Merge from emacs-24
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4dc7c8d5
SM
12012-07-17 Eli Zaretskii <eliz@gnu.org>
2
3 Remove FILE_SYSTEM_CASE.
4 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
5
6 * fileio.c (FILE_SYSTEM_CASE): Don't define.
7 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
8 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
9 call-process-region passes it through expand-file-name.
10
11 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
12
132012-07-17 Andreas Schwab <schwab@linux-m68k.org>
14
15 Fix crash when creating indirect buffer (Bug#11917)
16 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
17 Don't handle unbound variables specially if non-zero.
18 (Fbuffer_local_variables): Pass zero.
19 (clone_per_buffer_values): Pass non-zero.
20
212012-07-17 Andreas Schwab <schwab@linux-m68k.org>
22
23 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
24 to make the loop interruptible.
25
262012-07-17 Andreas Schwab <schwab@linux-m68k.org>
27
28 * gnutls.c (emacs_gnutls_handshake): Only retry if
29 GNUTLS_E_INTERRUPTED.
30
312012-07-17 Eli Zaretskii <eliz@gnu.org>
cce7fefc
DA
322012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
33
34 Cleanup and convert miscellaneous checks to eassert.
35 * alloc.c (mark_interval): Fix comment, partially rephrase
36 old comment from intervals.h (see below).
37 * intervals.c (find_interval, adjust_intervals_for_insertion)
38 (delete_interval, adjust_intervals_for_deletion)
39 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
40 Convert to eassert.
41 (adjust_intervals_for_insertion, make_new_interval):
42 Remove obsolete and unused code.
43 * intervals.h (struct interval): Remove obsolete comment.
44 * textprotp.c (erase_properties): Remove unused code.
45 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
46 (Fremove_list_of_text_properties): Convert to eassert.
47
9ea10cc3
CY
482012-07-17 Chong Yidong <cyd@gnu.org>
49
50 * editfns.c (Finsert_char): Doc fix.
51
3900d5de
DA
522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
53
54 Fix previous change to make Fmemory_free always accurate.
55 * alloc.c (make_interval): Update total_free_intervals.
56 (make_float): Likewise for total_free_floats.
57 (free_cons, Fcons): Likewise for total_free_conses.
58 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
59 Likewise for total_free_vector_bytes.
60 (Fmake_symbol): Likewise for total_free_symbols.
61 (bytes_free): Remove.
62
7098646f
DA
632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Simple free memory accounting feature.
66 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
67 (sweep_vectors): Accumulate size of free vectors.
68 (Fgarbage_collect): Setup bytes_free.
69 (Fmemory_free): New function.
70 (syms_of_alloc): Register it.
71
22657b40
DA
722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
73
74 Cleanup overlays checking.
75 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
76 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
77 eassert and OVERLAYP.
78 (sort_overlays): Change to use OVERLAYP.
79
ddfc8813
RK
802012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
81
82 * editfns.c (Finsert_char): Make it interactive, and make the
83 second arg optional. Copy interactive spec and docstring from
84 ucs-insert.
85
7c26cf3c
PE
862012-07-17 Paul Eggert <eggert@cs.ucla.edu>
87
88 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
89 Unlike the other wrapped functions, fabs has an unspecified
90 effect on errno.
91
5d127af9
JD
922012-07-16 Jan Djärv <jan.h.d@swipnet.se>
93
94 * nsterm.m (keyDown): Interpret flags without left/right bits
95 as the left key (Bug#11670).
96
6a0dd1d7
DA
972012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
98
99 Remove empty and useless init functions.
100 * lisp.h (init_character_once, init_fns, init_image)
101 (init_filelock, init_sound): Remove prototype.
102 * character.c (init_character_once): Remove.
103 * filelock.c (init_filelock): Likewise.
104 * fns.c (init_fns): Likewise.
105 * image.c (init_image): Likewise.
106 * sound.c (init_sound): Likewise.
107 * emacs.c (main): Adjust accordingly.
108
7a6136fd
DA
1092012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
110
111 * gtkutil.h: Tiny cleanups.
112 (use_old_gtk_file_dialog): Remove useless declaration.
113 (xg_uses_old_file_dialog): Add suggested const attribute.
114
ce811ad9
EZ
1152012-07-15 Eli Zaretskii <eliz@gnu.org>
116
117 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
118 (bidi_paragraph_init): Use it to limit search forward for a strong
119 directional character in abnormally large paragraphs full of
120 neutral or weak characters. (Bug#11943)
121
c9adfeaa
SF
1222012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
123
124 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
125 the toolbar (Bug#9451).
126 (xg_make_tool_item): Give the widget event box a transparent
127 background.
128
fff62aa9
DA
1292012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
130
131 Cleanup basic allocation variables and functions.
132 * alloc.c (ignore_warnings, init_intervals, init_float)
133 (init_cons, init_symbol, init_marker): Remove.
134 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
135 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
136 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
137 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
138 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
139 (staticidx, init_alloc_once, init_strings, free_ablock):
140 Remove redundant initialization.
141 * fns.c (init_weak_hash_tables): Remove.
142 * lisp.h (init_weak_hash_tables): Remove prototype.
143
9730daca
DA
1442012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
145
146 Use zero_vector where appropriate.
147 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
148 accordingly.
149 * lisp.h (zero_vector): New declaration.
150 * font.c (null_vector): Remove.
151 (syms_of_font): Remove initialization and staticpro.
152 (font_list_entities, font_find_for_lface): Change to use zero_vector.
153 * keymap.c (Faccessible_keymaps): Likewise.
154
2e2d2a13
LL
1552012-07-15 Leo Liu <sdl.web@gmail.com>
156
157 * fringe.c: Fix typo in comments.
158
cd276f6e
LL
1592012-07-14 Leo Liu <sdl.web@gmail.com>
160
161 * fringe.c: Add a new bitmap exclamation-mark.
162
5a1131d9
EZ
1632012-07-14 Eli Zaretskii <eliz@gnu.org>
164
165 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
166
167 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
168 (HAVE_MENUS): Don't define, defined by editing config.in with
169 msdos/sed2v2.inp.
170 (GMALLOC_INHIBIT_VALLOC): Don't define.
171 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
172
22e983b7
JB
1732012-07-14 Juanma Barranquero <lekktu@gmail.com>
174
175 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
176
5b3f250f
GM
1772012-07-14 Glenn Morris <rgm@gnu.org>
178
179 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
180 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
181 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
182
33d63ff4
GM
1832012-07-13 Glenn Morris <rgm@gnu.org>
184
5b633342
GM
185 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
186
33d63ff4
GM
187 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
188 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
189
b55b9f85
JD
1902012-07-13 Jan Djärv <jan.h.d@swipnet.se>
191
0dc8cf50
JD
192 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
193 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
194 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
195 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
196 where appropriate.
197 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
198 as boolean expression.
199 (x_set_window_size): Remove unused variable toolbar.
200 (ns_get_color_default, ns_mod_to_lisp): Remove.
201 (ns_mouse_position): Remove unused variables xchar and ychar.
202 (ns_compute_glyph_string_overhangs): Remove unused variable face.
203 (ns_set_vertical_scroll_bar): Remove unused variable count.
204 (ns_delete_terminal): Remove unused variable i.
205 (ns_term_init): Remove unused variables r, g and b.
206 (mouseDown): Remove unused variable window.
207 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
208 (initFrameFromEmacs): Remove unused variable vbextra.
209 (mouseEntered): Remove unused variables p and dpyinfo.
210 (mouseExited): Remove unused variables p and r.
211 (ns_define_frame_cursor, ns_clear_frame_area)
212 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
213 (menuDown): Assign [sender tag] to variable and cast the variable.
214
215 * nsterm.h (menuDown): Add id as type to argument sender.
216 (ns_display_info_for_name): Add Lisp_Object argument.
217 (ns_term_init): Add Lisp_Object argument.
218 (ns_map_event_to_object): Add void argument.
219 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
220 prototype with arguments and only declare if __OBJC__.
221 (nxatoms_of_nsselect): Add void argument.
222 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
223 (ns_alloc_autorelease_pool): Add void argument.
224 (ns_release_autorelease_pool): Add void* argument.
225 (ns_get_defaults_value): Add const char* argument.
226
227 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
228 (initFromContents): Use SSDATA where appropriate.
229 (ns_update_menubar): Add braces to ambigous if-else.
230 (initWithTitle): Put () around assignment in if statement.
231 (ns_menu_show): Remove unused variables window and keymap.
232 (update_frame_tool_bar): Remove unused variable selected_p.
233 (initWithContentRect): Remove unused variable this_cmd_name.
234
235 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
236 appropriate.
237 (setXBMColor): Remove unused variable len.
238 (setPixmapData): Put () around assignment in loop statement.
239
240 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
241 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
242 where appropriate.
243 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
244 around assignment in loop statement.
245 (nsfont_open): Remove unused variable i.
246 (nsfont_open): Remove unused variable len.
247 (nsfont_draw): Remove unused variable cs.
248
249 * nsfns.m (x_set_icon_name, ns_set_name_internal)
250 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
251 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
252 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
253 (Fns_font_name, Fns_perform_service)
254 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
255 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
256 (ns_set_name): Remove unused variable view.
257 (x_set_menu_bar_lines): Remove unused variable olines.
258 (x_set_tool_bar_lines): Remove unused variable root_window.
259 (Fns_list_colors): Put () around assignment in while statement.
260 (Fns_perform_service): Remove unused variable len.
261 (Fns_display_usable_bounds): Remove unused variable top.
262 (syms_of_nsfns): Remove unused variable i.
263
b55b9f85
JD
264 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
265 memcpy (Bug#11907).
266
ed9265fc 2672012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
268
269 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
270 and free it with DestroyExceptionInfo (Bug#11558).
271
ef099b57
JB
2722012-07-13 Juanma Barranquero <lekktu@gmail.com>
273
274 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
275 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
276 Set here, not in nt/config.nt.
277
ea814a5d
EZ
2782012-07-13 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
281 cursor overflow into the last glyph on display line when the right
282 fringe is off. (Bug#11832)
283
1a952767
PE
2842012-07-13 Paul Eggert <eggert@cs.ucla.edu>
285
286 * xdisp.c (produce_special_glyphs): Now static.
287 * dispextern.h (produce_special_glyphs): Remove decl.
288
983188fd
GM
2892012-07-13 Glenn Morris <rgm@gnu.org>
290
32fb4bb6
GM
291 * s/bsd-common, s/cygwin.h: Remove empty files.
292 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
293
983188fd
GM
294 * s/usg5-4-common.h (USG, USG5):
295 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
296 * s/sol2-6.h (SOLARIS2):
297 * s/irix6-5.h (IRIX6_5):
298 * s/hpux10-20.h (USG, USG5, HPUX):
299 * s/gnu-linux.h (USG, GNU_LINUX):
300 * s/freebsd.h (BSD_SYSTEM):
301 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
302 * s/cygwin.h (CYGWIN):
303 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
304 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
305
d1e68667 3062012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
307
308 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 309
6de0e799
GM
3102012-07-13 Glenn Morris <rgm@gnu.org>
311
739ae010
GM
312 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
313
dbee5793
GM
314 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
315
6de0e799
GM
316 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
317 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
318
b82da769
GM
3192012-07-12 Glenn Morris <rgm@gnu.org>
320
4fae5a7a 321 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
322
323 * process.c (init_process_emacs): Rename from init_process.
324 The old name is also the name of a Mach system call.
325 * lisp.h, emacs.c: Update for this name change.
326 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
327 longer needed.
328
5a979817
EZ
3292012-07-12 Eli Zaretskii <eliz@gnu.org>
330
331 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
332 memmove call that removes glyphs covered by the left truncation
333 glyph. Improve commentary.
334 (display_line): Fix display of continuation glyphs on GUI frames
335 when the right fringe is turned off and variable-size fonts are
336 used in the window. Move the code that appends a stretch glyph to
337 produce_special_glyphs, so that it could be used for truncation
338 and continuation glyphs alike.
339 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
340 glyph of a suitably computed width, to align the special glyphs at
341 the window margin. Code moved from display_line. (Bug#11832)
342
3e91a053
GM
3432012-07-12 Glenn Morris <rgm@gnu.org>
344
ba9e4b84
GM
345 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
346
347 * s/gnu-linux.h, s/hpux10-20.h:
348 Do not unconditionally define HAVE_XRMSETDATABASE.
349
3e91a053
GM
350 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
351
b300b1f4
PE
3522012-07-12 Paul Eggert <eggert@cs.ucla.edu>
353
354 Fix typos that broke OS X build.
355 Reported by Randal L. Schwartz in
356 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
357 * nsterm.m (ns_timeout): Add missing local decl.
358 (ns_get_color): snprintf -> sprintf, to fix typo.
359
6e777848
GM
3602012-07-12 Glenn Morris <rgm@gnu.org>
361
3f922c37
GM
362 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
363 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
364 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
365 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
366
0ab7b23a
GM
367 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
368 Move PTY_OPEN to configure.
369
6e777848
GM
370 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
371 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
372 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
373
4a7edc24
DA
3742012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Use empty_unibyte_string where applicable.
377 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
378 * lread.c (read1): Likewise.
379 * xsettings.c (syms_of_xsettings): Likewise.
380
308aab79
GM
3812012-07-12 Glenn Morris <rgm@gnu.org>
382
42bd1719
GM
383 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
384 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
385 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
386 * s/hpux10-20.h (RUN_TIME_REMAP):
387 * s/bsd-common.h (TABDLY): Move to configure.
388
389 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
390
391 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
392
ea0bbd17 393 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 394 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
395
396 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 397
308aab79
GM
398 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
399 * s/template.h: Move NARROWPROTO to configure.
400
ee1cf5cf
GM
4012012-07-11 Glenn Morris <rgm@gnu.org>
402
30fe9bf4
GM
403 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
404 unused since 2011-01-17 change to systty.h.
405
ee1cf5cf
GM
406 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
407 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
408 Move HAVE_PTYS and HAVE_SOCKETS to configure.
409
63e47e07
PE
4102012-07-11 Paul Eggert <eggert@cs.ucla.edu>
411
412 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
413
c43fb4c3
GM
4142012-07-11 Glenn Morris <rgm@gnu.org>
415
416 * s/darwin.h, s/gnu-linux.h, s/template.h:
417 Move INTERRUPT_INPUT to configure.
418
e8df9267
DA
4192012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
420
421 Minor adjustments to interning code.
422 * lisp.h (intern, intern_c_string): Redefine as static inline
423 wrappers for intern_1 and intern_c_string_1, respectively.
424 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
425 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
426 Vobarray checking.
e8df9267
DA
427 * font.c (font_intern_prop): Likewise. Adjust comment.
428 * w32font.c (intern_font_name): Likewise.
429
34348bd4
AS
4302012-07-11 Andreas Schwab <schwab@linux-m68k.org>
431
d96a1e0c
AS
432 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
433
34348bd4
AS
434 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
435 of Fcar/Fcdr if possible.
436 * font.c (check_otf_features): Likewise.
437 * fontset.c (Fnew_fontset): Likewise.
438 * gnutls.c (Fgnutls_boot): Likewise.
439 * minibuf.c (read_minibuf): Likewise.
440 * msdos.c (IT_set_frame_parameters): Likewise.
441 * xmenu.c (Fx_popup_dialog): Likewise.
442 * w32menu.c (Fx_popup_dialog): Likewise.
443
c8add24e
GM
4442012-07-11 Glenn Morris <rgm@gnu.org>
445
4b575b3c
GM
446 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
447 since nothing has defined it on these platforms.
448
09f4e3b0
GM
449 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
450 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
451
172bedef
GM
452 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
453 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
454 Move CLASH_DETECTION to configure.
455
249685df
GM
456 * s/gnu.h: Remove file, which is now empty.
457
c8add24e
GM
458 * s/gnu.h, s/gnu-linux.h:
459 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
460
b41253a3
JW
4612012-07-11 John Wiegley <johnw@newartisans.com>
462
463 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
464 function attribute, so we only use it if it exists in the
465 compiler.
466
d923b542
DA
4672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
468
469 Avoid call to strlen in fast_c_string_match_ignore_case.
470 * search.c (fast_c_string_match_ignore_case): Change to use
471 length argument. Adjust users accordingly.
472 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
473
5ebbef1d
PE
4742012-07-11 Paul Eggert <eggert@cs.ucla.edu>
475
bb352260
PE
476 Assume mkdir, rmdir.
477 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
478 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
479
57054ddd
PE
480 Assume rename.
481 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
482
b747d3f7
PE
483 Assume perror.
484 * s/hpux10-20.h (HAVE_PERROR): Remove.
485 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
486 Remove dummy definition, as this problem was obsolete long ago.
487
5ebbef1d
PE
488 Assume strerror.
489 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
490
984e7f30
DA
4912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
492
493 Avoid calls to strlen in font processing functions.
494 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 495 (font_open_by_name): Change to use length argument. Adjust
984e7f30 496 users accordingly.
d923b542
DA
497 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
498 Adjust prototypes.
499 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
500 Change to return ptrdiff_t.
984e7f30
DA
501 (xfont_list_pattern, xfont_match): Use length returned by
502 xfont_decode_coding_xlfd.
503 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
504
20e94fdd
GM
5052012-07-11 Glenn Morris <rgm@gnu.org>
506
9d596af3
GM
507 * s/darwin.h, s/freebsd.h, s/netbsd.h:
508 Move DONT_REOPEN_PTY to configure.
509
20e94fdd
GM
510 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
511 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
512
e99a530f
PE
5132012-07-10 Paul Eggert <eggert@cs.ucla.edu>
514
22ffb973
PE
515 Remove "#define unix" that is no longer needed (Bug#11905).
516 * s/aix4-2.h (unix): Remove; no longer needed.
517
e9a9ae03
PE
518 EMACS_TIME simplification (Bug#11875).
519 This replaces macros (which typically do not work in GDB)
520 with functions, typedefs and enums, making the code easier to debug.
521 The functional style also makes code easier to read and maintain.
522 * systime.h: Include <sys/time.h> on all hosts, not just if
523 WINDOWSNT, since 'struct timeval' is needed in general.
524 (EMACS_TIME): Now a typedef, not a macro.
525 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
526 not macros.
527 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
528 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
529 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
530 (EMACS_TIME_LE): Now functions, not macros.
531 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
532 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
533 which are not functions. All uses rewritten to use:
534 (make_emacs_time): New function.
535 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
536 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
537 not functions. All uses rewritten to use the following, respectively:
538 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
539 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 540 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
541 * fileio.c (Fcopy_file):
542 * xterm.c (XTflash): Get the current time closer to when it's used.
543 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
544
ffacb126
PE
545 * bytecode.c (targets): Suppress -Woverride-init warnings.
546
e99a530f
PE
547 Simplify by avoiding confusing use of strncpy etc.
548 * doc.c (Fsnarf_documentation):
549 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
550 * frame.c (Fmake_terminal_frame):
551 * gtkutil.c (get_utf8_string):
552 * lread.c (openp):
553 * nsmenu.m (ns_update_menubar):
554 * regex.c (regerror):
555 Prefer memcpy to strncpy and strncat when either will do.
556 * fileio.c (Fsubstitute_in_file_name):
557 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
558 (menu_separator_name_p):
559 * nsmenu.m (ns_update_menubar):
560 Prefer memcmp to strncmp when either will do.
561 * nsterm.m: Include <ftoastr.h>.
562 (ns_get_color):
563 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
564 Prefer snprintf to strncpy.
565 * nsterm.m (ns_term_init):
566 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
567 * nsterm.m (ns_term_init):
568 Avoid the need for strncpy, by using build_string or
569 make_unibyte_string directly. Use dtoastr, not snprintf.
570 * process.c (Fmake_network_process): Diagnose service names that
571 are too long, rather than silently truncating them or creating
572 non-null-terminated names.
573 (Fnetwork_interface_info): Likewise, for interface names.
574 * sysdep.c (system_process_attributes) [GNU_LINUX]:
575 Prefer sprintf to strncat.
576 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
577 Prefer vsnprintf to vsprintf + strncpy.
578
c59592b3
GM
5792012-07-10 Glenn Morris <rgm@gnu.org>
580
581 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
582 Clarify fallback case.
583
7d7bbefd
DA
5842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
587 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
588 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 589 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
590 where argument type is known to be a Lisp_Cons.
591
3a4c8000
TT
5922012-07-10 Tom Tromey <tromey@redhat.com>
593
594 * bytecode.c (BYTE_CODE_THREADED): New macro.
595 (BYTE_CODES): New macro. Replaces all old byte-code defines.
596 (enum byte_code_op): New type.
597 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
598 (exec_byte_code): Use them. Use token threading when applicable.
599
2a0213a6
DA
6002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
601
602 Optimize pure C strings initialization.
603 * lisp.h (make_pure_string): Fix prototype.
604 (build_pure_c_string): New function, defined as static inline. This
605 provides a better opportunity to optimize away calls to strlen when
606 the function is called with compile-time constant argument.
607 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
608 argument, adjust users accordingly. Use build_pure_c_string where
609 appropriate.
610 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
611 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
612 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
613
cb1caeaf
DA
6142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
615
616 Avoid calls to strlen in miscellaneous functions.
617 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
618 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
619 * lread.c (openp): Likewise.
620
c293e30c
DA
6212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
622
623 Avoid calls to strlen in path processing functions.
624 * fileio.c (file_name_as_directory): Add comment. Change to add
625 srclen argument and return the length of result. Adjust users
626 accordingly.
627 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 628 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
629 users accordingly.
630 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
631
9e059e3f
GM
6322012-07-10 Glenn Morris <rgm@gnu.org>
633
d02eb359
GM
634 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
635 Move PENDING_OUTPUT_COUNT definition to configure.
636
882cf227
GM
637 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
638 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
639 * s/gnu.h (DATA_START): Move definitions to configure.
640
af6e839f
GM
641 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
642 We include usg5-4-common.h, which defines them both.
643
40289a12
GM
644 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
645 O_RDONLY already includes it).
646
9e059e3f
GM
647 Stop ns builds setting the EMACSLOADPATH environment variable.
648 * nsterm.m (ns_load_path): Rename from ns_init_paths.
649 Now it does not set EMACSLOADPATH, just returns the load-path string.
650 * nsterm.h: Update accordingly.
651 * lread.c [HAVE_NS]: Include nsterm.h.
652 (init_lread) [HAVE_NS]: Use ns_load_path.
653 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
654
7c4e8ec0
GM
6552012-07-09 Glenn Morris <rgm@gnu.org>
656
d4f600ff
GM
657 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
658 since the included bsd-common.h does so.
659
cbb31951
GM
660 Stop ns builds setting the EMACSPATH environment variable.
661 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
662 (ns_init_paths): Do not set EMACSPATH.
663 * nsterm.h (ns_exec_path): Add it.
664 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
665 Use ns_exec_path.
666
7c4e8ec0
GM
667 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
668
26bccfae
PE
6692012-07-09 Paul Eggert <eggert@cs.ucla.edu>
670
a0bee46f
PE
671 * process.c (wait_reading_process_output): 'waitchannels' was unset
672 when read_kbd || !NILP (wait_for_cell); fix this.
673
5994c183
PE
674 Add GCC-style 'const' attribute to functions that can use it.
675 * character.h (char_resolve_modifier_mask):
676 * keyboard.h (make_ctrl_char):
677 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
678 (init_character_once, next_almost_prime, init_fns, init_image)
679 (flush_pending_output, init_sound):
680 * mem-limits.h (start_of_data):
681 * menu.h (finish_menu_items):
682 Add ATTRIBUTE_CONST.
683 * emacs.c (DEFINE_DUMMY_FUNCTION):
684 Declare the dummy function with ATTRIBUTE_CONST.
685 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
686 Add decls with ATTRIBUTE_CONST.
687
26bccfae
PE
688 Minor improvements to make_formatted_string.
689 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
690 where int is good enough, as vsprintf returns an int.
691 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
692
a8290ec3
DA
6932012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Use make_formatted_string to avoid double length calculation.
696 * lisp.h (make_formatted_string): New prototype.
697 * alloc.c (make_formatted_string): New function.
698 * buffer.c (Fgenerate_new_buffer_name): Use it.
699 * dbus.c (syms_of_dbusbind): Likewise.
700 * editfns.c (Fcurrent_time_zone): Likewise.
701 * filelock.c (get_boot_time): Likewise.
702 * frame.c (make_terminal_frame, set_term_frame_name)
703 (x_report_frame_params): Likewise.
704 * image.c (gs_load): Likewise.
705 * minibuf.c (get_minibuffer): Likewise.
706 * msdos.c (dos_set_window_size): Likewise.
707 * process.c (make_process): Likewise.
708 * xdisp.c (ensure_echo_area_buffers): Likewise.
709 * xsettings.c (apply_xft_settings): Likewise.
710
d01ba2f1
GM
7112012-07-09 Glenn Morris <rgm@gnu.org>
712
713 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
714 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
715 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
716 * nsterm.h (ns_etc_directory): Add it.
717 * callproc.c [HAVE_NS]: Include nsterm.h.
718 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
719
f1f924b6
DA
7202012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
721
722 Move marker debugging code under MARKER_DEBUG.
723 * marker.c (MARKER_DEBUG): Move marker debugging code under
724 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
725 for bootstrap with --enable-checking (~3x slowdown reported
726 by Juanma Barranquero <lekktu@gmail.com>).
727 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
728
ab531b66
PE
7292012-07-08 Paul Eggert <eggert@cs.ucla.edu>
730
731 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
732 See <http://bugs.gnu.org/11825#29>.
733
c4b3bc8a
EZ
7342012-07-08 Eli Zaretskii <eliz@gnu.org>
735
736 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
737 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
738 (display_line): Add commentary about displaying truncation glyphs
739 on GUI frames.
740 (produce_special_glyphs): Move here from term.c.
741
742 * term.c (produce_special_glyphs): Move to xdisp.c.
743
744 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
745 section.
c4b3bc8a 746
b676b881
AS
7472012-07-07 Andreas Schwab <schwab@linux-m68k.org>
748
f17c5273
AS
749 * xdisp.c (display_line): Avoid warning about implicit declaration
750 of FRAME_FONT.
751
298819b9
AS
752 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
753
b676b881
AS
754 * lisp.h: Remove empty conditional.
755
6045c4fd
PE
7562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
757
b3350bf9
PE
758 * lread.c (load_path_check): Now static.
759
6045c4fd
PE
760 Fix some minor --with-ns problems found by static checking.
761 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
762 (x_set_font) [!HAVE_X_WINDOWS]:
763 * image.c (xpm_load_image) [HAVE_NS]:
764 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
765 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
766 Remove unused local.
767 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
768 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
769 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
770 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
771 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
772 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
773 Fix pointer signedness problem.
774 * xfaces.c (FRAME_X_FONT_TABLE):
775 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
776
929e7845
GM
7772012-07-07 Glenn Morris <rgm@gnu.org>
778
779 * lread.c (load_path_check): New function, split from init_lread.
780 (init_lread): Reorganize. Motivation:
781 If EMACSLOADPATH is set, check/warn about that rather than the
782 defaults, which we are not going to use. Hence we can remove
783 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
784 Don't warn if site-lisp directories are missing.
785 If not installed, start from a blank load-path, since
786 PATH_LOADSEARCH refers to the eventual installation directories.
787
58dd0aa4
EZ
7882012-07-07 Eli Zaretskii <eliz@gnu.org>
789
790 Support truncation and continuation glyphs on GUI frames, when
791 fringes are disabled. (Bug#11832)
792 * xdisp.c (init_iterator): Get dimensions of truncation and
793 continuation glyphs even if on GUI frames. Adjust
794 it->last_visible_x on GUI frames when the left or right fringes,
795 or both, are absent.
796 (start_display, move_it_in_display_line_to): Handle the case of a
797 GUI frame without a fringe to display continuation or truncation
798 glyphs.
799 (insert_left_trunc_glyphs): Support GUI frames: make sure
800 truncation glyphs overwrite enough glyphs from the current line to
801 have sufficient space in pixels.
802 (display_line): Support truncation and continuation glyphs on GUI
803 frames. If some spare pixels are left on the line after inserting
804 the truncation glyphs, fill that space with a stretch glyph of a
805 suitably computed width.
806
807 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
808 produce_glyphs, to support GUI sessions.
809
31571fd7
PE
8102012-07-07 Paul Eggert <eggert@cs.ucla.edu>
811
5a16b9bc
PE
812 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
813
f3047c75
PE
814 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
815
31571fd7
PE
816 Do not require float-time's arg to fit in time_t (Bug#11825).
817 This works better on hosts where time_t is unsigned, and where
818 float-time is applied to the (negative) difference between two times.
819 * editfns.c (decode_time_components): Last arg is now double *,
820 not int *, and means to store all the result as a double, without
821 worrying about whether the seconds part fits in time_t.
822 All callers changed.
823 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
824 All callers changed.
825 (Ffloat_time): Do not fail merely because the specified time falls
826 outside of time_t range.
827
4516fbef
GM
8282012-07-07 Glenn Morris <rgm@gnu.org>
829
830 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
831 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
832 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
833
07adc2c6
JB
8342012-07-07 Juanma Barranquero <lekktu@gmail.com>
835
836 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
837 Update dependencies.
838
839 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
840
fd573f31
PE
8412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
842
fee5959d
PE
843 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
844 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
845 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
846 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
847 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
848 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
849
fd573f31
PE
850 * xfont.c (compare_font_names): Redo to omit the need for casts.
851
ddadbc0e
AS
8522012-07-06 Andreas Schwab <schwab@linux-m68k.org>
853
fca8d6b6
AS
854 * xfns.c (Fx_change_window_property): Doc fix.
855 * w32fns.c (Fx_change_window_property): Doc fix.
856
ddadbc0e
AS
857 * w32fns.c (Fx_window_property): Accept the same arguments as the
858 X Windows version. Doc fix.
859 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
860
ed9265fc 8612012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
862 Eli Zaretskii <eliz@gnu.org>
863
864 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
865 Windows-specific code from nt/config.nt moved here.
866 Obsolete settings removed.
867
216ee680
PE
8682012-07-06 Paul Eggert <eggert@cs.ucla.edu>
869
870 * process.c: Avoid unnecessary calls to gettime.
871 (wait_reading_process_output): Don't get the time of day
872 when gobbling data immediately and not waiting, as there's no need
873 for it in that case. This removes a FIXME.
874
bdd091e4
JD
8752012-07-06 Jan Djärv <jan.h.d@swipnet.se>
876
877 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
878 is defined (Bug#11768).
879
9d44f8ce
DA
8802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
881
882 Fix marker debugging code.
883 * marker.c (byte_char_debug_check): Do not perform the check
884 if buffer is not multibyte.
090bd7cb
JB
885 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
886 Call byte_char_debug_check with correct arguments.
9d44f8ce 887
90fc4786
DA
8882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
889
890 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
891 * marker.c (byte_char_debug_check, count_markers):
892 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
893 (byte_debug_flag): Remove.
894 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
895 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
896
7b7ae965
DA
8972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
898
4e57b342
DA
899 Avoid code repetition in marker-related functions.
900 * marker.c (attach_marker): New function.
901 (Fset_marker, set_marker_restricted, set_marker_both)
902 (set_marker_restricted_both): Use it.
903 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
904 Consistently rename charno to charpos.
905 (marker_position): Add eassert.
906 (marker_byte_position): Convert to eassert.
907
9082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
909
910 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 911 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 912 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 913
657924ff
DA
9142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
915
916 Introduce fast path for the widely used marker operation.
917 * alloc.c (build_marker): New function.
918 * lisp.h (build_marker): New prototype.
919 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
920 * composite.c (autocmp_chars): Likewise.
921 * editfns.c (buildmark): Remove.
922 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
923 (save_restriction_save): Use build_marker.
924 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
925 * window.c (save_window_save): Likewise.
926
041a49a6
DA
9272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
928
929 Do not use Fdelete_overlay in delete_all_overlays
930 to avoid redundant calls to unchain_overlay.
931 * buffer.c (drop_overlay): New function.
932 (delete_all_overlays, Fdelete_overlay): Use it.
933 * minibuf.c (get_minibuffer): Fix comment.
934
7dca65a4
PE
9352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
936
937 Port to OpenBSD 5.1 amd64.
938 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
939 This is needed for OpenBSD, and should be harmless on all BSD systems.
940 Also, include <sys/sysctl.h>, as it should be available on all
941 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
942 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
943 use p_pid member, not kp_proc.pid.
944
8eb876e2
GM
9452012-07-06 Glenn Morris <rgm@gnu.org>
946
947 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
948
38182d90
PE
9492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
950
951 More xmalloc and related cleanup.
952 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
953 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
954 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
955 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
956 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
957 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
958 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
959 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
960 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
961 * xterm.c:
962 Omit needless casts involving void * pointers and allocation.
963 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
964 as the former is more robust if P's type is changed.
965 Prefer xzalloc to xmalloc + memset 0.
966 Simplify malloc-or-realloc to realloc.
967 Don't worry about xmalloc returning a null pointer.
968 Prefer xstrdup to xmalloc + strcpy.
969 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
970 growing it.
971 * keyboard.c (apply_modifiers_uncached): Prefer local array to
972 alloca of a constant.
973
6dd5a677
EZ
9742012-07-05 Eli Zaretskii <eliz@gnu.org>
975
976 * xdisp.c (display_line): Fix horizontal pixel coordinates when
977 hscroll is larger than the line width. Fixes long and futile
978 looping inside extend_face_to_end_of_line (on a TTY) producing
979 glyphs that are not needed and thrown away.
980
6b312f0f
DA
9812012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
982
983 * marker.c (set_marker_restricted_both): Simplify by using
984 clip_to_bounds.
985
f520ef9b
PE
9862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
987
988 * editfns.c (region_limit): Simplify by using clip_to_bounds.
989
383b7c95
JD
9902012-07-05 Jan Djärv <jan.h.d@swipnet.se>
991
992 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
993 not defined (Bug#11768).
994 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
995 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
996 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
997 followed by gtk_box_set_homogeneous (Bug#11768).
998 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
999 (update_theme_scrollbar_width, xg_create_scroll_bar):
1000 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1001 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1002 (is_box_type): New function (Bug#11768).
1003 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1004 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1005 with default display (Bug#11768).
1006
d6e7bf45
EZ
10072012-07-05 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (window_hscroll_limited): New function.
1010 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1011 coordinates when window's hscroll is set to insanely large
1012 values. (Bug#11857)
1013
431391ec
JB
10142012-07-05 Juanma Barranquero <lekktu@gmail.com>
1015
1016 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1017 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1018
23f86fce
DA
10192012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 Cleanup xmalloc.
1022 * lisp.h (xzalloc): New prototype. Omit needless casts.
1023 * alloc.c (xzalloc): New function. Omit needless casts.
1024 * charset.c: Omit needless casts. Convert all calls to
1025 xmalloc with following memset to xzalloc.
1026 * dispnew.c: Likewise.
1027 * fringe.c: Likewise.
1028 * image.c: Likewise.
1029 * sound.c: Likewise.
1030 * term.c: Likewise.
1031 * w32fns.c: Likewise.
1032 * w32font.c: Likewise.
1033 * w32term.c: Likewise.
1034 * xfaces.c: Likewise.
1035 * xfns.c: Likewise.
1036 * xterm.c: Likewise.
1037 * atimer.c: Omit needless casts.
1038 * buffer.c: Likewise.
1039 * callproc.c: Likewise.
1040 * ccl.c: Likewise.
1041 * coding.c: Likewise.
1042 * composite.c: Likewise.
1043 * doc.c: Likewise.
1044 * doprnt.c: Likewise.
1045 * editfns.c: Likewise.
1046 * emacs.c: Likewise.
1047 * eval.c: Likewise.
1048 * filelock.c: Likewise.
1049 * fns.c: Likewise.
1050 * gtkutil.c: Likewise.
1051 * keyboard.c: Likewise.
1052 * lisp.h: Likewise.
1053 * lread.c: Likewise.
1054 * minibuf.c: Likewise.
1055 * msdos.c: Likewise.
1056 * print.c: Likewise.
1057 * process.c: Likewise.
1058 * region-cache.c: Likewise.
1059 * search.c: Likewise.
1060 * sysdep.c: Likewise.
1061 * termcap.c: Likewise.
1062 * terminal.c: Likewise.
1063 * tparam.c: Likewise.
1064 * w16select.c: Likewise.
1065 * w32.c: Likewise.
1066 * w32reg.c: Likewise.
1067 * w32select.c: Likewise.
1068 * w32uniscribe.c: Likewise.
1069 * widget.c: Likewise.
1070 * xdisp.c: Likewise.
1071 * xmenu.c: Likewise.
1072 * xrdb.c: Likewise.
1073 * xselect.c: Likewise.
1074
0497dc44
PE
10752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * fileio.c (time_error_value): Check the right error number.
1078 Problem reported by Troels Nielsen in
1079 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1080
356e7178
PE
10812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1082
4e71fd89
PE
1083 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1084 This should be fixed in a better way; see Eli Zaretskii in
1085 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1086 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1087
f0941253
PE
1088 * fileio.c (time_error_value): Rename from special_mtime.
1089 The old name's problems were noted by Eli Zaretskii in
1090 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1091
065c9eb4
PE
1092 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1093 This variable's comment says Emacs needs at least one GDB-visible
1094 symbol of type enum pvec_type, to work around GDB problems.
1095 The symbol's value doesn't matter.
1096
356e7178
PE
1097 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1098 that causes compilation to fail on pre-C99 compilers.
1099
ed9265fc 11002012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1101
1102 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1103 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1104
3884d954
DA
11052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1106
d209e2fb 1107 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1108 headers for buffer_defaults and buffer_local_symbols.
1109 Reported by Juanma Barranquero <lekktu@gmail.com>.
1110
ee28be33
SM
11112012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1112
1113 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1114 * lisp.h (enum pvec_type): Use fewer bits.
1115 (PSEUDOVECTOR_SIZE_BITS): New constant.
1116 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1117 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1118 change in pvec_type.
1119 (PSEUDOVECTOR_TYPEP): New macro.
1120 (TYPED_PSEUDOVECTORP): Use it.
1121 * fns.c (internal_equal): Adapt code to extract pvectype.
1122 * emacs.c (gdb_pvec_type): Update type.
1123 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1124 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1125 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1126 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1127 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1128 abusing vector->header.next.nbytes.
1129 (live_vector_p): Use PVEC_TYPE.
1130 (mark_object): Adapt code to extract pvectype. Use switch.
1131
c7f2cd7f
PE
11322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1135 Tighten new eassert a bit.
1136
8ce70ed2
DA
11372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 Fix compilation with --enable-gcc-warnings and -O1
1140 optimization level.
1141 * doprnt.c (doprnt): Change type of tem to int, initialize
1142 to avoid compiler warning. Add eassert.
1143 * search.c (simple_search): Initialize match_byte to avoid
1144 compiler warning. Add eassert.
1145
dea7f1e5
PE
11462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1147
24a212eb
PE
1148 Avoid weird behavior with large horizontal scrolls.
1149 Without this change, for example, large hscroll values would
1150 mess up Emacs's display on Fedora 15 x86, presumably due to
1151 overflows in int calculations in the display code.
1152 Also, if buffers had long lines, Emacs would freeze.
1153 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1154 (set_window_hscroll): New function, containing the old guts of
1155 Fset_window_hscroll. Return the clipped value.
1156 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1157 This avoids the need to check against PTRDIFF_MAX.
1158
dea7f1e5
PE
1159 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1160
76046526
DA
11612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1162
1163 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1164
39adff0d
PE
11652012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1166
63807d47
PE
1167 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1168 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1169 since GCC 4.4.6 issues a bogus warning for them.
1170
39adff0d
PE
1171 Fix bugs in file timestamp newness comparisons.
1172 * fileio.c (Ffile_newer_than_file_p):
1173 * lread.c (Fload): Use full timestamp resolution of files,
1174 not just the 1-second resolution, so that files that are only
1175 slightly newer still count as newer.
1176 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1177 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1178
dbeed9a6
PE
11792012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * fileio.c: Improve handling of file time marker. (Bug#11852)
1182 (special_mtime): New function.
1183 (Finsert_file_contents, Fverify_visited_file_modtime):
1184 Use it to set special mtime values consistently.
1185
636334d6
AS
11862012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1187
1188 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1189 marker for non-existing file. (Bug#11852)
1190
e2017fe2
GM
11912012-07-03 Glenn Morris <rgm@gnu.org>
1192
1193 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1194 and did not make it into globals.h).
1195
404dbd37
TT
11962012-07-03 Tom Tromey <tromey@redhat.com>
1197
1198 * window.c (Fset_window_margins, Fset_window_fringes)
1199 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1200 * textprop.c (Fprevious_property_change): No longer static.
1201 * syntax.c (Fsyntax_table_p): No longer static.
1202 * process.c (Fget_process, Fprocess_datagram_address): No longer
1203 static.
1204 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1205 * keyboard.c (Fcommand_execute): No longer static.
1206 Remove EXFUN.
1207 * insdel.c (Fcombine_after_change_execute): No longer static.
1208 * image.c (Finit_image_library): No longer static.
1209 * fileio.c (Fmake_symbolic_link): No longer static.
1210 * eval.c (Ffetch_bytecode): No longer static.
1211 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1212 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1213 No longer static.
404dbd37
TT
1214 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1215 static.
1216 * dired.c (Ffile_attributes): No longer static.
1217 * composite.c (Fcomposition_get_gstring): No longer static.
1218 * callproc.c (Fgetenv_internal): No longer static.
1219
1220 * ccl.h: Remove EXFUNs.
1221 * buffer.h: Remove EXFUNs.
1222 * dispextern.h: Remove EXFUNs.
1223 * intervals.h: Remove EXFUNs.
1224 * fontset.h: Remove EXFUN.
1225 * font.h: Remove EXFUNs.
1226 * dosfns.c (system_process_attributes): Remove EXFUN.
1227 * keymap.h: Remove EXFUNs.
1228 * lisp.h: Remove EXFUNs.
1229 * w32term.h: Remove EXFUNs.
1230 * window.h: Remove EXFUNs.
1231 * xsettings.h: Remove EXFUN.
1232 * xterm.h: Remove EXFUN.
1233
8e4fd1e1
GM
12342012-07-03 Glenn Morris <rgm@gnu.org>
1235
1236 * lisp.h (Frandom): Make it visible to C.
1237 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1238 buffer for invisible buffers. (Bug#1229)
1239
ca95b3eb
DA
12402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1241
1242 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1243 values which aren't power of 2.
1244 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1245 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1246 accordingly.
1247
7555c33f
SM
12482012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1249
1250 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1251
1252 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1253
d12e8f5a
DA
12542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1255
1256 * alloc.c (allocate_vector_block): Remove redundant
1257 calls to mallopt if DOUG_LEA_MALLOC is defined.
1258 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1259 avoid calls to mallopt if zero_vector is returned.
1260
296094c3
DA
12612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1262
1263 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1264 is enabled, avoid dereferencing NULL current_sblock if
1265 running undumped.
1266
36429c89
DA
12672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 Cleanup basic buffer management.
1270 * buffer.h (struct buffer): Change layout to use generic vector
1271 marking code. Fix some comments. Change type of 'clip_changed'
1272 to bitfield. Remove unused #ifndef old.
1273 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1274 (GET_OVERLAYS_AT): Fix indentation.
1275 (for_each_per_buffer_object_at): New macro.
1276 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1277 (Fbuffer_local_variables): Use it.
1278 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1279 * alloc.c (allocate_buffer): Adjust to match new layout of
1280 struct buffer. Fix comment.
1281 (mark_overlay): New function.
1282 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1283 Lisp area of struct buffer.
1284 (mark_object): Use it. Adjust marking of misc objects
1285 and related comments.
1286
3b3e4cac
PE
12872012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1290 wrapper that is not needed because the wrapped code is a no-op (zero
1291 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1292 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1293
cf5c0175
DA
12942012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 * alloc.c (mark_buffer): Simplify. Remove prototype.
1297 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1298 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1299 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1300 redundant calls to mark_vectorlike for bool vectors.
1301
ca26824c
GM
13022012-06-30 Glenn Morris <rgm@gnu.org>
1303
2e4c5312
GM
1304 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1305
ca26824c
GM
1306 * epaths.in (PATH_SITELOADSEARCH): New.
1307 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1308 This is rather than relying on --enable-locallisppath elements
1309 having "site-lisp" in their names. (Bug#10208#25, 11658)
1310
0d23c240
EZ
13112012-06-30 Eli Zaretskii <eliz@gnu.org>
1312
c9240d7a
EZ
1313 * w32proc.c (sys_select): Accept and ignore one more argument.
1314
1315 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1316
0d23c240 1317 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1318 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1319
1320 * sysdep.c: Don't include dos.h and dosfns.h.
1321
1322 * process.c (sys_select):
1323 * msdos.c (sys_select): Accept one more argument and ignore it.
1324
1325 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1326 adapt data types and code to that.
1327
1328 * dosfns.c:
1329 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1330 which clashes with the gnulib function of the same name.
1331
af5a5a98
AS
13322012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1333
c5e4379c
AS
1334 * font.c (font_style_to_value, font_style_symbolic)
1335 (font_prop_validate_style): Add type checks for values in
1336 font_style_table.
1337
af5a5a98
AS
1338 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1339 argument.
1340 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1341 uses.
1342
8d38f461
EZ
13432012-06-29 Eli Zaretskii <eliz@gnu.org>
1344
2e5a6631
EZ
1345 * xdisp.c (try_window_id): Undo last change.
1346
8d38f461
EZ
1347 * w32.c (getwd): Adjust commentary about startup_dir.
1348 (init_environment): Always call sys_access, even in non-MSVC
1349 builds. Don't chdir to the directory of the Emacs executable.
1350 This undoes code from 1997 which was justified by the need to
1351 "avoid conflicts when removing and renaming directories". But its
1352 downside was that every relative file name was being interpreted
1353 relative to the directory of the Emacs executable, which can never
1354 be TRT. In particular, it broke sys_access when called with
1355 relative file names.
1356 (sys_access): Map GetLastError to errno.
1357
2af3565e
DA
13582012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1359
1360 * window.h (struct window): Change type of 'fringes_outside_margins'
1361 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1362 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1363 Adjust comment.
1364 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1365 to ptrdiff_t.
1366
c8d3a25c 13672012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1368
c8d3a25c
GM
1369 * gnutls.c (emacs_gnutls_handshake):
1370 Add QUIT to make the loop interruptible.
57570cd3 1371
c8d3a25c 13722012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1373
c8d3a25c
GM
1374 * charset.c (init_charset): Make lack of etc/charsets fatal.
1375
3e984ee8
DA
13762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1377
1378 * editfns.c (region_limit): Fix type mismatch.
1379
ef884f23
DA
13802012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1383 undefined. Convert from xassert to eassert.
1384 * nsmenu.m: Convert from xassert to eassert.
1385 * nsterm.m: Likewise.
1386
7d7e0027
SM
13872012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1388
1389 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1390
aa754e6a
PE
13912012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 Avoid integer overflow on scroll-left and scroll-right.
1394 * window.c (HSCROLL_MAX): New macro.
1395 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1396 overflow when requested scroll falls outside ptrdiff_t range.
1397
80b00b08
DA
13982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1399
1400 * window.h (struct window): Change type of 'hscroll',
1401 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1402 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1403 Adjust users accordingly.
1404 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1405 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1406 from EMACS_INT to ptrdiff_t.
1407 (make_window): Omit redundant initialization.
1408
62b2bcf6
JB
14092012-06-28 Juanma Barranquero <lekktu@gmail.com>
1410
1411 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1412
45942c7d
DA
14132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1414
1415 * window.h (struct window): Change type of 'use_time' and
1416 'sequence_number' from Lisp_Object to int.
1417 * frame.c (make_frame): Adjust users accordingly.
1418 * print.c (print_object): Likewise.
1419 * window.c (select_window, Fwindow_use_time, make_parent_window)
1420 (make_window): Likewise.
1421
e509cfa6
DA
14222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1423
1424 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1425 enabled with --enable-checking=[all,glyphs] configure option.
1426 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1427 adjust comments accordingly.
1428 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1429 undefined, adjust comments accordingly.
1430 * image.c: Likewise.
1431 * scroll.c: Likewise.
1432 * w32fns.c: Likewise.
1433 * w32term.c: Likewise.
1434 * xdisp.c: Likewise.
1435 * xfaces.c: Likewise.
1436 * xfns.c: Likewise.
1437 * xterm.c: Likewise.
1438
a54e2c05
DA
14392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1440
1441 Generalize run-time debugging checks.
1442 * dispextern.h (XASSERTS): Remove.
1443 * fontset.c (xassert): Remove.
1444 Convert from xassert to eassert.
1445 * alloc.c: Convert from xassert to eassert.
1446 * bidi.c: Likewise.
1447 * dispnew.c: Likewise.
1448 * fns.c: Likewise.
1449 * fringe.c: Likewise.
1450 * ftfont.c: Likewise.
1451 * gtkutil.c: Likewise.
1452 * image.c: Likewise.
1453 * keyboard.c: Likewise.
1454 * menu.c: Likewise.
1455 * process.c: Likewise.
1456 * scroll.c: Likewise.
1457 * sound.c: Likewise.
1458 * term.c: Likewise.
1459 * w32console.c: Likewise.
1460 * w32fns.c: Likewise.
1461 * w32term.c: Likewise.
1462 * window.c: Likewise.
1463 * xdisp.c: Likewise.
1464 * xfaces.c: Likewise.
1465 * xfns.c: Likewise.
1466 * xselect.c: Likewise.
1467 * xterm.c: Likewise.
1468
1ec4b7b2
SM
14692012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1470
1471 * fns.c (maybe_resize_hash_table): Output message when growing the
1472 purify-hashtable.
1473
2014308a
DA
14742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1475
1476 * alloc.c (allocate_string_data): Remove dead code.
1477 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1478 avoid GCC warning about unused macro.
1479
246155eb
DA
14802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1481
1482 * alloc.c (allocate_string): Omit intervals initialization.
1483 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1484 as in make_pure_string and make_pure_c_string.
1485
43184b7b
DA
14862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1487
d209e2fb 1488 * alloc.c (allocate_string): Fix last change.
43184b7b 1489
3fe6dd74
DA
14902012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1491
d209e2fb 1492 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1493 to memset, add explicit initialization where appropriate.
1494
1ba6038a
GM
14952012-06-27 Glenn Morris <rgm@gnu.org>
1496
1497 * lisp.mk (lisp): Remove paths.elc.
1498
c89926a5
CY
14992012-06-27 Chong Yidong <cyd@gnu.org>
1500
1501 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1502
ed6b3510
JW
15032012-06-26 John Wiegley <johnw@newartisans.com>
1504
1ec4b7b2 1505 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1506 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1507
ed6b3510
JW
1508 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1509 when building with Clang.
1510
8edd4a2b
SM
15112012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1512
1513 * eval.c (Fapply): Allow calling it with a single argument.
1514
f6f62d1b
EZ
15152012-06-26 Eli Zaretskii <eliz@gnu.org>
1516
1517 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1518 _stricmp and _strnicmp.
1519 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1520
62efea5e
DA
15212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1522
1523 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1524 allocated window.
1525 (allocate_process): Likewise for new process.
8edd4a2b 1526 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1527 (allocate_frame): Likewise.
1528 * frame.c (make_frame): Omit redundant initialization.
1529 * window.c (make_parent_window): Use memset.
1530 (make_window): Omit redundant initialization.
1531 * process.c (make_process): Omit redundant initialization.
1532 * terminal.c (create_terminal): Likewise.
1533
42997f4d
DA
15342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 * term.c (delete_tty): Remove redundant call to memset.
1537
1130ecfc
DA
15382012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 * alloc.c: Remove build_string.
1541 * lisp.h: Define build_string as static inline. This provides
1542 a better opportunity to optimize away calls to strlen when the
1543 function is called with compile-time constant argument.
1544 * image.c (imagemagick_error): Convert to build_string.
1545 * w32proc.c (sys_spawnve): Likewise.
1546 * xterm.c (x_term_init): Likewise.
1547
cf38a720
PE
15482012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1549
99027bdd
PE
1550 Use sprintf return value instead of invoking strlen on result.
1551 In the old days this wasn't portable, since some sprintf
1552 implementations returned char *. But they died out years ago and
1553 Emacs already assumes sprintf returns int.
1554 Similarly for float_to_string.
1555 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1556 * ccl.c (ccl_driver):
1557 * character.c (string_escape_byte8):
1558 * data.c (Fnumber_to_string):
1559 * doprnt.c (doprnt):
1560 * print.c (print_object):
1561 * xdisp.c (message_dolog):
1562 * xfns.c (syms_of_xfns):
1563 Use sprintf or float_to_string result to avoid need to call strlen.
1564 * data.c (Fnumber_to_string):
1565 Use make_unibyte_string, since the string must be ASCII.
1566 * lisp.h, print.c (float_to_string): Now returns int length.
1567 * term.c (produce_glyphless_glyph):
1568 Use sprintf result rather than recomputing it.
1569
cf38a720
PE
1570 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1571 * Makefile.in (ALL_CFLAGS):
1572 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1573 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1574
3511c784
DA
15752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1576
0a08eb21 1577 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1578 strcasecmp if available.
1579 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1580
fb7da12e
AS
15812012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1582
1583 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1584 Avoid comma operator.
1585 * menu.c (push_submenu_start, push_submenu_end)
1586 (push_left_right_boundary, push_menu_pane): Likewise.
1587 * msdos.c (dos_rawgetc): Likewise.
1588
afa2ffd8
DA
15892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 * xfns.c (xic_create_fontsetname): Remove redundant calls
1592 to memset.
1593
b3b4476b
PE
15942012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1595
4495ff38
PE
1596 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1597 sprintf already null-terminates its output.
1598
b3b4476b
PE
1599 * xfns.c (x_window): Remove redundant cast.
1600
b00876c9
DA
16012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1602
1603 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1604 `const char *' to `char *' to avoid compiler warning.
1605
d188e26b
PE
16062012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1607
885d1d74
PE
1608 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1609 instead of truncating it to 63 (admittedly a generous limit).
1610
d188e26b
PE
1611 * process.c: Fix spelling and caps in comments.
1612
e2f560b1
DN
16132012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1614
e86db54b 1615 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1616 * sysdep.c (setpgrp): Remove definition, not used in this file.
1617
7583a3a1
JB
16182012-06-24 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * makefile.w32-in: Update dependencies.
1621
696056c2
EZ
16222012-06-24 Eli Zaretskii <eliz@gnu.org>
1623
1624 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1625 (SYSTIME_H): Add nt/inc/sys/time.h.
1626
1627 * systime.h [WINDOWSNT]: Include sys/time.h.
1628
1629 * s/ms-w32.h (struct timespec): Definition moved from
1630 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1631
845ca893
PE
16322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1635 * buffer.h (buffer_slot_type_mismatch):
1636 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1637 * eval.c (unwind_to_catch):
1638 * image.c (my_png_error, my_error_exit):
1639 * keyboard.c (quit_throw_to_read_char, user_error)
1640 (Fexit_recursive_edit, Fabort_recursive_edit):
1641 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1642 (wrong_type_argument, buffer_overflow, __executable_start)
1643 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1644 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1645 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1646 (fatal):
1647 (child_setup) [!DOS_NT]:
1648 * lread.c (end_of_file_error, invalid_syntax):
1649 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1650 * puresize.h (pure_write_error):
1651 * search.c (matcher_overflow):
1652 * sound.c (sound_perror, alsa_sound_perror):
1653 * sysdep.c, syssignal.h (croak):
1654 * term.c (maybe_fatal, vfatal):
1655 * textprop.c (text_read_only):
1656 * undo.c (user_error):
1657 * unexmacosx.c (unexec_error):
1658 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1659 Use _Noreturn rather than NO_RETURN.
1660 No need for separate decl merely because of _Noreturn.
1661 * sound.c (sound_warning, parse_sound):
1662 Remove unnecessary forward decls.
1663
f1dd8073
PE
16642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1667 * lisp.h (WAIT_READING_MAX): New macro.
1668 * dispnew.c (Fsleep_for, sit_for):
1669 * keyboard.c (kbd_buffer_get_event):
1670 * process.c (Faccept_process_output):
1671 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1672 This improves on the previous patch, which introduced a bug
1673 when time_t is unsigned and as wide as intmax_t.
1674 See <http://bugs.gnu.org/9000#51>.
1675
b82c1755
EZ
16762012-06-23 Eli Zaretskii <eliz@gnu.org>
1677
1678 * dispnew.c (sit_for, Fsleep_for):
1679 * keyboard.c (kbd_buffer_get_event):
1680 * process.c (Faccept_process_output): Avoid compiler warnings when
1681 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1682
ca300656
JB
16832012-06-23 Juanma Barranquero <lekktu@gmail.com>
1684
049ec95b
JB
1685 * makefile.w32-in: Update dependencies.
1686
ca300656
JB
1687 * w32.c (ltime): Add return type and declare static.
1688 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1689
db7b8d06
PE
16902012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1693 Privately reported by Herbert J. Skuhra.
1694 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1695 All uses changed.
1696 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1697 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1698
0bd8297f
EZ
16992012-06-23 Eli Zaretskii <eliz@gnu.org>
1700
96512555
EZ
1701 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1702 last argument of make_unibyte_string.
1703
0bd8297f
EZ
1704 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1705 language ID in the event parameters.
1706
1707 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1708 event.code, not the obscure "character set ID".
1709
63def6b6
CY
17102012-06-23 Chong Yidong <cyd@gnu.org>
1711
1712 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1713
e8a02204
EZ
17142012-06-23 Eli Zaretskii <eliz@gnu.org>
1715
388cdec0
EZ
1716 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1717 * w32.c (fdutimens): New function.
1718
1719 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1720
1721 * s/ms-w32.h (pselect): Redirect to sys_select.
1722
1723 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1724
e8a02204
EZ
1725 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1726 in the logic of incrementing and decrementing the value of
1727 use_relocatable_buffers.
1728
d054f3fb
PE
17292012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1732 Privately reported by Herbert J. Skuhra.
1733 [__FreeBSD__]: Remove "*/" typo after "#include".
1734 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1735 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1736 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1737 Don't assume EMACS_TIME and struct timeval are the same type.
1738
d35af63c
PE
17392012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 Support higher-resolution time stamps (Bug#9000).
1742 The time stamps are only nanosecond-resolution at the C level,
1743 since that's the best that any real-world system supports now.
1744 But they are picosecond-resolution at the Lisp level, as that's
1745 easy, and leaves room for future OS improvements.
1746
1747 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1748 (LIBES): Use it.
1749
1750 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1751 Don't get current time unless it's needed.
1752
1753 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1754 now provides it if it's absent.
1755 (start_atimer): Port to higher-res time stamps.
1756 Check for time stamp overflow. Don't get current time more
1757 often than is needed.
1758
1759 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1760 Include systime.h, not time.h.
1761 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1762
1763 * dired.c: Include stat-time.h.
1764 (Ffile-attributes): File times now have higher resolution.
1765
1766 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1767 (struct image): Timestamp now has higher resolution.
1768
1769 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1770 has at least microseconds now. All uses removed.
1771 (update_frame, update_single_window, update_window, update_frame_1)
1772 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1773
1774 * editfns.c (time_overflow): Now extern.
1775 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1776 (float-time, Fformat_time_string, Fcurrent_time_string)
1777 (Fcurrent_time_zone): Accept and generate higher-resolution
1778 time stamps.
1779 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1780 (decode_time_components, lisp_seconds_argument): New functions.
1781 (make_time): Now static.
1782 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1783 Report an error if the time is invalid, rather than having the caller
1784 do that.
1785
1786 * fileio.c: Include <stat-time.h>
1787 (Fcopy_file): Copy higher-resolution time stamps.
1788 Prefer to set the time stamp via a file descriptor if that works.
1789 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1790 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1791 (Fvisited_file_modtime, Fset_visited_file_modtime):
1792 Support higher-resolution time stamps.
1793
1794 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1795
1796 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1797
1798 * image.c (prepare_image_for_display, clear_image_cache)
1799 (lookup_image): Port to higer-resolution time stamps.
1800
1801 * keyboard.c (start_polling, bind_polling_period):
1802 Check for time stamp overflow.
1803 (read_char, kbd_buffer_get_event, timer_start_idle)
1804 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1805 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1806 Port to higher-resolution time stamps. Do not assume time_t is signed.
1807 (decode_timer): New function. Timers are now vectors of length 9,
1808 not 8, to accommodate the picosecond component.
1809 (timer_check_2): Use it.
1810
1811 * nsterm.m (select_timeout, timeval_subtract): Remove.
1812 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1813 as they're a bit more accurate and handle overflow better.
1814 (ns_select): Change prototype to be compatible with pselect.
1815 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1816 * nsterm.h (ns_select): Adjust prototype.
1817
1818 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1819 us-resolution time stamps.
1820 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1821
1822 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1823
1824 * lisp.h (time_overflow): New decl.
1825 (wait_reading_process_output): First arg is now intmax_t, not int,
1826 to accommodate larger waits.
1827
1828 * process.h (struct Lisp_Process.read_output_delay):
1829 Now counts nanoseconds, not microseconds.
1830 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1831 EMACS_HAS_USECS.
1832 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1833 (wait_reading_process_output):
1834 Port to ns-resolution time stamps.
1835 (Faccept_process_output, wait_reading_process_output):
1836 Check for time stamp overflow. Do not assume time_t is signed.
1837 (select_wrapper): Remove; we now use pselect.
1838 (Fprocess_attributes): Now generates ns-resolution time stamps.
1839
1840 * sysdep.c: Include utimens.h. Don't include utime.h
1841 or worry about struct utimbuf; gnulib does that for us now.
1842 (gettimeofday): Remove; gnulib provides a substitute.
1843 (make_timeval): New function.
1844 (set_file_times): Now sets ns-resolution time stamps.
1845 New arg FD; all uses changed.
1846 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1847 (system_process_attributes):
1848 Now returns ns-resolution time stamp. All uses changed.
1849 Check for time stamp overflow.
1850
1851 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1852 provides a substitute now.
1853
1854 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1855 since it guarantees struct timespec.
1856 (EMACS_TIME): Now struct timespec, so that we can support
1857 ns-resolution time stamps.
1858 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1859 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1860 (EMACS_USECS): Remove.
1861 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1862 so multiply the arg by 1000 before storing it.
1863 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1864 New macros.
1865 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1866 Port to ns-resolution time stamps.
1867 (EMACS_TIME_NEG_P): Remove; replaced by....
1868 (EMACS_TIME_SIGN): New macro.
1869 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1870 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1871 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1872 (make_timeval, make_lisp_time, decode_time_components): New decls.
1873 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1874 that it mishandled time_t overflow. You can't compare by subtracting!
1875 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1876 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1877
1878 * term.c: Include <sys/time.h>.
1879 (timeval_to_Time): New function, for proper overflow wraparound.
1880 (term_mouse_position, term_mouse_click): Use it.
1881
1882 * undo.c (record_first_change): Support higher-resolution time stamps
1883 in the undo buffer.
1884 (Fprimitive_undo): Use them when restoring time stamps.
1885
1886 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1887 (w32_get_internal_run_time):
1888 Port to higher-resolution Emacs time stamps.
1889 (ltime): Now accepts single 64-bit integer, as that's more convenient
1890 for callers.
1891
1892 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1893
1894 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1895 for compatibility with pselect. Support ns-resolution time stamps.
1896
1897 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1898
1899 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1900 Check for time stamp overflow, and support ns-resolution time stamps.
1901
1902 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1903 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1904 (timeval_subtract): Remove; no longer needed.
1905 (XTflash, XTring_bell, x_wait_for_event):
1906 Port to ns-resolution time stamps. Don't assume time_t is signed.
1907
b6a92dfe
CY
19082012-06-22 Chong Yidong <cyd@gnu.org>
1909
1910 * xdisp.c (x_consider_frame_title): Revert last change.
1911
d251c37c
EZ
19122012-06-22 Eli Zaretskii <eliz@gnu.org>
1913
1914 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1915 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1916 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1917 staticidx goes up to 1597 out of 1600 = 0x640.)
1918
f10deafb
PE
19192012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1922 Otherwise, the umask might be mistakenly 0 while handling input signals.
1923
ec6de1e2
SM
19242012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1925
1926 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1927
28be1ada
DA
19282012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1929
1930 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1931 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1932 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1933 access to `contents' member of Lisp_Vector objects with AREF and ASET
1934 where appropriate.
1935
c6bf3022
CY
19362012-06-19 Chong Yidong <cyd@gnu.org>
1937
1938 * frame.c (delete_frame): When selecting a frame on a different
1939 text terminal, do not alter the terminal's top-frame.
1940
1941 * xdisp.c (format_mode_line_unwind_data): Record the target
1942 frame's selected window and its terminal's top-frame.
1943 (unwind_format_mode_line): Restore them.
1944 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1945 Callers changed.
1946 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1947 since tty frames can be explicitly named.
1948 (prepare_menu_bars): Likewise.
1949
1950 * term.c (Ftty_top_frame): New function.
1951
defd4196
PE
19522012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 Port byte-code-meter to modern targets.
1955 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1956 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1957 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1958 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1959 (METER_1, METER_2): Simplify.
1960
1053a871
SM
19612012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1962
1963 * data.c (Fdefalias): Return `symbol' (bug#11686).
1964
b7e8d081
MR
19652012-06-18 Martin Rudalics <rudalics@gmx.at>
1966
1967 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1968 gets killed during executing of this function (Bug#11665).
1969 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1970 (Vkill_buffer_query_functions): In doc-string say that functions
1971 run by this hook should not change the current buffer.
1972
7ea2b339
PE
19732012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1974
1975 Fix recently-introduced process.c problems found by static checking.
1976 * process.c (write_queue_push, write_queue_pop, send_process):
1977 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1978 (write_queue_pop): Fix pointer signedness problem.
1979 (send_process): Remove unused local.
1980
96a313a1
CY
19812012-06-17 Chong Yidong <cyd@gnu.org>
1982
1983 * xdisp.c (redisplay_internal): No need to redisplay terminal
1984 frames that are not on top.
1985
20ca2e94
TN
19862012-06-17 Troels Nielsen <bn.troels@gmail.com>
1987
1988 * process.c (make_process): Initialize write_queue.
1989 (write_queue_push, write_queue_pop): New functions.
1990 (send_process): Use them to maintain correct ordering of process
1991 writes (Bug#10815).
1992
9a900ca9
PE
19932012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1994
310fbfa8
PE
1995 * lisp.h (eassert): Assume C89 or later.
1996 This removes the need for CHECK.
1997 (CHECK): Remove. Its comments about always evaluating its
1998 argument were confusing, as 'eassert' typically does not evaluate
1999 its argument.
2000
27bb1ca4
PE
2001 * coding.c (produce_chars): Use ptrdiff_t, not int.
2002
9a900ca9
PE
2003 * xterm.c (x_draw_underwave): Check for integer overflow.
2004 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2005
41b7f8bc 20062012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2007
2008 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2009 referenced (Bug#11583).
2010
9b0e3eba
AA
20112012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2012
2013 Implement wave-style variant of underlining.
2014 * dispextern.h (face_underline_type): New enum.
2015 (face): Add field for underline type.
2016 * nsterm.m (ns_draw_underwave): New function.
2017 (ns_draw_text_decoration): Use it.
2018 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2019 New functions.
2020 (x_draw_glyph_string): Use them.
2021 * xfaces.c (Qline, Qwave): New Lisp objects.
2022 (check_lface_attrs, merge_face_ref)
1053a871
SM
2023 (Finternal_set_lisp_face_attribute, realize_x_face):
2024 Handle wave-style underline face attributes.
9b0e3eba
AA
2025 * xterm.c (x_draw_underwave): New function.
2026 (x_draw_glyph_string): Use it.
2027
0fb52f11
JB
20282012-06-16 Juanma Barranquero <lekktu@gmail.com>
2029
2030 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2031 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2032 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2033 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2034 ($(BLD)/w32select.$(O)): Update dependencies.
2035
e5560ff7
AS
20362012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2037
2038 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2039 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2040 * character.c (_fetch_multibyte_char_p): Remove.
2041 * alloc.c: Include "character.h" before "buffer.h".
2042 * bidi.c: Likewise.
2043 * buffer.c: Likewise.
2044 * bytecode.c: Likewise.
2045 * callint.c: Likewise.
2046 * callproc.c: Likewise.
2047 * casefiddle.c: Likewise.
2048 * casetab.c: Likewise.
2049 * category.c: Likewise.
2050 * cmds.c: Likewise.
2051 * coding.c: Likewise.
2052 * composite.c: Likewise.
2053 * dired.c: Likewise.
2054 * dispnew.c: Likewise.
2055 * doc.c: Likewise.
2056 * dosfns.c: Likewise.
2057 * editfns.c: Likewise.
2058 * emacs.c: Likewise.
2059 * fileio.c: Likewise.
2060 * filelock.c: Likewise.
2061 * font.c: Likewise.
2062 * fontset.c: Likewise.
2063 * fringe.c: Likewise.
2064 * indent.c: Likewise.
2065 * insdel.c: Likewise.
2066 * intervals.c: Likewise.
2067 * keyboard.c: Likewise.
2068 * keymap.c: Likewise.
2069 * lread.c: Likewise.
2070 * macros.c: Likewise.
2071 * marker.c: Likewise.
2072 * minibuf.c: Likewise.
2073 * nsfns.m: Likewise.
2074 * nsmenu.m: Likewise.
2075 * print.c: Likewise.
2076 * process.c: Likewise.
2077 * regex.c: Likewise.
2078 * region-cache.c: Likewise.
2079 * search.c: Likewise.
2080 * syntax.c: Likewise.
2081 * term.c: Likewise.
2082 * textprop.c: Likewise.
2083 * undo.c: Likewise.
2084 * unexsol.c: Likewise.
2085 * w16select.c: Likewise.
2086 * w32fns.c: Likewise.
2087 * w32menu.c: Likewise.
2088 * window.c: Likewise.
2089 * xdisp.c: Likewise.
2090 * xfns.c: Likewise.
2091 * xmenu.c: Likewise.
2092 * xml.c: Likewise.
2093 * xselect.c: Likewise.
2094
2f07e6af
EZ
20952012-06-16 Eli Zaretskii <eliz@gnu.org>
2096
1053a871
SM
2097 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2098 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2099 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2100 row.
2101 (handle_face_prop): Use chunk-relative overlay string index when
2102 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2103 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2104 the rightmost. (Bug#11720)
2f07e6af 2105
29b83cec
AS
21062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2107
2108 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2109 (CATEGORY_MEMBER): Enforce 1/0 value.
2110 * category.c (_temp_category_set): Remove.
2111
4c5501e9
EZ
21122012-06-16 Eli Zaretskii <eliz@gnu.org>
2113
2114 * window.c (Fdelete_other_windows_internal)
2115 (Fdelete_window_internal): Don't access frame's mouse highlight
2116 info of the initial frame. (Bug#11677)
2117
2b570124
PE
21182012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2119
e93864f9
PE
2120 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2121 Assume USE_2_TAGS_FOR_INTS.
2122 (xreload): Adjust $tagmask width to match recent lisp.h change.
2123
2b570124
PE
2124 Simplify lisp.h in minor ways that should not affect code.
2125 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2126 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2127 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2128 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2129 (INTTYPEBITS): New macro, for clarity.
2130 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2131 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2132 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2133 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2134 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2135
81755f69
JB
21362012-06-13 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2139
16192a57
GM
21402012-06-13 Glenn Morris <rgm@gnu.org>
2141
2142 * s/bsd-common.h (BSD4_3):
2143 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2144
646b5f55
AS
21452012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2146
2147 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2148 instead of union.
2149 (XLI, XIL): Define.
1053a871
SM
2150 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2151 Use them.
2152 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2153 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2154 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2155 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2156 * frame.c (delete_frame): Remove outdated comment.
2157 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2158 USE_LISP_UNION_TYPE.
2159 (Fw32_unregister_hot_key): Likewise.
2160 (Fw32_toggle_lock_key): Likewise.
2161 * w32menu.c (add_menu_item): Likewise.
2162 (w32_menu_display_help): Use XIL instead of checking
2163 USE_LISP_UNION_TYPE.
2164 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2165 (init_heap): Likewise.
2166 * w32term.c (w32_read_socket): Update comment.
2167
1d3823c9
GM
21682012-06-13 Glenn Morris <rgm@gnu.org>
2169
c62ff706
GM
2170 * s/usg5-4-common.h, src/s/unixware.h:
2171 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2172
1d3823c9
GM
2173 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2174
bfe3e0a2
PE
21752012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2178 * alloc.c (make_number) [!defined make_number]:
2179 Remove, as lisp.h always defines this now.
2180 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2181 (roundup_size): Verify that it is a power of 2.
2182 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2183 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2184 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2185 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2186 USE_LSB_TAG now is always defined to be either 0 or 1.
2187 All uses changed.
2188 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2189 code works fine either way, and efficiency is not a concern here,
2190 as the union type is for debugging, not for production.
2191 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2192 Use an inline function on all platforms when using the union type,
2193 since this is simpler and 'static inline' can be used portably
2194 within Emacs now.
2195 (LISP_INITIALLY_ZERO): New macro.
2196 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2197 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2198
45fa9c0f
GM
21992012-06-12 Glenn Morris <rgm@gnu.org>
2200
b4492cba
GM
2201 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2202
2203 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2204
45fa9c0f
GM
2205 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2206 Move BROKEN_SIGIO to configure.
2207
2208 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2209 Move NO_TERMIO to configure.
2210
0e25d334
CY
22112012-06-12 Chong Yidong <cyd@gnu.org>
2212
2213 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2214 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2215 MagickExportImagePixels is undefined.
2216
43682bb6
PE
22172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * image.c (imagemagick_load_image): Remove unused label.
2220
a9be7d2b
GM
22212012-06-11 Glenn Morris <rgm@gnu.org>
2222
2223 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2224 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2225 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2226 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2227
3017f87f
SM
22282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2229
2230 * alloc.c (make_byte_code): New function.
2231 (Fmake_byte_code): Use it. Don't purify here.
2232 * lread.c (read1): Use it as well to avoid extra allocation.
2233
1b9b4cf4
CY
22342012-06-11 Chong Yidong <cyd@gnu.org>
2235
2236 * image.c (imagemagick_load_image): Implement transparency.
2237
95988fcf
AS
22382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2239
2240 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2241 account for preceding backslashes. (Bug#11663)
2242
cd4eb164
CY
22432012-06-09 Chong Yidong <cyd@gnu.org>
2244
2245 * term.c: Support italics in capable terminals (Bug#9652).
2246 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2247 (turn_on_face): Output using TS_enter_italic_mode if available.
2248 Don't handle unused blinking and alt-charset cases.
2249 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2250 and tty_alt_charset_p cases.
2251 (tty_capable_p, init_tty): Support italics.
2252
2253 * termchar.h (struct tty_display_info): Add field for italics.
2254 Remove unused blink field.
2255
2256 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2257 Handle slant.
2258
2259 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2260 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2261 tty_alt_charset_p. Add tty_italic_p.
2262
ff88beb8
MA
22632012-06-09 Michael Albinus <michael.albinus@gmx.de>
2264
2265 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2266 dbus_type_is_basic if available.
2267 (xd_extract_signed, xd_extract_unsigned): Rename from
2268 extract_signed and extract_unsigned, respectively. Adapt callers.
2269
44286096
CY
22702012-06-09 Chong Yidong <cyd@gnu.org>
2271
1682701f
CY
2272 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2273
44286096
CY
2274 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2275 case (Bug#9752).
2276
d86feb17
PE
22772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * xdisp.c (vmessage): Treat frame message as multibyte.
2280 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2281 would generate the diagnostic "Making \302\247 buffer-local while
2282 let-bound!".
2283
d5c20fe8
EZ
22842012-06-08 Eli Zaretskii <eliz@gnu.org>
2285
2286 * dispnew.c (showing_window_margins_p): Undo last change, which
2287 was done due to an inadvertent commit.
2288 (adjust_frame_glyphs_for_frame_redisplay): Do call
2289 showing_window_margins_p.
2290
513749ee
SM
22912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2292
2293 * eval.c (Fmake_var_non_special): New primitive.
2294 (syms_of_eval): Defsubr it.
2295 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2296
d4a8f5c1
JB
22972012-06-08 Juanma Barranquero <lekktu@gmail.com>
2298
2299 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2300 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2301
8bbbc977
EZ
23022012-06-08 Eli Zaretskii <eliz@gnu.org>
2303
2304 * alloc.c (allocate_vectorlike): Fix last change.
2305
f3372c87
DA
23062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 Block-based vector allocation of small vectors.
2309 * lisp.h (struct vectorlike_header): New field `nbytes',
2310 adjust comment accordingly.
2311 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2312 to denote vector blocks. Adjust users (live_vector_p,
2313 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2314 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2315 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2316 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2317 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2318 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2319 (roundup_size): New constant.
2320 (struct vector_block): New data type.
2321 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2322 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2323 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2324 (sweep_vectors): New functions.
2325 (allocate_vectorlike): Return `zero_vector' as the only vector of
2326 0 items. Allocate new vector from block if vector size is less than
2327 or equal to VBLOCK_BYTES_MAX.
2328 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2329 (init_alloc_once): Add call to init_vectors.
2330
4f18a4ed
SM
23312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2332
2333 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2334
86f158bc
PE
23352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 * doprnt.c (doprnt): Truncate multibyte char correctly.
2338 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2339 would mishandle a string argument "Xc" if X was a multibyte
2340 character of length 2: it would truncate after X's first byte
2341 rather than including all of X.
2342
c5cfcbe0
CY
23432012-06-06 Chong Yidong <cyd@gnu.org>
2344
2345 * buffer.c (word_wrap): Doc fix.
2346
c05cf390
PE
23472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2350
0c3461de
GM
23512012-06-03 Glenn Morris <rgm@gnu.org>
2352
2353 * xdisp.c (tool-bar-style): Doc fix.
2354
c71232db
UM
23552012-06-03 Ulrich Müller <ulm@gentoo.org>
2356
2357 * Makefile.in (PAXCTL): Define.
2358 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2359 binary via PaX flags if the paxctl utility is available.
2360 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2361 Restore PaX flags to their default. (Bug#11398)
2362
383f7350
CY
23632012-06-03 Chong Yidong <cyd@gnu.org>
2364
2365 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2366 buffer (Bug#11226).
2367
5f2c76c6
CY
23682012-06-03 Chong Yidong <cyd@gnu.org>
2369
2370 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2371 (note_mode_line_or_margin_highlight): If there is no help echo,
2372 use mode-line-default-help-echo. Handle the case where the mouse
2373 position is past the end of the mode line string.
2374
2375 * buffer.c (buffer_local_value_1): New function, split from
2376 Fbuffer_local_value; can return Qunbound.
2377 (Fbuffer_local_value): Use it.
2378 (Vmode_line_format): Docstring tweaks.
2379
773d47f6
PE
23802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 * sysdep.c (system_process_attributes): Improve comment.
2383
f2d6a3df
SM
23842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2385
2386 * keyboard.c: Export real-this-command to Elisp.
2387 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2388 and DEFVAR it. Update all users.
2389
63810350
PE
23902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2391
7bd5c1f4
PE
2392 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2393
63810350
PE
2394 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2395 Convert pctcpu and pctmem to Lisp float properly.
2396 Let the compiler fold better, as 100.0/0x8000 is exact.
2397
a2821611
AS
23982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2399
2400 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2401 cons_block.
2402
5fceba1d
PE
24032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2406
c98ff5dd
DA
24072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2408
2409 For a 'struct window', replace some Lisp_Object fields to
2410 bitfields where appropriate, remove unused fields.
2411 * window.h (struct window): Remove unused 'last_mark_x' and
2412 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2413 change it's type from Lisp_Object to bitfield.
2414 Change type of 'force_start', 'optional_new_start',
2415 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2416 fields from Lisp_Object to bitfield. Adjust users accordingly.
2417
ca34e0be
PE
24182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 Pacify gcc -Wdouble-precision when using Xaw.
2421 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2422 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2423 Use 'float' consistently, rather than 'float' in most places
2424 and 'double' in a couple of places.
2425
efc00ab1 24262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2427
2428 * xdisp.c (handle_stop): Detect whether we have overlay strings
2429 loaded by testing it->current.overlay_string_index to be
2430 non-negative, instead of checking whether n_overlay_strings is
2431 positive. (Bug#11587)
2432
efc00ab1 24332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2434
2435 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2436
2437 * doc.c (Fsubstitute_command_keys): Doc fix.
2438
efc00ab1 24392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2440
2441 * search.c (search_buffer): Remove calls to
2442 r_alloc_inhibit_buffer_relocation, as it is now called by
2443 maybe_unify_char, which was the cause of relocation of buffer text
2444 in bug#11519.
2445
efc00ab1 24462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2447
2448 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2449 for the duration of call to load_charset, to avoid problems with
2450 callers of maybe_unify_char that access buffer text through C
2451 pointers.
2452
2453 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2454 decrement the inhibition flag, instead of just setting or
2455 resetting it.
2456
ba93a187
PE
24572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 Remove obsolete '#define static' cruft.
2460 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2461 This #undef was "temporary" in 2000; it is no longer needed
2462 now that '#define static' has gone away.
2463 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2464 (gray_bitmap_bits): Remove; no longer needed.
2465 All uses replaced with definiens.
2466 * xterm.c: Include "bitmaps/gray.xbm".
2467
9e4bf381
PE
24682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 Clean up __executable_start, monstartup when --enable-profiling.
2471 The following changes affect the code only when profiling.
2472 * dispnew.c (__executable_start): Rename from safe_bcopy.
2473 Define only on platforms that need it.
2474 * emacs.c: Include <sys/gmon.h> when profiling.
2475 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2476 (__executable_start): Remove decl, since lisp.h does it now.
2477 (safe_bcopy): Remove decl; no longer has that name.
2478 (main): Coalesce #if into single bit of code, for simplicity.
2479 Cast pointers to uintptr_t, since standard libraries want integers
2480 and not pointers.
2481 * lisp.h (__executable_start): New decl.
2482
32d72c2f
GM
24832012-05-31 Glenn Morris <rgm@gnu.org>
2484
2485 * image.c (Fimagemagick_types): Doc fix.
2486
baac5bc7
JM
24872012-05-30 Jim Meyering <meyering@redhat.com>
2488
2489 * callproc.c (Fcall_process_region): Include directory component
2490 in mkstemp error message (Bug#11586).
2491
72cb32cf
PE
24922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 * alloc.c, lisp.h (make_pure_vector): Now static.
2495
61b108cc
SM
24962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2497
2498 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2499 Move to byte-run.el.
2500 (Fautoload): Do the hash-doc more carefully.
2501 * data.c (Fdefalias): Purify definition, except for keymaps.
2502 (Qdefun): Move from eval.c.
2503 * lisp.h (Qdefun): Remove.
2504 * lread.c (read1): Tiny simplification.
2505
471fe23d
TN
25062012-05-29 Troels Nielsen <bn.troels@gmail.com>
2507
934f3f58 2508 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2509 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2510 Bug#9642, but explicitly check that the buffer the overlay would
2511 be moved to is live and rearrange lines to make sure that errors
2512 will not put the overlay in an inconsistent state.
2513 (Fdelete_overlay): Cosmetics.
2514
85d0efd1
EZ
25152012-05-28 Eli Zaretskii <eliz@gnu.org>
2516
2517 * w32term.c (my_bring_window_to_top): New function.
2518 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2519 could be different from the original one.
2520 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2521 (Bug#11513)
2522
2523 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2524 by calling BringWindowToTop.
2525
2526 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2527 (WM_EMACS_END): Increase by one.
2528
da92a98c
PE
25292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2532 This avoids undefined behavior that might cause the eassert
2533 to not catch an out-of-range value.
2534
74d1f848
JB
25352012-05-28 Juanma Barranquero <lekktu@gmail.com>
2536
2537 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2538 Update dependencies.
2539
9e1a06fc
EZ
25402012-05-27 Eli Zaretskii <eliz@gnu.org>
2541
2542 * bidi.c (bidi_mirror_char): Fix last change.
2543
f3dd7312
AS
25442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2547 when referring to sectname field in printf format.
2548
81899c91
PE
25492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2550
57b81a9f
PE
2551 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2552 Only r_alloc_inhibit_buffer_relocation needed to be added;
2553 the others were already declared.
2554
81899c91
PE
2555 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2556 before checking whether it's out of range. Put the check inside
2557 eassert. See
2558 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2559
33017faf 25602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2561
2562 * callproc.c (Fcall_process): Restore a line that was accidentally
2563 commented out in the 2011-02-13 change (bug#11547).
2564
33017faf 25652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2566
2567 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2568 defined on ralloc.c.
2569
2570 * buffer.c [REL_ALLOC]: Remove prototypes of
2571 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2572 they are now on lisp.h.
2573
2574 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2575
2576 * search.c (search_buffer): Use it to inhibit relocation of buffer
2577 text while re_search_2 is doing its job, because re_search_2 is
2578 passed C pointers to buffer text. (Bug#11519)
2579
23415acf
EZ
2580 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2581 Update value to 24.
2582
44e27368
EZ
2583 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2584 state after an additional call to move_it_in_display_line_to, keep
2585 the values of it->max_ascent and it->max_descent found for the
2586 entire line.
2587 (pos_visible_p): Revert the comparison against bottom_y to what it
2588 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2589 (Bug#11464)
2590
c1892f11
PE
25912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 Fix coding-related core dumps with gcc -ftrapv.
2594 The code was computing A - B, where A and B are pointers, and B is
2595 random garbage. This can lead to core dumps on platforms that
2596 have special pointer registers, and it also leads to core dumps on
2597 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2598 A - B only when B is initialized properly.
2599 * coding.c (coding_set_source, coding_set_destination): Return void.
2600 (coding_change_source, coding_change_destinations): New functions,
2601 with the old behaviors of coding_set_source and coding_set_destination.
2602 All callers that need an offset changed to use these new functions.
2603
eb7afdad
GM
26042012-05-26 Glenn Morris <rgm@gnu.org>
2605
2606 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2607
f12fdf02
EZ
26082012-05-26 Eli Zaretskii <eliz@gnu.org>
2609
53a63be6 2610 Extend mouse support on W32 text-mode console.
61b108cc
SM
2611 * xdisp.c (draw_row_with_mouse_face):
2612 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2613
eb3f6f01 2614 * w32console.c: Include window.h.
61b108cc
SM
2615 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2616 New functions.
eb3f6f01
EZ
2617 (initialize_w32_display): Initialize mouse-highlight data.
2618
53a63be6
EZ
2619 * w32inevt.c: Include termchar.h and window.h.
2620 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2621 moves, call note_mouse_highlight. If help_echo changed, call
2622 gen_help_event to produce help-echo message in the echo area.
2623 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2624 highlight info.
2625
4cfd81f6
PE
26262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 * lread.c (read1): Simplify slightly to avoid an overflow warning
2629 with GCC 4.7.0 on x86-64.
2630
4446092a
EZ
26312012-05-26 Eli Zaretskii <eliz@gnu.org>
2632
2633 * bidi.c (bidi_mirror_char): Revert last change: an int is
2634 definitely wide enough here.
2635
42b2a986 26362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2637
42b2a986 2638 Fix integer width and related bugs (Bug#9874).
eb106a49 2639 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2640 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2641 (string_bytes, check_sblock, allocate_string_data):
2642 (compact_small_strings, Fmake_bool_vector, make_string)
2643 (make_unibyte_string, make_multibyte_string)
2644 (make_string_from_bytes, make_specified_string)
2645 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2646 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2647 (mark_vectorlike):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 (allocate_pseudovector):
2650 Use int, not EMACS_INT, where int is wide enough.
2651 (inhibit_garbage_collection, Fgarbage_collect):
2652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2653 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2654 int might not be wide enough.
2655 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2656 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2657 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2658 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2659 (bidi_level_of_next_char, bidi_move_to_visually_next):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2662 (Fkill_buffer, Fset_buffer_major_mode)
2663 (advance_to_char_boundary, Fbuffer_swap_text)
2664 (Fset_buffer_multibyte, overlays_at, overlays_in)
2665 (overlay_touches_p, struct sortvec, record_overlay_string)
2666 (overlay_strings, recenter_overlay_lists)
2667 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2668 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2669 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2670 (Foverlay_recenter, last_overlay_modification_hooks_used)
2671 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2673 (validate_region): Omit unnecessary test for b <= e,
2674 since that's guaranteed by the previous test.
d311d28c
PE
2675 (adjust_overlays_for_delete): Avoid pos + length overflow.
2676 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2677 (report_overlay_modification):
2678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2679 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2680 Omit pointer cast, which isn't needed anyway, and doesn't work
2681 after the EMACS_INT -> ptrdiff_t change.
02481186 2682 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2683 * buffer.h: Adjust decls to match defn changes elsewhere.
2684 (struct buffer_text, struct buffer):
2685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2686 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2687 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2688 not int, to avoid needless 32-bit limit on 64-bit hosts.
2689 (exec_byte_code): Use tighter memory-full test, one that checks
2690 for alloca overflow. Don't compute the address of the object just
2691 before an array, as that's not portable. Use EMACS_INT, not
2692 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2693 * callint.c (Fcall_interactively):
2694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2695 * callproc.c (call_process_kill, Fcall_process):
2696 Don't assume pid_t fits into an Emacs fixnum.
2697 (call_process_cleanup, Fcall_process, child_setup):
2698 Don't assume pid_t fits into int.
2699 (call_process_cleanup, Fcall_process, delete_temp_file)
2700 (Fcall_process_region):
2701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2702 (Fcall_process): Simplify handling of volatile integers.
2703 Use int, not EMACS_INT, where int will do.
2704 * casefiddle.c (casify_object, casify_region, operate_on_word)
2705 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (casify_object): Avoid integer overflow when overallocating buffer.
2708 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2709 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2710 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2711 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2712 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2713 integers are now checked earlier. All uses replaced with XINT.
2714 (ccl_driver):
2715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2716 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2717 (ccl_driver, Fregister_code_conversion_map):
2718 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2719 (resolve_symbol_ccl_program): Check that vector header is in range.
2720 Always copy the vector, so that we can check its contents reliably
2721 now rather than having to recheck each instruction as it's being
2722 executed. Check that vector words fit in 'int'.
2723 (ccl_get_compiled_code, Fregister_ccl_program)
2724 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2725 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2726 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2727 contents are in range.
2728 (Fccl_execute_on_string): Check that status is in range.
2729 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2730 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2731 Accept and return EMACS_INT, not int, because callers can pass values
2732 out of 'int' range.
2733 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2734 (multibyte_chars_in_text, parse_str_as_multibyte)
2735 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2736 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2737 (string_escape_byte8, Fget_byte):
2738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2739 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2740 avoid mishandling large integers.
2741 * character.h: Adjust decls to match defn changes elsewhere.
2742 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2743 (Ffind_charset_region):
2744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2745 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2746 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2747 Don't assume fixnum fits in int.
d311d28c
PE
2748 (load_charset_map_from_vector, Fmap_charset_chars):
2749 Remove now-unnecessary CHECK_NATNUMs.
2750 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2751 Don't rely on undefined behavior with signed left shift overflow.
2752 Don't assume unsigned int fits into fixnum, or that fixnum fits
2753 into unsigned int. Don't require max_code to be a valid fixnum;
2754 that's not true for gb10830 4-byte on a 32-bit host. Allow
2755 invalid_code to be a cons, for the same reason. Require code_offset
2756 to be a character. Avoid int overflow if max_char is close
2757 to INT_MAX.
2758 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2759 this is intended anyway and avoids some undefined behavior.
2760 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2761 INDEX_TO_CODE_POINT, as that's what it expects.
2762 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2763 * charset.h (DECODE_CHAR): Return int, not unsigned;
2764 this is what was intended anyway, and it avoids undefined behavior.
2765 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2766 integer-overflow issues.
2767 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2768 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2769 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2770 * chartab.c (Fmake_char_table, Fset_char_table_range)
2771 (uniprop_get_decoder, uniprop_get_encoder):
2772 Don't assume fixnum fits in int.
2773 * cmds.c (move_point): New function, that does the gist of
2774 Fforward_char and Fbackward_char, but does so while checking
2775 for integer overflow more accurately.
c96e5d6a 2776 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2777 (Fforward_line, Fend_of_line, internal_self_insert)
2778 (internal_self_insert):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 Fix a FIXME, by checking for integer overflow when calculating
2781 target_clm and actual_clm.
2782 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2783 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2784 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2785 (coding_alloc_by_making_gap, alloc_destination)
2786 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2787 (encode_coding_utf_16, detect_coding_emacs_mule)
2788 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2789 (detect_coding_iso_2022, decode_coding_iso_2022)
2790 (encode_invocation_designation, encode_designation_at_bol)
2791 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2792 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2793 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2794 (encode_coding_ccl, encode_coding_raw_text)
2795 (detect_coding_charset, decode_coding_charset)
2796 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2797 (produce_composition, produce_charset, produce_annotation)
2798 (decode_coding, handle_composition_annotation)
2799 (handle_charset_annotation, consume_chars, decode_coding_gap)
2800 (decode_coding_object, encode_coding_object, detect_coding_system)
2801 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2802 (code_convert_region, code_convert_string)
8f50130c
PE
2803 (Fdefine_coding_system_internal)
2804 (coding_set_source, coding_set_destination):
d311d28c
PE
2805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2806 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2807 (Fdefine_coding_system_internal):
2808 Don't assume fixnums fit in int.
2809 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2810 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2811 (Funencodable_char_position, Fcheck_coding_systems_region)
2812 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2814 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2815 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2816 Don't access memory outside of the args array.
d311d28c 2817 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2818 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2819 result of ENCODE_CHAR.
d311d28c
PE
2820 * coding.h: Adjust decls to match defn changes elsewhere.
2821 (struct coding_system):
2822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2823 * composite.c (get_composition_id, find_composition)
2824 (run_composition_function, update_compositions)
2825 (compose_text, composition_gstring_put_cache)
2826 (composition_gstring_p, composition_gstring_width)
2827 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2828 (composition_compute_stop_pos, composition_reseat_it)
2829 (composition_update_it, struct position_record)
2830 (find_automatic_composition, composition_adjust_point)
2831 (Fcomposition_get_gstring, Ffind_composition_internal):
2832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2833 (update_compositions):
2834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2835 * composite.h: Adjust decls to match defn changes elsewhere.
2836 (struct composition):
2837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2838 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2839 Do not attempt to compute the address of the object just before a
2840 buffer; this is not portable.
2841 (Faref, Faset):
2842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2843 (Faset): Use int, not EMACS_INT, where int is wide enough.
2844 (Fstring_to_number): Don't assume fixnums fit in int.
2845 (Frem): Don't assume arg is nonnegative.
2846 * dbusbind.c (xd_append_arg): Check for integers out of range.
2847 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2848 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2849 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2850 (xd_get_connection_references): Return ptrdiff_t, not int.
2851 All uses changed.
2852 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2853 (xd_read_message_1):
2854 Use int, not unsigned, where the dbus API uses int.
2855 (Fdbus_message_internal): Don't overflow mtype.
2856 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2857 * dired.c (directory_files_internal, file_name_completion, scmp)
2858 (file_name_completion_stat):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 (file_name_completion): Don't overflow matchcount.
2861 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2862 * dispextern.h: Adjust decls to match defn changes elsewhere.
2863 (struct text_pos, struct glyph, struct bidi_saved_info)
2864 (struct bidi_string_data, struct bidi_it, struct composition_it)
2865 (struct it):
2866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2867 (struct display_pos, struct composition_it, struct it):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 * dispnew.c (increment_matrix_positions)
2870 (increment_row_positions, mode_line_string)
2871 (marginal_area_string):
2872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2873 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2875 (duration_to_sec_usec): New function, to check for overflow better.
2876 (Fsleep_for, sit_for): Use it.
2877 * doc.c (get_doc_string, store_function_docstring):
2878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2879 (get_doc_string, Fsnarf_documentation):
2880 Use int, not EMACS_INT, where int is wide enough.
2881 (get_doc_string):
2882 Use SAFE_ALLOCA, not alloca.
2883 Check for overflow when converting EMACS_INT to off_t.
2884 * doprnt.c (doprnt):
2885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2886 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2887 Don't assume uid_t fits into fixnum.
2888 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2889 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2890 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2891 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2892 (general_insert_function)
2893 (Finsert_char, make_buffer_string, make_buffer_string_both)
2894 (update_buffer_properties, Fbuffer_substring)
2895 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2896 (Fsubst_char_in_region, check_translation)
2897 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2898 (transpose_markers, Ftranspose_regions):
2899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2900 (clip_to_bounds): Move to lisp.h as an inline function).
2901 (Fconstrain_to_field): Don't assume integers are nonnegative.
2902 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2903 (Fsubst_char_in_region, Fsave_restriction):
2904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2905 (Femacs_pid): Don't assume pid_t fits into fixnum.
2906 (lo_time): Use int, not EMACS_INT, when int suffices.
2907 (lisp_time_argument): Check for usec out of range.
2908 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2909 (Fuser_login_name, Fuser_full_name): Signal an error
2910 if a uid argument is out of range, rather than relying on
2911 undefined behavior.
c8d5c857
PE
2912 (Fformat_time_string): Remove now-unnecessary check.
2913 lisp_time_argument checks for out-of-range usec now.
243e0530 2914 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2915 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2916 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2917 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2918 (init_cmdargs, Fdump_emacs):
2919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2920 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2921 the bottom (typically) 32 bits of the fixnum.
2922 * eval.c (specpdl_size, call_debugger):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 (when_entered_debugger, Fbacktrace_debug):
2925 Don't assume fixnum can fit in int.
2926 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2927 the object just before a buffer; this is not portable.
2928 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2929 (grow_specpdl, unbind_to):
2930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2931 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2932 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2933 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2934 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2935 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2937 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2938 (a_write, e_write):
2939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2940 (Fcopy_file, non_regular_nbytes, read_non_regular)
2941 (Finsert_file_contents):
2942 Use int, not EMACS_INT, where int is wide enough.
2943 (READ_BUF_SIZE): Verify that it fits in int.
2944 (Finsert_file_contents): Check that counts are in proper range,
2945 rather than assuming fixnums fit into ptrdiff_t etc.
2946 Don't assume fixnums fit into int.
125b3835 2947 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2948 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2949 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2950 (string_char_to_byte, string_byte_to_char)
2951 (string_make_multibyte, string_to_multibyte)
2952 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2953 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2954 (substring_both, Fdelete, internal_equal, Ffillarray)
2955 (Fclear_string, mapcar1)
2956 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2957 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2958 (larger_vector, make_hash_table, maybe_resize_hash_table)
2959 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2960 (Fmaphash, secure_hash):
2961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2962 (concat): Check for string index and length overflow.
2963 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2964 (Frequire):
2965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2966 (larger_vector): New API (vec, incr_min, size_max) replaces old
2967 one (vec, new_size, init). This catches size overflow.
2968 INIT was removed because it was always Qnil.
2969 All callers changed.
2970 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2971 the upper bound on a hash table index size.
2972 (make_hash_table, maybe_resize_hash_table): Use it.
2973 (secure_hash): Computer start_byte and end_byte only after
2974 they're known to be in ptrdiff_t range.
2975 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2976 (Ffont_get_glyphs, Ffont_at):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2979 (Flist_fonts, Fopen_font):
2980 Don't assume fixnum can fit in int.
2981 (check_gstring): Don't assume index can fit in int.
2982 (font_match_p): Check that fixnum is a character, not a nonnegative
2983 fixnum, since the later code needs to stuff it into an int.
2984 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2985 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2986 conversion overflow issues.
2987 (Fopen_font): Check for integer out of range.
2988 (Ffont_get_glyphs): Don't assume index can fit in int.
2989 * font.h: Adjust decls to match defn changes elsewhere.
2990 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2991 integer overflow.
2992 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2993 printmax_t, where ptrdiff_t is wide enough.
2994 (Finternal_char_font):
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2997 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2998 (Fset_frame_position, x_set_frame_parameters)
2999 (x_set_line_spacing, x_set_border_width)
3000 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3001 Check that fixnums are in proper range for system types.
3002 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3004 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3005 Use SAFE_ALLOCA_LISP, not alloca.
3006 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3007 intptr_t is wide enough.
3008 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3009 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3010 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3011 Check for fixnum out of range.
3012 * ftfont.c (ftfont_list): Don't assume index fits in int.
3013 Check that fixnums are in proper range for system types.
3014 (ftfont_shape_by_flt):
3015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3016 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3018 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3019 Check that fixnums are in proper range for system types.
3020 * gnutls.h: Adjust decls to match defn changes elsewhere.
3021 * gtkutil.c (xg_dialog_run):
3022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3023 (update_frame_tool_bar):
3024 Check that fixnums are in proper range for system types.
3025 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3026 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3027 * indent.c (last_known_column, last_known_column_point):
3028 (current_column_bol_cache):
3029 (skip_invisible, current_column, check_display_width):
3030 (check_display_width, scan_for_column, current_column_1)
3031 (Findent_to, Fcurrent_indentation, position_indentation)
3032 (indented_beyond_p, Fmove_to_column, compute_motion):
3033 (Fcompute_motion, Fvertical_motion):
3034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3035 (last_known_column_modified): Use EMACS_INT, not int.
3036 (check_display_width):
3037 (Fcompute_motion):
3038 Check that fixnums and floats are in proper range for system types.
3039 (compute_motion): Don't assume index or fixnum fits in int.
3040 (compute_motion, Fcompute_motion):
3041 Use int, not EMACS_INT, when it is wide enough.
3042 (vmotion): Omit local var start_hpos that is always 0; that way
3043 we don't need to worry about overflow in expressions involving it.
3044 * indent.h: Adjust decls to match defn changes elsewhere.
3045 (struct position):
3046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3047 Use int, not EMACS_INT, where int is wide enough.
3048 Remove unused members ovstring_chars_done and tab_offset;
3049 all uses removed.
3050 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3051 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3052 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3053 (make_gap, copy_text, insert, insert_and_inherit)
3054 (insert_before_markers, insert_before_markers_and_inherit)
3055 (insert_1, count_combining_before, count_combining_after)
3056 (insert_1_both, insert_from_string)
3057 (insert_from_string_before_markers, insert_from_string_1)
3058 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3059 (adjust_after_replace, adjust_after_insert, replace_range)
3060 (replace_range_2, del_range, del_range_1, del_range_byte)
3061 (del_range_both, del_range_2, modify_region)
3062 (prepare_to_modify_buffer, signal_before_change)
3063 (signal_after_change, Fcombine_after_change_execute):
3064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3065 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3066 (balance_an_interval, split_interval_right, split_interval_left)
3067 (find_interval, next_interval, update_interval)
3068 (adjust_intervals_for_insertion, delete_node, delete_interval)
3069 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3070 (static_offset_intervals, offset_intervals)
3071 (merge_interval_right, merge_interval_left, make_new_interval)
3072 (graft_intervals_into_buffer, temp_set_point_both)
3073 (temp_set_point, set_point, adjust_for_invis_intang)
3074 (set_point_both, move_if_not_intangible, get_property_and_range)
3075 (get_local_map, copy_intervals, copy_intervals_to_string)
3076 (compare_string_intervals, set_intervals_multibyte_1):
3077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3078 * intervals.h: Adjust decls to match defn changes elsewhere.
3079 (struct interval):
3080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3081 * keyboard.c (this_command_key_count, this_single_command_key_start)
3082 (before_command_key_count, before_command_echo_length, echo_now)
3083 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3084 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3085 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3086 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3088 (last_non_minibuf_size, last_point_position, echo_truncate)
3089 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3090 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3091 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3092 (stuff_buffered_input):
3093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3094 (last_auto_save, command_loop_1, read_char):
3095 Use EMACS_INT, not int, to avoid integer overflow.
3096 (record_char): Avoid overflow in total_keys computation.
3097 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3098 * keyboard.h: Adjust decls to match defn changes elsewhere.
3099 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3100 (Fkey_description, Fdescribe_vector, Flookup_key):
3101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3102 (click_position): New function, to check that positions are in range.
3103 (Fcurrent_active_maps):
3104 (describe_command):
3105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3106 (Faccessible_keymaps, Fkey_description):
3107 (preferred_sequence_p):
3108 Don't assume fixnum can fit into int.
3109 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3110 Check for integer overflow in size calculations.
3111 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3112 avoid mishandling large integers.
3113 * lisp.h: Adjust decls to match defn changes elsewhere.
3114 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3115 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3116 (struct Lisp_Marker):
3117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3118 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3119 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3120 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3121 All callers changed.
3122 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3123 Assume the arg has valid form, since it always does.
3124 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3125 unsigned integer system type.
3126 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3127 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3130 (duration_to_sec_usec): New decl.
3131 * lread.c (read_from_string_index, read_from_string_index_byte)
3132 (read_from_string_limit, readchar, unreadchar, openp)
3133 (read_internal_start, read1, oblookup):
3134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3135 (Fload, readevalloop, Feval_buffer, Feval_region):
3136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3137 (openp): Check for out-of-range argument to 'access'.
3138 (read1): Use int, not EMACS_INT, where int is wide enough.
3139 Don't assume fixnum fits into int.
6efdadfd 3140 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3141 (read_filtered_event): Use duration_to_sec_usec
3142 to do proper overflow checking on durations.
d311d28c
PE
3143 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3144 in size calculation.
3145 (Fexecute_kbd_macro):
3146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3147 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3148 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3149 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3150 (set_marker_both, set_marker_restricted_both, marker_position)
3151 (marker_byte_position, Fbuffer_has_markers_at):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3154 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3155 It now merely ensures that the menu is large enough, without
3156 necessarily growing it, as this avoids some integer overflow issues.
3157 All callers changed.
3158 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3160 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3161 Use SAFE_ALLOCA_LISP, not alloca.
3162 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3163 to EMACS_INT. Check that fixnums are in proper range for system types.
3164 * minibuf.c (minibuf_prompt_width, string_to_object)
3165 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3166 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3168 (get_minibuffer, read_minibuf_unwind):
3169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3170 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3171 this simplifies overflow checking. All callers changed.
3172 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3173 (Ftest_completion):
3174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3175 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3176 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3177 Check that fixnums are in proper range for system types.
3178 (Fx_create_frame, Fx_show_tip):
3179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3180 * nsfont.m (ns_findfonts, nsfont_list_family):
3181 Don't assume fixnum fits in long.
3182 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3184 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3185 wide enough.
17fdb222 3186 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3188 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3189 (PRINTDECLARE, PRINTPREPARE):
3190 (strout, print_string):
3191 (print, print_preprocess, print_check_string_charset_prop)
3192 (print_object):
3193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3194 (PRINTDECLARE):
3195 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3197 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3198 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3199 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3200 (print_error_message): Use SAFE_ALLOCA, not alloca.
3201 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3202 (print_depth, new_backquote_output, print_number_index):
3203 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3204 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3205 (Fset_process_window_size, Fformat_network_address)
3206 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3207 (sigchld_handler):
d311d28c 3208 Check that fixnums are in proper range for system types.
d44287d4 3209 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3210 Check for process-ids out of pid_t range rather than relying on
3211 undefined behavior.
e4d81efc 3212 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3213 (Fformat_network_address, read_process_output, send_process)
3214 (Fprocess_send_region, status_notify):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3216 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3217 (wait_reading_process_output, read_process_output, exec_sentinel):
3218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3219 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3220 (Faccept_process_output): Use duration_to_sec_usec to do proper
3221 overflow checking on durations.
dde14581
PE
3222 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3223 Don't assume pid_t fits in int.
02481186
PE
3224 * process.h (struct Lisp_Process): Members tick and update_tick
3225 are now of type EMACS_INT, not int.
b62b53e8
PE
3226 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3227 configured --with-wide-int.
d311d28c
PE
3228 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3229 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3230 * search.c (looking_at_1, string_match_1):
3231 (fast_string_match, fast_c_string_match_ignore_case)
3232 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3233 (scan_newline, find_before_next_newline, search_command)
3234 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3235 (set_search_regs, wordify):
3236 (Freplace_match):
3237 (Fmatch_data):
3238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3239 (string_match_1, search_buffer, set_search_regs):
3240 (Fmatch_data):
3241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3242 (wordify): Check for overflow in size calculation.
3243 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3244 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3245 Check that fixnums are in proper range for system types.
3246 * sound.c (struct sound_device)
3247 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 (Fplay_sound_internal):
3250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3251 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3252 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3253 (Fparse_partial_sexp):
3254 Don't assume fixnums can fit in int.
3255 (struct lisp_parse_state, find_start_pos, find_start_value)
3256 (find_start_value_byte, find_start_begv)
3257 (update_syntax_table, char_quoted, dec_bytepos)
3258 (find_defun_start, prev_char_comend_first, back_comment):
3259 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3260 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3262 (Finternal_describe_syntax_value): Check that match_lisp is a
3263 character, not an integer, since the code stuffs it into int.
3264 (scan_words, scan_sexps_forward):
3265 Check that fixnums are in proper range for system types.
3266 (Fforward_word):
3267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3268 (scan_sexps_forward):
3269 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3270 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3271 * syntax.h: Adjust decls to match defn changes elsewhere.
3272 (struct gl_state_s):
3273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3274 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3275 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3276 * sysdep.c (wait_for_termination_1, wait_for_termination)
3277 (interruptible_wait_for_termination, mkdir):
3278 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3279 (emacs_read, emacs_write):
3280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3281 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3282 and double all fit in int.
d311d28c
PE
3283 * term.c (set_tty_color_mode):
3284 Check that fixnums are in proper range for system types.
3285 * termhooks.h (struct input_event):
3286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3287 * textprop.c (validate_interval_range, interval_of)
3288 (Fadd_text_properties, set_text_properties_1)
3289 (Fremove_text_properties, Fremove_list_of_text_properties)
3290 (Ftext_property_any, Ftext_property_not_all)
3291 (copy_text_properties, text_property_list, extend_property_ranges)
3292 (verify_interval_modification):
3293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3294 (Fnext_single_char_property_change)
3295 (Fprevious_single_char_property_change):
3296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3297 (copy_text_properties):
3298 Check for integer overflow in index calculation.
d311d28c
PE
3299 * undo.c (last_boundary_position, record_point, record_insert)
3300 (record_delete, record_marker_adjustment, record_change)
3301 (record_property_change):
3302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3303 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3305 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3306 (Fx_hide_tip, Fx_file_dialog):
3307 * w32menu.c (set_frame_menubar):
3308 Use ptrdiff_t, not int, for consistency with rest of code.
3309 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3310 (select_window, Fdelete_other_windows_internal)
3311 (window_scroll_pixel_based, window_scroll_line_based)
3312 (Frecenter, Fset_window_configuration):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3314 (Fset_window_hscroll, run_window_configuration_change_hook)
3315 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3316 (Fscroll_other_window, Frecenter):
d311d28c
PE
3317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3318 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3319 Don't assume fixnum fits in int.
3320 (Fset_window_scroll_bars):
3321 Check that fixnums are in proper range for system types.
3322 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3323 (string_pos, c_string_pos, number_of_chars, init_iterator)
3324 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3325 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3326 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3327 (face_before_or_after_it_pos, handle_invisible_prop)
3328 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3329 (display_prop_intangible_p, string_buffer_position_lim)
3330 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3331 (get_overlay_strings_1, get_overlay_strings)
3332 (iterate_out_of_display_property, forward_to_next_line_start)
3333 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3334 (get_next_display_element, set_iterator_to_next)
3335 (get_visually_first_element, compute_stop_pos_backwards)
3336 (handle_stop_backwards, next_element_from_buffer)
3337 (move_it_in_display_line_to, move_it_in_display_line)
3338 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3339 (add_to_log, message_dolog, message_log_check_duplicate)
3340 (message2, message2_nolog, message3, message3_nolog
3341 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3342 (current_message_1, truncate_echo_area, truncate_message_1)
3343 (set_message, set_message_1, store_mode_line_noprop)
3344 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3345 (text_outside_line_unchanged_p, check_point_in_composition)
3346 (reconsider_clip_changes)
3347 (redisplay_internal, set_cursor_from_row, try_scrolling)
3348 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3349 (redisplay_window, find_last_unchanged_at_beg_row)
3350 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3351 (trailing_whitespace_p, find_row_edges, display_line)
3352 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3353 (display_mode_element, store_mode_line_string)
3354 (pint2str, pint2hrstr, decode_mode_spec)
3355 (display_count_lines, display_string, draw_glyphs)
3356 (x_produce_glyphs, x_insert_glyphs)
3357 (rows_from_pos_range, mouse_face_from_buffer_pos)
3358 (fast_find_string_pos, mouse_face_from_string_pos)
3359 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3361 (safe_call, init_from_display_pos, handle_fontified_prop)
3362 (handle_single_display_spec, load_overlay_strings)
3363 (with_echo_area_buffer, setup_echo_area_for_printing)
3364 (display_echo_area, echo_area_display)
3365 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3366 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3367 (redisplay_window, dump_glyph_row, display_mode_line)
3368 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3369 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3371 (handle_single_display_spec, build_desired_tool_bar_string)
3372 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3373 (get_specified_cursor_type):
3374 Check that fixnums are in proper range for system types.
3375 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3376 (Flookup_image_map):
3377 Don't assume fixnums fit in int.
3378 (compare_overlay_entries):
3379 Avoid mishandling comparisons due to subtraction overflow.
3380 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3381 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3382 (handle_tool_bar_click):
3383 Use int, not unsigned, since we prefer signed and the signedness
3384 doesn't matter here.
3385 (get_next_display_element, next_element_from_display_vector):
3386 Use int, not EMACS_INT, when int is wide enough.
3387 (start_hourglass): Use duration_to_sec_usec to do proper
3388 overflow checking on durations.
3389 * xfaces.c (Fbitmap_spec_p):
3390 Check that fixnums are in proper range for system types.
3391 (compare_fonts_by_sort_order):
3392 Avoid mishandling comparisons due to subtraction overflow.
3393 (Fx_family_fonts, realize_basic_faces):
3394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3395 (Fx_family_fonts):
3396 Don't assume fixnum fits in int.
3397 Use SAFE_ALLOCA_LISP, not alloca.
3398 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3399 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3400 (face_at_buffer_position, face_for_overlay_string)
3401 (face_at_string_position):
3402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3403 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3405 (Fx_show_tip):
3406 Check that fixnums are in proper range for system types.
3407 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3408 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3410 (Fx_change_window_property): Don't assume fixnums fit in int.
3411 * xfont.c (xfont_chars_supported):
3412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3413 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3414 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3416 * xml.c (parse_region):
3417 * xrdb.c (magic_file_p):
3418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3419 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3420 (x_get_local_selection, x_reply_selection_request)
3421 (x_handle_selection_request, wait_for_property_change):
3422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3423 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3424 short is wide enough.
3425 (x_send_client_event): Don't assume fixnum fits in int.
3426 * xterm.c (x_x_to_emacs_modifiers):
3427 Don't assume EMACS_INT overflows nicely into int.
3428 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3429 may come from Lisp.
3430 (handle_one_xevent): NATNUMP can eval its arg twice.
3431 (x_connection_closed):
3432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3433 * xterm.h: Adjust decls to match defn changes elsewhere.
3434 (struct scroll_bar): Use struct vectorlike_header
3435 rather than rolling our own approximation.
3436 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3437
c6574eb5
GM
34382012-05-25 Glenn Morris <rgm@gnu.org>
3439
3440 * lisp.mk (lisp): Update for more files being compiled now.
3441
e8d32c7e
SM
34422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3443
48def666
SM
3444 * lread.c: Remove `read_pure' which makes no difference.
3445 (read_pure): Remove var.
3446 (unreadpure): Remove function.
3447 (readevalloop): Don't call read_list with -1 flag.
3448 (read1, read_vector): Don't test read_pure any more.
3449 (read_list): Simplify.
3450
e8d32c7e
SM
3451 * fileio.c, character.h: Minor style tweaks.
3452
4b2addb7
DA
34532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3454
3455 * window.h (clip_changed): Remove useless declaration.
3456
584461b2
JB
34572012-05-22 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3460 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3461
34374650
PE
34622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3463
3464 Remove src/m/*.
3465 This directory predates autoconf and is no longer needed nowadays.
3466 Move its few remaining bits of functionality to where they're needed.
3467 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3468 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3469 * m/template.h: Remove.
3470 * Makefile.in (M_FILE): Remove. All uses removed.
3471 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3472 * lisp.h (USE_LSB_TAG):
3473 * mem-limits.h (EXCEEDS_LISP_PTR):
3474 Use VAL_MAX, not VALBITS, in #if.
3475 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3476 (EMACS_UINT): Define unconditionally now.
3477 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3478 (BITS_PER_EMACS_INT): New constants, replacing
3479 what used to be in config.h, but not useful in #if.
3480 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3481 define them any more.
3482 (VAL_MAX): New macro.
3483 (VALMASK): Use it.
3484 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3485 BITS_PER_EMACS_INT, in #if.
3486 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3487 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3488 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3489 * s/ms-w32.h (DATA_START):
3490 Move here from removed file m/intel386.h.
3491 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3492 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3493
261cb4bb
PE
34942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 Assume C89 or later.
3497 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3498 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3499 (xrealloc):
3500 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3501 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3502 * textprop.c, tparam.c (NULL): Remove.
3503 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3504 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3505 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3506 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3507 * xterm.c (input_signal_count): Assume volatile works.
3508
ff23cd9f
KB
35092012-05-21 Ken Brown <kbrown@cornell.edu>
3510
3511 * xgselect.c (xg_select): Fix first argument in call to 'select'
3512 (bug#11508).
3513
1b170bc6
KB
35142012-05-20 Ken Brown <kbrown@cornell.edu>
3515
3516 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3517 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3518
b2f4d39f
KB
35192012-05-19 Ken Brown <kbrown@cornell.edu>
3520
3521 * xfns.c (x_in_use): Remove `static' qualifier.
3522 * xterm.h (x_in_use): Declare.
3523 * xgselect.c: Include xterm.h.
3524 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3525 and `display_arg' (bug#9754).
3526
003fdae2
PE
35272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3528
9232a6d9
PE
3529 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3530
003fdae2
PE
3531 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3532 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3533
784b56e2
EZ
35342012-05-18 Eli Zaretskii <eliz@gnu.org>
3535
3536 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3537
3538 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3539 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3540
3541 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3542 reference to image_cache->refcount.
3543 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3544
a0a79cde
JL
35452012-05-17 Juri Linkov <juri@jurta.org>
3546
3547 * search.c (Fword_search_regexp, Fword_search_backward)
3548 (Fword_search_forward, Fword_search_backward_lax)
3549 (Fword_search_forward_lax): Move functions to isearch.el
3550 (bug#10145, bug#11381).
3551
b0572523
PE
35522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3555
9660f5fc
SM
35562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3557
3558 * lread.c (init_obarray): Declare Qt and Qnil as special.
3559
4374de83
GM
35602012-05-14 Glenn Morris <rgm@gnu.org>
3561
3562 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3563 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3564
dc44c39a
PE
35652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3566
078c97cb
PE
3567 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3568
dc44c39a
PE
3569 * unexaix.c: Port to more-recent AIX compilers.
3570 (report_error, report_error_1, make_hdr, copy_sym)
3571 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3572 Make arguments const char *, not char *, to avoid violations of C
3573 standard and to fix some AIX warnings reported by Gilles Pion.
3574
e18afed7 35752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3576
3577 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3578 already have overlays loaded.
3579 (handle_single_display_spec): Before returning without displaying
3580 fringe bitmap, synchronize the bidi iterator with the main display
3581 iterator, by calling iterate_out_of_display_property.
3582 (iterate_out_of_display_property): Detect buffer iteration by
3583 testing that it->string is a Lisp string.
3584 (get_next_display_element): When the current object is exhausted,
3585 and there's something on it->stack, call set_iterator_to_next to
3586 proceed with what's on the stack, instead of returning zero.
3587 (set_iterator_to_next): If called at the end of a Lisp string,
3588 proceed to consider_string_end without incrementing string
3589 position. Don't increment display vector index past the end of
3590 the display vector. (Bug#11417)
c8fb9dc6
EZ
3591 (pos_visible_p): Don't report a position visible when move_it_to
3592 stopped at the last line of window, which happens to be scanned
3593 backwards by the bidi iteration. (Bug#11464)
ac268e67 3594
e18afed7 35952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3596
3597 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3598 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3599 are on a TTY, and thus unable to display on the fringes.
3600 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3601 so we need to signal to the caller that this is a "replacing"
3602 display spec. This fixes display when the spec is invalid or we
3603 are on a TTY.
3604
e18afed7 36052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3606
3607 * unexaix.c (make_hdr): Fix typo in prototype.
3608 This bug broke the build on AIX. Problem reported by Gilles Pion.
3609
9d0a235a
MA
36102012-05-14 Michael Albinus <michael.albinus@gmx.de>
3611
3612 * keyboard.c (kbd_buffer_get_event): Read special events also in
3613 batch mode. (Bug#11415)
3614
9e6b06ed
GM
36152012-05-12 Glenn Morris <rgm@gnu.org>
3616
3617 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3618
c1a1d7a3
EZ
36192012-05-12 Eli Zaretskii <eliz@gnu.org>
3620
3621 * lisp.mk (lisp): Add newcomment.elc.
3622
3fe7cdc8
GM
36232012-05-12 Glenn Morris <rgm@gnu.org>
3624
3625 * Makefile.in (MKDIR_P): New, set by configure.
3626 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3627
53f7d2c0
PE
36282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Remove unused function hourglass_started.
3631 * dispextern.h (hourglass_started):
3632 * w32fns.c (hourglass_started):
3633 * xdisp.c (hourglass_started): Remove.
3634
75aafb17
JB
36352012-05-10 Juanma Barranquero <lekktu@gmail.com>
3636
3637 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3638 Update dependencies.
3639
12959e8e
PE
36402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3641
97107e2e
PE
3642 * xgselect.c (xg_select): Put maxfds+1 into a var.
3643 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3644
12959e8e
PE
3645 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3646
836d29b3
DA
36472012-05-10 Dave Abrahams <dave@boostpro.com>
3648
3649 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3650 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3651
5cb67954
MA
36522012-05-09 Michael Albinus <michael.albinus@gmx.de>
3653
3654 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3655 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3656 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3657 Initialize xd_registered_buses.
3658
3478ec45
PE
36592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3660
b263a6b0
PE
3661 Untag more efficiently if USE_LSB_TAG.
3662 This is based on a proposal by YAMAMOTO Mitsuharu in
3663 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3664 For an admittedly artificial (nth 8000 longlist) benchmark on
3665 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3666 Emacs's overall text size by 1%.
3667 * lisp.h (XUNTAG): New macro.
3668 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3669 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3670 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3671 * eval.c (Fautoload):
3672 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3673 * frame.h (XFRAME): Use XUNTAG.
3674
3478ec45
PE
3675 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3676 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3677 Remove unportable assumptions about print widths of types like
3678 dbus_uint32_t.
3679 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3680 intptr_t when converting between pointer and integer, to avoid GCC
3681 warnings about wrong width.
3682
666b903b 36832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3684
3685 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3686 stack for each reader_thread, instead of defaulting to 8MB
3687 determined by the linker. This avoids failures in creating
3688 subprocesses on Windows 7, see the discussion in this thread:
3689 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3690
b120cc17
JC
36912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3692
3693 Fix up display of the *Minibuf-0* buffer in the mini window.
3694 * keyboard.c (read_char): Don't clear the echo area if there's no
3695 message to clear.
3696 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3697 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3698
9a4b36f8
MA
36992012-05-07 Michael Albinus <michael.albinus@gmx.de>
3700
3701 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3702 batch mode.
3703
e5f9458f
CY
37042012-05-06 Chong Yidong <cyd@gnu.org>
3705
3706 * lisp.mk (lisp): Update.
3707
eceeb5fc 37082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3709
3710 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3711
71873e2b
SM
37122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3713
3714 * data.c (PUT_ERROR): New macro.
3715 (syms_of_data): Use it. Add new error type `user-error'.
3716 * undo.c (user_error): New function.
3717 (Fprimitive_undo): Use it.
3718 * print.c (print_error_message): Adjust print style for `user-error'.
3719 * keyboard.c (user_error): New function.
3720 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3721
ab0fa4e4
PE
37222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3723
3724 Do not limit current-time-string to years 1000..9999.
3725 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3726 (Fcurrent_time_string): Support any year that is supported by the
3727 underlying localtime representation. Don't use asctime, as it
3728 has undefined behavior for years outside the range -999..9999.
3729
7ed806a7
PE
37302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3731
3732 Fix race conditions involving setenv, gmtime, localtime, asctime.
3733 Without this fix, interrupts could mess up code that uses these
3734 nonreentrant functions, since setting TZ invalidates existing
3735 tm_zone or tzname values, and since most of these functions return
3736 pointers to static storage.
3737 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3738 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3739 Grow the critical sections to include not just invoking
3740 localtime/gmtime, but also accessing these functions' results
3741 including their tm_zone values if any, and any related TZ setting.
3742 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3743 so that the struct tm is saved in the critical section.
3744 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3745 motivated by the fact that memory allocation needs to be outside
3746 the critical section.
3747
0c16dfed
DA
37482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3749
3750 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3751 with RESET_INTERVAL.
3752
3753 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3754 Remove duplicated buffer name initialization.
3755
3f83ace8
JM
37562012-05-02 Jim Meyering <jim@meyering.net>
3757
3758 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3759
c7b8541e
JM
3760 * xfns.c (x_window): Use xstrdup (Bug#11375).
3761
90207a15 37622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3763
3764 * xdisp.c (pos_visible_p): If already at a newline from the
3765 display string before the 'while' loop, don't walk back the glyphs
3766 from it3.glyph_row. Solves assertion violation when the display
3767 string begins with a newline (egg.el). (Bug#11367)
3768
b593d6a9
AH
37692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3770
3771 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3772 Move to simple.el.
3773
4737362e
GM
37742012-05-01 Glenn Morris <rgm@gnu.org>
3775
99cf43f9
GM
3776 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3777 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3778 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3779 All were removed before 23.1.
3780
9311dcff
GM
3781 * dispnew.c: Remove HAVE_LIBNCURSES test;
3782 it is always true on relevant platforms.
3783
4d5c6349
GM
3784 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3785 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3786
4737362e
GM
3787 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3788
74dd3a6b
AS
37892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3790
3791 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3792 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3793 Remove.
3794
13c379ee
PE
37952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3796
3797 Do not avoid creating empty evaporating overlays (Bug#9642).
3798 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3799 That is, do not delete an evaporating overlay if it becomes
3800 empty after its bounds are adjusted to fit within its buffer.
3801 This fix caused other problems, and I'm reverting it until we get
3802 to the bottom of them.
3803
a8e7d6d7 38042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3805
3806 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3807
a8e7d6d7 38082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3809
3810 * xdisp.c (pos_visible_p): If the window start position is beyond
3811 ZV, start the display from buffer beginning. Prevents assertion
3812 violation in init_iterator when the minibuffer window is scrolled
3813 via the scroll bar.
3814
3815 * window.c (window_scroll_pixel_based): Likewise.
3816
a8e7d6d7 38172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3818
3819 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3820
a8e7d6d7 38212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3822
3823 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3824 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3825
a8e7d6d7 38262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3827
b593d6a9
AH
3828 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3829 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3830
1c6900d9
EZ
38312012-04-26 Eli Zaretskii <eliz@gnu.org>
3832
4c3fa1d9
EZ
3833 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3834 display element, check also the underlying string or buffer
3835 character. (Bug#11341)
3836
1c6900d9
EZ
3837 * w32menu.c: Include w32heap.h.
3838 (add_menu_item): If the call to AppendMenuW (via
3839 unicode_append_menu) fails, disable Unicode menus only if we are
3840 running on Windows 9X/Me.
3841
42bf8205
AS
38422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3843
3844 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3845 (xgetint): Add missing shift for LSB tags.
3846
b1bac16e
MR
38472012-04-24 Martin Rudalics <rudalics@gmx.at>
3848
3849 * keyboard.c (read_char): Don't wipe echo area for select window
3850 events: These might get delayed via `mouse-autoselect-window'
3851 (Bug#11304).
3852
d69621cc
JB
38532012-04-24 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3856 manipulation of :loaded-from data.
3857
02fd101b
JB
38582012-04-23 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3861 now a cons (bug#11311).
3862
888bec30
PE
38632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3864
89a438bd
PE
3865 Do not create empty overlays with the evaporate property (Bug#9642).
3866 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3867 if it becomes empty after its bounds are adjusted to fit within
3868 its buffer. Without this fix, in a nonempty buffer (let ((o
3869 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3870 yields an empty overlay that has the evaporate property, which is
3871 not supposed to happen.
3872
1068fe4d
PE
3873 Fix minor GTK3 problems found by static checking.
3874 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3875 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3876 (struct _EmacsFixedClass, emacs_fixed_get_type):
3877 Move decls here from emacsgtkfixed.h, since they needn't be public.
3878 (emacs_fixed_get_type): Now static.
3879 (emacs_fixed_class_init): Omit unused local.
3880 (emacs_fixed_child_type): Remove; unused.
3881 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3882 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3883 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3884 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3885 (EMACS_FIXED_GET_CLASS): Remove; unused.
3886 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3887
888bec30
PE
3888 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3889 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3890
de85e130
PE
38912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3892
d0baac98 3893 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3894 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3895 (__malloc_size_t, __malloc_ptrdiff_t):
3896 Remove. All uses removed, replaced by the definiens if needed,
3897 since we can assume C89 or better now.
3898 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3899 (protect_malloc_state, align, get_contiguous_space)
3900 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3901 (malloc_atfork_handler_child, malloc_enable_thread)
3902 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3903 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3904 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3905 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3906 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3907 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3908 Define using prototypes, not old style.
3909 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3910 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3911 (align): Don't assume that signed integer overflow wraps around.
3912 Omit unused local var.
3913 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3914 (_free_internal_nolock, memalign, mallochook, reallochook):
3915 Omit no-longer-needed casts.
3916 (valloc): Use getpagesize, not __getpagesize.
3917 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3918 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3919
de85e130
PE
3920 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3921
dcbf5805
MA
39222012-04-22 Michael Albinus <michael.albinus@gmx.de>
3923
3924 Move functions from C to Lisp. Make non-blocking method calls
3925 the default. Implement further D-Bus standard interfaces.
3926
3927 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3928 (QCdbus_request_name_allow_replacement)
3929 (QCdbus_request_name_replace_existing)
3930 (QCdbus_request_name_do_not_queue)
3931 (QCdbus_request_name_reply_primary_owner)
3932 (QCdbus_request_name_reply_in_queue)
3933 (QCdbus_request_name_reply_exists)
3934 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3935 (QCdbus_registered_serial, QCdbus_registered_method)
3936 (QCdbus_registered_signal): New Lisp objects.
3937 (XD_DEBUG_MESSAGE): Use sizeof.
3938 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3939 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3940 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3941 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3942 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3943 (xd_signature, xd_append_arg): Allow float for integer types.
3944 (xd_get_connection_references): New function.
b593d6a9
AH
3945 (xd_get_connection_address): Rename from xd_initialize.
3946 Return cached address.
dcbf5805
MA
3947 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3948 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3949 level.
3950 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3951 Return number of refcounts.
dcbf5805
MA
3952 (Fdbus_get_unique_name): Make stronger parameter check.
3953 (Fdbus_message_internal): New defun.
3954 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3955 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3956 (Fdbus_send_signal, Fdbus_register_service)
3957 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3958 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3959 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3960 (Vdbus_compiled_version, Vdbus_runtime_version)
3961 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3962 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3963 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3964 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3965 Adapt docstring.
dcbf5805 3966
52828e02
PE
39672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3968
da05bc4c
PE
3969 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3970 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3971 Do not assume ptrdiff_t is the same width as 'int'.
3972
52828e02
PE
3973 * alloc.c: Handle unusual debugging option combinations.
3974 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3975 since the two debugging options are incompatible.
3976 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3977 is defined.
3978 (mem_init, mem_insert, mem_insert_fixup):
3979 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3980 (NEED_MEM_INSERT): Remove; no longer needed.
3981
f01769f9
LL
39822012-04-22 Leo Liu <sdl.web@gmail.com>
3983
3984 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3985
5790543d
PE
39862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 * sysdep.c [__FreeBSD__]: Minor cleanups.
3989 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3990 Use Emacs indenting style more consistently. Avoid some casts.
3991 Use 'double' consistently rather than mixing 'float' and 'double'.
3992
b91b7e4d
EW
39932012-04-21 Eduard Wiebe <usenet@pusto.de>
3994
b593d6a9
AH
3995 * sysdep.c (list_system_processes, system_process_attributes):
3996 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3997
6114eb15
AS
39982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3999
4000 * lisp.mk (lisp): Update.
4001
2f38dff7
PE
40022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4005 It is never used otherwise.
4006
4ae29f89
SM
40072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4008
4009 * print.c (print_preprocess): Only check print_depth if print-circle
4010 is nil.
4011 (print_object): Check for cycles even when print-circle is nil and
4012 print-gensym is t, but only check print_depth if print-circle is nil.
4013
f30d612a
CY
40142012-04-20 Chong Yidong <cyd@gnu.org>
4015
4016 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4017 set the status to "failed" and ensure that sentinel is run.
4018
c07a4c0b 40192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4020
4021 * process.c (Fset_process_inherit_coding_system_flag)
4022 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4023 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4024
c07a4c0b 40252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4026
4027 * xdisp.c (string_buffer_position_lim): Limit starting position to
4028 BEGV.
4029 (set_cursor_from_row): If called for a mode-line or header-line
4030 row, return zero immediately.
4031 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4032 farther than the first row after the header line, if any.
4033 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4034 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4035
c07a4c0b 40362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4037
4ae29f89
SM
4038 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4039 (bug#11238).
ad3a2b41 4040
c07a4c0b 40412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 40422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4043
4044 configure: new option --enable-gcc-warnings (Bug#11207)
4045 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4046 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4047 (ALL_CFLAGS): Use new macros rather than old.
4048 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4049 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4050 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4051 -Wunused-result, -Wunused-variable. This should go away once
4052 the Emacs and Gnulib regex code is merged.
4053 (xmalloc, xrealloc): Now static.
4054
aba027e8
PE
40552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 * dired.c (Fsystem_groups): Remove unused local.
4058
e5a36063
GM
40592012-04-17 Glenn Morris <rgm@gnu.org>
4060
4061 * dired.c (Fsystem_users): Doc fix.
4062
316411f0
DA
40632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4064
4065 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4066 (syms_of_dired): Add them.
4067
9426aba4
PE
40682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4069
b62a57be
PE
4070 Fix minor alloc.c problems found by static checking.
4071 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4072 New extern decls, to avoid calling undeclared functions.
4073 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4074 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4075 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4076 (NEED_MEM_INSERT): New macro.
4077 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4078 Remove one incorrect comment and fix another.
b62a57be 4079
3539f31f
PE
4080 Fix minor ralloc.c problems found by static checking.
4081 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4082 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4083 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4084 (r_alloc_sbrk): Now static.
4085
a041960a
PE
4086 Improve ralloc.c interface checking.
4087 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4088 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4089 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4090 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4091 [REL_ALLOC]: ... to here, to check interface.
4092 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4093 Remove decls. This fixes an "It stinks!".
4094
9426aba4
PE
4095 * alloc.c (which_symbols): Fix alignment issue / type clash.
4096
d55c12ed
AS
40972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4098
4099 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4100 (struct Lisp_Misc_Any): Likewise.
4101 (struct Lisp_Free): Likewise.
4102 * alloc.c (union aligned_Lisp_Symbol): Define.
4103 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4104 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4105 (union aligned_Lisp_Misc): Define.
4106 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4107 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4108 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4109
b948ce8b
PE
41102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4111
4112 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4113 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4114 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4115 * s/netbsd.h, s/sol2-6.h:
4116 Remove definition of GC_MARK_STACK, since the default now works.
4117 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4118 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4119 no longer the default.
4120 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4121
35dc09a1 41222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4123
35dc09a1
GM
4124 * lread.c (lisp_file_lexically_bound_p):
4125 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4126
35dc09a1
GM
41272012-04-14 Eli Zaretskii <eliz@gnu.org>
4128
4129 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4130 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4131
41322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4133
4134 * nsterm.m (constrainFrameRect): Always constrain when there is only
4135 one screen (Bug#10962).
4136
bcd86815
KB
41372012-04-13 Ken Brown <kbrown@cornell.edu>
4138
4139 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4140
c25df26e
RT
41412012-04-13 Reuben Thomas <rrt@sc3d.org>
4142
4143 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4144
0fc59f1e
DC
41452012-04-11 Daniel Colascione <dancol@dancol.org>
4146
4147 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4148 against is gone. It's better to use vfork now so that when Cygwin
4149 gains a new, working vfork, we use it automatically (bug#10398).
4150
de8c03dc
SM
41512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4152
4153 * window.c (save_window_save): Obey window-point-insertion-type.
4154
2f097256
GM
41552012-04-11 Glenn Morris <rgm@gnu.org>
4156
4157 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4158
453b951e
SM
41592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4160
4161 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4162
75f1671a 41632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4164
4165 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4166 (force_quit_count): New var.
4167 (handle_interrupt): Use it.
4168
2a8ce227
JB
41692012-04-10 Juanma Barranquero <lekktu@gmail.com>
4170
4171 * w32.c (w32_delayed_load): Record the full path of the library
4172 being loaded (bug#10424).
4173
935396c0
GM
41742012-04-09 Glenn Morris <rgm@gnu.org>
4175
05920a43
GM
4176 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4177 not just in the obarray, before snarfing them. (Bug#11036)
4178
935396c0
GM
4179 * Makefile.in ($(leimdir)/leim-list.el):
4180 Pass EMACS rather than BUILT_EMACS.
4181
a18ecafa
TZ
41822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4183
4184 * process.c (make_process):
4185 * process.h: Add integer `gnutls_handshakes_tried' member to
4186 process struct.
4187
6bbef4e5
JC
4188 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4189 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4190
4191 * gnutls.c (gnutls_log_function2i): Convenience log function.
4192 (emacs_gnutls_read): Use new log functions,
4193 `gnutls_handshakes_tried' process member, and
4194 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4195 attempts per process (connection).
4196
b4d3bc10
CY
41972012-04-09 Chong Yidong <cyd@gnu.org>
4198
4199 * eval.c (Fuser_variable_p, user_variable_p_eh)
4200 (lisp_indirect_variable): Functions deleted.
4201 (Fdefvar): Caller changed.
4202
4203 * callint.c (Finteractive, Fcall_interactively):
4204 * minibuf.c (Fread_variable): Callers changed.
4205
70f4d973
EZ
42062012-04-09 Eli Zaretskii <eliz@gnu.org>
4207
4208 * xdisp.c (set_cursor_from_row): If the display string appears in
4209 the buffer at position that is closer to point than the position
4210 after the display string, display the cursor on the first glyph of
4211 the display string. Fixes cursor display when a 'display' text
4212 property immediately follows invisible text. (Bug#11094)
4213
cb3c2e3e
PE
42142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 composite.c: use 'double' consistently
4217 * composite.c (get_composition_id): Use 'double' consistently
4218 instead of converting 'float' to 'double' and vice versa; this is
4219 easier to understand and avoids a GCC warning.
4220
fd06db5d
GM
42212012-04-09 Glenn Morris <rgm@gnu.org>
4222
50fe702a
GM
4223 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4224 preparation for dumping it with emacs. (Bug#4789)
4225 (leimdir): New variable.
4226 ($(leimdir)/leim-list.el): New rule.
4227 (emacs$(EXEEXT)): Depend on leim-list.el.
4228
fd06db5d
GM
4229 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4230 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4231 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4232
55c131ee
AS
42332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4234
4235 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4236 proper alignment.
4237
9209588f
JB
42382012-04-07 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4241 Remove unused local variable.
4242
e3fb2efb
PE
42432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4246 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4247 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4248 objects, as mark_maybe_pointer will catch them otherwise.
4249 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4250 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4251
b5385551
PE
42522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 Fix typo that broke non-Windows builds.
4255 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4256
9078ead6
EZ
42572012-04-07 Eli Zaretskii <eliz@gnu.org>
4258
4259 Support building on MS-Windows with libxml2.
4260
4261 * makefile.w32-in (OBJ2): Add xml.$(O).
4262 (GLOBAL_SOURCES): Add xml.c.
4263 ($(BLD)/xml.$(O)): New dependency list.
4264
4265 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4266 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4267 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4268 [!WINDOWSNT]: New macros.
4269 (init_libxml2_functions, libxml2_loaded_p): New functions.
4270 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4271 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4272 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4273 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4274 linked in).
6bbef4e5
JC
4275 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4276 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4277 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4278
4279 * emacs.c: Don't include libxml/parser.h.
4280 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4281 xmlCleanupParser directly.
4282
4283 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4284
3811fdf3
EZ
42852012-04-07 Eli Zaretskii <eliz@gnu.org>
4286
4287 * indent.c (Fvertical_motion): If there is a display string at
4288 point, use it.vpos to compute how many lines to backtrack after
4289 move_it_to point. (Bug#11133)
4290
2f8e16b2
EZ
42912012-04-06 Eli Zaretskii <eliz@gnu.org>
4292
4293 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4294 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4295 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4296 macros related to unification of CJK characters. For the details,
4297 see the discussion following the message here:
4298 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4299
3d439cd1
CY
43002012-04-04 Chong Yidong <cyd@gnu.org>
4301
4302 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4303
8bc53d00
EZ
43042012-04-01 Eli Zaretskii <eliz@gnu.org>
4305
4306 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4307 instead of alloca. (Bug#11138)
4308
3b0512a3
AS
43092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4310
4311 * w32menu.c (is_simple_dialog): Properly check lisp types.
4312 (Bug#11141)
4313
8427ddd2
EZ
43142012-03-31 Eli Zaretskii <eliz@gnu.org>
4315
979022ef
EZ
4316 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4317 position we get to after a call to move_it_to fails the
4318 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4319 only if we wind up in a string from display property. (Bug#11063)
4320
a6b1c7cc
EZ
4321 * window.c (Fdelete_other_windows_internal): Invalidate the row
4322 and column information about mouse highlight, so that redisplay
4323 restores it after reallocating the glyph matrices. (Bug#7464)
4324
8427ddd2
EZ
4325 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4326 string comes from a `display' text property, use the buffer
4327 position of that property as if we actually saw that position in
4328 the row's glyphs.
697ba24b
EZ
4329 (move_it_by_lines): Remove the assertion that
4330 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4331 violated when there's a before-string at the beginning of a line.
4332 (Bug#11063)
8427ddd2 4333
65a0a738
EZ
43342012-03-30 Eli Zaretskii <eliz@gnu.org>
4335
4336 * xdisp.c (append_space_for_newline): If the default face was
4337 remapped, use the remapped face for the appended newline.
4338 (extend_face_to_end_of_line): Use the remapped default face for
4339 extending the face to the end of the line.
4340 (display_line): Call extend_face_to_end_of_line when the default
4341 face was remapped. (Bug#11068)
4342
581355cc
EZ
43432012-03-29 Eli Zaretskii <eliz@gnu.org>
4344
4345 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4346
e8fc049f
SM
43472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4348
4349 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4350
4fb9a543
GM
43512012-03-27 Glenn Morris <rgm@gnu.org>
4352
4353 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4354 Doc fixes.
4355
679910f1
KH
43562012-03-26 Kenichi Handa <handa@m17n.org>
4357
4358 * dispextern.h (struct glyph): Fix previous change. Change the
4359 bit length of glyphless.ch to 25 (Bug#11082).
4360
90d49b7f
CY
43612012-03-26 Chong Yidong <cyd@gnu.org>
4362
4363 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4364 (command_loop_1): Use it; inhibit selection update for
4365 handle-select-window too (Bug#8996).
4366
f514f6f0
FP
43672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4368
e8fc049f 4369 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4370
bf43fa51
KH
43712012-03-25 Kenichi Handa <handa@m17n.org>
4372
4373 * dispextern.h (struct glyph): Change the bit length of
4374 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4375
8a0c01dd
EZ
43762012-03-24 Eli Zaretskii <eliz@gnu.org>
4377
4378 * s/ms-w32.h (tzname): Include time.h before redirecting to
4379 _tzname. Fixes the MSVC build. (Bug#9960)
4380
7d1c3a76
AS
43812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4382
8ed79523
AS
4383 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4384 characters.
4385
7d1c3a76
AS
4386 * xterm.c (XTread_socket): Only modify handling_signal if
4387 !SYNC_INPUT. (Bug#11080)
4388
e99a9b8b
EZ
43892012-03-23 Eli Zaretskii <eliz@gnu.org>
4390
4391 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4392 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4393 when fetching a multibyte character consumes more bytes than
4394 CHAR_BYTES returns, due to unification of CJK characters in
4395 string_char. (Bug#11073)
4396
5063c0e1
TN
43972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4398
4399 * process.c (wait_reading_process_output): Handle pty disconnect
4400 by refraining from sending oneself a SIGCHLD (bug#10933).
4401
9f851fbd
CY
44022012-03-22 Chong Yidong <cyd@gnu.org>
4403
4404 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4405
5063c0e1 4406 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4407 Mark string as coming from a prefix property.
4408 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4409 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4410
fb5b8aca
CY
44112012-03-21 Chong Yidong <cyd@gnu.org>
4412
4413 * xfaces.c (Vface_remapping_alist): Doc fix.
4414
62356a1b
EZ
44152012-03-20 Eli Zaretskii <eliz@gnu.org>
4416
4417 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4418 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4419 Doc fixes.
62356a1b 4420
025de85b
CY
44212012-03-20 Chong Yidong <cyd@gnu.org>
4422
4423 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4424 to reflect default non-nil value of redisplay-dont-pause.
4425
4827f94e
KH
44262012-03-19 Kenichi Handa <handa@m17n.org>
4427
4428 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4429 it fit in a valid range (Bug#11003).
4430
e50a24a2
EZ
44312012-03-18 Eli Zaretskii <eliz@gnu.org>
4432
4433 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4434 that is not from display property, accept the row as a "cursor
4435 row" if one of the string's character has a non-nil `cursor'
4436 property. Fixes cursor positioning when there are newlines in
4437 overlay strings, e.g. in icomplete.el. (Bug#11035)
4438
9af5ed87
PE
44392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4440
4441 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4442
d1f55f16
CY
44432012-03-12 Chong Yidong <cyd@gnu.org>
4444
4445 * eval.c (inhibit_lisp_code): Rename from
4446 inhibit_window_configuration_change_hook; move from window.c.
4447
4448 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4449 * window.c (run_window_configuration_change_hook)
4450 (syms_of_window): Callers changed.
4451
66c5eebd
CY
44522012-03-11 Chong Yidong <cyd@gnu.org>
4453
413df973
CY
4454 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4455
66c5eebd
CY
4456 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4457
1de11f56
CY
44582012-03-10 Chong Yidong <cyd@gnu.org>
4459
4460 * frame.c (other_visible_frames): Don't assume the selected frame
4461 is visible (Bug#10955).
4462
cae07000
SM
44632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4464
4465 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4466
89c94350
JD
44672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4468
4469 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4470 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4471 zero (Bug#10954).
4472
999dd333
GM
44732012-03-03 Glenn Morris <rgm@gnu.org>
4474
01a6dcc8 4475 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4476
de0100f2
EZ
44772012-03-02 Eli Zaretskii <eliz@gnu.org>
4478
4479 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4480 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4481 (redisplay_window, next_element_from_string): Fix typos in
4482 comments.
3e441275
EZ
4483 (redisplay_window): Pass to move_it_vertically the margin in
4484 pixels, not in screen lines.
de0100f2 4485
96a72ee9
GM
44862012-03-02 Glenn Morris <rgm@gnu.org>
4487
4488 * buffer.c (buffer-list-update-hook): Doc fix.
4489
312508d7
EZ
44902012-02-29 Eli Zaretskii <eliz@gnu.org>
4491
4492 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4493 push_it before setting up the iterator for the first overlay
4494 string, even if we have an empty string loaded.
4495 (next_overlay_string): If there's an empty string on the iterator
4496 stack, pop the stack. (Bug#10903)
4497
27f3c637
PE
44982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4499
4500 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4501 Suggested by Stefan Monnier in
4502 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4503 * alloc.c (widen_to_Lisp_Object): New static function.
4504 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4505 and widening them to Lisp_Objects. This would work even if
4506 USE_LSB_TAG is defined and wide integers are used, which might
4507 happen in a future version of Emacs.
4508
3c9dfce6
CY
45092012-02-25 Chong Yidong <cyd@gnu.org>
4510
fa74b241
CY
4511 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4512 Doc fix.
4513
3c9dfce6
CY
4514 * xselect.c (Fx_selection_exists_p): Doc fix.
4515 (x_clipboard_manager_save_all): Print an informative message
4516 before saving to clipboard manager.
4517
9486df08
CY
45182012-02-24 Chong Yidong <cyd@gnu.org>
4519
4520 * keyboard.c (process_special_events): Handle all X selection
4521 requests in kbd_buffer, not just the next one (Bug#8869).
4522
f01d3321
CY
45232012-02-23 Chong Yidong <cyd@gnu.org>
4524
4525 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4526 call when setting menu-bar-lines and tool-bar-lines parameters.
4527 (unwind_create_frame_1): New helper function.
4528
4529 * window.c (inhibit_window_configuration_change_hook): New var.
4530 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4531 (syms_of_window): Initialize it.
f01d3321 4532
86b847b6
CY
45332012-02-22 Chong Yidong <cyd@gnu.org>
4534
4535 * xterm.c (x_draw_image_relief): Add missing type check for
4536 Vtool_bar_button_margin (Bug#10743).
4537
a59225b1
CY
45382012-02-21 Chong Yidong <cyd@gnu.org>
4539
4540 * fileio.c (Vfile_name_handler_alist): Doc fix.
4541
4542 * buffer.c (Fget_file_buffer): Protect against invalid file
4543 handler return value.
4544
310f5bd4
PE
45452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4546
cb3a28cc
PE
4547 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4548 when computing $valmask.
4549
310f5bd4
PE
4550 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4551 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4552 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4553 It's useless in that case, and it can cause problems on hosts
4554 that allocate halves of EMACS_INT values separately.
4555 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4556 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4557 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4558 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4559 it avoids undefined behavior on hosts where shifting right by more
4560 than the word width has undefined behavior.
4561
2375c96a
CY
45622012-02-19 Chong Yidong <cyd@gnu.org>
4563
4564 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4565 (Funhandled_file_name_directory, Ffile_name_as_directory)
4566 (Fdirectory_file_name, Fexpand_file_name)
4567 (Fsubstitute_in_file_name): Protect against invalid file handler
4568 return values (Bug#10845).
4569
3eb49e71
EZ
45702012-02-18 Eli Zaretskii <eliz@gnu.org>
4571
4572 * .gdbinit (pitx): Fix incorrect references to fields of the
4573 iterator stack.
4574
7b926f3f
CY
45752012-02-17 Chong Yidong <cyd@gnu.org>
4576
4577 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4578
11273115
PE
45792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4582 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4583
c3a70e2b
CY
45842012-02-15 Chong Yidong <cyd@gnu.org>
4585
4586 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4587 marked as special. Also, starting docstrings with * is obsolete.
4588
0ca43699
AS
45892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4590
4591 * gnutls.c (emacs_gnutls_write): Fix last change.
4592
2e8f3c56
LI
45932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4594
4595 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4596 send_process.
4597
af70074f
SM
45982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4599
4600 * keymap.c (Fsingle_key_description): Handle char ranges.
4601
95986d52
CY
46022012-02-12 Chong Yidong <cyd@gnu.org>
4603
afd83bd1
CY
4604 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4605 as that creates a dangerous corner case.
4606
95986d52
CY
4607 * window.c (Fdelete_window_internal): Invalidate the mouse
4608 highlight (Bug#9904).
4609
bd7da63e
GM
46102012-02-12 Glenn Morris <rgm@gnu.org>
4611
4612 * xselect.c (Fx_own_selection_internal)
4613 (Fx_get_selection_internal, Fx_disown_selection_internal)
4614 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4615 * nsselect.m (Fx_own_selection_internal)
4616 (Fx_disown_selection_internal, Fx_selection_exists_p)
4617 (Fx_selection_owner_p, Fx_get_selection_internal):
4618 Sync docs and argument specs with the xselect.c versions.
4619
77abcbc2
LI
46202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4621
4622 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4623
90b671e2
EZ
46242012-02-11 Eli Zaretskii <eliz@gnu.org>
4625
1c0ca0b7
EZ
4626 * w32select.c (Fx_selection_exists_p): Sync doc string and
4627 argument list with xselect.c. (Bug#10783)
4628
4629 * w16select.c (Fx_selection_exists_p): Sync doc string and
4630 argument list with xselect.c. (Bug#10783)
90b671e2 4631
49241268
GM
46322012-02-10 Glenn Morris <rgm@gnu.org>
4633
4634 * fns.c (Fsecure_hash): Doc fix.
4635
f998bbe7 46362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4637
4638 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4639
0992bd9c
CY
46402012-02-07 Chong Yidong <cyd@gnu.org>
4641
4642 * buffer.c (Fbuffer_local_variables)
4643 (buffer_lisp_local_variables): Handle unbound vars correctly;
4644 don't let Qunbound leak into Lisp.
4645
af008560
GM
46462012-02-07 Glenn Morris <rgm@gnu.org>
4647
dd605cc4
GM
4648 * image.c (Fimagemagick_types): Doc fix.
4649
af008560
GM
4650 * image.c (imagemagick-render-type): Change it from a lisp object
4651 to an integer. Move the doc here from the lisp manual.
4652 Treat all values not equal to 0 the same.
4653
1449fa1d
CY
46542012-02-06 Chong Yidong <cyd@gnu.org>
4655
4656 * doc.c (store_function_docstring): Avoid applying docstring of
4657 alias to base function (Bug#2603).
4658
3723ec07
AS
46592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4660
4661 * .gdbinit (pp1, pv1): Remove redundant defines.
4662 (pr): Use pp.
4663
79c1cc1e
CY
46642012-02-04 Chong Yidong <cyd@gnu.org>
4665
4666 * nsterm.m: Declare a global (Bug#10694).
4667
d7f29f8e
EZ
46682012-02-04 Eli Zaretskii <eliz@gnu.org>
4669
cae07000
SM
4670 * w32.c (get_emacs_configuration_options):
4671 Include --enable-checking, if specified, in the return value.
d7f29f8e 4672
3b95a6f9
MR
46732012-02-04 Martin Rudalics <rudalics@gmx.at>
4674
4675 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4676 after rounding frame sizes. (Bug#9723)
4677
d6fa96a6
EZ
46782012-02-04 Eli Zaretskii <eliz@gnu.org>
4679
4680 * keyboard.c (adjust_point_for_property): Don't position point
4681 before BEGV. (Bug#10696)
4682
df0b2940
PE
46832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 Handle overflow when computing char display width (Bug#9496).
4686 * character.c (char_width): Return EMACS_INT, not int.
4687 (char_width, c_string_width): Check for overflow when
4688 computing the width; this is possible now that individual
4689 characters can have unbounded width. Problem introduced
4690 by merge from Emacs 23 on 2012-01-19.
4691
6bee44d6
MA
46922012-02-02 Michael Albinus <michael.albinus@gmx.de>
4693
4694 * dbusbind.c (Fdbus_register_method): Mention the return value
4695 :ignore in the docstring.
4696
44f92739
GM
46972012-02-02 Glenn Morris <rgm@gnu.org>
4698
1b9f60cc
GM
4699 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4700
44f92739
GM
4701 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4702 Unconditionally set to t. (Bug#10673)
4703 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4704 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4705 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4706
c5d3843c
KH
47072012-02-02 Kenichi Handa <handa@m17n.org>
4708
4709 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4710 0, do not call append_composite_glyph.
4711
159462d4 47122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4713
4714 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4715 NULL (Bug#6988).
4716 (x_produce_glyphs): If the component of a composition is a null
4717 string, set it->pixel_width to 1 to avoid zero-width glyph.
4718
78cef877
EZ
47192012-02-01 Eli Zaretskii <eliz@gnu.org>
4720
4721 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4722 first 2 arguments are identical. This makes inserting large
4723 output from a subprocess an order of magnitude faster on
4724 MS-Windows, where all sbrk'ed memory is always contiguous.
4725
97897668
GM
47262012-01-31 Glenn Morris <rgm@gnu.org>
4727
4728 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4729 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4730 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4731
31fd3586
GM
47322012-01-29 Glenn Morris <rgm@gnu.org>
4733
4734 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4735
0e24a8b2
CY
47362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4737
4738 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4739
cc0adcb0
CY
47402012-01-28 Chong Yidong <cyd@gnu.org>
4741
4742 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4743
acc28cb9
CY
47442012-01-26 Chong Yidong <cyd@gnu.org>
4745
9c69cfb7
CY
4746 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4747
acc28cb9
CY
4748 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4749 repeat counts (Bug#10507).
4750
48da7392
GM
47512012-01-26 Glenn Morris <rgm@gnu.org>
4752
4753 * lread.c (syms_of_lread): Doc fix.
4754
14af5f7f
CY
47552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4756
4757 * coding.c (encode_designation_at_bol): Change return value to
4758 EMACS_INT.
4759
0b21c100
CY
47602012-01-25 Chong Yidong <cyd@gnu.org>
4761
4762 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4763
3c2907f7
CY
47642012-01-21 Chong Yidong <cyd@gnu.org>
4765
4766 * floatfns.c (Fcopysign): Make the second argument non-optional,
4767 since nil is not allowed anyway.
4768
959ad23f
AS
47692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4770
4771 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4772 (send_process): Likewise.
4773
34a02f46
MR
47742012-01-19 Martin Rudalics <rudalics@gmx.at>
4775
4776 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4777 (Vwindow_persistent_parameters): Do not use Qstate.
4778 Rewrite doc-strings.
34a02f46 4779
1259009a 47802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4781
4782 * character.c (char_width): New function.
70d4fdf6
GM
4783 (Fchar_width, c_string_width, lisp_string_width):
4784 Use char_width (Bug#9496).
25ed9e61 4785
6a6ee00d
MR
47862012-01-16 Martin Rudalics <rudalics@gmx.at>
4787
4788 * window.c (Vwindow_persistent_parameters): New variable.
4789 (Fset_window_configuration, save_window_save): Handle persistent
4790 window parameters.
4791
c85efaf7
EZ
47922012-01-14 Eli Zaretskii <eliz@gnu.org>
4793
4794 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4795 thrashing the stack of the thread. (Bug#9087)
4796
5944709e
PE
47972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4800
e71f5d99
EZ
48012012-01-11 Eli Zaretskii <eliz@gnu.org>
4802
4803 * xdisp.c (rows_from_pos_range): Handle the case where the
4804 highlight ends on a newline. (Bug#10464)
4805 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4806 he end column for display of highlight that ends on a newline
4807 before a R2L line.
4808
ce316182
GM
48092012-01-11 Glenn Morris <rgm@gnu.org>
4810
4811 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4812 from load-path also when installation-directory is nil. (Bug#10208)
4813
5b43da69
GM
48142012-01-10 Glenn Morris <rgm@gnu.org>
4815
74cc8ff9
GM
4816 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4817
7d8d6e4e
GM
4818 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4819 Update template values to be closer to their typical values these days.
5b43da69 4820
a0db8d43
EZ
48212012-01-09 Eli Zaretskii <eliz@gnu.org>
4822
4823 * xdisp.c (rows_from_pos_range): Accept additional argument
4824 DISP_STRING, and accept any glyph in a row whose object is that
4825 string as eligible for mouse highlight. Fixes mouse highlight of
4826 display strings from overlays. (Bug#10464)
4827
9a0115ab 48282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4829
b9110d6a 4830 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4831 * fileio.c (auto_saving_dir_umask): New static var.
4832 (Fmake_directory_internal): Use it.
4833 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4834 creating the directory. The old code temporarily assigns
4835 too-generous permissions to the directory.
4836 (do_auto_save_eh): Clear it.
b9110d6a 4837 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4838 that the var is always cleared.
4839
6c1bd3f3
EZ
48402012-01-07 Eli Zaretskii <eliz@gnu.org>
4841
4842 * search.c (scan_buffer): Pass character positions to
4843 know_region_cache, not byte positions. (Bug#6540)
4844
069d2b50
L
48452012-01-07 LynX <_LynX@bk.ru> (tiny change)
4846
4847 * w32.c (sys_rename): Report EXDEV when rename of a directory
4848 fails because the target is on another logical disk. (Bug#10284)
4849
75bf0d33
DB
48502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4851
4852 * xterm.c (x_embed_request_focus): New function.
4853
4854 * xterm.h: Add prototype.
4855
4856 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4857
1c6e5a32
GM
48582012-01-05 Glenn Morris <rgm@gnu.org>
4859
4860 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4861
651e947e
EZ
48622012-01-01 Eli Zaretskii <eliz@gnu.org>
4863
4864 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4865 Load gnutls_transport_set_lowat only if GnuTLS version is below
4866 2.11.1.
4867 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4868 GnuTLS versions below 2.11.1.
4869
3778cdd8
AL
48702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4871
4872 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4873 to the doc string advising against its use for altering the way
4874 windows are scrolled.
4875
0e5317f7
KH
48762011-12-28 Kenichi Handa <handa@m17n.org>
4877
4878 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4879 coding-system ASCII compatible only when it does not produce BOM
4880 on encoding (Bug#10383).
4881
93d5ca1f
JD
48822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4883
4884 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4885 can scroll.
4886 (create_and_show_popup_menu): Always use menu_position_func for
4887 Gtk3 (Bug#10361).
4888
ca22b785
AS
48892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4890
4891 * callint.c (Fcall_interactively): Don't truncate prompt string.
4892
d048e1e6
EZ
48932011-12-23 Eli Zaretskii <eliz@gnu.org>
4894
4895 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4896 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4897 resumed from there (after widening). (Bug#10360)
d048e1e6 4898
5ccaba1f
JD
48992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4900
4901 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4902
204ee57f
JD
49032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4904
b81d40f0
JB
4905 * nsterm.m (x_free_frame_resources):
4906 Release f->output_data.ns->miniimage.
204ee57f
JD
4907 (ns_index_color): Fix indentation. Do not retain
4908 color_table->colors[i].
4909
4910 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4911 before returning.
4912
4913 * nsfns.m (x_set_background_color): Assign return value from
4914 ns_index_color to face-background instead of NSColor*.
4915 (ns_implicitly_set_icon_type): Fix indentation.
4916 Change assignment in for loop to comparison.
4917
4918 * emacs.c (ns_pool): New variable.
4919 (main): Assign ns_pool.
4920 (Fkill_emacs): Call ns_release_autorelease_pool.
4921
4922 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4923 autorelease fdesc, release fdAttrs and tdict.
4924 (ns_get_covering_families): Release charset.
4925 (ns_findfonts): Release NSFontDescriptor created with new.
4926 (ns_uni_to_glyphs): Fix indentation.
4927 (setString): Release attrStr before assigning new value.
4928
c803b2b7
JD
49292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4930
678f4426
JD
4931 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4932 and NS_IMPL_COCOA.
4933 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4934 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4935
cd394be1 49362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4937
5fecd5fc
JD
4938 * nsterm.m (ns_term_init): Subscribe for notifications
4939 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4940 to method trackingNotification in EmacsMenu.
4941
4942 * nsmenu.m (trackingMenu): New variable.
3771cb17 4943 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4944 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4945 from Aquamacs (Bug#7030).
678f4426
JD
4946
49472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4948
c803b2b7
JD
4949 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4950 (symbol_to_nsstring): Fix indentation.
4951 (ns_symbol_to_pb): New function.
cae07000
SM
4952 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4953 (Fns_rotate_cut_buffers_internal): Remove.
4954 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4955 Fns_store_cut_buffer_internal.
4956 (ns_get_foreign_selection, Fx_own_selection_internal)
4957 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4958 (Fns_get_selection_internal, Fns_store_selection_internal):
4959 Use ns_symbol_to_pb and check if return value is nil.
4960 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4961 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4962 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4963 renamed to Sns_store_selection_internal.
4964 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4965 and remove this function.
4966 (ns_handle_selection_clear): Remove, never used.
4967 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4968 here.
4969
e1b01a3a
KB
49702011-12-17 Ken Brown <kbrown@cornell.edu>
4971
4972 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4973 GID is unknown (Bug#10257).
4974
2adb6e85
PE
49752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4976
4977 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4978 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4979 which caused a build failure on GNU/Linux IA-64. This problem was
4980 introduced by my 2011-10-07 patch.
4981
d1d7b339
JL
49822011-12-15 Juri Linkov <juri@jurta.org>
4983
4984 * image.c (imagemagick_error): New function. (Bug#10112)
4985 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4986 Use `imagemagick_error' where ImageMagick functions return
4987 `MagickFalse'.
4988 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4989 proper order.
4990
100d5755
KH
49912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4992
4993 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4994 fill background (Bug#8992).
4995
454592a6
MR
49962011-12-13 Martin Rudalics <rudalics@gmx.at>
4997
4998 * window.c (Vwindow_combination_resize)
4999 (Vwindow_combination_limit): Use t instead of non-nil in
5000 doc-strings.
61d4b438
MR
5001 (Vrecenter_redisplay): Add first sentence of doc-string on
5002 separate line.
53524d93 5003 (Frecenter): Fix doc-string typo.
454592a6 5004
3633e3aa
KH
50052011-12-11 Kenichi Handa <handa@m17n.org>
5006
5007 * coding.c (Funencodable_char_position): Pay attention to the
5008 buffer text relocation (Bug#9389).
5009
7b9d523a 50102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5011
7b9d523a
JD
5012 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5013 gtk_init (Bug#10100).
5014
b73189c6
EZ
50152011-12-10 Eli Zaretskii <eliz@gnu.org>
5016
5017 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5018 IT->string is nil. (Bug#10263)
5019
f7dfe5d6
JD
50202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5021
83faebb4
JD
5022 * nsterm.h (x_free_frame_resources): Declare.
5023
f7dfe5d6
JD
5024 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5025 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5026
5027 * nsterm.h (ns_get_defaults_value): Declare.
5028
5029 * nsterm.m (ns_default): Call ns_get_defaults_value.
5030
7cd4e72c
EZ
50312011-12-09 Eli Zaretskii <eliz@gnu.org>
5032
5033 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5034 (Bug#10170)
5035
b34d7317
YM
50362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5037
5038 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5039 that where the value of an _OBJC_* symbol points to is in the .bss
5040 section (Bug#10240).
5041
76470ad1
KH
50422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5043
5044 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5045 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5046
745fff94
KH
50472011-12-08 Kenichi Handa <handa@m17n.org>
5048
5049 * ftfont.c (get_adstyle_property): Fix previous change
5050 (Bug#10233).
5051
6e44397c
JB
50522011-12-07 Juanma Barranquero <lekktu@gmail.com>
5053
5054 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5055 dirs from the default value of EMACSLOADPATH (bug#10208).
5056
7efa6272
GM
50572011-12-07 Glenn Morris <rgm@gnu.org>
5058
5059 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5060 installation and source directories as well. (Bug#10208)
5061
f6fc4d87
CY
50622011-12-06 Chong Yidong <cyd@gnu.org>
5063
5064 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5065
2bf26180
GM
50662011-12-06 Glenn Morris <rgm@gnu.org>
5067
5068 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5069 as an error, not just -1. (Bug#10217)
5070
3a6ad4f0
CY
50712011-12-05 Chong Yidong <cyd@gnu.org>
5072
5073 * keyboard.c (process_special_events): New function.
5074 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5075
75a3b399
PE
50762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5077
5078 * coding.c (encode_designation_at_bol): Don't use uninitialized
5079 local variable (Bug#9318).
5080
c3c9e25e
KH
50812011-12-05 Kenichi Handa <handa@m17n.org>
5082
5083 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5084 return Qnil (Bug#8046, Bug#10193).
5085
5eb05ea3
KH
50862011-12-05 Kenichi Handa <handa@m17n.org>
5087
5088 * coding.c (encode_designation_at_bol): New args charbuf_end and
5089 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5090 (coding_set_source): Return how many bytes coding->source was
5091 relocated.
5092 (coding_set_destination): Return how many bytes
5093 coding->destination was relocated.
5094 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5095 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5096
50972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5098
5099 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5100 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5101 macro (Bug#9318).
5102
51032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5104
5105 The following changes are to fix Bug#9318.
5106
a79703f5 5107 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5108 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5109 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5110 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5111
7dbda6df
JB
51122011-12-05 Juanma Barranquero <lekktu@gmail.com>
5113
5114 * lisp.h (process_quit_flag): Fix external declaration.
5115
6d5eb5b0
SM
51162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5117
5118 Don't macro-inline non-performance-critical code.
5119 * eval.c (process_quit_flag): New function.
5120 * lisp.h (QUIT): Use it.
5121
a0c3fad0
JD
51222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5123
5124 * nsfns.m (get_geometry_from_preferences): New function.
5125 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5126
6c07aac2
AS
51272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5128
5129 * emacs.c (Qkill_emacs): Define.
5130 (syms_of_emacs): Initialize it.
5131 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5132 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5133 (quit_throw_to_read_char): Add parameter `from_signal'.
5134 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5135 * lisp.h (QUIT): Call Fkill_emacs if requested.
5136
c052ead4
JD
51372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5138
5139 * widget.c (update_wm_hints): Return if wmshell is null.
5140 (widget_update_wm_size_hints): New function.
5141
5142 * widget.h (widget_update_wm_size_hints): Declare.
5143
5144 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5145 widget_update_wm_size_hints (Bug#10104).
5146
9e49252b
EZ
51472011-12-03 Eli Zaretskii <eliz@gnu.org>
5148
5149 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5150 before a newline, prepare the bidi iterator for consuming the
5151 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5152 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5153
02b16839
JL
51542011-12-02 Juri Linkov <juri@jurta.org>
5155
5156 * search.c (Fword_search_regexp): New Lisp function created from
5157 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5158 (Fword_search_backward, Fword_search_forward)
5159 (Fword_search_backward_lax, Fword_search_forward_lax):
5160 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5161 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5162
0068070e
SM
51632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5164
5165 * fileio.c (Finsert_file_contents): Move after-change-function call
5166 to before the "handled:" label, since all "goto handled" appear in
5167 cases where the *-change-functions have already been properly called
5168 (bug#10117).
5169
3360a3fc
AS
51702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5171
5172 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5173 waiting for input. (Bug#10169)
5174
73d6c093
EZ
51752011-11-30 Eli Zaretskii <eliz@gnu.org>
5176
5177 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5178 verifies glyph row's hash code--we have just reallocated the
5179 glyphs, so their contents can be complete garbage. (Bug#10164)
5180
febe6bea
JB
51812011-11-30 Juanma Barranquero <lekktu@gmail.com>
5182
5183 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5184
801a4313
EZ
51852011-11-30 Eli Zaretskii <eliz@gnu.org>
5186
5187 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5188 attributes are tested _before_ calling verify_row_hash, to protect
5189 against GCC re-ordering of the tests. (Bug#10164)
5190
2b56b87e
JD
51912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5192
5193 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5194
5195 * xterm.c (handle_one_xevent): Only set async_visible and friends
5196 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5197 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5198 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5199
dbf31225
PE
52002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5201
5202 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5203 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5204 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5205 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5206 All uses changed to use GCPRO1 etc.
5207 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5208 Revert to old implementation (i.e., before 2011-03-11).
5209
1305621b
YM
52102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5211
5212 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5213 of scroll runs so as to avoid assigning disabled bogus rows and
5214 unnecessary graphics copy operations.
5215
8c9afb46
EZ
52162011-11-27 Eli Zaretskii <eliz@gnu.org>
5217
5218 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5219 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5220 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5221 (malloc, free, realloc, calloc): Redirect to e_* only when
5222 compiling Emacs.
5223
5224 * lisp.h (GCTYPEBITS): Move before first use.
5225 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5226 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5227 this macro definition.
5228
5229 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5230 _MSC_VER.
5231
54e9e3bf
JD
52322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5233
6d5eb5b0
SM
5234 * gtkutil.c (xg_create_frame_widgets):
5235 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5236 present with Gtk+ 2.0.
5237
83aca1cb
PE
52382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 * fileio.c (Finsert_file_contents): Undo previous change; see
5241 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5242
5b76caa4
PE
52432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5244
5245 Rename locals to avoid shadowing.
5246 * fileio.c (Finsert_file_contents):
5247 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5248 * process.c (wait_reading_process_output):
5249 Rename inner 'proc' to 'p' to avoid shadowing.
5250 Indent for consistency with usual Emacs style.
5251
8c535114
EZ
52522011-11-25 Eli Zaretskii <eliz@gnu.org>
5253
5254 * xdisp.c (redisplay_window): If cursor row is not fully visible
5255 after recentering, and scroll-conservatively is set to a large
5256 number, scroll window by a few more lines to make the cursor fully
5257 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5258 (start_display): Don't move to the next line if the display should
5259 start at a newline that is part of a display vector or an overlay
5260 string. (Bug#10119)
8c535114 5261
fa4fdb5c
JL
52622011-11-24 Juri Linkov <juri@jurta.org>
5263
5264 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5265 after the `MagickPingImage' call. (Bug#10112)
5266
90ec88df
CY
52672011-11-23 Chong Yidong <cyd@gnu.org>
5268
5269 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5270
56e2e794
MR
52712011-11-23 Martin Rudalics <rudalics@gmx.at>
5272
5273 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5274 making another buffer current. (Bug#10114)
5275
b6e64c41
GM
52762011-11-23 Glenn Morris <rgm@gnu.org>
5277
5278 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5279
6b21de18
CY
52802011-11-23 Chong Yidong <cyd@gnu.org>
5281
5282 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5283 using it (Bug#5984).
5284
b12cd789
EZ
52852011-11-22 Eli Zaretskii <eliz@gnu.org>
5286
5287 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5288 and header-lines, as they don't have one computed for them.
5289 (Bug#10098)
5290
5291 * .gdbinit (prow): Make displayed values more self-explaining.
5292 Add row's hash code.
5293
261b6fd4
LMI
52942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5295
5296 * process.c (wait_reading_process_output): Fix asynchrounous
5297 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5298 (wait_reading_process_output): Add comment and URL.
261b6fd4 5299
e7cfd277
JD
53002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5301
5302 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5303
a9b9b7f5
CY
53042011-11-21 Chong Yidong <cyd@gnu.org>
5305
5306 * window.c (Fnext_window, Fprevious_window): Doc fix.
5307
b0d15b4f
SM
53082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5309
5310 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5311
fe7a3057
JB
53122011-11-20 Juanma Barranquero <lekktu@gmail.com>
5313
5314 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5315
d2999b1a
MR
53162011-11-20 Martin Rudalics <rudalics@gmx.at>
5317
5318 * window.c (Fset_window_combination_limit): Rename argument
5319 STATUS to LIMIT.
5320 (Vwindow_combination_limit): Remove "status" from doc-string.
5321
d5ff9cd0
AS
53222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5323
5324 * m/ibms390.h: Remove.
5325 * m/ibms390x.h: Don't include "ibms390.h".
5326
a5bb9bd3
SM
53272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5328
5329 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5330 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5331
cd1181db
JB
53322011-11-20 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * casetab.c (Fset_case_table):
5335 * charset.c (Fcharset_after): Fix typos.
5336
615a3b8d 53372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5338
17e845af
PE
5339 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5340 Otherwise, valgrind does not work on some platforms.
5341 Problem reported by Andreas Schwab in
6a0bf43d
PE
5342 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5343 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5344 is set, removing the need for VIRT_ADDRESS_VARIES.
5345 (PURE_P): Use a more-efficient implementation that needs just one
5346 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5347 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5348 to 4 (xorl, subq, cmpq, setbe).
5349 * alloc.c (pure): Always extern now, since that's the
5350 VIRT_ADDR_VARIES behavior.
5351 (PURE_POINTER_P): Use a single comparison, not two, for
5352 consistency with the new puresize.h.
5353 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5354 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5355 Remove VIRT_ADDR_VARIES no longer needed.
5356
f8fe6f96
EZ
53572011-11-19 Eli Zaretskii <eliz@gnu.org>
5358
5359 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5360 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5361 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5362 behave as if the cursor position were at the window margin.
5363
5364 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5365 and the cursor position is out of bounds, behave as if the cursor
5366 position were at the window margin. (Bug#10075)
5367
df05a53c
CY
53682011-11-18 Chong Yidong <cyd@gnu.org>
5369
5370 * window.c (Fwindow_combination_limit): Make first argument
5371 non-optional, since it is meaningless for live windows like the
5372 selected window.
61ccba97 5373
2071918e
DA
53742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5375
5376 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5377
b50a28de
SM
53782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5379
5380 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5381 (graft_intervals_into_buffer): Simplify.
5382
015137db
EZ
53832011-11-18 Eli Zaretskii <eliz@gnu.org>
5384
5385 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5386 hash values of the two rows.
5387 (copy_row_except_pointers): Preserve the used[] arrays and the
5388 hash values of the two rows. (Bug#10035)
68c95424 5389 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5390
5391 * xdisp.c (row_hash): New function, body extracted from
5392 compute_line_metrics.
5393 (compute_line_metrics): Call row_hash, instead of computing the
5394 hash code inline.
5395
5396 * dispnew.c (verify_row_hash): Call row_hash for computing the
5397 hash code of a row, instead of duplicating code from xdisp.c.
5398
5399 * dispextern.h (row_hash): Add prototype.
5400
a2addb04
TH
54012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5402
5403 * frame.c (delete_frame): Don't delete the terminal when the last
5404 X frame is closed if emacs is built with GTK toolkit.
5405
df85d315
JB
54062011-11-17 Juanma Barranquero <lekktu@gmail.com>
5407
5408 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5409
a0c2d0ae
MR
54102011-11-17 Martin Rudalics <rudalics@gmx.at>
5411
5412 * window.c (Vwindow_splits): Rename to
5413 Vwindow_combination_resize. Suggested by Juri Linkov.
5414 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5415 of Vwindow_splits.
5416
58179cce
JB
54172011-11-16 Juanma Barranquero <lekktu@gmail.com>
5418
7877f373
JB
5419 * nsfns.m (Fns_font_name):
5420 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5421
b6f67890
MR
54222011-11-16 Martin Rudalics <rudalics@gmx.at>
5423
5424 * window.h (window): Rename slot "nest" to "combination_limit".
5425 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5426 (Fset_window_nest): Rename to Fset_window_combination_limit.
5427 (Vwindow_nest): Rename to Vwindow_combination_limit.
5428 (recombine_windows, make_parent_window, make_window)
5429 (Fsplit_window_internal, saved_window)
5430 (Fset_window_configuration, save_window_save): Rename all
5431 occurrences of window_nest to window_combination_limit.
5432
c7015153
JB
54332011-11-15 Juanma Barranquero <lekktu@gmail.com>
5434
5435 * image.c (imagemagick_load_image): Fix typo.
5436
322ad6ec
EZ
54372011-11-14 Eli Zaretskii <eliz@gnu.org>
5438
5439 * xdisp.c (display_line): Move the call to
5440 highlight_trailing_whitespace before the call to
5441 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5442 faces of all the glyphs to compute ROW's hash value.
5443 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5444
f067b8ec
JB
54452011-11-14 Juanma Barranquero <lekktu@gmail.com>
5446
5447 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5448 just return (bug#10044).
5449
1e5b2111
EZ
54502011-11-12 Eli Zaretskii <eliz@gnu.org>
5451
7ef3cbd5
EZ
5452 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5453 with user-defined heap size. Bump the default size of the temacs
5454 heap to 27MB, to avoid memory warning when running temacs.
5455 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5456
1e5b2111
EZ
5457 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5458 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5459 (verify_row_hash) [XASSERTS]: New function.
5460 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5461 that the hash value of glyph rows is correct.
1e5b2111 5462
89d61221
MR
54632011-11-12 Martin Rudalics <rudalics@gmx.at>
5464
5465 * window.h (window): Remove splits slot.
5466 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5467 (Fdelete_other_windows_internal, make_parent_window)
5468 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5469 (Fset_window_configuration, save_window_save): Don't deal with
5470 split status of windows.
5471 (saved_window): Remove splits slot.
5472 (Vwindow_splits): Rewrite doc-string.
5473
97f18cc8
JD
54742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5475
5476 * xfns.c (unwind_create_frame):
5477 * nsfns.m (unwind_create_frame):
5478 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5479 Vframe_list (Bug#9999).
5480
22a648b4
DA
54812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5482
0b381c7e 5483 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5484
659afede
KH
54852011-11-11 Kenichi Handa <handa@m17n.org>
5486
5487 * callproc.c (Fcall_process): Set the member dst_multibyte of
5488 process_coding.
5489
9ac0394b
KH
54902011-11-11 Johan Bockgård <bojohan@gnu.org>
5491
5492 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5493 avoid a crash (bug#9496).
5494
2fbdc249
CY
54952011-11-09 Chong Yidong <cyd@gnu.org>
5496
5497 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5498 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5499
ac6b1f81
PE
55002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5501
5502 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5503
09db192c
PE
55042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5505
5506 Avoid some portability problems by eschewing 'extern inline' functions.
5507 The trivial performance wins aren't worth the portability hassles; see
5508 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5509 et seq.
5510 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5511 (window_box_width, window_box_left, window_box_left_offset)
5512 (window_box_right, window_box_right_offset): Undo previous change,
5513 by removing the "extern"s.
5514 * intervals.c (adjust_intervals_for_insertion)
5515 (adjust_intervals_for_deletion): Undo previous change,
5516 making these static again.
5517 (offset_intervals, temp_set_point_both, temp_set_point)
5518 (copy_intervals_to_string): No longer inline.
5519 * xdisp.c (window_text_bottom_y, window_box_width)
5520 (window_box_height, window_box_left_offset)
5521 (window_box_right_offset, window_box_left, window_box_right)
5522 (window_box): No longer inline.
5523
105216ed
CY
55242011-11-08 Chong Yidong <cyd@gnu.org>
5525
5526 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5527 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5528 Signal an error if not a live window.
105216ed
CY
5529 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5530 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5531
ae9e237f
JB
55322011-11-07 Juanma Barranquero <lekktu@gmail.com>
5533
5534 * lisp.h (syms_of_abbrev): Remove declaration.
5535 Reported by CHENG Gao <chenggao@royau.me>.
5536
c7aa8333
EZ
55372011-11-07 Eli Zaretskii <eliz@gnu.org>
5538
5539 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5540 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5541 of temacs in GUI mode.
5542
be7f5545
MR
55432011-11-07 Martin Rudalics <rudalics@gmx.at>
5544
5545 * window.h: Declare delete_all_child_windows instead of
5546 delete_all_subwindows.
5547 * window.c (Fwindow_nest, Fset_window_nest)
5548 (Fset_window_new_total, Fset_window_new_normal)
5549 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5550 (delete_all_subwindows): Rename to delete_all_child_windows.
5551 (Fdelete_other_windows_internal, Fset_window_configuration):
5552 Call delete_all_child_windows instead of delete_all_subwindows.
5553 * frame.c (delete_frame): Call delete_all_child_windows instead
5554 of delete_all_subwindows.
5555
ca78dc43
PE
55562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5557
5558 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5559 This is also needed for porting to any host where GC_MARK_STACK is
5560 not GC_MAKE_GCPROS_NOOPS.
5561 (which_symbols): Use it.
5562
a0241d01
KH
55632011-11-07 Kenichi Handa <handa@m17n.org>
5564
5565 * coding.c (coding_set_destination): Check coding->src_pos only
5566 when coding->src_object is a buffer (bug#9910).
5567
5568 * process.c (send_process): Set the member src_multibyte of coding
5569 to 0 (bug#9911) when sending a unibyte text.
5570
5571 * callproc.c (Fcall_process): Set the member src_multibyte of
5572 process_coding to 0 (bug#9912).
5573
a64bfdfa 55742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5575
5576 * xmenu.c (cleanup_widget_value_tree): New function.
5577 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5578 calling free_menubar_widget_value_tree directly (Bug#9830).
5579
cb41b32a
PE
55802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5581
5582 Fix some portability problems with 'inline'.
5583 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5584 (window_box_width, window_box_left, window_box_left_offset)
5585 (window_box_right, window_box_right_offset): Declare extern.
5586 Otherwise, these inline functions do not conform to C99 and
5587 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5588 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5589 * intervals.c (adjust_intervals_for_insertion)
5590 (adjust_intervals_for_deletion): Now extern, because otherwise the
5591 extern inline functions 'offset_intervals' couldn't refer to it.
5592 (static_offset_intervals): Remove.
5593 (offset_intervals): Rewrite using the old contents of
5594 static_offset_intervals. The old version didn't conform to C99
5595 because an extern inline function contained a reference to an
5596 identifier with static linkage.
5597
b7041366
AS
55982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5599
5600 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5601 GC.
5602
88a37c4d
EZ
56032011-11-06 Eli Zaretskii <eliz@gnu.org>
5604
5605 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5606 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5607 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5608 return Qleft_to_right.
5609
49745b39
CY
56102011-11-06 Chong Yidong <cyd@gnu.org>
5611
5612 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5613 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5614 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5615 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5616 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5617 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5618 (Fwindow_vscroll): Doc fix.
5619 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5620 argument, since it makes no sense to pass a live window and for
5621 consistency with window-child.
5622
1f05cd82
CS
56232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5624
5625 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5626 support MSVC.
5627
22610910
JR
56282011-11-05 Jason Rumney <jasonr@gnu.org>
5629
5630 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5631 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5632 fonts (Bug#6029).
5633 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5634 bitwise arithmetic preventing use of unicode-sip and non-truetype
5635 opentype fonts.
5636
a06776b2
EZ
56372011-11-05 Eli Zaretskii <eliz@gnu.org>
5638
3ad924ba
EZ
5639 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5640 "emacs"-only part.
5641
a06776b2
EZ
5642 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5643 initialization code to keep similarity to xfns.c after changes
5644 from 2011-11-05.
5645
c9e7db78
JD
56462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5647
a97f8f3f
JD
5648 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5649 (unwind_create_frame): New function (Bug#9943).
5650 (Fx_create_frame): Restructure code to be more similar to the one in
5651 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5652 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5653 Move terminal->reference_count++ just before making the frame official
5654 (Bug#9943).
5655
5656 * nsterm.m (x_free_frame_resources): New function.
5657 (x_destroy_window): Move code to x_free_frame_resources.
5658
c9e7db78 5659 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5660 (Fx_create_frame, x_create_tip_frame):
5661 Move terminal->reference_count++ just before making the frame
75f1671a 5662 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5663 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5664
a6fc3b5c
EZ
56652011-11-05 Eli Zaretskii <eliz@gnu.org>
5666
5667 Support MSVC build with newer versions of Visual Studio.
5668 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5669 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5670 nt/gmake.defs.
5671
5672 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5673 which are not supported by MSVC.
5674 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5675 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5676 bitfields.
5677 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5678 types in bitfields.
5679 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5680
5681 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5682
58179cce 56832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5684
5685 Support MSVC build with newer versions of Visual Studio.
5686 * w32.c: Don't include w32api.h for MSVC.
5687 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5688
5689 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5690 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5691 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5692 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5693 e_* cousins.
5694 (alloca) [_MSC_VER]: Define to _alloca.
5695
5696 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5697
5698 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5699
a58c13ed
EZ
57002011-11-04 Eli Zaretskii <eliz@gnu.org>
5701
5702 * xdisp.c (note_mouse_highlight): If either of
5703 previous/next-single-property-change returns nil, treat that as
5704 the beginning or the end of the buffer. (Bug#9955)
5705
fe0b6370
JD
57062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5707
a58c13ed 5708 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5709 label is not null (Bug#9951).
5710 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5711 may be NULL.
5712
89bd5ee1
EZ
57132011-11-04 Eli Zaretskii <eliz@gnu.org>
5714
5715 * window.c (Fwindow_body_size): Mention in the doc string that the
5716 return value is in frame's canonical units. (Bug#9949)
5717
84c3edb9
EZ
57182011-11-03 Eli Zaretskii <eliz@gnu.org>
5719
4e2fb5c7
EZ
5720 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5721
84c3edb9 5722 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5723 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5724 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5725
bc17a887
EZ
57262011-11-01 Eli Zaretskii <eliz@gnu.org>
5727
5728 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5729 Don't stop backward scan on the continuation glyph, even though
5730 its CHARPOS is positive.
6d5eb5b0
SM
5731 (mouse_face_from_buffer_pos, note_mouse_highlight):
5732 Rename cover_string to disp_string.
bc17a887 5733
4ee88440
MR
57342011-11-01 Martin Rudalics <rudalics@gmx.at>
5735
5736 * window.c (temp_output_buffer_show): Don't use
5737 Vtemp_buffer_show_specifiers.
5738 (Vtemp_buffer_show_specifiers): Remove unused variable.
5739
c2ff3c02
EZ
57402011-10-30 Eli Zaretskii <eliz@gnu.org>
5741
5742 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5743 past the beginning of the current glyph matrix.
5744
58179cce 57452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5746
5747 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5748 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5749 HAVE_GTK3 (Bug#9869).
b77a6a7f 5750
3b574623
JD
5751 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5752 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5753
b77a6a7f
JD
5754 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5755
5756 * xterm.c: Declare x_handle_net_wm_state to return int.
5757 (handle_one_xevent): Check if we are iconified but don't have
5758 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5759 (get_current_wm_state): Return non-zero if not hidden,
5760 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5761 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5762 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5763 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5764
196e41e4
PE
57652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5768 so that this new function doesn't get optimized away by a
5769 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5770
021f2e1a
AS
57712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5772
5773 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5774
8b058d44
EZ
57752011-10-29 Eli Zaretskii <eliz@gnu.org>
5776
5777 Fix the `xbytecode' command.
5778 * .gdbinit (xprintbytestr): New command.
b50a28de 5779 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5780 (xbytecode): Print the byte-code string as well.
5781
4452fb80
EZ
57822011-10-29 Kim Storm <storm@cua.dk>
5783
8b058d44
EZ
5784 * alloc.c (which_symbols): New function.
5785
21b72067
AS
57862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5787
5788 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5789 line. (Bug#9903)
5790
83ed7b5c
GM
57912011-10-29 Glenn Morris <rgm@gnu.org>
5792
5793 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5794 Not clear what it was for, and it causes various bugs. (Bug#9839)
5795
5a7a728b
EZ
57962011-10-28 Eli Zaretskii <eliz@gnu.org>
5797
5798 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5799 possible random value that matches one of those tested as
5800 condition to clear the mouse face.
5801
d3d0842f
CY
58022011-10-28 Chong Yidong <cyd@gnu.org>
5803
5804 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5805
31b39d13
DN
58062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5807
5808 * window.c (make_window): Initialize phys_cursor_on_p.
5809
9aba6043
SM
58102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5811
5812 * lisp.h (struct Lisp_Symbol): Update comments.
5813
c20992f4
JB
58142011-10-28 Juanma Barranquero <lekktu@gmail.com>
5815
5816 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5817
db4f02f2
EZ
58182011-10-28 Eli Zaretskii <eliz@gnu.org>
5819
5820 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5821 <oslsachem@gmail.com> for helping to debug this.
5822
5823 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5824 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5825 (g_b_init_get_glyph_outline_w): New static variables.
5826 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5827 (GetGlyphOutlineW_Proc): New typedefs.
5828 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5829 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5830 New functions.
5831 (w32font_open_internal, compute_metrics):
5832 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5833 instead of calling the "wide" APIs directly.
5834
5835 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5836
5837 * w32.h (syms_of_w32font): Add prototype.
5838
87e68db4
JB
58392011-10-27 Juanma Barranquero <lekktu@gmail.com>
5840
5841 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5842 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5843 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5844 (Fmove_to_window_line): Doc fix.
5845
435c1d67
CY
58462011-10-27 Chong Yidong <cyd@gnu.org>
5847
5848 * process.c (make_process): Set gnutls_state to NULL.
5849
5850 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5851 non-NULL, regardless of GNUTLS_INITSTAGE.
5852 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5853 an error. Set process slots as soon as we allocate them.
5854
5855 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5856
9c6c6f49
CY
58572011-10-27 Chong Yidong <cyd@gnu.org>
5858
9aba6043
SM
5859 * gnutls.c (emacs_gnutls_deinit): New function.
5860 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5861 (Fgnutls_deinit, Fgnutls_boot): Use it.
5862
5863 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5864 (deactivate_process): Call emacs_gnutls_deinit.
5865
657d08d3
JB
58662011-10-27 Juanma Barranquero <lekktu@gmail.com>
5867
5868 * image.c (x_create_x_image_and_pixmap):
5869 * w32.c (sys_rename, w32_delayed_load):
5870 * w32font.c (fill_in_logfont):
5871 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5872
5430d399
JB
58732011-10-26 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * w32fns.c (w32_default_color_map): New function,
5876 extracted from Fw32_default_color_map.
a7ef684b 5877 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5878
fe0055fa
PE
58792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5880
5881 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5882
e6346438
SM
58832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5884
5885 * keyboard.c (test_undefined): New function (bug#9751).
5886 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5887
e112cc37
ET
58882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5889
5890 * sysdep.c (init_sys_modes): Fix the check for the controlling
5891 terminal (Bug#6649).
5892
7b5d6677
EZ
58932011-10-20 Eli Zaretskii <eliz@gnu.org>
5894
5895 * dispextern.h (struct bidi_it): New member next_en_type.
5896
5897 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5898 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5899 current character, check also for next_en_type being WEAK_EN.
5900 (bidi_resolve_weak): Don't enter the expensive loop if the current
5901 position is before next_en_pos. Record the bidi type of the first
5902 non-ET, non-BN character we find, in addition to its position.
5903 (bidi_level_of_next_char): Invalidate next_en_type when
5904 next_en_pos is over-stepped.
5905
7da0b018
PE
59062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5907
5908 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5909 * editfns.c: Rewrite current-time-zone so that it invokes
5910 the equivalent of (format-time-string "%Z") to get the time zone name.
5911 This fixes a bug when the time zone name contains characters that
5912 need converting from the system time locale to Emacs internal format.
5913 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5914 that patch fixed format-time-string to do the conversion, but
5915 I forgot to fix current-time-zone.
5916 (format_time_string): New function, containing most of
5917 what Fformat_time_string used to contain.
5918 (Fformat_time_string): Rewrite in terms of format_time_string.
5919 This doesn't change this function's behavior.
5920 (current-time-zone): Rewrite to use format_time_string.
5921 This fixes the bug reported by Michael Schierl in
5922 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5923 Jason Rumney's 2007-06-07 change worked around this bug, but
5924 didn't fix it.
5925 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5926
8547b010
EZ
59272011-10-19 Eli Zaretskii <eliz@gnu.org>
5928
5929 * xdisp.c (start_display): If the character at POS is displayed
5930 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5931 (try_window_reusing_current_matrix): If a line ends in a display
5932 vector or the next line starts in a display vector, continue
5933 redrawing the window even though the character position of
5934 start_row was reached.
8547b010
EZ
5935 (Bug#9771, part 2)
5936
4e948d15
CY
59372011-10-18 Chong Yidong <cyd@gnu.org>
5938
5939 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5940 with nobreak-char-display too.
5941
4787455f
EZ
59422011-10-18 Eli Zaretskii <eliz@gnu.org>
5943
5944 Fix part 3 of bug#9771.
5945 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5946 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5947 non-neutral characters if the current character is a paragraph
5948 separator (a.k.a. Newline). This avoids running the same
5949 expensive loop twice, once when we consume the preceding newline
5950 and the other time when the line actually needs to be displayed.
5951 Avoid the loop when we see neutrals on the base embedding level
5952 following a character whose directionality is the same as the
5953 paragraph's. This avoids running the expensive loop when a line
5954 ends in a long sequence of neutrals, like control characters.
5955 Add assertion against STRONG_AL type. Slightly rearrange code
5956 that determines the type of a neutral given the first non-neutral
5957 that follows it.
5958 (bidi_level_of_next_char): Set next_en_pos to zero when
5959 invalidating its info.
5960
2c91f553
EZ
59612011-10-17 Eli Zaretskii <eliz@gnu.org>
5962
5963 * xdisp.c (push_display_prop): Determine whether to record string
5964 or buffer position by IT->string, not by IT->method. Allow
5965 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5966 (move_it_vertically_backward): Don't look for character position
5967 immediately after the newline when in a continuation line.
5968 (Bug#9771, part 1)
2c91f553 5969
c7b08b0d
MR
59702011-10-15 Martin Rudalics <rudalics@gmx.at>
5971
5972 * window.c (coordinates_in_window): Rewrite and delabelize
5973 vertical border check. (Bug#5357) (Bug#9618)
5974
6b02f655
SM
59752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5976
5977 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5978 errors in XSetWindowBorder (bug#9310).
5979
81d40c92
DA
59802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5981
5982 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5983 avoid crash when xmalloc overrun checking is enabled.
5984
d4172c3b
EZ
59852011-10-13 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5988 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5989 cursor motion with <left> and <right> arrow keys.
5990
5991 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5992 some callers set that themselves.
5993
b00eea75
EZ
59942011-10-12 Eli Zaretskii <eliz@gnu.org>
5995
5996 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5997 display string and the previous row comes from the same string and
5998 is empty. (Bug#9739) (Bug#9738)
5999
8fe012c4
SM
60002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6001
6002 * doc.c (get_doc_string): Encode file name (bug#9735).
6003
0074aef2
EZ
60042011-10-12 Eli Zaretskii <eliz@gnu.org>
6005
79beb178
EZ
6006 * bidi.c (bidi_level_of_next_char):
6007 * xdisp.c (get_visually_first_element): Remove old incorrect
6008 comments regarding the Unicode Line Separator character.
6009
0074aef2
EZ
6010 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6011
6e4b3fbe
DA
60122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6013
6014 * alloc.c (Fgc_status): Do not access beyond zombies array
6015 boundary if nzombies > MAX_ZOMBIES.
6016 * alloc.c (dump_zombies): Add missing format specifier.
6017
0324f3af
PE
60182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6019
b5525cac
PE
6020 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6021 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6022
0324f3af
PE
6023 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6024 Some packages use them to denote characters with modifiers.
6025
e9b5f888
AS
60262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6027
6028 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6029 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6030 matching a pp-number. Rename parameter var to var1.
6031
127827c0
SM
60322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6033
6034 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6035
c8fd3bd0
GM
60362011-10-08 Glenn Morris <rgm@gnu.org>
6037
6038 * callint.c (Fcall_interactively): Give a more explicit error for the
6039 'c' case with a non-character input. (Bug#8479)
6040
352ec8ff
EZ
60412011-10-08 Eli Zaretskii <eliz@gnu.org>
6042
03669ccb
EZ
6043 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6044 lines.
7061c986
EZ
6045 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6046 lines that are hscrolled on the left.
03669ccb 6047
352ec8ff
EZ
6048 * dispnew.c (buffer_posn_from_coords): Account for a possible
6049 presence of header-line. (Bug#4426)
6050
a66cfb1c
SM
60512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6052
6b02f655
SM
6053 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6054 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6055
7c5ee88e
PE
60562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6059 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6060 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6061 this makes Emacs dump core during garbage collection on rare
6062 occasions. sizeof is obviously inferior to offsetof here, so
6063 stick with offsetof.
6064 (GC_POINTER_ALIGNMENT): New macro.
6065 (mark_memory): Omit 3rd (offset) arg; caller changed.
6066 Don't assume EMACS_INT alignment is the same as pointer alignment.
6067
df1bbe5b
SM
60682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6069
6070 * keyboard.c (read_key_sequence_remapped): New var.
6071 (read_key_sequence): Compute remapping in the right buffer.
6072 (command_loop_1): Use read_key_sequence's remapping directly.
6073
51553db6
SM
60742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6075
32c1fffd
SM
6076 * dired.c (file_name_completion): Don't expand file name.
6077 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6078 before checking file name handler.
6079
51553db6
SM
6080 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6081 they've been requested explicitly (bug#9591).
6082
b6bd1599 60832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6084
6085 * keymap.c (Fsingle_key_description): Use make_specified_string
6086 instead of build_string to build string from push_key_description.
6087 (Bug#5193)
6088
f701dc2a
PE
60892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6090
4222c55d
PE
6091 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6092 This fixes a Y2038 bug on 64-bit hosts.
6093 * buffer.c (reset_buffer):
6094 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6095 (Fclear_buffer_auto_save_failure):
6096 Use 0, not -1, to represent an unset failure time, since time_t
6097 might not be signed.
6098
f701dc2a
PE
6099 Remove dependency on glibc malloc internals.
6100 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6101 Move back here from lisp.h, but with their new implementations.
6102 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6103 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6104 * charset.c (charset_table_init): New static var.
6105 (syms_of_charset): Use it instead of xmalloc. This removes a
6106 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6107 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6108 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6109 Move back to alloc.c.
6110 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6111 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6112
9ceebf39
JD
61132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6114
6115 * nsterm.m (windowDidResize): Call x_set_window_size only when
6116 ns_in_resize is true. Otherwise set pixelwidth/height and
6117 call change_frame_size (Bug#9628).
6118
cb993c58
PE
61192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6120
3930c88b
PE
6121 Port --enable-checking=all to Fedora 14 x86-64.
6122 * charset.c (syms_of_charset): Also account for glibc malloc's
6123 internal overhead when calculating the initial malloc maximum.
6124
cb993c58
PE
6125 Port --enable-checking=all to Fedora 14 x86.
6126 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6127 Move to lisp.h.
6128 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6129 (overrun_check_realloc, overrun_check_free):
6130 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6131 That way, xmalloc returns a properly-aligned pointer even if
6132 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6133 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6134 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6135 into account when calculating the initial malloc maximum.
6136 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6137 Move here from alloc.c, so that charset.c can use it too.
6138 Properly align; the old code wasn't right for common 32-bit hosts
6139 when configured with --enable-checking=all.
6140 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6141 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6142
31bed486
EZ
61432011-09-29 Eli Zaretskii <eliz@gnu.org>
6144
04c70788 6145 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6146 use EDOM.
6147
fbcaa2f3
EZ
61482011-09-28 Eli Zaretskii <eliz@gnu.org>
6149
6150 * xdisp.c (compute_display_string_end): If there's no display
6151 string at CHARPOS, return -1.
6152
6153 * bidi.c (bidi_fetch_char): When compute_display_string_end
6154 returns a negative value, treat the character as a normal
6155 character not covered by a display string. (Bug#9624)
6156
a239d4e9
JB
61572011-09-28 Juanma Barranquero <lekktu@gmail.com>
6158
6159 * lread.c (Fread_from_string): Fix typo in docstring.
6160
88652fd5
EZ
61612011-09-27 Eli Zaretskii <eliz@gnu.org>
6162
6163 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6164 newline, reseat the iterator instead of bidi-iterating there one
6165 character at a time. (Bug#9610)
32c1fffd
SM
6166 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6167 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6168
ed497dd4
AS
61692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6170
6171 * lread.c (readevalloop): Use correct code for NBSP.
6172 (read1): Likewise. (Bug#9608)
6173
b2bf61aa
MA
61742011-09-25 Michael Albinus <michael.albinus@gmx.de>
6175
6176 * dbusbind.c (Fdbus_register_signal): When service is not
6177 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6178
32bbb17c
GM
61792011-09-25 Glenn Morris <rgm@gnu.org>
6180
6181 * buffer.c (truncate-lines): Doc fix.
6182
94e0933e
CY
61832011-09-24 Chong Yidong <cyd@stupidchicken.com>
6184
6185 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6186 (Fset_window_next_buffers): Doc fix.
6187
cddde921
GM
61882011-09-24 Glenn Morris <rgm@gnu.org>
6189
6190 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6191
1260aef1
PE
61922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6193
25b4bfa0
PE
6194 Fix minor problems found by static checking.
6195 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6196 * indent.c (Fvertical_motion): Fix == vs = typo.
6197
e3cbd34b
EZ
61982011-09-24 Eli Zaretskii <eliz@gnu.org>
6199
a66cfb1c
SM
6200 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6201 Default value is now t. Doc fix.
6bf7006f 6202
e3cbd34b 6203 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6204 logic when moving up, not only when moving down. Fix the
e3cbd34b 6205 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6206 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6207
6208 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6209 CHARPOS is covered by a display string which includes newlines.
6210 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6211 is covered by a display string with embedded newlines.
6212
a3de0cbd
MA
62132011-09-24 Michael Albinus <michael.albinus@gmx.de>
6214
6215 * dbusbind.c (Fdbus_register_signal): Add match rule to
6216 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6217 (Fdbus_register_method, Vdbus_registered_objects_table):
6218 Fix docstring.
a3de0cbd 6219
b260039d
JM
62202011-09-24 Jim Meyering <meyering@redhat.com>
6221
32c1fffd 6222 do not ignore write error for any output size
b260039d
JM
6223 The previous change was incomplete.
6224 While it makes emacs --batch detect the vast majority of stdout
6225 write failures, errors were still ignored whenever the output size is
6226 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6227 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6228 && echo FAIL: ignored write error
6229 FAIL: ignored write error
6230 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6231 && echo FAIL: ignored write error
6232 FAIL: ignored write error
6233 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6234
8eca8a7c
AS
62352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6236
6237 * emacs.c (Fkill_emacs): In noninteractive mode exit
6238 non-successfully if a write error occurred on stdout. (Bug#9574)
6239
3341db62
EZ
62402011-09-21 Eli Zaretskii <eliz@gnu.org>
6241
6242 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6243 the xassert test.
6244
6245 * dispextern.h (struct it): Update the comment documenting what
6246 can it->OBJECT be.
6247
8c203dbf
EZ
62482011-09-20 Eli Zaretskii <eliz@gnu.org>
6249
6250 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6251 a display string, extend search for cursor position to end of row.
6252 (find_row_edges): If the row ends in a newline from a display
6253 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6254 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6255 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6256 non-empty line. Fixes confusing cursor motion with arrow keys at
6257 the beginning of a line that starts with whitespace.
8c203dbf 6258
a4824228
LMI
62592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6260
6261 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6262 (bug#9493).
6263
33ed493b
CY
62642011-09-18 Chong Yidong <cyd@stupidchicken.com>
6265
6266 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6267 boolean (Bug#9154).
6268
56cd55c8
EZ
62692011-09-18 Eli Zaretskii <eliz@gnu.org>
6270
6271 * xdisp.c (display_line): Record maximum and minimum buffer
6272 positions even if no glyphs were produced (e.g., by a zero-width
6273 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6274 buffer positions that will be removed from the glyph row because
6275 they don't fit.
c02dcedf
EZ
6276 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6277 column is beyond frame width: don't subtract 1 "pixel" when
6278 computing width of the stretch.
3e62b7e0
EZ
6279 (reseat_at_next_visible_line_start): Undo the change made on
6280 2011-09-17 that saved paragraph information and restored it after
6281 the call to `reseat'. (Bug#9545)
56cd55c8 6282
5ed99d36 62832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6284
6285 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6286 and turn window cursor on if cleared (Bug#9415).
6287
5ed99d36 62882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6289
6290 * search.c (boyer_moore): Take unibyte characters from pattern
6291 literally. (Bug#9458)
6292
9bade7b2
EZ
62932011-09-18 Eli Zaretskii <eliz@gnu.org>
6294
6295 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6296
e5e9d610
PE
62972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6298
87e4427a
PE
6299 Fix minor problem found by static checking.
6300 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6301 initialized, to pacify gcc -Wuninitialized.
6302
e5e9d610
PE
6303 * fileio.c: Report proper errno when syscall falls.
6304 (Finsert_file_contents): Save and restore errno,
6305 so that report_file_error outputs the correct diagnostic.
6306 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6307
a1674f0b
EZ
63082011-09-18 Eli Zaretskii <eliz@gnu.org>
6309
6310 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6311
fbfb6dd4
EZ
63122011-09-17 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6315 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6316
bb187662
EZ
63172011-09-17 Eli Zaretskii <eliz@gnu.org>
6318
1137e8b8 6319 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6320 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6321
6322 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6323 (bidi_find_paragraph_start): Search back for paragraph beginning
6324 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6325 (bidi_move_to_visually_next): Only trigger paragraph-related
6326 computations when the last character is a newline or at EOB, not
6327 just any NEUTRAL_B. (Bug#9470)
6328
bb187662
EZ
6329 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6330 truncated lines if point is covered by a display string. (Bug#9524)
6331
2e621251
PE
63322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6333
6334 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6335 (cons_to_x_long): New function.
6336 (lisp_data_to_selection_data): Use it. Correct the test for
6337 short-versus-long data; it was negated. Break out of vector
6338 loop, for efficiency, when a long datum is discovered.
6339
91a15bc6
SM
63402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6341
6342 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6343
b41c3a35
EZ
63442011-09-16 Eli Zaretskii <eliz@gnu.org>
6345
6346 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6347 GCC PR/17406) by declaring this function with external scope.
6348
7812ba2d
PE
63492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6350
6351 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6352 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6353
cf7edc2a
AS
63542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6355
6356 * editfns.c (Fformat): Correctly handle text properties on "%%".
6357
bd01620e
EZ
63582011-09-15 Eli Zaretskii <eliz@gnu.org>
6359
6360 * xterm.c (x_draw_composite_glyph_string_foreground):
6361 * w32term.c (x_draw_composite_glyph_string_foreground):
6362 * term.c (encode_terminal_code):
6363 * composite.c (composition_update_it, get_composition_id):
6364 * xdisp.c (get_next_display_element)
6365 (fill_composite_glyph_string): Add comments about special meaning
6366 of TAB characters in a composition.
6367
a02719a3
PE
63682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6369
6370 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6371 This occurs when processing a multibyte format.
6372 Problem reported by Wolfgang Jenker.
a02719a3 6373
72589a3c
JB
63742011-09-15 Johan Bockgård <bojohan@gnu.org>
6375
6376 * xdisp.c (try_cursor_movement): Only check for exact match if
6377 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6378
1c14176c
PE
63792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6380
6381 Remove unused external symbols.
6382 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6383 * xdisp.c (calc_pixel_width_or_height): Now static.
6384 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6385 * indent.c (check_display_width):
6386 * w32term.c: Fix comment to match code.
6387 * xterm.c, xterm.h (x_catching_errors): Remove.
6388
d2eea5b5
PE
63892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6390
6391 * xselect.c: Use signed conversions more consistently (Bug#9498).
6392 (selection_data_to_lisp_data): Assume incoming selection data are
6393 signed integers, not unsigned. This is to be consistent with
6394 outgoing selection data, which was modified to use signed integers
6395 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6396 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6397 expects long, not unsigned long.
6398
46888499
EZ
63992011-09-14 Eli Zaretskii <eliz@gnu.org>
6400
6401 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6402 computation of loop end. Reported by Johan Bockgård
6403 <bojohan@gnu.org>.
6404
ef8ef9fb
CY
64052011-09-13 Chong Yidong <cyd@stupidchicken.com>
6406
6407 * frame.c (Fother_visible_frames_p): Function deleted.
6408
fa819fed
EZ
64092011-09-12 Eli Zaretskii <eliz@gnu.org>
6410
6411 * indent.c (compute_motion): Process display vector front to back
6412 rather than the other way around. (Bug#2496)
6413
2ba8e008
SM
64142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6415
6416 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6417
20f53c69
CY
64182011-09-11 Chong Yidong <cyd@stupidchicken.com>
6419
6420 * minibuf.c (Fread_from_minibuffer): Doc fix.
6421
d562d7a4
EZ
64222011-09-11 Eli Zaretskii <eliz@gnu.org>
6423
6424 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6425 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6426
1c4d7f3d
LMI
64272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6428
6429 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6430 value for non-existent files.
6431
b885bf36
EZ
64322011-09-11 Eli Zaretskii <eliz@gnu.org>
6433
6434 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6435 set its "size" to -1. This will set the modtime_size field of
6436 the corresponding buffer to -1, which is what
6437 verify-visited-file-modtime expects for files that do not exist.
6438 (Bug#9139)
6439
6612f0bf
PE
64402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6441
6442 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6443 here ...
6444 * lisp.h: ... from here. push_key_description is no longer
6445 defined in keyboard.c, so its declaration should not be in
6446 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6447 logically belongs with push_key_description.
6448
dfb3f755
PE
64492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 * buffer.h: Include <sys/types.h> instead of <time.h>.
6452 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6453 Problem reported by Herbert J. Skuhra.
6454
3134906c
LMI
64552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6456
6457 * xml.c (parse_region): Make the parsing work for
6458 non-comment-starting XML files again (bug#9144).
6459
8d903f4e
AS
64602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6461
6462 * image.c (gif_load): Fix calculation of bottom and right corner.
6463 (Bug#9468)
6464
80ad64f4
EZ
64652011-09-10 Eli Zaretskii <eliz@gnu.org>
6466
6467 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6468 redisplay in small windows.
6469
208a048d
EZ
64702011-09-09 Eli Zaretskii <eliz@gnu.org>
6471
6472 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6473
9b1c252e
MR
64742011-09-08 Martin Rudalics <rudalics@gmx.at>
6475
6476 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6477 Operate on live windows only.
6478
2949f33b
JB
64792011-09-08 Juanma Barranquero <lekktu@gmail.com>
6480
6481 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6482
e08dcafd
EZ
64832011-09-07 Eli Zaretskii <eliz@gnu.org>
6484
6485 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6486 only under bidi iteration.
6487
115b96bd
JD
64882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6489
6490 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6491
c8199d0f
PE
64922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6493
6494 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6495 Without this fix, the command to link temacs failed due to an
6496 undefined symbol __builtin_isnan. This is because
6497 /usr/include/iso/math_c99.h #defines isnan(x) to
6498 __builtin_isnan(x), but the bundled gcc, which identifies itself
6499 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6500 a __builtin_isnan.
6501 * floatfns.c (isnan): #undef, and then #define to a clone of
6502 what's in data.c.
6503 (Fisnan): Always define, since it's always available now.
6504 (syms_of_floatfns): Always define isnan at the Lisp level.
6505
e39b275c 65062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6507
6508 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6509
b2db44d9 65102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6511
f4af5137 6512 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6513 The previous code assumed that file offsets (off_t values) fit in
6514 EMACS_INT variables, which is not true on typical 32-bit hosts.
6515 The code messed up by falsely reporting buffer overflow in cases
6516 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6517 when "big" contains more than 2**29 bytes, even though this
6518 inserts just one byte and does not overflow the buffer.
6519 (Finsert_file_contents): Store file offsets as off_t
6520 values, not as EMACS_INT values. Check for overflow when
6521 converting between EMACS_INT and off_t. When checking for
6522 buffer overflow or for overlap, take the offsets into account.
6523 Don't use EMACS_INT for small values where int suffices.
6524 When checking for overlap, fix a typo: ZV was used where
6525 ZV_BYTE was intended.
6526 (Fwrite_region): Don't assume off_t fits into 'long'.
6527 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6528
ecfc0a49
MA
65292011-09-05 Michael Albinus <michael.albinus@gmx.de>
6530
6531 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6532
6511acf2 65332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6534
0999621a 6535 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6536
6537 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6538 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6539 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6540 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6541 (modify_event_symbol): Do not assume that the length of
6542 name_alist_or_stem is safe to alloca and fits in int.
6543 (Fexecute_extended_command): Likewise for function name and binding.
6544 (Frecursion_depth): Wrap around reliably on integer overflow.
6545 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6546 since some callers pass EMACS_INT values.
6547 (Fsingle_key_description): Don't crash if symbol name contains more
6548 than MAX_ALLOCA bytes.
6549 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6550 (get_minibuffer): Arg is now EMACS_INT, not int.
6551 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6552 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6553 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6554
2be7d702
PE
6555 * dbusbind.c (signature_cat): New function.
6556 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6557 Do not overrun buffer; instead, report string overflow.
6558
9d1df220
PE
6559 * dispnew.c (add_window_display_history): Don't overrun buffer.
6560 Truncate instead; this is OK since it's just a log.
6561
33ef5c64
PE
6562 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6563 even if the time zone offset is outlandishly large.
6564 Don't mishandle offset == INT_MIN.
6565
66c6fdd5
PE
6566 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6567 when creating daemon; the previous buffer-overflow check was incorrect.
6568
d749b01b
PE
6569 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6570 which has the guts of the old verror function.
6571
b5cd1905
PE
6572 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6573 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6574
6e1a67fb
PE
6575 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6576 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6577 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6578 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6579 length of string rather than counting it via multiple sprintfs;
6580 that's simpler and more reliable.
c21721cc
PE
6581 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6582 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6583 sprintf, in case result does not fit in int.
6584
c57b67fc
PE
6585 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6586 (fontset_from_font): Print it.
6587
8a401434
PE
6588 * frame.c (tty_frame_count): Now printmax_t, not int.
6589 (make_terminal_frame, set_term_frame_name): Print it.
6590 (x_report_frame_params): In X, window IDs are unsigned long,
6591 not signed long, so print them as unsigned.
6592 (validate_x_resource_name): Check for implausibly long names,
6593 and don't assume name length fits in 'int'.
6594 (x_get_resource_string): Don't blindly alloca invocation name;
6595 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6596 not fit in int.
6597
6e1a67fb
PE
6598 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6599 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6600 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6601
0df02bf3
PE
6602 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6603 Use esprintf, not sprintf, in case result does not fit in int.
6604
48e30793
PE
6605 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6606 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6607 it as a large positive number.
6608 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6609 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6610
a66ff6d8
PE
6611 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6612 in case result does not fit in int.
6613
aca216ff
PE
6614 * print.c (float_to_string): Detect width overflow more reliably.
6615 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6616 buffer overrun. Don't assume list length fits in 'int'. Treat
6617 print length of 0 as 0, not as infinity; to be consistent with other
6618 uses of print length in this function. Don't overflow print length
6619 index. Don't assume hash table size fits in 'long', or that
6620 vectorlike size fits in 'unsigned long'.
6621
31c286f7
PE
6622 * process.c (make_process): Use printmax_t, not int, to format
6623 process-name gensyms.
6624
55e5faa1
PE
6625 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6626
80f2e268
PE
6627 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6628 to avoid potential buffer overrun.
6629
670741ab
PE
6630 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6631 if X resource line is longer than 512 bytes.
6632
b7163a50
PE
6633 * xfns.c (x_window): Make sprintf buffer a bit bigger
6634 to avoid potential buffer overrun.
6635
ae58ff1f
PE
6636 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6637
c43c8a6a
PE
6638 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6639
3f8236f4
PE
66402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6641
53e9fe90 6642 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6643 Without these, Emacs silently mishandles large integers sometimes.
6644 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6645 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6646
6511acf2
PE
6647 * xdisp.c (try_window_id): Check Emacs fixnum range before
6648 converting to 'int'.
806add1d 6649
6511acf2 6650 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6651 Check that an Emacs fixnum is in range before assigning it to 'int'.
6652 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6653 values converted from Emacs fixnums.
6654 (Frecenter): Don't wrap around a line count if it is out of 'int'
6655 range; instead, treat it as an extreme value.
6656 (Fset_window_configuration, compare_window_configurations):
6657 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6658
6511acf2
PE
6659 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6660 that can exceed INT_MAX. Check that EMACS_INT value is in range
6661 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6662 (match_limit): Don't assume that a fixnum can fit in 'int'.
6663
6511acf2 6664 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6665 exceed INT_MAX.
6666
6511acf2 6667 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6668 (Fvertical_motion): Don't wrap around LINES values that don't fit
6669 in 'int'. Instead, treat them as extreme values. This is good
6670 enough for windows, which can't have more than INT_MAX lines anyway.
6671
fcb901a7
LMI
66722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6673
0f2f6b6d
LMI
6674 * Require libxml/parser.h to avoid compilation warning.
6675
fcb901a7
LMI
6676 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6677
6678 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6679 since this reportedly can destroy thread storage.
6680
6e20a0d4
CY
66812011-08-30 Chong Yidong <cyd@stupidchicken.com>
6682
6683 * syntax.c (find_defun_start): Update all cache variables if
6684 exiting early (Bug#9401).
6685
148ae00e
EZ
66862011-08-30 Eli Zaretskii <eliz@gnu.org>
6687
f6cfbd8f
EZ
6688 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6689
148ae00e
EZ
6690 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6691 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6692 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6693
6694 * term.c (tty_append_glyph): New function.
6695 (produce_stretch_glyph): Static function and its prototype deleted.
6696
a66cfb1c
SM
6697 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6698 Add prototypes.
148ae00e 6699
c4a07a4c
PE
67002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6701
6702 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6703 when checking :margin (Bug#9390).
6704 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6705 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6706 so that the name doesn't mislead. All uses changed.
6707
6bc8cd65
JB
67082011-08-28 Johan Bockgård <bojohan@gnu.org>
6709
6710 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6711 set_tty_hooks.
6712
dca4927e
EZ
67132011-08-27 Eli Zaretskii <eliz@gnu.org>
6714
6715 * xdisp.c (move_it_to): Don't bail out early when reaching
6716 position beyond to_charpos, if we are scanning backwards.
6717 (move_it_vertically_backward): When DY == 0, make sure we get to
6718 the first character in the line after the newline.
6719
f2cad773
PE
67202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6721
6722 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6723 (ccl_driver): Do not generate an out-of-range pointer.
6724 (Fccl_execute_on_string): Remove unnecessary check for
6725 integer overflow, noted by Stefan Monnier in
6726 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6727 Remove a FIXME that didn't need fixing.
6728 Simplify the newly-introduced buffer reallocation code.
6729
0cae2cdb
JB
67302011-08-27 Juanma Barranquero <lekktu@gmail.com>
6731
6732 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6733
5fc295a4 67342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6735
70c60eb2 6736 Integer and memory overflow issues (Bug#9196).
726e0ab1 6737
d31850da
PE
6738 * doc.c (get_doc_string): Rework so that
6739 get_doc_string_buffer_size is the actual buffer size, rather than
6740 being 1 less than the actual buffer size; this makes xpalloc more
6741 convenient.
6742
a69fbedb
PE
6743 * image.c (x_allocate_bitmap_record, cache_image):
6744 * xselect.c (Fx_register_dnd_atom):
6745 Simplify previous changes by using xpalloc.
6746
fe5c5d37
PE
6747 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6748 since either will do and ptrdiff_t is convenient with xpalloc.
6749
0065d054
PE
6750 * charset.c (charset_table_size)
6751 (struct charset_sort_data.priority): Now ptrdiff_t.
6752 (charset_compare): Don't overflow if priorities differ greatly.
6753 (Fsort_charsets): Don't assume list length fits in int.
6754 Check for size-calculation overflow when allocating sort data.
6755 (syms_of_charset): Allocate an initial charset table that is
6756 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6757
6758 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6759
6760 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6761 The actual value is always <= INT_MAX, and leaving it unsigned made
6762 overflow checking harder.
6763
6764 * dispextern.h (struct glyph_matrix.rows_allocated)
6765 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6766 with xpalloc. The values are still always <= INT_MAX.
6767
6768 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6769
6770 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6771 (SAFE_NALLOCA): New macro.
6772
6773 * region-cache.c (struct boundary.pos, find_cache_boundary)
6774 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6775 (set_cache_region, invalidate_region_cache)
6776 (revalidate_region_cache, know_region_cache, region_cache_forward)
6777 (region_cache_backward, pp_cache):
6778 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6779 so that ptrdiff_t * can be passed to xpalloc.
6780 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6781 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6782 (pp_cache): Don't assume cache_len fits in int.
6783 * region-cache.h: Adjust extern decls to match.
6784
6785 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6786 EMACS_INT, since either will do, for xpalloc.
6787
6788 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6789 (xnmalloc, xnrealloc, xpalloc): New functions.
6790
726e0ab1
PE
6791 * bidi.c (bidi_shelve_header_size): New constant.
6792 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6793 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6794
51f30bc5 6795 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6796 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6797 (overlay_strings):
6798 Don't update size of array until after memory allocation succeeds,
6799 because xmalloc/xrealloc may not return.
0065d054
PE
6800 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6801 now that we have proper integer overflow checking.
6802 (record_overlay_string, overlay_strings): Catch overflows when
6803 calculating size of overlay_str_buf.
726e0ab1 6804
0065d054
PE
6805 * callproc.c (Fcall_process): Check for size overflow when
6806 calculating size of args2.
6807 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6808 Normally we prefer signed values, but sticking with ptrdiff_t would
6809 require adding more-complicated checks.
726e0ab1
PE
6810
6811 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6812 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6813 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6814 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6815
6816 * character.c (Fstring): Check for size-calculation overflow.
6817
6818 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6819 unnecessary integer overflow. Check for size overflow.
6820 (encode_coding_object): Don't update size until xmalloc succeeds.
6821
6822 * composite.c (get_composition_id): Check for overflow in glyph
6823 length calculations.
6824
6825 Integer and memory overflow fixes for display code.
6826 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6827 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6828 (scrolling_window): Check for overflow in size calculations.
6829 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6830 Don't assume glyph table len fits in int.
6831 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6832 (row_table_size): Now ptrdiff_t, not int.
6833 (scrolling_window): Avoid overflow in size calculations.
6834 Don't update size until allocation succeeds.
6835 * fns.c (concat): Check for overflow in size calculations.
6836 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6837 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6838 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6839
6840 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6841 (get_doc_string): Check for size calculation overflow.
6842 Don't update size until allocation succeeds.
6843 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6844 EMACS_INT, where ptrdiff_t will do.
6845 (Fsubstitute_command_keys): Check for string overflow.
6846
6847 * editfns.c (set_time_zone_rule): Don't assume environment length
6848 fits in int.
6849 (message_length): Now ptrdiff_t, not int.
6850 (Fmessage_box): Don't update size until allocation succeeds.
6851 Don't assume message length fits in int.
6852 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6853
0065d054
PE
6854 * emacs.c (main): Do not reallocate argv, since there is a null at
6855 the end that can be overwritten, and this way there's no need to
6856 worry about size-calculation overflow.
6857 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6858
6859 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6860 alloc succeeds.
6861 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6862
6863 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6864 (x_set_scroll_bar_width, x_figure_window_size):
6865 Check for integer overflow.
6866 (x_set_alpha): Do not assume XINT fits in int.
6867
6868 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6869 This is for the members text_lines, text_cols, total_lines, total_cols,
6870 where the system imposes an 'int' limit.
6871
6872 * fringe.c (Fdefine_fringe_bitmap):
6873 Don't update size until alloc works.
6874
6875 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6876 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6877
6878 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6879 Check for size-calculation overflow.
6880 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6881 do, as we prefer signed integers.
6882 (id_to_widget.max_size, id_to_widget.used)
6883 (xg_store_widget_in_map, xg_remove_widget_from_map)
6884 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6885 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6886 Use and return ptrdiff_t, not int.
6887 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6888 * gtkutil.h: Change prototypes to match the above.
6889
6890 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6891 are duplicate now that they've been promoted to lisp.h.
6892 (x_allocate_bitmap_record, x_alloc_image_color)
6893 (make_image_cache, cache_image, xpm_load):
6894 Don't update size until alloc is done.
6895 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6896 (x_detect_edges):
3256efce 6897 Check for size calculation overflow.
726e0ab1
PE
6898 (ct_colors_allocated_max): New constant.
6899 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6900 overflow.
3256efce 6901
726e0ab1
PE
6902 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6903 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6904 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6905 Use ptrdiff_t, not int, to count maps.
6906 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6907 calculations. Don't update size until allocation succeeds.
6908 Redo calculations to avoid overflow.
726e0ab1
PE
6909 * keyboard.h: Change prototypes to match the above.
6910
6911 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6912 to count maps.
6913 (current_minor_maps): Check for size calculation overflow.
6914 * keymap.h: Change prototypes to match the above.
6915
6916 * lread.c (read1, init_obarray): Don't update size until alloc done.
6917
6918 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6919 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6920
726e0ab1
PE
6921 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6922 Now ptrdiff_t, not int.
6923 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6924 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6925
6926 * process.c (Fnetwork_interface_list): Check for overflow
6927 in size calculation.
6928
6929 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6930
6931 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6932 overflow. Don't bother calling xmalloc when xrealloc will do.
6933
6934 * search.c (Freplace_match): Check for size calculation overflow.
6935 (Fset_match_data): Don't assume list lengths fit in 'int'.
6936
6937 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6938 for command line length. Do not attempt to address one before the
6939 beginning of an array, as that's not portable.
6940
6941 * term.c (max_frame_lines): Remove; unused.
6942 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6943 not int.
6944 (encode_terminal_code, calculate_costs): Check for size
6945 calculation overflow.
6946 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6947 table lengths and related sizes. Don't update size until alloc
6948 done. Redo calculations to avoid overflow.
6949 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6950
6951 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6952 subtracting pointers.
6953 (gobble_line): Check for overflow more carefully. Don't update size
6954 until alloc done.
6955
6956 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6957 Don't update size until alloc done.
6958 Redo size calculations to avoid overflow.
6959 Check for size calculation overflow.
0065d054 6960 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6961
6962 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6963 Use ptrdiff_t, not int, for sizes.
6964 (store_mode_line_noprop_char): Don't update size until alloc done.
6965
0065d054
PE
6966 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6967 Use ptrdiff_t, not int, for sizes.
6968 (Finternal_make_lisp_face, cache_face):
6969 Check for size calculation overflow.
6970 (cache_face): Treat size calculation overflows as if they were
6971 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6972
6973 * xfns.c (x_encode_text, x_set_name_internal)
6974 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6975 sizes, since they can exceed INT_MAX in size. Check for size
6976 calculation overflow.
6977
0065d054
PE
6978 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6979 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6980 Don't update size until alloc done.
6981
0065d054 6982 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6983 as sprintf is limited to int lengths.
1d526e2f 6984
252c5ee1
PE
6985 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6986 (X_LONG_MIN): New macros.
864d7ce7
PE
6987 Use them to make the following changes clearer.
6988 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6989 This change doesn't affect the value now, but it may help remind
6990 future maintainers not to raise the value too much later.
6991 (SELECTION_QUANTUM): Remove, replacing with ...
6992 (selection_quantum): ... new function, which avoids overflow.
6993 All uses changed.
6994 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6995 assumption that selection length fits in 'int'.
6996 (x_reply_selection_request, x_handle_selection_request)
6997 (x_get_window_property, receive_incremental_selection)
6998 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6999 (lisp_data_to_selection_data, clean_local_selection_data):
7000 Use ptrdiff_t, not int, to record length of selection.
7001 (x_reply_selection_request, x_get_window_property)
7002 (receive_incremental_selection, x_property_data_to_lisp):
7003 Redo calculations to avoid overflow.
7004 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7005 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7006 something.
7007 (x_get_window_property, receive_incremental_selection)
7008 (lisp_data_to_selection_data, x_property_data_to_lisp):
7009 Check for size-calculation overflow.
7010 (x_get_window_property, receive_incremental_selection)
7011 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7012 Don't store size until memory allocation succeeds.
7013 (x_get_window_property): Plug memory leak on memory exhaustion.
7014 Don't double-block input; malloc is safe here. Don't assume 2**34
7015 - 4 fits in unsigned long. Add an xassert to check
7016 XGetWindowProperty overflow. Be more careful about overflow
7017 calculations, and distinguish size from memory overflow better.
7018 (receive_incremental_selection): When tracing, don't assume
7019 unsigned int is less than INT_MAX.
7020 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7021 harmful) conversions of unsigned short to int.
7022 (lisp_data_to_selection_data): Don't assume that integers
7023 in the range -65535 through -1 fit in an X unsigned short.
7024 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7025 result parameters unless successful. Rely on cons_to_unsigned
7026 to report problems with elements; the old code wasn't right anyway.
7027 (x_check_property_data): Check for int overflow; we cannot use
7028 a wider type due to X limits.
7029 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7030
726e0ab1 7031 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7032
0065d054
PE
7033 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7034 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7035 (x_color_cells): Don't store size until memory allocation succeeds.
7036 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7037 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7038 (x_term_init): Don't assume length fits in int (sprintf is limited
7039 to int size).
bc18e09d 7040
ebfa62c0
PE
7041 Use ptrdiff_t for composition IDs.
7042 * character.c (lisp_string_width):
7043 * composite.c (composition_table_size, n_compositions)
7044 (get_composition_id, composition_gstring_from_id):
7045 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7046 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7047 * window.c (Frecenter):
7048 Use ptrdiff_t, not int, for composition IDs.
7049 * composite.c (get_composition_id): Check for integer overflow.
7050 * composite.h: Adjust prototypes to match the above changes.
7051
d3411f89
PE
7052 Use ptrdiff_t for hash table indexes.
7053 * category.c (hash_get_category_set):
7054 * ccl.c (ccl_driver):
7055 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7056 * coding.c (coding_system_charset_list, detect_coding_system):
7057 * coding.h (struct coding_system.id):
7058 * composite.c (get_composition_id, gstring_lookup_cache):
7059 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7060 * image.c (xpm_get_color_table_h):
7061 * lisp.h (hash_lookup, hash_put):
7062 * minibuf.c (Ftest_completion):
7063 Use ptrdiff_t for hash table indexes, not int (which is too
7064 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7065 32-bit --with-wide-int hosts).
7066
e097a6fa
PE
7067 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7068 Add a FIXME comment about memory leaks.
7069 (syms_of_charset): Don't assume xmalloc returns.
7070
5637687f
PE
7071 Don't assume that stated character widths fit in int.
7072 * character.c (Fchar_width, c_string_width, lisp_string_width):
7073 * character.h (CHAR_WIDTH):
7074 * indent.c (MULTIBYTE_BYTES_WIDTH):
7075 Use sanitize_char_width to avoid undefined and/or bad behavior
7076 with outlandish widths.
a66cfb1c 7077 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7078 now that we have two such functions. All uses changed.
7079 (sanitize_char_width): New inline function.
7080
a2271ba2
PE
7081 Don't assume that tab-width fits in int.
7082 * character.h (sanitize_width): New inline function.
7083 (SANE_TAB_WIDTH): New macro.
7084 (ASCII_CHAR_WIDTH): Use it.
7085 * indent.c (sane_tab_width): Remove. All uses replaced by
7086 SANE_TAB_WIDTH (current_buffer).
7087 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7088
18c52557
PE
7089 * fileio.c: Integer overflow issues with file modes.
7090 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7091
caeeedc1
PE
7092 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7093 Remove unreachable code.
7094 (read_hex, load_charset_map_from_file): Check for integer overflow.
7095
6df6ae42 7096 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7097 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7098 (x_send_scroll_bar_event): Likewise. Check that the size does not
7099 exceed limits imposed by XClientMessageEvent, as well as the usual
7100 ptrdiff_t and size_t limits.
7101
b13995db
PE
7102 * keyboard.c: Overflow, signedness and related fixes.
7103 (make_lispy_movement): Use same integer type in forward decl
7104 that is used in the definition.
7105 (read_key_sequence, keyremap_step):
7106 Change bufsize argument back to int, undoing my 2011-03-30 change.
7107 We prefer signed types, and int is wide enough here.
7108 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7109 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7110 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7111 length, not size_t. Use ptrdiff_t for index, not int.
7112 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7113 possibility of integer overflow.
7114
13464394
PE
7115 Overflow, signedness and related fixes for images.
7116
7117 * dispextern.h (struct it.stack[0].u.image.image_id)
7118 (struct_it.image_id, struct image.id, struct image_cache.size)
7119 (struct image_cache.used, struct image_cache.ref_count):
7120 * gtkutil.c (update_frame_tool_bar):
7121 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7122 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7123 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7124 * nsmenu.m (update_frame_tool_bar):
7125 * xdisp.c (calc_pixel_width_or_height):
7126 * xfns.c (image_cache_refcount):
7127 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7128 on typical 64-bit hosts.
7129
7130 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7131 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7132 Omit unnecessary casts to int.
7133 (parse_image_spec): Check that integers fall into 'int' range
7134 when the callers expect that.
7135 (image_ascent): Redo ascent calculation to avoid int overflow.
7136 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7137 (lookup_image): Remove unnecessary tests.
7138 (xbm_image_p): Locals are now of int, not EMACS_INT,
7139 since parse_image_check makes sure they fit into int.
7140 (png_load, gif_load, svg_load_image):
7141 Prefer int to unsigned where either will do.
7142 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7143 old tiff_error_handler and tiff_warning_handler.
7144 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7145 stack buffer overflows. It uses only the features of vsnprintf
7146 that are common to both POSIX and native Microsoft.
7147 (tiff_error_handler, tiff_warning_handler): Use it.
7148 (tiff_load, gif_load, imagemagick_load_image):
7149 Don't assume :index value fits in 'int'.
7150 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7151 (imagemagick_load_image): Check that crop parameters fit into
7152 the integer types that MagickCropImage accepts. Don't assume
7153 Vimagemagick_render_type has a nonnegative value. Don't assume
7154 size_t fits in 'long'.
7155 (gs_load): Use printmax_t to print the widest integers possible.
7156 Check for integer overflow when computing image height and width.
7157
c11821d4
EZ
71582011-08-26 Eli Zaretskii <eliz@gnu.org>
7159
7160 * xdisp.c (redisplay_window): Don't force window start if point
7161 will be invisible in the resulting window. (Bug#9324)
7162
0c95fcf7
EZ
71632011-08-25 Eli Zaretskii <eliz@gnu.org>
7164
7165 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7166 the display spec is of the form `(space ...)'.
7167 (handle_display_spec): Return the value returned by
7168 handle_single_display_spec, not just 1 or zero.
7169 (handle_single_display_spec): If the display spec is of the form
7170 `(space ...)', and specifies display in the text area, return 2
7171 rather than 1.
fee65a97 7172 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7173 accurately, and prefer exact match for point under bidi.
7174 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7175
7176 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7177 into disp_prop; all users changed.
7178
7179 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7180 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7181 for the text covered by the display property.
7182
e4ed06f1
CY
71832011-08-25 Chong Yidong <cyd@stupidchicken.com>
7184
7185 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7186 Change return value to nil.
7187 (Frecord_buffer): Delete unused function.
7188
f67cdd7f
EZ
71892011-08-24 Eli Zaretskii <eliz@gnu.org>
7190
5980d4c6
EZ
7191 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7192 buffers, return left-to-right.
8610fe8b
EZ
7193 (set_cursor_from_row): Consider candidate row a win if its glyph
7194 represents a newline and point is on that newline. Fixes cursor
7195 positioning on the newline at EOL of R2L text within L2R
7196 paragraph, and vice versa.
7197 (try_cursor_movement): Check continued rows, in addition to
7198 continuation rows. Fixes unwarranted scroll when point enters a
7199 continued line of R2L text within an L2R paragraph, or vice versa.
7200 (cursor_row_p): Consider the case of point being equal to
7201 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7202 from the end of a short line to the beginning of a continued line
7203 of R2L text within L2R paragraph.
7204 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7205 composed characters.
5980d4c6 7206
f67cdd7f
EZ
7207 * bidi.c (bidi_check_type): Use xassert.
7208 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7209 members.
7210
bca633fb
EZ
72112011-08-23 Eli Zaretskii <eliz@gnu.org>
7212
7213 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7214 a character.
7215
4a5885a7
CY
72162011-08-23 Chong Yidong <cyd@stupidchicken.com>
7217
7218 * nsfont.m (ns_otf_to_script): Fix typo.
7219
0902a04e
KH
72202011-08-22 Kenichi Handa <handa@m17n.org>
7221
7222 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7223 extra slot even if the purpose is char-code-property-table.
7224
1a2e6670
EZ
72252011-08-23 Eli Zaretskii <eliz@gnu.org>
7226
8ddde651
EZ
7227 * xdisp.c (redisplay_window): When computing centering_position,
7228 account for the height of the header line. (Bug#8874)
7229
425cc014
EZ
7230 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7231 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7232 candidate is selected by the mouse, and that candidate has a
7233 composed character under the mouse.
7234
1a2e6670
EZ
7235 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7236 coordinates reported by pos-visible-in-window-p for a composed
7237 character in column zero.
7238
8b76d6f8
SM
72392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7240
7241 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7242
dac347dd
EZ
72432011-08-22 Eli Zaretskii <eliz@gnu.org>
7244
7245 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7246 consider it a hit if to_charpos is anywhere in the range of the
7247 composed buffer positions.
7248
e013fb34
CY
72492011-08-22 Chong Yidong <cyd@stupidchicken.com>
7250
7251 * image.c (gif_load): Don't assume that each subimage has the same
7252 dimensions as the base image. Handle disposal method that is
7253 "undefined" by the gif spec (Bug#9335).
7254
bd1ba3e8
CY
72552011-08-20 Chong Yidong <cyd@stupidchicken.com>
7256
7257 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7258 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7259
54a1215b
EZ
72602011-08-19 Eli Zaretskii <eliz@gnu.org>
7261
823564e5
EZ
7262 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7263 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7264 from an Org mode buffer to a Speedbar frame.
7265
54a1215b
EZ
7266 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7267 a composition, take its buffer position from IT->cmp_it.charpos.
7268 Fixes cursor positioning at the beginning of a line that begins
7269 with a composed character.
7270
9778ebcc
EZ
72712011-08-18 Eli Zaretskii <eliz@gnu.org>
7272
0be6ee06
EZ
7273 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7274 character bidirectional type, use STRONG_L instead. Fixes crashes
7275 in a buffer produced by `describe-categories'.
7276
9778ebcc
EZ
7277 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7278 members before the level stack, so they would be saved and
7279 restored when copying iterator state. Fixes incorrect reordering
7280 around TABs covered by display properties.
7281
156bffbe
AS
72822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7283
6b02f655 7284 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7285
72ad093b
CY
72862011-08-17 Chong Yidong <cyd@stupidchicken.com>
7287
7288 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7289 (internal_condition_case_2, internal_condition_case_n):
7290 Remove unnecessary aborts (Bug#9081).
72ad093b 7291
35774242
EZ
72922011-08-17 Eli Zaretskii <eliz@gnu.org>
7293
7294 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7295 has no `load' handler, try opening the file locally. (Bug#9311)
7296
db76dd85
KB
72972011-08-16 Ken Brown <kbrown@cornell.edu>
7298
7299 * gmalloc.c: Expand comment.
7300
b215eee5
EZ
73012011-08-16 Eli Zaretskii <eliz@gnu.org>
7302
7303 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7304 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7305
a4579d33
KB
73062011-08-16 Ken Brown <kbrown@cornell.edu>
7307
7308 Fix memory allocation problems in Cygwin build (Bug#9273).
7309
7310 * unexcw.c ( __malloc_initialized): Declare external variable.
7311 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7312
8b76d6f8
SM
7313 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7314 New variables.
a4579d33
KB
7315 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7316 dumped emacs.
7317 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7318 in the static heap.
7319 [CYGWIN] (special_realloc): New function.
7320 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7321 requests to realloc storage in the static heap.
7322
3ebec551
PE
73232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7324
7325 * bidi.c (bidi_initialize): Remove unused local.
7326
9fd8be00
EZ
73272011-08-15 Eli Zaretskii <eliz@gnu.org>
7328
6b02f655
SM
7329 * bidimirror.h:
7330 * biditype.h: Remove file.
7331 * makefile.w32-in ($(BLD)/bidi.$(O)):
7332 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7333
7334 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7335
7336 * chartab.c: Improve commentary for the uniprop_table API.
7337
32413314
EZ
7338 * bidi.c (bidi_paragraph_init): Support zero value of
7339 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7340 (bidi_initialize): Use uniprop_table instead of including
7341 biditype.h and bidimirror.h.
32413314 7342
9fd8be00
EZ
7343 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7344 coordinates of the iterator when restoring from ppos_it.
7345 (Bug#9296)
7346
5cf2b69b
KH
73472011-08-14 Kenichi Handa <handa@m17n.org>
7348
7349 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7350 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7351
daf17d00
EZ
73522011-08-14 Eli Zaretskii <eliz@gnu.org>
7353
7354 * xdisp.c (move_it_in_display_line_to): Don't invoke
7355 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7356 ppos_it. Fixes vertical cursor motion when line beginning is
7357 covered by an image. (Bug#9296)
7358
08e3161a
JD
73592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7360
7361 * nsterm.h (ns_run_ascript): Declare.
7362 (NSAPP_DATA2_RUNASSCRIPT): Define.
7363
7364 * nsfns.m (as_script, as_result, as_status): New static variables.
7365 (ns_run_ascript): New function.
5e617bc2 7366 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7367 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7368 the event loop. Get status from as_status (Bug#7276).
7369
7370 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7371 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7372 the event loop (Bug#7276).
7373
a3720aa2
AS
73742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7375
7376 * gnutls.c (QCgnutls_bootprop_priority)
7377 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7378 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7379 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7380 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7381 (QCgnutls_bootprop_verify_hostname_error)
7382 (QCgnutls_bootprop_callbacks_verify): Rename from
7383 Qgnutls_bootprop_..., all uses changed.
7384
7385 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7386 uses changed.
7387
0a0d27fb
PE
73882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7389
19d5c50c
PE
7390 * xfaces.c (Qframe_set_background_mode): Now static.
7391 * dispextern.h (Qframe_set_background_mode): Remove decl.
7392
0a0d27fb
PE
7393 * process.c (Fnetwork_interface_info): Declare local only if needed.
7394
377538cb
JD
73952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7396
7397 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7398 (Fnetwork_interface_list): Allocate in increments of bytes instead
7399 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7400 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7401 sockaddr.
7402 (struct ifflag_def): notrailers is smart on OSX.
7403 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7404 Get hardware address with getifaddrs if available.
7405
08fff70c
EZ
74062011-08-12 Eli Zaretskii <eliz@gnu.org>
7407
7408 * xdisp.c (iterate_out_of_display_property): xassert that
7409 IT->position is set to within IT->object's boundaries. Break from
7410 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7411 when IT->position is set up wrongly due to some bug.
7412 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7413 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7414 entry. Force push_it to save on the stack the current
7415 buffer/string position, to be restored by pop_it. Fix flags in
7416 the iterator structure wrt the object coming from a display
7417 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7418 properties. (Bug#9284)
7419
7be1c708 74202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7421
7be1c708
CY
7422 * fontset.c (fontset_get_font_group): Add proper type checks.
7423 (Bug#9172)
aac0c6e3 7424
7be1c708 74252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7426
7be1c708
CY
7427 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7428 and LC_VERSION_MIN_MACOSX.
7429 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7430 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7431
97bb72a6
EZ
74322011-08-08 Eli Zaretskii <eliz@gnu.org>
7433
7434 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7435 no-display-properties-and-no-overlays under bidi display.
7436 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7437 properties and overlays.
97bb72a6 7438
d5617611
CY
74392011-08-08 Chong Yidong <cyd@stupidchicken.com>
7440
37e11a63
CY
7441 * editfns.c (Fset_time_zone_rule): Document relationship with the
7442 setenv function.
7443
d5617611
CY
7444 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7445 the font entity extracted from the cache (Bug#8109).
7446
58872834
CY
74472011-08-07 Chong Yidong <cyd@stupidchicken.com>
7448
7449 * composite.c (autocmp_chars): Don't reset point. That is done by
7450 restore_point_unwind (Bug#5984).
7451
75bfc667
JL
74522011-08-07 Juri Linkov <juri@jurta.org>
7453
7454 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7455 to show the arg `TIME' instead of `TIMEVAL'.
7456
d1410150
EZ
74572011-08-06 Eli Zaretskii <eliz@gnu.org>
7458
7459 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7460 display property strides EOL and includes a newline, as in
7461 longlines-mode. (Bug#9254)
75b771e4
EZ
7462 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7463 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7464
7465 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7466 is non-zero, even if the data buffer is NULL. Fixes a crash in
7467 vertical-motion with longlines-mode. (Bug#9254)
7468
35928349
EZ
74692011-08-05 Eli Zaretskii <eliz@gnu.org>
7470
ec7cc85b
EZ
7471 * bidi.c <bidi_cache_total_alloc>: Now static.
7472 (bidi_initialize): Initialize bidi_cache_total_alloc.
7473
8b76d6f8 7474 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7475 cache. (Bug#9221)
7476
7477 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7478 amount allocated this far in `bidi_cache_total_alloc'.
7479 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7480 non-zero, only free the data buffer without restoring the cache
7481 contents. All callers changed.
7482
7483 * dispextern.h (bidi_unshelve_cache): Update prototype.
7484
7485 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7486 (move_it_in_display_line, move_it_to)
7487 (move_it_vertically_backward, move_it_by_lines): Replace the call
7488 to xfree to an equivalent call to bidi_unshelve_cache.
7489 (move_it_in_display_line_to): Fix logic of returning
412b6358 7490 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7491
e2e2423b
EZ
74922011-08-05 Eli Zaretskii <eliz@gnu.org>
7493
7494 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7495 came from a string character with a `cursor' property. (Bug#9229)
7496
ae9e757a
JD
74972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7498
7499 * Makefile.in (LIB_PTHREAD): New variable.
7500 (LIBES): Add LIB_PTHREAD (Bug#9216).
7501
7502 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7503 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7504
213bd7f2
AS
75052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7506
6b02f655 7507 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7508
99aaf75f
JD
75092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7510
7511 * xterm.c (x_find_topmost_parent): New function.
7512 (x_set_frame_alpha): Find topmost parent window with
7513 x_find_topmost_parent and set the property there also (bug#9181).
7514 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7515
c74e9d86
PE
75162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7517
7518 * callproc.c (Fcall_process): Avoid vfork clobbering
7519 the local vars buffer, coding_systems, current_dir.
7520
640c8776
SM
75212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7522
7523 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7524
f26d0e4c
PE
75252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7526
8a10d76c
PE
7527 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7528 so that it is not optimized away.
7529
f26d0e4c
PE
7530 * xdisp.c (compute_display_string_pos): Remove unused local.
7531
55439c61
EZ
75322011-08-02 Eli Zaretskii <eliz@gnu.org>
7533
7534 Fix slow cursor motion and scrolling in large buffers with
7535 selective display, like Org Mode buffers. (Bug#9218)
7536
7537 * dispextern.h (struct bidi_it): New member disp_prop_p.
7538
7539 * xdisp.c: Remove one-slot cache of display string positions.
7540 (compute_display_string_pos): Accept an additional argument
5e617bc2 7541 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7542 for a display string or property. If found, set DISP_PROP_P
7543 non-zero.
7544
7545 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7546 DISP_PROP_P, and pass it to compute_display_string_pos.
7547 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7548 non-zero. All callers of bidi_fetch_char changed.
7549
fb33fa43
SM
75502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7551
7552 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7553
b099e063
DM
75542010-12-03 Don March <don@ohspite.net>
7555
7556 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7557 last character M-[char] is translated to ESC [char] (bug#7541).
7558
5cc7f7af
KH
75592011-08-02 Kenichi Handa <handa@m17n.org>
7560
d0fffa3f 7561 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7562
7563 * chartab.c (uniprop_table): Make it non-static.
7564
525d5e6e
EZ
75652011-08-01 Eli Zaretskii <eliz@gnu.org>
7566
7567 * xdisp.c (forward_to_next_line_start): Accept additional argument
7568 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7569 on the newline.
7570 (reseat_at_next_visible_line_start): Use the bidi iterator state
7571 returned by forward_to_next_line_start to restore the state of
7572 it->bidi_it after backing up to previous newline. (Bug#9212)
7573
31011111
AS
75742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7575
7576 * regex.c (re_comp): Protoize.
7577 (re_exec): Fix return type.
7578 (regexec): Fix type of `ret'. (Bug#9203)
7579
476371c4
PE
75802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7581
e5d76069
PE
7582 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7583 This is needed if max-image-size is a floating-point number.
7584
9a79b20c
AS
75852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7586
7587 * print.c (print_object): Print empty symbol as ##.
7588
7589 * lread.c (read1): Read ## as empty symbol.
7590
d8c2fa78
AA
75912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7592
7593 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7594 setting frame foreground color (Bug#9175).
7595 (x_set_background_color): Likewise.
7596
ffe57a7a
AA
7597 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7598 contents (Bug#9176).
7599 (EmacsTooltip -init): Remove bezels and add shadows to
7600 tooltip windows.
7601
bf3492a5
AA
7602 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7603 or scroll bar (Bug#8470).
7604
d55e9c53
AA
7605 * nsfont.m (nsfont_open): Remove assignment to voffset and
7606 unnecessary vars hshink, expand, hd, full_height, min_height.
7607 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7608
7609 * nsterm.h (nsfont_info): Remove voffset field.
7610
d8c2fa78 76112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7612
7613 Implement strike-through and overline on NextStep (Bug#8863).
7614
7615 * nsfont.m (nsfont_open): Use underline position provided by font,
7616 instead of hard-coded value of 2.
7617 (nsfont_draw): Call ns_draw_text_decoration instead.
7618
7619 * nsterm.h: Add declaration for ns_draw_text_decoration.
7620
7621 * nsterm.m (ns_draw_text_decoration): New function for drawing
7622 underline, overline, and strike-through.
7623 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7624 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7625 accommodate underlining, etc.
4843aac3 7626
4cc60b9b
EZ
76272011-07-28 Eli Zaretskii <eliz@gnu.org>
7628
bc7ece87
EZ
7629 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7630 default.
4cc60b9b 7631
476371c4
PE
76322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7633
66606eea
PE
7634 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7635 Without this fix, if a signal arrives just after memory fills up,
7636 'malloc' might be invoked reentrantly.
7637
476371c4
PE
7638 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7639 In other words, assume that every image size is allowed, on non-X
7640 hosts. This assumption is probably wrong, but it lets Emacs compile.
7641
f3fcc40d
AS
76422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7643
7644 * regex.c (re_iswctype): Convert return values to boolean.
7645
350c992f
EZ
76462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7647
7648 * xdisp.c (compute_display_string_pos): Don't use cached display
7649 string position if the buffer had its restriction changed.
7650 (Bug#9184)
7651
5266b4bb
PE
76522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7653
7654 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7655
2573a837 76562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7657
41f55ccd 7658 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7659
39e378da
PE
7660 * bidi.c: Integer size and overflow fixes.
7661 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7662 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7663 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7664 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7665 (bidi_find_other_level_edge):
7666 Use ptrdiff_t instead of EMACS_INT where either will do.
7667 This works better on 32-bit hosts configured --with-wide-int.
7668 (bidi_cache_ensure_space): Check for size-calculation overflow.
7669 Use % rather than repeated addition, for better worst-case speed.
7670 Don't set bidi_cache_size until after xrealloc returns, because it
7671 might not return.
7672 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7673 (bidi_cache_ensure_space): Also check that the bidi cache size
7674 does not exceed that of the largest Lisp string or buffer. See Eli
7675 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7676
5e927815
PE
7677 * alloc.c (__malloc_size_t): Remove.
7678 All uses replaced by size_t. See Andreas Schwab's note
7679 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7680
ca4aa935
PE
7681 * image.c: Improve checking for integer overflow.
7682 (check_image_size): Assume that f is nonnull, since
7683 it is always nonnull in practice. This is one less thing to
7684 worry about when checking for integer overflow later.
7685 (x_check_image_size): New function, which checks for integer
7686 overflow issues inside X.
7687 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7688 This removes the need for a memory_full check.
7689 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7690 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7691 (xbm_read_bitmap_data): Change locals back to 'int', since
7692 their values must fit in 'int'.
7693 (xpm_load_image, png_load, tiff_load):
7694 Invoke x_create_x_image_and_pixmap earlier,
7695 to avoid much needless work if the image is too large.
7696 (tiff_load): Treat overly large images as if
7697 x_create_x_image_and_pixmap failed, not as malloc failures.
7698 (gs_load): Use x_check_image_size.
7699
5f8f9cc2
PE
7700 * gtkutil.c: Omit integer casts.
7701 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7702 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7703
5adf60bc
PE
7704 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7705
c8907a93
PE
7706 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7707 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7708 would wrongly return t on a 64-bit host.
7709
e3c25c68
PE
7710 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7711 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7712 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7713 and therefore cause GCC to emit a bogus diagnostic in some cases.
7714
3f791afe
PE
7715 * image.c: Integer signedness and overflow and related fixes.
7716 This is not an exhaustive set of fixes, but it's time to
7717 record what I've got.
7718 (lookup_pixel_color, check_image_size): Remove redundant decls.
7719 (check_image_size): Don't assume that arbitrary EMACS_INT values
7720 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7721 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7722 (tiff_load, imagemagick_load_image):
7723 Check for overflow in size calculations.
7724 (x_create_x_image_and_pixmap): Remove unnecessary test for
7725 xmalloc returning NULL; that can't happen.
7726 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7727 (xpm_color_bucket): Use better integer hashing function.
7728 (xpm_cache_color): Don't possibly over-allocate memory.
7729 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7730 (gif_memory_source):
7731 Use ptrdiff_t, not int or size_t, to record sizes.
7732 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7733 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7734 either works, as we prefer signed integers.
7735 (tiff_read_from_memory, tiff_write_from_memory):
7736 Return tsize_t, not size_t, since that's what the TIFF API wants.
7737 (tiff_read_from_memory): Don't fail simply because the read would
7738 go past EOF; instead, return a short read.
7739 (tiff_load): Omit no-longer-needed casts.
7740 (Fimagemagick_types): Don't assume size fits into 'int'.
7741
3cc5a532
PE
7742 Improve hashing quality when configured --with-wide-int.
7743 * fns.c (hash_string): New function, taken from sxhash_string.
7744 Do not discard information about ASCII character case; this
7745 discarding is no longer needed.
7746 (sxhash-string): Use it. Change sig to match it. Caller changed.
7747 * lisp.h: Declare it.
7748 * lread.c (hash_string): Remove, since we now use fns.c's version.
7749 The fns.c version returns a wider integer if --with-wide-int is
7750 specified, so this should help the quality of the hashing a bit.
7751
b312a492
PE
7752 * emacs.c: Integer overflow minor fix.
7753 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7754 Define only if GNU_LINUX.
7755 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7756
dfd153ae
PE
7757 * dispnew.c: Integer signedness and overflow fixes.
7758 Remove unnecessary forward decls, that were a maintenance hassle.
7759 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7760 All uses changed.
7761 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7762 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7763 (prepare_desired_row, line_draw_cost):
7764 Use int, not unsigned, where either works.
7765 (save_current_matrix, restore_current_matrix):
7766 Use ptrdiff_t, not size_t, where either works.
7767 (init_display): Check for overflow more accurately, and without
7768 relying on undefined behavior.
7769
a81d11a3
PE
7770 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7771 Remove, replacing with the new symbols in lisp.h. All uses changed.
7772 * fileio.c (make_temp_name):
7773 * filelock.c (lock_file_1, lock_file):
7774 * xdisp.c (message_dolog):
7775 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7776 Use pMd etc. instead.
7777 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7778 replacing the pWIDE etc. symbols removed from editfns.c.
7779
3300e6fd
PE
7780 * keyboard.h (num_input_events): Now uintmax_t.
7781 This is (very slightly) less likely to mess up due to wraparound.
7782 All uses changed.
7783
fd05c7e9
PE
7784 * buffer.c: Integer signedness fixes.
7785 (alloc_buffer_text, enlarge_buffer_text):
7786 Use ptrdiff_t rather than size_t when either will do, as we prefer
7787 signed integers.
7788
903fe15d
PE
7789 * alloc.c: Integer signedness and overflow fixes.
7790 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7791 (__malloc_size_t): Default to size_t, not to int.
7792 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7793 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7794 Prefer ptrdiff_t to size_t when either would do, as we prefer
7795 signed integers.
7796 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7797 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7798 Now const. Initialize with values that are in range even if char
7799 is signed.
7800 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7801 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7802 These functions do the right thing with sizes > 2**32.
7803 (check_depth): Now ptrdiff_t, not int.
7804 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7805 Adjust to new way of storing sizes. Check for size overflow bugs
7806 in rest of code.
7807 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7808 slightly wrong anyway, as it missed one instance of
7809 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7810 (refill_memory_reserve): Omit needless cast to size_t.
7811 (mark_object_loop_halt): Mark as externally visible.
7812
ac82cc6a
PE
7813 * xselect.c: Integer signedness and overflow fixes.
7814 (Fx_register_dnd_atom, x_handle_dnd_message):
7815 Use ptrdiff_t, not size_t, since we prefer signed.
7816 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7817 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7818 x_dnd_atoms_size and x_dnd_atoms_length.
7819
c2d1e36d
PE
7820 * doprnt.c: Prefer signed to unsigned when either works.
7821 * eval.c (verror):
7822 * doprnt.c (doprnt):
7823 * lisp.h (doprnt):
7824 * xdisp.c (vmessage):
7825 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7826 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7827 prefer signed arithmetic to avoid comparison confusion.
7828 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7829 but is a bit tricky.
7830
0e926e56
PE
7831 Assume freestanding C89 headers, string.h, stdlib.h.
7832 * data.c, doprnt.c, floatfns.c, print.c:
7833 Include float.h unconditionally.
7834 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7835 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7836 * regex.c: Likewise for stddef.h, string.h.
7837 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7838 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7839 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7840 (STDC_HEADERS): Remove obsolete defines.
7841 * sysdep.c: Include limits.h unconditionally.
7842
9cfdb3ec
PE
7843 Assume support for memcmp, memcpy, memmove, memset.
7844 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7845 * regex.c (memcmp, memcpy):
7846 Remove; we assume C89 now.
7847
7848 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7849 (__malloc_safe_bcopy): Remove; no longer needed.
7850
cf950e6b 7851 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7852 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7853 well either way, and we prefer signed to unsigned.
7854
dbf38e02
LMI
78552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7856
7857 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7858 closes the connection while we're reading (bug#9182).
7859
d6f0886c 78602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7861
d6f0886c
JD
7862 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7863 are specified (Bug#9168).
24e0f6b1 7864
2eb1f9e6
PE
78652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7866
7867 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7868 Found by GCC static checking and --with-wide-int on a 32-bit host.
7869
22381272 78702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7871
7872 * xdisp.c (compute_display_string_pos): Fix logic of caching
7873 previous display string position. Initialize cached_prev_pos to
7874 -1. Fixes slow-down at the beginning of a buffer.
7875
f25e39b4
EZ
78762011-07-24 Eli Zaretskii <eliz@gnu.org>
7877
7878 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7879 for attrs[LFACE_FONTSET_INDEX].
7880
04c4b52e
PE
78812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7882
7883 * xml.c (parse_region): Remove unused local
7884 that was recently introduced.
7885
c1734fbd
EZ
78862011-07-23 Eli Zaretskii <eliz@gnu.org>
7887
be18c5a5
EZ
7888 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7889 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7890
c1734fbd
EZ
7891 * xdisp.c (move_it_in_display_line_to): Record the best matching
7892 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7893 exit if none of the characters scanned was an exact match.
7894 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7895 when exact match is impossible due to invisible text, and the
7896 lines are truncated.
7897
a258d627
JD
78982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7899
7900 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7901 for OSX >= 10.7.
7902
b6d5a689
EZ
79032011-07-22 Eli Zaretskii <eliz@gnu.org>
7904
0f74f785
EZ
7905 Fix a significant slow-down of cursor motion with C-n, C-p,
7906 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7907 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7908 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7909 (next_element_from_buffer): Call compute_stop_pos_backwards to
7910 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7911 base_level_stop.
7912 (reseat): Don't look for prev_stop, as that could mean a very long
7913 run.
7914 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7915 <cached_disp_overlay_modiff>: Cache for last found display string
7916 position.
551918c1 7917 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7918 about the same buffer in the same area of character positions, and
7919 the buffer wasn't changed since the time the display string
7920 position was cached.
551918c1 7921
b2d0c91a
EZ
79222011-07-22 Eli Zaretskii <eliz@gnu.org>
7923
7924 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7925 is an integer, which is important for empty lines. (Bug#9149)
7926
043604ee
CY
79272011-07-22 Chong Yidong <cyd@stupidchicken.com>
7928
7929 * frame.c (Fmodify_frame_parameters): In tty case, update the
7930 default face if necessary (Bug#4238).
7931
da4adb04
CY
79322011-07-21 Chong Yidong <cyd@stupidchicken.com>
7933
7934 * editfns.c (Fstring_to_char): No need to explain what a character
7935 is in the docstring (Bug#6576).
7936
9abd0532
LMI
79372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7938
7939 * xml.c (parse_region): Make sure we always return a tree.
7940
36881d16
HK
79412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7942
7943 * xml.c (parse_region): If a document contains only comments,
7944 return that, too.
7945
1e98674d
LMI
79462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7947
7948 * xml.c (make_dom): Return comments, too.
7949
590bd467
PE
79502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7951
7952 Port to OpenBSD.
7953 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7954 and the surrounding thread.
7955 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7956 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7957 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7958 timer goes off.
7959 * s/openbsd.h (BROKEN_SIGIO): Define.
7960 * unexelf.c (unexec) [__OpenBSD__]:
7961 Don't update the .mdebug section of the Alpha COFF symbol table.
7962
f41628b2
LMI
79632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7964
7965 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7966 (bug#8460).
7967
b59b67c5
PE
79682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7969
15e3a074
PE
7970 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7971 This fixes some race conditions on the permissions of any newly
7972 created file.
7973
41bed37d
PE
7974 * alloc.c (valid_pointer_p): Use pipe, not open.
7975 This fixes some permissions issues when debugging.
7976
b59b67c5
PE
7977 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7978 If fchown fails to set both uid and gid, try to set just gid,
7979 as that is sometimes allowed. Adjust the file's mode to eliminate
7980 setuid or setgid bits that are inappropriate if fchown fails.
7981
925a6be7
SM
79822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7983
7984 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7985 to compare Lisp_Objects.
7986 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7987 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7988 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7989
52968808
AS
79902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7991
0a6a104b
AS
7992 * lread.c (read_integer): Unread even EOF character.
7993 (read1): Likewise. Properly record start position of symbol.
7994
52968808
AS
7995 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7996 symbol character follows.
7997
9e381cdd
PE
79982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7999
8000 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8001 This works around a problem with the previous change to Fcopy_file.
8002 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8003 and without this change, GCC might complain about discarding
8004 fchown's return value.
8005
b5641435
JB
80062011-07-16 Juanma Barranquero <lekktu@gmail.com>
8007
8008 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8009
a8031457
PE
80102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8011
8012 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8013
dd889327
LMI
80142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8015
750c33f7
LMI
8016 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8017 it's used from the C level.
8018
dd889327
LMI
8019 * process.c: Use the same condition for POLL_FOR_INPUT in both
8020 keyboard.c and process.c (bug#1858).
8021
87e86684
LM
80222011-07-09 Lawrence Mitchell <wence@gmx.li>
8023
8024 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8025 (Fgnutls_boot): Use it.
8026
64348f40
AS
80272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8028
8029 * doc.c (Fsubstitute_command_keys): Revert last change.
8030
1d698799
LMI
80312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8032
f863868c
LMI
8033 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8034 quotes the next character, and doesn't affect other longer
8035 sequences (bug#8935).
8036
1d698799
LMI
8037 * lread.c (syms_of_lread): Clarify that is isn't only
8038 `eval-buffer' and `eval-defun' that's affected by
8039 `lexical-binding' (bug#8460).
8040
aa4b6df6
EZ
80412011-07-15 Eli Zaretskii <eliz@gnu.org>
8042
8043 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8044 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8045
5d856da6
PE
80462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8047
ad6042bb
PE
8048 Fix minor problems found by static checking.
8049 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8050 (elsz): Now a signed constant, not a size_t var. We prefer signed
8051 types to unsigned, to avoid integer comparison confusion. Without
8052 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8053 "cannot optimize loop, the loop counter may overflow", a symptom
8054 of the confusion.
f00bbb22 8055 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8056 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8057
6468f31c
LMI
80582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8059
49080b10
LMI
8060 * search.c (Fre_search_backward): Mention `case-fold-search' in
8061 all the re_search_* functions (bug#8138).
8062
6468f31c
LMI
8063 * keyboard.c (Fopen_dribble_file): Document when the file is
8064 closed (bug#8056).
8065
c965adc5
EZ
80662011-07-14 Eli Zaretskii <eliz@gnu.org>
8067
df9733bf
EZ
8068 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8069 bidi_cache_idx.
8070
0bb23927
EZ
8071 Support bidi reordering of display and overlay strings.
8072 * xdisp.c (compute_display_string_pos)
8073 (compute_display_string_end): Accept additional argument STRING.
8074 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8075 (reseat_to_string): Initialize bidi_it->string.s and
8076 bidi_it->string.schars.
8077 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8078 NULL (avoids a crash in bidi_paragraph_init).
8079 Initialize itb.string.lstring.
0bb23927
EZ
8080 (init_iterator): Call bidi_init_it only of a valid
8081 buffer position was specified. Initialize paragraph_embedding to
8082 L2R.
8083 (reseat_to_string): Initialize the bidi iterator.
8084 (display_string): If we need to ignore text properties of
8085 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8086 original value of -1 will not work with bidi.)
8087 (compute_display_string_pos): First arg is now struct
8088 `text_pos *'; all callers changed. Support display properties on
8089 Lisp strings.
8090 (compute_display_string_end): Support display properties on Lisp
8091 strings.
8092 (init_iterator, reseat_1, reseat_to_string): Initialize the
8093 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8094 when iterating on a string not from display properties).
640c8776
SM
8095 (compute_display_string_pos, compute_display_string_end):
8096 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8097 arrow keys.
8098 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8099 base_level_stop; instead, set base_level_stop to BEGV.
8100 Fixes crashes in vertical-motion.
0bb23927
EZ
8101 (next_element_from_buffer): Improve commentary for when
8102 the iterator is before prev_stop.
8103 (init_iterator): Initialize bidi_p from the default value of
8104 bidi-display-reordering, not from buffer-local value. Use the
8105 buffer-local value only if initializing for buffer iteration.
8106 (handle_invisible_prop): Support invisible properties on strings
8107 that are being bidi-reordered.
8108 (set_iterator_to_next): Support bidi reordering of C strings and
8109 Lisp strings.
8110 (next_element_from_string): Support bidi reordering of Lisp
8111 strings.
8112 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8113 (display_string): Support display of R2L glyph rows.
8114 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8115 (init_iterator): Don't initialize it->bidi_p for strings
8116 here.
8117 (reseat_to_string): Initialize it->bidi_p for strings here.
8118 (next_element_from_string, next_element_from_c_string)
8119 (next_element_from_buffer): Add xassert's for correspondence
8120 between IT's object being iterated and it->bidi_it.string
8121 structure.
8122 (face_before_or_after_it_pos): Support bidi iteration.
8123 (next_element_from_c_string): Handle the case of the first string
8124 character that is not the first one in the visual order.
8125 (get_visually_first_element): New function, refactored from common
8126 parts of next_element_from_buffer, next_element_from_string, and
8127 next_element_from_c_string.
8128 (tool_bar_lines_needed, redisplay_tool_bar)
8129 (display_menu_bar): Force left-to-right direction. Add a FIXME
8130 comment for making that be controlled by a user option.
8131 (push_it, pop_it): Save and restore the state of the
8132 bidi iterator. Save and restore the bidi_p flag.
8133 (pop_it): Iterate out of display property for string iteration as
8134 well.
8135 (iterate_out_of_display_property): Support iteration over strings.
8136 (handle_single_display_spec): Set up it->bidi_it for iteration
8137 over a display string, and call bidi_init_it.
8138 (handle_single_display_spec, next_overlay_string)
8139 (get_overlay_strings_1, push_display_prop): Set up the bidi
8140 iterator for displaying display or overlay strings.
8141 (forward_to_next_line_start): Don't use the shortcut if
8142 bidi-iterating.
8143 (back_to_previous_visible_line_start): If handle_display_prop
8144 pushed the iterator stack, restore the internal state of the bidi
8145 iterator by calling bidi_pop_it same number of times.
8146 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8147 and we are bidi-iterating, don't decrement the iterator position;
8148 instead, set the first_elt flag in the bidi iterator, to produce
8149 the same effect.
8150 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8151 (push_display_prop): xassert that we are iterating a buffer.
8152 (push_it, pop_it): Save and restore paragraph_embedding member.
8153 (handle_single_display_spec, next_overlay_string)
8154 (get_overlay_strings_1, reseat_1, reseat_to_string)
8155 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8156 correctly. Don't assume unibyte strings are not bidi-reordered.
8157 (compute_display_string_pos)
8158 (compute_display_string_end): Fix handling the case of C string.
8159 (push_it, pop_it): Save and restore from_disp_prop_p.
8160 (handle_single_display_spec, push_display_prop): Set the
8161 from_disp_prop_p flag.
8162 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8163 (pop_it): Call iterate_out_of_display_property only if we are
8164 popping after iteration over a string that came from a display
8165 property. Fix a typo in popping stretch info. Add an assertion
8166 for verifying that the iterator position is in sync with the bidi
8167 iterator.
8168 (handle_single_display_spec, get_overlay_strings_1)
8169 (push_display_prop): Fix initialization of paragraph direction for
8170 string when that of the parent object is not yet determined.
8171 (reseat_1): Call bidi_init_it to resync the bidi
8172 iterator with IT's position. (Bug#7616)
8173 (find_row_edges): If ROW->start.pos gives position
8174 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8175 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8176 Reset the from_disp_prop_p flag.
8177 (SAVE_IT, RESTORE_IT): New macros.
8178 (pos_visible_p, face_before_or_after_it_pos)
8179 (back_to_previous_visible_line_start)
8180 (move_it_in_display_line_to, move_it_in_display_line)
8181 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8182 (try_scrolling, redisplay_window, display_line): Use them when
8183 saving a temporary copy of the iterator and restoring it back.
8184 (back_to_previous_visible_line_start, reseat_1)
8185 (init_iterator): Empty the bidi cache "stack".
8186 (move_it_in_display_line_to): If iterator ended up at
8187 EOL, but we never saw any buffer positions smaller than
8188 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8189 motion in bidi-reordered lines.
8190 (move_it_in_display_line_to): Record prev_method and prev_pos
8191 immediately before the call to set_iterator_to_next. Fixes cursor
8192 motion in bidi-reordered lines with stretch glyphs and strings
8193 displayed in margins. (Bug#8133) (Bug#8867)
8194 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8195 TO_CHARPOS.
640c8776
SM
8196 (pos_visible_p): Support positions in bidi-reordered lines.
8197 Save and restore bidi cache.
0bb23927
EZ
8198
8199 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8200 (bidi_paragraph_info): Delete unused struct.
8201 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8202 (bidi_cache_start): New variable.
8203 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8204 to zero.
8205 (bidi_cache_fetch_state, bidi_cache_search)
8206 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8207 (bidi_cache_find, bidi_peek_at_next_level)
8208 (bidi_level_of_next_char, bidi_find_other_level_edge)
8209 (bidi_move_to_visually_next): Compare cache index with
8210 bidi_cache_start rather than with zero.
8211 (bidi_fetch_char): Accept new argument STRING; all callers
8212 changed. Support iteration over a string. Support strings with
8213 display properties. Support unibyte strings. Fix the type of
8214 `len' according to what STRING_CHAR_AND_LENGTH expects.
8215 (bidi_paragraph_init, bidi_resolve_explicit_1)
8216 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8217 (bidi_level_of_next_char, bidi_move_to_visually_next):
8218 Support iteration over a string.
0bb23927
EZ
8219 (bidi_set_sor_type, bidi_resolve_explicit_1)
8220 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8221 can now be zero (for strings); special values 0 and -1 were
8222 changed to -1 and -2, respectively.
8223 (bidi_char_at_pos): New function.
8224 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8225 Call it instead of FETCH_MULTIBYTE_CHAR.
8226 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8227 initialized to valid values.
8228 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8229 values.
8230 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8231 the test for valid cached positions. Fix the logic for looking up
8232 the sentinel state in the cache. GCPRO the Lisp string we are
8233 iterating.
8234 (bidi_push_it, bidi_pop_it): New functions.
8235 (bidi_initialize): Initialize the bidi cache start stack pointer.
8236 (bidi_cache_ensure_space): New function, refactored from part of
8237 bidi_cache_iterator_state. Don't assume the required size is just
8238 one BIDI_CACHE_CHUNK away.
8239 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8240 (bidi_count_bytes, bidi_char_at_pos): New functions.
8241 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8242 always valid if bidi_cache_idx is valid.
8243 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8244 is valid if it's going to be used.
8245 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8246 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8247 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8248 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8249 (bidi_find_other_level_edge, bidi_cache_start_stack):
8250 All variables related to cache indices are now EMACS_INT.
c965adc5 8251
0bb23927
EZ
8252 * dispextern.h (struct bidi_string_data): New structure.
8253 (struct bidi_it): New member `string'. Make flag members be 1-bit
8254 fields, and put them last in the struct.
640c8776
SM
8255 (compute_display_string_pos, compute_display_string_end):
8256 Update prototypes.
0bb23927
EZ
8257 (bidi_push_it, bidi_pop_it): Add prototypes.
8258 (struct iterator_stack_entry): New members bidi_p,
8259 paragraph_embedding, and from_disp_prop_p.
8260 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8261 (bidi_shelve_cache, bidi_unshelve_cache):
8262 Declare prototypes.
0bb23927
EZ
8263
8264 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8265 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8266 and vector-like objects.
8267
8268 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8269 cache around display iteration.
8270
8271 * window.c (Fwindow_end, window_scroll_pixel_based)
8272 (displayed_window_lines, Frecenter): Save and restore the bidi
8273 cache around display iteration.
8274
3bbd2265
LMI
82752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8276
8277 * editfns.c (Fdelete_region): Clarify the use of the named
8278 parameters (bug#6788).
8279
adc47434
MR
82802011-07-14 Martin Rudalics <rudalics@gmx.at>
8281
8282 * indent.c (Fvertical_motion): Set and restore w->pointm when
8283 saving and restoring the window's buffer (Bug#9006).
8284
837c31f8
LMI
82852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8286
8287 * editfns.c (Fstring_to_char): Clarify just what is returned
8288 (bug#6576). Text by Eli Zaretskii.
8289
ac389d0c
JB
82902011-07-13 Juanma Barranquero <lekktu@gmail.com>
8291
8292 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8293
0be0ce47
EZ
82942011-07-13 Eli Zaretskii <eliz@gnu.org>
8295
8296 * buffer.c (mmap_find): Fix a typo.
8297
cd18e7e3
JB
82982011-07-13 Johan Bockgård <bojohan@gnu.org>
8299
8300 Fix execution of x selection hooks.
8301 * xselect.c (Qx_lost_selection_functions)
8302 (Qx_sent_selection_functions): New vars.
8303 (syms_of_xselect): DEFSYM them.
8304 (x_handle_selection_request): Pass Qx_sent_selection_functions
8305 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8306 (x_handle_selection_clear,x_clear_frame_selections):
8307 Pass Qx_lost_selection_functions rather than
8308 Vx_lost_selection_functions to Frun_hook_with_args.
8309
47ea7f44
PE
83102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8311
ac389d0c 8312 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8313 The old code sometimes used this field without initializing it.
8314
47ea7f44
PE
8315 * alloc.c (gc_sweep): Don't read past end of array.
8316 In theory, the old code could also have corrupted Emacs internals,
8317 though it'd be very unlikely.
8318
bc985c87
AS
83192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8320
8321 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8322 argument. (Bug#4026)
bc985c87 8323
0cf34688
LMI
83242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8325
b3dadd76
LMI
8326 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8327 key" (bug#4257).
8328
0cf34688
LMI
8329 * window.c (Fset_window_start): Doc fix (bug#4199).
8330 (Fset_window_hscroll): Ditto.
8331
270768cd
PE
83322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8333
077e3dda 8334 Fix minor new problems caught by GCC 4.6.1.
270768cd 8335 * term.c (init_tty): Remove unused local.
490011a6 8336 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8337 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8338 not used otherwise.
270768cd 8339
b1f58454
CY
83402011-07-12 Chong Yidong <cyd@stupidchicken.com>
8341
8342 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8343
22b9578d
LMI
83442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8345
6e70ab07
LMI
8346 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8347 are the mini-buffer and the echo area (bug#3320).
8348
22b9578d
LMI
8349 * term.c (init_tty): Remove support for supdup, c10 and perq
8350 terminals, which are no longer supported (bug#1482).
8351
8974cc9f
JB
83522011-07-10 Johan Bockgård <bojohan@gnu.org>
8353
8354 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8355
a560d974
JD
83562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8357
8358 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8359 for non-popups (Bug#3642).
8360
1dae0f0a
AS
83612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8362
268c2c36 8363 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8364 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8365 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8366 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8367 * data.c (fmod): Likewise.
8368 * dispnew.c (swap_glyphs_in_rows): Likewise.
8369 * emacs.c (memory_warning_signal): Likewise.
8370 * floatfns.c (float_error): Likewise.
8371 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8372 (otf_open, font_otf_capability, generate_otf_features)
8373 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8374 Likewise.
8375 * image.c (pbm_read_file): Likewise.
8376 * indent.c (string_display_width): Likewise.
8377 * intervals.c (check_for_interval, search_for_interval)
8378 (inc_interval_count, count_intervals, root_interval)
8379 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8380 * lread.c (defalias): Likewise.
268c2c36 8381 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8382 * regex.c (set_image_of_range_1, set_image_of_range)
8383 (regex_grow_registers): Likewise.
8384 * sysdep.c (strerror): Likewise.
8385 * termcap.c (valid_filename_p, tprint, main): Likewise.
8386 * tparam.c (main): Likewise.
8387 * unexhp9k800.c (run_time_remap, save_data_space)
8388 (update_file_ptrs, read_header, write_header, calculate_checksum)
8389 (copy_file, copy_rest, display_header): Likewise.
8390 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8391 Likewise.
8392 * xdisp.c (check_it): Likewise.
8393 * xfaces.c (register_color, unregister_color, unregister_colors):
8394 Likewise.
8395 * xfns.c (print_fontset_result): Likewise.
8396 * xrdb.c (member, fatal, main): Likewise.
8397
99033785
PE
83982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8399
8400 Fix minor problems found by static checking (Bug#9031).
8401 * chartab.c (char_table_set_range, map_sub_char_table):
8402 Remove unused locals.
8403 (uniprop_table): Now static.
8404 * composite.c (_work_char): Remove unused static var.
8405
9cb2ac56
JB
84062011-07-09 Juanma Barranquero <lekktu@gmail.com>
8407
8408 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8409
f25661f0
JD
84102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8411
8412 * gtkutil.c (qttip_cb): Remove code without function.
8413
8278c4fe
EZ
84142011-07-09 Eli Zaretskii <eliz@gnu.org>
8415
8416 * w32.c (pthread_sigmask): New stub.
8417
1692ae2d 84182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8419
8a6ebd58 8420 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8421 sigprocmask is portable only for single-threaded applications, and
8422 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8423 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8424 (LIBES): Use it.
8425 * callproc.c (Fcall_process):
8426 * process.c (create_process):
8427 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8428 Use pthread_sigmask, not sigprocmask.
123403e4 8429
1b854618
JD
84302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8431
8432 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8433 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8434 wrong (Bug#8591).
8435
3fe4b549
JD
84362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8437
0ce7e563
JD
8438 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8439 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8440 (xg_hide_tooltip): Fix comment.
8441
3fe4b549
JD
8442 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8443 in registerServicesMenuSendTypes.
8444 (validRequestorForSendType): Don't check ns_return_types.
8445
8446 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8447 ns_return_type.
8448
5df75e47
JR
84492011-07-08 Jason Rumney <jasonr@gnu.org>
8450
22610910
JR
8451 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8452 SH_SHOW for hidden windows (Bug#5482).
8453
5df75e47
JR
8454 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8455 frame struct members of non-existent frames (Bug#6284).
8456
699c10bd
JD
84572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8458
4393663b
JD
8459 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8460 variable firstTime not needed on OSX >= 10.6.
8461 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8462 >= 10.5. Use setKnobProportion, setDoubleValue.
8463
8464 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8465 (MAC_OS_X_VERSION_10_5): Define if not defined.
8466 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8467 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8468 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8469
8470 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8471 cString and lossyCString on OSX >= 10.4.
4393663b 8472
58179cce 8473 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8474 sizeToFit on OSX >= 10.2.
8475
8476 * nsimage.m (allocInitFromFile): Don't use deprecated method
8477 bestRepresentationForDevice on OSX >= 10.6.
8478
8479 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8480 to avoid warning.
8481
8482 * emacs.c: Declare unexec_init_emacs_zone.
8483
a63e0781
JD
8484 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8485
699c10bd
JD
8486 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8487
8488 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8489 on svcsMenu (Bug#8842).
8490
8491 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8492 ns_return_types.
8493 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8494
8495 * nsterm.m (QUTF8_STRING): Declare.
8496 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8497 (validRequestorForSendType): Return type is (id).
8498 Change indexOfObjectIdenticalTo to indexOfObject.
8499 Check if we have local selection before returning self (Bug#8842).
8500 (writeSelectionToPasteboard): Put local selection into paste board
8501 if we have a local selection (Bug#8842).
8502 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8503
8504 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8505 (ns_get_local_selection): Declare.
8506
54e10184
LMI
85072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8508
9888ff71
LMI
8509 * keymap.c (describe_map_tree): Don't insert a double newline at
8510 the end of the buffer (bug#1169) and return whether we inserted
8511 something.
8512
54e10184
LMI
8513 * callint.c (Fcall_interactively): Change "reading args" to
8514 "providing args" to try to clarify what it does (bug#1010).
8515
15fa4783
KH
85162011-07-07 Kenichi Handa <handa@m17n.org>
8517
8518 * composite.c (composition_compute_stop_pos): Ignore a static
8519 composition starting before CHARPOS (Bug#8915).
8520
8521 * xdisp.c (handle_composition_prop): Likewise.
8522
a8815b00
EZ
85232011-07-07 Eli Zaretskii <eliz@gnu.org>
8524
8525 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8526 (Bug#9015)
8527
ef7b981d 85282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8529
8530 * character.h (unicode_category_t): New enum type.
8531
8532 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8533 (Qchar_code_property_table): New variable.
8534 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8535 (UNIPROP_COMPRESSED_FORM_P): New macros.
8536 (char_table_ascii): Uncompress the compressed values.
8537 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8538 Uncompress the compressed values.
ac389d0c 8539 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8540 (char_table_ref_and_range): Uncompress the compressed values.
8541 (sub_char_table_set): New arg is_uniprop. Callers changed.
8542 Uncompress the compressed values.
8543 (sub_char_table_set_range): Args changed. Callers changed.
8544 (char_table_set_range): Adjuted for the above change.
8545 (map_sub_char_table): Delete args default_val and parent. Add arg
8546 top. Give decoded values to a Lisp function.
640c8776 8547 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8548 values to a Lisp function. Gcpro more variables.
8549 (uniprop_table_uncompress)
8550 (uniprop_decode_value_run_length): New functions.
8551 (uniprop_decoder, uniprop_decoder_count): New variables.
8552 (uniprop_get_decoder, uniprop_encode_value_character)
8553 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8554 New functions.
8555 (uniprop_encoder, uniprop_encoder_count): New variables.
8556 (uniprop_get_encoder, uniprop_table)
8557 (Funicode_property_table_internal, Fget_unicode_property_internal)
8558 (Fput_unicode_property_internal): New functions.
8559 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8560 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8561 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8562 char-code-property-alist.
8563
640c8776 8564 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8565 Vunicode_category_table.
8566
640c8776 8567 * font.c (font_range): Adjust for the change of
c805dec0
KH
8568 Vunicode_category_table.
8569
76b397fb
DN
85702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8571
8572 * m/iris4d.h: Remove file, move contents ...
8573 * s/irix6-5.h: ... here.
8574
22b4128e
PE
85752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8576
8577 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8578 * alloc.c (mark_buffer):
8579 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8580 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8581 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8582 This isn't true in general, and it's particularly not true
8583 if Emacs is configured with --with-wide-int.
8584 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8585 New macros, used in the buffer.c change.
8586
869795d6
JD
85872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8588
8589 * xsettings.c: Use both GConf and GSettings if both are available.
8590 (store_config_changed_event): Add comment.
8591 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8592 (store_tool_bar_style_changed): New functions.
5e617bc2 8593 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8594 (struct xsettings): Move font inside HAVE_XFT.
8595 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8596 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8597 Move inside HAVE_XFT.
640c8776 8598 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8599 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8600 also.
8601 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8602 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8603 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8604 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8605 (parse_settings): Move check for font inside HAVE_XFT.
8606 (read_settings, apply_xft_settings): Add comment.
8607 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8608 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8609 call store_font_name_changed.
8610 (xft_settings_event): Add comment.
8611 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8612 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8613 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8614 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8615 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8616 (xsettings_get_system_font, xsettings_get_system_normal_font):
8617 Add comment.
869795d6 8618
d8ed26bd
PE
86192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8620
8621 Random fixes. E.g., (random) never returned negative values.
8622 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8623 subseconds part to the entropy, as that's a bit more random.
8624 Prefer signed to unsigned, since the signedness doesn't matter and
8625 in general we prefer signed. When given a limit, use a
8626 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8627 latter isn't right if USE_2_TAGS_FOR_INTS.
8628 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8629 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8630
cabf1cac
SM
86312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8632
8633 * textprop.c (text_property_stickiness):
8634 Obey Vtext_property_default_nonsticky.
8635 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8636 * w32fns.c (syms_of_w32fns):
8637 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8638
6e9b2be9
PE
86392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8640
8641 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8642 This is more efficient than Ffile_directory_p and avoids a minor race.
8643
90186c68
LMI
86442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8645
7c301272
LMI
8646 * buffer.c (Foverlay_put): Say what the return value is
8647 (bug#7835).
8648
c4f2d8d4
LMI
8649 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8650 is a directory before asking whether to use the file name
8651 (bug#7564).
ad637907
LMI
8652 (barf_or_query_if_file_exists): Make the "File is a directory"
8653 error be more correct.
c4f2d8d4 8654
90186c68
LMI
8655 * fns.c (Frequire): Remove the mention of the .gz files, since
8656 that's installation-specific, but keep the mention of
8657 `get-load-suffixes'.
8658
da64016e
PE
86592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8660
8661 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8662 Report string overflow if the output is too long.
8663
7d47b580
JB
86642011-07-04 Juanma Barranquero <lekktu@gmail.com>
8665
a555cb87
JB
8666 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8667 (syms_of_gnutls): Remove duplicate DEFSYM for
8668 Qgnutls_bootprop_verify_hostname_error, an error for
8669 Qgnutls_bootprop_verify_error (which is no longer used).
8670
7d47b580
JB
8671 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8672 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8673 Also (re)move comments that are misplaced or no longer relevant.
8674
1e49bfab
LMI
86752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8676
8677 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8678
1485f4c0
CY
86792011-07-03 Chong Yidong <cyd@stupidchicken.com>
8680
8681 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8682 and background color parameters if they have been changed.
8683
a9ab721e
LMI
86842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8685
8686 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8687
cf7cff57
PE
86882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8689
2e13213d
PE
8690 * xsettings.c (SYSTEM_FONT): Define only when used.
8691 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8692
cf7cff57
PE
8693 * keymap.c (access_keymap_1): Now static.
8694
7a8e04f7
CY
86952011-07-02 Chong Yidong <cyd@stupidchicken.com>
8696
8697 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8698 leave any prefix arg for the up event (Bug#1586).
8699
61352f62
LMI
87002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8701
69bb1ef7
LMI
8702 * lread.c (syms_of_lread): Mention single symbols defined by
8703 `defvar' or `defconst' (bug#7154).
8704
61352f62 8705 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8706 (Frequire): Mention get-load-suffixes.
61352f62 8707
28545e04
MR
87082011-07-02 Martin Rudalics <rudalics@gmx.at>
8709
8710 * window.h (window): Remove clone_number slot.
8711 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8712 Remove.
8713 (make_parent_window, make_window, saved_window)
8714 (Fset_window_configuration, save_window_save): Don't deal with
8715 clone numbers.
8716 * buffer.c (Qclone_number): Remove declaration.
8717 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8718
3349e122
SM
87192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8720
8721 Add multiple inheritance to keymaps.
8722 * keymap.c (Fmake_composed_keymap): New function.
8723 (Fset_keymap_parent): Simplify.
8724 (fix_submap_inheritance): Remove.
8725 (access_keymap_1): New function extracted from access_keymap to handle
8726 embedded parents and handle lists of maps.
8727 (access_keymap): Use it.
8728 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8729 (Fcopy_keymap): Handle embedded parents.
8730 (Fcommand_remapping, define_as_prefix): Simplify.
8731 (Fkey_binding): Simplify.
8732 (syms_of_keymap): Move minibuffer-local-completion-map,
8733 minibuffer-local-filename-completion-map,
8734 minibuffer-local-must-match-map, and
8735 minibuffer-local-filename-must-match-map to Elisp.
8736 (syms_of_keymap): Defsubr make-composed-keymap.
8737 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8738 (parse_menu_item): Trivial simplification.
8739
3279eb87
GM
87402011-07-01 Glenn Morris <rgm@gnu.org>
8741
8742 * Makefile.in (SETTINGS_LIBS): Fix typo.
8743
4550efdf
KI
87442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8745
8746 * coding.c (Fencode_coding_string): Record the last coding system
8747 used, as the function doc string says (bug#8738).
8748
0949d2b6
JD
87492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8750
8751 * xsettings.c (store_monospaced_changed): Take new font as arg and
8752 check for change against current_mono_font.
8753 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8754 (emacs_settings_constructor, emacs_settings_get_property)
8755 (emacs_settings_set_property, emacs_settings_class_init)
8756 (emacs_settings_init, gsettings_obj): Remove.
8757 (something_changedCB): New function for HAVE_GSETTINGS.
8758 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8759 with value as argument.
8760 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8761 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8762 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8763 "changed".
8764
8765 * xgselect.c: Add defined (HAVE_GSETTINGS).
8766 (xgselect_initialize): Ditto.
8767
8768 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8769 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8770 xg_select.
8771
bbc6b304
PE
87722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8773
8774 * eval.c (struct backtrace): Simplify and port the data structure.
8775 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8776 signed bit field, as this assumption is not portable and it makes
8777 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8778 "char debug_on_exit : 1" as this is not portable either; instead,
8779 use the portable "unsigned int debug_on_exit : 1". Remove unused
8780 member evalargs. Remove obsolete comments about cc bombing out.
8781
9851bfc5
JD
87822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8783
51bb811f 8784 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8785 Let HAVE_GSETTINGS override HAVE_GCONF.
8786 (store_monospaced_changed): New function.
8787 (EMACS_SETTINGS): A new type derived from GObject to handle
8788 GSettings notifications.
8789 (emacs_settings_constructor, emacs_settings_get_property)
8790 (emacs_settings_set_property, emacs_settings_class_init):
8791 New functions.
8792 (gsettings_client, gsettings_obj): New variables.
8793 (GSETTINGS_SCHEMA): New define.
8794 (something_changedCB): Call store_monospaced_changed.
8795 (init_gsettings): New function.
8796 (xsettings_initialize): Call init_gsettings.
8797 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8798 to NULL.
8799
640c8776 8800 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8801 GCONF_CFLAGS/LIBS.
8802
5386012d
MR
88032011-06-29 Martin Rudalics <rudalics@gmx.at>
8804
8805 * window.c (resize_root_window, grow_mini_window)
8806 (shrink_mini_window): Rename Qresize_root_window to
8807 Qwindow_resize_root_window and Qresize_root_window_vertically to
8808 Qwindow_resize_root_window_vertically.
8809
f13e0b08
PE
88102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8811
8812 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8813
94515237
JB
88142011-06-27 Juanma Barranquero <lekktu@gmail.com>
8815
8816 * makefile.w32-in: Redesign dependencies so they reflect more
8817 clearly which files are directly included by each source file,
8818 and not through other includes.
8819
e43b6e43
MR
88202011-06-27 Martin Rudalics <rudalics@gmx.at>
8821
8822 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8823 (sort_overlays, overlay_strings): When an overlay's clone number
8824 matches the window's clone number process the overlay even if
8825 the overlay's window property doesn't match the current window.
8826
d68443dc
MR
8827 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8828 (Fwindow_hchild): Rename to Fwindow_left_child.
8829 (Fwindow_next): Rename to Fwindow_next_sibling.
8830 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8831 (resize_window_check): Rename to window_resize_check.
8832 (resize_window_apply): Rename to window_resize_apply.
8833 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8834 (Fdelete_other_windows_internal, resize_frame_windows)
8835 (Fsplit_window_internal, Fdelete_window_internal)
8836 (grow_mini_window, shrink_mini_window)
8837 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8838
c7e73be5
JD
88392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8840
8841 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8842 (emacs_fixed_set_min_size): Remove.
8843 (emacs_fixed_new): Take frame as argument.
8844
8845 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8846 (_EmacsFixedPrivate): Remove minwidth/height.
8847 Add struct frame *f.
8848 (emacs_fixed_init): Initialize priv->f.
8849 (get_parent_class, emacs_fixed_set_min_size): Remove.
8850 (emacs_fixed_new): Set priv->f to argument.
8851 (emacs_fixed_get_preferred_width)
8852 (emacs_fixed_get_preferred_height): Use min_width/height from
8853 frames size_hint to set minimum and natural (Bug#8919).
8854 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8855 and use min_width/height from frames size_hint to set
8856 min_width/height (Bug#8919).
8857
8858 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8859 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8860 Fix indentation.
c7e73be5 8861
cf99dcf8
EZ
88622011-06-26 Eli Zaretskii <eliz@gnu.org>
8863
8864 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8865 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8866 called at ZV.
8867
029529ac
CY
88682011-06-26 Chong Yidong <cyd@stupidchicken.com>
8869
8870 * process.c (wait_reading_process_output): Bypass select if
8871 waiting for a cell while ignoring keyboard input, and input is
8872 pending. Suggested by Jan Djärv (Bug#8869).
8873
7a7ef429
PE
88742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8875
8876 Use gnulib's dup2 module instead of rolling our own.
8877 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8878
11fdef7d 88792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8880
8881 * dispnew.c (scrolling_window): Before scrolling, turn off a
8882 mouse-highlight in the window being scrolled.
8883
cd3520a4
JB
88842011-06-24 Juanma Barranquero <lekktu@gmail.com>
8885
8886 Move DEFSYM to lisp.h and use everywhere.
8887
8888 * character.h (DEFSYM): Move declaration...
8889 * lisp.h (DEFSYM): ...here.
8890
8891 * gnutls.c:
8892 * minibuf.c:
8893 * w32menu.c:
8894 * w32proc.c:
8895 * w32select.c: Don't include character.h.
8896
8897 * alloc.c (syms_of_alloc):
8898 * buffer.c (syms_of_buffer):
8899 * bytecode.c (syms_of_bytecode):
8900 * callint.c (syms_of_callint):
8901 * casefiddle.c (syms_of_casefiddle):
8902 * casetab.c (init_casetab_once):
8903 * category.c (init_category_once, syms_of_category):
8904 * ccl.c (syms_of_ccl):
8905 * cmds.c (syms_of_cmds):
8906 * composite.c (syms_of_composite):
8907 * dbusbind.c (syms_of_dbusbind):
8908 * dired.c (syms_of_dired):
8909 * dispnew.c (syms_of_display):
8910 * doc.c (syms_of_doc):
8911 * editfns.c (syms_of_editfns):
8912 * emacs.c (syms_of_emacs):
8913 * eval.c (syms_of_eval):
8914 * fileio.c (syms_of_fileio):
8915 * fns.c (syms_of_fns):
8916 * frame.c (syms_of_frame):
8917 * fringe.c (syms_of_fringe):
8918 * insdel.c (syms_of_insdel):
8919 * keymap.c (syms_of_keymap):
8920 * lread.c (init_obarray, syms_of_lread):
8921 * macros.c (syms_of_macros):
8922 * msdos.c (syms_of_msdos):
8923 * print.c (syms_of_print):
8924 * process.c (syms_of_process):
8925 * search.c (syms_of_search):
8926 * sound.c (syms_of_sound):
8927 * syntax.c (init_syntax_once, syms_of_syntax):
8928 * terminal.c (syms_of_terminal):
8929 * textprop.c (syms_of_textprop):
8930 * undo.c (syms_of_undo):
8931 * w32.c (globals_of_w32):
8932 * window.c (syms_of_window):
8933 * xdisp.c (syms_of_xdisp):
8934 * xfaces.c (syms_of_xfaces):
8935 * xfns.c (syms_of_xfns):
8936 * xmenu.c (syms_of_xmenu):
8937 * xsettings.c (syms_of_xsettings):
8938 * xterm.c (syms_of_xterm): Use DEFSYM.
8939
4228cf16
TZ
89402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8941
cd3520a4 8942 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8943
7fcccf1e
PE
89442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8945
7efb4e0e
PE
8946 Integer and buffer overflow fixes (Bug#8873).
8947
ff5844ad
PE
8948 * print.c (printchar, strout): Check for string overflow.
8949 (PRINTPREPARE, printchar, strout):
8950 Don't set size unless allocation succeeds.
8951
90532f02
PE
8952 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8953 for sizes. Check for string overflow more accurately.
8954 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8955
6d84508d
PE
8956 * macros.c: Integer and buffer overflow fixes.
8957 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8958 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8959 Use ptrdiff_t, not int, for sizes.
8960 Don't increment bufsize until after realloc succeeds.
8961 Check for size-calculation overflow.
8962 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8963
437b2cb4
PE
8964 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8965
8b9ac8b4
PE
8966 * lread.c: Integer overflow fixes.
8967 (read_integer): Radix is now EMACS_INT, not int,
8968 to improve quality of diagnostics for out-of-range radices.
8969 Calculate buffer size correctly for out-of-range radices.
8970 (read1): Check for integer overflow in radices, and in
8971 read-circle numbers.
82cb60d3
PE
8972 (read_escape): Avoid int overflow.
8973 (Fload, openp, read_buffer_size, read1)
8974 (substitute_object_recurse, read_vector, read_list, map_obarray):
8975 Use ptrdiff_t, not int, for sizes.
8976 (read1): Use EMACS_INT, not int, for sizes.
20270765 8977 Check for size overflow.
8b9ac8b4 8978
7fcccf1e
PE
8979 * image.c (cache_image): Check for size arithmetic overflow.
8980
bfbbd7e7
PE
8981 * lread.c: Integer overflow issues.
8982 (saved_doc_string_size, saved_doc_string_length)
8983 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8984 Now ptrdiff_t, not int.
8985 (read1): Don't assume doc string length fits in int. Check for
8986 out-of-range doc string lengths.
8987 (read_list): Don't assume file position fits in int.
39019e54 8988 (read_escape): Check for hex character overflow.
bfbbd7e7 8989
4e323265
LL
89902011-06-22 Leo Liu <sdl.web@gmail.com>
8991
8992 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8993 Move to minibuffer.el.
8994
85fece3e
PE
89952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8996
20b84ce9 8997 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8998 The following patches are for when GLYPH_DEBUG && !XASSERT.
8999 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9000 * dispnew.c (flush_stdout):
9001 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9002 Mark as externally visible.
9003 * dispnew.c (check_window_matrix_pointers): Now static.
9004 * dispnew.c (window_to_frame_vpos):
9005 * xfns.c (unwind_create_frame):
9006 * xterm.c (x_check_font): Remove unused local.
9007 * scroll.c (CHECK_BOUNDS):
9008 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9009 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9010 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9011 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9012 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9013 Now static.
9014 (debug_method_add): Use va_list and vsprintf rather than relying
9015 on undefined behavior with wrong number of arguments.
9016 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9017 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9018 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9019 since we're not interested in debugging glyphs with old libraries.
9020 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9021 GCC 4.6.0's static checking.
9022
0766b489
PE
90232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9024
31fd4b32
PE
9025 Integer overflow and signedness fixes (Bug#8873).
9026 A few related buffer overrun fixes, too.
9027
b79e8648
PE
9028 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9029
0766b489
PE
9030 * dispextern.h (struct face.stipple):
9031 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9032 (x_bitmap_mask, x_allocate_bitmap_record)
9033 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9034 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9035 (x_create_bitmap_from_xpm_data):
9036 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9037 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9038 (.bitmaps_last):
9039 * xfaces.c (load_pixmap):
9040 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9041 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9042 (.bitmaps_last, struct x_output.icon_bitmap):
9043 Use ptrdiff_t, not int, for bitmap indexes.
9044 (x_allocate_bitmap_record): Check for size overflow.
9045 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9046
b081724f
PE
9047 Use ptrdiff_t, not int, for overlay counts.
9048 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9049 * editfns.c (overlays_around, get_pos_property):
9050 * textprop.c (get_char_property_and_overlay):
9051 * xdisp.c (next_overlay_change, note_mouse_highlight):
9052 * xfaces.c (face_at_buffer_position):
21514da7
PE
9053 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9054 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9055 (Fnext_overlay_change, Fprevious_overlay_change)
9056 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9057 Use ptrdiff_t, not int, for sizes.
21514da7 9058 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9059
3de73e5e
PE
9060 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9061
2606c57b
PE
9062 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9063 (x_session_initialize): Do not assume string length fits in int.
9064
aaafe47a
PE
9065 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9066 This is unlikely, but can occur if DPI is outlandish.
9067
2674ddc8 9068 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9069 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9070
28154962
PE
9071 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9072 * xrdb.c (magic_file_p, search_magic_path):
9073 Omit last arg SUFFIX; it was always 0. All callers changed.
9074 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9075
7de51af5
PE
9076 * xfont.c (xfont_match): Avoid need for strlen.
9077
25ed6cc3
PE
9078 * xfns.c: Don't assume strlen fits in int.
9079 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9080
4eab31dd
PE
9081 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9082 not unsigned long, as we prefer signed integers. All callers changed.
9083 Detect integer overflow in repeat count.
9084 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9085 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9086
171e2a58
PE
9087 * termcap.c: Don't assume sizes fit in int and never overflow.
9088 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9089 (gobble_line): Check for size-calculation overflow.
9090
ad39faca 9091 * minibuf.c (Fread_buffer):
6e5bb2dc 9092 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9093 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9094 Don't assume string length fits in int.
9095
52c61c22 9096 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9097 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9098
b5b8c9e5
PE
9099 * font.c: Don't assume string length fits in int.
9100 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9101 Use ptrdiff_t, not int.
ccd6111c
PE
9102 (font_intern_prop): Don't assume string length fits in int.
9103 Don't assume integer property fits in fixnum.
9104 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9105
882f0d81 9106 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9107 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9108 Reformulate so as not to need the command string.
9109 Invoke gzip -cd rather than gunzip, as it's more portable.
9110 (lock_info_type, lock_file_1, lock_file):
9111 Don't assume pid_t and time_t fit in unsigned long.
9112 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9113 (current_lock_owner): Prefer signed type for sizes.
9114 Use memcpy, not strncpy, where memcpy is what is really wanted.
9115 Don't assume (via atoi) that time_t and pid_t fit in int.
9116 Check for time_t and/or pid_t out of range, e.g., via a network share.
9117 Don't alloca where an auto var works fine.
9118
93f4cf88
PE
9119 * fileio.c: Fix some integer overflow issues.
9120 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9121 Don't assume string length fits in int.
9122 (directory_file_name): Don't assume string length fits in long.
9123 (make_temp_name): Don't assume pid fits in int, or that its print
9124 length is less than 20.
9125
f3e92b69
PE
9126 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9127
1bfdaf10
PE
9128 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9129
35016e9a
PE
9130 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9131
3d1e65a1
PE
9132 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9133 We prefer signed integers, even for size calculations.
9134
0b963a93
PE
9135 * emacs.c: Don't assume string length fits in 'int'.
9136 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9137 (main): Don't invoke strlen when not needed.
9138
573f4b54
PE
9139 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9140 (XD_DEBUG_MESSAGE): Don't waste a byte.
9141
989f33ba
PE
9142 * callproc.c (getenv_internal_1, getenv_internal)
9143 (Fgetenv_internal):
965d34eb
PE
9144 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9145
e4d29b33
PE
9146 * lread.c (invalid_syntax): Omit length argument.
9147 All uses changed. This doesn't fix a bug, but it simplifies the
9148 code away from its former Hollerith-constant appearance, and it's
9149 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9150 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9151
eb49b136
PE
9152 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9153 This didn't break anything, but it didn't help either.
9154 It's confusing to put a bogus integer in a place where the actual
9155 value does not matter.
9f62aeb1 9156 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9157 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9158
15375a22
PE
9159 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9160 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9161 implementation.
b61cc01c
PE
9162 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9163 We prefer signed types, and the value cannot exceed the EMACS_INT
9164 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9165 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9166 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9167 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9168
53b2623d
PE
9169 * indent.c (sane_tab_width): New function.
9170 (current_column, scan_for_column, Findent_to, position_indentation)
9171 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9172 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9173
51cab52b 9174 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9175
f2ed8a70
PE
9176 * lisp.h (lint_assume): New macro.
9177 * composite.c (composition_gstring_put_cache):
9178 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9179
abe80cc6
PE
9180 * editfns.c, insdel.c:
9181 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9182
b02c740e
PE
9183 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9184
ebc96716
PE
9185 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9186
b4e50fa0 9187 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9188 Use much-faster test for byte-length change.
311d5d7c 9189 Don't assume string byte-length fits in 'int'.
a4cf38e4 9190 Check that character arg fits in 'int'.
85461888 9191 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9192
c0c1ee9f
PE
9193 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9194
a498d7f4
PE
9195 * fns.c (concat): Catch string overflow earlier.
9196 Do not rely on integer wraparound.
9197
51cab52b
PE
9198 * dispextern.h (struct it.overlay_strings_charpos)
9199 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9200 * xdisp.c (forward_to_next_line_start)
9201 (back_to_previous_visible_line_start)
9202 (reseat_at_next_visible_line_start, next_element_from_buffer):
9203 Don't arbitrarily truncate the value of 'selective' to int.
9204
76031fad
PE
9205 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9206
5eb55db9
PE
9207 * composite.c: Don't truncate sizes to 'int'.
9208 (composition_gstring_p, composition_reseat_it)
9209 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9210 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9211 not EMACS_UINT, for indexes.
5eb55db9 9212
0703a717
PE
9213 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9214
d6202519
PE
9215 * buffer.c: Include <verify.h>.
9216 (struct sortvec.priority, struct sortstr.priority):
8961a454 9217 Now EMACS_INT, not int.
c20998a7 9218 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9219 (struct sortstr.size, record_overlay_string)
9220 (struct sortstrlist.size, struct sortlist.used):
9221 Don't truncate size to int.
9222 (record_overlay_string): Check for size-calculation overflow.
d6202519 9223 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9224
d5a19415
JM
92252011-06-22 Jim Meyering <meyering@redhat.com>
9226
029529ac 9227 Don't leak an XBM-image-sized buffer
d5a19415
JM
9228 * image.c (xbm_load): Free the image buffer after using it.
9229
a9041e6c
PE
92302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9231
9232 Port to Sun C.
9233 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9234 that Sun C diagnosed.
9235 * fns.c (secure_hash): Fix pointer signedness issue.
9236 * intervals.c (static_offset_intervals): New function.
9237 (offset_intervals): Use it.
9238
7f3f739f
LL
92392011-06-21 Leo Liu <sdl.web@gmail.com>
9240
9241 * deps.mk (fns.o):
9242 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9243 sha512.h.
9244
9245 * fns.c (secure_hash): Rename from crypto_hash_function and change
9246 the first arg to accept symbols.
5b66d427 9247 (Fsecure_hash): New primitive.
7f3f739f
LL
9248 (syms_of_fns): New symbols.
9249
76147d94
DD
92502011-06-20 Deniz Dogan <deniz@dogan.se>
9251
9252 * process.c (Fset_process_buffer): Clarify return value in
9253 docstring.
9254
7d7d0045
CY
92552011-06-18 Chong Yidong <cyd@stupidchicken.com>
9256
9257 * dispnew.c (add_window_display_history): Use BVAR.
9258
9259 * xdisp.c (debug_method_add): Use BVAR.
9260 (check_window_end, dump_glyph_matrix, dump_glyph)
9261 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9262
9263 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9264 Likewise.
9265
9266 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9267 check till after the cache is created in init_frame_faces.
9268
ff2bc410
SM
92692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9270
9271 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9272
28177add
PE
92732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9274
dd3482fe
PE
9275 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9276 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9277 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9278
393d71f3 9279 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9280 * fileio.c (Finsert_file_contents):
9281 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9282 Remove the old (too-loose) buffer overflow checks.
9283 They weren't needed, since make_gap checks for buffer overflow.
9284 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9285 The old code merely checked for Emacs fixnum overflow, and relied
9286 on undefined (wraparound) behavior. The new code avoids undefined
9287 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9288
2e6813b0 9289 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9290 Tune. Don't use wider integers than needed. Don't use alloca.
9291 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9292
599a9e4f
PE
9293 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9294
99561444
PE
9295 * insdel.c, lisp.h (buffer_overflow): New function.
9296 (insert_from_buffer_1, replace_range, replace_range_2):
9297 * insdel.c (make_gap_larger):
9298 * editfns.c (Finsert_char):
9299 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9300
28177add
PE
9301 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9302
e69dafad
PE
93032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9304
4baa020d 9305 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9306
b1c46f02
PE
9307 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9308 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9309
e69dafad
PE
9310 * fileio.c: Don't assume EMACS_INT fits in off_t.
9311 (emacs_lseek): New static function.
9312 (Finsert_file_contents, Fwrite_region): Use it.
9313 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9314
566684ea
PE
9315 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9316
e6966cd6
PE
9317 * fns.c: Don't overflow int when computing a list length.
9318 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9319 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9320 truncation on 64-bit hosts. Check for QUIT every
9321 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9322 faster and is responsive enough.
9323 (Flength): Report an error instead of overflowing an integer.
9324 (Fsafe_length): Return a float if the value is not representable
9325 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9326 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9327 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9328
dd0b0efb
PE
9329 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9330 (header_size, word_size): New constants.
9331 (allocate_vectorlike): Don't check size overflow here.
9332 (allocate_vector): Check it here instead, since this is the only
9333 caller of allocate_vectorlike that could cause overflow.
9334 Check that the new vector's length is representable as a fixnum.
9335
86fe5cfe
PE
9336 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9337 The previous code was bogus. For example, next_almost_prime (32)
9338 returned 39, which is undesirable as it is a multiple of 3; and
9339 next_almost_prime (24) returned 25, which is a multiple of 5 so
9340 why was the code bothering to check for multiples of 7?
9341
80e88859
PE
9342 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9343
4a2f0ad6
PE
9344 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9345
f66c7cf8
PE
9346 Variadic C functions now count arguments with ptrdiff_t.
9347 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9348 Back then I didn't know that the Emacs coding style prefers signed int.
9349 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9350 were being counted with int, which may truncate counts on 64-bit
9351 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9352 * lisp.h (struct Lisp_Subr.function.aMANY)
9353 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9354 Arg counts are now ptrdiff_t, not size_t.
9355 All variadic functions and their callers changed accordingly.
9356 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9357 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9358 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9359 * callint.c (Fcall_interactively): Check arg count for overflow,
9360 to avoid potential buffer overrun. Use signed char, not 'int',
9361 for 'varies' array, so that we needn't bother to check its size
9362 calculation for overflow.
9363 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9364 * eval.c (apply_lambda):
9365 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9366 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9367 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9368
a1759b76
PE
9369 * callint.c (Fcall_interactively): Don't use index var as event count.
9370
d96be9fc
PE
9371 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9372 * mem-limits.h (SIZE): Remove; no longer used.
9373
a690a978 9374 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9375
578c21e6
PE
9376 Remove unnecessary casts.
9377 * xterm.c (x_term_init):
9378 * xfns.c (x_set_border_pixel):
9379 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9380 These aren't needed now that we assume ANSI C.
9381
96f53c6c
PE
9382 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9383 It's more likely to cause problems (due to unsigned overflow)
9384 than to cure them.
9385
83c77d31
PE
9386 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9387
ee2079f1
PE
9388 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9389
6da65536
PE
9390 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9391
7147c4a4
PE
9392 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9393
193e32d9
PE
9394 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9395
e5533da6
PE
9396 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9397
9910e595
PE
9398 GLYPH_CODE_FACE returns EMACS_INT, not int.
9399 * dispextern.h (merge_faces):
9400 * xfaces.c (merge_faces):
01103c44
PE
9401 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9402 Don't assume EMACS_INT fits in int.
9910e595 9403
2638320e
PE
9404 * character.h (CHAR_VALID_P): Remove unused parameter.
9405 * fontset.c, lisp.h, xdisp.c: All uses changed.
9406
045eb8d9
PE
9407 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9408
c1f134b5
PE
9409 * fns.c (concat): Minor tuning based on overflow analysis.
9410 This doesn't fix any bugs. Use int to hold character, instead
9411 of constantly refetching from Emacs object. Use XFASTINT, not
9412 XINT, for value known to be a character. Don't bother comparing
9413 a single byte to 0400, as it's always less.
9414
395fcb93 9415 * floatfns.c (Fexpt):
327eeec8
PE
9416 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9417
abbd3d23
PE
9418 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9419 for characters.
9420
684a03ef
PE
9421 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9422
0fed43f3
PE
9423 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9424 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9425 incorrectly succeed when S was a string, because 4294967386 was
9426 truncated before it was used.
9427
8fd02eb7
PE
9428 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9429 Otherwise, an out-of-range integer could cause undefined behavior
9430 on a 64-bit host.
9431
f8c86b69
PE
9432 * composite.c: Use int, not EMACS_INT, for characters.
9433 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9434 EMACS_INT, for values that are known to be in character range.
9435 This doesn't fix any bugs but is the usual style inside Emacs and
9436 may generate better code on 32-bit machines.
9437
34206dd2
PE
9438 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9439 This is for reasons similar to the recent CHAR_STRING fix.
9440 * charset.c (Fencode_char): Check that character arg is actually
9441 a character. Pass an int to ENCODE_CHAR.
9442 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9443 wider than 'int', as a compile-time check to prevent future regressions
9444 in this area.
9445
c5958d4c 9446 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9447
9448 Make sure a 64-bit char is never passed to CHAR_STRING.
9449 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9450 by silently ignoring the top 32 bits, allowing some values
9451 that were far too large to be valid characters.
9452 * character.h: Include <verify.h>.
9453 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9454 arguments are no wider than unsigned, as a compile-time check
9455 to prevent future regressions in this area.
9456 * data.c (Faset):
01103c44 9457 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9458 (Fsubst_char_in_region):
9459 * fns.c (concat):
9460 * xdisp.c (decode_mode_spec_coding):
9461 Adjust to CHAR_STRING's new requirement.
9462 * editfns.c (Finsert_char, Fsubst_char_in_region):
9463 * fns.c (concat): Check that character args are actually
9464 characters. Without this test, these functions did the wrong
9465 thing with wildly out-of-range values on 64-bit hosts.
9466
d37ca623
PE
9467 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9468 These casts should not be needed on 32-bit hosts, either.
9469 * keyboard.c (read_char):
9470 * lread.c (Fload): Remove casts to unsigned.
9471
ea204efb
PE
9472 * lisp.h (UNSIGNED_CMP): New macro.
9473 This fixes comparison bugs on 64-bit hosts.
9474 (ASCII_CHAR_P): Use it.
9475 * casefiddle.c (casify_object):
01103c44 9476 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9477 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9478 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9479 * dispextern.h (FACE_FROM_ID):
9480 * keyboard.c (read_char): Use UNSIGNED_CMP.
9481
41cb286c
PE
9482 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9483 not to EMACS_INT, to avoid GCC warning.
9484
4a1b9832
PE
9485 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9486
55daad71
PE
9487 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9488 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9489 isn't needed on 32-bit machines.
8f95c75c 9490
01103c44
PE
9491 * buffer.c (Fgenerate_new_buffer_name):
9492 Use EMACS_INT for count, not int.
0ceccced 9493 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9494
9495 * data.c (Qcompiled_function): Now static.
9496
c6f072e7
PE
9497 * window.c (window_body_lines): Now static.
9498
20ce5912
PE
9499 * image.c (gif_load): Rename local to avoid shadowing.
9500
9c4c5f81
PE
9501 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9502 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9503 * alloc.c (make_save_value): Integer argument is now of type
9504 ptrdiff_t, not int.
9505 (mark_object): Use ptrdiff_t, not int.
9506 * lisp.h (pD): New macro.
9507 * print.c (print_object): Use it.
9508
c0c5c8ae
PE
9509 * alloc.c: Use EMACS_INT, not int, to count objects.
9510 (total_conses, total_markers, total_symbols, total_vector_size)
9511 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9512 (total_free_floats, total_floats, total_free_intervals)
9513 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9514 Now EMACS_INT, not int. All uses changed.
9515 (Fgarbage_collect): Compute overall total using a double, so that
9516 integer overflow is less likely to be a problem. Check for overflow
9517 when converting back to an integer.
5a25e253
PE
9518 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9519 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9520 These were 'int' variables that could overflow on 64-bit hosts;
9521 they were never used, so remove them instead of repairing them.
211a0b2a 9522 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9523 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9524 Previously, this ceilinged at INT_MAX, but that doesn't work on
9525 64-bit machines.
e46bb31a 9526 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9527
c78baabf 9528 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9529 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9530 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9531 when a (possibly-narrower) signed value would do just as well.
9532 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9533
c9d624c6
PE
9534 * alloc.c: Catch some string size overflows that we were missing.
9535 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9536 for convenience in STRING_BYTES_MAX.
9537 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9538 The definition here is exact; the one in lisp.h was approximate.
9539 (allocate_string_data): Check for string overflow. This catches
9540 some instances we weren't catching before. Also, it catches
9541 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9542 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9543 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9544
c9d624c6
PE
9545 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9546 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9547 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9548
353032ce
PE
9549 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9550
2bccce07
PE
9551 * alloc.c (Fmake_string): Check for out-of-range init.
9552
0ac30604
SM
95532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9554
9555 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9556
c195f2de
JD
95572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9558
9559 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9560 xg_get_default_scrollbar_width.
9561
9562 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9563 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9564 (style_changed_cb): Call update_theme_scrollbar_width and call
9565 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9566 all frames (Bug#8505).
9567 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9568 Call gtk_window_set_resizable if HAVE_GTK3.
9569 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9570 and height if HAVE_GTK3 (Bug#8505).
9571 (scroll_bar_width_for_theme): New variable.
9572 (update_theme_scrollbar_width): New function.
9573 (xg_get_default_scrollbar_width): Move code to
9574 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9575 (xg_initialize): Call update_theme_scrollbar_width.
9576
9577 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9578
9579 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9580
e10ac9f1
MR
95812011-06-12 Martin Rudalics <rudalics@gmx.at>
9582
9583 * frame.c (make_frame): Call other_buffer_safely instead of
9584 other_buffer.
9585
9586 * window.c (temp_output_buffer_show): Call display_buffer with
9587 second argument Vtemp_buffer_show_specifiers and reset latter
9588 immediately after the call.
9589 (Vtemp_buffer_show_specifiers): New variable.
9590 (auto_window_vscroll_p, next_screen_context_lines)
9591 (Vscroll_preserve_screen_position): Remove leading asterisks from
9592 doc-strings.
9593
2d3c217e 95942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9595
7b7f97e8 9596 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9597 * buffer.c (Qclone_number): Remove for now, as it's unused.
9598 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9599 (record_buffer): Remove unused local.
9600 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9601 (set_frame_buffer_list): Remove; unused.
9602 * frame.h (other_visible_frames): Remove decl.
9603 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9604 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9605 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9606 if HAVE_GPM.
9607 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9608 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9609 Define only if HAVE_GPM.
9610 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9611 (update_hints_inhibit): Remove; never set. All uses removed.
9612 * widgetprv.h (emacsFrameClassRec): Remove decl.
9613 * window.c (delete_deletable_window): Now returns void, since it
9614 wasn't returning anything.
9615 (compare_window_configurations): Remove unused locals.
9616 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9617 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9618 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9619 the same widths as pointers. This follows up on the 2011-05-06 patch.
9620 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9621 * xterm.h: Likewise.
9622 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9623
1384b89e
JB
96242011-06-12 Juanma Barranquero <lekktu@gmail.com>
9625
9626 * makefile.w32-in: Update dependencies.
9627 (LISP_H): Add lib/intprops.h.
9628
1100a63c
CY
96292011-06-11 Chong Yidong <cyd@stupidchicken.com>
9630
9631 * image.c (gif_load): Add animation frame delay to the metadata.
9632 (syms_of_image): Use DEFSYM. New symbol `delay'.
9633
6198ccd0
MR
96342011-06-11 Martin Rudalics <rudalics@gmx.at>
9635
9636 * window.c (delete_deletable_window): Re-add.
9637 (Fset_window_configuration): Rewrite to handle dead buffers and
9638 consequently deletable windows.
9639 (window_tree, Fwindow_tree): Remove. Supply functionality in
9640 window.el.
9641 (compare_window_configurations): Simplify code.
9642
b6e3633c
AS
96432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9644
1ab0dee5
AS
9645 * image.c (imagemagick_load_image): Fix type mismatch.
9646 (Fimagemagick_types): Likewise.
9647
b6e3633c
AS
9648 * window.h (replace_buffer_in_windows): Declare.
9649
9397e56f
MR
96502011-06-11 Martin Rudalics <rudalics@gmx.at>
9651
9652 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9653 Qclone_number. Remove external declaration of Qdelete_window.
9654 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9655 code.
640c8776
SM
9656 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9657 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9658 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9659 buffer list implementation.
9660 (other_buffer_safely): New function.
9661 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9662 calls to replace_buffer_in_windows and
9663 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9664 if allowed.
9665 (record_buffer): Inhibit quitting and rewrite using quittable
9666 functions. Run Qbuffer_list_update_hook if allowed.
9667 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9668 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9669 Move switch-to-buffer to window.el.
9397e56f
MR
9670 (bury-buffer): Move to window.el.
9671 (Vbuffer_list_update_hook): New variable.
9672
9673 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9674 section.
9675
9676 * window.h (resize_frame_windows): Move up in code.
9677 (Fwindow_frame): Remove EXFUN.
9678 (replace_buffer_in_all_windows): Remove prototype.
9679 (replace_buffer_in_windows_safely): Add prototype.
9680
9681 * window.c: Declare Qdelete_window static again. Move down
9682 declaration of select_count.
9683 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9684 (Fother_window): Move to window.el.
9685 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9686 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9687 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9688 window.el.
9689 (replace_buffer_in_windows): Implement by calling
9690 Qreplace_buffer_in_windows.
9691 (replace_buffer_in_all_windows): Remove with some functionality
9692 moved into replace_buffer_in_windows_safely.
9693 (replace_buffer_in_windows_safely): New function.
9694 (select_window_norecord, select_frame_norecord): Move in front
9695 of run_window_configuration_change_hook. Remove now obsolete
9696 declarations.
640c8776
SM
9697 (Fset_window_buffer): Rewrite doc-string.
9698 Call Qrecord_window_buffer.
9397e56f
MR
9699 (keys_of_window): Move binding for other-window to window.el.
9700
b50691aa
CY
97012011-06-11 Chong Yidong <cyd@stupidchicken.com>
9702
9703 * dispextern.h (struct image): Replace data member, whose int_val
9704 and ptr_val fields were not used by anything, with a single
9705 lisp_val object.
9706
9707 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9708 (gif_clear_image, gif_load, imagemagick_load_image)
9709 (gs_clear_image, gs_load): Callers changed.
9710
3f754b86
PE
97112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9712
cca69397
PE
9713 * buffer.h: Include <time.h>, for time_t.
9714 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9715
109e28d0
PE
9716 Fix minor problems found by static checking.
9717
60737f02
PE
9718 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9719
4b66faf3
PE
9720 Make identifiers static if they are not used in other modules.
9721 * data.c (Qcompiled_function, Qframe, Qvector):
9722 * image.c (QimageMagick, Qsvg):
9723 * minibuf.c (Qmetadata):
9724 * window.c (resize_window_check, resize_root_window): Now static.
9725 * window.h (resize_window_check, resize_root_window): Remove decls.
9726
109e28d0
PE
9727 * window.c (window_deletion_count, delete_deletable_window):
9728 Remove; unused.
46a4ce9e
PE
9729 (window_body_lines): Now static.
9730 (Fdelete_other_windows_internal): Mark vars as initialized.
9731 Make sure 'resize_failed' is initialized.
9732 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9733 (resize_window_apply): Remove unused local.
9734 * window.h (delete_deletable_window): Remove decl.
9735
109e28d0 9736 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9737 (imagemagick_load_image): Fix pointer signedness problem by changing
9738 last arg from unsigned char * to char *. All uses changed.
9739 Also, fix a local for similar reasons.
9740 Remove unused locals. Remove locals to avoid shadowing.
9741 (fn_rsvg_handle_free): Remove; unused.
9742 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9743 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9744
3f754b86
PE
9745 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9746
2547adb1
CY
97472011-06-10 Chong Yidong <cyd@stupidchicken.com>
9748
9749 * image.c (gif_load): Fix omitted cast error introduced by
9750 2011-06-06 change.
9751
2c8e37d4
MR
97522011-06-10 Martin Rudalics <rudalics@gmx.at>
9753
9754 * window.h (resize_proportionally, orig_total_lines)
9755 (orig_top_line): Remove from window structure.
9756 (set_window_height, set_window_width, change_window_heights)
9757 (Fdelete_window): Remove prototypes.
9758 (resize_frame_windows): Remove duplicate declaration.
9759
440a42e3
EZ
97602011-06-10 Eli Zaretskii <eliz@gnu.org>
9761
9762 * window.h (resize_frame_windows, resize_window_check)
9763 (delete_deletable_window, resize_root_window)
9764 (resize_frame_windows): Declare prototypes.
9765
9766 * window.c (resize_window_apply): Make definition be "static" to
9767 match the prototype.
9768
562dd5e9
MR
97692011-06-10 Martin Rudalics <rudalics@gmx.at>
9770
9771 * window.c: Remove declarations of Qwindow_size_fixed,
9772 window_min_size_1, window_min_size_2, window_min_size,
9773 size_window, window_fixed_size_p, enlarge_window, delete_window.
9774 Remove static from declaration of Qdelete_window, it's
9775 temporarily needed by Fbury_buffer.
9776 (replace_window): Don't assign orig_top_line and
9777 orig_total_lines.
9778 (Fdelete_window, delete_window): Remove. Window deletion is
9779 handled by window.el.
640c8776
SM
9780 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9781 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9782 (Fdelete_other_windows): Remove. Deleting other windows is
9783 handled by window.el.
9784 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9785 handled in window.el.
9786 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9787 Window minimum sizes are handled in window.el.
9788 (shrink_windows, size_window, set_window_height)
9789 (set_window_width, change_window_heights, window_height)
9790 (window_width, CURBEG, CURSIZE, enlarge_window)
9791 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9792 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9793 handled in window.el.
9794 (make_dummy_parent): Rename to make_parent_window and give it a
9795 second argument horflag.
9796 (make_window): Don't set resize_proportionally any more.
9797 (Fsplit_window): Remove. Windows are split in window.el.
9798 (save_restore_action, save_restore_orig_size)
9799 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9800 Resize mini windows in window.el.
9801 (grow_mini_window, shrink_mini_window): Implement by calling
9802 Qresize_root_window_vertically, resize_window_check and
9803 resize_window_apply.
640c8776
SM
9804 (saved_window, Fset_window_configuration, save_window_save):
9805 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9806 resize_proportionally.
9807 (window_min_height, window_min_width): Move to window.el.
9808 (keys_of_window): Move bindings for delete-other-windows,
9809 split-window, delete-window and enlarge-window to window.el.
9810
9811 * buffer.c: Temporarily extern Qdelete_window.
9812 (Fbury_buffer): Temporarily call Qdelete_window instead of
9813 Fdelete_window (Fbury_buffer will move to window.el soon).
9814
9815 * frame.c (set_menu_bar_lines_1): Remove code handling
9816 orig_top_line and orig_total_lines.
9817
9818 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9819 set_window_height but set heights directly.
9820 (change_frame_size_1): Use resize_frame_windows.
9821
9822 * xdisp.c (init_xdisp): Don't use set_window_height but set
9823 heights directly.
9824
640c8776
SM
9825 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9826 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9827 run_window_configuration_change_hook.
9828
9829 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9830 instead of change_window_heights and run
9831 run_window_configuration_change_hook.
9832
1a13852e
MR
98332011-06-09 Martin Rudalics <rudalics@gmx.at>
9834
9835 * window.c (replace_window): Rename second argument REPLACEMENT to
9836 NEW. New third argument SETFLAG. Rewrite.
9837 (delete_window, make_dummy_parent): Call replace_window with
9838 third argument 1.
9839 (window_list_1): Move down in code.
9840 (run_window_configuration_change_hook): Move set_buffer part
9841 before select_frame_norecord part in order to unwind correctly.
9842 Rename count1 to count.
9843 (recombine_windows, delete_deletable_window, resize_root_window)
9844 (Fdelete_other_windows_internal)
9845 (Frun_window_configuration_change_hook, make_parent_window)
9846 (resize_window_check, resize_window_apply, Fresize_window_apply)
9847 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9848 (Fdelete_window_internal, Fresize_mini_window_internal):
9849 New functions.
1a13852e
MR
9850 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9851
f3d1777e
MR
98522011-06-08 Martin Rudalics <rudalics@gmx.at>
9853
496e208e
MR
9854 * window.h (window): Add some new members to window structure -
9855 normal_lines, normal_cols, new_total, new_normal, clone_number,
9856 splits, nest, prev_buffers, next_buffers.
9857 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9858 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9859
f3d1777e
MR
9860 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9861 Remove.
496e208e
MR
9862 (make_dummy_parent): Set new members of windows structure.
9863 (make_window): Move down in code. Handle new members of window
9864 structure.
9865 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9866 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9867 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9868 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9869 (Fset_window_next_buffers, Fset_window_clone_number):
9870 New functions.
496e208e
MR
9871 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9872 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9873 Doc-string fixes.
9874 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9875 Argument WINDOW can be now internal window too.
9876 (Fwindow_use_time): Move up in code.
9877 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9878 Rewrite doc-string.
9879 (Fset_window_configuration, saved_window)
9880 (Fcurrent_window_configuration, save_window_save): Handle new
9881 members of window structure.
b9e809c2
MR
9882 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9883 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9884 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9885 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9886 Qget_mru_window, Qresize_root_window,
9887 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9888 Qauto_buffer_name; staticpro them.
f3d1777e 9889
abde8f8c
MR
98902011-06-07 Martin Rudalics <rudalics@gmx.at>
9891
9892 * window.c (Fwindow_total_size, Fwindow_left_column)
9893 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9894 (Fwindow_list_1): New functions.
9895 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9896 (Fwindow_width, Fscroll_left, Fscroll_right):
9897 Use window_body_cols instead of window_box_text_cols.
9898 (delete_window, Fset_window_configuration):
9899 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9900 (delete_all_subwindows): Take a window as argument and not a
9901 structure. Rewrite.
190b47e6
MR
9902 (window_loop): Remove handling of GET_LRU_WINDOW and
9903 GET_LARGEST_WINDOW.
9904 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9905
9906 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9907 window_box_text_cols. delete_all_subwindows now takes a
9908 Lisp_Object as argument.
abde8f8c 9909
640c8776
SM
9910 * indent.c (compute_motion, Fcompute_motion):
9911 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9912
fa8a67e6
MR
9913 * frame.c (delete_frame): Call delete_all_subwindows with root
9914 window as argument.
9915
a54e3482
DC
99162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9917
9918 * fns.c (Fputhash): Document return value.
9919
60002bf5
CY
99202011-06-06 Chong Yidong <cyd@stupidchicken.com>
9921
9922 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9923
0c671da6 99242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9925
b862a52a 9926 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9927
be44ca6c
PE
9928 Check for overflow when converting integer to cons and back.
9929 * charset.c (Fdefine_charset_internal, Fdecode_char):
9930 Use cons_to_unsigned to catch overflow.
9931 (Fencode_char): Use INTEGER_TO_CONS.
9932 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9933 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9934 * data.c (long_to_cons, cons_to_long): Remove.
9935 (cons_to_unsigned, cons_to_signed): New functions.
9936 These signal an error for invalid or out-of-range values.
9937 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9938 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9939 * font.c (Ffont_variation_glyphs):
9940 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9941 * lisp.h: Include <intprops.h>.
9942 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9943 (cons_to_signed, cons_to_unsigned): New decls.
9944 (long_to_cons, cons_to_long): Remove decls.
9945 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9946 (Fprimitive_undo): Use CONS_TO_INTEGER.
9947 * xfns.c (Fx_window_property): Likewise.
9948 * xselect.c: Include <limits.h>.
9949 (x_own_selection, selection_data_to_lisp_data):
9950 Use INTEGER_TO_CONS.
9951 (x_handle_selection_request, x_handle_selection_clear)
9952 (x_get_foreign_selection, Fx_disown_selection_internal)
9953 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9954 (lisp_data_to_selection_data): Use cons_to_unsigned.
9955 (x_fill_property_data): Use cons_to_signed.
9956 Report values out of range.
9957
d1f3d2af
PE
9958 Check for buffer and string overflow more precisely.
9959 * buffer.h (BUF_BYTES_MAX): New macro.
9960 * lisp.h (STRING_BYTES_MAX): New macro.
9961 * alloc.c (Fmake_string):
9962 * character.c (string_escape_byte8):
9963 * coding.c (coding_alloc_by_realloc):
9964 * doprnt.c (doprnt):
9965 * editfns.c (Fformat):
9966 * eval.c (verror):
9967 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9968 since they may not be the same number.
9969 * editfns.c (Finsert_char):
9970 * fileio.c (Finsert_file_contents):
9971 Likewise for BUF_BYTES_MAX.
9972
dd52fcea
PE
9973 * image.c: Use ptrdiff_t, not int, for sizes.
9974 (slurp_file): Switch from int to ptrdiff_t.
9975 All uses changed.
9976 (slurp_file): Check that file size fits in both size_t (for
9977 malloc) and ptrdiff_t (for sanity and safety).
9978
7f9bbdbb
PE
9979 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9980 if b->modtime has its maximal value.
9981
dfe18f82
PE
9982 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9983
84acfcf0
PE
9984 Don't assume time_t can fit into int.
9985 * buffer.h (struct buffer.modtime): Now time_t, not int.
9986 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9987 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9988
ccd9a01a
PE
9989 Minor fixes for signed vs unsigned integers.
9990 * character.h (MAYBE_UNIFY_CHAR):
9991 * charset.c (maybe_unify_char):
9992 * keyboard.c (read_char, reorder_modifiers):
9993 XINT -> XFASTINT, since the integer must be nonnegative.
9994 * ftfont.c (ftfont_spec_pattern):
9995 * keymap.c (access_keymap, silly_event_symbol_error):
9996 XUINT -> XFASTINT, since the integer must be nonnegative.
9997 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9998 since it makes no difference and we prefer signed.
9999 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10000 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10001 nonnegative.
10002
d6d100dd
SM
100032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10004
10005 * window.h (Fwindow_frame): Declare.
10006
2b6148e4
PE
100072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10008
10009 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10010 (SPARE_MEMORY): Always define.
10011 (LARGE_REQUEST): Remove.
10012 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10013
f230ecc9
MR
100142011-06-06 Martin Rudalics <rudalics@gmx.at>
10015
727e958e
MR
10016 * lisp.h: Move EXFUNS for Fframe_root_window,
10017 Fframe_first_window and Fset_frame_selected_window to window.h.
10018
10019 * window.h: Move EXFUNS for Fframe_root_window,
10020 Fframe_first_window and Fset_frame_selected_window here from
10021 lisp.h.
10022
10023 * frame.c (Fwindow_frame, Fframe_first_window)
10024 (Fframe_root_window, Fframe_selected_window)
10025 (Fset_frame_selected_window): Move to window.c.
10026 (Factive_minibuffer_window): Move to minibuf.c.
10027 (Fother_visible_frames_p): New function.
10028
10029 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10030
f230ecc9
MR
10031 * window.c (decode_window, decode_any_window): Move up in code.
10032 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10033 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10034 (Fwindow_buffer): Move up and rewrite doc-string.
10035 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10036 (Fwindow_prev): New functions.
727e958e
MR
10037 (Fwindow_frame): Move here from frame.c. Accept any window as
10038 argument.
10039 (Fframe_root_window, Fframe_first_window)
10040 (Fframe_selected_window): Move here from frame.c. Accept frame
10041 or arbitrary window as argument. Update doc-strings.
10042 (Fminibuffer_window): Move up in code.
10043 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10044 (Fset_frame_selected_window): Move here from frame.c.
10045 Marginal rewrite.
727e958e
MR
10046 (Fselected_window, select_window, Fselect_window): Move up in
10047 code. Minor doc-string fixes.
f230ecc9 10048
4d09bcf6
PE
100492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10050
10051 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10052 Do not assume that spare memory exists; that assumption is valid
10053 only if SYSTEM_MALLOC.
10054 (LARGE_REQUEST): New macro, so that the issue of large requests
10055 is separated from the issue of spare memory.
10056
810928a2
AS
100572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10058
172418ad
AS
10059 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10060 format. (Bug#8806)
10061
43f862f7
AS
10062 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10063
810928a2
AS
10064 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10065 before statements.
10066
a059fe24
JD
100672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10068
10069 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10070
10071 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10072
10073 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10074 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10075
989bf368
JB
100762011-06-05 Juanma Barranquero <lekktu@gmail.com>
10077
10078 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10079
4b80f674
CY
100802011-06-04 Chong Yidong <cyd@stupidchicken.com>
10081
10082 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10083 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10084 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10085 New error handlers.
4b80f674
CY
10086 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10087 Obey Vx_select_enable_clipboard_manager. Catch errors in
10088 x_clipboard_manager_save (Bug#8779).
10089 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10090 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10091
99a33b77 100922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10093
10094 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10095
99a33b77 100962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10097
10098 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10099 in the current matrix if keep_current_p is non-zero.
10100
8264569d
EZ
101012011-06-04 Eli Zaretskii <eliz@gnu.org>
10102
10103 * bidi.c (bidi_level_of_next_char): Fix last change.
10104
57f97249
EZ
101052011-06-03 Eli Zaretskii <eliz@gnu.org>
10106
fec2107c 10107 Support bidi reordering of text covered by display properties.
57f97249 10108
fec2107c
EZ
10109 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10110 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10111 (bidi_cache_search, bidi_cache_iterator_state)
10112 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10113 (bidi_level_of_next_char, bidi_move_to_visually_next):
10114 Support character positions inside a run of characters covered by a
fec2107c
EZ
10115 display string.
10116 (bidi_paragraph_init, bidi_resolve_explicit_1)
10117 (bidi_level_of_next_char): Call bidi_fetch_char and
10118 bidi_fetch_char_advance instead of FETCH_CHAR and
10119 FETCH_CHAR_ADVANCE.
10120 (bidi_init_it): Initialize new members.
10121 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10122 definitions.
10123 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10124 instead of using explicit *_CHAR codes.
d6d100dd
SM
10125 (bidi_resolve_explicit, bidi_resolve_weak):
10126 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10127 bidirectional text is supported only in multibyte buffers.
10128 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10129 it to initialize the frame_window_p member of struct bidi_it.
10130 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10131 (bidi_resolve_explicit, bidi_resolve_weak)
10132 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10133 bidi_it->nchars is non-positive.
10134 (bidi_level_of_next_char): Don't try to lookup the cache for the
10135 next/previous character if nothing is cached there yet, or if we
10136 were just reseat()'ed to a new position.
c40e2fb2 10137
0e14fe90
EZ
10138 * xdisp.c (set_cursor_from_row): Set start and stop points
10139 according to the row's direction when priming the loop that looks
10140 for the glyph on which to display cursor.
10141 (single_display_spec_intangible_p): Function deleted.
10142 (display_prop_intangible_p): Reimplement to call
10143 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10144 Accept 3 additional arguments needed by handle_display_spec.
10145 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10146 values: lists, `(when COND...)' forms, etc.
10147 (single_display_spec_string_p): Support property values that are
10148 lists with the argument STRING its top-level element.
10149 (display_prop_string_p): Fix the condition for processing a
10150 property that is a list to be consistent with handle_display_spec.
fec2107c 10151 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10152 last portion of handle_display_prop.
10153 (compute_display_string_pos): Accept additional argument
10154 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10155 value of a `display' property is a "replacing spec".
10156 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10157 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10158 the display property, but just return a value indicating whether
10159 the display property will replace the characters it covers.
10160 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10161 frame_window_p members of struct bidi_it.
d6d100dd
SM
10162 (compute_display_string_pos, compute_display_string_end):
10163 New functions.
fec2107c
EZ
10164 (push_it): Accept second argument POSITION, where pop_it should
10165 jump to continue iteration.
10166 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10167
fec2107c
EZ
10168 * keyboard.c (adjust_point_for_property): Adjust the call to
10169 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10170
10171 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10172 (bidi_init_it): Update prototypes.
10173 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10174 (compute_display_string_pos, compute_display_string_end):
10175 Declare prototypes.
fec2107c
EZ
10176 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10177 EMACS_INT.
fc6f18ce 10178
40087514 101792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10180
57f53182
PE
10181 Malloc failure behavior now depends on size of allocation.
10182 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10183 * lisp.h: Change signatures accordingly.
10184 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10185 All callers changed. (Bug#8762)
10186
10187 * gnutls.c: Use Emacs's memory allocators.
10188 Without this change, the gnutls library would invoke malloc etc.
10189 directly, which causes problems on non-SYNC_INPUT hosts, and which
10190 runs afoul of improving memory_full behavior. (Bug#8761)
10191 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10192 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10193 xfree instead of the default malloc, realloc, free.
10194 (Fgnutls_boot): No need to check for memory allocation failure,
10195 since xmalloc does that for us.
10196
ac32cd99 10197 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10198 * category.c (hash_get_category_set):
10199 * ccl.c (ccl_driver):
10200 * charset.c (Fdefine_charset_internal):
10201 * charset.h (struct charset.hash_index):
10202 * composite.c (get_composition_id, gstring_lookup_cache)
10203 (composition_gstring_put_cache):
10204 * composite.h (struct composition.hash_index):
10205 * dispextern.h (struct image.hash):
10206 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10207 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10208 (hashfn_equal, hashfn_user_defined, make_hash_table)
10209 (maybe_resize_hash_table, hash_lookup, hash_put)
10210 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10211 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10212 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10213 * image.c (make_image, search_image_cache, lookup_image)
10214 (xpm_put_color_table_h):
10215 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10216 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10217 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10218 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10219 * alloc.c (allocate_vectorlike):
10220 Check for overflow in vector size calculations.
10221 * ccl.c (ccl_driver):
10222 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10223 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10224 need to be updated by these changes.
40087514
PE
10225 * fns.c (make_hash_table, maybe_resize_hash_table):
10226 Check for integer overflow with large hash tables.
0de4bb68
PE
10227 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10228 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10229 (SXHASH_REDUCE): New macro.
10230 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10231 Use it instead of discarding useful hash info with large hash values.
10232 (sxhash_float): New function.
10233 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10234 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10235 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10236 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10237 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10238 Adjust signatures to match updated version of code.
10239 (consing_since_gc): Now EMACS_INT, since a single hash table can
10240 use more than INT_MAX bytes.
10241
698d32e2
DN
102422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10243
10244 Make it possible to build with GCC-4.6+ -O2 -flto.
10245
10246 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10247
fd6fa53f
SM
102482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10249
10250 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10251 Call minibuffer-inactive-mode.
10252
864db017
JB
102532011-05-31 Juanma Barranquero <lekktu@gmail.com>
10254
10255 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10256 Update dependencies.
10257
2ad0baf4
DN
102582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10259
10260 * data.c (init_data): Remove code for UTS, this system is not
10261 supported anymore.
10262
4fcc2638
DN
102632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10264
10265 Don't force ./temacs to start in terminal mode.
10266
10267 * frame.c (make_initial_frame): Initialize faces in all cases, not
10268 only when CANNOT_DUMP is defined.
10269 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10270
c56e0fd5
DN
102712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10272
10273 * dispnew.c (add_window_display_history): Use const for the string
10274 pointer. Remove declaration, not needed.
10275
333d54da 102762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10277
55d4c1b2 10278 Use 'inline', not 'INLINE'.
333d54da 10279 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10280 * alloc.c, fontset.c (INLINE): Remove.
10281 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10282 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10283 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10284 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10285 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10286
738db178
DN
102872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10288
10289 Make it possible to run ./temacs.
10290
10291 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10292 syms_of_callproc does the same thing. Remove test for
10293 "initialized", do it in the caller.
10294 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10295
620c53a6
SM
102962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10297
10298 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10299 (read_minibuf): Use get_minibuffer.
10300 (syms_of_minibuf): Use DEFSYM.
10301 (Qmetadata): New var.
10302 * data.c (Qbuffer): Don't make it static.
10303 (syms_of_data): Use DEFSYM.
10304
e003a292
PE
103052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10306
10307 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10308 (CCL_CODE_MIN): New macro.
10309
ed008a6d
PE
103102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10311
3687c2ef
PE
10312 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10313
ed008a6d
PE
10314 * eval.c (Qdebug): Now static.
10315 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10316 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10317 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10318
d66c4c7c
CY
103192011-05-29 Chong Yidong <cyd@stupidchicken.com>
10320
10321 * image.c: Various fixes to ImageMagick code comments.
10322 (Fimagemagick_types): Doc fix.
10323
5fbc2025
PE
103242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10325
0196f88a
PE
10326 Minor fixes prompted by GCC 4.6.0 warnings.
10327
10328 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10329
5fbc2025
PE
10330 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10331 (x_clipboard_manager_save_all): Move extern decl to ...
10332 * xterm.h: ... here, so that it can be checked for consistency.
10333
1dd3c2d9
CY
103342011-05-29 Chong Yidong <cyd@stupidchicken.com>
10335
10336 * xselect.c (x_clipboard_manager_save_frame)
10337 (x_clipboard_manager_save_all): New functions.
10338 (Fx_clipboard_manager_save): Lisp function deleted.
10339
10340 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10341 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10342
10343 * xterm.h: Update prototype.
10344
5ba6571d
WX
103452011-05-28 William Xu <william.xwl@gmail.com>
10346
10347 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10348 exiting (Bug#8239).
10349
3eaff834
JM
103502011-05-28 Jim Meyering <meyering@redhat.com>
10351
e1900994 10352 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10353 * fns.c (to_uchar): Define.
10354 (crypto_hash_function): Use it to convert some newly-signed
10355 variables to unsigned, to avoid sign-extension bugs. For example,
10356 without this change, (md5 "truc") would evaluate to
10357 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10358 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10359 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10360
0f6990a7
PE
103612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10362
10363 Integer overflow fixes.
c8a9ca5a 10364
08686060
PE
10365 * dbusbind.c: Serial number integer overflow fixes.
10366 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10367 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10368 to hold a serial number that is too large for a fixnum.
10369 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10370 Check for serial numbers out of range. Decode any serial number
59568bf0 10371 that was so large that it became a float. (Bug#8722)
08686060 10372
2d1fc3c7
PE
10373 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10374 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10375 Use XFASTINT rather than XUINT when numbers are nonnegative.
10376 (xd_append_arg, Fdbus_method_return_internal):
10377 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10378 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10379 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10380 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10381 (Bug#8722)
2d1fc3c7 10382
c8a9ca5a
PE
10383 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10384
519e1d69
PE
10385 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10386
6df6ae42 10387 ccl: Add integer overflow checks.
30569699
PE
10388 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10389 (IN_INT_RANGE): New macros.
10390 (ccl_driver): Use them to check for integer overflow when
10391 decoding a CCL program. Many of the new checks are whether XINT (x)
10392 fits in int; it doesn't always, on 64-bit hosts. The new version
10393 doesn't catch all possible integer overflows, but it's an
847044ea 10394 improvement. (Bug#8719)
30569699 10395
c11285dc
PE
10396 * alloc.c (make_event_array): Use XINT, not XUINT.
10397 There's no need for unsigned here.
10398
fdccd48e
PE
10399 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10400 This follows up to the 2011-05-06 change that substituted uintptr_t
10401 for EMACS_INT. This case wasn't caught back then.
10402
37910ab2
PE
10403 Rework Fformat to avoid integer overflow issues.
10404 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10405 now (part of C89). Include <verify.h>.
10406 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10407 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10408 (Fformat): Avoid the prepass trying to compute sizes; it was only
10409 approximate and thus did not catch overflow reliably. Instead, walk
10410 through the format just once, formatting and computing sizes as we go,
10411 checking for integer overflow at every step, and allocating a larger
10412 buffer as needed. Keep track separately whether the format is
10413 multibyte. Keep only the most-recently calculated precision, rather
10414 than them all. Record whether each argument has been converted to
10415 string. Use EMACS_INT, not int, for byte and char and arg counts.
10416 Support field widths and precisions larger than INT_MAX. Avoid
10417 sprintf's undefined behavior with conversion specifications such as %#d
10418 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10419 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10420 formatting out-of-range floating point numbers with int
9173deec 10421 formats. (Bug#8668)
37910ab2 10422
2e6578fb
PE
10423 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10424
0ae6bdee
PE
10425 * data.c: Avoid integer truncation in expressions involving floats.
10426 * data.c: Include <intprops.h>.
10427 (arith_driver): When there's an integer overflow in an expression
10428 involving floating point, convert the integers to floating point
10429 so that the resulting value does not suffer from catastrophic
10430 integer truncation. For example, on a 64-bit host (* 4
10431 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10432 Do not rely on undefined behavior after integer overflow.
10433
de883a70
PE
10434 merge count_size_as_multibyte, parse_str_to_multibyte
10435 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10436 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10437 Check for integer overflow.
10438 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10439 since it's now a duplicate of the other. This is more of
10440 a character than a buffer op, so better that it's in character.c.
10441 * fns.c, print.c: Adjust to above changes.
10442
2ff916cb
PE
104432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10444
10445 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10446
f1b54466
PE
104472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10448
fb1ac845
PE
10449 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10450 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10451 (x_clipboard_manager_save): Now static.
10452 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10453
f1b54466
PE
10454 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10455 (crypto_hash_function): Now static.
10456 Fix pointer signedness problems. Avoid unnecessary initializations.
10457
a9f737ee
CY
104582011-05-27 Chong Yidong <cyd@stupidchicken.com>
10459
10460 * termhooks.h (Vselection_alist): Make it terminal-local.
10461
10462 * terminal.c (create_terminal): Initialize it.
10463
10464 * xselect.c: Support for clipboard managers.
10465 (Vselection_alist): Move to termhooks.h as terminal-local var.
10466 (LOCAL_SELECTION): New macro.
10467 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10468 (symbol_to_x_atom): Remove gratuitous arg.
10469 (x_handle_selection_request, lisp_data_to_selection_data)
10470 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10471 (x_own_selection, x_get_local_selection, x_convert_selection):
10472 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10473 (some_frame_on_display): Delete unused function.
10474 (Fx_own_selection_internal, Fx_get_selection_internal)
10475 (Fx_disown_selection_internal, Fx_selection_owner_p)
10476 (Fx_selection_exists_p): New optional frame arg.
10477 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10478 (x_handle_selection_clear): Don't treat other terminals with the
10479 same keyboard specially. Use the terminal-local Vselection_alist.
10480 (x_clear_frame_selections): Use Frun_hook_with_args.
10481
10482 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10483
10484 * xterm.h: Add support for those atoms.
10485
e067f0c1
CY
104862011-05-26 Chong Yidong <cyd@stupidchicken.com>
10487
10488 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10489 (converted_selections, conversion_fail_tag): New global variables.
10490 (x_selection_request_lisp_error): Free the above.
10491 (x_get_local_selection): Remove unnecessary code.
10492 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10493 of converted selections stored in converted_selections.
10494 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10495 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10496 (x_convert_selection): New function.
10497 (x_handle_selection_event): Simplify.
10498 (x_get_foreign_selection): Don't ignore incoming requests while
10499 waiting for an answer; this will fail when we implement
10500 SAVE_TARGETS, and seems unnecessary anyway.
10501 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10502 (Vx_sent_selection_functions): Doc fix.
10503
0f4aebc0
LL
105042011-05-26 Leo Liu <sdl.web@gmail.com>
10505
10506 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10507
e61124cd
YM
105082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10509
10510 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10511
10512 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10513 for fringe update if it has periodic bitmap.
ac389d0c 10514 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10515 and fringe_bitmap_periodic_p.
10516
10517 * fringe.c (get_fringe_bitmap_data): New function.
10518 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10519 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10520 row. Mark glyph row for fringe update if periodicity changed.
10521
10522 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10523 for fringe update unless it has periodic bitmap.
10524
f16d9837
KH
105252011-05-25 Kenichi Handa <handa@m17n.org>
10526
10527 * xdisp.c (get_next_display_element): Set correct it->face_id for
10528 a static composition.
10529
e1b90ef6
LL
105302011-05-24 Leo Liu <sdl.web@gmail.com>
10531
10532 * deps.mk (fns.o):
10533 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10534
10535 * fns.c (crypto_hash_function, Fsha1): New function.
10536 (Fmd5): Use crypto_hash_function.
10537 (syms_of_fns): Add Ssha1.
10538
7400048f
PE
105392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10540
10541 * gnutls.c: Remove unused macros.
10542 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10543 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10544 Remove macros that are defined and never used.
10545 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10546
abb71cf4
CY
105472011-05-22 Chong Yidong <cyd@stupidchicken.com>
10548
10549 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10550 (Fx_get_selection_internal): Minor cleanup.
10551 (Fx_own_selection_internal): Rename arguments for consistency with
10552 select.el.
10553
6307db39
PE
105542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10555
10556 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10557
f3d4e0a4
CY
105582011-05-22 Chong Yidong <cyd@stupidchicken.com>
10559
10560 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10561
4d8ade89
YM
105622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10563
10564 * dispnew.c (scrolling_window): Don't exclude the case that the
10565 last enabled row in the desired matrix touches the bottom boundary.
10566
32078c8d
GM
105672011-05-21 Glenn Morris <rgm@gnu.org>
10568
10569 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10570 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10571 and add some more files.
32078c8d 10572
7285dc67
EZ
105732011-05-20 Eli Zaretskii <eliz@gnu.org>
10574
10575 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10576 report_file_error introduced by the change from 2011-05-07.
10577
89d1bd22
PE
105782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10579
10580 * systime.h (Time): Define only if emacs is defined.
10581 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10582 where the include path doesn't have X11/X.h by default. See
10583 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10584
cd394be1 105852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10586
10587 * composite.c (find_automatic_composition): Fix previous change.
10588
b9704ad9
GM
105892011-05-20 Glenn Morris <rgm@gnu.org>
10590
10591 * lisp.mk: New file, split from Makefile.in.
10592 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10593 (shortlisp): Remove.
10594 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10595
4a720484
GM
105962011-05-19 Glenn Morris <rgm@gnu.org>
10597
10598 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10599 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10600 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10601 (lisp): Set the order to that of loadup.el.
10602 (shortlisp): Make it a copy of $lisp.
10603 (SOME_MACHINE_LISP): Remove.
10604 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10605 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10606
a28d4396
KH
106072011-05-18 Kenichi Handa <handa@m17n.org>
10608
10609 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10610 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10611 (find_automatic_composition): Mostly rewrite for efficiency.
10612
a2b1fa8e
JB
106132011-05-18 Juanma Barranquero <lekktu@gmail.com>
10614
10615 * makefile.w32-in: Update dependencies.
10616
8e1f5610
CS
106172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10618
10619 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10620 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10621
7025ee00 106222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10623
cdfa6eab
PE
10624 Fix some integer overflow issues, such as string length overflow.
10625
06d6db33
PE
10626 * insdel.c (count_size_as_multibyte): Check for string overflow.
10627
2b4560a8
PE
10628 * character.c (lisp_string_width): Check for string overflow.
10629 Use EMACS_INT, not int, for string indexes and lengths; in
10630 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10631 the resulting string length overflows an EMACS_INT; instead,
10632 report a string overflow if no precision given. When checking for
10633 precision exhaustion, use a check that cannot possibly have
10634 integer overflow. (Bug#8675)
10635 * character.h (lisp_string_width): Adjust to new signature.
10636
cb93f9be
PE
10637 * alloc.c (string_overflow): New function.
10638 (Fmake_string): Use it. This doesn't change behavior, but saves
10639 a few bytes and will simplify future changes.
10640 * character.c (string_escape_byte8): Likewise.
10641 * lisp.h (string_overflow): New decl.
10642
1a1f3366
PE
10643 Fixups, following up to the user-interface timestamp change.
10644 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10645 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10646 * msdos.c (mouse_get_pos): Likewise.
10647 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10648 * w32gui.h (Time): Define by including "systime.h" rather than by
10649 declaring it ourselves. (Bug#8664)
10650
d4e3e4d3
PE
10651 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10652 * image.c (clear_image_cache): Likewise.
10653
f6a24d19
PE
10654 * term.c (term_mouse_position): Don't assume time_t wraparound.
10655
08dc5ae6
PE
10656 Be more systematic about user-interface timestamps.
10657 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10658 and sometimes 'EMACS_UINT', to represent these timestamps.
10659 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10660 This makes the code easier to follow, and makes it easier to catch
10661 integer overflow bugs such as Bug#8664.
10662 * frame.c (Fmouse_position, Fmouse_pixel_position):
10663 Use Time, not unsigned long, for user-interface timestamps.
10664 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10665 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10666 * keyboard.h (last_event_timestamp): Likewise.
10667 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10668 * menu.h (xmenu_show): Likewise.
10669 * term.c (term_mouse_position): Likewise.
10670 * termhooks.h (struct input_event.timestamp): Likewise.
10671 (struct terminal.mouse_position_hook): Likewise.
10672 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10673 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10674 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10675 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10676 what it was before.
10677 * menu.h, termhooks.h: Include "systime.h", for Time.
10678
8e55734a
PE
10679 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10680 Don't assume that the difference between two unsigned long values
10681 can fit into an integer. At this point, we know button_down_time
10682 <= event->timestamp, so the difference must be nonnegative, so
10683 there's no need to cast the result if double-click-time is
10684 nonnegative, as it should be; check that it's nonnegative, just in
10685 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10686 apart (about 25 days). (Bug#8664)
8e55734a 10687
841f1b75 10688 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10689 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10690
3e26f69c
PE
10691 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10692 that always fit in int. Use a sentinel instead of a counter, to
10693 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10694 * frame.h (struct frame): Use int for menu_bar_items_used
10695 instead of EMACS_INT, since it always fits in int.
3e26f69c 10696
5cc152c0
PE
10697 * menu.c (grow_menu_items): Check for int overflow.
10698
d89eb65e
PE
10699 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10700
5235bd3e
PE
10701 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10702 Before, the code was not consistent. These values cannot exceed
10703 2**31 - 1 so there's no need to make them unsigned.
10704 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10705 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10706 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10707 as modifiers.
10708 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10709
bc827e23
PE
10710 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10711 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10712 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10713 presumably because the widths might not match.
10714
78eb494e
PE
10715 * window.c (size_window): Avoid needless test at loop start.
10716
04f2d78b
CB
107172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10718
10719 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10720
d2fc7e3d 107212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10722
10723 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10724
d2fc7e3d 107252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10726
10727 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10728 `width' to `bar_area_x' and `bar_area_width', respectively.
10729 (x_scroll_run): Take account of fringe background extension.
10730
04f2d78b
CB
10731 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10732 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10733 `bar_area_width', respectively.
10734 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10735 background extension.
10736
79b70037
GM
107372011-05-10 Jim Meyering <meyering@redhat.com>
10738
10739 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10740
2f142cc5
JB
107412011-05-10 Juanma Barranquero <lekktu@gmail.com>
10742
10743 * image.c (Finit_image_library): Return t for built-in image types,
10744 like pbm and xbm. (Bug#8640)
10745
57679c86
AS
107462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10747
10748 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10749
888c9e86
EZ
107502011-05-07 Eli Zaretskii <eliz@gnu.org>
10751
b0512a1d
EZ
10752 * w32console.c (Fset_screen_color): Doc fix.
10753 (Fget_screen_color): New function.
10754 (syms_of_ntterm): Defsubr it.
10755
7285dc67
EZ
10756 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10757 unlink the temporary file if Fcall_process didn't create it in the
10758 first place.
10759 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10760 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10761 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10762 cue to call_process_cleanup not to close that handle.
10763
4d3fcc8e
BK
107642011-05-07 Ben Key <bkey76@gmail.com>
10765
10766 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10767 one of two shell specific rules, either bootstrap-temacs-CMD or
10768 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10769 to the previous implementation of the bootstrap-temacs rule.
10770 The bootstrap-temacs-CMD rule is similar to the previous
10771 implementation of the bootstrap-temacs rule except that it
10772 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10773 variable.
10774
10775 These changes, along with some changes to nt/configure.bat,
10776 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10777 earlier fix to add support for --cflags and --ldflags options
10778 that include quotes so that it works whether make uses cmd or
10779 sh as the shell.
10780
b4289b64
MA
107812011-05-06 Michael Albinus <michael.albinus@gmx.de>
10782
10783 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10784 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10785 is a constant.
10786 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10787 a string. Handle both cases.
10788 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10789 (Fdbus_register_method): Use Qinvalid_function.
10790
af4c0e28
JB
107912011-05-06 Juanma Barranquero <lekktu@gmail.com>
10792
10793 * makefile.w32-in: Update dependencies.
10794 (LISP_H): Add inttypes.h and stdin.h.
10795 (PROCESS_H): Add unistd.h.
10796
c51453d9
EZ
107972011-05-06 Eli Zaretskii <eliz@gnu.org>
10798
10799 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10800 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10801
8ff0ac3c 108022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10803
4c4b566b
PE
10804 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10805
aab2b9b5
PE
10806 * term.c (vfatal): Remove stray call to va_end.
10807 It's not needed and the C Standard doesn't allow it here anyway.
10808
c378da0b
PE
10809 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10810 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10811
288b08c7
PE
10812 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10813 bytes.
10814
e3601888
PE
10815 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10816
db6c0e74
PE
10817 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10818
dd5963ea
PE
10819 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10820
88c9450f
PE
10821 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10822
2f9442b8
PE
10823 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10824
c032b5f8
PE
10825 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10826 * charset.c (Fdefine_charset_internal): Don't initialize
10827 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10828 32-bit int (Bug#8600).
a108c10b
PE
10829
10830 * lread.c (read_integer): Be more consistent with string-to-number.
10831 Use string_to_number to do the actual conversion; this avoids
10832 rounding errors and fixes some other screwups. Without this fix,
10833 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10834 (digit_to_number): Move earlier, for benefit of read_integer.
10835 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10836 not a digit in any supported base. (Bug#8602)
a108c10b 10837
ad5f9eea
PE
10838 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10839
aec1708a
PE
10840 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10841 to match comment at start of function. This also removes a
10842 GCC warning about overflow in a 32+64-bit port.
10843
47be4ab5
PE
10844 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10845
371cac43
PE
10846 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10847 Reported by Stefan Monnier in
10848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10849 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10850 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10851
d01a7826
PE
10852 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10853 (EMACS_UINTPTR): Likewise, with uintptr_t.
10854
7fd47d5c
PE
10855 * lisp.h: Prefer 64-bit EMACS_INT if available.
10856 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10857 on 32-bit hosts that have 64-bit int, so that they can access
10858 large files.
122b0c86
PE
10859 However, temporarily disable this change unless the temporary
10860 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10861
8727937b
PE
10862 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10863
8ac068ac
PE
10864 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10865 This removes an assumption that EMACS_INT and long are the same
10866 width as pointers. The assumption is true for Emacs porting targets
10867 now, but we want to make other targets possible.
10868 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10869 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10870 In the rest of the code, change types of integers that hold casted
10871 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10872 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10873 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10874 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10875 No need to cast type when ORing.
10876 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10877 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10878 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10879 assume EMACS_INT is the same width as char *.
10880 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10881 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10882 Remove no-longer-needed casts.
10883 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10884 (xg_tool_bar_help_callback, xg_make_tool_item):
10885 Use EMACS_INTPTR to hold an integer
10886 that will be cast to void *; this can avoid a GCC warning
10887 if EMACS_INT is not the same width as void *.
10888 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10889 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10890 (current_message_1, set_message_1):
10891 Use a local to convert to proper width without a cast.
10892 * xmenu.c (dialog_selection_callback): Likewise.
10893
ede49d71
PE
10894 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10895 Also, don't assume VALBITS / RAND_BITS is less than 5,
10896 and don't rely on undefined behavior when shifting a 1 left into
10897 the sign bit.
10898 * lisp.h (get_random): Change signature to match.
10899
2f30ecd0
PE
10900 * lread.c (hash_string): Use size_t, not int, for hash computation.
10901 Normally we prefer signed values; but hashing is special, because
10902 it's better to use unsigned division on hash table sizes so that
10903 the remainder is nonnegative. Also, size_t is the natural width
10904 for hashing into memory. The previous code used 'int', which doesn't
10905 retain enough info to hash well into very large tables.
10906 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10907
2a866e7b
PE
10908 * dbusbind.c: Don't possibly lose pointer info when converting.
10909 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10910 Use XPNTR rather than XHASH, so that the high-order bits of
10911 the pointer aren't lost when converting through void *.
10912
51639eac
PE
10913 * eval.c (Fautoload): Don't double-shift a pointer.
10914
92394119
PE
10915 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10916
dbdb9a7c
JB
109172011-05-06 Juanma Barranquero <lekktu@gmail.com>
10918
10919 * gnutls.c (DEF_GNUTLS_FN):
10920 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10921
db7a0b4f
AS
109222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10923
10924 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10925 marker. (Bug#8610)
10926
cd394be1 109272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10928
10929 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10930 New version that can reserve upto 2GB of heap space.
10931
f7ff1b0f 109322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10933
10934 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10935
639c109b
TZ
109362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10937
10938 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10939 `gnutls_certificate_set_x509_key_file'.
10940
d2127135
JB
109412011-05-05 Juanma Barranquero <lekktu@gmail.com>
10942
10943 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10944 Update dependencies.
10945
e968f4f3
JB
109462011-05-04 Juanma Barranquero <lekktu@gmail.com>
10947
10948 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10949 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10950 Remove unused parameter `fildes'.
10951 * process.c (read_process_output, send_process): Don't pass it.
10952
84d358f0
JB
109532011-05-04 Juanma Barranquero <lekktu@gmail.com>
10954
10955 Fix previous change: the library cache is defined in w32.c.
10956 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10957 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10958
0898ca10
JB
109592011-05-04 Juanma Barranquero <lekktu@gmail.com>
10960
10961 Implement dynamic loading of GnuTLS on Windows.
10962
10963 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10964 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10965 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10966 Declare.
10967
10968 * gnutls.c (Qgnutls_dll): Define.
10969 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10970 (gnutls_*): Declare function pointers.
10971 (init_gnutls_functions): New function to initialize function pointers.
10972 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10973 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10974 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10975 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10976 (emacs_gnutls_write, emacs_gnutls_read)
10977 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10978 (Fgnutls_available_p): New function.
10979 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10980 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10981 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10982
10983 * image.c: Include w32.h.
10984 (Vimage_type_cache): Delete.
10985 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10986 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10987 (w32_delayed_load): Move to w32.c.
10988
10989 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10990
10991 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10992 (w32_delayed_load): Move from image.c. When loading a library, record
10993 its filename in the :loaded-from property of the library id.
10994 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10995 Initialize and staticpro them.
10996 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10997
10998 * process.c: Include lisp.h before w32.h, not after.
10999 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11000 instead of gnutls_record_check_pending.
11001
11002 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11003
ff4de4aa
TZ
110042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11005
11006 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11007 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11008 as passed in.
11009
abe95abb
JD
110102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11011
11012 * xterm.c (x_set_frame_alpha): Do not set property on anything
11013 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11014
e16e55d4
JB
110152011-05-02 Juanma Barranquero <lekktu@gmail.com>
11016
11017 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11018
bafcf6a5
JB
110192011-05-02 Juanma Barranquero <lekktu@gmail.com>
11020
11021 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11022 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11023 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11024 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11025 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11026 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11027 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11028 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11029 (Qgnutls_bootprop_callbacks_verify): Make static.
11030
e7a6747f
AS
110312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11032
19ed11ba
AS
11033 * callproc.c: Indentation fixup.
11034
e7a6747f 11035 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11036 (wait_for_termination, interruptible_wait_for_termination):
11037 Move after wait_for_termination_1.
e7a6747f 11038
1ef14cb4
LMI
110392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11040
11041 * sysdep.c (interruptible_wait_for_termination): New function
11042 which is like wait_for_termination, but allows keyboard
11043 interruptions.
11044
11045 * callproc.c (Fcall_process): Add (:file "file") as an option for
11046 the STDOUT buffer.
11047 (Fcall_process_region): Ditto.
11048
330d880c
EZ
110492011-04-30 Eli Zaretskii <eliz@gnu.org>
11050
8db90b73
EZ
11051 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11052 rather than `XVECTOR (FOO)->size'.
11053
330d880c
EZ
11054 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11055 inttypes.h, as a gnulib replacement is used if it not available in
11056 system headers.
11057
15cbd324
EZ
110582011-04-21 Eli Zaretskii <eliz@gnu.org>
11059
11060 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11061 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11062 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11063
11064 * coding.c (coding_alloc_by_realloc): Error out if destination
11065 will grow beyond MOST_POSITIVE_FIXNUM.
11066 (decode_coding_emacs_mule): Abort if there isn't enough place in
11067 charbuf for the composition carryover bytes. Reserve an extra
11068 space for up to 2 characters produced in a loop.
11069 (decode_coding_iso_2022): Abort if there isn't enough place in
11070 charbuf for the composition carryover bytes.
11071
110722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11073
ae940cca
EZ
11074 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11075 aborting when %lld or %lll format is passed.
11076 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11077 %llo or %llx format is passed. (Bug#8545)
11078
03ab8921
EZ
11079 * window.c (window_scroll_line_based): Use a marker instead of
11080 simple variables to record original value of point. (Bug#7952)
11081
afda1437
EZ
11082 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11083 produced by %s or %c overflows available buffer space. (Bug#8545)
11084
f76dee0c
PE
110852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11086
11087 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11088 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11089
fdc5744d
JB
110902011-04-28 Juanma Barranquero <lekktu@gmail.com>
11091
11092 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11093
638f053a
JB
110942011-04-28 Juanma Barranquero <lekktu@gmail.com>
11095
11096 * keyboard.c (Qdelayed_warnings_hook): Define.
11097 (command_loop_1): Run `delayed-warnings-hook'
11098 if Vdelayed_warnings_list is non-nil.
11099 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11100 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11101
d178f871
EZ
111022011-04-28 Eli Zaretskii <eliz@gnu.org>
11103
11104 * doprnt.c (doprnt): Don't return value smaller than the buffer
11105 size if the message was truncated. (Bug#8545).
11106
b124fd93
JB
111072011-04-28 Juanma Barranquero <lekktu@gmail.com>
11108
11109 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11110 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11111
e810457d
PE
111122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11113
11114 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11115
ea51cceb
JB
111162011-04-27 Juanma Barranquero <lekktu@gmail.com>
11117
11118 * makefile.w32-in: Update dependencies.
11119
94dcfacf
EZ
111202011-04-27 Eli Zaretskii <eliz@gnu.org>
11121
11122 Improve `doprnt' and its usage. (Bug#8545)
11123 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11124 `format_end'. Remove support for %l as a conversion specifier.
11125 Don't use xrealloc. Improve diagnostics when the %l size modifier
11126 is used. Update the commentary.
11127
11128 * eval.c (verror): Simplify calculation of size_t.
11129
11130 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11131 messages.
11132
f61f41d7
PE
111332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11134
11135 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11136 change.
11137
96fb4434
PE
111382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11139
11140 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11141 This makes this file independent of the recent pseudovector change.
11142
671875da 111432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11144
69e9b5a3
PE
11145 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11146
b5f869a7 11147 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11148 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11149 Remove unused local.
c8926152 11150 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11151
841a1577 11152 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11153 GCC 4.6.0 optimizes based on type-based alias analysis.
11154 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11155 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11156 != &v->size, and therefore "v->size = 1; b->size = 2; return
11157 v->size;" must therefore return 1. This assumption is incorrect
11158 for Emacs, since it type-puns struct Lisp_Vector * with many other
11159 types. To fix this problem, this patch adds a new type struct
f904488f 11160 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11161 and pseudovectors, and helps optimizing compilers not get fooled
11162 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11163 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11164 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11165 the size member.
eab3844f
PE
11166 (XSETPVECTYPE): Rewrite in terms of new macro.
11167 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11168 This is a bit clearer, and further avoids the possibility of
11169 undesirable aliasing.
11170 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11171 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11172 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11173 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11174 (ASIZE): Now uses header.size rather than size.
11175 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11176 to avoid the hassle of writing XVECTOR (foo)->header.size.
11177 (struct vectorlike_header): New type.
eab3844f
PE
11178 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11179 object, to help avoid aliasing.
11180 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11181 (SUBRP): Likewise, since Lisp_Subr is a special case.
11182 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11183 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11184 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11185 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11186 changed to be "header.size" and "header.next".
11187 * buffer.h (struct buffer): Likewise.
11188 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11189 * frame.h (struct frame): Likewise.
11190 * process.h (struct Lisp_Process): Likewise.
11191 * termhooks.h (struct terminal): Likewise.
11192 * window.c (struct save_window_data, struct saved_window): Likewise.
11193 * window.h (struct window): Likewise.
11194 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11195 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11196 * buffer.c (init_buffer_once): Likewise.
11197 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11198 special case.
11199 * process.c (Fformat_network_address): Use local var for size,
11200 for brevity.
11201
0df1eac5
PE
11202 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11203
847ab9d1 11204 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11205 * data.c (atof): Remove decl; no longer used or needed.
11206 (digit_to_number): Move to lread.c.
11207 (Fstring_to_number): Use new string_to_number function, to be
11208 consistent with how the Lisp reader treats infinities and NaNs.
11209 Do not assume that floating-point numbers represent EMACS_INT
11210 without losing information; this is not true on most 64-bit hosts.
11211 Avoid double-rounding errors, by insisting on integers when
11212 parsing non-base-10 numbers, as the documentation specifies.
11213 * lisp.h (string_to_number): New decl, replacing ...
11214 (isfloat_string): Remove.
bc0a5c13 11215 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11216 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11217 appears to have been a coding error. Similarly, do not accept
11218 strings like +-1e0 as floating point numbers. Do not report
11219 overflow for integer overflows unless the base is not 10 which
11220 means we have no simple and reliable way to continue.
11221 Break out the floating-point parsing into a new
11222 function string_to_number, so that Fstring_to_number parses
11223 floating point numbers consistently with the Lisp reader.
04f2d78b 11224 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11225 (E_CHAR, EXP_INT): Remove, replacing with ...
11226 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11227 (string_to_number): New function, replacing isfloat_string.
11228 This function checks for valid syntax and produces the resulting
11229 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11230 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11231 so that overflow for non-base-10 numbers is reported only when
11232 there's no portable and simple way to convert to floating point.
452f4150 11233
67769ffc
PE
11234 * textprop.c (set_text_properties_1): Rewrite for clarity,
11235 and to avoid GCC warning about integer overflow.
11236
c20db43f
PE
11237 * intervals.h (struct interval): Use EMACS_INT for members
11238 where EMACS_UINT might cause problems. See
11239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11240 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11241 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11242 All uses changed.
37aa2f85
PE
11243 (offset_intervals): Tell GCC not to worry about length overflow
11244 when negating a negative length.
c20db43f 11245
2538aa2f
PE
11246 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11247 (overrun_check_free): Likewise.
11248
f2d3008d
PE
11249 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11250 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11251 word size.
11252
ec8df744
PE
11253 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11254 (gnutls_make_error): Rename local to avoid shadowing.
11255 (gnutls_emacs_global_deinit): ifdef out; not used.
11256 (Fgnutls_boot): Use const for pointer to readonly storage.
11257 Comment out unused local. Fix pointer signedness problems.
11258
640ee02d
PE
11259 * lread.c (openp): Don't stuff size_t into an 'int'.
11260 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11261 about possible signed overflow.
11262
6048fb2a
PE
11263 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11264 (GDK_KEY_g): Don't define if already defined.
11265 (xg_prepare_tooltip): Avoid pointer signedness problem.
11266 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11267
fa3c87e1
PE
11268 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11269 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11270
2172544b
PE
11271 * xfns.c (Fx_window_property): Simplify a bit,
11272 to make a bit faster and to avoid GCC 4.6.0 warning.
11273 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11274
9b821a21
PE
11275 * fns.c (internal_equal): Don't assume size_t fits in int.
11276
3c616cfa
PE
11277 * alloc.c (compact_small_strings): Tighten assertion a little.
11278
c2982e87
PE
11279 Replace pEd with more-general pI, and fix some printf arg casts.
11280 * lisp.h (pI): New macro, generalizing old pEd macro to other
11281 conversion specifiers. For example, use "...%"pI"d..." rather
11282 than "...%"pEd"...".
11283 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11284 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11285 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11286 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11287 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11288 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11289 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11290 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11291 64-bit hosts.
11292 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11293 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11294 * print.c (safe_debug_print, print_object): Likewise.
11295 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11296 to int.
6f04d126
PE
11297 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11298 avoiding the 0 flag, which is not portable.
c2982e87
PE
11299 * process.c (Fmake_network_process): Use pI to avoid cast.
11300 * region-cache.c (pp_cache): Likewise.
11301 * xdisp.c (decode_mode_spec): Likewise.
11302 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11303 behavior on 64-bit hosts with printf arg.
6f04d126 11304 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11305 (x_stop_queuing_selection_requests): Likewise.
11306 (x_get_window_property): Don't truncate byte count to an 'int'
11307 when tracing.
0b432f21 11308
5e073ec7
PE
11309 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11310 here, since it parses constructs like leading '-' and spaces,
11311 which are not wanted; and it overflows with large numbers.
11312 Instead, simply match F[0-9]+, which is what is wanted anyway.
11313
36372bf9
PE
11314 * alloc.c: Remove unportable assumptions about struct layout.
11315 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11316 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11317 (allocate_vectorlike, make_pure_vector): Use the new macros,
11318 plus offsetof, to remove unportable assumptions about struct layout.
11319 These assumptions hold on all porting targets that I know of, but
11320 they are not guaranteed, they're easy to remove, and removing them
11321 makes further changes easier.
11322
0b432f21
PE
11323 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11324 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11325 (string_overrun_cookie): Now const. Use initializers that
11326 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11327 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11328 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11329 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11330 multiple of sizeof (EMACS_INT); it need not be, if
11331 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11332 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11333
895009e1
JB
113342011-04-26 Juanma Barranquero <lekktu@gmail.com>
11335
11336 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11337
6a7a1b0b
TZ
113382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11339
11340 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11341 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11342 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11343
841a1577 113442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11345
11346 * lisp.h (Qdebug): List symbol.
895009e1 11347 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11348 * keyboard.c (debug-on-event): New variable.
11349 (handle_user_signal): Break into debugger when debug-on-event
11350 matches the current signal symbol.
11351
f2d3ba6f
DN
113522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11353
11354 * alloc.c (check_sblock, check_string_bytes)
11355 (check_string_free_list): Convert to standard C.
11356
42ce4c63
TZ
113572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11358
11359 * w32.c (emacs_gnutls_push): Fix typo.
11360
825cd63c
EZ
113612011-04-25 Eli Zaretskii <eliz@gnu.org>
11362
fb11d64d
EZ
11363 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11364 "cast to pointer from integer of different size".
11365
825cd63c
EZ
11366 Improve doprnt and its use in verror. (Bug#8545)
11367 * doprnt.c (doprnt): Document the set of format control sequences
11368 supported by the function. Use SAFE_ALLOCA instead of always
11369 using `alloca'.
11370
11371 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11372 is one byte too soon. Don't use xrealloc; instead xfree and
11373 xmalloc anew.
11374
e061a11b
TZ
113752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11376
11377 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11378 callbacks stage.
11379
11380 * gnutls.c: Renamed global_initialized to
11381 gnutls_global_initialized. Added internals for the
11382 :verify-hostname-error, :verify-error, and :verify-flags
11383 parameters of `gnutls-boot' and documented those parameters in the
11384 docstring. Start callback support.
9173deec
JB
11385 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11386 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11387 on error. Return error code.
e061a11b
TZ
11388 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11389 (emacs_gnutls_read): Likewise.
11390 (Fgnutls_boot): Return handshake error code.
11391 (emacs_gnutls_handle_error): New function.
11392 (wsaerror_to_errno): Likewise.
11393
11394 * w32.h (emacs_gnutls_pull): Add prototype.
11395 (emacs_gnutls_push): Likewise.
11396
11397 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11398 (emacs_gnutls_push): Likewise.
11399
114002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11401
11402 * process.c (wait_reading_process_output): Check if GnuTLS
11403 buffered some data internally if no FDs are set for TLS
11404 connections.
11405
11406 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11407 (LIBS): Link to USER_LIBS.
11408 ($(BLD)/gnutls.$(0)): New target.
11409
fa6996bc
EZ
114102011-04-24 Eli Zaretskii <eliz@gnu.org>
11411
eb35682e
EZ
11412 * xdisp.c (handle_single_display_spec): Rename the
11413 display_replaced_before_p argument into display_replaced_p, to
11414 make it consistent with the commentary. Fix typos in the
11415 commentary.
11416
e2ad650c
EZ
11417 * textprop.c (syms_of_textprop): Remove dead code.
11418 (copy_text_properties): Delete obsolete commentary about an
11419 interface that was deleted long ago. Fix typos in the description
11420 of arguments.
11421
1b2de274
EZ
11422 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11423 to changes in oldXMenu/XMenu.h from 2011-04-16.
11424 <menu_help_message, prev_menu_help_message>: Constify.
11425 (IT_menu_make_room): menu->help_text is now `const char **';
11426 adjust.
11427
11428 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11429 to changes in oldXMenu/XMenu.h from 2011-04-16.
11430 (struct XMenu): Declare `help_text' `const char **'.
11431
11432 * xfaces.c <Qunspecified>: Make extern again.
11433
11434 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11435 required by POSIX.
1b2de274 11436
762b15be
EZ
11437 * doc.c (get_doc_string): Improve the format passed to `error'.
11438
11439 * doprnt.c (doprnt): Improve commentary.
11440
11441 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11442
11443 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11444 them with etags.
11445
f1052e5d
EZ
11446 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11447 changes in globals.h immediately force recompilation.
762b15be
EZ
11448 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11449 $(CURDIR)/s/ms-w32.h.
11450 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11451
fa6996bc
EZ
11452 * character.c (Fchar_direction): Function deleted.
11453 (syms_of_character): Don't defsubr it.
11454 <char-direction-table>: Deleted.
11455
e6c3da20
EZ
114562011-04-23 Eli Zaretskii <eliz@gnu.org>
11457
11458 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11459 * doprnt.c: Include limits.h.
11460 (SIZE_MAX): New macro.
04f2d78b
CB
11461 (doprnt): Return a size_t value. 2nd arg is now size_t.
11462 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11463 Improve overflow protection. Support `l' modifier for integer
11464 conversions. Support %l conversion. Don't assume an EMACS_INT
11465 argument for integer conversions and for %c.
11466
11467 * lisp.h (doprnt): Restore prototype.
11468
11469 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11470 $(SRC)/character.h.
11471
11472 * Makefile.in (base_obj): Add back doprnt.o.
11473
11474 * deps.mk (doprnt.o): Add back prerequisites.
11475 (callint.o): Depend on character.h.
11476
11477 * eval.c (internal_lisp_condition_case): Include the handler
11478 representation in the error message.
11479 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11480 when breaking from the loop.
11481
11482 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11483
11484 * callint.c (Fcall_interactively): When displaying error message
11485 about invalid control letter, pass the character's codepoint, not
11486 a pointer to its multibyte form. Improve display of the character
11487 in octal and display also its hex code.
11488
11489 * character.c (char_string): Use %x to display the (unsigned)
11490 codepoint of an invalid character, to avoid displaying a bogus
11491 negative value.
11492
11493 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11494 `error', not SYMBOL_NAME itself.
11495
11496 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11497 character arguments to `error'.
11498
11499 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11500 to `error' in error message about FINAL_CHAR argument. Make sure
11501 FINAL_CHAR is a character, and use %c when it is passed as
11502 argument to `error'.
11503
4ffd0d6b 115042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11505
11506 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11507
11508 * w32.c: Include <time.h>.
11509 (sys_localtime): New function.
11510
4ffd0d6b 115112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11512
11513 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11514
4ffd0d6b 11515 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11516
4ffd0d6b 115172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11518
4ffd0d6b
GM
11519 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11520 zombies (Bug#8467).
aac0c6e3 11521
04c56954
EZ
115222011-04-19 Eli Zaretskii <eliz@gnu.org>
11523
11524 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11525 gl_state.e_property when gl_state.object is Qt.
11526
11527 * insdel.c (make_gap_larger): Remove limitation of buffer size
11528 to <= INT_MAX.
11529
16a43933
CY
115302011-04-18 Chong Yidong <cyd@stupidchicken.com>
11531
11532 * xdisp.c (lookup_glyphless_char_display)
11533 (produce_glyphless_glyph): Handle cons cell entry in
11534 glyphless-char-display.
11535 (Vglyphless_char_display): Document it.
11536
11537 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11538 glyphless-char-display.
11539
4581706e
CY
115402011-04-17 Chong Yidong <cyd@stupidchicken.com>
11541
11542 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11543
11544 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11545
11546 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11547 definition for no-X builds.
11548
4887c6e2 115492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11550
fd35b6f9
PE
11551 Static checks with GCC 4.6.0 and non-default toolkits.
11552
5c1ccb01
PE
11553 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11554
006c5daa
PE
11555 * process.c (keyboard_bit_set): Define only if SIGIO.
11556 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11557 (send_process): Repair possible setjmp clobbering.
11558
efc736d3
PE
11559 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11560
4e2fe2e6
PE
11561 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11562
f97334a2
PE
11563 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11564
4e75f29d
PE
11565 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11566 Define only if needed.
11567
90efadd1
PE
11568 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11569 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11570 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11571
3c647824
PE
11572 * dispextern.h (struct redisplay_interface): Rename param
11573 to avoid shadowing.
e264f262 11574 * termhooks.h (struct terminal): Likewise.
761383f4 11575 * xterm.c (xembed_send_message): Likewise.
3c647824 11576
b58c5c4a
PE
11577 * insdel.c (make_gap_smaller): Define only if
11578 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11579
cad59032
PE
11580 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11581 it.
11582
c339dc2e
PE
11583 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11584 so that we aren't warned about unused symbols.
11585
91a3e27b
PE
11586 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11587
399c71d3 11588 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11589
8ffc96f5
PE
11590 * xfns.c (x_real_positions): Mark locals as initialized.
11591
eef9bc79
PE
11592 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11593
098db9dd
PE
11594 * xterm.c: Fix problems found by static analysis with other toolkits.
11595 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11596 (x_dispatch_event): Declare static if USE_GTK, and
11597 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11598 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11599 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11600 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11601 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11602
eb18f6cc
PE
11603 * xmenu.c (menu_help_callback): Pointer type fixes.
11604 Use const pointers when pointing at readonly data. Avoid pointer
11605 signedness clashes.
11606 (FALSE): Remove unused macro.
11607 (update_frame_menubar): Remove unused decl.
11608
1fe72bf8
PE
11609 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11610
60d9e1db
PE
11611 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11612 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11613 (single_menu_item): Rename local to avoid shadowing.
11614
39261c26
PE
11615 * keyboard.c (make_lispy_event): Remove unused local var.
11616
018c5e19
PE
11617 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11618 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11619
63d2b86e
PE
11620 * bitmaps: Change bitmaps from unsigned char back to the X11
11621 compatible char. Avoid the old compiler warnings about
11622 out-of-range initializers by using, for example, '\xab' rather
11623 than 0xab.
11624
aefd87e1
PE
11625 * xgselect.c (xgselect_initialize): Check vs interface
11626 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11627
bf501fb9
PE
11628 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11629
e9829fdf
PE
11630 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11631 to read-only memory.
11632
1086c095
PE
11633 * fns.c (vector): Remove; this old hack is no longer needed.
11634
2baccd04 11635 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11636 Remove unused var.
dde42981 11637 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11638
72391843 11639 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11640
436c16df 11641 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11642 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11643 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11644
92bb796d 11645 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11646 (x_term_init): Remove local to avoid shadowing.
92bb796d 11647
764430a3 11648 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11649
11650 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11651 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11652
d1dfb56c
EZ
116532011-04-16 Eli Zaretskii <eliz@gnu.org>
11654
c4354cb4
EZ
11655 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11656
d1dfb56c
EZ
11657 Fix regex.c, syntax.c and friends for buffers > 2GB.
11658 * syntax.h (struct gl_state_s): Declare character position members
11659 EMACS_INT.
11660
11661 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11662
04f2d78b
CB
11663 * textprop.c (verify_interval_modification, interval_of):
11664 Declare arguments EMACS_INT.
d1dfb56c
EZ
11665
11666 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11667 EMACS_INT.
11668
11669 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11670
11671 * indent.c (Fvertical_motion): Local variable it_start is now
11672 EMACS_INT.
11673
11674 * regex.c (re_match, re_match_2, re_match_2_internal)
11675 (bcmp_translate, regcomp, regexec, print_double_string)
11676 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11677 (re_compile_pattern, re_exec): Declare arguments and local
11678 variables `size_t' and `ssize_t' and return values `regoff_t', as
11679 appropriate.
11680 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11681 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11682 <compile_stack_type>: `size' and `avail' are now `size_t'.
11683
11684 * regex.h <regoff_t>: Use ssize_t, not int.
11685 (re_search, re_search_2, re_match, re_match_2): Arguments that
11686 specify buffer/string position and length are now ssize_t and
11687 size_t. Return type is regoff_t.
11688
613052cd
BK
116892011-04-16 Ben Key <bkey76@gmail.com>
11690
11691 * nsfont.m: Fixed bugs in ns_get_family and
11692 ns_descriptor_to_entity that were caused by using free to
11693 deallocate memory blocks that were allocated by xmalloc (via
11694 xstrdup). This caused Emacs to crash when compiled with
11695 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11696 --enable-checking=xmallocoverrun). xfree is now used to
11697 deallocate these memory blocks.
11698
4170f62f 116992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11700
71b41406
PE
11701 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11702
9587a89d
PE
11703 emacs_write: Accept and return EMACS_INT for sizes.
11704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11705 et seq.
11706 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11707 Accept and return EMACS_INT.
11708 (emacs_gnutls_write): Return the number of bytes written on
11709 partial writes.
11710 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11711 (emacs_read, emacs_write): Remove check for negative size, as the
11712 Emacs source code has been audited now.
9587a89d
PE
11713 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11714 (emacs_read, emacs_write): Use it.
273a5f82
PE
11715 * process.c (send_process): Adjust to the new signatures of
11716 emacs_write and emacs_gnutls_write. Do not attempt to store
11717 a byte offset into an 'int'; it might overflow.
9587a89d 11718 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11719
3e047f51
PE
11720 * sound.c: Don't assume sizes fit in 'int'.
11721 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11722 Return EMACS_INT, not int.
3e047f51 11723 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11724 Accept EMACS_INT, not int.
11725 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11726 record read return values.
11727
cc39a9db
BK
117282011-04-15 Ben Key <bkey76@gmail.com>
11729
c9d0ec6d
JB
11730 * keyboard.c (Qundefined): Don't declare static since it is used
11731 in nsfns.m.
11732 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11733 static since they are used in nsfont.m.
cc39a9db 11734
6c60eb9f
SM
117352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11736
11737 * process.c (Qprocessp): Don't declare static.
11738 * lisp.h (Qprocessp): Declare again.
11739
7990b61a
JB
117402011-04-15 Juanma Barranquero <lekktu@gmail.com>
11741
11742 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11743
5d4cb038
PE
117442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11745
8bd7b830 11746 Improve C-level modularity by making more things 'static'.
cd64ea1d 11747
e3b27b31
PE
11748 Don't publish debugger-only interfaces to other modules.
11749 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11750 (verify_bytepos, count_markers): Move decls to the only modules
11751 that need them.
11752 * region-cache.h (pp_cache): Likewise.
11753 * window.h (check_all_windows): Likewise.
11754 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11755
5d4cb038
PE
11756 * sysdep.c (croak): Now static, if
11757 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11758 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11759
11760 * alloc.c (refill_memory_reserve): Now static if
11761 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11762 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11763
e87b6180
PE
11764 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11765 Define only if USE_LUCID.
11766
ac64929e
PE
11767 * xrdb.c (x_customization_string, x_rm_string): Now static.
11768
6f37259d
PE
11769 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11770 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11771
1683e3ab
PE
11772 * xdisp.c (draw_row_with_mouse_face): Now static.
11773 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11774
de9c2632
PE
11775 * window.h (check_all_windows): Mark externally visible.
11776
2b96acb7
PE
11777 * window.c (window_deletion_count): Now static.
11778
11779 * undo.c: Make symbols static if they're not exported.
11780 (last_undo_buffer, last_boundary_position, pending_boundary):
11781 Now static.
11782
50436f33
PE
11783 * textprop.c (interval_insert_behind_hooks): Now static.
11784 (interval_insert_in_front_hooks): Likewise.
11785
64520e5c
PE
11786 * term.c: Make symbols static if they're not exported.
11787 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11788 (max_frame_lines, tty_set_terminal_modes):
11789 (tty_reset_terminal_modes, tty_turn_off_highlight):
11790 (get_tty_terminal): Now static.
11791 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11792 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11793 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11794 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11795 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11796
1fa53021
PE
11797 * sysdep.c: Make symbols static if they're not exported.
11798 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11799 Now static.
11800 (sigprocmask_set, full_mask): Remove; unused.
11801 (wait_debugging): Mark as visible.
11802 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11803 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11804
d4b43b22
PE
11805 * syntax.c (syntax_temp): Define only if !__GNUC__.
11806
b7c513d0
PE
11807 * sound.c (current_sound_device, current_sound): Now static.
11808
989b29ad
PE
11809 * search.c (searchbufs, searchbuf_head): Now static.
11810
13a55a78
PE
11811 * scroll.c (scroll_cost): Remove; unused.
11812 * dispextern.h (scroll_cost): Remove decl.
11813
de68a1fc
PE
11814 * region-cache.h (pp_cache): Mark as externally visible.
11815
40ccffa6
PE
11816 * process.c: Make symbols static if they're not exported.
11817 (process_tick, update_tick, create_process, chan_process):
11818 (Vprocess_alist, proc_buffered_char, datagram_access):
11819 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11820 (deactivate_process): Mark defn as static, as well as decl.
11821 * lisp.h (create_process): Remove decl.
11822 * process.h (chan_process, Vprocess_alist): Remove decls.
11823
ad64fc97
PE
11824 * print.c: Make symbols static if they're not exported.
11825 (print_depth, new_backquote_output, being_printed, print_buffer):
11826 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11827 (print_interval, print_number_index, initial_stderr_stream):
11828 Now static.
11829 * lisp.h (Fprinc): Remove decl.
11830 (debug_output_compilation_hack): Mark as externally visible.
11831
adddb265
PE
11832 * sysdep.c (croak): Move decl from here to syssignal.h.
11833 * syssignal.h (croak): Put it here, so the API can be checked when
11834 'croak' is called from dissociate_if_controlling_tty.
11835
1717ede2
PE
11836 * minibuf.c: Make symbols static if they're not exported.
11837 (minibuf_save_list, choose_minibuf_frame): Now static.
11838 * lisp.h (choose_minibuf_frame): Remove decl.
11839
fa5fb2bc
PE
11840 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11841
1e3890d1
PE
11842 * lread.c: Make symbols static if they're not exported.
11843 (read_objects, initial_obarray, oblookup_last_bucket_number):
11844 Now static.
11845 (make_symbol): Remove; unused.
11846 * lisp.h (initial_obarray, make_symbol): Remove decls.
11847
8a1414fa
PE
11848 * keyboard.c: Make symbols static if they're not exported.
11849 (single_kboard, recent_keys_index, total_keys, recent_keys):
11850 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11851 (this_single_command_key_start, echoing, last_auto_save):
11852 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11853 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11854 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11855 (Vlispy_mouse_stem, double_click_count):
11856 Now static.
11857 (force_auto_save_soon): Define only if SIGDANGER.
11858 (ignore_mouse_drag_p): Now static if
11859 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11860 (print_help): Remove; unused.
11861 (stop_character, last_timer_event): Mark as externally visible.
11862 * keyboard.h (ignore_mouse_drag_p): Declare only if
11863 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11864 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11865 * lisp.h (echoing): Remove decl.
11866 (force_auto_save_soon): Declare only if SIGDANGER.
11867 * xdisp.c (redisplay_window): Simplify code, to make it more
11868 obvious that ignore_mouse_drag_p is not accessed if !defined
11869 USE_GTK && !defined HAVE_NS.
11870
93ea6e8f
PE
11871 * intervals.c: Make symbols static if they're not exported.
11872 (merge_properties_sticky, merge_interval_right, delete_interval):
11873 Now static.
11874 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11875
77382fcc
PE
11876 * insdel.c: Make symbols static if they're not exported.
11877 However, leave prepare_to_modify_buffer alone. It's never
11878 called from outside this function, but that appears to be a bug.
11879 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11880 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11881 (adjust_after_replace_noundo): Remove; unused.
11882 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11883 (signal_before_change): Remove decls.
77382fcc 11884
9306c32e
PE
11885 * indent.c (val_compute_motion, val_vmotion): Now static.
11886
cd44d2eb
PE
11887 * image.c: Make symbols static if they're not exported.
11888 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11889 if USE_GTK.
11890 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11891 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11892
ad9a7a06
PE
11893 * fringe.c (standard_bitmaps): Now static.
11894 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11895
81626931
PE
11896 * frame.c: Make symbols static if they're not exported.
11897 (x_report_frame_params, make_terminal_frame): Now static.
11898 (get_frame_param): Now static, unless HAVE_NS.
11899 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11900 (x_get_resource_string): Remove; not used.
11901 * frame.h (make_terminal_frame, x_report_frame_params):
11902 (x_get_resource_string); Remove decls.
11903 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11904 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11905
239f9db9
PE
11906 * font.c, fontset.c: Make symbols static if they're not exported.
11907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11908 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11909 * font.c (font_close_object): Now static.
11910 * font.h (font_close_object): Remove.
11911 * fontset.c (FONTSET_OBJLIST): Remove.
11912 (free_realized_fontset) #if-0 the body, which does nothing.
11913 (face_suitable_for_char_p): #if-0, as it's never called.
11914 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11915 * xfaces.c (face_at_string_position):
11916 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11917 since 0 is always ASCII.
11918
dfcf3579
PE
11919 * fns.c (weak_hash_tables): Now static.
11920
5045092b
PE
11921 * fileio.c: Make symbols static if they're not exported.
11922 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11923 (Vwrite_region_annotation_buffers): Now static.
11924
57a96f5c
PE
11925 * eval.c: Make symbols static if they're not exported.
11926 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11927 * lisp.h (backtrace_list): Remove decl.
11928
35f08c38
PE
11929 * emacs.c: Make symbols static if they're not exported.
11930 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11931 (fatal_error_code, fatal_error_signal_hook, standard_args):
11932 Now static.
11933 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11934 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11935 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11936 * lisp.h (fatal_error_signal_hook): Remove decl.
11937 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11938
f44bd759
PE
11939 * editfns.c: Move a (normally-unused) function to its only use.
11940 * editfns.c, lisp.h (get_operating_system_release): Remove.
11941 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11942 worth the hassle of breaking this out.
11943
b532497d
PE
11944 * xterm.c: Make symbols static if they're not exported.
11945 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11946 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11947 (x_destroy_window, x_delete_display):
11948 Now static.
11949 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11950 (x_mouse_leave): Remove; unused.
11951 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11952 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11953 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11954 Remove decls.
11955 (x_mouse_leave): Declare only if WINDOWSNT.
11956 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11957 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11958 USE_X_TOOLKIT.
11959
1675728f
PE
11960 * ftxfont.c: Make symbols static if they're not exported.
11961 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11962 HAVE_FREETYPE.
11963 * font.h (ftxfont_driver): Likewise.
11964
e4cebfca
PE
11965 * xfns.c: Make symbols static if they're not exported.
11966 (x_last_font_name, x_display_info_for_name):
11967 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11968 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11969 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11970 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11971 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11972 (last_show_tip_args): Now static.
11973 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11974 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11975 (x_screen_planes): Remove; unused.
11976 * dispextern.h (x_screen_planes): Remove decl.
11977
5bf46f05
PE
11978 * dispnew.c: Make symbols static if they're not exported.
11979 * dispextern.h (redraw_garbaged_frames, scrolling):
11980 (increment_row_positions): Remove.
11981 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11982 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11983 Now static.
11984 (redraw_garbaged_frames): Remove; unused.
11985
435f4c28
PE
11986 * xfaces.c: Make symbols static if they're not exported.
11987 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11988 Remove decls.
11989 * xterm.h (defined_color): Remove decls.
11990 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11991 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11992 (menu_face_changed_default, defined_color, free_realized_face):
11993 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11994 (ascii_face_of_lisp_face): Remove; unused.
11995
8524aef3
PE
11996 * xdisp.c: Make symbols static if they're not exported.
11997 * dispextern.h (scratch_glyph_row, window_box_edges):
11998 (glyph_to_pixel_coords, set_cursor_from_row):
11999 (get_next_display_element, set_iterator_to_next):
12000 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12001 (show_mouse_face): Remove decls
12002 * frame.h (message_buf_print): Likewise.
12003 * lisp.h (pop_message, set_message, check_point_in_composition):
12004 Likewise.
12005 * xterm.h (set_vertical_scroll_bar): Likewise.
12006 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12007 (message_buf_print, scratch_glyph_row, displayed_buffer):
12008 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12009 (get_next_display_element, show_mouse_face, window_box_edges):
12010 (frame_to_window_pixel_xy, check_point_in_composition):
12011 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12012 (glyph_to_pixel_coords): Remove; unused.
12013
16390cd2
PE
12014 * dired.c (file_name_completion): Now static.
12015
12016 * dbusbind.c (xd_in_read_queued_messages): Now static.
12017
a25f4dfa
PE
12018 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12019 * data.c (circular_list_error): Remove.
12020
14a9c8df
PE
12021 * commands.h (last_point_position, last_point_position_buffer):
12022 (last_point_position_window): Remove decls.
12023 * keyboard.c: Make these variables static.
12024
04f2d78b
CB
12025 * coding.h (coding, code_convert_region, encode_coding_gap):
12026 Remove decls.
74ab6df5
PE
12027 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12028 (iso_code_class, detect_coding, code_convert_region): Now static.
12029 (encode_coding_gap): Remove; unused.
12030
38dfbee1
PE
12031 * chartab.c (chartab_chars, chartab_bits): Now static.
12032
a2cb4e63
PE
12033 * charset.h (charset_iso_8859_1): Remove decl.
12034 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12035 Now static.
12036
127198fd
PE
12037 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12038 * ccl.c (Vccl_program_table): Now static.
12039 (check_ccl_update): Remove; unused.
12040
d85b608f
PE
12041 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12042 * category.h: ... from here.
12043 * category.c (check_category_table, set_category_set): Now static.
12044
31cd66f3
PE
12045 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12046 * lisp.h: Remove these decls.
12047
c358e587
PE
12048 * buffer.c (buffer_count): Remove unused var.
12049
e78aecca
PE
12050 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12051 so that it's not optimized away.
12052 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12053 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12054 exported only to the debugger.
12055
e192d7d3 12056 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12057 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12058
92470028
PE
12059 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12060 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12061 was inaccessible from Lisp.
12062 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12063 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12064
244ed907
PE
12065 alloc.c: Import and export fewer symbols, and remove unused items.
12066 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12067 is defined.
12068 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12069 it's not optimized away by whole-program optimization.
12070 (message_enable_multibyte, free_misc): Remove.
12071 (catchlist, handlerlist, mark_backtrace):
12072 Declare only if BYTE_MARK_STACK.
12073 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12074 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12075 (message_enable_multibyte): Remove decl.
12076 (free_misc, interval_free_list, float_block, float_block_index):
12077 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12078 (cons_free_list, last_marked_index):
12079 Now static.
12080 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12081 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12082 (mark_backtrace): Define only if BYTE_MARK_STACK.
12083 * xdisp.c (message_enable_multibyte): Now static.
12084
61c2b50e 12085 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12086 This makes it easier for human readers (and static analyzers)
12087 to see whether these variables are used from other modules.
12088 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12089 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12090 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12091 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12092 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12093 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12094 * xmenu.c, xselect.c:
12095 Declare Q* vars static if they are not used in other modules.
12096 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12097 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12098 Remove decls of unexported vars.
12099 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12100
95c82688
PE
12101 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12102
16a97296
PE
12103 Make Emacs functions such as Fatom 'static' by default.
12104 This makes it easier for human readers (and static analyzers)
12105 to see whether these functions can be called from other modules.
12106 DEFUN now defines a static function. To make the function external
12107 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12108 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12109 (Finit_image_library):
16a97296
PE
12110 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12111 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12112 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12113 Remove decls, since these functions are now static.
12114 (Funintern, Fget_internal_run_time): New decls, since these functions
12115 were already external.
95c82688 12116
16a97296
PE
12117 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12118 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12119 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12120 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12121 * keyboard.c, keymap.c, lread.c:
12122 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12123 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12124 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12125 Mark functions with DEFUE instead of DEFUN,
12126 if they are used in other modules.
12127 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12128 decls for now-static functions.
12129 * buffer.h (Fdelete_overlay): Remove decl.
12130 * callproc.c (Fgetenv_internal): Mark as internal.
12131 * composite.c (Fremove_list_of_text_properties): Remove decl.
12132 (Fcomposition_get_gstring): New forward static decl.
12133 * composite.h (Fcomposite_get_gstring): Remove decl.
12134 * dired.c (Ffile_attributes): New forward static decl.
12135 * doc.c (Fdocumntation_property): New forward static decl.
12136 * eval.c (Ffetch_bytecode): New forward static decl.
12137 (Funintern): Remove extern decl; now in .h file where it belongs.
12138 * fileio.c (Fmake_symbolic_link): New forward static decl.
12139 * image.c (Finit_image_library): New forward static decl.
12140 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12141 * intervals.h (Fprevious_property_change):
12142 (Fremove_list_of_text_properties): Remove decls.
12143 * keyboard.c (Fthis_command_keys): Remove decl.
12144 (Fcommand_execute): New forward static decl.
12145 * keymap.c (Flookup_key): New forward static decl.
12146 (Fcopy_keymap): Now static.
12147 * keymap.h (Flookup_key): Remove decl.
12148 * process.c (Fget_process): New forward static decl.
12149 (Fprocess_datagram_address): Mark as internal.
12150 * syntax.c (Fsyntax_table_p): New forward static decl.
12151 (skip_chars): Remove duplicate decl.
12152 * textprop.c (Fprevious_property_change): New forward static decl.
12153 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12154 Now internal.
12155 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12156 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12157
785bbd42
PE
12158 * editfns.c (Fformat): Remove unreachable code.
12159
8b913b57
AS
121602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12161
12162 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12163 change. (Bug#8496)
12164
a6744a35
EZ
121652011-04-13 Eli Zaretskii <eliz@gnu.org>
12166
12167 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12168 when at ZV. (Bug#8487)
12169
e7974947
AS
121702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12171
baad03f0
AS
12172 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12173 (Bug#8437)
12174 * keyboard.c (parse_tool_bar_item): Likewise.
12175 * sound.c (sound_cleanup, alsa_close): Likewise.
12176 * termcap.c (tgetent): Likewise.
12177 * xfns.c (x_default_font_parameter): Likewise.
12178 * xsettings.c (read_and_apply_settings): Likewise.
12179
e7974947
AS
12180 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12181 (overrun_check_free): Protoize.
12182
28272684
PE
121832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12184
12185 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12186 since callers should never pass a negative size.
12187 Change the signature to match that of plain 'read' and 'write'; see
12188 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12189 * lisp.h: Update prototypes of emacs_write and emacs_read.
12190
11997c76
EZ
121912011-04-11 Eli Zaretskii <eliz@gnu.org>
12192
12193 * xdisp.c (redisplay_window): Don't try to determine the character
12194 position of the scroll margin if the window start point w->startp
e896f03c 12195 is outside the buffer's accessible region. (Bug#8468)
11997c76 12196
8a2cbd72
EZ
121972011-04-10 Eli Zaretskii <eliz@gnu.org>
12198
12199 Fix write-region and its subroutines for buffers > 2GB.
12200 * fileio.c (a_write, e_write): Modify declaration of arguments and
12201 local variables to support buffers larger than 2GB.
12202 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12203
12204 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12205 argument, local variables, and return value.
12206
12207 * lisp.h: Update prototypes of emacs_write and emacs_read.
12208
12209 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12210
4073e537 122112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12212
1ebfdcb6
PE
12213 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12214
b2ded58d
PE
12215 Fix more problems found by GCC 4.6.0's static checks.
12216
7d66342c
PE
12217 * xdisp.c (vmessage): Use a better test for character truncation.
12218
bbf47d44
PE
12219 * charset.c (load_charset_map): <, not <=, for optimization,
12220 and to avoid potential problems with integer overflow.
9248994d 12221 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12222 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12223 * editfns.c (Fformat): Likewise.
1e69125e 12224 * syntax.c (skip_chars): Likewise.
3befa583 12225
e3019616
PE
12226 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12227 This also lets GCC 4.6.0 generate slightly better loop code.
12228
becfa255
PE
12229 * callint.c (Fcall_interactively): <, not <=, for optimization.
12230 (Fcall_interactively): Count the number of arguments produced,
12231 not the number of arguments given. This is simpler and lets GCC
12232 4.6.0 generate slightly better code.
12233
dae0cd48
PE
12234 * ftfont.c: Distingish more carefully between FcChar8 and char.
12235 The previous code passed unsigned char * to a functions like
12236 strlen and xstrcasecmp that expect char *, which does not
12237 conform to the C standard.
12238 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12239 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12240 char * when the C standard requires it.
12241
76032d70
PE
12242 * keyboard.c (read_char): Remove unused var.
12243
eb3f1cc8
PE
12244 * eval.c: Port to Windows vsnprintf (Bug#8435).
12245 Include <limits.h>.
12246 (SIZE_MAX): Define if the headers do not.
12247 (verror): Do not give up if vsnprintf returns a negative count.
12248 Instead, grow the buffer. This ports to Windows vsnprintf, which
12249 does not conform to C99. Problem reported by Eli Zaretskii.
12250 Also, simplify the allocation scheme, by avoiding the need for
12251 calling realloc, and removing the ALLOCATED variable.
12252
70476b54
PE
12253 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12254
12020a9e
PE
12255 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12256 But keep the doprint source code for now, as we might revamp it
12257 and use it again (Bug#8435).
ea6c7ae6
PE
12258 * lisp.h (doprnt): Remove.
12259 * Makefile.in (base_obj): Remove doprnt.o.
12260 * deps.mk (doprnt.o): Remove.
12261
5fdb398c
PE
12262 error: Print 32- and 64-bit integers portably (Bug#8435).
12263 Without this change, on typical 64-bit hosts error ("...%d...", N)
12264 was used to print both 32- and 64-bit integers N, which relied on
12265 undefined behavior.
61bdb816 12266 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12267 * lisp.h (error, verror): Mark as printf-like functions.
12268 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12269 Report overflow in size calculations when allocating printf buffer.
12270 Do not truncate output string at its first null byte.
12271 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12272 Truncate the output at a character boundary, since vsnprintf does not
12273 do that.
12274 * charset.c (check_iso_charset_parameter): Convert internal
12275 character to string before calling 'error', since %c now has the
12276 printf meaning.
12277 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12278 overflow when computing char to be passed to 'error'. Do not
12279 pass Lisp_Object to 'error'; pass the integer instead.
12280 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12281 formatted with plain %d.
12282
b189fa66
PE
12283 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12284
bff87ef0
PE
12285 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12286
7e2cac20
PE
12287 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12288
ce4d90b5
PE
12289 * xterm.c (x_catch_errors): Remove duplicate declaration.
12290
266c9547
PE
12291 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12292
79c49ad2
PE
12293 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12294
368f4090
JM
122952011-04-10 Jim Meyering <meyering@redhat.com>
12296
12297 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12298 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12299 return ssize_t not "int", and use size_t as the buffer length.
12300 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12301 * gnutls.h: Update declarations.
12302 * process.c (read_process_output): Use ssize_t, to match.
12303 (send_process): Likewise.
12304
a32d4040
CY
123052011-04-09 Chong Yidong <cyd@stupidchicken.com>
12306
12307 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12308
8546720e 123092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12310
04f2d78b
CB
12311 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12312 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12313
8546720e
GM
12314 * xterm.c (handle_one_xevent):
12315 * xmenu.c (create_and_show_popup_menu):
12316 * xselect.c (x_decline_selection_request)
12317 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12318
0a2f5c1a 123192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12320
12321 Fix some uses of `int' instead of EMACS_INT.
12322 * search.c (string_match_1, fast_string_match)
12323 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12324 (scan_buffer, find_next_newline_no_quit)
12325 (find_before_next_newline, search_command, Freplace_match)
12326 (Fmatch_data): Make some `int' variables be EMACS_INT.
12327
12328 * xdisp.c (display_count_lines): 3rd argument and return value now
12329 EMACS_INT. All callers changed.
12330 (pint2hrstr): Last argument is now EMACS_INT.
12331
12332 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12333 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12334 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12335 (decode_coding_utf_16, decode_coding_emacs_mule)
12336 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12337 (decode_coding_ccl, decode_coding_charset)
12338 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12339 (decode_coding_iso_2022, decode_coding_emacs_mule)
12340 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12341 <char_offset, last_offset>: Declare EMACS_INT.
12342 (encode_coding_utf_8, encode_coding_utf_16)
12343 (encode_coding_emacs_mule, encode_invocation_designation)
12344 (encode_designation_at_bol, encode_coding_iso_2022)
12345 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12346 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12347 Declare EMACS_INT.
12348 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12349 (encode_invocation_designation): Last argument P_NCHARS is now
12350 EMACS_INT.
12351 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12352 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12353
12354 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12355 All users changed.
12356
12357 * ccl.c (Fccl_execute_on_string): Declare some variables
12358 EMACS_INT.
12359
8546720e 123602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12361
12362 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12363
4e19a977
CS
123642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12365
12366 * process.c (Fformat_network_address): Doc fix.
12367
87302331
R
123682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12369
ee7683eb 12370 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12371
cbb59342
CY
123722011-04-08 Chong Yidong <cyd@stupidchicken.com>
12373
12374 * keyboard.c (read_char): Call Lisp function help-form-show,
12375 instead of using internal_with_output_to_temp_buffer.
12376 (Qhelp_form_show): New var.
e0d38eeb 12377 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12378
12379 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12380
12381 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12382
e67a13ab
CY
123832011-04-06 Chong Yidong <cyd@stupidchicken.com>
12384
04f2d78b
CB
12385 * process.c (Flist_processes): Remove to Lisp.
12386 (list_processes_1): Delete.
e67a13ab 12387
973f782d
EZ
123882011-04-06 Eli Zaretskii <eliz@gnu.org>
12389
7c106b1e
EZ
12390 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12391
973f782d
EZ
12392 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12393
41cf7d1a 123942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12395
ca23cc88
PE
12396 Fix more problems found by GCC 4.6.0's static checks.
12397
f390e2d5
PE
12398 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12399
42eea0d0
PE
12400 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12401
b69769da 12402 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12403
f9541e84
PE
12404 * xdisp.c (vmessage): Mark as a printf-like function.
12405
13841b55
PE
12406 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12407
c136c10f
PE
12408 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12409
5e2d4a30
PE
12410 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12411 printf-like functions.
12412 (tiff_load): Add casts to remove these marks before passing them
12413 to system-supplied API.
12414
583f48b9
PE
12415 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12416
b25d760e
PE
12417 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12418 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12419 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12420 directly, rather than having caller test rule sign. This avoids
12421 some unnecessary tests.
12422 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12423 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12424 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12425
bc7b6697 12426 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12427 (xfont_open): Avoid unnecessary tests.
bc7b6697 12428
27ccc379
PE
12429 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12430
dcd5c89a
PE
12431 * composite.h, composite.c (composition_gstring_put_cache):
12432 Use EMACS_INT, not int, for length.
12433
b13a45c6
PE
12434 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12435 breaking out part of COMPOSITION_DECODE_RULE.
12436 (COMPOSITION_DECODE_RULE): Use it.
12437 * composite.c (get_composition_id): Remove unused local vars,
12438 by using the new macro.
12439
1e792e4d
PE
12440 * textprop.c (set_text_properties_1): Change while to do-while,
12441 since the condition is always true at first.
12442
dc6c6455 12443 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12444 (interval_deletion_adjustment): Return unsigned value.
12445 All uses changed.
dc6c6455 12446
aba7731a
PE
12447 * process.c (list_processes_1, create_pty, read_process_output):
12448 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12449 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12450 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12451 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12452 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12453
fdfc4bf3
PE
12454 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12455
fca8fe46 12456 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12457 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12458
06a0259a 12459 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12460 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12461 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12462
e7b9e80f
PE
12463 * print.c (print_error_message): Avoid int overflow.
12464
56201685
PE
12465 * font.c (font_list_entities): Redo for clarity,
12466 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12467
78834453 12468 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12469 (font_score): Avoid potential overflow in diff calculation.
78834453 12470
0bc0b309 12471 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12472 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12473
e610eaca
PE
12474 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12475
b895abce
PE
12476 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12477 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12478 can always succeed if overflow has undefined behavior.
12479
1f1d9321 12480 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12481 (wordify): Omit three unnecessary tests.
1f1d9321 12482
c59478bc
PE
12483 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12484 All callers changed. This avoids the need for an unused var.
12485
79b73827
PE
12486 * casefiddle.c (casify_region): Remove var that is set but not used.
12487
a4db5dfe
PE
12488 * dired.c (file_name_completion): Remove var that is set but not used.
12489
43aae36e
PE
12490 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12491
2a47c44d 12492 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12493 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12494
a37c69bf
PE
12495 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12496 Check for integer overflow on size calculations.
12497
328ab8e7
PE
12498 * buffer.c (Fprevious_overlay_change): Remove var that is set
12499 but not used.
12500
e5a2a5cb
PE
12501 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12502 Remove vars that are set but not used.
8d84a6eb 12503 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12504 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12505
a60e5f68
PE
12506 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12507
f661cb61 12508 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12509 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12510
f0397f5a
PE
12511 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12512 that are set but not used.
12513
8664db06 12514 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12515 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12516
6abdaa4a
PE
12517 * xselect.c (x_get_local_selection, x_handle_property_notify):
12518 Remove vars that are set but not used.
12519
0ce7538d 12520 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12521 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12522
9ae848fc
PE
12523 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12524 Remove var that is set but not used.
0b918413
PE
12525 (scroll_bar_windows_size): Now size_t, not int.
12526 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12527 Check for overflow.
9ae848fc 12528
a5a62657
PE
12529 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12530 (map_tty_color) [!defined MSDOS]: Likewise.
12531
5c5cdd39
PE
12532 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12533
66ebf983
PE
12534 * coding.c: Remove vars that are set but not used.
12535 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12536 All callers changed.
12537 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12538 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12539 (decode_coding_charset): Remove vars that are set but not used.
12540
1be4d761
PE
12541 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12542 that is set but not used.
12543
47553fa8
PE
12544 * print.c (print_object): Remove var that is set but not used.
12545
1f7196bf 12546 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12547 The gnulib version avoids calling malloc in the usual case,
12548 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12549 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12550 * filelock.c (current_lock_owner): Likewise.
12551 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12552 * sysdep.c: Include allocator.h, careadlinkat.h.
12553 (emacs_no_realloc_allocator): New static constant.
12554 (emacs_readlink): New function.
fdb61804
PE
12555 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12556 ../lib/careadlinkat.h.
d1fdcab7 12557
f84c17c7
SM
125582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12559
12560 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12561 first non-nil return value).
12562
ef3862ad
JD
125632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12564
12565 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12566 if not defined (Bug#8403).
12567
376a7006
JB
125682011-04-02 Juanma Barranquero <lekktu@gmail.com>
12569
12570 * xdisp.c (display_count_lines): Remove parameter `start',
12571 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12572 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12573 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12574 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12575 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12576 and thereabouts. All callers changed.
12577 (get_per_char_metric): Remove parameter `f', unused since
12578 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12579
6ca3801d
JM
125802011-04-02 Jim Meyering <meyering@redhat.com>
12581
12582 do not dereference NULL upon failed strdup
12583 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12584 (ns_get_family): Likewise.
12585
d8e2b5ba
JB
125862011-04-02 Juanma Barranquero <lekktu@gmail.com>
12587
12588 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12589
8c74fcbd
JD
125902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12591
12592 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12593 later (Bug#8403).
12594
7200d79c
SM
125952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12596
03408648 12597 Add lexical binding.
7200d79c 12598
03408648
SM
12599 * window.c (Ftemp_output_buffer_show): New fun.
12600 (Fsave_window_excursion):
12601 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12602
12603 * lread.c (lisp_file_lexically_bound_p): New function.
12604 (Fload): Bind Qlexical_binding.
12605 (readevalloop): Remove `evalfun' arg.
12606 Bind Qinternal_interpreter_environment.
12607 (Feval_buffer): Bind Qlexical_binding.
12608 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12609 Mark as dynamic.
12610 (syms_of_lread): Declare `lexical-binding'.
12611
12612 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12613
12614 * keyboard.c (eval_dyn): New fun.
12615 (menu_item_eval_property): Use it.
ca105506
SM
12616
12617 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12618
03408648
SM
12619 * fns.c (concat, mapcar1): Accept byte-code-functions.
12620
12621 * eval.c (Fsetq): Handle lexical vars.
12622 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12623 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12624 (FletX, Flet): Obey lexical binding.
12625 (Fcommandp): Handle closures.
12626 (Feval): New `lexical' arg.
12627 (eval_sub): New function extracted from Feval. Use it almost
12628 everywhere where Feval was used. Look up vars in lexical env.
12629 Handle closures.
12630 (Ffunctionp): Move from subr.el.
12631 (Ffuncall): Handle closures.
12632 (apply_lambda): Remove `eval_flags'.
12633 (funcall_lambda): Handle closures and new byte-code-functions.
12634 (Fspecial_variable_p): New function.
12635 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12636 but without exporting it to Lisp.
23aba0ea 12637
23aba0ea 12638 * doc.c (Fdocumentation, store_function_docstring):
03408648 12639 * data.c (Finteractive_form): Handle closures.
23aba0ea 12640
03408648
SM
12641 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12642 interactive spec.
ba83908c 12643
04f2d78b
CB
12644 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12645 New byte-codes.
03408648
SM
12646 (exec_byte_code): New function extracted from Fbyte_code to handle new
12647 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12648
03408648 12649 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12650
03408648 12651 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12652
e2abce01
JB
126532011-03-31 Juanma Barranquero <lekktu@gmail.com>
12654
12655 * xdisp.c (redisplay_internal): Fix prototype.
12656
63696a73 126572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12658
63696a73 12659 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12660 (try_scrolling): Use it when setting scroll_limit.
12661 Limit scrolling to 100 screen lines.
63696a73
EZ
12662 (redisplay_window): Even when falling back on "recentering",
12663 position point in the window according to scroll-conservatively,
12664 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12665
12666 (try_scrolling): When point is above the window, allow searching
12667 as far as scroll_max, or one screenful, to compute vertical
12668 distance from PT to the scroll margin position. This prevents
12669 try_scrolling from unnecessarily failing when
12670 scroll-conservatively is set to a value slightly larger than the
12671 window height. Clean up the case of PT below the margin at bottom
12672 of window: scroll_max can no longer be INT_MAX. When aggressive
12673 scrolling is in use, don't let point enter the opposite scroll
12674 margin as result of the scroll.
12675 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12676 threshold of 100 lines for never-recentering scrolling.
12677
e4cc2dfc
JB
126782011-03-31 Juanma Barranquero <lekktu@gmail.com>
12679
12680 * dispextern.h (move_it_by_lines):
12681 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12682 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12683 (message_log_check_duplicate): Remove parameters `prev_bol' and
12684 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12685 (redisplay_internal): Remove parameter `preserve_echo_area',
12686 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12687
12688 * indent.c (Fvertical_motion):
12689 * window.c (window_scroll_pixel_based, Frecenter):
12690 Don't pass `need_y_p' to `move_it_by_lines'.
12691
1c470562
SM
126922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12693
44f230aa
SM
12694 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12695 steal a few bits to be more compact.
12696 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12697 Remove unneeded casts.
12698
1c470562
SM
12699 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12700
888adce9
ZK
127012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12702
12703 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12704 binding" message (bug#7967).
12705
f838ed7b
PE
127062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12707
77861b95
PE
12708 Fix more problems found by GCC 4.6.0's static checks.
12709
de6dbc14
PE
12710 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12711 Remove unused local var.
12712
f838ed7b
PE
12713 * editfns.c (Fmessage_box): Remove unused local var.
12714
792c7b2b
PE
12715 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12716 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12717 Omit unused local vars.
c499e557 12718 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12719 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12720 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12721 Omit unused local var.
12722
ba0165e1
PE
12723 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12724 Don't assume string length fits in int.
32ad8845 12725 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12726 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12727
3c59b4c9
PE
12728 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12729 instead of alloca (Bug#8344).
12730
a3eed478 12731 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12732 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12733
eb4d412d
PE
12734 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12735
1658b401
PE
12736 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12737 concerns.
12738
12739 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12740
12741 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12742
9a2c6e05
PE
12743 * keyboard.c (syms_of_keyboard): Use the same style as later
12744 in this function when indexing through an array. This also
12745 works around GCC bug 48267.
12746
03d0a109
PE
12747 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12748
44f730c8
PE
12749 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12750
fe75f926
PE
12751 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12752 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12753
ffa8c828
PE
12754 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12755 This avoids undefined behavior on integer overflow, and is a bit
12756 more convenient anyway since it is compared to a size_t variable.
12757
c5101a77
PE
12758 Variadic C functions now count arguments with size_t, not int.
12759 This avoids an unnecessary limitation on 64-bit machines, which
12760 caused (substring ...) to crash on large vectors (Bug#8344).
12761 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12763 All variadic functions and their callers changed accordingly.
c5101a77
PE
12764 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12765 * data.c (arith_driver, float_arith_driver): Likewise.
12766 * editfns.c (general_insert_function): Likewise.
12767 * eval.c (struct backtrace.nargs, interactive_p)
12768 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12769 (funcall_lambda, mark_backtrace): Likewise.
12770 * fns.c (concat): Likewise.
12771 * frame.c (x_set_frame_parameters): Likewise.
12772 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12773 0 if not found, not -1. All callers changed.
12774
dd3f25f7
PE
12775 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12776 (stack_copy_size): Now size_t, not int.
12777 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12778
461c2ab9
JB
127792011-03-28 Juanma Barranquero <lekktu@gmail.com>
12780
12781 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12782 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12783 All callers changed.
12784
12785 * lisp.h (multibyte_char_to_unibyte):
12786 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12787 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12788 * character.h (CHAR_TO_BYTE8):
12789 * cmds.c (internal_self_insert):
12790 * editfns.c (general_insert_function):
12791 * keymap.c (push_key_description):
12792 * search.c (Freplace_match):
12793 * xdisp.c (message_dolog, set_message_1): All callers changed.
12794
f6d62986
SM
127952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12796
12797 * keyboard.c (safe_run_hook_funcall): New function.
12798 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12799 don't set the hook to nil, but remove the offending function instead.
12800 (Qcommand_hook_internal): Remove, unused.
12801 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12802 Vcommand_hook_internal.
12803
12804 * eval.c (enum run_hooks_condition): Remove.
12805 (funcall_nil, funcall_not): New functions.
12806 (run_hook_with_args): Call each function through a `funcall' argument.
12807 Remove `cond' argument, now redundant.
12808 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12809 (Frun_hook_with_args_until_failure): Adjust accordingly.
12810 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12811
1db5b1ad
JB
128122011-03-28 Juanma Barranquero <lekktu@gmail.com>
12813
12814 * dispextern.h (string_buffer_position): Remove declaration.
12815
12816 * print.c (strout): Remove parameter `multibyte', unused since
12817 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12818
12819 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12820 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12821 All callers changed.
12822
12823 * w32.c (_wsa_errlist): Use braces for struct initializers.
12824
12825 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12826 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12827 All callers changed.
12828 (string_buffer_position): Likewise. Also, make static (it's never
12829 used outside xdisp.c).
12830 (cursor_row_p): Remove parameter `w', unused since
12831 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12832 (decode_mode_spec): Remove parameter `precision', introduced during
12833 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12834 All callers changed.
12835
5ffb62aa
JD
128362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12837
12838 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12839
461c2ab9 128402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12841
12842 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12843 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12844 (ns_update_auto_hide_menu_bar): New functions.
12845 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12846 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12847 ns_constrain_all_frames.
12848 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12849 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12850
5c380ffb
JD
128512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12852
12853 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12854
9af30bdf
GM
128552011-03-27 Glenn Morris <rgm@gnu.org>
12856
12857 * syssignal.h: Replace RETSIGTYPE with void.
12858 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12859 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12860 Replace SIGTYPE with void everywhere.
12861 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12862 * s/template.h (SIGTYPE): Remove commented out definition.
12863
e2abce01
JB
128642011-03-26 Eli Zaretskii <eliz@gnu.org>
12865
12866 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12867 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12868
f868cd8a
JB
128692011-03-26 Juanma Barranquero <lekktu@gmail.com>
12870
59eb0929
JB
12871 * w32.c (read_unc_volume): Use parameter `henum', instead of
12872 global variable `wget_enum_handle'.
12873
12874 * keymap.c (describe_vector): Remove parameters `indices' and
12875 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12876 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12877
f868cd8a
JB
12878 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12879
12880 * keyboard.c (timer_check): Remove parameter `do_it_now',
12881 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12882 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12883 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12884
12885 * keyboard.c (read_char):
12886 * w32menu.c (w32_menu_display_help):
12887 * xmenu.c (show_help_event, menu_help_callback):
12888 Adjust calls to `show_help_echo'.
12889
12890 * gtkutil.c (xg_maybe_add_timer):
12891 * keyboard.c (readable_events):
12892 * process.c (wait_reading_process_output):
12893 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12894
12895 * insdel.c (adjust_markers_gap_motion):
12896 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12897 (gap_left, gap_right): Don't call it.
12898
2ecf6fdb
CY
128992011-03-25 Chong Yidong <cyd@stupidchicken.com>
12900
12901 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12902 incurred during fontification.
12903
6b1f9ba4
JB
129042011-03-25 Juanma Barranquero <lekktu@gmail.com>
12905
12906 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12907 (DEFVAR_PER_BUFFER): Don't pass it.
12908
12909 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12910 (scrolling_window): Don't pass it.
12911
0f4a96b5
JB
129122011-03-25 Juanma Barranquero <lekktu@gmail.com>
12913
12914 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12915
12916 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12917 and `suffix'.
12918 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12919 of variables specific to SELinux and computation of `encoded_absname'.
12920
12921 * image.c (XPutPixel): Remove unused variable `height'.
12922
12923 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12924
12925 * unexw32.c (get_section_info): Remove unused variable `section'.
12926
12927 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12928 (system_process_attributes): Remove unused variable `sess'.
12929 (sys_read): Remove unused variable `err'.
12930
12931 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12932 (w32_wnd_proc): Remove unused variable `isdead'.
12933 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12934 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12935 (x_create_tip_frame): Remove unused variable `tem'.
12936
12937 * w32inevt.c (w32_console_read_socket):
12938 Remove unused variable `no_events'.
12939
12940 * w32term.c (x_draw_composite_glyph_string_foreground):
12941 Remove unused variable `width'.
12942
1149507c
JB
129432011-03-24 Juanma Barranquero <lekktu@gmail.com>
12944
12945 * w32term.c (x_set_glyph_string_clipping):
12946 Don't pass uninitialized region to CombineRgn.
12947
9c88f339
JB
129482011-03-23 Juanma Barranquero <lekktu@gmail.com>
12949
12950 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12951 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12952 (Fx_close_connection): Remove unused variable `i'.
12953
12954 * w32font.c (w32font_draw): Return number of glyphs.
12955 (w32font_open_internal): Remove unused variable `i'.
12956 (w32font_driver): Add missing initializer.
12957
12958 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12959 (fill_in_menu): Remove unused variable `items_added'.
12960
12961 * w32term.c (last_mouse_press_frame): Remove static global variable.
12962 (w32_clip_to_row): Remove unused variable `f'.
12963 (x_delete_terminal): Remove unused variable `i'.
12964
12965 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12966 (NOTHING): Remove unused static global variable.
12967 (uniscribe_check_otf): Remove unused variable `table'.
12968 (uniscribe_font_driver): Add missing initializers.
12969
dee091a3
JD
129702011-03-23 Julien Danjou <julien@danjou.info>
12971
12972 * term.c (Fsuspend_tty, Fresume_tty):
12973 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12974 * window.c (temp_output_buffer_show):
12975 * insdel.c (signal_before_change):
12976 * frame.c (Fhandle_switch_frame):
12977 * fileio.c (Fdo_auto_save):
12978 * emacs.c (Fkill_emacs):
12979 * editfns.c (save_excursion_restore):
12980 * cmds.c (internal_self_insert):
12981 * callint.c (Fcall_interactively):
12982 * buffer.c (Fkill_all_local_variables):
12983 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12984 Use Frun_hooks.
0f4a96b5 12985 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12986 unconditionally since it does the check itself.
dee091a3 12987
2c520ab5 129882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12989
c9c49752
PE
12990 Fix more problems found by GCC 4.5.2's static checks.
12991
8abc3f12
PE
12992 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12993 the first time through the loop, since we know p0 < p1 then.
12994 This also avoids a gcc -Wstrict-overflow warning.
12995
a2d26660
PE
12996 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12997 leading to a memory leak, possible in functions like
12998 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12999 of objects (Bug#8318).
a2d26660 13000
916c72e9
PE
13001 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13002 that could (at least in theory) be that large.
13003
19ab8a18
PE
13004 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13005 This is less likely to overflow, and avoids undefined behavior if
13006 overflow does occur. All callers changed. Use strtoul to scan
13007 for the unsigned long integer.
b7cbbd6f
PE
13008 (pint2hrstr): Simplify and tune code slightly.
13009 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13010
f0641eff
PE
13011 * scroll.c (do_scrolling): Work around GCC bug 48228.
13012 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13013
7f650bb9
PE
13014 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13015 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13016 (validate_x_resource_name): Simplify count usage.
13017 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13018
37dd57d1
PE
13019 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13020 fail (Bug#8306).
81e56e61 13021
699979fc 13022 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13023
401bf9b4
PE
13024 * process.c (Fmake_network_process): Use socklen_t, not int,
13025 where POSIX says socklen_t is required in portable programs.
13026 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13027 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13028 (Fmake_network_process, server_accept_connection):
13029 (wait_reading_process_output, read_process_output):
13030 Likewise.
13031
b93aacde
PE
13032 * process.c: Rename or move locals to avoid shadowing.
13033 (list_processes_1, Fmake_network_process):
13034 (read_process_output_error_handler, exec_sentinel_error_handler):
13035 Rename or move locals.
4dc343ee 13036 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13037 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13038 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13039 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13040 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13041
af8a867c 13042 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13043 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13044 Include tparam.h instead, since it declares them.
af8a867c
PE
13045 * cm.h (PC): Remove extern decl; tparam.h now does this.
13046 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13047 * terminfo.c: Include tparam.h, to check interfaces.
13048 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13049 (tparam): Adjust signature to match interface in tparam.h;
13050 this removes some undefined behavior. Check that outstring and len
13051 are zero, which they always are with Emacs.
13052 * tparam.h (PC, BC, UP): New extern decls.
13053
0248044d 13054 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13055 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13056
8ff096c1 13057 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13058 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13059 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13060 (ftfont_list): Remove unused local.
49eaafba
PE
13061 (get_adstyle_property, ftfont_pattern_entity):
13062 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13063 Rename locals to avoid shadowing.
8ff096c1 13064
e2be39f6
PE
13065 * xfont.c (xfont_list_family): Mark var as initialized.
13066
c9735e30
PE
13067 * xml.c (make_dom): Now static.
13068
8f5201ae
PE
13069 * composite.c (composition_compute_stop_pos): Rename local to
13070 avoid shadowing.
b246f932
PE
13071 (composition_reseat_it): Remove unused locals.
13072 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13073 (composition_update_it): Mark var as initialized.
11b61122
PE
13074 (find_automatic_composition): Mark vars as initialized,
13075 with a FIXME (Bug#8290).
8f5201ae 13076
760fbc2c
PE
13077 character.h: Rename locals to avoid shadowing.
13078 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13079 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13080 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13081 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13082 to avoid shadowing.
13083
ff08eb85
PE
13084 * textprop.c (property_change_between_p): Remove; unused.
13085
fc7bf025
PE
13086 * intervals.c (interval_start_pos): Now static.
13087
235d7abc
PE
13088 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13089
44f230aa
SM
13090 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13091 Rename locals to avoid shadowing.
3e7d6594 13092
50060332
PE
13093 * sound.c (wav_play, au_play, Fplay_sound_internal):
13094 Fix pointer signedness.
d01f234b 13095 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13096 (wav_play): Initialize a variable to 0, to prevent undefined
13097 behavior (Bug#8278).
50060332 13098
c4fc4e30
PE
13099 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13100
918436ed
PE
13101 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13102
c939f91b
PE
13103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13104 clobbering (Bug#8298).
b9c7f648
PE
13105 * sysdep.c (sys_subshell): Likewise.
13106 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13107
6bd8c144
PE
13108 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13109 This should get cleaned up, so that child_setup has the
13110 same signature on all platforms.
13111
7710357c 13112 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13113 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13114
c59da222
CY
131152011-03-22 Chong Yidong <cyd@stupidchicken.com>
13116
13117 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13118 not to be necessary, and produces flickering.
13119
66b87493
GM
131202011-03-20 Glenn Morris <rgm@gnu.org>
13121
13122 * config.in: Remove file.
13123
45b6f6d5
JB
131242011-03-20 Juanma Barranquero <lekktu@gmail.com>
13125
13126 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13127 are now in src/globals.h.
13128 (syms_of_minibuf): Remove spurious & from previous change.
13129
cd394be1 131302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13131
13132 * minibuf.c (completing-read-function): New variable.
13133 (completing-read-default): Rename from completing-read.
13134 (completing-read): Call completing-read-function.
13135
b14e3e21
CY
131362011-03-19 Juanma Barranquero <lekktu@gmail.com>
13137
13138 * xfaces.c (Fx_load_color_file):
13139 Read color file from absolute filename (bug#8250).
13140
f2b726e6
JB
131412011-03-19 Juanma Barranquero <lekktu@gmail.com>
13142
13143 * makefile.w32-in: Update dependencies.
13144
09f6ff02
EZ
131452011-03-17 Eli Zaretskii <eliz@gnu.org>
13146
13147 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13148
29a6015a
PE
131492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13150
a3a6c54e
PE
13151 Fix more problems found by GCC 4.5.2's static checks.
13152
b766f867
PE
13153 * process.c (make_serial_process_unwind, send_process_trap):
13154 (sigchld_handler): Now static.
13155
be02381c
PE
13156 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13157 That way, the code declares only the vars that it needs.
13158 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13159 * s/cygwin.h (PTY_ITERATION): Likewise.
13160 * s/darwin.h (PTY_ITERATION): Likewise.
13161 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13162
57048744
PE
13163 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13164 * process.c (allocate_pty): Don't declare stb unless it's needed.
13165
7914961c 13166 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13167 (CONSTANTLIM): Remove; unused.
13168 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13169 Define only if needed.
7914961c 13170
b3967b18
PE
13171 * unexelf.c (unexec): Name an expression,
13172 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13173 Use a different way to cause a compilation error if anyone uses
13174 n rather than nn, a way that does not involve shadowing.
73366a00 13175 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13176
29a6015a
PE
13177 * deps.mk (unexalpha.o): Remove; unused.
13178
43cfc33e 13179 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13180 * unexec.h: New file.
ce701a33
PE
13181 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13182 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13183 Depend on unexec.h.
13184 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13185 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13186 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13187 Change as necessary to match prototype in unexec.h.
ce701a33 13188
01f44d5a
PE
13189 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13190 shadowing.
4f63c6bb 13191 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13192
a6670b0b
PE
13193 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13194 Rename locals to avoid shadowing.
13195
cef2010d 13196 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13197 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13198
d4d7173a
PE
13199 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13200
f08b802a
PE
13201 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13202 warning when compiling print.c.
13203
3ddb0639
PE
13204 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13205 instead of using an uninitialized var.
5ad03b97 13206 (font_sort_entities): Mark var as initialized.
3ddb0639 13207
170a2692
PE
13208 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13209
e663c700
PE
13210 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13211 pointers to constants.
89bc529a 13212 (font_parse_fcname): Remove unused vars.
7b81e2d0 13213 (font_delete_unmatched): Now static.
ea838e10 13214 (font_get_spec): Remove; unused.
13a547c6
PE
13215 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13216 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13217 Rename or move locals to avoid shadowing.
e663c700 13218
2a80c887 13219 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13220 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13221
1384fa33 13222 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13223 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13224
8b2c52e9
PE
13225 * alloc.c (mark_backtrace): Move decl from here ...
13226 * lisp.h: ... to here, so that it can be checked.
13227
475545b5 13228 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13229 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13230 (lisp_indirect_variable): Name an expression,
13231 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13232 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13233
b1349114 13234 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13235 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13236 Use const pointer when appropriate.
b1349114 13237
a2928364
PE
13238 * lisp.h (get_system_name, get_operating_system_release):
13239 Move decls here, to check interfaces.
13240 * process.c (get_operating_system_release): Move decl to lisp.h.
13241 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13242 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13243 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13244 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13245 (Fformat_time_string, Fencode_time, Finsert_char):
13246 (Ftranslate_region_internal, Fformat):
13247 Rename or remove local vars to avoid shadowing.
9710023e 13248 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13249
a415e694
PE
13250 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13251 avoid shadowing.
13252
8ef4622d
PE
13253 * lisp.h (eassert): Check that the argument compiles, even if
13254 ENABLE_CHECKING is not defined.
13255
946f9a5b
PE
13256 * data.c (Findirect_variable): Name an expression, to avoid
13257 gcc -Wbad-function-cast warning.
112396d6 13258 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13259 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13260 (Fmake_variable_buffer_local, Fmake_local_variable):
13261 Mark variables as initialized.
52746918 13262 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13263
e5aab7e7 13264 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13265 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13266 Rename locals to avoid shadowing.
dff45157
PE
13267 (mark_stack): Move local variables into the #ifdef region where
13268 they're used.
7bc26fdb
PE
13269 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13270 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13271 needed otherwise.
13272 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13273 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13274 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13275
e5aab7e7
PE
13276 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13277 avoids undefined behavior in theory.
13278
4da60324
PE
13279 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13280
88043301
PE
13281 Use functions, not macros, for up- and down-casing (Bug#8254).
13282 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13284 to use the following functions instead of these macros.
13285 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13286 EMACS_INT, since callers assume the returned value fits in int.
13287 (upcase1): Likewise, for UPCASE_TABLE.
13288 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13289 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13290 the race-condition problem in the old DOWNCASE.
88043301 13291
19ed5445
PE
13292 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13293 Rename locals to avoid shadowing.
13294 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13295 (regex_compile, re_search_2, re_match_2_internal):
13296 Remove unused local vars.
952db0d7
PE
13297 (FREE_VAR): Rewrite so as not to use empty "else",
13298 which gcc can warn about.
da053e48 13299 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13300 (RETALLOC_IF): Define only if needed.
13301 (WORDCHAR_P): Likewise. This one is never needed, but is used
13302 only in a comment talking about a compiler bug, so put inside
13303 the #if 0 of that comment.
13304 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13305 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13306 Remove; unused.
19ed5445 13307
1f3561e4 13308 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13309 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13310 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13311
ded6f8f7
PE
13312 * search.c (simple_search): Remove unused var.
13313
dbd37a95
PE
13314 * dired.c (compile_pattern): Move decl from here ...
13315 * lisp.h: ... to here, so that it can be checked.
13316 (struct re_registers): New forward decl.
13317
7e47afad
PE
13318 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13319
85f24f61
PE
13320 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13321 All uses changed.
13322 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13323 Rename locals to avoid shadowing.
5671df8f 13324 (Fvertical_motion): Mark locals as initialized.
85f24f61 13325
181aa2be 13326 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13327 (casify_region): Mark local as initialized.
181aa2be 13328
930d429c
PE
13329 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13330
7082eac6
PE
13331 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13332 New macros, so that the caller can use some names other than
13333 gcpro1, gcpro2, etc.
13334 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13335 of the new macros.
13336 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13337 argument, for consistency with GCPRO2_VAR, etc: it is now the
13338 prefix of the variable, not the variable itself. All uses
13339 changed.
38b2c076
PE
13340 * dired.c (directory_files_internal, file_name_completion):
13341 Rename locals to avoid shadowing.
13342
15206ed9
PE
13343 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13344 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13345 dired.c's scmp function, had undefined behavior.
13346 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13348 * buffer.h: ... to here, because these macros use current_buffer,
13349 and the new implementation with inline functions needs to have
13350 current_buffer in scope now, rather than later when the macros
13351 are used.
13352 (downcase, upcase1): New static inline functions.
13353 (DOWNCASE, UPCASE1): Reimplement using these functions.
13354 This avoids undefined behavior in expressions like
13355 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13356 from race conditions in accessing the global variables
13357 case_temp1 and case_temp2.
13358 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13359 * lisp.h (case_temp1, case_temp2): Remove their decls.
13360 * character.h (ASCII_CHAR_P): Move from here ...
13361 * lisp.h: ... to here, so that the inline functions mentioned
13362 above can use them.
13363
4a6bea26
PE
13364 * dired.c (directory_files_internal_unwind): Now static.
13365
f14b7e14
PE
13366 * fileio.c (file_name_as_directory, directory_file_name):
13367 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13368 Now static.
2893f146
PE
13369 (file_name_as_directory): Use const pointers when appropriate.
13370 (Fexpand_file_name): Likewise. In particular, newdir might
13371 point at constant storage, so make it a const pointer.
fd4ead52 13372 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13373 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13374 signedness issues.
f839df0c
PE
13375 (Fset_file_times, Finsert_file_contents, auto_save_error):
13376 Rename locals to avoid shadowing.
f14b7e14 13377
5716756e 13378 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13379 (Ftry_completion, Fall_completions): Rename or remove locals
13380 to avoid shadowing.
5716756e 13381
b4c3046a
PE
13382 * marker.c (bytepos_to_charpos): Remove; unused.
13383
b45db522
PE
13384 * lisp.h (verify_bytepos, count_markers): New decls,
13385 so that gcc does not warn that these functions aren't declared.
13386
85876d07
PE
13387 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13388 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13389 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13390 (copy_text): Remove unused local var.
85876d07 13391
03d78a21 13392 * filelock.c (within_one_second): Now static.
b3dd38ab 13393 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13394
5df8f01b
PE
13395 * buffer.c (fix_overlays_before): Mark locals as initialized.
13396 (fix_start_end_in_overlays): Likewise. This function should be
13397 simplified by using pointers-to-pointers, but that's a different
13398 matter.
b1d876f1 13399 (switch_to_buffer_1): Now static.
8f54f30a
PE
13400 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13401 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13402
a70072c9 13403 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13404 Fix pointer signedness issue.
edced198
PE
13405 (sys_subshell): Mark local as volatile if checking for lint,
13406 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13407 (MAXPATHLEN): Define only if needed.
a70072c9 13408
a0977c44
PE
13409 * process.c (serial_open, serial_configure): Move decls from here ...
13410 * systty.h: ... to here, so that they can be checked.
13411
a884fdcc
PE
13412 * fns.c (get_random, seed_random): Move extern decls from here ...
13413 * lisp.h: ... to here, so that they can be checked.
13414
604efe86 13415 * sysdep.c (reset_io): Now static.
b8950c94 13416 (wait_for_termination_signal): Remove; unused.
604efe86 13417
38fc62d9
PE
13418 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13419 (copy_keymap_item, append_key, push_text_char_description):
13420 Now static.
1004a21a 13421 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13422 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13423 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13424 (describe_map_tree):
13425 Rename locals to avoid shadowing.
38fc62d9 13426
2f2650da
PE
13427 * keyboard.c: Declare functions static if they are not used elsewhere.
13428 (echo_char, echo_dash, cmd_error, top_level_2):
13429 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13430 (read_char, kbd_buffer_get_event, make_lispy_position):
13431 (make_lispy_event, make_lispy_movement, apply_modifiers):
13432 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13433 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13434 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13435 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13436 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13437
a053e86c 13438 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13439 (mark_kboards): Move decl here ...
13440 * alloc.c (mark_kboards): ... from here.
a053e86c 13441
4752793e
PE
13442 * lisp.h (force_auto_save_soon): New decl.
13443
74f10ca7 13444 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13445 (DEFINE_DUMMY_FUNCTION): New macro.
13446 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13447 Use it.
c03cd23f
PE
13448 (main): Add casts to avoid warnings
13449 if GCC considers string literals to be constants.
74f10ca7 13450
022e70d4
PE
13451 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13452
59d6fe83
PE
13453 * dbusbind.c: Pointer signedness fixes.
13454 (xd_signature, xd_append_arg, xd_initialize):
13455 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13457 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13458 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13459
78320123
PE
13460 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13461 if GCC considers string literals to be constants.
49cebcca 13462 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13463
35ac2a97
SM
134642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13465
fb103ca9
SM
13466 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13467 (print_preprocess, print_object): New macro to fix last change.
13468
35ac2a97
SM
13469 * print.c (print_preprocess): Don't forget font objects.
13470
62973b41
JB
134712011-03-16 Juanma Barranquero <lekktu@gmail.com>
13472
13473 * emacs.c (USAGE3): Doc fixes.
13474
0e48bb22
AS
134752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13476
13477 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13478 structure.
13479
7684e57b
JB
134802011-03-14 Juanma Barranquero <lekktu@gmail.com>
13481
13482 * lisp.h (VWindow_system, Qfile_name_history):
13483 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13484 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13485 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13486
13487 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13488 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13489
13490 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13491 * w32console.c (detect_input_pending, read_input_pending)
13492 (encode_terminal_code):
13493 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13494 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13495 (w32_system_caret_y, Qfile_name_history):
13496 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13497 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13498 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13499 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13500 * w32proc.c (Qlocal, report_file_error):
13501 * w32term.c (Vwindow_system, updating_frame):
13502 * w32uniscribe.c (initialized, uniscribe_font_driver):
13503 Remove unneeded extern declarations.
13504
2aa46d6c
CY
135052011-03-14 Chong Yidong <cyd@stupidchicken.com>
13506
c96bbc66 13507 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13508
cffc6f3b
CY
135092011-03-13 Chong Yidong <cyd@stupidchicken.com>
13510
13511 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13512 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13513 These macros can no longer be used for assignment.
13514
44f230aa
SM
13515 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13516 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13517 (record_buffer_markers, fetch_buffer_markers): New functions for
13518 recording and fetching special buffer markers.
13519 (set_buffer_internal_1, set_buffer_temp): Use them.
13520
13521 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13522
13523 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13524
13525 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13526 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13527
13528 * xdisp.c (hscroll_window_tree):
13529 (reconsider_clip_changes): Use PT instead of BUF_PT.
13530
d251f04b
EZ
135312011-03-13 Eli Zaretskii <eliz@gnu.org>
13532
13533 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13534 $(EMACS_ROOT)/lib/intprops.h.
13535
f0c77cd1
PE
135362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13537
3eca4629
PE
13538 Fix more problems found by GCC 4.5.2's static checks.
13539
7c86ee98
PE
13540 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13541 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13542 (xg_free_frame_widgets): Make it clear that a local variable is
13543 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13544 (gdk_window_get_screen): Make it clear that this macro is needed
13545 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13546 (int_gtk_range_get_value): New function, which avoids a diagnostic
13547 from gcc -Wbad-function-cast.
13548 (xg_set_toolkit_scroll_bar_thumb): Use it.
13549 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13550 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13551 (get_utf8_string, xg_get_file_with_chooser):
13552 Rename locals to avoid shadowing.
13553 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13554
41729b81
PE
13555 * xgselect.c (xg_select): Remove unused var.
13556
f0c77cd1
PE
13557 * image.c (four_corners_best): Mark locals as initialized.
13558 (gif_load): Initialize transparent_p to zero (Bug#8238).
13559 Mark another local as initialized.
ec6cf4c6 13560 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13561
ce0ad53d 13562 * image.c (clear_image_cache): Now static.
d5d5a617 13563 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13564 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13565 (x_edge_detection): Remove unnecessary cast that
13566 gcc -Wbad-function-cast diagnoses.
2037898d 13567 (gif_load): Fix pointer signedness.
6ae141d6
PE
13568 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13569 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13570
33383987 135712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13572
d32df629
PE
13573 Improve quality of tests for time stamp overflow.
13574 For example, without this patch (encode-time 0 0 0 1 1
13575 1152921504606846976) returns the obviously-bogus value (-948597
13576 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13577 reports time overflow. See
13578 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13579 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13580 * editfns.c: Include limits.h and intprops.h.
13581 (TIME_T_MIN, TIME_T_MAX): New macros.
13582 (time_overflow): Move earlier, to before first use.
13583 (hi_time, lo_time): New functions, for an accurate test for
13584 out-of-range times.
13585 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13586 (Fget_internal_run_time): Don't assume time_t fits in int.
13587 (make_time): Use list2 instead of Fcons twice.
13588 (Fdecode_time): More accurate test for out-of-range times.
13589 (check_tm_member): New function.
13590 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13591 (lisp_time_argument): Don't rely on undefined left-shift and
13592 right-shift behavior when checking for time stamp overflow.
8be6f318 13593
fe31d94c
PE
13594 * editfns.c (time_overflow): New function, refactoring common code.
13595 (Fformat_time_string, Fdecode_time, Fencode_time):
13596 (Fcurrent_time_string): Use it.
13597
8be6f318
PE
13598 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13599 * dired.c (make_time): Move to ...
13600 * editfns.c (make_time): ... here.
13601 * systime.h: Note the move.
13602
09d9db2c 136032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13604
126bc0dc
YM
13605 * fringe.c (update_window_fringes): Remove unused variables.
13606
c47cbdfd
YM
13607 * unexmacosx.c (copy_data_segment): Also copy __got section.
13608 (Bug#8223)
13609
7ac80be9
EZ
136102011-03-12 Eli Zaretskii <eliz@gnu.org>
13611
c96bbc66 13612 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13613 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13614 Constify `char *' arguments and their references according to
13615 prototypes in tparam.h.
13616
ecb0f94d 13617 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13618
7ac80be9
EZ
13619 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13620 Adapt all references accordingly.
13621
13622 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13623
ef1fd07e
TT
136242011-03-11 Tom Tromey <tromey@redhat.com>
13625
13626 * buffer.c (syms_of_buffer): Remove obsolete comment.
13627
7ef4b50c
EZ
136282011-03-11 Eli Zaretskii <eliz@gnu.org>
13629
13630 * termhooks.h (encode_terminal_code): Declare prototype.
13631
13632 * msdos.c (encode_terminal_code): Don't declare prototype.
13633
13634 * term.c (encode_terminal_code): Now external again, used by
13635 w32console.c and msdos.c.
13636
44f230aa
SM
13637 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13638 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13639
4b1ec863 136402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13641
1714f52b 13642 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13643
4b1ec863
PE
13644 * fringe.c (update_window_fringes): Mark locals as initialized
13645 (Bug#8227).
13646 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13647
524c7aa6
PE
13648 * alloc.c (mark_fringe_data): Move decl from here ...
13649 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13650 to check its interface.
13651 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13652
a5c0af81 13653 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13654 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13655 (fontset_font): Mark local as initialized.
a9a06e0b 13656 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13657
b4716021
PE
13658 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13659
811e9bac 13660 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13661 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13662 (x_own_selection, Fx_disown_selection_internal): Rename locals
13663 to avoid shadowing.
13664 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13665
7e3ab302
PE
13666 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13667 so that the caller can use some name other than gcpro1.
13668 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13669 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13670 (Fx_backspace_delete_keys_p):
13671 Use them to avoid shadowing, and rename vars to avoid shadowing.
13672 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13673 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13674 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13675 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13676 Remove unused locals.
7e3ab302
PE
13677 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13678 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13679 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13680 macros.
f78faa98 13681
e2b13473
PE
13682 * xterm.h (x_mouse_leave): New decl.
13683
77f23912
PE
13684 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13685 Remove unused functions.
cdf4ba58
PE
13686 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13687 (x_calc_absolute_position): Now static.
7411c686 13688 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13689 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13690 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13691 unless they are used.
38d0b34a
PE
13692 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13693 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13694 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13695 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13696 (x_error_catcher, x_connection_closed, x_error_handler):
13697 (x_error_quitter, xembed_send_message, x_iconify_frame):
13698 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13699 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13700 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13701
44f230aa
SM
13702 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13703 Rename or move locals to avoid shadowing.
6b463e58 13704 (tty_defined_color, merge_face_heights): Now static.
5967d051 13705 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13706 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13707 does not deduce is never used uninitialized.
73719eba
PE
13708 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13709 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13710
426994c3 13711 * terminal.c (store_terminal_param): Now static.
5489860b 13712
032f1620 13713 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13714 (set_frame_menubar): Remove unused local.
d4323972 13715 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13716 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13717 since they might point to immutable storage.
281585b0
PE
13718 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13719 since it's unused otherwise.
032f1620 13720
367c19e5 13721 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13722 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13723 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13724 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13725 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13726 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13727 does not deduce are never used uninitialized.
70739cbe 13728
07b48fa9
PE
13729 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13730
8868a238 13731 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13732 * window.c (window_loop, size_window):
13733 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13734
7e5cf297 13735 * window.c (display_buffer): Now static.
d6550a9f
PE
13736 (size_window): Mark variables that gcc -Wuninitialized
13737 does not deduce are never used uninitialized.
a586633d
PE
13738 * window.h (check_all_windows): New decl, to forestall
13739 gcc -Wmissing-prototypes diagnostic.
5b555da1 13740 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13741
f6095868
PE
13742 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13743 shadowing.
13744 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13745 Include <limits.h>.
13746 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13747 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13748 (load_charset_map): Mark variables that gcc -Wuninitialized
13749 does not deduce are never used uninitialized.
53df7c11 13750 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13751
f38b440c
PE
13752 * coding.c (coding_set_source, coding_set_destination):
13753 Use "else { /* comment */ }" rather than "else /* comment */;"
13754 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13755 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13756 a block, when the outer 'i' will do.
13757 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13758 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13759 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13760 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13761 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13762 Rename locals to avoid shadowing.
13763 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13764 * coding.c (emacs_mule_char, encode_invocation_designation):
13765 Now static, since they're not used elsewhere.
413bb2db 13766 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13767 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13768 (decode_coding_emacs_mule): Mark variables that gcc
13769 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13770 (detect_coding_iso_2022): Initialize a local variable that might
13771 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13772 this initialization is needed. (Bug#8211)
5f58e762
PE
13773 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13774 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13775 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13776 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13777 Remove unused macros.
f38b440c 13778
232b38b9 13779 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13780 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13781 * character.c (string_count_byte8): Likewise.
232b38b9 13782
fb90da1b
PE
13783 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13784 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13785
fb93dbc2
PE
13786 * chartab.c (copy_sub_char_table): Now static, since it's not used
13787 elsewhere.
5c156ace
PE
13788 (sub_char_table_ref_and_range, char_table_ref_and_range):
13789 Rename locals to avoid shadowing.
bbcd0949 13790 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13791
7d3b3862 13792 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13793 (BIDI_BOB): Remove unused macro.
7d3b3862 13794
6be7d3da
PE
13795 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13796 deduce are never used uninitialized.
c2ed9c8b 13797 * term.c (encode_terminal_code): Likewise.
6be7d3da 13798
75f8807f 13799 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13800
50938595
PE
13801 * tparam.h: New file.
13802 * term.c, tparam.h: Include it.
13803 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13804 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13805 Move these decls to tparam.h, and make them agree with what
13806 is actually in tparam.c. The previous trick of using incompatible
13807 decls in different modules does not conform to the C standard.
13808 All callers of tparam changed to use tparam's actual API.
13809 * tparam.c (tparam1, tparam, tgoto):
13810 Use const pointers where appropriate.
13811
fbceeba2
PE
13812 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13813 * cm.h (struct cm): Likewise.
13814 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13815 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13816 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13817 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13818 (turn_on_face, init_tty): Likewise.
13819 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13820
7f3f1250
PE
13821 * term.c (term_mouse_position): Rename local to avoid shadowing.
13822
e6ca6543
PE
13823 * alloc.c (mark_ttys): Move decl from here ...
13824 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13825
c40f8d15
AS
138262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13827
13828 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13829
cfe0661d
JB
138302011-03-09 Juanma Barranquero <lekktu@gmail.com>
13831
13832 * search.c (compile_pattern_1): Remove argument regp, unused since
13833 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13834 (compile_pattern): Don't pass it.
13835
0afb4571
J
138362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13837
13838 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13839 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13840 for ! HAVE_GTK3.
13841 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13842
13843 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13844
13845 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13846 gdk_window_get_screen, gdk_window_get_geometry,
13847 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13848 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13849 (xg_get_pixbuf_from_pixmap): New function.
13850 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13851 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13852 Call xg_get_pixbuf_from_pixmap instead of
13853 gdk_pixbuf_get_from_drawable.
13854 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13855 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13856 (xg_check_special_colors): Use GtkStyleContext and its functions
13857 for HAVE_GTK3.
13858 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13859 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13860 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13861 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13862 Call gtk_widget_get_preferred_size.
0afb4571
J
13863 (xg_frame_resized): gdk_window_get_geometry only takes 5
13864 parameters.
44f230aa
SM
13865 (xg_win_to_widget, xg_event_is_for_menubar):
13866 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13867 (xg_set_widget_bg): New function.
13868 (delete_cb): New function.
895009e1 13869 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13870 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13871 (xg_set_background_color): Call xg_set_widget_bg.
13872 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13873 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13874 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13875 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13876 if ! HAVE_GTK3.
13877 (update_frame_tool_bar): Call gtk_widget_hide.
13878 (xg_initialize): Use GDK_KEY_g.
13879
13880 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13881 if ! HAVE_GTK3
13882 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13883
13884 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13885 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13886 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13887
1c2cc4ef
JB
138882011-03-08 Juanma Barranquero <lekktu@gmail.com>
13889
13890 * w32xfns.c (select_palette): Check success of RealizePalette against
13891 GDI_ERROR, not zero.
13892
33383987 13893See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13894
13895;; Local Variables:
13896;; coding: utf-8
aac0c6e3
MR
13897;; End:
13898
2f097256 13899 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13900
13901 This file is part of GNU Emacs.
13902
13903 GNU Emacs is free software: you can redistribute it and/or modify
13904 it under the terms of the GNU General Public License as published by
13905 the Free Software Foundation, either version 3 of the License, or
13906 (at your option) any later version.
13907
13908 GNU Emacs is distributed in the hope that it will be useful,
13909 but WITHOUT ANY WARRANTY; without even the implied warranty of
13910 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13911 GNU General Public License for more details.
13912
13913 You should have received a copy of the GNU General Public License
13914 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.