* lisp/info.el (Info-mode-syntax-table): New variable.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
56cd55c8
EZ
12011-09-18 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (display_line): Record maximum and minimum buffer
4 positions even if no glyphs were produced (e.g., by a zero-width
5 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6 buffer positions that will be removed from the glyph row because
7 they don't fit.
c02dcedf
EZ
8 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9 column is beyond frame width: don't subtract 1 "pixel" when
10 computing width of the stretch.
3e62b7e0
EZ
11 (reseat_at_next_visible_line_start): Undo the change made on
12 2011-09-17 that saved paragraph information and restored it after
13 the call to `reseat'. (Bug#9545)
56cd55c8 14
5ed99d36 152011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
16
17 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
18 and turn window cursor on if cleared (Bug#9415).
19
5ed99d36 202011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
21
22 * search.c (boyer_moore): Take unibyte characters from pattern
23 literally. (Bug#9458)
24
9bade7b2
EZ
252011-09-18 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
28
e5e9d610
PE
292011-09-18 Paul Eggert <eggert@cs.ucla.edu>
30
87e4427a
PE
31 Fix minor problem found by static checking.
32 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
33 initialized, to pacify gcc -Wuninitialized.
34
e5e9d610
PE
35 * fileio.c: Report proper errno when syscall falls.
36 (Finsert_file_contents): Save and restore errno,
37 so that report_file_error outputs the correct diagnostic.
38 (Fwrite_region) [CLASH_DETECTION]: Likewise.
39
a1674f0b
EZ
402011-09-18 Eli Zaretskii <eliz@gnu.org>
41
42 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
43
fbfb6dd4
EZ
442011-09-17 Eli Zaretskii <eliz@gnu.org>
45
46 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
47 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
48
bb187662
EZ
492011-09-17 Eli Zaretskii <eliz@gnu.org>
50
1137e8b8
EZ
51 * xdisp.c (reseat_at_next_visible_line_start): Keep information
52 about the current paragraph and restore it after the call to
53 reseat.
54
55 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
56 (bidi_find_paragraph_start): Search back for paragraph beginning
57 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
58 (bidi_move_to_visually_next): Only trigger paragraph-related
59 computations when the last character is a newline or at EOB, not
60 just any NEUTRAL_B. (Bug#9470)
61
bb187662
EZ
62 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
63 truncated lines if point is covered by a display string. (Bug#9524)
64
2e621251
PE
652011-09-16 Paul Eggert <eggert@cs.ucla.edu>
66
67 * xselect.c: Relax test for outgoing X longs (Bug#9498).
68 (cons_to_x_long): New function.
69 (lisp_data_to_selection_data): Use it. Correct the test for
70 short-versus-long data; it was negated. Break out of vector
71 loop, for efficiency, when a long datum is discovered.
72
91a15bc6
SM
732011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
74
75 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
76
b41c3a35
EZ
772011-09-16 Eli Zaretskii <eliz@gnu.org>
78
79 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
80 GCC PR/17406) by declaring this function with external scope.
81
7812ba2d
PE
822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
83
84 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
85 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
86
cf7edc2a
AS
872011-09-15 Andreas Schwab <schwab@linux-m68k.org>
88
89 * editfns.c (Fformat): Correctly handle text properties on "%%".
90
bd01620e
EZ
912011-09-15 Eli Zaretskii <eliz@gnu.org>
92
93 * xterm.c (x_draw_composite_glyph_string_foreground):
94 * w32term.c (x_draw_composite_glyph_string_foreground):
95 * term.c (encode_terminal_code):
96 * composite.c (composition_update_it, get_composition_id):
97 * xdisp.c (get_next_display_element)
98 (fill_composite_glyph_string): Add comments about special meaning
99 of TAB characters in a composition.
100
a02719a3
PE
1012011-09-15 Paul Eggert <eggert@cs.ucla.edu>
102
103 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
104 This occurs when processing a multibyte format.
105 Problem reported by Wolfgang Jenker.
a02719a3 106
72589a3c
JB
1072011-09-15 Johan Bockgård <bojohan@gnu.org>
108
109 * xdisp.c (try_cursor_movement): Only check for exact match if
110 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
111
1c14176c
PE
1122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
113
114 Remove unused external symbols.
115 * dispextern.h (calc_pixel_width_or_height): Remove decl.
116 * xdisp.c (calc_pixel_width_or_height): Now static.
117 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
118 * indent.c (check_display_width):
119 * w32term.c: Fix comment to match code.
120 * xterm.c, xterm.h (x_catching_errors): Remove.
121
d2eea5b5
PE
1222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
123
124 * xselect.c: Use signed conversions more consistently (Bug#9498).
125 (selection_data_to_lisp_data): Assume incoming selection data are
126 signed integers, not unsigned. This is to be consistent with
127 outgoing selection data, which was modified to use signed integers
128 in as part of the fix to Bug#9196 in response to Jan D.'s comment
129 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
130 expects long, not unsigned long.
131
46888499
EZ
1322011-09-14 Eli Zaretskii <eliz@gnu.org>
133
134 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
135 computation of loop end. Reported by Johan Bockgård
136 <bojohan@gnu.org>.
137
ef8ef9fb
CY
1382011-09-13 Chong Yidong <cyd@stupidchicken.com>
139
140 * frame.c (Fother_visible_frames_p): Function deleted.
141
fa819fed
EZ
1422011-09-12 Eli Zaretskii <eliz@gnu.org>
143
144 * indent.c (compute_motion): Process display vector front to back
145 rather than the other way around. (Bug#2496)
146
2ba8e008
SM
1472011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
148
149 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
150
20f53c69
CY
1512011-09-11 Chong Yidong <cyd@stupidchicken.com>
152
153 * minibuf.c (Fread_from_minibuffer): Doc fix.
154
d562d7a4
EZ
1552011-09-11 Eli Zaretskii <eliz@gnu.org>
156
157 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
158 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
159
1c4d7f3d
LMI
1602011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
161
162 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
163 value for non-existent files.
164
b885bf36
EZ
1652011-09-11 Eli Zaretskii <eliz@gnu.org>
166
167 * fileio.c (Finsert_file_contents): If the file cannot be opened,
168 set its "size" to -1. This will set the modtime_size field of
169 the corresponding buffer to -1, which is what
170 verify-visited-file-modtime expects for files that do not exist.
171 (Bug#9139)
172
6612f0bf
PE
1732011-09-11 Paul Eggert <eggert@cs.ucla.edu>
174
175 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
176 here ...
177 * lisp.h: ... from here. push_key_description is no longer
178 defined in keyboard.c, so its declaration should not be in
179 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
180 logically belongs with push_key_description.
181
dfb3f755
PE
1822011-09-10 Paul Eggert <eggert@cs.ucla.edu>
183
184 * buffer.h: Include <sys/types.h> instead of <time.h>.
185 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
186 Problem reported by Herbert J. Skuhra.
187
3134906c
LMI
1882011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
189
190 * xml.c (parse_region): Make the parsing work for
191 non-comment-starting XML files again (bug#9144).
192
8d903f4e
AS
1932011-09-10 Andreas Schwab <schwab@linux-m68k.org>
194
195 * image.c (gif_load): Fix calculation of bottom and right corner.
196 (Bug#9468)
197
80ad64f4
EZ
1982011-09-10 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
201 redisplay in small windows.
202
208a048d
EZ
2032011-09-09 Eli Zaretskii <eliz@gnu.org>
204
205 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
206
9b1c252e
MR
2072011-09-08 Martin Rudalics <rudalics@gmx.at>
208
209 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
210 Operate on live windows only.
211
2949f33b
JB
2122011-09-08 Juanma Barranquero <lekktu@gmail.com>
213
214 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
215
e08dcafd
EZ
2162011-09-07 Eli Zaretskii <eliz@gnu.org>
217
218 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
219 only under bidi iteration.
220
115b96bd
JD
2212011-09-07 Jan Djärv <jan.h.d@swipnet.se>
222
223 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
224
c8199d0f
PE
2252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
226
227 isnan: Fix porting problem to Solaris 10 with bundled gcc.
228 Without this fix, the command to link temacs failed due to an
229 undefined symbol __builtin_isnan. This is because
230 /usr/include/iso/math_c99.h #defines isnan(x) to
231 __builtin_isnan(x), but the bundled gcc, which identifies itself
232 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
233 a __builtin_isnan.
234 * floatfns.c (isnan): #undef, and then #define to a clone of
235 what's in data.c.
236 (Fisnan): Always define, since it's always available now.
237 (syms_of_floatfns): Always define isnan at the Lisp level.
238
e39b275c 2392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
240
241 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
242
b2db44d9 2432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 244
f4af5137 245 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
246 The previous code assumed that file offsets (off_t values) fit in
247 EMACS_INT variables, which is not true on typical 32-bit hosts.
248 The code messed up by falsely reporting buffer overflow in cases
249 such as (insert-file-contents "big" nil 1 2) into an empty buffer
250 when "big" contains more than 2**29 bytes, even though this
251 inserts just one byte and does not overflow the buffer.
252 (Finsert_file_contents): Store file offsets as off_t
253 values, not as EMACS_INT values. Check for overflow when
254 converting between EMACS_INT and off_t. When checking for
255 buffer overflow or for overlap, take the offsets into account.
256 Don't use EMACS_INT for small values where int suffices.
257 When checking for overlap, fix a typo: ZV was used where
258 ZV_BYTE was intended.
259 (Fwrite_region): Don't assume off_t fits into 'long'.
260 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
261
ecfc0a49
MA
2622011-09-05 Michael Albinus <michael.albinus@gmx.de>
263
264 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
265
6511acf2 2662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 267
0999621a 268 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
269
270 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 271 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
272 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
273 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
274 (modify_event_symbol): Do not assume that the length of
275 name_alist_or_stem is safe to alloca and fits in int.
276 (Fexecute_extended_command): Likewise for function name and binding.
277 (Frecursion_depth): Wrap around reliably on integer overflow.
278 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
279 since some callers pass EMACS_INT values.
280 (Fsingle_key_description): Don't crash if symbol name contains more
281 than MAX_ALLOCA bytes.
282 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
283 (get_minibuffer): Arg is now EMACS_INT, not int.
284 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 285 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
286 * window.h (command_loop_level, minibuf_level): Reflect API changes.
287
2be7d702
PE
288 * dbusbind.c (signature_cat): New function.
289 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
290 Do not overrun buffer; instead, report string overflow.
291
9d1df220
PE
292 * dispnew.c (add_window_display_history): Don't overrun buffer.
293 Truncate instead; this is OK since it's just a log.
294
33ef5c64
PE
295 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
296 even if the time zone offset is outlandishly large.
297 Don't mishandle offset == INT_MIN.
298
66c6fdd5
PE
299 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
300 when creating daemon; the previous buffer-overflow check was incorrect.
301
d749b01b
PE
302 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
303 which has the guts of the old verror function.
304
b5cd1905
PE
305 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
306 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
307
6e1a67fb
PE
308 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
309 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 310 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 311 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
312 length of string rather than counting it via multiple sprintfs;
313 that's simpler and more reliable.
c21721cc
PE
314 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
315 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
316 sprintf, in case result does not fit in int.
317
c57b67fc
PE
318 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
319 (fontset_from_font): Print it.
320
8a401434
PE
321 * frame.c (tty_frame_count): Now printmax_t, not int.
322 (make_terminal_frame, set_term_frame_name): Print it.
323 (x_report_frame_params): In X, window IDs are unsigned long,
324 not signed long, so print them as unsigned.
325 (validate_x_resource_name): Check for implausibly long names,
326 and don't assume name length fits in 'int'.
327 (x_get_resource_string): Don't blindly alloca invocation name;
328 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
329 not fit in int.
330
6e1a67fb
PE
331 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
332 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
333 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
334
0df02bf3
PE
335 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
336 Use esprintf, not sprintf, in case result does not fit in int.
337
48e30793
PE
338 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
339 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
340 it as a large positive number.
341 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
342 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
343
a66ff6d8
PE
344 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
345 in case result does not fit in int.
346
aca216ff
PE
347 * print.c (float_to_string): Detect width overflow more reliably.
348 (print_object): Make sprintf buffer a bit bigger, to avoid potential
349 buffer overrun. Don't assume list length fits in 'int'. Treat
350 print length of 0 as 0, not as infinity; to be consistent with other
351 uses of print length in this function. Don't overflow print length
352 index. Don't assume hash table size fits in 'long', or that
353 vectorlike size fits in 'unsigned long'.
354
31c286f7
PE
355 * process.c (make_process): Use printmax_t, not int, to format
356 process-name gensyms.
357
55e5faa1
PE
358 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
359
80f2e268
PE
360 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
361 to avoid potential buffer overrun.
362
670741ab
PE
363 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
364 if X resource line is longer than 512 bytes.
365
b7163a50
PE
366 * xfns.c (x_window): Make sprintf buffer a bit bigger
367 to avoid potential buffer overrun.
368
ae58ff1f
PE
369 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
370
c43c8a6a
PE
371 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
372
3f8236f4
PE
3732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
374
53e9fe90 375 Integer overflow fixes for scrolling, etc.
6511acf2
PE
376 Without these, Emacs silently mishandles large integers sometimes.
377 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
378 it were "C-u 1 M-x recenter" on a typical 64-bit host.
379
6511acf2
PE
380 * xdisp.c (try_window_id): Check Emacs fixnum range before
381 converting to 'int'.
806add1d 382
6511acf2 383 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
384 Check that an Emacs fixnum is in range before assigning it to 'int'.
385 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
386 values converted from Emacs fixnums.
387 (Frecenter): Don't wrap around a line count if it is out of 'int'
388 range; instead, treat it as an extreme value.
389 (Fset_window_configuration, compare_window_configurations):
390 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
391
6511acf2
PE
392 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
393 that can exceed INT_MAX. Check that EMACS_INT value is in range
394 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
395 (match_limit): Don't assume that a fixnum can fit in 'int'.
396
6511acf2 397 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
398 exceed INT_MAX.
399
6511acf2 400 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
401 (Fvertical_motion): Don't wrap around LINES values that don't fit
402 in 'int'. Instead, treat them as extreme values. This is good
403 enough for windows, which can't have more than INT_MAX lines anyway.
404
fcb901a7
LMI
4052011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
406
0f2f6b6d
LMI
407 * Require libxml/parser.h to avoid compilation warning.
408
fcb901a7
LMI
409 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
410
411 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
412 since this reportedly can destroy thread storage.
413
6e20a0d4
CY
4142011-08-30 Chong Yidong <cyd@stupidchicken.com>
415
416 * syntax.c (find_defun_start): Update all cache variables if
417 exiting early (Bug#9401).
418
148ae00e
EZ
4192011-08-30 Eli Zaretskii <eliz@gnu.org>
420
f6cfbd8f
EZ
421 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
422
148ae00e
EZ
423 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
424 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
425 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
426
427 * term.c (tty_append_glyph): New function.
428 (produce_stretch_glyph): Static function and its prototype deleted.
429
430 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
431 prototypes.
432
c4a07a4c
PE
4332011-08-29 Paul Eggert <eggert@cs.ucla.edu>
434
435 * image.c (parse_image_spec): Check for nonnegative, not for positive,
436 when checking :margin (Bug#9390).
437 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
438 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
439 so that the name doesn't mislead. All uses changed.
440
6bc8cd65
JB
4412011-08-28 Johan Bockgård <bojohan@gnu.org>
442
443 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
444 set_tty_hooks.
445
dca4927e
EZ
4462011-08-27 Eli Zaretskii <eliz@gnu.org>
447
448 * xdisp.c (move_it_to): Don't bail out early when reaching
449 position beyond to_charpos, if we are scanning backwards.
450 (move_it_vertically_backward): When DY == 0, make sure we get to
451 the first character in the line after the newline.
452
f2cad773
PE
4532011-08-27 Paul Eggert <eggert@cs.ucla.edu>
454
455 * ccl.c: Improve and simplify overflow checking (Bug#9196).
456 (ccl_driver): Do not generate an out-of-range pointer.
457 (Fccl_execute_on_string): Remove unnecessary check for
458 integer overflow, noted by Stefan Monnier in
459 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
460 Remove a FIXME that didn't need fixing.
461 Simplify the newly-introduced buffer reallocation code.
462
0cae2cdb
JB
4632011-08-27 Juanma Barranquero <lekktu@gmail.com>
464
465 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
466
5fc295a4 4672011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 468
70c60eb2 469 Integer and memory overflow issues (Bug#9196).
726e0ab1 470
d31850da
PE
471 * doc.c (get_doc_string): Rework so that
472 get_doc_string_buffer_size is the actual buffer size, rather than
473 being 1 less than the actual buffer size; this makes xpalloc more
474 convenient.
475
a69fbedb
PE
476 * image.c (x_allocate_bitmap_record, cache_image):
477 * xselect.c (Fx_register_dnd_atom):
478 Simplify previous changes by using xpalloc.
479
fe5c5d37
PE
480 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
481 since either will do and ptrdiff_t is convenient with xpalloc.
482
0065d054
PE
483 * charset.c (charset_table_size)
484 (struct charset_sort_data.priority): Now ptrdiff_t.
485 (charset_compare): Don't overflow if priorities differ greatly.
486 (Fsort_charsets): Don't assume list length fits in int.
487 Check for size-calculation overflow when allocating sort data.
488 (syms_of_charset): Allocate an initial charset table that is
489 just under 64 KiB, to avoid problems with glibc malloc and mmap.
490
491 * cmds.c (internal_self_insert): Check for size-calculation overflow.
492
493 * composite.h (struct composition.glyph_len): Now int, not unsigned.
494 The actual value is always <= INT_MAX, and leaving it unsigned made
495 overflow checking harder.
496
497 * dispextern.h (struct glyph_matrix.rows_allocated)
498 (struct face_cache.size): Now ptrdiff_t, for convenience in use
499 with xpalloc. The values are still always <= INT_MAX.
500
501 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
502
503 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
504 (SAFE_NALLOCA): New macro.
505
506 * region-cache.c (struct boundary.pos, find_cache_boundary)
507 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
508 (set_cache_region, invalidate_region_cache)
509 (revalidate_region_cache, know_region_cache, region_cache_forward)
510 (region_cache_backward, pp_cache):
511 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
512 so that ptrdiff_t * can be passed to xpalloc.
513 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
514 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
515 (pp_cache): Don't assume cache_len fits in int.
516 * region-cache.h: Adjust extern decls to match.
517
518 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
519 EMACS_INT, since either will do, for xpalloc.
520
521 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
522 (xnmalloc, xnrealloc, xpalloc): New functions.
523
726e0ab1
PE
524 * bidi.c (bidi_shelve_header_size): New constant.
525 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
526 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
527
51f30bc5 528 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
529 * buffer.c (overlays_at, overlays_in, record_overlay_string)
530 (overlay_strings):
531 Don't update size of array until after memory allocation succeeds,
532 because xmalloc/xrealloc may not return.
0065d054
PE
533 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
534 now that we have proper integer overflow checking.
535 (record_overlay_string, overlay_strings): Catch overflows when
536 calculating size of overlay_str_buf.
726e0ab1 537
0065d054
PE
538 * callproc.c (Fcall_process): Check for size overflow when
539 calculating size of args2.
540 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
541 Normally we prefer signed values, but sticking with ptrdiff_t would
542 require adding more-complicated checks.
726e0ab1
PE
543
544 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
545 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
546 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 547 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
548
549 * character.c (Fstring): Check for size-calculation overflow.
550
551 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
552 unnecessary integer overflow. Check for size overflow.
553 (encode_coding_object): Don't update size until xmalloc succeeds.
554
555 * composite.c (get_composition_id): Check for overflow in glyph
556 length calculations.
557
558 Integer and memory overflow fixes for display code.
559 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
560 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
561 (scrolling_window): Check for overflow in size calculations.
562 (line_draw_cost, realloc_glyph_pool, add_row_entry):
563 Don't assume glyph table len fits in int.
564 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
565 (row_table_size): Now ptrdiff_t, not int.
566 (scrolling_window): Avoid overflow in size calculations.
567 Don't update size until allocation succeeds.
568 * fns.c (concat): Check for overflow in size calculations.
569 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
570 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
571 (NEXT_ALMOST_PRIME_LIMIT): New constant.
572
573 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
574 (get_doc_string): Check for size calculation overflow.
575 Don't update size until allocation succeeds.
576 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
577 EMACS_INT, where ptrdiff_t will do.
578 (Fsubstitute_command_keys): Check for string overflow.
579
580 * editfns.c (set_time_zone_rule): Don't assume environment length
581 fits in int.
582 (message_length): Now ptrdiff_t, not int.
583 (Fmessage_box): Don't update size until allocation succeeds.
584 Don't assume message length fits in int.
585 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
586
0065d054
PE
587 * emacs.c (main): Do not reallocate argv, since there is a null at
588 the end that can be overwritten, and this way there's no need to
589 worry about size-calculation overflow.
590 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
591
592 * eval.c (init_eval_once, grow_specpdl): Don't update size until
593 alloc succeeds.
594 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
595
596 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
597 (x_set_scroll_bar_width, x_figure_window_size):
598 Check for integer overflow.
599 (x_set_alpha): Do not assume XINT fits in int.
600
601 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
602 This is for the members text_lines, text_cols, total_lines, total_cols,
603 where the system imposes an 'int' limit.
604
605 * fringe.c (Fdefine_fringe_bitmap):
606 Don't update size until alloc works.
607
608 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
609 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
610
611 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
612 Check for size-calculation overflow.
613 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
614 do, as we prefer signed integers.
615 (id_to_widget.max_size, id_to_widget.used)
616 (xg_store_widget_in_map, xg_remove_widget_from_map)
617 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
618 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
619 Use and return ptrdiff_t, not int.
620 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
621 * gtkutil.h: Change prototypes to match the above.
622
623 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
624 are duplicate now that they've been promoted to lisp.h.
625 (x_allocate_bitmap_record, x_alloc_image_color)
626 (make_image_cache, cache_image, xpm_load):
627 Don't update size until alloc is done.
628 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
629 (x_detect_edges):
3256efce 630 Check for size calculation overflow.
726e0ab1
PE
631 (ct_colors_allocated_max): New constant.
632 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
633 overflow.
3256efce 634
726e0ab1
PE
635 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
636 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
637 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
638 Use ptrdiff_t, not int, to count maps.
639 (read_char_minibuf_menu_prompt): Check for overflow in size
640 calculations. Don't update size until allocation succeeds. Redo
641 calculations to avoid overflow.
642 * keyboard.h: Change prototypes to match the above.
643
644 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
645 to count maps.
646 (current_minor_maps): Check for size calculation overflow.
647 * keymap.h: Change prototypes to match the above.
648
649 * lread.c (read1, init_obarray): Don't update size until alloc done.
650
651 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
652 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
653
726e0ab1
PE
654 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
655 Now ptrdiff_t, not int.
656 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
657 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
658
659 * process.c (Fnetwork_interface_list): Check for overflow
660 in size calculation.
661
662 * region-cache.c (move_cache_gap): Check for size calculation overflow.
663
664 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
665 overflow. Don't bother calling xmalloc when xrealloc will do.
666
667 * search.c (Freplace_match): Check for size calculation overflow.
668 (Fset_match_data): Don't assume list lengths fit in 'int'.
669
670 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
671 for command line length. Do not attempt to address one before the
672 beginning of an array, as that's not portable.
673
674 * term.c (max_frame_lines): Remove; unused.
675 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
676 not int.
677 (encode_terminal_code, calculate_costs): Check for size
678 calculation overflow.
679 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
680 table lengths and related sizes. Don't update size until alloc
681 done. Redo calculations to avoid overflow.
682 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
683
684 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
685 subtracting pointers.
686 (gobble_line): Check for overflow more carefully. Don't update size
687 until alloc done.
688
689 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
690 Don't update size until alloc done.
691 Redo size calculations to avoid overflow.
692 Check for size calculation overflow.
0065d054 693 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
694
695 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
696 Use ptrdiff_t, not int, for sizes.
697 (store_mode_line_noprop_char): Don't update size until alloc done.
698
0065d054
PE
699 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
700 Use ptrdiff_t, not int, for sizes.
701 (Finternal_make_lisp_face, cache_face):
702 Check for size calculation overflow.
703 (cache_face): Treat size calculation overflows as if they were
704 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
705
706 * xfns.c (x_encode_text, x_set_name_internal)
707 (Fx_change_window_property): Use ptrdiff_t, not int, to count
708 sizes, since they can exceed INT_MAX in size. Check for size
709 calculation overflow.
710
0065d054
PE
711 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
712 (xg_select): Check for size calculation overflow.
726e0ab1
PE
713 Don't update size until alloc done.
714
0065d054 715 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 716 as sprintf is limited to int lengths.
1d526e2f 717
252c5ee1
PE
718 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
719 (X_LONG_MIN): New macros.
864d7ce7
PE
720 Use them to make the following changes clearer.
721 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
722 This change doesn't affect the value now, but it may help remind
723 future maintainers not to raise the value too much later.
724 (SELECTION_QUANTUM): Remove, replacing with ...
725 (selection_quantum): ... new function, which avoids overflow.
726 All uses changed.
727 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
728 assumption that selection length fits in 'int'.
729 (x_reply_selection_request, x_handle_selection_request)
730 (x_get_window_property, receive_incremental_selection)
731 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
732 (lisp_data_to_selection_data, clean_local_selection_data):
733 Use ptrdiff_t, not int, to record length of selection.
734 (x_reply_selection_request, x_get_window_property)
735 (receive_incremental_selection, x_property_data_to_lisp):
736 Redo calculations to avoid overflow.
737 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 738 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
739 something.
740 (x_get_window_property, receive_incremental_selection)
741 (lisp_data_to_selection_data, x_property_data_to_lisp):
742 Check for size-calculation overflow.
743 (x_get_window_property, receive_incremental_selection)
744 (lisp_data_to_selection_data, Fx_register_dnd_atom):
745 Don't store size until memory allocation succeeds.
746 (x_get_window_property): Plug memory leak on memory exhaustion.
747 Don't double-block input; malloc is safe here. Don't assume 2**34
748 - 4 fits in unsigned long. Add an xassert to check
749 XGetWindowProperty overflow. Be more careful about overflow
750 calculations, and distinguish size from memory overflow better.
751 (receive_incremental_selection): When tracing, don't assume
752 unsigned int is less than INT_MAX.
753 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
754 harmful) conversions of unsigned short to int.
755 (lisp_data_to_selection_data): Don't assume that integers
756 in the range -65535 through -1 fit in an X unsigned short.
757 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
758 result parameters unless successful. Rely on cons_to_unsigned
759 to report problems with elements; the old code wasn't right anyway.
760 (x_check_property_data): Check for int overflow; we cannot use
761 a wider type due to X limits.
762 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
763
726e0ab1 764 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 765
0065d054
PE
766 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
767 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
768 (x_color_cells): Don't store size until memory allocation succeeds.
769 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 770 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
771 (x_term_init): Don't assume length fits in int (sprintf is limited
772 to int size).
bc18e09d 773
ebfa62c0
PE
774 Use ptrdiff_t for composition IDs.
775 * character.c (lisp_string_width):
776 * composite.c (composition_table_size, n_compositions)
777 (get_composition_id, composition_gstring_from_id):
778 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
779 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
780 * window.c (Frecenter):
781 Use ptrdiff_t, not int, for composition IDs.
782 * composite.c (get_composition_id): Check for integer overflow.
783 * composite.h: Adjust prototypes to match the above changes.
784
d3411f89
PE
785 Use ptrdiff_t for hash table indexes.
786 * category.c (hash_get_category_set):
787 * ccl.c (ccl_driver):
788 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
789 * coding.c (coding_system_charset_list, detect_coding_system):
790 * coding.h (struct coding_system.id):
791 * composite.c (get_composition_id, gstring_lookup_cache):
792 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
793 * image.c (xpm_get_color_table_h):
794 * lisp.h (hash_lookup, hash_put):
795 * minibuf.c (Ftest_completion):
796 Use ptrdiff_t for hash table indexes, not int (which is too
797 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
798 32-bit --with-wide-int hosts).
799
e097a6fa
PE
800 * charset.c (Fdefine_charset_internal): Check for integer overflow.
801 Add a FIXME comment about memory leaks.
802 (syms_of_charset): Don't assume xmalloc returns.
803
5637687f
PE
804 Don't assume that stated character widths fit in int.
805 * character.c (Fchar_width, c_string_width, lisp_string_width):
806 * character.h (CHAR_WIDTH):
807 * indent.c (MULTIBYTE_BYTES_WIDTH):
808 Use sanitize_char_width to avoid undefined and/or bad behavior
809 with outlandish widths.
810 * character.h (sanitize_tab_width): Renamed from sanitize_width,
811 now that we have two such functions. All uses changed.
812 (sanitize_char_width): New inline function.
813
a2271ba2
PE
814 Don't assume that tab-width fits in int.
815 * character.h (sanitize_width): New inline function.
816 (SANE_TAB_WIDTH): New macro.
817 (ASCII_CHAR_WIDTH): Use it.
818 * indent.c (sane_tab_width): Remove. All uses replaced by
819 SANE_TAB_WIDTH (current_buffer).
820 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
821
18c52557
PE
822 * fileio.c: Integer overflow issues with file modes.
823 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
824
caeeedc1
PE
825 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
826 Remove unreachable code.
827 (read_hex, load_charset_map_from_file): Check for integer overflow.
828
50849c52
PE
829 * xterm.c: don't go over XClientMessageEvent limit
830 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
831 (x_send_scroll_bar_event): Likewise. Check that the size does not
832 exceed limits imposed by XClientMessageEvent, as well as the usual
833 ptrdiff_t and size_t limits.
834
b13995db
PE
835 * keyboard.c: Overflow, signedness and related fixes.
836 (make_lispy_movement): Use same integer type in forward decl
837 that is used in the definition.
838 (read_key_sequence, keyremap_step):
839 Change bufsize argument back to int, undoing my 2011-03-30 change.
840 We prefer signed types, and int is wide enough here.
841 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
842 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
843 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
844 length, not size_t. Use ptrdiff_t for index, not int.
845 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
846 possibility of integer overflow.
847
13464394
PE
848 Overflow, signedness and related fixes for images.
849
850 * dispextern.h (struct it.stack[0].u.image.image_id)
851 (struct_it.image_id, struct image.id, struct image_cache.size)
852 (struct image_cache.used, struct image_cache.ref_count):
853 * gtkutil.c (update_frame_tool_bar):
854 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
855 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
856 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
857 * nsmenu.m (update_frame_tool_bar):
858 * xdisp.c (calc_pixel_width_or_height):
859 * xfns.c (image_cache_refcount):
860 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
861 on typical 64-bit hosts.
862
863 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
864 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
865 Omit unnecessary casts to int.
866 (parse_image_spec): Check that integers fall into 'int' range
867 when the callers expect that.
868 (image_ascent): Redo ascent calculation to avoid int overflow.
869 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
870 (lookup_image): Remove unnecessary tests.
871 (xbm_image_p): Locals are now of int, not EMACS_INT,
872 since parse_image_check makes sure they fit into int.
873 (png_load, gif_load, svg_load_image):
874 Prefer int to unsigned where either will do.
875 (tiff_handler): New function, combining the cores of the
876 old tiff_error_handler and tiff_warning_handler. This
877 function is rewritten to use vsnprintf and thereby avoid
878 stack buffer overflows. It uses only the features of vsnprintf
879 that are common to both POSIX and native Microsoft.
880 (tiff_error_handler, tiff_warning_handler): Use it.
881 (tiff_load, gif_load, imagemagick_load_image):
882 Don't assume :index value fits in 'int'.
883 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
884 (imagemagick_load_image): Check that crop parameters fit into
885 the integer types that MagickCropImage accepts. Don't assume
886 Vimagemagick_render_type has a nonnegative value. Don't assume
887 size_t fits in 'long'.
888 (gs_load): Use printmax_t to print the widest integers possible.
889 Check for integer overflow when computing image height and width.
890
c11821d4
EZ
8912011-08-26 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (redisplay_window): Don't force window start if point
894 will be invisible in the resulting window. (Bug#9324)
895
0c95fcf7
EZ
8962011-08-25 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
899 the display spec is of the form `(space ...)'.
900 (handle_display_spec): Return the value returned by
901 handle_single_display_spec, not just 1 or zero.
902 (handle_single_display_spec): If the display spec is of the form
903 `(space ...)', and specifies display in the text area, return 2
904 rather than 1.
fee65a97 905 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
906 accurately, and prefer exact match for point under bidi. Don't
907 advance `row' beyond the last row of the window.
0c95fcf7
EZ
908
909 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
910 into disp_prop; all users changed.
911
912 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
913 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
914 for the text covered by the display property.
915
e4ed06f1
CY
9162011-08-25 Chong Yidong <cyd@stupidchicken.com>
917
918 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
919 Change return value to nil.
920 (Frecord_buffer): Delete unused function.
921
f67cdd7f
EZ
9222011-08-24 Eli Zaretskii <eliz@gnu.org>
923
5980d4c6
EZ
924 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
925 buffers, return left-to-right.
8610fe8b
EZ
926 (set_cursor_from_row): Consider candidate row a win if its glyph
927 represents a newline and point is on that newline. Fixes cursor
928 positioning on the newline at EOL of R2L text within L2R
929 paragraph, and vice versa.
930 (try_cursor_movement): Check continued rows, in addition to
931 continuation rows. Fixes unwarranted scroll when point enters a
932 continued line of R2L text within an L2R paragraph, or vice versa.
933 (cursor_row_p): Consider the case of point being equal to
934 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
935 from the end of a short line to the beginning of a continued line
936 of R2L text within L2R paragraph.
937 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
938 composed characters.
5980d4c6 939
f67cdd7f
EZ
940 * bidi.c (bidi_check_type): Use xassert.
941 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
942 members.
943
bca633fb
EZ
9442011-08-23 Eli Zaretskii <eliz@gnu.org>
945
946 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
947 a character.
948
4a5885a7
CY
9492011-08-23 Chong Yidong <cyd@stupidchicken.com>
950
951 * nsfont.m (ns_otf_to_script): Fix typo.
952
0902a04e
KH
9532011-08-22 Kenichi Handa <handa@m17n.org>
954
955 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
956 extra slot even if the purpose is char-code-property-table.
957
1a2e6670
EZ
9582011-08-23 Eli Zaretskii <eliz@gnu.org>
959
8ddde651
EZ
960 * xdisp.c (redisplay_window): When computing centering_position,
961 account for the height of the header line. (Bug#8874)
962
425cc014
EZ
963 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
964 instead of CHAR_TO_BYTE. Fixes a crash when a completion
965 candidate is selected by the mouse, and that candidate has a
966 composed character under the mouse.
967
1a2e6670
EZ
968 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
969 coordinates reported by pos-visible-in-window-p for a composed
970 character in column zero.
971
8b76d6f8
SM
9722011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
973
974 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
975
dac347dd
EZ
9762011-08-22 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
979 consider it a hit if to_charpos is anywhere in the range of the
980 composed buffer positions.
981
e013fb34
CY
9822011-08-22 Chong Yidong <cyd@stupidchicken.com>
983
984 * image.c (gif_load): Don't assume that each subimage has the same
985 dimensions as the base image. Handle disposal method that is
986 "undefined" by the gif spec (Bug#9335).
987
bd1ba3e8
CY
9882011-08-20 Chong Yidong <cyd@stupidchicken.com>
989
990 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 991 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 992
54a1215b
EZ
9932011-08-19 Eli Zaretskii <eliz@gnu.org>
994
823564e5
EZ
995 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
996 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
997 from an Org mode buffer to a Speedbar frame.
998
54a1215b
EZ
999 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1000 a composition, take its buffer position from IT->cmp_it.charpos.
1001 Fixes cursor positioning at the beginning of a line that begins
1002 with a composed character.
1003
9778ebcc
EZ
10042011-08-18 Eli Zaretskii <eliz@gnu.org>
1005
0be6ee06
EZ
1006 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1007 character bidirectional type, use STRONG_L instead. Fixes crashes
1008 in a buffer produced by `describe-categories'.
1009
9778ebcc
EZ
1010 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1011 members before the level stack, so they would be saved and
1012 restored when copying iterator state. Fixes incorrect reordering
1013 around TABs covered by display properties.
1014
156bffbe
AS
10152011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1016
1017 * process.c (Fnetwork_interface_list): Correctly determine buffer
1018 size.
1019
72ad093b
CY
10202011-08-17 Chong Yidong <cyd@stupidchicken.com>
1021
1022 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1023 (internal_condition_case_2, internal_condition_case_n):
1024 Remove unnecessary aborts (Bug#9081).
72ad093b 1025
35774242
EZ
10262011-08-17 Eli Zaretskii <eliz@gnu.org>
1027
1028 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1029 has no `load' handler, try opening the file locally. (Bug#9311)
1030
db76dd85
KB
10312011-08-16 Ken Brown <kbrown@cornell.edu>
1032
1033 * gmalloc.c: Expand comment.
1034
b215eee5
EZ
10352011-08-16 Eli Zaretskii <eliz@gnu.org>
1036
1037 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1038 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1039
a4579d33
KB
10402011-08-16 Ken Brown <kbrown@cornell.edu>
1041
1042 Fix memory allocation problems in Cygwin build (Bug#9273).
1043
1044 * unexcw.c ( __malloc_initialized): Declare external variable.
1045 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1046
8b76d6f8
SM
1047 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1048 New variables.
a4579d33
KB
1049 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1050 dumped emacs.
1051 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1052 in the static heap.
1053 [CYGWIN] (special_realloc): New function.
1054 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1055 requests to realloc storage in the static heap.
1056
3ebec551
PE
10572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * bidi.c (bidi_initialize): Remove unused local.
1060
9fd8be00
EZ
10612011-08-15 Eli Zaretskii <eliz@gnu.org>
1062
474a8465
EZ
1063 * biditype.h: File removed.
1064
1065 * bidimirror.h: File removed.
1066
1067 * deps.mk (bidi.o): Remove biditype.h and
1068 bidimirror.h.
1069
1070 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1071 bidimirror.h.
1072
1073 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1074
1075 * chartab.c: Improve commentary for the uniprop_table API.
1076
32413314
EZ
1077 * bidi.c (bidi_paragraph_init): Support zero value of
1078 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1079 (bidi_initialize): Use uniprop_table instead of including
1080 biditype.h and bidimirror.h.
32413314 1081
9fd8be00
EZ
1082 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1083 coordinates of the iterator when restoring from ppos_it.
1084 (Bug#9296)
1085
5cf2b69b
KH
10862011-08-14 Kenichi Handa <handa@m17n.org>
1087
1088 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1089 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1090
daf17d00
EZ
10912011-08-14 Eli Zaretskii <eliz@gnu.org>
1092
1093 * xdisp.c (move_it_in_display_line_to): Don't invoke
1094 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1095 ppos_it. Fixes vertical cursor motion when line beginning is
1096 covered by an image. (Bug#9296)
1097
08e3161a
JD
10982011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1099
1100 * nsterm.h (ns_run_ascript): Declare.
1101 (NSAPP_DATA2_RUNASSCRIPT): Define.
1102
1103 * nsfns.m (as_script, as_result, as_status): New static variables.
1104 (ns_run_ascript): New function.
5e617bc2 1105 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1106 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1107 the event loop. Get status from as_status (Bug#7276).
1108
1109 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1110 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1111 the event loop (Bug#7276).
1112
a3720aa2
AS
11132011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1114
1115 * gnutls.c (QCgnutls_bootprop_priority)
1116 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1117 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1118 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1119 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1120 (QCgnutls_bootprop_verify_hostname_error)
1121 (QCgnutls_bootprop_callbacks_verify): Rename from
1122 Qgnutls_bootprop_..., all uses changed.
1123
1124 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1125 uses changed.
1126
0a0d27fb
PE
11272011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1128
19d5c50c
PE
1129 * xfaces.c (Qframe_set_background_mode): Now static.
1130 * dispextern.h (Qframe_set_background_mode): Remove decl.
1131
0a0d27fb
PE
1132 * process.c (Fnetwork_interface_info): Declare local only if needed.
1133
377538cb
JD
11342011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1135
1136 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1137 (Fnetwork_interface_list): Allocate in increments of bytes instead
1138 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1139 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1140 sockaddr.
1141 (struct ifflag_def): notrailers is smart on OSX.
1142 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1143 Get hardware address with getifaddrs if available.
1144
08fff70c
EZ
11452011-08-12 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xdisp.c (iterate_out_of_display_property): xassert that
1148 IT->position is set to within IT->object's boundaries. Break from
1149 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1150 when IT->position is set up wrongly due to some bug.
1151 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1152 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1153 entry. Force push_it to save on the stack the current
1154 buffer/string position, to be restored by pop_it. Fix flags in
1155 the iterator structure wrt the object coming from a display
1156 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1157 properties. (Bug#9284)
1158
7be1c708 11592011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1160
7be1c708
CY
1161 * fontset.c (fontset_get_font_group): Add proper type checks.
1162 (Bug#9172)
aac0c6e3 1163
7be1c708 11642011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1165
7be1c708
CY
1166 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1167 and LC_VERSION_MIN_MACOSX.
1168 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1169 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1170
97bb72a6
EZ
11712011-08-08 Eli Zaretskii <eliz@gnu.org>
1172
1173 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1174 no-display-properties-and-no-overlays under bidi display.
1175 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1176 properties and overlays.
97bb72a6 1177
d5617611
CY
11782011-08-08 Chong Yidong <cyd@stupidchicken.com>
1179
37e11a63
CY
1180 * editfns.c (Fset_time_zone_rule): Document relationship with the
1181 setenv function.
1182
d5617611
CY
1183 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1184 the font entity extracted from the cache (Bug#8109).
1185
58872834
CY
11862011-08-07 Chong Yidong <cyd@stupidchicken.com>
1187
1188 * composite.c (autocmp_chars): Don't reset point. That is done by
1189 restore_point_unwind (Bug#5984).
1190
75bfc667
JL
11912011-08-07 Juri Linkov <juri@jurta.org>
1192
1193 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1194 to show the arg `TIME' instead of `TIMEVAL'.
1195
d1410150
EZ
11962011-08-06 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1199 display property strides EOL and includes a newline, as in
1200 longlines-mode. (Bug#9254)
75b771e4
EZ
1201 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1202 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1203
1204 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1205 is non-zero, even if the data buffer is NULL. Fixes a crash in
1206 vertical-motion with longlines-mode. (Bug#9254)
1207
35928349
EZ
12082011-08-05 Eli Zaretskii <eliz@gnu.org>
1209
ec7cc85b
EZ
1210 * bidi.c <bidi_cache_total_alloc>: Now static.
1211 (bidi_initialize): Initialize bidi_cache_total_alloc.
1212
8b76d6f8 1213 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1214 cache. (Bug#9221)
1215
1216 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1217 amount allocated this far in `bidi_cache_total_alloc'.
1218 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1219 non-zero, only free the data buffer without restoring the cache
1220 contents. All callers changed.
1221
1222 * dispextern.h (bidi_unshelve_cache): Update prototype.
1223
1224 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1225 (move_it_in_display_line, move_it_to)
1226 (move_it_vertically_backward, move_it_by_lines): Replace the call
1227 to xfree to an equivalent call to bidi_unshelve_cache.
1228 (move_it_in_display_line_to): Fix logic of returning
412b6358 1229 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1230
e2e2423b
EZ
12312011-08-05 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1234 came from a string character with a `cursor' property. (Bug#9229)
1235
ae9e757a
JD
12362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * Makefile.in (LIB_PTHREAD): New variable.
1239 (LIBES): Add LIB_PTHREAD (Bug#9216).
1240
1241 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1242 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1243
213bd7f2
AS
12442011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1245
1246 * regex.c (re_iswctype): Remove some redundant boolean
1247 conversions.
1248
99aaf75f
JD
12492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1250
1251 * xterm.c (x_find_topmost_parent): New function.
1252 (x_set_frame_alpha): Find topmost parent window with
1253 x_find_topmost_parent and set the property there also (bug#9181).
1254 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1255
c74e9d86
PE
12562011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * callproc.c (Fcall_process): Avoid vfork clobbering
1259 the local vars buffer, coding_systems, current_dir.
1260
640c8776
SM
12612011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1262
1263 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1264
f26d0e4c
PE
12652011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1266
8a10d76c
PE
1267 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1268 so that it is not optimized away.
1269
f26d0e4c
PE
1270 * xdisp.c (compute_display_string_pos): Remove unused local.
1271
55439c61
EZ
12722011-08-02 Eli Zaretskii <eliz@gnu.org>
1273
1274 Fix slow cursor motion and scrolling in large buffers with
1275 selective display, like Org Mode buffers. (Bug#9218)
1276
1277 * dispextern.h (struct bidi_it): New member disp_prop_p.
1278
1279 * xdisp.c: Remove one-slot cache of display string positions.
1280 (compute_display_string_pos): Accept an additional argument
5e617bc2 1281 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1282 for a display string or property. If found, set DISP_PROP_P
1283 non-zero.
1284
1285 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1286 DISP_PROP_P, and pass it to compute_display_string_pos.
1287 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1288 non-zero. All callers of bidi_fetch_char changed.
1289
fb33fa43
SM
12902011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1293
b099e063
DM
12942010-12-03 Don March <don@ohspite.net>
1295
1296 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1297 last character M-[char] is translated to ESC [char] (bug#7541).
1298
5cc7f7af
KH
12992011-08-02 Kenichi Handa <handa@m17n.org>
1300
d0fffa3f 1301 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1302
1303 * chartab.c (uniprop_table): Make it non-static.
1304
525d5e6e
EZ
13052011-08-01 Eli Zaretskii <eliz@gnu.org>
1306
1307 * xdisp.c (forward_to_next_line_start): Accept additional argument
1308 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1309 on the newline.
1310 (reseat_at_next_visible_line_start): Use the bidi iterator state
1311 returned by forward_to_next_line_start to restore the state of
1312 it->bidi_it after backing up to previous newline. (Bug#9212)
1313
31011111
AS
13142011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1315
1316 * regex.c (re_comp): Protoize.
1317 (re_exec): Fix return type.
1318 (regexec): Fix type of `ret'. (Bug#9203)
1319
476371c4
PE
13202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1321
e5d76069
PE
1322 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1323 This is needed if max-image-size is a floating-point number.
1324
9a79b20c
AS
13252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1326
1327 * print.c (print_object): Print empty symbol as ##.
1328
1329 * lread.c (read1): Read ## as empty symbol.
1330
d8c2fa78
AA
13312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1332
1333 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1334 setting frame foreground color (Bug#9175).
1335 (x_set_background_color): Likewise.
1336
ffe57a7a
AA
1337 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1338 contents (Bug#9176).
1339 (EmacsTooltip -init): Remove bezels and add shadows to
1340 tooltip windows.
1341
bf3492a5
AA
1342 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1343 or scroll bar (Bug#8470).
1344
d55e9c53
AA
1345 * nsfont.m (nsfont_open): Remove assignment to voffset and
1346 unnecessary vars hshink, expand, hd, full_height, min_height.
1347 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1348
1349 * nsterm.h (nsfont_info): Remove voffset field.
1350
d8c2fa78 13512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1352
1353 Implement strike-through and overline on NextStep (Bug#8863).
1354
1355 * nsfont.m (nsfont_open): Use underline position provided by font,
1356 instead of hard-coded value of 2.
1357 (nsfont_draw): Call ns_draw_text_decoration instead.
1358
1359 * nsterm.h: Add declaration for ns_draw_text_decoration.
1360
1361 * nsterm.m (ns_draw_text_decoration): New function for drawing
1362 underline, overline, and strike-through.
1363 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1364 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1365 accommodate underlining, etc.
4843aac3 1366
4cc60b9b
EZ
13672011-07-28 Eli Zaretskii <eliz@gnu.org>
1368
bc7ece87
EZ
1369 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1370 default.
4cc60b9b 1371
476371c4
PE
13722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1373
66606eea
PE
1374 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1375 Without this fix, if a signal arrives just after memory fills up,
1376 'malloc' might be invoked reentrantly.
1377
476371c4
PE
1378 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1379 In other words, assume that every image size is allowed, on non-X
1380 hosts. This assumption is probably wrong, but it lets Emacs compile.
1381
f3fcc40d
AS
13822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1383
1384 * regex.c (re_iswctype): Convert return values to boolean.
1385
350c992f
EZ
13862011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1387
1388 * xdisp.c (compute_display_string_pos): Don't use cached display
1389 string position if the buffer had its restriction changed.
1390 (Bug#9184)
1391
5266b4bb
PE
13922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1395
2573a837 13962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1397
41f55ccd 1398 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1399
39e378da
PE
1400 * bidi.c: Integer size and overflow fixes.
1401 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1402 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1403 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1404 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1405 (bidi_find_other_level_edge):
1406 Use ptrdiff_t instead of EMACS_INT where either will do.
1407 This works better on 32-bit hosts configured --with-wide-int.
1408 (bidi_cache_ensure_space): Check for size-calculation overflow.
1409 Use % rather than repeated addition, for better worst-case speed.
1410 Don't set bidi_cache_size until after xrealloc returns, because it
1411 might not return.
1412 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1413 (bidi_cache_ensure_space): Also check that the bidi cache size
1414 does not exceed that of the largest Lisp string or buffer. See Eli
1415 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1416
5e927815
PE
1417 * alloc.c (__malloc_size_t): Remove.
1418 All uses replaced by size_t. See Andreas Schwab's note
1419 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1420
ca4aa935
PE
1421 * image.c: Improve checking for integer overflow.
1422 (check_image_size): Assume that f is nonnull, since
1423 it is always nonnull in practice. This is one less thing to
1424 worry about when checking for integer overflow later.
1425 (x_check_image_size): New function, which checks for integer
1426 overflow issues inside X.
1427 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1428 This removes the need for a memory_full check.
1429 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1430 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1431 (xbm_read_bitmap_data): Change locals back to 'int', since
1432 their values must fit in 'int'.
1433 (xpm_load_image, png_load, tiff_load):
1434 Invoke x_create_x_image_and_pixmap earlier,
1435 to avoid much needless work if the image is too large.
1436 (tiff_load): Treat overly large images as if
1437 x_create_x_image_and_pixmap failed, not as malloc failures.
1438 (gs_load): Use x_check_image_size.
1439
5f8f9cc2
PE
1440 * gtkutil.c: Omit integer casts.
1441 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1442 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1443
5adf60bc
PE
1444 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1445
c8907a93
PE
1446 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1447 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1448 would wrongly return t on a 64-bit host.
1449
e3c25c68
PE
1450 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1451 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1452 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1453 and therefore cause GCC to emit a bogus diagnostic in some cases.
1454
3f791afe
PE
1455 * image.c: Integer signedness and overflow and related fixes.
1456 This is not an exhaustive set of fixes, but it's time to
1457 record what I've got.
1458 (lookup_pixel_color, check_image_size): Remove redundant decls.
1459 (check_image_size): Don't assume that arbitrary EMACS_INT values
1460 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1461 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1462 (tiff_load, imagemagick_load_image):
1463 Check for overflow in size calculations.
1464 (x_create_x_image_and_pixmap): Remove unnecessary test for
1465 xmalloc returning NULL; that can't happen.
1466 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1467 (xpm_color_bucket): Use better integer hashing function.
1468 (xpm_cache_color): Don't possibly over-allocate memory.
1469 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1470 (gif_memory_source):
1471 Use ptrdiff_t, not int or size_t, to record sizes.
1472 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1473 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1474 either works, as we prefer signed integers.
1475 (tiff_read_from_memory, tiff_write_from_memory):
1476 Return tsize_t, not size_t, since that's what the TIFF API wants.
1477 (tiff_read_from_memory): Don't fail simply because the read would
1478 go past EOF; instead, return a short read.
1479 (tiff_load): Omit no-longer-needed casts.
1480 (Fimagemagick_types): Don't assume size fits into 'int'.
1481
3cc5a532
PE
1482 Improve hashing quality when configured --with-wide-int.
1483 * fns.c (hash_string): New function, taken from sxhash_string.
1484 Do not discard information about ASCII character case; this
1485 discarding is no longer needed.
1486 (sxhash-string): Use it. Change sig to match it. Caller changed.
1487 * lisp.h: Declare it.
1488 * lread.c (hash_string): Remove, since we now use fns.c's version.
1489 The fns.c version returns a wider integer if --with-wide-int is
1490 specified, so this should help the quality of the hashing a bit.
1491
b312a492
PE
1492 * emacs.c: Integer overflow minor fix.
1493 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1494 Define only if GNU_LINUX.
1495 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1496
dfd153ae
PE
1497 * dispnew.c: Integer signedness and overflow fixes.
1498 Remove unnecessary forward decls, that were a maintenance hassle.
1499 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1500 All uses changed.
1501 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1502 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1503 (prepare_desired_row, line_draw_cost):
1504 Use int, not unsigned, where either works.
1505 (save_current_matrix, restore_current_matrix):
1506 Use ptrdiff_t, not size_t, where either works.
1507 (init_display): Check for overflow more accurately, and without
1508 relying on undefined behavior.
1509
a81d11a3
PE
1510 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1511 Remove, replacing with the new symbols in lisp.h. All uses changed.
1512 * fileio.c (make_temp_name):
1513 * filelock.c (lock_file_1, lock_file):
1514 * xdisp.c (message_dolog):
1515 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1516 Use pMd etc. instead.
1517 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1518 replacing the pWIDE etc. symbols removed from editfns.c.
1519
3300e6fd
PE
1520 * keyboard.h (num_input_events): Now uintmax_t.
1521 This is (very slightly) less likely to mess up due to wraparound.
1522 All uses changed.
1523
fd05c7e9
PE
1524 * buffer.c: Integer signedness fixes.
1525 (alloc_buffer_text, enlarge_buffer_text):
1526 Use ptrdiff_t rather than size_t when either will do, as we prefer
1527 signed integers.
1528
903fe15d
PE
1529 * alloc.c: Integer signedness and overflow fixes.
1530 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1531 (__malloc_size_t): Default to size_t, not to int.
1532 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1533 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1534 Prefer ptrdiff_t to size_t when either would do, as we prefer
1535 signed integers.
1536 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1537 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1538 Now const. Initialize with values that are in range even if char
1539 is signed.
1540 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1541 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1542 These functions do the right thing with sizes > 2**32.
1543 (check_depth): Now ptrdiff_t, not int.
1544 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1545 Adjust to new way of storing sizes. Check for size overflow bugs
1546 in rest of code.
1547 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1548 slightly wrong anyway, as it missed one instance of
1549 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1550 (refill_memory_reserve): Omit needless cast to size_t.
1551 (mark_object_loop_halt): Mark as externally visible.
1552
ac82cc6a
PE
1553 * xselect.c: Integer signedness and overflow fixes.
1554 (Fx_register_dnd_atom, x_handle_dnd_message):
1555 Use ptrdiff_t, not size_t, since we prefer signed.
1556 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1557 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1558 x_dnd_atoms_size and x_dnd_atoms_length.
1559
c2d1e36d
PE
1560 * doprnt.c: Prefer signed to unsigned when either works.
1561 * eval.c (verror):
1562 * doprnt.c (doprnt):
1563 * lisp.h (doprnt):
1564 * xdisp.c (vmessage):
1565 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1566 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1567 prefer signed arithmetic to avoid comparison confusion.
1568 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1569 but is a bit tricky.
1570
0e926e56
PE
1571 Assume freestanding C89 headers, string.h, stdlib.h.
1572 * data.c, doprnt.c, floatfns.c, print.c:
1573 Include float.h unconditionally.
1574 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1575 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1576 * regex.c: Likewise for stddef.h, string.h.
1577 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1578 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1579 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1580 (STDC_HEADERS): Remove obsolete defines.
1581 * sysdep.c: Include limits.h unconditionally.
1582
9cfdb3ec
PE
1583 Assume support for memcmp, memcpy, memmove, memset.
1584 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1585 * regex.c (memcmp, memcpy):
1586 Remove; we assume C89 now.
1587
1588 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1589 (__malloc_safe_bcopy): Remove; no longer needed.
1590
cf950e6b 1591 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1592 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1593 well either way, and we prefer signed to unsigned.
1594
dbf38e02
LMI
15952011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1596
1597 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1598 closes the connection while we're reading (bug#9182).
1599
d6f0886c 16002011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1601
d6f0886c
JD
1602 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1603 are specified (Bug#9168).
24e0f6b1 1604
2eb1f9e6
PE
16052011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1608 Found by GCC static checking and --with-wide-int on a 32-bit host.
1609
22381272 16102011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1611
1612 * xdisp.c (compute_display_string_pos): Fix logic of caching
1613 previous display string position. Initialize cached_prev_pos to
1614 -1. Fixes slow-down at the beginning of a buffer.
1615
f25e39b4
EZ
16162011-07-24 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1619 for attrs[LFACE_FONTSET_INDEX].
1620
04c4b52e
PE
16212011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 * xml.c (parse_region): Remove unused local
1624 that was recently introduced.
1625
c1734fbd
EZ
16262011-07-23 Eli Zaretskii <eliz@gnu.org>
1627
be18c5a5
EZ
1628 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1629 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1630
c1734fbd
EZ
1631 * xdisp.c (move_it_in_display_line_to): Record the best matching
1632 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1633 exit if none of the characters scanned was an exact match.
1634 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1635 when exact match is impossible due to invisible text, and the
1636 lines are truncated.
1637
a258d627
JD
16382011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1639
1640 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1641 for OSX >= 10.7.
1642
b6d5a689
EZ
16432011-07-22 Eli Zaretskii <eliz@gnu.org>
1644
0f74f785
EZ
1645 Fix a significant slow-down of cursor motion with C-n, C-p,
1646 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1647 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1648 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1649 (next_element_from_buffer): Call compute_stop_pos_backwards to
1650 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1651 base_level_stop.
1652 (reseat): Don't look for prev_stop, as that could mean a very long
1653 run.
1654 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1655 <cached_disp_overlay_modiff>: Cache for last found display string
1656 position.
551918c1 1657 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1658 about the same buffer in the same area of character positions, and
1659 the buffer wasn't changed since the time the display string
1660 position was cached.
551918c1 1661
b2d0c91a
EZ
16622011-07-22 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1665 is an integer, which is important for empty lines. (Bug#9149)
1666
043604ee
CY
16672011-07-22 Chong Yidong <cyd@stupidchicken.com>
1668
1669 * frame.c (Fmodify_frame_parameters): In tty case, update the
1670 default face if necessary (Bug#4238).
1671
da4adb04
CY
16722011-07-21 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * editfns.c (Fstring_to_char): No need to explain what a character
1675 is in the docstring (Bug#6576).
1676
9abd0532
LMI
16772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1678
1679 * xml.c (parse_region): Make sure we always return a tree.
1680
36881d16
HK
16812011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1682
1683 * xml.c (parse_region): If a document contains only comments,
1684 return that, too.
1685
1e98674d
LMI
16862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1687
1688 * xml.c (make_dom): Return comments, too.
1689
590bd467
PE
16902011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 Port to OpenBSD.
1693 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1694 and the surrounding thread.
1695 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1696 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1697 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1698 timer goes off.
1699 * s/openbsd.h (BROKEN_SIGIO): Define.
1700 * unexelf.c (unexec) [__OpenBSD__]:
1701 Don't update the .mdebug section of the Alpha COFF symbol table.
1702
f41628b2
LMI
17032011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1704
1705 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1706 (bug#8460).
1707
b59b67c5
PE
17082011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1709
15e3a074
PE
1710 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1711 This fixes some race conditions on the permissions of any newly
1712 created file.
1713
41bed37d
PE
1714 * alloc.c (valid_pointer_p): Use pipe, not open.
1715 This fixes some permissions issues when debugging.
1716
b59b67c5
PE
1717 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1718 If fchown fails to set both uid and gid, try to set just gid,
1719 as that is sometimes allowed. Adjust the file's mode to eliminate
1720 setuid or setgid bits that are inappropriate if fchown fails.
1721
925a6be7
SM
17222011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1725 to compare Lisp_Objects.
1726 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1727 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1728 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1729
52968808
AS
17302011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1731
0a6a104b
AS
1732 * lread.c (read_integer): Unread even EOF character.
1733 (read1): Likewise. Properly record start position of symbol.
1734
52968808
AS
1735 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1736 symbol character follows.
1737
9e381cdd
PE
17382011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1741 This works around a problem with the previous change to Fcopy_file.
1742 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1743 and without this change, GCC might complain about discarding
1744 fchown's return value.
1745
b5641435
JB
17462011-07-16 Juanma Barranquero <lekktu@gmail.com>
1747
1748 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1749
a8031457
PE
17502011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1753
dd889327
LMI
17542011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1755
750c33f7
LMI
1756 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1757 it's used from the C level.
1758
dd889327
LMI
1759 * process.c: Use the same condition for POLL_FOR_INPUT in both
1760 keyboard.c and process.c (bug#1858).
1761
87e86684
LM
17622011-07-09 Lawrence Mitchell <wence@gmx.li>
1763
1764 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1765 (Fgnutls_boot): Use it.
1766
64348f40
AS
17672011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1768
1769 * doc.c (Fsubstitute_command_keys): Revert last change.
1770
1d698799
LMI
17712011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772
f863868c
LMI
1773 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1774 quotes the next character, and doesn't affect other longer
1775 sequences (bug#8935).
1776
1d698799
LMI
1777 * lread.c (syms_of_lread): Clarify that is isn't only
1778 `eval-buffer' and `eval-defun' that's affected by
1779 `lexical-binding' (bug#8460).
1780
aa4b6df6
EZ
17812011-07-15 Eli Zaretskii <eliz@gnu.org>
1782
1783 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1784 bidi redisplay when a line includes both an image and is
1785 truncated.
1786
5d856da6
PE
17872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1788
ad6042bb
PE
1789 Fix minor problems found by static checking.
1790 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1791 (elsz): Now a signed constant, not a size_t var. We prefer signed
1792 types to unsigned, to avoid integer comparison confusion. Without
1793 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1794 "cannot optimize loop, the loop counter may overflow", a symptom
1795 of the confusion.
f00bbb22 1796 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1797 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1798
6468f31c
LMI
17992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1800
49080b10
LMI
1801 * search.c (Fre_search_backward): Mention `case-fold-search' in
1802 all the re_search_* functions (bug#8138).
1803
6468f31c
LMI
1804 * keyboard.c (Fopen_dribble_file): Document when the file is
1805 closed (bug#8056).
1806
c965adc5
EZ
18072011-07-14 Eli Zaretskii <eliz@gnu.org>
1808
df9733bf
EZ
1809 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1810 bidi_cache_idx.
1811
0bb23927
EZ
1812 Support bidi reordering of display and overlay strings.
1813 * xdisp.c (compute_display_string_pos)
1814 (compute_display_string_end): Accept additional argument STRING.
1815 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1816 (reseat_to_string): Initialize bidi_it->string.s and
1817 bidi_it->string.schars.
1818 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1819 NULL (avoids a crash in bidi_paragraph_init).
1820 Initialize itb.string.lstring.
0bb23927
EZ
1821 (init_iterator): Call bidi_init_it only of a valid
1822 buffer position was specified. Initialize paragraph_embedding to
1823 L2R.
1824 (reseat_to_string): Initialize the bidi iterator.
1825 (display_string): If we need to ignore text properties of
1826 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1827 original value of -1 will not work with bidi.)
1828 (compute_display_string_pos): First arg is now struct
1829 `text_pos *'; all callers changed. Support display properties on
1830 Lisp strings.
1831 (compute_display_string_end): Support display properties on Lisp
1832 strings.
1833 (init_iterator, reseat_1, reseat_to_string): Initialize the
1834 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1835 when iterating on a string not from display properties).
640c8776
SM
1836 (compute_display_string_pos, compute_display_string_end):
1837 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1838 arrow keys.
1839 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1840 base_level_stop; instead, set base_level_stop to BEGV.
1841 Fixes crashes in vertical-motion.
0bb23927
EZ
1842 (next_element_from_buffer): Improve commentary for when
1843 the iterator is before prev_stop.
1844 (init_iterator): Initialize bidi_p from the default value of
1845 bidi-display-reordering, not from buffer-local value. Use the
1846 buffer-local value only if initializing for buffer iteration.
1847 (handle_invisible_prop): Support invisible properties on strings
1848 that are being bidi-reordered.
1849 (set_iterator_to_next): Support bidi reordering of C strings and
1850 Lisp strings.
1851 (next_element_from_string): Support bidi reordering of Lisp
1852 strings.
1853 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1854 (display_string): Support display of R2L glyph rows.
1855 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1856 (init_iterator): Don't initialize it->bidi_p for strings
1857 here.
1858 (reseat_to_string): Initialize it->bidi_p for strings here.
1859 (next_element_from_string, next_element_from_c_string)
1860 (next_element_from_buffer): Add xassert's for correspondence
1861 between IT's object being iterated and it->bidi_it.string
1862 structure.
1863 (face_before_or_after_it_pos): Support bidi iteration.
1864 (next_element_from_c_string): Handle the case of the first string
1865 character that is not the first one in the visual order.
1866 (get_visually_first_element): New function, refactored from common
1867 parts of next_element_from_buffer, next_element_from_string, and
1868 next_element_from_c_string.
1869 (tool_bar_lines_needed, redisplay_tool_bar)
1870 (display_menu_bar): Force left-to-right direction. Add a FIXME
1871 comment for making that be controlled by a user option.
1872 (push_it, pop_it): Save and restore the state of the
1873 bidi iterator. Save and restore the bidi_p flag.
1874 (pop_it): Iterate out of display property for string iteration as
1875 well.
1876 (iterate_out_of_display_property): Support iteration over strings.
1877 (handle_single_display_spec): Set up it->bidi_it for iteration
1878 over a display string, and call bidi_init_it.
1879 (handle_single_display_spec, next_overlay_string)
1880 (get_overlay_strings_1, push_display_prop): Set up the bidi
1881 iterator for displaying display or overlay strings.
1882 (forward_to_next_line_start): Don't use the shortcut if
1883 bidi-iterating.
1884 (back_to_previous_visible_line_start): If handle_display_prop
1885 pushed the iterator stack, restore the internal state of the bidi
1886 iterator by calling bidi_pop_it same number of times.
1887 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1888 and we are bidi-iterating, don't decrement the iterator position;
1889 instead, set the first_elt flag in the bidi iterator, to produce
1890 the same effect.
1891 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1892 (push_display_prop): xassert that we are iterating a buffer.
1893 (push_it, pop_it): Save and restore paragraph_embedding member.
1894 (handle_single_display_spec, next_overlay_string)
1895 (get_overlay_strings_1, reseat_1, reseat_to_string)
1896 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1897 correctly. Don't assume unibyte strings are not bidi-reordered.
1898 (compute_display_string_pos)
1899 (compute_display_string_end): Fix handling the case of C string.
1900 (push_it, pop_it): Save and restore from_disp_prop_p.
1901 (handle_single_display_spec, push_display_prop): Set the
1902 from_disp_prop_p flag.
1903 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1904 (pop_it): Call iterate_out_of_display_property only if we are
1905 popping after iteration over a string that came from a display
1906 property. Fix a typo in popping stretch info. Add an assertion
1907 for verifying that the iterator position is in sync with the bidi
1908 iterator.
1909 (handle_single_display_spec, get_overlay_strings_1)
1910 (push_display_prop): Fix initialization of paragraph direction for
1911 string when that of the parent object is not yet determined.
1912 (reseat_1): Call bidi_init_it to resync the bidi
1913 iterator with IT's position. (Bug#7616)
1914 (find_row_edges): If ROW->start.pos gives position
1915 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1916 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1917 Reset the from_disp_prop_p flag.
1918 (SAVE_IT, RESTORE_IT): New macros.
1919 (pos_visible_p, face_before_or_after_it_pos)
1920 (back_to_previous_visible_line_start)
1921 (move_it_in_display_line_to, move_it_in_display_line)
1922 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1923 (try_scrolling, redisplay_window, display_line): Use them when
1924 saving a temporary copy of the iterator and restoring it back.
1925 (back_to_previous_visible_line_start, reseat_1)
1926 (init_iterator): Empty the bidi cache "stack".
1927 (move_it_in_display_line_to): If iterator ended up at
1928 EOL, but we never saw any buffer positions smaller than
1929 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1930 motion in bidi-reordered lines.
1931 (move_it_in_display_line_to): Record prev_method and prev_pos
1932 immediately before the call to set_iterator_to_next. Fixes cursor
1933 motion in bidi-reordered lines with stretch glyphs and strings
1934 displayed in margins. (Bug#8133) (Bug#8867)
1935 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1936 TO_CHARPOS.
640c8776
SM
1937 (pos_visible_p): Support positions in bidi-reordered lines.
1938 Save and restore bidi cache.
0bb23927
EZ
1939
1940 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1941 (bidi_paragraph_info): Delete unused struct.
1942 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1943 (bidi_cache_start): New variable.
1944 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1945 to zero.
1946 (bidi_cache_fetch_state, bidi_cache_search)
1947 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1948 (bidi_cache_find, bidi_peek_at_next_level)
1949 (bidi_level_of_next_char, bidi_find_other_level_edge)
1950 (bidi_move_to_visually_next): Compare cache index with
1951 bidi_cache_start rather than with zero.
1952 (bidi_fetch_char): Accept new argument STRING; all callers
1953 changed. Support iteration over a string. Support strings with
1954 display properties. Support unibyte strings. Fix the type of
1955 `len' according to what STRING_CHAR_AND_LENGTH expects.
1956 (bidi_paragraph_init, bidi_resolve_explicit_1)
1957 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1958 (bidi_level_of_next_char, bidi_move_to_visually_next):
1959 Support iteration over a string.
0bb23927
EZ
1960 (bidi_set_sor_type, bidi_resolve_explicit_1)
1961 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1962 can now be zero (for strings); special values 0 and -1 were
1963 changed to -1 and -2, respectively.
1964 (bidi_char_at_pos): New function.
1965 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1966 Call it instead of FETCH_MULTIBYTE_CHAR.
1967 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1968 initialized to valid values.
1969 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1970 values.
1971 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1972 the test for valid cached positions. Fix the logic for looking up
1973 the sentinel state in the cache. GCPRO the Lisp string we are
1974 iterating.
1975 (bidi_push_it, bidi_pop_it): New functions.
1976 (bidi_initialize): Initialize the bidi cache start stack pointer.
1977 (bidi_cache_ensure_space): New function, refactored from part of
1978 bidi_cache_iterator_state. Don't assume the required size is just
1979 one BIDI_CACHE_CHUNK away.
1980 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1981 (bidi_count_bytes, bidi_char_at_pos): New functions.
1982 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1983 always valid if bidi_cache_idx is valid.
1984 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1985 is valid if it's going to be used.
1986 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1987 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1988 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1989 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1990 (bidi_find_other_level_edge, bidi_cache_start_stack):
1991 All variables related to cache indices are now EMACS_INT.
c965adc5 1992
0bb23927
EZ
1993 * dispextern.h (struct bidi_string_data): New structure.
1994 (struct bidi_it): New member `string'. Make flag members be 1-bit
1995 fields, and put them last in the struct.
640c8776
SM
1996 (compute_display_string_pos, compute_display_string_end):
1997 Update prototypes.
0bb23927
EZ
1998 (bidi_push_it, bidi_pop_it): Add prototypes.
1999 (struct iterator_stack_entry): New members bidi_p,
2000 paragraph_embedding, and from_disp_prop_p.
2001 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2002 (bidi_shelve_cache, bidi_unshelve_cache):
2003 Declare prototypes.
0bb23927
EZ
2004
2005 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2006 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2007 and vector-like objects.
2008
2009 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2010 cache around display iteration.
2011
2012 * window.c (Fwindow_end, window_scroll_pixel_based)
2013 (displayed_window_lines, Frecenter): Save and restore the bidi
2014 cache around display iteration.
2015
3bbd2265
LMI
20162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2017
2018 * editfns.c (Fdelete_region): Clarify the use of the named
2019 parameters (bug#6788).
2020
adc47434
MR
20212011-07-14 Martin Rudalics <rudalics@gmx.at>
2022
2023 * indent.c (Fvertical_motion): Set and restore w->pointm when
2024 saving and restoring the window's buffer (Bug#9006).
2025
837c31f8
LMI
20262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2027
2028 * editfns.c (Fstring_to_char): Clarify just what is returned
2029 (bug#6576). Text by Eli Zaretskii.
2030
ac389d0c
JB
20312011-07-13 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2034
0be0ce47
EZ
20352011-07-13 Eli Zaretskii <eliz@gnu.org>
2036
2037 * buffer.c (mmap_find): Fix a typo.
2038
cd18e7e3
JB
20392011-07-13 Johan Bockgård <bojohan@gnu.org>
2040
2041 Fix execution of x selection hooks.
2042 * xselect.c (Qx_lost_selection_functions)
2043 (Qx_sent_selection_functions): New vars.
2044 (syms_of_xselect): DEFSYM them.
2045 (x_handle_selection_request): Pass Qx_sent_selection_functions
2046 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2047 (x_handle_selection_clear,x_clear_frame_selections):
2048 Pass Qx_lost_selection_functions rather than
2049 Vx_lost_selection_functions to Frun_hook_with_args.
2050
47ea7f44
PE
20512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2052
ac389d0c 2053 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2054 The old code sometimes used this field without initializing it.
2055
47ea7f44
PE
2056 * alloc.c (gc_sweep): Don't read past end of array.
2057 In theory, the old code could also have corrupted Emacs internals,
2058 though it'd be very unlikely.
2059
bc985c87
AS
20602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2061
2062 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2063 argument. (Bug#4026)
bc985c87 2064
0cf34688
LMI
20652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2066
b3dadd76
LMI
2067 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2068 key" (bug#4257).
2069
0cf34688
LMI
2070 * window.c (Fset_window_start): Doc fix (bug#4199).
2071 (Fset_window_hscroll): Ditto.
2072
270768cd
PE
20732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2074
077e3dda 2075 Fix minor new problems caught by GCC 4.6.1.
270768cd 2076 * term.c (init_tty): Remove unused local.
490011a6 2077 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2078 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2079 not used otherwise.
270768cd 2080
b1f58454
CY
20812011-07-12 Chong Yidong <cyd@stupidchicken.com>
2082
2083 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2084
22b9578d
LMI
20852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2086
6e70ab07
LMI
2087 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2088 are the mini-buffer and the echo area (bug#3320).
2089
22b9578d
LMI
2090 * term.c (init_tty): Remove support for supdup, c10 and perq
2091 terminals, which are no longer supported (bug#1482).
2092
8974cc9f
JB
20932011-07-10 Johan Bockgård <bojohan@gnu.org>
2094
2095 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2096
a560d974
JD
20972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2098
2099 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2100 for non-popups (Bug#3642).
2101
1dae0f0a
AS
21022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2103
268c2c36 2104 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2105 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2106 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2107 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2108 * data.c (fmod): Likewise.
2109 * dispnew.c (swap_glyphs_in_rows): Likewise.
2110 * emacs.c (memory_warning_signal): Likewise.
2111 * floatfns.c (float_error): Likewise.
2112 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2113 (otf_open, font_otf_capability, generate_otf_features)
2114 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2115 Likewise.
2116 * image.c (pbm_read_file): Likewise.
2117 * indent.c (string_display_width): Likewise.
2118 * intervals.c (check_for_interval, search_for_interval)
2119 (inc_interval_count, count_intervals, root_interval)
2120 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2121 * lread.c (defalias): Likewise.
268c2c36 2122 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2123 * regex.c (set_image_of_range_1, set_image_of_range)
2124 (regex_grow_registers): Likewise.
2125 * sysdep.c (strerror): Likewise.
2126 * termcap.c (valid_filename_p, tprint, main): Likewise.
2127 * tparam.c (main): Likewise.
2128 * unexhp9k800.c (run_time_remap, save_data_space)
2129 (update_file_ptrs, read_header, write_header, calculate_checksum)
2130 (copy_file, copy_rest, display_header): Likewise.
2131 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2132 Likewise.
2133 * xdisp.c (check_it): Likewise.
2134 * xfaces.c (register_color, unregister_color, unregister_colors):
2135 Likewise.
2136 * xfns.c (print_fontset_result): Likewise.
2137 * xrdb.c (member, fatal, main): Likewise.
2138
99033785
PE
21392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 Fix minor problems found by static checking (Bug#9031).
2142 * chartab.c (char_table_set_range, map_sub_char_table):
2143 Remove unused locals.
2144 (uniprop_table): Now static.
2145 * composite.c (_work_char): Remove unused static var.
2146
9cb2ac56
JB
21472011-07-09 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2150
f25661f0
JD
21512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2152
2153 * gtkutil.c (qttip_cb): Remove code without function.
2154
8278c4fe
EZ
21552011-07-09 Eli Zaretskii <eliz@gnu.org>
2156
2157 * w32.c (pthread_sigmask): New stub.
2158
1692ae2d 21592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2160
8a6ebd58 2161 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2162 sigprocmask is portable only for single-threaded applications, and
2163 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2164 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2165 (LIBES): Use it.
2166 * callproc.c (Fcall_process):
2167 * process.c (create_process):
2168 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2169 Use pthread_sigmask, not sigprocmask.
123403e4 2170
1b854618
JD
21712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2172
2173 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2174 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2175 wrong (Bug#8591).
2176
3fe4b549
JD
21772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2178
0ce7e563
JD
2179 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2180 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2181 (xg_hide_tooltip): Fix comment.
2182
3fe4b549
JD
2183 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2184 in registerServicesMenuSendTypes.
2185 (validRequestorForSendType): Don't check ns_return_types.
2186
2187 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2188 ns_return_type.
2189
5df75e47
JR
21902011-07-08 Jason Rumney <jasonr@gnu.org>
2191
2192 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2193 frame struct members of non-existent frames (Bug#6284).
2194
699c10bd
JD
21952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2196
4393663b
JD
2197 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2198 variable firstTime not needed on OSX >= 10.6.
2199 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2200 >= 10.5. Use setKnobProportion, setDoubleValue.
2201
2202 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2203 (MAC_OS_X_VERSION_10_5): Define if not defined.
2204 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2205 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2206 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2207
2208 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2209 cString and lossyCString on OSX >= 10.4
2210
2211 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2212 sizeToFit on OSX >= 10.2.
2213
2214 * nsimage.m (allocInitFromFile): Don't use deprecated method
2215 bestRepresentationForDevice on OSX >= 10.6.
2216
2217 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2218 to avoid warning.
2219
2220 * emacs.c: Declare unexec_init_emacs_zone.
2221
a63e0781
JD
2222 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2223
699c10bd
JD
2224 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2225
2226 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2227 on svcsMenu (Bug#8842).
2228
2229 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2230 ns_return_types.
2231 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2232
2233 * nsterm.m (QUTF8_STRING): Declare.
2234 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2235 (validRequestorForSendType): Return type is (id).
2236 Change indexOfObjectIdenticalTo to indexOfObject.
2237 Check if we have local selection before returning self (Bug#8842).
2238 (writeSelectionToPasteboard): Put local selection into paste board
2239 if we have a local selection (Bug#8842).
2240 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2241
2242 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2243 (ns_get_local_selection): Declare.
2244
54e10184
LMI
22452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2246
9888ff71
LMI
2247 * keymap.c (describe_map_tree): Don't insert a double newline at
2248 the end of the buffer (bug#1169) and return whether we inserted
2249 something.
2250
54e10184
LMI
2251 * callint.c (Fcall_interactively): Change "reading args" to
2252 "providing args" to try to clarify what it does (bug#1010).
2253
15fa4783
KH
22542011-07-07 Kenichi Handa <handa@m17n.org>
2255
2256 * composite.c (composition_compute_stop_pos): Ignore a static
2257 composition starting before CHARPOS (Bug#8915).
2258
2259 * xdisp.c (handle_composition_prop): Likewise.
2260
a8815b00
EZ
22612011-07-07 Eli Zaretskii <eliz@gnu.org>
2262
2263 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2264 (Bug#9015)
2265
ef7b981d 22662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2267
2268 * character.h (unicode_category_t): New enum type.
2269
2270 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2271 (Qchar_code_property_table): New variable.
2272 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2273 (UNIPROP_COMPRESSED_FORM_P): New macros.
2274 (char_table_ascii): Uncompress the compressed values.
2275 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2276 Uncompress the compressed values.
ac389d0c 2277 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2278 (char_table_ref_and_range): Uncompress the compressed values.
2279 (sub_char_table_set): New arg is_uniprop. Callers changed.
2280 Uncompress the compressed values.
2281 (sub_char_table_set_range): Args changed. Callers changed.
2282 (char_table_set_range): Adjuted for the above change.
2283 (map_sub_char_table): Delete args default_val and parent. Add arg
2284 top. Give decoded values to a Lisp function.
640c8776 2285 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2286 values to a Lisp function. Gcpro more variables.
2287 (uniprop_table_uncompress)
2288 (uniprop_decode_value_run_length): New functions.
2289 (uniprop_decoder, uniprop_decoder_count): New variables.
2290 (uniprop_get_decoder, uniprop_encode_value_character)
2291 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2292 New functions.
2293 (uniprop_encoder, uniprop_encoder_count): New variables.
2294 (uniprop_get_encoder, uniprop_table)
2295 (Funicode_property_table_internal, Fget_unicode_property_internal)
2296 (Fput_unicode_property_internal): New functions.
2297 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2298 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2299 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2300 char-code-property-alist.
2301
640c8776 2302 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2303 Vunicode_category_table.
2304
640c8776 2305 * font.c (font_range): Adjust for the change of
c805dec0
KH
2306 Vunicode_category_table.
2307
76b397fb
DN
23082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2309
2310 * m/iris4d.h: Remove file, move contents ...
2311 * s/irix6-5.h: ... here.
2312
22b4128e
PE
23132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2316 * alloc.c (mark_buffer):
2317 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2318 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2319 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2320 This isn't true in general, and it's particularly not true
2321 if Emacs is configured with --with-wide-int.
2322 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2323 New macros, used in the buffer.c change.
2324
869795d6
JD
23252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * xsettings.c: Use both GConf and GSettings if both are available.
2328 (store_config_changed_event): Add comment.
2329 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2330 (store_tool_bar_style_changed): New functions.
5e617bc2 2331 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2332 (struct xsettings): Move font inside HAVE_XFT.
2333 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2334 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2335 Move inside HAVE_XFT.
640c8776 2336 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2337 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2338 also.
2339 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2340 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2341 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2342 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2343 (parse_settings): Move check for font inside HAVE_XFT.
2344 (read_settings, apply_xft_settings): Add comment.
2345 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2346 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2347 call store_font_name_changed.
2348 (xft_settings_event): Add comment.
2349 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2350 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2351 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2352 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2353 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2354 (xsettings_get_system_font, xsettings_get_system_normal_font):
2355 Add comment.
869795d6 2356
d8ed26bd
PE
23572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 Random fixes. E.g., (random) never returned negative values.
2360 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2361 subseconds part to the entropy, as that's a bit more random.
2362 Prefer signed to unsigned, since the signedness doesn't matter and
2363 in general we prefer signed. When given a limit, use a
2364 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2365 latter isn't right if USE_2_TAGS_FOR_INTS.
2366 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2367 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2368
cabf1cac
SM
23692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 * textprop.c (text_property_stickiness):
2372 Obey Vtext_property_default_nonsticky.
2373 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2374 * w32fns.c (syms_of_w32fns):
2375 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2376
6e9b2be9
PE
23772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2380 This is more efficient than Ffile_directory_p and avoids a minor race.
2381
90186c68
LMI
23822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2383
7c301272
LMI
2384 * buffer.c (Foverlay_put): Say what the return value is
2385 (bug#7835).
2386
c4f2d8d4
LMI
2387 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2388 is a directory before asking whether to use the file name
2389 (bug#7564).
ad637907
LMI
2390 (barf_or_query_if_file_exists): Make the "File is a directory"
2391 error be more correct.
c4f2d8d4 2392
90186c68
LMI
2393 * fns.c (Frequire): Remove the mention of the .gz files, since
2394 that's installation-specific, but keep the mention of
2395 `get-load-suffixes'.
2396
da64016e
PE
23972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2400 Report string overflow if the output is too long.
2401
7d47b580
JB
24022011-07-04 Juanma Barranquero <lekktu@gmail.com>
2403
a555cb87
JB
2404 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2405 (syms_of_gnutls): Remove duplicate DEFSYM for
2406 Qgnutls_bootprop_verify_hostname_error, an error for
2407 Qgnutls_bootprop_verify_error (which is no longer used).
2408
7d47b580
JB
2409 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2410 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2411 Also (re)move comments that are misplaced or no longer relevant.
2412
1e49bfab
LMI
24132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2414
2415 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2416
1485f4c0
CY
24172011-07-03 Chong Yidong <cyd@stupidchicken.com>
2418
2419 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2420 and background color parameters if they have been changed.
2421
a9ab721e
LMI
24222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2423
2424 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2425
cf7cff57
PE
24262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2427
2e13213d
PE
2428 * xsettings.c (SYSTEM_FONT): Define only when used.
2429 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2430
cf7cff57
PE
2431 * keymap.c (access_keymap_1): Now static.
2432
7a8e04f7
CY
24332011-07-02 Chong Yidong <cyd@stupidchicken.com>
2434
2435 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2436 leave any prefix arg for the up event (Bug#1586).
2437
61352f62
LMI
24382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2439
69bb1ef7
LMI
2440 * lread.c (syms_of_lread): Mention single symbols defined by
2441 `defvar' or `defconst' (bug#7154).
2442
61352f62 2443 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2444 (Frequire): Mention get-load-suffixes.
61352f62 2445
28545e04
MR
24462011-07-02 Martin Rudalics <rudalics@gmx.at>
2447
2448 * window.h (window): Remove clone_number slot.
2449 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2450 Remove.
2451 (make_parent_window, make_window, saved_window)
2452 (Fset_window_configuration, save_window_save): Don't deal with
2453 clone numbers.
2454 * buffer.c (Qclone_number): Remove declaration.
2455 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2456
3349e122
SM
24572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2458
2459 Add multiple inheritance to keymaps.
2460 * keymap.c (Fmake_composed_keymap): New function.
2461 (Fset_keymap_parent): Simplify.
2462 (fix_submap_inheritance): Remove.
2463 (access_keymap_1): New function extracted from access_keymap to handle
2464 embedded parents and handle lists of maps.
2465 (access_keymap): Use it.
2466 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2467 (Fcopy_keymap): Handle embedded parents.
2468 (Fcommand_remapping, define_as_prefix): Simplify.
2469 (Fkey_binding): Simplify.
2470 (syms_of_keymap): Move minibuffer-local-completion-map,
2471 minibuffer-local-filename-completion-map,
2472 minibuffer-local-must-match-map, and
2473 minibuffer-local-filename-must-match-map to Elisp.
2474 (syms_of_keymap): Defsubr make-composed-keymap.
2475 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2476 (parse_menu_item): Trivial simplification.
2477
3279eb87
GM
24782011-07-01 Glenn Morris <rgm@gnu.org>
2479
2480 * Makefile.in (SETTINGS_LIBS): Fix typo.
2481
4550efdf
KI
24822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2483
2484 * coding.c (Fencode_coding_string): Record the last coding system
2485 used, as the function doc string says (bug#8738).
2486
0949d2b6
JD
24872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2488
2489 * xsettings.c (store_monospaced_changed): Take new font as arg and
2490 check for change against current_mono_font.
2491 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2492 (emacs_settings_constructor, emacs_settings_get_property)
2493 (emacs_settings_set_property, emacs_settings_class_init)
2494 (emacs_settings_init, gsettings_obj): Remove.
2495 (something_changedCB): New function for HAVE_GSETTINGS.
2496 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2497 with value as argument.
2498 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2499 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2500 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2501 "changed".
2502
2503 * xgselect.c: Add defined (HAVE_GSETTINGS).
2504 (xgselect_initialize): Ditto.
2505
2506 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2507 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2508 xg_select.
2509
bbc6b304
PE
25102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2511
2512 * eval.c (struct backtrace): Simplify and port the data structure.
2513 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2514 signed bit field, as this assumption is not portable and it makes
2515 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2516 "char debug_on_exit : 1" as this is not portable either; instead,
2517 use the portable "unsigned int debug_on_exit : 1". Remove unused
2518 member evalargs. Remove obsolete comments about cc bombing out.
2519
9851bfc5
JD
25202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2521
51bb811f 2522 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2523 Let HAVE_GSETTINGS override HAVE_GCONF.
2524 (store_monospaced_changed): New function.
2525 (EMACS_SETTINGS): A new type derived from GObject to handle
2526 GSettings notifications.
2527 (emacs_settings_constructor, emacs_settings_get_property)
2528 (emacs_settings_set_property, emacs_settings_class_init):
2529 New functions.
2530 (gsettings_client, gsettings_obj): New variables.
2531 (GSETTINGS_SCHEMA): New define.
2532 (something_changedCB): Call store_monospaced_changed.
2533 (init_gsettings): New function.
2534 (xsettings_initialize): Call init_gsettings.
2535 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2536 to NULL.
2537
640c8776 2538 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2539 GCONF_CFLAGS/LIBS.
2540
5386012d
MR
25412011-06-29 Martin Rudalics <rudalics@gmx.at>
2542
2543 * window.c (resize_root_window, grow_mini_window)
2544 (shrink_mini_window): Rename Qresize_root_window to
2545 Qwindow_resize_root_window and Qresize_root_window_vertically to
2546 Qwindow_resize_root_window_vertically.
2547
f13e0b08
PE
25482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2551
94515237
JB
25522011-06-27 Juanma Barranquero <lekktu@gmail.com>
2553
2554 * makefile.w32-in: Redesign dependencies so they reflect more
2555 clearly which files are directly included by each source file,
2556 and not through other includes.
2557
e43b6e43
MR
25582011-06-27 Martin Rudalics <rudalics@gmx.at>
2559
2560 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2561 (sort_overlays, overlay_strings): When an overlay's clone number
2562 matches the window's clone number process the overlay even if
2563 the overlay's window property doesn't match the current window.
2564
d68443dc
MR
2565 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2566 (Fwindow_hchild): Rename to Fwindow_left_child.
2567 (Fwindow_next): Rename to Fwindow_next_sibling.
2568 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2569 (resize_window_check): Rename to window_resize_check.
2570 (resize_window_apply): Rename to window_resize_apply.
2571 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2572 (Fdelete_other_windows_internal, resize_frame_windows)
2573 (Fsplit_window_internal, Fdelete_window_internal)
2574 (grow_mini_window, shrink_mini_window)
2575 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2576
c7e73be5
JD
25772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2578
2579 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2580 (emacs_fixed_set_min_size): Remove.
2581 (emacs_fixed_new): Take frame as argument.
2582
2583 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2584 (_EmacsFixedPrivate): Remove minwidth/height.
2585 Add struct frame *f.
2586 (emacs_fixed_init): Initialize priv->f.
2587 (get_parent_class, emacs_fixed_set_min_size): Remove.
2588 (emacs_fixed_new): Set priv->f to argument.
2589 (emacs_fixed_get_preferred_width)
2590 (emacs_fixed_get_preferred_height): Use min_width/height from
2591 frames size_hint to set minimum and natural (Bug#8919).
2592 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2593 and use min_width/height from frames size_hint to set
2594 min_width/height (Bug#8919).
2595
2596 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2597 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2598 Fix indentation.
c7e73be5 2599
cf99dcf8
EZ
26002011-06-26 Eli Zaretskii <eliz@gnu.org>
2601
2602 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2603 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2604 called at ZV.
2605
029529ac
CY
26062011-06-26 Chong Yidong <cyd@stupidchicken.com>
2607
2608 * process.c (wait_reading_process_output): Bypass select if
2609 waiting for a cell while ignoring keyboard input, and input is
2610 pending. Suggested by Jan Djärv (Bug#8869).
2611
7a7ef429
PE
26122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 Use gnulib's dup2 module instead of rolling our own.
2615 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2616
11fdef7d 26172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2618
2619 * dispnew.c (scrolling_window): Before scrolling, turn off a
2620 mouse-highlight in the window being scrolled.
2621
cd3520a4
JB
26222011-06-24 Juanma Barranquero <lekktu@gmail.com>
2623
2624 Move DEFSYM to lisp.h and use everywhere.
2625
2626 * character.h (DEFSYM): Move declaration...
2627 * lisp.h (DEFSYM): ...here.
2628
2629 * gnutls.c:
2630 * minibuf.c:
2631 * w32menu.c:
2632 * w32proc.c:
2633 * w32select.c: Don't include character.h.
2634
2635 * alloc.c (syms_of_alloc):
2636 * buffer.c (syms_of_buffer):
2637 * bytecode.c (syms_of_bytecode):
2638 * callint.c (syms_of_callint):
2639 * casefiddle.c (syms_of_casefiddle):
2640 * casetab.c (init_casetab_once):
2641 * category.c (init_category_once, syms_of_category):
2642 * ccl.c (syms_of_ccl):
2643 * cmds.c (syms_of_cmds):
2644 * composite.c (syms_of_composite):
2645 * dbusbind.c (syms_of_dbusbind):
2646 * dired.c (syms_of_dired):
2647 * dispnew.c (syms_of_display):
2648 * doc.c (syms_of_doc):
2649 * editfns.c (syms_of_editfns):
2650 * emacs.c (syms_of_emacs):
2651 * eval.c (syms_of_eval):
2652 * fileio.c (syms_of_fileio):
2653 * fns.c (syms_of_fns):
2654 * frame.c (syms_of_frame):
2655 * fringe.c (syms_of_fringe):
2656 * insdel.c (syms_of_insdel):
2657 * keymap.c (syms_of_keymap):
2658 * lread.c (init_obarray, syms_of_lread):
2659 * macros.c (syms_of_macros):
2660 * msdos.c (syms_of_msdos):
2661 * print.c (syms_of_print):
2662 * process.c (syms_of_process):
2663 * search.c (syms_of_search):
2664 * sound.c (syms_of_sound):
2665 * syntax.c (init_syntax_once, syms_of_syntax):
2666 * terminal.c (syms_of_terminal):
2667 * textprop.c (syms_of_textprop):
2668 * undo.c (syms_of_undo):
2669 * w32.c (globals_of_w32):
2670 * window.c (syms_of_window):
2671 * xdisp.c (syms_of_xdisp):
2672 * xfaces.c (syms_of_xfaces):
2673 * xfns.c (syms_of_xfns):
2674 * xmenu.c (syms_of_xmenu):
2675 * xsettings.c (syms_of_xsettings):
2676 * xterm.c (syms_of_xterm): Use DEFSYM.
2677
4228cf16
TZ
26782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2679
cd3520a4 2680 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2681
7fcccf1e
PE
26822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2683
7efb4e0e
PE
2684 Integer and buffer overflow fixes (Bug#8873).
2685
ff5844ad
PE
2686 * print.c (printchar, strout): Check for string overflow.
2687 (PRINTPREPARE, printchar, strout):
2688 Don't set size unless allocation succeeds.
2689
90532f02
PE
2690 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2691 for sizes. Check for string overflow more accurately.
2692 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2693
6d84508d
PE
2694 * macros.c: Integer and buffer overflow fixes.
2695 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2696 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2697 Use ptrdiff_t, not int, for sizes.
2698 Don't increment bufsize until after realloc succeeds.
2699 Check for size-calculation overflow.
2700 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2701
437b2cb4
PE
2702 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2703
8b9ac8b4
PE
2704 * lread.c: Integer overflow fixes.
2705 (read_integer): Radix is now EMACS_INT, not int,
2706 to improve quality of diagnostics for out-of-range radices.
2707 Calculate buffer size correctly for out-of-range radices.
2708 (read1): Check for integer overflow in radices, and in
2709 read-circle numbers.
82cb60d3
PE
2710 (read_escape): Avoid int overflow.
2711 (Fload, openp, read_buffer_size, read1)
2712 (substitute_object_recurse, read_vector, read_list, map_obarray):
2713 Use ptrdiff_t, not int, for sizes.
2714 (read1): Use EMACS_INT, not int, for sizes.
20270765 2715 Check for size overflow.
8b9ac8b4 2716
7fcccf1e
PE
2717 * image.c (cache_image): Check for size arithmetic overflow.
2718
bfbbd7e7
PE
2719 * lread.c: Integer overflow issues.
2720 (saved_doc_string_size, saved_doc_string_length)
2721 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2722 Now ptrdiff_t, not int.
2723 (read1): Don't assume doc string length fits in int. Check for
2724 out-of-range doc string lengths.
2725 (read_list): Don't assume file position fits in int.
39019e54 2726 (read_escape): Check for hex character overflow.
bfbbd7e7 2727
4e323265
LL
27282011-06-22 Leo Liu <sdl.web@gmail.com>
2729
2730 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2731 Move to minibuffer.el.
2732
85fece3e
PE
27332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2734
20b84ce9 2735 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2736 The following patches are for when GLYPH_DEBUG && !XASSERT.
2737 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2738 * dispnew.c (flush_stdout):
2739 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2740 Mark as externally visible.
2741 * dispnew.c (check_window_matrix_pointers): Now static.
2742 * dispnew.c (window_to_frame_vpos):
2743 * xfns.c (unwind_create_frame):
2744 * xterm.c (x_check_font): Remove unused local.
2745 * scroll.c (CHECK_BOUNDS):
2746 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2747 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2748 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2749 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2750 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2751 Now static.
2752 (debug_method_add): Use va_list and vsprintf rather than relying
2753 on undefined behavior with wrong number of arguments.
2754 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2755 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2756 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2757 since we're not interested in debugging glyphs with old libraries.
2758 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2759 GCC 4.6.0's static checking.
2760
0766b489
PE
27612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2762
31fd4b32
PE
2763 Integer overflow and signedness fixes (Bug#8873).
2764 A few related buffer overrun fixes, too.
2765
b79e8648
PE
2766 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2767
0766b489
PE
2768 * dispextern.h (struct face.stipple):
2769 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2770 (x_bitmap_mask, x_allocate_bitmap_record)
2771 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2772 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2773 (x_create_bitmap_from_xpm_data):
2774 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2775 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2776 (.bitmaps_last):
2777 * xfaces.c (load_pixmap):
2778 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2779 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2780 (.bitmaps_last, struct x_output.icon_bitmap):
2781 Use ptrdiff_t, not int, for bitmap indexes.
2782 (x_allocate_bitmap_record): Check for size overflow.
2783 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2784
b081724f
PE
2785 Use ptrdiff_t, not int, for overlay counts.
2786 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2787 * editfns.c (overlays_around, get_pos_property):
2788 * textprop.c (get_char_property_and_overlay):
2789 * xdisp.c (next_overlay_change, note_mouse_highlight):
2790 * xfaces.c (face_at_buffer_position):
21514da7
PE
2791 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2792 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2793 (Fnext_overlay_change, Fprevious_overlay_change)
2794 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2795 Use ptrdiff_t, not int, for sizes.
21514da7 2796 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2797
3de73e5e
PE
2798 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2799
2606c57b
PE
2800 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2801 (x_session_initialize): Do not assume string length fits in int.
2802
aaafe47a
PE
2803 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2804 This is unlikely, but can occur if DPI is outlandish.
2805
2674ddc8 2806 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2807 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2808
28154962
PE
2809 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2810 * xrdb.c (magic_file_p, search_magic_path):
2811 Omit last arg SUFFIX; it was always 0. All callers changed.
2812 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2813
7de51af5
PE
2814 * xfont.c (xfont_match): Avoid need for strlen.
2815
25ed6cc3
PE
2816 * xfns.c: Don't assume strlen fits in int.
2817 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2818
4eab31dd
PE
2819 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2820 not unsigned long, as we prefer signed integers. All callers changed.
2821 Detect integer overflow in repeat count.
2822 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2823 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2824
171e2a58
PE
2825 * termcap.c: Don't assume sizes fit in int and never overflow.
2826 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2827 (gobble_line): Check for size-calculation overflow.
2828
ad39faca 2829 * minibuf.c (Fread_buffer):
6e5bb2dc 2830 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2831 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2832 Don't assume string length fits in int.
2833
52c61c22 2834 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2835 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2836
b5b8c9e5
PE
2837 * font.c: Don't assume string length fits in int.
2838 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2839 Use ptrdiff_t, not int.
ccd6111c
PE
2840 (font_intern_prop): Don't assume string length fits in int.
2841 Don't assume integer property fits in fixnum.
2842 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2843
882f0d81 2844 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2845 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2846 Reformulate so as not to need the command string.
2847 Invoke gzip -cd rather than gunzip, as it's more portable.
2848 (lock_info_type, lock_file_1, lock_file):
2849 Don't assume pid_t and time_t fit in unsigned long.
2850 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2851 (current_lock_owner): Prefer signed type for sizes.
2852 Use memcpy, not strncpy, where memcpy is what is really wanted.
2853 Don't assume (via atoi) that time_t and pid_t fit in int.
2854 Check for time_t and/or pid_t out of range, e.g., via a network share.
2855 Don't alloca where an auto var works fine.
2856
93f4cf88
PE
2857 * fileio.c: Fix some integer overflow issues.
2858 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2859 Don't assume string length fits in int.
2860 (directory_file_name): Don't assume string length fits in long.
2861 (make_temp_name): Don't assume pid fits in int, or that its print
2862 length is less than 20.
2863
f3e92b69
PE
2864 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2865
1bfdaf10
PE
2866 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2867
35016e9a
PE
2868 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2869
3d1e65a1
PE
2870 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2871 We prefer signed integers, even for size calculations.
2872
0b963a93
PE
2873 * emacs.c: Don't assume string length fits in 'int'.
2874 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2875 (main): Don't invoke strlen when not needed.
2876
573f4b54
PE
2877 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2878 (XD_DEBUG_MESSAGE): Don't waste a byte.
2879
989f33ba
PE
2880 * callproc.c (getenv_internal_1, getenv_internal)
2881 (Fgetenv_internal):
965d34eb
PE
2882 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2883
e4d29b33
PE
2884 * lread.c (invalid_syntax): Omit length argument.
2885 All uses changed. This doesn't fix a bug, but it simplifies the
2886 code away from its former Hollerith-constant appearance, and it's
2887 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2888 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2889
eb49b136
PE
2890 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2891 This didn't break anything, but it didn't help either.
2892 It's confusing to put a bogus integer in a place where the actual
2893 value does not matter.
9f62aeb1 2894 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2895 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2896
15375a22
PE
2897 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2898 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2899 implementation.
b61cc01c
PE
2900 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2901 We prefer signed types, and the value cannot exceed the EMACS_INT
2902 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2903 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2904 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2905 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2906
53b2623d
PE
2907 * indent.c (sane_tab_width): New function.
2908 (current_column, scan_for_column, Findent_to, position_indentation)
2909 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2910 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2911
51cab52b 2912 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2913
f2ed8a70
PE
2914 * lisp.h (lint_assume): New macro.
2915 * composite.c (composition_gstring_put_cache):
2916 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2917
abe80cc6
PE
2918 * editfns.c, insdel.c:
2919 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2920
b02c740e
PE
2921 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2922
ebc96716
PE
2923 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2924
b4e50fa0 2925 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2926 Use much-faster test for byte-length change.
311d5d7c 2927 Don't assume string byte-length fits in 'int'.
a4cf38e4 2928 Check that character arg fits in 'int'.
85461888 2929 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2930
c0c1ee9f
PE
2931 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2932
a498d7f4
PE
2933 * fns.c (concat): Catch string overflow earlier.
2934 Do not rely on integer wraparound.
2935
51cab52b
PE
2936 * dispextern.h (struct it.overlay_strings_charpos)
2937 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2938 * xdisp.c (forward_to_next_line_start)
2939 (back_to_previous_visible_line_start)
2940 (reseat_at_next_visible_line_start, next_element_from_buffer):
2941 Don't arbitrarily truncate the value of 'selective' to int.
2942
76031fad
PE
2943 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2944
5eb55db9
PE
2945 * composite.c: Don't truncate sizes to 'int'.
2946 (composition_gstring_p, composition_reseat_it)
2947 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2948 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2949 not EMACS_UINT, for indexes.
5eb55db9 2950
0703a717
PE
2951 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2952
d6202519
PE
2953 * buffer.c: Include <verify.h>.
2954 (struct sortvec.priority, struct sortstr.priority):
8961a454 2955 Now EMACS_INT, not int.
c20998a7 2956 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2957 (struct sortstr.size, record_overlay_string)
2958 (struct sortstrlist.size, struct sortlist.used):
2959 Don't truncate size to int.
2960 (record_overlay_string): Check for size-calculation overflow.
d6202519 2961 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2962
d5a19415
JM
29632011-06-22 Jim Meyering <meyering@redhat.com>
2964
029529ac 2965 Don't leak an XBM-image-sized buffer
d5a19415
JM
2966 * image.c (xbm_load): Free the image buffer after using it.
2967
a9041e6c
PE
29682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 Port to Sun C.
2971 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2972 that Sun C diagnosed.
2973 * fns.c (secure_hash): Fix pointer signedness issue.
2974 * intervals.c (static_offset_intervals): New function.
2975 (offset_intervals): Use it.
2976
7f3f739f
LL
29772011-06-21 Leo Liu <sdl.web@gmail.com>
2978
2979 * deps.mk (fns.o):
2980 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2981 sha512.h.
2982
2983 * fns.c (secure_hash): Rename from crypto_hash_function and change
2984 the first arg to accept symbols.
5b66d427 2985 (Fsecure_hash): New primitive.
7f3f739f
LL
2986 (syms_of_fns): New symbols.
2987
76147d94
DD
29882011-06-20 Deniz Dogan <deniz@dogan.se>
2989
2990 * process.c (Fset_process_buffer): Clarify return value in
2991 docstring.
2992
7d7d0045
CY
29932011-06-18 Chong Yidong <cyd@stupidchicken.com>
2994
2995 * dispnew.c (add_window_display_history): Use BVAR.
2996
2997 * xdisp.c (debug_method_add): Use BVAR.
2998 (check_window_end, dump_glyph_matrix, dump_glyph)
2999 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3000
3001 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3002 Likewise.
3003
3004 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3005 check till after the cache is created in init_frame_faces.
3006
ff2bc410
SM
30072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3008
3009 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3010
28177add
PE
30112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3012
dd3482fe
PE
3013 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3014 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3015 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3016
393d71f3 3017 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3018 * fileio.c (Finsert_file_contents):
3019 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3020 Remove the old (too-loose) buffer overflow checks.
3021 They weren't needed, since make_gap checks for buffer overflow.
3022 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3023 The old code merely checked for Emacs fixnum overflow, and relied
3024 on undefined (wraparound) behavior. The new code avoids undefined
3025 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3026
2e6813b0 3027 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3028 Tune. Don't use wider integers than needed. Don't use alloca.
3029 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3030
599a9e4f
PE
3031 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3032
99561444
PE
3033 * insdel.c, lisp.h (buffer_overflow): New function.
3034 (insert_from_buffer_1, replace_range, replace_range_2):
3035 * insdel.c (make_gap_larger):
3036 * editfns.c (Finsert_char):
3037 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3038
28177add
PE
3039 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3040
e69dafad
PE
30412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3042
a7af7fde 3043 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3044
b1c46f02
PE
3045 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3046 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3047
e69dafad
PE
3048 * fileio.c: Don't assume EMACS_INT fits in off_t.
3049 (emacs_lseek): New static function.
3050 (Finsert_file_contents, Fwrite_region): Use it.
3051 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3052
566684ea
PE
3053 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3054
e6966cd6
PE
3055 * fns.c: Don't overflow int when computing a list length.
3056 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3057 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3058 truncation on 64-bit hosts. Check for QUIT every
3059 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3060 faster and is responsive enough.
3061 (Flength): Report an error instead of overflowing an integer.
3062 (Fsafe_length): Return a float if the value is not representable
3063 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3064 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3065 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3066
dd0b0efb
PE
3067 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3068 (header_size, word_size): New constants.
3069 (allocate_vectorlike): Don't check size overflow here.
3070 (allocate_vector): Check it here instead, since this is the only
3071 caller of allocate_vectorlike that could cause overflow.
3072 Check that the new vector's length is representable as a fixnum.
3073
86fe5cfe
PE
3074 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3075 The previous code was bogus. For example, next_almost_prime (32)
3076 returned 39, which is undesirable as it is a multiple of 3; and
3077 next_almost_prime (24) returned 25, which is a multiple of 5 so
3078 why was the code bothering to check for multiples of 7?
3079
80e88859
PE
3080 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3081
4a2f0ad6
PE
3082 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3083
f66c7cf8
PE
3084 Variadic C functions now count arguments with ptrdiff_t.
3085 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3086 Back then I didn't know that the Emacs coding style prefers signed int.
3087 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3088 were being counted with int, which may truncate counts on 64-bit
3089 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3090 * lisp.h (struct Lisp_Subr.function.aMANY)
3091 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3092 Arg counts are now ptrdiff_t, not size_t.
3093 All variadic functions and their callers changed accordingly.
3094 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3095 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3096 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3097 * callint.c (Fcall_interactively): Check arg count for overflow,
3098 to avoid potential buffer overrun. Use signed char, not 'int',
3099 for 'varies' array, so that we needn't bother to check its size
3100 calculation for overflow.
3101 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3102 * eval.c (apply_lambda):
3103 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3104 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3105 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3106
a1759b76
PE
3107 * callint.c (Fcall_interactively): Don't use index var as event count.
3108
d96be9fc
PE
3109 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3110 * mem-limits.h (SIZE): Remove; no longer used.
3111
a690a978 3112 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3113
578c21e6
PE
3114 Remove unnecessary casts.
3115 * xterm.c (x_term_init):
3116 * xfns.c (x_set_border_pixel):
3117 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3118 These aren't needed now that we assume ANSI C.
3119
96f53c6c
PE
3120 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3121 It's more likely to cause problems (due to unsigned overflow)
3122 than to cure them.
3123
83c77d31
PE
3124 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3125
ee2079f1
PE
3126 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3127
6da65536
PE
3128 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3129
7147c4a4
PE
3130 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3131
193e32d9
PE
3132 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3133
e5533da6
PE
3134 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3135
9910e595
PE
3136 GLYPH_CODE_FACE returns EMACS_INT, not int.
3137 * dispextern.h (merge_faces):
3138 * xfaces.c (merge_faces):
01103c44
PE
3139 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3140 Don't assume EMACS_INT fits in int.
9910e595 3141
2638320e
PE
3142 * character.h (CHAR_VALID_P): Remove unused parameter.
3143 * fontset.c, lisp.h, xdisp.c: All uses changed.
3144
045eb8d9
PE
3145 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3146
c1f134b5
PE
3147 * fns.c (concat): Minor tuning based on overflow analysis.
3148 This doesn't fix any bugs. Use int to hold character, instead
3149 of constantly refetching from Emacs object. Use XFASTINT, not
3150 XINT, for value known to be a character. Don't bother comparing
3151 a single byte to 0400, as it's always less.
3152
395fcb93 3153 * floatfns.c (Fexpt):
327eeec8
PE
3154 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3155
abbd3d23
PE
3156 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3157 for characters.
3158
684a03ef
PE
3159 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3160
0fed43f3
PE
3161 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3162 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3163 incorrectly succeed when S was a string, because 4294967386 was
3164 truncated before it was used.
3165
8fd02eb7
PE
3166 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3167 Otherwise, an out-of-range integer could cause undefined behavior
3168 on a 64-bit host.
3169
f8c86b69
PE
3170 * composite.c: Use int, not EMACS_INT, for characters.
3171 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3172 EMACS_INT, for values that are known to be in character range.
3173 This doesn't fix any bugs but is the usual style inside Emacs and
3174 may generate better code on 32-bit machines.
3175
34206dd2
PE
3176 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3177 This is for reasons similar to the recent CHAR_STRING fix.
3178 * charset.c (Fencode_char): Check that character arg is actually
3179 a character. Pass an int to ENCODE_CHAR.
3180 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3181 wider than 'int', as a compile-time check to prevent future regressions
3182 in this area.
3183
c5958d4c 3184 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3185
3186 Make sure a 64-bit char is never passed to CHAR_STRING.
3187 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3188 by silently ignoring the top 32 bits, allowing some values
3189 that were far too large to be valid characters.
3190 * character.h: Include <verify.h>.
3191 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3192 arguments are no wider than unsigned, as a compile-time check
3193 to prevent future regressions in this area.
3194 * data.c (Faset):
01103c44 3195 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3196 (Fsubst_char_in_region):
3197 * fns.c (concat):
3198 * xdisp.c (decode_mode_spec_coding):
3199 Adjust to CHAR_STRING's new requirement.
3200 * editfns.c (Finsert_char, Fsubst_char_in_region):
3201 * fns.c (concat): Check that character args are actually
3202 characters. Without this test, these functions did the wrong
3203 thing with wildly out-of-range values on 64-bit hosts.
3204
d37ca623
PE
3205 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3206 These casts should not be needed on 32-bit hosts, either.
3207 * keyboard.c (read_char):
3208 * lread.c (Fload): Remove casts to unsigned.
3209
ea204efb
PE
3210 * lisp.h (UNSIGNED_CMP): New macro.
3211 This fixes comparison bugs on 64-bit hosts.
3212 (ASCII_CHAR_P): Use it.
3213 * casefiddle.c (casify_object):
01103c44 3214 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3215 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3216 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3217 * dispextern.h (FACE_FROM_ID):
3218 * keyboard.c (read_char): Use UNSIGNED_CMP.
3219
41cb286c
PE
3220 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3221 not to EMACS_INT, to avoid GCC warning.
3222
4a1b9832
PE
3223 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3224
55daad71
PE
3225 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3226 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3227 isn't needed on 32-bit machines.
8f95c75c 3228
01103c44
PE
3229 * buffer.c (Fgenerate_new_buffer_name):
3230 Use EMACS_INT for count, not int.
0ceccced 3231 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3232
3233 * data.c (Qcompiled_function): Now static.
3234
c6f072e7
PE
3235 * window.c (window_body_lines): Now static.
3236
20ce5912
PE
3237 * image.c (gif_load): Rename local to avoid shadowing.
3238
9c4c5f81
PE
3239 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3240 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3241 * alloc.c (make_save_value): Integer argument is now of type
3242 ptrdiff_t, not int.
3243 (mark_object): Use ptrdiff_t, not int.
3244 * lisp.h (pD): New macro.
3245 * print.c (print_object): Use it.
3246
c0c5c8ae
PE
3247 * alloc.c: Use EMACS_INT, not int, to count objects.
3248 (total_conses, total_markers, total_symbols, total_vector_size)
3249 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3250 (total_free_floats, total_floats, total_free_intervals)
3251 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3252 Now EMACS_INT, not int. All uses changed.
3253 (Fgarbage_collect): Compute overall total using a double, so that
3254 integer overflow is less likely to be a problem. Check for overflow
3255 when converting back to an integer.
5a25e253
PE
3256 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3257 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3258 These were 'int' variables that could overflow on 64-bit hosts;
3259 they were never used, so remove them instead of repairing them.
211a0b2a 3260 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3261 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3262 Previously, this ceilinged at INT_MAX, but that doesn't work on
3263 64-bit machines.
e46bb31a 3264 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3265
c78baabf 3266 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3267 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3268 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3269 when a (possibly-narrower) signed value would do just as well.
3270 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3271
c9d624c6
PE
3272 * alloc.c: Catch some string size overflows that we were missing.
3273 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3274 for convenience in STRING_BYTES_MAX.
3275 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3276 The definition here is exact; the one in lisp.h was approximate.
3277 (allocate_string_data): Check for string overflow. This catches
3278 some instances we weren't catching before. Also, it catches
3279 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3280 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3281 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3282
c9d624c6
PE
3283 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3284 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3285 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3286
353032ce
PE
3287 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3288
2bccce07
PE
3289 * alloc.c (Fmake_string): Check for out-of-range init.
3290
0ac30604
SM
32912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3292
3293 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3294
c195f2de
JD
32952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3296
3297 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3298 xg_get_default_scrollbar_width.
3299
3300 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3301 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3302 (style_changed_cb): Call update_theme_scrollbar_width and call
3303 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3304 all frames (Bug#8505).
3305 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3306 Call gtk_window_set_resizable if HAVE_GTK3.
3307 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3308 and height if HAVE_GTK3 (Bug#8505).
3309 (scroll_bar_width_for_theme): New variable.
3310 (update_theme_scrollbar_width): New function.
3311 (xg_get_default_scrollbar_width): Move code to
3312 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3313 (xg_initialize): Call update_theme_scrollbar_width.
3314
3315 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3316
3317 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3318
e10ac9f1
MR
33192011-06-12 Martin Rudalics <rudalics@gmx.at>
3320
3321 * frame.c (make_frame): Call other_buffer_safely instead of
3322 other_buffer.
3323
3324 * window.c (temp_output_buffer_show): Call display_buffer with
3325 second argument Vtemp_buffer_show_specifiers and reset latter
3326 immediately after the call.
3327 (Vtemp_buffer_show_specifiers): New variable.
3328 (auto_window_vscroll_p, next_screen_context_lines)
3329 (Vscroll_preserve_screen_position): Remove leading asterisks from
3330 doc-strings.
3331
2d3c217e 33322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3333
7b7f97e8 3334 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3335 * buffer.c (Qclone_number): Remove for now, as it's unused.
3336 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3337 (record_buffer): Remove unused local.
3338 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3339 (set_frame_buffer_list): Remove; unused.
3340 * frame.h (other_visible_frames): Remove decl.
3341 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3342 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3343 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3344 if HAVE_GPM.
3345 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3346 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3347 Define only if HAVE_GPM.
3348 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3349 (update_hints_inhibit): Remove; never set. All uses removed.
3350 * widgetprv.h (emacsFrameClassRec): Remove decl.
3351 * window.c (delete_deletable_window): Now returns void, since it
3352 wasn't returning anything.
3353 (compare_window_configurations): Remove unused locals.
3354 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3355 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3356 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3357 the same widths as pointers. This follows up on the 2011-05-06 patch.
3358 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3359 * xterm.h: Likewise.
3360 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3361
1384b89e
JB
33622011-06-12 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * makefile.w32-in: Update dependencies.
3365 (LISP_H): Add lib/intprops.h.
3366
1100a63c
CY
33672011-06-11 Chong Yidong <cyd@stupidchicken.com>
3368
3369 * image.c (gif_load): Add animation frame delay to the metadata.
3370 (syms_of_image): Use DEFSYM. New symbol `delay'.
3371
6198ccd0
MR
33722011-06-11 Martin Rudalics <rudalics@gmx.at>
3373
3374 * window.c (delete_deletable_window): Re-add.
3375 (Fset_window_configuration): Rewrite to handle dead buffers and
3376 consequently deletable windows.
3377 (window_tree, Fwindow_tree): Remove. Supply functionality in
3378 window.el.
3379 (compare_window_configurations): Simplify code.
3380
b6e3633c
AS
33812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3382
1ab0dee5
AS
3383 * image.c (imagemagick_load_image): Fix type mismatch.
3384 (Fimagemagick_types): Likewise.
3385
b6e3633c
AS
3386 * window.h (replace_buffer_in_windows): Declare.
3387
9397e56f
MR
33882011-06-11 Martin Rudalics <rudalics@gmx.at>
3389
3390 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3391 Qclone_number. Remove external declaration of Qdelete_window.
3392 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3393 code.
640c8776
SM
3394 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3395 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3396 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3397 buffer list implementation.
3398 (other_buffer_safely): New function.
3399 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3400 calls to replace_buffer_in_windows and
3401 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3402 if allowed.
3403 (record_buffer): Inhibit quitting and rewrite using quittable
3404 functions. Run Qbuffer_list_update_hook if allowed.
3405 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3406 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3407 Move switch-to-buffer to window.el.
9397e56f
MR
3408 (bury-buffer): Move to window.el.
3409 (Vbuffer_list_update_hook): New variable.
3410
3411 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3412 section.
3413
3414 * window.h (resize_frame_windows): Move up in code.
3415 (Fwindow_frame): Remove EXFUN.
3416 (replace_buffer_in_all_windows): Remove prototype.
3417 (replace_buffer_in_windows_safely): Add prototype.
3418
3419 * window.c: Declare Qdelete_window static again. Move down
3420 declaration of select_count.
3421 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3422 (Fother_window): Move to window.el.
3423 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3424 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3425 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3426 window.el.
3427 (replace_buffer_in_windows): Implement by calling
3428 Qreplace_buffer_in_windows.
3429 (replace_buffer_in_all_windows): Remove with some functionality
3430 moved into replace_buffer_in_windows_safely.
3431 (replace_buffer_in_windows_safely): New function.
3432 (select_window_norecord, select_frame_norecord): Move in front
3433 of run_window_configuration_change_hook. Remove now obsolete
3434 declarations.
640c8776
SM
3435 (Fset_window_buffer): Rewrite doc-string.
3436 Call Qrecord_window_buffer.
9397e56f
MR
3437 (keys_of_window): Move binding for other-window to window.el.
3438
b50691aa
CY
34392011-06-11 Chong Yidong <cyd@stupidchicken.com>
3440
3441 * dispextern.h (struct image): Replace data member, whose int_val
3442 and ptr_val fields were not used by anything, with a single
3443 lisp_val object.
3444
3445 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3446 (gif_clear_image, gif_load, imagemagick_load_image)
3447 (gs_clear_image, gs_load): Callers changed.
3448
3f754b86
PE
34492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3450
cca69397
PE
3451 * buffer.h: Include <time.h>, for time_t.
3452 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3453
109e28d0
PE
3454 Fix minor problems found by static checking.
3455
60737f02
PE
3456 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3457
4b66faf3
PE
3458 Make identifiers static if they are not used in other modules.
3459 * data.c (Qcompiled_function, Qframe, Qvector):
3460 * image.c (QimageMagick, Qsvg):
3461 * minibuf.c (Qmetadata):
3462 * window.c (resize_window_check, resize_root_window): Now static.
3463 * window.h (resize_window_check, resize_root_window): Remove decls.
3464
109e28d0
PE
3465 * window.c (window_deletion_count, delete_deletable_window):
3466 Remove; unused.
46a4ce9e
PE
3467 (window_body_lines): Now static.
3468 (Fdelete_other_windows_internal): Mark vars as initialized.
3469 Make sure 'resize_failed' is initialized.
3470 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3471 (resize_window_apply): Remove unused local.
3472 * window.h (delete_deletable_window): Remove decl.
3473
109e28d0 3474 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3475 (imagemagick_load_image): Fix pointer signedness problem by changing
3476 last arg from unsigned char * to char *. All uses changed.
3477 Also, fix a local for similar reasons.
3478 Remove unused locals. Remove locals to avoid shadowing.
3479 (fn_rsvg_handle_free): Remove; unused.
3480 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3481 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3482
3f754b86
PE
3483 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3484
2547adb1
CY
34852011-06-10 Chong Yidong <cyd@stupidchicken.com>
3486
3487 * image.c (gif_load): Fix omitted cast error introduced by
3488 2011-06-06 change.
3489
2c8e37d4
MR
34902011-06-10 Martin Rudalics <rudalics@gmx.at>
3491
3492 * window.h (resize_proportionally, orig_total_lines)
3493 (orig_top_line): Remove from window structure.
3494 (set_window_height, set_window_width, change_window_heights)
3495 (Fdelete_window): Remove prototypes.
3496 (resize_frame_windows): Remove duplicate declaration.
3497
440a42e3
EZ
34982011-06-10 Eli Zaretskii <eliz@gnu.org>
3499
3500 * window.h (resize_frame_windows, resize_window_check)
3501 (delete_deletable_window, resize_root_window)
3502 (resize_frame_windows): Declare prototypes.
3503
3504 * window.c (resize_window_apply): Make definition be "static" to
3505 match the prototype.
3506
562dd5e9
MR
35072011-06-10 Martin Rudalics <rudalics@gmx.at>
3508
3509 * window.c: Remove declarations of Qwindow_size_fixed,
3510 window_min_size_1, window_min_size_2, window_min_size,
3511 size_window, window_fixed_size_p, enlarge_window, delete_window.
3512 Remove static from declaration of Qdelete_window, it's
3513 temporarily needed by Fbury_buffer.
3514 (replace_window): Don't assign orig_top_line and
3515 orig_total_lines.
3516 (Fdelete_window, delete_window): Remove. Window deletion is
3517 handled by window.el.
640c8776
SM
3518 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3519 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3520 (Fdelete_other_windows): Remove. Deleting other windows is
3521 handled by window.el.
3522 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3523 handled in window.el.
3524 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3525 Window minimum sizes are handled in window.el.
3526 (shrink_windows, size_window, set_window_height)
3527 (set_window_width, change_window_heights, window_height)
3528 (window_width, CURBEG, CURSIZE, enlarge_window)
3529 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3530 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3531 handled in window.el.
3532 (make_dummy_parent): Rename to make_parent_window and give it a
3533 second argument horflag.
3534 (make_window): Don't set resize_proportionally any more.
3535 (Fsplit_window): Remove. Windows are split in window.el.
3536 (save_restore_action, save_restore_orig_size)
3537 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3538 Resize mini windows in window.el.
3539 (grow_mini_window, shrink_mini_window): Implement by calling
3540 Qresize_root_window_vertically, resize_window_check and
3541 resize_window_apply.
640c8776
SM
3542 (saved_window, Fset_window_configuration, save_window_save):
3543 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3544 resize_proportionally.
3545 (window_min_height, window_min_width): Move to window.el.
3546 (keys_of_window): Move bindings for delete-other-windows,
3547 split-window, delete-window and enlarge-window to window.el.
3548
3549 * buffer.c: Temporarily extern Qdelete_window.
3550 (Fbury_buffer): Temporarily call Qdelete_window instead of
3551 Fdelete_window (Fbury_buffer will move to window.el soon).
3552
3553 * frame.c (set_menu_bar_lines_1): Remove code handling
3554 orig_top_line and orig_total_lines.
3555
3556 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3557 set_window_height but set heights directly.
3558 (change_frame_size_1): Use resize_frame_windows.
3559
3560 * xdisp.c (init_xdisp): Don't use set_window_height but set
3561 heights directly.
3562
640c8776
SM
3563 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3564 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3565 run_window_configuration_change_hook.
3566
3567 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3568 instead of change_window_heights and run
3569 run_window_configuration_change_hook.
3570
1a13852e
MR
35712011-06-09 Martin Rudalics <rudalics@gmx.at>
3572
3573 * window.c (replace_window): Rename second argument REPLACEMENT to
3574 NEW. New third argument SETFLAG. Rewrite.
3575 (delete_window, make_dummy_parent): Call replace_window with
3576 third argument 1.
3577 (window_list_1): Move down in code.
3578 (run_window_configuration_change_hook): Move set_buffer part
3579 before select_frame_norecord part in order to unwind correctly.
3580 Rename count1 to count.
3581 (recombine_windows, delete_deletable_window, resize_root_window)
3582 (Fdelete_other_windows_internal)
3583 (Frun_window_configuration_change_hook, make_parent_window)
3584 (resize_window_check, resize_window_apply, Fresize_window_apply)
3585 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3586 (Fdelete_window_internal, Fresize_mini_window_internal):
3587 New functions.
1a13852e
MR
3588 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3589
f3d1777e
MR
35902011-06-08 Martin Rudalics <rudalics@gmx.at>
3591
496e208e
MR
3592 * window.h (window): Add some new members to window structure -
3593 normal_lines, normal_cols, new_total, new_normal, clone_number,
3594 splits, nest, prev_buffers, next_buffers.
3595 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3596 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3597
f3d1777e
MR
3598 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3599 Remove.
496e208e
MR
3600 (make_dummy_parent): Set new members of windows structure.
3601 (make_window): Move down in code. Handle new members of window
3602 structure.
3603 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3604 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3605 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3606 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3607 (Fset_window_next_buffers, Fset_window_clone_number):
3608 New functions.
496e208e
MR
3609 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3610 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3611 Doc-string fixes.
3612 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3613 Argument WINDOW can be now internal window too.
3614 (Fwindow_use_time): Move up in code.
3615 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3616 Rewrite doc-string.
3617 (Fset_window_configuration, saved_window)
3618 (Fcurrent_window_configuration, save_window_save): Handle new
3619 members of window structure.
b9e809c2
MR
3620 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3621 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3622 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3623 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3624 Qget_mru_window, Qresize_root_window,
3625 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3626 Qauto_buffer_name; staticpro them.
f3d1777e 3627
abde8f8c
MR
36282011-06-07 Martin Rudalics <rudalics@gmx.at>
3629
3630 * window.c (Fwindow_total_size, Fwindow_left_column)
3631 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3632 (Fwindow_list_1): New functions.
3633 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3634 (Fwindow_width, Fscroll_left, Fscroll_right):
3635 Use window_body_cols instead of window_box_text_cols.
3636 (delete_window, Fset_window_configuration):
3637 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3638 (delete_all_subwindows): Take a window as argument and not a
3639 structure. Rewrite.
190b47e6
MR
3640 (window_loop): Remove handling of GET_LRU_WINDOW and
3641 GET_LARGEST_WINDOW.
3642 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3643
3644 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3645 window_box_text_cols. delete_all_subwindows now takes a
3646 Lisp_Object as argument.
abde8f8c 3647
640c8776
SM
3648 * indent.c (compute_motion, Fcompute_motion):
3649 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3650
fa8a67e6
MR
3651 * frame.c (delete_frame): Call delete_all_subwindows with root
3652 window as argument.
3653
a54e3482
DC
36542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3655
3656 * fns.c (Fputhash): Document return value.
3657
60002bf5
CY
36582011-06-06 Chong Yidong <cyd@stupidchicken.com>
3659
3660 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3661
0c671da6 36622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3663
b862a52a 3664 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3665
be44ca6c
PE
3666 Check for overflow when converting integer to cons and back.
3667 * charset.c (Fdefine_charset_internal, Fdecode_char):
3668 Use cons_to_unsigned to catch overflow.
3669 (Fencode_char): Use INTEGER_TO_CONS.
3670 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3671 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3672 * data.c (long_to_cons, cons_to_long): Remove.
3673 (cons_to_unsigned, cons_to_signed): New functions.
3674 These signal an error for invalid or out-of-range values.
3675 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3676 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3677 * font.c (Ffont_variation_glyphs):
3678 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3679 * lisp.h: Include <intprops.h>.
3680 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3681 (cons_to_signed, cons_to_unsigned): New decls.
3682 (long_to_cons, cons_to_long): Remove decls.
3683 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3684 (Fprimitive_undo): Use CONS_TO_INTEGER.
3685 * xfns.c (Fx_window_property): Likewise.
3686 * xselect.c: Include <limits.h>.
3687 (x_own_selection, selection_data_to_lisp_data):
3688 Use INTEGER_TO_CONS.
3689 (x_handle_selection_request, x_handle_selection_clear)
3690 (x_get_foreign_selection, Fx_disown_selection_internal)
3691 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3692 (lisp_data_to_selection_data): Use cons_to_unsigned.
3693 (x_fill_property_data): Use cons_to_signed.
3694 Report values out of range.
3695
d1f3d2af
PE
3696 Check for buffer and string overflow more precisely.
3697 * buffer.h (BUF_BYTES_MAX): New macro.
3698 * lisp.h (STRING_BYTES_MAX): New macro.
3699 * alloc.c (Fmake_string):
3700 * character.c (string_escape_byte8):
3701 * coding.c (coding_alloc_by_realloc):
3702 * doprnt.c (doprnt):
3703 * editfns.c (Fformat):
3704 * eval.c (verror):
3705 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3706 since they may not be the same number.
3707 * editfns.c (Finsert_char):
3708 * fileio.c (Finsert_file_contents):
3709 Likewise for BUF_BYTES_MAX.
3710
dd52fcea
PE
3711 * image.c: Use ptrdiff_t, not int, for sizes.
3712 (slurp_file): Switch from int to ptrdiff_t.
3713 All uses changed.
3714 (slurp_file): Check that file size fits in both size_t (for
3715 malloc) and ptrdiff_t (for sanity and safety).
3716
7f9bbdbb
PE
3717 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3718 if b->modtime has its maximal value.
3719
dfe18f82
PE
3720 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3721
84acfcf0
PE
3722 Don't assume time_t can fit into int.
3723 * buffer.h (struct buffer.modtime): Now time_t, not int.
3724 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3725 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3726
ccd9a01a
PE
3727 Minor fixes for signed vs unsigned integers.
3728 * character.h (MAYBE_UNIFY_CHAR):
3729 * charset.c (maybe_unify_char):
3730 * keyboard.c (read_char, reorder_modifiers):
3731 XINT -> XFASTINT, since the integer must be nonnegative.
3732 * ftfont.c (ftfont_spec_pattern):
3733 * keymap.c (access_keymap, silly_event_symbol_error):
3734 XUINT -> XFASTINT, since the integer must be nonnegative.
3735 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3736 since it makes no difference and we prefer signed.
3737 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3738 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3739 nonnegative.
3740
d6d100dd
SM
37412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3742
3743 * window.h (Fwindow_frame): Declare.
3744
2b6148e4
PE
37452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3748 (SPARE_MEMORY): Always define.
3749 (LARGE_REQUEST): Remove.
3750 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3751
f230ecc9
MR
37522011-06-06 Martin Rudalics <rudalics@gmx.at>
3753
727e958e
MR
3754 * lisp.h: Move EXFUNS for Fframe_root_window,
3755 Fframe_first_window and Fset_frame_selected_window to window.h.
3756
3757 * window.h: Move EXFUNS for Fframe_root_window,
3758 Fframe_first_window and Fset_frame_selected_window here from
3759 lisp.h.
3760
3761 * frame.c (Fwindow_frame, Fframe_first_window)
3762 (Fframe_root_window, Fframe_selected_window)
3763 (Fset_frame_selected_window): Move to window.c.
3764 (Factive_minibuffer_window): Move to minibuf.c.
3765 (Fother_visible_frames_p): New function.
3766
3767 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3768
f230ecc9
MR
3769 * window.c (decode_window, decode_any_window): Move up in code.
3770 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3771 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3772 (Fwindow_buffer): Move up and rewrite doc-string.
3773 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3774 (Fwindow_prev): New functions.
727e958e
MR
3775 (Fwindow_frame): Move here from frame.c. Accept any window as
3776 argument.
3777 (Fframe_root_window, Fframe_first_window)
3778 (Fframe_selected_window): Move here from frame.c. Accept frame
3779 or arbitrary window as argument. Update doc-strings.
3780 (Fminibuffer_window): Move up in code.
3781 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3782 (Fset_frame_selected_window): Move here from frame.c.
3783 Marginal rewrite.
727e958e
MR
3784 (Fselected_window, select_window, Fselect_window): Move up in
3785 code. Minor doc-string fixes.
f230ecc9 3786
4d09bcf6
PE
37872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3790 Do not assume that spare memory exists; that assumption is valid
3791 only if SYSTEM_MALLOC.
3792 (LARGE_REQUEST): New macro, so that the issue of large requests
3793 is separated from the issue of spare memory.
3794
810928a2
AS
37952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3796
172418ad
AS
3797 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3798 format. (Bug#8806)
3799
43f862f7
AS
3800 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3801
810928a2
AS
3802 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3803 before statements.
3804
a059fe24
JD
38052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3806
3807 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3808
3809 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3810
3811 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3812 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3813
989bf368
JB
38142011-06-05 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3817
4b80f674
CY
38182011-06-04 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3821 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3822 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3823 New error handlers.
4b80f674
CY
3824 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3825 Obey Vx_select_enable_clipboard_manager. Catch errors in
3826 x_clipboard_manager_save (Bug#8779).
3827 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3828 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3829
99a33b77 38302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3831
3832 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3833
99a33b77 38342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3835
3836 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3837 in the current matrix if keep_current_p is non-zero.
3838
8264569d
EZ
38392011-06-04 Eli Zaretskii <eliz@gnu.org>
3840
3841 * bidi.c (bidi_level_of_next_char): Fix last change.
3842
57f97249
EZ
38432011-06-03 Eli Zaretskii <eliz@gnu.org>
3844
fec2107c 3845 Support bidi reordering of text covered by display properties.
57f97249 3846
fec2107c
EZ
3847 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3848 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3849 (bidi_cache_search, bidi_cache_iterator_state)
3850 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3851 (bidi_level_of_next_char, bidi_move_to_visually_next):
3852 Support character positions inside a run of characters covered by a
fec2107c
EZ
3853 display string.
3854 (bidi_paragraph_init, bidi_resolve_explicit_1)
3855 (bidi_level_of_next_char): Call bidi_fetch_char and
3856 bidi_fetch_char_advance instead of FETCH_CHAR and
3857 FETCH_CHAR_ADVANCE.
3858 (bidi_init_it): Initialize new members.
3859 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3860 definitions.
3861 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3862 instead of using explicit *_CHAR codes.
d6d100dd
SM
3863 (bidi_resolve_explicit, bidi_resolve_weak):
3864 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3865 bidirectional text is supported only in multibyte buffers.
3866 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3867 it to initialize the frame_window_p member of struct bidi_it.
3868 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3869 (bidi_resolve_explicit, bidi_resolve_weak)
3870 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3871 bidi_it->nchars is non-positive.
3872 (bidi_level_of_next_char): Don't try to lookup the cache for the
3873 next/previous character if nothing is cached there yet, or if we
3874 were just reseat()'ed to a new position.
c40e2fb2 3875
0e14fe90
EZ
3876 * xdisp.c (set_cursor_from_row): Set start and stop points
3877 according to the row's direction when priming the loop that looks
3878 for the glyph on which to display cursor.
3879 (single_display_spec_intangible_p): Function deleted.
3880 (display_prop_intangible_p): Reimplement to call
3881 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3882 Accept 3 additional arguments needed by handle_display_spec.
3883 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3884 values: lists, `(when COND...)' forms, etc.
3885 (single_display_spec_string_p): Support property values that are
3886 lists with the argument STRING its top-level element.
3887 (display_prop_string_p): Fix the condition for processing a
3888 property that is a list to be consistent with handle_display_spec.
fec2107c 3889 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3890 last portion of handle_display_prop.
3891 (compute_display_string_pos): Accept additional argument
3892 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3893 value of a `display' property is a "replacing spec".
3894 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3895 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3896 the display property, but just return a value indicating whether
3897 the display property will replace the characters it covers.
3898 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3899 frame_window_p members of struct bidi_it.
d6d100dd
SM
3900 (compute_display_string_pos, compute_display_string_end):
3901 New functions.
fec2107c
EZ
3902 (push_it): Accept second argument POSITION, where pop_it should
3903 jump to continue iteration.
3904 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3905
fec2107c
EZ
3906 * keyboard.c (adjust_point_for_property): Adjust the call to
3907 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3908
3909 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3910 (bidi_init_it): Update prototypes.
3911 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3912 (compute_display_string_pos, compute_display_string_end):
3913 Declare prototypes.
fec2107c
EZ
3914 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3915 EMACS_INT.
fc6f18ce 3916
40087514 39172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3918
57f53182
PE
3919 Malloc failure behavior now depends on size of allocation.
3920 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3921 * lisp.h: Change signatures accordingly.
3922 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3923 All callers changed. (Bug#8762)
3924
3925 * gnutls.c: Use Emacs's memory allocators.
3926 Without this change, the gnutls library would invoke malloc etc.
3927 directly, which causes problems on non-SYNC_INPUT hosts, and which
3928 runs afoul of improving memory_full behavior. (Bug#8761)
3929 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3930 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3931 xfree instead of the default malloc, realloc, free.
3932 (Fgnutls_boot): No need to check for memory allocation failure,
3933 since xmalloc does that for us.
3934
ac32cd99 3935 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3936 * category.c (hash_get_category_set):
3937 * ccl.c (ccl_driver):
3938 * charset.c (Fdefine_charset_internal):
3939 * charset.h (struct charset.hash_index):
3940 * composite.c (get_composition_id, gstring_lookup_cache)
3941 (composition_gstring_put_cache):
3942 * composite.h (struct composition.hash_index):
3943 * dispextern.h (struct image.hash):
3944 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3945 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3946 (hashfn_equal, hashfn_user_defined, make_hash_table)
3947 (maybe_resize_hash_table, hash_lookup, hash_put)
3948 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3949 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3950 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3951 * image.c (make_image, search_image_cache, lookup_image)
3952 (xpm_put_color_table_h):
3953 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3954 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3955 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3956 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3957 * alloc.c (allocate_vectorlike):
3958 Check for overflow in vector size calculations.
3959 * ccl.c (ccl_driver):
3960 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3961 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3962 need to be updated by these changes.
40087514
PE
3963 * fns.c (make_hash_table, maybe_resize_hash_table):
3964 Check for integer overflow with large hash tables.
0de4bb68
PE
3965 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3966 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3967 (SXHASH_REDUCE): New macro.
3968 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3969 Use it instead of discarding useful hash info with large hash values.
3970 (sxhash_float): New function.
3971 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3972 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3973 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3974 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3975 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3976 Adjust signatures to match updated version of code.
3977 (consing_since_gc): Now EMACS_INT, since a single hash table can
3978 use more than INT_MAX bytes.
3979
698d32e2
DN
39802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3981
3982 Make it possible to build with GCC-4.6+ -O2 -flto.
3983
3984 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3985
fd6fa53f
SM
39862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3987
3988 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3989 Call minibuffer-inactive-mode.
3990
864db017
JB
39912011-05-31 Juanma Barranquero <lekktu@gmail.com>
3992
3993 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3994 Update dependencies.
3995
2ad0baf4
DN
39962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3997
3998 * data.c (init_data): Remove code for UTS, this system is not
3999 supported anymore.
4000
4fcc2638
DN
40012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4002
4003 Don't force ./temacs to start in terminal mode.
4004
4005 * frame.c (make_initial_frame): Initialize faces in all cases, not
4006 only when CANNOT_DUMP is defined.
4007 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4008
c56e0fd5
DN
40092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4010
4011 * dispnew.c (add_window_display_history): Use const for the string
4012 pointer. Remove declaration, not needed.
4013
333d54da 40142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4015
55d4c1b2 4016 Use 'inline', not 'INLINE'.
333d54da 4017 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4018 * alloc.c, fontset.c (INLINE): Remove.
4019 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4020 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4021 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4022 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4023 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4024
738db178
DN
40252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4026
4027 Make it possible to run ./temacs.
4028
4029 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4030 syms_of_callproc does the same thing. Remove test for
4031 "initialized", do it in the caller.
4032 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4033
620c53a6
SM
40342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4035
4036 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4037 (read_minibuf): Use get_minibuffer.
4038 (syms_of_minibuf): Use DEFSYM.
4039 (Qmetadata): New var.
4040 * data.c (Qbuffer): Don't make it static.
4041 (syms_of_data): Use DEFSYM.
4042
e003a292
PE
40432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4046 (CCL_CODE_MIN): New macro.
4047
ed008a6d
PE
40482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4049
3687c2ef
PE
4050 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4051
ed008a6d
PE
4052 * eval.c (Qdebug): Now static.
4053 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4054 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4055 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4056
d66c4c7c
CY
40572011-05-29 Chong Yidong <cyd@stupidchicken.com>
4058
4059 * image.c: Various fixes to ImageMagick code comments.
4060 (Fimagemagick_types): Doc fix.
4061
5fbc2025
PE
40622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4063
0196f88a
PE
4064 Minor fixes prompted by GCC 4.6.0 warnings.
4065
4066 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4067
5fbc2025
PE
4068 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4069 (x_clipboard_manager_save_all): Move extern decl to ...
4070 * xterm.h: ... here, so that it can be checked for consistency.
4071
1dd3c2d9
CY
40722011-05-29 Chong Yidong <cyd@stupidchicken.com>
4073
4074 * xselect.c (x_clipboard_manager_save_frame)
4075 (x_clipboard_manager_save_all): New functions.
4076 (Fx_clipboard_manager_save): Lisp function deleted.
4077
4078 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4079 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4080
4081 * xterm.h: Update prototype.
4082
5ba6571d
WX
40832011-05-28 William Xu <william.xwl@gmail.com>
4084
4085 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4086 exiting (Bug#8239).
4087
3eaff834
JM
40882011-05-28 Jim Meyering <meyering@redhat.com>
4089
e1900994 4090 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4091 * fns.c (to_uchar): Define.
4092 (crypto_hash_function): Use it to convert some newly-signed
4093 variables to unsigned, to avoid sign-extension bugs. For example,
4094 without this change, (md5 "truc") would evaluate to
4095 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4096 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4097 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4098
0f6990a7
PE
40992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 Integer overflow fixes.
c8a9ca5a 4102
08686060
PE
4103 * dbusbind.c: Serial number integer overflow fixes.
4104 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4105 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4106 to hold a serial number that is too large for a fixnum.
4107 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4108 Check for serial numbers out of range. Decode any serial number
59568bf0 4109 that was so large that it became a float. (Bug#8722)
08686060 4110
2d1fc3c7
PE
4111 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4112 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4113 Use XFASTINT rather than XUINT when numbers are nonnegative.
4114 (xd_append_arg, Fdbus_method_return_internal):
4115 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4116 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4117 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4118 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4119 (Bug#8722)
2d1fc3c7 4120
c8a9ca5a
PE
4121 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4122
519e1d69
PE
4123 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4124
30569699
PE
4125 ccl: add integer overflow checks
4126 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4127 (IN_INT_RANGE): New macros.
4128 (ccl_driver): Use them to check for integer overflow when
4129 decoding a CCL program. Many of the new checks are whether XINT (x)
4130 fits in int; it doesn't always, on 64-bit hosts. The new version
4131 doesn't catch all possible integer overflows, but it's an
847044ea 4132 improvement. (Bug#8719)
30569699 4133
c11285dc
PE
4134 * alloc.c (make_event_array): Use XINT, not XUINT.
4135 There's no need for unsigned here.
4136
fdccd48e
PE
4137 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4138 This follows up to the 2011-05-06 change that substituted uintptr_t
4139 for EMACS_INT. This case wasn't caught back then.
4140
37910ab2
PE
4141 Rework Fformat to avoid integer overflow issues.
4142 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4143 now (part of C89). Include <verify.h>.
4144 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4145 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4146 (Fformat): Avoid the prepass trying to compute sizes; it was only
4147 approximate and thus did not catch overflow reliably. Instead, walk
4148 through the format just once, formatting and computing sizes as we go,
4149 checking for integer overflow at every step, and allocating a larger
4150 buffer as needed. Keep track separately whether the format is
4151 multibyte. Keep only the most-recently calculated precision, rather
4152 than them all. Record whether each argument has been converted to
4153 string. Use EMACS_INT, not int, for byte and char and arg counts.
4154 Support field widths and precisions larger than INT_MAX. Avoid
4155 sprintf's undefined behavior with conversion specifications such as %#d
4156 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4157 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4158 formatting out-of-range floating point numbers with int
9173deec 4159 formats. (Bug#8668)
37910ab2 4160
2e6578fb
PE
4161 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4162
0ae6bdee
PE
4163 * data.c: Avoid integer truncation in expressions involving floats.
4164 * data.c: Include <intprops.h>.
4165 (arith_driver): When there's an integer overflow in an expression
4166 involving floating point, convert the integers to floating point
4167 so that the resulting value does not suffer from catastrophic
4168 integer truncation. For example, on a 64-bit host (* 4
4169 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4170 Do not rely on undefined behavior after integer overflow.
4171
de883a70
PE
4172 merge count_size_as_multibyte, parse_str_to_multibyte
4173 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4174 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4175 Check for integer overflow.
4176 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4177 since it's now a duplicate of the other. This is more of
4178 a character than a buffer op, so better that it's in character.c.
4179 * fns.c, print.c: Adjust to above changes.
4180
2ff916cb
PE
41812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4182
4183 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4184
f1b54466
PE
41852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4186
fb1ac845
PE
4187 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4188 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4189 (x_clipboard_manager_save): Now static.
4190 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4191
f1b54466
PE
4192 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4193 (crypto_hash_function): Now static.
4194 Fix pointer signedness problems. Avoid unnecessary initializations.
4195
a9f737ee
CY
41962011-05-27 Chong Yidong <cyd@stupidchicken.com>
4197
4198 * termhooks.h (Vselection_alist): Make it terminal-local.
4199
4200 * terminal.c (create_terminal): Initialize it.
4201
4202 * xselect.c: Support for clipboard managers.
4203 (Vselection_alist): Move to termhooks.h as terminal-local var.
4204 (LOCAL_SELECTION): New macro.
4205 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4206 (symbol_to_x_atom): Remove gratuitous arg.
4207 (x_handle_selection_request, lisp_data_to_selection_data)
4208 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4209 (x_own_selection, x_get_local_selection, x_convert_selection):
4210 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4211 (some_frame_on_display): Delete unused function.
4212 (Fx_own_selection_internal, Fx_get_selection_internal)
4213 (Fx_disown_selection_internal, Fx_selection_owner_p)
4214 (Fx_selection_exists_p): New optional frame arg.
4215 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4216 (x_handle_selection_clear): Don't treat other terminals with the
4217 same keyboard specially. Use the terminal-local Vselection_alist.
4218 (x_clear_frame_selections): Use Frun_hook_with_args.
4219
4220 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4221
4222 * xterm.h: Add support for those atoms.
4223
e067f0c1
CY
42242011-05-26 Chong Yidong <cyd@stupidchicken.com>
4225
4226 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4227 (converted_selections, conversion_fail_tag): New global variables.
4228 (x_selection_request_lisp_error): Free the above.
4229 (x_get_local_selection): Remove unnecessary code.
4230 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4231 of converted selections stored in converted_selections.
4232 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4233 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4234 (x_convert_selection): New function.
4235 (x_handle_selection_event): Simplify.
4236 (x_get_foreign_selection): Don't ignore incoming requests while
4237 waiting for an answer; this will fail when we implement
4238 SAVE_TARGETS, and seems unnecessary anyway.
4239 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4240 (Vx_sent_selection_functions): Doc fix.
4241
0f4aebc0
LL
42422011-05-26 Leo Liu <sdl.web@gmail.com>
4243
4244 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4245
e61124cd
YM
42462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4247
4248 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4249
4250 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4251 for fringe update if it has periodic bitmap.
ac389d0c 4252 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4253 and fringe_bitmap_periodic_p.
4254
4255 * fringe.c (get_fringe_bitmap_data): New function.
4256 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4257 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4258 row. Mark glyph row for fringe update if periodicity changed.
4259
4260 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4261 for fringe update unless it has periodic bitmap.
4262
f16d9837
KH
42632011-05-25 Kenichi Handa <handa@m17n.org>
4264
4265 * xdisp.c (get_next_display_element): Set correct it->face_id for
4266 a static composition.
4267
e1b90ef6
LL
42682011-05-24 Leo Liu <sdl.web@gmail.com>
4269
4270 * deps.mk (fns.o):
4271 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4272
4273 * fns.c (crypto_hash_function, Fsha1): New function.
4274 (Fmd5): Use crypto_hash_function.
4275 (syms_of_fns): Add Ssha1.
4276
7400048f
PE
42772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 * gnutls.c: Remove unused macros.
4280 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4281 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4282 Remove macros that are defined and never used.
4283 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4284
abb71cf4
CY
42852011-05-22 Chong Yidong <cyd@stupidchicken.com>
4286
4287 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4288 (Fx_get_selection_internal): Minor cleanup.
4289 (Fx_own_selection_internal): Rename arguments for consistency with
4290 select.el.
4291
6307db39
PE
42922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4293
4294 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4295
f3d4e0a4
CY
42962011-05-22 Chong Yidong <cyd@stupidchicken.com>
4297
4298 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4299
4d8ade89
YM
43002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4301
4302 * dispnew.c (scrolling_window): Don't exclude the case that the
4303 last enabled row in the desired matrix touches the bottom boundary.
4304
32078c8d
GM
43052011-05-21 Glenn Morris <rgm@gnu.org>
4306
4307 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4308 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4309 and add some more files.
32078c8d 4310
7285dc67
EZ
43112011-05-20 Eli Zaretskii <eliz@gnu.org>
4312
4313 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4314 report_file_error introduced by the change from 2011-05-07.
4315
89d1bd22
PE
43162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4317
4318 * systime.h (Time): Define only if emacs is defined.
4319 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4320 where the include path doesn't have X11/X.h by default. See
4321 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4322
e23640bb 43232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4324
4325 * composite.c (find_automatic_composition): Fix previous change.
4326
b9704ad9
GM
43272011-05-20 Glenn Morris <rgm@gnu.org>
4328
4329 * lisp.mk: New file, split from Makefile.in.
4330 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4331 (shortlisp): Remove.
4332 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4333
4a720484
GM
43342011-05-19 Glenn Morris <rgm@gnu.org>
4335
4336 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4337 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4338 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4339 (lisp): Set the order to that of loadup.el.
4340 (shortlisp): Make it a copy of $lisp.
4341 (SOME_MACHINE_LISP): Remove.
4342 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4343 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4344
a28d4396
KH
43452011-05-18 Kenichi Handa <handa@m17n.org>
4346
4347 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4348 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4349 (find_automatic_composition): Mostly rewrite for efficiency.
4350
a2b1fa8e
JB
43512011-05-18 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * makefile.w32-in: Update dependencies.
4354
8e1f5610
CS
43552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4356
4357 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4358 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4359
7025ee00 43602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4361
cdfa6eab
PE
4362 Fix some integer overflow issues, such as string length overflow.
4363
06d6db33
PE
4364 * insdel.c (count_size_as_multibyte): Check for string overflow.
4365
2b4560a8
PE
4366 * character.c (lisp_string_width): Check for string overflow.
4367 Use EMACS_INT, not int, for string indexes and lengths; in
4368 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4369 the resulting string length overflows an EMACS_INT; instead,
4370 report a string overflow if no precision given. When checking for
4371 precision exhaustion, use a check that cannot possibly have
4372 integer overflow. (Bug#8675)
4373 * character.h (lisp_string_width): Adjust to new signature.
4374
cb93f9be
PE
4375 * alloc.c (string_overflow): New function.
4376 (Fmake_string): Use it. This doesn't change behavior, but saves
4377 a few bytes and will simplify future changes.
4378 * character.c (string_escape_byte8): Likewise.
4379 * lisp.h (string_overflow): New decl.
4380
1a1f3366
PE
4381 Fixups, following up to the user-interface timestamp change.
4382 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4383 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4384 * msdos.c (mouse_get_pos): Likewise.
4385 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4386 * w32gui.h (Time): Define by including "systime.h" rather than by
4387 declaring it ourselves. (Bug#8664)
4388
d4e3e4d3
PE
4389 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4390 * image.c (clear_image_cache): Likewise.
4391
f6a24d19
PE
4392 * term.c (term_mouse_position): Don't assume time_t wraparound.
4393
08dc5ae6
PE
4394 Be more systematic about user-interface timestamps.
4395 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4396 and sometimes 'EMACS_UINT', to represent these timestamps.
4397 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4398 This makes the code easier to follow, and makes it easier to catch
4399 integer overflow bugs such as Bug#8664.
4400 * frame.c (Fmouse_position, Fmouse_pixel_position):
4401 Use Time, not unsigned long, for user-interface timestamps.
4402 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4403 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4404 * keyboard.h (last_event_timestamp): Likewise.
4405 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4406 * menu.h (xmenu_show): Likewise.
4407 * term.c (term_mouse_position): Likewise.
4408 * termhooks.h (struct input_event.timestamp): Likewise.
4409 (struct terminal.mouse_position_hook): Likewise.
4410 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4411 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4412 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4413 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4414 what it was before.
4415 * menu.h, termhooks.h: Include "systime.h", for Time.
4416
8e55734a
PE
4417 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4418 Don't assume that the difference between two unsigned long values
4419 can fit into an integer. At this point, we know button_down_time
4420 <= event->timestamp, so the difference must be nonnegative, so
4421 there's no need to cast the result if double-click-time is
4422 nonnegative, as it should be; check that it's nonnegative, just in
4423 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4424 apart (about 25 days). (Bug#8664)
8e55734a 4425
841f1b75 4426 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4427 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4428
3e26f69c
PE
4429 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4430 that always fit in int. Use a sentinel instead of a counter, to
4431 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4432 * frame.h (struct frame): Use int for menu_bar_items_used
4433 instead of EMACS_INT, since it always fits in int.
3e26f69c 4434
5cc152c0
PE
4435 * menu.c (grow_menu_items): Check for int overflow.
4436
d89eb65e
PE
4437 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4438
5235bd3e
PE
4439 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4440 Before, the code was not consistent. These values cannot exceed
4441 2**31 - 1 so there's no need to make them unsigned.
4442 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4443 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4444 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4445 as modifiers.
4446 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4447
bc827e23
PE
4448 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4449 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4450 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4451 presumably because the widths might not match.
4452
78eb494e
PE
4453 * window.c (size_window): Avoid needless test at loop start.
4454
04f2d78b
CB
44552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4456
4457 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4458
d2fc7e3d 44592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4460
4461 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4462
d2fc7e3d 44632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4464
4465 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4466 `width' to `bar_area_x' and `bar_area_width', respectively.
4467 (x_scroll_run): Take account of fringe background extension.
4468
04f2d78b
CB
4469 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4470 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4471 `bar_area_width', respectively.
4472 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4473 background extension.
4474
79b70037
GM
44752011-05-10 Jim Meyering <meyering@redhat.com>
4476
4477 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4478
2f142cc5
JB
44792011-05-10 Juanma Barranquero <lekktu@gmail.com>
4480
4481 * image.c (Finit_image_library): Return t for built-in image types,
4482 like pbm and xbm. (Bug#8640)
4483
57679c86
AS
44842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4485
4486 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4487
888c9e86
EZ
44882011-05-07 Eli Zaretskii <eliz@gnu.org>
4489
b0512a1d
EZ
4490 * w32console.c (Fset_screen_color): Doc fix.
4491 (Fget_screen_color): New function.
4492 (syms_of_ntterm): Defsubr it.
4493
7285dc67
EZ
4494 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4495 unlink the temporary file if Fcall_process didn't create it in the
4496 first place.
4497 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4498 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4499 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4500 cue to call_process_cleanup not to close that handle.
4501
4d3fcc8e
BK
45022011-05-07 Ben Key <bkey76@gmail.com>
4503
4504 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4505 one of two shell specific rules, either bootstrap-temacs-CMD or
4506 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4507 to the previous implementation of the bootstrap-temacs rule.
4508 The bootstrap-temacs-CMD rule is similar to the previous
4509 implementation of the bootstrap-temacs rule except that it
4510 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4511 variable.
4512
4513 These changes, along with some changes to nt/configure.bat,
4514 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4515 earlier fix to add support for --cflags and --ldflags options
4516 that include quotes so that it works whether make uses cmd or
4517 sh as the shell.
4518
b4289b64
MA
45192011-05-06 Michael Albinus <michael.albinus@gmx.de>
4520
4521 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4522 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4523 is a constant.
4524 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4525 a string. Handle both cases.
4526 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4527 (Fdbus_register_method): Use Qinvalid_function.
4528
af4c0e28
JB
45292011-05-06 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * makefile.w32-in: Update dependencies.
4532 (LISP_H): Add inttypes.h and stdin.h.
4533 (PROCESS_H): Add unistd.h.
4534
c51453d9
EZ
45352011-05-06 Eli Zaretskii <eliz@gnu.org>
4536
4537 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4538 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4539
8ff0ac3c 45402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4541
4c4b566b
PE
4542 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4543
aab2b9b5
PE
4544 * term.c (vfatal): Remove stray call to va_end.
4545 It's not needed and the C Standard doesn't allow it here anyway.
4546
c378da0b
PE
4547 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4548 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4549
288b08c7
PE
4550 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4551 bytes.
4552
e3601888
PE
4553 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4554
db6c0e74
PE
4555 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4556
dd5963ea
PE
4557 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4558
88c9450f
PE
4559 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4560
2f9442b8
PE
4561 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4562
c032b5f8
PE
4563 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4564 * charset.c (Fdefine_charset_internal): Don't initialize
4565 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4566 32-bit int (Bug#8600).
a108c10b
PE
4567
4568 * lread.c (read_integer): Be more consistent with string-to-number.
4569 Use string_to_number to do the actual conversion; this avoids
4570 rounding errors and fixes some other screwups. Without this fix,
4571 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4572 (digit_to_number): Move earlier, for benefit of read_integer.
4573 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4574 not a digit in any supported base. (Bug#8602)
a108c10b 4575
ad5f9eea
PE
4576 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4577
aec1708a
PE
4578 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4579 to match comment at start of function. This also removes a
4580 GCC warning about overflow in a 32+64-bit port.
4581
47be4ab5
PE
4582 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4583
371cac43
PE
4584 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4585 Reported by Stefan Monnier in
4586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4587 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4588 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4589
d01a7826
PE
4590 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4591 (EMACS_UINTPTR): Likewise, with uintptr_t.
4592
7fd47d5c
PE
4593 * lisp.h: Prefer 64-bit EMACS_INT if available.
4594 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4595 on 32-bit hosts that have 64-bit int, so that they can access
4596 large files.
122b0c86
PE
4597 However, temporarily disable this change unless the temporary
4598 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4599
8727937b
PE
4600 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4601
8ac068ac
PE
4602 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4603 This removes an assumption that EMACS_INT and long are the same
4604 width as pointers. The assumption is true for Emacs porting targets
4605 now, but we want to make other targets possible.
4606 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4607 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4608 In the rest of the code, change types of integers that hold casted
4609 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4610 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4611 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4612 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4613 No need to cast type when ORing.
4614 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4615 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4616 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4617 assume EMACS_INT is the same width as char *.
4618 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4619 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4620 Remove no-longer-needed casts.
4621 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4622 (xg_tool_bar_help_callback, xg_make_tool_item):
4623 Use EMACS_INTPTR to hold an integer
4624 that will be cast to void *; this can avoid a GCC warning
4625 if EMACS_INT is not the same width as void *.
4626 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4627 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4628 (current_message_1, set_message_1):
4629 Use a local to convert to proper width without a cast.
4630 * xmenu.c (dialog_selection_callback): Likewise.
4631
ede49d71
PE
4632 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4633 Also, don't assume VALBITS / RAND_BITS is less than 5,
4634 and don't rely on undefined behavior when shifting a 1 left into
4635 the sign bit.
4636 * lisp.h (get_random): Change signature to match.
4637
2f30ecd0
PE
4638 * lread.c (hash_string): Use size_t, not int, for hash computation.
4639 Normally we prefer signed values; but hashing is special, because
4640 it's better to use unsigned division on hash table sizes so that
4641 the remainder is nonnegative. Also, size_t is the natural width
4642 for hashing into memory. The previous code used 'int', which doesn't
4643 retain enough info to hash well into very large tables.
4644 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4645
2a866e7b
PE
4646 * dbusbind.c: Don't possibly lose pointer info when converting.
4647 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4648 Use XPNTR rather than XHASH, so that the high-order bits of
4649 the pointer aren't lost when converting through void *.
4650
51639eac
PE
4651 * eval.c (Fautoload): Don't double-shift a pointer.
4652
92394119
PE
4653 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4654
dbdb9a7c
JB
46552011-05-06 Juanma Barranquero <lekktu@gmail.com>
4656
4657 * gnutls.c (DEF_GNUTLS_FN):
4658 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4659
db7a0b4f
AS
46602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4661
4662 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4663 marker. (Bug#8610)
4664
f7ff1b0f 46652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4666
4667 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4668 New version that can reserve upto 2GB of heap space.
4669
f7ff1b0f 46702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4671
4672 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4673
639c109b
TZ
46742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4675
4676 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4677 `gnutls_certificate_set_x509_key_file'.
4678
d2127135
JB
46792011-05-05 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4682 Update dependencies.
4683
e968f4f3
JB
46842011-05-04 Juanma Barranquero <lekktu@gmail.com>
4685
4686 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4687 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4688 Remove unused parameter `fildes'.
4689 * process.c (read_process_output, send_process): Don't pass it.
4690
84d358f0
JB
46912011-05-04 Juanma Barranquero <lekktu@gmail.com>
4692
4693 Fix previous change: the library cache is defined in w32.c.
4694 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4695 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4696
0898ca10
JB
46972011-05-04 Juanma Barranquero <lekktu@gmail.com>
4698
4699 Implement dynamic loading of GnuTLS on Windows.
4700
4701 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4702 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4703 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4704 Declare.
4705
4706 * gnutls.c (Qgnutls_dll): Define.
4707 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4708 (gnutls_*): Declare function pointers.
4709 (init_gnutls_functions): New function to initialize function pointers.
4710 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4711 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4712 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4713 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4714 (emacs_gnutls_write, emacs_gnutls_read)
4715 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4716 (Fgnutls_available_p): New function.
4717 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4718 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4719 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4720
4721 * image.c: Include w32.h.
4722 (Vimage_type_cache): Delete.
4723 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4724 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4725 (w32_delayed_load): Move to w32.c.
4726
4727 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4728
4729 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4730 (w32_delayed_load): Move from image.c. When loading a library, record
4731 its filename in the :loaded-from property of the library id.
4732 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4733 Initialize and staticpro them.
4734 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4735
4736 * process.c: Include lisp.h before w32.h, not after.
4737 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4738 instead of gnutls_record_check_pending.
4739
4740 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4741
ff4de4aa
TZ
47422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4743
4744 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4745 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4746 as passed in.
4747
abe95abb
JD
47482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4749
4750 * xterm.c (x_set_frame_alpha): Do not set property on anything
4751 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4752
e16e55d4
JB
47532011-05-02 Juanma Barranquero <lekktu@gmail.com>
4754
4755 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4756
bafcf6a5
JB
47572011-05-02 Juanma Barranquero <lekktu@gmail.com>
4758
4759 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4760 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4761 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4762 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4763 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4764 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4765 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4766 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4767 (Qgnutls_bootprop_callbacks_verify): Make static.
4768
e7a6747f
AS
47692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4770
19ed11ba
AS
4771 * callproc.c: Indentation fixup.
4772
e7a6747f 4773 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4774 (wait_for_termination, interruptible_wait_for_termination):
4775 Move after wait_for_termination_1.
e7a6747f 4776
1ef14cb4
LMI
47772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4778
4779 * sysdep.c (interruptible_wait_for_termination): New function
4780 which is like wait_for_termination, but allows keyboard
4781 interruptions.
4782
4783 * callproc.c (Fcall_process): Add (:file "file") as an option for
4784 the STDOUT buffer.
4785 (Fcall_process_region): Ditto.
4786
330d880c
EZ
47872011-04-30 Eli Zaretskii <eliz@gnu.org>
4788
8db90b73
EZ
4789 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4790 rather than `XVECTOR (FOO)->size'.
4791
330d880c
EZ
4792 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4793 inttypes.h, as a gnulib replacement is used if it not available in
4794 system headers.
4795
15cbd324
EZ
47962011-04-21 Eli Zaretskii <eliz@gnu.org>
4797
4798 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4799 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4800 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4801
4802 * coding.c (coding_alloc_by_realloc): Error out if destination
4803 will grow beyond MOST_POSITIVE_FIXNUM.
4804 (decode_coding_emacs_mule): Abort if there isn't enough place in
4805 charbuf for the composition carryover bytes. Reserve an extra
4806 space for up to 2 characters produced in a loop.
4807 (decode_coding_iso_2022): Abort if there isn't enough place in
4808 charbuf for the composition carryover bytes.
4809
48102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4811
ae940cca
EZ
4812 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4813 aborting when %lld or %lll format is passed.
4814 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4815 %llo or %llx format is passed. (Bug#8545)
4816
03ab8921
EZ
4817 * window.c (window_scroll_line_based): Use a marker instead of
4818 simple variables to record original value of point. (Bug#7952)
4819
afda1437
EZ
4820 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4821 produced by %s or %c overflows available buffer space. (Bug#8545)
4822
f76dee0c
PE
48232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4824
4825 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4826 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4827
fdc5744d
JB
48282011-04-28 Juanma Barranquero <lekktu@gmail.com>
4829
4830 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4831
638f053a
JB
48322011-04-28 Juanma Barranquero <lekktu@gmail.com>
4833
4834 * keyboard.c (Qdelayed_warnings_hook): Define.
4835 (command_loop_1): Run `delayed-warnings-hook'
4836 if Vdelayed_warnings_list is non-nil.
4837 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4838 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4839
d178f871
EZ
48402011-04-28 Eli Zaretskii <eliz@gnu.org>
4841
4842 * doprnt.c (doprnt): Don't return value smaller than the buffer
4843 size if the message was truncated. (Bug#8545).
4844
b124fd93
JB
48452011-04-28 Juanma Barranquero <lekktu@gmail.com>
4846
4847 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4848 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4849
e810457d
PE
48502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4853
ea51cceb
JB
48542011-04-27 Juanma Barranquero <lekktu@gmail.com>
4855
4856 * makefile.w32-in: Update dependencies.
4857
94dcfacf
EZ
48582011-04-27 Eli Zaretskii <eliz@gnu.org>
4859
4860 Improve `doprnt' and its usage. (Bug#8545)
4861 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4862 `format_end'. Remove support for %l as a conversion specifier.
4863 Don't use xrealloc. Improve diagnostics when the %l size modifier
4864 is used. Update the commentary.
4865
4866 * eval.c (verror): Simplify calculation of size_t.
4867
4868 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4869 messages.
4870
f61f41d7
PE
48712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4872
4873 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4874 change.
4875
96fb4434
PE
48762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4877
4878 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4879 This makes this file independent of the recent pseudovector change.
4880
671875da 48812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4882
69e9b5a3
PE
4883 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4884
b5f869a7 4885 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4886 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4887 Remove unused local.
c8926152 4888 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4889
841a1577 4890 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4891 GCC 4.6.0 optimizes based on type-based alias analysis.
4892 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4893 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4894 != &v->size, and therefore "v->size = 1; b->size = 2; return
4895 v->size;" must therefore return 1. This assumption is incorrect
4896 for Emacs, since it type-puns struct Lisp_Vector * with many other
4897 types. To fix this problem, this patch adds a new type struct
f904488f 4898 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4899 and pseudovectors, and helps optimizing compilers not get fooled
4900 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4901 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4902 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4903 the size member.
eab3844f
PE
4904 (XSETPVECTYPE): Rewrite in terms of new macro.
4905 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4906 This is a bit clearer, and further avoids the possibility of
4907 undesirable aliasing.
4908 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4909 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4910 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4911 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4912 (ASIZE): Now uses header.size rather than size.
4913 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4914 to avoid the hassle of writing XVECTOR (foo)->header.size.
4915 (struct vectorlike_header): New type.
eab3844f
PE
4916 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4917 object, to help avoid aliasing.
4918 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4919 (SUBRP): Likewise, since Lisp_Subr is a special case.
4920 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4921 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4922 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4923 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4924 changed to be "header.size" and "header.next".
4925 * buffer.h (struct buffer): Likewise.
4926 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4927 * frame.h (struct frame): Likewise.
4928 * process.h (struct Lisp_Process): Likewise.
4929 * termhooks.h (struct terminal): Likewise.
4930 * window.c (struct save_window_data, struct saved_window): Likewise.
4931 * window.h (struct window): Likewise.
4932 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4933 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4934 * buffer.c (init_buffer_once): Likewise.
4935 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4936 special case.
4937 * process.c (Fformat_network_address): Use local var for size,
4938 for brevity.
4939
0df1eac5
PE
4940 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4941
847ab9d1 4942 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4943 * data.c (atof): Remove decl; no longer used or needed.
4944 (digit_to_number): Move to lread.c.
4945 (Fstring_to_number): Use new string_to_number function, to be
4946 consistent with how the Lisp reader treats infinities and NaNs.
4947 Do not assume that floating-point numbers represent EMACS_INT
4948 without losing information; this is not true on most 64-bit hosts.
4949 Avoid double-rounding errors, by insisting on integers when
4950 parsing non-base-10 numbers, as the documentation specifies.
4951 * lisp.h (string_to_number): New decl, replacing ...
4952 (isfloat_string): Remove.
bc0a5c13 4953 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4954 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4955 appears to have been a coding error. Similarly, do not accept
4956 strings like +-1e0 as floating point numbers. Do not report
4957 overflow for integer overflows unless the base is not 10 which
4958 means we have no simple and reliable way to continue.
4959 Break out the floating-point parsing into a new
4960 function string_to_number, so that Fstring_to_number parses
4961 floating point numbers consistently with the Lisp reader.
04f2d78b 4962 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4963 (E_CHAR, EXP_INT): Remove, replacing with ...
4964 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4965 (string_to_number): New function, replacing isfloat_string.
4966 This function checks for valid syntax and produces the resulting
4967 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4968 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4969 so that overflow for non-base-10 numbers is reported only when
4970 there's no portable and simple way to convert to floating point.
452f4150 4971
67769ffc
PE
4972 * textprop.c (set_text_properties_1): Rewrite for clarity,
4973 and to avoid GCC warning about integer overflow.
4974
c20db43f
PE
4975 * intervals.h (struct interval): Use EMACS_INT for members
4976 where EMACS_UINT might cause problems. See
4977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4978 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4979 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4980 All uses changed.
37aa2f85
PE
4981 (offset_intervals): Tell GCC not to worry about length overflow
4982 when negating a negative length.
c20db43f 4983
2538aa2f
PE
4984 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4985 (overrun_check_free): Likewise.
4986
f2d3008d
PE
4987 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4988 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4989 word size.
4990
ec8df744
PE
4991 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4992 (gnutls_make_error): Rename local to avoid shadowing.
4993 (gnutls_emacs_global_deinit): ifdef out; not used.
4994 (Fgnutls_boot): Use const for pointer to readonly storage.
4995 Comment out unused local. Fix pointer signedness problems.
4996
640ee02d
PE
4997 * lread.c (openp): Don't stuff size_t into an 'int'.
4998 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4999 about possible signed overflow.
5000
6048fb2a
PE
5001 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5002 (GDK_KEY_g): Don't define if already defined.
5003 (xg_prepare_tooltip): Avoid pointer signedness problem.
5004 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5005
fa3c87e1
PE
5006 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5007 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5008
2172544b
PE
5009 * xfns.c (Fx_window_property): Simplify a bit,
5010 to make a bit faster and to avoid GCC 4.6.0 warning.
5011 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5012
9b821a21
PE
5013 * fns.c (internal_equal): Don't assume size_t fits in int.
5014
3c616cfa
PE
5015 * alloc.c (compact_small_strings): Tighten assertion a little.
5016
c2982e87
PE
5017 Replace pEd with more-general pI, and fix some printf arg casts.
5018 * lisp.h (pI): New macro, generalizing old pEd macro to other
5019 conversion specifiers. For example, use "...%"pI"d..." rather
5020 than "...%"pEd"...".
5021 (pEd): Remove. All uses replaced with similar uses of pI.
5022 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5023 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5024 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5025 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5026 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5027 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5028 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5029 64-bit hosts.
5030 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5031 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5032 * print.c (safe_debug_print, print_object): Likewise.
5033 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5034 to int.
6f04d126
PE
5035 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5036 avoiding the 0 flag, which is not portable.
c2982e87
PE
5037 * process.c (Fmake_network_process): Use pI to avoid cast.
5038 * region-cache.c (pp_cache): Likewise.
5039 * xdisp.c (decode_mode_spec): Likewise.
5040 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5041 behavior on 64-bit hosts with printf arg.
6f04d126 5042 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5043 (x_stop_queuing_selection_requests): Likewise.
5044 (x_get_window_property): Don't truncate byte count to an 'int'
5045 when tracing.
0b432f21 5046
5e073ec7
PE
5047 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5048 here, since it parses constructs like leading '-' and spaces,
5049 which are not wanted; and it overflows with large numbers.
5050 Instead, simply match F[0-9]+, which is what is wanted anyway.
5051
36372bf9
PE
5052 * alloc.c: Remove unportable assumptions about struct layout.
5053 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5054 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5055 (allocate_vectorlike, make_pure_vector): Use the new macros,
5056 plus offsetof, to remove unportable assumptions about struct layout.
5057 These assumptions hold on all porting targets that I know of, but
5058 they are not guaranteed, they're easy to remove, and removing them
5059 makes further changes easier.
5060
0b432f21
PE
5061 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5062 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5063 (string_overrun_cookie): Now const. Use initializers that
5064 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5065 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5066 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5067 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5068 multiple of sizeof (EMACS_INT); it need not be, if
5069 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5070 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5071
895009e1
JB
50722011-04-26 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5075
6a7a1b0b
TZ
50762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5077
5078 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5079 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5080 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5081
841a1577 50822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5083
5084 * lisp.h (Qdebug): List symbol.
895009e1 5085 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5086 * keyboard.c (debug-on-event): New variable.
5087 (handle_user_signal): Break into debugger when debug-on-event
5088 matches the current signal symbol.
5089
f2d3ba6f
DN
50902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5091
5092 * alloc.c (check_sblock, check_string_bytes)
5093 (check_string_free_list): Convert to standard C.
5094
42ce4c63
TZ
50952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5096
5097 * w32.c (emacs_gnutls_push): Fix typo.
5098
825cd63c
EZ
50992011-04-25 Eli Zaretskii <eliz@gnu.org>
5100
fb11d64d
EZ
5101 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5102 "cast to pointer from integer of different size".
5103
825cd63c
EZ
5104 Improve doprnt and its use in verror. (Bug#8545)
5105 * doprnt.c (doprnt): Document the set of format control sequences
5106 supported by the function. Use SAFE_ALLOCA instead of always
5107 using `alloca'.
5108
5109 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5110 is one byte too soon. Don't use xrealloc; instead xfree and
5111 xmalloc anew.
5112
e061a11b
TZ
51132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5114
5115 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5116 callbacks stage.
5117
5118 * gnutls.c: Renamed global_initialized to
5119 gnutls_global_initialized. Added internals for the
5120 :verify-hostname-error, :verify-error, and :verify-flags
5121 parameters of `gnutls-boot' and documented those parameters in the
5122 docstring. Start callback support.
9173deec
JB
5123 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5124 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5125 on error. Return error code.
e061a11b
TZ
5126 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5127 (emacs_gnutls_read): Likewise.
5128 (Fgnutls_boot): Return handshake error code.
5129 (emacs_gnutls_handle_error): New function.
5130 (wsaerror_to_errno): Likewise.
5131
5132 * w32.h (emacs_gnutls_pull): Add prototype.
5133 (emacs_gnutls_push): Likewise.
5134
5135 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5136 (emacs_gnutls_push): Likewise.
5137
51382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5139
5140 * process.c (wait_reading_process_output): Check if GnuTLS
5141 buffered some data internally if no FDs are set for TLS
5142 connections.
5143
5144 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5145 (LIBS): Link to USER_LIBS.
5146 ($(BLD)/gnutls.$(0)): New target.
5147
fa6996bc
EZ
51482011-04-24 Eli Zaretskii <eliz@gnu.org>
5149
eb35682e
EZ
5150 * xdisp.c (handle_single_display_spec): Rename the
5151 display_replaced_before_p argument into display_replaced_p, to
5152 make it consistent with the commentary. Fix typos in the
5153 commentary.
5154
e2ad650c
EZ
5155 * textprop.c (syms_of_textprop): Remove dead code.
5156 (copy_text_properties): Delete obsolete commentary about an
5157 interface that was deleted long ago. Fix typos in the description
5158 of arguments.
5159
1b2de274
EZ
5160 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5161 to changes in oldXMenu/XMenu.h from 2011-04-16.
5162 <menu_help_message, prev_menu_help_message>: Constify.
5163 (IT_menu_make_room): menu->help_text is now `const char **';
5164 adjust.
5165
5166 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5167 to changes in oldXMenu/XMenu.h from 2011-04-16.
5168 (struct XMenu): Declare `help_text' `const char **'.
5169
5170 * xfaces.c <Qunspecified>: Make extern again.
5171
5172 * syntax.c: Include sys/types.h before including regex.h, as
5173 required by Posix.
5174
762b15be
EZ
5175 * doc.c (get_doc_string): Improve the format passed to `error'.
5176
5177 * doprnt.c (doprnt): Improve commentary.
5178
5179 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5180
5181 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5182 them with etags.
5183
f1052e5d
EZ
5184 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5185 changes in globals.h immediately force recompilation.
762b15be
EZ
5186 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5187 $(CURDIR)/s/ms-w32.h.
5188 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5189
fa6996bc
EZ
5190 * character.c (Fchar_direction): Function deleted.
5191 (syms_of_character): Don't defsubr it.
5192 <char-direction-table>: Deleted.
5193
e6c3da20
EZ
51942011-04-23 Eli Zaretskii <eliz@gnu.org>
5195
5196 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5197 * doprnt.c: Include limits.h.
5198 (SIZE_MAX): New macro.
04f2d78b
CB
5199 (doprnt): Return a size_t value. 2nd arg is now size_t.
5200 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5201 Improve overflow protection. Support `l' modifier for integer
5202 conversions. Support %l conversion. Don't assume an EMACS_INT
5203 argument for integer conversions and for %c.
5204
5205 * lisp.h (doprnt): Restore prototype.
5206
5207 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5208 $(SRC)/character.h.
5209
5210 * Makefile.in (base_obj): Add back doprnt.o.
5211
5212 * deps.mk (doprnt.o): Add back prerequisites.
5213 (callint.o): Depend on character.h.
5214
5215 * eval.c (internal_lisp_condition_case): Include the handler
5216 representation in the error message.
5217 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5218 when breaking from the loop.
5219
5220 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5221
5222 * callint.c (Fcall_interactively): When displaying error message
5223 about invalid control letter, pass the character's codepoint, not
5224 a pointer to its multibyte form. Improve display of the character
5225 in octal and display also its hex code.
5226
5227 * character.c (char_string): Use %x to display the (unsigned)
5228 codepoint of an invalid character, to avoid displaying a bogus
5229 negative value.
5230
5231 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5232 `error', not SYMBOL_NAME itself.
5233
5234 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5235 character arguments to `error'.
5236
5237 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5238 to `error' in error message about FINAL_CHAR argument. Make sure
5239 FINAL_CHAR is a character, and use %c when it is passed as
5240 argument to `error'.
5241
4ffd0d6b 52422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5243
5244 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5245
5246 * w32.c: Include <time.h>.
5247 (sys_localtime): New function.
5248
4ffd0d6b 52492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5250
5251 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5252
4ffd0d6b 5253 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5254
4ffd0d6b 52552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5256
4ffd0d6b
GM
5257 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5258 zombies (Bug#8467).
aac0c6e3 5259
04c56954
EZ
52602011-04-19 Eli Zaretskii <eliz@gnu.org>
5261
5262 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5263 gl_state.e_property when gl_state.object is Qt.
5264
5265 * insdel.c (make_gap_larger): Remove limitation of buffer size
5266 to <= INT_MAX.
5267
16a43933
CY
52682011-04-18 Chong Yidong <cyd@stupidchicken.com>
5269
5270 * xdisp.c (lookup_glyphless_char_display)
5271 (produce_glyphless_glyph): Handle cons cell entry in
5272 glyphless-char-display.
5273 (Vglyphless_char_display): Document it.
5274
5275 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5276 glyphless-char-display.
5277
4581706e
CY
52782011-04-17 Chong Yidong <cyd@stupidchicken.com>
5279
5280 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5281
5282 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5283
5284 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5285 definition for no-X builds.
5286
4887c6e2 52872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5288
fd35b6f9
PE
5289 Static checks with GCC 4.6.0 and non-default toolkits.
5290
5c1ccb01
PE
5291 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5292
006c5daa
PE
5293 * process.c (keyboard_bit_set): Define only if SIGIO.
5294 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5295 (send_process): Repair possible setjmp clobbering.
5296
efc736d3
PE
5297 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5298
4e2fe2e6
PE
5299 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5300
f97334a2
PE
5301 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5302
4e75f29d
PE
5303 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5304 Define only if needed.
5305
90efadd1
PE
5306 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5307 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5308 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5309
3c647824
PE
5310 * dispextern.h (struct redisplay_interface): Rename param
5311 to avoid shadowing.
e264f262 5312 * termhooks.h (struct terminal): Likewise.
761383f4 5313 * xterm.c (xembed_send_message): Likewise.
3c647824 5314
b58c5c4a
PE
5315 * insdel.c (make_gap_smaller): Define only if
5316 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5317
cad59032
PE
5318 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5319 it.
5320
c339dc2e
PE
5321 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5322 so that we aren't warned about unused symbols.
5323
91a3e27b
PE
5324 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5325
399c71d3 5326 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5327
8ffc96f5
PE
5328 * xfns.c (x_real_positions): Mark locals as initialized.
5329
eef9bc79
PE
5330 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5331
098db9dd
PE
5332 * xterm.c: Fix problems found by static analysis with other toolkits.
5333 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5334 (x_dispatch_event): Declare static if USE_GTK, and
5335 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5336 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5337 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5338 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5339 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5340
eb18f6cc
PE
5341 * xmenu.c (menu_help_callback): Pointer type fixes.
5342 Use const pointers when pointing at readonly data. Avoid pointer
5343 signedness clashes.
5344 (FALSE): Remove unused macro.
5345 (update_frame_menubar): Remove unused decl.
5346
1fe72bf8
PE
5347 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5348
60d9e1db
PE
5349 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5350 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5351 (single_menu_item): Rename local to avoid shadowing.
5352
39261c26
PE
5353 * keyboard.c (make_lispy_event): Remove unused local var.
5354
018c5e19
PE
5355 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5356 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5357
63d2b86e
PE
5358 * bitmaps: Change bitmaps from unsigned char back to the X11
5359 compatible char. Avoid the old compiler warnings about
5360 out-of-range initializers by using, for example, '\xab' rather
5361 than 0xab.
5362
aefd87e1
PE
5363 * xgselect.c (xgselect_initialize): Check vs interface
5364 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5365
bf501fb9
PE
5366 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5367
e9829fdf
PE
5368 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5369 to read-only memory.
5370
1086c095
PE
5371 * fns.c (vector): Remove; this old hack is no longer needed.
5372
2baccd04 5373 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5374 Remove unused var.
dde42981 5375 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5376
72391843 5377 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5378
436c16df 5379 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5380 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5381 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5382
92bb796d 5383 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5384 (x_term_init): Remove local to avoid shadowing.
92bb796d 5385
764430a3 5386 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5387
5388 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5389 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5390
d1dfb56c
EZ
53912011-04-16 Eli Zaretskii <eliz@gnu.org>
5392
c4354cb4
EZ
5393 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5394
d1dfb56c
EZ
5395 Fix regex.c, syntax.c and friends for buffers > 2GB.
5396 * syntax.h (struct gl_state_s): Declare character position members
5397 EMACS_INT.
5398
5399 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5400
04f2d78b
CB
5401 * textprop.c (verify_interval_modification, interval_of):
5402 Declare arguments EMACS_INT.
d1dfb56c
EZ
5403
5404 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5405 EMACS_INT.
5406
5407 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5408
5409 * indent.c (Fvertical_motion): Local variable it_start is now
5410 EMACS_INT.
5411
5412 * regex.c (re_match, re_match_2, re_match_2_internal)
5413 (bcmp_translate, regcomp, regexec, print_double_string)
5414 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5415 (re_compile_pattern, re_exec): Declare arguments and local
5416 variables `size_t' and `ssize_t' and return values `regoff_t', as
5417 appropriate.
5418 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5419 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5420 <compile_stack_type>: `size' and `avail' are now `size_t'.
5421
5422 * regex.h <regoff_t>: Use ssize_t, not int.
5423 (re_search, re_search_2, re_match, re_match_2): Arguments that
5424 specify buffer/string position and length are now ssize_t and
5425 size_t. Return type is regoff_t.
5426
613052cd
BK
54272011-04-16 Ben Key <bkey76@gmail.com>
5428
5429 * nsfont.m: Fixed bugs in ns_get_family and
5430 ns_descriptor_to_entity that were caused by using free to
5431 deallocate memory blocks that were allocated by xmalloc (via
5432 xstrdup). This caused Emacs to crash when compiled with
5433 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5434 --enable-checking=xmallocoverrun). xfree is now used to
5435 deallocate these memory blocks.
5436
4170f62f 54372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5438
71b41406
PE
5439 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5440
9587a89d
PE
5441 emacs_write: Accept and return EMACS_INT for sizes.
5442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5443 et seq.
5444 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5445 Accept and return EMACS_INT.
5446 (emacs_gnutls_write): Return the number of bytes written on
5447 partial writes.
5448 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5449 (emacs_read, emacs_write): Remove check for negative size, as the
5450 Emacs source code has been audited now.
9587a89d
PE
5451 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5452 (emacs_read, emacs_write): Use it.
273a5f82
PE
5453 * process.c (send_process): Adjust to the new signatures of
5454 emacs_write and emacs_gnutls_write. Do not attempt to store
5455 a byte offset into an 'int'; it might overflow.
9587a89d 5456 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5457
3e047f51
PE
5458 * sound.c: Don't assume sizes fit in 'int'.
5459 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5460 Return EMACS_INT, not int.
3e047f51 5461 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5462 Accept EMACS_INT, not int.
5463 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5464 record read return values.
5465
cc39a9db
BK
54662011-04-15 Ben Key <bkey76@gmail.com>
5467
c9d0ec6d
JB
5468 * keyboard.c (Qundefined): Don't declare static since it is used
5469 in nsfns.m.
5470 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5471 static since they are used in nsfont.m.
cc39a9db 5472
6c60eb9f
SM
54732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5474
5475 * process.c (Qprocessp): Don't declare static.
5476 * lisp.h (Qprocessp): Declare again.
5477
7990b61a
JB
54782011-04-15 Juanma Barranquero <lekktu@gmail.com>
5479
5480 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5481
5d4cb038
PE
54822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5483
8bd7b830 5484 Improve C-level modularity by making more things 'static'.
cd64ea1d 5485
e3b27b31
PE
5486 Don't publish debugger-only interfaces to other modules.
5487 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5488 (verify_bytepos, count_markers): Move decls to the only modules
5489 that need them.
5490 * region-cache.h (pp_cache): Likewise.
5491 * window.h (check_all_windows): Likewise.
5492 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5493
5d4cb038
PE
5494 * sysdep.c (croak): Now static, if
5495 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5496 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5497
5498 * alloc.c (refill_memory_reserve): Now static if
5499 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5500 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5501
e87b6180
PE
5502 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5503 Define only if USE_LUCID.
5504
ac64929e
PE
5505 * xrdb.c (x_customization_string, x_rm_string): Now static.
5506
6f37259d
PE
5507 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5508 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5509
1683e3ab
PE
5510 * xdisp.c (draw_row_with_mouse_face): Now static.
5511 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5512
de9c2632
PE
5513 * window.h (check_all_windows): Mark externally visible.
5514
2b96acb7
PE
5515 * window.c (window_deletion_count): Now static.
5516
5517 * undo.c: Make symbols static if they're not exported.
5518 (last_undo_buffer, last_boundary_position, pending_boundary):
5519 Now static.
5520
50436f33
PE
5521 * textprop.c (interval_insert_behind_hooks): Now static.
5522 (interval_insert_in_front_hooks): Likewise.
5523
64520e5c
PE
5524 * term.c: Make symbols static if they're not exported.
5525 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5526 (max_frame_lines, tty_set_terminal_modes):
5527 (tty_reset_terminal_modes, tty_turn_off_highlight):
5528 (get_tty_terminal): Now static.
5529 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5530 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5531 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5532 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5533 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5534
1fa53021
PE
5535 * sysdep.c: Make symbols static if they're not exported.
5536 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5537 Now static.
5538 (sigprocmask_set, full_mask): Remove; unused.
5539 (wait_debugging): Mark as visible.
5540 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5541 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5542
d4b43b22
PE
5543 * syntax.c (syntax_temp): Define only if !__GNUC__.
5544
b7c513d0
PE
5545 * sound.c (current_sound_device, current_sound): Now static.
5546
989b29ad
PE
5547 * search.c (searchbufs, searchbuf_head): Now static.
5548
13a55a78
PE
5549 * scroll.c (scroll_cost): Remove; unused.
5550 * dispextern.h (scroll_cost): Remove decl.
5551
de68a1fc
PE
5552 * region-cache.h (pp_cache): Mark as externally visible.
5553
40ccffa6
PE
5554 * process.c: Make symbols static if they're not exported.
5555 (process_tick, update_tick, create_process, chan_process):
5556 (Vprocess_alist, proc_buffered_char, datagram_access):
5557 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5558 (deactivate_process): Mark defn as static, as well as decl.
5559 * lisp.h (create_process): Remove decl.
5560 * process.h (chan_process, Vprocess_alist): Remove decls.
5561
ad64fc97
PE
5562 * print.c: Make symbols static if they're not exported.
5563 (print_depth, new_backquote_output, being_printed, print_buffer):
5564 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5565 (print_interval, print_number_index, initial_stderr_stream):
5566 Now static.
5567 * lisp.h (Fprinc): Remove decl.
5568 (debug_output_compilation_hack): Mark as externally visible.
5569
adddb265
PE
5570 * sysdep.c (croak): Move decl from here to syssignal.h.
5571 * syssignal.h (croak): Put it here, so the API can be checked when
5572 'croak' is called from dissociate_if_controlling_tty.
5573
1717ede2
PE
5574 * minibuf.c: Make symbols static if they're not exported.
5575 (minibuf_save_list, choose_minibuf_frame): Now static.
5576 * lisp.h (choose_minibuf_frame): Remove decl.
5577
fa5fb2bc
PE
5578 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5579
1e3890d1
PE
5580 * lread.c: Make symbols static if they're not exported.
5581 (read_objects, initial_obarray, oblookup_last_bucket_number):
5582 Now static.
5583 (make_symbol): Remove; unused.
5584 * lisp.h (initial_obarray, make_symbol): Remove decls.
5585
8a1414fa
PE
5586 * keyboard.c: Make symbols static if they're not exported.
5587 (single_kboard, recent_keys_index, total_keys, recent_keys):
5588 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5589 (this_single_command_key_start, echoing, last_auto_save):
5590 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5591 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5592 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5593 (Vlispy_mouse_stem, double_click_count):
5594 Now static.
5595 (force_auto_save_soon): Define only if SIGDANGER.
5596 (ignore_mouse_drag_p): Now static if
5597 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5598 (print_help): Remove; unused.
5599 (stop_character, last_timer_event): Mark as externally visible.
5600 * keyboard.h (ignore_mouse_drag_p): Declare only if
5601 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5602 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5603 * lisp.h (echoing): Remove decl.
5604 (force_auto_save_soon): Declare only if SIGDANGER.
5605 * xdisp.c (redisplay_window): Simplify code, to make it more
5606 obvious that ignore_mouse_drag_p is not accessed if !defined
5607 USE_GTK && !defined HAVE_NS.
5608
93ea6e8f
PE
5609 * intervals.c: Make symbols static if they're not exported.
5610 (merge_properties_sticky, merge_interval_right, delete_interval):
5611 Now static.
5612 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5613
77382fcc
PE
5614 * insdel.c: Make symbols static if they're not exported.
5615 However, leave prepare_to_modify_buffer alone. It's never
5616 called from outside this function, but that appears to be a bug.
5617 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5618 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5619 (adjust_after_replace_noundo): Remove; unused.
5620 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5621 (signal_before_change): Remove decls.
77382fcc 5622
9306c32e
PE
5623 * indent.c (val_compute_motion, val_vmotion): Now static.
5624
cd44d2eb
PE
5625 * image.c: Make symbols static if they're not exported.
5626 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5627 if USE_GTK.
5628 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5629 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5630
ad9a7a06
PE
5631 * fringe.c (standard_bitmaps): Now static.
5632 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5633
81626931
PE
5634 * frame.c: Make symbols static if they're not exported.
5635 (x_report_frame_params, make_terminal_frame): Now static.
5636 (get_frame_param): Now static, unless HAVE_NS.
5637 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5638 (x_get_resource_string): Remove; not used.
5639 * frame.h (make_terminal_frame, x_report_frame_params):
5640 (x_get_resource_string); Remove decls.
5641 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5642 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5643
239f9db9
PE
5644 * font.c, fontset.c: Make symbols static if they're not exported.
5645 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5646 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5647 * font.c (font_close_object): Now static.
5648 * font.h (font_close_object): Remove.
5649 * fontset.c (FONTSET_OBJLIST): Remove.
5650 (free_realized_fontset) #if-0 the body, which does nothing.
5651 (face_suitable_for_char_p): #if-0, as it's never called.
5652 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5653 * xfaces.c (face_at_string_position):
5654 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5655 since 0 is always ASCII.
5656
dfcf3579
PE
5657 * fns.c (weak_hash_tables): Now static.
5658
5045092b
PE
5659 * fileio.c: Make symbols static if they're not exported.
5660 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5661 (Vwrite_region_annotation_buffers): Now static.
5662
57a96f5c
PE
5663 * eval.c: Make symbols static if they're not exported.
5664 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5665 * lisp.h (backtrace_list): Remove decl.
5666
35f08c38
PE
5667 * emacs.c: Make symbols static if they're not exported.
5668 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5669 (fatal_error_code, fatal_error_signal_hook, standard_args):
5670 Now static.
5671 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5672 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5673 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5674 * lisp.h (fatal_error_signal_hook): Remove decl.
5675 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5676
f44bd759
PE
5677 * editfns.c: Move a (normally-unused) function to its only use.
5678 * editfns.c, lisp.h (get_operating_system_release): Remove.
5679 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5680 worth the hassle of breaking this out.
5681
b532497d
PE
5682 * xterm.c: Make symbols static if they're not exported.
5683 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5684 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5685 (x_destroy_window, x_delete_display):
5686 Now static.
5687 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5688 (x_mouse_leave): Remove; unused.
5689 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5690 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5691 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5692 Remove decls.
5693 (x_mouse_leave): Declare only if WINDOWSNT.
5694 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5695 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5696 USE_X_TOOLKIT.
5697
1675728f
PE
5698 * ftxfont.c: Make symbols static if they're not exported.
5699 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5700 HAVE_FREETYPE.
5701 * font.h (ftxfont_driver): Likewise.
5702
e4cebfca
PE
5703 * xfns.c: Make symbols static if they're not exported.
5704 (x_last_font_name, x_display_info_for_name):
5705 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5706 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5707 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5708 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5709 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5710 (last_show_tip_args): Now static.
5711 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5712 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5713 (x_screen_planes): Remove; unused.
5714 * dispextern.h (x_screen_planes): Remove decl.
5715
5bf46f05
PE
5716 * dispnew.c: Make symbols static if they're not exported.
5717 * dispextern.h (redraw_garbaged_frames, scrolling):
5718 (increment_row_positions): Remove.
5719 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5720 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5721 Now static.
5722 (redraw_garbaged_frames): Remove; unused.
5723
435f4c28
PE
5724 * xfaces.c: Make symbols static if they're not exported.
5725 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5726 Remove decls.
5727 * xterm.h (defined_color): Remove decls.
5728 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5729 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5730 (menu_face_changed_default, defined_color, free_realized_face):
5731 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5732 (ascii_face_of_lisp_face): Remove; unused.
5733
8524aef3
PE
5734 * xdisp.c: Make symbols static if they're not exported.
5735 * dispextern.h (scratch_glyph_row, window_box_edges):
5736 (glyph_to_pixel_coords, set_cursor_from_row):
5737 (get_next_display_element, set_iterator_to_next):
5738 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5739 (show_mouse_face): Remove decls
5740 * frame.h (message_buf_print): Likewise.
5741 * lisp.h (pop_message, set_message, check_point_in_composition):
5742 Likewise.
5743 * xterm.h (set_vertical_scroll_bar): Likewise.
5744 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5745 (message_buf_print, scratch_glyph_row, displayed_buffer):
5746 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5747 (get_next_display_element, show_mouse_face, window_box_edges):
5748 (frame_to_window_pixel_xy, check_point_in_composition):
5749 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5750 (glyph_to_pixel_coords): Remove; unused.
5751
16390cd2
PE
5752 * dired.c (file_name_completion): Now static.
5753
5754 * dbusbind.c (xd_in_read_queued_messages): Now static.
5755
a25f4dfa
PE
5756 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5757 * data.c (circular_list_error): Remove.
5758
14a9c8df
PE
5759 * commands.h (last_point_position, last_point_position_buffer):
5760 (last_point_position_window): Remove decls.
5761 * keyboard.c: Make these variables static.
5762
04f2d78b
CB
5763 * coding.h (coding, code_convert_region, encode_coding_gap):
5764 Remove decls.
74ab6df5
PE
5765 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5766 (iso_code_class, detect_coding, code_convert_region): Now static.
5767 (encode_coding_gap): Remove; unused.
5768
38dfbee1
PE
5769 * chartab.c (chartab_chars, chartab_bits): Now static.
5770
a2cb4e63
PE
5771 * charset.h (charset_iso_8859_1): Remove decl.
5772 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5773 Now static.
5774
127198fd
PE
5775 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5776 * ccl.c (Vccl_program_table): Now static.
5777 (check_ccl_update): Remove; unused.
5778
d85b608f
PE
5779 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5780 * category.h: ... from here.
5781 * category.c (check_category_table, set_category_set): Now static.
5782
31cd66f3
PE
5783 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5784 * lisp.h: Remove these decls.
5785
c358e587
PE
5786 * buffer.c (buffer_count): Remove unused var.
5787
e78aecca
PE
5788 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5789 so that it's not optimized away.
5790 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5791 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5792 exported only to the debugger.
5793
e192d7d3 5794 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5795 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5796
92470028
PE
5797 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5798 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5799 was inaccessible from Lisp.
5800 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5801 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5802
244ed907
PE
5803 alloc.c: Import and export fewer symbols, and remove unused items.
5804 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5805 is defined.
5806 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5807 it's not optimized away by whole-program optimization.
5808 (message_enable_multibyte, free_misc): Remove.
5809 (catchlist, handlerlist, mark_backtrace):
5810 Declare only if BYTE_MARK_STACK.
5811 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5812 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5813 (message_enable_multibyte): Remove decl.
5814 (free_misc, interval_free_list, float_block, float_block_index):
5815 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5816 (cons_free_list, last_marked_index):
5817 Now static.
5818 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5819 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5820 (mark_backtrace): Define only if BYTE_MARK_STACK.
5821 * xdisp.c (message_enable_multibyte): Now static.
5822
61c2b50e 5823 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5824 This makes it easier for human readers (and static analyzers)
5825 to see whether these variables are used from other modules.
5826 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5827 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5828 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5829 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5830 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5831 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5832 * xmenu.c, xselect.c:
5833 Declare Q* vars static if they are not used in other modules.
5834 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5835 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5836 Remove decls of unexported vars.
5837 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5838
95c82688
PE
5839 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5840
16a97296
PE
5841 Make Emacs functions such as Fatom 'static' by default.
5842 This makes it easier for human readers (and static analyzers)
5843 to see whether these functions can be called from other modules.
5844 DEFUN now defines a static function. To make the function external
5845 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5846 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5847 (Finit_image_library):
16a97296
PE
5848 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5849 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5850 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5851 Remove decls, since these functions are now static.
5852 (Funintern, Fget_internal_run_time): New decls, since these functions
5853 were already external.
95c82688 5854
16a97296
PE
5855 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5856 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5857 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5858 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5859 * keyboard.c, keymap.c, lread.c:
5860 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5861 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5862 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5863 Mark functions with DEFUE instead of DEFUN,
5864 if they are used in other modules.
5865 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5866 decls for now-static functions.
5867 * buffer.h (Fdelete_overlay): Remove decl.
5868 * callproc.c (Fgetenv_internal): Mark as internal.
5869 * composite.c (Fremove_list_of_text_properties): Remove decl.
5870 (Fcomposition_get_gstring): New forward static decl.
5871 * composite.h (Fcomposite_get_gstring): Remove decl.
5872 * dired.c (Ffile_attributes): New forward static decl.
5873 * doc.c (Fdocumntation_property): New forward static decl.
5874 * eval.c (Ffetch_bytecode): New forward static decl.
5875 (Funintern): Remove extern decl; now in .h file where it belongs.
5876 * fileio.c (Fmake_symbolic_link): New forward static decl.
5877 * image.c (Finit_image_library): New forward static decl.
5878 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5879 * intervals.h (Fprevious_property_change):
5880 (Fremove_list_of_text_properties): Remove decls.
5881 * keyboard.c (Fthis_command_keys): Remove decl.
5882 (Fcommand_execute): New forward static decl.
5883 * keymap.c (Flookup_key): New forward static decl.
5884 (Fcopy_keymap): Now static.
5885 * keymap.h (Flookup_key): Remove decl.
5886 * process.c (Fget_process): New forward static decl.
5887 (Fprocess_datagram_address): Mark as internal.
5888 * syntax.c (Fsyntax_table_p): New forward static decl.
5889 (skip_chars): Remove duplicate decl.
5890 * textprop.c (Fprevious_property_change): New forward static decl.
5891 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5892 Now internal.
5893 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5894 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5895
785bbd42
PE
5896 * editfns.c (Fformat): Remove unreachable code.
5897
8b913b57
AS
58982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5899
5900 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5901 change. (Bug#8496)
5902
a6744a35
EZ
59032011-04-13 Eli Zaretskii <eliz@gnu.org>
5904
5905 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5906 when at ZV. (Bug#8487)
5907
e7974947
AS
59082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5909
baad03f0
AS
5910 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5911 (Bug#8437)
5912 * keyboard.c (parse_tool_bar_item): Likewise.
5913 * sound.c (sound_cleanup, alsa_close): Likewise.
5914 * termcap.c (tgetent): Likewise.
5915 * xfns.c (x_default_font_parameter): Likewise.
5916 * xsettings.c (read_and_apply_settings): Likewise.
5917
e7974947
AS
5918 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5919 (overrun_check_free): Protoize.
5920
28272684
PE
59212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5922
5923 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5924 since callers should never pass a negative size.
5925 Change the signature to match that of plain 'read' and 'write'; see
5926 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5927 * lisp.h: Update prototypes of emacs_write and emacs_read.
5928
11997c76
EZ
59292011-04-11 Eli Zaretskii <eliz@gnu.org>
5930
5931 * xdisp.c (redisplay_window): Don't try to determine the character
5932 position of the scroll margin if the window start point w->startp
e896f03c 5933 is outside the buffer's accessible region. (Bug#8468)
11997c76 5934
8a2cbd72
EZ
59352011-04-10 Eli Zaretskii <eliz@gnu.org>
5936
5937 Fix write-region and its subroutines for buffers > 2GB.
5938 * fileio.c (a_write, e_write): Modify declaration of arguments and
5939 local variables to support buffers larger than 2GB.
5940 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5941
5942 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5943 argument, local variables, and return value.
5944
5945 * lisp.h: Update prototypes of emacs_write and emacs_read.
5946
5947 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5948
4073e537 59492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5950
1ebfdcb6
PE
5951 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5952
b2ded58d
PE
5953 Fix more problems found by GCC 4.6.0's static checks.
5954
7d66342c
PE
5955 * xdisp.c (vmessage): Use a better test for character truncation.
5956
bbf47d44
PE
5957 * charset.c (load_charset_map): <, not <=, for optimization,
5958 and to avoid potential problems with integer overflow.
9248994d 5959 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5960 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5961 * editfns.c (Fformat): Likewise.
1e69125e 5962 * syntax.c (skip_chars): Likewise.
3befa583 5963
e3019616
PE
5964 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5965 This also lets GCC 4.6.0 generate slightly better loop code.
5966
becfa255
PE
5967 * callint.c (Fcall_interactively): <, not <=, for optimization.
5968 (Fcall_interactively): Count the number of arguments produced,
5969 not the number of arguments given. This is simpler and lets GCC
5970 4.6.0 generate slightly better code.
5971
dae0cd48
PE
5972 * ftfont.c: Distingish more carefully between FcChar8 and char.
5973 The previous code passed unsigned char * to a functions like
5974 strlen and xstrcasecmp that expect char *, which does not
5975 conform to the C standard.
5976 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5977 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5978 char * when the C standard requires it.
5979
76032d70
PE
5980 * keyboard.c (read_char): Remove unused var.
5981
eb3f1cc8
PE
5982 * eval.c: Port to Windows vsnprintf (Bug#8435).
5983 Include <limits.h>.
5984 (SIZE_MAX): Define if the headers do not.
5985 (verror): Do not give up if vsnprintf returns a negative count.
5986 Instead, grow the buffer. This ports to Windows vsnprintf, which
5987 does not conform to C99. Problem reported by Eli Zaretskii.
5988 Also, simplify the allocation scheme, by avoiding the need for
5989 calling realloc, and removing the ALLOCATED variable.
5990
70476b54
PE
5991 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5992
12020a9e
PE
5993 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5994 But keep the doprint source code for now, as we might revamp it
5995 and use it again (Bug#8435).
ea6c7ae6
PE
5996 * lisp.h (doprnt): Remove.
5997 * Makefile.in (base_obj): Remove doprnt.o.
5998 * deps.mk (doprnt.o): Remove.
5999
5fdb398c
PE
6000 error: Print 32- and 64-bit integers portably (Bug#8435).
6001 Without this change, on typical 64-bit hosts error ("...%d...", N)
6002 was used to print both 32- and 64-bit integers N, which relied on
6003 undefined behavior.
6004 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6005 New macro.
6006 * lisp.h (error, verror): Mark as printf-like functions.
6007 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6008 Report overflow in size calculations when allocating printf buffer.
6009 Do not truncate output string at its first null byte.
6010 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6011 Truncate the output at a character boundary, since vsnprintf does not
6012 do that.
6013 * charset.c (check_iso_charset_parameter): Convert internal
6014 character to string before calling 'error', since %c now has the
6015 printf meaning.
6016 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6017 overflow when computing char to be passed to 'error'. Do not
6018 pass Lisp_Object to 'error'; pass the integer instead.
6019 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6020 formatted with plain %d.
6021
b189fa66
PE
6022 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6023
bff87ef0
PE
6024 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6025
7e2cac20
PE
6026 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6027
ce4d90b5
PE
6028 * xterm.c (x_catch_errors): Remove duplicate declaration.
6029
266c9547
PE
6030 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6031
79c49ad2
PE
6032 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6033
368f4090
JM
60342011-04-10 Jim Meyering <meyering@redhat.com>
6035
6036 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6037 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6038 return ssize_t not "int", and use size_t as the buffer length.
6039 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6040 * gnutls.h: Update declarations.
6041 * process.c (read_process_output): Use ssize_t, to match.
6042 (send_process): Likewise.
6043
a32d4040
CY
60442011-04-09 Chong Yidong <cyd@stupidchicken.com>
6045
6046 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6047
8546720e 60482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6049
04f2d78b
CB
6050 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6051 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6052
8546720e
GM
6053 * xterm.c (handle_one_xevent):
6054 * xmenu.c (create_and_show_popup_menu):
6055 * xselect.c (x_decline_selection_request)
6056 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6057
0a2f5c1a 60582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6059
6060 Fix some uses of `int' instead of EMACS_INT.
6061 * search.c (string_match_1, fast_string_match)
6062 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6063 (scan_buffer, find_next_newline_no_quit)
6064 (find_before_next_newline, search_command, Freplace_match)
6065 (Fmatch_data): Make some `int' variables be EMACS_INT.
6066
6067 * xdisp.c (display_count_lines): 3rd argument and return value now
6068 EMACS_INT. All callers changed.
6069 (pint2hrstr): Last argument is now EMACS_INT.
6070
6071 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6072 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6073 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6074 (decode_coding_utf_16, decode_coding_emacs_mule)
6075 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6076 (decode_coding_ccl, decode_coding_charset)
6077 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6078 (decode_coding_iso_2022, decode_coding_emacs_mule)
6079 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6080 <char_offset, last_offset>: Declare EMACS_INT.
6081 (encode_coding_utf_8, encode_coding_utf_16)
6082 (encode_coding_emacs_mule, encode_invocation_designation)
6083 (encode_designation_at_bol, encode_coding_iso_2022)
6084 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6085 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6086 Declare EMACS_INT.
6087 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6088 (encode_invocation_designation): Last argument P_NCHARS is now
6089 EMACS_INT.
6090 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6091 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6092
6093 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6094 All users changed.
6095
6096 * ccl.c (Fccl_execute_on_string): Declare some variables
6097 EMACS_INT.
6098
8546720e 60992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6100
6101 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6102
4e19a977
CS
61032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6104
6105 * process.c (Fformat_network_address): Doc fix.
6106
87302331
R
61072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6108
6109 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6110
cbb59342
CY
61112011-04-08 Chong Yidong <cyd@stupidchicken.com>
6112
6113 * keyboard.c (read_char): Call Lisp function help-form-show,
6114 instead of using internal_with_output_to_temp_buffer.
6115 (Qhelp_form_show): New var.
e0d38eeb 6116 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6117
6118 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6119
6120 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6121
e67a13ab
CY
61222011-04-06 Chong Yidong <cyd@stupidchicken.com>
6123
04f2d78b
CB
6124 * process.c (Flist_processes): Remove to Lisp.
6125 (list_processes_1): Delete.
e67a13ab 6126
973f782d
EZ
61272011-04-06 Eli Zaretskii <eliz@gnu.org>
6128
7c106b1e
EZ
6129 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6130
973f782d
EZ
6131 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6132
41cf7d1a 61332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6134
ca23cc88
PE
6135 Fix more problems found by GCC 4.6.0's static checks.
6136
f390e2d5
PE
6137 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6138
42eea0d0
PE
6139 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6140
b69769da 6141 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6142
f9541e84
PE
6143 * xdisp.c (vmessage): Mark as a printf-like function.
6144
13841b55
PE
6145 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6146
c136c10f
PE
6147 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6148
5e2d4a30
PE
6149 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6150 printf-like functions.
6151 (tiff_load): Add casts to remove these marks before passing them
6152 to system-supplied API.
6153
583f48b9
PE
6154 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6155
b25d760e
PE
6156 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6157 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6158 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6159 directly, rather than having caller test rule sign. This avoids
6160 some unnecessary tests.
6161 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6162 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6163 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6164
bc7b6697 6165 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6166 (xfont_open): Avoid unnecessary tests.
bc7b6697 6167
27ccc379
PE
6168 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6169
dcd5c89a
PE
6170 * composite.h, composite.c (composition_gstring_put_cache):
6171 Use EMACS_INT, not int, for length.
6172
b13a45c6
PE
6173 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6174 breaking out part of COMPOSITION_DECODE_RULE.
6175 (COMPOSITION_DECODE_RULE): Use it.
6176 * composite.c (get_composition_id): Remove unused local vars,
6177 by using the new macro.
6178
1e792e4d
PE
6179 * textprop.c (set_text_properties_1): Change while to do-while,
6180 since the condition is always true at first.
6181
dc6c6455 6182 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6183 (interval_deletion_adjustment): Return unsigned value.
6184 All uses changed.
dc6c6455 6185
aba7731a
PE
6186 * process.c (list_processes_1, create_pty, read_process_output):
6187 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6188 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6189 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6190 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6191 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6192
fdfc4bf3
PE
6193 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6194
fca8fe46 6195 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6196 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6197
06a0259a 6198 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6199 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6200 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6201
e7b9e80f
PE
6202 * print.c (print_error_message): Avoid int overflow.
6203
56201685
PE
6204 * font.c (font_list_entities): Redo for clarity,
6205 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6206
78834453 6207 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6208 (font_score): Avoid potential overflow in diff calculation.
78834453 6209
0bc0b309 6210 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6211 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6212
e610eaca
PE
6213 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6214
b895abce
PE
6215 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6216 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6217 can always succeed if overflow has undefined behavior.
6218
1f1d9321 6219 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6220 (wordify): Omit three unnecessary tests.
1f1d9321 6221
c59478bc
PE
6222 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6223 All callers changed. This avoids the need for an unused var.
6224
79b73827
PE
6225 * casefiddle.c (casify_region): Remove var that is set but not used.
6226
a4db5dfe
PE
6227 * dired.c (file_name_completion): Remove var that is set but not used.
6228
43aae36e
PE
6229 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6230
2a47c44d 6231 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6232 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6233
a37c69bf
PE
6234 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6235 Check for integer overflow on size calculations.
6236
328ab8e7
PE
6237 * buffer.c (Fprevious_overlay_change): Remove var that is set
6238 but not used.
6239
e5a2a5cb
PE
6240 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6241 Remove vars that are set but not used.
8d84a6eb 6242 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6243 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6244
a60e5f68
PE
6245 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6246
f661cb61 6247 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6248 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6249
f0397f5a
PE
6250 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6251 that are set but not used.
6252
8664db06 6253 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6254 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6255
6abdaa4a
PE
6256 * xselect.c (x_get_local_selection, x_handle_property_notify):
6257 Remove vars that are set but not used.
6258
0ce7538d 6259 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6260 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6261
9ae848fc
PE
6262 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6263 Remove var that is set but not used.
0b918413
PE
6264 (scroll_bar_windows_size): Now size_t, not int.
6265 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6266 Check for overflow.
9ae848fc 6267
a5a62657
PE
6268 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6269 (map_tty_color) [!defined MSDOS]: Likewise.
6270
5c5cdd39
PE
6271 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6272
66ebf983
PE
6273 * coding.c: Remove vars that are set but not used.
6274 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6275 All callers changed.
6276 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6277 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6278 (decode_coding_charset): Remove vars that are set but not used.
6279
1be4d761
PE
6280 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6281 that is set but not used.
6282
47553fa8
PE
6283 * print.c (print_object): Remove var that is set but not used.
6284
1f7196bf 6285 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6286 The gnulib version avoids calling malloc in the usual case,
6287 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6288 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6289 * filelock.c (current_lock_owner): Likewise.
6290 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6291 * sysdep.c: Include allocator.h, careadlinkat.h.
6292 (emacs_no_realloc_allocator): New static constant.
6293 (emacs_readlink): New function.
fdb61804
PE
6294 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6295 ../lib/careadlinkat.h.
d1fdcab7 6296
f84c17c7
SM
62972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6298
6299 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6300 first non-nil return value).
6301
ef3862ad
JD
63022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6303
6304 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6305 if not defined (Bug#8403).
6306
376a7006
JB
63072011-04-02 Juanma Barranquero <lekktu@gmail.com>
6308
6309 * xdisp.c (display_count_lines): Remove parameter `start',
6310 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6311 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6312 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6313 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6314 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6315 and thereabouts. All callers changed.
6316 (get_per_char_metric): Remove parameter `f', unused since
6317 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6318
6ca3801d
JM
63192011-04-02 Jim Meyering <meyering@redhat.com>
6320
6321 do not dereference NULL upon failed strdup
6322 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6323 (ns_get_family): Likewise.
6324
d8e2b5ba
JB
63252011-04-02 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6328
8c74fcbd
JD
63292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6330
6331 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6332 later (Bug#8403).
6333
7200d79c
SM
63342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6335
03408648 6336 Add lexical binding.
7200d79c 6337
03408648
SM
6338 * window.c (Ftemp_output_buffer_show): New fun.
6339 (Fsave_window_excursion):
6340 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6341
6342 * lread.c (lisp_file_lexically_bound_p): New function.
6343 (Fload): Bind Qlexical_binding.
6344 (readevalloop): Remove `evalfun' arg.
6345 Bind Qinternal_interpreter_environment.
6346 (Feval_buffer): Bind Qlexical_binding.
6347 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6348 Mark as dynamic.
6349 (syms_of_lread): Declare `lexical-binding'.
6350
6351 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6352
6353 * keyboard.c (eval_dyn): New fun.
6354 (menu_item_eval_property): Use it.
ca105506
SM
6355
6356 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6357
03408648
SM
6358 * fns.c (concat, mapcar1): Accept byte-code-functions.
6359
6360 * eval.c (Fsetq): Handle lexical vars.
6361 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6362 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6363 (FletX, Flet): Obey lexical binding.
6364 (Fcommandp): Handle closures.
6365 (Feval): New `lexical' arg.
6366 (eval_sub): New function extracted from Feval. Use it almost
6367 everywhere where Feval was used. Look up vars in lexical env.
6368 Handle closures.
6369 (Ffunctionp): Move from subr.el.
6370 (Ffuncall): Handle closures.
6371 (apply_lambda): Remove `eval_flags'.
6372 (funcall_lambda): Handle closures and new byte-code-functions.
6373 (Fspecial_variable_p): New function.
6374 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6375 but without exporting it to Lisp.
23aba0ea 6376
23aba0ea 6377 * doc.c (Fdocumentation, store_function_docstring):
03408648 6378 * data.c (Finteractive_form): Handle closures.
23aba0ea 6379
03408648
SM
6380 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6381 interactive spec.
ba83908c 6382
04f2d78b
CB
6383 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6384 New byte-codes.
03408648
SM
6385 (exec_byte_code): New function extracted from Fbyte_code to handle new
6386 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6387
03408648 6388 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6389
03408648 6390 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6391
e2abce01
JB
63922011-03-31 Juanma Barranquero <lekktu@gmail.com>
6393
6394 * xdisp.c (redisplay_internal): Fix prototype.
6395
63696a73 63962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6397
63696a73 6398 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6399 (try_scrolling): Use it when setting scroll_limit.
6400 Limit scrolling to 100 screen lines.
63696a73
EZ
6401 (redisplay_window): Even when falling back on "recentering",
6402 position point in the window according to scroll-conservatively,
6403 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6404
6405 (try_scrolling): When point is above the window, allow searching
6406 as far as scroll_max, or one screenful, to compute vertical
6407 distance from PT to the scroll margin position. This prevents
6408 try_scrolling from unnecessarily failing when
6409 scroll-conservatively is set to a value slightly larger than the
6410 window height. Clean up the case of PT below the margin at bottom
6411 of window: scroll_max can no longer be INT_MAX. When aggressive
6412 scrolling is in use, don't let point enter the opposite scroll
6413 margin as result of the scroll.
6414 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6415 threshold of 100 lines for never-recentering scrolling.
6416
e4cc2dfc
JB
64172011-03-31 Juanma Barranquero <lekktu@gmail.com>
6418
6419 * dispextern.h (move_it_by_lines):
6420 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6421 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6422 (message_log_check_duplicate): Remove parameters `prev_bol' and
6423 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6424 (redisplay_internal): Remove parameter `preserve_echo_area',
6425 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6426
6427 * indent.c (Fvertical_motion):
6428 * window.c (window_scroll_pixel_based, Frecenter):
6429 Don't pass `need_y_p' to `move_it_by_lines'.
6430
1c470562
SM
64312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6432
44f230aa
SM
6433 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6434 steal a few bits to be more compact.
6435 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6436 Remove unneeded casts.
6437
1c470562
SM
6438 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6439
888adce9
ZK
64402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6441
6442 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6443 binding" message (bug#7967).
6444
f838ed7b
PE
64452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6446
77861b95
PE
6447 Fix more problems found by GCC 4.6.0's static checks.
6448
de6dbc14
PE
6449 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6450 Remove unused local var.
6451
f838ed7b
PE
6452 * editfns.c (Fmessage_box): Remove unused local var.
6453
792c7b2b
PE
6454 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6455 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6456 Omit unused local vars.
c499e557 6457 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6458 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6459 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6460 Omit unused local var.
6461
ba0165e1
PE
6462 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6463 Don't assume string length fits in int.
32ad8845 6464 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6465 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6466
3c59b4c9
PE
6467 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6468 instead of alloca (Bug#8344).
6469
a3eed478 6470 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6471 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6472
eb4d412d
PE
6473 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6474
1658b401
PE
6475 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6476 concerns.
6477
6478 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6479
6480 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6481
9a2c6e05
PE
6482 * keyboard.c (syms_of_keyboard): Use the same style as later
6483 in this function when indexing through an array. This also
6484 works around GCC bug 48267.
6485
03d0a109
PE
6486 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6487
44f730c8
PE
6488 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6489
fe75f926
PE
6490 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6491 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6492
ffa8c828
PE
6493 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6494 This avoids undefined behavior on integer overflow, and is a bit
6495 more convenient anyway since it is compared to a size_t variable.
6496
c5101a77
PE
6497 Variadic C functions now count arguments with size_t, not int.
6498 This avoids an unnecessary limitation on 64-bit machines, which
6499 caused (substring ...) to crash on large vectors (Bug#8344).
6500 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6501 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6502 All variadic functions and their callers changed accordingly.
c5101a77
PE
6503 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6504 * data.c (arith_driver, float_arith_driver): Likewise.
6505 * editfns.c (general_insert_function): Likewise.
6506 * eval.c (struct backtrace.nargs, interactive_p)
6507 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6508 (funcall_lambda, mark_backtrace): Likewise.
6509 * fns.c (concat): Likewise.
6510 * frame.c (x_set_frame_parameters): Likewise.
6511 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6512 0 if not found, not -1. All callers changed.
6513
dd3f25f7
PE
6514 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6515 (stack_copy_size): Now size_t, not int.
6516 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6517
461c2ab9
JB
65182011-03-28 Juanma Barranquero <lekktu@gmail.com>
6519
6520 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6521 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6522 All callers changed.
6523
6524 * lisp.h (multibyte_char_to_unibyte):
6525 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6526 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6527 * character.h (CHAR_TO_BYTE8):
6528 * cmds.c (internal_self_insert):
6529 * editfns.c (general_insert_function):
6530 * keymap.c (push_key_description):
6531 * search.c (Freplace_match):
6532 * xdisp.c (message_dolog, set_message_1): All callers changed.
6533
f6d62986
SM
65342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6535
6536 * keyboard.c (safe_run_hook_funcall): New function.
6537 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6538 don't set the hook to nil, but remove the offending function instead.
6539 (Qcommand_hook_internal): Remove, unused.
6540 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6541 Vcommand_hook_internal.
6542
6543 * eval.c (enum run_hooks_condition): Remove.
6544 (funcall_nil, funcall_not): New functions.
6545 (run_hook_with_args): Call each function through a `funcall' argument.
6546 Remove `cond' argument, now redundant.
6547 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6548 (Frun_hook_with_args_until_failure): Adjust accordingly.
6549 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6550
1db5b1ad
JB
65512011-03-28 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * dispextern.h (string_buffer_position): Remove declaration.
6554
6555 * print.c (strout): Remove parameter `multibyte', unused since
6556 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6557
6558 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6559 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6560 All callers changed.
6561
6562 * w32.c (_wsa_errlist): Use braces for struct initializers.
6563
6564 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6565 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6566 All callers changed.
6567 (string_buffer_position): Likewise. Also, make static (it's never
6568 used outside xdisp.c).
6569 (cursor_row_p): Remove parameter `w', unused since
6570 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6571 (decode_mode_spec): Remove parameter `precision', introduced during
6572 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6573 All callers changed.
6574
5ffb62aa
JD
65752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6576
6577 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6578
461c2ab9 65792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6580
6581 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6582 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6583 (ns_update_auto_hide_menu_bar): New functions.
6584 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6585 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6586 ns_constrain_all_frames.
6587 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6588 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6589
5c380ffb
JD
65902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6591
6592 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6593
9af30bdf
GM
65942011-03-27 Glenn Morris <rgm@gnu.org>
6595
6596 * syssignal.h: Replace RETSIGTYPE with void.
6597 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6598 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6599 Replace SIGTYPE with void everywhere.
6600 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6601 * s/template.h (SIGTYPE): Remove commented out definition.
6602
e2abce01
JB
66032011-03-26 Eli Zaretskii <eliz@gnu.org>
6604
6605 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6606 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6607
f868cd8a
JB
66082011-03-26 Juanma Barranquero <lekktu@gmail.com>
6609
59eb0929
JB
6610 * w32.c (read_unc_volume): Use parameter `henum', instead of
6611 global variable `wget_enum_handle'.
6612
6613 * keymap.c (describe_vector): Remove parameters `indices' and
6614 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6615 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6616
f868cd8a
JB
6617 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6618
6619 * keyboard.c (timer_check): Remove parameter `do_it_now',
6620 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6621 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6622 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6623
6624 * keyboard.c (read_char):
6625 * w32menu.c (w32_menu_display_help):
6626 * xmenu.c (show_help_event, menu_help_callback):
6627 Adjust calls to `show_help_echo'.
6628
6629 * gtkutil.c (xg_maybe_add_timer):
6630 * keyboard.c (readable_events):
6631 * process.c (wait_reading_process_output):
6632 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6633
6634 * insdel.c (adjust_markers_gap_motion):
6635 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6636 (gap_left, gap_right): Don't call it.
6637
2ecf6fdb
CY
66382011-03-25 Chong Yidong <cyd@stupidchicken.com>
6639
6640 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6641 incurred during fontification.
6642
6b1f9ba4
JB
66432011-03-25 Juanma Barranquero <lekktu@gmail.com>
6644
6645 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6646 (DEFVAR_PER_BUFFER): Don't pass it.
6647
6648 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6649 (scrolling_window): Don't pass it.
6650
0f4a96b5
JB
66512011-03-25 Juanma Barranquero <lekktu@gmail.com>
6652
6653 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6654
6655 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6656 and `suffix'.
6657 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6658 of variables specific to SELinux and computation of `encoded_absname'.
6659
6660 * image.c (XPutPixel): Remove unused variable `height'.
6661
6662 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6663
6664 * unexw32.c (get_section_info): Remove unused variable `section'.
6665
6666 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6667 (system_process_attributes): Remove unused variable `sess'.
6668 (sys_read): Remove unused variable `err'.
6669
6670 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6671 (w32_wnd_proc): Remove unused variable `isdead'.
6672 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6673 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6674 (x_create_tip_frame): Remove unused variable `tem'.
6675
6676 * w32inevt.c (w32_console_read_socket):
6677 Remove unused variable `no_events'.
6678
6679 * w32term.c (x_draw_composite_glyph_string_foreground):
6680 Remove unused variable `width'.
6681
1149507c
JB
66822011-03-24 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * w32term.c (x_set_glyph_string_clipping):
6685 Don't pass uninitialized region to CombineRgn.
6686
9c88f339
JB
66872011-03-23 Juanma Barranquero <lekktu@gmail.com>
6688
6689 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6690 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6691 (Fx_close_connection): Remove unused variable `i'.
6692
6693 * w32font.c (w32font_draw): Return number of glyphs.
6694 (w32font_open_internal): Remove unused variable `i'.
6695 (w32font_driver): Add missing initializer.
6696
6697 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6698 (fill_in_menu): Remove unused variable `items_added'.
6699
6700 * w32term.c (last_mouse_press_frame): Remove static global variable.
6701 (w32_clip_to_row): Remove unused variable `f'.
6702 (x_delete_terminal): Remove unused variable `i'.
6703
6704 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6705 (NOTHING): Remove unused static global variable.
6706 (uniscribe_check_otf): Remove unused variable `table'.
6707 (uniscribe_font_driver): Add missing initializers.
6708
dee091a3
JD
67092011-03-23 Julien Danjou <julien@danjou.info>
6710
6711 * term.c (Fsuspend_tty, Fresume_tty):
6712 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6713 * window.c (temp_output_buffer_show):
6714 * insdel.c (signal_before_change):
6715 * frame.c (Fhandle_switch_frame):
6716 * fileio.c (Fdo_auto_save):
6717 * emacs.c (Fkill_emacs):
6718 * editfns.c (save_excursion_restore):
6719 * cmds.c (internal_self_insert):
6720 * callint.c (Fcall_interactively):
6721 * buffer.c (Fkill_all_local_variables):
6722 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6723 Use Frun_hooks.
0f4a96b5 6724 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6725 unconditionnaly since it does the check itself.
6726
2c520ab5 67272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6728
c9c49752
PE
6729 Fix more problems found by GCC 4.5.2's static checks.
6730
8abc3f12
PE
6731 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6732 the first time through the loop, since we know p0 < p1 then.
6733 This also avoids a gcc -Wstrict-overflow warning.
6734
a2d26660
PE
6735 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6736 leading to a memory leak, possible in functions like
6737 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6738 of objects (Bug#8318).
a2d26660 6739
916c72e9
PE
6740 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6741 that could (at least in theory) be that large.
6742
19ab8a18
PE
6743 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6744 This is less likely to overflow, and avoids undefined behavior if
6745 overflow does occur. All callers changed. Use strtoul to scan
6746 for the unsigned long integer.
b7cbbd6f
PE
6747 (pint2hrstr): Simplify and tune code slightly.
6748 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6749
f0641eff
PE
6750 * scroll.c (do_scrolling): Work around GCC bug 48228.
6751 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6752
7f650bb9
PE
6753 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6754 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6755 (validate_x_resource_name): Simplify count usage.
6756 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6757
37dd57d1
PE
6758 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6759 fail (Bug#8306).
81e56e61 6760
699979fc 6761 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6762
401bf9b4
PE
6763 * process.c (Fmake_network_process): Use socklen_t, not int,
6764 where POSIX says socklen_t is required in portable programs.
6765 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6766 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6767 (Fmake_network_process, server_accept_connection):
6768 (wait_reading_process_output, read_process_output):
6769 Likewise.
6770
b93aacde
PE
6771 * process.c: Rename or move locals to avoid shadowing.
6772 (list_processes_1, Fmake_network_process):
6773 (read_process_output_error_handler, exec_sentinel_error_handler):
6774 Rename or move locals.
4dc343ee 6775 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6776 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6777 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6778 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6779 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6780
af8a867c 6781 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6782 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6783 Include tparam.h instead, since it declares them.
af8a867c
PE
6784 * cm.h (PC): Remove extern decl; tparam.h now does this.
6785 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6786 * terminfo.c: Include tparam.h, to check interfaces.
6787 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6788 (tparam): Adjust signature to match interface in tparam.h;
6789 this removes some undefined behavior. Check that outstring and len
6790 are zero, which they always are with Emacs.
6791 * tparam.h (PC, BC, UP): New extern decls.
6792
0248044d 6793 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6794 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6795
8ff096c1 6796 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6797 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6798 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6799 (ftfont_list): Remove unused local.
49eaafba
PE
6800 (get_adstyle_property, ftfont_pattern_entity):
6801 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6802 Rename locals to avoid shadowing.
8ff096c1 6803
e2be39f6
PE
6804 * xfont.c (xfont_list_family): Mark var as initialized.
6805
c9735e30
PE
6806 * xml.c (make_dom): Now static.
6807
8f5201ae
PE
6808 * composite.c (composition_compute_stop_pos): Rename local to
6809 avoid shadowing.
b246f932
PE
6810 (composition_reseat_it): Remove unused locals.
6811 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6812 (composition_update_it): Mark var as initialized.
11b61122
PE
6813 (find_automatic_composition): Mark vars as initialized,
6814 with a FIXME (Bug#8290).
8f5201ae 6815
760fbc2c
PE
6816 character.h: Rename locals to avoid shadowing.
6817 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6818 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6819 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6820 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6821 to avoid shadowing.
6822
ff08eb85
PE
6823 * textprop.c (property_change_between_p): Remove; unused.
6824
fc7bf025
PE
6825 * intervals.c (interval_start_pos): Now static.
6826
235d7abc
PE
6827 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6828
44f230aa
SM
6829 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6830 Rename locals to avoid shadowing.
3e7d6594 6831
50060332
PE
6832 * sound.c (wav_play, au_play, Fplay_sound_internal):
6833 Fix pointer signedness.
d01f234b 6834 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6835 (wav_play): Initialize a variable to 0, to prevent undefined
6836 behavior (Bug#8278).
50060332 6837
c4fc4e30
PE
6838 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6839
918436ed
PE
6840 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6841
c939f91b
PE
6842 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6843 clobbering (Bug#8298).
b9c7f648
PE
6844 * sysdep.c (sys_subshell): Likewise.
6845 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6846
6bd8c144
PE
6847 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6848 This should get cleaned up, so that child_setup has the
6849 same signature on all platforms.
6850
7710357c 6851 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6852 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6853
c59da222
CY
68542011-03-22 Chong Yidong <cyd@stupidchicken.com>
6855
6856 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6857 not to be necessary, and produces flickering.
6858
66b87493
GM
68592011-03-20 Glenn Morris <rgm@gnu.org>
6860
6861 * config.in: Remove file.
6862
45b6f6d5
JB
68632011-03-20 Juanma Barranquero <lekktu@gmail.com>
6864
6865 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6866 are now in src/globals.h.
6867 (syms_of_minibuf): Remove spurious & from previous change.
6868
3ec03f7e
LL
68692011-03-20 Leo <sdl.web@gmail.com>
6870
6871 * minibuf.c (completing-read-function): New variable.
6872 (completing-read-default): Rename from completing-read.
6873 (completing-read): Call completing-read-function.
6874
b14e3e21
CY
68752011-03-19 Juanma Barranquero <lekktu@gmail.com>
6876
6877 * xfaces.c (Fx_load_color_file):
6878 Read color file from absolute filename (bug#8250).
6879
f2b726e6
JB
68802011-03-19 Juanma Barranquero <lekktu@gmail.com>
6881
6882 * makefile.w32-in: Update dependencies.
6883
09f6ff02
EZ
68842011-03-17 Eli Zaretskii <eliz@gnu.org>
6885
6886 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6887
29a6015a
PE
68882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6889
a3a6c54e
PE
6890 Fix more problems found by GCC 4.5.2's static checks.
6891
b766f867
PE
6892 * process.c (make_serial_process_unwind, send_process_trap):
6893 (sigchld_handler): Now static.
6894
be02381c
PE
6895 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6896 That way, the code declares only the vars that it needs.
6897 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6898 * s/cygwin.h (PTY_ITERATION): Likewise.
6899 * s/darwin.h (PTY_ITERATION): Likewise.
6900 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6901
57048744
PE
6902 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6903 * process.c (allocate_pty): Don't declare stb unless it's needed.
6904
7914961c 6905 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6906 (CONSTANTLIM): Remove; unused.
6907 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6908 Define only if needed.
7914961c 6909
b3967b18
PE
6910 * unexelf.c (unexec): Name an expression,
6911 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6912 Use a different way to cause a compilation error if anyone uses
6913 n rather than nn, a way that does not involve shadowing.
73366a00 6914 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6915
29a6015a
PE
6916 * deps.mk (unexalpha.o): Remove; unused.
6917
43cfc33e 6918 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6919 * unexec.h: New file.
ce701a33
PE
6920 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6921 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6922 Depend on unexec.h.
6923 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6924 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6925 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6926 Change as necessary to match prototype in unexec.h.
ce701a33 6927
01f44d5a
PE
6928 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6929 shadowing.
4f63c6bb 6930 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6931
a6670b0b
PE
6932 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6933 Rename locals to avoid shadowing.
6934
cef2010d 6935 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6936 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6937
d4d7173a
PE
6938 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6939
f08b802a
PE
6940 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6941 warning when compiling print.c.
6942
3ddb0639
PE
6943 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6944 instead of using an uninitialized var.
5ad03b97 6945 (font_sort_entities): Mark var as initialized.
3ddb0639 6946
170a2692
PE
6947 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6948
e663c700
PE
6949 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6950 pointers to constants.
89bc529a 6951 (font_parse_fcname): Remove unused vars.
7b81e2d0 6952 (font_delete_unmatched): Now static.
ea838e10 6953 (font_get_spec): Remove; unused.
13a547c6
PE
6954 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6955 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6956 Rename or move locals to avoid shadowing.
e663c700 6957
2a80c887 6958 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6959 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6960
1384fa33 6961 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6962 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6963
8b2c52e9
PE
6964 * alloc.c (mark_backtrace): Move decl from here ...
6965 * lisp.h: ... to here, so that it can be checked.
6966
475545b5 6967 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6968 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6969 (lisp_indirect_variable): Name an expression,
6970 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6971 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6972
b1349114 6973 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6974 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6975 Use const pointer when appropriate.
b1349114 6976
a2928364
PE
6977 * lisp.h (get_system_name, get_operating_system_release):
6978 Move decls here, to check interfaces.
6979 * process.c (get_operating_system_release): Move decl to lisp.h.
6980 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6981 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6982 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6983 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6984 (Fformat_time_string, Fencode_time, Finsert_char):
6985 (Ftranslate_region_internal, Fformat):
6986 Rename or remove local vars to avoid shadowing.
9710023e 6987 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6988
a415e694
PE
6989 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6990 avoid shadowing.
6991
8ef4622d
PE
6992 * lisp.h (eassert): Check that the argument compiles, even if
6993 ENABLE_CHECKING is not defined.
6994
946f9a5b
PE
6995 * data.c (Findirect_variable): Name an expression, to avoid
6996 gcc -Wbad-function-cast warning.
112396d6 6997 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6998 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6999 (Fmake_variable_buffer_local, Fmake_local_variable):
7000 Mark variables as initialized.
52746918 7001 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7002
e5aab7e7 7003 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7004 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7005 Rename locals to avoid shadowing.
dff45157
PE
7006 (mark_stack): Move local variables into the #ifdef region where
7007 they're used.
7bc26fdb
PE
7008 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7009 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7010 needed otherwise.
7011 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7012 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7013 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7014
e5aab7e7
PE
7015 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7016 avoids undefined behavior in theory.
7017
4da60324
PE
7018 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7019
88043301
PE
7020 Use functions, not macros, for up- and down-casing (Bug#8254).
7021 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7022 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7023 to use the following functions instead of these macros.
7024 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7025 EMACS_INT, since callers assume the returned value fits in int.
7026 (upcase1): Likewise, for UPCASE_TABLE.
7027 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7028 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7029 the race-condition problem in the old DOWNCASE.
88043301 7030
19ed5445
PE
7031 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7032 Rename locals to avoid shadowing.
7033 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7034 (regex_compile, re_search_2, re_match_2_internal):
7035 Remove unused local vars.
952db0d7
PE
7036 (FREE_VAR): Rewrite so as not to use empty "else",
7037 which gcc can warn about.
da053e48 7038 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7039 (RETALLOC_IF): Define only if needed.
7040 (WORDCHAR_P): Likewise. This one is never needed, but is used
7041 only in a comment talking about a compiler bug, so put inside
7042 the #if 0 of that comment.
7043 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7044 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7045 Remove; unused.
19ed5445 7046
1f3561e4 7047 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7048 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7049 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7050
ded6f8f7
PE
7051 * search.c (simple_search): Remove unused var.
7052
dbd37a95
PE
7053 * dired.c (compile_pattern): Move decl from here ...
7054 * lisp.h: ... to here, so that it can be checked.
7055 (struct re_registers): New forward decl.
7056
7e47afad
PE
7057 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7058
85f24f61
PE
7059 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7060 All uses changed.
7061 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7062 Rename locals to avoid shadowing.
5671df8f 7063 (Fvertical_motion): Mark locals as initialized.
85f24f61 7064
181aa2be 7065 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7066 (casify_region): Mark local as initialized.
181aa2be 7067
930d429c
PE
7068 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7069
7082eac6
PE
7070 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7071 New macros, so that the caller can use some names other than
7072 gcpro1, gcpro2, etc.
7073 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7074 of the new macros.
7075 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7076 argument, for consistency with GCPRO2_VAR, etc: it is now the
7077 prefix of the variable, not the variable itself. All uses
7078 changed.
38b2c076
PE
7079 * dired.c (directory_files_internal, file_name_completion):
7080 Rename locals to avoid shadowing.
7081
15206ed9
PE
7082 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7083 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7084 dired.c's scmp function, had undefined behavior.
7085 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7086 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7087 * buffer.h: ... to here, because these macros use current_buffer,
7088 and the new implementation with inline functions needs to have
7089 current_buffer in scope now, rather than later when the macros
7090 are used.
7091 (downcase, upcase1): New static inline functions.
7092 (DOWNCASE, UPCASE1): Reimplement using these functions.
7093 This avoids undefined behavior in expressions like
7094 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7095 from race conditions in accessing the global variables
7096 case_temp1 and case_temp2.
7097 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7098 * lisp.h (case_temp1, case_temp2): Remove their decls.
7099 * character.h (ASCII_CHAR_P): Move from here ...
7100 * lisp.h: ... to here, so that the inline functions mentioned
7101 above can use them.
7102
4a6bea26
PE
7103 * dired.c (directory_files_internal_unwind): Now static.
7104
f14b7e14
PE
7105 * fileio.c (file_name_as_directory, directory_file_name):
7106 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7107 Now static.
2893f146
PE
7108 (file_name_as_directory): Use const pointers when appropriate.
7109 (Fexpand_file_name): Likewise. In particular, newdir might
7110 point at constant storage, so make it a const pointer.
fd4ead52 7111 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7112 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7113 signedness issues.
f839df0c
PE
7114 (Fset_file_times, Finsert_file_contents, auto_save_error):
7115 Rename locals to avoid shadowing.
f14b7e14 7116
5716756e 7117 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7118 (Ftry_completion, Fall_completions): Rename or remove locals
7119 to avoid shadowing.
5716756e 7120
b4c3046a
PE
7121 * marker.c (bytepos_to_charpos): Remove; unused.
7122
b45db522
PE
7123 * lisp.h (verify_bytepos, count_markers): New decls,
7124 so that gcc does not warn that these functions aren't declared.
7125
85876d07
PE
7126 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7127 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7128 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7129 (copy_text): Remove unused local var.
85876d07 7130
03d78a21 7131 * filelock.c (within_one_second): Now static.
b3dd38ab 7132 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7133
5df8f01b
PE
7134 * buffer.c (fix_overlays_before): Mark locals as initialized.
7135 (fix_start_end_in_overlays): Likewise. This function should be
7136 simplified by using pointers-to-pointers, but that's a different
7137 matter.
b1d876f1 7138 (switch_to_buffer_1): Now static.
8f54f30a
PE
7139 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7140 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7141
a70072c9 7142 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7143 Fix pointer signedness issue.
edced198
PE
7144 (sys_subshell): Mark local as volatile if checking for lint,
7145 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7146 (MAXPATHLEN): Define only if needed.
a70072c9 7147
a0977c44
PE
7148 * process.c (serial_open, serial_configure): Move decls from here ...
7149 * systty.h: ... to here, so that they can be checked.
7150
a884fdcc
PE
7151 * fns.c (get_random, seed_random): Move extern decls from here ...
7152 * lisp.h: ... to here, so that they can be checked.
7153
604efe86 7154 * sysdep.c (reset_io): Now static.
b8950c94 7155 (wait_for_termination_signal): Remove; unused.
604efe86 7156
38fc62d9
PE
7157 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7158 (copy_keymap_item, append_key, push_text_char_description):
7159 Now static.
1004a21a 7160 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7161 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7162 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7163 (describe_map_tree):
7164 Rename locals to avoid shadowing.
38fc62d9 7165
2f2650da
PE
7166 * keyboard.c: Declare functions static if they are not used elsewhere.
7167 (echo_char, echo_dash, cmd_error, top_level_2):
7168 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7169 (read_char, kbd_buffer_get_event, make_lispy_position):
7170 (make_lispy_event, make_lispy_movement, apply_modifiers):
7171 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7172 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7173 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7174 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7175 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7176
a053e86c 7177 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7178 (mark_kboards): Move decl here ...
7179 * alloc.c (mark_kboards): ... from here.
a053e86c 7180
4752793e
PE
7181 * lisp.h (force_auto_save_soon): New decl.
7182
74f10ca7 7183 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7184 (DEFINE_DUMMY_FUNCTION): New macro.
7185 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7186 Use it.
c03cd23f
PE
7187 (main): Add casts to avoid warnings
7188 if GCC considers string literals to be constants.
74f10ca7 7189
022e70d4
PE
7190 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7191
59d6fe83
PE
7192 * dbusbind.c: Pointer signedness fixes.
7193 (xd_signature, xd_append_arg, xd_initialize):
7194 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7195 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7196 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7197 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7198
78320123
PE
7199 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7200 if GCC considers string literals to be constants.
49cebcca 7201 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7202
35ac2a97
SM
72032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7204
fb103ca9
SM
7205 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7206 (print_preprocess, print_object): New macro to fix last change.
7207
35ac2a97
SM
7208 * print.c (print_preprocess): Don't forget font objects.
7209
62973b41
JB
72102011-03-16 Juanma Barranquero <lekktu@gmail.com>
7211
7212 * emacs.c (USAGE3): Doc fixes.
7213
0e48bb22
AS
72142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7215
7216 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7217 structure.
7218
7684e57b
JB
72192011-03-14 Juanma Barranquero <lekktu@gmail.com>
7220
7221 * lisp.h (VWindow_system, Qfile_name_history):
7222 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7223 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7224 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7225
7226 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7227 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7228
7229 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7230 * w32console.c (detect_input_pending, read_input_pending)
7231 (encode_terminal_code):
7232 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7233 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7234 (w32_system_caret_y, Qfile_name_history):
7235 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7236 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7237 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7238 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7239 * w32proc.c (Qlocal, report_file_error):
7240 * w32term.c (Vwindow_system, updating_frame):
7241 * w32uniscribe.c (initialized, uniscribe_font_driver):
7242 Remove unneeded extern declarations.
7243
2aa46d6c
CY
72442011-03-14 Chong Yidong <cyd@stupidchicken.com>
7245
c96bbc66 7246 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7247
cffc6f3b
CY
72482011-03-13 Chong Yidong <cyd@stupidchicken.com>
7249
7250 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7251 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7252 These macros can no longer be used for assignment.
7253
44f230aa
SM
7254 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7255 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7256 (record_buffer_markers, fetch_buffer_markers): New functions for
7257 recording and fetching special buffer markers.
7258 (set_buffer_internal_1, set_buffer_temp): Use them.
7259
7260 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7261
7262 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7263
7264 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7265 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7266
7267 * xdisp.c (hscroll_window_tree):
7268 (reconsider_clip_changes): Use PT instead of BUF_PT.
7269
d251f04b
EZ
72702011-03-13 Eli Zaretskii <eliz@gnu.org>
7271
7272 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7273 $(EMACS_ROOT)/lib/intprops.h.
7274
f0c77cd1
PE
72752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7276
3eca4629
PE
7277 Fix more problems found by GCC 4.5.2's static checks.
7278
7c86ee98
PE
7279 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7280 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7281 (xg_free_frame_widgets): Make it clear that a local variable is
7282 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7283 (gdk_window_get_screen): Make it clear that this macro is needed
7284 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7285 (int_gtk_range_get_value): New function, which avoids a diagnostic
7286 from gcc -Wbad-function-cast.
7287 (xg_set_toolkit_scroll_bar_thumb): Use it.
7288 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7289 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7290 (get_utf8_string, xg_get_file_with_chooser):
7291 Rename locals to avoid shadowing.
7292 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7293
41729b81
PE
7294 * xgselect.c (xg_select): Remove unused var.
7295
f0c77cd1
PE
7296 * image.c (four_corners_best): Mark locals as initialized.
7297 (gif_load): Initialize transparent_p to zero (Bug#8238).
7298 Mark another local as initialized.
ec6cf4c6 7299 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7300
ce0ad53d 7301 * image.c (clear_image_cache): Now static.
d5d5a617 7302 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7303 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7304 (x_edge_detection): Remove unnecessary cast that
7305 gcc -Wbad-function-cast diagnoses.
2037898d 7306 (gif_load): Fix pointer signedness.
6ae141d6
PE
7307 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7308 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7309
33383987 73102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7311
d32df629
PE
7312 Improve quality of tests for time stamp overflow.
7313 For example, without this patch (encode-time 0 0 0 1 1
7314 1152921504606846976) returns the obviously-bogus value (-948597
7315 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7316 reports time overflow. See
7317 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7318 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7319 * editfns.c: Include limits.h and intprops.h.
7320 (TIME_T_MIN, TIME_T_MAX): New macros.
7321 (time_overflow): Move earlier, to before first use.
7322 (hi_time, lo_time): New functions, for an accurate test for
7323 out-of-range times.
7324 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7325 (Fget_internal_run_time): Don't assume time_t fits in int.
7326 (make_time): Use list2 instead of Fcons twice.
7327 (Fdecode_time): More accurate test for out-of-range times.
7328 (check_tm_member): New function.
7329 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7330 (lisp_time_argument): Don't rely on undefined left-shift and
7331 right-shift behavior when checking for time stamp overflow.
8be6f318 7332
fe31d94c
PE
7333 * editfns.c (time_overflow): New function, refactoring common code.
7334 (Fformat_time_string, Fdecode_time, Fencode_time):
7335 (Fcurrent_time_string): Use it.
7336
8be6f318
PE
7337 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7338 * dired.c (make_time): Move to ...
7339 * editfns.c (make_time): ... here.
7340 * systime.h: Note the move.
7341
09d9db2c 73422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7343
126bc0dc
YM
7344 * fringe.c (update_window_fringes): Remove unused variables.
7345
c47cbdfd
YM
7346 * unexmacosx.c (copy_data_segment): Also copy __got section.
7347 (Bug#8223)
7348
7ac80be9
EZ
73492011-03-12 Eli Zaretskii <eliz@gnu.org>
7350
c96bbc66 7351 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7352 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7353 Constify `char *' arguments and their references according to
7354 prototypes in tparam.h.
7355
ecb0f94d 7356 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7357
7ac80be9
EZ
7358 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7359 Adapt all references accordingly.
7360
7361 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7362
ef1fd07e
TT
73632011-03-11 Tom Tromey <tromey@redhat.com>
7364
7365 * buffer.c (syms_of_buffer): Remove obsolete comment.
7366
7ef4b50c
EZ
73672011-03-11 Eli Zaretskii <eliz@gnu.org>
7368
7369 * termhooks.h (encode_terminal_code): Declare prototype.
7370
7371 * msdos.c (encode_terminal_code): Don't declare prototype.
7372
7373 * term.c (encode_terminal_code): Now external again, used by
7374 w32console.c and msdos.c.
7375
44f230aa
SM
7376 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7377 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7378
4b1ec863 73792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7380
1714f52b 7381 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7382
4b1ec863
PE
7383 * fringe.c (update_window_fringes): Mark locals as initialized
7384 (Bug#8227).
7385 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7386
524c7aa6
PE
7387 * alloc.c (mark_fringe_data): Move decl from here ...
7388 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7389 to check its interface.
7390 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7391
a5c0af81 7392 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7393 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7394 (fontset_font): Mark local as initialized.
a9a06e0b 7395 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7396
b4716021
PE
7397 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7398
811e9bac 7399 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7400 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7401 (x_own_selection, Fx_disown_selection_internal): Rename locals
7402 to avoid shadowing.
7403 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7404
7e3ab302
PE
7405 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7406 so that the caller can use some name other than gcpro1.
7407 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7408 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7409 (Fx_backspace_delete_keys_p):
7410 Use them to avoid shadowing, and rename vars to avoid shadowing.
7411 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7412 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7413 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7414 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7415 Remove unused locals.
7e3ab302
PE
7416 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7417 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7418 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7419 macros.
f78faa98 7420
e2b13473
PE
7421 * xterm.h (x_mouse_leave): New decl.
7422
77f23912
PE
7423 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7424 Remove unused functions.
cdf4ba58
PE
7425 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7426 (x_calc_absolute_position): Now static.
7411c686 7427 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7428 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7429 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7430 unless they are used.
38d0b34a
PE
7431 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7432 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7433 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7434 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7435 (x_error_catcher, x_connection_closed, x_error_handler):
7436 (x_error_quitter, xembed_send_message, x_iconify_frame):
7437 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7438 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7439 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7440
44f230aa
SM
7441 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7442 Rename or move locals to avoid shadowing.
6b463e58 7443 (tty_defined_color, merge_face_heights): Now static.
5967d051 7444 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7445 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7446 does not deduce is never used uninitialized.
73719eba
PE
7447 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7448 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7449
426994c3 7450 * terminal.c (store_terminal_param): Now static.
5489860b 7451
032f1620 7452 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7453 (set_frame_menubar): Remove unused local.
d4323972 7454 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7455 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7456 since they might point to immutable storage.
281585b0
PE
7457 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7458 since it's unused otherwise.
032f1620 7459
367c19e5 7460 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7461 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7462 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7463 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7464 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7465 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7466 does not deduce are never used uninitialized.
70739cbe 7467
07b48fa9
PE
7468 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7469
8868a238 7470 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7471 * window.c (window_loop, size_window):
7472 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7473
7e5cf297 7474 * window.c (display_buffer): Now static.
d6550a9f
PE
7475 (size_window): Mark variables that gcc -Wuninitialized
7476 does not deduce are never used uninitialized.
a586633d
PE
7477 * window.h (check_all_windows): New decl, to forestall
7478 gcc -Wmissing-prototypes diagnostic.
5b555da1 7479 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7480
f6095868
PE
7481 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7482 shadowing.
7483 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7484 Include <limits.h>.
7485 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7486 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7487 (load_charset_map): Mark variables that gcc -Wuninitialized
7488 does not deduce are never used uninitialized.
53df7c11 7489 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7490
f38b440c
PE
7491 * coding.c (coding_set_source, coding_set_destination):
7492 Use "else { /* comment */ }" rather than "else /* comment */;"
7493 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7494 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7495 a block, when the outer 'i' will do.
7496 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7497 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7498 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7499 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7500 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7501 Rename locals to avoid shadowing.
7502 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7503 * coding.c (emacs_mule_char, encode_invocation_designation):
7504 Now static, since they're not used elsewhere.
413bb2db 7505 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7506 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7507 (decode_coding_emacs_mule): Mark variables that gcc
7508 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7509 (detect_coding_iso_2022): Initialize a local variable that might
7510 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7511 this initialization is needed. (Bug#8211)
5f58e762
PE
7512 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7513 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7514 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7515 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7516 Remove unused macros.
f38b440c 7517
232b38b9 7518 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7519 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7520 * character.c (string_count_byte8): Likewise.
232b38b9 7521
fb90da1b
PE
7522 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7523 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7524
fb93dbc2
PE
7525 * chartab.c (copy_sub_char_table): Now static, since it's not used
7526 elsewhere.
5c156ace
PE
7527 (sub_char_table_ref_and_range, char_table_ref_and_range):
7528 Rename locals to avoid shadowing.
bbcd0949 7529 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7530
7d3b3862 7531 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7532 (BIDI_BOB): Remove unused macro.
7d3b3862 7533
6be7d3da
PE
7534 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7535 deduce are never used uninitialized.
c2ed9c8b 7536 * term.c (encode_terminal_code): Likewise.
6be7d3da 7537
75f8807f 7538 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7539
50938595
PE
7540 * tparam.h: New file.
7541 * term.c, tparam.h: Include it.
7542 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7543 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7544 Move these decls to tparam.h, and make them agree with what
7545 is actually in tparam.c. The previous trick of using incompatible
7546 decls in different modules does not conform to the C standard.
7547 All callers of tparam changed to use tparam's actual API.
7548 * tparam.c (tparam1, tparam, tgoto):
7549 Use const pointers where appropriate.
7550
fbceeba2
PE
7551 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7552 * cm.h (struct cm): Likewise.
7553 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7554 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7555 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7556 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7557 (turn_on_face, init_tty): Likewise.
7558 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7559
7f3f1250
PE
7560 * term.c (term_mouse_position): Rename local to avoid shadowing.
7561
e6ca6543
PE
7562 * alloc.c (mark_ttys): Move decl from here ...
7563 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7564
c40f8d15
AS
75652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7566
7567 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7568
cfe0661d
JB
75692011-03-09 Juanma Barranquero <lekktu@gmail.com>
7570
7571 * search.c (compile_pattern_1): Remove argument regp, unused since
7572 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7573 (compile_pattern): Don't pass it.
7574
0afb4571
J
75752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7576
7577 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7578 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7579 for ! HAVE_GTK3.
7580 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7581
7582 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7583
7584 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7585 gdk_window_get_screen, gdk_window_get_geometry,
7586 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7587 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7588 (xg_get_pixbuf_from_pixmap): New function.
7589 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7590 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7591 Call xg_get_pixbuf_from_pixmap instead of
7592 gdk_pixbuf_get_from_drawable.
7593 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7594 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7595 (xg_check_special_colors): Use GtkStyleContext and its functions
7596 for HAVE_GTK3.
7597 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7598 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7599 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7600 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7601 Call gtk_widget_get_preferred_size.
0afb4571
J
7602 (xg_frame_resized): gdk_window_get_geometry only takes 5
7603 parameters.
44f230aa
SM
7604 (xg_win_to_widget, xg_event_is_for_menubar):
7605 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7606 (xg_set_widget_bg): New function.
7607 (delete_cb): New function.
895009e1 7608 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7609 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7610 (xg_set_background_color): Call xg_set_widget_bg.
7611 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7612 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7613 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7614 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7615 if ! HAVE_GTK3.
7616 (update_frame_tool_bar): Call gtk_widget_hide.
7617 (xg_initialize): Use GDK_KEY_g.
7618
7619 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7620 if ! HAVE_GTK3
7621 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7622
7623 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7624 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7625 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7626
1c2cc4ef
JB
76272011-03-08 Juanma Barranquero <lekktu@gmail.com>
7628
7629 * w32xfns.c (select_palette): Check success of RealizePalette against
7630 GDI_ERROR, not zero.
7631
33383987 7632See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7633
7634;; Local Variables:
7635;; coding: utf-8
aac0c6e3
MR
7636;; End:
7637
33383987 7638 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7639
7640 This file is part of GNU Emacs.
7641
7642 GNU Emacs is free software: you can redistribute it and/or modify
7643 it under the terms of the GNU General Public License as published by
7644 the Free Software Foundation, either version 3 of the License, or
7645 (at your option) any later version.
7646
7647 GNU Emacs is distributed in the hope that it will be useful,
7648 but WITHOUT ANY WARRANTY; without even the implied warranty of
7649 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7650 GNU General Public License for more details.
7651
7652 You should have received a copy of the GNU General Public License
7653 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.