* alloc.c (make_event_array): Use XINT, not XUINT.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fdccd48e
PE
12011-05-23 Paul Eggert <eggert@cs.ucla.edu>
2
c11285dc
PE
3 * alloc.c (make_event_array): Use XINT, not XUINT.
4 There's no need for unsigned here.
5
fdccd48e
PE
6 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7 This follows up to the 2011-05-06 change that substituted uintptr_t
8 for EMACS_INT. This case wasn't caught back then.
9
2e6578fb
PE
102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11
37910ab2
PE
12 Rework Fformat to avoid integer overflow issues.
13 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14 now (part of C89). Include <verify.h>.
15 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
16 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
17 (Fformat): Avoid the prepass trying to compute sizes; it was only
18 approximate and thus did not catch overflow reliably. Instead, walk
19 through the format just once, formatting and computing sizes as we go,
20 checking for integer overflow at every step, and allocating a larger
21 buffer as needed. Keep track separately whether the format is
22 multibyte. Keep only the most-recently calculated precision, rather
23 than them all. Record whether each argument has been converted to
24 string. Use EMACS_INT, not int, for byte and char and arg counts.
25 Support field widths and precisions larger than INT_MAX. Avoid
26 sprintf's undefined behavior with conversion specifications such as %#d
27 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
28 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
29 formatting out-of-range floating point numbers with int
30 formats. (Bug#8668)
31
2e6578fb
PE
32 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
33
0ae6bdee
PE
34 * data.c: Avoid integer truncation in expressions involving floats.
35 * data.c: Include <intprops.h>.
36 (arith_driver): When there's an integer overflow in an expression
37 involving floating point, convert the integers to floating point
38 so that the resulting value does not suffer from catastrophic
39 integer truncation. For example, on a 64-bit host (* 4
40 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
41 Do not rely on undefined behavior after integer overflow.
42
de883a70
PE
43 merge count_size_as_multibyte, parse_str_to_multibyte
44 * character.c, character.h (count_size_as_multibyte):
45 Renamed from parse_str_to_multibyte; all uses changed.
46 Check for integer overflow.
47 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
48 since it's now a duplicate of the other. This is more of
49 a character than a buffer op, so better that it's in character.c.
50 * fns.c, print.c: Adjust to above changes.
51
7400048f
PE
522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
53
54 * gnutls.c: Remove unused macros.
55 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
56 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
57 Remove macros that are defined and never used.
58 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
59
abb71cf4
CY
602011-05-22 Chong Yidong <cyd@stupidchicken.com>
61
62 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
63 (Fx_get_selection_internal): Minor cleanup.
64 (Fx_own_selection_internal): Rename arguments for consistency with
65 select.el.
66
6307db39
PE
672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
68
69 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
70
f3d4e0a4
CY
712011-05-22 Chong Yidong <cyd@stupidchicken.com>
72
73 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
74
4d8ade89
YM
752011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
76
77 * dispnew.c (scrolling_window): Don't exclude the case that the
78 last enabled row in the desired matrix touches the bottom boundary.
79
32078c8d
GM
802011-05-21 Glenn Morris <rgm@gnu.org>
81
82 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
83 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
84 and add some more files.
32078c8d 85
7285dc67
EZ
862011-05-20 Eli Zaretskii <eliz@gnu.org>
87
88 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
89 report_file_error introduced by the change from 2011-05-07.
90
89d1bd22
PE
912011-05-20 Paul Eggert <eggert@cs.ucla.edu>
92
93 * systime.h (Time): Define only if emacs is defined.
94 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
95 where the include path doesn't have X11/X.h by default. See
96 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
97
e23640bb 982011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
99
100 * composite.c (find_automatic_composition): Fix previous change.
101
b9704ad9
GM
1022011-05-20 Glenn Morris <rgm@gnu.org>
103
104 * lisp.mk: New file, split from Makefile.in.
105 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
106 (shortlisp): Remove.
107 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
108
4a720484
GM
1092011-05-19 Glenn Morris <rgm@gnu.org>
110
111 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
112 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
113 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
114 (lisp): Set the order to that of loadup.el.
115 (shortlisp): Make it a copy of $lisp.
116 (SOME_MACHINE_LISP): Remove.
117 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
118 Use just $shortlisp, not $SOME_MACHINE_LISP too.
119
a28d4396
KH
1202011-05-18 Kenichi Handa <handa@m17n.org>
121
122 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
123 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
124 (find_automatic_composition): Mostly rewrite for efficiency.
125
a2b1fa8e
JB
1262011-05-18 Juanma Barranquero <lekktu@gmail.com>
127
128 * makefile.w32-in: Update dependencies.
129
8e1f5610
CS
1302011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
131
132 * menu.c: Include limits.h (fixes the MS-Windows build broken by
133 revision 104625).
134
7025ee00 1352011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 136
cdfa6eab
PE
137 Fix some integer overflow issues, such as string length overflow.
138
06d6db33
PE
139 * insdel.c (count_size_as_multibyte): Check for string overflow.
140
2b4560a8
PE
141 * character.c (lisp_string_width): Check for string overflow.
142 Use EMACS_INT, not int, for string indexes and lengths; in
143 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
144 the resulting string length overflows an EMACS_INT; instead,
145 report a string overflow if no precision given. When checking for
146 precision exhaustion, use a check that cannot possibly have
147 integer overflow. (Bug#8675)
148 * character.h (lisp_string_width): Adjust to new signature.
149
cb93f9be
PE
150 * alloc.c (string_overflow): New function.
151 (Fmake_string): Use it. This doesn't change behavior, but saves
152 a few bytes and will simplify future changes.
153 * character.c (string_escape_byte8): Likewise.
154 * lisp.h (string_overflow): New decl.
155
1a1f3366
PE
156 Fixups, following up to the user-interface timestamp change.
157 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
158 for UI timestamps, instead of unsigned long.
9fbd6841
PE
159 * msdos.c (mouse_get_pos): Likewise.
160 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
161 * w32gui.h (Time): Define by including "systime.h" rather than by
162 declaring it ourselves. (Bug#8664)
163
d4e3e4d3
PE
164 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
165 * image.c (clear_image_cache): Likewise.
166
f6a24d19
PE
167 * term.c (term_mouse_position): Don't assume time_t wraparound.
168
08dc5ae6
PE
169 Be more systematic about user-interface timestamps.
170 Before, the code sometimes used 'Time', sometimes 'unsigned long',
171 and sometimes 'EMACS_UINT', to represent these timestamps. This
172 change causes it to use 'Time' uniformly, as that's what X uses.
173 This makes the code easier to follow, and makes it easier to catch
174 integer overflow bugs such as Bug#8664.
175 * frame.c (Fmouse_position, Fmouse_pixel_position):
176 Use Time, not unsigned long, for user-interface timestamps.
177 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
178 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
179 * keyboard.h (last_event_timestamp): Likewise.
180 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
181 * menu.h (xmenu_show): Likewise.
182 * term.c (term_mouse_position): Likewise.
183 * termhooks.h (struct input_event.timestamp): Likewise.
184 (struct terminal.mouse_position_hook): Likewise.
185 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
186 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
187 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
188 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
189 what it was before.
190 * menu.h, termhooks.h: Include "systime.h", for Time.
191
8e55734a
PE
192 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
193 Don't assume that the difference between two unsigned long values
194 can fit into an integer. At this point, we know button_down_time
195 <= event->timestamp, so the difference must be nonnegative, so
196 there's no need to cast the result if double-click-time is
197 nonnegative, as it should be; check that it's nonnegative, just in
198 case. This bug is triggered when events are more than 2**31 ms
86db42d2 199 apart (about 25 days). (Bug#8664)
8e55734a 200
841f1b75 201 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 202 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 203
3e26f69c
PE
204 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
205 that always fit in int. Use a sentinel instead of a counter, to
206 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
207 * frame.h (struct frame): Use int for menu_bar_items_used
208 instead of EMACS_INT, since it always fits in int.
3e26f69c 209
5cc152c0
PE
210 * menu.c (grow_menu_items): Check for int overflow.
211
d89eb65e
PE
212 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
213
5235bd3e
PE
214 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
215 Before, the code was not consistent. These values cannot exceed
216 2**31 - 1 so there's no need to make them unsigned.
217 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
218 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
219 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
220 as modifiers.
221 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
222
bc827e23
PE
223 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
224 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
225 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
226 presumably because the widths might not match.
227
78eb494e
PE
228 * window.c (size_window): Avoid needless test at loop start.
229
04f2d78b
CB
2302011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
231
232 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
233
d2fc7e3d 2342011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
235
236 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
237
d2fc7e3d 2382011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
239
240 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
241 `width' to `bar_area_x' and `bar_area_width', respectively.
242 (x_scroll_run): Take account of fringe background extension.
243
04f2d78b
CB
244 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
245 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
246 `bar_area_width', respectively.
247 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
248 background extension.
249
79b70037
GM
2502011-05-10 Jim Meyering <meyering@redhat.com>
251
252 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
253
2f142cc5
JB
2542011-05-10 Juanma Barranquero <lekktu@gmail.com>
255
256 * image.c (Finit_image_library): Return t for built-in image types,
257 like pbm and xbm. (Bug#8640)
258
57679c86
AS
2592011-05-09 Andreas Schwab <schwab@linux-m68k.org>
260
261 * w32menu.c (set_frame_menubar): Fix submenu allocation.
262
888c9e86
EZ
2632011-05-07 Eli Zaretskii <eliz@gnu.org>
264
b0512a1d
EZ
265 * w32console.c (Fset_screen_color): Doc fix.
266 (Fget_screen_color): New function.
267 (syms_of_ntterm): Defsubr it.
268
7285dc67
EZ
269 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
270 unlink the temporary file if Fcall_process didn't create it in the
271 first place.
272 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
273 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
274 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
275 cue to call_process_cleanup not to close that handle.
276
4d3fcc8e
BK
2772011-05-07 Ben Key <bkey76@gmail.com>
278
279 * makefile.w32-in: The bootstrap-temacs rule now makes use of
280 one of two shell specific rules, either bootstrap-temacs-CMD or
281 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
282 to the previous implementation of the bootstrap-temacs rule.
283 The bootstrap-temacs-CMD rule is similar to the previous
284 implementation of the bootstrap-temacs rule except that it
285 makes use of the ESC_CFLAGS variable instead of the CFLAGS
286 variable.
287
288 These changes, along with some changes to nt/configure.bat,
289 nt/gmake.defs, and nt/nmake.defs, are required to extend my
290 earlier fix to add support for --cflags and --ldflags options
291 that include quotes so that it works whether make uses cmd or
292 sh as the shell.
293
b4289b64
MA
2942011-05-06 Michael Albinus <michael.albinus@gmx.de>
295
296 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
297 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
298 is a constant.
299 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
300 a string. Handle both cases.
301 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
302 (Fdbus_register_method): Use Qinvalid_function.
303
af4c0e28
JB
3042011-05-06 Juanma Barranquero <lekktu@gmail.com>
305
306 * makefile.w32-in: Update dependencies.
307 (LISP_H): Add inttypes.h and stdin.h.
308 (PROCESS_H): Add unistd.h.
309
c51453d9
EZ
3102011-05-06 Eli Zaretskii <eliz@gnu.org>
311
312 * lread.c: Include limits.h (fixes the MS-Windows build broken by
313 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
314
8ff0ac3c 3152011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 316
4c4b566b
PE
317 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
318
aab2b9b5
PE
319 * term.c (vfatal): Remove stray call to va_end.
320 It's not needed and the C Standard doesn't allow it here anyway.
321
c378da0b
PE
322 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
323 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
324
288b08c7
PE
325 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
326 bytes.
327
e3601888
PE
328 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
329
db6c0e74
PE
330 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
331
dd5963ea
PE
332 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
333
88c9450f
PE
334 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
335
2f9442b8
PE
336 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
337
c032b5f8
PE
338 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
339 * charset.c (Fdefine_charset_internal): Don't initialize
340 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 341 32-bit int (Bug#8600).
a108c10b
PE
342
343 * lread.c (read_integer): Be more consistent with string-to-number.
344 Use string_to_number to do the actual conversion; this avoids
345 rounding errors and fixes some other screwups. Without this fix,
346 for example, #x1fffffffffffffff was misread as -2305843009213693952.
347 (digit_to_number): Move earlier, for benefit of read_integer.
348 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 349 not a digit in any supported base. (Bug#8602)
a108c10b 350
ad5f9eea
PE
351 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
352
aec1708a
PE
353 * dispnew.c (scrolling_window): Return 1 if we scrolled,
354 to match comment at start of function. This also removes a
355 GCC warning about overflow in a 32+64-bit port.
356
47be4ab5
PE
357 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
358
371cac43
PE
359 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
360 Reported by Stefan Monnier in
361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
362 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
363 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 364
d01a7826
PE
365 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
366 (EMACS_UINTPTR): Likewise, with uintptr_t.
367
7fd47d5c
PE
368 * lisp.h: Prefer 64-bit EMACS_INT if available.
369 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
370 on 32-bit hosts that have 64-bit int, so that they can access
371 large files.
122b0c86
PE
372 However, temporarily disable this change unless the temporary
373 symbol WIDE_EMACS_INT is defined.
7fd47d5c 374
8727937b
PE
375 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
376
8ac068ac
PE
377 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
378 This removes an assumption that EMACS_INT and long are the same
379 width as pointers. The assumption is true for Emacs porting targets
380 now, but we want to make other targets possible.
381 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
382 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
383 In the rest of the code, change types of integers that hold casted
384 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
385 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
386 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
387 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
388 No need to cast type when ORing.
389 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
390 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
391 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
392 assume EMACS_INT is the same width as char *.
393 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
394 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
395 Remove no-longer-needed casts.
396 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
397 (xg_tool_bar_help_callback, xg_make_tool_item):
398 Use EMACS_INTPTR to hold an integer
399 that will be cast to void *; this can avoid a GCC warning
400 if EMACS_INT is not the same width as void *.
401 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
402 * xdisp.c (display_echo_area_1, resize_mini_window_1):
403 (current_message_1, set_message_1):
404 Use a local to convert to proper width without a cast.
405 * xmenu.c (dialog_selection_callback): Likewise.
406
ede49d71
PE
407 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
408 Also, don't assume VALBITS / RAND_BITS is less than 5,
409 and don't rely on undefined behavior when shifting a 1 left into
410 the sign bit.
411 * lisp.h (get_random): Change signature to match.
412
2f30ecd0
PE
413 * lread.c (hash_string): Use size_t, not int, for hash computation.
414 Normally we prefer signed values; but hashing is special, because
415 it's better to use unsigned division on hash table sizes so that
416 the remainder is nonnegative. Also, size_t is the natural width
417 for hashing into memory. The previous code used 'int', which doesn't
418 retain enough info to hash well into very large tables.
419 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
420
2a866e7b
PE
421 * dbusbind.c: Don't possibly lose pointer info when converting.
422 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
423 Use XPNTR rather than XHASH, so that the high-order bits of
424 the pointer aren't lost when converting through void *.
425
51639eac
PE
426 * eval.c (Fautoload): Don't double-shift a pointer.
427
92394119
PE
428 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
429
dbdb9a7c
JB
4302011-05-06 Juanma Barranquero <lekktu@gmail.com>
431
432 * gnutls.c (DEF_GNUTLS_FN):
433 * image.c (DEF_IMGLIB_FN): Make function pointers static.
434
db7a0b4f
AS
4352011-05-05 Andreas Schwab <schwab@linux-m68k.org>
436
437 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
438 marker. (Bug#8610)
439
f7ff1b0f 4402011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
441
442 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
443 New version that can reserve upto 2GB of heap space.
444
f7ff1b0f 4452011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
446
447 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
448
639c109b
TZ
4492011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
450
451 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
452 `gnutls_certificate_set_x509_key_file'.
453
d2127135
JB
4542011-05-05 Juanma Barranquero <lekktu@gmail.com>
455
456 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
457 Update dependencies.
458
e968f4f3
JB
4592011-05-04 Juanma Barranquero <lekktu@gmail.com>
460
461 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
462 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
463 Remove unused parameter `fildes'.
464 * process.c (read_process_output, send_process): Don't pass it.
465
84d358f0
JB
4662011-05-04 Juanma Barranquero <lekktu@gmail.com>
467
468 Fix previous change: the library cache is defined in w32.c.
469 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
470 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
471
0898ca10
JB
4722011-05-04 Juanma Barranquero <lekktu@gmail.com>
473
474 Implement dynamic loading of GnuTLS on Windows.
475
476 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
477 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
478 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
479 Declare.
480
481 * gnutls.c (Qgnutls_dll): Define.
482 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
483 (gnutls_*): Declare function pointers.
484 (init_gnutls_functions): New function to initialize function pointers.
485 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
486 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
487 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
488 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
489 (emacs_gnutls_write, emacs_gnutls_read)
490 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
491 (Fgnutls_available_p): New function.
492 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
493 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
494 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
495
496 * image.c: Include w32.h.
497 (Vimage_type_cache): Delete.
498 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
499 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
500 (w32_delayed_load): Move to w32.c.
501
502 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
503
504 * w32.c (QCloaded_from, Vlibrary_cache): Define.
505 (w32_delayed_load): Move from image.c. When loading a library, record
506 its filename in the :loaded-from property of the library id.
507 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
508 Initialize and staticpro them.
509 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
510
511 * process.c: Include lisp.h before w32.h, not after.
512 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
513 instead of gnutls_record_check_pending.
514
515 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
516
ff4de4aa
TZ
5172011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
518
519 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
520 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
521 as passed in.
522
abe95abb
JD
5232011-05-03 Jan Djärv <jan.h.d@swipnet.se>
524
525 * xterm.c (x_set_frame_alpha): Do not set property on anything
526 else than FRAME_X_OUTER_WINDOW (Bug#8608).
527
e16e55d4
JB
5282011-05-02 Juanma Barranquero <lekktu@gmail.com>
529
530 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
531
bafcf6a5
JB
5322011-05-02 Juanma Barranquero <lekktu@gmail.com>
533
534 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
535 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
536 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
537 (gnutls_global_initialized, Qgnutls_bootprop_priority)
538 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
539 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
540 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
541 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
542 (Qgnutls_bootprop_callbacks_verify): Make static.
543
e7a6747f
AS
5442011-05-01 Andreas Schwab <schwab@linux-m68k.org>
545
19ed11ba
AS
546 * callproc.c: Indentation fixup.
547
e7a6747f 548 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
549 (wait_for_termination, interruptible_wait_for_termination):
550 Move after wait_for_termination_1.
e7a6747f 551
1ef14cb4
LMI
5522011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
553
554 * sysdep.c (interruptible_wait_for_termination): New function
555 which is like wait_for_termination, but allows keyboard
556 interruptions.
557
558 * callproc.c (Fcall_process): Add (:file "file") as an option for
559 the STDOUT buffer.
560 (Fcall_process_region): Ditto.
561
330d880c
EZ
5622011-04-30 Eli Zaretskii <eliz@gnu.org>
563
8db90b73
EZ
564 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
565 rather than `XVECTOR (FOO)->size'.
566
330d880c
EZ
567 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
568 inttypes.h, as a gnulib replacement is used if it not available in
569 system headers.
570
15cbd324
EZ
5712011-04-21 Eli Zaretskii <eliz@gnu.org>
572
573 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
574 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
575 of MOST_POSITIVE_FIXNUM. (Bug#8528)
576
577 * coding.c (coding_alloc_by_realloc): Error out if destination
578 will grow beyond MOST_POSITIVE_FIXNUM.
579 (decode_coding_emacs_mule): Abort if there isn't enough place in
580 charbuf for the composition carryover bytes. Reserve an extra
581 space for up to 2 characters produced in a loop.
582 (decode_coding_iso_2022): Abort if there isn't enough place in
583 charbuf for the composition carryover bytes.
584
5852011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 586
ae940cca
EZ
587 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
588 aborting when %lld or %lll format is passed.
589 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
590 %llo or %llx format is passed. (Bug#8545)
591
03ab8921
EZ
592 * window.c (window_scroll_line_based): Use a marker instead of
593 simple variables to record original value of point. (Bug#7952)
594
afda1437
EZ
595 * doprnt.c (doprnt): Fix the case where a multibyte sequence
596 produced by %s or %c overflows available buffer space. (Bug#8545)
597
f76dee0c
PE
5982011-04-28 Paul Eggert <eggert@cs.ucla.edu>
599
600 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 601 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 602
fdc5744d
JB
6032011-04-28 Juanma Barranquero <lekktu@gmail.com>
604
605 * w32.c (init_environment): Warn about defaulting HOME to C:\.
606
638f053a
JB
6072011-04-28 Juanma Barranquero <lekktu@gmail.com>
608
609 * keyboard.c (Qdelayed_warnings_hook): Define.
610 (command_loop_1): Run `delayed-warnings-hook'
611 if Vdelayed_warnings_list is non-nil.
612 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
613 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
614
d178f871
EZ
6152011-04-28 Eli Zaretskii <eliz@gnu.org>
616
617 * doprnt.c (doprnt): Don't return value smaller than the buffer
618 size if the message was truncated. (Bug#8545).
619
b124fd93
JB
6202011-04-28 Juanma Barranquero <lekktu@gmail.com>
621
622 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
623 (Fx_window_property): #if-0 the whole functions, not just the bodies.
624
e810457d
PE
6252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
626
627 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
628
ea51cceb
JB
6292011-04-27 Juanma Barranquero <lekktu@gmail.com>
630
631 * makefile.w32-in: Update dependencies.
632
94dcfacf
EZ
6332011-04-27 Eli Zaretskii <eliz@gnu.org>
634
635 Improve `doprnt' and its usage. (Bug#8545)
636 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
637 `format_end'. Remove support for %l as a conversion specifier.
638 Don't use xrealloc. Improve diagnostics when the %l size modifier
639 is used. Update the commentary.
640
641 * eval.c (verror): Simplify calculation of size_t.
642
643 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
644 messages.
645
f61f41d7
PE
6462011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
647
648 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
649 change.
650
96fb4434
PE
6512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
652
653 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
654 This makes this file independent of the recent pseudovector change.
655
671875da 6562011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 657
69e9b5a3
PE
658 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
659
b5f869a7 660 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 661 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 662 Remove unused local.
c8926152 663 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 664
841a1577 665 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
666 GCC 4.6.0 optimizes based on type-based alias analysis.
667 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
668 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
669 != &v->size, and therefore "v->size = 1; b->size = 2; return
670 v->size;" must therefore return 1. This assumption is incorrect
671 for Emacs, since it type-puns struct Lisp_Vector * with many other
672 types. To fix this problem, this patch adds a new type struct
f904488f 673 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
674 and pseudovectors, and helps optimizing compilers not get fooled
675 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
676 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
677 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
678 the size member.
eab3844f
PE
679 (XSETPVECTYPE): Rewrite in terms of new macro.
680 (XSETPVECTYPESIZE): New macro, specifying both type and size.
681 This is a bit clearer, and further avoids the possibility of
682 undesirable aliasing.
683 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 684 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
685 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
686 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
687 (ASIZE): Now uses header.size rather than size.
688 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
689 to avoid the hassle of writing XVECTOR (foo)->header.size.
690 (struct vectorlike_header): New type.
eab3844f
PE
691 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
692 object, to help avoid aliasing.
693 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
694 (SUBRP): Likewise, since Lisp_Subr is a special case.
695 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
696 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
697 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 698 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
699 changed to be "header.size" and "header.next".
700 * buffer.h (struct buffer): Likewise.
701 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
702 * frame.h (struct frame): Likewise.
703 * process.h (struct Lisp_Process): Likewise.
704 * termhooks.h (struct terminal): Likewise.
705 * window.c (struct save_window_data, struct saved_window): Likewise.
706 * window.h (struct window): Likewise.
707 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
708 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
709 * buffer.c (init_buffer_once): Likewise.
710 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
711 special case.
712 * process.c (Fformat_network_address): Use local var for size,
713 for brevity.
714
0df1eac5
PE
715 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
716
847ab9d1 717 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
718 * data.c (atof): Remove decl; no longer used or needed.
719 (digit_to_number): Move to lread.c.
720 (Fstring_to_number): Use new string_to_number function, to be
721 consistent with how the Lisp reader treats infinities and NaNs.
722 Do not assume that floating-point numbers represent EMACS_INT
723 without losing information; this is not true on most 64-bit hosts.
724 Avoid double-rounding errors, by insisting on integers when
725 parsing non-base-10 numbers, as the documentation specifies.
726 * lisp.h (string_to_number): New decl, replacing ...
727 (isfloat_string): Remove.
bc0a5c13 728 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 729 (read1): Do not accept +. and -. as integers; this
452f4150
PE
730 appears to have been a coding error. Similarly, do not accept
731 strings like +-1e0 as floating point numbers. Do not report
732 overflow for integer overflows unless the base is not 10 which
733 means we have no simple and reliable way to continue.
734 Break out the floating-point parsing into a new
735 function string_to_number, so that Fstring_to_number parses
736 floating point numbers consistently with the Lisp reader.
04f2d78b 737 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
738 (E_CHAR, EXP_INT): Remove, replacing with ...
739 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
740 (string_to_number): New function, replacing isfloat_string.
741 This function checks for valid syntax and produces the resulting
742 Lisp float number too. Rework it so that string-to-number
bc0a5c13 743 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
744 so that overflow for non-base-10 numbers is reported only when
745 there's no portable and simple way to convert to floating point.
452f4150 746
67769ffc
PE
747 * textprop.c (set_text_properties_1): Rewrite for clarity,
748 and to avoid GCC warning about integer overflow.
749
c20db43f
PE
750 * intervals.h (struct interval): Use EMACS_INT for members
751 where EMACS_UINT might cause problems. See
752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
753 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
754 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
755 All uses changed.
37aa2f85
PE
756 (offset_intervals): Tell GCC not to worry about length overflow
757 when negating a negative length.
c20db43f 758
2538aa2f
PE
759 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
760 (overrun_check_free): Likewise.
761
f2d3008d
PE
762 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
763 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
764 word size.
765
ec8df744
PE
766 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
767 (gnutls_make_error): Rename local to avoid shadowing.
768 (gnutls_emacs_global_deinit): ifdef out; not used.
769 (Fgnutls_boot): Use const for pointer to readonly storage.
770 Comment out unused local. Fix pointer signedness problems.
771
640ee02d
PE
772 * lread.c (openp): Don't stuff size_t into an 'int'.
773 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
774 about possible signed overflow.
775
6048fb2a
PE
776 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
777 (GDK_KEY_g): Don't define if already defined.
778 (xg_prepare_tooltip): Avoid pointer signedness problem.
779 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
780
fa3c87e1
PE
781 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
782 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
783
2172544b
PE
784 * xfns.c (Fx_window_property): Simplify a bit,
785 to make a bit faster and to avoid GCC 4.6.0 warning.
786 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
787
9b821a21
PE
788 * fns.c (internal_equal): Don't assume size_t fits in int.
789
3c616cfa
PE
790 * alloc.c (compact_small_strings): Tighten assertion a little.
791
c2982e87
PE
792 Replace pEd with more-general pI, and fix some printf arg casts.
793 * lisp.h (pI): New macro, generalizing old pEd macro to other
794 conversion specifiers. For example, use "...%"pI"d..." rather
795 than "...%"pEd"...".
796 (pEd): Remove. All uses replaced with similar uses of pI.
797 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
798 * alloc.c (check_pure_size): Don't overflow by converting size to int.
799 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
800 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
801 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
802 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
803 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
804 64-bit hosts.
805 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
806 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
807 * print.c (safe_debug_print, print_object): Likewise.
808 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
809 to int.
6f04d126
PE
810 Use pI instead of if-then-else-abort. Use %p to avoid casts,
811 avoiding the 0 flag, which is not portable.
c2982e87
PE
812 * process.c (Fmake_network_process): Use pI to avoid cast.
813 * region-cache.c (pp_cache): Likewise.
814 * xdisp.c (decode_mode_spec): Likewise.
815 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
816 behavior on 64-bit hosts with printf arg.
6f04d126 817 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
818 (x_stop_queuing_selection_requests): Likewise.
819 (x_get_window_property): Don't truncate byte count to an 'int'
820 when tracing.
0b432f21 821
5e073ec7
PE
822 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
823 here, since it parses constructs like leading '-' and spaces,
824 which are not wanted; and it overflows with large numbers.
825 Instead, simply match F[0-9]+, which is what is wanted anyway.
826
36372bf9
PE
827 * alloc.c: Remove unportable assumptions about struct layout.
828 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
829 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
830 (allocate_vectorlike, make_pure_vector): Use the new macros,
831 plus offsetof, to remove unportable assumptions about struct layout.
832 These assumptions hold on all porting targets that I know of, but
833 they are not guaranteed, they're easy to remove, and removing them
834 makes further changes easier.
835
0b432f21
PE
836 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
837 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
838 (string_overrun_cookie): Now const. Use initializers that
839 don't formally overflow signed char, to avoid warnings.
000098c1
PE
840 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
841 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
842 (allocate_buffer): Don't assume sizeof (struct buffer) is a
843 multiple of sizeof (EMACS_INT); it need not be, if
844 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 845 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 846
895009e1
JB
8472011-04-26 Juanma Barranquero <lekktu@gmail.com>
848
849 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
850
6a7a1b0b
TZ
8512011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
852
853 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 854 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
855 Reported by Paul Eggert <eggert@cs.ucla.edu>.
856
841a1577 8572011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
858
859 * lisp.h (Qdebug): List symbol.
895009e1 860 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
861 * keyboard.c (debug-on-event): New variable.
862 (handle_user_signal): Break into debugger when debug-on-event
863 matches the current signal symbol.
864
f2d3ba6f
DN
8652011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
866
867 * alloc.c (check_sblock, check_string_bytes)
868 (check_string_free_list): Convert to standard C.
869
42ce4c63
TZ
8702011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
871
872 * w32.c (emacs_gnutls_push): Fix typo.
873
825cd63c
EZ
8742011-04-25 Eli Zaretskii <eliz@gnu.org>
875
fb11d64d
EZ
876 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
877 "cast to pointer from integer of different size".
878
825cd63c
EZ
879 Improve doprnt and its use in verror. (Bug#8545)
880 * doprnt.c (doprnt): Document the set of format control sequences
881 supported by the function. Use SAFE_ALLOCA instead of always
882 using `alloca'.
883
884 * eval.c (verror): Don't limit the buffer size at size_max-1, that
885 is one byte too soon. Don't use xrealloc; instead xfree and
886 xmalloc anew.
887
e061a11b
TZ
8882011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
889
890 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
891 callbacks stage.
892
893 * gnutls.c: Renamed global_initialized to
894 gnutls_global_initialized. Added internals for the
895 :verify-hostname-error, :verify-error, and :verify-flags
896 parameters of `gnutls-boot' and documented those parameters in the
897 docstring. Start callback support.
898 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
899 unless a fatal error occured. Call gnutls_alert_send_appropriate
900 on error. Return error code.
901 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
902 (emacs_gnutls_read): Likewise.
903 (Fgnutls_boot): Return handshake error code.
904 (emacs_gnutls_handle_error): New function.
905 (wsaerror_to_errno): Likewise.
906
907 * w32.h (emacs_gnutls_pull): Add prototype.
908 (emacs_gnutls_push): Likewise.
909
910 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
911 (emacs_gnutls_push): Likewise.
912
9132011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
914
915 * process.c (wait_reading_process_output): Check if GnuTLS
916 buffered some data internally if no FDs are set for TLS
917 connections.
918
919 * makefile.w32-in (OBJ2): Add gnutls.$(O).
920 (LIBS): Link to USER_LIBS.
921 ($(BLD)/gnutls.$(0)): New target.
922
fa6996bc
EZ
9232011-04-24 Eli Zaretskii <eliz@gnu.org>
924
eb35682e
EZ
925 * xdisp.c (handle_single_display_spec): Rename the
926 display_replaced_before_p argument into display_replaced_p, to
927 make it consistent with the commentary. Fix typos in the
928 commentary.
929
e2ad650c
EZ
930 * textprop.c (syms_of_textprop): Remove dead code.
931 (copy_text_properties): Delete obsolete commentary about an
932 interface that was deleted long ago. Fix typos in the description
933 of arguments.
934
1b2de274
EZ
935 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
936 to changes in oldXMenu/XMenu.h from 2011-04-16.
937 <menu_help_message, prev_menu_help_message>: Constify.
938 (IT_menu_make_room): menu->help_text is now `const char **';
939 adjust.
940
941 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
942 to changes in oldXMenu/XMenu.h from 2011-04-16.
943 (struct XMenu): Declare `help_text' `const char **'.
944
945 * xfaces.c <Qunspecified>: Make extern again.
946
947 * syntax.c: Include sys/types.h before including regex.h, as
948 required by Posix.
949
762b15be
EZ
950 * doc.c (get_doc_string): Improve the format passed to `error'.
951
952 * doprnt.c (doprnt): Improve commentary.
953
954 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
955
956 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
957 them with etags.
958
f1052e5d
EZ
959 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
960 changes in globals.h immediately force recompilation.
762b15be
EZ
961 (TAGS): Depend on $(CURDIR)/m/intel386.h and
962 $(CURDIR)/s/ms-w32.h.
963 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 964
fa6996bc
EZ
965 * character.c (Fchar_direction): Function deleted.
966 (syms_of_character): Don't defsubr it.
967 <char-direction-table>: Deleted.
968
e6c3da20
EZ
9692011-04-23 Eli Zaretskii <eliz@gnu.org>
970
971 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
972 * doprnt.c: Include limits.h.
973 (SIZE_MAX): New macro.
04f2d78b
CB
974 (doprnt): Return a size_t value. 2nd arg is now size_t.
975 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
976 Improve overflow protection. Support `l' modifier for integer
977 conversions. Support %l conversion. Don't assume an EMACS_INT
978 argument for integer conversions and for %c.
979
980 * lisp.h (doprnt): Restore prototype.
981
982 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
983 $(SRC)/character.h.
984
985 * Makefile.in (base_obj): Add back doprnt.o.
986
987 * deps.mk (doprnt.o): Add back prerequisites.
988 (callint.o): Depend on character.h.
989
990 * eval.c (internal_lisp_condition_case): Include the handler
991 representation in the error message.
992 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
993 when breaking from the loop.
994
995 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
996
997 * callint.c (Fcall_interactively): When displaying error message
998 about invalid control letter, pass the character's codepoint, not
999 a pointer to its multibyte form. Improve display of the character
1000 in octal and display also its hex code.
1001
1002 * character.c (char_string): Use %x to display the (unsigned)
1003 codepoint of an invalid character, to avoid displaying a bogus
1004 negative value.
1005
1006 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1007 `error', not SYMBOL_NAME itself.
1008
1009 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1010 character arguments to `error'.
1011
1012 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1013 to `error' in error message about FINAL_CHAR argument. Make sure
1014 FINAL_CHAR is a character, and use %c when it is passed as
1015 argument to `error'.
1016
4ffd0d6b 10172011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1018
1019 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1020
1021 * w32.c: Include <time.h>.
1022 (sys_localtime): New function.
1023
4ffd0d6b 10242011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1025
1026 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1027
4ffd0d6b 1028 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1029
4ffd0d6b 10302011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1031
4ffd0d6b
GM
1032 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1033 zombies (Bug#8467).
aac0c6e3 1034
04c56954
EZ
10352011-04-19 Eli Zaretskii <eliz@gnu.org>
1036
1037 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1038 gl_state.e_property when gl_state.object is Qt.
1039
1040 * insdel.c (make_gap_larger): Remove limitation of buffer size
1041 to <= INT_MAX.
1042
16a43933
CY
10432011-04-18 Chong Yidong <cyd@stupidchicken.com>
1044
1045 * xdisp.c (lookup_glyphless_char_display)
1046 (produce_glyphless_glyph): Handle cons cell entry in
1047 glyphless-char-display.
1048 (Vglyphless_char_display): Document it.
1049
1050 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1051 glyphless-char-display.
1052
4581706e
CY
10532011-04-17 Chong Yidong <cyd@stupidchicken.com>
1054
1055 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1056
1057 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1058
1059 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1060 definition for no-X builds.
1061
4887c6e2 10622011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1063
fd35b6f9
PE
1064 Static checks with GCC 4.6.0 and non-default toolkits.
1065
5c1ccb01
PE
1066 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1067
006c5daa
PE
1068 * process.c (keyboard_bit_set): Define only if SIGIO.
1069 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1070 (send_process): Repair possible setjmp clobbering.
1071
efc736d3
PE
1072 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1073
4e2fe2e6
PE
1074 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1075
f97334a2
PE
1076 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1077
4e75f29d
PE
1078 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1079 Define only if needed.
1080
90efadd1
PE
1081 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1082 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1083 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1084
3c647824
PE
1085 * dispextern.h (struct redisplay_interface): Rename param
1086 to avoid shadowing.
e264f262 1087 * termhooks.h (struct terminal): Likewise.
761383f4 1088 * xterm.c (xembed_send_message): Likewise.
3c647824 1089
b58c5c4a
PE
1090 * insdel.c (make_gap_smaller): Define only if
1091 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1092
cad59032
PE
1093 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1094 it.
1095
c339dc2e
PE
1096 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1097 so that we aren't warned about unused symbols.
1098
91a3e27b
PE
1099 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1100
399c71d3 1101 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1102
8ffc96f5
PE
1103 * xfns.c (x_real_positions): Mark locals as initialized.
1104
eef9bc79
PE
1105 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1106
098db9dd
PE
1107 * xterm.c: Fix problems found by static analysis with other toolkits.
1108 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1109 (x_dispatch_event): Declare static if USE_GTK, and
1110 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1111 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1112 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1113 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1114 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1115
eb18f6cc
PE
1116 * xmenu.c (menu_help_callback): Pointer type fixes.
1117 Use const pointers when pointing at readonly data. Avoid pointer
1118 signedness clashes.
1119 (FALSE): Remove unused macro.
1120 (update_frame_menubar): Remove unused decl.
1121
1fe72bf8
PE
1122 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1123
60d9e1db
PE
1124 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1125 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1126 (single_menu_item): Rename local to avoid shadowing.
1127
39261c26
PE
1128 * keyboard.c (make_lispy_event): Remove unused local var.
1129
018c5e19
PE
1130 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1131 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1132
63d2b86e
PE
1133 * bitmaps: Change bitmaps from unsigned char back to the X11
1134 compatible char. Avoid the old compiler warnings about
1135 out-of-range initializers by using, for example, '\xab' rather
1136 than 0xab.
1137
aefd87e1
PE
1138 * xgselect.c (xgselect_initialize): Check vs interface
1139 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1140
bf501fb9
PE
1141 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1142
e9829fdf
PE
1143 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1144 to read-only memory.
1145
1086c095
PE
1146 * fns.c (vector): Remove; this old hack is no longer needed.
1147
2baccd04 1148 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1149 Remove unused var.
dde42981 1150 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1151
72391843 1152 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1153
436c16df 1154 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1155 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1156 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1157
92bb796d 1158 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1159 (x_term_init): Remove local to avoid shadowing.
92bb796d 1160
764430a3 1161 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1162
1163 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1164 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1165
d1dfb56c
EZ
11662011-04-16 Eli Zaretskii <eliz@gnu.org>
1167
c4354cb4
EZ
1168 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1169
d1dfb56c
EZ
1170 Fix regex.c, syntax.c and friends for buffers > 2GB.
1171 * syntax.h (struct gl_state_s): Declare character position members
1172 EMACS_INT.
1173
1174 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1175
04f2d78b
CB
1176 * textprop.c (verify_interval_modification, interval_of):
1177 Declare arguments EMACS_INT.
d1dfb56c
EZ
1178
1179 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1180 EMACS_INT.
1181
1182 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1183
1184 * indent.c (Fvertical_motion): Local variable it_start is now
1185 EMACS_INT.
1186
1187 * regex.c (re_match, re_match_2, re_match_2_internal)
1188 (bcmp_translate, regcomp, regexec, print_double_string)
1189 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1190 (re_compile_pattern, re_exec): Declare arguments and local
1191 variables `size_t' and `ssize_t' and return values `regoff_t', as
1192 appropriate.
1193 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1194 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1195 <compile_stack_type>: `size' and `avail' are now `size_t'.
1196
1197 * regex.h <regoff_t>: Use ssize_t, not int.
1198 (re_search, re_search_2, re_match, re_match_2): Arguments that
1199 specify buffer/string position and length are now ssize_t and
1200 size_t. Return type is regoff_t.
1201
613052cd
BK
12022011-04-16 Ben Key <bkey76@gmail.com>
1203
1204 * nsfont.m: Fixed bugs in ns_get_family and
1205 ns_descriptor_to_entity that were caused by using free to
1206 deallocate memory blocks that were allocated by xmalloc (via
1207 xstrdup). This caused Emacs to crash when compiled with
1208 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1209 --enable-checking=xmallocoverrun). xfree is now used to
1210 deallocate these memory blocks.
1211
4170f62f 12122011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1213
71b41406
PE
1214 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1215
9587a89d
PE
1216 emacs_write: Accept and return EMACS_INT for sizes.
1217 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1218 et seq.
1219 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1220 Accept and return EMACS_INT.
1221 (emacs_gnutls_write): Return the number of bytes written on
1222 partial writes.
1223 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1224 (emacs_read, emacs_write): Remove check for negative size, as the
1225 Emacs source code has been audited now.
9587a89d
PE
1226 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1227 (emacs_read, emacs_write): Use it.
273a5f82
PE
1228 * process.c (send_process): Adjust to the new signatures of
1229 emacs_write and emacs_gnutls_write. Do not attempt to store
1230 a byte offset into an 'int'; it might overflow.
9587a89d 1231 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1232
3e047f51
PE
1233 * sound.c: Don't assume sizes fit in 'int'.
1234 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1235 Return EMACS_INT, not int.
3e047f51 1236 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1237 Accept EMACS_INT, not int.
1238 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1239 record read return values.
1240
cc39a9db
BK
12412011-04-15 Ben Key <bkey76@gmail.com>
1242
c9d0ec6d
JB
1243 * keyboard.c (Qundefined): Don't declare static since it is used
1244 in nsfns.m.
1245 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1246 static since they are used in nsfont.m.
cc39a9db 1247
6c60eb9f
SM
12482011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1249
1250 * process.c (Qprocessp): Don't declare static.
1251 * lisp.h (Qprocessp): Declare again.
1252
7990b61a
JB
12532011-04-15 Juanma Barranquero <lekktu@gmail.com>
1254
1255 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1256
5d4cb038
PE
12572011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1258
8bd7b830 1259 Improve C-level modularity by making more things 'static'.
cd64ea1d 1260
e3b27b31
PE
1261 Don't publish debugger-only interfaces to other modules.
1262 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1263 (verify_bytepos, count_markers): Move decls to the only modules
1264 that need them.
1265 * region-cache.h (pp_cache): Likewise.
1266 * window.h (check_all_windows): Likewise.
1267 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1268
5d4cb038
PE
1269 * sysdep.c (croak): Now static, if
1270 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1271 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1272
1273 * alloc.c (refill_memory_reserve): Now static if
1274 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1275 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1276
e87b6180
PE
1277 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1278 Define only if USE_LUCID.
1279
ac64929e
PE
1280 * xrdb.c (x_customization_string, x_rm_string): Now static.
1281
6f37259d
PE
1282 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1283 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1284
1683e3ab
PE
1285 * xdisp.c (draw_row_with_mouse_face): Now static.
1286 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1287
de9c2632
PE
1288 * window.h (check_all_windows): Mark externally visible.
1289
2b96acb7
PE
1290 * window.c (window_deletion_count): Now static.
1291
1292 * undo.c: Make symbols static if they're not exported.
1293 (last_undo_buffer, last_boundary_position, pending_boundary):
1294 Now static.
1295
50436f33
PE
1296 * textprop.c (interval_insert_behind_hooks): Now static.
1297 (interval_insert_in_front_hooks): Likewise.
1298
64520e5c
PE
1299 * term.c: Make symbols static if they're not exported.
1300 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1301 (max_frame_lines, tty_set_terminal_modes):
1302 (tty_reset_terminal_modes, tty_turn_off_highlight):
1303 (get_tty_terminal): Now static.
1304 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1305 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1306 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1307 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1308 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1309
1fa53021
PE
1310 * sysdep.c: Make symbols static if they're not exported.
1311 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1312 Now static.
1313 (sigprocmask_set, full_mask): Remove; unused.
1314 (wait_debugging): Mark as visible.
1315 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1316 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1317
d4b43b22
PE
1318 * syntax.c (syntax_temp): Define only if !__GNUC__.
1319
b7c513d0
PE
1320 * sound.c (current_sound_device, current_sound): Now static.
1321
989b29ad
PE
1322 * search.c (searchbufs, searchbuf_head): Now static.
1323
13a55a78
PE
1324 * scroll.c (scroll_cost): Remove; unused.
1325 * dispextern.h (scroll_cost): Remove decl.
1326
de68a1fc
PE
1327 * region-cache.h (pp_cache): Mark as externally visible.
1328
40ccffa6
PE
1329 * process.c: Make symbols static if they're not exported.
1330 (process_tick, update_tick, create_process, chan_process):
1331 (Vprocess_alist, proc_buffered_char, datagram_access):
1332 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1333 (deactivate_process): Mark defn as static, as well as decl.
1334 * lisp.h (create_process): Remove decl.
1335 * process.h (chan_process, Vprocess_alist): Remove decls.
1336
ad64fc97
PE
1337 * print.c: Make symbols static if they're not exported.
1338 (print_depth, new_backquote_output, being_printed, print_buffer):
1339 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1340 (print_interval, print_number_index, initial_stderr_stream):
1341 Now static.
1342 * lisp.h (Fprinc): Remove decl.
1343 (debug_output_compilation_hack): Mark as externally visible.
1344
adddb265
PE
1345 * sysdep.c (croak): Move decl from here to syssignal.h.
1346 * syssignal.h (croak): Put it here, so the API can be checked when
1347 'croak' is called from dissociate_if_controlling_tty.
1348
1717ede2
PE
1349 * minibuf.c: Make symbols static if they're not exported.
1350 (minibuf_save_list, choose_minibuf_frame): Now static.
1351 * lisp.h (choose_minibuf_frame): Remove decl.
1352
fa5fb2bc
PE
1353 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1354
1e3890d1
PE
1355 * lread.c: Make symbols static if they're not exported.
1356 (read_objects, initial_obarray, oblookup_last_bucket_number):
1357 Now static.
1358 (make_symbol): Remove; unused.
1359 * lisp.h (initial_obarray, make_symbol): Remove decls.
1360
8a1414fa
PE
1361 * keyboard.c: Make symbols static if they're not exported.
1362 (single_kboard, recent_keys_index, total_keys, recent_keys):
1363 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1364 (this_single_command_key_start, echoing, last_auto_save):
1365 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1366 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1367 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1368 (Vlispy_mouse_stem, double_click_count):
1369 Now static.
1370 (force_auto_save_soon): Define only if SIGDANGER.
1371 (ignore_mouse_drag_p): Now static if
1372 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1373 (print_help): Remove; unused.
1374 (stop_character, last_timer_event): Mark as externally visible.
1375 * keyboard.h (ignore_mouse_drag_p): Declare only if
1376 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1377 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1378 * lisp.h (echoing): Remove decl.
1379 (force_auto_save_soon): Declare only if SIGDANGER.
1380 * xdisp.c (redisplay_window): Simplify code, to make it more
1381 obvious that ignore_mouse_drag_p is not accessed if !defined
1382 USE_GTK && !defined HAVE_NS.
1383
93ea6e8f
PE
1384 * intervals.c: Make symbols static if they're not exported.
1385 (merge_properties_sticky, merge_interval_right, delete_interval):
1386 Now static.
1387 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1388
77382fcc
PE
1389 * insdel.c: Make symbols static if they're not exported.
1390 However, leave prepare_to_modify_buffer alone. It's never
1391 called from outside this function, but that appears to be a bug.
1392 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1393 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1394 (adjust_after_replace_noundo): Remove; unused.
1395 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1396 (signal_before_change): Remove decls.
77382fcc 1397
9306c32e
PE
1398 * indent.c (val_compute_motion, val_vmotion): Now static.
1399
cd44d2eb
PE
1400 * image.c: Make symbols static if they're not exported.
1401 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1402 if USE_GTK.
1403 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1404 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1405
ad9a7a06
PE
1406 * fringe.c (standard_bitmaps): Now static.
1407 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1408
81626931
PE
1409 * frame.c: Make symbols static if they're not exported.
1410 (x_report_frame_params, make_terminal_frame): Now static.
1411 (get_frame_param): Now static, unless HAVE_NS.
1412 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1413 (x_get_resource_string): Remove; not used.
1414 * frame.h (make_terminal_frame, x_report_frame_params):
1415 (x_get_resource_string); Remove decls.
1416 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1417 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1418
239f9db9
PE
1419 * font.c, fontset.c: Make symbols static if they're not exported.
1420 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1421 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1422 * font.c (font_close_object): Now static.
1423 * font.h (font_close_object): Remove.
1424 * fontset.c (FONTSET_OBJLIST): Remove.
1425 (free_realized_fontset) #if-0 the body, which does nothing.
1426 (face_suitable_for_char_p): #if-0, as it's never called.
1427 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1428 * xfaces.c (face_at_string_position):
1429 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1430 since 0 is always ASCII.
1431
dfcf3579
PE
1432 * fns.c (weak_hash_tables): Now static.
1433
5045092b
PE
1434 * fileio.c: Make symbols static if they're not exported.
1435 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1436 (Vwrite_region_annotation_buffers): Now static.
1437
57a96f5c
PE
1438 * eval.c: Make symbols static if they're not exported.
1439 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1440 * lisp.h (backtrace_list): Remove decl.
1441
35f08c38
PE
1442 * emacs.c: Make symbols static if they're not exported.
1443 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1444 (fatal_error_code, fatal_error_signal_hook, standard_args):
1445 Now static.
1446 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1447 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1448 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1449 * lisp.h (fatal_error_signal_hook): Remove decl.
1450 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1451
f44bd759
PE
1452 * editfns.c: Move a (normally-unused) function to its only use.
1453 * editfns.c, lisp.h (get_operating_system_release): Remove.
1454 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1455 worth the hassle of breaking this out.
1456
b532497d
PE
1457 * xterm.c: Make symbols static if they're not exported.
1458 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1459 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1460 (x_destroy_window, x_delete_display):
1461 Now static.
1462 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1463 (x_mouse_leave): Remove; unused.
1464 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1465 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1466 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1467 Remove decls.
1468 (x_mouse_leave): Declare only if WINDOWSNT.
1469 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1470 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1471 USE_X_TOOLKIT.
1472
1675728f
PE
1473 * ftxfont.c: Make symbols static if they're not exported.
1474 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1475 HAVE_FREETYPE.
1476 * font.h (ftxfont_driver): Likewise.
1477
e4cebfca
PE
1478 * xfns.c: Make symbols static if they're not exported.
1479 (x_last_font_name, x_display_info_for_name):
1480 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1481 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1482 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1483 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1484 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1485 (last_show_tip_args): Now static.
1486 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1487 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1488 (x_screen_planes): Remove; unused.
1489 * dispextern.h (x_screen_planes): Remove decl.
1490
5bf46f05
PE
1491 * dispnew.c: Make symbols static if they're not exported.
1492 * dispextern.h (redraw_garbaged_frames, scrolling):
1493 (increment_row_positions): Remove.
1494 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1495 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1496 Now static.
1497 (redraw_garbaged_frames): Remove; unused.
1498
435f4c28
PE
1499 * xfaces.c: Make symbols static if they're not exported.
1500 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1501 Remove decls.
1502 * xterm.h (defined_color): Remove decls.
1503 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1504 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1505 (menu_face_changed_default, defined_color, free_realized_face):
1506 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1507 (ascii_face_of_lisp_face): Remove; unused.
1508
8524aef3
PE
1509 * xdisp.c: Make symbols static if they're not exported.
1510 * dispextern.h (scratch_glyph_row, window_box_edges):
1511 (glyph_to_pixel_coords, set_cursor_from_row):
1512 (get_next_display_element, set_iterator_to_next):
1513 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1514 (show_mouse_face): Remove decls
1515 * frame.h (message_buf_print): Likewise.
1516 * lisp.h (pop_message, set_message, check_point_in_composition):
1517 Likewise.
1518 * xterm.h (set_vertical_scroll_bar): Likewise.
1519 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1520 (message_buf_print, scratch_glyph_row, displayed_buffer):
1521 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1522 (get_next_display_element, show_mouse_face, window_box_edges):
1523 (frame_to_window_pixel_xy, check_point_in_composition):
1524 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1525 (glyph_to_pixel_coords): Remove; unused.
1526
16390cd2
PE
1527 * dired.c (file_name_completion): Now static.
1528
1529 * dbusbind.c (xd_in_read_queued_messages): Now static.
1530
a25f4dfa
PE
1531 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1532 * data.c (circular_list_error): Remove.
1533
14a9c8df
PE
1534 * commands.h (last_point_position, last_point_position_buffer):
1535 (last_point_position_window): Remove decls.
1536 * keyboard.c: Make these variables static.
1537
04f2d78b
CB
1538 * coding.h (coding, code_convert_region, encode_coding_gap):
1539 Remove decls.
74ab6df5
PE
1540 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1541 (iso_code_class, detect_coding, code_convert_region): Now static.
1542 (encode_coding_gap): Remove; unused.
1543
38dfbee1
PE
1544 * chartab.c (chartab_chars, chartab_bits): Now static.
1545
a2cb4e63
PE
1546 * charset.h (charset_iso_8859_1): Remove decl.
1547 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1548 Now static.
1549
127198fd
PE
1550 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1551 * ccl.c (Vccl_program_table): Now static.
1552 (check_ccl_update): Remove; unused.
1553
d85b608f
PE
1554 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1555 * category.h: ... from here.
1556 * category.c (check_category_table, set_category_set): Now static.
1557
31cd66f3
PE
1558 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1559 * lisp.h: Remove these decls.
1560
c358e587
PE
1561 * buffer.c (buffer_count): Remove unused var.
1562
e78aecca
PE
1563 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1564 so that it's not optimized away.
1565 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1566 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1567 exported only to the debugger.
1568
e192d7d3 1569 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1570 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1571
92470028
PE
1572 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1573 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1574 was inaccessible from Lisp.
1575 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1576 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1577
244ed907
PE
1578 alloc.c: Import and export fewer symbols, and remove unused items.
1579 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1580 is defined.
1581 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1582 it's not optimized away by whole-program optimization.
1583 (message_enable_multibyte, free_misc): Remove.
1584 (catchlist, handlerlist, mark_backtrace):
1585 Declare only if BYTE_MARK_STACK.
1586 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1587 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1588 (message_enable_multibyte): Remove decl.
1589 (free_misc, interval_free_list, float_block, float_block_index):
1590 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1591 (cons_free_list, last_marked_index):
1592 Now static.
1593 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1594 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1595 (mark_backtrace): Define only if BYTE_MARK_STACK.
1596 * xdisp.c (message_enable_multibyte): Now static.
1597
61c2b50e 1598 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1599 This makes it easier for human readers (and static analyzers)
1600 to see whether these variables are used from other modules.
1601 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1602 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1603 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1604 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1605 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1606 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1607 * xmenu.c, xselect.c:
1608 Declare Q* vars static if they are not used in other modules.
1609 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1610 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1611 Remove decls of unexported vars.
1612 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1613
95c82688
PE
1614 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1615
16a97296
PE
1616 Make Emacs functions such as Fatom 'static' by default.
1617 This makes it easier for human readers (and static analyzers)
1618 to see whether these functions can be called from other modules.
1619 DEFUN now defines a static function. To make the function external
1620 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1621 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1622 (Finit_image_library):
16a97296
PE
1623 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1624 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1625 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1626 Remove decls, since these functions are now static.
1627 (Funintern, Fget_internal_run_time): New decls, since these functions
1628 were already external.
95c82688 1629
16a97296
PE
1630 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1631 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1632 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1633 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1634 * keyboard.c, keymap.c, lread.c:
1635 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1636 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1637 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1638 Mark functions with DEFUE instead of DEFUN,
1639 if they are used in other modules.
1640 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1641 decls for now-static functions.
1642 * buffer.h (Fdelete_overlay): Remove decl.
1643 * callproc.c (Fgetenv_internal): Mark as internal.
1644 * composite.c (Fremove_list_of_text_properties): Remove decl.
1645 (Fcomposition_get_gstring): New forward static decl.
1646 * composite.h (Fcomposite_get_gstring): Remove decl.
1647 * dired.c (Ffile_attributes): New forward static decl.
1648 * doc.c (Fdocumntation_property): New forward static decl.
1649 * eval.c (Ffetch_bytecode): New forward static decl.
1650 (Funintern): Remove extern decl; now in .h file where it belongs.
1651 * fileio.c (Fmake_symbolic_link): New forward static decl.
1652 * image.c (Finit_image_library): New forward static decl.
1653 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1654 * intervals.h (Fprevious_property_change):
1655 (Fremove_list_of_text_properties): Remove decls.
1656 * keyboard.c (Fthis_command_keys): Remove decl.
1657 (Fcommand_execute): New forward static decl.
1658 * keymap.c (Flookup_key): New forward static decl.
1659 (Fcopy_keymap): Now static.
1660 * keymap.h (Flookup_key): Remove decl.
1661 * process.c (Fget_process): New forward static decl.
1662 (Fprocess_datagram_address): Mark as internal.
1663 * syntax.c (Fsyntax_table_p): New forward static decl.
1664 (skip_chars): Remove duplicate decl.
1665 * textprop.c (Fprevious_property_change): New forward static decl.
1666 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1667 Now internal.
1668 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1669 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1670
785bbd42
PE
1671 * editfns.c (Fformat): Remove unreachable code.
1672
8b913b57
AS
16732011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1674
1675 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1676 change. (Bug#8496)
1677
a6744a35
EZ
16782011-04-13 Eli Zaretskii <eliz@gnu.org>
1679
1680 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1681 when at ZV. (Bug#8487)
1682
e7974947
AS
16832011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1684
baad03f0
AS
1685 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1686 (Bug#8437)
1687 * keyboard.c (parse_tool_bar_item): Likewise.
1688 * sound.c (sound_cleanup, alsa_close): Likewise.
1689 * termcap.c (tgetent): Likewise.
1690 * xfns.c (x_default_font_parameter): Likewise.
1691 * xsettings.c (read_and_apply_settings): Likewise.
1692
e7974947
AS
1693 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1694 (overrun_check_free): Protoize.
1695
28272684
PE
16962011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1699 since callers should never pass a negative size.
1700 Change the signature to match that of plain 'read' and 'write'; see
1701 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1702 * lisp.h: Update prototypes of emacs_write and emacs_read.
1703
11997c76
EZ
17042011-04-11 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (redisplay_window): Don't try to determine the character
1707 position of the scroll margin if the window start point w->startp
e896f03c 1708 is outside the buffer's accessible region. (Bug#8468)
11997c76 1709
8a2cbd72
EZ
17102011-04-10 Eli Zaretskii <eliz@gnu.org>
1711
1712 Fix write-region and its subroutines for buffers > 2GB.
1713 * fileio.c (a_write, e_write): Modify declaration of arguments and
1714 local variables to support buffers larger than 2GB.
1715 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1716
1717 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1718 argument, local variables, and return value.
1719
1720 * lisp.h: Update prototypes of emacs_write and emacs_read.
1721
1722 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1723
4073e537 17242011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1725
1ebfdcb6
PE
1726 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1727
b2ded58d
PE
1728 Fix more problems found by GCC 4.6.0's static checks.
1729
7d66342c
PE
1730 * xdisp.c (vmessage): Use a better test for character truncation.
1731
bbf47d44
PE
1732 * charset.c (load_charset_map): <, not <=, for optimization,
1733 and to avoid potential problems with integer overflow.
9248994d 1734 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1735 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1736 * editfns.c (Fformat): Likewise.
1e69125e 1737 * syntax.c (skip_chars): Likewise.
3befa583 1738
e3019616
PE
1739 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1740 This also lets GCC 4.6.0 generate slightly better loop code.
1741
becfa255
PE
1742 * callint.c (Fcall_interactively): <, not <=, for optimization.
1743 (Fcall_interactively): Count the number of arguments produced,
1744 not the number of arguments given. This is simpler and lets GCC
1745 4.6.0 generate slightly better code.
1746
dae0cd48
PE
1747 * ftfont.c: Distingish more carefully between FcChar8 and char.
1748 The previous code passed unsigned char * to a functions like
1749 strlen and xstrcasecmp that expect char *, which does not
1750 conform to the C standard.
1751 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1752 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1753 char * when the C standard requires it.
1754
76032d70
PE
1755 * keyboard.c (read_char): Remove unused var.
1756
eb3f1cc8
PE
1757 * eval.c: Port to Windows vsnprintf (Bug#8435).
1758 Include <limits.h>.
1759 (SIZE_MAX): Define if the headers do not.
1760 (verror): Do not give up if vsnprintf returns a negative count.
1761 Instead, grow the buffer. This ports to Windows vsnprintf, which
1762 does not conform to C99. Problem reported by Eli Zaretskii.
1763 Also, simplify the allocation scheme, by avoiding the need for
1764 calling realloc, and removing the ALLOCATED variable.
1765
70476b54
PE
1766 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1767
12020a9e
PE
1768 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1769 But keep the doprint source code for now, as we might revamp it
1770 and use it again (Bug#8435).
ea6c7ae6
PE
1771 * lisp.h (doprnt): Remove.
1772 * Makefile.in (base_obj): Remove doprnt.o.
1773 * deps.mk (doprnt.o): Remove.
1774
5fdb398c
PE
1775 error: Print 32- and 64-bit integers portably (Bug#8435).
1776 Without this change, on typical 64-bit hosts error ("...%d...", N)
1777 was used to print both 32- and 64-bit integers N, which relied on
1778 undefined behavior.
1779 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1780 New macro.
1781 * lisp.h (error, verror): Mark as printf-like functions.
1782 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1783 Report overflow in size calculations when allocating printf buffer.
1784 Do not truncate output string at its first null byte.
1785 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1786 Truncate the output at a character boundary, since vsnprintf does not
1787 do that.
1788 * charset.c (check_iso_charset_parameter): Convert internal
1789 character to string before calling 'error', since %c now has the
1790 printf meaning.
1791 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1792 overflow when computing char to be passed to 'error'. Do not
1793 pass Lisp_Object to 'error'; pass the integer instead.
1794 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1795 formatted with plain %d.
1796
b189fa66
PE
1797 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1798
bff87ef0
PE
1799 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1800
7e2cac20
PE
1801 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1802
ce4d90b5
PE
1803 * xterm.c (x_catch_errors): Remove duplicate declaration.
1804
266c9547
PE
1805 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1806
79c49ad2
PE
1807 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1808
368f4090
JM
18092011-04-10 Jim Meyering <meyering@redhat.com>
1810
1811 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1812 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1813 return ssize_t not "int", and use size_t as the buffer length.
1814 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1815 * gnutls.h: Update declarations.
1816 * process.c (read_process_output): Use ssize_t, to match.
1817 (send_process): Likewise.
1818
a32d4040
CY
18192011-04-09 Chong Yidong <cyd@stupidchicken.com>
1820
1821 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1822
8546720e 18232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1824
04f2d78b
CB
1825 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1826 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1827
8546720e
GM
1828 * xterm.c (handle_one_xevent):
1829 * xmenu.c (create_and_show_popup_menu):
1830 * xselect.c (x_decline_selection_request)
1831 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1832
0a2f5c1a 18332011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1834
1835 Fix some uses of `int' instead of EMACS_INT.
1836 * search.c (string_match_1, fast_string_match)
1837 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1838 (scan_buffer, find_next_newline_no_quit)
1839 (find_before_next_newline, search_command, Freplace_match)
1840 (Fmatch_data): Make some `int' variables be EMACS_INT.
1841
1842 * xdisp.c (display_count_lines): 3rd argument and return value now
1843 EMACS_INT. All callers changed.
1844 (pint2hrstr): Last argument is now EMACS_INT.
1845
1846 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1847 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1848 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1849 (decode_coding_utf_16, decode_coding_emacs_mule)
1850 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1851 (decode_coding_ccl, decode_coding_charset)
1852 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1853 (decode_coding_iso_2022, decode_coding_emacs_mule)
1854 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1855 <char_offset, last_offset>: Declare EMACS_INT.
1856 (encode_coding_utf_8, encode_coding_utf_16)
1857 (encode_coding_emacs_mule, encode_invocation_designation)
1858 (encode_designation_at_bol, encode_coding_iso_2022)
1859 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1860 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1861 Declare EMACS_INT.
1862 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1863 (encode_invocation_designation): Last argument P_NCHARS is now
1864 EMACS_INT.
1865 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1866 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1867
1868 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1869 All users changed.
1870
1871 * ccl.c (Fccl_execute_on_string): Declare some variables
1872 EMACS_INT.
1873
8546720e 18742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1875
1876 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1877
4e19a977
CS
18782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1879
1880 * process.c (Fformat_network_address): Doc fix.
1881
87302331
R
18822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1883
1884 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1885
cbb59342
CY
18862011-04-08 Chong Yidong <cyd@stupidchicken.com>
1887
1888 * keyboard.c (read_char): Call Lisp function help-form-show,
1889 instead of using internal_with_output_to_temp_buffer.
1890 (Qhelp_form_show): New var.
e0d38eeb 1891 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1892
1893 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1894
1895 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1896
e67a13ab
CY
18972011-04-06 Chong Yidong <cyd@stupidchicken.com>
1898
04f2d78b
CB
1899 * process.c (Flist_processes): Remove to Lisp.
1900 (list_processes_1): Delete.
e67a13ab 1901
973f782d
EZ
19022011-04-06 Eli Zaretskii <eliz@gnu.org>
1903
7c106b1e
EZ
1904 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1905
973f782d
EZ
1906 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1907
41cf7d1a 19082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1909
ca23cc88
PE
1910 Fix more problems found by GCC 4.6.0's static checks.
1911
f390e2d5
PE
1912 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1913
42eea0d0
PE
1914 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1915
b69769da 1916 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1917
f9541e84
PE
1918 * xdisp.c (vmessage): Mark as a printf-like function.
1919
13841b55
PE
1920 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1921
c136c10f
PE
1922 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1923
5e2d4a30
PE
1924 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1925 printf-like functions.
1926 (tiff_load): Add casts to remove these marks before passing them
1927 to system-supplied API.
1928
583f48b9
PE
1929 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1930
b25d760e
PE
1931 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1932 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1933 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1934 directly, rather than having caller test rule sign. This avoids
1935 some unnecessary tests.
1936 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1937 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1938 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1939
bc7b6697 1940 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1941 (xfont_open): Avoid unnecessary tests.
bc7b6697 1942
27ccc379
PE
1943 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1944
dcd5c89a
PE
1945 * composite.h, composite.c (composition_gstring_put_cache):
1946 Use EMACS_INT, not int, for length.
1947
b13a45c6
PE
1948 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1949 breaking out part of COMPOSITION_DECODE_RULE.
1950 (COMPOSITION_DECODE_RULE): Use it.
1951 * composite.c (get_composition_id): Remove unused local vars,
1952 by using the new macro.
1953
1e792e4d
PE
1954 * textprop.c (set_text_properties_1): Change while to do-while,
1955 since the condition is always true at first.
1956
dc6c6455 1957 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1958 (interval_deletion_adjustment): Return unsigned value.
1959 All uses changed.
dc6c6455 1960
aba7731a
PE
1961 * process.c (list_processes_1, create_pty, read_process_output):
1962 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1963 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1964 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1965 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1966 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1967
fdfc4bf3
PE
1968 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1969
fca8fe46 1970 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1971 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1972
06a0259a 1973 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1974 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1975 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1976
e7b9e80f
PE
1977 * print.c (print_error_message): Avoid int overflow.
1978
56201685
PE
1979 * font.c (font_list_entities): Redo for clarity,
1980 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1981
78834453 1982 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1983 (font_score): Avoid potential overflow in diff calculation.
78834453 1984
0bc0b309 1985 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1986 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1987
e610eaca
PE
1988 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1989
b895abce
PE
1990 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1991 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1992 can always succeed if overflow has undefined behavior.
1993
1f1d9321 1994 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1995 (wordify): Omit three unnecessary tests.
1f1d9321 1996
c59478bc
PE
1997 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1998 All callers changed. This avoids the need for an unused var.
1999
79b73827
PE
2000 * casefiddle.c (casify_region): Remove var that is set but not used.
2001
a4db5dfe
PE
2002 * dired.c (file_name_completion): Remove var that is set but not used.
2003
43aae36e
PE
2004 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2005
2a47c44d 2006 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2007 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2008
a37c69bf
PE
2009 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2010 Check for integer overflow on size calculations.
2011
328ab8e7
PE
2012 * buffer.c (Fprevious_overlay_change): Remove var that is set
2013 but not used.
2014
e5a2a5cb
PE
2015 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2016 Remove vars that are set but not used.
8d84a6eb 2017 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2018 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2019
a60e5f68
PE
2020 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2021
f661cb61 2022 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2023 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2024
f0397f5a
PE
2025 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2026 that are set but not used.
2027
8664db06 2028 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2029 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2030
6abdaa4a
PE
2031 * xselect.c (x_get_local_selection, x_handle_property_notify):
2032 Remove vars that are set but not used.
2033
0ce7538d 2034 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2035 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2036
9ae848fc
PE
2037 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2038 Remove var that is set but not used.
0b918413
PE
2039 (scroll_bar_windows_size): Now size_t, not int.
2040 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2041 Check for overflow.
9ae848fc 2042
a5a62657
PE
2043 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2044 (map_tty_color) [!defined MSDOS]: Likewise.
2045
5c5cdd39
PE
2046 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2047
66ebf983
PE
2048 * coding.c: Remove vars that are set but not used.
2049 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2050 All callers changed.
2051 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2052 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2053 (decode_coding_charset): Remove vars that are set but not used.
2054
1be4d761
PE
2055 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2056 that is set but not used.
2057
47553fa8
PE
2058 * print.c (print_object): Remove var that is set but not used.
2059
1f7196bf 2060 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2061 The gnulib version avoids calling malloc in the usual case,
2062 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2063 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2064 * filelock.c (current_lock_owner): Likewise.
2065 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2066 * sysdep.c: Include allocator.h, careadlinkat.h.
2067 (emacs_no_realloc_allocator): New static constant.
2068 (emacs_readlink): New function.
fdb61804
PE
2069 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2070 ../lib/careadlinkat.h.
d1fdcab7 2071
f84c17c7
SM
20722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2073
2074 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2075 first non-nil return value).
2076
ef3862ad
JD
20772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2078
2079 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2080 if not defined (Bug#8403).
2081
376a7006
JB
20822011-04-02 Juanma Barranquero <lekktu@gmail.com>
2083
2084 * xdisp.c (display_count_lines): Remove parameter `start',
2085 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2086 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2087 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2088 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2089 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2090 and thereabouts. All callers changed.
2091 (get_per_char_metric): Remove parameter `f', unused since
2092 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2093
6ca3801d
JM
20942011-04-02 Jim Meyering <meyering@redhat.com>
2095
2096 do not dereference NULL upon failed strdup
2097 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2098 (ns_get_family): Likewise.
2099
d8e2b5ba
JB
21002011-04-02 Juanma Barranquero <lekktu@gmail.com>
2101
2102 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2103
8c74fcbd
JD
21042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2105
2106 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2107 later (Bug#8403).
2108
7200d79c
SM
21092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2110
03408648 2111 Add lexical binding.
7200d79c 2112
03408648
SM
2113 * window.c (Ftemp_output_buffer_show): New fun.
2114 (Fsave_window_excursion):
2115 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2116
2117 * lread.c (lisp_file_lexically_bound_p): New function.
2118 (Fload): Bind Qlexical_binding.
2119 (readevalloop): Remove `evalfun' arg.
2120 Bind Qinternal_interpreter_environment.
2121 (Feval_buffer): Bind Qlexical_binding.
2122 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2123 Mark as dynamic.
2124 (syms_of_lread): Declare `lexical-binding'.
2125
2126 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2127
2128 * keyboard.c (eval_dyn): New fun.
2129 (menu_item_eval_property): Use it.
ca105506
SM
2130
2131 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2132
03408648
SM
2133 * fns.c (concat, mapcar1): Accept byte-code-functions.
2134
2135 * eval.c (Fsetq): Handle lexical vars.
2136 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2137 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2138 (FletX, Flet): Obey lexical binding.
2139 (Fcommandp): Handle closures.
2140 (Feval): New `lexical' arg.
2141 (eval_sub): New function extracted from Feval. Use it almost
2142 everywhere where Feval was used. Look up vars in lexical env.
2143 Handle closures.
2144 (Ffunctionp): Move from subr.el.
2145 (Ffuncall): Handle closures.
2146 (apply_lambda): Remove `eval_flags'.
2147 (funcall_lambda): Handle closures and new byte-code-functions.
2148 (Fspecial_variable_p): New function.
2149 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2150 but without exporting it to Lisp.
23aba0ea 2151
23aba0ea 2152 * doc.c (Fdocumentation, store_function_docstring):
03408648 2153 * data.c (Finteractive_form): Handle closures.
23aba0ea 2154
03408648
SM
2155 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2156 interactive spec.
ba83908c 2157
04f2d78b
CB
2158 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2159 New byte-codes.
03408648
SM
2160 (exec_byte_code): New function extracted from Fbyte_code to handle new
2161 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2162
03408648 2163 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2164
03408648 2165 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2166
e2abce01
JB
21672011-03-31 Juanma Barranquero <lekktu@gmail.com>
2168
2169 * xdisp.c (redisplay_internal): Fix prototype.
2170
63696a73 21712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2172
63696a73 2173 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2174 (try_scrolling): Use it when setting scroll_limit.
2175 Limit scrolling to 100 screen lines.
63696a73
EZ
2176 (redisplay_window): Even when falling back on "recentering",
2177 position point in the window according to scroll-conservatively,
2178 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2179
2180 (try_scrolling): When point is above the window, allow searching
2181 as far as scroll_max, or one screenful, to compute vertical
2182 distance from PT to the scroll margin position. This prevents
2183 try_scrolling from unnecessarily failing when
2184 scroll-conservatively is set to a value slightly larger than the
2185 window height. Clean up the case of PT below the margin at bottom
2186 of window: scroll_max can no longer be INT_MAX. When aggressive
2187 scrolling is in use, don't let point enter the opposite scroll
2188 margin as result of the scroll.
2189 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2190 threshold of 100 lines for never-recentering scrolling.
2191
e4cc2dfc
JB
21922011-03-31 Juanma Barranquero <lekktu@gmail.com>
2193
2194 * dispextern.h (move_it_by_lines):
2195 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2196 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2197 (message_log_check_duplicate): Remove parameters `prev_bol' and
2198 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2199 (redisplay_internal): Remove parameter `preserve_echo_area',
2200 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2201
2202 * indent.c (Fvertical_motion):
2203 * window.c (window_scroll_pixel_based, Frecenter):
2204 Don't pass `need_y_p' to `move_it_by_lines'.
2205
1c470562
SM
22062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2207
44f230aa
SM
2208 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2209 steal a few bits to be more compact.
2210 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2211 Remove unneeded casts.
2212
1c470562
SM
2213 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2214
888adce9
ZK
22152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2216
2217 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2218 binding" message (bug#7967).
2219
f838ed7b
PE
22202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2221
77861b95
PE
2222 Fix more problems found by GCC 4.6.0's static checks.
2223
de6dbc14
PE
2224 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2225 Remove unused local var.
2226
f838ed7b
PE
2227 * editfns.c (Fmessage_box): Remove unused local var.
2228
792c7b2b
PE
2229 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2230 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2231 Omit unused local vars.
c499e557 2232 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2233 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2234 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2235 Omit unused local var.
2236
ba0165e1
PE
2237 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2238 Don't assume string length fits in int.
32ad8845 2239 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2240 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2241
3c59b4c9
PE
2242 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2243 instead of alloca (Bug#8344).
2244
a3eed478 2245 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2246 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2247
eb4d412d
PE
2248 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2249
1658b401
PE
2250 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2251 concerns.
2252
2253 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2254
2255 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2256
9a2c6e05
PE
2257 * keyboard.c (syms_of_keyboard): Use the same style as later
2258 in this function when indexing through an array. This also
2259 works around GCC bug 48267.
2260
03d0a109
PE
2261 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2262
44f730c8
PE
2263 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2264
fe75f926
PE
2265 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2266 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2267
ffa8c828
PE
2268 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2269 This avoids undefined behavior on integer overflow, and is a bit
2270 more convenient anyway since it is compared to a size_t variable.
2271
c5101a77
PE
2272 Variadic C functions now count arguments with size_t, not int.
2273 This avoids an unnecessary limitation on 64-bit machines, which
2274 caused (substring ...) to crash on large vectors (Bug#8344).
2275 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2276 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2277 All variadic functions and their callers changed accordingly.
c5101a77
PE
2278 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2279 * data.c (arith_driver, float_arith_driver): Likewise.
2280 * editfns.c (general_insert_function): Likewise.
2281 * eval.c (struct backtrace.nargs, interactive_p)
2282 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2283 (funcall_lambda, mark_backtrace): Likewise.
2284 * fns.c (concat): Likewise.
2285 * frame.c (x_set_frame_parameters): Likewise.
2286 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2287 0 if not found, not -1. All callers changed.
2288
dd3f25f7
PE
2289 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2290 (stack_copy_size): Now size_t, not int.
2291 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2292
461c2ab9
JB
22932011-03-28 Juanma Barranquero <lekktu@gmail.com>
2294
2295 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2296 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2297 All callers changed.
2298
2299 * lisp.h (multibyte_char_to_unibyte):
2300 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2301 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2302 * character.h (CHAR_TO_BYTE8):
2303 * cmds.c (internal_self_insert):
2304 * editfns.c (general_insert_function):
2305 * keymap.c (push_key_description):
2306 * search.c (Freplace_match):
2307 * xdisp.c (message_dolog, set_message_1): All callers changed.
2308
f6d62986
SM
23092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2310
2311 * keyboard.c (safe_run_hook_funcall): New function.
2312 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2313 don't set the hook to nil, but remove the offending function instead.
2314 (Qcommand_hook_internal): Remove, unused.
2315 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2316 Vcommand_hook_internal.
2317
2318 * eval.c (enum run_hooks_condition): Remove.
2319 (funcall_nil, funcall_not): New functions.
2320 (run_hook_with_args): Call each function through a `funcall' argument.
2321 Remove `cond' argument, now redundant.
2322 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2323 (Frun_hook_with_args_until_failure): Adjust accordingly.
2324 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2325
1db5b1ad
JB
23262011-03-28 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * dispextern.h (string_buffer_position): Remove declaration.
2329
2330 * print.c (strout): Remove parameter `multibyte', unused since
2331 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2332
2333 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2334 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2335 All callers changed.
2336
2337 * w32.c (_wsa_errlist): Use braces for struct initializers.
2338
2339 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2340 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2341 All callers changed.
2342 (string_buffer_position): Likewise. Also, make static (it's never
2343 used outside xdisp.c).
2344 (cursor_row_p): Remove parameter `w', unused since
2345 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2346 (decode_mode_spec): Remove parameter `precision', introduced during
2347 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2348 All callers changed.
2349
5ffb62aa
JD
23502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2351
2352 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2353
461c2ab9 23542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2355
2356 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2357 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2358 (ns_update_auto_hide_menu_bar): New functions.
2359 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2360 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2361 ns_constrain_all_frames.
2362 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2363 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2364
5c380ffb
JD
23652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2366
2367 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2368
9af30bdf
GM
23692011-03-27 Glenn Morris <rgm@gnu.org>
2370
2371 * syssignal.h: Replace RETSIGTYPE with void.
2372 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2373 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2374 Replace SIGTYPE with void everywhere.
2375 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2376 * s/template.h (SIGTYPE): Remove commented out definition.
2377
e2abce01
JB
23782011-03-26 Eli Zaretskii <eliz@gnu.org>
2379
2380 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2381 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2382
f868cd8a
JB
23832011-03-26 Juanma Barranquero <lekktu@gmail.com>
2384
59eb0929
JB
2385 * w32.c (read_unc_volume): Use parameter `henum', instead of
2386 global variable `wget_enum_handle'.
2387
2388 * keymap.c (describe_vector): Remove parameters `indices' and
2389 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2390 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2391
f868cd8a
JB
2392 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2393
2394 * keyboard.c (timer_check): Remove parameter `do_it_now',
2395 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2396 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2397 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2398
2399 * keyboard.c (read_char):
2400 * w32menu.c (w32_menu_display_help):
2401 * xmenu.c (show_help_event, menu_help_callback):
2402 Adjust calls to `show_help_echo'.
2403
2404 * gtkutil.c (xg_maybe_add_timer):
2405 * keyboard.c (readable_events):
2406 * process.c (wait_reading_process_output):
2407 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2408
2409 * insdel.c (adjust_markers_gap_motion):
2410 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2411 (gap_left, gap_right): Don't call it.
2412
2ecf6fdb
CY
24132011-03-25 Chong Yidong <cyd@stupidchicken.com>
2414
2415 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2416 incurred during fontification.
2417
6b1f9ba4
JB
24182011-03-25 Juanma Barranquero <lekktu@gmail.com>
2419
2420 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2421 (DEFVAR_PER_BUFFER): Don't pass it.
2422
2423 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2424 (scrolling_window): Don't pass it.
2425
0f4a96b5
JB
24262011-03-25 Juanma Barranquero <lekktu@gmail.com>
2427
2428 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2429
2430 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2431 and `suffix'.
2432 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2433 of variables specific to SELinux and computation of `encoded_absname'.
2434
2435 * image.c (XPutPixel): Remove unused variable `height'.
2436
2437 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2438
2439 * unexw32.c (get_section_info): Remove unused variable `section'.
2440
2441 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2442 (system_process_attributes): Remove unused variable `sess'.
2443 (sys_read): Remove unused variable `err'.
2444
2445 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2446 (w32_wnd_proc): Remove unused variable `isdead'.
2447 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2448 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2449 (x_create_tip_frame): Remove unused variable `tem'.
2450
2451 * w32inevt.c (w32_console_read_socket):
2452 Remove unused variable `no_events'.
2453
2454 * w32term.c (x_draw_composite_glyph_string_foreground):
2455 Remove unused variable `width'.
2456
1149507c
JB
24572011-03-24 Juanma Barranquero <lekktu@gmail.com>
2458
2459 * w32term.c (x_set_glyph_string_clipping):
2460 Don't pass uninitialized region to CombineRgn.
2461
9c88f339
JB
24622011-03-23 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2465 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2466 (Fx_close_connection): Remove unused variable `i'.
2467
2468 * w32font.c (w32font_draw): Return number of glyphs.
2469 (w32font_open_internal): Remove unused variable `i'.
2470 (w32font_driver): Add missing initializer.
2471
2472 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2473 (fill_in_menu): Remove unused variable `items_added'.
2474
2475 * w32term.c (last_mouse_press_frame): Remove static global variable.
2476 (w32_clip_to_row): Remove unused variable `f'.
2477 (x_delete_terminal): Remove unused variable `i'.
2478
2479 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2480 (NOTHING): Remove unused static global variable.
2481 (uniscribe_check_otf): Remove unused variable `table'.
2482 (uniscribe_font_driver): Add missing initializers.
2483
dee091a3
JD
24842011-03-23 Julien Danjou <julien@danjou.info>
2485
2486 * term.c (Fsuspend_tty, Fresume_tty):
2487 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2488 * window.c (temp_output_buffer_show):
2489 * insdel.c (signal_before_change):
2490 * frame.c (Fhandle_switch_frame):
2491 * fileio.c (Fdo_auto_save):
2492 * emacs.c (Fkill_emacs):
2493 * editfns.c (save_excursion_restore):
2494 * cmds.c (internal_self_insert):
2495 * callint.c (Fcall_interactively):
2496 * buffer.c (Fkill_all_local_variables):
2497 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2498 Use Frun_hooks.
0f4a96b5 2499 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2500 unconditionnaly since it does the check itself.
2501
2c520ab5 25022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2503
c9c49752
PE
2504 Fix more problems found by GCC 4.5.2's static checks.
2505
8abc3f12
PE
2506 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2507 the first time through the loop, since we know p0 < p1 then.
2508 This also avoids a gcc -Wstrict-overflow warning.
2509
a2d26660
PE
2510 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2511 leading to a memory leak, possible in functions like
2512 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2513 of objects (Bug#8318).
a2d26660 2514
916c72e9
PE
2515 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2516 that could (at least in theory) be that large.
2517
19ab8a18
PE
2518 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2519 This is less likely to overflow, and avoids undefined behavior if
2520 overflow does occur. All callers changed. Use strtoul to scan
2521 for the unsigned long integer.
b7cbbd6f
PE
2522 (pint2hrstr): Simplify and tune code slightly.
2523 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2524
f0641eff
PE
2525 * scroll.c (do_scrolling): Work around GCC bug 48228.
2526 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2527
7f650bb9
PE
2528 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2529 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2530 (validate_x_resource_name): Simplify count usage.
2531 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2532
37dd57d1
PE
2533 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2534 fail (Bug#8306).
81e56e61 2535
699979fc 2536 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2537
401bf9b4
PE
2538 * process.c (Fmake_network_process): Use socklen_t, not int,
2539 where POSIX says socklen_t is required in portable programs.
2540 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2541 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2542 (Fmake_network_process, server_accept_connection):
2543 (wait_reading_process_output, read_process_output):
2544 Likewise.
2545
b93aacde
PE
2546 * process.c: Rename or move locals to avoid shadowing.
2547 (list_processes_1, Fmake_network_process):
2548 (read_process_output_error_handler, exec_sentinel_error_handler):
2549 Rename or move locals.
4dc343ee 2550 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2551 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2552 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2553 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2554 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2555
af8a867c 2556 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2557 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2558 Include tparam.h instead, since it declares them.
af8a867c
PE
2559 * cm.h (PC): Remove extern decl; tparam.h now does this.
2560 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2561 * terminfo.c: Include tparam.h, to check interfaces.
2562 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2563 (tparam): Adjust signature to match interface in tparam.h;
2564 this removes some undefined behavior. Check that outstring and len
2565 are zero, which they always are with Emacs.
2566 * tparam.h (PC, BC, UP): New extern decls.
2567
0248044d 2568 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2569 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2570
8ff096c1 2571 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2572 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2573 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2574 (ftfont_list): Remove unused local.
49eaafba
PE
2575 (get_adstyle_property, ftfont_pattern_entity):
2576 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2577 Rename locals to avoid shadowing.
8ff096c1 2578
e2be39f6
PE
2579 * xfont.c (xfont_list_family): Mark var as initialized.
2580
c9735e30
PE
2581 * xml.c (make_dom): Now static.
2582
8f5201ae
PE
2583 * composite.c (composition_compute_stop_pos): Rename local to
2584 avoid shadowing.
b246f932
PE
2585 (composition_reseat_it): Remove unused locals.
2586 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2587 (composition_update_it): Mark var as initialized.
11b61122
PE
2588 (find_automatic_composition): Mark vars as initialized,
2589 with a FIXME (Bug#8290).
8f5201ae 2590
760fbc2c
PE
2591 character.h: Rename locals to avoid shadowing.
2592 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2593 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2594 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2595 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2596 to avoid shadowing.
2597
ff08eb85
PE
2598 * textprop.c (property_change_between_p): Remove; unused.
2599
fc7bf025
PE
2600 * intervals.c (interval_start_pos): Now static.
2601
235d7abc
PE
2602 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2603
44f230aa
SM
2604 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2605 Rename locals to avoid shadowing.
3e7d6594 2606
50060332
PE
2607 * sound.c (wav_play, au_play, Fplay_sound_internal):
2608 Fix pointer signedness.
d01f234b 2609 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2610 (wav_play): Initialize a variable to 0, to prevent undefined
2611 behavior (Bug#8278).
50060332 2612
c4fc4e30
PE
2613 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2614
918436ed
PE
2615 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2616
c939f91b
PE
2617 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2618 clobbering (Bug#8298).
b9c7f648
PE
2619 * sysdep.c (sys_subshell): Likewise.
2620 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2621
6bd8c144
PE
2622 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2623 This should get cleaned up, so that child_setup has the
2624 same signature on all platforms.
2625
7710357c 2626 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2627 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2628
c59da222
CY
26292011-03-22 Chong Yidong <cyd@stupidchicken.com>
2630
2631 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2632 not to be necessary, and produces flickering.
2633
66b87493
GM
26342011-03-20 Glenn Morris <rgm@gnu.org>
2635
2636 * config.in: Remove file.
2637
45b6f6d5
JB
26382011-03-20 Juanma Barranquero <lekktu@gmail.com>
2639
2640 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2641 are now in src/globals.h.
2642 (syms_of_minibuf): Remove spurious & from previous change.
2643
3ec03f7e
LL
26442011-03-20 Leo <sdl.web@gmail.com>
2645
2646 * minibuf.c (completing-read-function): New variable.
2647 (completing-read-default): Rename from completing-read.
2648 (completing-read): Call completing-read-function.
2649
b14e3e21
CY
26502011-03-19 Juanma Barranquero <lekktu@gmail.com>
2651
2652 * xfaces.c (Fx_load_color_file):
2653 Read color file from absolute filename (bug#8250).
2654
f2b726e6
JB
26552011-03-19 Juanma Barranquero <lekktu@gmail.com>
2656
2657 * makefile.w32-in: Update dependencies.
2658
09f6ff02
EZ
26592011-03-17 Eli Zaretskii <eliz@gnu.org>
2660
2661 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2662
29a6015a
PE
26632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2664
a3a6c54e
PE
2665 Fix more problems found by GCC 4.5.2's static checks.
2666
b766f867
PE
2667 * process.c (make_serial_process_unwind, send_process_trap):
2668 (sigchld_handler): Now static.
2669
be02381c
PE
2670 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2671 That way, the code declares only the vars that it needs.
2672 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2673 * s/cygwin.h (PTY_ITERATION): Likewise.
2674 * s/darwin.h (PTY_ITERATION): Likewise.
2675 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2676
57048744
PE
2677 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2678 * process.c (allocate_pty): Don't declare stb unless it's needed.
2679
7914961c 2680 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2681 (CONSTANTLIM): Remove; unused.
2682 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2683 Define only if needed.
7914961c 2684
b3967b18
PE
2685 * unexelf.c (unexec): Name an expression,
2686 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2687 Use a different way to cause a compilation error if anyone uses
2688 n rather than nn, a way that does not involve shadowing.
73366a00 2689 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2690
29a6015a
PE
2691 * deps.mk (unexalpha.o): Remove; unused.
2692
43cfc33e 2693 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2694 * unexec.h: New file.
ce701a33
PE
2695 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2696 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2697 Depend on unexec.h.
2698 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2699 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2700 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2701 Change as necessary to match prototype in unexec.h.
ce701a33 2702
01f44d5a
PE
2703 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2704 shadowing.
4f63c6bb 2705 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2706
a6670b0b
PE
2707 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2708 Rename locals to avoid shadowing.
2709
cef2010d 2710 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2711 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2712
d4d7173a
PE
2713 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2714
f08b802a
PE
2715 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2716 warning when compiling print.c.
2717
3ddb0639
PE
2718 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2719 instead of using an uninitialized var.
5ad03b97 2720 (font_sort_entities): Mark var as initialized.
3ddb0639 2721
170a2692
PE
2722 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2723
e663c700
PE
2724 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2725 pointers to constants.
89bc529a 2726 (font_parse_fcname): Remove unused vars.
7b81e2d0 2727 (font_delete_unmatched): Now static.
ea838e10 2728 (font_get_spec): Remove; unused.
13a547c6
PE
2729 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2730 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2731 Rename or move locals to avoid shadowing.
e663c700 2732
2a80c887 2733 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2734 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2735
1384fa33 2736 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2737 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2738
8b2c52e9
PE
2739 * alloc.c (mark_backtrace): Move decl from here ...
2740 * lisp.h: ... to here, so that it can be checked.
2741
475545b5 2742 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2743 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2744 (lisp_indirect_variable): Name an expression,
2745 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2746 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2747
b1349114 2748 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2749 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2750 Use const pointer when appropriate.
b1349114 2751
a2928364
PE
2752 * lisp.h (get_system_name, get_operating_system_release):
2753 Move decls here, to check interfaces.
2754 * process.c (get_operating_system_release): Move decl to lisp.h.
2755 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2756 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2757 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2758 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2759 (Fformat_time_string, Fencode_time, Finsert_char):
2760 (Ftranslate_region_internal, Fformat):
2761 Rename or remove local vars to avoid shadowing.
9710023e 2762 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2763
a415e694
PE
2764 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2765 avoid shadowing.
2766
8ef4622d
PE
2767 * lisp.h (eassert): Check that the argument compiles, even if
2768 ENABLE_CHECKING is not defined.
2769
946f9a5b
PE
2770 * data.c (Findirect_variable): Name an expression, to avoid
2771 gcc -Wbad-function-cast warning.
112396d6 2772 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2773 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2774 (Fmake_variable_buffer_local, Fmake_local_variable):
2775 Mark variables as initialized.
52746918 2776 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2777
e5aab7e7 2778 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2779 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2780 Rename locals to avoid shadowing.
dff45157
PE
2781 (mark_stack): Move local variables into the #ifdef region where
2782 they're used.
7bc26fdb
PE
2783 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2784 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2785 needed otherwise.
2786 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2787 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2788 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2789
e5aab7e7
PE
2790 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2791 avoids undefined behavior in theory.
2792
4da60324
PE
2793 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2794
88043301
PE
2795 Use functions, not macros, for up- and down-casing (Bug#8254).
2796 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2797 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2798 to use the following functions instead of these macros.
2799 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2800 EMACS_INT, since callers assume the returned value fits in int.
2801 (upcase1): Likewise, for UPCASE_TABLE.
2802 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2803 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2804 the race-condition problem in the old DOWNCASE.
88043301 2805
19ed5445
PE
2806 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2807 Rename locals to avoid shadowing.
2808 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2809 (regex_compile, re_search_2, re_match_2_internal):
2810 Remove unused local vars.
952db0d7
PE
2811 (FREE_VAR): Rewrite so as not to use empty "else",
2812 which gcc can warn about.
da053e48 2813 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2814 (RETALLOC_IF): Define only if needed.
2815 (WORDCHAR_P): Likewise. This one is never needed, but is used
2816 only in a comment talking about a compiler bug, so put inside
2817 the #if 0 of that comment.
2818 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2819 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2820 Remove; unused.
19ed5445 2821
1f3561e4 2822 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2823 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2824 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2825
ded6f8f7
PE
2826 * search.c (simple_search): Remove unused var.
2827
dbd37a95
PE
2828 * dired.c (compile_pattern): Move decl from here ...
2829 * lisp.h: ... to here, so that it can be checked.
2830 (struct re_registers): New forward decl.
2831
7e47afad
PE
2832 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2833
85f24f61
PE
2834 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2835 All uses changed.
2836 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2837 Rename locals to avoid shadowing.
5671df8f 2838 (Fvertical_motion): Mark locals as initialized.
85f24f61 2839
181aa2be 2840 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2841 (casify_region): Mark local as initialized.
181aa2be 2842
930d429c
PE
2843 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2844
7082eac6
PE
2845 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2846 New macros, so that the caller can use some names other than
2847 gcpro1, gcpro2, etc.
2848 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2849 of the new macros.
2850 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2851 argument, for consistency with GCPRO2_VAR, etc: it is now the
2852 prefix of the variable, not the variable itself. All uses
2853 changed.
38b2c076
PE
2854 * dired.c (directory_files_internal, file_name_completion):
2855 Rename locals to avoid shadowing.
2856
15206ed9
PE
2857 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2858 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2859 dired.c's scmp function, had undefined behavior.
2860 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2861 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2862 * buffer.h: ... to here, because these macros use current_buffer,
2863 and the new implementation with inline functions needs to have
2864 current_buffer in scope now, rather than later when the macros
2865 are used.
2866 (downcase, upcase1): New static inline functions.
2867 (DOWNCASE, UPCASE1): Reimplement using these functions.
2868 This avoids undefined behavior in expressions like
2869 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2870 from race conditions in accessing the global variables
2871 case_temp1 and case_temp2.
2872 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2873 * lisp.h (case_temp1, case_temp2): Remove their decls.
2874 * character.h (ASCII_CHAR_P): Move from here ...
2875 * lisp.h: ... to here, so that the inline functions mentioned
2876 above can use them.
2877
4a6bea26
PE
2878 * dired.c (directory_files_internal_unwind): Now static.
2879
f14b7e14
PE
2880 * fileio.c (file_name_as_directory, directory_file_name):
2881 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2882 Now static.
2893f146
PE
2883 (file_name_as_directory): Use const pointers when appropriate.
2884 (Fexpand_file_name): Likewise. In particular, newdir might
2885 point at constant storage, so make it a const pointer.
fd4ead52 2886 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2887 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2888 signedness issues.
f839df0c
PE
2889 (Fset_file_times, Finsert_file_contents, auto_save_error):
2890 Rename locals to avoid shadowing.
f14b7e14 2891
5716756e 2892 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2893 (Ftry_completion, Fall_completions): Rename or remove locals
2894 to avoid shadowing.
5716756e 2895
b4c3046a
PE
2896 * marker.c (bytepos_to_charpos): Remove; unused.
2897
b45db522
PE
2898 * lisp.h (verify_bytepos, count_markers): New decls,
2899 so that gcc does not warn that these functions aren't declared.
2900
85876d07
PE
2901 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2902 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2903 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2904 (copy_text): Remove unused local var.
85876d07 2905
03d78a21 2906 * filelock.c (within_one_second): Now static.
b3dd38ab 2907 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2908
5df8f01b
PE
2909 * buffer.c (fix_overlays_before): Mark locals as initialized.
2910 (fix_start_end_in_overlays): Likewise. This function should be
2911 simplified by using pointers-to-pointers, but that's a different
2912 matter.
b1d876f1 2913 (switch_to_buffer_1): Now static.
8f54f30a
PE
2914 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2915 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2916
a70072c9 2917 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2918 Fix pointer signedness issue.
edced198
PE
2919 (sys_subshell): Mark local as volatile if checking for lint,
2920 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2921 (MAXPATHLEN): Define only if needed.
a70072c9 2922
a0977c44
PE
2923 * process.c (serial_open, serial_configure): Move decls from here ...
2924 * systty.h: ... to here, so that they can be checked.
2925
a884fdcc
PE
2926 * fns.c (get_random, seed_random): Move extern decls from here ...
2927 * lisp.h: ... to here, so that they can be checked.
2928
604efe86 2929 * sysdep.c (reset_io): Now static.
b8950c94 2930 (wait_for_termination_signal): Remove; unused.
604efe86 2931
38fc62d9
PE
2932 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2933 (copy_keymap_item, append_key, push_text_char_description):
2934 Now static.
1004a21a 2935 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2936 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2937 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2938 (describe_map_tree):
2939 Rename locals to avoid shadowing.
38fc62d9 2940
2f2650da
PE
2941 * keyboard.c: Declare functions static if they are not used elsewhere.
2942 (echo_char, echo_dash, cmd_error, top_level_2):
2943 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2944 (read_char, kbd_buffer_get_event, make_lispy_position):
2945 (make_lispy_event, make_lispy_movement, apply_modifiers):
2946 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2947 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2948 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2949 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2950 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2951
a053e86c 2952 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2953 (mark_kboards): Move decl here ...
2954 * alloc.c (mark_kboards): ... from here.
a053e86c 2955
4752793e
PE
2956 * lisp.h (force_auto_save_soon): New decl.
2957
74f10ca7 2958 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2959 (DEFINE_DUMMY_FUNCTION): New macro.
2960 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2961 Use it.
c03cd23f
PE
2962 (main): Add casts to avoid warnings
2963 if GCC considers string literals to be constants.
74f10ca7 2964
022e70d4
PE
2965 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2966
59d6fe83
PE
2967 * dbusbind.c: Pointer signedness fixes.
2968 (xd_signature, xd_append_arg, xd_initialize):
2969 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2970 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2971 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2972 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2973
78320123
PE
2974 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2975 if GCC considers string literals to be constants.
49cebcca 2976 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2977
35ac2a97
SM
29782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2979
fb103ca9
SM
2980 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2981 (print_preprocess, print_object): New macro to fix last change.
2982
35ac2a97
SM
2983 * print.c (print_preprocess): Don't forget font objects.
2984
62973b41
JB
29852011-03-16 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * emacs.c (USAGE3): Doc fixes.
2988
0e48bb22
AS
29892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2990
2991 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2992 structure.
2993
7684e57b
JB
29942011-03-14 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * lisp.h (VWindow_system, Qfile_name_history):
2997 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2998 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2999 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3000
3001 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3002 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3003
3004 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3005 * w32console.c (detect_input_pending, read_input_pending)
3006 (encode_terminal_code):
3007 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3008 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3009 (w32_system_caret_y, Qfile_name_history):
3010 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3011 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3012 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3013 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3014 * w32proc.c (Qlocal, report_file_error):
3015 * w32term.c (Vwindow_system, updating_frame):
3016 * w32uniscribe.c (initialized, uniscribe_font_driver):
3017 Remove unneeded extern declarations.
3018
2aa46d6c
CY
30192011-03-14 Chong Yidong <cyd@stupidchicken.com>
3020
c96bbc66 3021 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3022
cffc6f3b
CY
30232011-03-13 Chong Yidong <cyd@stupidchicken.com>
3024
3025 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3026 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3027 These macros can no longer be used for assignment.
3028
44f230aa
SM
3029 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3030 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3031 (record_buffer_markers, fetch_buffer_markers): New functions for
3032 recording and fetching special buffer markers.
3033 (set_buffer_internal_1, set_buffer_temp): Use them.
3034
3035 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3036
3037 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3038
3039 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3040 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3041
3042 * xdisp.c (hscroll_window_tree):
3043 (reconsider_clip_changes): Use PT instead of BUF_PT.
3044
d251f04b
EZ
30452011-03-13 Eli Zaretskii <eliz@gnu.org>
3046
3047 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3048 $(EMACS_ROOT)/lib/intprops.h.
3049
f0c77cd1
PE
30502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3051
3eca4629
PE
3052 Fix more problems found by GCC 4.5.2's static checks.
3053
7c86ee98
PE
3054 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3055 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3056 (xg_free_frame_widgets): Make it clear that a local variable is
3057 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3058 (gdk_window_get_screen): Make it clear that this macro is needed
3059 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3060 (int_gtk_range_get_value): New function, which avoids a diagnostic
3061 from gcc -Wbad-function-cast.
3062 (xg_set_toolkit_scroll_bar_thumb): Use it.
3063 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3064 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3065 (get_utf8_string, xg_get_file_with_chooser):
3066 Rename locals to avoid shadowing.
3067 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3068
41729b81
PE
3069 * xgselect.c (xg_select): Remove unused var.
3070
f0c77cd1
PE
3071 * image.c (four_corners_best): Mark locals as initialized.
3072 (gif_load): Initialize transparent_p to zero (Bug#8238).
3073 Mark another local as initialized.
ec6cf4c6 3074 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3075
ce0ad53d 3076 * image.c (clear_image_cache): Now static.
d5d5a617 3077 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3078 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3079 (x_edge_detection): Remove unnecessary cast that
3080 gcc -Wbad-function-cast diagnoses.
2037898d 3081 (gif_load): Fix pointer signedness.
6ae141d6
PE
3082 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3083 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3084
33383987 30852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3086
d32df629
PE
3087 Improve quality of tests for time stamp overflow.
3088 For example, without this patch (encode-time 0 0 0 1 1
3089 1152921504606846976) returns the obviously-bogus value (-948597
3090 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3091 reports time overflow. See
3092 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3093 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3094 * editfns.c: Include limits.h and intprops.h.
3095 (TIME_T_MIN, TIME_T_MAX): New macros.
3096 (time_overflow): Move earlier, to before first use.
3097 (hi_time, lo_time): New functions, for an accurate test for
3098 out-of-range times.
3099 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3100 (Fget_internal_run_time): Don't assume time_t fits in int.
3101 (make_time): Use list2 instead of Fcons twice.
3102 (Fdecode_time): More accurate test for out-of-range times.
3103 (check_tm_member): New function.
3104 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3105 (lisp_time_argument): Don't rely on undefined left-shift and
3106 right-shift behavior when checking for time stamp overflow.
8be6f318 3107
fe31d94c
PE
3108 * editfns.c (time_overflow): New function, refactoring common code.
3109 (Fformat_time_string, Fdecode_time, Fencode_time):
3110 (Fcurrent_time_string): Use it.
3111
8be6f318
PE
3112 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3113 * dired.c (make_time): Move to ...
3114 * editfns.c (make_time): ... here.
3115 * systime.h: Note the move.
3116
09d9db2c 31172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3118
126bc0dc
YM
3119 * fringe.c (update_window_fringes): Remove unused variables.
3120
c47cbdfd
YM
3121 * unexmacosx.c (copy_data_segment): Also copy __got section.
3122 (Bug#8223)
3123
7ac80be9
EZ
31242011-03-12 Eli Zaretskii <eliz@gnu.org>
3125
c96bbc66 3126 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3127 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3128 Constify `char *' arguments and their references according to
3129 prototypes in tparam.h.
3130
ecb0f94d 3131 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3132
7ac80be9
EZ
3133 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3134 Adapt all references accordingly.
3135
3136 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3137
ef1fd07e
TT
31382011-03-11 Tom Tromey <tromey@redhat.com>
3139
3140 * buffer.c (syms_of_buffer): Remove obsolete comment.
3141
7ef4b50c
EZ
31422011-03-11 Eli Zaretskii <eliz@gnu.org>
3143
3144 * termhooks.h (encode_terminal_code): Declare prototype.
3145
3146 * msdos.c (encode_terminal_code): Don't declare prototype.
3147
3148 * term.c (encode_terminal_code): Now external again, used by
3149 w32console.c and msdos.c.
3150
44f230aa
SM
3151 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3152 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3153
4b1ec863 31542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3155
1714f52b 3156 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3157
4b1ec863
PE
3158 * fringe.c (update_window_fringes): Mark locals as initialized
3159 (Bug#8227).
3160 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3161
524c7aa6
PE
3162 * alloc.c (mark_fringe_data): Move decl from here ...
3163 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3164 to check its interface.
3165 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3166
a5c0af81 3167 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3168 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3169 (fontset_font): Mark local as initialized.
a9a06e0b 3170 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3171
b4716021
PE
3172 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3173
811e9bac 3174 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3175 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3176 (x_own_selection, Fx_disown_selection_internal): Rename locals
3177 to avoid shadowing.
3178 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3179
7e3ab302
PE
3180 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3181 so that the caller can use some name other than gcpro1.
3182 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3183 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3184 (Fx_backspace_delete_keys_p):
3185 Use them to avoid shadowing, and rename vars to avoid shadowing.
3186 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3187 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3188 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3189 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3190 Remove unused locals.
7e3ab302
PE
3191 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3192 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3193 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3194 macros.
f78faa98 3195
e2b13473
PE
3196 * xterm.h (x_mouse_leave): New decl.
3197
77f23912
PE
3198 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3199 Remove unused functions.
cdf4ba58
PE
3200 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3201 (x_calc_absolute_position): Now static.
7411c686 3202 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3203 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3204 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3205 unless they are used.
38d0b34a
PE
3206 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3207 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3208 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3209 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3210 (x_error_catcher, x_connection_closed, x_error_handler):
3211 (x_error_quitter, xembed_send_message, x_iconify_frame):
3212 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3213 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3214 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3215
44f230aa
SM
3216 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3217 Rename or move locals to avoid shadowing.
6b463e58 3218 (tty_defined_color, merge_face_heights): Now static.
5967d051 3219 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3220 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3221 does not deduce is never used uninitialized.
73719eba
PE
3222 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3223 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3224
426994c3 3225 * terminal.c (store_terminal_param): Now static.
5489860b 3226
032f1620 3227 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3228 (set_frame_menubar): Remove unused local.
d4323972 3229 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3230 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3231 since they might point to immutable storage.
281585b0
PE
3232 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3233 since it's unused otherwise.
032f1620 3234
367c19e5 3235 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3236 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3237 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3238 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3239 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3240 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3241 does not deduce are never used uninitialized.
70739cbe 3242
07b48fa9
PE
3243 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3244
8868a238 3245 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3246 * window.c (window_loop, size_window):
3247 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3248
7e5cf297 3249 * window.c (display_buffer): Now static.
d6550a9f
PE
3250 (size_window): Mark variables that gcc -Wuninitialized
3251 does not deduce are never used uninitialized.
a586633d
PE
3252 * window.h (check_all_windows): New decl, to forestall
3253 gcc -Wmissing-prototypes diagnostic.
5b555da1 3254 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3255
f6095868
PE
3256 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3257 shadowing.
3258 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3259 Include <limits.h>.
3260 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3261 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3262 (load_charset_map): Mark variables that gcc -Wuninitialized
3263 does not deduce are never used uninitialized.
53df7c11 3264 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3265
f38b440c
PE
3266 * coding.c (coding_set_source, coding_set_destination):
3267 Use "else { /* comment */ }" rather than "else /* comment */;"
3268 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3269 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3270 a block, when the outer 'i' will do.
3271 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3272 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3273 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3274 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3275 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3276 Rename locals to avoid shadowing.
3277 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3278 * coding.c (emacs_mule_char, encode_invocation_designation):
3279 Now static, since they're not used elsewhere.
413bb2db 3280 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3281 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3282 (decode_coding_emacs_mule): Mark variables that gcc
3283 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3284 (detect_coding_iso_2022): Initialize a local variable that might
3285 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3286 this initialization is needed. (Bug#8211)
5f58e762
PE
3287 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3288 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3289 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3290 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3291 Remove unused macros.
f38b440c 3292
232b38b9 3293 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3294 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3295 * character.c (string_count_byte8): Likewise.
232b38b9 3296
fb90da1b
PE
3297 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3298 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3299
fb93dbc2
PE
3300 * chartab.c (copy_sub_char_table): Now static, since it's not used
3301 elsewhere.
5c156ace
PE
3302 (sub_char_table_ref_and_range, char_table_ref_and_range):
3303 Rename locals to avoid shadowing.
bbcd0949 3304 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3305
7d3b3862 3306 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3307 (BIDI_BOB): Remove unused macro.
7d3b3862 3308
6be7d3da
PE
3309 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3310 deduce are never used uninitialized.
c2ed9c8b 3311 * term.c (encode_terminal_code): Likewise.
6be7d3da 3312
75f8807f 3313 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3314
50938595
PE
3315 * tparam.h: New file.
3316 * term.c, tparam.h: Include it.
3317 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3318 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3319 Move these decls to tparam.h, and make them agree with what
3320 is actually in tparam.c. The previous trick of using incompatible
3321 decls in different modules does not conform to the C standard.
3322 All callers of tparam changed to use tparam's actual API.
3323 * tparam.c (tparam1, tparam, tgoto):
3324 Use const pointers where appropriate.
3325
fbceeba2
PE
3326 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3327 * cm.h (struct cm): Likewise.
3328 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3329 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3330 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3331 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3332 (turn_on_face, init_tty): Likewise.
3333 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3334
7f3f1250
PE
3335 * term.c (term_mouse_position): Rename local to avoid shadowing.
3336
e6ca6543
PE
3337 * alloc.c (mark_ttys): Move decl from here ...
3338 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3339
c40f8d15
AS
33402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3341
3342 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3343
cfe0661d
JB
33442011-03-09 Juanma Barranquero <lekktu@gmail.com>
3345
3346 * search.c (compile_pattern_1): Remove argument regp, unused since
3347 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3348 (compile_pattern): Don't pass it.
3349
0afb4571
J
33502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3351
3352 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3353 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3354 for ! HAVE_GTK3.
3355 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3356
3357 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3358
3359 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3360 gdk_window_get_screen, gdk_window_get_geometry,
3361 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3362 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3363 (xg_get_pixbuf_from_pixmap): New function.
3364 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3365 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3366 Call xg_get_pixbuf_from_pixmap instead of
3367 gdk_pixbuf_get_from_drawable.
3368 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3369 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3370 (xg_check_special_colors): Use GtkStyleContext and its functions
3371 for HAVE_GTK3.
3372 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3373 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3374 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3375 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3376 Call gtk_widget_get_preferred_size.
0afb4571
J
3377 (xg_frame_resized): gdk_window_get_geometry only takes 5
3378 parameters.
44f230aa
SM
3379 (xg_win_to_widget, xg_event_is_for_menubar):
3380 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3381 (xg_set_widget_bg): New function.
3382 (delete_cb): New function.
895009e1 3383 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3384 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3385 (xg_set_background_color): Call xg_set_widget_bg.
3386 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3387 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3388 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3389 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3390 if ! HAVE_GTK3.
3391 (update_frame_tool_bar): Call gtk_widget_hide.
3392 (xg_initialize): Use GDK_KEY_g.
3393
3394 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3395 if ! HAVE_GTK3
3396 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3397
3398 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3399 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3400 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3401
1c2cc4ef
JB
34022011-03-08 Juanma Barranquero <lekktu@gmail.com>
3403
3404 * w32xfns.c (select_palette): Check success of RealizePalette against
3405 GDI_ERROR, not zero.
3406
33383987 3407See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3408
3409;; Local Variables:
3410;; coding: utf-8
aac0c6e3
MR
3411;; End:
3412
33383987 3413 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3414
3415 This file is part of GNU Emacs.
3416
3417 GNU Emacs is free software: you can redistribute it and/or modify
3418 it under the terms of the GNU General Public License as published by
3419 the Free Software Foundation, either version 3 of the License, or
3420 (at your option) any later version.
3421
3422 GNU Emacs is distributed in the hope that it will be useful,
3423 but WITHOUT ANY WARRANTY; without even the implied warranty of
3424 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3425 GNU General Public License for more details.
3426
3427 You should have received a copy of the GNU General Public License
3428 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.