Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c7f2cd7f
PE
12012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4 Tighten new eassert a bit.
5
8ce70ed2
DA
62012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Fix compilation with --enable-gcc-warnings and -O1
9 optimization level.
10 * doprnt.c (doprnt): Change type of tem to int, initialize
11 to avoid compiler warning. Add eassert.
12 * search.c (simple_search): Initialize match_byte to avoid
13 compiler warning. Add eassert.
14
dea7f1e5
PE
152012-07-04 Paul Eggert <eggert@cs.ucla.edu>
16
24a212eb
PE
17 Avoid weird behavior with large horizontal scrolls.
18 Without this change, for example, large hscroll values would
19 mess up Emacs's display on Fedora 15 x86, presumably due to
20 overflows in int calculations in the display code.
21 Also, if buffers had long lines, Emacs would freeze.
22 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
23 (set_window_hscroll): New function, containing the old guts of
24 Fset_window_hscroll. Return the clipped value.
25 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
26 This avoids the need to check against PTRDIFF_MAX.
27
dea7f1e5
PE
28 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
29
76046526
DA
302012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
31
32 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
33
39adff0d
PE
342012-07-04 Paul Eggert <eggert@cs.ucla.edu>
35
63807d47
PE
36 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
37 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
38 since GCC 4.4.6 issues a bogus warning for them.
39
39adff0d
PE
40 Fix bugs in file timestamp newness comparisons.
41 * fileio.c (Ffile_newer_than_file_p):
42 * lread.c (Fload): Use full timestamp resolution of files,
43 not just the 1-second resolution, so that files that are only
44 slightly newer still count as newer.
45 * fileio.c (Ffile_newer_than_file_p): Don't assume file
46 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
47
dbeed9a6
PE
482012-07-03 Paul Eggert <eggert@cs.ucla.edu>
49
50 * fileio.c: Improve handling of file time marker. (Bug#11852)
51 (special_mtime): New function.
52 (Finsert_file_contents, Fverify_visited_file_modtime):
53 Use it to set special mtime values consistently.
54
636334d6
AS
552012-07-03 Andreas Schwab <schwab@linux-m68k.org>
56
57 * fileio.c (Finsert_file_contents): Properly handle st_mtime
58 marker for non-existing file. (Bug#11852)
59
e2017fe2
GM
602012-07-03 Glenn Morris <rgm@gnu.org>
61
62 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
63 and did not make it into globals.h).
64
404dbd37
TT
652012-07-03 Tom Tromey <tromey@redhat.com>
66
67 * window.c (Fset_window_margins, Fset_window_fringes)
68 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
69 * textprop.c (Fprevious_property_change): No longer static.
70 * syntax.c (Fsyntax_table_p): No longer static.
71 * process.c (Fget_process, Fprocess_datagram_address): No longer
72 static.
73 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
74 * keyboard.c (Fcommand_execute): No longer static.
75 Remove EXFUN.
76 * insdel.c (Fcombine_after_change_execute): No longer static.
77 * image.c (Finit_image_library): No longer static.
78 * fileio.c (Fmake_symbolic_link): No longer static.
79 * eval.c (Ffetch_bytecode): No longer static.
80 * editfns.c (Fuser_full_name): No longer static.
81 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
82 longer static.
83 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
84 static.
85 * dired.c (Ffile_attributes): No longer static.
86 * composite.c (Fcomposition_get_gstring): No longer static.
87 * callproc.c (Fgetenv_internal): No longer static.
88
89 * ccl.h: Remove EXFUNs.
90 * buffer.h: Remove EXFUNs.
91 * dispextern.h: Remove EXFUNs.
92 * intervals.h: Remove EXFUNs.
93 * fontset.h: Remove EXFUN.
94 * font.h: Remove EXFUNs.
95 * dosfns.c (system_process_attributes): Remove EXFUN.
96 * keymap.h: Remove EXFUNs.
97 * lisp.h: Remove EXFUNs.
98 * w32term.h: Remove EXFUNs.
99 * window.h: Remove EXFUNs.
100 * xsettings.h: Remove EXFUN.
101 * xterm.h: Remove EXFUN.
102
8e4fd1e1
GM
1032012-07-03 Glenn Morris <rgm@gnu.org>
104
105 * lisp.h (Frandom): Make it visible to C.
106 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
107 buffer for invisible buffers. (Bug#1229)
108
ca95b3eb
DA
1092012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
112 values which aren't power of 2.
113 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
114 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
115 accordingly.
116
7555c33f
SM
1172012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
118
119 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
120
121 * alloc.c (mark_object): Revert part of last patch to use `switch'.
122
d12e8f5a
DA
1232012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
124
125 * alloc.c (allocate_vector_block): Remove redundant
126 calls to mallopt if DOUG_LEA_MALLOC is defined.
127 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
128 avoid calls to mallopt if zero_vector is returned.
129
296094c3
DA
1302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
131
132 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
133 is enabled, avoid dereferencing NULL current_sblock if
134 running undumped.
135
36429c89
DA
1362012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Cleanup basic buffer management.
139 * buffer.h (struct buffer): Change layout to use generic vector
140 marking code. Fix some comments. Change type of 'clip_changed'
141 to bitfield. Remove unused #ifndef old.
142 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
143 (GET_OVERLAYS_AT): Fix indentation.
144 (for_each_per_buffer_object_at): New macro.
145 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
146 (Fbuffer_local_variables): Use it.
147 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
148 * alloc.c (allocate_buffer): Adjust to match new layout of
149 struct buffer. Fix comment.
150 (mark_overlay): New function.
151 (mark_buffer): Use it. Use mark_vectorlike to mark normal
152 Lisp area of struct buffer.
153 (mark_object): Use it. Adjust marking of misc objects
154 and related comments.
155
3b3e4cac
PE
1562012-07-02 Paul Eggert <eggert@cs.ucla.edu>
157
158 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
159 wrapper that is not needed because the wrapped code is a no-op (zero
160 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
161 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
162
cf5c0175
DA
1632012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
164
165 * alloc.c (mark_buffer): Simplify. Remove prototype.
166 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 167 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
168 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
169 redundant calls to mark_vectorlike for bool vectors.
170
ca26824c
GM
1712012-06-30 Glenn Morris <rgm@gnu.org>
172
2e4c5312
GM
173 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
174
ca26824c
GM
175 * epaths.in (PATH_SITELOADSEARCH): New.
176 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
177 This is rather than relying on --enable-locallisppath elements
178 having "site-lisp" in their names. (Bug#10208#25, 11658)
179
0d23c240
EZ
1802012-06-30 Eli Zaretskii <eliz@gnu.org>
181
c9240d7a
EZ
182 * w32proc.c (sys_select): Accept and ignore one more argument.
183
184 * w32.c (emacs_gnutls_pull): Call select with one more argument.
185
0d23c240 186 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 187 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
188
189 * sysdep.c: Don't include dos.h and dosfns.h.
190
191 * process.c (sys_select):
192 * msdos.c (sys_select): Accept one more argument and ignore it.
193
194 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
195 adapt data types and code to that.
196
197 * dosfns.c:
198 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
199 which clashes with the gnulib function of the same name.
200
af5a5a98
AS
2012012-06-30 Andreas Schwab <schwab@linux-m68k.org>
202
c5e4379c
AS
203 * font.c (font_style_to_value, font_style_symbolic)
204 (font_prop_validate_style): Add type checks for values in
205 font_style_table.
206
af5a5a98
AS
207 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
208 argument.
209 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
210 uses.
211
8d38f461
EZ
2122012-06-29 Eli Zaretskii <eliz@gnu.org>
213
2e5a6631
EZ
214 * xdisp.c (try_window_id): Undo last change.
215
8d38f461
EZ
216 * w32.c (getwd): Adjust commentary about startup_dir.
217 (init_environment): Always call sys_access, even in non-MSVC
218 builds. Don't chdir to the directory of the Emacs executable.
219 This undoes code from 1997 which was justified by the need to
220 "avoid conflicts when removing and renaming directories". But its
221 downside was that every relative file name was being interpreted
222 relative to the directory of the Emacs executable, which can never
223 be TRT. In particular, it broke sys_access when called with
224 relative file names.
225 (sys_access): Map GetLastError to errno.
226
2af3565e
DA
2272012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * window.h (struct window): Change type of 'fringes_outside_margins'
230 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 231 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
232 Adjust comment.
233 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
234 to ptrdiff_t.
235
c8d3a25c 2362012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 237
c8d3a25c
GM
238 * gnutls.c (emacs_gnutls_handshake):
239 Add QUIT to make the loop interruptible.
57570cd3 240
c8d3a25c 2412012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 242
c8d3a25c
GM
243 * charset.c (init_charset): Make lack of etc/charsets fatal.
244
3e984ee8
DA
2452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
246
247 * editfns.c (region_limit): Fix type mismatch.
248
ef884f23
DA
2492012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
250
251 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
252 undefined. Convert from xassert to eassert.
253 * nsmenu.m: Convert from xassert to eassert.
254 * nsterm.m: Likewise.
255
7d7e0027
SM
2562012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * editfns.c (region_limit): Clip to narrowing (bug#11770).
259
aa754e6a
PE
2602012-06-28 Paul Eggert <eggert@cs.ucla.edu>
261
262 Avoid integer overflow on scroll-left and scroll-right.
263 * window.c (HSCROLL_MAX): New macro.
264 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
265 overflow when requested scroll falls outside ptrdiff_t range.
266
80b00b08
DA
2672012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
268
269 * window.h (struct window): Change type of 'hscroll',
270 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
271 'last_modified' and 'last_overlay_modified' to EMACS_INT.
272 Adjust users accordingly.
273 * xdisp.c (try_cursor_movement): Replace type check with eassert.
274 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
275 from EMACS_INT to ptrdiff_t.
276 (make_window): Omit redundant initialization.
277
62b2bcf6
JB
2782012-06-28 Juanma Barranquero <lekktu@gmail.com>
279
280 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
281
45942c7d
DA
2822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
283
284 * window.h (struct window): Change type of 'use_time' and
285 'sequence_number' from Lisp_Object to int.
286 * frame.c (make_frame): Adjust users accordingly.
287 * print.c (print_object): Likewise.
288 * window.c (select_window, Fwindow_use_time, make_parent_window)
289 (make_window): Likewise.
290
e509cfa6
DA
2912012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
292
293 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
294 enabled with --enable-checking=[all,glyphs] configure option.
295 Fix GLYPH_DEBUG usage assuming that it may be undefined,
296 adjust comments accordingly.
297 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
298 undefined, adjust comments accordingly.
299 * image.c: Likewise.
300 * scroll.c: Likewise.
301 * w32fns.c: Likewise.
302 * w32term.c: Likewise.
303 * xdisp.c: Likewise.
304 * xfaces.c: Likewise.
305 * xfns.c: Likewise.
306 * xterm.c: Likewise.
307
a54e2c05
DA
3082012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
309
310 Generalize run-time debugging checks.
311 * dispextern.h (XASSERTS): Remove.
312 * fontset.c (xassert): Remove.
313 Convert from xassert to eassert.
314 * alloc.c: Convert from xassert to eassert.
315 * bidi.c: Likewise.
316 * dispnew.c: Likewise.
317 * fns.c: Likewise.
318 * fringe.c: Likewise.
319 * ftfont.c: Likewise.
320 * gtkutil.c: Likewise.
321 * image.c: Likewise.
322 * keyboard.c: Likewise.
323 * menu.c: Likewise.
324 * process.c: Likewise.
325 * scroll.c: Likewise.
326 * sound.c: Likewise.
327 * term.c: Likewise.
328 * w32console.c: Likewise.
329 * w32fns.c: Likewise.
330 * w32term.c: Likewise.
331 * window.c: Likewise.
332 * xdisp.c: Likewise.
333 * xfaces.c: Likewise.
334 * xfns.c: Likewise.
335 * xselect.c: Likewise.
336 * xterm.c: Likewise.
337
1ec4b7b2
SM
3382012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
339
340 * fns.c (maybe_resize_hash_table): Output message when growing the
341 purify-hashtable.
342
2014308a
DA
3432012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
344
345 * alloc.c (allocate_string_data): Remove dead code.
346 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
347 avoid GCC warning about unused macro.
348
246155eb
DA
3492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
350
351 * alloc.c (allocate_string): Omit intervals initialization.
352 * alloc.c (make_uninit_multibyte_string): Initialize intervals
353 as in make_pure_string and make_pure_c_string.
354
43184b7b
DA
3552012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
356
357 * alloc.c (allocate_string): Fix last change.
358
3fe6dd74
DA
3592012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
360
361 * alloc.c (allocate_string): Remove two redundant calls
362 to memset, add explicit initialization where appropriate.
363
1ba6038a
GM
3642012-06-27 Glenn Morris <rgm@gnu.org>
365
366 * lisp.mk (lisp): Remove paths.elc.
367
c89926a5
CY
3682012-06-27 Chong Yidong <cyd@gnu.org>
369
370 * doc.c (Fsubstitute_command_keys): Fix punctuation.
371
ed6b3510
JW
3722012-06-26 John Wiegley <johnw@newartisans.com>
373
1ec4b7b2 374 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
375 on Mac OS X Lion: __mod_init_func and __mod_term_func.
376
ed6b3510
JW
377 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
378 when building with Clang.
379
8edd4a2b
SM
3802012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * eval.c (Fapply): Allow calling it with a single argument.
383
f6f62d1b
EZ
3842012-06-26 Eli Zaretskii <eliz@gnu.org>
385
386 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
387 _stricmp and _strnicmp.
388 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
389
62efea5e
DA
3902012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
391
392 * alloc.c (allocate_window): Zero out non-Lisp part of newly
393 allocated window.
394 (allocate_process): Likewise for new process.
8edd4a2b 395 (allocate_terminal): Change to use offsetof.
62efea5e
DA
396 (allocate_frame): Likewise.
397 * frame.c (make_frame): Omit redundant initialization.
398 * window.c (make_parent_window): Use memset.
399 (make_window): Omit redundant initialization.
400 * process.c (make_process): Omit redundant initialization.
401 * terminal.c (create_terminal): Likewise.
402
42997f4d
DA
4032012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
404
405 * term.c (delete_tty): Remove redundant call to memset.
406
1130ecfc
DA
4072012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
408
409 * alloc.c: Remove build_string.
410 * lisp.h: Define build_string as static inline. This provides
411 a better opportunity to optimize away calls to strlen when the
412 function is called with compile-time constant argument.
413 * image.c (imagemagick_error): Convert to build_string.
414 * w32proc.c (sys_spawnve): Likewise.
415 * xterm.c (x_term_init): Likewise.
416
cf38a720
PE
4172012-06-26 Paul Eggert <eggert@cs.ucla.edu>
418
99027bdd
PE
419 Use sprintf return value instead of invoking strlen on result.
420 In the old days this wasn't portable, since some sprintf
421 implementations returned char *. But they died out years ago and
422 Emacs already assumes sprintf returns int.
423 Similarly for float_to_string.
424 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
425 * ccl.c (ccl_driver):
426 * character.c (string_escape_byte8):
427 * data.c (Fnumber_to_string):
428 * doprnt.c (doprnt):
429 * print.c (print_object):
430 * xdisp.c (message_dolog):
431 * xfns.c (syms_of_xfns):
432 Use sprintf or float_to_string result to avoid need to call strlen.
433 * data.c (Fnumber_to_string):
434 Use make_unibyte_string, since the string must be ASCII.
435 * lisp.h, print.c (float_to_string): Now returns int length.
436 * term.c (produce_glyphless_glyph):
437 Use sprintf result rather than recomputing it.
438
cf38a720
PE
439 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
440 * Makefile.in (ALL_CFLAGS):
441 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
442 * gmalloc.c, regex.c: Include <config.h> unconditionally.
443
3511c784
DA
4442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
445
0a08eb21 446 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
447 strcasecmp if available.
448 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
449
fb7da12e
AS
4502012-06-25 Andreas Schwab <schwab@linux-m68k.org>
451
452 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
453 Avoid comma operator.
454 * menu.c (push_submenu_start, push_submenu_end)
455 (push_left_right_boundary, push_menu_pane): Likewise.
456 * msdos.c (dos_rawgetc): Likewise.
457
afa2ffd8
DA
4582012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
459
460 * xfns.c (xic_create_fontsetname): Remove redundant calls
461 to memset.
462
b3b4476b
PE
4632012-06-25 Paul Eggert <eggert@cs.ucla.edu>
464
4495ff38
PE
465 * gtkutil.c (get_utf8_string): Remove redundant assignment.
466 sprintf already null-terminates its output.
467
b3b4476b
PE
468 * xfns.c (x_window): Remove redundant cast.
469
b00876c9
DA
4702012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
471
472 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
473 `const char *' to `char *' to avoid compiler warning.
474
d188e26b
PE
4752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
476
885d1d74
PE
477 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
478 instead of truncating it to 63 (admittedly a generous limit).
479
d188e26b
PE
480 * process.c: Fix spelling and caps in comments.
481
e2f560b1
DN
4822012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
483
e86db54b 484 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
485 * sysdep.c (setpgrp): Remove definition, not used in this file.
486
7583a3a1
JB
4872012-06-24 Juanma Barranquero <lekktu@gmail.com>
488
489 * makefile.w32-in: Update dependencies.
490
696056c2
EZ
4912012-06-24 Eli Zaretskii <eliz@gnu.org>
492
493 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
494 (SYSTIME_H): Add nt/inc/sys/time.h.
495
496 * systime.h [WINDOWSNT]: Include sys/time.h.
497
498 * s/ms-w32.h (struct timespec): Definition moved from
499 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
500
845ca893
PE
5012012-06-24 Paul Eggert <eggert@cs.ucla.edu>
502
503 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
504 * buffer.h (buffer_slot_type_mismatch):
505 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
506 * eval.c (unwind_to_catch):
507 * image.c (my_png_error, my_error_exit):
508 * keyboard.c (quit_throw_to_read_char, user_error)
509 (Fexit_recursive_edit, Fabort_recursive_edit):
510 * lisp.h (die, args_out_of_range, args_out_of_range_3)
511 (wrong_type_argument, buffer_overflow, __executable_start)
512 (memory_full, buffer_memory_full, string_overflow, Fthrow)
513 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
514 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
515 (fatal):
516 (child_setup) [!DOS_NT]:
517 * lread.c (end_of_file_error, invalid_syntax):
518 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
519 * puresize.h (pure_write_error):
520 * search.c (matcher_overflow):
521 * sound.c (sound_perror, alsa_sound_perror):
522 * sysdep.c, syssignal.h (croak):
523 * term.c (maybe_fatal, vfatal):
524 * textprop.c (text_read_only):
525 * undo.c (user_error):
526 * unexmacosx.c (unexec_error):
527 * xterm.c (x_ins_del_lines, x_delete_glyphs):
528 Use _Noreturn rather than NO_RETURN.
529 No need for separate decl merely because of _Noreturn.
530 * sound.c (sound_warning, parse_sound):
531 Remove unnecessary forward decls.
532
f1dd8073
PE
5332012-06-24 Paul Eggert <eggert@cs.ucla.edu>
534
535 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
536 * lisp.h (WAIT_READING_MAX): New macro.
537 * dispnew.c (Fsleep_for, sit_for):
538 * keyboard.c (kbd_buffer_get_event):
539 * process.c (Faccept_process_output):
540 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
541 This improves on the previous patch, which introduced a bug
542 when time_t is unsigned and as wide as intmax_t.
543 See <http://bugs.gnu.org/9000#51>.
544
b82c1755
EZ
5452012-06-23 Eli Zaretskii <eliz@gnu.org>
546
547 * dispnew.c (sit_for, Fsleep_for):
548 * keyboard.c (kbd_buffer_get_event):
549 * process.c (Faccept_process_output): Avoid compiler warnings when
550 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
551
ca300656
JB
5522012-06-23 Juanma Barranquero <lekktu@gmail.com>
553
049ec95b
JB
554 * makefile.w32-in: Update dependencies.
555
ca300656
JB
556 * w32.c (ltime): Add return type and declare static.
557 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
558
db7b8d06
PE
5592012-06-23 Paul Eggert <eggert@cs.ucla.edu>
560
561 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
562 Privately reported by Herbert J. Skuhra.
563 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
564 All uses changed.
565 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
566 not make_lisp_timeval, when the argument is of type EMACS_TIME.
567
0bd8297f
EZ
5682012-06-23 Eli Zaretskii <eliz@gnu.org>
569
96512555
EZ
570 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
571 last argument of make_unibyte_string.
572
0bd8297f
EZ
573 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
574 language ID in the event parameters.
575
576 * w32term.c (w32_read_socket): Put the new keyboard codepage into
577 event.code, not the obscure "character set ID".
578
63def6b6
CY
5792012-06-23 Chong Yidong <cyd@gnu.org>
580
581 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
582
e8a02204
EZ
5832012-06-23 Eli Zaretskii <eliz@gnu.org>
584
388cdec0
EZ
585 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
586 * w32.c (fdutimens): New function.
587
588 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
589
590 * s/ms-w32.h (pselect): Redirect to sys_select.
591
592 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
593
e8a02204
EZ
594 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
595 in the logic of incrementing and decrementing the value of
596 use_relocatable_buffers.
597
d054f3fb
PE
5982012-06-23 Paul Eggert <eggert@cs.ucla.edu>
599
600 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
601 Privately reported by Herbert J. Skuhra.
602 [__FreeBSD__]: Remove "*/" typo after "#include".
603 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
604 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
605 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
606 Don't assume EMACS_TIME and struct timeval are the same type.
607
d35af63c
PE
6082012-06-22 Paul Eggert <eggert@cs.ucla.edu>
609
610 Support higher-resolution time stamps (Bug#9000).
611 The time stamps are only nanosecond-resolution at the C level,
612 since that's the best that any real-world system supports now.
613 But they are picosecond-resolution at the Lisp level, as that's
614 easy, and leaves room for future OS improvements.
615
616 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
617 (LIBES): Use it.
618
619 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
620 Don't get current time unless it's needed.
621
622 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
623 now provides it if it's absent.
624 (start_atimer): Port to higher-res time stamps.
625 Check for time stamp overflow. Don't get current time more
626 often than is needed.
627
628 * buffer.h (struct buffer): Buffer modtime now has high resolution.
629 Include systime.h, not time.h.
630 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
631
632 * dired.c: Include stat-time.h.
633 (Ffile-attributes): File times now have higher resolution.
634
635 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
636 (struct image): Timestamp now has higher resolution.
637
638 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
639 has at least microseconds now. All uses removed.
640 (update_frame, update_single_window, update_window, update_frame_1)
641 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
642
643 * editfns.c (time_overflow): Now extern.
644 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
645 (float-time, Fformat_time_string, Fcurrent_time_string)
646 (Fcurrent_time_zone): Accept and generate higher-resolution
647 time stamps.
648 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
649 (decode_time_components, lisp_seconds_argument): New functions.
650 (make_time): Now static.
651 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
652 Report an error if the time is invalid, rather than having the caller
653 do that.
654
655 * fileio.c: Include <stat-time.h>
656 (Fcopy_file): Copy higher-resolution time stamps.
657 Prefer to set the time stamp via a file descriptor if that works.
658 (Fset_file_times, Finsert_file_contents, Fwrite_region)
659 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
660 (Fvisited_file_modtime, Fset_visited_file_modtime):
661 Support higher-resolution time stamps.
662
663 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
664
665 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
666
667 * image.c (prepare_image_for_display, clear_image_cache)
668 (lookup_image): Port to higer-resolution time stamps.
669
670 * keyboard.c (start_polling, bind_polling_period):
671 Check for time stamp overflow.
672 (read_char, kbd_buffer_get_event, timer_start_idle)
673 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
674 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
675 Port to higher-resolution time stamps. Do not assume time_t is signed.
676 (decode_timer): New function. Timers are now vectors of length 9,
677 not 8, to accommodate the picosecond component.
678 (timer_check_2): Use it.
679
680 * nsterm.m (select_timeout, timeval_subtract): Remove.
681 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
682 as they're a bit more accurate and handle overflow better.
683 (ns_select): Change prototype to be compatible with pselect.
684 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
685 * nsterm.h (ns_select): Adjust prototype.
686
687 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
688 us-resolution time stamps.
689 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
690
691 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
692
693 * lisp.h (time_overflow): New decl.
694 (wait_reading_process_output): First arg is now intmax_t, not int,
695 to accommodate larger waits.
696
697 * process.h (struct Lisp_Process.read_output_delay):
698 Now counts nanoseconds, not microseconds.
699 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
700 EMACS_HAS_USECS.
701 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
702 (wait_reading_process_output):
703 Port to ns-resolution time stamps.
704 (Faccept_process_output, wait_reading_process_output):
705 Check for time stamp overflow. Do not assume time_t is signed.
706 (select_wrapper): Remove; we now use pselect.
707 (Fprocess_attributes): Now generates ns-resolution time stamps.
708
709 * sysdep.c: Include utimens.h. Don't include utime.h
710 or worry about struct utimbuf; gnulib does that for us now.
711 (gettimeofday): Remove; gnulib provides a substitute.
712 (make_timeval): New function.
713 (set_file_times): Now sets ns-resolution time stamps.
714 New arg FD; all uses changed.
715 (time_from_jiffies, ltime_from_jiffies, get_up_time)
716 (system_process_attributes):
717 Now returns ns-resolution time stamp. All uses changed.
718 Check for time stamp overflow.
719
720 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
721 provides a substitute now.
722
723 * systime.h: Include timespec.h rather than sys/time.h and time.h,
724 since it guarantees struct timespec.
725 (EMACS_TIME): Now struct timespec, so that we can support
726 ns-resolution time stamps.
727 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
728 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
729 (EMACS_USECS): Remove.
730 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
731 so multiply the arg by 1000 before storing it.
732 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
733 New macros.
734 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
735 Port to ns-resolution time stamps.
736 (EMACS_TIME_NEG_P): Remove; replaced by....
737 (EMACS_TIME_SIGN): New macro.
738 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
739 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
740 (set_file_times, make_time, lisp_time_argument): Adjust signature.
741 (make_timeval, make_lisp_time, decode_time_components): New decls.
742 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
743 that it mishandled time_t overflow. You can't compare by subtracting!
744 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
745 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
746
747 * term.c: Include <sys/time.h>.
748 (timeval_to_Time): New function, for proper overflow wraparound.
749 (term_mouse_position, term_mouse_click): Use it.
750
751 * undo.c (record_first_change): Support higher-resolution time stamps
752 in the undo buffer.
753 (Fprimitive_undo): Use them when restoring time stamps.
754
755 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
756 (w32_get_internal_run_time):
757 Port to higher-resolution Emacs time stamps.
758 (ltime): Now accepts single 64-bit integer, as that's more convenient
759 for callers.
760
761 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
762
763 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
764 for compatibility with pselect. Support ns-resolution time stamps.
765
766 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
767
768 * xselect.c (wait_for_property_change, x_get_foreign_selection):
769 Check for time stamp overflow, and support ns-resolution time stamps.
770
771 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
772 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
773 (timeval_subtract): Remove; no longer needed.
774 (XTflash, XTring_bell, x_wait_for_event):
775 Port to ns-resolution time stamps. Don't assume time_t is signed.
776
b6a92dfe
CY
7772012-06-22 Chong Yidong <cyd@gnu.org>
778
779 * xdisp.c (x_consider_frame_title): Revert last change.
780
d251c37c
EZ
7812012-06-22 Eli Zaretskii <eliz@gnu.org>
782
783 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
784 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
785 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
786 staticidx goes up to 1597 out of 1600 = 0x640.)
787
f10deafb
PE
7882012-06-20 Paul Eggert <eggert@cs.ucla.edu>
789
790 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
791 Otherwise, the umask might be mistakenly 0 while handling input signals.
792
ec6de1e2
SM
7932012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
794
795 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
796
28be1ada
DA
7972012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
798
799 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
800 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
801 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
802 access to `contents' member of Lisp_Vector objects with AREF and ASET
803 where appropriate.
804
c6bf3022
CY
8052012-06-19 Chong Yidong <cyd@gnu.org>
806
807 * frame.c (delete_frame): When selecting a frame on a different
808 text terminal, do not alter the terminal's top-frame.
809
810 * xdisp.c (format_mode_line_unwind_data): Record the target
811 frame's selected window and its terminal's top-frame.
812 (unwind_format_mode_line): Restore them.
813 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
814 Callers changed.
815 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
816 since tty frames can be explicitly named.
817 (prepare_menu_bars): Likewise.
818
819 * term.c (Ftty_top_frame): New function.
820
defd4196
PE
8212012-06-18 Paul Eggert <eggert@cs.ucla.edu>
822
823 Port byte-code-meter to modern targets.
824 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
825 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 826 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
827 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
828 (METER_1, METER_2): Simplify.
829
1053a871
SM
8302012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
831
832 * data.c (Fdefalias): Return `symbol' (bug#11686).
833
b7e8d081
MR
8342012-06-18 Martin Rudalics <rudalics@gmx.at>
835
836 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
837 gets killed during executing of this function (Bug#11665).
838 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
839 (Vkill_buffer_query_functions): In doc-string say that functions
840 run by this hook should not change the current buffer.
841
7ea2b339
PE
8422012-06-18 Paul Eggert <eggert@cs.ucla.edu>
843
844 Fix recently-introduced process.c problems found by static checking.
845 * process.c (write_queue_push, write_queue_pop, send_process):
846 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
847 (write_queue_pop): Fix pointer signedness problem.
848 (send_process): Remove unused local.
849
96a313a1
CY
8502012-06-17 Chong Yidong <cyd@gnu.org>
851
852 * xdisp.c (redisplay_internal): No need to redisplay terminal
853 frames that are not on top.
854
20ca2e94
TN
8552012-06-17 Troels Nielsen <bn.troels@gmail.com>
856
857 * process.c (make_process): Initialize write_queue.
858 (write_queue_push, write_queue_pop): New functions.
859 (send_process): Use them to maintain correct ordering of process
860 writes (Bug#10815).
861
9a900ca9
PE
8622012-06-17 Paul Eggert <eggert@cs.ucla.edu>
863
310fbfa8
PE
864 * lisp.h (eassert): Assume C89 or later.
865 This removes the need for CHECK.
866 (CHECK): Remove. Its comments about always evaluating its
867 argument were confusing, as 'eassert' typically does not evaluate
868 its argument.
869
27bb1ca4
PE
870 * coding.c (produce_chars): Use ptrdiff_t, not int.
871
9a900ca9
PE
872 * xterm.c (x_draw_underwave): Check for integer overflow.
873 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
874
41b7f8bc 8752012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
876
877 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
878 referenced (Bug#11583).
879
9b0e3eba
AA
8802012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
881
882 Implement wave-style variant of underlining.
883 * dispextern.h (face_underline_type): New enum.
884 (face): Add field for underline type.
885 * nsterm.m (ns_draw_underwave): New function.
886 (ns_draw_text_decoration): Use it.
887 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
888 New functions.
889 (x_draw_glyph_string): Use them.
890 * xfaces.c (Qline, Qwave): New Lisp objects.
891 (check_lface_attrs, merge_face_ref)
1053a871
SM
892 (Finternal_set_lisp_face_attribute, realize_x_face):
893 Handle wave-style underline face attributes.
9b0e3eba
AA
894 * xterm.c (x_draw_underwave): New function.
895 (x_draw_glyph_string): Use it.
896
0fb52f11
JB
8972012-06-16 Juanma Barranquero <lekktu@gmail.com>
898
899 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
900 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
901 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
902 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
903 ($(BLD)/w32select.$(O)): Update dependencies.
904
e5560ff7
AS
9052012-06-16 Andreas Schwab <schwab@linux-m68k.org>
906
907 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
908 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
909 * character.c (_fetch_multibyte_char_p): Remove.
910 * alloc.c: Include "character.h" before "buffer.h".
911 * bidi.c: Likewise.
912 * buffer.c: Likewise.
913 * bytecode.c: Likewise.
914 * callint.c: Likewise.
915 * callproc.c: Likewise.
916 * casefiddle.c: Likewise.
917 * casetab.c: Likewise.
918 * category.c: Likewise.
919 * cmds.c: Likewise.
920 * coding.c: Likewise.
921 * composite.c: Likewise.
922 * dired.c: Likewise.
923 * dispnew.c: Likewise.
924 * doc.c: Likewise.
925 * dosfns.c: Likewise.
926 * editfns.c: Likewise.
927 * emacs.c: Likewise.
928 * fileio.c: Likewise.
929 * filelock.c: Likewise.
930 * font.c: Likewise.
931 * fontset.c: Likewise.
932 * fringe.c: Likewise.
933 * indent.c: Likewise.
934 * insdel.c: Likewise.
935 * intervals.c: Likewise.
936 * keyboard.c: Likewise.
937 * keymap.c: Likewise.
938 * lread.c: Likewise.
939 * macros.c: Likewise.
940 * marker.c: Likewise.
941 * minibuf.c: Likewise.
942 * nsfns.m: Likewise.
943 * nsmenu.m: Likewise.
944 * print.c: Likewise.
945 * process.c: Likewise.
946 * regex.c: Likewise.
947 * region-cache.c: Likewise.
948 * search.c: Likewise.
949 * syntax.c: Likewise.
950 * term.c: Likewise.
951 * textprop.c: Likewise.
952 * undo.c: Likewise.
953 * unexsol.c: Likewise.
954 * w16select.c: Likewise.
955 * w32fns.c: Likewise.
956 * w32menu.c: Likewise.
957 * window.c: Likewise.
958 * xdisp.c: Likewise.
959 * xfns.c: Likewise.
960 * xmenu.c: Likewise.
961 * xml.c: Likewise.
962 * xselect.c: Likewise.
963
2f07e6af
EZ
9642012-06-16 Eli Zaretskii <eliz@gnu.org>
965
1053a871
SM
966 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
967 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 968 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
969 row.
970 (handle_face_prop): Use chunk-relative overlay string index when
971 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
972 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
973 the rightmost. (Bug#11720)
2f07e6af 974
29b83cec
AS
9752012-06-16 Andreas Schwab <schwab@linux-m68k.org>
976
977 * category.h (CHAR_HAS_CATEGORY): Define as inline.
978 (CATEGORY_MEMBER): Enforce 1/0 value.
979 * category.c (_temp_category_set): Remove.
980
4c5501e9
EZ
9812012-06-16 Eli Zaretskii <eliz@gnu.org>
982
983 * window.c (Fdelete_other_windows_internal)
984 (Fdelete_window_internal): Don't access frame's mouse highlight
985 info of the initial frame. (Bug#11677)
986
2b570124
PE
9872012-06-14 Paul Eggert <eggert@cs.ucla.edu>
988
e93864f9
PE
989 * .gdbinit (xgetint): Fix recently-introduced paren typo.
990 Assume USE_2_TAGS_FOR_INTS.
991 (xreload): Adjust $tagmask width to match recent lisp.h change.
992
2b570124
PE
993 Simplify lisp.h in minor ways that should not affect code.
994 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
995 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
996 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
997 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
998 (INTTYPEBITS): New macro, for clarity.
999 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1000 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1001 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1002 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1003 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1004
81755f69
JB
10052012-06-13 Juanma Barranquero <lekktu@gmail.com>
1006
1007 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1008
16192a57
GM
10092012-06-13 Glenn Morris <rgm@gnu.org>
1010
1011 * s/bsd-common.h (BSD4_3):
1012 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1013
646b5f55
AS
10142012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1015
1016 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1017 instead of union.
1018 (XLI, XIL): Define.
1053a871
SM
1019 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1020 Use them.
1021 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1022 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1023 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1024 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1025 * frame.c (delete_frame): Remove outdated comment.
1026 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1027 USE_LISP_UNION_TYPE.
1028 (Fw32_unregister_hot_key): Likewise.
1029 (Fw32_toggle_lock_key): Likewise.
1030 * w32menu.c (add_menu_item): Likewise.
1031 (w32_menu_display_help): Use XIL instead of checking
1032 USE_LISP_UNION_TYPE.
1033 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1034 (init_heap): Likewise.
1035 * w32term.c (w32_read_socket): Update comment.
1036
1d3823c9
GM
10372012-06-13 Glenn Morris <rgm@gnu.org>
1038
c62ff706
GM
1039 * s/usg5-4-common.h, src/s/unixware.h:
1040 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1041
1d3823c9
GM
1042 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1043
bfe3e0a2
PE
10442012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1047 * alloc.c (make_number) [!defined make_number]:
1048 Remove, as lisp.h always defines this now.
1049 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1050 (roundup_size): Verify that it is a power of 2.
1051 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1052 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1053 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1054 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1055 USE_LSB_TAG now is always defined to be either 0 or 1.
1056 All uses changed.
1057 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1058 code works fine either way, and efficiency is not a concern here,
1059 as the union type is for debugging, not for production.
1060 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1061 Use an inline function on all platforms when using the union type,
1062 since this is simpler and 'static inline' can be used portably
1063 within Emacs now.
1064 (LISP_INITIALLY_ZERO): New macro.
1065 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1066 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1067
45fa9c0f
GM
10682012-06-12 Glenn Morris <rgm@gnu.org>
1069
b4492cba
GM
1070 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1071
1072 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1073
45fa9c0f
GM
1074 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1075 Move BROKEN_SIGIO to configure.
1076
1077 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1078 Move NO_TERMIO to configure.
1079
0e25d334
CY
10802012-06-12 Chong Yidong <cyd@gnu.org>
1081
1082 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1083 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1084 MagickExportImagePixels is undefined.
1085
43682bb6
PE
10862012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * image.c (imagemagick_load_image): Remove unused label.
1089
a9be7d2b
GM
10902012-06-11 Glenn Morris <rgm@gnu.org>
1091
1092 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1093 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1094 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1095 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1096
3017f87f
SM
10972012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1098
1099 * alloc.c (make_byte_code): New function.
1100 (Fmake_byte_code): Use it. Don't purify here.
1101 * lread.c (read1): Use it as well to avoid extra allocation.
1102
1b9b4cf4
CY
11032012-06-11 Chong Yidong <cyd@gnu.org>
1104
1105 * image.c (imagemagick_load_image): Implement transparency.
1106
95988fcf
AS
11072012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1108
1109 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1110 account for preceding backslashes. (Bug#11663)
1111
cd4eb164
CY
11122012-06-09 Chong Yidong <cyd@gnu.org>
1113
1114 * term.c: Support italics in capable terminals (Bug#9652).
1115 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1116 (turn_on_face): Output using TS_enter_italic_mode if available.
1117 Don't handle unused blinking and alt-charset cases.
1118 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1119 and tty_alt_charset_p cases.
1120 (tty_capable_p, init_tty): Support italics.
1121
1122 * termchar.h (struct tty_display_info): Add field for italics.
1123 Remove unused blink field.
1124
1125 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1126 Handle slant.
1127
1128 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1129 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1130 tty_alt_charset_p. Add tty_italic_p.
1131
ff88beb8
MA
11322012-06-09 Michael Albinus <michael.albinus@gmx.de>
1133
1134 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1135 dbus_type_is_basic if available.
1136 (xd_extract_signed, xd_extract_unsigned): Rename from
1137 extract_signed and extract_unsigned, respectively. Adapt callers.
1138
44286096
CY
11392012-06-09 Chong Yidong <cyd@gnu.org>
1140
1682701f
CY
1141 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1142
44286096
CY
1143 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1144 case (Bug#9752).
1145
d86feb17
PE
11462012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * xdisp.c (vmessage): Treat frame message as multibyte.
1149 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1150 would generate the diagnostic "Making \302\247 buffer-local while
1151 let-bound!".
1152
d5c20fe8
EZ
11532012-06-08 Eli Zaretskii <eliz@gnu.org>
1154
1155 * dispnew.c (showing_window_margins_p): Undo last change, which
1156 was done due to an inadvertent commit.
1157 (adjust_frame_glyphs_for_frame_redisplay): Do call
1158 showing_window_margins_p.
1159
513749ee
SM
11602012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * eval.c (Fmake_var_non_special): New primitive.
1163 (syms_of_eval): Defsubr it.
1164 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1165
d4a8f5c1
JB
11662012-06-08 Juanma Barranquero <lekktu@gmail.com>
1167
1168 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1169 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1170
8bbbc977
EZ
11712012-06-08 Eli Zaretskii <eliz@gnu.org>
1172
1173 * alloc.c (allocate_vectorlike): Fix last change.
1174
f3372c87
DA
11752012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1176
1177 Block-based vector allocation of small vectors.
1178 * lisp.h (struct vectorlike_header): New field `nbytes',
1179 adjust comment accordingly.
1180 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1181 to denote vector blocks. Adjust users (live_vector_p,
1182 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1183 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1184 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1185 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1186 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1187 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1188 (roundup_size): New constant.
1189 (struct vector_block): New data type.
1190 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1191 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1192 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1193 (sweep_vectors): New functions.
1194 (allocate_vectorlike): Return `zero_vector' as the only vector of
1195 0 items. Allocate new vector from block if vector size is less than
1196 or equal to VBLOCK_BYTES_MAX.
1197 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1198 (init_alloc_once): Add call to init_vectors.
1199
4f18a4ed
SM
12002012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1201
1202 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1203
86f158bc
PE
12042012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 * doprnt.c (doprnt): Truncate multibyte char correctly.
1207 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1208 would mishandle a string argument "Xc" if X was a multibyte
1209 character of length 2: it would truncate after X's first byte
1210 rather than including all of X.
1211
c5cfcbe0
CY
12122012-06-06 Chong Yidong <cyd@gnu.org>
1213
1214 * buffer.c (word_wrap): Doc fix.
1215
c05cf390
PE
12162012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1219
0c3461de
GM
12202012-06-03 Glenn Morris <rgm@gnu.org>
1221
1222 * xdisp.c (tool-bar-style): Doc fix.
1223
c71232db
UM
12242012-06-03 Ulrich Müller <ulm@gentoo.org>
1225
1226 * Makefile.in (PAXCTL): Define.
1227 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1228 binary via PaX flags if the paxctl utility is available.
1229 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1230 Restore PaX flags to their default. (Bug#11398)
1231
383f7350
CY
12322012-06-03 Chong Yidong <cyd@gnu.org>
1233
1234 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1235 buffer (Bug#11226).
1236
5f2c76c6
CY
12372012-06-03 Chong Yidong <cyd@gnu.org>
1238
1239 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1240 (note_mode_line_or_margin_highlight): If there is no help echo,
1241 use mode-line-default-help-echo. Handle the case where the mouse
1242 position is past the end of the mode line string.
1243
1244 * buffer.c (buffer_local_value_1): New function, split from
1245 Fbuffer_local_value; can return Qunbound.
1246 (Fbuffer_local_value): Use it.
1247 (Vmode_line_format): Docstring tweaks.
1248
773d47f6
PE
12492012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 * sysdep.c (system_process_attributes): Improve comment.
1252
f2d6a3df
SM
12532012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1254
1255 * keyboard.c: Export real-this-command to Elisp.
1256 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1257 and DEFVAR it. Update all users.
1258
63810350
PE
12592012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1260
7bd5c1f4
PE
1261 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1262
63810350
PE
1263 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1264 Convert pctcpu and pctmem to Lisp float properly.
1265 Let the compiler fold better, as 100.0/0x8000 is exact.
1266
a2821611
AS
12672012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1268
1269 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1270 cons_block.
1271
5fceba1d
PE
12722012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1275
c98ff5dd
DA
12762012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1277
1278 For a 'struct window', replace some Lisp_Object fields to
1279 bitfields where appropriate, remove unused fields.
1280 * window.h (struct window): Remove unused 'last_mark_x' and
1281 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1282 change it's type from Lisp_Object to bitfield.
1283 Change type of 'force_start', 'optional_new_start',
1284 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1285 fields from Lisp_Object to bitfield. Adjust users accordingly.
1286
ca34e0be
PE
12872012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 Pacify gcc -Wdouble-precision when using Xaw.
1290 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1291 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1292 Use 'float' consistently, rather than 'float' in most places
1293 and 'double' in a couple of places.
1294
efc00ab1 12952012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1296
1297 * xdisp.c (handle_stop): Detect whether we have overlay strings
1298 loaded by testing it->current.overlay_string_index to be
1299 non-negative, instead of checking whether n_overlay_strings is
1300 positive. (Bug#11587)
1301
efc00ab1 13022012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1303
1304 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1305
1306 * doc.c (Fsubstitute_command_keys): Doc fix.
1307
efc00ab1 13082012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1309
1310 * search.c (search_buffer): Remove calls to
1311 r_alloc_inhibit_buffer_relocation, as it is now called by
1312 maybe_unify_char, which was the cause of relocation of buffer text
1313 in bug#11519.
1314
efc00ab1 13152012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1316
1317 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1318 for the duration of call to load_charset, to avoid problems with
1319 callers of maybe_unify_char that access buffer text through C
1320 pointers.
1321
1322 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1323 decrement the inhibition flag, instead of just setting or
1324 resetting it.
1325
ba93a187
PE
13262012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 Remove obsolete '#define static' cruft.
1329 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1330 This #undef was "temporary" in 2000; it is no longer needed
1331 now that '#define static' has gone away.
1332 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1333 (gray_bitmap_bits): Remove; no longer needed.
1334 All uses replaced with definiens.
1335 * xterm.c: Include "bitmaps/gray.xbm".
1336
9e4bf381
PE
13372012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1338
1339 Clean up __executable_start, monstartup when --enable-profiling.
1340 The following changes affect the code only when profiling.
1341 * dispnew.c (__executable_start): Rename from safe_bcopy.
1342 Define only on platforms that need it.
1343 * emacs.c: Include <sys/gmon.h> when profiling.
1344 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1345 (__executable_start): Remove decl, since lisp.h does it now.
1346 (safe_bcopy): Remove decl; no longer has that name.
1347 (main): Coalesce #if into single bit of code, for simplicity.
1348 Cast pointers to uintptr_t, since standard libraries want integers
1349 and not pointers.
1350 * lisp.h (__executable_start): New decl.
1351
32d72c2f
GM
13522012-05-31 Glenn Morris <rgm@gnu.org>
1353
1354 * image.c (Fimagemagick_types): Doc fix.
1355
baac5bc7
JM
13562012-05-30 Jim Meyering <meyering@redhat.com>
1357
1358 * callproc.c (Fcall_process_region): Include directory component
1359 in mkstemp error message (Bug#11586).
1360
72cb32cf
PE
13612012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 * alloc.c, lisp.h (make_pure_vector): Now static.
1364
61b108cc
SM
13652012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1368 Move to byte-run.el.
1369 (Fautoload): Do the hash-doc more carefully.
1370 * data.c (Fdefalias): Purify definition, except for keymaps.
1371 (Qdefun): Move from eval.c.
1372 * lisp.h (Qdefun): Remove.
1373 * lread.c (read1): Tiny simplification.
1374
471fe23d
TN
13752012-05-29 Troels Nielsen <bn.troels@gmail.com>
1376
934f3f58 1377 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1378 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1379 Bug#9642, but explicitly check that the buffer the overlay would
1380 be moved to is live and rearrange lines to make sure that errors
1381 will not put the overlay in an inconsistent state.
1382 (Fdelete_overlay): Cosmetics.
1383
85d0efd1
EZ
13842012-05-28 Eli Zaretskii <eliz@gnu.org>
1385
1386 * w32term.c (my_bring_window_to_top): New function.
1387 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1388 could be different from the original one.
1389 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1390 (Bug#11513)
1391
1392 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1393 by calling BringWindowToTop.
1394
1395 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1396 (WM_EMACS_END): Increase by one.
1397
da92a98c
PE
13982012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1401 This avoids undefined behavior that might cause the eassert
1402 to not catch an out-of-range value.
1403
74d1f848
JB
14042012-05-28 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1407 Update dependencies.
1408
9e1a06fc
EZ
14092012-05-27 Eli Zaretskii <eliz@gnu.org>
1410
1411 * bidi.c (bidi_mirror_char): Fix last change.
1412
f3dd7312
AS
14132012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1414
1415 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1416 when referring to sectname field in printf format.
1417
81899c91
PE
14182012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1419
57b81a9f
PE
1420 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1421 Only r_alloc_inhibit_buffer_relocation needed to be added;
1422 the others were already declared.
1423
81899c91
PE
1424 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1425 before checking whether it's out of range. Put the check inside
1426 eassert. See
1427 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1428
33017faf 14292012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1430
1431 * callproc.c (Fcall_process): Restore a line that was accidentally
1432 commented out in the 2011-02-13 change (bug#11547).
1433
33017faf 14342012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1435
1436 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1437 defined on ralloc.c.
1438
1439 * buffer.c [REL_ALLOC]: Remove prototypes of
1440 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1441 they are now on lisp.h.
1442
1443 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1444
1445 * search.c (search_buffer): Use it to inhibit relocation of buffer
1446 text while re_search_2 is doing its job, because re_search_2 is
1447 passed C pointers to buffer text. (Bug#11519)
1448
23415acf
EZ
1449 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1450 Update value to 24.
1451
44e27368
EZ
1452 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1453 state after an additional call to move_it_in_display_line_to, keep
1454 the values of it->max_ascent and it->max_descent found for the
1455 entire line.
1456 (pos_visible_p): Revert the comparison against bottom_y to what it
1457 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1458 (Bug#11464)
1459
c1892f11
PE
14602012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 Fix coding-related core dumps with gcc -ftrapv.
1463 The code was computing A - B, where A and B are pointers, and B is
1464 random garbage. This can lead to core dumps on platforms that
1465 have special pointer registers, and it also leads to core dumps on
1466 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1467 A - B only when B is initialized properly.
1468 * coding.c (coding_set_source, coding_set_destination): Return void.
1469 (coding_change_source, coding_change_destinations): New functions,
1470 with the old behaviors of coding_set_source and coding_set_destination.
1471 All callers that need an offset changed to use these new functions.
1472
eb7afdad
GM
14732012-05-26 Glenn Morris <rgm@gnu.org>
1474
1475 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1476
f12fdf02
EZ
14772012-05-26 Eli Zaretskii <eliz@gnu.org>
1478
53a63be6 1479 Extend mouse support on W32 text-mode console.
61b108cc
SM
1480 * xdisp.c (draw_row_with_mouse_face):
1481 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1482
eb3f6f01 1483 * w32console.c: Include window.h.
61b108cc
SM
1484 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1485 New functions.
eb3f6f01
EZ
1486 (initialize_w32_display): Initialize mouse-highlight data.
1487
53a63be6
EZ
1488 * w32inevt.c: Include termchar.h and window.h.
1489 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1490 moves, call note_mouse_highlight. If help_echo changed, call
1491 gen_help_event to produce help-echo message in the echo area.
1492 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1493 highlight info.
1494
4cfd81f6
PE
14952012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1496
1497 * lread.c (read1): Simplify slightly to avoid an overflow warning
1498 with GCC 4.7.0 on x86-64.
1499
4446092a
EZ
15002012-05-26 Eli Zaretskii <eliz@gnu.org>
1501
1502 * bidi.c (bidi_mirror_char): Revert last change: an int is
1503 definitely wide enough here.
1504
42b2a986 15052012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1506
42b2a986 1507 Fix integer width and related bugs (Bug#9874).
eb106a49 1508 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1509 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1510 (string_bytes, check_sblock, allocate_string_data):
1511 (compact_small_strings, Fmake_bool_vector, make_string)
1512 (make_unibyte_string, make_multibyte_string)
1513 (make_string_from_bytes, make_specified_string)
1514 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1515 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1516 (mark_vectorlike):
1517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1518 (allocate_pseudovector):
1519 Use int, not EMACS_INT, where int is wide enough.
1520 (inhibit_garbage_collection, Fgarbage_collect):
1521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1522 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1523 int might not be wide enough.
1524 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1525 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1526 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1527 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1528 (bidi_level_of_next_char, bidi_move_to_visually_next):
1529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1530 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1531 (Fkill_buffer, Fset_buffer_major_mode)
1532 (advance_to_char_boundary, Fbuffer_swap_text)
1533 (Fset_buffer_multibyte, overlays_at, overlays_in)
1534 (overlay_touches_p, struct sortvec, record_overlay_string)
1535 (overlay_strings, recenter_overlay_lists)
1536 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1537 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1538 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1539 (Foverlay_recenter, last_overlay_modification_hooks_used)
1540 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1542 (validate_region): Omit unnecessary test for b <= e,
1543 since that's guaranteed by the previous test.
d311d28c
PE
1544 (adjust_overlays_for_delete): Avoid pos + length overflow.
1545 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1546 (report_overlay_modification):
1547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1548 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1549 Omit pointer cast, which isn't needed anyway, and doesn't work
1550 after the EMACS_INT -> ptrdiff_t change.
02481186 1551 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1552 * buffer.h: Adjust decls to match defn changes elsewhere.
1553 (struct buffer_text, struct buffer):
1554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1555 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1556 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1557 not int, to avoid needless 32-bit limit on 64-bit hosts.
1558 (exec_byte_code): Use tighter memory-full test, one that checks
1559 for alloca overflow. Don't compute the address of the object just
1560 before an array, as that's not portable. Use EMACS_INT, not
1561 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1562 * callint.c (Fcall_interactively):
1563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1564 * callproc.c (call_process_kill, Fcall_process):
1565 Don't assume pid_t fits into an Emacs fixnum.
1566 (call_process_cleanup, Fcall_process, child_setup):
1567 Don't assume pid_t fits into int.
1568 (call_process_cleanup, Fcall_process, delete_temp_file)
1569 (Fcall_process_region):
1570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1571 (Fcall_process): Simplify handling of volatile integers.
1572 Use int, not EMACS_INT, where int will do.
1573 * casefiddle.c (casify_object, casify_region, operate_on_word)
1574 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 (casify_object): Avoid integer overflow when overallocating buffer.
1577 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1578 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1579 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1580 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1581 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1582 integers are now checked earlier. All uses replaced with XINT.
1583 (ccl_driver):
1584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1585 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1586 (ccl_driver, Fregister_code_conversion_map):
1587 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1588 (resolve_symbol_ccl_program): Check that vector header is in range.
1589 Always copy the vector, so that we can check its contents reliably
1590 now rather than having to recheck each instruction as it's being
1591 executed. Check that vector words fit in 'int'.
1592 (ccl_get_compiled_code, Fregister_ccl_program)
1593 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1594 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1595 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1596 contents are in range.
1597 (Fccl_execute_on_string): Check that status is in range.
1598 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1599 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1600 Accept and return EMACS_INT, not int, because callers can pass values
1601 out of 'int' range.
1602 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1603 (multibyte_chars_in_text, parse_str_as_multibyte)
1604 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1605 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1606 (string_escape_byte8, Fget_byte):
1607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1608 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1609 avoid mishandling large integers.
1610 * character.h: Adjust decls to match defn changes elsewhere.
1611 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1612 (Ffind_charset_region):
1613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1614 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1615 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1616 Don't assume fixnum fits in int.
d311d28c
PE
1617 (load_charset_map_from_vector, Fmap_charset_chars):
1618 Remove now-unnecessary CHECK_NATNUMs.
1619 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1620 Don't rely on undefined behavior with signed left shift overflow.
1621 Don't assume unsigned int fits into fixnum, or that fixnum fits
1622 into unsigned int. Don't require max_code to be a valid fixnum;
1623 that's not true for gb10830 4-byte on a 32-bit host. Allow
1624 invalid_code to be a cons, for the same reason. Require code_offset
1625 to be a character. Avoid int overflow if max_char is close
1626 to INT_MAX.
1627 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1628 this is intended anyway and avoids some undefined behavior.
1629 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1630 INDEX_TO_CODE_POINT, as that's what it expects.
1631 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1632 * charset.h (DECODE_CHAR): Return int, not unsigned;
1633 this is what was intended anyway, and it avoids undefined behavior.
1634 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1635 integer-overflow issues.
1636 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1637 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1638 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1639 * chartab.c (Fmake_char_table, Fset_char_table_range)
1640 (uniprop_get_decoder, uniprop_get_encoder):
1641 Don't assume fixnum fits in int.
1642 * cmds.c (move_point): New function, that does the gist of
1643 Fforward_char and Fbackward_char, but does so while checking
1644 for integer overflow more accurately.
c96e5d6a 1645 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1646 (Fforward_line, Fend_of_line, internal_self_insert)
1647 (internal_self_insert):
1648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1649 Fix a FIXME, by checking for integer overflow when calculating
1650 target_clm and actual_clm.
1651 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1652 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1653 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1654 (coding_alloc_by_making_gap, alloc_destination)
1655 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1656 (encode_coding_utf_16, detect_coding_emacs_mule)
1657 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1658 (detect_coding_iso_2022, decode_coding_iso_2022)
1659 (encode_invocation_designation, encode_designation_at_bol)
1660 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1661 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1662 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1663 (encode_coding_ccl, encode_coding_raw_text)
1664 (detect_coding_charset, decode_coding_charset)
1665 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1666 (produce_composition, produce_charset, produce_annotation)
1667 (decode_coding, handle_composition_annotation)
1668 (handle_charset_annotation, consume_chars, decode_coding_gap)
1669 (decode_coding_object, encode_coding_object, detect_coding_system)
1670 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1671 (code_convert_region, code_convert_string)
8f50130c
PE
1672 (Fdefine_coding_system_internal)
1673 (coding_set_source, coding_set_destination):
d311d28c
PE
1674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1675 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1676 (Fdefine_coding_system_internal):
1677 Don't assume fixnums fit in int.
1678 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1679 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1680 (Funencodable_char_position, Fcheck_coding_systems_region)
1681 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1683 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1684 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1685 Don't access memory outside of the args array.
d311d28c 1686 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1687 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1688 result of ENCODE_CHAR.
d311d28c
PE
1689 * coding.h: Adjust decls to match defn changes elsewhere.
1690 (struct coding_system):
1691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1692 * composite.c (get_composition_id, find_composition)
1693 (run_composition_function, update_compositions)
1694 (compose_text, composition_gstring_put_cache)
1695 (composition_gstring_p, composition_gstring_width)
1696 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1697 (composition_compute_stop_pos, composition_reseat_it)
1698 (composition_update_it, struct position_record)
1699 (find_automatic_composition, composition_adjust_point)
1700 (Fcomposition_get_gstring, Ffind_composition_internal):
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 (update_compositions):
1703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1704 * composite.h: Adjust decls to match defn changes elsewhere.
1705 (struct composition):
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1707 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1708 Do not attempt to compute the address of the object just before a
1709 buffer; this is not portable.
1710 (Faref, Faset):
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 (Faset): Use int, not EMACS_INT, where int is wide enough.
1713 (Fstring_to_number): Don't assume fixnums fit in int.
1714 (Frem): Don't assume arg is nonnegative.
1715 * dbusbind.c (xd_append_arg): Check for integers out of range.
1716 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1717 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1718 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1719 (xd_get_connection_references): Return ptrdiff_t, not int.
1720 All uses changed.
1721 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1722 (xd_read_message_1):
1723 Use int, not unsigned, where the dbus API uses int.
1724 (Fdbus_message_internal): Don't overflow mtype.
1725 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1726 * dired.c (directory_files_internal, file_name_completion, scmp)
1727 (file_name_completion_stat):
1728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1729 (file_name_completion): Don't overflow matchcount.
1730 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1731 * dispextern.h: Adjust decls to match defn changes elsewhere.
1732 (struct text_pos, struct glyph, struct bidi_saved_info)
1733 (struct bidi_string_data, struct bidi_it, struct composition_it)
1734 (struct it):
1735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1736 (struct display_pos, struct composition_it, struct it):
1737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1738 * dispnew.c (increment_matrix_positions)
1739 (increment_row_positions, mode_line_string)
1740 (marginal_area_string):
1741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1742 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1744 (duration_to_sec_usec): New function, to check for overflow better.
1745 (Fsleep_for, sit_for): Use it.
1746 * doc.c (get_doc_string, store_function_docstring):
1747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1748 (get_doc_string, Fsnarf_documentation):
1749 Use int, not EMACS_INT, where int is wide enough.
1750 (get_doc_string):
1751 Use SAFE_ALLOCA, not alloca.
1752 Check for overflow when converting EMACS_INT to off_t.
1753 * doprnt.c (doprnt):
1754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1755 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1756 Don't assume uid_t fits into fixnum.
1757 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1758 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1759 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1760 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1761 (general_insert_function)
1762 (Finsert_char, make_buffer_string, make_buffer_string_both)
1763 (update_buffer_properties, Fbuffer_substring)
1764 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1765 (Fsubst_char_in_region, check_translation)
1766 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1767 (transpose_markers, Ftranspose_regions):
1768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1769 (clip_to_bounds): Move to lisp.h as an inline function).
1770 (Fconstrain_to_field): Don't assume integers are nonnegative.
1771 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1772 (Fsubst_char_in_region, Fsave_restriction):
1773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1774 (Femacs_pid): Don't assume pid_t fits into fixnum.
1775 (lo_time): Use int, not EMACS_INT, when int suffices.
1776 (lisp_time_argument): Check for usec out of range.
1777 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1778 (Fuser_login_name, Fuser_full_name): Signal an error
1779 if a uid argument is out of range, rather than relying on
1780 undefined behavior.
c8d5c857
PE
1781 (Fformat_time_string): Remove now-unnecessary check.
1782 lisp_time_argument checks for out-of-range usec now.
243e0530 1783 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1784 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1785 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1786 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1787 (init_cmdargs, Fdump_emacs):
1788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1789 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1790 the bottom (typically) 32 bits of the fixnum.
1791 * eval.c (specpdl_size, call_debugger):
1792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1793 (when_entered_debugger, Fbacktrace_debug):
1794 Don't assume fixnum can fit in int.
1795 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1796 the object just before a buffer; this is not portable.
1797 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1798 (grow_specpdl, unbind_to):
1799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1800 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1801 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1802 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1803 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1804 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1806 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1807 (a_write, e_write):
1808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1809 (Fcopy_file, non_regular_nbytes, read_non_regular)
1810 (Finsert_file_contents):
1811 Use int, not EMACS_INT, where int is wide enough.
1812 (READ_BUF_SIZE): Verify that it fits in int.
1813 (Finsert_file_contents): Check that counts are in proper range,
1814 rather than assuming fixnums fit into ptrdiff_t etc.
1815 Don't assume fixnums fit into int.
125b3835 1816 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1817 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1818 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1819 (string_char_to_byte, string_byte_to_char)
1820 (string_make_multibyte, string_to_multibyte)
1821 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1822 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1823 (substring_both, Fdelete, internal_equal, Ffillarray)
1824 (Fclear_string, mapcar1)
1825 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1826 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1827 (larger_vector, make_hash_table, maybe_resize_hash_table)
1828 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1829 (Fmaphash, secure_hash):
1830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1831 (concat): Check for string index and length overflow.
1832 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1833 (Frequire):
1834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1835 (larger_vector): New API (vec, incr_min, size_max) replaces old
1836 one (vec, new_size, init). This catches size overflow.
1837 INIT was removed because it was always Qnil.
1838 All callers changed.
1839 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1840 the upper bound on a hash table index size.
1841 (make_hash_table, maybe_resize_hash_table): Use it.
1842 (secure_hash): Computer start_byte and end_byte only after
1843 they're known to be in ptrdiff_t range.
1844 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1845 (Ffont_get_glyphs, Ffont_at):
1846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1847 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1848 (Flist_fonts, Fopen_font):
1849 Don't assume fixnum can fit in int.
1850 (check_gstring): Don't assume index can fit in int.
1851 (font_match_p): Check that fixnum is a character, not a nonnegative
1852 fixnum, since the later code needs to stuff it into an int.
1853 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1854 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1855 conversion overflow issues.
1856 (Fopen_font): Check for integer out of range.
1857 (Ffont_get_glyphs): Don't assume index can fit in int.
1858 * font.h: Adjust decls to match defn changes elsewhere.
1859 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1860 integer overflow.
1861 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1862 printmax_t, where ptrdiff_t is wide enough.
1863 (Finternal_char_font):
1864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1865 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1866 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1867 (Fset_frame_position, x_set_frame_parameters)
1868 (x_set_line_spacing, x_set_border_width)
1869 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1870 Check that fixnums are in proper range for system types.
1871 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1873 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1874 Use SAFE_ALLOCA_LISP, not alloca.
1875 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1876 intptr_t is wide enough.
1877 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1878 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1879 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1880 Check for fixnum out of range.
1881 * ftfont.c (ftfont_list): Don't assume index fits in int.
1882 Check that fixnums are in proper range for system types.
1883 (ftfont_shape_by_flt):
1884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1885 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1887 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1888 Check that fixnums are in proper range for system types.
1889 * gnutls.h: Adjust decls to match defn changes elsewhere.
1890 * gtkutil.c (xg_dialog_run):
1891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1892 (update_frame_tool_bar):
1893 Check that fixnums are in proper range for system types.
1894 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1895 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1896 * indent.c (last_known_column, last_known_column_point):
1897 (current_column_bol_cache):
1898 (skip_invisible, current_column, check_display_width):
1899 (check_display_width, scan_for_column, current_column_1)
1900 (Findent_to, Fcurrent_indentation, position_indentation)
1901 (indented_beyond_p, Fmove_to_column, compute_motion):
1902 (Fcompute_motion, Fvertical_motion):
1903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1904 (last_known_column_modified): Use EMACS_INT, not int.
1905 (check_display_width):
1906 (Fcompute_motion):
1907 Check that fixnums and floats are in proper range for system types.
1908 (compute_motion): Don't assume index or fixnum fits in int.
1909 (compute_motion, Fcompute_motion):
1910 Use int, not EMACS_INT, when it is wide enough.
1911 (vmotion): Omit local var start_hpos that is always 0; that way
1912 we don't need to worry about overflow in expressions involving it.
1913 * indent.h: Adjust decls to match defn changes elsewhere.
1914 (struct position):
1915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1916 Use int, not EMACS_INT, where int is wide enough.
1917 Remove unused members ovstring_chars_done and tab_offset;
1918 all uses removed.
1919 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1920 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1921 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1922 (make_gap, copy_text, insert, insert_and_inherit)
1923 (insert_before_markers, insert_before_markers_and_inherit)
1924 (insert_1, count_combining_before, count_combining_after)
1925 (insert_1_both, insert_from_string)
1926 (insert_from_string_before_markers, insert_from_string_1)
1927 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1928 (adjust_after_replace, adjust_after_insert, replace_range)
1929 (replace_range_2, del_range, del_range_1, del_range_byte)
1930 (del_range_both, del_range_2, modify_region)
1931 (prepare_to_modify_buffer, signal_before_change)
1932 (signal_after_change, Fcombine_after_change_execute):
1933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1934 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1935 (balance_an_interval, split_interval_right, split_interval_left)
1936 (find_interval, next_interval, update_interval)
1937 (adjust_intervals_for_insertion, delete_node, delete_interval)
1938 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1939 (static_offset_intervals, offset_intervals)
1940 (merge_interval_right, merge_interval_left, make_new_interval)
1941 (graft_intervals_into_buffer, temp_set_point_both)
1942 (temp_set_point, set_point, adjust_for_invis_intang)
1943 (set_point_both, move_if_not_intangible, get_property_and_range)
1944 (get_local_map, copy_intervals, copy_intervals_to_string)
1945 (compare_string_intervals, set_intervals_multibyte_1):
1946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1947 * intervals.h: Adjust decls to match defn changes elsewhere.
1948 (struct interval):
1949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1950 * keyboard.c (this_command_key_count, this_single_command_key_start)
1951 (before_command_key_count, before_command_echo_length, echo_now)
1952 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1953 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1954 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1955 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1957 (last_non_minibuf_size, last_point_position, echo_truncate)
1958 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1959 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1960 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1961 (stuff_buffered_input):
1962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1963 (last_auto_save, command_loop_1, read_char):
1964 Use EMACS_INT, not int, to avoid integer overflow.
1965 (record_char): Avoid overflow in total_keys computation.
1966 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1967 * keyboard.h: Adjust decls to match defn changes elsewhere.
1968 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1969 (Fkey_description, Fdescribe_vector, Flookup_key):
1970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1971 (click_position): New function, to check that positions are in range.
1972 (Fcurrent_active_maps):
1973 (describe_command):
1974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1975 (Faccessible_keymaps, Fkey_description):
1976 (preferred_sequence_p):
1977 Don't assume fixnum can fit into int.
1978 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1979 Check for integer overflow in size calculations.
1980 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1981 avoid mishandling large integers.
1982 * lisp.h: Adjust decls to match defn changes elsewhere.
1983 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1984 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1985 (struct Lisp_Marker):
1986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1987 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1988 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1989 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1990 All callers changed.
1991 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1992 Assume the arg has valid form, since it always does.
1993 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1994 unsigned integer system type.
1995 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1996 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1998 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1999 (duration_to_sec_usec): New decl.
2000 * lread.c (read_from_string_index, read_from_string_index_byte)
2001 (read_from_string_limit, readchar, unreadchar, openp)
2002 (read_internal_start, read1, oblookup):
2003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2004 (Fload, readevalloop, Feval_buffer, Feval_region):
2005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2006 (openp): Check for out-of-range argument to 'access'.
2007 (read1): Use int, not EMACS_INT, where int is wide enough.
2008 Don't assume fixnum fits into int.
6efdadfd 2009 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2010 (read_filtered_event): Use duration_to_sec_usec
2011 to do proper overflow checking on durations.
d311d28c
PE
2012 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2013 in size calculation.
2014 (Fexecute_kbd_macro):
2015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2016 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2017 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2018 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2019 (set_marker_both, set_marker_restricted_both, marker_position)
2020 (marker_byte_position, Fbuffer_has_markers_at):
2021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2022 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2023 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2024 It now merely ensures that the menu is large enough, without
2025 necessarily growing it, as this avoids some integer overflow issues.
2026 All callers changed.
2027 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2029 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2030 Use SAFE_ALLOCA_LISP, not alloca.
2031 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2032 to EMACS_INT. Check that fixnums are in proper range for system types.
2033 * minibuf.c (minibuf_prompt_width, string_to_object)
2034 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2035 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2037 (get_minibuffer, read_minibuf_unwind):
2038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2039 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2040 this simplifies overflow checking. All callers changed.
2041 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2042 (Ftest_completion):
2043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2044 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2045 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2046 Check that fixnums are in proper range for system types.
2047 (Fx_create_frame, Fx_show_tip):
2048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2049 * nsfont.m (ns_findfonts, nsfont_list_family):
2050 Don't assume fixnum fits in long.
2051 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2053 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2054 wide enough.
17fdb222 2055 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2057 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2058 (PRINTDECLARE, PRINTPREPARE):
2059 (strout, print_string):
2060 (print, print_preprocess, print_check_string_charset_prop)
2061 (print_object):
2062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2063 (PRINTDECLARE):
2064 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2067 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2068 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2069 (print_error_message): Use SAFE_ALLOCA, not alloca.
2070 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2071 (print_depth, new_backquote_output, print_number_index):
2072 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2073 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2074 (Fset_process_window_size, Fformat_network_address)
2075 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2076 (sigchld_handler):
d311d28c 2077 Check that fixnums are in proper range for system types.
d44287d4 2078 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2079 Check for process-ids out of pid_t range rather than relying on
2080 undefined behavior.
e4d81efc 2081 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2082 (Fformat_network_address, read_process_output, send_process)
2083 (Fprocess_send_region, status_notify):
2084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2085 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2086 (wait_reading_process_output, read_process_output, exec_sentinel):
2087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2088 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2089 (Faccept_process_output): Use duration_to_sec_usec to do proper
2090 overflow checking on durations.
dde14581
PE
2091 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2092 Don't assume pid_t fits in int.
02481186
PE
2093 * process.h (struct Lisp_Process): Members tick and update_tick
2094 are now of type EMACS_INT, not int.
b62b53e8
PE
2095 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2096 configured --with-wide-int.
d311d28c
PE
2097 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2098 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2099 * search.c (looking_at_1, string_match_1):
2100 (fast_string_match, fast_c_string_match_ignore_case)
2101 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2102 (scan_newline, find_before_next_newline, search_command)
2103 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2104 (set_search_regs, wordify):
2105 (Freplace_match):
2106 (Fmatch_data):
2107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2108 (string_match_1, search_buffer, set_search_regs):
2109 (Fmatch_data):
2110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2111 (wordify): Check for overflow in size calculation.
2112 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2113 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2114 Check that fixnums are in proper range for system types.
2115 * sound.c (struct sound_device)
2116 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2118 (Fplay_sound_internal):
2119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2120 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2121 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2122 (Fparse_partial_sexp):
2123 Don't assume fixnums can fit in int.
2124 (struct lisp_parse_state, find_start_pos, find_start_value)
2125 (find_start_value_byte, find_start_begv)
2126 (update_syntax_table, char_quoted, dec_bytepos)
2127 (find_defun_start, prev_char_comend_first, back_comment):
2128 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2129 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2131 (Finternal_describe_syntax_value): Check that match_lisp is a
2132 character, not an integer, since the code stuffs it into int.
2133 (scan_words, scan_sexps_forward):
2134 Check that fixnums are in proper range for system types.
2135 (Fforward_word):
2136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2137 (scan_sexps_forward):
2138 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2139 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2140 * syntax.h: Adjust decls to match defn changes elsewhere.
2141 (struct gl_state_s):
2142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2143 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2144 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2145 * sysdep.c (wait_for_termination_1, wait_for_termination)
2146 (interruptible_wait_for_termination, mkdir):
2147 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2148 (emacs_read, emacs_write):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2150 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2151 and double all fit in int.
d311d28c
PE
2152 * term.c (set_tty_color_mode):
2153 Check that fixnums are in proper range for system types.
2154 * termhooks.h (struct input_event):
2155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2156 * textprop.c (validate_interval_range, interval_of)
2157 (Fadd_text_properties, set_text_properties_1)
2158 (Fremove_text_properties, Fremove_list_of_text_properties)
2159 (Ftext_property_any, Ftext_property_not_all)
2160 (copy_text_properties, text_property_list, extend_property_ranges)
2161 (verify_interval_modification):
2162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2163 (Fnext_single_char_property_change)
2164 (Fprevious_single_char_property_change):
2165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2166 (copy_text_properties):
2167 Check for integer overflow in index calculation.
d311d28c
PE
2168 * undo.c (last_boundary_position, record_point, record_insert)
2169 (record_delete, record_marker_adjustment, record_change)
2170 (record_property_change):
2171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2172 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2174 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2175 (Fx_hide_tip, Fx_file_dialog):
2176 * w32menu.c (set_frame_menubar):
2177 Use ptrdiff_t, not int, for consistency with rest of code.
2178 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2179 (select_window, Fdelete_other_windows_internal)
2180 (window_scroll_pixel_based, window_scroll_line_based)
2181 (Frecenter, Fset_window_configuration):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 (Fset_window_hscroll, run_window_configuration_change_hook)
2184 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2185 (Fscroll_other_window, Frecenter):
d311d28c
PE
2186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2187 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2188 Don't assume fixnum fits in int.
2189 (Fset_window_scroll_bars):
2190 Check that fixnums are in proper range for system types.
2191 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2192 (string_pos, c_string_pos, number_of_chars, init_iterator)
2193 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2194 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2195 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2196 (face_before_or_after_it_pos, handle_invisible_prop)
2197 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2198 (display_prop_intangible_p, string_buffer_position_lim)
2199 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2200 (get_overlay_strings_1, get_overlay_strings)
2201 (iterate_out_of_display_property, forward_to_next_line_start)
2202 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2203 (get_next_display_element, set_iterator_to_next)
2204 (get_visually_first_element, compute_stop_pos_backwards)
2205 (handle_stop_backwards, next_element_from_buffer)
2206 (move_it_in_display_line_to, move_it_in_display_line)
2207 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2208 (add_to_log, message_dolog, message_log_check_duplicate)
2209 (message2, message2_nolog, message3, message3_nolog
2210 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2211 (current_message_1, truncate_echo_area, truncate_message_1)
2212 (set_message, set_message_1, store_mode_line_noprop)
2213 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2214 (text_outside_line_unchanged_p, check_point_in_composition)
2215 (reconsider_clip_changes)
2216 (redisplay_internal, set_cursor_from_row, try_scrolling)
2217 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2218 (redisplay_window, find_last_unchanged_at_beg_row)
2219 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2220 (trailing_whitespace_p, find_row_edges, display_line)
2221 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2222 (display_mode_element, store_mode_line_string)
2223 (pint2str, pint2hrstr, decode_mode_spec)
2224 (display_count_lines, display_string, draw_glyphs)
2225 (x_produce_glyphs, x_insert_glyphs)
2226 (rows_from_pos_range, mouse_face_from_buffer_pos)
2227 (fast_find_string_pos, mouse_face_from_string_pos)
2228 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2230 (safe_call, init_from_display_pos, handle_fontified_prop)
2231 (handle_single_display_spec, load_overlay_strings)
2232 (with_echo_area_buffer, setup_echo_area_for_printing)
2233 (display_echo_area, echo_area_display)
2234 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2235 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2236 (redisplay_window, dump_glyph_row, display_mode_line)
2237 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2238 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2240 (handle_single_display_spec, build_desired_tool_bar_string)
2241 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2242 (get_specified_cursor_type):
2243 Check that fixnums are in proper range for system types.
2244 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2245 (Flookup_image_map):
2246 Don't assume fixnums fit in int.
2247 (compare_overlay_entries):
2248 Avoid mishandling comparisons due to subtraction overflow.
2249 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2250 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2251 (handle_tool_bar_click):
2252 Use int, not unsigned, since we prefer signed and the signedness
2253 doesn't matter here.
2254 (get_next_display_element, next_element_from_display_vector):
2255 Use int, not EMACS_INT, when int is wide enough.
2256 (start_hourglass): Use duration_to_sec_usec to do proper
2257 overflow checking on durations.
2258 * xfaces.c (Fbitmap_spec_p):
2259 Check that fixnums are in proper range for system types.
2260 (compare_fonts_by_sort_order):
2261 Avoid mishandling comparisons due to subtraction overflow.
2262 (Fx_family_fonts, realize_basic_faces):
2263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2264 (Fx_family_fonts):
2265 Don't assume fixnum fits in int.
2266 Use SAFE_ALLOCA_LISP, not alloca.
2267 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2268 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2269 (face_at_buffer_position, face_for_overlay_string)
2270 (face_at_string_position):
2271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2272 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2273 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2274 (Fx_show_tip):
2275 Check that fixnums are in proper range for system types.
2276 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2277 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2279 (Fx_change_window_property): Don't assume fixnums fit in int.
2280 * xfont.c (xfont_chars_supported):
2281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2282 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2283 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2285 * xml.c (parse_region):
2286 * xrdb.c (magic_file_p):
2287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2288 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2289 (x_get_local_selection, x_reply_selection_request)
2290 (x_handle_selection_request, wait_for_property_change):
2291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2292 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2293 short is wide enough.
2294 (x_send_client_event): Don't assume fixnum fits in int.
2295 * xterm.c (x_x_to_emacs_modifiers):
2296 Don't assume EMACS_INT overflows nicely into int.
2297 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2298 may come from Lisp.
2299 (handle_one_xevent): NATNUMP can eval its arg twice.
2300 (x_connection_closed):
2301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2302 * xterm.h: Adjust decls to match defn changes elsewhere.
2303 (struct scroll_bar): Use struct vectorlike_header
2304 rather than rolling our own approximation.
2305 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2306
c6574eb5
GM
23072012-05-25 Glenn Morris <rgm@gnu.org>
2308
2309 * lisp.mk (lisp): Update for more files being compiled now.
2310
e8d32c7e
SM
23112012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2312
48def666
SM
2313 * lread.c: Remove `read_pure' which makes no difference.
2314 (read_pure): Remove var.
2315 (unreadpure): Remove function.
2316 (readevalloop): Don't call read_list with -1 flag.
2317 (read1, read_vector): Don't test read_pure any more.
2318 (read_list): Simplify.
2319
e8d32c7e
SM
2320 * fileio.c, character.h: Minor style tweaks.
2321
4b2addb7
DA
23222012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2323
2324 * window.h (clip_changed): Remove useless declaration.
2325
584461b2
JB
23262012-05-22 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2329 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2330
34374650
PE
23312012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 Remove src/m/*.
2334 This directory predates autoconf and is no longer needed nowadays.
2335 Move its few remaining bits of functionality to where they're needed.
2336 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2337 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2338 * m/template.h: Remove.
2339 * Makefile.in (M_FILE): Remove. All uses removed.
2340 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2341 * lisp.h (USE_LSB_TAG):
2342 * mem-limits.h (EXCEEDS_LISP_PTR):
2343 Use VAL_MAX, not VALBITS, in #if.
2344 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2345 (EMACS_UINT): Define unconditionally now.
2346 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2347 (BITS_PER_EMACS_INT): New constants, replacing
2348 what used to be in config.h, but not useful in #if.
2349 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2350 define them any more.
2351 (VAL_MAX): New macro.
2352 (VALMASK): Use it.
2353 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2354 BITS_PER_EMACS_INT, in #if.
2355 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2356 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2357 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2358 * s/ms-w32.h (DATA_START):
2359 Move here from removed file m/intel386.h.
2360 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2361 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2362
261cb4bb
PE
23632012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 Assume C89 or later.
2366 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2367 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2368 (xrealloc):
2369 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2370 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2371 * textprop.c, tparam.c (NULL): Remove.
2372 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2373 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2374 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2375 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2376 * xterm.c (input_signal_count): Assume volatile works.
2377
ff23cd9f
KB
23782012-05-21 Ken Brown <kbrown@cornell.edu>
2379
2380 * xgselect.c (xg_select): Fix first argument in call to 'select'
2381 (bug#11508).
2382
1b170bc6
KB
23832012-05-20 Ken Brown <kbrown@cornell.edu>
2384
2385 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2386 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2387
b2f4d39f
KB
23882012-05-19 Ken Brown <kbrown@cornell.edu>
2389
2390 * xfns.c (x_in_use): Remove `static' qualifier.
2391 * xterm.h (x_in_use): Declare.
2392 * xgselect.c: Include xterm.h.
2393 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2394 and `display_arg' (bug#9754).
2395
003fdae2
PE
23962012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2397
9232a6d9
PE
2398 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2399
003fdae2
PE
2400 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2401 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2402
784b56e2
EZ
24032012-05-18 Eli Zaretskii <eliz@gnu.org>
2404
2405 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2406
2407 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2408 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2409
2410 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2411 reference to image_cache->refcount.
2412 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2413
a0a79cde
JL
24142012-05-17 Juri Linkov <juri@jurta.org>
2415
2416 * search.c (Fword_search_regexp, Fword_search_backward)
2417 (Fword_search_forward, Fword_search_backward_lax)
2418 (Fword_search_forward_lax): Move functions to isearch.el
2419 (bug#10145, bug#11381).
2420
b0572523
PE
24212012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2424
9660f5fc
SM
24252012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2426
2427 * lread.c (init_obarray): Declare Qt and Qnil as special.
2428
4374de83
GM
24292012-05-14 Glenn Morris <rgm@gnu.org>
2430
2431 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2432 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2433
dc44c39a
PE
24342012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2435
078c97cb
PE
2436 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2437
dc44c39a
PE
2438 * unexaix.c: Port to more-recent AIX compilers.
2439 (report_error, report_error_1, make_hdr, copy_sym)
2440 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2441 Make arguments const char *, not char *, to avoid violations of C
2442 standard and to fix some AIX warnings reported by Gilles Pion.
2443
e18afed7 24442012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2445
2446 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2447 already have overlays loaded.
2448 (handle_single_display_spec): Before returning without displaying
2449 fringe bitmap, synchronize the bidi iterator with the main display
2450 iterator, by calling iterate_out_of_display_property.
2451 (iterate_out_of_display_property): Detect buffer iteration by
2452 testing that it->string is a Lisp string.
2453 (get_next_display_element): When the current object is exhausted,
2454 and there's something on it->stack, call set_iterator_to_next to
2455 proceed with what's on the stack, instead of returning zero.
2456 (set_iterator_to_next): If called at the end of a Lisp string,
2457 proceed to consider_string_end without incrementing string
2458 position. Don't increment display vector index past the end of
2459 the display vector. (Bug#11417)
c8fb9dc6
EZ
2460 (pos_visible_p): Don't report a position visible when move_it_to
2461 stopped at the last line of window, which happens to be scanned
2462 backwards by the bidi iteration. (Bug#11464)
ac268e67 2463
e18afed7 24642012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2465
2466 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2467 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2468 are on a TTY, and thus unable to display on the fringes.
2469 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2470 so we need to signal to the caller that this is a "replacing"
2471 display spec. This fixes display when the spec is invalid or we
2472 are on a TTY.
2473
e18afed7 24742012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2475
2476 * unexaix.c (make_hdr): Fix typo in prototype.
2477 This bug broke the build on AIX. Problem reported by Gilles Pion.
2478
9d0a235a
MA
24792012-05-14 Michael Albinus <michael.albinus@gmx.de>
2480
2481 * keyboard.c (kbd_buffer_get_event): Read special events also in
2482 batch mode. (Bug#11415)
2483
9e6b06ed
GM
24842012-05-12 Glenn Morris <rgm@gnu.org>
2485
2486 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2487
c1a1d7a3
EZ
24882012-05-12 Eli Zaretskii <eliz@gnu.org>
2489
2490 * lisp.mk (lisp): Add newcomment.elc.
2491
3fe7cdc8
GM
24922012-05-12 Glenn Morris <rgm@gnu.org>
2493
2494 * Makefile.in (MKDIR_P): New, set by configure.
2495 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2496
53f7d2c0
PE
24972012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 Remove unused function hourglass_started.
2500 * dispextern.h (hourglass_started):
2501 * w32fns.c (hourglass_started):
2502 * xdisp.c (hourglass_started): Remove.
2503
75aafb17
JB
25042012-05-10 Juanma Barranquero <lekktu@gmail.com>
2505
2506 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2507 Update dependencies.
2508
12959e8e
PE
25092012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2510
97107e2e
PE
2511 * xgselect.c (xg_select): Put maxfds+1 into a var.
2512 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2513
12959e8e
PE
2514 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2515
836d29b3
DA
25162012-05-10 Dave Abrahams <dave@boostpro.com>
2517
2518 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2519 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2520
5cb67954
MA
25212012-05-09 Michael Albinus <michael.albinus@gmx.de>
2522
2523 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2524 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2525 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2526 Initialize xd_registered_buses.
2527
3478ec45
PE
25282012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2529
b263a6b0
PE
2530 Untag more efficiently if USE_LSB_TAG.
2531 This is based on a proposal by YAMAMOTO Mitsuharu in
2532 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2533 For an admittedly artificial (nth 8000 longlist) benchmark on
2534 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2535 Emacs's overall text size by 1%.
2536 * lisp.h (XUNTAG): New macro.
2537 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2538 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2539 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2540 * eval.c (Fautoload):
2541 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2542 * frame.h (XFRAME): Use XUNTAG.
2543
3478ec45
PE
2544 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2545 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2546 Remove unportable assumptions about print widths of types like
2547 dbus_uint32_t.
2548 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2549 intptr_t when converting between pointer and integer, to avoid GCC
2550 warnings about wrong width.
2551
666b903b 25522012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2553
2554 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2555 stack for each reader_thread, instead of defaulting to 8MB
2556 determined by the linker. This avoids failures in creating
2557 subprocesses on Windows 7, see the discussion in this thread:
2558 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2559
b120cc17
JC
25602012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2561
2562 Fix up display of the *Minibuf-0* buffer in the mini window.
2563 * keyboard.c (read_char): Don't clear the echo area if there's no
2564 message to clear.
2565 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2566 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2567
9a4b36f8
MA
25682012-05-07 Michael Albinus <michael.albinus@gmx.de>
2569
2570 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2571 batch mode.
2572
e5f9458f
CY
25732012-05-06 Chong Yidong <cyd@gnu.org>
2574
2575 * lisp.mk (lisp): Update.
2576
eceeb5fc 25772012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2578
2579 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2580
71873e2b
SM
25812012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2582
2583 * data.c (PUT_ERROR): New macro.
2584 (syms_of_data): Use it. Add new error type `user-error'.
2585 * undo.c (user_error): New function.
2586 (Fprimitive_undo): Use it.
2587 * print.c (print_error_message): Adjust print style for `user-error'.
2588 * keyboard.c (user_error): New function.
2589 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2590
ab0fa4e4
PE
25912012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 Do not limit current-time-string to years 1000..9999.
2594 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2595 (Fcurrent_time_string): Support any year that is supported by the
2596 underlying localtime representation. Don't use asctime, as it
2597 has undefined behavior for years outside the range -999..9999.
2598
7ed806a7
PE
25992012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 Fix race conditions involving setenv, gmtime, localtime, asctime.
2602 Without this fix, interrupts could mess up code that uses these
2603 nonreentrant functions, since setting TZ invalidates existing
2604 tm_zone or tzname values, and since most of these functions return
2605 pointers to static storage.
2606 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2607 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2608 Grow the critical sections to include not just invoking
2609 localtime/gmtime, but also accessing these functions' results
2610 including their tm_zone values if any, and any related TZ setting.
2611 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2612 so that the struct tm is saved in the critical section.
2613 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2614 motivated by the fact that memory allocation needs to be outside
2615 the critical section.
2616
0c16dfed
DA
26172012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2618
2619 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2620 with RESET_INTERVAL.
2621
2622 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2623 Remove duplicated buffer name initialization.
2624
3f83ace8
JM
26252012-05-02 Jim Meyering <jim@meyering.net>
2626
2627 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2628
c7b8541e
JM
2629 * xfns.c (x_window): Use xstrdup (Bug#11375).
2630
90207a15 26312012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2632
2633 * xdisp.c (pos_visible_p): If already at a newline from the
2634 display string before the 'while' loop, don't walk back the glyphs
2635 from it3.glyph_row. Solves assertion violation when the display
2636 string begins with a newline (egg.el). (Bug#11367)
2637
b593d6a9
AH
26382012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2639
2640 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2641 Move to simple.el.
2642
4737362e
GM
26432012-05-01 Glenn Morris <rgm@gnu.org>
2644
99cf43f9
GM
2645 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2646 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2647 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2648 All were removed before 23.1.
2649
9311dcff
GM
2650 * dispnew.c: Remove HAVE_LIBNCURSES test;
2651 it is always true on relevant platforms.
2652
4d5c6349
GM
2653 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2654 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2655
4737362e
GM
2656 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2657
74dd3a6b
AS
26582012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2659
2660 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2661 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2662 Remove.
2663
13c379ee
PE
26642012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 Do not avoid creating empty evaporating overlays (Bug#9642).
2667 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2668 That is, do not delete an evaporating overlay if it becomes
2669 empty after its bounds are adjusted to fit within its buffer.
2670 This fix caused other problems, and I'm reverting it until we get
2671 to the bottom of them.
2672
a8e7d6d7 26732012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2674
2675 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2676
a8e7d6d7 26772012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2678
2679 * xdisp.c (pos_visible_p): If the window start position is beyond
2680 ZV, start the display from buffer beginning. Prevents assertion
2681 violation in init_iterator when the minibuffer window is scrolled
2682 via the scroll bar.
2683
2684 * window.c (window_scroll_pixel_based): Likewise.
2685
a8e7d6d7 26862012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2687
2688 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2689
a8e7d6d7 26902012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2691
2692 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2693 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2694
a8e7d6d7 26952012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2696
b593d6a9
AH
2697 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2698 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2699
1c6900d9
EZ
27002012-04-26 Eli Zaretskii <eliz@gnu.org>
2701
4c3fa1d9
EZ
2702 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2703 display element, check also the underlying string or buffer
2704 character. (Bug#11341)
2705
1c6900d9
EZ
2706 * w32menu.c: Include w32heap.h.
2707 (add_menu_item): If the call to AppendMenuW (via
2708 unicode_append_menu) fails, disable Unicode menus only if we are
2709 running on Windows 9X/Me.
2710
42bf8205
AS
27112012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2712
2713 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2714 (xgetint): Add missing shift for LSB tags.
2715
b1bac16e
MR
27162012-04-24 Martin Rudalics <rudalics@gmx.at>
2717
2718 * keyboard.c (read_char): Don't wipe echo area for select window
2719 events: These might get delayed via `mouse-autoselect-window'
2720 (Bug#11304).
2721
d69621cc
JB
27222012-04-24 Juanma Barranquero <lekktu@gmail.com>
2723
2724 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2725 manipulation of :loaded-from data.
2726
02fd101b
JB
27272012-04-23 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2730 now a cons (bug#11311).
2731
888bec30
PE
27322012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2733
89a438bd
PE
2734 Do not create empty overlays with the evaporate property (Bug#9642).
2735 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2736 if it becomes empty after its bounds are adjusted to fit within
2737 its buffer. Without this fix, in a nonempty buffer (let ((o
2738 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2739 yields an empty overlay that has the evaporate property, which is
2740 not supposed to happen.
2741
1068fe4d
PE
2742 Fix minor GTK3 problems found by static checking.
2743 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2744 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2745 (struct _EmacsFixedClass, emacs_fixed_get_type):
2746 Move decls here from emacsgtkfixed.h, since they needn't be public.
2747 (emacs_fixed_get_type): Now static.
2748 (emacs_fixed_class_init): Omit unused local.
2749 (emacs_fixed_child_type): Remove; unused.
2750 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2751 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2752 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2753 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2754 (EMACS_FIXED_GET_CLASS): Remove; unused.
2755 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2756
888bec30
PE
2757 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2758 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2759
de85e130
PE
27602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2761
d0baac98 2762 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2763 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2764 (__malloc_size_t, __malloc_ptrdiff_t):
2765 Remove. All uses removed, replaced by the definiens if needed,
2766 since we can assume C89 or better now.
2767 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2768 (protect_malloc_state, align, get_contiguous_space)
2769 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2770 (malloc_atfork_handler_child, malloc_enable_thread)
2771 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2772 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2773 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2774 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2775 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2776 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2777 Define using prototypes, not old style.
2778 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2779 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2780 (align): Don't assume that signed integer overflow wraps around.
2781 Omit unused local var.
2782 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2783 (_free_internal_nolock, memalign, mallochook, reallochook):
2784 Omit no-longer-needed casts.
2785 (valloc): Use getpagesize, not __getpagesize.
2786 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2787 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2788
de85e130
PE
2789 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2790
dcbf5805
MA
27912012-04-22 Michael Albinus <michael.albinus@gmx.de>
2792
2793 Move functions from C to Lisp. Make non-blocking method calls
2794 the default. Implement further D-Bus standard interfaces.
2795
2796 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2797 (QCdbus_request_name_allow_replacement)
2798 (QCdbus_request_name_replace_existing)
2799 (QCdbus_request_name_do_not_queue)
2800 (QCdbus_request_name_reply_primary_owner)
2801 (QCdbus_request_name_reply_in_queue)
2802 (QCdbus_request_name_reply_exists)
2803 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2804 (QCdbus_registered_serial, QCdbus_registered_method)
2805 (QCdbus_registered_signal): New Lisp objects.
2806 (XD_DEBUG_MESSAGE): Use sizeof.
2807 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2808 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2809 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2810 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2811 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2812 (xd_signature, xd_append_arg): Allow float for integer types.
2813 (xd_get_connection_references): New function.
b593d6a9
AH
2814 (xd_get_connection_address): Rename from xd_initialize.
2815 Return cached address.
dcbf5805
MA
2816 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2817 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2818 level.
2819 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2820 Return number of refcounts.
dcbf5805
MA
2821 (Fdbus_get_unique_name): Make stronger parameter check.
2822 (Fdbus_message_internal): New defun.
2823 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2824 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2825 (Fdbus_send_signal, Fdbus_register_service)
2826 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2827 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2828 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2829 (Vdbus_compiled_version, Vdbus_runtime_version)
2830 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2831 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2832 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2833 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2834 Adapt docstring.
dcbf5805 2835
52828e02
PE
28362012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2837
da05bc4c
PE
2838 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2839 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2840 Do not assume ptrdiff_t is the same width as 'int'.
2841
52828e02
PE
2842 * alloc.c: Handle unusual debugging option combinations.
2843 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2844 since the two debugging options are incompatible.
2845 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2846 is defined.
2847 (mem_init, mem_insert, mem_insert_fixup):
2848 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2849 (NEED_MEM_INSERT): Remove; no longer needed.
2850
f01769f9
LL
28512012-04-22 Leo Liu <sdl.web@gmail.com>
2852
2853 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2854
5790543d
PE
28552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * sysdep.c [__FreeBSD__]: Minor cleanups.
2858 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2859 Use Emacs indenting style more consistently. Avoid some casts.
2860 Use 'double' consistently rather than mixing 'float' and 'double'.
2861
b91b7e4d
EW
28622012-04-21 Eduard Wiebe <usenet@pusto.de>
2863
b593d6a9
AH
2864 * sysdep.c (list_system_processes, system_process_attributes):
2865 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2866
6114eb15
AS
28672012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2868
2869 * lisp.mk (lisp): Update.
2870
2f38dff7
PE
28712012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2874 It is never used otherwise.
2875
4ae29f89
SM
28762012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2877
2878 * print.c (print_preprocess): Only check print_depth if print-circle
2879 is nil.
2880 (print_object): Check for cycles even when print-circle is nil and
2881 print-gensym is t, but only check print_depth if print-circle is nil.
2882
f30d612a
CY
28832012-04-20 Chong Yidong <cyd@gnu.org>
2884
2885 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2886 set the status to "failed" and ensure that sentinel is run.
2887
c07a4c0b 28882012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2889
2890 * process.c (Fset_process_inherit_coding_system_flag)
2891 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2892 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2893
c07a4c0b 28942012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2895
2896 * xdisp.c (string_buffer_position_lim): Limit starting position to
2897 BEGV.
2898 (set_cursor_from_row): If called for a mode-line or header-line
2899 row, return zero immediately.
2900 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2901 farther than the first row after the header line, if any.
2902 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2903 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2904
c07a4c0b 29052012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2906
4ae29f89
SM
2907 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2908 (bug#11238).
ad3a2b41 2909
c07a4c0b 29102012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29112012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2912
2913 configure: new option --enable-gcc-warnings (Bug#11207)
2914 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2915 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2916 (ALL_CFLAGS): Use new macros rather than old.
2917 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2918 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2919 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2920 -Wunused-result, -Wunused-variable. This should go away once
2921 the Emacs and Gnulib regex code is merged.
2922 (xmalloc, xrealloc): Now static.
2923
aba027e8
PE
29242012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 * dired.c (Fsystem_groups): Remove unused local.
2927
e5a36063
GM
29282012-04-17 Glenn Morris <rgm@gnu.org>
2929
2930 * dired.c (Fsystem_users): Doc fix.
2931
316411f0
DA
29322012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2933
2934 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2935 (syms_of_dired): Add them.
2936
9426aba4
PE
29372012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2938
b62a57be
PE
2939 Fix minor alloc.c problems found by static checking.
2940 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2941 New extern decls, to avoid calling undeclared functions.
2942 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2943 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2944 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2945 (NEED_MEM_INSERT): New macro.
2946 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2947 Remove one incorrect comment and fix another.
b62a57be 2948
3539f31f
PE
2949 Fix minor ralloc.c problems found by static checking.
2950 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2951 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2952 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2953 (r_alloc_sbrk): Now static.
2954
a041960a
PE
2955 Improve ralloc.c interface checking.
2956 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2957 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2958 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2959 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2960 [REL_ALLOC]: ... to here, to check interface.
2961 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2962 Remove decls. This fixes an "It stinks!".
2963
9426aba4
PE
2964 * alloc.c (which_symbols): Fix alignment issue / type clash.
2965
d55c12ed
AS
29662012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2967
2968 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2969 (struct Lisp_Misc_Any): Likewise.
2970 (struct Lisp_Free): Likewise.
2971 * alloc.c (union aligned_Lisp_Symbol): Define.
2972 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2973 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2974 (union aligned_Lisp_Misc): Define.
2975 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2976 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2977 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2978
b948ce8b
PE
29792012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2982 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2983 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2984 * s/netbsd.h, s/sol2-6.h:
2985 Remove definition of GC_MARK_STACK, since the default now works.
2986 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2987 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2988 no longer the default.
2989 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2990
35dc09a1 29912012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2992
35dc09a1
GM
2993 * lread.c (lisp_file_lexically_bound_p):
2994 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2995
35dc09a1
GM
29962012-04-14 Eli Zaretskii <eliz@gnu.org>
2997
2998 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2999 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3000
30012012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3002
3003 * nsterm.m (constrainFrameRect): Always constrain when there is only
3004 one screen (Bug#10962).
3005
bcd86815
KB
30062012-04-13 Ken Brown <kbrown@cornell.edu>
3007
3008 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3009
c25df26e
RT
30102012-04-13 Reuben Thomas <rrt@sc3d.org>
3011
3012 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3013
0fc59f1e
DC
30142012-04-11 Daniel Colascione <dancol@dancol.org>
3015
3016 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3017 against is gone. It's better to use vfork now so that when Cygwin
3018 gains a new, working vfork, we use it automatically (bug#10398).
3019
de8c03dc
SM
30202012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3021
3022 * window.c (save_window_save): Obey window-point-insertion-type.
3023
2f097256
GM
30242012-04-11 Glenn Morris <rgm@gnu.org>
3025
3026 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3027
453b951e
SM
30282012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3031
75f1671a 30322012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3033
3034 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3035 (force_quit_count): New var.
3036 (handle_interrupt): Use it.
3037
2a8ce227
JB
30382012-04-10 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * w32.c (w32_delayed_load): Record the full path of the library
3041 being loaded (bug#10424).
3042
935396c0
GM
30432012-04-09 Glenn Morris <rgm@gnu.org>
3044
05920a43
GM
3045 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3046 not just in the obarray, before snarfing them. (Bug#11036)
3047
935396c0
GM
3048 * Makefile.in ($(leimdir)/leim-list.el):
3049 Pass EMACS rather than BUILT_EMACS.
3050
a18ecafa
TZ
30512012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3052
3053 * process.c (make_process):
3054 * process.h: Add integer `gnutls_handshakes_tried' member to
3055 process struct.
3056
6bbef4e5
JC
3057 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3058 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3059
3060 * gnutls.c (gnutls_log_function2i): Convenience log function.
3061 (emacs_gnutls_read): Use new log functions,
3062 `gnutls_handshakes_tried' process member, and
3063 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3064 attempts per process (connection).
3065
b4d3bc10
CY
30662012-04-09 Chong Yidong <cyd@gnu.org>
3067
3068 * eval.c (Fuser_variable_p, user_variable_p_eh)
3069 (lisp_indirect_variable): Functions deleted.
3070 (Fdefvar): Caller changed.
3071
3072 * callint.c (Finteractive, Fcall_interactively):
3073 * minibuf.c (Fread_variable): Callers changed.
3074
70f4d973
EZ
30752012-04-09 Eli Zaretskii <eliz@gnu.org>
3076
3077 * xdisp.c (set_cursor_from_row): If the display string appears in
3078 the buffer at position that is closer to point than the position
3079 after the display string, display the cursor on the first glyph of
3080 the display string. Fixes cursor display when a 'display' text
3081 property immediately follows invisible text. (Bug#11094)
3082
cb3c2e3e
PE
30832012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 composite.c: use 'double' consistently
3086 * composite.c (get_composition_id): Use 'double' consistently
3087 instead of converting 'float' to 'double' and vice versa; this is
3088 easier to understand and avoids a GCC warning.
3089
fd06db5d
GM
30902012-04-09 Glenn Morris <rgm@gnu.org>
3091
50fe702a
GM
3092 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3093 preparation for dumping it with emacs. (Bug#4789)
3094 (leimdir): New variable.
3095 ($(leimdir)/leim-list.el): New rule.
3096 (emacs$(EXEEXT)): Depend on leim-list.el.
3097
fd06db5d
GM
3098 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3099 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3100 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3101
55c131ee
AS
31022012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3103
3104 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3105 proper alignment.
3106
9209588f
JB
31072012-04-07 Juanma Barranquero <lekktu@gmail.com>
3108
3109 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3110 Remove unused local variable.
3111
e3fb2efb
PE
31122012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3115 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3116 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3117 objects, as mark_maybe_pointer will catch them otherwise.
3118 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3119 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3120
b5385551
PE
31212012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 Fix typo that broke non-Windows builds.
3124 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3125
9078ead6
EZ
31262012-04-07 Eli Zaretskii <eliz@gnu.org>
3127
3128 Support building on MS-Windows with libxml2.
3129
3130 * makefile.w32-in (OBJ2): Add xml.$(O).
3131 (GLOBAL_SOURCES): Add xml.c.
3132 ($(BLD)/xml.$(O)): New dependency list.
3133
3134 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3135 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3136 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3137 [!WINDOWSNT]: New macros.
3138 (init_libxml2_functions, libxml2_loaded_p): New functions.
3139 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3140 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3141 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3142 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3143 linked in).
6bbef4e5
JC
3144 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3145 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3146 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3147
3148 * emacs.c: Don't include libxml/parser.h.
3149 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3150 xmlCleanupParser directly.
3151
3152 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3153
3811fdf3
EZ
31542012-04-07 Eli Zaretskii <eliz@gnu.org>
3155
3156 * indent.c (Fvertical_motion): If there is a display string at
3157 point, use it.vpos to compute how many lines to backtrack after
3158 move_it_to point. (Bug#11133)
3159
2f8e16b2
EZ
31602012-04-06 Eli Zaretskii <eliz@gnu.org>
3161
3162 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3163 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3164 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3165 macros related to unification of CJK characters. For the details,
3166 see the discussion following the message here:
3167 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3168
3d439cd1
CY
31692012-04-04 Chong Yidong <cyd@gnu.org>
3170
3171 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3172
8bc53d00
EZ
31732012-04-01 Eli Zaretskii <eliz@gnu.org>
3174
3175 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3176 instead of alloca. (Bug#11138)
3177
3b0512a3
AS
31782012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3179
3180 * w32menu.c (is_simple_dialog): Properly check lisp types.
3181 (Bug#11141)
3182
8427ddd2
EZ
31832012-03-31 Eli Zaretskii <eliz@gnu.org>
3184
979022ef
EZ
3185 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3186 position we get to after a call to move_it_to fails the
3187 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3188 only if we wind up in a string from display property. (Bug#11063)
3189
a6b1c7cc
EZ
3190 * window.c (Fdelete_other_windows_internal): Invalidate the row
3191 and column information about mouse highlight, so that redisplay
3192 restores it after reallocating the glyph matrices. (Bug#7464)
3193
8427ddd2
EZ
3194 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3195 string comes from a `display' text property, use the buffer
3196 position of that property as if we actually saw that position in
3197 the row's glyphs.
697ba24b
EZ
3198 (move_it_by_lines): Remove the assertion that
3199 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3200 violated when there's a before-string at the beginning of a line.
3201 (Bug#11063)
8427ddd2 3202
65a0a738
EZ
32032012-03-30 Eli Zaretskii <eliz@gnu.org>
3204
3205 * xdisp.c (append_space_for_newline): If the default face was
3206 remapped, use the remapped face for the appended newline.
3207 (extend_face_to_end_of_line): Use the remapped default face for
3208 extending the face to the end of the line.
3209 (display_line): Call extend_face_to_end_of_line when the default
3210 face was remapped. (Bug#11068)
3211
581355cc
EZ
32122012-03-29 Eli Zaretskii <eliz@gnu.org>
3213
3214 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3215
e8fc049f
SM
32162012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3217
3218 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3219
4fb9a543
GM
32202012-03-27 Glenn Morris <rgm@gnu.org>
3221
3222 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3223 Doc fixes.
3224
679910f1
KH
32252012-03-26 Kenichi Handa <handa@m17n.org>
3226
3227 * dispextern.h (struct glyph): Fix previous change. Change the
3228 bit length of glyphless.ch to 25 (Bug#11082).
3229
90d49b7f
CY
32302012-03-26 Chong Yidong <cyd@gnu.org>
3231
3232 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3233 (command_loop_1): Use it; inhibit selection update for
3234 handle-select-window too (Bug#8996).
3235
f514f6f0
FP
32362012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3237
e8fc049f 3238 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3239
bf43fa51
KH
32402012-03-25 Kenichi Handa <handa@m17n.org>
3241
3242 * dispextern.h (struct glyph): Change the bit length of
3243 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3244
8a0c01dd
EZ
32452012-03-24 Eli Zaretskii <eliz@gnu.org>
3246
3247 * s/ms-w32.h (tzname): Include time.h before redirecting to
3248 _tzname. Fixes the MSVC build. (Bug#9960)
3249
7d1c3a76
AS
32502012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3251
8ed79523
AS
3252 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3253 characters.
3254
7d1c3a76
AS
3255 * xterm.c (XTread_socket): Only modify handling_signal if
3256 !SYNC_INPUT. (Bug#11080)
3257
e99a9b8b
EZ
32582012-03-23 Eli Zaretskii <eliz@gnu.org>
3259
3260 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3261 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3262 when fetching a multibyte character consumes more bytes than
3263 CHAR_BYTES returns, due to unification of CJK characters in
3264 string_char. (Bug#11073)
3265
5063c0e1
TN
32662012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3267
3268 * process.c (wait_reading_process_output): Handle pty disconnect
3269 by refraining from sending oneself a SIGCHLD (bug#10933).
3270
9f851fbd
CY
32712012-03-22 Chong Yidong <cyd@gnu.org>
3272
3273 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3274
5063c0e1 3275 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3276 Mark string as coming from a prefix property.
3277 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3278 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3279
fb5b8aca
CY
32802012-03-21 Chong Yidong <cyd@gnu.org>
3281
3282 * xfaces.c (Vface_remapping_alist): Doc fix.
3283
62356a1b
EZ
32842012-03-20 Eli Zaretskii <eliz@gnu.org>
3285
3286 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3287 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3288 Doc fixes.
62356a1b 3289
025de85b
CY
32902012-03-20 Chong Yidong <cyd@gnu.org>
3291
3292 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3293 to reflect default non-nil value of redisplay-dont-pause.
3294
4827f94e
KH
32952012-03-19 Kenichi Handa <handa@m17n.org>
3296
3297 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3298 it fit in a valid range (Bug#11003).
3299
e50a24a2
EZ
33002012-03-18 Eli Zaretskii <eliz@gnu.org>
3301
3302 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3303 that is not from display property, accept the row as a "cursor
3304 row" if one of the string's character has a non-nil `cursor'
3305 property. Fixes cursor positioning when there are newlines in
3306 overlay strings, e.g. in icomplete.el. (Bug#11035)
3307
9af5ed87
PE
33082012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3311
d1f55f16
CY
33122012-03-12 Chong Yidong <cyd@gnu.org>
3313
3314 * eval.c (inhibit_lisp_code): Rename from
3315 inhibit_window_configuration_change_hook; move from window.c.
3316
3317 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3318 * window.c (run_window_configuration_change_hook)
3319 (syms_of_window): Callers changed.
3320
66c5eebd
CY
33212012-03-11 Chong Yidong <cyd@gnu.org>
3322
413df973
CY
3323 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3324
66c5eebd
CY
3325 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3326
1de11f56
CY
33272012-03-10 Chong Yidong <cyd@gnu.org>
3328
3329 * frame.c (other_visible_frames): Don't assume the selected frame
3330 is visible (Bug#10955).
3331
cae07000
SM
33322012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3333
3334 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3335
89c94350
JD
33362012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3337
3338 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3339 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3340 zero (Bug#10954).
3341
999dd333
GM
33422012-03-03 Glenn Morris <rgm@gnu.org>
3343
01a6dcc8 3344 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3345
de0100f2
EZ
33462012-03-02 Eli Zaretskii <eliz@gnu.org>
3347
3348 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3349 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3350 (redisplay_window, next_element_from_string): Fix typos in
3351 comments.
3e441275
EZ
3352 (redisplay_window): Pass to move_it_vertically the margin in
3353 pixels, not in screen lines.
de0100f2 3354
96a72ee9
GM
33552012-03-02 Glenn Morris <rgm@gnu.org>
3356
3357 * buffer.c (buffer-list-update-hook): Doc fix.
3358
312508d7
EZ
33592012-02-29 Eli Zaretskii <eliz@gnu.org>
3360
3361 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3362 push_it before setting up the iterator for the first overlay
3363 string, even if we have an empty string loaded.
3364 (next_overlay_string): If there's an empty string on the iterator
3365 stack, pop the stack. (Bug#10903)
3366
27f3c637
PE
33672012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3370 Suggested by Stefan Monnier in
3371 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3372 * alloc.c (widen_to_Lisp_Object): New static function.
3373 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3374 and widening them to Lisp_Objects. This would work even if
3375 USE_LSB_TAG is defined and wide integers are used, which might
3376 happen in a future version of Emacs.
3377
3c9dfce6
CY
33782012-02-25 Chong Yidong <cyd@gnu.org>
3379
fa74b241
CY
3380 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3381 Doc fix.
3382
3c9dfce6
CY
3383 * xselect.c (Fx_selection_exists_p): Doc fix.
3384 (x_clipboard_manager_save_all): Print an informative message
3385 before saving to clipboard manager.
3386
9486df08
CY
33872012-02-24 Chong Yidong <cyd@gnu.org>
3388
3389 * keyboard.c (process_special_events): Handle all X selection
3390 requests in kbd_buffer, not just the next one (Bug#8869).
3391
f01d3321
CY
33922012-02-23 Chong Yidong <cyd@gnu.org>
3393
3394 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3395 call when setting menu-bar-lines and tool-bar-lines parameters.
3396 (unwind_create_frame_1): New helper function.
3397
3398 * window.c (inhibit_window_configuration_change_hook): New var.
3399 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3400 (syms_of_window): Initialize it.
f01d3321 3401
86b847b6
CY
34022012-02-22 Chong Yidong <cyd@gnu.org>
3403
3404 * xterm.c (x_draw_image_relief): Add missing type check for
3405 Vtool_bar_button_margin (Bug#10743).
3406
a59225b1
CY
34072012-02-21 Chong Yidong <cyd@gnu.org>
3408
3409 * fileio.c (Vfile_name_handler_alist): Doc fix.
3410
3411 * buffer.c (Fget_file_buffer): Protect against invalid file
3412 handler return value.
3413
310f5bd4
PE
34142012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3415
cb3a28cc
PE
3416 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3417 when computing $valmask.
3418
310f5bd4
PE
3419 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3420 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3421 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3422 It's useless in that case, and it can cause problems on hosts
3423 that allocate halves of EMACS_INT values separately.
3424 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3425 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3426 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3427 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3428 it avoids undefined behavior on hosts where shifting right by more
3429 than the word width has undefined behavior.
3430
2375c96a
CY
34312012-02-19 Chong Yidong <cyd@gnu.org>
3432
3433 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3434 (Funhandled_file_name_directory, Ffile_name_as_directory)
3435 (Fdirectory_file_name, Fexpand_file_name)
3436 (Fsubstitute_in_file_name): Protect against invalid file handler
3437 return values (Bug#10845).
3438
3eb49e71
EZ
34392012-02-18 Eli Zaretskii <eliz@gnu.org>
3440
3441 * .gdbinit (pitx): Fix incorrect references to fields of the
3442 iterator stack.
3443
7b926f3f
CY
34442012-02-17 Chong Yidong <cyd@gnu.org>
3445
3446 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3447
11273115
PE
34482012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3449
3450 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3451 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3452
c3a70e2b
CY
34532012-02-15 Chong Yidong <cyd@gnu.org>
3454
3455 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3456 marked as special. Also, starting docstrings with * is obsolete.
3457
0ca43699
AS
34582012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3459
3460 * gnutls.c (emacs_gnutls_write): Fix last change.
3461
2e8f3c56
LI
34622012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3463
3464 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3465 send_process.
3466
af70074f
SM
34672012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3468
3469 * keymap.c (Fsingle_key_description): Handle char ranges.
3470
95986d52
CY
34712012-02-12 Chong Yidong <cyd@gnu.org>
3472
afd83bd1
CY
3473 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3474 as that creates a dangerous corner case.
3475
95986d52
CY
3476 * window.c (Fdelete_window_internal): Invalidate the mouse
3477 highlight (Bug#9904).
3478
bd7da63e
GM
34792012-02-12 Glenn Morris <rgm@gnu.org>
3480
3481 * xselect.c (Fx_own_selection_internal)
3482 (Fx_get_selection_internal, Fx_disown_selection_internal)
3483 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3484 * nsselect.m (Fx_own_selection_internal)
3485 (Fx_disown_selection_internal, Fx_selection_exists_p)
3486 (Fx_selection_owner_p, Fx_get_selection_internal):
3487 Sync docs and argument specs with the xselect.c versions.
3488
77abcbc2
LI
34892012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3490
3491 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3492
90b671e2
EZ
34932012-02-11 Eli Zaretskii <eliz@gnu.org>
3494
1c0ca0b7
EZ
3495 * w32select.c (Fx_selection_exists_p): Sync doc string and
3496 argument list with xselect.c. (Bug#10783)
3497
3498 * w16select.c (Fx_selection_exists_p): Sync doc string and
3499 argument list with xselect.c. (Bug#10783)
90b671e2 3500
49241268
GM
35012012-02-10 Glenn Morris <rgm@gnu.org>
3502
3503 * fns.c (Fsecure_hash): Doc fix.
3504
f998bbe7 35052012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3506
3507 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3508
0992bd9c
CY
35092012-02-07 Chong Yidong <cyd@gnu.org>
3510
3511 * buffer.c (Fbuffer_local_variables)
3512 (buffer_lisp_local_variables): Handle unbound vars correctly;
3513 don't let Qunbound leak into Lisp.
3514
af008560
GM
35152012-02-07 Glenn Morris <rgm@gnu.org>
3516
dd605cc4
GM
3517 * image.c (Fimagemagick_types): Doc fix.
3518
af008560
GM
3519 * image.c (imagemagick-render-type): Change it from a lisp object
3520 to an integer. Move the doc here from the lisp manual.
3521 Treat all values not equal to 0 the same.
3522
1449fa1d
CY
35232012-02-06 Chong Yidong <cyd@gnu.org>
3524
3525 * doc.c (store_function_docstring): Avoid applying docstring of
3526 alias to base function (Bug#2603).
3527
3723ec07
AS
35282012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3529
3530 * .gdbinit (pp1, pv1): Remove redundant defines.
3531 (pr): Use pp.
3532
79c1cc1e
CY
35332012-02-04 Chong Yidong <cyd@gnu.org>
3534
3535 * nsterm.m: Declare a global (Bug#10694).
3536
d7f29f8e
EZ
35372012-02-04 Eli Zaretskii <eliz@gnu.org>
3538
cae07000
SM
3539 * w32.c (get_emacs_configuration_options):
3540 Include --enable-checking, if specified, in the return value.
d7f29f8e 3541
3b95a6f9
MR
35422012-02-04 Martin Rudalics <rudalics@gmx.at>
3543
3544 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3545 after rounding frame sizes. (Bug#9723)
3546
d6fa96a6
EZ
35472012-02-04 Eli Zaretskii <eliz@gnu.org>
3548
3549 * keyboard.c (adjust_point_for_property): Don't position point
3550 before BEGV. (Bug#10696)
3551
df0b2940
PE
35522012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 Handle overflow when computing char display width (Bug#9496).
3555 * character.c (char_width): Return EMACS_INT, not int.
3556 (char_width, c_string_width): Check for overflow when
3557 computing the width; this is possible now that individual
3558 characters can have unbounded width. Problem introduced
3559 by merge from Emacs 23 on 2012-01-19.
3560
6bee44d6
MA
35612012-02-02 Michael Albinus <michael.albinus@gmx.de>
3562
3563 * dbusbind.c (Fdbus_register_method): Mention the return value
3564 :ignore in the docstring.
3565
44f92739
GM
35662012-02-02 Glenn Morris <rgm@gnu.org>
3567
1b9f60cc
GM
3568 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3569
44f92739
GM
3570 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3571 Unconditionally set to t. (Bug#10673)
3572 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3573 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3574 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3575
c5d3843c
KH
35762012-02-02 Kenichi Handa <handa@m17n.org>
3577
3578 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3579 0, do not call append_composite_glyph.
3580
159462d4 35812012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3582
3583 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3584 NULL (Bug#6988).
3585 (x_produce_glyphs): If the component of a composition is a null
3586 string, set it->pixel_width to 1 to avoid zero-width glyph.
3587
78cef877
EZ
35882012-02-01 Eli Zaretskii <eliz@gnu.org>
3589
3590 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3591 first 2 arguments are identical. This makes inserting large
3592 output from a subprocess an order of magnitude faster on
3593 MS-Windows, where all sbrk'ed memory is always contiguous.
3594
97897668
GM
35952012-01-31 Glenn Morris <rgm@gnu.org>
3596
3597 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3598 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3599 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3600
31fd3586
GM
36012012-01-29 Glenn Morris <rgm@gnu.org>
3602
3603 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3604
0e24a8b2
CY
36052012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3606
3607 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3608
cc0adcb0
CY
36092012-01-28 Chong Yidong <cyd@gnu.org>
3610
3611 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3612
acc28cb9
CY
36132012-01-26 Chong Yidong <cyd@gnu.org>
3614
9c69cfb7
CY
3615 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3616
acc28cb9
CY
3617 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3618 repeat counts (Bug#10507).
3619
48da7392
GM
36202012-01-26 Glenn Morris <rgm@gnu.org>
3621
3622 * lread.c (syms_of_lread): Doc fix.
3623
14af5f7f
CY
36242012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3625
3626 * coding.c (encode_designation_at_bol): Change return value to
3627 EMACS_INT.
3628
0b21c100
CY
36292012-01-25 Chong Yidong <cyd@gnu.org>
3630
3631 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3632
3c2907f7
CY
36332012-01-21 Chong Yidong <cyd@gnu.org>
3634
3635 * floatfns.c (Fcopysign): Make the second argument non-optional,
3636 since nil is not allowed anyway.
3637
959ad23f
AS
36382012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3641 (send_process): Likewise.
3642
34a02f46
MR
36432012-01-19 Martin Rudalics <rudalics@gmx.at>
3644
3645 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3646 (Vwindow_persistent_parameters): Do not use Qstate.
3647 Rewrite doc-strings.
34a02f46 3648
1259009a 36492012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3650
3651 * character.c (char_width): New function.
70d4fdf6
GM
3652 (Fchar_width, c_string_width, lisp_string_width):
3653 Use char_width (Bug#9496).
25ed9e61 3654
6a6ee00d
MR
36552012-01-16 Martin Rudalics <rudalics@gmx.at>
3656
3657 * window.c (Vwindow_persistent_parameters): New variable.
3658 (Fset_window_configuration, save_window_save): Handle persistent
3659 window parameters.
3660
c85efaf7
EZ
36612012-01-14 Eli Zaretskii <eliz@gnu.org>
3662
3663 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3664 thrashing the stack of the thread. (Bug#9087)
3665
5944709e
PE
36662012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3669
e71f5d99
EZ
36702012-01-11 Eli Zaretskii <eliz@gnu.org>
3671
3672 * xdisp.c (rows_from_pos_range): Handle the case where the
3673 highlight ends on a newline. (Bug#10464)
3674 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3675 he end column for display of highlight that ends on a newline
3676 before a R2L line.
3677
ce316182
GM
36782012-01-11 Glenn Morris <rgm@gnu.org>
3679
3680 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3681 from load-path also when installation-directory is nil. (Bug#10208)
3682
5b43da69
GM
36832012-01-10 Glenn Morris <rgm@gnu.org>
3684
74cc8ff9
GM
3685 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3686
7d8d6e4e
GM
3687 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3688 Update template values to be closer to their typical values these days.
5b43da69 3689
a0db8d43
EZ
36902012-01-09 Eli Zaretskii <eliz@gnu.org>
3691
3692 * xdisp.c (rows_from_pos_range): Accept additional argument
3693 DISP_STRING, and accept any glyph in a row whose object is that
3694 string as eligible for mouse highlight. Fixes mouse highlight of
3695 display strings from overlays. (Bug#10464)
3696
9a0115ab 36972012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3698
b9110d6a 3699 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3700 * fileio.c (auto_saving_dir_umask): New static var.
3701 (Fmake_directory_internal): Use it.
3702 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3703 creating the directory. The old code temporarily assigns
3704 too-generous permissions to the directory.
3705 (do_auto_save_eh): Clear it.
b9110d6a 3706 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3707 that the var is always cleared.
3708
6c1bd3f3
EZ
37092012-01-07 Eli Zaretskii <eliz@gnu.org>
3710
3711 * search.c (scan_buffer): Pass character positions to
3712 know_region_cache, not byte positions. (Bug#6540)
3713
069d2b50
L
37142012-01-07 LynX <_LynX@bk.ru> (tiny change)
3715
3716 * w32.c (sys_rename): Report EXDEV when rename of a directory
3717 fails because the target is on another logical disk. (Bug#10284)
3718
75bf0d33
DB
37192012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3720
3721 * xterm.c (x_embed_request_focus): New function.
3722
3723 * xterm.h: Add prototype.
3724
3725 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3726
1c6e5a32
GM
37272012-01-05 Glenn Morris <rgm@gnu.org>
3728
3729 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3730
651e947e
EZ
37312012-01-01 Eli Zaretskii <eliz@gnu.org>
3732
3733 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3734 Load gnutls_transport_set_lowat only if GnuTLS version is below
3735 2.11.1.
3736 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3737 GnuTLS versions below 2.11.1.
3738
3778cdd8
AL
37392011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3740
3741 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3742 to the doc string advising against its use for altering the way
3743 windows are scrolled.
3744
0e5317f7
KH
37452011-12-28 Kenichi Handa <handa@m17n.org>
3746
3747 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3748 coding-system ASCII compatible only when it does not produce BOM
3749 on encoding (Bug#10383).
3750
93d5ca1f
JD
37512011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3752
3753 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3754 can scroll.
3755 (create_and_show_popup_menu): Always use menu_position_func for
3756 Gtk3 (Bug#10361).
3757
ca22b785
AS
37582011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3759
3760 * callint.c (Fcall_interactively): Don't truncate prompt string.
3761
d048e1e6
EZ
37622011-12-23 Eli Zaretskii <eliz@gnu.org>
3763
3764 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3765 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3766 resumed from there (after widening). (Bug#10360)
d048e1e6 3767
5ccaba1f
JD
37682011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3769
3770 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3771
204ee57f
JD
37722011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3773
b81d40f0
JB
3774 * nsterm.m (x_free_frame_resources):
3775 Release f->output_data.ns->miniimage.
204ee57f
JD
3776 (ns_index_color): Fix indentation. Do not retain
3777 color_table->colors[i].
3778
3779 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3780 before returning.
3781
3782 * nsfns.m (x_set_background_color): Assign return value from
3783 ns_index_color to face-background instead of NSColor*.
3784 (ns_implicitly_set_icon_type): Fix indentation.
3785 Change assignment in for loop to comparison.
3786
3787 * emacs.c (ns_pool): New variable.
3788 (main): Assign ns_pool.
3789 (Fkill_emacs): Call ns_release_autorelease_pool.
3790
3791 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3792 autorelease fdesc, release fdAttrs and tdict.
3793 (ns_get_covering_families): Release charset.
3794 (ns_findfonts): Release NSFontDescriptor created with new.
3795 (ns_uni_to_glyphs): Fix indentation.
3796 (setString): Release attrStr before assigning new value.
3797
c803b2b7
JD
37982011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3799
678f4426
JD
3800 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3801 and NS_IMPL_COCOA.
3802 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3803 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3804
cd394be1 38052011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3806
5fecd5fc
JD
3807 * nsterm.m (ns_term_init): Subscribe for notifications
3808 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3809 to method trackingNotification in EmacsMenu.
3810
3811 * nsmenu.m (trackingMenu): New variable.
3771cb17 3812 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3813 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3814 from Aquamacs (Bug#7030).
678f4426
JD
3815
38162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3817
c803b2b7
JD
3818 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3819 (symbol_to_nsstring): Fix indentation.
3820 (ns_symbol_to_pb): New function.
cae07000
SM
3821 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3822 (Fns_rotate_cut_buffers_internal): Remove.
3823 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3824 Fns_store_cut_buffer_internal.
3825 (ns_get_foreign_selection, Fx_own_selection_internal)
3826 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3827 (Fns_get_selection_internal, Fns_store_selection_internal):
3828 Use ns_symbol_to_pb and check if return value is nil.
3829 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3830 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3831 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3832 renamed to Sns_store_selection_internal.
3833 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3834 and remove this function.
3835 (ns_handle_selection_clear): Remove, never used.
3836 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3837 here.
3838
e1b01a3a
KB
38392011-12-17 Ken Brown <kbrown@cornell.edu>
3840
3841 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3842 GID is unknown (Bug#10257).
3843
2adb6e85
PE
38442011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3847 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3848 which caused a build failure on GNU/Linux IA-64. This problem was
3849 introduced by my 2011-10-07 patch.
3850
d1d7b339
JL
38512011-12-15 Juri Linkov <juri@jurta.org>
3852
3853 * image.c (imagemagick_error): New function. (Bug#10112)
3854 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3855 Use `imagemagick_error' where ImageMagick functions return
3856 `MagickFalse'.
3857 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3858 proper order.
3859
100d5755
KH
38602011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3861
3862 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3863 fill background (Bug#8992).
3864
454592a6
MR
38652011-12-13 Martin Rudalics <rudalics@gmx.at>
3866
3867 * window.c (Vwindow_combination_resize)
3868 (Vwindow_combination_limit): Use t instead of non-nil in
3869 doc-strings.
61d4b438
MR
3870 (Vrecenter_redisplay): Add first sentence of doc-string on
3871 separate line.
53524d93 3872 (Frecenter): Fix doc-string typo.
454592a6 3873
3633e3aa
KH
38742011-12-11 Kenichi Handa <handa@m17n.org>
3875
3876 * coding.c (Funencodable_char_position): Pay attention to the
3877 buffer text relocation (Bug#9389).
3878
7b9d523a 38792011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3880
7b9d523a
JD
3881 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3882 gtk_init (Bug#10100).
3883
b73189c6
EZ
38842011-12-10 Eli Zaretskii <eliz@gnu.org>
3885
3886 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3887 IT->string is nil. (Bug#10263)
3888
f7dfe5d6
JD
38892011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3890
83faebb4
JD
3891 * nsterm.h (x_free_frame_resources): Declare.
3892
f7dfe5d6
JD
3893 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3894 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3895
3896 * nsterm.h (ns_get_defaults_value): Declare.
3897
3898 * nsterm.m (ns_default): Call ns_get_defaults_value.
3899
7cd4e72c
EZ
39002011-12-09 Eli Zaretskii <eliz@gnu.org>
3901
3902 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3903 (Bug#10170)
3904
b34d7317
YM
39052011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3906
3907 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3908 that where the value of an _OBJC_* symbol points to is in the .bss
3909 section (Bug#10240).
3910
76470ad1
KH
39112011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3912
3913 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3914 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3915
745fff94
KH
39162011-12-08 Kenichi Handa <handa@m17n.org>
3917
3918 * ftfont.c (get_adstyle_property): Fix previous change
3919 (Bug#10233).
3920
6e44397c
JB
39212011-12-07 Juanma Barranquero <lekktu@gmail.com>
3922
3923 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3924 dirs from the default value of EMACSLOADPATH (bug#10208).
3925
7efa6272
GM
39262011-12-07 Glenn Morris <rgm@gnu.org>
3927
3928 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3929 installation and source directories as well. (Bug#10208)
3930
f6fc4d87
CY
39312011-12-06 Chong Yidong <cyd@gnu.org>
3932
3933 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3934
2bf26180
GM
39352011-12-06 Glenn Morris <rgm@gnu.org>
3936
3937 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3938 as an error, not just -1. (Bug#10217)
3939
3a6ad4f0
CY
39402011-12-05 Chong Yidong <cyd@gnu.org>
3941
3942 * keyboard.c (process_special_events): New function.
3943 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3944
75a3b399
PE
39452011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3946
3947 * coding.c (encode_designation_at_bol): Don't use uninitialized
3948 local variable (Bug#9318).
3949
c3c9e25e
KH
39502011-12-05 Kenichi Handa <handa@m17n.org>
3951
3952 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3953 return Qnil (Bug#8046, Bug#10193).
3954
5eb05ea3
KH
39552011-12-05 Kenichi Handa <handa@m17n.org>
3956
3957 * coding.c (encode_designation_at_bol): New args charbuf_end and
3958 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3959 (coding_set_source): Return how many bytes coding->source was
3960 relocated.
3961 (coding_set_destination): Return how many bytes
3962 coding->destination was relocated.
3963 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3964 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3965
39662011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3967
3968 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3969 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3970 macro (Bug#9318).
3971
39722011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3973
3974 The following changes are to fix Bug#9318.
3975
a79703f5 3976 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3977 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3978 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3979 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3980
7dbda6df
JB
39812011-12-05 Juanma Barranquero <lekktu@gmail.com>
3982
3983 * lisp.h (process_quit_flag): Fix external declaration.
3984
6d5eb5b0
SM
39852011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 Don't macro-inline non-performance-critical code.
3988 * eval.c (process_quit_flag): New function.
3989 * lisp.h (QUIT): Use it.
3990
a0c3fad0
JD
39912011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3992
3993 * nsfns.m (get_geometry_from_preferences): New function.
3994 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3995
6c07aac2
AS
39962011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3997
3998 * emacs.c (Qkill_emacs): Define.
3999 (syms_of_emacs): Initialize it.
4000 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4001 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4002 (quit_throw_to_read_char): Add parameter `from_signal'.
4003 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4004 * lisp.h (QUIT): Call Fkill_emacs if requested.
4005
c052ead4
JD
40062011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4007
4008 * widget.c (update_wm_hints): Return if wmshell is null.
4009 (widget_update_wm_size_hints): New function.
4010
4011 * widget.h (widget_update_wm_size_hints): Declare.
4012
4013 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4014 widget_update_wm_size_hints (Bug#10104).
4015
9e49252b
EZ
40162011-12-03 Eli Zaretskii <eliz@gnu.org>
4017
4018 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4019 before a newline, prepare the bidi iterator for consuming the
4020 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4021 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4022
02b16839
JL
40232011-12-02 Juri Linkov <juri@jurta.org>
4024
4025 * search.c (Fword_search_regexp): New Lisp function created from
4026 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4027 (Fword_search_backward, Fword_search_forward)
4028 (Fword_search_backward_lax, Fword_search_forward_lax):
4029 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4030 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4031
0068070e
SM
40322011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4033
4034 * fileio.c (Finsert_file_contents): Move after-change-function call
4035 to before the "handled:" label, since all "goto handled" appear in
4036 cases where the *-change-functions have already been properly called
4037 (bug#10117).
4038
3360a3fc
AS
40392011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4040
4041 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4042 waiting for input. (Bug#10169)
4043
73d6c093
EZ
40442011-11-30 Eli Zaretskii <eliz@gnu.org>
4045
4046 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4047 verifies glyph row's hash code--we have just reallocated the
4048 glyphs, so their contents can be complete garbage. (Bug#10164)
4049
febe6bea
JB
40502011-11-30 Juanma Barranquero <lekktu@gmail.com>
4051
4052 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4053
801a4313
EZ
40542011-11-30 Eli Zaretskii <eliz@gnu.org>
4055
4056 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4057 attributes are tested _before_ calling verify_row_hash, to protect
4058 against GCC re-ordering of the tests. (Bug#10164)
4059
2b56b87e
JD
40602011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4061
4062 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4063
4064 * xterm.c (handle_one_xevent): Only set async_visible and friends
4065 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4066 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4067 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4068
dbf31225
PE
40692011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4070
4071 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4072 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4073 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4074 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4075 All uses changed to use GCPRO1 etc.
4076 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4077 Revert to old implementation (i.e., before 2011-03-11).
4078
1305621b
YM
40792011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4080
4081 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4082 of scroll runs so as to avoid assigning disabled bogus rows and
4083 unnecessary graphics copy operations.
4084
8c9afb46
EZ
40852011-11-27 Eli Zaretskii <eliz@gnu.org>
4086
4087 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4088 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4089 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4090 (malloc, free, realloc, calloc): Redirect to e_* only when
4091 compiling Emacs.
4092
4093 * lisp.h (GCTYPEBITS): Move before first use.
4094 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4095 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4096 this macro definition.
4097
4098 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4099 _MSC_VER.
4100
54e9e3bf
JD
41012011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4102
6d5eb5b0
SM
4103 * gtkutil.c (xg_create_frame_widgets):
4104 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4105 present with Gtk+ 2.0.
4106
83aca1cb
PE
41072011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 * fileio.c (Finsert_file_contents): Undo previous change; see
4110 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4111
5b76caa4
PE
41122011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 Rename locals to avoid shadowing.
4115 * fileio.c (Finsert_file_contents):
4116 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4117 * process.c (wait_reading_process_output):
4118 Rename inner 'proc' to 'p' to avoid shadowing.
4119 Indent for consistency with usual Emacs style.
4120
8c535114
EZ
41212011-11-25 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xdisp.c (redisplay_window): If cursor row is not fully visible
4124 after recentering, and scroll-conservatively is set to a large
4125 number, scroll window by a few more lines to make the cursor fully
4126 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4127 (start_display): Don't move to the next line if the display should
4128 start at a newline that is part of a display vector or an overlay
4129 string. (Bug#10119)
8c535114 4130
fa4fdb5c
JL
41312011-11-24 Juri Linkov <juri@jurta.org>
4132
4133 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4134 after the `MagickPingImage' call. (Bug#10112)
4135
90ec88df
CY
41362011-11-23 Chong Yidong <cyd@gnu.org>
4137
4138 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4139
56e2e794
MR
41402011-11-23 Martin Rudalics <rudalics@gmx.at>
4141
4142 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4143 making another buffer current. (Bug#10114)
4144
b6e64c41
GM
41452011-11-23 Glenn Morris <rgm@gnu.org>
4146
4147 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4148
6b21de18
CY
41492011-11-23 Chong Yidong <cyd@gnu.org>
4150
4151 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4152 using it (Bug#5984).
4153
b12cd789
EZ
41542011-11-22 Eli Zaretskii <eliz@gnu.org>
4155
4156 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4157 and header-lines, as they don't have one computed for them.
4158 (Bug#10098)
4159
4160 * .gdbinit (prow): Make displayed values more self-explaining.
4161 Add row's hash code.
4162
261b6fd4
LMI
41632011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4164
4165 * process.c (wait_reading_process_output): Fix asynchrounous
4166 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4167 (wait_reading_process_output): Add comment and URL.
261b6fd4 4168
e7cfd277
JD
41692011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4170
4171 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4172
a9b9b7f5
CY
41732011-11-21 Chong Yidong <cyd@gnu.org>
4174
4175 * window.c (Fnext_window, Fprevious_window): Doc fix.
4176
b0d15b4f
SM
41772011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4178
4179 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4180
fe7a3057
JB
41812011-11-20 Juanma Barranquero <lekktu@gmail.com>
4182
4183 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4184
d2999b1a
MR
41852011-11-20 Martin Rudalics <rudalics@gmx.at>
4186
4187 * window.c (Fset_window_combination_limit): Rename argument
4188 STATUS to LIMIT.
4189 (Vwindow_combination_limit): Remove "status" from doc-string.
4190
d5ff9cd0
AS
41912011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4192
4193 * m/ibms390.h: Remove.
4194 * m/ibms390x.h: Don't include "ibms390.h".
4195
a5bb9bd3
SM
41962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4197
4198 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4199 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4200
cd1181db
JB
42012011-11-20 Juanma Barranquero <lekktu@gmail.com>
4202
4203 * casetab.c (Fset_case_table):
4204 * charset.c (Fcharset_after): Fix typos.
4205
615a3b8d 42062011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4207
17e845af
PE
4208 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4209 Otherwise, valgrind does not work on some platforms.
4210 Problem reported by Andreas Schwab in
6a0bf43d
PE
4211 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4212 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4213 is set, removing the need for VIRT_ADDRESS_VARIES.
4214 (PURE_P): Use a more-efficient implementation that needs just one
4215 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4216 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4217 to 4 (xorl, subq, cmpq, setbe).
4218 * alloc.c (pure): Always extern now, since that's the
4219 VIRT_ADDR_VARIES behavior.
4220 (PURE_POINTER_P): Use a single comparison, not two, for
4221 consistency with the new puresize.h.
4222 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4223 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4224 Remove VIRT_ADDR_VARIES no longer needed.
4225
f8fe6f96
EZ
42262011-11-19 Eli Zaretskii <eliz@gnu.org>
4227
4228 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4229 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4230 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4231 behave as if the cursor position were at the window margin.
4232
4233 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4234 and the cursor position is out of bounds, behave as if the cursor
4235 position were at the window margin. (Bug#10075)
4236
df05a53c
CY
42372011-11-18 Chong Yidong <cyd@gnu.org>
4238
4239 * window.c (Fwindow_combination_limit): Make first argument
4240 non-optional, since it is meaningless for live windows like the
4241 selected window.
61ccba97 4242
2071918e
DA
42432011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4244
4245 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4246
b50a28de
SM
42472011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4248
4249 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4250 (graft_intervals_into_buffer): Simplify.
4251
015137db
EZ
42522011-11-18 Eli Zaretskii <eliz@gnu.org>
4253
4254 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4255 hash values of the two rows.
4256 (copy_row_except_pointers): Preserve the used[] arrays and the
4257 hash values of the two rows. (Bug#10035)
68c95424 4258 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4259
4260 * xdisp.c (row_hash): New function, body extracted from
4261 compute_line_metrics.
4262 (compute_line_metrics): Call row_hash, instead of computing the
4263 hash code inline.
4264
4265 * dispnew.c (verify_row_hash): Call row_hash for computing the
4266 hash code of a row, instead of duplicating code from xdisp.c.
4267
4268 * dispextern.h (row_hash): Add prototype.
4269
a2addb04
TH
42702011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4271
4272 * frame.c (delete_frame): Don't delete the terminal when the last
4273 X frame is closed if emacs is built with GTK toolkit.
4274
df85d315
JB
42752011-11-17 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4278
a0c2d0ae
MR
42792011-11-17 Martin Rudalics <rudalics@gmx.at>
4280
4281 * window.c (Vwindow_splits): Rename to
4282 Vwindow_combination_resize. Suggested by Juri Linkov.
4283 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4284 of Vwindow_splits.
4285
58179cce
JB
42862011-11-16 Juanma Barranquero <lekktu@gmail.com>
4287
7877f373
JB
4288 * nsfns.m (Fns_font_name):
4289 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4290
b6f67890
MR
42912011-11-16 Martin Rudalics <rudalics@gmx.at>
4292
4293 * window.h (window): Rename slot "nest" to "combination_limit".
4294 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4295 (Fset_window_nest): Rename to Fset_window_combination_limit.
4296 (Vwindow_nest): Rename to Vwindow_combination_limit.
4297 (recombine_windows, make_parent_window, make_window)
4298 (Fsplit_window_internal, saved_window)
4299 (Fset_window_configuration, save_window_save): Rename all
4300 occurrences of window_nest to window_combination_limit.
4301
c7015153
JB
43022011-11-15 Juanma Barranquero <lekktu@gmail.com>
4303
4304 * image.c (imagemagick_load_image): Fix typo.
4305
322ad6ec
EZ
43062011-11-14 Eli Zaretskii <eliz@gnu.org>
4307
4308 * xdisp.c (display_line): Move the call to
4309 highlight_trailing_whitespace before the call to
4310 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4311 faces of all the glyphs to compute ROW's hash value.
4312 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4313
f067b8ec
JB
43142011-11-14 Juanma Barranquero <lekktu@gmail.com>
4315
4316 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4317 just return (bug#10044).
4318
1e5b2111
EZ
43192011-11-12 Eli Zaretskii <eliz@gnu.org>
4320
7ef3cbd5
EZ
4321 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4322 with user-defined heap size. Bump the default size of the temacs
4323 heap to 27MB, to avoid memory warning when running temacs.
4324 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4325
1e5b2111
EZ
4326 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4327 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4328 (verify_row_hash) [XASSERTS]: New function.
4329 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4330 that the hash value of glyph rows is correct.
1e5b2111 4331
89d61221
MR
43322011-11-12 Martin Rudalics <rudalics@gmx.at>
4333
4334 * window.h (window): Remove splits slot.
4335 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4336 (Fdelete_other_windows_internal, make_parent_window)
4337 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4338 (Fset_window_configuration, save_window_save): Don't deal with
4339 split status of windows.
4340 (saved_window): Remove splits slot.
4341 (Vwindow_splits): Rewrite doc-string.
4342
97f18cc8
JD
43432011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4344
4345 * xfns.c (unwind_create_frame):
4346 * nsfns.m (unwind_create_frame):
4347 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4348 Vframe_list (Bug#9999).
4349
22a648b4
DA
43502011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4351
0b381c7e 4352 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4353
659afede
KH
43542011-11-11 Kenichi Handa <handa@m17n.org>
4355
4356 * callproc.c (Fcall_process): Set the member dst_multibyte of
4357 process_coding.
4358
9ac0394b
KH
43592011-11-11 Johan Bockgård <bojohan@gnu.org>
4360
4361 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4362 avoid a crash (bug#9496).
4363
2fbdc249
CY
43642011-11-09 Chong Yidong <cyd@gnu.org>
4365
4366 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4367 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4368
ac6b1f81
PE
43692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4372
09db192c
PE
43732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 Avoid some portability problems by eschewing 'extern inline' functions.
4376 The trivial performance wins aren't worth the portability hassles; see
4377 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4378 et seq.
4379 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4380 (window_box_width, window_box_left, window_box_left_offset)
4381 (window_box_right, window_box_right_offset): Undo previous change,
4382 by removing the "extern"s.
4383 * intervals.c (adjust_intervals_for_insertion)
4384 (adjust_intervals_for_deletion): Undo previous change,
4385 making these static again.
4386 (offset_intervals, temp_set_point_both, temp_set_point)
4387 (copy_intervals_to_string): No longer inline.
4388 * xdisp.c (window_text_bottom_y, window_box_width)
4389 (window_box_height, window_box_left_offset)
4390 (window_box_right_offset, window_box_left, window_box_right)
4391 (window_box): No longer inline.
4392
105216ed
CY
43932011-11-08 Chong Yidong <cyd@gnu.org>
4394
4395 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4396 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4397 Signal an error if not a live window.
105216ed
CY
4398 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4399 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4400
ae9e237f
JB
44012011-11-07 Juanma Barranquero <lekktu@gmail.com>
4402
4403 * lisp.h (syms_of_abbrev): Remove declaration.
4404 Reported by CHENG Gao <chenggao@royau.me>.
4405
c7aa8333
EZ
44062011-11-07 Eli Zaretskii <eliz@gnu.org>
4407
4408 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4409 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4410 of temacs in GUI mode.
4411
be7f5545
MR
44122011-11-07 Martin Rudalics <rudalics@gmx.at>
4413
4414 * window.h: Declare delete_all_child_windows instead of
4415 delete_all_subwindows.
4416 * window.c (Fwindow_nest, Fset_window_nest)
4417 (Fset_window_new_total, Fset_window_new_normal)
4418 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4419 (delete_all_subwindows): Rename to delete_all_child_windows.
4420 (Fdelete_other_windows_internal, Fset_window_configuration):
4421 Call delete_all_child_windows instead of delete_all_subwindows.
4422 * frame.c (delete_frame): Call delete_all_child_windows instead
4423 of delete_all_subwindows.
4424
ca78dc43
PE
44252011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4426
4427 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4428 This is also needed for porting to any host where GC_MARK_STACK is
4429 not GC_MAKE_GCPROS_NOOPS.
4430 (which_symbols): Use it.
4431
a0241d01
KH
44322011-11-07 Kenichi Handa <handa@m17n.org>
4433
4434 * coding.c (coding_set_destination): Check coding->src_pos only
4435 when coding->src_object is a buffer (bug#9910).
4436
4437 * process.c (send_process): Set the member src_multibyte of coding
4438 to 0 (bug#9911) when sending a unibyte text.
4439
4440 * callproc.c (Fcall_process): Set the member src_multibyte of
4441 process_coding to 0 (bug#9912).
4442
a64bfdfa 44432011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4444
4445 * xmenu.c (cleanup_widget_value_tree): New function.
4446 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4447 calling free_menubar_widget_value_tree directly (Bug#9830).
4448
cb41b32a
PE
44492011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 Fix some portability problems with 'inline'.
4452 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4453 (window_box_width, window_box_left, window_box_left_offset)
4454 (window_box_right, window_box_right_offset): Declare extern.
4455 Otherwise, these inline functions do not conform to C99 and
4456 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4457 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4458 * intervals.c (adjust_intervals_for_insertion)
4459 (adjust_intervals_for_deletion): Now extern, because otherwise the
4460 extern inline functions 'offset_intervals' couldn't refer to it.
4461 (static_offset_intervals): Remove.
4462 (offset_intervals): Rewrite using the old contents of
4463 static_offset_intervals. The old version didn't conform to C99
4464 because an extern inline function contained a reference to an
4465 identifier with static linkage.
4466
b7041366
AS
44672011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4468
4469 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4470 GC.
4471
88a37c4d
EZ
44722011-11-06 Eli Zaretskii <eliz@gnu.org>
4473
4474 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4475 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4476 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4477 return Qleft_to_right.
4478
49745b39
CY
44792011-11-06 Chong Yidong <cyd@gnu.org>
4480
4481 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4482 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4483 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4484 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4485 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4486 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4487 (Fwindow_vscroll): Doc fix.
4488 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4489 argument, since it makes no sense to pass a live window and for
4490 consistency with window-child.
4491
1f05cd82
CS
44922011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4493
4494 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4495 support MSVC.
4496
22610910
JR
44972011-11-05 Jason Rumney <jasonr@gnu.org>
4498
4499 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4500 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4501 fonts (Bug#6029).
4502 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4503 bitwise arithmetic preventing use of unicode-sip and non-truetype
4504 opentype fonts.
4505
a06776b2
EZ
45062011-11-05 Eli Zaretskii <eliz@gnu.org>
4507
3ad924ba
EZ
4508 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4509 "emacs"-only part.
4510
a06776b2
EZ
4511 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4512 initialization code to keep similarity to xfns.c after changes
4513 from 2011-11-05.
4514
c9e7db78
JD
45152011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4516
a97f8f3f
JD
4517 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4518 (unwind_create_frame): New function (Bug#9943).
4519 (Fx_create_frame): Restructure code to be more similar to the one in
4520 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4521 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4522 Move terminal->reference_count++ just before making the frame official
4523 (Bug#9943).
4524
4525 * nsterm.m (x_free_frame_resources): New function.
4526 (x_destroy_window): Move code to x_free_frame_resources.
4527
c9e7db78 4528 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4529 (Fx_create_frame, x_create_tip_frame):
4530 Move terminal->reference_count++ just before making the frame
75f1671a 4531 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4532 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4533
a6fc3b5c
EZ
45342011-11-05 Eli Zaretskii <eliz@gnu.org>
4535
4536 Support MSVC build with newer versions of Visual Studio.
4537 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4538 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4539 nt/gmake.defs.
4540
4541 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4542 which are not supported by MSVC.
4543 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4544 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4545 bitfields.
4546 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4547 types in bitfields.
4548 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4549
4550 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4551
58179cce 45522011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4553
4554 Support MSVC build with newer versions of Visual Studio.
4555 * w32.c: Don't include w32api.h for MSVC.
4556 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4557
4558 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4559 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4560 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4561 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4562 e_* cousins.
4563 (alloca) [_MSC_VER]: Define to _alloca.
4564
4565 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4566
4567 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4568
a58c13ed
EZ
45692011-11-04 Eli Zaretskii <eliz@gnu.org>
4570
4571 * xdisp.c (note_mouse_highlight): If either of
4572 previous/next-single-property-change returns nil, treat that as
4573 the beginning or the end of the buffer. (Bug#9955)
4574
fe0b6370
JD
45752011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4576
a58c13ed 4577 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4578 label is not null (Bug#9951).
4579 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4580 may be NULL.
4581
89bd5ee1
EZ
45822011-11-04 Eli Zaretskii <eliz@gnu.org>
4583
4584 * window.c (Fwindow_body_size): Mention in the doc string that the
4585 return value is in frame's canonical units. (Bug#9949)
4586
84c3edb9
EZ
45872011-11-03 Eli Zaretskii <eliz@gnu.org>
4588
4e2fb5c7
EZ
4589 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4590
84c3edb9 4591 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4592 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4593 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4594
bc17a887
EZ
45952011-11-01 Eli Zaretskii <eliz@gnu.org>
4596
4597 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4598 Don't stop backward scan on the continuation glyph, even though
4599 its CHARPOS is positive.
6d5eb5b0
SM
4600 (mouse_face_from_buffer_pos, note_mouse_highlight):
4601 Rename cover_string to disp_string.
bc17a887 4602
4ee88440
MR
46032011-11-01 Martin Rudalics <rudalics@gmx.at>
4604
4605 * window.c (temp_output_buffer_show): Don't use
4606 Vtemp_buffer_show_specifiers.
4607 (Vtemp_buffer_show_specifiers): Remove unused variable.
4608
c2ff3c02
EZ
46092011-10-30 Eli Zaretskii <eliz@gnu.org>
4610
4611 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4612 past the beginning of the current glyph matrix.
4613
58179cce 46142011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4615
4616 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4617 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4618 HAVE_GTK3 (Bug#9869).
b77a6a7f 4619
3b574623
JD
4620 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4621 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4622
b77a6a7f
JD
4623 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4624
4625 * xterm.c: Declare x_handle_net_wm_state to return int.
4626 (handle_one_xevent): Check if we are iconified but don't have
4627 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4628 (get_current_wm_state): Return non-zero if not hidden,
4629 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4630 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4631 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4632 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4633
196e41e4
PE
46342011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4635
4636 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4637 so that this new function doesn't get optimized away by a
4638 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4639
021f2e1a
AS
46402011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4641
4642 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4643
8b058d44
EZ
46442011-10-29 Eli Zaretskii <eliz@gnu.org>
4645
4646 Fix the `xbytecode' command.
4647 * .gdbinit (xprintbytestr): New command.
b50a28de 4648 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4649 (xbytecode): Print the byte-code string as well.
4650
4452fb80
EZ
46512011-10-29 Kim Storm <storm@cua.dk>
4652
8b058d44
EZ
4653 * alloc.c (which_symbols): New function.
4654
21b72067
AS
46552011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4656
4657 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4658 line. (Bug#9903)
4659
83ed7b5c
GM
46602011-10-29 Glenn Morris <rgm@gnu.org>
4661
4662 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4663 Not clear what it was for, and it causes various bugs. (Bug#9839)
4664
5a7a728b
EZ
46652011-10-28 Eli Zaretskii <eliz@gnu.org>
4666
4667 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4668 possible random value that matches one of those tested as
4669 condition to clear the mouse face.
4670
d3d0842f
CY
46712011-10-28 Chong Yidong <cyd@gnu.org>
4672
4673 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4674
31b39d13
DN
46752011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4676
4677 * window.c (make_window): Initialize phys_cursor_on_p.
4678
9aba6043
SM
46792011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4680
4681 * lisp.h (struct Lisp_Symbol): Update comments.
4682
c20992f4
JB
46832011-10-28 Juanma Barranquero <lekktu@gmail.com>
4684
4685 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4686
db4f02f2
EZ
46872011-10-28 Eli Zaretskii <eliz@gnu.org>
4688
4689 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4690 <oslsachem@gmail.com> for helping to debug this.
4691
4692 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4693 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4694 (g_b_init_get_glyph_outline_w): New static variables.
4695 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4696 (GetGlyphOutlineW_Proc): New typedefs.
4697 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4698 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4699 New functions.
4700 (w32font_open_internal, compute_metrics):
4701 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4702 instead of calling the "wide" APIs directly.
4703
4704 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4705
4706 * w32.h (syms_of_w32font): Add prototype.
4707
87e68db4
JB
47082011-10-27 Juanma Barranquero <lekktu@gmail.com>
4709
4710 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4711 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4712 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4713 (Fmove_to_window_line): Doc fix.
4714
435c1d67
CY
47152011-10-27 Chong Yidong <cyd@gnu.org>
4716
4717 * process.c (make_process): Set gnutls_state to NULL.
4718
4719 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4720 non-NULL, regardless of GNUTLS_INITSTAGE.
4721 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4722 an error. Set process slots as soon as we allocate them.
4723
4724 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4725
9c6c6f49
CY
47262011-10-27 Chong Yidong <cyd@gnu.org>
4727
9aba6043
SM
4728 * gnutls.c (emacs_gnutls_deinit): New function.
4729 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4730 (Fgnutls_deinit, Fgnutls_boot): Use it.
4731
4732 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4733 (deactivate_process): Call emacs_gnutls_deinit.
4734
657d08d3
JB
47352011-10-27 Juanma Barranquero <lekktu@gmail.com>
4736
4737 * image.c (x_create_x_image_and_pixmap):
4738 * w32.c (sys_rename, w32_delayed_load):
4739 * w32font.c (fill_in_logfont):
4740 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4741
5430d399
JB
47422011-10-26 Juanma Barranquero <lekktu@gmail.com>
4743
4744 * w32fns.c (w32_default_color_map): New function,
4745 extracted from Fw32_default_color_map.
a7ef684b 4746 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4747
fe0055fa
PE
47482011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4749
4750 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4751
e6346438
SM
47522011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4753
4754 * keyboard.c (test_undefined): New function (bug#9751).
4755 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4756
e112cc37
ET
47572011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4758
4759 * sysdep.c (init_sys_modes): Fix the check for the controlling
4760 terminal (Bug#6649).
4761
7b5d6677
EZ
47622011-10-20 Eli Zaretskii <eliz@gnu.org>
4763
4764 * dispextern.h (struct bidi_it): New member next_en_type.
4765
4766 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4767 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4768 current character, check also for next_en_type being WEAK_EN.
4769 (bidi_resolve_weak): Don't enter the expensive loop if the current
4770 position is before next_en_pos. Record the bidi type of the first
4771 non-ET, non-BN character we find, in addition to its position.
4772 (bidi_level_of_next_char): Invalidate next_en_type when
4773 next_en_pos is over-stepped.
4774
7da0b018
PE
47752011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4778 * editfns.c: Rewrite current-time-zone so that it invokes
4779 the equivalent of (format-time-string "%Z") to get the time zone name.
4780 This fixes a bug when the time zone name contains characters that
4781 need converting from the system time locale to Emacs internal format.
4782 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4783 that patch fixed format-time-string to do the conversion, but
4784 I forgot to fix current-time-zone.
4785 (format_time_string): New function, containing most of
4786 what Fformat_time_string used to contain.
4787 (Fformat_time_string): Rewrite in terms of format_time_string.
4788 This doesn't change this function's behavior.
4789 (current-time-zone): Rewrite to use format_time_string.
4790 This fixes the bug reported by Michael Schierl in
4791 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4792 Jason Rumney's 2007-06-07 change worked around this bug, but
4793 didn't fix it.
4794 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4795
8547b010
EZ
47962011-10-19 Eli Zaretskii <eliz@gnu.org>
4797
4798 * xdisp.c (start_display): If the character at POS is displayed
4799 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4800 (try_window_reusing_current_matrix): If a line ends in a display
4801 vector or the next line starts in a display vector, continue
4802 redrawing the window even though the character position of
4803 start_row was reached.
8547b010
EZ
4804 (Bug#9771, part 2)
4805
4e948d15
CY
48062011-10-18 Chong Yidong <cyd@gnu.org>
4807
4808 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4809 with nobreak-char-display too.
4810
4787455f
EZ
48112011-10-18 Eli Zaretskii <eliz@gnu.org>
4812
4813 Fix part 3 of bug#9771.
4814 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4815 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4816 non-neutral characters if the current character is a paragraph
4817 separator (a.k.a. Newline). This avoids running the same
4818 expensive loop twice, once when we consume the preceding newline
4819 and the other time when the line actually needs to be displayed.
4820 Avoid the loop when we see neutrals on the base embedding level
4821 following a character whose directionality is the same as the
4822 paragraph's. This avoids running the expensive loop when a line
4823 ends in a long sequence of neutrals, like control characters.
4824 Add assertion against STRONG_AL type. Slightly rearrange code
4825 that determines the type of a neutral given the first non-neutral
4826 that follows it.
4827 (bidi_level_of_next_char): Set next_en_pos to zero when
4828 invalidating its info.
4829
2c91f553
EZ
48302011-10-17 Eli Zaretskii <eliz@gnu.org>
4831
4832 * xdisp.c (push_display_prop): Determine whether to record string
4833 or buffer position by IT->string, not by IT->method. Allow
4834 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4835 (move_it_vertically_backward): Don't look for character position
4836 immediately after the newline when in a continuation line.
4837 (Bug#9771, part 1)
2c91f553 4838
c7b08b0d
MR
48392011-10-15 Martin Rudalics <rudalics@gmx.at>
4840
4841 * window.c (coordinates_in_window): Rewrite and delabelize
4842 vertical border check. (Bug#5357) (Bug#9618)
4843
6b02f655
SM
48442011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4845
4846 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4847 errors in XSetWindowBorder (bug#9310).
4848
81d40c92
DA
48492011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4850
4851 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4852 avoid crash when xmalloc overrun checking is enabled.
4853
d4172c3b
EZ
48542011-10-13 Eli Zaretskii <eliz@gnu.org>
4855
4856 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4857 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4858 cursor motion with <left> and <right> arrow keys.
4859
4860 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4861 some callers set that themselves.
4862
b00eea75
EZ
48632011-10-12 Eli Zaretskii <eliz@gnu.org>
4864
4865 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4866 display string and the previous row comes from the same string and
4867 is empty. (Bug#9739) (Bug#9738)
4868
8fe012c4
SM
48692011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4870
4871 * doc.c (get_doc_string): Encode file name (bug#9735).
4872
0074aef2
EZ
48732011-10-12 Eli Zaretskii <eliz@gnu.org>
4874
79beb178
EZ
4875 * bidi.c (bidi_level_of_next_char):
4876 * xdisp.c (get_visually_first_element): Remove old incorrect
4877 comments regarding the Unicode Line Separator character.
4878
0074aef2
EZ
4879 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4880
6e4b3fbe
DA
48812011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4882
4883 * alloc.c (Fgc_status): Do not access beyond zombies array
4884 boundary if nzombies > MAX_ZOMBIES.
4885 * alloc.c (dump_zombies): Add missing format specifier.
4886
0324f3af
PE
48872011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4888
b5525cac
PE
4889 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4890 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4891
0324f3af
PE
4892 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4893 Some packages use them to denote characters with modifiers.
4894
e9b5f888
AS
48952011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4896
4897 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4898 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4899 matching a pp-number. Rename parameter var to var1.
4900
127827c0
SM
49012011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4902
4903 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4904
c8fd3bd0
GM
49052011-10-08 Glenn Morris <rgm@gnu.org>
4906
4907 * callint.c (Fcall_interactively): Give a more explicit error for the
4908 'c' case with a non-character input. (Bug#8479)
4909
352ec8ff
EZ
49102011-10-08 Eli Zaretskii <eliz@gnu.org>
4911
03669ccb
EZ
4912 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4913 lines.
7061c986
EZ
4914 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4915 lines that are hscrolled on the left.
03669ccb 4916
352ec8ff
EZ
4917 * dispnew.c (buffer_posn_from_coords): Account for a possible
4918 presence of header-line. (Bug#4426)
4919
a66cfb1c
SM
49202011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4921
6b02f655
SM
4922 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4923 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4924
7c5ee88e
PE
49252011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4926
4927 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4928 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4929 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4930 this makes Emacs dump core during garbage collection on rare
4931 occasions. sizeof is obviously inferior to offsetof here, so
4932 stick with offsetof.
4933 (GC_POINTER_ALIGNMENT): New macro.
4934 (mark_memory): Omit 3rd (offset) arg; caller changed.
4935 Don't assume EMACS_INT alignment is the same as pointer alignment.
4936
df1bbe5b
SM
49372011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4938
4939 * keyboard.c (read_key_sequence_remapped): New var.
4940 (read_key_sequence): Compute remapping in the right buffer.
4941 (command_loop_1): Use read_key_sequence's remapping directly.
4942
51553db6
SM
49432011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4944
32c1fffd
SM
4945 * dired.c (file_name_completion): Don't expand file name.
4946 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4947 before checking file name handler.
4948
51553db6
SM
4949 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4950 they've been requested explicitly (bug#9591).
4951
b6bd1599 49522011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4953
4954 * keymap.c (Fsingle_key_description): Use make_specified_string
4955 instead of build_string to build string from push_key_description.
4956 (Bug#5193)
4957
f701dc2a
PE
49582011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4959
4222c55d
PE
4960 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4961 This fixes a Y2038 bug on 64-bit hosts.
4962 * buffer.c (reset_buffer):
4963 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4964 (Fclear_buffer_auto_save_failure):
4965 Use 0, not -1, to represent an unset failure time, since time_t
4966 might not be signed.
4967
f701dc2a
PE
4968 Remove dependency on glibc malloc internals.
4969 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4970 Move back here from lisp.h, but with their new implementations.
4971 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4972 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4973 * charset.c (charset_table_init): New static var.
4974 (syms_of_charset): Use it instead of xmalloc. This removes a
4975 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4976 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4977 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4978 Move back to alloc.c.
4979 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4980 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4981
9ceebf39
JD
49822011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4983
4984 * nsterm.m (windowDidResize): Call x_set_window_size only when
4985 ns_in_resize is true. Otherwise set pixelwidth/height and
4986 call change_frame_size (Bug#9628).
4987
cb993c58
PE
49882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4989
3930c88b
PE
4990 Port --enable-checking=all to Fedora 14 x86-64.
4991 * charset.c (syms_of_charset): Also account for glibc malloc's
4992 internal overhead when calculating the initial malloc maximum.
4993
cb993c58
PE
4994 Port --enable-checking=all to Fedora 14 x86.
4995 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4996 Move to lisp.h.
4997 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4998 (overrun_check_realloc, overrun_check_free):
4999 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5000 That way, xmalloc returns a properly-aligned pointer even if
5001 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5002 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5003 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5004 into account when calculating the initial malloc maximum.
5005 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5006 Move here from alloc.c, so that charset.c can use it too.
5007 Properly align; the old code wasn't right for common 32-bit hosts
5008 when configured with --enable-checking=all.
5009 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5010 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5011
31bed486
EZ
50122011-09-29 Eli Zaretskii <eliz@gnu.org>
5013
04c70788 5014 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5015 use EDOM.
5016
fbcaa2f3
EZ
50172011-09-28 Eli Zaretskii <eliz@gnu.org>
5018
5019 * xdisp.c (compute_display_string_end): If there's no display
5020 string at CHARPOS, return -1.
5021
5022 * bidi.c (bidi_fetch_char): When compute_display_string_end
5023 returns a negative value, treat the character as a normal
5024 character not covered by a display string. (Bug#9624)
5025
a239d4e9
JB
50262011-09-28 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * lread.c (Fread_from_string): Fix typo in docstring.
5029
88652fd5
EZ
50302011-09-27 Eli Zaretskii <eliz@gnu.org>
5031
5032 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5033 newline, reseat the iterator instead of bidi-iterating there one
5034 character at a time. (Bug#9610)
32c1fffd
SM
5035 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5036 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5037
ed497dd4
AS
50382011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5039
5040 * lread.c (readevalloop): Use correct code for NBSP.
5041 (read1): Likewise. (Bug#9608)
5042
b2bf61aa
MA
50432011-09-25 Michael Albinus <michael.albinus@gmx.de>
5044
5045 * dbusbind.c (Fdbus_register_signal): When service is not
5046 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5047
32bbb17c
GM
50482011-09-25 Glenn Morris <rgm@gnu.org>
5049
5050 * buffer.c (truncate-lines): Doc fix.
5051
94e0933e
CY
50522011-09-24 Chong Yidong <cyd@stupidchicken.com>
5053
5054 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5055 (Fset_window_next_buffers): Doc fix.
5056
cddde921
GM
50572011-09-24 Glenn Morris <rgm@gnu.org>
5058
5059 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5060
1260aef1
PE
50612011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5062
25b4bfa0
PE
5063 Fix minor problems found by static checking.
5064 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5065 * indent.c (Fvertical_motion): Fix == vs = typo.
5066
e3cbd34b
EZ
50672011-09-24 Eli Zaretskii <eliz@gnu.org>
5068
a66cfb1c
SM
5069 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5070 Default value is now t. Doc fix.
6bf7006f 5071
e3cbd34b 5072 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5073 logic when moving up, not only when moving down. Fix the
e3cbd34b 5074 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5075 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5076
5077 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5078 CHARPOS is covered by a display string which includes newlines.
5079 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5080 is covered by a display string with embedded newlines.
5081
a3de0cbd
MA
50822011-09-24 Michael Albinus <michael.albinus@gmx.de>
5083
5084 * dbusbind.c (Fdbus_register_signal): Add match rule to
5085 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5086 (Fdbus_register_method, Vdbus_registered_objects_table):
5087 Fix docstring.
a3de0cbd 5088
b260039d
JM
50892011-09-24 Jim Meyering <meyering@redhat.com>
5090
32c1fffd 5091 do not ignore write error for any output size
b260039d
JM
5092 The previous change was incomplete.
5093 While it makes emacs --batch detect the vast majority of stdout
5094 write failures, errors were still ignored whenever the output size is
5095 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5096 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5097 && echo FAIL: ignored write error
5098 FAIL: ignored write error
5099 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5100 && echo FAIL: ignored write error
5101 FAIL: ignored write error
5102 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5103
8eca8a7c
AS
51042011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5105
5106 * emacs.c (Fkill_emacs): In noninteractive mode exit
5107 non-successfully if a write error occurred on stdout. (Bug#9574)
5108
3341db62
EZ
51092011-09-21 Eli Zaretskii <eliz@gnu.org>
5110
5111 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5112 the xassert test.
5113
5114 * dispextern.h (struct it): Update the comment documenting what
5115 can it->OBJECT be.
5116
8c203dbf
EZ
51172011-09-20 Eli Zaretskii <eliz@gnu.org>
5118
5119 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5120 a display string, extend search for cursor position to end of row.
5121 (find_row_edges): If the row ends in a newline from a display
5122 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5123 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5124 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5125 non-empty line. Fixes confusing cursor motion with arrow keys at
5126 the beginning of a line that starts with whitespace.
8c203dbf 5127
a4824228
LMI
51282011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5129
5130 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5131 (bug#9493).
5132
33ed493b
CY
51332011-09-18 Chong Yidong <cyd@stupidchicken.com>
5134
5135 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5136 boolean (Bug#9154).
5137
56cd55c8
EZ
51382011-09-18 Eli Zaretskii <eliz@gnu.org>
5139
5140 * xdisp.c (display_line): Record maximum and minimum buffer
5141 positions even if no glyphs were produced (e.g., by a zero-width
5142 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5143 buffer positions that will be removed from the glyph row because
5144 they don't fit.
c02dcedf
EZ
5145 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5146 column is beyond frame width: don't subtract 1 "pixel" when
5147 computing width of the stretch.
3e62b7e0
EZ
5148 (reseat_at_next_visible_line_start): Undo the change made on
5149 2011-09-17 that saved paragraph information and restored it after
5150 the call to `reseat'. (Bug#9545)
56cd55c8 5151
5ed99d36 51522011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5153
5154 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5155 and turn window cursor on if cleared (Bug#9415).
5156
5ed99d36 51572011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5158
5159 * search.c (boyer_moore): Take unibyte characters from pattern
5160 literally. (Bug#9458)
5161
9bade7b2
EZ
51622011-09-18 Eli Zaretskii <eliz@gnu.org>
5163
5164 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5165
e5e9d610
PE
51662011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5167
87e4427a
PE
5168 Fix minor problem found by static checking.
5169 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5170 initialized, to pacify gcc -Wuninitialized.
5171
e5e9d610
PE
5172 * fileio.c: Report proper errno when syscall falls.
5173 (Finsert_file_contents): Save and restore errno,
5174 so that report_file_error outputs the correct diagnostic.
5175 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5176
a1674f0b
EZ
51772011-09-18 Eli Zaretskii <eliz@gnu.org>
5178
5179 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5180
fbfb6dd4
EZ
51812011-09-17 Eli Zaretskii <eliz@gnu.org>
5182
5183 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5184 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5185
bb187662
EZ
51862011-09-17 Eli Zaretskii <eliz@gnu.org>
5187
1137e8b8 5188 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5189 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5190
5191 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5192 (bidi_find_paragraph_start): Search back for paragraph beginning
5193 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5194 (bidi_move_to_visually_next): Only trigger paragraph-related
5195 computations when the last character is a newline or at EOB, not
5196 just any NEUTRAL_B. (Bug#9470)
5197
bb187662
EZ
5198 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5199 truncated lines if point is covered by a display string. (Bug#9524)
5200
2e621251
PE
52012011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5202
5203 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5204 (cons_to_x_long): New function.
5205 (lisp_data_to_selection_data): Use it. Correct the test for
5206 short-versus-long data; it was negated. Break out of vector
5207 loop, for efficiency, when a long datum is discovered.
5208
91a15bc6
SM
52092011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5210
5211 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5212
b41c3a35
EZ
52132011-09-16 Eli Zaretskii <eliz@gnu.org>
5214
5215 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5216 GCC PR/17406) by declaring this function with external scope.
5217
7812ba2d
PE
52182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5221 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5222
cf7edc2a
AS
52232011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5224
5225 * editfns.c (Fformat): Correctly handle text properties on "%%".
5226
bd01620e
EZ
52272011-09-15 Eli Zaretskii <eliz@gnu.org>
5228
5229 * xterm.c (x_draw_composite_glyph_string_foreground):
5230 * w32term.c (x_draw_composite_glyph_string_foreground):
5231 * term.c (encode_terminal_code):
5232 * composite.c (composition_update_it, get_composition_id):
5233 * xdisp.c (get_next_display_element)
5234 (fill_composite_glyph_string): Add comments about special meaning
5235 of TAB characters in a composition.
5236
a02719a3
PE
52372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5240 This occurs when processing a multibyte format.
5241 Problem reported by Wolfgang Jenker.
a02719a3 5242
72589a3c
JB
52432011-09-15 Johan Bockgård <bojohan@gnu.org>
5244
5245 * xdisp.c (try_cursor_movement): Only check for exact match if
5246 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5247
1c14176c
PE
52482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5249
5250 Remove unused external symbols.
5251 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5252 * xdisp.c (calc_pixel_width_or_height): Now static.
5253 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5254 * indent.c (check_display_width):
5255 * w32term.c: Fix comment to match code.
5256 * xterm.c, xterm.h (x_catching_errors): Remove.
5257
d2eea5b5
PE
52582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5259
5260 * xselect.c: Use signed conversions more consistently (Bug#9498).
5261 (selection_data_to_lisp_data): Assume incoming selection data are
5262 signed integers, not unsigned. This is to be consistent with
5263 outgoing selection data, which was modified to use signed integers
5264 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5265 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5266 expects long, not unsigned long.
5267
46888499
EZ
52682011-09-14 Eli Zaretskii <eliz@gnu.org>
5269
5270 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5271 computation of loop end. Reported by Johan Bockgård
5272 <bojohan@gnu.org>.
5273
ef8ef9fb
CY
52742011-09-13 Chong Yidong <cyd@stupidchicken.com>
5275
5276 * frame.c (Fother_visible_frames_p): Function deleted.
5277
fa819fed
EZ
52782011-09-12 Eli Zaretskii <eliz@gnu.org>
5279
5280 * indent.c (compute_motion): Process display vector front to back
5281 rather than the other way around. (Bug#2496)
5282
2ba8e008
SM
52832011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5284
5285 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5286
20f53c69
CY
52872011-09-11 Chong Yidong <cyd@stupidchicken.com>
5288
5289 * minibuf.c (Fread_from_minibuffer): Doc fix.
5290
d562d7a4
EZ
52912011-09-11 Eli Zaretskii <eliz@gnu.org>
5292
5293 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5294 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5295
1c4d7f3d
LMI
52962011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5297
5298 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5299 value for non-existent files.
5300
b885bf36
EZ
53012011-09-11 Eli Zaretskii <eliz@gnu.org>
5302
5303 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5304 set its "size" to -1. This will set the modtime_size field of
5305 the corresponding buffer to -1, which is what
5306 verify-visited-file-modtime expects for files that do not exist.
5307 (Bug#9139)
5308
6612f0bf
PE
53092011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5312 here ...
5313 * lisp.h: ... from here. push_key_description is no longer
5314 defined in keyboard.c, so its declaration should not be in
5315 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5316 logically belongs with push_key_description.
5317
dfb3f755
PE
53182011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5319
5320 * buffer.h: Include <sys/types.h> instead of <time.h>.
5321 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5322 Problem reported by Herbert J. Skuhra.
5323
3134906c
LMI
53242011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5325
5326 * xml.c (parse_region): Make the parsing work for
5327 non-comment-starting XML files again (bug#9144).
5328
8d903f4e
AS
53292011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5330
5331 * image.c (gif_load): Fix calculation of bottom and right corner.
5332 (Bug#9468)
5333
80ad64f4
EZ
53342011-09-10 Eli Zaretskii <eliz@gnu.org>
5335
5336 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5337 redisplay in small windows.
5338
208a048d
EZ
53392011-09-09 Eli Zaretskii <eliz@gnu.org>
5340
5341 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5342
9b1c252e
MR
53432011-09-08 Martin Rudalics <rudalics@gmx.at>
5344
5345 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5346 Operate on live windows only.
5347
2949f33b
JB
53482011-09-08 Juanma Barranquero <lekktu@gmail.com>
5349
5350 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5351
e08dcafd
EZ
53522011-09-07 Eli Zaretskii <eliz@gnu.org>
5353
5354 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5355 only under bidi iteration.
5356
115b96bd
JD
53572011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5358
5359 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5360
c8199d0f
PE
53612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5362
5363 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5364 Without this fix, the command to link temacs failed due to an
5365 undefined symbol __builtin_isnan. This is because
5366 /usr/include/iso/math_c99.h #defines isnan(x) to
5367 __builtin_isnan(x), but the bundled gcc, which identifies itself
5368 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5369 a __builtin_isnan.
5370 * floatfns.c (isnan): #undef, and then #define to a clone of
5371 what's in data.c.
5372 (Fisnan): Always define, since it's always available now.
5373 (syms_of_floatfns): Always define isnan at the Lisp level.
5374
e39b275c 53752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5376
5377 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5378
b2db44d9 53792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5380
f4af5137 5381 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5382 The previous code assumed that file offsets (off_t values) fit in
5383 EMACS_INT variables, which is not true on typical 32-bit hosts.
5384 The code messed up by falsely reporting buffer overflow in cases
5385 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5386 when "big" contains more than 2**29 bytes, even though this
5387 inserts just one byte and does not overflow the buffer.
5388 (Finsert_file_contents): Store file offsets as off_t
5389 values, not as EMACS_INT values. Check for overflow when
5390 converting between EMACS_INT and off_t. When checking for
5391 buffer overflow or for overlap, take the offsets into account.
5392 Don't use EMACS_INT for small values where int suffices.
5393 When checking for overlap, fix a typo: ZV was used where
5394 ZV_BYTE was intended.
5395 (Fwrite_region): Don't assume off_t fits into 'long'.
5396 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5397
ecfc0a49
MA
53982011-09-05 Michael Albinus <michael.albinus@gmx.de>
5399
5400 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5401
6511acf2 54022011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5403
0999621a 5404 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5405
5406 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5407 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5408 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5409 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5410 (modify_event_symbol): Do not assume that the length of
5411 name_alist_or_stem is safe to alloca and fits in int.
5412 (Fexecute_extended_command): Likewise for function name and binding.
5413 (Frecursion_depth): Wrap around reliably on integer overflow.
5414 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5415 since some callers pass EMACS_INT values.
5416 (Fsingle_key_description): Don't crash if symbol name contains more
5417 than MAX_ALLOCA bytes.
5418 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5419 (get_minibuffer): Arg is now EMACS_INT, not int.
5420 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5421 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5422 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5423
2be7d702
PE
5424 * dbusbind.c (signature_cat): New function.
5425 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5426 Do not overrun buffer; instead, report string overflow.
5427
9d1df220
PE
5428 * dispnew.c (add_window_display_history): Don't overrun buffer.
5429 Truncate instead; this is OK since it's just a log.
5430
33ef5c64
PE
5431 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5432 even if the time zone offset is outlandishly large.
5433 Don't mishandle offset == INT_MIN.
5434
66c6fdd5
PE
5435 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5436 when creating daemon; the previous buffer-overflow check was incorrect.
5437
d749b01b
PE
5438 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5439 which has the guts of the old verror function.
5440
b5cd1905
PE
5441 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5442 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5443
6e1a67fb
PE
5444 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5445 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5446 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5447 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5448 length of string rather than counting it via multiple sprintfs;
5449 that's simpler and more reliable.
c21721cc
PE
5450 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5451 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5452 sprintf, in case result does not fit in int.
5453
c57b67fc
PE
5454 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5455 (fontset_from_font): Print it.
5456
8a401434
PE
5457 * frame.c (tty_frame_count): Now printmax_t, not int.
5458 (make_terminal_frame, set_term_frame_name): Print it.
5459 (x_report_frame_params): In X, window IDs are unsigned long,
5460 not signed long, so print them as unsigned.
5461 (validate_x_resource_name): Check for implausibly long names,
5462 and don't assume name length fits in 'int'.
5463 (x_get_resource_string): Don't blindly alloca invocation name;
5464 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5465 not fit in int.
5466
6e1a67fb
PE
5467 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5468 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5469 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5470
0df02bf3
PE
5471 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5472 Use esprintf, not sprintf, in case result does not fit in int.
5473
48e30793
PE
5474 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5475 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5476 it as a large positive number.
5477 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5478 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5479
a66ff6d8
PE
5480 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5481 in case result does not fit in int.
5482
aca216ff
PE
5483 * print.c (float_to_string): Detect width overflow more reliably.
5484 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5485 buffer overrun. Don't assume list length fits in 'int'. Treat
5486 print length of 0 as 0, not as infinity; to be consistent with other
5487 uses of print length in this function. Don't overflow print length
5488 index. Don't assume hash table size fits in 'long', or that
5489 vectorlike size fits in 'unsigned long'.
5490
31c286f7
PE
5491 * process.c (make_process): Use printmax_t, not int, to format
5492 process-name gensyms.
5493
55e5faa1
PE
5494 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5495
80f2e268
PE
5496 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5497 to avoid potential buffer overrun.
5498
670741ab
PE
5499 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5500 if X resource line is longer than 512 bytes.
5501
b7163a50
PE
5502 * xfns.c (x_window): Make sprintf buffer a bit bigger
5503 to avoid potential buffer overrun.
5504
ae58ff1f
PE
5505 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5506
c43c8a6a
PE
5507 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5508
3f8236f4
PE
55092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5510
53e9fe90 5511 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5512 Without these, Emacs silently mishandles large integers sometimes.
5513 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5514 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5515
6511acf2
PE
5516 * xdisp.c (try_window_id): Check Emacs fixnum range before
5517 converting to 'int'.
806add1d 5518
6511acf2 5519 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5520 Check that an Emacs fixnum is in range before assigning it to 'int'.
5521 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5522 values converted from Emacs fixnums.
5523 (Frecenter): Don't wrap around a line count if it is out of 'int'
5524 range; instead, treat it as an extreme value.
5525 (Fset_window_configuration, compare_window_configurations):
5526 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5527
6511acf2
PE
5528 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5529 that can exceed INT_MAX. Check that EMACS_INT value is in range
5530 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5531 (match_limit): Don't assume that a fixnum can fit in 'int'.
5532
6511acf2 5533 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5534 exceed INT_MAX.
5535
6511acf2 5536 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5537 (Fvertical_motion): Don't wrap around LINES values that don't fit
5538 in 'int'. Instead, treat them as extreme values. This is good
5539 enough for windows, which can't have more than INT_MAX lines anyway.
5540
fcb901a7
LMI
55412011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5542
0f2f6b6d
LMI
5543 * Require libxml/parser.h to avoid compilation warning.
5544
fcb901a7
LMI
5545 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5546
5547 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5548 since this reportedly can destroy thread storage.
5549
6e20a0d4
CY
55502011-08-30 Chong Yidong <cyd@stupidchicken.com>
5551
5552 * syntax.c (find_defun_start): Update all cache variables if
5553 exiting early (Bug#9401).
5554
148ae00e
EZ
55552011-08-30 Eli Zaretskii <eliz@gnu.org>
5556
f6cfbd8f
EZ
5557 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5558
148ae00e
EZ
5559 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5560 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5561 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5562
5563 * term.c (tty_append_glyph): New function.
5564 (produce_stretch_glyph): Static function and its prototype deleted.
5565
a66cfb1c
SM
5566 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5567 Add prototypes.
148ae00e 5568
c4a07a4c
PE
55692011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5570
5571 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5572 when checking :margin (Bug#9390).
5573 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5574 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5575 so that the name doesn't mislead. All uses changed.
5576
6bc8cd65
JB
55772011-08-28 Johan Bockgård <bojohan@gnu.org>
5578
5579 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5580 set_tty_hooks.
5581
dca4927e
EZ
55822011-08-27 Eli Zaretskii <eliz@gnu.org>
5583
5584 * xdisp.c (move_it_to): Don't bail out early when reaching
5585 position beyond to_charpos, if we are scanning backwards.
5586 (move_it_vertically_backward): When DY == 0, make sure we get to
5587 the first character in the line after the newline.
5588
f2cad773
PE
55892011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5590
5591 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5592 (ccl_driver): Do not generate an out-of-range pointer.
5593 (Fccl_execute_on_string): Remove unnecessary check for
5594 integer overflow, noted by Stefan Monnier in
5595 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5596 Remove a FIXME that didn't need fixing.
5597 Simplify the newly-introduced buffer reallocation code.
5598
0cae2cdb
JB
55992011-08-27 Juanma Barranquero <lekktu@gmail.com>
5600
5601 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5602
5fc295a4 56032011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5604
70c60eb2 5605 Integer and memory overflow issues (Bug#9196).
726e0ab1 5606
d31850da
PE
5607 * doc.c (get_doc_string): Rework so that
5608 get_doc_string_buffer_size is the actual buffer size, rather than
5609 being 1 less than the actual buffer size; this makes xpalloc more
5610 convenient.
5611
a69fbedb
PE
5612 * image.c (x_allocate_bitmap_record, cache_image):
5613 * xselect.c (Fx_register_dnd_atom):
5614 Simplify previous changes by using xpalloc.
5615
fe5c5d37
PE
5616 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5617 since either will do and ptrdiff_t is convenient with xpalloc.
5618
0065d054
PE
5619 * charset.c (charset_table_size)
5620 (struct charset_sort_data.priority): Now ptrdiff_t.
5621 (charset_compare): Don't overflow if priorities differ greatly.
5622 (Fsort_charsets): Don't assume list length fits in int.
5623 Check for size-calculation overflow when allocating sort data.
5624 (syms_of_charset): Allocate an initial charset table that is
5625 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5626
5627 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5628
5629 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5630 The actual value is always <= INT_MAX, and leaving it unsigned made
5631 overflow checking harder.
5632
5633 * dispextern.h (struct glyph_matrix.rows_allocated)
5634 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5635 with xpalloc. The values are still always <= INT_MAX.
5636
5637 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5638
5639 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5640 (SAFE_NALLOCA): New macro.
5641
5642 * region-cache.c (struct boundary.pos, find_cache_boundary)
5643 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5644 (set_cache_region, invalidate_region_cache)
5645 (revalidate_region_cache, know_region_cache, region_cache_forward)
5646 (region_cache_backward, pp_cache):
5647 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5648 so that ptrdiff_t * can be passed to xpalloc.
5649 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5650 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5651 (pp_cache): Don't assume cache_len fits in int.
5652 * region-cache.h: Adjust extern decls to match.
5653
5654 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5655 EMACS_INT, since either will do, for xpalloc.
5656
5657 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5658 (xnmalloc, xnrealloc, xpalloc): New functions.
5659
726e0ab1
PE
5660 * bidi.c (bidi_shelve_header_size): New constant.
5661 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5662 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5663
51f30bc5 5664 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5665 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5666 (overlay_strings):
5667 Don't update size of array until after memory allocation succeeds,
5668 because xmalloc/xrealloc may not return.
0065d054
PE
5669 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5670 now that we have proper integer overflow checking.
5671 (record_overlay_string, overlay_strings): Catch overflows when
5672 calculating size of overlay_str_buf.
726e0ab1 5673
0065d054
PE
5674 * callproc.c (Fcall_process): Check for size overflow when
5675 calculating size of args2.
5676 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5677 Normally we prefer signed values, but sticking with ptrdiff_t would
5678 require adding more-complicated checks.
726e0ab1
PE
5679
5680 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5681 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5682 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5683 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5684
5685 * character.c (Fstring): Check for size-calculation overflow.
5686
5687 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5688 unnecessary integer overflow. Check for size overflow.
5689 (encode_coding_object): Don't update size until xmalloc succeeds.
5690
5691 * composite.c (get_composition_id): Check for overflow in glyph
5692 length calculations.
5693
5694 Integer and memory overflow fixes for display code.
5695 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5696 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5697 (scrolling_window): Check for overflow in size calculations.
5698 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5699 Don't assume glyph table len fits in int.
5700 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5701 (row_table_size): Now ptrdiff_t, not int.
5702 (scrolling_window): Avoid overflow in size calculations.
5703 Don't update size until allocation succeeds.
5704 * fns.c (concat): Check for overflow in size calculations.
5705 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5706 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5707 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5708
5709 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5710 (get_doc_string): Check for size calculation overflow.
5711 Don't update size until allocation succeeds.
5712 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5713 EMACS_INT, where ptrdiff_t will do.
5714 (Fsubstitute_command_keys): Check for string overflow.
5715
5716 * editfns.c (set_time_zone_rule): Don't assume environment length
5717 fits in int.
5718 (message_length): Now ptrdiff_t, not int.
5719 (Fmessage_box): Don't update size until allocation succeeds.
5720 Don't assume message length fits in int.
5721 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5722
0065d054
PE
5723 * emacs.c (main): Do not reallocate argv, since there is a null at
5724 the end that can be overwritten, and this way there's no need to
5725 worry about size-calculation overflow.
5726 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5727
5728 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5729 alloc succeeds.
5730 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5731
5732 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5733 (x_set_scroll_bar_width, x_figure_window_size):
5734 Check for integer overflow.
5735 (x_set_alpha): Do not assume XINT fits in int.
5736
5737 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5738 This is for the members text_lines, text_cols, total_lines, total_cols,
5739 where the system imposes an 'int' limit.
5740
5741 * fringe.c (Fdefine_fringe_bitmap):
5742 Don't update size until alloc works.
5743
5744 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5745 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5746
5747 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5748 Check for size-calculation overflow.
5749 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5750 do, as we prefer signed integers.
5751 (id_to_widget.max_size, id_to_widget.used)
5752 (xg_store_widget_in_map, xg_remove_widget_from_map)
5753 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5754 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5755 Use and return ptrdiff_t, not int.
5756 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5757 * gtkutil.h: Change prototypes to match the above.
5758
5759 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5760 are duplicate now that they've been promoted to lisp.h.
5761 (x_allocate_bitmap_record, x_alloc_image_color)
5762 (make_image_cache, cache_image, xpm_load):
5763 Don't update size until alloc is done.
5764 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5765 (x_detect_edges):
3256efce 5766 Check for size calculation overflow.
726e0ab1
PE
5767 (ct_colors_allocated_max): New constant.
5768 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5769 overflow.
3256efce 5770
726e0ab1
PE
5771 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5772 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5773 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5774 Use ptrdiff_t, not int, to count maps.
5775 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5776 calculations. Don't update size until allocation succeeds.
5777 Redo calculations to avoid overflow.
726e0ab1
PE
5778 * keyboard.h: Change prototypes to match the above.
5779
5780 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5781 to count maps.
5782 (current_minor_maps): Check for size calculation overflow.
5783 * keymap.h: Change prototypes to match the above.
5784
5785 * lread.c (read1, init_obarray): Don't update size until alloc done.
5786
5787 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5788 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5789
726e0ab1
PE
5790 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5791 Now ptrdiff_t, not int.
5792 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5793 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5794
5795 * process.c (Fnetwork_interface_list): Check for overflow
5796 in size calculation.
5797
5798 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5799
5800 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5801 overflow. Don't bother calling xmalloc when xrealloc will do.
5802
5803 * search.c (Freplace_match): Check for size calculation overflow.
5804 (Fset_match_data): Don't assume list lengths fit in 'int'.
5805
5806 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5807 for command line length. Do not attempt to address one before the
5808 beginning of an array, as that's not portable.
5809
5810 * term.c (max_frame_lines): Remove; unused.
5811 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5812 not int.
5813 (encode_terminal_code, calculate_costs): Check for size
5814 calculation overflow.
5815 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5816 table lengths and related sizes. Don't update size until alloc
5817 done. Redo calculations to avoid overflow.
5818 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5819
5820 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5821 subtracting pointers.
5822 (gobble_line): Check for overflow more carefully. Don't update size
5823 until alloc done.
5824
5825 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5826 Don't update size until alloc done.
5827 Redo size calculations to avoid overflow.
5828 Check for size calculation overflow.
0065d054 5829 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5830
5831 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5832 Use ptrdiff_t, not int, for sizes.
5833 (store_mode_line_noprop_char): Don't update size until alloc done.
5834
0065d054
PE
5835 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5836 Use ptrdiff_t, not int, for sizes.
5837 (Finternal_make_lisp_face, cache_face):
5838 Check for size calculation overflow.
5839 (cache_face): Treat size calculation overflows as if they were
5840 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5841
5842 * xfns.c (x_encode_text, x_set_name_internal)
5843 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5844 sizes, since they can exceed INT_MAX in size. Check for size
5845 calculation overflow.
5846
0065d054
PE
5847 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5848 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5849 Don't update size until alloc done.
5850
0065d054 5851 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5852 as sprintf is limited to int lengths.
1d526e2f 5853
252c5ee1
PE
5854 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5855 (X_LONG_MIN): New macros.
864d7ce7
PE
5856 Use them to make the following changes clearer.
5857 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5858 This change doesn't affect the value now, but it may help remind
5859 future maintainers not to raise the value too much later.
5860 (SELECTION_QUANTUM): Remove, replacing with ...
5861 (selection_quantum): ... new function, which avoids overflow.
5862 All uses changed.
5863 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5864 assumption that selection length fits in 'int'.
5865 (x_reply_selection_request, x_handle_selection_request)
5866 (x_get_window_property, receive_incremental_selection)
5867 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5868 (lisp_data_to_selection_data, clean_local_selection_data):
5869 Use ptrdiff_t, not int, to record length of selection.
5870 (x_reply_selection_request, x_get_window_property)
5871 (receive_incremental_selection, x_property_data_to_lisp):
5872 Redo calculations to avoid overflow.
5873 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5874 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5875 something.
5876 (x_get_window_property, receive_incremental_selection)
5877 (lisp_data_to_selection_data, x_property_data_to_lisp):
5878 Check for size-calculation overflow.
5879 (x_get_window_property, receive_incremental_selection)
5880 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5881 Don't store size until memory allocation succeeds.
5882 (x_get_window_property): Plug memory leak on memory exhaustion.
5883 Don't double-block input; malloc is safe here. Don't assume 2**34
5884 - 4 fits in unsigned long. Add an xassert to check
5885 XGetWindowProperty overflow. Be more careful about overflow
5886 calculations, and distinguish size from memory overflow better.
5887 (receive_incremental_selection): When tracing, don't assume
5888 unsigned int is less than INT_MAX.
5889 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5890 harmful) conversions of unsigned short to int.
5891 (lisp_data_to_selection_data): Don't assume that integers
5892 in the range -65535 through -1 fit in an X unsigned short.
5893 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5894 result parameters unless successful. Rely on cons_to_unsigned
5895 to report problems with elements; the old code wasn't right anyway.
5896 (x_check_property_data): Check for int overflow; we cannot use
5897 a wider type due to X limits.
5898 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5899
726e0ab1 5900 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5901
0065d054
PE
5902 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5903 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5904 (x_color_cells): Don't store size until memory allocation succeeds.
5905 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5906 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5907 (x_term_init): Don't assume length fits in int (sprintf is limited
5908 to int size).
bc18e09d 5909
ebfa62c0
PE
5910 Use ptrdiff_t for composition IDs.
5911 * character.c (lisp_string_width):
5912 * composite.c (composition_table_size, n_compositions)
5913 (get_composition_id, composition_gstring_from_id):
5914 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5915 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5916 * window.c (Frecenter):
5917 Use ptrdiff_t, not int, for composition IDs.
5918 * composite.c (get_composition_id): Check for integer overflow.
5919 * composite.h: Adjust prototypes to match the above changes.
5920
d3411f89
PE
5921 Use ptrdiff_t for hash table indexes.
5922 * category.c (hash_get_category_set):
5923 * ccl.c (ccl_driver):
5924 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5925 * coding.c (coding_system_charset_list, detect_coding_system):
5926 * coding.h (struct coding_system.id):
5927 * composite.c (get_composition_id, gstring_lookup_cache):
5928 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5929 * image.c (xpm_get_color_table_h):
5930 * lisp.h (hash_lookup, hash_put):
5931 * minibuf.c (Ftest_completion):
5932 Use ptrdiff_t for hash table indexes, not int (which is too
5933 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5934 32-bit --with-wide-int hosts).
5935
e097a6fa
PE
5936 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5937 Add a FIXME comment about memory leaks.
5938 (syms_of_charset): Don't assume xmalloc returns.
5939
5637687f
PE
5940 Don't assume that stated character widths fit in int.
5941 * character.c (Fchar_width, c_string_width, lisp_string_width):
5942 * character.h (CHAR_WIDTH):
5943 * indent.c (MULTIBYTE_BYTES_WIDTH):
5944 Use sanitize_char_width to avoid undefined and/or bad behavior
5945 with outlandish widths.
a66cfb1c 5946 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5947 now that we have two such functions. All uses changed.
5948 (sanitize_char_width): New inline function.
5949
a2271ba2
PE
5950 Don't assume that tab-width fits in int.
5951 * character.h (sanitize_width): New inline function.
5952 (SANE_TAB_WIDTH): New macro.
5953 (ASCII_CHAR_WIDTH): Use it.
5954 * indent.c (sane_tab_width): Remove. All uses replaced by
5955 SANE_TAB_WIDTH (current_buffer).
5956 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5957
18c52557
PE
5958 * fileio.c: Integer overflow issues with file modes.
5959 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5960
caeeedc1
PE
5961 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5962 Remove unreachable code.
5963 (read_hex, load_charset_map_from_file): Check for integer overflow.
5964
6df6ae42 5965 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5966 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5967 (x_send_scroll_bar_event): Likewise. Check that the size does not
5968 exceed limits imposed by XClientMessageEvent, as well as the usual
5969 ptrdiff_t and size_t limits.
5970
b13995db
PE
5971 * keyboard.c: Overflow, signedness and related fixes.
5972 (make_lispy_movement): Use same integer type in forward decl
5973 that is used in the definition.
5974 (read_key_sequence, keyremap_step):
5975 Change bufsize argument back to int, undoing my 2011-03-30 change.
5976 We prefer signed types, and int is wide enough here.
5977 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5978 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5979 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5980 length, not size_t. Use ptrdiff_t for index, not int.
5981 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5982 possibility of integer overflow.
5983
13464394
PE
5984 Overflow, signedness and related fixes for images.
5985
5986 * dispextern.h (struct it.stack[0].u.image.image_id)
5987 (struct_it.image_id, struct image.id, struct image_cache.size)
5988 (struct image_cache.used, struct image_cache.ref_count):
5989 * gtkutil.c (update_frame_tool_bar):
5990 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5991 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5992 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5993 * nsmenu.m (update_frame_tool_bar):
5994 * xdisp.c (calc_pixel_width_or_height):
5995 * xfns.c (image_cache_refcount):
5996 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5997 on typical 64-bit hosts.
5998
5999 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6000 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6001 Omit unnecessary casts to int.
6002 (parse_image_spec): Check that integers fall into 'int' range
6003 when the callers expect that.
6004 (image_ascent): Redo ascent calculation to avoid int overflow.
6005 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6006 (lookup_image): Remove unnecessary tests.
6007 (xbm_image_p): Locals are now of int, not EMACS_INT,
6008 since parse_image_check makes sure they fit into int.
6009 (png_load, gif_load, svg_load_image):
6010 Prefer int to unsigned where either will do.
6011 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6012 old tiff_error_handler and tiff_warning_handler.
6013 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6014 stack buffer overflows. It uses only the features of vsnprintf
6015 that are common to both POSIX and native Microsoft.
6016 (tiff_error_handler, tiff_warning_handler): Use it.
6017 (tiff_load, gif_load, imagemagick_load_image):
6018 Don't assume :index value fits in 'int'.
6019 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6020 (imagemagick_load_image): Check that crop parameters fit into
6021 the integer types that MagickCropImage accepts. Don't assume
6022 Vimagemagick_render_type has a nonnegative value. Don't assume
6023 size_t fits in 'long'.
6024 (gs_load): Use printmax_t to print the widest integers possible.
6025 Check for integer overflow when computing image height and width.
6026
c11821d4
EZ
60272011-08-26 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (redisplay_window): Don't force window start if point
6030 will be invisible in the resulting window. (Bug#9324)
6031
0c95fcf7
EZ
60322011-08-25 Eli Zaretskii <eliz@gnu.org>
6033
6034 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6035 the display spec is of the form `(space ...)'.
6036 (handle_display_spec): Return the value returned by
6037 handle_single_display_spec, not just 1 or zero.
6038 (handle_single_display_spec): If the display spec is of the form
6039 `(space ...)', and specifies display in the text area, return 2
6040 rather than 1.
fee65a97 6041 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6042 accurately, and prefer exact match for point under bidi.
6043 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6044
6045 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6046 into disp_prop; all users changed.
6047
6048 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6049 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6050 for the text covered by the display property.
6051
e4ed06f1
CY
60522011-08-25 Chong Yidong <cyd@stupidchicken.com>
6053
6054 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6055 Change return value to nil.
6056 (Frecord_buffer): Delete unused function.
6057
f67cdd7f
EZ
60582011-08-24 Eli Zaretskii <eliz@gnu.org>
6059
5980d4c6
EZ
6060 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6061 buffers, return left-to-right.
8610fe8b
EZ
6062 (set_cursor_from_row): Consider candidate row a win if its glyph
6063 represents a newline and point is on that newline. Fixes cursor
6064 positioning on the newline at EOL of R2L text within L2R
6065 paragraph, and vice versa.
6066 (try_cursor_movement): Check continued rows, in addition to
6067 continuation rows. Fixes unwarranted scroll when point enters a
6068 continued line of R2L text within an L2R paragraph, or vice versa.
6069 (cursor_row_p): Consider the case of point being equal to
6070 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6071 from the end of a short line to the beginning of a continued line
6072 of R2L text within L2R paragraph.
6073 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6074 composed characters.
5980d4c6 6075
f67cdd7f
EZ
6076 * bidi.c (bidi_check_type): Use xassert.
6077 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6078 members.
6079
bca633fb
EZ
60802011-08-23 Eli Zaretskii <eliz@gnu.org>
6081
6082 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6083 a character.
6084
4a5885a7
CY
60852011-08-23 Chong Yidong <cyd@stupidchicken.com>
6086
6087 * nsfont.m (ns_otf_to_script): Fix typo.
6088
0902a04e
KH
60892011-08-22 Kenichi Handa <handa@m17n.org>
6090
6091 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6092 extra slot even if the purpose is char-code-property-table.
6093
1a2e6670
EZ
60942011-08-23 Eli Zaretskii <eliz@gnu.org>
6095
8ddde651
EZ
6096 * xdisp.c (redisplay_window): When computing centering_position,
6097 account for the height of the header line. (Bug#8874)
6098
425cc014
EZ
6099 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6100 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6101 candidate is selected by the mouse, and that candidate has a
6102 composed character under the mouse.
6103
1a2e6670
EZ
6104 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6105 coordinates reported by pos-visible-in-window-p for a composed
6106 character in column zero.
6107
8b76d6f8
SM
61082011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6109
6110 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6111
dac347dd
EZ
61122011-08-22 Eli Zaretskii <eliz@gnu.org>
6113
6114 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6115 consider it a hit if to_charpos is anywhere in the range of the
6116 composed buffer positions.
6117
e013fb34
CY
61182011-08-22 Chong Yidong <cyd@stupidchicken.com>
6119
6120 * image.c (gif_load): Don't assume that each subimage has the same
6121 dimensions as the base image. Handle disposal method that is
6122 "undefined" by the gif spec (Bug#9335).
6123
bd1ba3e8
CY
61242011-08-20 Chong Yidong <cyd@stupidchicken.com>
6125
6126 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6127 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6128
54a1215b
EZ
61292011-08-19 Eli Zaretskii <eliz@gnu.org>
6130
823564e5
EZ
6131 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6132 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6133 from an Org mode buffer to a Speedbar frame.
6134
54a1215b
EZ
6135 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6136 a composition, take its buffer position from IT->cmp_it.charpos.
6137 Fixes cursor positioning at the beginning of a line that begins
6138 with a composed character.
6139
9778ebcc
EZ
61402011-08-18 Eli Zaretskii <eliz@gnu.org>
6141
0be6ee06
EZ
6142 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6143 character bidirectional type, use STRONG_L instead. Fixes crashes
6144 in a buffer produced by `describe-categories'.
6145
9778ebcc
EZ
6146 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6147 members before the level stack, so they would be saved and
6148 restored when copying iterator state. Fixes incorrect reordering
6149 around TABs covered by display properties.
6150
156bffbe
AS
61512011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6152
6b02f655 6153 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6154
72ad093b
CY
61552011-08-17 Chong Yidong <cyd@stupidchicken.com>
6156
6157 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6158 (internal_condition_case_2, internal_condition_case_n):
6159 Remove unnecessary aborts (Bug#9081).
72ad093b 6160
35774242
EZ
61612011-08-17 Eli Zaretskii <eliz@gnu.org>
6162
6163 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6164 has no `load' handler, try opening the file locally. (Bug#9311)
6165
db76dd85
KB
61662011-08-16 Ken Brown <kbrown@cornell.edu>
6167
6168 * gmalloc.c: Expand comment.
6169
b215eee5
EZ
61702011-08-16 Eli Zaretskii <eliz@gnu.org>
6171
6172 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6173 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6174
a4579d33
KB
61752011-08-16 Ken Brown <kbrown@cornell.edu>
6176
6177 Fix memory allocation problems in Cygwin build (Bug#9273).
6178
6179 * unexcw.c ( __malloc_initialized): Declare external variable.
6180 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6181
8b76d6f8
SM
6182 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6183 New variables.
a4579d33
KB
6184 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6185 dumped emacs.
6186 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6187 in the static heap.
6188 [CYGWIN] (special_realloc): New function.
6189 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6190 requests to realloc storage in the static heap.
6191
3ebec551
PE
61922011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6193
6194 * bidi.c (bidi_initialize): Remove unused local.
6195
9fd8be00
EZ
61962011-08-15 Eli Zaretskii <eliz@gnu.org>
6197
6b02f655
SM
6198 * bidimirror.h:
6199 * biditype.h: Remove file.
6200 * makefile.w32-in ($(BLD)/bidi.$(O)):
6201 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6202
6203 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6204
6205 * chartab.c: Improve commentary for the uniprop_table API.
6206
32413314
EZ
6207 * bidi.c (bidi_paragraph_init): Support zero value of
6208 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6209 (bidi_initialize): Use uniprop_table instead of including
6210 biditype.h and bidimirror.h.
32413314 6211
9fd8be00
EZ
6212 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6213 coordinates of the iterator when restoring from ppos_it.
6214 (Bug#9296)
6215
5cf2b69b
KH
62162011-08-14 Kenichi Handa <handa@m17n.org>
6217
6218 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6219 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6220
daf17d00
EZ
62212011-08-14 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (move_it_in_display_line_to): Don't invoke
6224 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6225 ppos_it. Fixes vertical cursor motion when line beginning is
6226 covered by an image. (Bug#9296)
6227
08e3161a
JD
62282011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6229
6230 * nsterm.h (ns_run_ascript): Declare.
6231 (NSAPP_DATA2_RUNASSCRIPT): Define.
6232
6233 * nsfns.m (as_script, as_result, as_status): New static variables.
6234 (ns_run_ascript): New function.
5e617bc2 6235 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6236 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6237 the event loop. Get status from as_status (Bug#7276).
6238
6239 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6240 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6241 the event loop (Bug#7276).
6242
a3720aa2
AS
62432011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6244
6245 * gnutls.c (QCgnutls_bootprop_priority)
6246 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6247 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6248 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6249 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6250 (QCgnutls_bootprop_verify_hostname_error)
6251 (QCgnutls_bootprop_callbacks_verify): Rename from
6252 Qgnutls_bootprop_..., all uses changed.
6253
6254 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6255 uses changed.
6256
0a0d27fb
PE
62572011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6258
19d5c50c
PE
6259 * xfaces.c (Qframe_set_background_mode): Now static.
6260 * dispextern.h (Qframe_set_background_mode): Remove decl.
6261
0a0d27fb
PE
6262 * process.c (Fnetwork_interface_info): Declare local only if needed.
6263
377538cb
JD
62642011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6265
6266 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6267 (Fnetwork_interface_list): Allocate in increments of bytes instead
6268 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6269 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6270 sockaddr.
6271 (struct ifflag_def): notrailers is smart on OSX.
6272 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6273 Get hardware address with getifaddrs if available.
6274
08fff70c
EZ
62752011-08-12 Eli Zaretskii <eliz@gnu.org>
6276
6277 * xdisp.c (iterate_out_of_display_property): xassert that
6278 IT->position is set to within IT->object's boundaries. Break from
6279 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6280 when IT->position is set up wrongly due to some bug.
6281 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6282 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6283 entry. Force push_it to save on the stack the current
6284 buffer/string position, to be restored by pop_it. Fix flags in
6285 the iterator structure wrt the object coming from a display
6286 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6287 properties. (Bug#9284)
6288
7be1c708 62892011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6290
7be1c708
CY
6291 * fontset.c (fontset_get_font_group): Add proper type checks.
6292 (Bug#9172)
aac0c6e3 6293
7be1c708 62942011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6295
7be1c708
CY
6296 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6297 and LC_VERSION_MIN_MACOSX.
6298 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6299 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6300
97bb72a6
EZ
63012011-08-08 Eli Zaretskii <eliz@gnu.org>
6302
6303 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6304 no-display-properties-and-no-overlays under bidi display.
6305 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6306 properties and overlays.
97bb72a6 6307
d5617611
CY
63082011-08-08 Chong Yidong <cyd@stupidchicken.com>
6309
37e11a63
CY
6310 * editfns.c (Fset_time_zone_rule): Document relationship with the
6311 setenv function.
6312
d5617611
CY
6313 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6314 the font entity extracted from the cache (Bug#8109).
6315
58872834
CY
63162011-08-07 Chong Yidong <cyd@stupidchicken.com>
6317
6318 * composite.c (autocmp_chars): Don't reset point. That is done by
6319 restore_point_unwind (Bug#5984).
6320
75bfc667
JL
63212011-08-07 Juri Linkov <juri@jurta.org>
6322
6323 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6324 to show the arg `TIME' instead of `TIMEVAL'.
6325
d1410150
EZ
63262011-08-06 Eli Zaretskii <eliz@gnu.org>
6327
6328 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6329 display property strides EOL and includes a newline, as in
6330 longlines-mode. (Bug#9254)
75b771e4
EZ
6331 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6332 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6333
6334 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6335 is non-zero, even if the data buffer is NULL. Fixes a crash in
6336 vertical-motion with longlines-mode. (Bug#9254)
6337
35928349
EZ
63382011-08-05 Eli Zaretskii <eliz@gnu.org>
6339
ec7cc85b
EZ
6340 * bidi.c <bidi_cache_total_alloc>: Now static.
6341 (bidi_initialize): Initialize bidi_cache_total_alloc.
6342
8b76d6f8 6343 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6344 cache. (Bug#9221)
6345
6346 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6347 amount allocated this far in `bidi_cache_total_alloc'.
6348 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6349 non-zero, only free the data buffer without restoring the cache
6350 contents. All callers changed.
6351
6352 * dispextern.h (bidi_unshelve_cache): Update prototype.
6353
6354 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6355 (move_it_in_display_line, move_it_to)
6356 (move_it_vertically_backward, move_it_by_lines): Replace the call
6357 to xfree to an equivalent call to bidi_unshelve_cache.
6358 (move_it_in_display_line_to): Fix logic of returning
412b6358 6359 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6360
e2e2423b
EZ
63612011-08-05 Eli Zaretskii <eliz@gnu.org>
6362
6363 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6364 came from a string character with a `cursor' property. (Bug#9229)
6365
ae9e757a
JD
63662011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6367
6368 * Makefile.in (LIB_PTHREAD): New variable.
6369 (LIBES): Add LIB_PTHREAD (Bug#9216).
6370
6371 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6372 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6373
213bd7f2
AS
63742011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6375
6b02f655 6376 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6377
99aaf75f
JD
63782011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6379
6380 * xterm.c (x_find_topmost_parent): New function.
6381 (x_set_frame_alpha): Find topmost parent window with
6382 x_find_topmost_parent and set the property there also (bug#9181).
6383 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6384
c74e9d86
PE
63852011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6386
6387 * callproc.c (Fcall_process): Avoid vfork clobbering
6388 the local vars buffer, coding_systems, current_dir.
6389
640c8776
SM
63902011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6391
6392 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6393
f26d0e4c
PE
63942011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6395
8a10d76c
PE
6396 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6397 so that it is not optimized away.
6398
f26d0e4c
PE
6399 * xdisp.c (compute_display_string_pos): Remove unused local.
6400
55439c61
EZ
64012011-08-02 Eli Zaretskii <eliz@gnu.org>
6402
6403 Fix slow cursor motion and scrolling in large buffers with
6404 selective display, like Org Mode buffers. (Bug#9218)
6405
6406 * dispextern.h (struct bidi_it): New member disp_prop_p.
6407
6408 * xdisp.c: Remove one-slot cache of display string positions.
6409 (compute_display_string_pos): Accept an additional argument
5e617bc2 6410 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6411 for a display string or property. If found, set DISP_PROP_P
6412 non-zero.
6413
6414 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6415 DISP_PROP_P, and pass it to compute_display_string_pos.
6416 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6417 non-zero. All callers of bidi_fetch_char changed.
6418
fb33fa43
SM
64192011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6420
6421 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6422
b099e063
DM
64232010-12-03 Don March <don@ohspite.net>
6424
6425 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6426 last character M-[char] is translated to ESC [char] (bug#7541).
6427
5cc7f7af
KH
64282011-08-02 Kenichi Handa <handa@m17n.org>
6429
d0fffa3f 6430 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6431
6432 * chartab.c (uniprop_table): Make it non-static.
6433
525d5e6e
EZ
64342011-08-01 Eli Zaretskii <eliz@gnu.org>
6435
6436 * xdisp.c (forward_to_next_line_start): Accept additional argument
6437 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6438 on the newline.
6439 (reseat_at_next_visible_line_start): Use the bidi iterator state
6440 returned by forward_to_next_line_start to restore the state of
6441 it->bidi_it after backing up to previous newline. (Bug#9212)
6442
31011111
AS
64432011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6444
6445 * regex.c (re_comp): Protoize.
6446 (re_exec): Fix return type.
6447 (regexec): Fix type of `ret'. (Bug#9203)
6448
476371c4
PE
64492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6450
e5d76069
PE
6451 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6452 This is needed if max-image-size is a floating-point number.
6453
9a79b20c
AS
64542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6455
6456 * print.c (print_object): Print empty symbol as ##.
6457
6458 * lread.c (read1): Read ## as empty symbol.
6459
d8c2fa78
AA
64602011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6461
6462 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6463 setting frame foreground color (Bug#9175).
6464 (x_set_background_color): Likewise.
6465
ffe57a7a
AA
6466 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6467 contents (Bug#9176).
6468 (EmacsTooltip -init): Remove bezels and add shadows to
6469 tooltip windows.
6470
bf3492a5
AA
6471 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6472 or scroll bar (Bug#8470).
6473
d55e9c53
AA
6474 * nsfont.m (nsfont_open): Remove assignment to voffset and
6475 unnecessary vars hshink, expand, hd, full_height, min_height.
6476 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6477
6478 * nsterm.h (nsfont_info): Remove voffset field.
6479
d8c2fa78 64802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6481
6482 Implement strike-through and overline on NextStep (Bug#8863).
6483
6484 * nsfont.m (nsfont_open): Use underline position provided by font,
6485 instead of hard-coded value of 2.
6486 (nsfont_draw): Call ns_draw_text_decoration instead.
6487
6488 * nsterm.h: Add declaration for ns_draw_text_decoration.
6489
6490 * nsterm.m (ns_draw_text_decoration): New function for drawing
6491 underline, overline, and strike-through.
6492 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6493 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6494 accommodate underlining, etc.
4843aac3 6495
4cc60b9b
EZ
64962011-07-28 Eli Zaretskii <eliz@gnu.org>
6497
bc7ece87
EZ
6498 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6499 default.
4cc60b9b 6500
476371c4
PE
65012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6502
66606eea
PE
6503 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6504 Without this fix, if a signal arrives just after memory fills up,
6505 'malloc' might be invoked reentrantly.
6506
476371c4
PE
6507 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6508 In other words, assume that every image size is allowed, on non-X
6509 hosts. This assumption is probably wrong, but it lets Emacs compile.
6510
f3fcc40d
AS
65112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6512
6513 * regex.c (re_iswctype): Convert return values to boolean.
6514
350c992f
EZ
65152011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6516
6517 * xdisp.c (compute_display_string_pos): Don't use cached display
6518 string position if the buffer had its restriction changed.
6519 (Bug#9184)
6520
5266b4bb
PE
65212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6524
2573a837 65252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6526
41f55ccd 6527 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6528
39e378da
PE
6529 * bidi.c: Integer size and overflow fixes.
6530 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6531 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6532 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6533 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6534 (bidi_find_other_level_edge):
6535 Use ptrdiff_t instead of EMACS_INT where either will do.
6536 This works better on 32-bit hosts configured --with-wide-int.
6537 (bidi_cache_ensure_space): Check for size-calculation overflow.
6538 Use % rather than repeated addition, for better worst-case speed.
6539 Don't set bidi_cache_size until after xrealloc returns, because it
6540 might not return.
6541 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6542 (bidi_cache_ensure_space): Also check that the bidi cache size
6543 does not exceed that of the largest Lisp string or buffer. See Eli
6544 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6545
5e927815
PE
6546 * alloc.c (__malloc_size_t): Remove.
6547 All uses replaced by size_t. See Andreas Schwab's note
6548 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6549
ca4aa935
PE
6550 * image.c: Improve checking for integer overflow.
6551 (check_image_size): Assume that f is nonnull, since
6552 it is always nonnull in practice. This is one less thing to
6553 worry about when checking for integer overflow later.
6554 (x_check_image_size): New function, which checks for integer
6555 overflow issues inside X.
6556 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6557 This removes the need for a memory_full check.
6558 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6559 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6560 (xbm_read_bitmap_data): Change locals back to 'int', since
6561 their values must fit in 'int'.
6562 (xpm_load_image, png_load, tiff_load):
6563 Invoke x_create_x_image_and_pixmap earlier,
6564 to avoid much needless work if the image is too large.
6565 (tiff_load): Treat overly large images as if
6566 x_create_x_image_and_pixmap failed, not as malloc failures.
6567 (gs_load): Use x_check_image_size.
6568
5f8f9cc2
PE
6569 * gtkutil.c: Omit integer casts.
6570 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6571 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6572
5adf60bc
PE
6573 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6574
c8907a93
PE
6575 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6576 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6577 would wrongly return t on a 64-bit host.
6578
e3c25c68
PE
6579 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6580 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6581 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6582 and therefore cause GCC to emit a bogus diagnostic in some cases.
6583
3f791afe
PE
6584 * image.c: Integer signedness and overflow and related fixes.
6585 This is not an exhaustive set of fixes, but it's time to
6586 record what I've got.
6587 (lookup_pixel_color, check_image_size): Remove redundant decls.
6588 (check_image_size): Don't assume that arbitrary EMACS_INT values
6589 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6590 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6591 (tiff_load, imagemagick_load_image):
6592 Check for overflow in size calculations.
6593 (x_create_x_image_and_pixmap): Remove unnecessary test for
6594 xmalloc returning NULL; that can't happen.
6595 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6596 (xpm_color_bucket): Use better integer hashing function.
6597 (xpm_cache_color): Don't possibly over-allocate memory.
6598 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6599 (gif_memory_source):
6600 Use ptrdiff_t, not int or size_t, to record sizes.
6601 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6602 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6603 either works, as we prefer signed integers.
6604 (tiff_read_from_memory, tiff_write_from_memory):
6605 Return tsize_t, not size_t, since that's what the TIFF API wants.
6606 (tiff_read_from_memory): Don't fail simply because the read would
6607 go past EOF; instead, return a short read.
6608 (tiff_load): Omit no-longer-needed casts.
6609 (Fimagemagick_types): Don't assume size fits into 'int'.
6610
3cc5a532
PE
6611 Improve hashing quality when configured --with-wide-int.
6612 * fns.c (hash_string): New function, taken from sxhash_string.
6613 Do not discard information about ASCII character case; this
6614 discarding is no longer needed.
6615 (sxhash-string): Use it. Change sig to match it. Caller changed.
6616 * lisp.h: Declare it.
6617 * lread.c (hash_string): Remove, since we now use fns.c's version.
6618 The fns.c version returns a wider integer if --with-wide-int is
6619 specified, so this should help the quality of the hashing a bit.
6620
b312a492
PE
6621 * emacs.c: Integer overflow minor fix.
6622 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6623 Define only if GNU_LINUX.
6624 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6625
dfd153ae
PE
6626 * dispnew.c: Integer signedness and overflow fixes.
6627 Remove unnecessary forward decls, that were a maintenance hassle.
6628 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6629 All uses changed.
6630 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6631 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6632 (prepare_desired_row, line_draw_cost):
6633 Use int, not unsigned, where either works.
6634 (save_current_matrix, restore_current_matrix):
6635 Use ptrdiff_t, not size_t, where either works.
6636 (init_display): Check for overflow more accurately, and without
6637 relying on undefined behavior.
6638
a81d11a3
PE
6639 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6640 Remove, replacing with the new symbols in lisp.h. All uses changed.
6641 * fileio.c (make_temp_name):
6642 * filelock.c (lock_file_1, lock_file):
6643 * xdisp.c (message_dolog):
6644 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6645 Use pMd etc. instead.
6646 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6647 replacing the pWIDE etc. symbols removed from editfns.c.
6648
3300e6fd
PE
6649 * keyboard.h (num_input_events): Now uintmax_t.
6650 This is (very slightly) less likely to mess up due to wraparound.
6651 All uses changed.
6652
fd05c7e9
PE
6653 * buffer.c: Integer signedness fixes.
6654 (alloc_buffer_text, enlarge_buffer_text):
6655 Use ptrdiff_t rather than size_t when either will do, as we prefer
6656 signed integers.
6657
903fe15d
PE
6658 * alloc.c: Integer signedness and overflow fixes.
6659 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6660 (__malloc_size_t): Default to size_t, not to int.
6661 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6662 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6663 Prefer ptrdiff_t to size_t when either would do, as we prefer
6664 signed integers.
6665 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6666 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6667 Now const. Initialize with values that are in range even if char
6668 is signed.
6669 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6670 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6671 These functions do the right thing with sizes > 2**32.
6672 (check_depth): Now ptrdiff_t, not int.
6673 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6674 Adjust to new way of storing sizes. Check for size overflow bugs
6675 in rest of code.
6676 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6677 slightly wrong anyway, as it missed one instance of
6678 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6679 (refill_memory_reserve): Omit needless cast to size_t.
6680 (mark_object_loop_halt): Mark as externally visible.
6681
ac82cc6a
PE
6682 * xselect.c: Integer signedness and overflow fixes.
6683 (Fx_register_dnd_atom, x_handle_dnd_message):
6684 Use ptrdiff_t, not size_t, since we prefer signed.
6685 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6686 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6687 x_dnd_atoms_size and x_dnd_atoms_length.
6688
c2d1e36d
PE
6689 * doprnt.c: Prefer signed to unsigned when either works.
6690 * eval.c (verror):
6691 * doprnt.c (doprnt):
6692 * lisp.h (doprnt):
6693 * xdisp.c (vmessage):
6694 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6695 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6696 prefer signed arithmetic to avoid comparison confusion.
6697 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6698 but is a bit tricky.
6699
0e926e56
PE
6700 Assume freestanding C89 headers, string.h, stdlib.h.
6701 * data.c, doprnt.c, floatfns.c, print.c:
6702 Include float.h unconditionally.
6703 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6704 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6705 * regex.c: Likewise for stddef.h, string.h.
6706 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6707 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6708 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6709 (STDC_HEADERS): Remove obsolete defines.
6710 * sysdep.c: Include limits.h unconditionally.
6711
9cfdb3ec
PE
6712 Assume support for memcmp, memcpy, memmove, memset.
6713 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6714 * regex.c (memcmp, memcpy):
6715 Remove; we assume C89 now.
6716
6717 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6718 (__malloc_safe_bcopy): Remove; no longer needed.
6719
cf950e6b 6720 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6721 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6722 well either way, and we prefer signed to unsigned.
6723
dbf38e02
LMI
67242011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6725
6726 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6727 closes the connection while we're reading (bug#9182).
6728
d6f0886c 67292011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6730
d6f0886c
JD
6731 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6732 are specified (Bug#9168).
24e0f6b1 6733
2eb1f9e6
PE
67342011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6735
6736 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6737 Found by GCC static checking and --with-wide-int on a 32-bit host.
6738
22381272 67392011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6740
6741 * xdisp.c (compute_display_string_pos): Fix logic of caching
6742 previous display string position. Initialize cached_prev_pos to
6743 -1. Fixes slow-down at the beginning of a buffer.
6744
f25e39b4
EZ
67452011-07-24 Eli Zaretskii <eliz@gnu.org>
6746
6747 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6748 for attrs[LFACE_FONTSET_INDEX].
6749
04c4b52e
PE
67502011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6751
6752 * xml.c (parse_region): Remove unused local
6753 that was recently introduced.
6754
c1734fbd
EZ
67552011-07-23 Eli Zaretskii <eliz@gnu.org>
6756
be18c5a5
EZ
6757 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6758 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6759
c1734fbd
EZ
6760 * xdisp.c (move_it_in_display_line_to): Record the best matching
6761 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6762 exit if none of the characters scanned was an exact match.
6763 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6764 when exact match is impossible due to invisible text, and the
6765 lines are truncated.
6766
a258d627
JD
67672011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6768
6769 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6770 for OSX >= 10.7.
6771
b6d5a689
EZ
67722011-07-22 Eli Zaretskii <eliz@gnu.org>
6773
0f74f785
EZ
6774 Fix a significant slow-down of cursor motion with C-n, C-p,
6775 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6776 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6777 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6778 (next_element_from_buffer): Call compute_stop_pos_backwards to
6779 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6780 base_level_stop.
6781 (reseat): Don't look for prev_stop, as that could mean a very long
6782 run.
6783 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6784 <cached_disp_overlay_modiff>: Cache for last found display string
6785 position.
551918c1 6786 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6787 about the same buffer in the same area of character positions, and
6788 the buffer wasn't changed since the time the display string
6789 position was cached.
551918c1 6790
b2d0c91a
EZ
67912011-07-22 Eli Zaretskii <eliz@gnu.org>
6792
6793 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6794 is an integer, which is important for empty lines. (Bug#9149)
6795
043604ee
CY
67962011-07-22 Chong Yidong <cyd@stupidchicken.com>
6797
6798 * frame.c (Fmodify_frame_parameters): In tty case, update the
6799 default face if necessary (Bug#4238).
6800
da4adb04
CY
68012011-07-21 Chong Yidong <cyd@stupidchicken.com>
6802
6803 * editfns.c (Fstring_to_char): No need to explain what a character
6804 is in the docstring (Bug#6576).
6805
9abd0532
LMI
68062011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6807
6808 * xml.c (parse_region): Make sure we always return a tree.
6809
36881d16
HK
68102011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6811
6812 * xml.c (parse_region): If a document contains only comments,
6813 return that, too.
6814
1e98674d
LMI
68152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6816
6817 * xml.c (make_dom): Return comments, too.
6818
590bd467
PE
68192011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6820
6821 Port to OpenBSD.
6822 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6823 and the surrounding thread.
6824 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6825 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6826 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6827 timer goes off.
6828 * s/openbsd.h (BROKEN_SIGIO): Define.
6829 * unexelf.c (unexec) [__OpenBSD__]:
6830 Don't update the .mdebug section of the Alpha COFF symbol table.
6831
f41628b2
LMI
68322011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6833
6834 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6835 (bug#8460).
6836
b59b67c5
PE
68372011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6838
15e3a074
PE
6839 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6840 This fixes some race conditions on the permissions of any newly
6841 created file.
6842
41bed37d
PE
6843 * alloc.c (valid_pointer_p): Use pipe, not open.
6844 This fixes some permissions issues when debugging.
6845
b59b67c5
PE
6846 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6847 If fchown fails to set both uid and gid, try to set just gid,
6848 as that is sometimes allowed. Adjust the file's mode to eliminate
6849 setuid or setgid bits that are inappropriate if fchown fails.
6850
925a6be7
SM
68512011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6852
6853 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6854 to compare Lisp_Objects.
6855 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6856 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6857 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6858
52968808
AS
68592011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6860
0a6a104b
AS
6861 * lread.c (read_integer): Unread even EOF character.
6862 (read1): Likewise. Properly record start position of symbol.
6863
52968808
AS
6864 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6865 symbol character follows.
6866
9e381cdd
PE
68672011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6868
6869 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6870 This works around a problem with the previous change to Fcopy_file.
6871 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6872 and without this change, GCC might complain about discarding
6873 fchown's return value.
6874
b5641435
JB
68752011-07-16 Juanma Barranquero <lekktu@gmail.com>
6876
6877 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6878
a8031457
PE
68792011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6880
6881 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6882
dd889327
LMI
68832011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6884
750c33f7
LMI
6885 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6886 it's used from the C level.
6887
dd889327
LMI
6888 * process.c: Use the same condition for POLL_FOR_INPUT in both
6889 keyboard.c and process.c (bug#1858).
6890
87e86684
LM
68912011-07-09 Lawrence Mitchell <wence@gmx.li>
6892
6893 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6894 (Fgnutls_boot): Use it.
6895
64348f40
AS
68962011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6897
6898 * doc.c (Fsubstitute_command_keys): Revert last change.
6899
1d698799
LMI
69002011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6901
f863868c
LMI
6902 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6903 quotes the next character, and doesn't affect other longer
6904 sequences (bug#8935).
6905
1d698799
LMI
6906 * lread.c (syms_of_lread): Clarify that is isn't only
6907 `eval-buffer' and `eval-defun' that's affected by
6908 `lexical-binding' (bug#8460).
6909
aa4b6df6
EZ
69102011-07-15 Eli Zaretskii <eliz@gnu.org>
6911
6912 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6913 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6914
5d856da6
PE
69152011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6916
ad6042bb
PE
6917 Fix minor problems found by static checking.
6918 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6919 (elsz): Now a signed constant, not a size_t var. We prefer signed
6920 types to unsigned, to avoid integer comparison confusion. Without
6921 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6922 "cannot optimize loop, the loop counter may overflow", a symptom
6923 of the confusion.
f00bbb22 6924 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6925 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6926
6468f31c
LMI
69272011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6928
49080b10
LMI
6929 * search.c (Fre_search_backward): Mention `case-fold-search' in
6930 all the re_search_* functions (bug#8138).
6931
6468f31c
LMI
6932 * keyboard.c (Fopen_dribble_file): Document when the file is
6933 closed (bug#8056).
6934
c965adc5
EZ
69352011-07-14 Eli Zaretskii <eliz@gnu.org>
6936
df9733bf
EZ
6937 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6938 bidi_cache_idx.
6939
0bb23927
EZ
6940 Support bidi reordering of display and overlay strings.
6941 * xdisp.c (compute_display_string_pos)
6942 (compute_display_string_end): Accept additional argument STRING.
6943 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6944 (reseat_to_string): Initialize bidi_it->string.s and
6945 bidi_it->string.schars.
6946 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6947 NULL (avoids a crash in bidi_paragraph_init).
6948 Initialize itb.string.lstring.
0bb23927
EZ
6949 (init_iterator): Call bidi_init_it only of a valid
6950 buffer position was specified. Initialize paragraph_embedding to
6951 L2R.
6952 (reseat_to_string): Initialize the bidi iterator.
6953 (display_string): If we need to ignore text properties of
6954 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6955 original value of -1 will not work with bidi.)
6956 (compute_display_string_pos): First arg is now struct
6957 `text_pos *'; all callers changed. Support display properties on
6958 Lisp strings.
6959 (compute_display_string_end): Support display properties on Lisp
6960 strings.
6961 (init_iterator, reseat_1, reseat_to_string): Initialize the
6962 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6963 when iterating on a string not from display properties).
640c8776
SM
6964 (compute_display_string_pos, compute_display_string_end):
6965 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6966 arrow keys.
6967 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6968 base_level_stop; instead, set base_level_stop to BEGV.
6969 Fixes crashes in vertical-motion.
0bb23927
EZ
6970 (next_element_from_buffer): Improve commentary for when
6971 the iterator is before prev_stop.
6972 (init_iterator): Initialize bidi_p from the default value of
6973 bidi-display-reordering, not from buffer-local value. Use the
6974 buffer-local value only if initializing for buffer iteration.
6975 (handle_invisible_prop): Support invisible properties on strings
6976 that are being bidi-reordered.
6977 (set_iterator_to_next): Support bidi reordering of C strings and
6978 Lisp strings.
6979 (next_element_from_string): Support bidi reordering of Lisp
6980 strings.
6981 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6982 (display_string): Support display of R2L glyph rows.
6983 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6984 (init_iterator): Don't initialize it->bidi_p for strings
6985 here.
6986 (reseat_to_string): Initialize it->bidi_p for strings here.
6987 (next_element_from_string, next_element_from_c_string)
6988 (next_element_from_buffer): Add xassert's for correspondence
6989 between IT's object being iterated and it->bidi_it.string
6990 structure.
6991 (face_before_or_after_it_pos): Support bidi iteration.
6992 (next_element_from_c_string): Handle the case of the first string
6993 character that is not the first one in the visual order.
6994 (get_visually_first_element): New function, refactored from common
6995 parts of next_element_from_buffer, next_element_from_string, and
6996 next_element_from_c_string.
6997 (tool_bar_lines_needed, redisplay_tool_bar)
6998 (display_menu_bar): Force left-to-right direction. Add a FIXME
6999 comment for making that be controlled by a user option.
7000 (push_it, pop_it): Save and restore the state of the
7001 bidi iterator. Save and restore the bidi_p flag.
7002 (pop_it): Iterate out of display property for string iteration as
7003 well.
7004 (iterate_out_of_display_property): Support iteration over strings.
7005 (handle_single_display_spec): Set up it->bidi_it for iteration
7006 over a display string, and call bidi_init_it.
7007 (handle_single_display_spec, next_overlay_string)
7008 (get_overlay_strings_1, push_display_prop): Set up the bidi
7009 iterator for displaying display or overlay strings.
7010 (forward_to_next_line_start): Don't use the shortcut if
7011 bidi-iterating.
7012 (back_to_previous_visible_line_start): If handle_display_prop
7013 pushed the iterator stack, restore the internal state of the bidi
7014 iterator by calling bidi_pop_it same number of times.
7015 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7016 and we are bidi-iterating, don't decrement the iterator position;
7017 instead, set the first_elt flag in the bidi iterator, to produce
7018 the same effect.
7019 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7020 (push_display_prop): xassert that we are iterating a buffer.
7021 (push_it, pop_it): Save and restore paragraph_embedding member.
7022 (handle_single_display_spec, next_overlay_string)
7023 (get_overlay_strings_1, reseat_1, reseat_to_string)
7024 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7025 correctly. Don't assume unibyte strings are not bidi-reordered.
7026 (compute_display_string_pos)
7027 (compute_display_string_end): Fix handling the case of C string.
7028 (push_it, pop_it): Save and restore from_disp_prop_p.
7029 (handle_single_display_spec, push_display_prop): Set the
7030 from_disp_prop_p flag.
7031 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7032 (pop_it): Call iterate_out_of_display_property only if we are
7033 popping after iteration over a string that came from a display
7034 property. Fix a typo in popping stretch info. Add an assertion
7035 for verifying that the iterator position is in sync with the bidi
7036 iterator.
7037 (handle_single_display_spec, get_overlay_strings_1)
7038 (push_display_prop): Fix initialization of paragraph direction for
7039 string when that of the parent object is not yet determined.
7040 (reseat_1): Call bidi_init_it to resync the bidi
7041 iterator with IT's position. (Bug#7616)
7042 (find_row_edges): If ROW->start.pos gives position
7043 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7044 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7045 Reset the from_disp_prop_p flag.
7046 (SAVE_IT, RESTORE_IT): New macros.
7047 (pos_visible_p, face_before_or_after_it_pos)
7048 (back_to_previous_visible_line_start)
7049 (move_it_in_display_line_to, move_it_in_display_line)
7050 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7051 (try_scrolling, redisplay_window, display_line): Use them when
7052 saving a temporary copy of the iterator and restoring it back.
7053 (back_to_previous_visible_line_start, reseat_1)
7054 (init_iterator): Empty the bidi cache "stack".
7055 (move_it_in_display_line_to): If iterator ended up at
7056 EOL, but we never saw any buffer positions smaller than
7057 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7058 motion in bidi-reordered lines.
7059 (move_it_in_display_line_to): Record prev_method and prev_pos
7060 immediately before the call to set_iterator_to_next. Fixes cursor
7061 motion in bidi-reordered lines with stretch glyphs and strings
7062 displayed in margins. (Bug#8133) (Bug#8867)
7063 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7064 TO_CHARPOS.
640c8776
SM
7065 (pos_visible_p): Support positions in bidi-reordered lines.
7066 Save and restore bidi cache.
0bb23927
EZ
7067
7068 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7069 (bidi_paragraph_info): Delete unused struct.
7070 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7071 (bidi_cache_start): New variable.
7072 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7073 to zero.
7074 (bidi_cache_fetch_state, bidi_cache_search)
7075 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7076 (bidi_cache_find, bidi_peek_at_next_level)
7077 (bidi_level_of_next_char, bidi_find_other_level_edge)
7078 (bidi_move_to_visually_next): Compare cache index with
7079 bidi_cache_start rather than with zero.
7080 (bidi_fetch_char): Accept new argument STRING; all callers
7081 changed. Support iteration over a string. Support strings with
7082 display properties. Support unibyte strings. Fix the type of
7083 `len' according to what STRING_CHAR_AND_LENGTH expects.
7084 (bidi_paragraph_init, bidi_resolve_explicit_1)
7085 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7086 (bidi_level_of_next_char, bidi_move_to_visually_next):
7087 Support iteration over a string.
0bb23927
EZ
7088 (bidi_set_sor_type, bidi_resolve_explicit_1)
7089 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7090 can now be zero (for strings); special values 0 and -1 were
7091 changed to -1 and -2, respectively.
7092 (bidi_char_at_pos): New function.
7093 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7094 Call it instead of FETCH_MULTIBYTE_CHAR.
7095 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7096 initialized to valid values.
7097 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7098 values.
7099 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7100 the test for valid cached positions. Fix the logic for looking up
7101 the sentinel state in the cache. GCPRO the Lisp string we are
7102 iterating.
7103 (bidi_push_it, bidi_pop_it): New functions.
7104 (bidi_initialize): Initialize the bidi cache start stack pointer.
7105 (bidi_cache_ensure_space): New function, refactored from part of
7106 bidi_cache_iterator_state. Don't assume the required size is just
7107 one BIDI_CACHE_CHUNK away.
7108 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7109 (bidi_count_bytes, bidi_char_at_pos): New functions.
7110 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7111 always valid if bidi_cache_idx is valid.
7112 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7113 is valid if it's going to be used.
7114 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7115 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7116 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7117 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7118 (bidi_find_other_level_edge, bidi_cache_start_stack):
7119 All variables related to cache indices are now EMACS_INT.
c965adc5 7120
0bb23927
EZ
7121 * dispextern.h (struct bidi_string_data): New structure.
7122 (struct bidi_it): New member `string'. Make flag members be 1-bit
7123 fields, and put them last in the struct.
640c8776
SM
7124 (compute_display_string_pos, compute_display_string_end):
7125 Update prototypes.
0bb23927
EZ
7126 (bidi_push_it, bidi_pop_it): Add prototypes.
7127 (struct iterator_stack_entry): New members bidi_p,
7128 paragraph_embedding, and from_disp_prop_p.
7129 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7130 (bidi_shelve_cache, bidi_unshelve_cache):
7131 Declare prototypes.
0bb23927
EZ
7132
7133 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7134 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7135 and vector-like objects.
7136
7137 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7138 cache around display iteration.
7139
7140 * window.c (Fwindow_end, window_scroll_pixel_based)
7141 (displayed_window_lines, Frecenter): Save and restore the bidi
7142 cache around display iteration.
7143
3bbd2265
LMI
71442011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7145
7146 * editfns.c (Fdelete_region): Clarify the use of the named
7147 parameters (bug#6788).
7148
adc47434
MR
71492011-07-14 Martin Rudalics <rudalics@gmx.at>
7150
7151 * indent.c (Fvertical_motion): Set and restore w->pointm when
7152 saving and restoring the window's buffer (Bug#9006).
7153
837c31f8
LMI
71542011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7155
7156 * editfns.c (Fstring_to_char): Clarify just what is returned
7157 (bug#6576). Text by Eli Zaretskii.
7158
ac389d0c
JB
71592011-07-13 Juanma Barranquero <lekktu@gmail.com>
7160
7161 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7162
0be0ce47
EZ
71632011-07-13 Eli Zaretskii <eliz@gnu.org>
7164
7165 * buffer.c (mmap_find): Fix a typo.
7166
cd18e7e3
JB
71672011-07-13 Johan Bockgård <bojohan@gnu.org>
7168
7169 Fix execution of x selection hooks.
7170 * xselect.c (Qx_lost_selection_functions)
7171 (Qx_sent_selection_functions): New vars.
7172 (syms_of_xselect): DEFSYM them.
7173 (x_handle_selection_request): Pass Qx_sent_selection_functions
7174 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7175 (x_handle_selection_clear,x_clear_frame_selections):
7176 Pass Qx_lost_selection_functions rather than
7177 Vx_lost_selection_functions to Frun_hook_with_args.
7178
47ea7f44
PE
71792011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7180
ac389d0c 7181 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7182 The old code sometimes used this field without initializing it.
7183
47ea7f44
PE
7184 * alloc.c (gc_sweep): Don't read past end of array.
7185 In theory, the old code could also have corrupted Emacs internals,
7186 though it'd be very unlikely.
7187
bc985c87
AS
71882011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7189
7190 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7191 argument. (Bug#4026)
bc985c87 7192
0cf34688
LMI
71932011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7194
b3dadd76
LMI
7195 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7196 key" (bug#4257).
7197
0cf34688
LMI
7198 * window.c (Fset_window_start): Doc fix (bug#4199).
7199 (Fset_window_hscroll): Ditto.
7200
270768cd
PE
72012011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7202
077e3dda 7203 Fix minor new problems caught by GCC 4.6.1.
270768cd 7204 * term.c (init_tty): Remove unused local.
490011a6 7205 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7206 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7207 not used otherwise.
270768cd 7208
b1f58454
CY
72092011-07-12 Chong Yidong <cyd@stupidchicken.com>
7210
7211 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7212
22b9578d
LMI
72132011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7214
6e70ab07
LMI
7215 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7216 are the mini-buffer and the echo area (bug#3320).
7217
22b9578d
LMI
7218 * term.c (init_tty): Remove support for supdup, c10 and perq
7219 terminals, which are no longer supported (bug#1482).
7220
8974cc9f
JB
72212011-07-10 Johan Bockgård <bojohan@gnu.org>
7222
7223 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7224
a560d974
JD
72252011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7226
7227 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7228 for non-popups (Bug#3642).
7229
1dae0f0a
AS
72302011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7231
268c2c36 7232 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7233 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7234 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7235 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7236 * data.c (fmod): Likewise.
7237 * dispnew.c (swap_glyphs_in_rows): Likewise.
7238 * emacs.c (memory_warning_signal): Likewise.
7239 * floatfns.c (float_error): Likewise.
7240 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7241 (otf_open, font_otf_capability, generate_otf_features)
7242 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7243 Likewise.
7244 * image.c (pbm_read_file): Likewise.
7245 * indent.c (string_display_width): Likewise.
7246 * intervals.c (check_for_interval, search_for_interval)
7247 (inc_interval_count, count_intervals, root_interval)
7248 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7249 * lread.c (defalias): Likewise.
268c2c36 7250 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7251 * regex.c (set_image_of_range_1, set_image_of_range)
7252 (regex_grow_registers): Likewise.
7253 * sysdep.c (strerror): Likewise.
7254 * termcap.c (valid_filename_p, tprint, main): Likewise.
7255 * tparam.c (main): Likewise.
7256 * unexhp9k800.c (run_time_remap, save_data_space)
7257 (update_file_ptrs, read_header, write_header, calculate_checksum)
7258 (copy_file, copy_rest, display_header): Likewise.
7259 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7260 Likewise.
7261 * xdisp.c (check_it): Likewise.
7262 * xfaces.c (register_color, unregister_color, unregister_colors):
7263 Likewise.
7264 * xfns.c (print_fontset_result): Likewise.
7265 * xrdb.c (member, fatal, main): Likewise.
7266
99033785
PE
72672011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7268
7269 Fix minor problems found by static checking (Bug#9031).
7270 * chartab.c (char_table_set_range, map_sub_char_table):
7271 Remove unused locals.
7272 (uniprop_table): Now static.
7273 * composite.c (_work_char): Remove unused static var.
7274
9cb2ac56
JB
72752011-07-09 Juanma Barranquero <lekktu@gmail.com>
7276
7277 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7278
f25661f0
JD
72792011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7280
7281 * gtkutil.c (qttip_cb): Remove code without function.
7282
8278c4fe
EZ
72832011-07-09 Eli Zaretskii <eliz@gnu.org>
7284
7285 * w32.c (pthread_sigmask): New stub.
7286
1692ae2d 72872011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7288
8a6ebd58 7289 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7290 sigprocmask is portable only for single-threaded applications, and
7291 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7292 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7293 (LIBES): Use it.
7294 * callproc.c (Fcall_process):
7295 * process.c (create_process):
7296 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7297 Use pthread_sigmask, not sigprocmask.
123403e4 7298
1b854618
JD
72992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7300
7301 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7302 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7303 wrong (Bug#8591).
7304
3fe4b549
JD
73052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7306
0ce7e563
JD
7307 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7308 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7309 (xg_hide_tooltip): Fix comment.
7310
3fe4b549
JD
7311 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7312 in registerServicesMenuSendTypes.
7313 (validRequestorForSendType): Don't check ns_return_types.
7314
7315 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7316 ns_return_type.
7317
5df75e47
JR
73182011-07-08 Jason Rumney <jasonr@gnu.org>
7319
22610910
JR
7320 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7321 SH_SHOW for hidden windows (Bug#5482).
7322
5df75e47
JR
7323 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7324 frame struct members of non-existent frames (Bug#6284).
7325
699c10bd
JD
73262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7327
4393663b
JD
7328 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7329 variable firstTime not needed on OSX >= 10.6.
7330 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7331 >= 10.5. Use setKnobProportion, setDoubleValue.
7332
7333 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7334 (MAC_OS_X_VERSION_10_5): Define if not defined.
7335 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7336 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7337 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7338
7339 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7340 cString and lossyCString on OSX >= 10.4
7341
58179cce 7342 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7343 sizeToFit on OSX >= 10.2.
7344
7345 * nsimage.m (allocInitFromFile): Don't use deprecated method
7346 bestRepresentationForDevice on OSX >= 10.6.
7347
7348 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7349 to avoid warning.
7350
7351 * emacs.c: Declare unexec_init_emacs_zone.
7352
a63e0781
JD
7353 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7354
699c10bd
JD
7355 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7356
7357 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7358 on svcsMenu (Bug#8842).
7359
7360 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7361 ns_return_types.
7362 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7363
7364 * nsterm.m (QUTF8_STRING): Declare.
7365 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7366 (validRequestorForSendType): Return type is (id).
7367 Change indexOfObjectIdenticalTo to indexOfObject.
7368 Check if we have local selection before returning self (Bug#8842).
7369 (writeSelectionToPasteboard): Put local selection into paste board
7370 if we have a local selection (Bug#8842).
7371 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7372
7373 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7374 (ns_get_local_selection): Declare.
7375
54e10184
LMI
73762011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7377
9888ff71
LMI
7378 * keymap.c (describe_map_tree): Don't insert a double newline at
7379 the end of the buffer (bug#1169) and return whether we inserted
7380 something.
7381
54e10184
LMI
7382 * callint.c (Fcall_interactively): Change "reading args" to
7383 "providing args" to try to clarify what it does (bug#1010).
7384
15fa4783
KH
73852011-07-07 Kenichi Handa <handa@m17n.org>
7386
7387 * composite.c (composition_compute_stop_pos): Ignore a static
7388 composition starting before CHARPOS (Bug#8915).
7389
7390 * xdisp.c (handle_composition_prop): Likewise.
7391
a8815b00
EZ
73922011-07-07 Eli Zaretskii <eliz@gnu.org>
7393
7394 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7395 (Bug#9015)
7396
ef7b981d 73972011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7398
7399 * character.h (unicode_category_t): New enum type.
7400
7401 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7402 (Qchar_code_property_table): New variable.
7403 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7404 (UNIPROP_COMPRESSED_FORM_P): New macros.
7405 (char_table_ascii): Uncompress the compressed values.
7406 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7407 Uncompress the compressed values.
ac389d0c 7408 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7409 (char_table_ref_and_range): Uncompress the compressed values.
7410 (sub_char_table_set): New arg is_uniprop. Callers changed.
7411 Uncompress the compressed values.
7412 (sub_char_table_set_range): Args changed. Callers changed.
7413 (char_table_set_range): Adjuted for the above change.
7414 (map_sub_char_table): Delete args default_val and parent. Add arg
7415 top. Give decoded values to a Lisp function.
640c8776 7416 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7417 values to a Lisp function. Gcpro more variables.
7418 (uniprop_table_uncompress)
7419 (uniprop_decode_value_run_length): New functions.
7420 (uniprop_decoder, uniprop_decoder_count): New variables.
7421 (uniprop_get_decoder, uniprop_encode_value_character)
7422 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7423 New functions.
7424 (uniprop_encoder, uniprop_encoder_count): New variables.
7425 (uniprop_get_encoder, uniprop_table)
7426 (Funicode_property_table_internal, Fget_unicode_property_internal)
7427 (Fput_unicode_property_internal): New functions.
7428 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7429 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7430 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7431 char-code-property-alist.
7432
640c8776 7433 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7434 Vunicode_category_table.
7435
640c8776 7436 * font.c (font_range): Adjust for the change of
c805dec0
KH
7437 Vunicode_category_table.
7438
76b397fb
DN
74392011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7440
7441 * m/iris4d.h: Remove file, move contents ...
7442 * s/irix6-5.h: ... here.
7443
22b4128e
PE
74442011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7445
7446 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7447 * alloc.c (mark_buffer):
7448 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7449 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7450 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7451 This isn't true in general, and it's particularly not true
7452 if Emacs is configured with --with-wide-int.
7453 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7454 New macros, used in the buffer.c change.
7455
869795d6
JD
74562011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7457
7458 * xsettings.c: Use both GConf and GSettings if both are available.
7459 (store_config_changed_event): Add comment.
7460 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7461 (store_tool_bar_style_changed): New functions.
5e617bc2 7462 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7463 (struct xsettings): Move font inside HAVE_XFT.
7464 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7465 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7466 Move inside HAVE_XFT.
640c8776 7467 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7468 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7469 also.
7470 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7471 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7472 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7473 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7474 (parse_settings): Move check for font inside HAVE_XFT.
7475 (read_settings, apply_xft_settings): Add comment.
7476 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7477 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7478 call store_font_name_changed.
7479 (xft_settings_event): Add comment.
7480 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7481 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7482 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7483 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7484 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7485 (xsettings_get_system_font, xsettings_get_system_normal_font):
7486 Add comment.
869795d6 7487
d8ed26bd
PE
74882011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7489
7490 Random fixes. E.g., (random) never returned negative values.
7491 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7492 subseconds part to the entropy, as that's a bit more random.
7493 Prefer signed to unsigned, since the signedness doesn't matter and
7494 in general we prefer signed. When given a limit, use a
7495 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7496 latter isn't right if USE_2_TAGS_FOR_INTS.
7497 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7498 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7499
cabf1cac
SM
75002011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7501
7502 * textprop.c (text_property_stickiness):
7503 Obey Vtext_property_default_nonsticky.
7504 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7505 * w32fns.c (syms_of_w32fns):
7506 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7507
6e9b2be9
PE
75082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7511 This is more efficient than Ffile_directory_p and avoids a minor race.
7512
90186c68
LMI
75132011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7514
7c301272
LMI
7515 * buffer.c (Foverlay_put): Say what the return value is
7516 (bug#7835).
7517
c4f2d8d4
LMI
7518 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7519 is a directory before asking whether to use the file name
7520 (bug#7564).
ad637907
LMI
7521 (barf_or_query_if_file_exists): Make the "File is a directory"
7522 error be more correct.
c4f2d8d4 7523
90186c68
LMI
7524 * fns.c (Frequire): Remove the mention of the .gz files, since
7525 that's installation-specific, but keep the mention of
7526 `get-load-suffixes'.
7527
da64016e
PE
75282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7529
7530 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7531 Report string overflow if the output is too long.
7532
7d47b580
JB
75332011-07-04 Juanma Barranquero <lekktu@gmail.com>
7534
a555cb87
JB
7535 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7536 (syms_of_gnutls): Remove duplicate DEFSYM for
7537 Qgnutls_bootprop_verify_hostname_error, an error for
7538 Qgnutls_bootprop_verify_error (which is no longer used).
7539
7d47b580
JB
7540 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7541 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7542 Also (re)move comments that are misplaced or no longer relevant.
7543
1e49bfab
LMI
75442011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545
7546 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7547
1485f4c0
CY
75482011-07-03 Chong Yidong <cyd@stupidchicken.com>
7549
7550 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7551 and background color parameters if they have been changed.
7552
a9ab721e
LMI
75532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7554
7555 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7556
cf7cff57
PE
75572011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7558
2e13213d
PE
7559 * xsettings.c (SYSTEM_FONT): Define only when used.
7560 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7561
cf7cff57
PE
7562 * keymap.c (access_keymap_1): Now static.
7563
7a8e04f7
CY
75642011-07-02 Chong Yidong <cyd@stupidchicken.com>
7565
7566 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7567 leave any prefix arg for the up event (Bug#1586).
7568
61352f62
LMI
75692011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7570
69bb1ef7
LMI
7571 * lread.c (syms_of_lread): Mention single symbols defined by
7572 `defvar' or `defconst' (bug#7154).
7573
61352f62 7574 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7575 (Frequire): Mention get-load-suffixes.
61352f62 7576
28545e04
MR
75772011-07-02 Martin Rudalics <rudalics@gmx.at>
7578
7579 * window.h (window): Remove clone_number slot.
7580 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7581 Remove.
7582 (make_parent_window, make_window, saved_window)
7583 (Fset_window_configuration, save_window_save): Don't deal with
7584 clone numbers.
7585 * buffer.c (Qclone_number): Remove declaration.
7586 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7587
3349e122
SM
75882011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7589
7590 Add multiple inheritance to keymaps.
7591 * keymap.c (Fmake_composed_keymap): New function.
7592 (Fset_keymap_parent): Simplify.
7593 (fix_submap_inheritance): Remove.
7594 (access_keymap_1): New function extracted from access_keymap to handle
7595 embedded parents and handle lists of maps.
7596 (access_keymap): Use it.
7597 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7598 (Fcopy_keymap): Handle embedded parents.
7599 (Fcommand_remapping, define_as_prefix): Simplify.
7600 (Fkey_binding): Simplify.
7601 (syms_of_keymap): Move minibuffer-local-completion-map,
7602 minibuffer-local-filename-completion-map,
7603 minibuffer-local-must-match-map, and
7604 minibuffer-local-filename-must-match-map to Elisp.
7605 (syms_of_keymap): Defsubr make-composed-keymap.
7606 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7607 (parse_menu_item): Trivial simplification.
7608
3279eb87
GM
76092011-07-01 Glenn Morris <rgm@gnu.org>
7610
7611 * Makefile.in (SETTINGS_LIBS): Fix typo.
7612
4550efdf
KI
76132011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7614
7615 * coding.c (Fencode_coding_string): Record the last coding system
7616 used, as the function doc string says (bug#8738).
7617
0949d2b6
JD
76182011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7619
7620 * xsettings.c (store_monospaced_changed): Take new font as arg and
7621 check for change against current_mono_font.
7622 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7623 (emacs_settings_constructor, emacs_settings_get_property)
7624 (emacs_settings_set_property, emacs_settings_class_init)
7625 (emacs_settings_init, gsettings_obj): Remove.
7626 (something_changedCB): New function for HAVE_GSETTINGS.
7627 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7628 with value as argument.
7629 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7630 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7631 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7632 "changed".
7633
7634 * xgselect.c: Add defined (HAVE_GSETTINGS).
7635 (xgselect_initialize): Ditto.
7636
7637 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7638 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7639 xg_select.
7640
bbc6b304
PE
76412011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7642
7643 * eval.c (struct backtrace): Simplify and port the data structure.
7644 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7645 signed bit field, as this assumption is not portable and it makes
7646 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7647 "char debug_on_exit : 1" as this is not portable either; instead,
7648 use the portable "unsigned int debug_on_exit : 1". Remove unused
7649 member evalargs. Remove obsolete comments about cc bombing out.
7650
9851bfc5
JD
76512011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7652
51bb811f 7653 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7654 Let HAVE_GSETTINGS override HAVE_GCONF.
7655 (store_monospaced_changed): New function.
7656 (EMACS_SETTINGS): A new type derived from GObject to handle
7657 GSettings notifications.
7658 (emacs_settings_constructor, emacs_settings_get_property)
7659 (emacs_settings_set_property, emacs_settings_class_init):
7660 New functions.
7661 (gsettings_client, gsettings_obj): New variables.
7662 (GSETTINGS_SCHEMA): New define.
7663 (something_changedCB): Call store_monospaced_changed.
7664 (init_gsettings): New function.
7665 (xsettings_initialize): Call init_gsettings.
7666 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7667 to NULL.
7668
640c8776 7669 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7670 GCONF_CFLAGS/LIBS.
7671
5386012d
MR
76722011-06-29 Martin Rudalics <rudalics@gmx.at>
7673
7674 * window.c (resize_root_window, grow_mini_window)
7675 (shrink_mini_window): Rename Qresize_root_window to
7676 Qwindow_resize_root_window and Qresize_root_window_vertically to
7677 Qwindow_resize_root_window_vertically.
7678
f13e0b08
PE
76792011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7680
7681 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7682
94515237
JB
76832011-06-27 Juanma Barranquero <lekktu@gmail.com>
7684
7685 * makefile.w32-in: Redesign dependencies so they reflect more
7686 clearly which files are directly included by each source file,
7687 and not through other includes.
7688
e43b6e43
MR
76892011-06-27 Martin Rudalics <rudalics@gmx.at>
7690
7691 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7692 (sort_overlays, overlay_strings): When an overlay's clone number
7693 matches the window's clone number process the overlay even if
7694 the overlay's window property doesn't match the current window.
7695
d68443dc
MR
7696 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7697 (Fwindow_hchild): Rename to Fwindow_left_child.
7698 (Fwindow_next): Rename to Fwindow_next_sibling.
7699 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7700 (resize_window_check): Rename to window_resize_check.
7701 (resize_window_apply): Rename to window_resize_apply.
7702 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7703 (Fdelete_other_windows_internal, resize_frame_windows)
7704 (Fsplit_window_internal, Fdelete_window_internal)
7705 (grow_mini_window, shrink_mini_window)
7706 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7707
c7e73be5
JD
77082011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7709
7710 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7711 (emacs_fixed_set_min_size): Remove.
7712 (emacs_fixed_new): Take frame as argument.
7713
7714 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7715 (_EmacsFixedPrivate): Remove minwidth/height.
7716 Add struct frame *f.
7717 (emacs_fixed_init): Initialize priv->f.
7718 (get_parent_class, emacs_fixed_set_min_size): Remove.
7719 (emacs_fixed_new): Set priv->f to argument.
7720 (emacs_fixed_get_preferred_width)
7721 (emacs_fixed_get_preferred_height): Use min_width/height from
7722 frames size_hint to set minimum and natural (Bug#8919).
7723 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7724 and use min_width/height from frames size_hint to set
7725 min_width/height (Bug#8919).
7726
7727 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7728 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7729 Fix indentation.
c7e73be5 7730
cf99dcf8
EZ
77312011-06-26 Eli Zaretskii <eliz@gnu.org>
7732
7733 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7734 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7735 called at ZV.
7736
029529ac
CY
77372011-06-26 Chong Yidong <cyd@stupidchicken.com>
7738
7739 * process.c (wait_reading_process_output): Bypass select if
7740 waiting for a cell while ignoring keyboard input, and input is
7741 pending. Suggested by Jan Djärv (Bug#8869).
7742
7a7ef429
PE
77432011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7744
7745 Use gnulib's dup2 module instead of rolling our own.
7746 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7747
11fdef7d 77482011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7749
7750 * dispnew.c (scrolling_window): Before scrolling, turn off a
7751 mouse-highlight in the window being scrolled.
7752
cd3520a4
JB
77532011-06-24 Juanma Barranquero <lekktu@gmail.com>
7754
7755 Move DEFSYM to lisp.h and use everywhere.
7756
7757 * character.h (DEFSYM): Move declaration...
7758 * lisp.h (DEFSYM): ...here.
7759
7760 * gnutls.c:
7761 * minibuf.c:
7762 * w32menu.c:
7763 * w32proc.c:
7764 * w32select.c: Don't include character.h.
7765
7766 * alloc.c (syms_of_alloc):
7767 * buffer.c (syms_of_buffer):
7768 * bytecode.c (syms_of_bytecode):
7769 * callint.c (syms_of_callint):
7770 * casefiddle.c (syms_of_casefiddle):
7771 * casetab.c (init_casetab_once):
7772 * category.c (init_category_once, syms_of_category):
7773 * ccl.c (syms_of_ccl):
7774 * cmds.c (syms_of_cmds):
7775 * composite.c (syms_of_composite):
7776 * dbusbind.c (syms_of_dbusbind):
7777 * dired.c (syms_of_dired):
7778 * dispnew.c (syms_of_display):
7779 * doc.c (syms_of_doc):
7780 * editfns.c (syms_of_editfns):
7781 * emacs.c (syms_of_emacs):
7782 * eval.c (syms_of_eval):
7783 * fileio.c (syms_of_fileio):
7784 * fns.c (syms_of_fns):
7785 * frame.c (syms_of_frame):
7786 * fringe.c (syms_of_fringe):
7787 * insdel.c (syms_of_insdel):
7788 * keymap.c (syms_of_keymap):
7789 * lread.c (init_obarray, syms_of_lread):
7790 * macros.c (syms_of_macros):
7791 * msdos.c (syms_of_msdos):
7792 * print.c (syms_of_print):
7793 * process.c (syms_of_process):
7794 * search.c (syms_of_search):
7795 * sound.c (syms_of_sound):
7796 * syntax.c (init_syntax_once, syms_of_syntax):
7797 * terminal.c (syms_of_terminal):
7798 * textprop.c (syms_of_textprop):
7799 * undo.c (syms_of_undo):
7800 * w32.c (globals_of_w32):
7801 * window.c (syms_of_window):
7802 * xdisp.c (syms_of_xdisp):
7803 * xfaces.c (syms_of_xfaces):
7804 * xfns.c (syms_of_xfns):
7805 * xmenu.c (syms_of_xmenu):
7806 * xsettings.c (syms_of_xsettings):
7807 * xterm.c (syms_of_xterm): Use DEFSYM.
7808
4228cf16
TZ
78092011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7810
cd3520a4 7811 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7812
7fcccf1e
PE
78132011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7814
7efb4e0e
PE
7815 Integer and buffer overflow fixes (Bug#8873).
7816
ff5844ad
PE
7817 * print.c (printchar, strout): Check for string overflow.
7818 (PRINTPREPARE, printchar, strout):
7819 Don't set size unless allocation succeeds.
7820
90532f02
PE
7821 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7822 for sizes. Check for string overflow more accurately.
7823 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7824
6d84508d
PE
7825 * macros.c: Integer and buffer overflow fixes.
7826 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7827 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7828 Use ptrdiff_t, not int, for sizes.
7829 Don't increment bufsize until after realloc succeeds.
7830 Check for size-calculation overflow.
7831 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7832
437b2cb4
PE
7833 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7834
8b9ac8b4
PE
7835 * lread.c: Integer overflow fixes.
7836 (read_integer): Radix is now EMACS_INT, not int,
7837 to improve quality of diagnostics for out-of-range radices.
7838 Calculate buffer size correctly for out-of-range radices.
7839 (read1): Check for integer overflow in radices, and in
7840 read-circle numbers.
82cb60d3
PE
7841 (read_escape): Avoid int overflow.
7842 (Fload, openp, read_buffer_size, read1)
7843 (substitute_object_recurse, read_vector, read_list, map_obarray):
7844 Use ptrdiff_t, not int, for sizes.
7845 (read1): Use EMACS_INT, not int, for sizes.
20270765 7846 Check for size overflow.
8b9ac8b4 7847
7fcccf1e
PE
7848 * image.c (cache_image): Check for size arithmetic overflow.
7849
bfbbd7e7
PE
7850 * lread.c: Integer overflow issues.
7851 (saved_doc_string_size, saved_doc_string_length)
7852 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7853 Now ptrdiff_t, not int.
7854 (read1): Don't assume doc string length fits in int. Check for
7855 out-of-range doc string lengths.
7856 (read_list): Don't assume file position fits in int.
39019e54 7857 (read_escape): Check for hex character overflow.
bfbbd7e7 7858
4e323265
LL
78592011-06-22 Leo Liu <sdl.web@gmail.com>
7860
7861 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7862 Move to minibuffer.el.
7863
85fece3e
PE
78642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7865
20b84ce9 7866 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7867 The following patches are for when GLYPH_DEBUG && !XASSERT.
7868 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7869 * dispnew.c (flush_stdout):
7870 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7871 Mark as externally visible.
7872 * dispnew.c (check_window_matrix_pointers): Now static.
7873 * dispnew.c (window_to_frame_vpos):
7874 * xfns.c (unwind_create_frame):
7875 * xterm.c (x_check_font): Remove unused local.
7876 * scroll.c (CHECK_BOUNDS):
7877 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7878 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7879 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7880 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7881 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7882 Now static.
7883 (debug_method_add): Use va_list and vsprintf rather than relying
7884 on undefined behavior with wrong number of arguments.
7885 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7886 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7887 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7888 since we're not interested in debugging glyphs with old libraries.
7889 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7890 GCC 4.6.0's static checking.
7891
0766b489
PE
78922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7893
31fd4b32
PE
7894 Integer overflow and signedness fixes (Bug#8873).
7895 A few related buffer overrun fixes, too.
7896
b79e8648
PE
7897 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7898
0766b489
PE
7899 * dispextern.h (struct face.stipple):
7900 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7901 (x_bitmap_mask, x_allocate_bitmap_record)
7902 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7903 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7904 (x_create_bitmap_from_xpm_data):
7905 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7906 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7907 (.bitmaps_last):
7908 * xfaces.c (load_pixmap):
7909 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7910 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7911 (.bitmaps_last, struct x_output.icon_bitmap):
7912 Use ptrdiff_t, not int, for bitmap indexes.
7913 (x_allocate_bitmap_record): Check for size overflow.
7914 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7915
b081724f
PE
7916 Use ptrdiff_t, not int, for overlay counts.
7917 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7918 * editfns.c (overlays_around, get_pos_property):
7919 * textprop.c (get_char_property_and_overlay):
7920 * xdisp.c (next_overlay_change, note_mouse_highlight):
7921 * xfaces.c (face_at_buffer_position):
21514da7
PE
7922 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7923 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7924 (Fnext_overlay_change, Fprevious_overlay_change)
7925 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7926 Use ptrdiff_t, not int, for sizes.
21514da7 7927 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7928
3de73e5e
PE
7929 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7930
2606c57b
PE
7931 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7932 (x_session_initialize): Do not assume string length fits in int.
7933
aaafe47a
PE
7934 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7935 This is unlikely, but can occur if DPI is outlandish.
7936
2674ddc8 7937 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7938 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7939
28154962
PE
7940 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7941 * xrdb.c (magic_file_p, search_magic_path):
7942 Omit last arg SUFFIX; it was always 0. All callers changed.
7943 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7944
7de51af5
PE
7945 * xfont.c (xfont_match): Avoid need for strlen.
7946
25ed6cc3
PE
7947 * xfns.c: Don't assume strlen fits in int.
7948 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7949
4eab31dd
PE
7950 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7951 not unsigned long, as we prefer signed integers. All callers changed.
7952 Detect integer overflow in repeat count.
7953 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7954 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7955
171e2a58
PE
7956 * termcap.c: Don't assume sizes fit in int and never overflow.
7957 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7958 (gobble_line): Check for size-calculation overflow.
7959
ad39faca 7960 * minibuf.c (Fread_buffer):
6e5bb2dc 7961 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7962 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7963 Don't assume string length fits in int.
7964
52c61c22 7965 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7966 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7967
b5b8c9e5
PE
7968 * font.c: Don't assume string length fits in int.
7969 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7970 Use ptrdiff_t, not int.
ccd6111c
PE
7971 (font_intern_prop): Don't assume string length fits in int.
7972 Don't assume integer property fits in fixnum.
7973 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7974
882f0d81 7975 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7976 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7977 Reformulate so as not to need the command string.
7978 Invoke gzip -cd rather than gunzip, as it's more portable.
7979 (lock_info_type, lock_file_1, lock_file):
7980 Don't assume pid_t and time_t fit in unsigned long.
7981 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7982 (current_lock_owner): Prefer signed type for sizes.
7983 Use memcpy, not strncpy, where memcpy is what is really wanted.
7984 Don't assume (via atoi) that time_t and pid_t fit in int.
7985 Check for time_t and/or pid_t out of range, e.g., via a network share.
7986 Don't alloca where an auto var works fine.
7987
93f4cf88
PE
7988 * fileio.c: Fix some integer overflow issues.
7989 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7990 Don't assume string length fits in int.
7991 (directory_file_name): Don't assume string length fits in long.
7992 (make_temp_name): Don't assume pid fits in int, or that its print
7993 length is less than 20.
7994
f3e92b69
PE
7995 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7996
1bfdaf10
PE
7997 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7998
35016e9a
PE
7999 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8000
3d1e65a1
PE
8001 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8002 We prefer signed integers, even for size calculations.
8003
0b963a93
PE
8004 * emacs.c: Don't assume string length fits in 'int'.
8005 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8006 (main): Don't invoke strlen when not needed.
8007
573f4b54
PE
8008 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8009 (XD_DEBUG_MESSAGE): Don't waste a byte.
8010
989f33ba
PE
8011 * callproc.c (getenv_internal_1, getenv_internal)
8012 (Fgetenv_internal):
965d34eb
PE
8013 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8014
e4d29b33
PE
8015 * lread.c (invalid_syntax): Omit length argument.
8016 All uses changed. This doesn't fix a bug, but it simplifies the
8017 code away from its former Hollerith-constant appearance, and it's
8018 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8019 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8020
eb49b136
PE
8021 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8022 This didn't break anything, but it didn't help either.
8023 It's confusing to put a bogus integer in a place where the actual
8024 value does not matter.
9f62aeb1 8025 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8026 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8027
15375a22
PE
8028 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8029 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8030 implementation.
b61cc01c
PE
8031 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8032 We prefer signed types, and the value cannot exceed the EMACS_INT
8033 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8034 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8035 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8036 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8037
53b2623d
PE
8038 * indent.c (sane_tab_width): New function.
8039 (current_column, scan_for_column, Findent_to, position_indentation)
8040 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8041 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8042
51cab52b 8043 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8044
f2ed8a70
PE
8045 * lisp.h (lint_assume): New macro.
8046 * composite.c (composition_gstring_put_cache):
8047 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8048
abe80cc6
PE
8049 * editfns.c, insdel.c:
8050 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8051
b02c740e
PE
8052 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8053
ebc96716
PE
8054 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8055
b4e50fa0 8056 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8057 Use much-faster test for byte-length change.
311d5d7c 8058 Don't assume string byte-length fits in 'int'.
a4cf38e4 8059 Check that character arg fits in 'int'.
85461888 8060 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8061
c0c1ee9f
PE
8062 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8063
a498d7f4
PE
8064 * fns.c (concat): Catch string overflow earlier.
8065 Do not rely on integer wraparound.
8066
51cab52b
PE
8067 * dispextern.h (struct it.overlay_strings_charpos)
8068 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8069 * xdisp.c (forward_to_next_line_start)
8070 (back_to_previous_visible_line_start)
8071 (reseat_at_next_visible_line_start, next_element_from_buffer):
8072 Don't arbitrarily truncate the value of 'selective' to int.
8073
76031fad
PE
8074 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8075
5eb55db9
PE
8076 * composite.c: Don't truncate sizes to 'int'.
8077 (composition_gstring_p, composition_reseat_it)
8078 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8079 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8080 not EMACS_UINT, for indexes.
5eb55db9 8081
0703a717
PE
8082 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8083
d6202519
PE
8084 * buffer.c: Include <verify.h>.
8085 (struct sortvec.priority, struct sortstr.priority):
8961a454 8086 Now EMACS_INT, not int.
c20998a7 8087 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8088 (struct sortstr.size, record_overlay_string)
8089 (struct sortstrlist.size, struct sortlist.used):
8090 Don't truncate size to int.
8091 (record_overlay_string): Check for size-calculation overflow.
d6202519 8092 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8093
d5a19415
JM
80942011-06-22 Jim Meyering <meyering@redhat.com>
8095
029529ac 8096 Don't leak an XBM-image-sized buffer
d5a19415
JM
8097 * image.c (xbm_load): Free the image buffer after using it.
8098
a9041e6c
PE
80992011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8100
8101 Port to Sun C.
8102 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8103 that Sun C diagnosed.
8104 * fns.c (secure_hash): Fix pointer signedness issue.
8105 * intervals.c (static_offset_intervals): New function.
8106 (offset_intervals): Use it.
8107
7f3f739f
LL
81082011-06-21 Leo Liu <sdl.web@gmail.com>
8109
8110 * deps.mk (fns.o):
8111 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8112 sha512.h.
8113
8114 * fns.c (secure_hash): Rename from crypto_hash_function and change
8115 the first arg to accept symbols.
5b66d427 8116 (Fsecure_hash): New primitive.
7f3f739f
LL
8117 (syms_of_fns): New symbols.
8118
76147d94
DD
81192011-06-20 Deniz Dogan <deniz@dogan.se>
8120
8121 * process.c (Fset_process_buffer): Clarify return value in
8122 docstring.
8123
7d7d0045
CY
81242011-06-18 Chong Yidong <cyd@stupidchicken.com>
8125
8126 * dispnew.c (add_window_display_history): Use BVAR.
8127
8128 * xdisp.c (debug_method_add): Use BVAR.
8129 (check_window_end, dump_glyph_matrix, dump_glyph)
8130 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8131
8132 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8133 Likewise.
8134
8135 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8136 check till after the cache is created in init_frame_faces.
8137
ff2bc410
SM
81382011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8139
8140 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8141
28177add
PE
81422011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8143
dd3482fe
PE
8144 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8145 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8146 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8147
393d71f3 8148 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8149 * fileio.c (Finsert_file_contents):
8150 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8151 Remove the old (too-loose) buffer overflow checks.
8152 They weren't needed, since make_gap checks for buffer overflow.
8153 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8154 The old code merely checked for Emacs fixnum overflow, and relied
8155 on undefined (wraparound) behavior. The new code avoids undefined
8156 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8157
2e6813b0 8158 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8159 Tune. Don't use wider integers than needed. Don't use alloca.
8160 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8161
599a9e4f
PE
8162 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8163
99561444
PE
8164 * insdel.c, lisp.h (buffer_overflow): New function.
8165 (insert_from_buffer_1, replace_range, replace_range_2):
8166 * insdel.c (make_gap_larger):
8167 * editfns.c (Finsert_char):
8168 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8169
28177add
PE
8170 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8171
e69dafad
PE
81722011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8173
4baa020d 8174 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8175
b1c46f02
PE
8176 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8177 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8178
e69dafad
PE
8179 * fileio.c: Don't assume EMACS_INT fits in off_t.
8180 (emacs_lseek): New static function.
8181 (Finsert_file_contents, Fwrite_region): Use it.
8182 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8183
566684ea
PE
8184 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8185
e6966cd6
PE
8186 * fns.c: Don't overflow int when computing a list length.
8187 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8188 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8189 truncation on 64-bit hosts. Check for QUIT every
8190 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8191 faster and is responsive enough.
8192 (Flength): Report an error instead of overflowing an integer.
8193 (Fsafe_length): Return a float if the value is not representable
8194 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8195 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8196 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8197
dd0b0efb
PE
8198 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8199 (header_size, word_size): New constants.
8200 (allocate_vectorlike): Don't check size overflow here.
8201 (allocate_vector): Check it here instead, since this is the only
8202 caller of allocate_vectorlike that could cause overflow.
8203 Check that the new vector's length is representable as a fixnum.
8204
86fe5cfe
PE
8205 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8206 The previous code was bogus. For example, next_almost_prime (32)
8207 returned 39, which is undesirable as it is a multiple of 3; and
8208 next_almost_prime (24) returned 25, which is a multiple of 5 so
8209 why was the code bothering to check for multiples of 7?
8210
80e88859
PE
8211 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8212
4a2f0ad6
PE
8213 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8214
f66c7cf8
PE
8215 Variadic C functions now count arguments with ptrdiff_t.
8216 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8217 Back then I didn't know that the Emacs coding style prefers signed int.
8218 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8219 were being counted with int, which may truncate counts on 64-bit
8220 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8221 * lisp.h (struct Lisp_Subr.function.aMANY)
8222 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8223 Arg counts are now ptrdiff_t, not size_t.
8224 All variadic functions and their callers changed accordingly.
8225 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8226 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8227 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8228 * callint.c (Fcall_interactively): Check arg count for overflow,
8229 to avoid potential buffer overrun. Use signed char, not 'int',
8230 for 'varies' array, so that we needn't bother to check its size
8231 calculation for overflow.
8232 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8233 * eval.c (apply_lambda):
8234 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8235 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8236 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8237
a1759b76
PE
8238 * callint.c (Fcall_interactively): Don't use index var as event count.
8239
d96be9fc
PE
8240 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8241 * mem-limits.h (SIZE): Remove; no longer used.
8242
a690a978 8243 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8244
578c21e6
PE
8245 Remove unnecessary casts.
8246 * xterm.c (x_term_init):
8247 * xfns.c (x_set_border_pixel):
8248 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8249 These aren't needed now that we assume ANSI C.
8250
96f53c6c
PE
8251 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8252 It's more likely to cause problems (due to unsigned overflow)
8253 than to cure them.
8254
83c77d31
PE
8255 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8256
ee2079f1
PE
8257 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8258
6da65536
PE
8259 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8260
7147c4a4
PE
8261 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8262
193e32d9
PE
8263 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8264
e5533da6
PE
8265 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8266
9910e595
PE
8267 GLYPH_CODE_FACE returns EMACS_INT, not int.
8268 * dispextern.h (merge_faces):
8269 * xfaces.c (merge_faces):
01103c44
PE
8270 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8271 Don't assume EMACS_INT fits in int.
9910e595 8272
2638320e
PE
8273 * character.h (CHAR_VALID_P): Remove unused parameter.
8274 * fontset.c, lisp.h, xdisp.c: All uses changed.
8275
045eb8d9
PE
8276 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8277
c1f134b5
PE
8278 * fns.c (concat): Minor tuning based on overflow analysis.
8279 This doesn't fix any bugs. Use int to hold character, instead
8280 of constantly refetching from Emacs object. Use XFASTINT, not
8281 XINT, for value known to be a character. Don't bother comparing
8282 a single byte to 0400, as it's always less.
8283
395fcb93 8284 * floatfns.c (Fexpt):
327eeec8
PE
8285 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8286
abbd3d23
PE
8287 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8288 for characters.
8289
684a03ef
PE
8290 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8291
0fed43f3
PE
8292 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8293 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8294 incorrectly succeed when S was a string, because 4294967386 was
8295 truncated before it was used.
8296
8fd02eb7
PE
8297 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8298 Otherwise, an out-of-range integer could cause undefined behavior
8299 on a 64-bit host.
8300
f8c86b69
PE
8301 * composite.c: Use int, not EMACS_INT, for characters.
8302 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8303 EMACS_INT, for values that are known to be in character range.
8304 This doesn't fix any bugs but is the usual style inside Emacs and
8305 may generate better code on 32-bit machines.
8306
34206dd2
PE
8307 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8308 This is for reasons similar to the recent CHAR_STRING fix.
8309 * charset.c (Fencode_char): Check that character arg is actually
8310 a character. Pass an int to ENCODE_CHAR.
8311 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8312 wider than 'int', as a compile-time check to prevent future regressions
8313 in this area.
8314
c5958d4c 8315 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8316
8317 Make sure a 64-bit char is never passed to CHAR_STRING.
8318 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8319 by silently ignoring the top 32 bits, allowing some values
8320 that were far too large to be valid characters.
8321 * character.h: Include <verify.h>.
8322 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8323 arguments are no wider than unsigned, as a compile-time check
8324 to prevent future regressions in this area.
8325 * data.c (Faset):
01103c44 8326 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8327 (Fsubst_char_in_region):
8328 * fns.c (concat):
8329 * xdisp.c (decode_mode_spec_coding):
8330 Adjust to CHAR_STRING's new requirement.
8331 * editfns.c (Finsert_char, Fsubst_char_in_region):
8332 * fns.c (concat): Check that character args are actually
8333 characters. Without this test, these functions did the wrong
8334 thing with wildly out-of-range values on 64-bit hosts.
8335
d37ca623
PE
8336 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8337 These casts should not be needed on 32-bit hosts, either.
8338 * keyboard.c (read_char):
8339 * lread.c (Fload): Remove casts to unsigned.
8340
ea204efb
PE
8341 * lisp.h (UNSIGNED_CMP): New macro.
8342 This fixes comparison bugs on 64-bit hosts.
8343 (ASCII_CHAR_P): Use it.
8344 * casefiddle.c (casify_object):
01103c44 8345 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8346 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8347 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8348 * dispextern.h (FACE_FROM_ID):
8349 * keyboard.c (read_char): Use UNSIGNED_CMP.
8350
41cb286c
PE
8351 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8352 not to EMACS_INT, to avoid GCC warning.
8353
4a1b9832
PE
8354 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8355
55daad71
PE
8356 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8357 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8358 isn't needed on 32-bit machines.
8f95c75c 8359
01103c44
PE
8360 * buffer.c (Fgenerate_new_buffer_name):
8361 Use EMACS_INT for count, not int.
0ceccced 8362 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8363
8364 * data.c (Qcompiled_function): Now static.
8365
c6f072e7
PE
8366 * window.c (window_body_lines): Now static.
8367
20ce5912
PE
8368 * image.c (gif_load): Rename local to avoid shadowing.
8369
9c4c5f81
PE
8370 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8371 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8372 * alloc.c (make_save_value): Integer argument is now of type
8373 ptrdiff_t, not int.
8374 (mark_object): Use ptrdiff_t, not int.
8375 * lisp.h (pD): New macro.
8376 * print.c (print_object): Use it.
8377
c0c5c8ae
PE
8378 * alloc.c: Use EMACS_INT, not int, to count objects.
8379 (total_conses, total_markers, total_symbols, total_vector_size)
8380 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8381 (total_free_floats, total_floats, total_free_intervals)
8382 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8383 Now EMACS_INT, not int. All uses changed.
8384 (Fgarbage_collect): Compute overall total using a double, so that
8385 integer overflow is less likely to be a problem. Check for overflow
8386 when converting back to an integer.
5a25e253
PE
8387 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8388 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8389 These were 'int' variables that could overflow on 64-bit hosts;
8390 they were never used, so remove them instead of repairing them.
211a0b2a 8391 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8392 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8393 Previously, this ceilinged at INT_MAX, but that doesn't work on
8394 64-bit machines.
e46bb31a 8395 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8396
c78baabf 8397 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8398 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8399 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8400 when a (possibly-narrower) signed value would do just as well.
8401 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8402
c9d624c6
PE
8403 * alloc.c: Catch some string size overflows that we were missing.
8404 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8405 for convenience in STRING_BYTES_MAX.
8406 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8407 The definition here is exact; the one in lisp.h was approximate.
8408 (allocate_string_data): Check for string overflow. This catches
8409 some instances we weren't catching before. Also, it catches
8410 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8411 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8412 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8413
c9d624c6
PE
8414 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8415 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8416 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8417
353032ce
PE
8418 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8419
2bccce07
PE
8420 * alloc.c (Fmake_string): Check for out-of-range init.
8421
0ac30604
SM
84222011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8423
8424 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8425
c195f2de
JD
84262011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8427
8428 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8429 xg_get_default_scrollbar_width.
8430
8431 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8432 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8433 (style_changed_cb): Call update_theme_scrollbar_width and call
8434 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8435 all frames (Bug#8505).
8436 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8437 Call gtk_window_set_resizable if HAVE_GTK3.
8438 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8439 and height if HAVE_GTK3 (Bug#8505).
8440 (scroll_bar_width_for_theme): New variable.
8441 (update_theme_scrollbar_width): New function.
8442 (xg_get_default_scrollbar_width): Move code to
8443 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8444 (xg_initialize): Call update_theme_scrollbar_width.
8445
8446 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8447
8448 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8449
e10ac9f1
MR
84502011-06-12 Martin Rudalics <rudalics@gmx.at>
8451
8452 * frame.c (make_frame): Call other_buffer_safely instead of
8453 other_buffer.
8454
8455 * window.c (temp_output_buffer_show): Call display_buffer with
8456 second argument Vtemp_buffer_show_specifiers and reset latter
8457 immediately after the call.
8458 (Vtemp_buffer_show_specifiers): New variable.
8459 (auto_window_vscroll_p, next_screen_context_lines)
8460 (Vscroll_preserve_screen_position): Remove leading asterisks from
8461 doc-strings.
8462
2d3c217e 84632011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8464
7b7f97e8 8465 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8466 * buffer.c (Qclone_number): Remove for now, as it's unused.
8467 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8468 (record_buffer): Remove unused local.
8469 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8470 (set_frame_buffer_list): Remove; unused.
8471 * frame.h (other_visible_frames): Remove decl.
8472 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8473 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8474 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8475 if HAVE_GPM.
8476 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8477 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8478 Define only if HAVE_GPM.
8479 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8480 (update_hints_inhibit): Remove; never set. All uses removed.
8481 * widgetprv.h (emacsFrameClassRec): Remove decl.
8482 * window.c (delete_deletable_window): Now returns void, since it
8483 wasn't returning anything.
8484 (compare_window_configurations): Remove unused locals.
8485 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8486 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8487 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8488 the same widths as pointers. This follows up on the 2011-05-06 patch.
8489 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8490 * xterm.h: Likewise.
8491 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8492
1384b89e
JB
84932011-06-12 Juanma Barranquero <lekktu@gmail.com>
8494
8495 * makefile.w32-in: Update dependencies.
8496 (LISP_H): Add lib/intprops.h.
8497
1100a63c
CY
84982011-06-11 Chong Yidong <cyd@stupidchicken.com>
8499
8500 * image.c (gif_load): Add animation frame delay to the metadata.
8501 (syms_of_image): Use DEFSYM. New symbol `delay'.
8502
6198ccd0
MR
85032011-06-11 Martin Rudalics <rudalics@gmx.at>
8504
8505 * window.c (delete_deletable_window): Re-add.
8506 (Fset_window_configuration): Rewrite to handle dead buffers and
8507 consequently deletable windows.
8508 (window_tree, Fwindow_tree): Remove. Supply functionality in
8509 window.el.
8510 (compare_window_configurations): Simplify code.
8511
b6e3633c
AS
85122011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8513
1ab0dee5
AS
8514 * image.c (imagemagick_load_image): Fix type mismatch.
8515 (Fimagemagick_types): Likewise.
8516
b6e3633c
AS
8517 * window.h (replace_buffer_in_windows): Declare.
8518
9397e56f
MR
85192011-06-11 Martin Rudalics <rudalics@gmx.at>
8520
8521 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8522 Qclone_number. Remove external declaration of Qdelete_window.
8523 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8524 code.
640c8776
SM
8525 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8526 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8527 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8528 buffer list implementation.
8529 (other_buffer_safely): New function.
8530 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8531 calls to replace_buffer_in_windows and
8532 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8533 if allowed.
8534 (record_buffer): Inhibit quitting and rewrite using quittable
8535 functions. Run Qbuffer_list_update_hook if allowed.
8536 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8537 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8538 Move switch-to-buffer to window.el.
9397e56f
MR
8539 (bury-buffer): Move to window.el.
8540 (Vbuffer_list_update_hook): New variable.
8541
8542 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8543 section.
8544
8545 * window.h (resize_frame_windows): Move up in code.
8546 (Fwindow_frame): Remove EXFUN.
8547 (replace_buffer_in_all_windows): Remove prototype.
8548 (replace_buffer_in_windows_safely): Add prototype.
8549
8550 * window.c: Declare Qdelete_window static again. Move down
8551 declaration of select_count.
8552 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8553 (Fother_window): Move to window.el.
8554 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8555 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8556 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8557 window.el.
8558 (replace_buffer_in_windows): Implement by calling
8559 Qreplace_buffer_in_windows.
8560 (replace_buffer_in_all_windows): Remove with some functionality
8561 moved into replace_buffer_in_windows_safely.
8562 (replace_buffer_in_windows_safely): New function.
8563 (select_window_norecord, select_frame_norecord): Move in front
8564 of run_window_configuration_change_hook. Remove now obsolete
8565 declarations.
640c8776
SM
8566 (Fset_window_buffer): Rewrite doc-string.
8567 Call Qrecord_window_buffer.
9397e56f
MR
8568 (keys_of_window): Move binding for other-window to window.el.
8569
b50691aa
CY
85702011-06-11 Chong Yidong <cyd@stupidchicken.com>
8571
8572 * dispextern.h (struct image): Replace data member, whose int_val
8573 and ptr_val fields were not used by anything, with a single
8574 lisp_val object.
8575
8576 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8577 (gif_clear_image, gif_load, imagemagick_load_image)
8578 (gs_clear_image, gs_load): Callers changed.
8579
3f754b86
PE
85802011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8581
cca69397
PE
8582 * buffer.h: Include <time.h>, for time_t.
8583 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8584
109e28d0
PE
8585 Fix minor problems found by static checking.
8586
60737f02
PE
8587 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8588
4b66faf3
PE
8589 Make identifiers static if they are not used in other modules.
8590 * data.c (Qcompiled_function, Qframe, Qvector):
8591 * image.c (QimageMagick, Qsvg):
8592 * minibuf.c (Qmetadata):
8593 * window.c (resize_window_check, resize_root_window): Now static.
8594 * window.h (resize_window_check, resize_root_window): Remove decls.
8595
109e28d0
PE
8596 * window.c (window_deletion_count, delete_deletable_window):
8597 Remove; unused.
46a4ce9e
PE
8598 (window_body_lines): Now static.
8599 (Fdelete_other_windows_internal): Mark vars as initialized.
8600 Make sure 'resize_failed' is initialized.
8601 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8602 (resize_window_apply): Remove unused local.
8603 * window.h (delete_deletable_window): Remove decl.
8604
109e28d0 8605 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8606 (imagemagick_load_image): Fix pointer signedness problem by changing
8607 last arg from unsigned char * to char *. All uses changed.
8608 Also, fix a local for similar reasons.
8609 Remove unused locals. Remove locals to avoid shadowing.
8610 (fn_rsvg_handle_free): Remove; unused.
8611 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8612 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8613
3f754b86
PE
8614 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8615
2547adb1
CY
86162011-06-10 Chong Yidong <cyd@stupidchicken.com>
8617
8618 * image.c (gif_load): Fix omitted cast error introduced by
8619 2011-06-06 change.
8620
2c8e37d4
MR
86212011-06-10 Martin Rudalics <rudalics@gmx.at>
8622
8623 * window.h (resize_proportionally, orig_total_lines)
8624 (orig_top_line): Remove from window structure.
8625 (set_window_height, set_window_width, change_window_heights)
8626 (Fdelete_window): Remove prototypes.
8627 (resize_frame_windows): Remove duplicate declaration.
8628
440a42e3
EZ
86292011-06-10 Eli Zaretskii <eliz@gnu.org>
8630
8631 * window.h (resize_frame_windows, resize_window_check)
8632 (delete_deletable_window, resize_root_window)
8633 (resize_frame_windows): Declare prototypes.
8634
8635 * window.c (resize_window_apply): Make definition be "static" to
8636 match the prototype.
8637
562dd5e9
MR
86382011-06-10 Martin Rudalics <rudalics@gmx.at>
8639
8640 * window.c: Remove declarations of Qwindow_size_fixed,
8641 window_min_size_1, window_min_size_2, window_min_size,
8642 size_window, window_fixed_size_p, enlarge_window, delete_window.
8643 Remove static from declaration of Qdelete_window, it's
8644 temporarily needed by Fbury_buffer.
8645 (replace_window): Don't assign orig_top_line and
8646 orig_total_lines.
8647 (Fdelete_window, delete_window): Remove. Window deletion is
8648 handled by window.el.
640c8776
SM
8649 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8650 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8651 (Fdelete_other_windows): Remove. Deleting other windows is
8652 handled by window.el.
8653 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8654 handled in window.el.
8655 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8656 Window minimum sizes are handled in window.el.
8657 (shrink_windows, size_window, set_window_height)
8658 (set_window_width, change_window_heights, window_height)
8659 (window_width, CURBEG, CURSIZE, enlarge_window)
8660 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8661 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8662 handled in window.el.
8663 (make_dummy_parent): Rename to make_parent_window and give it a
8664 second argument horflag.
8665 (make_window): Don't set resize_proportionally any more.
8666 (Fsplit_window): Remove. Windows are split in window.el.
8667 (save_restore_action, save_restore_orig_size)
8668 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8669 Resize mini windows in window.el.
8670 (grow_mini_window, shrink_mini_window): Implement by calling
8671 Qresize_root_window_vertically, resize_window_check and
8672 resize_window_apply.
640c8776
SM
8673 (saved_window, Fset_window_configuration, save_window_save):
8674 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8675 resize_proportionally.
8676 (window_min_height, window_min_width): Move to window.el.
8677 (keys_of_window): Move bindings for delete-other-windows,
8678 split-window, delete-window and enlarge-window to window.el.
8679
8680 * buffer.c: Temporarily extern Qdelete_window.
8681 (Fbury_buffer): Temporarily call Qdelete_window instead of
8682 Fdelete_window (Fbury_buffer will move to window.el soon).
8683
8684 * frame.c (set_menu_bar_lines_1): Remove code handling
8685 orig_top_line and orig_total_lines.
8686
8687 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8688 set_window_height but set heights directly.
8689 (change_frame_size_1): Use resize_frame_windows.
8690
8691 * xdisp.c (init_xdisp): Don't use set_window_height but set
8692 heights directly.
8693
640c8776
SM
8694 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8695 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8696 run_window_configuration_change_hook.
8697
8698 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8699 instead of change_window_heights and run
8700 run_window_configuration_change_hook.
8701
1a13852e
MR
87022011-06-09 Martin Rudalics <rudalics@gmx.at>
8703
8704 * window.c (replace_window): Rename second argument REPLACEMENT to
8705 NEW. New third argument SETFLAG. Rewrite.
8706 (delete_window, make_dummy_parent): Call replace_window with
8707 third argument 1.
8708 (window_list_1): Move down in code.
8709 (run_window_configuration_change_hook): Move set_buffer part
8710 before select_frame_norecord part in order to unwind correctly.
8711 Rename count1 to count.
8712 (recombine_windows, delete_deletable_window, resize_root_window)
8713 (Fdelete_other_windows_internal)
8714 (Frun_window_configuration_change_hook, make_parent_window)
8715 (resize_window_check, resize_window_apply, Fresize_window_apply)
8716 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8717 (Fdelete_window_internal, Fresize_mini_window_internal):
8718 New functions.
1a13852e
MR
8719 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8720
f3d1777e
MR
87212011-06-08 Martin Rudalics <rudalics@gmx.at>
8722
496e208e
MR
8723 * window.h (window): Add some new members to window structure -
8724 normal_lines, normal_cols, new_total, new_normal, clone_number,
8725 splits, nest, prev_buffers, next_buffers.
8726 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8727 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8728
f3d1777e
MR
8729 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8730 Remove.
496e208e
MR
8731 (make_dummy_parent): Set new members of windows structure.
8732 (make_window): Move down in code. Handle new members of window
8733 structure.
8734 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8735 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8736 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8737 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8738 (Fset_window_next_buffers, Fset_window_clone_number):
8739 New functions.
496e208e
MR
8740 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8741 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8742 Doc-string fixes.
8743 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8744 Argument WINDOW can be now internal window too.
8745 (Fwindow_use_time): Move up in code.
8746 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8747 Rewrite doc-string.
8748 (Fset_window_configuration, saved_window)
8749 (Fcurrent_window_configuration, save_window_save): Handle new
8750 members of window structure.
b9e809c2
MR
8751 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8752 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8753 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8754 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8755 Qget_mru_window, Qresize_root_window,
8756 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8757 Qauto_buffer_name; staticpro them.
f3d1777e 8758
abde8f8c
MR
87592011-06-07 Martin Rudalics <rudalics@gmx.at>
8760
8761 * window.c (Fwindow_total_size, Fwindow_left_column)
8762 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8763 (Fwindow_list_1): New functions.
8764 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8765 (Fwindow_width, Fscroll_left, Fscroll_right):
8766 Use window_body_cols instead of window_box_text_cols.
8767 (delete_window, Fset_window_configuration):
8768 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8769 (delete_all_subwindows): Take a window as argument and not a
8770 structure. Rewrite.
190b47e6
MR
8771 (window_loop): Remove handling of GET_LRU_WINDOW and
8772 GET_LARGEST_WINDOW.
8773 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8774
8775 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8776 window_box_text_cols. delete_all_subwindows now takes a
8777 Lisp_Object as argument.
abde8f8c 8778
640c8776
SM
8779 * indent.c (compute_motion, Fcompute_motion):
8780 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8781
fa8a67e6
MR
8782 * frame.c (delete_frame): Call delete_all_subwindows with root
8783 window as argument.
8784
a54e3482
DC
87852011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8786
8787 * fns.c (Fputhash): Document return value.
8788
60002bf5
CY
87892011-06-06 Chong Yidong <cyd@stupidchicken.com>
8790
8791 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8792
0c671da6 87932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8794
b862a52a 8795 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8796
be44ca6c
PE
8797 Check for overflow when converting integer to cons and back.
8798 * charset.c (Fdefine_charset_internal, Fdecode_char):
8799 Use cons_to_unsigned to catch overflow.
8800 (Fencode_char): Use INTEGER_TO_CONS.
8801 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8802 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8803 * data.c (long_to_cons, cons_to_long): Remove.
8804 (cons_to_unsigned, cons_to_signed): New functions.
8805 These signal an error for invalid or out-of-range values.
8806 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8807 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8808 * font.c (Ffont_variation_glyphs):
8809 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8810 * lisp.h: Include <intprops.h>.
8811 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8812 (cons_to_signed, cons_to_unsigned): New decls.
8813 (long_to_cons, cons_to_long): Remove decls.
8814 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8815 (Fprimitive_undo): Use CONS_TO_INTEGER.
8816 * xfns.c (Fx_window_property): Likewise.
8817 * xselect.c: Include <limits.h>.
8818 (x_own_selection, selection_data_to_lisp_data):
8819 Use INTEGER_TO_CONS.
8820 (x_handle_selection_request, x_handle_selection_clear)
8821 (x_get_foreign_selection, Fx_disown_selection_internal)
8822 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8823 (lisp_data_to_selection_data): Use cons_to_unsigned.
8824 (x_fill_property_data): Use cons_to_signed.
8825 Report values out of range.
8826
d1f3d2af
PE
8827 Check for buffer and string overflow more precisely.
8828 * buffer.h (BUF_BYTES_MAX): New macro.
8829 * lisp.h (STRING_BYTES_MAX): New macro.
8830 * alloc.c (Fmake_string):
8831 * character.c (string_escape_byte8):
8832 * coding.c (coding_alloc_by_realloc):
8833 * doprnt.c (doprnt):
8834 * editfns.c (Fformat):
8835 * eval.c (verror):
8836 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8837 since they may not be the same number.
8838 * editfns.c (Finsert_char):
8839 * fileio.c (Finsert_file_contents):
8840 Likewise for BUF_BYTES_MAX.
8841
dd52fcea
PE
8842 * image.c: Use ptrdiff_t, not int, for sizes.
8843 (slurp_file): Switch from int to ptrdiff_t.
8844 All uses changed.
8845 (slurp_file): Check that file size fits in both size_t (for
8846 malloc) and ptrdiff_t (for sanity and safety).
8847
7f9bbdbb
PE
8848 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8849 if b->modtime has its maximal value.
8850
dfe18f82
PE
8851 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8852
84acfcf0
PE
8853 Don't assume time_t can fit into int.
8854 * buffer.h (struct buffer.modtime): Now time_t, not int.
8855 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8856 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8857
ccd9a01a
PE
8858 Minor fixes for signed vs unsigned integers.
8859 * character.h (MAYBE_UNIFY_CHAR):
8860 * charset.c (maybe_unify_char):
8861 * keyboard.c (read_char, reorder_modifiers):
8862 XINT -> XFASTINT, since the integer must be nonnegative.
8863 * ftfont.c (ftfont_spec_pattern):
8864 * keymap.c (access_keymap, silly_event_symbol_error):
8865 XUINT -> XFASTINT, since the integer must be nonnegative.
8866 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8867 since it makes no difference and we prefer signed.
8868 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8869 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8870 nonnegative.
8871
d6d100dd
SM
88722011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8873
8874 * window.h (Fwindow_frame): Declare.
8875
2b6148e4
PE
88762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8877
8878 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8879 (SPARE_MEMORY): Always define.
8880 (LARGE_REQUEST): Remove.
8881 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8882
f230ecc9
MR
88832011-06-06 Martin Rudalics <rudalics@gmx.at>
8884
727e958e
MR
8885 * lisp.h: Move EXFUNS for Fframe_root_window,
8886 Fframe_first_window and Fset_frame_selected_window to window.h.
8887
8888 * window.h: Move EXFUNS for Fframe_root_window,
8889 Fframe_first_window and Fset_frame_selected_window here from
8890 lisp.h.
8891
8892 * frame.c (Fwindow_frame, Fframe_first_window)
8893 (Fframe_root_window, Fframe_selected_window)
8894 (Fset_frame_selected_window): Move to window.c.
8895 (Factive_minibuffer_window): Move to minibuf.c.
8896 (Fother_visible_frames_p): New function.
8897
8898 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8899
f230ecc9
MR
8900 * window.c (decode_window, decode_any_window): Move up in code.
8901 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8902 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8903 (Fwindow_buffer): Move up and rewrite doc-string.
8904 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8905 (Fwindow_prev): New functions.
727e958e
MR
8906 (Fwindow_frame): Move here from frame.c. Accept any window as
8907 argument.
8908 (Fframe_root_window, Fframe_first_window)
8909 (Fframe_selected_window): Move here from frame.c. Accept frame
8910 or arbitrary window as argument. Update doc-strings.
8911 (Fminibuffer_window): Move up in code.
8912 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8913 (Fset_frame_selected_window): Move here from frame.c.
8914 Marginal rewrite.
727e958e
MR
8915 (Fselected_window, select_window, Fselect_window): Move up in
8916 code. Minor doc-string fixes.
f230ecc9 8917
4d09bcf6
PE
89182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8919
8920 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8921 Do not assume that spare memory exists; that assumption is valid
8922 only if SYSTEM_MALLOC.
8923 (LARGE_REQUEST): New macro, so that the issue of large requests
8924 is separated from the issue of spare memory.
8925
810928a2
AS
89262011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8927
172418ad
AS
8928 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8929 format. (Bug#8806)
8930
43f862f7
AS
8931 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8932
810928a2
AS
8933 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8934 before statements.
8935
a059fe24
JD
89362011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8937
8938 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8939
8940 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8941
8942 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8943 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8944
989bf368
JB
89452011-06-05 Juanma Barranquero <lekktu@gmail.com>
8946
8947 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8948
4b80f674
CY
89492011-06-04 Chong Yidong <cyd@stupidchicken.com>
8950
8951 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8952 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8953 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8954 New error handlers.
4b80f674
CY
8955 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8956 Obey Vx_select_enable_clipboard_manager. Catch errors in
8957 x_clipboard_manager_save (Bug#8779).
8958 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8959 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8960
99a33b77 89612011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8962
8963 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8964
99a33b77 89652011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8966
8967 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8968 in the current matrix if keep_current_p is non-zero.
8969
8264569d
EZ
89702011-06-04 Eli Zaretskii <eliz@gnu.org>
8971
8972 * bidi.c (bidi_level_of_next_char): Fix last change.
8973
57f97249
EZ
89742011-06-03 Eli Zaretskii <eliz@gnu.org>
8975
fec2107c 8976 Support bidi reordering of text covered by display properties.
57f97249 8977
fec2107c
EZ
8978 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8979 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8980 (bidi_cache_search, bidi_cache_iterator_state)
8981 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8982 (bidi_level_of_next_char, bidi_move_to_visually_next):
8983 Support character positions inside a run of characters covered by a
fec2107c
EZ
8984 display string.
8985 (bidi_paragraph_init, bidi_resolve_explicit_1)
8986 (bidi_level_of_next_char): Call bidi_fetch_char and
8987 bidi_fetch_char_advance instead of FETCH_CHAR and
8988 FETCH_CHAR_ADVANCE.
8989 (bidi_init_it): Initialize new members.
8990 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8991 definitions.
8992 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8993 instead of using explicit *_CHAR codes.
d6d100dd
SM
8994 (bidi_resolve_explicit, bidi_resolve_weak):
8995 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8996 bidirectional text is supported only in multibyte buffers.
8997 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8998 it to initialize the frame_window_p member of struct bidi_it.
8999 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9000 (bidi_resolve_explicit, bidi_resolve_weak)
9001 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9002 bidi_it->nchars is non-positive.
9003 (bidi_level_of_next_char): Don't try to lookup the cache for the
9004 next/previous character if nothing is cached there yet, or if we
9005 were just reseat()'ed to a new position.
c40e2fb2 9006
0e14fe90
EZ
9007 * xdisp.c (set_cursor_from_row): Set start and stop points
9008 according to the row's direction when priming the loop that looks
9009 for the glyph on which to display cursor.
9010 (single_display_spec_intangible_p): Function deleted.
9011 (display_prop_intangible_p): Reimplement to call
9012 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9013 Accept 3 additional arguments needed by handle_display_spec.
9014 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9015 values: lists, `(when COND...)' forms, etc.
9016 (single_display_spec_string_p): Support property values that are
9017 lists with the argument STRING its top-level element.
9018 (display_prop_string_p): Fix the condition for processing a
9019 property that is a list to be consistent with handle_display_spec.
fec2107c 9020 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9021 last portion of handle_display_prop.
9022 (compute_display_string_pos): Accept additional argument
9023 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9024 value of a `display' property is a "replacing spec".
9025 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9026 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9027 the display property, but just return a value indicating whether
9028 the display property will replace the characters it covers.
9029 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9030 frame_window_p members of struct bidi_it.
d6d100dd
SM
9031 (compute_display_string_pos, compute_display_string_end):
9032 New functions.
fec2107c
EZ
9033 (push_it): Accept second argument POSITION, where pop_it should
9034 jump to continue iteration.
9035 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9036
fec2107c
EZ
9037 * keyboard.c (adjust_point_for_property): Adjust the call to
9038 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9039
9040 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9041 (bidi_init_it): Update prototypes.
9042 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9043 (compute_display_string_pos, compute_display_string_end):
9044 Declare prototypes.
fec2107c
EZ
9045 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9046 EMACS_INT.
fc6f18ce 9047
40087514 90482011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9049
57f53182
PE
9050 Malloc failure behavior now depends on size of allocation.
9051 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9052 * lisp.h: Change signatures accordingly.
9053 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9054 All callers changed. (Bug#8762)
9055
9056 * gnutls.c: Use Emacs's memory allocators.
9057 Without this change, the gnutls library would invoke malloc etc.
9058 directly, which causes problems on non-SYNC_INPUT hosts, and which
9059 runs afoul of improving memory_full behavior. (Bug#8761)
9060 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9061 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9062 xfree instead of the default malloc, realloc, free.
9063 (Fgnutls_boot): No need to check for memory allocation failure,
9064 since xmalloc does that for us.
9065
ac32cd99 9066 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9067 * category.c (hash_get_category_set):
9068 * ccl.c (ccl_driver):
9069 * charset.c (Fdefine_charset_internal):
9070 * charset.h (struct charset.hash_index):
9071 * composite.c (get_composition_id, gstring_lookup_cache)
9072 (composition_gstring_put_cache):
9073 * composite.h (struct composition.hash_index):
9074 * dispextern.h (struct image.hash):
9075 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9076 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9077 (hashfn_equal, hashfn_user_defined, make_hash_table)
9078 (maybe_resize_hash_table, hash_lookup, hash_put)
9079 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9080 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9081 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9082 * image.c (make_image, search_image_cache, lookup_image)
9083 (xpm_put_color_table_h):
9084 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9085 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9086 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9087 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9088 * alloc.c (allocate_vectorlike):
9089 Check for overflow in vector size calculations.
9090 * ccl.c (ccl_driver):
9091 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9092 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9093 need to be updated by these changes.
40087514
PE
9094 * fns.c (make_hash_table, maybe_resize_hash_table):
9095 Check for integer overflow with large hash tables.
0de4bb68
PE
9096 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9097 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9098 (SXHASH_REDUCE): New macro.
9099 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9100 Use it instead of discarding useful hash info with large hash values.
9101 (sxhash_float): New function.
9102 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9103 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9104 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9105 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9106 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9107 Adjust signatures to match updated version of code.
9108 (consing_since_gc): Now EMACS_INT, since a single hash table can
9109 use more than INT_MAX bytes.
9110
698d32e2
DN
91112011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9112
9113 Make it possible to build with GCC-4.6+ -O2 -flto.
9114
9115 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9116
fd6fa53f
SM
91172011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9118
9119 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9120 Call minibuffer-inactive-mode.
9121
864db017
JB
91222011-05-31 Juanma Barranquero <lekktu@gmail.com>
9123
9124 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9125 Update dependencies.
9126
2ad0baf4
DN
91272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9128
9129 * data.c (init_data): Remove code for UTS, this system is not
9130 supported anymore.
9131
4fcc2638
DN
91322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9133
9134 Don't force ./temacs to start in terminal mode.
9135
9136 * frame.c (make_initial_frame): Initialize faces in all cases, not
9137 only when CANNOT_DUMP is defined.
9138 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9139
c56e0fd5
DN
91402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9141
9142 * dispnew.c (add_window_display_history): Use const for the string
9143 pointer. Remove declaration, not needed.
9144
333d54da 91452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9146
55d4c1b2 9147 Use 'inline', not 'INLINE'.
333d54da 9148 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9149 * alloc.c, fontset.c (INLINE): Remove.
9150 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9151 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9152 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9153 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9154 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9155
738db178
DN
91562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9157
9158 Make it possible to run ./temacs.
9159
9160 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9161 syms_of_callproc does the same thing. Remove test for
9162 "initialized", do it in the caller.
9163 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9164
620c53a6
SM
91652011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9166
9167 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9168 (read_minibuf): Use get_minibuffer.
9169 (syms_of_minibuf): Use DEFSYM.
9170 (Qmetadata): New var.
9171 * data.c (Qbuffer): Don't make it static.
9172 (syms_of_data): Use DEFSYM.
9173
e003a292
PE
91742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9175
9176 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9177 (CCL_CODE_MIN): New macro.
9178
ed008a6d
PE
91792011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9180
3687c2ef
PE
9181 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9182
ed008a6d
PE
9183 * eval.c (Qdebug): Now static.
9184 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9185 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9186 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9187
d66c4c7c
CY
91882011-05-29 Chong Yidong <cyd@stupidchicken.com>
9189
9190 * image.c: Various fixes to ImageMagick code comments.
9191 (Fimagemagick_types): Doc fix.
9192
5fbc2025
PE
91932011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9194
0196f88a
PE
9195 Minor fixes prompted by GCC 4.6.0 warnings.
9196
9197 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9198
5fbc2025
PE
9199 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9200 (x_clipboard_manager_save_all): Move extern decl to ...
9201 * xterm.h: ... here, so that it can be checked for consistency.
9202
1dd3c2d9
CY
92032011-05-29 Chong Yidong <cyd@stupidchicken.com>
9204
9205 * xselect.c (x_clipboard_manager_save_frame)
9206 (x_clipboard_manager_save_all): New functions.
9207 (Fx_clipboard_manager_save): Lisp function deleted.
9208
9209 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9210 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9211
9212 * xterm.h: Update prototype.
9213
5ba6571d
WX
92142011-05-28 William Xu <william.xwl@gmail.com>
9215
9216 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9217 exiting (Bug#8239).
9218
3eaff834
JM
92192011-05-28 Jim Meyering <meyering@redhat.com>
9220
e1900994 9221 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9222 * fns.c (to_uchar): Define.
9223 (crypto_hash_function): Use it to convert some newly-signed
9224 variables to unsigned, to avoid sign-extension bugs. For example,
9225 without this change, (md5 "truc") would evaluate to
9226 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9227 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9228 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9229
0f6990a7
PE
92302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9231
9232 Integer overflow fixes.
c8a9ca5a 9233
08686060
PE
9234 * dbusbind.c: Serial number integer overflow fixes.
9235 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9236 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9237 to hold a serial number that is too large for a fixnum.
9238 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9239 Check for serial numbers out of range. Decode any serial number
59568bf0 9240 that was so large that it became a float. (Bug#8722)
08686060 9241
2d1fc3c7
PE
9242 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9243 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9244 Use XFASTINT rather than XUINT when numbers are nonnegative.
9245 (xd_append_arg, Fdbus_method_return_internal):
9246 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9247 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9248 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9249 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9250 (Bug#8722)
2d1fc3c7 9251
c8a9ca5a
PE
9252 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9253
519e1d69
PE
9254 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9255
6df6ae42 9256 ccl: Add integer overflow checks.
30569699
PE
9257 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9258 (IN_INT_RANGE): New macros.
9259 (ccl_driver): Use them to check for integer overflow when
9260 decoding a CCL program. Many of the new checks are whether XINT (x)
9261 fits in int; it doesn't always, on 64-bit hosts. The new version
9262 doesn't catch all possible integer overflows, but it's an
847044ea 9263 improvement. (Bug#8719)
30569699 9264
c11285dc
PE
9265 * alloc.c (make_event_array): Use XINT, not XUINT.
9266 There's no need for unsigned here.
9267
fdccd48e
PE
9268 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9269 This follows up to the 2011-05-06 change that substituted uintptr_t
9270 for EMACS_INT. This case wasn't caught back then.
9271
37910ab2
PE
9272 Rework Fformat to avoid integer overflow issues.
9273 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9274 now (part of C89). Include <verify.h>.
9275 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9276 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9277 (Fformat): Avoid the prepass trying to compute sizes; it was only
9278 approximate and thus did not catch overflow reliably. Instead, walk
9279 through the format just once, formatting and computing sizes as we go,
9280 checking for integer overflow at every step, and allocating a larger
9281 buffer as needed. Keep track separately whether the format is
9282 multibyte. Keep only the most-recently calculated precision, rather
9283 than them all. Record whether each argument has been converted to
9284 string. Use EMACS_INT, not int, for byte and char and arg counts.
9285 Support field widths and precisions larger than INT_MAX. Avoid
9286 sprintf's undefined behavior with conversion specifications such as %#d
9287 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9288 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9289 formatting out-of-range floating point numbers with int
9173deec 9290 formats. (Bug#8668)
37910ab2 9291
2e6578fb
PE
9292 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9293
0ae6bdee
PE
9294 * data.c: Avoid integer truncation in expressions involving floats.
9295 * data.c: Include <intprops.h>.
9296 (arith_driver): When there's an integer overflow in an expression
9297 involving floating point, convert the integers to floating point
9298 so that the resulting value does not suffer from catastrophic
9299 integer truncation. For example, on a 64-bit host (* 4
9300 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9301 Do not rely on undefined behavior after integer overflow.
9302
de883a70
PE
9303 merge count_size_as_multibyte, parse_str_to_multibyte
9304 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9305 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9306 Check for integer overflow.
9307 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9308 since it's now a duplicate of the other. This is more of
9309 a character than a buffer op, so better that it's in character.c.
9310 * fns.c, print.c: Adjust to above changes.
9311
2ff916cb
PE
93122011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9313
9314 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9315
f1b54466
PE
93162011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9317
fb1ac845
PE
9318 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9319 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9320 (x_clipboard_manager_save): Now static.
9321 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9322
f1b54466
PE
9323 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9324 (crypto_hash_function): Now static.
9325 Fix pointer signedness problems. Avoid unnecessary initializations.
9326
a9f737ee
CY
93272011-05-27 Chong Yidong <cyd@stupidchicken.com>
9328
9329 * termhooks.h (Vselection_alist): Make it terminal-local.
9330
9331 * terminal.c (create_terminal): Initialize it.
9332
9333 * xselect.c: Support for clipboard managers.
9334 (Vselection_alist): Move to termhooks.h as terminal-local var.
9335 (LOCAL_SELECTION): New macro.
9336 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9337 (symbol_to_x_atom): Remove gratuitous arg.
9338 (x_handle_selection_request, lisp_data_to_selection_data)
9339 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9340 (x_own_selection, x_get_local_selection, x_convert_selection):
9341 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9342 (some_frame_on_display): Delete unused function.
9343 (Fx_own_selection_internal, Fx_get_selection_internal)
9344 (Fx_disown_selection_internal, Fx_selection_owner_p)
9345 (Fx_selection_exists_p): New optional frame arg.
9346 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9347 (x_handle_selection_clear): Don't treat other terminals with the
9348 same keyboard specially. Use the terminal-local Vselection_alist.
9349 (x_clear_frame_selections): Use Frun_hook_with_args.
9350
9351 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9352
9353 * xterm.h: Add support for those atoms.
9354
e067f0c1
CY
93552011-05-26 Chong Yidong <cyd@stupidchicken.com>
9356
9357 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9358 (converted_selections, conversion_fail_tag): New global variables.
9359 (x_selection_request_lisp_error): Free the above.
9360 (x_get_local_selection): Remove unnecessary code.
9361 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9362 of converted selections stored in converted_selections.
9363 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9364 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9365 (x_convert_selection): New function.
9366 (x_handle_selection_event): Simplify.
9367 (x_get_foreign_selection): Don't ignore incoming requests while
9368 waiting for an answer; this will fail when we implement
9369 SAVE_TARGETS, and seems unnecessary anyway.
9370 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9371 (Vx_sent_selection_functions): Doc fix.
9372
0f4aebc0
LL
93732011-05-26 Leo Liu <sdl.web@gmail.com>
9374
9375 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9376
e61124cd
YM
93772011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9378
9379 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9380
9381 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9382 for fringe update if it has periodic bitmap.
ac389d0c 9383 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9384 and fringe_bitmap_periodic_p.
9385
9386 * fringe.c (get_fringe_bitmap_data): New function.
9387 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9388 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9389 row. Mark glyph row for fringe update if periodicity changed.
9390
9391 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9392 for fringe update unless it has periodic bitmap.
9393
f16d9837
KH
93942011-05-25 Kenichi Handa <handa@m17n.org>
9395
9396 * xdisp.c (get_next_display_element): Set correct it->face_id for
9397 a static composition.
9398
e1b90ef6
LL
93992011-05-24 Leo Liu <sdl.web@gmail.com>
9400
9401 * deps.mk (fns.o):
9402 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9403
9404 * fns.c (crypto_hash_function, Fsha1): New function.
9405 (Fmd5): Use crypto_hash_function.
9406 (syms_of_fns): Add Ssha1.
9407
7400048f
PE
94082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9409
9410 * gnutls.c: Remove unused macros.
9411 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9412 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9413 Remove macros that are defined and never used.
9414 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9415
abb71cf4
CY
94162011-05-22 Chong Yidong <cyd@stupidchicken.com>
9417
9418 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9419 (Fx_get_selection_internal): Minor cleanup.
9420 (Fx_own_selection_internal): Rename arguments for consistency with
9421 select.el.
9422
6307db39
PE
94232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9424
9425 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9426
f3d4e0a4
CY
94272011-05-22 Chong Yidong <cyd@stupidchicken.com>
9428
9429 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9430
4d8ade89
YM
94312011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9432
9433 * dispnew.c (scrolling_window): Don't exclude the case that the
9434 last enabled row in the desired matrix touches the bottom boundary.
9435
32078c8d
GM
94362011-05-21 Glenn Morris <rgm@gnu.org>
9437
9438 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9439 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9440 and add some more files.
32078c8d 9441
7285dc67
EZ
94422011-05-20 Eli Zaretskii <eliz@gnu.org>
9443
9444 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9445 report_file_error introduced by the change from 2011-05-07.
9446
89d1bd22
PE
94472011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9448
9449 * systime.h (Time): Define only if emacs is defined.
9450 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9451 where the include path doesn't have X11/X.h by default. See
9452 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9453
cd394be1 94542011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9455
9456 * composite.c (find_automatic_composition): Fix previous change.
9457
b9704ad9
GM
94582011-05-20 Glenn Morris <rgm@gnu.org>
9459
9460 * lisp.mk: New file, split from Makefile.in.
9461 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9462 (shortlisp): Remove.
9463 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9464
4a720484
GM
94652011-05-19 Glenn Morris <rgm@gnu.org>
9466
9467 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9468 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9469 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9470 (lisp): Set the order to that of loadup.el.
9471 (shortlisp): Make it a copy of $lisp.
9472 (SOME_MACHINE_LISP): Remove.
9473 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9474 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9475
a28d4396
KH
94762011-05-18 Kenichi Handa <handa@m17n.org>
9477
9478 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9479 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9480 (find_automatic_composition): Mostly rewrite for efficiency.
9481
a2b1fa8e
JB
94822011-05-18 Juanma Barranquero <lekktu@gmail.com>
9483
9484 * makefile.w32-in: Update dependencies.
9485
8e1f5610
CS
94862011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9487
9488 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9489 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9490
7025ee00 94912011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9492
cdfa6eab
PE
9493 Fix some integer overflow issues, such as string length overflow.
9494
06d6db33
PE
9495 * insdel.c (count_size_as_multibyte): Check for string overflow.
9496
2b4560a8
PE
9497 * character.c (lisp_string_width): Check for string overflow.
9498 Use EMACS_INT, not int, for string indexes and lengths; in
9499 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9500 the resulting string length overflows an EMACS_INT; instead,
9501 report a string overflow if no precision given. When checking for
9502 precision exhaustion, use a check that cannot possibly have
9503 integer overflow. (Bug#8675)
9504 * character.h (lisp_string_width): Adjust to new signature.
9505
cb93f9be
PE
9506 * alloc.c (string_overflow): New function.
9507 (Fmake_string): Use it. This doesn't change behavior, but saves
9508 a few bytes and will simplify future changes.
9509 * character.c (string_escape_byte8): Likewise.
9510 * lisp.h (string_overflow): New decl.
9511
1a1f3366
PE
9512 Fixups, following up to the user-interface timestamp change.
9513 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9514 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9515 * msdos.c (mouse_get_pos): Likewise.
9516 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9517 * w32gui.h (Time): Define by including "systime.h" rather than by
9518 declaring it ourselves. (Bug#8664)
9519
d4e3e4d3
PE
9520 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9521 * image.c (clear_image_cache): Likewise.
9522
f6a24d19
PE
9523 * term.c (term_mouse_position): Don't assume time_t wraparound.
9524
08dc5ae6
PE
9525 Be more systematic about user-interface timestamps.
9526 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9527 and sometimes 'EMACS_UINT', to represent these timestamps.
9528 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9529 This makes the code easier to follow, and makes it easier to catch
9530 integer overflow bugs such as Bug#8664.
9531 * frame.c (Fmouse_position, Fmouse_pixel_position):
9532 Use Time, not unsigned long, for user-interface timestamps.
9533 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9534 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9535 * keyboard.h (last_event_timestamp): Likewise.
9536 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9537 * menu.h (xmenu_show): Likewise.
9538 * term.c (term_mouse_position): Likewise.
9539 * termhooks.h (struct input_event.timestamp): Likewise.
9540 (struct terminal.mouse_position_hook): Likewise.
9541 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9542 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9543 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9544 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9545 what it was before.
9546 * menu.h, termhooks.h: Include "systime.h", for Time.
9547
8e55734a
PE
9548 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9549 Don't assume that the difference between two unsigned long values
9550 can fit into an integer. At this point, we know button_down_time
9551 <= event->timestamp, so the difference must be nonnegative, so
9552 there's no need to cast the result if double-click-time is
9553 nonnegative, as it should be; check that it's nonnegative, just in
9554 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9555 apart (about 25 days). (Bug#8664)
8e55734a 9556
841f1b75 9557 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9558 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9559
3e26f69c
PE
9560 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9561 that always fit in int. Use a sentinel instead of a counter, to
9562 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9563 * frame.h (struct frame): Use int for menu_bar_items_used
9564 instead of EMACS_INT, since it always fits in int.
3e26f69c 9565
5cc152c0
PE
9566 * menu.c (grow_menu_items): Check for int overflow.
9567
d89eb65e
PE
9568 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9569
5235bd3e
PE
9570 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9571 Before, the code was not consistent. These values cannot exceed
9572 2**31 - 1 so there's no need to make them unsigned.
9573 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9574 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9575 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9576 as modifiers.
9577 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9578
bc827e23
PE
9579 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9580 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9581 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9582 presumably because the widths might not match.
9583
78eb494e
PE
9584 * window.c (size_window): Avoid needless test at loop start.
9585
04f2d78b
CB
95862011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9587
9588 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9589
d2fc7e3d 95902011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9591
9592 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9593
d2fc7e3d 95942011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9595
9596 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9597 `width' to `bar_area_x' and `bar_area_width', respectively.
9598 (x_scroll_run): Take account of fringe background extension.
9599
04f2d78b
CB
9600 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9601 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9602 `bar_area_width', respectively.
9603 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9604 background extension.
9605
79b70037
GM
96062011-05-10 Jim Meyering <meyering@redhat.com>
9607
9608 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9609
2f142cc5
JB
96102011-05-10 Juanma Barranquero <lekktu@gmail.com>
9611
9612 * image.c (Finit_image_library): Return t for built-in image types,
9613 like pbm and xbm. (Bug#8640)
9614
57679c86
AS
96152011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9616
9617 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9618
888c9e86
EZ
96192011-05-07 Eli Zaretskii <eliz@gnu.org>
9620
b0512a1d
EZ
9621 * w32console.c (Fset_screen_color): Doc fix.
9622 (Fget_screen_color): New function.
9623 (syms_of_ntterm): Defsubr it.
9624
7285dc67
EZ
9625 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9626 unlink the temporary file if Fcall_process didn't create it in the
9627 first place.
9628 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9629 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9630 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9631 cue to call_process_cleanup not to close that handle.
9632
4d3fcc8e
BK
96332011-05-07 Ben Key <bkey76@gmail.com>
9634
9635 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9636 one of two shell specific rules, either bootstrap-temacs-CMD or
9637 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9638 to the previous implementation of the bootstrap-temacs rule.
9639 The bootstrap-temacs-CMD rule is similar to the previous
9640 implementation of the bootstrap-temacs rule except that it
9641 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9642 variable.
9643
9644 These changes, along with some changes to nt/configure.bat,
9645 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9646 earlier fix to add support for --cflags and --ldflags options
9647 that include quotes so that it works whether make uses cmd or
9648 sh as the shell.
9649
b4289b64
MA
96502011-05-06 Michael Albinus <michael.albinus@gmx.de>
9651
9652 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9653 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9654 is a constant.
9655 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9656 a string. Handle both cases.
9657 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9658 (Fdbus_register_method): Use Qinvalid_function.
9659
af4c0e28
JB
96602011-05-06 Juanma Barranquero <lekktu@gmail.com>
9661
9662 * makefile.w32-in: Update dependencies.
9663 (LISP_H): Add inttypes.h and stdin.h.
9664 (PROCESS_H): Add unistd.h.
9665
c51453d9
EZ
96662011-05-06 Eli Zaretskii <eliz@gnu.org>
9667
9668 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9669 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9670
8ff0ac3c 96712011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9672
4c4b566b
PE
9673 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9674
aab2b9b5
PE
9675 * term.c (vfatal): Remove stray call to va_end.
9676 It's not needed and the C Standard doesn't allow it here anyway.
9677
c378da0b
PE
9678 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9679 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9680
288b08c7
PE
9681 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9682 bytes.
9683
e3601888
PE
9684 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9685
db6c0e74
PE
9686 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9687
dd5963ea
PE
9688 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9689
88c9450f
PE
9690 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9691
2f9442b8
PE
9692 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9693
c032b5f8
PE
9694 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9695 * charset.c (Fdefine_charset_internal): Don't initialize
9696 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9697 32-bit int (Bug#8600).
a108c10b
PE
9698
9699 * lread.c (read_integer): Be more consistent with string-to-number.
9700 Use string_to_number to do the actual conversion; this avoids
9701 rounding errors and fixes some other screwups. Without this fix,
9702 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9703 (digit_to_number): Move earlier, for benefit of read_integer.
9704 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9705 not a digit in any supported base. (Bug#8602)
a108c10b 9706
ad5f9eea
PE
9707 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9708
aec1708a
PE
9709 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9710 to match comment at start of function. This also removes a
9711 GCC warning about overflow in a 32+64-bit port.
9712
47be4ab5
PE
9713 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9714
371cac43
PE
9715 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9716 Reported by Stefan Monnier in
9717 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9718 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9719 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9720
d01a7826
PE
9721 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9722 (EMACS_UINTPTR): Likewise, with uintptr_t.
9723
7fd47d5c
PE
9724 * lisp.h: Prefer 64-bit EMACS_INT if available.
9725 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9726 on 32-bit hosts that have 64-bit int, so that they can access
9727 large files.
122b0c86
PE
9728 However, temporarily disable this change unless the temporary
9729 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9730
8727937b
PE
9731 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9732
8ac068ac
PE
9733 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9734 This removes an assumption that EMACS_INT and long are the same
9735 width as pointers. The assumption is true for Emacs porting targets
9736 now, but we want to make other targets possible.
9737 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9738 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9739 In the rest of the code, change types of integers that hold casted
9740 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9741 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9742 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9743 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9744 No need to cast type when ORing.
9745 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9746 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9747 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9748 assume EMACS_INT is the same width as char *.
9749 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9750 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9751 Remove no-longer-needed casts.
9752 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9753 (xg_tool_bar_help_callback, xg_make_tool_item):
9754 Use EMACS_INTPTR to hold an integer
9755 that will be cast to void *; this can avoid a GCC warning
9756 if EMACS_INT is not the same width as void *.
9757 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9758 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9759 (current_message_1, set_message_1):
9760 Use a local to convert to proper width without a cast.
9761 * xmenu.c (dialog_selection_callback): Likewise.
9762
ede49d71
PE
9763 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9764 Also, don't assume VALBITS / RAND_BITS is less than 5,
9765 and don't rely on undefined behavior when shifting a 1 left into
9766 the sign bit.
9767 * lisp.h (get_random): Change signature to match.
9768
2f30ecd0
PE
9769 * lread.c (hash_string): Use size_t, not int, for hash computation.
9770 Normally we prefer signed values; but hashing is special, because
9771 it's better to use unsigned division on hash table sizes so that
9772 the remainder is nonnegative. Also, size_t is the natural width
9773 for hashing into memory. The previous code used 'int', which doesn't
9774 retain enough info to hash well into very large tables.
9775 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9776
2a866e7b
PE
9777 * dbusbind.c: Don't possibly lose pointer info when converting.
9778 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9779 Use XPNTR rather than XHASH, so that the high-order bits of
9780 the pointer aren't lost when converting through void *.
9781
51639eac
PE
9782 * eval.c (Fautoload): Don't double-shift a pointer.
9783
92394119
PE
9784 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9785
dbdb9a7c
JB
97862011-05-06 Juanma Barranquero <lekktu@gmail.com>
9787
9788 * gnutls.c (DEF_GNUTLS_FN):
9789 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9790
db7a0b4f
AS
97912011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9792
9793 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9794 marker. (Bug#8610)
9795
cd394be1 97962011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9797
9798 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9799 New version that can reserve upto 2GB of heap space.
9800
f7ff1b0f 98012011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9802
9803 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9804
639c109b
TZ
98052011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9806
9807 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9808 `gnutls_certificate_set_x509_key_file'.
9809
d2127135
JB
98102011-05-05 Juanma Barranquero <lekktu@gmail.com>
9811
9812 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9813 Update dependencies.
9814
e968f4f3
JB
98152011-05-04 Juanma Barranquero <lekktu@gmail.com>
9816
9817 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9818 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9819 Remove unused parameter `fildes'.
9820 * process.c (read_process_output, send_process): Don't pass it.
9821
84d358f0
JB
98222011-05-04 Juanma Barranquero <lekktu@gmail.com>
9823
9824 Fix previous change: the library cache is defined in w32.c.
9825 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9826 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9827
0898ca10
JB
98282011-05-04 Juanma Barranquero <lekktu@gmail.com>
9829
9830 Implement dynamic loading of GnuTLS on Windows.
9831
9832 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9833 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9834 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9835 Declare.
9836
9837 * gnutls.c (Qgnutls_dll): Define.
9838 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9839 (gnutls_*): Declare function pointers.
9840 (init_gnutls_functions): New function to initialize function pointers.
9841 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9842 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9843 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9844 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9845 (emacs_gnutls_write, emacs_gnutls_read)
9846 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9847 (Fgnutls_available_p): New function.
9848 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9849 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9850 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9851
9852 * image.c: Include w32.h.
9853 (Vimage_type_cache): Delete.
9854 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9855 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9856 (w32_delayed_load): Move to w32.c.
9857
9858 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9859
9860 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9861 (w32_delayed_load): Move from image.c. When loading a library, record
9862 its filename in the :loaded-from property of the library id.
9863 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9864 Initialize and staticpro them.
9865 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9866
9867 * process.c: Include lisp.h before w32.h, not after.
9868 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9869 instead of gnutls_record_check_pending.
9870
9871 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9872
ff4de4aa
TZ
98732011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9874
9875 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9876 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9877 as passed in.
9878
abe95abb
JD
98792011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9880
9881 * xterm.c (x_set_frame_alpha): Do not set property on anything
9882 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9883
e16e55d4
JB
98842011-05-02 Juanma Barranquero <lekktu@gmail.com>
9885
9886 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9887
bafcf6a5
JB
98882011-05-02 Juanma Barranquero <lekktu@gmail.com>
9889
9890 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9891 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9892 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9893 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9894 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9895 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9896 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9897 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9898 (Qgnutls_bootprop_callbacks_verify): Make static.
9899
e7a6747f
AS
99002011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9901
19ed11ba
AS
9902 * callproc.c: Indentation fixup.
9903
e7a6747f 9904 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9905 (wait_for_termination, interruptible_wait_for_termination):
9906 Move after wait_for_termination_1.
e7a6747f 9907
1ef14cb4
LMI
99082011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9909
9910 * sysdep.c (interruptible_wait_for_termination): New function
9911 which is like wait_for_termination, but allows keyboard
9912 interruptions.
9913
9914 * callproc.c (Fcall_process): Add (:file "file") as an option for
9915 the STDOUT buffer.
9916 (Fcall_process_region): Ditto.
9917
330d880c
EZ
99182011-04-30 Eli Zaretskii <eliz@gnu.org>
9919
8db90b73
EZ
9920 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9921 rather than `XVECTOR (FOO)->size'.
9922
330d880c
EZ
9923 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9924 inttypes.h, as a gnulib replacement is used if it not available in
9925 system headers.
9926
15cbd324
EZ
99272011-04-21 Eli Zaretskii <eliz@gnu.org>
9928
9929 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9930 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9931 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9932
9933 * coding.c (coding_alloc_by_realloc): Error out if destination
9934 will grow beyond MOST_POSITIVE_FIXNUM.
9935 (decode_coding_emacs_mule): Abort if there isn't enough place in
9936 charbuf for the composition carryover bytes. Reserve an extra
9937 space for up to 2 characters produced in a loop.
9938 (decode_coding_iso_2022): Abort if there isn't enough place in
9939 charbuf for the composition carryover bytes.
9940
99412011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9942
ae940cca
EZ
9943 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9944 aborting when %lld or %lll format is passed.
9945 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9946 %llo or %llx format is passed. (Bug#8545)
9947
03ab8921
EZ
9948 * window.c (window_scroll_line_based): Use a marker instead of
9949 simple variables to record original value of point. (Bug#7952)
9950
afda1437
EZ
9951 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9952 produced by %s or %c overflows available buffer space. (Bug#8545)
9953
f76dee0c
PE
99542011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9955
9956 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9957 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9958
fdc5744d
JB
99592011-04-28 Juanma Barranquero <lekktu@gmail.com>
9960
9961 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9962
638f053a
JB
99632011-04-28 Juanma Barranquero <lekktu@gmail.com>
9964
9965 * keyboard.c (Qdelayed_warnings_hook): Define.
9966 (command_loop_1): Run `delayed-warnings-hook'
9967 if Vdelayed_warnings_list is non-nil.
9968 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9969 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9970
d178f871
EZ
99712011-04-28 Eli Zaretskii <eliz@gnu.org>
9972
9973 * doprnt.c (doprnt): Don't return value smaller than the buffer
9974 size if the message was truncated. (Bug#8545).
9975
b124fd93
JB
99762011-04-28 Juanma Barranquero <lekktu@gmail.com>
9977
9978 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9979 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9980
e810457d
PE
99812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9982
9983 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9984
ea51cceb
JB
99852011-04-27 Juanma Barranquero <lekktu@gmail.com>
9986
9987 * makefile.w32-in: Update dependencies.
9988
94dcfacf
EZ
99892011-04-27 Eli Zaretskii <eliz@gnu.org>
9990
9991 Improve `doprnt' and its usage. (Bug#8545)
9992 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9993 `format_end'. Remove support for %l as a conversion specifier.
9994 Don't use xrealloc. Improve diagnostics when the %l size modifier
9995 is used. Update the commentary.
9996
9997 * eval.c (verror): Simplify calculation of size_t.
9998
9999 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10000 messages.
10001
f61f41d7
PE
100022011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10003
10004 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10005 change.
10006
96fb4434
PE
100072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10008
10009 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10010 This makes this file independent of the recent pseudovector change.
10011
671875da 100122011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10013
69e9b5a3
PE
10014 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10015
b5f869a7 10016 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10017 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10018 Remove unused local.
c8926152 10019 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10020
841a1577 10021 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10022 GCC 4.6.0 optimizes based on type-based alias analysis.
10023 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10024 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10025 != &v->size, and therefore "v->size = 1; b->size = 2; return
10026 v->size;" must therefore return 1. This assumption is incorrect
10027 for Emacs, since it type-puns struct Lisp_Vector * with many other
10028 types. To fix this problem, this patch adds a new type struct
f904488f 10029 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10030 and pseudovectors, and helps optimizing compilers not get fooled
10031 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10032 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10033 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10034 the size member.
eab3844f
PE
10035 (XSETPVECTYPE): Rewrite in terms of new macro.
10036 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10037 This is a bit clearer, and further avoids the possibility of
10038 undesirable aliasing.
10039 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10040 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10041 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10042 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10043 (ASIZE): Now uses header.size rather than size.
10044 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10045 to avoid the hassle of writing XVECTOR (foo)->header.size.
10046 (struct vectorlike_header): New type.
eab3844f
PE
10047 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10048 object, to help avoid aliasing.
10049 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10050 (SUBRP): Likewise, since Lisp_Subr is a special case.
10051 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10052 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10053 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10054 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10055 changed to be "header.size" and "header.next".
10056 * buffer.h (struct buffer): Likewise.
10057 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10058 * frame.h (struct frame): Likewise.
10059 * process.h (struct Lisp_Process): Likewise.
10060 * termhooks.h (struct terminal): Likewise.
10061 * window.c (struct save_window_data, struct saved_window): Likewise.
10062 * window.h (struct window): Likewise.
10063 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10064 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10065 * buffer.c (init_buffer_once): Likewise.
10066 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10067 special case.
10068 * process.c (Fformat_network_address): Use local var for size,
10069 for brevity.
10070
0df1eac5
PE
10071 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10072
847ab9d1 10073 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10074 * data.c (atof): Remove decl; no longer used or needed.
10075 (digit_to_number): Move to lread.c.
10076 (Fstring_to_number): Use new string_to_number function, to be
10077 consistent with how the Lisp reader treats infinities and NaNs.
10078 Do not assume that floating-point numbers represent EMACS_INT
10079 without losing information; this is not true on most 64-bit hosts.
10080 Avoid double-rounding errors, by insisting on integers when
10081 parsing non-base-10 numbers, as the documentation specifies.
10082 * lisp.h (string_to_number): New decl, replacing ...
10083 (isfloat_string): Remove.
bc0a5c13 10084 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10085 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10086 appears to have been a coding error. Similarly, do not accept
10087 strings like +-1e0 as floating point numbers. Do not report
10088 overflow for integer overflows unless the base is not 10 which
10089 means we have no simple and reliable way to continue.
10090 Break out the floating-point parsing into a new
10091 function string_to_number, so that Fstring_to_number parses
10092 floating point numbers consistently with the Lisp reader.
04f2d78b 10093 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10094 (E_CHAR, EXP_INT): Remove, replacing with ...
10095 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10096 (string_to_number): New function, replacing isfloat_string.
10097 This function checks for valid syntax and produces the resulting
10098 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10099 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10100 so that overflow for non-base-10 numbers is reported only when
10101 there's no portable and simple way to convert to floating point.
452f4150 10102
67769ffc
PE
10103 * textprop.c (set_text_properties_1): Rewrite for clarity,
10104 and to avoid GCC warning about integer overflow.
10105
c20db43f
PE
10106 * intervals.h (struct interval): Use EMACS_INT for members
10107 where EMACS_UINT might cause problems. See
10108 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10109 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10110 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10111 All uses changed.
37aa2f85
PE
10112 (offset_intervals): Tell GCC not to worry about length overflow
10113 when negating a negative length.
c20db43f 10114
2538aa2f
PE
10115 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10116 (overrun_check_free): Likewise.
10117
f2d3008d
PE
10118 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10119 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10120 word size.
10121
ec8df744
PE
10122 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10123 (gnutls_make_error): Rename local to avoid shadowing.
10124 (gnutls_emacs_global_deinit): ifdef out; not used.
10125 (Fgnutls_boot): Use const for pointer to readonly storage.
10126 Comment out unused local. Fix pointer signedness problems.
10127
640ee02d
PE
10128 * lread.c (openp): Don't stuff size_t into an 'int'.
10129 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10130 about possible signed overflow.
10131
6048fb2a
PE
10132 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10133 (GDK_KEY_g): Don't define if already defined.
10134 (xg_prepare_tooltip): Avoid pointer signedness problem.
10135 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10136
fa3c87e1
PE
10137 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10138 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10139
2172544b
PE
10140 * xfns.c (Fx_window_property): Simplify a bit,
10141 to make a bit faster and to avoid GCC 4.6.0 warning.
10142 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10143
9b821a21
PE
10144 * fns.c (internal_equal): Don't assume size_t fits in int.
10145
3c616cfa
PE
10146 * alloc.c (compact_small_strings): Tighten assertion a little.
10147
c2982e87
PE
10148 Replace pEd with more-general pI, and fix some printf arg casts.
10149 * lisp.h (pI): New macro, generalizing old pEd macro to other
10150 conversion specifiers. For example, use "...%"pI"d..." rather
10151 than "...%"pEd"...".
10152 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10153 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10154 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10155 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10156 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10157 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10158 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10159 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10160 64-bit hosts.
10161 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10162 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10163 * print.c (safe_debug_print, print_object): Likewise.
10164 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10165 to int.
6f04d126
PE
10166 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10167 avoiding the 0 flag, which is not portable.
c2982e87
PE
10168 * process.c (Fmake_network_process): Use pI to avoid cast.
10169 * region-cache.c (pp_cache): Likewise.
10170 * xdisp.c (decode_mode_spec): Likewise.
10171 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10172 behavior on 64-bit hosts with printf arg.
6f04d126 10173 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10174 (x_stop_queuing_selection_requests): Likewise.
10175 (x_get_window_property): Don't truncate byte count to an 'int'
10176 when tracing.
0b432f21 10177
5e073ec7
PE
10178 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10179 here, since it parses constructs like leading '-' and spaces,
10180 which are not wanted; and it overflows with large numbers.
10181 Instead, simply match F[0-9]+, which is what is wanted anyway.
10182
36372bf9
PE
10183 * alloc.c: Remove unportable assumptions about struct layout.
10184 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10185 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10186 (allocate_vectorlike, make_pure_vector): Use the new macros,
10187 plus offsetof, to remove unportable assumptions about struct layout.
10188 These assumptions hold on all porting targets that I know of, but
10189 they are not guaranteed, they're easy to remove, and removing them
10190 makes further changes easier.
10191
0b432f21
PE
10192 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10193 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10194 (string_overrun_cookie): Now const. Use initializers that
10195 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10196 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10197 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10198 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10199 multiple of sizeof (EMACS_INT); it need not be, if
10200 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10201 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10202
895009e1
JB
102032011-04-26 Juanma Barranquero <lekktu@gmail.com>
10204
10205 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10206
6a7a1b0b
TZ
102072011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10208
10209 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10210 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10211 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10212
841a1577 102132011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10214
10215 * lisp.h (Qdebug): List symbol.
895009e1 10216 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10217 * keyboard.c (debug-on-event): New variable.
10218 (handle_user_signal): Break into debugger when debug-on-event
10219 matches the current signal symbol.
10220
f2d3ba6f
DN
102212011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10222
10223 * alloc.c (check_sblock, check_string_bytes)
10224 (check_string_free_list): Convert to standard C.
10225
42ce4c63
TZ
102262011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10227
10228 * w32.c (emacs_gnutls_push): Fix typo.
10229
825cd63c
EZ
102302011-04-25 Eli Zaretskii <eliz@gnu.org>
10231
fb11d64d
EZ
10232 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10233 "cast to pointer from integer of different size".
10234
825cd63c
EZ
10235 Improve doprnt and its use in verror. (Bug#8545)
10236 * doprnt.c (doprnt): Document the set of format control sequences
10237 supported by the function. Use SAFE_ALLOCA instead of always
10238 using `alloca'.
10239
10240 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10241 is one byte too soon. Don't use xrealloc; instead xfree and
10242 xmalloc anew.
10243
e061a11b
TZ
102442011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10245
10246 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10247 callbacks stage.
10248
10249 * gnutls.c: Renamed global_initialized to
10250 gnutls_global_initialized. Added internals for the
10251 :verify-hostname-error, :verify-error, and :verify-flags
10252 parameters of `gnutls-boot' and documented those parameters in the
10253 docstring. Start callback support.
9173deec
JB
10254 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10255 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10256 on error. Return error code.
e061a11b
TZ
10257 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10258 (emacs_gnutls_read): Likewise.
10259 (Fgnutls_boot): Return handshake error code.
10260 (emacs_gnutls_handle_error): New function.
10261 (wsaerror_to_errno): Likewise.
10262
10263 * w32.h (emacs_gnutls_pull): Add prototype.
10264 (emacs_gnutls_push): Likewise.
10265
10266 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10267 (emacs_gnutls_push): Likewise.
10268
102692011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10270
10271 * process.c (wait_reading_process_output): Check if GnuTLS
10272 buffered some data internally if no FDs are set for TLS
10273 connections.
10274
10275 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10276 (LIBS): Link to USER_LIBS.
10277 ($(BLD)/gnutls.$(0)): New target.
10278
fa6996bc
EZ
102792011-04-24 Eli Zaretskii <eliz@gnu.org>
10280
eb35682e
EZ
10281 * xdisp.c (handle_single_display_spec): Rename the
10282 display_replaced_before_p argument into display_replaced_p, to
10283 make it consistent with the commentary. Fix typos in the
10284 commentary.
10285
e2ad650c
EZ
10286 * textprop.c (syms_of_textprop): Remove dead code.
10287 (copy_text_properties): Delete obsolete commentary about an
10288 interface that was deleted long ago. Fix typos in the description
10289 of arguments.
10290
1b2de274
EZ
10291 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10292 to changes in oldXMenu/XMenu.h from 2011-04-16.
10293 <menu_help_message, prev_menu_help_message>: Constify.
10294 (IT_menu_make_room): menu->help_text is now `const char **';
10295 adjust.
10296
10297 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10298 to changes in oldXMenu/XMenu.h from 2011-04-16.
10299 (struct XMenu): Declare `help_text' `const char **'.
10300
10301 * xfaces.c <Qunspecified>: Make extern again.
10302
10303 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10304 required by POSIX.
1b2de274 10305
762b15be
EZ
10306 * doc.c (get_doc_string): Improve the format passed to `error'.
10307
10308 * doprnt.c (doprnt): Improve commentary.
10309
10310 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10311
10312 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10313 them with etags.
10314
f1052e5d
EZ
10315 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10316 changes in globals.h immediately force recompilation.
762b15be
EZ
10317 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10318 $(CURDIR)/s/ms-w32.h.
10319 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10320
fa6996bc
EZ
10321 * character.c (Fchar_direction): Function deleted.
10322 (syms_of_character): Don't defsubr it.
10323 <char-direction-table>: Deleted.
10324
e6c3da20
EZ
103252011-04-23 Eli Zaretskii <eliz@gnu.org>
10326
10327 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10328 * doprnt.c: Include limits.h.
10329 (SIZE_MAX): New macro.
04f2d78b
CB
10330 (doprnt): Return a size_t value. 2nd arg is now size_t.
10331 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10332 Improve overflow protection. Support `l' modifier for integer
10333 conversions. Support %l conversion. Don't assume an EMACS_INT
10334 argument for integer conversions and for %c.
10335
10336 * lisp.h (doprnt): Restore prototype.
10337
10338 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10339 $(SRC)/character.h.
10340
10341 * Makefile.in (base_obj): Add back doprnt.o.
10342
10343 * deps.mk (doprnt.o): Add back prerequisites.
10344 (callint.o): Depend on character.h.
10345
10346 * eval.c (internal_lisp_condition_case): Include the handler
10347 representation in the error message.
10348 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10349 when breaking from the loop.
10350
10351 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10352
10353 * callint.c (Fcall_interactively): When displaying error message
10354 about invalid control letter, pass the character's codepoint, not
10355 a pointer to its multibyte form. Improve display of the character
10356 in octal and display also its hex code.
10357
10358 * character.c (char_string): Use %x to display the (unsigned)
10359 codepoint of an invalid character, to avoid displaying a bogus
10360 negative value.
10361
10362 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10363 `error', not SYMBOL_NAME itself.
10364
10365 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10366 character arguments to `error'.
10367
10368 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10369 to `error' in error message about FINAL_CHAR argument. Make sure
10370 FINAL_CHAR is a character, and use %c when it is passed as
10371 argument to `error'.
10372
4ffd0d6b 103732011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10374
10375 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10376
10377 * w32.c: Include <time.h>.
10378 (sys_localtime): New function.
10379
4ffd0d6b 103802011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10381
10382 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10383
4ffd0d6b 10384 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10385
4ffd0d6b 103862011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10387
4ffd0d6b
GM
10388 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10389 zombies (Bug#8467).
aac0c6e3 10390
04c56954
EZ
103912011-04-19 Eli Zaretskii <eliz@gnu.org>
10392
10393 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10394 gl_state.e_property when gl_state.object is Qt.
10395
10396 * insdel.c (make_gap_larger): Remove limitation of buffer size
10397 to <= INT_MAX.
10398
16a43933
CY
103992011-04-18 Chong Yidong <cyd@stupidchicken.com>
10400
10401 * xdisp.c (lookup_glyphless_char_display)
10402 (produce_glyphless_glyph): Handle cons cell entry in
10403 glyphless-char-display.
10404 (Vglyphless_char_display): Document it.
10405
10406 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10407 glyphless-char-display.
10408
4581706e
CY
104092011-04-17 Chong Yidong <cyd@stupidchicken.com>
10410
10411 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10412
10413 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10414
10415 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10416 definition for no-X builds.
10417
4887c6e2 104182011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10419
fd35b6f9
PE
10420 Static checks with GCC 4.6.0 and non-default toolkits.
10421
5c1ccb01
PE
10422 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10423
006c5daa
PE
10424 * process.c (keyboard_bit_set): Define only if SIGIO.
10425 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10426 (send_process): Repair possible setjmp clobbering.
10427
efc736d3
PE
10428 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10429
4e2fe2e6
PE
10430 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10431
f97334a2
PE
10432 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10433
4e75f29d
PE
10434 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10435 Define only if needed.
10436
90efadd1
PE
10437 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10438 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10439 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10440
3c647824
PE
10441 * dispextern.h (struct redisplay_interface): Rename param
10442 to avoid shadowing.
e264f262 10443 * termhooks.h (struct terminal): Likewise.
761383f4 10444 * xterm.c (xembed_send_message): Likewise.
3c647824 10445
b58c5c4a
PE
10446 * insdel.c (make_gap_smaller): Define only if
10447 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10448
cad59032
PE
10449 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10450 it.
10451
c339dc2e
PE
10452 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10453 so that we aren't warned about unused symbols.
10454
91a3e27b
PE
10455 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10456
399c71d3 10457 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10458
8ffc96f5
PE
10459 * xfns.c (x_real_positions): Mark locals as initialized.
10460
eef9bc79
PE
10461 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10462
098db9dd
PE
10463 * xterm.c: Fix problems found by static analysis with other toolkits.
10464 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10465 (x_dispatch_event): Declare static if USE_GTK, and
10466 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10467 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10468 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10469 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10470 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10471
eb18f6cc
PE
10472 * xmenu.c (menu_help_callback): Pointer type fixes.
10473 Use const pointers when pointing at readonly data. Avoid pointer
10474 signedness clashes.
10475 (FALSE): Remove unused macro.
10476 (update_frame_menubar): Remove unused decl.
10477
1fe72bf8
PE
10478 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10479
60d9e1db
PE
10480 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10481 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10482 (single_menu_item): Rename local to avoid shadowing.
10483
39261c26
PE
10484 * keyboard.c (make_lispy_event): Remove unused local var.
10485
018c5e19
PE
10486 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10487 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10488
63d2b86e
PE
10489 * bitmaps: Change bitmaps from unsigned char back to the X11
10490 compatible char. Avoid the old compiler warnings about
10491 out-of-range initializers by using, for example, '\xab' rather
10492 than 0xab.
10493
aefd87e1
PE
10494 * xgselect.c (xgselect_initialize): Check vs interface
10495 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10496
bf501fb9
PE
10497 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10498
e9829fdf
PE
10499 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10500 to read-only memory.
10501
1086c095
PE
10502 * fns.c (vector): Remove; this old hack is no longer needed.
10503
2baccd04 10504 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10505 Remove unused var.
dde42981 10506 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10507
72391843 10508 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10509
436c16df 10510 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10511 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10512 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10513
92bb796d 10514 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10515 (x_term_init): Remove local to avoid shadowing.
92bb796d 10516
764430a3 10517 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10518
10519 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10520 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10521
d1dfb56c
EZ
105222011-04-16 Eli Zaretskii <eliz@gnu.org>
10523
c4354cb4
EZ
10524 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10525
d1dfb56c
EZ
10526 Fix regex.c, syntax.c and friends for buffers > 2GB.
10527 * syntax.h (struct gl_state_s): Declare character position members
10528 EMACS_INT.
10529
10530 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10531
04f2d78b
CB
10532 * textprop.c (verify_interval_modification, interval_of):
10533 Declare arguments EMACS_INT.
d1dfb56c
EZ
10534
10535 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10536 EMACS_INT.
10537
10538 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10539
10540 * indent.c (Fvertical_motion): Local variable it_start is now
10541 EMACS_INT.
10542
10543 * regex.c (re_match, re_match_2, re_match_2_internal)
10544 (bcmp_translate, regcomp, regexec, print_double_string)
10545 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10546 (re_compile_pattern, re_exec): Declare arguments and local
10547 variables `size_t' and `ssize_t' and return values `regoff_t', as
10548 appropriate.
10549 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10550 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10551 <compile_stack_type>: `size' and `avail' are now `size_t'.
10552
10553 * regex.h <regoff_t>: Use ssize_t, not int.
10554 (re_search, re_search_2, re_match, re_match_2): Arguments that
10555 specify buffer/string position and length are now ssize_t and
10556 size_t. Return type is regoff_t.
10557
613052cd
BK
105582011-04-16 Ben Key <bkey76@gmail.com>
10559
10560 * nsfont.m: Fixed bugs in ns_get_family and
10561 ns_descriptor_to_entity that were caused by using free to
10562 deallocate memory blocks that were allocated by xmalloc (via
10563 xstrdup). This caused Emacs to crash when compiled with
10564 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10565 --enable-checking=xmallocoverrun). xfree is now used to
10566 deallocate these memory blocks.
10567
4170f62f 105682011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10569
71b41406
PE
10570 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10571
9587a89d
PE
10572 emacs_write: Accept and return EMACS_INT for sizes.
10573 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10574 et seq.
10575 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10576 Accept and return EMACS_INT.
10577 (emacs_gnutls_write): Return the number of bytes written on
10578 partial writes.
10579 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10580 (emacs_read, emacs_write): Remove check for negative size, as the
10581 Emacs source code has been audited now.
9587a89d
PE
10582 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10583 (emacs_read, emacs_write): Use it.
273a5f82
PE
10584 * process.c (send_process): Adjust to the new signatures of
10585 emacs_write and emacs_gnutls_write. Do not attempt to store
10586 a byte offset into an 'int'; it might overflow.
9587a89d 10587 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10588
3e047f51
PE
10589 * sound.c: Don't assume sizes fit in 'int'.
10590 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10591 Return EMACS_INT, not int.
3e047f51 10592 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10593 Accept EMACS_INT, not int.
10594 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10595 record read return values.
10596
cc39a9db
BK
105972011-04-15 Ben Key <bkey76@gmail.com>
10598
c9d0ec6d
JB
10599 * keyboard.c (Qundefined): Don't declare static since it is used
10600 in nsfns.m.
10601 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10602 static since they are used in nsfont.m.
cc39a9db 10603
6c60eb9f
SM
106042011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10605
10606 * process.c (Qprocessp): Don't declare static.
10607 * lisp.h (Qprocessp): Declare again.
10608
7990b61a
JB
106092011-04-15 Juanma Barranquero <lekktu@gmail.com>
10610
10611 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10612
5d4cb038
PE
106132011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10614
8bd7b830 10615 Improve C-level modularity by making more things 'static'.
cd64ea1d 10616
e3b27b31
PE
10617 Don't publish debugger-only interfaces to other modules.
10618 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10619 (verify_bytepos, count_markers): Move decls to the only modules
10620 that need them.
10621 * region-cache.h (pp_cache): Likewise.
10622 * window.h (check_all_windows): Likewise.
10623 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10624
5d4cb038
PE
10625 * sysdep.c (croak): Now static, if
10626 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10627 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10628
10629 * alloc.c (refill_memory_reserve): Now static if
10630 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10631 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10632
e87b6180
PE
10633 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10634 Define only if USE_LUCID.
10635
ac64929e
PE
10636 * xrdb.c (x_customization_string, x_rm_string): Now static.
10637
6f37259d
PE
10638 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10639 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10640
1683e3ab
PE
10641 * xdisp.c (draw_row_with_mouse_face): Now static.
10642 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10643
de9c2632
PE
10644 * window.h (check_all_windows): Mark externally visible.
10645
2b96acb7
PE
10646 * window.c (window_deletion_count): Now static.
10647
10648 * undo.c: Make symbols static if they're not exported.
10649 (last_undo_buffer, last_boundary_position, pending_boundary):
10650 Now static.
10651
50436f33
PE
10652 * textprop.c (interval_insert_behind_hooks): Now static.
10653 (interval_insert_in_front_hooks): Likewise.
10654
64520e5c
PE
10655 * term.c: Make symbols static if they're not exported.
10656 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10657 (max_frame_lines, tty_set_terminal_modes):
10658 (tty_reset_terminal_modes, tty_turn_off_highlight):
10659 (get_tty_terminal): Now static.
10660 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10661 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10662 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10663 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10664 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10665
1fa53021
PE
10666 * sysdep.c: Make symbols static if they're not exported.
10667 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10668 Now static.
10669 (sigprocmask_set, full_mask): Remove; unused.
10670 (wait_debugging): Mark as visible.
10671 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10672 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10673
d4b43b22
PE
10674 * syntax.c (syntax_temp): Define only if !__GNUC__.
10675
b7c513d0
PE
10676 * sound.c (current_sound_device, current_sound): Now static.
10677
989b29ad
PE
10678 * search.c (searchbufs, searchbuf_head): Now static.
10679
13a55a78
PE
10680 * scroll.c (scroll_cost): Remove; unused.
10681 * dispextern.h (scroll_cost): Remove decl.
10682
de68a1fc
PE
10683 * region-cache.h (pp_cache): Mark as externally visible.
10684
40ccffa6
PE
10685 * process.c: Make symbols static if they're not exported.
10686 (process_tick, update_tick, create_process, chan_process):
10687 (Vprocess_alist, proc_buffered_char, datagram_access):
10688 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10689 (deactivate_process): Mark defn as static, as well as decl.
10690 * lisp.h (create_process): Remove decl.
10691 * process.h (chan_process, Vprocess_alist): Remove decls.
10692
ad64fc97
PE
10693 * print.c: Make symbols static if they're not exported.
10694 (print_depth, new_backquote_output, being_printed, print_buffer):
10695 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10696 (print_interval, print_number_index, initial_stderr_stream):
10697 Now static.
10698 * lisp.h (Fprinc): Remove decl.
10699 (debug_output_compilation_hack): Mark as externally visible.
10700
adddb265
PE
10701 * sysdep.c (croak): Move decl from here to syssignal.h.
10702 * syssignal.h (croak): Put it here, so the API can be checked when
10703 'croak' is called from dissociate_if_controlling_tty.
10704
1717ede2
PE
10705 * minibuf.c: Make symbols static if they're not exported.
10706 (minibuf_save_list, choose_minibuf_frame): Now static.
10707 * lisp.h (choose_minibuf_frame): Remove decl.
10708
fa5fb2bc
PE
10709 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10710
1e3890d1
PE
10711 * lread.c: Make symbols static if they're not exported.
10712 (read_objects, initial_obarray, oblookup_last_bucket_number):
10713 Now static.
10714 (make_symbol): Remove; unused.
10715 * lisp.h (initial_obarray, make_symbol): Remove decls.
10716
8a1414fa
PE
10717 * keyboard.c: Make symbols static if they're not exported.
10718 (single_kboard, recent_keys_index, total_keys, recent_keys):
10719 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10720 (this_single_command_key_start, echoing, last_auto_save):
10721 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10722 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10723 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10724 (Vlispy_mouse_stem, double_click_count):
10725 Now static.
10726 (force_auto_save_soon): Define only if SIGDANGER.
10727 (ignore_mouse_drag_p): Now static if
10728 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10729 (print_help): Remove; unused.
10730 (stop_character, last_timer_event): Mark as externally visible.
10731 * keyboard.h (ignore_mouse_drag_p): Declare only if
10732 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10733 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10734 * lisp.h (echoing): Remove decl.
10735 (force_auto_save_soon): Declare only if SIGDANGER.
10736 * xdisp.c (redisplay_window): Simplify code, to make it more
10737 obvious that ignore_mouse_drag_p is not accessed if !defined
10738 USE_GTK && !defined HAVE_NS.
10739
93ea6e8f
PE
10740 * intervals.c: Make symbols static if they're not exported.
10741 (merge_properties_sticky, merge_interval_right, delete_interval):
10742 Now static.
10743 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10744
77382fcc
PE
10745 * insdel.c: Make symbols static if they're not exported.
10746 However, leave prepare_to_modify_buffer alone. It's never
10747 called from outside this function, but that appears to be a bug.
10748 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10749 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10750 (adjust_after_replace_noundo): Remove; unused.
10751 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10752 (signal_before_change): Remove decls.
77382fcc 10753
9306c32e
PE
10754 * indent.c (val_compute_motion, val_vmotion): Now static.
10755
cd44d2eb
PE
10756 * image.c: Make symbols static if they're not exported.
10757 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10758 if USE_GTK.
10759 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10760 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10761
ad9a7a06
PE
10762 * fringe.c (standard_bitmaps): Now static.
10763 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10764
81626931
PE
10765 * frame.c: Make symbols static if they're not exported.
10766 (x_report_frame_params, make_terminal_frame): Now static.
10767 (get_frame_param): Now static, unless HAVE_NS.
10768 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10769 (x_get_resource_string): Remove; not used.
10770 * frame.h (make_terminal_frame, x_report_frame_params):
10771 (x_get_resource_string); Remove decls.
10772 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10773 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10774
239f9db9
PE
10775 * font.c, fontset.c: Make symbols static if they're not exported.
10776 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10777 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10778 * font.c (font_close_object): Now static.
10779 * font.h (font_close_object): Remove.
10780 * fontset.c (FONTSET_OBJLIST): Remove.
10781 (free_realized_fontset) #if-0 the body, which does nothing.
10782 (face_suitable_for_char_p): #if-0, as it's never called.
10783 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10784 * xfaces.c (face_at_string_position):
10785 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10786 since 0 is always ASCII.
10787
dfcf3579
PE
10788 * fns.c (weak_hash_tables): Now static.
10789
5045092b
PE
10790 * fileio.c: Make symbols static if they're not exported.
10791 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10792 (Vwrite_region_annotation_buffers): Now static.
10793
57a96f5c
PE
10794 * eval.c: Make symbols static if they're not exported.
10795 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10796 * lisp.h (backtrace_list): Remove decl.
10797
35f08c38
PE
10798 * emacs.c: Make symbols static if they're not exported.
10799 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10800 (fatal_error_code, fatal_error_signal_hook, standard_args):
10801 Now static.
10802 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10803 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10804 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10805 * lisp.h (fatal_error_signal_hook): Remove decl.
10806 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10807
f44bd759
PE
10808 * editfns.c: Move a (normally-unused) function to its only use.
10809 * editfns.c, lisp.h (get_operating_system_release): Remove.
10810 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10811 worth the hassle of breaking this out.
10812
b532497d
PE
10813 * xterm.c: Make symbols static if they're not exported.
10814 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10815 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10816 (x_destroy_window, x_delete_display):
10817 Now static.
10818 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10819 (x_mouse_leave): Remove; unused.
10820 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10821 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10822 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10823 Remove decls.
10824 (x_mouse_leave): Declare only if WINDOWSNT.
10825 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10826 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10827 USE_X_TOOLKIT.
10828
1675728f
PE
10829 * ftxfont.c: Make symbols static if they're not exported.
10830 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10831 HAVE_FREETYPE.
10832 * font.h (ftxfont_driver): Likewise.
10833
e4cebfca
PE
10834 * xfns.c: Make symbols static if they're not exported.
10835 (x_last_font_name, x_display_info_for_name):
10836 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10837 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10838 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10839 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10840 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10841 (last_show_tip_args): Now static.
10842 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10843 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10844 (x_screen_planes): Remove; unused.
10845 * dispextern.h (x_screen_planes): Remove decl.
10846
5bf46f05
PE
10847 * dispnew.c: Make symbols static if they're not exported.
10848 * dispextern.h (redraw_garbaged_frames, scrolling):
10849 (increment_row_positions): Remove.
10850 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10851 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10852 Now static.
10853 (redraw_garbaged_frames): Remove; unused.
10854
435f4c28
PE
10855 * xfaces.c: Make symbols static if they're not exported.
10856 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10857 Remove decls.
10858 * xterm.h (defined_color): Remove decls.
10859 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10860 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10861 (menu_face_changed_default, defined_color, free_realized_face):
10862 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10863 (ascii_face_of_lisp_face): Remove; unused.
10864
8524aef3
PE
10865 * xdisp.c: Make symbols static if they're not exported.
10866 * dispextern.h (scratch_glyph_row, window_box_edges):
10867 (glyph_to_pixel_coords, set_cursor_from_row):
10868 (get_next_display_element, set_iterator_to_next):
10869 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10870 (show_mouse_face): Remove decls
10871 * frame.h (message_buf_print): Likewise.
10872 * lisp.h (pop_message, set_message, check_point_in_composition):
10873 Likewise.
10874 * xterm.h (set_vertical_scroll_bar): Likewise.
10875 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10876 (message_buf_print, scratch_glyph_row, displayed_buffer):
10877 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10878 (get_next_display_element, show_mouse_face, window_box_edges):
10879 (frame_to_window_pixel_xy, check_point_in_composition):
10880 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10881 (glyph_to_pixel_coords): Remove; unused.
10882
16390cd2
PE
10883 * dired.c (file_name_completion): Now static.
10884
10885 * dbusbind.c (xd_in_read_queued_messages): Now static.
10886
a25f4dfa
PE
10887 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10888 * data.c (circular_list_error): Remove.
10889
14a9c8df
PE
10890 * commands.h (last_point_position, last_point_position_buffer):
10891 (last_point_position_window): Remove decls.
10892 * keyboard.c: Make these variables static.
10893
04f2d78b
CB
10894 * coding.h (coding, code_convert_region, encode_coding_gap):
10895 Remove decls.
74ab6df5
PE
10896 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10897 (iso_code_class, detect_coding, code_convert_region): Now static.
10898 (encode_coding_gap): Remove; unused.
10899
38dfbee1
PE
10900 * chartab.c (chartab_chars, chartab_bits): Now static.
10901
a2cb4e63
PE
10902 * charset.h (charset_iso_8859_1): Remove decl.
10903 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10904 Now static.
10905
127198fd
PE
10906 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10907 * ccl.c (Vccl_program_table): Now static.
10908 (check_ccl_update): Remove; unused.
10909
d85b608f
PE
10910 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10911 * category.h: ... from here.
10912 * category.c (check_category_table, set_category_set): Now static.
10913
31cd66f3
PE
10914 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10915 * lisp.h: Remove these decls.
10916
c358e587
PE
10917 * buffer.c (buffer_count): Remove unused var.
10918
e78aecca
PE
10919 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10920 so that it's not optimized away.
10921 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10922 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10923 exported only to the debugger.
10924
e192d7d3 10925 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10926 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10927
92470028
PE
10928 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10929 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10930 was inaccessible from Lisp.
10931 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10932 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10933
244ed907
PE
10934 alloc.c: Import and export fewer symbols, and remove unused items.
10935 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10936 is defined.
10937 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10938 it's not optimized away by whole-program optimization.
10939 (message_enable_multibyte, free_misc): Remove.
10940 (catchlist, handlerlist, mark_backtrace):
10941 Declare only if BYTE_MARK_STACK.
10942 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10943 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10944 (message_enable_multibyte): Remove decl.
10945 (free_misc, interval_free_list, float_block, float_block_index):
10946 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10947 (cons_free_list, last_marked_index):
10948 Now static.
10949 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10950 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10951 (mark_backtrace): Define only if BYTE_MARK_STACK.
10952 * xdisp.c (message_enable_multibyte): Now static.
10953
61c2b50e 10954 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10955 This makes it easier for human readers (and static analyzers)
10956 to see whether these variables are used from other modules.
10957 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10958 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10959 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10960 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10961 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10962 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10963 * xmenu.c, xselect.c:
10964 Declare Q* vars static if they are not used in other modules.
10965 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10966 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10967 Remove decls of unexported vars.
10968 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10969
95c82688
PE
10970 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10971
16a97296
PE
10972 Make Emacs functions such as Fatom 'static' by default.
10973 This makes it easier for human readers (and static analyzers)
10974 to see whether these functions can be called from other modules.
10975 DEFUN now defines a static function. To make the function external
10976 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10977 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10978 (Finit_image_library):
16a97296
PE
10979 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10980 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10981 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10982 Remove decls, since these functions are now static.
10983 (Funintern, Fget_internal_run_time): New decls, since these functions
10984 were already external.
95c82688 10985
16a97296
PE
10986 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10987 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10988 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10989 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10990 * keyboard.c, keymap.c, lread.c:
10991 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10992 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10993 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10994 Mark functions with DEFUE instead of DEFUN,
10995 if they are used in other modules.
10996 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10997 decls for now-static functions.
10998 * buffer.h (Fdelete_overlay): Remove decl.
10999 * callproc.c (Fgetenv_internal): Mark as internal.
11000 * composite.c (Fremove_list_of_text_properties): Remove decl.
11001 (Fcomposition_get_gstring): New forward static decl.
11002 * composite.h (Fcomposite_get_gstring): Remove decl.
11003 * dired.c (Ffile_attributes): New forward static decl.
11004 * doc.c (Fdocumntation_property): New forward static decl.
11005 * eval.c (Ffetch_bytecode): New forward static decl.
11006 (Funintern): Remove extern decl; now in .h file where it belongs.
11007 * fileio.c (Fmake_symbolic_link): New forward static decl.
11008 * image.c (Finit_image_library): New forward static decl.
11009 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11010 * intervals.h (Fprevious_property_change):
11011 (Fremove_list_of_text_properties): Remove decls.
11012 * keyboard.c (Fthis_command_keys): Remove decl.
11013 (Fcommand_execute): New forward static decl.
11014 * keymap.c (Flookup_key): New forward static decl.
11015 (Fcopy_keymap): Now static.
11016 * keymap.h (Flookup_key): Remove decl.
11017 * process.c (Fget_process): New forward static decl.
11018 (Fprocess_datagram_address): Mark as internal.
11019 * syntax.c (Fsyntax_table_p): New forward static decl.
11020 (skip_chars): Remove duplicate decl.
11021 * textprop.c (Fprevious_property_change): New forward static decl.
11022 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11023 Now internal.
11024 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11025 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11026
785bbd42
PE
11027 * editfns.c (Fformat): Remove unreachable code.
11028
8b913b57
AS
110292011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11030
11031 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11032 change. (Bug#8496)
11033
a6744a35
EZ
110342011-04-13 Eli Zaretskii <eliz@gnu.org>
11035
11036 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11037 when at ZV. (Bug#8487)
11038
e7974947
AS
110392011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11040
baad03f0
AS
11041 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11042 (Bug#8437)
11043 * keyboard.c (parse_tool_bar_item): Likewise.
11044 * sound.c (sound_cleanup, alsa_close): Likewise.
11045 * termcap.c (tgetent): Likewise.
11046 * xfns.c (x_default_font_parameter): Likewise.
11047 * xsettings.c (read_and_apply_settings): Likewise.
11048
e7974947
AS
11049 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11050 (overrun_check_free): Protoize.
11051
28272684
PE
110522011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11053
11054 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11055 since callers should never pass a negative size.
11056 Change the signature to match that of plain 'read' and 'write'; see
11057 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11058 * lisp.h: Update prototypes of emacs_write and emacs_read.
11059
11997c76
EZ
110602011-04-11 Eli Zaretskii <eliz@gnu.org>
11061
11062 * xdisp.c (redisplay_window): Don't try to determine the character
11063 position of the scroll margin if the window start point w->startp
e896f03c 11064 is outside the buffer's accessible region. (Bug#8468)
11997c76 11065
8a2cbd72
EZ
110662011-04-10 Eli Zaretskii <eliz@gnu.org>
11067
11068 Fix write-region and its subroutines for buffers > 2GB.
11069 * fileio.c (a_write, e_write): Modify declaration of arguments and
11070 local variables to support buffers larger than 2GB.
11071 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11072
11073 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11074 argument, local variables, and return value.
11075
11076 * lisp.h: Update prototypes of emacs_write and emacs_read.
11077
11078 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11079
4073e537 110802011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11081
1ebfdcb6
PE
11082 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11083
b2ded58d
PE
11084 Fix more problems found by GCC 4.6.0's static checks.
11085
7d66342c
PE
11086 * xdisp.c (vmessage): Use a better test for character truncation.
11087
bbf47d44
PE
11088 * charset.c (load_charset_map): <, not <=, for optimization,
11089 and to avoid potential problems with integer overflow.
9248994d 11090 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11091 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11092 * editfns.c (Fformat): Likewise.
1e69125e 11093 * syntax.c (skip_chars): Likewise.
3befa583 11094
e3019616
PE
11095 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11096 This also lets GCC 4.6.0 generate slightly better loop code.
11097
becfa255
PE
11098 * callint.c (Fcall_interactively): <, not <=, for optimization.
11099 (Fcall_interactively): Count the number of arguments produced,
11100 not the number of arguments given. This is simpler and lets GCC
11101 4.6.0 generate slightly better code.
11102
dae0cd48
PE
11103 * ftfont.c: Distingish more carefully between FcChar8 and char.
11104 The previous code passed unsigned char * to a functions like
11105 strlen and xstrcasecmp that expect char *, which does not
11106 conform to the C standard.
11107 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11108 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11109 char * when the C standard requires it.
11110
76032d70
PE
11111 * keyboard.c (read_char): Remove unused var.
11112
eb3f1cc8
PE
11113 * eval.c: Port to Windows vsnprintf (Bug#8435).
11114 Include <limits.h>.
11115 (SIZE_MAX): Define if the headers do not.
11116 (verror): Do not give up if vsnprintf returns a negative count.
11117 Instead, grow the buffer. This ports to Windows vsnprintf, which
11118 does not conform to C99. Problem reported by Eli Zaretskii.
11119 Also, simplify the allocation scheme, by avoiding the need for
11120 calling realloc, and removing the ALLOCATED variable.
11121
70476b54
PE
11122 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11123
12020a9e
PE
11124 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11125 But keep the doprint source code for now, as we might revamp it
11126 and use it again (Bug#8435).
ea6c7ae6
PE
11127 * lisp.h (doprnt): Remove.
11128 * Makefile.in (base_obj): Remove doprnt.o.
11129 * deps.mk (doprnt.o): Remove.
11130
5fdb398c
PE
11131 error: Print 32- and 64-bit integers portably (Bug#8435).
11132 Without this change, on typical 64-bit hosts error ("...%d...", N)
11133 was used to print both 32- and 64-bit integers N, which relied on
11134 undefined behavior.
61bdb816 11135 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11136 * lisp.h (error, verror): Mark as printf-like functions.
11137 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11138 Report overflow in size calculations when allocating printf buffer.
11139 Do not truncate output string at its first null byte.
11140 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11141 Truncate the output at a character boundary, since vsnprintf does not
11142 do that.
11143 * charset.c (check_iso_charset_parameter): Convert internal
11144 character to string before calling 'error', since %c now has the
11145 printf meaning.
11146 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11147 overflow when computing char to be passed to 'error'. Do not
11148 pass Lisp_Object to 'error'; pass the integer instead.
11149 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11150 formatted with plain %d.
11151
b189fa66
PE
11152 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11153
bff87ef0
PE
11154 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11155
7e2cac20
PE
11156 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11157
ce4d90b5
PE
11158 * xterm.c (x_catch_errors): Remove duplicate declaration.
11159
266c9547
PE
11160 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11161
79c49ad2
PE
11162 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11163
368f4090
JM
111642011-04-10 Jim Meyering <meyering@redhat.com>
11165
11166 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11167 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11168 return ssize_t not "int", and use size_t as the buffer length.
11169 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11170 * gnutls.h: Update declarations.
11171 * process.c (read_process_output): Use ssize_t, to match.
11172 (send_process): Likewise.
11173
a32d4040
CY
111742011-04-09 Chong Yidong <cyd@stupidchicken.com>
11175
11176 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11177
8546720e 111782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11179
04f2d78b
CB
11180 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11181 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11182
8546720e
GM
11183 * xterm.c (handle_one_xevent):
11184 * xmenu.c (create_and_show_popup_menu):
11185 * xselect.c (x_decline_selection_request)
11186 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11187
0a2f5c1a 111882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11189
11190 Fix some uses of `int' instead of EMACS_INT.
11191 * search.c (string_match_1, fast_string_match)
11192 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11193 (scan_buffer, find_next_newline_no_quit)
11194 (find_before_next_newline, search_command, Freplace_match)
11195 (Fmatch_data): Make some `int' variables be EMACS_INT.
11196
11197 * xdisp.c (display_count_lines): 3rd argument and return value now
11198 EMACS_INT. All callers changed.
11199 (pint2hrstr): Last argument is now EMACS_INT.
11200
11201 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11202 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11203 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11204 (decode_coding_utf_16, decode_coding_emacs_mule)
11205 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11206 (decode_coding_ccl, decode_coding_charset)
11207 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11208 (decode_coding_iso_2022, decode_coding_emacs_mule)
11209 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11210 <char_offset, last_offset>: Declare EMACS_INT.
11211 (encode_coding_utf_8, encode_coding_utf_16)
11212 (encode_coding_emacs_mule, encode_invocation_designation)
11213 (encode_designation_at_bol, encode_coding_iso_2022)
11214 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11215 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11216 Declare EMACS_INT.
11217 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11218 (encode_invocation_designation): Last argument P_NCHARS is now
11219 EMACS_INT.
11220 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11221 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11222
11223 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11224 All users changed.
11225
11226 * ccl.c (Fccl_execute_on_string): Declare some variables
11227 EMACS_INT.
11228
8546720e 112292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11230
11231 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11232
4e19a977
CS
112332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11234
11235 * process.c (Fformat_network_address): Doc fix.
11236
87302331
R
112372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11238
ee7683eb 11239 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11240
cbb59342
CY
112412011-04-08 Chong Yidong <cyd@stupidchicken.com>
11242
11243 * keyboard.c (read_char): Call Lisp function help-form-show,
11244 instead of using internal_with_output_to_temp_buffer.
11245 (Qhelp_form_show): New var.
e0d38eeb 11246 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11247
11248 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11249
11250 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11251
e67a13ab
CY
112522011-04-06 Chong Yidong <cyd@stupidchicken.com>
11253
04f2d78b
CB
11254 * process.c (Flist_processes): Remove to Lisp.
11255 (list_processes_1): Delete.
e67a13ab 11256
973f782d
EZ
112572011-04-06 Eli Zaretskii <eliz@gnu.org>
11258
7c106b1e
EZ
11259 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11260
973f782d
EZ
11261 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11262
41cf7d1a 112632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11264
ca23cc88
PE
11265 Fix more problems found by GCC 4.6.0's static checks.
11266
f390e2d5
PE
11267 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11268
42eea0d0
PE
11269 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11270
b69769da 11271 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11272
f9541e84
PE
11273 * xdisp.c (vmessage): Mark as a printf-like function.
11274
13841b55
PE
11275 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11276
c136c10f
PE
11277 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11278
5e2d4a30
PE
11279 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11280 printf-like functions.
11281 (tiff_load): Add casts to remove these marks before passing them
11282 to system-supplied API.
11283
583f48b9
PE
11284 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11285
b25d760e
PE
11286 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11287 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11288 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11289 directly, rather than having caller test rule sign. This avoids
11290 some unnecessary tests.
11291 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11292 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11293 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11294
bc7b6697 11295 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11296 (xfont_open): Avoid unnecessary tests.
bc7b6697 11297
27ccc379
PE
11298 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11299
dcd5c89a
PE
11300 * composite.h, composite.c (composition_gstring_put_cache):
11301 Use EMACS_INT, not int, for length.
11302
b13a45c6
PE
11303 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11304 breaking out part of COMPOSITION_DECODE_RULE.
11305 (COMPOSITION_DECODE_RULE): Use it.
11306 * composite.c (get_composition_id): Remove unused local vars,
11307 by using the new macro.
11308
1e792e4d
PE
11309 * textprop.c (set_text_properties_1): Change while to do-while,
11310 since the condition is always true at first.
11311
dc6c6455 11312 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11313 (interval_deletion_adjustment): Return unsigned value.
11314 All uses changed.
dc6c6455 11315
aba7731a
PE
11316 * process.c (list_processes_1, create_pty, read_process_output):
11317 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11318 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11319 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11320 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11321 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11322
fdfc4bf3
PE
11323 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11324
fca8fe46 11325 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11326 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11327
06a0259a 11328 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11329 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11330 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11331
e7b9e80f
PE
11332 * print.c (print_error_message): Avoid int overflow.
11333
56201685
PE
11334 * font.c (font_list_entities): Redo for clarity,
11335 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11336
78834453 11337 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11338 (font_score): Avoid potential overflow in diff calculation.
78834453 11339
0bc0b309 11340 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11341 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11342
e610eaca
PE
11343 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11344
b895abce
PE
11345 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11346 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11347 can always succeed if overflow has undefined behavior.
11348
1f1d9321 11349 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11350 (wordify): Omit three unnecessary tests.
1f1d9321 11351
c59478bc
PE
11352 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11353 All callers changed. This avoids the need for an unused var.
11354
79b73827
PE
11355 * casefiddle.c (casify_region): Remove var that is set but not used.
11356
a4db5dfe
PE
11357 * dired.c (file_name_completion): Remove var that is set but not used.
11358
43aae36e
PE
11359 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11360
2a47c44d 11361 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11362 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11363
a37c69bf
PE
11364 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11365 Check for integer overflow on size calculations.
11366
328ab8e7
PE
11367 * buffer.c (Fprevious_overlay_change): Remove var that is set
11368 but not used.
11369
e5a2a5cb
PE
11370 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11371 Remove vars that are set but not used.
8d84a6eb 11372 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11373 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11374
a60e5f68
PE
11375 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11376
f661cb61 11377 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11378 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11379
f0397f5a
PE
11380 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11381 that are set but not used.
11382
8664db06 11383 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11384 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11385
6abdaa4a
PE
11386 * xselect.c (x_get_local_selection, x_handle_property_notify):
11387 Remove vars that are set but not used.
11388
0ce7538d 11389 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11390 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11391
9ae848fc
PE
11392 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11393 Remove var that is set but not used.
0b918413
PE
11394 (scroll_bar_windows_size): Now size_t, not int.
11395 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11396 Check for overflow.
9ae848fc 11397
a5a62657
PE
11398 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11399 (map_tty_color) [!defined MSDOS]: Likewise.
11400
5c5cdd39
PE
11401 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11402
66ebf983
PE
11403 * coding.c: Remove vars that are set but not used.
11404 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11405 All callers changed.
11406 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11407 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11408 (decode_coding_charset): Remove vars that are set but not used.
11409
1be4d761
PE
11410 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11411 that is set but not used.
11412
47553fa8
PE
11413 * print.c (print_object): Remove var that is set but not used.
11414
1f7196bf 11415 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11416 The gnulib version avoids calling malloc in the usual case,
11417 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11418 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11419 * filelock.c (current_lock_owner): Likewise.
11420 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11421 * sysdep.c: Include allocator.h, careadlinkat.h.
11422 (emacs_no_realloc_allocator): New static constant.
11423 (emacs_readlink): New function.
fdb61804
PE
11424 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11425 ../lib/careadlinkat.h.
d1fdcab7 11426
f84c17c7
SM
114272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11428
11429 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11430 first non-nil return value).
11431
ef3862ad
JD
114322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11433
11434 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11435 if not defined (Bug#8403).
11436
376a7006
JB
114372011-04-02 Juanma Barranquero <lekktu@gmail.com>
11438
11439 * xdisp.c (display_count_lines): Remove parameter `start',
11440 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11441 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11442 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11443 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11444 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11445 and thereabouts. All callers changed.
11446 (get_per_char_metric): Remove parameter `f', unused since
11447 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11448
6ca3801d
JM
114492011-04-02 Jim Meyering <meyering@redhat.com>
11450
11451 do not dereference NULL upon failed strdup
11452 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11453 (ns_get_family): Likewise.
11454
d8e2b5ba
JB
114552011-04-02 Juanma Barranquero <lekktu@gmail.com>
11456
11457 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11458
8c74fcbd
JD
114592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11460
11461 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11462 later (Bug#8403).
11463
7200d79c
SM
114642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11465
03408648 11466 Add lexical binding.
7200d79c 11467
03408648
SM
11468 * window.c (Ftemp_output_buffer_show): New fun.
11469 (Fsave_window_excursion):
11470 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11471
11472 * lread.c (lisp_file_lexically_bound_p): New function.
11473 (Fload): Bind Qlexical_binding.
11474 (readevalloop): Remove `evalfun' arg.
11475 Bind Qinternal_interpreter_environment.
11476 (Feval_buffer): Bind Qlexical_binding.
11477 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11478 Mark as dynamic.
11479 (syms_of_lread): Declare `lexical-binding'.
11480
11481 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11482
11483 * keyboard.c (eval_dyn): New fun.
11484 (menu_item_eval_property): Use it.
ca105506
SM
11485
11486 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11487
03408648
SM
11488 * fns.c (concat, mapcar1): Accept byte-code-functions.
11489
11490 * eval.c (Fsetq): Handle lexical vars.
11491 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11492 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11493 (FletX, Flet): Obey lexical binding.
11494 (Fcommandp): Handle closures.
11495 (Feval): New `lexical' arg.
11496 (eval_sub): New function extracted from Feval. Use it almost
11497 everywhere where Feval was used. Look up vars in lexical env.
11498 Handle closures.
11499 (Ffunctionp): Move from subr.el.
11500 (Ffuncall): Handle closures.
11501 (apply_lambda): Remove `eval_flags'.
11502 (funcall_lambda): Handle closures and new byte-code-functions.
11503 (Fspecial_variable_p): New function.
11504 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11505 but without exporting it to Lisp.
23aba0ea 11506
23aba0ea 11507 * doc.c (Fdocumentation, store_function_docstring):
03408648 11508 * data.c (Finteractive_form): Handle closures.
23aba0ea 11509
03408648
SM
11510 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11511 interactive spec.
ba83908c 11512
04f2d78b
CB
11513 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11514 New byte-codes.
03408648
SM
11515 (exec_byte_code): New function extracted from Fbyte_code to handle new
11516 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11517
03408648 11518 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11519
03408648 11520 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11521
e2abce01
JB
115222011-03-31 Juanma Barranquero <lekktu@gmail.com>
11523
11524 * xdisp.c (redisplay_internal): Fix prototype.
11525
63696a73 115262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11527
63696a73 11528 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11529 (try_scrolling): Use it when setting scroll_limit.
11530 Limit scrolling to 100 screen lines.
63696a73
EZ
11531 (redisplay_window): Even when falling back on "recentering",
11532 position point in the window according to scroll-conservatively,
11533 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11534
11535 (try_scrolling): When point is above the window, allow searching
11536 as far as scroll_max, or one screenful, to compute vertical
11537 distance from PT to the scroll margin position. This prevents
11538 try_scrolling from unnecessarily failing when
11539 scroll-conservatively is set to a value slightly larger than the
11540 window height. Clean up the case of PT below the margin at bottom
11541 of window: scroll_max can no longer be INT_MAX. When aggressive
11542 scrolling is in use, don't let point enter the opposite scroll
11543 margin as result of the scroll.
11544 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11545 threshold of 100 lines for never-recentering scrolling.
11546
e4cc2dfc
JB
115472011-03-31 Juanma Barranquero <lekktu@gmail.com>
11548
11549 * dispextern.h (move_it_by_lines):
11550 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11551 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11552 (message_log_check_duplicate): Remove parameters `prev_bol' and
11553 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11554 (redisplay_internal): Remove parameter `preserve_echo_area',
11555 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11556
11557 * indent.c (Fvertical_motion):
11558 * window.c (window_scroll_pixel_based, Frecenter):
11559 Don't pass `need_y_p' to `move_it_by_lines'.
11560
1c470562
SM
115612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11562
44f230aa
SM
11563 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11564 steal a few bits to be more compact.
11565 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11566 Remove unneeded casts.
11567
1c470562
SM
11568 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11569
888adce9
ZK
115702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11571
11572 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11573 binding" message (bug#7967).
11574
f838ed7b
PE
115752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11576
77861b95
PE
11577 Fix more problems found by GCC 4.6.0's static checks.
11578
de6dbc14
PE
11579 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11580 Remove unused local var.
11581
f838ed7b
PE
11582 * editfns.c (Fmessage_box): Remove unused local var.
11583
792c7b2b
PE
11584 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11585 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11586 Omit unused local vars.
c499e557 11587 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11588 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11589 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11590 Omit unused local var.
11591
ba0165e1
PE
11592 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11593 Don't assume string length fits in int.
32ad8845 11594 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11595 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11596
3c59b4c9
PE
11597 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11598 instead of alloca (Bug#8344).
11599
a3eed478 11600 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11601 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11602
eb4d412d
PE
11603 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11604
1658b401
PE
11605 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11606 concerns.
11607
11608 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11609
11610 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11611
9a2c6e05
PE
11612 * keyboard.c (syms_of_keyboard): Use the same style as later
11613 in this function when indexing through an array. This also
11614 works around GCC bug 48267.
11615
03d0a109
PE
11616 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11617
44f730c8
PE
11618 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11619
fe75f926
PE
11620 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11621 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11622
ffa8c828
PE
11623 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11624 This avoids undefined behavior on integer overflow, and is a bit
11625 more convenient anyway since it is compared to a size_t variable.
11626
c5101a77
PE
11627 Variadic C functions now count arguments with size_t, not int.
11628 This avoids an unnecessary limitation on 64-bit machines, which
11629 caused (substring ...) to crash on large vectors (Bug#8344).
11630 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11631 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11632 All variadic functions and their callers changed accordingly.
c5101a77
PE
11633 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11634 * data.c (arith_driver, float_arith_driver): Likewise.
11635 * editfns.c (general_insert_function): Likewise.
11636 * eval.c (struct backtrace.nargs, interactive_p)
11637 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11638 (funcall_lambda, mark_backtrace): Likewise.
11639 * fns.c (concat): Likewise.
11640 * frame.c (x_set_frame_parameters): Likewise.
11641 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11642 0 if not found, not -1. All callers changed.
11643
dd3f25f7
PE
11644 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11645 (stack_copy_size): Now size_t, not int.
11646 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11647
461c2ab9
JB
116482011-03-28 Juanma Barranquero <lekktu@gmail.com>
11649
11650 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11651 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11652 All callers changed.
11653
11654 * lisp.h (multibyte_char_to_unibyte):
11655 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11656 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11657 * character.h (CHAR_TO_BYTE8):
11658 * cmds.c (internal_self_insert):
11659 * editfns.c (general_insert_function):
11660 * keymap.c (push_key_description):
11661 * search.c (Freplace_match):
11662 * xdisp.c (message_dolog, set_message_1): All callers changed.
11663
f6d62986
SM
116642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11665
11666 * keyboard.c (safe_run_hook_funcall): New function.
11667 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11668 don't set the hook to nil, but remove the offending function instead.
11669 (Qcommand_hook_internal): Remove, unused.
11670 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11671 Vcommand_hook_internal.
11672
11673 * eval.c (enum run_hooks_condition): Remove.
11674 (funcall_nil, funcall_not): New functions.
11675 (run_hook_with_args): Call each function through a `funcall' argument.
11676 Remove `cond' argument, now redundant.
11677 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11678 (Frun_hook_with_args_until_failure): Adjust accordingly.
11679 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11680
1db5b1ad
JB
116812011-03-28 Juanma Barranquero <lekktu@gmail.com>
11682
11683 * dispextern.h (string_buffer_position): Remove declaration.
11684
11685 * print.c (strout): Remove parameter `multibyte', unused since
11686 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11687
11688 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11689 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11690 All callers changed.
11691
11692 * w32.c (_wsa_errlist): Use braces for struct initializers.
11693
11694 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11695 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11696 All callers changed.
11697 (string_buffer_position): Likewise. Also, make static (it's never
11698 used outside xdisp.c).
11699 (cursor_row_p): Remove parameter `w', unused since
11700 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11701 (decode_mode_spec): Remove parameter `precision', introduced during
11702 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11703 All callers changed.
11704
5ffb62aa
JD
117052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11706
11707 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11708
461c2ab9 117092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11710
11711 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11712 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11713 (ns_update_auto_hide_menu_bar): New functions.
11714 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11715 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11716 ns_constrain_all_frames.
11717 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11718 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11719
5c380ffb
JD
117202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11721
11722 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11723
9af30bdf
GM
117242011-03-27 Glenn Morris <rgm@gnu.org>
11725
11726 * syssignal.h: Replace RETSIGTYPE with void.
11727 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11728 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11729 Replace SIGTYPE with void everywhere.
11730 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11731 * s/template.h (SIGTYPE): Remove commented out definition.
11732
e2abce01
JB
117332011-03-26 Eli Zaretskii <eliz@gnu.org>
11734
11735 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11736 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11737
f868cd8a
JB
117382011-03-26 Juanma Barranquero <lekktu@gmail.com>
11739
59eb0929
JB
11740 * w32.c (read_unc_volume): Use parameter `henum', instead of
11741 global variable `wget_enum_handle'.
11742
11743 * keymap.c (describe_vector): Remove parameters `indices' and
11744 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11745 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11746
f868cd8a
JB
11747 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11748
11749 * keyboard.c (timer_check): Remove parameter `do_it_now',
11750 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11751 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11752 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11753
11754 * keyboard.c (read_char):
11755 * w32menu.c (w32_menu_display_help):
11756 * xmenu.c (show_help_event, menu_help_callback):
11757 Adjust calls to `show_help_echo'.
11758
11759 * gtkutil.c (xg_maybe_add_timer):
11760 * keyboard.c (readable_events):
11761 * process.c (wait_reading_process_output):
11762 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11763
11764 * insdel.c (adjust_markers_gap_motion):
11765 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11766 (gap_left, gap_right): Don't call it.
11767
2ecf6fdb
CY
117682011-03-25 Chong Yidong <cyd@stupidchicken.com>
11769
11770 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11771 incurred during fontification.
11772
6b1f9ba4
JB
117732011-03-25 Juanma Barranquero <lekktu@gmail.com>
11774
11775 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11776 (DEFVAR_PER_BUFFER): Don't pass it.
11777
11778 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11779 (scrolling_window): Don't pass it.
11780
0f4a96b5
JB
117812011-03-25 Juanma Barranquero <lekktu@gmail.com>
11782
11783 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11784
11785 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11786 and `suffix'.
11787 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11788 of variables specific to SELinux and computation of `encoded_absname'.
11789
11790 * image.c (XPutPixel): Remove unused variable `height'.
11791
11792 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11793
11794 * unexw32.c (get_section_info): Remove unused variable `section'.
11795
11796 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11797 (system_process_attributes): Remove unused variable `sess'.
11798 (sys_read): Remove unused variable `err'.
11799
11800 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11801 (w32_wnd_proc): Remove unused variable `isdead'.
11802 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11803 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11804 (x_create_tip_frame): Remove unused variable `tem'.
11805
11806 * w32inevt.c (w32_console_read_socket):
11807 Remove unused variable `no_events'.
11808
11809 * w32term.c (x_draw_composite_glyph_string_foreground):
11810 Remove unused variable `width'.
11811
1149507c
JB
118122011-03-24 Juanma Barranquero <lekktu@gmail.com>
11813
11814 * w32term.c (x_set_glyph_string_clipping):
11815 Don't pass uninitialized region to CombineRgn.
11816
9c88f339
JB
118172011-03-23 Juanma Barranquero <lekktu@gmail.com>
11818
11819 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11820 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11821 (Fx_close_connection): Remove unused variable `i'.
11822
11823 * w32font.c (w32font_draw): Return number of glyphs.
11824 (w32font_open_internal): Remove unused variable `i'.
11825 (w32font_driver): Add missing initializer.
11826
11827 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11828 (fill_in_menu): Remove unused variable `items_added'.
11829
11830 * w32term.c (last_mouse_press_frame): Remove static global variable.
11831 (w32_clip_to_row): Remove unused variable `f'.
11832 (x_delete_terminal): Remove unused variable `i'.
11833
11834 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11835 (NOTHING): Remove unused static global variable.
11836 (uniscribe_check_otf): Remove unused variable `table'.
11837 (uniscribe_font_driver): Add missing initializers.
11838
dee091a3
JD
118392011-03-23 Julien Danjou <julien@danjou.info>
11840
11841 * term.c (Fsuspend_tty, Fresume_tty):
11842 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11843 * window.c (temp_output_buffer_show):
11844 * insdel.c (signal_before_change):
11845 * frame.c (Fhandle_switch_frame):
11846 * fileio.c (Fdo_auto_save):
11847 * emacs.c (Fkill_emacs):
11848 * editfns.c (save_excursion_restore):
11849 * cmds.c (internal_self_insert):
11850 * callint.c (Fcall_interactively):
11851 * buffer.c (Fkill_all_local_variables):
11852 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11853 Use Frun_hooks.
0f4a96b5 11854 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11855 unconditionally since it does the check itself.
dee091a3 11856
2c520ab5 118572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11858
c9c49752
PE
11859 Fix more problems found by GCC 4.5.2's static checks.
11860
8abc3f12
PE
11861 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11862 the first time through the loop, since we know p0 < p1 then.
11863 This also avoids a gcc -Wstrict-overflow warning.
11864
a2d26660
PE
11865 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11866 leading to a memory leak, possible in functions like
11867 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11868 of objects (Bug#8318).
a2d26660 11869
916c72e9
PE
11870 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11871 that could (at least in theory) be that large.
11872
19ab8a18
PE
11873 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11874 This is less likely to overflow, and avoids undefined behavior if
11875 overflow does occur. All callers changed. Use strtoul to scan
11876 for the unsigned long integer.
b7cbbd6f
PE
11877 (pint2hrstr): Simplify and tune code slightly.
11878 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11879
f0641eff
PE
11880 * scroll.c (do_scrolling): Work around GCC bug 48228.
11881 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11882
7f650bb9
PE
11883 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11884 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11885 (validate_x_resource_name): Simplify count usage.
11886 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11887
37dd57d1
PE
11888 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11889 fail (Bug#8306).
81e56e61 11890
699979fc 11891 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11892
401bf9b4
PE
11893 * process.c (Fmake_network_process): Use socklen_t, not int,
11894 where POSIX says socklen_t is required in portable programs.
11895 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11896 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11897 (Fmake_network_process, server_accept_connection):
11898 (wait_reading_process_output, read_process_output):
11899 Likewise.
11900
b93aacde
PE
11901 * process.c: Rename or move locals to avoid shadowing.
11902 (list_processes_1, Fmake_network_process):
11903 (read_process_output_error_handler, exec_sentinel_error_handler):
11904 Rename or move locals.
4dc343ee 11905 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11906 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11907 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11908 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11909 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11910
af8a867c 11911 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11912 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11913 Include tparam.h instead, since it declares them.
af8a867c
PE
11914 * cm.h (PC): Remove extern decl; tparam.h now does this.
11915 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11916 * terminfo.c: Include tparam.h, to check interfaces.
11917 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11918 (tparam): Adjust signature to match interface in tparam.h;
11919 this removes some undefined behavior. Check that outstring and len
11920 are zero, which they always are with Emacs.
11921 * tparam.h (PC, BC, UP): New extern decls.
11922
0248044d 11923 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11924 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11925
8ff096c1 11926 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11927 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11928 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11929 (ftfont_list): Remove unused local.
49eaafba
PE
11930 (get_adstyle_property, ftfont_pattern_entity):
11931 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11932 Rename locals to avoid shadowing.
8ff096c1 11933
e2be39f6
PE
11934 * xfont.c (xfont_list_family): Mark var as initialized.
11935
c9735e30
PE
11936 * xml.c (make_dom): Now static.
11937
8f5201ae
PE
11938 * composite.c (composition_compute_stop_pos): Rename local to
11939 avoid shadowing.
b246f932
PE
11940 (composition_reseat_it): Remove unused locals.
11941 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11942 (composition_update_it): Mark var as initialized.
11b61122
PE
11943 (find_automatic_composition): Mark vars as initialized,
11944 with a FIXME (Bug#8290).
8f5201ae 11945
760fbc2c
PE
11946 character.h: Rename locals to avoid shadowing.
11947 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11948 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11949 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11950 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11951 to avoid shadowing.
11952
ff08eb85
PE
11953 * textprop.c (property_change_between_p): Remove; unused.
11954
fc7bf025
PE
11955 * intervals.c (interval_start_pos): Now static.
11956
235d7abc
PE
11957 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11958
44f230aa
SM
11959 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11960 Rename locals to avoid shadowing.
3e7d6594 11961
50060332
PE
11962 * sound.c (wav_play, au_play, Fplay_sound_internal):
11963 Fix pointer signedness.
d01f234b 11964 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11965 (wav_play): Initialize a variable to 0, to prevent undefined
11966 behavior (Bug#8278).
50060332 11967
c4fc4e30
PE
11968 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11969
918436ed
PE
11970 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11971
c939f91b
PE
11972 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11973 clobbering (Bug#8298).
b9c7f648
PE
11974 * sysdep.c (sys_subshell): Likewise.
11975 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11976
6bd8c144
PE
11977 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11978 This should get cleaned up, so that child_setup has the
11979 same signature on all platforms.
11980
7710357c 11981 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11982 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11983
c59da222
CY
119842011-03-22 Chong Yidong <cyd@stupidchicken.com>
11985
11986 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11987 not to be necessary, and produces flickering.
11988
66b87493
GM
119892011-03-20 Glenn Morris <rgm@gnu.org>
11990
11991 * config.in: Remove file.
11992
45b6f6d5
JB
119932011-03-20 Juanma Barranquero <lekktu@gmail.com>
11994
11995 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11996 are now in src/globals.h.
11997 (syms_of_minibuf): Remove spurious & from previous change.
11998
cd394be1 119992011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12000
12001 * minibuf.c (completing-read-function): New variable.
12002 (completing-read-default): Rename from completing-read.
12003 (completing-read): Call completing-read-function.
12004
b14e3e21
CY
120052011-03-19 Juanma Barranquero <lekktu@gmail.com>
12006
12007 * xfaces.c (Fx_load_color_file):
12008 Read color file from absolute filename (bug#8250).
12009
f2b726e6
JB
120102011-03-19 Juanma Barranquero <lekktu@gmail.com>
12011
12012 * makefile.w32-in: Update dependencies.
12013
09f6ff02
EZ
120142011-03-17 Eli Zaretskii <eliz@gnu.org>
12015
12016 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12017
29a6015a
PE
120182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12019
a3a6c54e
PE
12020 Fix more problems found by GCC 4.5.2's static checks.
12021
b766f867
PE
12022 * process.c (make_serial_process_unwind, send_process_trap):
12023 (sigchld_handler): Now static.
12024
be02381c
PE
12025 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12026 That way, the code declares only the vars that it needs.
12027 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12028 * s/cygwin.h (PTY_ITERATION): Likewise.
12029 * s/darwin.h (PTY_ITERATION): Likewise.
12030 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12031
57048744
PE
12032 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12033 * process.c (allocate_pty): Don't declare stb unless it's needed.
12034
7914961c 12035 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12036 (CONSTANTLIM): Remove; unused.
12037 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12038 Define only if needed.
7914961c 12039
b3967b18
PE
12040 * unexelf.c (unexec): Name an expression,
12041 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12042 Use a different way to cause a compilation error if anyone uses
12043 n rather than nn, a way that does not involve shadowing.
73366a00 12044 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12045
29a6015a
PE
12046 * deps.mk (unexalpha.o): Remove; unused.
12047
43cfc33e 12048 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12049 * unexec.h: New file.
ce701a33
PE
12050 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12051 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12052 Depend on unexec.h.
12053 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12054 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12055 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12056 Change as necessary to match prototype in unexec.h.
ce701a33 12057
01f44d5a
PE
12058 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12059 shadowing.
4f63c6bb 12060 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12061
a6670b0b
PE
12062 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12063 Rename locals to avoid shadowing.
12064
cef2010d 12065 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12066 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12067
d4d7173a
PE
12068 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12069
f08b802a
PE
12070 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12071 warning when compiling print.c.
12072
3ddb0639
PE
12073 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12074 instead of using an uninitialized var.
5ad03b97 12075 (font_sort_entities): Mark var as initialized.
3ddb0639 12076
170a2692
PE
12077 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12078
e663c700
PE
12079 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12080 pointers to constants.
89bc529a 12081 (font_parse_fcname): Remove unused vars.
7b81e2d0 12082 (font_delete_unmatched): Now static.
ea838e10 12083 (font_get_spec): Remove; unused.
13a547c6
PE
12084 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12085 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12086 Rename or move locals to avoid shadowing.
e663c700 12087
2a80c887 12088 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12089 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12090
1384fa33 12091 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12092 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12093
8b2c52e9
PE
12094 * alloc.c (mark_backtrace): Move decl from here ...
12095 * lisp.h: ... to here, so that it can be checked.
12096
475545b5 12097 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12098 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12099 (lisp_indirect_variable): Name an expression,
12100 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12101 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12102
b1349114 12103 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12104 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12105 Use const pointer when appropriate.
b1349114 12106
a2928364
PE
12107 * lisp.h (get_system_name, get_operating_system_release):
12108 Move decls here, to check interfaces.
12109 * process.c (get_operating_system_release): Move decl to lisp.h.
12110 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12111 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12112 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12113 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12114 (Fformat_time_string, Fencode_time, Finsert_char):
12115 (Ftranslate_region_internal, Fformat):
12116 Rename or remove local vars to avoid shadowing.
9710023e 12117 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12118
a415e694
PE
12119 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12120 avoid shadowing.
12121
8ef4622d
PE
12122 * lisp.h (eassert): Check that the argument compiles, even if
12123 ENABLE_CHECKING is not defined.
12124
946f9a5b
PE
12125 * data.c (Findirect_variable): Name an expression, to avoid
12126 gcc -Wbad-function-cast warning.
112396d6 12127 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12128 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12129 (Fmake_variable_buffer_local, Fmake_local_variable):
12130 Mark variables as initialized.
52746918 12131 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12132
e5aab7e7 12133 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12134 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12135 Rename locals to avoid shadowing.
dff45157
PE
12136 (mark_stack): Move local variables into the #ifdef region where
12137 they're used.
7bc26fdb
PE
12138 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12139 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12140 needed otherwise.
12141 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12142 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12143 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12144
e5aab7e7
PE
12145 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12146 avoids undefined behavior in theory.
12147
4da60324
PE
12148 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12149
88043301
PE
12150 Use functions, not macros, for up- and down-casing (Bug#8254).
12151 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12152 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12153 to use the following functions instead of these macros.
12154 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12155 EMACS_INT, since callers assume the returned value fits in int.
12156 (upcase1): Likewise, for UPCASE_TABLE.
12157 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12158 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12159 the race-condition problem in the old DOWNCASE.
88043301 12160
19ed5445
PE
12161 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12162 Rename locals to avoid shadowing.
12163 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12164 (regex_compile, re_search_2, re_match_2_internal):
12165 Remove unused local vars.
952db0d7
PE
12166 (FREE_VAR): Rewrite so as not to use empty "else",
12167 which gcc can warn about.
da053e48 12168 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12169 (RETALLOC_IF): Define only if needed.
12170 (WORDCHAR_P): Likewise. This one is never needed, but is used
12171 only in a comment talking about a compiler bug, so put inside
12172 the #if 0 of that comment.
12173 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12174 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12175 Remove; unused.
19ed5445 12176
1f3561e4 12177 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12178 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12179 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12180
ded6f8f7
PE
12181 * search.c (simple_search): Remove unused var.
12182
dbd37a95
PE
12183 * dired.c (compile_pattern): Move decl from here ...
12184 * lisp.h: ... to here, so that it can be checked.
12185 (struct re_registers): New forward decl.
12186
7e47afad
PE
12187 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12188
85f24f61
PE
12189 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12190 All uses changed.
12191 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12192 Rename locals to avoid shadowing.
5671df8f 12193 (Fvertical_motion): Mark locals as initialized.
85f24f61 12194
181aa2be 12195 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12196 (casify_region): Mark local as initialized.
181aa2be 12197
930d429c
PE
12198 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12199
7082eac6
PE
12200 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12201 New macros, so that the caller can use some names other than
12202 gcpro1, gcpro2, etc.
12203 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12204 of the new macros.
12205 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12206 argument, for consistency with GCPRO2_VAR, etc: it is now the
12207 prefix of the variable, not the variable itself. All uses
12208 changed.
38b2c076
PE
12209 * dired.c (directory_files_internal, file_name_completion):
12210 Rename locals to avoid shadowing.
12211
15206ed9
PE
12212 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12213 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12214 dired.c's scmp function, had undefined behavior.
12215 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12216 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12217 * buffer.h: ... to here, because these macros use current_buffer,
12218 and the new implementation with inline functions needs to have
12219 current_buffer in scope now, rather than later when the macros
12220 are used.
12221 (downcase, upcase1): New static inline functions.
12222 (DOWNCASE, UPCASE1): Reimplement using these functions.
12223 This avoids undefined behavior in expressions like
12224 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12225 from race conditions in accessing the global variables
12226 case_temp1 and case_temp2.
12227 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12228 * lisp.h (case_temp1, case_temp2): Remove their decls.
12229 * character.h (ASCII_CHAR_P): Move from here ...
12230 * lisp.h: ... to here, so that the inline functions mentioned
12231 above can use them.
12232
4a6bea26
PE
12233 * dired.c (directory_files_internal_unwind): Now static.
12234
f14b7e14
PE
12235 * fileio.c (file_name_as_directory, directory_file_name):
12236 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12237 Now static.
2893f146
PE
12238 (file_name_as_directory): Use const pointers when appropriate.
12239 (Fexpand_file_name): Likewise. In particular, newdir might
12240 point at constant storage, so make it a const pointer.
fd4ead52 12241 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12242 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12243 signedness issues.
f839df0c
PE
12244 (Fset_file_times, Finsert_file_contents, auto_save_error):
12245 Rename locals to avoid shadowing.
f14b7e14 12246
5716756e 12247 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12248 (Ftry_completion, Fall_completions): Rename or remove locals
12249 to avoid shadowing.
5716756e 12250
b4c3046a
PE
12251 * marker.c (bytepos_to_charpos): Remove; unused.
12252
b45db522
PE
12253 * lisp.h (verify_bytepos, count_markers): New decls,
12254 so that gcc does not warn that these functions aren't declared.
12255
85876d07
PE
12256 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12257 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12258 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12259 (copy_text): Remove unused local var.
85876d07 12260
03d78a21 12261 * filelock.c (within_one_second): Now static.
b3dd38ab 12262 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12263
5df8f01b
PE
12264 * buffer.c (fix_overlays_before): Mark locals as initialized.
12265 (fix_start_end_in_overlays): Likewise. This function should be
12266 simplified by using pointers-to-pointers, but that's a different
12267 matter.
b1d876f1 12268 (switch_to_buffer_1): Now static.
8f54f30a
PE
12269 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12270 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12271
a70072c9 12272 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12273 Fix pointer signedness issue.
edced198
PE
12274 (sys_subshell): Mark local as volatile if checking for lint,
12275 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12276 (MAXPATHLEN): Define only if needed.
a70072c9 12277
a0977c44
PE
12278 * process.c (serial_open, serial_configure): Move decls from here ...
12279 * systty.h: ... to here, so that they can be checked.
12280
a884fdcc
PE
12281 * fns.c (get_random, seed_random): Move extern decls from here ...
12282 * lisp.h: ... to here, so that they can be checked.
12283
604efe86 12284 * sysdep.c (reset_io): Now static.
b8950c94 12285 (wait_for_termination_signal): Remove; unused.
604efe86 12286
38fc62d9
PE
12287 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12288 (copy_keymap_item, append_key, push_text_char_description):
12289 Now static.
1004a21a 12290 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12291 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12292 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12293 (describe_map_tree):
12294 Rename locals to avoid shadowing.
38fc62d9 12295
2f2650da
PE
12296 * keyboard.c: Declare functions static if they are not used elsewhere.
12297 (echo_char, echo_dash, cmd_error, top_level_2):
12298 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12299 (read_char, kbd_buffer_get_event, make_lispy_position):
12300 (make_lispy_event, make_lispy_movement, apply_modifiers):
12301 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12302 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12303 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12304 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12305 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12306
a053e86c 12307 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12308 (mark_kboards): Move decl here ...
12309 * alloc.c (mark_kboards): ... from here.
a053e86c 12310
4752793e
PE
12311 * lisp.h (force_auto_save_soon): New decl.
12312
74f10ca7 12313 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12314 (DEFINE_DUMMY_FUNCTION): New macro.
12315 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12316 Use it.
c03cd23f
PE
12317 (main): Add casts to avoid warnings
12318 if GCC considers string literals to be constants.
74f10ca7 12319
022e70d4
PE
12320 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12321
59d6fe83
PE
12322 * dbusbind.c: Pointer signedness fixes.
12323 (xd_signature, xd_append_arg, xd_initialize):
12324 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12325 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12326 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12327 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12328
78320123
PE
12329 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12330 if GCC considers string literals to be constants.
49cebcca 12331 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12332
35ac2a97
SM
123332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12334
fb103ca9
SM
12335 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12336 (print_preprocess, print_object): New macro to fix last change.
12337
35ac2a97
SM
12338 * print.c (print_preprocess): Don't forget font objects.
12339
62973b41
JB
123402011-03-16 Juanma Barranquero <lekktu@gmail.com>
12341
12342 * emacs.c (USAGE3): Doc fixes.
12343
0e48bb22
AS
123442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12345
12346 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12347 structure.
12348
7684e57b
JB
123492011-03-14 Juanma Barranquero <lekktu@gmail.com>
12350
12351 * lisp.h (VWindow_system, Qfile_name_history):
12352 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12353 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12354 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12355
12356 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12357 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12358
12359 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12360 * w32console.c (detect_input_pending, read_input_pending)
12361 (encode_terminal_code):
12362 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12363 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12364 (w32_system_caret_y, Qfile_name_history):
12365 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12366 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12367 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12368 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12369 * w32proc.c (Qlocal, report_file_error):
12370 * w32term.c (Vwindow_system, updating_frame):
12371 * w32uniscribe.c (initialized, uniscribe_font_driver):
12372 Remove unneeded extern declarations.
12373
2aa46d6c
CY
123742011-03-14 Chong Yidong <cyd@stupidchicken.com>
12375
c96bbc66 12376 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12377
cffc6f3b
CY
123782011-03-13 Chong Yidong <cyd@stupidchicken.com>
12379
12380 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12381 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12382 These macros can no longer be used for assignment.
12383
44f230aa
SM
12384 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12385 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12386 (record_buffer_markers, fetch_buffer_markers): New functions for
12387 recording and fetching special buffer markers.
12388 (set_buffer_internal_1, set_buffer_temp): Use them.
12389
12390 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12391
12392 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12393
12394 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12395 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12396
12397 * xdisp.c (hscroll_window_tree):
12398 (reconsider_clip_changes): Use PT instead of BUF_PT.
12399
d251f04b
EZ
124002011-03-13 Eli Zaretskii <eliz@gnu.org>
12401
12402 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12403 $(EMACS_ROOT)/lib/intprops.h.
12404
f0c77cd1
PE
124052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12406
3eca4629
PE
12407 Fix more problems found by GCC 4.5.2's static checks.
12408
7c86ee98
PE
12409 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12410 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12411 (xg_free_frame_widgets): Make it clear that a local variable is
12412 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12413 (gdk_window_get_screen): Make it clear that this macro is needed
12414 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12415 (int_gtk_range_get_value): New function, which avoids a diagnostic
12416 from gcc -Wbad-function-cast.
12417 (xg_set_toolkit_scroll_bar_thumb): Use it.
12418 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12419 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12420 (get_utf8_string, xg_get_file_with_chooser):
12421 Rename locals to avoid shadowing.
12422 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12423
41729b81
PE
12424 * xgselect.c (xg_select): Remove unused var.
12425
f0c77cd1
PE
12426 * image.c (four_corners_best): Mark locals as initialized.
12427 (gif_load): Initialize transparent_p to zero (Bug#8238).
12428 Mark another local as initialized.
ec6cf4c6 12429 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12430
ce0ad53d 12431 * image.c (clear_image_cache): Now static.
d5d5a617 12432 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12433 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12434 (x_edge_detection): Remove unnecessary cast that
12435 gcc -Wbad-function-cast diagnoses.
2037898d 12436 (gif_load): Fix pointer signedness.
6ae141d6
PE
12437 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12438 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12439
33383987 124402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12441
d32df629
PE
12442 Improve quality of tests for time stamp overflow.
12443 For example, without this patch (encode-time 0 0 0 1 1
12444 1152921504606846976) returns the obviously-bogus value (-948597
12445 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12446 reports time overflow. See
12447 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12448 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12449 * editfns.c: Include limits.h and intprops.h.
12450 (TIME_T_MIN, TIME_T_MAX): New macros.
12451 (time_overflow): Move earlier, to before first use.
12452 (hi_time, lo_time): New functions, for an accurate test for
12453 out-of-range times.
12454 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12455 (Fget_internal_run_time): Don't assume time_t fits in int.
12456 (make_time): Use list2 instead of Fcons twice.
12457 (Fdecode_time): More accurate test for out-of-range times.
12458 (check_tm_member): New function.
12459 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12460 (lisp_time_argument): Don't rely on undefined left-shift and
12461 right-shift behavior when checking for time stamp overflow.
8be6f318 12462
fe31d94c
PE
12463 * editfns.c (time_overflow): New function, refactoring common code.
12464 (Fformat_time_string, Fdecode_time, Fencode_time):
12465 (Fcurrent_time_string): Use it.
12466
8be6f318
PE
12467 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12468 * dired.c (make_time): Move to ...
12469 * editfns.c (make_time): ... here.
12470 * systime.h: Note the move.
12471
09d9db2c 124722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12473
126bc0dc
YM
12474 * fringe.c (update_window_fringes): Remove unused variables.
12475
c47cbdfd
YM
12476 * unexmacosx.c (copy_data_segment): Also copy __got section.
12477 (Bug#8223)
12478
7ac80be9
EZ
124792011-03-12 Eli Zaretskii <eliz@gnu.org>
12480
c96bbc66 12481 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12482 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12483 Constify `char *' arguments and their references according to
12484 prototypes in tparam.h.
12485
ecb0f94d 12486 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12487
7ac80be9
EZ
12488 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12489 Adapt all references accordingly.
12490
12491 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12492
ef1fd07e
TT
124932011-03-11 Tom Tromey <tromey@redhat.com>
12494
12495 * buffer.c (syms_of_buffer): Remove obsolete comment.
12496
7ef4b50c
EZ
124972011-03-11 Eli Zaretskii <eliz@gnu.org>
12498
12499 * termhooks.h (encode_terminal_code): Declare prototype.
12500
12501 * msdos.c (encode_terminal_code): Don't declare prototype.
12502
12503 * term.c (encode_terminal_code): Now external again, used by
12504 w32console.c and msdos.c.
12505
44f230aa
SM
12506 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12507 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12508
4b1ec863 125092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12510
1714f52b 12511 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12512
4b1ec863
PE
12513 * fringe.c (update_window_fringes): Mark locals as initialized
12514 (Bug#8227).
12515 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12516
524c7aa6
PE
12517 * alloc.c (mark_fringe_data): Move decl from here ...
12518 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12519 to check its interface.
12520 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12521
a5c0af81 12522 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12523 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12524 (fontset_font): Mark local as initialized.
a9a06e0b 12525 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12526
b4716021
PE
12527 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12528
811e9bac 12529 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12530 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12531 (x_own_selection, Fx_disown_selection_internal): Rename locals
12532 to avoid shadowing.
12533 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12534
7e3ab302
PE
12535 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12536 so that the caller can use some name other than gcpro1.
12537 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12538 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12539 (Fx_backspace_delete_keys_p):
12540 Use them to avoid shadowing, and rename vars to avoid shadowing.
12541 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12542 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12543 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12544 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12545 Remove unused locals.
7e3ab302
PE
12546 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12547 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12548 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12549 macros.
f78faa98 12550
e2b13473
PE
12551 * xterm.h (x_mouse_leave): New decl.
12552
77f23912
PE
12553 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12554 Remove unused functions.
cdf4ba58
PE
12555 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12556 (x_calc_absolute_position): Now static.
7411c686 12557 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12558 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12559 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12560 unless they are used.
38d0b34a
PE
12561 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12562 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12563 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12564 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12565 (x_error_catcher, x_connection_closed, x_error_handler):
12566 (x_error_quitter, xembed_send_message, x_iconify_frame):
12567 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12568 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12569 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12570
44f230aa
SM
12571 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12572 Rename or move locals to avoid shadowing.
6b463e58 12573 (tty_defined_color, merge_face_heights): Now static.
5967d051 12574 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12575 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12576 does not deduce is never used uninitialized.
73719eba
PE
12577 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12578 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12579
426994c3 12580 * terminal.c (store_terminal_param): Now static.
5489860b 12581
032f1620 12582 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12583 (set_frame_menubar): Remove unused local.
d4323972 12584 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12585 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12586 since they might point to immutable storage.
281585b0
PE
12587 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12588 since it's unused otherwise.
032f1620 12589
367c19e5 12590 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12591 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12592 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12593 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12594 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12595 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12596 does not deduce are never used uninitialized.
70739cbe 12597
07b48fa9
PE
12598 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12599
8868a238 12600 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12601 * window.c (window_loop, size_window):
12602 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12603
7e5cf297 12604 * window.c (display_buffer): Now static.
d6550a9f
PE
12605 (size_window): Mark variables that gcc -Wuninitialized
12606 does not deduce are never used uninitialized.
a586633d
PE
12607 * window.h (check_all_windows): New decl, to forestall
12608 gcc -Wmissing-prototypes diagnostic.
5b555da1 12609 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12610
f6095868
PE
12611 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12612 shadowing.
12613 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12614 Include <limits.h>.
12615 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12616 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12617 (load_charset_map): Mark variables that gcc -Wuninitialized
12618 does not deduce are never used uninitialized.
53df7c11 12619 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12620
f38b440c
PE
12621 * coding.c (coding_set_source, coding_set_destination):
12622 Use "else { /* comment */ }" rather than "else /* comment */;"
12623 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12624 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12625 a block, when the outer 'i' will do.
12626 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12627 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12628 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12629 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12630 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12631 Rename locals to avoid shadowing.
12632 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12633 * coding.c (emacs_mule_char, encode_invocation_designation):
12634 Now static, since they're not used elsewhere.
413bb2db 12635 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12636 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12637 (decode_coding_emacs_mule): Mark variables that gcc
12638 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12639 (detect_coding_iso_2022): Initialize a local variable that might
12640 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12641 this initialization is needed. (Bug#8211)
5f58e762
PE
12642 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12643 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12644 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12645 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12646 Remove unused macros.
f38b440c 12647
232b38b9 12648 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12649 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12650 * character.c (string_count_byte8): Likewise.
232b38b9 12651
fb90da1b
PE
12652 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12653 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12654
fb93dbc2
PE
12655 * chartab.c (copy_sub_char_table): Now static, since it's not used
12656 elsewhere.
5c156ace
PE
12657 (sub_char_table_ref_and_range, char_table_ref_and_range):
12658 Rename locals to avoid shadowing.
bbcd0949 12659 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12660
7d3b3862 12661 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12662 (BIDI_BOB): Remove unused macro.
7d3b3862 12663
6be7d3da
PE
12664 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12665 deduce are never used uninitialized.
c2ed9c8b 12666 * term.c (encode_terminal_code): Likewise.
6be7d3da 12667
75f8807f 12668 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12669
50938595
PE
12670 * tparam.h: New file.
12671 * term.c, tparam.h: Include it.
12672 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12673 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12674 Move these decls to tparam.h, and make them agree with what
12675 is actually in tparam.c. The previous trick of using incompatible
12676 decls in different modules does not conform to the C standard.
12677 All callers of tparam changed to use tparam's actual API.
12678 * tparam.c (tparam1, tparam, tgoto):
12679 Use const pointers where appropriate.
12680
fbceeba2
PE
12681 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12682 * cm.h (struct cm): Likewise.
12683 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12684 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12685 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12686 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12687 (turn_on_face, init_tty): Likewise.
12688 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12689
7f3f1250
PE
12690 * term.c (term_mouse_position): Rename local to avoid shadowing.
12691
e6ca6543
PE
12692 * alloc.c (mark_ttys): Move decl from here ...
12693 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12694
c40f8d15
AS
126952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12696
12697 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12698
cfe0661d
JB
126992011-03-09 Juanma Barranquero <lekktu@gmail.com>
12700
12701 * search.c (compile_pattern_1): Remove argument regp, unused since
12702 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12703 (compile_pattern): Don't pass it.
12704
0afb4571
J
127052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12706
12707 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12708 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12709 for ! HAVE_GTK3.
12710 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12711
12712 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12713
12714 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12715 gdk_window_get_screen, gdk_window_get_geometry,
12716 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12717 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12718 (xg_get_pixbuf_from_pixmap): New function.
12719 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12720 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12721 Call xg_get_pixbuf_from_pixmap instead of
12722 gdk_pixbuf_get_from_drawable.
12723 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12724 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12725 (xg_check_special_colors): Use GtkStyleContext and its functions
12726 for HAVE_GTK3.
12727 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12728 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12729 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12730 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12731 Call gtk_widget_get_preferred_size.
0afb4571
J
12732 (xg_frame_resized): gdk_window_get_geometry only takes 5
12733 parameters.
44f230aa
SM
12734 (xg_win_to_widget, xg_event_is_for_menubar):
12735 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12736 (xg_set_widget_bg): New function.
12737 (delete_cb): New function.
895009e1 12738 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12739 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12740 (xg_set_background_color): Call xg_set_widget_bg.
12741 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12742 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12743 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12744 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12745 if ! HAVE_GTK3.
12746 (update_frame_tool_bar): Call gtk_widget_hide.
12747 (xg_initialize): Use GDK_KEY_g.
12748
12749 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12750 if ! HAVE_GTK3
12751 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12752
12753 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12754 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12755 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12756
1c2cc4ef
JB
127572011-03-08 Juanma Barranquero <lekktu@gmail.com>
12758
12759 * w32xfns.c (select_palette): Check success of RealizePalette against
12760 GDI_ERROR, not zero.
12761
33383987 12762See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12763
12764;; Local Variables:
12765;; coding: utf-8
aac0c6e3
MR
12766;; End:
12767
2f097256 12768 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12769
12770 This file is part of GNU Emacs.
12771
12772 GNU Emacs is free software: you can redistribute it and/or modify
12773 it under the terms of the GNU General Public License as published by
12774 the Free Software Foundation, either version 3 of the License, or
12775 (at your option) any later version.
12776
12777 GNU Emacs is distributed in the hope that it will be useful,
12778 but WITHOUT ANY WARRANTY; without even the implied warranty of
12779 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12780 GNU General Public License for more details.
12781
12782 You should have received a copy of the GNU General Public License
12783 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.