* net/tramp.el (tramp-debug-message): Add `tramp-with-progress-reporter'
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6198ccd0
MR
12011-06-11 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (delete_deletable_window): Re-add.
4 (Fset_window_configuration): Rewrite to handle dead buffers and
5 consequently deletable windows.
6 (window_tree, Fwindow_tree): Remove. Supply functionality in
7 window.el.
8 (compare_window_configurations): Simplify code.
9
b6e3633c
AS
102011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11
1ab0dee5
AS
12 * image.c (imagemagick_load_image): Fix type mismatch.
13 (Fimagemagick_types): Likewise.
14
b6e3633c
AS
15 * window.h (replace_buffer_in_windows): Declare.
16
9397e56f
MR
172011-06-11 Martin Rudalics <rudalics@gmx.at>
18
19 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
20 Qclone_number. Remove external declaration of Qdelete_window.
21 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
22 code.
23 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
24 Qbuffer_list_update_hook if allowed.
25 (Fother_buffer): Rewrite doc-string. Major rewrite for new
26 buffer list implementation.
27 (other_buffer_safely): New function.
28 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
29 calls to replace_buffer_in_windows and
30 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
31 if allowed.
32 (record_buffer): Inhibit quitting and rewrite using quittable
33 functions. Run Qbuffer_list_update_hook if allowed.
34 (Frecord_buffer, Funrecord_buffer): New functions.
35 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
36 switch-to-buffer to window.el.
37 (bury-buffer): Move to window.el.
38 (Vbuffer_list_update_hook): New variable.
39
40 * lisp.h (other_buffer_safely): Add prototype in buffer.c
41 section.
42
43 * window.h (resize_frame_windows): Move up in code.
44 (Fwindow_frame): Remove EXFUN.
45 (replace_buffer_in_all_windows): Remove prototype.
46 (replace_buffer_in_windows_safely): Add prototype.
47
48 * window.c: Declare Qdelete_window static again. Move down
49 declaration of select_count.
50 (Fnext_window, Fprevious_window): Rewrite doc-strings.
51 (Fother_window): Move to window.el.
52 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
53 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
54 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
55 window.el.
56 (replace_buffer_in_windows): Implement by calling
57 Qreplace_buffer_in_windows.
58 (replace_buffer_in_all_windows): Remove with some functionality
59 moved into replace_buffer_in_windows_safely.
60 (replace_buffer_in_windows_safely): New function.
61 (select_window_norecord, select_frame_norecord): Move in front
62 of run_window_configuration_change_hook. Remove now obsolete
63 declarations.
64 (Fset_window_buffer): Rewrite doc-string. Call
65 Qrecord_window_buffer.
66 (keys_of_window): Move binding for other-window to window.el.
67
b50691aa
CY
682011-06-11 Chong Yidong <cyd@stupidchicken.com>
69
70 * dispextern.h (struct image): Replace data member, whose int_val
71 and ptr_val fields were not used by anything, with a single
72 lisp_val object.
73
74 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
75 (gif_clear_image, gif_load, imagemagick_load_image)
76 (gs_clear_image, gs_load): Callers changed.
77
3f754b86
PE
782011-06-10 Paul Eggert <eggert@cs.ucla.edu>
79
cca69397
PE
80 * buffer.h: Include <time.h>, for time_t.
81 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
82
109e28d0
PE
83 Fix minor problems found by static checking.
84
60737f02
PE
85 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
86
4b66faf3
PE
87 Make identifiers static if they are not used in other modules.
88 * data.c (Qcompiled_function, Qframe, Qvector):
89 * image.c (QimageMagick, Qsvg):
90 * minibuf.c (Qmetadata):
91 * window.c (resize_window_check, resize_root_window): Now static.
92 * window.h (resize_window_check, resize_root_window): Remove decls.
93
109e28d0
PE
94 * window.c (window_deletion_count, delete_deletable_window):
95 Remove; unused.
46a4ce9e
PE
96 (window_body_lines): Now static.
97 (Fdelete_other_windows_internal): Mark vars as initialized.
98 Make sure 'resize_failed' is initialized.
99 (run_window_configuration_change_hook): Rename local to avoid shadowing.
100 (resize_window_apply): Remove unused local.
101 * window.h (delete_deletable_window): Remove decl.
102
109e28d0 103 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
104 (imagemagick_load_image): Fix pointer signedness problem by changing
105 last arg from unsigned char * to char *. All uses changed.
106 Also, fix a local for similar reasons.
107 Remove unused locals. Remove locals to avoid shadowing.
108 (fn_rsvg_handle_free): Remove; unused.
109 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 110 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 111
3f754b86
PE
112 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
113
2547adb1
CY
1142011-06-10 Chong Yidong <cyd@stupidchicken.com>
115
116 * image.c (gif_load): Fix omitted cast error introduced by
117 2011-06-06 change.
118
2c8e37d4
MR
1192011-06-10 Martin Rudalics <rudalics@gmx.at>
120
121 * window.h (resize_proportionally, orig_total_lines)
122 (orig_top_line): Remove from window structure.
123 (set_window_height, set_window_width, change_window_heights)
124 (Fdelete_window): Remove prototypes.
125 (resize_frame_windows): Remove duplicate declaration.
126
440a42e3
EZ
1272011-06-10 Eli Zaretskii <eliz@gnu.org>
128
129 * window.h (resize_frame_windows, resize_window_check)
130 (delete_deletable_window, resize_root_window)
131 (resize_frame_windows): Declare prototypes.
132
133 * window.c (resize_window_apply): Make definition be "static" to
134 match the prototype.
135
562dd5e9
MR
1362011-06-10 Martin Rudalics <rudalics@gmx.at>
137
138 * window.c: Remove declarations of Qwindow_size_fixed,
139 window_min_size_1, window_min_size_2, window_min_size,
140 size_window, window_fixed_size_p, enlarge_window, delete_window.
141 Remove static from declaration of Qdelete_window, it's
142 temporarily needed by Fbury_buffer.
143 (replace_window): Don't assign orig_top_line and
144 orig_total_lines.
145 (Fdelete_window, delete_window): Remove. Window deletion is
146 handled by window.el.
147 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
148 Fdelete_window calls with calls to Qdelete_window.
149 (Fdelete_other_windows): Remove. Deleting other windows is
150 handled by window.el.
151 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
152 handled in window.el.
153 (window_min_size_2, window_min_size_1, window_min_size): Remove.
154 Window minimum sizes are handled in window.el.
155 (shrink_windows, size_window, set_window_height)
156 (set_window_width, change_window_heights, window_height)
157 (window_width, CURBEG, CURSIZE, enlarge_window)
158 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
159 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
160 handled in window.el.
161 (make_dummy_parent): Rename to make_parent_window and give it a
162 second argument horflag.
163 (make_window): Don't set resize_proportionally any more.
164 (Fsplit_window): Remove. Windows are split in window.el.
165 (save_restore_action, save_restore_orig_size)
166 (shrink_window_lowest_first, save_restore_orig_size): Remove.
167 Resize mini windows in window.el.
168 (grow_mini_window, shrink_mini_window): Implement by calling
169 Qresize_root_window_vertically, resize_window_check and
170 resize_window_apply.
171 (saved_window, Fset_window_configuration, save_window_save): Do
172 not handle orig_top_line, orig_total_lines, and
173 resize_proportionally.
174 (window_min_height, window_min_width): Move to window.el.
175 (keys_of_window): Move bindings for delete-other-windows,
176 split-window, delete-window and enlarge-window to window.el.
177
178 * buffer.c: Temporarily extern Qdelete_window.
179 (Fbury_buffer): Temporarily call Qdelete_window instead of
180 Fdelete_window (Fbury_buffer will move to window.el soon).
181
182 * frame.c (set_menu_bar_lines_1): Remove code handling
183 orig_top_line and orig_total_lines.
184
185 * dispnew.c (adjust_frame_glyphs_initially): Don't use
186 set_window_height but set heights directly.
187 (change_frame_size_1): Use resize_frame_windows.
188
189 * xdisp.c (init_xdisp): Don't use set_window_height but set
190 heights directly.
191
192 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
193 resize_frame_windows instead of change_window_heights and run
194 run_window_configuration_change_hook.
195
196 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
197 instead of change_window_heights and run
198 run_window_configuration_change_hook.
199
1a13852e
MR
2002011-06-09 Martin Rudalics <rudalics@gmx.at>
201
202 * window.c (replace_window): Rename second argument REPLACEMENT to
203 NEW. New third argument SETFLAG. Rewrite.
204 (delete_window, make_dummy_parent): Call replace_window with
205 third argument 1.
206 (window_list_1): Move down in code.
207 (run_window_configuration_change_hook): Move set_buffer part
208 before select_frame_norecord part in order to unwind correctly.
209 Rename count1 to count.
210 (recombine_windows, delete_deletable_window, resize_root_window)
211 (Fdelete_other_windows_internal)
212 (Frun_window_configuration_change_hook, make_parent_window)
213 (resize_window_check, resize_window_apply, Fresize_window_apply)
214 (resize_frame_windows, Fsplit_window_internal)
215 (Fdelete_window_internal, Fresize_mini_window_internal): New
216 functions.
217 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
218
f3d1777e
MR
2192011-06-08 Martin Rudalics <rudalics@gmx.at>
220
496e208e
MR
221 * window.h (window): Add some new members to window structure -
222 normal_lines, normal_cols, new_total, new_normal, clone_number,
223 splits, nest, prev_buffers, next_buffers.
224 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 225 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 226
f3d1777e
MR
227 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
228 Remove.
496e208e
MR
229 (make_dummy_parent): Set new members of windows structure.
230 (make_window): Move down in code. Handle new members of window
231 structure.
232 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
233 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
234 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
235 (Fset_window_prev_buffers, Fwindow_next_buffers)
236 (Fset_window_next_buffers, Fset_window_clone_number): New
237 functions.
238 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
239 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
240 Doc-string fixes.
241 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
242 Argument WINDOW can be now internal window too.
243 (Fwindow_use_time): Move up in code.
244 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
245 Rewrite doc-string.
246 (Fset_window_configuration, saved_window)
247 (Fcurrent_window_configuration, save_window_save): Handle new
248 members of window structure.
b9e809c2
MR
249 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
250 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
251 (syms_of_window): New Lisp objects Qrecord_window_buffer,
252 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
253 Qget_mru_window, Qresize_root_window,
254 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
255 Qauto_buffer_name; staticpro them.
f3d1777e 256
abde8f8c
MR
2572011-06-07 Martin Rudalics <rudalics@gmx.at>
258
259 * window.c (Fwindow_total_size, Fwindow_left_column)
260 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
261 (Fwindow_list_1): New functions.
262 (window_box_text_cols): Replace with window_body_cols.
263 (Fwindow_width, Fscroll_left, Fscroll_right): Use
264 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
265 (delete_window, Fset_window_configuration): Call
266 delete_all_subwindows with window as argument.
267 (delete_all_subwindows): Take a window as argument and not a
268 structure. Rewrite.
190b47e6
MR
269 (window_loop): Remove handling of GET_LRU_WINDOW and
270 GET_LARGEST_WINDOW.
271 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
272
273 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
274 window_box_text_cols. delete_all_subwindows now takes a
275 Lisp_Object as argument.
abde8f8c
MR
276
277 * indent.c (compute_motion, Fcompute_motion): Use
278 window_body_cols instead of window_box_text_cols.
279
fa8a67e6
MR
280 * frame.c (delete_frame): Call delete_all_subwindows with root
281 window as argument.
282
a54e3482
DC
2832011-06-07 Daniel Colascione <dan.colascione@gmail.com>
284
285 * fns.c (Fputhash): Document return value.
286
60002bf5
CY
2872011-06-06 Chong Yidong <cyd@stupidchicken.com>
288
289 * image.c (gif_load): Implement gif89a spec "no disposal" method.
290
0c671da6 2912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 292
b862a52a 293 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 294
be44ca6c
PE
295 Check for overflow when converting integer to cons and back.
296 * charset.c (Fdefine_charset_internal, Fdecode_char):
297 Use cons_to_unsigned to catch overflow.
298 (Fencode_char): Use INTEGER_TO_CONS.
299 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
300 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
301 * data.c (long_to_cons, cons_to_long): Remove.
302 (cons_to_unsigned, cons_to_signed): New functions.
303 These signal an error for invalid or out-of-range values.
304 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
305 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
306 * font.c (Ffont_variation_glyphs):
307 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
308 * lisp.h: Include <intprops.h>.
309 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
310 (cons_to_signed, cons_to_unsigned): New decls.
311 (long_to_cons, cons_to_long): Remove decls.
312 * undo.c (record_first_change): Use INTEGER_TO_CONS.
313 (Fprimitive_undo): Use CONS_TO_INTEGER.
314 * xfns.c (Fx_window_property): Likewise.
315 * xselect.c: Include <limits.h>.
316 (x_own_selection, selection_data_to_lisp_data):
317 Use INTEGER_TO_CONS.
318 (x_handle_selection_request, x_handle_selection_clear)
319 (x_get_foreign_selection, Fx_disown_selection_internal)
320 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
321 (lisp_data_to_selection_data): Use cons_to_unsigned.
322 (x_fill_property_data): Use cons_to_signed.
323 Report values out of range.
324
d1f3d2af
PE
325 Check for buffer and string overflow more precisely.
326 * buffer.h (BUF_BYTES_MAX): New macro.
327 * lisp.h (STRING_BYTES_MAX): New macro.
328 * alloc.c (Fmake_string):
329 * character.c (string_escape_byte8):
330 * coding.c (coding_alloc_by_realloc):
331 * doprnt.c (doprnt):
332 * editfns.c (Fformat):
333 * eval.c (verror):
334 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
335 since they may not be the same number.
336 * editfns.c (Finsert_char):
337 * fileio.c (Finsert_file_contents):
338 Likewise for BUF_BYTES_MAX.
339
dd52fcea
PE
340 * image.c: Use ptrdiff_t, not int, for sizes.
341 (slurp_file): Switch from int to ptrdiff_t.
342 All uses changed.
343 (slurp_file): Check that file size fits in both size_t (for
344 malloc) and ptrdiff_t (for sanity and safety).
345
7f9bbdbb
PE
346 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
347 if b->modtime has its maximal value.
348
dfe18f82
PE
349 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
350
84acfcf0
PE
351 Don't assume time_t can fit into int.
352 * buffer.h (struct buffer.modtime): Now time_t, not int.
353 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
354 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
355
ccd9a01a
PE
356 Minor fixes for signed vs unsigned integers.
357 * character.h (MAYBE_UNIFY_CHAR):
358 * charset.c (maybe_unify_char):
359 * keyboard.c (read_char, reorder_modifiers):
360 XINT -> XFASTINT, since the integer must be nonnegative.
361 * ftfont.c (ftfont_spec_pattern):
362 * keymap.c (access_keymap, silly_event_symbol_error):
363 XUINT -> XFASTINT, since the integer must be nonnegative.
364 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
365 since it makes no difference and we prefer signed.
366 * keyboard.c (record_char): Use XUINT when all the neighbors do.
367 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
368 nonnegative.
369
d6d100dd
SM
3702011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
371
372 * window.h (Fwindow_frame): Declare.
373
2b6148e4
PE
3742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
375
376 * alloc.c: Simplify handling of large-request failures (Bug#8800).
377 (SPARE_MEMORY): Always define.
378 (LARGE_REQUEST): Remove.
379 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
380
f230ecc9
MR
3812011-06-06 Martin Rudalics <rudalics@gmx.at>
382
727e958e
MR
383 * lisp.h: Move EXFUNS for Fframe_root_window,
384 Fframe_first_window and Fset_frame_selected_window to window.h.
385
386 * window.h: Move EXFUNS for Fframe_root_window,
387 Fframe_first_window and Fset_frame_selected_window here from
388 lisp.h.
389
390 * frame.c (Fwindow_frame, Fframe_first_window)
391 (Fframe_root_window, Fframe_selected_window)
392 (Fset_frame_selected_window): Move to window.c.
393 (Factive_minibuffer_window): Move to minibuf.c.
394 (Fother_visible_frames_p): New function.
395
396 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
397
f230ecc9
MR
398 * window.c (decode_window, decode_any_window): Move up in code.
399 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
400 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
401 (Fwindow_buffer): Move up and rewrite doc-string.
402 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
403 (Fwindow_prev): New functions.
727e958e
MR
404 (Fwindow_frame): Move here from frame.c. Accept any window as
405 argument.
406 (Fframe_root_window, Fframe_first_window)
407 (Fframe_selected_window): Move here from frame.c. Accept frame
408 or arbitrary window as argument. Update doc-strings.
409 (Fminibuffer_window): Move up in code.
410 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
411 (Fset_frame_selected_window): Move here from frame.c.
412 Marginal rewrite.
727e958e
MR
413 (Fselected_window, select_window, Fselect_window): Move up in
414 code. Minor doc-string fixes.
f230ecc9 415
4d09bcf6
PE
4162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
417
418 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
419 Do not assume that spare memory exists; that assumption is valid
420 only if SYSTEM_MALLOC.
421 (LARGE_REQUEST): New macro, so that the issue of large requests
422 is separated from the issue of spare memory.
423
810928a2
AS
4242011-06-05 Andreas Schwab <schwab@linux-m68k.org>
425
172418ad
AS
426 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
427 format. (Bug#8806)
428
43f862f7
AS
429 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
430
810928a2
AS
431 * xfns.c (x_set_scroll_bar_default_width): Move declarations
432 before statements.
433
a059fe24
JD
4342011-06-05 Jan Djärv <jan.h.d@swipnet.se>
435
436 * gtkutil.c (xg_get_default_scrollbar_width): New function.
437
438 * gtkutil.h: Declare xg_get_default_scrollbar_width.
439
440 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
441 min width by calling x_set_scroll_bar_default_width (Bug#8505).
442
989bf368
JB
4432011-06-05 Juanma Barranquero <lekktu@gmail.com>
444
445 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
446
4b80f674
CY
4472011-06-04 Chong Yidong <cyd@stupidchicken.com>
448
449 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
450 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
451 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
452 New error handlers.
4b80f674
CY
453 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
454 Obey Vx_select_enable_clipboard_manager. Catch errors in
455 x_clipboard_manager_save (Bug#8779).
456 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 457 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 458
99a33b77 4592011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
460
461 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
462
99a33b77 4632011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
464
465 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
466 in the current matrix if keep_current_p is non-zero.
467
8264569d
EZ
4682011-06-04 Eli Zaretskii <eliz@gnu.org>
469
470 * bidi.c (bidi_level_of_next_char): Fix last change.
471
57f97249
EZ
4722011-06-03 Eli Zaretskii <eliz@gnu.org>
473
fec2107c 474 Support bidi reordering of text covered by display properties.
57f97249 475
fec2107c
EZ
476 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
477 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
478 (bidi_cache_search, bidi_cache_iterator_state)
479 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
480 (bidi_level_of_next_char, bidi_move_to_visually_next):
481 Support character positions inside a run of characters covered by a
fec2107c
EZ
482 display string.
483 (bidi_paragraph_init, bidi_resolve_explicit_1)
484 (bidi_level_of_next_char): Call bidi_fetch_char and
485 bidi_fetch_char_advance instead of FETCH_CHAR and
486 FETCH_CHAR_ADVANCE.
487 (bidi_init_it): Initialize new members.
488 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
489 definitions.
490 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
491 instead of using explicit *_CHAR codes.
d6d100dd
SM
492 (bidi_resolve_explicit, bidi_resolve_weak):
493 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
494 bidirectional text is supported only in multibyte buffers.
495 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
496 it to initialize the frame_window_p member of struct bidi_it.
497 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
498 (bidi_resolve_explicit, bidi_resolve_weak)
499 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
500 bidi_it->nchars is non-positive.
501 (bidi_level_of_next_char): Don't try to lookup the cache for the
502 next/previous character if nothing is cached there yet, or if we
503 were just reseat()'ed to a new position.
c40e2fb2 504
0e14fe90
EZ
505 * xdisp.c (set_cursor_from_row): Set start and stop points
506 according to the row's direction when priming the loop that looks
507 for the glyph on which to display cursor.
508 (single_display_spec_intangible_p): Function deleted.
509 (display_prop_intangible_p): Reimplement to call
510 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
511 Accept 3 additional arguments needed by handle_display_spec.
512 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
513 values: lists, `(when COND...)' forms, etc.
514 (single_display_spec_string_p): Support property values that are
515 lists with the argument STRING its top-level element.
516 (display_prop_string_p): Fix the condition for processing a
517 property that is a list to be consistent with handle_display_spec.
fec2107c 518 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
519 last portion of handle_display_prop.
520 (compute_display_string_pos): Accept additional argument
521 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
522 value of a `display' property is a "replacing spec".
523 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
524 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
525 the display property, but just return a value indicating whether
526 the display property will replace the characters it covers.
527 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
528 frame_window_p members of struct bidi_it.
d6d100dd
SM
529 (compute_display_string_pos, compute_display_string_end):
530 New functions.
fec2107c
EZ
531 (push_it): Accept second argument POSITION, where pop_it should
532 jump to continue iteration.
533 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 534
fec2107c
EZ
535 * keyboard.c (adjust_point_for_property): Adjust the call to
536 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
537
538 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
539 (bidi_init_it): Update prototypes.
540 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
541 (compute_display_string_pos, compute_display_string_end):
542 Declare prototypes.
fec2107c
EZ
543 (struct bidi_it): New members nchars and disp_pos. ch_len is now
544 EMACS_INT.
fc6f18ce 545
40087514 5462011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 547
57f53182
PE
548 Malloc failure behavior now depends on size of allocation.
549 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
550 * lisp.h: Change signatures accordingly.
551 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
552 All callers changed. (Bug#8762)
553
554 * gnutls.c: Use Emacs's memory allocators.
555 Without this change, the gnutls library would invoke malloc etc.
556 directly, which causes problems on non-SYNC_INPUT hosts, and which
557 runs afoul of improving memory_full behavior. (Bug#8761)
558 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
559 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
560 xfree instead of the default malloc, realloc, free.
561 (Fgnutls_boot): No need to check for memory allocation failure,
562 since xmalloc does that for us.
563
ac32cd99 564 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
565 * category.c (hash_get_category_set):
566 * ccl.c (ccl_driver):
567 * charset.c (Fdefine_charset_internal):
568 * charset.h (struct charset.hash_index):
569 * composite.c (get_composition_id, gstring_lookup_cache)
570 (composition_gstring_put_cache):
571 * composite.h (struct composition.hash_index):
572 * dispextern.h (struct image.hash):
573 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
574 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
575 (hashfn_equal, hashfn_user_defined, make_hash_table)
576 (maybe_resize_hash_table, hash_lookup, hash_put)
577 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
578 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
579 (Fsxhash, Fgethash, Fputhash, Fmaphash):
580 * image.c (make_image, search_image_cache, lookup_image)
581 (xpm_put_color_table_h):
582 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 583 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
584 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
585 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
586 * alloc.c (allocate_vectorlike):
587 Check for overflow in vector size calculations.
588 * ccl.c (ccl_driver):
589 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
590 * fns.c, image.c: Remove unnecessary static decls that would otherwise
591 need to be updated by these changes.
40087514
PE
592 * fns.c (make_hash_table, maybe_resize_hash_table):
593 Check for integer overflow with large hash tables.
0de4bb68
PE
594 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
595 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
596 (SXHASH_REDUCE): New macro.
597 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
598 Use it instead of discarding useful hash info with large hash values.
599 (sxhash_float): New function.
600 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
601 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
602 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
603 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
604 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
605 Adjust signatures to match updated version of code.
606 (consing_since_gc): Now EMACS_INT, since a single hash table can
607 use more than INT_MAX bytes.
608
698d32e2
DN
6092011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
610
611 Make it possible to build with GCC-4.6+ -O2 -flto.
612
613 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
614
fd6fa53f
SM
6152011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
616
617 * minibuf.c (get_minibuffer, read_minibuf_unwind):
618 Call minibuffer-inactive-mode.
619
864db017
JB
6202011-05-31 Juanma Barranquero <lekktu@gmail.com>
621
622 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
623 Update dependencies.
624
2ad0baf4
DN
6252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
626
627 * data.c (init_data): Remove code for UTS, this system is not
628 supported anymore.
629
4fcc2638
DN
6302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
631
632 Don't force ./temacs to start in terminal mode.
633
634 * frame.c (make_initial_frame): Initialize faces in all cases, not
635 only when CANNOT_DUMP is defined.
636 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
637
c56e0fd5
DN
6382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
639
640 * dispnew.c (add_window_display_history): Use const for the string
641 pointer. Remove declaration, not needed.
642
333d54da 6432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 644
55d4c1b2 645 Use 'inline', not 'INLINE'.
333d54da 646 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
647 * alloc.c, fontset.c (INLINE): Remove.
648 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
649 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
650 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
651 * gmalloc.c (register_heapinfo): Use inline unconditionally.
652 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
653
738db178
DN
6542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
655
656 Make it possible to run ./temacs.
657
658 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
659 syms_of_callproc does the same thing. Remove test for
660 "initialized", do it in the caller.
661 * emacs.c (main): Avoid calling set_initial_environment when dumping.
662
620c53a6
SM
6632011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
666 (read_minibuf): Use get_minibuffer.
667 (syms_of_minibuf): Use DEFSYM.
668 (Qmetadata): New var.
669 * data.c (Qbuffer): Don't make it static.
670 (syms_of_data): Use DEFSYM.
671
e003a292
PE
6722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
673
674 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
675 (CCL_CODE_MIN): New macro.
676
ed008a6d
PE
6772011-05-30 Paul Eggert <eggert@cs.ucla.edu>
678
3687c2ef
PE
679 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
680
ed008a6d
PE
681 * eval.c (Qdebug): Now static.
682 * lisp.h (Qdebug): Remove decl. This reverts a part of the
683 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
684 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
685
d66c4c7c
CY
6862011-05-29 Chong Yidong <cyd@stupidchicken.com>
687
688 * image.c: Various fixes to ImageMagick code comments.
689 (Fimagemagick_types): Doc fix.
690
5fbc2025
PE
6912011-05-29 Paul Eggert <eggert@cs.ucla.edu>
692
0196f88a
PE
693 Minor fixes prompted by GCC 4.6.0 warnings.
694
695 * xselect.c (converted_selections, conversion_fail_tag): Now static.
696
5fbc2025
PE
697 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
698 (x_clipboard_manager_save_all): Move extern decl to ...
699 * xterm.h: ... here, so that it can be checked for consistency.
700
1dd3c2d9
CY
7012011-05-29 Chong Yidong <cyd@stupidchicken.com>
702
703 * xselect.c (x_clipboard_manager_save_frame)
704 (x_clipboard_manager_save_all): New functions.
705 (Fx_clipboard_manager_save): Lisp function deleted.
706
707 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
708 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
709
710 * xterm.h: Update prototype.
711
5ba6571d
WX
7122011-05-28 William Xu <william.xwl@gmail.com>
713
714 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
715 exiting (Bug#8239).
716
3eaff834
JM
7172011-05-28 Jim Meyering <meyering@redhat.com>
718
e1900994 719 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
720 * fns.c (to_uchar): Define.
721 (crypto_hash_function): Use it to convert some newly-signed
722 variables to unsigned, to avoid sign-extension bugs. For example,
723 without this change, (md5 "truc") would evaluate to
724 45723a2aff78ff4fff7fff1114760e62 rather than the expected
725 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 726 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 727
0f6990a7
PE
7282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
729
730 Integer overflow fixes.
c8a9ca5a 731
08686060
PE
732 * dbusbind.c: Serial number integer overflow fixes.
733 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
734 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
735 to hold a serial number that is too large for a fixnum.
736 (Fdbus_method_return_internal, Fdbus_method_error_internal):
737 Check for serial numbers out of range. Decode any serial number
59568bf0 738 that was so large that it became a float. (Bug#8722)
08686060 739
2d1fc3c7
PE
740 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
741 (Fdbus_call_method, Fdbus_call_method_asynchronously):
742 Use XFASTINT rather than XUINT when numbers are nonnegative.
743 (xd_append_arg, Fdbus_method_return_internal):
744 (Fdbus_method_error_internal): Likewise. Also, for unsigned
745 arguments, check that Lisp number is nonnegative, rather than
59568bf0 746 silently wrapping negative numbers around. (Bug#8722)
30217ff0 747 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 748 (Bug#8722)
2d1fc3c7 749
c8a9ca5a
PE
750 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
751
519e1d69
PE
752 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
753
30569699
PE
754 ccl: add integer overflow checks
755 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
756 (IN_INT_RANGE): New macros.
757 (ccl_driver): Use them to check for integer overflow when
758 decoding a CCL program. Many of the new checks are whether XINT (x)
759 fits in int; it doesn't always, on 64-bit hosts. The new version
760 doesn't catch all possible integer overflows, but it's an
847044ea 761 improvement. (Bug#8719)
30569699 762
c11285dc
PE
763 * alloc.c (make_event_array): Use XINT, not XUINT.
764 There's no need for unsigned here.
765
fdccd48e
PE
766 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
767 This follows up to the 2011-05-06 change that substituted uintptr_t
768 for EMACS_INT. This case wasn't caught back then.
769
37910ab2
PE
770 Rework Fformat to avoid integer overflow issues.
771 * editfns.c: Include <float.h> unconditionally, as it's everywhere
772 now (part of C89). Include <verify.h>.
773 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
774 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
775 (Fformat): Avoid the prepass trying to compute sizes; it was only
776 approximate and thus did not catch overflow reliably. Instead, walk
777 through the format just once, formatting and computing sizes as we go,
778 checking for integer overflow at every step, and allocating a larger
779 buffer as needed. Keep track separately whether the format is
780 multibyte. Keep only the most-recently calculated precision, rather
781 than them all. Record whether each argument has been converted to
782 string. Use EMACS_INT, not int, for byte and char and arg counts.
783 Support field widths and precisions larger than INT_MAX. Avoid
784 sprintf's undefined behavior with conversion specifications such as %#d
785 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
786 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
787 formatting out-of-range floating point numbers with int
788 formats. (Bug#8668)
789
2e6578fb
PE
790 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
791
0ae6bdee
PE
792 * data.c: Avoid integer truncation in expressions involving floats.
793 * data.c: Include <intprops.h>.
794 (arith_driver): When there's an integer overflow in an expression
795 involving floating point, convert the integers to floating point
796 so that the resulting value does not suffer from catastrophic
797 integer truncation. For example, on a 64-bit host (* 4
798 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
799 Do not rely on undefined behavior after integer overflow.
800
de883a70
PE
801 merge count_size_as_multibyte, parse_str_to_multibyte
802 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 803 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
804 Check for integer overflow.
805 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
806 since it's now a duplicate of the other. This is more of
807 a character than a buffer op, so better that it's in character.c.
808 * fns.c, print.c: Adjust to above changes.
809
2ff916cb
PE
8102011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
813
f1b54466
PE
8142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
815
fb1ac845
PE
816 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
817 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
818 (x_clipboard_manager_save): Now static.
819 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
820
f1b54466
PE
821 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
822 (crypto_hash_function): Now static.
823 Fix pointer signedness problems. Avoid unnecessary initializations.
824
a9f737ee
CY
8252011-05-27 Chong Yidong <cyd@stupidchicken.com>
826
827 * termhooks.h (Vselection_alist): Make it terminal-local.
828
829 * terminal.c (create_terminal): Initialize it.
830
831 * xselect.c: Support for clipboard managers.
832 (Vselection_alist): Move to termhooks.h as terminal-local var.
833 (LOCAL_SELECTION): New macro.
834 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
835 (symbol_to_x_atom): Remove gratuitous arg.
836 (x_handle_selection_request, lisp_data_to_selection_data)
837 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
838 (x_own_selection, x_get_local_selection, x_convert_selection):
839 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
840 (some_frame_on_display): Delete unused function.
841 (Fx_own_selection_internal, Fx_get_selection_internal)
842 (Fx_disown_selection_internal, Fx_selection_owner_p)
843 (Fx_selection_exists_p): New optional frame arg.
844 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
845 (x_handle_selection_clear): Don't treat other terminals with the
846 same keyboard specially. Use the terminal-local Vselection_alist.
847 (x_clear_frame_selections): Use Frun_hook_with_args.
848
849 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
850
851 * xterm.h: Add support for those atoms.
852
e067f0c1
CY
8532011-05-26 Chong Yidong <cyd@stupidchicken.com>
854
855 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
856 (converted_selections, conversion_fail_tag): New global variables.
857 (x_selection_request_lisp_error): Free the above.
858 (x_get_local_selection): Remove unnecessary code.
859 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
860 of converted selections stored in converted_selections.
861 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
862 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
863 (x_convert_selection): New function.
864 (x_handle_selection_event): Simplify.
865 (x_get_foreign_selection): Don't ignore incoming requests while
866 waiting for an answer; this will fail when we implement
867 SAVE_TARGETS, and seems unnecessary anyway.
868 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
869 (Vx_sent_selection_functions): Doc fix.
870
0f4aebc0
LL
8712011-05-26 Leo Liu <sdl.web@gmail.com>
872
873 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
874
e61124cd
YM
8752011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
876
877 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
878
879 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
880 for fringe update if it has periodic bitmap.
881 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
882 and fringe_bitmap_periodic_p.
883
884 * fringe.c (get_fringe_bitmap_data): New function.
885 (draw_fringe_bitmap_1, update_window_fringes): Use it.
886 (update_window_fringes): Record periodicity of fringe bitmap in glyph
887 row. Mark glyph row for fringe update if periodicity changed.
888
889 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
890 for fringe update unless it has periodic bitmap.
891
f16d9837
KH
8922011-05-25 Kenichi Handa <handa@m17n.org>
893
894 * xdisp.c (get_next_display_element): Set correct it->face_id for
895 a static composition.
896
e1b90ef6
LL
8972011-05-24 Leo Liu <sdl.web@gmail.com>
898
899 * deps.mk (fns.o):
900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
901
902 * fns.c (crypto_hash_function, Fsha1): New function.
903 (Fmd5): Use crypto_hash_function.
904 (syms_of_fns): Add Ssha1.
905
7400048f
PE
9062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
907
908 * gnutls.c: Remove unused macros.
909 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
910 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
911 Remove macros that are defined and never used.
912 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
913
abb71cf4
CY
9142011-05-22 Chong Yidong <cyd@stupidchicken.com>
915
916 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
917 (Fx_get_selection_internal): Minor cleanup.
918 (Fx_own_selection_internal): Rename arguments for consistency with
919 select.el.
920
6307db39
PE
9212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
922
923 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
924
f3d4e0a4
CY
9252011-05-22 Chong Yidong <cyd@stupidchicken.com>
926
927 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
928
4d8ade89
YM
9292011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
930
931 * dispnew.c (scrolling_window): Don't exclude the case that the
932 last enabled row in the desired matrix touches the bottom boundary.
933
32078c8d
GM
9342011-05-21 Glenn Morris <rgm@gnu.org>
935
936 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
937 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
938 and add some more files.
32078c8d 939
7285dc67
EZ
9402011-05-20 Eli Zaretskii <eliz@gnu.org>
941
942 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
943 report_file_error introduced by the change from 2011-05-07.
944
89d1bd22
PE
9452011-05-20 Paul Eggert <eggert@cs.ucla.edu>
946
947 * systime.h (Time): Define only if emacs is defined.
948 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
949 where the include path doesn't have X11/X.h by default. See
950 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
951
e23640bb 9522011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
953
954 * composite.c (find_automatic_composition): Fix previous change.
955
b9704ad9
GM
9562011-05-20 Glenn Morris <rgm@gnu.org>
957
958 * lisp.mk: New file, split from Makefile.in.
959 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
960 (shortlisp): Remove.
961 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
962
4a720484
GM
9632011-05-19 Glenn Morris <rgm@gnu.org>
964
965 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
966 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
967 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
968 (lisp): Set the order to that of loadup.el.
969 (shortlisp): Make it a copy of $lisp.
970 (SOME_MACHINE_LISP): Remove.
971 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
972 Use just $shortlisp, not $SOME_MACHINE_LISP too.
973
a28d4396
KH
9742011-05-18 Kenichi Handa <handa@m17n.org>
975
976 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
977 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
978 (find_automatic_composition): Mostly rewrite for efficiency.
979
a2b1fa8e
JB
9802011-05-18 Juanma Barranquero <lekktu@gmail.com>
981
982 * makefile.w32-in: Update dependencies.
983
8e1f5610
CS
9842011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
985
986 * menu.c: Include limits.h (fixes the MS-Windows build broken by
987 revision 104625).
988
7025ee00 9892011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 990
cdfa6eab
PE
991 Fix some integer overflow issues, such as string length overflow.
992
06d6db33
PE
993 * insdel.c (count_size_as_multibyte): Check for string overflow.
994
2b4560a8
PE
995 * character.c (lisp_string_width): Check for string overflow.
996 Use EMACS_INT, not int, for string indexes and lengths; in
997 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
998 the resulting string length overflows an EMACS_INT; instead,
999 report a string overflow if no precision given. When checking for
1000 precision exhaustion, use a check that cannot possibly have
1001 integer overflow. (Bug#8675)
1002 * character.h (lisp_string_width): Adjust to new signature.
1003
cb93f9be
PE
1004 * alloc.c (string_overflow): New function.
1005 (Fmake_string): Use it. This doesn't change behavior, but saves
1006 a few bytes and will simplify future changes.
1007 * character.c (string_escape_byte8): Likewise.
1008 * lisp.h (string_overflow): New decl.
1009
1a1f3366
PE
1010 Fixups, following up to the user-interface timestamp change.
1011 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1012 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1013 * msdos.c (mouse_get_pos): Likewise.
1014 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1015 * w32gui.h (Time): Define by including "systime.h" rather than by
1016 declaring it ourselves. (Bug#8664)
1017
d4e3e4d3
PE
1018 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1019 * image.c (clear_image_cache): Likewise.
1020
f6a24d19
PE
1021 * term.c (term_mouse_position): Don't assume time_t wraparound.
1022
08dc5ae6
PE
1023 Be more systematic about user-interface timestamps.
1024 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1025 and sometimes 'EMACS_UINT', to represent these timestamps.
1026 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1027 This makes the code easier to follow, and makes it easier to catch
1028 integer overflow bugs such as Bug#8664.
1029 * frame.c (Fmouse_position, Fmouse_pixel_position):
1030 Use Time, not unsigned long, for user-interface timestamps.
1031 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1032 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1033 * keyboard.h (last_event_timestamp): Likewise.
1034 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1035 * menu.h (xmenu_show): Likewise.
1036 * term.c (term_mouse_position): Likewise.
1037 * termhooks.h (struct input_event.timestamp): Likewise.
1038 (struct terminal.mouse_position_hook): Likewise.
1039 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1040 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1041 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1042 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1043 what it was before.
1044 * menu.h, termhooks.h: Include "systime.h", for Time.
1045
8e55734a
PE
1046 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1047 Don't assume that the difference between two unsigned long values
1048 can fit into an integer. At this point, we know button_down_time
1049 <= event->timestamp, so the difference must be nonnegative, so
1050 there's no need to cast the result if double-click-time is
1051 nonnegative, as it should be; check that it's nonnegative, just in
1052 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1053 apart (about 25 days). (Bug#8664)
8e55734a 1054
841f1b75 1055 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1056 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1057
3e26f69c
PE
1058 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1059 that always fit in int. Use a sentinel instead of a counter, to
1060 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1061 * frame.h (struct frame): Use int for menu_bar_items_used
1062 instead of EMACS_INT, since it always fits in int.
3e26f69c 1063
5cc152c0
PE
1064 * menu.c (grow_menu_items): Check for int overflow.
1065
d89eb65e
PE
1066 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1067
5235bd3e
PE
1068 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1069 Before, the code was not consistent. These values cannot exceed
1070 2**31 - 1 so there's no need to make them unsigned.
1071 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1072 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1073 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1074 as modifiers.
1075 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1076
bc827e23
PE
1077 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1078 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1079 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1080 presumably because the widths might not match.
1081
78eb494e
PE
1082 * window.c (size_window): Avoid needless test at loop start.
1083
04f2d78b
CB
10842011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1085
1086 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1087
d2fc7e3d 10882011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1089
1090 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1091
d2fc7e3d 10922011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1093
1094 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1095 `width' to `bar_area_x' and `bar_area_width', respectively.
1096 (x_scroll_run): Take account of fringe background extension.
1097
04f2d78b
CB
1098 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1099 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1100 `bar_area_width', respectively.
1101 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1102 background extension.
1103
79b70037
GM
11042011-05-10 Jim Meyering <meyering@redhat.com>
1105
1106 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1107
2f142cc5
JB
11082011-05-10 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * image.c (Finit_image_library): Return t for built-in image types,
1111 like pbm and xbm. (Bug#8640)
1112
57679c86
AS
11132011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1114
1115 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1116
888c9e86
EZ
11172011-05-07 Eli Zaretskii <eliz@gnu.org>
1118
b0512a1d
EZ
1119 * w32console.c (Fset_screen_color): Doc fix.
1120 (Fget_screen_color): New function.
1121 (syms_of_ntterm): Defsubr it.
1122
7285dc67
EZ
1123 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1124 unlink the temporary file if Fcall_process didn't create it in the
1125 first place.
1126 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1127 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1128 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1129 cue to call_process_cleanup not to close that handle.
1130
4d3fcc8e
BK
11312011-05-07 Ben Key <bkey76@gmail.com>
1132
1133 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1134 one of two shell specific rules, either bootstrap-temacs-CMD or
1135 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1136 to the previous implementation of the bootstrap-temacs rule.
1137 The bootstrap-temacs-CMD rule is similar to the previous
1138 implementation of the bootstrap-temacs rule except that it
1139 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1140 variable.
1141
1142 These changes, along with some changes to nt/configure.bat,
1143 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1144 earlier fix to add support for --cflags and --ldflags options
1145 that include quotes so that it works whether make uses cmd or
1146 sh as the shell.
1147
b4289b64
MA
11482011-05-06 Michael Albinus <michael.albinus@gmx.de>
1149
1150 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1151 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1152 is a constant.
1153 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1154 a string. Handle both cases.
1155 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1156 (Fdbus_register_method): Use Qinvalid_function.
1157
af4c0e28
JB
11582011-05-06 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * makefile.w32-in: Update dependencies.
1161 (LISP_H): Add inttypes.h and stdin.h.
1162 (PROCESS_H): Add unistd.h.
1163
c51453d9
EZ
11642011-05-06 Eli Zaretskii <eliz@gnu.org>
1165
1166 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1167 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1168
8ff0ac3c 11692011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1170
4c4b566b
PE
1171 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1172
aab2b9b5
PE
1173 * term.c (vfatal): Remove stray call to va_end.
1174 It's not needed and the C Standard doesn't allow it here anyway.
1175
c378da0b
PE
1176 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1177 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1178
288b08c7
PE
1179 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1180 bytes.
1181
e3601888
PE
1182 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1183
db6c0e74
PE
1184 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1185
dd5963ea
PE
1186 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1187
88c9450f
PE
1188 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1189
2f9442b8
PE
1190 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1191
c032b5f8
PE
1192 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1193 * charset.c (Fdefine_charset_internal): Don't initialize
1194 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1195 32-bit int (Bug#8600).
a108c10b
PE
1196
1197 * lread.c (read_integer): Be more consistent with string-to-number.
1198 Use string_to_number to do the actual conversion; this avoids
1199 rounding errors and fixes some other screwups. Without this fix,
1200 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1201 (digit_to_number): Move earlier, for benefit of read_integer.
1202 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1203 not a digit in any supported base. (Bug#8602)
a108c10b 1204
ad5f9eea
PE
1205 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1206
aec1708a
PE
1207 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1208 to match comment at start of function. This also removes a
1209 GCC warning about overflow in a 32+64-bit port.
1210
47be4ab5
PE
1211 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1212
371cac43
PE
1213 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1214 Reported by Stefan Monnier in
1215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1216 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1217 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1218
d01a7826
PE
1219 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1220 (EMACS_UINTPTR): Likewise, with uintptr_t.
1221
7fd47d5c
PE
1222 * lisp.h: Prefer 64-bit EMACS_INT if available.
1223 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1224 on 32-bit hosts that have 64-bit int, so that they can access
1225 large files.
122b0c86
PE
1226 However, temporarily disable this change unless the temporary
1227 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1228
8727937b
PE
1229 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1230
8ac068ac
PE
1231 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1232 This removes an assumption that EMACS_INT and long are the same
1233 width as pointers. The assumption is true for Emacs porting targets
1234 now, but we want to make other targets possible.
1235 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1236 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1237 In the rest of the code, change types of integers that hold casted
1238 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1239 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1240 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1241 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1242 No need to cast type when ORing.
1243 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1244 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1245 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1246 assume EMACS_INT is the same width as char *.
1247 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1248 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1249 Remove no-longer-needed casts.
1250 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1251 (xg_tool_bar_help_callback, xg_make_tool_item):
1252 Use EMACS_INTPTR to hold an integer
1253 that will be cast to void *; this can avoid a GCC warning
1254 if EMACS_INT is not the same width as void *.
1255 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1256 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1257 (current_message_1, set_message_1):
1258 Use a local to convert to proper width without a cast.
1259 * xmenu.c (dialog_selection_callback): Likewise.
1260
ede49d71
PE
1261 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1262 Also, don't assume VALBITS / RAND_BITS is less than 5,
1263 and don't rely on undefined behavior when shifting a 1 left into
1264 the sign bit.
1265 * lisp.h (get_random): Change signature to match.
1266
2f30ecd0
PE
1267 * lread.c (hash_string): Use size_t, not int, for hash computation.
1268 Normally we prefer signed values; but hashing is special, because
1269 it's better to use unsigned division on hash table sizes so that
1270 the remainder is nonnegative. Also, size_t is the natural width
1271 for hashing into memory. The previous code used 'int', which doesn't
1272 retain enough info to hash well into very large tables.
1273 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1274
2a866e7b
PE
1275 * dbusbind.c: Don't possibly lose pointer info when converting.
1276 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1277 Use XPNTR rather than XHASH, so that the high-order bits of
1278 the pointer aren't lost when converting through void *.
1279
51639eac
PE
1280 * eval.c (Fautoload): Don't double-shift a pointer.
1281
92394119
PE
1282 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1283
dbdb9a7c
JB
12842011-05-06 Juanma Barranquero <lekktu@gmail.com>
1285
1286 * gnutls.c (DEF_GNUTLS_FN):
1287 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1288
db7a0b4f
AS
12892011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1290
1291 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1292 marker. (Bug#8610)
1293
f7ff1b0f 12942011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1295
1296 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1297 New version that can reserve upto 2GB of heap space.
1298
f7ff1b0f 12992011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1300
1301 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1302
639c109b
TZ
13032011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1304
1305 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1306 `gnutls_certificate_set_x509_key_file'.
1307
d2127135
JB
13082011-05-05 Juanma Barranquero <lekktu@gmail.com>
1309
1310 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1311 Update dependencies.
1312
e968f4f3
JB
13132011-05-04 Juanma Barranquero <lekktu@gmail.com>
1314
1315 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1316 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1317 Remove unused parameter `fildes'.
1318 * process.c (read_process_output, send_process): Don't pass it.
1319
84d358f0
JB
13202011-05-04 Juanma Barranquero <lekktu@gmail.com>
1321
1322 Fix previous change: the library cache is defined in w32.c.
1323 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1324 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1325
0898ca10
JB
13262011-05-04 Juanma Barranquero <lekktu@gmail.com>
1327
1328 Implement dynamic loading of GnuTLS on Windows.
1329
1330 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1331 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1332 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1333 Declare.
1334
1335 * gnutls.c (Qgnutls_dll): Define.
1336 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1337 (gnutls_*): Declare function pointers.
1338 (init_gnutls_functions): New function to initialize function pointers.
1339 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1340 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1341 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1342 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1343 (emacs_gnutls_write, emacs_gnutls_read)
1344 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1345 (Fgnutls_available_p): New function.
1346 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1347 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1348 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1349
1350 * image.c: Include w32.h.
1351 (Vimage_type_cache): Delete.
1352 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1353 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1354 (w32_delayed_load): Move to w32.c.
1355
1356 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1357
1358 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1359 (w32_delayed_load): Move from image.c. When loading a library, record
1360 its filename in the :loaded-from property of the library id.
1361 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1362 Initialize and staticpro them.
1363 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1364
1365 * process.c: Include lisp.h before w32.h, not after.
1366 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1367 instead of gnutls_record_check_pending.
1368
1369 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1370
ff4de4aa
TZ
13712011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1372
1373 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1374 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1375 as passed in.
1376
abe95abb
JD
13772011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1378
1379 * xterm.c (x_set_frame_alpha): Do not set property on anything
1380 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1381
e16e55d4
JB
13822011-05-02 Juanma Barranquero <lekktu@gmail.com>
1383
1384 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1385
bafcf6a5
JB
13862011-05-02 Juanma Barranquero <lekktu@gmail.com>
1387
1388 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1389 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1390 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1391 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1392 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1393 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1394 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1395 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1396 (Qgnutls_bootprop_callbacks_verify): Make static.
1397
e7a6747f
AS
13982011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1399
19ed11ba
AS
1400 * callproc.c: Indentation fixup.
1401
e7a6747f 1402 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1403 (wait_for_termination, interruptible_wait_for_termination):
1404 Move after wait_for_termination_1.
e7a6747f 1405
1ef14cb4
LMI
14062011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1407
1408 * sysdep.c (interruptible_wait_for_termination): New function
1409 which is like wait_for_termination, but allows keyboard
1410 interruptions.
1411
1412 * callproc.c (Fcall_process): Add (:file "file") as an option for
1413 the STDOUT buffer.
1414 (Fcall_process_region): Ditto.
1415
330d880c
EZ
14162011-04-30 Eli Zaretskii <eliz@gnu.org>
1417
8db90b73
EZ
1418 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1419 rather than `XVECTOR (FOO)->size'.
1420
330d880c
EZ
1421 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1422 inttypes.h, as a gnulib replacement is used if it not available in
1423 system headers.
1424
15cbd324
EZ
14252011-04-21 Eli Zaretskii <eliz@gnu.org>
1426
1427 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1428 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1429 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1430
1431 * coding.c (coding_alloc_by_realloc): Error out if destination
1432 will grow beyond MOST_POSITIVE_FIXNUM.
1433 (decode_coding_emacs_mule): Abort if there isn't enough place in
1434 charbuf for the composition carryover bytes. Reserve an extra
1435 space for up to 2 characters produced in a loop.
1436 (decode_coding_iso_2022): Abort if there isn't enough place in
1437 charbuf for the composition carryover bytes.
1438
14392011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1440
ae940cca
EZ
1441 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1442 aborting when %lld or %lll format is passed.
1443 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1444 %llo or %llx format is passed. (Bug#8545)
1445
03ab8921
EZ
1446 * window.c (window_scroll_line_based): Use a marker instead of
1447 simple variables to record original value of point. (Bug#7952)
1448
afda1437
EZ
1449 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1450 produced by %s or %c overflows available buffer space. (Bug#8545)
1451
f76dee0c
PE
14522011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1455 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1456
fdc5744d
JB
14572011-04-28 Juanma Barranquero <lekktu@gmail.com>
1458
1459 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1460
638f053a
JB
14612011-04-28 Juanma Barranquero <lekktu@gmail.com>
1462
1463 * keyboard.c (Qdelayed_warnings_hook): Define.
1464 (command_loop_1): Run `delayed-warnings-hook'
1465 if Vdelayed_warnings_list is non-nil.
1466 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1467 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1468
d178f871
EZ
14692011-04-28 Eli Zaretskii <eliz@gnu.org>
1470
1471 * doprnt.c (doprnt): Don't return value smaller than the buffer
1472 size if the message was truncated. (Bug#8545).
1473
b124fd93
JB
14742011-04-28 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1477 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1478
e810457d
PE
14792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1482
ea51cceb
JB
14832011-04-27 Juanma Barranquero <lekktu@gmail.com>
1484
1485 * makefile.w32-in: Update dependencies.
1486
94dcfacf
EZ
14872011-04-27 Eli Zaretskii <eliz@gnu.org>
1488
1489 Improve `doprnt' and its usage. (Bug#8545)
1490 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1491 `format_end'. Remove support for %l as a conversion specifier.
1492 Don't use xrealloc. Improve diagnostics when the %l size modifier
1493 is used. Update the commentary.
1494
1495 * eval.c (verror): Simplify calculation of size_t.
1496
1497 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1498 messages.
1499
f61f41d7
PE
15002011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1501
1502 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1503 change.
1504
96fb4434
PE
15052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1508 This makes this file independent of the recent pseudovector change.
1509
671875da 15102011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1511
69e9b5a3
PE
1512 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1513
b5f869a7 1514 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1515 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1516 Remove unused local.
c8926152 1517 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1518
841a1577 1519 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1520 GCC 4.6.0 optimizes based on type-based alias analysis.
1521 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1522 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1523 != &v->size, and therefore "v->size = 1; b->size = 2; return
1524 v->size;" must therefore return 1. This assumption is incorrect
1525 for Emacs, since it type-puns struct Lisp_Vector * with many other
1526 types. To fix this problem, this patch adds a new type struct
f904488f 1527 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1528 and pseudovectors, and helps optimizing compilers not get fooled
1529 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1530 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1531 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1532 the size member.
eab3844f
PE
1533 (XSETPVECTYPE): Rewrite in terms of new macro.
1534 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1535 This is a bit clearer, and further avoids the possibility of
1536 undesirable aliasing.
1537 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1538 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1539 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1540 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1541 (ASIZE): Now uses header.size rather than size.
1542 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1543 to avoid the hassle of writing XVECTOR (foo)->header.size.
1544 (struct vectorlike_header): New type.
eab3844f
PE
1545 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1546 object, to help avoid aliasing.
1547 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1548 (SUBRP): Likewise, since Lisp_Subr is a special case.
1549 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1550 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1551 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1552 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1553 changed to be "header.size" and "header.next".
1554 * buffer.h (struct buffer): Likewise.
1555 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1556 * frame.h (struct frame): Likewise.
1557 * process.h (struct Lisp_Process): Likewise.
1558 * termhooks.h (struct terminal): Likewise.
1559 * window.c (struct save_window_data, struct saved_window): Likewise.
1560 * window.h (struct window): Likewise.
1561 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1562 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1563 * buffer.c (init_buffer_once): Likewise.
1564 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1565 special case.
1566 * process.c (Fformat_network_address): Use local var for size,
1567 for brevity.
1568
0df1eac5
PE
1569 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1570
847ab9d1 1571 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1572 * data.c (atof): Remove decl; no longer used or needed.
1573 (digit_to_number): Move to lread.c.
1574 (Fstring_to_number): Use new string_to_number function, to be
1575 consistent with how the Lisp reader treats infinities and NaNs.
1576 Do not assume that floating-point numbers represent EMACS_INT
1577 without losing information; this is not true on most 64-bit hosts.
1578 Avoid double-rounding errors, by insisting on integers when
1579 parsing non-base-10 numbers, as the documentation specifies.
1580 * lisp.h (string_to_number): New decl, replacing ...
1581 (isfloat_string): Remove.
bc0a5c13 1582 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1583 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1584 appears to have been a coding error. Similarly, do not accept
1585 strings like +-1e0 as floating point numbers. Do not report
1586 overflow for integer overflows unless the base is not 10 which
1587 means we have no simple and reliable way to continue.
1588 Break out the floating-point parsing into a new
1589 function string_to_number, so that Fstring_to_number parses
1590 floating point numbers consistently with the Lisp reader.
04f2d78b 1591 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1592 (E_CHAR, EXP_INT): Remove, replacing with ...
1593 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1594 (string_to_number): New function, replacing isfloat_string.
1595 This function checks for valid syntax and produces the resulting
1596 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1597 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1598 so that overflow for non-base-10 numbers is reported only when
1599 there's no portable and simple way to convert to floating point.
452f4150 1600
67769ffc
PE
1601 * textprop.c (set_text_properties_1): Rewrite for clarity,
1602 and to avoid GCC warning about integer overflow.
1603
c20db43f
PE
1604 * intervals.h (struct interval): Use EMACS_INT for members
1605 where EMACS_UINT might cause problems. See
1606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1607 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1608 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1609 All uses changed.
37aa2f85
PE
1610 (offset_intervals): Tell GCC not to worry about length overflow
1611 when negating a negative length.
c20db43f 1612
2538aa2f
PE
1613 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1614 (overrun_check_free): Likewise.
1615
f2d3008d
PE
1616 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1617 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1618 word size.
1619
ec8df744
PE
1620 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1621 (gnutls_make_error): Rename local to avoid shadowing.
1622 (gnutls_emacs_global_deinit): ifdef out; not used.
1623 (Fgnutls_boot): Use const for pointer to readonly storage.
1624 Comment out unused local. Fix pointer signedness problems.
1625
640ee02d
PE
1626 * lread.c (openp): Don't stuff size_t into an 'int'.
1627 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1628 about possible signed overflow.
1629
6048fb2a
PE
1630 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1631 (GDK_KEY_g): Don't define if already defined.
1632 (xg_prepare_tooltip): Avoid pointer signedness problem.
1633 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1634
fa3c87e1
PE
1635 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1636 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1637
2172544b
PE
1638 * xfns.c (Fx_window_property): Simplify a bit,
1639 to make a bit faster and to avoid GCC 4.6.0 warning.
1640 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1641
9b821a21
PE
1642 * fns.c (internal_equal): Don't assume size_t fits in int.
1643
3c616cfa
PE
1644 * alloc.c (compact_small_strings): Tighten assertion a little.
1645
c2982e87
PE
1646 Replace pEd with more-general pI, and fix some printf arg casts.
1647 * lisp.h (pI): New macro, generalizing old pEd macro to other
1648 conversion specifiers. For example, use "...%"pI"d..." rather
1649 than "...%"pEd"...".
1650 (pEd): Remove. All uses replaced with similar uses of pI.
1651 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1652 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1653 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1654 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1655 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1656 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1657 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1658 64-bit hosts.
1659 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1660 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1661 * print.c (safe_debug_print, print_object): Likewise.
1662 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1663 to int.
6f04d126
PE
1664 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1665 avoiding the 0 flag, which is not portable.
c2982e87
PE
1666 * process.c (Fmake_network_process): Use pI to avoid cast.
1667 * region-cache.c (pp_cache): Likewise.
1668 * xdisp.c (decode_mode_spec): Likewise.
1669 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1670 behavior on 64-bit hosts with printf arg.
6f04d126 1671 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1672 (x_stop_queuing_selection_requests): Likewise.
1673 (x_get_window_property): Don't truncate byte count to an 'int'
1674 when tracing.
0b432f21 1675
5e073ec7
PE
1676 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1677 here, since it parses constructs like leading '-' and spaces,
1678 which are not wanted; and it overflows with large numbers.
1679 Instead, simply match F[0-9]+, which is what is wanted anyway.
1680
36372bf9
PE
1681 * alloc.c: Remove unportable assumptions about struct layout.
1682 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1683 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1684 (allocate_vectorlike, make_pure_vector): Use the new macros,
1685 plus offsetof, to remove unportable assumptions about struct layout.
1686 These assumptions hold on all porting targets that I know of, but
1687 they are not guaranteed, they're easy to remove, and removing them
1688 makes further changes easier.
1689
0b432f21
PE
1690 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1691 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1692 (string_overrun_cookie): Now const. Use initializers that
1693 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1694 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1695 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1696 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1697 multiple of sizeof (EMACS_INT); it need not be, if
1698 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1699 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1700
895009e1
JB
17012011-04-26 Juanma Barranquero <lekktu@gmail.com>
1702
1703 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1704
6a7a1b0b
TZ
17052011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1706
1707 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1708 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1709 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1710
841a1577 17112011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1712
1713 * lisp.h (Qdebug): List symbol.
895009e1 1714 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1715 * keyboard.c (debug-on-event): New variable.
1716 (handle_user_signal): Break into debugger when debug-on-event
1717 matches the current signal symbol.
1718
f2d3ba6f
DN
17192011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1720
1721 * alloc.c (check_sblock, check_string_bytes)
1722 (check_string_free_list): Convert to standard C.
1723
42ce4c63
TZ
17242011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1725
1726 * w32.c (emacs_gnutls_push): Fix typo.
1727
825cd63c
EZ
17282011-04-25 Eli Zaretskii <eliz@gnu.org>
1729
fb11d64d
EZ
1730 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1731 "cast to pointer from integer of different size".
1732
825cd63c
EZ
1733 Improve doprnt and its use in verror. (Bug#8545)
1734 * doprnt.c (doprnt): Document the set of format control sequences
1735 supported by the function. Use SAFE_ALLOCA instead of always
1736 using `alloca'.
1737
1738 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1739 is one byte too soon. Don't use xrealloc; instead xfree and
1740 xmalloc anew.
1741
e061a11b
TZ
17422011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1743
1744 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1745 callbacks stage.
1746
1747 * gnutls.c: Renamed global_initialized to
1748 gnutls_global_initialized. Added internals for the
1749 :verify-hostname-error, :verify-error, and :verify-flags
1750 parameters of `gnutls-boot' and documented those parameters in the
1751 docstring. Start callback support.
1752 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1753 unless a fatal error occured. Call gnutls_alert_send_appropriate
1754 on error. Return error code.
1755 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1756 (emacs_gnutls_read): Likewise.
1757 (Fgnutls_boot): Return handshake error code.
1758 (emacs_gnutls_handle_error): New function.
1759 (wsaerror_to_errno): Likewise.
1760
1761 * w32.h (emacs_gnutls_pull): Add prototype.
1762 (emacs_gnutls_push): Likewise.
1763
1764 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1765 (emacs_gnutls_push): Likewise.
1766
17672011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1768
1769 * process.c (wait_reading_process_output): Check if GnuTLS
1770 buffered some data internally if no FDs are set for TLS
1771 connections.
1772
1773 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1774 (LIBS): Link to USER_LIBS.
1775 ($(BLD)/gnutls.$(0)): New target.
1776
fa6996bc
EZ
17772011-04-24 Eli Zaretskii <eliz@gnu.org>
1778
eb35682e
EZ
1779 * xdisp.c (handle_single_display_spec): Rename the
1780 display_replaced_before_p argument into display_replaced_p, to
1781 make it consistent with the commentary. Fix typos in the
1782 commentary.
1783
e2ad650c
EZ
1784 * textprop.c (syms_of_textprop): Remove dead code.
1785 (copy_text_properties): Delete obsolete commentary about an
1786 interface that was deleted long ago. Fix typos in the description
1787 of arguments.
1788
1b2de274
EZ
1789 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1790 to changes in oldXMenu/XMenu.h from 2011-04-16.
1791 <menu_help_message, prev_menu_help_message>: Constify.
1792 (IT_menu_make_room): menu->help_text is now `const char **';
1793 adjust.
1794
1795 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1796 to changes in oldXMenu/XMenu.h from 2011-04-16.
1797 (struct XMenu): Declare `help_text' `const char **'.
1798
1799 * xfaces.c <Qunspecified>: Make extern again.
1800
1801 * syntax.c: Include sys/types.h before including regex.h, as
1802 required by Posix.
1803
762b15be
EZ
1804 * doc.c (get_doc_string): Improve the format passed to `error'.
1805
1806 * doprnt.c (doprnt): Improve commentary.
1807
1808 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1809
1810 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1811 them with etags.
1812
f1052e5d
EZ
1813 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1814 changes in globals.h immediately force recompilation.
762b15be
EZ
1815 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1816 $(CURDIR)/s/ms-w32.h.
1817 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1818
fa6996bc
EZ
1819 * character.c (Fchar_direction): Function deleted.
1820 (syms_of_character): Don't defsubr it.
1821 <char-direction-table>: Deleted.
1822
e6c3da20
EZ
18232011-04-23 Eli Zaretskii <eliz@gnu.org>
1824
1825 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1826 * doprnt.c: Include limits.h.
1827 (SIZE_MAX): New macro.
04f2d78b
CB
1828 (doprnt): Return a size_t value. 2nd arg is now size_t.
1829 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1830 Improve overflow protection. Support `l' modifier for integer
1831 conversions. Support %l conversion. Don't assume an EMACS_INT
1832 argument for integer conversions and for %c.
1833
1834 * lisp.h (doprnt): Restore prototype.
1835
1836 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1837 $(SRC)/character.h.
1838
1839 * Makefile.in (base_obj): Add back doprnt.o.
1840
1841 * deps.mk (doprnt.o): Add back prerequisites.
1842 (callint.o): Depend on character.h.
1843
1844 * eval.c (internal_lisp_condition_case): Include the handler
1845 representation in the error message.
1846 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1847 when breaking from the loop.
1848
1849 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1850
1851 * callint.c (Fcall_interactively): When displaying error message
1852 about invalid control letter, pass the character's codepoint, not
1853 a pointer to its multibyte form. Improve display of the character
1854 in octal and display also its hex code.
1855
1856 * character.c (char_string): Use %x to display the (unsigned)
1857 codepoint of an invalid character, to avoid displaying a bogus
1858 negative value.
1859
1860 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1861 `error', not SYMBOL_NAME itself.
1862
1863 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1864 character arguments to `error'.
1865
1866 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1867 to `error' in error message about FINAL_CHAR argument. Make sure
1868 FINAL_CHAR is a character, and use %c when it is passed as
1869 argument to `error'.
1870
4ffd0d6b 18712011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1872
1873 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1874
1875 * w32.c: Include <time.h>.
1876 (sys_localtime): New function.
1877
4ffd0d6b 18782011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1879
1880 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1881
4ffd0d6b 1882 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1883
4ffd0d6b 18842011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1885
4ffd0d6b
GM
1886 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1887 zombies (Bug#8467).
aac0c6e3 1888
04c56954
EZ
18892011-04-19 Eli Zaretskii <eliz@gnu.org>
1890
1891 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1892 gl_state.e_property when gl_state.object is Qt.
1893
1894 * insdel.c (make_gap_larger): Remove limitation of buffer size
1895 to <= INT_MAX.
1896
16a43933
CY
18972011-04-18 Chong Yidong <cyd@stupidchicken.com>
1898
1899 * xdisp.c (lookup_glyphless_char_display)
1900 (produce_glyphless_glyph): Handle cons cell entry in
1901 glyphless-char-display.
1902 (Vglyphless_char_display): Document it.
1903
1904 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1905 glyphless-char-display.
1906
4581706e
CY
19072011-04-17 Chong Yidong <cyd@stupidchicken.com>
1908
1909 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1910
1911 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1912
1913 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1914 definition for no-X builds.
1915
4887c6e2 19162011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1917
fd35b6f9
PE
1918 Static checks with GCC 4.6.0 and non-default toolkits.
1919
5c1ccb01
PE
1920 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1921
006c5daa
PE
1922 * process.c (keyboard_bit_set): Define only if SIGIO.
1923 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1924 (send_process): Repair possible setjmp clobbering.
1925
efc736d3
PE
1926 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1927
4e2fe2e6
PE
1928 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1929
f97334a2
PE
1930 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1931
4e75f29d
PE
1932 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1933 Define only if needed.
1934
90efadd1
PE
1935 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1936 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1937 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1938
3c647824
PE
1939 * dispextern.h (struct redisplay_interface): Rename param
1940 to avoid shadowing.
e264f262 1941 * termhooks.h (struct terminal): Likewise.
761383f4 1942 * xterm.c (xembed_send_message): Likewise.
3c647824 1943
b58c5c4a
PE
1944 * insdel.c (make_gap_smaller): Define only if
1945 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1946
cad59032
PE
1947 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1948 it.
1949
c339dc2e
PE
1950 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1951 so that we aren't warned about unused symbols.
1952
91a3e27b
PE
1953 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1954
399c71d3 1955 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1956
8ffc96f5
PE
1957 * xfns.c (x_real_positions): Mark locals as initialized.
1958
eef9bc79
PE
1959 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1960
098db9dd
PE
1961 * xterm.c: Fix problems found by static analysis with other toolkits.
1962 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1963 (x_dispatch_event): Declare static if USE_GTK, and
1964 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1965 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1966 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1967 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1968 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1969
eb18f6cc
PE
1970 * xmenu.c (menu_help_callback): Pointer type fixes.
1971 Use const pointers when pointing at readonly data. Avoid pointer
1972 signedness clashes.
1973 (FALSE): Remove unused macro.
1974 (update_frame_menubar): Remove unused decl.
1975
1fe72bf8
PE
1976 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1977
60d9e1db
PE
1978 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1979 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1980 (single_menu_item): Rename local to avoid shadowing.
1981
39261c26
PE
1982 * keyboard.c (make_lispy_event): Remove unused local var.
1983
018c5e19
PE
1984 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1985 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1986
63d2b86e
PE
1987 * bitmaps: Change bitmaps from unsigned char back to the X11
1988 compatible char. Avoid the old compiler warnings about
1989 out-of-range initializers by using, for example, '\xab' rather
1990 than 0xab.
1991
aefd87e1
PE
1992 * xgselect.c (xgselect_initialize): Check vs interface
1993 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1994
bf501fb9
PE
1995 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1996
e9829fdf
PE
1997 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1998 to read-only memory.
1999
1086c095
PE
2000 * fns.c (vector): Remove; this old hack is no longer needed.
2001
2baccd04 2002 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2003 Remove unused var.
dde42981 2004 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2005
72391843 2006 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2007
436c16df 2008 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2009 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2010 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2011
92bb796d 2012 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2013 (x_term_init): Remove local to avoid shadowing.
92bb796d 2014
764430a3 2015 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2016
2017 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2018 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2019
d1dfb56c
EZ
20202011-04-16 Eli Zaretskii <eliz@gnu.org>
2021
c4354cb4
EZ
2022 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2023
d1dfb56c
EZ
2024 Fix regex.c, syntax.c and friends for buffers > 2GB.
2025 * syntax.h (struct gl_state_s): Declare character position members
2026 EMACS_INT.
2027
2028 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2029
04f2d78b
CB
2030 * textprop.c (verify_interval_modification, interval_of):
2031 Declare arguments EMACS_INT.
d1dfb56c
EZ
2032
2033 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2034 EMACS_INT.
2035
2036 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2037
2038 * indent.c (Fvertical_motion): Local variable it_start is now
2039 EMACS_INT.
2040
2041 * regex.c (re_match, re_match_2, re_match_2_internal)
2042 (bcmp_translate, regcomp, regexec, print_double_string)
2043 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2044 (re_compile_pattern, re_exec): Declare arguments and local
2045 variables `size_t' and `ssize_t' and return values `regoff_t', as
2046 appropriate.
2047 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2048 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2049 <compile_stack_type>: `size' and `avail' are now `size_t'.
2050
2051 * regex.h <regoff_t>: Use ssize_t, not int.
2052 (re_search, re_search_2, re_match, re_match_2): Arguments that
2053 specify buffer/string position and length are now ssize_t and
2054 size_t. Return type is regoff_t.
2055
613052cd
BK
20562011-04-16 Ben Key <bkey76@gmail.com>
2057
2058 * nsfont.m: Fixed bugs in ns_get_family and
2059 ns_descriptor_to_entity that were caused by using free to
2060 deallocate memory blocks that were allocated by xmalloc (via
2061 xstrdup). This caused Emacs to crash when compiled with
2062 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2063 --enable-checking=xmallocoverrun). xfree is now used to
2064 deallocate these memory blocks.
2065
4170f62f 20662011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2067
71b41406
PE
2068 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2069
9587a89d
PE
2070 emacs_write: Accept and return EMACS_INT for sizes.
2071 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2072 et seq.
2073 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2074 Accept and return EMACS_INT.
2075 (emacs_gnutls_write): Return the number of bytes written on
2076 partial writes.
2077 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2078 (emacs_read, emacs_write): Remove check for negative size, as the
2079 Emacs source code has been audited now.
9587a89d
PE
2080 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2081 (emacs_read, emacs_write): Use it.
273a5f82
PE
2082 * process.c (send_process): Adjust to the new signatures of
2083 emacs_write and emacs_gnutls_write. Do not attempt to store
2084 a byte offset into an 'int'; it might overflow.
9587a89d 2085 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2086
3e047f51
PE
2087 * sound.c: Don't assume sizes fit in 'int'.
2088 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2089 Return EMACS_INT, not int.
3e047f51 2090 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2091 Accept EMACS_INT, not int.
2092 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2093 record read return values.
2094
cc39a9db
BK
20952011-04-15 Ben Key <bkey76@gmail.com>
2096
c9d0ec6d
JB
2097 * keyboard.c (Qundefined): Don't declare static since it is used
2098 in nsfns.m.
2099 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2100 static since they are used in nsfont.m.
cc39a9db 2101
6c60eb9f
SM
21022011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2103
2104 * process.c (Qprocessp): Don't declare static.
2105 * lisp.h (Qprocessp): Declare again.
2106
7990b61a
JB
21072011-04-15 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2110
5d4cb038
PE
21112011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2112
8bd7b830 2113 Improve C-level modularity by making more things 'static'.
cd64ea1d 2114
e3b27b31
PE
2115 Don't publish debugger-only interfaces to other modules.
2116 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2117 (verify_bytepos, count_markers): Move decls to the only modules
2118 that need them.
2119 * region-cache.h (pp_cache): Likewise.
2120 * window.h (check_all_windows): Likewise.
2121 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2122
5d4cb038
PE
2123 * sysdep.c (croak): Now static, if
2124 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2125 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2126
2127 * alloc.c (refill_memory_reserve): Now static if
2128 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2129 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2130
e87b6180
PE
2131 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2132 Define only if USE_LUCID.
2133
ac64929e
PE
2134 * xrdb.c (x_customization_string, x_rm_string): Now static.
2135
6f37259d
PE
2136 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2137 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2138
1683e3ab
PE
2139 * xdisp.c (draw_row_with_mouse_face): Now static.
2140 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2141
de9c2632
PE
2142 * window.h (check_all_windows): Mark externally visible.
2143
2b96acb7
PE
2144 * window.c (window_deletion_count): Now static.
2145
2146 * undo.c: Make symbols static if they're not exported.
2147 (last_undo_buffer, last_boundary_position, pending_boundary):
2148 Now static.
2149
50436f33
PE
2150 * textprop.c (interval_insert_behind_hooks): Now static.
2151 (interval_insert_in_front_hooks): Likewise.
2152
64520e5c
PE
2153 * term.c: Make symbols static if they're not exported.
2154 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2155 (max_frame_lines, tty_set_terminal_modes):
2156 (tty_reset_terminal_modes, tty_turn_off_highlight):
2157 (get_tty_terminal): Now static.
2158 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2159 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2160 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2161 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2162 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2163
1fa53021
PE
2164 * sysdep.c: Make symbols static if they're not exported.
2165 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2166 Now static.
2167 (sigprocmask_set, full_mask): Remove; unused.
2168 (wait_debugging): Mark as visible.
2169 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2170 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2171
d4b43b22
PE
2172 * syntax.c (syntax_temp): Define only if !__GNUC__.
2173
b7c513d0
PE
2174 * sound.c (current_sound_device, current_sound): Now static.
2175
989b29ad
PE
2176 * search.c (searchbufs, searchbuf_head): Now static.
2177
13a55a78
PE
2178 * scroll.c (scroll_cost): Remove; unused.
2179 * dispextern.h (scroll_cost): Remove decl.
2180
de68a1fc
PE
2181 * region-cache.h (pp_cache): Mark as externally visible.
2182
40ccffa6
PE
2183 * process.c: Make symbols static if they're not exported.
2184 (process_tick, update_tick, create_process, chan_process):
2185 (Vprocess_alist, proc_buffered_char, datagram_access):
2186 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2187 (deactivate_process): Mark defn as static, as well as decl.
2188 * lisp.h (create_process): Remove decl.
2189 * process.h (chan_process, Vprocess_alist): Remove decls.
2190
ad64fc97
PE
2191 * print.c: Make symbols static if they're not exported.
2192 (print_depth, new_backquote_output, being_printed, print_buffer):
2193 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2194 (print_interval, print_number_index, initial_stderr_stream):
2195 Now static.
2196 * lisp.h (Fprinc): Remove decl.
2197 (debug_output_compilation_hack): Mark as externally visible.
2198
adddb265
PE
2199 * sysdep.c (croak): Move decl from here to syssignal.h.
2200 * syssignal.h (croak): Put it here, so the API can be checked when
2201 'croak' is called from dissociate_if_controlling_tty.
2202
1717ede2
PE
2203 * minibuf.c: Make symbols static if they're not exported.
2204 (minibuf_save_list, choose_minibuf_frame): Now static.
2205 * lisp.h (choose_minibuf_frame): Remove decl.
2206
fa5fb2bc
PE
2207 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2208
1e3890d1
PE
2209 * lread.c: Make symbols static if they're not exported.
2210 (read_objects, initial_obarray, oblookup_last_bucket_number):
2211 Now static.
2212 (make_symbol): Remove; unused.
2213 * lisp.h (initial_obarray, make_symbol): Remove decls.
2214
8a1414fa
PE
2215 * keyboard.c: Make symbols static if they're not exported.
2216 (single_kboard, recent_keys_index, total_keys, recent_keys):
2217 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2218 (this_single_command_key_start, echoing, last_auto_save):
2219 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2220 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2221 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2222 (Vlispy_mouse_stem, double_click_count):
2223 Now static.
2224 (force_auto_save_soon): Define only if SIGDANGER.
2225 (ignore_mouse_drag_p): Now static if
2226 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2227 (print_help): Remove; unused.
2228 (stop_character, last_timer_event): Mark as externally visible.
2229 * keyboard.h (ignore_mouse_drag_p): Declare only if
2230 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2231 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2232 * lisp.h (echoing): Remove decl.
2233 (force_auto_save_soon): Declare only if SIGDANGER.
2234 * xdisp.c (redisplay_window): Simplify code, to make it more
2235 obvious that ignore_mouse_drag_p is not accessed if !defined
2236 USE_GTK && !defined HAVE_NS.
2237
93ea6e8f
PE
2238 * intervals.c: Make symbols static if they're not exported.
2239 (merge_properties_sticky, merge_interval_right, delete_interval):
2240 Now static.
2241 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2242
77382fcc
PE
2243 * insdel.c: Make symbols static if they're not exported.
2244 However, leave prepare_to_modify_buffer alone. It's never
2245 called from outside this function, but that appears to be a bug.
2246 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2247 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2248 (adjust_after_replace_noundo): Remove; unused.
2249 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2250 (signal_before_change): Remove decls.
77382fcc 2251
9306c32e
PE
2252 * indent.c (val_compute_motion, val_vmotion): Now static.
2253
cd44d2eb
PE
2254 * image.c: Make symbols static if they're not exported.
2255 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2256 if USE_GTK.
2257 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2258 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2259
ad9a7a06
PE
2260 * fringe.c (standard_bitmaps): Now static.
2261 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2262
81626931
PE
2263 * frame.c: Make symbols static if they're not exported.
2264 (x_report_frame_params, make_terminal_frame): Now static.
2265 (get_frame_param): Now static, unless HAVE_NS.
2266 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2267 (x_get_resource_string): Remove; not used.
2268 * frame.h (make_terminal_frame, x_report_frame_params):
2269 (x_get_resource_string); Remove decls.
2270 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2271 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2272
239f9db9
PE
2273 * font.c, fontset.c: Make symbols static if they're not exported.
2274 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2275 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2276 * font.c (font_close_object): Now static.
2277 * font.h (font_close_object): Remove.
2278 * fontset.c (FONTSET_OBJLIST): Remove.
2279 (free_realized_fontset) #if-0 the body, which does nothing.
2280 (face_suitable_for_char_p): #if-0, as it's never called.
2281 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2282 * xfaces.c (face_at_string_position):
2283 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2284 since 0 is always ASCII.
2285
dfcf3579
PE
2286 * fns.c (weak_hash_tables): Now static.
2287
5045092b
PE
2288 * fileio.c: Make symbols static if they're not exported.
2289 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2290 (Vwrite_region_annotation_buffers): Now static.
2291
57a96f5c
PE
2292 * eval.c: Make symbols static if they're not exported.
2293 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2294 * lisp.h (backtrace_list): Remove decl.
2295
35f08c38
PE
2296 * emacs.c: Make symbols static if they're not exported.
2297 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2298 (fatal_error_code, fatal_error_signal_hook, standard_args):
2299 Now static.
2300 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2301 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2302 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2303 * lisp.h (fatal_error_signal_hook): Remove decl.
2304 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2305
f44bd759
PE
2306 * editfns.c: Move a (normally-unused) function to its only use.
2307 * editfns.c, lisp.h (get_operating_system_release): Remove.
2308 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2309 worth the hassle of breaking this out.
2310
b532497d
PE
2311 * xterm.c: Make symbols static if they're not exported.
2312 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2313 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2314 (x_destroy_window, x_delete_display):
2315 Now static.
2316 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2317 (x_mouse_leave): Remove; unused.
2318 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2319 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2320 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2321 Remove decls.
2322 (x_mouse_leave): Declare only if WINDOWSNT.
2323 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2324 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2325 USE_X_TOOLKIT.
2326
1675728f
PE
2327 * ftxfont.c: Make symbols static if they're not exported.
2328 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2329 HAVE_FREETYPE.
2330 * font.h (ftxfont_driver): Likewise.
2331
e4cebfca
PE
2332 * xfns.c: Make symbols static if they're not exported.
2333 (x_last_font_name, x_display_info_for_name):
2334 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2335 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2336 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2337 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2338 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2339 (last_show_tip_args): Now static.
2340 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2341 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2342 (x_screen_planes): Remove; unused.
2343 * dispextern.h (x_screen_planes): Remove decl.
2344
5bf46f05
PE
2345 * dispnew.c: Make symbols static if they're not exported.
2346 * dispextern.h (redraw_garbaged_frames, scrolling):
2347 (increment_row_positions): Remove.
2348 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2349 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2350 Now static.
2351 (redraw_garbaged_frames): Remove; unused.
2352
435f4c28
PE
2353 * xfaces.c: Make symbols static if they're not exported.
2354 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2355 Remove decls.
2356 * xterm.h (defined_color): Remove decls.
2357 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2358 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2359 (menu_face_changed_default, defined_color, free_realized_face):
2360 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2361 (ascii_face_of_lisp_face): Remove; unused.
2362
8524aef3
PE
2363 * xdisp.c: Make symbols static if they're not exported.
2364 * dispextern.h (scratch_glyph_row, window_box_edges):
2365 (glyph_to_pixel_coords, set_cursor_from_row):
2366 (get_next_display_element, set_iterator_to_next):
2367 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2368 (show_mouse_face): Remove decls
2369 * frame.h (message_buf_print): Likewise.
2370 * lisp.h (pop_message, set_message, check_point_in_composition):
2371 Likewise.
2372 * xterm.h (set_vertical_scroll_bar): Likewise.
2373 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2374 (message_buf_print, scratch_glyph_row, displayed_buffer):
2375 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2376 (get_next_display_element, show_mouse_face, window_box_edges):
2377 (frame_to_window_pixel_xy, check_point_in_composition):
2378 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2379 (glyph_to_pixel_coords): Remove; unused.
2380
16390cd2
PE
2381 * dired.c (file_name_completion): Now static.
2382
2383 * dbusbind.c (xd_in_read_queued_messages): Now static.
2384
a25f4dfa
PE
2385 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2386 * data.c (circular_list_error): Remove.
2387
14a9c8df
PE
2388 * commands.h (last_point_position, last_point_position_buffer):
2389 (last_point_position_window): Remove decls.
2390 * keyboard.c: Make these variables static.
2391
04f2d78b
CB
2392 * coding.h (coding, code_convert_region, encode_coding_gap):
2393 Remove decls.
74ab6df5
PE
2394 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2395 (iso_code_class, detect_coding, code_convert_region): Now static.
2396 (encode_coding_gap): Remove; unused.
2397
38dfbee1
PE
2398 * chartab.c (chartab_chars, chartab_bits): Now static.
2399
a2cb4e63
PE
2400 * charset.h (charset_iso_8859_1): Remove decl.
2401 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2402 Now static.
2403
127198fd
PE
2404 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2405 * ccl.c (Vccl_program_table): Now static.
2406 (check_ccl_update): Remove; unused.
2407
d85b608f
PE
2408 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2409 * category.h: ... from here.
2410 * category.c (check_category_table, set_category_set): Now static.
2411
31cd66f3
PE
2412 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2413 * lisp.h: Remove these decls.
2414
c358e587
PE
2415 * buffer.c (buffer_count): Remove unused var.
2416
e78aecca
PE
2417 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2418 so that it's not optimized away.
2419 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2420 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2421 exported only to the debugger.
2422
e192d7d3 2423 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2424 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2425
92470028
PE
2426 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2427 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2428 was inaccessible from Lisp.
2429 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2430 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2431
244ed907
PE
2432 alloc.c: Import and export fewer symbols, and remove unused items.
2433 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2434 is defined.
2435 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2436 it's not optimized away by whole-program optimization.
2437 (message_enable_multibyte, free_misc): Remove.
2438 (catchlist, handlerlist, mark_backtrace):
2439 Declare only if BYTE_MARK_STACK.
2440 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2441 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2442 (message_enable_multibyte): Remove decl.
2443 (free_misc, interval_free_list, float_block, float_block_index):
2444 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2445 (cons_free_list, last_marked_index):
2446 Now static.
2447 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2448 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2449 (mark_backtrace): Define only if BYTE_MARK_STACK.
2450 * xdisp.c (message_enable_multibyte): Now static.
2451
61c2b50e 2452 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2453 This makes it easier for human readers (and static analyzers)
2454 to see whether these variables are used from other modules.
2455 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2456 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2457 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2458 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2459 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2460 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2461 * xmenu.c, xselect.c:
2462 Declare Q* vars static if they are not used in other modules.
2463 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2464 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2465 Remove decls of unexported vars.
2466 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2467
95c82688
PE
2468 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2469
16a97296
PE
2470 Make Emacs functions such as Fatom 'static' by default.
2471 This makes it easier for human readers (and static analyzers)
2472 to see whether these functions can be called from other modules.
2473 DEFUN now defines a static function. To make the function external
2474 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2475 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2476 (Finit_image_library):
16a97296
PE
2477 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2478 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2479 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2480 Remove decls, since these functions are now static.
2481 (Funintern, Fget_internal_run_time): New decls, since these functions
2482 were already external.
95c82688 2483
16a97296
PE
2484 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2485 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2486 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2487 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2488 * keyboard.c, keymap.c, lread.c:
2489 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2490 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2491 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2492 Mark functions with DEFUE instead of DEFUN,
2493 if they are used in other modules.
2494 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2495 decls for now-static functions.
2496 * buffer.h (Fdelete_overlay): Remove decl.
2497 * callproc.c (Fgetenv_internal): Mark as internal.
2498 * composite.c (Fremove_list_of_text_properties): Remove decl.
2499 (Fcomposition_get_gstring): New forward static decl.
2500 * composite.h (Fcomposite_get_gstring): Remove decl.
2501 * dired.c (Ffile_attributes): New forward static decl.
2502 * doc.c (Fdocumntation_property): New forward static decl.
2503 * eval.c (Ffetch_bytecode): New forward static decl.
2504 (Funintern): Remove extern decl; now in .h file where it belongs.
2505 * fileio.c (Fmake_symbolic_link): New forward static decl.
2506 * image.c (Finit_image_library): New forward static decl.
2507 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2508 * intervals.h (Fprevious_property_change):
2509 (Fremove_list_of_text_properties): Remove decls.
2510 * keyboard.c (Fthis_command_keys): Remove decl.
2511 (Fcommand_execute): New forward static decl.
2512 * keymap.c (Flookup_key): New forward static decl.
2513 (Fcopy_keymap): Now static.
2514 * keymap.h (Flookup_key): Remove decl.
2515 * process.c (Fget_process): New forward static decl.
2516 (Fprocess_datagram_address): Mark as internal.
2517 * syntax.c (Fsyntax_table_p): New forward static decl.
2518 (skip_chars): Remove duplicate decl.
2519 * textprop.c (Fprevious_property_change): New forward static decl.
2520 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2521 Now internal.
2522 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2523 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2524
785bbd42
PE
2525 * editfns.c (Fformat): Remove unreachable code.
2526
8b913b57
AS
25272011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2528
2529 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2530 change. (Bug#8496)
2531
a6744a35
EZ
25322011-04-13 Eli Zaretskii <eliz@gnu.org>
2533
2534 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2535 when at ZV. (Bug#8487)
2536
e7974947
AS
25372011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2538
baad03f0
AS
2539 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2540 (Bug#8437)
2541 * keyboard.c (parse_tool_bar_item): Likewise.
2542 * sound.c (sound_cleanup, alsa_close): Likewise.
2543 * termcap.c (tgetent): Likewise.
2544 * xfns.c (x_default_font_parameter): Likewise.
2545 * xsettings.c (read_and_apply_settings): Likewise.
2546
e7974947
AS
2547 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2548 (overrun_check_free): Protoize.
2549
28272684
PE
25502011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2553 since callers should never pass a negative size.
2554 Change the signature to match that of plain 'read' and 'write'; see
2555 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2556 * lisp.h: Update prototypes of emacs_write and emacs_read.
2557
11997c76
EZ
25582011-04-11 Eli Zaretskii <eliz@gnu.org>
2559
2560 * xdisp.c (redisplay_window): Don't try to determine the character
2561 position of the scroll margin if the window start point w->startp
e896f03c 2562 is outside the buffer's accessible region. (Bug#8468)
11997c76 2563
8a2cbd72
EZ
25642011-04-10 Eli Zaretskii <eliz@gnu.org>
2565
2566 Fix write-region and its subroutines for buffers > 2GB.
2567 * fileio.c (a_write, e_write): Modify declaration of arguments and
2568 local variables to support buffers larger than 2GB.
2569 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2570
2571 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2572 argument, local variables, and return value.
2573
2574 * lisp.h: Update prototypes of emacs_write and emacs_read.
2575
2576 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2577
4073e537 25782011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2579
1ebfdcb6
PE
2580 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2581
b2ded58d
PE
2582 Fix more problems found by GCC 4.6.0's static checks.
2583
7d66342c
PE
2584 * xdisp.c (vmessage): Use a better test for character truncation.
2585
bbf47d44
PE
2586 * charset.c (load_charset_map): <, not <=, for optimization,
2587 and to avoid potential problems with integer overflow.
9248994d 2588 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2589 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2590 * editfns.c (Fformat): Likewise.
1e69125e 2591 * syntax.c (skip_chars): Likewise.
3befa583 2592
e3019616
PE
2593 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2594 This also lets GCC 4.6.0 generate slightly better loop code.
2595
becfa255
PE
2596 * callint.c (Fcall_interactively): <, not <=, for optimization.
2597 (Fcall_interactively): Count the number of arguments produced,
2598 not the number of arguments given. This is simpler and lets GCC
2599 4.6.0 generate slightly better code.
2600
dae0cd48
PE
2601 * ftfont.c: Distingish more carefully between FcChar8 and char.
2602 The previous code passed unsigned char * to a functions like
2603 strlen and xstrcasecmp that expect char *, which does not
2604 conform to the C standard.
2605 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2606 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2607 char * when the C standard requires it.
2608
76032d70
PE
2609 * keyboard.c (read_char): Remove unused var.
2610
eb3f1cc8
PE
2611 * eval.c: Port to Windows vsnprintf (Bug#8435).
2612 Include <limits.h>.
2613 (SIZE_MAX): Define if the headers do not.
2614 (verror): Do not give up if vsnprintf returns a negative count.
2615 Instead, grow the buffer. This ports to Windows vsnprintf, which
2616 does not conform to C99. Problem reported by Eli Zaretskii.
2617 Also, simplify the allocation scheme, by avoiding the need for
2618 calling realloc, and removing the ALLOCATED variable.
2619
70476b54
PE
2620 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2621
12020a9e
PE
2622 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2623 But keep the doprint source code for now, as we might revamp it
2624 and use it again (Bug#8435).
ea6c7ae6
PE
2625 * lisp.h (doprnt): Remove.
2626 * Makefile.in (base_obj): Remove doprnt.o.
2627 * deps.mk (doprnt.o): Remove.
2628
5fdb398c
PE
2629 error: Print 32- and 64-bit integers portably (Bug#8435).
2630 Without this change, on typical 64-bit hosts error ("...%d...", N)
2631 was used to print both 32- and 64-bit integers N, which relied on
2632 undefined behavior.
2633 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2634 New macro.
2635 * lisp.h (error, verror): Mark as printf-like functions.
2636 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2637 Report overflow in size calculations when allocating printf buffer.
2638 Do not truncate output string at its first null byte.
2639 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2640 Truncate the output at a character boundary, since vsnprintf does not
2641 do that.
2642 * charset.c (check_iso_charset_parameter): Convert internal
2643 character to string before calling 'error', since %c now has the
2644 printf meaning.
2645 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2646 overflow when computing char to be passed to 'error'. Do not
2647 pass Lisp_Object to 'error'; pass the integer instead.
2648 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2649 formatted with plain %d.
2650
b189fa66
PE
2651 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2652
bff87ef0
PE
2653 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2654
7e2cac20
PE
2655 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2656
ce4d90b5
PE
2657 * xterm.c (x_catch_errors): Remove duplicate declaration.
2658
266c9547
PE
2659 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2660
79c49ad2
PE
2661 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2662
368f4090
JM
26632011-04-10 Jim Meyering <meyering@redhat.com>
2664
2665 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2666 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2667 return ssize_t not "int", and use size_t as the buffer length.
2668 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2669 * gnutls.h: Update declarations.
2670 * process.c (read_process_output): Use ssize_t, to match.
2671 (send_process): Likewise.
2672
a32d4040
CY
26732011-04-09 Chong Yidong <cyd@stupidchicken.com>
2674
2675 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2676
8546720e 26772011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2678
04f2d78b
CB
2679 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2680 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2681
8546720e
GM
2682 * xterm.c (handle_one_xevent):
2683 * xmenu.c (create_and_show_popup_menu):
2684 * xselect.c (x_decline_selection_request)
2685 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2686
0a2f5c1a 26872011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2688
2689 Fix some uses of `int' instead of EMACS_INT.
2690 * search.c (string_match_1, fast_string_match)
2691 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2692 (scan_buffer, find_next_newline_no_quit)
2693 (find_before_next_newline, search_command, Freplace_match)
2694 (Fmatch_data): Make some `int' variables be EMACS_INT.
2695
2696 * xdisp.c (display_count_lines): 3rd argument and return value now
2697 EMACS_INT. All callers changed.
2698 (pint2hrstr): Last argument is now EMACS_INT.
2699
2700 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2701 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2702 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2703 (decode_coding_utf_16, decode_coding_emacs_mule)
2704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2705 (decode_coding_ccl, decode_coding_charset)
2706 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2707 (decode_coding_iso_2022, decode_coding_emacs_mule)
2708 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2709 <char_offset, last_offset>: Declare EMACS_INT.
2710 (encode_coding_utf_8, encode_coding_utf_16)
2711 (encode_coding_emacs_mule, encode_invocation_designation)
2712 (encode_designation_at_bol, encode_coding_iso_2022)
2713 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2714 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2715 Declare EMACS_INT.
2716 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2717 (encode_invocation_designation): Last argument P_NCHARS is now
2718 EMACS_INT.
2719 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2720 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2721
2722 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2723 All users changed.
2724
2725 * ccl.c (Fccl_execute_on_string): Declare some variables
2726 EMACS_INT.
2727
8546720e 27282011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2729
2730 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2731
4e19a977
CS
27322011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2733
2734 * process.c (Fformat_network_address): Doc fix.
2735
87302331
R
27362011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2737
2738 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2739
cbb59342
CY
27402011-04-08 Chong Yidong <cyd@stupidchicken.com>
2741
2742 * keyboard.c (read_char): Call Lisp function help-form-show,
2743 instead of using internal_with_output_to_temp_buffer.
2744 (Qhelp_form_show): New var.
e0d38eeb 2745 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2746
2747 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2748
2749 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2750
e67a13ab
CY
27512011-04-06 Chong Yidong <cyd@stupidchicken.com>
2752
04f2d78b
CB
2753 * process.c (Flist_processes): Remove to Lisp.
2754 (list_processes_1): Delete.
e67a13ab 2755
973f782d
EZ
27562011-04-06 Eli Zaretskii <eliz@gnu.org>
2757
7c106b1e
EZ
2758 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2759
973f782d
EZ
2760 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2761
41cf7d1a 27622011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2763
ca23cc88
PE
2764 Fix more problems found by GCC 4.6.0's static checks.
2765
f390e2d5
PE
2766 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2767
42eea0d0
PE
2768 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2769
b69769da 2770 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2771
f9541e84
PE
2772 * xdisp.c (vmessage): Mark as a printf-like function.
2773
13841b55
PE
2774 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2775
c136c10f
PE
2776 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2777
5e2d4a30
PE
2778 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2779 printf-like functions.
2780 (tiff_load): Add casts to remove these marks before passing them
2781 to system-supplied API.
2782
583f48b9
PE
2783 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2784
b25d760e
PE
2785 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2786 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2787 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2788 directly, rather than having caller test rule sign. This avoids
2789 some unnecessary tests.
2790 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2791 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2792 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2793
bc7b6697 2794 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2795 (xfont_open): Avoid unnecessary tests.
bc7b6697 2796
27ccc379
PE
2797 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2798
dcd5c89a
PE
2799 * composite.h, composite.c (composition_gstring_put_cache):
2800 Use EMACS_INT, not int, for length.
2801
b13a45c6
PE
2802 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2803 breaking out part of COMPOSITION_DECODE_RULE.
2804 (COMPOSITION_DECODE_RULE): Use it.
2805 * composite.c (get_composition_id): Remove unused local vars,
2806 by using the new macro.
2807
1e792e4d
PE
2808 * textprop.c (set_text_properties_1): Change while to do-while,
2809 since the condition is always true at first.
2810
dc6c6455 2811 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2812 (interval_deletion_adjustment): Return unsigned value.
2813 All uses changed.
dc6c6455 2814
aba7731a
PE
2815 * process.c (list_processes_1, create_pty, read_process_output):
2816 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2817 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2818 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2819 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2820 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2821
fdfc4bf3
PE
2822 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2823
fca8fe46 2824 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2825 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2826
06a0259a 2827 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2828 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2829 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2830
e7b9e80f
PE
2831 * print.c (print_error_message): Avoid int overflow.
2832
56201685
PE
2833 * font.c (font_list_entities): Redo for clarity,
2834 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2835
78834453 2836 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2837 (font_score): Avoid potential overflow in diff calculation.
78834453 2838
0bc0b309 2839 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2840 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2841
e610eaca
PE
2842 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2843
b895abce
PE
2844 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2845 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2846 can always succeed if overflow has undefined behavior.
2847
1f1d9321 2848 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2849 (wordify): Omit three unnecessary tests.
1f1d9321 2850
c59478bc
PE
2851 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2852 All callers changed. This avoids the need for an unused var.
2853
79b73827
PE
2854 * casefiddle.c (casify_region): Remove var that is set but not used.
2855
a4db5dfe
PE
2856 * dired.c (file_name_completion): Remove var that is set but not used.
2857
43aae36e
PE
2858 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2859
2a47c44d 2860 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2861 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2862
a37c69bf
PE
2863 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2864 Check for integer overflow on size calculations.
2865
328ab8e7
PE
2866 * buffer.c (Fprevious_overlay_change): Remove var that is set
2867 but not used.
2868
e5a2a5cb
PE
2869 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2870 Remove vars that are set but not used.
8d84a6eb 2871 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2872 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2873
a60e5f68
PE
2874 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2875
f661cb61 2876 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2877 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2878
f0397f5a
PE
2879 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2880 that are set but not used.
2881
8664db06 2882 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2883 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2884
6abdaa4a
PE
2885 * xselect.c (x_get_local_selection, x_handle_property_notify):
2886 Remove vars that are set but not used.
2887
0ce7538d 2888 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2889 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2890
9ae848fc
PE
2891 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2892 Remove var that is set but not used.
0b918413
PE
2893 (scroll_bar_windows_size): Now size_t, not int.
2894 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2895 Check for overflow.
9ae848fc 2896
a5a62657
PE
2897 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2898 (map_tty_color) [!defined MSDOS]: Likewise.
2899
5c5cdd39
PE
2900 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2901
66ebf983
PE
2902 * coding.c: Remove vars that are set but not used.
2903 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2904 All callers changed.
2905 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2906 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2907 (decode_coding_charset): Remove vars that are set but not used.
2908
1be4d761
PE
2909 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2910 that is set but not used.
2911
47553fa8
PE
2912 * print.c (print_object): Remove var that is set but not used.
2913
1f7196bf 2914 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2915 The gnulib version avoids calling malloc in the usual case,
2916 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2917 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2918 * filelock.c (current_lock_owner): Likewise.
2919 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2920 * sysdep.c: Include allocator.h, careadlinkat.h.
2921 (emacs_no_realloc_allocator): New static constant.
2922 (emacs_readlink): New function.
fdb61804
PE
2923 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2924 ../lib/careadlinkat.h.
d1fdcab7 2925
f84c17c7
SM
29262011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2927
2928 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2929 first non-nil return value).
2930
ef3862ad
JD
29312011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2932
2933 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2934 if not defined (Bug#8403).
2935
376a7006
JB
29362011-04-02 Juanma Barranquero <lekktu@gmail.com>
2937
2938 * xdisp.c (display_count_lines): Remove parameter `start',
2939 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2940 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2941 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2942 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2943 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2944 and thereabouts. All callers changed.
2945 (get_per_char_metric): Remove parameter `f', unused since
2946 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2947
6ca3801d
JM
29482011-04-02 Jim Meyering <meyering@redhat.com>
2949
2950 do not dereference NULL upon failed strdup
2951 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2952 (ns_get_family): Likewise.
2953
d8e2b5ba
JB
29542011-04-02 Juanma Barranquero <lekktu@gmail.com>
2955
2956 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2957
8c74fcbd
JD
29582011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2959
2960 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2961 later (Bug#8403).
2962
7200d79c
SM
29632011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2964
03408648 2965 Add lexical binding.
7200d79c 2966
03408648
SM
2967 * window.c (Ftemp_output_buffer_show): New fun.
2968 (Fsave_window_excursion):
2969 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2970
2971 * lread.c (lisp_file_lexically_bound_p): New function.
2972 (Fload): Bind Qlexical_binding.
2973 (readevalloop): Remove `evalfun' arg.
2974 Bind Qinternal_interpreter_environment.
2975 (Feval_buffer): Bind Qlexical_binding.
2976 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2977 Mark as dynamic.
2978 (syms_of_lread): Declare `lexical-binding'.
2979
2980 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2981
2982 * keyboard.c (eval_dyn): New fun.
2983 (menu_item_eval_property): Use it.
ca105506
SM
2984
2985 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2986
03408648
SM
2987 * fns.c (concat, mapcar1): Accept byte-code-functions.
2988
2989 * eval.c (Fsetq): Handle lexical vars.
2990 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2991 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2992 (FletX, Flet): Obey lexical binding.
2993 (Fcommandp): Handle closures.
2994 (Feval): New `lexical' arg.
2995 (eval_sub): New function extracted from Feval. Use it almost
2996 everywhere where Feval was used. Look up vars in lexical env.
2997 Handle closures.
2998 (Ffunctionp): Move from subr.el.
2999 (Ffuncall): Handle closures.
3000 (apply_lambda): Remove `eval_flags'.
3001 (funcall_lambda): Handle closures and new byte-code-functions.
3002 (Fspecial_variable_p): New function.
3003 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3004 but without exporting it to Lisp.
23aba0ea 3005
23aba0ea 3006 * doc.c (Fdocumentation, store_function_docstring):
03408648 3007 * data.c (Finteractive_form): Handle closures.
23aba0ea 3008
03408648
SM
3009 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3010 interactive spec.
ba83908c 3011
04f2d78b
CB
3012 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3013 New byte-codes.
03408648
SM
3014 (exec_byte_code): New function extracted from Fbyte_code to handle new
3015 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3016
03408648 3017 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3018
03408648 3019 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3020
e2abce01
JB
30212011-03-31 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * xdisp.c (redisplay_internal): Fix prototype.
3024
63696a73 30252011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3026
63696a73 3027 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3028 (try_scrolling): Use it when setting scroll_limit.
3029 Limit scrolling to 100 screen lines.
63696a73
EZ
3030 (redisplay_window): Even when falling back on "recentering",
3031 position point in the window according to scroll-conservatively,
3032 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3033
3034 (try_scrolling): When point is above the window, allow searching
3035 as far as scroll_max, or one screenful, to compute vertical
3036 distance from PT to the scroll margin position. This prevents
3037 try_scrolling from unnecessarily failing when
3038 scroll-conservatively is set to a value slightly larger than the
3039 window height. Clean up the case of PT below the margin at bottom
3040 of window: scroll_max can no longer be INT_MAX. When aggressive
3041 scrolling is in use, don't let point enter the opposite scroll
3042 margin as result of the scroll.
3043 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3044 threshold of 100 lines for never-recentering scrolling.
3045
e4cc2dfc
JB
30462011-03-31 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * dispextern.h (move_it_by_lines):
3049 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3050 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3051 (message_log_check_duplicate): Remove parameters `prev_bol' and
3052 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3053 (redisplay_internal): Remove parameter `preserve_echo_area',
3054 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3055
3056 * indent.c (Fvertical_motion):
3057 * window.c (window_scroll_pixel_based, Frecenter):
3058 Don't pass `need_y_p' to `move_it_by_lines'.
3059
1c470562
SM
30602011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3061
44f230aa
SM
3062 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3063 steal a few bits to be more compact.
3064 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3065 Remove unneeded casts.
3066
1c470562
SM
3067 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3068
888adce9
ZK
30692011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3070
3071 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3072 binding" message (bug#7967).
3073
f838ed7b
PE
30742011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3075
77861b95
PE
3076 Fix more problems found by GCC 4.6.0's static checks.
3077
de6dbc14
PE
3078 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3079 Remove unused local var.
3080
f838ed7b
PE
3081 * editfns.c (Fmessage_box): Remove unused local var.
3082
792c7b2b
PE
3083 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3084 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3085 Omit unused local vars.
c499e557 3086 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3087 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3088 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3089 Omit unused local var.
3090
ba0165e1
PE
3091 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3092 Don't assume string length fits in int.
32ad8845 3093 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3094 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3095
3c59b4c9
PE
3096 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3097 instead of alloca (Bug#8344).
3098
a3eed478 3099 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3100 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3101
eb4d412d
PE
3102 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3103
1658b401
PE
3104 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3105 concerns.
3106
3107 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3108
3109 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3110
9a2c6e05
PE
3111 * keyboard.c (syms_of_keyboard): Use the same style as later
3112 in this function when indexing through an array. This also
3113 works around GCC bug 48267.
3114
03d0a109
PE
3115 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3116
44f730c8
PE
3117 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3118
fe75f926
PE
3119 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3120 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3121
ffa8c828
PE
3122 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3123 This avoids undefined behavior on integer overflow, and is a bit
3124 more convenient anyway since it is compared to a size_t variable.
3125
c5101a77
PE
3126 Variadic C functions now count arguments with size_t, not int.
3127 This avoids an unnecessary limitation on 64-bit machines, which
3128 caused (substring ...) to crash on large vectors (Bug#8344).
3129 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3130 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3131 All variadic functions and their callers changed accordingly.
c5101a77
PE
3132 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3133 * data.c (arith_driver, float_arith_driver): Likewise.
3134 * editfns.c (general_insert_function): Likewise.
3135 * eval.c (struct backtrace.nargs, interactive_p)
3136 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3137 (funcall_lambda, mark_backtrace): Likewise.
3138 * fns.c (concat): Likewise.
3139 * frame.c (x_set_frame_parameters): Likewise.
3140 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3141 0 if not found, not -1. All callers changed.
3142
dd3f25f7
PE
3143 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3144 (stack_copy_size): Now size_t, not int.
3145 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3146
461c2ab9
JB
31472011-03-28 Juanma Barranquero <lekktu@gmail.com>
3148
3149 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3150 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3151 All callers changed.
3152
3153 * lisp.h (multibyte_char_to_unibyte):
3154 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3155 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3156 * character.h (CHAR_TO_BYTE8):
3157 * cmds.c (internal_self_insert):
3158 * editfns.c (general_insert_function):
3159 * keymap.c (push_key_description):
3160 * search.c (Freplace_match):
3161 * xdisp.c (message_dolog, set_message_1): All callers changed.
3162
f6d62986
SM
31632011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3164
3165 * keyboard.c (safe_run_hook_funcall): New function.
3166 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3167 don't set the hook to nil, but remove the offending function instead.
3168 (Qcommand_hook_internal): Remove, unused.
3169 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3170 Vcommand_hook_internal.
3171
3172 * eval.c (enum run_hooks_condition): Remove.
3173 (funcall_nil, funcall_not): New functions.
3174 (run_hook_with_args): Call each function through a `funcall' argument.
3175 Remove `cond' argument, now redundant.
3176 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3177 (Frun_hook_with_args_until_failure): Adjust accordingly.
3178 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3179
1db5b1ad
JB
31802011-03-28 Juanma Barranquero <lekktu@gmail.com>
3181
3182 * dispextern.h (string_buffer_position): Remove declaration.
3183
3184 * print.c (strout): Remove parameter `multibyte', unused since
3185 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3186
3187 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3188 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3189 All callers changed.
3190
3191 * w32.c (_wsa_errlist): Use braces for struct initializers.
3192
3193 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3194 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3195 All callers changed.
3196 (string_buffer_position): Likewise. Also, make static (it's never
3197 used outside xdisp.c).
3198 (cursor_row_p): Remove parameter `w', unused since
3199 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3200 (decode_mode_spec): Remove parameter `precision', introduced during
3201 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3202 All callers changed.
3203
5ffb62aa
JD
32042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3205
3206 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3207
461c2ab9 32082011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3209
3210 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3211 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3212 (ns_update_auto_hide_menu_bar): New functions.
3213 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3214 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3215 ns_constrain_all_frames.
3216 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3217 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3218
5c380ffb
JD
32192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3220
3221 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3222
9af30bdf
GM
32232011-03-27 Glenn Morris <rgm@gnu.org>
3224
3225 * syssignal.h: Replace RETSIGTYPE with void.
3226 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3227 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3228 Replace SIGTYPE with void everywhere.
3229 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3230 * s/template.h (SIGTYPE): Remove commented out definition.
3231
e2abce01
JB
32322011-03-26 Eli Zaretskii <eliz@gnu.org>
3233
3234 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3235 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3236
f868cd8a
JB
32372011-03-26 Juanma Barranquero <lekktu@gmail.com>
3238
59eb0929
JB
3239 * w32.c (read_unc_volume): Use parameter `henum', instead of
3240 global variable `wget_enum_handle'.
3241
3242 * keymap.c (describe_vector): Remove parameters `indices' and
3243 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3244 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3245
f868cd8a
JB
3246 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3247
3248 * keyboard.c (timer_check): Remove parameter `do_it_now',
3249 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3250 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3251 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3252
3253 * keyboard.c (read_char):
3254 * w32menu.c (w32_menu_display_help):
3255 * xmenu.c (show_help_event, menu_help_callback):
3256 Adjust calls to `show_help_echo'.
3257
3258 * gtkutil.c (xg_maybe_add_timer):
3259 * keyboard.c (readable_events):
3260 * process.c (wait_reading_process_output):
3261 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3262
3263 * insdel.c (adjust_markers_gap_motion):
3264 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3265 (gap_left, gap_right): Don't call it.
3266
2ecf6fdb
CY
32672011-03-25 Chong Yidong <cyd@stupidchicken.com>
3268
3269 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3270 incurred during fontification.
3271
6b1f9ba4
JB
32722011-03-25 Juanma Barranquero <lekktu@gmail.com>
3273
3274 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3275 (DEFVAR_PER_BUFFER): Don't pass it.
3276
3277 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3278 (scrolling_window): Don't pass it.
3279
0f4a96b5
JB
32802011-03-25 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3283
3284 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3285 and `suffix'.
3286 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3287 of variables specific to SELinux and computation of `encoded_absname'.
3288
3289 * image.c (XPutPixel): Remove unused variable `height'.
3290
3291 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3292
3293 * unexw32.c (get_section_info): Remove unused variable `section'.
3294
3295 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3296 (system_process_attributes): Remove unused variable `sess'.
3297 (sys_read): Remove unused variable `err'.
3298
3299 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3300 (w32_wnd_proc): Remove unused variable `isdead'.
3301 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3302 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3303 (x_create_tip_frame): Remove unused variable `tem'.
3304
3305 * w32inevt.c (w32_console_read_socket):
3306 Remove unused variable `no_events'.
3307
3308 * w32term.c (x_draw_composite_glyph_string_foreground):
3309 Remove unused variable `width'.
3310
1149507c
JB
33112011-03-24 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * w32term.c (x_set_glyph_string_clipping):
3314 Don't pass uninitialized region to CombineRgn.
3315
9c88f339
JB
33162011-03-23 Juanma Barranquero <lekktu@gmail.com>
3317
3318 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3319 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3320 (Fx_close_connection): Remove unused variable `i'.
3321
3322 * w32font.c (w32font_draw): Return number of glyphs.
3323 (w32font_open_internal): Remove unused variable `i'.
3324 (w32font_driver): Add missing initializer.
3325
3326 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3327 (fill_in_menu): Remove unused variable `items_added'.
3328
3329 * w32term.c (last_mouse_press_frame): Remove static global variable.
3330 (w32_clip_to_row): Remove unused variable `f'.
3331 (x_delete_terminal): Remove unused variable `i'.
3332
3333 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3334 (NOTHING): Remove unused static global variable.
3335 (uniscribe_check_otf): Remove unused variable `table'.
3336 (uniscribe_font_driver): Add missing initializers.
3337
dee091a3
JD
33382011-03-23 Julien Danjou <julien@danjou.info>
3339
3340 * term.c (Fsuspend_tty, Fresume_tty):
3341 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3342 * window.c (temp_output_buffer_show):
3343 * insdel.c (signal_before_change):
3344 * frame.c (Fhandle_switch_frame):
3345 * fileio.c (Fdo_auto_save):
3346 * emacs.c (Fkill_emacs):
3347 * editfns.c (save_excursion_restore):
3348 * cmds.c (internal_self_insert):
3349 * callint.c (Fcall_interactively):
3350 * buffer.c (Fkill_all_local_variables):
3351 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3352 Use Frun_hooks.
0f4a96b5 3353 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3354 unconditionnaly since it does the check itself.
3355
2c520ab5 33562011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3357
c9c49752
PE
3358 Fix more problems found by GCC 4.5.2's static checks.
3359
8abc3f12
PE
3360 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3361 the first time through the loop, since we know p0 < p1 then.
3362 This also avoids a gcc -Wstrict-overflow warning.
3363
a2d26660
PE
3364 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3365 leading to a memory leak, possible in functions like
3366 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3367 of objects (Bug#8318).
a2d26660 3368
916c72e9
PE
3369 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3370 that could (at least in theory) be that large.
3371
19ab8a18
PE
3372 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3373 This is less likely to overflow, and avoids undefined behavior if
3374 overflow does occur. All callers changed. Use strtoul to scan
3375 for the unsigned long integer.
b7cbbd6f
PE
3376 (pint2hrstr): Simplify and tune code slightly.
3377 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3378
f0641eff
PE
3379 * scroll.c (do_scrolling): Work around GCC bug 48228.
3380 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3381
7f650bb9
PE
3382 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3383 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3384 (validate_x_resource_name): Simplify count usage.
3385 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3386
37dd57d1
PE
3387 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3388 fail (Bug#8306).
81e56e61 3389
699979fc 3390 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3391
401bf9b4
PE
3392 * process.c (Fmake_network_process): Use socklen_t, not int,
3393 where POSIX says socklen_t is required in portable programs.
3394 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3395 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3396 (Fmake_network_process, server_accept_connection):
3397 (wait_reading_process_output, read_process_output):
3398 Likewise.
3399
b93aacde
PE
3400 * process.c: Rename or move locals to avoid shadowing.
3401 (list_processes_1, Fmake_network_process):
3402 (read_process_output_error_handler, exec_sentinel_error_handler):
3403 Rename or move locals.
4dc343ee 3404 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3405 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3406 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3407 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3408 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3409
af8a867c 3410 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3411 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3412 Include tparam.h instead, since it declares them.
af8a867c
PE
3413 * cm.h (PC): Remove extern decl; tparam.h now does this.
3414 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3415 * terminfo.c: Include tparam.h, to check interfaces.
3416 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3417 (tparam): Adjust signature to match interface in tparam.h;
3418 this removes some undefined behavior. Check that outstring and len
3419 are zero, which they always are with Emacs.
3420 * tparam.h (PC, BC, UP): New extern decls.
3421
0248044d 3422 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3423 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3424
8ff096c1 3425 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3426 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3427 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3428 (ftfont_list): Remove unused local.
49eaafba
PE
3429 (get_adstyle_property, ftfont_pattern_entity):
3430 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3431 Rename locals to avoid shadowing.
8ff096c1 3432
e2be39f6
PE
3433 * xfont.c (xfont_list_family): Mark var as initialized.
3434
c9735e30
PE
3435 * xml.c (make_dom): Now static.
3436
8f5201ae
PE
3437 * composite.c (composition_compute_stop_pos): Rename local to
3438 avoid shadowing.
b246f932
PE
3439 (composition_reseat_it): Remove unused locals.
3440 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3441 (composition_update_it): Mark var as initialized.
11b61122
PE
3442 (find_automatic_composition): Mark vars as initialized,
3443 with a FIXME (Bug#8290).
8f5201ae 3444
760fbc2c
PE
3445 character.h: Rename locals to avoid shadowing.
3446 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3447 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3448 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3449 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3450 to avoid shadowing.
3451
ff08eb85
PE
3452 * textprop.c (property_change_between_p): Remove; unused.
3453
fc7bf025
PE
3454 * intervals.c (interval_start_pos): Now static.
3455
235d7abc
PE
3456 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3457
44f230aa
SM
3458 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3459 Rename locals to avoid shadowing.
3e7d6594 3460
50060332
PE
3461 * sound.c (wav_play, au_play, Fplay_sound_internal):
3462 Fix pointer signedness.
d01f234b 3463 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3464 (wav_play): Initialize a variable to 0, to prevent undefined
3465 behavior (Bug#8278).
50060332 3466
c4fc4e30
PE
3467 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3468
918436ed
PE
3469 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3470
c939f91b
PE
3471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3472 clobbering (Bug#8298).
b9c7f648
PE
3473 * sysdep.c (sys_subshell): Likewise.
3474 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3475
6bd8c144
PE
3476 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3477 This should get cleaned up, so that child_setup has the
3478 same signature on all platforms.
3479
7710357c 3480 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3481 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3482
c59da222
CY
34832011-03-22 Chong Yidong <cyd@stupidchicken.com>
3484
3485 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3486 not to be necessary, and produces flickering.
3487
66b87493
GM
34882011-03-20 Glenn Morris <rgm@gnu.org>
3489
3490 * config.in: Remove file.
3491
45b6f6d5
JB
34922011-03-20 Juanma Barranquero <lekktu@gmail.com>
3493
3494 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3495 are now in src/globals.h.
3496 (syms_of_minibuf): Remove spurious & from previous change.
3497
3ec03f7e
LL
34982011-03-20 Leo <sdl.web@gmail.com>
3499
3500 * minibuf.c (completing-read-function): New variable.
3501 (completing-read-default): Rename from completing-read.
3502 (completing-read): Call completing-read-function.
3503
b14e3e21
CY
35042011-03-19 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * xfaces.c (Fx_load_color_file):
3507 Read color file from absolute filename (bug#8250).
3508
f2b726e6
JB
35092011-03-19 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * makefile.w32-in: Update dependencies.
3512
09f6ff02
EZ
35132011-03-17 Eli Zaretskii <eliz@gnu.org>
3514
3515 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3516
29a6015a
PE
35172011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3518
a3a6c54e
PE
3519 Fix more problems found by GCC 4.5.2's static checks.
3520
b766f867
PE
3521 * process.c (make_serial_process_unwind, send_process_trap):
3522 (sigchld_handler): Now static.
3523
be02381c
PE
3524 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3525 That way, the code declares only the vars that it needs.
3526 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3527 * s/cygwin.h (PTY_ITERATION): Likewise.
3528 * s/darwin.h (PTY_ITERATION): Likewise.
3529 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3530
57048744
PE
3531 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3532 * process.c (allocate_pty): Don't declare stb unless it's needed.
3533
7914961c 3534 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3535 (CONSTANTLIM): Remove; unused.
3536 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3537 Define only if needed.
7914961c 3538
b3967b18
PE
3539 * unexelf.c (unexec): Name an expression,
3540 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3541 Use a different way to cause a compilation error if anyone uses
3542 n rather than nn, a way that does not involve shadowing.
73366a00 3543 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3544
29a6015a
PE
3545 * deps.mk (unexalpha.o): Remove; unused.
3546
43cfc33e 3547 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3548 * unexec.h: New file.
ce701a33
PE
3549 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3550 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3551 Depend on unexec.h.
3552 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3553 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3554 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3555 Change as necessary to match prototype in unexec.h.
ce701a33 3556
01f44d5a
PE
3557 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3558 shadowing.
4f63c6bb 3559 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3560
a6670b0b
PE
3561 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3562 Rename locals to avoid shadowing.
3563
cef2010d 3564 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3565 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3566
d4d7173a
PE
3567 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3568
f08b802a
PE
3569 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3570 warning when compiling print.c.
3571
3ddb0639
PE
3572 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3573 instead of using an uninitialized var.
5ad03b97 3574 (font_sort_entities): Mark var as initialized.
3ddb0639 3575
170a2692
PE
3576 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3577
e663c700
PE
3578 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3579 pointers to constants.
89bc529a 3580 (font_parse_fcname): Remove unused vars.
7b81e2d0 3581 (font_delete_unmatched): Now static.
ea838e10 3582 (font_get_spec): Remove; unused.
13a547c6
PE
3583 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3584 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3585 Rename or move locals to avoid shadowing.
e663c700 3586
2a80c887 3587 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3588 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3589
1384fa33 3590 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3591 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3592
8b2c52e9
PE
3593 * alloc.c (mark_backtrace): Move decl from here ...
3594 * lisp.h: ... to here, so that it can be checked.
3595
475545b5 3596 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3597 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3598 (lisp_indirect_variable): Name an expression,
3599 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3600 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3601
b1349114 3602 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3603 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3604 Use const pointer when appropriate.
b1349114 3605
a2928364
PE
3606 * lisp.h (get_system_name, get_operating_system_release):
3607 Move decls here, to check interfaces.
3608 * process.c (get_operating_system_release): Move decl to lisp.h.
3609 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3610 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3611 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3612 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3613 (Fformat_time_string, Fencode_time, Finsert_char):
3614 (Ftranslate_region_internal, Fformat):
3615 Rename or remove local vars to avoid shadowing.
9710023e 3616 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3617
a415e694
PE
3618 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3619 avoid shadowing.
3620
8ef4622d
PE
3621 * lisp.h (eassert): Check that the argument compiles, even if
3622 ENABLE_CHECKING is not defined.
3623
946f9a5b
PE
3624 * data.c (Findirect_variable): Name an expression, to avoid
3625 gcc -Wbad-function-cast warning.
112396d6 3626 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3627 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3628 (Fmake_variable_buffer_local, Fmake_local_variable):
3629 Mark variables as initialized.
52746918 3630 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3631
e5aab7e7 3632 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3633 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3634 Rename locals to avoid shadowing.
dff45157
PE
3635 (mark_stack): Move local variables into the #ifdef region where
3636 they're used.
7bc26fdb
PE
3637 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3638 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3639 needed otherwise.
3640 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3641 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3642 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3643
e5aab7e7
PE
3644 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3645 avoids undefined behavior in theory.
3646
4da60324
PE
3647 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3648
88043301
PE
3649 Use functions, not macros, for up- and down-casing (Bug#8254).
3650 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3651 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3652 to use the following functions instead of these macros.
3653 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3654 EMACS_INT, since callers assume the returned value fits in int.
3655 (upcase1): Likewise, for UPCASE_TABLE.
3656 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3657 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3658 the race-condition problem in the old DOWNCASE.
88043301 3659
19ed5445
PE
3660 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3661 Rename locals to avoid shadowing.
3662 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3663 (regex_compile, re_search_2, re_match_2_internal):
3664 Remove unused local vars.
952db0d7
PE
3665 (FREE_VAR): Rewrite so as not to use empty "else",
3666 which gcc can warn about.
da053e48 3667 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3668 (RETALLOC_IF): Define only if needed.
3669 (WORDCHAR_P): Likewise. This one is never needed, but is used
3670 only in a comment talking about a compiler bug, so put inside
3671 the #if 0 of that comment.
3672 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3673 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3674 Remove; unused.
19ed5445 3675
1f3561e4 3676 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3677 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3678 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3679
ded6f8f7
PE
3680 * search.c (simple_search): Remove unused var.
3681
dbd37a95
PE
3682 * dired.c (compile_pattern): Move decl from here ...
3683 * lisp.h: ... to here, so that it can be checked.
3684 (struct re_registers): New forward decl.
3685
7e47afad
PE
3686 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3687
85f24f61
PE
3688 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3689 All uses changed.
3690 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3691 Rename locals to avoid shadowing.
5671df8f 3692 (Fvertical_motion): Mark locals as initialized.
85f24f61 3693
181aa2be 3694 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3695 (casify_region): Mark local as initialized.
181aa2be 3696
930d429c
PE
3697 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3698
7082eac6
PE
3699 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3700 New macros, so that the caller can use some names other than
3701 gcpro1, gcpro2, etc.
3702 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3703 of the new macros.
3704 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3705 argument, for consistency with GCPRO2_VAR, etc: it is now the
3706 prefix of the variable, not the variable itself. All uses
3707 changed.
38b2c076
PE
3708 * dired.c (directory_files_internal, file_name_completion):
3709 Rename locals to avoid shadowing.
3710
15206ed9
PE
3711 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3712 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3713 dired.c's scmp function, had undefined behavior.
3714 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3716 * buffer.h: ... to here, because these macros use current_buffer,
3717 and the new implementation with inline functions needs to have
3718 current_buffer in scope now, rather than later when the macros
3719 are used.
3720 (downcase, upcase1): New static inline functions.
3721 (DOWNCASE, UPCASE1): Reimplement using these functions.
3722 This avoids undefined behavior in expressions like
3723 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3724 from race conditions in accessing the global variables
3725 case_temp1 and case_temp2.
3726 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3727 * lisp.h (case_temp1, case_temp2): Remove their decls.
3728 * character.h (ASCII_CHAR_P): Move from here ...
3729 * lisp.h: ... to here, so that the inline functions mentioned
3730 above can use them.
3731
4a6bea26
PE
3732 * dired.c (directory_files_internal_unwind): Now static.
3733
f14b7e14
PE
3734 * fileio.c (file_name_as_directory, directory_file_name):
3735 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3736 Now static.
2893f146
PE
3737 (file_name_as_directory): Use const pointers when appropriate.
3738 (Fexpand_file_name): Likewise. In particular, newdir might
3739 point at constant storage, so make it a const pointer.
fd4ead52 3740 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3741 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3742 signedness issues.
f839df0c
PE
3743 (Fset_file_times, Finsert_file_contents, auto_save_error):
3744 Rename locals to avoid shadowing.
f14b7e14 3745
5716756e 3746 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3747 (Ftry_completion, Fall_completions): Rename or remove locals
3748 to avoid shadowing.
5716756e 3749
b4c3046a
PE
3750 * marker.c (bytepos_to_charpos): Remove; unused.
3751
b45db522
PE
3752 * lisp.h (verify_bytepos, count_markers): New decls,
3753 so that gcc does not warn that these functions aren't declared.
3754
85876d07
PE
3755 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3756 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3757 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3758 (copy_text): Remove unused local var.
85876d07 3759
03d78a21 3760 * filelock.c (within_one_second): Now static.
b3dd38ab 3761 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3762
5df8f01b
PE
3763 * buffer.c (fix_overlays_before): Mark locals as initialized.
3764 (fix_start_end_in_overlays): Likewise. This function should be
3765 simplified by using pointers-to-pointers, but that's a different
3766 matter.
b1d876f1 3767 (switch_to_buffer_1): Now static.
8f54f30a
PE
3768 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3769 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3770
a70072c9 3771 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3772 Fix pointer signedness issue.
edced198
PE
3773 (sys_subshell): Mark local as volatile if checking for lint,
3774 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3775 (MAXPATHLEN): Define only if needed.
a70072c9 3776
a0977c44
PE
3777 * process.c (serial_open, serial_configure): Move decls from here ...
3778 * systty.h: ... to here, so that they can be checked.
3779
a884fdcc
PE
3780 * fns.c (get_random, seed_random): Move extern decls from here ...
3781 * lisp.h: ... to here, so that they can be checked.
3782
604efe86 3783 * sysdep.c (reset_io): Now static.
b8950c94 3784 (wait_for_termination_signal): Remove; unused.
604efe86 3785
38fc62d9
PE
3786 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3787 (copy_keymap_item, append_key, push_text_char_description):
3788 Now static.
1004a21a 3789 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3790 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3791 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3792 (describe_map_tree):
3793 Rename locals to avoid shadowing.
38fc62d9 3794
2f2650da
PE
3795 * keyboard.c: Declare functions static if they are not used elsewhere.
3796 (echo_char, echo_dash, cmd_error, top_level_2):
3797 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3798 (read_char, kbd_buffer_get_event, make_lispy_position):
3799 (make_lispy_event, make_lispy_movement, apply_modifiers):
3800 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3801 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3802 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3803 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3804 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3805
a053e86c 3806 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3807 (mark_kboards): Move decl here ...
3808 * alloc.c (mark_kboards): ... from here.
a053e86c 3809
4752793e
PE
3810 * lisp.h (force_auto_save_soon): New decl.
3811
74f10ca7 3812 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3813 (DEFINE_DUMMY_FUNCTION): New macro.
3814 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3815 Use it.
c03cd23f
PE
3816 (main): Add casts to avoid warnings
3817 if GCC considers string literals to be constants.
74f10ca7 3818
022e70d4
PE
3819 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3820
59d6fe83
PE
3821 * dbusbind.c: Pointer signedness fixes.
3822 (xd_signature, xd_append_arg, xd_initialize):
3823 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3824 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3825 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3826 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3827
78320123
PE
3828 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3829 if GCC considers string literals to be constants.
49cebcca 3830 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3831
35ac2a97
SM
38322011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3833
fb103ca9
SM
3834 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3835 (print_preprocess, print_object): New macro to fix last change.
3836
35ac2a97
SM
3837 * print.c (print_preprocess): Don't forget font objects.
3838
62973b41
JB
38392011-03-16 Juanma Barranquero <lekktu@gmail.com>
3840
3841 * emacs.c (USAGE3): Doc fixes.
3842
0e48bb22
AS
38432011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3844
3845 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3846 structure.
3847
7684e57b
JB
38482011-03-14 Juanma Barranquero <lekktu@gmail.com>
3849
3850 * lisp.h (VWindow_system, Qfile_name_history):
3851 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3852 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3853 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3854
3855 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3856 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3857
3858 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3859 * w32console.c (detect_input_pending, read_input_pending)
3860 (encode_terminal_code):
3861 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3862 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3863 (w32_system_caret_y, Qfile_name_history):
3864 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3865 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3866 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3867 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3868 * w32proc.c (Qlocal, report_file_error):
3869 * w32term.c (Vwindow_system, updating_frame):
3870 * w32uniscribe.c (initialized, uniscribe_font_driver):
3871 Remove unneeded extern declarations.
3872
2aa46d6c
CY
38732011-03-14 Chong Yidong <cyd@stupidchicken.com>
3874
c96bbc66 3875 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3876
cffc6f3b
CY
38772011-03-13 Chong Yidong <cyd@stupidchicken.com>
3878
3879 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3880 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3881 These macros can no longer be used for assignment.
3882
44f230aa
SM
3883 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3884 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3885 (record_buffer_markers, fetch_buffer_markers): New functions for
3886 recording and fetching special buffer markers.
3887 (set_buffer_internal_1, set_buffer_temp): Use them.
3888
3889 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3890
3891 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3892
3893 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3894 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3895
3896 * xdisp.c (hscroll_window_tree):
3897 (reconsider_clip_changes): Use PT instead of BUF_PT.
3898
d251f04b
EZ
38992011-03-13 Eli Zaretskii <eliz@gnu.org>
3900
3901 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3902 $(EMACS_ROOT)/lib/intprops.h.
3903
f0c77cd1
PE
39042011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3905
3eca4629
PE
3906 Fix more problems found by GCC 4.5.2's static checks.
3907
7c86ee98
PE
3908 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3909 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3910 (xg_free_frame_widgets): Make it clear that a local variable is
3911 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3912 (gdk_window_get_screen): Make it clear that this macro is needed
3913 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3914 (int_gtk_range_get_value): New function, which avoids a diagnostic
3915 from gcc -Wbad-function-cast.
3916 (xg_set_toolkit_scroll_bar_thumb): Use it.
3917 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3918 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3919 (get_utf8_string, xg_get_file_with_chooser):
3920 Rename locals to avoid shadowing.
3921 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3922
41729b81
PE
3923 * xgselect.c (xg_select): Remove unused var.
3924
f0c77cd1
PE
3925 * image.c (four_corners_best): Mark locals as initialized.
3926 (gif_load): Initialize transparent_p to zero (Bug#8238).
3927 Mark another local as initialized.
ec6cf4c6 3928 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3929
ce0ad53d 3930 * image.c (clear_image_cache): Now static.
d5d5a617 3931 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3932 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3933 (x_edge_detection): Remove unnecessary cast that
3934 gcc -Wbad-function-cast diagnoses.
2037898d 3935 (gif_load): Fix pointer signedness.
6ae141d6
PE
3936 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3937 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3938
33383987 39392011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3940
d32df629
PE
3941 Improve quality of tests for time stamp overflow.
3942 For example, without this patch (encode-time 0 0 0 1 1
3943 1152921504606846976) returns the obviously-bogus value (-948597
3944 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3945 reports time overflow. See
3946 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3947 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3948 * editfns.c: Include limits.h and intprops.h.
3949 (TIME_T_MIN, TIME_T_MAX): New macros.
3950 (time_overflow): Move earlier, to before first use.
3951 (hi_time, lo_time): New functions, for an accurate test for
3952 out-of-range times.
3953 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3954 (Fget_internal_run_time): Don't assume time_t fits in int.
3955 (make_time): Use list2 instead of Fcons twice.
3956 (Fdecode_time): More accurate test for out-of-range times.
3957 (check_tm_member): New function.
3958 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3959 (lisp_time_argument): Don't rely on undefined left-shift and
3960 right-shift behavior when checking for time stamp overflow.
8be6f318 3961
fe31d94c
PE
3962 * editfns.c (time_overflow): New function, refactoring common code.
3963 (Fformat_time_string, Fdecode_time, Fencode_time):
3964 (Fcurrent_time_string): Use it.
3965
8be6f318
PE
3966 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3967 * dired.c (make_time): Move to ...
3968 * editfns.c (make_time): ... here.
3969 * systime.h: Note the move.
3970
09d9db2c 39712011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3972
126bc0dc
YM
3973 * fringe.c (update_window_fringes): Remove unused variables.
3974
c47cbdfd
YM
3975 * unexmacosx.c (copy_data_segment): Also copy __got section.
3976 (Bug#8223)
3977
7ac80be9
EZ
39782011-03-12 Eli Zaretskii <eliz@gnu.org>
3979
c96bbc66 3980 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3981 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3982 Constify `char *' arguments and their references according to
3983 prototypes in tparam.h.
3984
ecb0f94d 3985 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3986
7ac80be9
EZ
3987 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3988 Adapt all references accordingly.
3989
3990 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3991
ef1fd07e
TT
39922011-03-11 Tom Tromey <tromey@redhat.com>
3993
3994 * buffer.c (syms_of_buffer): Remove obsolete comment.
3995
7ef4b50c
EZ
39962011-03-11 Eli Zaretskii <eliz@gnu.org>
3997
3998 * termhooks.h (encode_terminal_code): Declare prototype.
3999
4000 * msdos.c (encode_terminal_code): Don't declare prototype.
4001
4002 * term.c (encode_terminal_code): Now external again, used by
4003 w32console.c and msdos.c.
4004
44f230aa
SM
4005 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4006 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4007
4b1ec863 40082011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4009
1714f52b 4010 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4011
4b1ec863
PE
4012 * fringe.c (update_window_fringes): Mark locals as initialized
4013 (Bug#8227).
4014 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4015
524c7aa6
PE
4016 * alloc.c (mark_fringe_data): Move decl from here ...
4017 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4018 to check its interface.
4019 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4020
a5c0af81 4021 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4022 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4023 (fontset_font): Mark local as initialized.
a9a06e0b 4024 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4025
b4716021
PE
4026 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4027
811e9bac 4028 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4029 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4030 (x_own_selection, Fx_disown_selection_internal): Rename locals
4031 to avoid shadowing.
4032 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4033
7e3ab302
PE
4034 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4035 so that the caller can use some name other than gcpro1.
4036 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4037 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4038 (Fx_backspace_delete_keys_p):
4039 Use them to avoid shadowing, and rename vars to avoid shadowing.
4040 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4041 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4042 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4043 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4044 Remove unused locals.
7e3ab302
PE
4045 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4046 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4047 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4048 macros.
f78faa98 4049
e2b13473
PE
4050 * xterm.h (x_mouse_leave): New decl.
4051
77f23912
PE
4052 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4053 Remove unused functions.
cdf4ba58
PE
4054 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4055 (x_calc_absolute_position): Now static.
7411c686 4056 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4057 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4058 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4059 unless they are used.
38d0b34a
PE
4060 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4061 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4062 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4063 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4064 (x_error_catcher, x_connection_closed, x_error_handler):
4065 (x_error_quitter, xembed_send_message, x_iconify_frame):
4066 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4067 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4068 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4069
44f230aa
SM
4070 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4071 Rename or move locals to avoid shadowing.
6b463e58 4072 (tty_defined_color, merge_face_heights): Now static.
5967d051 4073 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4074 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4075 does not deduce is never used uninitialized.
73719eba
PE
4076 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4077 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4078
426994c3 4079 * terminal.c (store_terminal_param): Now static.
5489860b 4080
032f1620 4081 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4082 (set_frame_menubar): Remove unused local.
d4323972 4083 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4084 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4085 since they might point to immutable storage.
281585b0
PE
4086 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4087 since it's unused otherwise.
032f1620 4088
367c19e5 4089 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4090 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4091 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4092 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4093 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4094 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4095 does not deduce are never used uninitialized.
70739cbe 4096
07b48fa9
PE
4097 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4098
8868a238 4099 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4100 * window.c (window_loop, size_window):
4101 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4102
7e5cf297 4103 * window.c (display_buffer): Now static.
d6550a9f
PE
4104 (size_window): Mark variables that gcc -Wuninitialized
4105 does not deduce are never used uninitialized.
a586633d
PE
4106 * window.h (check_all_windows): New decl, to forestall
4107 gcc -Wmissing-prototypes diagnostic.
5b555da1 4108 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4109
f6095868
PE
4110 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4111 shadowing.
4112 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4113 Include <limits.h>.
4114 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4115 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4116 (load_charset_map): Mark variables that gcc -Wuninitialized
4117 does not deduce are never used uninitialized.
53df7c11 4118 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4119
f38b440c
PE
4120 * coding.c (coding_set_source, coding_set_destination):
4121 Use "else { /* comment */ }" rather than "else /* comment */;"
4122 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4123 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4124 a block, when the outer 'i' will do.
4125 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4126 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4127 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4128 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4129 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4130 Rename locals to avoid shadowing.
4131 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4132 * coding.c (emacs_mule_char, encode_invocation_designation):
4133 Now static, since they're not used elsewhere.
413bb2db 4134 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4135 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4136 (decode_coding_emacs_mule): Mark variables that gcc
4137 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4138 (detect_coding_iso_2022): Initialize a local variable that might
4139 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4140 this initialization is needed. (Bug#8211)
5f58e762
PE
4141 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4142 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4143 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4144 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4145 Remove unused macros.
f38b440c 4146
232b38b9 4147 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4148 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4149 * character.c (string_count_byte8): Likewise.
232b38b9 4150
fb90da1b
PE
4151 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4152 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4153
fb93dbc2
PE
4154 * chartab.c (copy_sub_char_table): Now static, since it's not used
4155 elsewhere.
5c156ace
PE
4156 (sub_char_table_ref_and_range, char_table_ref_and_range):
4157 Rename locals to avoid shadowing.
bbcd0949 4158 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4159
7d3b3862 4160 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4161 (BIDI_BOB): Remove unused macro.
7d3b3862 4162
6be7d3da
PE
4163 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4164 deduce are never used uninitialized.
c2ed9c8b 4165 * term.c (encode_terminal_code): Likewise.
6be7d3da 4166
75f8807f 4167 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4168
50938595
PE
4169 * tparam.h: New file.
4170 * term.c, tparam.h: Include it.
4171 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4172 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4173 Move these decls to tparam.h, and make them agree with what
4174 is actually in tparam.c. The previous trick of using incompatible
4175 decls in different modules does not conform to the C standard.
4176 All callers of tparam changed to use tparam's actual API.
4177 * tparam.c (tparam1, tparam, tgoto):
4178 Use const pointers where appropriate.
4179
fbceeba2
PE
4180 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4181 * cm.h (struct cm): Likewise.
4182 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4183 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4184 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4185 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4186 (turn_on_face, init_tty): Likewise.
4187 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4188
7f3f1250
PE
4189 * term.c (term_mouse_position): Rename local to avoid shadowing.
4190
e6ca6543
PE
4191 * alloc.c (mark_ttys): Move decl from here ...
4192 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4193
c40f8d15
AS
41942011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4195
4196 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4197
cfe0661d
JB
41982011-03-09 Juanma Barranquero <lekktu@gmail.com>
4199
4200 * search.c (compile_pattern_1): Remove argument regp, unused since
4201 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4202 (compile_pattern): Don't pass it.
4203
0afb4571
J
42042011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4205
4206 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4207 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4208 for ! HAVE_GTK3.
4209 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4210
4211 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4212
4213 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4214 gdk_window_get_screen, gdk_window_get_geometry,
4215 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4216 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4217 (xg_get_pixbuf_from_pixmap): New function.
4218 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4219 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4220 Call xg_get_pixbuf_from_pixmap instead of
4221 gdk_pixbuf_get_from_drawable.
4222 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4223 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4224 (xg_check_special_colors): Use GtkStyleContext and its functions
4225 for HAVE_GTK3.
4226 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4227 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4228 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4229 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4230 Call gtk_widget_get_preferred_size.
0afb4571
J
4231 (xg_frame_resized): gdk_window_get_geometry only takes 5
4232 parameters.
44f230aa
SM
4233 (xg_win_to_widget, xg_event_is_for_menubar):
4234 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4235 (xg_set_widget_bg): New function.
4236 (delete_cb): New function.
895009e1 4237 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4238 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4239 (xg_set_background_color): Call xg_set_widget_bg.
4240 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4241 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4242 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4243 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4244 if ! HAVE_GTK3.
4245 (update_frame_tool_bar): Call gtk_widget_hide.
4246 (xg_initialize): Use GDK_KEY_g.
4247
4248 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4249 if ! HAVE_GTK3
4250 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4251
4252 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4253 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4254 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4255
1c2cc4ef
JB
42562011-03-08 Juanma Barranquero <lekktu@gmail.com>
4257
4258 * w32xfns.c (select_palette): Check success of RealizePalette against
4259 GDI_ERROR, not zero.
4260
33383987 4261See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4262
4263;; Local Variables:
4264;; coding: utf-8
aac0c6e3
MR
4265;; End:
4266
33383987 4267 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4268
4269 This file is part of GNU Emacs.
4270
4271 GNU Emacs is free software: you can redistribute it and/or modify
4272 it under the terms of the GNU General Public License as published by
4273 the Free Software Foundation, either version 3 of the License, or
4274 (at your option) any later version.
4275
4276 GNU Emacs is distributed in the hope that it will be useful,
4277 but WITHOUT ANY WARRANTY; without even the implied warranty of
4278 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4279 GNU General Public License for more details.
4280
4281 You should have received a copy of the GNU General Public License
4282 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.