Move NSIG_MINIMUM from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6de0e799
GM
12012-07-13 Glenn Morris <rgm@gnu.org>
2
739ae010
GM
3 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4
dbee5793
GM
5 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
6
6de0e799
GM
7 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
8 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
9
b82da769
GM
102012-07-12 Glenn Morris <rgm@gnu.org>
11
4fae5a7a 12 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
13
14 * process.c (init_process_emacs): Rename from init_process.
15 The old name is also the name of a Mach system call.
16 * lisp.h, emacs.c: Update for this name change.
17 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
18 longer needed.
19
5a979817
EZ
202012-07-12 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
23 memmove call that removes glyphs covered by the left truncation
24 glyph. Improve commentary.
25 (display_line): Fix display of continuation glyphs on GUI frames
26 when the right fringe is turned off and variable-size fonts are
27 used in the window. Move the code that appends a stretch glyph to
28 produce_special_glyphs, so that it could be used for truncation
29 and continuation glyphs alike.
30 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
31 glyph of a suitably computed width, to align the special glyphs at
32 the window margin. Code moved from display_line. (Bug#11832)
33
3e91a053
GM
342012-07-12 Glenn Morris <rgm@gnu.org>
35
ba9e4b84
GM
36 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
37
38 * s/gnu-linux.h, s/hpux10-20.h:
39 Do not unconditionally define HAVE_XRMSETDATABASE.
40
3e91a053
GM
41 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
42
b300b1f4
PE
432012-07-12 Paul Eggert <eggert@cs.ucla.edu>
44
45 Fix typos that broke OS X build.
46 Reported by Randal L. Schwartz in
47 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
48 * nsterm.m (ns_timeout): Add missing local decl.
49 (ns_get_color): snprintf -> sprintf, to fix typo.
50
6e777848
GM
512012-07-12 Glenn Morris <rgm@gnu.org>
52
3f922c37
GM
53 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
54 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
55 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
56 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
57
0ab7b23a
GM
58 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
59 Move PTY_OPEN to configure.
60
6e777848
GM
61 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
62 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
63 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
64
4a7edc24
DA
652012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Use empty_unibyte_string where applicable.
68 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
69 * lread.c (read1): Likewise.
70 * xsettings.c (syms_of_xsettings): Likewise.
71
308aab79
GM
722012-07-12 Glenn Morris <rgm@gnu.org>
73
42bd1719
GM
74 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
75 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
76 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
77 * s/hpux10-20.h (RUN_TIME_REMAP):
78 * s/bsd-common.h (TABDLY): Move to configure.
79
80 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
81
82 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
83
ea0bbd17 84 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 85 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
86
87 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 88
308aab79
GM
89 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
90 * s/template.h: Move NARROWPROTO to configure.
91
ee1cf5cf
GM
922012-07-11 Glenn Morris <rgm@gnu.org>
93
30fe9bf4
GM
94 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
95 unused since 2011-01-17 change to systty.h.
96
ee1cf5cf
GM
97 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
98 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
99 Move HAVE_PTYS and HAVE_SOCKETS to configure.
100
63e47e07
PE
1012012-07-11 Paul Eggert <eggert@cs.ucla.edu>
102
103 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
104
c43fb4c3
GM
1052012-07-11 Glenn Morris <rgm@gnu.org>
106
107 * s/darwin.h, s/gnu-linux.h, s/template.h:
108 Move INTERRUPT_INPUT to configure.
109
e8df9267
DA
1102012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Minor adjustments to interning code.
113 * lisp.h (intern, intern_c_string): Redefine as static inline
114 wrappers for intern_1 and intern_c_string_1, respectively.
115 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
116 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
117 Vobarray checking.
e8df9267
DA
118 * font.c (font_intern_prop): Likewise. Adjust comment.
119 * w32font.c (intern_font_name): Likewise.
120
34348bd4
AS
1212012-07-11 Andreas Schwab <schwab@linux-m68k.org>
122
d96a1e0c
AS
123 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
124
34348bd4
AS
125 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
126 of Fcar/Fcdr if possible.
127 * font.c (check_otf_features): Likewise.
128 * fontset.c (Fnew_fontset): Likewise.
129 * gnutls.c (Fgnutls_boot): Likewise.
130 * minibuf.c (read_minibuf): Likewise.
131 * msdos.c (IT_set_frame_parameters): Likewise.
132 * xmenu.c (Fx_popup_dialog): Likewise.
133 * w32menu.c (Fx_popup_dialog): Likewise.
134
c8add24e
GM
1352012-07-11 Glenn Morris <rgm@gnu.org>
136
4b575b3c
GM
137 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
138 since nothing has defined it on these platforms.
139
09f4e3b0
GM
140 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
141 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
142
172bedef
GM
143 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
144 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
145 Move CLASH_DETECTION to configure.
146
249685df
GM
147 * s/gnu.h: Remove file, which is now empty.
148
c8add24e
GM
149 * s/gnu.h, s/gnu-linux.h:
150 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
151
b41253a3
JW
1522012-07-11 John Wiegley <johnw@newartisans.com>
153
154 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
155 function attribute, so we only use it if it exists in the
156 compiler.
157
d923b542
DA
1582012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
159
160 Avoid call to strlen in fast_c_string_match_ignore_case.
161 * search.c (fast_c_string_match_ignore_case): Change to use
162 length argument. Adjust users accordingly.
163 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
164
5ebbef1d
PE
1652012-07-11 Paul Eggert <eggert@cs.ucla.edu>
166
bb352260
PE
167 Assume mkdir, rmdir.
168 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
169 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
170
57054ddd
PE
171 Assume rename.
172 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
173
b747d3f7
PE
174 Assume perror.
175 * s/hpux10-20.h (HAVE_PERROR): Remove.
176 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
177 Remove dummy definition, as this problem was obsolete long ago.
178
5ebbef1d
PE
179 Assume strerror.
180 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
181
984e7f30
DA
1822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Avoid calls to strlen in font processing functions.
185 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 186 (font_open_by_name): Change to use length argument. Adjust
984e7f30 187 users accordingly.
d923b542
DA
188 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
189 Adjust prototypes.
190 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
191 Change to return ptrdiff_t.
984e7f30
DA
192 (xfont_list_pattern, xfont_match): Use length returned by
193 xfont_decode_coding_xlfd.
194 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
195
20e94fdd
GM
1962012-07-11 Glenn Morris <rgm@gnu.org>
197
9d596af3
GM
198 * s/darwin.h, s/freebsd.h, s/netbsd.h:
199 Move DONT_REOPEN_PTY to configure.
200
20e94fdd
GM
201 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
202 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
203
e99a530f
PE
2042012-07-10 Paul Eggert <eggert@cs.ucla.edu>
205
22ffb973
PE
206 Remove "#define unix" that is no longer needed (Bug#11905).
207 * s/aix4-2.h (unix): Remove; no longer needed.
208
e9a9ae03
PE
209 EMACS_TIME simplification (Bug#11875).
210 This replaces macros (which typically do not work in GDB)
211 with functions, typedefs and enums, making the code easier to debug.
212 The functional style also makes code easier to read and maintain.
213 * systime.h: Include <sys/time.h> on all hosts, not just if
214 WINDOWSNT, since 'struct timeval' is needed in general.
215 (EMACS_TIME): Now a typedef, not a macro.
216 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
217 not macros.
218 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
219 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
220 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
221 (EMACS_TIME_LE): Now functions, not macros.
222 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
223 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
224 which are not functions. All uses rewritten to use:
225 (make_emacs_time): New function.
226 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
227 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
228 not functions. All uses rewritten to use the following, respectively:
229 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
230 (add_emacs_time, sub_emacs_time): New functions.
231 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
232 * fileio.c (Fcopy_file):
233 * xterm.c (XTflash): Get the current time closer to when it's used.
234 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
235
ffacb126
PE
236 * bytecode.c (targets): Suppress -Woverride-init warnings.
237
e99a530f
PE
238 Simplify by avoiding confusing use of strncpy etc.
239 * doc.c (Fsnarf_documentation):
240 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
241 * frame.c (Fmake_terminal_frame):
242 * gtkutil.c (get_utf8_string):
243 * lread.c (openp):
244 * nsmenu.m (ns_update_menubar):
245 * regex.c (regerror):
246 Prefer memcpy to strncpy and strncat when either will do.
247 * fileio.c (Fsubstitute_in_file_name):
248 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
249 (menu_separator_name_p):
250 * nsmenu.m (ns_update_menubar):
251 Prefer memcmp to strncmp when either will do.
252 * nsterm.m: Include <ftoastr.h>.
253 (ns_get_color):
254 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
255 Prefer snprintf to strncpy.
256 * nsterm.m (ns_term_init):
257 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
258 * nsterm.m (ns_term_init):
259 Avoid the need for strncpy, by using build_string or
260 make_unibyte_string directly. Use dtoastr, not snprintf.
261 * process.c (Fmake_network_process): Diagnose service names that
262 are too long, rather than silently truncating them or creating
263 non-null-terminated names.
264 (Fnetwork_interface_info): Likewise, for interface names.
265 * sysdep.c (system_process_attributes) [GNU_LINUX]:
266 Prefer sprintf to strncat.
267 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
268 Prefer vsnprintf to vsprintf + strncpy.
269
c59592b3
GM
2702012-07-10 Glenn Morris <rgm@gnu.org>
271
272 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
273 Clarify fallback case.
274
7d7bbefd
DA
2752012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
278 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
279 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 280 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
281 where argument type is known to be a Lisp_Cons.
282
3a4c8000
TT
2832012-07-10 Tom Tromey <tromey@redhat.com>
284
285 * bytecode.c (BYTE_CODE_THREADED): New macro.
286 (BYTE_CODES): New macro. Replaces all old byte-code defines.
287 (enum byte_code_op): New type.
288 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
289 (exec_byte_code): Use them. Use token threading when applicable.
290
2a0213a6
DA
2912012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Optimize pure C strings initialization.
294 * lisp.h (make_pure_string): Fix prototype.
295 (build_pure_c_string): New function, defined as static inline. This
296 provides a better opportunity to optimize away calls to strlen when
297 the function is called with compile-time constant argument.
298 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
299 argument, adjust users accordingly. Use build_pure_c_string where
300 appropriate.
301 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
302 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
303 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
304
cb1caeaf
DA
3052012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
306
307 Avoid calls to strlen in miscellaneous functions.
308 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
309 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
310 * lread.c (openp): Likewise.
311
c293e30c
DA
3122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
313
314 Avoid calls to strlen in path processing functions.
315 * fileio.c (file_name_as_directory): Add comment. Change to add
316 srclen argument and return the length of result. Adjust users
317 accordingly.
318 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 319 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
320 users accordingly.
321 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
322
9e059e3f
GM
3232012-07-10 Glenn Morris <rgm@gnu.org>
324
d02eb359
GM
325 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
326 Move PENDING_OUTPUT_COUNT definition to configure.
327
882cf227
GM
328 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
329 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
330 * s/gnu.h (DATA_START): Move definitions to configure.
331
af6e839f
GM
332 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
333 We include usg5-4-common.h, which defines them both.
334
40289a12
GM
335 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
336 O_RDONLY already includes it).
337
9e059e3f
GM
338 Stop ns builds setting the EMACSLOADPATH environment variable.
339 * nsterm.m (ns_load_path): Rename from ns_init_paths.
340 Now it does not set EMACSLOADPATH, just returns the load-path string.
341 * nsterm.h: Update accordingly.
342 * lread.c [HAVE_NS]: Include nsterm.h.
343 (init_lread) [HAVE_NS]: Use ns_load_path.
344 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
345
7c4e8ec0
GM
3462012-07-09 Glenn Morris <rgm@gnu.org>
347
d4f600ff
GM
348 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
349 since the included bsd-common.h does so.
350
cbb31951
GM
351 Stop ns builds setting the EMACSPATH environment variable.
352 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
353 (ns_init_paths): Do not set EMACSPATH.
354 * nsterm.h (ns_exec_path): Add it.
355 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
356 Use ns_exec_path.
357
7c4e8ec0
GM
358 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
359
26bccfae
PE
3602012-07-09 Paul Eggert <eggert@cs.ucla.edu>
361
a0bee46f
PE
362 * process.c (wait_reading_process_output): 'waitchannels' was unset
363 when read_kbd || !NILP (wait_for_cell); fix this.
364
5994c183
PE
365 Add GCC-style 'const' attribute to functions that can use it.
366 * character.h (char_resolve_modifier_mask):
367 * keyboard.h (make_ctrl_char):
368 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
369 (init_character_once, next_almost_prime, init_fns, init_image)
370 (flush_pending_output, init_sound):
371 * mem-limits.h (start_of_data):
372 * menu.h (finish_menu_items):
373 Add ATTRIBUTE_CONST.
374 * emacs.c (DEFINE_DUMMY_FUNCTION):
375 Declare the dummy function with ATTRIBUTE_CONST.
376 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
377 Add decls with ATTRIBUTE_CONST.
378
26bccfae
PE
379 Minor improvements to make_formatted_string.
380 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
381 where int is good enough, as vsprintf returns an int.
382 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
383
a8290ec3
DA
3842012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
385
386 Use make_formatted_string to avoid double length calculation.
387 * lisp.h (make_formatted_string): New prototype.
388 * alloc.c (make_formatted_string): New function.
389 * buffer.c (Fgenerate_new_buffer_name): Use it.
390 * dbus.c (syms_of_dbusbind): Likewise.
391 * editfns.c (Fcurrent_time_zone): Likewise.
392 * filelock.c (get_boot_time): Likewise.
393 * frame.c (make_terminal_frame, set_term_frame_name)
394 (x_report_frame_params): Likewise.
395 * image.c (gs_load): Likewise.
396 * minibuf.c (get_minibuffer): Likewise.
397 * msdos.c (dos_set_window_size): Likewise.
398 * process.c (make_process): Likewise.
399 * xdisp.c (ensure_echo_area_buffers): Likewise.
400 * xsettings.c (apply_xft_settings): Likewise.
401
d01ba2f1
GM
4022012-07-09 Glenn Morris <rgm@gnu.org>
403
404 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
405 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
406 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
407 * nsterm.h (ns_etc_directory): Add it.
408 * callproc.c [HAVE_NS]: Include nsterm.h.
409 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
410
f1f924b6
DA
4112012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Move marker debugging code under MARKER_DEBUG.
414 * marker.c (MARKER_DEBUG): Move marker debugging code under
415 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
416 for bootstrap with --enable-checking (~3x slowdown reported
417 by Juanma Barranquero <lekktu@gmail.com>).
418 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
419
ab531b66
PE
4202012-07-08 Paul Eggert <eggert@cs.ucla.edu>
421
422 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
423 See <http://bugs.gnu.org/11825#29>.
424
c4b3bc8a
EZ
4252012-07-08 Eli Zaretskii <eliz@gnu.org>
426
427 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
428 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
429 (display_line): Add commentary about displaying truncation glyphs
430 on GUI frames.
431 (produce_special_glyphs): Move here from term.c.
432
433 * term.c (produce_special_glyphs): Move to xdisp.c.
434
435 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
436 section.
c4b3bc8a 437
b676b881
AS
4382012-07-07 Andreas Schwab <schwab@linux-m68k.org>
439
f17c5273
AS
440 * xdisp.c (display_line): Avoid warning about implicit declaration
441 of FRAME_FONT.
442
298819b9
AS
443 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
444
b676b881
AS
445 * lisp.h: Remove empty conditional.
446
6045c4fd
PE
4472012-07-07 Paul Eggert <eggert@cs.ucla.edu>
448
b3350bf9
PE
449 * lread.c (load_path_check): Now static.
450
6045c4fd
PE
451 Fix some minor --with-ns problems found by static checking.
452 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
453 (x_set_font) [!HAVE_X_WINDOWS]:
454 * image.c (xpm_load_image) [HAVE_NS]:
455 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
456 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
457 Remove unused local.
458 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
459 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
460 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
461 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
462 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
463 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
464 Fix pointer signedness problem.
465 * xfaces.c (FRAME_X_FONT_TABLE):
466 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
467
929e7845
GM
4682012-07-07 Glenn Morris <rgm@gnu.org>
469
470 * lread.c (load_path_check): New function, split from init_lread.
471 (init_lread): Reorganize. Motivation:
472 If EMACSLOADPATH is set, check/warn about that rather than the
473 defaults, which we are not going to use. Hence we can remove
474 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
475 Don't warn if site-lisp directories are missing.
476 If not installed, start from a blank load-path, since
477 PATH_LOADSEARCH refers to the eventual installation directories.
478
58dd0aa4
EZ
4792012-07-07 Eli Zaretskii <eliz@gnu.org>
480
481 Support truncation and continuation glyphs on GUI frames, when
482 fringes are disabled. (Bug#11832)
483 * xdisp.c (init_iterator): Get dimensions of truncation and
484 continuation glyphs even if on GUI frames. Adjust
485 it->last_visible_x on GUI frames when the left or right fringes,
486 or both, are absent.
487 (start_display, move_it_in_display_line_to): Handle the case of a
488 GUI frame without a fringe to display continuation or truncation
489 glyphs.
490 (insert_left_trunc_glyphs): Support GUI frames: make sure
491 truncation glyphs overwrite enough glyphs from the current line to
492 have sufficient space in pixels.
493 (display_line): Support truncation and continuation glyphs on GUI
494 frames. If some spare pixels are left on the line after inserting
495 the truncation glyphs, fill that space with a stretch glyph of a
496 suitably computed width.
497
498 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
499 produce_glyphs, to support GUI sessions.
500
31571fd7
PE
5012012-07-07 Paul Eggert <eggert@cs.ucla.edu>
502
5a16b9bc
PE
503 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
504
f3047c75
PE
505 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
506
31571fd7
PE
507 Do not require float-time's arg to fit in time_t (Bug#11825).
508 This works better on hosts where time_t is unsigned, and where
509 float-time is applied to the (negative) difference between two times.
510 * editfns.c (decode_time_components): Last arg is now double *,
511 not int *, and means to store all the result as a double, without
512 worrying about whether the seconds part fits in time_t.
513 All callers changed.
514 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
515 All callers changed.
516 (Ffloat_time): Do not fail merely because the specified time falls
517 outside of time_t range.
518
4516fbef
GM
5192012-07-07 Glenn Morris <rgm@gnu.org>
520
521 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
522 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
523 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
524
07adc2c6
JB
5252012-07-07 Juanma Barranquero <lekktu@gmail.com>
526
527 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
528 Update dependencies.
529
530 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
531
fd573f31
PE
5322012-07-06 Paul Eggert <eggert@cs.ucla.edu>
533
fee5959d
PE
534 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
535 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
536 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
537 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
538 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
539 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
540
fd573f31
PE
541 * xfont.c (compare_font_names): Redo to omit the need for casts.
542
ddadbc0e
AS
5432012-07-06 Andreas Schwab <schwab@linux-m68k.org>
544
fca8d6b6
AS
545 * xfns.c (Fx_change_window_property): Doc fix.
546 * w32fns.c (Fx_change_window_property): Doc fix.
547
ddadbc0e
AS
548 * w32fns.c (Fx_window_property): Accept the same arguments as the
549 X Windows version. Doc fix.
550 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
551
f247498e
JB
5522012-07-06 Juanma Barranquero <lekktu@gmail.com>
553 Eli Zaretskii <eliz@gnu.org>
554
555 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
556 Windows-specific code from nt/config.nt moved here.
557 Obsolete settings removed.
558
216ee680
PE
5592012-07-06 Paul Eggert <eggert@cs.ucla.edu>
560
561 * process.c: Avoid unnecessary calls to gettime.
562 (wait_reading_process_output): Don't get the time of day
563 when gobbling data immediately and not waiting, as there's no need
564 for it in that case. This removes a FIXME.
565
bdd091e4
JD
5662012-07-06 Jan Djärv <jan.h.d@swipnet.se>
567
568 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
569 is defined (Bug#11768).
570
9d44f8ce
DA
5712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
572
573 Fix marker debugging code.
574 * marker.c (byte_char_debug_check): Do not perform the check
575 if buffer is not multibyte.
090bd7cb
JB
576 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
577 Call byte_char_debug_check with correct arguments.
9d44f8ce 578
90fc4786
DA
5792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
580
581 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
582 * marker.c (byte_char_debug_check, count_markers):
583 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
584 (byte_debug_flag): Remove.
585 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
586 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
587
7b7ae965
DA
5882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
589
4e57b342
DA
590 Avoid code repetition in marker-related functions.
591 * marker.c (attach_marker): New function.
592 (Fset_marker, set_marker_restricted, set_marker_both)
593 (set_marker_restricted_both): Use it.
594 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
595 Consistently rename charno to charpos.
596 (marker_position): Add eassert.
597 (marker_byte_position): Convert to eassert.
598
5992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 602 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 603 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 604
657924ff
DA
6052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Introduce fast path for the widely used marker operation.
608 * alloc.c (build_marker): New function.
609 * lisp.h (build_marker): New prototype.
610 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
611 * composite.c (autocmp_chars): Likewise.
612 * editfns.c (buildmark): Remove.
613 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
614 (save_restriction_save): Use build_marker.
615 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
616 * window.c (save_window_save): Likewise.
617
041a49a6
DA
6182012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Do not use Fdelete_overlay in delete_all_overlays
621 to avoid redundant calls to unchain_overlay.
622 * buffer.c (drop_overlay): New function.
623 (delete_all_overlays, Fdelete_overlay): Use it.
624 * minibuf.c (get_minibuffer): Fix comment.
625
7dca65a4
PE
6262012-07-06 Paul Eggert <eggert@cs.ucla.edu>
627
628 Port to OpenBSD 5.1 amd64.
629 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
630 This is needed for OpenBSD, and should be harmless on all BSD systems.
631 Also, include <sys/sysctl.h>, as it should be available on all
632 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
633 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
634 use p_pid member, not kp_proc.pid.
635
8eb876e2
GM
6362012-07-06 Glenn Morris <rgm@gnu.org>
637
638 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
639
38182d90
PE
6402012-07-05 Paul Eggert <eggert@cs.ucla.edu>
641
642 More xmalloc and related cleanup.
643 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
644 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
645 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
646 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
647 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
648 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
649 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
650 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
651 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
652 * xterm.c:
653 Omit needless casts involving void * pointers and allocation.
654 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
655 as the former is more robust if P's type is changed.
656 Prefer xzalloc to xmalloc + memset 0.
657 Simplify malloc-or-realloc to realloc.
658 Don't worry about xmalloc returning a null pointer.
659 Prefer xstrdup to xmalloc + strcpy.
660 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
661 growing it.
662 * keyboard.c (apply_modifiers_uncached): Prefer local array to
663 alloca of a constant.
664
6dd5a677
EZ
6652012-07-05 Eli Zaretskii <eliz@gnu.org>
666
667 * xdisp.c (display_line): Fix horizontal pixel coordinates when
668 hscroll is larger than the line width. Fixes long and futile
669 looping inside extend_face_to_end_of_line (on a TTY) producing
670 glyphs that are not needed and thrown away.
671
6b312f0f
DA
6722012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
673
674 * marker.c (set_marker_restricted_both): Simplify by using
675 clip_to_bounds.
676
f520ef9b
PE
6772012-07-05 Paul Eggert <eggert@cs.ucla.edu>
678
679 * editfns.c (region_limit): Simplify by using clip_to_bounds.
680
383b7c95
JD
6812012-07-05 Jan Djärv <jan.h.d@swipnet.se>
682
683 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
684 not defined (Bug#11768).
685 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
686 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
687 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
688 followed by gtk_box_set_homogeneous (Bug#11768).
689 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
690 (update_theme_scrollbar_width, xg_create_scroll_bar):
691 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
692 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
693 (is_box_type): New function (Bug#11768).
694 (xg_tool_item_stale_p): Call is_box_type.
5293d758 695 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
696 with default display (Bug#11768).
697
d6e7bf45
EZ
6982012-07-05 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (window_hscroll_limited): New function.
701 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
702 coordinates when window's hscroll is set to insanely large
703 values. (Bug#11857)
704
431391ec
JB
7052012-07-05 Juanma Barranquero <lekktu@gmail.com>
706
707 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
708 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
709
23f86fce
DA
7102012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
711
712 Cleanup xmalloc.
713 * lisp.h (xzalloc): New prototype. Omit needless casts.
714 * alloc.c (xzalloc): New function. Omit needless casts.
715 * charset.c: Omit needless casts. Convert all calls to
716 xmalloc with following memset to xzalloc.
717 * dispnew.c: Likewise.
718 * fringe.c: Likewise.
719 * image.c: Likewise.
720 * sound.c: Likewise.
721 * term.c: Likewise.
722 * w32fns.c: Likewise.
723 * w32font.c: Likewise.
724 * w32term.c: Likewise.
725 * xfaces.c: Likewise.
726 * xfns.c: Likewise.
727 * xterm.c: Likewise.
728 * atimer.c: Omit needless casts.
729 * buffer.c: Likewise.
730 * callproc.c: Likewise.
731 * ccl.c: Likewise.
732 * coding.c: Likewise.
733 * composite.c: Likewise.
734 * doc.c: Likewise.
735 * doprnt.c: Likewise.
736 * editfns.c: Likewise.
737 * emacs.c: Likewise.
738 * eval.c: Likewise.
739 * filelock.c: Likewise.
740 * fns.c: Likewise.
741 * gtkutil.c: Likewise.
742 * keyboard.c: Likewise.
743 * lisp.h: Likewise.
744 * lread.c: Likewise.
745 * minibuf.c: Likewise.
746 * msdos.c: Likewise.
747 * print.c: Likewise.
748 * process.c: Likewise.
749 * region-cache.c: Likewise.
750 * search.c: Likewise.
751 * sysdep.c: Likewise.
752 * termcap.c: Likewise.
753 * terminal.c: Likewise.
754 * tparam.c: Likewise.
755 * w16select.c: Likewise.
756 * w32.c: Likewise.
757 * w32reg.c: Likewise.
758 * w32select.c: Likewise.
759 * w32uniscribe.c: Likewise.
760 * widget.c: Likewise.
761 * xdisp.c: Likewise.
762 * xmenu.c: Likewise.
763 * xrdb.c: Likewise.
764 * xselect.c: Likewise.
765
0497dc44
PE
7662012-07-05 Paul Eggert <eggert@cs.ucla.edu>
767
768 * fileio.c (time_error_value): Check the right error number.
769 Problem reported by Troels Nielsen in
770 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
771
356e7178
PE
7722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
773
4e71fd89
PE
774 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
775 This should be fixed in a better way; see Eli Zaretskii in
776 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
777 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
778
f0941253
PE
779 * fileio.c (time_error_value): Rename from special_mtime.
780 The old name's problems were noted by Eli Zaretskii in
781 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
782
065c9eb4
PE
783 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
784 This variable's comment says Emacs needs at least one GDB-visible
785 symbol of type enum pvec_type, to work around GDB problems.
786 The symbol's value doesn't matter.
787
356e7178
PE
788 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
789 that causes compilation to fail on pre-C99 compilers.
790
95f61aa2
JB
7912012-07-04 Juanma Barranquero <lekktu@gmail.com>
792
793 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
794 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
795
3884d954
DA
7962012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
797
d209e2fb 798 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
799 headers for buffer_defaults and buffer_local_symbols.
800 Reported by Juanma Barranquero <lekktu@gmail.com>.
801
ee28be33
SM
8022012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
803
804 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
805 * lisp.h (enum pvec_type): Use fewer bits.
806 (PSEUDOVECTOR_SIZE_BITS): New constant.
807 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
808 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
809 change in pvec_type.
810 (PSEUDOVECTOR_TYPEP): New macro.
811 (TYPED_PSEUDOVECTORP): Use it.
812 * fns.c (internal_equal): Adapt code to extract pvectype.
813 * emacs.c (gdb_pvec_type): Update type.
814 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
815 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
816 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
817 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
818 (sweep_vectors): Use it. Use local var `total_bytes' instead of
819 abusing vector->header.next.nbytes.
820 (live_vector_p): Use PVEC_TYPE.
821 (mark_object): Adapt code to extract pvectype. Use switch.
822
c7f2cd7f
PE
8232012-07-04 Paul Eggert <eggert@cs.ucla.edu>
824
825 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
826 Tighten new eassert a bit.
827
8ce70ed2
DA
8282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
829
830 Fix compilation with --enable-gcc-warnings and -O1
831 optimization level.
832 * doprnt.c (doprnt): Change type of tem to int, initialize
833 to avoid compiler warning. Add eassert.
834 * search.c (simple_search): Initialize match_byte to avoid
835 compiler warning. Add eassert.
836
dea7f1e5
PE
8372012-07-04 Paul Eggert <eggert@cs.ucla.edu>
838
24a212eb
PE
839 Avoid weird behavior with large horizontal scrolls.
840 Without this change, for example, large hscroll values would
841 mess up Emacs's display on Fedora 15 x86, presumably due to
842 overflows in int calculations in the display code.
843 Also, if buffers had long lines, Emacs would freeze.
844 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
845 (set_window_hscroll): New function, containing the old guts of
846 Fset_window_hscroll. Return the clipped value.
847 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
848 This avoids the need to check against PTRDIFF_MAX.
849
dea7f1e5
PE
850 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
851
76046526
DA
8522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
853
854 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
855
39adff0d
PE
8562012-07-04 Paul Eggert <eggert@cs.ucla.edu>
857
63807d47
PE
858 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
859 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
860 since GCC 4.4.6 issues a bogus warning for them.
861
39adff0d
PE
862 Fix bugs in file timestamp newness comparisons.
863 * fileio.c (Ffile_newer_than_file_p):
864 * lread.c (Fload): Use full timestamp resolution of files,
865 not just the 1-second resolution, so that files that are only
866 slightly newer still count as newer.
867 * fileio.c (Ffile_newer_than_file_p): Don't assume file
868 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
869
dbeed9a6
PE
8702012-07-03 Paul Eggert <eggert@cs.ucla.edu>
871
872 * fileio.c: Improve handling of file time marker. (Bug#11852)
873 (special_mtime): New function.
874 (Finsert_file_contents, Fverify_visited_file_modtime):
875 Use it to set special mtime values consistently.
876
636334d6
AS
8772012-07-03 Andreas Schwab <schwab@linux-m68k.org>
878
879 * fileio.c (Finsert_file_contents): Properly handle st_mtime
880 marker for non-existing file. (Bug#11852)
881
e2017fe2
GM
8822012-07-03 Glenn Morris <rgm@gnu.org>
883
884 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
885 and did not make it into globals.h).
886
404dbd37
TT
8872012-07-03 Tom Tromey <tromey@redhat.com>
888
889 * window.c (Fset_window_margins, Fset_window_fringes)
890 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
891 * textprop.c (Fprevious_property_change): No longer static.
892 * syntax.c (Fsyntax_table_p): No longer static.
893 * process.c (Fget_process, Fprocess_datagram_address): No longer
894 static.
895 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
896 * keyboard.c (Fcommand_execute): No longer static.
897 Remove EXFUN.
898 * insdel.c (Fcombine_after_change_execute): No longer static.
899 * image.c (Finit_image_library): No longer static.
900 * fileio.c (Fmake_symbolic_link): No longer static.
901 * eval.c (Ffetch_bytecode): No longer static.
902 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
903 * doc.c (Fdocumentation_property, Fsnarf_documentation):
904 No longer static.
404dbd37
TT
905 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
906 static.
907 * dired.c (Ffile_attributes): No longer static.
908 * composite.c (Fcomposition_get_gstring): No longer static.
909 * callproc.c (Fgetenv_internal): No longer static.
910
911 * ccl.h: Remove EXFUNs.
912 * buffer.h: Remove EXFUNs.
913 * dispextern.h: Remove EXFUNs.
914 * intervals.h: Remove EXFUNs.
915 * fontset.h: Remove EXFUN.
916 * font.h: Remove EXFUNs.
917 * dosfns.c (system_process_attributes): Remove EXFUN.
918 * keymap.h: Remove EXFUNs.
919 * lisp.h: Remove EXFUNs.
920 * w32term.h: Remove EXFUNs.
921 * window.h: Remove EXFUNs.
922 * xsettings.h: Remove EXFUN.
923 * xterm.h: Remove EXFUN.
924
8e4fd1e1
GM
9252012-07-03 Glenn Morris <rgm@gnu.org>
926
927 * lisp.h (Frandom): Make it visible to C.
928 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
929 buffer for invisible buffers. (Bug#1229)
930
ca95b3eb
DA
9312012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
932
933 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
934 values which aren't power of 2.
935 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
936 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
937 accordingly.
938
7555c33f
SM
9392012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
940
941 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
942
943 * alloc.c (mark_object): Revert part of last patch to use `switch'.
944
d12e8f5a
DA
9452012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
946
947 * alloc.c (allocate_vector_block): Remove redundant
948 calls to mallopt if DOUG_LEA_MALLOC is defined.
949 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
950 avoid calls to mallopt if zero_vector is returned.
951
296094c3
DA
9522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
953
954 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
955 is enabled, avoid dereferencing NULL current_sblock if
956 running undumped.
957
36429c89
DA
9582012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
959
960 Cleanup basic buffer management.
961 * buffer.h (struct buffer): Change layout to use generic vector
962 marking code. Fix some comments. Change type of 'clip_changed'
963 to bitfield. Remove unused #ifndef old.
964 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
965 (GET_OVERLAYS_AT): Fix indentation.
966 (for_each_per_buffer_object_at): New macro.
967 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
968 (Fbuffer_local_variables): Use it.
969 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
970 * alloc.c (allocate_buffer): Adjust to match new layout of
971 struct buffer. Fix comment.
972 (mark_overlay): New function.
973 (mark_buffer): Use it. Use mark_vectorlike to mark normal
974 Lisp area of struct buffer.
975 (mark_object): Use it. Adjust marking of misc objects
976 and related comments.
977
3b3e4cac
PE
9782012-07-02 Paul Eggert <eggert@cs.ucla.edu>
979
980 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
981 wrapper that is not needed because the wrapped code is a no-op (zero
982 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
983 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
984
cf5c0175
DA
9852012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
986
987 * alloc.c (mark_buffer): Simplify. Remove prototype.
988 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 989 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
990 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
991 redundant calls to mark_vectorlike for bool vectors.
992
ca26824c
GM
9932012-06-30 Glenn Morris <rgm@gnu.org>
994
2e4c5312
GM
995 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
996
ca26824c
GM
997 * epaths.in (PATH_SITELOADSEARCH): New.
998 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
999 This is rather than relying on --enable-locallisppath elements
1000 having "site-lisp" in their names. (Bug#10208#25, 11658)
1001
0d23c240
EZ
10022012-06-30 Eli Zaretskii <eliz@gnu.org>
1003
c9240d7a
EZ
1004 * w32proc.c (sys_select): Accept and ignore one more argument.
1005
1006 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1007
0d23c240 1008 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1009 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1010
1011 * sysdep.c: Don't include dos.h and dosfns.h.
1012
1013 * process.c (sys_select):
1014 * msdos.c (sys_select): Accept one more argument and ignore it.
1015
1016 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1017 adapt data types and code to that.
1018
1019 * dosfns.c:
1020 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1021 which clashes with the gnulib function of the same name.
1022
af5a5a98
AS
10232012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1024
c5e4379c
AS
1025 * font.c (font_style_to_value, font_style_symbolic)
1026 (font_prop_validate_style): Add type checks for values in
1027 font_style_table.
1028
af5a5a98
AS
1029 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1030 argument.
1031 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1032 uses.
1033
8d38f461
EZ
10342012-06-29 Eli Zaretskii <eliz@gnu.org>
1035
2e5a6631
EZ
1036 * xdisp.c (try_window_id): Undo last change.
1037
8d38f461
EZ
1038 * w32.c (getwd): Adjust commentary about startup_dir.
1039 (init_environment): Always call sys_access, even in non-MSVC
1040 builds. Don't chdir to the directory of the Emacs executable.
1041 This undoes code from 1997 which was justified by the need to
1042 "avoid conflicts when removing and renaming directories". But its
1043 downside was that every relative file name was being interpreted
1044 relative to the directory of the Emacs executable, which can never
1045 be TRT. In particular, it broke sys_access when called with
1046 relative file names.
1047 (sys_access): Map GetLastError to errno.
1048
2af3565e
DA
10492012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1050
1051 * window.h (struct window): Change type of 'fringes_outside_margins'
1052 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1053 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1054 Adjust comment.
1055 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1056 to ptrdiff_t.
1057
c8d3a25c 10582012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1059
c8d3a25c
GM
1060 * gnutls.c (emacs_gnutls_handshake):
1061 Add QUIT to make the loop interruptible.
57570cd3 1062
c8d3a25c 10632012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1064
c8d3a25c
GM
1065 * charset.c (init_charset): Make lack of etc/charsets fatal.
1066
3e984ee8
DA
10672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 * editfns.c (region_limit): Fix type mismatch.
1070
ef884f23
DA
10712012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1074 undefined. Convert from xassert to eassert.
1075 * nsmenu.m: Convert from xassert to eassert.
1076 * nsterm.m: Likewise.
1077
7d7e0027
SM
10782012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1079
1080 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1081
aa754e6a
PE
10822012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 Avoid integer overflow on scroll-left and scroll-right.
1085 * window.c (HSCROLL_MAX): New macro.
1086 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1087 overflow when requested scroll falls outside ptrdiff_t range.
1088
80b00b08
DA
10892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1090
1091 * window.h (struct window): Change type of 'hscroll',
1092 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1093 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1094 Adjust users accordingly.
1095 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1096 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1097 from EMACS_INT to ptrdiff_t.
1098 (make_window): Omit redundant initialization.
1099
62b2bcf6
JB
11002012-06-28 Juanma Barranquero <lekktu@gmail.com>
1101
1102 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1103
45942c7d
DA
11042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1105
1106 * window.h (struct window): Change type of 'use_time' and
1107 'sequence_number' from Lisp_Object to int.
1108 * frame.c (make_frame): Adjust users accordingly.
1109 * print.c (print_object): Likewise.
1110 * window.c (select_window, Fwindow_use_time, make_parent_window)
1111 (make_window): Likewise.
1112
e509cfa6
DA
11132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1116 enabled with --enable-checking=[all,glyphs] configure option.
1117 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1118 adjust comments accordingly.
1119 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1120 undefined, adjust comments accordingly.
1121 * image.c: Likewise.
1122 * scroll.c: Likewise.
1123 * w32fns.c: Likewise.
1124 * w32term.c: Likewise.
1125 * xdisp.c: Likewise.
1126 * xfaces.c: Likewise.
1127 * xfns.c: Likewise.
1128 * xterm.c: Likewise.
1129
a54e2c05
DA
11302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Generalize run-time debugging checks.
1133 * dispextern.h (XASSERTS): Remove.
1134 * fontset.c (xassert): Remove.
1135 Convert from xassert to eassert.
1136 * alloc.c: Convert from xassert to eassert.
1137 * bidi.c: Likewise.
1138 * dispnew.c: Likewise.
1139 * fns.c: Likewise.
1140 * fringe.c: Likewise.
1141 * ftfont.c: Likewise.
1142 * gtkutil.c: Likewise.
1143 * image.c: Likewise.
1144 * keyboard.c: Likewise.
1145 * menu.c: Likewise.
1146 * process.c: Likewise.
1147 * scroll.c: Likewise.
1148 * sound.c: Likewise.
1149 * term.c: Likewise.
1150 * w32console.c: Likewise.
1151 * w32fns.c: Likewise.
1152 * w32term.c: Likewise.
1153 * window.c: Likewise.
1154 * xdisp.c: Likewise.
1155 * xfaces.c: Likewise.
1156 * xfns.c: Likewise.
1157 * xselect.c: Likewise.
1158 * xterm.c: Likewise.
1159
1ec4b7b2
SM
11602012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * fns.c (maybe_resize_hash_table): Output message when growing the
1163 purify-hashtable.
1164
2014308a
DA
11652012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 * alloc.c (allocate_string_data): Remove dead code.
1168 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1169 avoid GCC warning about unused macro.
1170
246155eb
DA
11712012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1172
1173 * alloc.c (allocate_string): Omit intervals initialization.
1174 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1175 as in make_pure_string and make_pure_c_string.
1176
43184b7b
DA
11772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1178
d209e2fb 1179 * alloc.c (allocate_string): Fix last change.
43184b7b 1180
3fe6dd74
DA
11812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1182
d209e2fb 1183 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1184 to memset, add explicit initialization where appropriate.
1185
1ba6038a
GM
11862012-06-27 Glenn Morris <rgm@gnu.org>
1187
1188 * lisp.mk (lisp): Remove paths.elc.
1189
c89926a5
CY
11902012-06-27 Chong Yidong <cyd@gnu.org>
1191
1192 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1193
ed6b3510
JW
11942012-06-26 John Wiegley <johnw@newartisans.com>
1195
1ec4b7b2 1196 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1197 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1198
ed6b3510
JW
1199 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1200 when building with Clang.
1201
8edd4a2b
SM
12022012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1203
1204 * eval.c (Fapply): Allow calling it with a single argument.
1205
f6f62d1b
EZ
12062012-06-26 Eli Zaretskii <eliz@gnu.org>
1207
1208 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1209 _stricmp and _strnicmp.
1210 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1211
62efea5e
DA
12122012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1215 allocated window.
1216 (allocate_process): Likewise for new process.
8edd4a2b 1217 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1218 (allocate_frame): Likewise.
1219 * frame.c (make_frame): Omit redundant initialization.
1220 * window.c (make_parent_window): Use memset.
1221 (make_window): Omit redundant initialization.
1222 * process.c (make_process): Omit redundant initialization.
1223 * terminal.c (create_terminal): Likewise.
1224
42997f4d
DA
12252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1226
1227 * term.c (delete_tty): Remove redundant call to memset.
1228
1130ecfc
DA
12292012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1230
1231 * alloc.c: Remove build_string.
1232 * lisp.h: Define build_string as static inline. This provides
1233 a better opportunity to optimize away calls to strlen when the
1234 function is called with compile-time constant argument.
1235 * image.c (imagemagick_error): Convert to build_string.
1236 * w32proc.c (sys_spawnve): Likewise.
1237 * xterm.c (x_term_init): Likewise.
1238
cf38a720
PE
12392012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1240
99027bdd
PE
1241 Use sprintf return value instead of invoking strlen on result.
1242 In the old days this wasn't portable, since some sprintf
1243 implementations returned char *. But they died out years ago and
1244 Emacs already assumes sprintf returns int.
1245 Similarly for float_to_string.
1246 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1247 * ccl.c (ccl_driver):
1248 * character.c (string_escape_byte8):
1249 * data.c (Fnumber_to_string):
1250 * doprnt.c (doprnt):
1251 * print.c (print_object):
1252 * xdisp.c (message_dolog):
1253 * xfns.c (syms_of_xfns):
1254 Use sprintf or float_to_string result to avoid need to call strlen.
1255 * data.c (Fnumber_to_string):
1256 Use make_unibyte_string, since the string must be ASCII.
1257 * lisp.h, print.c (float_to_string): Now returns int length.
1258 * term.c (produce_glyphless_glyph):
1259 Use sprintf result rather than recomputing it.
1260
cf38a720
PE
1261 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1262 * Makefile.in (ALL_CFLAGS):
1263 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1264 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1265
3511c784
DA
12662012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1267
0a08eb21 1268 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1269 strcasecmp if available.
1270 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1271
fb7da12e
AS
12722012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1273
1274 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1275 Avoid comma operator.
1276 * menu.c (push_submenu_start, push_submenu_end)
1277 (push_left_right_boundary, push_menu_pane): Likewise.
1278 * msdos.c (dos_rawgetc): Likewise.
1279
afa2ffd8
DA
12802012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1281
1282 * xfns.c (xic_create_fontsetname): Remove redundant calls
1283 to memset.
1284
b3b4476b
PE
12852012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1286
4495ff38
PE
1287 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1288 sprintf already null-terminates its output.
1289
b3b4476b
PE
1290 * xfns.c (x_window): Remove redundant cast.
1291
b00876c9
DA
12922012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1295 `const char *' to `char *' to avoid compiler warning.
1296
d188e26b
PE
12972012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1298
885d1d74
PE
1299 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1300 instead of truncating it to 63 (admittedly a generous limit).
1301
d188e26b
PE
1302 * process.c: Fix spelling and caps in comments.
1303
e2f560b1
DN
13042012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1305
e86db54b 1306 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1307 * sysdep.c (setpgrp): Remove definition, not used in this file.
1308
7583a3a1
JB
13092012-06-24 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * makefile.w32-in: Update dependencies.
1312
696056c2
EZ
13132012-06-24 Eli Zaretskii <eliz@gnu.org>
1314
1315 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1316 (SYSTIME_H): Add nt/inc/sys/time.h.
1317
1318 * systime.h [WINDOWSNT]: Include sys/time.h.
1319
1320 * s/ms-w32.h (struct timespec): Definition moved from
1321 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1322
845ca893
PE
13232012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1326 * buffer.h (buffer_slot_type_mismatch):
1327 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1328 * eval.c (unwind_to_catch):
1329 * image.c (my_png_error, my_error_exit):
1330 * keyboard.c (quit_throw_to_read_char, user_error)
1331 (Fexit_recursive_edit, Fabort_recursive_edit):
1332 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1333 (wrong_type_argument, buffer_overflow, __executable_start)
1334 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1335 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1336 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1337 (fatal):
1338 (child_setup) [!DOS_NT]:
1339 * lread.c (end_of_file_error, invalid_syntax):
1340 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1341 * puresize.h (pure_write_error):
1342 * search.c (matcher_overflow):
1343 * sound.c (sound_perror, alsa_sound_perror):
1344 * sysdep.c, syssignal.h (croak):
1345 * term.c (maybe_fatal, vfatal):
1346 * textprop.c (text_read_only):
1347 * undo.c (user_error):
1348 * unexmacosx.c (unexec_error):
1349 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1350 Use _Noreturn rather than NO_RETURN.
1351 No need for separate decl merely because of _Noreturn.
1352 * sound.c (sound_warning, parse_sound):
1353 Remove unnecessary forward decls.
1354
f1dd8073
PE
13552012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1358 * lisp.h (WAIT_READING_MAX): New macro.
1359 * dispnew.c (Fsleep_for, sit_for):
1360 * keyboard.c (kbd_buffer_get_event):
1361 * process.c (Faccept_process_output):
1362 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1363 This improves on the previous patch, which introduced a bug
1364 when time_t is unsigned and as wide as intmax_t.
1365 See <http://bugs.gnu.org/9000#51>.
1366
b82c1755
EZ
13672012-06-23 Eli Zaretskii <eliz@gnu.org>
1368
1369 * dispnew.c (sit_for, Fsleep_for):
1370 * keyboard.c (kbd_buffer_get_event):
1371 * process.c (Faccept_process_output): Avoid compiler warnings when
1372 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1373
ca300656
JB
13742012-06-23 Juanma Barranquero <lekktu@gmail.com>
1375
049ec95b
JB
1376 * makefile.w32-in: Update dependencies.
1377
ca300656
JB
1378 * w32.c (ltime): Add return type and declare static.
1379 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1380
db7b8d06
PE
13812012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1384 Privately reported by Herbert J. Skuhra.
1385 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1386 All uses changed.
1387 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1388 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1389
0bd8297f
EZ
13902012-06-23 Eli Zaretskii <eliz@gnu.org>
1391
96512555
EZ
1392 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1393 last argument of make_unibyte_string.
1394
0bd8297f
EZ
1395 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1396 language ID in the event parameters.
1397
1398 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1399 event.code, not the obscure "character set ID".
1400
63def6b6
CY
14012012-06-23 Chong Yidong <cyd@gnu.org>
1402
1403 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1404
e8a02204
EZ
14052012-06-23 Eli Zaretskii <eliz@gnu.org>
1406
388cdec0
EZ
1407 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1408 * w32.c (fdutimens): New function.
1409
1410 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1411
1412 * s/ms-w32.h (pselect): Redirect to sys_select.
1413
1414 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1415
e8a02204
EZ
1416 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1417 in the logic of incrementing and decrementing the value of
1418 use_relocatable_buffers.
1419
d054f3fb
PE
14202012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1421
1422 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1423 Privately reported by Herbert J. Skuhra.
1424 [__FreeBSD__]: Remove "*/" typo after "#include".
1425 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1426 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1427 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1428 Don't assume EMACS_TIME and struct timeval are the same type.
1429
d35af63c
PE
14302012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 Support higher-resolution time stamps (Bug#9000).
1433 The time stamps are only nanosecond-resolution at the C level,
1434 since that's the best that any real-world system supports now.
1435 But they are picosecond-resolution at the Lisp level, as that's
1436 easy, and leaves room for future OS improvements.
1437
1438 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1439 (LIBES): Use it.
1440
1441 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1442 Don't get current time unless it's needed.
1443
1444 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1445 now provides it if it's absent.
1446 (start_atimer): Port to higher-res time stamps.
1447 Check for time stamp overflow. Don't get current time more
1448 often than is needed.
1449
1450 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1451 Include systime.h, not time.h.
1452 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1453
1454 * dired.c: Include stat-time.h.
1455 (Ffile-attributes): File times now have higher resolution.
1456
1457 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1458 (struct image): Timestamp now has higher resolution.
1459
1460 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1461 has at least microseconds now. All uses removed.
1462 (update_frame, update_single_window, update_window, update_frame_1)
1463 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1464
1465 * editfns.c (time_overflow): Now extern.
1466 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1467 (float-time, Fformat_time_string, Fcurrent_time_string)
1468 (Fcurrent_time_zone): Accept and generate higher-resolution
1469 time stamps.
1470 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1471 (decode_time_components, lisp_seconds_argument): New functions.
1472 (make_time): Now static.
1473 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1474 Report an error if the time is invalid, rather than having the caller
1475 do that.
1476
1477 * fileio.c: Include <stat-time.h>
1478 (Fcopy_file): Copy higher-resolution time stamps.
1479 Prefer to set the time stamp via a file descriptor if that works.
1480 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1481 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1482 (Fvisited_file_modtime, Fset_visited_file_modtime):
1483 Support higher-resolution time stamps.
1484
1485 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1486
1487 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1488
1489 * image.c (prepare_image_for_display, clear_image_cache)
1490 (lookup_image): Port to higer-resolution time stamps.
1491
1492 * keyboard.c (start_polling, bind_polling_period):
1493 Check for time stamp overflow.
1494 (read_char, kbd_buffer_get_event, timer_start_idle)
1495 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1496 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1497 Port to higher-resolution time stamps. Do not assume time_t is signed.
1498 (decode_timer): New function. Timers are now vectors of length 9,
1499 not 8, to accommodate the picosecond component.
1500 (timer_check_2): Use it.
1501
1502 * nsterm.m (select_timeout, timeval_subtract): Remove.
1503 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1504 as they're a bit more accurate and handle overflow better.
1505 (ns_select): Change prototype to be compatible with pselect.
1506 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1507 * nsterm.h (ns_select): Adjust prototype.
1508
1509 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1510 us-resolution time stamps.
1511 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1512
1513 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1514
1515 * lisp.h (time_overflow): New decl.
1516 (wait_reading_process_output): First arg is now intmax_t, not int,
1517 to accommodate larger waits.
1518
1519 * process.h (struct Lisp_Process.read_output_delay):
1520 Now counts nanoseconds, not microseconds.
1521 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1522 EMACS_HAS_USECS.
1523 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1524 (wait_reading_process_output):
1525 Port to ns-resolution time stamps.
1526 (Faccept_process_output, wait_reading_process_output):
1527 Check for time stamp overflow. Do not assume time_t is signed.
1528 (select_wrapper): Remove; we now use pselect.
1529 (Fprocess_attributes): Now generates ns-resolution time stamps.
1530
1531 * sysdep.c: Include utimens.h. Don't include utime.h
1532 or worry about struct utimbuf; gnulib does that for us now.
1533 (gettimeofday): Remove; gnulib provides a substitute.
1534 (make_timeval): New function.
1535 (set_file_times): Now sets ns-resolution time stamps.
1536 New arg FD; all uses changed.
1537 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1538 (system_process_attributes):
1539 Now returns ns-resolution time stamp. All uses changed.
1540 Check for time stamp overflow.
1541
1542 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1543 provides a substitute now.
1544
1545 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1546 since it guarantees struct timespec.
1547 (EMACS_TIME): Now struct timespec, so that we can support
1548 ns-resolution time stamps.
1549 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1550 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1551 (EMACS_USECS): Remove.
1552 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1553 so multiply the arg by 1000 before storing it.
1554 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1555 New macros.
1556 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1557 Port to ns-resolution time stamps.
1558 (EMACS_TIME_NEG_P): Remove; replaced by....
1559 (EMACS_TIME_SIGN): New macro.
1560 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1561 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1562 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1563 (make_timeval, make_lisp_time, decode_time_components): New decls.
1564 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1565 that it mishandled time_t overflow. You can't compare by subtracting!
1566 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1567 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1568
1569 * term.c: Include <sys/time.h>.
1570 (timeval_to_Time): New function, for proper overflow wraparound.
1571 (term_mouse_position, term_mouse_click): Use it.
1572
1573 * undo.c (record_first_change): Support higher-resolution time stamps
1574 in the undo buffer.
1575 (Fprimitive_undo): Use them when restoring time stamps.
1576
1577 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1578 (w32_get_internal_run_time):
1579 Port to higher-resolution Emacs time stamps.
1580 (ltime): Now accepts single 64-bit integer, as that's more convenient
1581 for callers.
1582
1583 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1584
1585 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1586 for compatibility with pselect. Support ns-resolution time stamps.
1587
1588 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1589
1590 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1591 Check for time stamp overflow, and support ns-resolution time stamps.
1592
1593 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1594 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1595 (timeval_subtract): Remove; no longer needed.
1596 (XTflash, XTring_bell, x_wait_for_event):
1597 Port to ns-resolution time stamps. Don't assume time_t is signed.
1598
b6a92dfe
CY
15992012-06-22 Chong Yidong <cyd@gnu.org>
1600
1601 * xdisp.c (x_consider_frame_title): Revert last change.
1602
d251c37c
EZ
16032012-06-22 Eli Zaretskii <eliz@gnu.org>
1604
1605 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1606 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1607 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1608 staticidx goes up to 1597 out of 1600 = 0x640.)
1609
f10deafb
PE
16102012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1613 Otherwise, the umask might be mistakenly 0 while handling input signals.
1614
ec6de1e2
SM
16152012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1616
1617 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1618
28be1ada
DA
16192012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1620
1621 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1622 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1623 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1624 access to `contents' member of Lisp_Vector objects with AREF and ASET
1625 where appropriate.
1626
c6bf3022
CY
16272012-06-19 Chong Yidong <cyd@gnu.org>
1628
1629 * frame.c (delete_frame): When selecting a frame on a different
1630 text terminal, do not alter the terminal's top-frame.
1631
1632 * xdisp.c (format_mode_line_unwind_data): Record the target
1633 frame's selected window and its terminal's top-frame.
1634 (unwind_format_mode_line): Restore them.
1635 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1636 Callers changed.
1637 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1638 since tty frames can be explicitly named.
1639 (prepare_menu_bars): Likewise.
1640
1641 * term.c (Ftty_top_frame): New function.
1642
defd4196
PE
16432012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 Port byte-code-meter to modern targets.
1646 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1647 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1648 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1649 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1650 (METER_1, METER_2): Simplify.
1651
1053a871
SM
16522012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1653
1654 * data.c (Fdefalias): Return `symbol' (bug#11686).
1655
b7e8d081
MR
16562012-06-18 Martin Rudalics <rudalics@gmx.at>
1657
1658 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1659 gets killed during executing of this function (Bug#11665).
1660 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1661 (Vkill_buffer_query_functions): In doc-string say that functions
1662 run by this hook should not change the current buffer.
1663
7ea2b339
PE
16642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 Fix recently-introduced process.c problems found by static checking.
1667 * process.c (write_queue_push, write_queue_pop, send_process):
1668 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1669 (write_queue_pop): Fix pointer signedness problem.
1670 (send_process): Remove unused local.
1671
96a313a1
CY
16722012-06-17 Chong Yidong <cyd@gnu.org>
1673
1674 * xdisp.c (redisplay_internal): No need to redisplay terminal
1675 frames that are not on top.
1676
20ca2e94
TN
16772012-06-17 Troels Nielsen <bn.troels@gmail.com>
1678
1679 * process.c (make_process): Initialize write_queue.
1680 (write_queue_push, write_queue_pop): New functions.
1681 (send_process): Use them to maintain correct ordering of process
1682 writes (Bug#10815).
1683
9a900ca9
PE
16842012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1685
310fbfa8
PE
1686 * lisp.h (eassert): Assume C89 or later.
1687 This removes the need for CHECK.
1688 (CHECK): Remove. Its comments about always evaluating its
1689 argument were confusing, as 'eassert' typically does not evaluate
1690 its argument.
1691
27bb1ca4
PE
1692 * coding.c (produce_chars): Use ptrdiff_t, not int.
1693
9a900ca9
PE
1694 * xterm.c (x_draw_underwave): Check for integer overflow.
1695 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1696
41b7f8bc 16972012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1698
1699 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1700 referenced (Bug#11583).
1701
9b0e3eba
AA
17022012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1703
1704 Implement wave-style variant of underlining.
1705 * dispextern.h (face_underline_type): New enum.
1706 (face): Add field for underline type.
1707 * nsterm.m (ns_draw_underwave): New function.
1708 (ns_draw_text_decoration): Use it.
1709 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1710 New functions.
1711 (x_draw_glyph_string): Use them.
1712 * xfaces.c (Qline, Qwave): New Lisp objects.
1713 (check_lface_attrs, merge_face_ref)
1053a871
SM
1714 (Finternal_set_lisp_face_attribute, realize_x_face):
1715 Handle wave-style underline face attributes.
9b0e3eba
AA
1716 * xterm.c (x_draw_underwave): New function.
1717 (x_draw_glyph_string): Use it.
1718
0fb52f11
JB
17192012-06-16 Juanma Barranquero <lekktu@gmail.com>
1720
1721 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1722 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1723 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1724 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1725 ($(BLD)/w32select.$(O)): Update dependencies.
1726
e5560ff7
AS
17272012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1728
1729 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1730 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1731 * character.c (_fetch_multibyte_char_p): Remove.
1732 * alloc.c: Include "character.h" before "buffer.h".
1733 * bidi.c: Likewise.
1734 * buffer.c: Likewise.
1735 * bytecode.c: Likewise.
1736 * callint.c: Likewise.
1737 * callproc.c: Likewise.
1738 * casefiddle.c: Likewise.
1739 * casetab.c: Likewise.
1740 * category.c: Likewise.
1741 * cmds.c: Likewise.
1742 * coding.c: Likewise.
1743 * composite.c: Likewise.
1744 * dired.c: Likewise.
1745 * dispnew.c: Likewise.
1746 * doc.c: Likewise.
1747 * dosfns.c: Likewise.
1748 * editfns.c: Likewise.
1749 * emacs.c: Likewise.
1750 * fileio.c: Likewise.
1751 * filelock.c: Likewise.
1752 * font.c: Likewise.
1753 * fontset.c: Likewise.
1754 * fringe.c: Likewise.
1755 * indent.c: Likewise.
1756 * insdel.c: Likewise.
1757 * intervals.c: Likewise.
1758 * keyboard.c: Likewise.
1759 * keymap.c: Likewise.
1760 * lread.c: Likewise.
1761 * macros.c: Likewise.
1762 * marker.c: Likewise.
1763 * minibuf.c: Likewise.
1764 * nsfns.m: Likewise.
1765 * nsmenu.m: Likewise.
1766 * print.c: Likewise.
1767 * process.c: Likewise.
1768 * regex.c: Likewise.
1769 * region-cache.c: Likewise.
1770 * search.c: Likewise.
1771 * syntax.c: Likewise.
1772 * term.c: Likewise.
1773 * textprop.c: Likewise.
1774 * undo.c: Likewise.
1775 * unexsol.c: Likewise.
1776 * w16select.c: Likewise.
1777 * w32fns.c: Likewise.
1778 * w32menu.c: Likewise.
1779 * window.c: Likewise.
1780 * xdisp.c: Likewise.
1781 * xfns.c: Likewise.
1782 * xmenu.c: Likewise.
1783 * xml.c: Likewise.
1784 * xselect.c: Likewise.
1785
2f07e6af
EZ
17862012-06-16 Eli Zaretskii <eliz@gnu.org>
1787
1053a871
SM
1788 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1789 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1790 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1791 row.
1792 (handle_face_prop): Use chunk-relative overlay string index when
1793 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1794 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1795 the rightmost. (Bug#11720)
2f07e6af 1796
29b83cec
AS
17972012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1798
1799 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1800 (CATEGORY_MEMBER): Enforce 1/0 value.
1801 * category.c (_temp_category_set): Remove.
1802
4c5501e9
EZ
18032012-06-16 Eli Zaretskii <eliz@gnu.org>
1804
1805 * window.c (Fdelete_other_windows_internal)
1806 (Fdelete_window_internal): Don't access frame's mouse highlight
1807 info of the initial frame. (Bug#11677)
1808
2b570124
PE
18092012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1810
e93864f9
PE
1811 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1812 Assume USE_2_TAGS_FOR_INTS.
1813 (xreload): Adjust $tagmask width to match recent lisp.h change.
1814
2b570124
PE
1815 Simplify lisp.h in minor ways that should not affect code.
1816 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1817 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1818 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1819 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1820 (INTTYPEBITS): New macro, for clarity.
1821 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1822 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1823 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1824 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1825 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1826
81755f69
JB
18272012-06-13 Juanma Barranquero <lekktu@gmail.com>
1828
1829 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1830
16192a57
GM
18312012-06-13 Glenn Morris <rgm@gnu.org>
1832
1833 * s/bsd-common.h (BSD4_3):
1834 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1835
646b5f55
AS
18362012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1837
1838 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1839 instead of union.
1840 (XLI, XIL): Define.
1053a871
SM
1841 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1842 Use them.
1843 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1844 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1845 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1846 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1847 * frame.c (delete_frame): Remove outdated comment.
1848 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1849 USE_LISP_UNION_TYPE.
1850 (Fw32_unregister_hot_key): Likewise.
1851 (Fw32_toggle_lock_key): Likewise.
1852 * w32menu.c (add_menu_item): Likewise.
1853 (w32_menu_display_help): Use XIL instead of checking
1854 USE_LISP_UNION_TYPE.
1855 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1856 (init_heap): Likewise.
1857 * w32term.c (w32_read_socket): Update comment.
1858
1d3823c9
GM
18592012-06-13 Glenn Morris <rgm@gnu.org>
1860
c62ff706
GM
1861 * s/usg5-4-common.h, src/s/unixware.h:
1862 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1863
1d3823c9
GM
1864 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1865
bfe3e0a2
PE
18662012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1869 * alloc.c (make_number) [!defined make_number]:
1870 Remove, as lisp.h always defines this now.
1871 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1872 (roundup_size): Verify that it is a power of 2.
1873 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1874 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1875 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1876 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1877 USE_LSB_TAG now is always defined to be either 0 or 1.
1878 All uses changed.
1879 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1880 code works fine either way, and efficiency is not a concern here,
1881 as the union type is for debugging, not for production.
1882 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1883 Use an inline function on all platforms when using the union type,
1884 since this is simpler and 'static inline' can be used portably
1885 within Emacs now.
1886 (LISP_INITIALLY_ZERO): New macro.
1887 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1888 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1889
45fa9c0f
GM
18902012-06-12 Glenn Morris <rgm@gnu.org>
1891
b4492cba
GM
1892 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1893
1894 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1895
45fa9c0f
GM
1896 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1897 Move BROKEN_SIGIO to configure.
1898
1899 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1900 Move NO_TERMIO to configure.
1901
0e25d334
CY
19022012-06-12 Chong Yidong <cyd@gnu.org>
1903
1904 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1905 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1906 MagickExportImagePixels is undefined.
1907
43682bb6
PE
19082012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * image.c (imagemagick_load_image): Remove unused label.
1911
a9be7d2b
GM
19122012-06-11 Glenn Morris <rgm@gnu.org>
1913
1914 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1915 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1916 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1917 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1918
3017f87f
SM
19192012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1920
1921 * alloc.c (make_byte_code): New function.
1922 (Fmake_byte_code): Use it. Don't purify here.
1923 * lread.c (read1): Use it as well to avoid extra allocation.
1924
1b9b4cf4
CY
19252012-06-11 Chong Yidong <cyd@gnu.org>
1926
1927 * image.c (imagemagick_load_image): Implement transparency.
1928
95988fcf
AS
19292012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1930
1931 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1932 account for preceding backslashes. (Bug#11663)
1933
cd4eb164
CY
19342012-06-09 Chong Yidong <cyd@gnu.org>
1935
1936 * term.c: Support italics in capable terminals (Bug#9652).
1937 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1938 (turn_on_face): Output using TS_enter_italic_mode if available.
1939 Don't handle unused blinking and alt-charset cases.
1940 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1941 and tty_alt_charset_p cases.
1942 (tty_capable_p, init_tty): Support italics.
1943
1944 * termchar.h (struct tty_display_info): Add field for italics.
1945 Remove unused blink field.
1946
1947 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1948 Handle slant.
1949
1950 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1951 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1952 tty_alt_charset_p. Add tty_italic_p.
1953
ff88beb8
MA
19542012-06-09 Michael Albinus <michael.albinus@gmx.de>
1955
1956 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1957 dbus_type_is_basic if available.
1958 (xd_extract_signed, xd_extract_unsigned): Rename from
1959 extract_signed and extract_unsigned, respectively. Adapt callers.
1960
44286096
CY
19612012-06-09 Chong Yidong <cyd@gnu.org>
1962
1682701f
CY
1963 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1964
44286096
CY
1965 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1966 case (Bug#9752).
1967
d86feb17
PE
19682012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * xdisp.c (vmessage): Treat frame message as multibyte.
1971 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1972 would generate the diagnostic "Making \302\247 buffer-local while
1973 let-bound!".
1974
d5c20fe8
EZ
19752012-06-08 Eli Zaretskii <eliz@gnu.org>
1976
1977 * dispnew.c (showing_window_margins_p): Undo last change, which
1978 was done due to an inadvertent commit.
1979 (adjust_frame_glyphs_for_frame_redisplay): Do call
1980 showing_window_margins_p.
1981
513749ee
SM
19822012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1983
1984 * eval.c (Fmake_var_non_special): New primitive.
1985 (syms_of_eval): Defsubr it.
1986 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1987
d4a8f5c1
JB
19882012-06-08 Juanma Barranquero <lekktu@gmail.com>
1989
1990 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1991 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1992
8bbbc977
EZ
19932012-06-08 Eli Zaretskii <eliz@gnu.org>
1994
1995 * alloc.c (allocate_vectorlike): Fix last change.
1996
f3372c87
DA
19972012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1998
1999 Block-based vector allocation of small vectors.
2000 * lisp.h (struct vectorlike_header): New field `nbytes',
2001 adjust comment accordingly.
2002 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2003 to denote vector blocks. Adjust users (live_vector_p,
2004 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2005 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2006 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2007 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2008 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2009 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2010 (roundup_size): New constant.
2011 (struct vector_block): New data type.
2012 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2013 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2014 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2015 (sweep_vectors): New functions.
2016 (allocate_vectorlike): Return `zero_vector' as the only vector of
2017 0 items. Allocate new vector from block if vector size is less than
2018 or equal to VBLOCK_BYTES_MAX.
2019 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2020 (init_alloc_once): Add call to init_vectors.
2021
4f18a4ed
SM
20222012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2023
2024 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2025
86f158bc
PE
20262012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * doprnt.c (doprnt): Truncate multibyte char correctly.
2029 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2030 would mishandle a string argument "Xc" if X was a multibyte
2031 character of length 2: it would truncate after X's first byte
2032 rather than including all of X.
2033
c5cfcbe0
CY
20342012-06-06 Chong Yidong <cyd@gnu.org>
2035
2036 * buffer.c (word_wrap): Doc fix.
2037
c05cf390
PE
20382012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2041
0c3461de
GM
20422012-06-03 Glenn Morris <rgm@gnu.org>
2043
2044 * xdisp.c (tool-bar-style): Doc fix.
2045
c71232db
UM
20462012-06-03 Ulrich Müller <ulm@gentoo.org>
2047
2048 * Makefile.in (PAXCTL): Define.
2049 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2050 binary via PaX flags if the paxctl utility is available.
2051 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2052 Restore PaX flags to their default. (Bug#11398)
2053
383f7350
CY
20542012-06-03 Chong Yidong <cyd@gnu.org>
2055
2056 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2057 buffer (Bug#11226).
2058
5f2c76c6
CY
20592012-06-03 Chong Yidong <cyd@gnu.org>
2060
2061 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2062 (note_mode_line_or_margin_highlight): If there is no help echo,
2063 use mode-line-default-help-echo. Handle the case where the mouse
2064 position is past the end of the mode line string.
2065
2066 * buffer.c (buffer_local_value_1): New function, split from
2067 Fbuffer_local_value; can return Qunbound.
2068 (Fbuffer_local_value): Use it.
2069 (Vmode_line_format): Docstring tweaks.
2070
773d47f6
PE
20712012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * sysdep.c (system_process_attributes): Improve comment.
2074
f2d6a3df
SM
20752012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2076
2077 * keyboard.c: Export real-this-command to Elisp.
2078 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2079 and DEFVAR it. Update all users.
2080
63810350
PE
20812012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2082
7bd5c1f4
PE
2083 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2084
63810350
PE
2085 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2086 Convert pctcpu and pctmem to Lisp float properly.
2087 Let the compiler fold better, as 100.0/0x8000 is exact.
2088
a2821611
AS
20892012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2090
2091 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2092 cons_block.
2093
5fceba1d
PE
20942012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2097
c98ff5dd
DA
20982012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2099
2100 For a 'struct window', replace some Lisp_Object fields to
2101 bitfields where appropriate, remove unused fields.
2102 * window.h (struct window): Remove unused 'last_mark_x' and
2103 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2104 change it's type from Lisp_Object to bitfield.
2105 Change type of 'force_start', 'optional_new_start',
2106 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2107 fields from Lisp_Object to bitfield. Adjust users accordingly.
2108
ca34e0be
PE
21092012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 Pacify gcc -Wdouble-precision when using Xaw.
2112 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2113 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2114 Use 'float' consistently, rather than 'float' in most places
2115 and 'double' in a couple of places.
2116
efc00ab1 21172012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2118
2119 * xdisp.c (handle_stop): Detect whether we have overlay strings
2120 loaded by testing it->current.overlay_string_index to be
2121 non-negative, instead of checking whether n_overlay_strings is
2122 positive. (Bug#11587)
2123
efc00ab1 21242012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2125
2126 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2127
2128 * doc.c (Fsubstitute_command_keys): Doc fix.
2129
efc00ab1 21302012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2131
2132 * search.c (search_buffer): Remove calls to
2133 r_alloc_inhibit_buffer_relocation, as it is now called by
2134 maybe_unify_char, which was the cause of relocation of buffer text
2135 in bug#11519.
2136
efc00ab1 21372012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2138
2139 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2140 for the duration of call to load_charset, to avoid problems with
2141 callers of maybe_unify_char that access buffer text through C
2142 pointers.
2143
2144 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2145 decrement the inhibition flag, instead of just setting or
2146 resetting it.
2147
ba93a187
PE
21482012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2149
2150 Remove obsolete '#define static' cruft.
2151 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2152 This #undef was "temporary" in 2000; it is no longer needed
2153 now that '#define static' has gone away.
2154 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2155 (gray_bitmap_bits): Remove; no longer needed.
2156 All uses replaced with definiens.
2157 * xterm.c: Include "bitmaps/gray.xbm".
2158
9e4bf381
PE
21592012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 Clean up __executable_start, monstartup when --enable-profiling.
2162 The following changes affect the code only when profiling.
2163 * dispnew.c (__executable_start): Rename from safe_bcopy.
2164 Define only on platforms that need it.
2165 * emacs.c: Include <sys/gmon.h> when profiling.
2166 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2167 (__executable_start): Remove decl, since lisp.h does it now.
2168 (safe_bcopy): Remove decl; no longer has that name.
2169 (main): Coalesce #if into single bit of code, for simplicity.
2170 Cast pointers to uintptr_t, since standard libraries want integers
2171 and not pointers.
2172 * lisp.h (__executable_start): New decl.
2173
32d72c2f
GM
21742012-05-31 Glenn Morris <rgm@gnu.org>
2175
2176 * image.c (Fimagemagick_types): Doc fix.
2177
baac5bc7
JM
21782012-05-30 Jim Meyering <meyering@redhat.com>
2179
2180 * callproc.c (Fcall_process_region): Include directory component
2181 in mkstemp error message (Bug#11586).
2182
72cb32cf
PE
21832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2184
2185 * alloc.c, lisp.h (make_pure_vector): Now static.
2186
61b108cc
SM
21872012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2188
2189 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2190 Move to byte-run.el.
2191 (Fautoload): Do the hash-doc more carefully.
2192 * data.c (Fdefalias): Purify definition, except for keymaps.
2193 (Qdefun): Move from eval.c.
2194 * lisp.h (Qdefun): Remove.
2195 * lread.c (read1): Tiny simplification.
2196
471fe23d
TN
21972012-05-29 Troels Nielsen <bn.troels@gmail.com>
2198
934f3f58 2199 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2200 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2201 Bug#9642, but explicitly check that the buffer the overlay would
2202 be moved to is live and rearrange lines to make sure that errors
2203 will not put the overlay in an inconsistent state.
2204 (Fdelete_overlay): Cosmetics.
2205
85d0efd1
EZ
22062012-05-28 Eli Zaretskii <eliz@gnu.org>
2207
2208 * w32term.c (my_bring_window_to_top): New function.
2209 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2210 could be different from the original one.
2211 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2212 (Bug#11513)
2213
2214 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2215 by calling BringWindowToTop.
2216
2217 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2218 (WM_EMACS_END): Increase by one.
2219
da92a98c
PE
22202012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2223 This avoids undefined behavior that might cause the eassert
2224 to not catch an out-of-range value.
2225
74d1f848
JB
22262012-05-28 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2229 Update dependencies.
2230
9e1a06fc
EZ
22312012-05-27 Eli Zaretskii <eliz@gnu.org>
2232
2233 * bidi.c (bidi_mirror_char): Fix last change.
2234
f3dd7312
AS
22352012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2236
2237 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2238 when referring to sectname field in printf format.
2239
81899c91
PE
22402012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2241
57b81a9f
PE
2242 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2243 Only r_alloc_inhibit_buffer_relocation needed to be added;
2244 the others were already declared.
2245
81899c91
PE
2246 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2247 before checking whether it's out of range. Put the check inside
2248 eassert. See
2249 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2250
33017faf 22512012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2252
2253 * callproc.c (Fcall_process): Restore a line that was accidentally
2254 commented out in the 2011-02-13 change (bug#11547).
2255
33017faf 22562012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2257
2258 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2259 defined on ralloc.c.
2260
2261 * buffer.c [REL_ALLOC]: Remove prototypes of
2262 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2263 they are now on lisp.h.
2264
2265 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2266
2267 * search.c (search_buffer): Use it to inhibit relocation of buffer
2268 text while re_search_2 is doing its job, because re_search_2 is
2269 passed C pointers to buffer text. (Bug#11519)
2270
23415acf
EZ
2271 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2272 Update value to 24.
2273
44e27368
EZ
2274 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2275 state after an additional call to move_it_in_display_line_to, keep
2276 the values of it->max_ascent and it->max_descent found for the
2277 entire line.
2278 (pos_visible_p): Revert the comparison against bottom_y to what it
2279 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2280 (Bug#11464)
2281
c1892f11
PE
22822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 Fix coding-related core dumps with gcc -ftrapv.
2285 The code was computing A - B, where A and B are pointers, and B is
2286 random garbage. This can lead to core dumps on platforms that
2287 have special pointer registers, and it also leads to core dumps on
2288 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2289 A - B only when B is initialized properly.
2290 * coding.c (coding_set_source, coding_set_destination): Return void.
2291 (coding_change_source, coding_change_destinations): New functions,
2292 with the old behaviors of coding_set_source and coding_set_destination.
2293 All callers that need an offset changed to use these new functions.
2294
eb7afdad
GM
22952012-05-26 Glenn Morris <rgm@gnu.org>
2296
2297 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2298
f12fdf02
EZ
22992012-05-26 Eli Zaretskii <eliz@gnu.org>
2300
53a63be6 2301 Extend mouse support on W32 text-mode console.
61b108cc
SM
2302 * xdisp.c (draw_row_with_mouse_face):
2303 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2304
eb3f6f01 2305 * w32console.c: Include window.h.
61b108cc
SM
2306 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2307 New functions.
eb3f6f01
EZ
2308 (initialize_w32_display): Initialize mouse-highlight data.
2309
53a63be6
EZ
2310 * w32inevt.c: Include termchar.h and window.h.
2311 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2312 moves, call note_mouse_highlight. If help_echo changed, call
2313 gen_help_event to produce help-echo message in the echo area.
2314 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2315 highlight info.
2316
4cfd81f6
PE
23172012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 * lread.c (read1): Simplify slightly to avoid an overflow warning
2320 with GCC 4.7.0 on x86-64.
2321
4446092a
EZ
23222012-05-26 Eli Zaretskii <eliz@gnu.org>
2323
2324 * bidi.c (bidi_mirror_char): Revert last change: an int is
2325 definitely wide enough here.
2326
42b2a986 23272012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2328
42b2a986 2329 Fix integer width and related bugs (Bug#9874).
eb106a49 2330 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2331 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2332 (string_bytes, check_sblock, allocate_string_data):
2333 (compact_small_strings, Fmake_bool_vector, make_string)
2334 (make_unibyte_string, make_multibyte_string)
2335 (make_string_from_bytes, make_specified_string)
2336 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2337 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2338 (mark_vectorlike):
2339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2340 (allocate_pseudovector):
2341 Use int, not EMACS_INT, where int is wide enough.
2342 (inhibit_garbage_collection, Fgarbage_collect):
2343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2344 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2345 int might not be wide enough.
2346 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2347 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2348 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2349 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2350 (bidi_level_of_next_char, bidi_move_to_visually_next):
2351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2352 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2353 (Fkill_buffer, Fset_buffer_major_mode)
2354 (advance_to_char_boundary, Fbuffer_swap_text)
2355 (Fset_buffer_multibyte, overlays_at, overlays_in)
2356 (overlay_touches_p, struct sortvec, record_overlay_string)
2357 (overlay_strings, recenter_overlay_lists)
2358 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2359 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2360 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2361 (Foverlay_recenter, last_overlay_modification_hooks_used)
2362 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2364 (validate_region): Omit unnecessary test for b <= e,
2365 since that's guaranteed by the previous test.
d311d28c
PE
2366 (adjust_overlays_for_delete): Avoid pos + length overflow.
2367 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2368 (report_overlay_modification):
2369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2370 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2371 Omit pointer cast, which isn't needed anyway, and doesn't work
2372 after the EMACS_INT -> ptrdiff_t change.
02481186 2373 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2374 * buffer.h: Adjust decls to match defn changes elsewhere.
2375 (struct buffer_text, struct buffer):
2376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2377 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2378 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2379 not int, to avoid needless 32-bit limit on 64-bit hosts.
2380 (exec_byte_code): Use tighter memory-full test, one that checks
2381 for alloca overflow. Don't compute the address of the object just
2382 before an array, as that's not portable. Use EMACS_INT, not
2383 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2384 * callint.c (Fcall_interactively):
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 * callproc.c (call_process_kill, Fcall_process):
2387 Don't assume pid_t fits into an Emacs fixnum.
2388 (call_process_cleanup, Fcall_process, child_setup):
2389 Don't assume pid_t fits into int.
2390 (call_process_cleanup, Fcall_process, delete_temp_file)
2391 (Fcall_process_region):
2392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2393 (Fcall_process): Simplify handling of volatile integers.
2394 Use int, not EMACS_INT, where int will do.
2395 * casefiddle.c (casify_object, casify_region, operate_on_word)
2396 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2398 (casify_object): Avoid integer overflow when overallocating buffer.
2399 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2400 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2401 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2402 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2403 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2404 integers are now checked earlier. All uses replaced with XINT.
2405 (ccl_driver):
2406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2407 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2408 (ccl_driver, Fregister_code_conversion_map):
2409 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2410 (resolve_symbol_ccl_program): Check that vector header is in range.
2411 Always copy the vector, so that we can check its contents reliably
2412 now rather than having to recheck each instruction as it's being
2413 executed. Check that vector words fit in 'int'.
2414 (ccl_get_compiled_code, Fregister_ccl_program)
2415 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2416 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2417 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2418 contents are in range.
2419 (Fccl_execute_on_string): Check that status is in range.
2420 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2421 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2422 Accept and return EMACS_INT, not int, because callers can pass values
2423 out of 'int' range.
2424 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2425 (multibyte_chars_in_text, parse_str_as_multibyte)
2426 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2427 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2428 (string_escape_byte8, Fget_byte):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2430 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2431 avoid mishandling large integers.
2432 * character.h: Adjust decls to match defn changes elsewhere.
2433 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2434 (Ffind_charset_region):
2435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2436 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2437 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2438 Don't assume fixnum fits in int.
d311d28c
PE
2439 (load_charset_map_from_vector, Fmap_charset_chars):
2440 Remove now-unnecessary CHECK_NATNUMs.
2441 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2442 Don't rely on undefined behavior with signed left shift overflow.
2443 Don't assume unsigned int fits into fixnum, or that fixnum fits
2444 into unsigned int. Don't require max_code to be a valid fixnum;
2445 that's not true for gb10830 4-byte on a 32-bit host. Allow
2446 invalid_code to be a cons, for the same reason. Require code_offset
2447 to be a character. Avoid int overflow if max_char is close
2448 to INT_MAX.
2449 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2450 this is intended anyway and avoids some undefined behavior.
2451 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2452 INDEX_TO_CODE_POINT, as that's what it expects.
2453 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2454 * charset.h (DECODE_CHAR): Return int, not unsigned;
2455 this is what was intended anyway, and it avoids undefined behavior.
2456 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2457 integer-overflow issues.
2458 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2459 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2460 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2461 * chartab.c (Fmake_char_table, Fset_char_table_range)
2462 (uniprop_get_decoder, uniprop_get_encoder):
2463 Don't assume fixnum fits in int.
2464 * cmds.c (move_point): New function, that does the gist of
2465 Fforward_char and Fbackward_char, but does so while checking
2466 for integer overflow more accurately.
c96e5d6a 2467 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2468 (Fforward_line, Fend_of_line, internal_self_insert)
2469 (internal_self_insert):
2470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2471 Fix a FIXME, by checking for integer overflow when calculating
2472 target_clm and actual_clm.
2473 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2474 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2475 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2476 (coding_alloc_by_making_gap, alloc_destination)
2477 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2478 (encode_coding_utf_16, detect_coding_emacs_mule)
2479 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2480 (detect_coding_iso_2022, decode_coding_iso_2022)
2481 (encode_invocation_designation, encode_designation_at_bol)
2482 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2483 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2484 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2485 (encode_coding_ccl, encode_coding_raw_text)
2486 (detect_coding_charset, decode_coding_charset)
2487 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2488 (produce_composition, produce_charset, produce_annotation)
2489 (decode_coding, handle_composition_annotation)
2490 (handle_charset_annotation, consume_chars, decode_coding_gap)
2491 (decode_coding_object, encode_coding_object, detect_coding_system)
2492 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2493 (code_convert_region, code_convert_string)
8f50130c
PE
2494 (Fdefine_coding_system_internal)
2495 (coding_set_source, coding_set_destination):
d311d28c
PE
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2498 (Fdefine_coding_system_internal):
2499 Don't assume fixnums fit in int.
2500 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2501 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2502 (Funencodable_char_position, Fcheck_coding_systems_region)
2503 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2505 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2506 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2507 Don't access memory outside of the args array.
d311d28c 2508 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2509 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2510 result of ENCODE_CHAR.
d311d28c
PE
2511 * coding.h: Adjust decls to match defn changes elsewhere.
2512 (struct coding_system):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 * composite.c (get_composition_id, find_composition)
2515 (run_composition_function, update_compositions)
2516 (compose_text, composition_gstring_put_cache)
2517 (composition_gstring_p, composition_gstring_width)
2518 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2519 (composition_compute_stop_pos, composition_reseat_it)
2520 (composition_update_it, struct position_record)
2521 (find_automatic_composition, composition_adjust_point)
2522 (Fcomposition_get_gstring, Ffind_composition_internal):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2524 (update_compositions):
2525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2526 * composite.h: Adjust decls to match defn changes elsewhere.
2527 (struct composition):
2528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2529 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2530 Do not attempt to compute the address of the object just before a
2531 buffer; this is not portable.
2532 (Faref, Faset):
2533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2534 (Faset): Use int, not EMACS_INT, where int is wide enough.
2535 (Fstring_to_number): Don't assume fixnums fit in int.
2536 (Frem): Don't assume arg is nonnegative.
2537 * dbusbind.c (xd_append_arg): Check for integers out of range.
2538 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2539 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2540 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2541 (xd_get_connection_references): Return ptrdiff_t, not int.
2542 All uses changed.
2543 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2544 (xd_read_message_1):
2545 Use int, not unsigned, where the dbus API uses int.
2546 (Fdbus_message_internal): Don't overflow mtype.
2547 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2548 * dired.c (directory_files_internal, file_name_completion, scmp)
2549 (file_name_completion_stat):
2550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2551 (file_name_completion): Don't overflow matchcount.
2552 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2553 * dispextern.h: Adjust decls to match defn changes elsewhere.
2554 (struct text_pos, struct glyph, struct bidi_saved_info)
2555 (struct bidi_string_data, struct bidi_it, struct composition_it)
2556 (struct it):
2557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2558 (struct display_pos, struct composition_it, struct it):
2559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2560 * dispnew.c (increment_matrix_positions)
2561 (increment_row_positions, mode_line_string)
2562 (marginal_area_string):
2563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2564 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2566 (duration_to_sec_usec): New function, to check for overflow better.
2567 (Fsleep_for, sit_for): Use it.
2568 * doc.c (get_doc_string, store_function_docstring):
2569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2570 (get_doc_string, Fsnarf_documentation):
2571 Use int, not EMACS_INT, where int is wide enough.
2572 (get_doc_string):
2573 Use SAFE_ALLOCA, not alloca.
2574 Check for overflow when converting EMACS_INT to off_t.
2575 * doprnt.c (doprnt):
2576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2577 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2578 Don't assume uid_t fits into fixnum.
2579 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2580 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2581 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2582 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2583 (general_insert_function)
2584 (Finsert_char, make_buffer_string, make_buffer_string_both)
2585 (update_buffer_properties, Fbuffer_substring)
2586 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2587 (Fsubst_char_in_region, check_translation)
2588 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2589 (transpose_markers, Ftranspose_regions):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 (clip_to_bounds): Move to lisp.h as an inline function).
2592 (Fconstrain_to_field): Don't assume integers are nonnegative.
2593 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2594 (Fsubst_char_in_region, Fsave_restriction):
2595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2596 (Femacs_pid): Don't assume pid_t fits into fixnum.
2597 (lo_time): Use int, not EMACS_INT, when int suffices.
2598 (lisp_time_argument): Check for usec out of range.
2599 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2600 (Fuser_login_name, Fuser_full_name): Signal an error
2601 if a uid argument is out of range, rather than relying on
2602 undefined behavior.
c8d5c857
PE
2603 (Fformat_time_string): Remove now-unnecessary check.
2604 lisp_time_argument checks for out-of-range usec now.
243e0530 2605 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2606 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2607 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2608 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2609 (init_cmdargs, Fdump_emacs):
2610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2611 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2612 the bottom (typically) 32 bits of the fixnum.
2613 * eval.c (specpdl_size, call_debugger):
2614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2615 (when_entered_debugger, Fbacktrace_debug):
2616 Don't assume fixnum can fit in int.
2617 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2618 the object just before a buffer; this is not portable.
2619 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2620 (grow_specpdl, unbind_to):
2621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2622 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2623 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2624 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2625 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2626 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2628 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2629 (a_write, e_write):
2630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2631 (Fcopy_file, non_regular_nbytes, read_non_regular)
2632 (Finsert_file_contents):
2633 Use int, not EMACS_INT, where int is wide enough.
2634 (READ_BUF_SIZE): Verify that it fits in int.
2635 (Finsert_file_contents): Check that counts are in proper range,
2636 rather than assuming fixnums fit into ptrdiff_t etc.
2637 Don't assume fixnums fit into int.
125b3835 2638 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2639 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2640 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2641 (string_char_to_byte, string_byte_to_char)
2642 (string_make_multibyte, string_to_multibyte)
2643 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2644 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2645 (substring_both, Fdelete, internal_equal, Ffillarray)
2646 (Fclear_string, mapcar1)
2647 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2648 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2649 (larger_vector, make_hash_table, maybe_resize_hash_table)
2650 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2651 (Fmaphash, secure_hash):
2652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (concat): Check for string index and length overflow.
2654 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2655 (Frequire):
2656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2657 (larger_vector): New API (vec, incr_min, size_max) replaces old
2658 one (vec, new_size, init). This catches size overflow.
2659 INIT was removed because it was always Qnil.
2660 All callers changed.
2661 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2662 the upper bound on a hash table index size.
2663 (make_hash_table, maybe_resize_hash_table): Use it.
2664 (secure_hash): Computer start_byte and end_byte only after
2665 they're known to be in ptrdiff_t range.
2666 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2667 (Ffont_get_glyphs, Ffont_at):
2668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2669 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2670 (Flist_fonts, Fopen_font):
2671 Don't assume fixnum can fit in int.
2672 (check_gstring): Don't assume index can fit in int.
2673 (font_match_p): Check that fixnum is a character, not a nonnegative
2674 fixnum, since the later code needs to stuff it into an int.
2675 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2676 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2677 conversion overflow issues.
2678 (Fopen_font): Check for integer out of range.
2679 (Ffont_get_glyphs): Don't assume index can fit in int.
2680 * font.h: Adjust decls to match defn changes elsewhere.
2681 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2682 integer overflow.
2683 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2684 printmax_t, where ptrdiff_t is wide enough.
2685 (Finternal_char_font):
2686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2687 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2688 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2689 (Fset_frame_position, x_set_frame_parameters)
2690 (x_set_line_spacing, x_set_border_width)
2691 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2692 Check that fixnums are in proper range for system types.
2693 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2695 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2696 Use SAFE_ALLOCA_LISP, not alloca.
2697 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2698 intptr_t is wide enough.
2699 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2700 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2701 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2702 Check for fixnum out of range.
2703 * ftfont.c (ftfont_list): Don't assume index fits in int.
2704 Check that fixnums are in proper range for system types.
2705 (ftfont_shape_by_flt):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2707 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2709 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2710 Check that fixnums are in proper range for system types.
2711 * gnutls.h: Adjust decls to match defn changes elsewhere.
2712 * gtkutil.c (xg_dialog_run):
2713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2714 (update_frame_tool_bar):
2715 Check that fixnums are in proper range for system types.
2716 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2717 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2718 * indent.c (last_known_column, last_known_column_point):
2719 (current_column_bol_cache):
2720 (skip_invisible, current_column, check_display_width):
2721 (check_display_width, scan_for_column, current_column_1)
2722 (Findent_to, Fcurrent_indentation, position_indentation)
2723 (indented_beyond_p, Fmove_to_column, compute_motion):
2724 (Fcompute_motion, Fvertical_motion):
2725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2726 (last_known_column_modified): Use EMACS_INT, not int.
2727 (check_display_width):
2728 (Fcompute_motion):
2729 Check that fixnums and floats are in proper range for system types.
2730 (compute_motion): Don't assume index or fixnum fits in int.
2731 (compute_motion, Fcompute_motion):
2732 Use int, not EMACS_INT, when it is wide enough.
2733 (vmotion): Omit local var start_hpos that is always 0; that way
2734 we don't need to worry about overflow in expressions involving it.
2735 * indent.h: Adjust decls to match defn changes elsewhere.
2736 (struct position):
2737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2738 Use int, not EMACS_INT, where int is wide enough.
2739 Remove unused members ovstring_chars_done and tab_offset;
2740 all uses removed.
2741 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2742 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2743 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2744 (make_gap, copy_text, insert, insert_and_inherit)
2745 (insert_before_markers, insert_before_markers_and_inherit)
2746 (insert_1, count_combining_before, count_combining_after)
2747 (insert_1_both, insert_from_string)
2748 (insert_from_string_before_markers, insert_from_string_1)
2749 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2750 (adjust_after_replace, adjust_after_insert, replace_range)
2751 (replace_range_2, del_range, del_range_1, del_range_byte)
2752 (del_range_both, del_range_2, modify_region)
2753 (prepare_to_modify_buffer, signal_before_change)
2754 (signal_after_change, Fcombine_after_change_execute):
2755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2756 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2757 (balance_an_interval, split_interval_right, split_interval_left)
2758 (find_interval, next_interval, update_interval)
2759 (adjust_intervals_for_insertion, delete_node, delete_interval)
2760 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2761 (static_offset_intervals, offset_intervals)
2762 (merge_interval_right, merge_interval_left, make_new_interval)
2763 (graft_intervals_into_buffer, temp_set_point_both)
2764 (temp_set_point, set_point, adjust_for_invis_intang)
2765 (set_point_both, move_if_not_intangible, get_property_and_range)
2766 (get_local_map, copy_intervals, copy_intervals_to_string)
2767 (compare_string_intervals, set_intervals_multibyte_1):
2768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2769 * intervals.h: Adjust decls to match defn changes elsewhere.
2770 (struct interval):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 * keyboard.c (this_command_key_count, this_single_command_key_start)
2773 (before_command_key_count, before_command_echo_length, echo_now)
2774 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2775 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2776 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2777 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2779 (last_non_minibuf_size, last_point_position, echo_truncate)
2780 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2781 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2782 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2783 (stuff_buffered_input):
2784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2785 (last_auto_save, command_loop_1, read_char):
2786 Use EMACS_INT, not int, to avoid integer overflow.
2787 (record_char): Avoid overflow in total_keys computation.
2788 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2789 * keyboard.h: Adjust decls to match defn changes elsewhere.
2790 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2791 (Fkey_description, Fdescribe_vector, Flookup_key):
2792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2793 (click_position): New function, to check that positions are in range.
2794 (Fcurrent_active_maps):
2795 (describe_command):
2796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2797 (Faccessible_keymaps, Fkey_description):
2798 (preferred_sequence_p):
2799 Don't assume fixnum can fit into int.
2800 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2801 Check for integer overflow in size calculations.
2802 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2803 avoid mishandling large integers.
2804 * lisp.h: Adjust decls to match defn changes elsewhere.
2805 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2806 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2807 (struct Lisp_Marker):
2808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2809 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2810 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2811 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2812 All callers changed.
2813 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2814 Assume the arg has valid form, since it always does.
2815 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2816 unsigned integer system type.
2817 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2818 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2820 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2821 (duration_to_sec_usec): New decl.
2822 * lread.c (read_from_string_index, read_from_string_index_byte)
2823 (read_from_string_limit, readchar, unreadchar, openp)
2824 (read_internal_start, read1, oblookup):
2825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2826 (Fload, readevalloop, Feval_buffer, Feval_region):
2827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2828 (openp): Check for out-of-range argument to 'access'.
2829 (read1): Use int, not EMACS_INT, where int is wide enough.
2830 Don't assume fixnum fits into int.
6efdadfd 2831 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2832 (read_filtered_event): Use duration_to_sec_usec
2833 to do proper overflow checking on durations.
d311d28c
PE
2834 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2835 in size calculation.
2836 (Fexecute_kbd_macro):
2837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2838 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2839 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2840 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2841 (set_marker_both, set_marker_restricted_both, marker_position)
2842 (marker_byte_position, Fbuffer_has_markers_at):
2843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2844 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2845 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2846 It now merely ensures that the menu is large enough, without
2847 necessarily growing it, as this avoids some integer overflow issues.
2848 All callers changed.
2849 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2851 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2852 Use SAFE_ALLOCA_LISP, not alloca.
2853 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2854 to EMACS_INT. Check that fixnums are in proper range for system types.
2855 * minibuf.c (minibuf_prompt_width, string_to_object)
2856 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2857 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2859 (get_minibuffer, read_minibuf_unwind):
2860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2861 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2862 this simplifies overflow checking. All callers changed.
2863 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2864 (Ftest_completion):
2865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2866 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2867 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2868 Check that fixnums are in proper range for system types.
2869 (Fx_create_frame, Fx_show_tip):
2870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2871 * nsfont.m (ns_findfonts, nsfont_list_family):
2872 Don't assume fixnum fits in long.
2873 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2875 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2876 wide enough.
17fdb222 2877 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2879 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2880 (PRINTDECLARE, PRINTPREPARE):
2881 (strout, print_string):
2882 (print, print_preprocess, print_check_string_charset_prop)
2883 (print_object):
2884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2885 (PRINTDECLARE):
2886 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2888 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2889 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2890 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2891 (print_error_message): Use SAFE_ALLOCA, not alloca.
2892 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2893 (print_depth, new_backquote_output, print_number_index):
2894 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2895 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2896 (Fset_process_window_size, Fformat_network_address)
2897 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2898 (sigchld_handler):
d311d28c 2899 Check that fixnums are in proper range for system types.
d44287d4 2900 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2901 Check for process-ids out of pid_t range rather than relying on
2902 undefined behavior.
e4d81efc 2903 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2904 (Fformat_network_address, read_process_output, send_process)
2905 (Fprocess_send_region, status_notify):
2906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2907 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2908 (wait_reading_process_output, read_process_output, exec_sentinel):
2909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2910 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2911 (Faccept_process_output): Use duration_to_sec_usec to do proper
2912 overflow checking on durations.
dde14581
PE
2913 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2914 Don't assume pid_t fits in int.
02481186
PE
2915 * process.h (struct Lisp_Process): Members tick and update_tick
2916 are now of type EMACS_INT, not int.
b62b53e8
PE
2917 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2918 configured --with-wide-int.
d311d28c
PE
2919 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2920 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2921 * search.c (looking_at_1, string_match_1):
2922 (fast_string_match, fast_c_string_match_ignore_case)
2923 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2924 (scan_newline, find_before_next_newline, search_command)
2925 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2926 (set_search_regs, wordify):
2927 (Freplace_match):
2928 (Fmatch_data):
2929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2930 (string_match_1, search_buffer, set_search_regs):
2931 (Fmatch_data):
2932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2933 (wordify): Check for overflow in size calculation.
2934 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2935 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2936 Check that fixnums are in proper range for system types.
2937 * sound.c (struct sound_device)
2938 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2940 (Fplay_sound_internal):
2941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2942 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2943 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2944 (Fparse_partial_sexp):
2945 Don't assume fixnums can fit in int.
2946 (struct lisp_parse_state, find_start_pos, find_start_value)
2947 (find_start_value_byte, find_start_begv)
2948 (update_syntax_table, char_quoted, dec_bytepos)
2949 (find_defun_start, prev_char_comend_first, back_comment):
2950 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2951 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2953 (Finternal_describe_syntax_value): Check that match_lisp is a
2954 character, not an integer, since the code stuffs it into int.
2955 (scan_words, scan_sexps_forward):
2956 Check that fixnums are in proper range for system types.
2957 (Fforward_word):
2958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2959 (scan_sexps_forward):
2960 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2961 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2962 * syntax.h: Adjust decls to match defn changes elsewhere.
2963 (struct gl_state_s):
2964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2965 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2966 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2967 * sysdep.c (wait_for_termination_1, wait_for_termination)
2968 (interruptible_wait_for_termination, mkdir):
2969 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2970 (emacs_read, emacs_write):
2971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2972 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2973 and double all fit in int.
d311d28c
PE
2974 * term.c (set_tty_color_mode):
2975 Check that fixnums are in proper range for system types.
2976 * termhooks.h (struct input_event):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 * textprop.c (validate_interval_range, interval_of)
2979 (Fadd_text_properties, set_text_properties_1)
2980 (Fremove_text_properties, Fremove_list_of_text_properties)
2981 (Ftext_property_any, Ftext_property_not_all)
2982 (copy_text_properties, text_property_list, extend_property_ranges)
2983 (verify_interval_modification):
2984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2985 (Fnext_single_char_property_change)
2986 (Fprevious_single_char_property_change):
2987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2988 (copy_text_properties):
2989 Check for integer overflow in index calculation.
d311d28c
PE
2990 * undo.c (last_boundary_position, record_point, record_insert)
2991 (record_delete, record_marker_adjustment, record_change)
2992 (record_property_change):
2993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2994 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2996 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2997 (Fx_hide_tip, Fx_file_dialog):
2998 * w32menu.c (set_frame_menubar):
2999 Use ptrdiff_t, not int, for consistency with rest of code.
3000 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3001 (select_window, Fdelete_other_windows_internal)
3002 (window_scroll_pixel_based, window_scroll_line_based)
3003 (Frecenter, Fset_window_configuration):
3004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3005 (Fset_window_hscroll, run_window_configuration_change_hook)
3006 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3007 (Fscroll_other_window, Frecenter):
d311d28c
PE
3008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3009 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3010 Don't assume fixnum fits in int.
3011 (Fset_window_scroll_bars):
3012 Check that fixnums are in proper range for system types.
3013 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3014 (string_pos, c_string_pos, number_of_chars, init_iterator)
3015 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3016 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3017 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3018 (face_before_or_after_it_pos, handle_invisible_prop)
3019 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3020 (display_prop_intangible_p, string_buffer_position_lim)
3021 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3022 (get_overlay_strings_1, get_overlay_strings)
3023 (iterate_out_of_display_property, forward_to_next_line_start)
3024 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3025 (get_next_display_element, set_iterator_to_next)
3026 (get_visually_first_element, compute_stop_pos_backwards)
3027 (handle_stop_backwards, next_element_from_buffer)
3028 (move_it_in_display_line_to, move_it_in_display_line)
3029 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3030 (add_to_log, message_dolog, message_log_check_duplicate)
3031 (message2, message2_nolog, message3, message3_nolog
3032 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3033 (current_message_1, truncate_echo_area, truncate_message_1)
3034 (set_message, set_message_1, store_mode_line_noprop)
3035 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3036 (text_outside_line_unchanged_p, check_point_in_composition)
3037 (reconsider_clip_changes)
3038 (redisplay_internal, set_cursor_from_row, try_scrolling)
3039 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3040 (redisplay_window, find_last_unchanged_at_beg_row)
3041 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3042 (trailing_whitespace_p, find_row_edges, display_line)
3043 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3044 (display_mode_element, store_mode_line_string)
3045 (pint2str, pint2hrstr, decode_mode_spec)
3046 (display_count_lines, display_string, draw_glyphs)
3047 (x_produce_glyphs, x_insert_glyphs)
3048 (rows_from_pos_range, mouse_face_from_buffer_pos)
3049 (fast_find_string_pos, mouse_face_from_string_pos)
3050 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3052 (safe_call, init_from_display_pos, handle_fontified_prop)
3053 (handle_single_display_spec, load_overlay_strings)
3054 (with_echo_area_buffer, setup_echo_area_for_printing)
3055 (display_echo_area, echo_area_display)
3056 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3057 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3058 (redisplay_window, dump_glyph_row, display_mode_line)
3059 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3060 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3062 (handle_single_display_spec, build_desired_tool_bar_string)
3063 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3064 (get_specified_cursor_type):
3065 Check that fixnums are in proper range for system types.
3066 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3067 (Flookup_image_map):
3068 Don't assume fixnums fit in int.
3069 (compare_overlay_entries):
3070 Avoid mishandling comparisons due to subtraction overflow.
3071 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3072 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3073 (handle_tool_bar_click):
3074 Use int, not unsigned, since we prefer signed and the signedness
3075 doesn't matter here.
3076 (get_next_display_element, next_element_from_display_vector):
3077 Use int, not EMACS_INT, when int is wide enough.
3078 (start_hourglass): Use duration_to_sec_usec to do proper
3079 overflow checking on durations.
3080 * xfaces.c (Fbitmap_spec_p):
3081 Check that fixnums are in proper range for system types.
3082 (compare_fonts_by_sort_order):
3083 Avoid mishandling comparisons due to subtraction overflow.
3084 (Fx_family_fonts, realize_basic_faces):
3085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3086 (Fx_family_fonts):
3087 Don't assume fixnum fits in int.
3088 Use SAFE_ALLOCA_LISP, not alloca.
3089 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3090 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3091 (face_at_buffer_position, face_for_overlay_string)
3092 (face_at_string_position):
3093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3094 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3095 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3096 (Fx_show_tip):
3097 Check that fixnums are in proper range for system types.
3098 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3099 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3101 (Fx_change_window_property): Don't assume fixnums fit in int.
3102 * xfont.c (xfont_chars_supported):
3103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3104 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3105 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3107 * xml.c (parse_region):
3108 * xrdb.c (magic_file_p):
3109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3110 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3111 (x_get_local_selection, x_reply_selection_request)
3112 (x_handle_selection_request, wait_for_property_change):
3113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3114 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3115 short is wide enough.
3116 (x_send_client_event): Don't assume fixnum fits in int.
3117 * xterm.c (x_x_to_emacs_modifiers):
3118 Don't assume EMACS_INT overflows nicely into int.
3119 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3120 may come from Lisp.
3121 (handle_one_xevent): NATNUMP can eval its arg twice.
3122 (x_connection_closed):
3123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3124 * xterm.h: Adjust decls to match defn changes elsewhere.
3125 (struct scroll_bar): Use struct vectorlike_header
3126 rather than rolling our own approximation.
3127 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3128
c6574eb5
GM
31292012-05-25 Glenn Morris <rgm@gnu.org>
3130
3131 * lisp.mk (lisp): Update for more files being compiled now.
3132
e8d32c7e
SM
31332012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3134
48def666
SM
3135 * lread.c: Remove `read_pure' which makes no difference.
3136 (read_pure): Remove var.
3137 (unreadpure): Remove function.
3138 (readevalloop): Don't call read_list with -1 flag.
3139 (read1, read_vector): Don't test read_pure any more.
3140 (read_list): Simplify.
3141
e8d32c7e
SM
3142 * fileio.c, character.h: Minor style tweaks.
3143
4b2addb7
DA
31442012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3145
3146 * window.h (clip_changed): Remove useless declaration.
3147
584461b2
JB
31482012-05-22 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3151 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3152
34374650
PE
31532012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3154
3155 Remove src/m/*.
3156 This directory predates autoconf and is no longer needed nowadays.
3157 Move its few remaining bits of functionality to where they're needed.
3158 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3159 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3160 * m/template.h: Remove.
3161 * Makefile.in (M_FILE): Remove. All uses removed.
3162 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3163 * lisp.h (USE_LSB_TAG):
3164 * mem-limits.h (EXCEEDS_LISP_PTR):
3165 Use VAL_MAX, not VALBITS, in #if.
3166 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3167 (EMACS_UINT): Define unconditionally now.
3168 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3169 (BITS_PER_EMACS_INT): New constants, replacing
3170 what used to be in config.h, but not useful in #if.
3171 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3172 define them any more.
3173 (VAL_MAX): New macro.
3174 (VALMASK): Use it.
3175 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3176 BITS_PER_EMACS_INT, in #if.
3177 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3178 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3179 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3180 * s/ms-w32.h (DATA_START):
3181 Move here from removed file m/intel386.h.
3182 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3183 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3184
261cb4bb
PE
31852012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3186
3187 Assume C89 or later.
3188 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3189 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3190 (xrealloc):
3191 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3192 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3193 * textprop.c, tparam.c (NULL): Remove.
3194 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3195 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3196 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3197 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3198 * xterm.c (input_signal_count): Assume volatile works.
3199
ff23cd9f
KB
32002012-05-21 Ken Brown <kbrown@cornell.edu>
3201
3202 * xgselect.c (xg_select): Fix first argument in call to 'select'
3203 (bug#11508).
3204
1b170bc6
KB
32052012-05-20 Ken Brown <kbrown@cornell.edu>
3206
3207 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3208 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3209
b2f4d39f
KB
32102012-05-19 Ken Brown <kbrown@cornell.edu>
3211
3212 * xfns.c (x_in_use): Remove `static' qualifier.
3213 * xterm.h (x_in_use): Declare.
3214 * xgselect.c: Include xterm.h.
3215 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3216 and `display_arg' (bug#9754).
3217
003fdae2
PE
32182012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3219
9232a6d9
PE
3220 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3221
003fdae2
PE
3222 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3223 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3224
784b56e2
EZ
32252012-05-18 Eli Zaretskii <eliz@gnu.org>
3226
3227 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3228
3229 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3230 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3231
3232 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3233 reference to image_cache->refcount.
3234 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3235
a0a79cde
JL
32362012-05-17 Juri Linkov <juri@jurta.org>
3237
3238 * search.c (Fword_search_regexp, Fword_search_backward)
3239 (Fword_search_forward, Fword_search_backward_lax)
3240 (Fword_search_forward_lax): Move functions to isearch.el
3241 (bug#10145, bug#11381).
3242
b0572523
PE
32432012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3246
9660f5fc
SM
32472012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3248
3249 * lread.c (init_obarray): Declare Qt and Qnil as special.
3250
4374de83
GM
32512012-05-14 Glenn Morris <rgm@gnu.org>
3252
3253 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3254 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3255
dc44c39a
PE
32562012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3257
078c97cb
PE
3258 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3259
dc44c39a
PE
3260 * unexaix.c: Port to more-recent AIX compilers.
3261 (report_error, report_error_1, make_hdr, copy_sym)
3262 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3263 Make arguments const char *, not char *, to avoid violations of C
3264 standard and to fix some AIX warnings reported by Gilles Pion.
3265
e18afed7 32662012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3267
3268 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3269 already have overlays loaded.
3270 (handle_single_display_spec): Before returning without displaying
3271 fringe bitmap, synchronize the bidi iterator with the main display
3272 iterator, by calling iterate_out_of_display_property.
3273 (iterate_out_of_display_property): Detect buffer iteration by
3274 testing that it->string is a Lisp string.
3275 (get_next_display_element): When the current object is exhausted,
3276 and there's something on it->stack, call set_iterator_to_next to
3277 proceed with what's on the stack, instead of returning zero.
3278 (set_iterator_to_next): If called at the end of a Lisp string,
3279 proceed to consider_string_end without incrementing string
3280 position. Don't increment display vector index past the end of
3281 the display vector. (Bug#11417)
c8fb9dc6
EZ
3282 (pos_visible_p): Don't report a position visible when move_it_to
3283 stopped at the last line of window, which happens to be scanned
3284 backwards by the bidi iteration. (Bug#11464)
ac268e67 3285
e18afed7 32862012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3287
3288 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3289 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3290 are on a TTY, and thus unable to display on the fringes.
3291 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3292 so we need to signal to the caller that this is a "replacing"
3293 display spec. This fixes display when the spec is invalid or we
3294 are on a TTY.
3295
e18afed7 32962012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3297
3298 * unexaix.c (make_hdr): Fix typo in prototype.
3299 This bug broke the build on AIX. Problem reported by Gilles Pion.
3300
9d0a235a
MA
33012012-05-14 Michael Albinus <michael.albinus@gmx.de>
3302
3303 * keyboard.c (kbd_buffer_get_event): Read special events also in
3304 batch mode. (Bug#11415)
3305
9e6b06ed
GM
33062012-05-12 Glenn Morris <rgm@gnu.org>
3307
3308 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3309
c1a1d7a3
EZ
33102012-05-12 Eli Zaretskii <eliz@gnu.org>
3311
3312 * lisp.mk (lisp): Add newcomment.elc.
3313
3fe7cdc8
GM
33142012-05-12 Glenn Morris <rgm@gnu.org>
3315
3316 * Makefile.in (MKDIR_P): New, set by configure.
3317 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3318
53f7d2c0
PE
33192012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 Remove unused function hourglass_started.
3322 * dispextern.h (hourglass_started):
3323 * w32fns.c (hourglass_started):
3324 * xdisp.c (hourglass_started): Remove.
3325
75aafb17
JB
33262012-05-10 Juanma Barranquero <lekktu@gmail.com>
3327
3328 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3329 Update dependencies.
3330
12959e8e
PE
33312012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3332
97107e2e
PE
3333 * xgselect.c (xg_select): Put maxfds+1 into a var.
3334 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3335
12959e8e
PE
3336 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3337
836d29b3
DA
33382012-05-10 Dave Abrahams <dave@boostpro.com>
3339
3340 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3341 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3342
5cb67954
MA
33432012-05-09 Michael Albinus <michael.albinus@gmx.de>
3344
3345 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3346 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3347 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3348 Initialize xd_registered_buses.
3349
3478ec45
PE
33502012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3351
b263a6b0
PE
3352 Untag more efficiently if USE_LSB_TAG.
3353 This is based on a proposal by YAMAMOTO Mitsuharu in
3354 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3355 For an admittedly artificial (nth 8000 longlist) benchmark on
3356 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3357 Emacs's overall text size by 1%.
3358 * lisp.h (XUNTAG): New macro.
3359 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3360 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3361 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3362 * eval.c (Fautoload):
3363 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3364 * frame.h (XFRAME): Use XUNTAG.
3365
3478ec45
PE
3366 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3367 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3368 Remove unportable assumptions about print widths of types like
3369 dbus_uint32_t.
3370 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3371 intptr_t when converting between pointer and integer, to avoid GCC
3372 warnings about wrong width.
3373
666b903b 33742012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3375
3376 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3377 stack for each reader_thread, instead of defaulting to 8MB
3378 determined by the linker. This avoids failures in creating
3379 subprocesses on Windows 7, see the discussion in this thread:
3380 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3381
b120cc17
JC
33822012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3383
3384 Fix up display of the *Minibuf-0* buffer in the mini window.
3385 * keyboard.c (read_char): Don't clear the echo area if there's no
3386 message to clear.
3387 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3388 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3389
9a4b36f8
MA
33902012-05-07 Michael Albinus <michael.albinus@gmx.de>
3391
3392 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3393 batch mode.
3394
e5f9458f
CY
33952012-05-06 Chong Yidong <cyd@gnu.org>
3396
3397 * lisp.mk (lisp): Update.
3398
eceeb5fc 33992012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3400
3401 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3402
71873e2b
SM
34032012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3404
3405 * data.c (PUT_ERROR): New macro.
3406 (syms_of_data): Use it. Add new error type `user-error'.
3407 * undo.c (user_error): New function.
3408 (Fprimitive_undo): Use it.
3409 * print.c (print_error_message): Adjust print style for `user-error'.
3410 * keyboard.c (user_error): New function.
3411 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3412
ab0fa4e4
PE
34132012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 Do not limit current-time-string to years 1000..9999.
3416 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3417 (Fcurrent_time_string): Support any year that is supported by the
3418 underlying localtime representation. Don't use asctime, as it
3419 has undefined behavior for years outside the range -999..9999.
3420
7ed806a7
PE
34212012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 Fix race conditions involving setenv, gmtime, localtime, asctime.
3424 Without this fix, interrupts could mess up code that uses these
3425 nonreentrant functions, since setting TZ invalidates existing
3426 tm_zone or tzname values, and since most of these functions return
3427 pointers to static storage.
3428 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3429 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3430 Grow the critical sections to include not just invoking
3431 localtime/gmtime, but also accessing these functions' results
3432 including their tm_zone values if any, and any related TZ setting.
3433 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3434 so that the struct tm is saved in the critical section.
3435 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3436 motivated by the fact that memory allocation needs to be outside
3437 the critical section.
3438
0c16dfed
DA
34392012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3440
3441 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3442 with RESET_INTERVAL.
3443
3444 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3445 Remove duplicated buffer name initialization.
3446
3f83ace8
JM
34472012-05-02 Jim Meyering <jim@meyering.net>
3448
3449 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3450
c7b8541e
JM
3451 * xfns.c (x_window): Use xstrdup (Bug#11375).
3452
90207a15 34532012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3454
3455 * xdisp.c (pos_visible_p): If already at a newline from the
3456 display string before the 'while' loop, don't walk back the glyphs
3457 from it3.glyph_row. Solves assertion violation when the display
3458 string begins with a newline (egg.el). (Bug#11367)
3459
b593d6a9
AH
34602012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3461
3462 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3463 Move to simple.el.
3464
4737362e
GM
34652012-05-01 Glenn Morris <rgm@gnu.org>
3466
99cf43f9
GM
3467 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3468 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3469 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3470 All were removed before 23.1.
3471
9311dcff
GM
3472 * dispnew.c: Remove HAVE_LIBNCURSES test;
3473 it is always true on relevant platforms.
3474
4d5c6349
GM
3475 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3476 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3477
4737362e
GM
3478 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3479
74dd3a6b
AS
34802012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3481
3482 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3483 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3484 Remove.
3485
13c379ee
PE
34862012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 Do not avoid creating empty evaporating overlays (Bug#9642).
3489 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3490 That is, do not delete an evaporating overlay if it becomes
3491 empty after its bounds are adjusted to fit within its buffer.
3492 This fix caused other problems, and I'm reverting it until we get
3493 to the bottom of them.
3494
a8e7d6d7 34952012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3496
3497 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3498
a8e7d6d7 34992012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3500
3501 * xdisp.c (pos_visible_p): If the window start position is beyond
3502 ZV, start the display from buffer beginning. Prevents assertion
3503 violation in init_iterator when the minibuffer window is scrolled
3504 via the scroll bar.
3505
3506 * window.c (window_scroll_pixel_based): Likewise.
3507
a8e7d6d7 35082012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3509
3510 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3511
a8e7d6d7 35122012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3513
3514 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3515 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3516
a8e7d6d7 35172012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3518
b593d6a9
AH
3519 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3520 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3521
1c6900d9
EZ
35222012-04-26 Eli Zaretskii <eliz@gnu.org>
3523
4c3fa1d9
EZ
3524 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3525 display element, check also the underlying string or buffer
3526 character. (Bug#11341)
3527
1c6900d9
EZ
3528 * w32menu.c: Include w32heap.h.
3529 (add_menu_item): If the call to AppendMenuW (via
3530 unicode_append_menu) fails, disable Unicode menus only if we are
3531 running on Windows 9X/Me.
3532
42bf8205
AS
35332012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3534
3535 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3536 (xgetint): Add missing shift for LSB tags.
3537
b1bac16e
MR
35382012-04-24 Martin Rudalics <rudalics@gmx.at>
3539
3540 * keyboard.c (read_char): Don't wipe echo area for select window
3541 events: These might get delayed via `mouse-autoselect-window'
3542 (Bug#11304).
3543
d69621cc
JB
35442012-04-24 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3547 manipulation of :loaded-from data.
3548
02fd101b
JB
35492012-04-23 Juanma Barranquero <lekktu@gmail.com>
3550
3551 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3552 now a cons (bug#11311).
3553
888bec30
PE
35542012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3555
89a438bd
PE
3556 Do not create empty overlays with the evaporate property (Bug#9642).
3557 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3558 if it becomes empty after its bounds are adjusted to fit within
3559 its buffer. Without this fix, in a nonempty buffer (let ((o
3560 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3561 yields an empty overlay that has the evaporate property, which is
3562 not supposed to happen.
3563
1068fe4d
PE
3564 Fix minor GTK3 problems found by static checking.
3565 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3566 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3567 (struct _EmacsFixedClass, emacs_fixed_get_type):
3568 Move decls here from emacsgtkfixed.h, since they needn't be public.
3569 (emacs_fixed_get_type): Now static.
3570 (emacs_fixed_class_init): Omit unused local.
3571 (emacs_fixed_child_type): Remove; unused.
3572 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3573 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3574 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3575 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3576 (EMACS_FIXED_GET_CLASS): Remove; unused.
3577 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3578
888bec30
PE
3579 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3580 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3581
de85e130
PE
35822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3583
d0baac98 3584 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3585 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3586 (__malloc_size_t, __malloc_ptrdiff_t):
3587 Remove. All uses removed, replaced by the definiens if needed,
3588 since we can assume C89 or better now.
3589 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3590 (protect_malloc_state, align, get_contiguous_space)
3591 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3592 (malloc_atfork_handler_child, malloc_enable_thread)
3593 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3594 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3595 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3596 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3597 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3598 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3599 Define using prototypes, not old style.
3600 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3601 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3602 (align): Don't assume that signed integer overflow wraps around.
3603 Omit unused local var.
3604 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3605 (_free_internal_nolock, memalign, mallochook, reallochook):
3606 Omit no-longer-needed casts.
3607 (valloc): Use getpagesize, not __getpagesize.
3608 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3609 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3610
de85e130
PE
3611 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3612
dcbf5805
MA
36132012-04-22 Michael Albinus <michael.albinus@gmx.de>
3614
3615 Move functions from C to Lisp. Make non-blocking method calls
3616 the default. Implement further D-Bus standard interfaces.
3617
3618 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3619 (QCdbus_request_name_allow_replacement)
3620 (QCdbus_request_name_replace_existing)
3621 (QCdbus_request_name_do_not_queue)
3622 (QCdbus_request_name_reply_primary_owner)
3623 (QCdbus_request_name_reply_in_queue)
3624 (QCdbus_request_name_reply_exists)
3625 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3626 (QCdbus_registered_serial, QCdbus_registered_method)
3627 (QCdbus_registered_signal): New Lisp objects.
3628 (XD_DEBUG_MESSAGE): Use sizeof.
3629 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3630 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3631 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3632 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3633 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3634 (xd_signature, xd_append_arg): Allow float for integer types.
3635 (xd_get_connection_references): New function.
b593d6a9
AH
3636 (xd_get_connection_address): Rename from xd_initialize.
3637 Return cached address.
dcbf5805
MA
3638 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3639 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3640 level.
3641 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3642 Return number of refcounts.
dcbf5805
MA
3643 (Fdbus_get_unique_name): Make stronger parameter check.
3644 (Fdbus_message_internal): New defun.
3645 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3646 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3647 (Fdbus_send_signal, Fdbus_register_service)
3648 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3649 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3650 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3651 (Vdbus_compiled_version, Vdbus_runtime_version)
3652 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3653 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3654 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3655 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3656 Adapt docstring.
dcbf5805 3657
52828e02
PE
36582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3659
da05bc4c
PE
3660 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3661 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3662 Do not assume ptrdiff_t is the same width as 'int'.
3663
52828e02
PE
3664 * alloc.c: Handle unusual debugging option combinations.
3665 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3666 since the two debugging options are incompatible.
3667 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3668 is defined.
3669 (mem_init, mem_insert, mem_insert_fixup):
3670 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3671 (NEED_MEM_INSERT): Remove; no longer needed.
3672
f01769f9
LL
36732012-04-22 Leo Liu <sdl.web@gmail.com>
3674
3675 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3676
5790543d
PE
36772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 * sysdep.c [__FreeBSD__]: Minor cleanups.
3680 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3681 Use Emacs indenting style more consistently. Avoid some casts.
3682 Use 'double' consistently rather than mixing 'float' and 'double'.
3683
b91b7e4d
EW
36842012-04-21 Eduard Wiebe <usenet@pusto.de>
3685
b593d6a9
AH
3686 * sysdep.c (list_system_processes, system_process_attributes):
3687 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3688
6114eb15
AS
36892012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3690
3691 * lisp.mk (lisp): Update.
3692
2f38dff7
PE
36932012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3696 It is never used otherwise.
3697
4ae29f89
SM
36982012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3699
3700 * print.c (print_preprocess): Only check print_depth if print-circle
3701 is nil.
3702 (print_object): Check for cycles even when print-circle is nil and
3703 print-gensym is t, but only check print_depth if print-circle is nil.
3704
f30d612a
CY
37052012-04-20 Chong Yidong <cyd@gnu.org>
3706
3707 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3708 set the status to "failed" and ensure that sentinel is run.
3709
c07a4c0b 37102012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3711
3712 * process.c (Fset_process_inherit_coding_system_flag)
3713 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3714 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3715
c07a4c0b 37162012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3717
3718 * xdisp.c (string_buffer_position_lim): Limit starting position to
3719 BEGV.
3720 (set_cursor_from_row): If called for a mode-line or header-line
3721 row, return zero immediately.
3722 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3723 farther than the first row after the header line, if any.
3724 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3725 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3726
c07a4c0b 37272012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3728
4ae29f89
SM
3729 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3730 (bug#11238).
ad3a2b41 3731
c07a4c0b 37322012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 37332012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3734
3735 configure: new option --enable-gcc-warnings (Bug#11207)
3736 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3737 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3738 (ALL_CFLAGS): Use new macros rather than old.
3739 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3740 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3741 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3742 -Wunused-result, -Wunused-variable. This should go away once
3743 the Emacs and Gnulib regex code is merged.
3744 (xmalloc, xrealloc): Now static.
3745
aba027e8
PE
37462012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 * dired.c (Fsystem_groups): Remove unused local.
3749
e5a36063
GM
37502012-04-17 Glenn Morris <rgm@gnu.org>
3751
3752 * dired.c (Fsystem_users): Doc fix.
3753
316411f0
DA
37542012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3755
3756 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3757 (syms_of_dired): Add them.
3758
9426aba4
PE
37592012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3760
b62a57be
PE
3761 Fix minor alloc.c problems found by static checking.
3762 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3763 New extern decls, to avoid calling undeclared functions.
3764 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3765 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3766 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3767 (NEED_MEM_INSERT): New macro.
3768 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3769 Remove one incorrect comment and fix another.
b62a57be 3770
3539f31f
PE
3771 Fix minor ralloc.c problems found by static checking.
3772 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3773 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3774 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3775 (r_alloc_sbrk): Now static.
3776
a041960a
PE
3777 Improve ralloc.c interface checking.
3778 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3779 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3780 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3781 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3782 [REL_ALLOC]: ... to here, to check interface.
3783 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3784 Remove decls. This fixes an "It stinks!".
3785
9426aba4
PE
3786 * alloc.c (which_symbols): Fix alignment issue / type clash.
3787
d55c12ed
AS
37882012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3789
3790 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3791 (struct Lisp_Misc_Any): Likewise.
3792 (struct Lisp_Free): Likewise.
3793 * alloc.c (union aligned_Lisp_Symbol): Define.
3794 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3795 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3796 (union aligned_Lisp_Misc): Define.
3797 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3798 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3799 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3800
b948ce8b
PE
38012012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3802
3803 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3804 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3805 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3806 * s/netbsd.h, s/sol2-6.h:
3807 Remove definition of GC_MARK_STACK, since the default now works.
3808 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3809 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3810 no longer the default.
3811 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3812
35dc09a1 38132012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3814
35dc09a1
GM
3815 * lread.c (lisp_file_lexically_bound_p):
3816 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3817
35dc09a1
GM
38182012-04-14 Eli Zaretskii <eliz@gnu.org>
3819
3820 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3821 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3822
38232012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3824
3825 * nsterm.m (constrainFrameRect): Always constrain when there is only
3826 one screen (Bug#10962).
3827
bcd86815
KB
38282012-04-13 Ken Brown <kbrown@cornell.edu>
3829
3830 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3831
c25df26e
RT
38322012-04-13 Reuben Thomas <rrt@sc3d.org>
3833
3834 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3835
0fc59f1e
DC
38362012-04-11 Daniel Colascione <dancol@dancol.org>
3837
3838 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3839 against is gone. It's better to use vfork now so that when Cygwin
3840 gains a new, working vfork, we use it automatically (bug#10398).
3841
de8c03dc
SM
38422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3843
3844 * window.c (save_window_save): Obey window-point-insertion-type.
3845
2f097256
GM
38462012-04-11 Glenn Morris <rgm@gnu.org>
3847
3848 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3849
453b951e
SM
38502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3851
3852 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3853
75f1671a 38542012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3855
3856 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3857 (force_quit_count): New var.
3858 (handle_interrupt): Use it.
3859
2a8ce227
JB
38602012-04-10 Juanma Barranquero <lekktu@gmail.com>
3861
3862 * w32.c (w32_delayed_load): Record the full path of the library
3863 being loaded (bug#10424).
3864
935396c0
GM
38652012-04-09 Glenn Morris <rgm@gnu.org>
3866
05920a43
GM
3867 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3868 not just in the obarray, before snarfing them. (Bug#11036)
3869
935396c0
GM
3870 * Makefile.in ($(leimdir)/leim-list.el):
3871 Pass EMACS rather than BUILT_EMACS.
3872
a18ecafa
TZ
38732012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3874
3875 * process.c (make_process):
3876 * process.h: Add integer `gnutls_handshakes_tried' member to
3877 process struct.
3878
6bbef4e5
JC
3879 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3880 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3881
3882 * gnutls.c (gnutls_log_function2i): Convenience log function.
3883 (emacs_gnutls_read): Use new log functions,
3884 `gnutls_handshakes_tried' process member, and
3885 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3886 attempts per process (connection).
3887
b4d3bc10
CY
38882012-04-09 Chong Yidong <cyd@gnu.org>
3889
3890 * eval.c (Fuser_variable_p, user_variable_p_eh)
3891 (lisp_indirect_variable): Functions deleted.
3892 (Fdefvar): Caller changed.
3893
3894 * callint.c (Finteractive, Fcall_interactively):
3895 * minibuf.c (Fread_variable): Callers changed.
3896
70f4d973
EZ
38972012-04-09 Eli Zaretskii <eliz@gnu.org>
3898
3899 * xdisp.c (set_cursor_from_row): If the display string appears in
3900 the buffer at position that is closer to point than the position
3901 after the display string, display the cursor on the first glyph of
3902 the display string. Fixes cursor display when a 'display' text
3903 property immediately follows invisible text. (Bug#11094)
3904
cb3c2e3e
PE
39052012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3906
3907 composite.c: use 'double' consistently
3908 * composite.c (get_composition_id): Use 'double' consistently
3909 instead of converting 'float' to 'double' and vice versa; this is
3910 easier to understand and avoids a GCC warning.
3911
fd06db5d
GM
39122012-04-09 Glenn Morris <rgm@gnu.org>
3913
50fe702a
GM
3914 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3915 preparation for dumping it with emacs. (Bug#4789)
3916 (leimdir): New variable.
3917 ($(leimdir)/leim-list.el): New rule.
3918 (emacs$(EXEEXT)): Depend on leim-list.el.
3919
fd06db5d
GM
3920 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3921 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3922 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3923
55c131ee
AS
39242012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3925
3926 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3927 proper alignment.
3928
9209588f
JB
39292012-04-07 Juanma Barranquero <lekktu@gmail.com>
3930
3931 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3932 Remove unused local variable.
3933
e3fb2efb
PE
39342012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3935
3936 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3937 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3938 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3939 objects, as mark_maybe_pointer will catch them otherwise.
3940 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3941 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3942
b5385551
PE
39432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 Fix typo that broke non-Windows builds.
3946 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3947
9078ead6
EZ
39482012-04-07 Eli Zaretskii <eliz@gnu.org>
3949
3950 Support building on MS-Windows with libxml2.
3951
3952 * makefile.w32-in (OBJ2): Add xml.$(O).
3953 (GLOBAL_SOURCES): Add xml.c.
3954 ($(BLD)/xml.$(O)): New dependency list.
3955
3956 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3957 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3958 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3959 [!WINDOWSNT]: New macros.
3960 (init_libxml2_functions, libxml2_loaded_p): New functions.
3961 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3962 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3963 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3964 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3965 linked in).
6bbef4e5
JC
3966 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3967 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3968 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3969
3970 * emacs.c: Don't include libxml/parser.h.
3971 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3972 xmlCleanupParser directly.
3973
3974 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3975
3811fdf3
EZ
39762012-04-07 Eli Zaretskii <eliz@gnu.org>
3977
3978 * indent.c (Fvertical_motion): If there is a display string at
3979 point, use it.vpos to compute how many lines to backtrack after
3980 move_it_to point. (Bug#11133)
3981
2f8e16b2
EZ
39822012-04-06 Eli Zaretskii <eliz@gnu.org>
3983
3984 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3985 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3986 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3987 macros related to unification of CJK characters. For the details,
3988 see the discussion following the message here:
3989 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3990
3d439cd1
CY
39912012-04-04 Chong Yidong <cyd@gnu.org>
3992
3993 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3994
8bc53d00
EZ
39952012-04-01 Eli Zaretskii <eliz@gnu.org>
3996
3997 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3998 instead of alloca. (Bug#11138)
3999
3b0512a3
AS
40002012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4001
4002 * w32menu.c (is_simple_dialog): Properly check lisp types.
4003 (Bug#11141)
4004
8427ddd2
EZ
40052012-03-31 Eli Zaretskii <eliz@gnu.org>
4006
979022ef
EZ
4007 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4008 position we get to after a call to move_it_to fails the
4009 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4010 only if we wind up in a string from display property. (Bug#11063)
4011
a6b1c7cc
EZ
4012 * window.c (Fdelete_other_windows_internal): Invalidate the row
4013 and column information about mouse highlight, so that redisplay
4014 restores it after reallocating the glyph matrices. (Bug#7464)
4015
8427ddd2
EZ
4016 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4017 string comes from a `display' text property, use the buffer
4018 position of that property as if we actually saw that position in
4019 the row's glyphs.
697ba24b
EZ
4020 (move_it_by_lines): Remove the assertion that
4021 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4022 violated when there's a before-string at the beginning of a line.
4023 (Bug#11063)
8427ddd2 4024
65a0a738
EZ
40252012-03-30 Eli Zaretskii <eliz@gnu.org>
4026
4027 * xdisp.c (append_space_for_newline): If the default face was
4028 remapped, use the remapped face for the appended newline.
4029 (extend_face_to_end_of_line): Use the remapped default face for
4030 extending the face to the end of the line.
4031 (display_line): Call extend_face_to_end_of_line when the default
4032 face was remapped. (Bug#11068)
4033
581355cc
EZ
40342012-03-29 Eli Zaretskii <eliz@gnu.org>
4035
4036 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4037
e8fc049f
SM
40382012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4039
4040 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4041
4fb9a543
GM
40422012-03-27 Glenn Morris <rgm@gnu.org>
4043
4044 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4045 Doc fixes.
4046
679910f1
KH
40472012-03-26 Kenichi Handa <handa@m17n.org>
4048
4049 * dispextern.h (struct glyph): Fix previous change. Change the
4050 bit length of glyphless.ch to 25 (Bug#11082).
4051
90d49b7f
CY
40522012-03-26 Chong Yidong <cyd@gnu.org>
4053
4054 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4055 (command_loop_1): Use it; inhibit selection update for
4056 handle-select-window too (Bug#8996).
4057
f514f6f0
FP
40582012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4059
e8fc049f 4060 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4061
bf43fa51
KH
40622012-03-25 Kenichi Handa <handa@m17n.org>
4063
4064 * dispextern.h (struct glyph): Change the bit length of
4065 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4066
8a0c01dd
EZ
40672012-03-24 Eli Zaretskii <eliz@gnu.org>
4068
4069 * s/ms-w32.h (tzname): Include time.h before redirecting to
4070 _tzname. Fixes the MSVC build. (Bug#9960)
4071
7d1c3a76
AS
40722012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4073
8ed79523
AS
4074 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4075 characters.
4076
7d1c3a76
AS
4077 * xterm.c (XTread_socket): Only modify handling_signal if
4078 !SYNC_INPUT. (Bug#11080)
4079
e99a9b8b
EZ
40802012-03-23 Eli Zaretskii <eliz@gnu.org>
4081
4082 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4083 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4084 when fetching a multibyte character consumes more bytes than
4085 CHAR_BYTES returns, due to unification of CJK characters in
4086 string_char. (Bug#11073)
4087
5063c0e1
TN
40882012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4089
4090 * process.c (wait_reading_process_output): Handle pty disconnect
4091 by refraining from sending oneself a SIGCHLD (bug#10933).
4092
9f851fbd
CY
40932012-03-22 Chong Yidong <cyd@gnu.org>
4094
4095 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4096
5063c0e1 4097 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4098 Mark string as coming from a prefix property.
4099 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4100 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4101
fb5b8aca
CY
41022012-03-21 Chong Yidong <cyd@gnu.org>
4103
4104 * xfaces.c (Vface_remapping_alist): Doc fix.
4105
62356a1b
EZ
41062012-03-20 Eli Zaretskii <eliz@gnu.org>
4107
4108 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4109 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4110 Doc fixes.
62356a1b 4111
025de85b
CY
41122012-03-20 Chong Yidong <cyd@gnu.org>
4113
4114 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4115 to reflect default non-nil value of redisplay-dont-pause.
4116
4827f94e
KH
41172012-03-19 Kenichi Handa <handa@m17n.org>
4118
4119 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4120 it fit in a valid range (Bug#11003).
4121
e50a24a2
EZ
41222012-03-18 Eli Zaretskii <eliz@gnu.org>
4123
4124 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4125 that is not from display property, accept the row as a "cursor
4126 row" if one of the string's character has a non-nil `cursor'
4127 property. Fixes cursor positioning when there are newlines in
4128 overlay strings, e.g. in icomplete.el. (Bug#11035)
4129
9af5ed87
PE
41302012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4131
4132 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4133
d1f55f16
CY
41342012-03-12 Chong Yidong <cyd@gnu.org>
4135
4136 * eval.c (inhibit_lisp_code): Rename from
4137 inhibit_window_configuration_change_hook; move from window.c.
4138
4139 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4140 * window.c (run_window_configuration_change_hook)
4141 (syms_of_window): Callers changed.
4142
66c5eebd
CY
41432012-03-11 Chong Yidong <cyd@gnu.org>
4144
413df973
CY
4145 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4146
66c5eebd
CY
4147 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4148
1de11f56
CY
41492012-03-10 Chong Yidong <cyd@gnu.org>
4150
4151 * frame.c (other_visible_frames): Don't assume the selected frame
4152 is visible (Bug#10955).
4153
cae07000
SM
41542012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4155
4156 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4157
89c94350
JD
41582012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4159
4160 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4161 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4162 zero (Bug#10954).
4163
999dd333
GM
41642012-03-03 Glenn Morris <rgm@gnu.org>
4165
01a6dcc8 4166 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4167
de0100f2
EZ
41682012-03-02 Eli Zaretskii <eliz@gnu.org>
4169
4170 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4171 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4172 (redisplay_window, next_element_from_string): Fix typos in
4173 comments.
3e441275
EZ
4174 (redisplay_window): Pass to move_it_vertically the margin in
4175 pixels, not in screen lines.
de0100f2 4176
96a72ee9
GM
41772012-03-02 Glenn Morris <rgm@gnu.org>
4178
4179 * buffer.c (buffer-list-update-hook): Doc fix.
4180
312508d7
EZ
41812012-02-29 Eli Zaretskii <eliz@gnu.org>
4182
4183 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4184 push_it before setting up the iterator for the first overlay
4185 string, even if we have an empty string loaded.
4186 (next_overlay_string): If there's an empty string on the iterator
4187 stack, pop the stack. (Bug#10903)
4188
27f3c637
PE
41892012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4192 Suggested by Stefan Monnier in
4193 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4194 * alloc.c (widen_to_Lisp_Object): New static function.
4195 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4196 and widening them to Lisp_Objects. This would work even if
4197 USE_LSB_TAG is defined and wide integers are used, which might
4198 happen in a future version of Emacs.
4199
3c9dfce6
CY
42002012-02-25 Chong Yidong <cyd@gnu.org>
4201
fa74b241
CY
4202 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4203 Doc fix.
4204
3c9dfce6
CY
4205 * xselect.c (Fx_selection_exists_p): Doc fix.
4206 (x_clipboard_manager_save_all): Print an informative message
4207 before saving to clipboard manager.
4208
9486df08
CY
42092012-02-24 Chong Yidong <cyd@gnu.org>
4210
4211 * keyboard.c (process_special_events): Handle all X selection
4212 requests in kbd_buffer, not just the next one (Bug#8869).
4213
f01d3321
CY
42142012-02-23 Chong Yidong <cyd@gnu.org>
4215
4216 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4217 call when setting menu-bar-lines and tool-bar-lines parameters.
4218 (unwind_create_frame_1): New helper function.
4219
4220 * window.c (inhibit_window_configuration_change_hook): New var.
4221 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4222 (syms_of_window): Initialize it.
f01d3321 4223
86b847b6
CY
42242012-02-22 Chong Yidong <cyd@gnu.org>
4225
4226 * xterm.c (x_draw_image_relief): Add missing type check for
4227 Vtool_bar_button_margin (Bug#10743).
4228
a59225b1
CY
42292012-02-21 Chong Yidong <cyd@gnu.org>
4230
4231 * fileio.c (Vfile_name_handler_alist): Doc fix.
4232
4233 * buffer.c (Fget_file_buffer): Protect against invalid file
4234 handler return value.
4235
310f5bd4
PE
42362012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4237
cb3a28cc
PE
4238 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4239 when computing $valmask.
4240
310f5bd4
PE
4241 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4242 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4243 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4244 It's useless in that case, and it can cause problems on hosts
4245 that allocate halves of EMACS_INT values separately.
4246 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4247 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4248 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4249 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4250 it avoids undefined behavior on hosts where shifting right by more
4251 than the word width has undefined behavior.
4252
2375c96a
CY
42532012-02-19 Chong Yidong <cyd@gnu.org>
4254
4255 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4256 (Funhandled_file_name_directory, Ffile_name_as_directory)
4257 (Fdirectory_file_name, Fexpand_file_name)
4258 (Fsubstitute_in_file_name): Protect against invalid file handler
4259 return values (Bug#10845).
4260
3eb49e71
EZ
42612012-02-18 Eli Zaretskii <eliz@gnu.org>
4262
4263 * .gdbinit (pitx): Fix incorrect references to fields of the
4264 iterator stack.
4265
7b926f3f
CY
42662012-02-17 Chong Yidong <cyd@gnu.org>
4267
4268 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4269
11273115
PE
42702012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4273 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4274
c3a70e2b
CY
42752012-02-15 Chong Yidong <cyd@gnu.org>
4276
4277 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4278 marked as special. Also, starting docstrings with * is obsolete.
4279
0ca43699
AS
42802012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4281
4282 * gnutls.c (emacs_gnutls_write): Fix last change.
4283
2e8f3c56
LI
42842012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4285
4286 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4287 send_process.
4288
af70074f
SM
42892012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 * keymap.c (Fsingle_key_description): Handle char ranges.
4292
95986d52
CY
42932012-02-12 Chong Yidong <cyd@gnu.org>
4294
afd83bd1
CY
4295 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4296 as that creates a dangerous corner case.
4297
95986d52
CY
4298 * window.c (Fdelete_window_internal): Invalidate the mouse
4299 highlight (Bug#9904).
4300
bd7da63e
GM
43012012-02-12 Glenn Morris <rgm@gnu.org>
4302
4303 * xselect.c (Fx_own_selection_internal)
4304 (Fx_get_selection_internal, Fx_disown_selection_internal)
4305 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4306 * nsselect.m (Fx_own_selection_internal)
4307 (Fx_disown_selection_internal, Fx_selection_exists_p)
4308 (Fx_selection_owner_p, Fx_get_selection_internal):
4309 Sync docs and argument specs with the xselect.c versions.
4310
77abcbc2
LI
43112012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4312
4313 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4314
90b671e2
EZ
43152012-02-11 Eli Zaretskii <eliz@gnu.org>
4316
1c0ca0b7
EZ
4317 * w32select.c (Fx_selection_exists_p): Sync doc string and
4318 argument list with xselect.c. (Bug#10783)
4319
4320 * w16select.c (Fx_selection_exists_p): Sync doc string and
4321 argument list with xselect.c. (Bug#10783)
90b671e2 4322
49241268
GM
43232012-02-10 Glenn Morris <rgm@gnu.org>
4324
4325 * fns.c (Fsecure_hash): Doc fix.
4326
f998bbe7 43272012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4328
4329 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4330
0992bd9c
CY
43312012-02-07 Chong Yidong <cyd@gnu.org>
4332
4333 * buffer.c (Fbuffer_local_variables)
4334 (buffer_lisp_local_variables): Handle unbound vars correctly;
4335 don't let Qunbound leak into Lisp.
4336
af008560
GM
43372012-02-07 Glenn Morris <rgm@gnu.org>
4338
dd605cc4
GM
4339 * image.c (Fimagemagick_types): Doc fix.
4340
af008560
GM
4341 * image.c (imagemagick-render-type): Change it from a lisp object
4342 to an integer. Move the doc here from the lisp manual.
4343 Treat all values not equal to 0 the same.
4344
1449fa1d
CY
43452012-02-06 Chong Yidong <cyd@gnu.org>
4346
4347 * doc.c (store_function_docstring): Avoid applying docstring of
4348 alias to base function (Bug#2603).
4349
3723ec07
AS
43502012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4351
4352 * .gdbinit (pp1, pv1): Remove redundant defines.
4353 (pr): Use pp.
4354
79c1cc1e
CY
43552012-02-04 Chong Yidong <cyd@gnu.org>
4356
4357 * nsterm.m: Declare a global (Bug#10694).
4358
d7f29f8e
EZ
43592012-02-04 Eli Zaretskii <eliz@gnu.org>
4360
cae07000
SM
4361 * w32.c (get_emacs_configuration_options):
4362 Include --enable-checking, if specified, in the return value.
d7f29f8e 4363
3b95a6f9
MR
43642012-02-04 Martin Rudalics <rudalics@gmx.at>
4365
4366 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4367 after rounding frame sizes. (Bug#9723)
4368
d6fa96a6
EZ
43692012-02-04 Eli Zaretskii <eliz@gnu.org>
4370
4371 * keyboard.c (adjust_point_for_property): Don't position point
4372 before BEGV. (Bug#10696)
4373
df0b2940
PE
43742012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 Handle overflow when computing char display width (Bug#9496).
4377 * character.c (char_width): Return EMACS_INT, not int.
4378 (char_width, c_string_width): Check for overflow when
4379 computing the width; this is possible now that individual
4380 characters can have unbounded width. Problem introduced
4381 by merge from Emacs 23 on 2012-01-19.
4382
6bee44d6
MA
43832012-02-02 Michael Albinus <michael.albinus@gmx.de>
4384
4385 * dbusbind.c (Fdbus_register_method): Mention the return value
4386 :ignore in the docstring.
4387
44f92739
GM
43882012-02-02 Glenn Morris <rgm@gnu.org>
4389
1b9f60cc
GM
4390 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4391
44f92739
GM
4392 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4393 Unconditionally set to t. (Bug#10673)
4394 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4395 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4396 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4397
c5d3843c
KH
43982012-02-02 Kenichi Handa <handa@m17n.org>
4399
4400 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4401 0, do not call append_composite_glyph.
4402
159462d4 44032012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4404
4405 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4406 NULL (Bug#6988).
4407 (x_produce_glyphs): If the component of a composition is a null
4408 string, set it->pixel_width to 1 to avoid zero-width glyph.
4409
78cef877
EZ
44102012-02-01 Eli Zaretskii <eliz@gnu.org>
4411
4412 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4413 first 2 arguments are identical. This makes inserting large
4414 output from a subprocess an order of magnitude faster on
4415 MS-Windows, where all sbrk'ed memory is always contiguous.
4416
97897668
GM
44172012-01-31 Glenn Morris <rgm@gnu.org>
4418
4419 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4420 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4421 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4422
31fd3586
GM
44232012-01-29 Glenn Morris <rgm@gnu.org>
4424
4425 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4426
0e24a8b2
CY
44272012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4428
4429 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4430
cc0adcb0
CY
44312012-01-28 Chong Yidong <cyd@gnu.org>
4432
4433 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4434
acc28cb9
CY
44352012-01-26 Chong Yidong <cyd@gnu.org>
4436
9c69cfb7
CY
4437 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4438
acc28cb9
CY
4439 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4440 repeat counts (Bug#10507).
4441
48da7392
GM
44422012-01-26 Glenn Morris <rgm@gnu.org>
4443
4444 * lread.c (syms_of_lread): Doc fix.
4445
14af5f7f
CY
44462012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4447
4448 * coding.c (encode_designation_at_bol): Change return value to
4449 EMACS_INT.
4450
0b21c100
CY
44512012-01-25 Chong Yidong <cyd@gnu.org>
4452
4453 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4454
3c2907f7
CY
44552012-01-21 Chong Yidong <cyd@gnu.org>
4456
4457 * floatfns.c (Fcopysign): Make the second argument non-optional,
4458 since nil is not allowed anyway.
4459
959ad23f
AS
44602012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4461
4462 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4463 (send_process): Likewise.
4464
34a02f46
MR
44652012-01-19 Martin Rudalics <rudalics@gmx.at>
4466
4467 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4468 (Vwindow_persistent_parameters): Do not use Qstate.
4469 Rewrite doc-strings.
34a02f46 4470
1259009a 44712012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4472
4473 * character.c (char_width): New function.
70d4fdf6
GM
4474 (Fchar_width, c_string_width, lisp_string_width):
4475 Use char_width (Bug#9496).
25ed9e61 4476
6a6ee00d
MR
44772012-01-16 Martin Rudalics <rudalics@gmx.at>
4478
4479 * window.c (Vwindow_persistent_parameters): New variable.
4480 (Fset_window_configuration, save_window_save): Handle persistent
4481 window parameters.
4482
c85efaf7
EZ
44832012-01-14 Eli Zaretskii <eliz@gnu.org>
4484
4485 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4486 thrashing the stack of the thread. (Bug#9087)
4487
5944709e
PE
44882012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4489
4490 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4491
e71f5d99
EZ
44922012-01-11 Eli Zaretskii <eliz@gnu.org>
4493
4494 * xdisp.c (rows_from_pos_range): Handle the case where the
4495 highlight ends on a newline. (Bug#10464)
4496 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4497 he end column for display of highlight that ends on a newline
4498 before a R2L line.
4499
ce316182
GM
45002012-01-11 Glenn Morris <rgm@gnu.org>
4501
4502 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4503 from load-path also when installation-directory is nil. (Bug#10208)
4504
5b43da69
GM
45052012-01-10 Glenn Morris <rgm@gnu.org>
4506
74cc8ff9
GM
4507 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4508
7d8d6e4e
GM
4509 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4510 Update template values to be closer to their typical values these days.
5b43da69 4511
a0db8d43
EZ
45122012-01-09 Eli Zaretskii <eliz@gnu.org>
4513
4514 * xdisp.c (rows_from_pos_range): Accept additional argument
4515 DISP_STRING, and accept any glyph in a row whose object is that
4516 string as eligible for mouse highlight. Fixes mouse highlight of
4517 display strings from overlays. (Bug#10464)
4518
9a0115ab 45192012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4520
b9110d6a 4521 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4522 * fileio.c (auto_saving_dir_umask): New static var.
4523 (Fmake_directory_internal): Use it.
4524 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4525 creating the directory. The old code temporarily assigns
4526 too-generous permissions to the directory.
4527 (do_auto_save_eh): Clear it.
b9110d6a 4528 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4529 that the var is always cleared.
4530
6c1bd3f3
EZ
45312012-01-07 Eli Zaretskii <eliz@gnu.org>
4532
4533 * search.c (scan_buffer): Pass character positions to
4534 know_region_cache, not byte positions. (Bug#6540)
4535
069d2b50
L
45362012-01-07 LynX <_LynX@bk.ru> (tiny change)
4537
4538 * w32.c (sys_rename): Report EXDEV when rename of a directory
4539 fails because the target is on another logical disk. (Bug#10284)
4540
75bf0d33
DB
45412012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4542
4543 * xterm.c (x_embed_request_focus): New function.
4544
4545 * xterm.h: Add prototype.
4546
4547 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4548
1c6e5a32
GM
45492012-01-05 Glenn Morris <rgm@gnu.org>
4550
4551 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4552
651e947e
EZ
45532012-01-01 Eli Zaretskii <eliz@gnu.org>
4554
4555 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4556 Load gnutls_transport_set_lowat only if GnuTLS version is below
4557 2.11.1.
4558 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4559 GnuTLS versions below 2.11.1.
4560
3778cdd8
AL
45612011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4562
4563 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4564 to the doc string advising against its use for altering the way
4565 windows are scrolled.
4566
0e5317f7
KH
45672011-12-28 Kenichi Handa <handa@m17n.org>
4568
4569 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4570 coding-system ASCII compatible only when it does not produce BOM
4571 on encoding (Bug#10383).
4572
93d5ca1f
JD
45732011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4574
4575 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4576 can scroll.
4577 (create_and_show_popup_menu): Always use menu_position_func for
4578 Gtk3 (Bug#10361).
4579
ca22b785
AS
45802011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4581
4582 * callint.c (Fcall_interactively): Don't truncate prompt string.
4583
d048e1e6
EZ
45842011-12-23 Eli Zaretskii <eliz@gnu.org>
4585
4586 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4587 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4588 resumed from there (after widening). (Bug#10360)
d048e1e6 4589
5ccaba1f
JD
45902011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4591
4592 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4593
204ee57f
JD
45942011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4595
b81d40f0
JB
4596 * nsterm.m (x_free_frame_resources):
4597 Release f->output_data.ns->miniimage.
204ee57f
JD
4598 (ns_index_color): Fix indentation. Do not retain
4599 color_table->colors[i].
4600
4601 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4602 before returning.
4603
4604 * nsfns.m (x_set_background_color): Assign return value from
4605 ns_index_color to face-background instead of NSColor*.
4606 (ns_implicitly_set_icon_type): Fix indentation.
4607 Change assignment in for loop to comparison.
4608
4609 * emacs.c (ns_pool): New variable.
4610 (main): Assign ns_pool.
4611 (Fkill_emacs): Call ns_release_autorelease_pool.
4612
4613 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4614 autorelease fdesc, release fdAttrs and tdict.
4615 (ns_get_covering_families): Release charset.
4616 (ns_findfonts): Release NSFontDescriptor created with new.
4617 (ns_uni_to_glyphs): Fix indentation.
4618 (setString): Release attrStr before assigning new value.
4619
c803b2b7
JD
46202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4621
678f4426
JD
4622 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4623 and NS_IMPL_COCOA.
4624 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4625 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4626
cd394be1 46272011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4628
5fecd5fc
JD
4629 * nsterm.m (ns_term_init): Subscribe for notifications
4630 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4631 to method trackingNotification in EmacsMenu.
4632
4633 * nsmenu.m (trackingMenu): New variable.
3771cb17 4634 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4635 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4636 from Aquamacs (Bug#7030).
678f4426
JD
4637
46382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4639
c803b2b7
JD
4640 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4641 (symbol_to_nsstring): Fix indentation.
4642 (ns_symbol_to_pb): New function.
cae07000
SM
4643 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4644 (Fns_rotate_cut_buffers_internal): Remove.
4645 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4646 Fns_store_cut_buffer_internal.
4647 (ns_get_foreign_selection, Fx_own_selection_internal)
4648 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4649 (Fns_get_selection_internal, Fns_store_selection_internal):
4650 Use ns_symbol_to_pb and check if return value is nil.
4651 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4652 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4653 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4654 renamed to Sns_store_selection_internal.
4655 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4656 and remove this function.
4657 (ns_handle_selection_clear): Remove, never used.
4658 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4659 here.
4660
e1b01a3a
KB
46612011-12-17 Ken Brown <kbrown@cornell.edu>
4662
4663 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4664 GID is unknown (Bug#10257).
4665
2adb6e85
PE
46662011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4667
4668 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4669 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4670 which caused a build failure on GNU/Linux IA-64. This problem was
4671 introduced by my 2011-10-07 patch.
4672
d1d7b339
JL
46732011-12-15 Juri Linkov <juri@jurta.org>
4674
4675 * image.c (imagemagick_error): New function. (Bug#10112)
4676 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4677 Use `imagemagick_error' where ImageMagick functions return
4678 `MagickFalse'.
4679 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4680 proper order.
4681
100d5755
KH
46822011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4683
4684 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4685 fill background (Bug#8992).
4686
454592a6
MR
46872011-12-13 Martin Rudalics <rudalics@gmx.at>
4688
4689 * window.c (Vwindow_combination_resize)
4690 (Vwindow_combination_limit): Use t instead of non-nil in
4691 doc-strings.
61d4b438
MR
4692 (Vrecenter_redisplay): Add first sentence of doc-string on
4693 separate line.
53524d93 4694 (Frecenter): Fix doc-string typo.
454592a6 4695
3633e3aa
KH
46962011-12-11 Kenichi Handa <handa@m17n.org>
4697
4698 * coding.c (Funencodable_char_position): Pay attention to the
4699 buffer text relocation (Bug#9389).
4700
7b9d523a 47012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4702
7b9d523a
JD
4703 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4704 gtk_init (Bug#10100).
4705
b73189c6
EZ
47062011-12-10 Eli Zaretskii <eliz@gnu.org>
4707
4708 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4709 IT->string is nil. (Bug#10263)
4710
f7dfe5d6
JD
47112011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4712
83faebb4
JD
4713 * nsterm.h (x_free_frame_resources): Declare.
4714
f7dfe5d6
JD
4715 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4716 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4717
4718 * nsterm.h (ns_get_defaults_value): Declare.
4719
4720 * nsterm.m (ns_default): Call ns_get_defaults_value.
4721
7cd4e72c
EZ
47222011-12-09 Eli Zaretskii <eliz@gnu.org>
4723
4724 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4725 (Bug#10170)
4726
b34d7317
YM
47272011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4728
4729 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4730 that where the value of an _OBJC_* symbol points to is in the .bss
4731 section (Bug#10240).
4732
76470ad1
KH
47332011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4734
4735 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4736 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4737
745fff94
KH
47382011-12-08 Kenichi Handa <handa@m17n.org>
4739
4740 * ftfont.c (get_adstyle_property): Fix previous change
4741 (Bug#10233).
4742
6e44397c
JB
47432011-12-07 Juanma Barranquero <lekktu@gmail.com>
4744
4745 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4746 dirs from the default value of EMACSLOADPATH (bug#10208).
4747
7efa6272
GM
47482011-12-07 Glenn Morris <rgm@gnu.org>
4749
4750 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4751 installation and source directories as well. (Bug#10208)
4752
f6fc4d87
CY
47532011-12-06 Chong Yidong <cyd@gnu.org>
4754
4755 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4756
2bf26180
GM
47572011-12-06 Glenn Morris <rgm@gnu.org>
4758
4759 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4760 as an error, not just -1. (Bug#10217)
4761
3a6ad4f0
CY
47622011-12-05 Chong Yidong <cyd@gnu.org>
4763
4764 * keyboard.c (process_special_events): New function.
4765 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4766
75a3b399
PE
47672011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4768
4769 * coding.c (encode_designation_at_bol): Don't use uninitialized
4770 local variable (Bug#9318).
4771
c3c9e25e
KH
47722011-12-05 Kenichi Handa <handa@m17n.org>
4773
4774 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4775 return Qnil (Bug#8046, Bug#10193).
4776
5eb05ea3
KH
47772011-12-05 Kenichi Handa <handa@m17n.org>
4778
4779 * coding.c (encode_designation_at_bol): New args charbuf_end and
4780 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4781 (coding_set_source): Return how many bytes coding->source was
4782 relocated.
4783 (coding_set_destination): Return how many bytes
4784 coding->destination was relocated.
4785 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4786 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4787
47882011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4789
4790 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4791 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4792 macro (Bug#9318).
4793
47942011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4795
4796 The following changes are to fix Bug#9318.
4797
a79703f5 4798 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4799 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4800 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4801 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4802
7dbda6df
JB
48032011-12-05 Juanma Barranquero <lekktu@gmail.com>
4804
4805 * lisp.h (process_quit_flag): Fix external declaration.
4806
6d5eb5b0
SM
48072011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4808
4809 Don't macro-inline non-performance-critical code.
4810 * eval.c (process_quit_flag): New function.
4811 * lisp.h (QUIT): Use it.
4812
a0c3fad0
JD
48132011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4814
4815 * nsfns.m (get_geometry_from_preferences): New function.
4816 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4817
6c07aac2
AS
48182011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4819
4820 * emacs.c (Qkill_emacs): Define.
4821 (syms_of_emacs): Initialize it.
4822 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4823 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4824 (quit_throw_to_read_char): Add parameter `from_signal'.
4825 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4826 * lisp.h (QUIT): Call Fkill_emacs if requested.
4827
c052ead4
JD
48282011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4829
4830 * widget.c (update_wm_hints): Return if wmshell is null.
4831 (widget_update_wm_size_hints): New function.
4832
4833 * widget.h (widget_update_wm_size_hints): Declare.
4834
4835 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4836 widget_update_wm_size_hints (Bug#10104).
4837
9e49252b
EZ
48382011-12-03 Eli Zaretskii <eliz@gnu.org>
4839
4840 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4841 before a newline, prepare the bidi iterator for consuming the
4842 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4843 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4844
02b16839
JL
48452011-12-02 Juri Linkov <juri@jurta.org>
4846
4847 * search.c (Fword_search_regexp): New Lisp function created from
4848 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4849 (Fword_search_backward, Fword_search_forward)
4850 (Fword_search_backward_lax, Fword_search_forward_lax):
4851 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4852 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4853
0068070e
SM
48542011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4855
4856 * fileio.c (Finsert_file_contents): Move after-change-function call
4857 to before the "handled:" label, since all "goto handled" appear in
4858 cases where the *-change-functions have already been properly called
4859 (bug#10117).
4860
3360a3fc
AS
48612011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4862
4863 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4864 waiting for input. (Bug#10169)
4865
73d6c093
EZ
48662011-11-30 Eli Zaretskii <eliz@gnu.org>
4867
4868 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4869 verifies glyph row's hash code--we have just reallocated the
4870 glyphs, so their contents can be complete garbage. (Bug#10164)
4871
febe6bea
JB
48722011-11-30 Juanma Barranquero <lekktu@gmail.com>
4873
4874 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4875
801a4313
EZ
48762011-11-30 Eli Zaretskii <eliz@gnu.org>
4877
4878 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4879 attributes are tested _before_ calling verify_row_hash, to protect
4880 against GCC re-ordering of the tests. (Bug#10164)
4881
2b56b87e
JD
48822011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4883
4884 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4885
4886 * xterm.c (handle_one_xevent): Only set async_visible and friends
4887 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4888 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4889 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4890
dbf31225
PE
48912011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4894 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4895 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4896 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4897 All uses changed to use GCPRO1 etc.
4898 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4899 Revert to old implementation (i.e., before 2011-03-11).
4900
1305621b
YM
49012011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4902
4903 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4904 of scroll runs so as to avoid assigning disabled bogus rows and
4905 unnecessary graphics copy operations.
4906
8c9afb46
EZ
49072011-11-27 Eli Zaretskii <eliz@gnu.org>
4908
4909 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4910 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4911 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4912 (malloc, free, realloc, calloc): Redirect to e_* only when
4913 compiling Emacs.
4914
4915 * lisp.h (GCTYPEBITS): Move before first use.
4916 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4917 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4918 this macro definition.
4919
4920 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4921 _MSC_VER.
4922
54e9e3bf
JD
49232011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4924
6d5eb5b0
SM
4925 * gtkutil.c (xg_create_frame_widgets):
4926 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4927 present with Gtk+ 2.0.
4928
83aca1cb
PE
49292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 * fileio.c (Finsert_file_contents): Undo previous change; see
4932 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4933
5b76caa4
PE
49342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4935
4936 Rename locals to avoid shadowing.
4937 * fileio.c (Finsert_file_contents):
4938 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4939 * process.c (wait_reading_process_output):
4940 Rename inner 'proc' to 'p' to avoid shadowing.
4941 Indent for consistency with usual Emacs style.
4942
8c535114
EZ
49432011-11-25 Eli Zaretskii <eliz@gnu.org>
4944
4945 * xdisp.c (redisplay_window): If cursor row is not fully visible
4946 after recentering, and scroll-conservatively is set to a large
4947 number, scroll window by a few more lines to make the cursor fully
4948 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4949 (start_display): Don't move to the next line if the display should
4950 start at a newline that is part of a display vector or an overlay
4951 string. (Bug#10119)
8c535114 4952
fa4fdb5c
JL
49532011-11-24 Juri Linkov <juri@jurta.org>
4954
4955 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4956 after the `MagickPingImage' call. (Bug#10112)
4957
90ec88df
CY
49582011-11-23 Chong Yidong <cyd@gnu.org>
4959
4960 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4961
56e2e794
MR
49622011-11-23 Martin Rudalics <rudalics@gmx.at>
4963
4964 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4965 making another buffer current. (Bug#10114)
4966
b6e64c41
GM
49672011-11-23 Glenn Morris <rgm@gnu.org>
4968
4969 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4970
6b21de18
CY
49712011-11-23 Chong Yidong <cyd@gnu.org>
4972
4973 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4974 using it (Bug#5984).
4975
b12cd789
EZ
49762011-11-22 Eli Zaretskii <eliz@gnu.org>
4977
4978 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4979 and header-lines, as they don't have one computed for them.
4980 (Bug#10098)
4981
4982 * .gdbinit (prow): Make displayed values more self-explaining.
4983 Add row's hash code.
4984
261b6fd4
LMI
49852011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4986
4987 * process.c (wait_reading_process_output): Fix asynchrounous
4988 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4989 (wait_reading_process_output): Add comment and URL.
261b6fd4 4990
e7cfd277
JD
49912011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4992
4993 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4994
a9b9b7f5
CY
49952011-11-21 Chong Yidong <cyd@gnu.org>
4996
4997 * window.c (Fnext_window, Fprevious_window): Doc fix.
4998
b0d15b4f
SM
49992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5000
5001 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5002
fe7a3057
JB
50032011-11-20 Juanma Barranquero <lekktu@gmail.com>
5004
5005 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5006
d2999b1a
MR
50072011-11-20 Martin Rudalics <rudalics@gmx.at>
5008
5009 * window.c (Fset_window_combination_limit): Rename argument
5010 STATUS to LIMIT.
5011 (Vwindow_combination_limit): Remove "status" from doc-string.
5012
d5ff9cd0
AS
50132011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5014
5015 * m/ibms390.h: Remove.
5016 * m/ibms390x.h: Don't include "ibms390.h".
5017
a5bb9bd3
SM
50182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5019
5020 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5021 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5022
cd1181db
JB
50232011-11-20 Juanma Barranquero <lekktu@gmail.com>
5024
5025 * casetab.c (Fset_case_table):
5026 * charset.c (Fcharset_after): Fix typos.
5027
615a3b8d 50282011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5029
17e845af
PE
5030 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5031 Otherwise, valgrind does not work on some platforms.
5032 Problem reported by Andreas Schwab in
6a0bf43d
PE
5033 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5034 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5035 is set, removing the need for VIRT_ADDRESS_VARIES.
5036 (PURE_P): Use a more-efficient implementation that needs just one
5037 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5038 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5039 to 4 (xorl, subq, cmpq, setbe).
5040 * alloc.c (pure): Always extern now, since that's the
5041 VIRT_ADDR_VARIES behavior.
5042 (PURE_POINTER_P): Use a single comparison, not two, for
5043 consistency with the new puresize.h.
5044 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5045 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5046 Remove VIRT_ADDR_VARIES no longer needed.
5047
f8fe6f96
EZ
50482011-11-19 Eli Zaretskii <eliz@gnu.org>
5049
5050 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5051 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5052 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5053 behave as if the cursor position were at the window margin.
5054
5055 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5056 and the cursor position is out of bounds, behave as if the cursor
5057 position were at the window margin. (Bug#10075)
5058
df05a53c
CY
50592011-11-18 Chong Yidong <cyd@gnu.org>
5060
5061 * window.c (Fwindow_combination_limit): Make first argument
5062 non-optional, since it is meaningless for live windows like the
5063 selected window.
61ccba97 5064
2071918e
DA
50652011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5066
5067 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5068
b50a28de
SM
50692011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5070
5071 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5072 (graft_intervals_into_buffer): Simplify.
5073
015137db
EZ
50742011-11-18 Eli Zaretskii <eliz@gnu.org>
5075
5076 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5077 hash values of the two rows.
5078 (copy_row_except_pointers): Preserve the used[] arrays and the
5079 hash values of the two rows. (Bug#10035)
68c95424 5080 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5081
5082 * xdisp.c (row_hash): New function, body extracted from
5083 compute_line_metrics.
5084 (compute_line_metrics): Call row_hash, instead of computing the
5085 hash code inline.
5086
5087 * dispnew.c (verify_row_hash): Call row_hash for computing the
5088 hash code of a row, instead of duplicating code from xdisp.c.
5089
5090 * dispextern.h (row_hash): Add prototype.
5091
a2addb04
TH
50922011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5093
5094 * frame.c (delete_frame): Don't delete the terminal when the last
5095 X frame is closed if emacs is built with GTK toolkit.
5096
df85d315
JB
50972011-11-17 Juanma Barranquero <lekktu@gmail.com>
5098
5099 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5100
a0c2d0ae
MR
51012011-11-17 Martin Rudalics <rudalics@gmx.at>
5102
5103 * window.c (Vwindow_splits): Rename to
5104 Vwindow_combination_resize. Suggested by Juri Linkov.
5105 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5106 of Vwindow_splits.
5107
58179cce
JB
51082011-11-16 Juanma Barranquero <lekktu@gmail.com>
5109
7877f373
JB
5110 * nsfns.m (Fns_font_name):
5111 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5112
b6f67890
MR
51132011-11-16 Martin Rudalics <rudalics@gmx.at>
5114
5115 * window.h (window): Rename slot "nest" to "combination_limit".
5116 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5117 (Fset_window_nest): Rename to Fset_window_combination_limit.
5118 (Vwindow_nest): Rename to Vwindow_combination_limit.
5119 (recombine_windows, make_parent_window, make_window)
5120 (Fsplit_window_internal, saved_window)
5121 (Fset_window_configuration, save_window_save): Rename all
5122 occurrences of window_nest to window_combination_limit.
5123
c7015153
JB
51242011-11-15 Juanma Barranquero <lekktu@gmail.com>
5125
5126 * image.c (imagemagick_load_image): Fix typo.
5127
322ad6ec
EZ
51282011-11-14 Eli Zaretskii <eliz@gnu.org>
5129
5130 * xdisp.c (display_line): Move the call to
5131 highlight_trailing_whitespace before the call to
5132 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5133 faces of all the glyphs to compute ROW's hash value.
5134 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5135
f067b8ec
JB
51362011-11-14 Juanma Barranquero <lekktu@gmail.com>
5137
5138 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5139 just return (bug#10044).
5140
1e5b2111
EZ
51412011-11-12 Eli Zaretskii <eliz@gnu.org>
5142
7ef3cbd5
EZ
5143 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5144 with user-defined heap size. Bump the default size of the temacs
5145 heap to 27MB, to avoid memory warning when running temacs.
5146 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5147
1e5b2111
EZ
5148 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5149 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5150 (verify_row_hash) [XASSERTS]: New function.
5151 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5152 that the hash value of glyph rows is correct.
1e5b2111 5153
89d61221
MR
51542011-11-12 Martin Rudalics <rudalics@gmx.at>
5155
5156 * window.h (window): Remove splits slot.
5157 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5158 (Fdelete_other_windows_internal, make_parent_window)
5159 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5160 (Fset_window_configuration, save_window_save): Don't deal with
5161 split status of windows.
5162 (saved_window): Remove splits slot.
5163 (Vwindow_splits): Rewrite doc-string.
5164
97f18cc8
JD
51652011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5166
5167 * xfns.c (unwind_create_frame):
5168 * nsfns.m (unwind_create_frame):
5169 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5170 Vframe_list (Bug#9999).
5171
22a648b4
DA
51722011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5173
0b381c7e 5174 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5175
659afede
KH
51762011-11-11 Kenichi Handa <handa@m17n.org>
5177
5178 * callproc.c (Fcall_process): Set the member dst_multibyte of
5179 process_coding.
5180
9ac0394b
KH
51812011-11-11 Johan Bockgård <bojohan@gnu.org>
5182
5183 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5184 avoid a crash (bug#9496).
5185
2fbdc249
CY
51862011-11-09 Chong Yidong <cyd@gnu.org>
5187
5188 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5189 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5190
ac6b1f81
PE
51912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5194
09db192c
PE
51952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5196
5197 Avoid some portability problems by eschewing 'extern inline' functions.
5198 The trivial performance wins aren't worth the portability hassles; see
5199 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5200 et seq.
5201 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5202 (window_box_width, window_box_left, window_box_left_offset)
5203 (window_box_right, window_box_right_offset): Undo previous change,
5204 by removing the "extern"s.
5205 * intervals.c (adjust_intervals_for_insertion)
5206 (adjust_intervals_for_deletion): Undo previous change,
5207 making these static again.
5208 (offset_intervals, temp_set_point_both, temp_set_point)
5209 (copy_intervals_to_string): No longer inline.
5210 * xdisp.c (window_text_bottom_y, window_box_width)
5211 (window_box_height, window_box_left_offset)
5212 (window_box_right_offset, window_box_left, window_box_right)
5213 (window_box): No longer inline.
5214
105216ed
CY
52152011-11-08 Chong Yidong <cyd@gnu.org>
5216
5217 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5218 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5219 Signal an error if not a live window.
105216ed
CY
5220 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5221 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5222
ae9e237f
JB
52232011-11-07 Juanma Barranquero <lekktu@gmail.com>
5224
5225 * lisp.h (syms_of_abbrev): Remove declaration.
5226 Reported by CHENG Gao <chenggao@royau.me>.
5227
c7aa8333
EZ
52282011-11-07 Eli Zaretskii <eliz@gnu.org>
5229
5230 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5231 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5232 of temacs in GUI mode.
5233
be7f5545
MR
52342011-11-07 Martin Rudalics <rudalics@gmx.at>
5235
5236 * window.h: Declare delete_all_child_windows instead of
5237 delete_all_subwindows.
5238 * window.c (Fwindow_nest, Fset_window_nest)
5239 (Fset_window_new_total, Fset_window_new_normal)
5240 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5241 (delete_all_subwindows): Rename to delete_all_child_windows.
5242 (Fdelete_other_windows_internal, Fset_window_configuration):
5243 Call delete_all_child_windows instead of delete_all_subwindows.
5244 * frame.c (delete_frame): Call delete_all_child_windows instead
5245 of delete_all_subwindows.
5246
ca78dc43
PE
52472011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5248
5249 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5250 This is also needed for porting to any host where GC_MARK_STACK is
5251 not GC_MAKE_GCPROS_NOOPS.
5252 (which_symbols): Use it.
5253
a0241d01
KH
52542011-11-07 Kenichi Handa <handa@m17n.org>
5255
5256 * coding.c (coding_set_destination): Check coding->src_pos only
5257 when coding->src_object is a buffer (bug#9910).
5258
5259 * process.c (send_process): Set the member src_multibyte of coding
5260 to 0 (bug#9911) when sending a unibyte text.
5261
5262 * callproc.c (Fcall_process): Set the member src_multibyte of
5263 process_coding to 0 (bug#9912).
5264
a64bfdfa 52652011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5266
5267 * xmenu.c (cleanup_widget_value_tree): New function.
5268 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5269 calling free_menubar_widget_value_tree directly (Bug#9830).
5270
cb41b32a
PE
52712011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5272
5273 Fix some portability problems with 'inline'.
5274 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5275 (window_box_width, window_box_left, window_box_left_offset)
5276 (window_box_right, window_box_right_offset): Declare extern.
5277 Otherwise, these inline functions do not conform to C99 and
5278 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5279 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5280 * intervals.c (adjust_intervals_for_insertion)
5281 (adjust_intervals_for_deletion): Now extern, because otherwise the
5282 extern inline functions 'offset_intervals' couldn't refer to it.
5283 (static_offset_intervals): Remove.
5284 (offset_intervals): Rewrite using the old contents of
5285 static_offset_intervals. The old version didn't conform to C99
5286 because an extern inline function contained a reference to an
5287 identifier with static linkage.
5288
b7041366
AS
52892011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5290
5291 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5292 GC.
5293
88a37c4d
EZ
52942011-11-06 Eli Zaretskii <eliz@gnu.org>
5295
5296 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5297 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5298 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5299 return Qleft_to_right.
5300
49745b39
CY
53012011-11-06 Chong Yidong <cyd@gnu.org>
5302
5303 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5304 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5305 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5306 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5307 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5308 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5309 (Fwindow_vscroll): Doc fix.
5310 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5311 argument, since it makes no sense to pass a live window and for
5312 consistency with window-child.
5313
1f05cd82
CS
53142011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5315
5316 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5317 support MSVC.
5318
22610910
JR
53192011-11-05 Jason Rumney <jasonr@gnu.org>
5320
5321 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5322 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5323 fonts (Bug#6029).
5324 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5325 bitwise arithmetic preventing use of unicode-sip and non-truetype
5326 opentype fonts.
5327
a06776b2
EZ
53282011-11-05 Eli Zaretskii <eliz@gnu.org>
5329
3ad924ba
EZ
5330 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5331 "emacs"-only part.
5332
a06776b2
EZ
5333 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5334 initialization code to keep similarity to xfns.c after changes
5335 from 2011-11-05.
5336
c9e7db78
JD
53372011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5338
a97f8f3f
JD
5339 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5340 (unwind_create_frame): New function (Bug#9943).
5341 (Fx_create_frame): Restructure code to be more similar to the one in
5342 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5343 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5344 Move terminal->reference_count++ just before making the frame official
5345 (Bug#9943).
5346
5347 * nsterm.m (x_free_frame_resources): New function.
5348 (x_destroy_window): Move code to x_free_frame_resources.
5349
c9e7db78 5350 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5351 (Fx_create_frame, x_create_tip_frame):
5352 Move terminal->reference_count++ just before making the frame
75f1671a 5353 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5354 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5355
a6fc3b5c
EZ
53562011-11-05 Eli Zaretskii <eliz@gnu.org>
5357
5358 Support MSVC build with newer versions of Visual Studio.
5359 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5360 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5361 nt/gmake.defs.
5362
5363 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5364 which are not supported by MSVC.
5365 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5366 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5367 bitfields.
5368 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5369 types in bitfields.
5370 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5371
5372 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5373
58179cce 53742011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5375
5376 Support MSVC build with newer versions of Visual Studio.
5377 * w32.c: Don't include w32api.h for MSVC.
5378 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5379
5380 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5381 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5382 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5383 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5384 e_* cousins.
5385 (alloca) [_MSC_VER]: Define to _alloca.
5386
5387 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5388
5389 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5390
a58c13ed
EZ
53912011-11-04 Eli Zaretskii <eliz@gnu.org>
5392
5393 * xdisp.c (note_mouse_highlight): If either of
5394 previous/next-single-property-change returns nil, treat that as
5395 the beginning or the end of the buffer. (Bug#9955)
5396
fe0b6370
JD
53972011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5398
a58c13ed 5399 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5400 label is not null (Bug#9951).
5401 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5402 may be NULL.
5403
89bd5ee1
EZ
54042011-11-04 Eli Zaretskii <eliz@gnu.org>
5405
5406 * window.c (Fwindow_body_size): Mention in the doc string that the
5407 return value is in frame's canonical units. (Bug#9949)
5408
84c3edb9
EZ
54092011-11-03 Eli Zaretskii <eliz@gnu.org>
5410
4e2fb5c7
EZ
5411 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5412
84c3edb9 5413 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5414 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5415 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5416
bc17a887
EZ
54172011-11-01 Eli Zaretskii <eliz@gnu.org>
5418
5419 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5420 Don't stop backward scan on the continuation glyph, even though
5421 its CHARPOS is positive.
6d5eb5b0
SM
5422 (mouse_face_from_buffer_pos, note_mouse_highlight):
5423 Rename cover_string to disp_string.
bc17a887 5424
4ee88440
MR
54252011-11-01 Martin Rudalics <rudalics@gmx.at>
5426
5427 * window.c (temp_output_buffer_show): Don't use
5428 Vtemp_buffer_show_specifiers.
5429 (Vtemp_buffer_show_specifiers): Remove unused variable.
5430
c2ff3c02
EZ
54312011-10-30 Eli Zaretskii <eliz@gnu.org>
5432
5433 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5434 past the beginning of the current glyph matrix.
5435
58179cce 54362011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5437
5438 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5439 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5440 HAVE_GTK3 (Bug#9869).
b77a6a7f 5441
3b574623
JD
5442 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5443 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5444
b77a6a7f
JD
5445 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5446
5447 * xterm.c: Declare x_handle_net_wm_state to return int.
5448 (handle_one_xevent): Check if we are iconified but don't have
5449 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5450 (get_current_wm_state): Return non-zero if not hidden,
5451 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5452 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5453 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5454 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5455
196e41e4
PE
54562011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5457
5458 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5459 so that this new function doesn't get optimized away by a
5460 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5461
021f2e1a
AS
54622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5463
5464 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5465
8b058d44
EZ
54662011-10-29 Eli Zaretskii <eliz@gnu.org>
5467
5468 Fix the `xbytecode' command.
5469 * .gdbinit (xprintbytestr): New command.
b50a28de 5470 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5471 (xbytecode): Print the byte-code string as well.
5472
4452fb80
EZ
54732011-10-29 Kim Storm <storm@cua.dk>
5474
8b058d44
EZ
5475 * alloc.c (which_symbols): New function.
5476
21b72067
AS
54772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5478
5479 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5480 line. (Bug#9903)
5481
83ed7b5c
GM
54822011-10-29 Glenn Morris <rgm@gnu.org>
5483
5484 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5485 Not clear what it was for, and it causes various bugs. (Bug#9839)
5486
5a7a728b
EZ
54872011-10-28 Eli Zaretskii <eliz@gnu.org>
5488
5489 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5490 possible random value that matches one of those tested as
5491 condition to clear the mouse face.
5492
d3d0842f
CY
54932011-10-28 Chong Yidong <cyd@gnu.org>
5494
5495 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5496
31b39d13
DN
54972011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5498
5499 * window.c (make_window): Initialize phys_cursor_on_p.
5500
9aba6043
SM
55012011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5502
5503 * lisp.h (struct Lisp_Symbol): Update comments.
5504
c20992f4
JB
55052011-10-28 Juanma Barranquero <lekktu@gmail.com>
5506
5507 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5508
db4f02f2
EZ
55092011-10-28 Eli Zaretskii <eliz@gnu.org>
5510
5511 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5512 <oslsachem@gmail.com> for helping to debug this.
5513
5514 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5515 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5516 (g_b_init_get_glyph_outline_w): New static variables.
5517 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5518 (GetGlyphOutlineW_Proc): New typedefs.
5519 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5520 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5521 New functions.
5522 (w32font_open_internal, compute_metrics):
5523 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5524 instead of calling the "wide" APIs directly.
5525
5526 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5527
5528 * w32.h (syms_of_w32font): Add prototype.
5529
87e68db4
JB
55302011-10-27 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5533 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5534 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5535 (Fmove_to_window_line): Doc fix.
5536
435c1d67
CY
55372011-10-27 Chong Yidong <cyd@gnu.org>
5538
5539 * process.c (make_process): Set gnutls_state to NULL.
5540
5541 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5542 non-NULL, regardless of GNUTLS_INITSTAGE.
5543 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5544 an error. Set process slots as soon as we allocate them.
5545
5546 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5547
9c6c6f49
CY
55482011-10-27 Chong Yidong <cyd@gnu.org>
5549
9aba6043
SM
5550 * gnutls.c (emacs_gnutls_deinit): New function.
5551 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5552 (Fgnutls_deinit, Fgnutls_boot): Use it.
5553
5554 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5555 (deactivate_process): Call emacs_gnutls_deinit.
5556
657d08d3
JB
55572011-10-27 Juanma Barranquero <lekktu@gmail.com>
5558
5559 * image.c (x_create_x_image_and_pixmap):
5560 * w32.c (sys_rename, w32_delayed_load):
5561 * w32font.c (fill_in_logfont):
5562 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5563
5430d399
JB
55642011-10-26 Juanma Barranquero <lekktu@gmail.com>
5565
5566 * w32fns.c (w32_default_color_map): New function,
5567 extracted from Fw32_default_color_map.
a7ef684b 5568 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5569
fe0055fa
PE
55702011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5573
e6346438
SM
55742011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5575
5576 * keyboard.c (test_undefined): New function (bug#9751).
5577 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5578
e112cc37
ET
55792011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5580
5581 * sysdep.c (init_sys_modes): Fix the check for the controlling
5582 terminal (Bug#6649).
5583
7b5d6677
EZ
55842011-10-20 Eli Zaretskii <eliz@gnu.org>
5585
5586 * dispextern.h (struct bidi_it): New member next_en_type.
5587
5588 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5589 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5590 current character, check also for next_en_type being WEAK_EN.
5591 (bidi_resolve_weak): Don't enter the expensive loop if the current
5592 position is before next_en_pos. Record the bidi type of the first
5593 non-ET, non-BN character we find, in addition to its position.
5594 (bidi_level_of_next_char): Invalidate next_en_type when
5595 next_en_pos is over-stepped.
5596
7da0b018
PE
55972011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5598
5599 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5600 * editfns.c: Rewrite current-time-zone so that it invokes
5601 the equivalent of (format-time-string "%Z") to get the time zone name.
5602 This fixes a bug when the time zone name contains characters that
5603 need converting from the system time locale to Emacs internal format.
5604 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5605 that patch fixed format-time-string to do the conversion, but
5606 I forgot to fix current-time-zone.
5607 (format_time_string): New function, containing most of
5608 what Fformat_time_string used to contain.
5609 (Fformat_time_string): Rewrite in terms of format_time_string.
5610 This doesn't change this function's behavior.
5611 (current-time-zone): Rewrite to use format_time_string.
5612 This fixes the bug reported by Michael Schierl in
5613 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5614 Jason Rumney's 2007-06-07 change worked around this bug, but
5615 didn't fix it.
5616 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5617
8547b010
EZ
56182011-10-19 Eli Zaretskii <eliz@gnu.org>
5619
5620 * xdisp.c (start_display): If the character at POS is displayed
5621 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5622 (try_window_reusing_current_matrix): If a line ends in a display
5623 vector or the next line starts in a display vector, continue
5624 redrawing the window even though the character position of
5625 start_row was reached.
8547b010
EZ
5626 (Bug#9771, part 2)
5627
4e948d15
CY
56282011-10-18 Chong Yidong <cyd@gnu.org>
5629
5630 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5631 with nobreak-char-display too.
5632
4787455f
EZ
56332011-10-18 Eli Zaretskii <eliz@gnu.org>
5634
5635 Fix part 3 of bug#9771.
5636 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5637 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5638 non-neutral characters if the current character is a paragraph
5639 separator (a.k.a. Newline). This avoids running the same
5640 expensive loop twice, once when we consume the preceding newline
5641 and the other time when the line actually needs to be displayed.
5642 Avoid the loop when we see neutrals on the base embedding level
5643 following a character whose directionality is the same as the
5644 paragraph's. This avoids running the expensive loop when a line
5645 ends in a long sequence of neutrals, like control characters.
5646 Add assertion against STRONG_AL type. Slightly rearrange code
5647 that determines the type of a neutral given the first non-neutral
5648 that follows it.
5649 (bidi_level_of_next_char): Set next_en_pos to zero when
5650 invalidating its info.
5651
2c91f553
EZ
56522011-10-17 Eli Zaretskii <eliz@gnu.org>
5653
5654 * xdisp.c (push_display_prop): Determine whether to record string
5655 or buffer position by IT->string, not by IT->method. Allow
5656 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5657 (move_it_vertically_backward): Don't look for character position
5658 immediately after the newline when in a continuation line.
5659 (Bug#9771, part 1)
2c91f553 5660
c7b08b0d
MR
56612011-10-15 Martin Rudalics <rudalics@gmx.at>
5662
5663 * window.c (coordinates_in_window): Rewrite and delabelize
5664 vertical border check. (Bug#5357) (Bug#9618)
5665
6b02f655
SM
56662011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5667
5668 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5669 errors in XSetWindowBorder (bug#9310).
5670
81d40c92
DA
56712011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5672
5673 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5674 avoid crash when xmalloc overrun checking is enabled.
5675
d4172c3b
EZ
56762011-10-13 Eli Zaretskii <eliz@gnu.org>
5677
5678 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5679 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5680 cursor motion with <left> and <right> arrow keys.
5681
5682 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5683 some callers set that themselves.
5684
b00eea75
EZ
56852011-10-12 Eli Zaretskii <eliz@gnu.org>
5686
5687 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5688 display string and the previous row comes from the same string and
5689 is empty. (Bug#9739) (Bug#9738)
5690
8fe012c4
SM
56912011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5692
5693 * doc.c (get_doc_string): Encode file name (bug#9735).
5694
0074aef2
EZ
56952011-10-12 Eli Zaretskii <eliz@gnu.org>
5696
79beb178
EZ
5697 * bidi.c (bidi_level_of_next_char):
5698 * xdisp.c (get_visually_first_element): Remove old incorrect
5699 comments regarding the Unicode Line Separator character.
5700
0074aef2
EZ
5701 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5702
6e4b3fbe
DA
57032011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5704
5705 * alloc.c (Fgc_status): Do not access beyond zombies array
5706 boundary if nzombies > MAX_ZOMBIES.
5707 * alloc.c (dump_zombies): Add missing format specifier.
5708
0324f3af
PE
57092011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5710
b5525cac
PE
5711 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5712 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5713
0324f3af
PE
5714 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5715 Some packages use them to denote characters with modifiers.
5716
e9b5f888
AS
57172011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5718
5719 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5720 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5721 matching a pp-number. Rename parameter var to var1.
5722
127827c0
SM
57232011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5724
5725 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5726
c8fd3bd0
GM
57272011-10-08 Glenn Morris <rgm@gnu.org>
5728
5729 * callint.c (Fcall_interactively): Give a more explicit error for the
5730 'c' case with a non-character input. (Bug#8479)
5731
352ec8ff
EZ
57322011-10-08 Eli Zaretskii <eliz@gnu.org>
5733
03669ccb
EZ
5734 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5735 lines.
7061c986
EZ
5736 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5737 lines that are hscrolled on the left.
03669ccb 5738
352ec8ff
EZ
5739 * dispnew.c (buffer_posn_from_coords): Account for a possible
5740 presence of header-line. (Bug#4426)
5741
a66cfb1c
SM
57422011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5743
6b02f655
SM
5744 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5745 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5746
7c5ee88e
PE
57472011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5748
5749 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5750 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5751 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5752 this makes Emacs dump core during garbage collection on rare
5753 occasions. sizeof is obviously inferior to offsetof here, so
5754 stick with offsetof.
5755 (GC_POINTER_ALIGNMENT): New macro.
5756 (mark_memory): Omit 3rd (offset) arg; caller changed.
5757 Don't assume EMACS_INT alignment is the same as pointer alignment.
5758
df1bbe5b
SM
57592011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5760
5761 * keyboard.c (read_key_sequence_remapped): New var.
5762 (read_key_sequence): Compute remapping in the right buffer.
5763 (command_loop_1): Use read_key_sequence's remapping directly.
5764
51553db6
SM
57652011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5766
32c1fffd
SM
5767 * dired.c (file_name_completion): Don't expand file name.
5768 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5769 before checking file name handler.
5770
51553db6
SM
5771 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5772 they've been requested explicitly (bug#9591).
5773
b6bd1599 57742011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5775
5776 * keymap.c (Fsingle_key_description): Use make_specified_string
5777 instead of build_string to build string from push_key_description.
5778 (Bug#5193)
5779
f701dc2a
PE
57802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5781
4222c55d
PE
5782 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5783 This fixes a Y2038 bug on 64-bit hosts.
5784 * buffer.c (reset_buffer):
5785 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5786 (Fclear_buffer_auto_save_failure):
5787 Use 0, not -1, to represent an unset failure time, since time_t
5788 might not be signed.
5789
f701dc2a
PE
5790 Remove dependency on glibc malloc internals.
5791 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5792 Move back here from lisp.h, but with their new implementations.
5793 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5794 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5795 * charset.c (charset_table_init): New static var.
5796 (syms_of_charset): Use it instead of xmalloc. This removes a
5797 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5798 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5799 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5800 Move back to alloc.c.
5801 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5802 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5803
9ceebf39
JD
58042011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5805
5806 * nsterm.m (windowDidResize): Call x_set_window_size only when
5807 ns_in_resize is true. Otherwise set pixelwidth/height and
5808 call change_frame_size (Bug#9628).
5809
cb993c58
PE
58102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5811
3930c88b
PE
5812 Port --enable-checking=all to Fedora 14 x86-64.
5813 * charset.c (syms_of_charset): Also account for glibc malloc's
5814 internal overhead when calculating the initial malloc maximum.
5815
cb993c58
PE
5816 Port --enable-checking=all to Fedora 14 x86.
5817 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5818 Move to lisp.h.
5819 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5820 (overrun_check_realloc, overrun_check_free):
5821 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5822 That way, xmalloc returns a properly-aligned pointer even if
5823 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5824 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5825 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5826 into account when calculating the initial malloc maximum.
5827 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5828 Move here from alloc.c, so that charset.c can use it too.
5829 Properly align; the old code wasn't right for common 32-bit hosts
5830 when configured with --enable-checking=all.
5831 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5832 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5833
31bed486
EZ
58342011-09-29 Eli Zaretskii <eliz@gnu.org>
5835
04c70788 5836 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5837 use EDOM.
5838
fbcaa2f3
EZ
58392011-09-28 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (compute_display_string_end): If there's no display
5842 string at CHARPOS, return -1.
5843
5844 * bidi.c (bidi_fetch_char): When compute_display_string_end
5845 returns a negative value, treat the character as a normal
5846 character not covered by a display string. (Bug#9624)
5847
a239d4e9
JB
58482011-09-28 Juanma Barranquero <lekktu@gmail.com>
5849
5850 * lread.c (Fread_from_string): Fix typo in docstring.
5851
88652fd5
EZ
58522011-09-27 Eli Zaretskii <eliz@gnu.org>
5853
5854 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5855 newline, reseat the iterator instead of bidi-iterating there one
5856 character at a time. (Bug#9610)
32c1fffd
SM
5857 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5858 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5859
ed497dd4
AS
58602011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5861
5862 * lread.c (readevalloop): Use correct code for NBSP.
5863 (read1): Likewise. (Bug#9608)
5864
b2bf61aa
MA
58652011-09-25 Michael Albinus <michael.albinus@gmx.de>
5866
5867 * dbusbind.c (Fdbus_register_signal): When service is not
5868 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5869
32bbb17c
GM
58702011-09-25 Glenn Morris <rgm@gnu.org>
5871
5872 * buffer.c (truncate-lines): Doc fix.
5873
94e0933e
CY
58742011-09-24 Chong Yidong <cyd@stupidchicken.com>
5875
5876 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5877 (Fset_window_next_buffers): Doc fix.
5878
cddde921
GM
58792011-09-24 Glenn Morris <rgm@gnu.org>
5880
5881 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5882
1260aef1
PE
58832011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5884
25b4bfa0
PE
5885 Fix minor problems found by static checking.
5886 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5887 * indent.c (Fvertical_motion): Fix == vs = typo.
5888
e3cbd34b
EZ
58892011-09-24 Eli Zaretskii <eliz@gnu.org>
5890
a66cfb1c
SM
5891 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5892 Default value is now t. Doc fix.
6bf7006f 5893
e3cbd34b 5894 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5895 logic when moving up, not only when moving down. Fix the
e3cbd34b 5896 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5897 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5898
5899 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5900 CHARPOS is covered by a display string which includes newlines.
5901 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5902 is covered by a display string with embedded newlines.
5903
a3de0cbd
MA
59042011-09-24 Michael Albinus <michael.albinus@gmx.de>
5905
5906 * dbusbind.c (Fdbus_register_signal): Add match rule to
5907 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5908 (Fdbus_register_method, Vdbus_registered_objects_table):
5909 Fix docstring.
a3de0cbd 5910
b260039d
JM
59112011-09-24 Jim Meyering <meyering@redhat.com>
5912
32c1fffd 5913 do not ignore write error for any output size
b260039d
JM
5914 The previous change was incomplete.
5915 While it makes emacs --batch detect the vast majority of stdout
5916 write failures, errors were still ignored whenever the output size is
5917 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5918 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5919 && echo FAIL: ignored write error
5920 FAIL: ignored write error
5921 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5922 && echo FAIL: ignored write error
5923 FAIL: ignored write error
5924 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5925
8eca8a7c
AS
59262011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5927
5928 * emacs.c (Fkill_emacs): In noninteractive mode exit
5929 non-successfully if a write error occurred on stdout. (Bug#9574)
5930
3341db62
EZ
59312011-09-21 Eli Zaretskii <eliz@gnu.org>
5932
5933 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5934 the xassert test.
5935
5936 * dispextern.h (struct it): Update the comment documenting what
5937 can it->OBJECT be.
5938
8c203dbf
EZ
59392011-09-20 Eli Zaretskii <eliz@gnu.org>
5940
5941 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5942 a display string, extend search for cursor position to end of row.
5943 (find_row_edges): If the row ends in a newline from a display
5944 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5945 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5946 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5947 non-empty line. Fixes confusing cursor motion with arrow keys at
5948 the beginning of a line that starts with whitespace.
8c203dbf 5949
a4824228
LMI
59502011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5951
5952 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5953 (bug#9493).
5954
33ed493b
CY
59552011-09-18 Chong Yidong <cyd@stupidchicken.com>
5956
5957 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5958 boolean (Bug#9154).
5959
56cd55c8
EZ
59602011-09-18 Eli Zaretskii <eliz@gnu.org>
5961
5962 * xdisp.c (display_line): Record maximum and minimum buffer
5963 positions even if no glyphs were produced (e.g., by a zero-width
5964 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5965 buffer positions that will be removed from the glyph row because
5966 they don't fit.
c02dcedf
EZ
5967 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5968 column is beyond frame width: don't subtract 1 "pixel" when
5969 computing width of the stretch.
3e62b7e0
EZ
5970 (reseat_at_next_visible_line_start): Undo the change made on
5971 2011-09-17 that saved paragraph information and restored it after
5972 the call to `reseat'. (Bug#9545)
56cd55c8 5973
5ed99d36 59742011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5975
5976 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5977 and turn window cursor on if cleared (Bug#9415).
5978
5ed99d36 59792011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5980
5981 * search.c (boyer_moore): Take unibyte characters from pattern
5982 literally. (Bug#9458)
5983
9bade7b2
EZ
59842011-09-18 Eli Zaretskii <eliz@gnu.org>
5985
5986 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5987
e5e9d610
PE
59882011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5989
87e4427a
PE
5990 Fix minor problem found by static checking.
5991 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5992 initialized, to pacify gcc -Wuninitialized.
5993
e5e9d610
PE
5994 * fileio.c: Report proper errno when syscall falls.
5995 (Finsert_file_contents): Save and restore errno,
5996 so that report_file_error outputs the correct diagnostic.
5997 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5998
a1674f0b
EZ
59992011-09-18 Eli Zaretskii <eliz@gnu.org>
6000
6001 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6002
fbfb6dd4
EZ
60032011-09-17 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6006 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6007
bb187662
EZ
60082011-09-17 Eli Zaretskii <eliz@gnu.org>
6009
1137e8b8 6010 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6011 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6012
6013 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6014 (bidi_find_paragraph_start): Search back for paragraph beginning
6015 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6016 (bidi_move_to_visually_next): Only trigger paragraph-related
6017 computations when the last character is a newline or at EOB, not
6018 just any NEUTRAL_B. (Bug#9470)
6019
bb187662
EZ
6020 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6021 truncated lines if point is covered by a display string. (Bug#9524)
6022
2e621251
PE
60232011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6024
6025 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6026 (cons_to_x_long): New function.
6027 (lisp_data_to_selection_data): Use it. Correct the test for
6028 short-versus-long data; it was negated. Break out of vector
6029 loop, for efficiency, when a long datum is discovered.
6030
91a15bc6
SM
60312011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6032
6033 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6034
b41c3a35
EZ
60352011-09-16 Eli Zaretskii <eliz@gnu.org>
6036
6037 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6038 GCC PR/17406) by declaring this function with external scope.
6039
7812ba2d
PE
60402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6041
6042 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6043 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6044
cf7edc2a
AS
60452011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6046
6047 * editfns.c (Fformat): Correctly handle text properties on "%%".
6048
bd01620e
EZ
60492011-09-15 Eli Zaretskii <eliz@gnu.org>
6050
6051 * xterm.c (x_draw_composite_glyph_string_foreground):
6052 * w32term.c (x_draw_composite_glyph_string_foreground):
6053 * term.c (encode_terminal_code):
6054 * composite.c (composition_update_it, get_composition_id):
6055 * xdisp.c (get_next_display_element)
6056 (fill_composite_glyph_string): Add comments about special meaning
6057 of TAB characters in a composition.
6058
a02719a3
PE
60592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6060
6061 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6062 This occurs when processing a multibyte format.
6063 Problem reported by Wolfgang Jenker.
a02719a3 6064
72589a3c
JB
60652011-09-15 Johan Bockgård <bojohan@gnu.org>
6066
6067 * xdisp.c (try_cursor_movement): Only check for exact match if
6068 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6069
1c14176c
PE
60702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6071
6072 Remove unused external symbols.
6073 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6074 * xdisp.c (calc_pixel_width_or_height): Now static.
6075 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6076 * indent.c (check_display_width):
6077 * w32term.c: Fix comment to match code.
6078 * xterm.c, xterm.h (x_catching_errors): Remove.
6079
d2eea5b5
PE
60802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6081
6082 * xselect.c: Use signed conversions more consistently (Bug#9498).
6083 (selection_data_to_lisp_data): Assume incoming selection data are
6084 signed integers, not unsigned. This is to be consistent with
6085 outgoing selection data, which was modified to use signed integers
6086 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6087 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6088 expects long, not unsigned long.
6089
46888499
EZ
60902011-09-14 Eli Zaretskii <eliz@gnu.org>
6091
6092 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6093 computation of loop end. Reported by Johan Bockgård
6094 <bojohan@gnu.org>.
6095
ef8ef9fb
CY
60962011-09-13 Chong Yidong <cyd@stupidchicken.com>
6097
6098 * frame.c (Fother_visible_frames_p): Function deleted.
6099
fa819fed
EZ
61002011-09-12 Eli Zaretskii <eliz@gnu.org>
6101
6102 * indent.c (compute_motion): Process display vector front to back
6103 rather than the other way around. (Bug#2496)
6104
2ba8e008
SM
61052011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6106
6107 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6108
20f53c69
CY
61092011-09-11 Chong Yidong <cyd@stupidchicken.com>
6110
6111 * minibuf.c (Fread_from_minibuffer): Doc fix.
6112
d562d7a4
EZ
61132011-09-11 Eli Zaretskii <eliz@gnu.org>
6114
6115 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6116 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6117
1c4d7f3d
LMI
61182011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6119
6120 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6121 value for non-existent files.
6122
b885bf36
EZ
61232011-09-11 Eli Zaretskii <eliz@gnu.org>
6124
6125 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6126 set its "size" to -1. This will set the modtime_size field of
6127 the corresponding buffer to -1, which is what
6128 verify-visited-file-modtime expects for files that do not exist.
6129 (Bug#9139)
6130
6612f0bf
PE
61312011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6132
6133 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6134 here ...
6135 * lisp.h: ... from here. push_key_description is no longer
6136 defined in keyboard.c, so its declaration should not be in
6137 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6138 logically belongs with push_key_description.
6139
dfb3f755
PE
61402011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6141
6142 * buffer.h: Include <sys/types.h> instead of <time.h>.
6143 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6144 Problem reported by Herbert J. Skuhra.
6145
3134906c
LMI
61462011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6147
6148 * xml.c (parse_region): Make the parsing work for
6149 non-comment-starting XML files again (bug#9144).
6150
8d903f4e
AS
61512011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6152
6153 * image.c (gif_load): Fix calculation of bottom and right corner.
6154 (Bug#9468)
6155
80ad64f4
EZ
61562011-09-10 Eli Zaretskii <eliz@gnu.org>
6157
6158 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6159 redisplay in small windows.
6160
208a048d
EZ
61612011-09-09 Eli Zaretskii <eliz@gnu.org>
6162
6163 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6164
9b1c252e
MR
61652011-09-08 Martin Rudalics <rudalics@gmx.at>
6166
6167 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6168 Operate on live windows only.
6169
2949f33b
JB
61702011-09-08 Juanma Barranquero <lekktu@gmail.com>
6171
6172 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6173
e08dcafd
EZ
61742011-09-07 Eli Zaretskii <eliz@gnu.org>
6175
6176 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6177 only under bidi iteration.
6178
115b96bd
JD
61792011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6180
6181 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6182
c8199d0f
PE
61832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6184
6185 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6186 Without this fix, the command to link temacs failed due to an
6187 undefined symbol __builtin_isnan. This is because
6188 /usr/include/iso/math_c99.h #defines isnan(x) to
6189 __builtin_isnan(x), but the bundled gcc, which identifies itself
6190 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6191 a __builtin_isnan.
6192 * floatfns.c (isnan): #undef, and then #define to a clone of
6193 what's in data.c.
6194 (Fisnan): Always define, since it's always available now.
6195 (syms_of_floatfns): Always define isnan at the Lisp level.
6196
e39b275c 61972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6198
6199 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6200
b2db44d9 62012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6202
f4af5137 6203 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6204 The previous code assumed that file offsets (off_t values) fit in
6205 EMACS_INT variables, which is not true on typical 32-bit hosts.
6206 The code messed up by falsely reporting buffer overflow in cases
6207 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6208 when "big" contains more than 2**29 bytes, even though this
6209 inserts just one byte and does not overflow the buffer.
6210 (Finsert_file_contents): Store file offsets as off_t
6211 values, not as EMACS_INT values. Check for overflow when
6212 converting between EMACS_INT and off_t. When checking for
6213 buffer overflow or for overlap, take the offsets into account.
6214 Don't use EMACS_INT for small values where int suffices.
6215 When checking for overlap, fix a typo: ZV was used where
6216 ZV_BYTE was intended.
6217 (Fwrite_region): Don't assume off_t fits into 'long'.
6218 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6219
ecfc0a49
MA
62202011-09-05 Michael Albinus <michael.albinus@gmx.de>
6221
6222 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6223
6511acf2 62242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6225
0999621a 6226 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6227
6228 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6229 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6230 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6231 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6232 (modify_event_symbol): Do not assume that the length of
6233 name_alist_or_stem is safe to alloca and fits in int.
6234 (Fexecute_extended_command): Likewise for function name and binding.
6235 (Frecursion_depth): Wrap around reliably on integer overflow.
6236 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6237 since some callers pass EMACS_INT values.
6238 (Fsingle_key_description): Don't crash if symbol name contains more
6239 than MAX_ALLOCA bytes.
6240 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6241 (get_minibuffer): Arg is now EMACS_INT, not int.
6242 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6243 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6244 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6245
2be7d702
PE
6246 * dbusbind.c (signature_cat): New function.
6247 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6248 Do not overrun buffer; instead, report string overflow.
6249
9d1df220
PE
6250 * dispnew.c (add_window_display_history): Don't overrun buffer.
6251 Truncate instead; this is OK since it's just a log.
6252
33ef5c64
PE
6253 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6254 even if the time zone offset is outlandishly large.
6255 Don't mishandle offset == INT_MIN.
6256
66c6fdd5
PE
6257 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6258 when creating daemon; the previous buffer-overflow check was incorrect.
6259
d749b01b
PE
6260 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6261 which has the guts of the old verror function.
6262
b5cd1905
PE
6263 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6264 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6265
6e1a67fb
PE
6266 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6267 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6268 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6269 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6270 length of string rather than counting it via multiple sprintfs;
6271 that's simpler and more reliable.
c21721cc
PE
6272 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6273 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6274 sprintf, in case result does not fit in int.
6275
c57b67fc
PE
6276 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6277 (fontset_from_font): Print it.
6278
8a401434
PE
6279 * frame.c (tty_frame_count): Now printmax_t, not int.
6280 (make_terminal_frame, set_term_frame_name): Print it.
6281 (x_report_frame_params): In X, window IDs are unsigned long,
6282 not signed long, so print them as unsigned.
6283 (validate_x_resource_name): Check for implausibly long names,
6284 and don't assume name length fits in 'int'.
6285 (x_get_resource_string): Don't blindly alloca invocation name;
6286 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6287 not fit in int.
6288
6e1a67fb
PE
6289 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6290 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6291 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6292
0df02bf3
PE
6293 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6294 Use esprintf, not sprintf, in case result does not fit in int.
6295
48e30793
PE
6296 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6297 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6298 it as a large positive number.
6299 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6300 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6301
a66ff6d8
PE
6302 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6303 in case result does not fit in int.
6304
aca216ff
PE
6305 * print.c (float_to_string): Detect width overflow more reliably.
6306 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6307 buffer overrun. Don't assume list length fits in 'int'. Treat
6308 print length of 0 as 0, not as infinity; to be consistent with other
6309 uses of print length in this function. Don't overflow print length
6310 index. Don't assume hash table size fits in 'long', or that
6311 vectorlike size fits in 'unsigned long'.
6312
31c286f7
PE
6313 * process.c (make_process): Use printmax_t, not int, to format
6314 process-name gensyms.
6315
55e5faa1
PE
6316 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6317
80f2e268
PE
6318 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6319 to avoid potential buffer overrun.
6320
670741ab
PE
6321 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6322 if X resource line is longer than 512 bytes.
6323
b7163a50
PE
6324 * xfns.c (x_window): Make sprintf buffer a bit bigger
6325 to avoid potential buffer overrun.
6326
ae58ff1f
PE
6327 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6328
c43c8a6a
PE
6329 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6330
3f8236f4
PE
63312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6332
53e9fe90 6333 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6334 Without these, Emacs silently mishandles large integers sometimes.
6335 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6336 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6337
6511acf2
PE
6338 * xdisp.c (try_window_id): Check Emacs fixnum range before
6339 converting to 'int'.
806add1d 6340
6511acf2 6341 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6342 Check that an Emacs fixnum is in range before assigning it to 'int'.
6343 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6344 values converted from Emacs fixnums.
6345 (Frecenter): Don't wrap around a line count if it is out of 'int'
6346 range; instead, treat it as an extreme value.
6347 (Fset_window_configuration, compare_window_configurations):
6348 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6349
6511acf2
PE
6350 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6351 that can exceed INT_MAX. Check that EMACS_INT value is in range
6352 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6353 (match_limit): Don't assume that a fixnum can fit in 'int'.
6354
6511acf2 6355 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6356 exceed INT_MAX.
6357
6511acf2 6358 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6359 (Fvertical_motion): Don't wrap around LINES values that don't fit
6360 in 'int'. Instead, treat them as extreme values. This is good
6361 enough for windows, which can't have more than INT_MAX lines anyway.
6362
fcb901a7
LMI
63632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6364
0f2f6b6d
LMI
6365 * Require libxml/parser.h to avoid compilation warning.
6366
fcb901a7
LMI
6367 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6368
6369 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6370 since this reportedly can destroy thread storage.
6371
6e20a0d4
CY
63722011-08-30 Chong Yidong <cyd@stupidchicken.com>
6373
6374 * syntax.c (find_defun_start): Update all cache variables if
6375 exiting early (Bug#9401).
6376
148ae00e
EZ
63772011-08-30 Eli Zaretskii <eliz@gnu.org>
6378
f6cfbd8f
EZ
6379 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6380
148ae00e
EZ
6381 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6382 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6383 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6384
6385 * term.c (tty_append_glyph): New function.
6386 (produce_stretch_glyph): Static function and its prototype deleted.
6387
a66cfb1c
SM
6388 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6389 Add prototypes.
148ae00e 6390
c4a07a4c
PE
63912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6392
6393 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6394 when checking :margin (Bug#9390).
6395 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6396 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6397 so that the name doesn't mislead. All uses changed.
6398
6bc8cd65
JB
63992011-08-28 Johan Bockgård <bojohan@gnu.org>
6400
6401 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6402 set_tty_hooks.
6403
dca4927e
EZ
64042011-08-27 Eli Zaretskii <eliz@gnu.org>
6405
6406 * xdisp.c (move_it_to): Don't bail out early when reaching
6407 position beyond to_charpos, if we are scanning backwards.
6408 (move_it_vertically_backward): When DY == 0, make sure we get to
6409 the first character in the line after the newline.
6410
f2cad773
PE
64112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6412
6413 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6414 (ccl_driver): Do not generate an out-of-range pointer.
6415 (Fccl_execute_on_string): Remove unnecessary check for
6416 integer overflow, noted by Stefan Monnier in
6417 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6418 Remove a FIXME that didn't need fixing.
6419 Simplify the newly-introduced buffer reallocation code.
6420
0cae2cdb
JB
64212011-08-27 Juanma Barranquero <lekktu@gmail.com>
6422
6423 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6424
5fc295a4 64252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6426
70c60eb2 6427 Integer and memory overflow issues (Bug#9196).
726e0ab1 6428
d31850da
PE
6429 * doc.c (get_doc_string): Rework so that
6430 get_doc_string_buffer_size is the actual buffer size, rather than
6431 being 1 less than the actual buffer size; this makes xpalloc more
6432 convenient.
6433
a69fbedb
PE
6434 * image.c (x_allocate_bitmap_record, cache_image):
6435 * xselect.c (Fx_register_dnd_atom):
6436 Simplify previous changes by using xpalloc.
6437
fe5c5d37
PE
6438 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6439 since either will do and ptrdiff_t is convenient with xpalloc.
6440
0065d054
PE
6441 * charset.c (charset_table_size)
6442 (struct charset_sort_data.priority): Now ptrdiff_t.
6443 (charset_compare): Don't overflow if priorities differ greatly.
6444 (Fsort_charsets): Don't assume list length fits in int.
6445 Check for size-calculation overflow when allocating sort data.
6446 (syms_of_charset): Allocate an initial charset table that is
6447 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6448
6449 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6450
6451 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6452 The actual value is always <= INT_MAX, and leaving it unsigned made
6453 overflow checking harder.
6454
6455 * dispextern.h (struct glyph_matrix.rows_allocated)
6456 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6457 with xpalloc. The values are still always <= INT_MAX.
6458
6459 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6460
6461 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6462 (SAFE_NALLOCA): New macro.
6463
6464 * region-cache.c (struct boundary.pos, find_cache_boundary)
6465 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6466 (set_cache_region, invalidate_region_cache)
6467 (revalidate_region_cache, know_region_cache, region_cache_forward)
6468 (region_cache_backward, pp_cache):
6469 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6470 so that ptrdiff_t * can be passed to xpalloc.
6471 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6472 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6473 (pp_cache): Don't assume cache_len fits in int.
6474 * region-cache.h: Adjust extern decls to match.
6475
6476 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6477 EMACS_INT, since either will do, for xpalloc.
6478
6479 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6480 (xnmalloc, xnrealloc, xpalloc): New functions.
6481
726e0ab1
PE
6482 * bidi.c (bidi_shelve_header_size): New constant.
6483 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6484 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6485
51f30bc5 6486 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6487 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6488 (overlay_strings):
6489 Don't update size of array until after memory allocation succeeds,
6490 because xmalloc/xrealloc may not return.
0065d054
PE
6491 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6492 now that we have proper integer overflow checking.
6493 (record_overlay_string, overlay_strings): Catch overflows when
6494 calculating size of overlay_str_buf.
726e0ab1 6495
0065d054
PE
6496 * callproc.c (Fcall_process): Check for size overflow when
6497 calculating size of args2.
6498 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6499 Normally we prefer signed values, but sticking with ptrdiff_t would
6500 require adding more-complicated checks.
726e0ab1
PE
6501
6502 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6503 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6504 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6505 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6506
6507 * character.c (Fstring): Check for size-calculation overflow.
6508
6509 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6510 unnecessary integer overflow. Check for size overflow.
6511 (encode_coding_object): Don't update size until xmalloc succeeds.
6512
6513 * composite.c (get_composition_id): Check for overflow in glyph
6514 length calculations.
6515
6516 Integer and memory overflow fixes for display code.
6517 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6518 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6519 (scrolling_window): Check for overflow in size calculations.
6520 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6521 Don't assume glyph table len fits in int.
6522 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6523 (row_table_size): Now ptrdiff_t, not int.
6524 (scrolling_window): Avoid overflow in size calculations.
6525 Don't update size until allocation succeeds.
6526 * fns.c (concat): Check for overflow in size calculations.
6527 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6528 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6529 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6530
6531 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6532 (get_doc_string): Check for size calculation overflow.
6533 Don't update size until allocation succeeds.
6534 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6535 EMACS_INT, where ptrdiff_t will do.
6536 (Fsubstitute_command_keys): Check for string overflow.
6537
6538 * editfns.c (set_time_zone_rule): Don't assume environment length
6539 fits in int.
6540 (message_length): Now ptrdiff_t, not int.
6541 (Fmessage_box): Don't update size until allocation succeeds.
6542 Don't assume message length fits in int.
6543 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6544
0065d054
PE
6545 * emacs.c (main): Do not reallocate argv, since there is a null at
6546 the end that can be overwritten, and this way there's no need to
6547 worry about size-calculation overflow.
6548 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6549
6550 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6551 alloc succeeds.
6552 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6553
6554 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6555 (x_set_scroll_bar_width, x_figure_window_size):
6556 Check for integer overflow.
6557 (x_set_alpha): Do not assume XINT fits in int.
6558
6559 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6560 This is for the members text_lines, text_cols, total_lines, total_cols,
6561 where the system imposes an 'int' limit.
6562
6563 * fringe.c (Fdefine_fringe_bitmap):
6564 Don't update size until alloc works.
6565
6566 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6567 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6568
6569 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6570 Check for size-calculation overflow.
6571 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6572 do, as we prefer signed integers.
6573 (id_to_widget.max_size, id_to_widget.used)
6574 (xg_store_widget_in_map, xg_remove_widget_from_map)
6575 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6576 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6577 Use and return ptrdiff_t, not int.
6578 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6579 * gtkutil.h: Change prototypes to match the above.
6580
6581 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6582 are duplicate now that they've been promoted to lisp.h.
6583 (x_allocate_bitmap_record, x_alloc_image_color)
6584 (make_image_cache, cache_image, xpm_load):
6585 Don't update size until alloc is done.
6586 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6587 (x_detect_edges):
3256efce 6588 Check for size calculation overflow.
726e0ab1
PE
6589 (ct_colors_allocated_max): New constant.
6590 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6591 overflow.
3256efce 6592
726e0ab1
PE
6593 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6594 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6595 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6596 Use ptrdiff_t, not int, to count maps.
6597 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6598 calculations. Don't update size until allocation succeeds.
6599 Redo calculations to avoid overflow.
726e0ab1
PE
6600 * keyboard.h: Change prototypes to match the above.
6601
6602 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6603 to count maps.
6604 (current_minor_maps): Check for size calculation overflow.
6605 * keymap.h: Change prototypes to match the above.
6606
6607 * lread.c (read1, init_obarray): Don't update size until alloc done.
6608
6609 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6610 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6611
726e0ab1
PE
6612 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6613 Now ptrdiff_t, not int.
6614 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6615 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6616
6617 * process.c (Fnetwork_interface_list): Check for overflow
6618 in size calculation.
6619
6620 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6621
6622 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6623 overflow. Don't bother calling xmalloc when xrealloc will do.
6624
6625 * search.c (Freplace_match): Check for size calculation overflow.
6626 (Fset_match_data): Don't assume list lengths fit in 'int'.
6627
6628 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6629 for command line length. Do not attempt to address one before the
6630 beginning of an array, as that's not portable.
6631
6632 * term.c (max_frame_lines): Remove; unused.
6633 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6634 not int.
6635 (encode_terminal_code, calculate_costs): Check for size
6636 calculation overflow.
6637 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6638 table lengths and related sizes. Don't update size until alloc
6639 done. Redo calculations to avoid overflow.
6640 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6641
6642 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6643 subtracting pointers.
6644 (gobble_line): Check for overflow more carefully. Don't update size
6645 until alloc done.
6646
6647 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6648 Don't update size until alloc done.
6649 Redo size calculations to avoid overflow.
6650 Check for size calculation overflow.
0065d054 6651 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6652
6653 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6654 Use ptrdiff_t, not int, for sizes.
6655 (store_mode_line_noprop_char): Don't update size until alloc done.
6656
0065d054
PE
6657 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6658 Use ptrdiff_t, not int, for sizes.
6659 (Finternal_make_lisp_face, cache_face):
6660 Check for size calculation overflow.
6661 (cache_face): Treat size calculation overflows as if they were
6662 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6663
6664 * xfns.c (x_encode_text, x_set_name_internal)
6665 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6666 sizes, since they can exceed INT_MAX in size. Check for size
6667 calculation overflow.
6668
0065d054
PE
6669 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6670 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6671 Don't update size until alloc done.
6672
0065d054 6673 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6674 as sprintf is limited to int lengths.
1d526e2f 6675
252c5ee1
PE
6676 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6677 (X_LONG_MIN): New macros.
864d7ce7
PE
6678 Use them to make the following changes clearer.
6679 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6680 This change doesn't affect the value now, but it may help remind
6681 future maintainers not to raise the value too much later.
6682 (SELECTION_QUANTUM): Remove, replacing with ...
6683 (selection_quantum): ... new function, which avoids overflow.
6684 All uses changed.
6685 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6686 assumption that selection length fits in 'int'.
6687 (x_reply_selection_request, x_handle_selection_request)
6688 (x_get_window_property, receive_incremental_selection)
6689 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6690 (lisp_data_to_selection_data, clean_local_selection_data):
6691 Use ptrdiff_t, not int, to record length of selection.
6692 (x_reply_selection_request, x_get_window_property)
6693 (receive_incremental_selection, x_property_data_to_lisp):
6694 Redo calculations to avoid overflow.
6695 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6696 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6697 something.
6698 (x_get_window_property, receive_incremental_selection)
6699 (lisp_data_to_selection_data, x_property_data_to_lisp):
6700 Check for size-calculation overflow.
6701 (x_get_window_property, receive_incremental_selection)
6702 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6703 Don't store size until memory allocation succeeds.
6704 (x_get_window_property): Plug memory leak on memory exhaustion.
6705 Don't double-block input; malloc is safe here. Don't assume 2**34
6706 - 4 fits in unsigned long. Add an xassert to check
6707 XGetWindowProperty overflow. Be more careful about overflow
6708 calculations, and distinguish size from memory overflow better.
6709 (receive_incremental_selection): When tracing, don't assume
6710 unsigned int is less than INT_MAX.
6711 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6712 harmful) conversions of unsigned short to int.
6713 (lisp_data_to_selection_data): Don't assume that integers
6714 in the range -65535 through -1 fit in an X unsigned short.
6715 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6716 result parameters unless successful. Rely on cons_to_unsigned
6717 to report problems with elements; the old code wasn't right anyway.
6718 (x_check_property_data): Check for int overflow; we cannot use
6719 a wider type due to X limits.
6720 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6721
726e0ab1 6722 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6723
0065d054
PE
6724 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6725 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6726 (x_color_cells): Don't store size until memory allocation succeeds.
6727 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6728 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6729 (x_term_init): Don't assume length fits in int (sprintf is limited
6730 to int size).
bc18e09d 6731
ebfa62c0
PE
6732 Use ptrdiff_t for composition IDs.
6733 * character.c (lisp_string_width):
6734 * composite.c (composition_table_size, n_compositions)
6735 (get_composition_id, composition_gstring_from_id):
6736 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6737 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6738 * window.c (Frecenter):
6739 Use ptrdiff_t, not int, for composition IDs.
6740 * composite.c (get_composition_id): Check for integer overflow.
6741 * composite.h: Adjust prototypes to match the above changes.
6742
d3411f89
PE
6743 Use ptrdiff_t for hash table indexes.
6744 * category.c (hash_get_category_set):
6745 * ccl.c (ccl_driver):
6746 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6747 * coding.c (coding_system_charset_list, detect_coding_system):
6748 * coding.h (struct coding_system.id):
6749 * composite.c (get_composition_id, gstring_lookup_cache):
6750 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6751 * image.c (xpm_get_color_table_h):
6752 * lisp.h (hash_lookup, hash_put):
6753 * minibuf.c (Ftest_completion):
6754 Use ptrdiff_t for hash table indexes, not int (which is too
6755 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6756 32-bit --with-wide-int hosts).
6757
e097a6fa
PE
6758 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6759 Add a FIXME comment about memory leaks.
6760 (syms_of_charset): Don't assume xmalloc returns.
6761
5637687f
PE
6762 Don't assume that stated character widths fit in int.
6763 * character.c (Fchar_width, c_string_width, lisp_string_width):
6764 * character.h (CHAR_WIDTH):
6765 * indent.c (MULTIBYTE_BYTES_WIDTH):
6766 Use sanitize_char_width to avoid undefined and/or bad behavior
6767 with outlandish widths.
a66cfb1c 6768 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6769 now that we have two such functions. All uses changed.
6770 (sanitize_char_width): New inline function.
6771
a2271ba2
PE
6772 Don't assume that tab-width fits in int.
6773 * character.h (sanitize_width): New inline function.
6774 (SANE_TAB_WIDTH): New macro.
6775 (ASCII_CHAR_WIDTH): Use it.
6776 * indent.c (sane_tab_width): Remove. All uses replaced by
6777 SANE_TAB_WIDTH (current_buffer).
6778 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6779
18c52557
PE
6780 * fileio.c: Integer overflow issues with file modes.
6781 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6782
caeeedc1
PE
6783 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6784 Remove unreachable code.
6785 (read_hex, load_charset_map_from_file): Check for integer overflow.
6786
6df6ae42 6787 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6788 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6789 (x_send_scroll_bar_event): Likewise. Check that the size does not
6790 exceed limits imposed by XClientMessageEvent, as well as the usual
6791 ptrdiff_t and size_t limits.
6792
b13995db
PE
6793 * keyboard.c: Overflow, signedness and related fixes.
6794 (make_lispy_movement): Use same integer type in forward decl
6795 that is used in the definition.
6796 (read_key_sequence, keyremap_step):
6797 Change bufsize argument back to int, undoing my 2011-03-30 change.
6798 We prefer signed types, and int is wide enough here.
6799 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6800 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6801 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6802 length, not size_t. Use ptrdiff_t for index, not int.
6803 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6804 possibility of integer overflow.
6805
13464394
PE
6806 Overflow, signedness and related fixes for images.
6807
6808 * dispextern.h (struct it.stack[0].u.image.image_id)
6809 (struct_it.image_id, struct image.id, struct image_cache.size)
6810 (struct image_cache.used, struct image_cache.ref_count):
6811 * gtkutil.c (update_frame_tool_bar):
6812 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6813 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6814 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6815 * nsmenu.m (update_frame_tool_bar):
6816 * xdisp.c (calc_pixel_width_or_height):
6817 * xfns.c (image_cache_refcount):
6818 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6819 on typical 64-bit hosts.
6820
6821 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6822 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6823 Omit unnecessary casts to int.
6824 (parse_image_spec): Check that integers fall into 'int' range
6825 when the callers expect that.
6826 (image_ascent): Redo ascent calculation to avoid int overflow.
6827 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6828 (lookup_image): Remove unnecessary tests.
6829 (xbm_image_p): Locals are now of int, not EMACS_INT,
6830 since parse_image_check makes sure they fit into int.
6831 (png_load, gif_load, svg_load_image):
6832 Prefer int to unsigned where either will do.
6833 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6834 old tiff_error_handler and tiff_warning_handler.
6835 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6836 stack buffer overflows. It uses only the features of vsnprintf
6837 that are common to both POSIX and native Microsoft.
6838 (tiff_error_handler, tiff_warning_handler): Use it.
6839 (tiff_load, gif_load, imagemagick_load_image):
6840 Don't assume :index value fits in 'int'.
6841 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6842 (imagemagick_load_image): Check that crop parameters fit into
6843 the integer types that MagickCropImage accepts. Don't assume
6844 Vimagemagick_render_type has a nonnegative value. Don't assume
6845 size_t fits in 'long'.
6846 (gs_load): Use printmax_t to print the widest integers possible.
6847 Check for integer overflow when computing image height and width.
6848
c11821d4
EZ
68492011-08-26 Eli Zaretskii <eliz@gnu.org>
6850
6851 * xdisp.c (redisplay_window): Don't force window start if point
6852 will be invisible in the resulting window. (Bug#9324)
6853
0c95fcf7
EZ
68542011-08-25 Eli Zaretskii <eliz@gnu.org>
6855
6856 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6857 the display spec is of the form `(space ...)'.
6858 (handle_display_spec): Return the value returned by
6859 handle_single_display_spec, not just 1 or zero.
6860 (handle_single_display_spec): If the display spec is of the form
6861 `(space ...)', and specifies display in the text area, return 2
6862 rather than 1.
fee65a97 6863 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6864 accurately, and prefer exact match for point under bidi.
6865 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6866
6867 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6868 into disp_prop; all users changed.
6869
6870 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6871 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6872 for the text covered by the display property.
6873
e4ed06f1
CY
68742011-08-25 Chong Yidong <cyd@stupidchicken.com>
6875
6876 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6877 Change return value to nil.
6878 (Frecord_buffer): Delete unused function.
6879
f67cdd7f
EZ
68802011-08-24 Eli Zaretskii <eliz@gnu.org>
6881
5980d4c6
EZ
6882 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6883 buffers, return left-to-right.
8610fe8b
EZ
6884 (set_cursor_from_row): Consider candidate row a win if its glyph
6885 represents a newline and point is on that newline. Fixes cursor
6886 positioning on the newline at EOL of R2L text within L2R
6887 paragraph, and vice versa.
6888 (try_cursor_movement): Check continued rows, in addition to
6889 continuation rows. Fixes unwarranted scroll when point enters a
6890 continued line of R2L text within an L2R paragraph, or vice versa.
6891 (cursor_row_p): Consider the case of point being equal to
6892 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6893 from the end of a short line to the beginning of a continued line
6894 of R2L text within L2R paragraph.
6895 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6896 composed characters.
5980d4c6 6897
f67cdd7f
EZ
6898 * bidi.c (bidi_check_type): Use xassert.
6899 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6900 members.
6901
bca633fb
EZ
69022011-08-23 Eli Zaretskii <eliz@gnu.org>
6903
6904 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6905 a character.
6906
4a5885a7
CY
69072011-08-23 Chong Yidong <cyd@stupidchicken.com>
6908
6909 * nsfont.m (ns_otf_to_script): Fix typo.
6910
0902a04e
KH
69112011-08-22 Kenichi Handa <handa@m17n.org>
6912
6913 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6914 extra slot even if the purpose is char-code-property-table.
6915
1a2e6670
EZ
69162011-08-23 Eli Zaretskii <eliz@gnu.org>
6917
8ddde651
EZ
6918 * xdisp.c (redisplay_window): When computing centering_position,
6919 account for the height of the header line. (Bug#8874)
6920
425cc014
EZ
6921 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6922 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6923 candidate is selected by the mouse, and that candidate has a
6924 composed character under the mouse.
6925
1a2e6670
EZ
6926 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6927 coordinates reported by pos-visible-in-window-p for a composed
6928 character in column zero.
6929
8b76d6f8
SM
69302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6931
6932 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6933
dac347dd
EZ
69342011-08-22 Eli Zaretskii <eliz@gnu.org>
6935
6936 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6937 consider it a hit if to_charpos is anywhere in the range of the
6938 composed buffer positions.
6939
e013fb34
CY
69402011-08-22 Chong Yidong <cyd@stupidchicken.com>
6941
6942 * image.c (gif_load): Don't assume that each subimage has the same
6943 dimensions as the base image. Handle disposal method that is
6944 "undefined" by the gif spec (Bug#9335).
6945
bd1ba3e8
CY
69462011-08-20 Chong Yidong <cyd@stupidchicken.com>
6947
6948 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6949 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6950
54a1215b
EZ
69512011-08-19 Eli Zaretskii <eliz@gnu.org>
6952
823564e5
EZ
6953 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6954 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6955 from an Org mode buffer to a Speedbar frame.
6956
54a1215b
EZ
6957 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6958 a composition, take its buffer position from IT->cmp_it.charpos.
6959 Fixes cursor positioning at the beginning of a line that begins
6960 with a composed character.
6961
9778ebcc
EZ
69622011-08-18 Eli Zaretskii <eliz@gnu.org>
6963
0be6ee06
EZ
6964 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6965 character bidirectional type, use STRONG_L instead. Fixes crashes
6966 in a buffer produced by `describe-categories'.
6967
9778ebcc
EZ
6968 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6969 members before the level stack, so they would be saved and
6970 restored when copying iterator state. Fixes incorrect reordering
6971 around TABs covered by display properties.
6972
156bffbe
AS
69732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6974
6b02f655 6975 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6976
72ad093b
CY
69772011-08-17 Chong Yidong <cyd@stupidchicken.com>
6978
6979 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6980 (internal_condition_case_2, internal_condition_case_n):
6981 Remove unnecessary aborts (Bug#9081).
72ad093b 6982
35774242
EZ
69832011-08-17 Eli Zaretskii <eliz@gnu.org>
6984
6985 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6986 has no `load' handler, try opening the file locally. (Bug#9311)
6987
db76dd85
KB
69882011-08-16 Ken Brown <kbrown@cornell.edu>
6989
6990 * gmalloc.c: Expand comment.
6991
b215eee5
EZ
69922011-08-16 Eli Zaretskii <eliz@gnu.org>
6993
6994 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6995 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6996
a4579d33
KB
69972011-08-16 Ken Brown <kbrown@cornell.edu>
6998
6999 Fix memory allocation problems in Cygwin build (Bug#9273).
7000
7001 * unexcw.c ( __malloc_initialized): Declare external variable.
7002 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7003
8b76d6f8
SM
7004 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7005 New variables.
a4579d33
KB
7006 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7007 dumped emacs.
7008 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7009 in the static heap.
7010 [CYGWIN] (special_realloc): New function.
7011 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7012 requests to realloc storage in the static heap.
7013
3ebec551
PE
70142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7015
7016 * bidi.c (bidi_initialize): Remove unused local.
7017
9fd8be00
EZ
70182011-08-15 Eli Zaretskii <eliz@gnu.org>
7019
6b02f655
SM
7020 * bidimirror.h:
7021 * biditype.h: Remove file.
7022 * makefile.w32-in ($(BLD)/bidi.$(O)):
7023 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7024
7025 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7026
7027 * chartab.c: Improve commentary for the uniprop_table API.
7028
32413314
EZ
7029 * bidi.c (bidi_paragraph_init): Support zero value of
7030 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7031 (bidi_initialize): Use uniprop_table instead of including
7032 biditype.h and bidimirror.h.
32413314 7033
9fd8be00
EZ
7034 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7035 coordinates of the iterator when restoring from ppos_it.
7036 (Bug#9296)
7037
5cf2b69b
KH
70382011-08-14 Kenichi Handa <handa@m17n.org>
7039
7040 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7041 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7042
daf17d00
EZ
70432011-08-14 Eli Zaretskii <eliz@gnu.org>
7044
7045 * xdisp.c (move_it_in_display_line_to): Don't invoke
7046 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7047 ppos_it. Fixes vertical cursor motion when line beginning is
7048 covered by an image. (Bug#9296)
7049
08e3161a
JD
70502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7051
7052 * nsterm.h (ns_run_ascript): Declare.
7053 (NSAPP_DATA2_RUNASSCRIPT): Define.
7054
7055 * nsfns.m (as_script, as_result, as_status): New static variables.
7056 (ns_run_ascript): New function.
5e617bc2 7057 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7058 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7059 the event loop. Get status from as_status (Bug#7276).
7060
7061 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7062 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7063 the event loop (Bug#7276).
7064
a3720aa2
AS
70652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7066
7067 * gnutls.c (QCgnutls_bootprop_priority)
7068 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7069 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7070 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7071 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7072 (QCgnutls_bootprop_verify_hostname_error)
7073 (QCgnutls_bootprop_callbacks_verify): Rename from
7074 Qgnutls_bootprop_..., all uses changed.
7075
7076 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7077 uses changed.
7078
0a0d27fb
PE
70792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7080
19d5c50c
PE
7081 * xfaces.c (Qframe_set_background_mode): Now static.
7082 * dispextern.h (Qframe_set_background_mode): Remove decl.
7083
0a0d27fb
PE
7084 * process.c (Fnetwork_interface_info): Declare local only if needed.
7085
377538cb
JD
70862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7087
7088 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7089 (Fnetwork_interface_list): Allocate in increments of bytes instead
7090 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7091 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7092 sockaddr.
7093 (struct ifflag_def): notrailers is smart on OSX.
7094 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7095 Get hardware address with getifaddrs if available.
7096
08fff70c
EZ
70972011-08-12 Eli Zaretskii <eliz@gnu.org>
7098
7099 * xdisp.c (iterate_out_of_display_property): xassert that
7100 IT->position is set to within IT->object's boundaries. Break from
7101 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7102 when IT->position is set up wrongly due to some bug.
7103 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7104 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7105 entry. Force push_it to save on the stack the current
7106 buffer/string position, to be restored by pop_it. Fix flags in
7107 the iterator structure wrt the object coming from a display
7108 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7109 properties. (Bug#9284)
7110
7be1c708 71112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7112
7be1c708
CY
7113 * fontset.c (fontset_get_font_group): Add proper type checks.
7114 (Bug#9172)
aac0c6e3 7115
7be1c708 71162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7117
7be1c708
CY
7118 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7119 and LC_VERSION_MIN_MACOSX.
7120 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7121 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7122
97bb72a6
EZ
71232011-08-08 Eli Zaretskii <eliz@gnu.org>
7124
7125 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7126 no-display-properties-and-no-overlays under bidi display.
7127 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7128 properties and overlays.
97bb72a6 7129
d5617611
CY
71302011-08-08 Chong Yidong <cyd@stupidchicken.com>
7131
37e11a63
CY
7132 * editfns.c (Fset_time_zone_rule): Document relationship with the
7133 setenv function.
7134
d5617611
CY
7135 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7136 the font entity extracted from the cache (Bug#8109).
7137
58872834
CY
71382011-08-07 Chong Yidong <cyd@stupidchicken.com>
7139
7140 * composite.c (autocmp_chars): Don't reset point. That is done by
7141 restore_point_unwind (Bug#5984).
7142
75bfc667
JL
71432011-08-07 Juri Linkov <juri@jurta.org>
7144
7145 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7146 to show the arg `TIME' instead of `TIMEVAL'.
7147
d1410150
EZ
71482011-08-06 Eli Zaretskii <eliz@gnu.org>
7149
7150 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7151 display property strides EOL and includes a newline, as in
7152 longlines-mode. (Bug#9254)
75b771e4
EZ
7153 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7154 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7155
7156 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7157 is non-zero, even if the data buffer is NULL. Fixes a crash in
7158 vertical-motion with longlines-mode. (Bug#9254)
7159
35928349
EZ
71602011-08-05 Eli Zaretskii <eliz@gnu.org>
7161
ec7cc85b
EZ
7162 * bidi.c <bidi_cache_total_alloc>: Now static.
7163 (bidi_initialize): Initialize bidi_cache_total_alloc.
7164
8b76d6f8 7165 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7166 cache. (Bug#9221)
7167
7168 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7169 amount allocated this far in `bidi_cache_total_alloc'.
7170 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7171 non-zero, only free the data buffer without restoring the cache
7172 contents. All callers changed.
7173
7174 * dispextern.h (bidi_unshelve_cache): Update prototype.
7175
7176 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7177 (move_it_in_display_line, move_it_to)
7178 (move_it_vertically_backward, move_it_by_lines): Replace the call
7179 to xfree to an equivalent call to bidi_unshelve_cache.
7180 (move_it_in_display_line_to): Fix logic of returning
412b6358 7181 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7182
e2e2423b
EZ
71832011-08-05 Eli Zaretskii <eliz@gnu.org>
7184
7185 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7186 came from a string character with a `cursor' property. (Bug#9229)
7187
ae9e757a
JD
71882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7189
7190 * Makefile.in (LIB_PTHREAD): New variable.
7191 (LIBES): Add LIB_PTHREAD (Bug#9216).
7192
7193 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7194 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7195
213bd7f2
AS
71962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7197
6b02f655 7198 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7199
99aaf75f
JD
72002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7201
7202 * xterm.c (x_find_topmost_parent): New function.
7203 (x_set_frame_alpha): Find topmost parent window with
7204 x_find_topmost_parent and set the property there also (bug#9181).
7205 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7206
c74e9d86
PE
72072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7208
7209 * callproc.c (Fcall_process): Avoid vfork clobbering
7210 the local vars buffer, coding_systems, current_dir.
7211
640c8776
SM
72122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7213
7214 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7215
f26d0e4c
PE
72162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7217
8a10d76c
PE
7218 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7219 so that it is not optimized away.
7220
f26d0e4c
PE
7221 * xdisp.c (compute_display_string_pos): Remove unused local.
7222
55439c61
EZ
72232011-08-02 Eli Zaretskii <eliz@gnu.org>
7224
7225 Fix slow cursor motion and scrolling in large buffers with
7226 selective display, like Org Mode buffers. (Bug#9218)
7227
7228 * dispextern.h (struct bidi_it): New member disp_prop_p.
7229
7230 * xdisp.c: Remove one-slot cache of display string positions.
7231 (compute_display_string_pos): Accept an additional argument
5e617bc2 7232 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7233 for a display string or property. If found, set DISP_PROP_P
7234 non-zero.
7235
7236 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7237 DISP_PROP_P, and pass it to compute_display_string_pos.
7238 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7239 non-zero. All callers of bidi_fetch_char changed.
7240
fb33fa43
SM
72412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7242
7243 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7244
b099e063
DM
72452010-12-03 Don March <don@ohspite.net>
7246
7247 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7248 last character M-[char] is translated to ESC [char] (bug#7541).
7249
5cc7f7af
KH
72502011-08-02 Kenichi Handa <handa@m17n.org>
7251
d0fffa3f 7252 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7253
7254 * chartab.c (uniprop_table): Make it non-static.
7255
525d5e6e
EZ
72562011-08-01 Eli Zaretskii <eliz@gnu.org>
7257
7258 * xdisp.c (forward_to_next_line_start): Accept additional argument
7259 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7260 on the newline.
7261 (reseat_at_next_visible_line_start): Use the bidi iterator state
7262 returned by forward_to_next_line_start to restore the state of
7263 it->bidi_it after backing up to previous newline. (Bug#9212)
7264
31011111
AS
72652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7266
7267 * regex.c (re_comp): Protoize.
7268 (re_exec): Fix return type.
7269 (regexec): Fix type of `ret'. (Bug#9203)
7270
476371c4
PE
72712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7272
e5d76069
PE
7273 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7274 This is needed if max-image-size is a floating-point number.
7275
9a79b20c
AS
72762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7277
7278 * print.c (print_object): Print empty symbol as ##.
7279
7280 * lread.c (read1): Read ## as empty symbol.
7281
d8c2fa78
AA
72822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7283
7284 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7285 setting frame foreground color (Bug#9175).
7286 (x_set_background_color): Likewise.
7287
ffe57a7a
AA
7288 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7289 contents (Bug#9176).
7290 (EmacsTooltip -init): Remove bezels and add shadows to
7291 tooltip windows.
7292
bf3492a5
AA
7293 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7294 or scroll bar (Bug#8470).
7295
d55e9c53
AA
7296 * nsfont.m (nsfont_open): Remove assignment to voffset and
7297 unnecessary vars hshink, expand, hd, full_height, min_height.
7298 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7299
7300 * nsterm.h (nsfont_info): Remove voffset field.
7301
d8c2fa78 73022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7303
7304 Implement strike-through and overline on NextStep (Bug#8863).
7305
7306 * nsfont.m (nsfont_open): Use underline position provided by font,
7307 instead of hard-coded value of 2.
7308 (nsfont_draw): Call ns_draw_text_decoration instead.
7309
7310 * nsterm.h: Add declaration for ns_draw_text_decoration.
7311
7312 * nsterm.m (ns_draw_text_decoration): New function for drawing
7313 underline, overline, and strike-through.
7314 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7315 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7316 accommodate underlining, etc.
4843aac3 7317
4cc60b9b
EZ
73182011-07-28 Eli Zaretskii <eliz@gnu.org>
7319
bc7ece87
EZ
7320 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7321 default.
4cc60b9b 7322
476371c4
PE
73232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7324
66606eea
PE
7325 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7326 Without this fix, if a signal arrives just after memory fills up,
7327 'malloc' might be invoked reentrantly.
7328
476371c4
PE
7329 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7330 In other words, assume that every image size is allowed, on non-X
7331 hosts. This assumption is probably wrong, but it lets Emacs compile.
7332
f3fcc40d
AS
73332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7334
7335 * regex.c (re_iswctype): Convert return values to boolean.
7336
350c992f
EZ
73372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7338
7339 * xdisp.c (compute_display_string_pos): Don't use cached display
7340 string position if the buffer had its restriction changed.
7341 (Bug#9184)
7342
5266b4bb
PE
73432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7344
7345 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7346
2573a837 73472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7348
41f55ccd 7349 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7350
39e378da
PE
7351 * bidi.c: Integer size and overflow fixes.
7352 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7353 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7354 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7355 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7356 (bidi_find_other_level_edge):
7357 Use ptrdiff_t instead of EMACS_INT where either will do.
7358 This works better on 32-bit hosts configured --with-wide-int.
7359 (bidi_cache_ensure_space): Check for size-calculation overflow.
7360 Use % rather than repeated addition, for better worst-case speed.
7361 Don't set bidi_cache_size until after xrealloc returns, because it
7362 might not return.
7363 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7364 (bidi_cache_ensure_space): Also check that the bidi cache size
7365 does not exceed that of the largest Lisp string or buffer. See Eli
7366 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7367
5e927815
PE
7368 * alloc.c (__malloc_size_t): Remove.
7369 All uses replaced by size_t. See Andreas Schwab's note
7370 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7371
ca4aa935
PE
7372 * image.c: Improve checking for integer overflow.
7373 (check_image_size): Assume that f is nonnull, since
7374 it is always nonnull in practice. This is one less thing to
7375 worry about when checking for integer overflow later.
7376 (x_check_image_size): New function, which checks for integer
7377 overflow issues inside X.
7378 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7379 This removes the need for a memory_full check.
7380 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7381 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7382 (xbm_read_bitmap_data): Change locals back to 'int', since
7383 their values must fit in 'int'.
7384 (xpm_load_image, png_load, tiff_load):
7385 Invoke x_create_x_image_and_pixmap earlier,
7386 to avoid much needless work if the image is too large.
7387 (tiff_load): Treat overly large images as if
7388 x_create_x_image_and_pixmap failed, not as malloc failures.
7389 (gs_load): Use x_check_image_size.
7390
5f8f9cc2
PE
7391 * gtkutil.c: Omit integer casts.
7392 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7393 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7394
5adf60bc
PE
7395 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7396
c8907a93
PE
7397 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7398 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7399 would wrongly return t on a 64-bit host.
7400
e3c25c68
PE
7401 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7402 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7403 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7404 and therefore cause GCC to emit a bogus diagnostic in some cases.
7405
3f791afe
PE
7406 * image.c: Integer signedness and overflow and related fixes.
7407 This is not an exhaustive set of fixes, but it's time to
7408 record what I've got.
7409 (lookup_pixel_color, check_image_size): Remove redundant decls.
7410 (check_image_size): Don't assume that arbitrary EMACS_INT values
7411 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7412 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7413 (tiff_load, imagemagick_load_image):
7414 Check for overflow in size calculations.
7415 (x_create_x_image_and_pixmap): Remove unnecessary test for
7416 xmalloc returning NULL; that can't happen.
7417 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7418 (xpm_color_bucket): Use better integer hashing function.
7419 (xpm_cache_color): Don't possibly over-allocate memory.
7420 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7421 (gif_memory_source):
7422 Use ptrdiff_t, not int or size_t, to record sizes.
7423 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7424 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7425 either works, as we prefer signed integers.
7426 (tiff_read_from_memory, tiff_write_from_memory):
7427 Return tsize_t, not size_t, since that's what the TIFF API wants.
7428 (tiff_read_from_memory): Don't fail simply because the read would
7429 go past EOF; instead, return a short read.
7430 (tiff_load): Omit no-longer-needed casts.
7431 (Fimagemagick_types): Don't assume size fits into 'int'.
7432
3cc5a532
PE
7433 Improve hashing quality when configured --with-wide-int.
7434 * fns.c (hash_string): New function, taken from sxhash_string.
7435 Do not discard information about ASCII character case; this
7436 discarding is no longer needed.
7437 (sxhash-string): Use it. Change sig to match it. Caller changed.
7438 * lisp.h: Declare it.
7439 * lread.c (hash_string): Remove, since we now use fns.c's version.
7440 The fns.c version returns a wider integer if --with-wide-int is
7441 specified, so this should help the quality of the hashing a bit.
7442
b312a492
PE
7443 * emacs.c: Integer overflow minor fix.
7444 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7445 Define only if GNU_LINUX.
7446 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7447
dfd153ae
PE
7448 * dispnew.c: Integer signedness and overflow fixes.
7449 Remove unnecessary forward decls, that were a maintenance hassle.
7450 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7451 All uses changed.
7452 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7453 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7454 (prepare_desired_row, line_draw_cost):
7455 Use int, not unsigned, where either works.
7456 (save_current_matrix, restore_current_matrix):
7457 Use ptrdiff_t, not size_t, where either works.
7458 (init_display): Check for overflow more accurately, and without
7459 relying on undefined behavior.
7460
a81d11a3
PE
7461 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7462 Remove, replacing with the new symbols in lisp.h. All uses changed.
7463 * fileio.c (make_temp_name):
7464 * filelock.c (lock_file_1, lock_file):
7465 * xdisp.c (message_dolog):
7466 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7467 Use pMd etc. instead.
7468 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7469 replacing the pWIDE etc. symbols removed from editfns.c.
7470
3300e6fd
PE
7471 * keyboard.h (num_input_events): Now uintmax_t.
7472 This is (very slightly) less likely to mess up due to wraparound.
7473 All uses changed.
7474
fd05c7e9
PE
7475 * buffer.c: Integer signedness fixes.
7476 (alloc_buffer_text, enlarge_buffer_text):
7477 Use ptrdiff_t rather than size_t when either will do, as we prefer
7478 signed integers.
7479
903fe15d
PE
7480 * alloc.c: Integer signedness and overflow fixes.
7481 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7482 (__malloc_size_t): Default to size_t, not to int.
7483 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7484 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7485 Prefer ptrdiff_t to size_t when either would do, as we prefer
7486 signed integers.
7487 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7488 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7489 Now const. Initialize with values that are in range even if char
7490 is signed.
7491 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7492 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7493 These functions do the right thing with sizes > 2**32.
7494 (check_depth): Now ptrdiff_t, not int.
7495 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7496 Adjust to new way of storing sizes. Check for size overflow bugs
7497 in rest of code.
7498 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7499 slightly wrong anyway, as it missed one instance of
7500 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7501 (refill_memory_reserve): Omit needless cast to size_t.
7502 (mark_object_loop_halt): Mark as externally visible.
7503
ac82cc6a
PE
7504 * xselect.c: Integer signedness and overflow fixes.
7505 (Fx_register_dnd_atom, x_handle_dnd_message):
7506 Use ptrdiff_t, not size_t, since we prefer signed.
7507 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7508 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7509 x_dnd_atoms_size and x_dnd_atoms_length.
7510
c2d1e36d
PE
7511 * doprnt.c: Prefer signed to unsigned when either works.
7512 * eval.c (verror):
7513 * doprnt.c (doprnt):
7514 * lisp.h (doprnt):
7515 * xdisp.c (vmessage):
7516 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7517 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7518 prefer signed arithmetic to avoid comparison confusion.
7519 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7520 but is a bit tricky.
7521
0e926e56
PE
7522 Assume freestanding C89 headers, string.h, stdlib.h.
7523 * data.c, doprnt.c, floatfns.c, print.c:
7524 Include float.h unconditionally.
7525 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7526 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7527 * regex.c: Likewise for stddef.h, string.h.
7528 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7529 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7530 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7531 (STDC_HEADERS): Remove obsolete defines.
7532 * sysdep.c: Include limits.h unconditionally.
7533
9cfdb3ec
PE
7534 Assume support for memcmp, memcpy, memmove, memset.
7535 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7536 * regex.c (memcmp, memcpy):
7537 Remove; we assume C89 now.
7538
7539 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7540 (__malloc_safe_bcopy): Remove; no longer needed.
7541
cf950e6b 7542 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7543 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7544 well either way, and we prefer signed to unsigned.
7545
dbf38e02
LMI
75462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7547
7548 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7549 closes the connection while we're reading (bug#9182).
7550
d6f0886c 75512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7552
d6f0886c
JD
7553 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7554 are specified (Bug#9168).
24e0f6b1 7555
2eb1f9e6
PE
75562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7557
7558 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7559 Found by GCC static checking and --with-wide-int on a 32-bit host.
7560
22381272 75612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7562
7563 * xdisp.c (compute_display_string_pos): Fix logic of caching
7564 previous display string position. Initialize cached_prev_pos to
7565 -1. Fixes slow-down at the beginning of a buffer.
7566
f25e39b4
EZ
75672011-07-24 Eli Zaretskii <eliz@gnu.org>
7568
7569 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7570 for attrs[LFACE_FONTSET_INDEX].
7571
04c4b52e
PE
75722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7573
7574 * xml.c (parse_region): Remove unused local
7575 that was recently introduced.
7576
c1734fbd
EZ
75772011-07-23 Eli Zaretskii <eliz@gnu.org>
7578
be18c5a5
EZ
7579 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7580 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7581
c1734fbd
EZ
7582 * xdisp.c (move_it_in_display_line_to): Record the best matching
7583 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7584 exit if none of the characters scanned was an exact match.
7585 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7586 when exact match is impossible due to invisible text, and the
7587 lines are truncated.
7588
a258d627
JD
75892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7590
7591 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7592 for OSX >= 10.7.
7593
b6d5a689
EZ
75942011-07-22 Eli Zaretskii <eliz@gnu.org>
7595
0f74f785
EZ
7596 Fix a significant slow-down of cursor motion with C-n, C-p,
7597 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7598 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7599 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7600 (next_element_from_buffer): Call compute_stop_pos_backwards to
7601 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7602 base_level_stop.
7603 (reseat): Don't look for prev_stop, as that could mean a very long
7604 run.
7605 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7606 <cached_disp_overlay_modiff>: Cache for last found display string
7607 position.
551918c1 7608 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7609 about the same buffer in the same area of character positions, and
7610 the buffer wasn't changed since the time the display string
7611 position was cached.
551918c1 7612
b2d0c91a
EZ
76132011-07-22 Eli Zaretskii <eliz@gnu.org>
7614
7615 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7616 is an integer, which is important for empty lines. (Bug#9149)
7617
043604ee
CY
76182011-07-22 Chong Yidong <cyd@stupidchicken.com>
7619
7620 * frame.c (Fmodify_frame_parameters): In tty case, update the
7621 default face if necessary (Bug#4238).
7622
da4adb04
CY
76232011-07-21 Chong Yidong <cyd@stupidchicken.com>
7624
7625 * editfns.c (Fstring_to_char): No need to explain what a character
7626 is in the docstring (Bug#6576).
7627
9abd0532
LMI
76282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7629
7630 * xml.c (parse_region): Make sure we always return a tree.
7631
36881d16
HK
76322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7633
7634 * xml.c (parse_region): If a document contains only comments,
7635 return that, too.
7636
1e98674d
LMI
76372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7638
7639 * xml.c (make_dom): Return comments, too.
7640
590bd467
PE
76412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7642
7643 Port to OpenBSD.
7644 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7645 and the surrounding thread.
7646 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7647 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7648 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7649 timer goes off.
7650 * s/openbsd.h (BROKEN_SIGIO): Define.
7651 * unexelf.c (unexec) [__OpenBSD__]:
7652 Don't update the .mdebug section of the Alpha COFF symbol table.
7653
f41628b2
LMI
76542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7655
7656 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7657 (bug#8460).
7658
b59b67c5
PE
76592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7660
15e3a074
PE
7661 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7662 This fixes some race conditions on the permissions of any newly
7663 created file.
7664
41bed37d
PE
7665 * alloc.c (valid_pointer_p): Use pipe, not open.
7666 This fixes some permissions issues when debugging.
7667
b59b67c5
PE
7668 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7669 If fchown fails to set both uid and gid, try to set just gid,
7670 as that is sometimes allowed. Adjust the file's mode to eliminate
7671 setuid or setgid bits that are inappropriate if fchown fails.
7672
925a6be7
SM
76732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7674
7675 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7676 to compare Lisp_Objects.
7677 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7678 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7679 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7680
52968808
AS
76812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7682
0a6a104b
AS
7683 * lread.c (read_integer): Unread even EOF character.
7684 (read1): Likewise. Properly record start position of symbol.
7685
52968808
AS
7686 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7687 symbol character follows.
7688
9e381cdd
PE
76892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7692 This works around a problem with the previous change to Fcopy_file.
7693 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7694 and without this change, GCC might complain about discarding
7695 fchown's return value.
7696
b5641435
JB
76972011-07-16 Juanma Barranquero <lekktu@gmail.com>
7698
7699 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7700
a8031457
PE
77012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7702
7703 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7704
dd889327
LMI
77052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7706
750c33f7
LMI
7707 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7708 it's used from the C level.
7709
dd889327
LMI
7710 * process.c: Use the same condition for POLL_FOR_INPUT in both
7711 keyboard.c and process.c (bug#1858).
7712
87e86684
LM
77132011-07-09 Lawrence Mitchell <wence@gmx.li>
7714
7715 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7716 (Fgnutls_boot): Use it.
7717
64348f40
AS
77182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7719
7720 * doc.c (Fsubstitute_command_keys): Revert last change.
7721
1d698799
LMI
77222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7723
f863868c
LMI
7724 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7725 quotes the next character, and doesn't affect other longer
7726 sequences (bug#8935).
7727
1d698799
LMI
7728 * lread.c (syms_of_lread): Clarify that is isn't only
7729 `eval-buffer' and `eval-defun' that's affected by
7730 `lexical-binding' (bug#8460).
7731
aa4b6df6
EZ
77322011-07-15 Eli Zaretskii <eliz@gnu.org>
7733
7734 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7735 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7736
5d856da6
PE
77372011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7738
ad6042bb
PE
7739 Fix minor problems found by static checking.
7740 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7741 (elsz): Now a signed constant, not a size_t var. We prefer signed
7742 types to unsigned, to avoid integer comparison confusion. Without
7743 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7744 "cannot optimize loop, the loop counter may overflow", a symptom
7745 of the confusion.
f00bbb22 7746 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7747 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7748
6468f31c
LMI
77492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7750
49080b10
LMI
7751 * search.c (Fre_search_backward): Mention `case-fold-search' in
7752 all the re_search_* functions (bug#8138).
7753
6468f31c
LMI
7754 * keyboard.c (Fopen_dribble_file): Document when the file is
7755 closed (bug#8056).
7756
c965adc5
EZ
77572011-07-14 Eli Zaretskii <eliz@gnu.org>
7758
df9733bf
EZ
7759 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7760 bidi_cache_idx.
7761
0bb23927
EZ
7762 Support bidi reordering of display and overlay strings.
7763 * xdisp.c (compute_display_string_pos)
7764 (compute_display_string_end): Accept additional argument STRING.
7765 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7766 (reseat_to_string): Initialize bidi_it->string.s and
7767 bidi_it->string.schars.
7768 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7769 NULL (avoids a crash in bidi_paragraph_init).
7770 Initialize itb.string.lstring.
0bb23927
EZ
7771 (init_iterator): Call bidi_init_it only of a valid
7772 buffer position was specified. Initialize paragraph_embedding to
7773 L2R.
7774 (reseat_to_string): Initialize the bidi iterator.
7775 (display_string): If we need to ignore text properties of
7776 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7777 original value of -1 will not work with bidi.)
7778 (compute_display_string_pos): First arg is now struct
7779 `text_pos *'; all callers changed. Support display properties on
7780 Lisp strings.
7781 (compute_display_string_end): Support display properties on Lisp
7782 strings.
7783 (init_iterator, reseat_1, reseat_to_string): Initialize the
7784 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7785 when iterating on a string not from display properties).
640c8776
SM
7786 (compute_display_string_pos, compute_display_string_end):
7787 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7788 arrow keys.
7789 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7790 base_level_stop; instead, set base_level_stop to BEGV.
7791 Fixes crashes in vertical-motion.
0bb23927
EZ
7792 (next_element_from_buffer): Improve commentary for when
7793 the iterator is before prev_stop.
7794 (init_iterator): Initialize bidi_p from the default value of
7795 bidi-display-reordering, not from buffer-local value. Use the
7796 buffer-local value only if initializing for buffer iteration.
7797 (handle_invisible_prop): Support invisible properties on strings
7798 that are being bidi-reordered.
7799 (set_iterator_to_next): Support bidi reordering of C strings and
7800 Lisp strings.
7801 (next_element_from_string): Support bidi reordering of Lisp
7802 strings.
7803 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7804 (display_string): Support display of R2L glyph rows.
7805 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7806 (init_iterator): Don't initialize it->bidi_p for strings
7807 here.
7808 (reseat_to_string): Initialize it->bidi_p for strings here.
7809 (next_element_from_string, next_element_from_c_string)
7810 (next_element_from_buffer): Add xassert's for correspondence
7811 between IT's object being iterated and it->bidi_it.string
7812 structure.
7813 (face_before_or_after_it_pos): Support bidi iteration.
7814 (next_element_from_c_string): Handle the case of the first string
7815 character that is not the first one in the visual order.
7816 (get_visually_first_element): New function, refactored from common
7817 parts of next_element_from_buffer, next_element_from_string, and
7818 next_element_from_c_string.
7819 (tool_bar_lines_needed, redisplay_tool_bar)
7820 (display_menu_bar): Force left-to-right direction. Add a FIXME
7821 comment for making that be controlled by a user option.
7822 (push_it, pop_it): Save and restore the state of the
7823 bidi iterator. Save and restore the bidi_p flag.
7824 (pop_it): Iterate out of display property for string iteration as
7825 well.
7826 (iterate_out_of_display_property): Support iteration over strings.
7827 (handle_single_display_spec): Set up it->bidi_it for iteration
7828 over a display string, and call bidi_init_it.
7829 (handle_single_display_spec, next_overlay_string)
7830 (get_overlay_strings_1, push_display_prop): Set up the bidi
7831 iterator for displaying display or overlay strings.
7832 (forward_to_next_line_start): Don't use the shortcut if
7833 bidi-iterating.
7834 (back_to_previous_visible_line_start): If handle_display_prop
7835 pushed the iterator stack, restore the internal state of the bidi
7836 iterator by calling bidi_pop_it same number of times.
7837 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7838 and we are bidi-iterating, don't decrement the iterator position;
7839 instead, set the first_elt flag in the bidi iterator, to produce
7840 the same effect.
7841 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7842 (push_display_prop): xassert that we are iterating a buffer.
7843 (push_it, pop_it): Save and restore paragraph_embedding member.
7844 (handle_single_display_spec, next_overlay_string)
7845 (get_overlay_strings_1, reseat_1, reseat_to_string)
7846 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7847 correctly. Don't assume unibyte strings are not bidi-reordered.
7848 (compute_display_string_pos)
7849 (compute_display_string_end): Fix handling the case of C string.
7850 (push_it, pop_it): Save and restore from_disp_prop_p.
7851 (handle_single_display_spec, push_display_prop): Set the
7852 from_disp_prop_p flag.
7853 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7854 (pop_it): Call iterate_out_of_display_property only if we are
7855 popping after iteration over a string that came from a display
7856 property. Fix a typo in popping stretch info. Add an assertion
7857 for verifying that the iterator position is in sync with the bidi
7858 iterator.
7859 (handle_single_display_spec, get_overlay_strings_1)
7860 (push_display_prop): Fix initialization of paragraph direction for
7861 string when that of the parent object is not yet determined.
7862 (reseat_1): Call bidi_init_it to resync the bidi
7863 iterator with IT's position. (Bug#7616)
7864 (find_row_edges): If ROW->start.pos gives position
7865 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7866 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7867 Reset the from_disp_prop_p flag.
7868 (SAVE_IT, RESTORE_IT): New macros.
7869 (pos_visible_p, face_before_or_after_it_pos)
7870 (back_to_previous_visible_line_start)
7871 (move_it_in_display_line_to, move_it_in_display_line)
7872 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7873 (try_scrolling, redisplay_window, display_line): Use them when
7874 saving a temporary copy of the iterator and restoring it back.
7875 (back_to_previous_visible_line_start, reseat_1)
7876 (init_iterator): Empty the bidi cache "stack".
7877 (move_it_in_display_line_to): If iterator ended up at
7878 EOL, but we never saw any buffer positions smaller than
7879 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7880 motion in bidi-reordered lines.
7881 (move_it_in_display_line_to): Record prev_method and prev_pos
7882 immediately before the call to set_iterator_to_next. Fixes cursor
7883 motion in bidi-reordered lines with stretch glyphs and strings
7884 displayed in margins. (Bug#8133) (Bug#8867)
7885 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7886 TO_CHARPOS.
640c8776
SM
7887 (pos_visible_p): Support positions in bidi-reordered lines.
7888 Save and restore bidi cache.
0bb23927
EZ
7889
7890 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7891 (bidi_paragraph_info): Delete unused struct.
7892 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7893 (bidi_cache_start): New variable.
7894 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7895 to zero.
7896 (bidi_cache_fetch_state, bidi_cache_search)
7897 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7898 (bidi_cache_find, bidi_peek_at_next_level)
7899 (bidi_level_of_next_char, bidi_find_other_level_edge)
7900 (bidi_move_to_visually_next): Compare cache index with
7901 bidi_cache_start rather than with zero.
7902 (bidi_fetch_char): Accept new argument STRING; all callers
7903 changed. Support iteration over a string. Support strings with
7904 display properties. Support unibyte strings. Fix the type of
7905 `len' according to what STRING_CHAR_AND_LENGTH expects.
7906 (bidi_paragraph_init, bidi_resolve_explicit_1)
7907 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7908 (bidi_level_of_next_char, bidi_move_to_visually_next):
7909 Support iteration over a string.
0bb23927
EZ
7910 (bidi_set_sor_type, bidi_resolve_explicit_1)
7911 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7912 can now be zero (for strings); special values 0 and -1 were
7913 changed to -1 and -2, respectively.
7914 (bidi_char_at_pos): New function.
7915 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7916 Call it instead of FETCH_MULTIBYTE_CHAR.
7917 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7918 initialized to valid values.
7919 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7920 values.
7921 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7922 the test for valid cached positions. Fix the logic for looking up
7923 the sentinel state in the cache. GCPRO the Lisp string we are
7924 iterating.
7925 (bidi_push_it, bidi_pop_it): New functions.
7926 (bidi_initialize): Initialize the bidi cache start stack pointer.
7927 (bidi_cache_ensure_space): New function, refactored from part of
7928 bidi_cache_iterator_state. Don't assume the required size is just
7929 one BIDI_CACHE_CHUNK away.
7930 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7931 (bidi_count_bytes, bidi_char_at_pos): New functions.
7932 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7933 always valid if bidi_cache_idx is valid.
7934 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7935 is valid if it's going to be used.
7936 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7937 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7938 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7939 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7940 (bidi_find_other_level_edge, bidi_cache_start_stack):
7941 All variables related to cache indices are now EMACS_INT.
c965adc5 7942
0bb23927
EZ
7943 * dispextern.h (struct bidi_string_data): New structure.
7944 (struct bidi_it): New member `string'. Make flag members be 1-bit
7945 fields, and put them last in the struct.
640c8776
SM
7946 (compute_display_string_pos, compute_display_string_end):
7947 Update prototypes.
0bb23927
EZ
7948 (bidi_push_it, bidi_pop_it): Add prototypes.
7949 (struct iterator_stack_entry): New members bidi_p,
7950 paragraph_embedding, and from_disp_prop_p.
7951 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7952 (bidi_shelve_cache, bidi_unshelve_cache):
7953 Declare prototypes.
0bb23927
EZ
7954
7955 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7956 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7957 and vector-like objects.
7958
7959 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7960 cache around display iteration.
7961
7962 * window.c (Fwindow_end, window_scroll_pixel_based)
7963 (displayed_window_lines, Frecenter): Save and restore the bidi
7964 cache around display iteration.
7965
3bbd2265
LMI
79662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7967
7968 * editfns.c (Fdelete_region): Clarify the use of the named
7969 parameters (bug#6788).
7970
adc47434
MR
79712011-07-14 Martin Rudalics <rudalics@gmx.at>
7972
7973 * indent.c (Fvertical_motion): Set and restore w->pointm when
7974 saving and restoring the window's buffer (Bug#9006).
7975
837c31f8
LMI
79762011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7977
7978 * editfns.c (Fstring_to_char): Clarify just what is returned
7979 (bug#6576). Text by Eli Zaretskii.
7980
ac389d0c
JB
79812011-07-13 Juanma Barranquero <lekktu@gmail.com>
7982
7983 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7984
0be0ce47
EZ
79852011-07-13 Eli Zaretskii <eliz@gnu.org>
7986
7987 * buffer.c (mmap_find): Fix a typo.
7988
cd18e7e3
JB
79892011-07-13 Johan Bockgård <bojohan@gnu.org>
7990
7991 Fix execution of x selection hooks.
7992 * xselect.c (Qx_lost_selection_functions)
7993 (Qx_sent_selection_functions): New vars.
7994 (syms_of_xselect): DEFSYM them.
7995 (x_handle_selection_request): Pass Qx_sent_selection_functions
7996 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7997 (x_handle_selection_clear,x_clear_frame_selections):
7998 Pass Qx_lost_selection_functions rather than
7999 Vx_lost_selection_functions to Frun_hook_with_args.
8000
47ea7f44
PE
80012011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8002
ac389d0c 8003 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8004 The old code sometimes used this field without initializing it.
8005
47ea7f44
PE
8006 * alloc.c (gc_sweep): Don't read past end of array.
8007 In theory, the old code could also have corrupted Emacs internals,
8008 though it'd be very unlikely.
8009
bc985c87
AS
80102011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8011
8012 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8013 argument. (Bug#4026)
bc985c87 8014
0cf34688
LMI
80152011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8016
b3dadd76
LMI
8017 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8018 key" (bug#4257).
8019
0cf34688
LMI
8020 * window.c (Fset_window_start): Doc fix (bug#4199).
8021 (Fset_window_hscroll): Ditto.
8022
270768cd
PE
80232011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8024
077e3dda 8025 Fix minor new problems caught by GCC 4.6.1.
270768cd 8026 * term.c (init_tty): Remove unused local.
490011a6 8027 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8028 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8029 not used otherwise.
270768cd 8030
b1f58454
CY
80312011-07-12 Chong Yidong <cyd@stupidchicken.com>
8032
8033 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8034
22b9578d
LMI
80352011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8036
6e70ab07
LMI
8037 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8038 are the mini-buffer and the echo area (bug#3320).
8039
22b9578d
LMI
8040 * term.c (init_tty): Remove support for supdup, c10 and perq
8041 terminals, which are no longer supported (bug#1482).
8042
8974cc9f
JB
80432011-07-10 Johan Bockgård <bojohan@gnu.org>
8044
8045 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8046
a560d974
JD
80472011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8048
8049 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8050 for non-popups (Bug#3642).
8051
1dae0f0a
AS
80522011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8053
268c2c36 8054 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8055 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8056 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8057 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8058 * data.c (fmod): Likewise.
8059 * dispnew.c (swap_glyphs_in_rows): Likewise.
8060 * emacs.c (memory_warning_signal): Likewise.
8061 * floatfns.c (float_error): Likewise.
8062 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8063 (otf_open, font_otf_capability, generate_otf_features)
8064 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8065 Likewise.
8066 * image.c (pbm_read_file): Likewise.
8067 * indent.c (string_display_width): Likewise.
8068 * intervals.c (check_for_interval, search_for_interval)
8069 (inc_interval_count, count_intervals, root_interval)
8070 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8071 * lread.c (defalias): Likewise.
268c2c36 8072 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8073 * regex.c (set_image_of_range_1, set_image_of_range)
8074 (regex_grow_registers): Likewise.
8075 * sysdep.c (strerror): Likewise.
8076 * termcap.c (valid_filename_p, tprint, main): Likewise.
8077 * tparam.c (main): Likewise.
8078 * unexhp9k800.c (run_time_remap, save_data_space)
8079 (update_file_ptrs, read_header, write_header, calculate_checksum)
8080 (copy_file, copy_rest, display_header): Likewise.
8081 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8082 Likewise.
8083 * xdisp.c (check_it): Likewise.
8084 * xfaces.c (register_color, unregister_color, unregister_colors):
8085 Likewise.
8086 * xfns.c (print_fontset_result): Likewise.
8087 * xrdb.c (member, fatal, main): Likewise.
8088
99033785
PE
80892011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8090
8091 Fix minor problems found by static checking (Bug#9031).
8092 * chartab.c (char_table_set_range, map_sub_char_table):
8093 Remove unused locals.
8094 (uniprop_table): Now static.
8095 * composite.c (_work_char): Remove unused static var.
8096
9cb2ac56
JB
80972011-07-09 Juanma Barranquero <lekktu@gmail.com>
8098
8099 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8100
f25661f0
JD
81012011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8102
8103 * gtkutil.c (qttip_cb): Remove code without function.
8104
8278c4fe
EZ
81052011-07-09 Eli Zaretskii <eliz@gnu.org>
8106
8107 * w32.c (pthread_sigmask): New stub.
8108
1692ae2d 81092011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8110
8a6ebd58 8111 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8112 sigprocmask is portable only for single-threaded applications, and
8113 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8114 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8115 (LIBES): Use it.
8116 * callproc.c (Fcall_process):
8117 * process.c (create_process):
8118 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8119 Use pthread_sigmask, not sigprocmask.
123403e4 8120
1b854618
JD
81212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8122
8123 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8124 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8125 wrong (Bug#8591).
8126
3fe4b549
JD
81272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8128
0ce7e563
JD
8129 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8130 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8131 (xg_hide_tooltip): Fix comment.
8132
3fe4b549
JD
8133 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8134 in registerServicesMenuSendTypes.
8135 (validRequestorForSendType): Don't check ns_return_types.
8136
8137 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8138 ns_return_type.
8139
5df75e47
JR
81402011-07-08 Jason Rumney <jasonr@gnu.org>
8141
22610910
JR
8142 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8143 SH_SHOW for hidden windows (Bug#5482).
8144
5df75e47
JR
8145 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8146 frame struct members of non-existent frames (Bug#6284).
8147
699c10bd
JD
81482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8149
4393663b
JD
8150 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8151 variable firstTime not needed on OSX >= 10.6.
8152 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8153 >= 10.5. Use setKnobProportion, setDoubleValue.
8154
8155 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8156 (MAC_OS_X_VERSION_10_5): Define if not defined.
8157 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8158 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8159 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8160
8161 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8162 cString and lossyCString on OSX >= 10.4.
4393663b 8163
58179cce 8164 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8165 sizeToFit on OSX >= 10.2.
8166
8167 * nsimage.m (allocInitFromFile): Don't use deprecated method
8168 bestRepresentationForDevice on OSX >= 10.6.
8169
8170 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8171 to avoid warning.
8172
8173 * emacs.c: Declare unexec_init_emacs_zone.
8174
a63e0781
JD
8175 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8176
699c10bd
JD
8177 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8178
8179 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8180 on svcsMenu (Bug#8842).
8181
8182 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8183 ns_return_types.
8184 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8185
8186 * nsterm.m (QUTF8_STRING): Declare.
8187 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8188 (validRequestorForSendType): Return type is (id).
8189 Change indexOfObjectIdenticalTo to indexOfObject.
8190 Check if we have local selection before returning self (Bug#8842).
8191 (writeSelectionToPasteboard): Put local selection into paste board
8192 if we have a local selection (Bug#8842).
8193 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8194
8195 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8196 (ns_get_local_selection): Declare.
8197
54e10184
LMI
81982011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8199
9888ff71
LMI
8200 * keymap.c (describe_map_tree): Don't insert a double newline at
8201 the end of the buffer (bug#1169) and return whether we inserted
8202 something.
8203
54e10184
LMI
8204 * callint.c (Fcall_interactively): Change "reading args" to
8205 "providing args" to try to clarify what it does (bug#1010).
8206
15fa4783
KH
82072011-07-07 Kenichi Handa <handa@m17n.org>
8208
8209 * composite.c (composition_compute_stop_pos): Ignore a static
8210 composition starting before CHARPOS (Bug#8915).
8211
8212 * xdisp.c (handle_composition_prop): Likewise.
8213
a8815b00
EZ
82142011-07-07 Eli Zaretskii <eliz@gnu.org>
8215
8216 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8217 (Bug#9015)
8218
ef7b981d 82192011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8220
8221 * character.h (unicode_category_t): New enum type.
8222
8223 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8224 (Qchar_code_property_table): New variable.
8225 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8226 (UNIPROP_COMPRESSED_FORM_P): New macros.
8227 (char_table_ascii): Uncompress the compressed values.
8228 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8229 Uncompress the compressed values.
ac389d0c 8230 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8231 (char_table_ref_and_range): Uncompress the compressed values.
8232 (sub_char_table_set): New arg is_uniprop. Callers changed.
8233 Uncompress the compressed values.
8234 (sub_char_table_set_range): Args changed. Callers changed.
8235 (char_table_set_range): Adjuted for the above change.
8236 (map_sub_char_table): Delete args default_val and parent. Add arg
8237 top. Give decoded values to a Lisp function.
640c8776 8238 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8239 values to a Lisp function. Gcpro more variables.
8240 (uniprop_table_uncompress)
8241 (uniprop_decode_value_run_length): New functions.
8242 (uniprop_decoder, uniprop_decoder_count): New variables.
8243 (uniprop_get_decoder, uniprop_encode_value_character)
8244 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8245 New functions.
8246 (uniprop_encoder, uniprop_encoder_count): New variables.
8247 (uniprop_get_encoder, uniprop_table)
8248 (Funicode_property_table_internal, Fget_unicode_property_internal)
8249 (Fput_unicode_property_internal): New functions.
8250 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8251 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8252 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8253 char-code-property-alist.
8254
640c8776 8255 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8256 Vunicode_category_table.
8257
640c8776 8258 * font.c (font_range): Adjust for the change of
c805dec0
KH
8259 Vunicode_category_table.
8260
76b397fb
DN
82612011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8262
8263 * m/iris4d.h: Remove file, move contents ...
8264 * s/irix6-5.h: ... here.
8265
22b4128e
PE
82662011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8267
8268 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8269 * alloc.c (mark_buffer):
8270 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8271 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8272 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8273 This isn't true in general, and it's particularly not true
8274 if Emacs is configured with --with-wide-int.
8275 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8276 New macros, used in the buffer.c change.
8277
869795d6
JD
82782011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8279
8280 * xsettings.c: Use both GConf and GSettings if both are available.
8281 (store_config_changed_event): Add comment.
8282 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8283 (store_tool_bar_style_changed): New functions.
5e617bc2 8284 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8285 (struct xsettings): Move font inside HAVE_XFT.
8286 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8287 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8288 Move inside HAVE_XFT.
640c8776 8289 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8290 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8291 also.
8292 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8293 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8294 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8295 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8296 (parse_settings): Move check for font inside HAVE_XFT.
8297 (read_settings, apply_xft_settings): Add comment.
8298 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8299 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8300 call store_font_name_changed.
8301 (xft_settings_event): Add comment.
8302 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8303 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8304 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8305 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8306 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8307 (xsettings_get_system_font, xsettings_get_system_normal_font):
8308 Add comment.
869795d6 8309
d8ed26bd
PE
83102011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8311
8312 Random fixes. E.g., (random) never returned negative values.
8313 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8314 subseconds part to the entropy, as that's a bit more random.
8315 Prefer signed to unsigned, since the signedness doesn't matter and
8316 in general we prefer signed. When given a limit, use a
8317 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8318 latter isn't right if USE_2_TAGS_FOR_INTS.
8319 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8320 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8321
cabf1cac
SM
83222011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8323
8324 * textprop.c (text_property_stickiness):
8325 Obey Vtext_property_default_nonsticky.
8326 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8327 * w32fns.c (syms_of_w32fns):
8328 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8329
6e9b2be9
PE
83302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8331
8332 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8333 This is more efficient than Ffile_directory_p and avoids a minor race.
8334
90186c68
LMI
83352011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8336
7c301272
LMI
8337 * buffer.c (Foverlay_put): Say what the return value is
8338 (bug#7835).
8339
c4f2d8d4
LMI
8340 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8341 is a directory before asking whether to use the file name
8342 (bug#7564).
ad637907
LMI
8343 (barf_or_query_if_file_exists): Make the "File is a directory"
8344 error be more correct.
c4f2d8d4 8345
90186c68
LMI
8346 * fns.c (Frequire): Remove the mention of the .gz files, since
8347 that's installation-specific, but keep the mention of
8348 `get-load-suffixes'.
8349
da64016e
PE
83502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8351
8352 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8353 Report string overflow if the output is too long.
8354
7d47b580
JB
83552011-07-04 Juanma Barranquero <lekktu@gmail.com>
8356
a555cb87
JB
8357 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8358 (syms_of_gnutls): Remove duplicate DEFSYM for
8359 Qgnutls_bootprop_verify_hostname_error, an error for
8360 Qgnutls_bootprop_verify_error (which is no longer used).
8361
7d47b580
JB
8362 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8363 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8364 Also (re)move comments that are misplaced or no longer relevant.
8365
1e49bfab
LMI
83662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8367
8368 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8369
1485f4c0
CY
83702011-07-03 Chong Yidong <cyd@stupidchicken.com>
8371
8372 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8373 and background color parameters if they have been changed.
8374
a9ab721e
LMI
83752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8376
8377 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8378
cf7cff57
PE
83792011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8380
2e13213d
PE
8381 * xsettings.c (SYSTEM_FONT): Define only when used.
8382 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8383
cf7cff57
PE
8384 * keymap.c (access_keymap_1): Now static.
8385
7a8e04f7
CY
83862011-07-02 Chong Yidong <cyd@stupidchicken.com>
8387
8388 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8389 leave any prefix arg for the up event (Bug#1586).
8390
61352f62
LMI
83912011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8392
69bb1ef7
LMI
8393 * lread.c (syms_of_lread): Mention single symbols defined by
8394 `defvar' or `defconst' (bug#7154).
8395
61352f62 8396 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8397 (Frequire): Mention get-load-suffixes.
61352f62 8398
28545e04
MR
83992011-07-02 Martin Rudalics <rudalics@gmx.at>
8400
8401 * window.h (window): Remove clone_number slot.
8402 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8403 Remove.
8404 (make_parent_window, make_window, saved_window)
8405 (Fset_window_configuration, save_window_save): Don't deal with
8406 clone numbers.
8407 * buffer.c (Qclone_number): Remove declaration.
8408 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8409
3349e122
SM
84102011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8411
8412 Add multiple inheritance to keymaps.
8413 * keymap.c (Fmake_composed_keymap): New function.
8414 (Fset_keymap_parent): Simplify.
8415 (fix_submap_inheritance): Remove.
8416 (access_keymap_1): New function extracted from access_keymap to handle
8417 embedded parents and handle lists of maps.
8418 (access_keymap): Use it.
8419 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8420 (Fcopy_keymap): Handle embedded parents.
8421 (Fcommand_remapping, define_as_prefix): Simplify.
8422 (Fkey_binding): Simplify.
8423 (syms_of_keymap): Move minibuffer-local-completion-map,
8424 minibuffer-local-filename-completion-map,
8425 minibuffer-local-must-match-map, and
8426 minibuffer-local-filename-must-match-map to Elisp.
8427 (syms_of_keymap): Defsubr make-composed-keymap.
8428 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8429 (parse_menu_item): Trivial simplification.
8430
3279eb87
GM
84312011-07-01 Glenn Morris <rgm@gnu.org>
8432
8433 * Makefile.in (SETTINGS_LIBS): Fix typo.
8434
4550efdf
KI
84352011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8436
8437 * coding.c (Fencode_coding_string): Record the last coding system
8438 used, as the function doc string says (bug#8738).
8439
0949d2b6
JD
84402011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8441
8442 * xsettings.c (store_monospaced_changed): Take new font as arg and
8443 check for change against current_mono_font.
8444 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8445 (emacs_settings_constructor, emacs_settings_get_property)
8446 (emacs_settings_set_property, emacs_settings_class_init)
8447 (emacs_settings_init, gsettings_obj): Remove.
8448 (something_changedCB): New function for HAVE_GSETTINGS.
8449 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8450 with value as argument.
8451 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8452 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8453 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8454 "changed".
8455
8456 * xgselect.c: Add defined (HAVE_GSETTINGS).
8457 (xgselect_initialize): Ditto.
8458
8459 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8460 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8461 xg_select.
8462
bbc6b304
PE
84632011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8464
8465 * eval.c (struct backtrace): Simplify and port the data structure.
8466 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8467 signed bit field, as this assumption is not portable and it makes
8468 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8469 "char debug_on_exit : 1" as this is not portable either; instead,
8470 use the portable "unsigned int debug_on_exit : 1". Remove unused
8471 member evalargs. Remove obsolete comments about cc bombing out.
8472
9851bfc5
JD
84732011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8474
51bb811f 8475 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8476 Let HAVE_GSETTINGS override HAVE_GCONF.
8477 (store_monospaced_changed): New function.
8478 (EMACS_SETTINGS): A new type derived from GObject to handle
8479 GSettings notifications.
8480 (emacs_settings_constructor, emacs_settings_get_property)
8481 (emacs_settings_set_property, emacs_settings_class_init):
8482 New functions.
8483 (gsettings_client, gsettings_obj): New variables.
8484 (GSETTINGS_SCHEMA): New define.
8485 (something_changedCB): Call store_monospaced_changed.
8486 (init_gsettings): New function.
8487 (xsettings_initialize): Call init_gsettings.
8488 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8489 to NULL.
8490
640c8776 8491 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8492 GCONF_CFLAGS/LIBS.
8493
5386012d
MR
84942011-06-29 Martin Rudalics <rudalics@gmx.at>
8495
8496 * window.c (resize_root_window, grow_mini_window)
8497 (shrink_mini_window): Rename Qresize_root_window to
8498 Qwindow_resize_root_window and Qresize_root_window_vertically to
8499 Qwindow_resize_root_window_vertically.
8500
f13e0b08
PE
85012011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8502
8503 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8504
94515237
JB
85052011-06-27 Juanma Barranquero <lekktu@gmail.com>
8506
8507 * makefile.w32-in: Redesign dependencies so they reflect more
8508 clearly which files are directly included by each source file,
8509 and not through other includes.
8510
e43b6e43
MR
85112011-06-27 Martin Rudalics <rudalics@gmx.at>
8512
8513 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8514 (sort_overlays, overlay_strings): When an overlay's clone number
8515 matches the window's clone number process the overlay even if
8516 the overlay's window property doesn't match the current window.
8517
d68443dc
MR
8518 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8519 (Fwindow_hchild): Rename to Fwindow_left_child.
8520 (Fwindow_next): Rename to Fwindow_next_sibling.
8521 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8522 (resize_window_check): Rename to window_resize_check.
8523 (resize_window_apply): Rename to window_resize_apply.
8524 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8525 (Fdelete_other_windows_internal, resize_frame_windows)
8526 (Fsplit_window_internal, Fdelete_window_internal)
8527 (grow_mini_window, shrink_mini_window)
8528 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8529
c7e73be5
JD
85302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8531
8532 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8533 (emacs_fixed_set_min_size): Remove.
8534 (emacs_fixed_new): Take frame as argument.
8535
8536 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8537 (_EmacsFixedPrivate): Remove minwidth/height.
8538 Add struct frame *f.
8539 (emacs_fixed_init): Initialize priv->f.
8540 (get_parent_class, emacs_fixed_set_min_size): Remove.
8541 (emacs_fixed_new): Set priv->f to argument.
8542 (emacs_fixed_get_preferred_width)
8543 (emacs_fixed_get_preferred_height): Use min_width/height from
8544 frames size_hint to set minimum and natural (Bug#8919).
8545 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8546 and use min_width/height from frames size_hint to set
8547 min_width/height (Bug#8919).
8548
8549 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8550 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8551 Fix indentation.
c7e73be5 8552
cf99dcf8
EZ
85532011-06-26 Eli Zaretskii <eliz@gnu.org>
8554
8555 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8556 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8557 called at ZV.
8558
029529ac
CY
85592011-06-26 Chong Yidong <cyd@stupidchicken.com>
8560
8561 * process.c (wait_reading_process_output): Bypass select if
8562 waiting for a cell while ignoring keyboard input, and input is
8563 pending. Suggested by Jan Djärv (Bug#8869).
8564
7a7ef429
PE
85652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8566
8567 Use gnulib's dup2 module instead of rolling our own.
8568 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8569
11fdef7d 85702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8571
8572 * dispnew.c (scrolling_window): Before scrolling, turn off a
8573 mouse-highlight in the window being scrolled.
8574
cd3520a4
JB
85752011-06-24 Juanma Barranquero <lekktu@gmail.com>
8576
8577 Move DEFSYM to lisp.h and use everywhere.
8578
8579 * character.h (DEFSYM): Move declaration...
8580 * lisp.h (DEFSYM): ...here.
8581
8582 * gnutls.c:
8583 * minibuf.c:
8584 * w32menu.c:
8585 * w32proc.c:
8586 * w32select.c: Don't include character.h.
8587
8588 * alloc.c (syms_of_alloc):
8589 * buffer.c (syms_of_buffer):
8590 * bytecode.c (syms_of_bytecode):
8591 * callint.c (syms_of_callint):
8592 * casefiddle.c (syms_of_casefiddle):
8593 * casetab.c (init_casetab_once):
8594 * category.c (init_category_once, syms_of_category):
8595 * ccl.c (syms_of_ccl):
8596 * cmds.c (syms_of_cmds):
8597 * composite.c (syms_of_composite):
8598 * dbusbind.c (syms_of_dbusbind):
8599 * dired.c (syms_of_dired):
8600 * dispnew.c (syms_of_display):
8601 * doc.c (syms_of_doc):
8602 * editfns.c (syms_of_editfns):
8603 * emacs.c (syms_of_emacs):
8604 * eval.c (syms_of_eval):
8605 * fileio.c (syms_of_fileio):
8606 * fns.c (syms_of_fns):
8607 * frame.c (syms_of_frame):
8608 * fringe.c (syms_of_fringe):
8609 * insdel.c (syms_of_insdel):
8610 * keymap.c (syms_of_keymap):
8611 * lread.c (init_obarray, syms_of_lread):
8612 * macros.c (syms_of_macros):
8613 * msdos.c (syms_of_msdos):
8614 * print.c (syms_of_print):
8615 * process.c (syms_of_process):
8616 * search.c (syms_of_search):
8617 * sound.c (syms_of_sound):
8618 * syntax.c (init_syntax_once, syms_of_syntax):
8619 * terminal.c (syms_of_terminal):
8620 * textprop.c (syms_of_textprop):
8621 * undo.c (syms_of_undo):
8622 * w32.c (globals_of_w32):
8623 * window.c (syms_of_window):
8624 * xdisp.c (syms_of_xdisp):
8625 * xfaces.c (syms_of_xfaces):
8626 * xfns.c (syms_of_xfns):
8627 * xmenu.c (syms_of_xmenu):
8628 * xsettings.c (syms_of_xsettings):
8629 * xterm.c (syms_of_xterm): Use DEFSYM.
8630
4228cf16
TZ
86312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8632
cd3520a4 8633 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8634
7fcccf1e
PE
86352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8636
7efb4e0e
PE
8637 Integer and buffer overflow fixes (Bug#8873).
8638
ff5844ad
PE
8639 * print.c (printchar, strout): Check for string overflow.
8640 (PRINTPREPARE, printchar, strout):
8641 Don't set size unless allocation succeeds.
8642
90532f02
PE
8643 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8644 for sizes. Check for string overflow more accurately.
8645 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8646
6d84508d
PE
8647 * macros.c: Integer and buffer overflow fixes.
8648 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8649 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8650 Use ptrdiff_t, not int, for sizes.
8651 Don't increment bufsize until after realloc succeeds.
8652 Check for size-calculation overflow.
8653 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8654
437b2cb4
PE
8655 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8656
8b9ac8b4
PE
8657 * lread.c: Integer overflow fixes.
8658 (read_integer): Radix is now EMACS_INT, not int,
8659 to improve quality of diagnostics for out-of-range radices.
8660 Calculate buffer size correctly for out-of-range radices.
8661 (read1): Check for integer overflow in radices, and in
8662 read-circle numbers.
82cb60d3
PE
8663 (read_escape): Avoid int overflow.
8664 (Fload, openp, read_buffer_size, read1)
8665 (substitute_object_recurse, read_vector, read_list, map_obarray):
8666 Use ptrdiff_t, not int, for sizes.
8667 (read1): Use EMACS_INT, not int, for sizes.
20270765 8668 Check for size overflow.
8b9ac8b4 8669
7fcccf1e
PE
8670 * image.c (cache_image): Check for size arithmetic overflow.
8671
bfbbd7e7
PE
8672 * lread.c: Integer overflow issues.
8673 (saved_doc_string_size, saved_doc_string_length)
8674 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8675 Now ptrdiff_t, not int.
8676 (read1): Don't assume doc string length fits in int. Check for
8677 out-of-range doc string lengths.
8678 (read_list): Don't assume file position fits in int.
39019e54 8679 (read_escape): Check for hex character overflow.
bfbbd7e7 8680
4e323265
LL
86812011-06-22 Leo Liu <sdl.web@gmail.com>
8682
8683 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8684 Move to minibuffer.el.
8685
85fece3e
PE
86862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8687
20b84ce9 8688 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8689 The following patches are for when GLYPH_DEBUG && !XASSERT.
8690 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8691 * dispnew.c (flush_stdout):
8692 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8693 Mark as externally visible.
8694 * dispnew.c (check_window_matrix_pointers): Now static.
8695 * dispnew.c (window_to_frame_vpos):
8696 * xfns.c (unwind_create_frame):
8697 * xterm.c (x_check_font): Remove unused local.
8698 * scroll.c (CHECK_BOUNDS):
8699 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8700 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8701 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8702 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8703 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8704 Now static.
8705 (debug_method_add): Use va_list and vsprintf rather than relying
8706 on undefined behavior with wrong number of arguments.
8707 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8708 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8709 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8710 since we're not interested in debugging glyphs with old libraries.
8711 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8712 GCC 4.6.0's static checking.
8713
0766b489
PE
87142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8715
31fd4b32
PE
8716 Integer overflow and signedness fixes (Bug#8873).
8717 A few related buffer overrun fixes, too.
8718
b79e8648
PE
8719 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8720
0766b489
PE
8721 * dispextern.h (struct face.stipple):
8722 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8723 (x_bitmap_mask, x_allocate_bitmap_record)
8724 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8725 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8726 (x_create_bitmap_from_xpm_data):
8727 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8728 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8729 (.bitmaps_last):
8730 * xfaces.c (load_pixmap):
8731 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8732 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8733 (.bitmaps_last, struct x_output.icon_bitmap):
8734 Use ptrdiff_t, not int, for bitmap indexes.
8735 (x_allocate_bitmap_record): Check for size overflow.
8736 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8737
b081724f
PE
8738 Use ptrdiff_t, not int, for overlay counts.
8739 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8740 * editfns.c (overlays_around, get_pos_property):
8741 * textprop.c (get_char_property_and_overlay):
8742 * xdisp.c (next_overlay_change, note_mouse_highlight):
8743 * xfaces.c (face_at_buffer_position):
21514da7
PE
8744 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8745 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8746 (Fnext_overlay_change, Fprevious_overlay_change)
8747 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8748 Use ptrdiff_t, not int, for sizes.
21514da7 8749 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8750
3de73e5e
PE
8751 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8752
2606c57b
PE
8753 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8754 (x_session_initialize): Do not assume string length fits in int.
8755
aaafe47a
PE
8756 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8757 This is unlikely, but can occur if DPI is outlandish.
8758
2674ddc8 8759 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8760 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8761
28154962
PE
8762 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8763 * xrdb.c (magic_file_p, search_magic_path):
8764 Omit last arg SUFFIX; it was always 0. All callers changed.
8765 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8766
7de51af5
PE
8767 * xfont.c (xfont_match): Avoid need for strlen.
8768
25ed6cc3
PE
8769 * xfns.c: Don't assume strlen fits in int.
8770 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8771
4eab31dd
PE
8772 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8773 not unsigned long, as we prefer signed integers. All callers changed.
8774 Detect integer overflow in repeat count.
8775 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8776 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8777
171e2a58
PE
8778 * termcap.c: Don't assume sizes fit in int and never overflow.
8779 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8780 (gobble_line): Check for size-calculation overflow.
8781
ad39faca 8782 * minibuf.c (Fread_buffer):
6e5bb2dc 8783 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8784 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8785 Don't assume string length fits in int.
8786
52c61c22 8787 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8788 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8789
b5b8c9e5
PE
8790 * font.c: Don't assume string length fits in int.
8791 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8792 Use ptrdiff_t, not int.
ccd6111c
PE
8793 (font_intern_prop): Don't assume string length fits in int.
8794 Don't assume integer property fits in fixnum.
8795 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8796
882f0d81 8797 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8798 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8799 Reformulate so as not to need the command string.
8800 Invoke gzip -cd rather than gunzip, as it's more portable.
8801 (lock_info_type, lock_file_1, lock_file):
8802 Don't assume pid_t and time_t fit in unsigned long.
8803 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8804 (current_lock_owner): Prefer signed type for sizes.
8805 Use memcpy, not strncpy, where memcpy is what is really wanted.
8806 Don't assume (via atoi) that time_t and pid_t fit in int.
8807 Check for time_t and/or pid_t out of range, e.g., via a network share.
8808 Don't alloca where an auto var works fine.
8809
93f4cf88
PE
8810 * fileio.c: Fix some integer overflow issues.
8811 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8812 Don't assume string length fits in int.
8813 (directory_file_name): Don't assume string length fits in long.
8814 (make_temp_name): Don't assume pid fits in int, or that its print
8815 length is less than 20.
8816
f3e92b69
PE
8817 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8818
1bfdaf10
PE
8819 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8820
35016e9a
PE
8821 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8822
3d1e65a1
PE
8823 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8824 We prefer signed integers, even for size calculations.
8825
0b963a93
PE
8826 * emacs.c: Don't assume string length fits in 'int'.
8827 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8828 (main): Don't invoke strlen when not needed.
8829
573f4b54
PE
8830 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8831 (XD_DEBUG_MESSAGE): Don't waste a byte.
8832
989f33ba
PE
8833 * callproc.c (getenv_internal_1, getenv_internal)
8834 (Fgetenv_internal):
965d34eb
PE
8835 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8836
e4d29b33
PE
8837 * lread.c (invalid_syntax): Omit length argument.
8838 All uses changed. This doesn't fix a bug, but it simplifies the
8839 code away from its former Hollerith-constant appearance, and it's
8840 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8841 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8842
eb49b136
PE
8843 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8844 This didn't break anything, but it didn't help either.
8845 It's confusing to put a bogus integer in a place where the actual
8846 value does not matter.
9f62aeb1 8847 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8848 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8849
15375a22
PE
8850 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8851 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8852 implementation.
b61cc01c
PE
8853 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8854 We prefer signed types, and the value cannot exceed the EMACS_INT
8855 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8856 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8857 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8858 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8859
53b2623d
PE
8860 * indent.c (sane_tab_width): New function.
8861 (current_column, scan_for_column, Findent_to, position_indentation)
8862 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8863 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8864
51cab52b 8865 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8866
f2ed8a70
PE
8867 * lisp.h (lint_assume): New macro.
8868 * composite.c (composition_gstring_put_cache):
8869 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8870
abe80cc6
PE
8871 * editfns.c, insdel.c:
8872 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8873
b02c740e
PE
8874 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8875
ebc96716
PE
8876 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8877
b4e50fa0 8878 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8879 Use much-faster test for byte-length change.
311d5d7c 8880 Don't assume string byte-length fits in 'int'.
a4cf38e4 8881 Check that character arg fits in 'int'.
85461888 8882 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8883
c0c1ee9f
PE
8884 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8885
a498d7f4
PE
8886 * fns.c (concat): Catch string overflow earlier.
8887 Do not rely on integer wraparound.
8888
51cab52b
PE
8889 * dispextern.h (struct it.overlay_strings_charpos)
8890 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8891 * xdisp.c (forward_to_next_line_start)
8892 (back_to_previous_visible_line_start)
8893 (reseat_at_next_visible_line_start, next_element_from_buffer):
8894 Don't arbitrarily truncate the value of 'selective' to int.
8895
76031fad
PE
8896 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8897
5eb55db9
PE
8898 * composite.c: Don't truncate sizes to 'int'.
8899 (composition_gstring_p, composition_reseat_it)
8900 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8901 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8902 not EMACS_UINT, for indexes.
5eb55db9 8903
0703a717
PE
8904 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8905
d6202519
PE
8906 * buffer.c: Include <verify.h>.
8907 (struct sortvec.priority, struct sortstr.priority):
8961a454 8908 Now EMACS_INT, not int.
c20998a7 8909 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8910 (struct sortstr.size, record_overlay_string)
8911 (struct sortstrlist.size, struct sortlist.used):
8912 Don't truncate size to int.
8913 (record_overlay_string): Check for size-calculation overflow.
d6202519 8914 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8915
d5a19415
JM
89162011-06-22 Jim Meyering <meyering@redhat.com>
8917
029529ac 8918 Don't leak an XBM-image-sized buffer
d5a19415
JM
8919 * image.c (xbm_load): Free the image buffer after using it.
8920
a9041e6c
PE
89212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8922
8923 Port to Sun C.
8924 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8925 that Sun C diagnosed.
8926 * fns.c (secure_hash): Fix pointer signedness issue.
8927 * intervals.c (static_offset_intervals): New function.
8928 (offset_intervals): Use it.
8929
7f3f739f
LL
89302011-06-21 Leo Liu <sdl.web@gmail.com>
8931
8932 * deps.mk (fns.o):
8933 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8934 sha512.h.
8935
8936 * fns.c (secure_hash): Rename from crypto_hash_function and change
8937 the first arg to accept symbols.
5b66d427 8938 (Fsecure_hash): New primitive.
7f3f739f
LL
8939 (syms_of_fns): New symbols.
8940
76147d94
DD
89412011-06-20 Deniz Dogan <deniz@dogan.se>
8942
8943 * process.c (Fset_process_buffer): Clarify return value in
8944 docstring.
8945
7d7d0045
CY
89462011-06-18 Chong Yidong <cyd@stupidchicken.com>
8947
8948 * dispnew.c (add_window_display_history): Use BVAR.
8949
8950 * xdisp.c (debug_method_add): Use BVAR.
8951 (check_window_end, dump_glyph_matrix, dump_glyph)
8952 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8953
8954 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8955 Likewise.
8956
8957 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8958 check till after the cache is created in init_frame_faces.
8959
ff2bc410
SM
89602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8961
8962 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8963
28177add
PE
89642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8965
dd3482fe
PE
8966 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8967 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8968 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8969
393d71f3 8970 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8971 * fileio.c (Finsert_file_contents):
8972 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8973 Remove the old (too-loose) buffer overflow checks.
8974 They weren't needed, since make_gap checks for buffer overflow.
8975 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8976 The old code merely checked for Emacs fixnum overflow, and relied
8977 on undefined (wraparound) behavior. The new code avoids undefined
8978 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8979
2e6813b0 8980 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8981 Tune. Don't use wider integers than needed. Don't use alloca.
8982 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8983
599a9e4f
PE
8984 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8985
99561444
PE
8986 * insdel.c, lisp.h (buffer_overflow): New function.
8987 (insert_from_buffer_1, replace_range, replace_range_2):
8988 * insdel.c (make_gap_larger):
8989 * editfns.c (Finsert_char):
8990 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8991
28177add
PE
8992 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8993
e69dafad
PE
89942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8995
4baa020d 8996 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8997
b1c46f02
PE
8998 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8999 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9000
e69dafad
PE
9001 * fileio.c: Don't assume EMACS_INT fits in off_t.
9002 (emacs_lseek): New static function.
9003 (Finsert_file_contents, Fwrite_region): Use it.
9004 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9005
566684ea
PE
9006 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9007
e6966cd6
PE
9008 * fns.c: Don't overflow int when computing a list length.
9009 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9010 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9011 truncation on 64-bit hosts. Check for QUIT every
9012 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9013 faster and is responsive enough.
9014 (Flength): Report an error instead of overflowing an integer.
9015 (Fsafe_length): Return a float if the value is not representable
9016 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9017 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9018 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9019
dd0b0efb
PE
9020 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9021 (header_size, word_size): New constants.
9022 (allocate_vectorlike): Don't check size overflow here.
9023 (allocate_vector): Check it here instead, since this is the only
9024 caller of allocate_vectorlike that could cause overflow.
9025 Check that the new vector's length is representable as a fixnum.
9026
86fe5cfe
PE
9027 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9028 The previous code was bogus. For example, next_almost_prime (32)
9029 returned 39, which is undesirable as it is a multiple of 3; and
9030 next_almost_prime (24) returned 25, which is a multiple of 5 so
9031 why was the code bothering to check for multiples of 7?
9032
80e88859
PE
9033 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9034
4a2f0ad6
PE
9035 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9036
f66c7cf8
PE
9037 Variadic C functions now count arguments with ptrdiff_t.
9038 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9039 Back then I didn't know that the Emacs coding style prefers signed int.
9040 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9041 were being counted with int, which may truncate counts on 64-bit
9042 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9043 * lisp.h (struct Lisp_Subr.function.aMANY)
9044 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9045 Arg counts are now ptrdiff_t, not size_t.
9046 All variadic functions and their callers changed accordingly.
9047 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9048 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9049 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9050 * callint.c (Fcall_interactively): Check arg count for overflow,
9051 to avoid potential buffer overrun. Use signed char, not 'int',
9052 for 'varies' array, so that we needn't bother to check its size
9053 calculation for overflow.
9054 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9055 * eval.c (apply_lambda):
9056 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9057 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9058 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9059
a1759b76
PE
9060 * callint.c (Fcall_interactively): Don't use index var as event count.
9061
d96be9fc
PE
9062 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9063 * mem-limits.h (SIZE): Remove; no longer used.
9064
a690a978 9065 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9066
578c21e6
PE
9067 Remove unnecessary casts.
9068 * xterm.c (x_term_init):
9069 * xfns.c (x_set_border_pixel):
9070 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9071 These aren't needed now that we assume ANSI C.
9072
96f53c6c
PE
9073 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9074 It's more likely to cause problems (due to unsigned overflow)
9075 than to cure them.
9076
83c77d31
PE
9077 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9078
ee2079f1
PE
9079 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9080
6da65536
PE
9081 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9082
7147c4a4
PE
9083 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9084
193e32d9
PE
9085 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9086
e5533da6
PE
9087 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9088
9910e595
PE
9089 GLYPH_CODE_FACE returns EMACS_INT, not int.
9090 * dispextern.h (merge_faces):
9091 * xfaces.c (merge_faces):
01103c44
PE
9092 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9093 Don't assume EMACS_INT fits in int.
9910e595 9094
2638320e
PE
9095 * character.h (CHAR_VALID_P): Remove unused parameter.
9096 * fontset.c, lisp.h, xdisp.c: All uses changed.
9097
045eb8d9
PE
9098 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9099
c1f134b5
PE
9100 * fns.c (concat): Minor tuning based on overflow analysis.
9101 This doesn't fix any bugs. Use int to hold character, instead
9102 of constantly refetching from Emacs object. Use XFASTINT, not
9103 XINT, for value known to be a character. Don't bother comparing
9104 a single byte to 0400, as it's always less.
9105
395fcb93 9106 * floatfns.c (Fexpt):
327eeec8
PE
9107 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9108
abbd3d23
PE
9109 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9110 for characters.
9111
684a03ef
PE
9112 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9113
0fed43f3
PE
9114 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9115 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9116 incorrectly succeed when S was a string, because 4294967386 was
9117 truncated before it was used.
9118
8fd02eb7
PE
9119 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9120 Otherwise, an out-of-range integer could cause undefined behavior
9121 on a 64-bit host.
9122
f8c86b69
PE
9123 * composite.c: Use int, not EMACS_INT, for characters.
9124 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9125 EMACS_INT, for values that are known to be in character range.
9126 This doesn't fix any bugs but is the usual style inside Emacs and
9127 may generate better code on 32-bit machines.
9128
34206dd2
PE
9129 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9130 This is for reasons similar to the recent CHAR_STRING fix.
9131 * charset.c (Fencode_char): Check that character arg is actually
9132 a character. Pass an int to ENCODE_CHAR.
9133 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9134 wider than 'int', as a compile-time check to prevent future regressions
9135 in this area.
9136
c5958d4c 9137 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9138
9139 Make sure a 64-bit char is never passed to CHAR_STRING.
9140 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9141 by silently ignoring the top 32 bits, allowing some values
9142 that were far too large to be valid characters.
9143 * character.h: Include <verify.h>.
9144 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9145 arguments are no wider than unsigned, as a compile-time check
9146 to prevent future regressions in this area.
9147 * data.c (Faset):
01103c44 9148 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9149 (Fsubst_char_in_region):
9150 * fns.c (concat):
9151 * xdisp.c (decode_mode_spec_coding):
9152 Adjust to CHAR_STRING's new requirement.
9153 * editfns.c (Finsert_char, Fsubst_char_in_region):
9154 * fns.c (concat): Check that character args are actually
9155 characters. Without this test, these functions did the wrong
9156 thing with wildly out-of-range values on 64-bit hosts.
9157
d37ca623
PE
9158 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9159 These casts should not be needed on 32-bit hosts, either.
9160 * keyboard.c (read_char):
9161 * lread.c (Fload): Remove casts to unsigned.
9162
ea204efb
PE
9163 * lisp.h (UNSIGNED_CMP): New macro.
9164 This fixes comparison bugs on 64-bit hosts.
9165 (ASCII_CHAR_P): Use it.
9166 * casefiddle.c (casify_object):
01103c44 9167 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9168 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9169 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9170 * dispextern.h (FACE_FROM_ID):
9171 * keyboard.c (read_char): Use UNSIGNED_CMP.
9172
41cb286c
PE
9173 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9174 not to EMACS_INT, to avoid GCC warning.
9175
4a1b9832
PE
9176 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9177
55daad71
PE
9178 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9179 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9180 isn't needed on 32-bit machines.
8f95c75c 9181
01103c44
PE
9182 * buffer.c (Fgenerate_new_buffer_name):
9183 Use EMACS_INT for count, not int.
0ceccced 9184 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9185
9186 * data.c (Qcompiled_function): Now static.
9187
c6f072e7
PE
9188 * window.c (window_body_lines): Now static.
9189
20ce5912
PE
9190 * image.c (gif_load): Rename local to avoid shadowing.
9191
9c4c5f81
PE
9192 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9193 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9194 * alloc.c (make_save_value): Integer argument is now of type
9195 ptrdiff_t, not int.
9196 (mark_object): Use ptrdiff_t, not int.
9197 * lisp.h (pD): New macro.
9198 * print.c (print_object): Use it.
9199
c0c5c8ae
PE
9200 * alloc.c: Use EMACS_INT, not int, to count objects.
9201 (total_conses, total_markers, total_symbols, total_vector_size)
9202 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9203 (total_free_floats, total_floats, total_free_intervals)
9204 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9205 Now EMACS_INT, not int. All uses changed.
9206 (Fgarbage_collect): Compute overall total using a double, so that
9207 integer overflow is less likely to be a problem. Check for overflow
9208 when converting back to an integer.
5a25e253
PE
9209 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9210 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9211 These were 'int' variables that could overflow on 64-bit hosts;
9212 they were never used, so remove them instead of repairing them.
211a0b2a 9213 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9214 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9215 Previously, this ceilinged at INT_MAX, but that doesn't work on
9216 64-bit machines.
e46bb31a 9217 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9218
c78baabf 9219 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9220 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9221 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9222 when a (possibly-narrower) signed value would do just as well.
9223 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9224
c9d624c6
PE
9225 * alloc.c: Catch some string size overflows that we were missing.
9226 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9227 for convenience in STRING_BYTES_MAX.
9228 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9229 The definition here is exact; the one in lisp.h was approximate.
9230 (allocate_string_data): Check for string overflow. This catches
9231 some instances we weren't catching before. Also, it catches
9232 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9233 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9234 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9235
c9d624c6
PE
9236 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9237 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9238 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9239
353032ce
PE
9240 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9241
2bccce07
PE
9242 * alloc.c (Fmake_string): Check for out-of-range init.
9243
0ac30604
SM
92442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9245
9246 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9247
c195f2de
JD
92482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9249
9250 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9251 xg_get_default_scrollbar_width.
9252
9253 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9254 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9255 (style_changed_cb): Call update_theme_scrollbar_width and call
9256 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9257 all frames (Bug#8505).
9258 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9259 Call gtk_window_set_resizable if HAVE_GTK3.
9260 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9261 and height if HAVE_GTK3 (Bug#8505).
9262 (scroll_bar_width_for_theme): New variable.
9263 (update_theme_scrollbar_width): New function.
9264 (xg_get_default_scrollbar_width): Move code to
9265 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9266 (xg_initialize): Call update_theme_scrollbar_width.
9267
9268 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9269
9270 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9271
e10ac9f1
MR
92722011-06-12 Martin Rudalics <rudalics@gmx.at>
9273
9274 * frame.c (make_frame): Call other_buffer_safely instead of
9275 other_buffer.
9276
9277 * window.c (temp_output_buffer_show): Call display_buffer with
9278 second argument Vtemp_buffer_show_specifiers and reset latter
9279 immediately after the call.
9280 (Vtemp_buffer_show_specifiers): New variable.
9281 (auto_window_vscroll_p, next_screen_context_lines)
9282 (Vscroll_preserve_screen_position): Remove leading asterisks from
9283 doc-strings.
9284
2d3c217e 92852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9286
7b7f97e8 9287 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9288 * buffer.c (Qclone_number): Remove for now, as it's unused.
9289 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9290 (record_buffer): Remove unused local.
9291 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9292 (set_frame_buffer_list): Remove; unused.
9293 * frame.h (other_visible_frames): Remove decl.
9294 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9295 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9296 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9297 if HAVE_GPM.
9298 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9299 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9300 Define only if HAVE_GPM.
9301 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9302 (update_hints_inhibit): Remove; never set. All uses removed.
9303 * widgetprv.h (emacsFrameClassRec): Remove decl.
9304 * window.c (delete_deletable_window): Now returns void, since it
9305 wasn't returning anything.
9306 (compare_window_configurations): Remove unused locals.
9307 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9308 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9309 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9310 the same widths as pointers. This follows up on the 2011-05-06 patch.
9311 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9312 * xterm.h: Likewise.
9313 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9314
1384b89e
JB
93152011-06-12 Juanma Barranquero <lekktu@gmail.com>
9316
9317 * makefile.w32-in: Update dependencies.
9318 (LISP_H): Add lib/intprops.h.
9319
1100a63c
CY
93202011-06-11 Chong Yidong <cyd@stupidchicken.com>
9321
9322 * image.c (gif_load): Add animation frame delay to the metadata.
9323 (syms_of_image): Use DEFSYM. New symbol `delay'.
9324
6198ccd0
MR
93252011-06-11 Martin Rudalics <rudalics@gmx.at>
9326
9327 * window.c (delete_deletable_window): Re-add.
9328 (Fset_window_configuration): Rewrite to handle dead buffers and
9329 consequently deletable windows.
9330 (window_tree, Fwindow_tree): Remove. Supply functionality in
9331 window.el.
9332 (compare_window_configurations): Simplify code.
9333
b6e3633c
AS
93342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9335
1ab0dee5
AS
9336 * image.c (imagemagick_load_image): Fix type mismatch.
9337 (Fimagemagick_types): Likewise.
9338
b6e3633c
AS
9339 * window.h (replace_buffer_in_windows): Declare.
9340
9397e56f
MR
93412011-06-11 Martin Rudalics <rudalics@gmx.at>
9342
9343 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9344 Qclone_number. Remove external declaration of Qdelete_window.
9345 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9346 code.
640c8776
SM
9347 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9348 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9349 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9350 buffer list implementation.
9351 (other_buffer_safely): New function.
9352 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9353 calls to replace_buffer_in_windows and
9354 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9355 if allowed.
9356 (record_buffer): Inhibit quitting and rewrite using quittable
9357 functions. Run Qbuffer_list_update_hook if allowed.
9358 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9359 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9360 Move switch-to-buffer to window.el.
9397e56f
MR
9361 (bury-buffer): Move to window.el.
9362 (Vbuffer_list_update_hook): New variable.
9363
9364 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9365 section.
9366
9367 * window.h (resize_frame_windows): Move up in code.
9368 (Fwindow_frame): Remove EXFUN.
9369 (replace_buffer_in_all_windows): Remove prototype.
9370 (replace_buffer_in_windows_safely): Add prototype.
9371
9372 * window.c: Declare Qdelete_window static again. Move down
9373 declaration of select_count.
9374 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9375 (Fother_window): Move to window.el.
9376 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9377 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9378 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9379 window.el.
9380 (replace_buffer_in_windows): Implement by calling
9381 Qreplace_buffer_in_windows.
9382 (replace_buffer_in_all_windows): Remove with some functionality
9383 moved into replace_buffer_in_windows_safely.
9384 (replace_buffer_in_windows_safely): New function.
9385 (select_window_norecord, select_frame_norecord): Move in front
9386 of run_window_configuration_change_hook. Remove now obsolete
9387 declarations.
640c8776
SM
9388 (Fset_window_buffer): Rewrite doc-string.
9389 Call Qrecord_window_buffer.
9397e56f
MR
9390 (keys_of_window): Move binding for other-window to window.el.
9391
b50691aa
CY
93922011-06-11 Chong Yidong <cyd@stupidchicken.com>
9393
9394 * dispextern.h (struct image): Replace data member, whose int_val
9395 and ptr_val fields were not used by anything, with a single
9396 lisp_val object.
9397
9398 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9399 (gif_clear_image, gif_load, imagemagick_load_image)
9400 (gs_clear_image, gs_load): Callers changed.
9401
3f754b86
PE
94022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9403
cca69397
PE
9404 * buffer.h: Include <time.h>, for time_t.
9405 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9406
109e28d0
PE
9407 Fix minor problems found by static checking.
9408
60737f02
PE
9409 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9410
4b66faf3
PE
9411 Make identifiers static if they are not used in other modules.
9412 * data.c (Qcompiled_function, Qframe, Qvector):
9413 * image.c (QimageMagick, Qsvg):
9414 * minibuf.c (Qmetadata):
9415 * window.c (resize_window_check, resize_root_window): Now static.
9416 * window.h (resize_window_check, resize_root_window): Remove decls.
9417
109e28d0
PE
9418 * window.c (window_deletion_count, delete_deletable_window):
9419 Remove; unused.
46a4ce9e
PE
9420 (window_body_lines): Now static.
9421 (Fdelete_other_windows_internal): Mark vars as initialized.
9422 Make sure 'resize_failed' is initialized.
9423 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9424 (resize_window_apply): Remove unused local.
9425 * window.h (delete_deletable_window): Remove decl.
9426
109e28d0 9427 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9428 (imagemagick_load_image): Fix pointer signedness problem by changing
9429 last arg from unsigned char * to char *. All uses changed.
9430 Also, fix a local for similar reasons.
9431 Remove unused locals. Remove locals to avoid shadowing.
9432 (fn_rsvg_handle_free): Remove; unused.
9433 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9434 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9435
3f754b86
PE
9436 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9437
2547adb1
CY
94382011-06-10 Chong Yidong <cyd@stupidchicken.com>
9439
9440 * image.c (gif_load): Fix omitted cast error introduced by
9441 2011-06-06 change.
9442
2c8e37d4
MR
94432011-06-10 Martin Rudalics <rudalics@gmx.at>
9444
9445 * window.h (resize_proportionally, orig_total_lines)
9446 (orig_top_line): Remove from window structure.
9447 (set_window_height, set_window_width, change_window_heights)
9448 (Fdelete_window): Remove prototypes.
9449 (resize_frame_windows): Remove duplicate declaration.
9450
440a42e3
EZ
94512011-06-10 Eli Zaretskii <eliz@gnu.org>
9452
9453 * window.h (resize_frame_windows, resize_window_check)
9454 (delete_deletable_window, resize_root_window)
9455 (resize_frame_windows): Declare prototypes.
9456
9457 * window.c (resize_window_apply): Make definition be "static" to
9458 match the prototype.
9459
562dd5e9
MR
94602011-06-10 Martin Rudalics <rudalics@gmx.at>
9461
9462 * window.c: Remove declarations of Qwindow_size_fixed,
9463 window_min_size_1, window_min_size_2, window_min_size,
9464 size_window, window_fixed_size_p, enlarge_window, delete_window.
9465 Remove static from declaration of Qdelete_window, it's
9466 temporarily needed by Fbury_buffer.
9467 (replace_window): Don't assign orig_top_line and
9468 orig_total_lines.
9469 (Fdelete_window, delete_window): Remove. Window deletion is
9470 handled by window.el.
640c8776
SM
9471 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9472 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9473 (Fdelete_other_windows): Remove. Deleting other windows is
9474 handled by window.el.
9475 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9476 handled in window.el.
9477 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9478 Window minimum sizes are handled in window.el.
9479 (shrink_windows, size_window, set_window_height)
9480 (set_window_width, change_window_heights, window_height)
9481 (window_width, CURBEG, CURSIZE, enlarge_window)
9482 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9483 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9484 handled in window.el.
9485 (make_dummy_parent): Rename to make_parent_window and give it a
9486 second argument horflag.
9487 (make_window): Don't set resize_proportionally any more.
9488 (Fsplit_window): Remove. Windows are split in window.el.
9489 (save_restore_action, save_restore_orig_size)
9490 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9491 Resize mini windows in window.el.
9492 (grow_mini_window, shrink_mini_window): Implement by calling
9493 Qresize_root_window_vertically, resize_window_check and
9494 resize_window_apply.
640c8776
SM
9495 (saved_window, Fset_window_configuration, save_window_save):
9496 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9497 resize_proportionally.
9498 (window_min_height, window_min_width): Move to window.el.
9499 (keys_of_window): Move bindings for delete-other-windows,
9500 split-window, delete-window and enlarge-window to window.el.
9501
9502 * buffer.c: Temporarily extern Qdelete_window.
9503 (Fbury_buffer): Temporarily call Qdelete_window instead of
9504 Fdelete_window (Fbury_buffer will move to window.el soon).
9505
9506 * frame.c (set_menu_bar_lines_1): Remove code handling
9507 orig_top_line and orig_total_lines.
9508
9509 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9510 set_window_height but set heights directly.
9511 (change_frame_size_1): Use resize_frame_windows.
9512
9513 * xdisp.c (init_xdisp): Don't use set_window_height but set
9514 heights directly.
9515
640c8776
SM
9516 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9517 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9518 run_window_configuration_change_hook.
9519
9520 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9521 instead of change_window_heights and run
9522 run_window_configuration_change_hook.
9523
1a13852e
MR
95242011-06-09 Martin Rudalics <rudalics@gmx.at>
9525
9526 * window.c (replace_window): Rename second argument REPLACEMENT to
9527 NEW. New third argument SETFLAG. Rewrite.
9528 (delete_window, make_dummy_parent): Call replace_window with
9529 third argument 1.
9530 (window_list_1): Move down in code.
9531 (run_window_configuration_change_hook): Move set_buffer part
9532 before select_frame_norecord part in order to unwind correctly.
9533 Rename count1 to count.
9534 (recombine_windows, delete_deletable_window, resize_root_window)
9535 (Fdelete_other_windows_internal)
9536 (Frun_window_configuration_change_hook, make_parent_window)
9537 (resize_window_check, resize_window_apply, Fresize_window_apply)
9538 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9539 (Fdelete_window_internal, Fresize_mini_window_internal):
9540 New functions.
1a13852e
MR
9541 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9542
f3d1777e
MR
95432011-06-08 Martin Rudalics <rudalics@gmx.at>
9544
496e208e
MR
9545 * window.h (window): Add some new members to window structure -
9546 normal_lines, normal_cols, new_total, new_normal, clone_number,
9547 splits, nest, prev_buffers, next_buffers.
9548 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9549 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9550
f3d1777e
MR
9551 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9552 Remove.
496e208e
MR
9553 (make_dummy_parent): Set new members of windows structure.
9554 (make_window): Move down in code. Handle new members of window
9555 structure.
9556 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9557 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9558 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9559 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9560 (Fset_window_next_buffers, Fset_window_clone_number):
9561 New functions.
496e208e
MR
9562 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9563 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9564 Doc-string fixes.
9565 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9566 Argument WINDOW can be now internal window too.
9567 (Fwindow_use_time): Move up in code.
9568 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9569 Rewrite doc-string.
9570 (Fset_window_configuration, saved_window)
9571 (Fcurrent_window_configuration, save_window_save): Handle new
9572 members of window structure.
b9e809c2
MR
9573 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9574 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9575 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9576 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9577 Qget_mru_window, Qresize_root_window,
9578 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9579 Qauto_buffer_name; staticpro them.
f3d1777e 9580
abde8f8c
MR
95812011-06-07 Martin Rudalics <rudalics@gmx.at>
9582
9583 * window.c (Fwindow_total_size, Fwindow_left_column)
9584 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9585 (Fwindow_list_1): New functions.
9586 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9587 (Fwindow_width, Fscroll_left, Fscroll_right):
9588 Use window_body_cols instead of window_box_text_cols.
9589 (delete_window, Fset_window_configuration):
9590 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9591 (delete_all_subwindows): Take a window as argument and not a
9592 structure. Rewrite.
190b47e6
MR
9593 (window_loop): Remove handling of GET_LRU_WINDOW and
9594 GET_LARGEST_WINDOW.
9595 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9596
9597 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9598 window_box_text_cols. delete_all_subwindows now takes a
9599 Lisp_Object as argument.
abde8f8c 9600
640c8776
SM
9601 * indent.c (compute_motion, Fcompute_motion):
9602 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9603
fa8a67e6
MR
9604 * frame.c (delete_frame): Call delete_all_subwindows with root
9605 window as argument.
9606
a54e3482
DC
96072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9608
9609 * fns.c (Fputhash): Document return value.
9610
60002bf5
CY
96112011-06-06 Chong Yidong <cyd@stupidchicken.com>
9612
9613 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9614
0c671da6 96152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9616
b862a52a 9617 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9618
be44ca6c
PE
9619 Check for overflow when converting integer to cons and back.
9620 * charset.c (Fdefine_charset_internal, Fdecode_char):
9621 Use cons_to_unsigned to catch overflow.
9622 (Fencode_char): Use INTEGER_TO_CONS.
9623 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9624 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9625 * data.c (long_to_cons, cons_to_long): Remove.
9626 (cons_to_unsigned, cons_to_signed): New functions.
9627 These signal an error for invalid or out-of-range values.
9628 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9629 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9630 * font.c (Ffont_variation_glyphs):
9631 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9632 * lisp.h: Include <intprops.h>.
9633 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9634 (cons_to_signed, cons_to_unsigned): New decls.
9635 (long_to_cons, cons_to_long): Remove decls.
9636 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9637 (Fprimitive_undo): Use CONS_TO_INTEGER.
9638 * xfns.c (Fx_window_property): Likewise.
9639 * xselect.c: Include <limits.h>.
9640 (x_own_selection, selection_data_to_lisp_data):
9641 Use INTEGER_TO_CONS.
9642 (x_handle_selection_request, x_handle_selection_clear)
9643 (x_get_foreign_selection, Fx_disown_selection_internal)
9644 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9645 (lisp_data_to_selection_data): Use cons_to_unsigned.
9646 (x_fill_property_data): Use cons_to_signed.
9647 Report values out of range.
9648
d1f3d2af
PE
9649 Check for buffer and string overflow more precisely.
9650 * buffer.h (BUF_BYTES_MAX): New macro.
9651 * lisp.h (STRING_BYTES_MAX): New macro.
9652 * alloc.c (Fmake_string):
9653 * character.c (string_escape_byte8):
9654 * coding.c (coding_alloc_by_realloc):
9655 * doprnt.c (doprnt):
9656 * editfns.c (Fformat):
9657 * eval.c (verror):
9658 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9659 since they may not be the same number.
9660 * editfns.c (Finsert_char):
9661 * fileio.c (Finsert_file_contents):
9662 Likewise for BUF_BYTES_MAX.
9663
dd52fcea
PE
9664 * image.c: Use ptrdiff_t, not int, for sizes.
9665 (slurp_file): Switch from int to ptrdiff_t.
9666 All uses changed.
9667 (slurp_file): Check that file size fits in both size_t (for
9668 malloc) and ptrdiff_t (for sanity and safety).
9669
7f9bbdbb
PE
9670 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9671 if b->modtime has its maximal value.
9672
dfe18f82
PE
9673 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9674
84acfcf0
PE
9675 Don't assume time_t can fit into int.
9676 * buffer.h (struct buffer.modtime): Now time_t, not int.
9677 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9678 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9679
ccd9a01a
PE
9680 Minor fixes for signed vs unsigned integers.
9681 * character.h (MAYBE_UNIFY_CHAR):
9682 * charset.c (maybe_unify_char):
9683 * keyboard.c (read_char, reorder_modifiers):
9684 XINT -> XFASTINT, since the integer must be nonnegative.
9685 * ftfont.c (ftfont_spec_pattern):
9686 * keymap.c (access_keymap, silly_event_symbol_error):
9687 XUINT -> XFASTINT, since the integer must be nonnegative.
9688 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9689 since it makes no difference and we prefer signed.
9690 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9691 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9692 nonnegative.
9693
d6d100dd
SM
96942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9695
9696 * window.h (Fwindow_frame): Declare.
9697
2b6148e4
PE
96982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9699
9700 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9701 (SPARE_MEMORY): Always define.
9702 (LARGE_REQUEST): Remove.
9703 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9704
f230ecc9
MR
97052011-06-06 Martin Rudalics <rudalics@gmx.at>
9706
727e958e
MR
9707 * lisp.h: Move EXFUNS for Fframe_root_window,
9708 Fframe_first_window and Fset_frame_selected_window to window.h.
9709
9710 * window.h: Move EXFUNS for Fframe_root_window,
9711 Fframe_first_window and Fset_frame_selected_window here from
9712 lisp.h.
9713
9714 * frame.c (Fwindow_frame, Fframe_first_window)
9715 (Fframe_root_window, Fframe_selected_window)
9716 (Fset_frame_selected_window): Move to window.c.
9717 (Factive_minibuffer_window): Move to minibuf.c.
9718 (Fother_visible_frames_p): New function.
9719
9720 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9721
f230ecc9
MR
9722 * window.c (decode_window, decode_any_window): Move up in code.
9723 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9724 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9725 (Fwindow_buffer): Move up and rewrite doc-string.
9726 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9727 (Fwindow_prev): New functions.
727e958e
MR
9728 (Fwindow_frame): Move here from frame.c. Accept any window as
9729 argument.
9730 (Fframe_root_window, Fframe_first_window)
9731 (Fframe_selected_window): Move here from frame.c. Accept frame
9732 or arbitrary window as argument. Update doc-strings.
9733 (Fminibuffer_window): Move up in code.
9734 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9735 (Fset_frame_selected_window): Move here from frame.c.
9736 Marginal rewrite.
727e958e
MR
9737 (Fselected_window, select_window, Fselect_window): Move up in
9738 code. Minor doc-string fixes.
f230ecc9 9739
4d09bcf6
PE
97402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9741
9742 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9743 Do not assume that spare memory exists; that assumption is valid
9744 only if SYSTEM_MALLOC.
9745 (LARGE_REQUEST): New macro, so that the issue of large requests
9746 is separated from the issue of spare memory.
9747
810928a2
AS
97482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9749
172418ad
AS
9750 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9751 format. (Bug#8806)
9752
43f862f7
AS
9753 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9754
810928a2
AS
9755 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9756 before statements.
9757
a059fe24
JD
97582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9759
9760 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9761
9762 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9763
9764 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9765 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9766
989bf368
JB
97672011-06-05 Juanma Barranquero <lekktu@gmail.com>
9768
9769 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9770
4b80f674
CY
97712011-06-04 Chong Yidong <cyd@stupidchicken.com>
9772
9773 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9774 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9775 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9776 New error handlers.
4b80f674
CY
9777 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9778 Obey Vx_select_enable_clipboard_manager. Catch errors in
9779 x_clipboard_manager_save (Bug#8779).
9780 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9781 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9782
99a33b77 97832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9784
9785 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9786
99a33b77 97872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9788
9789 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9790 in the current matrix if keep_current_p is non-zero.
9791
8264569d
EZ
97922011-06-04 Eli Zaretskii <eliz@gnu.org>
9793
9794 * bidi.c (bidi_level_of_next_char): Fix last change.
9795
57f97249
EZ
97962011-06-03 Eli Zaretskii <eliz@gnu.org>
9797
fec2107c 9798 Support bidi reordering of text covered by display properties.
57f97249 9799
fec2107c
EZ
9800 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9801 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9802 (bidi_cache_search, bidi_cache_iterator_state)
9803 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9804 (bidi_level_of_next_char, bidi_move_to_visually_next):
9805 Support character positions inside a run of characters covered by a
fec2107c
EZ
9806 display string.
9807 (bidi_paragraph_init, bidi_resolve_explicit_1)
9808 (bidi_level_of_next_char): Call bidi_fetch_char and
9809 bidi_fetch_char_advance instead of FETCH_CHAR and
9810 FETCH_CHAR_ADVANCE.
9811 (bidi_init_it): Initialize new members.
9812 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9813 definitions.
9814 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9815 instead of using explicit *_CHAR codes.
d6d100dd
SM
9816 (bidi_resolve_explicit, bidi_resolve_weak):
9817 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9818 bidirectional text is supported only in multibyte buffers.
9819 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9820 it to initialize the frame_window_p member of struct bidi_it.
9821 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9822 (bidi_resolve_explicit, bidi_resolve_weak)
9823 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9824 bidi_it->nchars is non-positive.
9825 (bidi_level_of_next_char): Don't try to lookup the cache for the
9826 next/previous character if nothing is cached there yet, or if we
9827 were just reseat()'ed to a new position.
c40e2fb2 9828
0e14fe90
EZ
9829 * xdisp.c (set_cursor_from_row): Set start and stop points
9830 according to the row's direction when priming the loop that looks
9831 for the glyph on which to display cursor.
9832 (single_display_spec_intangible_p): Function deleted.
9833 (display_prop_intangible_p): Reimplement to call
9834 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9835 Accept 3 additional arguments needed by handle_display_spec.
9836 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9837 values: lists, `(when COND...)' forms, etc.
9838 (single_display_spec_string_p): Support property values that are
9839 lists with the argument STRING its top-level element.
9840 (display_prop_string_p): Fix the condition for processing a
9841 property that is a list to be consistent with handle_display_spec.
fec2107c 9842 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9843 last portion of handle_display_prop.
9844 (compute_display_string_pos): Accept additional argument
9845 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9846 value of a `display' property is a "replacing spec".
9847 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9848 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9849 the display property, but just return a value indicating whether
9850 the display property will replace the characters it covers.
9851 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9852 frame_window_p members of struct bidi_it.
d6d100dd
SM
9853 (compute_display_string_pos, compute_display_string_end):
9854 New functions.
fec2107c
EZ
9855 (push_it): Accept second argument POSITION, where pop_it should
9856 jump to continue iteration.
9857 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9858
fec2107c
EZ
9859 * keyboard.c (adjust_point_for_property): Adjust the call to
9860 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9861
9862 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9863 (bidi_init_it): Update prototypes.
9864 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9865 (compute_display_string_pos, compute_display_string_end):
9866 Declare prototypes.
fec2107c
EZ
9867 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9868 EMACS_INT.
fc6f18ce 9869
40087514 98702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9871
57f53182
PE
9872 Malloc failure behavior now depends on size of allocation.
9873 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9874 * lisp.h: Change signatures accordingly.
9875 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9876 All callers changed. (Bug#8762)
9877
9878 * gnutls.c: Use Emacs's memory allocators.
9879 Without this change, the gnutls library would invoke malloc etc.
9880 directly, which causes problems on non-SYNC_INPUT hosts, and which
9881 runs afoul of improving memory_full behavior. (Bug#8761)
9882 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9883 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9884 xfree instead of the default malloc, realloc, free.
9885 (Fgnutls_boot): No need to check for memory allocation failure,
9886 since xmalloc does that for us.
9887
ac32cd99 9888 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9889 * category.c (hash_get_category_set):
9890 * ccl.c (ccl_driver):
9891 * charset.c (Fdefine_charset_internal):
9892 * charset.h (struct charset.hash_index):
9893 * composite.c (get_composition_id, gstring_lookup_cache)
9894 (composition_gstring_put_cache):
9895 * composite.h (struct composition.hash_index):
9896 * dispextern.h (struct image.hash):
9897 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9898 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9899 (hashfn_equal, hashfn_user_defined, make_hash_table)
9900 (maybe_resize_hash_table, hash_lookup, hash_put)
9901 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9902 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9903 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9904 * image.c (make_image, search_image_cache, lookup_image)
9905 (xpm_put_color_table_h):
9906 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9907 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9908 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9909 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9910 * alloc.c (allocate_vectorlike):
9911 Check for overflow in vector size calculations.
9912 * ccl.c (ccl_driver):
9913 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9914 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9915 need to be updated by these changes.
40087514
PE
9916 * fns.c (make_hash_table, maybe_resize_hash_table):
9917 Check for integer overflow with large hash tables.
0de4bb68
PE
9918 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9919 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9920 (SXHASH_REDUCE): New macro.
9921 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9922 Use it instead of discarding useful hash info with large hash values.
9923 (sxhash_float): New function.
9924 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9925 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9926 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9927 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9928 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9929 Adjust signatures to match updated version of code.
9930 (consing_since_gc): Now EMACS_INT, since a single hash table can
9931 use more than INT_MAX bytes.
9932
698d32e2
DN
99332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9934
9935 Make it possible to build with GCC-4.6+ -O2 -flto.
9936
9937 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9938
fd6fa53f
SM
99392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9940
9941 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9942 Call minibuffer-inactive-mode.
9943
864db017
JB
99442011-05-31 Juanma Barranquero <lekktu@gmail.com>
9945
9946 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9947 Update dependencies.
9948
2ad0baf4
DN
99492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9950
9951 * data.c (init_data): Remove code for UTS, this system is not
9952 supported anymore.
9953
4fcc2638
DN
99542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9955
9956 Don't force ./temacs to start in terminal mode.
9957
9958 * frame.c (make_initial_frame): Initialize faces in all cases, not
9959 only when CANNOT_DUMP is defined.
9960 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9961
c56e0fd5
DN
99622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9963
9964 * dispnew.c (add_window_display_history): Use const for the string
9965 pointer. Remove declaration, not needed.
9966
333d54da 99672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9968
55d4c1b2 9969 Use 'inline', not 'INLINE'.
333d54da 9970 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9971 * alloc.c, fontset.c (INLINE): Remove.
9972 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9973 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9974 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9975 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9976 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9977
738db178
DN
99782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9979
9980 Make it possible to run ./temacs.
9981
9982 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9983 syms_of_callproc does the same thing. Remove test for
9984 "initialized", do it in the caller.
9985 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9986
620c53a6
SM
99872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9988
9989 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9990 (read_minibuf): Use get_minibuffer.
9991 (syms_of_minibuf): Use DEFSYM.
9992 (Qmetadata): New var.
9993 * data.c (Qbuffer): Don't make it static.
9994 (syms_of_data): Use DEFSYM.
9995
e003a292
PE
99962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9997
9998 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9999 (CCL_CODE_MIN): New macro.
10000
ed008a6d
PE
100012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10002
3687c2ef
PE
10003 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10004
ed008a6d
PE
10005 * eval.c (Qdebug): Now static.
10006 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10007 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10008 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10009
d66c4c7c
CY
100102011-05-29 Chong Yidong <cyd@stupidchicken.com>
10011
10012 * image.c: Various fixes to ImageMagick code comments.
10013 (Fimagemagick_types): Doc fix.
10014
5fbc2025
PE
100152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10016
0196f88a
PE
10017 Minor fixes prompted by GCC 4.6.0 warnings.
10018
10019 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10020
5fbc2025
PE
10021 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10022 (x_clipboard_manager_save_all): Move extern decl to ...
10023 * xterm.h: ... here, so that it can be checked for consistency.
10024
1dd3c2d9
CY
100252011-05-29 Chong Yidong <cyd@stupidchicken.com>
10026
10027 * xselect.c (x_clipboard_manager_save_frame)
10028 (x_clipboard_manager_save_all): New functions.
10029 (Fx_clipboard_manager_save): Lisp function deleted.
10030
10031 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10032 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10033
10034 * xterm.h: Update prototype.
10035
5ba6571d
WX
100362011-05-28 William Xu <william.xwl@gmail.com>
10037
10038 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10039 exiting (Bug#8239).
10040
3eaff834
JM
100412011-05-28 Jim Meyering <meyering@redhat.com>
10042
e1900994 10043 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10044 * fns.c (to_uchar): Define.
10045 (crypto_hash_function): Use it to convert some newly-signed
10046 variables to unsigned, to avoid sign-extension bugs. For example,
10047 without this change, (md5 "truc") would evaluate to
10048 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10049 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10050 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10051
0f6990a7
PE
100522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10053
10054 Integer overflow fixes.
c8a9ca5a 10055
08686060
PE
10056 * dbusbind.c: Serial number integer overflow fixes.
10057 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10058 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10059 to hold a serial number that is too large for a fixnum.
10060 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10061 Check for serial numbers out of range. Decode any serial number
59568bf0 10062 that was so large that it became a float. (Bug#8722)
08686060 10063
2d1fc3c7
PE
10064 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10065 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10066 Use XFASTINT rather than XUINT when numbers are nonnegative.
10067 (xd_append_arg, Fdbus_method_return_internal):
10068 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10069 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10070 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10071 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10072 (Bug#8722)
2d1fc3c7 10073
c8a9ca5a
PE
10074 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10075
519e1d69
PE
10076 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10077
6df6ae42 10078 ccl: Add integer overflow checks.
30569699
PE
10079 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10080 (IN_INT_RANGE): New macros.
10081 (ccl_driver): Use them to check for integer overflow when
10082 decoding a CCL program. Many of the new checks are whether XINT (x)
10083 fits in int; it doesn't always, on 64-bit hosts. The new version
10084 doesn't catch all possible integer overflows, but it's an
847044ea 10085 improvement. (Bug#8719)
30569699 10086
c11285dc
PE
10087 * alloc.c (make_event_array): Use XINT, not XUINT.
10088 There's no need for unsigned here.
10089
fdccd48e
PE
10090 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10091 This follows up to the 2011-05-06 change that substituted uintptr_t
10092 for EMACS_INT. This case wasn't caught back then.
10093
37910ab2
PE
10094 Rework Fformat to avoid integer overflow issues.
10095 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10096 now (part of C89). Include <verify.h>.
10097 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10098 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10099 (Fformat): Avoid the prepass trying to compute sizes; it was only
10100 approximate and thus did not catch overflow reliably. Instead, walk
10101 through the format just once, formatting and computing sizes as we go,
10102 checking for integer overflow at every step, and allocating a larger
10103 buffer as needed. Keep track separately whether the format is
10104 multibyte. Keep only the most-recently calculated precision, rather
10105 than them all. Record whether each argument has been converted to
10106 string. Use EMACS_INT, not int, for byte and char and arg counts.
10107 Support field widths and precisions larger than INT_MAX. Avoid
10108 sprintf's undefined behavior with conversion specifications such as %#d
10109 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10110 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10111 formatting out-of-range floating point numbers with int
9173deec 10112 formats. (Bug#8668)
37910ab2 10113
2e6578fb
PE
10114 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10115
0ae6bdee
PE
10116 * data.c: Avoid integer truncation in expressions involving floats.
10117 * data.c: Include <intprops.h>.
10118 (arith_driver): When there's an integer overflow in an expression
10119 involving floating point, convert the integers to floating point
10120 so that the resulting value does not suffer from catastrophic
10121 integer truncation. For example, on a 64-bit host (* 4
10122 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10123 Do not rely on undefined behavior after integer overflow.
10124
de883a70
PE
10125 merge count_size_as_multibyte, parse_str_to_multibyte
10126 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10127 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10128 Check for integer overflow.
10129 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10130 since it's now a duplicate of the other. This is more of
10131 a character than a buffer op, so better that it's in character.c.
10132 * fns.c, print.c: Adjust to above changes.
10133
2ff916cb
PE
101342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10135
10136 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10137
f1b54466
PE
101382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10139
fb1ac845
PE
10140 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10141 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10142 (x_clipboard_manager_save): Now static.
10143 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10144
f1b54466
PE
10145 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10146 (crypto_hash_function): Now static.
10147 Fix pointer signedness problems. Avoid unnecessary initializations.
10148
a9f737ee
CY
101492011-05-27 Chong Yidong <cyd@stupidchicken.com>
10150
10151 * termhooks.h (Vselection_alist): Make it terminal-local.
10152
10153 * terminal.c (create_terminal): Initialize it.
10154
10155 * xselect.c: Support for clipboard managers.
10156 (Vselection_alist): Move to termhooks.h as terminal-local var.
10157 (LOCAL_SELECTION): New macro.
10158 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10159 (symbol_to_x_atom): Remove gratuitous arg.
10160 (x_handle_selection_request, lisp_data_to_selection_data)
10161 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10162 (x_own_selection, x_get_local_selection, x_convert_selection):
10163 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10164 (some_frame_on_display): Delete unused function.
10165 (Fx_own_selection_internal, Fx_get_selection_internal)
10166 (Fx_disown_selection_internal, Fx_selection_owner_p)
10167 (Fx_selection_exists_p): New optional frame arg.
10168 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10169 (x_handle_selection_clear): Don't treat other terminals with the
10170 same keyboard specially. Use the terminal-local Vselection_alist.
10171 (x_clear_frame_selections): Use Frun_hook_with_args.
10172
10173 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10174
10175 * xterm.h: Add support for those atoms.
10176
e067f0c1
CY
101772011-05-26 Chong Yidong <cyd@stupidchicken.com>
10178
10179 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10180 (converted_selections, conversion_fail_tag): New global variables.
10181 (x_selection_request_lisp_error): Free the above.
10182 (x_get_local_selection): Remove unnecessary code.
10183 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10184 of converted selections stored in converted_selections.
10185 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10186 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10187 (x_convert_selection): New function.
10188 (x_handle_selection_event): Simplify.
10189 (x_get_foreign_selection): Don't ignore incoming requests while
10190 waiting for an answer; this will fail when we implement
10191 SAVE_TARGETS, and seems unnecessary anyway.
10192 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10193 (Vx_sent_selection_functions): Doc fix.
10194
0f4aebc0
LL
101952011-05-26 Leo Liu <sdl.web@gmail.com>
10196
10197 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10198
e61124cd
YM
101992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10200
10201 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10202
10203 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10204 for fringe update if it has periodic bitmap.
ac389d0c 10205 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10206 and fringe_bitmap_periodic_p.
10207
10208 * fringe.c (get_fringe_bitmap_data): New function.
10209 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10210 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10211 row. Mark glyph row for fringe update if periodicity changed.
10212
10213 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10214 for fringe update unless it has periodic bitmap.
10215
f16d9837
KH
102162011-05-25 Kenichi Handa <handa@m17n.org>
10217
10218 * xdisp.c (get_next_display_element): Set correct it->face_id for
10219 a static composition.
10220
e1b90ef6
LL
102212011-05-24 Leo Liu <sdl.web@gmail.com>
10222
10223 * deps.mk (fns.o):
10224 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10225
10226 * fns.c (crypto_hash_function, Fsha1): New function.
10227 (Fmd5): Use crypto_hash_function.
10228 (syms_of_fns): Add Ssha1.
10229
7400048f
PE
102302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10231
10232 * gnutls.c: Remove unused macros.
10233 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10234 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10235 Remove macros that are defined and never used.
10236 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10237
abb71cf4
CY
102382011-05-22 Chong Yidong <cyd@stupidchicken.com>
10239
10240 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10241 (Fx_get_selection_internal): Minor cleanup.
10242 (Fx_own_selection_internal): Rename arguments for consistency with
10243 select.el.
10244
6307db39
PE
102452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10246
10247 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10248
f3d4e0a4
CY
102492011-05-22 Chong Yidong <cyd@stupidchicken.com>
10250
10251 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10252
4d8ade89
YM
102532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10254
10255 * dispnew.c (scrolling_window): Don't exclude the case that the
10256 last enabled row in the desired matrix touches the bottom boundary.
10257
32078c8d
GM
102582011-05-21 Glenn Morris <rgm@gnu.org>
10259
10260 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10261 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10262 and add some more files.
32078c8d 10263
7285dc67
EZ
102642011-05-20 Eli Zaretskii <eliz@gnu.org>
10265
10266 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10267 report_file_error introduced by the change from 2011-05-07.
10268
89d1bd22
PE
102692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10270
10271 * systime.h (Time): Define only if emacs is defined.
10272 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10273 where the include path doesn't have X11/X.h by default. See
10274 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10275
cd394be1 102762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10277
10278 * composite.c (find_automatic_composition): Fix previous change.
10279
b9704ad9
GM
102802011-05-20 Glenn Morris <rgm@gnu.org>
10281
10282 * lisp.mk: New file, split from Makefile.in.
10283 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10284 (shortlisp): Remove.
10285 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10286
4a720484
GM
102872011-05-19 Glenn Morris <rgm@gnu.org>
10288
10289 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10290 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10291 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10292 (lisp): Set the order to that of loadup.el.
10293 (shortlisp): Make it a copy of $lisp.
10294 (SOME_MACHINE_LISP): Remove.
10295 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10296 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10297
a28d4396
KH
102982011-05-18 Kenichi Handa <handa@m17n.org>
10299
10300 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10301 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10302 (find_automatic_composition): Mostly rewrite for efficiency.
10303
a2b1fa8e
JB
103042011-05-18 Juanma Barranquero <lekktu@gmail.com>
10305
10306 * makefile.w32-in: Update dependencies.
10307
8e1f5610
CS
103082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10309
10310 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10311 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10312
7025ee00 103132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10314
cdfa6eab
PE
10315 Fix some integer overflow issues, such as string length overflow.
10316
06d6db33
PE
10317 * insdel.c (count_size_as_multibyte): Check for string overflow.
10318
2b4560a8
PE
10319 * character.c (lisp_string_width): Check for string overflow.
10320 Use EMACS_INT, not int, for string indexes and lengths; in
10321 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10322 the resulting string length overflows an EMACS_INT; instead,
10323 report a string overflow if no precision given. When checking for
10324 precision exhaustion, use a check that cannot possibly have
10325 integer overflow. (Bug#8675)
10326 * character.h (lisp_string_width): Adjust to new signature.
10327
cb93f9be
PE
10328 * alloc.c (string_overflow): New function.
10329 (Fmake_string): Use it. This doesn't change behavior, but saves
10330 a few bytes and will simplify future changes.
10331 * character.c (string_escape_byte8): Likewise.
10332 * lisp.h (string_overflow): New decl.
10333
1a1f3366
PE
10334 Fixups, following up to the user-interface timestamp change.
10335 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10336 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10337 * msdos.c (mouse_get_pos): Likewise.
10338 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10339 * w32gui.h (Time): Define by including "systime.h" rather than by
10340 declaring it ourselves. (Bug#8664)
10341
d4e3e4d3
PE
10342 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10343 * image.c (clear_image_cache): Likewise.
10344
f6a24d19
PE
10345 * term.c (term_mouse_position): Don't assume time_t wraparound.
10346
08dc5ae6
PE
10347 Be more systematic about user-interface timestamps.
10348 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10349 and sometimes 'EMACS_UINT', to represent these timestamps.
10350 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10351 This makes the code easier to follow, and makes it easier to catch
10352 integer overflow bugs such as Bug#8664.
10353 * frame.c (Fmouse_position, Fmouse_pixel_position):
10354 Use Time, not unsigned long, for user-interface timestamps.
10355 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10356 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10357 * keyboard.h (last_event_timestamp): Likewise.
10358 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10359 * menu.h (xmenu_show): Likewise.
10360 * term.c (term_mouse_position): Likewise.
10361 * termhooks.h (struct input_event.timestamp): Likewise.
10362 (struct terminal.mouse_position_hook): Likewise.
10363 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10364 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10365 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10366 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10367 what it was before.
10368 * menu.h, termhooks.h: Include "systime.h", for Time.
10369
8e55734a
PE
10370 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10371 Don't assume that the difference between two unsigned long values
10372 can fit into an integer. At this point, we know button_down_time
10373 <= event->timestamp, so the difference must be nonnegative, so
10374 there's no need to cast the result if double-click-time is
10375 nonnegative, as it should be; check that it's nonnegative, just in
10376 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10377 apart (about 25 days). (Bug#8664)
8e55734a 10378
841f1b75 10379 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10380 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10381
3e26f69c
PE
10382 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10383 that always fit in int. Use a sentinel instead of a counter, to
10384 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10385 * frame.h (struct frame): Use int for menu_bar_items_used
10386 instead of EMACS_INT, since it always fits in int.
3e26f69c 10387
5cc152c0
PE
10388 * menu.c (grow_menu_items): Check for int overflow.
10389
d89eb65e
PE
10390 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10391
5235bd3e
PE
10392 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10393 Before, the code was not consistent. These values cannot exceed
10394 2**31 - 1 so there's no need to make them unsigned.
10395 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10396 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10397 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10398 as modifiers.
10399 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10400
bc827e23
PE
10401 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10402 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10403 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10404 presumably because the widths might not match.
10405
78eb494e
PE
10406 * window.c (size_window): Avoid needless test at loop start.
10407
04f2d78b
CB
104082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10409
10410 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10411
d2fc7e3d 104122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10413
10414 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10415
d2fc7e3d 104162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10417
10418 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10419 `width' to `bar_area_x' and `bar_area_width', respectively.
10420 (x_scroll_run): Take account of fringe background extension.
10421
04f2d78b
CB
10422 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10423 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10424 `bar_area_width', respectively.
10425 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10426 background extension.
10427
79b70037
GM
104282011-05-10 Jim Meyering <meyering@redhat.com>
10429
10430 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10431
2f142cc5
JB
104322011-05-10 Juanma Barranquero <lekktu@gmail.com>
10433
10434 * image.c (Finit_image_library): Return t for built-in image types,
10435 like pbm and xbm. (Bug#8640)
10436
57679c86
AS
104372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10438
10439 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10440
888c9e86
EZ
104412011-05-07 Eli Zaretskii <eliz@gnu.org>
10442
b0512a1d
EZ
10443 * w32console.c (Fset_screen_color): Doc fix.
10444 (Fget_screen_color): New function.
10445 (syms_of_ntterm): Defsubr it.
10446
7285dc67
EZ
10447 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10448 unlink the temporary file if Fcall_process didn't create it in the
10449 first place.
10450 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10451 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10452 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10453 cue to call_process_cleanup not to close that handle.
10454
4d3fcc8e
BK
104552011-05-07 Ben Key <bkey76@gmail.com>
10456
10457 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10458 one of two shell specific rules, either bootstrap-temacs-CMD or
10459 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10460 to the previous implementation of the bootstrap-temacs rule.
10461 The bootstrap-temacs-CMD rule is similar to the previous
10462 implementation of the bootstrap-temacs rule except that it
10463 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10464 variable.
10465
10466 These changes, along with some changes to nt/configure.bat,
10467 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10468 earlier fix to add support for --cflags and --ldflags options
10469 that include quotes so that it works whether make uses cmd or
10470 sh as the shell.
10471
b4289b64
MA
104722011-05-06 Michael Albinus <michael.albinus@gmx.de>
10473
10474 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10475 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10476 is a constant.
10477 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10478 a string. Handle both cases.
10479 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10480 (Fdbus_register_method): Use Qinvalid_function.
10481
af4c0e28
JB
104822011-05-06 Juanma Barranquero <lekktu@gmail.com>
10483
10484 * makefile.w32-in: Update dependencies.
10485 (LISP_H): Add inttypes.h and stdin.h.
10486 (PROCESS_H): Add unistd.h.
10487
c51453d9
EZ
104882011-05-06 Eli Zaretskii <eliz@gnu.org>
10489
10490 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10491 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10492
8ff0ac3c 104932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10494
4c4b566b
PE
10495 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10496
aab2b9b5
PE
10497 * term.c (vfatal): Remove stray call to va_end.
10498 It's not needed and the C Standard doesn't allow it here anyway.
10499
c378da0b
PE
10500 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10501 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10502
288b08c7
PE
10503 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10504 bytes.
10505
e3601888
PE
10506 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10507
db6c0e74
PE
10508 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10509
dd5963ea
PE
10510 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10511
88c9450f
PE
10512 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10513
2f9442b8
PE
10514 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10515
c032b5f8
PE
10516 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10517 * charset.c (Fdefine_charset_internal): Don't initialize
10518 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10519 32-bit int (Bug#8600).
a108c10b
PE
10520
10521 * lread.c (read_integer): Be more consistent with string-to-number.
10522 Use string_to_number to do the actual conversion; this avoids
10523 rounding errors and fixes some other screwups. Without this fix,
10524 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10525 (digit_to_number): Move earlier, for benefit of read_integer.
10526 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10527 not a digit in any supported base. (Bug#8602)
a108c10b 10528
ad5f9eea
PE
10529 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10530
aec1708a
PE
10531 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10532 to match comment at start of function. This also removes a
10533 GCC warning about overflow in a 32+64-bit port.
10534
47be4ab5
PE
10535 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10536
371cac43
PE
10537 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10538 Reported by Stefan Monnier in
10539 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10540 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10541 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10542
d01a7826
PE
10543 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10544 (EMACS_UINTPTR): Likewise, with uintptr_t.
10545
7fd47d5c
PE
10546 * lisp.h: Prefer 64-bit EMACS_INT if available.
10547 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10548 on 32-bit hosts that have 64-bit int, so that they can access
10549 large files.
122b0c86
PE
10550 However, temporarily disable this change unless the temporary
10551 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10552
8727937b
PE
10553 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10554
8ac068ac
PE
10555 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10556 This removes an assumption that EMACS_INT and long are the same
10557 width as pointers. The assumption is true for Emacs porting targets
10558 now, but we want to make other targets possible.
10559 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10560 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10561 In the rest of the code, change types of integers that hold casted
10562 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10563 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10564 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10565 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10566 No need to cast type when ORing.
10567 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10568 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10569 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10570 assume EMACS_INT is the same width as char *.
10571 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10572 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10573 Remove no-longer-needed casts.
10574 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10575 (xg_tool_bar_help_callback, xg_make_tool_item):
10576 Use EMACS_INTPTR to hold an integer
10577 that will be cast to void *; this can avoid a GCC warning
10578 if EMACS_INT is not the same width as void *.
10579 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10580 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10581 (current_message_1, set_message_1):
10582 Use a local to convert to proper width without a cast.
10583 * xmenu.c (dialog_selection_callback): Likewise.
10584
ede49d71
PE
10585 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10586 Also, don't assume VALBITS / RAND_BITS is less than 5,
10587 and don't rely on undefined behavior when shifting a 1 left into
10588 the sign bit.
10589 * lisp.h (get_random): Change signature to match.
10590
2f30ecd0
PE
10591 * lread.c (hash_string): Use size_t, not int, for hash computation.
10592 Normally we prefer signed values; but hashing is special, because
10593 it's better to use unsigned division on hash table sizes so that
10594 the remainder is nonnegative. Also, size_t is the natural width
10595 for hashing into memory. The previous code used 'int', which doesn't
10596 retain enough info to hash well into very large tables.
10597 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10598
2a866e7b
PE
10599 * dbusbind.c: Don't possibly lose pointer info when converting.
10600 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10601 Use XPNTR rather than XHASH, so that the high-order bits of
10602 the pointer aren't lost when converting through void *.
10603
51639eac
PE
10604 * eval.c (Fautoload): Don't double-shift a pointer.
10605
92394119
PE
10606 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10607
dbdb9a7c
JB
106082011-05-06 Juanma Barranquero <lekktu@gmail.com>
10609
10610 * gnutls.c (DEF_GNUTLS_FN):
10611 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10612
db7a0b4f
AS
106132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10614
10615 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10616 marker. (Bug#8610)
10617
cd394be1 106182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10619
10620 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10621 New version that can reserve upto 2GB of heap space.
10622
f7ff1b0f 106232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10624
10625 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10626
639c109b
TZ
106272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10628
10629 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10630 `gnutls_certificate_set_x509_key_file'.
10631
d2127135
JB
106322011-05-05 Juanma Barranquero <lekktu@gmail.com>
10633
10634 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10635 Update dependencies.
10636
e968f4f3
JB
106372011-05-04 Juanma Barranquero <lekktu@gmail.com>
10638
10639 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10640 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10641 Remove unused parameter `fildes'.
10642 * process.c (read_process_output, send_process): Don't pass it.
10643
84d358f0
JB
106442011-05-04 Juanma Barranquero <lekktu@gmail.com>
10645
10646 Fix previous change: the library cache is defined in w32.c.
10647 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10648 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10649
0898ca10
JB
106502011-05-04 Juanma Barranquero <lekktu@gmail.com>
10651
10652 Implement dynamic loading of GnuTLS on Windows.
10653
10654 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10655 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10656 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10657 Declare.
10658
10659 * gnutls.c (Qgnutls_dll): Define.
10660 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10661 (gnutls_*): Declare function pointers.
10662 (init_gnutls_functions): New function to initialize function pointers.
10663 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10664 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10665 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10666 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10667 (emacs_gnutls_write, emacs_gnutls_read)
10668 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10669 (Fgnutls_available_p): New function.
10670 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10671 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10672 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10673
10674 * image.c: Include w32.h.
10675 (Vimage_type_cache): Delete.
10676 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10677 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10678 (w32_delayed_load): Move to w32.c.
10679
10680 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10681
10682 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10683 (w32_delayed_load): Move from image.c. When loading a library, record
10684 its filename in the :loaded-from property of the library id.
10685 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10686 Initialize and staticpro them.
10687 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10688
10689 * process.c: Include lisp.h before w32.h, not after.
10690 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10691 instead of gnutls_record_check_pending.
10692
10693 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10694
ff4de4aa
TZ
106952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10696
10697 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10698 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10699 as passed in.
10700
abe95abb
JD
107012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10702
10703 * xterm.c (x_set_frame_alpha): Do not set property on anything
10704 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10705
e16e55d4
JB
107062011-05-02 Juanma Barranquero <lekktu@gmail.com>
10707
10708 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10709
bafcf6a5
JB
107102011-05-02 Juanma Barranquero <lekktu@gmail.com>
10711
10712 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10713 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10714 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10715 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10716 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10717 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10718 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10719 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10720 (Qgnutls_bootprop_callbacks_verify): Make static.
10721
e7a6747f
AS
107222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10723
19ed11ba
AS
10724 * callproc.c: Indentation fixup.
10725
e7a6747f 10726 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10727 (wait_for_termination, interruptible_wait_for_termination):
10728 Move after wait_for_termination_1.
e7a6747f 10729
1ef14cb4
LMI
107302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10731
10732 * sysdep.c (interruptible_wait_for_termination): New function
10733 which is like wait_for_termination, but allows keyboard
10734 interruptions.
10735
10736 * callproc.c (Fcall_process): Add (:file "file") as an option for
10737 the STDOUT buffer.
10738 (Fcall_process_region): Ditto.
10739
330d880c
EZ
107402011-04-30 Eli Zaretskii <eliz@gnu.org>
10741
8db90b73
EZ
10742 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10743 rather than `XVECTOR (FOO)->size'.
10744
330d880c
EZ
10745 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10746 inttypes.h, as a gnulib replacement is used if it not available in
10747 system headers.
10748
15cbd324
EZ
107492011-04-21 Eli Zaretskii <eliz@gnu.org>
10750
10751 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10752 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10753 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10754
10755 * coding.c (coding_alloc_by_realloc): Error out if destination
10756 will grow beyond MOST_POSITIVE_FIXNUM.
10757 (decode_coding_emacs_mule): Abort if there isn't enough place in
10758 charbuf for the composition carryover bytes. Reserve an extra
10759 space for up to 2 characters produced in a loop.
10760 (decode_coding_iso_2022): Abort if there isn't enough place in
10761 charbuf for the composition carryover bytes.
10762
107632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10764
ae940cca
EZ
10765 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10766 aborting when %lld or %lll format is passed.
10767 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10768 %llo or %llx format is passed. (Bug#8545)
10769
03ab8921
EZ
10770 * window.c (window_scroll_line_based): Use a marker instead of
10771 simple variables to record original value of point. (Bug#7952)
10772
afda1437
EZ
10773 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10774 produced by %s or %c overflows available buffer space. (Bug#8545)
10775
f76dee0c
PE
107762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10777
10778 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10779 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10780
fdc5744d
JB
107812011-04-28 Juanma Barranquero <lekktu@gmail.com>
10782
10783 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10784
638f053a
JB
107852011-04-28 Juanma Barranquero <lekktu@gmail.com>
10786
10787 * keyboard.c (Qdelayed_warnings_hook): Define.
10788 (command_loop_1): Run `delayed-warnings-hook'
10789 if Vdelayed_warnings_list is non-nil.
10790 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10791 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10792
d178f871
EZ
107932011-04-28 Eli Zaretskii <eliz@gnu.org>
10794
10795 * doprnt.c (doprnt): Don't return value smaller than the buffer
10796 size if the message was truncated. (Bug#8545).
10797
b124fd93
JB
107982011-04-28 Juanma Barranquero <lekktu@gmail.com>
10799
10800 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10801 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10802
e810457d
PE
108032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10804
10805 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10806
ea51cceb
JB
108072011-04-27 Juanma Barranquero <lekktu@gmail.com>
10808
10809 * makefile.w32-in: Update dependencies.
10810
94dcfacf
EZ
108112011-04-27 Eli Zaretskii <eliz@gnu.org>
10812
10813 Improve `doprnt' and its usage. (Bug#8545)
10814 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10815 `format_end'. Remove support for %l as a conversion specifier.
10816 Don't use xrealloc. Improve diagnostics when the %l size modifier
10817 is used. Update the commentary.
10818
10819 * eval.c (verror): Simplify calculation of size_t.
10820
10821 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10822 messages.
10823
f61f41d7
PE
108242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10825
10826 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10827 change.
10828
96fb4434
PE
108292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10830
10831 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10832 This makes this file independent of the recent pseudovector change.
10833
671875da 108342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10835
69e9b5a3
PE
10836 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10837
b5f869a7 10838 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10839 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10840 Remove unused local.
c8926152 10841 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10842
841a1577 10843 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10844 GCC 4.6.0 optimizes based on type-based alias analysis.
10845 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10846 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10847 != &v->size, and therefore "v->size = 1; b->size = 2; return
10848 v->size;" must therefore return 1. This assumption is incorrect
10849 for Emacs, since it type-puns struct Lisp_Vector * with many other
10850 types. To fix this problem, this patch adds a new type struct
f904488f 10851 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10852 and pseudovectors, and helps optimizing compilers not get fooled
10853 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10854 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10855 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10856 the size member.
eab3844f
PE
10857 (XSETPVECTYPE): Rewrite in terms of new macro.
10858 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10859 This is a bit clearer, and further avoids the possibility of
10860 undesirable aliasing.
10861 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10862 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10863 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10864 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10865 (ASIZE): Now uses header.size rather than size.
10866 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10867 to avoid the hassle of writing XVECTOR (foo)->header.size.
10868 (struct vectorlike_header): New type.
eab3844f
PE
10869 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10870 object, to help avoid aliasing.
10871 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10872 (SUBRP): Likewise, since Lisp_Subr is a special case.
10873 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10874 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10875 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10876 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10877 changed to be "header.size" and "header.next".
10878 * buffer.h (struct buffer): Likewise.
10879 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10880 * frame.h (struct frame): Likewise.
10881 * process.h (struct Lisp_Process): Likewise.
10882 * termhooks.h (struct terminal): Likewise.
10883 * window.c (struct save_window_data, struct saved_window): Likewise.
10884 * window.h (struct window): Likewise.
10885 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10886 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10887 * buffer.c (init_buffer_once): Likewise.
10888 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10889 special case.
10890 * process.c (Fformat_network_address): Use local var for size,
10891 for brevity.
10892
0df1eac5
PE
10893 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10894
847ab9d1 10895 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10896 * data.c (atof): Remove decl; no longer used or needed.
10897 (digit_to_number): Move to lread.c.
10898 (Fstring_to_number): Use new string_to_number function, to be
10899 consistent with how the Lisp reader treats infinities and NaNs.
10900 Do not assume that floating-point numbers represent EMACS_INT
10901 without losing information; this is not true on most 64-bit hosts.
10902 Avoid double-rounding errors, by insisting on integers when
10903 parsing non-base-10 numbers, as the documentation specifies.
10904 * lisp.h (string_to_number): New decl, replacing ...
10905 (isfloat_string): Remove.
bc0a5c13 10906 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10907 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10908 appears to have been a coding error. Similarly, do not accept
10909 strings like +-1e0 as floating point numbers. Do not report
10910 overflow for integer overflows unless the base is not 10 which
10911 means we have no simple and reliable way to continue.
10912 Break out the floating-point parsing into a new
10913 function string_to_number, so that Fstring_to_number parses
10914 floating point numbers consistently with the Lisp reader.
04f2d78b 10915 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10916 (E_CHAR, EXP_INT): Remove, replacing with ...
10917 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10918 (string_to_number): New function, replacing isfloat_string.
10919 This function checks for valid syntax and produces the resulting
10920 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10921 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10922 so that overflow for non-base-10 numbers is reported only when
10923 there's no portable and simple way to convert to floating point.
452f4150 10924
67769ffc
PE
10925 * textprop.c (set_text_properties_1): Rewrite for clarity,
10926 and to avoid GCC warning about integer overflow.
10927
c20db43f
PE
10928 * intervals.h (struct interval): Use EMACS_INT for members
10929 where EMACS_UINT might cause problems. See
10930 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10931 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10932 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10933 All uses changed.
37aa2f85
PE
10934 (offset_intervals): Tell GCC not to worry about length overflow
10935 when negating a negative length.
c20db43f 10936
2538aa2f
PE
10937 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10938 (overrun_check_free): Likewise.
10939
f2d3008d
PE
10940 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10941 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10942 word size.
10943
ec8df744
PE
10944 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10945 (gnutls_make_error): Rename local to avoid shadowing.
10946 (gnutls_emacs_global_deinit): ifdef out; not used.
10947 (Fgnutls_boot): Use const for pointer to readonly storage.
10948 Comment out unused local. Fix pointer signedness problems.
10949
640ee02d
PE
10950 * lread.c (openp): Don't stuff size_t into an 'int'.
10951 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10952 about possible signed overflow.
10953
6048fb2a
PE
10954 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10955 (GDK_KEY_g): Don't define if already defined.
10956 (xg_prepare_tooltip): Avoid pointer signedness problem.
10957 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10958
fa3c87e1
PE
10959 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10960 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10961
2172544b
PE
10962 * xfns.c (Fx_window_property): Simplify a bit,
10963 to make a bit faster and to avoid GCC 4.6.0 warning.
10964 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10965
9b821a21
PE
10966 * fns.c (internal_equal): Don't assume size_t fits in int.
10967
3c616cfa
PE
10968 * alloc.c (compact_small_strings): Tighten assertion a little.
10969
c2982e87
PE
10970 Replace pEd with more-general pI, and fix some printf arg casts.
10971 * lisp.h (pI): New macro, generalizing old pEd macro to other
10972 conversion specifiers. For example, use "...%"pI"d..." rather
10973 than "...%"pEd"...".
10974 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10975 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10976 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10977 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10978 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10979 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10980 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10981 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10982 64-bit hosts.
10983 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10984 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10985 * print.c (safe_debug_print, print_object): Likewise.
10986 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10987 to int.
6f04d126
PE
10988 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10989 avoiding the 0 flag, which is not portable.
c2982e87
PE
10990 * process.c (Fmake_network_process): Use pI to avoid cast.
10991 * region-cache.c (pp_cache): Likewise.
10992 * xdisp.c (decode_mode_spec): Likewise.
10993 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10994 behavior on 64-bit hosts with printf arg.
6f04d126 10995 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10996 (x_stop_queuing_selection_requests): Likewise.
10997 (x_get_window_property): Don't truncate byte count to an 'int'
10998 when tracing.
0b432f21 10999
5e073ec7
PE
11000 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11001 here, since it parses constructs like leading '-' and spaces,
11002 which are not wanted; and it overflows with large numbers.
11003 Instead, simply match F[0-9]+, which is what is wanted anyway.
11004
36372bf9
PE
11005 * alloc.c: Remove unportable assumptions about struct layout.
11006 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11007 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11008 (allocate_vectorlike, make_pure_vector): Use the new macros,
11009 plus offsetof, to remove unportable assumptions about struct layout.
11010 These assumptions hold on all porting targets that I know of, but
11011 they are not guaranteed, they're easy to remove, and removing them
11012 makes further changes easier.
11013
0b432f21
PE
11014 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11015 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11016 (string_overrun_cookie): Now const. Use initializers that
11017 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11018 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11019 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11020 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11021 multiple of sizeof (EMACS_INT); it need not be, if
11022 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11023 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11024
895009e1
JB
110252011-04-26 Juanma Barranquero <lekktu@gmail.com>
11026
11027 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11028
6a7a1b0b
TZ
110292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11030
11031 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11032 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11033 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11034
841a1577 110352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11036
11037 * lisp.h (Qdebug): List symbol.
895009e1 11038 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11039 * keyboard.c (debug-on-event): New variable.
11040 (handle_user_signal): Break into debugger when debug-on-event
11041 matches the current signal symbol.
11042
f2d3ba6f
DN
110432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11044
11045 * alloc.c (check_sblock, check_string_bytes)
11046 (check_string_free_list): Convert to standard C.
11047
42ce4c63
TZ
110482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11049
11050 * w32.c (emacs_gnutls_push): Fix typo.
11051
825cd63c
EZ
110522011-04-25 Eli Zaretskii <eliz@gnu.org>
11053
fb11d64d
EZ
11054 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11055 "cast to pointer from integer of different size".
11056
825cd63c
EZ
11057 Improve doprnt and its use in verror. (Bug#8545)
11058 * doprnt.c (doprnt): Document the set of format control sequences
11059 supported by the function. Use SAFE_ALLOCA instead of always
11060 using `alloca'.
11061
11062 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11063 is one byte too soon. Don't use xrealloc; instead xfree and
11064 xmalloc anew.
11065
e061a11b
TZ
110662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11067
11068 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11069 callbacks stage.
11070
11071 * gnutls.c: Renamed global_initialized to
11072 gnutls_global_initialized. Added internals for the
11073 :verify-hostname-error, :verify-error, and :verify-flags
11074 parameters of `gnutls-boot' and documented those parameters in the
11075 docstring. Start callback support.
9173deec
JB
11076 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11077 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11078 on error. Return error code.
e061a11b
TZ
11079 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11080 (emacs_gnutls_read): Likewise.
11081 (Fgnutls_boot): Return handshake error code.
11082 (emacs_gnutls_handle_error): New function.
11083 (wsaerror_to_errno): Likewise.
11084
11085 * w32.h (emacs_gnutls_pull): Add prototype.
11086 (emacs_gnutls_push): Likewise.
11087
11088 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11089 (emacs_gnutls_push): Likewise.
11090
110912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11092
11093 * process.c (wait_reading_process_output): Check if GnuTLS
11094 buffered some data internally if no FDs are set for TLS
11095 connections.
11096
11097 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11098 (LIBS): Link to USER_LIBS.
11099 ($(BLD)/gnutls.$(0)): New target.
11100
fa6996bc
EZ
111012011-04-24 Eli Zaretskii <eliz@gnu.org>
11102
eb35682e
EZ
11103 * xdisp.c (handle_single_display_spec): Rename the
11104 display_replaced_before_p argument into display_replaced_p, to
11105 make it consistent with the commentary. Fix typos in the
11106 commentary.
11107
e2ad650c
EZ
11108 * textprop.c (syms_of_textprop): Remove dead code.
11109 (copy_text_properties): Delete obsolete commentary about an
11110 interface that was deleted long ago. Fix typos in the description
11111 of arguments.
11112
1b2de274
EZ
11113 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11114 to changes in oldXMenu/XMenu.h from 2011-04-16.
11115 <menu_help_message, prev_menu_help_message>: Constify.
11116 (IT_menu_make_room): menu->help_text is now `const char **';
11117 adjust.
11118
11119 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11120 to changes in oldXMenu/XMenu.h from 2011-04-16.
11121 (struct XMenu): Declare `help_text' `const char **'.
11122
11123 * xfaces.c <Qunspecified>: Make extern again.
11124
11125 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11126 required by POSIX.
1b2de274 11127
762b15be
EZ
11128 * doc.c (get_doc_string): Improve the format passed to `error'.
11129
11130 * doprnt.c (doprnt): Improve commentary.
11131
11132 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11133
11134 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11135 them with etags.
11136
f1052e5d
EZ
11137 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11138 changes in globals.h immediately force recompilation.
762b15be
EZ
11139 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11140 $(CURDIR)/s/ms-w32.h.
11141 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11142
fa6996bc
EZ
11143 * character.c (Fchar_direction): Function deleted.
11144 (syms_of_character): Don't defsubr it.
11145 <char-direction-table>: Deleted.
11146
e6c3da20
EZ
111472011-04-23 Eli Zaretskii <eliz@gnu.org>
11148
11149 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11150 * doprnt.c: Include limits.h.
11151 (SIZE_MAX): New macro.
04f2d78b
CB
11152 (doprnt): Return a size_t value. 2nd arg is now size_t.
11153 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11154 Improve overflow protection. Support `l' modifier for integer
11155 conversions. Support %l conversion. Don't assume an EMACS_INT
11156 argument for integer conversions and for %c.
11157
11158 * lisp.h (doprnt): Restore prototype.
11159
11160 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11161 $(SRC)/character.h.
11162
11163 * Makefile.in (base_obj): Add back doprnt.o.
11164
11165 * deps.mk (doprnt.o): Add back prerequisites.
11166 (callint.o): Depend on character.h.
11167
11168 * eval.c (internal_lisp_condition_case): Include the handler
11169 representation in the error message.
11170 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11171 when breaking from the loop.
11172
11173 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11174
11175 * callint.c (Fcall_interactively): When displaying error message
11176 about invalid control letter, pass the character's codepoint, not
11177 a pointer to its multibyte form. Improve display of the character
11178 in octal and display also its hex code.
11179
11180 * character.c (char_string): Use %x to display the (unsigned)
11181 codepoint of an invalid character, to avoid displaying a bogus
11182 negative value.
11183
11184 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11185 `error', not SYMBOL_NAME itself.
11186
11187 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11188 character arguments to `error'.
11189
11190 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11191 to `error' in error message about FINAL_CHAR argument. Make sure
11192 FINAL_CHAR is a character, and use %c when it is passed as
11193 argument to `error'.
11194
4ffd0d6b 111952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11196
11197 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11198
11199 * w32.c: Include <time.h>.
11200 (sys_localtime): New function.
11201
4ffd0d6b 112022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11203
11204 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11205
4ffd0d6b 11206 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11207
4ffd0d6b 112082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11209
4ffd0d6b
GM
11210 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11211 zombies (Bug#8467).
aac0c6e3 11212
04c56954
EZ
112132011-04-19 Eli Zaretskii <eliz@gnu.org>
11214
11215 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11216 gl_state.e_property when gl_state.object is Qt.
11217
11218 * insdel.c (make_gap_larger): Remove limitation of buffer size
11219 to <= INT_MAX.
11220
16a43933
CY
112212011-04-18 Chong Yidong <cyd@stupidchicken.com>
11222
11223 * xdisp.c (lookup_glyphless_char_display)
11224 (produce_glyphless_glyph): Handle cons cell entry in
11225 glyphless-char-display.
11226 (Vglyphless_char_display): Document it.
11227
11228 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11229 glyphless-char-display.
11230
4581706e
CY
112312011-04-17 Chong Yidong <cyd@stupidchicken.com>
11232
11233 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11234
11235 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11236
11237 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11238 definition for no-X builds.
11239
4887c6e2 112402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11241
fd35b6f9
PE
11242 Static checks with GCC 4.6.0 and non-default toolkits.
11243
5c1ccb01
PE
11244 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11245
006c5daa
PE
11246 * process.c (keyboard_bit_set): Define only if SIGIO.
11247 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11248 (send_process): Repair possible setjmp clobbering.
11249
efc736d3
PE
11250 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11251
4e2fe2e6
PE
11252 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11253
f97334a2
PE
11254 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11255
4e75f29d
PE
11256 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11257 Define only if needed.
11258
90efadd1
PE
11259 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11260 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11261 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11262
3c647824
PE
11263 * dispextern.h (struct redisplay_interface): Rename param
11264 to avoid shadowing.
e264f262 11265 * termhooks.h (struct terminal): Likewise.
761383f4 11266 * xterm.c (xembed_send_message): Likewise.
3c647824 11267
b58c5c4a
PE
11268 * insdel.c (make_gap_smaller): Define only if
11269 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11270
cad59032
PE
11271 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11272 it.
11273
c339dc2e
PE
11274 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11275 so that we aren't warned about unused symbols.
11276
91a3e27b
PE
11277 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11278
399c71d3 11279 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11280
8ffc96f5
PE
11281 * xfns.c (x_real_positions): Mark locals as initialized.
11282
eef9bc79
PE
11283 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11284
098db9dd
PE
11285 * xterm.c: Fix problems found by static analysis with other toolkits.
11286 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11287 (x_dispatch_event): Declare static if USE_GTK, and
11288 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11289 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11290 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11291 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11292 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11293
eb18f6cc
PE
11294 * xmenu.c (menu_help_callback): Pointer type fixes.
11295 Use const pointers when pointing at readonly data. Avoid pointer
11296 signedness clashes.
11297 (FALSE): Remove unused macro.
11298 (update_frame_menubar): Remove unused decl.
11299
1fe72bf8
PE
11300 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11301
60d9e1db
PE
11302 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11303 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11304 (single_menu_item): Rename local to avoid shadowing.
11305
39261c26
PE
11306 * keyboard.c (make_lispy_event): Remove unused local var.
11307
018c5e19
PE
11308 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11309 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11310
63d2b86e
PE
11311 * bitmaps: Change bitmaps from unsigned char back to the X11
11312 compatible char. Avoid the old compiler warnings about
11313 out-of-range initializers by using, for example, '\xab' rather
11314 than 0xab.
11315
aefd87e1
PE
11316 * xgselect.c (xgselect_initialize): Check vs interface
11317 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11318
bf501fb9
PE
11319 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11320
e9829fdf
PE
11321 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11322 to read-only memory.
11323
1086c095
PE
11324 * fns.c (vector): Remove; this old hack is no longer needed.
11325
2baccd04 11326 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11327 Remove unused var.
dde42981 11328 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11329
72391843 11330 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11331
436c16df 11332 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11333 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11334 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11335
92bb796d 11336 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11337 (x_term_init): Remove local to avoid shadowing.
92bb796d 11338
764430a3 11339 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11340
11341 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11342 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11343
d1dfb56c
EZ
113442011-04-16 Eli Zaretskii <eliz@gnu.org>
11345
c4354cb4
EZ
11346 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11347
d1dfb56c
EZ
11348 Fix regex.c, syntax.c and friends for buffers > 2GB.
11349 * syntax.h (struct gl_state_s): Declare character position members
11350 EMACS_INT.
11351
11352 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11353
04f2d78b
CB
11354 * textprop.c (verify_interval_modification, interval_of):
11355 Declare arguments EMACS_INT.
d1dfb56c
EZ
11356
11357 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11358 EMACS_INT.
11359
11360 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11361
11362 * indent.c (Fvertical_motion): Local variable it_start is now
11363 EMACS_INT.
11364
11365 * regex.c (re_match, re_match_2, re_match_2_internal)
11366 (bcmp_translate, regcomp, regexec, print_double_string)
11367 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11368 (re_compile_pattern, re_exec): Declare arguments and local
11369 variables `size_t' and `ssize_t' and return values `regoff_t', as
11370 appropriate.
11371 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11372 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11373 <compile_stack_type>: `size' and `avail' are now `size_t'.
11374
11375 * regex.h <regoff_t>: Use ssize_t, not int.
11376 (re_search, re_search_2, re_match, re_match_2): Arguments that
11377 specify buffer/string position and length are now ssize_t and
11378 size_t. Return type is regoff_t.
11379
613052cd
BK
113802011-04-16 Ben Key <bkey76@gmail.com>
11381
11382 * nsfont.m: Fixed bugs in ns_get_family and
11383 ns_descriptor_to_entity that were caused by using free to
11384 deallocate memory blocks that were allocated by xmalloc (via
11385 xstrdup). This caused Emacs to crash when compiled with
11386 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11387 --enable-checking=xmallocoverrun). xfree is now used to
11388 deallocate these memory blocks.
11389
4170f62f 113902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11391
71b41406
PE
11392 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11393
9587a89d
PE
11394 emacs_write: Accept and return EMACS_INT for sizes.
11395 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11396 et seq.
11397 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11398 Accept and return EMACS_INT.
11399 (emacs_gnutls_write): Return the number of bytes written on
11400 partial writes.
11401 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11402 (emacs_read, emacs_write): Remove check for negative size, as the
11403 Emacs source code has been audited now.
9587a89d
PE
11404 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11405 (emacs_read, emacs_write): Use it.
273a5f82
PE
11406 * process.c (send_process): Adjust to the new signatures of
11407 emacs_write and emacs_gnutls_write. Do not attempt to store
11408 a byte offset into an 'int'; it might overflow.
9587a89d 11409 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11410
3e047f51
PE
11411 * sound.c: Don't assume sizes fit in 'int'.
11412 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11413 Return EMACS_INT, not int.
3e047f51 11414 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11415 Accept EMACS_INT, not int.
11416 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11417 record read return values.
11418
cc39a9db
BK
114192011-04-15 Ben Key <bkey76@gmail.com>
11420
c9d0ec6d
JB
11421 * keyboard.c (Qundefined): Don't declare static since it is used
11422 in nsfns.m.
11423 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11424 static since they are used in nsfont.m.
cc39a9db 11425
6c60eb9f
SM
114262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11427
11428 * process.c (Qprocessp): Don't declare static.
11429 * lisp.h (Qprocessp): Declare again.
11430
7990b61a
JB
114312011-04-15 Juanma Barranquero <lekktu@gmail.com>
11432
11433 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11434
5d4cb038
PE
114352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11436
8bd7b830 11437 Improve C-level modularity by making more things 'static'.
cd64ea1d 11438
e3b27b31
PE
11439 Don't publish debugger-only interfaces to other modules.
11440 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11441 (verify_bytepos, count_markers): Move decls to the only modules
11442 that need them.
11443 * region-cache.h (pp_cache): Likewise.
11444 * window.h (check_all_windows): Likewise.
11445 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11446
5d4cb038
PE
11447 * sysdep.c (croak): Now static, if
11448 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11449 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11450
11451 * alloc.c (refill_memory_reserve): Now static if
11452 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11453 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11454
e87b6180
PE
11455 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11456 Define only if USE_LUCID.
11457
ac64929e
PE
11458 * xrdb.c (x_customization_string, x_rm_string): Now static.
11459
6f37259d
PE
11460 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11461 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11462
1683e3ab
PE
11463 * xdisp.c (draw_row_with_mouse_face): Now static.
11464 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11465
de9c2632
PE
11466 * window.h (check_all_windows): Mark externally visible.
11467
2b96acb7
PE
11468 * window.c (window_deletion_count): Now static.
11469
11470 * undo.c: Make symbols static if they're not exported.
11471 (last_undo_buffer, last_boundary_position, pending_boundary):
11472 Now static.
11473
50436f33
PE
11474 * textprop.c (interval_insert_behind_hooks): Now static.
11475 (interval_insert_in_front_hooks): Likewise.
11476
64520e5c
PE
11477 * term.c: Make symbols static if they're not exported.
11478 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11479 (max_frame_lines, tty_set_terminal_modes):
11480 (tty_reset_terminal_modes, tty_turn_off_highlight):
11481 (get_tty_terminal): Now static.
11482 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11483 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11484 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11485 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11486 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11487
1fa53021
PE
11488 * sysdep.c: Make symbols static if they're not exported.
11489 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11490 Now static.
11491 (sigprocmask_set, full_mask): Remove; unused.
11492 (wait_debugging): Mark as visible.
11493 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11494 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11495
d4b43b22
PE
11496 * syntax.c (syntax_temp): Define only if !__GNUC__.
11497
b7c513d0
PE
11498 * sound.c (current_sound_device, current_sound): Now static.
11499
989b29ad
PE
11500 * search.c (searchbufs, searchbuf_head): Now static.
11501
13a55a78
PE
11502 * scroll.c (scroll_cost): Remove; unused.
11503 * dispextern.h (scroll_cost): Remove decl.
11504
de68a1fc
PE
11505 * region-cache.h (pp_cache): Mark as externally visible.
11506
40ccffa6
PE
11507 * process.c: Make symbols static if they're not exported.
11508 (process_tick, update_tick, create_process, chan_process):
11509 (Vprocess_alist, proc_buffered_char, datagram_access):
11510 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11511 (deactivate_process): Mark defn as static, as well as decl.
11512 * lisp.h (create_process): Remove decl.
11513 * process.h (chan_process, Vprocess_alist): Remove decls.
11514
ad64fc97
PE
11515 * print.c: Make symbols static if they're not exported.
11516 (print_depth, new_backquote_output, being_printed, print_buffer):
11517 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11518 (print_interval, print_number_index, initial_stderr_stream):
11519 Now static.
11520 * lisp.h (Fprinc): Remove decl.
11521 (debug_output_compilation_hack): Mark as externally visible.
11522
adddb265
PE
11523 * sysdep.c (croak): Move decl from here to syssignal.h.
11524 * syssignal.h (croak): Put it here, so the API can be checked when
11525 'croak' is called from dissociate_if_controlling_tty.
11526
1717ede2
PE
11527 * minibuf.c: Make symbols static if they're not exported.
11528 (minibuf_save_list, choose_minibuf_frame): Now static.
11529 * lisp.h (choose_minibuf_frame): Remove decl.
11530
fa5fb2bc
PE
11531 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11532
1e3890d1
PE
11533 * lread.c: Make symbols static if they're not exported.
11534 (read_objects, initial_obarray, oblookup_last_bucket_number):
11535 Now static.
11536 (make_symbol): Remove; unused.
11537 * lisp.h (initial_obarray, make_symbol): Remove decls.
11538
8a1414fa
PE
11539 * keyboard.c: Make symbols static if they're not exported.
11540 (single_kboard, recent_keys_index, total_keys, recent_keys):
11541 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11542 (this_single_command_key_start, echoing, last_auto_save):
11543 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11544 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11545 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11546 (Vlispy_mouse_stem, double_click_count):
11547 Now static.
11548 (force_auto_save_soon): Define only if SIGDANGER.
11549 (ignore_mouse_drag_p): Now static if
11550 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11551 (print_help): Remove; unused.
11552 (stop_character, last_timer_event): Mark as externally visible.
11553 * keyboard.h (ignore_mouse_drag_p): Declare only if
11554 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11555 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11556 * lisp.h (echoing): Remove decl.
11557 (force_auto_save_soon): Declare only if SIGDANGER.
11558 * xdisp.c (redisplay_window): Simplify code, to make it more
11559 obvious that ignore_mouse_drag_p is not accessed if !defined
11560 USE_GTK && !defined HAVE_NS.
11561
93ea6e8f
PE
11562 * intervals.c: Make symbols static if they're not exported.
11563 (merge_properties_sticky, merge_interval_right, delete_interval):
11564 Now static.
11565 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11566
77382fcc
PE
11567 * insdel.c: Make symbols static if they're not exported.
11568 However, leave prepare_to_modify_buffer alone. It's never
11569 called from outside this function, but that appears to be a bug.
11570 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11571 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11572 (adjust_after_replace_noundo): Remove; unused.
11573 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11574 (signal_before_change): Remove decls.
77382fcc 11575
9306c32e
PE
11576 * indent.c (val_compute_motion, val_vmotion): Now static.
11577
cd44d2eb
PE
11578 * image.c: Make symbols static if they're not exported.
11579 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11580 if USE_GTK.
11581 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11582 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11583
ad9a7a06
PE
11584 * fringe.c (standard_bitmaps): Now static.
11585 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11586
81626931
PE
11587 * frame.c: Make symbols static if they're not exported.
11588 (x_report_frame_params, make_terminal_frame): Now static.
11589 (get_frame_param): Now static, unless HAVE_NS.
11590 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11591 (x_get_resource_string): Remove; not used.
11592 * frame.h (make_terminal_frame, x_report_frame_params):
11593 (x_get_resource_string); Remove decls.
11594 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11595 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11596
239f9db9
PE
11597 * font.c, fontset.c: Make symbols static if they're not exported.
11598 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11599 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11600 * font.c (font_close_object): Now static.
11601 * font.h (font_close_object): Remove.
11602 * fontset.c (FONTSET_OBJLIST): Remove.
11603 (free_realized_fontset) #if-0 the body, which does nothing.
11604 (face_suitable_for_char_p): #if-0, as it's never called.
11605 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11606 * xfaces.c (face_at_string_position):
11607 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11608 since 0 is always ASCII.
11609
dfcf3579
PE
11610 * fns.c (weak_hash_tables): Now static.
11611
5045092b
PE
11612 * fileio.c: Make symbols static if they're not exported.
11613 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11614 (Vwrite_region_annotation_buffers): Now static.
11615
57a96f5c
PE
11616 * eval.c: Make symbols static if they're not exported.
11617 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11618 * lisp.h (backtrace_list): Remove decl.
11619
35f08c38
PE
11620 * emacs.c: Make symbols static if they're not exported.
11621 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11622 (fatal_error_code, fatal_error_signal_hook, standard_args):
11623 Now static.
11624 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11625 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11626 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11627 * lisp.h (fatal_error_signal_hook): Remove decl.
11628 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11629
f44bd759
PE
11630 * editfns.c: Move a (normally-unused) function to its only use.
11631 * editfns.c, lisp.h (get_operating_system_release): Remove.
11632 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11633 worth the hassle of breaking this out.
11634
b532497d
PE
11635 * xterm.c: Make symbols static if they're not exported.
11636 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11637 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11638 (x_destroy_window, x_delete_display):
11639 Now static.
11640 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11641 (x_mouse_leave): Remove; unused.
11642 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11643 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11644 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11645 Remove decls.
11646 (x_mouse_leave): Declare only if WINDOWSNT.
11647 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11648 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11649 USE_X_TOOLKIT.
11650
1675728f
PE
11651 * ftxfont.c: Make symbols static if they're not exported.
11652 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11653 HAVE_FREETYPE.
11654 * font.h (ftxfont_driver): Likewise.
11655
e4cebfca
PE
11656 * xfns.c: Make symbols static if they're not exported.
11657 (x_last_font_name, x_display_info_for_name):
11658 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11659 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11660 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11661 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11662 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11663 (last_show_tip_args): Now static.
11664 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11665 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11666 (x_screen_planes): Remove; unused.
11667 * dispextern.h (x_screen_planes): Remove decl.
11668
5bf46f05
PE
11669 * dispnew.c: Make symbols static if they're not exported.
11670 * dispextern.h (redraw_garbaged_frames, scrolling):
11671 (increment_row_positions): Remove.
11672 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11673 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11674 Now static.
11675 (redraw_garbaged_frames): Remove; unused.
11676
435f4c28
PE
11677 * xfaces.c: Make symbols static if they're not exported.
11678 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11679 Remove decls.
11680 * xterm.h (defined_color): Remove decls.
11681 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11682 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11683 (menu_face_changed_default, defined_color, free_realized_face):
11684 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11685 (ascii_face_of_lisp_face): Remove; unused.
11686
8524aef3
PE
11687 * xdisp.c: Make symbols static if they're not exported.
11688 * dispextern.h (scratch_glyph_row, window_box_edges):
11689 (glyph_to_pixel_coords, set_cursor_from_row):
11690 (get_next_display_element, set_iterator_to_next):
11691 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11692 (show_mouse_face): Remove decls
11693 * frame.h (message_buf_print): Likewise.
11694 * lisp.h (pop_message, set_message, check_point_in_composition):
11695 Likewise.
11696 * xterm.h (set_vertical_scroll_bar): Likewise.
11697 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11698 (message_buf_print, scratch_glyph_row, displayed_buffer):
11699 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11700 (get_next_display_element, show_mouse_face, window_box_edges):
11701 (frame_to_window_pixel_xy, check_point_in_composition):
11702 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11703 (glyph_to_pixel_coords): Remove; unused.
11704
16390cd2
PE
11705 * dired.c (file_name_completion): Now static.
11706
11707 * dbusbind.c (xd_in_read_queued_messages): Now static.
11708
a25f4dfa
PE
11709 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11710 * data.c (circular_list_error): Remove.
11711
14a9c8df
PE
11712 * commands.h (last_point_position, last_point_position_buffer):
11713 (last_point_position_window): Remove decls.
11714 * keyboard.c: Make these variables static.
11715
04f2d78b
CB
11716 * coding.h (coding, code_convert_region, encode_coding_gap):
11717 Remove decls.
74ab6df5
PE
11718 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11719 (iso_code_class, detect_coding, code_convert_region): Now static.
11720 (encode_coding_gap): Remove; unused.
11721
38dfbee1
PE
11722 * chartab.c (chartab_chars, chartab_bits): Now static.
11723
a2cb4e63
PE
11724 * charset.h (charset_iso_8859_1): Remove decl.
11725 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11726 Now static.
11727
127198fd
PE
11728 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11729 * ccl.c (Vccl_program_table): Now static.
11730 (check_ccl_update): Remove; unused.
11731
d85b608f
PE
11732 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11733 * category.h: ... from here.
11734 * category.c (check_category_table, set_category_set): Now static.
11735
31cd66f3
PE
11736 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11737 * lisp.h: Remove these decls.
11738
c358e587
PE
11739 * buffer.c (buffer_count): Remove unused var.
11740
e78aecca
PE
11741 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11742 so that it's not optimized away.
11743 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11744 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11745 exported only to the debugger.
11746
e192d7d3 11747 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11748 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11749
92470028
PE
11750 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11751 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11752 was inaccessible from Lisp.
11753 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11754 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11755
244ed907
PE
11756 alloc.c: Import and export fewer symbols, and remove unused items.
11757 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11758 is defined.
11759 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11760 it's not optimized away by whole-program optimization.
11761 (message_enable_multibyte, free_misc): Remove.
11762 (catchlist, handlerlist, mark_backtrace):
11763 Declare only if BYTE_MARK_STACK.
11764 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11765 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11766 (message_enable_multibyte): Remove decl.
11767 (free_misc, interval_free_list, float_block, float_block_index):
11768 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11769 (cons_free_list, last_marked_index):
11770 Now static.
11771 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11772 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11773 (mark_backtrace): Define only if BYTE_MARK_STACK.
11774 * xdisp.c (message_enable_multibyte): Now static.
11775
61c2b50e 11776 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11777 This makes it easier for human readers (and static analyzers)
11778 to see whether these variables are used from other modules.
11779 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11780 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11781 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11782 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11783 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11784 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11785 * xmenu.c, xselect.c:
11786 Declare Q* vars static if they are not used in other modules.
11787 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11788 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11789 Remove decls of unexported vars.
11790 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11791
95c82688
PE
11792 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11793
16a97296
PE
11794 Make Emacs functions such as Fatom 'static' by default.
11795 This makes it easier for human readers (and static analyzers)
11796 to see whether these functions can be called from other modules.
11797 DEFUN now defines a static function. To make the function external
11798 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11799 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11800 (Finit_image_library):
16a97296
PE
11801 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11802 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11803 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11804 Remove decls, since these functions are now static.
11805 (Funintern, Fget_internal_run_time): New decls, since these functions
11806 were already external.
95c82688 11807
16a97296
PE
11808 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11809 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11810 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11811 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11812 * keyboard.c, keymap.c, lread.c:
11813 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11814 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11815 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11816 Mark functions with DEFUE instead of DEFUN,
11817 if they are used in other modules.
11818 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11819 decls for now-static functions.
11820 * buffer.h (Fdelete_overlay): Remove decl.
11821 * callproc.c (Fgetenv_internal): Mark as internal.
11822 * composite.c (Fremove_list_of_text_properties): Remove decl.
11823 (Fcomposition_get_gstring): New forward static decl.
11824 * composite.h (Fcomposite_get_gstring): Remove decl.
11825 * dired.c (Ffile_attributes): New forward static decl.
11826 * doc.c (Fdocumntation_property): New forward static decl.
11827 * eval.c (Ffetch_bytecode): New forward static decl.
11828 (Funintern): Remove extern decl; now in .h file where it belongs.
11829 * fileio.c (Fmake_symbolic_link): New forward static decl.
11830 * image.c (Finit_image_library): New forward static decl.
11831 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11832 * intervals.h (Fprevious_property_change):
11833 (Fremove_list_of_text_properties): Remove decls.
11834 * keyboard.c (Fthis_command_keys): Remove decl.
11835 (Fcommand_execute): New forward static decl.
11836 * keymap.c (Flookup_key): New forward static decl.
11837 (Fcopy_keymap): Now static.
11838 * keymap.h (Flookup_key): Remove decl.
11839 * process.c (Fget_process): New forward static decl.
11840 (Fprocess_datagram_address): Mark as internal.
11841 * syntax.c (Fsyntax_table_p): New forward static decl.
11842 (skip_chars): Remove duplicate decl.
11843 * textprop.c (Fprevious_property_change): New forward static decl.
11844 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11845 Now internal.
11846 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11847 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11848
785bbd42
PE
11849 * editfns.c (Fformat): Remove unreachable code.
11850
8b913b57
AS
118512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11852
11853 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11854 change. (Bug#8496)
11855
a6744a35
EZ
118562011-04-13 Eli Zaretskii <eliz@gnu.org>
11857
11858 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11859 when at ZV. (Bug#8487)
11860
e7974947
AS
118612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11862
baad03f0
AS
11863 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11864 (Bug#8437)
11865 * keyboard.c (parse_tool_bar_item): Likewise.
11866 * sound.c (sound_cleanup, alsa_close): Likewise.
11867 * termcap.c (tgetent): Likewise.
11868 * xfns.c (x_default_font_parameter): Likewise.
11869 * xsettings.c (read_and_apply_settings): Likewise.
11870
e7974947
AS
11871 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11872 (overrun_check_free): Protoize.
11873
28272684
PE
118742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11875
11876 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11877 since callers should never pass a negative size.
11878 Change the signature to match that of plain 'read' and 'write'; see
11879 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11880 * lisp.h: Update prototypes of emacs_write and emacs_read.
11881
11997c76
EZ
118822011-04-11 Eli Zaretskii <eliz@gnu.org>
11883
11884 * xdisp.c (redisplay_window): Don't try to determine the character
11885 position of the scroll margin if the window start point w->startp
e896f03c 11886 is outside the buffer's accessible region. (Bug#8468)
11997c76 11887
8a2cbd72
EZ
118882011-04-10 Eli Zaretskii <eliz@gnu.org>
11889
11890 Fix write-region and its subroutines for buffers > 2GB.
11891 * fileio.c (a_write, e_write): Modify declaration of arguments and
11892 local variables to support buffers larger than 2GB.
11893 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11894
11895 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11896 argument, local variables, and return value.
11897
11898 * lisp.h: Update prototypes of emacs_write and emacs_read.
11899
11900 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11901
4073e537 119022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11903
1ebfdcb6
PE
11904 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11905
b2ded58d
PE
11906 Fix more problems found by GCC 4.6.0's static checks.
11907
7d66342c
PE
11908 * xdisp.c (vmessage): Use a better test for character truncation.
11909
bbf47d44
PE
11910 * charset.c (load_charset_map): <, not <=, for optimization,
11911 and to avoid potential problems with integer overflow.
9248994d 11912 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11913 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11914 * editfns.c (Fformat): Likewise.
1e69125e 11915 * syntax.c (skip_chars): Likewise.
3befa583 11916
e3019616
PE
11917 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11918 This also lets GCC 4.6.0 generate slightly better loop code.
11919
becfa255
PE
11920 * callint.c (Fcall_interactively): <, not <=, for optimization.
11921 (Fcall_interactively): Count the number of arguments produced,
11922 not the number of arguments given. This is simpler and lets GCC
11923 4.6.0 generate slightly better code.
11924
dae0cd48
PE
11925 * ftfont.c: Distingish more carefully between FcChar8 and char.
11926 The previous code passed unsigned char * to a functions like
11927 strlen and xstrcasecmp that expect char *, which does not
11928 conform to the C standard.
11929 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11930 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11931 char * when the C standard requires it.
11932
76032d70
PE
11933 * keyboard.c (read_char): Remove unused var.
11934
eb3f1cc8
PE
11935 * eval.c: Port to Windows vsnprintf (Bug#8435).
11936 Include <limits.h>.
11937 (SIZE_MAX): Define if the headers do not.
11938 (verror): Do not give up if vsnprintf returns a negative count.
11939 Instead, grow the buffer. This ports to Windows vsnprintf, which
11940 does not conform to C99. Problem reported by Eli Zaretskii.
11941 Also, simplify the allocation scheme, by avoiding the need for
11942 calling realloc, and removing the ALLOCATED variable.
11943
70476b54
PE
11944 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11945
12020a9e
PE
11946 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11947 But keep the doprint source code for now, as we might revamp it
11948 and use it again (Bug#8435).
ea6c7ae6
PE
11949 * lisp.h (doprnt): Remove.
11950 * Makefile.in (base_obj): Remove doprnt.o.
11951 * deps.mk (doprnt.o): Remove.
11952
5fdb398c
PE
11953 error: Print 32- and 64-bit integers portably (Bug#8435).
11954 Without this change, on typical 64-bit hosts error ("...%d...", N)
11955 was used to print both 32- and 64-bit integers N, which relied on
11956 undefined behavior.
61bdb816 11957 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11958 * lisp.h (error, verror): Mark as printf-like functions.
11959 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11960 Report overflow in size calculations when allocating printf buffer.
11961 Do not truncate output string at its first null byte.
11962 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11963 Truncate the output at a character boundary, since vsnprintf does not
11964 do that.
11965 * charset.c (check_iso_charset_parameter): Convert internal
11966 character to string before calling 'error', since %c now has the
11967 printf meaning.
11968 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11969 overflow when computing char to be passed to 'error'. Do not
11970 pass Lisp_Object to 'error'; pass the integer instead.
11971 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11972 formatted with plain %d.
11973
b189fa66
PE
11974 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11975
bff87ef0
PE
11976 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11977
7e2cac20
PE
11978 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11979
ce4d90b5
PE
11980 * xterm.c (x_catch_errors): Remove duplicate declaration.
11981
266c9547
PE
11982 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11983
79c49ad2
PE
11984 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11985
368f4090
JM
119862011-04-10 Jim Meyering <meyering@redhat.com>
11987
11988 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11989 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11990 return ssize_t not "int", and use size_t as the buffer length.
11991 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11992 * gnutls.h: Update declarations.
11993 * process.c (read_process_output): Use ssize_t, to match.
11994 (send_process): Likewise.
11995
a32d4040
CY
119962011-04-09 Chong Yidong <cyd@stupidchicken.com>
11997
11998 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11999
8546720e 120002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12001
04f2d78b
CB
12002 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12003 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12004
8546720e
GM
12005 * xterm.c (handle_one_xevent):
12006 * xmenu.c (create_and_show_popup_menu):
12007 * xselect.c (x_decline_selection_request)
12008 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12009
0a2f5c1a 120102011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12011
12012 Fix some uses of `int' instead of EMACS_INT.
12013 * search.c (string_match_1, fast_string_match)
12014 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12015 (scan_buffer, find_next_newline_no_quit)
12016 (find_before_next_newline, search_command, Freplace_match)
12017 (Fmatch_data): Make some `int' variables be EMACS_INT.
12018
12019 * xdisp.c (display_count_lines): 3rd argument and return value now
12020 EMACS_INT. All callers changed.
12021 (pint2hrstr): Last argument is now EMACS_INT.
12022
12023 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12024 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12025 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12026 (decode_coding_utf_16, decode_coding_emacs_mule)
12027 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12028 (decode_coding_ccl, decode_coding_charset)
12029 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12030 (decode_coding_iso_2022, decode_coding_emacs_mule)
12031 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12032 <char_offset, last_offset>: Declare EMACS_INT.
12033 (encode_coding_utf_8, encode_coding_utf_16)
12034 (encode_coding_emacs_mule, encode_invocation_designation)
12035 (encode_designation_at_bol, encode_coding_iso_2022)
12036 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12037 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12038 Declare EMACS_INT.
12039 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12040 (encode_invocation_designation): Last argument P_NCHARS is now
12041 EMACS_INT.
12042 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12043 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12044
12045 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12046 All users changed.
12047
12048 * ccl.c (Fccl_execute_on_string): Declare some variables
12049 EMACS_INT.
12050
8546720e 120512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12052
12053 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12054
4e19a977
CS
120552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12056
12057 * process.c (Fformat_network_address): Doc fix.
12058
87302331
R
120592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12060
ee7683eb 12061 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12062
cbb59342
CY
120632011-04-08 Chong Yidong <cyd@stupidchicken.com>
12064
12065 * keyboard.c (read_char): Call Lisp function help-form-show,
12066 instead of using internal_with_output_to_temp_buffer.
12067 (Qhelp_form_show): New var.
e0d38eeb 12068 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12069
12070 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12071
12072 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12073
e67a13ab
CY
120742011-04-06 Chong Yidong <cyd@stupidchicken.com>
12075
04f2d78b
CB
12076 * process.c (Flist_processes): Remove to Lisp.
12077 (list_processes_1): Delete.
e67a13ab 12078
973f782d
EZ
120792011-04-06 Eli Zaretskii <eliz@gnu.org>
12080
7c106b1e
EZ
12081 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12082
973f782d
EZ
12083 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12084
41cf7d1a 120852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12086
ca23cc88
PE
12087 Fix more problems found by GCC 4.6.0's static checks.
12088
f390e2d5
PE
12089 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12090
42eea0d0
PE
12091 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12092
b69769da 12093 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12094
f9541e84
PE
12095 * xdisp.c (vmessage): Mark as a printf-like function.
12096
13841b55
PE
12097 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12098
c136c10f
PE
12099 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12100
5e2d4a30
PE
12101 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12102 printf-like functions.
12103 (tiff_load): Add casts to remove these marks before passing them
12104 to system-supplied API.
12105
583f48b9
PE
12106 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12107
b25d760e
PE
12108 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12109 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12110 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12111 directly, rather than having caller test rule sign. This avoids
12112 some unnecessary tests.
12113 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12114 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12115 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12116
bc7b6697 12117 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12118 (xfont_open): Avoid unnecessary tests.
bc7b6697 12119
27ccc379
PE
12120 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12121
dcd5c89a
PE
12122 * composite.h, composite.c (composition_gstring_put_cache):
12123 Use EMACS_INT, not int, for length.
12124
b13a45c6
PE
12125 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12126 breaking out part of COMPOSITION_DECODE_RULE.
12127 (COMPOSITION_DECODE_RULE): Use it.
12128 * composite.c (get_composition_id): Remove unused local vars,
12129 by using the new macro.
12130
1e792e4d
PE
12131 * textprop.c (set_text_properties_1): Change while to do-while,
12132 since the condition is always true at first.
12133
dc6c6455 12134 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12135 (interval_deletion_adjustment): Return unsigned value.
12136 All uses changed.
dc6c6455 12137
aba7731a
PE
12138 * process.c (list_processes_1, create_pty, read_process_output):
12139 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12140 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12141 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12142 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12143 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12144
fdfc4bf3
PE
12145 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12146
fca8fe46 12147 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12148 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12149
06a0259a 12150 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12151 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12152 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12153
e7b9e80f
PE
12154 * print.c (print_error_message): Avoid int overflow.
12155
56201685
PE
12156 * font.c (font_list_entities): Redo for clarity,
12157 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12158
78834453 12159 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12160 (font_score): Avoid potential overflow in diff calculation.
78834453 12161
0bc0b309 12162 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12163 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12164
e610eaca
PE
12165 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12166
b895abce
PE
12167 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12168 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12169 can always succeed if overflow has undefined behavior.
12170
1f1d9321 12171 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12172 (wordify): Omit three unnecessary tests.
1f1d9321 12173
c59478bc
PE
12174 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12175 All callers changed. This avoids the need for an unused var.
12176
79b73827
PE
12177 * casefiddle.c (casify_region): Remove var that is set but not used.
12178
a4db5dfe
PE
12179 * dired.c (file_name_completion): Remove var that is set but not used.
12180
43aae36e
PE
12181 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12182
2a47c44d 12183 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12184 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12185
a37c69bf
PE
12186 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12187 Check for integer overflow on size calculations.
12188
328ab8e7
PE
12189 * buffer.c (Fprevious_overlay_change): Remove var that is set
12190 but not used.
12191
e5a2a5cb
PE
12192 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12193 Remove vars that are set but not used.
8d84a6eb 12194 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12195 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12196
a60e5f68
PE
12197 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12198
f661cb61 12199 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12200 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12201
f0397f5a
PE
12202 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12203 that are set but not used.
12204
8664db06 12205 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12206 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12207
6abdaa4a
PE
12208 * xselect.c (x_get_local_selection, x_handle_property_notify):
12209 Remove vars that are set but not used.
12210
0ce7538d 12211 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12212 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12213
9ae848fc
PE
12214 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12215 Remove var that is set but not used.
0b918413
PE
12216 (scroll_bar_windows_size): Now size_t, not int.
12217 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12218 Check for overflow.
9ae848fc 12219
a5a62657
PE
12220 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12221 (map_tty_color) [!defined MSDOS]: Likewise.
12222
5c5cdd39
PE
12223 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12224
66ebf983
PE
12225 * coding.c: Remove vars that are set but not used.
12226 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12227 All callers changed.
12228 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12229 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12230 (decode_coding_charset): Remove vars that are set but not used.
12231
1be4d761
PE
12232 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12233 that is set but not used.
12234
47553fa8
PE
12235 * print.c (print_object): Remove var that is set but not used.
12236
1f7196bf 12237 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12238 The gnulib version avoids calling malloc in the usual case,
12239 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12240 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12241 * filelock.c (current_lock_owner): Likewise.
12242 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12243 * sysdep.c: Include allocator.h, careadlinkat.h.
12244 (emacs_no_realloc_allocator): New static constant.
12245 (emacs_readlink): New function.
fdb61804
PE
12246 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12247 ../lib/careadlinkat.h.
d1fdcab7 12248
f84c17c7
SM
122492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12250
12251 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12252 first non-nil return value).
12253
ef3862ad
JD
122542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12255
12256 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12257 if not defined (Bug#8403).
12258
376a7006
JB
122592011-04-02 Juanma Barranquero <lekktu@gmail.com>
12260
12261 * xdisp.c (display_count_lines): Remove parameter `start',
12262 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12263 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12264 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12265 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12266 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12267 and thereabouts. All callers changed.
12268 (get_per_char_metric): Remove parameter `f', unused since
12269 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12270
6ca3801d
JM
122712011-04-02 Jim Meyering <meyering@redhat.com>
12272
12273 do not dereference NULL upon failed strdup
12274 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12275 (ns_get_family): Likewise.
12276
d8e2b5ba
JB
122772011-04-02 Juanma Barranquero <lekktu@gmail.com>
12278
12279 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12280
8c74fcbd
JD
122812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12282
12283 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12284 later (Bug#8403).
12285
7200d79c
SM
122862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12287
03408648 12288 Add lexical binding.
7200d79c 12289
03408648
SM
12290 * window.c (Ftemp_output_buffer_show): New fun.
12291 (Fsave_window_excursion):
12292 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12293
12294 * lread.c (lisp_file_lexically_bound_p): New function.
12295 (Fload): Bind Qlexical_binding.
12296 (readevalloop): Remove `evalfun' arg.
12297 Bind Qinternal_interpreter_environment.
12298 (Feval_buffer): Bind Qlexical_binding.
12299 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12300 Mark as dynamic.
12301 (syms_of_lread): Declare `lexical-binding'.
12302
12303 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12304
12305 * keyboard.c (eval_dyn): New fun.
12306 (menu_item_eval_property): Use it.
ca105506
SM
12307
12308 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12309
03408648
SM
12310 * fns.c (concat, mapcar1): Accept byte-code-functions.
12311
12312 * eval.c (Fsetq): Handle lexical vars.
12313 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12314 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12315 (FletX, Flet): Obey lexical binding.
12316 (Fcommandp): Handle closures.
12317 (Feval): New `lexical' arg.
12318 (eval_sub): New function extracted from Feval. Use it almost
12319 everywhere where Feval was used. Look up vars in lexical env.
12320 Handle closures.
12321 (Ffunctionp): Move from subr.el.
12322 (Ffuncall): Handle closures.
12323 (apply_lambda): Remove `eval_flags'.
12324 (funcall_lambda): Handle closures and new byte-code-functions.
12325 (Fspecial_variable_p): New function.
12326 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12327 but without exporting it to Lisp.
23aba0ea 12328
23aba0ea 12329 * doc.c (Fdocumentation, store_function_docstring):
03408648 12330 * data.c (Finteractive_form): Handle closures.
23aba0ea 12331
03408648
SM
12332 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12333 interactive spec.
ba83908c 12334
04f2d78b
CB
12335 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12336 New byte-codes.
03408648
SM
12337 (exec_byte_code): New function extracted from Fbyte_code to handle new
12338 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12339
03408648 12340 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12341
03408648 12342 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12343
e2abce01
JB
123442011-03-31 Juanma Barranquero <lekktu@gmail.com>
12345
12346 * xdisp.c (redisplay_internal): Fix prototype.
12347
63696a73 123482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12349
63696a73 12350 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12351 (try_scrolling): Use it when setting scroll_limit.
12352 Limit scrolling to 100 screen lines.
63696a73
EZ
12353 (redisplay_window): Even when falling back on "recentering",
12354 position point in the window according to scroll-conservatively,
12355 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12356
12357 (try_scrolling): When point is above the window, allow searching
12358 as far as scroll_max, or one screenful, to compute vertical
12359 distance from PT to the scroll margin position. This prevents
12360 try_scrolling from unnecessarily failing when
12361 scroll-conservatively is set to a value slightly larger than the
12362 window height. Clean up the case of PT below the margin at bottom
12363 of window: scroll_max can no longer be INT_MAX. When aggressive
12364 scrolling is in use, don't let point enter the opposite scroll
12365 margin as result of the scroll.
12366 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12367 threshold of 100 lines for never-recentering scrolling.
12368
e4cc2dfc
JB
123692011-03-31 Juanma Barranquero <lekktu@gmail.com>
12370
12371 * dispextern.h (move_it_by_lines):
12372 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12373 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12374 (message_log_check_duplicate): Remove parameters `prev_bol' and
12375 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12376 (redisplay_internal): Remove parameter `preserve_echo_area',
12377 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12378
12379 * indent.c (Fvertical_motion):
12380 * window.c (window_scroll_pixel_based, Frecenter):
12381 Don't pass `need_y_p' to `move_it_by_lines'.
12382
1c470562
SM
123832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12384
44f230aa
SM
12385 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12386 steal a few bits to be more compact.
12387 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12388 Remove unneeded casts.
12389
1c470562
SM
12390 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12391
888adce9
ZK
123922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12393
12394 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12395 binding" message (bug#7967).
12396
f838ed7b
PE
123972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12398
77861b95
PE
12399 Fix more problems found by GCC 4.6.0's static checks.
12400
de6dbc14
PE
12401 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12402 Remove unused local var.
12403
f838ed7b
PE
12404 * editfns.c (Fmessage_box): Remove unused local var.
12405
792c7b2b
PE
12406 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12407 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12408 Omit unused local vars.
c499e557 12409 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12410 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12411 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12412 Omit unused local var.
12413
ba0165e1
PE
12414 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12415 Don't assume string length fits in int.
32ad8845 12416 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12417 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12418
3c59b4c9
PE
12419 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12420 instead of alloca (Bug#8344).
12421
a3eed478 12422 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12423 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12424
eb4d412d
PE
12425 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12426
1658b401
PE
12427 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12428 concerns.
12429
12430 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12431
12432 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12433
9a2c6e05
PE
12434 * keyboard.c (syms_of_keyboard): Use the same style as later
12435 in this function when indexing through an array. This also
12436 works around GCC bug 48267.
12437
03d0a109
PE
12438 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12439
44f730c8
PE
12440 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12441
fe75f926
PE
12442 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12443 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12444
ffa8c828
PE
12445 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12446 This avoids undefined behavior on integer overflow, and is a bit
12447 more convenient anyway since it is compared to a size_t variable.
12448
c5101a77
PE
12449 Variadic C functions now count arguments with size_t, not int.
12450 This avoids an unnecessary limitation on 64-bit machines, which
12451 caused (substring ...) to crash on large vectors (Bug#8344).
12452 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12453 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12454 All variadic functions and their callers changed accordingly.
c5101a77
PE
12455 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12456 * data.c (arith_driver, float_arith_driver): Likewise.
12457 * editfns.c (general_insert_function): Likewise.
12458 * eval.c (struct backtrace.nargs, interactive_p)
12459 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12460 (funcall_lambda, mark_backtrace): Likewise.
12461 * fns.c (concat): Likewise.
12462 * frame.c (x_set_frame_parameters): Likewise.
12463 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12464 0 if not found, not -1. All callers changed.
12465
dd3f25f7
PE
12466 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12467 (stack_copy_size): Now size_t, not int.
12468 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12469
461c2ab9
JB
124702011-03-28 Juanma Barranquero <lekktu@gmail.com>
12471
12472 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12473 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12474 All callers changed.
12475
12476 * lisp.h (multibyte_char_to_unibyte):
12477 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12478 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12479 * character.h (CHAR_TO_BYTE8):
12480 * cmds.c (internal_self_insert):
12481 * editfns.c (general_insert_function):
12482 * keymap.c (push_key_description):
12483 * search.c (Freplace_match):
12484 * xdisp.c (message_dolog, set_message_1): All callers changed.
12485
f6d62986
SM
124862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12487
12488 * keyboard.c (safe_run_hook_funcall): New function.
12489 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12490 don't set the hook to nil, but remove the offending function instead.
12491 (Qcommand_hook_internal): Remove, unused.
12492 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12493 Vcommand_hook_internal.
12494
12495 * eval.c (enum run_hooks_condition): Remove.
12496 (funcall_nil, funcall_not): New functions.
12497 (run_hook_with_args): Call each function through a `funcall' argument.
12498 Remove `cond' argument, now redundant.
12499 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12500 (Frun_hook_with_args_until_failure): Adjust accordingly.
12501 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12502
1db5b1ad
JB
125032011-03-28 Juanma Barranquero <lekktu@gmail.com>
12504
12505 * dispextern.h (string_buffer_position): Remove declaration.
12506
12507 * print.c (strout): Remove parameter `multibyte', unused since
12508 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12509
12510 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12511 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12512 All callers changed.
12513
12514 * w32.c (_wsa_errlist): Use braces for struct initializers.
12515
12516 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12517 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12518 All callers changed.
12519 (string_buffer_position): Likewise. Also, make static (it's never
12520 used outside xdisp.c).
12521 (cursor_row_p): Remove parameter `w', unused since
12522 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12523 (decode_mode_spec): Remove parameter `precision', introduced during
12524 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12525 All callers changed.
12526
5ffb62aa
JD
125272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12528
12529 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12530
461c2ab9 125312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12532
12533 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12534 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12535 (ns_update_auto_hide_menu_bar): New functions.
12536 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12537 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12538 ns_constrain_all_frames.
12539 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12540 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12541
5c380ffb
JD
125422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12543
12544 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12545
9af30bdf
GM
125462011-03-27 Glenn Morris <rgm@gnu.org>
12547
12548 * syssignal.h: Replace RETSIGTYPE with void.
12549 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12550 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12551 Replace SIGTYPE with void everywhere.
12552 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12553 * s/template.h (SIGTYPE): Remove commented out definition.
12554
e2abce01
JB
125552011-03-26 Eli Zaretskii <eliz@gnu.org>
12556
12557 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12558 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12559
f868cd8a
JB
125602011-03-26 Juanma Barranquero <lekktu@gmail.com>
12561
59eb0929
JB
12562 * w32.c (read_unc_volume): Use parameter `henum', instead of
12563 global variable `wget_enum_handle'.
12564
12565 * keymap.c (describe_vector): Remove parameters `indices' and
12566 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12567 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12568
f868cd8a
JB
12569 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12570
12571 * keyboard.c (timer_check): Remove parameter `do_it_now',
12572 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12573 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12574 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12575
12576 * keyboard.c (read_char):
12577 * w32menu.c (w32_menu_display_help):
12578 * xmenu.c (show_help_event, menu_help_callback):
12579 Adjust calls to `show_help_echo'.
12580
12581 * gtkutil.c (xg_maybe_add_timer):
12582 * keyboard.c (readable_events):
12583 * process.c (wait_reading_process_output):
12584 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12585
12586 * insdel.c (adjust_markers_gap_motion):
12587 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12588 (gap_left, gap_right): Don't call it.
12589
2ecf6fdb
CY
125902011-03-25 Chong Yidong <cyd@stupidchicken.com>
12591
12592 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12593 incurred during fontification.
12594
6b1f9ba4
JB
125952011-03-25 Juanma Barranquero <lekktu@gmail.com>
12596
12597 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12598 (DEFVAR_PER_BUFFER): Don't pass it.
12599
12600 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12601 (scrolling_window): Don't pass it.
12602
0f4a96b5
JB
126032011-03-25 Juanma Barranquero <lekktu@gmail.com>
12604
12605 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12606
12607 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12608 and `suffix'.
12609 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12610 of variables specific to SELinux and computation of `encoded_absname'.
12611
12612 * image.c (XPutPixel): Remove unused variable `height'.
12613
12614 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12615
12616 * unexw32.c (get_section_info): Remove unused variable `section'.
12617
12618 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12619 (system_process_attributes): Remove unused variable `sess'.
12620 (sys_read): Remove unused variable `err'.
12621
12622 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12623 (w32_wnd_proc): Remove unused variable `isdead'.
12624 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12625 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12626 (x_create_tip_frame): Remove unused variable `tem'.
12627
12628 * w32inevt.c (w32_console_read_socket):
12629 Remove unused variable `no_events'.
12630
12631 * w32term.c (x_draw_composite_glyph_string_foreground):
12632 Remove unused variable `width'.
12633
1149507c
JB
126342011-03-24 Juanma Barranquero <lekktu@gmail.com>
12635
12636 * w32term.c (x_set_glyph_string_clipping):
12637 Don't pass uninitialized region to CombineRgn.
12638
9c88f339
JB
126392011-03-23 Juanma Barranquero <lekktu@gmail.com>
12640
12641 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12642 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12643 (Fx_close_connection): Remove unused variable `i'.
12644
12645 * w32font.c (w32font_draw): Return number of glyphs.
12646 (w32font_open_internal): Remove unused variable `i'.
12647 (w32font_driver): Add missing initializer.
12648
12649 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12650 (fill_in_menu): Remove unused variable `items_added'.
12651
12652 * w32term.c (last_mouse_press_frame): Remove static global variable.
12653 (w32_clip_to_row): Remove unused variable `f'.
12654 (x_delete_terminal): Remove unused variable `i'.
12655
12656 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12657 (NOTHING): Remove unused static global variable.
12658 (uniscribe_check_otf): Remove unused variable `table'.
12659 (uniscribe_font_driver): Add missing initializers.
12660
dee091a3
JD
126612011-03-23 Julien Danjou <julien@danjou.info>
12662
12663 * term.c (Fsuspend_tty, Fresume_tty):
12664 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12665 * window.c (temp_output_buffer_show):
12666 * insdel.c (signal_before_change):
12667 * frame.c (Fhandle_switch_frame):
12668 * fileio.c (Fdo_auto_save):
12669 * emacs.c (Fkill_emacs):
12670 * editfns.c (save_excursion_restore):
12671 * cmds.c (internal_self_insert):
12672 * callint.c (Fcall_interactively):
12673 * buffer.c (Fkill_all_local_variables):
12674 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12675 Use Frun_hooks.
0f4a96b5 12676 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12677 unconditionally since it does the check itself.
dee091a3 12678
2c520ab5 126792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12680
c9c49752
PE
12681 Fix more problems found by GCC 4.5.2's static checks.
12682
8abc3f12
PE
12683 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12684 the first time through the loop, since we know p0 < p1 then.
12685 This also avoids a gcc -Wstrict-overflow warning.
12686
a2d26660
PE
12687 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12688 leading to a memory leak, possible in functions like
12689 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12690 of objects (Bug#8318).
a2d26660 12691
916c72e9
PE
12692 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12693 that could (at least in theory) be that large.
12694
19ab8a18
PE
12695 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12696 This is less likely to overflow, and avoids undefined behavior if
12697 overflow does occur. All callers changed. Use strtoul to scan
12698 for the unsigned long integer.
b7cbbd6f
PE
12699 (pint2hrstr): Simplify and tune code slightly.
12700 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12701
f0641eff
PE
12702 * scroll.c (do_scrolling): Work around GCC bug 48228.
12703 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12704
7f650bb9
PE
12705 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12706 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12707 (validate_x_resource_name): Simplify count usage.
12708 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12709
37dd57d1
PE
12710 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12711 fail (Bug#8306).
81e56e61 12712
699979fc 12713 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12714
401bf9b4
PE
12715 * process.c (Fmake_network_process): Use socklen_t, not int,
12716 where POSIX says socklen_t is required in portable programs.
12717 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12718 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12719 (Fmake_network_process, server_accept_connection):
12720 (wait_reading_process_output, read_process_output):
12721 Likewise.
12722
b93aacde
PE
12723 * process.c: Rename or move locals to avoid shadowing.
12724 (list_processes_1, Fmake_network_process):
12725 (read_process_output_error_handler, exec_sentinel_error_handler):
12726 Rename or move locals.
4dc343ee 12727 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12728 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12729 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12730 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12731 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12732
af8a867c 12733 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12734 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12735 Include tparam.h instead, since it declares them.
af8a867c
PE
12736 * cm.h (PC): Remove extern decl; tparam.h now does this.
12737 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12738 * terminfo.c: Include tparam.h, to check interfaces.
12739 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12740 (tparam): Adjust signature to match interface in tparam.h;
12741 this removes some undefined behavior. Check that outstring and len
12742 are zero, which they always are with Emacs.
12743 * tparam.h (PC, BC, UP): New extern decls.
12744
0248044d 12745 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12746 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12747
8ff096c1 12748 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12749 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12750 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12751 (ftfont_list): Remove unused local.
49eaafba
PE
12752 (get_adstyle_property, ftfont_pattern_entity):
12753 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12754 Rename locals to avoid shadowing.
8ff096c1 12755
e2be39f6
PE
12756 * xfont.c (xfont_list_family): Mark var as initialized.
12757
c9735e30
PE
12758 * xml.c (make_dom): Now static.
12759
8f5201ae
PE
12760 * composite.c (composition_compute_stop_pos): Rename local to
12761 avoid shadowing.
b246f932
PE
12762 (composition_reseat_it): Remove unused locals.
12763 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12764 (composition_update_it): Mark var as initialized.
11b61122
PE
12765 (find_automatic_composition): Mark vars as initialized,
12766 with a FIXME (Bug#8290).
8f5201ae 12767
760fbc2c
PE
12768 character.h: Rename locals to avoid shadowing.
12769 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12770 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12771 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12772 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12773 to avoid shadowing.
12774
ff08eb85
PE
12775 * textprop.c (property_change_between_p): Remove; unused.
12776
fc7bf025
PE
12777 * intervals.c (interval_start_pos): Now static.
12778
235d7abc
PE
12779 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12780
44f230aa
SM
12781 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12782 Rename locals to avoid shadowing.
3e7d6594 12783
50060332
PE
12784 * sound.c (wav_play, au_play, Fplay_sound_internal):
12785 Fix pointer signedness.
d01f234b 12786 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12787 (wav_play): Initialize a variable to 0, to prevent undefined
12788 behavior (Bug#8278).
50060332 12789
c4fc4e30
PE
12790 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12791
918436ed
PE
12792 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12793
c939f91b
PE
12794 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12795 clobbering (Bug#8298).
b9c7f648
PE
12796 * sysdep.c (sys_subshell): Likewise.
12797 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12798
6bd8c144
PE
12799 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12800 This should get cleaned up, so that child_setup has the
12801 same signature on all platforms.
12802
7710357c 12803 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12804 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12805
c59da222
CY
128062011-03-22 Chong Yidong <cyd@stupidchicken.com>
12807
12808 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12809 not to be necessary, and produces flickering.
12810
66b87493
GM
128112011-03-20 Glenn Morris <rgm@gnu.org>
12812
12813 * config.in: Remove file.
12814
45b6f6d5
JB
128152011-03-20 Juanma Barranquero <lekktu@gmail.com>
12816
12817 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12818 are now in src/globals.h.
12819 (syms_of_minibuf): Remove spurious & from previous change.
12820
cd394be1 128212011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12822
12823 * minibuf.c (completing-read-function): New variable.
12824 (completing-read-default): Rename from completing-read.
12825 (completing-read): Call completing-read-function.
12826
b14e3e21
CY
128272011-03-19 Juanma Barranquero <lekktu@gmail.com>
12828
12829 * xfaces.c (Fx_load_color_file):
12830 Read color file from absolute filename (bug#8250).
12831
f2b726e6
JB
128322011-03-19 Juanma Barranquero <lekktu@gmail.com>
12833
12834 * makefile.w32-in: Update dependencies.
12835
09f6ff02
EZ
128362011-03-17 Eli Zaretskii <eliz@gnu.org>
12837
12838 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12839
29a6015a
PE
128402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12841
a3a6c54e
PE
12842 Fix more problems found by GCC 4.5.2's static checks.
12843
b766f867
PE
12844 * process.c (make_serial_process_unwind, send_process_trap):
12845 (sigchld_handler): Now static.
12846
be02381c
PE
12847 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12848 That way, the code declares only the vars that it needs.
12849 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12850 * s/cygwin.h (PTY_ITERATION): Likewise.
12851 * s/darwin.h (PTY_ITERATION): Likewise.
12852 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12853
57048744
PE
12854 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12855 * process.c (allocate_pty): Don't declare stb unless it's needed.
12856
7914961c 12857 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12858 (CONSTANTLIM): Remove; unused.
12859 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12860 Define only if needed.
7914961c 12861
b3967b18
PE
12862 * unexelf.c (unexec): Name an expression,
12863 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12864 Use a different way to cause a compilation error if anyone uses
12865 n rather than nn, a way that does not involve shadowing.
73366a00 12866 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12867
29a6015a
PE
12868 * deps.mk (unexalpha.o): Remove; unused.
12869
43cfc33e 12870 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12871 * unexec.h: New file.
ce701a33
PE
12872 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12873 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12874 Depend on unexec.h.
12875 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12876 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12877 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12878 Change as necessary to match prototype in unexec.h.
ce701a33 12879
01f44d5a
PE
12880 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12881 shadowing.
4f63c6bb 12882 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12883
a6670b0b
PE
12884 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12885 Rename locals to avoid shadowing.
12886
cef2010d 12887 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12888 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12889
d4d7173a
PE
12890 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12891
f08b802a
PE
12892 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12893 warning when compiling print.c.
12894
3ddb0639
PE
12895 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12896 instead of using an uninitialized var.
5ad03b97 12897 (font_sort_entities): Mark var as initialized.
3ddb0639 12898
170a2692
PE
12899 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12900
e663c700
PE
12901 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12902 pointers to constants.
89bc529a 12903 (font_parse_fcname): Remove unused vars.
7b81e2d0 12904 (font_delete_unmatched): Now static.
ea838e10 12905 (font_get_spec): Remove; unused.
13a547c6
PE
12906 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12907 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12908 Rename or move locals to avoid shadowing.
e663c700 12909
2a80c887 12910 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12911 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12912
1384fa33 12913 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12914 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12915
8b2c52e9
PE
12916 * alloc.c (mark_backtrace): Move decl from here ...
12917 * lisp.h: ... to here, so that it can be checked.
12918
475545b5 12919 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12920 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12921 (lisp_indirect_variable): Name an expression,
12922 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12923 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12924
b1349114 12925 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12926 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12927 Use const pointer when appropriate.
b1349114 12928
a2928364
PE
12929 * lisp.h (get_system_name, get_operating_system_release):
12930 Move decls here, to check interfaces.
12931 * process.c (get_operating_system_release): Move decl to lisp.h.
12932 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12933 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12934 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12935 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12936 (Fformat_time_string, Fencode_time, Finsert_char):
12937 (Ftranslate_region_internal, Fformat):
12938 Rename or remove local vars to avoid shadowing.
9710023e 12939 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12940
a415e694
PE
12941 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12942 avoid shadowing.
12943
8ef4622d
PE
12944 * lisp.h (eassert): Check that the argument compiles, even if
12945 ENABLE_CHECKING is not defined.
12946
946f9a5b
PE
12947 * data.c (Findirect_variable): Name an expression, to avoid
12948 gcc -Wbad-function-cast warning.
112396d6 12949 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12950 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12951 (Fmake_variable_buffer_local, Fmake_local_variable):
12952 Mark variables as initialized.
52746918 12953 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12954
e5aab7e7 12955 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12956 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12957 Rename locals to avoid shadowing.
dff45157
PE
12958 (mark_stack): Move local variables into the #ifdef region where
12959 they're used.
7bc26fdb
PE
12960 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12961 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12962 needed otherwise.
12963 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12964 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12965 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12966
e5aab7e7
PE
12967 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12968 avoids undefined behavior in theory.
12969
4da60324
PE
12970 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12971
88043301
PE
12972 Use functions, not macros, for up- and down-casing (Bug#8254).
12973 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12974 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12975 to use the following functions instead of these macros.
12976 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12977 EMACS_INT, since callers assume the returned value fits in int.
12978 (upcase1): Likewise, for UPCASE_TABLE.
12979 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12980 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12981 the race-condition problem in the old DOWNCASE.
88043301 12982
19ed5445
PE
12983 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12984 Rename locals to avoid shadowing.
12985 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12986 (regex_compile, re_search_2, re_match_2_internal):
12987 Remove unused local vars.
952db0d7
PE
12988 (FREE_VAR): Rewrite so as not to use empty "else",
12989 which gcc can warn about.
da053e48 12990 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12991 (RETALLOC_IF): Define only if needed.
12992 (WORDCHAR_P): Likewise. This one is never needed, but is used
12993 only in a comment talking about a compiler bug, so put inside
12994 the #if 0 of that comment.
12995 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12996 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12997 Remove; unused.
19ed5445 12998
1f3561e4 12999 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13000 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13001 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13002
ded6f8f7
PE
13003 * search.c (simple_search): Remove unused var.
13004
dbd37a95
PE
13005 * dired.c (compile_pattern): Move decl from here ...
13006 * lisp.h: ... to here, so that it can be checked.
13007 (struct re_registers): New forward decl.
13008
7e47afad
PE
13009 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13010
85f24f61
PE
13011 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13012 All uses changed.
13013 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13014 Rename locals to avoid shadowing.
5671df8f 13015 (Fvertical_motion): Mark locals as initialized.
85f24f61 13016
181aa2be 13017 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13018 (casify_region): Mark local as initialized.
181aa2be 13019
930d429c
PE
13020 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13021
7082eac6
PE
13022 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13023 New macros, so that the caller can use some names other than
13024 gcpro1, gcpro2, etc.
13025 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13026 of the new macros.
13027 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13028 argument, for consistency with GCPRO2_VAR, etc: it is now the
13029 prefix of the variable, not the variable itself. All uses
13030 changed.
38b2c076
PE
13031 * dired.c (directory_files_internal, file_name_completion):
13032 Rename locals to avoid shadowing.
13033
15206ed9
PE
13034 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13035 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13036 dired.c's scmp function, had undefined behavior.
13037 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13038 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13039 * buffer.h: ... to here, because these macros use current_buffer,
13040 and the new implementation with inline functions needs to have
13041 current_buffer in scope now, rather than later when the macros
13042 are used.
13043 (downcase, upcase1): New static inline functions.
13044 (DOWNCASE, UPCASE1): Reimplement using these functions.
13045 This avoids undefined behavior in expressions like
13046 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13047 from race conditions in accessing the global variables
13048 case_temp1 and case_temp2.
13049 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13050 * lisp.h (case_temp1, case_temp2): Remove their decls.
13051 * character.h (ASCII_CHAR_P): Move from here ...
13052 * lisp.h: ... to here, so that the inline functions mentioned
13053 above can use them.
13054
4a6bea26
PE
13055 * dired.c (directory_files_internal_unwind): Now static.
13056
f14b7e14
PE
13057 * fileio.c (file_name_as_directory, directory_file_name):
13058 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13059 Now static.
2893f146
PE
13060 (file_name_as_directory): Use const pointers when appropriate.
13061 (Fexpand_file_name): Likewise. In particular, newdir might
13062 point at constant storage, so make it a const pointer.
fd4ead52 13063 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13064 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13065 signedness issues.
f839df0c
PE
13066 (Fset_file_times, Finsert_file_contents, auto_save_error):
13067 Rename locals to avoid shadowing.
f14b7e14 13068
5716756e 13069 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13070 (Ftry_completion, Fall_completions): Rename or remove locals
13071 to avoid shadowing.
5716756e 13072
b4c3046a
PE
13073 * marker.c (bytepos_to_charpos): Remove; unused.
13074
b45db522
PE
13075 * lisp.h (verify_bytepos, count_markers): New decls,
13076 so that gcc does not warn that these functions aren't declared.
13077
85876d07
PE
13078 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13079 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13080 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13081 (copy_text): Remove unused local var.
85876d07 13082
03d78a21 13083 * filelock.c (within_one_second): Now static.
b3dd38ab 13084 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13085
5df8f01b
PE
13086 * buffer.c (fix_overlays_before): Mark locals as initialized.
13087 (fix_start_end_in_overlays): Likewise. This function should be
13088 simplified by using pointers-to-pointers, but that's a different
13089 matter.
b1d876f1 13090 (switch_to_buffer_1): Now static.
8f54f30a
PE
13091 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13092 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13093
a70072c9 13094 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13095 Fix pointer signedness issue.
edced198
PE
13096 (sys_subshell): Mark local as volatile if checking for lint,
13097 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13098 (MAXPATHLEN): Define only if needed.
a70072c9 13099
a0977c44
PE
13100 * process.c (serial_open, serial_configure): Move decls from here ...
13101 * systty.h: ... to here, so that they can be checked.
13102
a884fdcc
PE
13103 * fns.c (get_random, seed_random): Move extern decls from here ...
13104 * lisp.h: ... to here, so that they can be checked.
13105
604efe86 13106 * sysdep.c (reset_io): Now static.
b8950c94 13107 (wait_for_termination_signal): Remove; unused.
604efe86 13108
38fc62d9
PE
13109 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13110 (copy_keymap_item, append_key, push_text_char_description):
13111 Now static.
1004a21a 13112 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13113 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13114 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13115 (describe_map_tree):
13116 Rename locals to avoid shadowing.
38fc62d9 13117
2f2650da
PE
13118 * keyboard.c: Declare functions static if they are not used elsewhere.
13119 (echo_char, echo_dash, cmd_error, top_level_2):
13120 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13121 (read_char, kbd_buffer_get_event, make_lispy_position):
13122 (make_lispy_event, make_lispy_movement, apply_modifiers):
13123 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13124 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13125 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13126 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13127 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13128
a053e86c 13129 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13130 (mark_kboards): Move decl here ...
13131 * alloc.c (mark_kboards): ... from here.
a053e86c 13132
4752793e
PE
13133 * lisp.h (force_auto_save_soon): New decl.
13134
74f10ca7 13135 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13136 (DEFINE_DUMMY_FUNCTION): New macro.
13137 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13138 Use it.
c03cd23f
PE
13139 (main): Add casts to avoid warnings
13140 if GCC considers string literals to be constants.
74f10ca7 13141
022e70d4
PE
13142 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13143
59d6fe83
PE
13144 * dbusbind.c: Pointer signedness fixes.
13145 (xd_signature, xd_append_arg, xd_initialize):
13146 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13147 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13148 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13149 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13150
78320123
PE
13151 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13152 if GCC considers string literals to be constants.
49cebcca 13153 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13154
35ac2a97
SM
131552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13156
fb103ca9
SM
13157 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13158 (print_preprocess, print_object): New macro to fix last change.
13159
35ac2a97
SM
13160 * print.c (print_preprocess): Don't forget font objects.
13161
62973b41
JB
131622011-03-16 Juanma Barranquero <lekktu@gmail.com>
13163
13164 * emacs.c (USAGE3): Doc fixes.
13165
0e48bb22
AS
131662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13167
13168 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13169 structure.
13170
7684e57b
JB
131712011-03-14 Juanma Barranquero <lekktu@gmail.com>
13172
13173 * lisp.h (VWindow_system, Qfile_name_history):
13174 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13175 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13176 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13177
13178 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13179 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13180
13181 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13182 * w32console.c (detect_input_pending, read_input_pending)
13183 (encode_terminal_code):
13184 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13185 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13186 (w32_system_caret_y, Qfile_name_history):
13187 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13188 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13189 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13190 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13191 * w32proc.c (Qlocal, report_file_error):
13192 * w32term.c (Vwindow_system, updating_frame):
13193 * w32uniscribe.c (initialized, uniscribe_font_driver):
13194 Remove unneeded extern declarations.
13195
2aa46d6c
CY
131962011-03-14 Chong Yidong <cyd@stupidchicken.com>
13197
c96bbc66 13198 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13199
cffc6f3b
CY
132002011-03-13 Chong Yidong <cyd@stupidchicken.com>
13201
13202 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13203 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13204 These macros can no longer be used for assignment.
13205
44f230aa
SM
13206 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13207 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13208 (record_buffer_markers, fetch_buffer_markers): New functions for
13209 recording and fetching special buffer markers.
13210 (set_buffer_internal_1, set_buffer_temp): Use them.
13211
13212 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13213
13214 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13215
13216 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13217 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13218
13219 * xdisp.c (hscroll_window_tree):
13220 (reconsider_clip_changes): Use PT instead of BUF_PT.
13221
d251f04b
EZ
132222011-03-13 Eli Zaretskii <eliz@gnu.org>
13223
13224 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13225 $(EMACS_ROOT)/lib/intprops.h.
13226
f0c77cd1
PE
132272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13228
3eca4629
PE
13229 Fix more problems found by GCC 4.5.2's static checks.
13230
7c86ee98
PE
13231 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13232 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13233 (xg_free_frame_widgets): Make it clear that a local variable is
13234 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13235 (gdk_window_get_screen): Make it clear that this macro is needed
13236 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13237 (int_gtk_range_get_value): New function, which avoids a diagnostic
13238 from gcc -Wbad-function-cast.
13239 (xg_set_toolkit_scroll_bar_thumb): Use it.
13240 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13241 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13242 (get_utf8_string, xg_get_file_with_chooser):
13243 Rename locals to avoid shadowing.
13244 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13245
41729b81
PE
13246 * xgselect.c (xg_select): Remove unused var.
13247
f0c77cd1
PE
13248 * image.c (four_corners_best): Mark locals as initialized.
13249 (gif_load): Initialize transparent_p to zero (Bug#8238).
13250 Mark another local as initialized.
ec6cf4c6 13251 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13252
ce0ad53d 13253 * image.c (clear_image_cache): Now static.
d5d5a617 13254 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13255 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13256 (x_edge_detection): Remove unnecessary cast that
13257 gcc -Wbad-function-cast diagnoses.
2037898d 13258 (gif_load): Fix pointer signedness.
6ae141d6
PE
13259 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13260 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13261
33383987 132622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13263
d32df629
PE
13264 Improve quality of tests for time stamp overflow.
13265 For example, without this patch (encode-time 0 0 0 1 1
13266 1152921504606846976) returns the obviously-bogus value (-948597
13267 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13268 reports time overflow. See
13269 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13270 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13271 * editfns.c: Include limits.h and intprops.h.
13272 (TIME_T_MIN, TIME_T_MAX): New macros.
13273 (time_overflow): Move earlier, to before first use.
13274 (hi_time, lo_time): New functions, for an accurate test for
13275 out-of-range times.
13276 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13277 (Fget_internal_run_time): Don't assume time_t fits in int.
13278 (make_time): Use list2 instead of Fcons twice.
13279 (Fdecode_time): More accurate test for out-of-range times.
13280 (check_tm_member): New function.
13281 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13282 (lisp_time_argument): Don't rely on undefined left-shift and
13283 right-shift behavior when checking for time stamp overflow.
8be6f318 13284
fe31d94c
PE
13285 * editfns.c (time_overflow): New function, refactoring common code.
13286 (Fformat_time_string, Fdecode_time, Fencode_time):
13287 (Fcurrent_time_string): Use it.
13288
8be6f318
PE
13289 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13290 * dired.c (make_time): Move to ...
13291 * editfns.c (make_time): ... here.
13292 * systime.h: Note the move.
13293
09d9db2c 132942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13295
126bc0dc
YM
13296 * fringe.c (update_window_fringes): Remove unused variables.
13297
c47cbdfd
YM
13298 * unexmacosx.c (copy_data_segment): Also copy __got section.
13299 (Bug#8223)
13300
7ac80be9
EZ
133012011-03-12 Eli Zaretskii <eliz@gnu.org>
13302
c96bbc66 13303 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13304 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13305 Constify `char *' arguments and their references according to
13306 prototypes in tparam.h.
13307
ecb0f94d 13308 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13309
7ac80be9
EZ
13310 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13311 Adapt all references accordingly.
13312
13313 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13314
ef1fd07e
TT
133152011-03-11 Tom Tromey <tromey@redhat.com>
13316
13317 * buffer.c (syms_of_buffer): Remove obsolete comment.
13318
7ef4b50c
EZ
133192011-03-11 Eli Zaretskii <eliz@gnu.org>
13320
13321 * termhooks.h (encode_terminal_code): Declare prototype.
13322
13323 * msdos.c (encode_terminal_code): Don't declare prototype.
13324
13325 * term.c (encode_terminal_code): Now external again, used by
13326 w32console.c and msdos.c.
13327
44f230aa
SM
13328 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13329 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13330
4b1ec863 133312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13332
1714f52b 13333 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13334
4b1ec863
PE
13335 * fringe.c (update_window_fringes): Mark locals as initialized
13336 (Bug#8227).
13337 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13338
524c7aa6
PE
13339 * alloc.c (mark_fringe_data): Move decl from here ...
13340 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13341 to check its interface.
13342 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13343
a5c0af81 13344 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13345 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13346 (fontset_font): Mark local as initialized.
a9a06e0b 13347 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13348
b4716021
PE
13349 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13350
811e9bac 13351 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13352 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13353 (x_own_selection, Fx_disown_selection_internal): Rename locals
13354 to avoid shadowing.
13355 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13356
7e3ab302
PE
13357 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13358 so that the caller can use some name other than gcpro1.
13359 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13360 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13361 (Fx_backspace_delete_keys_p):
13362 Use them to avoid shadowing, and rename vars to avoid shadowing.
13363 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13364 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13365 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13366 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13367 Remove unused locals.
7e3ab302
PE
13368 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13369 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13370 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13371 macros.
f78faa98 13372
e2b13473
PE
13373 * xterm.h (x_mouse_leave): New decl.
13374
77f23912
PE
13375 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13376 Remove unused functions.
cdf4ba58
PE
13377 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13378 (x_calc_absolute_position): Now static.
7411c686 13379 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13380 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13381 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13382 unless they are used.
38d0b34a
PE
13383 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13384 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13385 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13386 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13387 (x_error_catcher, x_connection_closed, x_error_handler):
13388 (x_error_quitter, xembed_send_message, x_iconify_frame):
13389 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13390 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13391 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13392
44f230aa
SM
13393 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13394 Rename or move locals to avoid shadowing.
6b463e58 13395 (tty_defined_color, merge_face_heights): Now static.
5967d051 13396 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13397 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13398 does not deduce is never used uninitialized.
73719eba
PE
13399 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13400 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13401
426994c3 13402 * terminal.c (store_terminal_param): Now static.
5489860b 13403
032f1620 13404 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13405 (set_frame_menubar): Remove unused local.
d4323972 13406 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13407 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13408 since they might point to immutable storage.
281585b0
PE
13409 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13410 since it's unused otherwise.
032f1620 13411
367c19e5 13412 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13413 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13414 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13415 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13416 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13417 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13418 does not deduce are never used uninitialized.
70739cbe 13419
07b48fa9
PE
13420 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13421
8868a238 13422 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13423 * window.c (window_loop, size_window):
13424 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13425
7e5cf297 13426 * window.c (display_buffer): Now static.
d6550a9f
PE
13427 (size_window): Mark variables that gcc -Wuninitialized
13428 does not deduce are never used uninitialized.
a586633d
PE
13429 * window.h (check_all_windows): New decl, to forestall
13430 gcc -Wmissing-prototypes diagnostic.
5b555da1 13431 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13432
f6095868
PE
13433 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13434 shadowing.
13435 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13436 Include <limits.h>.
13437 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13438 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13439 (load_charset_map): Mark variables that gcc -Wuninitialized
13440 does not deduce are never used uninitialized.
53df7c11 13441 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13442
f38b440c
PE
13443 * coding.c (coding_set_source, coding_set_destination):
13444 Use "else { /* comment */ }" rather than "else /* comment */;"
13445 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13446 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13447 a block, when the outer 'i' will do.
13448 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13449 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13450 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13451 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13452 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13453 Rename locals to avoid shadowing.
13454 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13455 * coding.c (emacs_mule_char, encode_invocation_designation):
13456 Now static, since they're not used elsewhere.
413bb2db 13457 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13458 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13459 (decode_coding_emacs_mule): Mark variables that gcc
13460 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13461 (detect_coding_iso_2022): Initialize a local variable that might
13462 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13463 this initialization is needed. (Bug#8211)
5f58e762
PE
13464 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13465 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13466 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13467 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13468 Remove unused macros.
f38b440c 13469
232b38b9 13470 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13471 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13472 * character.c (string_count_byte8): Likewise.
232b38b9 13473
fb90da1b
PE
13474 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13475 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13476
fb93dbc2
PE
13477 * chartab.c (copy_sub_char_table): Now static, since it's not used
13478 elsewhere.
5c156ace
PE
13479 (sub_char_table_ref_and_range, char_table_ref_and_range):
13480 Rename locals to avoid shadowing.
bbcd0949 13481 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13482
7d3b3862 13483 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13484 (BIDI_BOB): Remove unused macro.
7d3b3862 13485
6be7d3da
PE
13486 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13487 deduce are never used uninitialized.
c2ed9c8b 13488 * term.c (encode_terminal_code): Likewise.
6be7d3da 13489
75f8807f 13490 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13491
50938595
PE
13492 * tparam.h: New file.
13493 * term.c, tparam.h: Include it.
13494 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13495 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13496 Move these decls to tparam.h, and make them agree with what
13497 is actually in tparam.c. The previous trick of using incompatible
13498 decls in different modules does not conform to the C standard.
13499 All callers of tparam changed to use tparam's actual API.
13500 * tparam.c (tparam1, tparam, tgoto):
13501 Use const pointers where appropriate.
13502
fbceeba2
PE
13503 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13504 * cm.h (struct cm): Likewise.
13505 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13506 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13507 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13508 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13509 (turn_on_face, init_tty): Likewise.
13510 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13511
7f3f1250
PE
13512 * term.c (term_mouse_position): Rename local to avoid shadowing.
13513
e6ca6543
PE
13514 * alloc.c (mark_ttys): Move decl from here ...
13515 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13516
c40f8d15
AS
135172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13518
13519 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13520
cfe0661d
JB
135212011-03-09 Juanma Barranquero <lekktu@gmail.com>
13522
13523 * search.c (compile_pattern_1): Remove argument regp, unused since
13524 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13525 (compile_pattern): Don't pass it.
13526
0afb4571
J
135272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13528
13529 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13530 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13531 for ! HAVE_GTK3.
13532 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13533
13534 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13535
13536 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13537 gdk_window_get_screen, gdk_window_get_geometry,
13538 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13539 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13540 (xg_get_pixbuf_from_pixmap): New function.
13541 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13542 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13543 Call xg_get_pixbuf_from_pixmap instead of
13544 gdk_pixbuf_get_from_drawable.
13545 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13546 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13547 (xg_check_special_colors): Use GtkStyleContext and its functions
13548 for HAVE_GTK3.
13549 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13550 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13551 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13552 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13553 Call gtk_widget_get_preferred_size.
0afb4571
J
13554 (xg_frame_resized): gdk_window_get_geometry only takes 5
13555 parameters.
44f230aa
SM
13556 (xg_win_to_widget, xg_event_is_for_menubar):
13557 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13558 (xg_set_widget_bg): New function.
13559 (delete_cb): New function.
895009e1 13560 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13561 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13562 (xg_set_background_color): Call xg_set_widget_bg.
13563 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13564 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13565 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13566 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13567 if ! HAVE_GTK3.
13568 (update_frame_tool_bar): Call gtk_widget_hide.
13569 (xg_initialize): Use GDK_KEY_g.
13570
13571 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13572 if ! HAVE_GTK3
13573 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13574
13575 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13576 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13577 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13578
1c2cc4ef
JB
135792011-03-08 Juanma Barranquero <lekktu@gmail.com>
13580
13581 * w32xfns.c (select_palette): Check success of RealizePalette against
13582 GDI_ERROR, not zero.
13583
33383987 13584See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13585
13586;; Local Variables:
13587;; coding: utf-8
aac0c6e3
MR
13588;; End:
13589
2f097256 13590 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13591
13592 This file is part of GNU Emacs.
13593
13594 GNU Emacs is free software: you can redistribute it and/or modify
13595 it under the terms of the GNU General Public License as published by
13596 the Free Software Foundation, either version 3 of the License, or
13597 (at your option) any later version.
13598
13599 GNU Emacs is distributed in the hope that it will be useful,
13600 but WITHOUT ANY WARRANTY; without even the implied warranty of
13601 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13602 GNU General Public License for more details.
13603
13604 You should have received a copy of the GNU General Public License
13605 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.