Move Dissociated Press section of manual into Amusements.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b1f58454
CY
12011-07-12 Chong Yidong <cyd@stupidchicken.com>
2
3 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4
22b9578d
LMI
52011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6
6e70ab07
LMI
7 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8 are the mini-buffer and the echo area (bug#3320).
9
22b9578d
LMI
10 * term.c (init_tty): Remove support for supdup, c10 and perq
11 terminals, which are no longer supported (bug#1482).
12
8974cc9f
JB
132011-07-10 Johan Bockgård <bojohan@gnu.org>
14
15 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
16
a560d974
JD
172011-07-10 Jan Djärv <jan.h.d@swipnet.se>
18
19 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
20 for non-popups (Bug#3642).
21
1dae0f0a
AS
222011-07-10 Andreas Schwab <schwab@linux-m68k.org>
23
268c2c36 24 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 25 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
26 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
27 * cm.c (losecursor): Likewise.
1dae0f0a
AS
28 * data.c (fmod): Likewise.
29 * dispnew.c (swap_glyphs_in_rows): Likewise.
30 * emacs.c (memory_warning_signal): Likewise.
31 * floatfns.c (float_error): Likewise.
32 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
33 (otf_open, font_otf_capability, generate_otf_features)
34 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
35 Likewise.
36 * image.c (pbm_read_file): Likewise.
37 * indent.c (string_display_width): Likewise.
38 * intervals.c (check_for_interval, search_for_interval)
39 (inc_interval_count, count_intervals, root_interval)
40 (adjust_intervals_for_insertion, make_new_interval): Likewise.
41 * lread.c (defalias): Likewise.
268c2c36 42 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
43 * regex.c (set_image_of_range_1, set_image_of_range)
44 (regex_grow_registers): Likewise.
45 * sysdep.c (strerror): Likewise.
46 * termcap.c (valid_filename_p, tprint, main): Likewise.
47 * tparam.c (main): Likewise.
48 * unexhp9k800.c (run_time_remap, save_data_space)
49 (update_file_ptrs, read_header, write_header, calculate_checksum)
50 (copy_file, copy_rest, display_header): Likewise.
51 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
52 Likewise.
53 * xdisp.c (check_it): Likewise.
54 * xfaces.c (register_color, unregister_color, unregister_colors):
55 Likewise.
56 * xfns.c (print_fontset_result): Likewise.
57 * xrdb.c (member, fatal, main): Likewise.
58
99033785
PE
592011-07-10 Paul Eggert <eggert@cs.ucla.edu>
60
61 Fix minor problems found by static checking (Bug#9031).
62 * chartab.c (char_table_set_range, map_sub_char_table):
63 Remove unused locals.
64 (uniprop_table): Now static.
65 * composite.c (_work_char): Remove unused static var.
66
9cb2ac56
JB
672011-07-09 Juanma Barranquero <lekktu@gmail.com>
68
69 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
70
f25661f0
JD
712011-07-09 Jan Djärv <jan.h.d@swipnet.se>
72
73 * gtkutil.c (qttip_cb): Remove code without function.
74
8278c4fe
EZ
752011-07-09 Eli Zaretskii <eliz@gnu.org>
76
77 * w32.c (pthread_sigmask): New stub.
78
1692ae2d 792011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 80
8a6ebd58 81 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
82 sigprocmask is portable only for single-threaded applications, and
83 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
84 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
85 (LIBES): Use it.
86 * callproc.c (Fcall_process):
87 * process.c (create_process):
88 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
89 Use pthread_sigmask, not sigprocmask.
123403e4 90
1b854618
JD
912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
92
93 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
94 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
95 wrong (Bug#8591).
96
3fe4b549
JD
972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
98
0ce7e563
JD
99 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
100 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
101 (xg_hide_tooltip): Fix comment.
102
3fe4b549
JD
103 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
104 in registerServicesMenuSendTypes.
105 (validRequestorForSendType): Don't check ns_return_types.
106
107 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
108 ns_return_type.
109
5df75e47
JR
1102011-07-08 Jason Rumney <jasonr@gnu.org>
111
112 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
113 frame struct members of non-existent frames (Bug#6284).
114
699c10bd
JD
1152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
116
4393663b
JD
117 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
118 variable firstTime not needed on OSX >= 10.6.
119 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
120 >= 10.5. Use setKnobProportion, setDoubleValue.
121
122 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
123 (MAC_OS_X_VERSION_10_5): Define if not defined.
124 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
125 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
126 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
127
128 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
129 cString and lossyCString on OSX >= 10.4
130
131 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
132 sizeToFit on OSX >= 10.2.
133
134 * nsimage.m (allocInitFromFile): Don't use deprecated method
135 bestRepresentationForDevice on OSX >= 10.6.
136
137 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
138 to avoid warning.
139
140 * emacs.c: Declare unexec_init_emacs_zone.
141
a63e0781
JD
142 * nsgui.h: Fix compiler warning about gnulib redefining verify.
143
699c10bd
JD
144 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
145
146 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
147 on svcsMenu (Bug#8842).
148
149 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
150 ns_return_types.
151 (Fns_list_services): Just return Qnil on 10.6, code not working there.
152
153 * nsterm.m (QUTF8_STRING): Declare.
154 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
155 (validRequestorForSendType): Return type is (id).
156 Change indexOfObjectIdenticalTo to indexOfObject.
157 Check if we have local selection before returning self (Bug#8842).
158 (writeSelectionToPasteboard): Put local selection into paste board
159 if we have a local selection (Bug#8842).
160 (syms_of_nsterm): DEFSYM QUTF8_STRING.
161
162 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
163 (ns_get_local_selection): Declare.
164
54e10184
LMI
1652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
166
9888ff71
LMI
167 * keymap.c (describe_map_tree): Don't insert a double newline at
168 the end of the buffer (bug#1169) and return whether we inserted
169 something.
170
54e10184
LMI
171 * callint.c (Fcall_interactively): Change "reading args" to
172 "providing args" to try to clarify what it does (bug#1010).
173
15fa4783
KH
1742011-07-07 Kenichi Handa <handa@m17n.org>
175
176 * composite.c (composition_compute_stop_pos): Ignore a static
177 composition starting before CHARPOS (Bug#8915).
178
179 * xdisp.c (handle_composition_prop): Likewise.
180
a8815b00
EZ
1812011-07-07 Eli Zaretskii <eliz@gnu.org>
182
183 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
184 (Bug#9015)
185
ef7b981d 1862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
187
188 * character.h (unicode_category_t): New enum type.
189
190 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
191 (Qchar_code_property_table): New variable.
192 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
193 (UNIPROP_COMPRESSED_FORM_P): New macros.
194 (char_table_ascii): Uncompress the compressed values.
195 (sub_char_table_ref): New arg is_uniprop. Callers changed.
196 Uncompress the compressed values.
197 (sub_char_table_ref_and_range): Likewise.
198 (char_table_ref_and_range): Uncompress the compressed values.
199 (sub_char_table_set): New arg is_uniprop. Callers changed.
200 Uncompress the compressed values.
201 (sub_char_table_set_range): Args changed. Callers changed.
202 (char_table_set_range): Adjuted for the above change.
203 (map_sub_char_table): Delete args default_val and parent. Add arg
204 top. Give decoded values to a Lisp function.
205 (map_char_table): Adjusted for the above change. Give decoded
206 values to a Lisp function. Gcpro more variables.
207 (uniprop_table_uncompress)
208 (uniprop_decode_value_run_length): New functions.
209 (uniprop_decoder, uniprop_decoder_count): New variables.
210 (uniprop_get_decoder, uniprop_encode_value_character)
211 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
212 New functions.
213 (uniprop_encoder, uniprop_encoder_count): New variables.
214 (uniprop_get_encoder, uniprop_table)
215 (Funicode_property_table_internal, Fget_unicode_property_internal)
216 (Fput_unicode_property_internal): New functions.
217 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
218 Sunicode_property_table_internal, Sget_unicode_property_internal,
219 and Sput_unicode_property_internal. Defvar_lisp
220 char-code-property-alist.
221
222 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
223 Vunicode_category_table.
224
225 * font.c (font_range): Adjusted for the change of
226 Vunicode_category_table.
227
76b397fb
DN
2282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
229
230 * m/iris4d.h: Remove file, move contents ...
231 * s/irix6-5.h: ... here.
232
22b4128e
PE
2332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
234
235 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
236 * alloc.c (mark_buffer):
237 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
238 (clone_per_buffer_values): Don't assume that
22b4128e
PE
239 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
240 This isn't true in general, and it's particularly not true
241 if Emacs is configured with --with-wide-int.
242 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
243 New macros, used in the buffer.c change.
244
869795d6
JD
2452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
246
247 * xsettings.c: Use both GConf and GSettings if both are available.
248 (store_config_changed_event): Add comment.
249 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
250 (store_tool_bar_style_changed): New functions.
251 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
252 (struct xsettings): Move font inside HAVE_XFT.
253 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
254 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
255 Move inside HAVE_XFT.
256 (something_changed_gsettingsCB): Renamed from something_changedCB.
257 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
258 also.
259 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
260 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
261 (something_changed_gconfCB): Renamed from something_changedCB.
262 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
263 (parse_settings): Move check for font inside HAVE_XFT.
264 (read_settings, apply_xft_settings): Add comment.
265 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
266 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
267 call store_font_name_changed.
268 (xft_settings_event): Add comment.
269 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
270 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
271 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
272 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
273 (xsettings_initialize): Call init_gsettings last.
274 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
275 comment.
276
d8ed26bd
PE
2772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
278
279 Random fixes. E.g., (random) never returned negative values.
280 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
281 subseconds part to the entropy, as that's a bit more random.
282 Prefer signed to unsigned, since the signedness doesn't matter and
283 in general we prefer signed. When given a limit, use a
284 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
285 latter isn't right if USE_2_TAGS_FOR_INTS.
286 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
287 not 0..VALMASK. Don't discard "excess" bits that random () returns.
288
cabf1cac
SM
2892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 * textprop.c (text_property_stickiness):
292 Obey Vtext_property_default_nonsticky.
293 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
294 * w32fns.c (syms_of_w32fns):
295 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
296
6e9b2be9
PE
2972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
298
299 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
300 This is more efficient than Ffile_directory_p and avoids a minor race.
301
90186c68
LMI
3022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
303
7c301272
LMI
304 * buffer.c (Foverlay_put): Say what the return value is
305 (bug#7835).
306
c4f2d8d4
LMI
307 * fileio.c (barf_or_query_if_file_exists): Check first if the file
308 is a directory before asking whether to use the file name
309 (bug#7564).
ad637907
LMI
310 (barf_or_query_if_file_exists): Make the "File is a directory"
311 error be more correct.
c4f2d8d4 312
90186c68
LMI
313 * fns.c (Frequire): Remove the mention of the .gz files, since
314 that's installation-specific, but keep the mention of
315 `get-load-suffixes'.
316
da64016e
PE
3172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
318
319 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
320 Report string overflow if the output is too long.
321
7d47b580
JB
3222011-07-04 Juanma Barranquero <lekktu@gmail.com>
323
a555cb87
JB
324 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
325 (syms_of_gnutls): Remove duplicate DEFSYM for
326 Qgnutls_bootprop_verify_hostname_error, an error for
327 Qgnutls_bootprop_verify_error (which is no longer used).
328
7d47b580
JB
329 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
330 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
331 Also (re)move comments that are misplaced or no longer relevant.
332
1e49bfab
LMI
3332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
334
335 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
336
1485f4c0
CY
3372011-07-03 Chong Yidong <cyd@stupidchicken.com>
338
339 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
340 and background color parameters if they have been changed.
341
a9ab721e
LMI
3422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
343
344 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
345
cf7cff57
PE
3462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
347
2e13213d
PE
348 * xsettings.c (SYSTEM_FONT): Define only when used.
349 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
350
cf7cff57
PE
351 * keymap.c (access_keymap_1): Now static.
352
7a8e04f7
CY
3532011-07-02 Chong Yidong <cyd@stupidchicken.com>
354
355 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
356 leave any prefix arg for the up event (Bug#1586).
357
61352f62
LMI
3582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
359
69bb1ef7
LMI
360 * lread.c (syms_of_lread): Mention single symbols defined by
361 `defvar' or `defconst' (bug#7154).
362
61352f62 363 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 364 (Frequire): Mention get-load-suffixes.
61352f62 365
28545e04
MR
3662011-07-02 Martin Rudalics <rudalics@gmx.at>
367
368 * window.h (window): Remove clone_number slot.
369 * window.c (Fwindow_clone_number, Fset_window_clone_number):
370 Remove.
371 (make_parent_window, make_window, saved_window)
372 (Fset_window_configuration, save_window_save): Don't deal with
373 clone numbers.
374 * buffer.c (Qclone_number): Remove declaration.
375 (sort_overlays, overlay_strings): Don't deal with clone numbers.
376
3349e122
SM
3772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
378
379 Add multiple inheritance to keymaps.
380 * keymap.c (Fmake_composed_keymap): New function.
381 (Fset_keymap_parent): Simplify.
382 (fix_submap_inheritance): Remove.
383 (access_keymap_1): New function extracted from access_keymap to handle
384 embedded parents and handle lists of maps.
385 (access_keymap): Use it.
386 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
387 (Fcopy_keymap): Handle embedded parents.
388 (Fcommand_remapping, define_as_prefix): Simplify.
389 (Fkey_binding): Simplify.
390 (syms_of_keymap): Move minibuffer-local-completion-map,
391 minibuffer-local-filename-completion-map,
392 minibuffer-local-must-match-map, and
393 minibuffer-local-filename-must-match-map to Elisp.
394 (syms_of_keymap): Defsubr make-composed-keymap.
395 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
396 (parse_menu_item): Trivial simplification.
397
3279eb87
GM
3982011-07-01 Glenn Morris <rgm@gnu.org>
399
400 * Makefile.in (SETTINGS_LIBS): Fix typo.
401
4550efdf
KI
4022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
403
404 * coding.c (Fencode_coding_string): Record the last coding system
405 used, as the function doc string says (bug#8738).
406
0949d2b6
JD
4072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
408
409 * xsettings.c (store_monospaced_changed): Take new font as arg and
410 check for change against current_mono_font.
411 (EMACS_TYPE_SETTINGS): Remove this and related defines.
412 (emacs_settings_constructor, emacs_settings_get_property)
413 (emacs_settings_set_property, emacs_settings_class_init)
414 (emacs_settings_init, gsettings_obj): Remove.
415 (something_changedCB): New function for HAVE_GSETTINGS.
416 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
417 with value as argument.
418 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
419 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 420 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
421 "changed".
422
423 * xgselect.c: Add defined (HAVE_GSETTINGS).
424 (xgselect_initialize): Ditto.
425
426 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
427 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
428 xg_select.
429
bbc6b304
PE
4302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
431
432 * eval.c (struct backtrace): Simplify and port the data structure.
433 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
434 signed bit field, as this assumption is not portable and it makes
435 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
436 "char debug_on_exit : 1" as this is not portable either; instead,
437 use the portable "unsigned int debug_on_exit : 1". Remove unused
438 member evalargs. Remove obsolete comments about cc bombing out.
439
9851bfc5
JD
4402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
441
51bb811f 442 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
443 Let HAVE_GSETTINGS override HAVE_GCONF.
444 (store_monospaced_changed): New function.
445 (EMACS_SETTINGS): A new type derived from GObject to handle
446 GSettings notifications.
447 (emacs_settings_constructor, emacs_settings_get_property)
448 (emacs_settings_set_property, emacs_settings_class_init):
449 New functions.
450 (gsettings_client, gsettings_obj): New variables.
451 (GSETTINGS_SCHEMA): New define.
452 (something_changedCB): Call store_monospaced_changed.
453 (init_gsettings): New function.
454 (xsettings_initialize): Call init_gsettings.
455 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
456 to NULL.
457
458 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
459 GCONF_CFLAGS/LIBS.
460
5386012d
MR
4612011-06-29 Martin Rudalics <rudalics@gmx.at>
462
463 * window.c (resize_root_window, grow_mini_window)
464 (shrink_mini_window): Rename Qresize_root_window to
465 Qwindow_resize_root_window and Qresize_root_window_vertically to
466 Qwindow_resize_root_window_vertically.
467
f13e0b08
PE
4682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
469
470 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
471
94515237
JB
4722011-06-27 Juanma Barranquero <lekktu@gmail.com>
473
474 * makefile.w32-in: Redesign dependencies so they reflect more
475 clearly which files are directly included by each source file,
476 and not through other includes.
477
e43b6e43
MR
4782011-06-27 Martin Rudalics <rudalics@gmx.at>
479
480 * buffer.c (Qclone_number): Declare static and DEFSYM it.
481 (sort_overlays, overlay_strings): When an overlay's clone number
482 matches the window's clone number process the overlay even if
483 the overlay's window property doesn't match the current window.
484
d68443dc
MR
485 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
486 (Fwindow_hchild): Rename to Fwindow_left_child.
487 (Fwindow_next): Rename to Fwindow_next_sibling.
488 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
489 (resize_window_check): Rename to window_resize_check.
490 (resize_window_apply): Rename to window_resize_apply.
491 (Fresize_window_apply): Rename to Fwindow_resize_apply.
492 (Fdelete_other_windows_internal, resize_frame_windows)
493 (Fsplit_window_internal, Fdelete_window_internal)
494 (grow_mini_window, shrink_mini_window)
495 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 496
c7e73be5
JD
4972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
498
499 * emacsgtkfixed.h: State that this is only used with Gtk+3.
500 (emacs_fixed_set_min_size): Remove.
501 (emacs_fixed_new): Take frame as argument.
502
503 * emacsgtkfixed.c: State that this is only used with Gtk+3.
504 (_EmacsFixedPrivate): Remove minwidth/height.
505 Add struct frame *f.
506 (emacs_fixed_init): Initialize priv->f.
507 (get_parent_class, emacs_fixed_set_min_size): Remove.
508 (emacs_fixed_new): Set priv->f to argument.
509 (emacs_fixed_get_preferred_width)
510 (emacs_fixed_get_preferred_height): Use min_width/height from
511 frames size_hint to set minimum and natural (Bug#8919).
512 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
513 and use min_width/height from frames size_hint to set
514 min_width/height (Bug#8919).
515
516 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
517 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
518 Fix indentation.
c7e73be5 519
cf99dcf8
EZ
5202011-06-26 Eli Zaretskii <eliz@gnu.org>
521
522 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
523 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
524 called at ZV.
525
029529ac
CY
5262011-06-26 Chong Yidong <cyd@stupidchicken.com>
527
528 * process.c (wait_reading_process_output): Bypass select if
529 waiting for a cell while ignoring keyboard input, and input is
530 pending. Suggested by Jan Djärv (Bug#8869).
531
7a7ef429
PE
5322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
533
534 Use gnulib's dup2 module instead of rolling our own.
535 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
536
11fdef7d 5372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
538
539 * dispnew.c (scrolling_window): Before scrolling, turn off a
540 mouse-highlight in the window being scrolled.
541
cd3520a4
JB
5422011-06-24 Juanma Barranquero <lekktu@gmail.com>
543
544 Move DEFSYM to lisp.h and use everywhere.
545
546 * character.h (DEFSYM): Move declaration...
547 * lisp.h (DEFSYM): ...here.
548
549 * gnutls.c:
550 * minibuf.c:
551 * w32menu.c:
552 * w32proc.c:
553 * w32select.c: Don't include character.h.
554
555 * alloc.c (syms_of_alloc):
556 * buffer.c (syms_of_buffer):
557 * bytecode.c (syms_of_bytecode):
558 * callint.c (syms_of_callint):
559 * casefiddle.c (syms_of_casefiddle):
560 * casetab.c (init_casetab_once):
561 * category.c (init_category_once, syms_of_category):
562 * ccl.c (syms_of_ccl):
563 * cmds.c (syms_of_cmds):
564 * composite.c (syms_of_composite):
565 * dbusbind.c (syms_of_dbusbind):
566 * dired.c (syms_of_dired):
567 * dispnew.c (syms_of_display):
568 * doc.c (syms_of_doc):
569 * editfns.c (syms_of_editfns):
570 * emacs.c (syms_of_emacs):
571 * eval.c (syms_of_eval):
572 * fileio.c (syms_of_fileio):
573 * fns.c (syms_of_fns):
574 * frame.c (syms_of_frame):
575 * fringe.c (syms_of_fringe):
576 * insdel.c (syms_of_insdel):
577 * keymap.c (syms_of_keymap):
578 * lread.c (init_obarray, syms_of_lread):
579 * macros.c (syms_of_macros):
580 * msdos.c (syms_of_msdos):
581 * print.c (syms_of_print):
582 * process.c (syms_of_process):
583 * search.c (syms_of_search):
584 * sound.c (syms_of_sound):
585 * syntax.c (init_syntax_once, syms_of_syntax):
586 * terminal.c (syms_of_terminal):
587 * textprop.c (syms_of_textprop):
588 * undo.c (syms_of_undo):
589 * w32.c (globals_of_w32):
590 * window.c (syms_of_window):
591 * xdisp.c (syms_of_xdisp):
592 * xfaces.c (syms_of_xfaces):
593 * xfns.c (syms_of_xfns):
594 * xmenu.c (syms_of_xmenu):
595 * xsettings.c (syms_of_xsettings):
596 * xterm.c (syms_of_xterm): Use DEFSYM.
597
4228cf16
TZ
5982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
599
cd3520a4 600 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 601
7fcccf1e
PE
6022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
603
7efb4e0e
PE
604 Integer and buffer overflow fixes (Bug#8873).
605
ff5844ad
PE
606 * print.c (printchar, strout): Check for string overflow.
607 (PRINTPREPARE, printchar, strout):
608 Don't set size unless allocation succeeds.
609
90532f02
PE
610 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
611 for sizes. Check for string overflow more accurately.
612 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
613
6d84508d
PE
614 * macros.c: Integer and buffer overflow fixes.
615 * keyboard.h (struct keyboard.kbd_macro_bufsize):
616 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
617 Use ptrdiff_t, not int, for sizes.
618 Don't increment bufsize until after realloc succeeds.
619 Check for size-calculation overflow.
620 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
621
437b2cb4
PE
622 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
623
8b9ac8b4
PE
624 * lread.c: Integer overflow fixes.
625 (read_integer): Radix is now EMACS_INT, not int,
626 to improve quality of diagnostics for out-of-range radices.
627 Calculate buffer size correctly for out-of-range radices.
628 (read1): Check for integer overflow in radices, and in
629 read-circle numbers.
82cb60d3
PE
630 (read_escape): Avoid int overflow.
631 (Fload, openp, read_buffer_size, read1)
632 (substitute_object_recurse, read_vector, read_list, map_obarray):
633 Use ptrdiff_t, not int, for sizes.
634 (read1): Use EMACS_INT, not int, for sizes.
20270765 635 Check for size overflow.
8b9ac8b4 636
7fcccf1e
PE
637 * image.c (cache_image): Check for size arithmetic overflow.
638
bfbbd7e7
PE
639 * lread.c: Integer overflow issues.
640 (saved_doc_string_size, saved_doc_string_length)
641 (prev_saved_doc_string_size, prev_saved_doc_string_length):
642 Now ptrdiff_t, not int.
643 (read1): Don't assume doc string length fits in int. Check for
644 out-of-range doc string lengths.
645 (read_list): Don't assume file position fits in int.
39019e54 646 (read_escape): Check for hex character overflow.
bfbbd7e7 647
4e323265
LL
6482011-06-22 Leo Liu <sdl.web@gmail.com>
649
650 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
651 Move to minibuffer.el.
652
85fece3e
PE
6532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
654
20b84ce9 655 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
656 The following patches are for when GLYPH_DEBUG && !XASSERT.
657 * dispextern.h (trace_redisplay_p, dump_glyph_string):
658 * dispnew.c (flush_stdout):
659 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
660 Mark as externally visible.
661 * dispnew.c (check_window_matrix_pointers): Now static.
662 * dispnew.c (window_to_frame_vpos):
663 * xfns.c (unwind_create_frame):
664 * xterm.c (x_check_font): Remove unused local.
665 * scroll.c (CHECK_BOUNDS):
666 * xfaces.c (cache_fache): Rename local to avoid shadowing.
667 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
668 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
669 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
670 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
671 Now static.
672 (debug_method_add): Use va_list and vsprintf rather than relying
673 on undefined behavior with wrong number of arguments.
674 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
675 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
676 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
677 since we're not interested in debugging glyphs with old libraries.
678 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
679 GCC 4.6.0's static checking.
680
0766b489
PE
6812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
682
31fd4b32
PE
683 Integer overflow and signedness fixes (Bug#8873).
684 A few related buffer overrun fixes, too.
685
b79e8648
PE
686 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
687
0766b489
PE
688 * dispextern.h (struct face.stipple):
689 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
690 (x_bitmap_mask, x_allocate_bitmap_record)
691 (x_create_bitmap_from_data, x_create_bitmap_from_file)
692 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
693 (x_create_bitmap_from_xpm_data):
694 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
695 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
696 (.bitmaps_last):
697 * xfaces.c (load_pixmap):
698 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
699 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
700 (.bitmaps_last, struct x_output.icon_bitmap):
701 Use ptrdiff_t, not int, for bitmap indexes.
702 (x_allocate_bitmap_record): Check for size overflow.
703 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
704
b081724f
PE
705 Use ptrdiff_t, not int, for overlay counts.
706 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
707 * editfns.c (overlays_around, get_pos_property):
708 * textprop.c (get_char_property_and_overlay):
709 * xdisp.c (next_overlay_change, note_mouse_highlight):
710 * xfaces.c (face_at_buffer_position):
21514da7
PE
711 * buffer.c (OVERLAY_COUNT_MAX): New macro.
712 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
713 (Fnext_overlay_change, Fprevious_overlay_change)
714 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 715 Use ptrdiff_t, not int, for sizes.
21514da7 716 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 717
3de73e5e
PE
718 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
719
2606c57b
PE
720 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
721 (x_session_initialize): Do not assume string length fits in int.
722
aaafe47a
PE
723 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
724 This is unlikely, but can occur if DPI is outlandish.
725
2674ddc8 726 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
727 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
728
28154962
PE
729 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
730 * xrdb.c (magic_file_p, search_magic_path):
731 Omit last arg SUFFIX; it was always 0. All callers changed.
732 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
733
7de51af5
PE
734 * xfont.c (xfont_match): Avoid need for strlen.
735
25ed6cc3
PE
736 * xfns.c: Don't assume strlen fits in int.
737 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
738
4eab31dd
PE
739 * xdisp.c (message_log_check_duplicate): Return intmax_t,
740 not unsigned long, as we prefer signed integers. All callers changed.
741 Detect integer overflow in repeat count.
742 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 743 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 744
171e2a58
PE
745 * termcap.c: Don't assume sizes fit in int and never overflow.
746 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
747 (gobble_line): Check for size-calculation overflow.
748
ad39faca 749 * minibuf.c (Fread_buffer):
6e5bb2dc 750 * lread.c (intern, intern_c_string):
74ca2eb3
PE
751 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
752 Don't assume string length fits in int.
753
52c61c22 754 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
755 * gtkutil.c (style_changed_cb): Avoid need for strlen.
756
b5b8c9e5
PE
757 * font.c: Don't assume string length fits in int.
758 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
759 Use ptrdiff_t, not int.
ccd6111c
PE
760 (font_intern_prop): Don't assume string length fits in int.
761 Don't assume integer property fits in fixnum.
762 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 763
882f0d81 764 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 765 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
766 Reformulate so as not to need the command string.
767 Invoke gzip -cd rather than gunzip, as it's more portable.
768 (lock_info_type, lock_file_1, lock_file):
769 Don't assume pid_t and time_t fit in unsigned long.
770 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
771 (current_lock_owner): Prefer signed type for sizes.
772 Use memcpy, not strncpy, where memcpy is what is really wanted.
773 Don't assume (via atoi) that time_t and pid_t fit in int.
774 Check for time_t and/or pid_t out of range, e.g., via a network share.
775 Don't alloca where an auto var works fine.
776
93f4cf88
PE
777 * fileio.c: Fix some integer overflow issues.
778 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
779 Don't assume string length fits in int.
780 (directory_file_name): Don't assume string length fits in long.
781 (make_temp_name): Don't assume pid fits in int, or that its print
782 length is less than 20.
783
f3e92b69
PE
784 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
785
1bfdaf10
PE
786 * coding.c (make_subsidiaries): Don't assume string length fits in int.
787
35016e9a
PE
788 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
789
3d1e65a1
PE
790 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
791 We prefer signed integers, even for size calculations.
792
0b963a93
PE
793 * emacs.c: Don't assume string length fits in 'int'.
794 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
795 (main): Don't invoke strlen when not needed.
796
573f4b54
PE
797 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
798 (XD_DEBUG_MESSAGE): Don't waste a byte.
799
989f33ba
PE
800 * callproc.c (getenv_internal_1, getenv_internal)
801 (Fgetenv_internal):
965d34eb
PE
802 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
803
e4d29b33
PE
804 * lread.c (invalid_syntax): Omit length argument.
805 All uses changed. This doesn't fix a bug, but it simplifies the
806 code away from its former Hollerith-constant appearance, and it's
807 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 808 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 809
eb49b136
PE
810 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
811 This didn't break anything, but it didn't help either.
812 It's confusing to put a bogus integer in a place where the actual
813 value does not matter.
9f62aeb1 814 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 815 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 816
15375a22
PE
817 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
818 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
819 implementation.
b61cc01c
PE
820 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
821 We prefer signed types, and the value cannot exceed the EMACS_INT
822 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
823 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
824 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
825 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 826
53b2623d
PE
827 * indent.c (sane_tab_width): New function.
828 (current_column, scan_for_column, Findent_to, position_indentation)
829 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 830 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 831
51cab52b 832 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 833
f2ed8a70
PE
834 * lisp.h (lint_assume): New macro.
835 * composite.c (composition_gstring_put_cache):
836 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
837
abe80cc6
PE
838 * editfns.c, insdel.c:
839 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 840
b02c740e
PE
841 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
842
ebc96716
PE
843 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
844
b4e50fa0 845 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 846 Use much-faster test for byte-length change.
311d5d7c 847 Don't assume string byte-length fits in 'int'.
a4cf38e4 848 Check that character arg fits in 'int'.
85461888 849 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 850
c0c1ee9f
PE
851 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
852
a498d7f4
PE
853 * fns.c (concat): Catch string overflow earlier.
854 Do not rely on integer wraparound.
855
51cab52b
PE
856 * dispextern.h (struct it.overlay_strings_charpos)
857 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
858 * xdisp.c (forward_to_next_line_start)
859 (back_to_previous_visible_line_start)
860 (reseat_at_next_visible_line_start, next_element_from_buffer):
861 Don't arbitrarily truncate the value of 'selective' to int.
862
76031fad
PE
863 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
864
5eb55db9
PE
865 * composite.c: Don't truncate sizes to 'int'.
866 (composition_gstring_p, composition_reseat_it)
867 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
868 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
869 not EMACS_UINT, for indexes.
5eb55db9 870
0703a717
PE
871 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
872
d6202519
PE
873 * buffer.c: Include <verify.h>.
874 (struct sortvec.priority, struct sortstr.priority):
8961a454 875 Now EMACS_INT, not int.
c20998a7 876 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
877 (struct sortstr.size, record_overlay_string)
878 (struct sortstrlist.size, struct sortlist.used):
879 Don't truncate size to int.
880 (record_overlay_string): Check for size-calculation overflow.
d6202519 881 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 882
d5a19415
JM
8832011-06-22 Jim Meyering <meyering@redhat.com>
884
029529ac 885 Don't leak an XBM-image-sized buffer
d5a19415
JM
886 * image.c (xbm_load): Free the image buffer after using it.
887
a9041e6c
PE
8882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
889
890 Port to Sun C.
891 * composite.c (find_automatic_composition): Omit needless 'return 0;'
892 that Sun C diagnosed.
893 * fns.c (secure_hash): Fix pointer signedness issue.
894 * intervals.c (static_offset_intervals): New function.
895 (offset_intervals): Use it.
896
7f3f739f
LL
8972011-06-21 Leo Liu <sdl.web@gmail.com>
898
899 * deps.mk (fns.o):
900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
901 sha512.h.
902
903 * fns.c (secure_hash): Rename from crypto_hash_function and change
904 the first arg to accept symbols.
5b66d427 905 (Fsecure_hash): New primitive.
7f3f739f
LL
906 (syms_of_fns): New symbols.
907
76147d94
DD
9082011-06-20 Deniz Dogan <deniz@dogan.se>
909
910 * process.c (Fset_process_buffer): Clarify return value in
911 docstring.
912
7d7d0045
CY
9132011-06-18 Chong Yidong <cyd@stupidchicken.com>
914
915 * dispnew.c (add_window_display_history): Use BVAR.
916
917 * xdisp.c (debug_method_add): Use BVAR.
918 (check_window_end, dump_glyph_matrix, dump_glyph)
919 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
920
921 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
922 Likewise.
923
924 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
925 check till after the cache is created in init_frame_faces.
926
ff2bc410
SM
9272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
928
929 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
930
28177add
PE
9312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
932
dd3482fe
PE
933 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
934 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
935 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
936
393d71f3 937 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
938 * fileio.c (Finsert_file_contents):
939 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
940 Remove the old (too-loose) buffer overflow checks.
941 They weren't needed, since make_gap checks for buffer overflow.
942 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
943 The old code merely checked for Emacs fixnum overflow, and relied
944 on undefined (wraparound) behavior. The new code avoids undefined
945 behavior, and also checks for ptrdiff_t and/or size_t overflow.
946
2e6813b0 947 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
948 Tune. Don't use wider integers than needed. Don't use alloca.
949 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 950
599a9e4f
PE
951 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
952
99561444
PE
953 * insdel.c, lisp.h (buffer_overflow): New function.
954 (insert_from_buffer_1, replace_range, replace_range_2):
955 * insdel.c (make_gap_larger):
956 * editfns.c (Finsert_char):
957 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
958
28177add
PE
959 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
960
e69dafad
PE
9612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
962
a7af7fde 963 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 964
b1c46f02
PE
965 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
966 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
967
e69dafad
PE
968 * fileio.c: Don't assume EMACS_INT fits in off_t.
969 (emacs_lseek): New static function.
970 (Finsert_file_contents, Fwrite_region): Use it.
971 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
972
566684ea
PE
973 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
974
e6966cd6
PE
975 * fns.c: Don't overflow int when computing a list length.
976 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
977 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
978 truncation on 64-bit hosts. Check for QUIT every
979 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
980 faster and is responsive enough.
981 (Flength): Report an error instead of overflowing an integer.
982 (Fsafe_length): Return a float if the value is not representable
983 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 984 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 985 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 986
dd0b0efb
PE
987 * alloc.c: Check that resized vectors' lengths fit in fixnums.
988 (header_size, word_size): New constants.
989 (allocate_vectorlike): Don't check size overflow here.
990 (allocate_vector): Check it here instead, since this is the only
991 caller of allocate_vectorlike that could cause overflow.
992 Check that the new vector's length is representable as a fixnum.
993
86fe5cfe
PE
994 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
995 The previous code was bogus. For example, next_almost_prime (32)
996 returned 39, which is undesirable as it is a multiple of 3; and
997 next_almost_prime (24) returned 25, which is a multiple of 5 so
998 why was the code bothering to check for multiples of 7?
999
80e88859
PE
1000 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1001
4a2f0ad6
PE
1002 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1003
f66c7cf8
PE
1004 Variadic C functions now count arguments with ptrdiff_t.
1005 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1006 Back then I didn't know that the Emacs coding style prefers signed int.
1007 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1008 were being counted with int, which may truncate counts on 64-bit
1009 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1010 * lisp.h (struct Lisp_Subr.function.aMANY)
1011 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1012 Arg counts are now ptrdiff_t, not size_t.
1013 All variadic functions and their callers changed accordingly.
1014 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1015 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1016 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1017 * callint.c (Fcall_interactively): Check arg count for overflow,
1018 to avoid potential buffer overrun. Use signed char, not 'int',
1019 for 'varies' array, so that we needn't bother to check its size
1020 calculation for overflow.
1021 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1022 * eval.c (apply_lambda):
1023 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1024 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1025 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1026
a1759b76
PE
1027 * callint.c (Fcall_interactively): Don't use index var as event count.
1028
d96be9fc
PE
1029 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1030 * mem-limits.h (SIZE): Remove; no longer used.
1031
a690a978 1032 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1033
578c21e6
PE
1034 Remove unnecessary casts.
1035 * xterm.c (x_term_init):
1036 * xfns.c (x_set_border_pixel):
1037 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1038 These aren't needed now that we assume ANSI C.
1039
96f53c6c
PE
1040 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1041 It's more likely to cause problems (due to unsigned overflow)
1042 than to cure them.
1043
83c77d31
PE
1044 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1045
ee2079f1
PE
1046 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1047
6da65536
PE
1048 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1049
7147c4a4
PE
1050 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1051
193e32d9
PE
1052 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1053
e5533da6
PE
1054 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1055
9910e595
PE
1056 GLYPH_CODE_FACE returns EMACS_INT, not int.
1057 * dispextern.h (merge_faces):
1058 * xfaces.c (merge_faces):
01103c44
PE
1059 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1060 Don't assume EMACS_INT fits in int.
9910e595 1061
2638320e
PE
1062 * character.h (CHAR_VALID_P): Remove unused parameter.
1063 * fontset.c, lisp.h, xdisp.c: All uses changed.
1064
045eb8d9
PE
1065 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1066
c1f134b5
PE
1067 * fns.c (concat): Minor tuning based on overflow analysis.
1068 This doesn't fix any bugs. Use int to hold character, instead
1069 of constantly refetching from Emacs object. Use XFASTINT, not
1070 XINT, for value known to be a character. Don't bother comparing
1071 a single byte to 0400, as it's always less.
1072
395fcb93 1073 * floatfns.c (Fexpt):
327eeec8
PE
1074 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1075
abbd3d23
PE
1076 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1077 for characters.
1078
684a03ef
PE
1079 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1080
0fed43f3
PE
1081 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1082 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1083 incorrectly succeed when S was a string, because 4294967386 was
1084 truncated before it was used.
1085
8fd02eb7
PE
1086 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1087 Otherwise, an out-of-range integer could cause undefined behavior
1088 on a 64-bit host.
1089
f8c86b69
PE
1090 * composite.c: Use int, not EMACS_INT, for characters.
1091 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1092 EMACS_INT, for values that are known to be in character range.
1093 This doesn't fix any bugs but is the usual style inside Emacs and
1094 may generate better code on 32-bit machines.
1095
34206dd2
PE
1096 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1097 This is for reasons similar to the recent CHAR_STRING fix.
1098 * charset.c (Fencode_char): Check that character arg is actually
1099 a character. Pass an int to ENCODE_CHAR.
1100 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1101 wider than 'int', as a compile-time check to prevent future regressions
1102 in this area.
1103
c5958d4c 1104 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1105
1106 Make sure a 64-bit char is never passed to CHAR_STRING.
1107 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1108 by silently ignoring the top 32 bits, allowing some values
1109 that were far too large to be valid characters.
1110 * character.h: Include <verify.h>.
1111 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1112 arguments are no wider than unsigned, as a compile-time check
1113 to prevent future regressions in this area.
1114 * data.c (Faset):
01103c44 1115 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1116 (Fsubst_char_in_region):
1117 * fns.c (concat):
1118 * xdisp.c (decode_mode_spec_coding):
1119 Adjust to CHAR_STRING's new requirement.
1120 * editfns.c (Finsert_char, Fsubst_char_in_region):
1121 * fns.c (concat): Check that character args are actually
1122 characters. Without this test, these functions did the wrong
1123 thing with wildly out-of-range values on 64-bit hosts.
1124
d37ca623
PE
1125 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1126 These casts should not be needed on 32-bit hosts, either.
1127 * keyboard.c (read_char):
1128 * lread.c (Fload): Remove casts to unsigned.
1129
ea204efb
PE
1130 * lisp.h (UNSIGNED_CMP): New macro.
1131 This fixes comparison bugs on 64-bit hosts.
1132 (ASCII_CHAR_P): Use it.
1133 * casefiddle.c (casify_object):
01103c44 1134 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1135 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1136 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1137 * dispextern.h (FACE_FROM_ID):
1138 * keyboard.c (read_char): Use UNSIGNED_CMP.
1139
41cb286c
PE
1140 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1141 not to EMACS_INT, to avoid GCC warning.
1142
4a1b9832
PE
1143 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1144
55daad71
PE
1145 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1146 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1147 isn't needed on 32-bit machines.
8f95c75c 1148
01103c44
PE
1149 * buffer.c (Fgenerate_new_buffer_name):
1150 Use EMACS_INT for count, not int.
0ceccced 1151 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1152
1153 * data.c (Qcompiled_function): Now static.
1154
c6f072e7
PE
1155 * window.c (window_body_lines): Now static.
1156
20ce5912
PE
1157 * image.c (gif_load): Rename local to avoid shadowing.
1158
9c4c5f81
PE
1159 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1160 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1161 * alloc.c (make_save_value): Integer argument is now of type
1162 ptrdiff_t, not int.
1163 (mark_object): Use ptrdiff_t, not int.
1164 * lisp.h (pD): New macro.
1165 * print.c (print_object): Use it.
1166
c0c5c8ae
PE
1167 * alloc.c: Use EMACS_INT, not int, to count objects.
1168 (total_conses, total_markers, total_symbols, total_vector_size)
1169 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1170 (total_free_floats, total_floats, total_free_intervals)
1171 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1172 Now EMACS_INT, not int. All uses changed.
1173 (Fgarbage_collect): Compute overall total using a double, so that
1174 integer overflow is less likely to be a problem. Check for overflow
1175 when converting back to an integer.
5a25e253
PE
1176 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1177 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1178 These were 'int' variables that could overflow on 64-bit hosts;
1179 they were never used, so remove them instead of repairing them.
211a0b2a 1180 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1181 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1182 Previously, this ceilinged at INT_MAX, but that doesn't work on
1183 64-bit machines.
e46bb31a 1184 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1185
c78baabf 1186 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1187 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1188 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1189 when a (possibly-narrower) signed value would do just as well.
1190 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1191
c9d624c6
PE
1192 * alloc.c: Catch some string size overflows that we were missing.
1193 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1194 for convenience in STRING_BYTES_MAX.
1195 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1196 The definition here is exact; the one in lisp.h was approximate.
1197 (allocate_string_data): Check for string overflow. This catches
1198 some instances we weren't catching before. Also, it catches
1199 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1200 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1201 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1202
c9d624c6
PE
1203 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1204 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1205 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1206
353032ce
PE
1207 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1208
2bccce07
PE
1209 * alloc.c (Fmake_string): Check for out-of-range init.
1210
0ac30604
SM
12112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1214
c195f2de
JD
12152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1216
1217 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1218 xg_get_default_scrollbar_width.
1219
1220 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1221 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1222 (style_changed_cb): Call update_theme_scrollbar_width and call
1223 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1224 all frames (Bug#8505).
1225 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1226 Call gtk_window_set_resizable if HAVE_GTK3.
1227 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1228 and height if HAVE_GTK3 (Bug#8505).
1229 (scroll_bar_width_for_theme): New variable.
1230 (update_theme_scrollbar_width): New function.
1231 (xg_get_default_scrollbar_width): Move code to
1232 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1233 (xg_initialize): Call update_theme_scrollbar_width.
1234
1235 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1236
1237 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1238
e10ac9f1
MR
12392011-06-12 Martin Rudalics <rudalics@gmx.at>
1240
1241 * frame.c (make_frame): Call other_buffer_safely instead of
1242 other_buffer.
1243
1244 * window.c (temp_output_buffer_show): Call display_buffer with
1245 second argument Vtemp_buffer_show_specifiers and reset latter
1246 immediately after the call.
1247 (Vtemp_buffer_show_specifiers): New variable.
1248 (auto_window_vscroll_p, next_screen_context_lines)
1249 (Vscroll_preserve_screen_position): Remove leading asterisks from
1250 doc-strings.
1251
2d3c217e 12522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1253
7b7f97e8 1254 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1255 * buffer.c (Qclone_number): Remove for now, as it's unused.
1256 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1257 (record_buffer): Remove unused local.
1258 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1259 (set_frame_buffer_list): Remove; unused.
1260 * frame.h (other_visible_frames): Remove decl.
1261 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1262 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1263 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1264 if HAVE_GPM.
1265 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1266 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1267 Define only if HAVE_GPM.
1268 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1269 (update_hints_inhibit): Remove; never set. All uses removed.
1270 * widgetprv.h (emacsFrameClassRec): Remove decl.
1271 * window.c (delete_deletable_window): Now returns void, since it
1272 wasn't returning anything.
1273 (compare_window_configurations): Remove unused locals.
1274 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1275 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1276 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1277 the same widths as pointers. This follows up on the 2011-05-06 patch.
1278 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1279 * xterm.h: Likewise.
1280 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1281
1384b89e
JB
12822011-06-12 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * makefile.w32-in: Update dependencies.
1285 (LISP_H): Add lib/intprops.h.
1286
1100a63c
CY
12872011-06-11 Chong Yidong <cyd@stupidchicken.com>
1288
1289 * image.c (gif_load): Add animation frame delay to the metadata.
1290 (syms_of_image): Use DEFSYM. New symbol `delay'.
1291
6198ccd0
MR
12922011-06-11 Martin Rudalics <rudalics@gmx.at>
1293
1294 * window.c (delete_deletable_window): Re-add.
1295 (Fset_window_configuration): Rewrite to handle dead buffers and
1296 consequently deletable windows.
1297 (window_tree, Fwindow_tree): Remove. Supply functionality in
1298 window.el.
1299 (compare_window_configurations): Simplify code.
1300
b6e3633c
AS
13012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1302
1ab0dee5
AS
1303 * image.c (imagemagick_load_image): Fix type mismatch.
1304 (Fimagemagick_types): Likewise.
1305
b6e3633c
AS
1306 * window.h (replace_buffer_in_windows): Declare.
1307
9397e56f
MR
13082011-06-11 Martin Rudalics <rudalics@gmx.at>
1309
1310 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1311 Qclone_number. Remove external declaration of Qdelete_window.
1312 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1313 code.
1314 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1315 Qbuffer_list_update_hook if allowed.
1316 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1317 buffer list implementation.
1318 (other_buffer_safely): New function.
1319 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1320 calls to replace_buffer_in_windows and
1321 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1322 if allowed.
1323 (record_buffer): Inhibit quitting and rewrite using quittable
1324 functions. Run Qbuffer_list_update_hook if allowed.
1325 (Frecord_buffer, Funrecord_buffer): New functions.
1326 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1327 switch-to-buffer to window.el.
1328 (bury-buffer): Move to window.el.
1329 (Vbuffer_list_update_hook): New variable.
1330
1331 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1332 section.
1333
1334 * window.h (resize_frame_windows): Move up in code.
1335 (Fwindow_frame): Remove EXFUN.
1336 (replace_buffer_in_all_windows): Remove prototype.
1337 (replace_buffer_in_windows_safely): Add prototype.
1338
1339 * window.c: Declare Qdelete_window static again. Move down
1340 declaration of select_count.
1341 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1342 (Fother_window): Move to window.el.
1343 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1344 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1345 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1346 window.el.
1347 (replace_buffer_in_windows): Implement by calling
1348 Qreplace_buffer_in_windows.
1349 (replace_buffer_in_all_windows): Remove with some functionality
1350 moved into replace_buffer_in_windows_safely.
1351 (replace_buffer_in_windows_safely): New function.
1352 (select_window_norecord, select_frame_norecord): Move in front
1353 of run_window_configuration_change_hook. Remove now obsolete
1354 declarations.
1355 (Fset_window_buffer): Rewrite doc-string. Call
1356 Qrecord_window_buffer.
1357 (keys_of_window): Move binding for other-window to window.el.
1358
b50691aa
CY
13592011-06-11 Chong Yidong <cyd@stupidchicken.com>
1360
1361 * dispextern.h (struct image): Replace data member, whose int_val
1362 and ptr_val fields were not used by anything, with a single
1363 lisp_val object.
1364
1365 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1366 (gif_clear_image, gif_load, imagemagick_load_image)
1367 (gs_clear_image, gs_load): Callers changed.
1368
3f754b86
PE
13692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1370
cca69397
PE
1371 * buffer.h: Include <time.h>, for time_t.
1372 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1373
109e28d0
PE
1374 Fix minor problems found by static checking.
1375
60737f02
PE
1376 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1377
4b66faf3
PE
1378 Make identifiers static if they are not used in other modules.
1379 * data.c (Qcompiled_function, Qframe, Qvector):
1380 * image.c (QimageMagick, Qsvg):
1381 * minibuf.c (Qmetadata):
1382 * window.c (resize_window_check, resize_root_window): Now static.
1383 * window.h (resize_window_check, resize_root_window): Remove decls.
1384
109e28d0
PE
1385 * window.c (window_deletion_count, delete_deletable_window):
1386 Remove; unused.
46a4ce9e
PE
1387 (window_body_lines): Now static.
1388 (Fdelete_other_windows_internal): Mark vars as initialized.
1389 Make sure 'resize_failed' is initialized.
1390 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1391 (resize_window_apply): Remove unused local.
1392 * window.h (delete_deletable_window): Remove decl.
1393
109e28d0 1394 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1395 (imagemagick_load_image): Fix pointer signedness problem by changing
1396 last arg from unsigned char * to char *. All uses changed.
1397 Also, fix a local for similar reasons.
1398 Remove unused locals. Remove locals to avoid shadowing.
1399 (fn_rsvg_handle_free): Remove; unused.
1400 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1401 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1402
3f754b86
PE
1403 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1404
2547adb1
CY
14052011-06-10 Chong Yidong <cyd@stupidchicken.com>
1406
1407 * image.c (gif_load): Fix omitted cast error introduced by
1408 2011-06-06 change.
1409
2c8e37d4
MR
14102011-06-10 Martin Rudalics <rudalics@gmx.at>
1411
1412 * window.h (resize_proportionally, orig_total_lines)
1413 (orig_top_line): Remove from window structure.
1414 (set_window_height, set_window_width, change_window_heights)
1415 (Fdelete_window): Remove prototypes.
1416 (resize_frame_windows): Remove duplicate declaration.
1417
440a42e3
EZ
14182011-06-10 Eli Zaretskii <eliz@gnu.org>
1419
1420 * window.h (resize_frame_windows, resize_window_check)
1421 (delete_deletable_window, resize_root_window)
1422 (resize_frame_windows): Declare prototypes.
1423
1424 * window.c (resize_window_apply): Make definition be "static" to
1425 match the prototype.
1426
562dd5e9
MR
14272011-06-10 Martin Rudalics <rudalics@gmx.at>
1428
1429 * window.c: Remove declarations of Qwindow_size_fixed,
1430 window_min_size_1, window_min_size_2, window_min_size,
1431 size_window, window_fixed_size_p, enlarge_window, delete_window.
1432 Remove static from declaration of Qdelete_window, it's
1433 temporarily needed by Fbury_buffer.
1434 (replace_window): Don't assign orig_top_line and
1435 orig_total_lines.
1436 (Fdelete_window, delete_window): Remove. Window deletion is
1437 handled by window.el.
1438 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1439 Fdelete_window calls with calls to Qdelete_window.
1440 (Fdelete_other_windows): Remove. Deleting other windows is
1441 handled by window.el.
1442 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1443 handled in window.el.
1444 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1445 Window minimum sizes are handled in window.el.
1446 (shrink_windows, size_window, set_window_height)
1447 (set_window_width, change_window_heights, window_height)
1448 (window_width, CURBEG, CURSIZE, enlarge_window)
1449 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1450 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1451 handled in window.el.
1452 (make_dummy_parent): Rename to make_parent_window and give it a
1453 second argument horflag.
1454 (make_window): Don't set resize_proportionally any more.
1455 (Fsplit_window): Remove. Windows are split in window.el.
1456 (save_restore_action, save_restore_orig_size)
1457 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1458 Resize mini windows in window.el.
1459 (grow_mini_window, shrink_mini_window): Implement by calling
1460 Qresize_root_window_vertically, resize_window_check and
1461 resize_window_apply.
1462 (saved_window, Fset_window_configuration, save_window_save): Do
1463 not handle orig_top_line, orig_total_lines, and
1464 resize_proportionally.
1465 (window_min_height, window_min_width): Move to window.el.
1466 (keys_of_window): Move bindings for delete-other-windows,
1467 split-window, delete-window and enlarge-window to window.el.
1468
1469 * buffer.c: Temporarily extern Qdelete_window.
1470 (Fbury_buffer): Temporarily call Qdelete_window instead of
1471 Fdelete_window (Fbury_buffer will move to window.el soon).
1472
1473 * frame.c (set_menu_bar_lines_1): Remove code handling
1474 orig_top_line and orig_total_lines.
1475
1476 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1477 set_window_height but set heights directly.
1478 (change_frame_size_1): Use resize_frame_windows.
1479
1480 * xdisp.c (init_xdisp): Don't use set_window_height but set
1481 heights directly.
1482
1483 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1484 resize_frame_windows instead of change_window_heights and run
1485 run_window_configuration_change_hook.
1486
1487 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1488 instead of change_window_heights and run
1489 run_window_configuration_change_hook.
1490
1a13852e
MR
14912011-06-09 Martin Rudalics <rudalics@gmx.at>
1492
1493 * window.c (replace_window): Rename second argument REPLACEMENT to
1494 NEW. New third argument SETFLAG. Rewrite.
1495 (delete_window, make_dummy_parent): Call replace_window with
1496 third argument 1.
1497 (window_list_1): Move down in code.
1498 (run_window_configuration_change_hook): Move set_buffer part
1499 before select_frame_norecord part in order to unwind correctly.
1500 Rename count1 to count.
1501 (recombine_windows, delete_deletable_window, resize_root_window)
1502 (Fdelete_other_windows_internal)
1503 (Frun_window_configuration_change_hook, make_parent_window)
1504 (resize_window_check, resize_window_apply, Fresize_window_apply)
1505 (resize_frame_windows, Fsplit_window_internal)
1506 (Fdelete_window_internal, Fresize_mini_window_internal): New
1507 functions.
1508 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1509
f3d1777e
MR
15102011-06-08 Martin Rudalics <rudalics@gmx.at>
1511
496e208e
MR
1512 * window.h (window): Add some new members to window structure -
1513 normal_lines, normal_cols, new_total, new_normal, clone_number,
1514 splits, nest, prev_buffers, next_buffers.
1515 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1516 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1517
f3d1777e
MR
1518 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1519 Remove.
496e208e
MR
1520 (make_dummy_parent): Set new members of windows structure.
1521 (make_window): Move down in code. Handle new members of window
1522 structure.
1523 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1524 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1525 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1526 (Fset_window_prev_buffers, Fwindow_next_buffers)
1527 (Fset_window_next_buffers, Fset_window_clone_number): New
1528 functions.
1529 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1530 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1531 Doc-string fixes.
1532 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1533 Argument WINDOW can be now internal window too.
1534 (Fwindow_use_time): Move up in code.
1535 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1536 Rewrite doc-string.
1537 (Fset_window_configuration, saved_window)
1538 (Fcurrent_window_configuration, save_window_save): Handle new
1539 members of window structure.
b9e809c2
MR
1540 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1541 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1542 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1543 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1544 Qget_mru_window, Qresize_root_window,
1545 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1546 Qauto_buffer_name; staticpro them.
f3d1777e 1547
abde8f8c
MR
15482011-06-07 Martin Rudalics <rudalics@gmx.at>
1549
1550 * window.c (Fwindow_total_size, Fwindow_left_column)
1551 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1552 (Fwindow_list_1): New functions.
1553 (window_box_text_cols): Replace with window_body_cols.
1554 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1555 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1556 (delete_window, Fset_window_configuration): Call
1557 delete_all_subwindows with window as argument.
1558 (delete_all_subwindows): Take a window as argument and not a
1559 structure. Rewrite.
190b47e6
MR
1560 (window_loop): Remove handling of GET_LRU_WINDOW and
1561 GET_LARGEST_WINDOW.
1562 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1563
1564 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1565 window_box_text_cols. delete_all_subwindows now takes a
1566 Lisp_Object as argument.
abde8f8c
MR
1567
1568 * indent.c (compute_motion, Fcompute_motion): Use
1569 window_body_cols instead of window_box_text_cols.
1570
fa8a67e6
MR
1571 * frame.c (delete_frame): Call delete_all_subwindows with root
1572 window as argument.
1573
a54e3482
DC
15742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1575
1576 * fns.c (Fputhash): Document return value.
1577
60002bf5
CY
15782011-06-06 Chong Yidong <cyd@stupidchicken.com>
1579
1580 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1581
0c671da6 15822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1583
b862a52a 1584 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1585
be44ca6c
PE
1586 Check for overflow when converting integer to cons and back.
1587 * charset.c (Fdefine_charset_internal, Fdecode_char):
1588 Use cons_to_unsigned to catch overflow.
1589 (Fencode_char): Use INTEGER_TO_CONS.
1590 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1591 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1592 * data.c (long_to_cons, cons_to_long): Remove.
1593 (cons_to_unsigned, cons_to_signed): New functions.
1594 These signal an error for invalid or out-of-range values.
1595 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1596 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1597 * font.c (Ffont_variation_glyphs):
1598 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1599 * lisp.h: Include <intprops.h>.
1600 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1601 (cons_to_signed, cons_to_unsigned): New decls.
1602 (long_to_cons, cons_to_long): Remove decls.
1603 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1604 (Fprimitive_undo): Use CONS_TO_INTEGER.
1605 * xfns.c (Fx_window_property): Likewise.
1606 * xselect.c: Include <limits.h>.
1607 (x_own_selection, selection_data_to_lisp_data):
1608 Use INTEGER_TO_CONS.
1609 (x_handle_selection_request, x_handle_selection_clear)
1610 (x_get_foreign_selection, Fx_disown_selection_internal)
1611 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1612 (lisp_data_to_selection_data): Use cons_to_unsigned.
1613 (x_fill_property_data): Use cons_to_signed.
1614 Report values out of range.
1615
d1f3d2af
PE
1616 Check for buffer and string overflow more precisely.
1617 * buffer.h (BUF_BYTES_MAX): New macro.
1618 * lisp.h (STRING_BYTES_MAX): New macro.
1619 * alloc.c (Fmake_string):
1620 * character.c (string_escape_byte8):
1621 * coding.c (coding_alloc_by_realloc):
1622 * doprnt.c (doprnt):
1623 * editfns.c (Fformat):
1624 * eval.c (verror):
1625 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1626 since they may not be the same number.
1627 * editfns.c (Finsert_char):
1628 * fileio.c (Finsert_file_contents):
1629 Likewise for BUF_BYTES_MAX.
1630
dd52fcea
PE
1631 * image.c: Use ptrdiff_t, not int, for sizes.
1632 (slurp_file): Switch from int to ptrdiff_t.
1633 All uses changed.
1634 (slurp_file): Check that file size fits in both size_t (for
1635 malloc) and ptrdiff_t (for sanity and safety).
1636
7f9bbdbb
PE
1637 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1638 if b->modtime has its maximal value.
1639
dfe18f82
PE
1640 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1641
84acfcf0
PE
1642 Don't assume time_t can fit into int.
1643 * buffer.h (struct buffer.modtime): Now time_t, not int.
1644 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1645 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1646
ccd9a01a
PE
1647 Minor fixes for signed vs unsigned integers.
1648 * character.h (MAYBE_UNIFY_CHAR):
1649 * charset.c (maybe_unify_char):
1650 * keyboard.c (read_char, reorder_modifiers):
1651 XINT -> XFASTINT, since the integer must be nonnegative.
1652 * ftfont.c (ftfont_spec_pattern):
1653 * keymap.c (access_keymap, silly_event_symbol_error):
1654 XUINT -> XFASTINT, since the integer must be nonnegative.
1655 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1656 since it makes no difference and we prefer signed.
1657 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1658 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1659 nonnegative.
1660
d6d100dd
SM
16612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1662
1663 * window.h (Fwindow_frame): Declare.
1664
2b6148e4
PE
16652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1668 (SPARE_MEMORY): Always define.
1669 (LARGE_REQUEST): Remove.
1670 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1671
f230ecc9
MR
16722011-06-06 Martin Rudalics <rudalics@gmx.at>
1673
727e958e
MR
1674 * lisp.h: Move EXFUNS for Fframe_root_window,
1675 Fframe_first_window and Fset_frame_selected_window to window.h.
1676
1677 * window.h: Move EXFUNS for Fframe_root_window,
1678 Fframe_first_window and Fset_frame_selected_window here from
1679 lisp.h.
1680
1681 * frame.c (Fwindow_frame, Fframe_first_window)
1682 (Fframe_root_window, Fframe_selected_window)
1683 (Fset_frame_selected_window): Move to window.c.
1684 (Factive_minibuffer_window): Move to minibuf.c.
1685 (Fother_visible_frames_p): New function.
1686
1687 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1688
f230ecc9
MR
1689 * window.c (decode_window, decode_any_window): Move up in code.
1690 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1691 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1692 (Fwindow_buffer): Move up and rewrite doc-string.
1693 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1694 (Fwindow_prev): New functions.
727e958e
MR
1695 (Fwindow_frame): Move here from frame.c. Accept any window as
1696 argument.
1697 (Fframe_root_window, Fframe_first_window)
1698 (Fframe_selected_window): Move here from frame.c. Accept frame
1699 or arbitrary window as argument. Update doc-strings.
1700 (Fminibuffer_window): Move up in code.
1701 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1702 (Fset_frame_selected_window): Move here from frame.c.
1703 Marginal rewrite.
727e958e
MR
1704 (Fselected_window, select_window, Fselect_window): Move up in
1705 code. Minor doc-string fixes.
f230ecc9 1706
4d09bcf6
PE
17072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1710 Do not assume that spare memory exists; that assumption is valid
1711 only if SYSTEM_MALLOC.
1712 (LARGE_REQUEST): New macro, so that the issue of large requests
1713 is separated from the issue of spare memory.
1714
810928a2
AS
17152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1716
172418ad
AS
1717 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1718 format. (Bug#8806)
1719
43f862f7
AS
1720 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1721
810928a2
AS
1722 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1723 before statements.
1724
a059fe24
JD
17252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1726
1727 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1728
1729 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1730
1731 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1732 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1733
989bf368
JB
17342011-06-05 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1737
4b80f674
CY
17382011-06-04 Chong Yidong <cyd@stupidchicken.com>
1739
1740 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1741 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1742 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1743 New error handlers.
4b80f674
CY
1744 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1745 Obey Vx_select_enable_clipboard_manager. Catch errors in
1746 x_clipboard_manager_save (Bug#8779).
1747 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1748 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1749
99a33b77 17502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1751
1752 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1753
99a33b77 17542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1755
1756 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1757 in the current matrix if keep_current_p is non-zero.
1758
8264569d
EZ
17592011-06-04 Eli Zaretskii <eliz@gnu.org>
1760
1761 * bidi.c (bidi_level_of_next_char): Fix last change.
1762
57f97249
EZ
17632011-06-03 Eli Zaretskii <eliz@gnu.org>
1764
fec2107c 1765 Support bidi reordering of text covered by display properties.
57f97249 1766
fec2107c
EZ
1767 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1768 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1769 (bidi_cache_search, bidi_cache_iterator_state)
1770 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1771 (bidi_level_of_next_char, bidi_move_to_visually_next):
1772 Support character positions inside a run of characters covered by a
fec2107c
EZ
1773 display string.
1774 (bidi_paragraph_init, bidi_resolve_explicit_1)
1775 (bidi_level_of_next_char): Call bidi_fetch_char and
1776 bidi_fetch_char_advance instead of FETCH_CHAR and
1777 FETCH_CHAR_ADVANCE.
1778 (bidi_init_it): Initialize new members.
1779 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1780 definitions.
1781 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1782 instead of using explicit *_CHAR codes.
d6d100dd
SM
1783 (bidi_resolve_explicit, bidi_resolve_weak):
1784 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1785 bidirectional text is supported only in multibyte buffers.
1786 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1787 it to initialize the frame_window_p member of struct bidi_it.
1788 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1789 (bidi_resolve_explicit, bidi_resolve_weak)
1790 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1791 bidi_it->nchars is non-positive.
1792 (bidi_level_of_next_char): Don't try to lookup the cache for the
1793 next/previous character if nothing is cached there yet, or if we
1794 were just reseat()'ed to a new position.
c40e2fb2 1795
0e14fe90
EZ
1796 * xdisp.c (set_cursor_from_row): Set start and stop points
1797 according to the row's direction when priming the loop that looks
1798 for the glyph on which to display cursor.
1799 (single_display_spec_intangible_p): Function deleted.
1800 (display_prop_intangible_p): Reimplement to call
1801 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1802 Accept 3 additional arguments needed by handle_display_spec.
1803 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1804 values: lists, `(when COND...)' forms, etc.
1805 (single_display_spec_string_p): Support property values that are
1806 lists with the argument STRING its top-level element.
1807 (display_prop_string_p): Fix the condition for processing a
1808 property that is a list to be consistent with handle_display_spec.
fec2107c 1809 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1810 last portion of handle_display_prop.
1811 (compute_display_string_pos): Accept additional argument
1812 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1813 value of a `display' property is a "replacing spec".
1814 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1815 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1816 the display property, but just return a value indicating whether
1817 the display property will replace the characters it covers.
1818 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1819 frame_window_p members of struct bidi_it.
d6d100dd
SM
1820 (compute_display_string_pos, compute_display_string_end):
1821 New functions.
fec2107c
EZ
1822 (push_it): Accept second argument POSITION, where pop_it should
1823 jump to continue iteration.
1824 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1825
fec2107c
EZ
1826 * keyboard.c (adjust_point_for_property): Adjust the call to
1827 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1828
1829 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1830 (bidi_init_it): Update prototypes.
1831 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1832 (compute_display_string_pos, compute_display_string_end):
1833 Declare prototypes.
fec2107c
EZ
1834 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1835 EMACS_INT.
fc6f18ce 1836
40087514 18372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1838
57f53182
PE
1839 Malloc failure behavior now depends on size of allocation.
1840 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1841 * lisp.h: Change signatures accordingly.
1842 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1843 All callers changed. (Bug#8762)
1844
1845 * gnutls.c: Use Emacs's memory allocators.
1846 Without this change, the gnutls library would invoke malloc etc.
1847 directly, which causes problems on non-SYNC_INPUT hosts, and which
1848 runs afoul of improving memory_full behavior. (Bug#8761)
1849 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1850 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1851 xfree instead of the default malloc, realloc, free.
1852 (Fgnutls_boot): No need to check for memory allocation failure,
1853 since xmalloc does that for us.
1854
ac32cd99 1855 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1856 * category.c (hash_get_category_set):
1857 * ccl.c (ccl_driver):
1858 * charset.c (Fdefine_charset_internal):
1859 * charset.h (struct charset.hash_index):
1860 * composite.c (get_composition_id, gstring_lookup_cache)
1861 (composition_gstring_put_cache):
1862 * composite.h (struct composition.hash_index):
1863 * dispextern.h (struct image.hash):
1864 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1865 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1866 (hashfn_equal, hashfn_user_defined, make_hash_table)
1867 (maybe_resize_hash_table, hash_lookup, hash_put)
1868 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1869 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1870 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1871 * image.c (make_image, search_image_cache, lookup_image)
1872 (xpm_put_color_table_h):
1873 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1874 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1875 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1876 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1877 * alloc.c (allocate_vectorlike):
1878 Check for overflow in vector size calculations.
1879 * ccl.c (ccl_driver):
1880 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1881 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1882 need to be updated by these changes.
40087514
PE
1883 * fns.c (make_hash_table, maybe_resize_hash_table):
1884 Check for integer overflow with large hash tables.
0de4bb68
PE
1885 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1886 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1887 (SXHASH_REDUCE): New macro.
1888 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1889 Use it instead of discarding useful hash info with large hash values.
1890 (sxhash_float): New function.
1891 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1892 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1893 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1894 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1895 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1896 Adjust signatures to match updated version of code.
1897 (consing_since_gc): Now EMACS_INT, since a single hash table can
1898 use more than INT_MAX bytes.
1899
698d32e2
DN
19002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1901
1902 Make it possible to build with GCC-4.6+ -O2 -flto.
1903
1904 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1905
fd6fa53f
SM
19062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1907
1908 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1909 Call minibuffer-inactive-mode.
1910
864db017
JB
19112011-05-31 Juanma Barranquero <lekktu@gmail.com>
1912
1913 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1914 Update dependencies.
1915
2ad0baf4
DN
19162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1917
1918 * data.c (init_data): Remove code for UTS, this system is not
1919 supported anymore.
1920
4fcc2638
DN
19212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1922
1923 Don't force ./temacs to start in terminal mode.
1924
1925 * frame.c (make_initial_frame): Initialize faces in all cases, not
1926 only when CANNOT_DUMP is defined.
1927 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1928
c56e0fd5
DN
19292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1930
1931 * dispnew.c (add_window_display_history): Use const for the string
1932 pointer. Remove declaration, not needed.
1933
333d54da 19342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1935
55d4c1b2 1936 Use 'inline', not 'INLINE'.
333d54da 1937 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1938 * alloc.c, fontset.c (INLINE): Remove.
1939 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1940 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1941 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1942 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1943 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1944
738db178
DN
19452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1946
1947 Make it possible to run ./temacs.
1948
1949 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1950 syms_of_callproc does the same thing. Remove test for
1951 "initialized", do it in the caller.
1952 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1953
620c53a6
SM
19542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1955
1956 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1957 (read_minibuf): Use get_minibuffer.
1958 (syms_of_minibuf): Use DEFSYM.
1959 (Qmetadata): New var.
1960 * data.c (Qbuffer): Don't make it static.
1961 (syms_of_data): Use DEFSYM.
1962
e003a292
PE
19632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1966 (CCL_CODE_MIN): New macro.
1967
ed008a6d
PE
19682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1969
3687c2ef
PE
1970 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1971
ed008a6d
PE
1972 * eval.c (Qdebug): Now static.
1973 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1974 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1975 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1976
d66c4c7c
CY
19772011-05-29 Chong Yidong <cyd@stupidchicken.com>
1978
1979 * image.c: Various fixes to ImageMagick code comments.
1980 (Fimagemagick_types): Doc fix.
1981
5fbc2025
PE
19822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1983
0196f88a
PE
1984 Minor fixes prompted by GCC 4.6.0 warnings.
1985
1986 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1987
5fbc2025
PE
1988 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1989 (x_clipboard_manager_save_all): Move extern decl to ...
1990 * xterm.h: ... here, so that it can be checked for consistency.
1991
1dd3c2d9
CY
19922011-05-29 Chong Yidong <cyd@stupidchicken.com>
1993
1994 * xselect.c (x_clipboard_manager_save_frame)
1995 (x_clipboard_manager_save_all): New functions.
1996 (Fx_clipboard_manager_save): Lisp function deleted.
1997
1998 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1999 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2000
2001 * xterm.h: Update prototype.
2002
5ba6571d
WX
20032011-05-28 William Xu <william.xwl@gmail.com>
2004
2005 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2006 exiting (Bug#8239).
2007
3eaff834
JM
20082011-05-28 Jim Meyering <meyering@redhat.com>
2009
e1900994 2010 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2011 * fns.c (to_uchar): Define.
2012 (crypto_hash_function): Use it to convert some newly-signed
2013 variables to unsigned, to avoid sign-extension bugs. For example,
2014 without this change, (md5 "truc") would evaluate to
2015 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2016 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2017 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2018
0f6990a7
PE
20192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2020
2021 Integer overflow fixes.
c8a9ca5a 2022
08686060
PE
2023 * dbusbind.c: Serial number integer overflow fixes.
2024 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2025 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2026 to hold a serial number that is too large for a fixnum.
2027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2028 Check for serial numbers out of range. Decode any serial number
59568bf0 2029 that was so large that it became a float. (Bug#8722)
08686060 2030
2d1fc3c7
PE
2031 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2032 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2033 Use XFASTINT rather than XUINT when numbers are nonnegative.
2034 (xd_append_arg, Fdbus_method_return_internal):
2035 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2036 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2037 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2038 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2039 (Bug#8722)
2d1fc3c7 2040
c8a9ca5a
PE
2041 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2042
519e1d69
PE
2043 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2044
30569699
PE
2045 ccl: add integer overflow checks
2046 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2047 (IN_INT_RANGE): New macros.
2048 (ccl_driver): Use them to check for integer overflow when
2049 decoding a CCL program. Many of the new checks are whether XINT (x)
2050 fits in int; it doesn't always, on 64-bit hosts. The new version
2051 doesn't catch all possible integer overflows, but it's an
847044ea 2052 improvement. (Bug#8719)
30569699 2053
c11285dc
PE
2054 * alloc.c (make_event_array): Use XINT, not XUINT.
2055 There's no need for unsigned here.
2056
fdccd48e
PE
2057 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2058 This follows up to the 2011-05-06 change that substituted uintptr_t
2059 for EMACS_INT. This case wasn't caught back then.
2060
37910ab2
PE
2061 Rework Fformat to avoid integer overflow issues.
2062 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2063 now (part of C89). Include <verify.h>.
2064 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2065 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2066 (Fformat): Avoid the prepass trying to compute sizes; it was only
2067 approximate and thus did not catch overflow reliably. Instead, walk
2068 through the format just once, formatting and computing sizes as we go,
2069 checking for integer overflow at every step, and allocating a larger
2070 buffer as needed. Keep track separately whether the format is
2071 multibyte. Keep only the most-recently calculated precision, rather
2072 than them all. Record whether each argument has been converted to
2073 string. Use EMACS_INT, not int, for byte and char and arg counts.
2074 Support field widths and precisions larger than INT_MAX. Avoid
2075 sprintf's undefined behavior with conversion specifications such as %#d
2076 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2077 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2078 formatting out-of-range floating point numbers with int
9173deec 2079 formats. (Bug#8668)
37910ab2 2080
2e6578fb
PE
2081 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2082
0ae6bdee
PE
2083 * data.c: Avoid integer truncation in expressions involving floats.
2084 * data.c: Include <intprops.h>.
2085 (arith_driver): When there's an integer overflow in an expression
2086 involving floating point, convert the integers to floating point
2087 so that the resulting value does not suffer from catastrophic
2088 integer truncation. For example, on a 64-bit host (* 4
2089 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2090 Do not rely on undefined behavior after integer overflow.
2091
de883a70
PE
2092 merge count_size_as_multibyte, parse_str_to_multibyte
2093 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2094 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2095 Check for integer overflow.
2096 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2097 since it's now a duplicate of the other. This is more of
2098 a character than a buffer op, so better that it's in character.c.
2099 * fns.c, print.c: Adjust to above changes.
2100
2ff916cb
PE
21012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2102
2103 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2104
f1b54466
PE
21052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2106
fb1ac845
PE
2107 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2108 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2109 (x_clipboard_manager_save): Now static.
2110 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2111
f1b54466
PE
2112 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2113 (crypto_hash_function): Now static.
2114 Fix pointer signedness problems. Avoid unnecessary initializations.
2115
a9f737ee
CY
21162011-05-27 Chong Yidong <cyd@stupidchicken.com>
2117
2118 * termhooks.h (Vselection_alist): Make it terminal-local.
2119
2120 * terminal.c (create_terminal): Initialize it.
2121
2122 * xselect.c: Support for clipboard managers.
2123 (Vselection_alist): Move to termhooks.h as terminal-local var.
2124 (LOCAL_SELECTION): New macro.
2125 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2126 (symbol_to_x_atom): Remove gratuitous arg.
2127 (x_handle_selection_request, lisp_data_to_selection_data)
2128 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2129 (x_own_selection, x_get_local_selection, x_convert_selection):
2130 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2131 (some_frame_on_display): Delete unused function.
2132 (Fx_own_selection_internal, Fx_get_selection_internal)
2133 (Fx_disown_selection_internal, Fx_selection_owner_p)
2134 (Fx_selection_exists_p): New optional frame arg.
2135 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2136 (x_handle_selection_clear): Don't treat other terminals with the
2137 same keyboard specially. Use the terminal-local Vselection_alist.
2138 (x_clear_frame_selections): Use Frun_hook_with_args.
2139
2140 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2141
2142 * xterm.h: Add support for those atoms.
2143
e067f0c1
CY
21442011-05-26 Chong Yidong <cyd@stupidchicken.com>
2145
2146 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2147 (converted_selections, conversion_fail_tag): New global variables.
2148 (x_selection_request_lisp_error): Free the above.
2149 (x_get_local_selection): Remove unnecessary code.
2150 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2151 of converted selections stored in converted_selections.
2152 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2153 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2154 (x_convert_selection): New function.
2155 (x_handle_selection_event): Simplify.
2156 (x_get_foreign_selection): Don't ignore incoming requests while
2157 waiting for an answer; this will fail when we implement
2158 SAVE_TARGETS, and seems unnecessary anyway.
2159 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2160 (Vx_sent_selection_functions): Doc fix.
2161
0f4aebc0
LL
21622011-05-26 Leo Liu <sdl.web@gmail.com>
2163
2164 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2165
e61124cd
YM
21662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2167
2168 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2169
2170 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2171 for fringe update if it has periodic bitmap.
2172 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2173 and fringe_bitmap_periodic_p.
2174
2175 * fringe.c (get_fringe_bitmap_data): New function.
2176 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2177 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2178 row. Mark glyph row for fringe update if periodicity changed.
2179
2180 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2181 for fringe update unless it has periodic bitmap.
2182
f16d9837
KH
21832011-05-25 Kenichi Handa <handa@m17n.org>
2184
2185 * xdisp.c (get_next_display_element): Set correct it->face_id for
2186 a static composition.
2187
e1b90ef6
LL
21882011-05-24 Leo Liu <sdl.web@gmail.com>
2189
2190 * deps.mk (fns.o):
2191 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2192
2193 * fns.c (crypto_hash_function, Fsha1): New function.
2194 (Fmd5): Use crypto_hash_function.
2195 (syms_of_fns): Add Ssha1.
2196
7400048f
PE
21972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * gnutls.c: Remove unused macros.
2200 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2201 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2202 Remove macros that are defined and never used.
2203 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2204
abb71cf4
CY
22052011-05-22 Chong Yidong <cyd@stupidchicken.com>
2206
2207 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2208 (Fx_get_selection_internal): Minor cleanup.
2209 (Fx_own_selection_internal): Rename arguments for consistency with
2210 select.el.
2211
6307db39
PE
22122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2215
f3d4e0a4
CY
22162011-05-22 Chong Yidong <cyd@stupidchicken.com>
2217
2218 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2219
4d8ade89
YM
22202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2221
2222 * dispnew.c (scrolling_window): Don't exclude the case that the
2223 last enabled row in the desired matrix touches the bottom boundary.
2224
32078c8d
GM
22252011-05-21 Glenn Morris <rgm@gnu.org>
2226
2227 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2228 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2229 and add some more files.
32078c8d 2230
7285dc67
EZ
22312011-05-20 Eli Zaretskii <eliz@gnu.org>
2232
2233 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2234 report_file_error introduced by the change from 2011-05-07.
2235
89d1bd22
PE
22362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 * systime.h (Time): Define only if emacs is defined.
2239 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2240 where the include path doesn't have X11/X.h by default. See
2241 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2242
e23640bb 22432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2244
2245 * composite.c (find_automatic_composition): Fix previous change.
2246
b9704ad9
GM
22472011-05-20 Glenn Morris <rgm@gnu.org>
2248
2249 * lisp.mk: New file, split from Makefile.in.
2250 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2251 (shortlisp): Remove.
2252 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2253
4a720484
GM
22542011-05-19 Glenn Morris <rgm@gnu.org>
2255
2256 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2257 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2258 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2259 (lisp): Set the order to that of loadup.el.
2260 (shortlisp): Make it a copy of $lisp.
2261 (SOME_MACHINE_LISP): Remove.
2262 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2263 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2264
a28d4396
KH
22652011-05-18 Kenichi Handa <handa@m17n.org>
2266
2267 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2268 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2269 (find_automatic_composition): Mostly rewrite for efficiency.
2270
a2b1fa8e
JB
22712011-05-18 Juanma Barranquero <lekktu@gmail.com>
2272
2273 * makefile.w32-in: Update dependencies.
2274
8e1f5610
CS
22752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2276
2277 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2278 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2279
7025ee00 22802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2281
cdfa6eab
PE
2282 Fix some integer overflow issues, such as string length overflow.
2283
06d6db33
PE
2284 * insdel.c (count_size_as_multibyte): Check for string overflow.
2285
2b4560a8
PE
2286 * character.c (lisp_string_width): Check for string overflow.
2287 Use EMACS_INT, not int, for string indexes and lengths; in
2288 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2289 the resulting string length overflows an EMACS_INT; instead,
2290 report a string overflow if no precision given. When checking for
2291 precision exhaustion, use a check that cannot possibly have
2292 integer overflow. (Bug#8675)
2293 * character.h (lisp_string_width): Adjust to new signature.
2294
cb93f9be
PE
2295 * alloc.c (string_overflow): New function.
2296 (Fmake_string): Use it. This doesn't change behavior, but saves
2297 a few bytes and will simplify future changes.
2298 * character.c (string_escape_byte8): Likewise.
2299 * lisp.h (string_overflow): New decl.
2300
1a1f3366
PE
2301 Fixups, following up to the user-interface timestamp change.
2302 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2303 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2304 * msdos.c (mouse_get_pos): Likewise.
2305 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2306 * w32gui.h (Time): Define by including "systime.h" rather than by
2307 declaring it ourselves. (Bug#8664)
2308
d4e3e4d3
PE
2309 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2310 * image.c (clear_image_cache): Likewise.
2311
f6a24d19
PE
2312 * term.c (term_mouse_position): Don't assume time_t wraparound.
2313
08dc5ae6
PE
2314 Be more systematic about user-interface timestamps.
2315 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2316 and sometimes 'EMACS_UINT', to represent these timestamps.
2317 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2318 This makes the code easier to follow, and makes it easier to catch
2319 integer overflow bugs such as Bug#8664.
2320 * frame.c (Fmouse_position, Fmouse_pixel_position):
2321 Use Time, not unsigned long, for user-interface timestamps.
2322 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2323 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2324 * keyboard.h (last_event_timestamp): Likewise.
2325 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2326 * menu.h (xmenu_show): Likewise.
2327 * term.c (term_mouse_position): Likewise.
2328 * termhooks.h (struct input_event.timestamp): Likewise.
2329 (struct terminal.mouse_position_hook): Likewise.
2330 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2331 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2332 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2333 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2334 what it was before.
2335 * menu.h, termhooks.h: Include "systime.h", for Time.
2336
8e55734a
PE
2337 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2338 Don't assume that the difference between two unsigned long values
2339 can fit into an integer. At this point, we know button_down_time
2340 <= event->timestamp, so the difference must be nonnegative, so
2341 there's no need to cast the result if double-click-time is
2342 nonnegative, as it should be; check that it's nonnegative, just in
2343 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2344 apart (about 25 days). (Bug#8664)
8e55734a 2345
841f1b75 2346 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2347 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2348
3e26f69c
PE
2349 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2350 that always fit in int. Use a sentinel instead of a counter, to
2351 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2352 * frame.h (struct frame): Use int for menu_bar_items_used
2353 instead of EMACS_INT, since it always fits in int.
3e26f69c 2354
5cc152c0
PE
2355 * menu.c (grow_menu_items): Check for int overflow.
2356
d89eb65e
PE
2357 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2358
5235bd3e
PE
2359 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2360 Before, the code was not consistent. These values cannot exceed
2361 2**31 - 1 so there's no need to make them unsigned.
2362 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2363 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2364 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2365 as modifiers.
2366 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2367
bc827e23
PE
2368 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2369 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2370 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2371 presumably because the widths might not match.
2372
78eb494e
PE
2373 * window.c (size_window): Avoid needless test at loop start.
2374
04f2d78b
CB
23752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2376
2377 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2378
d2fc7e3d 23792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2380
2381 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2382
d2fc7e3d 23832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2384
2385 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2386 `width' to `bar_area_x' and `bar_area_width', respectively.
2387 (x_scroll_run): Take account of fringe background extension.
2388
04f2d78b
CB
2389 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2390 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2391 `bar_area_width', respectively.
2392 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2393 background extension.
2394
79b70037
GM
23952011-05-10 Jim Meyering <meyering@redhat.com>
2396
2397 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2398
2f142cc5
JB
23992011-05-10 Juanma Barranquero <lekktu@gmail.com>
2400
2401 * image.c (Finit_image_library): Return t for built-in image types,
2402 like pbm and xbm. (Bug#8640)
2403
57679c86
AS
24042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2405
2406 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2407
888c9e86
EZ
24082011-05-07 Eli Zaretskii <eliz@gnu.org>
2409
b0512a1d
EZ
2410 * w32console.c (Fset_screen_color): Doc fix.
2411 (Fget_screen_color): New function.
2412 (syms_of_ntterm): Defsubr it.
2413
7285dc67
EZ
2414 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2415 unlink the temporary file if Fcall_process didn't create it in the
2416 first place.
2417 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2418 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2419 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2420 cue to call_process_cleanup not to close that handle.
2421
4d3fcc8e
BK
24222011-05-07 Ben Key <bkey76@gmail.com>
2423
2424 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2425 one of two shell specific rules, either bootstrap-temacs-CMD or
2426 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2427 to the previous implementation of the bootstrap-temacs rule.
2428 The bootstrap-temacs-CMD rule is similar to the previous
2429 implementation of the bootstrap-temacs rule except that it
2430 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2431 variable.
2432
2433 These changes, along with some changes to nt/configure.bat,
2434 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2435 earlier fix to add support for --cflags and --ldflags options
2436 that include quotes so that it works whether make uses cmd or
2437 sh as the shell.
2438
b4289b64
MA
24392011-05-06 Michael Albinus <michael.albinus@gmx.de>
2440
2441 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2442 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2443 is a constant.
2444 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2445 a string. Handle both cases.
2446 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2447 (Fdbus_register_method): Use Qinvalid_function.
2448
af4c0e28
JB
24492011-05-06 Juanma Barranquero <lekktu@gmail.com>
2450
2451 * makefile.w32-in: Update dependencies.
2452 (LISP_H): Add inttypes.h and stdin.h.
2453 (PROCESS_H): Add unistd.h.
2454
c51453d9
EZ
24552011-05-06 Eli Zaretskii <eliz@gnu.org>
2456
2457 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2458 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2459
8ff0ac3c 24602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2461
4c4b566b
PE
2462 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2463
aab2b9b5
PE
2464 * term.c (vfatal): Remove stray call to va_end.
2465 It's not needed and the C Standard doesn't allow it here anyway.
2466
c378da0b
PE
2467 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2468 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2469
288b08c7
PE
2470 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2471 bytes.
2472
e3601888
PE
2473 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2474
db6c0e74
PE
2475 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2476
dd5963ea
PE
2477 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2478
88c9450f
PE
2479 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2480
2f9442b8
PE
2481 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2482
c032b5f8
PE
2483 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2484 * charset.c (Fdefine_charset_internal): Don't initialize
2485 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2486 32-bit int (Bug#8600).
a108c10b
PE
2487
2488 * lread.c (read_integer): Be more consistent with string-to-number.
2489 Use string_to_number to do the actual conversion; this avoids
2490 rounding errors and fixes some other screwups. Without this fix,
2491 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2492 (digit_to_number): Move earlier, for benefit of read_integer.
2493 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2494 not a digit in any supported base. (Bug#8602)
a108c10b 2495
ad5f9eea
PE
2496 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2497
aec1708a
PE
2498 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2499 to match comment at start of function. This also removes a
2500 GCC warning about overflow in a 32+64-bit port.
2501
47be4ab5
PE
2502 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2503
371cac43
PE
2504 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2505 Reported by Stefan Monnier in
2506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2507 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2508 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2509
d01a7826
PE
2510 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2511 (EMACS_UINTPTR): Likewise, with uintptr_t.
2512
7fd47d5c
PE
2513 * lisp.h: Prefer 64-bit EMACS_INT if available.
2514 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2515 on 32-bit hosts that have 64-bit int, so that they can access
2516 large files.
122b0c86
PE
2517 However, temporarily disable this change unless the temporary
2518 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2519
8727937b
PE
2520 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2521
8ac068ac
PE
2522 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2523 This removes an assumption that EMACS_INT and long are the same
2524 width as pointers. The assumption is true for Emacs porting targets
2525 now, but we want to make other targets possible.
2526 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2527 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2528 In the rest of the code, change types of integers that hold casted
2529 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2530 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2531 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2532 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2533 No need to cast type when ORing.
2534 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2535 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2536 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2537 assume EMACS_INT is the same width as char *.
2538 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2539 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2540 Remove no-longer-needed casts.
2541 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2542 (xg_tool_bar_help_callback, xg_make_tool_item):
2543 Use EMACS_INTPTR to hold an integer
2544 that will be cast to void *; this can avoid a GCC warning
2545 if EMACS_INT is not the same width as void *.
2546 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2547 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2548 (current_message_1, set_message_1):
2549 Use a local to convert to proper width without a cast.
2550 * xmenu.c (dialog_selection_callback): Likewise.
2551
ede49d71
PE
2552 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2553 Also, don't assume VALBITS / RAND_BITS is less than 5,
2554 and don't rely on undefined behavior when shifting a 1 left into
2555 the sign bit.
2556 * lisp.h (get_random): Change signature to match.
2557
2f30ecd0
PE
2558 * lread.c (hash_string): Use size_t, not int, for hash computation.
2559 Normally we prefer signed values; but hashing is special, because
2560 it's better to use unsigned division on hash table sizes so that
2561 the remainder is nonnegative. Also, size_t is the natural width
2562 for hashing into memory. The previous code used 'int', which doesn't
2563 retain enough info to hash well into very large tables.
2564 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2565
2a866e7b
PE
2566 * dbusbind.c: Don't possibly lose pointer info when converting.
2567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2568 Use XPNTR rather than XHASH, so that the high-order bits of
2569 the pointer aren't lost when converting through void *.
2570
51639eac
PE
2571 * eval.c (Fautoload): Don't double-shift a pointer.
2572
92394119
PE
2573 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2574
dbdb9a7c
JB
25752011-05-06 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * gnutls.c (DEF_GNUTLS_FN):
2578 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2579
db7a0b4f
AS
25802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2581
2582 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2583 marker. (Bug#8610)
2584
f7ff1b0f 25852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2586
2587 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2588 New version that can reserve upto 2GB of heap space.
2589
f7ff1b0f 25902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2591
2592 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2593
639c109b
TZ
25942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2595
2596 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2597 `gnutls_certificate_set_x509_key_file'.
2598
d2127135
JB
25992011-05-05 Juanma Barranquero <lekktu@gmail.com>
2600
2601 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2602 Update dependencies.
2603
e968f4f3
JB
26042011-05-04 Juanma Barranquero <lekktu@gmail.com>
2605
2606 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2608 Remove unused parameter `fildes'.
2609 * process.c (read_process_output, send_process): Don't pass it.
2610
84d358f0
JB
26112011-05-04 Juanma Barranquero <lekktu@gmail.com>
2612
2613 Fix previous change: the library cache is defined in w32.c.
2614 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2615 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2616
0898ca10
JB
26172011-05-04 Juanma Barranquero <lekktu@gmail.com>
2618
2619 Implement dynamic loading of GnuTLS on Windows.
2620
2621 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2622 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2623 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2624 Declare.
2625
2626 * gnutls.c (Qgnutls_dll): Define.
2627 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2628 (gnutls_*): Declare function pointers.
2629 (init_gnutls_functions): New function to initialize function pointers.
2630 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2631 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2633 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2634 (emacs_gnutls_write, emacs_gnutls_read)
2635 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2636 (Fgnutls_available_p): New function.
2637 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2638 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2639 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2640
2641 * image.c: Include w32.h.
2642 (Vimage_type_cache): Delete.
2643 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2644 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2645 (w32_delayed_load): Move to w32.c.
2646
2647 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2648
2649 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2650 (w32_delayed_load): Move from image.c. When loading a library, record
2651 its filename in the :loaded-from property of the library id.
2652 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2653 Initialize and staticpro them.
2654 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2655
2656 * process.c: Include lisp.h before w32.h, not after.
2657 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2658 instead of gnutls_record_check_pending.
2659
2660 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2661
ff4de4aa
TZ
26622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2663
2664 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2665 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2666 as passed in.
2667
abe95abb
JD
26682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2669
2670 * xterm.c (x_set_frame_alpha): Do not set property on anything
2671 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2672
e16e55d4
JB
26732011-05-02 Juanma Barranquero <lekktu@gmail.com>
2674
2675 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2676
bafcf6a5
JB
26772011-05-02 Juanma Barranquero <lekktu@gmail.com>
2678
2679 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2680 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2681 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2682 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2683 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2684 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2685 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2686 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2687 (Qgnutls_bootprop_callbacks_verify): Make static.
2688
e7a6747f
AS
26892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2690
19ed11ba
AS
2691 * callproc.c: Indentation fixup.
2692
e7a6747f 2693 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2694 (wait_for_termination, interruptible_wait_for_termination):
2695 Move after wait_for_termination_1.
e7a6747f 2696
1ef14cb4
LMI
26972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2698
2699 * sysdep.c (interruptible_wait_for_termination): New function
2700 which is like wait_for_termination, but allows keyboard
2701 interruptions.
2702
2703 * callproc.c (Fcall_process): Add (:file "file") as an option for
2704 the STDOUT buffer.
2705 (Fcall_process_region): Ditto.
2706
330d880c
EZ
27072011-04-30 Eli Zaretskii <eliz@gnu.org>
2708
8db90b73
EZ
2709 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2710 rather than `XVECTOR (FOO)->size'.
2711
330d880c
EZ
2712 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2713 inttypes.h, as a gnulib replacement is used if it not available in
2714 system headers.
2715
15cbd324
EZ
27162011-04-21 Eli Zaretskii <eliz@gnu.org>
2717
2718 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2719 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2720 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2721
2722 * coding.c (coding_alloc_by_realloc): Error out if destination
2723 will grow beyond MOST_POSITIVE_FIXNUM.
2724 (decode_coding_emacs_mule): Abort if there isn't enough place in
2725 charbuf for the composition carryover bytes. Reserve an extra
2726 space for up to 2 characters produced in a loop.
2727 (decode_coding_iso_2022): Abort if there isn't enough place in
2728 charbuf for the composition carryover bytes.
2729
27302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2731
ae940cca
EZ
2732 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2733 aborting when %lld or %lll format is passed.
2734 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2735 %llo or %llx format is passed. (Bug#8545)
2736
03ab8921
EZ
2737 * window.c (window_scroll_line_based): Use a marker instead of
2738 simple variables to record original value of point. (Bug#7952)
2739
afda1437
EZ
2740 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2741 produced by %s or %c overflows available buffer space. (Bug#8545)
2742
f76dee0c
PE
27432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2744
2745 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2746 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2747
fdc5744d
JB
27482011-04-28 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2751
638f053a
JB
27522011-04-28 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * keyboard.c (Qdelayed_warnings_hook): Define.
2755 (command_loop_1): Run `delayed-warnings-hook'
2756 if Vdelayed_warnings_list is non-nil.
2757 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2758 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2759
d178f871
EZ
27602011-04-28 Eli Zaretskii <eliz@gnu.org>
2761
2762 * doprnt.c (doprnt): Don't return value smaller than the buffer
2763 size if the message was truncated. (Bug#8545).
2764
b124fd93
JB
27652011-04-28 Juanma Barranquero <lekktu@gmail.com>
2766
2767 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2768 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2769
e810457d
PE
27702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2773
ea51cceb
JB
27742011-04-27 Juanma Barranquero <lekktu@gmail.com>
2775
2776 * makefile.w32-in: Update dependencies.
2777
94dcfacf
EZ
27782011-04-27 Eli Zaretskii <eliz@gnu.org>
2779
2780 Improve `doprnt' and its usage. (Bug#8545)
2781 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2782 `format_end'. Remove support for %l as a conversion specifier.
2783 Don't use xrealloc. Improve diagnostics when the %l size modifier
2784 is used. Update the commentary.
2785
2786 * eval.c (verror): Simplify calculation of size_t.
2787
2788 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2789 messages.
2790
f61f41d7
PE
27912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2792
2793 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2794 change.
2795
96fb4434
PE
27962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2799 This makes this file independent of the recent pseudovector change.
2800
671875da 28012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2802
69e9b5a3
PE
2803 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2804
b5f869a7 2805 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2806 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2807 Remove unused local.
c8926152 2808 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2809
841a1577 2810 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2811 GCC 4.6.0 optimizes based on type-based alias analysis.
2812 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2813 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2814 != &v->size, and therefore "v->size = 1; b->size = 2; return
2815 v->size;" must therefore return 1. This assumption is incorrect
2816 for Emacs, since it type-puns struct Lisp_Vector * with many other
2817 types. To fix this problem, this patch adds a new type struct
f904488f 2818 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2819 and pseudovectors, and helps optimizing compilers not get fooled
2820 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2821 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2822 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2823 the size member.
eab3844f
PE
2824 (XSETPVECTYPE): Rewrite in terms of new macro.
2825 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2826 This is a bit clearer, and further avoids the possibility of
2827 undesirable aliasing.
2828 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2829 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2830 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2831 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2832 (ASIZE): Now uses header.size rather than size.
2833 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2834 to avoid the hassle of writing XVECTOR (foo)->header.size.
2835 (struct vectorlike_header): New type.
eab3844f
PE
2836 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2837 object, to help avoid aliasing.
2838 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2839 (SUBRP): Likewise, since Lisp_Subr is a special case.
2840 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2841 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2842 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2843 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2844 changed to be "header.size" and "header.next".
2845 * buffer.h (struct buffer): Likewise.
2846 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2847 * frame.h (struct frame): Likewise.
2848 * process.h (struct Lisp_Process): Likewise.
2849 * termhooks.h (struct terminal): Likewise.
2850 * window.c (struct save_window_data, struct saved_window): Likewise.
2851 * window.h (struct window): Likewise.
2852 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2853 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2854 * buffer.c (init_buffer_once): Likewise.
2855 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2856 special case.
2857 * process.c (Fformat_network_address): Use local var for size,
2858 for brevity.
2859
0df1eac5
PE
2860 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2861
847ab9d1 2862 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2863 * data.c (atof): Remove decl; no longer used or needed.
2864 (digit_to_number): Move to lread.c.
2865 (Fstring_to_number): Use new string_to_number function, to be
2866 consistent with how the Lisp reader treats infinities and NaNs.
2867 Do not assume that floating-point numbers represent EMACS_INT
2868 without losing information; this is not true on most 64-bit hosts.
2869 Avoid double-rounding errors, by insisting on integers when
2870 parsing non-base-10 numbers, as the documentation specifies.
2871 * lisp.h (string_to_number): New decl, replacing ...
2872 (isfloat_string): Remove.
bc0a5c13 2873 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2874 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2875 appears to have been a coding error. Similarly, do not accept
2876 strings like +-1e0 as floating point numbers. Do not report
2877 overflow for integer overflows unless the base is not 10 which
2878 means we have no simple and reliable way to continue.
2879 Break out the floating-point parsing into a new
2880 function string_to_number, so that Fstring_to_number parses
2881 floating point numbers consistently with the Lisp reader.
04f2d78b 2882 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2883 (E_CHAR, EXP_INT): Remove, replacing with ...
2884 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2885 (string_to_number): New function, replacing isfloat_string.
2886 This function checks for valid syntax and produces the resulting
2887 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2888 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2889 so that overflow for non-base-10 numbers is reported only when
2890 there's no portable and simple way to convert to floating point.
452f4150 2891
67769ffc
PE
2892 * textprop.c (set_text_properties_1): Rewrite for clarity,
2893 and to avoid GCC warning about integer overflow.
2894
c20db43f
PE
2895 * intervals.h (struct interval): Use EMACS_INT for members
2896 where EMACS_UINT might cause problems. See
2897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2898 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2899 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2900 All uses changed.
37aa2f85
PE
2901 (offset_intervals): Tell GCC not to worry about length overflow
2902 when negating a negative length.
c20db43f 2903
2538aa2f
PE
2904 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2905 (overrun_check_free): Likewise.
2906
f2d3008d
PE
2907 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2908 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2909 word size.
2910
ec8df744
PE
2911 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2912 (gnutls_make_error): Rename local to avoid shadowing.
2913 (gnutls_emacs_global_deinit): ifdef out; not used.
2914 (Fgnutls_boot): Use const for pointer to readonly storage.
2915 Comment out unused local. Fix pointer signedness problems.
2916
640ee02d
PE
2917 * lread.c (openp): Don't stuff size_t into an 'int'.
2918 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2919 about possible signed overflow.
2920
6048fb2a
PE
2921 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2922 (GDK_KEY_g): Don't define if already defined.
2923 (xg_prepare_tooltip): Avoid pointer signedness problem.
2924 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2925
fa3c87e1
PE
2926 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2927 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2928
2172544b
PE
2929 * xfns.c (Fx_window_property): Simplify a bit,
2930 to make a bit faster and to avoid GCC 4.6.0 warning.
2931 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2932
9b821a21
PE
2933 * fns.c (internal_equal): Don't assume size_t fits in int.
2934
3c616cfa
PE
2935 * alloc.c (compact_small_strings): Tighten assertion a little.
2936
c2982e87
PE
2937 Replace pEd with more-general pI, and fix some printf arg casts.
2938 * lisp.h (pI): New macro, generalizing old pEd macro to other
2939 conversion specifiers. For example, use "...%"pI"d..." rather
2940 than "...%"pEd"...".
2941 (pEd): Remove. All uses replaced with similar uses of pI.
2942 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2943 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2944 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2945 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2946 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2947 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2948 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2949 64-bit hosts.
2950 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2951 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2952 * print.c (safe_debug_print, print_object): Likewise.
2953 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2954 to int.
6f04d126
PE
2955 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2956 avoiding the 0 flag, which is not portable.
c2982e87
PE
2957 * process.c (Fmake_network_process): Use pI to avoid cast.
2958 * region-cache.c (pp_cache): Likewise.
2959 * xdisp.c (decode_mode_spec): Likewise.
2960 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2961 behavior on 64-bit hosts with printf arg.
6f04d126 2962 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2963 (x_stop_queuing_selection_requests): Likewise.
2964 (x_get_window_property): Don't truncate byte count to an 'int'
2965 when tracing.
0b432f21 2966
5e073ec7
PE
2967 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2968 here, since it parses constructs like leading '-' and spaces,
2969 which are not wanted; and it overflows with large numbers.
2970 Instead, simply match F[0-9]+, which is what is wanted anyway.
2971
36372bf9
PE
2972 * alloc.c: Remove unportable assumptions about struct layout.
2973 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2974 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2975 (allocate_vectorlike, make_pure_vector): Use the new macros,
2976 plus offsetof, to remove unportable assumptions about struct layout.
2977 These assumptions hold on all porting targets that I know of, but
2978 they are not guaranteed, they're easy to remove, and removing them
2979 makes further changes easier.
2980
0b432f21
PE
2981 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2982 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2983 (string_overrun_cookie): Now const. Use initializers that
2984 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2985 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2986 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2987 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2988 multiple of sizeof (EMACS_INT); it need not be, if
2989 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2990 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2991
895009e1
JB
29922011-04-26 Juanma Barranquero <lekktu@gmail.com>
2993
2994 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2995
6a7a1b0b
TZ
29962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2997
2998 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2999 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3000 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3001
841a1577 30022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3003
3004 * lisp.h (Qdebug): List symbol.
895009e1 3005 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3006 * keyboard.c (debug-on-event): New variable.
3007 (handle_user_signal): Break into debugger when debug-on-event
3008 matches the current signal symbol.
3009
f2d3ba6f
DN
30102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3011
3012 * alloc.c (check_sblock, check_string_bytes)
3013 (check_string_free_list): Convert to standard C.
3014
42ce4c63
TZ
30152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3016
3017 * w32.c (emacs_gnutls_push): Fix typo.
3018
825cd63c
EZ
30192011-04-25 Eli Zaretskii <eliz@gnu.org>
3020
fb11d64d
EZ
3021 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3022 "cast to pointer from integer of different size".
3023
825cd63c
EZ
3024 Improve doprnt and its use in verror. (Bug#8545)
3025 * doprnt.c (doprnt): Document the set of format control sequences
3026 supported by the function. Use SAFE_ALLOCA instead of always
3027 using `alloca'.
3028
3029 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3030 is one byte too soon. Don't use xrealloc; instead xfree and
3031 xmalloc anew.
3032
e061a11b
TZ
30332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3034
3035 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3036 callbacks stage.
3037
3038 * gnutls.c: Renamed global_initialized to
3039 gnutls_global_initialized. Added internals for the
3040 :verify-hostname-error, :verify-error, and :verify-flags
3041 parameters of `gnutls-boot' and documented those parameters in the
3042 docstring. Start callback support.
9173deec
JB
3043 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3044 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3045 on error. Return error code.
e061a11b
TZ
3046 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3047 (emacs_gnutls_read): Likewise.
3048 (Fgnutls_boot): Return handshake error code.
3049 (emacs_gnutls_handle_error): New function.
3050 (wsaerror_to_errno): Likewise.
3051
3052 * w32.h (emacs_gnutls_pull): Add prototype.
3053 (emacs_gnutls_push): Likewise.
3054
3055 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3056 (emacs_gnutls_push): Likewise.
3057
30582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3059
3060 * process.c (wait_reading_process_output): Check if GnuTLS
3061 buffered some data internally if no FDs are set for TLS
3062 connections.
3063
3064 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3065 (LIBS): Link to USER_LIBS.
3066 ($(BLD)/gnutls.$(0)): New target.
3067
fa6996bc
EZ
30682011-04-24 Eli Zaretskii <eliz@gnu.org>
3069
eb35682e
EZ
3070 * xdisp.c (handle_single_display_spec): Rename the
3071 display_replaced_before_p argument into display_replaced_p, to
3072 make it consistent with the commentary. Fix typos in the
3073 commentary.
3074
e2ad650c
EZ
3075 * textprop.c (syms_of_textprop): Remove dead code.
3076 (copy_text_properties): Delete obsolete commentary about an
3077 interface that was deleted long ago. Fix typos in the description
3078 of arguments.
3079
1b2de274
EZ
3080 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3081 to changes in oldXMenu/XMenu.h from 2011-04-16.
3082 <menu_help_message, prev_menu_help_message>: Constify.
3083 (IT_menu_make_room): menu->help_text is now `const char **';
3084 adjust.
3085
3086 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3087 to changes in oldXMenu/XMenu.h from 2011-04-16.
3088 (struct XMenu): Declare `help_text' `const char **'.
3089
3090 * xfaces.c <Qunspecified>: Make extern again.
3091
3092 * syntax.c: Include sys/types.h before including regex.h, as
3093 required by Posix.
3094
762b15be
EZ
3095 * doc.c (get_doc_string): Improve the format passed to `error'.
3096
3097 * doprnt.c (doprnt): Improve commentary.
3098
3099 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3100
3101 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3102 them with etags.
3103
f1052e5d
EZ
3104 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3105 changes in globals.h immediately force recompilation.
762b15be
EZ
3106 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3107 $(CURDIR)/s/ms-w32.h.
3108 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3109
fa6996bc
EZ
3110 * character.c (Fchar_direction): Function deleted.
3111 (syms_of_character): Don't defsubr it.
3112 <char-direction-table>: Deleted.
3113
e6c3da20
EZ
31142011-04-23 Eli Zaretskii <eliz@gnu.org>
3115
3116 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3117 * doprnt.c: Include limits.h.
3118 (SIZE_MAX): New macro.
04f2d78b
CB
3119 (doprnt): Return a size_t value. 2nd arg is now size_t.
3120 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3121 Improve overflow protection. Support `l' modifier for integer
3122 conversions. Support %l conversion. Don't assume an EMACS_INT
3123 argument for integer conversions and for %c.
3124
3125 * lisp.h (doprnt): Restore prototype.
3126
3127 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3128 $(SRC)/character.h.
3129
3130 * Makefile.in (base_obj): Add back doprnt.o.
3131
3132 * deps.mk (doprnt.o): Add back prerequisites.
3133 (callint.o): Depend on character.h.
3134
3135 * eval.c (internal_lisp_condition_case): Include the handler
3136 representation in the error message.
3137 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3138 when breaking from the loop.
3139
3140 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3141
3142 * callint.c (Fcall_interactively): When displaying error message
3143 about invalid control letter, pass the character's codepoint, not
3144 a pointer to its multibyte form. Improve display of the character
3145 in octal and display also its hex code.
3146
3147 * character.c (char_string): Use %x to display the (unsigned)
3148 codepoint of an invalid character, to avoid displaying a bogus
3149 negative value.
3150
3151 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3152 `error', not SYMBOL_NAME itself.
3153
3154 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3155 character arguments to `error'.
3156
3157 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3158 to `error' in error message about FINAL_CHAR argument. Make sure
3159 FINAL_CHAR is a character, and use %c when it is passed as
3160 argument to `error'.
3161
4ffd0d6b 31622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3163
3164 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3165
3166 * w32.c: Include <time.h>.
3167 (sys_localtime): New function.
3168
4ffd0d6b 31692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3170
3171 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3172
4ffd0d6b 3173 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3174
4ffd0d6b 31752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3176
4ffd0d6b
GM
3177 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3178 zombies (Bug#8467).
aac0c6e3 3179
04c56954
EZ
31802011-04-19 Eli Zaretskii <eliz@gnu.org>
3181
3182 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3183 gl_state.e_property when gl_state.object is Qt.
3184
3185 * insdel.c (make_gap_larger): Remove limitation of buffer size
3186 to <= INT_MAX.
3187
16a43933
CY
31882011-04-18 Chong Yidong <cyd@stupidchicken.com>
3189
3190 * xdisp.c (lookup_glyphless_char_display)
3191 (produce_glyphless_glyph): Handle cons cell entry in
3192 glyphless-char-display.
3193 (Vglyphless_char_display): Document it.
3194
3195 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3196 glyphless-char-display.
3197
4581706e
CY
31982011-04-17 Chong Yidong <cyd@stupidchicken.com>
3199
3200 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3201
3202 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3203
3204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3205 definition for no-X builds.
3206
4887c6e2 32072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3208
fd35b6f9
PE
3209 Static checks with GCC 4.6.0 and non-default toolkits.
3210
5c1ccb01
PE
3211 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3212
006c5daa
PE
3213 * process.c (keyboard_bit_set): Define only if SIGIO.
3214 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3215 (send_process): Repair possible setjmp clobbering.
3216
efc736d3
PE
3217 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3218
4e2fe2e6
PE
3219 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3220
f97334a2
PE
3221 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3222
4e75f29d
PE
3223 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3224 Define only if needed.
3225
90efadd1
PE
3226 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3227 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3228 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3229
3c647824
PE
3230 * dispextern.h (struct redisplay_interface): Rename param
3231 to avoid shadowing.
e264f262 3232 * termhooks.h (struct terminal): Likewise.
761383f4 3233 * xterm.c (xembed_send_message): Likewise.
3c647824 3234
b58c5c4a
PE
3235 * insdel.c (make_gap_smaller): Define only if
3236 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3237
cad59032
PE
3238 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3239 it.
3240
c339dc2e
PE
3241 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3242 so that we aren't warned about unused symbols.
3243
91a3e27b
PE
3244 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3245
399c71d3 3246 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3247
8ffc96f5
PE
3248 * xfns.c (x_real_positions): Mark locals as initialized.
3249
eef9bc79
PE
3250 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3251
098db9dd
PE
3252 * xterm.c: Fix problems found by static analysis with other toolkits.
3253 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3254 (x_dispatch_event): Declare static if USE_GTK, and
3255 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3256 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3257 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3258 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3259 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3260
eb18f6cc
PE
3261 * xmenu.c (menu_help_callback): Pointer type fixes.
3262 Use const pointers when pointing at readonly data. Avoid pointer
3263 signedness clashes.
3264 (FALSE): Remove unused macro.
3265 (update_frame_menubar): Remove unused decl.
3266
1fe72bf8
PE
3267 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3268
60d9e1db
PE
3269 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3270 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3271 (single_menu_item): Rename local to avoid shadowing.
3272
39261c26
PE
3273 * keyboard.c (make_lispy_event): Remove unused local var.
3274
018c5e19
PE
3275 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3276 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3277
63d2b86e
PE
3278 * bitmaps: Change bitmaps from unsigned char back to the X11
3279 compatible char. Avoid the old compiler warnings about
3280 out-of-range initializers by using, for example, '\xab' rather
3281 than 0xab.
3282
aefd87e1
PE
3283 * xgselect.c (xgselect_initialize): Check vs interface
3284 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3285
bf501fb9
PE
3286 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3287
e9829fdf
PE
3288 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3289 to read-only memory.
3290
1086c095
PE
3291 * fns.c (vector): Remove; this old hack is no longer needed.
3292
2baccd04 3293 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3294 Remove unused var.
dde42981 3295 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3296
72391843 3297 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3298
436c16df 3299 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3300 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3301 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3302
92bb796d 3303 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3304 (x_term_init): Remove local to avoid shadowing.
92bb796d 3305
764430a3 3306 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3307
3308 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3309 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3310
d1dfb56c
EZ
33112011-04-16 Eli Zaretskii <eliz@gnu.org>
3312
c4354cb4
EZ
3313 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3314
d1dfb56c
EZ
3315 Fix regex.c, syntax.c and friends for buffers > 2GB.
3316 * syntax.h (struct gl_state_s): Declare character position members
3317 EMACS_INT.
3318
3319 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3320
04f2d78b
CB
3321 * textprop.c (verify_interval_modification, interval_of):
3322 Declare arguments EMACS_INT.
d1dfb56c
EZ
3323
3324 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3325 EMACS_INT.
3326
3327 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3328
3329 * indent.c (Fvertical_motion): Local variable it_start is now
3330 EMACS_INT.
3331
3332 * regex.c (re_match, re_match_2, re_match_2_internal)
3333 (bcmp_translate, regcomp, regexec, print_double_string)
3334 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3335 (re_compile_pattern, re_exec): Declare arguments and local
3336 variables `size_t' and `ssize_t' and return values `regoff_t', as
3337 appropriate.
3338 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3339 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3340 <compile_stack_type>: `size' and `avail' are now `size_t'.
3341
3342 * regex.h <regoff_t>: Use ssize_t, not int.
3343 (re_search, re_search_2, re_match, re_match_2): Arguments that
3344 specify buffer/string position and length are now ssize_t and
3345 size_t. Return type is regoff_t.
3346
613052cd
BK
33472011-04-16 Ben Key <bkey76@gmail.com>
3348
3349 * nsfont.m: Fixed bugs in ns_get_family and
3350 ns_descriptor_to_entity that were caused by using free to
3351 deallocate memory blocks that were allocated by xmalloc (via
3352 xstrdup). This caused Emacs to crash when compiled with
3353 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3354 --enable-checking=xmallocoverrun). xfree is now used to
3355 deallocate these memory blocks.
3356
4170f62f 33572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3358
71b41406
PE
3359 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3360
9587a89d
PE
3361 emacs_write: Accept and return EMACS_INT for sizes.
3362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3363 et seq.
3364 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3365 Accept and return EMACS_INT.
3366 (emacs_gnutls_write): Return the number of bytes written on
3367 partial writes.
3368 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3369 (emacs_read, emacs_write): Remove check for negative size, as the
3370 Emacs source code has been audited now.
9587a89d
PE
3371 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3372 (emacs_read, emacs_write): Use it.
273a5f82
PE
3373 * process.c (send_process): Adjust to the new signatures of
3374 emacs_write and emacs_gnutls_write. Do not attempt to store
3375 a byte offset into an 'int'; it might overflow.
9587a89d 3376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3377
3e047f51
PE
3378 * sound.c: Don't assume sizes fit in 'int'.
3379 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3380 Return EMACS_INT, not int.
3e047f51 3381 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3382 Accept EMACS_INT, not int.
3383 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3384 record read return values.
3385
cc39a9db
BK
33862011-04-15 Ben Key <bkey76@gmail.com>
3387
c9d0ec6d
JB
3388 * keyboard.c (Qundefined): Don't declare static since it is used
3389 in nsfns.m.
3390 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3391 static since they are used in nsfont.m.
cc39a9db 3392
6c60eb9f
SM
33932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3394
3395 * process.c (Qprocessp): Don't declare static.
3396 * lisp.h (Qprocessp): Declare again.
3397
7990b61a
JB
33982011-04-15 Juanma Barranquero <lekktu@gmail.com>
3399
3400 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3401
5d4cb038
PE
34022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3403
8bd7b830 3404 Improve C-level modularity by making more things 'static'.
cd64ea1d 3405
e3b27b31
PE
3406 Don't publish debugger-only interfaces to other modules.
3407 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3408 (verify_bytepos, count_markers): Move decls to the only modules
3409 that need them.
3410 * region-cache.h (pp_cache): Likewise.
3411 * window.h (check_all_windows): Likewise.
3412 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3413
5d4cb038
PE
3414 * sysdep.c (croak): Now static, if
3415 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3416 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3417
3418 * alloc.c (refill_memory_reserve): Now static if
3419 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3420 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3421
e87b6180
PE
3422 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3423 Define only if USE_LUCID.
3424
ac64929e
PE
3425 * xrdb.c (x_customization_string, x_rm_string): Now static.
3426
6f37259d
PE
3427 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3428 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3429
1683e3ab
PE
3430 * xdisp.c (draw_row_with_mouse_face): Now static.
3431 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3432
de9c2632
PE
3433 * window.h (check_all_windows): Mark externally visible.
3434
2b96acb7
PE
3435 * window.c (window_deletion_count): Now static.
3436
3437 * undo.c: Make symbols static if they're not exported.
3438 (last_undo_buffer, last_boundary_position, pending_boundary):
3439 Now static.
3440
50436f33
PE
3441 * textprop.c (interval_insert_behind_hooks): Now static.
3442 (interval_insert_in_front_hooks): Likewise.
3443
64520e5c
PE
3444 * term.c: Make symbols static if they're not exported.
3445 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3446 (max_frame_lines, tty_set_terminal_modes):
3447 (tty_reset_terminal_modes, tty_turn_off_highlight):
3448 (get_tty_terminal): Now static.
3449 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3450 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3451 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3452 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3453 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3454
1fa53021
PE
3455 * sysdep.c: Make symbols static if they're not exported.
3456 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3457 Now static.
3458 (sigprocmask_set, full_mask): Remove; unused.
3459 (wait_debugging): Mark as visible.
3460 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3461 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3462
d4b43b22
PE
3463 * syntax.c (syntax_temp): Define only if !__GNUC__.
3464
b7c513d0
PE
3465 * sound.c (current_sound_device, current_sound): Now static.
3466
989b29ad
PE
3467 * search.c (searchbufs, searchbuf_head): Now static.
3468
13a55a78
PE
3469 * scroll.c (scroll_cost): Remove; unused.
3470 * dispextern.h (scroll_cost): Remove decl.
3471
de68a1fc
PE
3472 * region-cache.h (pp_cache): Mark as externally visible.
3473
40ccffa6
PE
3474 * process.c: Make symbols static if they're not exported.
3475 (process_tick, update_tick, create_process, chan_process):
3476 (Vprocess_alist, proc_buffered_char, datagram_access):
3477 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3478 (deactivate_process): Mark defn as static, as well as decl.
3479 * lisp.h (create_process): Remove decl.
3480 * process.h (chan_process, Vprocess_alist): Remove decls.
3481
ad64fc97
PE
3482 * print.c: Make symbols static if they're not exported.
3483 (print_depth, new_backquote_output, being_printed, print_buffer):
3484 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3485 (print_interval, print_number_index, initial_stderr_stream):
3486 Now static.
3487 * lisp.h (Fprinc): Remove decl.
3488 (debug_output_compilation_hack): Mark as externally visible.
3489
adddb265
PE
3490 * sysdep.c (croak): Move decl from here to syssignal.h.
3491 * syssignal.h (croak): Put it here, so the API can be checked when
3492 'croak' is called from dissociate_if_controlling_tty.
3493
1717ede2
PE
3494 * minibuf.c: Make symbols static if they're not exported.
3495 (minibuf_save_list, choose_minibuf_frame): Now static.
3496 * lisp.h (choose_minibuf_frame): Remove decl.
3497
fa5fb2bc
PE
3498 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3499
1e3890d1
PE
3500 * lread.c: Make symbols static if they're not exported.
3501 (read_objects, initial_obarray, oblookup_last_bucket_number):
3502 Now static.
3503 (make_symbol): Remove; unused.
3504 * lisp.h (initial_obarray, make_symbol): Remove decls.
3505
8a1414fa
PE
3506 * keyboard.c: Make symbols static if they're not exported.
3507 (single_kboard, recent_keys_index, total_keys, recent_keys):
3508 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3509 (this_single_command_key_start, echoing, last_auto_save):
3510 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3511 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3512 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3513 (Vlispy_mouse_stem, double_click_count):
3514 Now static.
3515 (force_auto_save_soon): Define only if SIGDANGER.
3516 (ignore_mouse_drag_p): Now static if
3517 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3518 (print_help): Remove; unused.
3519 (stop_character, last_timer_event): Mark as externally visible.
3520 * keyboard.h (ignore_mouse_drag_p): Declare only if
3521 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3522 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3523 * lisp.h (echoing): Remove decl.
3524 (force_auto_save_soon): Declare only if SIGDANGER.
3525 * xdisp.c (redisplay_window): Simplify code, to make it more
3526 obvious that ignore_mouse_drag_p is not accessed if !defined
3527 USE_GTK && !defined HAVE_NS.
3528
93ea6e8f
PE
3529 * intervals.c: Make symbols static if they're not exported.
3530 (merge_properties_sticky, merge_interval_right, delete_interval):
3531 Now static.
3532 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3533
77382fcc
PE
3534 * insdel.c: Make symbols static if they're not exported.
3535 However, leave prepare_to_modify_buffer alone. It's never
3536 called from outside this function, but that appears to be a bug.
3537 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3538 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3539 (adjust_after_replace_noundo): Remove; unused.
3540 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3541 (signal_before_change): Remove decls.
77382fcc 3542
9306c32e
PE
3543 * indent.c (val_compute_motion, val_vmotion): Now static.
3544
cd44d2eb
PE
3545 * image.c: Make symbols static if they're not exported.
3546 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3547 if USE_GTK.
3548 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3549 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3550
ad9a7a06
PE
3551 * fringe.c (standard_bitmaps): Now static.
3552 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3553
81626931
PE
3554 * frame.c: Make symbols static if they're not exported.
3555 (x_report_frame_params, make_terminal_frame): Now static.
3556 (get_frame_param): Now static, unless HAVE_NS.
3557 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3558 (x_get_resource_string): Remove; not used.
3559 * frame.h (make_terminal_frame, x_report_frame_params):
3560 (x_get_resource_string); Remove decls.
3561 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3562 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3563
239f9db9
PE
3564 * font.c, fontset.c: Make symbols static if they're not exported.
3565 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3566 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3567 * font.c (font_close_object): Now static.
3568 * font.h (font_close_object): Remove.
3569 * fontset.c (FONTSET_OBJLIST): Remove.
3570 (free_realized_fontset) #if-0 the body, which does nothing.
3571 (face_suitable_for_char_p): #if-0, as it's never called.
3572 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3573 * xfaces.c (face_at_string_position):
3574 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3575 since 0 is always ASCII.
3576
dfcf3579
PE
3577 * fns.c (weak_hash_tables): Now static.
3578
5045092b
PE
3579 * fileio.c: Make symbols static if they're not exported.
3580 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3581 (Vwrite_region_annotation_buffers): Now static.
3582
57a96f5c
PE
3583 * eval.c: Make symbols static if they're not exported.
3584 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3585 * lisp.h (backtrace_list): Remove decl.
3586
35f08c38
PE
3587 * emacs.c: Make symbols static if they're not exported.
3588 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3589 (fatal_error_code, fatal_error_signal_hook, standard_args):
3590 Now static.
3591 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3592 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3593 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3594 * lisp.h (fatal_error_signal_hook): Remove decl.
3595 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3596
f44bd759
PE
3597 * editfns.c: Move a (normally-unused) function to its only use.
3598 * editfns.c, lisp.h (get_operating_system_release): Remove.
3599 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3600 worth the hassle of breaking this out.
3601
b532497d
PE
3602 * xterm.c: Make symbols static if they're not exported.
3603 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3604 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3605 (x_destroy_window, x_delete_display):
3606 Now static.
3607 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3608 (x_mouse_leave): Remove; unused.
3609 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3610 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3611 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3612 Remove decls.
3613 (x_mouse_leave): Declare only if WINDOWSNT.
3614 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3615 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3616 USE_X_TOOLKIT.
3617
1675728f
PE
3618 * ftxfont.c: Make symbols static if they're not exported.
3619 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3620 HAVE_FREETYPE.
3621 * font.h (ftxfont_driver): Likewise.
3622
e4cebfca
PE
3623 * xfns.c: Make symbols static if they're not exported.
3624 (x_last_font_name, x_display_info_for_name):
3625 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3626 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3627 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3628 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3629 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3630 (last_show_tip_args): Now static.
3631 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3632 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3633 (x_screen_planes): Remove; unused.
3634 * dispextern.h (x_screen_planes): Remove decl.
3635
5bf46f05
PE
3636 * dispnew.c: Make symbols static if they're not exported.
3637 * dispextern.h (redraw_garbaged_frames, scrolling):
3638 (increment_row_positions): Remove.
3639 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3640 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3641 Now static.
3642 (redraw_garbaged_frames): Remove; unused.
3643
435f4c28
PE
3644 * xfaces.c: Make symbols static if they're not exported.
3645 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3646 Remove decls.
3647 * xterm.h (defined_color): Remove decls.
3648 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3649 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3650 (menu_face_changed_default, defined_color, free_realized_face):
3651 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3652 (ascii_face_of_lisp_face): Remove; unused.
3653
8524aef3
PE
3654 * xdisp.c: Make symbols static if they're not exported.
3655 * dispextern.h (scratch_glyph_row, window_box_edges):
3656 (glyph_to_pixel_coords, set_cursor_from_row):
3657 (get_next_display_element, set_iterator_to_next):
3658 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3659 (show_mouse_face): Remove decls
3660 * frame.h (message_buf_print): Likewise.
3661 * lisp.h (pop_message, set_message, check_point_in_composition):
3662 Likewise.
3663 * xterm.h (set_vertical_scroll_bar): Likewise.
3664 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3665 (message_buf_print, scratch_glyph_row, displayed_buffer):
3666 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3667 (get_next_display_element, show_mouse_face, window_box_edges):
3668 (frame_to_window_pixel_xy, check_point_in_composition):
3669 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3670 (glyph_to_pixel_coords): Remove; unused.
3671
16390cd2
PE
3672 * dired.c (file_name_completion): Now static.
3673
3674 * dbusbind.c (xd_in_read_queued_messages): Now static.
3675
a25f4dfa
PE
3676 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3677 * data.c (circular_list_error): Remove.
3678
14a9c8df
PE
3679 * commands.h (last_point_position, last_point_position_buffer):
3680 (last_point_position_window): Remove decls.
3681 * keyboard.c: Make these variables static.
3682
04f2d78b
CB
3683 * coding.h (coding, code_convert_region, encode_coding_gap):
3684 Remove decls.
74ab6df5
PE
3685 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3686 (iso_code_class, detect_coding, code_convert_region): Now static.
3687 (encode_coding_gap): Remove; unused.
3688
38dfbee1
PE
3689 * chartab.c (chartab_chars, chartab_bits): Now static.
3690
a2cb4e63
PE
3691 * charset.h (charset_iso_8859_1): Remove decl.
3692 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3693 Now static.
3694
127198fd
PE
3695 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3696 * ccl.c (Vccl_program_table): Now static.
3697 (check_ccl_update): Remove; unused.
3698
d85b608f
PE
3699 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3700 * category.h: ... from here.
3701 * category.c (check_category_table, set_category_set): Now static.
3702
31cd66f3
PE
3703 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3704 * lisp.h: Remove these decls.
3705
c358e587
PE
3706 * buffer.c (buffer_count): Remove unused var.
3707
e78aecca
PE
3708 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3709 so that it's not optimized away.
3710 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3711 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3712 exported only to the debugger.
3713
e192d7d3 3714 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3715 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3716
92470028
PE
3717 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3718 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3719 was inaccessible from Lisp.
3720 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3721 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3722
244ed907
PE
3723 alloc.c: Import and export fewer symbols, and remove unused items.
3724 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3725 is defined.
3726 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3727 it's not optimized away by whole-program optimization.
3728 (message_enable_multibyte, free_misc): Remove.
3729 (catchlist, handlerlist, mark_backtrace):
3730 Declare only if BYTE_MARK_STACK.
3731 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3732 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3733 (message_enable_multibyte): Remove decl.
3734 (free_misc, interval_free_list, float_block, float_block_index):
3735 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3736 (cons_free_list, last_marked_index):
3737 Now static.
3738 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3739 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3740 (mark_backtrace): Define only if BYTE_MARK_STACK.
3741 * xdisp.c (message_enable_multibyte): Now static.
3742
61c2b50e 3743 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3744 This makes it easier for human readers (and static analyzers)
3745 to see whether these variables are used from other modules.
3746 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3747 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3748 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3749 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3750 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3751 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3752 * xmenu.c, xselect.c:
3753 Declare Q* vars static if they are not used in other modules.
3754 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3755 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3756 Remove decls of unexported vars.
3757 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3758
95c82688
PE
3759 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3760
16a97296
PE
3761 Make Emacs functions such as Fatom 'static' by default.
3762 This makes it easier for human readers (and static analyzers)
3763 to see whether these functions can be called from other modules.
3764 DEFUN now defines a static function. To make the function external
3765 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3766 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3767 (Finit_image_library):
16a97296
PE
3768 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3769 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3770 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3771 Remove decls, since these functions are now static.
3772 (Funintern, Fget_internal_run_time): New decls, since these functions
3773 were already external.
95c82688 3774
16a97296
PE
3775 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3776 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3777 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3778 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3779 * keyboard.c, keymap.c, lread.c:
3780 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3781 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3782 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3783 Mark functions with DEFUE instead of DEFUN,
3784 if they are used in other modules.
3785 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3786 decls for now-static functions.
3787 * buffer.h (Fdelete_overlay): Remove decl.
3788 * callproc.c (Fgetenv_internal): Mark as internal.
3789 * composite.c (Fremove_list_of_text_properties): Remove decl.
3790 (Fcomposition_get_gstring): New forward static decl.
3791 * composite.h (Fcomposite_get_gstring): Remove decl.
3792 * dired.c (Ffile_attributes): New forward static decl.
3793 * doc.c (Fdocumntation_property): New forward static decl.
3794 * eval.c (Ffetch_bytecode): New forward static decl.
3795 (Funintern): Remove extern decl; now in .h file where it belongs.
3796 * fileio.c (Fmake_symbolic_link): New forward static decl.
3797 * image.c (Finit_image_library): New forward static decl.
3798 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3799 * intervals.h (Fprevious_property_change):
3800 (Fremove_list_of_text_properties): Remove decls.
3801 * keyboard.c (Fthis_command_keys): Remove decl.
3802 (Fcommand_execute): New forward static decl.
3803 * keymap.c (Flookup_key): New forward static decl.
3804 (Fcopy_keymap): Now static.
3805 * keymap.h (Flookup_key): Remove decl.
3806 * process.c (Fget_process): New forward static decl.
3807 (Fprocess_datagram_address): Mark as internal.
3808 * syntax.c (Fsyntax_table_p): New forward static decl.
3809 (skip_chars): Remove duplicate decl.
3810 * textprop.c (Fprevious_property_change): New forward static decl.
3811 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3812 Now internal.
3813 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3814 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3815
785bbd42
PE
3816 * editfns.c (Fformat): Remove unreachable code.
3817
8b913b57
AS
38182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3819
3820 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3821 change. (Bug#8496)
3822
a6744a35
EZ
38232011-04-13 Eli Zaretskii <eliz@gnu.org>
3824
3825 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3826 when at ZV. (Bug#8487)
3827
e7974947
AS
38282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3829
baad03f0
AS
3830 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3831 (Bug#8437)
3832 * keyboard.c (parse_tool_bar_item): Likewise.
3833 * sound.c (sound_cleanup, alsa_close): Likewise.
3834 * termcap.c (tgetent): Likewise.
3835 * xfns.c (x_default_font_parameter): Likewise.
3836 * xsettings.c (read_and_apply_settings): Likewise.
3837
e7974947
AS
3838 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3839 (overrun_check_free): Protoize.
3840
28272684
PE
38412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3844 since callers should never pass a negative size.
3845 Change the signature to match that of plain 'read' and 'write'; see
3846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3847 * lisp.h: Update prototypes of emacs_write and emacs_read.
3848
11997c76
EZ
38492011-04-11 Eli Zaretskii <eliz@gnu.org>
3850
3851 * xdisp.c (redisplay_window): Don't try to determine the character
3852 position of the scroll margin if the window start point w->startp
e896f03c 3853 is outside the buffer's accessible region. (Bug#8468)
11997c76 3854
8a2cbd72
EZ
38552011-04-10 Eli Zaretskii <eliz@gnu.org>
3856
3857 Fix write-region and its subroutines for buffers > 2GB.
3858 * fileio.c (a_write, e_write): Modify declaration of arguments and
3859 local variables to support buffers larger than 2GB.
3860 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3861
3862 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3863 argument, local variables, and return value.
3864
3865 * lisp.h: Update prototypes of emacs_write and emacs_read.
3866
3867 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3868
4073e537 38692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3870
1ebfdcb6
PE
3871 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3872
b2ded58d
PE
3873 Fix more problems found by GCC 4.6.0's static checks.
3874
7d66342c
PE
3875 * xdisp.c (vmessage): Use a better test for character truncation.
3876
bbf47d44
PE
3877 * charset.c (load_charset_map): <, not <=, for optimization,
3878 and to avoid potential problems with integer overflow.
9248994d 3879 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3880 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3881 * editfns.c (Fformat): Likewise.
1e69125e 3882 * syntax.c (skip_chars): Likewise.
3befa583 3883
e3019616
PE
3884 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3885 This also lets GCC 4.6.0 generate slightly better loop code.
3886
becfa255
PE
3887 * callint.c (Fcall_interactively): <, not <=, for optimization.
3888 (Fcall_interactively): Count the number of arguments produced,
3889 not the number of arguments given. This is simpler and lets GCC
3890 4.6.0 generate slightly better code.
3891
dae0cd48
PE
3892 * ftfont.c: Distingish more carefully between FcChar8 and char.
3893 The previous code passed unsigned char * to a functions like
3894 strlen and xstrcasecmp that expect char *, which does not
3895 conform to the C standard.
3896 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3897 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3898 char * when the C standard requires it.
3899
76032d70
PE
3900 * keyboard.c (read_char): Remove unused var.
3901
eb3f1cc8
PE
3902 * eval.c: Port to Windows vsnprintf (Bug#8435).
3903 Include <limits.h>.
3904 (SIZE_MAX): Define if the headers do not.
3905 (verror): Do not give up if vsnprintf returns a negative count.
3906 Instead, grow the buffer. This ports to Windows vsnprintf, which
3907 does not conform to C99. Problem reported by Eli Zaretskii.
3908 Also, simplify the allocation scheme, by avoiding the need for
3909 calling realloc, and removing the ALLOCATED variable.
3910
70476b54
PE
3911 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3912
12020a9e
PE
3913 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3914 But keep the doprint source code for now, as we might revamp it
3915 and use it again (Bug#8435).
ea6c7ae6
PE
3916 * lisp.h (doprnt): Remove.
3917 * Makefile.in (base_obj): Remove doprnt.o.
3918 * deps.mk (doprnt.o): Remove.
3919
5fdb398c
PE
3920 error: Print 32- and 64-bit integers portably (Bug#8435).
3921 Without this change, on typical 64-bit hosts error ("...%d...", N)
3922 was used to print both 32- and 64-bit integers N, which relied on
3923 undefined behavior.
3924 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3925 New macro.
3926 * lisp.h (error, verror): Mark as printf-like functions.
3927 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3928 Report overflow in size calculations when allocating printf buffer.
3929 Do not truncate output string at its first null byte.
3930 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3931 Truncate the output at a character boundary, since vsnprintf does not
3932 do that.
3933 * charset.c (check_iso_charset_parameter): Convert internal
3934 character to string before calling 'error', since %c now has the
3935 printf meaning.
3936 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3937 overflow when computing char to be passed to 'error'. Do not
3938 pass Lisp_Object to 'error'; pass the integer instead.
3939 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3940 formatted with plain %d.
3941
b189fa66
PE
3942 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3943
bff87ef0
PE
3944 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3945
7e2cac20
PE
3946 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3947
ce4d90b5
PE
3948 * xterm.c (x_catch_errors): Remove duplicate declaration.
3949
266c9547
PE
3950 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3951
79c49ad2
PE
3952 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3953
368f4090
JM
39542011-04-10 Jim Meyering <meyering@redhat.com>
3955
3956 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3957 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3958 return ssize_t not "int", and use size_t as the buffer length.
3959 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3960 * gnutls.h: Update declarations.
3961 * process.c (read_process_output): Use ssize_t, to match.
3962 (send_process): Likewise.
3963
a32d4040
CY
39642011-04-09 Chong Yidong <cyd@stupidchicken.com>
3965
3966 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3967
8546720e 39682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3969
04f2d78b
CB
3970 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3971 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3972
8546720e
GM
3973 * xterm.c (handle_one_xevent):
3974 * xmenu.c (create_and_show_popup_menu):
3975 * xselect.c (x_decline_selection_request)
3976 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3977
0a2f5c1a 39782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3979
3980 Fix some uses of `int' instead of EMACS_INT.
3981 * search.c (string_match_1, fast_string_match)
3982 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3983 (scan_buffer, find_next_newline_no_quit)
3984 (find_before_next_newline, search_command, Freplace_match)
3985 (Fmatch_data): Make some `int' variables be EMACS_INT.
3986
3987 * xdisp.c (display_count_lines): 3rd argument and return value now
3988 EMACS_INT. All callers changed.
3989 (pint2hrstr): Last argument is now EMACS_INT.
3990
3991 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3992 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3993 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3994 (decode_coding_utf_16, decode_coding_emacs_mule)
3995 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3996 (decode_coding_ccl, decode_coding_charset)
3997 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3998 (decode_coding_iso_2022, decode_coding_emacs_mule)
3999 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4000 <char_offset, last_offset>: Declare EMACS_INT.
4001 (encode_coding_utf_8, encode_coding_utf_16)
4002 (encode_coding_emacs_mule, encode_invocation_designation)
4003 (encode_designation_at_bol, encode_coding_iso_2022)
4004 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4005 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4006 Declare EMACS_INT.
4007 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4008 (encode_invocation_designation): Last argument P_NCHARS is now
4009 EMACS_INT.
4010 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4011 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4012
4013 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4014 All users changed.
4015
4016 * ccl.c (Fccl_execute_on_string): Declare some variables
4017 EMACS_INT.
4018
8546720e 40192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4020
4021 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4022
4e19a977
CS
40232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4024
4025 * process.c (Fformat_network_address): Doc fix.
4026
87302331
R
40272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4028
4029 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4030
cbb59342
CY
40312011-04-08 Chong Yidong <cyd@stupidchicken.com>
4032
4033 * keyboard.c (read_char): Call Lisp function help-form-show,
4034 instead of using internal_with_output_to_temp_buffer.
4035 (Qhelp_form_show): New var.
e0d38eeb 4036 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4037
4038 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4039
4040 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4041
e67a13ab
CY
40422011-04-06 Chong Yidong <cyd@stupidchicken.com>
4043
04f2d78b
CB
4044 * process.c (Flist_processes): Remove to Lisp.
4045 (list_processes_1): Delete.
e67a13ab 4046
973f782d
EZ
40472011-04-06 Eli Zaretskii <eliz@gnu.org>
4048
7c106b1e
EZ
4049 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4050
973f782d
EZ
4051 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4052
41cf7d1a 40532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4054
ca23cc88
PE
4055 Fix more problems found by GCC 4.6.0's static checks.
4056
f390e2d5
PE
4057 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4058
42eea0d0
PE
4059 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4060
b69769da 4061 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4062
f9541e84
PE
4063 * xdisp.c (vmessage): Mark as a printf-like function.
4064
13841b55
PE
4065 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4066
c136c10f
PE
4067 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4068
5e2d4a30
PE
4069 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4070 printf-like functions.
4071 (tiff_load): Add casts to remove these marks before passing them
4072 to system-supplied API.
4073
583f48b9
PE
4074 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4075
b25d760e
PE
4076 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4077 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4078 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4079 directly, rather than having caller test rule sign. This avoids
4080 some unnecessary tests.
4081 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4082 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4083 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4084
bc7b6697 4085 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4086 (xfont_open): Avoid unnecessary tests.
bc7b6697 4087
27ccc379
PE
4088 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4089
dcd5c89a
PE
4090 * composite.h, composite.c (composition_gstring_put_cache):
4091 Use EMACS_INT, not int, for length.
4092
b13a45c6
PE
4093 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4094 breaking out part of COMPOSITION_DECODE_RULE.
4095 (COMPOSITION_DECODE_RULE): Use it.
4096 * composite.c (get_composition_id): Remove unused local vars,
4097 by using the new macro.
4098
1e792e4d
PE
4099 * textprop.c (set_text_properties_1): Change while to do-while,
4100 since the condition is always true at first.
4101
dc6c6455 4102 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4103 (interval_deletion_adjustment): Return unsigned value.
4104 All uses changed.
dc6c6455 4105
aba7731a
PE
4106 * process.c (list_processes_1, create_pty, read_process_output):
4107 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4108 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4109 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4110 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4111 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4112
fdfc4bf3
PE
4113 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4114
fca8fe46 4115 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4116 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4117
06a0259a 4118 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4119 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4120 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4121
e7b9e80f
PE
4122 * print.c (print_error_message): Avoid int overflow.
4123
56201685
PE
4124 * font.c (font_list_entities): Redo for clarity,
4125 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4126
78834453 4127 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4128 (font_score): Avoid potential overflow in diff calculation.
78834453 4129
0bc0b309 4130 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4131 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4132
e610eaca
PE
4133 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4134
b895abce
PE
4135 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4136 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4137 can always succeed if overflow has undefined behavior.
4138
1f1d9321 4139 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4140 (wordify): Omit three unnecessary tests.
1f1d9321 4141
c59478bc
PE
4142 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4143 All callers changed. This avoids the need for an unused var.
4144
79b73827
PE
4145 * casefiddle.c (casify_region): Remove var that is set but not used.
4146
a4db5dfe
PE
4147 * dired.c (file_name_completion): Remove var that is set but not used.
4148
43aae36e
PE
4149 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4150
2a47c44d 4151 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4152 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4153
a37c69bf
PE
4154 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4155 Check for integer overflow on size calculations.
4156
328ab8e7
PE
4157 * buffer.c (Fprevious_overlay_change): Remove var that is set
4158 but not used.
4159
e5a2a5cb
PE
4160 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4161 Remove vars that are set but not used.
8d84a6eb 4162 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4163 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4164
a60e5f68
PE
4165 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4166
f661cb61 4167 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4168 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4169
f0397f5a
PE
4170 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4171 that are set but not used.
4172
8664db06 4173 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4174 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4175
6abdaa4a
PE
4176 * xselect.c (x_get_local_selection, x_handle_property_notify):
4177 Remove vars that are set but not used.
4178
0ce7538d 4179 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4180 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4181
9ae848fc
PE
4182 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4183 Remove var that is set but not used.
0b918413
PE
4184 (scroll_bar_windows_size): Now size_t, not int.
4185 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4186 Check for overflow.
9ae848fc 4187
a5a62657
PE
4188 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4189 (map_tty_color) [!defined MSDOS]: Likewise.
4190
5c5cdd39
PE
4191 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4192
66ebf983
PE
4193 * coding.c: Remove vars that are set but not used.
4194 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4195 All callers changed.
4196 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4197 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4198 (decode_coding_charset): Remove vars that are set but not used.
4199
1be4d761
PE
4200 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4201 that is set but not used.
4202
47553fa8
PE
4203 * print.c (print_object): Remove var that is set but not used.
4204
1f7196bf 4205 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4206 The gnulib version avoids calling malloc in the usual case,
4207 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4208 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4209 * filelock.c (current_lock_owner): Likewise.
4210 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4211 * sysdep.c: Include allocator.h, careadlinkat.h.
4212 (emacs_no_realloc_allocator): New static constant.
4213 (emacs_readlink): New function.
fdb61804
PE
4214 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4215 ../lib/careadlinkat.h.
d1fdcab7 4216
f84c17c7
SM
42172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4218
4219 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4220 first non-nil return value).
4221
ef3862ad
JD
42222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4223
4224 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4225 if not defined (Bug#8403).
4226
376a7006
JB
42272011-04-02 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * xdisp.c (display_count_lines): Remove parameter `start',
4230 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4231 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4232 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4233 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4234 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4235 and thereabouts. All callers changed.
4236 (get_per_char_metric): Remove parameter `f', unused since
4237 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4238
6ca3801d
JM
42392011-04-02 Jim Meyering <meyering@redhat.com>
4240
4241 do not dereference NULL upon failed strdup
4242 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4243 (ns_get_family): Likewise.
4244
d8e2b5ba
JB
42452011-04-02 Juanma Barranquero <lekktu@gmail.com>
4246
4247 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4248
8c74fcbd
JD
42492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4250
4251 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4252 later (Bug#8403).
4253
7200d79c
SM
42542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4255
03408648 4256 Add lexical binding.
7200d79c 4257
03408648
SM
4258 * window.c (Ftemp_output_buffer_show): New fun.
4259 (Fsave_window_excursion):
4260 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4261
4262 * lread.c (lisp_file_lexically_bound_p): New function.
4263 (Fload): Bind Qlexical_binding.
4264 (readevalloop): Remove `evalfun' arg.
4265 Bind Qinternal_interpreter_environment.
4266 (Feval_buffer): Bind Qlexical_binding.
4267 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4268 Mark as dynamic.
4269 (syms_of_lread): Declare `lexical-binding'.
4270
4271 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4272
4273 * keyboard.c (eval_dyn): New fun.
4274 (menu_item_eval_property): Use it.
ca105506
SM
4275
4276 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4277
03408648
SM
4278 * fns.c (concat, mapcar1): Accept byte-code-functions.
4279
4280 * eval.c (Fsetq): Handle lexical vars.
4281 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4282 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4283 (FletX, Flet): Obey lexical binding.
4284 (Fcommandp): Handle closures.
4285 (Feval): New `lexical' arg.
4286 (eval_sub): New function extracted from Feval. Use it almost
4287 everywhere where Feval was used. Look up vars in lexical env.
4288 Handle closures.
4289 (Ffunctionp): Move from subr.el.
4290 (Ffuncall): Handle closures.
4291 (apply_lambda): Remove `eval_flags'.
4292 (funcall_lambda): Handle closures and new byte-code-functions.
4293 (Fspecial_variable_p): New function.
4294 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4295 but without exporting it to Lisp.
23aba0ea 4296
23aba0ea 4297 * doc.c (Fdocumentation, store_function_docstring):
03408648 4298 * data.c (Finteractive_form): Handle closures.
23aba0ea 4299
03408648
SM
4300 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4301 interactive spec.
ba83908c 4302
04f2d78b
CB
4303 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4304 New byte-codes.
03408648
SM
4305 (exec_byte_code): New function extracted from Fbyte_code to handle new
4306 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4307
03408648 4308 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4309
03408648 4310 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4311
e2abce01
JB
43122011-03-31 Juanma Barranquero <lekktu@gmail.com>
4313
4314 * xdisp.c (redisplay_internal): Fix prototype.
4315
63696a73 43162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4317
63696a73 4318 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4319 (try_scrolling): Use it when setting scroll_limit.
4320 Limit scrolling to 100 screen lines.
63696a73
EZ
4321 (redisplay_window): Even when falling back on "recentering",
4322 position point in the window according to scroll-conservatively,
4323 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4324
4325 (try_scrolling): When point is above the window, allow searching
4326 as far as scroll_max, or one screenful, to compute vertical
4327 distance from PT to the scroll margin position. This prevents
4328 try_scrolling from unnecessarily failing when
4329 scroll-conservatively is set to a value slightly larger than the
4330 window height. Clean up the case of PT below the margin at bottom
4331 of window: scroll_max can no longer be INT_MAX. When aggressive
4332 scrolling is in use, don't let point enter the opposite scroll
4333 margin as result of the scroll.
4334 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4335 threshold of 100 lines for never-recentering scrolling.
4336
e4cc2dfc
JB
43372011-03-31 Juanma Barranquero <lekktu@gmail.com>
4338
4339 * dispextern.h (move_it_by_lines):
4340 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4341 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4342 (message_log_check_duplicate): Remove parameters `prev_bol' and
4343 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4344 (redisplay_internal): Remove parameter `preserve_echo_area',
4345 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4346
4347 * indent.c (Fvertical_motion):
4348 * window.c (window_scroll_pixel_based, Frecenter):
4349 Don't pass `need_y_p' to `move_it_by_lines'.
4350
1c470562
SM
43512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4352
44f230aa
SM
4353 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4354 steal a few bits to be more compact.
4355 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4356 Remove unneeded casts.
4357
1c470562
SM
4358 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4359
888adce9
ZK
43602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4361
4362 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4363 binding" message (bug#7967).
4364
f838ed7b
PE
43652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4366
77861b95
PE
4367 Fix more problems found by GCC 4.6.0's static checks.
4368
de6dbc14
PE
4369 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4370 Remove unused local var.
4371
f838ed7b
PE
4372 * editfns.c (Fmessage_box): Remove unused local var.
4373
792c7b2b
PE
4374 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4375 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4376 Omit unused local vars.
c499e557 4377 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4378 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4379 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4380 Omit unused local var.
4381
ba0165e1
PE
4382 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4383 Don't assume string length fits in int.
32ad8845 4384 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4385 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4386
3c59b4c9
PE
4387 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4388 instead of alloca (Bug#8344).
4389
a3eed478 4390 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4391 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4392
eb4d412d
PE
4393 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4394
1658b401
PE
4395 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4396 concerns.
4397
4398 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4399
4400 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4401
9a2c6e05
PE
4402 * keyboard.c (syms_of_keyboard): Use the same style as later
4403 in this function when indexing through an array. This also
4404 works around GCC bug 48267.
4405
03d0a109
PE
4406 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4407
44f730c8
PE
4408 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4409
fe75f926
PE
4410 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4411 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4412
ffa8c828
PE
4413 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4414 This avoids undefined behavior on integer overflow, and is a bit
4415 more convenient anyway since it is compared to a size_t variable.
4416
c5101a77
PE
4417 Variadic C functions now count arguments with size_t, not int.
4418 This avoids an unnecessary limitation on 64-bit machines, which
4419 caused (substring ...) to crash on large vectors (Bug#8344).
4420 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4421 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4422 All variadic functions and their callers changed accordingly.
c5101a77
PE
4423 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4424 * data.c (arith_driver, float_arith_driver): Likewise.
4425 * editfns.c (general_insert_function): Likewise.
4426 * eval.c (struct backtrace.nargs, interactive_p)
4427 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4428 (funcall_lambda, mark_backtrace): Likewise.
4429 * fns.c (concat): Likewise.
4430 * frame.c (x_set_frame_parameters): Likewise.
4431 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4432 0 if not found, not -1. All callers changed.
4433
dd3f25f7
PE
4434 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4435 (stack_copy_size): Now size_t, not int.
4436 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4437
461c2ab9
JB
44382011-03-28 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4441 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4442 All callers changed.
4443
4444 * lisp.h (multibyte_char_to_unibyte):
4445 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4446 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4447 * character.h (CHAR_TO_BYTE8):
4448 * cmds.c (internal_self_insert):
4449 * editfns.c (general_insert_function):
4450 * keymap.c (push_key_description):
4451 * search.c (Freplace_match):
4452 * xdisp.c (message_dolog, set_message_1): All callers changed.
4453
f6d62986
SM
44542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4455
4456 * keyboard.c (safe_run_hook_funcall): New function.
4457 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4458 don't set the hook to nil, but remove the offending function instead.
4459 (Qcommand_hook_internal): Remove, unused.
4460 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4461 Vcommand_hook_internal.
4462
4463 * eval.c (enum run_hooks_condition): Remove.
4464 (funcall_nil, funcall_not): New functions.
4465 (run_hook_with_args): Call each function through a `funcall' argument.
4466 Remove `cond' argument, now redundant.
4467 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4468 (Frun_hook_with_args_until_failure): Adjust accordingly.
4469 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4470
1db5b1ad
JB
44712011-03-28 Juanma Barranquero <lekktu@gmail.com>
4472
4473 * dispextern.h (string_buffer_position): Remove declaration.
4474
4475 * print.c (strout): Remove parameter `multibyte', unused since
4476 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4477
4478 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4479 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4480 All callers changed.
4481
4482 * w32.c (_wsa_errlist): Use braces for struct initializers.
4483
4484 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4485 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4486 All callers changed.
4487 (string_buffer_position): Likewise. Also, make static (it's never
4488 used outside xdisp.c).
4489 (cursor_row_p): Remove parameter `w', unused since
4490 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4491 (decode_mode_spec): Remove parameter `precision', introduced during
4492 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4493 All callers changed.
4494
5ffb62aa
JD
44952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4496
4497 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4498
461c2ab9 44992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4500
4501 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4502 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4503 (ns_update_auto_hide_menu_bar): New functions.
4504 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4505 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4506 ns_constrain_all_frames.
4507 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4508 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4509
5c380ffb
JD
45102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4511
4512 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4513
9af30bdf
GM
45142011-03-27 Glenn Morris <rgm@gnu.org>
4515
4516 * syssignal.h: Replace RETSIGTYPE with void.
4517 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4518 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4519 Replace SIGTYPE with void everywhere.
4520 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4521 * s/template.h (SIGTYPE): Remove commented out definition.
4522
e2abce01
JB
45232011-03-26 Eli Zaretskii <eliz@gnu.org>
4524
4525 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4526 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4527
f868cd8a
JB
45282011-03-26 Juanma Barranquero <lekktu@gmail.com>
4529
59eb0929
JB
4530 * w32.c (read_unc_volume): Use parameter `henum', instead of
4531 global variable `wget_enum_handle'.
4532
4533 * keymap.c (describe_vector): Remove parameters `indices' and
4534 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4535 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4536
f868cd8a
JB
4537 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4538
4539 * keyboard.c (timer_check): Remove parameter `do_it_now',
4540 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4541 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4542 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4543
4544 * keyboard.c (read_char):
4545 * w32menu.c (w32_menu_display_help):
4546 * xmenu.c (show_help_event, menu_help_callback):
4547 Adjust calls to `show_help_echo'.
4548
4549 * gtkutil.c (xg_maybe_add_timer):
4550 * keyboard.c (readable_events):
4551 * process.c (wait_reading_process_output):
4552 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4553
4554 * insdel.c (adjust_markers_gap_motion):
4555 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4556 (gap_left, gap_right): Don't call it.
4557
2ecf6fdb
CY
45582011-03-25 Chong Yidong <cyd@stupidchicken.com>
4559
4560 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4561 incurred during fontification.
4562
6b1f9ba4
JB
45632011-03-25 Juanma Barranquero <lekktu@gmail.com>
4564
4565 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4566 (DEFVAR_PER_BUFFER): Don't pass it.
4567
4568 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4569 (scrolling_window): Don't pass it.
4570
0f4a96b5
JB
45712011-03-25 Juanma Barranquero <lekktu@gmail.com>
4572
4573 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4574
4575 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4576 and `suffix'.
4577 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4578 of variables specific to SELinux and computation of `encoded_absname'.
4579
4580 * image.c (XPutPixel): Remove unused variable `height'.
4581
4582 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4583
4584 * unexw32.c (get_section_info): Remove unused variable `section'.
4585
4586 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4587 (system_process_attributes): Remove unused variable `sess'.
4588 (sys_read): Remove unused variable `err'.
4589
4590 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4591 (w32_wnd_proc): Remove unused variable `isdead'.
4592 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4593 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4594 (x_create_tip_frame): Remove unused variable `tem'.
4595
4596 * w32inevt.c (w32_console_read_socket):
4597 Remove unused variable `no_events'.
4598
4599 * w32term.c (x_draw_composite_glyph_string_foreground):
4600 Remove unused variable `width'.
4601
1149507c
JB
46022011-03-24 Juanma Barranquero <lekktu@gmail.com>
4603
4604 * w32term.c (x_set_glyph_string_clipping):
4605 Don't pass uninitialized region to CombineRgn.
4606
9c88f339
JB
46072011-03-23 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4610 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4611 (Fx_close_connection): Remove unused variable `i'.
4612
4613 * w32font.c (w32font_draw): Return number of glyphs.
4614 (w32font_open_internal): Remove unused variable `i'.
4615 (w32font_driver): Add missing initializer.
4616
4617 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4618 (fill_in_menu): Remove unused variable `items_added'.
4619
4620 * w32term.c (last_mouse_press_frame): Remove static global variable.
4621 (w32_clip_to_row): Remove unused variable `f'.
4622 (x_delete_terminal): Remove unused variable `i'.
4623
4624 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4625 (NOTHING): Remove unused static global variable.
4626 (uniscribe_check_otf): Remove unused variable `table'.
4627 (uniscribe_font_driver): Add missing initializers.
4628
dee091a3
JD
46292011-03-23 Julien Danjou <julien@danjou.info>
4630
4631 * term.c (Fsuspend_tty, Fresume_tty):
4632 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4633 * window.c (temp_output_buffer_show):
4634 * insdel.c (signal_before_change):
4635 * frame.c (Fhandle_switch_frame):
4636 * fileio.c (Fdo_auto_save):
4637 * emacs.c (Fkill_emacs):
4638 * editfns.c (save_excursion_restore):
4639 * cmds.c (internal_self_insert):
4640 * callint.c (Fcall_interactively):
4641 * buffer.c (Fkill_all_local_variables):
4642 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4643 Use Frun_hooks.
0f4a96b5 4644 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4645 unconditionnaly since it does the check itself.
4646
2c520ab5 46472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4648
c9c49752
PE
4649 Fix more problems found by GCC 4.5.2's static checks.
4650
8abc3f12
PE
4651 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4652 the first time through the loop, since we know p0 < p1 then.
4653 This also avoids a gcc -Wstrict-overflow warning.
4654
a2d26660
PE
4655 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4656 leading to a memory leak, possible in functions like
4657 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4658 of objects (Bug#8318).
a2d26660 4659
916c72e9
PE
4660 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4661 that could (at least in theory) be that large.
4662
19ab8a18
PE
4663 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4664 This is less likely to overflow, and avoids undefined behavior if
4665 overflow does occur. All callers changed. Use strtoul to scan
4666 for the unsigned long integer.
b7cbbd6f
PE
4667 (pint2hrstr): Simplify and tune code slightly.
4668 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4669
f0641eff
PE
4670 * scroll.c (do_scrolling): Work around GCC bug 48228.
4671 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4672
7f650bb9
PE
4673 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4674 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4675 (validate_x_resource_name): Simplify count usage.
4676 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4677
37dd57d1
PE
4678 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4679 fail (Bug#8306).
81e56e61 4680
699979fc 4681 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4682
401bf9b4
PE
4683 * process.c (Fmake_network_process): Use socklen_t, not int,
4684 where POSIX says socklen_t is required in portable programs.
4685 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4686 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4687 (Fmake_network_process, server_accept_connection):
4688 (wait_reading_process_output, read_process_output):
4689 Likewise.
4690
b93aacde
PE
4691 * process.c: Rename or move locals to avoid shadowing.
4692 (list_processes_1, Fmake_network_process):
4693 (read_process_output_error_handler, exec_sentinel_error_handler):
4694 Rename or move locals.
4dc343ee 4695 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4696 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4697 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4698 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4699 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4700
af8a867c 4701 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4702 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4703 Include tparam.h instead, since it declares them.
af8a867c
PE
4704 * cm.h (PC): Remove extern decl; tparam.h now does this.
4705 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4706 * terminfo.c: Include tparam.h, to check interfaces.
4707 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4708 (tparam): Adjust signature to match interface in tparam.h;
4709 this removes some undefined behavior. Check that outstring and len
4710 are zero, which they always are with Emacs.
4711 * tparam.h (PC, BC, UP): New extern decls.
4712
0248044d 4713 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4714 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4715
8ff096c1 4716 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4717 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4718 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4719 (ftfont_list): Remove unused local.
49eaafba
PE
4720 (get_adstyle_property, ftfont_pattern_entity):
4721 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4722 Rename locals to avoid shadowing.
8ff096c1 4723
e2be39f6
PE
4724 * xfont.c (xfont_list_family): Mark var as initialized.
4725
c9735e30
PE
4726 * xml.c (make_dom): Now static.
4727
8f5201ae
PE
4728 * composite.c (composition_compute_stop_pos): Rename local to
4729 avoid shadowing.
b246f932
PE
4730 (composition_reseat_it): Remove unused locals.
4731 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4732 (composition_update_it): Mark var as initialized.
11b61122
PE
4733 (find_automatic_composition): Mark vars as initialized,
4734 with a FIXME (Bug#8290).
8f5201ae 4735
760fbc2c
PE
4736 character.h: Rename locals to avoid shadowing.
4737 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4738 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4739 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4740 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4741 to avoid shadowing.
4742
ff08eb85
PE
4743 * textprop.c (property_change_between_p): Remove; unused.
4744
fc7bf025
PE
4745 * intervals.c (interval_start_pos): Now static.
4746
235d7abc
PE
4747 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4748
44f230aa
SM
4749 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4750 Rename locals to avoid shadowing.
3e7d6594 4751
50060332
PE
4752 * sound.c (wav_play, au_play, Fplay_sound_internal):
4753 Fix pointer signedness.
d01f234b 4754 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4755 (wav_play): Initialize a variable to 0, to prevent undefined
4756 behavior (Bug#8278).
50060332 4757
c4fc4e30
PE
4758 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4759
918436ed
PE
4760 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4761
c939f91b
PE
4762 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4763 clobbering (Bug#8298).
b9c7f648
PE
4764 * sysdep.c (sys_subshell): Likewise.
4765 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4766
6bd8c144
PE
4767 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4768 This should get cleaned up, so that child_setup has the
4769 same signature on all platforms.
4770
7710357c 4771 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4772 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4773
c59da222
CY
47742011-03-22 Chong Yidong <cyd@stupidchicken.com>
4775
4776 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4777 not to be necessary, and produces flickering.
4778
66b87493
GM
47792011-03-20 Glenn Morris <rgm@gnu.org>
4780
4781 * config.in: Remove file.
4782
45b6f6d5
JB
47832011-03-20 Juanma Barranquero <lekktu@gmail.com>
4784
4785 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4786 are now in src/globals.h.
4787 (syms_of_minibuf): Remove spurious & from previous change.
4788
3ec03f7e
LL
47892011-03-20 Leo <sdl.web@gmail.com>
4790
4791 * minibuf.c (completing-read-function): New variable.
4792 (completing-read-default): Rename from completing-read.
4793 (completing-read): Call completing-read-function.
4794
b14e3e21
CY
47952011-03-19 Juanma Barranquero <lekktu@gmail.com>
4796
4797 * xfaces.c (Fx_load_color_file):
4798 Read color file from absolute filename (bug#8250).
4799
f2b726e6
JB
48002011-03-19 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * makefile.w32-in: Update dependencies.
4803
09f6ff02
EZ
48042011-03-17 Eli Zaretskii <eliz@gnu.org>
4805
4806 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4807
29a6015a
PE
48082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4809
a3a6c54e
PE
4810 Fix more problems found by GCC 4.5.2's static checks.
4811
b766f867
PE
4812 * process.c (make_serial_process_unwind, send_process_trap):
4813 (sigchld_handler): Now static.
4814
be02381c
PE
4815 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4816 That way, the code declares only the vars that it needs.
4817 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4818 * s/cygwin.h (PTY_ITERATION): Likewise.
4819 * s/darwin.h (PTY_ITERATION): Likewise.
4820 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4821
57048744
PE
4822 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4823 * process.c (allocate_pty): Don't declare stb unless it's needed.
4824
7914961c 4825 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4826 (CONSTANTLIM): Remove; unused.
4827 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4828 Define only if needed.
7914961c 4829
b3967b18
PE
4830 * unexelf.c (unexec): Name an expression,
4831 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4832 Use a different way to cause a compilation error if anyone uses
4833 n rather than nn, a way that does not involve shadowing.
73366a00 4834 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4835
29a6015a
PE
4836 * deps.mk (unexalpha.o): Remove; unused.
4837
43cfc33e 4838 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4839 * unexec.h: New file.
ce701a33
PE
4840 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4841 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4842 Depend on unexec.h.
4843 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4844 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4845 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4846 Change as necessary to match prototype in unexec.h.
ce701a33 4847
01f44d5a
PE
4848 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4849 shadowing.
4f63c6bb 4850 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4851
a6670b0b
PE
4852 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4853 Rename locals to avoid shadowing.
4854
cef2010d 4855 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4856 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4857
d4d7173a
PE
4858 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4859
f08b802a
PE
4860 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4861 warning when compiling print.c.
4862
3ddb0639
PE
4863 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4864 instead of using an uninitialized var.
5ad03b97 4865 (font_sort_entities): Mark var as initialized.
3ddb0639 4866
170a2692
PE
4867 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4868
e663c700
PE
4869 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4870 pointers to constants.
89bc529a 4871 (font_parse_fcname): Remove unused vars.
7b81e2d0 4872 (font_delete_unmatched): Now static.
ea838e10 4873 (font_get_spec): Remove; unused.
13a547c6
PE
4874 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4875 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4876 Rename or move locals to avoid shadowing.
e663c700 4877
2a80c887 4878 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4879 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4880
1384fa33 4881 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4882 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4883
8b2c52e9
PE
4884 * alloc.c (mark_backtrace): Move decl from here ...
4885 * lisp.h: ... to here, so that it can be checked.
4886
475545b5 4887 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4888 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4889 (lisp_indirect_variable): Name an expression,
4890 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4891 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4892
b1349114 4893 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4894 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4895 Use const pointer when appropriate.
b1349114 4896
a2928364
PE
4897 * lisp.h (get_system_name, get_operating_system_release):
4898 Move decls here, to check interfaces.
4899 * process.c (get_operating_system_release): Move decl to lisp.h.
4900 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4901 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4902 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4903 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4904 (Fformat_time_string, Fencode_time, Finsert_char):
4905 (Ftranslate_region_internal, Fformat):
4906 Rename or remove local vars to avoid shadowing.
9710023e 4907 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4908
a415e694
PE
4909 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4910 avoid shadowing.
4911
8ef4622d
PE
4912 * lisp.h (eassert): Check that the argument compiles, even if
4913 ENABLE_CHECKING is not defined.
4914
946f9a5b
PE
4915 * data.c (Findirect_variable): Name an expression, to avoid
4916 gcc -Wbad-function-cast warning.
112396d6 4917 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4918 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4919 (Fmake_variable_buffer_local, Fmake_local_variable):
4920 Mark variables as initialized.
52746918 4921 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4922
e5aab7e7 4923 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4924 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4925 Rename locals to avoid shadowing.
dff45157
PE
4926 (mark_stack): Move local variables into the #ifdef region where
4927 they're used.
7bc26fdb
PE
4928 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4929 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4930 needed otherwise.
4931 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4932 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4933 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4934
e5aab7e7
PE
4935 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4936 avoids undefined behavior in theory.
4937
4da60324
PE
4938 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4939
88043301
PE
4940 Use functions, not macros, for up- and down-casing (Bug#8254).
4941 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4942 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4943 to use the following functions instead of these macros.
4944 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4945 EMACS_INT, since callers assume the returned value fits in int.
4946 (upcase1): Likewise, for UPCASE_TABLE.
4947 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4948 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4949 the race-condition problem in the old DOWNCASE.
88043301 4950
19ed5445
PE
4951 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4952 Rename locals to avoid shadowing.
4953 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4954 (regex_compile, re_search_2, re_match_2_internal):
4955 Remove unused local vars.
952db0d7
PE
4956 (FREE_VAR): Rewrite so as not to use empty "else",
4957 which gcc can warn about.
da053e48 4958 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4959 (RETALLOC_IF): Define only if needed.
4960 (WORDCHAR_P): Likewise. This one is never needed, but is used
4961 only in a comment talking about a compiler bug, so put inside
4962 the #if 0 of that comment.
4963 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4964 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4965 Remove; unused.
19ed5445 4966
1f3561e4 4967 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4968 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4969 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4970
ded6f8f7
PE
4971 * search.c (simple_search): Remove unused var.
4972
dbd37a95
PE
4973 * dired.c (compile_pattern): Move decl from here ...
4974 * lisp.h: ... to here, so that it can be checked.
4975 (struct re_registers): New forward decl.
4976
7e47afad
PE
4977 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4978
85f24f61
PE
4979 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4980 All uses changed.
4981 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4982 Rename locals to avoid shadowing.
5671df8f 4983 (Fvertical_motion): Mark locals as initialized.
85f24f61 4984
181aa2be 4985 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4986 (casify_region): Mark local as initialized.
181aa2be 4987
930d429c
PE
4988 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4989
7082eac6
PE
4990 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4991 New macros, so that the caller can use some names other than
4992 gcpro1, gcpro2, etc.
4993 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4994 of the new macros.
4995 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4996 argument, for consistency with GCPRO2_VAR, etc: it is now the
4997 prefix of the variable, not the variable itself. All uses
4998 changed.
38b2c076
PE
4999 * dired.c (directory_files_internal, file_name_completion):
5000 Rename locals to avoid shadowing.
5001
15206ed9
PE
5002 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5003 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5004 dired.c's scmp function, had undefined behavior.
5005 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5006 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5007 * buffer.h: ... to here, because these macros use current_buffer,
5008 and the new implementation with inline functions needs to have
5009 current_buffer in scope now, rather than later when the macros
5010 are used.
5011 (downcase, upcase1): New static inline functions.
5012 (DOWNCASE, UPCASE1): Reimplement using these functions.
5013 This avoids undefined behavior in expressions like
5014 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5015 from race conditions in accessing the global variables
5016 case_temp1 and case_temp2.
5017 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5018 * lisp.h (case_temp1, case_temp2): Remove their decls.
5019 * character.h (ASCII_CHAR_P): Move from here ...
5020 * lisp.h: ... to here, so that the inline functions mentioned
5021 above can use them.
5022
4a6bea26
PE
5023 * dired.c (directory_files_internal_unwind): Now static.
5024
f14b7e14
PE
5025 * fileio.c (file_name_as_directory, directory_file_name):
5026 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5027 Now static.
2893f146
PE
5028 (file_name_as_directory): Use const pointers when appropriate.
5029 (Fexpand_file_name): Likewise. In particular, newdir might
5030 point at constant storage, so make it a const pointer.
fd4ead52 5031 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5032 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5033 signedness issues.
f839df0c
PE
5034 (Fset_file_times, Finsert_file_contents, auto_save_error):
5035 Rename locals to avoid shadowing.
f14b7e14 5036
5716756e 5037 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5038 (Ftry_completion, Fall_completions): Rename or remove locals
5039 to avoid shadowing.
5716756e 5040
b4c3046a
PE
5041 * marker.c (bytepos_to_charpos): Remove; unused.
5042
b45db522
PE
5043 * lisp.h (verify_bytepos, count_markers): New decls,
5044 so that gcc does not warn that these functions aren't declared.
5045
85876d07
PE
5046 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5047 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5048 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5049 (copy_text): Remove unused local var.
85876d07 5050
03d78a21 5051 * filelock.c (within_one_second): Now static.
b3dd38ab 5052 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5053
5df8f01b
PE
5054 * buffer.c (fix_overlays_before): Mark locals as initialized.
5055 (fix_start_end_in_overlays): Likewise. This function should be
5056 simplified by using pointers-to-pointers, but that's a different
5057 matter.
b1d876f1 5058 (switch_to_buffer_1): Now static.
8f54f30a
PE
5059 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5060 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5061
a70072c9 5062 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5063 Fix pointer signedness issue.
edced198
PE
5064 (sys_subshell): Mark local as volatile if checking for lint,
5065 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5066 (MAXPATHLEN): Define only if needed.
a70072c9 5067
a0977c44
PE
5068 * process.c (serial_open, serial_configure): Move decls from here ...
5069 * systty.h: ... to here, so that they can be checked.
5070
a884fdcc
PE
5071 * fns.c (get_random, seed_random): Move extern decls from here ...
5072 * lisp.h: ... to here, so that they can be checked.
5073
604efe86 5074 * sysdep.c (reset_io): Now static.
b8950c94 5075 (wait_for_termination_signal): Remove; unused.
604efe86 5076
38fc62d9
PE
5077 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5078 (copy_keymap_item, append_key, push_text_char_description):
5079 Now static.
1004a21a 5080 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5081 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5082 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5083 (describe_map_tree):
5084 Rename locals to avoid shadowing.
38fc62d9 5085
2f2650da
PE
5086 * keyboard.c: Declare functions static if they are not used elsewhere.
5087 (echo_char, echo_dash, cmd_error, top_level_2):
5088 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5089 (read_char, kbd_buffer_get_event, make_lispy_position):
5090 (make_lispy_event, make_lispy_movement, apply_modifiers):
5091 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5092 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5093 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5094 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5095 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5096
a053e86c 5097 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5098 (mark_kboards): Move decl here ...
5099 * alloc.c (mark_kboards): ... from here.
a053e86c 5100
4752793e
PE
5101 * lisp.h (force_auto_save_soon): New decl.
5102
74f10ca7 5103 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5104 (DEFINE_DUMMY_FUNCTION): New macro.
5105 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5106 Use it.
c03cd23f
PE
5107 (main): Add casts to avoid warnings
5108 if GCC considers string literals to be constants.
74f10ca7 5109
022e70d4
PE
5110 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5111
59d6fe83
PE
5112 * dbusbind.c: Pointer signedness fixes.
5113 (xd_signature, xd_append_arg, xd_initialize):
5114 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5115 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5116 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5117 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5118
78320123
PE
5119 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5120 if GCC considers string literals to be constants.
49cebcca 5121 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5122
35ac2a97
SM
51232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5124
fb103ca9
SM
5125 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5126 (print_preprocess, print_object): New macro to fix last change.
5127
35ac2a97
SM
5128 * print.c (print_preprocess): Don't forget font objects.
5129
62973b41
JB
51302011-03-16 Juanma Barranquero <lekktu@gmail.com>
5131
5132 * emacs.c (USAGE3): Doc fixes.
5133
0e48bb22
AS
51342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5135
5136 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5137 structure.
5138
7684e57b
JB
51392011-03-14 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * lisp.h (VWindow_system, Qfile_name_history):
5142 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5143 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5144 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5145
5146 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5147 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5148
5149 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5150 * w32console.c (detect_input_pending, read_input_pending)
5151 (encode_terminal_code):
5152 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5153 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5154 (w32_system_caret_y, Qfile_name_history):
5155 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5156 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5157 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5158 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5159 * w32proc.c (Qlocal, report_file_error):
5160 * w32term.c (Vwindow_system, updating_frame):
5161 * w32uniscribe.c (initialized, uniscribe_font_driver):
5162 Remove unneeded extern declarations.
5163
2aa46d6c
CY
51642011-03-14 Chong Yidong <cyd@stupidchicken.com>
5165
c96bbc66 5166 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5167
cffc6f3b
CY
51682011-03-13 Chong Yidong <cyd@stupidchicken.com>
5169
5170 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5171 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5172 These macros can no longer be used for assignment.
5173
44f230aa
SM
5174 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5175 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5176 (record_buffer_markers, fetch_buffer_markers): New functions for
5177 recording and fetching special buffer markers.
5178 (set_buffer_internal_1, set_buffer_temp): Use them.
5179
5180 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5181
5182 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5183
5184 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5185 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5186
5187 * xdisp.c (hscroll_window_tree):
5188 (reconsider_clip_changes): Use PT instead of BUF_PT.
5189
d251f04b
EZ
51902011-03-13 Eli Zaretskii <eliz@gnu.org>
5191
5192 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5193 $(EMACS_ROOT)/lib/intprops.h.
5194
f0c77cd1
PE
51952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5196
3eca4629
PE
5197 Fix more problems found by GCC 4.5.2's static checks.
5198
7c86ee98
PE
5199 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5200 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5201 (xg_free_frame_widgets): Make it clear that a local variable is
5202 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5203 (gdk_window_get_screen): Make it clear that this macro is needed
5204 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5205 (int_gtk_range_get_value): New function, which avoids a diagnostic
5206 from gcc -Wbad-function-cast.
5207 (xg_set_toolkit_scroll_bar_thumb): Use it.
5208 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5209 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5210 (get_utf8_string, xg_get_file_with_chooser):
5211 Rename locals to avoid shadowing.
5212 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5213
41729b81
PE
5214 * xgselect.c (xg_select): Remove unused var.
5215
f0c77cd1
PE
5216 * image.c (four_corners_best): Mark locals as initialized.
5217 (gif_load): Initialize transparent_p to zero (Bug#8238).
5218 Mark another local as initialized.
ec6cf4c6 5219 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5220
ce0ad53d 5221 * image.c (clear_image_cache): Now static.
d5d5a617 5222 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5223 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5224 (x_edge_detection): Remove unnecessary cast that
5225 gcc -Wbad-function-cast diagnoses.
2037898d 5226 (gif_load): Fix pointer signedness.
6ae141d6
PE
5227 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5228 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5229
33383987 52302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5231
d32df629
PE
5232 Improve quality of tests for time stamp overflow.
5233 For example, without this patch (encode-time 0 0 0 1 1
5234 1152921504606846976) returns the obviously-bogus value (-948597
5235 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5236 reports time overflow. See
5237 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5238 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5239 * editfns.c: Include limits.h and intprops.h.
5240 (TIME_T_MIN, TIME_T_MAX): New macros.
5241 (time_overflow): Move earlier, to before first use.
5242 (hi_time, lo_time): New functions, for an accurate test for
5243 out-of-range times.
5244 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5245 (Fget_internal_run_time): Don't assume time_t fits in int.
5246 (make_time): Use list2 instead of Fcons twice.
5247 (Fdecode_time): More accurate test for out-of-range times.
5248 (check_tm_member): New function.
5249 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5250 (lisp_time_argument): Don't rely on undefined left-shift and
5251 right-shift behavior when checking for time stamp overflow.
8be6f318 5252
fe31d94c
PE
5253 * editfns.c (time_overflow): New function, refactoring common code.
5254 (Fformat_time_string, Fdecode_time, Fencode_time):
5255 (Fcurrent_time_string): Use it.
5256
8be6f318
PE
5257 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5258 * dired.c (make_time): Move to ...
5259 * editfns.c (make_time): ... here.
5260 * systime.h: Note the move.
5261
09d9db2c 52622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5263
126bc0dc
YM
5264 * fringe.c (update_window_fringes): Remove unused variables.
5265
c47cbdfd
YM
5266 * unexmacosx.c (copy_data_segment): Also copy __got section.
5267 (Bug#8223)
5268
7ac80be9
EZ
52692011-03-12 Eli Zaretskii <eliz@gnu.org>
5270
c96bbc66 5271 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5272 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5273 Constify `char *' arguments and their references according to
5274 prototypes in tparam.h.
5275
ecb0f94d 5276 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5277
7ac80be9
EZ
5278 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5279 Adapt all references accordingly.
5280
5281 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5282
ef1fd07e
TT
52832011-03-11 Tom Tromey <tromey@redhat.com>
5284
5285 * buffer.c (syms_of_buffer): Remove obsolete comment.
5286
7ef4b50c
EZ
52872011-03-11 Eli Zaretskii <eliz@gnu.org>
5288
5289 * termhooks.h (encode_terminal_code): Declare prototype.
5290
5291 * msdos.c (encode_terminal_code): Don't declare prototype.
5292
5293 * term.c (encode_terminal_code): Now external again, used by
5294 w32console.c and msdos.c.
5295
44f230aa
SM
5296 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5297 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5298
4b1ec863 52992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5300
1714f52b 5301 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5302
4b1ec863
PE
5303 * fringe.c (update_window_fringes): Mark locals as initialized
5304 (Bug#8227).
5305 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5306
524c7aa6
PE
5307 * alloc.c (mark_fringe_data): Move decl from here ...
5308 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5309 to check its interface.
5310 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5311
a5c0af81 5312 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5313 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5314 (fontset_font): Mark local as initialized.
a9a06e0b 5315 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5316
b4716021
PE
5317 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5318
811e9bac 5319 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5320 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5321 (x_own_selection, Fx_disown_selection_internal): Rename locals
5322 to avoid shadowing.
5323 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5324
7e3ab302
PE
5325 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5326 so that the caller can use some name other than gcpro1.
5327 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5328 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5329 (Fx_backspace_delete_keys_p):
5330 Use them to avoid shadowing, and rename vars to avoid shadowing.
5331 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5332 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5333 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5334 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5335 Remove unused locals.
7e3ab302
PE
5336 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5337 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5338 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5339 macros.
f78faa98 5340
e2b13473
PE
5341 * xterm.h (x_mouse_leave): New decl.
5342
77f23912
PE
5343 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5344 Remove unused functions.
cdf4ba58
PE
5345 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5346 (x_calc_absolute_position): Now static.
7411c686 5347 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5348 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5349 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5350 unless they are used.
38d0b34a
PE
5351 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5352 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5353 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5354 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5355 (x_error_catcher, x_connection_closed, x_error_handler):
5356 (x_error_quitter, xembed_send_message, x_iconify_frame):
5357 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5358 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5359 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5360
44f230aa
SM
5361 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5362 Rename or move locals to avoid shadowing.
6b463e58 5363 (tty_defined_color, merge_face_heights): Now static.
5967d051 5364 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5365 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5366 does not deduce is never used uninitialized.
73719eba
PE
5367 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5368 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5369
426994c3 5370 * terminal.c (store_terminal_param): Now static.
5489860b 5371
032f1620 5372 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5373 (set_frame_menubar): Remove unused local.
d4323972 5374 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5375 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5376 since they might point to immutable storage.
281585b0
PE
5377 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5378 since it's unused otherwise.
032f1620 5379
367c19e5 5380 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5381 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5382 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5383 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5384 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5385 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5386 does not deduce are never used uninitialized.
70739cbe 5387
07b48fa9
PE
5388 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5389
8868a238 5390 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5391 * window.c (window_loop, size_window):
5392 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5393
7e5cf297 5394 * window.c (display_buffer): Now static.
d6550a9f
PE
5395 (size_window): Mark variables that gcc -Wuninitialized
5396 does not deduce are never used uninitialized.
a586633d
PE
5397 * window.h (check_all_windows): New decl, to forestall
5398 gcc -Wmissing-prototypes diagnostic.
5b555da1 5399 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5400
f6095868
PE
5401 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5402 shadowing.
5403 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5404 Include <limits.h>.
5405 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5406 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5407 (load_charset_map): Mark variables that gcc -Wuninitialized
5408 does not deduce are never used uninitialized.
53df7c11 5409 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5410
f38b440c
PE
5411 * coding.c (coding_set_source, coding_set_destination):
5412 Use "else { /* comment */ }" rather than "else /* comment */;"
5413 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5414 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5415 a block, when the outer 'i' will do.
5416 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5417 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5418 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5419 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5420 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5421 Rename locals to avoid shadowing.
5422 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5423 * coding.c (emacs_mule_char, encode_invocation_designation):
5424 Now static, since they're not used elsewhere.
413bb2db 5425 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5426 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5427 (decode_coding_emacs_mule): Mark variables that gcc
5428 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5429 (detect_coding_iso_2022): Initialize a local variable that might
5430 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5431 this initialization is needed. (Bug#8211)
5f58e762
PE
5432 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5433 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5434 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5435 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5436 Remove unused macros.
f38b440c 5437
232b38b9 5438 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5439 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5440 * character.c (string_count_byte8): Likewise.
232b38b9 5441
fb90da1b
PE
5442 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5443 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5444
fb93dbc2
PE
5445 * chartab.c (copy_sub_char_table): Now static, since it's not used
5446 elsewhere.
5c156ace
PE
5447 (sub_char_table_ref_and_range, char_table_ref_and_range):
5448 Rename locals to avoid shadowing.
bbcd0949 5449 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5450
7d3b3862 5451 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5452 (BIDI_BOB): Remove unused macro.
7d3b3862 5453
6be7d3da
PE
5454 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5455 deduce are never used uninitialized.
c2ed9c8b 5456 * term.c (encode_terminal_code): Likewise.
6be7d3da 5457
75f8807f 5458 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5459
50938595
PE
5460 * tparam.h: New file.
5461 * term.c, tparam.h: Include it.
5462 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5463 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5464 Move these decls to tparam.h, and make them agree with what
5465 is actually in tparam.c. The previous trick of using incompatible
5466 decls in different modules does not conform to the C standard.
5467 All callers of tparam changed to use tparam's actual API.
5468 * tparam.c (tparam1, tparam, tgoto):
5469 Use const pointers where appropriate.
5470
fbceeba2
PE
5471 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5472 * cm.h (struct cm): Likewise.
5473 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5474 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5475 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5476 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5477 (turn_on_face, init_tty): Likewise.
5478 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5479
7f3f1250
PE
5480 * term.c (term_mouse_position): Rename local to avoid shadowing.
5481
e6ca6543
PE
5482 * alloc.c (mark_ttys): Move decl from here ...
5483 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5484
c40f8d15
AS
54852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5486
5487 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5488
cfe0661d
JB
54892011-03-09 Juanma Barranquero <lekktu@gmail.com>
5490
5491 * search.c (compile_pattern_1): Remove argument regp, unused since
5492 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5493 (compile_pattern): Don't pass it.
5494
0afb4571
J
54952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5496
5497 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5498 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5499 for ! HAVE_GTK3.
5500 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5501
5502 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5503
5504 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5505 gdk_window_get_screen, gdk_window_get_geometry,
5506 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5507 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5508 (xg_get_pixbuf_from_pixmap): New function.
5509 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5510 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5511 Call xg_get_pixbuf_from_pixmap instead of
5512 gdk_pixbuf_get_from_drawable.
5513 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5514 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5515 (xg_check_special_colors): Use GtkStyleContext and its functions
5516 for HAVE_GTK3.
5517 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5518 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5519 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5520 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5521 Call gtk_widget_get_preferred_size.
0afb4571
J
5522 (xg_frame_resized): gdk_window_get_geometry only takes 5
5523 parameters.
44f230aa
SM
5524 (xg_win_to_widget, xg_event_is_for_menubar):
5525 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5526 (xg_set_widget_bg): New function.
5527 (delete_cb): New function.
895009e1 5528 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5529 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5530 (xg_set_background_color): Call xg_set_widget_bg.
5531 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5532 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5533 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5534 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5535 if ! HAVE_GTK3.
5536 (update_frame_tool_bar): Call gtk_widget_hide.
5537 (xg_initialize): Use GDK_KEY_g.
5538
5539 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5540 if ! HAVE_GTK3
5541 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5542
5543 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5544 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5545 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5546
1c2cc4ef
JB
55472011-03-08 Juanma Barranquero <lekktu@gmail.com>
5548
5549 * w32xfns.c (select_palette): Check success of RealizePalette against
5550 GDI_ERROR, not zero.
5551
33383987 5552See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5553
5554;; Local Variables:
5555;; coding: utf-8
aac0c6e3
MR
5556;; End:
5557
33383987 5558 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5559
5560 This file is part of GNU Emacs.
5561
5562 GNU Emacs is free software: you can redistribute it and/or modify
5563 it under the terms of the GNU General Public License as published by
5564 the Free Software Foundation, either version 3 of the License, or
5565 (at your option) any later version.
5566
5567 GNU Emacs is distributed in the hope that it will be useful,
5568 but WITHOUT ANY WARRANTY; without even the implied warranty of
5569 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5570 GNU General Public License for more details.
5571
5572 You should have received a copy of the GNU General Public License
5573 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.