Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ea814a5d
EZ
12012-07-13 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4 cursor overflow into the last glyph on display line when the right
5 fringe is off. (Bug#11832)
6
1a952767
PE
72012-07-13 Paul Eggert <eggert@cs.ucla.edu>
8
9 * xdisp.c (produce_special_glyphs): Now static.
10 * dispextern.h (produce_special_glyphs): Remove decl.
11
983188fd
GM
122012-07-13 Glenn Morris <rgm@gnu.org>
13
32fb4bb6
GM
14 * s/bsd-common, s/cygwin.h: Remove empty files.
15 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
16
983188fd
GM
17 * s/usg5-4-common.h (USG, USG5):
18 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
19 * s/sol2-6.h (SOLARIS2):
20 * s/irix6-5.h (IRIX6_5):
21 * s/hpux10-20.h (USG, USG5, HPUX):
22 * s/gnu-linux.h (USG, GNU_LINUX):
23 * s/freebsd.h (BSD_SYSTEM):
24 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
25 * s/cygwin.h (CYGWIN):
26 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
27 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
28
d1e68667 292012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
30
31 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 32
6de0e799
GM
332012-07-13 Glenn Morris <rgm@gnu.org>
34
739ae010
GM
35 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
36
dbee5793
GM
37 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
38
6de0e799
GM
39 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
40 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
41
b82da769
GM
422012-07-12 Glenn Morris <rgm@gnu.org>
43
4fae5a7a 44 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
45
46 * process.c (init_process_emacs): Rename from init_process.
47 The old name is also the name of a Mach system call.
48 * lisp.h, emacs.c: Update for this name change.
49 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
50 longer needed.
51
5a979817
EZ
522012-07-12 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
55 memmove call that removes glyphs covered by the left truncation
56 glyph. Improve commentary.
57 (display_line): Fix display of continuation glyphs on GUI frames
58 when the right fringe is turned off and variable-size fonts are
59 used in the window. Move the code that appends a stretch glyph to
60 produce_special_glyphs, so that it could be used for truncation
61 and continuation glyphs alike.
62 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
63 glyph of a suitably computed width, to align the special glyphs at
64 the window margin. Code moved from display_line. (Bug#11832)
65
3e91a053
GM
662012-07-12 Glenn Morris <rgm@gnu.org>
67
ba9e4b84
GM
68 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
69
70 * s/gnu-linux.h, s/hpux10-20.h:
71 Do not unconditionally define HAVE_XRMSETDATABASE.
72
3e91a053
GM
73 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
74
b300b1f4
PE
752012-07-12 Paul Eggert <eggert@cs.ucla.edu>
76
77 Fix typos that broke OS X build.
78 Reported by Randal L. Schwartz in
79 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
80 * nsterm.m (ns_timeout): Add missing local decl.
81 (ns_get_color): snprintf -> sprintf, to fix typo.
82
6e777848
GM
832012-07-12 Glenn Morris <rgm@gnu.org>
84
3f922c37
GM
85 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
86 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
87 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
88 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
89
0ab7b23a
GM
90 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
91 Move PTY_OPEN to configure.
92
6e777848
GM
93 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
94 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
95 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
96
4a7edc24
DA
972012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
98
99 Use empty_unibyte_string where applicable.
100 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
101 * lread.c (read1): Likewise.
102 * xsettings.c (syms_of_xsettings): Likewise.
103
308aab79
GM
1042012-07-12 Glenn Morris <rgm@gnu.org>
105
42bd1719
GM
106 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
107 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
108 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
109 * s/hpux10-20.h (RUN_TIME_REMAP):
110 * s/bsd-common.h (TABDLY): Move to configure.
111
112 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
113
114 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
115
ea0bbd17 116 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 117 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
118
119 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 120
308aab79
GM
121 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
122 * s/template.h: Move NARROWPROTO to configure.
123
ee1cf5cf
GM
1242012-07-11 Glenn Morris <rgm@gnu.org>
125
30fe9bf4
GM
126 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
127 unused since 2011-01-17 change to systty.h.
128
ee1cf5cf
GM
129 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
130 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
131 Move HAVE_PTYS and HAVE_SOCKETS to configure.
132
63e47e07
PE
1332012-07-11 Paul Eggert <eggert@cs.ucla.edu>
134
135 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
136
c43fb4c3
GM
1372012-07-11 Glenn Morris <rgm@gnu.org>
138
139 * s/darwin.h, s/gnu-linux.h, s/template.h:
140 Move INTERRUPT_INPUT to configure.
141
e8df9267
DA
1422012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
143
144 Minor adjustments to interning code.
145 * lisp.h (intern, intern_c_string): Redefine as static inline
146 wrappers for intern_1 and intern_c_string_1, respectively.
147 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
148 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
149 Vobarray checking.
e8df9267
DA
150 * font.c (font_intern_prop): Likewise. Adjust comment.
151 * w32font.c (intern_font_name): Likewise.
152
34348bd4
AS
1532012-07-11 Andreas Schwab <schwab@linux-m68k.org>
154
d96a1e0c
AS
155 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
156
34348bd4
AS
157 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
158 of Fcar/Fcdr if possible.
159 * font.c (check_otf_features): Likewise.
160 * fontset.c (Fnew_fontset): Likewise.
161 * gnutls.c (Fgnutls_boot): Likewise.
162 * minibuf.c (read_minibuf): Likewise.
163 * msdos.c (IT_set_frame_parameters): Likewise.
164 * xmenu.c (Fx_popup_dialog): Likewise.
165 * w32menu.c (Fx_popup_dialog): Likewise.
166
c8add24e
GM
1672012-07-11 Glenn Morris <rgm@gnu.org>
168
4b575b3c
GM
169 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
170 since nothing has defined it on these platforms.
171
09f4e3b0
GM
172 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
173 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
174
172bedef
GM
175 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
176 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
177 Move CLASH_DETECTION to configure.
178
249685df
GM
179 * s/gnu.h: Remove file, which is now empty.
180
c8add24e
GM
181 * s/gnu.h, s/gnu-linux.h:
182 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
183
b41253a3
JW
1842012-07-11 John Wiegley <johnw@newartisans.com>
185
186 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
187 function attribute, so we only use it if it exists in the
188 compiler.
189
d923b542
DA
1902012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
191
192 Avoid call to strlen in fast_c_string_match_ignore_case.
193 * search.c (fast_c_string_match_ignore_case): Change to use
194 length argument. Adjust users accordingly.
195 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
196
5ebbef1d
PE
1972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
198
bb352260
PE
199 Assume mkdir, rmdir.
200 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
201 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
202
57054ddd
PE
203 Assume rename.
204 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
205
b747d3f7
PE
206 Assume perror.
207 * s/hpux10-20.h (HAVE_PERROR): Remove.
208 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
209 Remove dummy definition, as this problem was obsolete long ago.
210
5ebbef1d
PE
211 Assume strerror.
212 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
213
984e7f30
DA
2142012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Avoid calls to strlen in font processing functions.
217 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 218 (font_open_by_name): Change to use length argument. Adjust
984e7f30 219 users accordingly.
d923b542
DA
220 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
221 Adjust prototypes.
222 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
223 Change to return ptrdiff_t.
984e7f30
DA
224 (xfont_list_pattern, xfont_match): Use length returned by
225 xfont_decode_coding_xlfd.
226 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
227
20e94fdd
GM
2282012-07-11 Glenn Morris <rgm@gnu.org>
229
9d596af3
GM
230 * s/darwin.h, s/freebsd.h, s/netbsd.h:
231 Move DONT_REOPEN_PTY to configure.
232
20e94fdd
GM
233 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
234 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
235
e99a530f
PE
2362012-07-10 Paul Eggert <eggert@cs.ucla.edu>
237
22ffb973
PE
238 Remove "#define unix" that is no longer needed (Bug#11905).
239 * s/aix4-2.h (unix): Remove; no longer needed.
240
e9a9ae03
PE
241 EMACS_TIME simplification (Bug#11875).
242 This replaces macros (which typically do not work in GDB)
243 with functions, typedefs and enums, making the code easier to debug.
244 The functional style also makes code easier to read and maintain.
245 * systime.h: Include <sys/time.h> on all hosts, not just if
246 WINDOWSNT, since 'struct timeval' is needed in general.
247 (EMACS_TIME): Now a typedef, not a macro.
248 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
249 not macros.
250 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
251 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
252 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
253 (EMACS_TIME_LE): Now functions, not macros.
254 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
255 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
256 which are not functions. All uses rewritten to use:
257 (make_emacs_time): New function.
258 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
259 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
260 not functions. All uses rewritten to use the following, respectively:
261 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
262 (add_emacs_time, sub_emacs_time): New functions.
263 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
264 * fileio.c (Fcopy_file):
265 * xterm.c (XTflash): Get the current time closer to when it's used.
266 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
267
ffacb126
PE
268 * bytecode.c (targets): Suppress -Woverride-init warnings.
269
e99a530f
PE
270 Simplify by avoiding confusing use of strncpy etc.
271 * doc.c (Fsnarf_documentation):
272 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
273 * frame.c (Fmake_terminal_frame):
274 * gtkutil.c (get_utf8_string):
275 * lread.c (openp):
276 * nsmenu.m (ns_update_menubar):
277 * regex.c (regerror):
278 Prefer memcpy to strncpy and strncat when either will do.
279 * fileio.c (Fsubstitute_in_file_name):
280 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
281 (menu_separator_name_p):
282 * nsmenu.m (ns_update_menubar):
283 Prefer memcmp to strncmp when either will do.
284 * nsterm.m: Include <ftoastr.h>.
285 (ns_get_color):
286 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
287 Prefer snprintf to strncpy.
288 * nsterm.m (ns_term_init):
289 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
290 * nsterm.m (ns_term_init):
291 Avoid the need for strncpy, by using build_string or
292 make_unibyte_string directly. Use dtoastr, not snprintf.
293 * process.c (Fmake_network_process): Diagnose service names that
294 are too long, rather than silently truncating them or creating
295 non-null-terminated names.
296 (Fnetwork_interface_info): Likewise, for interface names.
297 * sysdep.c (system_process_attributes) [GNU_LINUX]:
298 Prefer sprintf to strncat.
299 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
300 Prefer vsnprintf to vsprintf + strncpy.
301
c59592b3
GM
3022012-07-10 Glenn Morris <rgm@gnu.org>
303
304 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
305 Clarify fallback case.
306
7d7bbefd
DA
3072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
308
309 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
310 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
311 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 312 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
313 where argument type is known to be a Lisp_Cons.
314
3a4c8000
TT
3152012-07-10 Tom Tromey <tromey@redhat.com>
316
317 * bytecode.c (BYTE_CODE_THREADED): New macro.
318 (BYTE_CODES): New macro. Replaces all old byte-code defines.
319 (enum byte_code_op): New type.
320 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
321 (exec_byte_code): Use them. Use token threading when applicable.
322
2a0213a6
DA
3232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
324
325 Optimize pure C strings initialization.
326 * lisp.h (make_pure_string): Fix prototype.
327 (build_pure_c_string): New function, defined as static inline. This
328 provides a better opportunity to optimize away calls to strlen when
329 the function is called with compile-time constant argument.
330 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
331 argument, adjust users accordingly. Use build_pure_c_string where
332 appropriate.
333 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
334 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
335 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
336
cb1caeaf
DA
3372012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
338
339 Avoid calls to strlen in miscellaneous functions.
340 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
341 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
342 * lread.c (openp): Likewise.
343
c293e30c
DA
3442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Avoid calls to strlen in path processing functions.
347 * fileio.c (file_name_as_directory): Add comment. Change to add
348 srclen argument and return the length of result. Adjust users
349 accordingly.
350 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 351 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
352 users accordingly.
353 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
354
9e059e3f
GM
3552012-07-10 Glenn Morris <rgm@gnu.org>
356
d02eb359
GM
357 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
358 Move PENDING_OUTPUT_COUNT definition to configure.
359
882cf227
GM
360 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
361 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
362 * s/gnu.h (DATA_START): Move definitions to configure.
363
af6e839f
GM
364 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
365 We include usg5-4-common.h, which defines them both.
366
40289a12
GM
367 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
368 O_RDONLY already includes it).
369
9e059e3f
GM
370 Stop ns builds setting the EMACSLOADPATH environment variable.
371 * nsterm.m (ns_load_path): Rename from ns_init_paths.
372 Now it does not set EMACSLOADPATH, just returns the load-path string.
373 * nsterm.h: Update accordingly.
374 * lread.c [HAVE_NS]: Include nsterm.h.
375 (init_lread) [HAVE_NS]: Use ns_load_path.
376 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
377
7c4e8ec0
GM
3782012-07-09 Glenn Morris <rgm@gnu.org>
379
d4f600ff
GM
380 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
381 since the included bsd-common.h does so.
382
cbb31951
GM
383 Stop ns builds setting the EMACSPATH environment variable.
384 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
385 (ns_init_paths): Do not set EMACSPATH.
386 * nsterm.h (ns_exec_path): Add it.
387 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
388 Use ns_exec_path.
389
7c4e8ec0
GM
390 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
391
26bccfae
PE
3922012-07-09 Paul Eggert <eggert@cs.ucla.edu>
393
a0bee46f
PE
394 * process.c (wait_reading_process_output): 'waitchannels' was unset
395 when read_kbd || !NILP (wait_for_cell); fix this.
396
5994c183
PE
397 Add GCC-style 'const' attribute to functions that can use it.
398 * character.h (char_resolve_modifier_mask):
399 * keyboard.h (make_ctrl_char):
400 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
401 (init_character_once, next_almost_prime, init_fns, init_image)
402 (flush_pending_output, init_sound):
403 * mem-limits.h (start_of_data):
404 * menu.h (finish_menu_items):
405 Add ATTRIBUTE_CONST.
406 * emacs.c (DEFINE_DUMMY_FUNCTION):
407 Declare the dummy function with ATTRIBUTE_CONST.
408 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
409 Add decls with ATTRIBUTE_CONST.
410
26bccfae
PE
411 Minor improvements to make_formatted_string.
412 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
413 where int is good enough, as vsprintf returns an int.
414 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
415
a8290ec3
DA
4162012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Use make_formatted_string to avoid double length calculation.
419 * lisp.h (make_formatted_string): New prototype.
420 * alloc.c (make_formatted_string): New function.
421 * buffer.c (Fgenerate_new_buffer_name): Use it.
422 * dbus.c (syms_of_dbusbind): Likewise.
423 * editfns.c (Fcurrent_time_zone): Likewise.
424 * filelock.c (get_boot_time): Likewise.
425 * frame.c (make_terminal_frame, set_term_frame_name)
426 (x_report_frame_params): Likewise.
427 * image.c (gs_load): Likewise.
428 * minibuf.c (get_minibuffer): Likewise.
429 * msdos.c (dos_set_window_size): Likewise.
430 * process.c (make_process): Likewise.
431 * xdisp.c (ensure_echo_area_buffers): Likewise.
432 * xsettings.c (apply_xft_settings): Likewise.
433
d01ba2f1
GM
4342012-07-09 Glenn Morris <rgm@gnu.org>
435
436 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
437 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
438 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
439 * nsterm.h (ns_etc_directory): Add it.
440 * callproc.c [HAVE_NS]: Include nsterm.h.
441 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
442
f1f924b6
DA
4432012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
444
445 Move marker debugging code under MARKER_DEBUG.
446 * marker.c (MARKER_DEBUG): Move marker debugging code under
447 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
448 for bootstrap with --enable-checking (~3x slowdown reported
449 by Juanma Barranquero <lekktu@gmail.com>).
450 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
451
ab531b66
PE
4522012-07-08 Paul Eggert <eggert@cs.ucla.edu>
453
454 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
455 See <http://bugs.gnu.org/11825#29>.
456
c4b3bc8a
EZ
4572012-07-08 Eli Zaretskii <eliz@gnu.org>
458
459 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
460 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
461 (display_line): Add commentary about displaying truncation glyphs
462 on GUI frames.
463 (produce_special_glyphs): Move here from term.c.
464
465 * term.c (produce_special_glyphs): Move to xdisp.c.
466
467 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
468 section.
c4b3bc8a 469
b676b881
AS
4702012-07-07 Andreas Schwab <schwab@linux-m68k.org>
471
f17c5273
AS
472 * xdisp.c (display_line): Avoid warning about implicit declaration
473 of FRAME_FONT.
474
298819b9
AS
475 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
476
b676b881
AS
477 * lisp.h: Remove empty conditional.
478
6045c4fd
PE
4792012-07-07 Paul Eggert <eggert@cs.ucla.edu>
480
b3350bf9
PE
481 * lread.c (load_path_check): Now static.
482
6045c4fd
PE
483 Fix some minor --with-ns problems found by static checking.
484 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
485 (x_set_font) [!HAVE_X_WINDOWS]:
486 * image.c (xpm_load_image) [HAVE_NS]:
487 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
488 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
489 Remove unused local.
490 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
491 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
492 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
493 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
494 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
495 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
496 Fix pointer signedness problem.
497 * xfaces.c (FRAME_X_FONT_TABLE):
498 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
499
929e7845
GM
5002012-07-07 Glenn Morris <rgm@gnu.org>
501
502 * lread.c (load_path_check): New function, split from init_lread.
503 (init_lread): Reorganize. Motivation:
504 If EMACSLOADPATH is set, check/warn about that rather than the
505 defaults, which we are not going to use. Hence we can remove
506 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
507 Don't warn if site-lisp directories are missing.
508 If not installed, start from a blank load-path, since
509 PATH_LOADSEARCH refers to the eventual installation directories.
510
58dd0aa4
EZ
5112012-07-07 Eli Zaretskii <eliz@gnu.org>
512
513 Support truncation and continuation glyphs on GUI frames, when
514 fringes are disabled. (Bug#11832)
515 * xdisp.c (init_iterator): Get dimensions of truncation and
516 continuation glyphs even if on GUI frames. Adjust
517 it->last_visible_x on GUI frames when the left or right fringes,
518 or both, are absent.
519 (start_display, move_it_in_display_line_to): Handle the case of a
520 GUI frame without a fringe to display continuation or truncation
521 glyphs.
522 (insert_left_trunc_glyphs): Support GUI frames: make sure
523 truncation glyphs overwrite enough glyphs from the current line to
524 have sufficient space in pixels.
525 (display_line): Support truncation and continuation glyphs on GUI
526 frames. If some spare pixels are left on the line after inserting
527 the truncation glyphs, fill that space with a stretch glyph of a
528 suitably computed width.
529
530 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
531 produce_glyphs, to support GUI sessions.
532
31571fd7
PE
5332012-07-07 Paul Eggert <eggert@cs.ucla.edu>
534
5a16b9bc
PE
535 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
536
f3047c75
PE
537 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
538
31571fd7
PE
539 Do not require float-time's arg to fit in time_t (Bug#11825).
540 This works better on hosts where time_t is unsigned, and where
541 float-time is applied to the (negative) difference between two times.
542 * editfns.c (decode_time_components): Last arg is now double *,
543 not int *, and means to store all the result as a double, without
544 worrying about whether the seconds part fits in time_t.
545 All callers changed.
546 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
547 All callers changed.
548 (Ffloat_time): Do not fail merely because the specified time falls
549 outside of time_t range.
550
4516fbef
GM
5512012-07-07 Glenn Morris <rgm@gnu.org>
552
553 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
554 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
555 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
556
07adc2c6
JB
5572012-07-07 Juanma Barranquero <lekktu@gmail.com>
558
559 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
560 Update dependencies.
561
562 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
563
fd573f31
PE
5642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
565
fee5959d
PE
566 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
567 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
568 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
569 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
570 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
571 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
572
fd573f31
PE
573 * xfont.c (compare_font_names): Redo to omit the need for casts.
574
ddadbc0e
AS
5752012-07-06 Andreas Schwab <schwab@linux-m68k.org>
576
fca8d6b6
AS
577 * xfns.c (Fx_change_window_property): Doc fix.
578 * w32fns.c (Fx_change_window_property): Doc fix.
579
ddadbc0e
AS
580 * w32fns.c (Fx_window_property): Accept the same arguments as the
581 X Windows version. Doc fix.
582 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
583
f247498e
JB
5842012-07-06 Juanma Barranquero <lekktu@gmail.com>
585 Eli Zaretskii <eliz@gnu.org>
586
587 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
588 Windows-specific code from nt/config.nt moved here.
589 Obsolete settings removed.
590
216ee680
PE
5912012-07-06 Paul Eggert <eggert@cs.ucla.edu>
592
593 * process.c: Avoid unnecessary calls to gettime.
594 (wait_reading_process_output): Don't get the time of day
595 when gobbling data immediately and not waiting, as there's no need
596 for it in that case. This removes a FIXME.
597
bdd091e4
JD
5982012-07-06 Jan Djärv <jan.h.d@swipnet.se>
599
600 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
601 is defined (Bug#11768).
602
9d44f8ce
DA
6032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Fix marker debugging code.
606 * marker.c (byte_char_debug_check): Do not perform the check
607 if buffer is not multibyte.
090bd7cb
JB
608 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
609 Call byte_char_debug_check with correct arguments.
9d44f8ce 610
90fc4786
DA
6112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
612
613 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
614 * marker.c (byte_char_debug_check, count_markers):
615 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
616 (byte_debug_flag): Remove.
617 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
618 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
619
7b7ae965
DA
6202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
621
4e57b342
DA
622 Avoid code repetition in marker-related functions.
623 * marker.c (attach_marker): New function.
624 (Fset_marker, set_marker_restricted, set_marker_both)
625 (set_marker_restricted_both): Use it.
626 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
627 Consistently rename charno to charpos.
628 (marker_position): Add eassert.
629 (marker_byte_position): Convert to eassert.
630
6312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
632
633 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 634 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 635 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 636
657924ff
DA
6372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
638
639 Introduce fast path for the widely used marker operation.
640 * alloc.c (build_marker): New function.
641 * lisp.h (build_marker): New prototype.
642 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
643 * composite.c (autocmp_chars): Likewise.
644 * editfns.c (buildmark): Remove.
645 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
646 (save_restriction_save): Use build_marker.
647 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
648 * window.c (save_window_save): Likewise.
649
041a49a6
DA
6502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
651
652 Do not use Fdelete_overlay in delete_all_overlays
653 to avoid redundant calls to unchain_overlay.
654 * buffer.c (drop_overlay): New function.
655 (delete_all_overlays, Fdelete_overlay): Use it.
656 * minibuf.c (get_minibuffer): Fix comment.
657
7dca65a4
PE
6582012-07-06 Paul Eggert <eggert@cs.ucla.edu>
659
660 Port to OpenBSD 5.1 amd64.
661 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
662 This is needed for OpenBSD, and should be harmless on all BSD systems.
663 Also, include <sys/sysctl.h>, as it should be available on all
664 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
665 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
666 use p_pid member, not kp_proc.pid.
667
8eb876e2
GM
6682012-07-06 Glenn Morris <rgm@gnu.org>
669
670 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
671
38182d90
PE
6722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
673
674 More xmalloc and related cleanup.
675 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
676 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
678 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
679 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
680 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
681 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
682 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
683 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
684 * xterm.c:
685 Omit needless casts involving void * pointers and allocation.
686 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
687 as the former is more robust if P's type is changed.
688 Prefer xzalloc to xmalloc + memset 0.
689 Simplify malloc-or-realloc to realloc.
690 Don't worry about xmalloc returning a null pointer.
691 Prefer xstrdup to xmalloc + strcpy.
692 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
693 growing it.
694 * keyboard.c (apply_modifiers_uncached): Prefer local array to
695 alloca of a constant.
696
6dd5a677
EZ
6972012-07-05 Eli Zaretskii <eliz@gnu.org>
698
699 * xdisp.c (display_line): Fix horizontal pixel coordinates when
700 hscroll is larger than the line width. Fixes long and futile
701 looping inside extend_face_to_end_of_line (on a TTY) producing
702 glyphs that are not needed and thrown away.
703
6b312f0f
DA
7042012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
705
706 * marker.c (set_marker_restricted_both): Simplify by using
707 clip_to_bounds.
708
f520ef9b
PE
7092012-07-05 Paul Eggert <eggert@cs.ucla.edu>
710
711 * editfns.c (region_limit): Simplify by using clip_to_bounds.
712
383b7c95
JD
7132012-07-05 Jan Djärv <jan.h.d@swipnet.se>
714
715 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
716 not defined (Bug#11768).
717 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
718 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
719 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
720 followed by gtk_box_set_homogeneous (Bug#11768).
721 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
722 (update_theme_scrollbar_width, xg_create_scroll_bar):
723 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
724 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
725 (is_box_type): New function (Bug#11768).
726 (xg_tool_item_stale_p): Call is_box_type.
5293d758 727 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
728 with default display (Bug#11768).
729
d6e7bf45
EZ
7302012-07-05 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (window_hscroll_limited): New function.
733 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
734 coordinates when window's hscroll is set to insanely large
735 values. (Bug#11857)
736
431391ec
JB
7372012-07-05 Juanma Barranquero <lekktu@gmail.com>
738
739 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
740 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
741
23f86fce
DA
7422012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
743
744 Cleanup xmalloc.
745 * lisp.h (xzalloc): New prototype. Omit needless casts.
746 * alloc.c (xzalloc): New function. Omit needless casts.
747 * charset.c: Omit needless casts. Convert all calls to
748 xmalloc with following memset to xzalloc.
749 * dispnew.c: Likewise.
750 * fringe.c: Likewise.
751 * image.c: Likewise.
752 * sound.c: Likewise.
753 * term.c: Likewise.
754 * w32fns.c: Likewise.
755 * w32font.c: Likewise.
756 * w32term.c: Likewise.
757 * xfaces.c: Likewise.
758 * xfns.c: Likewise.
759 * xterm.c: Likewise.
760 * atimer.c: Omit needless casts.
761 * buffer.c: Likewise.
762 * callproc.c: Likewise.
763 * ccl.c: Likewise.
764 * coding.c: Likewise.
765 * composite.c: Likewise.
766 * doc.c: Likewise.
767 * doprnt.c: Likewise.
768 * editfns.c: Likewise.
769 * emacs.c: Likewise.
770 * eval.c: Likewise.
771 * filelock.c: Likewise.
772 * fns.c: Likewise.
773 * gtkutil.c: Likewise.
774 * keyboard.c: Likewise.
775 * lisp.h: Likewise.
776 * lread.c: Likewise.
777 * minibuf.c: Likewise.
778 * msdos.c: Likewise.
779 * print.c: Likewise.
780 * process.c: Likewise.
781 * region-cache.c: Likewise.
782 * search.c: Likewise.
783 * sysdep.c: Likewise.
784 * termcap.c: Likewise.
785 * terminal.c: Likewise.
786 * tparam.c: Likewise.
787 * w16select.c: Likewise.
788 * w32.c: Likewise.
789 * w32reg.c: Likewise.
790 * w32select.c: Likewise.
791 * w32uniscribe.c: Likewise.
792 * widget.c: Likewise.
793 * xdisp.c: Likewise.
794 * xmenu.c: Likewise.
795 * xrdb.c: Likewise.
796 * xselect.c: Likewise.
797
0497dc44
PE
7982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
799
800 * fileio.c (time_error_value): Check the right error number.
801 Problem reported by Troels Nielsen in
802 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
803
356e7178
PE
8042012-07-04 Paul Eggert <eggert@cs.ucla.edu>
805
4e71fd89
PE
806 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
807 This should be fixed in a better way; see Eli Zaretskii in
808 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
809 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
810
f0941253
PE
811 * fileio.c (time_error_value): Rename from special_mtime.
812 The old name's problems were noted by Eli Zaretskii in
813 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
814
065c9eb4
PE
815 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
816 This variable's comment says Emacs needs at least one GDB-visible
817 symbol of type enum pvec_type, to work around GDB problems.
818 The symbol's value doesn't matter.
819
356e7178
PE
820 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
821 that causes compilation to fail on pre-C99 compilers.
822
95f61aa2
JB
8232012-07-04 Juanma Barranquero <lekktu@gmail.com>
824
825 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
826 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
827
3884d954
DA
8282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
829
d209e2fb 830 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
831 headers for buffer_defaults and buffer_local_symbols.
832 Reported by Juanma Barranquero <lekktu@gmail.com>.
833
ee28be33
SM
8342012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
835
836 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
837 * lisp.h (enum pvec_type): Use fewer bits.
838 (PSEUDOVECTOR_SIZE_BITS): New constant.
839 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
840 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
841 change in pvec_type.
842 (PSEUDOVECTOR_TYPEP): New macro.
843 (TYPED_PSEUDOVECTORP): Use it.
844 * fns.c (internal_equal): Adapt code to extract pvectype.
845 * emacs.c (gdb_pvec_type): Update type.
846 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
847 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
848 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
849 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
850 (sweep_vectors): Use it. Use local var `total_bytes' instead of
851 abusing vector->header.next.nbytes.
852 (live_vector_p): Use PVEC_TYPE.
853 (mark_object): Adapt code to extract pvectype. Use switch.
854
c7f2cd7f
PE
8552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
856
857 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
858 Tighten new eassert a bit.
859
8ce70ed2
DA
8602012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
861
862 Fix compilation with --enable-gcc-warnings and -O1
863 optimization level.
864 * doprnt.c (doprnt): Change type of tem to int, initialize
865 to avoid compiler warning. Add eassert.
866 * search.c (simple_search): Initialize match_byte to avoid
867 compiler warning. Add eassert.
868
dea7f1e5
PE
8692012-07-04 Paul Eggert <eggert@cs.ucla.edu>
870
24a212eb
PE
871 Avoid weird behavior with large horizontal scrolls.
872 Without this change, for example, large hscroll values would
873 mess up Emacs's display on Fedora 15 x86, presumably due to
874 overflows in int calculations in the display code.
875 Also, if buffers had long lines, Emacs would freeze.
876 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
877 (set_window_hscroll): New function, containing the old guts of
878 Fset_window_hscroll. Return the clipped value.
879 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
880 This avoids the need to check against PTRDIFF_MAX.
881
dea7f1e5
PE
882 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
883
76046526
DA
8842012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
885
886 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
887
39adff0d
PE
8882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
889
63807d47
PE
890 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
891 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
892 since GCC 4.4.6 issues a bogus warning for them.
893
39adff0d
PE
894 Fix bugs in file timestamp newness comparisons.
895 * fileio.c (Ffile_newer_than_file_p):
896 * lread.c (Fload): Use full timestamp resolution of files,
897 not just the 1-second resolution, so that files that are only
898 slightly newer still count as newer.
899 * fileio.c (Ffile_newer_than_file_p): Don't assume file
900 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
901
dbeed9a6
PE
9022012-07-03 Paul Eggert <eggert@cs.ucla.edu>
903
904 * fileio.c: Improve handling of file time marker. (Bug#11852)
905 (special_mtime): New function.
906 (Finsert_file_contents, Fverify_visited_file_modtime):
907 Use it to set special mtime values consistently.
908
636334d6
AS
9092012-07-03 Andreas Schwab <schwab@linux-m68k.org>
910
911 * fileio.c (Finsert_file_contents): Properly handle st_mtime
912 marker for non-existing file. (Bug#11852)
913
e2017fe2
GM
9142012-07-03 Glenn Morris <rgm@gnu.org>
915
916 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
917 and did not make it into globals.h).
918
404dbd37
TT
9192012-07-03 Tom Tromey <tromey@redhat.com>
920
921 * window.c (Fset_window_margins, Fset_window_fringes)
922 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
923 * textprop.c (Fprevious_property_change): No longer static.
924 * syntax.c (Fsyntax_table_p): No longer static.
925 * process.c (Fget_process, Fprocess_datagram_address): No longer
926 static.
927 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
928 * keyboard.c (Fcommand_execute): No longer static.
929 Remove EXFUN.
930 * insdel.c (Fcombine_after_change_execute): No longer static.
931 * image.c (Finit_image_library): No longer static.
932 * fileio.c (Fmake_symbolic_link): No longer static.
933 * eval.c (Ffetch_bytecode): No longer static.
934 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
935 * doc.c (Fdocumentation_property, Fsnarf_documentation):
936 No longer static.
404dbd37
TT
937 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
938 static.
939 * dired.c (Ffile_attributes): No longer static.
940 * composite.c (Fcomposition_get_gstring): No longer static.
941 * callproc.c (Fgetenv_internal): No longer static.
942
943 * ccl.h: Remove EXFUNs.
944 * buffer.h: Remove EXFUNs.
945 * dispextern.h: Remove EXFUNs.
946 * intervals.h: Remove EXFUNs.
947 * fontset.h: Remove EXFUN.
948 * font.h: Remove EXFUNs.
949 * dosfns.c (system_process_attributes): Remove EXFUN.
950 * keymap.h: Remove EXFUNs.
951 * lisp.h: Remove EXFUNs.
952 * w32term.h: Remove EXFUNs.
953 * window.h: Remove EXFUNs.
954 * xsettings.h: Remove EXFUN.
955 * xterm.h: Remove EXFUN.
956
8e4fd1e1
GM
9572012-07-03 Glenn Morris <rgm@gnu.org>
958
959 * lisp.h (Frandom): Make it visible to C.
960 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
961 buffer for invisible buffers. (Bug#1229)
962
ca95b3eb
DA
9632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
964
965 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
966 values which aren't power of 2.
967 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
968 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
969 accordingly.
970
7555c33f
SM
9712012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
972
973 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
974
975 * alloc.c (mark_object): Revert part of last patch to use `switch'.
976
d12e8f5a
DA
9772012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
978
979 * alloc.c (allocate_vector_block): Remove redundant
980 calls to mallopt if DOUG_LEA_MALLOC is defined.
981 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
982 avoid calls to mallopt if zero_vector is returned.
983
296094c3
DA
9842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
985
986 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
987 is enabled, avoid dereferencing NULL current_sblock if
988 running undumped.
989
36429c89
DA
9902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
991
992 Cleanup basic buffer management.
993 * buffer.h (struct buffer): Change layout to use generic vector
994 marking code. Fix some comments. Change type of 'clip_changed'
995 to bitfield. Remove unused #ifndef old.
996 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
997 (GET_OVERLAYS_AT): Fix indentation.
998 (for_each_per_buffer_object_at): New macro.
999 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1000 (Fbuffer_local_variables): Use it.
1001 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1002 * alloc.c (allocate_buffer): Adjust to match new layout of
1003 struct buffer. Fix comment.
1004 (mark_overlay): New function.
1005 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1006 Lisp area of struct buffer.
1007 (mark_object): Use it. Adjust marking of misc objects
1008 and related comments.
1009
3b3e4cac
PE
10102012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1013 wrapper that is not needed because the wrapped code is a no-op (zero
1014 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1015 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1016
cf5c0175
DA
10172012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1018
1019 * alloc.c (mark_buffer): Simplify. Remove prototype.
1020 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1021 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1022 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1023 redundant calls to mark_vectorlike for bool vectors.
1024
ca26824c
GM
10252012-06-30 Glenn Morris <rgm@gnu.org>
1026
2e4c5312
GM
1027 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1028
ca26824c
GM
1029 * epaths.in (PATH_SITELOADSEARCH): New.
1030 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1031 This is rather than relying on --enable-locallisppath elements
1032 having "site-lisp" in their names. (Bug#10208#25, 11658)
1033
0d23c240
EZ
10342012-06-30 Eli Zaretskii <eliz@gnu.org>
1035
c9240d7a
EZ
1036 * w32proc.c (sys_select): Accept and ignore one more argument.
1037
1038 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1039
0d23c240 1040 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1041 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1042
1043 * sysdep.c: Don't include dos.h and dosfns.h.
1044
1045 * process.c (sys_select):
1046 * msdos.c (sys_select): Accept one more argument and ignore it.
1047
1048 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1049 adapt data types and code to that.
1050
1051 * dosfns.c:
1052 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1053 which clashes with the gnulib function of the same name.
1054
af5a5a98
AS
10552012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1056
c5e4379c
AS
1057 * font.c (font_style_to_value, font_style_symbolic)
1058 (font_prop_validate_style): Add type checks for values in
1059 font_style_table.
1060
af5a5a98
AS
1061 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1062 argument.
1063 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1064 uses.
1065
8d38f461
EZ
10662012-06-29 Eli Zaretskii <eliz@gnu.org>
1067
2e5a6631
EZ
1068 * xdisp.c (try_window_id): Undo last change.
1069
8d38f461
EZ
1070 * w32.c (getwd): Adjust commentary about startup_dir.
1071 (init_environment): Always call sys_access, even in non-MSVC
1072 builds. Don't chdir to the directory of the Emacs executable.
1073 This undoes code from 1997 which was justified by the need to
1074 "avoid conflicts when removing and renaming directories". But its
1075 downside was that every relative file name was being interpreted
1076 relative to the directory of the Emacs executable, which can never
1077 be TRT. In particular, it broke sys_access when called with
1078 relative file names.
1079 (sys_access): Map GetLastError to errno.
1080
2af3565e
DA
10812012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 * window.h (struct window): Change type of 'fringes_outside_margins'
1084 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1085 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1086 Adjust comment.
1087 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1088 to ptrdiff_t.
1089
c8d3a25c 10902012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1091
c8d3a25c
GM
1092 * gnutls.c (emacs_gnutls_handshake):
1093 Add QUIT to make the loop interruptible.
57570cd3 1094
c8d3a25c 10952012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1096
c8d3a25c
GM
1097 * charset.c (init_charset): Make lack of etc/charsets fatal.
1098
3e984ee8
DA
10992012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1100
1101 * editfns.c (region_limit): Fix type mismatch.
1102
ef884f23
DA
11032012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1106 undefined. Convert from xassert to eassert.
1107 * nsmenu.m: Convert from xassert to eassert.
1108 * nsterm.m: Likewise.
1109
7d7e0027
SM
11102012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1113
aa754e6a
PE
11142012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 Avoid integer overflow on scroll-left and scroll-right.
1117 * window.c (HSCROLL_MAX): New macro.
1118 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1119 overflow when requested scroll falls outside ptrdiff_t range.
1120
80b00b08
DA
11212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * window.h (struct window): Change type of 'hscroll',
1124 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1125 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1126 Adjust users accordingly.
1127 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1128 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1129 from EMACS_INT to ptrdiff_t.
1130 (make_window): Omit redundant initialization.
1131
62b2bcf6
JB
11322012-06-28 Juanma Barranquero <lekktu@gmail.com>
1133
1134 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1135
45942c7d
DA
11362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1137
1138 * window.h (struct window): Change type of 'use_time' and
1139 'sequence_number' from Lisp_Object to int.
1140 * frame.c (make_frame): Adjust users accordingly.
1141 * print.c (print_object): Likewise.
1142 * window.c (select_window, Fwindow_use_time, make_parent_window)
1143 (make_window): Likewise.
1144
e509cfa6
DA
11452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1146
1147 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1148 enabled with --enable-checking=[all,glyphs] configure option.
1149 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1150 adjust comments accordingly.
1151 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1152 undefined, adjust comments accordingly.
1153 * image.c: Likewise.
1154 * scroll.c: Likewise.
1155 * w32fns.c: Likewise.
1156 * w32term.c: Likewise.
1157 * xdisp.c: Likewise.
1158 * xfaces.c: Likewise.
1159 * xfns.c: Likewise.
1160 * xterm.c: Likewise.
1161
a54e2c05
DA
11622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1163
1164 Generalize run-time debugging checks.
1165 * dispextern.h (XASSERTS): Remove.
1166 * fontset.c (xassert): Remove.
1167 Convert from xassert to eassert.
1168 * alloc.c: Convert from xassert to eassert.
1169 * bidi.c: Likewise.
1170 * dispnew.c: Likewise.
1171 * fns.c: Likewise.
1172 * fringe.c: Likewise.
1173 * ftfont.c: Likewise.
1174 * gtkutil.c: Likewise.
1175 * image.c: Likewise.
1176 * keyboard.c: Likewise.
1177 * menu.c: Likewise.
1178 * process.c: Likewise.
1179 * scroll.c: Likewise.
1180 * sound.c: Likewise.
1181 * term.c: Likewise.
1182 * w32console.c: Likewise.
1183 * w32fns.c: Likewise.
1184 * w32term.c: Likewise.
1185 * window.c: Likewise.
1186 * xdisp.c: Likewise.
1187 * xfaces.c: Likewise.
1188 * xfns.c: Likewise.
1189 * xselect.c: Likewise.
1190 * xterm.c: Likewise.
1191
1ec4b7b2
SM
11922012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1193
1194 * fns.c (maybe_resize_hash_table): Output message when growing the
1195 purify-hashtable.
1196
2014308a
DA
11972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 * alloc.c (allocate_string_data): Remove dead code.
1200 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1201 avoid GCC warning about unused macro.
1202
246155eb
DA
12032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 * alloc.c (allocate_string): Omit intervals initialization.
1206 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1207 as in make_pure_string and make_pure_c_string.
1208
43184b7b
DA
12092012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1210
d209e2fb 1211 * alloc.c (allocate_string): Fix last change.
43184b7b 1212
3fe6dd74
DA
12132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1214
d209e2fb 1215 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1216 to memset, add explicit initialization where appropriate.
1217
1ba6038a
GM
12182012-06-27 Glenn Morris <rgm@gnu.org>
1219
1220 * lisp.mk (lisp): Remove paths.elc.
1221
c89926a5
CY
12222012-06-27 Chong Yidong <cyd@gnu.org>
1223
1224 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1225
ed6b3510
JW
12262012-06-26 John Wiegley <johnw@newartisans.com>
1227
1ec4b7b2 1228 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1229 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1230
ed6b3510
JW
1231 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1232 when building with Clang.
1233
8edd4a2b
SM
12342012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1235
1236 * eval.c (Fapply): Allow calling it with a single argument.
1237
f6f62d1b
EZ
12382012-06-26 Eli Zaretskii <eliz@gnu.org>
1239
1240 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1241 _stricmp and _strnicmp.
1242 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1243
62efea5e
DA
12442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1247 allocated window.
1248 (allocate_process): Likewise for new process.
8edd4a2b 1249 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1250 (allocate_frame): Likewise.
1251 * frame.c (make_frame): Omit redundant initialization.
1252 * window.c (make_parent_window): Use memset.
1253 (make_window): Omit redundant initialization.
1254 * process.c (make_process): Omit redundant initialization.
1255 * terminal.c (create_terminal): Likewise.
1256
42997f4d
DA
12572012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 * term.c (delete_tty): Remove redundant call to memset.
1260
1130ecfc
DA
12612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1262
1263 * alloc.c: Remove build_string.
1264 * lisp.h: Define build_string as static inline. This provides
1265 a better opportunity to optimize away calls to strlen when the
1266 function is called with compile-time constant argument.
1267 * image.c (imagemagick_error): Convert to build_string.
1268 * w32proc.c (sys_spawnve): Likewise.
1269 * xterm.c (x_term_init): Likewise.
1270
cf38a720
PE
12712012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1272
99027bdd
PE
1273 Use sprintf return value instead of invoking strlen on result.
1274 In the old days this wasn't portable, since some sprintf
1275 implementations returned char *. But they died out years ago and
1276 Emacs already assumes sprintf returns int.
1277 Similarly for float_to_string.
1278 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1279 * ccl.c (ccl_driver):
1280 * character.c (string_escape_byte8):
1281 * data.c (Fnumber_to_string):
1282 * doprnt.c (doprnt):
1283 * print.c (print_object):
1284 * xdisp.c (message_dolog):
1285 * xfns.c (syms_of_xfns):
1286 Use sprintf or float_to_string result to avoid need to call strlen.
1287 * data.c (Fnumber_to_string):
1288 Use make_unibyte_string, since the string must be ASCII.
1289 * lisp.h, print.c (float_to_string): Now returns int length.
1290 * term.c (produce_glyphless_glyph):
1291 Use sprintf result rather than recomputing it.
1292
cf38a720
PE
1293 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1294 * Makefile.in (ALL_CFLAGS):
1295 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1296 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1297
3511c784
DA
12982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1299
0a08eb21 1300 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1301 strcasecmp if available.
1302 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1303
fb7da12e
AS
13042012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1305
1306 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1307 Avoid comma operator.
1308 * menu.c (push_submenu_start, push_submenu_end)
1309 (push_left_right_boundary, push_menu_pane): Likewise.
1310 * msdos.c (dos_rawgetc): Likewise.
1311
afa2ffd8
DA
13122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1313
1314 * xfns.c (xic_create_fontsetname): Remove redundant calls
1315 to memset.
1316
b3b4476b
PE
13172012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1318
4495ff38
PE
1319 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1320 sprintf already null-terminates its output.
1321
b3b4476b
PE
1322 * xfns.c (x_window): Remove redundant cast.
1323
b00876c9
DA
13242012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1325
1326 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1327 `const char *' to `char *' to avoid compiler warning.
1328
d188e26b
PE
13292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1330
885d1d74
PE
1331 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1332 instead of truncating it to 63 (admittedly a generous limit).
1333
d188e26b
PE
1334 * process.c: Fix spelling and caps in comments.
1335
e2f560b1
DN
13362012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1337
e86db54b 1338 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1339 * sysdep.c (setpgrp): Remove definition, not used in this file.
1340
7583a3a1
JB
13412012-06-24 Juanma Barranquero <lekktu@gmail.com>
1342
1343 * makefile.w32-in: Update dependencies.
1344
696056c2
EZ
13452012-06-24 Eli Zaretskii <eliz@gnu.org>
1346
1347 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1348 (SYSTIME_H): Add nt/inc/sys/time.h.
1349
1350 * systime.h [WINDOWSNT]: Include sys/time.h.
1351
1352 * s/ms-w32.h (struct timespec): Definition moved from
1353 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1354
845ca893
PE
13552012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1358 * buffer.h (buffer_slot_type_mismatch):
1359 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1360 * eval.c (unwind_to_catch):
1361 * image.c (my_png_error, my_error_exit):
1362 * keyboard.c (quit_throw_to_read_char, user_error)
1363 (Fexit_recursive_edit, Fabort_recursive_edit):
1364 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1365 (wrong_type_argument, buffer_overflow, __executable_start)
1366 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1367 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1368 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1369 (fatal):
1370 (child_setup) [!DOS_NT]:
1371 * lread.c (end_of_file_error, invalid_syntax):
1372 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1373 * puresize.h (pure_write_error):
1374 * search.c (matcher_overflow):
1375 * sound.c (sound_perror, alsa_sound_perror):
1376 * sysdep.c, syssignal.h (croak):
1377 * term.c (maybe_fatal, vfatal):
1378 * textprop.c (text_read_only):
1379 * undo.c (user_error):
1380 * unexmacosx.c (unexec_error):
1381 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1382 Use _Noreturn rather than NO_RETURN.
1383 No need for separate decl merely because of _Noreturn.
1384 * sound.c (sound_warning, parse_sound):
1385 Remove unnecessary forward decls.
1386
f1dd8073
PE
13872012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1390 * lisp.h (WAIT_READING_MAX): New macro.
1391 * dispnew.c (Fsleep_for, sit_for):
1392 * keyboard.c (kbd_buffer_get_event):
1393 * process.c (Faccept_process_output):
1394 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1395 This improves on the previous patch, which introduced a bug
1396 when time_t is unsigned and as wide as intmax_t.
1397 See <http://bugs.gnu.org/9000#51>.
1398
b82c1755
EZ
13992012-06-23 Eli Zaretskii <eliz@gnu.org>
1400
1401 * dispnew.c (sit_for, Fsleep_for):
1402 * keyboard.c (kbd_buffer_get_event):
1403 * process.c (Faccept_process_output): Avoid compiler warnings when
1404 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1405
ca300656
JB
14062012-06-23 Juanma Barranquero <lekktu@gmail.com>
1407
049ec95b
JB
1408 * makefile.w32-in: Update dependencies.
1409
ca300656
JB
1410 * w32.c (ltime): Add return type and declare static.
1411 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1412
db7b8d06
PE
14132012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1416 Privately reported by Herbert J. Skuhra.
1417 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1418 All uses changed.
1419 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1420 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1421
0bd8297f
EZ
14222012-06-23 Eli Zaretskii <eliz@gnu.org>
1423
96512555
EZ
1424 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1425 last argument of make_unibyte_string.
1426
0bd8297f
EZ
1427 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1428 language ID in the event parameters.
1429
1430 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1431 event.code, not the obscure "character set ID".
1432
63def6b6
CY
14332012-06-23 Chong Yidong <cyd@gnu.org>
1434
1435 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1436
e8a02204
EZ
14372012-06-23 Eli Zaretskii <eliz@gnu.org>
1438
388cdec0
EZ
1439 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1440 * w32.c (fdutimens): New function.
1441
1442 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1443
1444 * s/ms-w32.h (pselect): Redirect to sys_select.
1445
1446 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1447
e8a02204
EZ
1448 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1449 in the logic of incrementing and decrementing the value of
1450 use_relocatable_buffers.
1451
d054f3fb
PE
14522012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1455 Privately reported by Herbert J. Skuhra.
1456 [__FreeBSD__]: Remove "*/" typo after "#include".
1457 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1458 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1459 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1460 Don't assume EMACS_TIME and struct timeval are the same type.
1461
d35af63c
PE
14622012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 Support higher-resolution time stamps (Bug#9000).
1465 The time stamps are only nanosecond-resolution at the C level,
1466 since that's the best that any real-world system supports now.
1467 But they are picosecond-resolution at the Lisp level, as that's
1468 easy, and leaves room for future OS improvements.
1469
1470 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1471 (LIBES): Use it.
1472
1473 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1474 Don't get current time unless it's needed.
1475
1476 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1477 now provides it if it's absent.
1478 (start_atimer): Port to higher-res time stamps.
1479 Check for time stamp overflow. Don't get current time more
1480 often than is needed.
1481
1482 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1483 Include systime.h, not time.h.
1484 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1485
1486 * dired.c: Include stat-time.h.
1487 (Ffile-attributes): File times now have higher resolution.
1488
1489 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1490 (struct image): Timestamp now has higher resolution.
1491
1492 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1493 has at least microseconds now. All uses removed.
1494 (update_frame, update_single_window, update_window, update_frame_1)
1495 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1496
1497 * editfns.c (time_overflow): Now extern.
1498 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1499 (float-time, Fformat_time_string, Fcurrent_time_string)
1500 (Fcurrent_time_zone): Accept and generate higher-resolution
1501 time stamps.
1502 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1503 (decode_time_components, lisp_seconds_argument): New functions.
1504 (make_time): Now static.
1505 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1506 Report an error if the time is invalid, rather than having the caller
1507 do that.
1508
1509 * fileio.c: Include <stat-time.h>
1510 (Fcopy_file): Copy higher-resolution time stamps.
1511 Prefer to set the time stamp via a file descriptor if that works.
1512 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1513 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1514 (Fvisited_file_modtime, Fset_visited_file_modtime):
1515 Support higher-resolution time stamps.
1516
1517 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1518
1519 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1520
1521 * image.c (prepare_image_for_display, clear_image_cache)
1522 (lookup_image): Port to higer-resolution time stamps.
1523
1524 * keyboard.c (start_polling, bind_polling_period):
1525 Check for time stamp overflow.
1526 (read_char, kbd_buffer_get_event, timer_start_idle)
1527 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1528 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1529 Port to higher-resolution time stamps. Do not assume time_t is signed.
1530 (decode_timer): New function. Timers are now vectors of length 9,
1531 not 8, to accommodate the picosecond component.
1532 (timer_check_2): Use it.
1533
1534 * nsterm.m (select_timeout, timeval_subtract): Remove.
1535 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1536 as they're a bit more accurate and handle overflow better.
1537 (ns_select): Change prototype to be compatible with pselect.
1538 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1539 * nsterm.h (ns_select): Adjust prototype.
1540
1541 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1542 us-resolution time stamps.
1543 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1544
1545 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1546
1547 * lisp.h (time_overflow): New decl.
1548 (wait_reading_process_output): First arg is now intmax_t, not int,
1549 to accommodate larger waits.
1550
1551 * process.h (struct Lisp_Process.read_output_delay):
1552 Now counts nanoseconds, not microseconds.
1553 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1554 EMACS_HAS_USECS.
1555 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1556 (wait_reading_process_output):
1557 Port to ns-resolution time stamps.
1558 (Faccept_process_output, wait_reading_process_output):
1559 Check for time stamp overflow. Do not assume time_t is signed.
1560 (select_wrapper): Remove; we now use pselect.
1561 (Fprocess_attributes): Now generates ns-resolution time stamps.
1562
1563 * sysdep.c: Include utimens.h. Don't include utime.h
1564 or worry about struct utimbuf; gnulib does that for us now.
1565 (gettimeofday): Remove; gnulib provides a substitute.
1566 (make_timeval): New function.
1567 (set_file_times): Now sets ns-resolution time stamps.
1568 New arg FD; all uses changed.
1569 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1570 (system_process_attributes):
1571 Now returns ns-resolution time stamp. All uses changed.
1572 Check for time stamp overflow.
1573
1574 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1575 provides a substitute now.
1576
1577 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1578 since it guarantees struct timespec.
1579 (EMACS_TIME): Now struct timespec, so that we can support
1580 ns-resolution time stamps.
1581 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1582 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1583 (EMACS_USECS): Remove.
1584 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1585 so multiply the arg by 1000 before storing it.
1586 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1587 New macros.
1588 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1589 Port to ns-resolution time stamps.
1590 (EMACS_TIME_NEG_P): Remove; replaced by....
1591 (EMACS_TIME_SIGN): New macro.
1592 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1593 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1594 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1595 (make_timeval, make_lisp_time, decode_time_components): New decls.
1596 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1597 that it mishandled time_t overflow. You can't compare by subtracting!
1598 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1599 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1600
1601 * term.c: Include <sys/time.h>.
1602 (timeval_to_Time): New function, for proper overflow wraparound.
1603 (term_mouse_position, term_mouse_click): Use it.
1604
1605 * undo.c (record_first_change): Support higher-resolution time stamps
1606 in the undo buffer.
1607 (Fprimitive_undo): Use them when restoring time stamps.
1608
1609 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1610 (w32_get_internal_run_time):
1611 Port to higher-resolution Emacs time stamps.
1612 (ltime): Now accepts single 64-bit integer, as that's more convenient
1613 for callers.
1614
1615 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1616
1617 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1618 for compatibility with pselect. Support ns-resolution time stamps.
1619
1620 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1621
1622 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1623 Check for time stamp overflow, and support ns-resolution time stamps.
1624
1625 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1626 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1627 (timeval_subtract): Remove; no longer needed.
1628 (XTflash, XTring_bell, x_wait_for_event):
1629 Port to ns-resolution time stamps. Don't assume time_t is signed.
1630
b6a92dfe
CY
16312012-06-22 Chong Yidong <cyd@gnu.org>
1632
1633 * xdisp.c (x_consider_frame_title): Revert last change.
1634
d251c37c
EZ
16352012-06-22 Eli Zaretskii <eliz@gnu.org>
1636
1637 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1638 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1639 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1640 staticidx goes up to 1597 out of 1600 = 0x640.)
1641
f10deafb
PE
16422012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1643
1644 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1645 Otherwise, the umask might be mistakenly 0 while handling input signals.
1646
ec6de1e2
SM
16472012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1648
1649 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1650
28be1ada
DA
16512012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1652
1653 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1654 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1655 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1656 access to `contents' member of Lisp_Vector objects with AREF and ASET
1657 where appropriate.
1658
c6bf3022
CY
16592012-06-19 Chong Yidong <cyd@gnu.org>
1660
1661 * frame.c (delete_frame): When selecting a frame on a different
1662 text terminal, do not alter the terminal's top-frame.
1663
1664 * xdisp.c (format_mode_line_unwind_data): Record the target
1665 frame's selected window and its terminal's top-frame.
1666 (unwind_format_mode_line): Restore them.
1667 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1668 Callers changed.
1669 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1670 since tty frames can be explicitly named.
1671 (prepare_menu_bars): Likewise.
1672
1673 * term.c (Ftty_top_frame): New function.
1674
defd4196
PE
16752012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 Port byte-code-meter to modern targets.
1678 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1679 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1680 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1681 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1682 (METER_1, METER_2): Simplify.
1683
1053a871
SM
16842012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1685
1686 * data.c (Fdefalias): Return `symbol' (bug#11686).
1687
b7e8d081
MR
16882012-06-18 Martin Rudalics <rudalics@gmx.at>
1689
1690 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1691 gets killed during executing of this function (Bug#11665).
1692 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1693 (Vkill_buffer_query_functions): In doc-string say that functions
1694 run by this hook should not change the current buffer.
1695
7ea2b339
PE
16962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 Fix recently-introduced process.c problems found by static checking.
1699 * process.c (write_queue_push, write_queue_pop, send_process):
1700 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1701 (write_queue_pop): Fix pointer signedness problem.
1702 (send_process): Remove unused local.
1703
96a313a1
CY
17042012-06-17 Chong Yidong <cyd@gnu.org>
1705
1706 * xdisp.c (redisplay_internal): No need to redisplay terminal
1707 frames that are not on top.
1708
20ca2e94
TN
17092012-06-17 Troels Nielsen <bn.troels@gmail.com>
1710
1711 * process.c (make_process): Initialize write_queue.
1712 (write_queue_push, write_queue_pop): New functions.
1713 (send_process): Use them to maintain correct ordering of process
1714 writes (Bug#10815).
1715
9a900ca9
PE
17162012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1717
310fbfa8
PE
1718 * lisp.h (eassert): Assume C89 or later.
1719 This removes the need for CHECK.
1720 (CHECK): Remove. Its comments about always evaluating its
1721 argument were confusing, as 'eassert' typically does not evaluate
1722 its argument.
1723
27bb1ca4
PE
1724 * coding.c (produce_chars): Use ptrdiff_t, not int.
1725
9a900ca9
PE
1726 * xterm.c (x_draw_underwave): Check for integer overflow.
1727 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1728
41b7f8bc 17292012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1730
1731 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1732 referenced (Bug#11583).
1733
9b0e3eba
AA
17342012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1735
1736 Implement wave-style variant of underlining.
1737 * dispextern.h (face_underline_type): New enum.
1738 (face): Add field for underline type.
1739 * nsterm.m (ns_draw_underwave): New function.
1740 (ns_draw_text_decoration): Use it.
1741 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1742 New functions.
1743 (x_draw_glyph_string): Use them.
1744 * xfaces.c (Qline, Qwave): New Lisp objects.
1745 (check_lface_attrs, merge_face_ref)
1053a871
SM
1746 (Finternal_set_lisp_face_attribute, realize_x_face):
1747 Handle wave-style underline face attributes.
9b0e3eba
AA
1748 * xterm.c (x_draw_underwave): New function.
1749 (x_draw_glyph_string): Use it.
1750
0fb52f11
JB
17512012-06-16 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1754 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1755 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1756 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1757 ($(BLD)/w32select.$(O)): Update dependencies.
1758
e5560ff7
AS
17592012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1760
1761 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1762 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1763 * character.c (_fetch_multibyte_char_p): Remove.
1764 * alloc.c: Include "character.h" before "buffer.h".
1765 * bidi.c: Likewise.
1766 * buffer.c: Likewise.
1767 * bytecode.c: Likewise.
1768 * callint.c: Likewise.
1769 * callproc.c: Likewise.
1770 * casefiddle.c: Likewise.
1771 * casetab.c: Likewise.
1772 * category.c: Likewise.
1773 * cmds.c: Likewise.
1774 * coding.c: Likewise.
1775 * composite.c: Likewise.
1776 * dired.c: Likewise.
1777 * dispnew.c: Likewise.
1778 * doc.c: Likewise.
1779 * dosfns.c: Likewise.
1780 * editfns.c: Likewise.
1781 * emacs.c: Likewise.
1782 * fileio.c: Likewise.
1783 * filelock.c: Likewise.
1784 * font.c: Likewise.
1785 * fontset.c: Likewise.
1786 * fringe.c: Likewise.
1787 * indent.c: Likewise.
1788 * insdel.c: Likewise.
1789 * intervals.c: Likewise.
1790 * keyboard.c: Likewise.
1791 * keymap.c: Likewise.
1792 * lread.c: Likewise.
1793 * macros.c: Likewise.
1794 * marker.c: Likewise.
1795 * minibuf.c: Likewise.
1796 * nsfns.m: Likewise.
1797 * nsmenu.m: Likewise.
1798 * print.c: Likewise.
1799 * process.c: Likewise.
1800 * regex.c: Likewise.
1801 * region-cache.c: Likewise.
1802 * search.c: Likewise.
1803 * syntax.c: Likewise.
1804 * term.c: Likewise.
1805 * textprop.c: Likewise.
1806 * undo.c: Likewise.
1807 * unexsol.c: Likewise.
1808 * w16select.c: Likewise.
1809 * w32fns.c: Likewise.
1810 * w32menu.c: Likewise.
1811 * window.c: Likewise.
1812 * xdisp.c: Likewise.
1813 * xfns.c: Likewise.
1814 * xmenu.c: Likewise.
1815 * xml.c: Likewise.
1816 * xselect.c: Likewise.
1817
2f07e6af
EZ
18182012-06-16 Eli Zaretskii <eliz@gnu.org>
1819
1053a871
SM
1820 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1821 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1822 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1823 row.
1824 (handle_face_prop): Use chunk-relative overlay string index when
1825 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1826 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1827 the rightmost. (Bug#11720)
2f07e6af 1828
29b83cec
AS
18292012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1830
1831 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1832 (CATEGORY_MEMBER): Enforce 1/0 value.
1833 * category.c (_temp_category_set): Remove.
1834
4c5501e9
EZ
18352012-06-16 Eli Zaretskii <eliz@gnu.org>
1836
1837 * window.c (Fdelete_other_windows_internal)
1838 (Fdelete_window_internal): Don't access frame's mouse highlight
1839 info of the initial frame. (Bug#11677)
1840
2b570124
PE
18412012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1842
e93864f9
PE
1843 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1844 Assume USE_2_TAGS_FOR_INTS.
1845 (xreload): Adjust $tagmask width to match recent lisp.h change.
1846
2b570124
PE
1847 Simplify lisp.h in minor ways that should not affect code.
1848 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1849 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1850 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1851 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1852 (INTTYPEBITS): New macro, for clarity.
1853 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1854 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1855 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1856 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1857 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1858
81755f69
JB
18592012-06-13 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1862
16192a57
GM
18632012-06-13 Glenn Morris <rgm@gnu.org>
1864
1865 * s/bsd-common.h (BSD4_3):
1866 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1867
646b5f55
AS
18682012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1869
1870 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1871 instead of union.
1872 (XLI, XIL): Define.
1053a871
SM
1873 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1874 Use them.
1875 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1876 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1877 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1878 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1879 * frame.c (delete_frame): Remove outdated comment.
1880 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1881 USE_LISP_UNION_TYPE.
1882 (Fw32_unregister_hot_key): Likewise.
1883 (Fw32_toggle_lock_key): Likewise.
1884 * w32menu.c (add_menu_item): Likewise.
1885 (w32_menu_display_help): Use XIL instead of checking
1886 USE_LISP_UNION_TYPE.
1887 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1888 (init_heap): Likewise.
1889 * w32term.c (w32_read_socket): Update comment.
1890
1d3823c9
GM
18912012-06-13 Glenn Morris <rgm@gnu.org>
1892
c62ff706
GM
1893 * s/usg5-4-common.h, src/s/unixware.h:
1894 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1895
1d3823c9
GM
1896 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1897
bfe3e0a2
PE
18982012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1899
1900 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1901 * alloc.c (make_number) [!defined make_number]:
1902 Remove, as lisp.h always defines this now.
1903 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1904 (roundup_size): Verify that it is a power of 2.
1905 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1906 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1907 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1908 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1909 USE_LSB_TAG now is always defined to be either 0 or 1.
1910 All uses changed.
1911 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1912 code works fine either way, and efficiency is not a concern here,
1913 as the union type is for debugging, not for production.
1914 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1915 Use an inline function on all platforms when using the union type,
1916 since this is simpler and 'static inline' can be used portably
1917 within Emacs now.
1918 (LISP_INITIALLY_ZERO): New macro.
1919 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1920 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1921
45fa9c0f
GM
19222012-06-12 Glenn Morris <rgm@gnu.org>
1923
b4492cba
GM
1924 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1925
1926 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1927
45fa9c0f
GM
1928 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1929 Move BROKEN_SIGIO to configure.
1930
1931 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1932 Move NO_TERMIO to configure.
1933
0e25d334
CY
19342012-06-12 Chong Yidong <cyd@gnu.org>
1935
1936 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1937 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1938 MagickExportImagePixels is undefined.
1939
43682bb6
PE
19402012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * image.c (imagemagick_load_image): Remove unused label.
1943
a9be7d2b
GM
19442012-06-11 Glenn Morris <rgm@gnu.org>
1945
1946 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1947 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1948 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1949 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1950
3017f87f
SM
19512012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1952
1953 * alloc.c (make_byte_code): New function.
1954 (Fmake_byte_code): Use it. Don't purify here.
1955 * lread.c (read1): Use it as well to avoid extra allocation.
1956
1b9b4cf4
CY
19572012-06-11 Chong Yidong <cyd@gnu.org>
1958
1959 * image.c (imagemagick_load_image): Implement transparency.
1960
95988fcf
AS
19612012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1962
1963 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1964 account for preceding backslashes. (Bug#11663)
1965
cd4eb164
CY
19662012-06-09 Chong Yidong <cyd@gnu.org>
1967
1968 * term.c: Support italics in capable terminals (Bug#9652).
1969 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1970 (turn_on_face): Output using TS_enter_italic_mode if available.
1971 Don't handle unused blinking and alt-charset cases.
1972 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1973 and tty_alt_charset_p cases.
1974 (tty_capable_p, init_tty): Support italics.
1975
1976 * termchar.h (struct tty_display_info): Add field for italics.
1977 Remove unused blink field.
1978
1979 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1980 Handle slant.
1981
1982 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1983 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1984 tty_alt_charset_p. Add tty_italic_p.
1985
ff88beb8
MA
19862012-06-09 Michael Albinus <michael.albinus@gmx.de>
1987
1988 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1989 dbus_type_is_basic if available.
1990 (xd_extract_signed, xd_extract_unsigned): Rename from
1991 extract_signed and extract_unsigned, respectively. Adapt callers.
1992
44286096
CY
19932012-06-09 Chong Yidong <cyd@gnu.org>
1994
1682701f
CY
1995 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1996
44286096
CY
1997 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1998 case (Bug#9752).
1999
d86feb17
PE
20002012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 * xdisp.c (vmessage): Treat frame message as multibyte.
2003 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2004 would generate the diagnostic "Making \302\247 buffer-local while
2005 let-bound!".
2006
d5c20fe8
EZ
20072012-06-08 Eli Zaretskii <eliz@gnu.org>
2008
2009 * dispnew.c (showing_window_margins_p): Undo last change, which
2010 was done due to an inadvertent commit.
2011 (adjust_frame_glyphs_for_frame_redisplay): Do call
2012 showing_window_margins_p.
2013
513749ee
SM
20142012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * eval.c (Fmake_var_non_special): New primitive.
2017 (syms_of_eval): Defsubr it.
2018 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2019
d4a8f5c1
JB
20202012-06-08 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2023 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2024
8bbbc977
EZ
20252012-06-08 Eli Zaretskii <eliz@gnu.org>
2026
2027 * alloc.c (allocate_vectorlike): Fix last change.
2028
f3372c87
DA
20292012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2030
2031 Block-based vector allocation of small vectors.
2032 * lisp.h (struct vectorlike_header): New field `nbytes',
2033 adjust comment accordingly.
2034 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2035 to denote vector blocks. Adjust users (live_vector_p,
2036 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2037 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2038 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2039 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2040 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2041 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2042 (roundup_size): New constant.
2043 (struct vector_block): New data type.
2044 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2045 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2046 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2047 (sweep_vectors): New functions.
2048 (allocate_vectorlike): Return `zero_vector' as the only vector of
2049 0 items. Allocate new vector from block if vector size is less than
2050 or equal to VBLOCK_BYTES_MAX.
2051 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2052 (init_alloc_once): Add call to init_vectors.
2053
4f18a4ed
SM
20542012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2055
2056 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2057
86f158bc
PE
20582012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * doprnt.c (doprnt): Truncate multibyte char correctly.
2061 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2062 would mishandle a string argument "Xc" if X was a multibyte
2063 character of length 2: it would truncate after X's first byte
2064 rather than including all of X.
2065
c5cfcbe0
CY
20662012-06-06 Chong Yidong <cyd@gnu.org>
2067
2068 * buffer.c (word_wrap): Doc fix.
2069
c05cf390
PE
20702012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2073
0c3461de
GM
20742012-06-03 Glenn Morris <rgm@gnu.org>
2075
2076 * xdisp.c (tool-bar-style): Doc fix.
2077
c71232db
UM
20782012-06-03 Ulrich Müller <ulm@gentoo.org>
2079
2080 * Makefile.in (PAXCTL): Define.
2081 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2082 binary via PaX flags if the paxctl utility is available.
2083 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2084 Restore PaX flags to their default. (Bug#11398)
2085
383f7350
CY
20862012-06-03 Chong Yidong <cyd@gnu.org>
2087
2088 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2089 buffer (Bug#11226).
2090
5f2c76c6
CY
20912012-06-03 Chong Yidong <cyd@gnu.org>
2092
2093 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2094 (note_mode_line_or_margin_highlight): If there is no help echo,
2095 use mode-line-default-help-echo. Handle the case where the mouse
2096 position is past the end of the mode line string.
2097
2098 * buffer.c (buffer_local_value_1): New function, split from
2099 Fbuffer_local_value; can return Qunbound.
2100 (Fbuffer_local_value): Use it.
2101 (Vmode_line_format): Docstring tweaks.
2102
773d47f6
PE
21032012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * sysdep.c (system_process_attributes): Improve comment.
2106
f2d6a3df
SM
21072012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2108
2109 * keyboard.c: Export real-this-command to Elisp.
2110 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2111 and DEFVAR it. Update all users.
2112
63810350
PE
21132012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2114
7bd5c1f4
PE
2115 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2116
63810350
PE
2117 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2118 Convert pctcpu and pctmem to Lisp float properly.
2119 Let the compiler fold better, as 100.0/0x8000 is exact.
2120
a2821611
AS
21212012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2122
2123 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2124 cons_block.
2125
5fceba1d
PE
21262012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2129
c98ff5dd
DA
21302012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2131
2132 For a 'struct window', replace some Lisp_Object fields to
2133 bitfields where appropriate, remove unused fields.
2134 * window.h (struct window): Remove unused 'last_mark_x' and
2135 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2136 change it's type from Lisp_Object to bitfield.
2137 Change type of 'force_start', 'optional_new_start',
2138 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2139 fields from Lisp_Object to bitfield. Adjust users accordingly.
2140
ca34e0be
PE
21412012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 Pacify gcc -Wdouble-precision when using Xaw.
2144 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2145 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2146 Use 'float' consistently, rather than 'float' in most places
2147 and 'double' in a couple of places.
2148
efc00ab1 21492012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2150
2151 * xdisp.c (handle_stop): Detect whether we have overlay strings
2152 loaded by testing it->current.overlay_string_index to be
2153 non-negative, instead of checking whether n_overlay_strings is
2154 positive. (Bug#11587)
2155
efc00ab1 21562012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2157
2158 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2159
2160 * doc.c (Fsubstitute_command_keys): Doc fix.
2161
efc00ab1 21622012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2163
2164 * search.c (search_buffer): Remove calls to
2165 r_alloc_inhibit_buffer_relocation, as it is now called by
2166 maybe_unify_char, which was the cause of relocation of buffer text
2167 in bug#11519.
2168
efc00ab1 21692012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2170
2171 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2172 for the duration of call to load_charset, to avoid problems with
2173 callers of maybe_unify_char that access buffer text through C
2174 pointers.
2175
2176 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2177 decrement the inhibition flag, instead of just setting or
2178 resetting it.
2179
ba93a187
PE
21802012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 Remove obsolete '#define static' cruft.
2183 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2184 This #undef was "temporary" in 2000; it is no longer needed
2185 now that '#define static' has gone away.
2186 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2187 (gray_bitmap_bits): Remove; no longer needed.
2188 All uses replaced with definiens.
2189 * xterm.c: Include "bitmaps/gray.xbm".
2190
9e4bf381
PE
21912012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 Clean up __executable_start, monstartup when --enable-profiling.
2194 The following changes affect the code only when profiling.
2195 * dispnew.c (__executable_start): Rename from safe_bcopy.
2196 Define only on platforms that need it.
2197 * emacs.c: Include <sys/gmon.h> when profiling.
2198 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2199 (__executable_start): Remove decl, since lisp.h does it now.
2200 (safe_bcopy): Remove decl; no longer has that name.
2201 (main): Coalesce #if into single bit of code, for simplicity.
2202 Cast pointers to uintptr_t, since standard libraries want integers
2203 and not pointers.
2204 * lisp.h (__executable_start): New decl.
2205
32d72c2f
GM
22062012-05-31 Glenn Morris <rgm@gnu.org>
2207
2208 * image.c (Fimagemagick_types): Doc fix.
2209
baac5bc7
JM
22102012-05-30 Jim Meyering <meyering@redhat.com>
2211
2212 * callproc.c (Fcall_process_region): Include directory component
2213 in mkstemp error message (Bug#11586).
2214
72cb32cf
PE
22152012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 * alloc.c, lisp.h (make_pure_vector): Now static.
2218
61b108cc
SM
22192012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2220
2221 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2222 Move to byte-run.el.
2223 (Fautoload): Do the hash-doc more carefully.
2224 * data.c (Fdefalias): Purify definition, except for keymaps.
2225 (Qdefun): Move from eval.c.
2226 * lisp.h (Qdefun): Remove.
2227 * lread.c (read1): Tiny simplification.
2228
471fe23d
TN
22292012-05-29 Troels Nielsen <bn.troels@gmail.com>
2230
934f3f58 2231 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2232 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2233 Bug#9642, but explicitly check that the buffer the overlay would
2234 be moved to is live and rearrange lines to make sure that errors
2235 will not put the overlay in an inconsistent state.
2236 (Fdelete_overlay): Cosmetics.
2237
85d0efd1
EZ
22382012-05-28 Eli Zaretskii <eliz@gnu.org>
2239
2240 * w32term.c (my_bring_window_to_top): New function.
2241 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2242 could be different from the original one.
2243 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2244 (Bug#11513)
2245
2246 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2247 by calling BringWindowToTop.
2248
2249 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2250 (WM_EMACS_END): Increase by one.
2251
da92a98c
PE
22522012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2255 This avoids undefined behavior that might cause the eassert
2256 to not catch an out-of-range value.
2257
74d1f848
JB
22582012-05-28 Juanma Barranquero <lekktu@gmail.com>
2259
2260 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2261 Update dependencies.
2262
9e1a06fc
EZ
22632012-05-27 Eli Zaretskii <eliz@gnu.org>
2264
2265 * bidi.c (bidi_mirror_char): Fix last change.
2266
f3dd7312
AS
22672012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2268
2269 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2270 when referring to sectname field in printf format.
2271
81899c91
PE
22722012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2273
57b81a9f
PE
2274 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2275 Only r_alloc_inhibit_buffer_relocation needed to be added;
2276 the others were already declared.
2277
81899c91
PE
2278 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2279 before checking whether it's out of range. Put the check inside
2280 eassert. See
2281 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2282
33017faf 22832012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2284
2285 * callproc.c (Fcall_process): Restore a line that was accidentally
2286 commented out in the 2011-02-13 change (bug#11547).
2287
33017faf 22882012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2289
2290 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2291 defined on ralloc.c.
2292
2293 * buffer.c [REL_ALLOC]: Remove prototypes of
2294 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2295 they are now on lisp.h.
2296
2297 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2298
2299 * search.c (search_buffer): Use it to inhibit relocation of buffer
2300 text while re_search_2 is doing its job, because re_search_2 is
2301 passed C pointers to buffer text. (Bug#11519)
2302
23415acf
EZ
2303 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2304 Update value to 24.
2305
44e27368
EZ
2306 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2307 state after an additional call to move_it_in_display_line_to, keep
2308 the values of it->max_ascent and it->max_descent found for the
2309 entire line.
2310 (pos_visible_p): Revert the comparison against bottom_y to what it
2311 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2312 (Bug#11464)
2313
c1892f11
PE
23142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 Fix coding-related core dumps with gcc -ftrapv.
2317 The code was computing A - B, where A and B are pointers, and B is
2318 random garbage. This can lead to core dumps on platforms that
2319 have special pointer registers, and it also leads to core dumps on
2320 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2321 A - B only when B is initialized properly.
2322 * coding.c (coding_set_source, coding_set_destination): Return void.
2323 (coding_change_source, coding_change_destinations): New functions,
2324 with the old behaviors of coding_set_source and coding_set_destination.
2325 All callers that need an offset changed to use these new functions.
2326
eb7afdad
GM
23272012-05-26 Glenn Morris <rgm@gnu.org>
2328
2329 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2330
f12fdf02
EZ
23312012-05-26 Eli Zaretskii <eliz@gnu.org>
2332
53a63be6 2333 Extend mouse support on W32 text-mode console.
61b108cc
SM
2334 * xdisp.c (draw_row_with_mouse_face):
2335 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2336
eb3f6f01 2337 * w32console.c: Include window.h.
61b108cc
SM
2338 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2339 New functions.
eb3f6f01
EZ
2340 (initialize_w32_display): Initialize mouse-highlight data.
2341
53a63be6
EZ
2342 * w32inevt.c: Include termchar.h and window.h.
2343 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2344 moves, call note_mouse_highlight. If help_echo changed, call
2345 gen_help_event to produce help-echo message in the echo area.
2346 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2347 highlight info.
2348
4cfd81f6
PE
23492012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * lread.c (read1): Simplify slightly to avoid an overflow warning
2352 with GCC 4.7.0 on x86-64.
2353
4446092a
EZ
23542012-05-26 Eli Zaretskii <eliz@gnu.org>
2355
2356 * bidi.c (bidi_mirror_char): Revert last change: an int is
2357 definitely wide enough here.
2358
42b2a986 23592012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2360
42b2a986 2361 Fix integer width and related bugs (Bug#9874).
eb106a49 2362 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2363 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2364 (string_bytes, check_sblock, allocate_string_data):
2365 (compact_small_strings, Fmake_bool_vector, make_string)
2366 (make_unibyte_string, make_multibyte_string)
2367 (make_string_from_bytes, make_specified_string)
2368 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2369 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2370 (mark_vectorlike):
2371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2372 (allocate_pseudovector):
2373 Use int, not EMACS_INT, where int is wide enough.
2374 (inhibit_garbage_collection, Fgarbage_collect):
2375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2376 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2377 int might not be wide enough.
2378 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2379 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2380 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2381 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2382 (bidi_level_of_next_char, bidi_move_to_visually_next):
2383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2384 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2385 (Fkill_buffer, Fset_buffer_major_mode)
2386 (advance_to_char_boundary, Fbuffer_swap_text)
2387 (Fset_buffer_multibyte, overlays_at, overlays_in)
2388 (overlay_touches_p, struct sortvec, record_overlay_string)
2389 (overlay_strings, recenter_overlay_lists)
2390 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2391 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2392 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2393 (Foverlay_recenter, last_overlay_modification_hooks_used)
2394 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2396 (validate_region): Omit unnecessary test for b <= e,
2397 since that's guaranteed by the previous test.
d311d28c
PE
2398 (adjust_overlays_for_delete): Avoid pos + length overflow.
2399 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2400 (report_overlay_modification):
2401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2402 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2403 Omit pointer cast, which isn't needed anyway, and doesn't work
2404 after the EMACS_INT -> ptrdiff_t change.
02481186 2405 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2406 * buffer.h: Adjust decls to match defn changes elsewhere.
2407 (struct buffer_text, struct buffer):
2408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2409 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2410 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2411 not int, to avoid needless 32-bit limit on 64-bit hosts.
2412 (exec_byte_code): Use tighter memory-full test, one that checks
2413 for alloca overflow. Don't compute the address of the object just
2414 before an array, as that's not portable. Use EMACS_INT, not
2415 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2416 * callint.c (Fcall_interactively):
2417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2418 * callproc.c (call_process_kill, Fcall_process):
2419 Don't assume pid_t fits into an Emacs fixnum.
2420 (call_process_cleanup, Fcall_process, child_setup):
2421 Don't assume pid_t fits into int.
2422 (call_process_cleanup, Fcall_process, delete_temp_file)
2423 (Fcall_process_region):
2424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2425 (Fcall_process): Simplify handling of volatile integers.
2426 Use int, not EMACS_INT, where int will do.
2427 * casefiddle.c (casify_object, casify_region, operate_on_word)
2428 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 (casify_object): Avoid integer overflow when overallocating buffer.
2431 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2432 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2433 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2434 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2435 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2436 integers are now checked earlier. All uses replaced with XINT.
2437 (ccl_driver):
2438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2439 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2440 (ccl_driver, Fregister_code_conversion_map):
2441 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2442 (resolve_symbol_ccl_program): Check that vector header is in range.
2443 Always copy the vector, so that we can check its contents reliably
2444 now rather than having to recheck each instruction as it's being
2445 executed. Check that vector words fit in 'int'.
2446 (ccl_get_compiled_code, Fregister_ccl_program)
2447 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2448 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2449 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2450 contents are in range.
2451 (Fccl_execute_on_string): Check that status is in range.
2452 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2453 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2454 Accept and return EMACS_INT, not int, because callers can pass values
2455 out of 'int' range.
2456 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2457 (multibyte_chars_in_text, parse_str_as_multibyte)
2458 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2459 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2460 (string_escape_byte8, Fget_byte):
2461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2462 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2463 avoid mishandling large integers.
2464 * character.h: Adjust decls to match defn changes elsewhere.
2465 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2466 (Ffind_charset_region):
2467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2468 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2469 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2470 Don't assume fixnum fits in int.
d311d28c
PE
2471 (load_charset_map_from_vector, Fmap_charset_chars):
2472 Remove now-unnecessary CHECK_NATNUMs.
2473 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2474 Don't rely on undefined behavior with signed left shift overflow.
2475 Don't assume unsigned int fits into fixnum, or that fixnum fits
2476 into unsigned int. Don't require max_code to be a valid fixnum;
2477 that's not true for gb10830 4-byte on a 32-bit host. Allow
2478 invalid_code to be a cons, for the same reason. Require code_offset
2479 to be a character. Avoid int overflow if max_char is close
2480 to INT_MAX.
2481 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2482 this is intended anyway and avoids some undefined behavior.
2483 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2484 INDEX_TO_CODE_POINT, as that's what it expects.
2485 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2486 * charset.h (DECODE_CHAR): Return int, not unsigned;
2487 this is what was intended anyway, and it avoids undefined behavior.
2488 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2489 integer-overflow issues.
2490 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2491 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2492 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2493 * chartab.c (Fmake_char_table, Fset_char_table_range)
2494 (uniprop_get_decoder, uniprop_get_encoder):
2495 Don't assume fixnum fits in int.
2496 * cmds.c (move_point): New function, that does the gist of
2497 Fforward_char and Fbackward_char, but does so while checking
2498 for integer overflow more accurately.
c96e5d6a 2499 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2500 (Fforward_line, Fend_of_line, internal_self_insert)
2501 (internal_self_insert):
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 Fix a FIXME, by checking for integer overflow when calculating
2504 target_clm and actual_clm.
2505 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2506 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2507 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2508 (coding_alloc_by_making_gap, alloc_destination)
2509 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2510 (encode_coding_utf_16, detect_coding_emacs_mule)
2511 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2512 (detect_coding_iso_2022, decode_coding_iso_2022)
2513 (encode_invocation_designation, encode_designation_at_bol)
2514 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2515 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2516 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2517 (encode_coding_ccl, encode_coding_raw_text)
2518 (detect_coding_charset, decode_coding_charset)
2519 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2520 (produce_composition, produce_charset, produce_annotation)
2521 (decode_coding, handle_composition_annotation)
2522 (handle_charset_annotation, consume_chars, decode_coding_gap)
2523 (decode_coding_object, encode_coding_object, detect_coding_system)
2524 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2525 (code_convert_region, code_convert_string)
8f50130c
PE
2526 (Fdefine_coding_system_internal)
2527 (coding_set_source, coding_set_destination):
d311d28c
PE
2528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2529 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2530 (Fdefine_coding_system_internal):
2531 Don't assume fixnums fit in int.
2532 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2533 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2534 (Funencodable_char_position, Fcheck_coding_systems_region)
2535 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2537 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2538 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2539 Don't access memory outside of the args array.
d311d28c 2540 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2541 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2542 result of ENCODE_CHAR.
d311d28c
PE
2543 * coding.h: Adjust decls to match defn changes elsewhere.
2544 (struct coding_system):
2545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2546 * composite.c (get_composition_id, find_composition)
2547 (run_composition_function, update_compositions)
2548 (compose_text, composition_gstring_put_cache)
2549 (composition_gstring_p, composition_gstring_width)
2550 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2551 (composition_compute_stop_pos, composition_reseat_it)
2552 (composition_update_it, struct position_record)
2553 (find_automatic_composition, composition_adjust_point)
2554 (Fcomposition_get_gstring, Ffind_composition_internal):
2555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2556 (update_compositions):
2557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2558 * composite.h: Adjust decls to match defn changes elsewhere.
2559 (struct composition):
2560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2561 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2562 Do not attempt to compute the address of the object just before a
2563 buffer; this is not portable.
2564 (Faref, Faset):
2565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2566 (Faset): Use int, not EMACS_INT, where int is wide enough.
2567 (Fstring_to_number): Don't assume fixnums fit in int.
2568 (Frem): Don't assume arg is nonnegative.
2569 * dbusbind.c (xd_append_arg): Check for integers out of range.
2570 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2571 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2572 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2573 (xd_get_connection_references): Return ptrdiff_t, not int.
2574 All uses changed.
2575 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2576 (xd_read_message_1):
2577 Use int, not unsigned, where the dbus API uses int.
2578 (Fdbus_message_internal): Don't overflow mtype.
2579 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2580 * dired.c (directory_files_internal, file_name_completion, scmp)
2581 (file_name_completion_stat):
2582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2583 (file_name_completion): Don't overflow matchcount.
2584 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2585 * dispextern.h: Adjust decls to match defn changes elsewhere.
2586 (struct text_pos, struct glyph, struct bidi_saved_info)
2587 (struct bidi_string_data, struct bidi_it, struct composition_it)
2588 (struct it):
2589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2590 (struct display_pos, struct composition_it, struct it):
2591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2592 * dispnew.c (increment_matrix_positions)
2593 (increment_row_positions, mode_line_string)
2594 (marginal_area_string):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2596 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2598 (duration_to_sec_usec): New function, to check for overflow better.
2599 (Fsleep_for, sit_for): Use it.
2600 * doc.c (get_doc_string, store_function_docstring):
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 (get_doc_string, Fsnarf_documentation):
2603 Use int, not EMACS_INT, where int is wide enough.
2604 (get_doc_string):
2605 Use SAFE_ALLOCA, not alloca.
2606 Check for overflow when converting EMACS_INT to off_t.
2607 * doprnt.c (doprnt):
2608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2609 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2610 Don't assume uid_t fits into fixnum.
2611 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2612 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2613 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2614 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2615 (general_insert_function)
2616 (Finsert_char, make_buffer_string, make_buffer_string_both)
2617 (update_buffer_properties, Fbuffer_substring)
2618 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2619 (Fsubst_char_in_region, check_translation)
2620 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2621 (transpose_markers, Ftranspose_regions):
2622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2623 (clip_to_bounds): Move to lisp.h as an inline function).
2624 (Fconstrain_to_field): Don't assume integers are nonnegative.
2625 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2626 (Fsubst_char_in_region, Fsave_restriction):
2627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2628 (Femacs_pid): Don't assume pid_t fits into fixnum.
2629 (lo_time): Use int, not EMACS_INT, when int suffices.
2630 (lisp_time_argument): Check for usec out of range.
2631 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2632 (Fuser_login_name, Fuser_full_name): Signal an error
2633 if a uid argument is out of range, rather than relying on
2634 undefined behavior.
c8d5c857
PE
2635 (Fformat_time_string): Remove now-unnecessary check.
2636 lisp_time_argument checks for out-of-range usec now.
243e0530 2637 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2638 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2639 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2640 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2641 (init_cmdargs, Fdump_emacs):
2642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2643 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2644 the bottom (typically) 32 bits of the fixnum.
2645 * eval.c (specpdl_size, call_debugger):
2646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2647 (when_entered_debugger, Fbacktrace_debug):
2648 Don't assume fixnum can fit in int.
2649 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2650 the object just before a buffer; this is not portable.
2651 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2652 (grow_specpdl, unbind_to):
2653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2654 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2655 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2656 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2657 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2658 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2660 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2661 (a_write, e_write):
2662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2663 (Fcopy_file, non_regular_nbytes, read_non_regular)
2664 (Finsert_file_contents):
2665 Use int, not EMACS_INT, where int is wide enough.
2666 (READ_BUF_SIZE): Verify that it fits in int.
2667 (Finsert_file_contents): Check that counts are in proper range,
2668 rather than assuming fixnums fit into ptrdiff_t etc.
2669 Don't assume fixnums fit into int.
125b3835 2670 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2671 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2672 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2673 (string_char_to_byte, string_byte_to_char)
2674 (string_make_multibyte, string_to_multibyte)
2675 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2676 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2677 (substring_both, Fdelete, internal_equal, Ffillarray)
2678 (Fclear_string, mapcar1)
2679 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2680 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2681 (larger_vector, make_hash_table, maybe_resize_hash_table)
2682 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2683 (Fmaphash, secure_hash):
2684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2685 (concat): Check for string index and length overflow.
2686 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2687 (Frequire):
2688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2689 (larger_vector): New API (vec, incr_min, size_max) replaces old
2690 one (vec, new_size, init). This catches size overflow.
2691 INIT was removed because it was always Qnil.
2692 All callers changed.
2693 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2694 the upper bound on a hash table index size.
2695 (make_hash_table, maybe_resize_hash_table): Use it.
2696 (secure_hash): Computer start_byte and end_byte only after
2697 they're known to be in ptrdiff_t range.
2698 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2699 (Ffont_get_glyphs, Ffont_at):
2700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2701 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2702 (Flist_fonts, Fopen_font):
2703 Don't assume fixnum can fit in int.
2704 (check_gstring): Don't assume index can fit in int.
2705 (font_match_p): Check that fixnum is a character, not a nonnegative
2706 fixnum, since the later code needs to stuff it into an int.
2707 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2708 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2709 conversion overflow issues.
2710 (Fopen_font): Check for integer out of range.
2711 (Ffont_get_glyphs): Don't assume index can fit in int.
2712 * font.h: Adjust decls to match defn changes elsewhere.
2713 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2714 integer overflow.
2715 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2716 printmax_t, where ptrdiff_t is wide enough.
2717 (Finternal_char_font):
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2719 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2720 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2721 (Fset_frame_position, x_set_frame_parameters)
2722 (x_set_line_spacing, x_set_border_width)
2723 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2724 Check that fixnums are in proper range for system types.
2725 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2727 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2728 Use SAFE_ALLOCA_LISP, not alloca.
2729 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2730 intptr_t is wide enough.
2731 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2732 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2733 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2734 Check for fixnum out of range.
2735 * ftfont.c (ftfont_list): Don't assume index fits in int.
2736 Check that fixnums are in proper range for system types.
2737 (ftfont_shape_by_flt):
2738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2739 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2741 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2742 Check that fixnums are in proper range for system types.
2743 * gnutls.h: Adjust decls to match defn changes elsewhere.
2744 * gtkutil.c (xg_dialog_run):
2745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2746 (update_frame_tool_bar):
2747 Check that fixnums are in proper range for system types.
2748 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2749 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2750 * indent.c (last_known_column, last_known_column_point):
2751 (current_column_bol_cache):
2752 (skip_invisible, current_column, check_display_width):
2753 (check_display_width, scan_for_column, current_column_1)
2754 (Findent_to, Fcurrent_indentation, position_indentation)
2755 (indented_beyond_p, Fmove_to_column, compute_motion):
2756 (Fcompute_motion, Fvertical_motion):
2757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2758 (last_known_column_modified): Use EMACS_INT, not int.
2759 (check_display_width):
2760 (Fcompute_motion):
2761 Check that fixnums and floats are in proper range for system types.
2762 (compute_motion): Don't assume index or fixnum fits in int.
2763 (compute_motion, Fcompute_motion):
2764 Use int, not EMACS_INT, when it is wide enough.
2765 (vmotion): Omit local var start_hpos that is always 0; that way
2766 we don't need to worry about overflow in expressions involving it.
2767 * indent.h: Adjust decls to match defn changes elsewhere.
2768 (struct position):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2770 Use int, not EMACS_INT, where int is wide enough.
2771 Remove unused members ovstring_chars_done and tab_offset;
2772 all uses removed.
2773 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2774 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2775 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2776 (make_gap, copy_text, insert, insert_and_inherit)
2777 (insert_before_markers, insert_before_markers_and_inherit)
2778 (insert_1, count_combining_before, count_combining_after)
2779 (insert_1_both, insert_from_string)
2780 (insert_from_string_before_markers, insert_from_string_1)
2781 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2782 (adjust_after_replace, adjust_after_insert, replace_range)
2783 (replace_range_2, del_range, del_range_1, del_range_byte)
2784 (del_range_both, del_range_2, modify_region)
2785 (prepare_to_modify_buffer, signal_before_change)
2786 (signal_after_change, Fcombine_after_change_execute):
2787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2788 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2789 (balance_an_interval, split_interval_right, split_interval_left)
2790 (find_interval, next_interval, update_interval)
2791 (adjust_intervals_for_insertion, delete_node, delete_interval)
2792 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2793 (static_offset_intervals, offset_intervals)
2794 (merge_interval_right, merge_interval_left, make_new_interval)
2795 (graft_intervals_into_buffer, temp_set_point_both)
2796 (temp_set_point, set_point, adjust_for_invis_intang)
2797 (set_point_both, move_if_not_intangible, get_property_and_range)
2798 (get_local_map, copy_intervals, copy_intervals_to_string)
2799 (compare_string_intervals, set_intervals_multibyte_1):
2800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2801 * intervals.h: Adjust decls to match defn changes elsewhere.
2802 (struct interval):
2803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2804 * keyboard.c (this_command_key_count, this_single_command_key_start)
2805 (before_command_key_count, before_command_echo_length, echo_now)
2806 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2807 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2808 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2809 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2811 (last_non_minibuf_size, last_point_position, echo_truncate)
2812 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2813 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2814 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2815 (stuff_buffered_input):
2816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2817 (last_auto_save, command_loop_1, read_char):
2818 Use EMACS_INT, not int, to avoid integer overflow.
2819 (record_char): Avoid overflow in total_keys computation.
2820 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2821 * keyboard.h: Adjust decls to match defn changes elsewhere.
2822 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2823 (Fkey_description, Fdescribe_vector, Flookup_key):
2824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2825 (click_position): New function, to check that positions are in range.
2826 (Fcurrent_active_maps):
2827 (describe_command):
2828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2829 (Faccessible_keymaps, Fkey_description):
2830 (preferred_sequence_p):
2831 Don't assume fixnum can fit into int.
2832 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2833 Check for integer overflow in size calculations.
2834 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2835 avoid mishandling large integers.
2836 * lisp.h: Adjust decls to match defn changes elsewhere.
2837 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2838 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2839 (struct Lisp_Marker):
2840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2841 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2842 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2843 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2844 All callers changed.
2845 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2846 Assume the arg has valid form, since it always does.
2847 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2848 unsigned integer system type.
2849 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2850 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2853 (duration_to_sec_usec): New decl.
2854 * lread.c (read_from_string_index, read_from_string_index_byte)
2855 (read_from_string_limit, readchar, unreadchar, openp)
2856 (read_internal_start, read1, oblookup):
2857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2858 (Fload, readevalloop, Feval_buffer, Feval_region):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 (openp): Check for out-of-range argument to 'access'.
2861 (read1): Use int, not EMACS_INT, where int is wide enough.
2862 Don't assume fixnum fits into int.
6efdadfd 2863 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2864 (read_filtered_event): Use duration_to_sec_usec
2865 to do proper overflow checking on durations.
d311d28c
PE
2866 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2867 in size calculation.
2868 (Fexecute_kbd_macro):
2869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2870 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2871 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2872 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2873 (set_marker_both, set_marker_restricted_both, marker_position)
2874 (marker_byte_position, Fbuffer_has_markers_at):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2877 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2878 It now merely ensures that the menu is large enough, without
2879 necessarily growing it, as this avoids some integer overflow issues.
2880 All callers changed.
2881 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2883 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2884 Use SAFE_ALLOCA_LISP, not alloca.
2885 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2886 to EMACS_INT. Check that fixnums are in proper range for system types.
2887 * minibuf.c (minibuf_prompt_width, string_to_object)
2888 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2889 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2891 (get_minibuffer, read_minibuf_unwind):
2892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2893 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2894 this simplifies overflow checking. All callers changed.
2895 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2896 (Ftest_completion):
2897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2898 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2899 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2900 Check that fixnums are in proper range for system types.
2901 (Fx_create_frame, Fx_show_tip):
2902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2903 * nsfont.m (ns_findfonts, nsfont_list_family):
2904 Don't assume fixnum fits in long.
2905 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2907 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2908 wide enough.
17fdb222 2909 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2911 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2912 (PRINTDECLARE, PRINTPREPARE):
2913 (strout, print_string):
2914 (print, print_preprocess, print_check_string_charset_prop)
2915 (print_object):
2916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2917 (PRINTDECLARE):
2918 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2920 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2921 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2922 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2923 (print_error_message): Use SAFE_ALLOCA, not alloca.
2924 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2925 (print_depth, new_backquote_output, print_number_index):
2926 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2927 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2928 (Fset_process_window_size, Fformat_network_address)
2929 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2930 (sigchld_handler):
d311d28c 2931 Check that fixnums are in proper range for system types.
d44287d4 2932 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2933 Check for process-ids out of pid_t range rather than relying on
2934 undefined behavior.
e4d81efc 2935 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2936 (Fformat_network_address, read_process_output, send_process)
2937 (Fprocess_send_region, status_notify):
2938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2939 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2940 (wait_reading_process_output, read_process_output, exec_sentinel):
2941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2942 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2943 (Faccept_process_output): Use duration_to_sec_usec to do proper
2944 overflow checking on durations.
dde14581
PE
2945 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2946 Don't assume pid_t fits in int.
02481186
PE
2947 * process.h (struct Lisp_Process): Members tick and update_tick
2948 are now of type EMACS_INT, not int.
b62b53e8
PE
2949 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2950 configured --with-wide-int.
d311d28c
PE
2951 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2952 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2953 * search.c (looking_at_1, string_match_1):
2954 (fast_string_match, fast_c_string_match_ignore_case)
2955 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2956 (scan_newline, find_before_next_newline, search_command)
2957 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2958 (set_search_regs, wordify):
2959 (Freplace_match):
2960 (Fmatch_data):
2961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2962 (string_match_1, search_buffer, set_search_regs):
2963 (Fmatch_data):
2964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2965 (wordify): Check for overflow in size calculation.
2966 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2967 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2968 Check that fixnums are in proper range for system types.
2969 * sound.c (struct sound_device)
2970 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2972 (Fplay_sound_internal):
2973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2974 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2975 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2976 (Fparse_partial_sexp):
2977 Don't assume fixnums can fit in int.
2978 (struct lisp_parse_state, find_start_pos, find_start_value)
2979 (find_start_value_byte, find_start_begv)
2980 (update_syntax_table, char_quoted, dec_bytepos)
2981 (find_defun_start, prev_char_comend_first, back_comment):
2982 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2983 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2985 (Finternal_describe_syntax_value): Check that match_lisp is a
2986 character, not an integer, since the code stuffs it into int.
2987 (scan_words, scan_sexps_forward):
2988 Check that fixnums are in proper range for system types.
2989 (Fforward_word):
2990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2991 (scan_sexps_forward):
2992 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2993 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2994 * syntax.h: Adjust decls to match defn changes elsewhere.
2995 (struct gl_state_s):
2996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2997 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2998 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2999 * sysdep.c (wait_for_termination_1, wait_for_termination)
3000 (interruptible_wait_for_termination, mkdir):
3001 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3002 (emacs_read, emacs_write):
3003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3004 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3005 and double all fit in int.
d311d28c
PE
3006 * term.c (set_tty_color_mode):
3007 Check that fixnums are in proper range for system types.
3008 * termhooks.h (struct input_event):
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 * textprop.c (validate_interval_range, interval_of)
3011 (Fadd_text_properties, set_text_properties_1)
3012 (Fremove_text_properties, Fremove_list_of_text_properties)
3013 (Ftext_property_any, Ftext_property_not_all)
3014 (copy_text_properties, text_property_list, extend_property_ranges)
3015 (verify_interval_modification):
3016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3017 (Fnext_single_char_property_change)
3018 (Fprevious_single_char_property_change):
3019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3020 (copy_text_properties):
3021 Check for integer overflow in index calculation.
d311d28c
PE
3022 * undo.c (last_boundary_position, record_point, record_insert)
3023 (record_delete, record_marker_adjustment, record_change)
3024 (record_property_change):
3025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3026 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3028 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3029 (Fx_hide_tip, Fx_file_dialog):
3030 * w32menu.c (set_frame_menubar):
3031 Use ptrdiff_t, not int, for consistency with rest of code.
3032 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3033 (select_window, Fdelete_other_windows_internal)
3034 (window_scroll_pixel_based, window_scroll_line_based)
3035 (Frecenter, Fset_window_configuration):
3036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3037 (Fset_window_hscroll, run_window_configuration_change_hook)
3038 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3039 (Fscroll_other_window, Frecenter):
d311d28c
PE
3040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3041 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3042 Don't assume fixnum fits in int.
3043 (Fset_window_scroll_bars):
3044 Check that fixnums are in proper range for system types.
3045 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3046 (string_pos, c_string_pos, number_of_chars, init_iterator)
3047 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3048 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3049 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3050 (face_before_or_after_it_pos, handle_invisible_prop)
3051 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3052 (display_prop_intangible_p, string_buffer_position_lim)
3053 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3054 (get_overlay_strings_1, get_overlay_strings)
3055 (iterate_out_of_display_property, forward_to_next_line_start)
3056 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3057 (get_next_display_element, set_iterator_to_next)
3058 (get_visually_first_element, compute_stop_pos_backwards)
3059 (handle_stop_backwards, next_element_from_buffer)
3060 (move_it_in_display_line_to, move_it_in_display_line)
3061 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3062 (add_to_log, message_dolog, message_log_check_duplicate)
3063 (message2, message2_nolog, message3, message3_nolog
3064 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3065 (current_message_1, truncate_echo_area, truncate_message_1)
3066 (set_message, set_message_1, store_mode_line_noprop)
3067 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3068 (text_outside_line_unchanged_p, check_point_in_composition)
3069 (reconsider_clip_changes)
3070 (redisplay_internal, set_cursor_from_row, try_scrolling)
3071 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3072 (redisplay_window, find_last_unchanged_at_beg_row)
3073 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3074 (trailing_whitespace_p, find_row_edges, display_line)
3075 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3076 (display_mode_element, store_mode_line_string)
3077 (pint2str, pint2hrstr, decode_mode_spec)
3078 (display_count_lines, display_string, draw_glyphs)
3079 (x_produce_glyphs, x_insert_glyphs)
3080 (rows_from_pos_range, mouse_face_from_buffer_pos)
3081 (fast_find_string_pos, mouse_face_from_string_pos)
3082 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3084 (safe_call, init_from_display_pos, handle_fontified_prop)
3085 (handle_single_display_spec, load_overlay_strings)
3086 (with_echo_area_buffer, setup_echo_area_for_printing)
3087 (display_echo_area, echo_area_display)
3088 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3089 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3090 (redisplay_window, dump_glyph_row, display_mode_line)
3091 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3092 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3094 (handle_single_display_spec, build_desired_tool_bar_string)
3095 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3096 (get_specified_cursor_type):
3097 Check that fixnums are in proper range for system types.
3098 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3099 (Flookup_image_map):
3100 Don't assume fixnums fit in int.
3101 (compare_overlay_entries):
3102 Avoid mishandling comparisons due to subtraction overflow.
3103 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3104 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3105 (handle_tool_bar_click):
3106 Use int, not unsigned, since we prefer signed and the signedness
3107 doesn't matter here.
3108 (get_next_display_element, next_element_from_display_vector):
3109 Use int, not EMACS_INT, when int is wide enough.
3110 (start_hourglass): Use duration_to_sec_usec to do proper
3111 overflow checking on durations.
3112 * xfaces.c (Fbitmap_spec_p):
3113 Check that fixnums are in proper range for system types.
3114 (compare_fonts_by_sort_order):
3115 Avoid mishandling comparisons due to subtraction overflow.
3116 (Fx_family_fonts, realize_basic_faces):
3117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3118 (Fx_family_fonts):
3119 Don't assume fixnum fits in int.
3120 Use SAFE_ALLOCA_LISP, not alloca.
3121 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3122 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3123 (face_at_buffer_position, face_for_overlay_string)
3124 (face_at_string_position):
3125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3126 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3127 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3128 (Fx_show_tip):
3129 Check that fixnums are in proper range for system types.
3130 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3131 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3133 (Fx_change_window_property): Don't assume fixnums fit in int.
3134 * xfont.c (xfont_chars_supported):
3135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3136 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3137 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3139 * xml.c (parse_region):
3140 * xrdb.c (magic_file_p):
3141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3142 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3143 (x_get_local_selection, x_reply_selection_request)
3144 (x_handle_selection_request, wait_for_property_change):
3145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3146 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3147 short is wide enough.
3148 (x_send_client_event): Don't assume fixnum fits in int.
3149 * xterm.c (x_x_to_emacs_modifiers):
3150 Don't assume EMACS_INT overflows nicely into int.
3151 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3152 may come from Lisp.
3153 (handle_one_xevent): NATNUMP can eval its arg twice.
3154 (x_connection_closed):
3155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3156 * xterm.h: Adjust decls to match defn changes elsewhere.
3157 (struct scroll_bar): Use struct vectorlike_header
3158 rather than rolling our own approximation.
3159 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3160
c6574eb5
GM
31612012-05-25 Glenn Morris <rgm@gnu.org>
3162
3163 * lisp.mk (lisp): Update for more files being compiled now.
3164
e8d32c7e
SM
31652012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3166
48def666
SM
3167 * lread.c: Remove `read_pure' which makes no difference.
3168 (read_pure): Remove var.
3169 (unreadpure): Remove function.
3170 (readevalloop): Don't call read_list with -1 flag.
3171 (read1, read_vector): Don't test read_pure any more.
3172 (read_list): Simplify.
3173
e8d32c7e
SM
3174 * fileio.c, character.h: Minor style tweaks.
3175
4b2addb7
DA
31762012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3177
3178 * window.h (clip_changed): Remove useless declaration.
3179
584461b2
JB
31802012-05-22 Juanma Barranquero <lekktu@gmail.com>
3181
3182 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3183 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3184
34374650
PE
31852012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3186
3187 Remove src/m/*.
3188 This directory predates autoconf and is no longer needed nowadays.
3189 Move its few remaining bits of functionality to where they're needed.
3190 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3191 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3192 * m/template.h: Remove.
3193 * Makefile.in (M_FILE): Remove. All uses removed.
3194 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3195 * lisp.h (USE_LSB_TAG):
3196 * mem-limits.h (EXCEEDS_LISP_PTR):
3197 Use VAL_MAX, not VALBITS, in #if.
3198 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3199 (EMACS_UINT): Define unconditionally now.
3200 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3201 (BITS_PER_EMACS_INT): New constants, replacing
3202 what used to be in config.h, but not useful in #if.
3203 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3204 define them any more.
3205 (VAL_MAX): New macro.
3206 (VALMASK): Use it.
3207 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3208 BITS_PER_EMACS_INT, in #if.
3209 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3210 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3211 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3212 * s/ms-w32.h (DATA_START):
3213 Move here from removed file m/intel386.h.
3214 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3215 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3216
261cb4bb
PE
32172012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 Assume C89 or later.
3220 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3221 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3222 (xrealloc):
3223 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3224 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3225 * textprop.c, tparam.c (NULL): Remove.
3226 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3227 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3228 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3229 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3230 * xterm.c (input_signal_count): Assume volatile works.
3231
ff23cd9f
KB
32322012-05-21 Ken Brown <kbrown@cornell.edu>
3233
3234 * xgselect.c (xg_select): Fix first argument in call to 'select'
3235 (bug#11508).
3236
1b170bc6
KB
32372012-05-20 Ken Brown <kbrown@cornell.edu>
3238
3239 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3240 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3241
b2f4d39f
KB
32422012-05-19 Ken Brown <kbrown@cornell.edu>
3243
3244 * xfns.c (x_in_use): Remove `static' qualifier.
3245 * xterm.h (x_in_use): Declare.
3246 * xgselect.c: Include xterm.h.
3247 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3248 and `display_arg' (bug#9754).
3249
003fdae2
PE
32502012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3251
9232a6d9
PE
3252 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3253
003fdae2
PE
3254 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3255 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3256
784b56e2
EZ
32572012-05-18 Eli Zaretskii <eliz@gnu.org>
3258
3259 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3260
3261 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3262 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3263
3264 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3265 reference to image_cache->refcount.
3266 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3267
a0a79cde
JL
32682012-05-17 Juri Linkov <juri@jurta.org>
3269
3270 * search.c (Fword_search_regexp, Fword_search_backward)
3271 (Fword_search_forward, Fword_search_backward_lax)
3272 (Fword_search_forward_lax): Move functions to isearch.el
3273 (bug#10145, bug#11381).
3274
b0572523
PE
32752012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3276
3277 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3278
9660f5fc
SM
32792012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3280
3281 * lread.c (init_obarray): Declare Qt and Qnil as special.
3282
4374de83
GM
32832012-05-14 Glenn Morris <rgm@gnu.org>
3284
3285 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3286 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3287
dc44c39a
PE
32882012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3289
078c97cb
PE
3290 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3291
dc44c39a
PE
3292 * unexaix.c: Port to more-recent AIX compilers.
3293 (report_error, report_error_1, make_hdr, copy_sym)
3294 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3295 Make arguments const char *, not char *, to avoid violations of C
3296 standard and to fix some AIX warnings reported by Gilles Pion.
3297
e18afed7 32982012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3299
3300 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3301 already have overlays loaded.
3302 (handle_single_display_spec): Before returning without displaying
3303 fringe bitmap, synchronize the bidi iterator with the main display
3304 iterator, by calling iterate_out_of_display_property.
3305 (iterate_out_of_display_property): Detect buffer iteration by
3306 testing that it->string is a Lisp string.
3307 (get_next_display_element): When the current object is exhausted,
3308 and there's something on it->stack, call set_iterator_to_next to
3309 proceed with what's on the stack, instead of returning zero.
3310 (set_iterator_to_next): If called at the end of a Lisp string,
3311 proceed to consider_string_end without incrementing string
3312 position. Don't increment display vector index past the end of
3313 the display vector. (Bug#11417)
c8fb9dc6
EZ
3314 (pos_visible_p): Don't report a position visible when move_it_to
3315 stopped at the last line of window, which happens to be scanned
3316 backwards by the bidi iteration. (Bug#11464)
ac268e67 3317
e18afed7 33182012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3319
3320 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3321 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3322 are on a TTY, and thus unable to display on the fringes.
3323 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3324 so we need to signal to the caller that this is a "replacing"
3325 display spec. This fixes display when the spec is invalid or we
3326 are on a TTY.
3327
e18afed7 33282012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3329
3330 * unexaix.c (make_hdr): Fix typo in prototype.
3331 This bug broke the build on AIX. Problem reported by Gilles Pion.
3332
9d0a235a
MA
33332012-05-14 Michael Albinus <michael.albinus@gmx.de>
3334
3335 * keyboard.c (kbd_buffer_get_event): Read special events also in
3336 batch mode. (Bug#11415)
3337
9e6b06ed
GM
33382012-05-12 Glenn Morris <rgm@gnu.org>
3339
3340 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3341
c1a1d7a3
EZ
33422012-05-12 Eli Zaretskii <eliz@gnu.org>
3343
3344 * lisp.mk (lisp): Add newcomment.elc.
3345
3fe7cdc8
GM
33462012-05-12 Glenn Morris <rgm@gnu.org>
3347
3348 * Makefile.in (MKDIR_P): New, set by configure.
3349 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3350
53f7d2c0
PE
33512012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3352
3353 Remove unused function hourglass_started.
3354 * dispextern.h (hourglass_started):
3355 * w32fns.c (hourglass_started):
3356 * xdisp.c (hourglass_started): Remove.
3357
75aafb17
JB
33582012-05-10 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3361 Update dependencies.
3362
12959e8e
PE
33632012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3364
97107e2e
PE
3365 * xgselect.c (xg_select): Put maxfds+1 into a var.
3366 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3367
12959e8e
PE
3368 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3369
836d29b3
DA
33702012-05-10 Dave Abrahams <dave@boostpro.com>
3371
3372 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3373 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3374
5cb67954
MA
33752012-05-09 Michael Albinus <michael.albinus@gmx.de>
3376
3377 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3378 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3379 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3380 Initialize xd_registered_buses.
3381
3478ec45
PE
33822012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3383
b263a6b0
PE
3384 Untag more efficiently if USE_LSB_TAG.
3385 This is based on a proposal by YAMAMOTO Mitsuharu in
3386 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3387 For an admittedly artificial (nth 8000 longlist) benchmark on
3388 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3389 Emacs's overall text size by 1%.
3390 * lisp.h (XUNTAG): New macro.
3391 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3392 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3393 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3394 * eval.c (Fautoload):
3395 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3396 * frame.h (XFRAME): Use XUNTAG.
3397
3478ec45
PE
3398 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3399 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3400 Remove unportable assumptions about print widths of types like
3401 dbus_uint32_t.
3402 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3403 intptr_t when converting between pointer and integer, to avoid GCC
3404 warnings about wrong width.
3405
666b903b 34062012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3407
3408 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3409 stack for each reader_thread, instead of defaulting to 8MB
3410 determined by the linker. This avoids failures in creating
3411 subprocesses on Windows 7, see the discussion in this thread:
3412 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3413
b120cc17
JC
34142012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3415
3416 Fix up display of the *Minibuf-0* buffer in the mini window.
3417 * keyboard.c (read_char): Don't clear the echo area if there's no
3418 message to clear.
3419 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3420 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3421
9a4b36f8
MA
34222012-05-07 Michael Albinus <michael.albinus@gmx.de>
3423
3424 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3425 batch mode.
3426
e5f9458f
CY
34272012-05-06 Chong Yidong <cyd@gnu.org>
3428
3429 * lisp.mk (lisp): Update.
3430
eceeb5fc 34312012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3432
3433 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3434
71873e2b
SM
34352012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3436
3437 * data.c (PUT_ERROR): New macro.
3438 (syms_of_data): Use it. Add new error type `user-error'.
3439 * undo.c (user_error): New function.
3440 (Fprimitive_undo): Use it.
3441 * print.c (print_error_message): Adjust print style for `user-error'.
3442 * keyboard.c (user_error): New function.
3443 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3444
ab0fa4e4
PE
34452012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 Do not limit current-time-string to years 1000..9999.
3448 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3449 (Fcurrent_time_string): Support any year that is supported by the
3450 underlying localtime representation. Don't use asctime, as it
3451 has undefined behavior for years outside the range -999..9999.
3452
7ed806a7
PE
34532012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 Fix race conditions involving setenv, gmtime, localtime, asctime.
3456 Without this fix, interrupts could mess up code that uses these
3457 nonreentrant functions, since setting TZ invalidates existing
3458 tm_zone or tzname values, and since most of these functions return
3459 pointers to static storage.
3460 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3461 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3462 Grow the critical sections to include not just invoking
3463 localtime/gmtime, but also accessing these functions' results
3464 including their tm_zone values if any, and any related TZ setting.
3465 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3466 so that the struct tm is saved in the critical section.
3467 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3468 motivated by the fact that memory allocation needs to be outside
3469 the critical section.
3470
0c16dfed
DA
34712012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3472
3473 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3474 with RESET_INTERVAL.
3475
3476 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3477 Remove duplicated buffer name initialization.
3478
3f83ace8
JM
34792012-05-02 Jim Meyering <jim@meyering.net>
3480
3481 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3482
c7b8541e
JM
3483 * xfns.c (x_window): Use xstrdup (Bug#11375).
3484
90207a15 34852012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3486
3487 * xdisp.c (pos_visible_p): If already at a newline from the
3488 display string before the 'while' loop, don't walk back the glyphs
3489 from it3.glyph_row. Solves assertion violation when the display
3490 string begins with a newline (egg.el). (Bug#11367)
3491
b593d6a9
AH
34922012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3493
3494 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3495 Move to simple.el.
3496
4737362e
GM
34972012-05-01 Glenn Morris <rgm@gnu.org>
3498
99cf43f9
GM
3499 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3500 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3501 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3502 All were removed before 23.1.
3503
9311dcff
GM
3504 * dispnew.c: Remove HAVE_LIBNCURSES test;
3505 it is always true on relevant platforms.
3506
4d5c6349
GM
3507 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3508 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3509
4737362e
GM
3510 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3511
74dd3a6b
AS
35122012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3513
3514 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3515 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3516 Remove.
3517
13c379ee
PE
35182012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 Do not avoid creating empty evaporating overlays (Bug#9642).
3521 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3522 That is, do not delete an evaporating overlay if it becomes
3523 empty after its bounds are adjusted to fit within its buffer.
3524 This fix caused other problems, and I'm reverting it until we get
3525 to the bottom of them.
3526
a8e7d6d7 35272012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3528
3529 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3530
a8e7d6d7 35312012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3532
3533 * xdisp.c (pos_visible_p): If the window start position is beyond
3534 ZV, start the display from buffer beginning. Prevents assertion
3535 violation in init_iterator when the minibuffer window is scrolled
3536 via the scroll bar.
3537
3538 * window.c (window_scroll_pixel_based): Likewise.
3539
a8e7d6d7 35402012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3541
3542 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3543
a8e7d6d7 35442012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3545
3546 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3547 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3548
a8e7d6d7 35492012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3550
b593d6a9
AH
3551 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3552 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3553
1c6900d9
EZ
35542012-04-26 Eli Zaretskii <eliz@gnu.org>
3555
4c3fa1d9
EZ
3556 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3557 display element, check also the underlying string or buffer
3558 character. (Bug#11341)
3559
1c6900d9
EZ
3560 * w32menu.c: Include w32heap.h.
3561 (add_menu_item): If the call to AppendMenuW (via
3562 unicode_append_menu) fails, disable Unicode menus only if we are
3563 running on Windows 9X/Me.
3564
42bf8205
AS
35652012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3568 (xgetint): Add missing shift for LSB tags.
3569
b1bac16e
MR
35702012-04-24 Martin Rudalics <rudalics@gmx.at>
3571
3572 * keyboard.c (read_char): Don't wipe echo area for select window
3573 events: These might get delayed via `mouse-autoselect-window'
3574 (Bug#11304).
3575
d69621cc
JB
35762012-04-24 Juanma Barranquero <lekktu@gmail.com>
3577
3578 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3579 manipulation of :loaded-from data.
3580
02fd101b
JB
35812012-04-23 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3584 now a cons (bug#11311).
3585
888bec30
PE
35862012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3587
89a438bd
PE
3588 Do not create empty overlays with the evaporate property (Bug#9642).
3589 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3590 if it becomes empty after its bounds are adjusted to fit within
3591 its buffer. Without this fix, in a nonempty buffer (let ((o
3592 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3593 yields an empty overlay that has the evaporate property, which is
3594 not supposed to happen.
3595
1068fe4d
PE
3596 Fix minor GTK3 problems found by static checking.
3597 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3598 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3599 (struct _EmacsFixedClass, emacs_fixed_get_type):
3600 Move decls here from emacsgtkfixed.h, since they needn't be public.
3601 (emacs_fixed_get_type): Now static.
3602 (emacs_fixed_class_init): Omit unused local.
3603 (emacs_fixed_child_type): Remove; unused.
3604 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3605 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3606 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3607 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3608 (EMACS_FIXED_GET_CLASS): Remove; unused.
3609 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3610
888bec30
PE
3611 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3612 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3613
de85e130
PE
36142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3615
d0baac98 3616 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3617 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3618 (__malloc_size_t, __malloc_ptrdiff_t):
3619 Remove. All uses removed, replaced by the definiens if needed,
3620 since we can assume C89 or better now.
3621 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3622 (protect_malloc_state, align, get_contiguous_space)
3623 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3624 (malloc_atfork_handler_child, malloc_enable_thread)
3625 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3626 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3627 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3628 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3629 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3630 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3631 Define using prototypes, not old style.
3632 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3633 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3634 (align): Don't assume that signed integer overflow wraps around.
3635 Omit unused local var.
3636 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3637 (_free_internal_nolock, memalign, mallochook, reallochook):
3638 Omit no-longer-needed casts.
3639 (valloc): Use getpagesize, not __getpagesize.
3640 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3641 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3642
de85e130
PE
3643 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3644
dcbf5805
MA
36452012-04-22 Michael Albinus <michael.albinus@gmx.de>
3646
3647 Move functions from C to Lisp. Make non-blocking method calls
3648 the default. Implement further D-Bus standard interfaces.
3649
3650 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3651 (QCdbus_request_name_allow_replacement)
3652 (QCdbus_request_name_replace_existing)
3653 (QCdbus_request_name_do_not_queue)
3654 (QCdbus_request_name_reply_primary_owner)
3655 (QCdbus_request_name_reply_in_queue)
3656 (QCdbus_request_name_reply_exists)
3657 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3658 (QCdbus_registered_serial, QCdbus_registered_method)
3659 (QCdbus_registered_signal): New Lisp objects.
3660 (XD_DEBUG_MESSAGE): Use sizeof.
3661 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3662 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3663 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3664 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3665 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3666 (xd_signature, xd_append_arg): Allow float for integer types.
3667 (xd_get_connection_references): New function.
b593d6a9
AH
3668 (xd_get_connection_address): Rename from xd_initialize.
3669 Return cached address.
dcbf5805
MA
3670 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3671 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3672 level.
3673 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3674 Return number of refcounts.
dcbf5805
MA
3675 (Fdbus_get_unique_name): Make stronger parameter check.
3676 (Fdbus_message_internal): New defun.
3677 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3678 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3679 (Fdbus_send_signal, Fdbus_register_service)
3680 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3681 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3682 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3683 (Vdbus_compiled_version, Vdbus_runtime_version)
3684 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3685 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3686 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3687 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3688 Adapt docstring.
dcbf5805 3689
52828e02
PE
36902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3691
da05bc4c
PE
3692 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3693 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3694 Do not assume ptrdiff_t is the same width as 'int'.
3695
52828e02
PE
3696 * alloc.c: Handle unusual debugging option combinations.
3697 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3698 since the two debugging options are incompatible.
3699 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3700 is defined.
3701 (mem_init, mem_insert, mem_insert_fixup):
3702 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3703 (NEED_MEM_INSERT): Remove; no longer needed.
3704
f01769f9
LL
37052012-04-22 Leo Liu <sdl.web@gmail.com>
3706
3707 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3708
5790543d
PE
37092012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3710
3711 * sysdep.c [__FreeBSD__]: Minor cleanups.
3712 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3713 Use Emacs indenting style more consistently. Avoid some casts.
3714 Use 'double' consistently rather than mixing 'float' and 'double'.
3715
b91b7e4d
EW
37162012-04-21 Eduard Wiebe <usenet@pusto.de>
3717
b593d6a9
AH
3718 * sysdep.c (list_system_processes, system_process_attributes):
3719 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3720
6114eb15
AS
37212012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3722
3723 * lisp.mk (lisp): Update.
3724
2f38dff7
PE
37252012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3728 It is never used otherwise.
3729
4ae29f89
SM
37302012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3731
3732 * print.c (print_preprocess): Only check print_depth if print-circle
3733 is nil.
3734 (print_object): Check for cycles even when print-circle is nil and
3735 print-gensym is t, but only check print_depth if print-circle is nil.
3736
f30d612a
CY
37372012-04-20 Chong Yidong <cyd@gnu.org>
3738
3739 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3740 set the status to "failed" and ensure that sentinel is run.
3741
c07a4c0b 37422012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3743
3744 * process.c (Fset_process_inherit_coding_system_flag)
3745 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3746 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3747
c07a4c0b 37482012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3749
3750 * xdisp.c (string_buffer_position_lim): Limit starting position to
3751 BEGV.
3752 (set_cursor_from_row): If called for a mode-line or header-line
3753 row, return zero immediately.
3754 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3755 farther than the first row after the header line, if any.
3756 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3757 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3758
c07a4c0b 37592012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3760
4ae29f89
SM
3761 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3762 (bug#11238).
ad3a2b41 3763
c07a4c0b 37642012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 37652012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3766
3767 configure: new option --enable-gcc-warnings (Bug#11207)
3768 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3769 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3770 (ALL_CFLAGS): Use new macros rather than old.
3771 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3772 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3773 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3774 -Wunused-result, -Wunused-variable. This should go away once
3775 the Emacs and Gnulib regex code is merged.
3776 (xmalloc, xrealloc): Now static.
3777
aba027e8
PE
37782012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3779
3780 * dired.c (Fsystem_groups): Remove unused local.
3781
e5a36063
GM
37822012-04-17 Glenn Morris <rgm@gnu.org>
3783
3784 * dired.c (Fsystem_users): Doc fix.
3785
316411f0
DA
37862012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3787
3788 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3789 (syms_of_dired): Add them.
3790
9426aba4
PE
37912012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3792
b62a57be
PE
3793 Fix minor alloc.c problems found by static checking.
3794 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3795 New extern decls, to avoid calling undeclared functions.
3796 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3797 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3798 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3799 (NEED_MEM_INSERT): New macro.
3800 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3801 Remove one incorrect comment and fix another.
b62a57be 3802
3539f31f
PE
3803 Fix minor ralloc.c problems found by static checking.
3804 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3805 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3806 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3807 (r_alloc_sbrk): Now static.
3808
a041960a
PE
3809 Improve ralloc.c interface checking.
3810 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3811 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3812 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3813 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3814 [REL_ALLOC]: ... to here, to check interface.
3815 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3816 Remove decls. This fixes an "It stinks!".
3817
9426aba4
PE
3818 * alloc.c (which_symbols): Fix alignment issue / type clash.
3819
d55c12ed
AS
38202012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3821
3822 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3823 (struct Lisp_Misc_Any): Likewise.
3824 (struct Lisp_Free): Likewise.
3825 * alloc.c (union aligned_Lisp_Symbol): Define.
3826 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3827 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3828 (union aligned_Lisp_Misc): Define.
3829 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3830 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3831 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3832
b948ce8b
PE
38332012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3836 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3837 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3838 * s/netbsd.h, s/sol2-6.h:
3839 Remove definition of GC_MARK_STACK, since the default now works.
3840 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3841 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3842 no longer the default.
3843 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3844
35dc09a1 38452012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3846
35dc09a1
GM
3847 * lread.c (lisp_file_lexically_bound_p):
3848 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3849
35dc09a1
GM
38502012-04-14 Eli Zaretskii <eliz@gnu.org>
3851
3852 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3853 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3854
38552012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3856
3857 * nsterm.m (constrainFrameRect): Always constrain when there is only
3858 one screen (Bug#10962).
3859
bcd86815
KB
38602012-04-13 Ken Brown <kbrown@cornell.edu>
3861
3862 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3863
c25df26e
RT
38642012-04-13 Reuben Thomas <rrt@sc3d.org>
3865
3866 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3867
0fc59f1e
DC
38682012-04-11 Daniel Colascione <dancol@dancol.org>
3869
3870 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3871 against is gone. It's better to use vfork now so that when Cygwin
3872 gains a new, working vfork, we use it automatically (bug#10398).
3873
de8c03dc
SM
38742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3875
3876 * window.c (save_window_save): Obey window-point-insertion-type.
3877
2f097256
GM
38782012-04-11 Glenn Morris <rgm@gnu.org>
3879
3880 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3881
453b951e
SM
38822012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3883
3884 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3885
75f1671a 38862012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3887
3888 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3889 (force_quit_count): New var.
3890 (handle_interrupt): Use it.
3891
2a8ce227
JB
38922012-04-10 Juanma Barranquero <lekktu@gmail.com>
3893
3894 * w32.c (w32_delayed_load): Record the full path of the library
3895 being loaded (bug#10424).
3896
935396c0
GM
38972012-04-09 Glenn Morris <rgm@gnu.org>
3898
05920a43
GM
3899 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3900 not just in the obarray, before snarfing them. (Bug#11036)
3901
935396c0
GM
3902 * Makefile.in ($(leimdir)/leim-list.el):
3903 Pass EMACS rather than BUILT_EMACS.
3904
a18ecafa
TZ
39052012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3906
3907 * process.c (make_process):
3908 * process.h: Add integer `gnutls_handshakes_tried' member to
3909 process struct.
3910
6bbef4e5
JC
3911 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3912 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3913
3914 * gnutls.c (gnutls_log_function2i): Convenience log function.
3915 (emacs_gnutls_read): Use new log functions,
3916 `gnutls_handshakes_tried' process member, and
3917 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3918 attempts per process (connection).
3919
b4d3bc10
CY
39202012-04-09 Chong Yidong <cyd@gnu.org>
3921
3922 * eval.c (Fuser_variable_p, user_variable_p_eh)
3923 (lisp_indirect_variable): Functions deleted.
3924 (Fdefvar): Caller changed.
3925
3926 * callint.c (Finteractive, Fcall_interactively):
3927 * minibuf.c (Fread_variable): Callers changed.
3928
70f4d973
EZ
39292012-04-09 Eli Zaretskii <eliz@gnu.org>
3930
3931 * xdisp.c (set_cursor_from_row): If the display string appears in
3932 the buffer at position that is closer to point than the position
3933 after the display string, display the cursor on the first glyph of
3934 the display string. Fixes cursor display when a 'display' text
3935 property immediately follows invisible text. (Bug#11094)
3936
cb3c2e3e
PE
39372012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 composite.c: use 'double' consistently
3940 * composite.c (get_composition_id): Use 'double' consistently
3941 instead of converting 'float' to 'double' and vice versa; this is
3942 easier to understand and avoids a GCC warning.
3943
fd06db5d
GM
39442012-04-09 Glenn Morris <rgm@gnu.org>
3945
50fe702a
GM
3946 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3947 preparation for dumping it with emacs. (Bug#4789)
3948 (leimdir): New variable.
3949 ($(leimdir)/leim-list.el): New rule.
3950 (emacs$(EXEEXT)): Depend on leim-list.el.
3951
fd06db5d
GM
3952 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3953 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3954 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3955
55c131ee
AS
39562012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3957
3958 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3959 proper alignment.
3960
9209588f
JB
39612012-04-07 Juanma Barranquero <lekktu@gmail.com>
3962
3963 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3964 Remove unused local variable.
3965
e3fb2efb
PE
39662012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3967
3968 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3969 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3970 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3971 objects, as mark_maybe_pointer will catch them otherwise.
3972 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3973 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3974
b5385551
PE
39752012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3976
3977 Fix typo that broke non-Windows builds.
3978 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3979
9078ead6
EZ
39802012-04-07 Eli Zaretskii <eliz@gnu.org>
3981
3982 Support building on MS-Windows with libxml2.
3983
3984 * makefile.w32-in (OBJ2): Add xml.$(O).
3985 (GLOBAL_SOURCES): Add xml.c.
3986 ($(BLD)/xml.$(O)): New dependency list.
3987
3988 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3989 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3990 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3991 [!WINDOWSNT]: New macros.
3992 (init_libxml2_functions, libxml2_loaded_p): New functions.
3993 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3994 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3995 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3996 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3997 linked in).
6bbef4e5
JC
3998 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3999 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4000 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4001
4002 * emacs.c: Don't include libxml/parser.h.
4003 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4004 xmlCleanupParser directly.
4005
4006 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4007
3811fdf3
EZ
40082012-04-07 Eli Zaretskii <eliz@gnu.org>
4009
4010 * indent.c (Fvertical_motion): If there is a display string at
4011 point, use it.vpos to compute how many lines to backtrack after
4012 move_it_to point. (Bug#11133)
4013
2f8e16b2
EZ
40142012-04-06 Eli Zaretskii <eliz@gnu.org>
4015
4016 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4017 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4018 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4019 macros related to unification of CJK characters. For the details,
4020 see the discussion following the message here:
4021 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4022
3d439cd1
CY
40232012-04-04 Chong Yidong <cyd@gnu.org>
4024
4025 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4026
8bc53d00
EZ
40272012-04-01 Eli Zaretskii <eliz@gnu.org>
4028
4029 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4030 instead of alloca. (Bug#11138)
4031
3b0512a3
AS
40322012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4033
4034 * w32menu.c (is_simple_dialog): Properly check lisp types.
4035 (Bug#11141)
4036
8427ddd2
EZ
40372012-03-31 Eli Zaretskii <eliz@gnu.org>
4038
979022ef
EZ
4039 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4040 position we get to after a call to move_it_to fails the
4041 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4042 only if we wind up in a string from display property. (Bug#11063)
4043
a6b1c7cc
EZ
4044 * window.c (Fdelete_other_windows_internal): Invalidate the row
4045 and column information about mouse highlight, so that redisplay
4046 restores it after reallocating the glyph matrices. (Bug#7464)
4047
8427ddd2
EZ
4048 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4049 string comes from a `display' text property, use the buffer
4050 position of that property as if we actually saw that position in
4051 the row's glyphs.
697ba24b
EZ
4052 (move_it_by_lines): Remove the assertion that
4053 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4054 violated when there's a before-string at the beginning of a line.
4055 (Bug#11063)
8427ddd2 4056
65a0a738
EZ
40572012-03-30 Eli Zaretskii <eliz@gnu.org>
4058
4059 * xdisp.c (append_space_for_newline): If the default face was
4060 remapped, use the remapped face for the appended newline.
4061 (extend_face_to_end_of_line): Use the remapped default face for
4062 extending the face to the end of the line.
4063 (display_line): Call extend_face_to_end_of_line when the default
4064 face was remapped. (Bug#11068)
4065
581355cc
EZ
40662012-03-29 Eli Zaretskii <eliz@gnu.org>
4067
4068 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4069
e8fc049f
SM
40702012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4071
4072 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4073
4fb9a543
GM
40742012-03-27 Glenn Morris <rgm@gnu.org>
4075
4076 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4077 Doc fixes.
4078
679910f1
KH
40792012-03-26 Kenichi Handa <handa@m17n.org>
4080
4081 * dispextern.h (struct glyph): Fix previous change. Change the
4082 bit length of glyphless.ch to 25 (Bug#11082).
4083
90d49b7f
CY
40842012-03-26 Chong Yidong <cyd@gnu.org>
4085
4086 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4087 (command_loop_1): Use it; inhibit selection update for
4088 handle-select-window too (Bug#8996).
4089
f514f6f0
FP
40902012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4091
e8fc049f 4092 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4093
bf43fa51
KH
40942012-03-25 Kenichi Handa <handa@m17n.org>
4095
4096 * dispextern.h (struct glyph): Change the bit length of
4097 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4098
8a0c01dd
EZ
40992012-03-24 Eli Zaretskii <eliz@gnu.org>
4100
4101 * s/ms-w32.h (tzname): Include time.h before redirecting to
4102 _tzname. Fixes the MSVC build. (Bug#9960)
4103
7d1c3a76
AS
41042012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4105
8ed79523
AS
4106 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4107 characters.
4108
7d1c3a76
AS
4109 * xterm.c (XTread_socket): Only modify handling_signal if
4110 !SYNC_INPUT. (Bug#11080)
4111
e99a9b8b
EZ
41122012-03-23 Eli Zaretskii <eliz@gnu.org>
4113
4114 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4115 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4116 when fetching a multibyte character consumes more bytes than
4117 CHAR_BYTES returns, due to unification of CJK characters in
4118 string_char. (Bug#11073)
4119
5063c0e1
TN
41202012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4121
4122 * process.c (wait_reading_process_output): Handle pty disconnect
4123 by refraining from sending oneself a SIGCHLD (bug#10933).
4124
9f851fbd
CY
41252012-03-22 Chong Yidong <cyd@gnu.org>
4126
4127 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4128
5063c0e1 4129 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4130 Mark string as coming from a prefix property.
4131 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4132 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4133
fb5b8aca
CY
41342012-03-21 Chong Yidong <cyd@gnu.org>
4135
4136 * xfaces.c (Vface_remapping_alist): Doc fix.
4137
62356a1b
EZ
41382012-03-20 Eli Zaretskii <eliz@gnu.org>
4139
4140 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4141 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4142 Doc fixes.
62356a1b 4143
025de85b
CY
41442012-03-20 Chong Yidong <cyd@gnu.org>
4145
4146 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4147 to reflect default non-nil value of redisplay-dont-pause.
4148
4827f94e
KH
41492012-03-19 Kenichi Handa <handa@m17n.org>
4150
4151 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4152 it fit in a valid range (Bug#11003).
4153
e50a24a2
EZ
41542012-03-18 Eli Zaretskii <eliz@gnu.org>
4155
4156 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4157 that is not from display property, accept the row as a "cursor
4158 row" if one of the string's character has a non-nil `cursor'
4159 property. Fixes cursor positioning when there are newlines in
4160 overlay strings, e.g. in icomplete.el. (Bug#11035)
4161
9af5ed87
PE
41622012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4163
4164 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4165
d1f55f16
CY
41662012-03-12 Chong Yidong <cyd@gnu.org>
4167
4168 * eval.c (inhibit_lisp_code): Rename from
4169 inhibit_window_configuration_change_hook; move from window.c.
4170
4171 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4172 * window.c (run_window_configuration_change_hook)
4173 (syms_of_window): Callers changed.
4174
66c5eebd
CY
41752012-03-11 Chong Yidong <cyd@gnu.org>
4176
413df973
CY
4177 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4178
66c5eebd
CY
4179 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4180
1de11f56
CY
41812012-03-10 Chong Yidong <cyd@gnu.org>
4182
4183 * frame.c (other_visible_frames): Don't assume the selected frame
4184 is visible (Bug#10955).
4185
cae07000
SM
41862012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4187
4188 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4189
89c94350
JD
41902012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4191
4192 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4193 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4194 zero (Bug#10954).
4195
999dd333
GM
41962012-03-03 Glenn Morris <rgm@gnu.org>
4197
01a6dcc8 4198 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4199
de0100f2
EZ
42002012-03-02 Eli Zaretskii <eliz@gnu.org>
4201
4202 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4203 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4204 (redisplay_window, next_element_from_string): Fix typos in
4205 comments.
3e441275
EZ
4206 (redisplay_window): Pass to move_it_vertically the margin in
4207 pixels, not in screen lines.
de0100f2 4208
96a72ee9
GM
42092012-03-02 Glenn Morris <rgm@gnu.org>
4210
4211 * buffer.c (buffer-list-update-hook): Doc fix.
4212
312508d7
EZ
42132012-02-29 Eli Zaretskii <eliz@gnu.org>
4214
4215 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4216 push_it before setting up the iterator for the first overlay
4217 string, even if we have an empty string loaded.
4218 (next_overlay_string): If there's an empty string on the iterator
4219 stack, pop the stack. (Bug#10903)
4220
27f3c637
PE
42212012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4222
4223 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4224 Suggested by Stefan Monnier in
4225 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4226 * alloc.c (widen_to_Lisp_Object): New static function.
4227 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4228 and widening them to Lisp_Objects. This would work even if
4229 USE_LSB_TAG is defined and wide integers are used, which might
4230 happen in a future version of Emacs.
4231
3c9dfce6
CY
42322012-02-25 Chong Yidong <cyd@gnu.org>
4233
fa74b241
CY
4234 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4235 Doc fix.
4236
3c9dfce6
CY
4237 * xselect.c (Fx_selection_exists_p): Doc fix.
4238 (x_clipboard_manager_save_all): Print an informative message
4239 before saving to clipboard manager.
4240
9486df08
CY
42412012-02-24 Chong Yidong <cyd@gnu.org>
4242
4243 * keyboard.c (process_special_events): Handle all X selection
4244 requests in kbd_buffer, not just the next one (Bug#8869).
4245
f01d3321
CY
42462012-02-23 Chong Yidong <cyd@gnu.org>
4247
4248 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4249 call when setting menu-bar-lines and tool-bar-lines parameters.
4250 (unwind_create_frame_1): New helper function.
4251
4252 * window.c (inhibit_window_configuration_change_hook): New var.
4253 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4254 (syms_of_window): Initialize it.
f01d3321 4255
86b847b6
CY
42562012-02-22 Chong Yidong <cyd@gnu.org>
4257
4258 * xterm.c (x_draw_image_relief): Add missing type check for
4259 Vtool_bar_button_margin (Bug#10743).
4260
a59225b1
CY
42612012-02-21 Chong Yidong <cyd@gnu.org>
4262
4263 * fileio.c (Vfile_name_handler_alist): Doc fix.
4264
4265 * buffer.c (Fget_file_buffer): Protect against invalid file
4266 handler return value.
4267
310f5bd4
PE
42682012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4269
cb3a28cc
PE
4270 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4271 when computing $valmask.
4272
310f5bd4
PE
4273 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4274 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4275 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4276 It's useless in that case, and it can cause problems on hosts
4277 that allocate halves of EMACS_INT values separately.
4278 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4279 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4280 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4281 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4282 it avoids undefined behavior on hosts where shifting right by more
4283 than the word width has undefined behavior.
4284
2375c96a
CY
42852012-02-19 Chong Yidong <cyd@gnu.org>
4286
4287 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4288 (Funhandled_file_name_directory, Ffile_name_as_directory)
4289 (Fdirectory_file_name, Fexpand_file_name)
4290 (Fsubstitute_in_file_name): Protect against invalid file handler
4291 return values (Bug#10845).
4292
3eb49e71
EZ
42932012-02-18 Eli Zaretskii <eliz@gnu.org>
4294
4295 * .gdbinit (pitx): Fix incorrect references to fields of the
4296 iterator stack.
4297
7b926f3f
CY
42982012-02-17 Chong Yidong <cyd@gnu.org>
4299
4300 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4301
11273115
PE
43022012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4305 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4306
c3a70e2b
CY
43072012-02-15 Chong Yidong <cyd@gnu.org>
4308
4309 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4310 marked as special. Also, starting docstrings with * is obsolete.
4311
0ca43699
AS
43122012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4313
4314 * gnutls.c (emacs_gnutls_write): Fix last change.
4315
2e8f3c56
LI
43162012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4317
4318 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4319 send_process.
4320
af70074f
SM
43212012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4322
4323 * keymap.c (Fsingle_key_description): Handle char ranges.
4324
95986d52
CY
43252012-02-12 Chong Yidong <cyd@gnu.org>
4326
afd83bd1
CY
4327 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4328 as that creates a dangerous corner case.
4329
95986d52
CY
4330 * window.c (Fdelete_window_internal): Invalidate the mouse
4331 highlight (Bug#9904).
4332
bd7da63e
GM
43332012-02-12 Glenn Morris <rgm@gnu.org>
4334
4335 * xselect.c (Fx_own_selection_internal)
4336 (Fx_get_selection_internal, Fx_disown_selection_internal)
4337 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4338 * nsselect.m (Fx_own_selection_internal)
4339 (Fx_disown_selection_internal, Fx_selection_exists_p)
4340 (Fx_selection_owner_p, Fx_get_selection_internal):
4341 Sync docs and argument specs with the xselect.c versions.
4342
77abcbc2
LI
43432012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4344
4345 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4346
90b671e2
EZ
43472012-02-11 Eli Zaretskii <eliz@gnu.org>
4348
1c0ca0b7
EZ
4349 * w32select.c (Fx_selection_exists_p): Sync doc string and
4350 argument list with xselect.c. (Bug#10783)
4351
4352 * w16select.c (Fx_selection_exists_p): Sync doc string and
4353 argument list with xselect.c. (Bug#10783)
90b671e2 4354
49241268
GM
43552012-02-10 Glenn Morris <rgm@gnu.org>
4356
4357 * fns.c (Fsecure_hash): Doc fix.
4358
f998bbe7 43592012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4360
4361 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4362
0992bd9c
CY
43632012-02-07 Chong Yidong <cyd@gnu.org>
4364
4365 * buffer.c (Fbuffer_local_variables)
4366 (buffer_lisp_local_variables): Handle unbound vars correctly;
4367 don't let Qunbound leak into Lisp.
4368
af008560
GM
43692012-02-07 Glenn Morris <rgm@gnu.org>
4370
dd605cc4
GM
4371 * image.c (Fimagemagick_types): Doc fix.
4372
af008560
GM
4373 * image.c (imagemagick-render-type): Change it from a lisp object
4374 to an integer. Move the doc here from the lisp manual.
4375 Treat all values not equal to 0 the same.
4376
1449fa1d
CY
43772012-02-06 Chong Yidong <cyd@gnu.org>
4378
4379 * doc.c (store_function_docstring): Avoid applying docstring of
4380 alias to base function (Bug#2603).
4381
3723ec07
AS
43822012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4383
4384 * .gdbinit (pp1, pv1): Remove redundant defines.
4385 (pr): Use pp.
4386
79c1cc1e
CY
43872012-02-04 Chong Yidong <cyd@gnu.org>
4388
4389 * nsterm.m: Declare a global (Bug#10694).
4390
d7f29f8e
EZ
43912012-02-04 Eli Zaretskii <eliz@gnu.org>
4392
cae07000
SM
4393 * w32.c (get_emacs_configuration_options):
4394 Include --enable-checking, if specified, in the return value.
d7f29f8e 4395
3b95a6f9
MR
43962012-02-04 Martin Rudalics <rudalics@gmx.at>
4397
4398 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4399 after rounding frame sizes. (Bug#9723)
4400
d6fa96a6
EZ
44012012-02-04 Eli Zaretskii <eliz@gnu.org>
4402
4403 * keyboard.c (adjust_point_for_property): Don't position point
4404 before BEGV. (Bug#10696)
4405
df0b2940
PE
44062012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4407
4408 Handle overflow when computing char display width (Bug#9496).
4409 * character.c (char_width): Return EMACS_INT, not int.
4410 (char_width, c_string_width): Check for overflow when
4411 computing the width; this is possible now that individual
4412 characters can have unbounded width. Problem introduced
4413 by merge from Emacs 23 on 2012-01-19.
4414
6bee44d6
MA
44152012-02-02 Michael Albinus <michael.albinus@gmx.de>
4416
4417 * dbusbind.c (Fdbus_register_method): Mention the return value
4418 :ignore in the docstring.
4419
44f92739
GM
44202012-02-02 Glenn Morris <rgm@gnu.org>
4421
1b9f60cc
GM
4422 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4423
44f92739
GM
4424 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4425 Unconditionally set to t. (Bug#10673)
4426 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4427 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4428 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4429
c5d3843c
KH
44302012-02-02 Kenichi Handa <handa@m17n.org>
4431
4432 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4433 0, do not call append_composite_glyph.
4434
159462d4 44352012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4436
4437 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4438 NULL (Bug#6988).
4439 (x_produce_glyphs): If the component of a composition is a null
4440 string, set it->pixel_width to 1 to avoid zero-width glyph.
4441
78cef877
EZ
44422012-02-01 Eli Zaretskii <eliz@gnu.org>
4443
4444 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4445 first 2 arguments are identical. This makes inserting large
4446 output from a subprocess an order of magnitude faster on
4447 MS-Windows, where all sbrk'ed memory is always contiguous.
4448
97897668
GM
44492012-01-31 Glenn Morris <rgm@gnu.org>
4450
4451 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4452 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4453 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4454
31fd3586
GM
44552012-01-29 Glenn Morris <rgm@gnu.org>
4456
4457 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4458
0e24a8b2
CY
44592012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4460
4461 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4462
cc0adcb0
CY
44632012-01-28 Chong Yidong <cyd@gnu.org>
4464
4465 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4466
acc28cb9
CY
44672012-01-26 Chong Yidong <cyd@gnu.org>
4468
9c69cfb7
CY
4469 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4470
acc28cb9
CY
4471 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4472 repeat counts (Bug#10507).
4473
48da7392
GM
44742012-01-26 Glenn Morris <rgm@gnu.org>
4475
4476 * lread.c (syms_of_lread): Doc fix.
4477
14af5f7f
CY
44782012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4479
4480 * coding.c (encode_designation_at_bol): Change return value to
4481 EMACS_INT.
4482
0b21c100
CY
44832012-01-25 Chong Yidong <cyd@gnu.org>
4484
4485 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4486
3c2907f7
CY
44872012-01-21 Chong Yidong <cyd@gnu.org>
4488
4489 * floatfns.c (Fcopysign): Make the second argument non-optional,
4490 since nil is not allowed anyway.
4491
959ad23f
AS
44922012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4493
4494 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4495 (send_process): Likewise.
4496
34a02f46
MR
44972012-01-19 Martin Rudalics <rudalics@gmx.at>
4498
4499 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4500 (Vwindow_persistent_parameters): Do not use Qstate.
4501 Rewrite doc-strings.
34a02f46 4502
1259009a 45032012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4504
4505 * character.c (char_width): New function.
70d4fdf6
GM
4506 (Fchar_width, c_string_width, lisp_string_width):
4507 Use char_width (Bug#9496).
25ed9e61 4508
6a6ee00d
MR
45092012-01-16 Martin Rudalics <rudalics@gmx.at>
4510
4511 * window.c (Vwindow_persistent_parameters): New variable.
4512 (Fset_window_configuration, save_window_save): Handle persistent
4513 window parameters.
4514
c85efaf7
EZ
45152012-01-14 Eli Zaretskii <eliz@gnu.org>
4516
4517 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4518 thrashing the stack of the thread. (Bug#9087)
4519
5944709e
PE
45202012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4523
e71f5d99
EZ
45242012-01-11 Eli Zaretskii <eliz@gnu.org>
4525
4526 * xdisp.c (rows_from_pos_range): Handle the case where the
4527 highlight ends on a newline. (Bug#10464)
4528 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4529 he end column for display of highlight that ends on a newline
4530 before a R2L line.
4531
ce316182
GM
45322012-01-11 Glenn Morris <rgm@gnu.org>
4533
4534 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4535 from load-path also when installation-directory is nil. (Bug#10208)
4536
5b43da69
GM
45372012-01-10 Glenn Morris <rgm@gnu.org>
4538
74cc8ff9
GM
4539 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4540
7d8d6e4e
GM
4541 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4542 Update template values to be closer to their typical values these days.
5b43da69 4543
a0db8d43
EZ
45442012-01-09 Eli Zaretskii <eliz@gnu.org>
4545
4546 * xdisp.c (rows_from_pos_range): Accept additional argument
4547 DISP_STRING, and accept any glyph in a row whose object is that
4548 string as eligible for mouse highlight. Fixes mouse highlight of
4549 display strings from overlays. (Bug#10464)
4550
9a0115ab 45512012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4552
b9110d6a 4553 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4554 * fileio.c (auto_saving_dir_umask): New static var.
4555 (Fmake_directory_internal): Use it.
4556 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4557 creating the directory. The old code temporarily assigns
4558 too-generous permissions to the directory.
4559 (do_auto_save_eh): Clear it.
b9110d6a 4560 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4561 that the var is always cleared.
4562
6c1bd3f3
EZ
45632012-01-07 Eli Zaretskii <eliz@gnu.org>
4564
4565 * search.c (scan_buffer): Pass character positions to
4566 know_region_cache, not byte positions. (Bug#6540)
4567
069d2b50
L
45682012-01-07 LynX <_LynX@bk.ru> (tiny change)
4569
4570 * w32.c (sys_rename): Report EXDEV when rename of a directory
4571 fails because the target is on another logical disk. (Bug#10284)
4572
75bf0d33
DB
45732012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4574
4575 * xterm.c (x_embed_request_focus): New function.
4576
4577 * xterm.h: Add prototype.
4578
4579 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4580
1c6e5a32
GM
45812012-01-05 Glenn Morris <rgm@gnu.org>
4582
4583 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4584
651e947e
EZ
45852012-01-01 Eli Zaretskii <eliz@gnu.org>
4586
4587 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4588 Load gnutls_transport_set_lowat only if GnuTLS version is below
4589 2.11.1.
4590 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4591 GnuTLS versions below 2.11.1.
4592
3778cdd8
AL
45932011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4594
4595 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4596 to the doc string advising against its use for altering the way
4597 windows are scrolled.
4598
0e5317f7
KH
45992011-12-28 Kenichi Handa <handa@m17n.org>
4600
4601 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4602 coding-system ASCII compatible only when it does not produce BOM
4603 on encoding (Bug#10383).
4604
93d5ca1f
JD
46052011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4606
4607 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4608 can scroll.
4609 (create_and_show_popup_menu): Always use menu_position_func for
4610 Gtk3 (Bug#10361).
4611
ca22b785
AS
46122011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4613
4614 * callint.c (Fcall_interactively): Don't truncate prompt string.
4615
d048e1e6
EZ
46162011-12-23 Eli Zaretskii <eliz@gnu.org>
4617
4618 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4619 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4620 resumed from there (after widening). (Bug#10360)
d048e1e6 4621
5ccaba1f
JD
46222011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4623
4624 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4625
204ee57f
JD
46262011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4627
b81d40f0
JB
4628 * nsterm.m (x_free_frame_resources):
4629 Release f->output_data.ns->miniimage.
204ee57f
JD
4630 (ns_index_color): Fix indentation. Do not retain
4631 color_table->colors[i].
4632
4633 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4634 before returning.
4635
4636 * nsfns.m (x_set_background_color): Assign return value from
4637 ns_index_color to face-background instead of NSColor*.
4638 (ns_implicitly_set_icon_type): Fix indentation.
4639 Change assignment in for loop to comparison.
4640
4641 * emacs.c (ns_pool): New variable.
4642 (main): Assign ns_pool.
4643 (Fkill_emacs): Call ns_release_autorelease_pool.
4644
4645 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4646 autorelease fdesc, release fdAttrs and tdict.
4647 (ns_get_covering_families): Release charset.
4648 (ns_findfonts): Release NSFontDescriptor created with new.
4649 (ns_uni_to_glyphs): Fix indentation.
4650 (setString): Release attrStr before assigning new value.
4651
c803b2b7
JD
46522011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4653
678f4426
JD
4654 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4655 and NS_IMPL_COCOA.
4656 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4657 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4658
cd394be1 46592011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4660
5fecd5fc
JD
4661 * nsterm.m (ns_term_init): Subscribe for notifications
4662 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4663 to method trackingNotification in EmacsMenu.
4664
4665 * nsmenu.m (trackingMenu): New variable.
3771cb17 4666 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4667 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4668 from Aquamacs (Bug#7030).
678f4426
JD
4669
46702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4671
c803b2b7
JD
4672 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4673 (symbol_to_nsstring): Fix indentation.
4674 (ns_symbol_to_pb): New function.
cae07000
SM
4675 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4676 (Fns_rotate_cut_buffers_internal): Remove.
4677 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4678 Fns_store_cut_buffer_internal.
4679 (ns_get_foreign_selection, Fx_own_selection_internal)
4680 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4681 (Fns_get_selection_internal, Fns_store_selection_internal):
4682 Use ns_symbol_to_pb and check if return value is nil.
4683 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4684 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4685 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4686 renamed to Sns_store_selection_internal.
4687 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4688 and remove this function.
4689 (ns_handle_selection_clear): Remove, never used.
4690 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4691 here.
4692
e1b01a3a
KB
46932011-12-17 Ken Brown <kbrown@cornell.edu>
4694
4695 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4696 GID is unknown (Bug#10257).
4697
2adb6e85
PE
46982011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4701 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4702 which caused a build failure on GNU/Linux IA-64. This problem was
4703 introduced by my 2011-10-07 patch.
4704
d1d7b339
JL
47052011-12-15 Juri Linkov <juri@jurta.org>
4706
4707 * image.c (imagemagick_error): New function. (Bug#10112)
4708 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4709 Use `imagemagick_error' where ImageMagick functions return
4710 `MagickFalse'.
4711 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4712 proper order.
4713
100d5755
KH
47142011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4715
4716 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4717 fill background (Bug#8992).
4718
454592a6
MR
47192011-12-13 Martin Rudalics <rudalics@gmx.at>
4720
4721 * window.c (Vwindow_combination_resize)
4722 (Vwindow_combination_limit): Use t instead of non-nil in
4723 doc-strings.
61d4b438
MR
4724 (Vrecenter_redisplay): Add first sentence of doc-string on
4725 separate line.
53524d93 4726 (Frecenter): Fix doc-string typo.
454592a6 4727
3633e3aa
KH
47282011-12-11 Kenichi Handa <handa@m17n.org>
4729
4730 * coding.c (Funencodable_char_position): Pay attention to the
4731 buffer text relocation (Bug#9389).
4732
7b9d523a 47332011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4734
7b9d523a
JD
4735 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4736 gtk_init (Bug#10100).
4737
b73189c6
EZ
47382011-12-10 Eli Zaretskii <eliz@gnu.org>
4739
4740 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4741 IT->string is nil. (Bug#10263)
4742
f7dfe5d6
JD
47432011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4744
83faebb4
JD
4745 * nsterm.h (x_free_frame_resources): Declare.
4746
f7dfe5d6
JD
4747 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4748 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4749
4750 * nsterm.h (ns_get_defaults_value): Declare.
4751
4752 * nsterm.m (ns_default): Call ns_get_defaults_value.
4753
7cd4e72c
EZ
47542011-12-09 Eli Zaretskii <eliz@gnu.org>
4755
4756 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4757 (Bug#10170)
4758
b34d7317
YM
47592011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4760
4761 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4762 that where the value of an _OBJC_* symbol points to is in the .bss
4763 section (Bug#10240).
4764
76470ad1
KH
47652011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4766
4767 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4768 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4769
745fff94
KH
47702011-12-08 Kenichi Handa <handa@m17n.org>
4771
4772 * ftfont.c (get_adstyle_property): Fix previous change
4773 (Bug#10233).
4774
6e44397c
JB
47752011-12-07 Juanma Barranquero <lekktu@gmail.com>
4776
4777 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4778 dirs from the default value of EMACSLOADPATH (bug#10208).
4779
7efa6272
GM
47802011-12-07 Glenn Morris <rgm@gnu.org>
4781
4782 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4783 installation and source directories as well. (Bug#10208)
4784
f6fc4d87
CY
47852011-12-06 Chong Yidong <cyd@gnu.org>
4786
4787 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4788
2bf26180
GM
47892011-12-06 Glenn Morris <rgm@gnu.org>
4790
4791 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4792 as an error, not just -1. (Bug#10217)
4793
3a6ad4f0
CY
47942011-12-05 Chong Yidong <cyd@gnu.org>
4795
4796 * keyboard.c (process_special_events): New function.
4797 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4798
75a3b399
PE
47992011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 * coding.c (encode_designation_at_bol): Don't use uninitialized
4802 local variable (Bug#9318).
4803
c3c9e25e
KH
48042011-12-05 Kenichi Handa <handa@m17n.org>
4805
4806 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4807 return Qnil (Bug#8046, Bug#10193).
4808
5eb05ea3
KH
48092011-12-05 Kenichi Handa <handa@m17n.org>
4810
4811 * coding.c (encode_designation_at_bol): New args charbuf_end and
4812 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4813 (coding_set_source): Return how many bytes coding->source was
4814 relocated.
4815 (coding_set_destination): Return how many bytes
4816 coding->destination was relocated.
4817 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4818 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4819
48202011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4821
4822 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4823 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4824 macro (Bug#9318).
4825
48262011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4827
4828 The following changes are to fix Bug#9318.
4829
a79703f5 4830 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4831 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4832 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4833 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4834
7dbda6df
JB
48352011-12-05 Juanma Barranquero <lekktu@gmail.com>
4836
4837 * lisp.h (process_quit_flag): Fix external declaration.
4838
6d5eb5b0
SM
48392011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4840
4841 Don't macro-inline non-performance-critical code.
4842 * eval.c (process_quit_flag): New function.
4843 * lisp.h (QUIT): Use it.
4844
a0c3fad0
JD
48452011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4846
4847 * nsfns.m (get_geometry_from_preferences): New function.
4848 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4849
6c07aac2
AS
48502011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4851
4852 * emacs.c (Qkill_emacs): Define.
4853 (syms_of_emacs): Initialize it.
4854 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4855 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4856 (quit_throw_to_read_char): Add parameter `from_signal'.
4857 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4858 * lisp.h (QUIT): Call Fkill_emacs if requested.
4859
c052ead4
JD
48602011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4861
4862 * widget.c (update_wm_hints): Return if wmshell is null.
4863 (widget_update_wm_size_hints): New function.
4864
4865 * widget.h (widget_update_wm_size_hints): Declare.
4866
4867 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4868 widget_update_wm_size_hints (Bug#10104).
4869
9e49252b
EZ
48702011-12-03 Eli Zaretskii <eliz@gnu.org>
4871
4872 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4873 before a newline, prepare the bidi iterator for consuming the
4874 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4875 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4876
02b16839
JL
48772011-12-02 Juri Linkov <juri@jurta.org>
4878
4879 * search.c (Fword_search_regexp): New Lisp function created from
4880 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4881 (Fword_search_backward, Fword_search_forward)
4882 (Fword_search_backward_lax, Fword_search_forward_lax):
4883 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4884 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4885
0068070e
SM
48862011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4887
4888 * fileio.c (Finsert_file_contents): Move after-change-function call
4889 to before the "handled:" label, since all "goto handled" appear in
4890 cases where the *-change-functions have already been properly called
4891 (bug#10117).
4892
3360a3fc
AS
48932011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4894
4895 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4896 waiting for input. (Bug#10169)
4897
73d6c093
EZ
48982011-11-30 Eli Zaretskii <eliz@gnu.org>
4899
4900 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4901 verifies glyph row's hash code--we have just reallocated the
4902 glyphs, so their contents can be complete garbage. (Bug#10164)
4903
febe6bea
JB
49042011-11-30 Juanma Barranquero <lekktu@gmail.com>
4905
4906 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4907
801a4313
EZ
49082011-11-30 Eli Zaretskii <eliz@gnu.org>
4909
4910 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4911 attributes are tested _before_ calling verify_row_hash, to protect
4912 against GCC re-ordering of the tests. (Bug#10164)
4913
2b56b87e
JD
49142011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4915
4916 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4917
4918 * xterm.c (handle_one_xevent): Only set async_visible and friends
4919 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4920 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4921 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4922
dbf31225
PE
49232011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4924
4925 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4926 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4927 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4928 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4929 All uses changed to use GCPRO1 etc.
4930 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4931 Revert to old implementation (i.e., before 2011-03-11).
4932
1305621b
YM
49332011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4934
4935 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4936 of scroll runs so as to avoid assigning disabled bogus rows and
4937 unnecessary graphics copy operations.
4938
8c9afb46
EZ
49392011-11-27 Eli Zaretskii <eliz@gnu.org>
4940
4941 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4942 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4943 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4944 (malloc, free, realloc, calloc): Redirect to e_* only when
4945 compiling Emacs.
4946
4947 * lisp.h (GCTYPEBITS): Move before first use.
4948 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4949 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4950 this macro definition.
4951
4952 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4953 _MSC_VER.
4954
54e9e3bf
JD
49552011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4956
6d5eb5b0
SM
4957 * gtkutil.c (xg_create_frame_widgets):
4958 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4959 present with Gtk+ 2.0.
4960
83aca1cb
PE
49612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4962
4963 * fileio.c (Finsert_file_contents): Undo previous change; see
4964 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4965
5b76caa4
PE
49662011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Rename locals to avoid shadowing.
4969 * fileio.c (Finsert_file_contents):
4970 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4971 * process.c (wait_reading_process_output):
4972 Rename inner 'proc' to 'p' to avoid shadowing.
4973 Indent for consistency with usual Emacs style.
4974
8c535114
EZ
49752011-11-25 Eli Zaretskii <eliz@gnu.org>
4976
4977 * xdisp.c (redisplay_window): If cursor row is not fully visible
4978 after recentering, and scroll-conservatively is set to a large
4979 number, scroll window by a few more lines to make the cursor fully
4980 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4981 (start_display): Don't move to the next line if the display should
4982 start at a newline that is part of a display vector or an overlay
4983 string. (Bug#10119)
8c535114 4984
fa4fdb5c
JL
49852011-11-24 Juri Linkov <juri@jurta.org>
4986
4987 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4988 after the `MagickPingImage' call. (Bug#10112)
4989
90ec88df
CY
49902011-11-23 Chong Yidong <cyd@gnu.org>
4991
4992 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4993
56e2e794
MR
49942011-11-23 Martin Rudalics <rudalics@gmx.at>
4995
4996 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4997 making another buffer current. (Bug#10114)
4998
b6e64c41
GM
49992011-11-23 Glenn Morris <rgm@gnu.org>
5000
5001 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5002
6b21de18
CY
50032011-11-23 Chong Yidong <cyd@gnu.org>
5004
5005 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5006 using it (Bug#5984).
5007
b12cd789
EZ
50082011-11-22 Eli Zaretskii <eliz@gnu.org>
5009
5010 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5011 and header-lines, as they don't have one computed for them.
5012 (Bug#10098)
5013
5014 * .gdbinit (prow): Make displayed values more self-explaining.
5015 Add row's hash code.
5016
261b6fd4
LMI
50172011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5018
5019 * process.c (wait_reading_process_output): Fix asynchrounous
5020 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5021 (wait_reading_process_output): Add comment and URL.
261b6fd4 5022
e7cfd277
JD
50232011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5024
5025 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5026
a9b9b7f5
CY
50272011-11-21 Chong Yidong <cyd@gnu.org>
5028
5029 * window.c (Fnext_window, Fprevious_window): Doc fix.
5030
b0d15b4f
SM
50312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5032
5033 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5034
fe7a3057
JB
50352011-11-20 Juanma Barranquero <lekktu@gmail.com>
5036
5037 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5038
d2999b1a
MR
50392011-11-20 Martin Rudalics <rudalics@gmx.at>
5040
5041 * window.c (Fset_window_combination_limit): Rename argument
5042 STATUS to LIMIT.
5043 (Vwindow_combination_limit): Remove "status" from doc-string.
5044
d5ff9cd0
AS
50452011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5046
5047 * m/ibms390.h: Remove.
5048 * m/ibms390x.h: Don't include "ibms390.h".
5049
a5bb9bd3
SM
50502011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5051
5052 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5053 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5054
cd1181db
JB
50552011-11-20 Juanma Barranquero <lekktu@gmail.com>
5056
5057 * casetab.c (Fset_case_table):
5058 * charset.c (Fcharset_after): Fix typos.
5059
615a3b8d 50602011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5061
17e845af
PE
5062 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5063 Otherwise, valgrind does not work on some platforms.
5064 Problem reported by Andreas Schwab in
6a0bf43d
PE
5065 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5066 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5067 is set, removing the need for VIRT_ADDRESS_VARIES.
5068 (PURE_P): Use a more-efficient implementation that needs just one
5069 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5070 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5071 to 4 (xorl, subq, cmpq, setbe).
5072 * alloc.c (pure): Always extern now, since that's the
5073 VIRT_ADDR_VARIES behavior.
5074 (PURE_POINTER_P): Use a single comparison, not two, for
5075 consistency with the new puresize.h.
5076 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5077 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5078 Remove VIRT_ADDR_VARIES no longer needed.
5079
f8fe6f96
EZ
50802011-11-19 Eli Zaretskii <eliz@gnu.org>
5081
5082 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5083 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5084 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5085 behave as if the cursor position were at the window margin.
5086
5087 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5088 and the cursor position is out of bounds, behave as if the cursor
5089 position were at the window margin. (Bug#10075)
5090
df05a53c
CY
50912011-11-18 Chong Yidong <cyd@gnu.org>
5092
5093 * window.c (Fwindow_combination_limit): Make first argument
5094 non-optional, since it is meaningless for live windows like the
5095 selected window.
61ccba97 5096
2071918e
DA
50972011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5098
5099 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5100
b50a28de
SM
51012011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5102
5103 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5104 (graft_intervals_into_buffer): Simplify.
5105
015137db
EZ
51062011-11-18 Eli Zaretskii <eliz@gnu.org>
5107
5108 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5109 hash values of the two rows.
5110 (copy_row_except_pointers): Preserve the used[] arrays and the
5111 hash values of the two rows. (Bug#10035)
68c95424 5112 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5113
5114 * xdisp.c (row_hash): New function, body extracted from
5115 compute_line_metrics.
5116 (compute_line_metrics): Call row_hash, instead of computing the
5117 hash code inline.
5118
5119 * dispnew.c (verify_row_hash): Call row_hash for computing the
5120 hash code of a row, instead of duplicating code from xdisp.c.
5121
5122 * dispextern.h (row_hash): Add prototype.
5123
a2addb04
TH
51242011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5125
5126 * frame.c (delete_frame): Don't delete the terminal when the last
5127 X frame is closed if emacs is built with GTK toolkit.
5128
df85d315
JB
51292011-11-17 Juanma Barranquero <lekktu@gmail.com>
5130
5131 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5132
a0c2d0ae
MR
51332011-11-17 Martin Rudalics <rudalics@gmx.at>
5134
5135 * window.c (Vwindow_splits): Rename to
5136 Vwindow_combination_resize. Suggested by Juri Linkov.
5137 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5138 of Vwindow_splits.
5139
58179cce
JB
51402011-11-16 Juanma Barranquero <lekktu@gmail.com>
5141
7877f373
JB
5142 * nsfns.m (Fns_font_name):
5143 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5144
b6f67890
MR
51452011-11-16 Martin Rudalics <rudalics@gmx.at>
5146
5147 * window.h (window): Rename slot "nest" to "combination_limit".
5148 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5149 (Fset_window_nest): Rename to Fset_window_combination_limit.
5150 (Vwindow_nest): Rename to Vwindow_combination_limit.
5151 (recombine_windows, make_parent_window, make_window)
5152 (Fsplit_window_internal, saved_window)
5153 (Fset_window_configuration, save_window_save): Rename all
5154 occurrences of window_nest to window_combination_limit.
5155
c7015153
JB
51562011-11-15 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * image.c (imagemagick_load_image): Fix typo.
5159
322ad6ec
EZ
51602011-11-14 Eli Zaretskii <eliz@gnu.org>
5161
5162 * xdisp.c (display_line): Move the call to
5163 highlight_trailing_whitespace before the call to
5164 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5165 faces of all the glyphs to compute ROW's hash value.
5166 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5167
f067b8ec
JB
51682011-11-14 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5171 just return (bug#10044).
5172
1e5b2111
EZ
51732011-11-12 Eli Zaretskii <eliz@gnu.org>
5174
7ef3cbd5
EZ
5175 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5176 with user-defined heap size. Bump the default size of the temacs
5177 heap to 27MB, to avoid memory warning when running temacs.
5178 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5179
1e5b2111
EZ
5180 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5181 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5182 (verify_row_hash) [XASSERTS]: New function.
5183 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5184 that the hash value of glyph rows is correct.
1e5b2111 5185
89d61221
MR
51862011-11-12 Martin Rudalics <rudalics@gmx.at>
5187
5188 * window.h (window): Remove splits slot.
5189 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5190 (Fdelete_other_windows_internal, make_parent_window)
5191 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5192 (Fset_window_configuration, save_window_save): Don't deal with
5193 split status of windows.
5194 (saved_window): Remove splits slot.
5195 (Vwindow_splits): Rewrite doc-string.
5196
97f18cc8
JD
51972011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5198
5199 * xfns.c (unwind_create_frame):
5200 * nsfns.m (unwind_create_frame):
5201 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5202 Vframe_list (Bug#9999).
5203
22a648b4
DA
52042011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5205
0b381c7e 5206 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5207
659afede
KH
52082011-11-11 Kenichi Handa <handa@m17n.org>
5209
5210 * callproc.c (Fcall_process): Set the member dst_multibyte of
5211 process_coding.
5212
9ac0394b
KH
52132011-11-11 Johan Bockgård <bojohan@gnu.org>
5214
5215 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5216 avoid a crash (bug#9496).
5217
2fbdc249
CY
52182011-11-09 Chong Yidong <cyd@gnu.org>
5219
5220 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5221 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5222
ac6b1f81
PE
52232011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5226
09db192c
PE
52272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5228
5229 Avoid some portability problems by eschewing 'extern inline' functions.
5230 The trivial performance wins aren't worth the portability hassles; see
5231 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5232 et seq.
5233 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5234 (window_box_width, window_box_left, window_box_left_offset)
5235 (window_box_right, window_box_right_offset): Undo previous change,
5236 by removing the "extern"s.
5237 * intervals.c (adjust_intervals_for_insertion)
5238 (adjust_intervals_for_deletion): Undo previous change,
5239 making these static again.
5240 (offset_intervals, temp_set_point_both, temp_set_point)
5241 (copy_intervals_to_string): No longer inline.
5242 * xdisp.c (window_text_bottom_y, window_box_width)
5243 (window_box_height, window_box_left_offset)
5244 (window_box_right_offset, window_box_left, window_box_right)
5245 (window_box): No longer inline.
5246
105216ed
CY
52472011-11-08 Chong Yidong <cyd@gnu.org>
5248
5249 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5250 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5251 Signal an error if not a live window.
105216ed
CY
5252 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5253 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5254
ae9e237f
JB
52552011-11-07 Juanma Barranquero <lekktu@gmail.com>
5256
5257 * lisp.h (syms_of_abbrev): Remove declaration.
5258 Reported by CHENG Gao <chenggao@royau.me>.
5259
c7aa8333
EZ
52602011-11-07 Eli Zaretskii <eliz@gnu.org>
5261
5262 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5263 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5264 of temacs in GUI mode.
5265
be7f5545
MR
52662011-11-07 Martin Rudalics <rudalics@gmx.at>
5267
5268 * window.h: Declare delete_all_child_windows instead of
5269 delete_all_subwindows.
5270 * window.c (Fwindow_nest, Fset_window_nest)
5271 (Fset_window_new_total, Fset_window_new_normal)
5272 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5273 (delete_all_subwindows): Rename to delete_all_child_windows.
5274 (Fdelete_other_windows_internal, Fset_window_configuration):
5275 Call delete_all_child_windows instead of delete_all_subwindows.
5276 * frame.c (delete_frame): Call delete_all_child_windows instead
5277 of delete_all_subwindows.
5278
ca78dc43
PE
52792011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5282 This is also needed for porting to any host where GC_MARK_STACK is
5283 not GC_MAKE_GCPROS_NOOPS.
5284 (which_symbols): Use it.
5285
a0241d01
KH
52862011-11-07 Kenichi Handa <handa@m17n.org>
5287
5288 * coding.c (coding_set_destination): Check coding->src_pos only
5289 when coding->src_object is a buffer (bug#9910).
5290
5291 * process.c (send_process): Set the member src_multibyte of coding
5292 to 0 (bug#9911) when sending a unibyte text.
5293
5294 * callproc.c (Fcall_process): Set the member src_multibyte of
5295 process_coding to 0 (bug#9912).
5296
a64bfdfa 52972011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5298
5299 * xmenu.c (cleanup_widget_value_tree): New function.
5300 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5301 calling free_menubar_widget_value_tree directly (Bug#9830).
5302
cb41b32a
PE
53032011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5304
5305 Fix some portability problems with 'inline'.
5306 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5307 (window_box_width, window_box_left, window_box_left_offset)
5308 (window_box_right, window_box_right_offset): Declare extern.
5309 Otherwise, these inline functions do not conform to C99 and
5310 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5311 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5312 * intervals.c (adjust_intervals_for_insertion)
5313 (adjust_intervals_for_deletion): Now extern, because otherwise the
5314 extern inline functions 'offset_intervals' couldn't refer to it.
5315 (static_offset_intervals): Remove.
5316 (offset_intervals): Rewrite using the old contents of
5317 static_offset_intervals. The old version didn't conform to C99
5318 because an extern inline function contained a reference to an
5319 identifier with static linkage.
5320
b7041366
AS
53212011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5322
5323 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5324 GC.
5325
88a37c4d
EZ
53262011-11-06 Eli Zaretskii <eliz@gnu.org>
5327
5328 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5329 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5330 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5331 return Qleft_to_right.
5332
49745b39
CY
53332011-11-06 Chong Yidong <cyd@gnu.org>
5334
5335 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5336 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5337 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5338 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5339 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5340 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5341 (Fwindow_vscroll): Doc fix.
5342 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5343 argument, since it makes no sense to pass a live window and for
5344 consistency with window-child.
5345
1f05cd82
CS
53462011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5347
5348 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5349 support MSVC.
5350
22610910
JR
53512011-11-05 Jason Rumney <jasonr@gnu.org>
5352
5353 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5354 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5355 fonts (Bug#6029).
5356 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5357 bitwise arithmetic preventing use of unicode-sip and non-truetype
5358 opentype fonts.
5359
a06776b2
EZ
53602011-11-05 Eli Zaretskii <eliz@gnu.org>
5361
3ad924ba
EZ
5362 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5363 "emacs"-only part.
5364
a06776b2
EZ
5365 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5366 initialization code to keep similarity to xfns.c after changes
5367 from 2011-11-05.
5368
c9e7db78
JD
53692011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5370
a97f8f3f
JD
5371 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5372 (unwind_create_frame): New function (Bug#9943).
5373 (Fx_create_frame): Restructure code to be more similar to the one in
5374 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5375 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5376 Move terminal->reference_count++ just before making the frame official
5377 (Bug#9943).
5378
5379 * nsterm.m (x_free_frame_resources): New function.
5380 (x_destroy_window): Move code to x_free_frame_resources.
5381
c9e7db78 5382 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5383 (Fx_create_frame, x_create_tip_frame):
5384 Move terminal->reference_count++ just before making the frame
75f1671a 5385 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5386 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5387
a6fc3b5c
EZ
53882011-11-05 Eli Zaretskii <eliz@gnu.org>
5389
5390 Support MSVC build with newer versions of Visual Studio.
5391 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5392 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5393 nt/gmake.defs.
5394
5395 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5396 which are not supported by MSVC.
5397 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5398 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5399 bitfields.
5400 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5401 types in bitfields.
5402 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5403
5404 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5405
58179cce 54062011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5407
5408 Support MSVC build with newer versions of Visual Studio.
5409 * w32.c: Don't include w32api.h for MSVC.
5410 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5411
5412 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5413 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5414 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5415 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5416 e_* cousins.
5417 (alloca) [_MSC_VER]: Define to _alloca.
5418
5419 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5420
5421 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5422
a58c13ed
EZ
54232011-11-04 Eli Zaretskii <eliz@gnu.org>
5424
5425 * xdisp.c (note_mouse_highlight): If either of
5426 previous/next-single-property-change returns nil, treat that as
5427 the beginning or the end of the buffer. (Bug#9955)
5428
fe0b6370
JD
54292011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5430
a58c13ed 5431 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5432 label is not null (Bug#9951).
5433 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5434 may be NULL.
5435
89bd5ee1
EZ
54362011-11-04 Eli Zaretskii <eliz@gnu.org>
5437
5438 * window.c (Fwindow_body_size): Mention in the doc string that the
5439 return value is in frame's canonical units. (Bug#9949)
5440
84c3edb9
EZ
54412011-11-03 Eli Zaretskii <eliz@gnu.org>
5442
4e2fb5c7
EZ
5443 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5444
84c3edb9 5445 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5446 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5447 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5448
bc17a887
EZ
54492011-11-01 Eli Zaretskii <eliz@gnu.org>
5450
5451 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5452 Don't stop backward scan on the continuation glyph, even though
5453 its CHARPOS is positive.
6d5eb5b0
SM
5454 (mouse_face_from_buffer_pos, note_mouse_highlight):
5455 Rename cover_string to disp_string.
bc17a887 5456
4ee88440
MR
54572011-11-01 Martin Rudalics <rudalics@gmx.at>
5458
5459 * window.c (temp_output_buffer_show): Don't use
5460 Vtemp_buffer_show_specifiers.
5461 (Vtemp_buffer_show_specifiers): Remove unused variable.
5462
c2ff3c02
EZ
54632011-10-30 Eli Zaretskii <eliz@gnu.org>
5464
5465 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5466 past the beginning of the current glyph matrix.
5467
58179cce 54682011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5469
5470 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5471 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5472 HAVE_GTK3 (Bug#9869).
b77a6a7f 5473
3b574623
JD
5474 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5475 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5476
b77a6a7f
JD
5477 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5478
5479 * xterm.c: Declare x_handle_net_wm_state to return int.
5480 (handle_one_xevent): Check if we are iconified but don't have
5481 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5482 (get_current_wm_state): Return non-zero if not hidden,
5483 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5484 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5485 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5486 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5487
196e41e4
PE
54882011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5489
5490 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5491 so that this new function doesn't get optimized away by a
5492 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5493
021f2e1a
AS
54942011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5495
5496 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5497
8b058d44
EZ
54982011-10-29 Eli Zaretskii <eliz@gnu.org>
5499
5500 Fix the `xbytecode' command.
5501 * .gdbinit (xprintbytestr): New command.
b50a28de 5502 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5503 (xbytecode): Print the byte-code string as well.
5504
4452fb80
EZ
55052011-10-29 Kim Storm <storm@cua.dk>
5506
8b058d44
EZ
5507 * alloc.c (which_symbols): New function.
5508
21b72067
AS
55092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5510
5511 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5512 line. (Bug#9903)
5513
83ed7b5c
GM
55142011-10-29 Glenn Morris <rgm@gnu.org>
5515
5516 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5517 Not clear what it was for, and it causes various bugs. (Bug#9839)
5518
5a7a728b
EZ
55192011-10-28 Eli Zaretskii <eliz@gnu.org>
5520
5521 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5522 possible random value that matches one of those tested as
5523 condition to clear the mouse face.
5524
d3d0842f
CY
55252011-10-28 Chong Yidong <cyd@gnu.org>
5526
5527 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5528
31b39d13
DN
55292011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5530
5531 * window.c (make_window): Initialize phys_cursor_on_p.
5532
9aba6043
SM
55332011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5534
5535 * lisp.h (struct Lisp_Symbol): Update comments.
5536
c20992f4
JB
55372011-10-28 Juanma Barranquero <lekktu@gmail.com>
5538
5539 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5540
db4f02f2
EZ
55412011-10-28 Eli Zaretskii <eliz@gnu.org>
5542
5543 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5544 <oslsachem@gmail.com> for helping to debug this.
5545
5546 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5547 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5548 (g_b_init_get_glyph_outline_w): New static variables.
5549 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5550 (GetGlyphOutlineW_Proc): New typedefs.
5551 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5552 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5553 New functions.
5554 (w32font_open_internal, compute_metrics):
5555 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5556 instead of calling the "wide" APIs directly.
5557
5558 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5559
5560 * w32.h (syms_of_w32font): Add prototype.
5561
87e68db4
JB
55622011-10-27 Juanma Barranquero <lekktu@gmail.com>
5563
5564 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5565 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5566 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5567 (Fmove_to_window_line): Doc fix.
5568
435c1d67
CY
55692011-10-27 Chong Yidong <cyd@gnu.org>
5570
5571 * process.c (make_process): Set gnutls_state to NULL.
5572
5573 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5574 non-NULL, regardless of GNUTLS_INITSTAGE.
5575 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5576 an error. Set process slots as soon as we allocate them.
5577
5578 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5579
9c6c6f49
CY
55802011-10-27 Chong Yidong <cyd@gnu.org>
5581
9aba6043
SM
5582 * gnutls.c (emacs_gnutls_deinit): New function.
5583 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5584 (Fgnutls_deinit, Fgnutls_boot): Use it.
5585
5586 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5587 (deactivate_process): Call emacs_gnutls_deinit.
5588
657d08d3
JB
55892011-10-27 Juanma Barranquero <lekktu@gmail.com>
5590
5591 * image.c (x_create_x_image_and_pixmap):
5592 * w32.c (sys_rename, w32_delayed_load):
5593 * w32font.c (fill_in_logfont):
5594 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5595
5430d399
JB
55962011-10-26 Juanma Barranquero <lekktu@gmail.com>
5597
5598 * w32fns.c (w32_default_color_map): New function,
5599 extracted from Fw32_default_color_map.
a7ef684b 5600 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5601
fe0055fa
PE
56022011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5603
5604 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5605
e6346438
SM
56062011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5607
5608 * keyboard.c (test_undefined): New function (bug#9751).
5609 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5610
e112cc37
ET
56112011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5612
5613 * sysdep.c (init_sys_modes): Fix the check for the controlling
5614 terminal (Bug#6649).
5615
7b5d6677
EZ
56162011-10-20 Eli Zaretskii <eliz@gnu.org>
5617
5618 * dispextern.h (struct bidi_it): New member next_en_type.
5619
5620 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5621 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5622 current character, check also for next_en_type being WEAK_EN.
5623 (bidi_resolve_weak): Don't enter the expensive loop if the current
5624 position is before next_en_pos. Record the bidi type of the first
5625 non-ET, non-BN character we find, in addition to its position.
5626 (bidi_level_of_next_char): Invalidate next_en_type when
5627 next_en_pos is over-stepped.
5628
7da0b018
PE
56292011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5630
5631 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5632 * editfns.c: Rewrite current-time-zone so that it invokes
5633 the equivalent of (format-time-string "%Z") to get the time zone name.
5634 This fixes a bug when the time zone name contains characters that
5635 need converting from the system time locale to Emacs internal format.
5636 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5637 that patch fixed format-time-string to do the conversion, but
5638 I forgot to fix current-time-zone.
5639 (format_time_string): New function, containing most of
5640 what Fformat_time_string used to contain.
5641 (Fformat_time_string): Rewrite in terms of format_time_string.
5642 This doesn't change this function's behavior.
5643 (current-time-zone): Rewrite to use format_time_string.
5644 This fixes the bug reported by Michael Schierl in
5645 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5646 Jason Rumney's 2007-06-07 change worked around this bug, but
5647 didn't fix it.
5648 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5649
8547b010
EZ
56502011-10-19 Eli Zaretskii <eliz@gnu.org>
5651
5652 * xdisp.c (start_display): If the character at POS is displayed
5653 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5654 (try_window_reusing_current_matrix): If a line ends in a display
5655 vector or the next line starts in a display vector, continue
5656 redrawing the window even though the character position of
5657 start_row was reached.
8547b010
EZ
5658 (Bug#9771, part 2)
5659
4e948d15
CY
56602011-10-18 Chong Yidong <cyd@gnu.org>
5661
5662 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5663 with nobreak-char-display too.
5664
4787455f
EZ
56652011-10-18 Eli Zaretskii <eliz@gnu.org>
5666
5667 Fix part 3 of bug#9771.
5668 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5669 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5670 non-neutral characters if the current character is a paragraph
5671 separator (a.k.a. Newline). This avoids running the same
5672 expensive loop twice, once when we consume the preceding newline
5673 and the other time when the line actually needs to be displayed.
5674 Avoid the loop when we see neutrals on the base embedding level
5675 following a character whose directionality is the same as the
5676 paragraph's. This avoids running the expensive loop when a line
5677 ends in a long sequence of neutrals, like control characters.
5678 Add assertion against STRONG_AL type. Slightly rearrange code
5679 that determines the type of a neutral given the first non-neutral
5680 that follows it.
5681 (bidi_level_of_next_char): Set next_en_pos to zero when
5682 invalidating its info.
5683
2c91f553
EZ
56842011-10-17 Eli Zaretskii <eliz@gnu.org>
5685
5686 * xdisp.c (push_display_prop): Determine whether to record string
5687 or buffer position by IT->string, not by IT->method. Allow
5688 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5689 (move_it_vertically_backward): Don't look for character position
5690 immediately after the newline when in a continuation line.
5691 (Bug#9771, part 1)
2c91f553 5692
c7b08b0d
MR
56932011-10-15 Martin Rudalics <rudalics@gmx.at>
5694
5695 * window.c (coordinates_in_window): Rewrite and delabelize
5696 vertical border check. (Bug#5357) (Bug#9618)
5697
6b02f655
SM
56982011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5699
5700 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5701 errors in XSetWindowBorder (bug#9310).
5702
81d40c92
DA
57032011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5704
5705 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5706 avoid crash when xmalloc overrun checking is enabled.
5707
d4172c3b
EZ
57082011-10-13 Eli Zaretskii <eliz@gnu.org>
5709
5710 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5711 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5712 cursor motion with <left> and <right> arrow keys.
5713
5714 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5715 some callers set that themselves.
5716
b00eea75
EZ
57172011-10-12 Eli Zaretskii <eliz@gnu.org>
5718
5719 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5720 display string and the previous row comes from the same string and
5721 is empty. (Bug#9739) (Bug#9738)
5722
8fe012c4
SM
57232011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5724
5725 * doc.c (get_doc_string): Encode file name (bug#9735).
5726
0074aef2
EZ
57272011-10-12 Eli Zaretskii <eliz@gnu.org>
5728
79beb178
EZ
5729 * bidi.c (bidi_level_of_next_char):
5730 * xdisp.c (get_visually_first_element): Remove old incorrect
5731 comments regarding the Unicode Line Separator character.
5732
0074aef2
EZ
5733 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5734
6e4b3fbe
DA
57352011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5736
5737 * alloc.c (Fgc_status): Do not access beyond zombies array
5738 boundary if nzombies > MAX_ZOMBIES.
5739 * alloc.c (dump_zombies): Add missing format specifier.
5740
0324f3af
PE
57412011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5742
b5525cac
PE
5743 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5744 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5745
0324f3af
PE
5746 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5747 Some packages use them to denote characters with modifiers.
5748
e9b5f888
AS
57492011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5750
5751 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5752 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5753 matching a pp-number. Rename parameter var to var1.
5754
127827c0
SM
57552011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5756
5757 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5758
c8fd3bd0
GM
57592011-10-08 Glenn Morris <rgm@gnu.org>
5760
5761 * callint.c (Fcall_interactively): Give a more explicit error for the
5762 'c' case with a non-character input. (Bug#8479)
5763
352ec8ff
EZ
57642011-10-08 Eli Zaretskii <eliz@gnu.org>
5765
03669ccb
EZ
5766 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5767 lines.
7061c986
EZ
5768 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5769 lines that are hscrolled on the left.
03669ccb 5770
352ec8ff
EZ
5771 * dispnew.c (buffer_posn_from_coords): Account for a possible
5772 presence of header-line. (Bug#4426)
5773
a66cfb1c
SM
57742011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5775
6b02f655
SM
5776 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5777 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5778
7c5ee88e
PE
57792011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5780
5781 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5782 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5783 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5784 this makes Emacs dump core during garbage collection on rare
5785 occasions. sizeof is obviously inferior to offsetof here, so
5786 stick with offsetof.
5787 (GC_POINTER_ALIGNMENT): New macro.
5788 (mark_memory): Omit 3rd (offset) arg; caller changed.
5789 Don't assume EMACS_INT alignment is the same as pointer alignment.
5790
df1bbe5b
SM
57912011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5792
5793 * keyboard.c (read_key_sequence_remapped): New var.
5794 (read_key_sequence): Compute remapping in the right buffer.
5795 (command_loop_1): Use read_key_sequence's remapping directly.
5796
51553db6
SM
57972011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5798
32c1fffd
SM
5799 * dired.c (file_name_completion): Don't expand file name.
5800 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5801 before checking file name handler.
5802
51553db6
SM
5803 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5804 they've been requested explicitly (bug#9591).
5805
b6bd1599 58062011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5807
5808 * keymap.c (Fsingle_key_description): Use make_specified_string
5809 instead of build_string to build string from push_key_description.
5810 (Bug#5193)
5811
f701dc2a
PE
58122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5813
4222c55d
PE
5814 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5815 This fixes a Y2038 bug on 64-bit hosts.
5816 * buffer.c (reset_buffer):
5817 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5818 (Fclear_buffer_auto_save_failure):
5819 Use 0, not -1, to represent an unset failure time, since time_t
5820 might not be signed.
5821
f701dc2a
PE
5822 Remove dependency on glibc malloc internals.
5823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5824 Move back here from lisp.h, but with their new implementations.
5825 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5826 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5827 * charset.c (charset_table_init): New static var.
5828 (syms_of_charset): Use it instead of xmalloc. This removes a
5829 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5830 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5831 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5832 Move back to alloc.c.
5833 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5834 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5835
9ceebf39
JD
58362011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5837
5838 * nsterm.m (windowDidResize): Call x_set_window_size only when
5839 ns_in_resize is true. Otherwise set pixelwidth/height and
5840 call change_frame_size (Bug#9628).
5841
cb993c58
PE
58422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5843
3930c88b
PE
5844 Port --enable-checking=all to Fedora 14 x86-64.
5845 * charset.c (syms_of_charset): Also account for glibc malloc's
5846 internal overhead when calculating the initial malloc maximum.
5847
cb993c58
PE
5848 Port --enable-checking=all to Fedora 14 x86.
5849 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5850 Move to lisp.h.
5851 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5852 (overrun_check_realloc, overrun_check_free):
5853 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5854 That way, xmalloc returns a properly-aligned pointer even if
5855 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5856 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5857 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5858 into account when calculating the initial malloc maximum.
5859 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5860 Move here from alloc.c, so that charset.c can use it too.
5861 Properly align; the old code wasn't right for common 32-bit hosts
5862 when configured with --enable-checking=all.
5863 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5864 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5865
31bed486
EZ
58662011-09-29 Eli Zaretskii <eliz@gnu.org>
5867
04c70788 5868 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5869 use EDOM.
5870
fbcaa2f3
EZ
58712011-09-28 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xdisp.c (compute_display_string_end): If there's no display
5874 string at CHARPOS, return -1.
5875
5876 * bidi.c (bidi_fetch_char): When compute_display_string_end
5877 returns a negative value, treat the character as a normal
5878 character not covered by a display string. (Bug#9624)
5879
a239d4e9
JB
58802011-09-28 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * lread.c (Fread_from_string): Fix typo in docstring.
5883
88652fd5
EZ
58842011-09-27 Eli Zaretskii <eliz@gnu.org>
5885
5886 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5887 newline, reseat the iterator instead of bidi-iterating there one
5888 character at a time. (Bug#9610)
32c1fffd
SM
5889 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5890 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5891
ed497dd4
AS
58922011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5893
5894 * lread.c (readevalloop): Use correct code for NBSP.
5895 (read1): Likewise. (Bug#9608)
5896
b2bf61aa
MA
58972011-09-25 Michael Albinus <michael.albinus@gmx.de>
5898
5899 * dbusbind.c (Fdbus_register_signal): When service is not
5900 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5901
32bbb17c
GM
59022011-09-25 Glenn Morris <rgm@gnu.org>
5903
5904 * buffer.c (truncate-lines): Doc fix.
5905
94e0933e
CY
59062011-09-24 Chong Yidong <cyd@stupidchicken.com>
5907
5908 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5909 (Fset_window_next_buffers): Doc fix.
5910
cddde921
GM
59112011-09-24 Glenn Morris <rgm@gnu.org>
5912
5913 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5914
1260aef1
PE
59152011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5916
25b4bfa0
PE
5917 Fix minor problems found by static checking.
5918 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5919 * indent.c (Fvertical_motion): Fix == vs = typo.
5920
e3cbd34b
EZ
59212011-09-24 Eli Zaretskii <eliz@gnu.org>
5922
a66cfb1c
SM
5923 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5924 Default value is now t. Doc fix.
6bf7006f 5925
e3cbd34b 5926 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5927 logic when moving up, not only when moving down. Fix the
e3cbd34b 5928 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5929 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5930
5931 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5932 CHARPOS is covered by a display string which includes newlines.
5933 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5934 is covered by a display string with embedded newlines.
5935
a3de0cbd
MA
59362011-09-24 Michael Albinus <michael.albinus@gmx.de>
5937
5938 * dbusbind.c (Fdbus_register_signal): Add match rule to
5939 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5940 (Fdbus_register_method, Vdbus_registered_objects_table):
5941 Fix docstring.
a3de0cbd 5942
b260039d
JM
59432011-09-24 Jim Meyering <meyering@redhat.com>
5944
32c1fffd 5945 do not ignore write error for any output size
b260039d
JM
5946 The previous change was incomplete.
5947 While it makes emacs --batch detect the vast majority of stdout
5948 write failures, errors were still ignored whenever the output size is
5949 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5950 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5951 && echo FAIL: ignored write error
5952 FAIL: ignored write error
5953 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5954 && echo FAIL: ignored write error
5955 FAIL: ignored write error
5956 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5957
8eca8a7c
AS
59582011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5959
5960 * emacs.c (Fkill_emacs): In noninteractive mode exit
5961 non-successfully if a write error occurred on stdout. (Bug#9574)
5962
3341db62
EZ
59632011-09-21 Eli Zaretskii <eliz@gnu.org>
5964
5965 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5966 the xassert test.
5967
5968 * dispextern.h (struct it): Update the comment documenting what
5969 can it->OBJECT be.
5970
8c203dbf
EZ
59712011-09-20 Eli Zaretskii <eliz@gnu.org>
5972
5973 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5974 a display string, extend search for cursor position to end of row.
5975 (find_row_edges): If the row ends in a newline from a display
5976 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5977 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5978 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5979 non-empty line. Fixes confusing cursor motion with arrow keys at
5980 the beginning of a line that starts with whitespace.
8c203dbf 5981
a4824228
LMI
59822011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5983
5984 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5985 (bug#9493).
5986
33ed493b
CY
59872011-09-18 Chong Yidong <cyd@stupidchicken.com>
5988
5989 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5990 boolean (Bug#9154).
5991
56cd55c8
EZ
59922011-09-18 Eli Zaretskii <eliz@gnu.org>
5993
5994 * xdisp.c (display_line): Record maximum and minimum buffer
5995 positions even if no glyphs were produced (e.g., by a zero-width
5996 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5997 buffer positions that will be removed from the glyph row because
5998 they don't fit.
c02dcedf
EZ
5999 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6000 column is beyond frame width: don't subtract 1 "pixel" when
6001 computing width of the stretch.
3e62b7e0
EZ
6002 (reseat_at_next_visible_line_start): Undo the change made on
6003 2011-09-17 that saved paragraph information and restored it after
6004 the call to `reseat'. (Bug#9545)
56cd55c8 6005
5ed99d36 60062011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6007
6008 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6009 and turn window cursor on if cleared (Bug#9415).
6010
5ed99d36 60112011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6012
6013 * search.c (boyer_moore): Take unibyte characters from pattern
6014 literally. (Bug#9458)
6015
9bade7b2
EZ
60162011-09-18 Eli Zaretskii <eliz@gnu.org>
6017
6018 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6019
e5e9d610
PE
60202011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6021
87e4427a
PE
6022 Fix minor problem found by static checking.
6023 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6024 initialized, to pacify gcc -Wuninitialized.
6025
e5e9d610
PE
6026 * fileio.c: Report proper errno when syscall falls.
6027 (Finsert_file_contents): Save and restore errno,
6028 so that report_file_error outputs the correct diagnostic.
6029 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6030
a1674f0b
EZ
60312011-09-18 Eli Zaretskii <eliz@gnu.org>
6032
6033 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6034
fbfb6dd4
EZ
60352011-09-17 Eli Zaretskii <eliz@gnu.org>
6036
6037 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6038 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6039
bb187662
EZ
60402011-09-17 Eli Zaretskii <eliz@gnu.org>
6041
1137e8b8 6042 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6043 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6044
6045 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6046 (bidi_find_paragraph_start): Search back for paragraph beginning
6047 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6048 (bidi_move_to_visually_next): Only trigger paragraph-related
6049 computations when the last character is a newline or at EOB, not
6050 just any NEUTRAL_B. (Bug#9470)
6051
bb187662
EZ
6052 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6053 truncated lines if point is covered by a display string. (Bug#9524)
6054
2e621251
PE
60552011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6058 (cons_to_x_long): New function.
6059 (lisp_data_to_selection_data): Use it. Correct the test for
6060 short-versus-long data; it was negated. Break out of vector
6061 loop, for efficiency, when a long datum is discovered.
6062
91a15bc6
SM
60632011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6064
6065 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6066
b41c3a35
EZ
60672011-09-16 Eli Zaretskii <eliz@gnu.org>
6068
6069 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6070 GCC PR/17406) by declaring this function with external scope.
6071
7812ba2d
PE
60722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6073
6074 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6075 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6076
cf7edc2a
AS
60772011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6078
6079 * editfns.c (Fformat): Correctly handle text properties on "%%".
6080
bd01620e
EZ
60812011-09-15 Eli Zaretskii <eliz@gnu.org>
6082
6083 * xterm.c (x_draw_composite_glyph_string_foreground):
6084 * w32term.c (x_draw_composite_glyph_string_foreground):
6085 * term.c (encode_terminal_code):
6086 * composite.c (composition_update_it, get_composition_id):
6087 * xdisp.c (get_next_display_element)
6088 (fill_composite_glyph_string): Add comments about special meaning
6089 of TAB characters in a composition.
6090
a02719a3
PE
60912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6092
6093 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6094 This occurs when processing a multibyte format.
6095 Problem reported by Wolfgang Jenker.
a02719a3 6096
72589a3c
JB
60972011-09-15 Johan Bockgård <bojohan@gnu.org>
6098
6099 * xdisp.c (try_cursor_movement): Only check for exact match if
6100 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6101
1c14176c
PE
61022011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6103
6104 Remove unused external symbols.
6105 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6106 * xdisp.c (calc_pixel_width_or_height): Now static.
6107 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6108 * indent.c (check_display_width):
6109 * w32term.c: Fix comment to match code.
6110 * xterm.c, xterm.h (x_catching_errors): Remove.
6111
d2eea5b5
PE
61122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 * xselect.c: Use signed conversions more consistently (Bug#9498).
6115 (selection_data_to_lisp_data): Assume incoming selection data are
6116 signed integers, not unsigned. This is to be consistent with
6117 outgoing selection data, which was modified to use signed integers
6118 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6119 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6120 expects long, not unsigned long.
6121
46888499
EZ
61222011-09-14 Eli Zaretskii <eliz@gnu.org>
6123
6124 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6125 computation of loop end. Reported by Johan Bockgård
6126 <bojohan@gnu.org>.
6127
ef8ef9fb
CY
61282011-09-13 Chong Yidong <cyd@stupidchicken.com>
6129
6130 * frame.c (Fother_visible_frames_p): Function deleted.
6131
fa819fed
EZ
61322011-09-12 Eli Zaretskii <eliz@gnu.org>
6133
6134 * indent.c (compute_motion): Process display vector front to back
6135 rather than the other way around. (Bug#2496)
6136
2ba8e008
SM
61372011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6138
6139 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6140
20f53c69
CY
61412011-09-11 Chong Yidong <cyd@stupidchicken.com>
6142
6143 * minibuf.c (Fread_from_minibuffer): Doc fix.
6144
d562d7a4
EZ
61452011-09-11 Eli Zaretskii <eliz@gnu.org>
6146
6147 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6148 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6149
1c4d7f3d
LMI
61502011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6151
6152 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6153 value for non-existent files.
6154
b885bf36
EZ
61552011-09-11 Eli Zaretskii <eliz@gnu.org>
6156
6157 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6158 set its "size" to -1. This will set the modtime_size field of
6159 the corresponding buffer to -1, which is what
6160 verify-visited-file-modtime expects for files that do not exist.
6161 (Bug#9139)
6162
6612f0bf
PE
61632011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6164
6165 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6166 here ...
6167 * lisp.h: ... from here. push_key_description is no longer
6168 defined in keyboard.c, so its declaration should not be in
6169 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6170 logically belongs with push_key_description.
6171
dfb3f755
PE
61722011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6173
6174 * buffer.h: Include <sys/types.h> instead of <time.h>.
6175 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6176 Problem reported by Herbert J. Skuhra.
6177
3134906c
LMI
61782011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6179
6180 * xml.c (parse_region): Make the parsing work for
6181 non-comment-starting XML files again (bug#9144).
6182
8d903f4e
AS
61832011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6184
6185 * image.c (gif_load): Fix calculation of bottom and right corner.
6186 (Bug#9468)
6187
80ad64f4
EZ
61882011-09-10 Eli Zaretskii <eliz@gnu.org>
6189
6190 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6191 redisplay in small windows.
6192
208a048d
EZ
61932011-09-09 Eli Zaretskii <eliz@gnu.org>
6194
6195 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6196
9b1c252e
MR
61972011-09-08 Martin Rudalics <rudalics@gmx.at>
6198
6199 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6200 Operate on live windows only.
6201
2949f33b
JB
62022011-09-08 Juanma Barranquero <lekktu@gmail.com>
6203
6204 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6205
e08dcafd
EZ
62062011-09-07 Eli Zaretskii <eliz@gnu.org>
6207
6208 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6209 only under bidi iteration.
6210
115b96bd
JD
62112011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6212
6213 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6214
c8199d0f
PE
62152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6216
6217 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6218 Without this fix, the command to link temacs failed due to an
6219 undefined symbol __builtin_isnan. This is because
6220 /usr/include/iso/math_c99.h #defines isnan(x) to
6221 __builtin_isnan(x), but the bundled gcc, which identifies itself
6222 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6223 a __builtin_isnan.
6224 * floatfns.c (isnan): #undef, and then #define to a clone of
6225 what's in data.c.
6226 (Fisnan): Always define, since it's always available now.
6227 (syms_of_floatfns): Always define isnan at the Lisp level.
6228
e39b275c 62292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6230
6231 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6232
b2db44d9 62332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6234
f4af5137 6235 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6236 The previous code assumed that file offsets (off_t values) fit in
6237 EMACS_INT variables, which is not true on typical 32-bit hosts.
6238 The code messed up by falsely reporting buffer overflow in cases
6239 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6240 when "big" contains more than 2**29 bytes, even though this
6241 inserts just one byte and does not overflow the buffer.
6242 (Finsert_file_contents): Store file offsets as off_t
6243 values, not as EMACS_INT values. Check for overflow when
6244 converting between EMACS_INT and off_t. When checking for
6245 buffer overflow or for overlap, take the offsets into account.
6246 Don't use EMACS_INT for small values where int suffices.
6247 When checking for overlap, fix a typo: ZV was used where
6248 ZV_BYTE was intended.
6249 (Fwrite_region): Don't assume off_t fits into 'long'.
6250 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6251
ecfc0a49
MA
62522011-09-05 Michael Albinus <michael.albinus@gmx.de>
6253
6254 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6255
6511acf2 62562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6257
0999621a 6258 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6259
6260 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6261 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6262 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6263 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6264 (modify_event_symbol): Do not assume that the length of
6265 name_alist_or_stem is safe to alloca and fits in int.
6266 (Fexecute_extended_command): Likewise for function name and binding.
6267 (Frecursion_depth): Wrap around reliably on integer overflow.
6268 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6269 since some callers pass EMACS_INT values.
6270 (Fsingle_key_description): Don't crash if symbol name contains more
6271 than MAX_ALLOCA bytes.
6272 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6273 (get_minibuffer): Arg is now EMACS_INT, not int.
6274 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6275 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6276 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6277
2be7d702
PE
6278 * dbusbind.c (signature_cat): New function.
6279 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6280 Do not overrun buffer; instead, report string overflow.
6281
9d1df220
PE
6282 * dispnew.c (add_window_display_history): Don't overrun buffer.
6283 Truncate instead; this is OK since it's just a log.
6284
33ef5c64
PE
6285 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6286 even if the time zone offset is outlandishly large.
6287 Don't mishandle offset == INT_MIN.
6288
66c6fdd5
PE
6289 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6290 when creating daemon; the previous buffer-overflow check was incorrect.
6291
d749b01b
PE
6292 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6293 which has the guts of the old verror function.
6294
b5cd1905
PE
6295 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6296 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6297
6e1a67fb
PE
6298 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6299 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6300 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6301 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6302 length of string rather than counting it via multiple sprintfs;
6303 that's simpler and more reliable.
c21721cc
PE
6304 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6305 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6306 sprintf, in case result does not fit in int.
6307
c57b67fc
PE
6308 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6309 (fontset_from_font): Print it.
6310
8a401434
PE
6311 * frame.c (tty_frame_count): Now printmax_t, not int.
6312 (make_terminal_frame, set_term_frame_name): Print it.
6313 (x_report_frame_params): In X, window IDs are unsigned long,
6314 not signed long, so print them as unsigned.
6315 (validate_x_resource_name): Check for implausibly long names,
6316 and don't assume name length fits in 'int'.
6317 (x_get_resource_string): Don't blindly alloca invocation name;
6318 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6319 not fit in int.
6320
6e1a67fb
PE
6321 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6322 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6323 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6324
0df02bf3
PE
6325 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6326 Use esprintf, not sprintf, in case result does not fit in int.
6327
48e30793
PE
6328 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6329 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6330 it as a large positive number.
6331 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6332 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6333
a66ff6d8
PE
6334 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6335 in case result does not fit in int.
6336
aca216ff
PE
6337 * print.c (float_to_string): Detect width overflow more reliably.
6338 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6339 buffer overrun. Don't assume list length fits in 'int'. Treat
6340 print length of 0 as 0, not as infinity; to be consistent with other
6341 uses of print length in this function. Don't overflow print length
6342 index. Don't assume hash table size fits in 'long', or that
6343 vectorlike size fits in 'unsigned long'.
6344
31c286f7
PE
6345 * process.c (make_process): Use printmax_t, not int, to format
6346 process-name gensyms.
6347
55e5faa1
PE
6348 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6349
80f2e268
PE
6350 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6351 to avoid potential buffer overrun.
6352
670741ab
PE
6353 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6354 if X resource line is longer than 512 bytes.
6355
b7163a50
PE
6356 * xfns.c (x_window): Make sprintf buffer a bit bigger
6357 to avoid potential buffer overrun.
6358
ae58ff1f
PE
6359 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6360
c43c8a6a
PE
6361 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6362
3f8236f4
PE
63632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6364
53e9fe90 6365 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6366 Without these, Emacs silently mishandles large integers sometimes.
6367 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6368 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6369
6511acf2
PE
6370 * xdisp.c (try_window_id): Check Emacs fixnum range before
6371 converting to 'int'.
806add1d 6372
6511acf2 6373 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6374 Check that an Emacs fixnum is in range before assigning it to 'int'.
6375 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6376 values converted from Emacs fixnums.
6377 (Frecenter): Don't wrap around a line count if it is out of 'int'
6378 range; instead, treat it as an extreme value.
6379 (Fset_window_configuration, compare_window_configurations):
6380 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6381
6511acf2
PE
6382 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6383 that can exceed INT_MAX. Check that EMACS_INT value is in range
6384 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6385 (match_limit): Don't assume that a fixnum can fit in 'int'.
6386
6511acf2 6387 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6388 exceed INT_MAX.
6389
6511acf2 6390 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6391 (Fvertical_motion): Don't wrap around LINES values that don't fit
6392 in 'int'. Instead, treat them as extreme values. This is good
6393 enough for windows, which can't have more than INT_MAX lines anyway.
6394
fcb901a7
LMI
63952011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6396
0f2f6b6d
LMI
6397 * Require libxml/parser.h to avoid compilation warning.
6398
fcb901a7
LMI
6399 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6400
6401 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6402 since this reportedly can destroy thread storage.
6403
6e20a0d4
CY
64042011-08-30 Chong Yidong <cyd@stupidchicken.com>
6405
6406 * syntax.c (find_defun_start): Update all cache variables if
6407 exiting early (Bug#9401).
6408
148ae00e
EZ
64092011-08-30 Eli Zaretskii <eliz@gnu.org>
6410
f6cfbd8f
EZ
6411 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6412
148ae00e
EZ
6413 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6414 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6415 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6416
6417 * term.c (tty_append_glyph): New function.
6418 (produce_stretch_glyph): Static function and its prototype deleted.
6419
a66cfb1c
SM
6420 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6421 Add prototypes.
148ae00e 6422
c4a07a4c
PE
64232011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6424
6425 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6426 when checking :margin (Bug#9390).
6427 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6428 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6429 so that the name doesn't mislead. All uses changed.
6430
6bc8cd65
JB
64312011-08-28 Johan Bockgård <bojohan@gnu.org>
6432
6433 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6434 set_tty_hooks.
6435
dca4927e
EZ
64362011-08-27 Eli Zaretskii <eliz@gnu.org>
6437
6438 * xdisp.c (move_it_to): Don't bail out early when reaching
6439 position beyond to_charpos, if we are scanning backwards.
6440 (move_it_vertically_backward): When DY == 0, make sure we get to
6441 the first character in the line after the newline.
6442
f2cad773
PE
64432011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6446 (ccl_driver): Do not generate an out-of-range pointer.
6447 (Fccl_execute_on_string): Remove unnecessary check for
6448 integer overflow, noted by Stefan Monnier in
6449 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6450 Remove a FIXME that didn't need fixing.
6451 Simplify the newly-introduced buffer reallocation code.
6452
0cae2cdb
JB
64532011-08-27 Juanma Barranquero <lekktu@gmail.com>
6454
6455 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6456
5fc295a4 64572011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6458
70c60eb2 6459 Integer and memory overflow issues (Bug#9196).
726e0ab1 6460
d31850da
PE
6461 * doc.c (get_doc_string): Rework so that
6462 get_doc_string_buffer_size is the actual buffer size, rather than
6463 being 1 less than the actual buffer size; this makes xpalloc more
6464 convenient.
6465
a69fbedb
PE
6466 * image.c (x_allocate_bitmap_record, cache_image):
6467 * xselect.c (Fx_register_dnd_atom):
6468 Simplify previous changes by using xpalloc.
6469
fe5c5d37
PE
6470 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6471 since either will do and ptrdiff_t is convenient with xpalloc.
6472
0065d054
PE
6473 * charset.c (charset_table_size)
6474 (struct charset_sort_data.priority): Now ptrdiff_t.
6475 (charset_compare): Don't overflow if priorities differ greatly.
6476 (Fsort_charsets): Don't assume list length fits in int.
6477 Check for size-calculation overflow when allocating sort data.
6478 (syms_of_charset): Allocate an initial charset table that is
6479 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6480
6481 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6482
6483 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6484 The actual value is always <= INT_MAX, and leaving it unsigned made
6485 overflow checking harder.
6486
6487 * dispextern.h (struct glyph_matrix.rows_allocated)
6488 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6489 with xpalloc. The values are still always <= INT_MAX.
6490
6491 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6492
6493 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6494 (SAFE_NALLOCA): New macro.
6495
6496 * region-cache.c (struct boundary.pos, find_cache_boundary)
6497 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6498 (set_cache_region, invalidate_region_cache)
6499 (revalidate_region_cache, know_region_cache, region_cache_forward)
6500 (region_cache_backward, pp_cache):
6501 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6502 so that ptrdiff_t * can be passed to xpalloc.
6503 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6504 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6505 (pp_cache): Don't assume cache_len fits in int.
6506 * region-cache.h: Adjust extern decls to match.
6507
6508 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6509 EMACS_INT, since either will do, for xpalloc.
6510
6511 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6512 (xnmalloc, xnrealloc, xpalloc): New functions.
6513
726e0ab1
PE
6514 * bidi.c (bidi_shelve_header_size): New constant.
6515 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6516 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6517
51f30bc5 6518 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6519 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6520 (overlay_strings):
6521 Don't update size of array until after memory allocation succeeds,
6522 because xmalloc/xrealloc may not return.
0065d054
PE
6523 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6524 now that we have proper integer overflow checking.
6525 (record_overlay_string, overlay_strings): Catch overflows when
6526 calculating size of overlay_str_buf.
726e0ab1 6527
0065d054
PE
6528 * callproc.c (Fcall_process): Check for size overflow when
6529 calculating size of args2.
6530 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6531 Normally we prefer signed values, but sticking with ptrdiff_t would
6532 require adding more-complicated checks.
726e0ab1
PE
6533
6534 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6535 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6536 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6537 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6538
6539 * character.c (Fstring): Check for size-calculation overflow.
6540
6541 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6542 unnecessary integer overflow. Check for size overflow.
6543 (encode_coding_object): Don't update size until xmalloc succeeds.
6544
6545 * composite.c (get_composition_id): Check for overflow in glyph
6546 length calculations.
6547
6548 Integer and memory overflow fixes for display code.
6549 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6550 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6551 (scrolling_window): Check for overflow in size calculations.
6552 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6553 Don't assume glyph table len fits in int.
6554 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6555 (row_table_size): Now ptrdiff_t, not int.
6556 (scrolling_window): Avoid overflow in size calculations.
6557 Don't update size until allocation succeeds.
6558 * fns.c (concat): Check for overflow in size calculations.
6559 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6560 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6561 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6562
6563 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6564 (get_doc_string): Check for size calculation overflow.
6565 Don't update size until allocation succeeds.
6566 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6567 EMACS_INT, where ptrdiff_t will do.
6568 (Fsubstitute_command_keys): Check for string overflow.
6569
6570 * editfns.c (set_time_zone_rule): Don't assume environment length
6571 fits in int.
6572 (message_length): Now ptrdiff_t, not int.
6573 (Fmessage_box): Don't update size until allocation succeeds.
6574 Don't assume message length fits in int.
6575 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6576
0065d054
PE
6577 * emacs.c (main): Do not reallocate argv, since there is a null at
6578 the end that can be overwritten, and this way there's no need to
6579 worry about size-calculation overflow.
6580 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6581
6582 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6583 alloc succeeds.
6584 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6585
6586 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6587 (x_set_scroll_bar_width, x_figure_window_size):
6588 Check for integer overflow.
6589 (x_set_alpha): Do not assume XINT fits in int.
6590
6591 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6592 This is for the members text_lines, text_cols, total_lines, total_cols,
6593 where the system imposes an 'int' limit.
6594
6595 * fringe.c (Fdefine_fringe_bitmap):
6596 Don't update size until alloc works.
6597
6598 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6599 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6600
6601 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6602 Check for size-calculation overflow.
6603 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6604 do, as we prefer signed integers.
6605 (id_to_widget.max_size, id_to_widget.used)
6606 (xg_store_widget_in_map, xg_remove_widget_from_map)
6607 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6608 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6609 Use and return ptrdiff_t, not int.
6610 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6611 * gtkutil.h: Change prototypes to match the above.
6612
6613 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6614 are duplicate now that they've been promoted to lisp.h.
6615 (x_allocate_bitmap_record, x_alloc_image_color)
6616 (make_image_cache, cache_image, xpm_load):
6617 Don't update size until alloc is done.
6618 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6619 (x_detect_edges):
3256efce 6620 Check for size calculation overflow.
726e0ab1
PE
6621 (ct_colors_allocated_max): New constant.
6622 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6623 overflow.
3256efce 6624
726e0ab1
PE
6625 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6626 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6627 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6628 Use ptrdiff_t, not int, to count maps.
6629 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6630 calculations. Don't update size until allocation succeeds.
6631 Redo calculations to avoid overflow.
726e0ab1
PE
6632 * keyboard.h: Change prototypes to match the above.
6633
6634 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6635 to count maps.
6636 (current_minor_maps): Check for size calculation overflow.
6637 * keymap.h: Change prototypes to match the above.
6638
6639 * lread.c (read1, init_obarray): Don't update size until alloc done.
6640
6641 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6642 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6643
726e0ab1
PE
6644 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6645 Now ptrdiff_t, not int.
6646 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6647 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6648
6649 * process.c (Fnetwork_interface_list): Check for overflow
6650 in size calculation.
6651
6652 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6653
6654 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6655 overflow. Don't bother calling xmalloc when xrealloc will do.
6656
6657 * search.c (Freplace_match): Check for size calculation overflow.
6658 (Fset_match_data): Don't assume list lengths fit in 'int'.
6659
6660 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6661 for command line length. Do not attempt to address one before the
6662 beginning of an array, as that's not portable.
6663
6664 * term.c (max_frame_lines): Remove; unused.
6665 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6666 not int.
6667 (encode_terminal_code, calculate_costs): Check for size
6668 calculation overflow.
6669 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6670 table lengths and related sizes. Don't update size until alloc
6671 done. Redo calculations to avoid overflow.
6672 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6673
6674 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6675 subtracting pointers.
6676 (gobble_line): Check for overflow more carefully. Don't update size
6677 until alloc done.
6678
6679 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6680 Don't update size until alloc done.
6681 Redo size calculations to avoid overflow.
6682 Check for size calculation overflow.
0065d054 6683 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6684
6685 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6686 Use ptrdiff_t, not int, for sizes.
6687 (store_mode_line_noprop_char): Don't update size until alloc done.
6688
0065d054
PE
6689 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6690 Use ptrdiff_t, not int, for sizes.
6691 (Finternal_make_lisp_face, cache_face):
6692 Check for size calculation overflow.
6693 (cache_face): Treat size calculation overflows as if they were
6694 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6695
6696 * xfns.c (x_encode_text, x_set_name_internal)
6697 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6698 sizes, since they can exceed INT_MAX in size. Check for size
6699 calculation overflow.
6700
0065d054
PE
6701 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6702 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6703 Don't update size until alloc done.
6704
0065d054 6705 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6706 as sprintf is limited to int lengths.
1d526e2f 6707
252c5ee1
PE
6708 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6709 (X_LONG_MIN): New macros.
864d7ce7
PE
6710 Use them to make the following changes clearer.
6711 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6712 This change doesn't affect the value now, but it may help remind
6713 future maintainers not to raise the value too much later.
6714 (SELECTION_QUANTUM): Remove, replacing with ...
6715 (selection_quantum): ... new function, which avoids overflow.
6716 All uses changed.
6717 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6718 assumption that selection length fits in 'int'.
6719 (x_reply_selection_request, x_handle_selection_request)
6720 (x_get_window_property, receive_incremental_selection)
6721 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6722 (lisp_data_to_selection_data, clean_local_selection_data):
6723 Use ptrdiff_t, not int, to record length of selection.
6724 (x_reply_selection_request, x_get_window_property)
6725 (receive_incremental_selection, x_property_data_to_lisp):
6726 Redo calculations to avoid overflow.
6727 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6728 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6729 something.
6730 (x_get_window_property, receive_incremental_selection)
6731 (lisp_data_to_selection_data, x_property_data_to_lisp):
6732 Check for size-calculation overflow.
6733 (x_get_window_property, receive_incremental_selection)
6734 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6735 Don't store size until memory allocation succeeds.
6736 (x_get_window_property): Plug memory leak on memory exhaustion.
6737 Don't double-block input; malloc is safe here. Don't assume 2**34
6738 - 4 fits in unsigned long. Add an xassert to check
6739 XGetWindowProperty overflow. Be more careful about overflow
6740 calculations, and distinguish size from memory overflow better.
6741 (receive_incremental_selection): When tracing, don't assume
6742 unsigned int is less than INT_MAX.
6743 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6744 harmful) conversions of unsigned short to int.
6745 (lisp_data_to_selection_data): Don't assume that integers
6746 in the range -65535 through -1 fit in an X unsigned short.
6747 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6748 result parameters unless successful. Rely on cons_to_unsigned
6749 to report problems with elements; the old code wasn't right anyway.
6750 (x_check_property_data): Check for int overflow; we cannot use
6751 a wider type due to X limits.
6752 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6753
726e0ab1 6754 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6755
0065d054
PE
6756 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6757 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6758 (x_color_cells): Don't store size until memory allocation succeeds.
6759 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6760 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6761 (x_term_init): Don't assume length fits in int (sprintf is limited
6762 to int size).
bc18e09d 6763
ebfa62c0
PE
6764 Use ptrdiff_t for composition IDs.
6765 * character.c (lisp_string_width):
6766 * composite.c (composition_table_size, n_compositions)
6767 (get_composition_id, composition_gstring_from_id):
6768 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6769 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6770 * window.c (Frecenter):
6771 Use ptrdiff_t, not int, for composition IDs.
6772 * composite.c (get_composition_id): Check for integer overflow.
6773 * composite.h: Adjust prototypes to match the above changes.
6774
d3411f89
PE
6775 Use ptrdiff_t for hash table indexes.
6776 * category.c (hash_get_category_set):
6777 * ccl.c (ccl_driver):
6778 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6779 * coding.c (coding_system_charset_list, detect_coding_system):
6780 * coding.h (struct coding_system.id):
6781 * composite.c (get_composition_id, gstring_lookup_cache):
6782 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6783 * image.c (xpm_get_color_table_h):
6784 * lisp.h (hash_lookup, hash_put):
6785 * minibuf.c (Ftest_completion):
6786 Use ptrdiff_t for hash table indexes, not int (which is too
6787 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6788 32-bit --with-wide-int hosts).
6789
e097a6fa
PE
6790 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6791 Add a FIXME comment about memory leaks.
6792 (syms_of_charset): Don't assume xmalloc returns.
6793
5637687f
PE
6794 Don't assume that stated character widths fit in int.
6795 * character.c (Fchar_width, c_string_width, lisp_string_width):
6796 * character.h (CHAR_WIDTH):
6797 * indent.c (MULTIBYTE_BYTES_WIDTH):
6798 Use sanitize_char_width to avoid undefined and/or bad behavior
6799 with outlandish widths.
a66cfb1c 6800 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6801 now that we have two such functions. All uses changed.
6802 (sanitize_char_width): New inline function.
6803
a2271ba2
PE
6804 Don't assume that tab-width fits in int.
6805 * character.h (sanitize_width): New inline function.
6806 (SANE_TAB_WIDTH): New macro.
6807 (ASCII_CHAR_WIDTH): Use it.
6808 * indent.c (sane_tab_width): Remove. All uses replaced by
6809 SANE_TAB_WIDTH (current_buffer).
6810 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6811
18c52557
PE
6812 * fileio.c: Integer overflow issues with file modes.
6813 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6814
caeeedc1
PE
6815 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6816 Remove unreachable code.
6817 (read_hex, load_charset_map_from_file): Check for integer overflow.
6818
6df6ae42 6819 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6820 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6821 (x_send_scroll_bar_event): Likewise. Check that the size does not
6822 exceed limits imposed by XClientMessageEvent, as well as the usual
6823 ptrdiff_t and size_t limits.
6824
b13995db
PE
6825 * keyboard.c: Overflow, signedness and related fixes.
6826 (make_lispy_movement): Use same integer type in forward decl
6827 that is used in the definition.
6828 (read_key_sequence, keyremap_step):
6829 Change bufsize argument back to int, undoing my 2011-03-30 change.
6830 We prefer signed types, and int is wide enough here.
6831 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6832 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6833 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6834 length, not size_t. Use ptrdiff_t for index, not int.
6835 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6836 possibility of integer overflow.
6837
13464394
PE
6838 Overflow, signedness and related fixes for images.
6839
6840 * dispextern.h (struct it.stack[0].u.image.image_id)
6841 (struct_it.image_id, struct image.id, struct image_cache.size)
6842 (struct image_cache.used, struct image_cache.ref_count):
6843 * gtkutil.c (update_frame_tool_bar):
6844 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6845 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6846 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6847 * nsmenu.m (update_frame_tool_bar):
6848 * xdisp.c (calc_pixel_width_or_height):
6849 * xfns.c (image_cache_refcount):
6850 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6851 on typical 64-bit hosts.
6852
6853 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6854 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6855 Omit unnecessary casts to int.
6856 (parse_image_spec): Check that integers fall into 'int' range
6857 when the callers expect that.
6858 (image_ascent): Redo ascent calculation to avoid int overflow.
6859 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6860 (lookup_image): Remove unnecessary tests.
6861 (xbm_image_p): Locals are now of int, not EMACS_INT,
6862 since parse_image_check makes sure they fit into int.
6863 (png_load, gif_load, svg_load_image):
6864 Prefer int to unsigned where either will do.
6865 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6866 old tiff_error_handler and tiff_warning_handler.
6867 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6868 stack buffer overflows. It uses only the features of vsnprintf
6869 that are common to both POSIX and native Microsoft.
6870 (tiff_error_handler, tiff_warning_handler): Use it.
6871 (tiff_load, gif_load, imagemagick_load_image):
6872 Don't assume :index value fits in 'int'.
6873 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6874 (imagemagick_load_image): Check that crop parameters fit into
6875 the integer types that MagickCropImage accepts. Don't assume
6876 Vimagemagick_render_type has a nonnegative value. Don't assume
6877 size_t fits in 'long'.
6878 (gs_load): Use printmax_t to print the widest integers possible.
6879 Check for integer overflow when computing image height and width.
6880
c11821d4
EZ
68812011-08-26 Eli Zaretskii <eliz@gnu.org>
6882
6883 * xdisp.c (redisplay_window): Don't force window start if point
6884 will be invisible in the resulting window. (Bug#9324)
6885
0c95fcf7
EZ
68862011-08-25 Eli Zaretskii <eliz@gnu.org>
6887
6888 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6889 the display spec is of the form `(space ...)'.
6890 (handle_display_spec): Return the value returned by
6891 handle_single_display_spec, not just 1 or zero.
6892 (handle_single_display_spec): If the display spec is of the form
6893 `(space ...)', and specifies display in the text area, return 2
6894 rather than 1.
fee65a97 6895 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6896 accurately, and prefer exact match for point under bidi.
6897 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6898
6899 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6900 into disp_prop; all users changed.
6901
6902 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6903 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6904 for the text covered by the display property.
6905
e4ed06f1
CY
69062011-08-25 Chong Yidong <cyd@stupidchicken.com>
6907
6908 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6909 Change return value to nil.
6910 (Frecord_buffer): Delete unused function.
6911
f67cdd7f
EZ
69122011-08-24 Eli Zaretskii <eliz@gnu.org>
6913
5980d4c6
EZ
6914 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6915 buffers, return left-to-right.
8610fe8b
EZ
6916 (set_cursor_from_row): Consider candidate row a win if its glyph
6917 represents a newline and point is on that newline. Fixes cursor
6918 positioning on the newline at EOL of R2L text within L2R
6919 paragraph, and vice versa.
6920 (try_cursor_movement): Check continued rows, in addition to
6921 continuation rows. Fixes unwarranted scroll when point enters a
6922 continued line of R2L text within an L2R paragraph, or vice versa.
6923 (cursor_row_p): Consider the case of point being equal to
6924 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6925 from the end of a short line to the beginning of a continued line
6926 of R2L text within L2R paragraph.
6927 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6928 composed characters.
5980d4c6 6929
f67cdd7f
EZ
6930 * bidi.c (bidi_check_type): Use xassert.
6931 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6932 members.
6933
bca633fb
EZ
69342011-08-23 Eli Zaretskii <eliz@gnu.org>
6935
6936 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6937 a character.
6938
4a5885a7
CY
69392011-08-23 Chong Yidong <cyd@stupidchicken.com>
6940
6941 * nsfont.m (ns_otf_to_script): Fix typo.
6942
0902a04e
KH
69432011-08-22 Kenichi Handa <handa@m17n.org>
6944
6945 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6946 extra slot even if the purpose is char-code-property-table.
6947
1a2e6670
EZ
69482011-08-23 Eli Zaretskii <eliz@gnu.org>
6949
8ddde651
EZ
6950 * xdisp.c (redisplay_window): When computing centering_position,
6951 account for the height of the header line. (Bug#8874)
6952
425cc014
EZ
6953 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6954 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6955 candidate is selected by the mouse, and that candidate has a
6956 composed character under the mouse.
6957
1a2e6670
EZ
6958 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6959 coordinates reported by pos-visible-in-window-p for a composed
6960 character in column zero.
6961
8b76d6f8
SM
69622011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6963
6964 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6965
dac347dd
EZ
69662011-08-22 Eli Zaretskii <eliz@gnu.org>
6967
6968 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6969 consider it a hit if to_charpos is anywhere in the range of the
6970 composed buffer positions.
6971
e013fb34
CY
69722011-08-22 Chong Yidong <cyd@stupidchicken.com>
6973
6974 * image.c (gif_load): Don't assume that each subimage has the same
6975 dimensions as the base image. Handle disposal method that is
6976 "undefined" by the gif spec (Bug#9335).
6977
bd1ba3e8
CY
69782011-08-20 Chong Yidong <cyd@stupidchicken.com>
6979
6980 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6981 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6982
54a1215b
EZ
69832011-08-19 Eli Zaretskii <eliz@gnu.org>
6984
823564e5
EZ
6985 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6986 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6987 from an Org mode buffer to a Speedbar frame.
6988
54a1215b
EZ
6989 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6990 a composition, take its buffer position from IT->cmp_it.charpos.
6991 Fixes cursor positioning at the beginning of a line that begins
6992 with a composed character.
6993
9778ebcc
EZ
69942011-08-18 Eli Zaretskii <eliz@gnu.org>
6995
0be6ee06
EZ
6996 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6997 character bidirectional type, use STRONG_L instead. Fixes crashes
6998 in a buffer produced by `describe-categories'.
6999
9778ebcc
EZ
7000 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7001 members before the level stack, so they would be saved and
7002 restored when copying iterator state. Fixes incorrect reordering
7003 around TABs covered by display properties.
7004
156bffbe
AS
70052011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7006
6b02f655 7007 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7008
72ad093b
CY
70092011-08-17 Chong Yidong <cyd@stupidchicken.com>
7010
7011 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7012 (internal_condition_case_2, internal_condition_case_n):
7013 Remove unnecessary aborts (Bug#9081).
72ad093b 7014
35774242
EZ
70152011-08-17 Eli Zaretskii <eliz@gnu.org>
7016
7017 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7018 has no `load' handler, try opening the file locally. (Bug#9311)
7019
db76dd85
KB
70202011-08-16 Ken Brown <kbrown@cornell.edu>
7021
7022 * gmalloc.c: Expand comment.
7023
b215eee5
EZ
70242011-08-16 Eli Zaretskii <eliz@gnu.org>
7025
7026 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7027 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7028
a4579d33
KB
70292011-08-16 Ken Brown <kbrown@cornell.edu>
7030
7031 Fix memory allocation problems in Cygwin build (Bug#9273).
7032
7033 * unexcw.c ( __malloc_initialized): Declare external variable.
7034 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7035
8b76d6f8
SM
7036 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7037 New variables.
a4579d33
KB
7038 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7039 dumped emacs.
7040 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7041 in the static heap.
7042 [CYGWIN] (special_realloc): New function.
7043 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7044 requests to realloc storage in the static heap.
7045
3ebec551
PE
70462011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * bidi.c (bidi_initialize): Remove unused local.
7049
9fd8be00
EZ
70502011-08-15 Eli Zaretskii <eliz@gnu.org>
7051
6b02f655
SM
7052 * bidimirror.h:
7053 * biditype.h: Remove file.
7054 * makefile.w32-in ($(BLD)/bidi.$(O)):
7055 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7056
7057 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7058
7059 * chartab.c: Improve commentary for the uniprop_table API.
7060
32413314
EZ
7061 * bidi.c (bidi_paragraph_init): Support zero value of
7062 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7063 (bidi_initialize): Use uniprop_table instead of including
7064 biditype.h and bidimirror.h.
32413314 7065
9fd8be00
EZ
7066 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7067 coordinates of the iterator when restoring from ppos_it.
7068 (Bug#9296)
7069
5cf2b69b
KH
70702011-08-14 Kenichi Handa <handa@m17n.org>
7071
7072 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7073 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7074
daf17d00
EZ
70752011-08-14 Eli Zaretskii <eliz@gnu.org>
7076
7077 * xdisp.c (move_it_in_display_line_to): Don't invoke
7078 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7079 ppos_it. Fixes vertical cursor motion when line beginning is
7080 covered by an image. (Bug#9296)
7081
08e3161a
JD
70822011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7083
7084 * nsterm.h (ns_run_ascript): Declare.
7085 (NSAPP_DATA2_RUNASSCRIPT): Define.
7086
7087 * nsfns.m (as_script, as_result, as_status): New static variables.
7088 (ns_run_ascript): New function.
5e617bc2 7089 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7090 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7091 the event loop. Get status from as_status (Bug#7276).
7092
7093 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7094 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7095 the event loop (Bug#7276).
7096
a3720aa2
AS
70972011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7098
7099 * gnutls.c (QCgnutls_bootprop_priority)
7100 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7101 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7102 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7103 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7104 (QCgnutls_bootprop_verify_hostname_error)
7105 (QCgnutls_bootprop_callbacks_verify): Rename from
7106 Qgnutls_bootprop_..., all uses changed.
7107
7108 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7109 uses changed.
7110
0a0d27fb
PE
71112011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7112
19d5c50c
PE
7113 * xfaces.c (Qframe_set_background_mode): Now static.
7114 * dispextern.h (Qframe_set_background_mode): Remove decl.
7115
0a0d27fb
PE
7116 * process.c (Fnetwork_interface_info): Declare local only if needed.
7117
377538cb
JD
71182011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7119
7120 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7121 (Fnetwork_interface_list): Allocate in increments of bytes instead
7122 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7123 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7124 sockaddr.
7125 (struct ifflag_def): notrailers is smart on OSX.
7126 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7127 Get hardware address with getifaddrs if available.
7128
08fff70c
EZ
71292011-08-12 Eli Zaretskii <eliz@gnu.org>
7130
7131 * xdisp.c (iterate_out_of_display_property): xassert that
7132 IT->position is set to within IT->object's boundaries. Break from
7133 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7134 when IT->position is set up wrongly due to some bug.
7135 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7136 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7137 entry. Force push_it to save on the stack the current
7138 buffer/string position, to be restored by pop_it. Fix flags in
7139 the iterator structure wrt the object coming from a display
7140 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7141 properties. (Bug#9284)
7142
7be1c708 71432011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7144
7be1c708
CY
7145 * fontset.c (fontset_get_font_group): Add proper type checks.
7146 (Bug#9172)
aac0c6e3 7147
7be1c708 71482011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7149
7be1c708
CY
7150 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7151 and LC_VERSION_MIN_MACOSX.
7152 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7153 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7154
97bb72a6
EZ
71552011-08-08 Eli Zaretskii <eliz@gnu.org>
7156
7157 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7158 no-display-properties-and-no-overlays under bidi display.
7159 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7160 properties and overlays.
97bb72a6 7161
d5617611
CY
71622011-08-08 Chong Yidong <cyd@stupidchicken.com>
7163
37e11a63
CY
7164 * editfns.c (Fset_time_zone_rule): Document relationship with the
7165 setenv function.
7166
d5617611
CY
7167 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7168 the font entity extracted from the cache (Bug#8109).
7169
58872834
CY
71702011-08-07 Chong Yidong <cyd@stupidchicken.com>
7171
7172 * composite.c (autocmp_chars): Don't reset point. That is done by
7173 restore_point_unwind (Bug#5984).
7174
75bfc667
JL
71752011-08-07 Juri Linkov <juri@jurta.org>
7176
7177 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7178 to show the arg `TIME' instead of `TIMEVAL'.
7179
d1410150
EZ
71802011-08-06 Eli Zaretskii <eliz@gnu.org>
7181
7182 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7183 display property strides EOL and includes a newline, as in
7184 longlines-mode. (Bug#9254)
75b771e4
EZ
7185 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7186 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7187
7188 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7189 is non-zero, even if the data buffer is NULL. Fixes a crash in
7190 vertical-motion with longlines-mode. (Bug#9254)
7191
35928349
EZ
71922011-08-05 Eli Zaretskii <eliz@gnu.org>
7193
ec7cc85b
EZ
7194 * bidi.c <bidi_cache_total_alloc>: Now static.
7195 (bidi_initialize): Initialize bidi_cache_total_alloc.
7196
8b76d6f8 7197 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7198 cache. (Bug#9221)
7199
7200 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7201 amount allocated this far in `bidi_cache_total_alloc'.
7202 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7203 non-zero, only free the data buffer without restoring the cache
7204 contents. All callers changed.
7205
7206 * dispextern.h (bidi_unshelve_cache): Update prototype.
7207
7208 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7209 (move_it_in_display_line, move_it_to)
7210 (move_it_vertically_backward, move_it_by_lines): Replace the call
7211 to xfree to an equivalent call to bidi_unshelve_cache.
7212 (move_it_in_display_line_to): Fix logic of returning
412b6358 7213 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7214
e2e2423b
EZ
72152011-08-05 Eli Zaretskii <eliz@gnu.org>
7216
7217 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7218 came from a string character with a `cursor' property. (Bug#9229)
7219
ae9e757a
JD
72202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7221
7222 * Makefile.in (LIB_PTHREAD): New variable.
7223 (LIBES): Add LIB_PTHREAD (Bug#9216).
7224
7225 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7226 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7227
213bd7f2
AS
72282011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7229
6b02f655 7230 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7231
99aaf75f
JD
72322011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7233
7234 * xterm.c (x_find_topmost_parent): New function.
7235 (x_set_frame_alpha): Find topmost parent window with
7236 x_find_topmost_parent and set the property there also (bug#9181).
7237 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7238
c74e9d86
PE
72392011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7240
7241 * callproc.c (Fcall_process): Avoid vfork clobbering
7242 the local vars buffer, coding_systems, current_dir.
7243
640c8776
SM
72442011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7245
7246 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7247
f26d0e4c
PE
72482011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7249
8a10d76c
PE
7250 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7251 so that it is not optimized away.
7252
f26d0e4c
PE
7253 * xdisp.c (compute_display_string_pos): Remove unused local.
7254
55439c61
EZ
72552011-08-02 Eli Zaretskii <eliz@gnu.org>
7256
7257 Fix slow cursor motion and scrolling in large buffers with
7258 selective display, like Org Mode buffers. (Bug#9218)
7259
7260 * dispextern.h (struct bidi_it): New member disp_prop_p.
7261
7262 * xdisp.c: Remove one-slot cache of display string positions.
7263 (compute_display_string_pos): Accept an additional argument
5e617bc2 7264 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7265 for a display string or property. If found, set DISP_PROP_P
7266 non-zero.
7267
7268 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7269 DISP_PROP_P, and pass it to compute_display_string_pos.
7270 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7271 non-zero. All callers of bidi_fetch_char changed.
7272
fb33fa43
SM
72732011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7274
7275 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7276
b099e063
DM
72772010-12-03 Don March <don@ohspite.net>
7278
7279 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7280 last character M-[char] is translated to ESC [char] (bug#7541).
7281
5cc7f7af
KH
72822011-08-02 Kenichi Handa <handa@m17n.org>
7283
d0fffa3f 7284 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7285
7286 * chartab.c (uniprop_table): Make it non-static.
7287
525d5e6e
EZ
72882011-08-01 Eli Zaretskii <eliz@gnu.org>
7289
7290 * xdisp.c (forward_to_next_line_start): Accept additional argument
7291 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7292 on the newline.
7293 (reseat_at_next_visible_line_start): Use the bidi iterator state
7294 returned by forward_to_next_line_start to restore the state of
7295 it->bidi_it after backing up to previous newline. (Bug#9212)
7296
31011111
AS
72972011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7298
7299 * regex.c (re_comp): Protoize.
7300 (re_exec): Fix return type.
7301 (regexec): Fix type of `ret'. (Bug#9203)
7302
476371c4
PE
73032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7304
e5d76069
PE
7305 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7306 This is needed if max-image-size is a floating-point number.
7307
9a79b20c
AS
73082011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7309
7310 * print.c (print_object): Print empty symbol as ##.
7311
7312 * lread.c (read1): Read ## as empty symbol.
7313
d8c2fa78
AA
73142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7315
7316 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7317 setting frame foreground color (Bug#9175).
7318 (x_set_background_color): Likewise.
7319
ffe57a7a
AA
7320 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7321 contents (Bug#9176).
7322 (EmacsTooltip -init): Remove bezels and add shadows to
7323 tooltip windows.
7324
bf3492a5
AA
7325 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7326 or scroll bar (Bug#8470).
7327
d55e9c53
AA
7328 * nsfont.m (nsfont_open): Remove assignment to voffset and
7329 unnecessary vars hshink, expand, hd, full_height, min_height.
7330 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7331
7332 * nsterm.h (nsfont_info): Remove voffset field.
7333
d8c2fa78 73342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7335
7336 Implement strike-through and overline on NextStep (Bug#8863).
7337
7338 * nsfont.m (nsfont_open): Use underline position provided by font,
7339 instead of hard-coded value of 2.
7340 (nsfont_draw): Call ns_draw_text_decoration instead.
7341
7342 * nsterm.h: Add declaration for ns_draw_text_decoration.
7343
7344 * nsterm.m (ns_draw_text_decoration): New function for drawing
7345 underline, overline, and strike-through.
7346 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7347 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7348 accommodate underlining, etc.
4843aac3 7349
4cc60b9b
EZ
73502011-07-28 Eli Zaretskii <eliz@gnu.org>
7351
bc7ece87
EZ
7352 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7353 default.
4cc60b9b 7354
476371c4
PE
73552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7356
66606eea
PE
7357 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7358 Without this fix, if a signal arrives just after memory fills up,
7359 'malloc' might be invoked reentrantly.
7360
476371c4
PE
7361 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7362 In other words, assume that every image size is allowed, on non-X
7363 hosts. This assumption is probably wrong, but it lets Emacs compile.
7364
f3fcc40d
AS
73652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7366
7367 * regex.c (re_iswctype): Convert return values to boolean.
7368
350c992f
EZ
73692011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7370
7371 * xdisp.c (compute_display_string_pos): Don't use cached display
7372 string position if the buffer had its restriction changed.
7373 (Bug#9184)
7374
5266b4bb
PE
73752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7376
7377 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7378
2573a837 73792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7380
41f55ccd 7381 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7382
39e378da
PE
7383 * bidi.c: Integer size and overflow fixes.
7384 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7385 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7386 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7387 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7388 (bidi_find_other_level_edge):
7389 Use ptrdiff_t instead of EMACS_INT where either will do.
7390 This works better on 32-bit hosts configured --with-wide-int.
7391 (bidi_cache_ensure_space): Check for size-calculation overflow.
7392 Use % rather than repeated addition, for better worst-case speed.
7393 Don't set bidi_cache_size until after xrealloc returns, because it
7394 might not return.
7395 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7396 (bidi_cache_ensure_space): Also check that the bidi cache size
7397 does not exceed that of the largest Lisp string or buffer. See Eli
7398 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7399
5e927815
PE
7400 * alloc.c (__malloc_size_t): Remove.
7401 All uses replaced by size_t. See Andreas Schwab's note
7402 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7403
ca4aa935
PE
7404 * image.c: Improve checking for integer overflow.
7405 (check_image_size): Assume that f is nonnull, since
7406 it is always nonnull in practice. This is one less thing to
7407 worry about when checking for integer overflow later.
7408 (x_check_image_size): New function, which checks for integer
7409 overflow issues inside X.
7410 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7411 This removes the need for a memory_full check.
7412 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7413 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7414 (xbm_read_bitmap_data): Change locals back to 'int', since
7415 their values must fit in 'int'.
7416 (xpm_load_image, png_load, tiff_load):
7417 Invoke x_create_x_image_and_pixmap earlier,
7418 to avoid much needless work if the image is too large.
7419 (tiff_load): Treat overly large images as if
7420 x_create_x_image_and_pixmap failed, not as malloc failures.
7421 (gs_load): Use x_check_image_size.
7422
5f8f9cc2
PE
7423 * gtkutil.c: Omit integer casts.
7424 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7425 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7426
5adf60bc
PE
7427 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7428
c8907a93
PE
7429 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7430 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7431 would wrongly return t on a 64-bit host.
7432
e3c25c68
PE
7433 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7434 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7435 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7436 and therefore cause GCC to emit a bogus diagnostic in some cases.
7437
3f791afe
PE
7438 * image.c: Integer signedness and overflow and related fixes.
7439 This is not an exhaustive set of fixes, but it's time to
7440 record what I've got.
7441 (lookup_pixel_color, check_image_size): Remove redundant decls.
7442 (check_image_size): Don't assume that arbitrary EMACS_INT values
7443 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7444 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7445 (tiff_load, imagemagick_load_image):
7446 Check for overflow in size calculations.
7447 (x_create_x_image_and_pixmap): Remove unnecessary test for
7448 xmalloc returning NULL; that can't happen.
7449 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7450 (xpm_color_bucket): Use better integer hashing function.
7451 (xpm_cache_color): Don't possibly over-allocate memory.
7452 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7453 (gif_memory_source):
7454 Use ptrdiff_t, not int or size_t, to record sizes.
7455 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7456 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7457 either works, as we prefer signed integers.
7458 (tiff_read_from_memory, tiff_write_from_memory):
7459 Return tsize_t, not size_t, since that's what the TIFF API wants.
7460 (tiff_read_from_memory): Don't fail simply because the read would
7461 go past EOF; instead, return a short read.
7462 (tiff_load): Omit no-longer-needed casts.
7463 (Fimagemagick_types): Don't assume size fits into 'int'.
7464
3cc5a532
PE
7465 Improve hashing quality when configured --with-wide-int.
7466 * fns.c (hash_string): New function, taken from sxhash_string.
7467 Do not discard information about ASCII character case; this
7468 discarding is no longer needed.
7469 (sxhash-string): Use it. Change sig to match it. Caller changed.
7470 * lisp.h: Declare it.
7471 * lread.c (hash_string): Remove, since we now use fns.c's version.
7472 The fns.c version returns a wider integer if --with-wide-int is
7473 specified, so this should help the quality of the hashing a bit.
7474
b312a492
PE
7475 * emacs.c: Integer overflow minor fix.
7476 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7477 Define only if GNU_LINUX.
7478 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7479
dfd153ae
PE
7480 * dispnew.c: Integer signedness and overflow fixes.
7481 Remove unnecessary forward decls, that were a maintenance hassle.
7482 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7483 All uses changed.
7484 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7485 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7486 (prepare_desired_row, line_draw_cost):
7487 Use int, not unsigned, where either works.
7488 (save_current_matrix, restore_current_matrix):
7489 Use ptrdiff_t, not size_t, where either works.
7490 (init_display): Check for overflow more accurately, and without
7491 relying on undefined behavior.
7492
a81d11a3
PE
7493 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7494 Remove, replacing with the new symbols in lisp.h. All uses changed.
7495 * fileio.c (make_temp_name):
7496 * filelock.c (lock_file_1, lock_file):
7497 * xdisp.c (message_dolog):
7498 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7499 Use pMd etc. instead.
7500 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7501 replacing the pWIDE etc. symbols removed from editfns.c.
7502
3300e6fd
PE
7503 * keyboard.h (num_input_events): Now uintmax_t.
7504 This is (very slightly) less likely to mess up due to wraparound.
7505 All uses changed.
7506
fd05c7e9
PE
7507 * buffer.c: Integer signedness fixes.
7508 (alloc_buffer_text, enlarge_buffer_text):
7509 Use ptrdiff_t rather than size_t when either will do, as we prefer
7510 signed integers.
7511
903fe15d
PE
7512 * alloc.c: Integer signedness and overflow fixes.
7513 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7514 (__malloc_size_t): Default to size_t, not to int.
7515 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7516 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7517 Prefer ptrdiff_t to size_t when either would do, as we prefer
7518 signed integers.
7519 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7520 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7521 Now const. Initialize with values that are in range even if char
7522 is signed.
7523 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7524 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7525 These functions do the right thing with sizes > 2**32.
7526 (check_depth): Now ptrdiff_t, not int.
7527 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7528 Adjust to new way of storing sizes. Check for size overflow bugs
7529 in rest of code.
7530 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7531 slightly wrong anyway, as it missed one instance of
7532 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7533 (refill_memory_reserve): Omit needless cast to size_t.
7534 (mark_object_loop_halt): Mark as externally visible.
7535
ac82cc6a
PE
7536 * xselect.c: Integer signedness and overflow fixes.
7537 (Fx_register_dnd_atom, x_handle_dnd_message):
7538 Use ptrdiff_t, not size_t, since we prefer signed.
7539 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7540 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7541 x_dnd_atoms_size and x_dnd_atoms_length.
7542
c2d1e36d
PE
7543 * doprnt.c: Prefer signed to unsigned when either works.
7544 * eval.c (verror):
7545 * doprnt.c (doprnt):
7546 * lisp.h (doprnt):
7547 * xdisp.c (vmessage):
7548 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7549 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7550 prefer signed arithmetic to avoid comparison confusion.
7551 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7552 but is a bit tricky.
7553
0e926e56
PE
7554 Assume freestanding C89 headers, string.h, stdlib.h.
7555 * data.c, doprnt.c, floatfns.c, print.c:
7556 Include float.h unconditionally.
7557 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7558 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7559 * regex.c: Likewise for stddef.h, string.h.
7560 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7561 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7562 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7563 (STDC_HEADERS): Remove obsolete defines.
7564 * sysdep.c: Include limits.h unconditionally.
7565
9cfdb3ec
PE
7566 Assume support for memcmp, memcpy, memmove, memset.
7567 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7568 * regex.c (memcmp, memcpy):
7569 Remove; we assume C89 now.
7570
7571 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7572 (__malloc_safe_bcopy): Remove; no longer needed.
7573
cf950e6b 7574 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7575 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7576 well either way, and we prefer signed to unsigned.
7577
dbf38e02
LMI
75782011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7579
7580 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7581 closes the connection while we're reading (bug#9182).
7582
d6f0886c 75832011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7584
d6f0886c
JD
7585 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7586 are specified (Bug#9168).
24e0f6b1 7587
2eb1f9e6
PE
75882011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7589
7590 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7591 Found by GCC static checking and --with-wide-int on a 32-bit host.
7592
22381272 75932011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7594
7595 * xdisp.c (compute_display_string_pos): Fix logic of caching
7596 previous display string position. Initialize cached_prev_pos to
7597 -1. Fixes slow-down at the beginning of a buffer.
7598
f25e39b4
EZ
75992011-07-24 Eli Zaretskii <eliz@gnu.org>
7600
7601 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7602 for attrs[LFACE_FONTSET_INDEX].
7603
04c4b52e
PE
76042011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7605
7606 * xml.c (parse_region): Remove unused local
7607 that was recently introduced.
7608
c1734fbd
EZ
76092011-07-23 Eli Zaretskii <eliz@gnu.org>
7610
be18c5a5
EZ
7611 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7612 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7613
c1734fbd
EZ
7614 * xdisp.c (move_it_in_display_line_to): Record the best matching
7615 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7616 exit if none of the characters scanned was an exact match.
7617 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7618 when exact match is impossible due to invisible text, and the
7619 lines are truncated.
7620
a258d627
JD
76212011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7622
7623 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7624 for OSX >= 10.7.
7625
b6d5a689
EZ
76262011-07-22 Eli Zaretskii <eliz@gnu.org>
7627
0f74f785
EZ
7628 Fix a significant slow-down of cursor motion with C-n, C-p,
7629 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7630 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7631 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7632 (next_element_from_buffer): Call compute_stop_pos_backwards to
7633 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7634 base_level_stop.
7635 (reseat): Don't look for prev_stop, as that could mean a very long
7636 run.
7637 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7638 <cached_disp_overlay_modiff>: Cache for last found display string
7639 position.
551918c1 7640 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7641 about the same buffer in the same area of character positions, and
7642 the buffer wasn't changed since the time the display string
7643 position was cached.
551918c1 7644
b2d0c91a
EZ
76452011-07-22 Eli Zaretskii <eliz@gnu.org>
7646
7647 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7648 is an integer, which is important for empty lines. (Bug#9149)
7649
043604ee
CY
76502011-07-22 Chong Yidong <cyd@stupidchicken.com>
7651
7652 * frame.c (Fmodify_frame_parameters): In tty case, update the
7653 default face if necessary (Bug#4238).
7654
da4adb04
CY
76552011-07-21 Chong Yidong <cyd@stupidchicken.com>
7656
7657 * editfns.c (Fstring_to_char): No need to explain what a character
7658 is in the docstring (Bug#6576).
7659
9abd0532
LMI
76602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7661
7662 * xml.c (parse_region): Make sure we always return a tree.
7663
36881d16
HK
76642011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7665
7666 * xml.c (parse_region): If a document contains only comments,
7667 return that, too.
7668
1e98674d
LMI
76692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7670
7671 * xml.c (make_dom): Return comments, too.
7672
590bd467
PE
76732011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7674
7675 Port to OpenBSD.
7676 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7677 and the surrounding thread.
7678 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7679 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7680 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7681 timer goes off.
7682 * s/openbsd.h (BROKEN_SIGIO): Define.
7683 * unexelf.c (unexec) [__OpenBSD__]:
7684 Don't update the .mdebug section of the Alpha COFF symbol table.
7685
f41628b2
LMI
76862011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7687
7688 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7689 (bug#8460).
7690
b59b67c5
PE
76912011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7692
15e3a074
PE
7693 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7694 This fixes some race conditions on the permissions of any newly
7695 created file.
7696
41bed37d
PE
7697 * alloc.c (valid_pointer_p): Use pipe, not open.
7698 This fixes some permissions issues when debugging.
7699
b59b67c5
PE
7700 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7701 If fchown fails to set both uid and gid, try to set just gid,
7702 as that is sometimes allowed. Adjust the file's mode to eliminate
7703 setuid or setgid bits that are inappropriate if fchown fails.
7704
925a6be7
SM
77052011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7706
7707 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7708 to compare Lisp_Objects.
7709 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7710 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7711 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7712
52968808
AS
77132011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7714
0a6a104b
AS
7715 * lread.c (read_integer): Unread even EOF character.
7716 (read1): Likewise. Properly record start position of symbol.
7717
52968808
AS
7718 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7719 symbol character follows.
7720
9e381cdd
PE
77212011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7722
7723 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7724 This works around a problem with the previous change to Fcopy_file.
7725 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7726 and without this change, GCC might complain about discarding
7727 fchown's return value.
7728
b5641435
JB
77292011-07-16 Juanma Barranquero <lekktu@gmail.com>
7730
7731 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7732
a8031457
PE
77332011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7734
7735 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7736
dd889327
LMI
77372011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7738
750c33f7
LMI
7739 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7740 it's used from the C level.
7741
dd889327
LMI
7742 * process.c: Use the same condition for POLL_FOR_INPUT in both
7743 keyboard.c and process.c (bug#1858).
7744
87e86684
LM
77452011-07-09 Lawrence Mitchell <wence@gmx.li>
7746
7747 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7748 (Fgnutls_boot): Use it.
7749
64348f40
AS
77502011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7751
7752 * doc.c (Fsubstitute_command_keys): Revert last change.
7753
1d698799
LMI
77542011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7755
f863868c
LMI
7756 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7757 quotes the next character, and doesn't affect other longer
7758 sequences (bug#8935).
7759
1d698799
LMI
7760 * lread.c (syms_of_lread): Clarify that is isn't only
7761 `eval-buffer' and `eval-defun' that's affected by
7762 `lexical-binding' (bug#8460).
7763
aa4b6df6
EZ
77642011-07-15 Eli Zaretskii <eliz@gnu.org>
7765
7766 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7767 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7768
5d856da6
PE
77692011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7770
ad6042bb
PE
7771 Fix minor problems found by static checking.
7772 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7773 (elsz): Now a signed constant, not a size_t var. We prefer signed
7774 types to unsigned, to avoid integer comparison confusion. Without
7775 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7776 "cannot optimize loop, the loop counter may overflow", a symptom
7777 of the confusion.
f00bbb22 7778 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7779 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7780
6468f31c
LMI
77812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7782
49080b10
LMI
7783 * search.c (Fre_search_backward): Mention `case-fold-search' in
7784 all the re_search_* functions (bug#8138).
7785
6468f31c
LMI
7786 * keyboard.c (Fopen_dribble_file): Document when the file is
7787 closed (bug#8056).
7788
c965adc5
EZ
77892011-07-14 Eli Zaretskii <eliz@gnu.org>
7790
df9733bf
EZ
7791 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7792 bidi_cache_idx.
7793
0bb23927
EZ
7794 Support bidi reordering of display and overlay strings.
7795 * xdisp.c (compute_display_string_pos)
7796 (compute_display_string_end): Accept additional argument STRING.
7797 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7798 (reseat_to_string): Initialize bidi_it->string.s and
7799 bidi_it->string.schars.
7800 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7801 NULL (avoids a crash in bidi_paragraph_init).
7802 Initialize itb.string.lstring.
0bb23927
EZ
7803 (init_iterator): Call bidi_init_it only of a valid
7804 buffer position was specified. Initialize paragraph_embedding to
7805 L2R.
7806 (reseat_to_string): Initialize the bidi iterator.
7807 (display_string): If we need to ignore text properties of
7808 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7809 original value of -1 will not work with bidi.)
7810 (compute_display_string_pos): First arg is now struct
7811 `text_pos *'; all callers changed. Support display properties on
7812 Lisp strings.
7813 (compute_display_string_end): Support display properties on Lisp
7814 strings.
7815 (init_iterator, reseat_1, reseat_to_string): Initialize the
7816 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7817 when iterating on a string not from display properties).
640c8776
SM
7818 (compute_display_string_pos, compute_display_string_end):
7819 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7820 arrow keys.
7821 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7822 base_level_stop; instead, set base_level_stop to BEGV.
7823 Fixes crashes in vertical-motion.
0bb23927
EZ
7824 (next_element_from_buffer): Improve commentary for when
7825 the iterator is before prev_stop.
7826 (init_iterator): Initialize bidi_p from the default value of
7827 bidi-display-reordering, not from buffer-local value. Use the
7828 buffer-local value only if initializing for buffer iteration.
7829 (handle_invisible_prop): Support invisible properties on strings
7830 that are being bidi-reordered.
7831 (set_iterator_to_next): Support bidi reordering of C strings and
7832 Lisp strings.
7833 (next_element_from_string): Support bidi reordering of Lisp
7834 strings.
7835 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7836 (display_string): Support display of R2L glyph rows.
7837 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7838 (init_iterator): Don't initialize it->bidi_p for strings
7839 here.
7840 (reseat_to_string): Initialize it->bidi_p for strings here.
7841 (next_element_from_string, next_element_from_c_string)
7842 (next_element_from_buffer): Add xassert's for correspondence
7843 between IT's object being iterated and it->bidi_it.string
7844 structure.
7845 (face_before_or_after_it_pos): Support bidi iteration.
7846 (next_element_from_c_string): Handle the case of the first string
7847 character that is not the first one in the visual order.
7848 (get_visually_first_element): New function, refactored from common
7849 parts of next_element_from_buffer, next_element_from_string, and
7850 next_element_from_c_string.
7851 (tool_bar_lines_needed, redisplay_tool_bar)
7852 (display_menu_bar): Force left-to-right direction. Add a FIXME
7853 comment for making that be controlled by a user option.
7854 (push_it, pop_it): Save and restore the state of the
7855 bidi iterator. Save and restore the bidi_p flag.
7856 (pop_it): Iterate out of display property for string iteration as
7857 well.
7858 (iterate_out_of_display_property): Support iteration over strings.
7859 (handle_single_display_spec): Set up it->bidi_it for iteration
7860 over a display string, and call bidi_init_it.
7861 (handle_single_display_spec, next_overlay_string)
7862 (get_overlay_strings_1, push_display_prop): Set up the bidi
7863 iterator for displaying display or overlay strings.
7864 (forward_to_next_line_start): Don't use the shortcut if
7865 bidi-iterating.
7866 (back_to_previous_visible_line_start): If handle_display_prop
7867 pushed the iterator stack, restore the internal state of the bidi
7868 iterator by calling bidi_pop_it same number of times.
7869 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7870 and we are bidi-iterating, don't decrement the iterator position;
7871 instead, set the first_elt flag in the bidi iterator, to produce
7872 the same effect.
7873 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7874 (push_display_prop): xassert that we are iterating a buffer.
7875 (push_it, pop_it): Save and restore paragraph_embedding member.
7876 (handle_single_display_spec, next_overlay_string)
7877 (get_overlay_strings_1, reseat_1, reseat_to_string)
7878 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7879 correctly. Don't assume unibyte strings are not bidi-reordered.
7880 (compute_display_string_pos)
7881 (compute_display_string_end): Fix handling the case of C string.
7882 (push_it, pop_it): Save and restore from_disp_prop_p.
7883 (handle_single_display_spec, push_display_prop): Set the
7884 from_disp_prop_p flag.
7885 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7886 (pop_it): Call iterate_out_of_display_property only if we are
7887 popping after iteration over a string that came from a display
7888 property. Fix a typo in popping stretch info. Add an assertion
7889 for verifying that the iterator position is in sync with the bidi
7890 iterator.
7891 (handle_single_display_spec, get_overlay_strings_1)
7892 (push_display_prop): Fix initialization of paragraph direction for
7893 string when that of the parent object is not yet determined.
7894 (reseat_1): Call bidi_init_it to resync the bidi
7895 iterator with IT's position. (Bug#7616)
7896 (find_row_edges): If ROW->start.pos gives position
7897 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7898 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7899 Reset the from_disp_prop_p flag.
7900 (SAVE_IT, RESTORE_IT): New macros.
7901 (pos_visible_p, face_before_or_after_it_pos)
7902 (back_to_previous_visible_line_start)
7903 (move_it_in_display_line_to, move_it_in_display_line)
7904 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7905 (try_scrolling, redisplay_window, display_line): Use them when
7906 saving a temporary copy of the iterator and restoring it back.
7907 (back_to_previous_visible_line_start, reseat_1)
7908 (init_iterator): Empty the bidi cache "stack".
7909 (move_it_in_display_line_to): If iterator ended up at
7910 EOL, but we never saw any buffer positions smaller than
7911 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7912 motion in bidi-reordered lines.
7913 (move_it_in_display_line_to): Record prev_method and prev_pos
7914 immediately before the call to set_iterator_to_next. Fixes cursor
7915 motion in bidi-reordered lines with stretch glyphs and strings
7916 displayed in margins. (Bug#8133) (Bug#8867)
7917 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7918 TO_CHARPOS.
640c8776
SM
7919 (pos_visible_p): Support positions in bidi-reordered lines.
7920 Save and restore bidi cache.
0bb23927
EZ
7921
7922 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7923 (bidi_paragraph_info): Delete unused struct.
7924 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7925 (bidi_cache_start): New variable.
7926 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7927 to zero.
7928 (bidi_cache_fetch_state, bidi_cache_search)
7929 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7930 (bidi_cache_find, bidi_peek_at_next_level)
7931 (bidi_level_of_next_char, bidi_find_other_level_edge)
7932 (bidi_move_to_visually_next): Compare cache index with
7933 bidi_cache_start rather than with zero.
7934 (bidi_fetch_char): Accept new argument STRING; all callers
7935 changed. Support iteration over a string. Support strings with
7936 display properties. Support unibyte strings. Fix the type of
7937 `len' according to what STRING_CHAR_AND_LENGTH expects.
7938 (bidi_paragraph_init, bidi_resolve_explicit_1)
7939 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7940 (bidi_level_of_next_char, bidi_move_to_visually_next):
7941 Support iteration over a string.
0bb23927
EZ
7942 (bidi_set_sor_type, bidi_resolve_explicit_1)
7943 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7944 can now be zero (for strings); special values 0 and -1 were
7945 changed to -1 and -2, respectively.
7946 (bidi_char_at_pos): New function.
7947 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7948 Call it instead of FETCH_MULTIBYTE_CHAR.
7949 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7950 initialized to valid values.
7951 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7952 values.
7953 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7954 the test for valid cached positions. Fix the logic for looking up
7955 the sentinel state in the cache. GCPRO the Lisp string we are
7956 iterating.
7957 (bidi_push_it, bidi_pop_it): New functions.
7958 (bidi_initialize): Initialize the bidi cache start stack pointer.
7959 (bidi_cache_ensure_space): New function, refactored from part of
7960 bidi_cache_iterator_state. Don't assume the required size is just
7961 one BIDI_CACHE_CHUNK away.
7962 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7963 (bidi_count_bytes, bidi_char_at_pos): New functions.
7964 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7965 always valid if bidi_cache_idx is valid.
7966 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7967 is valid if it's going to be used.
7968 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7969 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7970 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7971 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7972 (bidi_find_other_level_edge, bidi_cache_start_stack):
7973 All variables related to cache indices are now EMACS_INT.
c965adc5 7974
0bb23927
EZ
7975 * dispextern.h (struct bidi_string_data): New structure.
7976 (struct bidi_it): New member `string'. Make flag members be 1-bit
7977 fields, and put them last in the struct.
640c8776
SM
7978 (compute_display_string_pos, compute_display_string_end):
7979 Update prototypes.
0bb23927
EZ
7980 (bidi_push_it, bidi_pop_it): Add prototypes.
7981 (struct iterator_stack_entry): New members bidi_p,
7982 paragraph_embedding, and from_disp_prop_p.
7983 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7984 (bidi_shelve_cache, bidi_unshelve_cache):
7985 Declare prototypes.
0bb23927
EZ
7986
7987 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7988 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7989 and vector-like objects.
7990
7991 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7992 cache around display iteration.
7993
7994 * window.c (Fwindow_end, window_scroll_pixel_based)
7995 (displayed_window_lines, Frecenter): Save and restore the bidi
7996 cache around display iteration.
7997
3bbd2265
LMI
79982011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7999
8000 * editfns.c (Fdelete_region): Clarify the use of the named
8001 parameters (bug#6788).
8002
adc47434
MR
80032011-07-14 Martin Rudalics <rudalics@gmx.at>
8004
8005 * indent.c (Fvertical_motion): Set and restore w->pointm when
8006 saving and restoring the window's buffer (Bug#9006).
8007
837c31f8
LMI
80082011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8009
8010 * editfns.c (Fstring_to_char): Clarify just what is returned
8011 (bug#6576). Text by Eli Zaretskii.
8012
ac389d0c
JB
80132011-07-13 Juanma Barranquero <lekktu@gmail.com>
8014
8015 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8016
0be0ce47
EZ
80172011-07-13 Eli Zaretskii <eliz@gnu.org>
8018
8019 * buffer.c (mmap_find): Fix a typo.
8020
cd18e7e3
JB
80212011-07-13 Johan Bockgård <bojohan@gnu.org>
8022
8023 Fix execution of x selection hooks.
8024 * xselect.c (Qx_lost_selection_functions)
8025 (Qx_sent_selection_functions): New vars.
8026 (syms_of_xselect): DEFSYM them.
8027 (x_handle_selection_request): Pass Qx_sent_selection_functions
8028 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8029 (x_handle_selection_clear,x_clear_frame_selections):
8030 Pass Qx_lost_selection_functions rather than
8031 Vx_lost_selection_functions to Frun_hook_with_args.
8032
47ea7f44
PE
80332011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8034
ac389d0c 8035 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8036 The old code sometimes used this field without initializing it.
8037
47ea7f44
PE
8038 * alloc.c (gc_sweep): Don't read past end of array.
8039 In theory, the old code could also have corrupted Emacs internals,
8040 though it'd be very unlikely.
8041
bc985c87
AS
80422011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8043
8044 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8045 argument. (Bug#4026)
bc985c87 8046
0cf34688
LMI
80472011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8048
b3dadd76
LMI
8049 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8050 key" (bug#4257).
8051
0cf34688
LMI
8052 * window.c (Fset_window_start): Doc fix (bug#4199).
8053 (Fset_window_hscroll): Ditto.
8054
270768cd
PE
80552011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8056
077e3dda 8057 Fix minor new problems caught by GCC 4.6.1.
270768cd 8058 * term.c (init_tty): Remove unused local.
490011a6 8059 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8060 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8061 not used otherwise.
270768cd 8062
b1f58454
CY
80632011-07-12 Chong Yidong <cyd@stupidchicken.com>
8064
8065 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8066
22b9578d
LMI
80672011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8068
6e70ab07
LMI
8069 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8070 are the mini-buffer and the echo area (bug#3320).
8071
22b9578d
LMI
8072 * term.c (init_tty): Remove support for supdup, c10 and perq
8073 terminals, which are no longer supported (bug#1482).
8074
8974cc9f
JB
80752011-07-10 Johan Bockgård <bojohan@gnu.org>
8076
8077 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8078
a560d974
JD
80792011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8080
8081 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8082 for non-popups (Bug#3642).
8083
1dae0f0a
AS
80842011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8085
268c2c36 8086 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8087 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8088 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8089 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8090 * data.c (fmod): Likewise.
8091 * dispnew.c (swap_glyphs_in_rows): Likewise.
8092 * emacs.c (memory_warning_signal): Likewise.
8093 * floatfns.c (float_error): Likewise.
8094 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8095 (otf_open, font_otf_capability, generate_otf_features)
8096 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8097 Likewise.
8098 * image.c (pbm_read_file): Likewise.
8099 * indent.c (string_display_width): Likewise.
8100 * intervals.c (check_for_interval, search_for_interval)
8101 (inc_interval_count, count_intervals, root_interval)
8102 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8103 * lread.c (defalias): Likewise.
268c2c36 8104 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8105 * regex.c (set_image_of_range_1, set_image_of_range)
8106 (regex_grow_registers): Likewise.
8107 * sysdep.c (strerror): Likewise.
8108 * termcap.c (valid_filename_p, tprint, main): Likewise.
8109 * tparam.c (main): Likewise.
8110 * unexhp9k800.c (run_time_remap, save_data_space)
8111 (update_file_ptrs, read_header, write_header, calculate_checksum)
8112 (copy_file, copy_rest, display_header): Likewise.
8113 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8114 Likewise.
8115 * xdisp.c (check_it): Likewise.
8116 * xfaces.c (register_color, unregister_color, unregister_colors):
8117 Likewise.
8118 * xfns.c (print_fontset_result): Likewise.
8119 * xrdb.c (member, fatal, main): Likewise.
8120
99033785
PE
81212011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8122
8123 Fix minor problems found by static checking (Bug#9031).
8124 * chartab.c (char_table_set_range, map_sub_char_table):
8125 Remove unused locals.
8126 (uniprop_table): Now static.
8127 * composite.c (_work_char): Remove unused static var.
8128
9cb2ac56
JB
81292011-07-09 Juanma Barranquero <lekktu@gmail.com>
8130
8131 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8132
f25661f0
JD
81332011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8134
8135 * gtkutil.c (qttip_cb): Remove code without function.
8136
8278c4fe
EZ
81372011-07-09 Eli Zaretskii <eliz@gnu.org>
8138
8139 * w32.c (pthread_sigmask): New stub.
8140
1692ae2d 81412011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8142
8a6ebd58 8143 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8144 sigprocmask is portable only for single-threaded applications, and
8145 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8146 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8147 (LIBES): Use it.
8148 * callproc.c (Fcall_process):
8149 * process.c (create_process):
8150 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8151 Use pthread_sigmask, not sigprocmask.
123403e4 8152
1b854618
JD
81532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8154
8155 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8156 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8157 wrong (Bug#8591).
8158
3fe4b549
JD
81592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8160
0ce7e563
JD
8161 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8162 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8163 (xg_hide_tooltip): Fix comment.
8164
3fe4b549
JD
8165 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8166 in registerServicesMenuSendTypes.
8167 (validRequestorForSendType): Don't check ns_return_types.
8168
8169 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8170 ns_return_type.
8171
5df75e47
JR
81722011-07-08 Jason Rumney <jasonr@gnu.org>
8173
22610910
JR
8174 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8175 SH_SHOW for hidden windows (Bug#5482).
8176
5df75e47
JR
8177 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8178 frame struct members of non-existent frames (Bug#6284).
8179
699c10bd
JD
81802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8181
4393663b
JD
8182 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8183 variable firstTime not needed on OSX >= 10.6.
8184 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8185 >= 10.5. Use setKnobProportion, setDoubleValue.
8186
8187 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8188 (MAC_OS_X_VERSION_10_5): Define if not defined.
8189 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8190 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8191 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8192
8193 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8194 cString and lossyCString on OSX >= 10.4.
4393663b 8195
58179cce 8196 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8197 sizeToFit on OSX >= 10.2.
8198
8199 * nsimage.m (allocInitFromFile): Don't use deprecated method
8200 bestRepresentationForDevice on OSX >= 10.6.
8201
8202 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8203 to avoid warning.
8204
8205 * emacs.c: Declare unexec_init_emacs_zone.
8206
a63e0781
JD
8207 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8208
699c10bd
JD
8209 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8210
8211 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8212 on svcsMenu (Bug#8842).
8213
8214 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8215 ns_return_types.
8216 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8217
8218 * nsterm.m (QUTF8_STRING): Declare.
8219 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8220 (validRequestorForSendType): Return type is (id).
8221 Change indexOfObjectIdenticalTo to indexOfObject.
8222 Check if we have local selection before returning self (Bug#8842).
8223 (writeSelectionToPasteboard): Put local selection into paste board
8224 if we have a local selection (Bug#8842).
8225 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8226
8227 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8228 (ns_get_local_selection): Declare.
8229
54e10184
LMI
82302011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8231
9888ff71
LMI
8232 * keymap.c (describe_map_tree): Don't insert a double newline at
8233 the end of the buffer (bug#1169) and return whether we inserted
8234 something.
8235
54e10184
LMI
8236 * callint.c (Fcall_interactively): Change "reading args" to
8237 "providing args" to try to clarify what it does (bug#1010).
8238
15fa4783
KH
82392011-07-07 Kenichi Handa <handa@m17n.org>
8240
8241 * composite.c (composition_compute_stop_pos): Ignore a static
8242 composition starting before CHARPOS (Bug#8915).
8243
8244 * xdisp.c (handle_composition_prop): Likewise.
8245
a8815b00
EZ
82462011-07-07 Eli Zaretskii <eliz@gnu.org>
8247
8248 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8249 (Bug#9015)
8250
ef7b981d 82512011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8252
8253 * character.h (unicode_category_t): New enum type.
8254
8255 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8256 (Qchar_code_property_table): New variable.
8257 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8258 (UNIPROP_COMPRESSED_FORM_P): New macros.
8259 (char_table_ascii): Uncompress the compressed values.
8260 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8261 Uncompress the compressed values.
ac389d0c 8262 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8263 (char_table_ref_and_range): Uncompress the compressed values.
8264 (sub_char_table_set): New arg is_uniprop. Callers changed.
8265 Uncompress the compressed values.
8266 (sub_char_table_set_range): Args changed. Callers changed.
8267 (char_table_set_range): Adjuted for the above change.
8268 (map_sub_char_table): Delete args default_val and parent. Add arg
8269 top. Give decoded values to a Lisp function.
640c8776 8270 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8271 values to a Lisp function. Gcpro more variables.
8272 (uniprop_table_uncompress)
8273 (uniprop_decode_value_run_length): New functions.
8274 (uniprop_decoder, uniprop_decoder_count): New variables.
8275 (uniprop_get_decoder, uniprop_encode_value_character)
8276 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8277 New functions.
8278 (uniprop_encoder, uniprop_encoder_count): New variables.
8279 (uniprop_get_encoder, uniprop_table)
8280 (Funicode_property_table_internal, Fget_unicode_property_internal)
8281 (Fput_unicode_property_internal): New functions.
8282 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8283 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8284 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8285 char-code-property-alist.
8286
640c8776 8287 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8288 Vunicode_category_table.
8289
640c8776 8290 * font.c (font_range): Adjust for the change of
c805dec0
KH
8291 Vunicode_category_table.
8292
76b397fb
DN
82932011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8294
8295 * m/iris4d.h: Remove file, move contents ...
8296 * s/irix6-5.h: ... here.
8297
22b4128e
PE
82982011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8299
8300 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8301 * alloc.c (mark_buffer):
8302 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8303 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8304 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8305 This isn't true in general, and it's particularly not true
8306 if Emacs is configured with --with-wide-int.
8307 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8308 New macros, used in the buffer.c change.
8309
869795d6
JD
83102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8311
8312 * xsettings.c: Use both GConf and GSettings if both are available.
8313 (store_config_changed_event): Add comment.
8314 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8315 (store_tool_bar_style_changed): New functions.
5e617bc2 8316 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8317 (struct xsettings): Move font inside HAVE_XFT.
8318 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8319 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8320 Move inside HAVE_XFT.
640c8776 8321 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8322 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8323 also.
8324 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8325 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8326 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8327 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8328 (parse_settings): Move check for font inside HAVE_XFT.
8329 (read_settings, apply_xft_settings): Add comment.
8330 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8331 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8332 call store_font_name_changed.
8333 (xft_settings_event): Add comment.
8334 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8335 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8336 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8337 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8338 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8339 (xsettings_get_system_font, xsettings_get_system_normal_font):
8340 Add comment.
869795d6 8341
d8ed26bd
PE
83422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8343
8344 Random fixes. E.g., (random) never returned negative values.
8345 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8346 subseconds part to the entropy, as that's a bit more random.
8347 Prefer signed to unsigned, since the signedness doesn't matter and
8348 in general we prefer signed. When given a limit, use a
8349 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8350 latter isn't right if USE_2_TAGS_FOR_INTS.
8351 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8352 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8353
cabf1cac
SM
83542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8355
8356 * textprop.c (text_property_stickiness):
8357 Obey Vtext_property_default_nonsticky.
8358 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8359 * w32fns.c (syms_of_w32fns):
8360 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8361
6e9b2be9
PE
83622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8363
8364 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8365 This is more efficient than Ffile_directory_p and avoids a minor race.
8366
90186c68
LMI
83672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8368
7c301272
LMI
8369 * buffer.c (Foverlay_put): Say what the return value is
8370 (bug#7835).
8371
c4f2d8d4
LMI
8372 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8373 is a directory before asking whether to use the file name
8374 (bug#7564).
ad637907
LMI
8375 (barf_or_query_if_file_exists): Make the "File is a directory"
8376 error be more correct.
c4f2d8d4 8377
90186c68
LMI
8378 * fns.c (Frequire): Remove the mention of the .gz files, since
8379 that's installation-specific, but keep the mention of
8380 `get-load-suffixes'.
8381
da64016e
PE
83822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8383
8384 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8385 Report string overflow if the output is too long.
8386
7d47b580
JB
83872011-07-04 Juanma Barranquero <lekktu@gmail.com>
8388
a555cb87
JB
8389 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8390 (syms_of_gnutls): Remove duplicate DEFSYM for
8391 Qgnutls_bootprop_verify_hostname_error, an error for
8392 Qgnutls_bootprop_verify_error (which is no longer used).
8393
7d47b580
JB
8394 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8395 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8396 Also (re)move comments that are misplaced or no longer relevant.
8397
1e49bfab
LMI
83982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8399
8400 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8401
1485f4c0
CY
84022011-07-03 Chong Yidong <cyd@stupidchicken.com>
8403
8404 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8405 and background color parameters if they have been changed.
8406
a9ab721e
LMI
84072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8408
8409 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8410
cf7cff57
PE
84112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8412
2e13213d
PE
8413 * xsettings.c (SYSTEM_FONT): Define only when used.
8414 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8415
cf7cff57
PE
8416 * keymap.c (access_keymap_1): Now static.
8417
7a8e04f7
CY
84182011-07-02 Chong Yidong <cyd@stupidchicken.com>
8419
8420 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8421 leave any prefix arg for the up event (Bug#1586).
8422
61352f62
LMI
84232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8424
69bb1ef7
LMI
8425 * lread.c (syms_of_lread): Mention single symbols defined by
8426 `defvar' or `defconst' (bug#7154).
8427
61352f62 8428 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8429 (Frequire): Mention get-load-suffixes.
61352f62 8430
28545e04
MR
84312011-07-02 Martin Rudalics <rudalics@gmx.at>
8432
8433 * window.h (window): Remove clone_number slot.
8434 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8435 Remove.
8436 (make_parent_window, make_window, saved_window)
8437 (Fset_window_configuration, save_window_save): Don't deal with
8438 clone numbers.
8439 * buffer.c (Qclone_number): Remove declaration.
8440 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8441
3349e122
SM
84422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8443
8444 Add multiple inheritance to keymaps.
8445 * keymap.c (Fmake_composed_keymap): New function.
8446 (Fset_keymap_parent): Simplify.
8447 (fix_submap_inheritance): Remove.
8448 (access_keymap_1): New function extracted from access_keymap to handle
8449 embedded parents and handle lists of maps.
8450 (access_keymap): Use it.
8451 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8452 (Fcopy_keymap): Handle embedded parents.
8453 (Fcommand_remapping, define_as_prefix): Simplify.
8454 (Fkey_binding): Simplify.
8455 (syms_of_keymap): Move minibuffer-local-completion-map,
8456 minibuffer-local-filename-completion-map,
8457 minibuffer-local-must-match-map, and
8458 minibuffer-local-filename-must-match-map to Elisp.
8459 (syms_of_keymap): Defsubr make-composed-keymap.
8460 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8461 (parse_menu_item): Trivial simplification.
8462
3279eb87
GM
84632011-07-01 Glenn Morris <rgm@gnu.org>
8464
8465 * Makefile.in (SETTINGS_LIBS): Fix typo.
8466
4550efdf
KI
84672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8468
8469 * coding.c (Fencode_coding_string): Record the last coding system
8470 used, as the function doc string says (bug#8738).
8471
0949d2b6
JD
84722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8473
8474 * xsettings.c (store_monospaced_changed): Take new font as arg and
8475 check for change against current_mono_font.
8476 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8477 (emacs_settings_constructor, emacs_settings_get_property)
8478 (emacs_settings_set_property, emacs_settings_class_init)
8479 (emacs_settings_init, gsettings_obj): Remove.
8480 (something_changedCB): New function for HAVE_GSETTINGS.
8481 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8482 with value as argument.
8483 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8484 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8485 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8486 "changed".
8487
8488 * xgselect.c: Add defined (HAVE_GSETTINGS).
8489 (xgselect_initialize): Ditto.
8490
8491 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8492 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8493 xg_select.
8494
bbc6b304
PE
84952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8496
8497 * eval.c (struct backtrace): Simplify and port the data structure.
8498 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8499 signed bit field, as this assumption is not portable and it makes
8500 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8501 "char debug_on_exit : 1" as this is not portable either; instead,
8502 use the portable "unsigned int debug_on_exit : 1". Remove unused
8503 member evalargs. Remove obsolete comments about cc bombing out.
8504
9851bfc5
JD
85052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8506
51bb811f 8507 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8508 Let HAVE_GSETTINGS override HAVE_GCONF.
8509 (store_monospaced_changed): New function.
8510 (EMACS_SETTINGS): A new type derived from GObject to handle
8511 GSettings notifications.
8512 (emacs_settings_constructor, emacs_settings_get_property)
8513 (emacs_settings_set_property, emacs_settings_class_init):
8514 New functions.
8515 (gsettings_client, gsettings_obj): New variables.
8516 (GSETTINGS_SCHEMA): New define.
8517 (something_changedCB): Call store_monospaced_changed.
8518 (init_gsettings): New function.
8519 (xsettings_initialize): Call init_gsettings.
8520 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8521 to NULL.
8522
640c8776 8523 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8524 GCONF_CFLAGS/LIBS.
8525
5386012d
MR
85262011-06-29 Martin Rudalics <rudalics@gmx.at>
8527
8528 * window.c (resize_root_window, grow_mini_window)
8529 (shrink_mini_window): Rename Qresize_root_window to
8530 Qwindow_resize_root_window and Qresize_root_window_vertically to
8531 Qwindow_resize_root_window_vertically.
8532
f13e0b08
PE
85332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8534
8535 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8536
94515237
JB
85372011-06-27 Juanma Barranquero <lekktu@gmail.com>
8538
8539 * makefile.w32-in: Redesign dependencies so they reflect more
8540 clearly which files are directly included by each source file,
8541 and not through other includes.
8542
e43b6e43
MR
85432011-06-27 Martin Rudalics <rudalics@gmx.at>
8544
8545 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8546 (sort_overlays, overlay_strings): When an overlay's clone number
8547 matches the window's clone number process the overlay even if
8548 the overlay's window property doesn't match the current window.
8549
d68443dc
MR
8550 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8551 (Fwindow_hchild): Rename to Fwindow_left_child.
8552 (Fwindow_next): Rename to Fwindow_next_sibling.
8553 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8554 (resize_window_check): Rename to window_resize_check.
8555 (resize_window_apply): Rename to window_resize_apply.
8556 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8557 (Fdelete_other_windows_internal, resize_frame_windows)
8558 (Fsplit_window_internal, Fdelete_window_internal)
8559 (grow_mini_window, shrink_mini_window)
8560 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8561
c7e73be5
JD
85622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8563
8564 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8565 (emacs_fixed_set_min_size): Remove.
8566 (emacs_fixed_new): Take frame as argument.
8567
8568 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8569 (_EmacsFixedPrivate): Remove minwidth/height.
8570 Add struct frame *f.
8571 (emacs_fixed_init): Initialize priv->f.
8572 (get_parent_class, emacs_fixed_set_min_size): Remove.
8573 (emacs_fixed_new): Set priv->f to argument.
8574 (emacs_fixed_get_preferred_width)
8575 (emacs_fixed_get_preferred_height): Use min_width/height from
8576 frames size_hint to set minimum and natural (Bug#8919).
8577 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8578 and use min_width/height from frames size_hint to set
8579 min_width/height (Bug#8919).
8580
8581 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8582 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8583 Fix indentation.
c7e73be5 8584
cf99dcf8
EZ
85852011-06-26 Eli Zaretskii <eliz@gnu.org>
8586
8587 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8588 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8589 called at ZV.
8590
029529ac
CY
85912011-06-26 Chong Yidong <cyd@stupidchicken.com>
8592
8593 * process.c (wait_reading_process_output): Bypass select if
8594 waiting for a cell while ignoring keyboard input, and input is
8595 pending. Suggested by Jan Djärv (Bug#8869).
8596
7a7ef429
PE
85972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8598
8599 Use gnulib's dup2 module instead of rolling our own.
8600 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8601
11fdef7d 86022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8603
8604 * dispnew.c (scrolling_window): Before scrolling, turn off a
8605 mouse-highlight in the window being scrolled.
8606
cd3520a4
JB
86072011-06-24 Juanma Barranquero <lekktu@gmail.com>
8608
8609 Move DEFSYM to lisp.h and use everywhere.
8610
8611 * character.h (DEFSYM): Move declaration...
8612 * lisp.h (DEFSYM): ...here.
8613
8614 * gnutls.c:
8615 * minibuf.c:
8616 * w32menu.c:
8617 * w32proc.c:
8618 * w32select.c: Don't include character.h.
8619
8620 * alloc.c (syms_of_alloc):
8621 * buffer.c (syms_of_buffer):
8622 * bytecode.c (syms_of_bytecode):
8623 * callint.c (syms_of_callint):
8624 * casefiddle.c (syms_of_casefiddle):
8625 * casetab.c (init_casetab_once):
8626 * category.c (init_category_once, syms_of_category):
8627 * ccl.c (syms_of_ccl):
8628 * cmds.c (syms_of_cmds):
8629 * composite.c (syms_of_composite):
8630 * dbusbind.c (syms_of_dbusbind):
8631 * dired.c (syms_of_dired):
8632 * dispnew.c (syms_of_display):
8633 * doc.c (syms_of_doc):
8634 * editfns.c (syms_of_editfns):
8635 * emacs.c (syms_of_emacs):
8636 * eval.c (syms_of_eval):
8637 * fileio.c (syms_of_fileio):
8638 * fns.c (syms_of_fns):
8639 * frame.c (syms_of_frame):
8640 * fringe.c (syms_of_fringe):
8641 * insdel.c (syms_of_insdel):
8642 * keymap.c (syms_of_keymap):
8643 * lread.c (init_obarray, syms_of_lread):
8644 * macros.c (syms_of_macros):
8645 * msdos.c (syms_of_msdos):
8646 * print.c (syms_of_print):
8647 * process.c (syms_of_process):
8648 * search.c (syms_of_search):
8649 * sound.c (syms_of_sound):
8650 * syntax.c (init_syntax_once, syms_of_syntax):
8651 * terminal.c (syms_of_terminal):
8652 * textprop.c (syms_of_textprop):
8653 * undo.c (syms_of_undo):
8654 * w32.c (globals_of_w32):
8655 * window.c (syms_of_window):
8656 * xdisp.c (syms_of_xdisp):
8657 * xfaces.c (syms_of_xfaces):
8658 * xfns.c (syms_of_xfns):
8659 * xmenu.c (syms_of_xmenu):
8660 * xsettings.c (syms_of_xsettings):
8661 * xterm.c (syms_of_xterm): Use DEFSYM.
8662
4228cf16
TZ
86632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8664
cd3520a4 8665 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8666
7fcccf1e
PE
86672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8668
7efb4e0e
PE
8669 Integer and buffer overflow fixes (Bug#8873).
8670
ff5844ad
PE
8671 * print.c (printchar, strout): Check for string overflow.
8672 (PRINTPREPARE, printchar, strout):
8673 Don't set size unless allocation succeeds.
8674
90532f02
PE
8675 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8676 for sizes. Check for string overflow more accurately.
8677 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8678
6d84508d
PE
8679 * macros.c: Integer and buffer overflow fixes.
8680 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8681 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8682 Use ptrdiff_t, not int, for sizes.
8683 Don't increment bufsize until after realloc succeeds.
8684 Check for size-calculation overflow.
8685 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8686
437b2cb4
PE
8687 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8688
8b9ac8b4
PE
8689 * lread.c: Integer overflow fixes.
8690 (read_integer): Radix is now EMACS_INT, not int,
8691 to improve quality of diagnostics for out-of-range radices.
8692 Calculate buffer size correctly for out-of-range radices.
8693 (read1): Check for integer overflow in radices, and in
8694 read-circle numbers.
82cb60d3
PE
8695 (read_escape): Avoid int overflow.
8696 (Fload, openp, read_buffer_size, read1)
8697 (substitute_object_recurse, read_vector, read_list, map_obarray):
8698 Use ptrdiff_t, not int, for sizes.
8699 (read1): Use EMACS_INT, not int, for sizes.
20270765 8700 Check for size overflow.
8b9ac8b4 8701
7fcccf1e
PE
8702 * image.c (cache_image): Check for size arithmetic overflow.
8703
bfbbd7e7
PE
8704 * lread.c: Integer overflow issues.
8705 (saved_doc_string_size, saved_doc_string_length)
8706 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8707 Now ptrdiff_t, not int.
8708 (read1): Don't assume doc string length fits in int. Check for
8709 out-of-range doc string lengths.
8710 (read_list): Don't assume file position fits in int.
39019e54 8711 (read_escape): Check for hex character overflow.
bfbbd7e7 8712
4e323265
LL
87132011-06-22 Leo Liu <sdl.web@gmail.com>
8714
8715 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8716 Move to minibuffer.el.
8717
85fece3e
PE
87182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8719
20b84ce9 8720 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8721 The following patches are for when GLYPH_DEBUG && !XASSERT.
8722 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8723 * dispnew.c (flush_stdout):
8724 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8725 Mark as externally visible.
8726 * dispnew.c (check_window_matrix_pointers): Now static.
8727 * dispnew.c (window_to_frame_vpos):
8728 * xfns.c (unwind_create_frame):
8729 * xterm.c (x_check_font): Remove unused local.
8730 * scroll.c (CHECK_BOUNDS):
8731 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8732 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8733 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8734 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8735 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8736 Now static.
8737 (debug_method_add): Use va_list and vsprintf rather than relying
8738 on undefined behavior with wrong number of arguments.
8739 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8740 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8741 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8742 since we're not interested in debugging glyphs with old libraries.
8743 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8744 GCC 4.6.0's static checking.
8745
0766b489
PE
87462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8747
31fd4b32
PE
8748 Integer overflow and signedness fixes (Bug#8873).
8749 A few related buffer overrun fixes, too.
8750
b79e8648
PE
8751 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8752
0766b489
PE
8753 * dispextern.h (struct face.stipple):
8754 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8755 (x_bitmap_mask, x_allocate_bitmap_record)
8756 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8757 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8758 (x_create_bitmap_from_xpm_data):
8759 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8760 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8761 (.bitmaps_last):
8762 * xfaces.c (load_pixmap):
8763 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8764 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8765 (.bitmaps_last, struct x_output.icon_bitmap):
8766 Use ptrdiff_t, not int, for bitmap indexes.
8767 (x_allocate_bitmap_record): Check for size overflow.
8768 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8769
b081724f
PE
8770 Use ptrdiff_t, not int, for overlay counts.
8771 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8772 * editfns.c (overlays_around, get_pos_property):
8773 * textprop.c (get_char_property_and_overlay):
8774 * xdisp.c (next_overlay_change, note_mouse_highlight):
8775 * xfaces.c (face_at_buffer_position):
21514da7
PE
8776 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8777 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8778 (Fnext_overlay_change, Fprevious_overlay_change)
8779 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8780 Use ptrdiff_t, not int, for sizes.
21514da7 8781 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8782
3de73e5e
PE
8783 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8784
2606c57b
PE
8785 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8786 (x_session_initialize): Do not assume string length fits in int.
8787
aaafe47a
PE
8788 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8789 This is unlikely, but can occur if DPI is outlandish.
8790
2674ddc8 8791 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8792 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8793
28154962
PE
8794 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8795 * xrdb.c (magic_file_p, search_magic_path):
8796 Omit last arg SUFFIX; it was always 0. All callers changed.
8797 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8798
7de51af5
PE
8799 * xfont.c (xfont_match): Avoid need for strlen.
8800
25ed6cc3
PE
8801 * xfns.c: Don't assume strlen fits in int.
8802 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8803
4eab31dd
PE
8804 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8805 not unsigned long, as we prefer signed integers. All callers changed.
8806 Detect integer overflow in repeat count.
8807 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8808 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8809
171e2a58
PE
8810 * termcap.c: Don't assume sizes fit in int and never overflow.
8811 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8812 (gobble_line): Check for size-calculation overflow.
8813
ad39faca 8814 * minibuf.c (Fread_buffer):
6e5bb2dc 8815 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8816 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8817 Don't assume string length fits in int.
8818
52c61c22 8819 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8820 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8821
b5b8c9e5
PE
8822 * font.c: Don't assume string length fits in int.
8823 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8824 Use ptrdiff_t, not int.
ccd6111c
PE
8825 (font_intern_prop): Don't assume string length fits in int.
8826 Don't assume integer property fits in fixnum.
8827 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8828
882f0d81 8829 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8830 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8831 Reformulate so as not to need the command string.
8832 Invoke gzip -cd rather than gunzip, as it's more portable.
8833 (lock_info_type, lock_file_1, lock_file):
8834 Don't assume pid_t and time_t fit in unsigned long.
8835 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8836 (current_lock_owner): Prefer signed type for sizes.
8837 Use memcpy, not strncpy, where memcpy is what is really wanted.
8838 Don't assume (via atoi) that time_t and pid_t fit in int.
8839 Check for time_t and/or pid_t out of range, e.g., via a network share.
8840 Don't alloca where an auto var works fine.
8841
93f4cf88
PE
8842 * fileio.c: Fix some integer overflow issues.
8843 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8844 Don't assume string length fits in int.
8845 (directory_file_name): Don't assume string length fits in long.
8846 (make_temp_name): Don't assume pid fits in int, or that its print
8847 length is less than 20.
8848
f3e92b69
PE
8849 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8850
1bfdaf10
PE
8851 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8852
35016e9a
PE
8853 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8854
3d1e65a1
PE
8855 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8856 We prefer signed integers, even for size calculations.
8857
0b963a93
PE
8858 * emacs.c: Don't assume string length fits in 'int'.
8859 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8860 (main): Don't invoke strlen when not needed.
8861
573f4b54
PE
8862 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8863 (XD_DEBUG_MESSAGE): Don't waste a byte.
8864
989f33ba
PE
8865 * callproc.c (getenv_internal_1, getenv_internal)
8866 (Fgetenv_internal):
965d34eb
PE
8867 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8868
e4d29b33
PE
8869 * lread.c (invalid_syntax): Omit length argument.
8870 All uses changed. This doesn't fix a bug, but it simplifies the
8871 code away from its former Hollerith-constant appearance, and it's
8872 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8873 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8874
eb49b136
PE
8875 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8876 This didn't break anything, but it didn't help either.
8877 It's confusing to put a bogus integer in a place where the actual
8878 value does not matter.
9f62aeb1 8879 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8880 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8881
15375a22
PE
8882 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8883 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8884 implementation.
b61cc01c
PE
8885 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8886 We prefer signed types, and the value cannot exceed the EMACS_INT
8887 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8888 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8889 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8890 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8891
53b2623d
PE
8892 * indent.c (sane_tab_width): New function.
8893 (current_column, scan_for_column, Findent_to, position_indentation)
8894 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8895 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8896
51cab52b 8897 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8898
f2ed8a70
PE
8899 * lisp.h (lint_assume): New macro.
8900 * composite.c (composition_gstring_put_cache):
8901 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8902
abe80cc6
PE
8903 * editfns.c, insdel.c:
8904 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8905
b02c740e
PE
8906 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8907
ebc96716
PE
8908 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8909
b4e50fa0 8910 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8911 Use much-faster test for byte-length change.
311d5d7c 8912 Don't assume string byte-length fits in 'int'.
a4cf38e4 8913 Check that character arg fits in 'int'.
85461888 8914 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8915
c0c1ee9f
PE
8916 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8917
a498d7f4
PE
8918 * fns.c (concat): Catch string overflow earlier.
8919 Do not rely on integer wraparound.
8920
51cab52b
PE
8921 * dispextern.h (struct it.overlay_strings_charpos)
8922 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8923 * xdisp.c (forward_to_next_line_start)
8924 (back_to_previous_visible_line_start)
8925 (reseat_at_next_visible_line_start, next_element_from_buffer):
8926 Don't arbitrarily truncate the value of 'selective' to int.
8927
76031fad
PE
8928 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8929
5eb55db9
PE
8930 * composite.c: Don't truncate sizes to 'int'.
8931 (composition_gstring_p, composition_reseat_it)
8932 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8933 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8934 not EMACS_UINT, for indexes.
5eb55db9 8935
0703a717
PE
8936 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8937
d6202519
PE
8938 * buffer.c: Include <verify.h>.
8939 (struct sortvec.priority, struct sortstr.priority):
8961a454 8940 Now EMACS_INT, not int.
c20998a7 8941 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8942 (struct sortstr.size, record_overlay_string)
8943 (struct sortstrlist.size, struct sortlist.used):
8944 Don't truncate size to int.
8945 (record_overlay_string): Check for size-calculation overflow.
d6202519 8946 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8947
d5a19415
JM
89482011-06-22 Jim Meyering <meyering@redhat.com>
8949
029529ac 8950 Don't leak an XBM-image-sized buffer
d5a19415
JM
8951 * image.c (xbm_load): Free the image buffer after using it.
8952
a9041e6c
PE
89532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8954
8955 Port to Sun C.
8956 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8957 that Sun C diagnosed.
8958 * fns.c (secure_hash): Fix pointer signedness issue.
8959 * intervals.c (static_offset_intervals): New function.
8960 (offset_intervals): Use it.
8961
7f3f739f
LL
89622011-06-21 Leo Liu <sdl.web@gmail.com>
8963
8964 * deps.mk (fns.o):
8965 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8966 sha512.h.
8967
8968 * fns.c (secure_hash): Rename from crypto_hash_function and change
8969 the first arg to accept symbols.
5b66d427 8970 (Fsecure_hash): New primitive.
7f3f739f
LL
8971 (syms_of_fns): New symbols.
8972
76147d94
DD
89732011-06-20 Deniz Dogan <deniz@dogan.se>
8974
8975 * process.c (Fset_process_buffer): Clarify return value in
8976 docstring.
8977
7d7d0045
CY
89782011-06-18 Chong Yidong <cyd@stupidchicken.com>
8979
8980 * dispnew.c (add_window_display_history): Use BVAR.
8981
8982 * xdisp.c (debug_method_add): Use BVAR.
8983 (check_window_end, dump_glyph_matrix, dump_glyph)
8984 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8985
8986 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8987 Likewise.
8988
8989 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8990 check till after the cache is created in init_frame_faces.
8991
ff2bc410
SM
89922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8993
8994 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8995
28177add
PE
89962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8997
dd3482fe
PE
8998 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8999 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9000 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9001
393d71f3 9002 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9003 * fileio.c (Finsert_file_contents):
9004 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9005 Remove the old (too-loose) buffer overflow checks.
9006 They weren't needed, since make_gap checks for buffer overflow.
9007 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9008 The old code merely checked for Emacs fixnum overflow, and relied
9009 on undefined (wraparound) behavior. The new code avoids undefined
9010 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9011
2e6813b0 9012 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9013 Tune. Don't use wider integers than needed. Don't use alloca.
9014 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9015
599a9e4f
PE
9016 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9017
99561444
PE
9018 * insdel.c, lisp.h (buffer_overflow): New function.
9019 (insert_from_buffer_1, replace_range, replace_range_2):
9020 * insdel.c (make_gap_larger):
9021 * editfns.c (Finsert_char):
9022 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9023
28177add
PE
9024 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9025
e69dafad
PE
90262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9027
4baa020d 9028 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9029
b1c46f02
PE
9030 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9031 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9032
e69dafad
PE
9033 * fileio.c: Don't assume EMACS_INT fits in off_t.
9034 (emacs_lseek): New static function.
9035 (Finsert_file_contents, Fwrite_region): Use it.
9036 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9037
566684ea
PE
9038 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9039
e6966cd6
PE
9040 * fns.c: Don't overflow int when computing a list length.
9041 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9042 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9043 truncation on 64-bit hosts. Check for QUIT every
9044 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9045 faster and is responsive enough.
9046 (Flength): Report an error instead of overflowing an integer.
9047 (Fsafe_length): Return a float if the value is not representable
9048 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9049 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9050 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9051
dd0b0efb
PE
9052 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9053 (header_size, word_size): New constants.
9054 (allocate_vectorlike): Don't check size overflow here.
9055 (allocate_vector): Check it here instead, since this is the only
9056 caller of allocate_vectorlike that could cause overflow.
9057 Check that the new vector's length is representable as a fixnum.
9058
86fe5cfe
PE
9059 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9060 The previous code was bogus. For example, next_almost_prime (32)
9061 returned 39, which is undesirable as it is a multiple of 3; and
9062 next_almost_prime (24) returned 25, which is a multiple of 5 so
9063 why was the code bothering to check for multiples of 7?
9064
80e88859
PE
9065 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9066
4a2f0ad6
PE
9067 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9068
f66c7cf8
PE
9069 Variadic C functions now count arguments with ptrdiff_t.
9070 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9071 Back then I didn't know that the Emacs coding style prefers signed int.
9072 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9073 were being counted with int, which may truncate counts on 64-bit
9074 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9075 * lisp.h (struct Lisp_Subr.function.aMANY)
9076 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9077 Arg counts are now ptrdiff_t, not size_t.
9078 All variadic functions and their callers changed accordingly.
9079 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9080 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9081 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9082 * callint.c (Fcall_interactively): Check arg count for overflow,
9083 to avoid potential buffer overrun. Use signed char, not 'int',
9084 for 'varies' array, so that we needn't bother to check its size
9085 calculation for overflow.
9086 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9087 * eval.c (apply_lambda):
9088 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9089 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9090 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9091
a1759b76
PE
9092 * callint.c (Fcall_interactively): Don't use index var as event count.
9093
d96be9fc
PE
9094 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9095 * mem-limits.h (SIZE): Remove; no longer used.
9096
a690a978 9097 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9098
578c21e6
PE
9099 Remove unnecessary casts.
9100 * xterm.c (x_term_init):
9101 * xfns.c (x_set_border_pixel):
9102 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9103 These aren't needed now that we assume ANSI C.
9104
96f53c6c
PE
9105 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9106 It's more likely to cause problems (due to unsigned overflow)
9107 than to cure them.
9108
83c77d31
PE
9109 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9110
ee2079f1
PE
9111 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9112
6da65536
PE
9113 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9114
7147c4a4
PE
9115 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9116
193e32d9
PE
9117 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9118
e5533da6
PE
9119 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9120
9910e595
PE
9121 GLYPH_CODE_FACE returns EMACS_INT, not int.
9122 * dispextern.h (merge_faces):
9123 * xfaces.c (merge_faces):
01103c44
PE
9124 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9125 Don't assume EMACS_INT fits in int.
9910e595 9126
2638320e
PE
9127 * character.h (CHAR_VALID_P): Remove unused parameter.
9128 * fontset.c, lisp.h, xdisp.c: All uses changed.
9129
045eb8d9
PE
9130 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9131
c1f134b5
PE
9132 * fns.c (concat): Minor tuning based on overflow analysis.
9133 This doesn't fix any bugs. Use int to hold character, instead
9134 of constantly refetching from Emacs object. Use XFASTINT, not
9135 XINT, for value known to be a character. Don't bother comparing
9136 a single byte to 0400, as it's always less.
9137
395fcb93 9138 * floatfns.c (Fexpt):
327eeec8
PE
9139 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9140
abbd3d23
PE
9141 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9142 for characters.
9143
684a03ef
PE
9144 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9145
0fed43f3
PE
9146 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9147 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9148 incorrectly succeed when S was a string, because 4294967386 was
9149 truncated before it was used.
9150
8fd02eb7
PE
9151 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9152 Otherwise, an out-of-range integer could cause undefined behavior
9153 on a 64-bit host.
9154
f8c86b69
PE
9155 * composite.c: Use int, not EMACS_INT, for characters.
9156 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9157 EMACS_INT, for values that are known to be in character range.
9158 This doesn't fix any bugs but is the usual style inside Emacs and
9159 may generate better code on 32-bit machines.
9160
34206dd2
PE
9161 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9162 This is for reasons similar to the recent CHAR_STRING fix.
9163 * charset.c (Fencode_char): Check that character arg is actually
9164 a character. Pass an int to ENCODE_CHAR.
9165 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9166 wider than 'int', as a compile-time check to prevent future regressions
9167 in this area.
9168
c5958d4c 9169 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9170
9171 Make sure a 64-bit char is never passed to CHAR_STRING.
9172 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9173 by silently ignoring the top 32 bits, allowing some values
9174 that were far too large to be valid characters.
9175 * character.h: Include <verify.h>.
9176 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9177 arguments are no wider than unsigned, as a compile-time check
9178 to prevent future regressions in this area.
9179 * data.c (Faset):
01103c44 9180 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9181 (Fsubst_char_in_region):
9182 * fns.c (concat):
9183 * xdisp.c (decode_mode_spec_coding):
9184 Adjust to CHAR_STRING's new requirement.
9185 * editfns.c (Finsert_char, Fsubst_char_in_region):
9186 * fns.c (concat): Check that character args are actually
9187 characters. Without this test, these functions did the wrong
9188 thing with wildly out-of-range values on 64-bit hosts.
9189
d37ca623
PE
9190 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9191 These casts should not be needed on 32-bit hosts, either.
9192 * keyboard.c (read_char):
9193 * lread.c (Fload): Remove casts to unsigned.
9194
ea204efb
PE
9195 * lisp.h (UNSIGNED_CMP): New macro.
9196 This fixes comparison bugs on 64-bit hosts.
9197 (ASCII_CHAR_P): Use it.
9198 * casefiddle.c (casify_object):
01103c44 9199 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9200 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9201 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9202 * dispextern.h (FACE_FROM_ID):
9203 * keyboard.c (read_char): Use UNSIGNED_CMP.
9204
41cb286c
PE
9205 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9206 not to EMACS_INT, to avoid GCC warning.
9207
4a1b9832
PE
9208 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9209
55daad71
PE
9210 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9211 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9212 isn't needed on 32-bit machines.
8f95c75c 9213
01103c44
PE
9214 * buffer.c (Fgenerate_new_buffer_name):
9215 Use EMACS_INT for count, not int.
0ceccced 9216 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9217
9218 * data.c (Qcompiled_function): Now static.
9219
c6f072e7
PE
9220 * window.c (window_body_lines): Now static.
9221
20ce5912
PE
9222 * image.c (gif_load): Rename local to avoid shadowing.
9223
9c4c5f81
PE
9224 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9225 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9226 * alloc.c (make_save_value): Integer argument is now of type
9227 ptrdiff_t, not int.
9228 (mark_object): Use ptrdiff_t, not int.
9229 * lisp.h (pD): New macro.
9230 * print.c (print_object): Use it.
9231
c0c5c8ae
PE
9232 * alloc.c: Use EMACS_INT, not int, to count objects.
9233 (total_conses, total_markers, total_symbols, total_vector_size)
9234 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9235 (total_free_floats, total_floats, total_free_intervals)
9236 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9237 Now EMACS_INT, not int. All uses changed.
9238 (Fgarbage_collect): Compute overall total using a double, so that
9239 integer overflow is less likely to be a problem. Check for overflow
9240 when converting back to an integer.
5a25e253
PE
9241 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9242 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9243 These were 'int' variables that could overflow on 64-bit hosts;
9244 they were never used, so remove them instead of repairing them.
211a0b2a 9245 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9246 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9247 Previously, this ceilinged at INT_MAX, but that doesn't work on
9248 64-bit machines.
e46bb31a 9249 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9250
c78baabf 9251 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9252 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9253 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9254 when a (possibly-narrower) signed value would do just as well.
9255 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9256
c9d624c6
PE
9257 * alloc.c: Catch some string size overflows that we were missing.
9258 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9259 for convenience in STRING_BYTES_MAX.
9260 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9261 The definition here is exact; the one in lisp.h was approximate.
9262 (allocate_string_data): Check for string overflow. This catches
9263 some instances we weren't catching before. Also, it catches
9264 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9265 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9266 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9267
c9d624c6
PE
9268 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9269 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9270 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9271
353032ce
PE
9272 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9273
2bccce07
PE
9274 * alloc.c (Fmake_string): Check for out-of-range init.
9275
0ac30604
SM
92762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9277
9278 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9279
c195f2de
JD
92802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9281
9282 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9283 xg_get_default_scrollbar_width.
9284
9285 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9286 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9287 (style_changed_cb): Call update_theme_scrollbar_width and call
9288 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9289 all frames (Bug#8505).
9290 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9291 Call gtk_window_set_resizable if HAVE_GTK3.
9292 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9293 and height if HAVE_GTK3 (Bug#8505).
9294 (scroll_bar_width_for_theme): New variable.
9295 (update_theme_scrollbar_width): New function.
9296 (xg_get_default_scrollbar_width): Move code to
9297 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9298 (xg_initialize): Call update_theme_scrollbar_width.
9299
9300 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9301
9302 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9303
e10ac9f1
MR
93042011-06-12 Martin Rudalics <rudalics@gmx.at>
9305
9306 * frame.c (make_frame): Call other_buffer_safely instead of
9307 other_buffer.
9308
9309 * window.c (temp_output_buffer_show): Call display_buffer with
9310 second argument Vtemp_buffer_show_specifiers and reset latter
9311 immediately after the call.
9312 (Vtemp_buffer_show_specifiers): New variable.
9313 (auto_window_vscroll_p, next_screen_context_lines)
9314 (Vscroll_preserve_screen_position): Remove leading asterisks from
9315 doc-strings.
9316
2d3c217e 93172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9318
7b7f97e8 9319 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9320 * buffer.c (Qclone_number): Remove for now, as it's unused.
9321 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9322 (record_buffer): Remove unused local.
9323 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9324 (set_frame_buffer_list): Remove; unused.
9325 * frame.h (other_visible_frames): Remove decl.
9326 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9327 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9328 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9329 if HAVE_GPM.
9330 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9331 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9332 Define only if HAVE_GPM.
9333 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9334 (update_hints_inhibit): Remove; never set. All uses removed.
9335 * widgetprv.h (emacsFrameClassRec): Remove decl.
9336 * window.c (delete_deletable_window): Now returns void, since it
9337 wasn't returning anything.
9338 (compare_window_configurations): Remove unused locals.
9339 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9340 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9341 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9342 the same widths as pointers. This follows up on the 2011-05-06 patch.
9343 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9344 * xterm.h: Likewise.
9345 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9346
1384b89e
JB
93472011-06-12 Juanma Barranquero <lekktu@gmail.com>
9348
9349 * makefile.w32-in: Update dependencies.
9350 (LISP_H): Add lib/intprops.h.
9351
1100a63c
CY
93522011-06-11 Chong Yidong <cyd@stupidchicken.com>
9353
9354 * image.c (gif_load): Add animation frame delay to the metadata.
9355 (syms_of_image): Use DEFSYM. New symbol `delay'.
9356
6198ccd0
MR
93572011-06-11 Martin Rudalics <rudalics@gmx.at>
9358
9359 * window.c (delete_deletable_window): Re-add.
9360 (Fset_window_configuration): Rewrite to handle dead buffers and
9361 consequently deletable windows.
9362 (window_tree, Fwindow_tree): Remove. Supply functionality in
9363 window.el.
9364 (compare_window_configurations): Simplify code.
9365
b6e3633c
AS
93662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9367
1ab0dee5
AS
9368 * image.c (imagemagick_load_image): Fix type mismatch.
9369 (Fimagemagick_types): Likewise.
9370
b6e3633c
AS
9371 * window.h (replace_buffer_in_windows): Declare.
9372
9397e56f
MR
93732011-06-11 Martin Rudalics <rudalics@gmx.at>
9374
9375 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9376 Qclone_number. Remove external declaration of Qdelete_window.
9377 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9378 code.
640c8776
SM
9379 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9380 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9381 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9382 buffer list implementation.
9383 (other_buffer_safely): New function.
9384 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9385 calls to replace_buffer_in_windows and
9386 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9387 if allowed.
9388 (record_buffer): Inhibit quitting and rewrite using quittable
9389 functions. Run Qbuffer_list_update_hook if allowed.
9390 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9391 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9392 Move switch-to-buffer to window.el.
9397e56f
MR
9393 (bury-buffer): Move to window.el.
9394 (Vbuffer_list_update_hook): New variable.
9395
9396 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9397 section.
9398
9399 * window.h (resize_frame_windows): Move up in code.
9400 (Fwindow_frame): Remove EXFUN.
9401 (replace_buffer_in_all_windows): Remove prototype.
9402 (replace_buffer_in_windows_safely): Add prototype.
9403
9404 * window.c: Declare Qdelete_window static again. Move down
9405 declaration of select_count.
9406 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9407 (Fother_window): Move to window.el.
9408 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9409 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9410 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9411 window.el.
9412 (replace_buffer_in_windows): Implement by calling
9413 Qreplace_buffer_in_windows.
9414 (replace_buffer_in_all_windows): Remove with some functionality
9415 moved into replace_buffer_in_windows_safely.
9416 (replace_buffer_in_windows_safely): New function.
9417 (select_window_norecord, select_frame_norecord): Move in front
9418 of run_window_configuration_change_hook. Remove now obsolete
9419 declarations.
640c8776
SM
9420 (Fset_window_buffer): Rewrite doc-string.
9421 Call Qrecord_window_buffer.
9397e56f
MR
9422 (keys_of_window): Move binding for other-window to window.el.
9423
b50691aa
CY
94242011-06-11 Chong Yidong <cyd@stupidchicken.com>
9425
9426 * dispextern.h (struct image): Replace data member, whose int_val
9427 and ptr_val fields were not used by anything, with a single
9428 lisp_val object.
9429
9430 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9431 (gif_clear_image, gif_load, imagemagick_load_image)
9432 (gs_clear_image, gs_load): Callers changed.
9433
3f754b86
PE
94342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9435
cca69397
PE
9436 * buffer.h: Include <time.h>, for time_t.
9437 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9438
109e28d0
PE
9439 Fix minor problems found by static checking.
9440
60737f02
PE
9441 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9442
4b66faf3
PE
9443 Make identifiers static if they are not used in other modules.
9444 * data.c (Qcompiled_function, Qframe, Qvector):
9445 * image.c (QimageMagick, Qsvg):
9446 * minibuf.c (Qmetadata):
9447 * window.c (resize_window_check, resize_root_window): Now static.
9448 * window.h (resize_window_check, resize_root_window): Remove decls.
9449
109e28d0
PE
9450 * window.c (window_deletion_count, delete_deletable_window):
9451 Remove; unused.
46a4ce9e
PE
9452 (window_body_lines): Now static.
9453 (Fdelete_other_windows_internal): Mark vars as initialized.
9454 Make sure 'resize_failed' is initialized.
9455 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9456 (resize_window_apply): Remove unused local.
9457 * window.h (delete_deletable_window): Remove decl.
9458
109e28d0 9459 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9460 (imagemagick_load_image): Fix pointer signedness problem by changing
9461 last arg from unsigned char * to char *. All uses changed.
9462 Also, fix a local for similar reasons.
9463 Remove unused locals. Remove locals to avoid shadowing.
9464 (fn_rsvg_handle_free): Remove; unused.
9465 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9466 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9467
3f754b86
PE
9468 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9469
2547adb1
CY
94702011-06-10 Chong Yidong <cyd@stupidchicken.com>
9471
9472 * image.c (gif_load): Fix omitted cast error introduced by
9473 2011-06-06 change.
9474
2c8e37d4
MR
94752011-06-10 Martin Rudalics <rudalics@gmx.at>
9476
9477 * window.h (resize_proportionally, orig_total_lines)
9478 (orig_top_line): Remove from window structure.
9479 (set_window_height, set_window_width, change_window_heights)
9480 (Fdelete_window): Remove prototypes.
9481 (resize_frame_windows): Remove duplicate declaration.
9482
440a42e3
EZ
94832011-06-10 Eli Zaretskii <eliz@gnu.org>
9484
9485 * window.h (resize_frame_windows, resize_window_check)
9486 (delete_deletable_window, resize_root_window)
9487 (resize_frame_windows): Declare prototypes.
9488
9489 * window.c (resize_window_apply): Make definition be "static" to
9490 match the prototype.
9491
562dd5e9
MR
94922011-06-10 Martin Rudalics <rudalics@gmx.at>
9493
9494 * window.c: Remove declarations of Qwindow_size_fixed,
9495 window_min_size_1, window_min_size_2, window_min_size,
9496 size_window, window_fixed_size_p, enlarge_window, delete_window.
9497 Remove static from declaration of Qdelete_window, it's
9498 temporarily needed by Fbury_buffer.
9499 (replace_window): Don't assign orig_top_line and
9500 orig_total_lines.
9501 (Fdelete_window, delete_window): Remove. Window deletion is
9502 handled by window.el.
640c8776
SM
9503 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9504 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9505 (Fdelete_other_windows): Remove. Deleting other windows is
9506 handled by window.el.
9507 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9508 handled in window.el.
9509 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9510 Window minimum sizes are handled in window.el.
9511 (shrink_windows, size_window, set_window_height)
9512 (set_window_width, change_window_heights, window_height)
9513 (window_width, CURBEG, CURSIZE, enlarge_window)
9514 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9515 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9516 handled in window.el.
9517 (make_dummy_parent): Rename to make_parent_window and give it a
9518 second argument horflag.
9519 (make_window): Don't set resize_proportionally any more.
9520 (Fsplit_window): Remove. Windows are split in window.el.
9521 (save_restore_action, save_restore_orig_size)
9522 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9523 Resize mini windows in window.el.
9524 (grow_mini_window, shrink_mini_window): Implement by calling
9525 Qresize_root_window_vertically, resize_window_check and
9526 resize_window_apply.
640c8776
SM
9527 (saved_window, Fset_window_configuration, save_window_save):
9528 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9529 resize_proportionally.
9530 (window_min_height, window_min_width): Move to window.el.
9531 (keys_of_window): Move bindings for delete-other-windows,
9532 split-window, delete-window and enlarge-window to window.el.
9533
9534 * buffer.c: Temporarily extern Qdelete_window.
9535 (Fbury_buffer): Temporarily call Qdelete_window instead of
9536 Fdelete_window (Fbury_buffer will move to window.el soon).
9537
9538 * frame.c (set_menu_bar_lines_1): Remove code handling
9539 orig_top_line and orig_total_lines.
9540
9541 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9542 set_window_height but set heights directly.
9543 (change_frame_size_1): Use resize_frame_windows.
9544
9545 * xdisp.c (init_xdisp): Don't use set_window_height but set
9546 heights directly.
9547
640c8776
SM
9548 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9549 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9550 run_window_configuration_change_hook.
9551
9552 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9553 instead of change_window_heights and run
9554 run_window_configuration_change_hook.
9555
1a13852e
MR
95562011-06-09 Martin Rudalics <rudalics@gmx.at>
9557
9558 * window.c (replace_window): Rename second argument REPLACEMENT to
9559 NEW. New third argument SETFLAG. Rewrite.
9560 (delete_window, make_dummy_parent): Call replace_window with
9561 third argument 1.
9562 (window_list_1): Move down in code.
9563 (run_window_configuration_change_hook): Move set_buffer part
9564 before select_frame_norecord part in order to unwind correctly.
9565 Rename count1 to count.
9566 (recombine_windows, delete_deletable_window, resize_root_window)
9567 (Fdelete_other_windows_internal)
9568 (Frun_window_configuration_change_hook, make_parent_window)
9569 (resize_window_check, resize_window_apply, Fresize_window_apply)
9570 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9571 (Fdelete_window_internal, Fresize_mini_window_internal):
9572 New functions.
1a13852e
MR
9573 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9574
f3d1777e
MR
95752011-06-08 Martin Rudalics <rudalics@gmx.at>
9576
496e208e
MR
9577 * window.h (window): Add some new members to window structure -
9578 normal_lines, normal_cols, new_total, new_normal, clone_number,
9579 splits, nest, prev_buffers, next_buffers.
9580 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9581 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9582
f3d1777e
MR
9583 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9584 Remove.
496e208e
MR
9585 (make_dummy_parent): Set new members of windows structure.
9586 (make_window): Move down in code. Handle new members of window
9587 structure.
9588 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9589 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9590 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9591 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9592 (Fset_window_next_buffers, Fset_window_clone_number):
9593 New functions.
496e208e
MR
9594 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9595 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9596 Doc-string fixes.
9597 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9598 Argument WINDOW can be now internal window too.
9599 (Fwindow_use_time): Move up in code.
9600 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9601 Rewrite doc-string.
9602 (Fset_window_configuration, saved_window)
9603 (Fcurrent_window_configuration, save_window_save): Handle new
9604 members of window structure.
b9e809c2
MR
9605 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9606 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9607 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9608 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9609 Qget_mru_window, Qresize_root_window,
9610 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9611 Qauto_buffer_name; staticpro them.
f3d1777e 9612
abde8f8c
MR
96132011-06-07 Martin Rudalics <rudalics@gmx.at>
9614
9615 * window.c (Fwindow_total_size, Fwindow_left_column)
9616 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9617 (Fwindow_list_1): New functions.
9618 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9619 (Fwindow_width, Fscroll_left, Fscroll_right):
9620 Use window_body_cols instead of window_box_text_cols.
9621 (delete_window, Fset_window_configuration):
9622 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9623 (delete_all_subwindows): Take a window as argument and not a
9624 structure. Rewrite.
190b47e6
MR
9625 (window_loop): Remove handling of GET_LRU_WINDOW and
9626 GET_LARGEST_WINDOW.
9627 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9628
9629 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9630 window_box_text_cols. delete_all_subwindows now takes a
9631 Lisp_Object as argument.
abde8f8c 9632
640c8776
SM
9633 * indent.c (compute_motion, Fcompute_motion):
9634 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9635
fa8a67e6
MR
9636 * frame.c (delete_frame): Call delete_all_subwindows with root
9637 window as argument.
9638
a54e3482
DC
96392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9640
9641 * fns.c (Fputhash): Document return value.
9642
60002bf5
CY
96432011-06-06 Chong Yidong <cyd@stupidchicken.com>
9644
9645 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9646
0c671da6 96472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9648
b862a52a 9649 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9650
be44ca6c
PE
9651 Check for overflow when converting integer to cons and back.
9652 * charset.c (Fdefine_charset_internal, Fdecode_char):
9653 Use cons_to_unsigned to catch overflow.
9654 (Fencode_char): Use INTEGER_TO_CONS.
9655 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9656 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9657 * data.c (long_to_cons, cons_to_long): Remove.
9658 (cons_to_unsigned, cons_to_signed): New functions.
9659 These signal an error for invalid or out-of-range values.
9660 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9661 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9662 * font.c (Ffont_variation_glyphs):
9663 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9664 * lisp.h: Include <intprops.h>.
9665 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9666 (cons_to_signed, cons_to_unsigned): New decls.
9667 (long_to_cons, cons_to_long): Remove decls.
9668 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9669 (Fprimitive_undo): Use CONS_TO_INTEGER.
9670 * xfns.c (Fx_window_property): Likewise.
9671 * xselect.c: Include <limits.h>.
9672 (x_own_selection, selection_data_to_lisp_data):
9673 Use INTEGER_TO_CONS.
9674 (x_handle_selection_request, x_handle_selection_clear)
9675 (x_get_foreign_selection, Fx_disown_selection_internal)
9676 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9677 (lisp_data_to_selection_data): Use cons_to_unsigned.
9678 (x_fill_property_data): Use cons_to_signed.
9679 Report values out of range.
9680
d1f3d2af
PE
9681 Check for buffer and string overflow more precisely.
9682 * buffer.h (BUF_BYTES_MAX): New macro.
9683 * lisp.h (STRING_BYTES_MAX): New macro.
9684 * alloc.c (Fmake_string):
9685 * character.c (string_escape_byte8):
9686 * coding.c (coding_alloc_by_realloc):
9687 * doprnt.c (doprnt):
9688 * editfns.c (Fformat):
9689 * eval.c (verror):
9690 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9691 since they may not be the same number.
9692 * editfns.c (Finsert_char):
9693 * fileio.c (Finsert_file_contents):
9694 Likewise for BUF_BYTES_MAX.
9695
dd52fcea
PE
9696 * image.c: Use ptrdiff_t, not int, for sizes.
9697 (slurp_file): Switch from int to ptrdiff_t.
9698 All uses changed.
9699 (slurp_file): Check that file size fits in both size_t (for
9700 malloc) and ptrdiff_t (for sanity and safety).
9701
7f9bbdbb
PE
9702 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9703 if b->modtime has its maximal value.
9704
dfe18f82
PE
9705 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9706
84acfcf0
PE
9707 Don't assume time_t can fit into int.
9708 * buffer.h (struct buffer.modtime): Now time_t, not int.
9709 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9710 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9711
ccd9a01a
PE
9712 Minor fixes for signed vs unsigned integers.
9713 * character.h (MAYBE_UNIFY_CHAR):
9714 * charset.c (maybe_unify_char):
9715 * keyboard.c (read_char, reorder_modifiers):
9716 XINT -> XFASTINT, since the integer must be nonnegative.
9717 * ftfont.c (ftfont_spec_pattern):
9718 * keymap.c (access_keymap, silly_event_symbol_error):
9719 XUINT -> XFASTINT, since the integer must be nonnegative.
9720 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9721 since it makes no difference and we prefer signed.
9722 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9723 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9724 nonnegative.
9725
d6d100dd
SM
97262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9727
9728 * window.h (Fwindow_frame): Declare.
9729
2b6148e4
PE
97302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9731
9732 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9733 (SPARE_MEMORY): Always define.
9734 (LARGE_REQUEST): Remove.
9735 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9736
f230ecc9
MR
97372011-06-06 Martin Rudalics <rudalics@gmx.at>
9738
727e958e
MR
9739 * lisp.h: Move EXFUNS for Fframe_root_window,
9740 Fframe_first_window and Fset_frame_selected_window to window.h.
9741
9742 * window.h: Move EXFUNS for Fframe_root_window,
9743 Fframe_first_window and Fset_frame_selected_window here from
9744 lisp.h.
9745
9746 * frame.c (Fwindow_frame, Fframe_first_window)
9747 (Fframe_root_window, Fframe_selected_window)
9748 (Fset_frame_selected_window): Move to window.c.
9749 (Factive_minibuffer_window): Move to minibuf.c.
9750 (Fother_visible_frames_p): New function.
9751
9752 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9753
f230ecc9
MR
9754 * window.c (decode_window, decode_any_window): Move up in code.
9755 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9756 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9757 (Fwindow_buffer): Move up and rewrite doc-string.
9758 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9759 (Fwindow_prev): New functions.
727e958e
MR
9760 (Fwindow_frame): Move here from frame.c. Accept any window as
9761 argument.
9762 (Fframe_root_window, Fframe_first_window)
9763 (Fframe_selected_window): Move here from frame.c. Accept frame
9764 or arbitrary window as argument. Update doc-strings.
9765 (Fminibuffer_window): Move up in code.
9766 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9767 (Fset_frame_selected_window): Move here from frame.c.
9768 Marginal rewrite.
727e958e
MR
9769 (Fselected_window, select_window, Fselect_window): Move up in
9770 code. Minor doc-string fixes.
f230ecc9 9771
4d09bcf6
PE
97722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9773
9774 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9775 Do not assume that spare memory exists; that assumption is valid
9776 only if SYSTEM_MALLOC.
9777 (LARGE_REQUEST): New macro, so that the issue of large requests
9778 is separated from the issue of spare memory.
9779
810928a2
AS
97802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9781
172418ad
AS
9782 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9783 format. (Bug#8806)
9784
43f862f7
AS
9785 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9786
810928a2
AS
9787 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9788 before statements.
9789
a059fe24
JD
97902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9791
9792 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9793
9794 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9795
9796 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9797 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9798
989bf368
JB
97992011-06-05 Juanma Barranquero <lekktu@gmail.com>
9800
9801 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9802
4b80f674
CY
98032011-06-04 Chong Yidong <cyd@stupidchicken.com>
9804
9805 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9806 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9807 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9808 New error handlers.
4b80f674
CY
9809 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9810 Obey Vx_select_enable_clipboard_manager. Catch errors in
9811 x_clipboard_manager_save (Bug#8779).
9812 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9813 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9814
99a33b77 98152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9816
9817 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9818
99a33b77 98192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9820
9821 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9822 in the current matrix if keep_current_p is non-zero.
9823
8264569d
EZ
98242011-06-04 Eli Zaretskii <eliz@gnu.org>
9825
9826 * bidi.c (bidi_level_of_next_char): Fix last change.
9827
57f97249
EZ
98282011-06-03 Eli Zaretskii <eliz@gnu.org>
9829
fec2107c 9830 Support bidi reordering of text covered by display properties.
57f97249 9831
fec2107c
EZ
9832 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9833 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9834 (bidi_cache_search, bidi_cache_iterator_state)
9835 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9836 (bidi_level_of_next_char, bidi_move_to_visually_next):
9837 Support character positions inside a run of characters covered by a
fec2107c
EZ
9838 display string.
9839 (bidi_paragraph_init, bidi_resolve_explicit_1)
9840 (bidi_level_of_next_char): Call bidi_fetch_char and
9841 bidi_fetch_char_advance instead of FETCH_CHAR and
9842 FETCH_CHAR_ADVANCE.
9843 (bidi_init_it): Initialize new members.
9844 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9845 definitions.
9846 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9847 instead of using explicit *_CHAR codes.
d6d100dd
SM
9848 (bidi_resolve_explicit, bidi_resolve_weak):
9849 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9850 bidirectional text is supported only in multibyte buffers.
9851 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9852 it to initialize the frame_window_p member of struct bidi_it.
9853 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9854 (bidi_resolve_explicit, bidi_resolve_weak)
9855 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9856 bidi_it->nchars is non-positive.
9857 (bidi_level_of_next_char): Don't try to lookup the cache for the
9858 next/previous character if nothing is cached there yet, or if we
9859 were just reseat()'ed to a new position.
c40e2fb2 9860
0e14fe90
EZ
9861 * xdisp.c (set_cursor_from_row): Set start and stop points
9862 according to the row's direction when priming the loop that looks
9863 for the glyph on which to display cursor.
9864 (single_display_spec_intangible_p): Function deleted.
9865 (display_prop_intangible_p): Reimplement to call
9866 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9867 Accept 3 additional arguments needed by handle_display_spec.
9868 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9869 values: lists, `(when COND...)' forms, etc.
9870 (single_display_spec_string_p): Support property values that are
9871 lists with the argument STRING its top-level element.
9872 (display_prop_string_p): Fix the condition for processing a
9873 property that is a list to be consistent with handle_display_spec.
fec2107c 9874 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9875 last portion of handle_display_prop.
9876 (compute_display_string_pos): Accept additional argument
9877 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9878 value of a `display' property is a "replacing spec".
9879 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9880 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9881 the display property, but just return a value indicating whether
9882 the display property will replace the characters it covers.
9883 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9884 frame_window_p members of struct bidi_it.
d6d100dd
SM
9885 (compute_display_string_pos, compute_display_string_end):
9886 New functions.
fec2107c
EZ
9887 (push_it): Accept second argument POSITION, where pop_it should
9888 jump to continue iteration.
9889 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9890
fec2107c
EZ
9891 * keyboard.c (adjust_point_for_property): Adjust the call to
9892 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9893
9894 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9895 (bidi_init_it): Update prototypes.
9896 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9897 (compute_display_string_pos, compute_display_string_end):
9898 Declare prototypes.
fec2107c
EZ
9899 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9900 EMACS_INT.
fc6f18ce 9901
40087514 99022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9903
57f53182
PE
9904 Malloc failure behavior now depends on size of allocation.
9905 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9906 * lisp.h: Change signatures accordingly.
9907 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9908 All callers changed. (Bug#8762)
9909
9910 * gnutls.c: Use Emacs's memory allocators.
9911 Without this change, the gnutls library would invoke malloc etc.
9912 directly, which causes problems on non-SYNC_INPUT hosts, and which
9913 runs afoul of improving memory_full behavior. (Bug#8761)
9914 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9915 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9916 xfree instead of the default malloc, realloc, free.
9917 (Fgnutls_boot): No need to check for memory allocation failure,
9918 since xmalloc does that for us.
9919
ac32cd99 9920 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9921 * category.c (hash_get_category_set):
9922 * ccl.c (ccl_driver):
9923 * charset.c (Fdefine_charset_internal):
9924 * charset.h (struct charset.hash_index):
9925 * composite.c (get_composition_id, gstring_lookup_cache)
9926 (composition_gstring_put_cache):
9927 * composite.h (struct composition.hash_index):
9928 * dispextern.h (struct image.hash):
9929 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9930 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9931 (hashfn_equal, hashfn_user_defined, make_hash_table)
9932 (maybe_resize_hash_table, hash_lookup, hash_put)
9933 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9935 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9936 * image.c (make_image, search_image_cache, lookup_image)
9937 (xpm_put_color_table_h):
9938 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9939 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9940 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9941 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9942 * alloc.c (allocate_vectorlike):
9943 Check for overflow in vector size calculations.
9944 * ccl.c (ccl_driver):
9945 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9946 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9947 need to be updated by these changes.
40087514
PE
9948 * fns.c (make_hash_table, maybe_resize_hash_table):
9949 Check for integer overflow with large hash tables.
0de4bb68
PE
9950 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9951 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9952 (SXHASH_REDUCE): New macro.
9953 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9954 Use it instead of discarding useful hash info with large hash values.
9955 (sxhash_float): New function.
9956 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9957 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9958 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9959 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9960 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9961 Adjust signatures to match updated version of code.
9962 (consing_since_gc): Now EMACS_INT, since a single hash table can
9963 use more than INT_MAX bytes.
9964
698d32e2
DN
99652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9966
9967 Make it possible to build with GCC-4.6+ -O2 -flto.
9968
9969 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9970
fd6fa53f
SM
99712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9972
9973 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9974 Call minibuffer-inactive-mode.
9975
864db017
JB
99762011-05-31 Juanma Barranquero <lekktu@gmail.com>
9977
9978 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9979 Update dependencies.
9980
2ad0baf4
DN
99812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9982
9983 * data.c (init_data): Remove code for UTS, this system is not
9984 supported anymore.
9985
4fcc2638
DN
99862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9987
9988 Don't force ./temacs to start in terminal mode.
9989
9990 * frame.c (make_initial_frame): Initialize faces in all cases, not
9991 only when CANNOT_DUMP is defined.
9992 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9993
c56e0fd5
DN
99942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9995
9996 * dispnew.c (add_window_display_history): Use const for the string
9997 pointer. Remove declaration, not needed.
9998
333d54da 99992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10000
55d4c1b2 10001 Use 'inline', not 'INLINE'.
333d54da 10002 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10003 * alloc.c, fontset.c (INLINE): Remove.
10004 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10005 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10006 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10007 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10008 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10009
738db178
DN
100102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10011
10012 Make it possible to run ./temacs.
10013
10014 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10015 syms_of_callproc does the same thing. Remove test for
10016 "initialized", do it in the caller.
10017 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10018
620c53a6
SM
100192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10020
10021 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10022 (read_minibuf): Use get_minibuffer.
10023 (syms_of_minibuf): Use DEFSYM.
10024 (Qmetadata): New var.
10025 * data.c (Qbuffer): Don't make it static.
10026 (syms_of_data): Use DEFSYM.
10027
e003a292
PE
100282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10029
10030 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10031 (CCL_CODE_MIN): New macro.
10032
ed008a6d
PE
100332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10034
3687c2ef
PE
10035 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10036
ed008a6d
PE
10037 * eval.c (Qdebug): Now static.
10038 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10039 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10040 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10041
d66c4c7c
CY
100422011-05-29 Chong Yidong <cyd@stupidchicken.com>
10043
10044 * image.c: Various fixes to ImageMagick code comments.
10045 (Fimagemagick_types): Doc fix.
10046
5fbc2025
PE
100472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10048
0196f88a
PE
10049 Minor fixes prompted by GCC 4.6.0 warnings.
10050
10051 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10052
5fbc2025
PE
10053 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10054 (x_clipboard_manager_save_all): Move extern decl to ...
10055 * xterm.h: ... here, so that it can be checked for consistency.
10056
1dd3c2d9
CY
100572011-05-29 Chong Yidong <cyd@stupidchicken.com>
10058
10059 * xselect.c (x_clipboard_manager_save_frame)
10060 (x_clipboard_manager_save_all): New functions.
10061 (Fx_clipboard_manager_save): Lisp function deleted.
10062
10063 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10064 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10065
10066 * xterm.h: Update prototype.
10067
5ba6571d
WX
100682011-05-28 William Xu <william.xwl@gmail.com>
10069
10070 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10071 exiting (Bug#8239).
10072
3eaff834
JM
100732011-05-28 Jim Meyering <meyering@redhat.com>
10074
e1900994 10075 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10076 * fns.c (to_uchar): Define.
10077 (crypto_hash_function): Use it to convert some newly-signed
10078 variables to unsigned, to avoid sign-extension bugs. For example,
10079 without this change, (md5 "truc") would evaluate to
10080 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10081 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10082 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10083
0f6990a7
PE
100842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10085
10086 Integer overflow fixes.
c8a9ca5a 10087
08686060
PE
10088 * dbusbind.c: Serial number integer overflow fixes.
10089 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10090 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10091 to hold a serial number that is too large for a fixnum.
10092 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10093 Check for serial numbers out of range. Decode any serial number
59568bf0 10094 that was so large that it became a float. (Bug#8722)
08686060 10095
2d1fc3c7
PE
10096 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10097 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10098 Use XFASTINT rather than XUINT when numbers are nonnegative.
10099 (xd_append_arg, Fdbus_method_return_internal):
10100 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10101 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10102 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10103 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10104 (Bug#8722)
2d1fc3c7 10105
c8a9ca5a
PE
10106 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10107
519e1d69
PE
10108 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10109
6df6ae42 10110 ccl: Add integer overflow checks.
30569699
PE
10111 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10112 (IN_INT_RANGE): New macros.
10113 (ccl_driver): Use them to check for integer overflow when
10114 decoding a CCL program. Many of the new checks are whether XINT (x)
10115 fits in int; it doesn't always, on 64-bit hosts. The new version
10116 doesn't catch all possible integer overflows, but it's an
847044ea 10117 improvement. (Bug#8719)
30569699 10118
c11285dc
PE
10119 * alloc.c (make_event_array): Use XINT, not XUINT.
10120 There's no need for unsigned here.
10121
fdccd48e
PE
10122 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10123 This follows up to the 2011-05-06 change that substituted uintptr_t
10124 for EMACS_INT. This case wasn't caught back then.
10125
37910ab2
PE
10126 Rework Fformat to avoid integer overflow issues.
10127 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10128 now (part of C89). Include <verify.h>.
10129 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10130 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10131 (Fformat): Avoid the prepass trying to compute sizes; it was only
10132 approximate and thus did not catch overflow reliably. Instead, walk
10133 through the format just once, formatting and computing sizes as we go,
10134 checking for integer overflow at every step, and allocating a larger
10135 buffer as needed. Keep track separately whether the format is
10136 multibyte. Keep only the most-recently calculated precision, rather
10137 than them all. Record whether each argument has been converted to
10138 string. Use EMACS_INT, not int, for byte and char and arg counts.
10139 Support field widths and precisions larger than INT_MAX. Avoid
10140 sprintf's undefined behavior with conversion specifications such as %#d
10141 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10142 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10143 formatting out-of-range floating point numbers with int
9173deec 10144 formats. (Bug#8668)
37910ab2 10145
2e6578fb
PE
10146 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10147
0ae6bdee
PE
10148 * data.c: Avoid integer truncation in expressions involving floats.
10149 * data.c: Include <intprops.h>.
10150 (arith_driver): When there's an integer overflow in an expression
10151 involving floating point, convert the integers to floating point
10152 so that the resulting value does not suffer from catastrophic
10153 integer truncation. For example, on a 64-bit host (* 4
10154 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10155 Do not rely on undefined behavior after integer overflow.
10156
de883a70
PE
10157 merge count_size_as_multibyte, parse_str_to_multibyte
10158 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10159 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10160 Check for integer overflow.
10161 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10162 since it's now a duplicate of the other. This is more of
10163 a character than a buffer op, so better that it's in character.c.
10164 * fns.c, print.c: Adjust to above changes.
10165
2ff916cb
PE
101662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10167
10168 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10169
f1b54466
PE
101702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10171
fb1ac845
PE
10172 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10173 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10174 (x_clipboard_manager_save): Now static.
10175 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10176
f1b54466
PE
10177 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10178 (crypto_hash_function): Now static.
10179 Fix pointer signedness problems. Avoid unnecessary initializations.
10180
a9f737ee
CY
101812011-05-27 Chong Yidong <cyd@stupidchicken.com>
10182
10183 * termhooks.h (Vselection_alist): Make it terminal-local.
10184
10185 * terminal.c (create_terminal): Initialize it.
10186
10187 * xselect.c: Support for clipboard managers.
10188 (Vselection_alist): Move to termhooks.h as terminal-local var.
10189 (LOCAL_SELECTION): New macro.
10190 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10191 (symbol_to_x_atom): Remove gratuitous arg.
10192 (x_handle_selection_request, lisp_data_to_selection_data)
10193 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10194 (x_own_selection, x_get_local_selection, x_convert_selection):
10195 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10196 (some_frame_on_display): Delete unused function.
10197 (Fx_own_selection_internal, Fx_get_selection_internal)
10198 (Fx_disown_selection_internal, Fx_selection_owner_p)
10199 (Fx_selection_exists_p): New optional frame arg.
10200 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10201 (x_handle_selection_clear): Don't treat other terminals with the
10202 same keyboard specially. Use the terminal-local Vselection_alist.
10203 (x_clear_frame_selections): Use Frun_hook_with_args.
10204
10205 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10206
10207 * xterm.h: Add support for those atoms.
10208
e067f0c1
CY
102092011-05-26 Chong Yidong <cyd@stupidchicken.com>
10210
10211 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10212 (converted_selections, conversion_fail_tag): New global variables.
10213 (x_selection_request_lisp_error): Free the above.
10214 (x_get_local_selection): Remove unnecessary code.
10215 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10216 of converted selections stored in converted_selections.
10217 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10218 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10219 (x_convert_selection): New function.
10220 (x_handle_selection_event): Simplify.
10221 (x_get_foreign_selection): Don't ignore incoming requests while
10222 waiting for an answer; this will fail when we implement
10223 SAVE_TARGETS, and seems unnecessary anyway.
10224 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10225 (Vx_sent_selection_functions): Doc fix.
10226
0f4aebc0
LL
102272011-05-26 Leo Liu <sdl.web@gmail.com>
10228
10229 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10230
e61124cd
YM
102312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10232
10233 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10234
10235 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10236 for fringe update if it has periodic bitmap.
ac389d0c 10237 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10238 and fringe_bitmap_periodic_p.
10239
10240 * fringe.c (get_fringe_bitmap_data): New function.
10241 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10242 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10243 row. Mark glyph row for fringe update if periodicity changed.
10244
10245 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10246 for fringe update unless it has periodic bitmap.
10247
f16d9837
KH
102482011-05-25 Kenichi Handa <handa@m17n.org>
10249
10250 * xdisp.c (get_next_display_element): Set correct it->face_id for
10251 a static composition.
10252
e1b90ef6
LL
102532011-05-24 Leo Liu <sdl.web@gmail.com>
10254
10255 * deps.mk (fns.o):
10256 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10257
10258 * fns.c (crypto_hash_function, Fsha1): New function.
10259 (Fmd5): Use crypto_hash_function.
10260 (syms_of_fns): Add Ssha1.
10261
7400048f
PE
102622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10263
10264 * gnutls.c: Remove unused macros.
10265 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10266 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10267 Remove macros that are defined and never used.
10268 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10269
abb71cf4
CY
102702011-05-22 Chong Yidong <cyd@stupidchicken.com>
10271
10272 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10273 (Fx_get_selection_internal): Minor cleanup.
10274 (Fx_own_selection_internal): Rename arguments for consistency with
10275 select.el.
10276
6307db39
PE
102772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10278
10279 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10280
f3d4e0a4
CY
102812011-05-22 Chong Yidong <cyd@stupidchicken.com>
10282
10283 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10284
4d8ade89
YM
102852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10286
10287 * dispnew.c (scrolling_window): Don't exclude the case that the
10288 last enabled row in the desired matrix touches the bottom boundary.
10289
32078c8d
GM
102902011-05-21 Glenn Morris <rgm@gnu.org>
10291
10292 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10293 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10294 and add some more files.
32078c8d 10295
7285dc67
EZ
102962011-05-20 Eli Zaretskii <eliz@gnu.org>
10297
10298 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10299 report_file_error introduced by the change from 2011-05-07.
10300
89d1bd22
PE
103012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10302
10303 * systime.h (Time): Define only if emacs is defined.
10304 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10305 where the include path doesn't have X11/X.h by default. See
10306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10307
cd394be1 103082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10309
10310 * composite.c (find_automatic_composition): Fix previous change.
10311
b9704ad9
GM
103122011-05-20 Glenn Morris <rgm@gnu.org>
10313
10314 * lisp.mk: New file, split from Makefile.in.
10315 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10316 (shortlisp): Remove.
10317 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10318
4a720484
GM
103192011-05-19 Glenn Morris <rgm@gnu.org>
10320
10321 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10322 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10323 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10324 (lisp): Set the order to that of loadup.el.
10325 (shortlisp): Make it a copy of $lisp.
10326 (SOME_MACHINE_LISP): Remove.
10327 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10328 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10329
a28d4396
KH
103302011-05-18 Kenichi Handa <handa@m17n.org>
10331
10332 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10333 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10334 (find_automatic_composition): Mostly rewrite for efficiency.
10335
a2b1fa8e
JB
103362011-05-18 Juanma Barranquero <lekktu@gmail.com>
10337
10338 * makefile.w32-in: Update dependencies.
10339
8e1f5610
CS
103402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10341
10342 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10343 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10344
7025ee00 103452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10346
cdfa6eab
PE
10347 Fix some integer overflow issues, such as string length overflow.
10348
06d6db33
PE
10349 * insdel.c (count_size_as_multibyte): Check for string overflow.
10350
2b4560a8
PE
10351 * character.c (lisp_string_width): Check for string overflow.
10352 Use EMACS_INT, not int, for string indexes and lengths; in
10353 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10354 the resulting string length overflows an EMACS_INT; instead,
10355 report a string overflow if no precision given. When checking for
10356 precision exhaustion, use a check that cannot possibly have
10357 integer overflow. (Bug#8675)
10358 * character.h (lisp_string_width): Adjust to new signature.
10359
cb93f9be
PE
10360 * alloc.c (string_overflow): New function.
10361 (Fmake_string): Use it. This doesn't change behavior, but saves
10362 a few bytes and will simplify future changes.
10363 * character.c (string_escape_byte8): Likewise.
10364 * lisp.h (string_overflow): New decl.
10365
1a1f3366
PE
10366 Fixups, following up to the user-interface timestamp change.
10367 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10368 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10369 * msdos.c (mouse_get_pos): Likewise.
10370 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10371 * w32gui.h (Time): Define by including "systime.h" rather than by
10372 declaring it ourselves. (Bug#8664)
10373
d4e3e4d3
PE
10374 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10375 * image.c (clear_image_cache): Likewise.
10376
f6a24d19
PE
10377 * term.c (term_mouse_position): Don't assume time_t wraparound.
10378
08dc5ae6
PE
10379 Be more systematic about user-interface timestamps.
10380 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10381 and sometimes 'EMACS_UINT', to represent these timestamps.
10382 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10383 This makes the code easier to follow, and makes it easier to catch
10384 integer overflow bugs such as Bug#8664.
10385 * frame.c (Fmouse_position, Fmouse_pixel_position):
10386 Use Time, not unsigned long, for user-interface timestamps.
10387 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10388 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10389 * keyboard.h (last_event_timestamp): Likewise.
10390 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10391 * menu.h (xmenu_show): Likewise.
10392 * term.c (term_mouse_position): Likewise.
10393 * termhooks.h (struct input_event.timestamp): Likewise.
10394 (struct terminal.mouse_position_hook): Likewise.
10395 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10396 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10397 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10398 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10399 what it was before.
10400 * menu.h, termhooks.h: Include "systime.h", for Time.
10401
8e55734a
PE
10402 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10403 Don't assume that the difference between two unsigned long values
10404 can fit into an integer. At this point, we know button_down_time
10405 <= event->timestamp, so the difference must be nonnegative, so
10406 there's no need to cast the result if double-click-time is
10407 nonnegative, as it should be; check that it's nonnegative, just in
10408 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10409 apart (about 25 days). (Bug#8664)
8e55734a 10410
841f1b75 10411 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10412 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10413
3e26f69c
PE
10414 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10415 that always fit in int. Use a sentinel instead of a counter, to
10416 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10417 * frame.h (struct frame): Use int for menu_bar_items_used
10418 instead of EMACS_INT, since it always fits in int.
3e26f69c 10419
5cc152c0
PE
10420 * menu.c (grow_menu_items): Check for int overflow.
10421
d89eb65e
PE
10422 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10423
5235bd3e
PE
10424 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10425 Before, the code was not consistent. These values cannot exceed
10426 2**31 - 1 so there's no need to make them unsigned.
10427 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10428 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10429 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10430 as modifiers.
10431 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10432
bc827e23
PE
10433 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10434 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10435 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10436 presumably because the widths might not match.
10437
78eb494e
PE
10438 * window.c (size_window): Avoid needless test at loop start.
10439
04f2d78b
CB
104402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10441
10442 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10443
d2fc7e3d 104442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10445
10446 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10447
d2fc7e3d 104482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10449
10450 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10451 `width' to `bar_area_x' and `bar_area_width', respectively.
10452 (x_scroll_run): Take account of fringe background extension.
10453
04f2d78b
CB
10454 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10455 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10456 `bar_area_width', respectively.
10457 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10458 background extension.
10459
79b70037
GM
104602011-05-10 Jim Meyering <meyering@redhat.com>
10461
10462 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10463
2f142cc5
JB
104642011-05-10 Juanma Barranquero <lekktu@gmail.com>
10465
10466 * image.c (Finit_image_library): Return t for built-in image types,
10467 like pbm and xbm. (Bug#8640)
10468
57679c86
AS
104692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10470
10471 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10472
888c9e86
EZ
104732011-05-07 Eli Zaretskii <eliz@gnu.org>
10474
b0512a1d
EZ
10475 * w32console.c (Fset_screen_color): Doc fix.
10476 (Fget_screen_color): New function.
10477 (syms_of_ntterm): Defsubr it.
10478
7285dc67
EZ
10479 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10480 unlink the temporary file if Fcall_process didn't create it in the
10481 first place.
10482 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10483 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10484 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10485 cue to call_process_cleanup not to close that handle.
10486
4d3fcc8e
BK
104872011-05-07 Ben Key <bkey76@gmail.com>
10488
10489 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10490 one of two shell specific rules, either bootstrap-temacs-CMD or
10491 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10492 to the previous implementation of the bootstrap-temacs rule.
10493 The bootstrap-temacs-CMD rule is similar to the previous
10494 implementation of the bootstrap-temacs rule except that it
10495 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10496 variable.
10497
10498 These changes, along with some changes to nt/configure.bat,
10499 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10500 earlier fix to add support for --cflags and --ldflags options
10501 that include quotes so that it works whether make uses cmd or
10502 sh as the shell.
10503
b4289b64
MA
105042011-05-06 Michael Albinus <michael.albinus@gmx.de>
10505
10506 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10507 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10508 is a constant.
10509 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10510 a string. Handle both cases.
10511 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10512 (Fdbus_register_method): Use Qinvalid_function.
10513
af4c0e28
JB
105142011-05-06 Juanma Barranquero <lekktu@gmail.com>
10515
10516 * makefile.w32-in: Update dependencies.
10517 (LISP_H): Add inttypes.h and stdin.h.
10518 (PROCESS_H): Add unistd.h.
10519
c51453d9
EZ
105202011-05-06 Eli Zaretskii <eliz@gnu.org>
10521
10522 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10523 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10524
8ff0ac3c 105252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10526
4c4b566b
PE
10527 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10528
aab2b9b5
PE
10529 * term.c (vfatal): Remove stray call to va_end.
10530 It's not needed and the C Standard doesn't allow it here anyway.
10531
c378da0b
PE
10532 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10533 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10534
288b08c7
PE
10535 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10536 bytes.
10537
e3601888
PE
10538 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10539
db6c0e74
PE
10540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10541
dd5963ea
PE
10542 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10543
88c9450f
PE
10544 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10545
2f9442b8
PE
10546 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10547
c032b5f8
PE
10548 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10549 * charset.c (Fdefine_charset_internal): Don't initialize
10550 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10551 32-bit int (Bug#8600).
a108c10b
PE
10552
10553 * lread.c (read_integer): Be more consistent with string-to-number.
10554 Use string_to_number to do the actual conversion; this avoids
10555 rounding errors and fixes some other screwups. Without this fix,
10556 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10557 (digit_to_number): Move earlier, for benefit of read_integer.
10558 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10559 not a digit in any supported base. (Bug#8602)
a108c10b 10560
ad5f9eea
PE
10561 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10562
aec1708a
PE
10563 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10564 to match comment at start of function. This also removes a
10565 GCC warning about overflow in a 32+64-bit port.
10566
47be4ab5
PE
10567 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10568
371cac43
PE
10569 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10570 Reported by Stefan Monnier in
10571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10572 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10573 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10574
d01a7826
PE
10575 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10576 (EMACS_UINTPTR): Likewise, with uintptr_t.
10577
7fd47d5c
PE
10578 * lisp.h: Prefer 64-bit EMACS_INT if available.
10579 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10580 on 32-bit hosts that have 64-bit int, so that they can access
10581 large files.
122b0c86
PE
10582 However, temporarily disable this change unless the temporary
10583 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10584
8727937b
PE
10585 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10586
8ac068ac
PE
10587 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10588 This removes an assumption that EMACS_INT and long are the same
10589 width as pointers. The assumption is true for Emacs porting targets
10590 now, but we want to make other targets possible.
10591 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10592 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10593 In the rest of the code, change types of integers that hold casted
10594 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10595 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10596 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10597 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10598 No need to cast type when ORing.
10599 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10600 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10601 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10602 assume EMACS_INT is the same width as char *.
10603 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10604 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10605 Remove no-longer-needed casts.
10606 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10607 (xg_tool_bar_help_callback, xg_make_tool_item):
10608 Use EMACS_INTPTR to hold an integer
10609 that will be cast to void *; this can avoid a GCC warning
10610 if EMACS_INT is not the same width as void *.
10611 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10612 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10613 (current_message_1, set_message_1):
10614 Use a local to convert to proper width without a cast.
10615 * xmenu.c (dialog_selection_callback): Likewise.
10616
ede49d71
PE
10617 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10618 Also, don't assume VALBITS / RAND_BITS is less than 5,
10619 and don't rely on undefined behavior when shifting a 1 left into
10620 the sign bit.
10621 * lisp.h (get_random): Change signature to match.
10622
2f30ecd0
PE
10623 * lread.c (hash_string): Use size_t, not int, for hash computation.
10624 Normally we prefer signed values; but hashing is special, because
10625 it's better to use unsigned division on hash table sizes so that
10626 the remainder is nonnegative. Also, size_t is the natural width
10627 for hashing into memory. The previous code used 'int', which doesn't
10628 retain enough info to hash well into very large tables.
10629 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10630
2a866e7b
PE
10631 * dbusbind.c: Don't possibly lose pointer info when converting.
10632 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10633 Use XPNTR rather than XHASH, so that the high-order bits of
10634 the pointer aren't lost when converting through void *.
10635
51639eac
PE
10636 * eval.c (Fautoload): Don't double-shift a pointer.
10637
92394119
PE
10638 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10639
dbdb9a7c
JB
106402011-05-06 Juanma Barranquero <lekktu@gmail.com>
10641
10642 * gnutls.c (DEF_GNUTLS_FN):
10643 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10644
db7a0b4f
AS
106452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10646
10647 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10648 marker. (Bug#8610)
10649
cd394be1 106502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10651
10652 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10653 New version that can reserve upto 2GB of heap space.
10654
f7ff1b0f 106552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10656
10657 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10658
639c109b
TZ
106592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10660
10661 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10662 `gnutls_certificate_set_x509_key_file'.
10663
d2127135
JB
106642011-05-05 Juanma Barranquero <lekktu@gmail.com>
10665
10666 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10667 Update dependencies.
10668
e968f4f3
JB
106692011-05-04 Juanma Barranquero <lekktu@gmail.com>
10670
10671 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10672 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10673 Remove unused parameter `fildes'.
10674 * process.c (read_process_output, send_process): Don't pass it.
10675
84d358f0
JB
106762011-05-04 Juanma Barranquero <lekktu@gmail.com>
10677
10678 Fix previous change: the library cache is defined in w32.c.
10679 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10680 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10681
0898ca10
JB
106822011-05-04 Juanma Barranquero <lekktu@gmail.com>
10683
10684 Implement dynamic loading of GnuTLS on Windows.
10685
10686 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10687 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10689 Declare.
10690
10691 * gnutls.c (Qgnutls_dll): Define.
10692 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10693 (gnutls_*): Declare function pointers.
10694 (init_gnutls_functions): New function to initialize function pointers.
10695 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10696 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10697 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10698 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10699 (emacs_gnutls_write, emacs_gnutls_read)
10700 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10701 (Fgnutls_available_p): New function.
10702 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10703 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10704 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10705
10706 * image.c: Include w32.h.
10707 (Vimage_type_cache): Delete.
10708 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10709 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10710 (w32_delayed_load): Move to w32.c.
10711
10712 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10713
10714 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10715 (w32_delayed_load): Move from image.c. When loading a library, record
10716 its filename in the :loaded-from property of the library id.
10717 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10718 Initialize and staticpro them.
10719 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10720
10721 * process.c: Include lisp.h before w32.h, not after.
10722 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10723 instead of gnutls_record_check_pending.
10724
10725 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10726
ff4de4aa
TZ
107272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10728
10729 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10730 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10731 as passed in.
10732
abe95abb
JD
107332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10734
10735 * xterm.c (x_set_frame_alpha): Do not set property on anything
10736 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10737
e16e55d4
JB
107382011-05-02 Juanma Barranquero <lekktu@gmail.com>
10739
10740 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10741
bafcf6a5
JB
107422011-05-02 Juanma Barranquero <lekktu@gmail.com>
10743
10744 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10745 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10746 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10747 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10748 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10749 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10750 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10751 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10752 (Qgnutls_bootprop_callbacks_verify): Make static.
10753
e7a6747f
AS
107542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10755
19ed11ba
AS
10756 * callproc.c: Indentation fixup.
10757
e7a6747f 10758 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10759 (wait_for_termination, interruptible_wait_for_termination):
10760 Move after wait_for_termination_1.
e7a6747f 10761
1ef14cb4
LMI
107622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10763
10764 * sysdep.c (interruptible_wait_for_termination): New function
10765 which is like wait_for_termination, but allows keyboard
10766 interruptions.
10767
10768 * callproc.c (Fcall_process): Add (:file "file") as an option for
10769 the STDOUT buffer.
10770 (Fcall_process_region): Ditto.
10771
330d880c
EZ
107722011-04-30 Eli Zaretskii <eliz@gnu.org>
10773
8db90b73
EZ
10774 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10775 rather than `XVECTOR (FOO)->size'.
10776
330d880c
EZ
10777 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10778 inttypes.h, as a gnulib replacement is used if it not available in
10779 system headers.
10780
15cbd324
EZ
107812011-04-21 Eli Zaretskii <eliz@gnu.org>
10782
10783 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10784 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10785 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10786
10787 * coding.c (coding_alloc_by_realloc): Error out if destination
10788 will grow beyond MOST_POSITIVE_FIXNUM.
10789 (decode_coding_emacs_mule): Abort if there isn't enough place in
10790 charbuf for the composition carryover bytes. Reserve an extra
10791 space for up to 2 characters produced in a loop.
10792 (decode_coding_iso_2022): Abort if there isn't enough place in
10793 charbuf for the composition carryover bytes.
10794
107952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10796
ae940cca
EZ
10797 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10798 aborting when %lld or %lll format is passed.
10799 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10800 %llo or %llx format is passed. (Bug#8545)
10801
03ab8921
EZ
10802 * window.c (window_scroll_line_based): Use a marker instead of
10803 simple variables to record original value of point. (Bug#7952)
10804
afda1437
EZ
10805 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10806 produced by %s or %c overflows available buffer space. (Bug#8545)
10807
f76dee0c
PE
108082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10809
10810 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10811 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10812
fdc5744d
JB
108132011-04-28 Juanma Barranquero <lekktu@gmail.com>
10814
10815 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10816
638f053a
JB
108172011-04-28 Juanma Barranquero <lekktu@gmail.com>
10818
10819 * keyboard.c (Qdelayed_warnings_hook): Define.
10820 (command_loop_1): Run `delayed-warnings-hook'
10821 if Vdelayed_warnings_list is non-nil.
10822 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10823 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10824
d178f871
EZ
108252011-04-28 Eli Zaretskii <eliz@gnu.org>
10826
10827 * doprnt.c (doprnt): Don't return value smaller than the buffer
10828 size if the message was truncated. (Bug#8545).
10829
b124fd93
JB
108302011-04-28 Juanma Barranquero <lekktu@gmail.com>
10831
10832 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10833 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10834
e810457d
PE
108352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10836
10837 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10838
ea51cceb
JB
108392011-04-27 Juanma Barranquero <lekktu@gmail.com>
10840
10841 * makefile.w32-in: Update dependencies.
10842
94dcfacf
EZ
108432011-04-27 Eli Zaretskii <eliz@gnu.org>
10844
10845 Improve `doprnt' and its usage. (Bug#8545)
10846 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10847 `format_end'. Remove support for %l as a conversion specifier.
10848 Don't use xrealloc. Improve diagnostics when the %l size modifier
10849 is used. Update the commentary.
10850
10851 * eval.c (verror): Simplify calculation of size_t.
10852
10853 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10854 messages.
10855
f61f41d7
PE
108562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10857
10858 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10859 change.
10860
96fb4434
PE
108612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10862
10863 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10864 This makes this file independent of the recent pseudovector change.
10865
671875da 108662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10867
69e9b5a3
PE
10868 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10869
b5f869a7 10870 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10871 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10872 Remove unused local.
c8926152 10873 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10874
841a1577 10875 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10876 GCC 4.6.0 optimizes based on type-based alias analysis.
10877 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10878 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10879 != &v->size, and therefore "v->size = 1; b->size = 2; return
10880 v->size;" must therefore return 1. This assumption is incorrect
10881 for Emacs, since it type-puns struct Lisp_Vector * with many other
10882 types. To fix this problem, this patch adds a new type struct
f904488f 10883 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10884 and pseudovectors, and helps optimizing compilers not get fooled
10885 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10886 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10887 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10888 the size member.
eab3844f
PE
10889 (XSETPVECTYPE): Rewrite in terms of new macro.
10890 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10891 This is a bit clearer, and further avoids the possibility of
10892 undesirable aliasing.
10893 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10894 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10895 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10896 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10897 (ASIZE): Now uses header.size rather than size.
10898 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10899 to avoid the hassle of writing XVECTOR (foo)->header.size.
10900 (struct vectorlike_header): New type.
eab3844f
PE
10901 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10902 object, to help avoid aliasing.
10903 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10904 (SUBRP): Likewise, since Lisp_Subr is a special case.
10905 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10906 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10907 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10908 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10909 changed to be "header.size" and "header.next".
10910 * buffer.h (struct buffer): Likewise.
10911 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10912 * frame.h (struct frame): Likewise.
10913 * process.h (struct Lisp_Process): Likewise.
10914 * termhooks.h (struct terminal): Likewise.
10915 * window.c (struct save_window_data, struct saved_window): Likewise.
10916 * window.h (struct window): Likewise.
10917 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10918 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10919 * buffer.c (init_buffer_once): Likewise.
10920 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10921 special case.
10922 * process.c (Fformat_network_address): Use local var for size,
10923 for brevity.
10924
0df1eac5
PE
10925 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10926
847ab9d1 10927 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10928 * data.c (atof): Remove decl; no longer used or needed.
10929 (digit_to_number): Move to lread.c.
10930 (Fstring_to_number): Use new string_to_number function, to be
10931 consistent with how the Lisp reader treats infinities and NaNs.
10932 Do not assume that floating-point numbers represent EMACS_INT
10933 without losing information; this is not true on most 64-bit hosts.
10934 Avoid double-rounding errors, by insisting on integers when
10935 parsing non-base-10 numbers, as the documentation specifies.
10936 * lisp.h (string_to_number): New decl, replacing ...
10937 (isfloat_string): Remove.
bc0a5c13 10938 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10939 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10940 appears to have been a coding error. Similarly, do not accept
10941 strings like +-1e0 as floating point numbers. Do not report
10942 overflow for integer overflows unless the base is not 10 which
10943 means we have no simple and reliable way to continue.
10944 Break out the floating-point parsing into a new
10945 function string_to_number, so that Fstring_to_number parses
10946 floating point numbers consistently with the Lisp reader.
04f2d78b 10947 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10948 (E_CHAR, EXP_INT): Remove, replacing with ...
10949 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10950 (string_to_number): New function, replacing isfloat_string.
10951 This function checks for valid syntax and produces the resulting
10952 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10953 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10954 so that overflow for non-base-10 numbers is reported only when
10955 there's no portable and simple way to convert to floating point.
452f4150 10956
67769ffc
PE
10957 * textprop.c (set_text_properties_1): Rewrite for clarity,
10958 and to avoid GCC warning about integer overflow.
10959
c20db43f
PE
10960 * intervals.h (struct interval): Use EMACS_INT for members
10961 where EMACS_UINT might cause problems. See
10962 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10963 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10964 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10965 All uses changed.
37aa2f85
PE
10966 (offset_intervals): Tell GCC not to worry about length overflow
10967 when negating a negative length.
c20db43f 10968
2538aa2f
PE
10969 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10970 (overrun_check_free): Likewise.
10971
f2d3008d
PE
10972 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10973 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10974 word size.
10975
ec8df744
PE
10976 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10977 (gnutls_make_error): Rename local to avoid shadowing.
10978 (gnutls_emacs_global_deinit): ifdef out; not used.
10979 (Fgnutls_boot): Use const for pointer to readonly storage.
10980 Comment out unused local. Fix pointer signedness problems.
10981
640ee02d
PE
10982 * lread.c (openp): Don't stuff size_t into an 'int'.
10983 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10984 about possible signed overflow.
10985
6048fb2a
PE
10986 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10987 (GDK_KEY_g): Don't define if already defined.
10988 (xg_prepare_tooltip): Avoid pointer signedness problem.
10989 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10990
fa3c87e1
PE
10991 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10992 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10993
2172544b
PE
10994 * xfns.c (Fx_window_property): Simplify a bit,
10995 to make a bit faster and to avoid GCC 4.6.0 warning.
10996 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10997
9b821a21
PE
10998 * fns.c (internal_equal): Don't assume size_t fits in int.
10999
3c616cfa
PE
11000 * alloc.c (compact_small_strings): Tighten assertion a little.
11001
c2982e87
PE
11002 Replace pEd with more-general pI, and fix some printf arg casts.
11003 * lisp.h (pI): New macro, generalizing old pEd macro to other
11004 conversion specifiers. For example, use "...%"pI"d..." rather
11005 than "...%"pEd"...".
11006 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11007 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11008 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11009 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11010 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11011 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11012 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11013 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11014 64-bit hosts.
11015 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11016 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11017 * print.c (safe_debug_print, print_object): Likewise.
11018 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11019 to int.
6f04d126
PE
11020 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11021 avoiding the 0 flag, which is not portable.
c2982e87
PE
11022 * process.c (Fmake_network_process): Use pI to avoid cast.
11023 * region-cache.c (pp_cache): Likewise.
11024 * xdisp.c (decode_mode_spec): Likewise.
11025 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11026 behavior on 64-bit hosts with printf arg.
6f04d126 11027 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11028 (x_stop_queuing_selection_requests): Likewise.
11029 (x_get_window_property): Don't truncate byte count to an 'int'
11030 when tracing.
0b432f21 11031
5e073ec7
PE
11032 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11033 here, since it parses constructs like leading '-' and spaces,
11034 which are not wanted; and it overflows with large numbers.
11035 Instead, simply match F[0-9]+, which is what is wanted anyway.
11036
36372bf9
PE
11037 * alloc.c: Remove unportable assumptions about struct layout.
11038 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11039 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11040 (allocate_vectorlike, make_pure_vector): Use the new macros,
11041 plus offsetof, to remove unportable assumptions about struct layout.
11042 These assumptions hold on all porting targets that I know of, but
11043 they are not guaranteed, they're easy to remove, and removing them
11044 makes further changes easier.
11045
0b432f21
PE
11046 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11047 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11048 (string_overrun_cookie): Now const. Use initializers that
11049 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11050 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11051 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11052 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11053 multiple of sizeof (EMACS_INT); it need not be, if
11054 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11055 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11056
895009e1
JB
110572011-04-26 Juanma Barranquero <lekktu@gmail.com>
11058
11059 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11060
6a7a1b0b
TZ
110612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11062
11063 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11064 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11065 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11066
841a1577 110672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11068
11069 * lisp.h (Qdebug): List symbol.
895009e1 11070 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11071 * keyboard.c (debug-on-event): New variable.
11072 (handle_user_signal): Break into debugger when debug-on-event
11073 matches the current signal symbol.
11074
f2d3ba6f
DN
110752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11076
11077 * alloc.c (check_sblock, check_string_bytes)
11078 (check_string_free_list): Convert to standard C.
11079
42ce4c63
TZ
110802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11081
11082 * w32.c (emacs_gnutls_push): Fix typo.
11083
825cd63c
EZ
110842011-04-25 Eli Zaretskii <eliz@gnu.org>
11085
fb11d64d
EZ
11086 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11087 "cast to pointer from integer of different size".
11088
825cd63c
EZ
11089 Improve doprnt and its use in verror. (Bug#8545)
11090 * doprnt.c (doprnt): Document the set of format control sequences
11091 supported by the function. Use SAFE_ALLOCA instead of always
11092 using `alloca'.
11093
11094 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11095 is one byte too soon. Don't use xrealloc; instead xfree and
11096 xmalloc anew.
11097
e061a11b
TZ
110982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11099
11100 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11101 callbacks stage.
11102
11103 * gnutls.c: Renamed global_initialized to
11104 gnutls_global_initialized. Added internals for the
11105 :verify-hostname-error, :verify-error, and :verify-flags
11106 parameters of `gnutls-boot' and documented those parameters in the
11107 docstring. Start callback support.
9173deec
JB
11108 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11109 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11110 on error. Return error code.
e061a11b
TZ
11111 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11112 (emacs_gnutls_read): Likewise.
11113 (Fgnutls_boot): Return handshake error code.
11114 (emacs_gnutls_handle_error): New function.
11115 (wsaerror_to_errno): Likewise.
11116
11117 * w32.h (emacs_gnutls_pull): Add prototype.
11118 (emacs_gnutls_push): Likewise.
11119
11120 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11121 (emacs_gnutls_push): Likewise.
11122
111232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11124
11125 * process.c (wait_reading_process_output): Check if GnuTLS
11126 buffered some data internally if no FDs are set for TLS
11127 connections.
11128
11129 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11130 (LIBS): Link to USER_LIBS.
11131 ($(BLD)/gnutls.$(0)): New target.
11132
fa6996bc
EZ
111332011-04-24 Eli Zaretskii <eliz@gnu.org>
11134
eb35682e
EZ
11135 * xdisp.c (handle_single_display_spec): Rename the
11136 display_replaced_before_p argument into display_replaced_p, to
11137 make it consistent with the commentary. Fix typos in the
11138 commentary.
11139
e2ad650c
EZ
11140 * textprop.c (syms_of_textprop): Remove dead code.
11141 (copy_text_properties): Delete obsolete commentary about an
11142 interface that was deleted long ago. Fix typos in the description
11143 of arguments.
11144
1b2de274
EZ
11145 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11146 to changes in oldXMenu/XMenu.h from 2011-04-16.
11147 <menu_help_message, prev_menu_help_message>: Constify.
11148 (IT_menu_make_room): menu->help_text is now `const char **';
11149 adjust.
11150
11151 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11152 to changes in oldXMenu/XMenu.h from 2011-04-16.
11153 (struct XMenu): Declare `help_text' `const char **'.
11154
11155 * xfaces.c <Qunspecified>: Make extern again.
11156
11157 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11158 required by POSIX.
1b2de274 11159
762b15be
EZ
11160 * doc.c (get_doc_string): Improve the format passed to `error'.
11161
11162 * doprnt.c (doprnt): Improve commentary.
11163
11164 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11165
11166 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11167 them with etags.
11168
f1052e5d
EZ
11169 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11170 changes in globals.h immediately force recompilation.
762b15be
EZ
11171 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11172 $(CURDIR)/s/ms-w32.h.
11173 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11174
fa6996bc
EZ
11175 * character.c (Fchar_direction): Function deleted.
11176 (syms_of_character): Don't defsubr it.
11177 <char-direction-table>: Deleted.
11178
e6c3da20
EZ
111792011-04-23 Eli Zaretskii <eliz@gnu.org>
11180
11181 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11182 * doprnt.c: Include limits.h.
11183 (SIZE_MAX): New macro.
04f2d78b
CB
11184 (doprnt): Return a size_t value. 2nd arg is now size_t.
11185 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11186 Improve overflow protection. Support `l' modifier for integer
11187 conversions. Support %l conversion. Don't assume an EMACS_INT
11188 argument for integer conversions and for %c.
11189
11190 * lisp.h (doprnt): Restore prototype.
11191
11192 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11193 $(SRC)/character.h.
11194
11195 * Makefile.in (base_obj): Add back doprnt.o.
11196
11197 * deps.mk (doprnt.o): Add back prerequisites.
11198 (callint.o): Depend on character.h.
11199
11200 * eval.c (internal_lisp_condition_case): Include the handler
11201 representation in the error message.
11202 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11203 when breaking from the loop.
11204
11205 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11206
11207 * callint.c (Fcall_interactively): When displaying error message
11208 about invalid control letter, pass the character's codepoint, not
11209 a pointer to its multibyte form. Improve display of the character
11210 in octal and display also its hex code.
11211
11212 * character.c (char_string): Use %x to display the (unsigned)
11213 codepoint of an invalid character, to avoid displaying a bogus
11214 negative value.
11215
11216 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11217 `error', not SYMBOL_NAME itself.
11218
11219 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11220 character arguments to `error'.
11221
11222 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11223 to `error' in error message about FINAL_CHAR argument. Make sure
11224 FINAL_CHAR is a character, and use %c when it is passed as
11225 argument to `error'.
11226
4ffd0d6b 112272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11228
11229 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11230
11231 * w32.c: Include <time.h>.
11232 (sys_localtime): New function.
11233
4ffd0d6b 112342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11235
11236 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11237
4ffd0d6b 11238 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11239
4ffd0d6b 112402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11241
4ffd0d6b
GM
11242 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11243 zombies (Bug#8467).
aac0c6e3 11244
04c56954
EZ
112452011-04-19 Eli Zaretskii <eliz@gnu.org>
11246
11247 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11248 gl_state.e_property when gl_state.object is Qt.
11249
11250 * insdel.c (make_gap_larger): Remove limitation of buffer size
11251 to <= INT_MAX.
11252
16a43933
CY
112532011-04-18 Chong Yidong <cyd@stupidchicken.com>
11254
11255 * xdisp.c (lookup_glyphless_char_display)
11256 (produce_glyphless_glyph): Handle cons cell entry in
11257 glyphless-char-display.
11258 (Vglyphless_char_display): Document it.
11259
11260 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11261 glyphless-char-display.
11262
4581706e
CY
112632011-04-17 Chong Yidong <cyd@stupidchicken.com>
11264
11265 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11266
11267 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11268
11269 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11270 definition for no-X builds.
11271
4887c6e2 112722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11273
fd35b6f9
PE
11274 Static checks with GCC 4.6.0 and non-default toolkits.
11275
5c1ccb01
PE
11276 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11277
006c5daa
PE
11278 * process.c (keyboard_bit_set): Define only if SIGIO.
11279 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11280 (send_process): Repair possible setjmp clobbering.
11281
efc736d3
PE
11282 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11283
4e2fe2e6
PE
11284 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11285
f97334a2
PE
11286 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11287
4e75f29d
PE
11288 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11289 Define only if needed.
11290
90efadd1
PE
11291 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11292 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11293 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11294
3c647824
PE
11295 * dispextern.h (struct redisplay_interface): Rename param
11296 to avoid shadowing.
e264f262 11297 * termhooks.h (struct terminal): Likewise.
761383f4 11298 * xterm.c (xembed_send_message): Likewise.
3c647824 11299
b58c5c4a
PE
11300 * insdel.c (make_gap_smaller): Define only if
11301 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11302
cad59032
PE
11303 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11304 it.
11305
c339dc2e
PE
11306 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11307 so that we aren't warned about unused symbols.
11308
91a3e27b
PE
11309 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11310
399c71d3 11311 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11312
8ffc96f5
PE
11313 * xfns.c (x_real_positions): Mark locals as initialized.
11314
eef9bc79
PE
11315 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11316
098db9dd
PE
11317 * xterm.c: Fix problems found by static analysis with other toolkits.
11318 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11319 (x_dispatch_event): Declare static if USE_GTK, and
11320 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11321 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11322 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11323 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11324 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11325
eb18f6cc
PE
11326 * xmenu.c (menu_help_callback): Pointer type fixes.
11327 Use const pointers when pointing at readonly data. Avoid pointer
11328 signedness clashes.
11329 (FALSE): Remove unused macro.
11330 (update_frame_menubar): Remove unused decl.
11331
1fe72bf8
PE
11332 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11333
60d9e1db
PE
11334 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11335 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11336 (single_menu_item): Rename local to avoid shadowing.
11337
39261c26
PE
11338 * keyboard.c (make_lispy_event): Remove unused local var.
11339
018c5e19
PE
11340 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11341 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11342
63d2b86e
PE
11343 * bitmaps: Change bitmaps from unsigned char back to the X11
11344 compatible char. Avoid the old compiler warnings about
11345 out-of-range initializers by using, for example, '\xab' rather
11346 than 0xab.
11347
aefd87e1
PE
11348 * xgselect.c (xgselect_initialize): Check vs interface
11349 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11350
bf501fb9
PE
11351 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11352
e9829fdf
PE
11353 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11354 to read-only memory.
11355
1086c095
PE
11356 * fns.c (vector): Remove; this old hack is no longer needed.
11357
2baccd04 11358 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11359 Remove unused var.
dde42981 11360 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11361
72391843 11362 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11363
436c16df 11364 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11365 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11366 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11367
92bb796d 11368 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11369 (x_term_init): Remove local to avoid shadowing.
92bb796d 11370
764430a3 11371 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11372
11373 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11374 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11375
d1dfb56c
EZ
113762011-04-16 Eli Zaretskii <eliz@gnu.org>
11377
c4354cb4
EZ
11378 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11379
d1dfb56c
EZ
11380 Fix regex.c, syntax.c and friends for buffers > 2GB.
11381 * syntax.h (struct gl_state_s): Declare character position members
11382 EMACS_INT.
11383
11384 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11385
04f2d78b
CB
11386 * textprop.c (verify_interval_modification, interval_of):
11387 Declare arguments EMACS_INT.
d1dfb56c
EZ
11388
11389 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11390 EMACS_INT.
11391
11392 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11393
11394 * indent.c (Fvertical_motion): Local variable it_start is now
11395 EMACS_INT.
11396
11397 * regex.c (re_match, re_match_2, re_match_2_internal)
11398 (bcmp_translate, regcomp, regexec, print_double_string)
11399 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11400 (re_compile_pattern, re_exec): Declare arguments and local
11401 variables `size_t' and `ssize_t' and return values `regoff_t', as
11402 appropriate.
11403 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11404 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11405 <compile_stack_type>: `size' and `avail' are now `size_t'.
11406
11407 * regex.h <regoff_t>: Use ssize_t, not int.
11408 (re_search, re_search_2, re_match, re_match_2): Arguments that
11409 specify buffer/string position and length are now ssize_t and
11410 size_t. Return type is regoff_t.
11411
613052cd
BK
114122011-04-16 Ben Key <bkey76@gmail.com>
11413
11414 * nsfont.m: Fixed bugs in ns_get_family and
11415 ns_descriptor_to_entity that were caused by using free to
11416 deallocate memory blocks that were allocated by xmalloc (via
11417 xstrdup). This caused Emacs to crash when compiled with
11418 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11419 --enable-checking=xmallocoverrun). xfree is now used to
11420 deallocate these memory blocks.
11421
4170f62f 114222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11423
71b41406
PE
11424 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11425
9587a89d
PE
11426 emacs_write: Accept and return EMACS_INT for sizes.
11427 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11428 et seq.
11429 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11430 Accept and return EMACS_INT.
11431 (emacs_gnutls_write): Return the number of bytes written on
11432 partial writes.
11433 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11434 (emacs_read, emacs_write): Remove check for negative size, as the
11435 Emacs source code has been audited now.
9587a89d
PE
11436 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11437 (emacs_read, emacs_write): Use it.
273a5f82
PE
11438 * process.c (send_process): Adjust to the new signatures of
11439 emacs_write and emacs_gnutls_write. Do not attempt to store
11440 a byte offset into an 'int'; it might overflow.
9587a89d 11441 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11442
3e047f51
PE
11443 * sound.c: Don't assume sizes fit in 'int'.
11444 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11445 Return EMACS_INT, not int.
3e047f51 11446 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11447 Accept EMACS_INT, not int.
11448 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11449 record read return values.
11450
cc39a9db
BK
114512011-04-15 Ben Key <bkey76@gmail.com>
11452
c9d0ec6d
JB
11453 * keyboard.c (Qundefined): Don't declare static since it is used
11454 in nsfns.m.
11455 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11456 static since they are used in nsfont.m.
cc39a9db 11457
6c60eb9f
SM
114582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11459
11460 * process.c (Qprocessp): Don't declare static.
11461 * lisp.h (Qprocessp): Declare again.
11462
7990b61a
JB
114632011-04-15 Juanma Barranquero <lekktu@gmail.com>
11464
11465 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11466
5d4cb038
PE
114672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11468
8bd7b830 11469 Improve C-level modularity by making more things 'static'.
cd64ea1d 11470
e3b27b31
PE
11471 Don't publish debugger-only interfaces to other modules.
11472 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11473 (verify_bytepos, count_markers): Move decls to the only modules
11474 that need them.
11475 * region-cache.h (pp_cache): Likewise.
11476 * window.h (check_all_windows): Likewise.
11477 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11478
5d4cb038
PE
11479 * sysdep.c (croak): Now static, if
11480 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11481 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11482
11483 * alloc.c (refill_memory_reserve): Now static if
11484 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11485 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11486
e87b6180
PE
11487 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11488 Define only if USE_LUCID.
11489
ac64929e
PE
11490 * xrdb.c (x_customization_string, x_rm_string): Now static.
11491
6f37259d
PE
11492 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11493 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11494
1683e3ab
PE
11495 * xdisp.c (draw_row_with_mouse_face): Now static.
11496 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11497
de9c2632
PE
11498 * window.h (check_all_windows): Mark externally visible.
11499
2b96acb7
PE
11500 * window.c (window_deletion_count): Now static.
11501
11502 * undo.c: Make symbols static if they're not exported.
11503 (last_undo_buffer, last_boundary_position, pending_boundary):
11504 Now static.
11505
50436f33
PE
11506 * textprop.c (interval_insert_behind_hooks): Now static.
11507 (interval_insert_in_front_hooks): Likewise.
11508
64520e5c
PE
11509 * term.c: Make symbols static if they're not exported.
11510 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11511 (max_frame_lines, tty_set_terminal_modes):
11512 (tty_reset_terminal_modes, tty_turn_off_highlight):
11513 (get_tty_terminal): Now static.
11514 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11515 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11516 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11517 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11518 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11519
1fa53021
PE
11520 * sysdep.c: Make symbols static if they're not exported.
11521 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11522 Now static.
11523 (sigprocmask_set, full_mask): Remove; unused.
11524 (wait_debugging): Mark as visible.
11525 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11526 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11527
d4b43b22
PE
11528 * syntax.c (syntax_temp): Define only if !__GNUC__.
11529
b7c513d0
PE
11530 * sound.c (current_sound_device, current_sound): Now static.
11531
989b29ad
PE
11532 * search.c (searchbufs, searchbuf_head): Now static.
11533
13a55a78
PE
11534 * scroll.c (scroll_cost): Remove; unused.
11535 * dispextern.h (scroll_cost): Remove decl.
11536
de68a1fc
PE
11537 * region-cache.h (pp_cache): Mark as externally visible.
11538
40ccffa6
PE
11539 * process.c: Make symbols static if they're not exported.
11540 (process_tick, update_tick, create_process, chan_process):
11541 (Vprocess_alist, proc_buffered_char, datagram_access):
11542 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11543 (deactivate_process): Mark defn as static, as well as decl.
11544 * lisp.h (create_process): Remove decl.
11545 * process.h (chan_process, Vprocess_alist): Remove decls.
11546
ad64fc97
PE
11547 * print.c: Make symbols static if they're not exported.
11548 (print_depth, new_backquote_output, being_printed, print_buffer):
11549 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11550 (print_interval, print_number_index, initial_stderr_stream):
11551 Now static.
11552 * lisp.h (Fprinc): Remove decl.
11553 (debug_output_compilation_hack): Mark as externally visible.
11554
adddb265
PE
11555 * sysdep.c (croak): Move decl from here to syssignal.h.
11556 * syssignal.h (croak): Put it here, so the API can be checked when
11557 'croak' is called from dissociate_if_controlling_tty.
11558
1717ede2
PE
11559 * minibuf.c: Make symbols static if they're not exported.
11560 (minibuf_save_list, choose_minibuf_frame): Now static.
11561 * lisp.h (choose_minibuf_frame): Remove decl.
11562
fa5fb2bc
PE
11563 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11564
1e3890d1
PE
11565 * lread.c: Make symbols static if they're not exported.
11566 (read_objects, initial_obarray, oblookup_last_bucket_number):
11567 Now static.
11568 (make_symbol): Remove; unused.
11569 * lisp.h (initial_obarray, make_symbol): Remove decls.
11570
8a1414fa
PE
11571 * keyboard.c: Make symbols static if they're not exported.
11572 (single_kboard, recent_keys_index, total_keys, recent_keys):
11573 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11574 (this_single_command_key_start, echoing, last_auto_save):
11575 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11576 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11577 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11578 (Vlispy_mouse_stem, double_click_count):
11579 Now static.
11580 (force_auto_save_soon): Define only if SIGDANGER.
11581 (ignore_mouse_drag_p): Now static if
11582 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11583 (print_help): Remove; unused.
11584 (stop_character, last_timer_event): Mark as externally visible.
11585 * keyboard.h (ignore_mouse_drag_p): Declare only if
11586 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11587 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11588 * lisp.h (echoing): Remove decl.
11589 (force_auto_save_soon): Declare only if SIGDANGER.
11590 * xdisp.c (redisplay_window): Simplify code, to make it more
11591 obvious that ignore_mouse_drag_p is not accessed if !defined
11592 USE_GTK && !defined HAVE_NS.
11593
93ea6e8f
PE
11594 * intervals.c: Make symbols static if they're not exported.
11595 (merge_properties_sticky, merge_interval_right, delete_interval):
11596 Now static.
11597 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11598
77382fcc
PE
11599 * insdel.c: Make symbols static if they're not exported.
11600 However, leave prepare_to_modify_buffer alone. It's never
11601 called from outside this function, but that appears to be a bug.
11602 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11603 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11604 (adjust_after_replace_noundo): Remove; unused.
11605 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11606 (signal_before_change): Remove decls.
77382fcc 11607
9306c32e
PE
11608 * indent.c (val_compute_motion, val_vmotion): Now static.
11609
cd44d2eb
PE
11610 * image.c: Make symbols static if they're not exported.
11611 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11612 if USE_GTK.
11613 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11614 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11615
ad9a7a06
PE
11616 * fringe.c (standard_bitmaps): Now static.
11617 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11618
81626931
PE
11619 * frame.c: Make symbols static if they're not exported.
11620 (x_report_frame_params, make_terminal_frame): Now static.
11621 (get_frame_param): Now static, unless HAVE_NS.
11622 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11623 (x_get_resource_string): Remove; not used.
11624 * frame.h (make_terminal_frame, x_report_frame_params):
11625 (x_get_resource_string); Remove decls.
11626 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11627 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11628
239f9db9
PE
11629 * font.c, fontset.c: Make symbols static if they're not exported.
11630 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11631 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11632 * font.c (font_close_object): Now static.
11633 * font.h (font_close_object): Remove.
11634 * fontset.c (FONTSET_OBJLIST): Remove.
11635 (free_realized_fontset) #if-0 the body, which does nothing.
11636 (face_suitable_for_char_p): #if-0, as it's never called.
11637 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11638 * xfaces.c (face_at_string_position):
11639 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11640 since 0 is always ASCII.
11641
dfcf3579
PE
11642 * fns.c (weak_hash_tables): Now static.
11643
5045092b
PE
11644 * fileio.c: Make symbols static if they're not exported.
11645 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11646 (Vwrite_region_annotation_buffers): Now static.
11647
57a96f5c
PE
11648 * eval.c: Make symbols static if they're not exported.
11649 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11650 * lisp.h (backtrace_list): Remove decl.
11651
35f08c38
PE
11652 * emacs.c: Make symbols static if they're not exported.
11653 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11654 (fatal_error_code, fatal_error_signal_hook, standard_args):
11655 Now static.
11656 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11657 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11658 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11659 * lisp.h (fatal_error_signal_hook): Remove decl.
11660 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11661
f44bd759
PE
11662 * editfns.c: Move a (normally-unused) function to its only use.
11663 * editfns.c, lisp.h (get_operating_system_release): Remove.
11664 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11665 worth the hassle of breaking this out.
11666
b532497d
PE
11667 * xterm.c: Make symbols static if they're not exported.
11668 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11669 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11670 (x_destroy_window, x_delete_display):
11671 Now static.
11672 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11673 (x_mouse_leave): Remove; unused.
11674 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11675 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11676 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11677 Remove decls.
11678 (x_mouse_leave): Declare only if WINDOWSNT.
11679 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11680 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11681 USE_X_TOOLKIT.
11682
1675728f
PE
11683 * ftxfont.c: Make symbols static if they're not exported.
11684 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11685 HAVE_FREETYPE.
11686 * font.h (ftxfont_driver): Likewise.
11687
e4cebfca
PE
11688 * xfns.c: Make symbols static if they're not exported.
11689 (x_last_font_name, x_display_info_for_name):
11690 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11691 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11692 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11693 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11694 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11695 (last_show_tip_args): Now static.
11696 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11697 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11698 (x_screen_planes): Remove; unused.
11699 * dispextern.h (x_screen_planes): Remove decl.
11700
5bf46f05
PE
11701 * dispnew.c: Make symbols static if they're not exported.
11702 * dispextern.h (redraw_garbaged_frames, scrolling):
11703 (increment_row_positions): Remove.
11704 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11705 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11706 Now static.
11707 (redraw_garbaged_frames): Remove; unused.
11708
435f4c28
PE
11709 * xfaces.c: Make symbols static if they're not exported.
11710 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11711 Remove decls.
11712 * xterm.h (defined_color): Remove decls.
11713 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11714 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11715 (menu_face_changed_default, defined_color, free_realized_face):
11716 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11717 (ascii_face_of_lisp_face): Remove; unused.
11718
8524aef3
PE
11719 * xdisp.c: Make symbols static if they're not exported.
11720 * dispextern.h (scratch_glyph_row, window_box_edges):
11721 (glyph_to_pixel_coords, set_cursor_from_row):
11722 (get_next_display_element, set_iterator_to_next):
11723 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11724 (show_mouse_face): Remove decls
11725 * frame.h (message_buf_print): Likewise.
11726 * lisp.h (pop_message, set_message, check_point_in_composition):
11727 Likewise.
11728 * xterm.h (set_vertical_scroll_bar): Likewise.
11729 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11730 (message_buf_print, scratch_glyph_row, displayed_buffer):
11731 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11732 (get_next_display_element, show_mouse_face, window_box_edges):
11733 (frame_to_window_pixel_xy, check_point_in_composition):
11734 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11735 (glyph_to_pixel_coords): Remove; unused.
11736
16390cd2
PE
11737 * dired.c (file_name_completion): Now static.
11738
11739 * dbusbind.c (xd_in_read_queued_messages): Now static.
11740
a25f4dfa
PE
11741 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11742 * data.c (circular_list_error): Remove.
11743
14a9c8df
PE
11744 * commands.h (last_point_position, last_point_position_buffer):
11745 (last_point_position_window): Remove decls.
11746 * keyboard.c: Make these variables static.
11747
04f2d78b
CB
11748 * coding.h (coding, code_convert_region, encode_coding_gap):
11749 Remove decls.
74ab6df5
PE
11750 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11751 (iso_code_class, detect_coding, code_convert_region): Now static.
11752 (encode_coding_gap): Remove; unused.
11753
38dfbee1
PE
11754 * chartab.c (chartab_chars, chartab_bits): Now static.
11755
a2cb4e63
PE
11756 * charset.h (charset_iso_8859_1): Remove decl.
11757 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11758 Now static.
11759
127198fd
PE
11760 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11761 * ccl.c (Vccl_program_table): Now static.
11762 (check_ccl_update): Remove; unused.
11763
d85b608f
PE
11764 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11765 * category.h: ... from here.
11766 * category.c (check_category_table, set_category_set): Now static.
11767
31cd66f3
PE
11768 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11769 * lisp.h: Remove these decls.
11770
c358e587
PE
11771 * buffer.c (buffer_count): Remove unused var.
11772
e78aecca
PE
11773 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11774 so that it's not optimized away.
11775 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11776 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11777 exported only to the debugger.
11778
e192d7d3 11779 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11780 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11781
92470028
PE
11782 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11783 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11784 was inaccessible from Lisp.
11785 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11786 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11787
244ed907
PE
11788 alloc.c: Import and export fewer symbols, and remove unused items.
11789 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11790 is defined.
11791 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11792 it's not optimized away by whole-program optimization.
11793 (message_enable_multibyte, free_misc): Remove.
11794 (catchlist, handlerlist, mark_backtrace):
11795 Declare only if BYTE_MARK_STACK.
11796 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11797 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11798 (message_enable_multibyte): Remove decl.
11799 (free_misc, interval_free_list, float_block, float_block_index):
11800 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11801 (cons_free_list, last_marked_index):
11802 Now static.
11803 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11804 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11805 (mark_backtrace): Define only if BYTE_MARK_STACK.
11806 * xdisp.c (message_enable_multibyte): Now static.
11807
61c2b50e 11808 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11809 This makes it easier for human readers (and static analyzers)
11810 to see whether these variables are used from other modules.
11811 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11812 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11813 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11814 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11815 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11816 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11817 * xmenu.c, xselect.c:
11818 Declare Q* vars static if they are not used in other modules.
11819 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11820 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11821 Remove decls of unexported vars.
11822 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11823
95c82688
PE
11824 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11825
16a97296
PE
11826 Make Emacs functions such as Fatom 'static' by default.
11827 This makes it easier for human readers (and static analyzers)
11828 to see whether these functions can be called from other modules.
11829 DEFUN now defines a static function. To make the function external
11830 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11831 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11832 (Finit_image_library):
16a97296
PE
11833 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11834 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11835 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11836 Remove decls, since these functions are now static.
11837 (Funintern, Fget_internal_run_time): New decls, since these functions
11838 were already external.
95c82688 11839
16a97296
PE
11840 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11841 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11842 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11843 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11844 * keyboard.c, keymap.c, lread.c:
11845 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11846 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11847 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11848 Mark functions with DEFUE instead of DEFUN,
11849 if they are used in other modules.
11850 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11851 decls for now-static functions.
11852 * buffer.h (Fdelete_overlay): Remove decl.
11853 * callproc.c (Fgetenv_internal): Mark as internal.
11854 * composite.c (Fremove_list_of_text_properties): Remove decl.
11855 (Fcomposition_get_gstring): New forward static decl.
11856 * composite.h (Fcomposite_get_gstring): Remove decl.
11857 * dired.c (Ffile_attributes): New forward static decl.
11858 * doc.c (Fdocumntation_property): New forward static decl.
11859 * eval.c (Ffetch_bytecode): New forward static decl.
11860 (Funintern): Remove extern decl; now in .h file where it belongs.
11861 * fileio.c (Fmake_symbolic_link): New forward static decl.
11862 * image.c (Finit_image_library): New forward static decl.
11863 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11864 * intervals.h (Fprevious_property_change):
11865 (Fremove_list_of_text_properties): Remove decls.
11866 * keyboard.c (Fthis_command_keys): Remove decl.
11867 (Fcommand_execute): New forward static decl.
11868 * keymap.c (Flookup_key): New forward static decl.
11869 (Fcopy_keymap): Now static.
11870 * keymap.h (Flookup_key): Remove decl.
11871 * process.c (Fget_process): New forward static decl.
11872 (Fprocess_datagram_address): Mark as internal.
11873 * syntax.c (Fsyntax_table_p): New forward static decl.
11874 (skip_chars): Remove duplicate decl.
11875 * textprop.c (Fprevious_property_change): New forward static decl.
11876 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11877 Now internal.
11878 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11879 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11880
785bbd42
PE
11881 * editfns.c (Fformat): Remove unreachable code.
11882
8b913b57
AS
118832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11884
11885 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11886 change. (Bug#8496)
11887
a6744a35
EZ
118882011-04-13 Eli Zaretskii <eliz@gnu.org>
11889
11890 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11891 when at ZV. (Bug#8487)
11892
e7974947
AS
118932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11894
baad03f0
AS
11895 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11896 (Bug#8437)
11897 * keyboard.c (parse_tool_bar_item): Likewise.
11898 * sound.c (sound_cleanup, alsa_close): Likewise.
11899 * termcap.c (tgetent): Likewise.
11900 * xfns.c (x_default_font_parameter): Likewise.
11901 * xsettings.c (read_and_apply_settings): Likewise.
11902
e7974947
AS
11903 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11904 (overrun_check_free): Protoize.
11905
28272684
PE
119062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11907
11908 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11909 since callers should never pass a negative size.
11910 Change the signature to match that of plain 'read' and 'write'; see
11911 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11912 * lisp.h: Update prototypes of emacs_write and emacs_read.
11913
11997c76
EZ
119142011-04-11 Eli Zaretskii <eliz@gnu.org>
11915
11916 * xdisp.c (redisplay_window): Don't try to determine the character
11917 position of the scroll margin if the window start point w->startp
e896f03c 11918 is outside the buffer's accessible region. (Bug#8468)
11997c76 11919
8a2cbd72
EZ
119202011-04-10 Eli Zaretskii <eliz@gnu.org>
11921
11922 Fix write-region and its subroutines for buffers > 2GB.
11923 * fileio.c (a_write, e_write): Modify declaration of arguments and
11924 local variables to support buffers larger than 2GB.
11925 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11926
11927 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11928 argument, local variables, and return value.
11929
11930 * lisp.h: Update prototypes of emacs_write and emacs_read.
11931
11932 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11933
4073e537 119342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11935
1ebfdcb6
PE
11936 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11937
b2ded58d
PE
11938 Fix more problems found by GCC 4.6.0's static checks.
11939
7d66342c
PE
11940 * xdisp.c (vmessage): Use a better test for character truncation.
11941
bbf47d44
PE
11942 * charset.c (load_charset_map): <, not <=, for optimization,
11943 and to avoid potential problems with integer overflow.
9248994d 11944 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11945 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11946 * editfns.c (Fformat): Likewise.
1e69125e 11947 * syntax.c (skip_chars): Likewise.
3befa583 11948
e3019616
PE
11949 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11950 This also lets GCC 4.6.0 generate slightly better loop code.
11951
becfa255
PE
11952 * callint.c (Fcall_interactively): <, not <=, for optimization.
11953 (Fcall_interactively): Count the number of arguments produced,
11954 not the number of arguments given. This is simpler and lets GCC
11955 4.6.0 generate slightly better code.
11956
dae0cd48
PE
11957 * ftfont.c: Distingish more carefully between FcChar8 and char.
11958 The previous code passed unsigned char * to a functions like
11959 strlen and xstrcasecmp that expect char *, which does not
11960 conform to the C standard.
11961 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11962 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11963 char * when the C standard requires it.
11964
76032d70
PE
11965 * keyboard.c (read_char): Remove unused var.
11966
eb3f1cc8
PE
11967 * eval.c: Port to Windows vsnprintf (Bug#8435).
11968 Include <limits.h>.
11969 (SIZE_MAX): Define if the headers do not.
11970 (verror): Do not give up if vsnprintf returns a negative count.
11971 Instead, grow the buffer. This ports to Windows vsnprintf, which
11972 does not conform to C99. Problem reported by Eli Zaretskii.
11973 Also, simplify the allocation scheme, by avoiding the need for
11974 calling realloc, and removing the ALLOCATED variable.
11975
70476b54
PE
11976 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11977
12020a9e
PE
11978 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11979 But keep the doprint source code for now, as we might revamp it
11980 and use it again (Bug#8435).
ea6c7ae6
PE
11981 * lisp.h (doprnt): Remove.
11982 * Makefile.in (base_obj): Remove doprnt.o.
11983 * deps.mk (doprnt.o): Remove.
11984
5fdb398c
PE
11985 error: Print 32- and 64-bit integers portably (Bug#8435).
11986 Without this change, on typical 64-bit hosts error ("...%d...", N)
11987 was used to print both 32- and 64-bit integers N, which relied on
11988 undefined behavior.
61bdb816 11989 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11990 * lisp.h (error, verror): Mark as printf-like functions.
11991 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11992 Report overflow in size calculations when allocating printf buffer.
11993 Do not truncate output string at its first null byte.
11994 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11995 Truncate the output at a character boundary, since vsnprintf does not
11996 do that.
11997 * charset.c (check_iso_charset_parameter): Convert internal
11998 character to string before calling 'error', since %c now has the
11999 printf meaning.
12000 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12001 overflow when computing char to be passed to 'error'. Do not
12002 pass Lisp_Object to 'error'; pass the integer instead.
12003 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12004 formatted with plain %d.
12005
b189fa66
PE
12006 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12007
bff87ef0
PE
12008 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12009
7e2cac20
PE
12010 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12011
ce4d90b5
PE
12012 * xterm.c (x_catch_errors): Remove duplicate declaration.
12013
266c9547
PE
12014 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12015
79c49ad2
PE
12016 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12017
368f4090
JM
120182011-04-10 Jim Meyering <meyering@redhat.com>
12019
12020 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12021 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12022 return ssize_t not "int", and use size_t as the buffer length.
12023 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12024 * gnutls.h: Update declarations.
12025 * process.c (read_process_output): Use ssize_t, to match.
12026 (send_process): Likewise.
12027
a32d4040
CY
120282011-04-09 Chong Yidong <cyd@stupidchicken.com>
12029
12030 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12031
8546720e 120322011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12033
04f2d78b
CB
12034 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12035 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12036
8546720e
GM
12037 * xterm.c (handle_one_xevent):
12038 * xmenu.c (create_and_show_popup_menu):
12039 * xselect.c (x_decline_selection_request)
12040 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12041
0a2f5c1a 120422011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12043
12044 Fix some uses of `int' instead of EMACS_INT.
12045 * search.c (string_match_1, fast_string_match)
12046 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12047 (scan_buffer, find_next_newline_no_quit)
12048 (find_before_next_newline, search_command, Freplace_match)
12049 (Fmatch_data): Make some `int' variables be EMACS_INT.
12050
12051 * xdisp.c (display_count_lines): 3rd argument and return value now
12052 EMACS_INT. All callers changed.
12053 (pint2hrstr): Last argument is now EMACS_INT.
12054
12055 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12056 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12057 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12058 (decode_coding_utf_16, decode_coding_emacs_mule)
12059 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12060 (decode_coding_ccl, decode_coding_charset)
12061 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12062 (decode_coding_iso_2022, decode_coding_emacs_mule)
12063 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12064 <char_offset, last_offset>: Declare EMACS_INT.
12065 (encode_coding_utf_8, encode_coding_utf_16)
12066 (encode_coding_emacs_mule, encode_invocation_designation)
12067 (encode_designation_at_bol, encode_coding_iso_2022)
12068 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12069 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12070 Declare EMACS_INT.
12071 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12072 (encode_invocation_designation): Last argument P_NCHARS is now
12073 EMACS_INT.
12074 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12075 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12076
12077 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12078 All users changed.
12079
12080 * ccl.c (Fccl_execute_on_string): Declare some variables
12081 EMACS_INT.
12082
8546720e 120832011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12084
12085 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12086
4e19a977
CS
120872011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12088
12089 * process.c (Fformat_network_address): Doc fix.
12090
87302331
R
120912011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12092
ee7683eb 12093 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12094
cbb59342
CY
120952011-04-08 Chong Yidong <cyd@stupidchicken.com>
12096
12097 * keyboard.c (read_char): Call Lisp function help-form-show,
12098 instead of using internal_with_output_to_temp_buffer.
12099 (Qhelp_form_show): New var.
e0d38eeb 12100 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12101
12102 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12103
12104 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12105
e67a13ab
CY
121062011-04-06 Chong Yidong <cyd@stupidchicken.com>
12107
04f2d78b
CB
12108 * process.c (Flist_processes): Remove to Lisp.
12109 (list_processes_1): Delete.
e67a13ab 12110
973f782d
EZ
121112011-04-06 Eli Zaretskii <eliz@gnu.org>
12112
7c106b1e
EZ
12113 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12114
973f782d
EZ
12115 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12116
41cf7d1a 121172011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12118
ca23cc88
PE
12119 Fix more problems found by GCC 4.6.0's static checks.
12120
f390e2d5
PE
12121 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12122
42eea0d0
PE
12123 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12124
b69769da 12125 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12126
f9541e84
PE
12127 * xdisp.c (vmessage): Mark as a printf-like function.
12128
13841b55
PE
12129 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12130
c136c10f
PE
12131 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12132
5e2d4a30
PE
12133 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12134 printf-like functions.
12135 (tiff_load): Add casts to remove these marks before passing them
12136 to system-supplied API.
12137
583f48b9
PE
12138 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12139
b25d760e
PE
12140 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12141 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12142 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12143 directly, rather than having caller test rule sign. This avoids
12144 some unnecessary tests.
12145 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12146 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12147 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12148
bc7b6697 12149 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12150 (xfont_open): Avoid unnecessary tests.
bc7b6697 12151
27ccc379
PE
12152 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12153
dcd5c89a
PE
12154 * composite.h, composite.c (composition_gstring_put_cache):
12155 Use EMACS_INT, not int, for length.
12156
b13a45c6
PE
12157 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12158 breaking out part of COMPOSITION_DECODE_RULE.
12159 (COMPOSITION_DECODE_RULE): Use it.
12160 * composite.c (get_composition_id): Remove unused local vars,
12161 by using the new macro.
12162
1e792e4d
PE
12163 * textprop.c (set_text_properties_1): Change while to do-while,
12164 since the condition is always true at first.
12165
dc6c6455 12166 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12167 (interval_deletion_adjustment): Return unsigned value.
12168 All uses changed.
dc6c6455 12169
aba7731a
PE
12170 * process.c (list_processes_1, create_pty, read_process_output):
12171 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12172 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12173 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12174 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12175 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12176
fdfc4bf3
PE
12177 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12178
fca8fe46 12179 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12180 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12181
06a0259a 12182 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12183 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12184 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12185
e7b9e80f
PE
12186 * print.c (print_error_message): Avoid int overflow.
12187
56201685
PE
12188 * font.c (font_list_entities): Redo for clarity,
12189 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12190
78834453 12191 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12192 (font_score): Avoid potential overflow in diff calculation.
78834453 12193
0bc0b309 12194 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12195 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12196
e610eaca
PE
12197 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12198
b895abce
PE
12199 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12200 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12201 can always succeed if overflow has undefined behavior.
12202
1f1d9321 12203 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12204 (wordify): Omit three unnecessary tests.
1f1d9321 12205
c59478bc
PE
12206 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12207 All callers changed. This avoids the need for an unused var.
12208
79b73827
PE
12209 * casefiddle.c (casify_region): Remove var that is set but not used.
12210
a4db5dfe
PE
12211 * dired.c (file_name_completion): Remove var that is set but not used.
12212
43aae36e
PE
12213 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12214
2a47c44d 12215 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12216 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12217
a37c69bf
PE
12218 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12219 Check for integer overflow on size calculations.
12220
328ab8e7
PE
12221 * buffer.c (Fprevious_overlay_change): Remove var that is set
12222 but not used.
12223
e5a2a5cb
PE
12224 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12225 Remove vars that are set but not used.
8d84a6eb 12226 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12227 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12228
a60e5f68
PE
12229 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12230
f661cb61 12231 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12232 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12233
f0397f5a
PE
12234 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12235 that are set but not used.
12236
8664db06 12237 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12238 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12239
6abdaa4a
PE
12240 * xselect.c (x_get_local_selection, x_handle_property_notify):
12241 Remove vars that are set but not used.
12242
0ce7538d 12243 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12244 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12245
9ae848fc
PE
12246 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12247 Remove var that is set but not used.
0b918413
PE
12248 (scroll_bar_windows_size): Now size_t, not int.
12249 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12250 Check for overflow.
9ae848fc 12251
a5a62657
PE
12252 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12253 (map_tty_color) [!defined MSDOS]: Likewise.
12254
5c5cdd39
PE
12255 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12256
66ebf983
PE
12257 * coding.c: Remove vars that are set but not used.
12258 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12259 All callers changed.
12260 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12261 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12262 (decode_coding_charset): Remove vars that are set but not used.
12263
1be4d761
PE
12264 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12265 that is set but not used.
12266
47553fa8
PE
12267 * print.c (print_object): Remove var that is set but not used.
12268
1f7196bf 12269 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12270 The gnulib version avoids calling malloc in the usual case,
12271 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12272 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12273 * filelock.c (current_lock_owner): Likewise.
12274 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12275 * sysdep.c: Include allocator.h, careadlinkat.h.
12276 (emacs_no_realloc_allocator): New static constant.
12277 (emacs_readlink): New function.
fdb61804
PE
12278 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12279 ../lib/careadlinkat.h.
d1fdcab7 12280
f84c17c7
SM
122812011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12282
12283 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12284 first non-nil return value).
12285
ef3862ad
JD
122862011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12287
12288 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12289 if not defined (Bug#8403).
12290
376a7006
JB
122912011-04-02 Juanma Barranquero <lekktu@gmail.com>
12292
12293 * xdisp.c (display_count_lines): Remove parameter `start',
12294 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12295 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12296 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12297 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12298 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12299 and thereabouts. All callers changed.
12300 (get_per_char_metric): Remove parameter `f', unused since
12301 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12302
6ca3801d
JM
123032011-04-02 Jim Meyering <meyering@redhat.com>
12304
12305 do not dereference NULL upon failed strdup
12306 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12307 (ns_get_family): Likewise.
12308
d8e2b5ba
JB
123092011-04-02 Juanma Barranquero <lekktu@gmail.com>
12310
12311 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12312
8c74fcbd
JD
123132011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12314
12315 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12316 later (Bug#8403).
12317
7200d79c
SM
123182011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12319
03408648 12320 Add lexical binding.
7200d79c 12321
03408648
SM
12322 * window.c (Ftemp_output_buffer_show): New fun.
12323 (Fsave_window_excursion):
12324 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12325
12326 * lread.c (lisp_file_lexically_bound_p): New function.
12327 (Fload): Bind Qlexical_binding.
12328 (readevalloop): Remove `evalfun' arg.
12329 Bind Qinternal_interpreter_environment.
12330 (Feval_buffer): Bind Qlexical_binding.
12331 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12332 Mark as dynamic.
12333 (syms_of_lread): Declare `lexical-binding'.
12334
12335 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12336
12337 * keyboard.c (eval_dyn): New fun.
12338 (menu_item_eval_property): Use it.
ca105506
SM
12339
12340 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12341
03408648
SM
12342 * fns.c (concat, mapcar1): Accept byte-code-functions.
12343
12344 * eval.c (Fsetq): Handle lexical vars.
12345 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12346 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12347 (FletX, Flet): Obey lexical binding.
12348 (Fcommandp): Handle closures.
12349 (Feval): New `lexical' arg.
12350 (eval_sub): New function extracted from Feval. Use it almost
12351 everywhere where Feval was used. Look up vars in lexical env.
12352 Handle closures.
12353 (Ffunctionp): Move from subr.el.
12354 (Ffuncall): Handle closures.
12355 (apply_lambda): Remove `eval_flags'.
12356 (funcall_lambda): Handle closures and new byte-code-functions.
12357 (Fspecial_variable_p): New function.
12358 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12359 but without exporting it to Lisp.
23aba0ea 12360
23aba0ea 12361 * doc.c (Fdocumentation, store_function_docstring):
03408648 12362 * data.c (Finteractive_form): Handle closures.
23aba0ea 12363
03408648
SM
12364 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12365 interactive spec.
ba83908c 12366
04f2d78b
CB
12367 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12368 New byte-codes.
03408648
SM
12369 (exec_byte_code): New function extracted from Fbyte_code to handle new
12370 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12371
03408648 12372 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12373
03408648 12374 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12375
e2abce01
JB
123762011-03-31 Juanma Barranquero <lekktu@gmail.com>
12377
12378 * xdisp.c (redisplay_internal): Fix prototype.
12379
63696a73 123802011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12381
63696a73 12382 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12383 (try_scrolling): Use it when setting scroll_limit.
12384 Limit scrolling to 100 screen lines.
63696a73
EZ
12385 (redisplay_window): Even when falling back on "recentering",
12386 position point in the window according to scroll-conservatively,
12387 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12388
12389 (try_scrolling): When point is above the window, allow searching
12390 as far as scroll_max, or one screenful, to compute vertical
12391 distance from PT to the scroll margin position. This prevents
12392 try_scrolling from unnecessarily failing when
12393 scroll-conservatively is set to a value slightly larger than the
12394 window height. Clean up the case of PT below the margin at bottom
12395 of window: scroll_max can no longer be INT_MAX. When aggressive
12396 scrolling is in use, don't let point enter the opposite scroll
12397 margin as result of the scroll.
12398 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12399 threshold of 100 lines for never-recentering scrolling.
12400
e4cc2dfc
JB
124012011-03-31 Juanma Barranquero <lekktu@gmail.com>
12402
12403 * dispextern.h (move_it_by_lines):
12404 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12405 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12406 (message_log_check_duplicate): Remove parameters `prev_bol' and
12407 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12408 (redisplay_internal): Remove parameter `preserve_echo_area',
12409 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12410
12411 * indent.c (Fvertical_motion):
12412 * window.c (window_scroll_pixel_based, Frecenter):
12413 Don't pass `need_y_p' to `move_it_by_lines'.
12414
1c470562
SM
124152011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12416
44f230aa
SM
12417 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12418 steal a few bits to be more compact.
12419 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12420 Remove unneeded casts.
12421
1c470562
SM
12422 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12423
888adce9
ZK
124242011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12425
12426 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12427 binding" message (bug#7967).
12428
f838ed7b
PE
124292011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12430
77861b95
PE
12431 Fix more problems found by GCC 4.6.0's static checks.
12432
de6dbc14
PE
12433 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12434 Remove unused local var.
12435
f838ed7b
PE
12436 * editfns.c (Fmessage_box): Remove unused local var.
12437
792c7b2b
PE
12438 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12439 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12440 Omit unused local vars.
c499e557 12441 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12442 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12443 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12444 Omit unused local var.
12445
ba0165e1
PE
12446 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12447 Don't assume string length fits in int.
32ad8845 12448 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12449 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12450
3c59b4c9
PE
12451 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12452 instead of alloca (Bug#8344).
12453
a3eed478 12454 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12455 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12456
eb4d412d
PE
12457 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12458
1658b401
PE
12459 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12460 concerns.
12461
12462 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12463
12464 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12465
9a2c6e05
PE
12466 * keyboard.c (syms_of_keyboard): Use the same style as later
12467 in this function when indexing through an array. This also
12468 works around GCC bug 48267.
12469
03d0a109
PE
12470 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12471
44f730c8
PE
12472 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12473
fe75f926
PE
12474 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12475 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12476
ffa8c828
PE
12477 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12478 This avoids undefined behavior on integer overflow, and is a bit
12479 more convenient anyway since it is compared to a size_t variable.
12480
c5101a77
PE
12481 Variadic C functions now count arguments with size_t, not int.
12482 This avoids an unnecessary limitation on 64-bit machines, which
12483 caused (substring ...) to crash on large vectors (Bug#8344).
12484 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12485 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12486 All variadic functions and their callers changed accordingly.
c5101a77
PE
12487 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12488 * data.c (arith_driver, float_arith_driver): Likewise.
12489 * editfns.c (general_insert_function): Likewise.
12490 * eval.c (struct backtrace.nargs, interactive_p)
12491 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12492 (funcall_lambda, mark_backtrace): Likewise.
12493 * fns.c (concat): Likewise.
12494 * frame.c (x_set_frame_parameters): Likewise.
12495 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12496 0 if not found, not -1. All callers changed.
12497
dd3f25f7
PE
12498 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12499 (stack_copy_size): Now size_t, not int.
12500 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12501
461c2ab9
JB
125022011-03-28 Juanma Barranquero <lekktu@gmail.com>
12503
12504 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12505 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12506 All callers changed.
12507
12508 * lisp.h (multibyte_char_to_unibyte):
12509 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12510 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12511 * character.h (CHAR_TO_BYTE8):
12512 * cmds.c (internal_self_insert):
12513 * editfns.c (general_insert_function):
12514 * keymap.c (push_key_description):
12515 * search.c (Freplace_match):
12516 * xdisp.c (message_dolog, set_message_1): All callers changed.
12517
f6d62986
SM
125182011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12519
12520 * keyboard.c (safe_run_hook_funcall): New function.
12521 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12522 don't set the hook to nil, but remove the offending function instead.
12523 (Qcommand_hook_internal): Remove, unused.
12524 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12525 Vcommand_hook_internal.
12526
12527 * eval.c (enum run_hooks_condition): Remove.
12528 (funcall_nil, funcall_not): New functions.
12529 (run_hook_with_args): Call each function through a `funcall' argument.
12530 Remove `cond' argument, now redundant.
12531 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12532 (Frun_hook_with_args_until_failure): Adjust accordingly.
12533 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12534
1db5b1ad
JB
125352011-03-28 Juanma Barranquero <lekktu@gmail.com>
12536
12537 * dispextern.h (string_buffer_position): Remove declaration.
12538
12539 * print.c (strout): Remove parameter `multibyte', unused since
12540 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12541
12542 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12543 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12544 All callers changed.
12545
12546 * w32.c (_wsa_errlist): Use braces for struct initializers.
12547
12548 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12549 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12550 All callers changed.
12551 (string_buffer_position): Likewise. Also, make static (it's never
12552 used outside xdisp.c).
12553 (cursor_row_p): Remove parameter `w', unused since
12554 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12555 (decode_mode_spec): Remove parameter `precision', introduced during
12556 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12557 All callers changed.
12558
5ffb62aa
JD
125592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12560
12561 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12562
461c2ab9 125632011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12564
12565 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12566 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12567 (ns_update_auto_hide_menu_bar): New functions.
12568 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12569 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12570 ns_constrain_all_frames.
12571 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12572 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12573
5c380ffb
JD
125742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12575
12576 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12577
9af30bdf
GM
125782011-03-27 Glenn Morris <rgm@gnu.org>
12579
12580 * syssignal.h: Replace RETSIGTYPE with void.
12581 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12582 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12583 Replace SIGTYPE with void everywhere.
12584 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12585 * s/template.h (SIGTYPE): Remove commented out definition.
12586
e2abce01
JB
125872011-03-26 Eli Zaretskii <eliz@gnu.org>
12588
12589 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12590 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12591
f868cd8a
JB
125922011-03-26 Juanma Barranquero <lekktu@gmail.com>
12593
59eb0929
JB
12594 * w32.c (read_unc_volume): Use parameter `henum', instead of
12595 global variable `wget_enum_handle'.
12596
12597 * keymap.c (describe_vector): Remove parameters `indices' and
12598 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12599 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12600
f868cd8a
JB
12601 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12602
12603 * keyboard.c (timer_check): Remove parameter `do_it_now',
12604 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12605 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12606 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12607
12608 * keyboard.c (read_char):
12609 * w32menu.c (w32_menu_display_help):
12610 * xmenu.c (show_help_event, menu_help_callback):
12611 Adjust calls to `show_help_echo'.
12612
12613 * gtkutil.c (xg_maybe_add_timer):
12614 * keyboard.c (readable_events):
12615 * process.c (wait_reading_process_output):
12616 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12617
12618 * insdel.c (adjust_markers_gap_motion):
12619 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12620 (gap_left, gap_right): Don't call it.
12621
2ecf6fdb
CY
126222011-03-25 Chong Yidong <cyd@stupidchicken.com>
12623
12624 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12625 incurred during fontification.
12626
6b1f9ba4
JB
126272011-03-25 Juanma Barranquero <lekktu@gmail.com>
12628
12629 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12630 (DEFVAR_PER_BUFFER): Don't pass it.
12631
12632 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12633 (scrolling_window): Don't pass it.
12634
0f4a96b5
JB
126352011-03-25 Juanma Barranquero <lekktu@gmail.com>
12636
12637 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12638
12639 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12640 and `suffix'.
12641 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12642 of variables specific to SELinux and computation of `encoded_absname'.
12643
12644 * image.c (XPutPixel): Remove unused variable `height'.
12645
12646 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12647
12648 * unexw32.c (get_section_info): Remove unused variable `section'.
12649
12650 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12651 (system_process_attributes): Remove unused variable `sess'.
12652 (sys_read): Remove unused variable `err'.
12653
12654 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12655 (w32_wnd_proc): Remove unused variable `isdead'.
12656 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12657 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12658 (x_create_tip_frame): Remove unused variable `tem'.
12659
12660 * w32inevt.c (w32_console_read_socket):
12661 Remove unused variable `no_events'.
12662
12663 * w32term.c (x_draw_composite_glyph_string_foreground):
12664 Remove unused variable `width'.
12665
1149507c
JB
126662011-03-24 Juanma Barranquero <lekktu@gmail.com>
12667
12668 * w32term.c (x_set_glyph_string_clipping):
12669 Don't pass uninitialized region to CombineRgn.
12670
9c88f339
JB
126712011-03-23 Juanma Barranquero <lekktu@gmail.com>
12672
12673 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12674 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12675 (Fx_close_connection): Remove unused variable `i'.
12676
12677 * w32font.c (w32font_draw): Return number of glyphs.
12678 (w32font_open_internal): Remove unused variable `i'.
12679 (w32font_driver): Add missing initializer.
12680
12681 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12682 (fill_in_menu): Remove unused variable `items_added'.
12683
12684 * w32term.c (last_mouse_press_frame): Remove static global variable.
12685 (w32_clip_to_row): Remove unused variable `f'.
12686 (x_delete_terminal): Remove unused variable `i'.
12687
12688 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12689 (NOTHING): Remove unused static global variable.
12690 (uniscribe_check_otf): Remove unused variable `table'.
12691 (uniscribe_font_driver): Add missing initializers.
12692
dee091a3
JD
126932011-03-23 Julien Danjou <julien@danjou.info>
12694
12695 * term.c (Fsuspend_tty, Fresume_tty):
12696 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12697 * window.c (temp_output_buffer_show):
12698 * insdel.c (signal_before_change):
12699 * frame.c (Fhandle_switch_frame):
12700 * fileio.c (Fdo_auto_save):
12701 * emacs.c (Fkill_emacs):
12702 * editfns.c (save_excursion_restore):
12703 * cmds.c (internal_self_insert):
12704 * callint.c (Fcall_interactively):
12705 * buffer.c (Fkill_all_local_variables):
12706 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12707 Use Frun_hooks.
0f4a96b5 12708 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12709 unconditionally since it does the check itself.
dee091a3 12710
2c520ab5 127112011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12712
c9c49752
PE
12713 Fix more problems found by GCC 4.5.2's static checks.
12714
8abc3f12
PE
12715 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12716 the first time through the loop, since we know p0 < p1 then.
12717 This also avoids a gcc -Wstrict-overflow warning.
12718
a2d26660
PE
12719 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12720 leading to a memory leak, possible in functions like
12721 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12722 of objects (Bug#8318).
a2d26660 12723
916c72e9
PE
12724 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12725 that could (at least in theory) be that large.
12726
19ab8a18
PE
12727 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12728 This is less likely to overflow, and avoids undefined behavior if
12729 overflow does occur. All callers changed. Use strtoul to scan
12730 for the unsigned long integer.
b7cbbd6f
PE
12731 (pint2hrstr): Simplify and tune code slightly.
12732 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12733
f0641eff
PE
12734 * scroll.c (do_scrolling): Work around GCC bug 48228.
12735 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12736
7f650bb9
PE
12737 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12738 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12739 (validate_x_resource_name): Simplify count usage.
12740 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12741
37dd57d1
PE
12742 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12743 fail (Bug#8306).
81e56e61 12744
699979fc 12745 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12746
401bf9b4
PE
12747 * process.c (Fmake_network_process): Use socklen_t, not int,
12748 where POSIX says socklen_t is required in portable programs.
12749 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12750 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12751 (Fmake_network_process, server_accept_connection):
12752 (wait_reading_process_output, read_process_output):
12753 Likewise.
12754
b93aacde
PE
12755 * process.c: Rename or move locals to avoid shadowing.
12756 (list_processes_1, Fmake_network_process):
12757 (read_process_output_error_handler, exec_sentinel_error_handler):
12758 Rename or move locals.
4dc343ee 12759 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12760 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12761 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12762 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12763 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12764
af8a867c 12765 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12766 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12767 Include tparam.h instead, since it declares them.
af8a867c
PE
12768 * cm.h (PC): Remove extern decl; tparam.h now does this.
12769 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12770 * terminfo.c: Include tparam.h, to check interfaces.
12771 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12772 (tparam): Adjust signature to match interface in tparam.h;
12773 this removes some undefined behavior. Check that outstring and len
12774 are zero, which they always are with Emacs.
12775 * tparam.h (PC, BC, UP): New extern decls.
12776
0248044d 12777 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12778 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12779
8ff096c1 12780 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12781 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12782 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12783 (ftfont_list): Remove unused local.
49eaafba
PE
12784 (get_adstyle_property, ftfont_pattern_entity):
12785 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12786 Rename locals to avoid shadowing.
8ff096c1 12787
e2be39f6
PE
12788 * xfont.c (xfont_list_family): Mark var as initialized.
12789
c9735e30
PE
12790 * xml.c (make_dom): Now static.
12791
8f5201ae
PE
12792 * composite.c (composition_compute_stop_pos): Rename local to
12793 avoid shadowing.
b246f932
PE
12794 (composition_reseat_it): Remove unused locals.
12795 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12796 (composition_update_it): Mark var as initialized.
11b61122
PE
12797 (find_automatic_composition): Mark vars as initialized,
12798 with a FIXME (Bug#8290).
8f5201ae 12799
760fbc2c
PE
12800 character.h: Rename locals to avoid shadowing.
12801 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12802 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12803 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12804 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12805 to avoid shadowing.
12806
ff08eb85
PE
12807 * textprop.c (property_change_between_p): Remove; unused.
12808
fc7bf025
PE
12809 * intervals.c (interval_start_pos): Now static.
12810
235d7abc
PE
12811 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12812
44f230aa
SM
12813 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12814 Rename locals to avoid shadowing.
3e7d6594 12815
50060332
PE
12816 * sound.c (wav_play, au_play, Fplay_sound_internal):
12817 Fix pointer signedness.
d01f234b 12818 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12819 (wav_play): Initialize a variable to 0, to prevent undefined
12820 behavior (Bug#8278).
50060332 12821
c4fc4e30
PE
12822 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12823
918436ed
PE
12824 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12825
c939f91b
PE
12826 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12827 clobbering (Bug#8298).
b9c7f648
PE
12828 * sysdep.c (sys_subshell): Likewise.
12829 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12830
6bd8c144
PE
12831 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12832 This should get cleaned up, so that child_setup has the
12833 same signature on all platforms.
12834
7710357c 12835 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12836 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12837
c59da222
CY
128382011-03-22 Chong Yidong <cyd@stupidchicken.com>
12839
12840 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12841 not to be necessary, and produces flickering.
12842
66b87493
GM
128432011-03-20 Glenn Morris <rgm@gnu.org>
12844
12845 * config.in: Remove file.
12846
45b6f6d5
JB
128472011-03-20 Juanma Barranquero <lekktu@gmail.com>
12848
12849 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12850 are now in src/globals.h.
12851 (syms_of_minibuf): Remove spurious & from previous change.
12852
cd394be1 128532011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12854
12855 * minibuf.c (completing-read-function): New variable.
12856 (completing-read-default): Rename from completing-read.
12857 (completing-read): Call completing-read-function.
12858
b14e3e21
CY
128592011-03-19 Juanma Barranquero <lekktu@gmail.com>
12860
12861 * xfaces.c (Fx_load_color_file):
12862 Read color file from absolute filename (bug#8250).
12863
f2b726e6
JB
128642011-03-19 Juanma Barranquero <lekktu@gmail.com>
12865
12866 * makefile.w32-in: Update dependencies.
12867
09f6ff02
EZ
128682011-03-17 Eli Zaretskii <eliz@gnu.org>
12869
12870 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12871
29a6015a
PE
128722011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12873
a3a6c54e
PE
12874 Fix more problems found by GCC 4.5.2's static checks.
12875
b766f867
PE
12876 * process.c (make_serial_process_unwind, send_process_trap):
12877 (sigchld_handler): Now static.
12878
be02381c
PE
12879 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12880 That way, the code declares only the vars that it needs.
12881 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12882 * s/cygwin.h (PTY_ITERATION): Likewise.
12883 * s/darwin.h (PTY_ITERATION): Likewise.
12884 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12885
57048744
PE
12886 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12887 * process.c (allocate_pty): Don't declare stb unless it's needed.
12888
7914961c 12889 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12890 (CONSTANTLIM): Remove; unused.
12891 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12892 Define only if needed.
7914961c 12893
b3967b18
PE
12894 * unexelf.c (unexec): Name an expression,
12895 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12896 Use a different way to cause a compilation error if anyone uses
12897 n rather than nn, a way that does not involve shadowing.
73366a00 12898 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12899
29a6015a
PE
12900 * deps.mk (unexalpha.o): Remove; unused.
12901
43cfc33e 12902 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12903 * unexec.h: New file.
ce701a33
PE
12904 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12905 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12906 Depend on unexec.h.
12907 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12908 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12909 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12910 Change as necessary to match prototype in unexec.h.
ce701a33 12911
01f44d5a
PE
12912 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12913 shadowing.
4f63c6bb 12914 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12915
a6670b0b
PE
12916 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12917 Rename locals to avoid shadowing.
12918
cef2010d 12919 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12920 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12921
d4d7173a
PE
12922 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12923
f08b802a
PE
12924 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12925 warning when compiling print.c.
12926
3ddb0639
PE
12927 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12928 instead of using an uninitialized var.
5ad03b97 12929 (font_sort_entities): Mark var as initialized.
3ddb0639 12930
170a2692
PE
12931 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12932
e663c700
PE
12933 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12934 pointers to constants.
89bc529a 12935 (font_parse_fcname): Remove unused vars.
7b81e2d0 12936 (font_delete_unmatched): Now static.
ea838e10 12937 (font_get_spec): Remove; unused.
13a547c6
PE
12938 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12939 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12940 Rename or move locals to avoid shadowing.
e663c700 12941
2a80c887 12942 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12943 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12944
1384fa33 12945 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12946 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12947
8b2c52e9
PE
12948 * alloc.c (mark_backtrace): Move decl from here ...
12949 * lisp.h: ... to here, so that it can be checked.
12950
475545b5 12951 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12952 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12953 (lisp_indirect_variable): Name an expression,
12954 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12955 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12956
b1349114 12957 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12958 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12959 Use const pointer when appropriate.
b1349114 12960
a2928364
PE
12961 * lisp.h (get_system_name, get_operating_system_release):
12962 Move decls here, to check interfaces.
12963 * process.c (get_operating_system_release): Move decl to lisp.h.
12964 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12965 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12966 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12967 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12968 (Fformat_time_string, Fencode_time, Finsert_char):
12969 (Ftranslate_region_internal, Fformat):
12970 Rename or remove local vars to avoid shadowing.
9710023e 12971 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12972
a415e694
PE
12973 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12974 avoid shadowing.
12975
8ef4622d
PE
12976 * lisp.h (eassert): Check that the argument compiles, even if
12977 ENABLE_CHECKING is not defined.
12978
946f9a5b
PE
12979 * data.c (Findirect_variable): Name an expression, to avoid
12980 gcc -Wbad-function-cast warning.
112396d6 12981 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12982 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12983 (Fmake_variable_buffer_local, Fmake_local_variable):
12984 Mark variables as initialized.
52746918 12985 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12986
e5aab7e7 12987 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12988 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12989 Rename locals to avoid shadowing.
dff45157
PE
12990 (mark_stack): Move local variables into the #ifdef region where
12991 they're used.
7bc26fdb
PE
12992 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12993 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12994 needed otherwise.
12995 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12996 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12997 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12998
e5aab7e7
PE
12999 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13000 avoids undefined behavior in theory.
13001
4da60324
PE
13002 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13003
88043301
PE
13004 Use functions, not macros, for up- and down-casing (Bug#8254).
13005 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13006 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13007 to use the following functions instead of these macros.
13008 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13009 EMACS_INT, since callers assume the returned value fits in int.
13010 (upcase1): Likewise, for UPCASE_TABLE.
13011 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13012 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13013 the race-condition problem in the old DOWNCASE.
88043301 13014
19ed5445
PE
13015 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13016 Rename locals to avoid shadowing.
13017 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13018 (regex_compile, re_search_2, re_match_2_internal):
13019 Remove unused local vars.
952db0d7
PE
13020 (FREE_VAR): Rewrite so as not to use empty "else",
13021 which gcc can warn about.
da053e48 13022 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13023 (RETALLOC_IF): Define only if needed.
13024 (WORDCHAR_P): Likewise. This one is never needed, but is used
13025 only in a comment talking about a compiler bug, so put inside
13026 the #if 0 of that comment.
13027 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13028 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13029 Remove; unused.
19ed5445 13030
1f3561e4 13031 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13032 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13033 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13034
ded6f8f7
PE
13035 * search.c (simple_search): Remove unused var.
13036
dbd37a95
PE
13037 * dired.c (compile_pattern): Move decl from here ...
13038 * lisp.h: ... to here, so that it can be checked.
13039 (struct re_registers): New forward decl.
13040
7e47afad
PE
13041 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13042
85f24f61
PE
13043 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13044 All uses changed.
13045 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13046 Rename locals to avoid shadowing.
5671df8f 13047 (Fvertical_motion): Mark locals as initialized.
85f24f61 13048
181aa2be 13049 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13050 (casify_region): Mark local as initialized.
181aa2be 13051
930d429c
PE
13052 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13053
7082eac6
PE
13054 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13055 New macros, so that the caller can use some names other than
13056 gcpro1, gcpro2, etc.
13057 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13058 of the new macros.
13059 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13060 argument, for consistency with GCPRO2_VAR, etc: it is now the
13061 prefix of the variable, not the variable itself. All uses
13062 changed.
38b2c076
PE
13063 * dired.c (directory_files_internal, file_name_completion):
13064 Rename locals to avoid shadowing.
13065
15206ed9
PE
13066 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13067 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13068 dired.c's scmp function, had undefined behavior.
13069 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13070 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13071 * buffer.h: ... to here, because these macros use current_buffer,
13072 and the new implementation with inline functions needs to have
13073 current_buffer in scope now, rather than later when the macros
13074 are used.
13075 (downcase, upcase1): New static inline functions.
13076 (DOWNCASE, UPCASE1): Reimplement using these functions.
13077 This avoids undefined behavior in expressions like
13078 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13079 from race conditions in accessing the global variables
13080 case_temp1 and case_temp2.
13081 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13082 * lisp.h (case_temp1, case_temp2): Remove their decls.
13083 * character.h (ASCII_CHAR_P): Move from here ...
13084 * lisp.h: ... to here, so that the inline functions mentioned
13085 above can use them.
13086
4a6bea26
PE
13087 * dired.c (directory_files_internal_unwind): Now static.
13088
f14b7e14
PE
13089 * fileio.c (file_name_as_directory, directory_file_name):
13090 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13091 Now static.
2893f146
PE
13092 (file_name_as_directory): Use const pointers when appropriate.
13093 (Fexpand_file_name): Likewise. In particular, newdir might
13094 point at constant storage, so make it a const pointer.
fd4ead52 13095 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13096 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13097 signedness issues.
f839df0c
PE
13098 (Fset_file_times, Finsert_file_contents, auto_save_error):
13099 Rename locals to avoid shadowing.
f14b7e14 13100
5716756e 13101 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13102 (Ftry_completion, Fall_completions): Rename or remove locals
13103 to avoid shadowing.
5716756e 13104
b4c3046a
PE
13105 * marker.c (bytepos_to_charpos): Remove; unused.
13106
b45db522
PE
13107 * lisp.h (verify_bytepos, count_markers): New decls,
13108 so that gcc does not warn that these functions aren't declared.
13109
85876d07
PE
13110 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13111 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13112 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13113 (copy_text): Remove unused local var.
85876d07 13114
03d78a21 13115 * filelock.c (within_one_second): Now static.
b3dd38ab 13116 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13117
5df8f01b
PE
13118 * buffer.c (fix_overlays_before): Mark locals as initialized.
13119 (fix_start_end_in_overlays): Likewise. This function should be
13120 simplified by using pointers-to-pointers, but that's a different
13121 matter.
b1d876f1 13122 (switch_to_buffer_1): Now static.
8f54f30a
PE
13123 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13124 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13125
a70072c9 13126 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13127 Fix pointer signedness issue.
edced198
PE
13128 (sys_subshell): Mark local as volatile if checking for lint,
13129 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13130 (MAXPATHLEN): Define only if needed.
a70072c9 13131
a0977c44
PE
13132 * process.c (serial_open, serial_configure): Move decls from here ...
13133 * systty.h: ... to here, so that they can be checked.
13134
a884fdcc
PE
13135 * fns.c (get_random, seed_random): Move extern decls from here ...
13136 * lisp.h: ... to here, so that they can be checked.
13137
604efe86 13138 * sysdep.c (reset_io): Now static.
b8950c94 13139 (wait_for_termination_signal): Remove; unused.
604efe86 13140
38fc62d9
PE
13141 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13142 (copy_keymap_item, append_key, push_text_char_description):
13143 Now static.
1004a21a 13144 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13145 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13146 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13147 (describe_map_tree):
13148 Rename locals to avoid shadowing.
38fc62d9 13149
2f2650da
PE
13150 * keyboard.c: Declare functions static if they are not used elsewhere.
13151 (echo_char, echo_dash, cmd_error, top_level_2):
13152 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13153 (read_char, kbd_buffer_get_event, make_lispy_position):
13154 (make_lispy_event, make_lispy_movement, apply_modifiers):
13155 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13156 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13157 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13158 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13159 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13160
a053e86c 13161 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13162 (mark_kboards): Move decl here ...
13163 * alloc.c (mark_kboards): ... from here.
a053e86c 13164
4752793e
PE
13165 * lisp.h (force_auto_save_soon): New decl.
13166
74f10ca7 13167 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13168 (DEFINE_DUMMY_FUNCTION): New macro.
13169 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13170 Use it.
c03cd23f
PE
13171 (main): Add casts to avoid warnings
13172 if GCC considers string literals to be constants.
74f10ca7 13173
022e70d4
PE
13174 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13175
59d6fe83
PE
13176 * dbusbind.c: Pointer signedness fixes.
13177 (xd_signature, xd_append_arg, xd_initialize):
13178 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13179 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13180 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13181 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13182
78320123
PE
13183 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13184 if GCC considers string literals to be constants.
49cebcca 13185 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13186
35ac2a97
SM
131872011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13188
fb103ca9
SM
13189 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13190 (print_preprocess, print_object): New macro to fix last change.
13191
35ac2a97
SM
13192 * print.c (print_preprocess): Don't forget font objects.
13193
62973b41
JB
131942011-03-16 Juanma Barranquero <lekktu@gmail.com>
13195
13196 * emacs.c (USAGE3): Doc fixes.
13197
0e48bb22
AS
131982011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13199
13200 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13201 structure.
13202
7684e57b
JB
132032011-03-14 Juanma Barranquero <lekktu@gmail.com>
13204
13205 * lisp.h (VWindow_system, Qfile_name_history):
13206 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13207 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13208 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13209
13210 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13211 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13212
13213 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13214 * w32console.c (detect_input_pending, read_input_pending)
13215 (encode_terminal_code):
13216 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13217 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13218 (w32_system_caret_y, Qfile_name_history):
13219 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13220 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13221 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13222 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13223 * w32proc.c (Qlocal, report_file_error):
13224 * w32term.c (Vwindow_system, updating_frame):
13225 * w32uniscribe.c (initialized, uniscribe_font_driver):
13226 Remove unneeded extern declarations.
13227
2aa46d6c
CY
132282011-03-14 Chong Yidong <cyd@stupidchicken.com>
13229
c96bbc66 13230 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13231
cffc6f3b
CY
132322011-03-13 Chong Yidong <cyd@stupidchicken.com>
13233
13234 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13235 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13236 These macros can no longer be used for assignment.
13237
44f230aa
SM
13238 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13239 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13240 (record_buffer_markers, fetch_buffer_markers): New functions for
13241 recording and fetching special buffer markers.
13242 (set_buffer_internal_1, set_buffer_temp): Use them.
13243
13244 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13245
13246 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13247
13248 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13249 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13250
13251 * xdisp.c (hscroll_window_tree):
13252 (reconsider_clip_changes): Use PT instead of BUF_PT.
13253
d251f04b
EZ
132542011-03-13 Eli Zaretskii <eliz@gnu.org>
13255
13256 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13257 $(EMACS_ROOT)/lib/intprops.h.
13258
f0c77cd1
PE
132592011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13260
3eca4629
PE
13261 Fix more problems found by GCC 4.5.2's static checks.
13262
7c86ee98
PE
13263 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13264 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13265 (xg_free_frame_widgets): Make it clear that a local variable is
13266 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13267 (gdk_window_get_screen): Make it clear that this macro is needed
13268 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13269 (int_gtk_range_get_value): New function, which avoids a diagnostic
13270 from gcc -Wbad-function-cast.
13271 (xg_set_toolkit_scroll_bar_thumb): Use it.
13272 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13273 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13274 (get_utf8_string, xg_get_file_with_chooser):
13275 Rename locals to avoid shadowing.
13276 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13277
41729b81
PE
13278 * xgselect.c (xg_select): Remove unused var.
13279
f0c77cd1
PE
13280 * image.c (four_corners_best): Mark locals as initialized.
13281 (gif_load): Initialize transparent_p to zero (Bug#8238).
13282 Mark another local as initialized.
ec6cf4c6 13283 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13284
ce0ad53d 13285 * image.c (clear_image_cache): Now static.
d5d5a617 13286 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13287 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13288 (x_edge_detection): Remove unnecessary cast that
13289 gcc -Wbad-function-cast diagnoses.
2037898d 13290 (gif_load): Fix pointer signedness.
6ae141d6
PE
13291 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13292 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13293
33383987 132942011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13295
d32df629
PE
13296 Improve quality of tests for time stamp overflow.
13297 For example, without this patch (encode-time 0 0 0 1 1
13298 1152921504606846976) returns the obviously-bogus value (-948597
13299 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13300 reports time overflow. See
13301 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13302 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13303 * editfns.c: Include limits.h and intprops.h.
13304 (TIME_T_MIN, TIME_T_MAX): New macros.
13305 (time_overflow): Move earlier, to before first use.
13306 (hi_time, lo_time): New functions, for an accurate test for
13307 out-of-range times.
13308 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13309 (Fget_internal_run_time): Don't assume time_t fits in int.
13310 (make_time): Use list2 instead of Fcons twice.
13311 (Fdecode_time): More accurate test for out-of-range times.
13312 (check_tm_member): New function.
13313 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13314 (lisp_time_argument): Don't rely on undefined left-shift and
13315 right-shift behavior when checking for time stamp overflow.
8be6f318 13316
fe31d94c
PE
13317 * editfns.c (time_overflow): New function, refactoring common code.
13318 (Fformat_time_string, Fdecode_time, Fencode_time):
13319 (Fcurrent_time_string): Use it.
13320
8be6f318
PE
13321 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13322 * dired.c (make_time): Move to ...
13323 * editfns.c (make_time): ... here.
13324 * systime.h: Note the move.
13325
09d9db2c 133262011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13327
126bc0dc
YM
13328 * fringe.c (update_window_fringes): Remove unused variables.
13329
c47cbdfd
YM
13330 * unexmacosx.c (copy_data_segment): Also copy __got section.
13331 (Bug#8223)
13332
7ac80be9
EZ
133332011-03-12 Eli Zaretskii <eliz@gnu.org>
13334
c96bbc66 13335 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13336 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13337 Constify `char *' arguments and their references according to
13338 prototypes in tparam.h.
13339
ecb0f94d 13340 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13341
7ac80be9
EZ
13342 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13343 Adapt all references accordingly.
13344
13345 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13346
ef1fd07e
TT
133472011-03-11 Tom Tromey <tromey@redhat.com>
13348
13349 * buffer.c (syms_of_buffer): Remove obsolete comment.
13350
7ef4b50c
EZ
133512011-03-11 Eli Zaretskii <eliz@gnu.org>
13352
13353 * termhooks.h (encode_terminal_code): Declare prototype.
13354
13355 * msdos.c (encode_terminal_code): Don't declare prototype.
13356
13357 * term.c (encode_terminal_code): Now external again, used by
13358 w32console.c and msdos.c.
13359
44f230aa
SM
13360 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13361 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13362
4b1ec863 133632011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13364
1714f52b 13365 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13366
4b1ec863
PE
13367 * fringe.c (update_window_fringes): Mark locals as initialized
13368 (Bug#8227).
13369 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13370
524c7aa6
PE
13371 * alloc.c (mark_fringe_data): Move decl from here ...
13372 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13373 to check its interface.
13374 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13375
a5c0af81 13376 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13377 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13378 (fontset_font): Mark local as initialized.
a9a06e0b 13379 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13380
b4716021
PE
13381 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13382
811e9bac 13383 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13384 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13385 (x_own_selection, Fx_disown_selection_internal): Rename locals
13386 to avoid shadowing.
13387 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13388
7e3ab302
PE
13389 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13390 so that the caller can use some name other than gcpro1.
13391 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13392 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13393 (Fx_backspace_delete_keys_p):
13394 Use them to avoid shadowing, and rename vars to avoid shadowing.
13395 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13396 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13397 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13398 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13399 Remove unused locals.
7e3ab302
PE
13400 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13401 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13402 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13403 macros.
f78faa98 13404
e2b13473
PE
13405 * xterm.h (x_mouse_leave): New decl.
13406
77f23912
PE
13407 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13408 Remove unused functions.
cdf4ba58
PE
13409 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13410 (x_calc_absolute_position): Now static.
7411c686 13411 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13412 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13413 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13414 unless they are used.
38d0b34a
PE
13415 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13416 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13417 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13418 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13419 (x_error_catcher, x_connection_closed, x_error_handler):
13420 (x_error_quitter, xembed_send_message, x_iconify_frame):
13421 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13422 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13423 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13424
44f230aa
SM
13425 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13426 Rename or move locals to avoid shadowing.
6b463e58 13427 (tty_defined_color, merge_face_heights): Now static.
5967d051 13428 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13429 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13430 does not deduce is never used uninitialized.
73719eba
PE
13431 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13432 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13433
426994c3 13434 * terminal.c (store_terminal_param): Now static.
5489860b 13435
032f1620 13436 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13437 (set_frame_menubar): Remove unused local.
d4323972 13438 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13439 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13440 since they might point to immutable storage.
281585b0
PE
13441 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13442 since it's unused otherwise.
032f1620 13443
367c19e5 13444 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13445 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13446 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13447 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13448 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13449 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13450 does not deduce are never used uninitialized.
70739cbe 13451
07b48fa9
PE
13452 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13453
8868a238 13454 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13455 * window.c (window_loop, size_window):
13456 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13457
7e5cf297 13458 * window.c (display_buffer): Now static.
d6550a9f
PE
13459 (size_window): Mark variables that gcc -Wuninitialized
13460 does not deduce are never used uninitialized.
a586633d
PE
13461 * window.h (check_all_windows): New decl, to forestall
13462 gcc -Wmissing-prototypes diagnostic.
5b555da1 13463 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13464
f6095868
PE
13465 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13466 shadowing.
13467 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13468 Include <limits.h>.
13469 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13470 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13471 (load_charset_map): Mark variables that gcc -Wuninitialized
13472 does not deduce are never used uninitialized.
53df7c11 13473 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13474
f38b440c
PE
13475 * coding.c (coding_set_source, coding_set_destination):
13476 Use "else { /* comment */ }" rather than "else /* comment */;"
13477 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13478 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13479 a block, when the outer 'i' will do.
13480 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13481 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13482 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13483 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13484 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13485 Rename locals to avoid shadowing.
13486 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13487 * coding.c (emacs_mule_char, encode_invocation_designation):
13488 Now static, since they're not used elsewhere.
413bb2db 13489 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13490 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13491 (decode_coding_emacs_mule): Mark variables that gcc
13492 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13493 (detect_coding_iso_2022): Initialize a local variable that might
13494 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13495 this initialization is needed. (Bug#8211)
5f58e762
PE
13496 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13497 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13498 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13499 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13500 Remove unused macros.
f38b440c 13501
232b38b9 13502 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13503 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13504 * character.c (string_count_byte8): Likewise.
232b38b9 13505
fb90da1b
PE
13506 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13507 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13508
fb93dbc2
PE
13509 * chartab.c (copy_sub_char_table): Now static, since it's not used
13510 elsewhere.
5c156ace
PE
13511 (sub_char_table_ref_and_range, char_table_ref_and_range):
13512 Rename locals to avoid shadowing.
bbcd0949 13513 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13514
7d3b3862 13515 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13516 (BIDI_BOB): Remove unused macro.
7d3b3862 13517
6be7d3da
PE
13518 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13519 deduce are never used uninitialized.
c2ed9c8b 13520 * term.c (encode_terminal_code): Likewise.
6be7d3da 13521
75f8807f 13522 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13523
50938595
PE
13524 * tparam.h: New file.
13525 * term.c, tparam.h: Include it.
13526 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13527 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13528 Move these decls to tparam.h, and make them agree with what
13529 is actually in tparam.c. The previous trick of using incompatible
13530 decls in different modules does not conform to the C standard.
13531 All callers of tparam changed to use tparam's actual API.
13532 * tparam.c (tparam1, tparam, tgoto):
13533 Use const pointers where appropriate.
13534
fbceeba2
PE
13535 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13536 * cm.h (struct cm): Likewise.
13537 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13538 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13539 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13540 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13541 (turn_on_face, init_tty): Likewise.
13542 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13543
7f3f1250
PE
13544 * term.c (term_mouse_position): Rename local to avoid shadowing.
13545
e6ca6543
PE
13546 * alloc.c (mark_ttys): Move decl from here ...
13547 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13548
c40f8d15
AS
135492011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13550
13551 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13552
cfe0661d
JB
135532011-03-09 Juanma Barranquero <lekktu@gmail.com>
13554
13555 * search.c (compile_pattern_1): Remove argument regp, unused since
13556 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13557 (compile_pattern): Don't pass it.
13558
0afb4571
J
135592011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13560
13561 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13562 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13563 for ! HAVE_GTK3.
13564 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13565
13566 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13567
13568 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13569 gdk_window_get_screen, gdk_window_get_geometry,
13570 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13571 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13572 (xg_get_pixbuf_from_pixmap): New function.
13573 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13574 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13575 Call xg_get_pixbuf_from_pixmap instead of
13576 gdk_pixbuf_get_from_drawable.
13577 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13578 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13579 (xg_check_special_colors): Use GtkStyleContext and its functions
13580 for HAVE_GTK3.
13581 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13582 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13583 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13584 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13585 Call gtk_widget_get_preferred_size.
0afb4571
J
13586 (xg_frame_resized): gdk_window_get_geometry only takes 5
13587 parameters.
44f230aa
SM
13588 (xg_win_to_widget, xg_event_is_for_menubar):
13589 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13590 (xg_set_widget_bg): New function.
13591 (delete_cb): New function.
895009e1 13592 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13593 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13594 (xg_set_background_color): Call xg_set_widget_bg.
13595 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13596 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13597 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13598 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13599 if ! HAVE_GTK3.
13600 (update_frame_tool_bar): Call gtk_widget_hide.
13601 (xg_initialize): Use GDK_KEY_g.
13602
13603 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13604 if ! HAVE_GTK3
13605 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13606
13607 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13608 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13609 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13610
1c2cc4ef
JB
136112011-03-08 Juanma Barranquero <lekktu@gmail.com>
13612
13613 * w32xfns.c (select_palette): Check success of RealizePalette against
13614 GDI_ERROR, not zero.
13615
33383987 13616See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13617
13618;; Local Variables:
13619;; coding: utf-8
aac0c6e3
MR
13620;; End:
13621
2f097256 13622 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13623
13624 This file is part of GNU Emacs.
13625
13626 GNU Emacs is free software: you can redistribute it and/or modify
13627 it under the terms of the GNU General Public License as published by
13628 the Free Software Foundation, either version 3 of the License, or
13629 (at your option) any later version.
13630
13631 GNU Emacs is distributed in the hope that it will be useful,
13632 but WITHOUT ANY WARRANTY; without even the implied warranty of
13633 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13634 GNU General Public License for more details.
13635
13636 You should have received a copy of the GNU General Public License
13637 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.