Build test-distrib on MS-Windows and run it during the build.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3811fdf3
EZ
12012-04-07 Eli Zaretskii <eliz@gnu.org>
2
3 * indent.c (Fvertical_motion): If there is a display string at
4 point, use it.vpos to compute how many lines to backtrack after
5 move_it_to point. (Bug#11133)
6
2f8e16b2
EZ
72012-04-06 Eli Zaretskii <eliz@gnu.org>
8
9 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
10 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
11 about subtle differences between FETCH_CHAR* and STRING_CHAR*
12 macros related to unification of CJK characters. For the details,
13 see the discussion following the message here:
14 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
15
3d439cd1
CY
162012-04-04 Chong Yidong <cyd@gnu.org>
17
18 * keyboard.c (Vdelayed_warnings_list): Doc fix.
19
8bc53d00
EZ
202012-04-01 Eli Zaretskii <eliz@gnu.org>
21
22 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
23 instead of alloca. (Bug#11138)
24
3b0512a3
AS
252012-04-01 Andreas Schwab <schwab@linux-m68k.org>
26
27 * w32menu.c (is_simple_dialog): Properly check lisp types.
28 (Bug#11141)
29
8427ddd2
EZ
302012-03-31 Eli Zaretskii <eliz@gnu.org>
31
979022ef
EZ
32 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
33 position we get to after a call to move_it_to fails the
34 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
35 only if we wind up in a string from display property. (Bug#11063)
36
a6b1c7cc
EZ
37 * window.c (Fdelete_other_windows_internal): Invalidate the row
38 and column information about mouse highlight, so that redisplay
39 restores it after reallocating the glyph matrices. (Bug#7464)
40
8427ddd2
EZ
41 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
42 string comes from a `display' text property, use the buffer
43 position of that property as if we actually saw that position in
44 the row's glyphs.
697ba24b
EZ
45 (move_it_by_lines): Remove the assertion that
46 "it->current_x == 0 && it->hpos == 0" which can be legitimately
47 violated when there's a before-string at the beginning of a line.
48 (Bug#11063)
8427ddd2 49
65a0a738
EZ
502012-03-30 Eli Zaretskii <eliz@gnu.org>
51
52 * xdisp.c (append_space_for_newline): If the default face was
53 remapped, use the remapped face for the appended newline.
54 (extend_face_to_end_of_line): Use the remapped default face for
55 extending the face to the end of the line.
56 (display_line): Call extend_face_to_end_of_line when the default
57 face was remapped. (Bug#11068)
58
581355cc
EZ
592012-03-29 Eli Zaretskii <eliz@gnu.org>
60
61 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
62
e8fc049f
SM
632012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
64
65 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
66
4fb9a543
GM
672012-03-27 Glenn Morris <rgm@gnu.org>
68
69 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
70 Doc fixes.
71
679910f1
KH
722012-03-26 Kenichi Handa <handa@m17n.org>
73
74 * dispextern.h (struct glyph): Fix previous change. Change the
75 bit length of glyphless.ch to 25 (Bug#11082).
76
90d49b7f
CY
772012-03-26 Chong Yidong <cyd@gnu.org>
78
79 * keyboard.c (Vselection_inhibit_update_commands): New variable.
80 (command_loop_1): Use it; inhibit selection update for
81 handle-select-window too (Bug#8996).
82
f514f6f0
FP
832012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
84
e8fc049f 85 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 86
bf43fa51
KH
872012-03-25 Kenichi Handa <handa@m17n.org>
88
89 * dispextern.h (struct glyph): Change the bit length of
90 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
91
8a0c01dd
EZ
922012-03-24 Eli Zaretskii <eliz@gnu.org>
93
94 * s/ms-w32.h (tzname): Include time.h before redirecting to
95 _tzname. Fixes the MSVC build. (Bug#9960)
96
7d1c3a76
AS
972012-03-24 Andreas Schwab <schwab@linux-m68k.org>
98
8ed79523
AS
99 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
100 characters.
101
7d1c3a76
AS
102 * xterm.c (XTread_socket): Only modify handling_signal if
103 !SYNC_INPUT. (Bug#11080)
104
e99a9b8b
EZ
1052012-03-23 Eli Zaretskii <eliz@gnu.org>
106
107 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
108 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
109 when fetching a multibyte character consumes more bytes than
110 CHAR_BYTES returns, due to unification of CJK characters in
111 string_char. (Bug#11073)
112
5063c0e1
TN
1132012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
114
115 * process.c (wait_reading_process_output): Handle pty disconnect
116 by refraining from sending oneself a SIGCHLD (bug#10933).
117
9f851fbd
CY
1182012-03-22 Chong Yidong <cyd@gnu.org>
119
120 * dispextern.h (struct it): New member string_from_prefix_prop_p.
121
5063c0e1 122 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
123 Mark string as coming from a prefix property.
124 (handle_face_prop): Use default face for prefix strings (Bug#4281).
125 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
126
fb5b8aca
CY
1272012-03-21 Chong Yidong <cyd@gnu.org>
128
129 * xfaces.c (Vface_remapping_alist): Doc fix.
130
62356a1b
EZ
1312012-03-20 Eli Zaretskii <eliz@gnu.org>
132
133 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
134 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
135 Doc fixes.
62356a1b 136
025de85b
CY
1372012-03-20 Chong Yidong <cyd@gnu.org>
138
139 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
140 to reflect default non-nil value of redisplay-dont-pause.
141
4827f94e
KH
1422012-03-19 Kenichi Handa <handa@m17n.org>
143
144 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
145 it fit in a valid range (Bug#11003).
146
e50a24a2
EZ
1472012-03-18 Eli Zaretskii <eliz@gnu.org>
148
149 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
150 that is not from display property, accept the row as a "cursor
151 row" if one of the string's character has a non-nil `cursor'
152 property. Fixes cursor positioning when there are newlines in
153 overlay strings, e.g. in icomplete.el. (Bug#11035)
154
9af5ed87
PE
1552012-03-12 Paul Eggert <eggert@cs.ucla.edu>
156
157 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
158
d1f55f16
CY
1592012-03-12 Chong Yidong <cyd@gnu.org>
160
161 * eval.c (inhibit_lisp_code): Rename from
162 inhibit_window_configuration_change_hook; move from window.c.
163
164 * xfns.c (unwind_create_frame_1, Fx_create_frame):
165 * window.c (run_window_configuration_change_hook)
166 (syms_of_window): Callers changed.
167
66c5eebd
CY
1682012-03-11 Chong Yidong <cyd@gnu.org>
169
413df973
CY
170 * keymap.c (Fkey_description): Doc fix (Bug#9700).
171
66c5eebd
CY
172 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
173
1de11f56
CY
1742012-03-10 Chong Yidong <cyd@gnu.org>
175
176 * frame.c (other_visible_frames): Don't assume the selected frame
177 is visible (Bug#10955).
178
cae07000
SM
1792012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
180
181 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
182
89c94350
JD
1832012-03-08 Jan Djärv <jan.h.d@swipnet.se>
184
185 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
186 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
187 zero (Bug#10954).
188
999dd333
GM
1892012-03-03 Glenn Morris <rgm@gnu.org>
190
01a6dcc8 191 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 192
de0100f2
EZ
1932012-03-02 Eli Zaretskii <eliz@gnu.org>
194
195 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
196 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
197 (redisplay_window, next_element_from_string): Fix typos in
198 comments.
3e441275
EZ
199 (redisplay_window): Pass to move_it_vertically the margin in
200 pixels, not in screen lines.
de0100f2 201
96a72ee9
GM
2022012-03-02 Glenn Morris <rgm@gnu.org>
203
204 * buffer.c (buffer-list-update-hook): Doc fix.
205
312508d7
EZ
2062012-02-29 Eli Zaretskii <eliz@gnu.org>
207
208 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
209 push_it before setting up the iterator for the first overlay
210 string, even if we have an empty string loaded.
211 (next_overlay_string): If there's an empty string on the iterator
212 stack, pop the stack. (Bug#10903)
213
27f3c637
PE
2142012-02-25 Paul Eggert <eggert@cs.ucla.edu>
215
216 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
217 Suggested by Stefan Monnier in
218 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
219 * alloc.c (widen_to_Lisp_Object): New static function.
220 (mark_memory): Also mark Lisp_Objects by fetching pointer words
221 and widening them to Lisp_Objects. This would work even if
222 USE_LSB_TAG is defined and wide integers are used, which might
223 happen in a future version of Emacs.
224
3c9dfce6
CY
2252012-02-25 Chong Yidong <cyd@gnu.org>
226
fa74b241
CY
227 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
228 Doc fix.
229
3c9dfce6
CY
230 * xselect.c (Fx_selection_exists_p): Doc fix.
231 (x_clipboard_manager_save_all): Print an informative message
232 before saving to clipboard manager.
233
9486df08
CY
2342012-02-24 Chong Yidong <cyd@gnu.org>
235
236 * keyboard.c (process_special_events): Handle all X selection
237 requests in kbd_buffer, not just the next one (Bug#8869).
238
f01d3321
CY
2392012-02-23 Chong Yidong <cyd@gnu.org>
240
241 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
242 call when setting menu-bar-lines and tool-bar-lines parameters.
243 (unwind_create_frame_1): New helper function.
244
245 * window.c (inhibit_window_configuration_change_hook): New var.
246 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 247 (syms_of_window): Initialize it.
f01d3321 248
86b847b6
CY
2492012-02-22 Chong Yidong <cyd@gnu.org>
250
251 * xterm.c (x_draw_image_relief): Add missing type check for
252 Vtool_bar_button_margin (Bug#10743).
253
a59225b1
CY
2542012-02-21 Chong Yidong <cyd@gnu.org>
255
256 * fileio.c (Vfile_name_handler_alist): Doc fix.
257
258 * buffer.c (Fget_file_buffer): Protect against invalid file
259 handler return value.
260
310f5bd4
PE
2612012-02-20 Paul Eggert <eggert@cs.ucla.edu>
262
cb3a28cc
PE
263 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
264 when computing $valmask.
265
310f5bd4
PE
266 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
267 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
268 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
269 It's useless in that case, and it can cause problems on hosts
270 that allocate halves of EMACS_INT values separately.
271 Reported by Dan Horák. Diagnosed by Andreas Schwab in
272 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
273 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
274 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
275 it avoids undefined behavior on hosts where shifting right by more
276 than the word width has undefined behavior.
277
2375c96a
CY
2782012-02-19 Chong Yidong <cyd@gnu.org>
279
280 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
281 (Funhandled_file_name_directory, Ffile_name_as_directory)
282 (Fdirectory_file_name, Fexpand_file_name)
283 (Fsubstitute_in_file_name): Protect against invalid file handler
284 return values (Bug#10845).
285
3eb49e71
EZ
2862012-02-18 Eli Zaretskii <eliz@gnu.org>
287
288 * .gdbinit (pitx): Fix incorrect references to fields of the
289 iterator stack.
290
7b926f3f
CY
2912012-02-17 Chong Yidong <cyd@gnu.org>
292
293 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
294
11273115
PE
2952012-02-15 Paul Eggert <eggert@cs.ucla.edu>
296
297 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
298 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
299
c3a70e2b
CY
3002012-02-15 Chong Yidong <cyd@gnu.org>
301
302 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
303 marked as special. Also, starting docstrings with * is obsolete.
304
0ca43699
AS
3052012-02-13 Andreas Schwab <schwab@linux-m68k.org>
306
307 * gnutls.c (emacs_gnutls_write): Fix last change.
308
2e8f3c56
LI
3092012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
310
311 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
312 send_process.
313
af70074f
SM
3142012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
315
316 * keymap.c (Fsingle_key_description): Handle char ranges.
317
95986d52
CY
3182012-02-12 Chong Yidong <cyd@gnu.org>
319
afd83bd1
CY
320 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
321 as that creates a dangerous corner case.
322
95986d52
CY
323 * window.c (Fdelete_window_internal): Invalidate the mouse
324 highlight (Bug#9904).
325
bd7da63e
GM
3262012-02-12 Glenn Morris <rgm@gnu.org>
327
328 * xselect.c (Fx_own_selection_internal)
329 (Fx_get_selection_internal, Fx_disown_selection_internal)
330 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
331 * nsselect.m (Fx_own_selection_internal)
332 (Fx_disown_selection_internal, Fx_selection_exists_p)
333 (Fx_selection_owner_p, Fx_get_selection_internal):
334 Sync docs and argument specs with the xselect.c versions.
335
77abcbc2
LI
3362012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
337
338 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
339
90b671e2
EZ
3402012-02-11 Eli Zaretskii <eliz@gnu.org>
341
1c0ca0b7
EZ
342 * w32select.c (Fx_selection_exists_p): Sync doc string and
343 argument list with xselect.c. (Bug#10783)
344
345 * w16select.c (Fx_selection_exists_p): Sync doc string and
346 argument list with xselect.c. (Bug#10783)
90b671e2 347
49241268
GM
3482012-02-10 Glenn Morris <rgm@gnu.org>
349
350 * fns.c (Fsecure_hash): Doc fix.
351
f998bbe7 3522012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
353
354 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
355
0992bd9c
CY
3562012-02-07 Chong Yidong <cyd@gnu.org>
357
358 * buffer.c (Fbuffer_local_variables)
359 (buffer_lisp_local_variables): Handle unbound vars correctly;
360 don't let Qunbound leak into Lisp.
361
af008560
GM
3622012-02-07 Glenn Morris <rgm@gnu.org>
363
dd605cc4
GM
364 * image.c (Fimagemagick_types): Doc fix.
365
af008560
GM
366 * image.c (imagemagick-render-type): Change it from a lisp object
367 to an integer. Move the doc here from the lisp manual.
368 Treat all values not equal to 0 the same.
369
1449fa1d
CY
3702012-02-06 Chong Yidong <cyd@gnu.org>
371
372 * doc.c (store_function_docstring): Avoid applying docstring of
373 alias to base function (Bug#2603).
374
3723ec07
AS
3752012-02-04 Andreas Schwab <schwab@linux-m68k.org>
376
377 * .gdbinit (pp1, pv1): Remove redundant defines.
378 (pr): Use pp.
379
79c1cc1e
CY
3802012-02-04 Chong Yidong <cyd@gnu.org>
381
382 * nsterm.m: Declare a global (Bug#10694).
383
d7f29f8e
EZ
3842012-02-04 Eli Zaretskii <eliz@gnu.org>
385
cae07000
SM
386 * w32.c (get_emacs_configuration_options):
387 Include --enable-checking, if specified, in the return value.
d7f29f8e 388
3b95a6f9
MR
3892012-02-04 Martin Rudalics <rudalics@gmx.at>
390
391 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
392 after rounding frame sizes. (Bug#9723)
393
d6fa96a6
EZ
3942012-02-04 Eli Zaretskii <eliz@gnu.org>
395
396 * keyboard.c (adjust_point_for_property): Don't position point
397 before BEGV. (Bug#10696)
398
df0b2940
PE
3992012-02-03 Paul Eggert <eggert@cs.ucla.edu>
400
401 Handle overflow when computing char display width (Bug#9496).
402 * character.c (char_width): Return EMACS_INT, not int.
403 (char_width, c_string_width): Check for overflow when
404 computing the width; this is possible now that individual
405 characters can have unbounded width. Problem introduced
406 by merge from Emacs 23 on 2012-01-19.
407
6bee44d6
MA
4082012-02-02 Michael Albinus <michael.albinus@gmx.de>
409
410 * dbusbind.c (Fdbus_register_method): Mention the return value
411 :ignore in the docstring.
412
44f92739
GM
4132012-02-02 Glenn Morris <rgm@gnu.org>
414
1b9f60cc
GM
415 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
416
44f92739
GM
417 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
418 Unconditionally set to t. (Bug#10673)
419 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
420 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
421 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
422
c5d3843c
KH
4232012-02-02 Kenichi Handa <handa@m17n.org>
424
425 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
426 0, do not call append_composite_glyph.
427
159462d4 4282012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
429
430 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
431 NULL (Bug#6988).
432 (x_produce_glyphs): If the component of a composition is a null
433 string, set it->pixel_width to 1 to avoid zero-width glyph.
434
78cef877
EZ
4352012-02-01 Eli Zaretskii <eliz@gnu.org>
436
437 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
438 first 2 arguments are identical. This makes inserting large
439 output from a subprocess an order of magnitude faster on
440 MS-Windows, where all sbrk'ed memory is always contiguous.
441
97897668
GM
4422012-01-31 Glenn Morris <rgm@gnu.org>
443
444 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 445 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
446 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
447
31fd3586
GM
4482012-01-29 Glenn Morris <rgm@gnu.org>
449
450 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
451
0e24a8b2
CY
4522012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
453
454 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
455
cc0adcb0
CY
4562012-01-28 Chong Yidong <cyd@gnu.org>
457
458 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
459
acc28cb9
CY
4602012-01-26 Chong Yidong <cyd@gnu.org>
461
9c69cfb7
CY
462 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
463
acc28cb9
CY
464 * search.c (Fsearch_forward, Fsearch_backward): Document negative
465 repeat counts (Bug#10507).
466
48da7392
GM
4672012-01-26 Glenn Morris <rgm@gnu.org>
468
469 * lread.c (syms_of_lread): Doc fix.
470
14af5f7f
CY
4712012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
472
473 * coding.c (encode_designation_at_bol): Change return value to
474 EMACS_INT.
475
0b21c100
CY
4762012-01-25 Chong Yidong <cyd@gnu.org>
477
478 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
479
3c2907f7
CY
4802012-01-21 Chong Yidong <cyd@gnu.org>
481
482 * floatfns.c (Fcopysign): Make the second argument non-optional,
483 since nil is not allowed anyway.
484
959ad23f
AS
4852012-01-21 Andreas Schwab <schwab@linux-m68k.org>
486
487 * process.c (read_process_output): Use p instead of XPROCESS (proc).
488 (send_process): Likewise.
489
34a02f46
MR
4902012-01-19 Martin Rudalics <rudalics@gmx.at>
491
492 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
493 (Vwindow_persistent_parameters): Do not use Qstate.
494 Rewrite doc-strings.
34a02f46 495
1259009a 4962012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
497
498 * character.c (char_width): New function.
70d4fdf6
GM
499 (Fchar_width, c_string_width, lisp_string_width):
500 Use char_width (Bug#9496).
25ed9e61 501
6a6ee00d
MR
5022012-01-16 Martin Rudalics <rudalics@gmx.at>
503
504 * window.c (Vwindow_persistent_parameters): New variable.
505 (Fset_window_configuration, save_window_save): Handle persistent
506 window parameters.
507
c85efaf7
EZ
5082012-01-14 Eli Zaretskii <eliz@gnu.org>
509
510 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
511 thrashing the stack of the thread. (Bug#9087)
512
5944709e
PE
5132012-01-12 Paul Eggert <eggert@cs.ucla.edu>
514
515 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
516
e71f5d99
EZ
5172012-01-11 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (rows_from_pos_range): Handle the case where the
520 highlight ends on a newline. (Bug#10464)
521 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
522 he end column for display of highlight that ends on a newline
523 before a R2L line.
524
ce316182
GM
5252012-01-11 Glenn Morris <rgm@gnu.org>
526
527 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
528 from load-path also when installation-directory is nil. (Bug#10208)
529
5b43da69
GM
5302012-01-10 Glenn Morris <rgm@gnu.org>
531
74cc8ff9
GM
532 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
533
7d8d6e4e
GM
534 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
535 Update template values to be closer to their typical values these days.
5b43da69 536
a0db8d43
EZ
5372012-01-09 Eli Zaretskii <eliz@gnu.org>
538
539 * xdisp.c (rows_from_pos_range): Accept additional argument
540 DISP_STRING, and accept any glyph in a row whose object is that
541 string as eligible for mouse highlight. Fixes mouse highlight of
542 display strings from overlays. (Bug#10464)
543
9a0115ab 5442012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 545
b9110d6a 546 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
547 * fileio.c (auto_saving_dir_umask): New static var.
548 (Fmake_directory_internal): Use it.
549 (do_auto_save_make_dir): Set it, instead of invoking chmod after
550 creating the directory. The old code temporarily assigns
551 too-generous permissions to the directory.
552 (do_auto_save_eh): Clear it.
b9110d6a 553 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
554 that the var is always cleared.
555
6c1bd3f3
EZ
5562012-01-07 Eli Zaretskii <eliz@gnu.org>
557
558 * search.c (scan_buffer): Pass character positions to
559 know_region_cache, not byte positions. (Bug#6540)
560
069d2b50
L
5612012-01-07 LynX <_LynX@bk.ru> (tiny change)
562
563 * w32.c (sys_rename): Report EXDEV when rename of a directory
564 fails because the target is on another logical disk. (Bug#10284)
565
75bf0d33
DB
5662012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
567
568 * xterm.c (x_embed_request_focus): New function.
569
570 * xterm.h: Add prototype.
571
572 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
573
1c6e5a32
GM
5742012-01-05 Glenn Morris <rgm@gnu.org>
575
576 * emacs.c (emacs_copyright): Update short copyright year to 2012.
577
651e947e
EZ
5782012-01-01 Eli Zaretskii <eliz@gnu.org>
579
580 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
581 Load gnutls_transport_set_lowat only if GnuTLS version is below
582 2.11.1.
583 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
584 GnuTLS versions below 2.11.1.
585
3778cdd8
AL
5862011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
587
588 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
589 to the doc string advising against its use for altering the way
590 windows are scrolled.
591
0e5317f7
KH
5922011-12-28 Kenichi Handa <handa@m17n.org>
593
594 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
595 coding-system ASCII compatible only when it does not produce BOM
596 on encoding (Bug#10383).
597
93d5ca1f
JD
5982011-12-26 Jan Djärv <jan.h.d@swipnet.se>
599
600 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
601 can scroll.
602 (create_and_show_popup_menu): Always use menu_position_func for
603 Gtk3 (Bug#10361).
604
ca22b785
AS
6052011-12-24 Andreas Schwab <schwab@linux-m68k.org>
606
607 * callint.c (Fcall_interactively): Don't truncate prompt string.
608
d048e1e6
EZ
6092011-12-23 Eli Zaretskii <eliz@gnu.org>
610
611 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
612 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 613 resumed from there (after widening). (Bug#10360)
d048e1e6 614
5ccaba1f
JD
6152011-12-22 Jan Djärv <jan.h.d@swipnet.se>
616
617 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
618
204ee57f
JD
6192011-12-21 Jan Djärv <jan.h.d@swipnet.se>
620
b81d40f0
JB
621 * nsterm.m (x_free_frame_resources):
622 Release f->output_data.ns->miniimage.
204ee57f
JD
623 (ns_index_color): Fix indentation. Do not retain
624 color_table->colors[i].
625
626 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
627 before returning.
628
629 * nsfns.m (x_set_background_color): Assign return value from
630 ns_index_color to face-background instead of NSColor*.
631 (ns_implicitly_set_icon_type): Fix indentation.
632 Change assignment in for loop to comparison.
633
634 * emacs.c (ns_pool): New variable.
635 (main): Assign ns_pool.
636 (Fkill_emacs): Call ns_release_autorelease_pool.
637
638 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
639 autorelease fdesc, release fdAttrs and tdict.
640 (ns_get_covering_families): Release charset.
641 (ns_findfonts): Release NSFontDescriptor created with new.
642 (ns_uni_to_glyphs): Fix indentation.
643 (setString): Release attrStr before assigning new value.
644
c803b2b7
JD
6452011-12-18 Jan Djärv <jan.h.d@swipnet.se>
646
678f4426
JD
647 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
648 and NS_IMPL_COCOA.
649 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
650 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
651
cd394be1 6522011-12-18 David Reitter <reitter@cmu.edu>
678f4426 653
5fecd5fc
JD
654 * nsterm.m (ns_term_init): Subscribe for notifications
655 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
656 to method trackingNotification in EmacsMenu.
657
658 * nsmenu.m (trackingMenu): New variable.
3771cb17 659 (trackingNotification): New method (from Aquamacs).
5fecd5fc 660 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 661 from Aquamacs (Bug#7030).
678f4426
JD
662
6632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 664
c803b2b7
JD
665 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
666 (symbol_to_nsstring): Fix indentation.
667 (ns_symbol_to_pb): New function.
cae07000
SM
668 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
669 (Fns_rotate_cut_buffers_internal): Remove.
670 (Fns_store_selection_internal): Rename from
c803b2b7
JD
671 Fns_store_cut_buffer_internal.
672 (ns_get_foreign_selection, Fx_own_selection_internal)
673 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
674 (Fns_get_selection_internal, Fns_store_selection_internal):
675 Use ns_symbol_to_pb and check if return value is nil.
676 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
677 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
678 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
679 renamed to Sns_store_selection_internal.
680 (ns_handle_selection_request): Move code to Fx_own_selection_internal
681 and remove this function.
682 (ns_handle_selection_clear): Remove, never used.
683 (Fx_own_selection_internal): Move code from ns_handle_selection_request
684 here.
685
e1b01a3a
KB
6862011-12-17 Ken Brown <kbrown@cornell.edu>
687
688 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
689 GID is unknown (Bug#10257).
690
2adb6e85
PE
6912011-12-17 Paul Eggert <eggert@cs.ucla.edu>
692
693 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
694 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
695 which caused a build failure on GNU/Linux IA-64. This problem was
696 introduced by my 2011-10-07 patch.
697
d1d7b339
JL
6982011-12-15 Juri Linkov <juri@jurta.org>
699
700 * image.c (imagemagick_error): New function. (Bug#10112)
701 (imagemagick_load_image): Comment out `MagickSetResolution' call.
702 Use `imagemagick_error' where ImageMagick functions return
703 `MagickFalse'.
704 (Fimagemagick_types): Add `Fnreverse' to return the list in the
705 proper order.
706
100d5755
KH
7072011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
708
709 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
710 fill background (Bug#8992).
711
454592a6
MR
7122011-12-13 Martin Rudalics <rudalics@gmx.at>
713
714 * window.c (Vwindow_combination_resize)
715 (Vwindow_combination_limit): Use t instead of non-nil in
716 doc-strings.
61d4b438
MR
717 (Vrecenter_redisplay): Add first sentence of doc-string on
718 separate line.
53524d93 719 (Frecenter): Fix doc-string typo.
454592a6 720
3633e3aa
KH
7212011-12-11 Kenichi Handa <handa@m17n.org>
722
723 * coding.c (Funencodable_char_position): Pay attention to the
724 buffer text relocation (Bug#9389).
725
7b9d523a
JD
7262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
729 gtk_init (Bug#10100).
730
b73189c6
EZ
7312011-12-10 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
734 IT->string is nil. (Bug#10263)
735
f7dfe5d6
JD
7362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
737
83faebb4
JD
738 * nsterm.h (x_free_frame_resources): Declare.
739
f7dfe5d6
JD
740 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
741 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
742
743 * nsterm.h (ns_get_defaults_value): Declare.
744
745 * nsterm.m (ns_default): Call ns_get_defaults_value.
746
7cd4e72c
EZ
7472011-12-09 Eli Zaretskii <eliz@gnu.org>
748
749 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
750 (Bug#10170)
751
b34d7317
YM
7522011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
753
754 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
755 that where the value of an _OBJC_* symbol points to is in the .bss
756 section (Bug#10240).
757
76470ad1
KH
7582011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
759
760 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 761 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 762
745fff94
KH
7632011-12-08 Kenichi Handa <handa@m17n.org>
764
765 * ftfont.c (get_adstyle_property): Fix previous change
766 (Bug#10233).
767
6e44397c
JB
7682011-12-07 Juanma Barranquero <lekktu@gmail.com>
769
770 * w32.c (init_environment): If no_site_lisp, remove site-lisp
771 dirs from the default value of EMACSLOADPATH (bug#10208).
772
7efa6272
GM
7732011-12-07 Glenn Morris <rgm@gnu.org>
774
775 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
776 installation and source directories as well. (Bug#10208)
777
f6fc4d87
CY
7782011-12-06 Chong Yidong <cyd@gnu.org>
779
780 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
781
2bf26180
GM
7822011-12-06 Glenn Morris <rgm@gnu.org>
783
784 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
785 as an error, not just -1. (Bug#10217)
786
3a6ad4f0
CY
7872011-12-05 Chong Yidong <cyd@gnu.org>
788
789 * keyboard.c (process_special_events): New function.
790 (swallow_events, Finput_pending_p): Use it (Bug#10195).
791
75a3b399
PE
7922011-12-05 Paul Eggert <eggert@cs.ucla.edu>
793
794 * coding.c (encode_designation_at_bol): Don't use uninitialized
795 local variable (Bug#9318).
796
c3c9e25e
KH
7972011-12-05 Kenichi Handa <handa@m17n.org>
798
799 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
800 return Qnil (Bug#8046, Bug#10193).
801
5eb05ea3
KH
8022011-12-05 Kenichi Handa <handa@m17n.org>
803
804 * coding.c (encode_designation_at_bol): New args charbuf_end and
805 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
806 (coding_set_source): Return how many bytes coding->source was
807 relocated.
808 (coding_set_destination): Return how many bytes
809 coding->destination was relocated.
810 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 811 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
812
8132011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
814
815 * coding.c (CODING_CHAR_CHARSET_P): New macro.
816 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
817 macro (Bug#9318).
818
8192011-12-05 Andreas Schwab <schwab@linux-m68k.org>
820
821 The following changes are to fix Bug#9318.
822
a79703f5 823 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
824 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
825 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 826 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 827
7dbda6df
JB
8282011-12-05 Juanma Barranquero <lekktu@gmail.com>
829
830 * lisp.h (process_quit_flag): Fix external declaration.
831
6d5eb5b0
SM
8322011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
833
834 Don't macro-inline non-performance-critical code.
835 * eval.c (process_quit_flag): New function.
836 * lisp.h (QUIT): Use it.
837
a0c3fad0
JD
8382011-12-04 Jan Djärv <jan.h.d@swipnet.se>
839
840 * nsfns.m (get_geometry_from_preferences): New function.
841 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
842
6c07aac2
AS
8432011-12-04 Andreas Schwab <schwab@linux-m68k.org>
844
845 * emacs.c (Qkill_emacs): Define.
846 (syms_of_emacs): Initialize it.
847 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
848 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
849 (quit_throw_to_read_char): Add parameter `from_signal'.
850 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
851 * lisp.h (QUIT): Call Fkill_emacs if requested.
852
c052ead4
JD
8532011-12-03 Jan Djärv <jan.h.d@swipnet.se>
854
855 * widget.c (update_wm_hints): Return if wmshell is null.
856 (widget_update_wm_size_hints): New function.
857
858 * widget.h (widget_update_wm_size_hints): Declare.
859
860 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
861 widget_update_wm_size_hints (Bug#10104).
862
9e49252b
EZ
8632011-12-03 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (handle_invisible_prop): If the invisible text ends just
866 before a newline, prepare the bidi iterator for consuming the
867 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 868 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 869
02b16839
JL
8702011-12-02 Juri Linkov <juri@jurta.org>
871
872 * search.c (Fword_search_regexp): New Lisp function created from
873 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
874 (Fword_search_backward, Fword_search_forward)
875 (Fword_search_backward_lax, Fword_search_forward_lax):
876 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
877 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
878
0068070e
SM
8792011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
880
881 * fileio.c (Finsert_file_contents): Move after-change-function call
882 to before the "handled:" label, since all "goto handled" appear in
883 cases where the *-change-functions have already been properly called
884 (bug#10117).
885
3360a3fc
AS
8862011-12-01 Andreas Schwab <schwab@linux-m68k.org>
887
888 * keyboard.c (interrupt_signal): Don't call kill-emacs when
889 waiting for input. (Bug#10169)
890
73d6c093
EZ
8912011-11-30 Eli Zaretskii <eliz@gnu.org>
892
893 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
894 verifies glyph row's hash code--we have just reallocated the
895 glyphs, so their contents can be complete garbage. (Bug#10164)
896
febe6bea
JB
8972011-11-30 Juanma Barranquero <lekktu@gmail.com>
898
899 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
900
801a4313
EZ
9012011-11-30 Eli Zaretskii <eliz@gnu.org>
902
903 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
904 attributes are tested _before_ calling verify_row_hash, to protect
905 against GCC re-ordering of the tests. (Bug#10164)
906
2b56b87e
JD
9072011-11-29 Jan Djärv <jan.h.d@swipnet.se>
908
909 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
910
911 * xterm.c (handle_one_xevent): Only set async_visible and friends
912 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 913 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
914 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
915
dbf31225
PE
9162011-11-28 Paul Eggert <eggert@cs.ucla.edu>
917
918 Remove GCPRO-related macros that exist only to avoid shadowing locals.
919 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
920 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
921 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
922 All uses changed to use GCPRO1 etc.
923 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
924 Revert to old implementation (i.e., before 2011-03-11).
925
1305621b
YM
9262011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
927
928 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
929 of scroll runs so as to avoid assigning disabled bogus rows and
930 unnecessary graphics copy operations.
931
8c9afb46
EZ
9322011-11-27 Eli Zaretskii <eliz@gnu.org>
933
934 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
935 (snprintf) [_MSC_VER]: Redirect to _snprintf.
936 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
937 (malloc, free, realloc, calloc): Redirect to e_* only when
938 compiling Emacs.
939
940 * lisp.h (GCTYPEBITS): Move before first use.
941 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
942 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
943 this macro definition.
944
945 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
946 _MSC_VER.
947
54e9e3bf
JD
9482011-11-27 Jan Djärv <jan.h.d@swipnet.se>
949
6d5eb5b0
SM
950 * gtkutil.c (xg_create_frame_widgets):
951 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
952 present with Gtk+ 2.0.
953
83aca1cb
PE
9542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
955
956 * fileio.c (Finsert_file_contents): Undo previous change; see
957 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
958
5b76caa4
PE
9592011-11-26 Paul Eggert <eggert@cs.ucla.edu>
960
961 Rename locals to avoid shadowing.
962 * fileio.c (Finsert_file_contents):
963 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
964 * process.c (wait_reading_process_output):
965 Rename inner 'proc' to 'p' to avoid shadowing.
966 Indent for consistency with usual Emacs style.
967
8c535114
EZ
9682011-11-25 Eli Zaretskii <eliz@gnu.org>
969
970 * xdisp.c (redisplay_window): If cursor row is not fully visible
971 after recentering, and scroll-conservatively is set to a large
972 number, scroll window by a few more lines to make the cursor fully
973 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
974 (start_display): Don't move to the next line if the display should
975 start at a newline that is part of a display vector or an overlay
976 string. (Bug#10119)
8c535114 977
fa4fdb5c
JL
9782011-11-24 Juri Linkov <juri@jurta.org>
979
980 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
981 after the `MagickPingImage' call. (Bug#10112)
982
90ec88df
CY
9832011-11-23 Chong Yidong <cyd@gnu.org>
984
985 * window.c (Fcoordinates_in_window_p): Accept only live windows.
986
56e2e794
MR
9872011-11-23 Martin Rudalics <rudalics@gmx.at>
988
989 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
990 making another buffer current. (Bug#10114)
991
b6e64c41
GM
9922011-11-23 Glenn Morris <rgm@gnu.org>
993
994 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
995
6b21de18
CY
9962011-11-23 Chong Yidong <cyd@gnu.org>
997
998 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
999 using it (Bug#5984).
1000
b12cd789
EZ
10012011-11-22 Eli Zaretskii <eliz@gnu.org>
1002
1003 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1004 and header-lines, as they don't have one computed for them.
1005 (Bug#10098)
1006
1007 * .gdbinit (prow): Make displayed values more self-explaining.
1008 Add row's hash code.
1009
261b6fd4
LMI
10102011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1011
1012 * process.c (wait_reading_process_output): Fix asynchrounous
1013 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1014 (wait_reading_process_output): Add comment and URL.
261b6fd4 1015
e7cfd277
JD
10162011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1017
1018 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1019
a9b9b7f5
CY
10202011-11-21 Chong Yidong <cyd@gnu.org>
1021
1022 * window.c (Fnext_window, Fprevious_window): Doc fix.
1023
b0d15b4f
SM
10242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1025
1026 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1027
fe7a3057
JB
10282011-11-20 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1031
d2999b1a
MR
10322011-11-20 Martin Rudalics <rudalics@gmx.at>
1033
1034 * window.c (Fset_window_combination_limit): Rename argument
1035 STATUS to LIMIT.
1036 (Vwindow_combination_limit): Remove "status" from doc-string.
1037
d5ff9cd0
AS
10382011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1039
1040 * m/ibms390.h: Remove.
1041 * m/ibms390x.h: Don't include "ibms390.h".
1042
a5bb9bd3
SM
10432011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1044
1045 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1046 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1047
cd1181db
JB
10482011-11-20 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * casetab.c (Fset_case_table):
1051 * charset.c (Fcharset_after): Fix typos.
1052
615a3b8d 10532011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1054
17e845af
PE
1055 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1056 Otherwise, valgrind does not work on some platforms.
1057 Problem reported by Andreas Schwab in
6a0bf43d
PE
1058 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1059 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1060 is set, removing the need for VIRT_ADDRESS_VARIES.
1061 (PURE_P): Use a more-efficient implementation that needs just one
1062 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1063 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1064 to 4 (xorl, subq, cmpq, setbe).
1065 * alloc.c (pure): Always extern now, since that's the
1066 VIRT_ADDR_VARIES behavior.
1067 (PURE_POINTER_P): Use a single comparison, not two, for
1068 consistency with the new puresize.h.
1069 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1070 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1071 Remove VIRT_ADDR_VARIES no longer needed.
1072
f8fe6f96
EZ
10732011-11-19 Eli Zaretskii <eliz@gnu.org>
1074
1075 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1076 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1077 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1078 behave as if the cursor position were at the window margin.
1079
1080 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1081 and the cursor position is out of bounds, behave as if the cursor
1082 position were at the window margin. (Bug#10075)
1083
df05a53c
CY
10842011-11-18 Chong Yidong <cyd@gnu.org>
1085
1086 * window.c (Fwindow_combination_limit): Make first argument
1087 non-optional, since it is meaningless for live windows like the
1088 selected window.
1089
2071918e
DA
10902011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1091
1092 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1093
b50a28de
SM
10942011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1095
1096 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1097 (graft_intervals_into_buffer): Simplify.
1098
015137db
EZ
10992011-11-18 Eli Zaretskii <eliz@gnu.org>
1100
1101 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1102 hash values of the two rows.
1103 (copy_row_except_pointers): Preserve the used[] arrays and the
1104 hash values of the two rows. (Bug#10035)
68c95424 1105 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1106
1107 * xdisp.c (row_hash): New function, body extracted from
1108 compute_line_metrics.
1109 (compute_line_metrics): Call row_hash, instead of computing the
1110 hash code inline.
1111
1112 * dispnew.c (verify_row_hash): Call row_hash for computing the
1113 hash code of a row, instead of duplicating code from xdisp.c.
1114
1115 * dispextern.h (row_hash): Add prototype.
1116
a2addb04
TH
11172011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1118
1119 * frame.c (delete_frame): Don't delete the terminal when the last
1120 X frame is closed if emacs is built with GTK toolkit.
1121
df85d315
JB
11222011-11-17 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1125
a0c2d0ae
MR
11262011-11-17 Martin Rudalics <rudalics@gmx.at>
1127
1128 * window.c (Vwindow_splits): Rename to
1129 Vwindow_combination_resize. Suggested by Juri Linkov.
1130 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1131 of Vwindow_splits.
1132
58179cce
JB
11332011-11-16 Juanma Barranquero <lekktu@gmail.com>
1134
7877f373
JB
1135 * nsfns.m (Fns_font_name):
1136 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1137
b6f67890
MR
11382011-11-16 Martin Rudalics <rudalics@gmx.at>
1139
1140 * window.h (window): Rename slot "nest" to "combination_limit".
1141 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1142 (Fset_window_nest): Rename to Fset_window_combination_limit.
1143 (Vwindow_nest): Rename to Vwindow_combination_limit.
1144 (recombine_windows, make_parent_window, make_window)
1145 (Fsplit_window_internal, saved_window)
1146 (Fset_window_configuration, save_window_save): Rename all
1147 occurrences of window_nest to window_combination_limit.
1148
c7015153
JB
11492011-11-15 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * image.c (imagemagick_load_image): Fix typo.
1152
322ad6ec
EZ
11532011-11-14 Eli Zaretskii <eliz@gnu.org>
1154
1155 * xdisp.c (display_line): Move the call to
1156 highlight_trailing_whitespace before the call to
1157 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1158 faces of all the glyphs to compute ROW's hash value.
1159 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1160
f067b8ec
JB
11612011-11-14 Juanma Barranquero <lekktu@gmail.com>
1162
1163 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1164 just return (bug#10044).
1165
1e5b2111
EZ
11662011-11-12 Eli Zaretskii <eliz@gnu.org>
1167
7ef3cbd5
EZ
1168 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1169 with user-defined heap size. Bump the default size of the temacs
1170 heap to 27MB, to avoid memory warning when running temacs.
1171 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1172
1e5b2111
EZ
1173 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1174 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1175 (verify_row_hash) [XASSERTS]: New function.
1176 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1177 that the hash value of glyph rows is correct.
1e5b2111 1178
89d61221
MR
11792011-11-12 Martin Rudalics <rudalics@gmx.at>
1180
1181 * window.h (window): Remove splits slot.
1182 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1183 (Fdelete_other_windows_internal, make_parent_window)
1184 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1185 (Fset_window_configuration, save_window_save): Don't deal with
1186 split status of windows.
1187 (saved_window): Remove splits slot.
1188 (Vwindow_splits): Rewrite doc-string.
1189
97f18cc8
JD
11902011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * xfns.c (unwind_create_frame):
1193 * nsfns.m (unwind_create_frame):
1194 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1195 Vframe_list (Bug#9999).
1196
22a648b4
DA
11972011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1198
0b381c7e 1199 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1200
659afede
KH
12012011-11-11 Kenichi Handa <handa@m17n.org>
1202
1203 * callproc.c (Fcall_process): Set the member dst_multibyte of
1204 process_coding.
1205
9ac0394b
KH
12062011-11-11 Johan Bockgård <bojohan@gnu.org>
1207
1208 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1209 avoid a crash (bug#9496).
1210
2fbdc249
CY
12112011-11-09 Chong Yidong <cyd@gnu.org>
1212
1213 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1214 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1215
ac6b1f81
PE
12162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1219
09db192c
PE
12202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 Avoid some portability problems by eschewing 'extern inline' functions.
1223 The trivial performance wins aren't worth the portability hassles; see
1224 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1225 et seq.
1226 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1227 (window_box_width, window_box_left, window_box_left_offset)
1228 (window_box_right, window_box_right_offset): Undo previous change,
1229 by removing the "extern"s.
1230 * intervals.c (adjust_intervals_for_insertion)
1231 (adjust_intervals_for_deletion): Undo previous change,
1232 making these static again.
1233 (offset_intervals, temp_set_point_both, temp_set_point)
1234 (copy_intervals_to_string): No longer inline.
1235 * xdisp.c (window_text_bottom_y, window_box_width)
1236 (window_box_height, window_box_left_offset)
1237 (window_box_right_offset, window_box_left, window_box_right)
1238 (window_box): No longer inline.
1239
105216ed
CY
12402011-11-08 Chong Yidong <cyd@gnu.org>
1241
1242 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1243 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1244 Signal an error if not a live window.
105216ed
CY
1245 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1246 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1247
ae9e237f
JB
12482011-11-07 Juanma Barranquero <lekktu@gmail.com>
1249
1250 * lisp.h (syms_of_abbrev): Remove declaration.
1251 Reported by CHENG Gao <chenggao@royau.me>.
1252
c7aa8333
EZ
12532011-11-07 Eli Zaretskii <eliz@gnu.org>
1254
1255 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1256 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1257 of temacs in GUI mode.
1258
be7f5545
MR
12592011-11-07 Martin Rudalics <rudalics@gmx.at>
1260
1261 * window.h: Declare delete_all_child_windows instead of
1262 delete_all_subwindows.
1263 * window.c (Fwindow_nest, Fset_window_nest)
1264 (Fset_window_new_total, Fset_window_new_normal)
1265 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1266 (delete_all_subwindows): Rename to delete_all_child_windows.
1267 (Fdelete_other_windows_internal, Fset_window_configuration):
1268 Call delete_all_child_windows instead of delete_all_subwindows.
1269 * frame.c (delete_frame): Call delete_all_child_windows instead
1270 of delete_all_subwindows.
1271
ca78dc43
PE
12722011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1275 This is also needed for porting to any host where GC_MARK_STACK is
1276 not GC_MAKE_GCPROS_NOOPS.
1277 (which_symbols): Use it.
1278
a0241d01
KH
12792011-11-07 Kenichi Handa <handa@m17n.org>
1280
1281 * coding.c (coding_set_destination): Check coding->src_pos only
1282 when coding->src_object is a buffer (bug#9910).
1283
1284 * process.c (send_process): Set the member src_multibyte of coding
1285 to 0 (bug#9911) when sending a unibyte text.
1286
1287 * callproc.c (Fcall_process): Set the member src_multibyte of
1288 process_coding to 0 (bug#9912).
1289
a64bfdfa 12902011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1291
1292 * xmenu.c (cleanup_widget_value_tree): New function.
1293 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1294 calling free_menubar_widget_value_tree directly (Bug#9830).
1295
cb41b32a
PE
12962011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 Fix some portability problems with 'inline'.
1299 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1300 (window_box_width, window_box_left, window_box_left_offset)
1301 (window_box_right, window_box_right_offset): Declare extern.
1302 Otherwise, these inline functions do not conform to C99 and
1303 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1304 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1305 * intervals.c (adjust_intervals_for_insertion)
1306 (adjust_intervals_for_deletion): Now extern, because otherwise the
1307 extern inline functions 'offset_intervals' couldn't refer to it.
1308 (static_offset_intervals): Remove.
1309 (offset_intervals): Rewrite using the old contents of
1310 static_offset_intervals. The old version didn't conform to C99
1311 because an extern inline function contained a reference to an
1312 identifier with static linkage.
1313
b7041366
AS
13142011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1315
1316 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1317 GC.
1318
88a37c4d
EZ
13192011-11-06 Eli Zaretskii <eliz@gnu.org>
1320
1321 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1322 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1323 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1324 return Qleft_to_right.
1325
49745b39
CY
13262011-11-06 Chong Yidong <cyd@gnu.org>
1327
1328 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1329 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1330 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1331 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1332 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1333 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1334 (Fwindow_vscroll): Doc fix.
1335 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1336 argument, since it makes no sense to pass a live window and for
1337 consistency with window-child.
1338
1f05cd82
CS
13392011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1340
1341 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1342 support MSVC.
1343
22610910
JR
13442011-11-05 Jason Rumney <jasonr@gnu.org>
1345
1346 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1347 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1348 fonts (Bug#6029).
1349 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1350 bitwise arithmetic preventing use of unicode-sip and non-truetype
1351 opentype fonts.
1352
a06776b2
EZ
13532011-11-05 Eli Zaretskii <eliz@gnu.org>
1354
3ad924ba
EZ
1355 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1356 "emacs"-only part.
1357
a06776b2
EZ
1358 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1359 initialization code to keep similarity to xfns.c after changes
1360 from 2011-11-05.
1361
c9e7db78
JD
13622011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1363
a97f8f3f
JD
1364 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1365 (unwind_create_frame): New function (Bug#9943).
1366 (Fx_create_frame): Restructure code to be more similar to the one in
1367 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1368 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1369 Move terminal->reference_count++ just before making the frame official
1370 (Bug#9943).
1371
1372 * nsterm.m (x_free_frame_resources): New function.
1373 (x_destroy_window): Move code to x_free_frame_resources.
1374
c9e7db78 1375 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1376 (Fx_create_frame, x_create_tip_frame):
1377 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1378 official. Move initialization of image_cache_refcount and
1379 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1380
a6fc3b5c
EZ
13812011-11-05 Eli Zaretskii <eliz@gnu.org>
1382
1383 Support MSVC build with newer versions of Visual Studio.
1384 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1385 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1386 nt/gmake.defs.
1387
1388 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1389 which are not supported by MSVC.
1390 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1391 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1392 bitfields.
1393 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1394 types in bitfields.
1395 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1396
1397 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1398
58179cce 13992011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1400
1401 Support MSVC build with newer versions of Visual Studio.
1402 * w32.c: Don't include w32api.h for MSVC.
1403 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1404
1405 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1406 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1407 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1408 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1409 e_* cousins.
1410 (alloca) [_MSC_VER]: Define to _alloca.
1411
1412 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1413
1414 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1415
a58c13ed
EZ
14162011-11-04 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (note_mouse_highlight): If either of
1419 previous/next-single-property-change returns nil, treat that as
1420 the beginning or the end of the buffer. (Bug#9955)
1421
fe0b6370
JD
14222011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1423
a58c13ed 1424 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1425 label is not null (Bug#9951).
1426 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1427 may be NULL.
1428
89bd5ee1
EZ
14292011-11-04 Eli Zaretskii <eliz@gnu.org>
1430
1431 * window.c (Fwindow_body_size): Mention in the doc string that the
1432 return value is in frame's canonical units. (Bug#9949)
1433
84c3edb9
EZ
14342011-11-03 Eli Zaretskii <eliz@gnu.org>
1435
4e2fb5c7
EZ
1436 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1437
84c3edb9 1438 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1439 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1440 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1441
bc17a887
EZ
14422011-11-01 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1445 Don't stop backward scan on the continuation glyph, even though
1446 its CHARPOS is positive.
6d5eb5b0
SM
1447 (mouse_face_from_buffer_pos, note_mouse_highlight):
1448 Rename cover_string to disp_string.
bc17a887 1449
4ee88440
MR
14502011-11-01 Martin Rudalics <rudalics@gmx.at>
1451
1452 * window.c (temp_output_buffer_show): Don't use
1453 Vtemp_buffer_show_specifiers.
1454 (Vtemp_buffer_show_specifiers): Remove unused variable.
1455
c2ff3c02
EZ
14562011-10-30 Eli Zaretskii <eliz@gnu.org>
1457
1458 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1459 past the beginning of the current glyph matrix.
1460
58179cce 14612011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1462
1463 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1464 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1465 HAVE_GTK3 (Bug#9869).
b77a6a7f 1466
3b574623
JD
1467 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1468 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1469
b77a6a7f
JD
1470 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1471
1472 * xterm.c: Declare x_handle_net_wm_state to return int.
1473 (handle_one_xevent): Check if we are iconified but don't have
1474 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1475 (get_current_wm_state): Return non-zero if not hidden,
1476 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1477 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1478 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1479 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1480
196e41e4
PE
14812011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1484 so that this new function doesn't get optimized away by a
1485 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1486
021f2e1a
AS
14872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1488
1489 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1490
8b058d44
EZ
14912011-10-29 Eli Zaretskii <eliz@gnu.org>
1492
1493 Fix the `xbytecode' command.
1494 * .gdbinit (xprintbytestr): New command.
b50a28de 1495 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1496 (xbytecode): Print the byte-code string as well.
1497
4452fb80
EZ
14982011-10-29 Kim Storm <storm@cua.dk>
1499
8b058d44
EZ
1500 * alloc.c (which_symbols): New function.
1501
21b72067
AS
15022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1503
1504 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1505 line. (Bug#9903)
1506
83ed7b5c
GM
15072011-10-29 Glenn Morris <rgm@gnu.org>
1508
1509 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1510 Not clear what it was for, and it causes various bugs. (Bug#9839)
1511
5a7a728b
EZ
15122011-10-28 Eli Zaretskii <eliz@gnu.org>
1513
1514 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1515 possible random value that matches one of those tested as
1516 condition to clear the mouse face.
1517
d3d0842f
CY
15182011-10-28 Chong Yidong <cyd@gnu.org>
1519
1520 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1521
31b39d13
DN
15222011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1523
1524 * window.c (make_window): Initialize phys_cursor_on_p.
1525
9aba6043
SM
15262011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1527
1528 * lisp.h (struct Lisp_Symbol): Update comments.
1529
c20992f4
JB
15302011-10-28 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1533
db4f02f2
EZ
15342011-10-28 Eli Zaretskii <eliz@gnu.org>
1535
1536 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1537 <oslsachem@gmail.com> for helping to debug this.
1538
1539 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1540 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1541 (g_b_init_get_glyph_outline_w): New static variables.
1542 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1543 (GetGlyphOutlineW_Proc): New typedefs.
1544 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1545 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1546 New functions.
1547 (w32font_open_internal, compute_metrics):
1548 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1549 instead of calling the "wide" APIs directly.
1550
1551 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1552
1553 * w32.h (syms_of_w32font): Add prototype.
1554
87e68db4
JB
15552011-10-27 Juanma Barranquero <lekktu@gmail.com>
1556
1557 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1558 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1559 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1560 (Fmove_to_window_line): Doc fix.
1561
435c1d67
CY
15622011-10-27 Chong Yidong <cyd@gnu.org>
1563
1564 * process.c (make_process): Set gnutls_state to NULL.
1565
1566 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1567 non-NULL, regardless of GNUTLS_INITSTAGE.
1568 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1569 an error. Set process slots as soon as we allocate them.
1570
1571 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1572
9c6c6f49
CY
15732011-10-27 Chong Yidong <cyd@gnu.org>
1574
9aba6043
SM
1575 * gnutls.c (emacs_gnutls_deinit): New function.
1576 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1577 (Fgnutls_deinit, Fgnutls_boot): Use it.
1578
1579 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1580 (deactivate_process): Call emacs_gnutls_deinit.
1581
657d08d3
JB
15822011-10-27 Juanma Barranquero <lekktu@gmail.com>
1583
1584 * image.c (x_create_x_image_and_pixmap):
1585 * w32.c (sys_rename, w32_delayed_load):
1586 * w32font.c (fill_in_logfont):
1587 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1588
5430d399
JB
15892011-10-26 Juanma Barranquero <lekktu@gmail.com>
1590
1591 * w32fns.c (w32_default_color_map): New function,
1592 extracted from Fw32_default_color_map.
a7ef684b 1593 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1594
fe0055fa
PE
15952011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1596
1597 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1598
e6346438
SM
15992011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1600
1601 * keyboard.c (test_undefined): New function (bug#9751).
1602 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1603
e112cc37
ET
16042011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1605
1606 * sysdep.c (init_sys_modes): Fix the check for the controlling
1607 terminal (Bug#6649).
1608
7b5d6677
EZ
16092011-10-20 Eli Zaretskii <eliz@gnu.org>
1610
1611 * dispextern.h (struct bidi_it): New member next_en_type.
1612
1613 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1614 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1615 current character, check also for next_en_type being WEAK_EN.
1616 (bidi_resolve_weak): Don't enter the expensive loop if the current
1617 position is before next_en_pos. Record the bidi type of the first
1618 non-ET, non-BN character we find, in addition to its position.
1619 (bidi_level_of_next_char): Invalidate next_en_type when
1620 next_en_pos is over-stepped.
1621
7da0b018
PE
16222011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1625 * editfns.c: Rewrite current-time-zone so that it invokes
1626 the equivalent of (format-time-string "%Z") to get the time zone name.
1627 This fixes a bug when the time zone name contains characters that
1628 need converting from the system time locale to Emacs internal format.
1629 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1630 that patch fixed format-time-string to do the conversion, but
1631 I forgot to fix current-time-zone.
1632 (format_time_string): New function, containing most of
1633 what Fformat_time_string used to contain.
1634 (Fformat_time_string): Rewrite in terms of format_time_string.
1635 This doesn't change this function's behavior.
1636 (current-time-zone): Rewrite to use format_time_string.
1637 This fixes the bug reported by Michael Schierl in
1638 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1639 Jason Rumney's 2007-06-07 change worked around this bug, but
1640 didn't fix it.
1641 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1642
8547b010
EZ
16432011-10-19 Eli Zaretskii <eliz@gnu.org>
1644
1645 * xdisp.c (start_display): If the character at POS is displayed
1646 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1647 (try_window_reusing_current_matrix): If a line ends in a display
1648 vector or the next line starts in a display vector, continue
1649 redrawing the window even though the character position of
1650 start_row was reached.
8547b010
EZ
1651 (Bug#9771, part 2)
1652
4e948d15
CY
16532011-10-18 Chong Yidong <cyd@gnu.org>
1654
1655 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1656 with nobreak-char-display too.
1657
4787455f
EZ
16582011-10-18 Eli Zaretskii <eliz@gnu.org>
1659
1660 Fix part 3 of bug#9771.
1661 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1662 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1663 non-neutral characters if the current character is a paragraph
1664 separator (a.k.a. Newline). This avoids running the same
1665 expensive loop twice, once when we consume the preceding newline
1666 and the other time when the line actually needs to be displayed.
1667 Avoid the loop when we see neutrals on the base embedding level
1668 following a character whose directionality is the same as the
1669 paragraph's. This avoids running the expensive loop when a line
1670 ends in a long sequence of neutrals, like control characters.
1671 Add assertion against STRONG_AL type. Slightly rearrange code
1672 that determines the type of a neutral given the first non-neutral
1673 that follows it.
1674 (bidi_level_of_next_char): Set next_en_pos to zero when
1675 invalidating its info.
1676
2c91f553
EZ
16772011-10-17 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (push_display_prop): Determine whether to record string
1680 or buffer position by IT->string, not by IT->method. Allow
1681 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1682 (move_it_vertically_backward): Don't look for character position
1683 immediately after the newline when in a continuation line.
1684 (Bug#9771, part 1)
2c91f553 1685
c7b08b0d
MR
16862011-10-15 Martin Rudalics <rudalics@gmx.at>
1687
1688 * window.c (coordinates_in_window): Rewrite and delabelize
1689 vertical border check. (Bug#5357) (Bug#9618)
1690
6b02f655
SM
16912011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1692
1693 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1694 errors in XSetWindowBorder (bug#9310).
1695
81d40c92
DA
16962011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1699 avoid crash when xmalloc overrun checking is enabled.
1700
d4172c3b
EZ
17012011-10-13 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1704 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1705 cursor motion with <left> and <right> arrow keys.
1706
1707 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1708 some callers set that themselves.
1709
b00eea75
EZ
17102011-10-12 Eli Zaretskii <eliz@gnu.org>
1711
1712 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1713 display string and the previous row comes from the same string and
1714 is empty. (Bug#9739) (Bug#9738)
1715
8fe012c4
SM
17162011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1717
1718 * doc.c (get_doc_string): Encode file name (bug#9735).
1719
0074aef2
EZ
17202011-10-12 Eli Zaretskii <eliz@gnu.org>
1721
79beb178
EZ
1722 * bidi.c (bidi_level_of_next_char):
1723 * xdisp.c (get_visually_first_element): Remove old incorrect
1724 comments regarding the Unicode Line Separator character.
1725
0074aef2
EZ
1726 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1727
6e4b3fbe
DA
17282011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1729
1730 * alloc.c (Fgc_status): Do not access beyond zombies array
1731 boundary if nzombies > MAX_ZOMBIES.
1732 * alloc.c (dump_zombies): Add missing format specifier.
1733
0324f3af
PE
17342011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1735
b5525cac
PE
1736 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1737 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1738
0324f3af
PE
1739 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1740 Some packages use them to denote characters with modifiers.
1741
e9b5f888
AS
17422011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1743
1744 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1745 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1746 matching a pp-number. Rename parameter var to var1.
1747
127827c0
SM
17482011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1749
1750 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1751
c8fd3bd0
GM
17522011-10-08 Glenn Morris <rgm@gnu.org>
1753
1754 * callint.c (Fcall_interactively): Give a more explicit error for the
1755 'c' case with a non-character input. (Bug#8479)
1756
352ec8ff
EZ
17572011-10-08 Eli Zaretskii <eliz@gnu.org>
1758
03669ccb
EZ
1759 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1760 lines.
7061c986
EZ
1761 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1762 lines that are hscrolled on the left.
03669ccb 1763
352ec8ff
EZ
1764 * dispnew.c (buffer_posn_from_coords): Account for a possible
1765 presence of header-line. (Bug#4426)
1766
a66cfb1c
SM
17672011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1768
6b02f655
SM
1769 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1770 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1771
7c5ee88e
PE
17722011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1775 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1776 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1777 this makes Emacs dump core during garbage collection on rare
1778 occasions. sizeof is obviously inferior to offsetof here, so
1779 stick with offsetof.
1780 (GC_POINTER_ALIGNMENT): New macro.
1781 (mark_memory): Omit 3rd (offset) arg; caller changed.
1782 Don't assume EMACS_INT alignment is the same as pointer alignment.
1783
df1bbe5b
SM
17842011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1785
1786 * keyboard.c (read_key_sequence_remapped): New var.
1787 (read_key_sequence): Compute remapping in the right buffer.
1788 (command_loop_1): Use read_key_sequence's remapping directly.
1789
51553db6
SM
17902011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1791
32c1fffd
SM
1792 * dired.c (file_name_completion): Don't expand file name.
1793 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1794 before checking file name handler.
1795
51553db6
SM
1796 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1797 they've been requested explicitly (bug#9591).
1798
b6bd1599 17992011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1800
1801 * keymap.c (Fsingle_key_description): Use make_specified_string
1802 instead of build_string to build string from push_key_description.
1803 (Bug#5193)
1804
f701dc2a
PE
18052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1806
4222c55d
PE
1807 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1808 This fixes a Y2038 bug on 64-bit hosts.
1809 * buffer.c (reset_buffer):
1810 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1811 (Fclear_buffer_auto_save_failure):
1812 Use 0, not -1, to represent an unset failure time, since time_t
1813 might not be signed.
1814
f701dc2a
PE
1815 Remove dependency on glibc malloc internals.
1816 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1817 Move back here from lisp.h, but with their new implementations.
1818 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1819 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1820 * charset.c (charset_table_init): New static var.
1821 (syms_of_charset): Use it instead of xmalloc. This removes a
1822 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1823 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1824 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1825 Move back to alloc.c.
1826 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1827 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1828
9ceebf39
JD
18292011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1830
1831 * nsterm.m (windowDidResize): Call x_set_window_size only when
1832 ns_in_resize is true. Otherwise set pixelwidth/height and
1833 call change_frame_size (Bug#9628).
1834
cb993c58
PE
18352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1836
3930c88b
PE
1837 Port --enable-checking=all to Fedora 14 x86-64.
1838 * charset.c (syms_of_charset): Also account for glibc malloc's
1839 internal overhead when calculating the initial malloc maximum.
1840
cb993c58
PE
1841 Port --enable-checking=all to Fedora 14 x86.
1842 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1843 Move to lisp.h.
1844 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1845 (overrun_check_realloc, overrun_check_free):
1846 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1847 That way, xmalloc returns a properly-aligned pointer even if
1848 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1849 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1850 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1851 into account when calculating the initial malloc maximum.
1852 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1853 Move here from alloc.c, so that charset.c can use it too.
1854 Properly align; the old code wasn't right for common 32-bit hosts
1855 when configured with --enable-checking=all.
1856 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1857 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1858
31bed486
EZ
18592011-09-29 Eli Zaretskii <eliz@gnu.org>
1860
04c70788 1861 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1862 use EDOM.
1863
fbcaa2f3
EZ
18642011-09-28 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (compute_display_string_end): If there's no display
1867 string at CHARPOS, return -1.
1868
1869 * bidi.c (bidi_fetch_char): When compute_display_string_end
1870 returns a negative value, treat the character as a normal
1871 character not covered by a display string. (Bug#9624)
1872
a239d4e9
JB
18732011-09-28 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * lread.c (Fread_from_string): Fix typo in docstring.
1876
88652fd5
EZ
18772011-09-27 Eli Zaretskii <eliz@gnu.org>
1878
1879 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1880 newline, reseat the iterator instead of bidi-iterating there one
1881 character at a time. (Bug#9610)
32c1fffd
SM
1882 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1883 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1884
ed497dd4
AS
18852011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1886
1887 * lread.c (readevalloop): Use correct code for NBSP.
1888 (read1): Likewise. (Bug#9608)
1889
b2bf61aa
MA
18902011-09-25 Michael Albinus <michael.albinus@gmx.de>
1891
1892 * dbusbind.c (Fdbus_register_signal): When service is not
1893 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1894
32bbb17c
GM
18952011-09-25 Glenn Morris <rgm@gnu.org>
1896
1897 * buffer.c (truncate-lines): Doc fix.
1898
94e0933e
CY
18992011-09-24 Chong Yidong <cyd@stupidchicken.com>
1900
1901 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1902 (Fset_window_next_buffers): Doc fix.
1903
cddde921
GM
19042011-09-24 Glenn Morris <rgm@gnu.org>
1905
1906 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1907
1260aef1
PE
19082011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1909
25b4bfa0
PE
1910 Fix minor problems found by static checking.
1911 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1912 * indent.c (Fvertical_motion): Fix == vs = typo.
1913
e3cbd34b
EZ
19142011-09-24 Eli Zaretskii <eliz@gnu.org>
1915
a66cfb1c
SM
1916 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1917 Default value is now t. Doc fix.
6bf7006f 1918
e3cbd34b 1919 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1920 logic when moving up, not only when moving down. Fix the
e3cbd34b 1921 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1922 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1923
1924 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1925 CHARPOS is covered by a display string which includes newlines.
1926 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1927 is covered by a display string with embedded newlines.
1928
a3de0cbd
MA
19292011-09-24 Michael Albinus <michael.albinus@gmx.de>
1930
1931 * dbusbind.c (Fdbus_register_signal): Add match rule to
1932 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1933 (Fdbus_register_method, Vdbus_registered_objects_table):
1934 Fix docstring.
a3de0cbd 1935
b260039d
JM
19362011-09-24 Jim Meyering <meyering@redhat.com>
1937
32c1fffd 1938 do not ignore write error for any output size
b260039d
JM
1939 The previous change was incomplete.
1940 While it makes emacs --batch detect the vast majority of stdout
1941 write failures, errors were still ignored whenever the output size is
1942 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1943 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1944 && echo FAIL: ignored write error
1945 FAIL: ignored write error
1946 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1947 && echo FAIL: ignored write error
1948 FAIL: ignored write error
1949 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1950
8eca8a7c
AS
19512011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1952
1953 * emacs.c (Fkill_emacs): In noninteractive mode exit
1954 non-successfully if a write error occurred on stdout. (Bug#9574)
1955
3341db62
EZ
19562011-09-21 Eli Zaretskii <eliz@gnu.org>
1957
1958 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1959 the xassert test.
1960
1961 * dispextern.h (struct it): Update the comment documenting what
1962 can it->OBJECT be.
1963
8c203dbf
EZ
19642011-09-20 Eli Zaretskii <eliz@gnu.org>
1965
1966 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1967 a display string, extend search for cursor position to end of row.
1968 (find_row_edges): If the row ends in a newline from a display
1969 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1970 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1971 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1972 non-empty line. Fixes confusing cursor motion with arrow keys at
1973 the beginning of a line that starts with whitespace.
8c203dbf 1974
a4824228
LMI
19752011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1976
1977 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1978 (bug#9493).
1979
33ed493b
CY
19802011-09-18 Chong Yidong <cyd@stupidchicken.com>
1981
1982 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1983 boolean (Bug#9154).
1984
56cd55c8
EZ
19852011-09-18 Eli Zaretskii <eliz@gnu.org>
1986
1987 * xdisp.c (display_line): Record maximum and minimum buffer
1988 positions even if no glyphs were produced (e.g., by a zero-width
1989 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1990 buffer positions that will be removed from the glyph row because
1991 they don't fit.
c02dcedf
EZ
1992 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1993 column is beyond frame width: don't subtract 1 "pixel" when
1994 computing width of the stretch.
3e62b7e0
EZ
1995 (reseat_at_next_visible_line_start): Undo the change made on
1996 2011-09-17 that saved paragraph information and restored it after
1997 the call to `reseat'. (Bug#9545)
56cd55c8 1998
5ed99d36 19992011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2000
2001 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2002 and turn window cursor on if cleared (Bug#9415).
2003
5ed99d36 20042011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2005
2006 * search.c (boyer_moore): Take unibyte characters from pattern
2007 literally. (Bug#9458)
2008
9bade7b2
EZ
20092011-09-18 Eli Zaretskii <eliz@gnu.org>
2010
2011 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2012
e5e9d610
PE
20132011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2014
87e4427a
PE
2015 Fix minor problem found by static checking.
2016 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2017 initialized, to pacify gcc -Wuninitialized.
2018
e5e9d610
PE
2019 * fileio.c: Report proper errno when syscall falls.
2020 (Finsert_file_contents): Save and restore errno,
2021 so that report_file_error outputs the correct diagnostic.
2022 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2023
a1674f0b
EZ
20242011-09-18 Eli Zaretskii <eliz@gnu.org>
2025
2026 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2027
fbfb6dd4
EZ
20282011-09-17 Eli Zaretskii <eliz@gnu.org>
2029
2030 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2031 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2032
bb187662
EZ
20332011-09-17 Eli Zaretskii <eliz@gnu.org>
2034
1137e8b8 2035 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2036 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2037
2038 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2039 (bidi_find_paragraph_start): Search back for paragraph beginning
2040 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2041 (bidi_move_to_visually_next): Only trigger paragraph-related
2042 computations when the last character is a newline or at EOB, not
2043 just any NEUTRAL_B. (Bug#9470)
2044
bb187662
EZ
2045 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2046 truncated lines if point is covered by a display string. (Bug#9524)
2047
2e621251
PE
20482011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2051 (cons_to_x_long): New function.
2052 (lisp_data_to_selection_data): Use it. Correct the test for
2053 short-versus-long data; it was negated. Break out of vector
2054 loop, for efficiency, when a long datum is discovered.
2055
91a15bc6
SM
20562011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2057
2058 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2059
b41c3a35
EZ
20602011-09-16 Eli Zaretskii <eliz@gnu.org>
2061
2062 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2063 GCC PR/17406) by declaring this function with external scope.
2064
7812ba2d
PE
20652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2068 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2069
cf7edc2a
AS
20702011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2071
2072 * editfns.c (Fformat): Correctly handle text properties on "%%".
2073
bd01620e
EZ
20742011-09-15 Eli Zaretskii <eliz@gnu.org>
2075
2076 * xterm.c (x_draw_composite_glyph_string_foreground):
2077 * w32term.c (x_draw_composite_glyph_string_foreground):
2078 * term.c (encode_terminal_code):
2079 * composite.c (composition_update_it, get_composition_id):
2080 * xdisp.c (get_next_display_element)
2081 (fill_composite_glyph_string): Add comments about special meaning
2082 of TAB characters in a composition.
2083
a02719a3
PE
20842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2087 This occurs when processing a multibyte format.
2088 Problem reported by Wolfgang Jenker.
a02719a3 2089
72589a3c
JB
20902011-09-15 Johan Bockgård <bojohan@gnu.org>
2091
2092 * xdisp.c (try_cursor_movement): Only check for exact match if
2093 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2094
1c14176c
PE
20952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 Remove unused external symbols.
2098 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2099 * xdisp.c (calc_pixel_width_or_height): Now static.
2100 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2101 * indent.c (check_display_width):
2102 * w32term.c: Fix comment to match code.
2103 * xterm.c, xterm.h (x_catching_errors): Remove.
2104
d2eea5b5
PE
21052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 * xselect.c: Use signed conversions more consistently (Bug#9498).
2108 (selection_data_to_lisp_data): Assume incoming selection data are
2109 signed integers, not unsigned. This is to be consistent with
2110 outgoing selection data, which was modified to use signed integers
2111 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2112 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2113 expects long, not unsigned long.
2114
46888499
EZ
21152011-09-14 Eli Zaretskii <eliz@gnu.org>
2116
2117 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2118 computation of loop end. Reported by Johan Bockgård
2119 <bojohan@gnu.org>.
2120
ef8ef9fb
CY
21212011-09-13 Chong Yidong <cyd@stupidchicken.com>
2122
2123 * frame.c (Fother_visible_frames_p): Function deleted.
2124
fa819fed
EZ
21252011-09-12 Eli Zaretskii <eliz@gnu.org>
2126
2127 * indent.c (compute_motion): Process display vector front to back
2128 rather than the other way around. (Bug#2496)
2129
2ba8e008
SM
21302011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2131
2132 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2133
20f53c69
CY
21342011-09-11 Chong Yidong <cyd@stupidchicken.com>
2135
2136 * minibuf.c (Fread_from_minibuffer): Doc fix.
2137
d562d7a4
EZ
21382011-09-11 Eli Zaretskii <eliz@gnu.org>
2139
2140 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2141 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2142
1c4d7f3d
LMI
21432011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2144
2145 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2146 value for non-existent files.
2147
b885bf36
EZ
21482011-09-11 Eli Zaretskii <eliz@gnu.org>
2149
2150 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2151 set its "size" to -1. This will set the modtime_size field of
2152 the corresponding buffer to -1, which is what
2153 verify-visited-file-modtime expects for files that do not exist.
2154 (Bug#9139)
2155
6612f0bf
PE
21562011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2159 here ...
2160 * lisp.h: ... from here. push_key_description is no longer
2161 defined in keyboard.c, so its declaration should not be in
2162 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2163 logically belongs with push_key_description.
2164
dfb3f755
PE
21652011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 * buffer.h: Include <sys/types.h> instead of <time.h>.
2168 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2169 Problem reported by Herbert J. Skuhra.
2170
3134906c
LMI
21712011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2172
2173 * xml.c (parse_region): Make the parsing work for
2174 non-comment-starting XML files again (bug#9144).
2175
8d903f4e
AS
21762011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2177
2178 * image.c (gif_load): Fix calculation of bottom and right corner.
2179 (Bug#9468)
2180
80ad64f4
EZ
21812011-09-10 Eli Zaretskii <eliz@gnu.org>
2182
2183 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2184 redisplay in small windows.
2185
208a048d
EZ
21862011-09-09 Eli Zaretskii <eliz@gnu.org>
2187
2188 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2189
9b1c252e
MR
21902011-09-08 Martin Rudalics <rudalics@gmx.at>
2191
2192 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2193 Operate on live windows only.
2194
2949f33b
JB
21952011-09-08 Juanma Barranquero <lekktu@gmail.com>
2196
2197 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2198
e08dcafd
EZ
21992011-09-07 Eli Zaretskii <eliz@gnu.org>
2200
2201 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2202 only under bidi iteration.
2203
115b96bd
JD
22042011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2205
2206 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2207
c8199d0f
PE
22082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2211 Without this fix, the command to link temacs failed due to an
2212 undefined symbol __builtin_isnan. This is because
2213 /usr/include/iso/math_c99.h #defines isnan(x) to
2214 __builtin_isnan(x), but the bundled gcc, which identifies itself
2215 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2216 a __builtin_isnan.
2217 * floatfns.c (isnan): #undef, and then #define to a clone of
2218 what's in data.c.
2219 (Fisnan): Always define, since it's always available now.
2220 (syms_of_floatfns): Always define isnan at the Lisp level.
2221
e39b275c 22222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2223
2224 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2225
b2db44d9 22262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2227
f4af5137 2228 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2229 The previous code assumed that file offsets (off_t values) fit in
2230 EMACS_INT variables, which is not true on typical 32-bit hosts.
2231 The code messed up by falsely reporting buffer overflow in cases
2232 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2233 when "big" contains more than 2**29 bytes, even though this
2234 inserts just one byte and does not overflow the buffer.
2235 (Finsert_file_contents): Store file offsets as off_t
2236 values, not as EMACS_INT values. Check for overflow when
2237 converting between EMACS_INT and off_t. When checking for
2238 buffer overflow or for overlap, take the offsets into account.
2239 Don't use EMACS_INT for small values where int suffices.
2240 When checking for overlap, fix a typo: ZV was used where
2241 ZV_BYTE was intended.
2242 (Fwrite_region): Don't assume off_t fits into 'long'.
2243 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2244
ecfc0a49
MA
22452011-09-05 Michael Albinus <michael.albinus@gmx.de>
2246
2247 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2248
6511acf2 22492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2250
0999621a 2251 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2252
2253 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2254 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2255 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2256 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2257 (modify_event_symbol): Do not assume that the length of
2258 name_alist_or_stem is safe to alloca and fits in int.
2259 (Fexecute_extended_command): Likewise for function name and binding.
2260 (Frecursion_depth): Wrap around reliably on integer overflow.
2261 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2262 since some callers pass EMACS_INT values.
2263 (Fsingle_key_description): Don't crash if symbol name contains more
2264 than MAX_ALLOCA bytes.
2265 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2266 (get_minibuffer): Arg is now EMACS_INT, not int.
2267 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2268 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2269 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2270
2be7d702
PE
2271 * dbusbind.c (signature_cat): New function.
2272 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2273 Do not overrun buffer; instead, report string overflow.
2274
9d1df220
PE
2275 * dispnew.c (add_window_display_history): Don't overrun buffer.
2276 Truncate instead; this is OK since it's just a log.
2277
33ef5c64
PE
2278 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2279 even if the time zone offset is outlandishly large.
2280 Don't mishandle offset == INT_MIN.
2281
66c6fdd5
PE
2282 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2283 when creating daemon; the previous buffer-overflow check was incorrect.
2284
d749b01b
PE
2285 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2286 which has the guts of the old verror function.
2287
b5cd1905
PE
2288 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2289 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2290
6e1a67fb
PE
2291 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2292 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2293 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2294 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2295 length of string rather than counting it via multiple sprintfs;
2296 that's simpler and more reliable.
c21721cc
PE
2297 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2298 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2299 sprintf, in case result does not fit in int.
2300
c57b67fc
PE
2301 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2302 (fontset_from_font): Print it.
2303
8a401434
PE
2304 * frame.c (tty_frame_count): Now printmax_t, not int.
2305 (make_terminal_frame, set_term_frame_name): Print it.
2306 (x_report_frame_params): In X, window IDs are unsigned long,
2307 not signed long, so print them as unsigned.
2308 (validate_x_resource_name): Check for implausibly long names,
2309 and don't assume name length fits in 'int'.
2310 (x_get_resource_string): Don't blindly alloca invocation name;
2311 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2312 not fit in int.
2313
6e1a67fb
PE
2314 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2315 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2316 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2317
0df02bf3
PE
2318 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2319 Use esprintf, not sprintf, in case result does not fit in int.
2320
48e30793
PE
2321 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2322 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2323 it as a large positive number.
2324 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2325 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2326
a66ff6d8
PE
2327 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2328 in case result does not fit in int.
2329
aca216ff
PE
2330 * print.c (float_to_string): Detect width overflow more reliably.
2331 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2332 buffer overrun. Don't assume list length fits in 'int'. Treat
2333 print length of 0 as 0, not as infinity; to be consistent with other
2334 uses of print length in this function. Don't overflow print length
2335 index. Don't assume hash table size fits in 'long', or that
2336 vectorlike size fits in 'unsigned long'.
2337
31c286f7
PE
2338 * process.c (make_process): Use printmax_t, not int, to format
2339 process-name gensyms.
2340
55e5faa1
PE
2341 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2342
80f2e268
PE
2343 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2344 to avoid potential buffer overrun.
2345
670741ab
PE
2346 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2347 if X resource line is longer than 512 bytes.
2348
b7163a50
PE
2349 * xfns.c (x_window): Make sprintf buffer a bit bigger
2350 to avoid potential buffer overrun.
2351
ae58ff1f
PE
2352 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2353
c43c8a6a
PE
2354 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2355
3f8236f4
PE
23562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2357
53e9fe90 2358 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2359 Without these, Emacs silently mishandles large integers sometimes.
2360 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2361 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2362
6511acf2
PE
2363 * xdisp.c (try_window_id): Check Emacs fixnum range before
2364 converting to 'int'.
806add1d 2365
6511acf2 2366 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2367 Check that an Emacs fixnum is in range before assigning it to 'int'.
2368 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2369 values converted from Emacs fixnums.
2370 (Frecenter): Don't wrap around a line count if it is out of 'int'
2371 range; instead, treat it as an extreme value.
2372 (Fset_window_configuration, compare_window_configurations):
2373 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2374
6511acf2
PE
2375 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2376 that can exceed INT_MAX. Check that EMACS_INT value is in range
2377 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2378 (match_limit): Don't assume that a fixnum can fit in 'int'.
2379
6511acf2 2380 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2381 exceed INT_MAX.
2382
6511acf2 2383 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2384 (Fvertical_motion): Don't wrap around LINES values that don't fit
2385 in 'int'. Instead, treat them as extreme values. This is good
2386 enough for windows, which can't have more than INT_MAX lines anyway.
2387
fcb901a7
LMI
23882011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2389
0f2f6b6d
LMI
2390 * Require libxml/parser.h to avoid compilation warning.
2391
fcb901a7
LMI
2392 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2393
2394 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2395 since this reportedly can destroy thread storage.
2396
6e20a0d4
CY
23972011-08-30 Chong Yidong <cyd@stupidchicken.com>
2398
2399 * syntax.c (find_defun_start): Update all cache variables if
2400 exiting early (Bug#9401).
2401
148ae00e
EZ
24022011-08-30 Eli Zaretskii <eliz@gnu.org>
2403
f6cfbd8f
EZ
2404 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2405
148ae00e
EZ
2406 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2407 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2408 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2409
2410 * term.c (tty_append_glyph): New function.
2411 (produce_stretch_glyph): Static function and its prototype deleted.
2412
a66cfb1c
SM
2413 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2414 Add prototypes.
148ae00e 2415
c4a07a4c
PE
24162011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2419 when checking :margin (Bug#9390).
2420 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2421 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2422 so that the name doesn't mislead. All uses changed.
2423
6bc8cd65
JB
24242011-08-28 Johan Bockgård <bojohan@gnu.org>
2425
2426 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2427 set_tty_hooks.
2428
dca4927e
EZ
24292011-08-27 Eli Zaretskii <eliz@gnu.org>
2430
2431 * xdisp.c (move_it_to): Don't bail out early when reaching
2432 position beyond to_charpos, if we are scanning backwards.
2433 (move_it_vertically_backward): When DY == 0, make sure we get to
2434 the first character in the line after the newline.
2435
f2cad773
PE
24362011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2439 (ccl_driver): Do not generate an out-of-range pointer.
2440 (Fccl_execute_on_string): Remove unnecessary check for
2441 integer overflow, noted by Stefan Monnier in
2442 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2443 Remove a FIXME that didn't need fixing.
2444 Simplify the newly-introduced buffer reallocation code.
2445
0cae2cdb
JB
24462011-08-27 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2449
5fc295a4 24502011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2451
70c60eb2 2452 Integer and memory overflow issues (Bug#9196).
726e0ab1 2453
d31850da
PE
2454 * doc.c (get_doc_string): Rework so that
2455 get_doc_string_buffer_size is the actual buffer size, rather than
2456 being 1 less than the actual buffer size; this makes xpalloc more
2457 convenient.
2458
a69fbedb
PE
2459 * image.c (x_allocate_bitmap_record, cache_image):
2460 * xselect.c (Fx_register_dnd_atom):
2461 Simplify previous changes by using xpalloc.
2462
fe5c5d37
PE
2463 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2464 since either will do and ptrdiff_t is convenient with xpalloc.
2465
0065d054
PE
2466 * charset.c (charset_table_size)
2467 (struct charset_sort_data.priority): Now ptrdiff_t.
2468 (charset_compare): Don't overflow if priorities differ greatly.
2469 (Fsort_charsets): Don't assume list length fits in int.
2470 Check for size-calculation overflow when allocating sort data.
2471 (syms_of_charset): Allocate an initial charset table that is
2472 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2473
2474 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2475
2476 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2477 The actual value is always <= INT_MAX, and leaving it unsigned made
2478 overflow checking harder.
2479
2480 * dispextern.h (struct glyph_matrix.rows_allocated)
2481 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2482 with xpalloc. The values are still always <= INT_MAX.
2483
2484 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2485
2486 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2487 (SAFE_NALLOCA): New macro.
2488
2489 * region-cache.c (struct boundary.pos, find_cache_boundary)
2490 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2491 (set_cache_region, invalidate_region_cache)
2492 (revalidate_region_cache, know_region_cache, region_cache_forward)
2493 (region_cache_backward, pp_cache):
2494 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2495 so that ptrdiff_t * can be passed to xpalloc.
2496 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2497 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2498 (pp_cache): Don't assume cache_len fits in int.
2499 * region-cache.h: Adjust extern decls to match.
2500
2501 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2502 EMACS_INT, since either will do, for xpalloc.
2503
2504 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2505 (xnmalloc, xnrealloc, xpalloc): New functions.
2506
726e0ab1
PE
2507 * bidi.c (bidi_shelve_header_size): New constant.
2508 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2509 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2510
51f30bc5 2511 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2512 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2513 (overlay_strings):
2514 Don't update size of array until after memory allocation succeeds,
2515 because xmalloc/xrealloc may not return.
0065d054
PE
2516 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2517 now that we have proper integer overflow checking.
2518 (record_overlay_string, overlay_strings): Catch overflows when
2519 calculating size of overlay_str_buf.
726e0ab1 2520
0065d054
PE
2521 * callproc.c (Fcall_process): Check for size overflow when
2522 calculating size of args2.
2523 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2524 Normally we prefer signed values, but sticking with ptrdiff_t would
2525 require adding more-complicated checks.
726e0ab1
PE
2526
2527 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2528 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2529 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2530 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2531
2532 * character.c (Fstring): Check for size-calculation overflow.
2533
2534 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2535 unnecessary integer overflow. Check for size overflow.
2536 (encode_coding_object): Don't update size until xmalloc succeeds.
2537
2538 * composite.c (get_composition_id): Check for overflow in glyph
2539 length calculations.
2540
2541 Integer and memory overflow fixes for display code.
2542 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2543 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2544 (scrolling_window): Check for overflow in size calculations.
2545 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2546 Don't assume glyph table len fits in int.
2547 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2548 (row_table_size): Now ptrdiff_t, not int.
2549 (scrolling_window): Avoid overflow in size calculations.
2550 Don't update size until allocation succeeds.
2551 * fns.c (concat): Check for overflow in size calculations.
2552 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2553 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2554 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2555
2556 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2557 (get_doc_string): Check for size calculation overflow.
2558 Don't update size until allocation succeeds.
2559 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2560 EMACS_INT, where ptrdiff_t will do.
2561 (Fsubstitute_command_keys): Check for string overflow.
2562
2563 * editfns.c (set_time_zone_rule): Don't assume environment length
2564 fits in int.
2565 (message_length): Now ptrdiff_t, not int.
2566 (Fmessage_box): Don't update size until allocation succeeds.
2567 Don't assume message length fits in int.
2568 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2569
0065d054
PE
2570 * emacs.c (main): Do not reallocate argv, since there is a null at
2571 the end that can be overwritten, and this way there's no need to
2572 worry about size-calculation overflow.
2573 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2574
2575 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2576 alloc succeeds.
2577 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2578
2579 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2580 (x_set_scroll_bar_width, x_figure_window_size):
2581 Check for integer overflow.
2582 (x_set_alpha): Do not assume XINT fits in int.
2583
2584 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2585 This is for the members text_lines, text_cols, total_lines, total_cols,
2586 where the system imposes an 'int' limit.
2587
2588 * fringe.c (Fdefine_fringe_bitmap):
2589 Don't update size until alloc works.
2590
2591 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2592 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2593
2594 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2595 Check for size-calculation overflow.
2596 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2597 do, as we prefer signed integers.
2598 (id_to_widget.max_size, id_to_widget.used)
2599 (xg_store_widget_in_map, xg_remove_widget_from_map)
2600 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2601 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2602 Use and return ptrdiff_t, not int.
2603 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2604 * gtkutil.h: Change prototypes to match the above.
2605
2606 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2607 are duplicate now that they've been promoted to lisp.h.
2608 (x_allocate_bitmap_record, x_alloc_image_color)
2609 (make_image_cache, cache_image, xpm_load):
2610 Don't update size until alloc is done.
2611 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2612 (x_detect_edges):
3256efce 2613 Check for size calculation overflow.
726e0ab1
PE
2614 (ct_colors_allocated_max): New constant.
2615 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2616 overflow.
3256efce 2617
726e0ab1
PE
2618 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2619 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2620 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2621 Use ptrdiff_t, not int, to count maps.
2622 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2623 calculations. Don't update size until allocation succeeds.
2624 Redo calculations to avoid overflow.
726e0ab1
PE
2625 * keyboard.h: Change prototypes to match the above.
2626
2627 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2628 to count maps.
2629 (current_minor_maps): Check for size calculation overflow.
2630 * keymap.h: Change prototypes to match the above.
2631
2632 * lread.c (read1, init_obarray): Don't update size until alloc done.
2633
2634 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2635 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2636
726e0ab1
PE
2637 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2638 Now ptrdiff_t, not int.
2639 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2640 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2641
2642 * process.c (Fnetwork_interface_list): Check for overflow
2643 in size calculation.
2644
2645 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2646
2647 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2648 overflow. Don't bother calling xmalloc when xrealloc will do.
2649
2650 * search.c (Freplace_match): Check for size calculation overflow.
2651 (Fset_match_data): Don't assume list lengths fit in 'int'.
2652
2653 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2654 for command line length. Do not attempt to address one before the
2655 beginning of an array, as that's not portable.
2656
2657 * term.c (max_frame_lines): Remove; unused.
2658 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2659 not int.
2660 (encode_terminal_code, calculate_costs): Check for size
2661 calculation overflow.
2662 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2663 table lengths and related sizes. Don't update size until alloc
2664 done. Redo calculations to avoid overflow.
2665 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2666
2667 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2668 subtracting pointers.
2669 (gobble_line): Check for overflow more carefully. Don't update size
2670 until alloc done.
2671
2672 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2673 Don't update size until alloc done.
2674 Redo size calculations to avoid overflow.
2675 Check for size calculation overflow.
0065d054 2676 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2677
2678 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2679 Use ptrdiff_t, not int, for sizes.
2680 (store_mode_line_noprop_char): Don't update size until alloc done.
2681
0065d054
PE
2682 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2683 Use ptrdiff_t, not int, for sizes.
2684 (Finternal_make_lisp_face, cache_face):
2685 Check for size calculation overflow.
2686 (cache_face): Treat size calculation overflows as if they were
2687 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2688
2689 * xfns.c (x_encode_text, x_set_name_internal)
2690 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2691 sizes, since they can exceed INT_MAX in size. Check for size
2692 calculation overflow.
2693
0065d054
PE
2694 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2695 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2696 Don't update size until alloc done.
2697
0065d054 2698 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2699 as sprintf is limited to int lengths.
1d526e2f 2700
252c5ee1
PE
2701 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2702 (X_LONG_MIN): New macros.
864d7ce7
PE
2703 Use them to make the following changes clearer.
2704 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2705 This change doesn't affect the value now, but it may help remind
2706 future maintainers not to raise the value too much later.
2707 (SELECTION_QUANTUM): Remove, replacing with ...
2708 (selection_quantum): ... new function, which avoids overflow.
2709 All uses changed.
2710 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2711 assumption that selection length fits in 'int'.
2712 (x_reply_selection_request, x_handle_selection_request)
2713 (x_get_window_property, receive_incremental_selection)
2714 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2715 (lisp_data_to_selection_data, clean_local_selection_data):
2716 Use ptrdiff_t, not int, to record length of selection.
2717 (x_reply_selection_request, x_get_window_property)
2718 (receive_incremental_selection, x_property_data_to_lisp):
2719 Redo calculations to avoid overflow.
2720 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2721 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2722 something.
2723 (x_get_window_property, receive_incremental_selection)
2724 (lisp_data_to_selection_data, x_property_data_to_lisp):
2725 Check for size-calculation overflow.
2726 (x_get_window_property, receive_incremental_selection)
2727 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2728 Don't store size until memory allocation succeeds.
2729 (x_get_window_property): Plug memory leak on memory exhaustion.
2730 Don't double-block input; malloc is safe here. Don't assume 2**34
2731 - 4 fits in unsigned long. Add an xassert to check
2732 XGetWindowProperty overflow. Be more careful about overflow
2733 calculations, and distinguish size from memory overflow better.
2734 (receive_incremental_selection): When tracing, don't assume
2735 unsigned int is less than INT_MAX.
2736 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2737 harmful) conversions of unsigned short to int.
2738 (lisp_data_to_selection_data): Don't assume that integers
2739 in the range -65535 through -1 fit in an X unsigned short.
2740 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2741 result parameters unless successful. Rely on cons_to_unsigned
2742 to report problems with elements; the old code wasn't right anyway.
2743 (x_check_property_data): Check for int overflow; we cannot use
2744 a wider type due to X limits.
2745 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2746
726e0ab1 2747 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2748
0065d054
PE
2749 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2750 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2751 (x_color_cells): Don't store size until memory allocation succeeds.
2752 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2753 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2754 (x_term_init): Don't assume length fits in int (sprintf is limited
2755 to int size).
bc18e09d 2756
ebfa62c0
PE
2757 Use ptrdiff_t for composition IDs.
2758 * character.c (lisp_string_width):
2759 * composite.c (composition_table_size, n_compositions)
2760 (get_composition_id, composition_gstring_from_id):
2761 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2762 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2763 * window.c (Frecenter):
2764 Use ptrdiff_t, not int, for composition IDs.
2765 * composite.c (get_composition_id): Check for integer overflow.
2766 * composite.h: Adjust prototypes to match the above changes.
2767
d3411f89
PE
2768 Use ptrdiff_t for hash table indexes.
2769 * category.c (hash_get_category_set):
2770 * ccl.c (ccl_driver):
2771 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2772 * coding.c (coding_system_charset_list, detect_coding_system):
2773 * coding.h (struct coding_system.id):
2774 * composite.c (get_composition_id, gstring_lookup_cache):
2775 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2776 * image.c (xpm_get_color_table_h):
2777 * lisp.h (hash_lookup, hash_put):
2778 * minibuf.c (Ftest_completion):
2779 Use ptrdiff_t for hash table indexes, not int (which is too
2780 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2781 32-bit --with-wide-int hosts).
2782
e097a6fa
PE
2783 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2784 Add a FIXME comment about memory leaks.
2785 (syms_of_charset): Don't assume xmalloc returns.
2786
5637687f
PE
2787 Don't assume that stated character widths fit in int.
2788 * character.c (Fchar_width, c_string_width, lisp_string_width):
2789 * character.h (CHAR_WIDTH):
2790 * indent.c (MULTIBYTE_BYTES_WIDTH):
2791 Use sanitize_char_width to avoid undefined and/or bad behavior
2792 with outlandish widths.
a66cfb1c 2793 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2794 now that we have two such functions. All uses changed.
2795 (sanitize_char_width): New inline function.
2796
a2271ba2
PE
2797 Don't assume that tab-width fits in int.
2798 * character.h (sanitize_width): New inline function.
2799 (SANE_TAB_WIDTH): New macro.
2800 (ASCII_CHAR_WIDTH): Use it.
2801 * indent.c (sane_tab_width): Remove. All uses replaced by
2802 SANE_TAB_WIDTH (current_buffer).
2803 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2804
18c52557
PE
2805 * fileio.c: Integer overflow issues with file modes.
2806 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2807
caeeedc1
PE
2808 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2809 Remove unreachable code.
2810 (read_hex, load_charset_map_from_file): Check for integer overflow.
2811
6df6ae42 2812 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2813 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2814 (x_send_scroll_bar_event): Likewise. Check that the size does not
2815 exceed limits imposed by XClientMessageEvent, as well as the usual
2816 ptrdiff_t and size_t limits.
2817
b13995db
PE
2818 * keyboard.c: Overflow, signedness and related fixes.
2819 (make_lispy_movement): Use same integer type in forward decl
2820 that is used in the definition.
2821 (read_key_sequence, keyremap_step):
2822 Change bufsize argument back to int, undoing my 2011-03-30 change.
2823 We prefer signed types, and int is wide enough here.
2824 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2825 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2826 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2827 length, not size_t. Use ptrdiff_t for index, not int.
2828 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2829 possibility of integer overflow.
2830
13464394
PE
2831 Overflow, signedness and related fixes for images.
2832
2833 * dispextern.h (struct it.stack[0].u.image.image_id)
2834 (struct_it.image_id, struct image.id, struct image_cache.size)
2835 (struct image_cache.used, struct image_cache.ref_count):
2836 * gtkutil.c (update_frame_tool_bar):
2837 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2838 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2839 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2840 * nsmenu.m (update_frame_tool_bar):
2841 * xdisp.c (calc_pixel_width_or_height):
2842 * xfns.c (image_cache_refcount):
2843 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2844 on typical 64-bit hosts.
2845
2846 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2847 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2848 Omit unnecessary casts to int.
2849 (parse_image_spec): Check that integers fall into 'int' range
2850 when the callers expect that.
2851 (image_ascent): Redo ascent calculation to avoid int overflow.
2852 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2853 (lookup_image): Remove unnecessary tests.
2854 (xbm_image_p): Locals are now of int, not EMACS_INT,
2855 since parse_image_check makes sure they fit into int.
2856 (png_load, gif_load, svg_load_image):
2857 Prefer int to unsigned where either will do.
2858 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2859 old tiff_error_handler and tiff_warning_handler.
2860 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2861 stack buffer overflows. It uses only the features of vsnprintf
2862 that are common to both POSIX and native Microsoft.
2863 (tiff_error_handler, tiff_warning_handler): Use it.
2864 (tiff_load, gif_load, imagemagick_load_image):
2865 Don't assume :index value fits in 'int'.
2866 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2867 (imagemagick_load_image): Check that crop parameters fit into
2868 the integer types that MagickCropImage accepts. Don't assume
2869 Vimagemagick_render_type has a nonnegative value. Don't assume
2870 size_t fits in 'long'.
2871 (gs_load): Use printmax_t to print the widest integers possible.
2872 Check for integer overflow when computing image height and width.
2873
c11821d4
EZ
28742011-08-26 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (redisplay_window): Don't force window start if point
2877 will be invisible in the resulting window. (Bug#9324)
2878
0c95fcf7
EZ
28792011-08-25 Eli Zaretskii <eliz@gnu.org>
2880
2881 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2882 the display spec is of the form `(space ...)'.
2883 (handle_display_spec): Return the value returned by
2884 handle_single_display_spec, not just 1 or zero.
2885 (handle_single_display_spec): If the display spec is of the form
2886 `(space ...)', and specifies display in the text area, return 2
2887 rather than 1.
fee65a97 2888 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2889 accurately, and prefer exact match for point under bidi.
2890 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2891
2892 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2893 into disp_prop; all users changed.
2894
2895 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2896 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2897 for the text covered by the display property.
2898
e4ed06f1
CY
28992011-08-25 Chong Yidong <cyd@stupidchicken.com>
2900
2901 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2902 Change return value to nil.
2903 (Frecord_buffer): Delete unused function.
2904
f67cdd7f
EZ
29052011-08-24 Eli Zaretskii <eliz@gnu.org>
2906
5980d4c6
EZ
2907 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2908 buffers, return left-to-right.
8610fe8b
EZ
2909 (set_cursor_from_row): Consider candidate row a win if its glyph
2910 represents a newline and point is on that newline. Fixes cursor
2911 positioning on the newline at EOL of R2L text within L2R
2912 paragraph, and vice versa.
2913 (try_cursor_movement): Check continued rows, in addition to
2914 continuation rows. Fixes unwarranted scroll when point enters a
2915 continued line of R2L text within an L2R paragraph, or vice versa.
2916 (cursor_row_p): Consider the case of point being equal to
2917 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2918 from the end of a short line to the beginning of a continued line
2919 of R2L text within L2R paragraph.
2920 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2921 composed characters.
5980d4c6 2922
f67cdd7f
EZ
2923 * bidi.c (bidi_check_type): Use xassert.
2924 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2925 members.
2926
bca633fb
EZ
29272011-08-23 Eli Zaretskii <eliz@gnu.org>
2928
2929 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2930 a character.
2931
4a5885a7
CY
29322011-08-23 Chong Yidong <cyd@stupidchicken.com>
2933
2934 * nsfont.m (ns_otf_to_script): Fix typo.
2935
0902a04e
KH
29362011-08-22 Kenichi Handa <handa@m17n.org>
2937
2938 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2939 extra slot even if the purpose is char-code-property-table.
2940
1a2e6670
EZ
29412011-08-23 Eli Zaretskii <eliz@gnu.org>
2942
8ddde651
EZ
2943 * xdisp.c (redisplay_window): When computing centering_position,
2944 account for the height of the header line. (Bug#8874)
2945
425cc014
EZ
2946 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2947 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2948 candidate is selected by the mouse, and that candidate has a
2949 composed character under the mouse.
2950
1a2e6670
EZ
2951 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2952 coordinates reported by pos-visible-in-window-p for a composed
2953 character in column zero.
2954
8b76d6f8
SM
29552011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2956
2957 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2958
dac347dd
EZ
29592011-08-22 Eli Zaretskii <eliz@gnu.org>
2960
2961 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2962 consider it a hit if to_charpos is anywhere in the range of the
2963 composed buffer positions.
2964
e013fb34
CY
29652011-08-22 Chong Yidong <cyd@stupidchicken.com>
2966
2967 * image.c (gif_load): Don't assume that each subimage has the same
2968 dimensions as the base image. Handle disposal method that is
2969 "undefined" by the gif spec (Bug#9335).
2970
bd1ba3e8
CY
29712011-08-20 Chong Yidong <cyd@stupidchicken.com>
2972
2973 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2974 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2975
54a1215b
EZ
29762011-08-19 Eli Zaretskii <eliz@gnu.org>
2977
823564e5
EZ
2978 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2979 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2980 from an Org mode buffer to a Speedbar frame.
2981
54a1215b
EZ
2982 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2983 a composition, take its buffer position from IT->cmp_it.charpos.
2984 Fixes cursor positioning at the beginning of a line that begins
2985 with a composed character.
2986
9778ebcc
EZ
29872011-08-18 Eli Zaretskii <eliz@gnu.org>
2988
0be6ee06
EZ
2989 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2990 character bidirectional type, use STRONG_L instead. Fixes crashes
2991 in a buffer produced by `describe-categories'.
2992
9778ebcc
EZ
2993 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2994 members before the level stack, so they would be saved and
2995 restored when copying iterator state. Fixes incorrect reordering
2996 around TABs covered by display properties.
2997
156bffbe
AS
29982011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2999
6b02f655 3000 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3001
72ad093b
CY
30022011-08-17 Chong Yidong <cyd@stupidchicken.com>
3003
3004 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3005 (internal_condition_case_2, internal_condition_case_n):
3006 Remove unnecessary aborts (Bug#9081).
72ad093b 3007
35774242
EZ
30082011-08-17 Eli Zaretskii <eliz@gnu.org>
3009
3010 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3011 has no `load' handler, try opening the file locally. (Bug#9311)
3012
db76dd85
KB
30132011-08-16 Ken Brown <kbrown@cornell.edu>
3014
3015 * gmalloc.c: Expand comment.
3016
b215eee5
EZ
30172011-08-16 Eli Zaretskii <eliz@gnu.org>
3018
3019 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3020 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3021
a4579d33
KB
30222011-08-16 Ken Brown <kbrown@cornell.edu>
3023
3024 Fix memory allocation problems in Cygwin build (Bug#9273).
3025
3026 * unexcw.c ( __malloc_initialized): Declare external variable.
3027 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3028
8b76d6f8
SM
3029 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3030 New variables.
a4579d33
KB
3031 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3032 dumped emacs.
3033 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3034 in the static heap.
3035 [CYGWIN] (special_realloc): New function.
3036 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3037 requests to realloc storage in the static heap.
3038
3ebec551
PE
30392011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3040
3041 * bidi.c (bidi_initialize): Remove unused local.
3042
9fd8be00
EZ
30432011-08-15 Eli Zaretskii <eliz@gnu.org>
3044
6b02f655
SM
3045 * bidimirror.h:
3046 * biditype.h: Remove file.
3047 * makefile.w32-in ($(BLD)/bidi.$(O)):
3048 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3049
3050 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3051
3052 * chartab.c: Improve commentary for the uniprop_table API.
3053
32413314
EZ
3054 * bidi.c (bidi_paragraph_init): Support zero value of
3055 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3056 (bidi_initialize): Use uniprop_table instead of including
3057 biditype.h and bidimirror.h.
32413314 3058
9fd8be00
EZ
3059 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3060 coordinates of the iterator when restoring from ppos_it.
3061 (Bug#9296)
3062
5cf2b69b
KH
30632011-08-14 Kenichi Handa <handa@m17n.org>
3064
3065 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3066 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3067
daf17d00
EZ
30682011-08-14 Eli Zaretskii <eliz@gnu.org>
3069
3070 * xdisp.c (move_it_in_display_line_to): Don't invoke
3071 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3072 ppos_it. Fixes vertical cursor motion when line beginning is
3073 covered by an image. (Bug#9296)
3074
08e3161a
JD
30752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3076
3077 * nsterm.h (ns_run_ascript): Declare.
3078 (NSAPP_DATA2_RUNASSCRIPT): Define.
3079
3080 * nsfns.m (as_script, as_result, as_status): New static variables.
3081 (ns_run_ascript): New function.
5e617bc2 3082 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3083 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3084 the event loop. Get status from as_status (Bug#7276).
3085
3086 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3087 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3088 the event loop (Bug#7276).
3089
a3720aa2
AS
30902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3091
3092 * gnutls.c (QCgnutls_bootprop_priority)
3093 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3094 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3095 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3096 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3097 (QCgnutls_bootprop_verify_hostname_error)
3098 (QCgnutls_bootprop_callbacks_verify): Rename from
3099 Qgnutls_bootprop_..., all uses changed.
3100
3101 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3102 uses changed.
3103
0a0d27fb
PE
31042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3105
19d5c50c
PE
3106 * xfaces.c (Qframe_set_background_mode): Now static.
3107 * dispextern.h (Qframe_set_background_mode): Remove decl.
3108
0a0d27fb
PE
3109 * process.c (Fnetwork_interface_info): Declare local only if needed.
3110
377538cb
JD
31112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3112
3113 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3114 (Fnetwork_interface_list): Allocate in increments of bytes instead
3115 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3116 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3117 sockaddr.
3118 (struct ifflag_def): notrailers is smart on OSX.
3119 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3120 Get hardware address with getifaddrs if available.
3121
08fff70c
EZ
31222011-08-12 Eli Zaretskii <eliz@gnu.org>
3123
3124 * xdisp.c (iterate_out_of_display_property): xassert that
3125 IT->position is set to within IT->object's boundaries. Break from
3126 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3127 when IT->position is set up wrongly due to some bug.
3128 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3129 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3130 entry. Force push_it to save on the stack the current
3131 buffer/string position, to be restored by pop_it. Fix flags in
3132 the iterator structure wrt the object coming from a display
3133 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3134 properties. (Bug#9284)
3135
7be1c708 31362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3137
7be1c708
CY
3138 * fontset.c (fontset_get_font_group): Add proper type checks.
3139 (Bug#9172)
aac0c6e3 3140
7be1c708 31412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3142
7be1c708
CY
3143 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3144 and LC_VERSION_MIN_MACOSX.
3145 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3146 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3147
97bb72a6
EZ
31482011-08-08 Eli Zaretskii <eliz@gnu.org>
3149
3150 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3151 no-display-properties-and-no-overlays under bidi display.
3152 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3153 properties and overlays.
97bb72a6 3154
d5617611
CY
31552011-08-08 Chong Yidong <cyd@stupidchicken.com>
3156
37e11a63
CY
3157 * editfns.c (Fset_time_zone_rule): Document relationship with the
3158 setenv function.
3159
d5617611
CY
3160 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3161 the font entity extracted from the cache (Bug#8109).
3162
58872834
CY
31632011-08-07 Chong Yidong <cyd@stupidchicken.com>
3164
3165 * composite.c (autocmp_chars): Don't reset point. That is done by
3166 restore_point_unwind (Bug#5984).
3167
75bfc667
JL
31682011-08-07 Juri Linkov <juri@jurta.org>
3169
3170 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3171 to show the arg `TIME' instead of `TIMEVAL'.
3172
d1410150
EZ
31732011-08-06 Eli Zaretskii <eliz@gnu.org>
3174
3175 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3176 display property strides EOL and includes a newline, as in
3177 longlines-mode. (Bug#9254)
75b771e4
EZ
3178 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3179 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3180
3181 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3182 is non-zero, even if the data buffer is NULL. Fixes a crash in
3183 vertical-motion with longlines-mode. (Bug#9254)
3184
35928349
EZ
31852011-08-05 Eli Zaretskii <eliz@gnu.org>
3186
ec7cc85b
EZ
3187 * bidi.c <bidi_cache_total_alloc>: Now static.
3188 (bidi_initialize): Initialize bidi_cache_total_alloc.
3189
8b76d6f8 3190 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3191 cache. (Bug#9221)
3192
3193 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3194 amount allocated this far in `bidi_cache_total_alloc'.
3195 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3196 non-zero, only free the data buffer without restoring the cache
3197 contents. All callers changed.
3198
3199 * dispextern.h (bidi_unshelve_cache): Update prototype.
3200
3201 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3202 (move_it_in_display_line, move_it_to)
3203 (move_it_vertically_backward, move_it_by_lines): Replace the call
3204 to xfree to an equivalent call to bidi_unshelve_cache.
3205 (move_it_in_display_line_to): Fix logic of returning
412b6358 3206 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3207
e2e2423b
EZ
32082011-08-05 Eli Zaretskii <eliz@gnu.org>
3209
3210 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3211 came from a string character with a `cursor' property. (Bug#9229)
3212
ae9e757a
JD
32132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3214
3215 * Makefile.in (LIB_PTHREAD): New variable.
3216 (LIBES): Add LIB_PTHREAD (Bug#9216).
3217
3218 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3219 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3220
213bd7f2
AS
32212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3222
6b02f655 3223 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3224
99aaf75f
JD
32252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3226
3227 * xterm.c (x_find_topmost_parent): New function.
3228 (x_set_frame_alpha): Find topmost parent window with
3229 x_find_topmost_parent and set the property there also (bug#9181).
3230 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3231
c74e9d86
PE
32322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3233
3234 * callproc.c (Fcall_process): Avoid vfork clobbering
3235 the local vars buffer, coding_systems, current_dir.
3236
640c8776
SM
32372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3238
3239 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3240
f26d0e4c
PE
32412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3242
8a10d76c
PE
3243 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3244 so that it is not optimized away.
3245
f26d0e4c
PE
3246 * xdisp.c (compute_display_string_pos): Remove unused local.
3247
55439c61
EZ
32482011-08-02 Eli Zaretskii <eliz@gnu.org>
3249
3250 Fix slow cursor motion and scrolling in large buffers with
3251 selective display, like Org Mode buffers. (Bug#9218)
3252
3253 * dispextern.h (struct bidi_it): New member disp_prop_p.
3254
3255 * xdisp.c: Remove one-slot cache of display string positions.
3256 (compute_display_string_pos): Accept an additional argument
5e617bc2 3257 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3258 for a display string or property. If found, set DISP_PROP_P
3259 non-zero.
3260
3261 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3262 DISP_PROP_P, and pass it to compute_display_string_pos.
3263 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3264 non-zero. All callers of bidi_fetch_char changed.
3265
fb33fa43
SM
32662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3267
3268 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3269
b099e063
DM
32702010-12-03 Don March <don@ohspite.net>
3271
3272 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3273 last character M-[char] is translated to ESC [char] (bug#7541).
3274
5cc7f7af
KH
32752011-08-02 Kenichi Handa <handa@m17n.org>
3276
d0fffa3f 3277 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3278
3279 * chartab.c (uniprop_table): Make it non-static.
3280
525d5e6e
EZ
32812011-08-01 Eli Zaretskii <eliz@gnu.org>
3282
3283 * xdisp.c (forward_to_next_line_start): Accept additional argument
3284 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3285 on the newline.
3286 (reseat_at_next_visible_line_start): Use the bidi iterator state
3287 returned by forward_to_next_line_start to restore the state of
3288 it->bidi_it after backing up to previous newline. (Bug#9212)
3289
31011111
AS
32902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3291
3292 * regex.c (re_comp): Protoize.
3293 (re_exec): Fix return type.
3294 (regexec): Fix type of `ret'. (Bug#9203)
3295
476371c4
PE
32962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3297
e5d76069
PE
3298 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3299 This is needed if max-image-size is a floating-point number.
3300
9a79b20c
AS
33012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3302
3303 * print.c (print_object): Print empty symbol as ##.
3304
3305 * lread.c (read1): Read ## as empty symbol.
3306
d8c2fa78
AA
33072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3308
3309 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3310 setting frame foreground color (Bug#9175).
3311 (x_set_background_color): Likewise.
3312
ffe57a7a
AA
3313 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3314 contents (Bug#9176).
3315 (EmacsTooltip -init): Remove bezels and add shadows to
3316 tooltip windows.
3317
bf3492a5
AA
3318 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3319 or scroll bar (Bug#8470).
3320
d55e9c53
AA
3321 * nsfont.m (nsfont_open): Remove assignment to voffset and
3322 unnecessary vars hshink, expand, hd, full_height, min_height.
3323 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3324
3325 * nsterm.h (nsfont_info): Remove voffset field.
3326
d8c2fa78 33272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3328
3329 Implement strike-through and overline on NextStep (Bug#8863).
3330
3331 * nsfont.m (nsfont_open): Use underline position provided by font,
3332 instead of hard-coded value of 2.
3333 (nsfont_draw): Call ns_draw_text_decoration instead.
3334
3335 * nsterm.h: Add declaration for ns_draw_text_decoration.
3336
3337 * nsterm.m (ns_draw_text_decoration): New function for drawing
3338 underline, overline, and strike-through.
3339 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3340 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3341 accommodate underlining, etc.
4843aac3 3342
4cc60b9b
EZ
33432011-07-28 Eli Zaretskii <eliz@gnu.org>
3344
bc7ece87
EZ
3345 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3346 default.
4cc60b9b 3347
476371c4
PE
33482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3349
66606eea
PE
3350 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3351 Without this fix, if a signal arrives just after memory fills up,
3352 'malloc' might be invoked reentrantly.
3353
476371c4
PE
3354 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3355 In other words, assume that every image size is allowed, on non-X
3356 hosts. This assumption is probably wrong, but it lets Emacs compile.
3357
f3fcc40d
AS
33582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3359
3360 * regex.c (re_iswctype): Convert return values to boolean.
3361
350c992f
EZ
33622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3363
3364 * xdisp.c (compute_display_string_pos): Don't use cached display
3365 string position if the buffer had its restriction changed.
3366 (Bug#9184)
3367
5266b4bb
PE
33682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3369
3370 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3371
2573a837 33722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3373
41f55ccd 3374 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3375
39e378da
PE
3376 * bidi.c: Integer size and overflow fixes.
3377 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3378 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3379 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3380 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3381 (bidi_find_other_level_edge):
3382 Use ptrdiff_t instead of EMACS_INT where either will do.
3383 This works better on 32-bit hosts configured --with-wide-int.
3384 (bidi_cache_ensure_space): Check for size-calculation overflow.
3385 Use % rather than repeated addition, for better worst-case speed.
3386 Don't set bidi_cache_size until after xrealloc returns, because it
3387 might not return.
3388 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3389 (bidi_cache_ensure_space): Also check that the bidi cache size
3390 does not exceed that of the largest Lisp string or buffer. See Eli
3391 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3392
5e927815
PE
3393 * alloc.c (__malloc_size_t): Remove.
3394 All uses replaced by size_t. See Andreas Schwab's note
3395 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3396
ca4aa935
PE
3397 * image.c: Improve checking for integer overflow.
3398 (check_image_size): Assume that f is nonnull, since
3399 it is always nonnull in practice. This is one less thing to
3400 worry about when checking for integer overflow later.
3401 (x_check_image_size): New function, which checks for integer
3402 overflow issues inside X.
3403 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3404 This removes the need for a memory_full check.
3405 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3406 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3407 (xbm_read_bitmap_data): Change locals back to 'int', since
3408 their values must fit in 'int'.
3409 (xpm_load_image, png_load, tiff_load):
3410 Invoke x_create_x_image_and_pixmap earlier,
3411 to avoid much needless work if the image is too large.
3412 (tiff_load): Treat overly large images as if
3413 x_create_x_image_and_pixmap failed, not as malloc failures.
3414 (gs_load): Use x_check_image_size.
3415
5f8f9cc2
PE
3416 * gtkutil.c: Omit integer casts.
3417 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3418 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3419
5adf60bc
PE
3420 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3421
c8907a93
PE
3422 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3423 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3424 would wrongly return t on a 64-bit host.
3425
e3c25c68
PE
3426 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3427 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3428 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3429 and therefore cause GCC to emit a bogus diagnostic in some cases.
3430
3f791afe
PE
3431 * image.c: Integer signedness and overflow and related fixes.
3432 This is not an exhaustive set of fixes, but it's time to
3433 record what I've got.
3434 (lookup_pixel_color, check_image_size): Remove redundant decls.
3435 (check_image_size): Don't assume that arbitrary EMACS_INT values
3436 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3437 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3438 (tiff_load, imagemagick_load_image):
3439 Check for overflow in size calculations.
3440 (x_create_x_image_and_pixmap): Remove unnecessary test for
3441 xmalloc returning NULL; that can't happen.
3442 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3443 (xpm_color_bucket): Use better integer hashing function.
3444 (xpm_cache_color): Don't possibly over-allocate memory.
3445 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3446 (gif_memory_source):
3447 Use ptrdiff_t, not int or size_t, to record sizes.
3448 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3449 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3450 either works, as we prefer signed integers.
3451 (tiff_read_from_memory, tiff_write_from_memory):
3452 Return tsize_t, not size_t, since that's what the TIFF API wants.
3453 (tiff_read_from_memory): Don't fail simply because the read would
3454 go past EOF; instead, return a short read.
3455 (tiff_load): Omit no-longer-needed casts.
3456 (Fimagemagick_types): Don't assume size fits into 'int'.
3457
3cc5a532
PE
3458 Improve hashing quality when configured --with-wide-int.
3459 * fns.c (hash_string): New function, taken from sxhash_string.
3460 Do not discard information about ASCII character case; this
3461 discarding is no longer needed.
3462 (sxhash-string): Use it. Change sig to match it. Caller changed.
3463 * lisp.h: Declare it.
3464 * lread.c (hash_string): Remove, since we now use fns.c's version.
3465 The fns.c version returns a wider integer if --with-wide-int is
3466 specified, so this should help the quality of the hashing a bit.
3467
b312a492
PE
3468 * emacs.c: Integer overflow minor fix.
3469 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3470 Define only if GNU_LINUX.
3471 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3472
dfd153ae
PE
3473 * dispnew.c: Integer signedness and overflow fixes.
3474 Remove unnecessary forward decls, that were a maintenance hassle.
3475 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3476 All uses changed.
3477 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3478 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3479 (prepare_desired_row, line_draw_cost):
3480 Use int, not unsigned, where either works.
3481 (save_current_matrix, restore_current_matrix):
3482 Use ptrdiff_t, not size_t, where either works.
3483 (init_display): Check for overflow more accurately, and without
3484 relying on undefined behavior.
3485
a81d11a3
PE
3486 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3487 Remove, replacing with the new symbols in lisp.h. All uses changed.
3488 * fileio.c (make_temp_name):
3489 * filelock.c (lock_file_1, lock_file):
3490 * xdisp.c (message_dolog):
3491 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3492 Use pMd etc. instead.
3493 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3494 replacing the pWIDE etc. symbols removed from editfns.c.
3495
3300e6fd
PE
3496 * keyboard.h (num_input_events): Now uintmax_t.
3497 This is (very slightly) less likely to mess up due to wraparound.
3498 All uses changed.
3499
fd05c7e9
PE
3500 * buffer.c: Integer signedness fixes.
3501 (alloc_buffer_text, enlarge_buffer_text):
3502 Use ptrdiff_t rather than size_t when either will do, as we prefer
3503 signed integers.
3504
903fe15d
PE
3505 * alloc.c: Integer signedness and overflow fixes.
3506 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3507 (__malloc_size_t): Default to size_t, not to int.
3508 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3509 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3510 Prefer ptrdiff_t to size_t when either would do, as we prefer
3511 signed integers.
3512 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3513 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3514 Now const. Initialize with values that are in range even if char
3515 is signed.
3516 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3517 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3518 These functions do the right thing with sizes > 2**32.
3519 (check_depth): Now ptrdiff_t, not int.
3520 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3521 Adjust to new way of storing sizes. Check for size overflow bugs
3522 in rest of code.
3523 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3524 slightly wrong anyway, as it missed one instance of
3525 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3526 (refill_memory_reserve): Omit needless cast to size_t.
3527 (mark_object_loop_halt): Mark as externally visible.
3528
ac82cc6a
PE
3529 * xselect.c: Integer signedness and overflow fixes.
3530 (Fx_register_dnd_atom, x_handle_dnd_message):
3531 Use ptrdiff_t, not size_t, since we prefer signed.
3532 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3533 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3534 x_dnd_atoms_size and x_dnd_atoms_length.
3535
c2d1e36d
PE
3536 * doprnt.c: Prefer signed to unsigned when either works.
3537 * eval.c (verror):
3538 * doprnt.c (doprnt):
3539 * lisp.h (doprnt):
3540 * xdisp.c (vmessage):
3541 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3542 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3543 prefer signed arithmetic to avoid comparison confusion.
3544 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3545 but is a bit tricky.
3546
0e926e56
PE
3547 Assume freestanding C89 headers, string.h, stdlib.h.
3548 * data.c, doprnt.c, floatfns.c, print.c:
3549 Include float.h unconditionally.
3550 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3551 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3552 * regex.c: Likewise for stddef.h, string.h.
3553 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3554 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3555 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3556 (STDC_HEADERS): Remove obsolete defines.
3557 * sysdep.c: Include limits.h unconditionally.
3558
9cfdb3ec
PE
3559 Assume support for memcmp, memcpy, memmove, memset.
3560 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3561 * regex.c (memcmp, memcpy):
3562 Remove; we assume C89 now.
3563
3564 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3565 (__malloc_safe_bcopy): Remove; no longer needed.
3566
cf950e6b 3567 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3568 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3569 well either way, and we prefer signed to unsigned.
3570
dbf38e02
LMI
35712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3572
3573 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3574 closes the connection while we're reading (bug#9182).
3575
d6f0886c 35762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3577
d6f0886c
JD
3578 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3579 are specified (Bug#9168).
24e0f6b1 3580
2eb1f9e6
PE
35812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3582
3583 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3584 Found by GCC static checking and --with-wide-int on a 32-bit host.
3585
22381272 35862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3587
3588 * xdisp.c (compute_display_string_pos): Fix logic of caching
3589 previous display string position. Initialize cached_prev_pos to
3590 -1. Fixes slow-down at the beginning of a buffer.
3591
f25e39b4
EZ
35922011-07-24 Eli Zaretskii <eliz@gnu.org>
3593
3594 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3595 for attrs[LFACE_FONTSET_INDEX].
3596
04c4b52e
PE
35972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3598
3599 * xml.c (parse_region): Remove unused local
3600 that was recently introduced.
3601
c1734fbd
EZ
36022011-07-23 Eli Zaretskii <eliz@gnu.org>
3603
be18c5a5
EZ
3604 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3605 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3606
c1734fbd
EZ
3607 * xdisp.c (move_it_in_display_line_to): Record the best matching
3608 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3609 exit if none of the characters scanned was an exact match.
3610 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3611 when exact match is impossible due to invisible text, and the
3612 lines are truncated.
3613
a258d627
JD
36142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3615
3616 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3617 for OSX >= 10.7.
3618
b6d5a689
EZ
36192011-07-22 Eli Zaretskii <eliz@gnu.org>
3620
0f74f785
EZ
3621 Fix a significant slow-down of cursor motion with C-n, C-p,
3622 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3623 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3624 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3625 (next_element_from_buffer): Call compute_stop_pos_backwards to
3626 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3627 base_level_stop.
3628 (reseat): Don't look for prev_stop, as that could mean a very long
3629 run.
3630 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3631 <cached_disp_overlay_modiff>: Cache for last found display string
3632 position.
551918c1 3633 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3634 about the same buffer in the same area of character positions, and
3635 the buffer wasn't changed since the time the display string
3636 position was cached.
551918c1 3637
b2d0c91a
EZ
36382011-07-22 Eli Zaretskii <eliz@gnu.org>
3639
3640 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3641 is an integer, which is important for empty lines. (Bug#9149)
3642
043604ee
CY
36432011-07-22 Chong Yidong <cyd@stupidchicken.com>
3644
3645 * frame.c (Fmodify_frame_parameters): In tty case, update the
3646 default face if necessary (Bug#4238).
3647
da4adb04
CY
36482011-07-21 Chong Yidong <cyd@stupidchicken.com>
3649
3650 * editfns.c (Fstring_to_char): No need to explain what a character
3651 is in the docstring (Bug#6576).
3652
9abd0532
LMI
36532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3654
3655 * xml.c (parse_region): Make sure we always return a tree.
3656
36881d16
HK
36572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3658
3659 * xml.c (parse_region): If a document contains only comments,
3660 return that, too.
3661
1e98674d
LMI
36622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3663
3664 * xml.c (make_dom): Return comments, too.
3665
590bd467
PE
36662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 Port to OpenBSD.
3669 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3670 and the surrounding thread.
3671 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3672 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3673 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3674 timer goes off.
3675 * s/openbsd.h (BROKEN_SIGIO): Define.
3676 * unexelf.c (unexec) [__OpenBSD__]:
3677 Don't update the .mdebug section of the Alpha COFF symbol table.
3678
f41628b2
LMI
36792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3680
3681 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3682 (bug#8460).
3683
b59b67c5
PE
36842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3685
15e3a074
PE
3686 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3687 This fixes some race conditions on the permissions of any newly
3688 created file.
3689
41bed37d
PE
3690 * alloc.c (valid_pointer_p): Use pipe, not open.
3691 This fixes some permissions issues when debugging.
3692
b59b67c5
PE
3693 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3694 If fchown fails to set both uid and gid, try to set just gid,
3695 as that is sometimes allowed. Adjust the file's mode to eliminate
3696 setuid or setgid bits that are inappropriate if fchown fails.
3697
925a6be7
SM
36982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3699
3700 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3701 to compare Lisp_Objects.
3702 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3703 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3704 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3705
52968808
AS
37062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3707
0a6a104b
AS
3708 * lread.c (read_integer): Unread even EOF character.
3709 (read1): Likewise. Properly record start position of symbol.
3710
52968808
AS
3711 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3712 symbol character follows.
3713
9e381cdd
PE
37142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3715
3716 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3717 This works around a problem with the previous change to Fcopy_file.
3718 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3719 and without this change, GCC might complain about discarding
3720 fchown's return value.
3721
b5641435
JB
37222011-07-16 Juanma Barranquero <lekktu@gmail.com>
3723
3724 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3725
a8031457
PE
37262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3727
3728 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3729
dd889327
LMI
37302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3731
750c33f7
LMI
3732 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3733 it's used from the C level.
3734
dd889327
LMI
3735 * process.c: Use the same condition for POLL_FOR_INPUT in both
3736 keyboard.c and process.c (bug#1858).
3737
87e86684
LM
37382011-07-09 Lawrence Mitchell <wence@gmx.li>
3739
3740 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3741 (Fgnutls_boot): Use it.
3742
64348f40
AS
37432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3744
3745 * doc.c (Fsubstitute_command_keys): Revert last change.
3746
1d698799
LMI
37472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3748
f863868c
LMI
3749 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3750 quotes the next character, and doesn't affect other longer
3751 sequences (bug#8935).
3752
1d698799
LMI
3753 * lread.c (syms_of_lread): Clarify that is isn't only
3754 `eval-buffer' and `eval-defun' that's affected by
3755 `lexical-binding' (bug#8460).
3756
aa4b6df6
EZ
37572011-07-15 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3760 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3761
5d856da6
PE
37622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3763
ad6042bb
PE
3764 Fix minor problems found by static checking.
3765 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3766 (elsz): Now a signed constant, not a size_t var. We prefer signed
3767 types to unsigned, to avoid integer comparison confusion. Without
3768 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3769 "cannot optimize loop, the loop counter may overflow", a symptom
3770 of the confusion.
f00bbb22 3771 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3772 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3773
6468f31c
LMI
37742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775
49080b10
LMI
3776 * search.c (Fre_search_backward): Mention `case-fold-search' in
3777 all the re_search_* functions (bug#8138).
3778
6468f31c
LMI
3779 * keyboard.c (Fopen_dribble_file): Document when the file is
3780 closed (bug#8056).
3781
c965adc5
EZ
37822011-07-14 Eli Zaretskii <eliz@gnu.org>
3783
df9733bf
EZ
3784 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3785 bidi_cache_idx.
3786
0bb23927
EZ
3787 Support bidi reordering of display and overlay strings.
3788 * xdisp.c (compute_display_string_pos)
3789 (compute_display_string_end): Accept additional argument STRING.
3790 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3791 (reseat_to_string): Initialize bidi_it->string.s and
3792 bidi_it->string.schars.
3793 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3794 NULL (avoids a crash in bidi_paragraph_init).
3795 Initialize itb.string.lstring.
0bb23927
EZ
3796 (init_iterator): Call bidi_init_it only of a valid
3797 buffer position was specified. Initialize paragraph_embedding to
3798 L2R.
3799 (reseat_to_string): Initialize the bidi iterator.
3800 (display_string): If we need to ignore text properties of
3801 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3802 original value of -1 will not work with bidi.)
3803 (compute_display_string_pos): First arg is now struct
3804 `text_pos *'; all callers changed. Support display properties on
3805 Lisp strings.
3806 (compute_display_string_end): Support display properties on Lisp
3807 strings.
3808 (init_iterator, reseat_1, reseat_to_string): Initialize the
3809 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3810 when iterating on a string not from display properties).
640c8776
SM
3811 (compute_display_string_pos, compute_display_string_end):
3812 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3813 arrow keys.
3814 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3815 base_level_stop; instead, set base_level_stop to BEGV.
3816 Fixes crashes in vertical-motion.
0bb23927
EZ
3817 (next_element_from_buffer): Improve commentary for when
3818 the iterator is before prev_stop.
3819 (init_iterator): Initialize bidi_p from the default value of
3820 bidi-display-reordering, not from buffer-local value. Use the
3821 buffer-local value only if initializing for buffer iteration.
3822 (handle_invisible_prop): Support invisible properties on strings
3823 that are being bidi-reordered.
3824 (set_iterator_to_next): Support bidi reordering of C strings and
3825 Lisp strings.
3826 (next_element_from_string): Support bidi reordering of Lisp
3827 strings.
3828 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3829 (display_string): Support display of R2L glyph rows.
3830 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3831 (init_iterator): Don't initialize it->bidi_p for strings
3832 here.
3833 (reseat_to_string): Initialize it->bidi_p for strings here.
3834 (next_element_from_string, next_element_from_c_string)
3835 (next_element_from_buffer): Add xassert's for correspondence
3836 between IT's object being iterated and it->bidi_it.string
3837 structure.
3838 (face_before_or_after_it_pos): Support bidi iteration.
3839 (next_element_from_c_string): Handle the case of the first string
3840 character that is not the first one in the visual order.
3841 (get_visually_first_element): New function, refactored from common
3842 parts of next_element_from_buffer, next_element_from_string, and
3843 next_element_from_c_string.
3844 (tool_bar_lines_needed, redisplay_tool_bar)
3845 (display_menu_bar): Force left-to-right direction. Add a FIXME
3846 comment for making that be controlled by a user option.
3847 (push_it, pop_it): Save and restore the state of the
3848 bidi iterator. Save and restore the bidi_p flag.
3849 (pop_it): Iterate out of display property for string iteration as
3850 well.
3851 (iterate_out_of_display_property): Support iteration over strings.
3852 (handle_single_display_spec): Set up it->bidi_it for iteration
3853 over a display string, and call bidi_init_it.
3854 (handle_single_display_spec, next_overlay_string)
3855 (get_overlay_strings_1, push_display_prop): Set up the bidi
3856 iterator for displaying display or overlay strings.
3857 (forward_to_next_line_start): Don't use the shortcut if
3858 bidi-iterating.
3859 (back_to_previous_visible_line_start): If handle_display_prop
3860 pushed the iterator stack, restore the internal state of the bidi
3861 iterator by calling bidi_pop_it same number of times.
3862 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3863 and we are bidi-iterating, don't decrement the iterator position;
3864 instead, set the first_elt flag in the bidi iterator, to produce
3865 the same effect.
3866 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3867 (push_display_prop): xassert that we are iterating a buffer.
3868 (push_it, pop_it): Save and restore paragraph_embedding member.
3869 (handle_single_display_spec, next_overlay_string)
3870 (get_overlay_strings_1, reseat_1, reseat_to_string)
3871 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3872 correctly. Don't assume unibyte strings are not bidi-reordered.
3873 (compute_display_string_pos)
3874 (compute_display_string_end): Fix handling the case of C string.
3875 (push_it, pop_it): Save and restore from_disp_prop_p.
3876 (handle_single_display_spec, push_display_prop): Set the
3877 from_disp_prop_p flag.
3878 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3879 (pop_it): Call iterate_out_of_display_property only if we are
3880 popping after iteration over a string that came from a display
3881 property. Fix a typo in popping stretch info. Add an assertion
3882 for verifying that the iterator position is in sync with the bidi
3883 iterator.
3884 (handle_single_display_spec, get_overlay_strings_1)
3885 (push_display_prop): Fix initialization of paragraph direction for
3886 string when that of the parent object is not yet determined.
3887 (reseat_1): Call bidi_init_it to resync the bidi
3888 iterator with IT's position. (Bug#7616)
3889 (find_row_edges): If ROW->start.pos gives position
3890 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3891 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3892 Reset the from_disp_prop_p flag.
3893 (SAVE_IT, RESTORE_IT): New macros.
3894 (pos_visible_p, face_before_or_after_it_pos)
3895 (back_to_previous_visible_line_start)
3896 (move_it_in_display_line_to, move_it_in_display_line)
3897 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3898 (try_scrolling, redisplay_window, display_line): Use them when
3899 saving a temporary copy of the iterator and restoring it back.
3900 (back_to_previous_visible_line_start, reseat_1)
3901 (init_iterator): Empty the bidi cache "stack".
3902 (move_it_in_display_line_to): If iterator ended up at
3903 EOL, but we never saw any buffer positions smaller than
3904 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3905 motion in bidi-reordered lines.
3906 (move_it_in_display_line_to): Record prev_method and prev_pos
3907 immediately before the call to set_iterator_to_next. Fixes cursor
3908 motion in bidi-reordered lines with stretch glyphs and strings
3909 displayed in margins. (Bug#8133) (Bug#8867)
3910 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3911 TO_CHARPOS.
640c8776
SM
3912 (pos_visible_p): Support positions in bidi-reordered lines.
3913 Save and restore bidi cache.
0bb23927
EZ
3914
3915 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3916 (bidi_paragraph_info): Delete unused struct.
3917 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3918 (bidi_cache_start): New variable.
3919 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3920 to zero.
3921 (bidi_cache_fetch_state, bidi_cache_search)
3922 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3923 (bidi_cache_find, bidi_peek_at_next_level)
3924 (bidi_level_of_next_char, bidi_find_other_level_edge)
3925 (bidi_move_to_visually_next): Compare cache index with
3926 bidi_cache_start rather than with zero.
3927 (bidi_fetch_char): Accept new argument STRING; all callers
3928 changed. Support iteration over a string. Support strings with
3929 display properties. Support unibyte strings. Fix the type of
3930 `len' according to what STRING_CHAR_AND_LENGTH expects.
3931 (bidi_paragraph_init, bidi_resolve_explicit_1)
3932 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3933 (bidi_level_of_next_char, bidi_move_to_visually_next):
3934 Support iteration over a string.
0bb23927
EZ
3935 (bidi_set_sor_type, bidi_resolve_explicit_1)
3936 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3937 can now be zero (for strings); special values 0 and -1 were
3938 changed to -1 and -2, respectively.
3939 (bidi_char_at_pos): New function.
3940 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3941 Call it instead of FETCH_MULTIBYTE_CHAR.
3942 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3943 initialized to valid values.
3944 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3945 values.
3946 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3947 the test for valid cached positions. Fix the logic for looking up
3948 the sentinel state in the cache. GCPRO the Lisp string we are
3949 iterating.
3950 (bidi_push_it, bidi_pop_it): New functions.
3951 (bidi_initialize): Initialize the bidi cache start stack pointer.
3952 (bidi_cache_ensure_space): New function, refactored from part of
3953 bidi_cache_iterator_state. Don't assume the required size is just
3954 one BIDI_CACHE_CHUNK away.
3955 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3956 (bidi_count_bytes, bidi_char_at_pos): New functions.
3957 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3958 always valid if bidi_cache_idx is valid.
3959 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3960 is valid if it's going to be used.
3961 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3962 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3963 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3964 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3965 (bidi_find_other_level_edge, bidi_cache_start_stack):
3966 All variables related to cache indices are now EMACS_INT.
c965adc5 3967
0bb23927
EZ
3968 * dispextern.h (struct bidi_string_data): New structure.
3969 (struct bidi_it): New member `string'. Make flag members be 1-bit
3970 fields, and put them last in the struct.
640c8776
SM
3971 (compute_display_string_pos, compute_display_string_end):
3972 Update prototypes.
0bb23927
EZ
3973 (bidi_push_it, bidi_pop_it): Add prototypes.
3974 (struct iterator_stack_entry): New members bidi_p,
3975 paragraph_embedding, and from_disp_prop_p.
3976 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3977 (bidi_shelve_cache, bidi_unshelve_cache):
3978 Declare prototypes.
0bb23927
EZ
3979
3980 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3981 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3982 and vector-like objects.
3983
3984 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3985 cache around display iteration.
3986
3987 * window.c (Fwindow_end, window_scroll_pixel_based)
3988 (displayed_window_lines, Frecenter): Save and restore the bidi
3989 cache around display iteration.
3990
3bbd2265
LMI
39912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3992
3993 * editfns.c (Fdelete_region): Clarify the use of the named
3994 parameters (bug#6788).
3995
adc47434
MR
39962011-07-14 Martin Rudalics <rudalics@gmx.at>
3997
3998 * indent.c (Fvertical_motion): Set and restore w->pointm when
3999 saving and restoring the window's buffer (Bug#9006).
4000
837c31f8
LMI
40012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4002
4003 * editfns.c (Fstring_to_char): Clarify just what is returned
4004 (bug#6576). Text by Eli Zaretskii.
4005
ac389d0c
JB
40062011-07-13 Juanma Barranquero <lekktu@gmail.com>
4007
4008 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4009
0be0ce47
EZ
40102011-07-13 Eli Zaretskii <eliz@gnu.org>
4011
4012 * buffer.c (mmap_find): Fix a typo.
4013
cd18e7e3
JB
40142011-07-13 Johan Bockgård <bojohan@gnu.org>
4015
4016 Fix execution of x selection hooks.
4017 * xselect.c (Qx_lost_selection_functions)
4018 (Qx_sent_selection_functions): New vars.
4019 (syms_of_xselect): DEFSYM them.
4020 (x_handle_selection_request): Pass Qx_sent_selection_functions
4021 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4022 (x_handle_selection_clear,x_clear_frame_selections):
4023 Pass Qx_lost_selection_functions rather than
4024 Vx_lost_selection_functions to Frun_hook_with_args.
4025
47ea7f44
PE
40262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4027
ac389d0c 4028 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4029 The old code sometimes used this field without initializing it.
4030
47ea7f44
PE
4031 * alloc.c (gc_sweep): Don't read past end of array.
4032 In theory, the old code could also have corrupted Emacs internals,
4033 though it'd be very unlikely.
4034
bc985c87
AS
40352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4036
4037 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4038 argument. (Bug#4026)
bc985c87 4039
0cf34688
LMI
40402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4041
b3dadd76
LMI
4042 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4043 key" (bug#4257).
4044
0cf34688
LMI
4045 * window.c (Fset_window_start): Doc fix (bug#4199).
4046 (Fset_window_hscroll): Ditto.
4047
270768cd
PE
40482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4049
077e3dda 4050 Fix minor new problems caught by GCC 4.6.1.
270768cd 4051 * term.c (init_tty): Remove unused local.
490011a6 4052 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4053 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4054 not used otherwise.
270768cd 4055
b1f58454
CY
40562011-07-12 Chong Yidong <cyd@stupidchicken.com>
4057
4058 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4059
22b9578d
LMI
40602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4061
6e70ab07
LMI
4062 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4063 are the mini-buffer and the echo area (bug#3320).
4064
22b9578d
LMI
4065 * term.c (init_tty): Remove support for supdup, c10 and perq
4066 terminals, which are no longer supported (bug#1482).
4067
8974cc9f
JB
40682011-07-10 Johan Bockgård <bojohan@gnu.org>
4069
4070 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4071
a560d974
JD
40722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4073
4074 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4075 for non-popups (Bug#3642).
4076
1dae0f0a
AS
40772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4078
268c2c36 4079 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4080 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4081 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4082 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4083 * data.c (fmod): Likewise.
4084 * dispnew.c (swap_glyphs_in_rows): Likewise.
4085 * emacs.c (memory_warning_signal): Likewise.
4086 * floatfns.c (float_error): Likewise.
4087 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4088 (otf_open, font_otf_capability, generate_otf_features)
4089 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4090 Likewise.
4091 * image.c (pbm_read_file): Likewise.
4092 * indent.c (string_display_width): Likewise.
4093 * intervals.c (check_for_interval, search_for_interval)
4094 (inc_interval_count, count_intervals, root_interval)
4095 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4096 * lread.c (defalias): Likewise.
268c2c36 4097 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4098 * regex.c (set_image_of_range_1, set_image_of_range)
4099 (regex_grow_registers): Likewise.
4100 * sysdep.c (strerror): Likewise.
4101 * termcap.c (valid_filename_p, tprint, main): Likewise.
4102 * tparam.c (main): Likewise.
4103 * unexhp9k800.c (run_time_remap, save_data_space)
4104 (update_file_ptrs, read_header, write_header, calculate_checksum)
4105 (copy_file, copy_rest, display_header): Likewise.
4106 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4107 Likewise.
4108 * xdisp.c (check_it): Likewise.
4109 * xfaces.c (register_color, unregister_color, unregister_colors):
4110 Likewise.
4111 * xfns.c (print_fontset_result): Likewise.
4112 * xrdb.c (member, fatal, main): Likewise.
4113
99033785
PE
41142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4115
4116 Fix minor problems found by static checking (Bug#9031).
4117 * chartab.c (char_table_set_range, map_sub_char_table):
4118 Remove unused locals.
4119 (uniprop_table): Now static.
4120 * composite.c (_work_char): Remove unused static var.
4121
9cb2ac56
JB
41222011-07-09 Juanma Barranquero <lekktu@gmail.com>
4123
4124 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4125
f25661f0
JD
41262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4127
4128 * gtkutil.c (qttip_cb): Remove code without function.
4129
8278c4fe
EZ
41302011-07-09 Eli Zaretskii <eliz@gnu.org>
4131
4132 * w32.c (pthread_sigmask): New stub.
4133
1692ae2d 41342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4135
8a6ebd58 4136 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4137 sigprocmask is portable only for single-threaded applications, and
4138 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4139 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4140 (LIBES): Use it.
4141 * callproc.c (Fcall_process):
4142 * process.c (create_process):
4143 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4144 Use pthread_sigmask, not sigprocmask.
123403e4 4145
1b854618
JD
41462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4147
4148 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4149 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4150 wrong (Bug#8591).
4151
3fe4b549
JD
41522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4153
0ce7e563
JD
4154 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4155 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4156 (xg_hide_tooltip): Fix comment.
4157
3fe4b549
JD
4158 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4159 in registerServicesMenuSendTypes.
4160 (validRequestorForSendType): Don't check ns_return_types.
4161
4162 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4163 ns_return_type.
4164
5df75e47
JR
41652011-07-08 Jason Rumney <jasonr@gnu.org>
4166
22610910
JR
4167 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4168 SH_SHOW for hidden windows (Bug#5482).
4169
5df75e47
JR
4170 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4171 frame struct members of non-existent frames (Bug#6284).
4172
699c10bd
JD
41732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4174
4393663b
JD
4175 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4176 variable firstTime not needed on OSX >= 10.6.
4177 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4178 >= 10.5. Use setKnobProportion, setDoubleValue.
4179
4180 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4181 (MAC_OS_X_VERSION_10_5): Define if not defined.
4182 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4183 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4184 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4185
4186 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4187 cString and lossyCString on OSX >= 10.4
4188
58179cce 4189 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4190 sizeToFit on OSX >= 10.2.
4191
4192 * nsimage.m (allocInitFromFile): Don't use deprecated method
4193 bestRepresentationForDevice on OSX >= 10.6.
4194
4195 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4196 to avoid warning.
4197
4198 * emacs.c: Declare unexec_init_emacs_zone.
4199
a63e0781
JD
4200 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4201
699c10bd
JD
4202 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4203
4204 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4205 on svcsMenu (Bug#8842).
4206
4207 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4208 ns_return_types.
4209 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4210
4211 * nsterm.m (QUTF8_STRING): Declare.
4212 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4213 (validRequestorForSendType): Return type is (id).
4214 Change indexOfObjectIdenticalTo to indexOfObject.
4215 Check if we have local selection before returning self (Bug#8842).
4216 (writeSelectionToPasteboard): Put local selection into paste board
4217 if we have a local selection (Bug#8842).
4218 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4219
4220 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4221 (ns_get_local_selection): Declare.
4222
54e10184
LMI
42232011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4224
9888ff71
LMI
4225 * keymap.c (describe_map_tree): Don't insert a double newline at
4226 the end of the buffer (bug#1169) and return whether we inserted
4227 something.
4228
54e10184
LMI
4229 * callint.c (Fcall_interactively): Change "reading args" to
4230 "providing args" to try to clarify what it does (bug#1010).
4231
15fa4783
KH
42322011-07-07 Kenichi Handa <handa@m17n.org>
4233
4234 * composite.c (composition_compute_stop_pos): Ignore a static
4235 composition starting before CHARPOS (Bug#8915).
4236
4237 * xdisp.c (handle_composition_prop): Likewise.
4238
a8815b00
EZ
42392011-07-07 Eli Zaretskii <eliz@gnu.org>
4240
4241 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4242 (Bug#9015)
4243
ef7b981d 42442011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4245
4246 * character.h (unicode_category_t): New enum type.
4247
4248 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4249 (Qchar_code_property_table): New variable.
4250 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4251 (UNIPROP_COMPRESSED_FORM_P): New macros.
4252 (char_table_ascii): Uncompress the compressed values.
4253 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4254 Uncompress the compressed values.
ac389d0c 4255 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4256 (char_table_ref_and_range): Uncompress the compressed values.
4257 (sub_char_table_set): New arg is_uniprop. Callers changed.
4258 Uncompress the compressed values.
4259 (sub_char_table_set_range): Args changed. Callers changed.
4260 (char_table_set_range): Adjuted for the above change.
4261 (map_sub_char_table): Delete args default_val and parent. Add arg
4262 top. Give decoded values to a Lisp function.
640c8776 4263 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4264 values to a Lisp function. Gcpro more variables.
4265 (uniprop_table_uncompress)
4266 (uniprop_decode_value_run_length): New functions.
4267 (uniprop_decoder, uniprop_decoder_count): New variables.
4268 (uniprop_get_decoder, uniprop_encode_value_character)
4269 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4270 New functions.
4271 (uniprop_encoder, uniprop_encoder_count): New variables.
4272 (uniprop_get_encoder, uniprop_table)
4273 (Funicode_property_table_internal, Fget_unicode_property_internal)
4274 (Fput_unicode_property_internal): New functions.
4275 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4276 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4277 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4278 char-code-property-alist.
4279
640c8776 4280 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4281 Vunicode_category_table.
4282
640c8776 4283 * font.c (font_range): Adjust for the change of
c805dec0
KH
4284 Vunicode_category_table.
4285
76b397fb
DN
42862011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4287
4288 * m/iris4d.h: Remove file, move contents ...
4289 * s/irix6-5.h: ... here.
4290
22b4128e
PE
42912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4294 * alloc.c (mark_buffer):
4295 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4296 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4297 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4298 This isn't true in general, and it's particularly not true
4299 if Emacs is configured with --with-wide-int.
4300 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4301 New macros, used in the buffer.c change.
4302
869795d6
JD
43032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4304
4305 * xsettings.c: Use both GConf and GSettings if both are available.
4306 (store_config_changed_event): Add comment.
4307 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4308 (store_tool_bar_style_changed): New functions.
5e617bc2 4309 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4310 (struct xsettings): Move font inside HAVE_XFT.
4311 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4312 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4313 Move inside HAVE_XFT.
640c8776 4314 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4315 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4316 also.
4317 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4318 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4319 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4320 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4321 (parse_settings): Move check for font inside HAVE_XFT.
4322 (read_settings, apply_xft_settings): Add comment.
4323 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4324 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4325 call store_font_name_changed.
4326 (xft_settings_event): Add comment.
4327 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4328 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4329 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4330 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4331 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4332 (xsettings_get_system_font, xsettings_get_system_normal_font):
4333 Add comment.
869795d6 4334
d8ed26bd
PE
43352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4336
4337 Random fixes. E.g., (random) never returned negative values.
4338 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4339 subseconds part to the entropy, as that's a bit more random.
4340 Prefer signed to unsigned, since the signedness doesn't matter and
4341 in general we prefer signed. When given a limit, use a
4342 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4343 latter isn't right if USE_2_TAGS_FOR_INTS.
4344 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4345 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4346
cabf1cac
SM
43472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4348
4349 * textprop.c (text_property_stickiness):
4350 Obey Vtext_property_default_nonsticky.
4351 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4352 * w32fns.c (syms_of_w32fns):
4353 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4354
6e9b2be9
PE
43552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4358 This is more efficient than Ffile_directory_p and avoids a minor race.
4359
90186c68
LMI
43602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4361
7c301272
LMI
4362 * buffer.c (Foverlay_put): Say what the return value is
4363 (bug#7835).
4364
c4f2d8d4
LMI
4365 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4366 is a directory before asking whether to use the file name
4367 (bug#7564).
ad637907
LMI
4368 (barf_or_query_if_file_exists): Make the "File is a directory"
4369 error be more correct.
c4f2d8d4 4370
90186c68
LMI
4371 * fns.c (Frequire): Remove the mention of the .gz files, since
4372 that's installation-specific, but keep the mention of
4373 `get-load-suffixes'.
4374
da64016e
PE
43752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4378 Report string overflow if the output is too long.
4379
7d47b580
JB
43802011-07-04 Juanma Barranquero <lekktu@gmail.com>
4381
a555cb87
JB
4382 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4383 (syms_of_gnutls): Remove duplicate DEFSYM for
4384 Qgnutls_bootprop_verify_hostname_error, an error for
4385 Qgnutls_bootprop_verify_error (which is no longer used).
4386
7d47b580
JB
4387 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4388 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4389 Also (re)move comments that are misplaced or no longer relevant.
4390
1e49bfab
LMI
43912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4392
4393 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4394
1485f4c0
CY
43952011-07-03 Chong Yidong <cyd@stupidchicken.com>
4396
4397 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4398 and background color parameters if they have been changed.
4399
a9ab721e
LMI
44002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4401
4402 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4403
cf7cff57
PE
44042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4405
2e13213d
PE
4406 * xsettings.c (SYSTEM_FONT): Define only when used.
4407 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4408
cf7cff57
PE
4409 * keymap.c (access_keymap_1): Now static.
4410
7a8e04f7
CY
44112011-07-02 Chong Yidong <cyd@stupidchicken.com>
4412
4413 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4414 leave any prefix arg for the up event (Bug#1586).
4415
61352f62
LMI
44162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4417
69bb1ef7
LMI
4418 * lread.c (syms_of_lread): Mention single symbols defined by
4419 `defvar' or `defconst' (bug#7154).
4420
61352f62 4421 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4422 (Frequire): Mention get-load-suffixes.
61352f62 4423
28545e04
MR
44242011-07-02 Martin Rudalics <rudalics@gmx.at>
4425
4426 * window.h (window): Remove clone_number slot.
4427 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4428 Remove.
4429 (make_parent_window, make_window, saved_window)
4430 (Fset_window_configuration, save_window_save): Don't deal with
4431 clone numbers.
4432 * buffer.c (Qclone_number): Remove declaration.
4433 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4434
3349e122
SM
44352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4436
4437 Add multiple inheritance to keymaps.
4438 * keymap.c (Fmake_composed_keymap): New function.
4439 (Fset_keymap_parent): Simplify.
4440 (fix_submap_inheritance): Remove.
4441 (access_keymap_1): New function extracted from access_keymap to handle
4442 embedded parents and handle lists of maps.
4443 (access_keymap): Use it.
4444 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4445 (Fcopy_keymap): Handle embedded parents.
4446 (Fcommand_remapping, define_as_prefix): Simplify.
4447 (Fkey_binding): Simplify.
4448 (syms_of_keymap): Move minibuffer-local-completion-map,
4449 minibuffer-local-filename-completion-map,
4450 minibuffer-local-must-match-map, and
4451 minibuffer-local-filename-must-match-map to Elisp.
4452 (syms_of_keymap): Defsubr make-composed-keymap.
4453 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4454 (parse_menu_item): Trivial simplification.
4455
3279eb87
GM
44562011-07-01 Glenn Morris <rgm@gnu.org>
4457
4458 * Makefile.in (SETTINGS_LIBS): Fix typo.
4459
4550efdf
KI
44602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4461
4462 * coding.c (Fencode_coding_string): Record the last coding system
4463 used, as the function doc string says (bug#8738).
4464
0949d2b6
JD
44652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4466
4467 * xsettings.c (store_monospaced_changed): Take new font as arg and
4468 check for change against current_mono_font.
4469 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4470 (emacs_settings_constructor, emacs_settings_get_property)
4471 (emacs_settings_set_property, emacs_settings_class_init)
4472 (emacs_settings_init, gsettings_obj): Remove.
4473 (something_changedCB): New function for HAVE_GSETTINGS.
4474 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4475 with value as argument.
4476 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4477 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4478 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4479 "changed".
4480
4481 * xgselect.c: Add defined (HAVE_GSETTINGS).
4482 (xgselect_initialize): Ditto.
4483
4484 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4485 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4486 xg_select.
4487
bbc6b304
PE
44882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4489
4490 * eval.c (struct backtrace): Simplify and port the data structure.
4491 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4492 signed bit field, as this assumption is not portable and it makes
4493 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4494 "char debug_on_exit : 1" as this is not portable either; instead,
4495 use the portable "unsigned int debug_on_exit : 1". Remove unused
4496 member evalargs. Remove obsolete comments about cc bombing out.
4497
9851bfc5
JD
44982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4499
51bb811f 4500 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4501 Let HAVE_GSETTINGS override HAVE_GCONF.
4502 (store_monospaced_changed): New function.
4503 (EMACS_SETTINGS): A new type derived from GObject to handle
4504 GSettings notifications.
4505 (emacs_settings_constructor, emacs_settings_get_property)
4506 (emacs_settings_set_property, emacs_settings_class_init):
4507 New functions.
4508 (gsettings_client, gsettings_obj): New variables.
4509 (GSETTINGS_SCHEMA): New define.
4510 (something_changedCB): Call store_monospaced_changed.
4511 (init_gsettings): New function.
4512 (xsettings_initialize): Call init_gsettings.
4513 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4514 to NULL.
4515
640c8776 4516 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4517 GCONF_CFLAGS/LIBS.
4518
5386012d
MR
45192011-06-29 Martin Rudalics <rudalics@gmx.at>
4520
4521 * window.c (resize_root_window, grow_mini_window)
4522 (shrink_mini_window): Rename Qresize_root_window to
4523 Qwindow_resize_root_window and Qresize_root_window_vertically to
4524 Qwindow_resize_root_window_vertically.
4525
f13e0b08
PE
45262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4527
4528 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4529
94515237
JB
45302011-06-27 Juanma Barranquero <lekktu@gmail.com>
4531
4532 * makefile.w32-in: Redesign dependencies so they reflect more
4533 clearly which files are directly included by each source file,
4534 and not through other includes.
4535
e43b6e43
MR
45362011-06-27 Martin Rudalics <rudalics@gmx.at>
4537
4538 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4539 (sort_overlays, overlay_strings): When an overlay's clone number
4540 matches the window's clone number process the overlay even if
4541 the overlay's window property doesn't match the current window.
4542
d68443dc
MR
4543 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4544 (Fwindow_hchild): Rename to Fwindow_left_child.
4545 (Fwindow_next): Rename to Fwindow_next_sibling.
4546 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4547 (resize_window_check): Rename to window_resize_check.
4548 (resize_window_apply): Rename to window_resize_apply.
4549 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4550 (Fdelete_other_windows_internal, resize_frame_windows)
4551 (Fsplit_window_internal, Fdelete_window_internal)
4552 (grow_mini_window, shrink_mini_window)
4553 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4554
c7e73be5
JD
45552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4556
4557 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4558 (emacs_fixed_set_min_size): Remove.
4559 (emacs_fixed_new): Take frame as argument.
4560
4561 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4562 (_EmacsFixedPrivate): Remove minwidth/height.
4563 Add struct frame *f.
4564 (emacs_fixed_init): Initialize priv->f.
4565 (get_parent_class, emacs_fixed_set_min_size): Remove.
4566 (emacs_fixed_new): Set priv->f to argument.
4567 (emacs_fixed_get_preferred_width)
4568 (emacs_fixed_get_preferred_height): Use min_width/height from
4569 frames size_hint to set minimum and natural (Bug#8919).
4570 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4571 and use min_width/height from frames size_hint to set
4572 min_width/height (Bug#8919).
4573
4574 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4575 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4576 Fix indentation.
c7e73be5 4577
cf99dcf8
EZ
45782011-06-26 Eli Zaretskii <eliz@gnu.org>
4579
4580 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4581 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4582 called at ZV.
4583
029529ac
CY
45842011-06-26 Chong Yidong <cyd@stupidchicken.com>
4585
4586 * process.c (wait_reading_process_output): Bypass select if
4587 waiting for a cell while ignoring keyboard input, and input is
4588 pending. Suggested by Jan Djärv (Bug#8869).
4589
7a7ef429
PE
45902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4591
4592 Use gnulib's dup2 module instead of rolling our own.
4593 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4594
11fdef7d 45952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4596
4597 * dispnew.c (scrolling_window): Before scrolling, turn off a
4598 mouse-highlight in the window being scrolled.
4599
cd3520a4
JB
46002011-06-24 Juanma Barranquero <lekktu@gmail.com>
4601
4602 Move DEFSYM to lisp.h and use everywhere.
4603
4604 * character.h (DEFSYM): Move declaration...
4605 * lisp.h (DEFSYM): ...here.
4606
4607 * gnutls.c:
4608 * minibuf.c:
4609 * w32menu.c:
4610 * w32proc.c:
4611 * w32select.c: Don't include character.h.
4612
4613 * alloc.c (syms_of_alloc):
4614 * buffer.c (syms_of_buffer):
4615 * bytecode.c (syms_of_bytecode):
4616 * callint.c (syms_of_callint):
4617 * casefiddle.c (syms_of_casefiddle):
4618 * casetab.c (init_casetab_once):
4619 * category.c (init_category_once, syms_of_category):
4620 * ccl.c (syms_of_ccl):
4621 * cmds.c (syms_of_cmds):
4622 * composite.c (syms_of_composite):
4623 * dbusbind.c (syms_of_dbusbind):
4624 * dired.c (syms_of_dired):
4625 * dispnew.c (syms_of_display):
4626 * doc.c (syms_of_doc):
4627 * editfns.c (syms_of_editfns):
4628 * emacs.c (syms_of_emacs):
4629 * eval.c (syms_of_eval):
4630 * fileio.c (syms_of_fileio):
4631 * fns.c (syms_of_fns):
4632 * frame.c (syms_of_frame):
4633 * fringe.c (syms_of_fringe):
4634 * insdel.c (syms_of_insdel):
4635 * keymap.c (syms_of_keymap):
4636 * lread.c (init_obarray, syms_of_lread):
4637 * macros.c (syms_of_macros):
4638 * msdos.c (syms_of_msdos):
4639 * print.c (syms_of_print):
4640 * process.c (syms_of_process):
4641 * search.c (syms_of_search):
4642 * sound.c (syms_of_sound):
4643 * syntax.c (init_syntax_once, syms_of_syntax):
4644 * terminal.c (syms_of_terminal):
4645 * textprop.c (syms_of_textprop):
4646 * undo.c (syms_of_undo):
4647 * w32.c (globals_of_w32):
4648 * window.c (syms_of_window):
4649 * xdisp.c (syms_of_xdisp):
4650 * xfaces.c (syms_of_xfaces):
4651 * xfns.c (syms_of_xfns):
4652 * xmenu.c (syms_of_xmenu):
4653 * xsettings.c (syms_of_xsettings):
4654 * xterm.c (syms_of_xterm): Use DEFSYM.
4655
4228cf16
TZ
46562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4657
cd3520a4 4658 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4659
7fcccf1e
PE
46602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4661
7efb4e0e
PE
4662 Integer and buffer overflow fixes (Bug#8873).
4663
ff5844ad
PE
4664 * print.c (printchar, strout): Check for string overflow.
4665 (PRINTPREPARE, printchar, strout):
4666 Don't set size unless allocation succeeds.
4667
90532f02
PE
4668 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4669 for sizes. Check for string overflow more accurately.
4670 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4671
6d84508d
PE
4672 * macros.c: Integer and buffer overflow fixes.
4673 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4674 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4675 Use ptrdiff_t, not int, for sizes.
4676 Don't increment bufsize until after realloc succeeds.
4677 Check for size-calculation overflow.
4678 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4679
437b2cb4
PE
4680 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4681
8b9ac8b4
PE
4682 * lread.c: Integer overflow fixes.
4683 (read_integer): Radix is now EMACS_INT, not int,
4684 to improve quality of diagnostics for out-of-range radices.
4685 Calculate buffer size correctly for out-of-range radices.
4686 (read1): Check for integer overflow in radices, and in
4687 read-circle numbers.
82cb60d3
PE
4688 (read_escape): Avoid int overflow.
4689 (Fload, openp, read_buffer_size, read1)
4690 (substitute_object_recurse, read_vector, read_list, map_obarray):
4691 Use ptrdiff_t, not int, for sizes.
4692 (read1): Use EMACS_INT, not int, for sizes.
20270765 4693 Check for size overflow.
8b9ac8b4 4694
7fcccf1e
PE
4695 * image.c (cache_image): Check for size arithmetic overflow.
4696
bfbbd7e7
PE
4697 * lread.c: Integer overflow issues.
4698 (saved_doc_string_size, saved_doc_string_length)
4699 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4700 Now ptrdiff_t, not int.
4701 (read1): Don't assume doc string length fits in int. Check for
4702 out-of-range doc string lengths.
4703 (read_list): Don't assume file position fits in int.
39019e54 4704 (read_escape): Check for hex character overflow.
bfbbd7e7 4705
4e323265
LL
47062011-06-22 Leo Liu <sdl.web@gmail.com>
4707
4708 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4709 Move to minibuffer.el.
4710
85fece3e
PE
47112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4712
20b84ce9 4713 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4714 The following patches are for when GLYPH_DEBUG && !XASSERT.
4715 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4716 * dispnew.c (flush_stdout):
4717 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4718 Mark as externally visible.
4719 * dispnew.c (check_window_matrix_pointers): Now static.
4720 * dispnew.c (window_to_frame_vpos):
4721 * xfns.c (unwind_create_frame):
4722 * xterm.c (x_check_font): Remove unused local.
4723 * scroll.c (CHECK_BOUNDS):
4724 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4725 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4726 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4727 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4728 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4729 Now static.
4730 (debug_method_add): Use va_list and vsprintf rather than relying
4731 on undefined behavior with wrong number of arguments.
4732 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4733 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4734 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4735 since we're not interested in debugging glyphs with old libraries.
4736 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4737 GCC 4.6.0's static checking.
4738
0766b489
PE
47392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4740
31fd4b32
PE
4741 Integer overflow and signedness fixes (Bug#8873).
4742 A few related buffer overrun fixes, too.
4743
b79e8648
PE
4744 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4745
0766b489
PE
4746 * dispextern.h (struct face.stipple):
4747 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4748 (x_bitmap_mask, x_allocate_bitmap_record)
4749 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4750 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4751 (x_create_bitmap_from_xpm_data):
4752 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4753 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4754 (.bitmaps_last):
4755 * xfaces.c (load_pixmap):
4756 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4757 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4758 (.bitmaps_last, struct x_output.icon_bitmap):
4759 Use ptrdiff_t, not int, for bitmap indexes.
4760 (x_allocate_bitmap_record): Check for size overflow.
4761 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4762
b081724f
PE
4763 Use ptrdiff_t, not int, for overlay counts.
4764 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4765 * editfns.c (overlays_around, get_pos_property):
4766 * textprop.c (get_char_property_and_overlay):
4767 * xdisp.c (next_overlay_change, note_mouse_highlight):
4768 * xfaces.c (face_at_buffer_position):
21514da7
PE
4769 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4770 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4771 (Fnext_overlay_change, Fprevious_overlay_change)
4772 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4773 Use ptrdiff_t, not int, for sizes.
21514da7 4774 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4775
3de73e5e
PE
4776 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4777
2606c57b
PE
4778 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4779 (x_session_initialize): Do not assume string length fits in int.
4780
aaafe47a
PE
4781 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4782 This is unlikely, but can occur if DPI is outlandish.
4783
2674ddc8 4784 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4785 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4786
28154962
PE
4787 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4788 * xrdb.c (magic_file_p, search_magic_path):
4789 Omit last arg SUFFIX; it was always 0. All callers changed.
4790 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4791
7de51af5
PE
4792 * xfont.c (xfont_match): Avoid need for strlen.
4793
25ed6cc3
PE
4794 * xfns.c: Don't assume strlen fits in int.
4795 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4796
4eab31dd
PE
4797 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4798 not unsigned long, as we prefer signed integers. All callers changed.
4799 Detect integer overflow in repeat count.
4800 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4801 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4802
171e2a58
PE
4803 * termcap.c: Don't assume sizes fit in int and never overflow.
4804 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4805 (gobble_line): Check for size-calculation overflow.
4806
ad39faca 4807 * minibuf.c (Fread_buffer):
6e5bb2dc 4808 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4809 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4810 Don't assume string length fits in int.
4811
52c61c22 4812 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4813 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4814
b5b8c9e5
PE
4815 * font.c: Don't assume string length fits in int.
4816 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4817 Use ptrdiff_t, not int.
ccd6111c
PE
4818 (font_intern_prop): Don't assume string length fits in int.
4819 Don't assume integer property fits in fixnum.
4820 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4821
882f0d81 4822 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4823 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4824 Reformulate so as not to need the command string.
4825 Invoke gzip -cd rather than gunzip, as it's more portable.
4826 (lock_info_type, lock_file_1, lock_file):
4827 Don't assume pid_t and time_t fit in unsigned long.
4828 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4829 (current_lock_owner): Prefer signed type for sizes.
4830 Use memcpy, not strncpy, where memcpy is what is really wanted.
4831 Don't assume (via atoi) that time_t and pid_t fit in int.
4832 Check for time_t and/or pid_t out of range, e.g., via a network share.
4833 Don't alloca where an auto var works fine.
4834
93f4cf88
PE
4835 * fileio.c: Fix some integer overflow issues.
4836 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4837 Don't assume string length fits in int.
4838 (directory_file_name): Don't assume string length fits in long.
4839 (make_temp_name): Don't assume pid fits in int, or that its print
4840 length is less than 20.
4841
f3e92b69
PE
4842 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4843
1bfdaf10
PE
4844 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4845
35016e9a
PE
4846 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4847
3d1e65a1
PE
4848 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4849 We prefer signed integers, even for size calculations.
4850
0b963a93
PE
4851 * emacs.c: Don't assume string length fits in 'int'.
4852 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4853 (main): Don't invoke strlen when not needed.
4854
573f4b54
PE
4855 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4856 (XD_DEBUG_MESSAGE): Don't waste a byte.
4857
989f33ba
PE
4858 * callproc.c (getenv_internal_1, getenv_internal)
4859 (Fgetenv_internal):
965d34eb
PE
4860 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4861
e4d29b33
PE
4862 * lread.c (invalid_syntax): Omit length argument.
4863 All uses changed. This doesn't fix a bug, but it simplifies the
4864 code away from its former Hollerith-constant appearance, and it's
4865 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4866 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4867
eb49b136
PE
4868 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4869 This didn't break anything, but it didn't help either.
4870 It's confusing to put a bogus integer in a place where the actual
4871 value does not matter.
9f62aeb1 4872 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4873 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4874
15375a22
PE
4875 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4876 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4877 implementation.
b61cc01c
PE
4878 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4879 We prefer signed types, and the value cannot exceed the EMACS_INT
4880 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4881 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4882 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4883 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4884
53b2623d
PE
4885 * indent.c (sane_tab_width): New function.
4886 (current_column, scan_for_column, Findent_to, position_indentation)
4887 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4888 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4889
51cab52b 4890 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4891
f2ed8a70
PE
4892 * lisp.h (lint_assume): New macro.
4893 * composite.c (composition_gstring_put_cache):
4894 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4895
abe80cc6
PE
4896 * editfns.c, insdel.c:
4897 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4898
b02c740e
PE
4899 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4900
ebc96716
PE
4901 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4902
b4e50fa0 4903 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4904 Use much-faster test for byte-length change.
311d5d7c 4905 Don't assume string byte-length fits in 'int'.
a4cf38e4 4906 Check that character arg fits in 'int'.
85461888 4907 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4908
c0c1ee9f
PE
4909 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4910
a498d7f4
PE
4911 * fns.c (concat): Catch string overflow earlier.
4912 Do not rely on integer wraparound.
4913
51cab52b
PE
4914 * dispextern.h (struct it.overlay_strings_charpos)
4915 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4916 * xdisp.c (forward_to_next_line_start)
4917 (back_to_previous_visible_line_start)
4918 (reseat_at_next_visible_line_start, next_element_from_buffer):
4919 Don't arbitrarily truncate the value of 'selective' to int.
4920
76031fad
PE
4921 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4922
5eb55db9
PE
4923 * composite.c: Don't truncate sizes to 'int'.
4924 (composition_gstring_p, composition_reseat_it)
4925 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4926 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4927 not EMACS_UINT, for indexes.
5eb55db9 4928
0703a717
PE
4929 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4930
d6202519
PE
4931 * buffer.c: Include <verify.h>.
4932 (struct sortvec.priority, struct sortstr.priority):
8961a454 4933 Now EMACS_INT, not int.
c20998a7 4934 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4935 (struct sortstr.size, record_overlay_string)
4936 (struct sortstrlist.size, struct sortlist.used):
4937 Don't truncate size to int.
4938 (record_overlay_string): Check for size-calculation overflow.
d6202519 4939 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4940
d5a19415
JM
49412011-06-22 Jim Meyering <meyering@redhat.com>
4942
029529ac 4943 Don't leak an XBM-image-sized buffer
d5a19415
JM
4944 * image.c (xbm_load): Free the image buffer after using it.
4945
a9041e6c
PE
49462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4947
4948 Port to Sun C.
4949 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4950 that Sun C diagnosed.
4951 * fns.c (secure_hash): Fix pointer signedness issue.
4952 * intervals.c (static_offset_intervals): New function.
4953 (offset_intervals): Use it.
4954
7f3f739f
LL
49552011-06-21 Leo Liu <sdl.web@gmail.com>
4956
4957 * deps.mk (fns.o):
4958 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4959 sha512.h.
4960
4961 * fns.c (secure_hash): Rename from crypto_hash_function and change
4962 the first arg to accept symbols.
5b66d427 4963 (Fsecure_hash): New primitive.
7f3f739f
LL
4964 (syms_of_fns): New symbols.
4965
76147d94
DD
49662011-06-20 Deniz Dogan <deniz@dogan.se>
4967
4968 * process.c (Fset_process_buffer): Clarify return value in
4969 docstring.
4970
7d7d0045
CY
49712011-06-18 Chong Yidong <cyd@stupidchicken.com>
4972
4973 * dispnew.c (add_window_display_history): Use BVAR.
4974
4975 * xdisp.c (debug_method_add): Use BVAR.
4976 (check_window_end, dump_glyph_matrix, dump_glyph)
4977 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4978
4979 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4980 Likewise.
4981
4982 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4983 check till after the cache is created in init_frame_faces.
4984
ff2bc410
SM
49852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4986
4987 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4988
28177add
PE
49892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4990
dd3482fe
PE
4991 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4992 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4993 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4994
393d71f3 4995 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4996 * fileio.c (Finsert_file_contents):
4997 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4998 Remove the old (too-loose) buffer overflow checks.
4999 They weren't needed, since make_gap checks for buffer overflow.
5000 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5001 The old code merely checked for Emacs fixnum overflow, and relied
5002 on undefined (wraparound) behavior. The new code avoids undefined
5003 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5004
2e6813b0 5005 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5006 Tune. Don't use wider integers than needed. Don't use alloca.
5007 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5008
599a9e4f
PE
5009 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5010
99561444
PE
5011 * insdel.c, lisp.h (buffer_overflow): New function.
5012 (insert_from_buffer_1, replace_range, replace_range_2):
5013 * insdel.c (make_gap_larger):
5014 * editfns.c (Finsert_char):
5015 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5016
28177add
PE
5017 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5018
e69dafad
PE
50192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5020
4baa020d 5021 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5022
b1c46f02
PE
5023 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5024 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5025
e69dafad
PE
5026 * fileio.c: Don't assume EMACS_INT fits in off_t.
5027 (emacs_lseek): New static function.
5028 (Finsert_file_contents, Fwrite_region): Use it.
5029 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5030
566684ea
PE
5031 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5032
e6966cd6
PE
5033 * fns.c: Don't overflow int when computing a list length.
5034 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5035 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5036 truncation on 64-bit hosts. Check for QUIT every
5037 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5038 faster and is responsive enough.
5039 (Flength): Report an error instead of overflowing an integer.
5040 (Fsafe_length): Return a float if the value is not representable
5041 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5042 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5043 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5044
dd0b0efb
PE
5045 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5046 (header_size, word_size): New constants.
5047 (allocate_vectorlike): Don't check size overflow here.
5048 (allocate_vector): Check it here instead, since this is the only
5049 caller of allocate_vectorlike that could cause overflow.
5050 Check that the new vector's length is representable as a fixnum.
5051
86fe5cfe
PE
5052 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5053 The previous code was bogus. For example, next_almost_prime (32)
5054 returned 39, which is undesirable as it is a multiple of 3; and
5055 next_almost_prime (24) returned 25, which is a multiple of 5 so
5056 why was the code bothering to check for multiples of 7?
5057
80e88859
PE
5058 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5059
4a2f0ad6
PE
5060 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5061
f66c7cf8
PE
5062 Variadic C functions now count arguments with ptrdiff_t.
5063 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5064 Back then I didn't know that the Emacs coding style prefers signed int.
5065 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5066 were being counted with int, which may truncate counts on 64-bit
5067 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5068 * lisp.h (struct Lisp_Subr.function.aMANY)
5069 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5070 Arg counts are now ptrdiff_t, not size_t.
5071 All variadic functions and their callers changed accordingly.
5072 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5073 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5074 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5075 * callint.c (Fcall_interactively): Check arg count for overflow,
5076 to avoid potential buffer overrun. Use signed char, not 'int',
5077 for 'varies' array, so that we needn't bother to check its size
5078 calculation for overflow.
5079 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5080 * eval.c (apply_lambda):
5081 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5082 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5083 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5084
a1759b76
PE
5085 * callint.c (Fcall_interactively): Don't use index var as event count.
5086
d96be9fc
PE
5087 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5088 * mem-limits.h (SIZE): Remove; no longer used.
5089
a690a978 5090 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5091
578c21e6
PE
5092 Remove unnecessary casts.
5093 * xterm.c (x_term_init):
5094 * xfns.c (x_set_border_pixel):
5095 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5096 These aren't needed now that we assume ANSI C.
5097
96f53c6c
PE
5098 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5099 It's more likely to cause problems (due to unsigned overflow)
5100 than to cure them.
5101
83c77d31
PE
5102 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5103
ee2079f1
PE
5104 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5105
6da65536
PE
5106 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5107
7147c4a4
PE
5108 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5109
193e32d9
PE
5110 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5111
e5533da6
PE
5112 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5113
9910e595
PE
5114 GLYPH_CODE_FACE returns EMACS_INT, not int.
5115 * dispextern.h (merge_faces):
5116 * xfaces.c (merge_faces):
01103c44
PE
5117 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5118 Don't assume EMACS_INT fits in int.
9910e595 5119
2638320e
PE
5120 * character.h (CHAR_VALID_P): Remove unused parameter.
5121 * fontset.c, lisp.h, xdisp.c: All uses changed.
5122
045eb8d9
PE
5123 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5124
c1f134b5
PE
5125 * fns.c (concat): Minor tuning based on overflow analysis.
5126 This doesn't fix any bugs. Use int to hold character, instead
5127 of constantly refetching from Emacs object. Use XFASTINT, not
5128 XINT, for value known to be a character. Don't bother comparing
5129 a single byte to 0400, as it's always less.
5130
395fcb93 5131 * floatfns.c (Fexpt):
327eeec8
PE
5132 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5133
abbd3d23
PE
5134 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5135 for characters.
5136
684a03ef
PE
5137 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5138
0fed43f3
PE
5139 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5140 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5141 incorrectly succeed when S was a string, because 4294967386 was
5142 truncated before it was used.
5143
8fd02eb7
PE
5144 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5145 Otherwise, an out-of-range integer could cause undefined behavior
5146 on a 64-bit host.
5147
f8c86b69
PE
5148 * composite.c: Use int, not EMACS_INT, for characters.
5149 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5150 EMACS_INT, for values that are known to be in character range.
5151 This doesn't fix any bugs but is the usual style inside Emacs and
5152 may generate better code on 32-bit machines.
5153
34206dd2
PE
5154 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5155 This is for reasons similar to the recent CHAR_STRING fix.
5156 * charset.c (Fencode_char): Check that character arg is actually
5157 a character. Pass an int to ENCODE_CHAR.
5158 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5159 wider than 'int', as a compile-time check to prevent future regressions
5160 in this area.
5161
c5958d4c 5162 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5163
5164 Make sure a 64-bit char is never passed to CHAR_STRING.
5165 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5166 by silently ignoring the top 32 bits, allowing some values
5167 that were far too large to be valid characters.
5168 * character.h: Include <verify.h>.
5169 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5170 arguments are no wider than unsigned, as a compile-time check
5171 to prevent future regressions in this area.
5172 * data.c (Faset):
01103c44 5173 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5174 (Fsubst_char_in_region):
5175 * fns.c (concat):
5176 * xdisp.c (decode_mode_spec_coding):
5177 Adjust to CHAR_STRING's new requirement.
5178 * editfns.c (Finsert_char, Fsubst_char_in_region):
5179 * fns.c (concat): Check that character args are actually
5180 characters. Without this test, these functions did the wrong
5181 thing with wildly out-of-range values on 64-bit hosts.
5182
d37ca623
PE
5183 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5184 These casts should not be needed on 32-bit hosts, either.
5185 * keyboard.c (read_char):
5186 * lread.c (Fload): Remove casts to unsigned.
5187
ea204efb
PE
5188 * lisp.h (UNSIGNED_CMP): New macro.
5189 This fixes comparison bugs on 64-bit hosts.
5190 (ASCII_CHAR_P): Use it.
5191 * casefiddle.c (casify_object):
01103c44 5192 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5193 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5194 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5195 * dispextern.h (FACE_FROM_ID):
5196 * keyboard.c (read_char): Use UNSIGNED_CMP.
5197
41cb286c
PE
5198 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5199 not to EMACS_INT, to avoid GCC warning.
5200
4a1b9832
PE
5201 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5202
55daad71
PE
5203 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5204 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5205 isn't needed on 32-bit machines.
8f95c75c 5206
01103c44
PE
5207 * buffer.c (Fgenerate_new_buffer_name):
5208 Use EMACS_INT for count, not int.
0ceccced 5209 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5210
5211 * data.c (Qcompiled_function): Now static.
5212
c6f072e7
PE
5213 * window.c (window_body_lines): Now static.
5214
20ce5912
PE
5215 * image.c (gif_load): Rename local to avoid shadowing.
5216
9c4c5f81
PE
5217 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5218 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5219 * alloc.c (make_save_value): Integer argument is now of type
5220 ptrdiff_t, not int.
5221 (mark_object): Use ptrdiff_t, not int.
5222 * lisp.h (pD): New macro.
5223 * print.c (print_object): Use it.
5224
c0c5c8ae
PE
5225 * alloc.c: Use EMACS_INT, not int, to count objects.
5226 (total_conses, total_markers, total_symbols, total_vector_size)
5227 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5228 (total_free_floats, total_floats, total_free_intervals)
5229 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5230 Now EMACS_INT, not int. All uses changed.
5231 (Fgarbage_collect): Compute overall total using a double, so that
5232 integer overflow is less likely to be a problem. Check for overflow
5233 when converting back to an integer.
5a25e253
PE
5234 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5235 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5236 These were 'int' variables that could overflow on 64-bit hosts;
5237 they were never used, so remove them instead of repairing them.
211a0b2a 5238 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5239 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5240 Previously, this ceilinged at INT_MAX, but that doesn't work on
5241 64-bit machines.
e46bb31a 5242 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5243
c78baabf 5244 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5245 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5246 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5247 when a (possibly-narrower) signed value would do just as well.
5248 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5249
c9d624c6
PE
5250 * alloc.c: Catch some string size overflows that we were missing.
5251 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5252 for convenience in STRING_BYTES_MAX.
5253 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5254 The definition here is exact; the one in lisp.h was approximate.
5255 (allocate_string_data): Check for string overflow. This catches
5256 some instances we weren't catching before. Also, it catches
5257 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5258 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5259 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5260
c9d624c6
PE
5261 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5262 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5263 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5264
353032ce
PE
5265 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5266
2bccce07
PE
5267 * alloc.c (Fmake_string): Check for out-of-range init.
5268
0ac30604
SM
52692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5270
5271 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5272
c195f2de
JD
52732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5274
5275 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5276 xg_get_default_scrollbar_width.
5277
5278 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5279 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5280 (style_changed_cb): Call update_theme_scrollbar_width and call
5281 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5282 all frames (Bug#8505).
5283 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5284 Call gtk_window_set_resizable if HAVE_GTK3.
5285 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5286 and height if HAVE_GTK3 (Bug#8505).
5287 (scroll_bar_width_for_theme): New variable.
5288 (update_theme_scrollbar_width): New function.
5289 (xg_get_default_scrollbar_width): Move code to
5290 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5291 (xg_initialize): Call update_theme_scrollbar_width.
5292
5293 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5294
5295 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5296
e10ac9f1
MR
52972011-06-12 Martin Rudalics <rudalics@gmx.at>
5298
5299 * frame.c (make_frame): Call other_buffer_safely instead of
5300 other_buffer.
5301
5302 * window.c (temp_output_buffer_show): Call display_buffer with
5303 second argument Vtemp_buffer_show_specifiers and reset latter
5304 immediately after the call.
5305 (Vtemp_buffer_show_specifiers): New variable.
5306 (auto_window_vscroll_p, next_screen_context_lines)
5307 (Vscroll_preserve_screen_position): Remove leading asterisks from
5308 doc-strings.
5309
2d3c217e 53102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5311
7b7f97e8 5312 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5313 * buffer.c (Qclone_number): Remove for now, as it's unused.
5314 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5315 (record_buffer): Remove unused local.
5316 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5317 (set_frame_buffer_list): Remove; unused.
5318 * frame.h (other_visible_frames): Remove decl.
5319 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5320 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5321 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5322 if HAVE_GPM.
5323 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5324 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5325 Define only if HAVE_GPM.
5326 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5327 (update_hints_inhibit): Remove; never set. All uses removed.
5328 * widgetprv.h (emacsFrameClassRec): Remove decl.
5329 * window.c (delete_deletable_window): Now returns void, since it
5330 wasn't returning anything.
5331 (compare_window_configurations): Remove unused locals.
5332 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5333 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5334 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5335 the same widths as pointers. This follows up on the 2011-05-06 patch.
5336 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5337 * xterm.h: Likewise.
5338 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5339
1384b89e
JB
53402011-06-12 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * makefile.w32-in: Update dependencies.
5343 (LISP_H): Add lib/intprops.h.
5344
1100a63c
CY
53452011-06-11 Chong Yidong <cyd@stupidchicken.com>
5346
5347 * image.c (gif_load): Add animation frame delay to the metadata.
5348 (syms_of_image): Use DEFSYM. New symbol `delay'.
5349
6198ccd0
MR
53502011-06-11 Martin Rudalics <rudalics@gmx.at>
5351
5352 * window.c (delete_deletable_window): Re-add.
5353 (Fset_window_configuration): Rewrite to handle dead buffers and
5354 consequently deletable windows.
5355 (window_tree, Fwindow_tree): Remove. Supply functionality in
5356 window.el.
5357 (compare_window_configurations): Simplify code.
5358
b6e3633c
AS
53592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5360
1ab0dee5
AS
5361 * image.c (imagemagick_load_image): Fix type mismatch.
5362 (Fimagemagick_types): Likewise.
5363
b6e3633c
AS
5364 * window.h (replace_buffer_in_windows): Declare.
5365
9397e56f
MR
53662011-06-11 Martin Rudalics <rudalics@gmx.at>
5367
5368 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5369 Qclone_number. Remove external declaration of Qdelete_window.
5370 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5371 code.
640c8776
SM
5372 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5373 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5374 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5375 buffer list implementation.
5376 (other_buffer_safely): New function.
5377 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5378 calls to replace_buffer_in_windows and
5379 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5380 if allowed.
5381 (record_buffer): Inhibit quitting and rewrite using quittable
5382 functions. Run Qbuffer_list_update_hook if allowed.
5383 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5384 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5385 Move switch-to-buffer to window.el.
9397e56f
MR
5386 (bury-buffer): Move to window.el.
5387 (Vbuffer_list_update_hook): New variable.
5388
5389 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5390 section.
5391
5392 * window.h (resize_frame_windows): Move up in code.
5393 (Fwindow_frame): Remove EXFUN.
5394 (replace_buffer_in_all_windows): Remove prototype.
5395 (replace_buffer_in_windows_safely): Add prototype.
5396
5397 * window.c: Declare Qdelete_window static again. Move down
5398 declaration of select_count.
5399 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5400 (Fother_window): Move to window.el.
5401 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5402 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5403 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5404 window.el.
5405 (replace_buffer_in_windows): Implement by calling
5406 Qreplace_buffer_in_windows.
5407 (replace_buffer_in_all_windows): Remove with some functionality
5408 moved into replace_buffer_in_windows_safely.
5409 (replace_buffer_in_windows_safely): New function.
5410 (select_window_norecord, select_frame_norecord): Move in front
5411 of run_window_configuration_change_hook. Remove now obsolete
5412 declarations.
640c8776
SM
5413 (Fset_window_buffer): Rewrite doc-string.
5414 Call Qrecord_window_buffer.
9397e56f
MR
5415 (keys_of_window): Move binding for other-window to window.el.
5416
b50691aa
CY
54172011-06-11 Chong Yidong <cyd@stupidchicken.com>
5418
5419 * dispextern.h (struct image): Replace data member, whose int_val
5420 and ptr_val fields were not used by anything, with a single
5421 lisp_val object.
5422
5423 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5424 (gif_clear_image, gif_load, imagemagick_load_image)
5425 (gs_clear_image, gs_load): Callers changed.
5426
3f754b86
PE
54272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5428
cca69397
PE
5429 * buffer.h: Include <time.h>, for time_t.
5430 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5431
109e28d0
PE
5432 Fix minor problems found by static checking.
5433
60737f02
PE
5434 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5435
4b66faf3
PE
5436 Make identifiers static if they are not used in other modules.
5437 * data.c (Qcompiled_function, Qframe, Qvector):
5438 * image.c (QimageMagick, Qsvg):
5439 * minibuf.c (Qmetadata):
5440 * window.c (resize_window_check, resize_root_window): Now static.
5441 * window.h (resize_window_check, resize_root_window): Remove decls.
5442
109e28d0
PE
5443 * window.c (window_deletion_count, delete_deletable_window):
5444 Remove; unused.
46a4ce9e
PE
5445 (window_body_lines): Now static.
5446 (Fdelete_other_windows_internal): Mark vars as initialized.
5447 Make sure 'resize_failed' is initialized.
5448 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5449 (resize_window_apply): Remove unused local.
5450 * window.h (delete_deletable_window): Remove decl.
5451
109e28d0 5452 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5453 (imagemagick_load_image): Fix pointer signedness problem by changing
5454 last arg from unsigned char * to char *. All uses changed.
5455 Also, fix a local for similar reasons.
5456 Remove unused locals. Remove locals to avoid shadowing.
5457 (fn_rsvg_handle_free): Remove; unused.
5458 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5459 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5460
3f754b86
PE
5461 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5462
2547adb1
CY
54632011-06-10 Chong Yidong <cyd@stupidchicken.com>
5464
5465 * image.c (gif_load): Fix omitted cast error introduced by
5466 2011-06-06 change.
5467
2c8e37d4
MR
54682011-06-10 Martin Rudalics <rudalics@gmx.at>
5469
5470 * window.h (resize_proportionally, orig_total_lines)
5471 (orig_top_line): Remove from window structure.
5472 (set_window_height, set_window_width, change_window_heights)
5473 (Fdelete_window): Remove prototypes.
5474 (resize_frame_windows): Remove duplicate declaration.
5475
440a42e3
EZ
54762011-06-10 Eli Zaretskii <eliz@gnu.org>
5477
5478 * window.h (resize_frame_windows, resize_window_check)
5479 (delete_deletable_window, resize_root_window)
5480 (resize_frame_windows): Declare prototypes.
5481
5482 * window.c (resize_window_apply): Make definition be "static" to
5483 match the prototype.
5484
562dd5e9
MR
54852011-06-10 Martin Rudalics <rudalics@gmx.at>
5486
5487 * window.c: Remove declarations of Qwindow_size_fixed,
5488 window_min_size_1, window_min_size_2, window_min_size,
5489 size_window, window_fixed_size_p, enlarge_window, delete_window.
5490 Remove static from declaration of Qdelete_window, it's
5491 temporarily needed by Fbury_buffer.
5492 (replace_window): Don't assign orig_top_line and
5493 orig_total_lines.
5494 (Fdelete_window, delete_window): Remove. Window deletion is
5495 handled by window.el.
640c8776
SM
5496 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5497 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5498 (Fdelete_other_windows): Remove. Deleting other windows is
5499 handled by window.el.
5500 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5501 handled in window.el.
5502 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5503 Window minimum sizes are handled in window.el.
5504 (shrink_windows, size_window, set_window_height)
5505 (set_window_width, change_window_heights, window_height)
5506 (window_width, CURBEG, CURSIZE, enlarge_window)
5507 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5508 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5509 handled in window.el.
5510 (make_dummy_parent): Rename to make_parent_window and give it a
5511 second argument horflag.
5512 (make_window): Don't set resize_proportionally any more.
5513 (Fsplit_window): Remove. Windows are split in window.el.
5514 (save_restore_action, save_restore_orig_size)
5515 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5516 Resize mini windows in window.el.
5517 (grow_mini_window, shrink_mini_window): Implement by calling
5518 Qresize_root_window_vertically, resize_window_check and
5519 resize_window_apply.
640c8776
SM
5520 (saved_window, Fset_window_configuration, save_window_save):
5521 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5522 resize_proportionally.
5523 (window_min_height, window_min_width): Move to window.el.
5524 (keys_of_window): Move bindings for delete-other-windows,
5525 split-window, delete-window and enlarge-window to window.el.
5526
5527 * buffer.c: Temporarily extern Qdelete_window.
5528 (Fbury_buffer): Temporarily call Qdelete_window instead of
5529 Fdelete_window (Fbury_buffer will move to window.el soon).
5530
5531 * frame.c (set_menu_bar_lines_1): Remove code handling
5532 orig_top_line and orig_total_lines.
5533
5534 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5535 set_window_height but set heights directly.
5536 (change_frame_size_1): Use resize_frame_windows.
5537
5538 * xdisp.c (init_xdisp): Don't use set_window_height but set
5539 heights directly.
5540
640c8776
SM
5541 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5542 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5543 run_window_configuration_change_hook.
5544
5545 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5546 instead of change_window_heights and run
5547 run_window_configuration_change_hook.
5548
1a13852e
MR
55492011-06-09 Martin Rudalics <rudalics@gmx.at>
5550
5551 * window.c (replace_window): Rename second argument REPLACEMENT to
5552 NEW. New third argument SETFLAG. Rewrite.
5553 (delete_window, make_dummy_parent): Call replace_window with
5554 third argument 1.
5555 (window_list_1): Move down in code.
5556 (run_window_configuration_change_hook): Move set_buffer part
5557 before select_frame_norecord part in order to unwind correctly.
5558 Rename count1 to count.
5559 (recombine_windows, delete_deletable_window, resize_root_window)
5560 (Fdelete_other_windows_internal)
5561 (Frun_window_configuration_change_hook, make_parent_window)
5562 (resize_window_check, resize_window_apply, Fresize_window_apply)
5563 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5564 (Fdelete_window_internal, Fresize_mini_window_internal):
5565 New functions.
1a13852e
MR
5566 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5567
f3d1777e
MR
55682011-06-08 Martin Rudalics <rudalics@gmx.at>
5569
496e208e
MR
5570 * window.h (window): Add some new members to window structure -
5571 normal_lines, normal_cols, new_total, new_normal, clone_number,
5572 splits, nest, prev_buffers, next_buffers.
5573 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5574 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5575
f3d1777e
MR
5576 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5577 Remove.
496e208e
MR
5578 (make_dummy_parent): Set new members of windows structure.
5579 (make_window): Move down in code. Handle new members of window
5580 structure.
5581 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5582 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5583 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5584 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5585 (Fset_window_next_buffers, Fset_window_clone_number):
5586 New functions.
496e208e
MR
5587 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5588 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5589 Doc-string fixes.
5590 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5591 Argument WINDOW can be now internal window too.
5592 (Fwindow_use_time): Move up in code.
5593 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5594 Rewrite doc-string.
5595 (Fset_window_configuration, saved_window)
5596 (Fcurrent_window_configuration, save_window_save): Handle new
5597 members of window structure.
b9e809c2
MR
5598 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5599 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5600 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5601 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5602 Qget_mru_window, Qresize_root_window,
5603 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5604 Qauto_buffer_name; staticpro them.
f3d1777e 5605
abde8f8c
MR
56062011-06-07 Martin Rudalics <rudalics@gmx.at>
5607
5608 * window.c (Fwindow_total_size, Fwindow_left_column)
5609 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5610 (Fwindow_list_1): New functions.
5611 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5612 (Fwindow_width, Fscroll_left, Fscroll_right):
5613 Use window_body_cols instead of window_box_text_cols.
5614 (delete_window, Fset_window_configuration):
5615 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5616 (delete_all_subwindows): Take a window as argument and not a
5617 structure. Rewrite.
190b47e6
MR
5618 (window_loop): Remove handling of GET_LRU_WINDOW and
5619 GET_LARGEST_WINDOW.
5620 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5621
5622 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5623 window_box_text_cols. delete_all_subwindows now takes a
5624 Lisp_Object as argument.
abde8f8c 5625
640c8776
SM
5626 * indent.c (compute_motion, Fcompute_motion):
5627 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5628
fa8a67e6
MR
5629 * frame.c (delete_frame): Call delete_all_subwindows with root
5630 window as argument.
5631
a54e3482
DC
56322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5633
5634 * fns.c (Fputhash): Document return value.
5635
60002bf5
CY
56362011-06-06 Chong Yidong <cyd@stupidchicken.com>
5637
5638 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5639
0c671da6 56402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5641
b862a52a 5642 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5643
be44ca6c
PE
5644 Check for overflow when converting integer to cons and back.
5645 * charset.c (Fdefine_charset_internal, Fdecode_char):
5646 Use cons_to_unsigned to catch overflow.
5647 (Fencode_char): Use INTEGER_TO_CONS.
5648 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5649 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5650 * data.c (long_to_cons, cons_to_long): Remove.
5651 (cons_to_unsigned, cons_to_signed): New functions.
5652 These signal an error for invalid or out-of-range values.
5653 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5654 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5655 * font.c (Ffont_variation_glyphs):
5656 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5657 * lisp.h: Include <intprops.h>.
5658 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5659 (cons_to_signed, cons_to_unsigned): New decls.
5660 (long_to_cons, cons_to_long): Remove decls.
5661 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5662 (Fprimitive_undo): Use CONS_TO_INTEGER.
5663 * xfns.c (Fx_window_property): Likewise.
5664 * xselect.c: Include <limits.h>.
5665 (x_own_selection, selection_data_to_lisp_data):
5666 Use INTEGER_TO_CONS.
5667 (x_handle_selection_request, x_handle_selection_clear)
5668 (x_get_foreign_selection, Fx_disown_selection_internal)
5669 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5670 (lisp_data_to_selection_data): Use cons_to_unsigned.
5671 (x_fill_property_data): Use cons_to_signed.
5672 Report values out of range.
5673
d1f3d2af
PE
5674 Check for buffer and string overflow more precisely.
5675 * buffer.h (BUF_BYTES_MAX): New macro.
5676 * lisp.h (STRING_BYTES_MAX): New macro.
5677 * alloc.c (Fmake_string):
5678 * character.c (string_escape_byte8):
5679 * coding.c (coding_alloc_by_realloc):
5680 * doprnt.c (doprnt):
5681 * editfns.c (Fformat):
5682 * eval.c (verror):
5683 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5684 since they may not be the same number.
5685 * editfns.c (Finsert_char):
5686 * fileio.c (Finsert_file_contents):
5687 Likewise for BUF_BYTES_MAX.
5688
dd52fcea
PE
5689 * image.c: Use ptrdiff_t, not int, for sizes.
5690 (slurp_file): Switch from int to ptrdiff_t.
5691 All uses changed.
5692 (slurp_file): Check that file size fits in both size_t (for
5693 malloc) and ptrdiff_t (for sanity and safety).
5694
7f9bbdbb
PE
5695 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5696 if b->modtime has its maximal value.
5697
dfe18f82
PE
5698 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5699
84acfcf0
PE
5700 Don't assume time_t can fit into int.
5701 * buffer.h (struct buffer.modtime): Now time_t, not int.
5702 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5703 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5704
ccd9a01a
PE
5705 Minor fixes for signed vs unsigned integers.
5706 * character.h (MAYBE_UNIFY_CHAR):
5707 * charset.c (maybe_unify_char):
5708 * keyboard.c (read_char, reorder_modifiers):
5709 XINT -> XFASTINT, since the integer must be nonnegative.
5710 * ftfont.c (ftfont_spec_pattern):
5711 * keymap.c (access_keymap, silly_event_symbol_error):
5712 XUINT -> XFASTINT, since the integer must be nonnegative.
5713 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5714 since it makes no difference and we prefer signed.
5715 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5716 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5717 nonnegative.
5718
d6d100dd
SM
57192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * window.h (Fwindow_frame): Declare.
5722
2b6148e4
PE
57232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5724
5725 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5726 (SPARE_MEMORY): Always define.
5727 (LARGE_REQUEST): Remove.
5728 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5729
f230ecc9
MR
57302011-06-06 Martin Rudalics <rudalics@gmx.at>
5731
727e958e
MR
5732 * lisp.h: Move EXFUNS for Fframe_root_window,
5733 Fframe_first_window and Fset_frame_selected_window to window.h.
5734
5735 * window.h: Move EXFUNS for Fframe_root_window,
5736 Fframe_first_window and Fset_frame_selected_window here from
5737 lisp.h.
5738
5739 * frame.c (Fwindow_frame, Fframe_first_window)
5740 (Fframe_root_window, Fframe_selected_window)
5741 (Fset_frame_selected_window): Move to window.c.
5742 (Factive_minibuffer_window): Move to minibuf.c.
5743 (Fother_visible_frames_p): New function.
5744
5745 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5746
f230ecc9
MR
5747 * window.c (decode_window, decode_any_window): Move up in code.
5748 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5749 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5750 (Fwindow_buffer): Move up and rewrite doc-string.
5751 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5752 (Fwindow_prev): New functions.
727e958e
MR
5753 (Fwindow_frame): Move here from frame.c. Accept any window as
5754 argument.
5755 (Fframe_root_window, Fframe_first_window)
5756 (Fframe_selected_window): Move here from frame.c. Accept frame
5757 or arbitrary window as argument. Update doc-strings.
5758 (Fminibuffer_window): Move up in code.
5759 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5760 (Fset_frame_selected_window): Move here from frame.c.
5761 Marginal rewrite.
727e958e
MR
5762 (Fselected_window, select_window, Fselect_window): Move up in
5763 code. Minor doc-string fixes.
f230ecc9 5764
4d09bcf6
PE
57652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5768 Do not assume that spare memory exists; that assumption is valid
5769 only if SYSTEM_MALLOC.
5770 (LARGE_REQUEST): New macro, so that the issue of large requests
5771 is separated from the issue of spare memory.
5772
810928a2
AS
57732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5774
172418ad
AS
5775 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5776 format. (Bug#8806)
5777
43f862f7
AS
5778 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5779
810928a2
AS
5780 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5781 before statements.
5782
a059fe24
JD
57832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5784
5785 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5786
5787 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5788
5789 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5790 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5791
989bf368
JB
57922011-06-05 Juanma Barranquero <lekktu@gmail.com>
5793
5794 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5795
4b80f674
CY
57962011-06-04 Chong Yidong <cyd@stupidchicken.com>
5797
5798 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5799 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5800 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5801 New error handlers.
4b80f674
CY
5802 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5803 Obey Vx_select_enable_clipboard_manager. Catch errors in
5804 x_clipboard_manager_save (Bug#8779).
5805 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5806 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5807
99a33b77 58082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5809
5810 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5811
99a33b77 58122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5813
5814 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5815 in the current matrix if keep_current_p is non-zero.
5816
8264569d
EZ
58172011-06-04 Eli Zaretskii <eliz@gnu.org>
5818
5819 * bidi.c (bidi_level_of_next_char): Fix last change.
5820
57f97249
EZ
58212011-06-03 Eli Zaretskii <eliz@gnu.org>
5822
fec2107c 5823 Support bidi reordering of text covered by display properties.
57f97249 5824
fec2107c
EZ
5825 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5826 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5827 (bidi_cache_search, bidi_cache_iterator_state)
5828 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5829 (bidi_level_of_next_char, bidi_move_to_visually_next):
5830 Support character positions inside a run of characters covered by a
fec2107c
EZ
5831 display string.
5832 (bidi_paragraph_init, bidi_resolve_explicit_1)
5833 (bidi_level_of_next_char): Call bidi_fetch_char and
5834 bidi_fetch_char_advance instead of FETCH_CHAR and
5835 FETCH_CHAR_ADVANCE.
5836 (bidi_init_it): Initialize new members.
5837 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5838 definitions.
5839 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5840 instead of using explicit *_CHAR codes.
d6d100dd
SM
5841 (bidi_resolve_explicit, bidi_resolve_weak):
5842 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5843 bidirectional text is supported only in multibyte buffers.
5844 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5845 it to initialize the frame_window_p member of struct bidi_it.
5846 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5847 (bidi_resolve_explicit, bidi_resolve_weak)
5848 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5849 bidi_it->nchars is non-positive.
5850 (bidi_level_of_next_char): Don't try to lookup the cache for the
5851 next/previous character if nothing is cached there yet, or if we
5852 were just reseat()'ed to a new position.
c40e2fb2 5853
0e14fe90
EZ
5854 * xdisp.c (set_cursor_from_row): Set start and stop points
5855 according to the row's direction when priming the loop that looks
5856 for the glyph on which to display cursor.
5857 (single_display_spec_intangible_p): Function deleted.
5858 (display_prop_intangible_p): Reimplement to call
5859 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5860 Accept 3 additional arguments needed by handle_display_spec.
5861 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5862 values: lists, `(when COND...)' forms, etc.
5863 (single_display_spec_string_p): Support property values that are
5864 lists with the argument STRING its top-level element.
5865 (display_prop_string_p): Fix the condition for processing a
5866 property that is a list to be consistent with handle_display_spec.
fec2107c 5867 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5868 last portion of handle_display_prop.
5869 (compute_display_string_pos): Accept additional argument
5870 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5871 value of a `display' property is a "replacing spec".
5872 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5873 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5874 the display property, but just return a value indicating whether
5875 the display property will replace the characters it covers.
5876 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5877 frame_window_p members of struct bidi_it.
d6d100dd
SM
5878 (compute_display_string_pos, compute_display_string_end):
5879 New functions.
fec2107c
EZ
5880 (push_it): Accept second argument POSITION, where pop_it should
5881 jump to continue iteration.
5882 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5883
fec2107c
EZ
5884 * keyboard.c (adjust_point_for_property): Adjust the call to
5885 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5886
5887 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5888 (bidi_init_it): Update prototypes.
5889 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5890 (compute_display_string_pos, compute_display_string_end):
5891 Declare prototypes.
fec2107c
EZ
5892 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5893 EMACS_INT.
fc6f18ce 5894
40087514 58952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5896
57f53182
PE
5897 Malloc failure behavior now depends on size of allocation.
5898 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5899 * lisp.h: Change signatures accordingly.
5900 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5901 All callers changed. (Bug#8762)
5902
5903 * gnutls.c: Use Emacs's memory allocators.
5904 Without this change, the gnutls library would invoke malloc etc.
5905 directly, which causes problems on non-SYNC_INPUT hosts, and which
5906 runs afoul of improving memory_full behavior. (Bug#8761)
5907 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5908 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5909 xfree instead of the default malloc, realloc, free.
5910 (Fgnutls_boot): No need to check for memory allocation failure,
5911 since xmalloc does that for us.
5912
ac32cd99 5913 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5914 * category.c (hash_get_category_set):
5915 * ccl.c (ccl_driver):
5916 * charset.c (Fdefine_charset_internal):
5917 * charset.h (struct charset.hash_index):
5918 * composite.c (get_composition_id, gstring_lookup_cache)
5919 (composition_gstring_put_cache):
5920 * composite.h (struct composition.hash_index):
5921 * dispextern.h (struct image.hash):
5922 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5923 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5924 (hashfn_equal, hashfn_user_defined, make_hash_table)
5925 (maybe_resize_hash_table, hash_lookup, hash_put)
5926 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5927 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5928 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5929 * image.c (make_image, search_image_cache, lookup_image)
5930 (xpm_put_color_table_h):
5931 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5932 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5933 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5934 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5935 * alloc.c (allocate_vectorlike):
5936 Check for overflow in vector size calculations.
5937 * ccl.c (ccl_driver):
5938 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5939 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5940 need to be updated by these changes.
40087514
PE
5941 * fns.c (make_hash_table, maybe_resize_hash_table):
5942 Check for integer overflow with large hash tables.
0de4bb68
PE
5943 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5944 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5945 (SXHASH_REDUCE): New macro.
5946 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5947 Use it instead of discarding useful hash info with large hash values.
5948 (sxhash_float): New function.
5949 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5950 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5951 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5952 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5953 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5954 Adjust signatures to match updated version of code.
5955 (consing_since_gc): Now EMACS_INT, since a single hash table can
5956 use more than INT_MAX bytes.
5957
698d32e2
DN
59582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5959
5960 Make it possible to build with GCC-4.6+ -O2 -flto.
5961
5962 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5963
fd6fa53f
SM
59642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5965
5966 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5967 Call minibuffer-inactive-mode.
5968
864db017
JB
59692011-05-31 Juanma Barranquero <lekktu@gmail.com>
5970
5971 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5972 Update dependencies.
5973
2ad0baf4
DN
59742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5975
5976 * data.c (init_data): Remove code for UTS, this system is not
5977 supported anymore.
5978
4fcc2638
DN
59792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5980
5981 Don't force ./temacs to start in terminal mode.
5982
5983 * frame.c (make_initial_frame): Initialize faces in all cases, not
5984 only when CANNOT_DUMP is defined.
5985 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5986
c56e0fd5
DN
59872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5988
5989 * dispnew.c (add_window_display_history): Use const for the string
5990 pointer. Remove declaration, not needed.
5991
333d54da 59922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5993
55d4c1b2 5994 Use 'inline', not 'INLINE'.
333d54da 5995 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5996 * alloc.c, fontset.c (INLINE): Remove.
5997 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5998 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5999 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6000 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6001 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6002
738db178
DN
60032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6004
6005 Make it possible to run ./temacs.
6006
6007 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6008 syms_of_callproc does the same thing. Remove test for
6009 "initialized", do it in the caller.
6010 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6011
620c53a6
SM
60122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6013
6014 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6015 (read_minibuf): Use get_minibuffer.
6016 (syms_of_minibuf): Use DEFSYM.
6017 (Qmetadata): New var.
6018 * data.c (Qbuffer): Don't make it static.
6019 (syms_of_data): Use DEFSYM.
6020
e003a292
PE
60212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6024 (CCL_CODE_MIN): New macro.
6025
ed008a6d
PE
60262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6027
3687c2ef
PE
6028 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6029
ed008a6d
PE
6030 * eval.c (Qdebug): Now static.
6031 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6032 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6033 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6034
d66c4c7c
CY
60352011-05-29 Chong Yidong <cyd@stupidchicken.com>
6036
6037 * image.c: Various fixes to ImageMagick code comments.
6038 (Fimagemagick_types): Doc fix.
6039
5fbc2025
PE
60402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6041
0196f88a
PE
6042 Minor fixes prompted by GCC 4.6.0 warnings.
6043
6044 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6045
5fbc2025
PE
6046 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6047 (x_clipboard_manager_save_all): Move extern decl to ...
6048 * xterm.h: ... here, so that it can be checked for consistency.
6049
1dd3c2d9
CY
60502011-05-29 Chong Yidong <cyd@stupidchicken.com>
6051
6052 * xselect.c (x_clipboard_manager_save_frame)
6053 (x_clipboard_manager_save_all): New functions.
6054 (Fx_clipboard_manager_save): Lisp function deleted.
6055
6056 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6057 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6058
6059 * xterm.h: Update prototype.
6060
5ba6571d
WX
60612011-05-28 William Xu <william.xwl@gmail.com>
6062
6063 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6064 exiting (Bug#8239).
6065
3eaff834
JM
60662011-05-28 Jim Meyering <meyering@redhat.com>
6067
e1900994 6068 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6069 * fns.c (to_uchar): Define.
6070 (crypto_hash_function): Use it to convert some newly-signed
6071 variables to unsigned, to avoid sign-extension bugs. For example,
6072 without this change, (md5 "truc") would evaluate to
6073 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6074 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6075 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6076
0f6990a7
PE
60772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6078
6079 Integer overflow fixes.
c8a9ca5a 6080
08686060
PE
6081 * dbusbind.c: Serial number integer overflow fixes.
6082 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6083 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6084 to hold a serial number that is too large for a fixnum.
6085 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6086 Check for serial numbers out of range. Decode any serial number
59568bf0 6087 that was so large that it became a float. (Bug#8722)
08686060 6088
2d1fc3c7
PE
6089 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6090 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6091 Use XFASTINT rather than XUINT when numbers are nonnegative.
6092 (xd_append_arg, Fdbus_method_return_internal):
6093 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6094 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6095 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6096 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6097 (Bug#8722)
2d1fc3c7 6098
c8a9ca5a
PE
6099 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6100
519e1d69
PE
6101 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6102
6df6ae42 6103 ccl: Add integer overflow checks.
30569699
PE
6104 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6105 (IN_INT_RANGE): New macros.
6106 (ccl_driver): Use them to check for integer overflow when
6107 decoding a CCL program. Many of the new checks are whether XINT (x)
6108 fits in int; it doesn't always, on 64-bit hosts. The new version
6109 doesn't catch all possible integer overflows, but it's an
847044ea 6110 improvement. (Bug#8719)
30569699 6111
c11285dc
PE
6112 * alloc.c (make_event_array): Use XINT, not XUINT.
6113 There's no need for unsigned here.
6114
fdccd48e
PE
6115 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6116 This follows up to the 2011-05-06 change that substituted uintptr_t
6117 for EMACS_INT. This case wasn't caught back then.
6118
37910ab2
PE
6119 Rework Fformat to avoid integer overflow issues.
6120 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6121 now (part of C89). Include <verify.h>.
6122 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6123 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6124 (Fformat): Avoid the prepass trying to compute sizes; it was only
6125 approximate and thus did not catch overflow reliably. Instead, walk
6126 through the format just once, formatting and computing sizes as we go,
6127 checking for integer overflow at every step, and allocating a larger
6128 buffer as needed. Keep track separately whether the format is
6129 multibyte. Keep only the most-recently calculated precision, rather
6130 than them all. Record whether each argument has been converted to
6131 string. Use EMACS_INT, not int, for byte and char and arg counts.
6132 Support field widths and precisions larger than INT_MAX. Avoid
6133 sprintf's undefined behavior with conversion specifications such as %#d
6134 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6135 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6136 formatting out-of-range floating point numbers with int
9173deec 6137 formats. (Bug#8668)
37910ab2 6138
2e6578fb
PE
6139 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6140
0ae6bdee
PE
6141 * data.c: Avoid integer truncation in expressions involving floats.
6142 * data.c: Include <intprops.h>.
6143 (arith_driver): When there's an integer overflow in an expression
6144 involving floating point, convert the integers to floating point
6145 so that the resulting value does not suffer from catastrophic
6146 integer truncation. For example, on a 64-bit host (* 4
6147 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6148 Do not rely on undefined behavior after integer overflow.
6149
de883a70
PE
6150 merge count_size_as_multibyte, parse_str_to_multibyte
6151 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6152 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6153 Check for integer overflow.
6154 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6155 since it's now a duplicate of the other. This is more of
6156 a character than a buffer op, so better that it's in character.c.
6157 * fns.c, print.c: Adjust to above changes.
6158
2ff916cb
PE
61592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6160
6161 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6162
f1b54466
PE
61632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6164
fb1ac845
PE
6165 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6166 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6167 (x_clipboard_manager_save): Now static.
6168 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6169
f1b54466
PE
6170 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6171 (crypto_hash_function): Now static.
6172 Fix pointer signedness problems. Avoid unnecessary initializations.
6173
a9f737ee
CY
61742011-05-27 Chong Yidong <cyd@stupidchicken.com>
6175
6176 * termhooks.h (Vselection_alist): Make it terminal-local.
6177
6178 * terminal.c (create_terminal): Initialize it.
6179
6180 * xselect.c: Support for clipboard managers.
6181 (Vselection_alist): Move to termhooks.h as terminal-local var.
6182 (LOCAL_SELECTION): New macro.
6183 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6184 (symbol_to_x_atom): Remove gratuitous arg.
6185 (x_handle_selection_request, lisp_data_to_selection_data)
6186 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6187 (x_own_selection, x_get_local_selection, x_convert_selection):
6188 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6189 (some_frame_on_display): Delete unused function.
6190 (Fx_own_selection_internal, Fx_get_selection_internal)
6191 (Fx_disown_selection_internal, Fx_selection_owner_p)
6192 (Fx_selection_exists_p): New optional frame arg.
6193 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6194 (x_handle_selection_clear): Don't treat other terminals with the
6195 same keyboard specially. Use the terminal-local Vselection_alist.
6196 (x_clear_frame_selections): Use Frun_hook_with_args.
6197
6198 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6199
6200 * xterm.h: Add support for those atoms.
6201
e067f0c1
CY
62022011-05-26 Chong Yidong <cyd@stupidchicken.com>
6203
6204 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6205 (converted_selections, conversion_fail_tag): New global variables.
6206 (x_selection_request_lisp_error): Free the above.
6207 (x_get_local_selection): Remove unnecessary code.
6208 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6209 of converted selections stored in converted_selections.
6210 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6211 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6212 (x_convert_selection): New function.
6213 (x_handle_selection_event): Simplify.
6214 (x_get_foreign_selection): Don't ignore incoming requests while
6215 waiting for an answer; this will fail when we implement
6216 SAVE_TARGETS, and seems unnecessary anyway.
6217 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6218 (Vx_sent_selection_functions): Doc fix.
6219
0f4aebc0
LL
62202011-05-26 Leo Liu <sdl.web@gmail.com>
6221
6222 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6223
e61124cd
YM
62242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6225
6226 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6227
6228 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6229 for fringe update if it has periodic bitmap.
ac389d0c 6230 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6231 and fringe_bitmap_periodic_p.
6232
6233 * fringe.c (get_fringe_bitmap_data): New function.
6234 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6235 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6236 row. Mark glyph row for fringe update if periodicity changed.
6237
6238 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6239 for fringe update unless it has periodic bitmap.
6240
f16d9837
KH
62412011-05-25 Kenichi Handa <handa@m17n.org>
6242
6243 * xdisp.c (get_next_display_element): Set correct it->face_id for
6244 a static composition.
6245
e1b90ef6
LL
62462011-05-24 Leo Liu <sdl.web@gmail.com>
6247
6248 * deps.mk (fns.o):
6249 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6250
6251 * fns.c (crypto_hash_function, Fsha1): New function.
6252 (Fmd5): Use crypto_hash_function.
6253 (syms_of_fns): Add Ssha1.
6254
7400048f
PE
62552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6256
6257 * gnutls.c: Remove unused macros.
6258 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6259 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6260 Remove macros that are defined and never used.
6261 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6262
abb71cf4
CY
62632011-05-22 Chong Yidong <cyd@stupidchicken.com>
6264
6265 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6266 (Fx_get_selection_internal): Minor cleanup.
6267 (Fx_own_selection_internal): Rename arguments for consistency with
6268 select.el.
6269
6307db39
PE
62702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6271
6272 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6273
f3d4e0a4
CY
62742011-05-22 Chong Yidong <cyd@stupidchicken.com>
6275
6276 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6277
4d8ade89
YM
62782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6279
6280 * dispnew.c (scrolling_window): Don't exclude the case that the
6281 last enabled row in the desired matrix touches the bottom boundary.
6282
32078c8d
GM
62832011-05-21 Glenn Morris <rgm@gnu.org>
6284
6285 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6286 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6287 and add some more files.
32078c8d 6288
7285dc67
EZ
62892011-05-20 Eli Zaretskii <eliz@gnu.org>
6290
6291 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6292 report_file_error introduced by the change from 2011-05-07.
6293
89d1bd22
PE
62942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6295
6296 * systime.h (Time): Define only if emacs is defined.
6297 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6298 where the include path doesn't have X11/X.h by default. See
6299 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6300
cd394be1 63012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6302
6303 * composite.c (find_automatic_composition): Fix previous change.
6304
b9704ad9
GM
63052011-05-20 Glenn Morris <rgm@gnu.org>
6306
6307 * lisp.mk: New file, split from Makefile.in.
6308 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6309 (shortlisp): Remove.
6310 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6311
4a720484
GM
63122011-05-19 Glenn Morris <rgm@gnu.org>
6313
6314 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6315 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6316 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6317 (lisp): Set the order to that of loadup.el.
6318 (shortlisp): Make it a copy of $lisp.
6319 (SOME_MACHINE_LISP): Remove.
6320 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6321 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6322
a28d4396
KH
63232011-05-18 Kenichi Handa <handa@m17n.org>
6324
6325 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6326 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6327 (find_automatic_composition): Mostly rewrite for efficiency.
6328
a2b1fa8e
JB
63292011-05-18 Juanma Barranquero <lekktu@gmail.com>
6330
6331 * makefile.w32-in: Update dependencies.
6332
8e1f5610
CS
63332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6334
6335 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6336 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6337
7025ee00 63382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6339
cdfa6eab
PE
6340 Fix some integer overflow issues, such as string length overflow.
6341
06d6db33
PE
6342 * insdel.c (count_size_as_multibyte): Check for string overflow.
6343
2b4560a8
PE
6344 * character.c (lisp_string_width): Check for string overflow.
6345 Use EMACS_INT, not int, for string indexes and lengths; in
6346 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6347 the resulting string length overflows an EMACS_INT; instead,
6348 report a string overflow if no precision given. When checking for
6349 precision exhaustion, use a check that cannot possibly have
6350 integer overflow. (Bug#8675)
6351 * character.h (lisp_string_width): Adjust to new signature.
6352
cb93f9be
PE
6353 * alloc.c (string_overflow): New function.
6354 (Fmake_string): Use it. This doesn't change behavior, but saves
6355 a few bytes and will simplify future changes.
6356 * character.c (string_escape_byte8): Likewise.
6357 * lisp.h (string_overflow): New decl.
6358
1a1f3366
PE
6359 Fixups, following up to the user-interface timestamp change.
6360 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6361 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6362 * msdos.c (mouse_get_pos): Likewise.
6363 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6364 * w32gui.h (Time): Define by including "systime.h" rather than by
6365 declaring it ourselves. (Bug#8664)
6366
d4e3e4d3
PE
6367 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6368 * image.c (clear_image_cache): Likewise.
6369
f6a24d19
PE
6370 * term.c (term_mouse_position): Don't assume time_t wraparound.
6371
08dc5ae6
PE
6372 Be more systematic about user-interface timestamps.
6373 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6374 and sometimes 'EMACS_UINT', to represent these timestamps.
6375 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6376 This makes the code easier to follow, and makes it easier to catch
6377 integer overflow bugs such as Bug#8664.
6378 * frame.c (Fmouse_position, Fmouse_pixel_position):
6379 Use Time, not unsigned long, for user-interface timestamps.
6380 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6381 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6382 * keyboard.h (last_event_timestamp): Likewise.
6383 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6384 * menu.h (xmenu_show): Likewise.
6385 * term.c (term_mouse_position): Likewise.
6386 * termhooks.h (struct input_event.timestamp): Likewise.
6387 (struct terminal.mouse_position_hook): Likewise.
6388 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6389 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6390 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6391 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6392 what it was before.
6393 * menu.h, termhooks.h: Include "systime.h", for Time.
6394
8e55734a
PE
6395 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6396 Don't assume that the difference between two unsigned long values
6397 can fit into an integer. At this point, we know button_down_time
6398 <= event->timestamp, so the difference must be nonnegative, so
6399 there's no need to cast the result if double-click-time is
6400 nonnegative, as it should be; check that it's nonnegative, just in
6401 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6402 apart (about 25 days). (Bug#8664)
8e55734a 6403
841f1b75 6404 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6405 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6406
3e26f69c
PE
6407 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6408 that always fit in int. Use a sentinel instead of a counter, to
6409 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6410 * frame.h (struct frame): Use int for menu_bar_items_used
6411 instead of EMACS_INT, since it always fits in int.
3e26f69c 6412
5cc152c0
PE
6413 * menu.c (grow_menu_items): Check for int overflow.
6414
d89eb65e
PE
6415 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6416
5235bd3e
PE
6417 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6418 Before, the code was not consistent. These values cannot exceed
6419 2**31 - 1 so there's no need to make them unsigned.
6420 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6421 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6422 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6423 as modifiers.
6424 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6425
bc827e23
PE
6426 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6427 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6428 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6429 presumably because the widths might not match.
6430
78eb494e
PE
6431 * window.c (size_window): Avoid needless test at loop start.
6432
04f2d78b
CB
64332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6434
6435 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6436
d2fc7e3d 64372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6438
6439 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6440
d2fc7e3d 64412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6442
6443 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6444 `width' to `bar_area_x' and `bar_area_width', respectively.
6445 (x_scroll_run): Take account of fringe background extension.
6446
04f2d78b
CB
6447 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6448 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6449 `bar_area_width', respectively.
6450 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6451 background extension.
6452
79b70037
GM
64532011-05-10 Jim Meyering <meyering@redhat.com>
6454
6455 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6456
2f142cc5
JB
64572011-05-10 Juanma Barranquero <lekktu@gmail.com>
6458
6459 * image.c (Finit_image_library): Return t for built-in image types,
6460 like pbm and xbm. (Bug#8640)
6461
57679c86
AS
64622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6463
6464 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6465
888c9e86
EZ
64662011-05-07 Eli Zaretskii <eliz@gnu.org>
6467
b0512a1d
EZ
6468 * w32console.c (Fset_screen_color): Doc fix.
6469 (Fget_screen_color): New function.
6470 (syms_of_ntterm): Defsubr it.
6471
7285dc67
EZ
6472 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6473 unlink the temporary file if Fcall_process didn't create it in the
6474 first place.
6475 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6476 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6477 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6478 cue to call_process_cleanup not to close that handle.
6479
4d3fcc8e
BK
64802011-05-07 Ben Key <bkey76@gmail.com>
6481
6482 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6483 one of two shell specific rules, either bootstrap-temacs-CMD or
6484 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6485 to the previous implementation of the bootstrap-temacs rule.
6486 The bootstrap-temacs-CMD rule is similar to the previous
6487 implementation of the bootstrap-temacs rule except that it
6488 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6489 variable.
6490
6491 These changes, along with some changes to nt/configure.bat,
6492 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6493 earlier fix to add support for --cflags and --ldflags options
6494 that include quotes so that it works whether make uses cmd or
6495 sh as the shell.
6496
b4289b64
MA
64972011-05-06 Michael Albinus <michael.albinus@gmx.de>
6498
6499 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6500 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6501 is a constant.
6502 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6503 a string. Handle both cases.
6504 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6505 (Fdbus_register_method): Use Qinvalid_function.
6506
af4c0e28
JB
65072011-05-06 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * makefile.w32-in: Update dependencies.
6510 (LISP_H): Add inttypes.h and stdin.h.
6511 (PROCESS_H): Add unistd.h.
6512
c51453d9
EZ
65132011-05-06 Eli Zaretskii <eliz@gnu.org>
6514
6515 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6516 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6517
8ff0ac3c 65182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6519
4c4b566b
PE
6520 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6521
aab2b9b5
PE
6522 * term.c (vfatal): Remove stray call to va_end.
6523 It's not needed and the C Standard doesn't allow it here anyway.
6524
c378da0b
PE
6525 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6526 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6527
288b08c7
PE
6528 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6529 bytes.
6530
e3601888
PE
6531 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6532
db6c0e74
PE
6533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6534
dd5963ea
PE
6535 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6536
88c9450f
PE
6537 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6538
2f9442b8
PE
6539 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6540
c032b5f8
PE
6541 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6542 * charset.c (Fdefine_charset_internal): Don't initialize
6543 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6544 32-bit int (Bug#8600).
a108c10b
PE
6545
6546 * lread.c (read_integer): Be more consistent with string-to-number.
6547 Use string_to_number to do the actual conversion; this avoids
6548 rounding errors and fixes some other screwups. Without this fix,
6549 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6550 (digit_to_number): Move earlier, for benefit of read_integer.
6551 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6552 not a digit in any supported base. (Bug#8602)
a108c10b 6553
ad5f9eea
PE
6554 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6555
aec1708a
PE
6556 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6557 to match comment at start of function. This also removes a
6558 GCC warning about overflow in a 32+64-bit port.
6559
47be4ab5
PE
6560 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6561
371cac43
PE
6562 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6563 Reported by Stefan Monnier in
6564 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6565 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6566 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6567
d01a7826
PE
6568 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6569 (EMACS_UINTPTR): Likewise, with uintptr_t.
6570
7fd47d5c
PE
6571 * lisp.h: Prefer 64-bit EMACS_INT if available.
6572 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6573 on 32-bit hosts that have 64-bit int, so that they can access
6574 large files.
122b0c86
PE
6575 However, temporarily disable this change unless the temporary
6576 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6577
8727937b
PE
6578 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6579
8ac068ac
PE
6580 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6581 This removes an assumption that EMACS_INT and long are the same
6582 width as pointers. The assumption is true for Emacs porting targets
6583 now, but we want to make other targets possible.
6584 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6585 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6586 In the rest of the code, change types of integers that hold casted
6587 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6588 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6589 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6590 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6591 No need to cast type when ORing.
6592 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6593 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6594 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6595 assume EMACS_INT is the same width as char *.
6596 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6597 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6598 Remove no-longer-needed casts.
6599 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6600 (xg_tool_bar_help_callback, xg_make_tool_item):
6601 Use EMACS_INTPTR to hold an integer
6602 that will be cast to void *; this can avoid a GCC warning
6603 if EMACS_INT is not the same width as void *.
6604 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6605 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6606 (current_message_1, set_message_1):
6607 Use a local to convert to proper width without a cast.
6608 * xmenu.c (dialog_selection_callback): Likewise.
6609
ede49d71
PE
6610 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6611 Also, don't assume VALBITS / RAND_BITS is less than 5,
6612 and don't rely on undefined behavior when shifting a 1 left into
6613 the sign bit.
6614 * lisp.h (get_random): Change signature to match.
6615
2f30ecd0
PE
6616 * lread.c (hash_string): Use size_t, not int, for hash computation.
6617 Normally we prefer signed values; but hashing is special, because
6618 it's better to use unsigned division on hash table sizes so that
6619 the remainder is nonnegative. Also, size_t is the natural width
6620 for hashing into memory. The previous code used 'int', which doesn't
6621 retain enough info to hash well into very large tables.
6622 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6623
2a866e7b
PE
6624 * dbusbind.c: Don't possibly lose pointer info when converting.
6625 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6626 Use XPNTR rather than XHASH, so that the high-order bits of
6627 the pointer aren't lost when converting through void *.
6628
51639eac
PE
6629 * eval.c (Fautoload): Don't double-shift a pointer.
6630
92394119
PE
6631 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6632
dbdb9a7c
JB
66332011-05-06 Juanma Barranquero <lekktu@gmail.com>
6634
6635 * gnutls.c (DEF_GNUTLS_FN):
6636 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6637
db7a0b4f
AS
66382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6639
6640 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6641 marker. (Bug#8610)
6642
cd394be1 66432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6644
6645 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6646 New version that can reserve upto 2GB of heap space.
6647
f7ff1b0f 66482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6649
6650 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6651
639c109b
TZ
66522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6653
6654 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6655 `gnutls_certificate_set_x509_key_file'.
6656
d2127135
JB
66572011-05-05 Juanma Barranquero <lekktu@gmail.com>
6658
6659 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6660 Update dependencies.
6661
e968f4f3
JB
66622011-05-04 Juanma Barranquero <lekktu@gmail.com>
6663
6664 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6665 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6666 Remove unused parameter `fildes'.
6667 * process.c (read_process_output, send_process): Don't pass it.
6668
84d358f0
JB
66692011-05-04 Juanma Barranquero <lekktu@gmail.com>
6670
6671 Fix previous change: the library cache is defined in w32.c.
6672 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6673 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6674
0898ca10
JB
66752011-05-04 Juanma Barranquero <lekktu@gmail.com>
6676
6677 Implement dynamic loading of GnuTLS on Windows.
6678
6679 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6680 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6681 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6682 Declare.
6683
6684 * gnutls.c (Qgnutls_dll): Define.
6685 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6686 (gnutls_*): Declare function pointers.
6687 (init_gnutls_functions): New function to initialize function pointers.
6688 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6689 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6690 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6691 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6692 (emacs_gnutls_write, emacs_gnutls_read)
6693 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6694 (Fgnutls_available_p): New function.
6695 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6696 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6697 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6698
6699 * image.c: Include w32.h.
6700 (Vimage_type_cache): Delete.
6701 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6702 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6703 (w32_delayed_load): Move to w32.c.
6704
6705 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6706
6707 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6708 (w32_delayed_load): Move from image.c. When loading a library, record
6709 its filename in the :loaded-from property of the library id.
6710 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6711 Initialize and staticpro them.
6712 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6713
6714 * process.c: Include lisp.h before w32.h, not after.
6715 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6716 instead of gnutls_record_check_pending.
6717
6718 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6719
ff4de4aa
TZ
67202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6721
6722 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6723 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6724 as passed in.
6725
abe95abb
JD
67262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6727
6728 * xterm.c (x_set_frame_alpha): Do not set property on anything
6729 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6730
e16e55d4
JB
67312011-05-02 Juanma Barranquero <lekktu@gmail.com>
6732
6733 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6734
bafcf6a5
JB
67352011-05-02 Juanma Barranquero <lekktu@gmail.com>
6736
6737 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6738 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6739 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6740 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6741 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6742 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6743 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6744 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6745 (Qgnutls_bootprop_callbacks_verify): Make static.
6746
e7a6747f
AS
67472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6748
19ed11ba
AS
6749 * callproc.c: Indentation fixup.
6750
e7a6747f 6751 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6752 (wait_for_termination, interruptible_wait_for_termination):
6753 Move after wait_for_termination_1.
e7a6747f 6754
1ef14cb4
LMI
67552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6756
6757 * sysdep.c (interruptible_wait_for_termination): New function
6758 which is like wait_for_termination, but allows keyboard
6759 interruptions.
6760
6761 * callproc.c (Fcall_process): Add (:file "file") as an option for
6762 the STDOUT buffer.
6763 (Fcall_process_region): Ditto.
6764
330d880c
EZ
67652011-04-30 Eli Zaretskii <eliz@gnu.org>
6766
8db90b73
EZ
6767 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6768 rather than `XVECTOR (FOO)->size'.
6769
330d880c
EZ
6770 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6771 inttypes.h, as a gnulib replacement is used if it not available in
6772 system headers.
6773
15cbd324
EZ
67742011-04-21 Eli Zaretskii <eliz@gnu.org>
6775
6776 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6777 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6778 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6779
6780 * coding.c (coding_alloc_by_realloc): Error out if destination
6781 will grow beyond MOST_POSITIVE_FIXNUM.
6782 (decode_coding_emacs_mule): Abort if there isn't enough place in
6783 charbuf for the composition carryover bytes. Reserve an extra
6784 space for up to 2 characters produced in a loop.
6785 (decode_coding_iso_2022): Abort if there isn't enough place in
6786 charbuf for the composition carryover bytes.
6787
67882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6789
ae940cca
EZ
6790 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6791 aborting when %lld or %lll format is passed.
6792 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6793 %llo or %llx format is passed. (Bug#8545)
6794
03ab8921
EZ
6795 * window.c (window_scroll_line_based): Use a marker instead of
6796 simple variables to record original value of point. (Bug#7952)
6797
afda1437
EZ
6798 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6799 produced by %s or %c overflows available buffer space. (Bug#8545)
6800
f76dee0c
PE
68012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6802
6803 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6804 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6805
fdc5744d
JB
68062011-04-28 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6809
638f053a
JB
68102011-04-28 Juanma Barranquero <lekktu@gmail.com>
6811
6812 * keyboard.c (Qdelayed_warnings_hook): Define.
6813 (command_loop_1): Run `delayed-warnings-hook'
6814 if Vdelayed_warnings_list is non-nil.
6815 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6816 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6817
d178f871
EZ
68182011-04-28 Eli Zaretskii <eliz@gnu.org>
6819
6820 * doprnt.c (doprnt): Don't return value smaller than the buffer
6821 size if the message was truncated. (Bug#8545).
6822
b124fd93
JB
68232011-04-28 Juanma Barranquero <lekktu@gmail.com>
6824
6825 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6826 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6827
e810457d
PE
68282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6829
6830 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6831
ea51cceb
JB
68322011-04-27 Juanma Barranquero <lekktu@gmail.com>
6833
6834 * makefile.w32-in: Update dependencies.
6835
94dcfacf
EZ
68362011-04-27 Eli Zaretskii <eliz@gnu.org>
6837
6838 Improve `doprnt' and its usage. (Bug#8545)
6839 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6840 `format_end'. Remove support for %l as a conversion specifier.
6841 Don't use xrealloc. Improve diagnostics when the %l size modifier
6842 is used. Update the commentary.
6843
6844 * eval.c (verror): Simplify calculation of size_t.
6845
6846 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6847 messages.
6848
f61f41d7
PE
68492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6850
6851 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6852 change.
6853
96fb4434
PE
68542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6855
6856 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6857 This makes this file independent of the recent pseudovector change.
6858
671875da 68592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6860
69e9b5a3
PE
6861 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6862
b5f869a7 6863 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6864 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6865 Remove unused local.
c8926152 6866 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6867
841a1577 6868 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6869 GCC 4.6.0 optimizes based on type-based alias analysis.
6870 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6871 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6872 != &v->size, and therefore "v->size = 1; b->size = 2; return
6873 v->size;" must therefore return 1. This assumption is incorrect
6874 for Emacs, since it type-puns struct Lisp_Vector * with many other
6875 types. To fix this problem, this patch adds a new type struct
f904488f 6876 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6877 and pseudovectors, and helps optimizing compilers not get fooled
6878 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6879 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6880 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6881 the size member.
eab3844f
PE
6882 (XSETPVECTYPE): Rewrite in terms of new macro.
6883 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6884 This is a bit clearer, and further avoids the possibility of
6885 undesirable aliasing.
6886 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6887 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6888 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6889 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6890 (ASIZE): Now uses header.size rather than size.
6891 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6892 to avoid the hassle of writing XVECTOR (foo)->header.size.
6893 (struct vectorlike_header): New type.
eab3844f
PE
6894 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6895 object, to help avoid aliasing.
6896 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6897 (SUBRP): Likewise, since Lisp_Subr is a special case.
6898 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6899 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6900 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6901 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6902 changed to be "header.size" and "header.next".
6903 * buffer.h (struct buffer): Likewise.
6904 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6905 * frame.h (struct frame): Likewise.
6906 * process.h (struct Lisp_Process): Likewise.
6907 * termhooks.h (struct terminal): Likewise.
6908 * window.c (struct save_window_data, struct saved_window): Likewise.
6909 * window.h (struct window): Likewise.
6910 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6911 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6912 * buffer.c (init_buffer_once): Likewise.
6913 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6914 special case.
6915 * process.c (Fformat_network_address): Use local var for size,
6916 for brevity.
6917
0df1eac5
PE
6918 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6919
847ab9d1 6920 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6921 * data.c (atof): Remove decl; no longer used or needed.
6922 (digit_to_number): Move to lread.c.
6923 (Fstring_to_number): Use new string_to_number function, to be
6924 consistent with how the Lisp reader treats infinities and NaNs.
6925 Do not assume that floating-point numbers represent EMACS_INT
6926 without losing information; this is not true on most 64-bit hosts.
6927 Avoid double-rounding errors, by insisting on integers when
6928 parsing non-base-10 numbers, as the documentation specifies.
6929 * lisp.h (string_to_number): New decl, replacing ...
6930 (isfloat_string): Remove.
bc0a5c13 6931 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6932 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6933 appears to have been a coding error. Similarly, do not accept
6934 strings like +-1e0 as floating point numbers. Do not report
6935 overflow for integer overflows unless the base is not 10 which
6936 means we have no simple and reliable way to continue.
6937 Break out the floating-point parsing into a new
6938 function string_to_number, so that Fstring_to_number parses
6939 floating point numbers consistently with the Lisp reader.
04f2d78b 6940 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6941 (E_CHAR, EXP_INT): Remove, replacing with ...
6942 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6943 (string_to_number): New function, replacing isfloat_string.
6944 This function checks for valid syntax and produces the resulting
6945 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6946 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6947 so that overflow for non-base-10 numbers is reported only when
6948 there's no portable and simple way to convert to floating point.
452f4150 6949
67769ffc
PE
6950 * textprop.c (set_text_properties_1): Rewrite for clarity,
6951 and to avoid GCC warning about integer overflow.
6952
c20db43f
PE
6953 * intervals.h (struct interval): Use EMACS_INT for members
6954 where EMACS_UINT might cause problems. See
6955 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6956 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6957 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6958 All uses changed.
37aa2f85
PE
6959 (offset_intervals): Tell GCC not to worry about length overflow
6960 when negating a negative length.
c20db43f 6961
2538aa2f
PE
6962 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6963 (overrun_check_free): Likewise.
6964
f2d3008d
PE
6965 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6966 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6967 word size.
6968
ec8df744
PE
6969 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6970 (gnutls_make_error): Rename local to avoid shadowing.
6971 (gnutls_emacs_global_deinit): ifdef out; not used.
6972 (Fgnutls_boot): Use const for pointer to readonly storage.
6973 Comment out unused local. Fix pointer signedness problems.
6974
640ee02d
PE
6975 * lread.c (openp): Don't stuff size_t into an 'int'.
6976 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6977 about possible signed overflow.
6978
6048fb2a
PE
6979 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6980 (GDK_KEY_g): Don't define if already defined.
6981 (xg_prepare_tooltip): Avoid pointer signedness problem.
6982 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6983
fa3c87e1
PE
6984 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6985 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6986
2172544b
PE
6987 * xfns.c (Fx_window_property): Simplify a bit,
6988 to make a bit faster and to avoid GCC 4.6.0 warning.
6989 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6990
9b821a21
PE
6991 * fns.c (internal_equal): Don't assume size_t fits in int.
6992
3c616cfa
PE
6993 * alloc.c (compact_small_strings): Tighten assertion a little.
6994
c2982e87
PE
6995 Replace pEd with more-general pI, and fix some printf arg casts.
6996 * lisp.h (pI): New macro, generalizing old pEd macro to other
6997 conversion specifiers. For example, use "...%"pI"d..." rather
6998 than "...%"pEd"...".
6999 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7000 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7001 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7002 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7003 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7004 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7005 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7006 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7007 64-bit hosts.
7008 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7009 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7010 * print.c (safe_debug_print, print_object): Likewise.
7011 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7012 to int.
6f04d126
PE
7013 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7014 avoiding the 0 flag, which is not portable.
c2982e87
PE
7015 * process.c (Fmake_network_process): Use pI to avoid cast.
7016 * region-cache.c (pp_cache): Likewise.
7017 * xdisp.c (decode_mode_spec): Likewise.
7018 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7019 behavior on 64-bit hosts with printf arg.
6f04d126 7020 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7021 (x_stop_queuing_selection_requests): Likewise.
7022 (x_get_window_property): Don't truncate byte count to an 'int'
7023 when tracing.
0b432f21 7024
5e073ec7
PE
7025 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7026 here, since it parses constructs like leading '-' and spaces,
7027 which are not wanted; and it overflows with large numbers.
7028 Instead, simply match F[0-9]+, which is what is wanted anyway.
7029
36372bf9
PE
7030 * alloc.c: Remove unportable assumptions about struct layout.
7031 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7032 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7033 (allocate_vectorlike, make_pure_vector): Use the new macros,
7034 plus offsetof, to remove unportable assumptions about struct layout.
7035 These assumptions hold on all porting targets that I know of, but
7036 they are not guaranteed, they're easy to remove, and removing them
7037 makes further changes easier.
7038
0b432f21
PE
7039 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7040 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7041 (string_overrun_cookie): Now const. Use initializers that
7042 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7043 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7044 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7045 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7046 multiple of sizeof (EMACS_INT); it need not be, if
7047 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7048 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7049
895009e1
JB
70502011-04-26 Juanma Barranquero <lekktu@gmail.com>
7051
7052 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7053
6a7a1b0b
TZ
70542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7055
7056 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7057 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7058 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7059
841a1577 70602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7061
7062 * lisp.h (Qdebug): List symbol.
895009e1 7063 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7064 * keyboard.c (debug-on-event): New variable.
7065 (handle_user_signal): Break into debugger when debug-on-event
7066 matches the current signal symbol.
7067
f2d3ba6f
DN
70682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7069
7070 * alloc.c (check_sblock, check_string_bytes)
7071 (check_string_free_list): Convert to standard C.
7072
42ce4c63
TZ
70732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7074
7075 * w32.c (emacs_gnutls_push): Fix typo.
7076
825cd63c
EZ
70772011-04-25 Eli Zaretskii <eliz@gnu.org>
7078
fb11d64d
EZ
7079 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7080 "cast to pointer from integer of different size".
7081
825cd63c
EZ
7082 Improve doprnt and its use in verror. (Bug#8545)
7083 * doprnt.c (doprnt): Document the set of format control sequences
7084 supported by the function. Use SAFE_ALLOCA instead of always
7085 using `alloca'.
7086
7087 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7088 is one byte too soon. Don't use xrealloc; instead xfree and
7089 xmalloc anew.
7090
e061a11b
TZ
70912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7092
7093 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7094 callbacks stage.
7095
7096 * gnutls.c: Renamed global_initialized to
7097 gnutls_global_initialized. Added internals for the
7098 :verify-hostname-error, :verify-error, and :verify-flags
7099 parameters of `gnutls-boot' and documented those parameters in the
7100 docstring. Start callback support.
9173deec
JB
7101 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7102 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7103 on error. Return error code.
e061a11b
TZ
7104 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7105 (emacs_gnutls_read): Likewise.
7106 (Fgnutls_boot): Return handshake error code.
7107 (emacs_gnutls_handle_error): New function.
7108 (wsaerror_to_errno): Likewise.
7109
7110 * w32.h (emacs_gnutls_pull): Add prototype.
7111 (emacs_gnutls_push): Likewise.
7112
7113 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7114 (emacs_gnutls_push): Likewise.
7115
71162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7117
7118 * process.c (wait_reading_process_output): Check if GnuTLS
7119 buffered some data internally if no FDs are set for TLS
7120 connections.
7121
7122 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7123 (LIBS): Link to USER_LIBS.
7124 ($(BLD)/gnutls.$(0)): New target.
7125
fa6996bc
EZ
71262011-04-24 Eli Zaretskii <eliz@gnu.org>
7127
eb35682e
EZ
7128 * xdisp.c (handle_single_display_spec): Rename the
7129 display_replaced_before_p argument into display_replaced_p, to
7130 make it consistent with the commentary. Fix typos in the
7131 commentary.
7132
e2ad650c
EZ
7133 * textprop.c (syms_of_textprop): Remove dead code.
7134 (copy_text_properties): Delete obsolete commentary about an
7135 interface that was deleted long ago. Fix typos in the description
7136 of arguments.
7137
1b2de274
EZ
7138 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7139 to changes in oldXMenu/XMenu.h from 2011-04-16.
7140 <menu_help_message, prev_menu_help_message>: Constify.
7141 (IT_menu_make_room): menu->help_text is now `const char **';
7142 adjust.
7143
7144 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7145 to changes in oldXMenu/XMenu.h from 2011-04-16.
7146 (struct XMenu): Declare `help_text' `const char **'.
7147
7148 * xfaces.c <Qunspecified>: Make extern again.
7149
7150 * syntax.c: Include sys/types.h before including regex.h, as
7151 required by Posix.
7152
762b15be
EZ
7153 * doc.c (get_doc_string): Improve the format passed to `error'.
7154
7155 * doprnt.c (doprnt): Improve commentary.
7156
7157 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7158
7159 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7160 them with etags.
7161
f1052e5d
EZ
7162 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7163 changes in globals.h immediately force recompilation.
762b15be
EZ
7164 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7165 $(CURDIR)/s/ms-w32.h.
7166 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7167
fa6996bc
EZ
7168 * character.c (Fchar_direction): Function deleted.
7169 (syms_of_character): Don't defsubr it.
7170 <char-direction-table>: Deleted.
7171
e6c3da20
EZ
71722011-04-23 Eli Zaretskii <eliz@gnu.org>
7173
7174 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7175 * doprnt.c: Include limits.h.
7176 (SIZE_MAX): New macro.
04f2d78b
CB
7177 (doprnt): Return a size_t value. 2nd arg is now size_t.
7178 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7179 Improve overflow protection. Support `l' modifier for integer
7180 conversions. Support %l conversion. Don't assume an EMACS_INT
7181 argument for integer conversions and for %c.
7182
7183 * lisp.h (doprnt): Restore prototype.
7184
7185 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7186 $(SRC)/character.h.
7187
7188 * Makefile.in (base_obj): Add back doprnt.o.
7189
7190 * deps.mk (doprnt.o): Add back prerequisites.
7191 (callint.o): Depend on character.h.
7192
7193 * eval.c (internal_lisp_condition_case): Include the handler
7194 representation in the error message.
7195 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7196 when breaking from the loop.
7197
7198 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7199
7200 * callint.c (Fcall_interactively): When displaying error message
7201 about invalid control letter, pass the character's codepoint, not
7202 a pointer to its multibyte form. Improve display of the character
7203 in octal and display also its hex code.
7204
7205 * character.c (char_string): Use %x to display the (unsigned)
7206 codepoint of an invalid character, to avoid displaying a bogus
7207 negative value.
7208
7209 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7210 `error', not SYMBOL_NAME itself.
7211
7212 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7213 character arguments to `error'.
7214
7215 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7216 to `error' in error message about FINAL_CHAR argument. Make sure
7217 FINAL_CHAR is a character, and use %c when it is passed as
7218 argument to `error'.
7219
4ffd0d6b 72202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7221
7222 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7223
7224 * w32.c: Include <time.h>.
7225 (sys_localtime): New function.
7226
4ffd0d6b 72272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7228
7229 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7230
4ffd0d6b 7231 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7232
4ffd0d6b 72332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7234
4ffd0d6b
GM
7235 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7236 zombies (Bug#8467).
aac0c6e3 7237
04c56954
EZ
72382011-04-19 Eli Zaretskii <eliz@gnu.org>
7239
7240 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7241 gl_state.e_property when gl_state.object is Qt.
7242
7243 * insdel.c (make_gap_larger): Remove limitation of buffer size
7244 to <= INT_MAX.
7245
16a43933
CY
72462011-04-18 Chong Yidong <cyd@stupidchicken.com>
7247
7248 * xdisp.c (lookup_glyphless_char_display)
7249 (produce_glyphless_glyph): Handle cons cell entry in
7250 glyphless-char-display.
7251 (Vglyphless_char_display): Document it.
7252
7253 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7254 glyphless-char-display.
7255
4581706e
CY
72562011-04-17 Chong Yidong <cyd@stupidchicken.com>
7257
7258 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7259
7260 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7261
7262 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7263 definition for no-X builds.
7264
4887c6e2 72652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7266
fd35b6f9
PE
7267 Static checks with GCC 4.6.0 and non-default toolkits.
7268
5c1ccb01
PE
7269 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7270
006c5daa
PE
7271 * process.c (keyboard_bit_set): Define only if SIGIO.
7272 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7273 (send_process): Repair possible setjmp clobbering.
7274
efc736d3
PE
7275 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7276
4e2fe2e6
PE
7277 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7278
f97334a2
PE
7279 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7280
4e75f29d
PE
7281 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7282 Define only if needed.
7283
90efadd1
PE
7284 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7285 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7286 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7287
3c647824
PE
7288 * dispextern.h (struct redisplay_interface): Rename param
7289 to avoid shadowing.
e264f262 7290 * termhooks.h (struct terminal): Likewise.
761383f4 7291 * xterm.c (xembed_send_message): Likewise.
3c647824 7292
b58c5c4a
PE
7293 * insdel.c (make_gap_smaller): Define only if
7294 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7295
cad59032
PE
7296 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7297 it.
7298
c339dc2e
PE
7299 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7300 so that we aren't warned about unused symbols.
7301
91a3e27b
PE
7302 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7303
399c71d3 7304 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7305
8ffc96f5
PE
7306 * xfns.c (x_real_positions): Mark locals as initialized.
7307
eef9bc79
PE
7308 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7309
098db9dd
PE
7310 * xterm.c: Fix problems found by static analysis with other toolkits.
7311 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7312 (x_dispatch_event): Declare static if USE_GTK, and
7313 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7314 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7315 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7316 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7317 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7318
eb18f6cc
PE
7319 * xmenu.c (menu_help_callback): Pointer type fixes.
7320 Use const pointers when pointing at readonly data. Avoid pointer
7321 signedness clashes.
7322 (FALSE): Remove unused macro.
7323 (update_frame_menubar): Remove unused decl.
7324
1fe72bf8
PE
7325 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7326
60d9e1db
PE
7327 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7328 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7329 (single_menu_item): Rename local to avoid shadowing.
7330
39261c26
PE
7331 * keyboard.c (make_lispy_event): Remove unused local var.
7332
018c5e19
PE
7333 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7334 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7335
63d2b86e
PE
7336 * bitmaps: Change bitmaps from unsigned char back to the X11
7337 compatible char. Avoid the old compiler warnings about
7338 out-of-range initializers by using, for example, '\xab' rather
7339 than 0xab.
7340
aefd87e1
PE
7341 * xgselect.c (xgselect_initialize): Check vs interface
7342 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7343
bf501fb9
PE
7344 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7345
e9829fdf
PE
7346 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7347 to read-only memory.
7348
1086c095
PE
7349 * fns.c (vector): Remove; this old hack is no longer needed.
7350
2baccd04 7351 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7352 Remove unused var.
dde42981 7353 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7354
72391843 7355 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7356
436c16df 7357 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7358 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7359 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7360
92bb796d 7361 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7362 (x_term_init): Remove local to avoid shadowing.
92bb796d 7363
764430a3 7364 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7365
7366 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7367 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7368
d1dfb56c
EZ
73692011-04-16 Eli Zaretskii <eliz@gnu.org>
7370
c4354cb4
EZ
7371 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7372
d1dfb56c
EZ
7373 Fix regex.c, syntax.c and friends for buffers > 2GB.
7374 * syntax.h (struct gl_state_s): Declare character position members
7375 EMACS_INT.
7376
7377 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7378
04f2d78b
CB
7379 * textprop.c (verify_interval_modification, interval_of):
7380 Declare arguments EMACS_INT.
d1dfb56c
EZ
7381
7382 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7383 EMACS_INT.
7384
7385 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7386
7387 * indent.c (Fvertical_motion): Local variable it_start is now
7388 EMACS_INT.
7389
7390 * regex.c (re_match, re_match_2, re_match_2_internal)
7391 (bcmp_translate, regcomp, regexec, print_double_string)
7392 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7393 (re_compile_pattern, re_exec): Declare arguments and local
7394 variables `size_t' and `ssize_t' and return values `regoff_t', as
7395 appropriate.
7396 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7397 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7398 <compile_stack_type>: `size' and `avail' are now `size_t'.
7399
7400 * regex.h <regoff_t>: Use ssize_t, not int.
7401 (re_search, re_search_2, re_match, re_match_2): Arguments that
7402 specify buffer/string position and length are now ssize_t and
7403 size_t. Return type is regoff_t.
7404
613052cd
BK
74052011-04-16 Ben Key <bkey76@gmail.com>
7406
7407 * nsfont.m: Fixed bugs in ns_get_family and
7408 ns_descriptor_to_entity that were caused by using free to
7409 deallocate memory blocks that were allocated by xmalloc (via
7410 xstrdup). This caused Emacs to crash when compiled with
7411 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7412 --enable-checking=xmallocoverrun). xfree is now used to
7413 deallocate these memory blocks.
7414
4170f62f 74152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7416
71b41406
PE
7417 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7418
9587a89d
PE
7419 emacs_write: Accept and return EMACS_INT for sizes.
7420 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7421 et seq.
7422 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7423 Accept and return EMACS_INT.
7424 (emacs_gnutls_write): Return the number of bytes written on
7425 partial writes.
7426 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7427 (emacs_read, emacs_write): Remove check for negative size, as the
7428 Emacs source code has been audited now.
9587a89d
PE
7429 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7430 (emacs_read, emacs_write): Use it.
273a5f82
PE
7431 * process.c (send_process): Adjust to the new signatures of
7432 emacs_write and emacs_gnutls_write. Do not attempt to store
7433 a byte offset into an 'int'; it might overflow.
9587a89d 7434 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7435
3e047f51
PE
7436 * sound.c: Don't assume sizes fit in 'int'.
7437 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7438 Return EMACS_INT, not int.
3e047f51 7439 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7440 Accept EMACS_INT, not int.
7441 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7442 record read return values.
7443
cc39a9db
BK
74442011-04-15 Ben Key <bkey76@gmail.com>
7445
c9d0ec6d
JB
7446 * keyboard.c (Qundefined): Don't declare static since it is used
7447 in nsfns.m.
7448 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7449 static since they are used in nsfont.m.
cc39a9db 7450
6c60eb9f
SM
74512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7452
7453 * process.c (Qprocessp): Don't declare static.
7454 * lisp.h (Qprocessp): Declare again.
7455
7990b61a
JB
74562011-04-15 Juanma Barranquero <lekktu@gmail.com>
7457
7458 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7459
5d4cb038
PE
74602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7461
8bd7b830 7462 Improve C-level modularity by making more things 'static'.
cd64ea1d 7463
e3b27b31
PE
7464 Don't publish debugger-only interfaces to other modules.
7465 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7466 (verify_bytepos, count_markers): Move decls to the only modules
7467 that need them.
7468 * region-cache.h (pp_cache): Likewise.
7469 * window.h (check_all_windows): Likewise.
7470 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7471
5d4cb038
PE
7472 * sysdep.c (croak): Now static, if
7473 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7474 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7475
7476 * alloc.c (refill_memory_reserve): Now static if
7477 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7478 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7479
e87b6180
PE
7480 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7481 Define only if USE_LUCID.
7482
ac64929e
PE
7483 * xrdb.c (x_customization_string, x_rm_string): Now static.
7484
6f37259d
PE
7485 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7486 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7487
1683e3ab
PE
7488 * xdisp.c (draw_row_with_mouse_face): Now static.
7489 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7490
de9c2632
PE
7491 * window.h (check_all_windows): Mark externally visible.
7492
2b96acb7
PE
7493 * window.c (window_deletion_count): Now static.
7494
7495 * undo.c: Make symbols static if they're not exported.
7496 (last_undo_buffer, last_boundary_position, pending_boundary):
7497 Now static.
7498
50436f33
PE
7499 * textprop.c (interval_insert_behind_hooks): Now static.
7500 (interval_insert_in_front_hooks): Likewise.
7501
64520e5c
PE
7502 * term.c: Make symbols static if they're not exported.
7503 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7504 (max_frame_lines, tty_set_terminal_modes):
7505 (tty_reset_terminal_modes, tty_turn_off_highlight):
7506 (get_tty_terminal): Now static.
7507 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7508 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7509 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7510 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7511 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7512
1fa53021
PE
7513 * sysdep.c: Make symbols static if they're not exported.
7514 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7515 Now static.
7516 (sigprocmask_set, full_mask): Remove; unused.
7517 (wait_debugging): Mark as visible.
7518 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7519 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7520
d4b43b22
PE
7521 * syntax.c (syntax_temp): Define only if !__GNUC__.
7522
b7c513d0
PE
7523 * sound.c (current_sound_device, current_sound): Now static.
7524
989b29ad
PE
7525 * search.c (searchbufs, searchbuf_head): Now static.
7526
13a55a78
PE
7527 * scroll.c (scroll_cost): Remove; unused.
7528 * dispextern.h (scroll_cost): Remove decl.
7529
de68a1fc
PE
7530 * region-cache.h (pp_cache): Mark as externally visible.
7531
40ccffa6
PE
7532 * process.c: Make symbols static if they're not exported.
7533 (process_tick, update_tick, create_process, chan_process):
7534 (Vprocess_alist, proc_buffered_char, datagram_access):
7535 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7536 (deactivate_process): Mark defn as static, as well as decl.
7537 * lisp.h (create_process): Remove decl.
7538 * process.h (chan_process, Vprocess_alist): Remove decls.
7539
ad64fc97
PE
7540 * print.c: Make symbols static if they're not exported.
7541 (print_depth, new_backquote_output, being_printed, print_buffer):
7542 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7543 (print_interval, print_number_index, initial_stderr_stream):
7544 Now static.
7545 * lisp.h (Fprinc): Remove decl.
7546 (debug_output_compilation_hack): Mark as externally visible.
7547
adddb265
PE
7548 * sysdep.c (croak): Move decl from here to syssignal.h.
7549 * syssignal.h (croak): Put it here, so the API can be checked when
7550 'croak' is called from dissociate_if_controlling_tty.
7551
1717ede2
PE
7552 * minibuf.c: Make symbols static if they're not exported.
7553 (minibuf_save_list, choose_minibuf_frame): Now static.
7554 * lisp.h (choose_minibuf_frame): Remove decl.
7555
fa5fb2bc
PE
7556 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7557
1e3890d1
PE
7558 * lread.c: Make symbols static if they're not exported.
7559 (read_objects, initial_obarray, oblookup_last_bucket_number):
7560 Now static.
7561 (make_symbol): Remove; unused.
7562 * lisp.h (initial_obarray, make_symbol): Remove decls.
7563
8a1414fa
PE
7564 * keyboard.c: Make symbols static if they're not exported.
7565 (single_kboard, recent_keys_index, total_keys, recent_keys):
7566 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7567 (this_single_command_key_start, echoing, last_auto_save):
7568 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7569 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7570 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7571 (Vlispy_mouse_stem, double_click_count):
7572 Now static.
7573 (force_auto_save_soon): Define only if SIGDANGER.
7574 (ignore_mouse_drag_p): Now static if
7575 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7576 (print_help): Remove; unused.
7577 (stop_character, last_timer_event): Mark as externally visible.
7578 * keyboard.h (ignore_mouse_drag_p): Declare only if
7579 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7580 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7581 * lisp.h (echoing): Remove decl.
7582 (force_auto_save_soon): Declare only if SIGDANGER.
7583 * xdisp.c (redisplay_window): Simplify code, to make it more
7584 obvious that ignore_mouse_drag_p is not accessed if !defined
7585 USE_GTK && !defined HAVE_NS.
7586
93ea6e8f
PE
7587 * intervals.c: Make symbols static if they're not exported.
7588 (merge_properties_sticky, merge_interval_right, delete_interval):
7589 Now static.
7590 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7591
77382fcc
PE
7592 * insdel.c: Make symbols static if they're not exported.
7593 However, leave prepare_to_modify_buffer alone. It's never
7594 called from outside this function, but that appears to be a bug.
7595 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7596 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7597 (adjust_after_replace_noundo): Remove; unused.
7598 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7599 (signal_before_change): Remove decls.
77382fcc 7600
9306c32e
PE
7601 * indent.c (val_compute_motion, val_vmotion): Now static.
7602
cd44d2eb
PE
7603 * image.c: Make symbols static if they're not exported.
7604 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7605 if USE_GTK.
7606 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7607 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7608
ad9a7a06
PE
7609 * fringe.c (standard_bitmaps): Now static.
7610 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7611
81626931
PE
7612 * frame.c: Make symbols static if they're not exported.
7613 (x_report_frame_params, make_terminal_frame): Now static.
7614 (get_frame_param): Now static, unless HAVE_NS.
7615 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7616 (x_get_resource_string): Remove; not used.
7617 * frame.h (make_terminal_frame, x_report_frame_params):
7618 (x_get_resource_string); Remove decls.
7619 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7620 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7621
239f9db9
PE
7622 * font.c, fontset.c: Make symbols static if they're not exported.
7623 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7624 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7625 * font.c (font_close_object): Now static.
7626 * font.h (font_close_object): Remove.
7627 * fontset.c (FONTSET_OBJLIST): Remove.
7628 (free_realized_fontset) #if-0 the body, which does nothing.
7629 (face_suitable_for_char_p): #if-0, as it's never called.
7630 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7631 * xfaces.c (face_at_string_position):
7632 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7633 since 0 is always ASCII.
7634
dfcf3579
PE
7635 * fns.c (weak_hash_tables): Now static.
7636
5045092b
PE
7637 * fileio.c: Make symbols static if they're not exported.
7638 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7639 (Vwrite_region_annotation_buffers): Now static.
7640
57a96f5c
PE
7641 * eval.c: Make symbols static if they're not exported.
7642 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7643 * lisp.h (backtrace_list): Remove decl.
7644
35f08c38
PE
7645 * emacs.c: Make symbols static if they're not exported.
7646 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7647 (fatal_error_code, fatal_error_signal_hook, standard_args):
7648 Now static.
7649 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7650 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7651 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7652 * lisp.h (fatal_error_signal_hook): Remove decl.
7653 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7654
f44bd759
PE
7655 * editfns.c: Move a (normally-unused) function to its only use.
7656 * editfns.c, lisp.h (get_operating_system_release): Remove.
7657 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7658 worth the hassle of breaking this out.
7659
b532497d
PE
7660 * xterm.c: Make symbols static if they're not exported.
7661 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7662 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7663 (x_destroy_window, x_delete_display):
7664 Now static.
7665 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7666 (x_mouse_leave): Remove; unused.
7667 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7668 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7669 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7670 Remove decls.
7671 (x_mouse_leave): Declare only if WINDOWSNT.
7672 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7673 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7674 USE_X_TOOLKIT.
7675
1675728f
PE
7676 * ftxfont.c: Make symbols static if they're not exported.
7677 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7678 HAVE_FREETYPE.
7679 * font.h (ftxfont_driver): Likewise.
7680
e4cebfca
PE
7681 * xfns.c: Make symbols static if they're not exported.
7682 (x_last_font_name, x_display_info_for_name):
7683 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7684 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7685 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7686 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7687 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7688 (last_show_tip_args): Now static.
7689 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7690 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7691 (x_screen_planes): Remove; unused.
7692 * dispextern.h (x_screen_planes): Remove decl.
7693
5bf46f05
PE
7694 * dispnew.c: Make symbols static if they're not exported.
7695 * dispextern.h (redraw_garbaged_frames, scrolling):
7696 (increment_row_positions): Remove.
7697 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7698 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7699 Now static.
7700 (redraw_garbaged_frames): Remove; unused.
7701
435f4c28
PE
7702 * xfaces.c: Make symbols static if they're not exported.
7703 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7704 Remove decls.
7705 * xterm.h (defined_color): Remove decls.
7706 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7707 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7708 (menu_face_changed_default, defined_color, free_realized_face):
7709 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7710 (ascii_face_of_lisp_face): Remove; unused.
7711
8524aef3
PE
7712 * xdisp.c: Make symbols static if they're not exported.
7713 * dispextern.h (scratch_glyph_row, window_box_edges):
7714 (glyph_to_pixel_coords, set_cursor_from_row):
7715 (get_next_display_element, set_iterator_to_next):
7716 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7717 (show_mouse_face): Remove decls
7718 * frame.h (message_buf_print): Likewise.
7719 * lisp.h (pop_message, set_message, check_point_in_composition):
7720 Likewise.
7721 * xterm.h (set_vertical_scroll_bar): Likewise.
7722 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7723 (message_buf_print, scratch_glyph_row, displayed_buffer):
7724 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7725 (get_next_display_element, show_mouse_face, window_box_edges):
7726 (frame_to_window_pixel_xy, check_point_in_composition):
7727 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7728 (glyph_to_pixel_coords): Remove; unused.
7729
16390cd2
PE
7730 * dired.c (file_name_completion): Now static.
7731
7732 * dbusbind.c (xd_in_read_queued_messages): Now static.
7733
a25f4dfa
PE
7734 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7735 * data.c (circular_list_error): Remove.
7736
14a9c8df
PE
7737 * commands.h (last_point_position, last_point_position_buffer):
7738 (last_point_position_window): Remove decls.
7739 * keyboard.c: Make these variables static.
7740
04f2d78b
CB
7741 * coding.h (coding, code_convert_region, encode_coding_gap):
7742 Remove decls.
74ab6df5
PE
7743 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7744 (iso_code_class, detect_coding, code_convert_region): Now static.
7745 (encode_coding_gap): Remove; unused.
7746
38dfbee1
PE
7747 * chartab.c (chartab_chars, chartab_bits): Now static.
7748
a2cb4e63
PE
7749 * charset.h (charset_iso_8859_1): Remove decl.
7750 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7751 Now static.
7752
127198fd
PE
7753 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7754 * ccl.c (Vccl_program_table): Now static.
7755 (check_ccl_update): Remove; unused.
7756
d85b608f
PE
7757 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7758 * category.h: ... from here.
7759 * category.c (check_category_table, set_category_set): Now static.
7760
31cd66f3
PE
7761 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7762 * lisp.h: Remove these decls.
7763
c358e587
PE
7764 * buffer.c (buffer_count): Remove unused var.
7765
e78aecca
PE
7766 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7767 so that it's not optimized away.
7768 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7769 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7770 exported only to the debugger.
7771
e192d7d3 7772 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7773 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7774
92470028
PE
7775 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7776 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7777 was inaccessible from Lisp.
7778 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7779 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7780
244ed907
PE
7781 alloc.c: Import and export fewer symbols, and remove unused items.
7782 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7783 is defined.
7784 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7785 it's not optimized away by whole-program optimization.
7786 (message_enable_multibyte, free_misc): Remove.
7787 (catchlist, handlerlist, mark_backtrace):
7788 Declare only if BYTE_MARK_STACK.
7789 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7790 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7791 (message_enable_multibyte): Remove decl.
7792 (free_misc, interval_free_list, float_block, float_block_index):
7793 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7794 (cons_free_list, last_marked_index):
7795 Now static.
7796 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7797 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7798 (mark_backtrace): Define only if BYTE_MARK_STACK.
7799 * xdisp.c (message_enable_multibyte): Now static.
7800
61c2b50e 7801 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7802 This makes it easier for human readers (and static analyzers)
7803 to see whether these variables are used from other modules.
7804 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7805 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7806 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7807 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7808 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7809 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7810 * xmenu.c, xselect.c:
7811 Declare Q* vars static if they are not used in other modules.
7812 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7813 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7814 Remove decls of unexported vars.
7815 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7816
95c82688
PE
7817 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7818
16a97296
PE
7819 Make Emacs functions such as Fatom 'static' by default.
7820 This makes it easier for human readers (and static analyzers)
7821 to see whether these functions can be called from other modules.
7822 DEFUN now defines a static function. To make the function external
7823 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7824 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7825 (Finit_image_library):
16a97296
PE
7826 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7827 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7828 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7829 Remove decls, since these functions are now static.
7830 (Funintern, Fget_internal_run_time): New decls, since these functions
7831 were already external.
95c82688 7832
16a97296
PE
7833 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7834 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7835 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7836 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7837 * keyboard.c, keymap.c, lread.c:
7838 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7839 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7840 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7841 Mark functions with DEFUE instead of DEFUN,
7842 if they are used in other modules.
7843 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7844 decls for now-static functions.
7845 * buffer.h (Fdelete_overlay): Remove decl.
7846 * callproc.c (Fgetenv_internal): Mark as internal.
7847 * composite.c (Fremove_list_of_text_properties): Remove decl.
7848 (Fcomposition_get_gstring): New forward static decl.
7849 * composite.h (Fcomposite_get_gstring): Remove decl.
7850 * dired.c (Ffile_attributes): New forward static decl.
7851 * doc.c (Fdocumntation_property): New forward static decl.
7852 * eval.c (Ffetch_bytecode): New forward static decl.
7853 (Funintern): Remove extern decl; now in .h file where it belongs.
7854 * fileio.c (Fmake_symbolic_link): New forward static decl.
7855 * image.c (Finit_image_library): New forward static decl.
7856 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7857 * intervals.h (Fprevious_property_change):
7858 (Fremove_list_of_text_properties): Remove decls.
7859 * keyboard.c (Fthis_command_keys): Remove decl.
7860 (Fcommand_execute): New forward static decl.
7861 * keymap.c (Flookup_key): New forward static decl.
7862 (Fcopy_keymap): Now static.
7863 * keymap.h (Flookup_key): Remove decl.
7864 * process.c (Fget_process): New forward static decl.
7865 (Fprocess_datagram_address): Mark as internal.
7866 * syntax.c (Fsyntax_table_p): New forward static decl.
7867 (skip_chars): Remove duplicate decl.
7868 * textprop.c (Fprevious_property_change): New forward static decl.
7869 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7870 Now internal.
7871 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7872 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7873
785bbd42
PE
7874 * editfns.c (Fformat): Remove unreachable code.
7875
8b913b57
AS
78762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7877
7878 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7879 change. (Bug#8496)
7880
a6744a35
EZ
78812011-04-13 Eli Zaretskii <eliz@gnu.org>
7882
7883 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7884 when at ZV. (Bug#8487)
7885
e7974947
AS
78862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7887
baad03f0
AS
7888 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7889 (Bug#8437)
7890 * keyboard.c (parse_tool_bar_item): Likewise.
7891 * sound.c (sound_cleanup, alsa_close): Likewise.
7892 * termcap.c (tgetent): Likewise.
7893 * xfns.c (x_default_font_parameter): Likewise.
7894 * xsettings.c (read_and_apply_settings): Likewise.
7895
e7974947
AS
7896 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7897 (overrun_check_free): Protoize.
7898
28272684
PE
78992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7900
7901 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7902 since callers should never pass a negative size.
7903 Change the signature to match that of plain 'read' and 'write'; see
7904 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7905 * lisp.h: Update prototypes of emacs_write and emacs_read.
7906
11997c76
EZ
79072011-04-11 Eli Zaretskii <eliz@gnu.org>
7908
7909 * xdisp.c (redisplay_window): Don't try to determine the character
7910 position of the scroll margin if the window start point w->startp
e896f03c 7911 is outside the buffer's accessible region. (Bug#8468)
11997c76 7912
8a2cbd72
EZ
79132011-04-10 Eli Zaretskii <eliz@gnu.org>
7914
7915 Fix write-region and its subroutines for buffers > 2GB.
7916 * fileio.c (a_write, e_write): Modify declaration of arguments and
7917 local variables to support buffers larger than 2GB.
7918 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7919
7920 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7921 argument, local variables, and return value.
7922
7923 * lisp.h: Update prototypes of emacs_write and emacs_read.
7924
7925 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7926
4073e537 79272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7928
1ebfdcb6
PE
7929 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7930
b2ded58d
PE
7931 Fix more problems found by GCC 4.6.0's static checks.
7932
7d66342c
PE
7933 * xdisp.c (vmessage): Use a better test for character truncation.
7934
bbf47d44
PE
7935 * charset.c (load_charset_map): <, not <=, for optimization,
7936 and to avoid potential problems with integer overflow.
9248994d 7937 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7938 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7939 * editfns.c (Fformat): Likewise.
1e69125e 7940 * syntax.c (skip_chars): Likewise.
3befa583 7941
e3019616
PE
7942 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7943 This also lets GCC 4.6.0 generate slightly better loop code.
7944
becfa255
PE
7945 * callint.c (Fcall_interactively): <, not <=, for optimization.
7946 (Fcall_interactively): Count the number of arguments produced,
7947 not the number of arguments given. This is simpler and lets GCC
7948 4.6.0 generate slightly better code.
7949
dae0cd48
PE
7950 * ftfont.c: Distingish more carefully between FcChar8 and char.
7951 The previous code passed unsigned char * to a functions like
7952 strlen and xstrcasecmp that expect char *, which does not
7953 conform to the C standard.
7954 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7955 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7956 char * when the C standard requires it.
7957
76032d70
PE
7958 * keyboard.c (read_char): Remove unused var.
7959
eb3f1cc8
PE
7960 * eval.c: Port to Windows vsnprintf (Bug#8435).
7961 Include <limits.h>.
7962 (SIZE_MAX): Define if the headers do not.
7963 (verror): Do not give up if vsnprintf returns a negative count.
7964 Instead, grow the buffer. This ports to Windows vsnprintf, which
7965 does not conform to C99. Problem reported by Eli Zaretskii.
7966 Also, simplify the allocation scheme, by avoiding the need for
7967 calling realloc, and removing the ALLOCATED variable.
7968
70476b54
PE
7969 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7970
12020a9e
PE
7971 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7972 But keep the doprint source code for now, as we might revamp it
7973 and use it again (Bug#8435).
ea6c7ae6
PE
7974 * lisp.h (doprnt): Remove.
7975 * Makefile.in (base_obj): Remove doprnt.o.
7976 * deps.mk (doprnt.o): Remove.
7977
5fdb398c
PE
7978 error: Print 32- and 64-bit integers portably (Bug#8435).
7979 Without this change, on typical 64-bit hosts error ("...%d...", N)
7980 was used to print both 32- and 64-bit integers N, which relied on
7981 undefined behavior.
61bdb816 7982 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7983 * lisp.h (error, verror): Mark as printf-like functions.
7984 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7985 Report overflow in size calculations when allocating printf buffer.
7986 Do not truncate output string at its first null byte.
7987 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7988 Truncate the output at a character boundary, since vsnprintf does not
7989 do that.
7990 * charset.c (check_iso_charset_parameter): Convert internal
7991 character to string before calling 'error', since %c now has the
7992 printf meaning.
7993 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7994 overflow when computing char to be passed to 'error'. Do not
7995 pass Lisp_Object to 'error'; pass the integer instead.
7996 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7997 formatted with plain %d.
7998
b189fa66
PE
7999 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8000
bff87ef0
PE
8001 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8002
7e2cac20
PE
8003 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8004
ce4d90b5
PE
8005 * xterm.c (x_catch_errors): Remove duplicate declaration.
8006
266c9547
PE
8007 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8008
79c49ad2
PE
8009 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8010
368f4090
JM
80112011-04-10 Jim Meyering <meyering@redhat.com>
8012
8013 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8014 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8015 return ssize_t not "int", and use size_t as the buffer length.
8016 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8017 * gnutls.h: Update declarations.
8018 * process.c (read_process_output): Use ssize_t, to match.
8019 (send_process): Likewise.
8020
a32d4040
CY
80212011-04-09 Chong Yidong <cyd@stupidchicken.com>
8022
8023 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8024
8546720e 80252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8026
04f2d78b
CB
8027 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8028 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8029
8546720e
GM
8030 * xterm.c (handle_one_xevent):
8031 * xmenu.c (create_and_show_popup_menu):
8032 * xselect.c (x_decline_selection_request)
8033 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8034
0a2f5c1a 80352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8036
8037 Fix some uses of `int' instead of EMACS_INT.
8038 * search.c (string_match_1, fast_string_match)
8039 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8040 (scan_buffer, find_next_newline_no_quit)
8041 (find_before_next_newline, search_command, Freplace_match)
8042 (Fmatch_data): Make some `int' variables be EMACS_INT.
8043
8044 * xdisp.c (display_count_lines): 3rd argument and return value now
8045 EMACS_INT. All callers changed.
8046 (pint2hrstr): Last argument is now EMACS_INT.
8047
8048 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8049 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8050 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8051 (decode_coding_utf_16, decode_coding_emacs_mule)
8052 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8053 (decode_coding_ccl, decode_coding_charset)
8054 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8055 (decode_coding_iso_2022, decode_coding_emacs_mule)
8056 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8057 <char_offset, last_offset>: Declare EMACS_INT.
8058 (encode_coding_utf_8, encode_coding_utf_16)
8059 (encode_coding_emacs_mule, encode_invocation_designation)
8060 (encode_designation_at_bol, encode_coding_iso_2022)
8061 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8062 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8063 Declare EMACS_INT.
8064 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8065 (encode_invocation_designation): Last argument P_NCHARS is now
8066 EMACS_INT.
8067 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8068 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8069
8070 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8071 All users changed.
8072
8073 * ccl.c (Fccl_execute_on_string): Declare some variables
8074 EMACS_INT.
8075
8546720e 80762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8077
8078 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8079
4e19a977
CS
80802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8081
8082 * process.c (Fformat_network_address): Doc fix.
8083
87302331
R
80842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8085
ee7683eb 8086 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8087
cbb59342
CY
80882011-04-08 Chong Yidong <cyd@stupidchicken.com>
8089
8090 * keyboard.c (read_char): Call Lisp function help-form-show,
8091 instead of using internal_with_output_to_temp_buffer.
8092 (Qhelp_form_show): New var.
e0d38eeb 8093 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8094
8095 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8096
8097 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8098
e67a13ab
CY
80992011-04-06 Chong Yidong <cyd@stupidchicken.com>
8100
04f2d78b
CB
8101 * process.c (Flist_processes): Remove to Lisp.
8102 (list_processes_1): Delete.
e67a13ab 8103
973f782d
EZ
81042011-04-06 Eli Zaretskii <eliz@gnu.org>
8105
7c106b1e
EZ
8106 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8107
973f782d
EZ
8108 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8109
41cf7d1a 81102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8111
ca23cc88
PE
8112 Fix more problems found by GCC 4.6.0's static checks.
8113
f390e2d5
PE
8114 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8115
42eea0d0
PE
8116 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8117
b69769da 8118 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8119
f9541e84
PE
8120 * xdisp.c (vmessage): Mark as a printf-like function.
8121
13841b55
PE
8122 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8123
c136c10f
PE
8124 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8125
5e2d4a30
PE
8126 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8127 printf-like functions.
8128 (tiff_load): Add casts to remove these marks before passing them
8129 to system-supplied API.
8130
583f48b9
PE
8131 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8132
b25d760e
PE
8133 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8134 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8135 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8136 directly, rather than having caller test rule sign. This avoids
8137 some unnecessary tests.
8138 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8139 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8140 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8141
bc7b6697 8142 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8143 (xfont_open): Avoid unnecessary tests.
bc7b6697 8144
27ccc379
PE
8145 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8146
dcd5c89a
PE
8147 * composite.h, composite.c (composition_gstring_put_cache):
8148 Use EMACS_INT, not int, for length.
8149
b13a45c6
PE
8150 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8151 breaking out part of COMPOSITION_DECODE_RULE.
8152 (COMPOSITION_DECODE_RULE): Use it.
8153 * composite.c (get_composition_id): Remove unused local vars,
8154 by using the new macro.
8155
1e792e4d
PE
8156 * textprop.c (set_text_properties_1): Change while to do-while,
8157 since the condition is always true at first.
8158
dc6c6455 8159 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8160 (interval_deletion_adjustment): Return unsigned value.
8161 All uses changed.
dc6c6455 8162
aba7731a
PE
8163 * process.c (list_processes_1, create_pty, read_process_output):
8164 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8165 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8166 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8167 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8168 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8169
fdfc4bf3
PE
8170 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8171
fca8fe46 8172 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8173 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8174
06a0259a 8175 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8176 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8177 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8178
e7b9e80f
PE
8179 * print.c (print_error_message): Avoid int overflow.
8180
56201685
PE
8181 * font.c (font_list_entities): Redo for clarity,
8182 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8183
78834453 8184 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8185 (font_score): Avoid potential overflow in diff calculation.
78834453 8186
0bc0b309 8187 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8188 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8189
e610eaca
PE
8190 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8191
b895abce
PE
8192 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8193 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8194 can always succeed if overflow has undefined behavior.
8195
1f1d9321 8196 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8197 (wordify): Omit three unnecessary tests.
1f1d9321 8198
c59478bc
PE
8199 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8200 All callers changed. This avoids the need for an unused var.
8201
79b73827
PE
8202 * casefiddle.c (casify_region): Remove var that is set but not used.
8203
a4db5dfe
PE
8204 * dired.c (file_name_completion): Remove var that is set but not used.
8205
43aae36e
PE
8206 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8207
2a47c44d 8208 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8209 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8210
a37c69bf
PE
8211 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8212 Check for integer overflow on size calculations.
8213
328ab8e7
PE
8214 * buffer.c (Fprevious_overlay_change): Remove var that is set
8215 but not used.
8216
e5a2a5cb
PE
8217 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8218 Remove vars that are set but not used.
8d84a6eb 8219 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8220 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8221
a60e5f68
PE
8222 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8223
f661cb61 8224 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8225 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8226
f0397f5a
PE
8227 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8228 that are set but not used.
8229
8664db06 8230 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8231 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8232
6abdaa4a
PE
8233 * xselect.c (x_get_local_selection, x_handle_property_notify):
8234 Remove vars that are set but not used.
8235
0ce7538d 8236 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8237 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8238
9ae848fc
PE
8239 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8240 Remove var that is set but not used.
0b918413
PE
8241 (scroll_bar_windows_size): Now size_t, not int.
8242 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8243 Check for overflow.
9ae848fc 8244
a5a62657
PE
8245 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8246 (map_tty_color) [!defined MSDOS]: Likewise.
8247
5c5cdd39
PE
8248 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8249
66ebf983
PE
8250 * coding.c: Remove vars that are set but not used.
8251 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8252 All callers changed.
8253 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8254 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8255 (decode_coding_charset): Remove vars that are set but not used.
8256
1be4d761
PE
8257 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8258 that is set but not used.
8259
47553fa8
PE
8260 * print.c (print_object): Remove var that is set but not used.
8261
1f7196bf 8262 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8263 The gnulib version avoids calling malloc in the usual case,
8264 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8265 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8266 * filelock.c (current_lock_owner): Likewise.
8267 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8268 * sysdep.c: Include allocator.h, careadlinkat.h.
8269 (emacs_no_realloc_allocator): New static constant.
8270 (emacs_readlink): New function.
fdb61804
PE
8271 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8272 ../lib/careadlinkat.h.
d1fdcab7 8273
f84c17c7
SM
82742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8275
8276 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8277 first non-nil return value).
8278
ef3862ad
JD
82792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8280
8281 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8282 if not defined (Bug#8403).
8283
376a7006
JB
82842011-04-02 Juanma Barranquero <lekktu@gmail.com>
8285
8286 * xdisp.c (display_count_lines): Remove parameter `start',
8287 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8288 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8289 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8290 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8291 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8292 and thereabouts. All callers changed.
8293 (get_per_char_metric): Remove parameter `f', unused since
8294 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8295
6ca3801d
JM
82962011-04-02 Jim Meyering <meyering@redhat.com>
8297
8298 do not dereference NULL upon failed strdup
8299 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8300 (ns_get_family): Likewise.
8301
d8e2b5ba
JB
83022011-04-02 Juanma Barranquero <lekktu@gmail.com>
8303
8304 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8305
8c74fcbd
JD
83062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8307
8308 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8309 later (Bug#8403).
8310
7200d79c
SM
83112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8312
03408648 8313 Add lexical binding.
7200d79c 8314
03408648
SM
8315 * window.c (Ftemp_output_buffer_show): New fun.
8316 (Fsave_window_excursion):
8317 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8318
8319 * lread.c (lisp_file_lexically_bound_p): New function.
8320 (Fload): Bind Qlexical_binding.
8321 (readevalloop): Remove `evalfun' arg.
8322 Bind Qinternal_interpreter_environment.
8323 (Feval_buffer): Bind Qlexical_binding.
8324 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8325 Mark as dynamic.
8326 (syms_of_lread): Declare `lexical-binding'.
8327
8328 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8329
8330 * keyboard.c (eval_dyn): New fun.
8331 (menu_item_eval_property): Use it.
ca105506
SM
8332
8333 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8334
03408648
SM
8335 * fns.c (concat, mapcar1): Accept byte-code-functions.
8336
8337 * eval.c (Fsetq): Handle lexical vars.
8338 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8339 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8340 (FletX, Flet): Obey lexical binding.
8341 (Fcommandp): Handle closures.
8342 (Feval): New `lexical' arg.
8343 (eval_sub): New function extracted from Feval. Use it almost
8344 everywhere where Feval was used. Look up vars in lexical env.
8345 Handle closures.
8346 (Ffunctionp): Move from subr.el.
8347 (Ffuncall): Handle closures.
8348 (apply_lambda): Remove `eval_flags'.
8349 (funcall_lambda): Handle closures and new byte-code-functions.
8350 (Fspecial_variable_p): New function.
8351 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8352 but without exporting it to Lisp.
23aba0ea 8353
23aba0ea 8354 * doc.c (Fdocumentation, store_function_docstring):
03408648 8355 * data.c (Finteractive_form): Handle closures.
23aba0ea 8356
03408648
SM
8357 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8358 interactive spec.
ba83908c 8359
04f2d78b
CB
8360 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8361 New byte-codes.
03408648
SM
8362 (exec_byte_code): New function extracted from Fbyte_code to handle new
8363 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8364
03408648 8365 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8366
03408648 8367 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8368
e2abce01
JB
83692011-03-31 Juanma Barranquero <lekktu@gmail.com>
8370
8371 * xdisp.c (redisplay_internal): Fix prototype.
8372
63696a73 83732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8374
63696a73 8375 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8376 (try_scrolling): Use it when setting scroll_limit.
8377 Limit scrolling to 100 screen lines.
63696a73
EZ
8378 (redisplay_window): Even when falling back on "recentering",
8379 position point in the window according to scroll-conservatively,
8380 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8381
8382 (try_scrolling): When point is above the window, allow searching
8383 as far as scroll_max, or one screenful, to compute vertical
8384 distance from PT to the scroll margin position. This prevents
8385 try_scrolling from unnecessarily failing when
8386 scroll-conservatively is set to a value slightly larger than the
8387 window height. Clean up the case of PT below the margin at bottom
8388 of window: scroll_max can no longer be INT_MAX. When aggressive
8389 scrolling is in use, don't let point enter the opposite scroll
8390 margin as result of the scroll.
8391 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8392 threshold of 100 lines for never-recentering scrolling.
8393
e4cc2dfc
JB
83942011-03-31 Juanma Barranquero <lekktu@gmail.com>
8395
8396 * dispextern.h (move_it_by_lines):
8397 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8398 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8399 (message_log_check_duplicate): Remove parameters `prev_bol' and
8400 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8401 (redisplay_internal): Remove parameter `preserve_echo_area',
8402 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8403
8404 * indent.c (Fvertical_motion):
8405 * window.c (window_scroll_pixel_based, Frecenter):
8406 Don't pass `need_y_p' to `move_it_by_lines'.
8407
1c470562
SM
84082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8409
44f230aa
SM
8410 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8411 steal a few bits to be more compact.
8412 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8413 Remove unneeded casts.
8414
1c470562
SM
8415 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8416
888adce9
ZK
84172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8418
8419 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8420 binding" message (bug#7967).
8421
f838ed7b
PE
84222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8423
77861b95
PE
8424 Fix more problems found by GCC 4.6.0's static checks.
8425
de6dbc14
PE
8426 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8427 Remove unused local var.
8428
f838ed7b
PE
8429 * editfns.c (Fmessage_box): Remove unused local var.
8430
792c7b2b
PE
8431 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8432 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8433 Omit unused local vars.
c499e557 8434 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8435 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8436 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8437 Omit unused local var.
8438
ba0165e1
PE
8439 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8440 Don't assume string length fits in int.
32ad8845 8441 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8442 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8443
3c59b4c9
PE
8444 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8445 instead of alloca (Bug#8344).
8446
a3eed478 8447 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8448 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8449
eb4d412d
PE
8450 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8451
1658b401
PE
8452 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8453 concerns.
8454
8455 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8456
8457 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8458
9a2c6e05
PE
8459 * keyboard.c (syms_of_keyboard): Use the same style as later
8460 in this function when indexing through an array. This also
8461 works around GCC bug 48267.
8462
03d0a109
PE
8463 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8464
44f730c8
PE
8465 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8466
fe75f926
PE
8467 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8468 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8469
ffa8c828
PE
8470 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8471 This avoids undefined behavior on integer overflow, and is a bit
8472 more convenient anyway since it is compared to a size_t variable.
8473
c5101a77
PE
8474 Variadic C functions now count arguments with size_t, not int.
8475 This avoids an unnecessary limitation on 64-bit machines, which
8476 caused (substring ...) to crash on large vectors (Bug#8344).
8477 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8478 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8479 All variadic functions and their callers changed accordingly.
c5101a77
PE
8480 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8481 * data.c (arith_driver, float_arith_driver): Likewise.
8482 * editfns.c (general_insert_function): Likewise.
8483 * eval.c (struct backtrace.nargs, interactive_p)
8484 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8485 (funcall_lambda, mark_backtrace): Likewise.
8486 * fns.c (concat): Likewise.
8487 * frame.c (x_set_frame_parameters): Likewise.
8488 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8489 0 if not found, not -1. All callers changed.
8490
dd3f25f7
PE
8491 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8492 (stack_copy_size): Now size_t, not int.
8493 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8494
461c2ab9
JB
84952011-03-28 Juanma Barranquero <lekktu@gmail.com>
8496
8497 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8498 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8499 All callers changed.
8500
8501 * lisp.h (multibyte_char_to_unibyte):
8502 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8503 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8504 * character.h (CHAR_TO_BYTE8):
8505 * cmds.c (internal_self_insert):
8506 * editfns.c (general_insert_function):
8507 * keymap.c (push_key_description):
8508 * search.c (Freplace_match):
8509 * xdisp.c (message_dolog, set_message_1): All callers changed.
8510
f6d62986
SM
85112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8512
8513 * keyboard.c (safe_run_hook_funcall): New function.
8514 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8515 don't set the hook to nil, but remove the offending function instead.
8516 (Qcommand_hook_internal): Remove, unused.
8517 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8518 Vcommand_hook_internal.
8519
8520 * eval.c (enum run_hooks_condition): Remove.
8521 (funcall_nil, funcall_not): New functions.
8522 (run_hook_with_args): Call each function through a `funcall' argument.
8523 Remove `cond' argument, now redundant.
8524 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8525 (Frun_hook_with_args_until_failure): Adjust accordingly.
8526 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8527
1db5b1ad
JB
85282011-03-28 Juanma Barranquero <lekktu@gmail.com>
8529
8530 * dispextern.h (string_buffer_position): Remove declaration.
8531
8532 * print.c (strout): Remove parameter `multibyte', unused since
8533 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8534
8535 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8536 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8537 All callers changed.
8538
8539 * w32.c (_wsa_errlist): Use braces for struct initializers.
8540
8541 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8542 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8543 All callers changed.
8544 (string_buffer_position): Likewise. Also, make static (it's never
8545 used outside xdisp.c).
8546 (cursor_row_p): Remove parameter `w', unused since
8547 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8548 (decode_mode_spec): Remove parameter `precision', introduced during
8549 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8550 All callers changed.
8551
5ffb62aa
JD
85522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8553
8554 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8555
461c2ab9 85562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8557
8558 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8559 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8560 (ns_update_auto_hide_menu_bar): New functions.
8561 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8562 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8563 ns_constrain_all_frames.
8564 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8565 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8566
5c380ffb
JD
85672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8568
8569 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8570
9af30bdf
GM
85712011-03-27 Glenn Morris <rgm@gnu.org>
8572
8573 * syssignal.h: Replace RETSIGTYPE with void.
8574 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8575 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8576 Replace SIGTYPE with void everywhere.
8577 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8578 * s/template.h (SIGTYPE): Remove commented out definition.
8579
e2abce01
JB
85802011-03-26 Eli Zaretskii <eliz@gnu.org>
8581
8582 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8583 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8584
f868cd8a
JB
85852011-03-26 Juanma Barranquero <lekktu@gmail.com>
8586
59eb0929
JB
8587 * w32.c (read_unc_volume): Use parameter `henum', instead of
8588 global variable `wget_enum_handle'.
8589
8590 * keymap.c (describe_vector): Remove parameters `indices' and
8591 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8592 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8593
f868cd8a
JB
8594 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8595
8596 * keyboard.c (timer_check): Remove parameter `do_it_now',
8597 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8598 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8599 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8600
8601 * keyboard.c (read_char):
8602 * w32menu.c (w32_menu_display_help):
8603 * xmenu.c (show_help_event, menu_help_callback):
8604 Adjust calls to `show_help_echo'.
8605
8606 * gtkutil.c (xg_maybe_add_timer):
8607 * keyboard.c (readable_events):
8608 * process.c (wait_reading_process_output):
8609 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8610
8611 * insdel.c (adjust_markers_gap_motion):
8612 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8613 (gap_left, gap_right): Don't call it.
8614
2ecf6fdb
CY
86152011-03-25 Chong Yidong <cyd@stupidchicken.com>
8616
8617 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8618 incurred during fontification.
8619
6b1f9ba4
JB
86202011-03-25 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8623 (DEFVAR_PER_BUFFER): Don't pass it.
8624
8625 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8626 (scrolling_window): Don't pass it.
8627
0f4a96b5
JB
86282011-03-25 Juanma Barranquero <lekktu@gmail.com>
8629
8630 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8631
8632 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8633 and `suffix'.
8634 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8635 of variables specific to SELinux and computation of `encoded_absname'.
8636
8637 * image.c (XPutPixel): Remove unused variable `height'.
8638
8639 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8640
8641 * unexw32.c (get_section_info): Remove unused variable `section'.
8642
8643 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8644 (system_process_attributes): Remove unused variable `sess'.
8645 (sys_read): Remove unused variable `err'.
8646
8647 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8648 (w32_wnd_proc): Remove unused variable `isdead'.
8649 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8650 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8651 (x_create_tip_frame): Remove unused variable `tem'.
8652
8653 * w32inevt.c (w32_console_read_socket):
8654 Remove unused variable `no_events'.
8655
8656 * w32term.c (x_draw_composite_glyph_string_foreground):
8657 Remove unused variable `width'.
8658
1149507c
JB
86592011-03-24 Juanma Barranquero <lekktu@gmail.com>
8660
8661 * w32term.c (x_set_glyph_string_clipping):
8662 Don't pass uninitialized region to CombineRgn.
8663
9c88f339
JB
86642011-03-23 Juanma Barranquero <lekktu@gmail.com>
8665
8666 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8667 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8668 (Fx_close_connection): Remove unused variable `i'.
8669
8670 * w32font.c (w32font_draw): Return number of glyphs.
8671 (w32font_open_internal): Remove unused variable `i'.
8672 (w32font_driver): Add missing initializer.
8673
8674 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8675 (fill_in_menu): Remove unused variable `items_added'.
8676
8677 * w32term.c (last_mouse_press_frame): Remove static global variable.
8678 (w32_clip_to_row): Remove unused variable `f'.
8679 (x_delete_terminal): Remove unused variable `i'.
8680
8681 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8682 (NOTHING): Remove unused static global variable.
8683 (uniscribe_check_otf): Remove unused variable `table'.
8684 (uniscribe_font_driver): Add missing initializers.
8685
dee091a3
JD
86862011-03-23 Julien Danjou <julien@danjou.info>
8687
8688 * term.c (Fsuspend_tty, Fresume_tty):
8689 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8690 * window.c (temp_output_buffer_show):
8691 * insdel.c (signal_before_change):
8692 * frame.c (Fhandle_switch_frame):
8693 * fileio.c (Fdo_auto_save):
8694 * emacs.c (Fkill_emacs):
8695 * editfns.c (save_excursion_restore):
8696 * cmds.c (internal_self_insert):
8697 * callint.c (Fcall_interactively):
8698 * buffer.c (Fkill_all_local_variables):
8699 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8700 Use Frun_hooks.
0f4a96b5 8701 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8702 unconditionally since it does the check itself.
dee091a3 8703
2c520ab5 87042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8705
c9c49752
PE
8706 Fix more problems found by GCC 4.5.2's static checks.
8707
8abc3f12
PE
8708 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8709 the first time through the loop, since we know p0 < p1 then.
8710 This also avoids a gcc -Wstrict-overflow warning.
8711
a2d26660
PE
8712 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8713 leading to a memory leak, possible in functions like
8714 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8715 of objects (Bug#8318).
a2d26660 8716
916c72e9
PE
8717 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8718 that could (at least in theory) be that large.
8719
19ab8a18
PE
8720 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8721 This is less likely to overflow, and avoids undefined behavior if
8722 overflow does occur. All callers changed. Use strtoul to scan
8723 for the unsigned long integer.
b7cbbd6f
PE
8724 (pint2hrstr): Simplify and tune code slightly.
8725 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8726
f0641eff
PE
8727 * scroll.c (do_scrolling): Work around GCC bug 48228.
8728 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8729
7f650bb9
PE
8730 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8731 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8732 (validate_x_resource_name): Simplify count usage.
8733 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8734
37dd57d1
PE
8735 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8736 fail (Bug#8306).
81e56e61 8737
699979fc 8738 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8739
401bf9b4
PE
8740 * process.c (Fmake_network_process): Use socklen_t, not int,
8741 where POSIX says socklen_t is required in portable programs.
8742 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8743 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8744 (Fmake_network_process, server_accept_connection):
8745 (wait_reading_process_output, read_process_output):
8746 Likewise.
8747
b93aacde
PE
8748 * process.c: Rename or move locals to avoid shadowing.
8749 (list_processes_1, Fmake_network_process):
8750 (read_process_output_error_handler, exec_sentinel_error_handler):
8751 Rename or move locals.
4dc343ee 8752 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8753 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8754 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8755 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8756 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8757
af8a867c 8758 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8759 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8760 Include tparam.h instead, since it declares them.
af8a867c
PE
8761 * cm.h (PC): Remove extern decl; tparam.h now does this.
8762 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8763 * terminfo.c: Include tparam.h, to check interfaces.
8764 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8765 (tparam): Adjust signature to match interface in tparam.h;
8766 this removes some undefined behavior. Check that outstring and len
8767 are zero, which they always are with Emacs.
8768 * tparam.h (PC, BC, UP): New extern decls.
8769
0248044d 8770 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8771 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8772
8ff096c1 8773 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8774 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8775 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8776 (ftfont_list): Remove unused local.
49eaafba
PE
8777 (get_adstyle_property, ftfont_pattern_entity):
8778 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8779 Rename locals to avoid shadowing.
8ff096c1 8780
e2be39f6
PE
8781 * xfont.c (xfont_list_family): Mark var as initialized.
8782
c9735e30
PE
8783 * xml.c (make_dom): Now static.
8784
8f5201ae
PE
8785 * composite.c (composition_compute_stop_pos): Rename local to
8786 avoid shadowing.
b246f932
PE
8787 (composition_reseat_it): Remove unused locals.
8788 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8789 (composition_update_it): Mark var as initialized.
11b61122
PE
8790 (find_automatic_composition): Mark vars as initialized,
8791 with a FIXME (Bug#8290).
8f5201ae 8792
760fbc2c
PE
8793 character.h: Rename locals to avoid shadowing.
8794 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8795 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8796 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8797 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8798 to avoid shadowing.
8799
ff08eb85
PE
8800 * textprop.c (property_change_between_p): Remove; unused.
8801
fc7bf025
PE
8802 * intervals.c (interval_start_pos): Now static.
8803
235d7abc
PE
8804 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8805
44f230aa
SM
8806 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8807 Rename locals to avoid shadowing.
3e7d6594 8808
50060332
PE
8809 * sound.c (wav_play, au_play, Fplay_sound_internal):
8810 Fix pointer signedness.
d01f234b 8811 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8812 (wav_play): Initialize a variable to 0, to prevent undefined
8813 behavior (Bug#8278).
50060332 8814
c4fc4e30
PE
8815 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8816
918436ed
PE
8817 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8818
c939f91b
PE
8819 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8820 clobbering (Bug#8298).
b9c7f648
PE
8821 * sysdep.c (sys_subshell): Likewise.
8822 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8823
6bd8c144
PE
8824 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8825 This should get cleaned up, so that child_setup has the
8826 same signature on all platforms.
8827
7710357c 8828 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8829 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8830
c59da222
CY
88312011-03-22 Chong Yidong <cyd@stupidchicken.com>
8832
8833 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8834 not to be necessary, and produces flickering.
8835
66b87493
GM
88362011-03-20 Glenn Morris <rgm@gnu.org>
8837
8838 * config.in: Remove file.
8839
45b6f6d5
JB
88402011-03-20 Juanma Barranquero <lekktu@gmail.com>
8841
8842 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8843 are now in src/globals.h.
8844 (syms_of_minibuf): Remove spurious & from previous change.
8845
cd394be1 88462011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8847
8848 * minibuf.c (completing-read-function): New variable.
8849 (completing-read-default): Rename from completing-read.
8850 (completing-read): Call completing-read-function.
8851
b14e3e21
CY
88522011-03-19 Juanma Barranquero <lekktu@gmail.com>
8853
8854 * xfaces.c (Fx_load_color_file):
8855 Read color file from absolute filename (bug#8250).
8856
f2b726e6
JB
88572011-03-19 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * makefile.w32-in: Update dependencies.
8860
09f6ff02
EZ
88612011-03-17 Eli Zaretskii <eliz@gnu.org>
8862
8863 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8864
29a6015a
PE
88652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8866
a3a6c54e
PE
8867 Fix more problems found by GCC 4.5.2's static checks.
8868
b766f867
PE
8869 * process.c (make_serial_process_unwind, send_process_trap):
8870 (sigchld_handler): Now static.
8871
be02381c
PE
8872 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8873 That way, the code declares only the vars that it needs.
8874 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8875 * s/cygwin.h (PTY_ITERATION): Likewise.
8876 * s/darwin.h (PTY_ITERATION): Likewise.
8877 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8878
57048744
PE
8879 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8880 * process.c (allocate_pty): Don't declare stb unless it's needed.
8881
7914961c 8882 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8883 (CONSTANTLIM): Remove; unused.
8884 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8885 Define only if needed.
7914961c 8886
b3967b18
PE
8887 * unexelf.c (unexec): Name an expression,
8888 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8889 Use a different way to cause a compilation error if anyone uses
8890 n rather than nn, a way that does not involve shadowing.
73366a00 8891 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8892
29a6015a
PE
8893 * deps.mk (unexalpha.o): Remove; unused.
8894
43cfc33e 8895 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8896 * unexec.h: New file.
ce701a33
PE
8897 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8898 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8899 Depend on unexec.h.
8900 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8901 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8902 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8903 Change as necessary to match prototype in unexec.h.
ce701a33 8904
01f44d5a
PE
8905 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8906 shadowing.
4f63c6bb 8907 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8908
a6670b0b
PE
8909 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8910 Rename locals to avoid shadowing.
8911
cef2010d 8912 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8913 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8914
d4d7173a
PE
8915 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8916
f08b802a
PE
8917 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8918 warning when compiling print.c.
8919
3ddb0639
PE
8920 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8921 instead of using an uninitialized var.
5ad03b97 8922 (font_sort_entities): Mark var as initialized.
3ddb0639 8923
170a2692
PE
8924 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8925
e663c700
PE
8926 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8927 pointers to constants.
89bc529a 8928 (font_parse_fcname): Remove unused vars.
7b81e2d0 8929 (font_delete_unmatched): Now static.
ea838e10 8930 (font_get_spec): Remove; unused.
13a547c6
PE
8931 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8932 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8933 Rename or move locals to avoid shadowing.
e663c700 8934
2a80c887 8935 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8936 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8937
1384fa33 8938 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8939 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8940
8b2c52e9
PE
8941 * alloc.c (mark_backtrace): Move decl from here ...
8942 * lisp.h: ... to here, so that it can be checked.
8943
475545b5 8944 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8945 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8946 (lisp_indirect_variable): Name an expression,
8947 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8948 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8949
b1349114 8950 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8951 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8952 Use const pointer when appropriate.
b1349114 8953
a2928364
PE
8954 * lisp.h (get_system_name, get_operating_system_release):
8955 Move decls here, to check interfaces.
8956 * process.c (get_operating_system_release): Move decl to lisp.h.
8957 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8958 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8959 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8960 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8961 (Fformat_time_string, Fencode_time, Finsert_char):
8962 (Ftranslate_region_internal, Fformat):
8963 Rename or remove local vars to avoid shadowing.
9710023e 8964 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8965
a415e694
PE
8966 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8967 avoid shadowing.
8968
8ef4622d
PE
8969 * lisp.h (eassert): Check that the argument compiles, even if
8970 ENABLE_CHECKING is not defined.
8971
946f9a5b
PE
8972 * data.c (Findirect_variable): Name an expression, to avoid
8973 gcc -Wbad-function-cast warning.
112396d6 8974 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8975 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8976 (Fmake_variable_buffer_local, Fmake_local_variable):
8977 Mark variables as initialized.
52746918 8978 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8979
e5aab7e7 8980 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8981 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8982 Rename locals to avoid shadowing.
dff45157
PE
8983 (mark_stack): Move local variables into the #ifdef region where
8984 they're used.
7bc26fdb
PE
8985 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8986 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8987 needed otherwise.
8988 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8989 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8990 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8991
e5aab7e7
PE
8992 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8993 avoids undefined behavior in theory.
8994
4da60324
PE
8995 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8996
88043301
PE
8997 Use functions, not macros, for up- and down-casing (Bug#8254).
8998 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8999 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9000 to use the following functions instead of these macros.
9001 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9002 EMACS_INT, since callers assume the returned value fits in int.
9003 (upcase1): Likewise, for UPCASE_TABLE.
9004 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9005 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9006 the race-condition problem in the old DOWNCASE.
88043301 9007
19ed5445
PE
9008 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9009 Rename locals to avoid shadowing.
9010 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9011 (regex_compile, re_search_2, re_match_2_internal):
9012 Remove unused local vars.
952db0d7
PE
9013 (FREE_VAR): Rewrite so as not to use empty "else",
9014 which gcc can warn about.
da053e48 9015 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9016 (RETALLOC_IF): Define only if needed.
9017 (WORDCHAR_P): Likewise. This one is never needed, but is used
9018 only in a comment talking about a compiler bug, so put inside
9019 the #if 0 of that comment.
9020 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9021 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9022 Remove; unused.
19ed5445 9023
1f3561e4 9024 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9025 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9026 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9027
ded6f8f7
PE
9028 * search.c (simple_search): Remove unused var.
9029
dbd37a95
PE
9030 * dired.c (compile_pattern): Move decl from here ...
9031 * lisp.h: ... to here, so that it can be checked.
9032 (struct re_registers): New forward decl.
9033
7e47afad
PE
9034 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9035
85f24f61
PE
9036 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9037 All uses changed.
9038 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9039 Rename locals to avoid shadowing.
5671df8f 9040 (Fvertical_motion): Mark locals as initialized.
85f24f61 9041
181aa2be 9042 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9043 (casify_region): Mark local as initialized.
181aa2be 9044
930d429c
PE
9045 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9046
7082eac6
PE
9047 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9048 New macros, so that the caller can use some names other than
9049 gcpro1, gcpro2, etc.
9050 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9051 of the new macros.
9052 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9053 argument, for consistency with GCPRO2_VAR, etc: it is now the
9054 prefix of the variable, not the variable itself. All uses
9055 changed.
38b2c076
PE
9056 * dired.c (directory_files_internal, file_name_completion):
9057 Rename locals to avoid shadowing.
9058
15206ed9
PE
9059 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9060 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9061 dired.c's scmp function, had undefined behavior.
9062 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9063 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9064 * buffer.h: ... to here, because these macros use current_buffer,
9065 and the new implementation with inline functions needs to have
9066 current_buffer in scope now, rather than later when the macros
9067 are used.
9068 (downcase, upcase1): New static inline functions.
9069 (DOWNCASE, UPCASE1): Reimplement using these functions.
9070 This avoids undefined behavior in expressions like
9071 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9072 from race conditions in accessing the global variables
9073 case_temp1 and case_temp2.
9074 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9075 * lisp.h (case_temp1, case_temp2): Remove their decls.
9076 * character.h (ASCII_CHAR_P): Move from here ...
9077 * lisp.h: ... to here, so that the inline functions mentioned
9078 above can use them.
9079
4a6bea26
PE
9080 * dired.c (directory_files_internal_unwind): Now static.
9081
f14b7e14
PE
9082 * fileio.c (file_name_as_directory, directory_file_name):
9083 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9084 Now static.
2893f146
PE
9085 (file_name_as_directory): Use const pointers when appropriate.
9086 (Fexpand_file_name): Likewise. In particular, newdir might
9087 point at constant storage, so make it a const pointer.
fd4ead52 9088 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9089 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9090 signedness issues.
f839df0c
PE
9091 (Fset_file_times, Finsert_file_contents, auto_save_error):
9092 Rename locals to avoid shadowing.
f14b7e14 9093
5716756e 9094 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9095 (Ftry_completion, Fall_completions): Rename or remove locals
9096 to avoid shadowing.
5716756e 9097
b4c3046a
PE
9098 * marker.c (bytepos_to_charpos): Remove; unused.
9099
b45db522
PE
9100 * lisp.h (verify_bytepos, count_markers): New decls,
9101 so that gcc does not warn that these functions aren't declared.
9102
85876d07
PE
9103 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9104 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9105 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9106 (copy_text): Remove unused local var.
85876d07 9107
03d78a21 9108 * filelock.c (within_one_second): Now static.
b3dd38ab 9109 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9110
5df8f01b
PE
9111 * buffer.c (fix_overlays_before): Mark locals as initialized.
9112 (fix_start_end_in_overlays): Likewise. This function should be
9113 simplified by using pointers-to-pointers, but that's a different
9114 matter.
b1d876f1 9115 (switch_to_buffer_1): Now static.
8f54f30a
PE
9116 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9117 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9118
a70072c9 9119 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9120 Fix pointer signedness issue.
edced198
PE
9121 (sys_subshell): Mark local as volatile if checking for lint,
9122 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9123 (MAXPATHLEN): Define only if needed.
a70072c9 9124
a0977c44
PE
9125 * process.c (serial_open, serial_configure): Move decls from here ...
9126 * systty.h: ... to here, so that they can be checked.
9127
a884fdcc
PE
9128 * fns.c (get_random, seed_random): Move extern decls from here ...
9129 * lisp.h: ... to here, so that they can be checked.
9130
604efe86 9131 * sysdep.c (reset_io): Now static.
b8950c94 9132 (wait_for_termination_signal): Remove; unused.
604efe86 9133
38fc62d9
PE
9134 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9135 (copy_keymap_item, append_key, push_text_char_description):
9136 Now static.
1004a21a 9137 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9138 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9139 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9140 (describe_map_tree):
9141 Rename locals to avoid shadowing.
38fc62d9 9142
2f2650da
PE
9143 * keyboard.c: Declare functions static if they are not used elsewhere.
9144 (echo_char, echo_dash, cmd_error, top_level_2):
9145 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9146 (read_char, kbd_buffer_get_event, make_lispy_position):
9147 (make_lispy_event, make_lispy_movement, apply_modifiers):
9148 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9149 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9150 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9151 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9152 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9153
a053e86c 9154 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9155 (mark_kboards): Move decl here ...
9156 * alloc.c (mark_kboards): ... from here.
a053e86c 9157
4752793e
PE
9158 * lisp.h (force_auto_save_soon): New decl.
9159
74f10ca7 9160 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9161 (DEFINE_DUMMY_FUNCTION): New macro.
9162 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9163 Use it.
c03cd23f
PE
9164 (main): Add casts to avoid warnings
9165 if GCC considers string literals to be constants.
74f10ca7 9166
022e70d4
PE
9167 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9168
59d6fe83
PE
9169 * dbusbind.c: Pointer signedness fixes.
9170 (xd_signature, xd_append_arg, xd_initialize):
9171 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9172 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9173 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9174 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9175
78320123
PE
9176 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9177 if GCC considers string literals to be constants.
49cebcca 9178 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9179
35ac2a97
SM
91802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9181
fb103ca9
SM
9182 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9183 (print_preprocess, print_object): New macro to fix last change.
9184
35ac2a97
SM
9185 * print.c (print_preprocess): Don't forget font objects.
9186
62973b41
JB
91872011-03-16 Juanma Barranquero <lekktu@gmail.com>
9188
9189 * emacs.c (USAGE3): Doc fixes.
9190
0e48bb22
AS
91912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9192
9193 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9194 structure.
9195
7684e57b
JB
91962011-03-14 Juanma Barranquero <lekktu@gmail.com>
9197
9198 * lisp.h (VWindow_system, Qfile_name_history):
9199 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9200 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9201 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9202
9203 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9204 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9205
9206 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9207 * w32console.c (detect_input_pending, read_input_pending)
9208 (encode_terminal_code):
9209 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9210 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9211 (w32_system_caret_y, Qfile_name_history):
9212 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9213 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9214 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9215 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9216 * w32proc.c (Qlocal, report_file_error):
9217 * w32term.c (Vwindow_system, updating_frame):
9218 * w32uniscribe.c (initialized, uniscribe_font_driver):
9219 Remove unneeded extern declarations.
9220
2aa46d6c
CY
92212011-03-14 Chong Yidong <cyd@stupidchicken.com>
9222
c96bbc66 9223 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9224
cffc6f3b
CY
92252011-03-13 Chong Yidong <cyd@stupidchicken.com>
9226
9227 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9228 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9229 These macros can no longer be used for assignment.
9230
44f230aa
SM
9231 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9232 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9233 (record_buffer_markers, fetch_buffer_markers): New functions for
9234 recording and fetching special buffer markers.
9235 (set_buffer_internal_1, set_buffer_temp): Use them.
9236
9237 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9238
9239 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9240
9241 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9242 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9243
9244 * xdisp.c (hscroll_window_tree):
9245 (reconsider_clip_changes): Use PT instead of BUF_PT.
9246
d251f04b
EZ
92472011-03-13 Eli Zaretskii <eliz@gnu.org>
9248
9249 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9250 $(EMACS_ROOT)/lib/intprops.h.
9251
f0c77cd1
PE
92522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9253
3eca4629
PE
9254 Fix more problems found by GCC 4.5.2's static checks.
9255
7c86ee98
PE
9256 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9257 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9258 (xg_free_frame_widgets): Make it clear that a local variable is
9259 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9260 (gdk_window_get_screen): Make it clear that this macro is needed
9261 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9262 (int_gtk_range_get_value): New function, which avoids a diagnostic
9263 from gcc -Wbad-function-cast.
9264 (xg_set_toolkit_scroll_bar_thumb): Use it.
9265 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9266 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9267 (get_utf8_string, xg_get_file_with_chooser):
9268 Rename locals to avoid shadowing.
9269 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9270
41729b81
PE
9271 * xgselect.c (xg_select): Remove unused var.
9272
f0c77cd1
PE
9273 * image.c (four_corners_best): Mark locals as initialized.
9274 (gif_load): Initialize transparent_p to zero (Bug#8238).
9275 Mark another local as initialized.
ec6cf4c6 9276 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9277
ce0ad53d 9278 * image.c (clear_image_cache): Now static.
d5d5a617 9279 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9280 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9281 (x_edge_detection): Remove unnecessary cast that
9282 gcc -Wbad-function-cast diagnoses.
2037898d 9283 (gif_load): Fix pointer signedness.
6ae141d6
PE
9284 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9285 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9286
33383987 92872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9288
d32df629
PE
9289 Improve quality of tests for time stamp overflow.
9290 For example, without this patch (encode-time 0 0 0 1 1
9291 1152921504606846976) returns the obviously-bogus value (-948597
9292 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9293 reports time overflow. See
9294 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9295 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9296 * editfns.c: Include limits.h and intprops.h.
9297 (TIME_T_MIN, TIME_T_MAX): New macros.
9298 (time_overflow): Move earlier, to before first use.
9299 (hi_time, lo_time): New functions, for an accurate test for
9300 out-of-range times.
9301 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9302 (Fget_internal_run_time): Don't assume time_t fits in int.
9303 (make_time): Use list2 instead of Fcons twice.
9304 (Fdecode_time): More accurate test for out-of-range times.
9305 (check_tm_member): New function.
9306 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9307 (lisp_time_argument): Don't rely on undefined left-shift and
9308 right-shift behavior when checking for time stamp overflow.
8be6f318 9309
fe31d94c
PE
9310 * editfns.c (time_overflow): New function, refactoring common code.
9311 (Fformat_time_string, Fdecode_time, Fencode_time):
9312 (Fcurrent_time_string): Use it.
9313
8be6f318
PE
9314 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9315 * dired.c (make_time): Move to ...
9316 * editfns.c (make_time): ... here.
9317 * systime.h: Note the move.
9318
09d9db2c 93192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9320
126bc0dc
YM
9321 * fringe.c (update_window_fringes): Remove unused variables.
9322
c47cbdfd
YM
9323 * unexmacosx.c (copy_data_segment): Also copy __got section.
9324 (Bug#8223)
9325
7ac80be9
EZ
93262011-03-12 Eli Zaretskii <eliz@gnu.org>
9327
c96bbc66 9328 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9329 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9330 Constify `char *' arguments and their references according to
9331 prototypes in tparam.h.
9332
ecb0f94d 9333 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9334
7ac80be9
EZ
9335 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9336 Adapt all references accordingly.
9337
9338 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9339
ef1fd07e
TT
93402011-03-11 Tom Tromey <tromey@redhat.com>
9341
9342 * buffer.c (syms_of_buffer): Remove obsolete comment.
9343
7ef4b50c
EZ
93442011-03-11 Eli Zaretskii <eliz@gnu.org>
9345
9346 * termhooks.h (encode_terminal_code): Declare prototype.
9347
9348 * msdos.c (encode_terminal_code): Don't declare prototype.
9349
9350 * term.c (encode_terminal_code): Now external again, used by
9351 w32console.c and msdos.c.
9352
44f230aa
SM
9353 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9354 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9355
4b1ec863 93562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9357
1714f52b 9358 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9359
4b1ec863
PE
9360 * fringe.c (update_window_fringes): Mark locals as initialized
9361 (Bug#8227).
9362 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9363
524c7aa6
PE
9364 * alloc.c (mark_fringe_data): Move decl from here ...
9365 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9366 to check its interface.
9367 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9368
a5c0af81 9369 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9370 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9371 (fontset_font): Mark local as initialized.
a9a06e0b 9372 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9373
b4716021
PE
9374 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9375
811e9bac 9376 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9377 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9378 (x_own_selection, Fx_disown_selection_internal): Rename locals
9379 to avoid shadowing.
9380 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9381
7e3ab302
PE
9382 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9383 so that the caller can use some name other than gcpro1.
9384 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9385 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9386 (Fx_backspace_delete_keys_p):
9387 Use them to avoid shadowing, and rename vars to avoid shadowing.
9388 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9389 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9390 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9391 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9392 Remove unused locals.
7e3ab302
PE
9393 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9394 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9395 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9396 macros.
f78faa98 9397
e2b13473
PE
9398 * xterm.h (x_mouse_leave): New decl.
9399
77f23912
PE
9400 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9401 Remove unused functions.
cdf4ba58
PE
9402 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9403 (x_calc_absolute_position): Now static.
7411c686 9404 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9405 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9406 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9407 unless they are used.
38d0b34a
PE
9408 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9409 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9410 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9411 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9412 (x_error_catcher, x_connection_closed, x_error_handler):
9413 (x_error_quitter, xembed_send_message, x_iconify_frame):
9414 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9415 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9416 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9417
44f230aa
SM
9418 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9419 Rename or move locals to avoid shadowing.
6b463e58 9420 (tty_defined_color, merge_face_heights): Now static.
5967d051 9421 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9422 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9423 does not deduce is never used uninitialized.
73719eba
PE
9424 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9425 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9426
426994c3 9427 * terminal.c (store_terminal_param): Now static.
5489860b 9428
032f1620 9429 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9430 (set_frame_menubar): Remove unused local.
d4323972 9431 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9432 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9433 since they might point to immutable storage.
281585b0
PE
9434 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9435 since it's unused otherwise.
032f1620 9436
367c19e5 9437 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9438 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9439 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9440 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9441 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9442 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9443 does not deduce are never used uninitialized.
70739cbe 9444
07b48fa9
PE
9445 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9446
8868a238 9447 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9448 * window.c (window_loop, size_window):
9449 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9450
7e5cf297 9451 * window.c (display_buffer): Now static.
d6550a9f
PE
9452 (size_window): Mark variables that gcc -Wuninitialized
9453 does not deduce are never used uninitialized.
a586633d
PE
9454 * window.h (check_all_windows): New decl, to forestall
9455 gcc -Wmissing-prototypes diagnostic.
5b555da1 9456 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9457
f6095868
PE
9458 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9459 shadowing.
9460 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9461 Include <limits.h>.
9462 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9463 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9464 (load_charset_map): Mark variables that gcc -Wuninitialized
9465 does not deduce are never used uninitialized.
53df7c11 9466 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9467
f38b440c
PE
9468 * coding.c (coding_set_source, coding_set_destination):
9469 Use "else { /* comment */ }" rather than "else /* comment */;"
9470 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9471 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9472 a block, when the outer 'i' will do.
9473 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9474 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9475 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9476 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9477 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9478 Rename locals to avoid shadowing.
9479 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9480 * coding.c (emacs_mule_char, encode_invocation_designation):
9481 Now static, since they're not used elsewhere.
413bb2db 9482 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9483 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9484 (decode_coding_emacs_mule): Mark variables that gcc
9485 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9486 (detect_coding_iso_2022): Initialize a local variable that might
9487 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9488 this initialization is needed. (Bug#8211)
5f58e762
PE
9489 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9490 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9491 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9492 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9493 Remove unused macros.
f38b440c 9494
232b38b9 9495 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9496 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9497 * character.c (string_count_byte8): Likewise.
232b38b9 9498
fb90da1b
PE
9499 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9500 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9501
fb93dbc2
PE
9502 * chartab.c (copy_sub_char_table): Now static, since it's not used
9503 elsewhere.
5c156ace
PE
9504 (sub_char_table_ref_and_range, char_table_ref_and_range):
9505 Rename locals to avoid shadowing.
bbcd0949 9506 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9507
7d3b3862 9508 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9509 (BIDI_BOB): Remove unused macro.
7d3b3862 9510
6be7d3da
PE
9511 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9512 deduce are never used uninitialized.
c2ed9c8b 9513 * term.c (encode_terminal_code): Likewise.
6be7d3da 9514
75f8807f 9515 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9516
50938595
PE
9517 * tparam.h: New file.
9518 * term.c, tparam.h: Include it.
9519 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9520 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9521 Move these decls to tparam.h, and make them agree with what
9522 is actually in tparam.c. The previous trick of using incompatible
9523 decls in different modules does not conform to the C standard.
9524 All callers of tparam changed to use tparam's actual API.
9525 * tparam.c (tparam1, tparam, tgoto):
9526 Use const pointers where appropriate.
9527
fbceeba2
PE
9528 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9529 * cm.h (struct cm): Likewise.
9530 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9531 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9532 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9533 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9534 (turn_on_face, init_tty): Likewise.
9535 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9536
7f3f1250
PE
9537 * term.c (term_mouse_position): Rename local to avoid shadowing.
9538
e6ca6543
PE
9539 * alloc.c (mark_ttys): Move decl from here ...
9540 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9541
c40f8d15
AS
95422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9543
9544 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9545
cfe0661d
JB
95462011-03-09 Juanma Barranquero <lekktu@gmail.com>
9547
9548 * search.c (compile_pattern_1): Remove argument regp, unused since
9549 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9550 (compile_pattern): Don't pass it.
9551
0afb4571
J
95522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9553
9554 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9555 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9556 for ! HAVE_GTK3.
9557 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9558
9559 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9560
9561 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9562 gdk_window_get_screen, gdk_window_get_geometry,
9563 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9564 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9565 (xg_get_pixbuf_from_pixmap): New function.
9566 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9567 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9568 Call xg_get_pixbuf_from_pixmap instead of
9569 gdk_pixbuf_get_from_drawable.
9570 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9571 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9572 (xg_check_special_colors): Use GtkStyleContext and its functions
9573 for HAVE_GTK3.
9574 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9575 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9576 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9577 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9578 Call gtk_widget_get_preferred_size.
0afb4571
J
9579 (xg_frame_resized): gdk_window_get_geometry only takes 5
9580 parameters.
44f230aa
SM
9581 (xg_win_to_widget, xg_event_is_for_menubar):
9582 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9583 (xg_set_widget_bg): New function.
9584 (delete_cb): New function.
895009e1 9585 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9586 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9587 (xg_set_background_color): Call xg_set_widget_bg.
9588 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9589 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9590 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9591 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9592 if ! HAVE_GTK3.
9593 (update_frame_tool_bar): Call gtk_widget_hide.
9594 (xg_initialize): Use GDK_KEY_g.
9595
9596 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9597 if ! HAVE_GTK3
9598 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9599
9600 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9601 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9602 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9603
1c2cc4ef
JB
96042011-03-08 Juanma Barranquero <lekktu@gmail.com>
9605
9606 * w32xfns.c (select_palette): Check success of RealizePalette against
9607 GDI_ERROR, not zero.
9608
33383987 9609See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9610
9611;; Local Variables:
9612;; coding: utf-8
aac0c6e3
MR
9613;; End:
9614
acaf905b 9615 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9616
9617 This file is part of GNU Emacs.
9618
9619 GNU Emacs is free software: you can redistribute it and/or modify
9620 it under the terms of the GNU General Public License as published by
9621 the Free Software Foundation, either version 3 of the License, or
9622 (at your option) any later version.
9623
9624 GNU Emacs is distributed in the hope that it will be useful,
9625 but WITHOUT ANY WARRANTY; without even the implied warranty of
9626 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9627 GNU General Public License for more details.
9628
9629 You should have received a copy of the GNU General Public License
9630 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.