* doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
684a03ef
PE
3 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4
0fed43f3
PE
5 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7 incorrectly succeed when S was a string, because 4294967386 was
8 truncated before it was used.
9
8fd02eb7
PE
10 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11 Otherwise, an out-of-range integer could cause undefined behavior
12 on a 64-bit host.
13
f8c86b69
PE
14 * composite.c: Use int, not EMACS_INT, for characters.
15 (fill_gstring_body, composition_compute_stop_pos): Use int, not
16 EMACS_INT, for values that are known to be in character range.
17 This doesn't fix any bugs but is the usual style inside Emacs and
18 may generate better code on 32-bit machines.
19
34206dd2
PE
20 Make sure a 64-bit char is never passed to ENCODE_CHAR.
21 This is for reasons similar to the recent CHAR_STRING fix.
22 * charset.c (Fencode_char): Check that character arg is actually
23 a character. Pass an int to ENCODE_CHAR.
24 * charset.h (ENCODE_CHAR): Verify that the character argument is no
25 wider than 'int', as a compile-time check to prevent future regressions
26 in this area.
27
c5958d4c 28 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
29
30 Make sure a 64-bit char is never passed to CHAR_STRING.
31 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
32 by silently ignoring the top 32 bits, allowing some values
33 that were far too large to be valid characters.
34 * character.h: Include <verify.h>.
35 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
36 arguments are no wider than unsigned, as a compile-time check
37 to prevent future regressions in this area.
38 * data.c (Faset):
39 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
40 (Fsubst_char_in_region):
41 * fns.c (concat):
42 * xdisp.c (decode_mode_spec_coding):
43 Adjust to CHAR_STRING's new requirement.
44 * editfns.c (Finsert_char, Fsubst_char_in_region):
45 * fns.c (concat): Check that character args are actually
46 characters. Without this test, these functions did the wrong
47 thing with wildly out-of-range values on 64-bit hosts.
48
ea204efb
PE
492011-06-12 Paul Eggert <eggert@cs.ucla.edu>
50
d37ca623
PE
51 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
52 These casts should not be needed on 32-bit hosts, either.
53 * keyboard.c (read_char):
54 * lread.c (Fload): Remove casts to unsigned.
55
ea204efb
PE
56 * lisp.h (UNSIGNED_CMP): New macro.
57 This fixes comparison bugs on 64-bit hosts.
58 (ASCII_CHAR_P): Use it.
59 * casefiddle.c (casify_object):
60 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
61 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
62 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
63 * dispextern.h (FACE_FROM_ID):
64 * keyboard.c (read_char): Use UNSIGNED_CMP.
65
fc83f7d3 662011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 67
41cb286c
PE
68 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
69 not to EMACS_INT, to avoid GCC warning.
70
4a1b9832
PE
71 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
72
55daad71
PE
73 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
74 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
75 isn't needed on 32-bit machines.
8f95c75c 76
666398f3 77 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 78 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
79
80 * data.c (Qcompiled_function): Now static.
81
c6f072e7
PE
82 * window.c (window_body_lines): Now static.
83
20ce5912
PE
84 * image.c (gif_load): Rename local to avoid shadowing.
85
9c4c5f81
PE
86 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
87 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
88 * alloc.c (make_save_value): Integer argument is now of type
89 ptrdiff_t, not int.
90 (mark_object): Use ptrdiff_t, not int.
91 * lisp.h (pD): New macro.
92 * print.c (print_object): Use it.
93
c0c5c8ae
PE
94 * alloc.c: Use EMACS_INT, not int, to count objects.
95 (total_conses, total_markers, total_symbols, total_vector_size)
96 (total_free_conses, total_free_markers, total_free_symbols)
97 (total_free_floats, total_floats, total_free_intervals, total_intervals)
98 (total_strings, total_free_strings):
99 Now EMACS_INT, not int. All uses changed.
100 (Fgarbage_collect): Compute overall total using a double, so that
101 integer overflow is less likely to be a problem. Check for overflow
102 when converting back to an integer.
5a25e253
PE
103 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
104 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
105 These were 'int' variables that could overflow on 64-bit hosts;
106 they were never used, so remove them instead of repairing them.
211a0b2a 107 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
108 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
109 Previously, this ceilinged at INT_MAX, but that doesn't work on
110 64-bit machines.
e46bb31a 111 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 112
c78baabf 113 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 114 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
115 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
116 when a (possibly-narrower) signed value would do just as well.
117 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 118
c9d624c6
PE
119 * alloc.c: Catch some string size overflows that we were missing.
120 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
121 for convenience in STRING_BYTES_MAX.
122 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
123 The definition here is exact; the one in lisp.h was approximate.
124 (allocate_string_data): Check for string overflow. This catches
125 some instances we weren't catching before. Also, it catches
126 size_t overflow on (unusual) hosts where SIZE_MAX <= min
127 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
128 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 129
c9d624c6
PE
130 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
131 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
132 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
133
353032ce
PE
134 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
135
2bccce07
PE
136 * alloc.c (Fmake_string): Check for out-of-range init.
137
b50691aa
CY
1382011-06-11 Chong Yidong <cyd@stupidchicken.com>
139
140 * dispextern.h (struct image): Replace data member, whose int_val
141 and ptr_val fields were not used by anything, with a single
142 lisp_val object.
143
144 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
145 (gif_clear_image, gif_load, imagemagick_load_image)
146 (gs_clear_image, gs_load): Callers changed.
147
3f754b86
PE
1482011-06-10 Paul Eggert <eggert@cs.ucla.edu>
149
cca69397
PE
150 * buffer.h: Include <time.h>, for time_t.
151 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
152
109e28d0
PE
153 Fix minor problems found by static checking.
154
60737f02
PE
155 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
156
4b66faf3
PE
157 Make identifiers static if they are not used in other modules.
158 * data.c (Qcompiled_function, Qframe, Qvector):
159 * image.c (QimageMagick, Qsvg):
160 * minibuf.c (Qmetadata):
161 * window.c (resize_window_check, resize_root_window): Now static.
162 * window.h (resize_window_check, resize_root_window): Remove decls.
163
109e28d0
PE
164 * window.c (window_deletion_count, delete_deletable_window):
165 Remove; unused.
46a4ce9e
PE
166 (window_body_lines): Now static.
167 (Fdelete_other_windows_internal): Mark vars as initialized.
168 Make sure 'resize_failed' is initialized.
169 (run_window_configuration_change_hook): Rename local to avoid shadowing.
170 (resize_window_apply): Remove unused local.
171 * window.h (delete_deletable_window): Remove decl.
172
109e28d0 173 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
174 (imagemagick_load_image): Fix pointer signedness problem by changing
175 last arg from unsigned char * to char *. All uses changed.
176 Also, fix a local for similar reasons.
177 Remove unused locals. Remove locals to avoid shadowing.
178 (fn_rsvg_handle_free): Remove; unused.
179 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 180 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 181
3f754b86
PE
182 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
183
2547adb1
CY
1842011-06-10 Chong Yidong <cyd@stupidchicken.com>
185
186 * image.c (gif_load): Fix omitted cast error introduced by
187 2011-06-06 change.
188
2c8e37d4
MR
1892011-06-10 Martin Rudalics <rudalics@gmx.at>
190
191 * window.h (resize_proportionally, orig_total_lines)
192 (orig_top_line): Remove from window structure.
193 (set_window_height, set_window_width, change_window_heights)
194 (Fdelete_window): Remove prototypes.
195 (resize_frame_windows): Remove duplicate declaration.
196
440a42e3
EZ
1972011-06-10 Eli Zaretskii <eliz@gnu.org>
198
199 * window.h (resize_frame_windows, resize_window_check)
200 (delete_deletable_window, resize_root_window)
201 (resize_frame_windows): Declare prototypes.
202
203 * window.c (resize_window_apply): Make definition be "static" to
204 match the prototype.
205
562dd5e9
MR
2062011-06-10 Martin Rudalics <rudalics@gmx.at>
207
208 * window.c: Remove declarations of Qwindow_size_fixed,
209 window_min_size_1, window_min_size_2, window_min_size,
210 size_window, window_fixed_size_p, enlarge_window, delete_window.
211 Remove static from declaration of Qdelete_window, it's
212 temporarily needed by Fbury_buffer.
213 (replace_window): Don't assign orig_top_line and
214 orig_total_lines.
215 (Fdelete_window, delete_window): Remove. Window deletion is
216 handled by window.el.
217 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
218 Fdelete_window calls with calls to Qdelete_window.
219 (Fdelete_other_windows): Remove. Deleting other windows is
220 handled by window.el.
221 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
222 handled in window.el.
223 (window_min_size_2, window_min_size_1, window_min_size): Remove.
224 Window minimum sizes are handled in window.el.
225 (shrink_windows, size_window, set_window_height)
226 (set_window_width, change_window_heights, window_height)
227 (window_width, CURBEG, CURSIZE, enlarge_window)
228 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
229 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
230 handled in window.el.
231 (make_dummy_parent): Rename to make_parent_window and give it a
232 second argument horflag.
233 (make_window): Don't set resize_proportionally any more.
234 (Fsplit_window): Remove. Windows are split in window.el.
235 (save_restore_action, save_restore_orig_size)
236 (shrink_window_lowest_first, save_restore_orig_size): Remove.
237 Resize mini windows in window.el.
238 (grow_mini_window, shrink_mini_window): Implement by calling
239 Qresize_root_window_vertically, resize_window_check and
240 resize_window_apply.
241 (saved_window, Fset_window_configuration, save_window_save): Do
242 not handle orig_top_line, orig_total_lines, and
243 resize_proportionally.
244 (window_min_height, window_min_width): Move to window.el.
245 (keys_of_window): Move bindings for delete-other-windows,
246 split-window, delete-window and enlarge-window to window.el.
247
248 * buffer.c: Temporarily extern Qdelete_window.
249 (Fbury_buffer): Temporarily call Qdelete_window instead of
250 Fdelete_window (Fbury_buffer will move to window.el soon).
251
252 * frame.c (set_menu_bar_lines_1): Remove code handling
253 orig_top_line and orig_total_lines.
254
255 * dispnew.c (adjust_frame_glyphs_initially): Don't use
256 set_window_height but set heights directly.
257 (change_frame_size_1): Use resize_frame_windows.
258
259 * xdisp.c (init_xdisp): Don't use set_window_height but set
260 heights directly.
261
262 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
263 resize_frame_windows instead of change_window_heights and run
264 run_window_configuration_change_hook.
265
266 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
267 instead of change_window_heights and run
268 run_window_configuration_change_hook.
269
1a13852e
MR
2702011-06-09 Martin Rudalics <rudalics@gmx.at>
271
272 * window.c (replace_window): Rename second argument REPLACEMENT to
273 NEW. New third argument SETFLAG. Rewrite.
274 (delete_window, make_dummy_parent): Call replace_window with
275 third argument 1.
276 (window_list_1): Move down in code.
277 (run_window_configuration_change_hook): Move set_buffer part
278 before select_frame_norecord part in order to unwind correctly.
279 Rename count1 to count.
280 (recombine_windows, delete_deletable_window, resize_root_window)
281 (Fdelete_other_windows_internal)
282 (Frun_window_configuration_change_hook, make_parent_window)
283 (resize_window_check, resize_window_apply, Fresize_window_apply)
284 (resize_frame_windows, Fsplit_window_internal)
285 (Fdelete_window_internal, Fresize_mini_window_internal): New
286 functions.
287 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
288
f3d1777e
MR
2892011-06-08 Martin Rudalics <rudalics@gmx.at>
290
496e208e
MR
291 * window.h (window): Add some new members to window structure -
292 normal_lines, normal_cols, new_total, new_normal, clone_number,
293 splits, nest, prev_buffers, next_buffers.
294 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 295 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 296
f3d1777e
MR
297 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
298 Remove.
496e208e
MR
299 (make_dummy_parent): Set new members of windows structure.
300 (make_window): Move down in code. Handle new members of window
301 structure.
302 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
303 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
304 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
305 (Fset_window_prev_buffers, Fwindow_next_buffers)
306 (Fset_window_next_buffers, Fset_window_clone_number): New
307 functions.
308 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
309 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
310 Doc-string fixes.
311 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
312 Argument WINDOW can be now internal window too.
313 (Fwindow_use_time): Move up in code.
314 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
315 Rewrite doc-string.
316 (Fset_window_configuration, saved_window)
317 (Fcurrent_window_configuration, save_window_save): Handle new
318 members of window structure.
b9e809c2
MR
319 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
320 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
321 (syms_of_window): New Lisp objects Qrecord_window_buffer,
322 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
323 Qget_mru_window, Qresize_root_window,
324 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
325 Qauto_buffer_name; staticpro them.
f3d1777e 326
abde8f8c
MR
3272011-06-07 Martin Rudalics <rudalics@gmx.at>
328
329 * window.c (Fwindow_total_size, Fwindow_left_column)
330 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
331 (Fwindow_list_1): New functions.
332 (window_box_text_cols): Replace with window_body_cols.
333 (Fwindow_width, Fscroll_left, Fscroll_right): Use
334 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
335 (delete_window, Fset_window_configuration): Call
336 delete_all_subwindows with window as argument.
337 (delete_all_subwindows): Take a window as argument and not a
338 structure. Rewrite.
190b47e6
MR
339 (window_loop): Remove handling of GET_LRU_WINDOW and
340 GET_LARGEST_WINDOW.
341 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
342
343 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
344 window_box_text_cols. delete_all_subwindows now takes a
345 Lisp_Object as argument.
abde8f8c
MR
346
347 * indent.c (compute_motion, Fcompute_motion): Use
348 window_body_cols instead of window_box_text_cols.
349
fa8a67e6
MR
350 * frame.c (delete_frame): Call delete_all_subwindows with root
351 window as argument.
352
a54e3482
DC
3532011-06-07 Daniel Colascione <dan.colascione@gmail.com>
354
355 * fns.c (Fputhash): Document return value.
356
60002bf5
CY
3572011-06-06 Chong Yidong <cyd@stupidchicken.com>
358
359 * image.c (gif_load): Implement gif89a spec "no disposal" method.
360
0c671da6 3612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 362
b862a52a 363 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 364
be44ca6c
PE
365 Check for overflow when converting integer to cons and back.
366 * charset.c (Fdefine_charset_internal, Fdecode_char):
367 Use cons_to_unsigned to catch overflow.
368 (Fencode_char): Use INTEGER_TO_CONS.
369 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
370 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
371 * data.c (long_to_cons, cons_to_long): Remove.
372 (cons_to_unsigned, cons_to_signed): New functions.
373 These signal an error for invalid or out-of-range values.
374 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
375 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
376 * font.c (Ffont_variation_glyphs):
377 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
378 * lisp.h: Include <intprops.h>.
379 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
380 (cons_to_signed, cons_to_unsigned): New decls.
381 (long_to_cons, cons_to_long): Remove decls.
382 * undo.c (record_first_change): Use INTEGER_TO_CONS.
383 (Fprimitive_undo): Use CONS_TO_INTEGER.
384 * xfns.c (Fx_window_property): Likewise.
385 * xselect.c: Include <limits.h>.
386 (x_own_selection, selection_data_to_lisp_data):
387 Use INTEGER_TO_CONS.
388 (x_handle_selection_request, x_handle_selection_clear)
389 (x_get_foreign_selection, Fx_disown_selection_internal)
390 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
391 (lisp_data_to_selection_data): Use cons_to_unsigned.
392 (x_fill_property_data): Use cons_to_signed.
393 Report values out of range.
394
d1f3d2af
PE
395 Check for buffer and string overflow more precisely.
396 * buffer.h (BUF_BYTES_MAX): New macro.
397 * lisp.h (STRING_BYTES_MAX): New macro.
398 * alloc.c (Fmake_string):
399 * character.c (string_escape_byte8):
400 * coding.c (coding_alloc_by_realloc):
401 * doprnt.c (doprnt):
402 * editfns.c (Fformat):
403 * eval.c (verror):
404 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
405 since they may not be the same number.
406 * editfns.c (Finsert_char):
407 * fileio.c (Finsert_file_contents):
408 Likewise for BUF_BYTES_MAX.
409
dd52fcea
PE
410 * image.c: Use ptrdiff_t, not int, for sizes.
411 (slurp_file): Switch from int to ptrdiff_t.
412 All uses changed.
413 (slurp_file): Check that file size fits in both size_t (for
414 malloc) and ptrdiff_t (for sanity and safety).
415
7f9bbdbb
PE
416 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
417 if b->modtime has its maximal value.
418
dfe18f82
PE
419 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
420
84acfcf0
PE
421 Don't assume time_t can fit into int.
422 * buffer.h (struct buffer.modtime): Now time_t, not int.
423 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
424 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
425
ccd9a01a
PE
426 Minor fixes for signed vs unsigned integers.
427 * character.h (MAYBE_UNIFY_CHAR):
428 * charset.c (maybe_unify_char):
429 * keyboard.c (read_char, reorder_modifiers):
430 XINT -> XFASTINT, since the integer must be nonnegative.
431 * ftfont.c (ftfont_spec_pattern):
432 * keymap.c (access_keymap, silly_event_symbol_error):
433 XUINT -> XFASTINT, since the integer must be nonnegative.
434 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
435 since it makes no difference and we prefer signed.
436 * keyboard.c (record_char): Use XUINT when all the neighbors do.
437 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
438 nonnegative.
439
d6d100dd
SM
4402011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
441
442 * window.h (Fwindow_frame): Declare.
443
2b6148e4
PE
4442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
445
446 * alloc.c: Simplify handling of large-request failures (Bug#8800).
447 (SPARE_MEMORY): Always define.
448 (LARGE_REQUEST): Remove.
449 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
450
f230ecc9
MR
4512011-06-06 Martin Rudalics <rudalics@gmx.at>
452
727e958e
MR
453 * lisp.h: Move EXFUNS for Fframe_root_window,
454 Fframe_first_window and Fset_frame_selected_window to window.h.
455
456 * window.h: Move EXFUNS for Fframe_root_window,
457 Fframe_first_window and Fset_frame_selected_window here from
458 lisp.h.
459
460 * frame.c (Fwindow_frame, Fframe_first_window)
461 (Fframe_root_window, Fframe_selected_window)
462 (Fset_frame_selected_window): Move to window.c.
463 (Factive_minibuffer_window): Move to minibuf.c.
464 (Fother_visible_frames_p): New function.
465
466 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
467
f230ecc9
MR
468 * window.c (decode_window, decode_any_window): Move up in code.
469 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
470 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
471 (Fwindow_buffer): Move up and rewrite doc-string.
472 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
473 (Fwindow_prev): New functions.
727e958e
MR
474 (Fwindow_frame): Move here from frame.c. Accept any window as
475 argument.
476 (Fframe_root_window, Fframe_first_window)
477 (Fframe_selected_window): Move here from frame.c. Accept frame
478 or arbitrary window as argument. Update doc-strings.
479 (Fminibuffer_window): Move up in code.
480 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
481 (Fset_frame_selected_window): Move here from frame.c.
482 Marginal rewrite.
727e958e
MR
483 (Fselected_window, select_window, Fselect_window): Move up in
484 code. Minor doc-string fixes.
f230ecc9 485
4d09bcf6
PE
4862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
487
488 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
489 Do not assume that spare memory exists; that assumption is valid
490 only if SYSTEM_MALLOC.
491 (LARGE_REQUEST): New macro, so that the issue of large requests
492 is separated from the issue of spare memory.
493
810928a2
AS
4942011-06-05 Andreas Schwab <schwab@linux-m68k.org>
495
172418ad
AS
496 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
497 format. (Bug#8806)
498
43f862f7
AS
499 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
500
810928a2
AS
501 * xfns.c (x_set_scroll_bar_default_width): Move declarations
502 before statements.
503
a059fe24
JD
5042011-06-05 Jan Djärv <jan.h.d@swipnet.se>
505
506 * gtkutil.c (xg_get_default_scrollbar_width): New function.
507
508 * gtkutil.h: Declare xg_get_default_scrollbar_width.
509
510 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
511 min width by calling x_set_scroll_bar_default_width (Bug#8505).
512
989bf368
JB
5132011-06-05 Juanma Barranquero <lekktu@gmail.com>
514
515 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
516
4b80f674
CY
5172011-06-04 Chong Yidong <cyd@stupidchicken.com>
518
519 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
520 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
521 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
522 New error handlers.
4b80f674
CY
523 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
524 Obey Vx_select_enable_clipboard_manager. Catch errors in
525 x_clipboard_manager_save (Bug#8779).
526 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 527 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 528
99a33b77 5292011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
530
531 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
532
99a33b77 5332011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
534
535 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
536 in the current matrix if keep_current_p is non-zero.
537
8264569d
EZ
5382011-06-04 Eli Zaretskii <eliz@gnu.org>
539
540 * bidi.c (bidi_level_of_next_char): Fix last change.
541
57f97249
EZ
5422011-06-03 Eli Zaretskii <eliz@gnu.org>
543
fec2107c 544 Support bidi reordering of text covered by display properties.
57f97249 545
fec2107c
EZ
546 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
547 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
548 (bidi_cache_search, bidi_cache_iterator_state)
549 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
550 (bidi_level_of_next_char, bidi_move_to_visually_next):
551 Support character positions inside a run of characters covered by a
fec2107c
EZ
552 display string.
553 (bidi_paragraph_init, bidi_resolve_explicit_1)
554 (bidi_level_of_next_char): Call bidi_fetch_char and
555 bidi_fetch_char_advance instead of FETCH_CHAR and
556 FETCH_CHAR_ADVANCE.
557 (bidi_init_it): Initialize new members.
558 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
559 definitions.
560 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
561 instead of using explicit *_CHAR codes.
d6d100dd
SM
562 (bidi_resolve_explicit, bidi_resolve_weak):
563 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
564 bidirectional text is supported only in multibyte buffers.
565 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
566 it to initialize the frame_window_p member of struct bidi_it.
567 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
568 (bidi_resolve_explicit, bidi_resolve_weak)
569 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
570 bidi_it->nchars is non-positive.
571 (bidi_level_of_next_char): Don't try to lookup the cache for the
572 next/previous character if nothing is cached there yet, or if we
573 were just reseat()'ed to a new position.
c40e2fb2 574
0e14fe90
EZ
575 * xdisp.c (set_cursor_from_row): Set start and stop points
576 according to the row's direction when priming the loop that looks
577 for the glyph on which to display cursor.
578 (single_display_spec_intangible_p): Function deleted.
579 (display_prop_intangible_p): Reimplement to call
580 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
581 Accept 3 additional arguments needed by handle_display_spec.
582 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
583 values: lists, `(when COND...)' forms, etc.
584 (single_display_spec_string_p): Support property values that are
585 lists with the argument STRING its top-level element.
586 (display_prop_string_p): Fix the condition for processing a
587 property that is a list to be consistent with handle_display_spec.
fec2107c 588 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
589 last portion of handle_display_prop.
590 (compute_display_string_pos): Accept additional argument
591 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
592 value of a `display' property is a "replacing spec".
593 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
594 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
595 the display property, but just return a value indicating whether
596 the display property will replace the characters it covers.
597 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
598 frame_window_p members of struct bidi_it.
d6d100dd
SM
599 (compute_display_string_pos, compute_display_string_end):
600 New functions.
fec2107c
EZ
601 (push_it): Accept second argument POSITION, where pop_it should
602 jump to continue iteration.
603 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 604
fec2107c
EZ
605 * keyboard.c (adjust_point_for_property): Adjust the call to
606 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
607
608 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
609 (bidi_init_it): Update prototypes.
610 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
611 (compute_display_string_pos, compute_display_string_end):
612 Declare prototypes.
fec2107c
EZ
613 (struct bidi_it): New members nchars and disp_pos. ch_len is now
614 EMACS_INT.
fc6f18ce 615
40087514 6162011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 617
57f53182
PE
618 Malloc failure behavior now depends on size of allocation.
619 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
620 * lisp.h: Change signatures accordingly.
621 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
622 All callers changed. (Bug#8762)
623
624 * gnutls.c: Use Emacs's memory allocators.
625 Without this change, the gnutls library would invoke malloc etc.
626 directly, which causes problems on non-SYNC_INPUT hosts, and which
627 runs afoul of improving memory_full behavior. (Bug#8761)
628 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
629 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
630 xfree instead of the default malloc, realloc, free.
631 (Fgnutls_boot): No need to check for memory allocation failure,
632 since xmalloc does that for us.
633
ac32cd99 634 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
635 * category.c (hash_get_category_set):
636 * ccl.c (ccl_driver):
637 * charset.c (Fdefine_charset_internal):
638 * charset.h (struct charset.hash_index):
639 * composite.c (get_composition_id, gstring_lookup_cache)
640 (composition_gstring_put_cache):
641 * composite.h (struct composition.hash_index):
642 * dispextern.h (struct image.hash):
643 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
644 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
645 (hashfn_equal, hashfn_user_defined, make_hash_table)
646 (maybe_resize_hash_table, hash_lookup, hash_put)
647 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
648 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
649 (Fsxhash, Fgethash, Fputhash, Fmaphash):
650 * image.c (make_image, search_image_cache, lookup_image)
651 (xpm_put_color_table_h):
652 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 653 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
654 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
655 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
656 * alloc.c (allocate_vectorlike):
657 Check for overflow in vector size calculations.
658 * ccl.c (ccl_driver):
659 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
660 * fns.c, image.c: Remove unnecessary static decls that would otherwise
661 need to be updated by these changes.
40087514
PE
662 * fns.c (make_hash_table, maybe_resize_hash_table):
663 Check for integer overflow with large hash tables.
0de4bb68
PE
664 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
665 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
666 (SXHASH_REDUCE): New macro.
667 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
668 Use it instead of discarding useful hash info with large hash values.
669 (sxhash_float): New function.
670 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
671 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
672 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
673 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
674 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
675 Adjust signatures to match updated version of code.
676 (consing_since_gc): Now EMACS_INT, since a single hash table can
677 use more than INT_MAX bytes.
678
698d32e2
DN
6792011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
680
681 Make it possible to build with GCC-4.6+ -O2 -flto.
682
683 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
684
fd6fa53f
SM
6852011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * minibuf.c (get_minibuffer, read_minibuf_unwind):
688 Call minibuffer-inactive-mode.
689
864db017
JB
6902011-05-31 Juanma Barranquero <lekktu@gmail.com>
691
692 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
693 Update dependencies.
694
2ad0baf4
DN
6952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
696
697 * data.c (init_data): Remove code for UTS, this system is not
698 supported anymore.
699
4fcc2638
DN
7002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
701
702 Don't force ./temacs to start in terminal mode.
703
704 * frame.c (make_initial_frame): Initialize faces in all cases, not
705 only when CANNOT_DUMP is defined.
706 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
707
c56e0fd5
DN
7082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
709
710 * dispnew.c (add_window_display_history): Use const for the string
711 pointer. Remove declaration, not needed.
712
333d54da 7132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 714
55d4c1b2 715 Use 'inline', not 'INLINE'.
333d54da 716 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
717 * alloc.c, fontset.c (INLINE): Remove.
718 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
719 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
720 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
721 * gmalloc.c (register_heapinfo): Use inline unconditionally.
722 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
723
738db178
DN
7242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
725
726 Make it possible to run ./temacs.
727
728 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
729 syms_of_callproc does the same thing. Remove test for
730 "initialized", do it in the caller.
731 * emacs.c (main): Avoid calling set_initial_environment when dumping.
732
620c53a6
SM
7332011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
736 (read_minibuf): Use get_minibuffer.
737 (syms_of_minibuf): Use DEFSYM.
738 (Qmetadata): New var.
739 * data.c (Qbuffer): Don't make it static.
740 (syms_of_data): Use DEFSYM.
741
e003a292
PE
7422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
743
744 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
745 (CCL_CODE_MIN): New macro.
746
ed008a6d
PE
7472011-05-30 Paul Eggert <eggert@cs.ucla.edu>
748
3687c2ef
PE
749 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
750
ed008a6d
PE
751 * eval.c (Qdebug): Now static.
752 * lisp.h (Qdebug): Remove decl. This reverts a part of the
753 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
754 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
755
d66c4c7c
CY
7562011-05-29 Chong Yidong <cyd@stupidchicken.com>
757
758 * image.c: Various fixes to ImageMagick code comments.
759 (Fimagemagick_types): Doc fix.
760
5fbc2025
PE
7612011-05-29 Paul Eggert <eggert@cs.ucla.edu>
762
0196f88a
PE
763 Minor fixes prompted by GCC 4.6.0 warnings.
764
765 * xselect.c (converted_selections, conversion_fail_tag): Now static.
766
5fbc2025
PE
767 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
768 (x_clipboard_manager_save_all): Move extern decl to ...
769 * xterm.h: ... here, so that it can be checked for consistency.
770
1dd3c2d9
CY
7712011-05-29 Chong Yidong <cyd@stupidchicken.com>
772
773 * xselect.c (x_clipboard_manager_save_frame)
774 (x_clipboard_manager_save_all): New functions.
775 (Fx_clipboard_manager_save): Lisp function deleted.
776
777 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
778 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
779
780 * xterm.h: Update prototype.
781
5ba6571d
WX
7822011-05-28 William Xu <william.xwl@gmail.com>
783
784 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
785 exiting (Bug#8239).
786
3eaff834
JM
7872011-05-28 Jim Meyering <meyering@redhat.com>
788
e1900994 789 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
790 * fns.c (to_uchar): Define.
791 (crypto_hash_function): Use it to convert some newly-signed
792 variables to unsigned, to avoid sign-extension bugs. For example,
793 without this change, (md5 "truc") would evaluate to
794 45723a2aff78ff4fff7fff1114760e62 rather than the expected
795 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 796 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 797
0f6990a7
PE
7982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
799
800 Integer overflow fixes.
c8a9ca5a 801
08686060
PE
802 * dbusbind.c: Serial number integer overflow fixes.
803 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
804 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
805 to hold a serial number that is too large for a fixnum.
806 (Fdbus_method_return_internal, Fdbus_method_error_internal):
807 Check for serial numbers out of range. Decode any serial number
59568bf0 808 that was so large that it became a float. (Bug#8722)
08686060 809
2d1fc3c7
PE
810 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
811 (Fdbus_call_method, Fdbus_call_method_asynchronously):
812 Use XFASTINT rather than XUINT when numbers are nonnegative.
813 (xd_append_arg, Fdbus_method_return_internal):
814 (Fdbus_method_error_internal): Likewise. Also, for unsigned
815 arguments, check that Lisp number is nonnegative, rather than
59568bf0 816 silently wrapping negative numbers around. (Bug#8722)
30217ff0 817 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 818 (Bug#8722)
2d1fc3c7 819
c8a9ca5a
PE
820 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
821
519e1d69
PE
822 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
823
30569699
PE
824 ccl: add integer overflow checks
825 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
826 (IN_INT_RANGE): New macros.
827 (ccl_driver): Use them to check for integer overflow when
828 decoding a CCL program. Many of the new checks are whether XINT (x)
829 fits in int; it doesn't always, on 64-bit hosts. The new version
830 doesn't catch all possible integer overflows, but it's an
847044ea 831 improvement. (Bug#8719)
30569699 832
c11285dc
PE
833 * alloc.c (make_event_array): Use XINT, not XUINT.
834 There's no need for unsigned here.
835
fdccd48e
PE
836 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
837 This follows up to the 2011-05-06 change that substituted uintptr_t
838 for EMACS_INT. This case wasn't caught back then.
839
37910ab2
PE
840 Rework Fformat to avoid integer overflow issues.
841 * editfns.c: Include <float.h> unconditionally, as it's everywhere
842 now (part of C89). Include <verify.h>.
843 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
844 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
845 (Fformat): Avoid the prepass trying to compute sizes; it was only
846 approximate and thus did not catch overflow reliably. Instead, walk
847 through the format just once, formatting and computing sizes as we go,
848 checking for integer overflow at every step, and allocating a larger
849 buffer as needed. Keep track separately whether the format is
850 multibyte. Keep only the most-recently calculated precision, rather
851 than them all. Record whether each argument has been converted to
852 string. Use EMACS_INT, not int, for byte and char and arg counts.
853 Support field widths and precisions larger than INT_MAX. Avoid
854 sprintf's undefined behavior with conversion specifications such as %#d
855 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
856 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
857 formatting out-of-range floating point numbers with int
858 formats. (Bug#8668)
859
2e6578fb
PE
860 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
861
0ae6bdee
PE
862 * data.c: Avoid integer truncation in expressions involving floats.
863 * data.c: Include <intprops.h>.
864 (arith_driver): When there's an integer overflow in an expression
865 involving floating point, convert the integers to floating point
866 so that the resulting value does not suffer from catastrophic
867 integer truncation. For example, on a 64-bit host (* 4
868 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
869 Do not rely on undefined behavior after integer overflow.
870
de883a70
PE
871 merge count_size_as_multibyte, parse_str_to_multibyte
872 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 873 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
874 Check for integer overflow.
875 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
876 since it's now a duplicate of the other. This is more of
877 a character than a buffer op, so better that it's in character.c.
878 * fns.c, print.c: Adjust to above changes.
879
2ff916cb
PE
8802011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
881
882 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
883
f1b54466
PE
8842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
885
fb1ac845
PE
886 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
887 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
888 (x_clipboard_manager_save): Now static.
889 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
890
f1b54466
PE
891 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
892 (crypto_hash_function): Now static.
893 Fix pointer signedness problems. Avoid unnecessary initializations.
894
a9f737ee
CY
8952011-05-27 Chong Yidong <cyd@stupidchicken.com>
896
897 * termhooks.h (Vselection_alist): Make it terminal-local.
898
899 * terminal.c (create_terminal): Initialize it.
900
901 * xselect.c: Support for clipboard managers.
902 (Vselection_alist): Move to termhooks.h as terminal-local var.
903 (LOCAL_SELECTION): New macro.
904 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
905 (symbol_to_x_atom): Remove gratuitous arg.
906 (x_handle_selection_request, lisp_data_to_selection_data)
907 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
908 (x_own_selection, x_get_local_selection, x_convert_selection):
909 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
910 (some_frame_on_display): Delete unused function.
911 (Fx_own_selection_internal, Fx_get_selection_internal)
912 (Fx_disown_selection_internal, Fx_selection_owner_p)
913 (Fx_selection_exists_p): New optional frame arg.
914 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
915 (x_handle_selection_clear): Don't treat other terminals with the
916 same keyboard specially. Use the terminal-local Vselection_alist.
917 (x_clear_frame_selections): Use Frun_hook_with_args.
918
919 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
920
921 * xterm.h: Add support for those atoms.
922
e067f0c1
CY
9232011-05-26 Chong Yidong <cyd@stupidchicken.com>
924
925 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
926 (converted_selections, conversion_fail_tag): New global variables.
927 (x_selection_request_lisp_error): Free the above.
928 (x_get_local_selection): Remove unnecessary code.
929 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
930 of converted selections stored in converted_selections.
931 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
932 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
933 (x_convert_selection): New function.
934 (x_handle_selection_event): Simplify.
935 (x_get_foreign_selection): Don't ignore incoming requests while
936 waiting for an answer; this will fail when we implement
937 SAVE_TARGETS, and seems unnecessary anyway.
938 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
939 (Vx_sent_selection_functions): Doc fix.
940
0f4aebc0
LL
9412011-05-26 Leo Liu <sdl.web@gmail.com>
942
943 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
944
e61124cd
YM
9452011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
946
947 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
948
949 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
950 for fringe update if it has periodic bitmap.
951 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
952 and fringe_bitmap_periodic_p.
953
954 * fringe.c (get_fringe_bitmap_data): New function.
955 (draw_fringe_bitmap_1, update_window_fringes): Use it.
956 (update_window_fringes): Record periodicity of fringe bitmap in glyph
957 row. Mark glyph row for fringe update if periodicity changed.
958
959 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
960 for fringe update unless it has periodic bitmap.
961
f16d9837
KH
9622011-05-25 Kenichi Handa <handa@m17n.org>
963
964 * xdisp.c (get_next_display_element): Set correct it->face_id for
965 a static composition.
966
e1b90ef6
LL
9672011-05-24 Leo Liu <sdl.web@gmail.com>
968
969 * deps.mk (fns.o):
970 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
971
972 * fns.c (crypto_hash_function, Fsha1): New function.
973 (Fmd5): Use crypto_hash_function.
974 (syms_of_fns): Add Ssha1.
975
7400048f
PE
9762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
977
978 * gnutls.c: Remove unused macros.
979 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
980 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
981 Remove macros that are defined and never used.
982 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
983
abb71cf4
CY
9842011-05-22 Chong Yidong <cyd@stupidchicken.com>
985
986 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
987 (Fx_get_selection_internal): Minor cleanup.
988 (Fx_own_selection_internal): Rename arguments for consistency with
989 select.el.
990
6307db39
PE
9912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
992
993 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
994
f3d4e0a4
CY
9952011-05-22 Chong Yidong <cyd@stupidchicken.com>
996
997 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
998
4d8ade89
YM
9992011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1000
1001 * dispnew.c (scrolling_window): Don't exclude the case that the
1002 last enabled row in the desired matrix touches the bottom boundary.
1003
32078c8d
GM
10042011-05-21 Glenn Morris <rgm@gnu.org>
1005
1006 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1007 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1008 and add some more files.
32078c8d 1009
7285dc67
EZ
10102011-05-20 Eli Zaretskii <eliz@gnu.org>
1011
1012 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1013 report_file_error introduced by the change from 2011-05-07.
1014
89d1bd22
PE
10152011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * systime.h (Time): Define only if emacs is defined.
1018 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1019 where the include path doesn't have X11/X.h by default. See
1020 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1021
e23640bb 10222011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1023
1024 * composite.c (find_automatic_composition): Fix previous change.
1025
b9704ad9
GM
10262011-05-20 Glenn Morris <rgm@gnu.org>
1027
1028 * lisp.mk: New file, split from Makefile.in.
1029 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1030 (shortlisp): Remove.
1031 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1032
4a720484
GM
10332011-05-19 Glenn Morris <rgm@gnu.org>
1034
1035 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1036 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1037 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1038 (lisp): Set the order to that of loadup.el.
1039 (shortlisp): Make it a copy of $lisp.
1040 (SOME_MACHINE_LISP): Remove.
1041 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1042 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1043
a28d4396
KH
10442011-05-18 Kenichi Handa <handa@m17n.org>
1045
1046 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1047 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1048 (find_automatic_composition): Mostly rewrite for efficiency.
1049
a2b1fa8e
JB
10502011-05-18 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * makefile.w32-in: Update dependencies.
1053
8e1f5610
CS
10542011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1055
1056 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1057 revision 104625).
1058
7025ee00 10592011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1060
cdfa6eab
PE
1061 Fix some integer overflow issues, such as string length overflow.
1062
06d6db33
PE
1063 * insdel.c (count_size_as_multibyte): Check for string overflow.
1064
2b4560a8
PE
1065 * character.c (lisp_string_width): Check for string overflow.
1066 Use EMACS_INT, not int, for string indexes and lengths; in
1067 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1068 the resulting string length overflows an EMACS_INT; instead,
1069 report a string overflow if no precision given. When checking for
1070 precision exhaustion, use a check that cannot possibly have
1071 integer overflow. (Bug#8675)
1072 * character.h (lisp_string_width): Adjust to new signature.
1073
cb93f9be
PE
1074 * alloc.c (string_overflow): New function.
1075 (Fmake_string): Use it. This doesn't change behavior, but saves
1076 a few bytes and will simplify future changes.
1077 * character.c (string_escape_byte8): Likewise.
1078 * lisp.h (string_overflow): New decl.
1079
1a1f3366
PE
1080 Fixups, following up to the user-interface timestamp change.
1081 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1082 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1083 * msdos.c (mouse_get_pos): Likewise.
1084 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1085 * w32gui.h (Time): Define by including "systime.h" rather than by
1086 declaring it ourselves. (Bug#8664)
1087
d4e3e4d3
PE
1088 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1089 * image.c (clear_image_cache): Likewise.
1090
f6a24d19
PE
1091 * term.c (term_mouse_position): Don't assume time_t wraparound.
1092
08dc5ae6
PE
1093 Be more systematic about user-interface timestamps.
1094 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1095 and sometimes 'EMACS_UINT', to represent these timestamps.
1096 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1097 This makes the code easier to follow, and makes it easier to catch
1098 integer overflow bugs such as Bug#8664.
1099 * frame.c (Fmouse_position, Fmouse_pixel_position):
1100 Use Time, not unsigned long, for user-interface timestamps.
1101 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1102 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1103 * keyboard.h (last_event_timestamp): Likewise.
1104 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1105 * menu.h (xmenu_show): Likewise.
1106 * term.c (term_mouse_position): Likewise.
1107 * termhooks.h (struct input_event.timestamp): Likewise.
1108 (struct terminal.mouse_position_hook): Likewise.
1109 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1110 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1111 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1112 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1113 what it was before.
1114 * menu.h, termhooks.h: Include "systime.h", for Time.
1115
8e55734a
PE
1116 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1117 Don't assume that the difference between two unsigned long values
1118 can fit into an integer. At this point, we know button_down_time
1119 <= event->timestamp, so the difference must be nonnegative, so
1120 there's no need to cast the result if double-click-time is
1121 nonnegative, as it should be; check that it's nonnegative, just in
1122 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1123 apart (about 25 days). (Bug#8664)
8e55734a 1124
841f1b75 1125 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1126 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1127
3e26f69c
PE
1128 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1129 that always fit in int. Use a sentinel instead of a counter, to
1130 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1131 * frame.h (struct frame): Use int for menu_bar_items_used
1132 instead of EMACS_INT, since it always fits in int.
3e26f69c 1133
5cc152c0
PE
1134 * menu.c (grow_menu_items): Check for int overflow.
1135
d89eb65e
PE
1136 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1137
5235bd3e
PE
1138 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1139 Before, the code was not consistent. These values cannot exceed
1140 2**31 - 1 so there's no need to make them unsigned.
1141 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1142 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1143 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1144 as modifiers.
1145 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1146
bc827e23
PE
1147 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1148 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1149 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1150 presumably because the widths might not match.
1151
78eb494e
PE
1152 * window.c (size_window): Avoid needless test at loop start.
1153
04f2d78b
CB
11542011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1155
1156 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1157
d2fc7e3d 11582011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1159
1160 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1161
d2fc7e3d 11622011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1163
1164 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1165 `width' to `bar_area_x' and `bar_area_width', respectively.
1166 (x_scroll_run): Take account of fringe background extension.
1167
04f2d78b
CB
1168 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1169 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1170 `bar_area_width', respectively.
1171 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1172 background extension.
1173
79b70037
GM
11742011-05-10 Jim Meyering <meyering@redhat.com>
1175
1176 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1177
2f142cc5
JB
11782011-05-10 Juanma Barranquero <lekktu@gmail.com>
1179
1180 * image.c (Finit_image_library): Return t for built-in image types,
1181 like pbm and xbm. (Bug#8640)
1182
57679c86
AS
11832011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1184
1185 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1186
888c9e86
EZ
11872011-05-07 Eli Zaretskii <eliz@gnu.org>
1188
b0512a1d
EZ
1189 * w32console.c (Fset_screen_color): Doc fix.
1190 (Fget_screen_color): New function.
1191 (syms_of_ntterm): Defsubr it.
1192
7285dc67
EZ
1193 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1194 unlink the temporary file if Fcall_process didn't create it in the
1195 first place.
1196 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1197 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1198 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1199 cue to call_process_cleanup not to close that handle.
1200
4d3fcc8e
BK
12012011-05-07 Ben Key <bkey76@gmail.com>
1202
1203 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1204 one of two shell specific rules, either bootstrap-temacs-CMD or
1205 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1206 to the previous implementation of the bootstrap-temacs rule.
1207 The bootstrap-temacs-CMD rule is similar to the previous
1208 implementation of the bootstrap-temacs rule except that it
1209 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1210 variable.
1211
1212 These changes, along with some changes to nt/configure.bat,
1213 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1214 earlier fix to add support for --cflags and --ldflags options
1215 that include quotes so that it works whether make uses cmd or
1216 sh as the shell.
1217
b4289b64
MA
12182011-05-06 Michael Albinus <michael.albinus@gmx.de>
1219
1220 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1221 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1222 is a constant.
1223 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1224 a string. Handle both cases.
1225 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1226 (Fdbus_register_method): Use Qinvalid_function.
1227
af4c0e28
JB
12282011-05-06 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * makefile.w32-in: Update dependencies.
1231 (LISP_H): Add inttypes.h and stdin.h.
1232 (PROCESS_H): Add unistd.h.
1233
c51453d9
EZ
12342011-05-06 Eli Zaretskii <eliz@gnu.org>
1235
1236 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1237 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1238
8ff0ac3c 12392011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1240
4c4b566b
PE
1241 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1242
aab2b9b5
PE
1243 * term.c (vfatal): Remove stray call to va_end.
1244 It's not needed and the C Standard doesn't allow it here anyway.
1245
c378da0b
PE
1246 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1247 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1248
288b08c7
PE
1249 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1250 bytes.
1251
e3601888
PE
1252 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1253
db6c0e74
PE
1254 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1255
dd5963ea
PE
1256 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1257
88c9450f
PE
1258 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1259
2f9442b8
PE
1260 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1261
c032b5f8
PE
1262 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1263 * charset.c (Fdefine_charset_internal): Don't initialize
1264 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1265 32-bit int (Bug#8600).
a108c10b
PE
1266
1267 * lread.c (read_integer): Be more consistent with string-to-number.
1268 Use string_to_number to do the actual conversion; this avoids
1269 rounding errors and fixes some other screwups. Without this fix,
1270 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1271 (digit_to_number): Move earlier, for benefit of read_integer.
1272 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1273 not a digit in any supported base. (Bug#8602)
a108c10b 1274
ad5f9eea
PE
1275 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1276
aec1708a
PE
1277 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1278 to match comment at start of function. This also removes a
1279 GCC warning about overflow in a 32+64-bit port.
1280
47be4ab5
PE
1281 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1282
371cac43
PE
1283 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1284 Reported by Stefan Monnier in
1285 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1286 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1287 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1288
d01a7826
PE
1289 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1290 (EMACS_UINTPTR): Likewise, with uintptr_t.
1291
7fd47d5c
PE
1292 * lisp.h: Prefer 64-bit EMACS_INT if available.
1293 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1294 on 32-bit hosts that have 64-bit int, so that they can access
1295 large files.
122b0c86
PE
1296 However, temporarily disable this change unless the temporary
1297 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1298
8727937b
PE
1299 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1300
8ac068ac
PE
1301 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1302 This removes an assumption that EMACS_INT and long are the same
1303 width as pointers. The assumption is true for Emacs porting targets
1304 now, but we want to make other targets possible.
1305 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1306 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1307 In the rest of the code, change types of integers that hold casted
1308 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1309 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1310 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1311 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1312 No need to cast type when ORing.
1313 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1314 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1315 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1316 assume EMACS_INT is the same width as char *.
1317 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1318 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1319 Remove no-longer-needed casts.
1320 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1321 (xg_tool_bar_help_callback, xg_make_tool_item):
1322 Use EMACS_INTPTR to hold an integer
1323 that will be cast to void *; this can avoid a GCC warning
1324 if EMACS_INT is not the same width as void *.
1325 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1326 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1327 (current_message_1, set_message_1):
1328 Use a local to convert to proper width without a cast.
1329 * xmenu.c (dialog_selection_callback): Likewise.
1330
ede49d71
PE
1331 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1332 Also, don't assume VALBITS / RAND_BITS is less than 5,
1333 and don't rely on undefined behavior when shifting a 1 left into
1334 the sign bit.
1335 * lisp.h (get_random): Change signature to match.
1336
2f30ecd0
PE
1337 * lread.c (hash_string): Use size_t, not int, for hash computation.
1338 Normally we prefer signed values; but hashing is special, because
1339 it's better to use unsigned division on hash table sizes so that
1340 the remainder is nonnegative. Also, size_t is the natural width
1341 for hashing into memory. The previous code used 'int', which doesn't
1342 retain enough info to hash well into very large tables.
1343 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1344
2a866e7b
PE
1345 * dbusbind.c: Don't possibly lose pointer info when converting.
1346 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1347 Use XPNTR rather than XHASH, so that the high-order bits of
1348 the pointer aren't lost when converting through void *.
1349
51639eac
PE
1350 * eval.c (Fautoload): Don't double-shift a pointer.
1351
92394119
PE
1352 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1353
dbdb9a7c
JB
13542011-05-06 Juanma Barranquero <lekktu@gmail.com>
1355
1356 * gnutls.c (DEF_GNUTLS_FN):
1357 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1358
db7a0b4f
AS
13592011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1360
1361 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1362 marker. (Bug#8610)
1363
f7ff1b0f 13642011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1365
1366 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1367 New version that can reserve upto 2GB of heap space.
1368
f7ff1b0f 13692011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1370
1371 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1372
639c109b
TZ
13732011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1374
1375 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1376 `gnutls_certificate_set_x509_key_file'.
1377
d2127135
JB
13782011-05-05 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1381 Update dependencies.
1382
e968f4f3
JB
13832011-05-04 Juanma Barranquero <lekktu@gmail.com>
1384
1385 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1386 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1387 Remove unused parameter `fildes'.
1388 * process.c (read_process_output, send_process): Don't pass it.
1389
84d358f0
JB
13902011-05-04 Juanma Barranquero <lekktu@gmail.com>
1391
1392 Fix previous change: the library cache is defined in w32.c.
1393 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1394 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1395
0898ca10
JB
13962011-05-04 Juanma Barranquero <lekktu@gmail.com>
1397
1398 Implement dynamic loading of GnuTLS on Windows.
1399
1400 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1401 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1402 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1403 Declare.
1404
1405 * gnutls.c (Qgnutls_dll): Define.
1406 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1407 (gnutls_*): Declare function pointers.
1408 (init_gnutls_functions): New function to initialize function pointers.
1409 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1410 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1411 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1412 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1413 (emacs_gnutls_write, emacs_gnutls_read)
1414 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1415 (Fgnutls_available_p): New function.
1416 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1417 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1418 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1419
1420 * image.c: Include w32.h.
1421 (Vimage_type_cache): Delete.
1422 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1423 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1424 (w32_delayed_load): Move to w32.c.
1425
1426 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1427
1428 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1429 (w32_delayed_load): Move from image.c. When loading a library, record
1430 its filename in the :loaded-from property of the library id.
1431 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1432 Initialize and staticpro them.
1433 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1434
1435 * process.c: Include lisp.h before w32.h, not after.
1436 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1437 instead of gnutls_record_check_pending.
1438
1439 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1440
ff4de4aa
TZ
14412011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1442
1443 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1444 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1445 as passed in.
1446
abe95abb
JD
14472011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1448
1449 * xterm.c (x_set_frame_alpha): Do not set property on anything
1450 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1451
e16e55d4
JB
14522011-05-02 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1455
bafcf6a5
JB
14562011-05-02 Juanma Barranquero <lekktu@gmail.com>
1457
1458 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1459 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1460 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1461 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1462 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1463 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1464 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1465 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1466 (Qgnutls_bootprop_callbacks_verify): Make static.
1467
e7a6747f
AS
14682011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1469
19ed11ba
AS
1470 * callproc.c: Indentation fixup.
1471
e7a6747f 1472 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1473 (wait_for_termination, interruptible_wait_for_termination):
1474 Move after wait_for_termination_1.
e7a6747f 1475
1ef14cb4
LMI
14762011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1477
1478 * sysdep.c (interruptible_wait_for_termination): New function
1479 which is like wait_for_termination, but allows keyboard
1480 interruptions.
1481
1482 * callproc.c (Fcall_process): Add (:file "file") as an option for
1483 the STDOUT buffer.
1484 (Fcall_process_region): Ditto.
1485
330d880c
EZ
14862011-04-30 Eli Zaretskii <eliz@gnu.org>
1487
8db90b73
EZ
1488 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1489 rather than `XVECTOR (FOO)->size'.
1490
330d880c
EZ
1491 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1492 inttypes.h, as a gnulib replacement is used if it not available in
1493 system headers.
1494
15cbd324
EZ
14952011-04-21 Eli Zaretskii <eliz@gnu.org>
1496
1497 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1498 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1499 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1500
1501 * coding.c (coding_alloc_by_realloc): Error out if destination
1502 will grow beyond MOST_POSITIVE_FIXNUM.
1503 (decode_coding_emacs_mule): Abort if there isn't enough place in
1504 charbuf for the composition carryover bytes. Reserve an extra
1505 space for up to 2 characters produced in a loop.
1506 (decode_coding_iso_2022): Abort if there isn't enough place in
1507 charbuf for the composition carryover bytes.
1508
15092011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1510
ae940cca
EZ
1511 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1512 aborting when %lld or %lll format is passed.
1513 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1514 %llo or %llx format is passed. (Bug#8545)
1515
03ab8921
EZ
1516 * window.c (window_scroll_line_based): Use a marker instead of
1517 simple variables to record original value of point. (Bug#7952)
1518
afda1437
EZ
1519 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1520 produced by %s or %c overflows available buffer space. (Bug#8545)
1521
f76dee0c
PE
15222011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1525 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1526
fdc5744d
JB
15272011-04-28 Juanma Barranquero <lekktu@gmail.com>
1528
1529 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1530
638f053a
JB
15312011-04-28 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * keyboard.c (Qdelayed_warnings_hook): Define.
1534 (command_loop_1): Run `delayed-warnings-hook'
1535 if Vdelayed_warnings_list is non-nil.
1536 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1537 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1538
d178f871
EZ
15392011-04-28 Eli Zaretskii <eliz@gnu.org>
1540
1541 * doprnt.c (doprnt): Don't return value smaller than the buffer
1542 size if the message was truncated. (Bug#8545).
1543
b124fd93
JB
15442011-04-28 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1547 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1548
e810457d
PE
15492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1552
ea51cceb
JB
15532011-04-27 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * makefile.w32-in: Update dependencies.
1556
94dcfacf
EZ
15572011-04-27 Eli Zaretskii <eliz@gnu.org>
1558
1559 Improve `doprnt' and its usage. (Bug#8545)
1560 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1561 `format_end'. Remove support for %l as a conversion specifier.
1562 Don't use xrealloc. Improve diagnostics when the %l size modifier
1563 is used. Update the commentary.
1564
1565 * eval.c (verror): Simplify calculation of size_t.
1566
1567 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1568 messages.
1569
f61f41d7
PE
15702011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1571
1572 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1573 change.
1574
96fb4434
PE
15752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1578 This makes this file independent of the recent pseudovector change.
1579
671875da 15802011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1581
69e9b5a3
PE
1582 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1583
b5f869a7 1584 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1585 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1586 Remove unused local.
c8926152 1587 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1588
841a1577 1589 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1590 GCC 4.6.0 optimizes based on type-based alias analysis.
1591 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1592 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1593 != &v->size, and therefore "v->size = 1; b->size = 2; return
1594 v->size;" must therefore return 1. This assumption is incorrect
1595 for Emacs, since it type-puns struct Lisp_Vector * with many other
1596 types. To fix this problem, this patch adds a new type struct
f904488f 1597 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1598 and pseudovectors, and helps optimizing compilers not get fooled
1599 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1600 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1601 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1602 the size member.
eab3844f
PE
1603 (XSETPVECTYPE): Rewrite in terms of new macro.
1604 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1605 This is a bit clearer, and further avoids the possibility of
1606 undesirable aliasing.
1607 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1608 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1609 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1610 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1611 (ASIZE): Now uses header.size rather than size.
1612 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1613 to avoid the hassle of writing XVECTOR (foo)->header.size.
1614 (struct vectorlike_header): New type.
eab3844f
PE
1615 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1616 object, to help avoid aliasing.
1617 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1618 (SUBRP): Likewise, since Lisp_Subr is a special case.
1619 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1620 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1621 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1622 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1623 changed to be "header.size" and "header.next".
1624 * buffer.h (struct buffer): Likewise.
1625 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1626 * frame.h (struct frame): Likewise.
1627 * process.h (struct Lisp_Process): Likewise.
1628 * termhooks.h (struct terminal): Likewise.
1629 * window.c (struct save_window_data, struct saved_window): Likewise.
1630 * window.h (struct window): Likewise.
1631 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1632 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1633 * buffer.c (init_buffer_once): Likewise.
1634 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1635 special case.
1636 * process.c (Fformat_network_address): Use local var for size,
1637 for brevity.
1638
0df1eac5
PE
1639 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1640
847ab9d1 1641 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1642 * data.c (atof): Remove decl; no longer used or needed.
1643 (digit_to_number): Move to lread.c.
1644 (Fstring_to_number): Use new string_to_number function, to be
1645 consistent with how the Lisp reader treats infinities and NaNs.
1646 Do not assume that floating-point numbers represent EMACS_INT
1647 without losing information; this is not true on most 64-bit hosts.
1648 Avoid double-rounding errors, by insisting on integers when
1649 parsing non-base-10 numbers, as the documentation specifies.
1650 * lisp.h (string_to_number): New decl, replacing ...
1651 (isfloat_string): Remove.
bc0a5c13 1652 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1653 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1654 appears to have been a coding error. Similarly, do not accept
1655 strings like +-1e0 as floating point numbers. Do not report
1656 overflow for integer overflows unless the base is not 10 which
1657 means we have no simple and reliable way to continue.
1658 Break out the floating-point parsing into a new
1659 function string_to_number, so that Fstring_to_number parses
1660 floating point numbers consistently with the Lisp reader.
04f2d78b 1661 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1662 (E_CHAR, EXP_INT): Remove, replacing with ...
1663 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1664 (string_to_number): New function, replacing isfloat_string.
1665 This function checks for valid syntax and produces the resulting
1666 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1667 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1668 so that overflow for non-base-10 numbers is reported only when
1669 there's no portable and simple way to convert to floating point.
452f4150 1670
67769ffc
PE
1671 * textprop.c (set_text_properties_1): Rewrite for clarity,
1672 and to avoid GCC warning about integer overflow.
1673
c20db43f
PE
1674 * intervals.h (struct interval): Use EMACS_INT for members
1675 where EMACS_UINT might cause problems. See
1676 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1677 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1678 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1679 All uses changed.
37aa2f85
PE
1680 (offset_intervals): Tell GCC not to worry about length overflow
1681 when negating a negative length.
c20db43f 1682
2538aa2f
PE
1683 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1684 (overrun_check_free): Likewise.
1685
f2d3008d
PE
1686 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1687 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1688 word size.
1689
ec8df744
PE
1690 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1691 (gnutls_make_error): Rename local to avoid shadowing.
1692 (gnutls_emacs_global_deinit): ifdef out; not used.
1693 (Fgnutls_boot): Use const for pointer to readonly storage.
1694 Comment out unused local. Fix pointer signedness problems.
1695
640ee02d
PE
1696 * lread.c (openp): Don't stuff size_t into an 'int'.
1697 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1698 about possible signed overflow.
1699
6048fb2a
PE
1700 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1701 (GDK_KEY_g): Don't define if already defined.
1702 (xg_prepare_tooltip): Avoid pointer signedness problem.
1703 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1704
fa3c87e1
PE
1705 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1706 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1707
2172544b
PE
1708 * xfns.c (Fx_window_property): Simplify a bit,
1709 to make a bit faster and to avoid GCC 4.6.0 warning.
1710 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1711
9b821a21
PE
1712 * fns.c (internal_equal): Don't assume size_t fits in int.
1713
3c616cfa
PE
1714 * alloc.c (compact_small_strings): Tighten assertion a little.
1715
c2982e87
PE
1716 Replace pEd with more-general pI, and fix some printf arg casts.
1717 * lisp.h (pI): New macro, generalizing old pEd macro to other
1718 conversion specifiers. For example, use "...%"pI"d..." rather
1719 than "...%"pEd"...".
1720 (pEd): Remove. All uses replaced with similar uses of pI.
1721 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1722 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1723 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1724 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1725 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1726 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1727 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1728 64-bit hosts.
1729 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1730 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1731 * print.c (safe_debug_print, print_object): Likewise.
1732 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1733 to int.
6f04d126
PE
1734 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1735 avoiding the 0 flag, which is not portable.
c2982e87
PE
1736 * process.c (Fmake_network_process): Use pI to avoid cast.
1737 * region-cache.c (pp_cache): Likewise.
1738 * xdisp.c (decode_mode_spec): Likewise.
1739 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1740 behavior on 64-bit hosts with printf arg.
6f04d126 1741 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1742 (x_stop_queuing_selection_requests): Likewise.
1743 (x_get_window_property): Don't truncate byte count to an 'int'
1744 when tracing.
0b432f21 1745
5e073ec7
PE
1746 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1747 here, since it parses constructs like leading '-' and spaces,
1748 which are not wanted; and it overflows with large numbers.
1749 Instead, simply match F[0-9]+, which is what is wanted anyway.
1750
36372bf9
PE
1751 * alloc.c: Remove unportable assumptions about struct layout.
1752 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1753 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1754 (allocate_vectorlike, make_pure_vector): Use the new macros,
1755 plus offsetof, to remove unportable assumptions about struct layout.
1756 These assumptions hold on all porting targets that I know of, but
1757 they are not guaranteed, they're easy to remove, and removing them
1758 makes further changes easier.
1759
0b432f21
PE
1760 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1761 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1762 (string_overrun_cookie): Now const. Use initializers that
1763 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1764 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1765 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1766 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1767 multiple of sizeof (EMACS_INT); it need not be, if
1768 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1769 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1770
895009e1
JB
17712011-04-26 Juanma Barranquero <lekktu@gmail.com>
1772
1773 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1774
6a7a1b0b
TZ
17752011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1776
1777 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1778 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1779 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1780
841a1577 17812011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1782
1783 * lisp.h (Qdebug): List symbol.
895009e1 1784 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1785 * keyboard.c (debug-on-event): New variable.
1786 (handle_user_signal): Break into debugger when debug-on-event
1787 matches the current signal symbol.
1788
f2d3ba6f
DN
17892011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1790
1791 * alloc.c (check_sblock, check_string_bytes)
1792 (check_string_free_list): Convert to standard C.
1793
42ce4c63
TZ
17942011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1795
1796 * w32.c (emacs_gnutls_push): Fix typo.
1797
825cd63c
EZ
17982011-04-25 Eli Zaretskii <eliz@gnu.org>
1799
fb11d64d
EZ
1800 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1801 "cast to pointer from integer of different size".
1802
825cd63c
EZ
1803 Improve doprnt and its use in verror. (Bug#8545)
1804 * doprnt.c (doprnt): Document the set of format control sequences
1805 supported by the function. Use SAFE_ALLOCA instead of always
1806 using `alloca'.
1807
1808 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1809 is one byte too soon. Don't use xrealloc; instead xfree and
1810 xmalloc anew.
1811
e061a11b
TZ
18122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1813
1814 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1815 callbacks stage.
1816
1817 * gnutls.c: Renamed global_initialized to
1818 gnutls_global_initialized. Added internals for the
1819 :verify-hostname-error, :verify-error, and :verify-flags
1820 parameters of `gnutls-boot' and documented those parameters in the
1821 docstring. Start callback support.
1822 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1823 unless a fatal error occured. Call gnutls_alert_send_appropriate
1824 on error. Return error code.
1825 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1826 (emacs_gnutls_read): Likewise.
1827 (Fgnutls_boot): Return handshake error code.
1828 (emacs_gnutls_handle_error): New function.
1829 (wsaerror_to_errno): Likewise.
1830
1831 * w32.h (emacs_gnutls_pull): Add prototype.
1832 (emacs_gnutls_push): Likewise.
1833
1834 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1835 (emacs_gnutls_push): Likewise.
1836
18372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1838
1839 * process.c (wait_reading_process_output): Check if GnuTLS
1840 buffered some data internally if no FDs are set for TLS
1841 connections.
1842
1843 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1844 (LIBS): Link to USER_LIBS.
1845 ($(BLD)/gnutls.$(0)): New target.
1846
fa6996bc
EZ
18472011-04-24 Eli Zaretskii <eliz@gnu.org>
1848
eb35682e
EZ
1849 * xdisp.c (handle_single_display_spec): Rename the
1850 display_replaced_before_p argument into display_replaced_p, to
1851 make it consistent with the commentary. Fix typos in the
1852 commentary.
1853
e2ad650c
EZ
1854 * textprop.c (syms_of_textprop): Remove dead code.
1855 (copy_text_properties): Delete obsolete commentary about an
1856 interface that was deleted long ago. Fix typos in the description
1857 of arguments.
1858
1b2de274
EZ
1859 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1860 to changes in oldXMenu/XMenu.h from 2011-04-16.
1861 <menu_help_message, prev_menu_help_message>: Constify.
1862 (IT_menu_make_room): menu->help_text is now `const char **';
1863 adjust.
1864
1865 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1866 to changes in oldXMenu/XMenu.h from 2011-04-16.
1867 (struct XMenu): Declare `help_text' `const char **'.
1868
1869 * xfaces.c <Qunspecified>: Make extern again.
1870
1871 * syntax.c: Include sys/types.h before including regex.h, as
1872 required by Posix.
1873
762b15be
EZ
1874 * doc.c (get_doc_string): Improve the format passed to `error'.
1875
1876 * doprnt.c (doprnt): Improve commentary.
1877
1878 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1879
1880 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1881 them with etags.
1882
f1052e5d
EZ
1883 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1884 changes in globals.h immediately force recompilation.
762b15be
EZ
1885 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1886 $(CURDIR)/s/ms-w32.h.
1887 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1888
fa6996bc
EZ
1889 * character.c (Fchar_direction): Function deleted.
1890 (syms_of_character): Don't defsubr it.
1891 <char-direction-table>: Deleted.
1892
e6c3da20
EZ
18932011-04-23 Eli Zaretskii <eliz@gnu.org>
1894
1895 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1896 * doprnt.c: Include limits.h.
1897 (SIZE_MAX): New macro.
04f2d78b
CB
1898 (doprnt): Return a size_t value. 2nd arg is now size_t.
1899 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1900 Improve overflow protection. Support `l' modifier for integer
1901 conversions. Support %l conversion. Don't assume an EMACS_INT
1902 argument for integer conversions and for %c.
1903
1904 * lisp.h (doprnt): Restore prototype.
1905
1906 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1907 $(SRC)/character.h.
1908
1909 * Makefile.in (base_obj): Add back doprnt.o.
1910
1911 * deps.mk (doprnt.o): Add back prerequisites.
1912 (callint.o): Depend on character.h.
1913
1914 * eval.c (internal_lisp_condition_case): Include the handler
1915 representation in the error message.
1916 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1917 when breaking from the loop.
1918
1919 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1920
1921 * callint.c (Fcall_interactively): When displaying error message
1922 about invalid control letter, pass the character's codepoint, not
1923 a pointer to its multibyte form. Improve display of the character
1924 in octal and display also its hex code.
1925
1926 * character.c (char_string): Use %x to display the (unsigned)
1927 codepoint of an invalid character, to avoid displaying a bogus
1928 negative value.
1929
1930 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1931 `error', not SYMBOL_NAME itself.
1932
1933 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1934 character arguments to `error'.
1935
1936 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1937 to `error' in error message about FINAL_CHAR argument. Make sure
1938 FINAL_CHAR is a character, and use %c when it is passed as
1939 argument to `error'.
1940
4ffd0d6b 19412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1942
1943 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1944
1945 * w32.c: Include <time.h>.
1946 (sys_localtime): New function.
1947
4ffd0d6b 19482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1949
1950 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1951
4ffd0d6b 1952 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1953
4ffd0d6b 19542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1955
4ffd0d6b
GM
1956 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1957 zombies (Bug#8467).
aac0c6e3 1958
04c56954
EZ
19592011-04-19 Eli Zaretskii <eliz@gnu.org>
1960
1961 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1962 gl_state.e_property when gl_state.object is Qt.
1963
1964 * insdel.c (make_gap_larger): Remove limitation of buffer size
1965 to <= INT_MAX.
1966
16a43933
CY
19672011-04-18 Chong Yidong <cyd@stupidchicken.com>
1968
1969 * xdisp.c (lookup_glyphless_char_display)
1970 (produce_glyphless_glyph): Handle cons cell entry in
1971 glyphless-char-display.
1972 (Vglyphless_char_display): Document it.
1973
1974 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1975 glyphless-char-display.
1976
4581706e
CY
19772011-04-17 Chong Yidong <cyd@stupidchicken.com>
1978
1979 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1980
1981 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1982
1983 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1984 definition for no-X builds.
1985
4887c6e2 19862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1987
fd35b6f9
PE
1988 Static checks with GCC 4.6.0 and non-default toolkits.
1989
5c1ccb01
PE
1990 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1991
006c5daa
PE
1992 * process.c (keyboard_bit_set): Define only if SIGIO.
1993 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1994 (send_process): Repair possible setjmp clobbering.
1995
efc736d3
PE
1996 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1997
4e2fe2e6
PE
1998 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1999
f97334a2
PE
2000 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2001
4e75f29d
PE
2002 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2003 Define only if needed.
2004
90efadd1
PE
2005 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2006 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2007 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2008
3c647824
PE
2009 * dispextern.h (struct redisplay_interface): Rename param
2010 to avoid shadowing.
e264f262 2011 * termhooks.h (struct terminal): Likewise.
761383f4 2012 * xterm.c (xembed_send_message): Likewise.
3c647824 2013
b58c5c4a
PE
2014 * insdel.c (make_gap_smaller): Define only if
2015 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2016
cad59032
PE
2017 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2018 it.
2019
c339dc2e
PE
2020 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2021 so that we aren't warned about unused symbols.
2022
91a3e27b
PE
2023 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2024
399c71d3 2025 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2026
8ffc96f5
PE
2027 * xfns.c (x_real_positions): Mark locals as initialized.
2028
eef9bc79
PE
2029 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2030
098db9dd
PE
2031 * xterm.c: Fix problems found by static analysis with other toolkits.
2032 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2033 (x_dispatch_event): Declare static if USE_GTK, and
2034 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2035 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2036 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2037 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2038 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2039
eb18f6cc
PE
2040 * xmenu.c (menu_help_callback): Pointer type fixes.
2041 Use const pointers when pointing at readonly data. Avoid pointer
2042 signedness clashes.
2043 (FALSE): Remove unused macro.
2044 (update_frame_menubar): Remove unused decl.
2045
1fe72bf8
PE
2046 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2047
60d9e1db
PE
2048 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2049 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2050 (single_menu_item): Rename local to avoid shadowing.
2051
39261c26
PE
2052 * keyboard.c (make_lispy_event): Remove unused local var.
2053
018c5e19
PE
2054 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2055 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2056
63d2b86e
PE
2057 * bitmaps: Change bitmaps from unsigned char back to the X11
2058 compatible char. Avoid the old compiler warnings about
2059 out-of-range initializers by using, for example, '\xab' rather
2060 than 0xab.
2061
aefd87e1
PE
2062 * xgselect.c (xgselect_initialize): Check vs interface
2063 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2064
bf501fb9
PE
2065 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2066
e9829fdf
PE
2067 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2068 to read-only memory.
2069
1086c095
PE
2070 * fns.c (vector): Remove; this old hack is no longer needed.
2071
2baccd04 2072 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2073 Remove unused var.
dde42981 2074 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2075
72391843 2076 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2077
436c16df 2078 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2079 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2080 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2081
92bb796d 2082 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2083 (x_term_init): Remove local to avoid shadowing.
92bb796d 2084
764430a3 2085 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2086
2087 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2088 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2089
d1dfb56c
EZ
20902011-04-16 Eli Zaretskii <eliz@gnu.org>
2091
c4354cb4
EZ
2092 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2093
d1dfb56c
EZ
2094 Fix regex.c, syntax.c and friends for buffers > 2GB.
2095 * syntax.h (struct gl_state_s): Declare character position members
2096 EMACS_INT.
2097
2098 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2099
04f2d78b
CB
2100 * textprop.c (verify_interval_modification, interval_of):
2101 Declare arguments EMACS_INT.
d1dfb56c
EZ
2102
2103 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2104 EMACS_INT.
2105
2106 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2107
2108 * indent.c (Fvertical_motion): Local variable it_start is now
2109 EMACS_INT.
2110
2111 * regex.c (re_match, re_match_2, re_match_2_internal)
2112 (bcmp_translate, regcomp, regexec, print_double_string)
2113 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2114 (re_compile_pattern, re_exec): Declare arguments and local
2115 variables `size_t' and `ssize_t' and return values `regoff_t', as
2116 appropriate.
2117 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2118 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2119 <compile_stack_type>: `size' and `avail' are now `size_t'.
2120
2121 * regex.h <regoff_t>: Use ssize_t, not int.
2122 (re_search, re_search_2, re_match, re_match_2): Arguments that
2123 specify buffer/string position and length are now ssize_t and
2124 size_t. Return type is regoff_t.
2125
613052cd
BK
21262011-04-16 Ben Key <bkey76@gmail.com>
2127
2128 * nsfont.m: Fixed bugs in ns_get_family and
2129 ns_descriptor_to_entity that were caused by using free to
2130 deallocate memory blocks that were allocated by xmalloc (via
2131 xstrdup). This caused Emacs to crash when compiled with
2132 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2133 --enable-checking=xmallocoverrun). xfree is now used to
2134 deallocate these memory blocks.
2135
4170f62f 21362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2137
71b41406
PE
2138 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2139
9587a89d
PE
2140 emacs_write: Accept and return EMACS_INT for sizes.
2141 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2142 et seq.
2143 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2144 Accept and return EMACS_INT.
2145 (emacs_gnutls_write): Return the number of bytes written on
2146 partial writes.
2147 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2148 (emacs_read, emacs_write): Remove check for negative size, as the
2149 Emacs source code has been audited now.
9587a89d
PE
2150 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2151 (emacs_read, emacs_write): Use it.
273a5f82
PE
2152 * process.c (send_process): Adjust to the new signatures of
2153 emacs_write and emacs_gnutls_write. Do not attempt to store
2154 a byte offset into an 'int'; it might overflow.
9587a89d 2155 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2156
3e047f51
PE
2157 * sound.c: Don't assume sizes fit in 'int'.
2158 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2159 Return EMACS_INT, not int.
3e047f51 2160 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2161 Accept EMACS_INT, not int.
2162 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2163 record read return values.
2164
cc39a9db
BK
21652011-04-15 Ben Key <bkey76@gmail.com>
2166
c9d0ec6d
JB
2167 * keyboard.c (Qundefined): Don't declare static since it is used
2168 in nsfns.m.
2169 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2170 static since they are used in nsfont.m.
cc39a9db 2171
6c60eb9f
SM
21722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * process.c (Qprocessp): Don't declare static.
2175 * lisp.h (Qprocessp): Declare again.
2176
7990b61a
JB
21772011-04-15 Juanma Barranquero <lekktu@gmail.com>
2178
2179 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2180
5d4cb038
PE
21812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2182
8bd7b830 2183 Improve C-level modularity by making more things 'static'.
cd64ea1d 2184
e3b27b31
PE
2185 Don't publish debugger-only interfaces to other modules.
2186 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2187 (verify_bytepos, count_markers): Move decls to the only modules
2188 that need them.
2189 * region-cache.h (pp_cache): Likewise.
2190 * window.h (check_all_windows): Likewise.
2191 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2192
5d4cb038
PE
2193 * sysdep.c (croak): Now static, if
2194 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2195 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2196
2197 * alloc.c (refill_memory_reserve): Now static if
2198 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2199 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2200
e87b6180
PE
2201 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2202 Define only if USE_LUCID.
2203
ac64929e
PE
2204 * xrdb.c (x_customization_string, x_rm_string): Now static.
2205
6f37259d
PE
2206 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2207 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2208
1683e3ab
PE
2209 * xdisp.c (draw_row_with_mouse_face): Now static.
2210 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2211
de9c2632
PE
2212 * window.h (check_all_windows): Mark externally visible.
2213
2b96acb7
PE
2214 * window.c (window_deletion_count): Now static.
2215
2216 * undo.c: Make symbols static if they're not exported.
2217 (last_undo_buffer, last_boundary_position, pending_boundary):
2218 Now static.
2219
50436f33
PE
2220 * textprop.c (interval_insert_behind_hooks): Now static.
2221 (interval_insert_in_front_hooks): Likewise.
2222
64520e5c
PE
2223 * term.c: Make symbols static if they're not exported.
2224 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2225 (max_frame_lines, tty_set_terminal_modes):
2226 (tty_reset_terminal_modes, tty_turn_off_highlight):
2227 (get_tty_terminal): Now static.
2228 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2229 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2230 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2231 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2232 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2233
1fa53021
PE
2234 * sysdep.c: Make symbols static if they're not exported.
2235 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2236 Now static.
2237 (sigprocmask_set, full_mask): Remove; unused.
2238 (wait_debugging): Mark as visible.
2239 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2240 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2241
d4b43b22
PE
2242 * syntax.c (syntax_temp): Define only if !__GNUC__.
2243
b7c513d0
PE
2244 * sound.c (current_sound_device, current_sound): Now static.
2245
989b29ad
PE
2246 * search.c (searchbufs, searchbuf_head): Now static.
2247
13a55a78
PE
2248 * scroll.c (scroll_cost): Remove; unused.
2249 * dispextern.h (scroll_cost): Remove decl.
2250
de68a1fc
PE
2251 * region-cache.h (pp_cache): Mark as externally visible.
2252
40ccffa6
PE
2253 * process.c: Make symbols static if they're not exported.
2254 (process_tick, update_tick, create_process, chan_process):
2255 (Vprocess_alist, proc_buffered_char, datagram_access):
2256 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2257 (deactivate_process): Mark defn as static, as well as decl.
2258 * lisp.h (create_process): Remove decl.
2259 * process.h (chan_process, Vprocess_alist): Remove decls.
2260
ad64fc97
PE
2261 * print.c: Make symbols static if they're not exported.
2262 (print_depth, new_backquote_output, being_printed, print_buffer):
2263 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2264 (print_interval, print_number_index, initial_stderr_stream):
2265 Now static.
2266 * lisp.h (Fprinc): Remove decl.
2267 (debug_output_compilation_hack): Mark as externally visible.
2268
adddb265
PE
2269 * sysdep.c (croak): Move decl from here to syssignal.h.
2270 * syssignal.h (croak): Put it here, so the API can be checked when
2271 'croak' is called from dissociate_if_controlling_tty.
2272
1717ede2
PE
2273 * minibuf.c: Make symbols static if they're not exported.
2274 (minibuf_save_list, choose_minibuf_frame): Now static.
2275 * lisp.h (choose_minibuf_frame): Remove decl.
2276
fa5fb2bc
PE
2277 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2278
1e3890d1
PE
2279 * lread.c: Make symbols static if they're not exported.
2280 (read_objects, initial_obarray, oblookup_last_bucket_number):
2281 Now static.
2282 (make_symbol): Remove; unused.
2283 * lisp.h (initial_obarray, make_symbol): Remove decls.
2284
8a1414fa
PE
2285 * keyboard.c: Make symbols static if they're not exported.
2286 (single_kboard, recent_keys_index, total_keys, recent_keys):
2287 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2288 (this_single_command_key_start, echoing, last_auto_save):
2289 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2290 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2291 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2292 (Vlispy_mouse_stem, double_click_count):
2293 Now static.
2294 (force_auto_save_soon): Define only if SIGDANGER.
2295 (ignore_mouse_drag_p): Now static if
2296 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2297 (print_help): Remove; unused.
2298 (stop_character, last_timer_event): Mark as externally visible.
2299 * keyboard.h (ignore_mouse_drag_p): Declare only if
2300 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2301 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2302 * lisp.h (echoing): Remove decl.
2303 (force_auto_save_soon): Declare only if SIGDANGER.
2304 * xdisp.c (redisplay_window): Simplify code, to make it more
2305 obvious that ignore_mouse_drag_p is not accessed if !defined
2306 USE_GTK && !defined HAVE_NS.
2307
93ea6e8f
PE
2308 * intervals.c: Make symbols static if they're not exported.
2309 (merge_properties_sticky, merge_interval_right, delete_interval):
2310 Now static.
2311 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2312
77382fcc
PE
2313 * insdel.c: Make symbols static if they're not exported.
2314 However, leave prepare_to_modify_buffer alone. It's never
2315 called from outside this function, but that appears to be a bug.
2316 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2317 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2318 (adjust_after_replace_noundo): Remove; unused.
2319 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2320 (signal_before_change): Remove decls.
77382fcc 2321
9306c32e
PE
2322 * indent.c (val_compute_motion, val_vmotion): Now static.
2323
cd44d2eb
PE
2324 * image.c: Make symbols static if they're not exported.
2325 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2326 if USE_GTK.
2327 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2328 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2329
ad9a7a06
PE
2330 * fringe.c (standard_bitmaps): Now static.
2331 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2332
81626931
PE
2333 * frame.c: Make symbols static if they're not exported.
2334 (x_report_frame_params, make_terminal_frame): Now static.
2335 (get_frame_param): Now static, unless HAVE_NS.
2336 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2337 (x_get_resource_string): Remove; not used.
2338 * frame.h (make_terminal_frame, x_report_frame_params):
2339 (x_get_resource_string); Remove decls.
2340 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2341 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2342
239f9db9
PE
2343 * font.c, fontset.c: Make symbols static if they're not exported.
2344 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2345 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2346 * font.c (font_close_object): Now static.
2347 * font.h (font_close_object): Remove.
2348 * fontset.c (FONTSET_OBJLIST): Remove.
2349 (free_realized_fontset) #if-0 the body, which does nothing.
2350 (face_suitable_for_char_p): #if-0, as it's never called.
2351 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2352 * xfaces.c (face_at_string_position):
2353 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2354 since 0 is always ASCII.
2355
dfcf3579
PE
2356 * fns.c (weak_hash_tables): Now static.
2357
5045092b
PE
2358 * fileio.c: Make symbols static if they're not exported.
2359 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2360 (Vwrite_region_annotation_buffers): Now static.
2361
57a96f5c
PE
2362 * eval.c: Make symbols static if they're not exported.
2363 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2364 * lisp.h (backtrace_list): Remove decl.
2365
35f08c38
PE
2366 * emacs.c: Make symbols static if they're not exported.
2367 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2368 (fatal_error_code, fatal_error_signal_hook, standard_args):
2369 Now static.
2370 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2371 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2372 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2373 * lisp.h (fatal_error_signal_hook): Remove decl.
2374 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2375
f44bd759
PE
2376 * editfns.c: Move a (normally-unused) function to its only use.
2377 * editfns.c, lisp.h (get_operating_system_release): Remove.
2378 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2379 worth the hassle of breaking this out.
2380
b532497d
PE
2381 * xterm.c: Make symbols static if they're not exported.
2382 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2383 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2384 (x_destroy_window, x_delete_display):
2385 Now static.
2386 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2387 (x_mouse_leave): Remove; unused.
2388 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2389 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2390 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2391 Remove decls.
2392 (x_mouse_leave): Declare only if WINDOWSNT.
2393 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2394 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2395 USE_X_TOOLKIT.
2396
1675728f
PE
2397 * ftxfont.c: Make symbols static if they're not exported.
2398 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2399 HAVE_FREETYPE.
2400 * font.h (ftxfont_driver): Likewise.
2401
e4cebfca
PE
2402 * xfns.c: Make symbols static if they're not exported.
2403 (x_last_font_name, x_display_info_for_name):
2404 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2405 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2406 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2407 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2408 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2409 (last_show_tip_args): Now static.
2410 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2411 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2412 (x_screen_planes): Remove; unused.
2413 * dispextern.h (x_screen_planes): Remove decl.
2414
5bf46f05
PE
2415 * dispnew.c: Make symbols static if they're not exported.
2416 * dispextern.h (redraw_garbaged_frames, scrolling):
2417 (increment_row_positions): Remove.
2418 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2419 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2420 Now static.
2421 (redraw_garbaged_frames): Remove; unused.
2422
435f4c28
PE
2423 * xfaces.c: Make symbols static if they're not exported.
2424 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2425 Remove decls.
2426 * xterm.h (defined_color): Remove decls.
2427 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2428 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2429 (menu_face_changed_default, defined_color, free_realized_face):
2430 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2431 (ascii_face_of_lisp_face): Remove; unused.
2432
8524aef3
PE
2433 * xdisp.c: Make symbols static if they're not exported.
2434 * dispextern.h (scratch_glyph_row, window_box_edges):
2435 (glyph_to_pixel_coords, set_cursor_from_row):
2436 (get_next_display_element, set_iterator_to_next):
2437 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2438 (show_mouse_face): Remove decls
2439 * frame.h (message_buf_print): Likewise.
2440 * lisp.h (pop_message, set_message, check_point_in_composition):
2441 Likewise.
2442 * xterm.h (set_vertical_scroll_bar): Likewise.
2443 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2444 (message_buf_print, scratch_glyph_row, displayed_buffer):
2445 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2446 (get_next_display_element, show_mouse_face, window_box_edges):
2447 (frame_to_window_pixel_xy, check_point_in_composition):
2448 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2449 (glyph_to_pixel_coords): Remove; unused.
2450
16390cd2
PE
2451 * dired.c (file_name_completion): Now static.
2452
2453 * dbusbind.c (xd_in_read_queued_messages): Now static.
2454
a25f4dfa
PE
2455 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2456 * data.c (circular_list_error): Remove.
2457
14a9c8df
PE
2458 * commands.h (last_point_position, last_point_position_buffer):
2459 (last_point_position_window): Remove decls.
2460 * keyboard.c: Make these variables static.
2461
04f2d78b
CB
2462 * coding.h (coding, code_convert_region, encode_coding_gap):
2463 Remove decls.
74ab6df5
PE
2464 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2465 (iso_code_class, detect_coding, code_convert_region): Now static.
2466 (encode_coding_gap): Remove; unused.
2467
38dfbee1
PE
2468 * chartab.c (chartab_chars, chartab_bits): Now static.
2469
a2cb4e63
PE
2470 * charset.h (charset_iso_8859_1): Remove decl.
2471 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2472 Now static.
2473
127198fd
PE
2474 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2475 * ccl.c (Vccl_program_table): Now static.
2476 (check_ccl_update): Remove; unused.
2477
d85b608f
PE
2478 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2479 * category.h: ... from here.
2480 * category.c (check_category_table, set_category_set): Now static.
2481
31cd66f3
PE
2482 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2483 * lisp.h: Remove these decls.
2484
c358e587
PE
2485 * buffer.c (buffer_count): Remove unused var.
2486
e78aecca
PE
2487 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2488 so that it's not optimized away.
2489 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2490 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2491 exported only to the debugger.
2492
e192d7d3 2493 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2494 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2495
92470028
PE
2496 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2497 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2498 was inaccessible from Lisp.
2499 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2500 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2501
244ed907
PE
2502 alloc.c: Import and export fewer symbols, and remove unused items.
2503 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2504 is defined.
2505 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2506 it's not optimized away by whole-program optimization.
2507 (message_enable_multibyte, free_misc): Remove.
2508 (catchlist, handlerlist, mark_backtrace):
2509 Declare only if BYTE_MARK_STACK.
2510 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2511 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2512 (message_enable_multibyte): Remove decl.
2513 (free_misc, interval_free_list, float_block, float_block_index):
2514 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2515 (cons_free_list, last_marked_index):
2516 Now static.
2517 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2518 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2519 (mark_backtrace): Define only if BYTE_MARK_STACK.
2520 * xdisp.c (message_enable_multibyte): Now static.
2521
61c2b50e 2522 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2523 This makes it easier for human readers (and static analyzers)
2524 to see whether these variables are used from other modules.
2525 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2526 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2527 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2528 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2529 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2530 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2531 * xmenu.c, xselect.c:
2532 Declare Q* vars static if they are not used in other modules.
2533 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2534 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2535 Remove decls of unexported vars.
2536 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2537
95c82688
PE
2538 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2539
16a97296
PE
2540 Make Emacs functions such as Fatom 'static' by default.
2541 This makes it easier for human readers (and static analyzers)
2542 to see whether these functions can be called from other modules.
2543 DEFUN now defines a static function. To make the function external
2544 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2545 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2546 (Finit_image_library):
16a97296
PE
2547 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2548 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2549 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2550 Remove decls, since these functions are now static.
2551 (Funintern, Fget_internal_run_time): New decls, since these functions
2552 were already external.
95c82688 2553
16a97296
PE
2554 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2555 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2556 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2557 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2558 * keyboard.c, keymap.c, lread.c:
2559 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2560 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2561 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2562 Mark functions with DEFUE instead of DEFUN,
2563 if they are used in other modules.
2564 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2565 decls for now-static functions.
2566 * buffer.h (Fdelete_overlay): Remove decl.
2567 * callproc.c (Fgetenv_internal): Mark as internal.
2568 * composite.c (Fremove_list_of_text_properties): Remove decl.
2569 (Fcomposition_get_gstring): New forward static decl.
2570 * composite.h (Fcomposite_get_gstring): Remove decl.
2571 * dired.c (Ffile_attributes): New forward static decl.
2572 * doc.c (Fdocumntation_property): New forward static decl.
2573 * eval.c (Ffetch_bytecode): New forward static decl.
2574 (Funintern): Remove extern decl; now in .h file where it belongs.
2575 * fileio.c (Fmake_symbolic_link): New forward static decl.
2576 * image.c (Finit_image_library): New forward static decl.
2577 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2578 * intervals.h (Fprevious_property_change):
2579 (Fremove_list_of_text_properties): Remove decls.
2580 * keyboard.c (Fthis_command_keys): Remove decl.
2581 (Fcommand_execute): New forward static decl.
2582 * keymap.c (Flookup_key): New forward static decl.
2583 (Fcopy_keymap): Now static.
2584 * keymap.h (Flookup_key): Remove decl.
2585 * process.c (Fget_process): New forward static decl.
2586 (Fprocess_datagram_address): Mark as internal.
2587 * syntax.c (Fsyntax_table_p): New forward static decl.
2588 (skip_chars): Remove duplicate decl.
2589 * textprop.c (Fprevious_property_change): New forward static decl.
2590 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2591 Now internal.
2592 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2593 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2594
785bbd42
PE
2595 * editfns.c (Fformat): Remove unreachable code.
2596
8b913b57
AS
25972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2598
2599 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2600 change. (Bug#8496)
2601
a6744a35
EZ
26022011-04-13 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2605 when at ZV. (Bug#8487)
2606
e7974947
AS
26072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2608
baad03f0
AS
2609 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2610 (Bug#8437)
2611 * keyboard.c (parse_tool_bar_item): Likewise.
2612 * sound.c (sound_cleanup, alsa_close): Likewise.
2613 * termcap.c (tgetent): Likewise.
2614 * xfns.c (x_default_font_parameter): Likewise.
2615 * xsettings.c (read_and_apply_settings): Likewise.
2616
e7974947
AS
2617 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2618 (overrun_check_free): Protoize.
2619
28272684
PE
26202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2621
2622 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2623 since callers should never pass a negative size.
2624 Change the signature to match that of plain 'read' and 'write'; see
2625 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2626 * lisp.h: Update prototypes of emacs_write and emacs_read.
2627
11997c76
EZ
26282011-04-11 Eli Zaretskii <eliz@gnu.org>
2629
2630 * xdisp.c (redisplay_window): Don't try to determine the character
2631 position of the scroll margin if the window start point w->startp
e896f03c 2632 is outside the buffer's accessible region. (Bug#8468)
11997c76 2633
8a2cbd72
EZ
26342011-04-10 Eli Zaretskii <eliz@gnu.org>
2635
2636 Fix write-region and its subroutines for buffers > 2GB.
2637 * fileio.c (a_write, e_write): Modify declaration of arguments and
2638 local variables to support buffers larger than 2GB.
2639 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2640
2641 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2642 argument, local variables, and return value.
2643
2644 * lisp.h: Update prototypes of emacs_write and emacs_read.
2645
2646 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2647
4073e537 26482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2649
1ebfdcb6
PE
2650 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2651
b2ded58d
PE
2652 Fix more problems found by GCC 4.6.0's static checks.
2653
7d66342c
PE
2654 * xdisp.c (vmessage): Use a better test for character truncation.
2655
bbf47d44
PE
2656 * charset.c (load_charset_map): <, not <=, for optimization,
2657 and to avoid potential problems with integer overflow.
9248994d 2658 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2659 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2660 * editfns.c (Fformat): Likewise.
1e69125e 2661 * syntax.c (skip_chars): Likewise.
3befa583 2662
e3019616
PE
2663 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2664 This also lets GCC 4.6.0 generate slightly better loop code.
2665
becfa255
PE
2666 * callint.c (Fcall_interactively): <, not <=, for optimization.
2667 (Fcall_interactively): Count the number of arguments produced,
2668 not the number of arguments given. This is simpler and lets GCC
2669 4.6.0 generate slightly better code.
2670
dae0cd48
PE
2671 * ftfont.c: Distingish more carefully between FcChar8 and char.
2672 The previous code passed unsigned char * to a functions like
2673 strlen and xstrcasecmp that expect char *, which does not
2674 conform to the C standard.
2675 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2676 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2677 char * when the C standard requires it.
2678
76032d70
PE
2679 * keyboard.c (read_char): Remove unused var.
2680
eb3f1cc8
PE
2681 * eval.c: Port to Windows vsnprintf (Bug#8435).
2682 Include <limits.h>.
2683 (SIZE_MAX): Define if the headers do not.
2684 (verror): Do not give up if vsnprintf returns a negative count.
2685 Instead, grow the buffer. This ports to Windows vsnprintf, which
2686 does not conform to C99. Problem reported by Eli Zaretskii.
2687 Also, simplify the allocation scheme, by avoiding the need for
2688 calling realloc, and removing the ALLOCATED variable.
2689
70476b54
PE
2690 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2691
12020a9e
PE
2692 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2693 But keep the doprint source code for now, as we might revamp it
2694 and use it again (Bug#8435).
ea6c7ae6
PE
2695 * lisp.h (doprnt): Remove.
2696 * Makefile.in (base_obj): Remove doprnt.o.
2697 * deps.mk (doprnt.o): Remove.
2698
5fdb398c
PE
2699 error: Print 32- and 64-bit integers portably (Bug#8435).
2700 Without this change, on typical 64-bit hosts error ("...%d...", N)
2701 was used to print both 32- and 64-bit integers N, which relied on
2702 undefined behavior.
2703 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2704 New macro.
2705 * lisp.h (error, verror): Mark as printf-like functions.
2706 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2707 Report overflow in size calculations when allocating printf buffer.
2708 Do not truncate output string at its first null byte.
2709 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2710 Truncate the output at a character boundary, since vsnprintf does not
2711 do that.
2712 * charset.c (check_iso_charset_parameter): Convert internal
2713 character to string before calling 'error', since %c now has the
2714 printf meaning.
2715 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2716 overflow when computing char to be passed to 'error'. Do not
2717 pass Lisp_Object to 'error'; pass the integer instead.
2718 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2719 formatted with plain %d.
2720
b189fa66
PE
2721 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2722
bff87ef0
PE
2723 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2724
7e2cac20
PE
2725 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2726
ce4d90b5
PE
2727 * xterm.c (x_catch_errors): Remove duplicate declaration.
2728
266c9547
PE
2729 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2730
79c49ad2
PE
2731 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2732
368f4090
JM
27332011-04-10 Jim Meyering <meyering@redhat.com>
2734
2735 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2736 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2737 return ssize_t not "int", and use size_t as the buffer length.
2738 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2739 * gnutls.h: Update declarations.
2740 * process.c (read_process_output): Use ssize_t, to match.
2741 (send_process): Likewise.
2742
a32d4040
CY
27432011-04-09 Chong Yidong <cyd@stupidchicken.com>
2744
2745 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2746
8546720e 27472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2748
04f2d78b
CB
2749 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2750 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2751
8546720e
GM
2752 * xterm.c (handle_one_xevent):
2753 * xmenu.c (create_and_show_popup_menu):
2754 * xselect.c (x_decline_selection_request)
2755 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2756
0a2f5c1a 27572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2758
2759 Fix some uses of `int' instead of EMACS_INT.
2760 * search.c (string_match_1, fast_string_match)
2761 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2762 (scan_buffer, find_next_newline_no_quit)
2763 (find_before_next_newline, search_command, Freplace_match)
2764 (Fmatch_data): Make some `int' variables be EMACS_INT.
2765
2766 * xdisp.c (display_count_lines): 3rd argument and return value now
2767 EMACS_INT. All callers changed.
2768 (pint2hrstr): Last argument is now EMACS_INT.
2769
2770 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2771 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2772 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2773 (decode_coding_utf_16, decode_coding_emacs_mule)
2774 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2775 (decode_coding_ccl, decode_coding_charset)
2776 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2777 (decode_coding_iso_2022, decode_coding_emacs_mule)
2778 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2779 <char_offset, last_offset>: Declare EMACS_INT.
2780 (encode_coding_utf_8, encode_coding_utf_16)
2781 (encode_coding_emacs_mule, encode_invocation_designation)
2782 (encode_designation_at_bol, encode_coding_iso_2022)
2783 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2784 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2785 Declare EMACS_INT.
2786 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2787 (encode_invocation_designation): Last argument P_NCHARS is now
2788 EMACS_INT.
2789 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2790 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2791
2792 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2793 All users changed.
2794
2795 * ccl.c (Fccl_execute_on_string): Declare some variables
2796 EMACS_INT.
2797
8546720e 27982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2799
2800 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2801
4e19a977
CS
28022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2803
2804 * process.c (Fformat_network_address): Doc fix.
2805
87302331
R
28062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2807
2808 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2809
cbb59342
CY
28102011-04-08 Chong Yidong <cyd@stupidchicken.com>
2811
2812 * keyboard.c (read_char): Call Lisp function help-form-show,
2813 instead of using internal_with_output_to_temp_buffer.
2814 (Qhelp_form_show): New var.
e0d38eeb 2815 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2816
2817 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2818
2819 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2820
e67a13ab
CY
28212011-04-06 Chong Yidong <cyd@stupidchicken.com>
2822
04f2d78b
CB
2823 * process.c (Flist_processes): Remove to Lisp.
2824 (list_processes_1): Delete.
e67a13ab 2825
973f782d
EZ
28262011-04-06 Eli Zaretskii <eliz@gnu.org>
2827
7c106b1e
EZ
2828 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2829
973f782d
EZ
2830 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2831
41cf7d1a 28322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2833
ca23cc88
PE
2834 Fix more problems found by GCC 4.6.0's static checks.
2835
f390e2d5
PE
2836 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2837
42eea0d0
PE
2838 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2839
b69769da 2840 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2841
f9541e84
PE
2842 * xdisp.c (vmessage): Mark as a printf-like function.
2843
13841b55
PE
2844 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2845
c136c10f
PE
2846 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2847
5e2d4a30
PE
2848 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2849 printf-like functions.
2850 (tiff_load): Add casts to remove these marks before passing them
2851 to system-supplied API.
2852
583f48b9
PE
2853 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2854
b25d760e
PE
2855 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2856 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2857 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2858 directly, rather than having caller test rule sign. This avoids
2859 some unnecessary tests.
2860 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2861 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2862 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2863
bc7b6697 2864 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2865 (xfont_open): Avoid unnecessary tests.
bc7b6697 2866
27ccc379
PE
2867 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2868
dcd5c89a
PE
2869 * composite.h, composite.c (composition_gstring_put_cache):
2870 Use EMACS_INT, not int, for length.
2871
b13a45c6
PE
2872 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2873 breaking out part of COMPOSITION_DECODE_RULE.
2874 (COMPOSITION_DECODE_RULE): Use it.
2875 * composite.c (get_composition_id): Remove unused local vars,
2876 by using the new macro.
2877
1e792e4d
PE
2878 * textprop.c (set_text_properties_1): Change while to do-while,
2879 since the condition is always true at first.
2880
dc6c6455 2881 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2882 (interval_deletion_adjustment): Return unsigned value.
2883 All uses changed.
dc6c6455 2884
aba7731a
PE
2885 * process.c (list_processes_1, create_pty, read_process_output):
2886 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2887 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2888 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2889 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2890 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2891
fdfc4bf3
PE
2892 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2893
fca8fe46 2894 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2895 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2896
06a0259a 2897 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2898 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2899 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2900
e7b9e80f
PE
2901 * print.c (print_error_message): Avoid int overflow.
2902
56201685
PE
2903 * font.c (font_list_entities): Redo for clarity,
2904 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2905
78834453 2906 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2907 (font_score): Avoid potential overflow in diff calculation.
78834453 2908
0bc0b309 2909 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2910 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2911
e610eaca
PE
2912 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2913
b895abce
PE
2914 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2915 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2916 can always succeed if overflow has undefined behavior.
2917
1f1d9321 2918 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2919 (wordify): Omit three unnecessary tests.
1f1d9321 2920
c59478bc
PE
2921 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2922 All callers changed. This avoids the need for an unused var.
2923
79b73827
PE
2924 * casefiddle.c (casify_region): Remove var that is set but not used.
2925
a4db5dfe
PE
2926 * dired.c (file_name_completion): Remove var that is set but not used.
2927
43aae36e
PE
2928 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2929
2a47c44d 2930 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2931 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2932
a37c69bf
PE
2933 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2934 Check for integer overflow on size calculations.
2935
328ab8e7
PE
2936 * buffer.c (Fprevious_overlay_change): Remove var that is set
2937 but not used.
2938
e5a2a5cb
PE
2939 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2940 Remove vars that are set but not used.
8d84a6eb 2941 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2942 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2943
a60e5f68
PE
2944 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2945
f661cb61 2946 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2947 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2948
f0397f5a
PE
2949 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2950 that are set but not used.
2951
8664db06 2952 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2953 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2954
6abdaa4a
PE
2955 * xselect.c (x_get_local_selection, x_handle_property_notify):
2956 Remove vars that are set but not used.
2957
0ce7538d 2958 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2959 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2960
9ae848fc
PE
2961 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2962 Remove var that is set but not used.
0b918413
PE
2963 (scroll_bar_windows_size): Now size_t, not int.
2964 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2965 Check for overflow.
9ae848fc 2966
a5a62657
PE
2967 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2968 (map_tty_color) [!defined MSDOS]: Likewise.
2969
5c5cdd39
PE
2970 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2971
66ebf983
PE
2972 * coding.c: Remove vars that are set but not used.
2973 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2974 All callers changed.
2975 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2976 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2977 (decode_coding_charset): Remove vars that are set but not used.
2978
1be4d761
PE
2979 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2980 that is set but not used.
2981
47553fa8
PE
2982 * print.c (print_object): Remove var that is set but not used.
2983
1f7196bf 2984 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2985 The gnulib version avoids calling malloc in the usual case,
2986 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2987 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2988 * filelock.c (current_lock_owner): Likewise.
2989 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2990 * sysdep.c: Include allocator.h, careadlinkat.h.
2991 (emacs_no_realloc_allocator): New static constant.
2992 (emacs_readlink): New function.
fdb61804
PE
2993 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2994 ../lib/careadlinkat.h.
d1fdcab7 2995
f84c17c7
SM
29962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2997
2998 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2999 first non-nil return value).
3000
ef3862ad
JD
30012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3002
3003 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3004 if not defined (Bug#8403).
3005
376a7006
JB
30062011-04-02 Juanma Barranquero <lekktu@gmail.com>
3007
3008 * xdisp.c (display_count_lines): Remove parameter `start',
3009 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3010 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3011 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3012 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3013 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3014 and thereabouts. All callers changed.
3015 (get_per_char_metric): Remove parameter `f', unused since
3016 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3017
6ca3801d
JM
30182011-04-02 Jim Meyering <meyering@redhat.com>
3019
3020 do not dereference NULL upon failed strdup
3021 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3022 (ns_get_family): Likewise.
3023
d8e2b5ba
JB
30242011-04-02 Juanma Barranquero <lekktu@gmail.com>
3025
3026 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3027
8c74fcbd
JD
30282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3029
3030 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3031 later (Bug#8403).
3032
7200d79c
SM
30332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3034
03408648 3035 Add lexical binding.
7200d79c 3036
03408648
SM
3037 * window.c (Ftemp_output_buffer_show): New fun.
3038 (Fsave_window_excursion):
3039 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3040
3041 * lread.c (lisp_file_lexically_bound_p): New function.
3042 (Fload): Bind Qlexical_binding.
3043 (readevalloop): Remove `evalfun' arg.
3044 Bind Qinternal_interpreter_environment.
3045 (Feval_buffer): Bind Qlexical_binding.
3046 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3047 Mark as dynamic.
3048 (syms_of_lread): Declare `lexical-binding'.
3049
3050 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3051
3052 * keyboard.c (eval_dyn): New fun.
3053 (menu_item_eval_property): Use it.
ca105506
SM
3054
3055 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3056
03408648
SM
3057 * fns.c (concat, mapcar1): Accept byte-code-functions.
3058
3059 * eval.c (Fsetq): Handle lexical vars.
3060 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3061 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3062 (FletX, Flet): Obey lexical binding.
3063 (Fcommandp): Handle closures.
3064 (Feval): New `lexical' arg.
3065 (eval_sub): New function extracted from Feval. Use it almost
3066 everywhere where Feval was used. Look up vars in lexical env.
3067 Handle closures.
3068 (Ffunctionp): Move from subr.el.
3069 (Ffuncall): Handle closures.
3070 (apply_lambda): Remove `eval_flags'.
3071 (funcall_lambda): Handle closures and new byte-code-functions.
3072 (Fspecial_variable_p): New function.
3073 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3074 but without exporting it to Lisp.
23aba0ea 3075
23aba0ea 3076 * doc.c (Fdocumentation, store_function_docstring):
03408648 3077 * data.c (Finteractive_form): Handle closures.
23aba0ea 3078
03408648
SM
3079 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3080 interactive spec.
ba83908c 3081
04f2d78b
CB
3082 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3083 New byte-codes.
03408648
SM
3084 (exec_byte_code): New function extracted from Fbyte_code to handle new
3085 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3086
03408648 3087 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3088
03408648 3089 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3090
e2abce01
JB
30912011-03-31 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * xdisp.c (redisplay_internal): Fix prototype.
3094
63696a73 30952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3096
63696a73 3097 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3098 (try_scrolling): Use it when setting scroll_limit.
3099 Limit scrolling to 100 screen lines.
63696a73
EZ
3100 (redisplay_window): Even when falling back on "recentering",
3101 position point in the window according to scroll-conservatively,
3102 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3103
3104 (try_scrolling): When point is above the window, allow searching
3105 as far as scroll_max, or one screenful, to compute vertical
3106 distance from PT to the scroll margin position. This prevents
3107 try_scrolling from unnecessarily failing when
3108 scroll-conservatively is set to a value slightly larger than the
3109 window height. Clean up the case of PT below the margin at bottom
3110 of window: scroll_max can no longer be INT_MAX. When aggressive
3111 scrolling is in use, don't let point enter the opposite scroll
3112 margin as result of the scroll.
3113 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3114 threshold of 100 lines for never-recentering scrolling.
3115
e4cc2dfc
JB
31162011-03-31 Juanma Barranquero <lekktu@gmail.com>
3117
3118 * dispextern.h (move_it_by_lines):
3119 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3120 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3121 (message_log_check_duplicate): Remove parameters `prev_bol' and
3122 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3123 (redisplay_internal): Remove parameter `preserve_echo_area',
3124 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3125
3126 * indent.c (Fvertical_motion):
3127 * window.c (window_scroll_pixel_based, Frecenter):
3128 Don't pass `need_y_p' to `move_it_by_lines'.
3129
1c470562
SM
31302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3131
44f230aa
SM
3132 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3133 steal a few bits to be more compact.
3134 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3135 Remove unneeded casts.
3136
1c470562
SM
3137 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3138
888adce9
ZK
31392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3140
3141 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3142 binding" message (bug#7967).
3143
f838ed7b
PE
31442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3145
77861b95
PE
3146 Fix more problems found by GCC 4.6.0's static checks.
3147
de6dbc14
PE
3148 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3149 Remove unused local var.
3150
f838ed7b
PE
3151 * editfns.c (Fmessage_box): Remove unused local var.
3152
792c7b2b
PE
3153 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3154 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3155 Omit unused local vars.
c499e557 3156 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3157 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3158 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3159 Omit unused local var.
3160
ba0165e1
PE
3161 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3162 Don't assume string length fits in int.
32ad8845 3163 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3164 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3165
3c59b4c9
PE
3166 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3167 instead of alloca (Bug#8344).
3168
a3eed478 3169 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3170 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3171
eb4d412d
PE
3172 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3173
1658b401
PE
3174 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3175 concerns.
3176
3177 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3178
3179 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3180
9a2c6e05
PE
3181 * keyboard.c (syms_of_keyboard): Use the same style as later
3182 in this function when indexing through an array. This also
3183 works around GCC bug 48267.
3184
03d0a109
PE
3185 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3186
44f730c8
PE
3187 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3188
fe75f926
PE
3189 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3190 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3191
ffa8c828
PE
3192 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3193 This avoids undefined behavior on integer overflow, and is a bit
3194 more convenient anyway since it is compared to a size_t variable.
3195
c5101a77
PE
3196 Variadic C functions now count arguments with size_t, not int.
3197 This avoids an unnecessary limitation on 64-bit machines, which
3198 caused (substring ...) to crash on large vectors (Bug#8344).
3199 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3200 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3201 All variadic functions and their callers changed accordingly.
c5101a77
PE
3202 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3203 * data.c (arith_driver, float_arith_driver): Likewise.
3204 * editfns.c (general_insert_function): Likewise.
3205 * eval.c (struct backtrace.nargs, interactive_p)
3206 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3207 (funcall_lambda, mark_backtrace): Likewise.
3208 * fns.c (concat): Likewise.
3209 * frame.c (x_set_frame_parameters): Likewise.
3210 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3211 0 if not found, not -1. All callers changed.
3212
dd3f25f7
PE
3213 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3214 (stack_copy_size): Now size_t, not int.
3215 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3216
461c2ab9
JB
32172011-03-28 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3220 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3221 All callers changed.
3222
3223 * lisp.h (multibyte_char_to_unibyte):
3224 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3225 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3226 * character.h (CHAR_TO_BYTE8):
3227 * cmds.c (internal_self_insert):
3228 * editfns.c (general_insert_function):
3229 * keymap.c (push_key_description):
3230 * search.c (Freplace_match):
3231 * xdisp.c (message_dolog, set_message_1): All callers changed.
3232
f6d62986
SM
32332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3234
3235 * keyboard.c (safe_run_hook_funcall): New function.
3236 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3237 don't set the hook to nil, but remove the offending function instead.
3238 (Qcommand_hook_internal): Remove, unused.
3239 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3240 Vcommand_hook_internal.
3241
3242 * eval.c (enum run_hooks_condition): Remove.
3243 (funcall_nil, funcall_not): New functions.
3244 (run_hook_with_args): Call each function through a `funcall' argument.
3245 Remove `cond' argument, now redundant.
3246 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3247 (Frun_hook_with_args_until_failure): Adjust accordingly.
3248 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3249
1db5b1ad
JB
32502011-03-28 Juanma Barranquero <lekktu@gmail.com>
3251
3252 * dispextern.h (string_buffer_position): Remove declaration.
3253
3254 * print.c (strout): Remove parameter `multibyte', unused since
3255 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3256
3257 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3258 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3259 All callers changed.
3260
3261 * w32.c (_wsa_errlist): Use braces for struct initializers.
3262
3263 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3264 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3265 All callers changed.
3266 (string_buffer_position): Likewise. Also, make static (it's never
3267 used outside xdisp.c).
3268 (cursor_row_p): Remove parameter `w', unused since
3269 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3270 (decode_mode_spec): Remove parameter `precision', introduced during
3271 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3272 All callers changed.
3273
5ffb62aa
JD
32742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3275
3276 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3277
461c2ab9 32782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3279
3280 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3281 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3282 (ns_update_auto_hide_menu_bar): New functions.
3283 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3284 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3285 ns_constrain_all_frames.
3286 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3287 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3288
5c380ffb
JD
32892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3292
9af30bdf
GM
32932011-03-27 Glenn Morris <rgm@gnu.org>
3294
3295 * syssignal.h: Replace RETSIGTYPE with void.
3296 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3297 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3298 Replace SIGTYPE with void everywhere.
3299 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3300 * s/template.h (SIGTYPE): Remove commented out definition.
3301
e2abce01
JB
33022011-03-26 Eli Zaretskii <eliz@gnu.org>
3303
3304 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3305 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3306
f868cd8a
JB
33072011-03-26 Juanma Barranquero <lekktu@gmail.com>
3308
59eb0929
JB
3309 * w32.c (read_unc_volume): Use parameter `henum', instead of
3310 global variable `wget_enum_handle'.
3311
3312 * keymap.c (describe_vector): Remove parameters `indices' and
3313 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3314 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3315
f868cd8a
JB
3316 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3317
3318 * keyboard.c (timer_check): Remove parameter `do_it_now',
3319 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3320 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3321 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3322
3323 * keyboard.c (read_char):
3324 * w32menu.c (w32_menu_display_help):
3325 * xmenu.c (show_help_event, menu_help_callback):
3326 Adjust calls to `show_help_echo'.
3327
3328 * gtkutil.c (xg_maybe_add_timer):
3329 * keyboard.c (readable_events):
3330 * process.c (wait_reading_process_output):
3331 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3332
3333 * insdel.c (adjust_markers_gap_motion):
3334 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3335 (gap_left, gap_right): Don't call it.
3336
2ecf6fdb
CY
33372011-03-25 Chong Yidong <cyd@stupidchicken.com>
3338
3339 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3340 incurred during fontification.
3341
6b1f9ba4
JB
33422011-03-25 Juanma Barranquero <lekktu@gmail.com>
3343
3344 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3345 (DEFVAR_PER_BUFFER): Don't pass it.
3346
3347 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3348 (scrolling_window): Don't pass it.
3349
0f4a96b5
JB
33502011-03-25 Juanma Barranquero <lekktu@gmail.com>
3351
3352 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3353
3354 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3355 and `suffix'.
3356 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3357 of variables specific to SELinux and computation of `encoded_absname'.
3358
3359 * image.c (XPutPixel): Remove unused variable `height'.
3360
3361 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3362
3363 * unexw32.c (get_section_info): Remove unused variable `section'.
3364
3365 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3366 (system_process_attributes): Remove unused variable `sess'.
3367 (sys_read): Remove unused variable `err'.
3368
3369 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3370 (w32_wnd_proc): Remove unused variable `isdead'.
3371 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3372 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3373 (x_create_tip_frame): Remove unused variable `tem'.
3374
3375 * w32inevt.c (w32_console_read_socket):
3376 Remove unused variable `no_events'.
3377
3378 * w32term.c (x_draw_composite_glyph_string_foreground):
3379 Remove unused variable `width'.
3380
1149507c
JB
33812011-03-24 Juanma Barranquero <lekktu@gmail.com>
3382
3383 * w32term.c (x_set_glyph_string_clipping):
3384 Don't pass uninitialized region to CombineRgn.
3385
9c88f339
JB
33862011-03-23 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3389 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3390 (Fx_close_connection): Remove unused variable `i'.
3391
3392 * w32font.c (w32font_draw): Return number of glyphs.
3393 (w32font_open_internal): Remove unused variable `i'.
3394 (w32font_driver): Add missing initializer.
3395
3396 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3397 (fill_in_menu): Remove unused variable `items_added'.
3398
3399 * w32term.c (last_mouse_press_frame): Remove static global variable.
3400 (w32_clip_to_row): Remove unused variable `f'.
3401 (x_delete_terminal): Remove unused variable `i'.
3402
3403 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3404 (NOTHING): Remove unused static global variable.
3405 (uniscribe_check_otf): Remove unused variable `table'.
3406 (uniscribe_font_driver): Add missing initializers.
3407
dee091a3
JD
34082011-03-23 Julien Danjou <julien@danjou.info>
3409
3410 * term.c (Fsuspend_tty, Fresume_tty):
3411 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3412 * window.c (temp_output_buffer_show):
3413 * insdel.c (signal_before_change):
3414 * frame.c (Fhandle_switch_frame):
3415 * fileio.c (Fdo_auto_save):
3416 * emacs.c (Fkill_emacs):
3417 * editfns.c (save_excursion_restore):
3418 * cmds.c (internal_self_insert):
3419 * callint.c (Fcall_interactively):
3420 * buffer.c (Fkill_all_local_variables):
3421 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3422 Use Frun_hooks.
0f4a96b5 3423 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3424 unconditionnaly since it does the check itself.
3425
2c520ab5 34262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3427
c9c49752
PE
3428 Fix more problems found by GCC 4.5.2's static checks.
3429
8abc3f12
PE
3430 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3431 the first time through the loop, since we know p0 < p1 then.
3432 This also avoids a gcc -Wstrict-overflow warning.
3433
a2d26660
PE
3434 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3435 leading to a memory leak, possible in functions like
3436 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3437 of objects (Bug#8318).
a2d26660 3438
916c72e9
PE
3439 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3440 that could (at least in theory) be that large.
3441
19ab8a18
PE
3442 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3443 This is less likely to overflow, and avoids undefined behavior if
3444 overflow does occur. All callers changed. Use strtoul to scan
3445 for the unsigned long integer.
b7cbbd6f
PE
3446 (pint2hrstr): Simplify and tune code slightly.
3447 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3448
f0641eff
PE
3449 * scroll.c (do_scrolling): Work around GCC bug 48228.
3450 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3451
7f650bb9
PE
3452 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3453 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3454 (validate_x_resource_name): Simplify count usage.
3455 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3456
37dd57d1
PE
3457 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3458 fail (Bug#8306).
81e56e61 3459
699979fc 3460 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3461
401bf9b4
PE
3462 * process.c (Fmake_network_process): Use socklen_t, not int,
3463 where POSIX says socklen_t is required in portable programs.
3464 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3465 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3466 (Fmake_network_process, server_accept_connection):
3467 (wait_reading_process_output, read_process_output):
3468 Likewise.
3469
b93aacde
PE
3470 * process.c: Rename or move locals to avoid shadowing.
3471 (list_processes_1, Fmake_network_process):
3472 (read_process_output_error_handler, exec_sentinel_error_handler):
3473 Rename or move locals.
4dc343ee 3474 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3475 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3476 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3477 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3478 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3479
af8a867c 3480 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3481 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3482 Include tparam.h instead, since it declares them.
af8a867c
PE
3483 * cm.h (PC): Remove extern decl; tparam.h now does this.
3484 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3485 * terminfo.c: Include tparam.h, to check interfaces.
3486 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3487 (tparam): Adjust signature to match interface in tparam.h;
3488 this removes some undefined behavior. Check that outstring and len
3489 are zero, which they always are with Emacs.
3490 * tparam.h (PC, BC, UP): New extern decls.
3491
0248044d 3492 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3493 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3494
8ff096c1 3495 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3496 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3497 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3498 (ftfont_list): Remove unused local.
49eaafba
PE
3499 (get_adstyle_property, ftfont_pattern_entity):
3500 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3501 Rename locals to avoid shadowing.
8ff096c1 3502
e2be39f6
PE
3503 * xfont.c (xfont_list_family): Mark var as initialized.
3504
c9735e30
PE
3505 * xml.c (make_dom): Now static.
3506
8f5201ae
PE
3507 * composite.c (composition_compute_stop_pos): Rename local to
3508 avoid shadowing.
b246f932
PE
3509 (composition_reseat_it): Remove unused locals.
3510 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3511 (composition_update_it): Mark var as initialized.
11b61122
PE
3512 (find_automatic_composition): Mark vars as initialized,
3513 with a FIXME (Bug#8290).
8f5201ae 3514
760fbc2c
PE
3515 character.h: Rename locals to avoid shadowing.
3516 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3517 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3518 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3519 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3520 to avoid shadowing.
3521
ff08eb85
PE
3522 * textprop.c (property_change_between_p): Remove; unused.
3523
fc7bf025
PE
3524 * intervals.c (interval_start_pos): Now static.
3525
235d7abc
PE
3526 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3527
44f230aa
SM
3528 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3529 Rename locals to avoid shadowing.
3e7d6594 3530
50060332
PE
3531 * sound.c (wav_play, au_play, Fplay_sound_internal):
3532 Fix pointer signedness.
d01f234b 3533 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3534 (wav_play): Initialize a variable to 0, to prevent undefined
3535 behavior (Bug#8278).
50060332 3536
c4fc4e30
PE
3537 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3538
918436ed
PE
3539 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3540
c939f91b
PE
3541 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3542 clobbering (Bug#8298).
b9c7f648
PE
3543 * sysdep.c (sys_subshell): Likewise.
3544 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3545
6bd8c144
PE
3546 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3547 This should get cleaned up, so that child_setup has the
3548 same signature on all platforms.
3549
7710357c 3550 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3551 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3552
c59da222
CY
35532011-03-22 Chong Yidong <cyd@stupidchicken.com>
3554
3555 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3556 not to be necessary, and produces flickering.
3557
66b87493
GM
35582011-03-20 Glenn Morris <rgm@gnu.org>
3559
3560 * config.in: Remove file.
3561
45b6f6d5
JB
35622011-03-20 Juanma Barranquero <lekktu@gmail.com>
3563
3564 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3565 are now in src/globals.h.
3566 (syms_of_minibuf): Remove spurious & from previous change.
3567
3ec03f7e
LL
35682011-03-20 Leo <sdl.web@gmail.com>
3569
3570 * minibuf.c (completing-read-function): New variable.
3571 (completing-read-default): Rename from completing-read.
3572 (completing-read): Call completing-read-function.
3573
b14e3e21
CY
35742011-03-19 Juanma Barranquero <lekktu@gmail.com>
3575
3576 * xfaces.c (Fx_load_color_file):
3577 Read color file from absolute filename (bug#8250).
3578
f2b726e6
JB
35792011-03-19 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * makefile.w32-in: Update dependencies.
3582
09f6ff02
EZ
35832011-03-17 Eli Zaretskii <eliz@gnu.org>
3584
3585 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3586
29a6015a
PE
35872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3588
a3a6c54e
PE
3589 Fix more problems found by GCC 4.5.2's static checks.
3590
b766f867
PE
3591 * process.c (make_serial_process_unwind, send_process_trap):
3592 (sigchld_handler): Now static.
3593
be02381c
PE
3594 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3595 That way, the code declares only the vars that it needs.
3596 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3597 * s/cygwin.h (PTY_ITERATION): Likewise.
3598 * s/darwin.h (PTY_ITERATION): Likewise.
3599 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3600
57048744
PE
3601 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3602 * process.c (allocate_pty): Don't declare stb unless it's needed.
3603
7914961c 3604 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3605 (CONSTANTLIM): Remove; unused.
3606 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3607 Define only if needed.
7914961c 3608
b3967b18
PE
3609 * unexelf.c (unexec): Name an expression,
3610 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3611 Use a different way to cause a compilation error if anyone uses
3612 n rather than nn, a way that does not involve shadowing.
73366a00 3613 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3614
29a6015a
PE
3615 * deps.mk (unexalpha.o): Remove; unused.
3616
43cfc33e 3617 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3618 * unexec.h: New file.
ce701a33
PE
3619 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3620 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3621 Depend on unexec.h.
3622 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3623 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3624 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3625 Change as necessary to match prototype in unexec.h.
ce701a33 3626
01f44d5a
PE
3627 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3628 shadowing.
4f63c6bb 3629 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3630
a6670b0b
PE
3631 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3632 Rename locals to avoid shadowing.
3633
cef2010d 3634 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3635 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3636
d4d7173a
PE
3637 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3638
f08b802a
PE
3639 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3640 warning when compiling print.c.
3641
3ddb0639
PE
3642 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3643 instead of using an uninitialized var.
5ad03b97 3644 (font_sort_entities): Mark var as initialized.
3ddb0639 3645
170a2692
PE
3646 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3647
e663c700
PE
3648 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3649 pointers to constants.
89bc529a 3650 (font_parse_fcname): Remove unused vars.
7b81e2d0 3651 (font_delete_unmatched): Now static.
ea838e10 3652 (font_get_spec): Remove; unused.
13a547c6
PE
3653 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3654 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3655 Rename or move locals to avoid shadowing.
e663c700 3656
2a80c887 3657 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3658 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3659
1384fa33 3660 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3661 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3662
8b2c52e9
PE
3663 * alloc.c (mark_backtrace): Move decl from here ...
3664 * lisp.h: ... to here, so that it can be checked.
3665
475545b5 3666 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3667 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3668 (lisp_indirect_variable): Name an expression,
3669 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3670 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3671
b1349114 3672 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3673 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3674 Use const pointer when appropriate.
b1349114 3675
a2928364
PE
3676 * lisp.h (get_system_name, get_operating_system_release):
3677 Move decls here, to check interfaces.
3678 * process.c (get_operating_system_release): Move decl to lisp.h.
3679 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3680 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3681 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3682 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3683 (Fformat_time_string, Fencode_time, Finsert_char):
3684 (Ftranslate_region_internal, Fformat):
3685 Rename or remove local vars to avoid shadowing.
9710023e 3686 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3687
a415e694
PE
3688 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3689 avoid shadowing.
3690
8ef4622d
PE
3691 * lisp.h (eassert): Check that the argument compiles, even if
3692 ENABLE_CHECKING is not defined.
3693
946f9a5b
PE
3694 * data.c (Findirect_variable): Name an expression, to avoid
3695 gcc -Wbad-function-cast warning.
112396d6 3696 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3697 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3698 (Fmake_variable_buffer_local, Fmake_local_variable):
3699 Mark variables as initialized.
52746918 3700 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3701
e5aab7e7 3702 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3703 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3704 Rename locals to avoid shadowing.
dff45157
PE
3705 (mark_stack): Move local variables into the #ifdef region where
3706 they're used.
7bc26fdb
PE
3707 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3708 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3709 needed otherwise.
3710 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3711 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3712 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3713
e5aab7e7
PE
3714 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3715 avoids undefined behavior in theory.
3716
4da60324
PE
3717 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3718
88043301
PE
3719 Use functions, not macros, for up- and down-casing (Bug#8254).
3720 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3721 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3722 to use the following functions instead of these macros.
3723 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3724 EMACS_INT, since callers assume the returned value fits in int.
3725 (upcase1): Likewise, for UPCASE_TABLE.
3726 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3727 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3728 the race-condition problem in the old DOWNCASE.
88043301 3729
19ed5445
PE
3730 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3731 Rename locals to avoid shadowing.
3732 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3733 (regex_compile, re_search_2, re_match_2_internal):
3734 Remove unused local vars.
952db0d7
PE
3735 (FREE_VAR): Rewrite so as not to use empty "else",
3736 which gcc can warn about.
da053e48 3737 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3738 (RETALLOC_IF): Define only if needed.
3739 (WORDCHAR_P): Likewise. This one is never needed, but is used
3740 only in a comment talking about a compiler bug, so put inside
3741 the #if 0 of that comment.
3742 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3743 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3744 Remove; unused.
19ed5445 3745
1f3561e4 3746 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3747 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3748 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3749
ded6f8f7
PE
3750 * search.c (simple_search): Remove unused var.
3751
dbd37a95
PE
3752 * dired.c (compile_pattern): Move decl from here ...
3753 * lisp.h: ... to here, so that it can be checked.
3754 (struct re_registers): New forward decl.
3755
7e47afad
PE
3756 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3757
85f24f61
PE
3758 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3759 All uses changed.
3760 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3761 Rename locals to avoid shadowing.
5671df8f 3762 (Fvertical_motion): Mark locals as initialized.
85f24f61 3763
181aa2be 3764 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3765 (casify_region): Mark local as initialized.
181aa2be 3766
930d429c
PE
3767 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3768
7082eac6
PE
3769 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3770 New macros, so that the caller can use some names other than
3771 gcpro1, gcpro2, etc.
3772 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3773 of the new macros.
3774 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3775 argument, for consistency with GCPRO2_VAR, etc: it is now the
3776 prefix of the variable, not the variable itself. All uses
3777 changed.
38b2c076
PE
3778 * dired.c (directory_files_internal, file_name_completion):
3779 Rename locals to avoid shadowing.
3780
15206ed9
PE
3781 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3782 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3783 dired.c's scmp function, had undefined behavior.
3784 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3785 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3786 * buffer.h: ... to here, because these macros use current_buffer,
3787 and the new implementation with inline functions needs to have
3788 current_buffer in scope now, rather than later when the macros
3789 are used.
3790 (downcase, upcase1): New static inline functions.
3791 (DOWNCASE, UPCASE1): Reimplement using these functions.
3792 This avoids undefined behavior in expressions like
3793 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3794 from race conditions in accessing the global variables
3795 case_temp1 and case_temp2.
3796 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3797 * lisp.h (case_temp1, case_temp2): Remove their decls.
3798 * character.h (ASCII_CHAR_P): Move from here ...
3799 * lisp.h: ... to here, so that the inline functions mentioned
3800 above can use them.
3801
4a6bea26
PE
3802 * dired.c (directory_files_internal_unwind): Now static.
3803
f14b7e14
PE
3804 * fileio.c (file_name_as_directory, directory_file_name):
3805 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3806 Now static.
2893f146
PE
3807 (file_name_as_directory): Use const pointers when appropriate.
3808 (Fexpand_file_name): Likewise. In particular, newdir might
3809 point at constant storage, so make it a const pointer.
fd4ead52 3810 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3811 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3812 signedness issues.
f839df0c
PE
3813 (Fset_file_times, Finsert_file_contents, auto_save_error):
3814 Rename locals to avoid shadowing.
f14b7e14 3815
5716756e 3816 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3817 (Ftry_completion, Fall_completions): Rename or remove locals
3818 to avoid shadowing.
5716756e 3819
b4c3046a
PE
3820 * marker.c (bytepos_to_charpos): Remove; unused.
3821
b45db522
PE
3822 * lisp.h (verify_bytepos, count_markers): New decls,
3823 so that gcc does not warn that these functions aren't declared.
3824
85876d07
PE
3825 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3826 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3827 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3828 (copy_text): Remove unused local var.
85876d07 3829
03d78a21 3830 * filelock.c (within_one_second): Now static.
b3dd38ab 3831 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3832
5df8f01b
PE
3833 * buffer.c (fix_overlays_before): Mark locals as initialized.
3834 (fix_start_end_in_overlays): Likewise. This function should be
3835 simplified by using pointers-to-pointers, but that's a different
3836 matter.
b1d876f1 3837 (switch_to_buffer_1): Now static.
8f54f30a
PE
3838 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3839 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3840
a70072c9 3841 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3842 Fix pointer signedness issue.
edced198
PE
3843 (sys_subshell): Mark local as volatile if checking for lint,
3844 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3845 (MAXPATHLEN): Define only if needed.
a70072c9 3846
a0977c44
PE
3847 * process.c (serial_open, serial_configure): Move decls from here ...
3848 * systty.h: ... to here, so that they can be checked.
3849
a884fdcc
PE
3850 * fns.c (get_random, seed_random): Move extern decls from here ...
3851 * lisp.h: ... to here, so that they can be checked.
3852
604efe86 3853 * sysdep.c (reset_io): Now static.
b8950c94 3854 (wait_for_termination_signal): Remove; unused.
604efe86 3855
38fc62d9
PE
3856 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3857 (copy_keymap_item, append_key, push_text_char_description):
3858 Now static.
1004a21a 3859 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3860 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3861 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3862 (describe_map_tree):
3863 Rename locals to avoid shadowing.
38fc62d9 3864
2f2650da
PE
3865 * keyboard.c: Declare functions static if they are not used elsewhere.
3866 (echo_char, echo_dash, cmd_error, top_level_2):
3867 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3868 (read_char, kbd_buffer_get_event, make_lispy_position):
3869 (make_lispy_event, make_lispy_movement, apply_modifiers):
3870 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3871 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3872 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3873 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3874 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3875
a053e86c 3876 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3877 (mark_kboards): Move decl here ...
3878 * alloc.c (mark_kboards): ... from here.
a053e86c 3879
4752793e
PE
3880 * lisp.h (force_auto_save_soon): New decl.
3881
74f10ca7 3882 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3883 (DEFINE_DUMMY_FUNCTION): New macro.
3884 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3885 Use it.
c03cd23f
PE
3886 (main): Add casts to avoid warnings
3887 if GCC considers string literals to be constants.
74f10ca7 3888
022e70d4
PE
3889 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3890
59d6fe83
PE
3891 * dbusbind.c: Pointer signedness fixes.
3892 (xd_signature, xd_append_arg, xd_initialize):
3893 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3894 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3895 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3896 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3897
78320123
PE
3898 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3899 if GCC considers string literals to be constants.
49cebcca 3900 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3901
35ac2a97
SM
39022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3903
fb103ca9
SM
3904 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3905 (print_preprocess, print_object): New macro to fix last change.
3906
35ac2a97
SM
3907 * print.c (print_preprocess): Don't forget font objects.
3908
62973b41
JB
39092011-03-16 Juanma Barranquero <lekktu@gmail.com>
3910
3911 * emacs.c (USAGE3): Doc fixes.
3912
0e48bb22
AS
39132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3914
3915 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3916 structure.
3917
7684e57b
JB
39182011-03-14 Juanma Barranquero <lekktu@gmail.com>
3919
3920 * lisp.h (VWindow_system, Qfile_name_history):
3921 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3922 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3923 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3924
3925 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3926 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3927
3928 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3929 * w32console.c (detect_input_pending, read_input_pending)
3930 (encode_terminal_code):
3931 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3932 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3933 (w32_system_caret_y, Qfile_name_history):
3934 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3935 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3936 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3937 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3938 * w32proc.c (Qlocal, report_file_error):
3939 * w32term.c (Vwindow_system, updating_frame):
3940 * w32uniscribe.c (initialized, uniscribe_font_driver):
3941 Remove unneeded extern declarations.
3942
2aa46d6c
CY
39432011-03-14 Chong Yidong <cyd@stupidchicken.com>
3944
c96bbc66 3945 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3946
cffc6f3b
CY
39472011-03-13 Chong Yidong <cyd@stupidchicken.com>
3948
3949 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3950 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3951 These macros can no longer be used for assignment.
3952
44f230aa
SM
3953 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3954 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3955 (record_buffer_markers, fetch_buffer_markers): New functions for
3956 recording and fetching special buffer markers.
3957 (set_buffer_internal_1, set_buffer_temp): Use them.
3958
3959 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3960
3961 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3962
3963 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3964 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3965
3966 * xdisp.c (hscroll_window_tree):
3967 (reconsider_clip_changes): Use PT instead of BUF_PT.
3968
d251f04b
EZ
39692011-03-13 Eli Zaretskii <eliz@gnu.org>
3970
3971 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3972 $(EMACS_ROOT)/lib/intprops.h.
3973
f0c77cd1
PE
39742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3975
3eca4629
PE
3976 Fix more problems found by GCC 4.5.2's static checks.
3977
7c86ee98
PE
3978 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3979 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3980 (xg_free_frame_widgets): Make it clear that a local variable is
3981 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3982 (gdk_window_get_screen): Make it clear that this macro is needed
3983 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3984 (int_gtk_range_get_value): New function, which avoids a diagnostic
3985 from gcc -Wbad-function-cast.
3986 (xg_set_toolkit_scroll_bar_thumb): Use it.
3987 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3988 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3989 (get_utf8_string, xg_get_file_with_chooser):
3990 Rename locals to avoid shadowing.
3991 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3992
41729b81
PE
3993 * xgselect.c (xg_select): Remove unused var.
3994
f0c77cd1
PE
3995 * image.c (four_corners_best): Mark locals as initialized.
3996 (gif_load): Initialize transparent_p to zero (Bug#8238).
3997 Mark another local as initialized.
ec6cf4c6 3998 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3999
ce0ad53d 4000 * image.c (clear_image_cache): Now static.
d5d5a617 4001 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4002 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4003 (x_edge_detection): Remove unnecessary cast that
4004 gcc -Wbad-function-cast diagnoses.
2037898d 4005 (gif_load): Fix pointer signedness.
6ae141d6
PE
4006 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4007 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4008
33383987 40092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4010
d32df629
PE
4011 Improve quality of tests for time stamp overflow.
4012 For example, without this patch (encode-time 0 0 0 1 1
4013 1152921504606846976) returns the obviously-bogus value (-948597
4014 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4015 reports time overflow. See
4016 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4017 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4018 * editfns.c: Include limits.h and intprops.h.
4019 (TIME_T_MIN, TIME_T_MAX): New macros.
4020 (time_overflow): Move earlier, to before first use.
4021 (hi_time, lo_time): New functions, for an accurate test for
4022 out-of-range times.
4023 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4024 (Fget_internal_run_time): Don't assume time_t fits in int.
4025 (make_time): Use list2 instead of Fcons twice.
4026 (Fdecode_time): More accurate test for out-of-range times.
4027 (check_tm_member): New function.
4028 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4029 (lisp_time_argument): Don't rely on undefined left-shift and
4030 right-shift behavior when checking for time stamp overflow.
8be6f318 4031
fe31d94c
PE
4032 * editfns.c (time_overflow): New function, refactoring common code.
4033 (Fformat_time_string, Fdecode_time, Fencode_time):
4034 (Fcurrent_time_string): Use it.
4035
8be6f318
PE
4036 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4037 * dired.c (make_time): Move to ...
4038 * editfns.c (make_time): ... here.
4039 * systime.h: Note the move.
4040
09d9db2c 40412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4042
126bc0dc
YM
4043 * fringe.c (update_window_fringes): Remove unused variables.
4044
c47cbdfd
YM
4045 * unexmacosx.c (copy_data_segment): Also copy __got section.
4046 (Bug#8223)
4047
7ac80be9
EZ
40482011-03-12 Eli Zaretskii <eliz@gnu.org>
4049
c96bbc66 4050 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4051 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4052 Constify `char *' arguments and their references according to
4053 prototypes in tparam.h.
4054
ecb0f94d 4055 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4056
7ac80be9
EZ
4057 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4058 Adapt all references accordingly.
4059
4060 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4061
ef1fd07e
TT
40622011-03-11 Tom Tromey <tromey@redhat.com>
4063
4064 * buffer.c (syms_of_buffer): Remove obsolete comment.
4065
7ef4b50c
EZ
40662011-03-11 Eli Zaretskii <eliz@gnu.org>
4067
4068 * termhooks.h (encode_terminal_code): Declare prototype.
4069
4070 * msdos.c (encode_terminal_code): Don't declare prototype.
4071
4072 * term.c (encode_terminal_code): Now external again, used by
4073 w32console.c and msdos.c.
4074
44f230aa
SM
4075 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4076 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4077
4b1ec863 40782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4079
1714f52b 4080 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4081
4b1ec863
PE
4082 * fringe.c (update_window_fringes): Mark locals as initialized
4083 (Bug#8227).
4084 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4085
524c7aa6
PE
4086 * alloc.c (mark_fringe_data): Move decl from here ...
4087 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4088 to check its interface.
4089 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4090
a5c0af81 4091 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4092 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4093 (fontset_font): Mark local as initialized.
a9a06e0b 4094 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4095
b4716021
PE
4096 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4097
811e9bac 4098 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4099 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4100 (x_own_selection, Fx_disown_selection_internal): Rename locals
4101 to avoid shadowing.
4102 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4103
7e3ab302
PE
4104 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4105 so that the caller can use some name other than gcpro1.
4106 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4107 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4108 (Fx_backspace_delete_keys_p):
4109 Use them to avoid shadowing, and rename vars to avoid shadowing.
4110 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4111 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4112 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4113 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4114 Remove unused locals.
7e3ab302
PE
4115 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4116 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4117 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4118 macros.
f78faa98 4119
e2b13473
PE
4120 * xterm.h (x_mouse_leave): New decl.
4121
77f23912
PE
4122 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4123 Remove unused functions.
cdf4ba58
PE
4124 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4125 (x_calc_absolute_position): Now static.
7411c686 4126 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4127 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4128 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4129 unless they are used.
38d0b34a
PE
4130 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4131 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4132 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4133 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4134 (x_error_catcher, x_connection_closed, x_error_handler):
4135 (x_error_quitter, xembed_send_message, x_iconify_frame):
4136 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4137 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4138 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4139
44f230aa
SM
4140 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4141 Rename or move locals to avoid shadowing.
6b463e58 4142 (tty_defined_color, merge_face_heights): Now static.
5967d051 4143 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4144 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4145 does not deduce is never used uninitialized.
73719eba
PE
4146 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4147 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4148
426994c3 4149 * terminal.c (store_terminal_param): Now static.
5489860b 4150
032f1620 4151 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4152 (set_frame_menubar): Remove unused local.
d4323972 4153 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4154 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4155 since they might point to immutable storage.
281585b0
PE
4156 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4157 since it's unused otherwise.
032f1620 4158
367c19e5 4159 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4160 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4161 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4162 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4163 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4164 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4165 does not deduce are never used uninitialized.
70739cbe 4166
07b48fa9
PE
4167 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4168
8868a238 4169 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4170 * window.c (window_loop, size_window):
4171 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4172
7e5cf297 4173 * window.c (display_buffer): Now static.
d6550a9f
PE
4174 (size_window): Mark variables that gcc -Wuninitialized
4175 does not deduce are never used uninitialized.
a586633d
PE
4176 * window.h (check_all_windows): New decl, to forestall
4177 gcc -Wmissing-prototypes diagnostic.
5b555da1 4178 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4179
f6095868
PE
4180 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4181 shadowing.
4182 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4183 Include <limits.h>.
4184 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4185 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4186 (load_charset_map): Mark variables that gcc -Wuninitialized
4187 does not deduce are never used uninitialized.
53df7c11 4188 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4189
f38b440c
PE
4190 * coding.c (coding_set_source, coding_set_destination):
4191 Use "else { /* comment */ }" rather than "else /* comment */;"
4192 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4193 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4194 a block, when the outer 'i' will do.
4195 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4196 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4197 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4198 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4199 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4200 Rename locals to avoid shadowing.
4201 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4202 * coding.c (emacs_mule_char, encode_invocation_designation):
4203 Now static, since they're not used elsewhere.
413bb2db 4204 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4205 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4206 (decode_coding_emacs_mule): Mark variables that gcc
4207 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4208 (detect_coding_iso_2022): Initialize a local variable that might
4209 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4210 this initialization is needed. (Bug#8211)
5f58e762
PE
4211 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4212 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4213 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4214 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4215 Remove unused macros.
f38b440c 4216
232b38b9 4217 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4218 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4219 * character.c (string_count_byte8): Likewise.
232b38b9 4220
fb90da1b
PE
4221 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4222 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4223
fb93dbc2
PE
4224 * chartab.c (copy_sub_char_table): Now static, since it's not used
4225 elsewhere.
5c156ace
PE
4226 (sub_char_table_ref_and_range, char_table_ref_and_range):
4227 Rename locals to avoid shadowing.
bbcd0949 4228 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4229
7d3b3862 4230 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4231 (BIDI_BOB): Remove unused macro.
7d3b3862 4232
6be7d3da
PE
4233 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4234 deduce are never used uninitialized.
c2ed9c8b 4235 * term.c (encode_terminal_code): Likewise.
6be7d3da 4236
75f8807f 4237 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4238
50938595
PE
4239 * tparam.h: New file.
4240 * term.c, tparam.h: Include it.
4241 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4242 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4243 Move these decls to tparam.h, and make them agree with what
4244 is actually in tparam.c. The previous trick of using incompatible
4245 decls in different modules does not conform to the C standard.
4246 All callers of tparam changed to use tparam's actual API.
4247 * tparam.c (tparam1, tparam, tgoto):
4248 Use const pointers where appropriate.
4249
fbceeba2
PE
4250 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4251 * cm.h (struct cm): Likewise.
4252 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4253 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4254 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4255 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4256 (turn_on_face, init_tty): Likewise.
4257 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4258
7f3f1250
PE
4259 * term.c (term_mouse_position): Rename local to avoid shadowing.
4260
e6ca6543
PE
4261 * alloc.c (mark_ttys): Move decl from here ...
4262 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4263
c40f8d15
AS
42642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4265
4266 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4267
cfe0661d
JB
42682011-03-09 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * search.c (compile_pattern_1): Remove argument regp, unused since
4271 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4272 (compile_pattern): Don't pass it.
4273
0afb4571
J
42742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4275
4276 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4277 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4278 for ! HAVE_GTK3.
4279 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4280
4281 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4282
4283 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4284 gdk_window_get_screen, gdk_window_get_geometry,
4285 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4286 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4287 (xg_get_pixbuf_from_pixmap): New function.
4288 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4289 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4290 Call xg_get_pixbuf_from_pixmap instead of
4291 gdk_pixbuf_get_from_drawable.
4292 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4293 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4294 (xg_check_special_colors): Use GtkStyleContext and its functions
4295 for HAVE_GTK3.
4296 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4297 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4298 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4299 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4300 Call gtk_widget_get_preferred_size.
0afb4571
J
4301 (xg_frame_resized): gdk_window_get_geometry only takes 5
4302 parameters.
44f230aa
SM
4303 (xg_win_to_widget, xg_event_is_for_menubar):
4304 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4305 (xg_set_widget_bg): New function.
4306 (delete_cb): New function.
895009e1 4307 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4308 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4309 (xg_set_background_color): Call xg_set_widget_bg.
4310 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4311 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4312 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4313 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4314 if ! HAVE_GTK3.
4315 (update_frame_tool_bar): Call gtk_widget_hide.
4316 (xg_initialize): Use GDK_KEY_g.
4317
4318 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4319 if ! HAVE_GTK3
4320 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4321
4322 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4323 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4324 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4325
1c2cc4ef
JB
43262011-03-08 Juanma Barranquero <lekktu@gmail.com>
4327
4328 * w32xfns.c (select_palette): Check success of RealizePalette against
4329 GDI_ERROR, not zero.
4330
33383987 4331See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4332
4333;; Local Variables:
4334;; coding: utf-8
aac0c6e3
MR
4335;; End:
4336
33383987 4337 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4338
4339 This file is part of GNU Emacs.
4340
4341 GNU Emacs is free software: you can redistribute it and/or modify
4342 it under the terms of the GNU General Public License as published by
4343 the Free Software Foundation, either version 3 of the License, or
4344 (at your option) any later version.
4345
4346 GNU Emacs is distributed in the hope that it will be useful,
4347 but WITHOUT ANY WARRANTY; without even the implied warranty of
4348 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4349 GNU General Public License for more details.
4350
4351 You should have received a copy of the GNU General Public License
4352 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.