Minor fix to last change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5cf2b69b
KH
12011-08-14 Kenichi Handa <handa@m17n.org>
2
3 * process.c (create_process): Call setup_process_coding_systems
4 after the pid of the process is set to -1.
5
daf17d00
EZ
62011-08-14 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (move_it_in_display_line_to): Don't invoke
9 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10 ppos_it. Fixes vertical cursor motion when line beginning is
11 covered by an image. (Bug#9296)
12
08e3161a
JD
132011-08-14 Jan Djärv <jan.h.d@swipnet.se>
14
15 * nsterm.h (ns_run_ascript): Declare.
16 (NSAPP_DATA2_RUNASSCRIPT): Define.
17
18 * nsfns.m (as_script, as_result, as_status): New static variables.
19 (ns_run_ascript): New function.
20 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
21 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
22 the event loop. Get status from as_status (Bug#7276).
23
24 * nsterm.m (sendEvent): If event is NSApplicationDefined and
25 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
26 the event loop (Bug#7276).
27
a3720aa2
AS
282011-08-14 Andreas Schwab <schwab@linux-m68k.org>
29
30 * gnutls.c (QCgnutls_bootprop_priority)
31 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
32 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
33 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
34 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
35 (QCgnutls_bootprop_verify_hostname_error)
36 (QCgnutls_bootprop_callbacks_verify): Rename from
37 Qgnutls_bootprop_..., all uses changed.
38
39 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
40 uses changed.
41
0a0d27fb
PE
422011-08-14 Paul Eggert <eggert@cs.ucla.edu>
43
19d5c50c
PE
44 * xfaces.c (Qframe_set_background_mode): Now static.
45 * dispextern.h (Qframe_set_background_mode): Remove decl.
46
0a0d27fb
PE
47 * process.c (Fnetwork_interface_info): Declare local only if needed.
48
377538cb
JD
492011-08-13 Jan Djärv <jan.h.d@swipnet.se>
50
51 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
52 (Fnetwork_interface_list): Allocate in increments of bytes instead
53 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
54 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
55 sockaddr.
56 (struct ifflag_def): notrailers is smart on OSX.
57 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
58 Get hardware address with getifaddrs if available.
59
08fff70c
EZ
602011-08-12 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (iterate_out_of_display_property): xassert that
63 IT->position is set to within IT->object's boundaries. Break from
64 the loop as soon as EOB is reached; avoids infloops in redisplay
65 when IT->position is set up wrongly due to some bug. Set
66 IT->current to match the bidi iterator unconditionally.
67 (push_display_prop): Allow GET_FROM_STRING as IT->method on
68 entry. Force push_it to save on the stack the current
69 buffer/string position, to be restored by pop_it. Fix flags in
70 the iterator structure wrt the object coming from a display
71 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
72 properties. (Bug#9284)
73
7be1c708 742011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 75
7be1c708
CY
76 * fontset.c (fontset_get_font_group): Add proper type checks.
77 (Bug#9172)
aac0c6e3 78
7be1c708 792011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 80
7be1c708
CY
81 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
82 and LC_VERSION_MIN_MACOSX.
83 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
84 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 85
97bb72a6
EZ
862011-08-08 Eli Zaretskii <eliz@gnu.org>
87
88 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
89 no-display-properties-and-no-overlays under bidi display. Set
90 disp_pos in the bidi iterator to avoid searches for display
91 properties and overlays.
97bb72a6 92
d5617611
CY
932011-08-08 Chong Yidong <cyd@stupidchicken.com>
94
37e11a63
CY
95 * editfns.c (Fset_time_zone_rule): Document relationship with the
96 setenv function.
97
d5617611
CY
98 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
99 the font entity extracted from the cache (Bug#8109).
100
58872834
CY
1012011-08-07 Chong Yidong <cyd@stupidchicken.com>
102
103 * composite.c (autocmp_chars): Don't reset point. That is done by
104 restore_point_unwind (Bug#5984).
105
75bfc667
JL
1062011-08-07 Juri Linkov <juri@jurta.org>
107
108 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
109 to show the arg `TIME' instead of `TIMEVAL'.
110
d1410150
EZ
1112011-08-06 Eli Zaretskii <eliz@gnu.org>
112
113 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
114 display property strides EOL and includes a newline, as in
115 longlines-mode. (Bug#9254)
75b771e4
EZ
116 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
117 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
118
119 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
120 is non-zero, even if the data buffer is NULL. Fixes a crash in
121 vertical-motion with longlines-mode. (Bug#9254)
122
35928349
EZ
1232011-08-05 Eli Zaretskii <eliz@gnu.org>
124
ec7cc85b
EZ
125 * bidi.c <bidi_cache_total_alloc>: Now static.
126 (bidi_initialize): Initialize bidi_cache_total_alloc.
127
35928349
EZ
128 *xdisp.c (display_line): Release buffer allocated for shelved bidi
129 cache. (Bug#9221)
130
131 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
132 amount allocated this far in `bidi_cache_total_alloc'.
133 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
134 non-zero, only free the data buffer without restoring the cache
135 contents. All callers changed.
136
137 * dispextern.h (bidi_unshelve_cache): Update prototype.
138
139 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
140 (move_it_in_display_line, move_it_to)
141 (move_it_vertically_backward, move_it_by_lines): Replace the call
142 to xfree to an equivalent call to bidi_unshelve_cache.
143 (move_it_in_display_line_to): Fix logic of returning
412b6358 144 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 145
e2e2423b
EZ
1462011-08-05 Eli Zaretskii <eliz@gnu.org>
147
148 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
149 came from a string character with a `cursor' property. (Bug#9229)
150
ae9e757a
JD
1512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
152
153 * Makefile.in (LIB_PTHREAD): New variable.
154 (LIBES): Add LIB_PTHREAD (Bug#9216).
155
156 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
157 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
158
213bd7f2
AS
1592011-08-04 Andreas Schwab <schwab@linux-m68k.org>
160
161 * regex.c (re_iswctype): Remove some redundant boolean
162 conversions.
163
99aaf75f
JD
1642011-08-04 Jan Djärv <jan.h.d@swipnet.se>
165
166 * xterm.c (x_find_topmost_parent): New function.
167 (x_set_frame_alpha): Find topmost parent window with
168 x_find_topmost_parent and set the property there also (bug#9181).
169 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
170
c74e9d86
PE
1712011-08-04 Paul Eggert <eggert@cs.ucla.edu>
172
173 * callproc.c (Fcall_process): Avoid vfork clobbering
174 the local vars buffer, coding_systems, current_dir.
175
640c8776
SM
1762011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * keymap.c (Fmake_composed_keymap): Move to subr.el.
179
f26d0e4c
PE
1802011-08-03 Paul Eggert <eggert@cs.ucla.edu>
181
8a10d76c
PE
182 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
183 so that it is not optimized away.
184
f26d0e4c
PE
185 * xdisp.c (compute_display_string_pos): Remove unused local.
186
55439c61
EZ
1872011-08-02 Eli Zaretskii <eliz@gnu.org>
188
189 Fix slow cursor motion and scrolling in large buffers with
190 selective display, like Org Mode buffers. (Bug#9218)
191
192 * dispextern.h (struct bidi_it): New member disp_prop_p.
193
194 * xdisp.c: Remove one-slot cache of display string positions.
195 (compute_display_string_pos): Accept an additional argument
196 DISP_PROP_P; callers changed. Scan at most 5K characters forward
197 for a display string or property. If found, set DISP_PROP_P
198 non-zero.
199
200 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
201 DISP_PROP_P, and pass it to compute_display_string_pos.
202 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
203 non-zero. All callers of bidi_fetch_char changed.
204
fb33fa43
SM
2052011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
206
207 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
208
b099e063
DM
2092010-12-03 Don March <don@ohspite.net>
210
211 * keymap.c (Fdefine_key): Fix non-prefix key error message when
212 last character M-[char] is translated to ESC [char] (bug#7541).
213
5cc7f7af
KH
2142011-08-02 Kenichi Handa <handa@m17n.org>
215
d0fffa3f 216 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
217
218 * chartab.c (uniprop_table): Make it non-static.
219
525d5e6e
EZ
2202011-08-01 Eli Zaretskii <eliz@gnu.org>
221
222 * xdisp.c (forward_to_next_line_start): Accept additional argument
223 BIDI_IT_PREV, and store into it the state of the bidi iterator had
224 on the newline.
225 (reseat_at_next_visible_line_start): Use the bidi iterator state
226 returned by forward_to_next_line_start to restore the state of
227 it->bidi_it after backing up to previous newline. (Bug#9212)
228
31011111
AS
2292011-07-30 Andreas Schwab <schwab@linux-m68k.org>
230
231 * regex.c (re_comp): Protoize.
232 (re_exec): Fix return type.
233 (regexec): Fix type of `ret'. (Bug#9203)
234
e5d76069
PE
2352011-07-29 Paul Eggert <eggert@cs.ucla.edu>
236
237 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
238 This is needed if max-image-size is a floating-point number.
239
9a79b20c
AS
2402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
241
242 * print.c (print_object): Print empty symbol as ##.
243
244 * lread.c (read1): Read ## as empty symbol.
245
d8c2fa78
AA
2462011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
247
248 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
249 setting frame foreground color (Bug#9175).
250 (x_set_background_color): Likewise.
251
ffe57a7a
AA
252 * nsmenu.m (-setText): Size tooltip dimensions precisely to
253 contents (Bug#9176).
254 (EmacsTooltip -init): Remove bezels and add shadows to
255 tooltip windows.
256
bf3492a5
AA
257 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
258 or scroll bar (Bug#8470).
259
d55e9c53
AA
260 * nsfont.m (nsfont_open): Remove assignment to voffset and
261 unnecessary vars hshink, expand, hd, full_height, min_height.
262 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
263
264 * nsterm.h (nsfont_info): Remove voffset field.
265
d8c2fa78 2662011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
267
268 Implement strike-through and overline on NextStep (Bug#8863).
269
270 * nsfont.m (nsfont_open): Use underline position provided by font,
271 instead of hard-coded value of 2.
272 (nsfont_draw): Call ns_draw_text_decoration instead.
273
274 * nsterm.h: Add declaration for ns_draw_text_decoration.
275
276 * nsterm.m (ns_draw_text_decoration): New function for drawing
277 underline, overline, and strike-through.
278 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
279 ns_draw_text_decoration. Change treatment of cursor drawing to
280 accomodate underlining, etc.
281
4cc60b9b
EZ
2822011-07-28 Eli Zaretskii <eliz@gnu.org>
283
bc7ece87
EZ
284 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
285 default.
4cc60b9b 286
476371c4
PE
2872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
288
66606eea
PE
289 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
290 Without this fix, if a signal arrives just after memory fills up,
291 'malloc' might be invoked reentrantly.
292
476371c4
PE
293 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
294 In other words, assume that every image size is allowed, on non-X
295 hosts. This assumption is probably wrong, but it lets Emacs compile.
296
f3fcc40d
AS
2972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
298
299 * regex.c (re_iswctype): Convert return values to boolean.
300
350c992f
EZ
3012011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
302
303 * xdisp.c (compute_display_string_pos): Don't use cached display
304 string position if the buffer had its restriction changed.
305 (Bug#9184)
306
5266b4bb
PE
3072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
308
309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
310
2573a837 3112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 312
41f55ccd 313 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 314
39e378da
PE
315 * bidi.c: Integer size and overflow fixes.
316 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
317 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
318 (bidi_cache_find_level_change, bidi_cache_ensure_space)
319 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
320 (bidi_find_other_level_edge):
321 Use ptrdiff_t instead of EMACS_INT where either will do.
322 This works better on 32-bit hosts configured --with-wide-int.
323 (bidi_cache_ensure_space): Check for size-calculation overflow.
324 Use % rather than repeated addition, for better worst-case speed.
325 Don't set bidi_cache_size until after xrealloc returns, because it
326 might not return.
327 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
328 (bidi_cache_ensure_space): Also check that the bidi cache size
329 does not exceed that of the largest Lisp string or buffer. See Eli
330 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 331
5e927815
PE
332 * alloc.c (__malloc_size_t): Remove.
333 All uses replaced by size_t. See Andreas Schwab's note
334 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
335
ca4aa935
PE
336 * image.c: Improve checking for integer overflow.
337 (check_image_size): Assume that f is nonnull, since
338 it is always nonnull in practice. This is one less thing to
339 worry about when checking for integer overflow later.
340 (x_check_image_size): New function, which checks for integer
341 overflow issues inside X.
342 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
343 This removes the need for a memory_full check.
344 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
345 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
346 (xbm_read_bitmap_data): Change locals back to 'int', since
347 their values must fit in 'int'.
348 (xpm_load_image, png_load, tiff_load):
349 Invoke x_create_x_image_and_pixmap earlier,
350 to avoid much needless work if the image is too large.
351 (tiff_load): Treat overly large images as if
352 x_create_x_image_and_pixmap failed, not as malloc failures.
353 (gs_load): Use x_check_image_size.
354
5f8f9cc2
PE
355 * gtkutil.c: Omit integer casts.
356 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
357 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
358
5adf60bc
PE
359 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
360
c8907a93
PE
361 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
362 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
363 would wrongly return t on a 64-bit host.
364
e3c25c68
PE
365 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
366 The plain *_OVERFLOW macros run afoul of GCC bug 49705
367 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
368 and therefore cause GCC to emit a bogus diagnostic in some cases.
369
3f791afe
PE
370 * image.c: Integer signedness and overflow and related fixes.
371 This is not an exhaustive set of fixes, but it's time to
372 record what I've got.
373 (lookup_pixel_color, check_image_size): Remove redundant decls.
374 (check_image_size): Don't assume that arbitrary EMACS_INT values
375 fit in 'int', or that arbitrary 'double' values fit in 'int'.
376 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
377 (tiff_load, imagemagick_load_image):
378 Check for overflow in size calculations.
379 (x_create_x_image_and_pixmap): Remove unnecessary test for
380 xmalloc returning NULL; that can't happen.
381 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
382 (xpm_color_bucket): Use better integer hashing function.
383 (xpm_cache_color): Don't possibly over-allocate memory.
384 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
385 (gif_memory_source):
386 Use ptrdiff_t, not int or size_t, to record sizes.
387 (png_load): Don't assume values greater than 2**31 fit in 'int'.
388 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
389 either works, as we prefer signed integers.
390 (tiff_read_from_memory, tiff_write_from_memory):
391 Return tsize_t, not size_t, since that's what the TIFF API wants.
392 (tiff_read_from_memory): Don't fail simply because the read would
393 go past EOF; instead, return a short read.
394 (tiff_load): Omit no-longer-needed casts.
395 (Fimagemagick_types): Don't assume size fits into 'int'.
396
3cc5a532
PE
397 Improve hashing quality when configured --with-wide-int.
398 * fns.c (hash_string): New function, taken from sxhash_string.
399 Do not discard information about ASCII character case; this
400 discarding is no longer needed.
401 (sxhash-string): Use it. Change sig to match it. Caller changed.
402 * lisp.h: Declare it.
403 * lread.c (hash_string): Remove, since we now use fns.c's version.
404 The fns.c version returns a wider integer if --with-wide-int is
405 specified, so this should help the quality of the hashing a bit.
406
b312a492
PE
407 * emacs.c: Integer overflow minor fix.
408 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
409 Define only if GNU_LINUX.
410 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
411
dfd153ae
PE
412 * dispnew.c: Integer signedness and overflow fixes.
413 Remove unnecessary forward decls, that were a maintenance hassle.
414 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
415 All uses changed.
416 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
417 (scrolling_window): Use ptrdiff_t, not int, for byte count.
418 (prepare_desired_row, line_draw_cost):
419 Use int, not unsigned, where either works.
420 (save_current_matrix, restore_current_matrix):
421 Use ptrdiff_t, not size_t, where either works.
422 (init_display): Check for overflow more accurately, and without
423 relying on undefined behavior.
424
a81d11a3
PE
425 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
426 Remove, replacing with the new symbols in lisp.h. All uses changed.
427 * fileio.c (make_temp_name):
428 * filelock.c (lock_file_1, lock_file):
429 * xdisp.c (message_dolog):
430 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
431 Use pMd etc. instead.
432 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
433 replacing the pWIDE etc. symbols removed from editfns.c.
434
3300e6fd
PE
435 * keyboard.h (num_input_events): Now uintmax_t.
436 This is (very slightly) less likely to mess up due to wraparound.
437 All uses changed.
438
fd05c7e9
PE
439 * buffer.c: Integer signedness fixes.
440 (alloc_buffer_text, enlarge_buffer_text):
441 Use ptrdiff_t rather than size_t when either will do, as we prefer
442 signed integers.
443
903fe15d
PE
444 * alloc.c: Integer signedness and overflow fixes.
445 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
446 (__malloc_size_t): Default to size_t, not to int.
447 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
448 (Fgarbage_collect, mark_object_loop_halt, mark_object):
449 Prefer ptrdiff_t to size_t when either would do, as we prefer
450 signed integers.
451 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
452 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
453 Now const. Initialize with values that are in range even if char
454 is signed.
455 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
456 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
457 These functions do the right thing with sizes > 2**32.
458 (check_depth): Now ptrdiff_t, not int.
459 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
460 Adjust to new way of storing sizes. Check for size overflow bugs
461 in rest of code.
462 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
463 slightly wrong anyway, as it missed one instance of
464 XMALLOC_OVERRUN_CHECK_OVERHEAD.
465 (refill_memory_reserve): Omit needless cast to size_t.
466 (mark_object_loop_halt): Mark as externally visible.
467
ac82cc6a
PE
468 * xselect.c: Integer signedness and overflow fixes.
469 (Fx_register_dnd_atom, x_handle_dnd_message):
470 Use ptrdiff_t, not size_t, since we prefer signed.
471 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
472 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
473 x_dnd_atoms_size and x_dnd_atoms_length.
474
c2d1e36d
PE
475 * doprnt.c: Prefer signed to unsigned when either works.
476 * eval.c (verror):
477 * doprnt.c (doprnt):
478 * lisp.h (doprnt):
479 * xdisp.c (vmessage):
480 Use ptrdiff_t, not size_t, when using or implementing doprnt,
481 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
482 prefer signed arithmetic to avoid comparison confusion.
483 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
484 but is a bit tricky.
485
0e926e56
PE
486 Assume freestanding C89 headers, string.h, stdlib.h.
487 * data.c, doprnt.c, floatfns.c, print.c:
488 Include float.h unconditionally.
489 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
490 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
491 * regex.c: Likewise for stddef.h, string.h.
492 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
493 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
494 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
495 (STDC_HEADERS): Remove obsolete defines.
496 * sysdep.c: Include limits.h unconditionally.
497
9cfdb3ec
PE
498 Assume support for memcmp, memcpy, memmove, memset.
499 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
500 * regex.c (memcmp, memcpy):
501 Remove; we assume C89 now.
502
503 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
504 (__malloc_safe_bcopy): Remove; no longer needed.
505
cf950e6b 506 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
507 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
508 well either way, and we prefer signed to unsigned.
509
dbf38e02
LMI
5102011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
511
512 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
513 closes the connection while we're reading (bug#9182).
514
d6f0886c
JD
5152011-07-25 Jan Djärv <jan.h.d@swipnet.se>
516
517 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
518 are specified (Bug#9168).
519
2eb1f9e6
PE
5202011-07-25 Paul Eggert <eggert@cs.ucla.edu>
521
522 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
523 Found by GCC static checking and --with-wide-int on a 32-bit host.
524
22381272 5252011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
526
527 * xdisp.c (compute_display_string_pos): Fix logic of caching
528 previous display string position. Initialize cached_prev_pos to
529 -1. Fixes slow-down at the beginning of a buffer.
530
f25e39b4
EZ
5312011-07-24 Eli Zaretskii <eliz@gnu.org>
532
533 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
534 for attrs[LFACE_FONTSET_INDEX].
535
04c4b52e
PE
5362011-07-23 Paul Eggert <eggert@cs.ucla.edu>
537
538 * xml.c (parse_region): Remove unused local
539 that was recently introduced.
540
c1734fbd
EZ
5412011-07-23 Eli Zaretskii <eliz@gnu.org>
542
be18c5a5
EZ
543 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
544 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
545
c1734fbd
EZ
546 * xdisp.c (move_it_in_display_line_to): Record the best matching
547 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
548 exit if none of the characters scanned was an exact match.
549 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
550 when exact match is impossible due to invisible text, and the
551 lines are truncated.
552
a258d627
JD
5532011-07-23 Jan Djärv <jan.h.d@swipnet.se>
554
555 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
556 for OSX >= 10.7.
557
b6d5a689
EZ
5582011-07-22 Eli Zaretskii <eliz@gnu.org>
559
0f74f785
EZ
560 Fix a significant slow-down of cursor motion with C-n, C-p,
561 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
562 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 563 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
564 (next_element_from_buffer): Call compute_stop_pos_backwards to
565 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
566 base_level_stop.
567 (reseat): Don't look for prev_stop, as that could mean a very long
568 run.
569 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
570 <cached_disp_overlay_modiff>: Cache for last found display string
571 position.
551918c1 572 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
573 about the same buffer in the same area of character positions, and
574 the buffer wasn't changed since the time the display string
575 position was cached.
551918c1 576
b2d0c91a
EZ
5772011-07-22 Eli Zaretskii <eliz@gnu.org>
578
579 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
580 is an integer, which is important for empty lines. (Bug#9149)
581
043604ee
CY
5822011-07-22 Chong Yidong <cyd@stupidchicken.com>
583
584 * frame.c (Fmodify_frame_parameters): In tty case, update the
585 default face if necessary (Bug#4238).
586
da4adb04
CY
5872011-07-21 Chong Yidong <cyd@stupidchicken.com>
588
589 * editfns.c (Fstring_to_char): No need to explain what a character
590 is in the docstring (Bug#6576).
591
9abd0532
LMI
5922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
593
594 * xml.c (parse_region): Make sure we always return a tree.
595
36881d16
HK
5962011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
597
598 * xml.c (parse_region): If a document contains only comments,
599 return that, too.
600
1e98674d
LMI
6012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
602
603 * xml.c (make_dom): Return comments, too.
604
590bd467
PE
6052011-07-19 Paul Eggert <eggert@cs.ucla.edu>
606
607 Port to OpenBSD.
608 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
609 and the surrounding thread.
610 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
611 rather than fgets, and retry after EINTR. Otherwise, 'emacs
612 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
613 timer goes off.
614 * s/openbsd.h (BROKEN_SIGIO): Define.
615 * unexelf.c (unexec) [__OpenBSD__]:
616 Don't update the .mdebug section of the Alpha COFF symbol table.
617
f41628b2
LMI
6182011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
619
620 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
621 (bug#8460).
622
b59b67c5
PE
6232011-07-18 Paul Eggert <eggert@cs.ucla.edu>
624
15e3a074
PE
625 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
626 This fixes some race conditions on the permissions of any newly
627 created file.
628
41bed37d
PE
629 * alloc.c (valid_pointer_p): Use pipe, not open.
630 This fixes some permissions issues when debugging.
631
b59b67c5
PE
632 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
633 If fchown fails to set both uid and gid, try to set just gid,
634 as that is sometimes allowed. Adjust the file's mode to eliminate
635 setuid or setgid bits that are inappropriate if fchown fails.
636
925a6be7
SM
6372011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
638
639 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
640 to compare Lisp_Objects.
641 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
642 global_gnutls_log_level, don't mistake it for a Lisp_Object.
643 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
644
52968808
AS
6452011-07-17 Andreas Schwab <schwab@linux-m68k.org>
646
0a6a104b
AS
647 * lread.c (read_integer): Unread even EOF character.
648 (read1): Likewise. Properly record start position of symbol.
649
52968808
AS
650 * lread.c (read1): Read `#:' as empty uninterned symbol if no
651 symbol character follows.
652
9e381cdd
PE
6532011-07-17 Paul Eggert <eggert@cs.ucla.edu>
654
655 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
656 This works around a problem with the previous change to Fcopy_file.
657 Recent glibc declares fchown with __attribute__((warn_unused_result)),
658 and without this change, GCC might complain about discarding
659 fchown's return value.
660
b5641435
JB
6612011-07-16 Juanma Barranquero <lekktu@gmail.com>
662
663 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
664
a8031457
PE
6652011-07-16 Paul Eggert <eggert@cs.ucla.edu>
666
667 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
668
dd889327
LMI
6692011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
670
750c33f7
LMI
671 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
672 it's used from the C level.
673
dd889327
LMI
674 * process.c: Use the same condition for POLL_FOR_INPUT in both
675 keyboard.c and process.c (bug#1858).
676
87e86684
LM
6772011-07-09 Lawrence Mitchell <wence@gmx.li>
678
679 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
680 (Fgnutls_boot): Use it.
681
64348f40
AS
6822011-07-15 Andreas Schwab <schwab@linux-m68k.org>
683
684 * doc.c (Fsubstitute_command_keys): Revert last change.
685
1d698799
LMI
6862011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
687
f863868c
LMI
688 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
689 quotes the next character, and doesn't affect other longer
690 sequences (bug#8935).
691
1d698799
LMI
692 * lread.c (syms_of_lread): Clarify that is isn't only
693 `eval-buffer' and `eval-defun' that's affected by
694 `lexical-binding' (bug#8460).
695
aa4b6df6
EZ
6962011-07-15 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
699 bidi redisplay when a line includes both an image and is
700 truncated.
701
5d856da6
PE
7022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
703
ad6042bb
PE
704 Fix minor problems found by static checking.
705 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
706 (elsz): Now a signed constant, not a size_t var. We prefer signed
707 types to unsigned, to avoid integer comparison confusion. Without
708 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
709 "cannot optimize loop, the loop counter may overflow", a symptom
710 of the confusion.
f00bbb22 711 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
712 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
713
6468f31c
LMI
7142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
715
49080b10
LMI
716 * search.c (Fre_search_backward): Mention `case-fold-search' in
717 all the re_search_* functions (bug#8138).
718
6468f31c
LMI
719 * keyboard.c (Fopen_dribble_file): Document when the file is
720 closed (bug#8056).
721
c965adc5
EZ
7222011-07-14 Eli Zaretskii <eliz@gnu.org>
723
df9733bf
EZ
724 * bidi.c (bidi_dump_cached_states): Fix format of displaying
725 bidi_cache_idx.
726
0bb23927
EZ
727 Support bidi reordering of display and overlay strings.
728 * xdisp.c (compute_display_string_pos)
729 (compute_display_string_end): Accept additional argument STRING.
730 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
731 (reseat_to_string): Initialize bidi_it->string.s and
732 bidi_it->string.schars.
733 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
734 NULL (avoids a crash in bidi_paragraph_init).
735 Initialize itb.string.lstring.
0bb23927
EZ
736 (init_iterator): Call bidi_init_it only of a valid
737 buffer position was specified. Initialize paragraph_embedding to
738 L2R.
739 (reseat_to_string): Initialize the bidi iterator.
740 (display_string): If we need to ignore text properties of
741 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
742 original value of -1 will not work with bidi.)
743 (compute_display_string_pos): First arg is now struct
744 `text_pos *'; all callers changed. Support display properties on
745 Lisp strings.
746 (compute_display_string_end): Support display properties on Lisp
747 strings.
748 (init_iterator, reseat_1, reseat_to_string): Initialize the
749 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
750 when iterating on a string not from display properties).
640c8776
SM
751 (compute_display_string_pos, compute_display_string_end):
752 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
753 arrow keys.
754 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
755 base_level_stop; instead, set base_level_stop to BEGV.
756 Fixes crashes in vertical-motion.
0bb23927
EZ
757 (next_element_from_buffer): Improve commentary for when
758 the iterator is before prev_stop.
759 (init_iterator): Initialize bidi_p from the default value of
760 bidi-display-reordering, not from buffer-local value. Use the
761 buffer-local value only if initializing for buffer iteration.
762 (handle_invisible_prop): Support invisible properties on strings
763 that are being bidi-reordered.
764 (set_iterator_to_next): Support bidi reordering of C strings and
765 Lisp strings.
766 (next_element_from_string): Support bidi reordering of Lisp
767 strings.
768 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
769 (display_string): Support display of R2L glyph rows.
770 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
771 (init_iterator): Don't initialize it->bidi_p for strings
772 here.
773 (reseat_to_string): Initialize it->bidi_p for strings here.
774 (next_element_from_string, next_element_from_c_string)
775 (next_element_from_buffer): Add xassert's for correspondence
776 between IT's object being iterated and it->bidi_it.string
777 structure.
778 (face_before_or_after_it_pos): Support bidi iteration.
779 (next_element_from_c_string): Handle the case of the first string
780 character that is not the first one in the visual order.
781 (get_visually_first_element): New function, refactored from common
782 parts of next_element_from_buffer, next_element_from_string, and
783 next_element_from_c_string.
784 (tool_bar_lines_needed, redisplay_tool_bar)
785 (display_menu_bar): Force left-to-right direction. Add a FIXME
786 comment for making that be controlled by a user option.
787 (push_it, pop_it): Save and restore the state of the
788 bidi iterator. Save and restore the bidi_p flag.
789 (pop_it): Iterate out of display property for string iteration as
790 well.
791 (iterate_out_of_display_property): Support iteration over strings.
792 (handle_single_display_spec): Set up it->bidi_it for iteration
793 over a display string, and call bidi_init_it.
794 (handle_single_display_spec, next_overlay_string)
795 (get_overlay_strings_1, push_display_prop): Set up the bidi
796 iterator for displaying display or overlay strings.
797 (forward_to_next_line_start): Don't use the shortcut if
798 bidi-iterating.
799 (back_to_previous_visible_line_start): If handle_display_prop
800 pushed the iterator stack, restore the internal state of the bidi
801 iterator by calling bidi_pop_it same number of times.
802 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
803 and we are bidi-iterating, don't decrement the iterator position;
804 instead, set the first_elt flag in the bidi iterator, to produce
805 the same effect.
806 (reseat_1): Remove redundant setting of string_from_display_prop_p.
807 (push_display_prop): xassert that we are iterating a buffer.
808 (push_it, pop_it): Save and restore paragraph_embedding member.
809 (handle_single_display_spec, next_overlay_string)
810 (get_overlay_strings_1, reseat_1, reseat_to_string)
811 (push_display_prop): Set up the `unibyte' member of bidi_it.string
812 correctly. Don't assume unibyte strings are not bidi-reordered.
813 (compute_display_string_pos)
814 (compute_display_string_end): Fix handling the case of C string.
815 (push_it, pop_it): Save and restore from_disp_prop_p.
816 (handle_single_display_spec, push_display_prop): Set the
817 from_disp_prop_p flag.
818 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
819 (pop_it): Call iterate_out_of_display_property only if we are
820 popping after iteration over a string that came from a display
821 property. Fix a typo in popping stretch info. Add an assertion
822 for verifying that the iterator position is in sync with the bidi
823 iterator.
824 (handle_single_display_spec, get_overlay_strings_1)
825 (push_display_prop): Fix initialization of paragraph direction for
826 string when that of the parent object is not yet determined.
827 (reseat_1): Call bidi_init_it to resync the bidi
828 iterator with IT's position. (Bug#7616)
829 (find_row_edges): If ROW->start.pos gives position
830 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
831 (handle_stop, back_to_previous_visible_line_start, reseat_1):
832 Reset the from_disp_prop_p flag.
833 (SAVE_IT, RESTORE_IT): New macros.
834 (pos_visible_p, face_before_or_after_it_pos)
835 (back_to_previous_visible_line_start)
836 (move_it_in_display_line_to, move_it_in_display_line)
837 (move_it_to, move_it_vertically_backward, move_it_by_lines)
838 (try_scrolling, redisplay_window, display_line): Use them when
839 saving a temporary copy of the iterator and restoring it back.
840 (back_to_previous_visible_line_start, reseat_1)
841 (init_iterator): Empty the bidi cache "stack".
842 (move_it_in_display_line_to): If iterator ended up at
843 EOL, but we never saw any buffer positions smaller than
844 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
845 motion in bidi-reordered lines.
846 (move_it_in_display_line_to): Record prev_method and prev_pos
847 immediately before the call to set_iterator_to_next. Fixes cursor
848 motion in bidi-reordered lines with stretch glyphs and strings
849 displayed in margins. (Bug#8133) (Bug#8867)
850 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
851 TO_CHARPOS.
640c8776
SM
852 (pos_visible_p): Support positions in bidi-reordered lines.
853 Save and restore bidi cache.
0bb23927
EZ
854
855 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
856 (bidi_paragraph_info): Delete unused struct.
857 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
858 (bidi_cache_start): New variable.
859 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
860 to zero.
861 (bidi_cache_fetch_state, bidi_cache_search)
862 (bidi_cache_find_level_change, bidi_cache_iterator_state)
863 (bidi_cache_find, bidi_peek_at_next_level)
864 (bidi_level_of_next_char, bidi_find_other_level_edge)
865 (bidi_move_to_visually_next): Compare cache index with
866 bidi_cache_start rather than with zero.
867 (bidi_fetch_char): Accept new argument STRING; all callers
868 changed. Support iteration over a string. Support strings with
869 display properties. Support unibyte strings. Fix the type of
870 `len' according to what STRING_CHAR_AND_LENGTH expects.
871 (bidi_paragraph_init, bidi_resolve_explicit_1)
872 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
873 (bidi_level_of_next_char, bidi_move_to_visually_next):
874 Support iteration over a string.
0bb23927
EZ
875 (bidi_set_sor_type, bidi_resolve_explicit_1)
876 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
877 can now be zero (for strings); special values 0 and -1 were
878 changed to -1 and -2, respectively.
879 (bidi_char_at_pos): New function.
880 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
881 Call it instead of FETCH_MULTIBYTE_CHAR.
882 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
883 initialized to valid values.
884 (bidi_init_it): Don't initialize charpos and bytepos with invalid
885 values.
886 (bidi_level_of_next_char): Allow the sentinel "position" to pass
887 the test for valid cached positions. Fix the logic for looking up
888 the sentinel state in the cache. GCPRO the Lisp string we are
889 iterating.
890 (bidi_push_it, bidi_pop_it): New functions.
891 (bidi_initialize): Initialize the bidi cache start stack pointer.
892 (bidi_cache_ensure_space): New function, refactored from part of
893 bidi_cache_iterator_state. Don't assume the required size is just
894 one BIDI_CACHE_CHUNK away.
895 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
896 (bidi_count_bytes, bidi_char_at_pos): New functions.
897 (bidi_cache_search): Don't assume bidi_cache_last_idx is
898 always valid if bidi_cache_idx is valid.
899 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
900 is valid if it's going to be used.
901 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
902 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
903 (bidi_cache_find_level_change, bidi_cache_ensure_space)
904 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
905 (bidi_find_other_level_edge, bidi_cache_start_stack):
906 All variables related to cache indices are now EMACS_INT.
c965adc5 907
0bb23927
EZ
908 * dispextern.h (struct bidi_string_data): New structure.
909 (struct bidi_it): New member `string'. Make flag members be 1-bit
910 fields, and put them last in the struct.
640c8776
SM
911 (compute_display_string_pos, compute_display_string_end):
912 Update prototypes.
0bb23927
EZ
913 (bidi_push_it, bidi_pop_it): Add prototypes.
914 (struct iterator_stack_entry): New members bidi_p,
915 paragraph_embedding, and from_disp_prop_p.
916 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
917 (bidi_shelve_cache, bidi_unshelve_cache):
918 Declare prototypes.
0bb23927
EZ
919
920 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
921 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
922 and vector-like objects.
923
924 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
925 cache around display iteration.
926
927 * window.c (Fwindow_end, window_scroll_pixel_based)
928 (displayed_window_lines, Frecenter): Save and restore the bidi
929 cache around display iteration.
930
3bbd2265
LMI
9312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
932
933 * editfns.c (Fdelete_region): Clarify the use of the named
934 parameters (bug#6788).
935
adc47434
MR
9362011-07-14 Martin Rudalics <rudalics@gmx.at>
937
938 * indent.c (Fvertical_motion): Set and restore w->pointm when
939 saving and restoring the window's buffer (Bug#9006).
940
837c31f8
LMI
9412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
942
943 * editfns.c (Fstring_to_char): Clarify just what is returned
944 (bug#6576). Text by Eli Zaretskii.
945
ac389d0c
JB
9462011-07-13 Juanma Barranquero <lekktu@gmail.com>
947
948 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
949
0be0ce47
EZ
9502011-07-13 Eli Zaretskii <eliz@gnu.org>
951
952 * buffer.c (mmap_find): Fix a typo.
953
cd18e7e3
JB
9542011-07-13 Johan Bockgård <bojohan@gnu.org>
955
956 Fix execution of x selection hooks.
957 * xselect.c (Qx_lost_selection_functions)
958 (Qx_sent_selection_functions): New vars.
959 (syms_of_xselect): DEFSYM them.
960 (x_handle_selection_request): Pass Qx_sent_selection_functions
961 rather than Vx_sent_selection_functions to Frun_hook_with_args.
962 (x_handle_selection_clear,x_clear_frame_selections):
963 Pass Qx_lost_selection_functions rather than
964 Vx_lost_selection_functions to Frun_hook_with_args.
965
47ea7f44
PE
9662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
967
ac389d0c 968 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
969 The old code sometimes used this field without initializing it.
970
47ea7f44
PE
971 * alloc.c (gc_sweep): Don't read past end of array.
972 In theory, the old code could also have corrupted Emacs internals,
973 though it'd be very unlikely.
974
bc985c87
AS
9752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
976
977 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 978 argument. (Bug#4026)
bc985c87 979
0cf34688
LMI
9802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
981
b3dadd76
LMI
982 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
983 key" (bug#4257).
984
0cf34688
LMI
985 * window.c (Fset_window_start): Doc fix (bug#4199).
986 (Fset_window_hscroll): Ditto.
987
270768cd
PE
9882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
989
077e3dda 990 Fix minor new problems caught by GCC 4.6.1.
270768cd 991 * term.c (init_tty): Remove unused local.
490011a6 992 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 993 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 994 not used otherwise.
270768cd 995
b1f58454
CY
9962011-07-12 Chong Yidong <cyd@stupidchicken.com>
997
998 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
999
22b9578d
LMI
10002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1001
6e70ab07
LMI
1002 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1003 are the mini-buffer and the echo area (bug#3320).
1004
22b9578d
LMI
1005 * term.c (init_tty): Remove support for supdup, c10 and perq
1006 terminals, which are no longer supported (bug#1482).
1007
8974cc9f
JB
10082011-07-10 Johan Bockgård <bojohan@gnu.org>
1009
1010 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1011
a560d974
JD
10122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1015 for non-popups (Bug#3642).
1016
1dae0f0a
AS
10172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1018
268c2c36 1019 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1020 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1021 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1022 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1023 * data.c (fmod): Likewise.
1024 * dispnew.c (swap_glyphs_in_rows): Likewise.
1025 * emacs.c (memory_warning_signal): Likewise.
1026 * floatfns.c (float_error): Likewise.
1027 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1028 (otf_open, font_otf_capability, generate_otf_features)
1029 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1030 Likewise.
1031 * image.c (pbm_read_file): Likewise.
1032 * indent.c (string_display_width): Likewise.
1033 * intervals.c (check_for_interval, search_for_interval)
1034 (inc_interval_count, count_intervals, root_interval)
1035 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1036 * lread.c (defalias): Likewise.
268c2c36 1037 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1038 * regex.c (set_image_of_range_1, set_image_of_range)
1039 (regex_grow_registers): Likewise.
1040 * sysdep.c (strerror): Likewise.
1041 * termcap.c (valid_filename_p, tprint, main): Likewise.
1042 * tparam.c (main): Likewise.
1043 * unexhp9k800.c (run_time_remap, save_data_space)
1044 (update_file_ptrs, read_header, write_header, calculate_checksum)
1045 (copy_file, copy_rest, display_header): Likewise.
1046 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1047 Likewise.
1048 * xdisp.c (check_it): Likewise.
1049 * xfaces.c (register_color, unregister_color, unregister_colors):
1050 Likewise.
1051 * xfns.c (print_fontset_result): Likewise.
1052 * xrdb.c (member, fatal, main): Likewise.
1053
99033785
PE
10542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 Fix minor problems found by static checking (Bug#9031).
1057 * chartab.c (char_table_set_range, map_sub_char_table):
1058 Remove unused locals.
1059 (uniprop_table): Now static.
1060 * composite.c (_work_char): Remove unused static var.
1061
9cb2ac56
JB
10622011-07-09 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1065
f25661f0
JD
10662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1067
1068 * gtkutil.c (qttip_cb): Remove code without function.
1069
8278c4fe
EZ
10702011-07-09 Eli Zaretskii <eliz@gnu.org>
1071
1072 * w32.c (pthread_sigmask): New stub.
1073
1692ae2d 10742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1075
8a6ebd58 1076 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1077 sigprocmask is portable only for single-threaded applications, and
1078 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1079 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1080 (LIBES): Use it.
1081 * callproc.c (Fcall_process):
1082 * process.c (create_process):
1083 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1084 Use pthread_sigmask, not sigprocmask.
123403e4 1085
1b854618
JD
10862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1087
1088 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1089 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1090 wrong (Bug#8591).
1091
3fe4b549
JD
10922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1093
0ce7e563
JD
1094 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1095 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1096 (xg_hide_tooltip): Fix comment.
1097
3fe4b549
JD
1098 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1099 in registerServicesMenuSendTypes.
1100 (validRequestorForSendType): Don't check ns_return_types.
1101
1102 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1103 ns_return_type.
1104
5df75e47
JR
11052011-07-08 Jason Rumney <jasonr@gnu.org>
1106
1107 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1108 frame struct members of non-existent frames (Bug#6284).
1109
699c10bd
JD
11102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1111
4393663b
JD
1112 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1113 variable firstTime not needed on OSX >= 10.6.
1114 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1115 >= 10.5. Use setKnobProportion, setDoubleValue.
1116
1117 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1118 (MAC_OS_X_VERSION_10_5): Define if not defined.
1119 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1120 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1121 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1122
1123 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1124 cString and lossyCString on OSX >= 10.4
1125
1126 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1127 sizeToFit on OSX >= 10.2.
1128
1129 * nsimage.m (allocInitFromFile): Don't use deprecated method
1130 bestRepresentationForDevice on OSX >= 10.6.
1131
1132 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1133 to avoid warning.
1134
1135 * emacs.c: Declare unexec_init_emacs_zone.
1136
a63e0781
JD
1137 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1138
699c10bd
JD
1139 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1140
1141 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1142 on svcsMenu (Bug#8842).
1143
1144 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1145 ns_return_types.
1146 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1147
1148 * nsterm.m (QUTF8_STRING): Declare.
1149 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1150 (validRequestorForSendType): Return type is (id).
1151 Change indexOfObjectIdenticalTo to indexOfObject.
1152 Check if we have local selection before returning self (Bug#8842).
1153 (writeSelectionToPasteboard): Put local selection into paste board
1154 if we have a local selection (Bug#8842).
1155 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1156
1157 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1158 (ns_get_local_selection): Declare.
1159
54e10184
LMI
11602011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1161
9888ff71
LMI
1162 * keymap.c (describe_map_tree): Don't insert a double newline at
1163 the end of the buffer (bug#1169) and return whether we inserted
1164 something.
1165
54e10184
LMI
1166 * callint.c (Fcall_interactively): Change "reading args" to
1167 "providing args" to try to clarify what it does (bug#1010).
1168
15fa4783
KH
11692011-07-07 Kenichi Handa <handa@m17n.org>
1170
1171 * composite.c (composition_compute_stop_pos): Ignore a static
1172 composition starting before CHARPOS (Bug#8915).
1173
1174 * xdisp.c (handle_composition_prop): Likewise.
1175
a8815b00
EZ
11762011-07-07 Eli Zaretskii <eliz@gnu.org>
1177
1178 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1179 (Bug#9015)
1180
ef7b981d 11812011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1182
1183 * character.h (unicode_category_t): New enum type.
1184
1185 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1186 (Qchar_code_property_table): New variable.
1187 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1188 (UNIPROP_COMPRESSED_FORM_P): New macros.
1189 (char_table_ascii): Uncompress the compressed values.
1190 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1191 Uncompress the compressed values.
ac389d0c 1192 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1193 (char_table_ref_and_range): Uncompress the compressed values.
1194 (sub_char_table_set): New arg is_uniprop. Callers changed.
1195 Uncompress the compressed values.
1196 (sub_char_table_set_range): Args changed. Callers changed.
1197 (char_table_set_range): Adjuted for the above change.
1198 (map_sub_char_table): Delete args default_val and parent. Add arg
1199 top. Give decoded values to a Lisp function.
640c8776 1200 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1201 values to a Lisp function. Gcpro more variables.
1202 (uniprop_table_uncompress)
1203 (uniprop_decode_value_run_length): New functions.
1204 (uniprop_decoder, uniprop_decoder_count): New variables.
1205 (uniprop_get_decoder, uniprop_encode_value_character)
1206 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1207 New functions.
1208 (uniprop_encoder, uniprop_encoder_count): New variables.
1209 (uniprop_get_encoder, uniprop_table)
1210 (Funicode_property_table_internal, Fget_unicode_property_internal)
1211 (Fput_unicode_property_internal): New functions.
1212 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1213 Sunicode_property_table_internal, Sget_unicode_property_internal,
1214 and Sput_unicode_property_internal. Defvar_lisp
1215 char-code-property-alist.
1216
640c8776 1217 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1218 Vunicode_category_table.
1219
640c8776 1220 * font.c (font_range): Adjust for the change of
c805dec0
KH
1221 Vunicode_category_table.
1222
76b397fb
DN
12232011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1224
1225 * m/iris4d.h: Remove file, move contents ...
1226 * s/irix6-5.h: ... here.
1227
22b4128e
PE
12282011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1231 * alloc.c (mark_buffer):
1232 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1233 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1234 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1235 This isn't true in general, and it's particularly not true
1236 if Emacs is configured with --with-wide-int.
1237 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1238 New macros, used in the buffer.c change.
1239
869795d6
JD
12402011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1241
1242 * xsettings.c: Use both GConf and GSettings if both are available.
1243 (store_config_changed_event): Add comment.
1244 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1245 (store_tool_bar_style_changed): New functions.
1246 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1247 (struct xsettings): Move font inside HAVE_XFT.
1248 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1249 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1250 Move inside HAVE_XFT.
640c8776 1251 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1252 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1253 also.
1254 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1255 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1256 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1257 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1258 (parse_settings): Move check for font inside HAVE_XFT.
1259 (read_settings, apply_xft_settings): Add comment.
1260 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1261 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1262 call store_font_name_changed.
1263 (xft_settings_event): Add comment.
1264 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1265 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1266 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1267 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1268 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1269 (xsettings_get_system_font, xsettings_get_system_normal_font):
1270 Add comment.
869795d6 1271
d8ed26bd
PE
12722011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 Random fixes. E.g., (random) never returned negative values.
1275 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1276 subseconds part to the entropy, as that's a bit more random.
1277 Prefer signed to unsigned, since the signedness doesn't matter and
1278 in general we prefer signed. When given a limit, use a
1279 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1280 latter isn't right if USE_2_TAGS_FOR_INTS.
1281 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1282 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1283
cabf1cac
SM
12842011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1285
1286 * textprop.c (text_property_stickiness):
1287 Obey Vtext_property_default_nonsticky.
1288 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1289 * w32fns.c (syms_of_w32fns):
1290 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1291
6e9b2be9
PE
12922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1295 This is more efficient than Ffile_directory_p and avoids a minor race.
1296
90186c68
LMI
12972011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1298
7c301272
LMI
1299 * buffer.c (Foverlay_put): Say what the return value is
1300 (bug#7835).
1301
c4f2d8d4
LMI
1302 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1303 is a directory before asking whether to use the file name
1304 (bug#7564).
ad637907
LMI
1305 (barf_or_query_if_file_exists): Make the "File is a directory"
1306 error be more correct.
c4f2d8d4 1307
90186c68
LMI
1308 * fns.c (Frequire): Remove the mention of the .gz files, since
1309 that's installation-specific, but keep the mention of
1310 `get-load-suffixes'.
1311
da64016e
PE
13122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1315 Report string overflow if the output is too long.
1316
7d47b580
JB
13172011-07-04 Juanma Barranquero <lekktu@gmail.com>
1318
a555cb87
JB
1319 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1320 (syms_of_gnutls): Remove duplicate DEFSYM for
1321 Qgnutls_bootprop_verify_hostname_error, an error for
1322 Qgnutls_bootprop_verify_error (which is no longer used).
1323
7d47b580
JB
1324 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1325 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1326 Also (re)move comments that are misplaced or no longer relevant.
1327
1e49bfab
LMI
13282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1329
1330 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1331
1485f4c0
CY
13322011-07-03 Chong Yidong <cyd@stupidchicken.com>
1333
1334 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1335 and background color parameters if they have been changed.
1336
a9ab721e
LMI
13372011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1338
1339 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1340
cf7cff57
PE
13412011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1342
2e13213d
PE
1343 * xsettings.c (SYSTEM_FONT): Define only when used.
1344 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1345
cf7cff57
PE
1346 * keymap.c (access_keymap_1): Now static.
1347
7a8e04f7
CY
13482011-07-02 Chong Yidong <cyd@stupidchicken.com>
1349
1350 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1351 leave any prefix arg for the up event (Bug#1586).
1352
61352f62
LMI
13532011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1354
69bb1ef7
LMI
1355 * lread.c (syms_of_lread): Mention single symbols defined by
1356 `defvar' or `defconst' (bug#7154).
1357
61352f62 1358 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1359 (Frequire): Mention get-load-suffixes.
61352f62 1360
28545e04
MR
13612011-07-02 Martin Rudalics <rudalics@gmx.at>
1362
1363 * window.h (window): Remove clone_number slot.
1364 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1365 Remove.
1366 (make_parent_window, make_window, saved_window)
1367 (Fset_window_configuration, save_window_save): Don't deal with
1368 clone numbers.
1369 * buffer.c (Qclone_number): Remove declaration.
1370 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1371
3349e122
SM
13722011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1373
1374 Add multiple inheritance to keymaps.
1375 * keymap.c (Fmake_composed_keymap): New function.
1376 (Fset_keymap_parent): Simplify.
1377 (fix_submap_inheritance): Remove.
1378 (access_keymap_1): New function extracted from access_keymap to handle
1379 embedded parents and handle lists of maps.
1380 (access_keymap): Use it.
1381 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1382 (Fcopy_keymap): Handle embedded parents.
1383 (Fcommand_remapping, define_as_prefix): Simplify.
1384 (Fkey_binding): Simplify.
1385 (syms_of_keymap): Move minibuffer-local-completion-map,
1386 minibuffer-local-filename-completion-map,
1387 minibuffer-local-must-match-map, and
1388 minibuffer-local-filename-must-match-map to Elisp.
1389 (syms_of_keymap): Defsubr make-composed-keymap.
1390 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1391 (parse_menu_item): Trivial simplification.
1392
3279eb87
GM
13932011-07-01 Glenn Morris <rgm@gnu.org>
1394
1395 * Makefile.in (SETTINGS_LIBS): Fix typo.
1396
4550efdf
KI
13972011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1398
1399 * coding.c (Fencode_coding_string): Record the last coding system
1400 used, as the function doc string says (bug#8738).
1401
0949d2b6
JD
14022011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1403
1404 * xsettings.c (store_monospaced_changed): Take new font as arg and
1405 check for change against current_mono_font.
1406 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1407 (emacs_settings_constructor, emacs_settings_get_property)
1408 (emacs_settings_set_property, emacs_settings_class_init)
1409 (emacs_settings_init, gsettings_obj): Remove.
1410 (something_changedCB): New function for HAVE_GSETTINGS.
1411 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1412 with value as argument.
1413 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1414 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1415 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1416 "changed".
1417
1418 * xgselect.c: Add defined (HAVE_GSETTINGS).
1419 (xgselect_initialize): Ditto.
1420
1421 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1422 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1423 xg_select.
1424
bbc6b304
PE
14252011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * eval.c (struct backtrace): Simplify and port the data structure.
1428 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1429 signed bit field, as this assumption is not portable and it makes
1430 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1431 "char debug_on_exit : 1" as this is not portable either; instead,
1432 use the portable "unsigned int debug_on_exit : 1". Remove unused
1433 member evalargs. Remove obsolete comments about cc bombing out.
1434
9851bfc5
JD
14352011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1436
51bb811f 1437 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1438 Let HAVE_GSETTINGS override HAVE_GCONF.
1439 (store_monospaced_changed): New function.
1440 (EMACS_SETTINGS): A new type derived from GObject to handle
1441 GSettings notifications.
1442 (emacs_settings_constructor, emacs_settings_get_property)
1443 (emacs_settings_set_property, emacs_settings_class_init):
1444 New functions.
1445 (gsettings_client, gsettings_obj): New variables.
1446 (GSETTINGS_SCHEMA): New define.
1447 (something_changedCB): Call store_monospaced_changed.
1448 (init_gsettings): New function.
1449 (xsettings_initialize): Call init_gsettings.
1450 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1451 to NULL.
1452
640c8776 1453 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1454 GCONF_CFLAGS/LIBS.
1455
5386012d
MR
14562011-06-29 Martin Rudalics <rudalics@gmx.at>
1457
1458 * window.c (resize_root_window, grow_mini_window)
1459 (shrink_mini_window): Rename Qresize_root_window to
1460 Qwindow_resize_root_window and Qresize_root_window_vertically to
1461 Qwindow_resize_root_window_vertically.
1462
f13e0b08
PE
14632011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1466
94515237
JB
14672011-06-27 Juanma Barranquero <lekktu@gmail.com>
1468
1469 * makefile.w32-in: Redesign dependencies so they reflect more
1470 clearly which files are directly included by each source file,
1471 and not through other includes.
1472
e43b6e43
MR
14732011-06-27 Martin Rudalics <rudalics@gmx.at>
1474
1475 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1476 (sort_overlays, overlay_strings): When an overlay's clone number
1477 matches the window's clone number process the overlay even if
1478 the overlay's window property doesn't match the current window.
1479
d68443dc
MR
1480 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1481 (Fwindow_hchild): Rename to Fwindow_left_child.
1482 (Fwindow_next): Rename to Fwindow_next_sibling.
1483 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1484 (resize_window_check): Rename to window_resize_check.
1485 (resize_window_apply): Rename to window_resize_apply.
1486 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1487 (Fdelete_other_windows_internal, resize_frame_windows)
1488 (Fsplit_window_internal, Fdelete_window_internal)
1489 (grow_mini_window, shrink_mini_window)
1490 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1491
c7e73be5
JD
14922011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1493
1494 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1495 (emacs_fixed_set_min_size): Remove.
1496 (emacs_fixed_new): Take frame as argument.
1497
1498 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1499 (_EmacsFixedPrivate): Remove minwidth/height.
1500 Add struct frame *f.
1501 (emacs_fixed_init): Initialize priv->f.
1502 (get_parent_class, emacs_fixed_set_min_size): Remove.
1503 (emacs_fixed_new): Set priv->f to argument.
1504 (emacs_fixed_get_preferred_width)
1505 (emacs_fixed_get_preferred_height): Use min_width/height from
1506 frames size_hint to set minimum and natural (Bug#8919).
1507 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1508 and use min_width/height from frames size_hint to set
1509 min_width/height (Bug#8919).
1510
1511 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1512 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1513 Fix indentation.
c7e73be5 1514
cf99dcf8
EZ
15152011-06-26 Eli Zaretskii <eliz@gnu.org>
1516
1517 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1518 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1519 called at ZV.
1520
029529ac
CY
15212011-06-26 Chong Yidong <cyd@stupidchicken.com>
1522
1523 * process.c (wait_reading_process_output): Bypass select if
1524 waiting for a cell while ignoring keyboard input, and input is
1525 pending. Suggested by Jan Djärv (Bug#8869).
1526
7a7ef429
PE
15272011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1528
1529 Use gnulib's dup2 module instead of rolling our own.
1530 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1531
11fdef7d 15322011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1533
1534 * dispnew.c (scrolling_window): Before scrolling, turn off a
1535 mouse-highlight in the window being scrolled.
1536
cd3520a4
JB
15372011-06-24 Juanma Barranquero <lekktu@gmail.com>
1538
1539 Move DEFSYM to lisp.h and use everywhere.
1540
1541 * character.h (DEFSYM): Move declaration...
1542 * lisp.h (DEFSYM): ...here.
1543
1544 * gnutls.c:
1545 * minibuf.c:
1546 * w32menu.c:
1547 * w32proc.c:
1548 * w32select.c: Don't include character.h.
1549
1550 * alloc.c (syms_of_alloc):
1551 * buffer.c (syms_of_buffer):
1552 * bytecode.c (syms_of_bytecode):
1553 * callint.c (syms_of_callint):
1554 * casefiddle.c (syms_of_casefiddle):
1555 * casetab.c (init_casetab_once):
1556 * category.c (init_category_once, syms_of_category):
1557 * ccl.c (syms_of_ccl):
1558 * cmds.c (syms_of_cmds):
1559 * composite.c (syms_of_composite):
1560 * dbusbind.c (syms_of_dbusbind):
1561 * dired.c (syms_of_dired):
1562 * dispnew.c (syms_of_display):
1563 * doc.c (syms_of_doc):
1564 * editfns.c (syms_of_editfns):
1565 * emacs.c (syms_of_emacs):
1566 * eval.c (syms_of_eval):
1567 * fileio.c (syms_of_fileio):
1568 * fns.c (syms_of_fns):
1569 * frame.c (syms_of_frame):
1570 * fringe.c (syms_of_fringe):
1571 * insdel.c (syms_of_insdel):
1572 * keymap.c (syms_of_keymap):
1573 * lread.c (init_obarray, syms_of_lread):
1574 * macros.c (syms_of_macros):
1575 * msdos.c (syms_of_msdos):
1576 * print.c (syms_of_print):
1577 * process.c (syms_of_process):
1578 * search.c (syms_of_search):
1579 * sound.c (syms_of_sound):
1580 * syntax.c (init_syntax_once, syms_of_syntax):
1581 * terminal.c (syms_of_terminal):
1582 * textprop.c (syms_of_textprop):
1583 * undo.c (syms_of_undo):
1584 * w32.c (globals_of_w32):
1585 * window.c (syms_of_window):
1586 * xdisp.c (syms_of_xdisp):
1587 * xfaces.c (syms_of_xfaces):
1588 * xfns.c (syms_of_xfns):
1589 * xmenu.c (syms_of_xmenu):
1590 * xsettings.c (syms_of_xsettings):
1591 * xterm.c (syms_of_xterm): Use DEFSYM.
1592
4228cf16
TZ
15932011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1594
cd3520a4 1595 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1596
7fcccf1e
PE
15972011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1598
7efb4e0e
PE
1599 Integer and buffer overflow fixes (Bug#8873).
1600
ff5844ad
PE
1601 * print.c (printchar, strout): Check for string overflow.
1602 (PRINTPREPARE, printchar, strout):
1603 Don't set size unless allocation succeeds.
1604
90532f02
PE
1605 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1606 for sizes. Check for string overflow more accurately.
1607 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1608
6d84508d
PE
1609 * macros.c: Integer and buffer overflow fixes.
1610 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1611 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1612 Use ptrdiff_t, not int, for sizes.
1613 Don't increment bufsize until after realloc succeeds.
1614 Check for size-calculation overflow.
1615 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1616
437b2cb4
PE
1617 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1618
8b9ac8b4
PE
1619 * lread.c: Integer overflow fixes.
1620 (read_integer): Radix is now EMACS_INT, not int,
1621 to improve quality of diagnostics for out-of-range radices.
1622 Calculate buffer size correctly for out-of-range radices.
1623 (read1): Check for integer overflow in radices, and in
1624 read-circle numbers.
82cb60d3
PE
1625 (read_escape): Avoid int overflow.
1626 (Fload, openp, read_buffer_size, read1)
1627 (substitute_object_recurse, read_vector, read_list, map_obarray):
1628 Use ptrdiff_t, not int, for sizes.
1629 (read1): Use EMACS_INT, not int, for sizes.
20270765 1630 Check for size overflow.
8b9ac8b4 1631
7fcccf1e
PE
1632 * image.c (cache_image): Check for size arithmetic overflow.
1633
bfbbd7e7
PE
1634 * lread.c: Integer overflow issues.
1635 (saved_doc_string_size, saved_doc_string_length)
1636 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1637 Now ptrdiff_t, not int.
1638 (read1): Don't assume doc string length fits in int. Check for
1639 out-of-range doc string lengths.
1640 (read_list): Don't assume file position fits in int.
39019e54 1641 (read_escape): Check for hex character overflow.
bfbbd7e7 1642
4e323265
LL
16432011-06-22 Leo Liu <sdl.web@gmail.com>
1644
1645 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1646 Move to minibuffer.el.
1647
85fece3e
PE
16482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1649
20b84ce9 1650 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1651 The following patches are for when GLYPH_DEBUG && !XASSERT.
1652 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1653 * dispnew.c (flush_stdout):
1654 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1655 Mark as externally visible.
1656 * dispnew.c (check_window_matrix_pointers): Now static.
1657 * dispnew.c (window_to_frame_vpos):
1658 * xfns.c (unwind_create_frame):
1659 * xterm.c (x_check_font): Remove unused local.
1660 * scroll.c (CHECK_BOUNDS):
1661 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1662 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1663 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1664 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1665 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1666 Now static.
1667 (debug_method_add): Use va_list and vsprintf rather than relying
1668 on undefined behavior with wrong number of arguments.
1669 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1670 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1671 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1672 since we're not interested in debugging glyphs with old libraries.
1673 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1674 GCC 4.6.0's static checking.
1675
0766b489
PE
16762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1677
31fd4b32
PE
1678 Integer overflow and signedness fixes (Bug#8873).
1679 A few related buffer overrun fixes, too.
1680
b79e8648
PE
1681 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1682
0766b489
PE
1683 * dispextern.h (struct face.stipple):
1684 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1685 (x_bitmap_mask, x_allocate_bitmap_record)
1686 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1687 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1688 (x_create_bitmap_from_xpm_data):
1689 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1690 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1691 (.bitmaps_last):
1692 * xfaces.c (load_pixmap):
1693 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1694 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1695 (.bitmaps_last, struct x_output.icon_bitmap):
1696 Use ptrdiff_t, not int, for bitmap indexes.
1697 (x_allocate_bitmap_record): Check for size overflow.
1698 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1699
b081724f
PE
1700 Use ptrdiff_t, not int, for overlay counts.
1701 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1702 * editfns.c (overlays_around, get_pos_property):
1703 * textprop.c (get_char_property_and_overlay):
1704 * xdisp.c (next_overlay_change, note_mouse_highlight):
1705 * xfaces.c (face_at_buffer_position):
21514da7
PE
1706 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1707 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1708 (Fnext_overlay_change, Fprevious_overlay_change)
1709 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1710 Use ptrdiff_t, not int, for sizes.
21514da7 1711 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1712
3de73e5e
PE
1713 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1714
2606c57b
PE
1715 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1716 (x_session_initialize): Do not assume string length fits in int.
1717
aaafe47a
PE
1718 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1719 This is unlikely, but can occur if DPI is outlandish.
1720
2674ddc8 1721 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1722 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1723
28154962
PE
1724 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1725 * xrdb.c (magic_file_p, search_magic_path):
1726 Omit last arg SUFFIX; it was always 0. All callers changed.
1727 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1728
7de51af5
PE
1729 * xfont.c (xfont_match): Avoid need for strlen.
1730
25ed6cc3
PE
1731 * xfns.c: Don't assume strlen fits in int.
1732 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1733
4eab31dd
PE
1734 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1735 not unsigned long, as we prefer signed integers. All callers changed.
1736 Detect integer overflow in repeat count.
1737 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1738 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1739
171e2a58
PE
1740 * termcap.c: Don't assume sizes fit in int and never overflow.
1741 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1742 (gobble_line): Check for size-calculation overflow.
1743
ad39faca 1744 * minibuf.c (Fread_buffer):
6e5bb2dc 1745 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1746 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1747 Don't assume string length fits in int.
1748
52c61c22 1749 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1750 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1751
b5b8c9e5
PE
1752 * font.c: Don't assume string length fits in int.
1753 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1754 Use ptrdiff_t, not int.
ccd6111c
PE
1755 (font_intern_prop): Don't assume string length fits in int.
1756 Don't assume integer property fits in fixnum.
1757 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1758
882f0d81 1759 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1760 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1761 Reformulate so as not to need the command string.
1762 Invoke gzip -cd rather than gunzip, as it's more portable.
1763 (lock_info_type, lock_file_1, lock_file):
1764 Don't assume pid_t and time_t fit in unsigned long.
1765 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1766 (current_lock_owner): Prefer signed type for sizes.
1767 Use memcpy, not strncpy, where memcpy is what is really wanted.
1768 Don't assume (via atoi) that time_t and pid_t fit in int.
1769 Check for time_t and/or pid_t out of range, e.g., via a network share.
1770 Don't alloca where an auto var works fine.
1771
93f4cf88
PE
1772 * fileio.c: Fix some integer overflow issues.
1773 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1774 Don't assume string length fits in int.
1775 (directory_file_name): Don't assume string length fits in long.
1776 (make_temp_name): Don't assume pid fits in int, or that its print
1777 length is less than 20.
1778
f3e92b69
PE
1779 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1780
1bfdaf10
PE
1781 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1782
35016e9a
PE
1783 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1784
3d1e65a1
PE
1785 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1786 We prefer signed integers, even for size calculations.
1787
0b963a93
PE
1788 * emacs.c: Don't assume string length fits in 'int'.
1789 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1790 (main): Don't invoke strlen when not needed.
1791
573f4b54
PE
1792 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1793 (XD_DEBUG_MESSAGE): Don't waste a byte.
1794
989f33ba
PE
1795 * callproc.c (getenv_internal_1, getenv_internal)
1796 (Fgetenv_internal):
965d34eb
PE
1797 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1798
e4d29b33
PE
1799 * lread.c (invalid_syntax): Omit length argument.
1800 All uses changed. This doesn't fix a bug, but it simplifies the
1801 code away from its former Hollerith-constant appearance, and it's
1802 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1803 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1804
eb49b136
PE
1805 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1806 This didn't break anything, but it didn't help either.
1807 It's confusing to put a bogus integer in a place where the actual
1808 value does not matter.
9f62aeb1 1809 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1810 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1811
15375a22
PE
1812 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1813 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1814 implementation.
b61cc01c
PE
1815 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1816 We prefer signed types, and the value cannot exceed the EMACS_INT
1817 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1818 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1819 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1820 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1821
53b2623d
PE
1822 * indent.c (sane_tab_width): New function.
1823 (current_column, scan_for_column, Findent_to, position_indentation)
1824 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1825 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1826
51cab52b 1827 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1828
f2ed8a70
PE
1829 * lisp.h (lint_assume): New macro.
1830 * composite.c (composition_gstring_put_cache):
1831 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1832
abe80cc6
PE
1833 * editfns.c, insdel.c:
1834 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1835
b02c740e
PE
1836 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1837
ebc96716
PE
1838 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1839
b4e50fa0 1840 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1841 Use much-faster test for byte-length change.
311d5d7c 1842 Don't assume string byte-length fits in 'int'.
a4cf38e4 1843 Check that character arg fits in 'int'.
85461888 1844 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1845
c0c1ee9f
PE
1846 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1847
a498d7f4
PE
1848 * fns.c (concat): Catch string overflow earlier.
1849 Do not rely on integer wraparound.
1850
51cab52b
PE
1851 * dispextern.h (struct it.overlay_strings_charpos)
1852 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1853 * xdisp.c (forward_to_next_line_start)
1854 (back_to_previous_visible_line_start)
1855 (reseat_at_next_visible_line_start, next_element_from_buffer):
1856 Don't arbitrarily truncate the value of 'selective' to int.
1857
76031fad
PE
1858 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1859
5eb55db9
PE
1860 * composite.c: Don't truncate sizes to 'int'.
1861 (composition_gstring_p, composition_reseat_it)
1862 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1863 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1864 not EMACS_UINT, for indexes.
5eb55db9 1865
0703a717
PE
1866 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1867
d6202519
PE
1868 * buffer.c: Include <verify.h>.
1869 (struct sortvec.priority, struct sortstr.priority):
8961a454 1870 Now EMACS_INT, not int.
c20998a7 1871 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1872 (struct sortstr.size, record_overlay_string)
1873 (struct sortstrlist.size, struct sortlist.used):
1874 Don't truncate size to int.
1875 (record_overlay_string): Check for size-calculation overflow.
d6202519 1876 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1877
d5a19415
JM
18782011-06-22 Jim Meyering <meyering@redhat.com>
1879
029529ac 1880 Don't leak an XBM-image-sized buffer
d5a19415
JM
1881 * image.c (xbm_load): Free the image buffer after using it.
1882
a9041e6c
PE
18832011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 Port to Sun C.
1886 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1887 that Sun C diagnosed.
1888 * fns.c (secure_hash): Fix pointer signedness issue.
1889 * intervals.c (static_offset_intervals): New function.
1890 (offset_intervals): Use it.
1891
7f3f739f
LL
18922011-06-21 Leo Liu <sdl.web@gmail.com>
1893
1894 * deps.mk (fns.o):
1895 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1896 sha512.h.
1897
1898 * fns.c (secure_hash): Rename from crypto_hash_function and change
1899 the first arg to accept symbols.
5b66d427 1900 (Fsecure_hash): New primitive.
7f3f739f
LL
1901 (syms_of_fns): New symbols.
1902
76147d94
DD
19032011-06-20 Deniz Dogan <deniz@dogan.se>
1904
1905 * process.c (Fset_process_buffer): Clarify return value in
1906 docstring.
1907
7d7d0045
CY
19082011-06-18 Chong Yidong <cyd@stupidchicken.com>
1909
1910 * dispnew.c (add_window_display_history): Use BVAR.
1911
1912 * xdisp.c (debug_method_add): Use BVAR.
1913 (check_window_end, dump_glyph_matrix, dump_glyph)
1914 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1915
1916 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1917 Likewise.
1918
1919 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1920 check till after the cache is created in init_frame_faces.
1921
ff2bc410
SM
19222011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1923
1924 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1925
28177add
PE
19262011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1927
dd3482fe
PE
1928 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1929 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1930 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1931
393d71f3 1932 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1933 * fileio.c (Finsert_file_contents):
1934 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1935 Remove the old (too-loose) buffer overflow checks.
1936 They weren't needed, since make_gap checks for buffer overflow.
1937 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1938 The old code merely checked for Emacs fixnum overflow, and relied
1939 on undefined (wraparound) behavior. The new code avoids undefined
1940 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1941
2e6813b0 1942 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1943 Tune. Don't use wider integers than needed. Don't use alloca.
1944 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1945
599a9e4f
PE
1946 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1947
99561444
PE
1948 * insdel.c, lisp.h (buffer_overflow): New function.
1949 (insert_from_buffer_1, replace_range, replace_range_2):
1950 * insdel.c (make_gap_larger):
1951 * editfns.c (Finsert_char):
1952 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1953
28177add
PE
1954 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1955
e69dafad
PE
19562011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1957
a7af7fde 1958 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1959
b1c46f02
PE
1960 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1961 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1962
e69dafad
PE
1963 * fileio.c: Don't assume EMACS_INT fits in off_t.
1964 (emacs_lseek): New static function.
1965 (Finsert_file_contents, Fwrite_region): Use it.
1966 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1967
566684ea
PE
1968 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1969
e6966cd6
PE
1970 * fns.c: Don't overflow int when computing a list length.
1971 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1972 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1973 truncation on 64-bit hosts. Check for QUIT every
1974 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1975 faster and is responsive enough.
1976 (Flength): Report an error instead of overflowing an integer.
1977 (Fsafe_length): Return a float if the value is not representable
1978 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1979 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1980 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1981
dd0b0efb
PE
1982 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1983 (header_size, word_size): New constants.
1984 (allocate_vectorlike): Don't check size overflow here.
1985 (allocate_vector): Check it here instead, since this is the only
1986 caller of allocate_vectorlike that could cause overflow.
1987 Check that the new vector's length is representable as a fixnum.
1988
86fe5cfe
PE
1989 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1990 The previous code was bogus. For example, next_almost_prime (32)
1991 returned 39, which is undesirable as it is a multiple of 3; and
1992 next_almost_prime (24) returned 25, which is a multiple of 5 so
1993 why was the code bothering to check for multiples of 7?
1994
80e88859
PE
1995 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1996
4a2f0ad6
PE
1997 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1998
f66c7cf8
PE
1999 Variadic C functions now count arguments with ptrdiff_t.
2000 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2001 Back then I didn't know that the Emacs coding style prefers signed int.
2002 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2003 were being counted with int, which may truncate counts on 64-bit
2004 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2005 * lisp.h (struct Lisp_Subr.function.aMANY)
2006 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2007 Arg counts are now ptrdiff_t, not size_t.
2008 All variadic functions and their callers changed accordingly.
2009 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2010 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2011 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2012 * callint.c (Fcall_interactively): Check arg count for overflow,
2013 to avoid potential buffer overrun. Use signed char, not 'int',
2014 for 'varies' array, so that we needn't bother to check its size
2015 calculation for overflow.
2016 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2017 * eval.c (apply_lambda):
2018 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2019 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2020 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2021
a1759b76
PE
2022 * callint.c (Fcall_interactively): Don't use index var as event count.
2023
d96be9fc
PE
2024 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2025 * mem-limits.h (SIZE): Remove; no longer used.
2026
a690a978 2027 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2028
578c21e6
PE
2029 Remove unnecessary casts.
2030 * xterm.c (x_term_init):
2031 * xfns.c (x_set_border_pixel):
2032 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2033 These aren't needed now that we assume ANSI C.
2034
96f53c6c
PE
2035 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2036 It's more likely to cause problems (due to unsigned overflow)
2037 than to cure them.
2038
83c77d31
PE
2039 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2040
ee2079f1
PE
2041 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2042
6da65536
PE
2043 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2044
7147c4a4
PE
2045 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2046
193e32d9
PE
2047 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2048
e5533da6
PE
2049 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2050
9910e595
PE
2051 GLYPH_CODE_FACE returns EMACS_INT, not int.
2052 * dispextern.h (merge_faces):
2053 * xfaces.c (merge_faces):
01103c44
PE
2054 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2055 Don't assume EMACS_INT fits in int.
9910e595 2056
2638320e
PE
2057 * character.h (CHAR_VALID_P): Remove unused parameter.
2058 * fontset.c, lisp.h, xdisp.c: All uses changed.
2059
045eb8d9
PE
2060 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2061
c1f134b5
PE
2062 * fns.c (concat): Minor tuning based on overflow analysis.
2063 This doesn't fix any bugs. Use int to hold character, instead
2064 of constantly refetching from Emacs object. Use XFASTINT, not
2065 XINT, for value known to be a character. Don't bother comparing
2066 a single byte to 0400, as it's always less.
2067
395fcb93 2068 * floatfns.c (Fexpt):
327eeec8
PE
2069 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2070
abbd3d23
PE
2071 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2072 for characters.
2073
684a03ef
PE
2074 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2075
0fed43f3
PE
2076 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2077 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2078 incorrectly succeed when S was a string, because 4294967386 was
2079 truncated before it was used.
2080
8fd02eb7
PE
2081 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2082 Otherwise, an out-of-range integer could cause undefined behavior
2083 on a 64-bit host.
2084
f8c86b69
PE
2085 * composite.c: Use int, not EMACS_INT, for characters.
2086 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2087 EMACS_INT, for values that are known to be in character range.
2088 This doesn't fix any bugs but is the usual style inside Emacs and
2089 may generate better code on 32-bit machines.
2090
34206dd2
PE
2091 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2092 This is for reasons similar to the recent CHAR_STRING fix.
2093 * charset.c (Fencode_char): Check that character arg is actually
2094 a character. Pass an int to ENCODE_CHAR.
2095 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2096 wider than 'int', as a compile-time check to prevent future regressions
2097 in this area.
2098
c5958d4c 2099 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2100
2101 Make sure a 64-bit char is never passed to CHAR_STRING.
2102 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2103 by silently ignoring the top 32 bits, allowing some values
2104 that were far too large to be valid characters.
2105 * character.h: Include <verify.h>.
2106 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2107 arguments are no wider than unsigned, as a compile-time check
2108 to prevent future regressions in this area.
2109 * data.c (Faset):
01103c44 2110 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2111 (Fsubst_char_in_region):
2112 * fns.c (concat):
2113 * xdisp.c (decode_mode_spec_coding):
2114 Adjust to CHAR_STRING's new requirement.
2115 * editfns.c (Finsert_char, Fsubst_char_in_region):
2116 * fns.c (concat): Check that character args are actually
2117 characters. Without this test, these functions did the wrong
2118 thing with wildly out-of-range values on 64-bit hosts.
2119
d37ca623
PE
2120 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2121 These casts should not be needed on 32-bit hosts, either.
2122 * keyboard.c (read_char):
2123 * lread.c (Fload): Remove casts to unsigned.
2124
ea204efb
PE
2125 * lisp.h (UNSIGNED_CMP): New macro.
2126 This fixes comparison bugs on 64-bit hosts.
2127 (ASCII_CHAR_P): Use it.
2128 * casefiddle.c (casify_object):
01103c44 2129 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2130 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2131 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2132 * dispextern.h (FACE_FROM_ID):
2133 * keyboard.c (read_char): Use UNSIGNED_CMP.
2134
41cb286c
PE
2135 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2136 not to EMACS_INT, to avoid GCC warning.
2137
4a1b9832
PE
2138 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2139
55daad71
PE
2140 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2141 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2142 isn't needed on 32-bit machines.
8f95c75c 2143
01103c44
PE
2144 * buffer.c (Fgenerate_new_buffer_name):
2145 Use EMACS_INT for count, not int.
0ceccced 2146 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2147
2148 * data.c (Qcompiled_function): Now static.
2149
c6f072e7
PE
2150 * window.c (window_body_lines): Now static.
2151
20ce5912
PE
2152 * image.c (gif_load): Rename local to avoid shadowing.
2153
9c4c5f81
PE
2154 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2155 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2156 * alloc.c (make_save_value): Integer argument is now of type
2157 ptrdiff_t, not int.
2158 (mark_object): Use ptrdiff_t, not int.
2159 * lisp.h (pD): New macro.
2160 * print.c (print_object): Use it.
2161
c0c5c8ae
PE
2162 * alloc.c: Use EMACS_INT, not int, to count objects.
2163 (total_conses, total_markers, total_symbols, total_vector_size)
2164 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2165 (total_free_floats, total_floats, total_free_intervals)
2166 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2167 Now EMACS_INT, not int. All uses changed.
2168 (Fgarbage_collect): Compute overall total using a double, so that
2169 integer overflow is less likely to be a problem. Check for overflow
2170 when converting back to an integer.
5a25e253
PE
2171 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2172 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2173 These were 'int' variables that could overflow on 64-bit hosts;
2174 they were never used, so remove them instead of repairing them.
211a0b2a 2175 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2176 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2177 Previously, this ceilinged at INT_MAX, but that doesn't work on
2178 64-bit machines.
e46bb31a 2179 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2180
c78baabf 2181 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2182 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2183 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2184 when a (possibly-narrower) signed value would do just as well.
2185 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2186
c9d624c6
PE
2187 * alloc.c: Catch some string size overflows that we were missing.
2188 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2189 for convenience in STRING_BYTES_MAX.
2190 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2191 The definition here is exact; the one in lisp.h was approximate.
2192 (allocate_string_data): Check for string overflow. This catches
2193 some instances we weren't catching before. Also, it catches
2194 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2195 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2196 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2197
c9d624c6
PE
2198 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2199 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2200 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2201
353032ce
PE
2202 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2203
2bccce07
PE
2204 * alloc.c (Fmake_string): Check for out-of-range init.
2205
0ac30604
SM
22062011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2207
2208 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2209
c195f2de
JD
22102011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2211
2212 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2213 xg_get_default_scrollbar_width.
2214
2215 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2216 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2217 (style_changed_cb): Call update_theme_scrollbar_width and call
2218 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2219 all frames (Bug#8505).
2220 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2221 Call gtk_window_set_resizable if HAVE_GTK3.
2222 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2223 and height if HAVE_GTK3 (Bug#8505).
2224 (scroll_bar_width_for_theme): New variable.
2225 (update_theme_scrollbar_width): New function.
2226 (xg_get_default_scrollbar_width): Move code to
2227 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2228 (xg_initialize): Call update_theme_scrollbar_width.
2229
2230 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2231
2232 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2233
e10ac9f1
MR
22342011-06-12 Martin Rudalics <rudalics@gmx.at>
2235
2236 * frame.c (make_frame): Call other_buffer_safely instead of
2237 other_buffer.
2238
2239 * window.c (temp_output_buffer_show): Call display_buffer with
2240 second argument Vtemp_buffer_show_specifiers and reset latter
2241 immediately after the call.
2242 (Vtemp_buffer_show_specifiers): New variable.
2243 (auto_window_vscroll_p, next_screen_context_lines)
2244 (Vscroll_preserve_screen_position): Remove leading asterisks from
2245 doc-strings.
2246
2d3c217e 22472011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2248
7b7f97e8 2249 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2250 * buffer.c (Qclone_number): Remove for now, as it's unused.
2251 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2252 (record_buffer): Remove unused local.
2253 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2254 (set_frame_buffer_list): Remove; unused.
2255 * frame.h (other_visible_frames): Remove decl.
2256 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2257 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2258 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2259 if HAVE_GPM.
2260 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2261 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2262 Define only if HAVE_GPM.
2263 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2264 (update_hints_inhibit): Remove; never set. All uses removed.
2265 * widgetprv.h (emacsFrameClassRec): Remove decl.
2266 * window.c (delete_deletable_window): Now returns void, since it
2267 wasn't returning anything.
2268 (compare_window_configurations): Remove unused locals.
2269 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2270 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2271 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2272 the same widths as pointers. This follows up on the 2011-05-06 patch.
2273 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2274 * xterm.h: Likewise.
2275 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2276
1384b89e
JB
22772011-06-12 Juanma Barranquero <lekktu@gmail.com>
2278
2279 * makefile.w32-in: Update dependencies.
2280 (LISP_H): Add lib/intprops.h.
2281
1100a63c
CY
22822011-06-11 Chong Yidong <cyd@stupidchicken.com>
2283
2284 * image.c (gif_load): Add animation frame delay to the metadata.
2285 (syms_of_image): Use DEFSYM. New symbol `delay'.
2286
6198ccd0
MR
22872011-06-11 Martin Rudalics <rudalics@gmx.at>
2288
2289 * window.c (delete_deletable_window): Re-add.
2290 (Fset_window_configuration): Rewrite to handle dead buffers and
2291 consequently deletable windows.
2292 (window_tree, Fwindow_tree): Remove. Supply functionality in
2293 window.el.
2294 (compare_window_configurations): Simplify code.
2295
b6e3633c
AS
22962011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2297
1ab0dee5
AS
2298 * image.c (imagemagick_load_image): Fix type mismatch.
2299 (Fimagemagick_types): Likewise.
2300
b6e3633c
AS
2301 * window.h (replace_buffer_in_windows): Declare.
2302
9397e56f
MR
23032011-06-11 Martin Rudalics <rudalics@gmx.at>
2304
2305 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2306 Qclone_number. Remove external declaration of Qdelete_window.
2307 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2308 code.
640c8776
SM
2309 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2310 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2311 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2312 buffer list implementation.
2313 (other_buffer_safely): New function.
2314 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2315 calls to replace_buffer_in_windows and
2316 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2317 if allowed.
2318 (record_buffer): Inhibit quitting and rewrite using quittable
2319 functions. Run Qbuffer_list_update_hook if allowed.
2320 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2321 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2322 Move switch-to-buffer to window.el.
9397e56f
MR
2323 (bury-buffer): Move to window.el.
2324 (Vbuffer_list_update_hook): New variable.
2325
2326 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2327 section.
2328
2329 * window.h (resize_frame_windows): Move up in code.
2330 (Fwindow_frame): Remove EXFUN.
2331 (replace_buffer_in_all_windows): Remove prototype.
2332 (replace_buffer_in_windows_safely): Add prototype.
2333
2334 * window.c: Declare Qdelete_window static again. Move down
2335 declaration of select_count.
2336 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2337 (Fother_window): Move to window.el.
2338 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2339 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2340 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2341 window.el.
2342 (replace_buffer_in_windows): Implement by calling
2343 Qreplace_buffer_in_windows.
2344 (replace_buffer_in_all_windows): Remove with some functionality
2345 moved into replace_buffer_in_windows_safely.
2346 (replace_buffer_in_windows_safely): New function.
2347 (select_window_norecord, select_frame_norecord): Move in front
2348 of run_window_configuration_change_hook. Remove now obsolete
2349 declarations.
640c8776
SM
2350 (Fset_window_buffer): Rewrite doc-string.
2351 Call Qrecord_window_buffer.
9397e56f
MR
2352 (keys_of_window): Move binding for other-window to window.el.
2353
b50691aa
CY
23542011-06-11 Chong Yidong <cyd@stupidchicken.com>
2355
2356 * dispextern.h (struct image): Replace data member, whose int_val
2357 and ptr_val fields were not used by anything, with a single
2358 lisp_val object.
2359
2360 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2361 (gif_clear_image, gif_load, imagemagick_load_image)
2362 (gs_clear_image, gs_load): Callers changed.
2363
3f754b86
PE
23642011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2365
cca69397
PE
2366 * buffer.h: Include <time.h>, for time_t.
2367 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2368
109e28d0
PE
2369 Fix minor problems found by static checking.
2370
60737f02
PE
2371 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2372
4b66faf3
PE
2373 Make identifiers static if they are not used in other modules.
2374 * data.c (Qcompiled_function, Qframe, Qvector):
2375 * image.c (QimageMagick, Qsvg):
2376 * minibuf.c (Qmetadata):
2377 * window.c (resize_window_check, resize_root_window): Now static.
2378 * window.h (resize_window_check, resize_root_window): Remove decls.
2379
109e28d0
PE
2380 * window.c (window_deletion_count, delete_deletable_window):
2381 Remove; unused.
46a4ce9e
PE
2382 (window_body_lines): Now static.
2383 (Fdelete_other_windows_internal): Mark vars as initialized.
2384 Make sure 'resize_failed' is initialized.
2385 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2386 (resize_window_apply): Remove unused local.
2387 * window.h (delete_deletable_window): Remove decl.
2388
109e28d0 2389 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2390 (imagemagick_load_image): Fix pointer signedness problem by changing
2391 last arg from unsigned char * to char *. All uses changed.
2392 Also, fix a local for similar reasons.
2393 Remove unused locals. Remove locals to avoid shadowing.
2394 (fn_rsvg_handle_free): Remove; unused.
2395 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2396 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2397
3f754b86
PE
2398 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2399
2547adb1
CY
24002011-06-10 Chong Yidong <cyd@stupidchicken.com>
2401
2402 * image.c (gif_load): Fix omitted cast error introduced by
2403 2011-06-06 change.
2404
2c8e37d4
MR
24052011-06-10 Martin Rudalics <rudalics@gmx.at>
2406
2407 * window.h (resize_proportionally, orig_total_lines)
2408 (orig_top_line): Remove from window structure.
2409 (set_window_height, set_window_width, change_window_heights)
2410 (Fdelete_window): Remove prototypes.
2411 (resize_frame_windows): Remove duplicate declaration.
2412
440a42e3
EZ
24132011-06-10 Eli Zaretskii <eliz@gnu.org>
2414
2415 * window.h (resize_frame_windows, resize_window_check)
2416 (delete_deletable_window, resize_root_window)
2417 (resize_frame_windows): Declare prototypes.
2418
2419 * window.c (resize_window_apply): Make definition be "static" to
2420 match the prototype.
2421
562dd5e9
MR
24222011-06-10 Martin Rudalics <rudalics@gmx.at>
2423
2424 * window.c: Remove declarations of Qwindow_size_fixed,
2425 window_min_size_1, window_min_size_2, window_min_size,
2426 size_window, window_fixed_size_p, enlarge_window, delete_window.
2427 Remove static from declaration of Qdelete_window, it's
2428 temporarily needed by Fbury_buffer.
2429 (replace_window): Don't assign orig_top_line and
2430 orig_total_lines.
2431 (Fdelete_window, delete_window): Remove. Window deletion is
2432 handled by window.el.
640c8776
SM
2433 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2434 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2435 (Fdelete_other_windows): Remove. Deleting other windows is
2436 handled by window.el.
2437 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2438 handled in window.el.
2439 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2440 Window minimum sizes are handled in window.el.
2441 (shrink_windows, size_window, set_window_height)
2442 (set_window_width, change_window_heights, window_height)
2443 (window_width, CURBEG, CURSIZE, enlarge_window)
2444 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2445 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2446 handled in window.el.
2447 (make_dummy_parent): Rename to make_parent_window and give it a
2448 second argument horflag.
2449 (make_window): Don't set resize_proportionally any more.
2450 (Fsplit_window): Remove. Windows are split in window.el.
2451 (save_restore_action, save_restore_orig_size)
2452 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2453 Resize mini windows in window.el.
2454 (grow_mini_window, shrink_mini_window): Implement by calling
2455 Qresize_root_window_vertically, resize_window_check and
2456 resize_window_apply.
640c8776
SM
2457 (saved_window, Fset_window_configuration, save_window_save):
2458 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2459 resize_proportionally.
2460 (window_min_height, window_min_width): Move to window.el.
2461 (keys_of_window): Move bindings for delete-other-windows,
2462 split-window, delete-window and enlarge-window to window.el.
2463
2464 * buffer.c: Temporarily extern Qdelete_window.
2465 (Fbury_buffer): Temporarily call Qdelete_window instead of
2466 Fdelete_window (Fbury_buffer will move to window.el soon).
2467
2468 * frame.c (set_menu_bar_lines_1): Remove code handling
2469 orig_top_line and orig_total_lines.
2470
2471 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2472 set_window_height but set heights directly.
2473 (change_frame_size_1): Use resize_frame_windows.
2474
2475 * xdisp.c (init_xdisp): Don't use set_window_height but set
2476 heights directly.
2477
640c8776
SM
2478 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2479 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2480 run_window_configuration_change_hook.
2481
2482 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2483 instead of change_window_heights and run
2484 run_window_configuration_change_hook.
2485
1a13852e
MR
24862011-06-09 Martin Rudalics <rudalics@gmx.at>
2487
2488 * window.c (replace_window): Rename second argument REPLACEMENT to
2489 NEW. New third argument SETFLAG. Rewrite.
2490 (delete_window, make_dummy_parent): Call replace_window with
2491 third argument 1.
2492 (window_list_1): Move down in code.
2493 (run_window_configuration_change_hook): Move set_buffer part
2494 before select_frame_norecord part in order to unwind correctly.
2495 Rename count1 to count.
2496 (recombine_windows, delete_deletable_window, resize_root_window)
2497 (Fdelete_other_windows_internal)
2498 (Frun_window_configuration_change_hook, make_parent_window)
2499 (resize_window_check, resize_window_apply, Fresize_window_apply)
2500 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2501 (Fdelete_window_internal, Fresize_mini_window_internal):
2502 New functions.
1a13852e
MR
2503 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2504
f3d1777e
MR
25052011-06-08 Martin Rudalics <rudalics@gmx.at>
2506
496e208e
MR
2507 * window.h (window): Add some new members to window structure -
2508 normal_lines, normal_cols, new_total, new_normal, clone_number,
2509 splits, nest, prev_buffers, next_buffers.
2510 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2511 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2512
f3d1777e
MR
2513 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2514 Remove.
496e208e
MR
2515 (make_dummy_parent): Set new members of windows structure.
2516 (make_window): Move down in code. Handle new members of window
2517 structure.
2518 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2519 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2520 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2521 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2522 (Fset_window_next_buffers, Fset_window_clone_number):
2523 New functions.
496e208e
MR
2524 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2525 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2526 Doc-string fixes.
2527 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2528 Argument WINDOW can be now internal window too.
2529 (Fwindow_use_time): Move up in code.
2530 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2531 Rewrite doc-string.
2532 (Fset_window_configuration, saved_window)
2533 (Fcurrent_window_configuration, save_window_save): Handle new
2534 members of window structure.
b9e809c2
MR
2535 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2536 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2537 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2538 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2539 Qget_mru_window, Qresize_root_window,
2540 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2541 Qauto_buffer_name; staticpro them.
f3d1777e 2542
abde8f8c
MR
25432011-06-07 Martin Rudalics <rudalics@gmx.at>
2544
2545 * window.c (Fwindow_total_size, Fwindow_left_column)
2546 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2547 (Fwindow_list_1): New functions.
2548 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2549 (Fwindow_width, Fscroll_left, Fscroll_right):
2550 Use window_body_cols instead of window_box_text_cols.
2551 (delete_window, Fset_window_configuration):
2552 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2553 (delete_all_subwindows): Take a window as argument and not a
2554 structure. Rewrite.
190b47e6
MR
2555 (window_loop): Remove handling of GET_LRU_WINDOW and
2556 GET_LARGEST_WINDOW.
2557 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2558
2559 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2560 window_box_text_cols. delete_all_subwindows now takes a
2561 Lisp_Object as argument.
abde8f8c 2562
640c8776
SM
2563 * indent.c (compute_motion, Fcompute_motion):
2564 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2565
fa8a67e6
MR
2566 * frame.c (delete_frame): Call delete_all_subwindows with root
2567 window as argument.
2568
a54e3482
DC
25692011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2570
2571 * fns.c (Fputhash): Document return value.
2572
60002bf5
CY
25732011-06-06 Chong Yidong <cyd@stupidchicken.com>
2574
2575 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2576
0c671da6 25772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2578
b862a52a 2579 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2580
be44ca6c
PE
2581 Check for overflow when converting integer to cons and back.
2582 * charset.c (Fdefine_charset_internal, Fdecode_char):
2583 Use cons_to_unsigned to catch overflow.
2584 (Fencode_char): Use INTEGER_TO_CONS.
2585 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2586 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2587 * data.c (long_to_cons, cons_to_long): Remove.
2588 (cons_to_unsigned, cons_to_signed): New functions.
2589 These signal an error for invalid or out-of-range values.
2590 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2591 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2592 * font.c (Ffont_variation_glyphs):
2593 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2594 * lisp.h: Include <intprops.h>.
2595 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2596 (cons_to_signed, cons_to_unsigned): New decls.
2597 (long_to_cons, cons_to_long): Remove decls.
2598 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2599 (Fprimitive_undo): Use CONS_TO_INTEGER.
2600 * xfns.c (Fx_window_property): Likewise.
2601 * xselect.c: Include <limits.h>.
2602 (x_own_selection, selection_data_to_lisp_data):
2603 Use INTEGER_TO_CONS.
2604 (x_handle_selection_request, x_handle_selection_clear)
2605 (x_get_foreign_selection, Fx_disown_selection_internal)
2606 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2607 (lisp_data_to_selection_data): Use cons_to_unsigned.
2608 (x_fill_property_data): Use cons_to_signed.
2609 Report values out of range.
2610
d1f3d2af
PE
2611 Check for buffer and string overflow more precisely.
2612 * buffer.h (BUF_BYTES_MAX): New macro.
2613 * lisp.h (STRING_BYTES_MAX): New macro.
2614 * alloc.c (Fmake_string):
2615 * character.c (string_escape_byte8):
2616 * coding.c (coding_alloc_by_realloc):
2617 * doprnt.c (doprnt):
2618 * editfns.c (Fformat):
2619 * eval.c (verror):
2620 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2621 since they may not be the same number.
2622 * editfns.c (Finsert_char):
2623 * fileio.c (Finsert_file_contents):
2624 Likewise for BUF_BYTES_MAX.
2625
dd52fcea
PE
2626 * image.c: Use ptrdiff_t, not int, for sizes.
2627 (slurp_file): Switch from int to ptrdiff_t.
2628 All uses changed.
2629 (slurp_file): Check that file size fits in both size_t (for
2630 malloc) and ptrdiff_t (for sanity and safety).
2631
7f9bbdbb
PE
2632 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2633 if b->modtime has its maximal value.
2634
dfe18f82
PE
2635 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2636
84acfcf0
PE
2637 Don't assume time_t can fit into int.
2638 * buffer.h (struct buffer.modtime): Now time_t, not int.
2639 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2640 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2641
ccd9a01a
PE
2642 Minor fixes for signed vs unsigned integers.
2643 * character.h (MAYBE_UNIFY_CHAR):
2644 * charset.c (maybe_unify_char):
2645 * keyboard.c (read_char, reorder_modifiers):
2646 XINT -> XFASTINT, since the integer must be nonnegative.
2647 * ftfont.c (ftfont_spec_pattern):
2648 * keymap.c (access_keymap, silly_event_symbol_error):
2649 XUINT -> XFASTINT, since the integer must be nonnegative.
2650 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2651 since it makes no difference and we prefer signed.
2652 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2653 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2654 nonnegative.
2655
d6d100dd
SM
26562011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2657
2658 * window.h (Fwindow_frame): Declare.
2659
2b6148e4
PE
26602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2661
2662 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2663 (SPARE_MEMORY): Always define.
2664 (LARGE_REQUEST): Remove.
2665 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2666
f230ecc9
MR
26672011-06-06 Martin Rudalics <rudalics@gmx.at>
2668
727e958e
MR
2669 * lisp.h: Move EXFUNS for Fframe_root_window,
2670 Fframe_first_window and Fset_frame_selected_window to window.h.
2671
2672 * window.h: Move EXFUNS for Fframe_root_window,
2673 Fframe_first_window and Fset_frame_selected_window here from
2674 lisp.h.
2675
2676 * frame.c (Fwindow_frame, Fframe_first_window)
2677 (Fframe_root_window, Fframe_selected_window)
2678 (Fset_frame_selected_window): Move to window.c.
2679 (Factive_minibuffer_window): Move to minibuf.c.
2680 (Fother_visible_frames_p): New function.
2681
2682 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2683
f230ecc9
MR
2684 * window.c (decode_window, decode_any_window): Move up in code.
2685 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2686 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2687 (Fwindow_buffer): Move up and rewrite doc-string.
2688 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2689 (Fwindow_prev): New functions.
727e958e
MR
2690 (Fwindow_frame): Move here from frame.c. Accept any window as
2691 argument.
2692 (Fframe_root_window, Fframe_first_window)
2693 (Fframe_selected_window): Move here from frame.c. Accept frame
2694 or arbitrary window as argument. Update doc-strings.
2695 (Fminibuffer_window): Move up in code.
2696 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2697 (Fset_frame_selected_window): Move here from frame.c.
2698 Marginal rewrite.
727e958e
MR
2699 (Fselected_window, select_window, Fselect_window): Move up in
2700 code. Minor doc-string fixes.
f230ecc9 2701
4d09bcf6
PE
27022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2705 Do not assume that spare memory exists; that assumption is valid
2706 only if SYSTEM_MALLOC.
2707 (LARGE_REQUEST): New macro, so that the issue of large requests
2708 is separated from the issue of spare memory.
2709
810928a2
AS
27102011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2711
172418ad
AS
2712 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2713 format. (Bug#8806)
2714
43f862f7
AS
2715 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2716
810928a2
AS
2717 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2718 before statements.
2719
a059fe24
JD
27202011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2721
2722 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2723
2724 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2725
2726 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2727 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2728
989bf368
JB
27292011-06-05 Juanma Barranquero <lekktu@gmail.com>
2730
2731 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2732
4b80f674
CY
27332011-06-04 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2736 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2737 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2738 New error handlers.
4b80f674
CY
2739 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2740 Obey Vx_select_enable_clipboard_manager. Catch errors in
2741 x_clipboard_manager_save (Bug#8779).
2742 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2743 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2744
99a33b77 27452011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2746
2747 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2748
99a33b77 27492011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2750
2751 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2752 in the current matrix if keep_current_p is non-zero.
2753
8264569d
EZ
27542011-06-04 Eli Zaretskii <eliz@gnu.org>
2755
2756 * bidi.c (bidi_level_of_next_char): Fix last change.
2757
57f97249
EZ
27582011-06-03 Eli Zaretskii <eliz@gnu.org>
2759
fec2107c 2760 Support bidi reordering of text covered by display properties.
57f97249 2761
fec2107c
EZ
2762 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2763 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2764 (bidi_cache_search, bidi_cache_iterator_state)
2765 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2766 (bidi_level_of_next_char, bidi_move_to_visually_next):
2767 Support character positions inside a run of characters covered by a
fec2107c
EZ
2768 display string.
2769 (bidi_paragraph_init, bidi_resolve_explicit_1)
2770 (bidi_level_of_next_char): Call bidi_fetch_char and
2771 bidi_fetch_char_advance instead of FETCH_CHAR and
2772 FETCH_CHAR_ADVANCE.
2773 (bidi_init_it): Initialize new members.
2774 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2775 definitions.
2776 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2777 instead of using explicit *_CHAR codes.
d6d100dd
SM
2778 (bidi_resolve_explicit, bidi_resolve_weak):
2779 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2780 bidirectional text is supported only in multibyte buffers.
2781 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2782 it to initialize the frame_window_p member of struct bidi_it.
2783 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2784 (bidi_resolve_explicit, bidi_resolve_weak)
2785 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2786 bidi_it->nchars is non-positive.
2787 (bidi_level_of_next_char): Don't try to lookup the cache for the
2788 next/previous character if nothing is cached there yet, or if we
2789 were just reseat()'ed to a new position.
c40e2fb2 2790
0e14fe90
EZ
2791 * xdisp.c (set_cursor_from_row): Set start and stop points
2792 according to the row's direction when priming the loop that looks
2793 for the glyph on which to display cursor.
2794 (single_display_spec_intangible_p): Function deleted.
2795 (display_prop_intangible_p): Reimplement to call
2796 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2797 Accept 3 additional arguments needed by handle_display_spec.
2798 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2799 values: lists, `(when COND...)' forms, etc.
2800 (single_display_spec_string_p): Support property values that are
2801 lists with the argument STRING its top-level element.
2802 (display_prop_string_p): Fix the condition for processing a
2803 property that is a list to be consistent with handle_display_spec.
fec2107c 2804 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2805 last portion of handle_display_prop.
2806 (compute_display_string_pos): Accept additional argument
2807 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2808 value of a `display' property is a "replacing spec".
2809 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2810 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2811 the display property, but just return a value indicating whether
2812 the display property will replace the characters it covers.
2813 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2814 frame_window_p members of struct bidi_it.
d6d100dd
SM
2815 (compute_display_string_pos, compute_display_string_end):
2816 New functions.
fec2107c
EZ
2817 (push_it): Accept second argument POSITION, where pop_it should
2818 jump to continue iteration.
2819 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2820
fec2107c
EZ
2821 * keyboard.c (adjust_point_for_property): Adjust the call to
2822 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2823
2824 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2825 (bidi_init_it): Update prototypes.
2826 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2827 (compute_display_string_pos, compute_display_string_end):
2828 Declare prototypes.
fec2107c
EZ
2829 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2830 EMACS_INT.
fc6f18ce 2831
40087514 28322011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2833
57f53182
PE
2834 Malloc failure behavior now depends on size of allocation.
2835 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2836 * lisp.h: Change signatures accordingly.
2837 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2838 All callers changed. (Bug#8762)
2839
2840 * gnutls.c: Use Emacs's memory allocators.
2841 Without this change, the gnutls library would invoke malloc etc.
2842 directly, which causes problems on non-SYNC_INPUT hosts, and which
2843 runs afoul of improving memory_full behavior. (Bug#8761)
2844 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2845 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2846 xfree instead of the default malloc, realloc, free.
2847 (Fgnutls_boot): No need to check for memory allocation failure,
2848 since xmalloc does that for us.
2849
ac32cd99 2850 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2851 * category.c (hash_get_category_set):
2852 * ccl.c (ccl_driver):
2853 * charset.c (Fdefine_charset_internal):
2854 * charset.h (struct charset.hash_index):
2855 * composite.c (get_composition_id, gstring_lookup_cache)
2856 (composition_gstring_put_cache):
2857 * composite.h (struct composition.hash_index):
2858 * dispextern.h (struct image.hash):
2859 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2860 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2861 (hashfn_equal, hashfn_user_defined, make_hash_table)
2862 (maybe_resize_hash_table, hash_lookup, hash_put)
2863 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2864 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2865 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2866 * image.c (make_image, search_image_cache, lookup_image)
2867 (xpm_put_color_table_h):
2868 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2869 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2870 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2871 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2872 * alloc.c (allocate_vectorlike):
2873 Check for overflow in vector size calculations.
2874 * ccl.c (ccl_driver):
2875 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2876 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2877 need to be updated by these changes.
40087514
PE
2878 * fns.c (make_hash_table, maybe_resize_hash_table):
2879 Check for integer overflow with large hash tables.
0de4bb68
PE
2880 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2881 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2882 (SXHASH_REDUCE): New macro.
2883 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2884 Use it instead of discarding useful hash info with large hash values.
2885 (sxhash_float): New function.
2886 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2887 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2888 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2889 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2890 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2891 Adjust signatures to match updated version of code.
2892 (consing_since_gc): Now EMACS_INT, since a single hash table can
2893 use more than INT_MAX bytes.
2894
698d32e2
DN
28952011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2896
2897 Make it possible to build with GCC-4.6+ -O2 -flto.
2898
2899 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2900
fd6fa53f
SM
29012011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2902
2903 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2904 Call minibuffer-inactive-mode.
2905
864db017
JB
29062011-05-31 Juanma Barranquero <lekktu@gmail.com>
2907
2908 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2909 Update dependencies.
2910
2ad0baf4
DN
29112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2912
2913 * data.c (init_data): Remove code for UTS, this system is not
2914 supported anymore.
2915
4fcc2638
DN
29162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2917
2918 Don't force ./temacs to start in terminal mode.
2919
2920 * frame.c (make_initial_frame): Initialize faces in all cases, not
2921 only when CANNOT_DUMP is defined.
2922 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2923
c56e0fd5
DN
29242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2925
2926 * dispnew.c (add_window_display_history): Use const for the string
2927 pointer. Remove declaration, not needed.
2928
333d54da 29292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2930
55d4c1b2 2931 Use 'inline', not 'INLINE'.
333d54da 2932 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2933 * alloc.c, fontset.c (INLINE): Remove.
2934 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2935 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2936 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2937 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2938 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2939
738db178
DN
29402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2941
2942 Make it possible to run ./temacs.
2943
2944 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2945 syms_of_callproc does the same thing. Remove test for
2946 "initialized", do it in the caller.
2947 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2948
620c53a6
SM
29492011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2950
2951 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2952 (read_minibuf): Use get_minibuffer.
2953 (syms_of_minibuf): Use DEFSYM.
2954 (Qmetadata): New var.
2955 * data.c (Qbuffer): Don't make it static.
2956 (syms_of_data): Use DEFSYM.
2957
e003a292
PE
29582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2961 (CCL_CODE_MIN): New macro.
2962
ed008a6d
PE
29632011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2964
3687c2ef
PE
2965 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2966
ed008a6d
PE
2967 * eval.c (Qdebug): Now static.
2968 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2969 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2970 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2971
d66c4c7c
CY
29722011-05-29 Chong Yidong <cyd@stupidchicken.com>
2973
2974 * image.c: Various fixes to ImageMagick code comments.
2975 (Fimagemagick_types): Doc fix.
2976
5fbc2025
PE
29772011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2978
0196f88a
PE
2979 Minor fixes prompted by GCC 4.6.0 warnings.
2980
2981 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2982
5fbc2025
PE
2983 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2984 (x_clipboard_manager_save_all): Move extern decl to ...
2985 * xterm.h: ... here, so that it can be checked for consistency.
2986
1dd3c2d9
CY
29872011-05-29 Chong Yidong <cyd@stupidchicken.com>
2988
2989 * xselect.c (x_clipboard_manager_save_frame)
2990 (x_clipboard_manager_save_all): New functions.
2991 (Fx_clipboard_manager_save): Lisp function deleted.
2992
2993 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2994 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2995
2996 * xterm.h: Update prototype.
2997
5ba6571d
WX
29982011-05-28 William Xu <william.xwl@gmail.com>
2999
3000 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3001 exiting (Bug#8239).
3002
3eaff834
JM
30032011-05-28 Jim Meyering <meyering@redhat.com>
3004
e1900994 3005 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3006 * fns.c (to_uchar): Define.
3007 (crypto_hash_function): Use it to convert some newly-signed
3008 variables to unsigned, to avoid sign-extension bugs. For example,
3009 without this change, (md5 "truc") would evaluate to
3010 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3011 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3012 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3013
0f6990a7
PE
30142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 Integer overflow fixes.
c8a9ca5a 3017
08686060
PE
3018 * dbusbind.c: Serial number integer overflow fixes.
3019 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3020 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3021 to hold a serial number that is too large for a fixnum.
3022 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3023 Check for serial numbers out of range. Decode any serial number
59568bf0 3024 that was so large that it became a float. (Bug#8722)
08686060 3025
2d1fc3c7
PE
3026 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3027 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3028 Use XFASTINT rather than XUINT when numbers are nonnegative.
3029 (xd_append_arg, Fdbus_method_return_internal):
3030 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3031 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3032 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3033 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3034 (Bug#8722)
2d1fc3c7 3035
c8a9ca5a
PE
3036 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3037
519e1d69
PE
3038 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3039
30569699
PE
3040 ccl: add integer overflow checks
3041 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3042 (IN_INT_RANGE): New macros.
3043 (ccl_driver): Use them to check for integer overflow when
3044 decoding a CCL program. Many of the new checks are whether XINT (x)
3045 fits in int; it doesn't always, on 64-bit hosts. The new version
3046 doesn't catch all possible integer overflows, but it's an
847044ea 3047 improvement. (Bug#8719)
30569699 3048
c11285dc
PE
3049 * alloc.c (make_event_array): Use XINT, not XUINT.
3050 There's no need for unsigned here.
3051
fdccd48e
PE
3052 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3053 This follows up to the 2011-05-06 change that substituted uintptr_t
3054 for EMACS_INT. This case wasn't caught back then.
3055
37910ab2
PE
3056 Rework Fformat to avoid integer overflow issues.
3057 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3058 now (part of C89). Include <verify.h>.
3059 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3060 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3061 (Fformat): Avoid the prepass trying to compute sizes; it was only
3062 approximate and thus did not catch overflow reliably. Instead, walk
3063 through the format just once, formatting and computing sizes as we go,
3064 checking for integer overflow at every step, and allocating a larger
3065 buffer as needed. Keep track separately whether the format is
3066 multibyte. Keep only the most-recently calculated precision, rather
3067 than them all. Record whether each argument has been converted to
3068 string. Use EMACS_INT, not int, for byte and char and arg counts.
3069 Support field widths and precisions larger than INT_MAX. Avoid
3070 sprintf's undefined behavior with conversion specifications such as %#d
3071 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3072 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3073 formatting out-of-range floating point numbers with int
9173deec 3074 formats. (Bug#8668)
37910ab2 3075
2e6578fb
PE
3076 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3077
0ae6bdee
PE
3078 * data.c: Avoid integer truncation in expressions involving floats.
3079 * data.c: Include <intprops.h>.
3080 (arith_driver): When there's an integer overflow in an expression
3081 involving floating point, convert the integers to floating point
3082 so that the resulting value does not suffer from catastrophic
3083 integer truncation. For example, on a 64-bit host (* 4
3084 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3085 Do not rely on undefined behavior after integer overflow.
3086
de883a70
PE
3087 merge count_size_as_multibyte, parse_str_to_multibyte
3088 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3089 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3090 Check for integer overflow.
3091 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3092 since it's now a duplicate of the other. This is more of
3093 a character than a buffer op, so better that it's in character.c.
3094 * fns.c, print.c: Adjust to above changes.
3095
2ff916cb
PE
30962011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3097
3098 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3099
f1b54466
PE
31002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3101
fb1ac845
PE
3102 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3103 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3104 (x_clipboard_manager_save): Now static.
3105 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3106
f1b54466
PE
3107 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3108 (crypto_hash_function): Now static.
3109 Fix pointer signedness problems. Avoid unnecessary initializations.
3110
a9f737ee
CY
31112011-05-27 Chong Yidong <cyd@stupidchicken.com>
3112
3113 * termhooks.h (Vselection_alist): Make it terminal-local.
3114
3115 * terminal.c (create_terminal): Initialize it.
3116
3117 * xselect.c: Support for clipboard managers.
3118 (Vselection_alist): Move to termhooks.h as terminal-local var.
3119 (LOCAL_SELECTION): New macro.
3120 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3121 (symbol_to_x_atom): Remove gratuitous arg.
3122 (x_handle_selection_request, lisp_data_to_selection_data)
3123 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3124 (x_own_selection, x_get_local_selection, x_convert_selection):
3125 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3126 (some_frame_on_display): Delete unused function.
3127 (Fx_own_selection_internal, Fx_get_selection_internal)
3128 (Fx_disown_selection_internal, Fx_selection_owner_p)
3129 (Fx_selection_exists_p): New optional frame arg.
3130 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3131 (x_handle_selection_clear): Don't treat other terminals with the
3132 same keyboard specially. Use the terminal-local Vselection_alist.
3133 (x_clear_frame_selections): Use Frun_hook_with_args.
3134
3135 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3136
3137 * xterm.h: Add support for those atoms.
3138
e067f0c1
CY
31392011-05-26 Chong Yidong <cyd@stupidchicken.com>
3140
3141 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3142 (converted_selections, conversion_fail_tag): New global variables.
3143 (x_selection_request_lisp_error): Free the above.
3144 (x_get_local_selection): Remove unnecessary code.
3145 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3146 of converted selections stored in converted_selections.
3147 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3148 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3149 (x_convert_selection): New function.
3150 (x_handle_selection_event): Simplify.
3151 (x_get_foreign_selection): Don't ignore incoming requests while
3152 waiting for an answer; this will fail when we implement
3153 SAVE_TARGETS, and seems unnecessary anyway.
3154 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3155 (Vx_sent_selection_functions): Doc fix.
3156
0f4aebc0
LL
31572011-05-26 Leo Liu <sdl.web@gmail.com>
3158
3159 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3160
e61124cd
YM
31612011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3162
3163 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3164
3165 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3166 for fringe update if it has periodic bitmap.
ac389d0c 3167 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3168 and fringe_bitmap_periodic_p.
3169
3170 * fringe.c (get_fringe_bitmap_data): New function.
3171 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3172 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3173 row. Mark glyph row for fringe update if periodicity changed.
3174
3175 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3176 for fringe update unless it has periodic bitmap.
3177
f16d9837
KH
31782011-05-25 Kenichi Handa <handa@m17n.org>
3179
3180 * xdisp.c (get_next_display_element): Set correct it->face_id for
3181 a static composition.
3182
e1b90ef6
LL
31832011-05-24 Leo Liu <sdl.web@gmail.com>
3184
3185 * deps.mk (fns.o):
3186 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3187
3188 * fns.c (crypto_hash_function, Fsha1): New function.
3189 (Fmd5): Use crypto_hash_function.
3190 (syms_of_fns): Add Ssha1.
3191
7400048f
PE
31922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * gnutls.c: Remove unused macros.
3195 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3196 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3197 Remove macros that are defined and never used.
3198 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3199
abb71cf4
CY
32002011-05-22 Chong Yidong <cyd@stupidchicken.com>
3201
3202 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3203 (Fx_get_selection_internal): Minor cleanup.
3204 (Fx_own_selection_internal): Rename arguments for consistency with
3205 select.el.
3206
6307db39
PE
32072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3210
f3d4e0a4
CY
32112011-05-22 Chong Yidong <cyd@stupidchicken.com>
3212
3213 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3214
4d8ade89
YM
32152011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3216
3217 * dispnew.c (scrolling_window): Don't exclude the case that the
3218 last enabled row in the desired matrix touches the bottom boundary.
3219
32078c8d
GM
32202011-05-21 Glenn Morris <rgm@gnu.org>
3221
3222 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3223 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3224 and add some more files.
32078c8d 3225
7285dc67
EZ
32262011-05-20 Eli Zaretskii <eliz@gnu.org>
3227
3228 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3229 report_file_error introduced by the change from 2011-05-07.
3230
89d1bd22
PE
32312011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 * systime.h (Time): Define only if emacs is defined.
3234 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3235 where the include path doesn't have X11/X.h by default. See
3236 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3237
e23640bb 32382011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3239
3240 * composite.c (find_automatic_composition): Fix previous change.
3241
b9704ad9
GM
32422011-05-20 Glenn Morris <rgm@gnu.org>
3243
3244 * lisp.mk: New file, split from Makefile.in.
3245 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3246 (shortlisp): Remove.
3247 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3248
4a720484
GM
32492011-05-19 Glenn Morris <rgm@gnu.org>
3250
3251 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3252 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3253 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3254 (lisp): Set the order to that of loadup.el.
3255 (shortlisp): Make it a copy of $lisp.
3256 (SOME_MACHINE_LISP): Remove.
3257 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3258 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3259
a28d4396
KH
32602011-05-18 Kenichi Handa <handa@m17n.org>
3261
3262 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3263 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3264 (find_automatic_composition): Mostly rewrite for efficiency.
3265
a2b1fa8e
JB
32662011-05-18 Juanma Barranquero <lekktu@gmail.com>
3267
3268 * makefile.w32-in: Update dependencies.
3269
8e1f5610
CS
32702011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3271
3272 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3273 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3274
7025ee00 32752011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3276
cdfa6eab
PE
3277 Fix some integer overflow issues, such as string length overflow.
3278
06d6db33
PE
3279 * insdel.c (count_size_as_multibyte): Check for string overflow.
3280
2b4560a8
PE
3281 * character.c (lisp_string_width): Check for string overflow.
3282 Use EMACS_INT, not int, for string indexes and lengths; in
3283 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3284 the resulting string length overflows an EMACS_INT; instead,
3285 report a string overflow if no precision given. When checking for
3286 precision exhaustion, use a check that cannot possibly have
3287 integer overflow. (Bug#8675)
3288 * character.h (lisp_string_width): Adjust to new signature.
3289
cb93f9be
PE
3290 * alloc.c (string_overflow): New function.
3291 (Fmake_string): Use it. This doesn't change behavior, but saves
3292 a few bytes and will simplify future changes.
3293 * character.c (string_escape_byte8): Likewise.
3294 * lisp.h (string_overflow): New decl.
3295
1a1f3366
PE
3296 Fixups, following up to the user-interface timestamp change.
3297 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3298 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3299 * msdos.c (mouse_get_pos): Likewise.
3300 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3301 * w32gui.h (Time): Define by including "systime.h" rather than by
3302 declaring it ourselves. (Bug#8664)
3303
d4e3e4d3
PE
3304 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3305 * image.c (clear_image_cache): Likewise.
3306
f6a24d19
PE
3307 * term.c (term_mouse_position): Don't assume time_t wraparound.
3308
08dc5ae6
PE
3309 Be more systematic about user-interface timestamps.
3310 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3311 and sometimes 'EMACS_UINT', to represent these timestamps.
3312 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3313 This makes the code easier to follow, and makes it easier to catch
3314 integer overflow bugs such as Bug#8664.
3315 * frame.c (Fmouse_position, Fmouse_pixel_position):
3316 Use Time, not unsigned long, for user-interface timestamps.
3317 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3318 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3319 * keyboard.h (last_event_timestamp): Likewise.
3320 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3321 * menu.h (xmenu_show): Likewise.
3322 * term.c (term_mouse_position): Likewise.
3323 * termhooks.h (struct input_event.timestamp): Likewise.
3324 (struct terminal.mouse_position_hook): Likewise.
3325 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3326 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3327 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3328 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3329 what it was before.
3330 * menu.h, termhooks.h: Include "systime.h", for Time.
3331
8e55734a
PE
3332 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3333 Don't assume that the difference between two unsigned long values
3334 can fit into an integer. At this point, we know button_down_time
3335 <= event->timestamp, so the difference must be nonnegative, so
3336 there's no need to cast the result if double-click-time is
3337 nonnegative, as it should be; check that it's nonnegative, just in
3338 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3339 apart (about 25 days). (Bug#8664)
8e55734a 3340
841f1b75 3341 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3342 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3343
3e26f69c
PE
3344 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3345 that always fit in int. Use a sentinel instead of a counter, to
3346 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3347 * frame.h (struct frame): Use int for menu_bar_items_used
3348 instead of EMACS_INT, since it always fits in int.
3e26f69c 3349
5cc152c0
PE
3350 * menu.c (grow_menu_items): Check for int overflow.
3351
d89eb65e
PE
3352 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3353
5235bd3e
PE
3354 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3355 Before, the code was not consistent. These values cannot exceed
3356 2**31 - 1 so there's no need to make them unsigned.
3357 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3358 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3359 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3360 as modifiers.
3361 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3362
bc827e23
PE
3363 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3364 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3365 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3366 presumably because the widths might not match.
3367
78eb494e
PE
3368 * window.c (size_window): Avoid needless test at loop start.
3369
04f2d78b
CB
33702011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3371
3372 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3373
d2fc7e3d 33742011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3375
3376 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3377
d2fc7e3d 33782011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3379
3380 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3381 `width' to `bar_area_x' and `bar_area_width', respectively.
3382 (x_scroll_run): Take account of fringe background extension.
3383
04f2d78b
CB
3384 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3385 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3386 `bar_area_width', respectively.
3387 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3388 background extension.
3389
79b70037
GM
33902011-05-10 Jim Meyering <meyering@redhat.com>
3391
3392 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3393
2f142cc5
JB
33942011-05-10 Juanma Barranquero <lekktu@gmail.com>
3395
3396 * image.c (Finit_image_library): Return t for built-in image types,
3397 like pbm and xbm. (Bug#8640)
3398
57679c86
AS
33992011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3400
3401 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3402
888c9e86
EZ
34032011-05-07 Eli Zaretskii <eliz@gnu.org>
3404
b0512a1d
EZ
3405 * w32console.c (Fset_screen_color): Doc fix.
3406 (Fget_screen_color): New function.
3407 (syms_of_ntterm): Defsubr it.
3408
7285dc67
EZ
3409 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3410 unlink the temporary file if Fcall_process didn't create it in the
3411 first place.
3412 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3413 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3414 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3415 cue to call_process_cleanup not to close that handle.
3416
4d3fcc8e
BK
34172011-05-07 Ben Key <bkey76@gmail.com>
3418
3419 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3420 one of two shell specific rules, either bootstrap-temacs-CMD or
3421 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3422 to the previous implementation of the bootstrap-temacs rule.
3423 The bootstrap-temacs-CMD rule is similar to the previous
3424 implementation of the bootstrap-temacs rule except that it
3425 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3426 variable.
3427
3428 These changes, along with some changes to nt/configure.bat,
3429 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3430 earlier fix to add support for --cflags and --ldflags options
3431 that include quotes so that it works whether make uses cmd or
3432 sh as the shell.
3433
b4289b64
MA
34342011-05-06 Michael Albinus <michael.albinus@gmx.de>
3435
3436 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3437 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3438 is a constant.
3439 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3440 a string. Handle both cases.
3441 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3442 (Fdbus_register_method): Use Qinvalid_function.
3443
af4c0e28
JB
34442011-05-06 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * makefile.w32-in: Update dependencies.
3447 (LISP_H): Add inttypes.h and stdin.h.
3448 (PROCESS_H): Add unistd.h.
3449
c51453d9
EZ
34502011-05-06 Eli Zaretskii <eliz@gnu.org>
3451
3452 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3453 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3454
8ff0ac3c 34552011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3456
4c4b566b
PE
3457 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3458
aab2b9b5
PE
3459 * term.c (vfatal): Remove stray call to va_end.
3460 It's not needed and the C Standard doesn't allow it here anyway.
3461
c378da0b
PE
3462 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3463 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3464
288b08c7
PE
3465 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3466 bytes.
3467
e3601888
PE
3468 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3469
db6c0e74
PE
3470 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3471
dd5963ea
PE
3472 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3473
88c9450f
PE
3474 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3475
2f9442b8
PE
3476 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3477
c032b5f8
PE
3478 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3479 * charset.c (Fdefine_charset_internal): Don't initialize
3480 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3481 32-bit int (Bug#8600).
a108c10b
PE
3482
3483 * lread.c (read_integer): Be more consistent with string-to-number.
3484 Use string_to_number to do the actual conversion; this avoids
3485 rounding errors and fixes some other screwups. Without this fix,
3486 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3487 (digit_to_number): Move earlier, for benefit of read_integer.
3488 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3489 not a digit in any supported base. (Bug#8602)
a108c10b 3490
ad5f9eea
PE
3491 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3492
aec1708a
PE
3493 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3494 to match comment at start of function. This also removes a
3495 GCC warning about overflow in a 32+64-bit port.
3496
47be4ab5
PE
3497 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3498
371cac43
PE
3499 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3500 Reported by Stefan Monnier in
3501 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3502 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3503 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3504
d01a7826
PE
3505 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3506 (EMACS_UINTPTR): Likewise, with uintptr_t.
3507
7fd47d5c
PE
3508 * lisp.h: Prefer 64-bit EMACS_INT if available.
3509 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3510 on 32-bit hosts that have 64-bit int, so that they can access
3511 large files.
122b0c86
PE
3512 However, temporarily disable this change unless the temporary
3513 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3514
8727937b
PE
3515 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3516
8ac068ac
PE
3517 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3518 This removes an assumption that EMACS_INT and long are the same
3519 width as pointers. The assumption is true for Emacs porting targets
3520 now, but we want to make other targets possible.
3521 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3522 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3523 In the rest of the code, change types of integers that hold casted
3524 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3525 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3526 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3527 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3528 No need to cast type when ORing.
3529 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3530 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3531 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3532 assume EMACS_INT is the same width as char *.
3533 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3534 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3535 Remove no-longer-needed casts.
3536 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3537 (xg_tool_bar_help_callback, xg_make_tool_item):
3538 Use EMACS_INTPTR to hold an integer
3539 that will be cast to void *; this can avoid a GCC warning
3540 if EMACS_INT is not the same width as void *.
3541 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3542 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3543 (current_message_1, set_message_1):
3544 Use a local to convert to proper width without a cast.
3545 * xmenu.c (dialog_selection_callback): Likewise.
3546
ede49d71
PE
3547 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3548 Also, don't assume VALBITS / RAND_BITS is less than 5,
3549 and don't rely on undefined behavior when shifting a 1 left into
3550 the sign bit.
3551 * lisp.h (get_random): Change signature to match.
3552
2f30ecd0
PE
3553 * lread.c (hash_string): Use size_t, not int, for hash computation.
3554 Normally we prefer signed values; but hashing is special, because
3555 it's better to use unsigned division on hash table sizes so that
3556 the remainder is nonnegative. Also, size_t is the natural width
3557 for hashing into memory. The previous code used 'int', which doesn't
3558 retain enough info to hash well into very large tables.
3559 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3560
2a866e7b
PE
3561 * dbusbind.c: Don't possibly lose pointer info when converting.
3562 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3563 Use XPNTR rather than XHASH, so that the high-order bits of
3564 the pointer aren't lost when converting through void *.
3565
51639eac
PE
3566 * eval.c (Fautoload): Don't double-shift a pointer.
3567
92394119
PE
3568 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3569
dbdb9a7c
JB
35702011-05-06 Juanma Barranquero <lekktu@gmail.com>
3571
3572 * gnutls.c (DEF_GNUTLS_FN):
3573 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3574
db7a0b4f
AS
35752011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3576
3577 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3578 marker. (Bug#8610)
3579
f7ff1b0f 35802011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3581
3582 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3583 New version that can reserve upto 2GB of heap space.
3584
f7ff1b0f 35852011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3586
3587 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3588
639c109b
TZ
35892011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3590
3591 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3592 `gnutls_certificate_set_x509_key_file'.
3593
d2127135
JB
35942011-05-05 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3597 Update dependencies.
3598
e968f4f3
JB
35992011-05-04 Juanma Barranquero <lekktu@gmail.com>
3600
3601 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3602 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3603 Remove unused parameter `fildes'.
3604 * process.c (read_process_output, send_process): Don't pass it.
3605
84d358f0
JB
36062011-05-04 Juanma Barranquero <lekktu@gmail.com>
3607
3608 Fix previous change: the library cache is defined in w32.c.
3609 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3610 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3611
0898ca10
JB
36122011-05-04 Juanma Barranquero <lekktu@gmail.com>
3613
3614 Implement dynamic loading of GnuTLS on Windows.
3615
3616 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3617 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3618 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3619 Declare.
3620
3621 * gnutls.c (Qgnutls_dll): Define.
3622 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3623 (gnutls_*): Declare function pointers.
3624 (init_gnutls_functions): New function to initialize function pointers.
3625 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3626 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3627 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3628 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3629 (emacs_gnutls_write, emacs_gnutls_read)
3630 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3631 (Fgnutls_available_p): New function.
3632 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3633 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3634 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3635
3636 * image.c: Include w32.h.
3637 (Vimage_type_cache): Delete.
3638 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3639 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3640 (w32_delayed_load): Move to w32.c.
3641
3642 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3643
3644 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3645 (w32_delayed_load): Move from image.c. When loading a library, record
3646 its filename in the :loaded-from property of the library id.
3647 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3648 Initialize and staticpro them.
3649 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3650
3651 * process.c: Include lisp.h before w32.h, not after.
3652 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3653 instead of gnutls_record_check_pending.
3654
3655 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3656
ff4de4aa
TZ
36572011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3658
3659 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3660 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3661 as passed in.
3662
abe95abb
JD
36632011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3664
3665 * xterm.c (x_set_frame_alpha): Do not set property on anything
3666 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3667
e16e55d4
JB
36682011-05-02 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3671
bafcf6a5
JB
36722011-05-02 Juanma Barranquero <lekktu@gmail.com>
3673
3674 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3675 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3676 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3677 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3678 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3679 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3680 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3681 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3682 (Qgnutls_bootprop_callbacks_verify): Make static.
3683
e7a6747f
AS
36842011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3685
19ed11ba
AS
3686 * callproc.c: Indentation fixup.
3687
e7a6747f 3688 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3689 (wait_for_termination, interruptible_wait_for_termination):
3690 Move after wait_for_termination_1.
e7a6747f 3691
1ef14cb4
LMI
36922011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3693
3694 * sysdep.c (interruptible_wait_for_termination): New function
3695 which is like wait_for_termination, but allows keyboard
3696 interruptions.
3697
3698 * callproc.c (Fcall_process): Add (:file "file") as an option for
3699 the STDOUT buffer.
3700 (Fcall_process_region): Ditto.
3701
330d880c
EZ
37022011-04-30 Eli Zaretskii <eliz@gnu.org>
3703
8db90b73
EZ
3704 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3705 rather than `XVECTOR (FOO)->size'.
3706
330d880c
EZ
3707 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3708 inttypes.h, as a gnulib replacement is used if it not available in
3709 system headers.
3710
15cbd324
EZ
37112011-04-21 Eli Zaretskii <eliz@gnu.org>
3712
3713 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3714 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3715 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3716
3717 * coding.c (coding_alloc_by_realloc): Error out if destination
3718 will grow beyond MOST_POSITIVE_FIXNUM.
3719 (decode_coding_emacs_mule): Abort if there isn't enough place in
3720 charbuf for the composition carryover bytes. Reserve an extra
3721 space for up to 2 characters produced in a loop.
3722 (decode_coding_iso_2022): Abort if there isn't enough place in
3723 charbuf for the composition carryover bytes.
3724
37252011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3726
ae940cca
EZ
3727 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3728 aborting when %lld or %lll format is passed.
3729 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3730 %llo or %llx format is passed. (Bug#8545)
3731
03ab8921
EZ
3732 * window.c (window_scroll_line_based): Use a marker instead of
3733 simple variables to record original value of point. (Bug#7952)
3734
afda1437
EZ
3735 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3736 produced by %s or %c overflows available buffer space. (Bug#8545)
3737
f76dee0c
PE
37382011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3741 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3742
fdc5744d
JB
37432011-04-28 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3746
638f053a
JB
37472011-04-28 Juanma Barranquero <lekktu@gmail.com>
3748
3749 * keyboard.c (Qdelayed_warnings_hook): Define.
3750 (command_loop_1): Run `delayed-warnings-hook'
3751 if Vdelayed_warnings_list is non-nil.
3752 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3753 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3754
d178f871
EZ
37552011-04-28 Eli Zaretskii <eliz@gnu.org>
3756
3757 * doprnt.c (doprnt): Don't return value smaller than the buffer
3758 size if the message was truncated. (Bug#8545).
3759
b124fd93
JB
37602011-04-28 Juanma Barranquero <lekktu@gmail.com>
3761
3762 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3763 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3764
e810457d
PE
37652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3768
ea51cceb
JB
37692011-04-27 Juanma Barranquero <lekktu@gmail.com>
3770
3771 * makefile.w32-in: Update dependencies.
3772
94dcfacf
EZ
37732011-04-27 Eli Zaretskii <eliz@gnu.org>
3774
3775 Improve `doprnt' and its usage. (Bug#8545)
3776 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3777 `format_end'. Remove support for %l as a conversion specifier.
3778 Don't use xrealloc. Improve diagnostics when the %l size modifier
3779 is used. Update the commentary.
3780
3781 * eval.c (verror): Simplify calculation of size_t.
3782
3783 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3784 messages.
3785
f61f41d7
PE
37862011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3787
3788 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3789 change.
3790
96fb4434
PE
37912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3794 This makes this file independent of the recent pseudovector change.
3795
671875da 37962011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3797
69e9b5a3
PE
3798 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3799
b5f869a7 3800 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3801 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3802 Remove unused local.
c8926152 3803 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3804
841a1577 3805 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3806 GCC 4.6.0 optimizes based on type-based alias analysis.
3807 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3808 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3809 != &v->size, and therefore "v->size = 1; b->size = 2; return
3810 v->size;" must therefore return 1. This assumption is incorrect
3811 for Emacs, since it type-puns struct Lisp_Vector * with many other
3812 types. To fix this problem, this patch adds a new type struct
f904488f 3813 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3814 and pseudovectors, and helps optimizing compilers not get fooled
3815 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3816 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3817 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3818 the size member.
eab3844f
PE
3819 (XSETPVECTYPE): Rewrite in terms of new macro.
3820 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3821 This is a bit clearer, and further avoids the possibility of
3822 undesirable aliasing.
3823 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3824 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3825 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3826 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3827 (ASIZE): Now uses header.size rather than size.
3828 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3829 to avoid the hassle of writing XVECTOR (foo)->header.size.
3830 (struct vectorlike_header): New type.
eab3844f
PE
3831 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3832 object, to help avoid aliasing.
3833 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3834 (SUBRP): Likewise, since Lisp_Subr is a special case.
3835 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3836 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3837 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3838 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3839 changed to be "header.size" and "header.next".
3840 * buffer.h (struct buffer): Likewise.
3841 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3842 * frame.h (struct frame): Likewise.
3843 * process.h (struct Lisp_Process): Likewise.
3844 * termhooks.h (struct terminal): Likewise.
3845 * window.c (struct save_window_data, struct saved_window): Likewise.
3846 * window.h (struct window): Likewise.
3847 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3848 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3849 * buffer.c (init_buffer_once): Likewise.
3850 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3851 special case.
3852 * process.c (Fformat_network_address): Use local var for size,
3853 for brevity.
3854
0df1eac5
PE
3855 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3856
847ab9d1 3857 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3858 * data.c (atof): Remove decl; no longer used or needed.
3859 (digit_to_number): Move to lread.c.
3860 (Fstring_to_number): Use new string_to_number function, to be
3861 consistent with how the Lisp reader treats infinities and NaNs.
3862 Do not assume that floating-point numbers represent EMACS_INT
3863 without losing information; this is not true on most 64-bit hosts.
3864 Avoid double-rounding errors, by insisting on integers when
3865 parsing non-base-10 numbers, as the documentation specifies.
3866 * lisp.h (string_to_number): New decl, replacing ...
3867 (isfloat_string): Remove.
bc0a5c13 3868 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3869 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3870 appears to have been a coding error. Similarly, do not accept
3871 strings like +-1e0 as floating point numbers. Do not report
3872 overflow for integer overflows unless the base is not 10 which
3873 means we have no simple and reliable way to continue.
3874 Break out the floating-point parsing into a new
3875 function string_to_number, so that Fstring_to_number parses
3876 floating point numbers consistently with the Lisp reader.
04f2d78b 3877 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3878 (E_CHAR, EXP_INT): Remove, replacing with ...
3879 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3880 (string_to_number): New function, replacing isfloat_string.
3881 This function checks for valid syntax and produces the resulting
3882 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3883 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3884 so that overflow for non-base-10 numbers is reported only when
3885 there's no portable and simple way to convert to floating point.
452f4150 3886
67769ffc
PE
3887 * textprop.c (set_text_properties_1): Rewrite for clarity,
3888 and to avoid GCC warning about integer overflow.
3889
c20db43f
PE
3890 * intervals.h (struct interval): Use EMACS_INT for members
3891 where EMACS_UINT might cause problems. See
3892 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3893 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3894 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3895 All uses changed.
37aa2f85
PE
3896 (offset_intervals): Tell GCC not to worry about length overflow
3897 when negating a negative length.
c20db43f 3898
2538aa2f
PE
3899 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3900 (overrun_check_free): Likewise.
3901
f2d3008d
PE
3902 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3903 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3904 word size.
3905
ec8df744
PE
3906 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3907 (gnutls_make_error): Rename local to avoid shadowing.
3908 (gnutls_emacs_global_deinit): ifdef out; not used.
3909 (Fgnutls_boot): Use const for pointer to readonly storage.
3910 Comment out unused local. Fix pointer signedness problems.
3911
640ee02d
PE
3912 * lread.c (openp): Don't stuff size_t into an 'int'.
3913 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3914 about possible signed overflow.
3915
6048fb2a
PE
3916 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3917 (GDK_KEY_g): Don't define if already defined.
3918 (xg_prepare_tooltip): Avoid pointer signedness problem.
3919 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3920
fa3c87e1
PE
3921 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3922 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3923
2172544b
PE
3924 * xfns.c (Fx_window_property): Simplify a bit,
3925 to make a bit faster and to avoid GCC 4.6.0 warning.
3926 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3927
9b821a21
PE
3928 * fns.c (internal_equal): Don't assume size_t fits in int.
3929
3c616cfa
PE
3930 * alloc.c (compact_small_strings): Tighten assertion a little.
3931
c2982e87
PE
3932 Replace pEd with more-general pI, and fix some printf arg casts.
3933 * lisp.h (pI): New macro, generalizing old pEd macro to other
3934 conversion specifiers. For example, use "...%"pI"d..." rather
3935 than "...%"pEd"...".
3936 (pEd): Remove. All uses replaced with similar uses of pI.
3937 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3938 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3939 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3940 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3941 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3942 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3943 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3944 64-bit hosts.
3945 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3946 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3947 * print.c (safe_debug_print, print_object): Likewise.
3948 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3949 to int.
6f04d126
PE
3950 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3951 avoiding the 0 flag, which is not portable.
c2982e87
PE
3952 * process.c (Fmake_network_process): Use pI to avoid cast.
3953 * region-cache.c (pp_cache): Likewise.
3954 * xdisp.c (decode_mode_spec): Likewise.
3955 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3956 behavior on 64-bit hosts with printf arg.
6f04d126 3957 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3958 (x_stop_queuing_selection_requests): Likewise.
3959 (x_get_window_property): Don't truncate byte count to an 'int'
3960 when tracing.
0b432f21 3961
5e073ec7
PE
3962 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3963 here, since it parses constructs like leading '-' and spaces,
3964 which are not wanted; and it overflows with large numbers.
3965 Instead, simply match F[0-9]+, which is what is wanted anyway.
3966
36372bf9
PE
3967 * alloc.c: Remove unportable assumptions about struct layout.
3968 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3969 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3970 (allocate_vectorlike, make_pure_vector): Use the new macros,
3971 plus offsetof, to remove unportable assumptions about struct layout.
3972 These assumptions hold on all porting targets that I know of, but
3973 they are not guaranteed, they're easy to remove, and removing them
3974 makes further changes easier.
3975
0b432f21
PE
3976 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3977 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3978 (string_overrun_cookie): Now const. Use initializers that
3979 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3980 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3981 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3982 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3983 multiple of sizeof (EMACS_INT); it need not be, if
3984 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3985 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3986
895009e1
JB
39872011-04-26 Juanma Barranquero <lekktu@gmail.com>
3988
3989 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3990
6a7a1b0b
TZ
39912011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3992
3993 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3994 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3995 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3996
841a1577 39972011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3998
3999 * lisp.h (Qdebug): List symbol.
895009e1 4000 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4001 * keyboard.c (debug-on-event): New variable.
4002 (handle_user_signal): Break into debugger when debug-on-event
4003 matches the current signal symbol.
4004
f2d3ba6f
DN
40052011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4006
4007 * alloc.c (check_sblock, check_string_bytes)
4008 (check_string_free_list): Convert to standard C.
4009
42ce4c63
TZ
40102011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4011
4012 * w32.c (emacs_gnutls_push): Fix typo.
4013
825cd63c
EZ
40142011-04-25 Eli Zaretskii <eliz@gnu.org>
4015
fb11d64d
EZ
4016 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4017 "cast to pointer from integer of different size".
4018
825cd63c
EZ
4019 Improve doprnt and its use in verror. (Bug#8545)
4020 * doprnt.c (doprnt): Document the set of format control sequences
4021 supported by the function. Use SAFE_ALLOCA instead of always
4022 using `alloca'.
4023
4024 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4025 is one byte too soon. Don't use xrealloc; instead xfree and
4026 xmalloc anew.
4027
e061a11b
TZ
40282011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4029
4030 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4031 callbacks stage.
4032
4033 * gnutls.c: Renamed global_initialized to
4034 gnutls_global_initialized. Added internals for the
4035 :verify-hostname-error, :verify-error, and :verify-flags
4036 parameters of `gnutls-boot' and documented those parameters in the
4037 docstring. Start callback support.
9173deec
JB
4038 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4039 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4040 on error. Return error code.
e061a11b
TZ
4041 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4042 (emacs_gnutls_read): Likewise.
4043 (Fgnutls_boot): Return handshake error code.
4044 (emacs_gnutls_handle_error): New function.
4045 (wsaerror_to_errno): Likewise.
4046
4047 * w32.h (emacs_gnutls_pull): Add prototype.
4048 (emacs_gnutls_push): Likewise.
4049
4050 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4051 (emacs_gnutls_push): Likewise.
4052
40532011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4054
4055 * process.c (wait_reading_process_output): Check if GnuTLS
4056 buffered some data internally if no FDs are set for TLS
4057 connections.
4058
4059 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4060 (LIBS): Link to USER_LIBS.
4061 ($(BLD)/gnutls.$(0)): New target.
4062
fa6996bc
EZ
40632011-04-24 Eli Zaretskii <eliz@gnu.org>
4064
eb35682e
EZ
4065 * xdisp.c (handle_single_display_spec): Rename the
4066 display_replaced_before_p argument into display_replaced_p, to
4067 make it consistent with the commentary. Fix typos in the
4068 commentary.
4069
e2ad650c
EZ
4070 * textprop.c (syms_of_textprop): Remove dead code.
4071 (copy_text_properties): Delete obsolete commentary about an
4072 interface that was deleted long ago. Fix typos in the description
4073 of arguments.
4074
1b2de274
EZ
4075 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4076 to changes in oldXMenu/XMenu.h from 2011-04-16.
4077 <menu_help_message, prev_menu_help_message>: Constify.
4078 (IT_menu_make_room): menu->help_text is now `const char **';
4079 adjust.
4080
4081 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4082 to changes in oldXMenu/XMenu.h from 2011-04-16.
4083 (struct XMenu): Declare `help_text' `const char **'.
4084
4085 * xfaces.c <Qunspecified>: Make extern again.
4086
4087 * syntax.c: Include sys/types.h before including regex.h, as
4088 required by Posix.
4089
762b15be
EZ
4090 * doc.c (get_doc_string): Improve the format passed to `error'.
4091
4092 * doprnt.c (doprnt): Improve commentary.
4093
4094 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4095
4096 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4097 them with etags.
4098
f1052e5d
EZ
4099 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4100 changes in globals.h immediately force recompilation.
762b15be
EZ
4101 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4102 $(CURDIR)/s/ms-w32.h.
4103 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4104
fa6996bc
EZ
4105 * character.c (Fchar_direction): Function deleted.
4106 (syms_of_character): Don't defsubr it.
4107 <char-direction-table>: Deleted.
4108
e6c3da20
EZ
41092011-04-23 Eli Zaretskii <eliz@gnu.org>
4110
4111 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4112 * doprnt.c: Include limits.h.
4113 (SIZE_MAX): New macro.
04f2d78b
CB
4114 (doprnt): Return a size_t value. 2nd arg is now size_t.
4115 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4116 Improve overflow protection. Support `l' modifier for integer
4117 conversions. Support %l conversion. Don't assume an EMACS_INT
4118 argument for integer conversions and for %c.
4119
4120 * lisp.h (doprnt): Restore prototype.
4121
4122 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4123 $(SRC)/character.h.
4124
4125 * Makefile.in (base_obj): Add back doprnt.o.
4126
4127 * deps.mk (doprnt.o): Add back prerequisites.
4128 (callint.o): Depend on character.h.
4129
4130 * eval.c (internal_lisp_condition_case): Include the handler
4131 representation in the error message.
4132 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4133 when breaking from the loop.
4134
4135 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4136
4137 * callint.c (Fcall_interactively): When displaying error message
4138 about invalid control letter, pass the character's codepoint, not
4139 a pointer to its multibyte form. Improve display of the character
4140 in octal and display also its hex code.
4141
4142 * character.c (char_string): Use %x to display the (unsigned)
4143 codepoint of an invalid character, to avoid displaying a bogus
4144 negative value.
4145
4146 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4147 `error', not SYMBOL_NAME itself.
4148
4149 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4150 character arguments to `error'.
4151
4152 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4153 to `error' in error message about FINAL_CHAR argument. Make sure
4154 FINAL_CHAR is a character, and use %c when it is passed as
4155 argument to `error'.
4156
4ffd0d6b 41572011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4158
4159 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4160
4161 * w32.c: Include <time.h>.
4162 (sys_localtime): New function.
4163
4ffd0d6b 41642011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4165
4166 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4167
4ffd0d6b 4168 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4169
4ffd0d6b 41702011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4171
4ffd0d6b
GM
4172 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4173 zombies (Bug#8467).
aac0c6e3 4174
04c56954
EZ
41752011-04-19 Eli Zaretskii <eliz@gnu.org>
4176
4177 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4178 gl_state.e_property when gl_state.object is Qt.
4179
4180 * insdel.c (make_gap_larger): Remove limitation of buffer size
4181 to <= INT_MAX.
4182
16a43933
CY
41832011-04-18 Chong Yidong <cyd@stupidchicken.com>
4184
4185 * xdisp.c (lookup_glyphless_char_display)
4186 (produce_glyphless_glyph): Handle cons cell entry in
4187 glyphless-char-display.
4188 (Vglyphless_char_display): Document it.
4189
4190 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4191 glyphless-char-display.
4192
4581706e
CY
41932011-04-17 Chong Yidong <cyd@stupidchicken.com>
4194
4195 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4196
4197 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4198
4199 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4200 definition for no-X builds.
4201
4887c6e2 42022011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4203
fd35b6f9
PE
4204 Static checks with GCC 4.6.0 and non-default toolkits.
4205
5c1ccb01
PE
4206 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4207
006c5daa
PE
4208 * process.c (keyboard_bit_set): Define only if SIGIO.
4209 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4210 (send_process): Repair possible setjmp clobbering.
4211
efc736d3
PE
4212 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4213
4e2fe2e6
PE
4214 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4215
f97334a2
PE
4216 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4217
4e75f29d
PE
4218 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4219 Define only if needed.
4220
90efadd1
PE
4221 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4222 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4223 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4224
3c647824
PE
4225 * dispextern.h (struct redisplay_interface): Rename param
4226 to avoid shadowing.
e264f262 4227 * termhooks.h (struct terminal): Likewise.
761383f4 4228 * xterm.c (xembed_send_message): Likewise.
3c647824 4229
b58c5c4a
PE
4230 * insdel.c (make_gap_smaller): Define only if
4231 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4232
cad59032
PE
4233 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4234 it.
4235
c339dc2e
PE
4236 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4237 so that we aren't warned about unused symbols.
4238
91a3e27b
PE
4239 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4240
399c71d3 4241 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4242
8ffc96f5
PE
4243 * xfns.c (x_real_positions): Mark locals as initialized.
4244
eef9bc79
PE
4245 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4246
098db9dd
PE
4247 * xterm.c: Fix problems found by static analysis with other toolkits.
4248 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4249 (x_dispatch_event): Declare static if USE_GTK, and
4250 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4251 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4252 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4253 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4254 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4255
eb18f6cc
PE
4256 * xmenu.c (menu_help_callback): Pointer type fixes.
4257 Use const pointers when pointing at readonly data. Avoid pointer
4258 signedness clashes.
4259 (FALSE): Remove unused macro.
4260 (update_frame_menubar): Remove unused decl.
4261
1fe72bf8
PE
4262 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4263
60d9e1db
PE
4264 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4265 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4266 (single_menu_item): Rename local to avoid shadowing.
4267
39261c26
PE
4268 * keyboard.c (make_lispy_event): Remove unused local var.
4269
018c5e19
PE
4270 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4271 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4272
63d2b86e
PE
4273 * bitmaps: Change bitmaps from unsigned char back to the X11
4274 compatible char. Avoid the old compiler warnings about
4275 out-of-range initializers by using, for example, '\xab' rather
4276 than 0xab.
4277
aefd87e1
PE
4278 * xgselect.c (xgselect_initialize): Check vs interface
4279 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4280
bf501fb9
PE
4281 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4282
e9829fdf
PE
4283 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4284 to read-only memory.
4285
1086c095
PE
4286 * fns.c (vector): Remove; this old hack is no longer needed.
4287
2baccd04 4288 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4289 Remove unused var.
dde42981 4290 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4291
72391843 4292 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4293
436c16df 4294 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4295 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4296 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4297
92bb796d 4298 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4299 (x_term_init): Remove local to avoid shadowing.
92bb796d 4300
764430a3 4301 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4302
4303 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4304 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4305
d1dfb56c
EZ
43062011-04-16 Eli Zaretskii <eliz@gnu.org>
4307
c4354cb4
EZ
4308 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4309
d1dfb56c
EZ
4310 Fix regex.c, syntax.c and friends for buffers > 2GB.
4311 * syntax.h (struct gl_state_s): Declare character position members
4312 EMACS_INT.
4313
4314 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4315
04f2d78b
CB
4316 * textprop.c (verify_interval_modification, interval_of):
4317 Declare arguments EMACS_INT.
d1dfb56c
EZ
4318
4319 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4320 EMACS_INT.
4321
4322 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4323
4324 * indent.c (Fvertical_motion): Local variable it_start is now
4325 EMACS_INT.
4326
4327 * regex.c (re_match, re_match_2, re_match_2_internal)
4328 (bcmp_translate, regcomp, regexec, print_double_string)
4329 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4330 (re_compile_pattern, re_exec): Declare arguments and local
4331 variables `size_t' and `ssize_t' and return values `regoff_t', as
4332 appropriate.
4333 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4334 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4335 <compile_stack_type>: `size' and `avail' are now `size_t'.
4336
4337 * regex.h <regoff_t>: Use ssize_t, not int.
4338 (re_search, re_search_2, re_match, re_match_2): Arguments that
4339 specify buffer/string position and length are now ssize_t and
4340 size_t. Return type is regoff_t.
4341
613052cd
BK
43422011-04-16 Ben Key <bkey76@gmail.com>
4343
4344 * nsfont.m: Fixed bugs in ns_get_family and
4345 ns_descriptor_to_entity that were caused by using free to
4346 deallocate memory blocks that were allocated by xmalloc (via
4347 xstrdup). This caused Emacs to crash when compiled with
4348 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4349 --enable-checking=xmallocoverrun). xfree is now used to
4350 deallocate these memory blocks.
4351
4170f62f 43522011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4353
71b41406
PE
4354 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4355
9587a89d
PE
4356 emacs_write: Accept and return EMACS_INT for sizes.
4357 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4358 et seq.
4359 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4360 Accept and return EMACS_INT.
4361 (emacs_gnutls_write): Return the number of bytes written on
4362 partial writes.
4363 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4364 (emacs_read, emacs_write): Remove check for negative size, as the
4365 Emacs source code has been audited now.
9587a89d
PE
4366 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4367 (emacs_read, emacs_write): Use it.
273a5f82
PE
4368 * process.c (send_process): Adjust to the new signatures of
4369 emacs_write and emacs_gnutls_write. Do not attempt to store
4370 a byte offset into an 'int'; it might overflow.
9587a89d 4371 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4372
3e047f51
PE
4373 * sound.c: Don't assume sizes fit in 'int'.
4374 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4375 Return EMACS_INT, not int.
3e047f51 4376 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4377 Accept EMACS_INT, not int.
4378 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4379 record read return values.
4380
cc39a9db
BK
43812011-04-15 Ben Key <bkey76@gmail.com>
4382
c9d0ec6d
JB
4383 * keyboard.c (Qundefined): Don't declare static since it is used
4384 in nsfns.m.
4385 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4386 static since they are used in nsfont.m.
cc39a9db 4387
6c60eb9f
SM
43882011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4389
4390 * process.c (Qprocessp): Don't declare static.
4391 * lisp.h (Qprocessp): Declare again.
4392
7990b61a
JB
43932011-04-15 Juanma Barranquero <lekktu@gmail.com>
4394
4395 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4396
5d4cb038
PE
43972011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4398
8bd7b830 4399 Improve C-level modularity by making more things 'static'.
cd64ea1d 4400
e3b27b31
PE
4401 Don't publish debugger-only interfaces to other modules.
4402 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4403 (verify_bytepos, count_markers): Move decls to the only modules
4404 that need them.
4405 * region-cache.h (pp_cache): Likewise.
4406 * window.h (check_all_windows): Likewise.
4407 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4408
5d4cb038
PE
4409 * sysdep.c (croak): Now static, if
4410 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4411 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4412
4413 * alloc.c (refill_memory_reserve): Now static if
4414 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4415 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4416
e87b6180
PE
4417 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4418 Define only if USE_LUCID.
4419
ac64929e
PE
4420 * xrdb.c (x_customization_string, x_rm_string): Now static.
4421
6f37259d
PE
4422 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4423 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4424
1683e3ab
PE
4425 * xdisp.c (draw_row_with_mouse_face): Now static.
4426 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4427
de9c2632
PE
4428 * window.h (check_all_windows): Mark externally visible.
4429
2b96acb7
PE
4430 * window.c (window_deletion_count): Now static.
4431
4432 * undo.c: Make symbols static if they're not exported.
4433 (last_undo_buffer, last_boundary_position, pending_boundary):
4434 Now static.
4435
50436f33
PE
4436 * textprop.c (interval_insert_behind_hooks): Now static.
4437 (interval_insert_in_front_hooks): Likewise.
4438
64520e5c
PE
4439 * term.c: Make symbols static if they're not exported.
4440 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4441 (max_frame_lines, tty_set_terminal_modes):
4442 (tty_reset_terminal_modes, tty_turn_off_highlight):
4443 (get_tty_terminal): Now static.
4444 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4445 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4446 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4447 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4448 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4449
1fa53021
PE
4450 * sysdep.c: Make symbols static if they're not exported.
4451 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4452 Now static.
4453 (sigprocmask_set, full_mask): Remove; unused.
4454 (wait_debugging): Mark as visible.
4455 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4456 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4457
d4b43b22
PE
4458 * syntax.c (syntax_temp): Define only if !__GNUC__.
4459
b7c513d0
PE
4460 * sound.c (current_sound_device, current_sound): Now static.
4461
989b29ad
PE
4462 * search.c (searchbufs, searchbuf_head): Now static.
4463
13a55a78
PE
4464 * scroll.c (scroll_cost): Remove; unused.
4465 * dispextern.h (scroll_cost): Remove decl.
4466
de68a1fc
PE
4467 * region-cache.h (pp_cache): Mark as externally visible.
4468
40ccffa6
PE
4469 * process.c: Make symbols static if they're not exported.
4470 (process_tick, update_tick, create_process, chan_process):
4471 (Vprocess_alist, proc_buffered_char, datagram_access):
4472 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4473 (deactivate_process): Mark defn as static, as well as decl.
4474 * lisp.h (create_process): Remove decl.
4475 * process.h (chan_process, Vprocess_alist): Remove decls.
4476
ad64fc97
PE
4477 * print.c: Make symbols static if they're not exported.
4478 (print_depth, new_backquote_output, being_printed, print_buffer):
4479 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4480 (print_interval, print_number_index, initial_stderr_stream):
4481 Now static.
4482 * lisp.h (Fprinc): Remove decl.
4483 (debug_output_compilation_hack): Mark as externally visible.
4484
adddb265
PE
4485 * sysdep.c (croak): Move decl from here to syssignal.h.
4486 * syssignal.h (croak): Put it here, so the API can be checked when
4487 'croak' is called from dissociate_if_controlling_tty.
4488
1717ede2
PE
4489 * minibuf.c: Make symbols static if they're not exported.
4490 (minibuf_save_list, choose_minibuf_frame): Now static.
4491 * lisp.h (choose_minibuf_frame): Remove decl.
4492
fa5fb2bc
PE
4493 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4494
1e3890d1
PE
4495 * lread.c: Make symbols static if they're not exported.
4496 (read_objects, initial_obarray, oblookup_last_bucket_number):
4497 Now static.
4498 (make_symbol): Remove; unused.
4499 * lisp.h (initial_obarray, make_symbol): Remove decls.
4500
8a1414fa
PE
4501 * keyboard.c: Make symbols static if they're not exported.
4502 (single_kboard, recent_keys_index, total_keys, recent_keys):
4503 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4504 (this_single_command_key_start, echoing, last_auto_save):
4505 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4506 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4507 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4508 (Vlispy_mouse_stem, double_click_count):
4509 Now static.
4510 (force_auto_save_soon): Define only if SIGDANGER.
4511 (ignore_mouse_drag_p): Now static if
4512 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4513 (print_help): Remove; unused.
4514 (stop_character, last_timer_event): Mark as externally visible.
4515 * keyboard.h (ignore_mouse_drag_p): Declare only if
4516 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4517 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4518 * lisp.h (echoing): Remove decl.
4519 (force_auto_save_soon): Declare only if SIGDANGER.
4520 * xdisp.c (redisplay_window): Simplify code, to make it more
4521 obvious that ignore_mouse_drag_p is not accessed if !defined
4522 USE_GTK && !defined HAVE_NS.
4523
93ea6e8f
PE
4524 * intervals.c: Make symbols static if they're not exported.
4525 (merge_properties_sticky, merge_interval_right, delete_interval):
4526 Now static.
4527 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4528
77382fcc
PE
4529 * insdel.c: Make symbols static if they're not exported.
4530 However, leave prepare_to_modify_buffer alone. It's never
4531 called from outside this function, but that appears to be a bug.
4532 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4533 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4534 (adjust_after_replace_noundo): Remove; unused.
4535 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4536 (signal_before_change): Remove decls.
77382fcc 4537
9306c32e
PE
4538 * indent.c (val_compute_motion, val_vmotion): Now static.
4539
cd44d2eb
PE
4540 * image.c: Make symbols static if they're not exported.
4541 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4542 if USE_GTK.
4543 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4544 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4545
ad9a7a06
PE
4546 * fringe.c (standard_bitmaps): Now static.
4547 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4548
81626931
PE
4549 * frame.c: Make symbols static if they're not exported.
4550 (x_report_frame_params, make_terminal_frame): Now static.
4551 (get_frame_param): Now static, unless HAVE_NS.
4552 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4553 (x_get_resource_string): Remove; not used.
4554 * frame.h (make_terminal_frame, x_report_frame_params):
4555 (x_get_resource_string); Remove decls.
4556 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4557 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4558
239f9db9
PE
4559 * font.c, fontset.c: Make symbols static if they're not exported.
4560 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4561 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4562 * font.c (font_close_object): Now static.
4563 * font.h (font_close_object): Remove.
4564 * fontset.c (FONTSET_OBJLIST): Remove.
4565 (free_realized_fontset) #if-0 the body, which does nothing.
4566 (face_suitable_for_char_p): #if-0, as it's never called.
4567 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4568 * xfaces.c (face_at_string_position):
4569 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4570 since 0 is always ASCII.
4571
dfcf3579
PE
4572 * fns.c (weak_hash_tables): Now static.
4573
5045092b
PE
4574 * fileio.c: Make symbols static if they're not exported.
4575 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4576 (Vwrite_region_annotation_buffers): Now static.
4577
57a96f5c
PE
4578 * eval.c: Make symbols static if they're not exported.
4579 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4580 * lisp.h (backtrace_list): Remove decl.
4581
35f08c38
PE
4582 * emacs.c: Make symbols static if they're not exported.
4583 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4584 (fatal_error_code, fatal_error_signal_hook, standard_args):
4585 Now static.
4586 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4587 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4588 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4589 * lisp.h (fatal_error_signal_hook): Remove decl.
4590 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4591
f44bd759
PE
4592 * editfns.c: Move a (normally-unused) function to its only use.
4593 * editfns.c, lisp.h (get_operating_system_release): Remove.
4594 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4595 worth the hassle of breaking this out.
4596
b532497d
PE
4597 * xterm.c: Make symbols static if they're not exported.
4598 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4599 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4600 (x_destroy_window, x_delete_display):
4601 Now static.
4602 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4603 (x_mouse_leave): Remove; unused.
4604 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4605 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4606 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4607 Remove decls.
4608 (x_mouse_leave): Declare only if WINDOWSNT.
4609 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4610 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4611 USE_X_TOOLKIT.
4612
1675728f
PE
4613 * ftxfont.c: Make symbols static if they're not exported.
4614 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4615 HAVE_FREETYPE.
4616 * font.h (ftxfont_driver): Likewise.
4617
e4cebfca
PE
4618 * xfns.c: Make symbols static if they're not exported.
4619 (x_last_font_name, x_display_info_for_name):
4620 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4621 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4622 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4623 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4624 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4625 (last_show_tip_args): Now static.
4626 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4627 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4628 (x_screen_planes): Remove; unused.
4629 * dispextern.h (x_screen_planes): Remove decl.
4630
5bf46f05
PE
4631 * dispnew.c: Make symbols static if they're not exported.
4632 * dispextern.h (redraw_garbaged_frames, scrolling):
4633 (increment_row_positions): Remove.
4634 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4635 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4636 Now static.
4637 (redraw_garbaged_frames): Remove; unused.
4638
435f4c28
PE
4639 * xfaces.c: Make symbols static if they're not exported.
4640 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4641 Remove decls.
4642 * xterm.h (defined_color): Remove decls.
4643 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4644 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4645 (menu_face_changed_default, defined_color, free_realized_face):
4646 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4647 (ascii_face_of_lisp_face): Remove; unused.
4648
8524aef3
PE
4649 * xdisp.c: Make symbols static if they're not exported.
4650 * dispextern.h (scratch_glyph_row, window_box_edges):
4651 (glyph_to_pixel_coords, set_cursor_from_row):
4652 (get_next_display_element, set_iterator_to_next):
4653 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4654 (show_mouse_face): Remove decls
4655 * frame.h (message_buf_print): Likewise.
4656 * lisp.h (pop_message, set_message, check_point_in_composition):
4657 Likewise.
4658 * xterm.h (set_vertical_scroll_bar): Likewise.
4659 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4660 (message_buf_print, scratch_glyph_row, displayed_buffer):
4661 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4662 (get_next_display_element, show_mouse_face, window_box_edges):
4663 (frame_to_window_pixel_xy, check_point_in_composition):
4664 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4665 (glyph_to_pixel_coords): Remove; unused.
4666
16390cd2
PE
4667 * dired.c (file_name_completion): Now static.
4668
4669 * dbusbind.c (xd_in_read_queued_messages): Now static.
4670
a25f4dfa
PE
4671 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4672 * data.c (circular_list_error): Remove.
4673
14a9c8df
PE
4674 * commands.h (last_point_position, last_point_position_buffer):
4675 (last_point_position_window): Remove decls.
4676 * keyboard.c: Make these variables static.
4677
04f2d78b
CB
4678 * coding.h (coding, code_convert_region, encode_coding_gap):
4679 Remove decls.
74ab6df5
PE
4680 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4681 (iso_code_class, detect_coding, code_convert_region): Now static.
4682 (encode_coding_gap): Remove; unused.
4683
38dfbee1
PE
4684 * chartab.c (chartab_chars, chartab_bits): Now static.
4685
a2cb4e63
PE
4686 * charset.h (charset_iso_8859_1): Remove decl.
4687 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4688 Now static.
4689
127198fd
PE
4690 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4691 * ccl.c (Vccl_program_table): Now static.
4692 (check_ccl_update): Remove; unused.
4693
d85b608f
PE
4694 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4695 * category.h: ... from here.
4696 * category.c (check_category_table, set_category_set): Now static.
4697
31cd66f3
PE
4698 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4699 * lisp.h: Remove these decls.
4700
c358e587
PE
4701 * buffer.c (buffer_count): Remove unused var.
4702
e78aecca
PE
4703 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4704 so that it's not optimized away.
4705 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4706 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4707 exported only to the debugger.
4708
e192d7d3 4709 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4710 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4711
92470028
PE
4712 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4713 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4714 was inaccessible from Lisp.
4715 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4716 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4717
244ed907
PE
4718 alloc.c: Import and export fewer symbols, and remove unused items.
4719 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4720 is defined.
4721 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4722 it's not optimized away by whole-program optimization.
4723 (message_enable_multibyte, free_misc): Remove.
4724 (catchlist, handlerlist, mark_backtrace):
4725 Declare only if BYTE_MARK_STACK.
4726 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4727 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4728 (message_enable_multibyte): Remove decl.
4729 (free_misc, interval_free_list, float_block, float_block_index):
4730 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4731 (cons_free_list, last_marked_index):
4732 Now static.
4733 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4734 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4735 (mark_backtrace): Define only if BYTE_MARK_STACK.
4736 * xdisp.c (message_enable_multibyte): Now static.
4737
61c2b50e 4738 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4739 This makes it easier for human readers (and static analyzers)
4740 to see whether these variables are used from other modules.
4741 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4742 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4743 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4744 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4745 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4746 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4747 * xmenu.c, xselect.c:
4748 Declare Q* vars static if they are not used in other modules.
4749 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4750 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4751 Remove decls of unexported vars.
4752 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4753
95c82688
PE
4754 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4755
16a97296
PE
4756 Make Emacs functions such as Fatom 'static' by default.
4757 This makes it easier for human readers (and static analyzers)
4758 to see whether these functions can be called from other modules.
4759 DEFUN now defines a static function. To make the function external
4760 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4761 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4762 (Finit_image_library):
16a97296
PE
4763 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4764 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4765 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4766 Remove decls, since these functions are now static.
4767 (Funintern, Fget_internal_run_time): New decls, since these functions
4768 were already external.
95c82688 4769
16a97296
PE
4770 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4771 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4772 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4773 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4774 * keyboard.c, keymap.c, lread.c:
4775 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4776 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4777 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4778 Mark functions with DEFUE instead of DEFUN,
4779 if they are used in other modules.
4780 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4781 decls for now-static functions.
4782 * buffer.h (Fdelete_overlay): Remove decl.
4783 * callproc.c (Fgetenv_internal): Mark as internal.
4784 * composite.c (Fremove_list_of_text_properties): Remove decl.
4785 (Fcomposition_get_gstring): New forward static decl.
4786 * composite.h (Fcomposite_get_gstring): Remove decl.
4787 * dired.c (Ffile_attributes): New forward static decl.
4788 * doc.c (Fdocumntation_property): New forward static decl.
4789 * eval.c (Ffetch_bytecode): New forward static decl.
4790 (Funintern): Remove extern decl; now in .h file where it belongs.
4791 * fileio.c (Fmake_symbolic_link): New forward static decl.
4792 * image.c (Finit_image_library): New forward static decl.
4793 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4794 * intervals.h (Fprevious_property_change):
4795 (Fremove_list_of_text_properties): Remove decls.
4796 * keyboard.c (Fthis_command_keys): Remove decl.
4797 (Fcommand_execute): New forward static decl.
4798 * keymap.c (Flookup_key): New forward static decl.
4799 (Fcopy_keymap): Now static.
4800 * keymap.h (Flookup_key): Remove decl.
4801 * process.c (Fget_process): New forward static decl.
4802 (Fprocess_datagram_address): Mark as internal.
4803 * syntax.c (Fsyntax_table_p): New forward static decl.
4804 (skip_chars): Remove duplicate decl.
4805 * textprop.c (Fprevious_property_change): New forward static decl.
4806 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4807 Now internal.
4808 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4809 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4810
785bbd42
PE
4811 * editfns.c (Fformat): Remove unreachable code.
4812
8b913b57
AS
48132011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4814
4815 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4816 change. (Bug#8496)
4817
a6744a35
EZ
48182011-04-13 Eli Zaretskii <eliz@gnu.org>
4819
4820 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4821 when at ZV. (Bug#8487)
4822
e7974947
AS
48232011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4824
baad03f0
AS
4825 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4826 (Bug#8437)
4827 * keyboard.c (parse_tool_bar_item): Likewise.
4828 * sound.c (sound_cleanup, alsa_close): Likewise.
4829 * termcap.c (tgetent): Likewise.
4830 * xfns.c (x_default_font_parameter): Likewise.
4831 * xsettings.c (read_and_apply_settings): Likewise.
4832
e7974947
AS
4833 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4834 (overrun_check_free): Protoize.
4835
28272684
PE
48362011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4839 since callers should never pass a negative size.
4840 Change the signature to match that of plain 'read' and 'write'; see
4841 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4842 * lisp.h: Update prototypes of emacs_write and emacs_read.
4843
11997c76
EZ
48442011-04-11 Eli Zaretskii <eliz@gnu.org>
4845
4846 * xdisp.c (redisplay_window): Don't try to determine the character
4847 position of the scroll margin if the window start point w->startp
e896f03c 4848 is outside the buffer's accessible region. (Bug#8468)
11997c76 4849
8a2cbd72
EZ
48502011-04-10 Eli Zaretskii <eliz@gnu.org>
4851
4852 Fix write-region and its subroutines for buffers > 2GB.
4853 * fileio.c (a_write, e_write): Modify declaration of arguments and
4854 local variables to support buffers larger than 2GB.
4855 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4856
4857 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4858 argument, local variables, and return value.
4859
4860 * lisp.h: Update prototypes of emacs_write and emacs_read.
4861
4862 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4863
4073e537 48642011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4865
1ebfdcb6
PE
4866 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4867
b2ded58d
PE
4868 Fix more problems found by GCC 4.6.0's static checks.
4869
7d66342c
PE
4870 * xdisp.c (vmessage): Use a better test for character truncation.
4871
bbf47d44
PE
4872 * charset.c (load_charset_map): <, not <=, for optimization,
4873 and to avoid potential problems with integer overflow.
9248994d 4874 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4875 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4876 * editfns.c (Fformat): Likewise.
1e69125e 4877 * syntax.c (skip_chars): Likewise.
3befa583 4878
e3019616
PE
4879 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4880 This also lets GCC 4.6.0 generate slightly better loop code.
4881
becfa255
PE
4882 * callint.c (Fcall_interactively): <, not <=, for optimization.
4883 (Fcall_interactively): Count the number of arguments produced,
4884 not the number of arguments given. This is simpler and lets GCC
4885 4.6.0 generate slightly better code.
4886
dae0cd48
PE
4887 * ftfont.c: Distingish more carefully between FcChar8 and char.
4888 The previous code passed unsigned char * to a functions like
4889 strlen and xstrcasecmp that expect char *, which does not
4890 conform to the C standard.
4891 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4892 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4893 char * when the C standard requires it.
4894
76032d70
PE
4895 * keyboard.c (read_char): Remove unused var.
4896
eb3f1cc8
PE
4897 * eval.c: Port to Windows vsnprintf (Bug#8435).
4898 Include <limits.h>.
4899 (SIZE_MAX): Define if the headers do not.
4900 (verror): Do not give up if vsnprintf returns a negative count.
4901 Instead, grow the buffer. This ports to Windows vsnprintf, which
4902 does not conform to C99. Problem reported by Eli Zaretskii.
4903 Also, simplify the allocation scheme, by avoiding the need for
4904 calling realloc, and removing the ALLOCATED variable.
4905
70476b54
PE
4906 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4907
12020a9e
PE
4908 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4909 But keep the doprint source code for now, as we might revamp it
4910 and use it again (Bug#8435).
ea6c7ae6
PE
4911 * lisp.h (doprnt): Remove.
4912 * Makefile.in (base_obj): Remove doprnt.o.
4913 * deps.mk (doprnt.o): Remove.
4914
5fdb398c
PE
4915 error: Print 32- and 64-bit integers portably (Bug#8435).
4916 Without this change, on typical 64-bit hosts error ("...%d...", N)
4917 was used to print both 32- and 64-bit integers N, which relied on
4918 undefined behavior.
4919 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4920 New macro.
4921 * lisp.h (error, verror): Mark as printf-like functions.
4922 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4923 Report overflow in size calculations when allocating printf buffer.
4924 Do not truncate output string at its first null byte.
4925 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4926 Truncate the output at a character boundary, since vsnprintf does not
4927 do that.
4928 * charset.c (check_iso_charset_parameter): Convert internal
4929 character to string before calling 'error', since %c now has the
4930 printf meaning.
4931 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4932 overflow when computing char to be passed to 'error'. Do not
4933 pass Lisp_Object to 'error'; pass the integer instead.
4934 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4935 formatted with plain %d.
4936
b189fa66
PE
4937 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4938
bff87ef0
PE
4939 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4940
7e2cac20
PE
4941 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4942
ce4d90b5
PE
4943 * xterm.c (x_catch_errors): Remove duplicate declaration.
4944
266c9547
PE
4945 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4946
79c49ad2
PE
4947 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4948
368f4090
JM
49492011-04-10 Jim Meyering <meyering@redhat.com>
4950
4951 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4952 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4953 return ssize_t not "int", and use size_t as the buffer length.
4954 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4955 * gnutls.h: Update declarations.
4956 * process.c (read_process_output): Use ssize_t, to match.
4957 (send_process): Likewise.
4958
a32d4040
CY
49592011-04-09 Chong Yidong <cyd@stupidchicken.com>
4960
4961 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4962
8546720e 49632011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4964
04f2d78b
CB
4965 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4966 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4967
8546720e
GM
4968 * xterm.c (handle_one_xevent):
4969 * xmenu.c (create_and_show_popup_menu):
4970 * xselect.c (x_decline_selection_request)
4971 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4972
0a2f5c1a 49732011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4974
4975 Fix some uses of `int' instead of EMACS_INT.
4976 * search.c (string_match_1, fast_string_match)
4977 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4978 (scan_buffer, find_next_newline_no_quit)
4979 (find_before_next_newline, search_command, Freplace_match)
4980 (Fmatch_data): Make some `int' variables be EMACS_INT.
4981
4982 * xdisp.c (display_count_lines): 3rd argument and return value now
4983 EMACS_INT. All callers changed.
4984 (pint2hrstr): Last argument is now EMACS_INT.
4985
4986 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4987 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4988 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4989 (decode_coding_utf_16, decode_coding_emacs_mule)
4990 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4991 (decode_coding_ccl, decode_coding_charset)
4992 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4993 (decode_coding_iso_2022, decode_coding_emacs_mule)
4994 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4995 <char_offset, last_offset>: Declare EMACS_INT.
4996 (encode_coding_utf_8, encode_coding_utf_16)
4997 (encode_coding_emacs_mule, encode_invocation_designation)
4998 (encode_designation_at_bol, encode_coding_iso_2022)
4999 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5000 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5001 Declare EMACS_INT.
5002 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5003 (encode_invocation_designation): Last argument P_NCHARS is now
5004 EMACS_INT.
5005 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5006 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5007
5008 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5009 All users changed.
5010
5011 * ccl.c (Fccl_execute_on_string): Declare some variables
5012 EMACS_INT.
5013
8546720e 50142011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5015
5016 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5017
4e19a977
CS
50182011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5019
5020 * process.c (Fformat_network_address): Doc fix.
5021
87302331
R
50222011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5023
5024 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5025
cbb59342
CY
50262011-04-08 Chong Yidong <cyd@stupidchicken.com>
5027
5028 * keyboard.c (read_char): Call Lisp function help-form-show,
5029 instead of using internal_with_output_to_temp_buffer.
5030 (Qhelp_form_show): New var.
e0d38eeb 5031 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5032
5033 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5034
5035 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5036
e67a13ab
CY
50372011-04-06 Chong Yidong <cyd@stupidchicken.com>
5038
04f2d78b
CB
5039 * process.c (Flist_processes): Remove to Lisp.
5040 (list_processes_1): Delete.
e67a13ab 5041
973f782d
EZ
50422011-04-06 Eli Zaretskii <eliz@gnu.org>
5043
7c106b1e
EZ
5044 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5045
973f782d
EZ
5046 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5047
41cf7d1a 50482011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5049
ca23cc88
PE
5050 Fix more problems found by GCC 4.6.0's static checks.
5051
f390e2d5
PE
5052 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5053
42eea0d0
PE
5054 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5055
b69769da 5056 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5057
f9541e84
PE
5058 * xdisp.c (vmessage): Mark as a printf-like function.
5059
13841b55
PE
5060 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5061
c136c10f
PE
5062 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5063
5e2d4a30
PE
5064 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5065 printf-like functions.
5066 (tiff_load): Add casts to remove these marks before passing them
5067 to system-supplied API.
5068
583f48b9
PE
5069 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5070
b25d760e
PE
5071 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5072 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5073 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5074 directly, rather than having caller test rule sign. This avoids
5075 some unnecessary tests.
5076 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5077 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5078 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5079
bc7b6697 5080 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5081 (xfont_open): Avoid unnecessary tests.
bc7b6697 5082
27ccc379
PE
5083 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5084
dcd5c89a
PE
5085 * composite.h, composite.c (composition_gstring_put_cache):
5086 Use EMACS_INT, not int, for length.
5087
b13a45c6
PE
5088 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5089 breaking out part of COMPOSITION_DECODE_RULE.
5090 (COMPOSITION_DECODE_RULE): Use it.
5091 * composite.c (get_composition_id): Remove unused local vars,
5092 by using the new macro.
5093
1e792e4d
PE
5094 * textprop.c (set_text_properties_1): Change while to do-while,
5095 since the condition is always true at first.
5096
dc6c6455 5097 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5098 (interval_deletion_adjustment): Return unsigned value.
5099 All uses changed.
dc6c6455 5100
aba7731a
PE
5101 * process.c (list_processes_1, create_pty, read_process_output):
5102 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5103 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5104 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5105 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5106 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5107
fdfc4bf3
PE
5108 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5109
fca8fe46 5110 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5111 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5112
06a0259a 5113 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5114 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5115 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5116
e7b9e80f
PE
5117 * print.c (print_error_message): Avoid int overflow.
5118
56201685
PE
5119 * font.c (font_list_entities): Redo for clarity,
5120 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5121
78834453 5122 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5123 (font_score): Avoid potential overflow in diff calculation.
78834453 5124
0bc0b309 5125 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5126 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5127
e610eaca
PE
5128 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5129
b895abce
PE
5130 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5131 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5132 can always succeed if overflow has undefined behavior.
5133
1f1d9321 5134 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5135 (wordify): Omit three unnecessary tests.
1f1d9321 5136
c59478bc
PE
5137 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5138 All callers changed. This avoids the need for an unused var.
5139
79b73827
PE
5140 * casefiddle.c (casify_region): Remove var that is set but not used.
5141
a4db5dfe
PE
5142 * dired.c (file_name_completion): Remove var that is set but not used.
5143
43aae36e
PE
5144 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5145
2a47c44d 5146 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5147 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5148
a37c69bf
PE
5149 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5150 Check for integer overflow on size calculations.
5151
328ab8e7
PE
5152 * buffer.c (Fprevious_overlay_change): Remove var that is set
5153 but not used.
5154
e5a2a5cb
PE
5155 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5156 Remove vars that are set but not used.
8d84a6eb 5157 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5158 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5159
a60e5f68
PE
5160 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5161
f661cb61 5162 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5163 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5164
f0397f5a
PE
5165 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5166 that are set but not used.
5167
8664db06 5168 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5169 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5170
6abdaa4a
PE
5171 * xselect.c (x_get_local_selection, x_handle_property_notify):
5172 Remove vars that are set but not used.
5173
0ce7538d 5174 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5175 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5176
9ae848fc
PE
5177 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5178 Remove var that is set but not used.
0b918413
PE
5179 (scroll_bar_windows_size): Now size_t, not int.
5180 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5181 Check for overflow.
9ae848fc 5182
a5a62657
PE
5183 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5184 (map_tty_color) [!defined MSDOS]: Likewise.
5185
5c5cdd39
PE
5186 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5187
66ebf983
PE
5188 * coding.c: Remove vars that are set but not used.
5189 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5190 All callers changed.
5191 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5192 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5193 (decode_coding_charset): Remove vars that are set but not used.
5194
1be4d761
PE
5195 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5196 that is set but not used.
5197
47553fa8
PE
5198 * print.c (print_object): Remove var that is set but not used.
5199
1f7196bf 5200 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5201 The gnulib version avoids calling malloc in the usual case,
5202 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5203 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5204 * filelock.c (current_lock_owner): Likewise.
5205 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5206 * sysdep.c: Include allocator.h, careadlinkat.h.
5207 (emacs_no_realloc_allocator): New static constant.
5208 (emacs_readlink): New function.
fdb61804
PE
5209 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5210 ../lib/careadlinkat.h.
d1fdcab7 5211
f84c17c7
SM
52122011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5213
5214 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5215 first non-nil return value).
5216
ef3862ad
JD
52172011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5218
5219 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5220 if not defined (Bug#8403).
5221
376a7006
JB
52222011-04-02 Juanma Barranquero <lekktu@gmail.com>
5223
5224 * xdisp.c (display_count_lines): Remove parameter `start',
5225 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5226 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5227 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5228 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5229 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5230 and thereabouts. All callers changed.
5231 (get_per_char_metric): Remove parameter `f', unused since
5232 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5233
6ca3801d
JM
52342011-04-02 Jim Meyering <meyering@redhat.com>
5235
5236 do not dereference NULL upon failed strdup
5237 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5238 (ns_get_family): Likewise.
5239
d8e2b5ba
JB
52402011-04-02 Juanma Barranquero <lekktu@gmail.com>
5241
5242 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5243
8c74fcbd
JD
52442011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5245
5246 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5247 later (Bug#8403).
5248
7200d79c
SM
52492011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5250
03408648 5251 Add lexical binding.
7200d79c 5252
03408648
SM
5253 * window.c (Ftemp_output_buffer_show): New fun.
5254 (Fsave_window_excursion):
5255 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5256
5257 * lread.c (lisp_file_lexically_bound_p): New function.
5258 (Fload): Bind Qlexical_binding.
5259 (readevalloop): Remove `evalfun' arg.
5260 Bind Qinternal_interpreter_environment.
5261 (Feval_buffer): Bind Qlexical_binding.
5262 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5263 Mark as dynamic.
5264 (syms_of_lread): Declare `lexical-binding'.
5265
5266 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5267
5268 * keyboard.c (eval_dyn): New fun.
5269 (menu_item_eval_property): Use it.
ca105506
SM
5270
5271 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5272
03408648
SM
5273 * fns.c (concat, mapcar1): Accept byte-code-functions.
5274
5275 * eval.c (Fsetq): Handle lexical vars.
5276 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5277 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5278 (FletX, Flet): Obey lexical binding.
5279 (Fcommandp): Handle closures.
5280 (Feval): New `lexical' arg.
5281 (eval_sub): New function extracted from Feval. Use it almost
5282 everywhere where Feval was used. Look up vars in lexical env.
5283 Handle closures.
5284 (Ffunctionp): Move from subr.el.
5285 (Ffuncall): Handle closures.
5286 (apply_lambda): Remove `eval_flags'.
5287 (funcall_lambda): Handle closures and new byte-code-functions.
5288 (Fspecial_variable_p): New function.
5289 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5290 but without exporting it to Lisp.
23aba0ea 5291
23aba0ea 5292 * doc.c (Fdocumentation, store_function_docstring):
03408648 5293 * data.c (Finteractive_form): Handle closures.
23aba0ea 5294
03408648
SM
5295 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5296 interactive spec.
ba83908c 5297
04f2d78b
CB
5298 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5299 New byte-codes.
03408648
SM
5300 (exec_byte_code): New function extracted from Fbyte_code to handle new
5301 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5302
03408648 5303 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5304
03408648 5305 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5306
e2abce01
JB
53072011-03-31 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * xdisp.c (redisplay_internal): Fix prototype.
5310
63696a73 53112011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5312
63696a73 5313 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5314 (try_scrolling): Use it when setting scroll_limit.
5315 Limit scrolling to 100 screen lines.
63696a73
EZ
5316 (redisplay_window): Even when falling back on "recentering",
5317 position point in the window according to scroll-conservatively,
5318 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5319
5320 (try_scrolling): When point is above the window, allow searching
5321 as far as scroll_max, or one screenful, to compute vertical
5322 distance from PT to the scroll margin position. This prevents
5323 try_scrolling from unnecessarily failing when
5324 scroll-conservatively is set to a value slightly larger than the
5325 window height. Clean up the case of PT below the margin at bottom
5326 of window: scroll_max can no longer be INT_MAX. When aggressive
5327 scrolling is in use, don't let point enter the opposite scroll
5328 margin as result of the scroll.
5329 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5330 threshold of 100 lines for never-recentering scrolling.
5331
e4cc2dfc
JB
53322011-03-31 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * dispextern.h (move_it_by_lines):
5335 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5336 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5337 (message_log_check_duplicate): Remove parameters `prev_bol' and
5338 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5339 (redisplay_internal): Remove parameter `preserve_echo_area',
5340 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5341
5342 * indent.c (Fvertical_motion):
5343 * window.c (window_scroll_pixel_based, Frecenter):
5344 Don't pass `need_y_p' to `move_it_by_lines'.
5345
1c470562
SM
53462011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5347
44f230aa
SM
5348 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5349 steal a few bits to be more compact.
5350 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5351 Remove unneeded casts.
5352
1c470562
SM
5353 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5354
888adce9
ZK
53552011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5356
5357 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5358 binding" message (bug#7967).
5359
f838ed7b
PE
53602011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5361
77861b95
PE
5362 Fix more problems found by GCC 4.6.0's static checks.
5363
de6dbc14
PE
5364 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5365 Remove unused local var.
5366
f838ed7b
PE
5367 * editfns.c (Fmessage_box): Remove unused local var.
5368
792c7b2b
PE
5369 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5370 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5371 Omit unused local vars.
c499e557 5372 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5373 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5374 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5375 Omit unused local var.
5376
ba0165e1
PE
5377 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5378 Don't assume string length fits in int.
32ad8845 5379 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5380 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5381
3c59b4c9
PE
5382 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5383 instead of alloca (Bug#8344).
5384
a3eed478 5385 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5386 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5387
eb4d412d
PE
5388 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5389
1658b401
PE
5390 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5391 concerns.
5392
5393 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5394
5395 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5396
9a2c6e05
PE
5397 * keyboard.c (syms_of_keyboard): Use the same style as later
5398 in this function when indexing through an array. This also
5399 works around GCC bug 48267.
5400
03d0a109
PE
5401 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5402
44f730c8
PE
5403 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5404
fe75f926
PE
5405 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5406 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5407
ffa8c828
PE
5408 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5409 This avoids undefined behavior on integer overflow, and is a bit
5410 more convenient anyway since it is compared to a size_t variable.
5411
c5101a77
PE
5412 Variadic C functions now count arguments with size_t, not int.
5413 This avoids an unnecessary limitation on 64-bit machines, which
5414 caused (substring ...) to crash on large vectors (Bug#8344).
5415 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5416 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5417 All variadic functions and their callers changed accordingly.
c5101a77
PE
5418 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5419 * data.c (arith_driver, float_arith_driver): Likewise.
5420 * editfns.c (general_insert_function): Likewise.
5421 * eval.c (struct backtrace.nargs, interactive_p)
5422 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5423 (funcall_lambda, mark_backtrace): Likewise.
5424 * fns.c (concat): Likewise.
5425 * frame.c (x_set_frame_parameters): Likewise.
5426 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5427 0 if not found, not -1. All callers changed.
5428
dd3f25f7
PE
5429 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5430 (stack_copy_size): Now size_t, not int.
5431 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5432
461c2ab9
JB
54332011-03-28 Juanma Barranquero <lekktu@gmail.com>
5434
5435 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5436 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5437 All callers changed.
5438
5439 * lisp.h (multibyte_char_to_unibyte):
5440 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5441 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5442 * character.h (CHAR_TO_BYTE8):
5443 * cmds.c (internal_self_insert):
5444 * editfns.c (general_insert_function):
5445 * keymap.c (push_key_description):
5446 * search.c (Freplace_match):
5447 * xdisp.c (message_dolog, set_message_1): All callers changed.
5448
f6d62986
SM
54492011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5450
5451 * keyboard.c (safe_run_hook_funcall): New function.
5452 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5453 don't set the hook to nil, but remove the offending function instead.
5454 (Qcommand_hook_internal): Remove, unused.
5455 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5456 Vcommand_hook_internal.
5457
5458 * eval.c (enum run_hooks_condition): Remove.
5459 (funcall_nil, funcall_not): New functions.
5460 (run_hook_with_args): Call each function through a `funcall' argument.
5461 Remove `cond' argument, now redundant.
5462 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5463 (Frun_hook_with_args_until_failure): Adjust accordingly.
5464 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5465
1db5b1ad
JB
54662011-03-28 Juanma Barranquero <lekktu@gmail.com>
5467
5468 * dispextern.h (string_buffer_position): Remove declaration.
5469
5470 * print.c (strout): Remove parameter `multibyte', unused since
5471 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5472
5473 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5474 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5475 All callers changed.
5476
5477 * w32.c (_wsa_errlist): Use braces for struct initializers.
5478
5479 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5480 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5481 All callers changed.
5482 (string_buffer_position): Likewise. Also, make static (it's never
5483 used outside xdisp.c).
5484 (cursor_row_p): Remove parameter `w', unused since
5485 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5486 (decode_mode_spec): Remove parameter `precision', introduced during
5487 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5488 All callers changed.
5489
5ffb62aa
JD
54902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5491
5492 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5493
461c2ab9 54942011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5495
5496 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5497 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5498 (ns_update_auto_hide_menu_bar): New functions.
5499 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5500 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5501 ns_constrain_all_frames.
5502 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5503 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5504
5c380ffb
JD
55052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5506
5507 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5508
9af30bdf
GM
55092011-03-27 Glenn Morris <rgm@gnu.org>
5510
5511 * syssignal.h: Replace RETSIGTYPE with void.
5512 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5513 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5514 Replace SIGTYPE with void everywhere.
5515 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5516 * s/template.h (SIGTYPE): Remove commented out definition.
5517
e2abce01
JB
55182011-03-26 Eli Zaretskii <eliz@gnu.org>
5519
5520 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5521 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5522
f868cd8a
JB
55232011-03-26 Juanma Barranquero <lekktu@gmail.com>
5524
59eb0929
JB
5525 * w32.c (read_unc_volume): Use parameter `henum', instead of
5526 global variable `wget_enum_handle'.
5527
5528 * keymap.c (describe_vector): Remove parameters `indices' and
5529 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5530 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5531
f868cd8a
JB
5532 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5533
5534 * keyboard.c (timer_check): Remove parameter `do_it_now',
5535 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5536 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5537 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5538
5539 * keyboard.c (read_char):
5540 * w32menu.c (w32_menu_display_help):
5541 * xmenu.c (show_help_event, menu_help_callback):
5542 Adjust calls to `show_help_echo'.
5543
5544 * gtkutil.c (xg_maybe_add_timer):
5545 * keyboard.c (readable_events):
5546 * process.c (wait_reading_process_output):
5547 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5548
5549 * insdel.c (adjust_markers_gap_motion):
5550 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5551 (gap_left, gap_right): Don't call it.
5552
2ecf6fdb
CY
55532011-03-25 Chong Yidong <cyd@stupidchicken.com>
5554
5555 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5556 incurred during fontification.
5557
6b1f9ba4
JB
55582011-03-25 Juanma Barranquero <lekktu@gmail.com>
5559
5560 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5561 (DEFVAR_PER_BUFFER): Don't pass it.
5562
5563 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5564 (scrolling_window): Don't pass it.
5565
0f4a96b5
JB
55662011-03-25 Juanma Barranquero <lekktu@gmail.com>
5567
5568 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5569
5570 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5571 and `suffix'.
5572 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5573 of variables specific to SELinux and computation of `encoded_absname'.
5574
5575 * image.c (XPutPixel): Remove unused variable `height'.
5576
5577 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5578
5579 * unexw32.c (get_section_info): Remove unused variable `section'.
5580
5581 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5582 (system_process_attributes): Remove unused variable `sess'.
5583 (sys_read): Remove unused variable `err'.
5584
5585 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5586 (w32_wnd_proc): Remove unused variable `isdead'.
5587 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5588 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5589 (x_create_tip_frame): Remove unused variable `tem'.
5590
5591 * w32inevt.c (w32_console_read_socket):
5592 Remove unused variable `no_events'.
5593
5594 * w32term.c (x_draw_composite_glyph_string_foreground):
5595 Remove unused variable `width'.
5596
1149507c
JB
55972011-03-24 Juanma Barranquero <lekktu@gmail.com>
5598
5599 * w32term.c (x_set_glyph_string_clipping):
5600 Don't pass uninitialized region to CombineRgn.
5601
9c88f339
JB
56022011-03-23 Juanma Barranquero <lekktu@gmail.com>
5603
5604 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5605 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5606 (Fx_close_connection): Remove unused variable `i'.
5607
5608 * w32font.c (w32font_draw): Return number of glyphs.
5609 (w32font_open_internal): Remove unused variable `i'.
5610 (w32font_driver): Add missing initializer.
5611
5612 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5613 (fill_in_menu): Remove unused variable `items_added'.
5614
5615 * w32term.c (last_mouse_press_frame): Remove static global variable.
5616 (w32_clip_to_row): Remove unused variable `f'.
5617 (x_delete_terminal): Remove unused variable `i'.
5618
5619 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5620 (NOTHING): Remove unused static global variable.
5621 (uniscribe_check_otf): Remove unused variable `table'.
5622 (uniscribe_font_driver): Add missing initializers.
5623
dee091a3
JD
56242011-03-23 Julien Danjou <julien@danjou.info>
5625
5626 * term.c (Fsuspend_tty, Fresume_tty):
5627 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5628 * window.c (temp_output_buffer_show):
5629 * insdel.c (signal_before_change):
5630 * frame.c (Fhandle_switch_frame):
5631 * fileio.c (Fdo_auto_save):
5632 * emacs.c (Fkill_emacs):
5633 * editfns.c (save_excursion_restore):
5634 * cmds.c (internal_self_insert):
5635 * callint.c (Fcall_interactively):
5636 * buffer.c (Fkill_all_local_variables):
5637 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5638 Use Frun_hooks.
0f4a96b5 5639 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5640 unconditionnaly since it does the check itself.
5641
2c520ab5 56422011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5643
c9c49752
PE
5644 Fix more problems found by GCC 4.5.2's static checks.
5645
8abc3f12
PE
5646 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5647 the first time through the loop, since we know p0 < p1 then.
5648 This also avoids a gcc -Wstrict-overflow warning.
5649
a2d26660
PE
5650 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5651 leading to a memory leak, possible in functions like
5652 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5653 of objects (Bug#8318).
a2d26660 5654
916c72e9
PE
5655 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5656 that could (at least in theory) be that large.
5657
19ab8a18
PE
5658 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5659 This is less likely to overflow, and avoids undefined behavior if
5660 overflow does occur. All callers changed. Use strtoul to scan
5661 for the unsigned long integer.
b7cbbd6f
PE
5662 (pint2hrstr): Simplify and tune code slightly.
5663 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5664
f0641eff
PE
5665 * scroll.c (do_scrolling): Work around GCC bug 48228.
5666 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5667
7f650bb9
PE
5668 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5669 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5670 (validate_x_resource_name): Simplify count usage.
5671 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5672
37dd57d1
PE
5673 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5674 fail (Bug#8306).
81e56e61 5675
699979fc 5676 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5677
401bf9b4
PE
5678 * process.c (Fmake_network_process): Use socklen_t, not int,
5679 where POSIX says socklen_t is required in portable programs.
5680 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5681 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5682 (Fmake_network_process, server_accept_connection):
5683 (wait_reading_process_output, read_process_output):
5684 Likewise.
5685
b93aacde
PE
5686 * process.c: Rename or move locals to avoid shadowing.
5687 (list_processes_1, Fmake_network_process):
5688 (read_process_output_error_handler, exec_sentinel_error_handler):
5689 Rename or move locals.
4dc343ee 5690 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5691 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5692 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5693 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5694 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5695
af8a867c 5696 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5697 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5698 Include tparam.h instead, since it declares them.
af8a867c
PE
5699 * cm.h (PC): Remove extern decl; tparam.h now does this.
5700 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5701 * terminfo.c: Include tparam.h, to check interfaces.
5702 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5703 (tparam): Adjust signature to match interface in tparam.h;
5704 this removes some undefined behavior. Check that outstring and len
5705 are zero, which they always are with Emacs.
5706 * tparam.h (PC, BC, UP): New extern decls.
5707
0248044d 5708 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5709 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5710
8ff096c1 5711 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5712 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5713 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5714 (ftfont_list): Remove unused local.
49eaafba
PE
5715 (get_adstyle_property, ftfont_pattern_entity):
5716 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5717 Rename locals to avoid shadowing.
8ff096c1 5718
e2be39f6
PE
5719 * xfont.c (xfont_list_family): Mark var as initialized.
5720
c9735e30
PE
5721 * xml.c (make_dom): Now static.
5722
8f5201ae
PE
5723 * composite.c (composition_compute_stop_pos): Rename local to
5724 avoid shadowing.
b246f932
PE
5725 (composition_reseat_it): Remove unused locals.
5726 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5727 (composition_update_it): Mark var as initialized.
11b61122
PE
5728 (find_automatic_composition): Mark vars as initialized,
5729 with a FIXME (Bug#8290).
8f5201ae 5730
760fbc2c
PE
5731 character.h: Rename locals to avoid shadowing.
5732 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5733 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5734 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5735 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5736 to avoid shadowing.
5737
ff08eb85
PE
5738 * textprop.c (property_change_between_p): Remove; unused.
5739
fc7bf025
PE
5740 * intervals.c (interval_start_pos): Now static.
5741
235d7abc
PE
5742 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5743
44f230aa
SM
5744 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5745 Rename locals to avoid shadowing.
3e7d6594 5746
50060332
PE
5747 * sound.c (wav_play, au_play, Fplay_sound_internal):
5748 Fix pointer signedness.
d01f234b 5749 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5750 (wav_play): Initialize a variable to 0, to prevent undefined
5751 behavior (Bug#8278).
50060332 5752
c4fc4e30
PE
5753 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5754
918436ed
PE
5755 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5756
c939f91b
PE
5757 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5758 clobbering (Bug#8298).
b9c7f648
PE
5759 * sysdep.c (sys_subshell): Likewise.
5760 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5761
6bd8c144
PE
5762 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5763 This should get cleaned up, so that child_setup has the
5764 same signature on all platforms.
5765
7710357c 5766 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5767 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5768
c59da222
CY
57692011-03-22 Chong Yidong <cyd@stupidchicken.com>
5770
5771 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5772 not to be necessary, and produces flickering.
5773
66b87493
GM
57742011-03-20 Glenn Morris <rgm@gnu.org>
5775
5776 * config.in: Remove file.
5777
45b6f6d5
JB
57782011-03-20 Juanma Barranquero <lekktu@gmail.com>
5779
5780 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5781 are now in src/globals.h.
5782 (syms_of_minibuf): Remove spurious & from previous change.
5783
3ec03f7e
LL
57842011-03-20 Leo <sdl.web@gmail.com>
5785
5786 * minibuf.c (completing-read-function): New variable.
5787 (completing-read-default): Rename from completing-read.
5788 (completing-read): Call completing-read-function.
5789
b14e3e21
CY
57902011-03-19 Juanma Barranquero <lekktu@gmail.com>
5791
5792 * xfaces.c (Fx_load_color_file):
5793 Read color file from absolute filename (bug#8250).
5794
f2b726e6
JB
57952011-03-19 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * makefile.w32-in: Update dependencies.
5798
09f6ff02
EZ
57992011-03-17 Eli Zaretskii <eliz@gnu.org>
5800
5801 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5802
29a6015a
PE
58032011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5804
a3a6c54e
PE
5805 Fix more problems found by GCC 4.5.2's static checks.
5806
b766f867
PE
5807 * process.c (make_serial_process_unwind, send_process_trap):
5808 (sigchld_handler): Now static.
5809
be02381c
PE
5810 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5811 That way, the code declares only the vars that it needs.
5812 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5813 * s/cygwin.h (PTY_ITERATION): Likewise.
5814 * s/darwin.h (PTY_ITERATION): Likewise.
5815 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5816
57048744
PE
5817 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5818 * process.c (allocate_pty): Don't declare stb unless it's needed.
5819
7914961c 5820 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5821 (CONSTANTLIM): Remove; unused.
5822 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5823 Define only if needed.
7914961c 5824
b3967b18
PE
5825 * unexelf.c (unexec): Name an expression,
5826 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5827 Use a different way to cause a compilation error if anyone uses
5828 n rather than nn, a way that does not involve shadowing.
73366a00 5829 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5830
29a6015a
PE
5831 * deps.mk (unexalpha.o): Remove; unused.
5832
43cfc33e 5833 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5834 * unexec.h: New file.
ce701a33
PE
5835 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5836 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5837 Depend on unexec.h.
5838 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5839 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5840 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5841 Change as necessary to match prototype in unexec.h.
ce701a33 5842
01f44d5a
PE
5843 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5844 shadowing.
4f63c6bb 5845 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5846
a6670b0b
PE
5847 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5848 Rename locals to avoid shadowing.
5849
cef2010d 5850 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5851 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5852
d4d7173a
PE
5853 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5854
f08b802a
PE
5855 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5856 warning when compiling print.c.
5857
3ddb0639
PE
5858 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5859 instead of using an uninitialized var.
5ad03b97 5860 (font_sort_entities): Mark var as initialized.
3ddb0639 5861
170a2692
PE
5862 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5863
e663c700
PE
5864 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5865 pointers to constants.
89bc529a 5866 (font_parse_fcname): Remove unused vars.
7b81e2d0 5867 (font_delete_unmatched): Now static.
ea838e10 5868 (font_get_spec): Remove; unused.
13a547c6
PE
5869 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5870 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5871 Rename or move locals to avoid shadowing.
e663c700 5872
2a80c887 5873 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5874 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5875
1384fa33 5876 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5877 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5878
8b2c52e9
PE
5879 * alloc.c (mark_backtrace): Move decl from here ...
5880 * lisp.h: ... to here, so that it can be checked.
5881
475545b5 5882 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5883 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5884 (lisp_indirect_variable): Name an expression,
5885 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5886 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5887
b1349114 5888 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5889 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5890 Use const pointer when appropriate.
b1349114 5891
a2928364
PE
5892 * lisp.h (get_system_name, get_operating_system_release):
5893 Move decls here, to check interfaces.
5894 * process.c (get_operating_system_release): Move decl to lisp.h.
5895 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5896 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5897 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5898 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5899 (Fformat_time_string, Fencode_time, Finsert_char):
5900 (Ftranslate_region_internal, Fformat):
5901 Rename or remove local vars to avoid shadowing.
9710023e 5902 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5903
a415e694
PE
5904 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5905 avoid shadowing.
5906
8ef4622d
PE
5907 * lisp.h (eassert): Check that the argument compiles, even if
5908 ENABLE_CHECKING is not defined.
5909
946f9a5b
PE
5910 * data.c (Findirect_variable): Name an expression, to avoid
5911 gcc -Wbad-function-cast warning.
112396d6 5912 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5913 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5914 (Fmake_variable_buffer_local, Fmake_local_variable):
5915 Mark variables as initialized.
52746918 5916 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5917
e5aab7e7 5918 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5919 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5920 Rename locals to avoid shadowing.
dff45157
PE
5921 (mark_stack): Move local variables into the #ifdef region where
5922 they're used.
7bc26fdb
PE
5923 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5924 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5925 needed otherwise.
5926 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5927 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5928 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5929
e5aab7e7
PE
5930 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5931 avoids undefined behavior in theory.
5932
4da60324
PE
5933 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5934
88043301
PE
5935 Use functions, not macros, for up- and down-casing (Bug#8254).
5936 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5937 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5938 to use the following functions instead of these macros.
5939 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5940 EMACS_INT, since callers assume the returned value fits in int.
5941 (upcase1): Likewise, for UPCASE_TABLE.
5942 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5943 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5944 the race-condition problem in the old DOWNCASE.
88043301 5945
19ed5445
PE
5946 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5947 Rename locals to avoid shadowing.
5948 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5949 (regex_compile, re_search_2, re_match_2_internal):
5950 Remove unused local vars.
952db0d7
PE
5951 (FREE_VAR): Rewrite so as not to use empty "else",
5952 which gcc can warn about.
da053e48 5953 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5954 (RETALLOC_IF): Define only if needed.
5955 (WORDCHAR_P): Likewise. This one is never needed, but is used
5956 only in a comment talking about a compiler bug, so put inside
5957 the #if 0 of that comment.
5958 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5959 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5960 Remove; unused.
19ed5445 5961
1f3561e4 5962 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5963 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5964 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5965
ded6f8f7
PE
5966 * search.c (simple_search): Remove unused var.
5967
dbd37a95
PE
5968 * dired.c (compile_pattern): Move decl from here ...
5969 * lisp.h: ... to here, so that it can be checked.
5970 (struct re_registers): New forward decl.
5971
7e47afad
PE
5972 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5973
85f24f61
PE
5974 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5975 All uses changed.
5976 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5977 Rename locals to avoid shadowing.
5671df8f 5978 (Fvertical_motion): Mark locals as initialized.
85f24f61 5979
181aa2be 5980 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5981 (casify_region): Mark local as initialized.
181aa2be 5982
930d429c
PE
5983 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5984
7082eac6
PE
5985 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5986 New macros, so that the caller can use some names other than
5987 gcpro1, gcpro2, etc.
5988 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5989 of the new macros.
5990 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5991 argument, for consistency with GCPRO2_VAR, etc: it is now the
5992 prefix of the variable, not the variable itself. All uses
5993 changed.
38b2c076
PE
5994 * dired.c (directory_files_internal, file_name_completion):
5995 Rename locals to avoid shadowing.
5996
15206ed9
PE
5997 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5998 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5999 dired.c's scmp function, had undefined behavior.
6000 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6001 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6002 * buffer.h: ... to here, because these macros use current_buffer,
6003 and the new implementation with inline functions needs to have
6004 current_buffer in scope now, rather than later when the macros
6005 are used.
6006 (downcase, upcase1): New static inline functions.
6007 (DOWNCASE, UPCASE1): Reimplement using these functions.
6008 This avoids undefined behavior in expressions like
6009 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6010 from race conditions in accessing the global variables
6011 case_temp1 and case_temp2.
6012 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6013 * lisp.h (case_temp1, case_temp2): Remove their decls.
6014 * character.h (ASCII_CHAR_P): Move from here ...
6015 * lisp.h: ... to here, so that the inline functions mentioned
6016 above can use them.
6017
4a6bea26
PE
6018 * dired.c (directory_files_internal_unwind): Now static.
6019
f14b7e14
PE
6020 * fileio.c (file_name_as_directory, directory_file_name):
6021 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6022 Now static.
2893f146
PE
6023 (file_name_as_directory): Use const pointers when appropriate.
6024 (Fexpand_file_name): Likewise. In particular, newdir might
6025 point at constant storage, so make it a const pointer.
fd4ead52 6026 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6027 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6028 signedness issues.
f839df0c
PE
6029 (Fset_file_times, Finsert_file_contents, auto_save_error):
6030 Rename locals to avoid shadowing.
f14b7e14 6031
5716756e 6032 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6033 (Ftry_completion, Fall_completions): Rename or remove locals
6034 to avoid shadowing.
5716756e 6035
b4c3046a
PE
6036 * marker.c (bytepos_to_charpos): Remove; unused.
6037
b45db522
PE
6038 * lisp.h (verify_bytepos, count_markers): New decls,
6039 so that gcc does not warn that these functions aren't declared.
6040
85876d07
PE
6041 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6042 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6043 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6044 (copy_text): Remove unused local var.
85876d07 6045
03d78a21 6046 * filelock.c (within_one_second): Now static.
b3dd38ab 6047 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6048
5df8f01b
PE
6049 * buffer.c (fix_overlays_before): Mark locals as initialized.
6050 (fix_start_end_in_overlays): Likewise. This function should be
6051 simplified by using pointers-to-pointers, but that's a different
6052 matter.
b1d876f1 6053 (switch_to_buffer_1): Now static.
8f54f30a
PE
6054 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6055 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6056
a70072c9 6057 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6058 Fix pointer signedness issue.
edced198
PE
6059 (sys_subshell): Mark local as volatile if checking for lint,
6060 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6061 (MAXPATHLEN): Define only if needed.
a70072c9 6062
a0977c44
PE
6063 * process.c (serial_open, serial_configure): Move decls from here ...
6064 * systty.h: ... to here, so that they can be checked.
6065
a884fdcc
PE
6066 * fns.c (get_random, seed_random): Move extern decls from here ...
6067 * lisp.h: ... to here, so that they can be checked.
6068
604efe86 6069 * sysdep.c (reset_io): Now static.
b8950c94 6070 (wait_for_termination_signal): Remove; unused.
604efe86 6071
38fc62d9
PE
6072 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6073 (copy_keymap_item, append_key, push_text_char_description):
6074 Now static.
1004a21a 6075 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6076 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6077 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6078 (describe_map_tree):
6079 Rename locals to avoid shadowing.
38fc62d9 6080
2f2650da
PE
6081 * keyboard.c: Declare functions static if they are not used elsewhere.
6082 (echo_char, echo_dash, cmd_error, top_level_2):
6083 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6084 (read_char, kbd_buffer_get_event, make_lispy_position):
6085 (make_lispy_event, make_lispy_movement, apply_modifiers):
6086 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6087 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6088 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6089 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6090 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6091
a053e86c 6092 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6093 (mark_kboards): Move decl here ...
6094 * alloc.c (mark_kboards): ... from here.
a053e86c 6095
4752793e
PE
6096 * lisp.h (force_auto_save_soon): New decl.
6097
74f10ca7 6098 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6099 (DEFINE_DUMMY_FUNCTION): New macro.
6100 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6101 Use it.
c03cd23f
PE
6102 (main): Add casts to avoid warnings
6103 if GCC considers string literals to be constants.
74f10ca7 6104
022e70d4
PE
6105 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6106
59d6fe83
PE
6107 * dbusbind.c: Pointer signedness fixes.
6108 (xd_signature, xd_append_arg, xd_initialize):
6109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6110 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6111 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6112 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6113
78320123
PE
6114 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6115 if GCC considers string literals to be constants.
49cebcca 6116 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6117
35ac2a97
SM
61182011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6119
fb103ca9
SM
6120 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6121 (print_preprocess, print_object): New macro to fix last change.
6122
35ac2a97
SM
6123 * print.c (print_preprocess): Don't forget font objects.
6124
62973b41
JB
61252011-03-16 Juanma Barranquero <lekktu@gmail.com>
6126
6127 * emacs.c (USAGE3): Doc fixes.
6128
0e48bb22
AS
61292011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6130
6131 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6132 structure.
6133
7684e57b
JB
61342011-03-14 Juanma Barranquero <lekktu@gmail.com>
6135
6136 * lisp.h (VWindow_system, Qfile_name_history):
6137 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6138 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6139 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6140
6141 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6142 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6143
6144 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6145 * w32console.c (detect_input_pending, read_input_pending)
6146 (encode_terminal_code):
6147 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6148 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6149 (w32_system_caret_y, Qfile_name_history):
6150 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6151 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6152 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6153 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6154 * w32proc.c (Qlocal, report_file_error):
6155 * w32term.c (Vwindow_system, updating_frame):
6156 * w32uniscribe.c (initialized, uniscribe_font_driver):
6157 Remove unneeded extern declarations.
6158
2aa46d6c
CY
61592011-03-14 Chong Yidong <cyd@stupidchicken.com>
6160
c96bbc66 6161 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6162
cffc6f3b
CY
61632011-03-13 Chong Yidong <cyd@stupidchicken.com>
6164
6165 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6166 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6167 These macros can no longer be used for assignment.
6168
44f230aa
SM
6169 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6170 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6171 (record_buffer_markers, fetch_buffer_markers): New functions for
6172 recording and fetching special buffer markers.
6173 (set_buffer_internal_1, set_buffer_temp): Use them.
6174
6175 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6176
6177 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6178
6179 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6180 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6181
6182 * xdisp.c (hscroll_window_tree):
6183 (reconsider_clip_changes): Use PT instead of BUF_PT.
6184
d251f04b
EZ
61852011-03-13 Eli Zaretskii <eliz@gnu.org>
6186
6187 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6188 $(EMACS_ROOT)/lib/intprops.h.
6189
f0c77cd1
PE
61902011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6191
3eca4629
PE
6192 Fix more problems found by GCC 4.5.2's static checks.
6193
7c86ee98
PE
6194 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6195 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6196 (xg_free_frame_widgets): Make it clear that a local variable is
6197 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6198 (gdk_window_get_screen): Make it clear that this macro is needed
6199 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6200 (int_gtk_range_get_value): New function, which avoids a diagnostic
6201 from gcc -Wbad-function-cast.
6202 (xg_set_toolkit_scroll_bar_thumb): Use it.
6203 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6204 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6205 (get_utf8_string, xg_get_file_with_chooser):
6206 Rename locals to avoid shadowing.
6207 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6208
41729b81
PE
6209 * xgselect.c (xg_select): Remove unused var.
6210
f0c77cd1
PE
6211 * image.c (four_corners_best): Mark locals as initialized.
6212 (gif_load): Initialize transparent_p to zero (Bug#8238).
6213 Mark another local as initialized.
ec6cf4c6 6214 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6215
ce0ad53d 6216 * image.c (clear_image_cache): Now static.
d5d5a617 6217 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6218 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6219 (x_edge_detection): Remove unnecessary cast that
6220 gcc -Wbad-function-cast diagnoses.
2037898d 6221 (gif_load): Fix pointer signedness.
6ae141d6
PE
6222 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6223 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6224
33383987 62252011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6226
d32df629
PE
6227 Improve quality of tests for time stamp overflow.
6228 For example, without this patch (encode-time 0 0 0 1 1
6229 1152921504606846976) returns the obviously-bogus value (-948597
6230 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6231 reports time overflow. See
6232 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6233 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6234 * editfns.c: Include limits.h and intprops.h.
6235 (TIME_T_MIN, TIME_T_MAX): New macros.
6236 (time_overflow): Move earlier, to before first use.
6237 (hi_time, lo_time): New functions, for an accurate test for
6238 out-of-range times.
6239 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6240 (Fget_internal_run_time): Don't assume time_t fits in int.
6241 (make_time): Use list2 instead of Fcons twice.
6242 (Fdecode_time): More accurate test for out-of-range times.
6243 (check_tm_member): New function.
6244 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6245 (lisp_time_argument): Don't rely on undefined left-shift and
6246 right-shift behavior when checking for time stamp overflow.
8be6f318 6247
fe31d94c
PE
6248 * editfns.c (time_overflow): New function, refactoring common code.
6249 (Fformat_time_string, Fdecode_time, Fencode_time):
6250 (Fcurrent_time_string): Use it.
6251
8be6f318
PE
6252 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6253 * dired.c (make_time): Move to ...
6254 * editfns.c (make_time): ... here.
6255 * systime.h: Note the move.
6256
09d9db2c 62572011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6258
126bc0dc
YM
6259 * fringe.c (update_window_fringes): Remove unused variables.
6260
c47cbdfd
YM
6261 * unexmacosx.c (copy_data_segment): Also copy __got section.
6262 (Bug#8223)
6263
7ac80be9
EZ
62642011-03-12 Eli Zaretskii <eliz@gnu.org>
6265
c96bbc66 6266 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6267 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6268 Constify `char *' arguments and their references according to
6269 prototypes in tparam.h.
6270
ecb0f94d 6271 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6272
7ac80be9
EZ
6273 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6274 Adapt all references accordingly.
6275
6276 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6277
ef1fd07e
TT
62782011-03-11 Tom Tromey <tromey@redhat.com>
6279
6280 * buffer.c (syms_of_buffer): Remove obsolete comment.
6281
7ef4b50c
EZ
62822011-03-11 Eli Zaretskii <eliz@gnu.org>
6283
6284 * termhooks.h (encode_terminal_code): Declare prototype.
6285
6286 * msdos.c (encode_terminal_code): Don't declare prototype.
6287
6288 * term.c (encode_terminal_code): Now external again, used by
6289 w32console.c and msdos.c.
6290
44f230aa
SM
6291 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6292 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6293
4b1ec863 62942011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6295
1714f52b 6296 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6297
4b1ec863
PE
6298 * fringe.c (update_window_fringes): Mark locals as initialized
6299 (Bug#8227).
6300 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6301
524c7aa6
PE
6302 * alloc.c (mark_fringe_data): Move decl from here ...
6303 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6304 to check its interface.
6305 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6306
a5c0af81 6307 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6308 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6309 (fontset_font): Mark local as initialized.
a9a06e0b 6310 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6311
b4716021
PE
6312 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6313
811e9bac 6314 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6315 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6316 (x_own_selection, Fx_disown_selection_internal): Rename locals
6317 to avoid shadowing.
6318 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6319
7e3ab302
PE
6320 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6321 so that the caller can use some name other than gcpro1.
6322 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6323 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6324 (Fx_backspace_delete_keys_p):
6325 Use them to avoid shadowing, and rename vars to avoid shadowing.
6326 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6327 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6328 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6329 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6330 Remove unused locals.
7e3ab302
PE
6331 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6332 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6333 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6334 macros.
f78faa98 6335
e2b13473
PE
6336 * xterm.h (x_mouse_leave): New decl.
6337
77f23912
PE
6338 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6339 Remove unused functions.
cdf4ba58
PE
6340 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6341 (x_calc_absolute_position): Now static.
7411c686 6342 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6343 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6344 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6345 unless they are used.
38d0b34a
PE
6346 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6347 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6348 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6349 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6350 (x_error_catcher, x_connection_closed, x_error_handler):
6351 (x_error_quitter, xembed_send_message, x_iconify_frame):
6352 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6353 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6354 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6355
44f230aa
SM
6356 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6357 Rename or move locals to avoid shadowing.
6b463e58 6358 (tty_defined_color, merge_face_heights): Now static.
5967d051 6359 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6360 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6361 does not deduce is never used uninitialized.
73719eba
PE
6362 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6363 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6364
426994c3 6365 * terminal.c (store_terminal_param): Now static.
5489860b 6366
032f1620 6367 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6368 (set_frame_menubar): Remove unused local.
d4323972 6369 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6370 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6371 since they might point to immutable storage.
281585b0
PE
6372 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6373 since it's unused otherwise.
032f1620 6374
367c19e5 6375 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6376 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6377 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6378 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6379 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6380 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6381 does not deduce are never used uninitialized.
70739cbe 6382
07b48fa9
PE
6383 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6384
8868a238 6385 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6386 * window.c (window_loop, size_window):
6387 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6388
7e5cf297 6389 * window.c (display_buffer): Now static.
d6550a9f
PE
6390 (size_window): Mark variables that gcc -Wuninitialized
6391 does not deduce are never used uninitialized.
a586633d
PE
6392 * window.h (check_all_windows): New decl, to forestall
6393 gcc -Wmissing-prototypes diagnostic.
5b555da1 6394 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6395
f6095868
PE
6396 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6397 shadowing.
6398 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6399 Include <limits.h>.
6400 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6401 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6402 (load_charset_map): Mark variables that gcc -Wuninitialized
6403 does not deduce are never used uninitialized.
53df7c11 6404 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6405
f38b440c
PE
6406 * coding.c (coding_set_source, coding_set_destination):
6407 Use "else { /* comment */ }" rather than "else /* comment */;"
6408 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6409 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6410 a block, when the outer 'i' will do.
6411 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6412 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6413 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6414 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6415 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6416 Rename locals to avoid shadowing.
6417 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6418 * coding.c (emacs_mule_char, encode_invocation_designation):
6419 Now static, since they're not used elsewhere.
413bb2db 6420 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6421 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6422 (decode_coding_emacs_mule): Mark variables that gcc
6423 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6424 (detect_coding_iso_2022): Initialize a local variable that might
6425 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6426 this initialization is needed. (Bug#8211)
5f58e762
PE
6427 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6428 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6429 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6430 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6431 Remove unused macros.
f38b440c 6432
232b38b9 6433 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6434 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6435 * character.c (string_count_byte8): Likewise.
232b38b9 6436
fb90da1b
PE
6437 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6438 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6439
fb93dbc2
PE
6440 * chartab.c (copy_sub_char_table): Now static, since it's not used
6441 elsewhere.
5c156ace
PE
6442 (sub_char_table_ref_and_range, char_table_ref_and_range):
6443 Rename locals to avoid shadowing.
bbcd0949 6444 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6445
7d3b3862 6446 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6447 (BIDI_BOB): Remove unused macro.
7d3b3862 6448
6be7d3da
PE
6449 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6450 deduce are never used uninitialized.
c2ed9c8b 6451 * term.c (encode_terminal_code): Likewise.
6be7d3da 6452
75f8807f 6453 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6454
50938595
PE
6455 * tparam.h: New file.
6456 * term.c, tparam.h: Include it.
6457 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6458 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6459 Move these decls to tparam.h, and make them agree with what
6460 is actually in tparam.c. The previous trick of using incompatible
6461 decls in different modules does not conform to the C standard.
6462 All callers of tparam changed to use tparam's actual API.
6463 * tparam.c (tparam1, tparam, tgoto):
6464 Use const pointers where appropriate.
6465
fbceeba2
PE
6466 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6467 * cm.h (struct cm): Likewise.
6468 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6469 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6470 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6471 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6472 (turn_on_face, init_tty): Likewise.
6473 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6474
7f3f1250
PE
6475 * term.c (term_mouse_position): Rename local to avoid shadowing.
6476
e6ca6543
PE
6477 * alloc.c (mark_ttys): Move decl from here ...
6478 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6479
c40f8d15
AS
64802011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6481
6482 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6483
cfe0661d
JB
64842011-03-09 Juanma Barranquero <lekktu@gmail.com>
6485
6486 * search.c (compile_pattern_1): Remove argument regp, unused since
6487 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6488 (compile_pattern): Don't pass it.
6489
0afb4571
J
64902011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6491
6492 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6493 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6494 for ! HAVE_GTK3.
6495 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6496
6497 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6498
6499 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6500 gdk_window_get_screen, gdk_window_get_geometry,
6501 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6502 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6503 (xg_get_pixbuf_from_pixmap): New function.
6504 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6505 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6506 Call xg_get_pixbuf_from_pixmap instead of
6507 gdk_pixbuf_get_from_drawable.
6508 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6509 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6510 (xg_check_special_colors): Use GtkStyleContext and its functions
6511 for HAVE_GTK3.
6512 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6513 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6514 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6515 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6516 Call gtk_widget_get_preferred_size.
0afb4571
J
6517 (xg_frame_resized): gdk_window_get_geometry only takes 5
6518 parameters.
44f230aa
SM
6519 (xg_win_to_widget, xg_event_is_for_menubar):
6520 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6521 (xg_set_widget_bg): New function.
6522 (delete_cb): New function.
895009e1 6523 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6524 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6525 (xg_set_background_color): Call xg_set_widget_bg.
6526 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6527 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6528 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6529 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6530 if ! HAVE_GTK3.
6531 (update_frame_tool_bar): Call gtk_widget_hide.
6532 (xg_initialize): Use GDK_KEY_g.
6533
6534 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6535 if ! HAVE_GTK3
6536 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6537
6538 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6539 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6540 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6541
1c2cc4ef
JB
65422011-03-08 Juanma Barranquero <lekktu@gmail.com>
6543
6544 * w32xfns.c (select_palette): Check success of RealizePalette against
6545 GDI_ERROR, not zero.
6546
33383987 6547See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6548
6549;; Local Variables:
6550;; coding: utf-8
aac0c6e3
MR
6551;; End:
6552
33383987 6553 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6554
6555 This file is part of GNU Emacs.
6556
6557 GNU Emacs is free software: you can redistribute it and/or modify
6558 it under the terms of the GNU General Public License as published by
6559 the Free Software Foundation, either version 3 of the License, or
6560 (at your option) any later version.
6561
6562 GNU Emacs is distributed in the hope that it will be useful,
6563 but WITHOUT ANY WARRANTY; without even the implied warranty of
6564 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6565 GNU General Public License for more details.
6566
6567 You should have received a copy of the GNU General Public License
6568 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.