nt/config.nt: Sync with autogen/config.in.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8e99d072
BR
12012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2
3 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
4 (bug#12022).
5
08908aca
MR
62012-08-14 Martin Rudalics <rudalics@gmx.at>
7
8 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
9 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
10 * minibuf.c (choose_minibuf_frame, read_minibuf):
11 * w32fns.c (x_create_tip_frame):
12 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
13 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
14
56120d6f
PE
152012-08-14 Paul Eggert <eggert@cs.ucla.edu>
16
17 * intervals.c (offset_intervals): Remove obsolete comment.
18
67b77c0b
AS
192012-08-14 Andreas Schwab <schwab@linux-m68k.org>
20
21 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
22
f48b82fd
GR
232012-08-14 Gergely Risko <gergely@risko.hu>
24
25 * coding.c (decode_coding): Record buffer modification before
26 disabling undo_list (Bug#11773).
27
fd318b54
DA
282012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Revert and cleanup some recent overlay changes.
31 * buffer.h (enum overlay_type): Remove.
32 (buffer_get_overlays, buffer_set_overlays): Likewise.
33 (buffer_set_overlays_before, buffer_set_overlays_after):
34 New function. Adjust users.
35 (unchain_both): Add eassert.
36
41a62dd9
DA
372012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
38
39 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
40
5884c324
PE
412012-08-14 Paul Eggert <eggert@cs.ucla.edu>
42
43 * gtkutil.c (xg_mark_data): Don't assume C99.
44
ca06f160
JD
452012-08-13 Jan Djärv <jan.h.d@swipnet.se>
46
47 * gtkutil.c (xg_frame_tb_info): New struct.
48 (TB_INFO_KEY): New define.
49 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
50 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
51 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
52 if not present.
53 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
54 is up to date. Otherwise store new data.
55 (free_frame_tool_bar): Free xg_frame_tb_info if present.
56
7864a3f7
DA
572012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
58
59 Use KSET for write access to Lisp_Object members of struct kboard.
60 * keyboard.h (KSET): New macro.
61 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
62 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
63 * xterm.c: Adjust users.
64
4c31be61
DA
652012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Use BSET for write access to Lisp_Object members of struct buffer.
68 * buffer.h (BSET): New macro.
69 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
70 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
71 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
72 * window.c, xdisp.c, xfns.c: Adjust users.
73
14ae4239
BT
742012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
75
76 * lread.c (syms_of_lread): Initialize Vlexical_binding.
77
32bcadb4
JD
782012-08-11 Jan Djärv <jan.h.d@swipnet.se>
79
3d29b2ce
JD
80 * nsterm.m (not_in_argv): New function.
81 (application:openFile, application:openTempFile:):
82 (application:openFileWithoutUI:, application:openFiles:): Open file
83 if not_in_argv returns non-zero (bug#12171).
84
32bcadb4 85 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
86 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
87 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
88 (xg_get_font_name): Use those functions/macros here.
89 Reported by Frans Oilinki <moilinki@gmail.com>.
90
9ff9402d 912012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
92
93 * unexmacosx.c (copy_data_segment): Copy initialized data in
94 statically linked libraries from input file rather than memory.
95
db74a5fc
YM
96 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
97 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
98 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
99
25e65510
GM
1002012-08-10 Glenn Morris <rgm@gnu.org>
101
102 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
103 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
104
7961135c
DA
1052012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
106
107 Fix last change to allow compilation with low optimization levels.
108 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
109 Reported by Jan Djärv <jan.h.d@swipnet.se>.
110
42b3a444
DA
1112012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
112
113 Use common inline syntax in intervals.h.
114 * intervals.h (INTERVALS_INLINE): New macro.
115 Change all users from LISP_INLINE.
116
9fb0c957
DA
1172012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
118
119 Define Qnone once for all platforms.
120 * frame.c (Qnone): Define here.
121 (syms_of_frame): DEFSYM it.
122 * lisp.h (Qnone): New declaration.
123 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
124 * xfns.c: Remove duplication. Adjust users.
125
65e8ee52
DA
1262012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
127
128 Remove unused macros from intervals.h.
129 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
130 * intervals.c: Adjust comment.
131
9b855fd6
EZ
1322012-08-10 Eli Zaretskii <eliz@gnu.org>
133
134 * w32fns.c <w32_unicode_gui>: New static variable.
135 (globals_of_w32fns): Initialize it according to os_subtype.
136 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
137 testing os_subtype.
138
39cb9e56 1392012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
140 Eli Zaretskii <eliz@gnu.org>
141
142 Fix bug #10299 with Unicode characters sent by customized
143 keyboards created by MSKLC.
144 * w32fns.c (INIT_WINDOW_CLASS): New macro.
145 (w32_init_class): Use it to initialize the Emacs class with either
146 ANSI or Unicode API calls.
147 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
148 later.
149 (w32_wnd_proc): If the character code sent by WM_CHAR or
150 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
151 original message. Call DefWindowProcW on NT and later.
152
9374581a
GM
1532012-08-10 Glenn Morris <rgm@gnu.org>
154
4b94e8cf
GM
155 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
156
9374581a
GM
157 * lisp.h (DIRECTORY_SEP): Let configure set it.
158
a2752828
DA
1592012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
160
161 Use TSET for write access to Lisp_Object slots of struct terminal.
162 * termhooks.h (TSET): New macro.
163 * coding.c, terminal.c, xselect.c: Adjust users.
164
cc92c454
SM
1652012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
166
167 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
168 the failing expression, include them in the error message.
169 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
170 * lisp.h (internal_condition_case_n): Update declaration.
171
4cb3e6b3
DA
1722012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
173
174 Inline functions to examine and change buffer overlays.
175 * buffer.c (unchain_both): New function.
176 * buffer.h (buffer_get_overlays, buffer_set_overlays):
177 (buffer_has_overlays): New function.
178 (enum overlay_type): New enum.
179 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
180 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
181
8707c1e5
DA
1822012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Inline functions to examine and change buffer intervals.
185 * alloc.c (mark_interval_tree): Remove.
186 (MARK_INTERVAL_TREE): Simplify.
187 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
188 * intervals.c (buffer_balance_intervals): New function.
189 (graft_intervals_into_buffer): Adjust indentation.
190 (set_intervals_multibyte): Simplify.
191 * buffer.h (BUF_INTERVALS): Remove.
192 (buffer_get_intervals, buffer_set_intervals): New function.
193 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
194 * intervals.c, textprop.c: Adjust users.
195
ad8c997f
DA
1962012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Inline functions to examine and change string intervals.
199 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
200 (string_get_intervals, string_set_intervals): New function.
201 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
202 * lread.c, print.c, textprop.c: Adjust users.
203
32ac3a6b
GM
2042012-08-08 Glenn Morris <rgm@gnu.org>
205
206 * lisp.mk (lisp): Remove language/persian.elc.
207
77c7bcb1
DA
2082012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Cleanup intervals.
211 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
212 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
213 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
214 Adjust comment. Move under #if 0.
77c7bcb1
DA
215 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
216 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
217
9c08a8d4
DA
2182012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
219
220 Check total length of intervals with eassert.
221 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
222 * intervals.c: Change all users to eassert.
223
26d16b35
EZ
2242012-08-07 Eli Zaretskii <eliz@gnu.org>
225
14ae4239
BT
226 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
227 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
228 INTERNAL_FIELD in Lisp_Cons.
229
c644523b
DA
2302012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
231
232 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
233 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
234 name since all xname users are fixed long time ago. Do not
235 use INTERNAL_FIELD.
236 (set_symbol_name, set_symbol_function, set_symbol_plist):
237 (set_symbol_next, set_overlay_plist): New function.
238 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
239 (struct Lisp_Overlay): Likewise.
240 (CVAR, MVAR, SVAR): Remove.
241 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
242 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
243 * xterm.c: Adjust users.
244 * .gdbinit: Change to use name field of struct Lisp_Symbol
245 where appropriate.
246
6a3d20cc
DA
2472012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
248
249 Basic functions to set Lisp_Object and pointer slots of intervals.
250 * intervals.h (interval_set_parent, interval_set_object):
251 (interval_set_left, interval_set_right, interval_set_plist):
252 (interval_copy_parent): New function.
253 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
254 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
255 Adjust indentation.
6a3d20cc
DA
256 (INTERVAL_SIZE): Remove. Adjust users.
257 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
258
4d2b044c
DA
2592012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
260
261 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
262 * process.h (PGET): Remove.
263 (struct Lisp_Process): Do not use INTERNAL_FIELD.
264 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
265
d3d50620
DA
2662012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
267
268 Drop WGET and revert read access to Lisp_Objects slots of struct window.
269 * window.h (WGET): Remove.
270 (struct window): Do not use INTERNAL_FIELD.
271 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
272 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
273 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
274 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
275 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
276 Adjust users.
277
d10a51dc
CY
2782012-08-07 Chong Yidong <cyd@gnu.org>
279
280 * window.c (Fwindow_edges, Fwindow_pixel_edges)
281 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
282 (Fdelete_window_internal): Signal an error if the window is not on
283 a live frame (Bug#12025).
284
e69b0960
DA
2852012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
286
287 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
288 * frame.h (FGET): Remove.
289 (struct frame): Do not use INTERNAL_FIELD.
290 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
291 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
292 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
293 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
294
25a20a3a
JB
2952012-08-06 Juanma Barranquero <lekktu@gmail.com>
296
297 * w32.c: Silence compiler warnings.
298 (map_w32_filename): Remove unused variable `is_fat'.
299 (chase_symlinks): Add parentheses around expression.
300
1c6f11f4
GM
3012012-08-06 Glenn Morris <rgm@gnu.org>
302
1db4583a
GM
303 * sysdep.c: Respect BROKEN_GETWD.
304
1c6f11f4
GM
305 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
306 Let configure handle it.
307 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
308
2b90362b
DA
3092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Use GCALIGNMENT where appropriate.
312 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
313 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
314 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
315
5f50daf2
EZ
3162012-08-06 Eli Zaretskii <eliz@gnu.org>
317
14ae4239
BT
318 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
319 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 320
cbcc7007
SM
3212012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
322
323 * buffer.h (struct buffer): Revert `indirections' to a simple int;
324 that should be sufficient for everyone.
325
4d365fa4
JD
3262012-08-06 Jan Djärv <jan.h.d@swipnet.se>
327
328 * keyboard.c (timer_check_2): Add break so timer_check returns next
329 timeout.
330
dd86bd82
DA
3312012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
332
333 Fix Windows build errors introduced after converting to WGET and WSET.
334 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
335 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
336
054e1668
JD
3372012-08-06 Jan Djärv <jan.h.d@swipnet.se>
338
339 * nsterm.m (ns_frame_rehighlight): Use FSET.
340
341 * nsmenu.m (ns_update_menubar): Use FSET.
342
21238f11
DA
3432012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
344
345 Separate read and write access to Lisp_Object slots of Lisp_Process.
346 * process.h (PGET, PSET): New macros similar to AREF and ASET.
347 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
348
077288cf
DA
3492012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
350
351 Separate read and write access to Lisp_Object slots of struct window.
352 * window.h (WGET, WSET): New macros similar to AREF and ASET.
353 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
354 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
355 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
356 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
357 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
358 Adjust users.
359
71688bd7
DA
3602012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
361
362 Fix Windows build errors introduced after converting to FGET and FSET.
363 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
364 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
365 (w32_judge_scroll_bars): Change to use FSET.
366 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
367
f99bac93
DA
3682012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
369
370 Fix replacement typo.
371 * window.c (replace_window): Set root_window instead of
372 selected_window. This fixes a total window subsystem
373 malfunction reported by Bastien Guerry <bzg@gnu.org>.
374
8c2a0f2d
GM
3752012-08-06 Glenn Morris <rgm@gnu.org>
376
377 * lisp.mk (lisp): Add language/persian.elc.
378
edd74c35
DA
3792012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
380
381 Separate read and write access to Lisp_Object slots of struct frame.
382 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
383 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
384 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
385 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
386 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
387
8671676c
AS
3882012-08-05 Andreas Schwab <schwab@linux-m68k.org>
389
390 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
391
663e2b3f
DA
3922012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
393
394 Generalize common compile-time constants.
395 * lisp.h (header_size, bool_header_size, word_size): Now here.
396 (struct Lisp_Vector): Add comment.
397 (struct Lisp_Bool_Vector): Move up to define handy constants.
398 (VECSIZE, PSEUDOVECSIZE): Simplify.
399 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
400 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
401 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
402 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
403 * xfont.c, xmenu.c: Use word_size where appropriate.
404
d32e47af
LM
4052012-08-05 Lawrence Mitchell <wence@gmx.li>
406
407 * search.c (Freplace_match): Treat \? in the replacement text
408 literally (Bug#8161).
409
e5d9c0d1
CY
4102012-08-05 Chong Yidong <cyd@gnu.org>
411
412 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
413 * frame.c (Vdelete_frame_functions):
414 * emacs.c (Vkill_emacs_hook): Doc fix.
415
8da0576b
EZ
4162012-08-04 Eli Zaretskii <eliz@gnu.org>
417
418 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
419 --with-x-toolkit=no builds.
420 Reported by Carsten Mattner <carstenmattner@gmail.com>.
421
02676e5d
CY
4222012-08-04 Chong Yidong <cyd@gnu.org>
423
424 * syntax.c (Fmodify_syntax_entry): Doc fix.
425
97147da9
EZ
4262012-08-04 Eli Zaretskii <eliz@gnu.org>
427
76151e2c
EZ
428 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
429 * w32.c (init_environment): Change the default values of many
430 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
431 them into environment when they were not already defined.
432 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 433 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
434 (check_windows_init_file): Now external, not static.
435 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
436 called when Vload_path is already set up.
437
438 * w32.h (check_windows_init_file): Add prototype.
439
440 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
441 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
442 compatibility with Posix platforms.
443 (main): Move the call to check_windows_init_file to here from
444 w32.c.
445 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
446 any, in the DEFALT argument into the root of the Emacs build or
447 installation tree, as appropriate.
448
449 * callproc.c (init_callproc_1): Call decode_env_path instead of
450 doing its equivalent by hand.
451 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
452 the code that sets Vexec_path run on MS-Windows.
453
454 * lread.c (init_lread): Add comments to #ifdef's.
455
97147da9
EZ
456 * msdos.c (dos_set_window_size, IT_update_begin)
457 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
458 instead of direct references.
459
185ee146
PE
4602012-08-04 Paul Eggert <eggert@cs.ucla.edu>
461
462 Export DEFAULT_REHASH_* to GDB.
463 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
464 Now constants, not macros.
465
8834c57a
PE
4662012-08-03 Paul Eggert <eggert@cs.ucla.edu>
467
98c6f1e3
PE
468 Remove unnecessary casts involving pointers.
469 These casts are no longer needed now that we assume C89 or later,
470 since they involve casting to or from void *.
471 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
472 (make_pure_float, make_pure_vector):
473 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
474 * macros.c (Fstart_kbd_macro):
475 * menu.c (find_and_return_menu_selection):
476 * minibuf.c (read_minibuf_noninteractive):
477 * sysdep.c (closedir):
478 * xdisp.c (x_produce_glyphs):
479 * xfaces.c (compare_fonts_by_sort_order):
480 * xfns.c (x_real_positions, select_visual):
481 * xselect.c (x_stop_queuing_selection_requests)
482 (x_get_window_property, x_get_window_property_as_lisp_data):
483 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
484 Remove unnecessary pointer casts.
485 * alloc.c (record_xmalloc): New function.
486 * lisp.h (record_xmalloc): New decl.
487 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
488 more like a function. This is because the pointer cast is not
489 needed. All uses changed.
490 * print.c (print_string, print_error_message): Avoid length recalc.
491
8834c57a
PE
492 Improve fix for macroexp crash with debugging (Bug#12118).
493 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
494 ARRAY_MARK_FLAG when checking subscripts, because ASET is
495 not supposed to be invoked from the garbage collector.
496 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
497 (gc_aset): New function, which is like ASET but can be
498 used in the garbage collector.
499 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
500 (set_hash_index): Use it instead of ASET.
501
6dad7178
EZ
5022012-08-03 Eli Zaretskii <eliz@gnu.org>
503
504 Support symlinks on latest versions of MS-Windows.
505 * w32.c: Include winioctl.h and aclapi.h.
506 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
507 (revert_to_self): Forward declarations of static functions.
508 <static BOOL g_b_init_get_security_info>:
509 <g_b_init_create_symbolic_link>: New static flags.
510 (globals_of_w32): Initialize them to zero.
511 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
512 (map_w32_filename): Improve commentary. Simplify switch.
513 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
514 headers (most versions of MinGW w32api don't).
515 (get_security_info, create_symbolic_link)
516 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
517 New functions.
518 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
519 in the argument file name.
520 (sys_access): Call unc_volume_file_attributes only if
521 GetFileAttributes fails with network-related error codes.
522 (sys_rename): Diagnose renaming of a symlink when the user doesn't
523 have the required privileges.
14ae4239 524 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
525 get_file_security_desc.
526 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
527 with addition of handling of symlinks and support for 'lstat'.
528 If possible, get file's attributes and security information by
6dad7178
EZ
529 handle, not by name. Produce S_IFLNK bit for symlinks, when
530 called from 'lstat'.
531 (stat, lstat): New functions, call 'stat_worker'.
532 (symlink, readlink, careadlinkat): Rewritten to create and resolve
533 symlinks when the underlying filesystem supports them.
534
f162bcc3
PE
5352012-08-02 Paul Eggert <eggert@cs.ucla.edu>
536
79ea6c20
PE
537 Fix macroexp crash on Windows with debugging (Bug#12118).
538 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
539 checking subscripts; problem introduced with the recent
540 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
541 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
542 since it's used in non-static inline functions now.
543
c0ce93fd
PE
544 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
545 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 546
f162bcc3
PE
547 Use C99-style 'extern inline' if available.
548 * buffer.h (BUFFER_INLINE):
549 * category.h (CATEGORY_INLINE):
550 * character.h (CHARACTER_INLINE):
551 * charset.h (CHARSET_INLINE):
552 * composite.h (COMPOSITE_INLINE):
553 * dispextern.h (DISPEXTERN_INLINE):
554 * lisp.h (LISP_INLINE):
555 * systime.h (SYSTIME_INLINE):
556 New macro, replacing 'static inline' in this header.
557 * buffer.h, category.h, character.h, charset.h, composite.h:
558 * dispextern.h, lisp.h, systime.h:
559 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
560 * alloc.c (LISP_INLINE):
561 * buffer.c (BUFFER_INLINE):
562 * category.c (CATEGORY_INLINE):
563 * character.c (CHARACTER_INLINE):
564 * charset.c (CHARSET_INLINE):
565 * composite.c (COMPOSITE_INLINE):
566 * dispnew.c (DISPEXTERN_INLINE):
567 * sysdep.c (SYSTIME_INLINE):
568 Define to EXTERN_INLINE, so that the corresponding functions
569 are compiled into code.
570 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
571 (INLINE_HEADER_END): New macros.
572 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
573 since it's used in non-static inline functions now.
a8333d03 574 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 575
837b365b
GM
5762012-08-02 Glenn Morris <rgm@gnu.org>
577
d66b744d
GM
578 * s/: Remove empty directory.
579
837b365b
GM
580 * s/ms-w32.h: Move to ../nt/inc.
581 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
582 Update for new ms-w32.h location.
583
13294f95
PE
5842012-08-02 Paul Eggert <eggert@cs.ucla.edu>
585
586 Port to Solaris 8.
587 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
588
90df0db3
GM
5892012-08-02 Glenn Morris <rgm@gnu.org>
590
591 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
592 hard-coding the path separator.
593
4939150c
PE
5942012-08-01 Paul Eggert <eggert@cs.ucla.edu>
595
596 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
597 This how ASET and AREF are supposed to work, and makes
598 it easier to think about future improvements. See
599 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
600 * charset.h (set_charset_attr): New function.
601 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
602 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
603 (aref_addr): New function. All uses of &AREF(...) changed.
604 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
605 (set_hash_index): New functions. All lvalue-style uses of
606 HASH_KEY etc. changed.
607 * keyboard.c (set_prop): New function. All lvalue-style uses
608 of PROP changed.
609
947b2afd
AA
6102012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
611
612 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
613 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
614 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
615 * nsfns.m (ns_set_name_as_filename): Likewise.
616 * nsmenu.m (ns_update_menubar): Likewise.
617 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
618
4f5d0325
EZ
6192012-08-01 Eli Zaretskii <eliz@gnu.org>
620
2008beae
EZ
621 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
622 Adapt to latest changes in field names of the corresponding Lisp
288479f6 623 objects.
2008beae 624
4f5d0325
EZ
625 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
626
fe3cc771
GM
6272012-08-01 Glenn Morris <rgm@gnu.org>
628
629 * s/msdos.h: Remove file.
630 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
631 * Makefile.in (S_FILE): Remove.
632 (config_h): Remove S_FILE.
633
c90acc54
JB
6342012-08-01 Juanma Barranquero <lekktu@gmail.com>
635
636 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
637 Remove; moved to nt/config.nt.
638
d8a05828
DA
6392012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
640
641 Use INTERNAL_FIELD for conses and overlays.
642 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
643 Remove obsolete comment.
644 (MVAR): New macro.
645 (struct Lisp_Overlay): Use INTERNAL_FIELD.
646 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
647
8271d590
DA
6482012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
649
650 Use INTERNAL_FIELD for symbols.
651 * lisp.h (SVAR): New macro. Adjust users.
652 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
653 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
654
3193acd2
DA
6552012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
656
657 Use INTERNAL_FIELD for processes.
658 * process.h (PVAR): New macro. Adjust style.
659 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
660 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
661
3a45383a
DA
6622012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
663
664 Use INTERNAL_FIELD for windows.
665 * window.h (WVAR): New macro.
666 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
667 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
668 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
669 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
670 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
671 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
672
c1dbc63c
PE
6732012-08-01 Paul Eggert <eggert@cs.ucla.edu>
674
675 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
676
5c0c0e8a
GM
6772012-08-01 Glenn Morris <rgm@gnu.org>
678
679 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
680 Move to configure.ac.
681
552a99b4
JB
6822012-08-01 Juanma Barranquero <lekktu@gmail.com>
683
684 * makefile.w32-in (CONFIG_H): Update dependencies.
685 (CONF_POST_H): New macro.
686
687 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
688
8d8e2dfe
GM
6892012-07-31 Glenn Morris <rgm@gnu.org>
690
bc96620a
GM
691 * Makefile.in (S_FILE): No longer set by configure.
692
476b1b2d
GM
693 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
694 is available.
695 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
696
b2c7a106
GM
697 * process.h (NULL_DEVICE):
698 * emacs.c (SEPCHAR):
699 * editfns.c (USER_FULL_NAME): Let configure set them.
700
d53d062a
GM
701 * s/README, s/template.h: Remove files.
702
4515017f
GM
703 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
704
8d8e2dfe
GM
705 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
706 Move to configure.ac.
707
5b20b3cc
EZ
7082012-07-31 Eli Zaretskii <eliz@gnu.org>
709
1e0afd9a
EZ
710 * .gdbinit (xframe): Adapt to introduction of FVAR and the
711 resulting renaming of 'struct frame' members.
712
5b20b3cc
EZ
713 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
714
715 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
716 after introduction of FVAR.
717
f1310128
JD
7182012-07-31 Jan Djärv <jan.h.d@swipnet.se>
719
79e721e0
JD
720 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
721
722 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
723 instead of compositeToPoint.
724 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
725
8d7c7eed 726 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 727
e34f7f79
DA
7282012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
731 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 732 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
733 (BVAR): Change to use INTERNAL_FIELD.
734 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
735 (KVAR): Change to use INTERNAL_FIELD.
736 * frame.h (FVAR): New macro.
737 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
738 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
739 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
740 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
741 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
742
c09bfb2f
DA
7432012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
744
745 Miscellaneous fixes for non-default X toolkits.
746 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
747 * xterm.c (x_frame_of_widget): Remove redundant prototype.
748 Move under #ifdef USE_LUCID.
749 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
750 definition and usage to avoid warnings.
751
14c114ae
JD
7522012-07-31 Jan Djärv <jan.h.d@swipnet.se>
753
754 * nsterm.m (openFiles): Fix previous checkin.
755
3bd21e82
PE
7562012-07-31 Paul Eggert <eggert@cs.ucla.edu>
757
758 * indent.c (compute_motion): Remove unused local.
759
c1529ded
GM
7602012-07-31 Glenn Morris <rgm@gnu.org>
761
400d5621
GM
762 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
763
268e2432
GM
764 * conf_post.h [USG5_4]:
765 Move remaining contents of s/usg5-4-common.h here.
766 * s/usg5-4-common.h: Remove file.
767
7552f3ee
GM
768 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
769 * s/irix6-5.h: Remove file.
770
6a381852
GM
771 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
772 * s/darwin.h: Remove file.
773
c1529ded
GM
774 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
775 * s/hpux10-20.h: Remove file, which is now empty.
776
b429a4ee
GM
7772012-07-30 Glenn Morris <rgm@gnu.org>
778
779 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
780 * Makefile.in (config_h): Add conf_post.h.
781 * makefile.w32-in (CONFIG_H): Add conf_post.h.
782
adff3182
JD
7832012-07-30 Jan Djärv <jan.h.d@swipnet.se>
784
785 * nsterm.m (ns_do_open_file): New variable.
b9031d69 786 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
787 (openFile, openTempFile, openFileWithoutUI, openFiles):
788 Open files only if ns_do_open_file.
adff3182 789
c32af1e4
PE
7902012-07-30 Paul Eggert <eggert@cs.ucla.edu>
791
7393bcbb
PE
792 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
793 This no-op macro hasn't been needed for many years.
794 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
795
c32af1e4
PE
796 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
797 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
798 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
799 gdb_make_enums_visible.
800 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
801 (DIRECTORY_SEP): Now a constant, not a macro.
802
302fc036
EZ
8032012-07-30 Eli Zaretskii <eliz@gnu.org>
804
805 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
806 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
807
808 * w32term.c <w32_keyboard_codepage>: Renamed from
809 keyboard_codepage and now external. All users changed.
810
811 * w32term.h: Add declaration of w32_keyboard_codepage.
812
813 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
814 the codepage to translate keys to Unicode. If this argument is
815 -1, use the value returned by GetConsoleCP. All callers changed.
816
88fb40b4
PE
8172012-07-30 Paul Eggert <eggert@cs.ucla.edu>
818
0aee6912
PE
819 Update .PHONY listings in makefiles.
820 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
821 bootstrap-clean, distclean, maintainer-clean, versioclean,
822 extraclean, frc.
823
88fb40b4
PE
824 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
825 This is a bit clearer. Fix some commentary typos.
826
0a763bd1
GM
8272012-07-30 Glenn Morris <rgm@gnu.org>
828
32bac6d6
GM
829 * s/netbsd.h: Let configure include signal.h if needed.
830 Remove file, which is now empty.
831
b65e7c46
GM
832 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
833 Let configure set them.
834 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
835 No more need to undefine.
0a763bd1 836
169304bd
AS
8372012-07-30 Andreas Schwab <schwab@linux-m68k.org>
838
839 * keymap.c (Fkey_description): Don't remove 0x80 bit from
840 non-single-byte char when adding meta modifier. (Bug#12090)
841
6cd7a139
DA
8422012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
843
844 Convert safe_call to use variable number of arguments.
845 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
846 (safe_call2): Fix comment.
847 * lisp.h (safe_call): Adjust prototype.
848 * coding.c (encode_coding_object): Change to use safe_call2.
849 * xfaces.c (merge_face_heights): Change to use safe_call1.
850
d34d6ffc
GM
8512012-07-30 Glenn Morris <rgm@gnu.org>
852
7b8a48e4 853 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 854 does that unconditionally. Remove file, which is now empty.
7b8a48e4 855
d34d6ffc
GM
856 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
857 Remove empty files.
858
03a660a6
PE
8592012-07-30 Paul Eggert <eggert@cs.ucla.edu>
860
861 Export to GDB most of lisp.h's remaining object-like macros.
862 * lisp.h (min, max): Move earlier, because they're used earlier now.
863 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
864 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
865 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
866 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
867 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
868 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
869 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
870 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
871 Now constants, for GDB. They need not be macros.
872 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
873 Now constants, for GDB, as well as macros, for static initializers.
874 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
875 Move to after the definition of struct Lisp_Char_Table,
876 since the former now needs that type defined.
877 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
878 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
879 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
880 New enums, for gdb_make_enums_visible.
881 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 882 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
883 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
884 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
885 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
886 enum maxargs, enum MAX_ALLOCA.
887 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
888 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
889 no longer needed, now that they are done in lisp.h.
890
e499d0ee
DA
8912012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
892
893 Cleanup string bytes checking.
894 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
895 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
896 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
897 (check_sblock, compact_small_strings): Simplify.
898
d5040d2d
PE
8992012-07-29 Paul Eggert <eggert@cs.ucla.edu>
900
901 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
902 These macros are confusing and no longer need to be defined, as
903 the enum values now suffice. All uses replaced with definiens.
904 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
905
7f259ae6
JB
9062012-07-29 Juanma Barranquero <lekktu@gmail.com>
907
908 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
909 ($(BLD)/w32console.$(O)): Update dependencies.
910
7e63e0c3
DA
9112012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
912
913 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
914 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
915 time. Adjust users.
916 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
917
ffd817eb
JD
9182012-07-29 Jan Djärv <jan.h.d@swipnet.se>
919
920 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
921 setting sitelisp (Bug#12010).
922
417a7a0e
EZ
9232012-07-29 Eli Zaretskii <eliz@gnu.org>
924
14ae4239 925 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
926
927 * w32heap.c (cache_system_info):
928 * w32.c (sys_rename):
929 * w32proc.c (find_child_console, sys_kill): All users changed.
930
387d4d92
PE
9312012-07-29 Paul Eggert <eggert@cs.ucla.edu>
932
933 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
934
55a6cca6
EZ
9352012-07-29 Eli Zaretskii <eliz@gnu.org>
936
937 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
938
dbcf001c
DA
9392012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
940
941 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
942 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
943 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 944
e2688e4a
DA
9452012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
946
947 Generalize marker debugging code under MARKER_DEBUG and use eassert.
948 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
949 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
950 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
951 (replace_range, replace_range_2, del_range_2): Change to eassert.
952 * marker.c (byte_char_debug_check): Adjust style.
953
b46a6a83
PE
9542012-07-29 Paul Eggert <eggert@cs.ucla.edu>
955
956 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
957 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
958 long-ago-commented-out code that talks about "WIN32".
959 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
960 All uses changed.
961
e32a5799
PE
9622012-07-28 Paul Eggert <eggert@cs.ucla.edu>
963
964 Use Gnulib stdalign module (Bug#9772, Bug#9960).
965 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
966 Simplify by using alignof.
967 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
968 * lisp.h: Include <stdalign.h>.
969 (GCALIGNMENT): New macro and constant.
970 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
971 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
972 (stdalign): New macro, if not already defined.
973
df81cd29
EZ
9742012-07-28 Eli Zaretskii <eliz@gnu.org>
975
01bd1b0d
EZ
976 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
977 * w32inevt.c: Include w32inevt.h.
978 (w32_read_console_input): New inline function, calls either
979 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
980 w32_console_unicode_input.
981 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
982 (w32_kbd_patch_key, key_event): Use the codepage returned by
983 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
984 (key_event): use uChar.UnicodeChar only if
985 w32_console_unicode_input is non-zero.
986
987 * w32console.c: Include w32heap.h.
988 <w32_console_unicode_input>: New global variable.
989 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
990 family of Windows, zero otherwise.
991
992 * w32inevt.h: Declare w32_console_unicode_input.
993
df81cd29
EZ
994 * xdisp.c (init_iterator): Don't reference tip_frame in a build
995 --without-x. (Bug#11742)
996
c20fdd9e
PE
9972012-07-27 Paul Eggert <eggert@cs.ucla.edu>
998
999 Adjust GDB to reflect pvec_type changes (Bug#12036).
1000 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1001 2012-07-04 changes to pseudovector representation.
1002 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1003
32770973 10042012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1005
1006 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1007 bus address.
1008 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1009
3438fe21
EZ
10102012-07-27 Eli Zaretskii <eliz@gnu.org>
1011
bcfbc9de
EZ
1012 * alloc.c (listn): Fix the order the arguments are consed onto the
1013 list.
1014
3438fe21
EZ
1015 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1016 enumeration constants, as PURE and HEAP are too general, and clash
1017 with other headers and sources, such as gmalloc.c and the
1018 MS-Windows system headers. All users changed.
1019
eeaea515
DA
10202012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1021
1022 Revert last save_excursion_save and save_excursion_restore changes.
1023 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1024 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1025
073c88c2
DA
10262012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1027
1028 Fix recently-introduced typos in Windows port.
1029 Reported by Martin Rudalics <rudalics@gmx.at>.
1030 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1031 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1032
4706125e
PE
10332012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 Improve GDB symbol export (Bug#12036).
1036 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1037 arms of an 'if', not using conditional expressions; otherwise GDB
1038 complains about the types in the unevaluated arm when the argument
1039 is an integer literal.
1040 (xgetint): Simplify expression.
1041 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1042 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1043 Zaretskii in <http://bugs.gnu.org/12036#13>.
1044 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1045 needed now that we have gdb_make_enums_visible.
1046 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1047 (enum enum_USE_LSB_TAG):
1048 New enum types, packaging up enums that need to be exported to GDB.
1049
694b6c97
DA
10502012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1051
1052 Utility function to make a list from specified amount of objects.
1053 * lisp.h (enum constype): New datatype.
1054 (listn): New prototype.
1055 * alloc.c (listn): New function.
1056 (Fmemory_use_count, syms_of_alloc): Use it.
1057 * buffer.c (syms_of_buffer): Likewise.
1058 * callint.c (syms_of_callint): Likewise.
1059 * charset.c (define_charset_internal): Likewise.
1060 * coding.c (syms_of_coding): Likewise.
1061 * keymap.c (syms_of_keymap): Likewise.
1062 * search.c (syms_of_search): Likewise.
1063 * syntax.c (syms_of_syntax): Likewise.
1064 * w32.c (init_environment): Likewise.
1065 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1066 * xdisp.c (syms_of_xdisp): Likewise.
1067 * xfns.c (syms_of_xfns): Likewise.
1068
6195f384
DA
10692012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1070
1071 Fast save_excursion_save and save_excursion_restore.
1072 * lisp.h (struct Lisp_Excursion): New data type.
1073 (PVEC_EXCURSION): New pseudovector type.
1074 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1075 to deal with it. Adjust comments.
1076 (init_marker, attach_marker): New prototype.
1077 (unchain_marker): Adjust prototype.
1078 * marker.c (attach_marker): Change to global.
1079 (init_marker): New function.
1080 * alloc.c (Fmake_marker, build_marker): Use it.
1081 (build_marker): More easserts.
1082 (mark_object): Handle struct Lisp_Excursion.
1083 * editfns.c (save_excursion_save, save_excursion_restore):
1084 Reimplement to use struct Lisp_Excursion. Add comments.
1085
5eceb8fb
PE
10862012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 Fix export of symbols to GDB (Bug#12036).
1089 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1090 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1091 emacs.c, as this is a more-suitable home. Had this been done earlier
1092 the fix for 12036 would have avoided some of the problems noted in
1093 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1094 would have been more obvious.
562157c8
PE
1095 * emacs.c: Do not include <verify.h>; no longer needed.
1096 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1097 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1098 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1099 Remove; now done in lisp.h.
1100 * lisp.h (PUBLISH_TO_GDB): New macro.
1101 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1102 (DATA_SEG_BITS): Use it.
1103 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1104 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1105 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1106 not be usable in #if. This simplifies things.
1107
d6749401
JB
11082012-07-26 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1111
1781b9e9
PE
11122012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1113
d89518db 1114 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1115 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1116 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1117 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1118 Adjust to changes in lisp.h and emacs.c, by using
1119 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1120 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1121 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1122 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1123 instead of gdb_valbits.
1124 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1125 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1126 instead of gdb_array_mark_flag.
1127 (xboolvector): Get size from $->size, not $->header.size.
1128 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1129 (xreload, hook-run, hookpost-run): Remove.
1130 * emacs.c: Include <verify.h>.
1131 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1132 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1133 Remove.
1134 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1135 (gdb_USE_LSB_TAG): New enum constants.
1136 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1137 Also define these as enum constants, so they're visible to GDB.
1138 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1139 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1140 as constants, so they're visible to GDB.
1141 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1142 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1143 Now enum constants, not macros, so they're visible to GDB.
1144 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1145 more convenient now. All uses changed.
1146 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1147 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1148
3628596a
DA
11492012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1150
1151 Explicitly free restriction data that are not needed anymore.
1152 * editfns.c (save_restriction_restore): Free restriction data.
1153
7abaf5cc
SM
11542012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1155
1156 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1157 add argument, tune behavior, and adjust all callers.
1158
71f88e00
PE
11592012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 Use typedef for EMACS_INT, EMACS_UINT.
1162 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1163 than macros. This simplifies debugging in the usual case, since
1164 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1165 and it allows expressions involving EMACS_INT casts.
1166 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1167
57ec3034
JD
11682012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1169
1170 * nsterm.m (ns_read_socket): Return early if there is a modal
1171 window (Bug#12043).
1172
8137e7b3
MR
11732012-07-25 Martin Rudalics <rudalics@gmx.at>
1174
1175 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1176 that FOCUS-FRAME can be omitted.
1177
04e9897c
DA
11782012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1179
1180 Adjust buffer text indirection counters at the end of Fkill_buffer.
1181 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1182 buffer is definitely dead. This should really fix an issue reported
1183 by Christoph Scholtes again. (Bug#12007).
1184 (init_buffer_once): Initialize indirection counters of
1185 buffer_defaults and buffer_local_symbols (for sanity and safety).
1186
8a0484e1
EZ
11872012-07-24 Eli Zaretskii <eliz@gnu.org>
1188
1189 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1190 and continuation glyphs on tooltip frames, leave them at zero.
1191 Avoids continued lines in tooltips. (Bug#11832)
1192
fa691a83
DA
11932012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1194
1195 Simplify copy_overlay.
04e9897c 1196 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1197 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1198
436bc8e0
EZ
11992012-07-23 Eli Zaretskii <eliz@gnu.org>
1200
1201 * print.c (print_object): Don't crash when a frame's name is nil
1202 or invalid. (Bug#12025)
1203
1204 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1205 it signals an error when a tooltip frame is being created.
1206
d7a7fda3
DA
12072012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 Cleanup miscellaneous objects allocation and initialization.
1210 * alloc.c (allocate_misc): Change to static. Add argument to
1211 specify the subtype. Adjust comment and users.
1212 (build_overlay): New function.
1213 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1214 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1215 (allocate_misc): Remove prototype.
1216 (build_overlay): Add prototype.
1217
12182012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1219
1220 Swap buffer text indirection counters in Fbuffer_swap_text.
1221 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1222 This avoids crash reported by Christoph Scholtes at
1223 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1224
9d7fa573
JD
12252012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1226
1227 * nsmenu.m (Popdown_data): New struct.
1228 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1229 free Popdown_data.
1230 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1231 (initWithContentRect): Make imgView and contentView non-static
1232 and autorelease them. Also autorelease img and matrix (Bug#12005).
1233 (dealloc): Remove (Bug#12005).
1234
0dd6d66d
DA
12352012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 Adjust consing_since_gc when objects are explicitly freed.
1238 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1239 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1240 (free_cons, free_misc): Subtract object size from consing_since_gc.
1241
d36d71df
DA
12422012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1243
1244 Simplify and cleanup markers positioning code.
1245 * marker.c (attach_marker): More useful eassert.
1246 (live_buffer, set_marker_internal): New function.
1247 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1248 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1249
fb9ea40f
PE
12502012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1253 as it's limited by the amount of memory, not by INT_MAX.
1254
2d5c5f7d
EZ
12552012-07-21 Eli Zaretskii <eliz@gnu.org>
1256
07fb592e
EZ
1257 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1258 in special-event-map. See the discussion at
1259 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1260 for the reasons.
1261
37a9eac8 1262 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1263 info.dwItemData. Fixes crashes on 64-bit Windows.
1264 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1265
c4328746
JD
12662012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1267
1268 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1269 (conversationIdentifier): Return value is NSInteger.
784051c4 1270 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1271
6e5d1c12
CY
12722012-07-21 Chong Yidong <cyd@gnu.org>
1273
1274 * window.c (decode_any_window): Signal an error if the window is
1275 on a dead frame (Bug#11984).
1276
9928463d
DA
12772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 Add indirection counting to speed up Fkill_buffer.
1280 * buffer.h (struct buffer): New member.
1281 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1282 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1283 base buffer indirection counter.
1284 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1285 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1286 through buffer list if indirection counter is 0.
1287
f8643a6b
DA
12882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Extend the value returned by Fgarbage_collect with heap statistics.
1291 * alloc.c (Qheap): New symbol.
1292 (syms_of_alloc): DEFSYM it.
1293 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1294 (Fmemory_free): Remove.
1295 (syms_of_alloc): Don't defsubr it.
1296 * buffer.c (Fcompact_buffer): Remove.
1297 (syms_of_buffer): Don't defsubr it.
1298
dac616ff
DA
12992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 Make maybe_gc inline.
1302 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1303 * lisp.h (consing_since_gc, gc_relative_threshold)
1304 (memory_full_cons_threshold): Revert declaration.
1305 (maybe_gc): Remove prototype, define as inline.
1306 * alloc.c: Remove old commented-out code.
1307 (consing_since_gc, gc_relative_threshold)
1308 (memory_full_cons_threshold): Revert to global.
1309 (maybe_gc): Remove.
1310
d7ea76b4
DA
13112012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1314 * lisp.h (build_unibyte_string): New function.
1315 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1316 * sysdep.c, w32fns.c, xfns.c: Use it.
1317 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1318 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1319 Adjust users accordingly.
1320 * font.h (font_open_by_name): Adjust prototype.
1321
765e61e3
DA
13222012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1323
1324 Cleanup calls to Fgarbage_collect.
1325 * lisp.h (maybe_gc): New prototype.
1326 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1327 Remove declarations.
1328 * alloc.c (maybe_gc): New function.
1329 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1330 Make them static.
1331 * bytecode.c (MAYBE_GC): Use maybe_gc.
1332 * eval.c (eval_sub, Ffuncall): Likewise.
1333 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1334 to avoid dependency from auto-save feature.
1335
52b852c7
PE
13362012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1339 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1340 'for_each_per_buffer_object_at'.
1341 All uses changed. It's better to use upper-case for macros that
1342 cannot be implemented as functions, to give the reader a clue
1343 that they're special.
1344
5db81e33
SM
13452012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1346
1347 * alloc.c (Fgarbage_collect): Tweak docstring.
1348
5b835e1d
DA
13492012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 Tweak the value returned from Fgarbage_collect again.
1352 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1353 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1354 Adjust documentation.
1355 (total_vector_bytes): Rename to total_vector_slots, adjust
1356 accounting.
1357 (total_free_vector_bytes): Rename to total_free_vector_slots,
1358 adjust accounting.
1359 (Qstring_bytes, Qvector_slots): New symbols.
1360 (syms_of_alloc): DEFSYM them.
1361
9cd47b72
DA
13622012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 Buffer compaction primitive which may be used from Lisp.
1365 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1366 (syms_of_buffer): Register Fcompact_buffer.
1367 * alloc.c (Fgarbage_collect): Use compact_buffer.
1368 * buffer.h (compact_buffer): New prototype.
1369 (struct buffer_text): New member.
1370
d17337e5
DA
13712012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1372
1373 New macro to iterate over all buffers, miscellaneous cleanups.
1374 * lisp.h (all_buffers): Remove declaration.
1375 * buffer.h (all_buffers): Add declaration, with comment.
1376 (for_each_buffer): New macro.
1377 * alloc.c (Fgarbage_collect, mark_object): Use it.
1378 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1379 (init_buffer): Likewise.
1380 * data.c (Fset_default): Likewise.
1381 * coding.c (code_conversion_restore): Remove redundant check
1382 for dead buffer.
1383 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1384
60cfd278
AS
13852012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1386
1387 Fix bug that created negative-length intervals.
1388 * intervals.c (merge_interval_right, merge_interval_left):
1389 Do not zero out this interval if it is absorbed by its children,
1390 as this interval's total length doesn't change in that case. See
1391 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1392
d06714cb
PE
13932012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1394
83713154
PE
1395 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1396 when invoking (make-bool-vector N t) and N is a positive
1397 multiple of 8 -- the last 8 bits were mistakenly cleared.
1398
d06714cb
PE
1399 Remove some struct layout assumptions in bool vectors.
1400 * alloc.c (bool_header_size): New constant.
1401 (header_size, word_size): Move earlier, as they're now used earlier.
1402 Use 'word_size' in a few more places, where it's appropriate.
1403 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1404 padding before the data member of a bool vector.
1405 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1406 than doing the check by hand with an abort ().
1407
464d5a5e
SM
14082012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1409
5fbc0409
SM
1410 * eval.c (Fdefvar): Don't check constants since we only set the var if
1411 it's not yet defined anyway (bug#11904).
1412
464d5a5e
SM
1413 * lisp.h (last_undo_boundary): Declare new var.
1414 * keyboard.c (command_loop_1): Set it.
1415 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1416 were auto-added by the command loop (bug#11774).
1417
8dc2e44a
AS
14182012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1419
1420 * w32font.c (Qsymbol): Remove local definition.
1421 (syms_of_w32font): Don't DEFSYM it.
1422
169925ec
DA
14232012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1424
1425 Fix sweep_vectors to handle large bool vectors correctly.
1426 * alloc.c (sweep_vectors): Account total_vector_bytes for
1427 bool vectors larger than VBLOCK_BYTES_MAX.
1428
5fbfb018
CY
14292012-07-18 Chong Yidong <cyd@gnu.org>
1430
1431 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1432 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1433
3ab6e069
DA
14342012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 Return more descriptive data from Fgarbage_collect.
1437 Suggested by Stefan Monnier in
1438 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1439 * alloc.c (bounded_number): New function.
1440 (total_buffers, total_vectors): New variable.
1441 (total_string_size): Rename to total_string_bytes, adjust users.
1442 (total_vector_size): Rename to total_vector_bytes, adjust users.
1443 (sweep_vectors): Account total_vectors and total_vector_bytes.
1444 (Fgarbage_collect): New return value. Adjust documentation.
1445 (gc_sweep): Account total_buffers.
1446 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1447 (VECTOR_SIZE): Remove.
1448 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1449 (Qinterval, Qmisc): New symbols.
1450 (syms_of_data): Initialize them.
1451 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1452 (Qcons, Qbuffer): New declarations.
1453
6d02fe5b
PE
14542012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1457 Round up, not down. Improve doc.
1458
b7ffe040
DA
14592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1460
1461 Restore old code in allocate_string_data to avoid Faset breakage.
1462 Reported by Julien Danjou <julien@danjou.info> in
1463 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1464 * alloc.c (allocate_string_data): Restore old code with minor
1465 adjustments, fix comment to explain this subtle issue.
1466
4dc7c8d5
SM
14672012-07-17 Eli Zaretskii <eliz@gnu.org>
1468
1469 Remove FILE_SYSTEM_CASE.
1470 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1471
1472 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1473 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1474 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1475 call-process-region passes it through expand-file-name.
1476
1477 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1478
14792012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 Fix crash when creating indirect buffer (Bug#11917)
1482 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1483 Don't handle unbound variables specially if non-zero.
1484 (Fbuffer_local_variables): Pass zero.
1485 (clone_per_buffer_values): Pass non-zero.
1486
14872012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1488
1489 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1490 to make the loop interruptible.
1491
14922012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1493
1494 * gnutls.c (emacs_gnutls_handshake): Only retry if
1495 GNUTLS_E_INTERRUPTED.
1496
cce7fefc
DA
14972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1498
1499 Cleanup and convert miscellaneous checks to eassert.
1500 * alloc.c (mark_interval): Fix comment, partially rephrase
1501 old comment from intervals.h (see below).
1502 * intervals.c (find_interval, adjust_intervals_for_insertion)
1503 (delete_interval, adjust_intervals_for_deletion)
1504 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1505 Convert to eassert.
1506 (adjust_intervals_for_insertion, make_new_interval):
1507 Remove obsolete and unused code.
1508 * intervals.h (struct interval): Remove obsolete comment.
1509 * textprotp.c (erase_properties): Remove unused code.
1510 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1511 (Fremove_list_of_text_properties): Convert to eassert.
1512
9ea10cc3
CY
15132012-07-17 Chong Yidong <cyd@gnu.org>
1514
1515 * editfns.c (Finsert_char): Doc fix.
1516
3900d5de
DA
15172012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1518
1519 Fix previous change to make Fmemory_free always accurate.
1520 * alloc.c (make_interval): Update total_free_intervals.
1521 (make_float): Likewise for total_free_floats.
1522 (free_cons, Fcons): Likewise for total_free_conses.
1523 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1524 Likewise for total_free_vector_bytes.
1525 (Fmake_symbol): Likewise for total_free_symbols.
1526 (bytes_free): Remove.
1527
7098646f
DA
15282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1529
1530 Simple free memory accounting feature.
1531 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1532 (sweep_vectors): Accumulate size of free vectors.
1533 (Fgarbage_collect): Setup bytes_free.
1534 (Fmemory_free): New function.
1535 (syms_of_alloc): Register it.
1536
22657b40
DA
15372012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1538
1539 Cleanup overlays checking.
1540 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1541 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1542 eassert and OVERLAYP.
1543 (sort_overlays): Change to use OVERLAYP.
1544
ddfc8813
RK
15452012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1546
1547 * editfns.c (Finsert_char): Make it interactive, and make the
1548 second arg optional. Copy interactive spec and docstring from
1549 ucs-insert.
1550
7c26cf3c
PE
15512012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1552
1553 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1554 Unlike the other wrapped functions, fabs has an unspecified
1555 effect on errno.
1556
5d127af9
JD
15572012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1558
1559 * nsterm.m (keyDown): Interpret flags without left/right bits
1560 as the left key (Bug#11670).
1561
6a0dd1d7
DA
15622012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1563
1564 Remove empty and useless init functions.
1565 * lisp.h (init_character_once, init_fns, init_image)
1566 (init_filelock, init_sound): Remove prototype.
1567 * character.c (init_character_once): Remove.
1568 * filelock.c (init_filelock): Likewise.
1569 * fns.c (init_fns): Likewise.
1570 * image.c (init_image): Likewise.
1571 * sound.c (init_sound): Likewise.
1572 * emacs.c (main): Adjust accordingly.
1573
7a6136fd
DA
15742012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1575
1576 * gtkutil.h: Tiny cleanups.
1577 (use_old_gtk_file_dialog): Remove useless declaration.
1578 (xg_uses_old_file_dialog): Add suggested const attribute.
1579
ce811ad9
EZ
15802012-07-15 Eli Zaretskii <eliz@gnu.org>
1581
1582 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1583 (bidi_paragraph_init): Use it to limit search forward for a strong
1584 directional character in abnormally large paragraphs full of
1585 neutral or weak characters. (Bug#11943)
1586
c9adfeaa
SF
15872012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1588
1589 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1590 the toolbar (Bug#9451).
1591 (xg_make_tool_item): Give the widget event box a transparent
1592 background.
1593
fff62aa9
DA
15942012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1595
1596 Cleanup basic allocation variables and functions.
1597 * alloc.c (ignore_warnings, init_intervals, init_float)
1598 (init_cons, init_symbol, init_marker): Remove.
1599 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1600 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1601 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1602 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1603 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1604 (staticidx, init_alloc_once, init_strings, free_ablock):
1605 Remove redundant initialization.
1606 * fns.c (init_weak_hash_tables): Remove.
1607 * lisp.h (init_weak_hash_tables): Remove prototype.
1608
9730daca
DA
16092012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1610
1611 Use zero_vector where appropriate.
1612 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1613 accordingly.
1614 * lisp.h (zero_vector): New declaration.
1615 * font.c (null_vector): Remove.
1616 (syms_of_font): Remove initialization and staticpro.
1617 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1618 * keymap.c (Faccessible_keymaps): Likewise.
1619
2e2d2a13
LL
16202012-07-15 Leo Liu <sdl.web@gmail.com>
1621
1622 * fringe.c: Fix typo in comments.
1623
cd276f6e
LL
16242012-07-14 Leo Liu <sdl.web@gmail.com>
1625
1626 * fringe.c: Add a new bitmap exclamation-mark.
1627
5a1131d9
EZ
16282012-07-14 Eli Zaretskii <eliz@gnu.org>
1629
1630 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1631
1632 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1633 (HAVE_MENUS): Don't define, defined by editing config.in with
1634 msdos/sed2v2.inp.
1635 (GMALLOC_INHIBIT_VALLOC): Don't define.
1636 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1637
22e983b7
JB
16382012-07-14 Juanma Barranquero <lekktu@gmail.com>
1639
1640 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1641
5b3f250f
GM
16422012-07-14 Glenn Morris <rgm@gnu.org>
1643
1644 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1645 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1646 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1647
33d63ff4
GM
16482012-07-13 Glenn Morris <rgm@gnu.org>
1649
5b633342
GM
1650 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1651
33d63ff4
GM
1652 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1653 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1654
b55b9f85
JD
16552012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1656
0dc8cf50
JD
1657 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1658 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1659 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1660 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1661 where appropriate.
1662 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1663 as boolean expression.
1664 (x_set_window_size): Remove unused variable toolbar.
1665 (ns_get_color_default, ns_mod_to_lisp): Remove.
1666 (ns_mouse_position): Remove unused variables xchar and ychar.
1667 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1668 (ns_set_vertical_scroll_bar): Remove unused variable count.
1669 (ns_delete_terminal): Remove unused variable i.
1670 (ns_term_init): Remove unused variables r, g and b.
1671 (mouseDown): Remove unused variable window.
1672 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1673 (initFrameFromEmacs): Remove unused variable vbextra.
1674 (mouseEntered): Remove unused variables p and dpyinfo.
1675 (mouseExited): Remove unused variables p and r.
1676 (ns_define_frame_cursor, ns_clear_frame_area)
1677 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1678 (menuDown): Assign [sender tag] to variable and cast the variable.
1679
1680 * nsterm.h (menuDown): Add id as type to argument sender.
1681 (ns_display_info_for_name): Add Lisp_Object argument.
1682 (ns_term_init): Add Lisp_Object argument.
1683 (ns_map_event_to_object): Add void argument.
1684 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1685 prototype with arguments and only declare if __OBJC__.
1686 (nxatoms_of_nsselect): Add void argument.
1687 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1688 (ns_alloc_autorelease_pool): Add void argument.
1689 (ns_release_autorelease_pool): Add void* argument.
1690 (ns_get_defaults_value): Add const char* argument.
1691
1692 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1693 (initFromContents): Use SSDATA where appropriate.
1694 (ns_update_menubar): Add braces to ambigous if-else.
1695 (initWithTitle): Put () around assignment in if statement.
1696 (ns_menu_show): Remove unused variables window and keymap.
1697 (update_frame_tool_bar): Remove unused variable selected_p.
1698 (initWithContentRect): Remove unused variable this_cmd_name.
1699
1700 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1701 appropriate.
1702 (setXBMColor): Remove unused variable len.
1703 (setPixmapData): Put () around assignment in loop statement.
1704
1705 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1706 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1707 where appropriate.
1708 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1709 around assignment in loop statement.
1710 (nsfont_open): Remove unused variable i.
1711 (nsfont_open): Remove unused variable len.
1712 (nsfont_draw): Remove unused variable cs.
1713
1714 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1715 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1716 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1717 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1718 (Fns_font_name, Fns_perform_service)
1719 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1720 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1721 (ns_set_name): Remove unused variable view.
1722 (x_set_menu_bar_lines): Remove unused variable olines.
1723 (x_set_tool_bar_lines): Remove unused variable root_window.
1724 (Fns_list_colors): Put () around assignment in while statement.
1725 (Fns_perform_service): Remove unused variable len.
1726 (Fns_display_usable_bounds): Remove unused variable top.
1727 (syms_of_nsfns): Remove unused variable i.
1728
b55b9f85
JD
1729 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1730 memcpy (Bug#11907).
1731
ed9265fc 17322012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1733
1734 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1735 and free it with DestroyExceptionInfo (Bug#11558).
1736
ef099b57
JB
17372012-07-13 Juanma Barranquero <lekktu@gmail.com>
1738
1739 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1740 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1741 Set here, not in nt/config.nt.
1742
ea814a5d
EZ
17432012-07-13 Eli Zaretskii <eliz@gnu.org>
1744
1745 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1746 cursor overflow into the last glyph on display line when the right
1747 fringe is off. (Bug#11832)
1748
1a952767
PE
17492012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * xdisp.c (produce_special_glyphs): Now static.
1752 * dispextern.h (produce_special_glyphs): Remove decl.
1753
983188fd
GM
17542012-07-13 Glenn Morris <rgm@gnu.org>
1755
8d7c7eed 1756 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1757 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1758
983188fd
GM
1759 * s/usg5-4-common.h (USG, USG5):
1760 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1761 * s/sol2-6.h (SOLARIS2):
1762 * s/irix6-5.h (IRIX6_5):
1763 * s/hpux10-20.h (USG, USG5, HPUX):
1764 * s/gnu-linux.h (USG, GNU_LINUX):
1765 * s/freebsd.h (BSD_SYSTEM):
1766 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1767 * s/cygwin.h (CYGWIN):
1768 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1769 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1770
d1e68667 17712012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1772
1773 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1774
6de0e799
GM
17752012-07-13 Glenn Morris <rgm@gnu.org>
1776
739ae010
GM
1777 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1778
dbee5793
GM
1779 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1780
6de0e799
GM
1781 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1782 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1783
b82da769
GM
17842012-07-12 Glenn Morris <rgm@gnu.org>
1785
4fae5a7a 1786 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1787
1788 * process.c (init_process_emacs): Rename from init_process.
1789 The old name is also the name of a Mach system call.
1790 * lisp.h, emacs.c: Update for this name change.
1791 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1792 longer needed.
1793
5a979817
EZ
17942012-07-12 Eli Zaretskii <eliz@gnu.org>
1795
1796 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1797 memmove call that removes glyphs covered by the left truncation
1798 glyph. Improve commentary.
1799 (display_line): Fix display of continuation glyphs on GUI frames
1800 when the right fringe is turned off and variable-size fonts are
1801 used in the window. Move the code that appends a stretch glyph to
1802 produce_special_glyphs, so that it could be used for truncation
1803 and continuation glyphs alike.
1804 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1805 glyph of a suitably computed width, to align the special glyphs at
1806 the window margin. Code moved from display_line. (Bug#11832)
1807
3e91a053
GM
18082012-07-12 Glenn Morris <rgm@gnu.org>
1809
ba9e4b84
GM
1810 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1811
1812 * s/gnu-linux.h, s/hpux10-20.h:
1813 Do not unconditionally define HAVE_XRMSETDATABASE.
1814
3e91a053
GM
1815 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1816
b300b1f4
PE
18172012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 Fix typos that broke OS X build.
1820 Reported by Randal L. Schwartz in
1821 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1822 * nsterm.m (ns_timeout): Add missing local decl.
1823 (ns_get_color): snprintf -> sprintf, to fix typo.
1824
6e777848
GM
18252012-07-12 Glenn Morris <rgm@gnu.org>
1826
3f922c37
GM
1827 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1828 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1829 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1830 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1831
0ab7b23a
GM
1832 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1833 Move PTY_OPEN to configure.
1834
6e777848
GM
1835 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1836 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1837 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1838
4a7edc24
DA
18392012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1840
1841 Use empty_unibyte_string where applicable.
1842 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1843 * lread.c (read1): Likewise.
1844 * xsettings.c (syms_of_xsettings): Likewise.
1845
308aab79
GM
18462012-07-12 Glenn Morris <rgm@gnu.org>
1847
42bd1719
GM
1848 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1849 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1850 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1851 * s/hpux10-20.h (RUN_TIME_REMAP):
1852 * s/bsd-common.h (TABDLY): Move to configure.
1853
1854 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1855
1856 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1857
ea0bbd17 1858 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1859 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1860
1861 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1862
308aab79
GM
1863 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1864 * s/template.h: Move NARROWPROTO to configure.
1865
ee1cf5cf
GM
18662012-07-11 Glenn Morris <rgm@gnu.org>
1867
30fe9bf4
GM
1868 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1869 unused since 2011-01-17 change to systty.h.
1870
ee1cf5cf
GM
1871 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1872 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1873 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1874
63e47e07
PE
18752012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1878
c43fb4c3
GM
18792012-07-11 Glenn Morris <rgm@gnu.org>
1880
1881 * s/darwin.h, s/gnu-linux.h, s/template.h:
1882 Move INTERRUPT_INPUT to configure.
1883
e8df9267
DA
18842012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1885
1886 Minor adjustments to interning code.
1887 * lisp.h (intern, intern_c_string): Redefine as static inline
1888 wrappers for intern_1 and intern_c_string_1, respectively.
1889 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1890 * lread.c (intern_1, intern_c_string_1, oblookup):
1891 Simplify Vobarray checking.
e8df9267
DA
1892 * font.c (font_intern_prop): Likewise. Adjust comment.
1893 * w32font.c (intern_font_name): Likewise.
1894
34348bd4
AS
18952012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1896
d96a1e0c
AS
1897 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1898
34348bd4
AS
1899 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1900 of Fcar/Fcdr if possible.
1901 * font.c (check_otf_features): Likewise.
1902 * fontset.c (Fnew_fontset): Likewise.
1903 * gnutls.c (Fgnutls_boot): Likewise.
1904 * minibuf.c (read_minibuf): Likewise.
1905 * msdos.c (IT_set_frame_parameters): Likewise.
1906 * xmenu.c (Fx_popup_dialog): Likewise.
1907 * w32menu.c (Fx_popup_dialog): Likewise.
1908
c8add24e
GM
19092012-07-11 Glenn Morris <rgm@gnu.org>
1910
4b575b3c
GM
1911 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1912 since nothing has defined it on these platforms.
1913
09f4e3b0
GM
1914 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1915 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1916
172bedef
GM
1917 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1918 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1919 Move CLASH_DETECTION to configure.
1920
249685df
GM
1921 * s/gnu.h: Remove file, which is now empty.
1922
c8add24e
GM
1923 * s/gnu.h, s/gnu-linux.h:
1924 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1925
b41253a3
JW
19262012-07-11 John Wiegley <johnw@newartisans.com>
1927
1928 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1929 function attribute, so we only use it if it exists in the
1930 compiler.
1931
d923b542
DA
19322012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1933
1934 Avoid call to strlen in fast_c_string_match_ignore_case.
1935 * search.c (fast_c_string_match_ignore_case): Change to use
1936 length argument. Adjust users accordingly.
1937 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1938
5ebbef1d
PE
19392012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1940
bb352260
PE
1941 Assume mkdir, rmdir.
1942 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1943 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1944
57054ddd
PE
1945 Assume rename.
1946 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1947
b747d3f7
PE
1948 Assume perror.
1949 * s/hpux10-20.h (HAVE_PERROR): Remove.
1950 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1951 Remove dummy definition, as this problem was obsolete long ago.
1952
5ebbef1d
PE
1953 Assume strerror.
1954 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1955
984e7f30
DA
19562012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1957
1958 Avoid calls to strlen in font processing functions.
1959 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1960 (font_open_by_name): Change to use length argument.
1961 Adjust users accordingly.
d923b542
DA
1962 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1963 Adjust prototypes.
1964 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1965 Change to return ptrdiff_t.
984e7f30
DA
1966 (xfont_list_pattern, xfont_match): Use length returned by
1967 xfont_decode_coding_xlfd.
1968 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1969
20e94fdd
GM
19702012-07-11 Glenn Morris <rgm@gnu.org>
1971
9d596af3
GM
1972 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1973 Move DONT_REOPEN_PTY to configure.
1974
20e94fdd
GM
1975 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1976 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1977
e99a530f
PE
19782012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1979
22ffb973
PE
1980 Remove "#define unix" that is no longer needed (Bug#11905).
1981 * s/aix4-2.h (unix): Remove; no longer needed.
1982
e9a9ae03
PE
1983 EMACS_TIME simplification (Bug#11875).
1984 This replaces macros (which typically do not work in GDB)
1985 with functions, typedefs and enums, making the code easier to debug.
1986 The functional style also makes code easier to read and maintain.
1987 * systime.h: Include <sys/time.h> on all hosts, not just if
1988 WINDOWSNT, since 'struct timeval' is needed in general.
1989 (EMACS_TIME): Now a typedef, not a macro.
1990 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1991 not macros.
1992 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1993 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1994 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1995 (EMACS_TIME_LE): Now functions, not macros.
1996 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1997 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1998 which are not functions. All uses rewritten to use:
1999 (make_emacs_time): New function.
2000 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2001 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2002 not functions. All uses rewritten to use the following, respectively:
2003 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2004 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2005 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2006 * fileio.c (Fcopy_file):
2007 * xterm.c (XTflash): Get the current time closer to when it's used.
2008 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2009
ffacb126
PE
2010 * bytecode.c (targets): Suppress -Woverride-init warnings.
2011
e99a530f
PE
2012 Simplify by avoiding confusing use of strncpy etc.
2013 * doc.c (Fsnarf_documentation):
2014 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2015 * frame.c (Fmake_terminal_frame):
2016 * gtkutil.c (get_utf8_string):
2017 * lread.c (openp):
2018 * nsmenu.m (ns_update_menubar):
2019 * regex.c (regerror):
2020 Prefer memcpy to strncpy and strncat when either will do.
2021 * fileio.c (Fsubstitute_in_file_name):
2022 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2023 (menu_separator_name_p):
2024 * nsmenu.m (ns_update_menubar):
2025 Prefer memcmp to strncmp when either will do.
2026 * nsterm.m: Include <ftoastr.h>.
2027 (ns_get_color):
2028 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2029 Prefer snprintf to strncpy.
2030 * nsterm.m (ns_term_init):
2031 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2032 * nsterm.m (ns_term_init):
2033 Avoid the need for strncpy, by using build_string or
2034 make_unibyte_string directly. Use dtoastr, not snprintf.
2035 * process.c (Fmake_network_process): Diagnose service names that
2036 are too long, rather than silently truncating them or creating
2037 non-null-terminated names.
2038 (Fnetwork_interface_info): Likewise, for interface names.
2039 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2040 Prefer sprintf to strncat.
2041 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2042 Prefer vsnprintf to vsprintf + strncpy.
2043
c59592b3
GM
20442012-07-10 Glenn Morris <rgm@gnu.org>
2045
2046 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2047 Clarify fallback case.
2048
7d7bbefd
DA
20492012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2050
2051 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2052 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2053 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2054 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2055 where argument type is known to be a Lisp_Cons.
2056
3a4c8000
TT
20572012-07-10 Tom Tromey <tromey@redhat.com>
2058
2059 * bytecode.c (BYTE_CODE_THREADED): New macro.
2060 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2061 (enum byte_code_op): New type.
2062 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2063 (exec_byte_code): Use them. Use token threading when applicable.
2064
2a0213a6
DA
20652012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2066
2067 Optimize pure C strings initialization.
2068 * lisp.h (make_pure_string): Fix prototype.
2069 (build_pure_c_string): New function, defined as static inline. This
2070 provides a better opportunity to optimize away calls to strlen when
2071 the function is called with compile-time constant argument.
2072 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2073 argument, adjust users accordingly. Use build_pure_c_string where
2074 appropriate.
2075 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2076 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2077 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2078
cb1caeaf
DA
20792012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2080
2081 Avoid calls to strlen in miscellaneous functions.
2082 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2083 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2084 * lread.c (openp): Likewise.
2085
c293e30c
DA
20862012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2087
2088 Avoid calls to strlen in path processing functions.
2089 * fileio.c (file_name_as_directory): Add comment. Change to add
2090 srclen argument and return the length of result. Adjust users
2091 accordingly.
2092 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2093 swap 1st and 2nd arguments to obey the common convention.
2094 Adjust users accordingly.
c293e30c
DA
2095 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2096
9e059e3f
GM
20972012-07-10 Glenn Morris <rgm@gnu.org>
2098
d02eb359
GM
2099 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2100 Move PENDING_OUTPUT_COUNT definition to configure.
2101
882cf227
GM
2102 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2103 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2104 * s/gnu.h (DATA_START): Move definitions to configure.
2105
af6e839f
GM
2106 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2107 We include usg5-4-common.h, which defines them both.
2108
40289a12
GM
2109 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2110 O_RDONLY already includes it).
2111
9e059e3f
GM
2112 Stop ns builds setting the EMACSLOADPATH environment variable.
2113 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2114 Now it does not set EMACSLOADPATH, just returns the load-path string.
2115 * nsterm.h: Update accordingly.
2116 * lread.c [HAVE_NS]: Include nsterm.h.
2117 (init_lread) [HAVE_NS]: Use ns_load_path.
2118 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2119
7c4e8ec0
GM
21202012-07-09 Glenn Morris <rgm@gnu.org>
2121
d4f600ff
GM
2122 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2123 since the included bsd-common.h does so.
2124
cbb31951
GM
2125 Stop ns builds setting the EMACSPATH environment variable.
2126 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2127 (ns_init_paths): Do not set EMACSPATH.
2128 * nsterm.h (ns_exec_path): Add it.
2129 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2130 Use ns_exec_path.
2131
7c4e8ec0
GM
2132 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2133
26bccfae
PE
21342012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2135
a0bee46f
PE
2136 * process.c (wait_reading_process_output): 'waitchannels' was unset
2137 when read_kbd || !NILP (wait_for_cell); fix this.
2138
5994c183
PE
2139 Add GCC-style 'const' attribute to functions that can use it.
2140 * character.h (char_resolve_modifier_mask):
2141 * keyboard.h (make_ctrl_char):
2142 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2143 (init_character_once, next_almost_prime, init_fns, init_image)
2144 (flush_pending_output, init_sound):
2145 * mem-limits.h (start_of_data):
2146 * menu.h (finish_menu_items):
2147 Add ATTRIBUTE_CONST.
2148 * emacs.c (DEFINE_DUMMY_FUNCTION):
2149 Declare the dummy function with ATTRIBUTE_CONST.
2150 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2151 Add decls with ATTRIBUTE_CONST.
2152
26bccfae
PE
2153 Minor improvements to make_formatted_string.
2154 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2155 where int is good enough, as vsprintf returns an int.
2156 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2157
a8290ec3
DA
21582012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2159
2160 Use make_formatted_string to avoid double length calculation.
2161 * lisp.h (make_formatted_string): New prototype.
2162 * alloc.c (make_formatted_string): New function.
2163 * buffer.c (Fgenerate_new_buffer_name): Use it.
2164 * dbus.c (syms_of_dbusbind): Likewise.
2165 * editfns.c (Fcurrent_time_zone): Likewise.
2166 * filelock.c (get_boot_time): Likewise.
2167 * frame.c (make_terminal_frame, set_term_frame_name)
2168 (x_report_frame_params): Likewise.
2169 * image.c (gs_load): Likewise.
2170 * minibuf.c (get_minibuffer): Likewise.
2171 * msdos.c (dos_set_window_size): Likewise.
2172 * process.c (make_process): Likewise.
2173 * xdisp.c (ensure_echo_area_buffers): Likewise.
2174 * xsettings.c (apply_xft_settings): Likewise.
2175
d01ba2f1
GM
21762012-07-09 Glenn Morris <rgm@gnu.org>
2177
2178 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2179 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2180 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2181 * nsterm.h (ns_etc_directory): Add it.
2182 * callproc.c [HAVE_NS]: Include nsterm.h.
2183 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2184
f1f924b6
DA
21852012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 Move marker debugging code under MARKER_DEBUG.
2188 * marker.c (MARKER_DEBUG): Move marker debugging code under
2189 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2190 for bootstrap with --enable-checking (~3x slowdown reported
2191 by Juanma Barranquero <lekktu@gmail.com>).
2192 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2193
ab531b66
PE
21942012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2195
2196 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2197 See <http://bugs.gnu.org/11825#29>.
2198
c4b3bc8a
EZ
21992012-07-08 Eli Zaretskii <eliz@gnu.org>
2200
2201 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2202 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2203 (display_line): Add commentary about displaying truncation glyphs
2204 on GUI frames.
2205 (produce_special_glyphs): Move here from term.c.
2206
2207 * term.c (produce_special_glyphs): Move to xdisp.c.
2208
2209 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2210 section.
c4b3bc8a 2211
b676b881
AS
22122012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2213
f17c5273
AS
2214 * xdisp.c (display_line): Avoid warning about implicit declaration
2215 of FRAME_FONT.
2216
298819b9
AS
2217 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2218
b676b881
AS
2219 * lisp.h: Remove empty conditional.
2220
6045c4fd
PE
22212012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2222
b3350bf9
PE
2223 * lread.c (load_path_check): Now static.
2224
6045c4fd
PE
2225 Fix some minor --with-ns problems found by static checking.
2226 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2227 (x_set_font) [!HAVE_X_WINDOWS]:
2228 * image.c (xpm_load_image) [HAVE_NS]:
2229 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2230 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2231 Remove unused local.
2232 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2233 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2234 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2235 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2236 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2237 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2238 Fix pointer signedness problem.
2239 * xfaces.c (FRAME_X_FONT_TABLE):
2240 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2241
929e7845
GM
22422012-07-07 Glenn Morris <rgm@gnu.org>
2243
2244 * lread.c (load_path_check): New function, split from init_lread.
2245 (init_lread): Reorganize. Motivation:
2246 If EMACSLOADPATH is set, check/warn about that rather than the
2247 defaults, which we are not going to use. Hence we can remove
2248 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2249 Don't warn if site-lisp directories are missing.
2250 If not installed, start from a blank load-path, since
2251 PATH_LOADSEARCH refers to the eventual installation directories.
2252
58dd0aa4
EZ
22532012-07-07 Eli Zaretskii <eliz@gnu.org>
2254
2255 Support truncation and continuation glyphs on GUI frames, when
2256 fringes are disabled. (Bug#11832)
2257 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2258 continuation glyphs even if on GUI frames.
2259 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2260 or both, are absent.
2261 (start_display, move_it_in_display_line_to): Handle the case of a
2262 GUI frame without a fringe to display continuation or truncation
2263 glyphs.
2264 (insert_left_trunc_glyphs): Support GUI frames: make sure
2265 truncation glyphs overwrite enough glyphs from the current line to
2266 have sufficient space in pixels.
2267 (display_line): Support truncation and continuation glyphs on GUI
2268 frames. If some spare pixels are left on the line after inserting
2269 the truncation glyphs, fill that space with a stretch glyph of a
2270 suitably computed width.
2271
2272 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2273 produce_glyphs, to support GUI sessions.
2274
31571fd7
PE
22752012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2276
5a16b9bc
PE
2277 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2278
f3047c75
PE
2279 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2280
31571fd7
PE
2281 Do not require float-time's arg to fit in time_t (Bug#11825).
2282 This works better on hosts where time_t is unsigned, and where
2283 float-time is applied to the (negative) difference between two times.
2284 * editfns.c (decode_time_components): Last arg is now double *,
2285 not int *, and means to store all the result as a double, without
2286 worrying about whether the seconds part fits in time_t.
2287 All callers changed.
2288 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2289 All callers changed.
2290 (Ffloat_time): Do not fail merely because the specified time falls
2291 outside of time_t range.
2292
4516fbef
GM
22932012-07-07 Glenn Morris <rgm@gnu.org>
2294
2295 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2296 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2297 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2298
07adc2c6
JB
22992012-07-07 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2302 Update dependencies.
2303
2304 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2305
fd573f31
PE
23062012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2307
fee5959d
PE
2308 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2309 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2310 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2311 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2312 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2313 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2314
fd573f31
PE
2315 * xfont.c (compare_font_names): Redo to omit the need for casts.
2316
ddadbc0e
AS
23172012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2318
fca8d6b6
AS
2319 * xfns.c (Fx_change_window_property): Doc fix.
2320 * w32fns.c (Fx_change_window_property): Doc fix.
2321
ddadbc0e
AS
2322 * w32fns.c (Fx_window_property): Accept the same arguments as the
2323 X Windows version. Doc fix.
2324 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2325
ed9265fc 23262012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2327 Eli Zaretskii <eliz@gnu.org>
2328
2329 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2330 Windows-specific code from nt/config.nt moved here.
2331 Obsolete settings removed.
2332
216ee680
PE
23332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 * process.c: Avoid unnecessary calls to gettime.
2336 (wait_reading_process_output): Don't get the time of day
2337 when gobbling data immediately and not waiting, as there's no need
2338 for it in that case. This removes a FIXME.
2339
bdd091e4
JD
23402012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2341
2342 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2343 is defined (Bug#11768).
2344
9d44f8ce
DA
23452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2346
2347 Fix marker debugging code.
2348 * marker.c (byte_char_debug_check): Do not perform the check
2349 if buffer is not multibyte.
090bd7cb
JB
2350 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2351 Call byte_char_debug_check with correct arguments.
9d44f8ce 2352
90fc4786
DA
23532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2354
2355 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2356 * marker.c (byte_char_debug_check, count_markers):
2357 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2358 (byte_debug_flag): Remove.
2359 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2360 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2361
7b7ae965
DA
23622012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2363
4e57b342
DA
2364 Avoid code repetition in marker-related functions.
2365 * marker.c (attach_marker): New function.
2366 (Fset_marker, set_marker_restricted, set_marker_both)
2367 (set_marker_restricted_both): Use it.
2368 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2369 Consistently rename charno to charpos.
2370 (marker_position): Add eassert.
2371 (marker_byte_position): Convert to eassert.
2372
23732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2376 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2377 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2378
657924ff
DA
23792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2380
2381 Introduce fast path for the widely used marker operation.
2382 * alloc.c (build_marker): New function.
2383 * lisp.h (build_marker): New prototype.
2384 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2385 * composite.c (autocmp_chars): Likewise.
2386 * editfns.c (buildmark): Remove.
2387 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2388 (save_restriction_save): Use build_marker.
2389 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2390 * window.c (save_window_save): Likewise.
2391
041a49a6
DA
23922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2393
2394 Do not use Fdelete_overlay in delete_all_overlays
2395 to avoid redundant calls to unchain_overlay.
2396 * buffer.c (drop_overlay): New function.
2397 (delete_all_overlays, Fdelete_overlay): Use it.
2398 * minibuf.c (get_minibuffer): Fix comment.
2399
7dca65a4
PE
24002012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Port to OpenBSD 5.1 amd64.
2403 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2404 This is needed for OpenBSD, and should be harmless on all BSD systems.
2405 Also, include <sys/sysctl.h>, as it should be available on all
2406 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2407 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2408 use p_pid member, not kp_proc.pid.
2409
8eb876e2
GM
24102012-07-06 Glenn Morris <rgm@gnu.org>
2411
2412 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2413
38182d90
PE
24142012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 More xmalloc and related cleanup.
2417 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2418 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2419 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2420 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2421 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2422 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2423 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2424 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2425 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2426 * xterm.c:
2427 Omit needless casts involving void * pointers and allocation.
2428 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2429 as the former is more robust if P's type is changed.
2430 Prefer xzalloc to xmalloc + memset 0.
2431 Simplify malloc-or-realloc to realloc.
2432 Don't worry about xmalloc returning a null pointer.
2433 Prefer xstrdup to xmalloc + strcpy.
2434 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2435 growing it.
2436 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2437 alloca of a constant.
2438
6dd5a677
EZ
24392012-07-05 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2442 hscroll is larger than the line width. Fixes long and futile
2443 looping inside extend_face_to_end_of_line (on a TTY) producing
2444 glyphs that are not needed and thrown away.
2445
6b312f0f
DA
24462012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2447
2448 * marker.c (set_marker_restricted_both): Simplify by using
2449 clip_to_bounds.
2450
f520ef9b
PE
24512012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2454
383b7c95
JD
24552012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2456
2457 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2458 not defined (Bug#11768).
2459 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2460 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2461 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2462 followed by gtk_box_set_homogeneous (Bug#11768).
2463 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2464 (update_theme_scrollbar_width, xg_create_scroll_bar):
2465 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2466 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2467 (is_box_type): New function (Bug#11768).
2468 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2469 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2470 with default display (Bug#11768).
2471
d6e7bf45
EZ
24722012-07-05 Eli Zaretskii <eliz@gnu.org>
2473
2474 * xdisp.c (window_hscroll_limited): New function.
2475 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2476 coordinates when window's hscroll is set to insanely large
2477 values. (Bug#11857)
2478
431391ec
JB
24792012-07-05 Juanma Barranquero <lekktu@gmail.com>
2480
2481 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2482 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2483
23f86fce
DA
24842012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2485
2486 Cleanup xmalloc.
2487 * lisp.h (xzalloc): New prototype. Omit needless casts.
2488 * alloc.c (xzalloc): New function. Omit needless casts.
2489 * charset.c: Omit needless casts. Convert all calls to
2490 xmalloc with following memset to xzalloc.
2491 * dispnew.c: Likewise.
2492 * fringe.c: Likewise.
2493 * image.c: Likewise.
2494 * sound.c: Likewise.
2495 * term.c: Likewise.
2496 * w32fns.c: Likewise.
2497 * w32font.c: Likewise.
2498 * w32term.c: Likewise.
2499 * xfaces.c: Likewise.
2500 * xfns.c: Likewise.
2501 * xterm.c: Likewise.
2502 * atimer.c: Omit needless casts.
2503 * buffer.c: Likewise.
2504 * callproc.c: Likewise.
2505 * ccl.c: Likewise.
2506 * coding.c: Likewise.
2507 * composite.c: Likewise.
2508 * doc.c: Likewise.
2509 * doprnt.c: Likewise.
2510 * editfns.c: Likewise.
2511 * emacs.c: Likewise.
2512 * eval.c: Likewise.
2513 * filelock.c: Likewise.
2514 * fns.c: Likewise.
2515 * gtkutil.c: Likewise.
2516 * keyboard.c: Likewise.
2517 * lisp.h: Likewise.
2518 * lread.c: Likewise.
2519 * minibuf.c: Likewise.
2520 * msdos.c: Likewise.
2521 * print.c: Likewise.
2522 * process.c: Likewise.
2523 * region-cache.c: Likewise.
2524 * search.c: Likewise.
2525 * sysdep.c: Likewise.
2526 * termcap.c: Likewise.
2527 * terminal.c: Likewise.
2528 * tparam.c: Likewise.
2529 * w16select.c: Likewise.
2530 * w32.c: Likewise.
2531 * w32reg.c: Likewise.
2532 * w32select.c: Likewise.
2533 * w32uniscribe.c: Likewise.
2534 * widget.c: Likewise.
2535 * xdisp.c: Likewise.
2536 * xmenu.c: Likewise.
2537 * xrdb.c: Likewise.
2538 * xselect.c: Likewise.
2539
0497dc44
PE
25402012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2541
2542 * fileio.c (time_error_value): Check the right error number.
2543 Problem reported by Troels Nielsen in
2544 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2545
356e7178
PE
25462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2547
4e71fd89
PE
2548 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2549 This should be fixed in a better way; see Eli Zaretskii in
2550 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2551 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2552
f0941253
PE
2553 * fileio.c (time_error_value): Rename from special_mtime.
2554 The old name's problems were noted by Eli Zaretskii in
2555 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2556
065c9eb4
PE
2557 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2558 This variable's comment says Emacs needs at least one GDB-visible
2559 symbol of type enum pvec_type, to work around GDB problems.
2560 The symbol's value doesn't matter.
2561
356e7178
PE
2562 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2563 that causes compilation to fail on pre-C99 compilers.
2564
ed9265fc 25652012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2566
2567 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2568 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2569
3884d954
DA
25702012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2571
d209e2fb 2572 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2573 headers for buffer_defaults and buffer_local_symbols.
2574 Reported by Juanma Barranquero <lekktu@gmail.com>.
2575
ee28be33
SM
25762012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2577
2578 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2579 * lisp.h (enum pvec_type): Use fewer bits.
2580 (PSEUDOVECTOR_SIZE_BITS): New constant.
2581 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2582 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2583 change in pvec_type.
2584 (PSEUDOVECTOR_TYPEP): New macro.
2585 (TYPED_PSEUDOVECTORP): Use it.
2586 * fns.c (internal_equal): Adapt code to extract pvectype.
2587 * emacs.c (gdb_pvec_type): Update type.
2588 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2589 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2590 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2591 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2592 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2593 abusing vector->header.next.nbytes.
2594 (live_vector_p): Use PVEC_TYPE.
2595 (mark_object): Adapt code to extract pvectype. Use switch.
2596
c7f2cd7f
PE
25972012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2600 Tighten new eassert a bit.
2601
8ce70ed2
DA
26022012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2603
2604 Fix compilation with --enable-gcc-warnings and -O1
2605 optimization level.
2606 * doprnt.c (doprnt): Change type of tem to int, initialize
2607 to avoid compiler warning. Add eassert.
2608 * search.c (simple_search): Initialize match_byte to avoid
2609 compiler warning. Add eassert.
2610
dea7f1e5
PE
26112012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2612
24a212eb
PE
2613 Avoid weird behavior with large horizontal scrolls.
2614 Without this change, for example, large hscroll values would
2615 mess up Emacs's display on Fedora 15 x86, presumably due to
2616 overflows in int calculations in the display code.
2617 Also, if buffers had long lines, Emacs would freeze.
2618 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2619 (set_window_hscroll): New function, containing the old guts of
2620 Fset_window_hscroll. Return the clipped value.
2621 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2622 This avoids the need to check against PTRDIFF_MAX.
2623
dea7f1e5
PE
2624 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2625
76046526
DA
26262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2627
2628 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2629
39adff0d
PE
26302012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2631
63807d47
PE
2632 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2633 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2634 since GCC 4.4.6 issues a bogus warning for them.
2635
39adff0d
PE
2636 Fix bugs in file timestamp newness comparisons.
2637 * fileio.c (Ffile_newer_than_file_p):
2638 * lread.c (Fload): Use full timestamp resolution of files,
2639 not just the 1-second resolution, so that files that are only
2640 slightly newer still count as newer.
2641 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2642 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2643
dbeed9a6
PE
26442012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2645
2646 * fileio.c: Improve handling of file time marker. (Bug#11852)
2647 (special_mtime): New function.
2648 (Finsert_file_contents, Fverify_visited_file_modtime):
2649 Use it to set special mtime values consistently.
2650
636334d6
AS
26512012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2652
2653 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2654 marker for non-existing file. (Bug#11852)
2655
e2017fe2
GM
26562012-07-03 Glenn Morris <rgm@gnu.org>
2657
2658 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2659 and did not make it into globals.h).
2660
404dbd37
TT
26612012-07-03 Tom Tromey <tromey@redhat.com>
2662
2663 * window.c (Fset_window_margins, Fset_window_fringes)
2664 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2665 * textprop.c (Fprevious_property_change): No longer static.
2666 * syntax.c (Fsyntax_table_p): No longer static.
2667 * process.c (Fget_process, Fprocess_datagram_address): No longer
2668 static.
2669 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2670 * keyboard.c (Fcommand_execute): No longer static.
2671 Remove EXFUN.
2672 * insdel.c (Fcombine_after_change_execute): No longer static.
2673 * image.c (Finit_image_library): No longer static.
2674 * fileio.c (Fmake_symbolic_link): No longer static.
2675 * eval.c (Ffetch_bytecode): No longer static.
2676 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2677 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2678 No longer static.
404dbd37
TT
2679 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2680 static.
2681 * dired.c (Ffile_attributes): No longer static.
2682 * composite.c (Fcomposition_get_gstring): No longer static.
2683 * callproc.c (Fgetenv_internal): No longer static.
2684
2685 * ccl.h: Remove EXFUNs.
2686 * buffer.h: Remove EXFUNs.
2687 * dispextern.h: Remove EXFUNs.
2688 * intervals.h: Remove EXFUNs.
2689 * fontset.h: Remove EXFUN.
2690 * font.h: Remove EXFUNs.
2691 * dosfns.c (system_process_attributes): Remove EXFUN.
2692 * keymap.h: Remove EXFUNs.
2693 * lisp.h: Remove EXFUNs.
2694 * w32term.h: Remove EXFUNs.
2695 * window.h: Remove EXFUNs.
2696 * xsettings.h: Remove EXFUN.
2697 * xterm.h: Remove EXFUN.
2698
8e4fd1e1
GM
26992012-07-03 Glenn Morris <rgm@gnu.org>
2700
2701 * lisp.h (Frandom): Make it visible to C.
2702 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2703 buffer for invisible buffers. (Bug#1229)
2704
ca95b3eb
DA
27052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2706
2707 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2708 values which aren't power of 2.
14ae4239
BT
2709 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2710 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2711 accordingly.
2712
7555c33f
SM
27132012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2714
2715 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2716
2717 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2718
d12e8f5a
DA
27192012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2720
2721 * alloc.c (allocate_vector_block): Remove redundant
2722 calls to mallopt if DOUG_LEA_MALLOC is defined.
2723 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2724 avoid calls to mallopt if zero_vector is returned.
2725
296094c3
DA
27262012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2727
2728 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2729 is enabled, avoid dereferencing NULL current_sblock if
2730 running undumped.
2731
36429c89
DA
27322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2733
2734 Cleanup basic buffer management.
2735 * buffer.h (struct buffer): Change layout to use generic vector
2736 marking code. Fix some comments. Change type of 'clip_changed'
2737 to bitfield. Remove unused #ifndef old.
2738 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2739 (GET_OVERLAYS_AT): Fix indentation.
2740 (for_each_per_buffer_object_at): New macro.
2741 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2742 (Fbuffer_local_variables): Use it.
2743 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2744 * alloc.c (allocate_buffer): Adjust to match new layout of
2745 struct buffer. Fix comment.
2746 (mark_overlay): New function.
2747 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2748 Lisp area of struct buffer.
2749 (mark_object): Use it. Adjust marking of misc objects
2750 and related comments.
2751
3b3e4cac
PE
27522012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2753
2754 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2755 wrapper that is not needed because the wrapped code is a no-op (zero
2756 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2757 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2758
cf5c0175
DA
27592012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2760
2761 * alloc.c (mark_buffer): Simplify. Remove prototype.
2762 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2763 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2764 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2765 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2766
ca26824c
GM
27672012-06-30 Glenn Morris <rgm@gnu.org>
2768
2e4c5312
GM
2769 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2770
ca26824c
GM
2771 * epaths.in (PATH_SITELOADSEARCH): New.
2772 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2773 This is rather than relying on --enable-locallisppath elements
2774 having "site-lisp" in their names. (Bug#10208#25, 11658)
2775
0d23c240
EZ
27762012-06-30 Eli Zaretskii <eliz@gnu.org>
2777
c9240d7a
EZ
2778 * w32proc.c (sys_select): Accept and ignore one more argument.
2779
2780 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2781
0d23c240 2782 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2783 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2784
2785 * sysdep.c: Don't include dos.h and dosfns.h.
2786
2787 * process.c (sys_select):
2788 * msdos.c (sys_select): Accept one more argument and ignore it.
2789
2790 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2791 adapt data types and code to that.
2792
2793 * dosfns.c:
2794 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2795 which clashes with the gnulib function of the same name.
2796
af5a5a98
AS
27972012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2798
c5e4379c
AS
2799 * font.c (font_style_to_value, font_style_symbolic)
2800 (font_prop_validate_style): Add type checks for values in
2801 font_style_table.
2802
af5a5a98
AS
2803 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2804 argument.
2805 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2806 uses.
2807
8d38f461
EZ
28082012-06-29 Eli Zaretskii <eliz@gnu.org>
2809
2e5a6631
EZ
2810 * xdisp.c (try_window_id): Undo last change.
2811
8d38f461
EZ
2812 * w32.c (getwd): Adjust commentary about startup_dir.
2813 (init_environment): Always call sys_access, even in non-MSVC
2814 builds. Don't chdir to the directory of the Emacs executable.
2815 This undoes code from 1997 which was justified by the need to
2816 "avoid conflicts when removing and renaming directories". But its
2817 downside was that every relative file name was being interpreted
2818 relative to the directory of the Emacs executable, which can never
2819 be TRT. In particular, it broke sys_access when called with
2820 relative file names.
2821 (sys_access): Map GetLastError to errno.
2822
2af3565e
DA
28232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * window.h (struct window): Change type of 'fringes_outside_margins'
2826 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2827 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2828 Adjust comment.
2829 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2830 to ptrdiff_t.
2831
c8d3a25c 28322012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2833
c8d3a25c
GM
2834 * gnutls.c (emacs_gnutls_handshake):
2835 Add QUIT to make the loop interruptible.
57570cd3 2836
c8d3a25c 28372012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2838
c8d3a25c
GM
2839 * charset.c (init_charset): Make lack of etc/charsets fatal.
2840
3e984ee8
DA
28412012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2842
2843 * editfns.c (region_limit): Fix type mismatch.
2844
ef884f23
DA
28452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2846
2847 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2848 undefined. Convert from xassert to eassert.
2849 * nsmenu.m: Convert from xassert to eassert.
2850 * nsterm.m: Likewise.
2851
7d7e0027
SM
28522012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2853
2854 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2855
aa754e6a
PE
28562012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Avoid integer overflow on scroll-left and scroll-right.
2859 * window.c (HSCROLL_MAX): New macro.
2860 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2861 overflow when requested scroll falls outside ptrdiff_t range.
2862
80b00b08
DA
28632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2864
2865 * window.h (struct window): Change type of 'hscroll',
2866 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2867 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2868 Adjust users accordingly.
2869 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2870 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2871 from EMACS_INT to ptrdiff_t.
2872 (make_window): Omit redundant initialization.
2873
62b2bcf6
JB
28742012-06-28 Juanma Barranquero <lekktu@gmail.com>
2875
2876 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2877
45942c7d
DA
28782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2879
2880 * window.h (struct window): Change type of 'use_time' and
2881 'sequence_number' from Lisp_Object to int.
2882 * frame.c (make_frame): Adjust users accordingly.
2883 * print.c (print_object): Likewise.
2884 * window.c (select_window, Fwindow_use_time, make_parent_window)
2885 (make_window): Likewise.
2886
e509cfa6
DA
28872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2888
2889 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2890 enabled with --enable-checking=[all,glyphs] configure option.
2891 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2892 adjust comments accordingly.
2893 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2894 undefined, adjust comments accordingly.
2895 * image.c: Likewise.
2896 * scroll.c: Likewise.
2897 * w32fns.c: Likewise.
2898 * w32term.c: Likewise.
2899 * xdisp.c: Likewise.
2900 * xfaces.c: Likewise.
2901 * xfns.c: Likewise.
2902 * xterm.c: Likewise.
2903
a54e2c05
DA
29042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 Generalize run-time debugging checks.
2907 * dispextern.h (XASSERTS): Remove.
2908 * fontset.c (xassert): Remove.
2909 Convert from xassert to eassert.
2910 * alloc.c: Convert from xassert to eassert.
2911 * bidi.c: Likewise.
2912 * dispnew.c: Likewise.
2913 * fns.c: Likewise.
2914 * fringe.c: Likewise.
2915 * ftfont.c: Likewise.
2916 * gtkutil.c: Likewise.
2917 * image.c: Likewise.
2918 * keyboard.c: Likewise.
2919 * menu.c: Likewise.
2920 * process.c: Likewise.
2921 * scroll.c: Likewise.
2922 * sound.c: Likewise.
2923 * term.c: Likewise.
2924 * w32console.c: Likewise.
2925 * w32fns.c: Likewise.
2926 * w32term.c: Likewise.
2927 * window.c: Likewise.
2928 * xdisp.c: Likewise.
2929 * xfaces.c: Likewise.
2930 * xfns.c: Likewise.
2931 * xselect.c: Likewise.
2932 * xterm.c: Likewise.
2933
1ec4b7b2
SM
29342012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2935
2936 * fns.c (maybe_resize_hash_table): Output message when growing the
2937 purify-hashtable.
2938
2014308a
DA
29392012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2940
2941 * alloc.c (allocate_string_data): Remove dead code.
2942 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2943 avoid GCC warning about unused macro.
2944
246155eb
DA
29452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2946
2947 * alloc.c (allocate_string): Omit intervals initialization.
2948 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2949 as in make_pure_string and make_pure_c_string.
2950
43184b7b
DA
29512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2952
d209e2fb 2953 * alloc.c (allocate_string): Fix last change.
43184b7b 2954
3fe6dd74
DA
29552012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2956
d209e2fb 2957 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2958 to memset, add explicit initialization where appropriate.
2959
1ba6038a
GM
29602012-06-27 Glenn Morris <rgm@gnu.org>
2961
2962 * lisp.mk (lisp): Remove paths.elc.
2963
c89926a5
CY
29642012-06-27 Chong Yidong <cyd@gnu.org>
2965
2966 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2967
ed6b3510
JW
29682012-06-26 John Wiegley <johnw@newartisans.com>
2969
1ec4b7b2 2970 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2971 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2972
ed6b3510
JW
2973 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2974 when building with Clang.
2975
8edd4a2b
SM
29762012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2977
2978 * eval.c (Fapply): Allow calling it with a single argument.
2979
f6f62d1b
EZ
29802012-06-26 Eli Zaretskii <eliz@gnu.org>
2981
2982 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2983 _stricmp and _strnicmp.
2984 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2985
62efea5e
DA
29862012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2987
2988 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2989 allocated window.
2990 (allocate_process): Likewise for new process.
8edd4a2b 2991 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2992 (allocate_frame): Likewise.
2993 * frame.c (make_frame): Omit redundant initialization.
2994 * window.c (make_parent_window): Use memset.
2995 (make_window): Omit redundant initialization.
2996 * process.c (make_process): Omit redundant initialization.
2997 * terminal.c (create_terminal): Likewise.
2998
42997f4d
DA
29992012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3000
3001 * term.c (delete_tty): Remove redundant call to memset.
3002
1130ecfc
DA
30032012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3004
3005 * alloc.c: Remove build_string.
3006 * lisp.h: Define build_string as static inline. This provides
3007 a better opportunity to optimize away calls to strlen when the
3008 function is called with compile-time constant argument.
3009 * image.c (imagemagick_error): Convert to build_string.
3010 * w32proc.c (sys_spawnve): Likewise.
3011 * xterm.c (x_term_init): Likewise.
3012
cf38a720
PE
30132012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3014
99027bdd
PE
3015 Use sprintf return value instead of invoking strlen on result.
3016 In the old days this wasn't portable, since some sprintf
3017 implementations returned char *. But they died out years ago and
3018 Emacs already assumes sprintf returns int.
3019 Similarly for float_to_string.
3020 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3021 * ccl.c (ccl_driver):
3022 * character.c (string_escape_byte8):
3023 * data.c (Fnumber_to_string):
3024 * doprnt.c (doprnt):
3025 * print.c (print_object):
3026 * xdisp.c (message_dolog):
3027 * xfns.c (syms_of_xfns):
3028 Use sprintf or float_to_string result to avoid need to call strlen.
3029 * data.c (Fnumber_to_string):
3030 Use make_unibyte_string, since the string must be ASCII.
3031 * lisp.h, print.c (float_to_string): Now returns int length.
3032 * term.c (produce_glyphless_glyph):
3033 Use sprintf result rather than recomputing it.
3034
cf38a720
PE
3035 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3036 * Makefile.in (ALL_CFLAGS):
3037 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3038 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3039
3511c784
DA
30402012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3041
0a08eb21 3042 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3043 strcasecmp if available.
3044 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3045
fb7da12e
AS
30462012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3047
3048 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3049 Avoid comma operator.
3050 * menu.c (push_submenu_start, push_submenu_end)
3051 (push_left_right_boundary, push_menu_pane): Likewise.
3052 * msdos.c (dos_rawgetc): Likewise.
3053
afa2ffd8
DA
30542012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3055
3056 * xfns.c (xic_create_fontsetname): Remove redundant calls
3057 to memset.
3058
b3b4476b
PE
30592012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3060
4495ff38
PE
3061 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3062 sprintf already null-terminates its output.
3063
b3b4476b
PE
3064 * xfns.c (x_window): Remove redundant cast.
3065
b00876c9
DA
30662012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3067
3068 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3069 `const char *' to `char *' to avoid compiler warning.
3070
d188e26b
PE
30712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3072
885d1d74
PE
3073 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3074 instead of truncating it to 63 (admittedly a generous limit).
3075
d188e26b
PE
3076 * process.c: Fix spelling and caps in comments.
3077
e2f560b1
DN
30782012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3079
e86db54b 3080 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3081 * sysdep.c (setpgrp): Remove definition, not used in this file.
3082
7583a3a1
JB
30832012-06-24 Juanma Barranquero <lekktu@gmail.com>
3084
3085 * makefile.w32-in: Update dependencies.
3086
696056c2
EZ
30872012-06-24 Eli Zaretskii <eliz@gnu.org>
3088
3089 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3090 (SYSTIME_H): Add nt/inc/sys/time.h.
3091
3092 * systime.h [WINDOWSNT]: Include sys/time.h.
3093
3094 * s/ms-w32.h (struct timespec): Definition moved from
3095 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3096
845ca893
PE
30972012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3098
3099 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3100 * buffer.h (buffer_slot_type_mismatch):
3101 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3102 * eval.c (unwind_to_catch):
3103 * image.c (my_png_error, my_error_exit):
3104 * keyboard.c (quit_throw_to_read_char, user_error)
3105 (Fexit_recursive_edit, Fabort_recursive_edit):
3106 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3107 (wrong_type_argument, buffer_overflow, __executable_start)
3108 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3109 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3110 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3111 (fatal):
3112 (child_setup) [!DOS_NT]:
3113 * lread.c (end_of_file_error, invalid_syntax):
3114 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3115 * puresize.h (pure_write_error):
3116 * search.c (matcher_overflow):
3117 * sound.c (sound_perror, alsa_sound_perror):
3118 * sysdep.c, syssignal.h (croak):
3119 * term.c (maybe_fatal, vfatal):
3120 * textprop.c (text_read_only):
3121 * undo.c (user_error):
3122 * unexmacosx.c (unexec_error):
3123 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3124 Use _Noreturn rather than NO_RETURN.
3125 No need for separate decl merely because of _Noreturn.
3126 * sound.c (sound_warning, parse_sound):
3127 Remove unnecessary forward decls.
3128
f1dd8073
PE
31292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3130
3131 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3132 * lisp.h (WAIT_READING_MAX): New macro.
3133 * dispnew.c (Fsleep_for, sit_for):
3134 * keyboard.c (kbd_buffer_get_event):
3135 * process.c (Faccept_process_output):
3136 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3137 This improves on the previous patch, which introduced a bug
3138 when time_t is unsigned and as wide as intmax_t.
3139 See <http://bugs.gnu.org/9000#51>.
3140
b82c1755
EZ
31412012-06-23 Eli Zaretskii <eliz@gnu.org>
3142
3143 * dispnew.c (sit_for, Fsleep_for):
3144 * keyboard.c (kbd_buffer_get_event):
3145 * process.c (Faccept_process_output): Avoid compiler warnings when
3146 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3147
ca300656
JB
31482012-06-23 Juanma Barranquero <lekktu@gmail.com>
3149
049ec95b
JB
3150 * makefile.w32-in: Update dependencies.
3151
ca300656
JB
3152 * w32.c (ltime): Add return type and declare static.
3153 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3154
db7b8d06
PE
31552012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3158 Privately reported by Herbert J. Skuhra.
3159 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3160 All uses changed.
3161 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3162 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3163
0bd8297f
EZ
31642012-06-23 Eli Zaretskii <eliz@gnu.org>
3165
96512555
EZ
3166 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3167 last argument of make_unibyte_string.
3168
0bd8297f
EZ
3169 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3170 language ID in the event parameters.
3171
3172 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3173 event.code, not the obscure "character set ID".
3174
63def6b6
CY
31752012-06-23 Chong Yidong <cyd@gnu.org>
3176
3177 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3178
e8a02204
EZ
31792012-06-23 Eli Zaretskii <eliz@gnu.org>
3180
388cdec0
EZ
3181 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3182 * w32.c (fdutimens): New function.
3183
3184 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3185
3186 * s/ms-w32.h (pselect): Redirect to sys_select.
3187
3188 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3189
e8a02204
EZ
3190 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3191 in the logic of incrementing and decrementing the value of
3192 use_relocatable_buffers.
3193
d054f3fb
PE
31942012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3197 Privately reported by Herbert J. Skuhra.
3198 [__FreeBSD__]: Remove "*/" typo after "#include".
3199 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3200 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3201 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3202 Don't assume EMACS_TIME and struct timeval are the same type.
3203
d35af63c
PE
32042012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 Support higher-resolution time stamps (Bug#9000).
3207 The time stamps are only nanosecond-resolution at the C level,
3208 since that's the best that any real-world system supports now.
3209 But they are picosecond-resolution at the Lisp level, as that's
3210 easy, and leaves room for future OS improvements.
3211
3212 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3213 (LIBES): Use it.
3214
3215 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3216 Don't get current time unless it's needed.
3217
3218 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3219 now provides it if it's absent.
3220 (start_atimer): Port to higher-res time stamps.
3221 Check for time stamp overflow. Don't get current time more
3222 often than is needed.
3223
3224 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3225 Include systime.h, not time.h.
3226 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3227
3228 * dired.c: Include stat-time.h.
3229 (Ffile-attributes): File times now have higher resolution.
3230
3231 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3232 (struct image): Timestamp now has higher resolution.
3233
3234 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3235 has at least microseconds now. All uses removed.
3236 (update_frame, update_single_window, update_window, update_frame_1)
3237 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3238
3239 * editfns.c (time_overflow): Now extern.
3240 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3241 (float-time, Fformat_time_string, Fcurrent_time_string)
3242 (Fcurrent_time_zone): Accept and generate higher-resolution
3243 time stamps.
3244 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3245 (decode_time_components, lisp_seconds_argument): New functions.
3246 (make_time): Now static.
3247 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3248 Report an error if the time is invalid, rather than having the caller
3249 do that.
3250
3251 * fileio.c: Include <stat-time.h>
3252 (Fcopy_file): Copy higher-resolution time stamps.
3253 Prefer to set the time stamp via a file descriptor if that works.
3254 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3255 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3256 (Fvisited_file_modtime, Fset_visited_file_modtime):
3257 Support higher-resolution time stamps.
3258
3259 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3260
3261 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3262
3263 * image.c (prepare_image_for_display, clear_image_cache)
3264 (lookup_image): Port to higer-resolution time stamps.
3265
3266 * keyboard.c (start_polling, bind_polling_period):
3267 Check for time stamp overflow.
3268 (read_char, kbd_buffer_get_event, timer_start_idle)
3269 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3270 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3271 Port to higher-resolution time stamps. Do not assume time_t is signed.
3272 (decode_timer): New function. Timers are now vectors of length 9,
3273 not 8, to accommodate the picosecond component.
3274 (timer_check_2): Use it.
3275
3276 * nsterm.m (select_timeout, timeval_subtract): Remove.
3277 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3278 as they're a bit more accurate and handle overflow better.
3279 (ns_select): Change prototype to be compatible with pselect.
3280 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3281 * nsterm.h (ns_select): Adjust prototype.
3282
3283 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3284 us-resolution time stamps.
3285 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3286
3287 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3288
3289 * lisp.h (time_overflow): New decl.
3290 (wait_reading_process_output): First arg is now intmax_t, not int,
3291 to accommodate larger waits.
3292
3293 * process.h (struct Lisp_Process.read_output_delay):
3294 Now counts nanoseconds, not microseconds.
3295 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3296 EMACS_HAS_USECS.
3297 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3298 (wait_reading_process_output):
3299 Port to ns-resolution time stamps.
3300 (Faccept_process_output, wait_reading_process_output):
3301 Check for time stamp overflow. Do not assume time_t is signed.
3302 (select_wrapper): Remove; we now use pselect.
3303 (Fprocess_attributes): Now generates ns-resolution time stamps.
3304
3305 * sysdep.c: Include utimens.h. Don't include utime.h
3306 or worry about struct utimbuf; gnulib does that for us now.
3307 (gettimeofday): Remove; gnulib provides a substitute.
3308 (make_timeval): New function.
3309 (set_file_times): Now sets ns-resolution time stamps.
3310 New arg FD; all uses changed.
3311 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3312 (system_process_attributes):
3313 Now returns ns-resolution time stamp. All uses changed.
3314 Check for time stamp overflow.
3315
3316 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3317 provides a substitute now.
3318
3319 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3320 since it guarantees struct timespec.
3321 (EMACS_TIME): Now struct timespec, so that we can support
3322 ns-resolution time stamps.
3323 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3324 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3325 (EMACS_USECS): Remove.
3326 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3327 so multiply the arg by 1000 before storing it.
3328 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3329 New macros.
3330 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3331 Port to ns-resolution time stamps.
3332 (EMACS_TIME_NEG_P): Remove; replaced by....
3333 (EMACS_TIME_SIGN): New macro.
3334 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3335 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3336 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3337 (make_timeval, make_lisp_time, decode_time_components): New decls.
3338 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3339 that it mishandled time_t overflow. You can't compare by subtracting!
3340 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3341 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3342
3343 * term.c: Include <sys/time.h>.
3344 (timeval_to_Time): New function, for proper overflow wraparound.
3345 (term_mouse_position, term_mouse_click): Use it.
3346
3347 * undo.c (record_first_change): Support higher-resolution time stamps
3348 in the undo buffer.
3349 (Fprimitive_undo): Use them when restoring time stamps.
3350
3351 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3352 (w32_get_internal_run_time):
3353 Port to higher-resolution Emacs time stamps.
3354 (ltime): Now accepts single 64-bit integer, as that's more convenient
3355 for callers.
3356
3357 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3358
3359 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3360 for compatibility with pselect. Support ns-resolution time stamps.
3361
3362 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3363
3364 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3365 Check for time stamp overflow, and support ns-resolution time stamps.
3366
3367 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3368 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3369 (timeval_subtract): Remove; no longer needed.
3370 (XTflash, XTring_bell, x_wait_for_event):
3371 Port to ns-resolution time stamps. Don't assume time_t is signed.
3372
b6a92dfe
CY
33732012-06-22 Chong Yidong <cyd@gnu.org>
3374
3375 * xdisp.c (x_consider_frame_title): Revert last change.
3376
d251c37c
EZ
33772012-06-22 Eli Zaretskii <eliz@gnu.org>
3378
3379 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3380 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3381 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3382 staticidx goes up to 1597 out of 1600 = 0x640.)
3383
f10deafb
PE
33842012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3385
3386 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3387 Otherwise, the umask might be mistakenly 0 while handling input signals.
3388
ec6de1e2
SM
33892012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3390
3391 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3392
28be1ada
DA
33932012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3394
3395 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3396 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3397 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3398 access to `contents' member of Lisp_Vector objects with AREF and ASET
3399 where appropriate.
3400
c6bf3022
CY
34012012-06-19 Chong Yidong <cyd@gnu.org>
3402
3403 * frame.c (delete_frame): When selecting a frame on a different
3404 text terminal, do not alter the terminal's top-frame.
3405
3406 * xdisp.c (format_mode_line_unwind_data): Record the target
3407 frame's selected window and its terminal's top-frame.
3408 (unwind_format_mode_line): Restore them.
3409 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3410 Callers changed.
3411 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3412 since tty frames can be explicitly named.
3413 (prepare_menu_bars): Likewise.
3414
3415 * term.c (Ftty_top_frame): New function.
3416
defd4196
PE
34172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 Port byte-code-meter to modern targets.
3420 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3421 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3422 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3423 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3424 (METER_1, METER_2): Simplify.
3425
1053a871
SM
34262012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3427
3428 * data.c (Fdefalias): Return `symbol' (bug#11686).
3429
b7e8d081
MR
34302012-06-18 Martin Rudalics <rudalics@gmx.at>
3431
3432 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3433 gets killed during executing of this function (Bug#11665).
3434 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3435 (Vkill_buffer_query_functions): In doc-string say that functions
3436 run by this hook should not change the current buffer.
3437
7ea2b339
PE
34382012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3439
3440 Fix recently-introduced process.c problems found by static checking.
3441 * process.c (write_queue_push, write_queue_pop, send_process):
3442 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3443 (write_queue_pop): Fix pointer signedness problem.
3444 (send_process): Remove unused local.
3445
96a313a1
CY
34462012-06-17 Chong Yidong <cyd@gnu.org>
3447
3448 * xdisp.c (redisplay_internal): No need to redisplay terminal
3449 frames that are not on top.
3450
20ca2e94
TN
34512012-06-17 Troels Nielsen <bn.troels@gmail.com>
3452
3453 * process.c (make_process): Initialize write_queue.
3454 (write_queue_push, write_queue_pop): New functions.
3455 (send_process): Use them to maintain correct ordering of process
3456 writes (Bug#10815).
3457
9a900ca9
PE
34582012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3459
310fbfa8
PE
3460 * lisp.h (eassert): Assume C89 or later.
3461 This removes the need for CHECK.
3462 (CHECK): Remove. Its comments about always evaluating its
3463 argument were confusing, as 'eassert' typically does not evaluate
3464 its argument.
3465
27bb1ca4
PE
3466 * coding.c (produce_chars): Use ptrdiff_t, not int.
3467
9a900ca9
PE
3468 * xterm.c (x_draw_underwave): Check for integer overflow.
3469 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3470
41b7f8bc 34712012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3472
3473 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3474 referenced (Bug#11583).
3475
9b0e3eba
AA
34762012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3477
3478 Implement wave-style variant of underlining.
3479 * dispextern.h (face_underline_type): New enum.
3480 (face): Add field for underline type.
3481 * nsterm.m (ns_draw_underwave): New function.
3482 (ns_draw_text_decoration): Use it.
3483 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3484 New functions.
3485 (x_draw_glyph_string): Use them.
3486 * xfaces.c (Qline, Qwave): New Lisp objects.
3487 (check_lface_attrs, merge_face_ref)
1053a871
SM
3488 (Finternal_set_lisp_face_attribute, realize_x_face):
3489 Handle wave-style underline face attributes.
9b0e3eba
AA
3490 * xterm.c (x_draw_underwave): New function.
3491 (x_draw_glyph_string): Use it.
3492
0fb52f11
JB
34932012-06-16 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3496 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3497 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3498 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3499 ($(BLD)/w32select.$(O)): Update dependencies.
3500
e5560ff7
AS
35012012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3502
3503 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3504 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3505 * character.c (_fetch_multibyte_char_p): Remove.
3506 * alloc.c: Include "character.h" before "buffer.h".
3507 * bidi.c: Likewise.
3508 * buffer.c: Likewise.
3509 * bytecode.c: Likewise.
3510 * callint.c: Likewise.
3511 * callproc.c: Likewise.
3512 * casefiddle.c: Likewise.
3513 * casetab.c: Likewise.
3514 * category.c: Likewise.
3515 * cmds.c: Likewise.
3516 * coding.c: Likewise.
3517 * composite.c: Likewise.
3518 * dired.c: Likewise.
3519 * dispnew.c: Likewise.
3520 * doc.c: Likewise.
3521 * dosfns.c: Likewise.
3522 * editfns.c: Likewise.
3523 * emacs.c: Likewise.
3524 * fileio.c: Likewise.
3525 * filelock.c: Likewise.
3526 * font.c: Likewise.
3527 * fontset.c: Likewise.
3528 * fringe.c: Likewise.
3529 * indent.c: Likewise.
3530 * insdel.c: Likewise.
3531 * intervals.c: Likewise.
3532 * keyboard.c: Likewise.
3533 * keymap.c: Likewise.
3534 * lread.c: Likewise.
3535 * macros.c: Likewise.
3536 * marker.c: Likewise.
3537 * minibuf.c: Likewise.
3538 * nsfns.m: Likewise.
3539 * nsmenu.m: Likewise.
3540 * print.c: Likewise.
3541 * process.c: Likewise.
3542 * regex.c: Likewise.
3543 * region-cache.c: Likewise.
3544 * search.c: Likewise.
3545 * syntax.c: Likewise.
3546 * term.c: Likewise.
3547 * textprop.c: Likewise.
3548 * undo.c: Likewise.
3549 * unexsol.c: Likewise.
3550 * w16select.c: Likewise.
3551 * w32fns.c: Likewise.
3552 * w32menu.c: Likewise.
3553 * window.c: Likewise.
3554 * xdisp.c: Likewise.
3555 * xfns.c: Likewise.
3556 * xmenu.c: Likewise.
3557 * xml.c: Likewise.
3558 * xselect.c: Likewise.
3559
2f07e6af
EZ
35602012-06-16 Eli Zaretskii <eliz@gnu.org>
3561
1053a871
SM
3562 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3563 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3564 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3565 row.
3566 (handle_face_prop): Use chunk-relative overlay string index when
3567 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3568 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3569 the rightmost. (Bug#11720)
2f07e6af 3570
29b83cec
AS
35712012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3572
3573 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3574 (CATEGORY_MEMBER): Enforce 1/0 value.
3575 * category.c (_temp_category_set): Remove.
3576
4c5501e9
EZ
35772012-06-16 Eli Zaretskii <eliz@gnu.org>
3578
3579 * window.c (Fdelete_other_windows_internal)
3580 (Fdelete_window_internal): Don't access frame's mouse highlight
3581 info of the initial frame. (Bug#11677)
3582
2b570124
PE
35832012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3584
e93864f9
PE
3585 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3586 Assume USE_2_TAGS_FOR_INTS.
3587 (xreload): Adjust $tagmask width to match recent lisp.h change.
3588
2b570124
PE
3589 Simplify lisp.h in minor ways that should not affect code.
3590 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3591 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3592 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3593 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3594 (INTTYPEBITS): New macro, for clarity.
3595 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3596 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3597 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3598 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3599 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3600
81755f69
JB
36012012-06-13 Juanma Barranquero <lekktu@gmail.com>
3602
3603 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3604
16192a57
GM
36052012-06-13 Glenn Morris <rgm@gnu.org>
3606
3607 * s/bsd-common.h (BSD4_3):
3608 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3609
646b5f55
AS
36102012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3611
3612 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3613 instead of union.
3614 (XLI, XIL): Define.
1053a871
SM
3615 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3616 Use them.
3617 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3618 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3619 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3620 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3621 * frame.c (delete_frame): Remove outdated comment.
3622 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3623 USE_LISP_UNION_TYPE.
3624 (Fw32_unregister_hot_key): Likewise.
3625 (Fw32_toggle_lock_key): Likewise.
3626 * w32menu.c (add_menu_item): Likewise.
3627 (w32_menu_display_help): Use XIL instead of checking
3628 USE_LISP_UNION_TYPE.
3629 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3630 (init_heap): Likewise.
3631 * w32term.c (w32_read_socket): Update comment.
3632
1d3823c9
GM
36332012-06-13 Glenn Morris <rgm@gnu.org>
3634
c62ff706
GM
3635 * s/usg5-4-common.h, src/s/unixware.h:
3636 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3637
1d3823c9
GM
3638 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3639
bfe3e0a2
PE
36402012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3641
3642 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3643 * alloc.c (make_number) [!defined make_number]:
3644 Remove, as lisp.h always defines this now.
3645 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3646 (roundup_size): Verify that it is a power of 2.
3647 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3648 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3649 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3650 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3651 USE_LSB_TAG now is always defined to be either 0 or 1.
3652 All uses changed.
3653 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3654 code works fine either way, and efficiency is not a concern here,
3655 as the union type is for debugging, not for production.
3656 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3657 Use an inline function on all platforms when using the union type,
3658 since this is simpler and 'static inline' can be used portably
3659 within Emacs now.
3660 (LISP_INITIALLY_ZERO): New macro.
3661 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3662 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3663
45fa9c0f
GM
36642012-06-12 Glenn Morris <rgm@gnu.org>
3665
b4492cba
GM
3666 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3667
3668 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3669
45fa9c0f
GM
3670 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3671 Move BROKEN_SIGIO to configure.
3672
3673 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3674 Move NO_TERMIO to configure.
3675
0e25d334
CY
36762012-06-12 Chong Yidong <cyd@gnu.org>
3677
3678 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3679 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3680 MagickExportImagePixels is undefined.
3681
43682bb6
PE
36822012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3683
3684 * image.c (imagemagick_load_image): Remove unused label.
3685
a9be7d2b
GM
36862012-06-11 Glenn Morris <rgm@gnu.org>
3687
3688 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3689 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3690 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3691 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3692
3017f87f
SM
36932012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3694
3695 * alloc.c (make_byte_code): New function.
3696 (Fmake_byte_code): Use it. Don't purify here.
3697 * lread.c (read1): Use it as well to avoid extra allocation.
3698
1b9b4cf4
CY
36992012-06-11 Chong Yidong <cyd@gnu.org>
3700
3701 * image.c (imagemagick_load_image): Implement transparency.
3702
95988fcf
AS
37032012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3704
3705 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3706 account for preceding backslashes. (Bug#11663)
3707
cd4eb164
CY
37082012-06-09 Chong Yidong <cyd@gnu.org>
3709
3710 * term.c: Support italics in capable terminals (Bug#9652).
3711 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3712 (turn_on_face): Output using TS_enter_italic_mode if available.
3713 Don't handle unused blinking and alt-charset cases.
3714 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3715 and tty_alt_charset_p cases.
3716 (tty_capable_p, init_tty): Support italics.
3717
3718 * termchar.h (struct tty_display_info): Add field for italics.
3719 Remove unused blink field.
3720
3721 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3722 Handle slant.
3723
3724 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3725 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3726 tty_alt_charset_p. Add tty_italic_p.
3727
ff88beb8
MA
37282012-06-09 Michael Albinus <michael.albinus@gmx.de>
3729
3730 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3731 dbus_type_is_basic if available.
3732 (xd_extract_signed, xd_extract_unsigned): Rename from
3733 extract_signed and extract_unsigned, respectively. Adapt callers.
3734
44286096
CY
37352012-06-09 Chong Yidong <cyd@gnu.org>
3736
1682701f
CY
3737 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3738
44286096
CY
3739 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3740 case (Bug#9752).
3741
d86feb17
PE
37422012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3743
3744 * xdisp.c (vmessage): Treat frame message as multibyte.
3745 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3746 would generate the diagnostic "Making \302\247 buffer-local while
3747 let-bound!".
3748
d5c20fe8
EZ
37492012-06-08 Eli Zaretskii <eliz@gnu.org>
3750
3751 * dispnew.c (showing_window_margins_p): Undo last change, which
3752 was done due to an inadvertent commit.
3753 (adjust_frame_glyphs_for_frame_redisplay): Do call
3754 showing_window_margins_p.
3755
513749ee
SM
37562012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3757
3758 * eval.c (Fmake_var_non_special): New primitive.
3759 (syms_of_eval): Defsubr it.
3760 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3761
d4a8f5c1
JB
37622012-06-08 Juanma Barranquero <lekktu@gmail.com>
3763
3764 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3765 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3766
8bbbc977
EZ
37672012-06-08 Eli Zaretskii <eliz@gnu.org>
3768
3769 * alloc.c (allocate_vectorlike): Fix last change.
3770
f3372c87
DA
37712012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3772
3773 Block-based vector allocation of small vectors.
3774 * lisp.h (struct vectorlike_header): New field `nbytes',
3775 adjust comment accordingly.
3776 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3777 to denote vector blocks. Adjust users (live_vector_p,
3778 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3779 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3780 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3781 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3782 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3783 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3784 (roundup_size): New constant.
3785 (struct vector_block): New data type.
3786 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3787 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3788 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3789 (sweep_vectors): New functions.
3790 (allocate_vectorlike): Return `zero_vector' as the only vector of
3791 0 items. Allocate new vector from block if vector size is less than
3792 or equal to VBLOCK_BYTES_MAX.
3793 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3794 (init_alloc_once): Add call to init_vectors.
3795
4f18a4ed
SM
37962012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3797
3798 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3799
86f158bc
PE
38002012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 * doprnt.c (doprnt): Truncate multibyte char correctly.
3803 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3804 would mishandle a string argument "Xc" if X was a multibyte
3805 character of length 2: it would truncate after X's first byte
3806 rather than including all of X.
3807
c5cfcbe0
CY
38082012-06-06 Chong Yidong <cyd@gnu.org>
3809
3810 * buffer.c (word_wrap): Doc fix.
3811
c05cf390
PE
38122012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3815
0c3461de
GM
38162012-06-03 Glenn Morris <rgm@gnu.org>
3817
3818 * xdisp.c (tool-bar-style): Doc fix.
3819
c71232db
UM
38202012-06-03 Ulrich Müller <ulm@gentoo.org>
3821
3822 * Makefile.in (PAXCTL): Define.
3823 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3824 binary via PaX flags if the paxctl utility is available.
3825 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3826 Restore PaX flags to their default. (Bug#11398)
3827
383f7350
CY
38282012-06-03 Chong Yidong <cyd@gnu.org>
3829
3830 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3831 buffer (Bug#11226).
3832
5f2c76c6
CY
38332012-06-03 Chong Yidong <cyd@gnu.org>
3834
3835 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3836 (note_mode_line_or_margin_highlight): If there is no help echo,
3837 use mode-line-default-help-echo. Handle the case where the mouse
3838 position is past the end of the mode line string.
3839
3840 * buffer.c (buffer_local_value_1): New function, split from
3841 Fbuffer_local_value; can return Qunbound.
3842 (Fbuffer_local_value): Use it.
3843 (Vmode_line_format): Docstring tweaks.
3844
773d47f6
PE
38452012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 * sysdep.c (system_process_attributes): Improve comment.
3848
f2d6a3df
SM
38492012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3850
3851 * keyboard.c: Export real-this-command to Elisp.
3852 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3853 and DEFVAR it. Update all users.
3854
63810350
PE
38552012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3856
7bd5c1f4
PE
3857 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3858
63810350
PE
3859 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3860 Convert pctcpu and pctmem to Lisp float properly.
3861 Let the compiler fold better, as 100.0/0x8000 is exact.
3862
a2821611
AS
38632012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3864
3865 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3866 cons_block.
3867
5fceba1d
PE
38682012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3871
c98ff5dd
DA
38722012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3873
3874 For a 'struct window', replace some Lisp_Object fields to
3875 bitfields where appropriate, remove unused fields.
3876 * window.h (struct window): Remove unused 'last_mark_x' and
3877 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3878 change it's type from Lisp_Object to bitfield.
3879 Change type of 'force_start', 'optional_new_start',
3880 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3881 fields from Lisp_Object to bitfield. Adjust users accordingly.
3882
ca34e0be
PE
38832012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 Pacify gcc -Wdouble-precision when using Xaw.
3886 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3887 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3888 Use 'float' consistently, rather than 'float' in most places
3889 and 'double' in a couple of places.
3890
efc00ab1 38912012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3892
3893 * xdisp.c (handle_stop): Detect whether we have overlay strings
3894 loaded by testing it->current.overlay_string_index to be
3895 non-negative, instead of checking whether n_overlay_strings is
3896 positive. (Bug#11587)
3897
efc00ab1 38982012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3899
3900 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3901
3902 * doc.c (Fsubstitute_command_keys): Doc fix.
3903
efc00ab1 39042012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3905
3906 * search.c (search_buffer): Remove calls to
3907 r_alloc_inhibit_buffer_relocation, as it is now called by
3908 maybe_unify_char, which was the cause of relocation of buffer text
3909 in bug#11519.
3910
efc00ab1 39112012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3912
3913 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3914 for the duration of call to load_charset, to avoid problems with
3915 callers of maybe_unify_char that access buffer text through C
3916 pointers.
3917
3918 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3919 decrement the inhibition flag, instead of just setting or
3920 resetting it.
3921
ba93a187
PE
39222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 Remove obsolete '#define static' cruft.
3925 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3926 This #undef was "temporary" in 2000; it is no longer needed
3927 now that '#define static' has gone away.
3928 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3929 (gray_bitmap_bits): Remove; no longer needed.
3930 All uses replaced with definiens.
3931 * xterm.c: Include "bitmaps/gray.xbm".
3932
9e4bf381
PE
39332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 Clean up __executable_start, monstartup when --enable-profiling.
3936 The following changes affect the code only when profiling.
3937 * dispnew.c (__executable_start): Rename from safe_bcopy.
3938 Define only on platforms that need it.
3939 * emacs.c: Include <sys/gmon.h> when profiling.
3940 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3941 (__executable_start): Remove decl, since lisp.h does it now.
3942 (safe_bcopy): Remove decl; no longer has that name.
3943 (main): Coalesce #if into single bit of code, for simplicity.
3944 Cast pointers to uintptr_t, since standard libraries want integers
3945 and not pointers.
3946 * lisp.h (__executable_start): New decl.
3947
32d72c2f
GM
39482012-05-31 Glenn Morris <rgm@gnu.org>
3949
3950 * image.c (Fimagemagick_types): Doc fix.
3951
baac5bc7
JM
39522012-05-30 Jim Meyering <meyering@redhat.com>
3953
3954 * callproc.c (Fcall_process_region): Include directory component
3955 in mkstemp error message (Bug#11586).
3956
72cb32cf
PE
39572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * alloc.c, lisp.h (make_pure_vector): Now static.
3960
61b108cc
SM
39612012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3962
3963 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3964 Move to byte-run.el.
3965 (Fautoload): Do the hash-doc more carefully.
3966 * data.c (Fdefalias): Purify definition, except for keymaps.
3967 (Qdefun): Move from eval.c.
3968 * lisp.h (Qdefun): Remove.
3969 * lread.c (read1): Tiny simplification.
3970
471fe23d
TN
39712012-05-29 Troels Nielsen <bn.troels@gmail.com>
3972
934f3f58 3973 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3974 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3975 Bug#9642, but explicitly check that the buffer the overlay would
3976 be moved to is live and rearrange lines to make sure that errors
3977 will not put the overlay in an inconsistent state.
3978 (Fdelete_overlay): Cosmetics.
3979
85d0efd1
EZ
39802012-05-28 Eli Zaretskii <eliz@gnu.org>
3981
3982 * w32term.c (my_bring_window_to_top): New function.
3983 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3984 could be different from the original one.
3985 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3986 (Bug#11513)
3987
3988 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3989 by calling BringWindowToTop.
3990
3991 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3992 (WM_EMACS_END): Increase by one.
3993
da92a98c
PE
39942012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3997 This avoids undefined behavior that might cause the eassert
3998 to not catch an out-of-range value.
3999
74d1f848
JB
40002012-05-28 Juanma Barranquero <lekktu@gmail.com>
4001
4002 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4003 Update dependencies.
4004
9e1a06fc
EZ
40052012-05-27 Eli Zaretskii <eliz@gnu.org>
4006
4007 * bidi.c (bidi_mirror_char): Fix last change.
4008
f3dd7312
AS
40092012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4010
4011 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4012 when referring to sectname field in printf format.
4013
81899c91
PE
40142012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4015
57b81a9f
PE
4016 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4017 Only r_alloc_inhibit_buffer_relocation needed to be added;
4018 the others were already declared.
4019
81899c91
PE
4020 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4021 before checking whether it's out of range. Put the check inside
4022 eassert. See
4023 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4024
33017faf 40252012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4026
4027 * callproc.c (Fcall_process): Restore a line that was accidentally
4028 commented out in the 2011-02-13 change (bug#11547).
4029
33017faf 40302012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4031
4032 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4033 defined on ralloc.c.
4034
4035 * buffer.c [REL_ALLOC]: Remove prototypes of
4036 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4037 they are now on lisp.h.
4038
4039 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4040
4041 * search.c (search_buffer): Use it to inhibit relocation of buffer
4042 text while re_search_2 is doing its job, because re_search_2 is
4043 passed C pointers to buffer text. (Bug#11519)
4044
23415acf
EZ
4045 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4046 Update value to 24.
4047
44e27368
EZ
4048 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4049 state after an additional call to move_it_in_display_line_to, keep
4050 the values of it->max_ascent and it->max_descent found for the
4051 entire line.
4052 (pos_visible_p): Revert the comparison against bottom_y to what it
4053 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4054 (Bug#11464)
4055
c1892f11
PE
40562012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 Fix coding-related core dumps with gcc -ftrapv.
4059 The code was computing A - B, where A and B are pointers, and B is
4060 random garbage. This can lead to core dumps on platforms that
4061 have special pointer registers, and it also leads to core dumps on
4062 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4063 A - B only when B is initialized properly.
4064 * coding.c (coding_set_source, coding_set_destination): Return void.
4065 (coding_change_source, coding_change_destinations): New functions,
4066 with the old behaviors of coding_set_source and coding_set_destination.
4067 All callers that need an offset changed to use these new functions.
4068
eb7afdad
GM
40692012-05-26 Glenn Morris <rgm@gnu.org>
4070
4071 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4072
f12fdf02
EZ
40732012-05-26 Eli Zaretskii <eliz@gnu.org>
4074
53a63be6 4075 Extend mouse support on W32 text-mode console.
61b108cc
SM
4076 * xdisp.c (draw_row_with_mouse_face):
4077 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4078
eb3f6f01 4079 * w32console.c: Include window.h.
61b108cc
SM
4080 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4081 New functions.
eb3f6f01
EZ
4082 (initialize_w32_display): Initialize mouse-highlight data.
4083
53a63be6
EZ
4084 * w32inevt.c: Include termchar.h and window.h.
4085 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4086 moves, call note_mouse_highlight. If help_echo changed, call
4087 gen_help_event to produce help-echo message in the echo area.
4088 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4089 highlight info.
4090
4cfd81f6
PE
40912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4092
4093 * lread.c (read1): Simplify slightly to avoid an overflow warning
4094 with GCC 4.7.0 on x86-64.
4095
4446092a
EZ
40962012-05-26 Eli Zaretskii <eliz@gnu.org>
4097
4098 * bidi.c (bidi_mirror_char): Revert last change: an int is
4099 definitely wide enough here.
4100
42b2a986 41012012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4102
42b2a986 4103 Fix integer width and related bugs (Bug#9874).
eb106a49 4104 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4105 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4106 (string_bytes, check_sblock, allocate_string_data):
4107 (compact_small_strings, Fmake_bool_vector, make_string)
4108 (make_unibyte_string, make_multibyte_string)
4109 (make_string_from_bytes, make_specified_string)
4110 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4111 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4112 (mark_vectorlike):
4113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4114 (allocate_pseudovector):
4115 Use int, not EMACS_INT, where int is wide enough.
4116 (inhibit_garbage_collection, Fgarbage_collect):
4117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4118 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4119 int might not be wide enough.
4120 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4121 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4122 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4123 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4124 (bidi_level_of_next_char, bidi_move_to_visually_next):
4125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4126 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4127 (Fkill_buffer, Fset_buffer_major_mode)
4128 (advance_to_char_boundary, Fbuffer_swap_text)
4129 (Fset_buffer_multibyte, overlays_at, overlays_in)
4130 (overlay_touches_p, struct sortvec, record_overlay_string)
4131 (overlay_strings, recenter_overlay_lists)
4132 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4133 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4134 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4135 (Foverlay_recenter, last_overlay_modification_hooks_used)
4136 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4138 (validate_region): Omit unnecessary test for b <= e,
4139 since that's guaranteed by the previous test.
d311d28c
PE
4140 (adjust_overlays_for_delete): Avoid pos + length overflow.
4141 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4142 (report_overlay_modification):
4143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4144 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4145 Omit pointer cast, which isn't needed anyway, and doesn't work
4146 after the EMACS_INT -> ptrdiff_t change.
02481186 4147 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4148 * buffer.h: Adjust decls to match defn changes elsewhere.
4149 (struct buffer_text, struct buffer):
4150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4151 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4152 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4153 not int, to avoid needless 32-bit limit on 64-bit hosts.
4154 (exec_byte_code): Use tighter memory-full test, one that checks
4155 for alloca overflow. Don't compute the address of the object just
4156 before an array, as that's not portable. Use EMACS_INT, not
4157 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4158 * callint.c (Fcall_interactively):
4159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4160 * callproc.c (call_process_kill, Fcall_process):
4161 Don't assume pid_t fits into an Emacs fixnum.
4162 (call_process_cleanup, Fcall_process, child_setup):
4163 Don't assume pid_t fits into int.
4164 (call_process_cleanup, Fcall_process, delete_temp_file)
4165 (Fcall_process_region):
4166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4167 (Fcall_process): Simplify handling of volatile integers.
4168 Use int, not EMACS_INT, where int will do.
4169 * casefiddle.c (casify_object, casify_region, operate_on_word)
4170 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4172 (casify_object): Avoid integer overflow when overallocating buffer.
4173 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4174 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4175 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4176 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4177 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4178 integers are now checked earlier. All uses replaced with XINT.
4179 (ccl_driver):
4180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4181 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4182 (ccl_driver, Fregister_code_conversion_map):
4183 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4184 (resolve_symbol_ccl_program): Check that vector header is in range.
4185 Always copy the vector, so that we can check its contents reliably
4186 now rather than having to recheck each instruction as it's being
4187 executed. Check that vector words fit in 'int'.
4188 (ccl_get_compiled_code, Fregister_ccl_program)
4189 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4190 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4191 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4192 contents are in range.
4193 (Fccl_execute_on_string): Check that status is in range.
4194 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4195 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4196 Accept and return EMACS_INT, not int, because callers can pass values
4197 out of 'int' range.
4198 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4199 (multibyte_chars_in_text, parse_str_as_multibyte)
4200 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4201 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4202 (string_escape_byte8, Fget_byte):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4204 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4205 avoid mishandling large integers.
4206 * character.h: Adjust decls to match defn changes elsewhere.
4207 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4208 (Ffind_charset_region):
4209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4210 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4211 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4212 Don't assume fixnum fits in int.
d311d28c
PE
4213 (load_charset_map_from_vector, Fmap_charset_chars):
4214 Remove now-unnecessary CHECK_NATNUMs.
4215 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4216 Don't rely on undefined behavior with signed left shift overflow.
4217 Don't assume unsigned int fits into fixnum, or that fixnum fits
4218 into unsigned int. Don't require max_code to be a valid fixnum;
4219 that's not true for gb10830 4-byte on a 32-bit host. Allow
4220 invalid_code to be a cons, for the same reason. Require code_offset
4221 to be a character. Avoid int overflow if max_char is close
4222 to INT_MAX.
4223 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4224 this is intended anyway and avoids some undefined behavior.
4225 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4226 INDEX_TO_CODE_POINT, as that's what it expects.
4227 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4228 * charset.h (DECODE_CHAR): Return int, not unsigned;
4229 this is what was intended anyway, and it avoids undefined behavior.
4230 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4231 integer-overflow issues.
4232 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4233 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4234 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4235 * chartab.c (Fmake_char_table, Fset_char_table_range)
4236 (uniprop_get_decoder, uniprop_get_encoder):
4237 Don't assume fixnum fits in int.
4238 * cmds.c (move_point): New function, that does the gist of
4239 Fforward_char and Fbackward_char, but does so while checking
4240 for integer overflow more accurately.
c96e5d6a 4241 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4242 (Fforward_line, Fend_of_line, internal_self_insert)
4243 (internal_self_insert):
4244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4245 Fix a FIXME, by checking for integer overflow when calculating
4246 target_clm and actual_clm.
4247 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4248 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4249 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4250 (coding_alloc_by_making_gap, alloc_destination)
4251 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4252 (encode_coding_utf_16, detect_coding_emacs_mule)
4253 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4254 (detect_coding_iso_2022, decode_coding_iso_2022)
4255 (encode_invocation_designation, encode_designation_at_bol)
4256 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4257 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4258 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4259 (encode_coding_ccl, encode_coding_raw_text)
4260 (detect_coding_charset, decode_coding_charset)
4261 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4262 (produce_composition, produce_charset, produce_annotation)
4263 (decode_coding, handle_composition_annotation)
4264 (handle_charset_annotation, consume_chars, decode_coding_gap)
4265 (decode_coding_object, encode_coding_object, detect_coding_system)
4266 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4267 (code_convert_region, code_convert_string)
8f50130c
PE
4268 (Fdefine_coding_system_internal)
4269 (coding_set_source, coding_set_destination):
d311d28c
PE
4270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4271 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4272 (Fdefine_coding_system_internal):
4273 Don't assume fixnums fit in int.
4274 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4275 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4276 (Funencodable_char_position, Fcheck_coding_systems_region)
4277 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4279 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4280 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4281 Don't access memory outside of the args array.
d311d28c 4282 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4283 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4284 result of ENCODE_CHAR.
d311d28c
PE
4285 * coding.h: Adjust decls to match defn changes elsewhere.
4286 (struct coding_system):
4287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4288 * composite.c (get_composition_id, find_composition)
4289 (run_composition_function, update_compositions)
4290 (compose_text, composition_gstring_put_cache)
4291 (composition_gstring_p, composition_gstring_width)
4292 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4293 (composition_compute_stop_pos, composition_reseat_it)
4294 (composition_update_it, struct position_record)
4295 (find_automatic_composition, composition_adjust_point)
4296 (Fcomposition_get_gstring, Ffind_composition_internal):
4297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4298 (update_compositions):
4299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4300 * composite.h: Adjust decls to match defn changes elsewhere.
4301 (struct composition):
4302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4303 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4304 Do not attempt to compute the address of the object just before a
4305 buffer; this is not portable.
4306 (Faref, Faset):
4307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4308 (Faset): Use int, not EMACS_INT, where int is wide enough.
4309 (Fstring_to_number): Don't assume fixnums fit in int.
4310 (Frem): Don't assume arg is nonnegative.
4311 * dbusbind.c (xd_append_arg): Check for integers out of range.
4312 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4313 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4314 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4315 (xd_get_connection_references): Return ptrdiff_t, not int.
4316 All uses changed.
4317 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4318 (xd_read_message_1):
4319 Use int, not unsigned, where the dbus API uses int.
4320 (Fdbus_message_internal): Don't overflow mtype.
4321 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4322 * dired.c (directory_files_internal, file_name_completion, scmp)
4323 (file_name_completion_stat):
4324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4325 (file_name_completion): Don't overflow matchcount.
4326 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4327 * dispextern.h: Adjust decls to match defn changes elsewhere.
4328 (struct text_pos, struct glyph, struct bidi_saved_info)
4329 (struct bidi_string_data, struct bidi_it, struct composition_it)
4330 (struct it):
4331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4332 (struct display_pos, struct composition_it, struct it):
4333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4334 * dispnew.c (increment_matrix_positions)
4335 (increment_row_positions, mode_line_string)
4336 (marginal_area_string):
4337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4338 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4340 (duration_to_sec_usec): New function, to check for overflow better.
4341 (Fsleep_for, sit_for): Use it.
4342 * doc.c (get_doc_string, store_function_docstring):
4343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4344 (get_doc_string, Fsnarf_documentation):
4345 Use int, not EMACS_INT, where int is wide enough.
4346 (get_doc_string):
4347 Use SAFE_ALLOCA, not alloca.
4348 Check for overflow when converting EMACS_INT to off_t.
4349 * doprnt.c (doprnt):
4350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4351 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4352 Don't assume uid_t fits into fixnum.
4353 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4354 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4355 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4356 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4357 (general_insert_function)
4358 (Finsert_char, make_buffer_string, make_buffer_string_both)
4359 (update_buffer_properties, Fbuffer_substring)
4360 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4361 (Fsubst_char_in_region, check_translation)
4362 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4363 (transpose_markers, Ftranspose_regions):
4364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4365 (clip_to_bounds): Move to lisp.h as an inline function).
4366 (Fconstrain_to_field): Don't assume integers are nonnegative.
4367 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4368 (Fsubst_char_in_region, Fsave_restriction):
4369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4370 (Femacs_pid): Don't assume pid_t fits into fixnum.
4371 (lo_time): Use int, not EMACS_INT, when int suffices.
4372 (lisp_time_argument): Check for usec out of range.
4373 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4374 (Fuser_login_name, Fuser_full_name): Signal an error
4375 if a uid argument is out of range, rather than relying on
4376 undefined behavior.
c8d5c857
PE
4377 (Fformat_time_string): Remove now-unnecessary check.
4378 lisp_time_argument checks for out-of-range usec now.
243e0530 4379 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4380 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4381 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4382 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4383 (init_cmdargs, Fdump_emacs):
4384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4385 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4386 the bottom (typically) 32 bits of the fixnum.
4387 * eval.c (specpdl_size, call_debugger):
4388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4389 (when_entered_debugger, Fbacktrace_debug):
4390 Don't assume fixnum can fit in int.
4391 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4392 the object just before a buffer; this is not portable.
4393 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4394 (grow_specpdl, unbind_to):
4395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4396 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4397 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4398 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4399 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4400 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4402 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4403 (a_write, e_write):
4404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4405 (Fcopy_file, non_regular_nbytes, read_non_regular)
4406 (Finsert_file_contents):
4407 Use int, not EMACS_INT, where int is wide enough.
4408 (READ_BUF_SIZE): Verify that it fits in int.
4409 (Finsert_file_contents): Check that counts are in proper range,
4410 rather than assuming fixnums fit into ptrdiff_t etc.
4411 Don't assume fixnums fit into int.
125b3835 4412 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4413 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4414 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4415 (string_char_to_byte, string_byte_to_char)
4416 (string_make_multibyte, string_to_multibyte)
4417 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4418 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4419 (substring_both, Fdelete, internal_equal, Ffillarray)
4420 (Fclear_string, mapcar1)
4421 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4422 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4423 (larger_vector, make_hash_table, maybe_resize_hash_table)
4424 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4425 (Fmaphash, secure_hash):
4426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4427 (concat): Check for string index and length overflow.
4428 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4429 (Frequire):
4430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4431 (larger_vector): New API (vec, incr_min, size_max) replaces old
4432 one (vec, new_size, init). This catches size overflow.
4433 INIT was removed because it was always Qnil.
4434 All callers changed.
4435 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4436 the upper bound on a hash table index size.
4437 (make_hash_table, maybe_resize_hash_table): Use it.
4438 (secure_hash): Computer start_byte and end_byte only after
4439 they're known to be in ptrdiff_t range.
4440 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4441 (Ffont_get_glyphs, Ffont_at):
4442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4443 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4444 (Flist_fonts, Fopen_font):
4445 Don't assume fixnum can fit in int.
4446 (check_gstring): Don't assume index can fit in int.
4447 (font_match_p): Check that fixnum is a character, not a nonnegative
4448 fixnum, since the later code needs to stuff it into an int.
4449 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4450 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4451 conversion overflow issues.
4452 (Fopen_font): Check for integer out of range.
4453 (Ffont_get_glyphs): Don't assume index can fit in int.
4454 * font.h: Adjust decls to match defn changes elsewhere.
4455 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4456 integer overflow.
4457 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4458 printmax_t, where ptrdiff_t is wide enough.
4459 (Finternal_char_font):
4460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4461 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4462 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4463 (Fset_frame_position, x_set_frame_parameters)
4464 (x_set_line_spacing, x_set_border_width)
4465 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4466 Check that fixnums are in proper range for system types.
4467 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4469 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4470 Use SAFE_ALLOCA_LISP, not alloca.
4471 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4472 intptr_t is wide enough.
4473 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4474 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4475 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4476 Check for fixnum out of range.
4477 * ftfont.c (ftfont_list): Don't assume index fits in int.
4478 Check that fixnums are in proper range for system types.
4479 (ftfont_shape_by_flt):
4480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4481 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4483 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4484 Check that fixnums are in proper range for system types.
4485 * gnutls.h: Adjust decls to match defn changes elsewhere.
4486 * gtkutil.c (xg_dialog_run):
4487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4488 (update_frame_tool_bar):
4489 Check that fixnums are in proper range for system types.
4490 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4491 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4492 * indent.c (last_known_column, last_known_column_point):
4493 (current_column_bol_cache):
4494 (skip_invisible, current_column, check_display_width):
4495 (check_display_width, scan_for_column, current_column_1)
4496 (Findent_to, Fcurrent_indentation, position_indentation)
4497 (indented_beyond_p, Fmove_to_column, compute_motion):
4498 (Fcompute_motion, Fvertical_motion):
4499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4500 (last_known_column_modified): Use EMACS_INT, not int.
4501 (check_display_width):
4502 (Fcompute_motion):
4503 Check that fixnums and floats are in proper range for system types.
4504 (compute_motion): Don't assume index or fixnum fits in int.
4505 (compute_motion, Fcompute_motion):
4506 Use int, not EMACS_INT, when it is wide enough.
4507 (vmotion): Omit local var start_hpos that is always 0; that way
4508 we don't need to worry about overflow in expressions involving it.
4509 * indent.h: Adjust decls to match defn changes elsewhere.
4510 (struct position):
4511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4512 Use int, not EMACS_INT, where int is wide enough.
4513 Remove unused members ovstring_chars_done and tab_offset;
4514 all uses removed.
4515 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4516 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4517 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4518 (make_gap, copy_text, insert, insert_and_inherit)
4519 (insert_before_markers, insert_before_markers_and_inherit)
4520 (insert_1, count_combining_before, count_combining_after)
4521 (insert_1_both, insert_from_string)
4522 (insert_from_string_before_markers, insert_from_string_1)
4523 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4524 (adjust_after_replace, adjust_after_insert, replace_range)
4525 (replace_range_2, del_range, del_range_1, del_range_byte)
4526 (del_range_both, del_range_2, modify_region)
4527 (prepare_to_modify_buffer, signal_before_change)
4528 (signal_after_change, Fcombine_after_change_execute):
4529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4530 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4531 (balance_an_interval, split_interval_right, split_interval_left)
4532 (find_interval, next_interval, update_interval)
4533 (adjust_intervals_for_insertion, delete_node, delete_interval)
4534 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4535 (static_offset_intervals, offset_intervals)
4536 (merge_interval_right, merge_interval_left, make_new_interval)
4537 (graft_intervals_into_buffer, temp_set_point_both)
4538 (temp_set_point, set_point, adjust_for_invis_intang)
4539 (set_point_both, move_if_not_intangible, get_property_and_range)
4540 (get_local_map, copy_intervals, copy_intervals_to_string)
4541 (compare_string_intervals, set_intervals_multibyte_1):
4542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4543 * intervals.h: Adjust decls to match defn changes elsewhere.
4544 (struct interval):
4545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4546 * keyboard.c (this_command_key_count, this_single_command_key_start)
4547 (before_command_key_count, before_command_echo_length, echo_now)
4548 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4549 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4550 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4551 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4553 (last_non_minibuf_size, last_point_position, echo_truncate)
4554 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4555 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4556 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4557 (stuff_buffered_input):
4558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4559 (last_auto_save, command_loop_1, read_char):
4560 Use EMACS_INT, not int, to avoid integer overflow.
4561 (record_char): Avoid overflow in total_keys computation.
4562 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4563 * keyboard.h: Adjust decls to match defn changes elsewhere.
4564 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4565 (Fkey_description, Fdescribe_vector, Flookup_key):
4566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4567 (click_position): New function, to check that positions are in range.
4568 (Fcurrent_active_maps):
4569 (describe_command):
4570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4571 (Faccessible_keymaps, Fkey_description):
4572 (preferred_sequence_p):
4573 Don't assume fixnum can fit into int.
4574 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4575 Check for integer overflow in size calculations.
4576 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4577 avoid mishandling large integers.
4578 * lisp.h: Adjust decls to match defn changes elsewhere.
4579 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4580 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4581 (struct Lisp_Marker):
4582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4583 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4584 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4585 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4586 All callers changed.
4587 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4588 Assume the arg has valid form, since it always does.
4589 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4590 unsigned integer system type.
4591 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4592 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4594 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4595 (duration_to_sec_usec): New decl.
4596 * lread.c (read_from_string_index, read_from_string_index_byte)
4597 (read_from_string_limit, readchar, unreadchar, openp)
4598 (read_internal_start, read1, oblookup):
4599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4600 (Fload, readevalloop, Feval_buffer, Feval_region):
4601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4602 (openp): Check for out-of-range argument to 'access'.
4603 (read1): Use int, not EMACS_INT, where int is wide enough.
4604 Don't assume fixnum fits into int.
6efdadfd 4605 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4606 (read_filtered_event): Use duration_to_sec_usec
4607 to do proper overflow checking on durations.
d311d28c
PE
4608 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4609 in size calculation.
4610 (Fexecute_kbd_macro):
4611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4612 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4613 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4614 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4615 (set_marker_both, set_marker_restricted_both, marker_position)
4616 (marker_byte_position, Fbuffer_has_markers_at):
4617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4618 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4619 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4620 It now merely ensures that the menu is large enough, without
4621 necessarily growing it, as this avoids some integer overflow issues.
4622 All callers changed.
4623 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4625 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4626 Use SAFE_ALLOCA_LISP, not alloca.
4627 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4628 to EMACS_INT. Check that fixnums are in proper range for system types.
4629 * minibuf.c (minibuf_prompt_width, string_to_object)
4630 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4631 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4633 (get_minibuffer, read_minibuf_unwind):
4634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4635 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4636 this simplifies overflow checking. All callers changed.
4637 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4638 (Ftest_completion):
4639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4640 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4641 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4642 Check that fixnums are in proper range for system types.
4643 (Fx_create_frame, Fx_show_tip):
4644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4645 * nsfont.m (ns_findfonts, nsfont_list_family):
4646 Don't assume fixnum fits in long.
4647 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4649 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4650 wide enough.
17fdb222 4651 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4653 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4654 (PRINTDECLARE, PRINTPREPARE):
4655 (strout, print_string):
4656 (print, print_preprocess, print_check_string_charset_prop)
4657 (print_object):
4658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4659 (PRINTDECLARE):
4660 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4662 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4663 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4664 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4665 (print_error_message): Use SAFE_ALLOCA, not alloca.
4666 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4667 (print_depth, new_backquote_output, print_number_index):
4668 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4669 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4670 (Fset_process_window_size, Fformat_network_address)
4671 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4672 (sigchld_handler):
d311d28c 4673 Check that fixnums are in proper range for system types.
d44287d4 4674 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4675 Check for process-ids out of pid_t range rather than relying on
4676 undefined behavior.
e4d81efc 4677 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4678 (Fformat_network_address, read_process_output, send_process)
4679 (Fprocess_send_region, status_notify):
4680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4681 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4682 (wait_reading_process_output, read_process_output, exec_sentinel):
4683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4684 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4685 (Faccept_process_output): Use duration_to_sec_usec to do proper
4686 overflow checking on durations.
dde14581
PE
4687 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4688 Don't assume pid_t fits in int.
02481186
PE
4689 * process.h (struct Lisp_Process): Members tick and update_tick
4690 are now of type EMACS_INT, not int.
b62b53e8
PE
4691 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4692 configured --with-wide-int.
d311d28c
PE
4693 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4694 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4695 * search.c (looking_at_1, string_match_1):
4696 (fast_string_match, fast_c_string_match_ignore_case)
4697 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4698 (scan_newline, find_before_next_newline, search_command)
4699 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4700 (set_search_regs, wordify):
4701 (Freplace_match):
4702 (Fmatch_data):
4703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4704 (string_match_1, search_buffer, set_search_regs):
4705 (Fmatch_data):
4706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4707 (wordify): Check for overflow in size calculation.
4708 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4709 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4710 Check that fixnums are in proper range for system types.
4711 * sound.c (struct sound_device)
4712 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4714 (Fplay_sound_internal):
4715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4716 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4717 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4718 (Fparse_partial_sexp):
4719 Don't assume fixnums can fit in int.
4720 (struct lisp_parse_state, find_start_pos, find_start_value)
4721 (find_start_value_byte, find_start_begv)
4722 (update_syntax_table, char_quoted, dec_bytepos)
4723 (find_defun_start, prev_char_comend_first, back_comment):
4724 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4725 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4727 (Finternal_describe_syntax_value): Check that match_lisp is a
4728 character, not an integer, since the code stuffs it into int.
4729 (scan_words, scan_sexps_forward):
4730 Check that fixnums are in proper range for system types.
4731 (Fforward_word):
4732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4733 (scan_sexps_forward):
4734 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4735 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4736 * syntax.h: Adjust decls to match defn changes elsewhere.
4737 (struct gl_state_s):
4738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4739 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4740 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4741 * sysdep.c (wait_for_termination_1, wait_for_termination)
4742 (interruptible_wait_for_termination, mkdir):
4743 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4744 (emacs_read, emacs_write):
4745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4746 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4747 and double all fit in int.
d311d28c
PE
4748 * term.c (set_tty_color_mode):
4749 Check that fixnums are in proper range for system types.
4750 * termhooks.h (struct input_event):
4751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4752 * textprop.c (validate_interval_range, interval_of)
4753 (Fadd_text_properties, set_text_properties_1)
4754 (Fremove_text_properties, Fremove_list_of_text_properties)
4755 (Ftext_property_any, Ftext_property_not_all)
4756 (copy_text_properties, text_property_list, extend_property_ranges)
4757 (verify_interval_modification):
4758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4759 (Fnext_single_char_property_change)
4760 (Fprevious_single_char_property_change):
4761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4762 (copy_text_properties):
4763 Check for integer overflow in index calculation.
d311d28c
PE
4764 * undo.c (last_boundary_position, record_point, record_insert)
4765 (record_delete, record_marker_adjustment, record_change)
4766 (record_property_change):
4767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4768 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4770 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4771 (Fx_hide_tip, Fx_file_dialog):
4772 * w32menu.c (set_frame_menubar):
4773 Use ptrdiff_t, not int, for consistency with rest of code.
4774 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4775 (select_window, Fdelete_other_windows_internal)
4776 (window_scroll_pixel_based, window_scroll_line_based)
4777 (Frecenter, Fset_window_configuration):
4778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4779 (Fset_window_hscroll, run_window_configuration_change_hook)
4780 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4781 (Fscroll_other_window, Frecenter):
d311d28c
PE
4782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4783 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4784 Don't assume fixnum fits in int.
4785 (Fset_window_scroll_bars):
4786 Check that fixnums are in proper range for system types.
4787 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4788 (string_pos, c_string_pos, number_of_chars, init_iterator)
4789 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4790 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4791 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4792 (face_before_or_after_it_pos, handle_invisible_prop)
4793 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4794 (display_prop_intangible_p, string_buffer_position_lim)
4795 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4796 (get_overlay_strings_1, get_overlay_strings)
4797 (iterate_out_of_display_property, forward_to_next_line_start)
4798 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4799 (get_next_display_element, set_iterator_to_next)
4800 (get_visually_first_element, compute_stop_pos_backwards)
4801 (handle_stop_backwards, next_element_from_buffer)
4802 (move_it_in_display_line_to, move_it_in_display_line)
4803 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4804 (add_to_log, message_dolog, message_log_check_duplicate)
4805 (message2, message2_nolog, message3, message3_nolog
4806 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4807 (current_message_1, truncate_echo_area, truncate_message_1)
4808 (set_message, set_message_1, store_mode_line_noprop)
4809 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4810 (text_outside_line_unchanged_p, check_point_in_composition)
4811 (reconsider_clip_changes)
4812 (redisplay_internal, set_cursor_from_row, try_scrolling)
4813 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4814 (redisplay_window, find_last_unchanged_at_beg_row)
4815 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4816 (trailing_whitespace_p, find_row_edges, display_line)
4817 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4818 (display_mode_element, store_mode_line_string)
4819 (pint2str, pint2hrstr, decode_mode_spec)
4820 (display_count_lines, display_string, draw_glyphs)
4821 (x_produce_glyphs, x_insert_glyphs)
4822 (rows_from_pos_range, mouse_face_from_buffer_pos)
4823 (fast_find_string_pos, mouse_face_from_string_pos)
4824 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4826 (safe_call, init_from_display_pos, handle_fontified_prop)
4827 (handle_single_display_spec, load_overlay_strings)
4828 (with_echo_area_buffer, setup_echo_area_for_printing)
4829 (display_echo_area, echo_area_display)
4830 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4831 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4832 (redisplay_window, dump_glyph_row, display_mode_line)
4833 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4834 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4836 (handle_single_display_spec, build_desired_tool_bar_string)
4837 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4838 (get_specified_cursor_type):
4839 Check that fixnums are in proper range for system types.
4840 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4841 (Flookup_image_map):
4842 Don't assume fixnums fit in int.
4843 (compare_overlay_entries):
4844 Avoid mishandling comparisons due to subtraction overflow.
4845 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4846 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4847 (handle_tool_bar_click):
4848 Use int, not unsigned, since we prefer signed and the signedness
4849 doesn't matter here.
4850 (get_next_display_element, next_element_from_display_vector):
4851 Use int, not EMACS_INT, when int is wide enough.
4852 (start_hourglass): Use duration_to_sec_usec to do proper
4853 overflow checking on durations.
4854 * xfaces.c (Fbitmap_spec_p):
4855 Check that fixnums are in proper range for system types.
4856 (compare_fonts_by_sort_order):
4857 Avoid mishandling comparisons due to subtraction overflow.
4858 (Fx_family_fonts, realize_basic_faces):
4859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4860 (Fx_family_fonts):
4861 Don't assume fixnum fits in int.
4862 Use SAFE_ALLOCA_LISP, not alloca.
4863 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4864 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4865 (face_at_buffer_position, face_for_overlay_string)
4866 (face_at_string_position):
4867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4868 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4869 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4870 (Fx_show_tip):
4871 Check that fixnums are in proper range for system types.
4872 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4873 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4875 (Fx_change_window_property): Don't assume fixnums fit in int.
4876 * xfont.c (xfont_chars_supported):
4877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4878 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4879 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4881 * xml.c (parse_region):
4882 * xrdb.c (magic_file_p):
4883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4884 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4885 (x_get_local_selection, x_reply_selection_request)
4886 (x_handle_selection_request, wait_for_property_change):
4887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4888 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4889 short is wide enough.
4890 (x_send_client_event): Don't assume fixnum fits in int.
4891 * xterm.c (x_x_to_emacs_modifiers):
4892 Don't assume EMACS_INT overflows nicely into int.
4893 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4894 may come from Lisp.
4895 (handle_one_xevent): NATNUMP can eval its arg twice.
4896 (x_connection_closed):
4897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4898 * xterm.h: Adjust decls to match defn changes elsewhere.
4899 (struct scroll_bar): Use struct vectorlike_header
4900 rather than rolling our own approximation.
4901 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4902
c6574eb5
GM
49032012-05-25 Glenn Morris <rgm@gnu.org>
4904
4905 * lisp.mk (lisp): Update for more files being compiled now.
4906
e8d32c7e
SM
49072012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4908
48def666
SM
4909 * lread.c: Remove `read_pure' which makes no difference.
4910 (read_pure): Remove var.
4911 (unreadpure): Remove function.
4912 (readevalloop): Don't call read_list with -1 flag.
4913 (read1, read_vector): Don't test read_pure any more.
4914 (read_list): Simplify.
4915
e8d32c7e
SM
4916 * fileio.c, character.h: Minor style tweaks.
4917
4b2addb7
DA
49182012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4919
4920 * window.h (clip_changed): Remove useless declaration.
4921
584461b2
JB
49222012-05-22 Juanma Barranquero <lekktu@gmail.com>
4923
4924 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4925 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4926
34374650
PE
49272012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4928
4929 Remove src/m/*.
4930 This directory predates autoconf and is no longer needed nowadays.
4931 Move its few remaining bits of functionality to where they're needed.
4932 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4933 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4934 * m/template.h: Remove.
4935 * Makefile.in (M_FILE): Remove. All uses removed.
4936 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4937 * lisp.h (USE_LSB_TAG):
4938 * mem-limits.h (EXCEEDS_LISP_PTR):
4939 Use VAL_MAX, not VALBITS, in #if.
4940 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4941 (EMACS_UINT): Define unconditionally now.
4942 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4943 (BITS_PER_EMACS_INT): New constants, replacing
4944 what used to be in config.h, but not useful in #if.
4945 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4946 define them any more.
4947 (VAL_MAX): New macro.
4948 (VALMASK): Use it.
4949 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4950 BITS_PER_EMACS_INT, in #if.
4951 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4952 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4953 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4954 * s/ms-w32.h (DATA_START):
4955 Move here from removed file m/intel386.h.
4956 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4957 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4958
261cb4bb
PE
49592012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4960
4961 Assume C89 or later.
4962 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4963 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4964 (xrealloc):
4965 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4966 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4967 * textprop.c, tparam.c (NULL): Remove.
4968 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4969 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4970 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4971 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4972 * xterm.c (input_signal_count): Assume volatile works.
4973
ff23cd9f
KB
49742012-05-21 Ken Brown <kbrown@cornell.edu>
4975
4976 * xgselect.c (xg_select): Fix first argument in call to 'select'
4977 (bug#11508).
4978
1b170bc6
KB
49792012-05-20 Ken Brown <kbrown@cornell.edu>
4980
4981 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4982 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4983
b2f4d39f
KB
49842012-05-19 Ken Brown <kbrown@cornell.edu>
4985
4986 * xfns.c (x_in_use): Remove `static' qualifier.
4987 * xterm.h (x_in_use): Declare.
4988 * xgselect.c: Include xterm.h.
4989 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4990 and `display_arg' (bug#9754).
4991
003fdae2
PE
49922012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4993
9232a6d9
PE
4994 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4995
003fdae2
PE
4996 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4997 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4998
784b56e2
EZ
49992012-05-18 Eli Zaretskii <eliz@gnu.org>
5000
5001 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5002
5003 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5004 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5005
5006 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5007 reference to image_cache->refcount.
5008 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5009
a0a79cde
JL
50102012-05-17 Juri Linkov <juri@jurta.org>
5011
5012 * search.c (Fword_search_regexp, Fword_search_backward)
5013 (Fword_search_forward, Fword_search_backward_lax)
5014 (Fword_search_forward_lax): Move functions to isearch.el
5015 (bug#10145, bug#11381).
5016
b0572523
PE
50172012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5018
5019 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5020
9660f5fc
SM
50212012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5022
5023 * lread.c (init_obarray): Declare Qt and Qnil as special.
5024
4374de83
GM
50252012-05-14 Glenn Morris <rgm@gnu.org>
5026
5027 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5028 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5029
dc44c39a
PE
50302012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5031
078c97cb
PE
5032 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5033
dc44c39a
PE
5034 * unexaix.c: Port to more-recent AIX compilers.
5035 (report_error, report_error_1, make_hdr, copy_sym)
5036 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5037 Make arguments const char *, not char *, to avoid violations of C
5038 standard and to fix some AIX warnings reported by Gilles Pion.
5039
e18afed7 50402012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5041
5042 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5043 already have overlays loaded.
5044 (handle_single_display_spec): Before returning without displaying
5045 fringe bitmap, synchronize the bidi iterator with the main display
5046 iterator, by calling iterate_out_of_display_property.
5047 (iterate_out_of_display_property): Detect buffer iteration by
5048 testing that it->string is a Lisp string.
5049 (get_next_display_element): When the current object is exhausted,
5050 and there's something on it->stack, call set_iterator_to_next to
5051 proceed with what's on the stack, instead of returning zero.
5052 (set_iterator_to_next): If called at the end of a Lisp string,
5053 proceed to consider_string_end without incrementing string
5054 position. Don't increment display vector index past the end of
5055 the display vector. (Bug#11417)
c8fb9dc6
EZ
5056 (pos_visible_p): Don't report a position visible when move_it_to
5057 stopped at the last line of window, which happens to be scanned
5058 backwards by the bidi iteration. (Bug#11464)
ac268e67 5059
e18afed7 50602012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5061
5062 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5063 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5064 are on a TTY, and thus unable to display on the fringes.
5065 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5066 so we need to signal to the caller that this is a "replacing"
5067 display spec. This fixes display when the spec is invalid or we
5068 are on a TTY.
5069
e18afed7 50702012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5071
5072 * unexaix.c (make_hdr): Fix typo in prototype.
5073 This bug broke the build on AIX. Problem reported by Gilles Pion.
5074
9d0a235a
MA
50752012-05-14 Michael Albinus <michael.albinus@gmx.de>
5076
5077 * keyboard.c (kbd_buffer_get_event): Read special events also in
5078 batch mode. (Bug#11415)
5079
9e6b06ed
GM
50802012-05-12 Glenn Morris <rgm@gnu.org>
5081
5082 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5083
c1a1d7a3
EZ
50842012-05-12 Eli Zaretskii <eliz@gnu.org>
5085
5086 * lisp.mk (lisp): Add newcomment.elc.
5087
3fe7cdc8
GM
50882012-05-12 Glenn Morris <rgm@gnu.org>
5089
5090 * Makefile.in (MKDIR_P): New, set by configure.
5091 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5092
53f7d2c0
PE
50932012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 Remove unused function hourglass_started.
5096 * dispextern.h (hourglass_started):
5097 * w32fns.c (hourglass_started):
5098 * xdisp.c (hourglass_started): Remove.
5099
75aafb17
JB
51002012-05-10 Juanma Barranquero <lekktu@gmail.com>
5101
5102 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5103 Update dependencies.
5104
12959e8e
PE
51052012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5106
97107e2e
PE
5107 * xgselect.c (xg_select): Put maxfds+1 into a var.
5108 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5109
12959e8e
PE
5110 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5111
836d29b3
DA
51122012-05-10 Dave Abrahams <dave@boostpro.com>
5113
5114 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5115 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5116
5cb67954
MA
51172012-05-09 Michael Albinus <michael.albinus@gmx.de>
5118
5119 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5120 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5121 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5122 Initialize xd_registered_buses.
5123
3478ec45
PE
51242012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5125
b263a6b0
PE
5126 Untag more efficiently if USE_LSB_TAG.
5127 This is based on a proposal by YAMAMOTO Mitsuharu in
5128 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5129 For an admittedly artificial (nth 8000 longlist) benchmark on
5130 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5131 Emacs's overall text size by 1%.
5132 * lisp.h (XUNTAG): New macro.
5133 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5134 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5135 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5136 * eval.c (Fautoload):
5137 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5138 * frame.h (XFRAME): Use XUNTAG.
5139
3478ec45
PE
5140 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5141 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5142 Remove unportable assumptions about print widths of types like
5143 dbus_uint32_t.
5144 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5145 intptr_t when converting between pointer and integer, to avoid GCC
5146 warnings about wrong width.
5147
666b903b 51482012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5149
5150 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5151 stack for each reader_thread, instead of defaulting to 8MB
5152 determined by the linker. This avoids failures in creating
5153 subprocesses on Windows 7, see the discussion in this thread:
5154 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5155
b120cc17
JC
51562012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5157
5158 Fix up display of the *Minibuf-0* buffer in the mini window.
5159 * keyboard.c (read_char): Don't clear the echo area if there's no
5160 message to clear.
5161 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5162 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5163
9a4b36f8
MA
51642012-05-07 Michael Albinus <michael.albinus@gmx.de>
5165
5166 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5167 batch mode.
5168
e5f9458f
CY
51692012-05-06 Chong Yidong <cyd@gnu.org>
5170
5171 * lisp.mk (lisp): Update.
5172
eceeb5fc 51732012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5174
5175 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5176
71873e2b
SM
51772012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * data.c (PUT_ERROR): New macro.
5180 (syms_of_data): Use it. Add new error type `user-error'.
5181 * undo.c (user_error): New function.
5182 (Fprimitive_undo): Use it.
5183 * print.c (print_error_message): Adjust print style for `user-error'.
5184 * keyboard.c (user_error): New function.
5185 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5186
ab0fa4e4
PE
51872012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 Do not limit current-time-string to years 1000..9999.
5190 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5191 (Fcurrent_time_string): Support any year that is supported by the
5192 underlying localtime representation. Don't use asctime, as it
5193 has undefined behavior for years outside the range -999..9999.
5194
7ed806a7
PE
51952012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5196
5197 Fix race conditions involving setenv, gmtime, localtime, asctime.
5198 Without this fix, interrupts could mess up code that uses these
5199 nonreentrant functions, since setting TZ invalidates existing
5200 tm_zone or tzname values, and since most of these functions return
5201 pointers to static storage.
5202 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5203 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5204 Grow the critical sections to include not just invoking
5205 localtime/gmtime, but also accessing these functions' results
5206 including their tm_zone values if any, and any related TZ setting.
5207 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5208 so that the struct tm is saved in the critical section.
5209 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5210 motivated by the fact that memory allocation needs to be outside
5211 the critical section.
5212
0c16dfed
DA
52132012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5214
5215 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5216 with RESET_INTERVAL.
5217
5218 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5219 Remove duplicated buffer name initialization.
5220
3f83ace8
JM
52212012-05-02 Jim Meyering <jim@meyering.net>
5222
5223 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5224
c7b8541e
JM
5225 * xfns.c (x_window): Use xstrdup (Bug#11375).
5226
90207a15 52272012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5228
5229 * xdisp.c (pos_visible_p): If already at a newline from the
5230 display string before the 'while' loop, don't walk back the glyphs
5231 from it3.glyph_row. Solves assertion violation when the display
5232 string begins with a newline (egg.el). (Bug#11367)
5233
b593d6a9
AH
52342012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5235
5236 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5237 Move to simple.el.
5238
4737362e
GM
52392012-05-01 Glenn Morris <rgm@gnu.org>
5240
99cf43f9
GM
5241 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5242 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5243 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5244 All were removed before 23.1.
5245
9311dcff
GM
5246 * dispnew.c: Remove HAVE_LIBNCURSES test;
5247 it is always true on relevant platforms.
5248
4d5c6349
GM
5249 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5250 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5251
4737362e
GM
5252 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5253
74dd3a6b
AS
52542012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5255
5256 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5257 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5258 Remove.
5259
13c379ee
PE
52602012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5261
5262 Do not avoid creating empty evaporating overlays (Bug#9642).
5263 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5264 That is, do not delete an evaporating overlay if it becomes
5265 empty after its bounds are adjusted to fit within its buffer.
5266 This fix caused other problems, and I'm reverting it until we get
5267 to the bottom of them.
5268
a8e7d6d7 52692012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5270
5271 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5272
a8e7d6d7 52732012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5274
5275 * xdisp.c (pos_visible_p): If the window start position is beyond
5276 ZV, start the display from buffer beginning. Prevents assertion
5277 violation in init_iterator when the minibuffer window is scrolled
5278 via the scroll bar.
5279
5280 * window.c (window_scroll_pixel_based): Likewise.
5281
a8e7d6d7 52822012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5283
5284 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5285
a8e7d6d7 52862012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5287
5288 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5289 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5290
a8e7d6d7 52912012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5292
b593d6a9
AH
5293 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5294 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5295
1c6900d9
EZ
52962012-04-26 Eli Zaretskii <eliz@gnu.org>
5297
4c3fa1d9
EZ
5298 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5299 display element, check also the underlying string or buffer
5300 character. (Bug#11341)
5301
1c6900d9
EZ
5302 * w32menu.c: Include w32heap.h.
5303 (add_menu_item): If the call to AppendMenuW (via
5304 unicode_append_menu) fails, disable Unicode menus only if we are
5305 running on Windows 9X/Me.
5306
42bf8205
AS
53072012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5308
5309 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5310 (xgetint): Add missing shift for LSB tags.
5311
b1bac16e
MR
53122012-04-24 Martin Rudalics <rudalics@gmx.at>
5313
5314 * keyboard.c (read_char): Don't wipe echo area for select window
5315 events: These might get delayed via `mouse-autoselect-window'
5316 (Bug#11304).
5317
d69621cc
JB
53182012-04-24 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5321 manipulation of :loaded-from data.
5322
02fd101b
JB
53232012-04-23 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5326 now a cons (bug#11311).
5327
888bec30
PE
53282012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5329
89a438bd
PE
5330 Do not create empty overlays with the evaporate property (Bug#9642).
5331 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5332 if it becomes empty after its bounds are adjusted to fit within
5333 its buffer. Without this fix, in a nonempty buffer (let ((o
5334 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5335 yields an empty overlay that has the evaporate property, which is
5336 not supposed to happen.
5337
1068fe4d
PE
5338 Fix minor GTK3 problems found by static checking.
5339 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5340 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5341 (struct _EmacsFixedClass, emacs_fixed_get_type):
5342 Move decls here from emacsgtkfixed.h, since they needn't be public.
5343 (emacs_fixed_get_type): Now static.
5344 (emacs_fixed_class_init): Omit unused local.
5345 (emacs_fixed_child_type): Remove; unused.
5346 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5347 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5348 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5349 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5350 (EMACS_FIXED_GET_CLASS): Remove; unused.
5351 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5352
888bec30
PE
5353 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5354 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5355
de85e130
PE
53562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5357
d0baac98 5358 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5359 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5360 (__malloc_size_t, __malloc_ptrdiff_t):
5361 Remove. All uses removed, replaced by the definiens if needed,
5362 since we can assume C89 or better now.
5363 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5364 (protect_malloc_state, align, get_contiguous_space)
5365 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5366 (malloc_atfork_handler_child, malloc_enable_thread)
5367 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5368 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5369 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5370 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5371 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5372 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5373 Define using prototypes, not old style.
5374 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5375 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5376 (align): Don't assume that signed integer overflow wraps around.
5377 Omit unused local var.
5378 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5379 (_free_internal_nolock, memalign, mallochook, reallochook):
5380 Omit no-longer-needed casts.
5381 (valloc): Use getpagesize, not __getpagesize.
5382 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5383 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5384
de85e130
PE
5385 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5386
dcbf5805
MA
53872012-04-22 Michael Albinus <michael.albinus@gmx.de>
5388
5389 Move functions from C to Lisp. Make non-blocking method calls
5390 the default. Implement further D-Bus standard interfaces.
5391
5392 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5393 (QCdbus_request_name_allow_replacement)
5394 (QCdbus_request_name_replace_existing)
5395 (QCdbus_request_name_do_not_queue)
5396 (QCdbus_request_name_reply_primary_owner)
5397 (QCdbus_request_name_reply_in_queue)
5398 (QCdbus_request_name_reply_exists)
5399 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5400 (QCdbus_registered_serial, QCdbus_registered_method)
5401 (QCdbus_registered_signal): New Lisp objects.
5402 (XD_DEBUG_MESSAGE): Use sizeof.
5403 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5404 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5405 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5406 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5407 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5408 (xd_signature, xd_append_arg): Allow float for integer types.
5409 (xd_get_connection_references): New function.
b593d6a9
AH
5410 (xd_get_connection_address): Rename from xd_initialize.
5411 Return cached address.
dcbf5805
MA
5412 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5413 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5414 level.
5415 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5416 Return number of refcounts.
dcbf5805
MA
5417 (Fdbus_get_unique_name): Make stronger parameter check.
5418 (Fdbus_message_internal): New defun.
5419 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5420 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5421 (Fdbus_send_signal, Fdbus_register_service)
5422 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5423 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5424 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5425 (Vdbus_compiled_version, Vdbus_runtime_version)
5426 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5427 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5428 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5429 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5430 Adapt docstring.
dcbf5805 5431
52828e02
PE
54322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5433
da05bc4c
PE
5434 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5435 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5436 Do not assume ptrdiff_t is the same width as 'int'.
5437
52828e02
PE
5438 * alloc.c: Handle unusual debugging option combinations.
5439 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5440 since the two debugging options are incompatible.
5441 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5442 is defined.
5443 (mem_init, mem_insert, mem_insert_fixup):
5444 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5445 (NEED_MEM_INSERT): Remove; no longer needed.
5446
f01769f9
LL
54472012-04-22 Leo Liu <sdl.web@gmail.com>
5448
5449 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5450
5790543d
PE
54512012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5452
5453 * sysdep.c [__FreeBSD__]: Minor cleanups.
5454 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5455 Use Emacs indenting style more consistently. Avoid some casts.
5456 Use 'double' consistently rather than mixing 'float' and 'double'.
5457
b91b7e4d
EW
54582012-04-21 Eduard Wiebe <usenet@pusto.de>
5459
b593d6a9
AH
5460 * sysdep.c (list_system_processes, system_process_attributes):
5461 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5462
6114eb15
AS
54632012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5464
5465 * lisp.mk (lisp): Update.
5466
2f38dff7
PE
54672012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5468
5469 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5470 It is never used otherwise.
5471
4ae29f89
SM
54722012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5473
5474 * print.c (print_preprocess): Only check print_depth if print-circle
5475 is nil.
5476 (print_object): Check for cycles even when print-circle is nil and
5477 print-gensym is t, but only check print_depth if print-circle is nil.
5478
f30d612a
CY
54792012-04-20 Chong Yidong <cyd@gnu.org>
5480
5481 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5482 set the status to "failed" and ensure that sentinel is run.
5483
c07a4c0b 54842012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5485
5486 * process.c (Fset_process_inherit_coding_system_flag)
5487 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5488 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5489
c07a4c0b 54902012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5491
5492 * xdisp.c (string_buffer_position_lim): Limit starting position to
5493 BEGV.
5494 (set_cursor_from_row): If called for a mode-line or header-line
5495 row, return zero immediately.
5496 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5497 farther than the first row after the header line, if any.
5498 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5499 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5500
c07a4c0b 55012012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5502
4ae29f89
SM
5503 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5504 (bug#11238).
ad3a2b41 5505
c07a4c0b 55062012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55072012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5508
5509 configure: new option --enable-gcc-warnings (Bug#11207)
5510 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5511 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5512 (ALL_CFLAGS): Use new macros rather than old.
5513 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5514 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5515 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5516 -Wunused-result, -Wunused-variable. This should go away once
5517 the Emacs and Gnulib regex code is merged.
5518 (xmalloc, xrealloc): Now static.
5519
aba027e8
PE
55202012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5521
5522 * dired.c (Fsystem_groups): Remove unused local.
5523
e5a36063
GM
55242012-04-17 Glenn Morris <rgm@gnu.org>
5525
5526 * dired.c (Fsystem_users): Doc fix.
5527
316411f0
DA
55282012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5529
5530 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5531 (syms_of_dired): Add them.
5532
9426aba4
PE
55332012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5534
b62a57be
PE
5535 Fix minor alloc.c problems found by static checking.
5536 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5537 New extern decls, to avoid calling undeclared functions.
5538 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5539 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5540 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5541 (NEED_MEM_INSERT): New macro.
5542 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5543 Remove one incorrect comment and fix another.
b62a57be 5544
3539f31f
PE
5545 Fix minor ralloc.c problems found by static checking.
5546 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5547 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5548 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5549 (r_alloc_sbrk): Now static.
5550
a041960a
PE
5551 Improve ralloc.c interface checking.
5552 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5553 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5554 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5555 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5556 [REL_ALLOC]: ... to here, to check interface.
5557 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5558 Remove decls. This fixes an "It stinks!".
5559
9426aba4
PE
5560 * alloc.c (which_symbols): Fix alignment issue / type clash.
5561
d55c12ed
AS
55622012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5563
5564 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5565 (struct Lisp_Misc_Any): Likewise.
5566 (struct Lisp_Free): Likewise.
5567 * alloc.c (union aligned_Lisp_Symbol): Define.
5568 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5569 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5570 (union aligned_Lisp_Misc): Define.
5571 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5572 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5573 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5574
b948ce8b
PE
55752012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5576
5577 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5578 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5579 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5580 * s/netbsd.h, s/sol2-6.h:
5581 Remove definition of GC_MARK_STACK, since the default now works.
5582 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5583 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5584 no longer the default.
5585 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5586
35dc09a1 55872012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5588
35dc09a1
GM
5589 * lread.c (lisp_file_lexically_bound_p):
5590 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5591
35dc09a1
GM
55922012-04-14 Eli Zaretskii <eliz@gnu.org>
5593
5594 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5595 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5596
55972012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5598
5599 * nsterm.m (constrainFrameRect): Always constrain when there is only
5600 one screen (Bug#10962).
5601
bcd86815
KB
56022012-04-13 Ken Brown <kbrown@cornell.edu>
5603
5604 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5605
c25df26e
RT
56062012-04-13 Reuben Thomas <rrt@sc3d.org>
5607
5608 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5609
0fc59f1e
DC
56102012-04-11 Daniel Colascione <dancol@dancol.org>
5611
5612 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5613 against is gone. It's better to use vfork now so that when Cygwin
5614 gains a new, working vfork, we use it automatically (bug#10398).
5615
de8c03dc
SM
56162012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5617
5618 * window.c (save_window_save): Obey window-point-insertion-type.
5619
2f097256
GM
56202012-04-11 Glenn Morris <rgm@gnu.org>
5621
5622 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5623
453b951e
SM
56242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5625
5626 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5627
75f1671a 56282012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5629
5630 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5631 (force_quit_count): New var.
5632 (handle_interrupt): Use it.
5633
2a8ce227
JB
56342012-04-10 Juanma Barranquero <lekktu@gmail.com>
5635
5636 * w32.c (w32_delayed_load): Record the full path of the library
5637 being loaded (bug#10424).
5638
935396c0
GM
56392012-04-09 Glenn Morris <rgm@gnu.org>
5640
05920a43
GM
5641 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5642 not just in the obarray, before snarfing them. (Bug#11036)
5643
935396c0
GM
5644 * Makefile.in ($(leimdir)/leim-list.el):
5645 Pass EMACS rather than BUILT_EMACS.
5646
a18ecafa
TZ
56472012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5648
5649 * process.c (make_process):
5650 * process.h: Add integer `gnutls_handshakes_tried' member to
5651 process struct.
5652
6bbef4e5
JC
5653 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5654 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5655
5656 * gnutls.c (gnutls_log_function2i): Convenience log function.
5657 (emacs_gnutls_read): Use new log functions,
5658 `gnutls_handshakes_tried' process member, and
5659 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5660 attempts per process (connection).
5661
b4d3bc10
CY
56622012-04-09 Chong Yidong <cyd@gnu.org>
5663
5664 * eval.c (Fuser_variable_p, user_variable_p_eh)
5665 (lisp_indirect_variable): Functions deleted.
5666 (Fdefvar): Caller changed.
5667
5668 * callint.c (Finteractive, Fcall_interactively):
5669 * minibuf.c (Fread_variable): Callers changed.
5670
70f4d973
EZ
56712012-04-09 Eli Zaretskii <eliz@gnu.org>
5672
5673 * xdisp.c (set_cursor_from_row): If the display string appears in
5674 the buffer at position that is closer to point than the position
5675 after the display string, display the cursor on the first glyph of
5676 the display string. Fixes cursor display when a 'display' text
5677 property immediately follows invisible text. (Bug#11094)
5678
cb3c2e3e
PE
56792012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 composite.c: use 'double' consistently
5682 * composite.c (get_composition_id): Use 'double' consistently
5683 instead of converting 'float' to 'double' and vice versa; this is
5684 easier to understand and avoids a GCC warning.
5685
fd06db5d
GM
56862012-04-09 Glenn Morris <rgm@gnu.org>
5687
50fe702a
GM
5688 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5689 preparation for dumping it with emacs. (Bug#4789)
5690 (leimdir): New variable.
5691 ($(leimdir)/leim-list.el): New rule.
5692 (emacs$(EXEEXT)): Depend on leim-list.el.
5693
fd06db5d
GM
5694 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5695 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5696 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5697
55c131ee
AS
56982012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5699
5700 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5701 proper alignment.
5702
9209588f
JB
57032012-04-07 Juanma Barranquero <lekktu@gmail.com>
5704
5705 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5706 Remove unused local variable.
5707
e3fb2efb
PE
57082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5711 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5712 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5713 objects, as mark_maybe_pointer will catch them otherwise.
5714 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5715 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5716
b5385551
PE
57172012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 Fix typo that broke non-Windows builds.
5720 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5721
9078ead6
EZ
57222012-04-07 Eli Zaretskii <eliz@gnu.org>
5723
5724 Support building on MS-Windows with libxml2.
5725
5726 * makefile.w32-in (OBJ2): Add xml.$(O).
5727 (GLOBAL_SOURCES): Add xml.c.
5728 ($(BLD)/xml.$(O)): New dependency list.
5729
5730 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5731 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5732 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5733 [!WINDOWSNT]: New macros.
5734 (init_libxml2_functions, libxml2_loaded_p): New functions.
5735 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5736 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5737 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5738 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5739 linked in).
6bbef4e5
JC
5740 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5741 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5742 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5743
5744 * emacs.c: Don't include libxml/parser.h.
5745 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5746 xmlCleanupParser directly.
5747
5748 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5749
3811fdf3
EZ
57502012-04-07 Eli Zaretskii <eliz@gnu.org>
5751
5752 * indent.c (Fvertical_motion): If there is a display string at
5753 point, use it.vpos to compute how many lines to backtrack after
5754 move_it_to point. (Bug#11133)
5755
2f8e16b2
EZ
57562012-04-06 Eli Zaretskii <eliz@gnu.org>
5757
5758 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5759 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5760 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5761 macros related to unification of CJK characters. For the details,
5762 see the discussion following the message here:
5763 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5764
3d439cd1
CY
57652012-04-04 Chong Yidong <cyd@gnu.org>
5766
5767 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5768
8bc53d00
EZ
57692012-04-01 Eli Zaretskii <eliz@gnu.org>
5770
5771 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5772 instead of alloca. (Bug#11138)
5773
3b0512a3
AS
57742012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5775
5776 * w32menu.c (is_simple_dialog): Properly check lisp types.
5777 (Bug#11141)
5778
8427ddd2
EZ
57792012-03-31 Eli Zaretskii <eliz@gnu.org>
5780
979022ef
EZ
5781 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5782 position we get to after a call to move_it_to fails the
5783 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5784 only if we wind up in a string from display property. (Bug#11063)
5785
a6b1c7cc
EZ
5786 * window.c (Fdelete_other_windows_internal): Invalidate the row
5787 and column information about mouse highlight, so that redisplay
5788 restores it after reallocating the glyph matrices. (Bug#7464)
5789
8427ddd2
EZ
5790 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5791 string comes from a `display' text property, use the buffer
5792 position of that property as if we actually saw that position in
5793 the row's glyphs.
697ba24b
EZ
5794 (move_it_by_lines): Remove the assertion that
5795 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5796 violated when there's a before-string at the beginning of a line.
5797 (Bug#11063)
8427ddd2 5798
65a0a738
EZ
57992012-03-30 Eli Zaretskii <eliz@gnu.org>
5800
5801 * xdisp.c (append_space_for_newline): If the default face was
5802 remapped, use the remapped face for the appended newline.
5803 (extend_face_to_end_of_line): Use the remapped default face for
5804 extending the face to the end of the line.
5805 (display_line): Call extend_face_to_end_of_line when the default
5806 face was remapped. (Bug#11068)
5807
581355cc
EZ
58082012-03-29 Eli Zaretskii <eliz@gnu.org>
5809
5810 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5811
e8fc049f
SM
58122012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5813
5814 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5815
4fb9a543
GM
58162012-03-27 Glenn Morris <rgm@gnu.org>
5817
5818 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5819 Doc fixes.
5820
679910f1
KH
58212012-03-26 Kenichi Handa <handa@m17n.org>
5822
5823 * dispextern.h (struct glyph): Fix previous change. Change the
5824 bit length of glyphless.ch to 25 (Bug#11082).
5825
90d49b7f
CY
58262012-03-26 Chong Yidong <cyd@gnu.org>
5827
5828 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5829 (command_loop_1): Use it; inhibit selection update for
5830 handle-select-window too (Bug#8996).
5831
f514f6f0
FP
58322012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5833
e8fc049f 5834 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5835
bf43fa51
KH
58362012-03-25 Kenichi Handa <handa@m17n.org>
5837
5838 * dispextern.h (struct glyph): Change the bit length of
5839 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5840
8a0c01dd
EZ
58412012-03-24 Eli Zaretskii <eliz@gnu.org>
5842
5843 * s/ms-w32.h (tzname): Include time.h before redirecting to
5844 _tzname. Fixes the MSVC build. (Bug#9960)
5845
7d1c3a76
AS
58462012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5847
8ed79523
AS
5848 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5849 characters.
5850
7d1c3a76
AS
5851 * xterm.c (XTread_socket): Only modify handling_signal if
5852 !SYNC_INPUT. (Bug#11080)
5853
e99a9b8b
EZ
58542012-03-23 Eli Zaretskii <eliz@gnu.org>
5855
5856 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5857 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5858 when fetching a multibyte character consumes more bytes than
5859 CHAR_BYTES returns, due to unification of CJK characters in
5860 string_char. (Bug#11073)
5861
5063c0e1
TN
58622012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5863
5864 * process.c (wait_reading_process_output): Handle pty disconnect
5865 by refraining from sending oneself a SIGCHLD (bug#10933).
5866
9f851fbd
CY
58672012-03-22 Chong Yidong <cyd@gnu.org>
5868
5869 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5870
5063c0e1 5871 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5872 Mark string as coming from a prefix property.
5873 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5874 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5875
fb5b8aca
CY
58762012-03-21 Chong Yidong <cyd@gnu.org>
5877
5878 * xfaces.c (Vface_remapping_alist): Doc fix.
5879
62356a1b
EZ
58802012-03-20 Eli Zaretskii <eliz@gnu.org>
5881
5882 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5883 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5884 Doc fixes.
62356a1b 5885
025de85b
CY
58862012-03-20 Chong Yidong <cyd@gnu.org>
5887
5888 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5889 to reflect default non-nil value of redisplay-dont-pause.
5890
4827f94e
KH
58912012-03-19 Kenichi Handa <handa@m17n.org>
5892
5893 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5894 it fit in a valid range (Bug#11003).
5895
e50a24a2
EZ
58962012-03-18 Eli Zaretskii <eliz@gnu.org>
5897
5898 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5899 that is not from display property, accept the row as a "cursor
5900 row" if one of the string's character has a non-nil `cursor'
5901 property. Fixes cursor positioning when there are newlines in
5902 overlay strings, e.g. in icomplete.el. (Bug#11035)
5903
9af5ed87
PE
59042012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5907
d1f55f16
CY
59082012-03-12 Chong Yidong <cyd@gnu.org>
5909
5910 * eval.c (inhibit_lisp_code): Rename from
5911 inhibit_window_configuration_change_hook; move from window.c.
5912
5913 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5914 * window.c (run_window_configuration_change_hook)
5915 (syms_of_window): Callers changed.
5916
66c5eebd
CY
59172012-03-11 Chong Yidong <cyd@gnu.org>
5918
413df973
CY
5919 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5920
66c5eebd
CY
5921 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5922
1de11f56
CY
59232012-03-10 Chong Yidong <cyd@gnu.org>
5924
5925 * frame.c (other_visible_frames): Don't assume the selected frame
5926 is visible (Bug#10955).
5927
cae07000
SM
59282012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5929
5930 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5931
89c94350
JD
59322012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5933
5934 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5935 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5936 zero (Bug#10954).
5937
999dd333
GM
59382012-03-03 Glenn Morris <rgm@gnu.org>
5939
01a6dcc8 5940 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5941
de0100f2
EZ
59422012-03-02 Eli Zaretskii <eliz@gnu.org>
5943
5944 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5945 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5946 (redisplay_window, next_element_from_string): Fix typos in
5947 comments.
3e441275
EZ
5948 (redisplay_window): Pass to move_it_vertically the margin in
5949 pixels, not in screen lines.
de0100f2 5950
96a72ee9
GM
59512012-03-02 Glenn Morris <rgm@gnu.org>
5952
5953 * buffer.c (buffer-list-update-hook): Doc fix.
5954
312508d7
EZ
59552012-02-29 Eli Zaretskii <eliz@gnu.org>
5956
5957 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5958 push_it before setting up the iterator for the first overlay
5959 string, even if we have an empty string loaded.
5960 (next_overlay_string): If there's an empty string on the iterator
5961 stack, pop the stack. (Bug#10903)
5962
27f3c637
PE
59632012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5964
5965 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5966 Suggested by Stefan Monnier in
5967 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5968 * alloc.c (widen_to_Lisp_Object): New static function.
5969 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5970 and widening them to Lisp_Objects. This would work even if
5971 USE_LSB_TAG is defined and wide integers are used, which might
5972 happen in a future version of Emacs.
5973
3c9dfce6
CY
59742012-02-25 Chong Yidong <cyd@gnu.org>
5975
fa74b241
CY
5976 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5977 Doc fix.
5978
3c9dfce6
CY
5979 * xselect.c (Fx_selection_exists_p): Doc fix.
5980 (x_clipboard_manager_save_all): Print an informative message
5981 before saving to clipboard manager.
5982
9486df08
CY
59832012-02-24 Chong Yidong <cyd@gnu.org>
5984
5985 * keyboard.c (process_special_events): Handle all X selection
5986 requests in kbd_buffer, not just the next one (Bug#8869).
5987
f01d3321
CY
59882012-02-23 Chong Yidong <cyd@gnu.org>
5989
5990 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5991 call when setting menu-bar-lines and tool-bar-lines parameters.
5992 (unwind_create_frame_1): New helper function.
5993
5994 * window.c (inhibit_window_configuration_change_hook): New var.
5995 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5996 (syms_of_window): Initialize it.
f01d3321 5997
86b847b6
CY
59982012-02-22 Chong Yidong <cyd@gnu.org>
5999
6000 * xterm.c (x_draw_image_relief): Add missing type check for
6001 Vtool_bar_button_margin (Bug#10743).
6002
a59225b1
CY
60032012-02-21 Chong Yidong <cyd@gnu.org>
6004
6005 * fileio.c (Vfile_name_handler_alist): Doc fix.
6006
6007 * buffer.c (Fget_file_buffer): Protect against invalid file
6008 handler return value.
6009
310f5bd4
PE
60102012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6011
cb3a28cc
PE
6012 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6013 when computing $valmask.
6014
310f5bd4
PE
6015 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6016 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6017 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6018 It's useless in that case, and it can cause problems on hosts
6019 that allocate halves of EMACS_INT values separately.
6020 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6021 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6022 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6023 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6024 it avoids undefined behavior on hosts where shifting right by more
6025 than the word width has undefined behavior.
6026
2375c96a
CY
60272012-02-19 Chong Yidong <cyd@gnu.org>
6028
6029 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6030 (Funhandled_file_name_directory, Ffile_name_as_directory)
6031 (Fdirectory_file_name, Fexpand_file_name)
6032 (Fsubstitute_in_file_name): Protect against invalid file handler
6033 return values (Bug#10845).
6034
3eb49e71
EZ
60352012-02-18 Eli Zaretskii <eliz@gnu.org>
6036
6037 * .gdbinit (pitx): Fix incorrect references to fields of the
6038 iterator stack.
6039
7b926f3f
CY
60402012-02-17 Chong Yidong <cyd@gnu.org>
6041
6042 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6043
11273115
PE
60442012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6047 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6048
c3a70e2b
CY
60492012-02-15 Chong Yidong <cyd@gnu.org>
6050
6051 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6052 marked as special. Also, starting docstrings with * is obsolete.
6053
0ca43699
AS
60542012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6055
6056 * gnutls.c (emacs_gnutls_write): Fix last change.
6057
2e8f3c56
LI
60582012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6059
6060 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6061 send_process.
6062
af70074f
SM
60632012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6064
6065 * keymap.c (Fsingle_key_description): Handle char ranges.
6066
95986d52
CY
60672012-02-12 Chong Yidong <cyd@gnu.org>
6068
afd83bd1
CY
6069 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6070 as that creates a dangerous corner case.
6071
95986d52
CY
6072 * window.c (Fdelete_window_internal): Invalidate the mouse
6073 highlight (Bug#9904).
6074
bd7da63e
GM
60752012-02-12 Glenn Morris <rgm@gnu.org>
6076
6077 * xselect.c (Fx_own_selection_internal)
6078 (Fx_get_selection_internal, Fx_disown_selection_internal)
6079 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6080 * nsselect.m (Fx_own_selection_internal)
6081 (Fx_disown_selection_internal, Fx_selection_exists_p)
6082 (Fx_selection_owner_p, Fx_get_selection_internal):
6083 Sync docs and argument specs with the xselect.c versions.
6084
77abcbc2
LI
60852012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6086
6087 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6088
90b671e2
EZ
60892012-02-11 Eli Zaretskii <eliz@gnu.org>
6090
1c0ca0b7
EZ
6091 * w32select.c (Fx_selection_exists_p): Sync doc string and
6092 argument list with xselect.c. (Bug#10783)
6093
6094 * w16select.c (Fx_selection_exists_p): Sync doc string and
6095 argument list with xselect.c. (Bug#10783)
90b671e2 6096
49241268
GM
60972012-02-10 Glenn Morris <rgm@gnu.org>
6098
6099 * fns.c (Fsecure_hash): Doc fix.
6100
f998bbe7 61012012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6102
6103 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6104
0992bd9c
CY
61052012-02-07 Chong Yidong <cyd@gnu.org>
6106
6107 * buffer.c (Fbuffer_local_variables)
6108 (buffer_lisp_local_variables): Handle unbound vars correctly;
6109 don't let Qunbound leak into Lisp.
6110
af008560
GM
61112012-02-07 Glenn Morris <rgm@gnu.org>
6112
dd605cc4
GM
6113 * image.c (Fimagemagick_types): Doc fix.
6114
af008560
GM
6115 * image.c (imagemagick-render-type): Change it from a lisp object
6116 to an integer. Move the doc here from the lisp manual.
6117 Treat all values not equal to 0 the same.
6118
1449fa1d
CY
61192012-02-06 Chong Yidong <cyd@gnu.org>
6120
6121 * doc.c (store_function_docstring): Avoid applying docstring of
6122 alias to base function (Bug#2603).
6123
3723ec07
AS
61242012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6125
6126 * .gdbinit (pp1, pv1): Remove redundant defines.
6127 (pr): Use pp.
6128
79c1cc1e
CY
61292012-02-04 Chong Yidong <cyd@gnu.org>
6130
6131 * nsterm.m: Declare a global (Bug#10694).
6132
d7f29f8e
EZ
61332012-02-04 Eli Zaretskii <eliz@gnu.org>
6134
cae07000
SM
6135 * w32.c (get_emacs_configuration_options):
6136 Include --enable-checking, if specified, in the return value.
d7f29f8e 6137
3b95a6f9
MR
61382012-02-04 Martin Rudalics <rudalics@gmx.at>
6139
6140 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6141 after rounding frame sizes. (Bug#9723)
6142
d6fa96a6
EZ
61432012-02-04 Eli Zaretskii <eliz@gnu.org>
6144
6145 * keyboard.c (adjust_point_for_property): Don't position point
6146 before BEGV. (Bug#10696)
6147
df0b2940
PE
61482012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6149
6150 Handle overflow when computing char display width (Bug#9496).
6151 * character.c (char_width): Return EMACS_INT, not int.
6152 (char_width, c_string_width): Check for overflow when
6153 computing the width; this is possible now that individual
6154 characters can have unbounded width. Problem introduced
6155 by merge from Emacs 23 on 2012-01-19.
6156
6bee44d6
MA
61572012-02-02 Michael Albinus <michael.albinus@gmx.de>
6158
6159 * dbusbind.c (Fdbus_register_method): Mention the return value
6160 :ignore in the docstring.
6161
44f92739
GM
61622012-02-02 Glenn Morris <rgm@gnu.org>
6163
1b9f60cc
GM
6164 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6165
44f92739
GM
6166 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6167 Unconditionally set to t. (Bug#10673)
6168 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6169 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6170 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6171
c5d3843c
KH
61722012-02-02 Kenichi Handa <handa@m17n.org>
6173
6174 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6175 0, do not call append_composite_glyph.
6176
159462d4 61772012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6178
6179 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6180 NULL (Bug#6988).
6181 (x_produce_glyphs): If the component of a composition is a null
6182 string, set it->pixel_width to 1 to avoid zero-width glyph.
6183
78cef877
EZ
61842012-02-01 Eli Zaretskii <eliz@gnu.org>
6185
6186 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6187 first 2 arguments are identical. This makes inserting large
6188 output from a subprocess an order of magnitude faster on
6189 MS-Windows, where all sbrk'ed memory is always contiguous.
6190
97897668
GM
61912012-01-31 Glenn Morris <rgm@gnu.org>
6192
6193 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6194 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6195 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6196
31fd3586
GM
61972012-01-29 Glenn Morris <rgm@gnu.org>
6198
6199 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6200
0e24a8b2
CY
62012012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6202
6203 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6204
cc0adcb0
CY
62052012-01-28 Chong Yidong <cyd@gnu.org>
6206
6207 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6208
acc28cb9
CY
62092012-01-26 Chong Yidong <cyd@gnu.org>
6210
9c69cfb7
CY
6211 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6212
acc28cb9
CY
6213 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6214 repeat counts (Bug#10507).
6215
48da7392
GM
62162012-01-26 Glenn Morris <rgm@gnu.org>
6217
6218 * lread.c (syms_of_lread): Doc fix.
6219
14af5f7f
CY
62202012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6221
6222 * coding.c (encode_designation_at_bol): Change return value to
6223 EMACS_INT.
6224
0b21c100
CY
62252012-01-25 Chong Yidong <cyd@gnu.org>
6226
6227 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6228
3c2907f7
CY
62292012-01-21 Chong Yidong <cyd@gnu.org>
6230
6231 * floatfns.c (Fcopysign): Make the second argument non-optional,
6232 since nil is not allowed anyway.
6233
959ad23f
AS
62342012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6235
6236 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6237 (send_process): Likewise.
6238
34a02f46
MR
62392012-01-19 Martin Rudalics <rudalics@gmx.at>
6240
6241 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6242 (Vwindow_persistent_parameters): Do not use Qstate.
6243 Rewrite doc-strings.
34a02f46 6244
1259009a 62452012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6246
6247 * character.c (char_width): New function.
70d4fdf6
GM
6248 (Fchar_width, c_string_width, lisp_string_width):
6249 Use char_width (Bug#9496).
25ed9e61 6250
6a6ee00d
MR
62512012-01-16 Martin Rudalics <rudalics@gmx.at>
6252
6253 * window.c (Vwindow_persistent_parameters): New variable.
6254 (Fset_window_configuration, save_window_save): Handle persistent
6255 window parameters.
6256
c85efaf7
EZ
62572012-01-14 Eli Zaretskii <eliz@gnu.org>
6258
6259 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6260 thrashing the stack of the thread. (Bug#9087)
6261
5944709e
PE
62622012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6263
6264 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6265
e71f5d99
EZ
62662012-01-11 Eli Zaretskii <eliz@gnu.org>
6267
6268 * xdisp.c (rows_from_pos_range): Handle the case where the
6269 highlight ends on a newline. (Bug#10464)
6270 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6271 he end column for display of highlight that ends on a newline
6272 before a R2L line.
6273
ce316182
GM
62742012-01-11 Glenn Morris <rgm@gnu.org>
6275
6276 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6277 from load-path also when installation-directory is nil. (Bug#10208)
6278
5b43da69
GM
62792012-01-10 Glenn Morris <rgm@gnu.org>
6280
74cc8ff9
GM
6281 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6282
7d8d6e4e
GM
6283 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6284 Update template values to be closer to their typical values these days.
5b43da69 6285
a0db8d43
EZ
62862012-01-09 Eli Zaretskii <eliz@gnu.org>
6287
6288 * xdisp.c (rows_from_pos_range): Accept additional argument
6289 DISP_STRING, and accept any glyph in a row whose object is that
6290 string as eligible for mouse highlight. Fixes mouse highlight of
6291 display strings from overlays. (Bug#10464)
6292
9a0115ab 62932012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6294
b9110d6a 6295 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6296 * fileio.c (auto_saving_dir_umask): New static var.
6297 (Fmake_directory_internal): Use it.
6298 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6299 creating the directory. The old code temporarily assigns
6300 too-generous permissions to the directory.
6301 (do_auto_save_eh): Clear it.
b9110d6a 6302 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6303 that the var is always cleared.
6304
6c1bd3f3
EZ
63052012-01-07 Eli Zaretskii <eliz@gnu.org>
6306
6307 * search.c (scan_buffer): Pass character positions to
6308 know_region_cache, not byte positions. (Bug#6540)
6309
069d2b50
L
63102012-01-07 LynX <_LynX@bk.ru> (tiny change)
6311
6312 * w32.c (sys_rename): Report EXDEV when rename of a directory
6313 fails because the target is on another logical disk. (Bug#10284)
6314
75bf0d33
DB
63152012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6316
6317 * xterm.c (x_embed_request_focus): New function.
6318
6319 * xterm.h: Add prototype.
6320
6321 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6322
1c6e5a32
GM
63232012-01-05 Glenn Morris <rgm@gnu.org>
6324
6325 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6326
651e947e
EZ
63272012-01-01 Eli Zaretskii <eliz@gnu.org>
6328
6329 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6330 Load gnutls_transport_set_lowat only if GnuTLS version is below
6331 2.11.1.
6332 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6333 GnuTLS versions below 2.11.1.
6334
3778cdd8
AL
63352011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6336
6337 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6338 to the doc string advising against its use for altering the way
6339 windows are scrolled.
6340
0e5317f7
KH
63412011-12-28 Kenichi Handa <handa@m17n.org>
6342
6343 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6344 coding-system ASCII compatible only when it does not produce BOM
6345 on encoding (Bug#10383).
6346
93d5ca1f
JD
63472011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6348
6349 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6350 can scroll.
6351 (create_and_show_popup_menu): Always use menu_position_func for
6352 Gtk3 (Bug#10361).
6353
ca22b785
AS
63542011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6355
6356 * callint.c (Fcall_interactively): Don't truncate prompt string.
6357
d048e1e6
EZ
63582011-12-23 Eli Zaretskii <eliz@gnu.org>
6359
6360 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6361 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6362 resumed from there (after widening). (Bug#10360)
d048e1e6 6363
5ccaba1f
JD
63642011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6365
6366 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6367
204ee57f
JD
63682011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6369
b81d40f0
JB
6370 * nsterm.m (x_free_frame_resources):
6371 Release f->output_data.ns->miniimage.
204ee57f
JD
6372 (ns_index_color): Fix indentation. Do not retain
6373 color_table->colors[i].
6374
6375 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6376 before returning.
6377
6378 * nsfns.m (x_set_background_color): Assign return value from
6379 ns_index_color to face-background instead of NSColor*.
6380 (ns_implicitly_set_icon_type): Fix indentation.
6381 Change assignment in for loop to comparison.
6382
6383 * emacs.c (ns_pool): New variable.
6384 (main): Assign ns_pool.
6385 (Fkill_emacs): Call ns_release_autorelease_pool.
6386
6387 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6388 autorelease fdesc, release fdAttrs and tdict.
6389 (ns_get_covering_families): Release charset.
6390 (ns_findfonts): Release NSFontDescriptor created with new.
6391 (ns_uni_to_glyphs): Fix indentation.
6392 (setString): Release attrStr before assigning new value.
6393
c803b2b7
JD
63942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6395
678f4426
JD
6396 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6397 and NS_IMPL_COCOA.
6398 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6399 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6400
cd394be1 64012011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6402
5fecd5fc
JD
6403 * nsterm.m (ns_term_init): Subscribe for notifications
6404 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6405 to method trackingNotification in EmacsMenu.
6406
6407 * nsmenu.m (trackingMenu): New variable.
3771cb17 6408 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6409 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6410 from Aquamacs (Bug#7030).
678f4426
JD
6411
64122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6413
c803b2b7
JD
6414 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6415 (symbol_to_nsstring): Fix indentation.
6416 (ns_symbol_to_pb): New function.
cae07000
SM
6417 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6418 (Fns_rotate_cut_buffers_internal): Remove.
6419 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6420 Fns_store_cut_buffer_internal.
6421 (ns_get_foreign_selection, Fx_own_selection_internal)
6422 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6423 (Fns_get_selection_internal, Fns_store_selection_internal):
6424 Use ns_symbol_to_pb and check if return value is nil.
6425 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6426 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6427 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6428 renamed to Sns_store_selection_internal.
6429 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6430 and remove this function.
6431 (ns_handle_selection_clear): Remove, never used.
6432 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6433 here.
6434
e1b01a3a
KB
64352011-12-17 Ken Brown <kbrown@cornell.edu>
6436
6437 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6438 GID is unknown (Bug#10257).
6439
2adb6e85
PE
64402011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6441
6442 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6443 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6444 which caused a build failure on GNU/Linux IA-64. This problem was
6445 introduced by my 2011-10-07 patch.
6446
d1d7b339
JL
64472011-12-15 Juri Linkov <juri@jurta.org>
6448
6449 * image.c (imagemagick_error): New function. (Bug#10112)
6450 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6451 Use `imagemagick_error' where ImageMagick functions return
6452 `MagickFalse'.
6453 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6454 proper order.
6455
100d5755
KH
64562011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6457
6458 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6459 fill background (Bug#8992).
6460
454592a6
MR
64612011-12-13 Martin Rudalics <rudalics@gmx.at>
6462
6463 * window.c (Vwindow_combination_resize)
6464 (Vwindow_combination_limit): Use t instead of non-nil in
6465 doc-strings.
61d4b438
MR
6466 (Vrecenter_redisplay): Add first sentence of doc-string on
6467 separate line.
53524d93 6468 (Frecenter): Fix doc-string typo.
454592a6 6469
3633e3aa
KH
64702011-12-11 Kenichi Handa <handa@m17n.org>
6471
6472 * coding.c (Funencodable_char_position): Pay attention to the
6473 buffer text relocation (Bug#9389).
6474
7b9d523a 64752011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6476
7b9d523a
JD
6477 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6478 gtk_init (Bug#10100).
6479
b73189c6
EZ
64802011-12-10 Eli Zaretskii <eliz@gnu.org>
6481
6482 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6483 IT->string is nil. (Bug#10263)
6484
f7dfe5d6
JD
64852011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6486
83faebb4
JD
6487 * nsterm.h (x_free_frame_resources): Declare.
6488
f7dfe5d6
JD
6489 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6490 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6491
6492 * nsterm.h (ns_get_defaults_value): Declare.
6493
6494 * nsterm.m (ns_default): Call ns_get_defaults_value.
6495
7cd4e72c
EZ
64962011-12-09 Eli Zaretskii <eliz@gnu.org>
6497
6498 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6499 (Bug#10170)
6500
b34d7317
YM
65012011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6502
6503 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6504 that where the value of an _OBJC_* symbol points to is in the .bss
6505 section (Bug#10240).
6506
76470ad1
KH
65072011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6508
6509 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6510 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6511
745fff94
KH
65122011-12-08 Kenichi Handa <handa@m17n.org>
6513
6514 * ftfont.c (get_adstyle_property): Fix previous change
6515 (Bug#10233).
6516
6e44397c
JB
65172011-12-07 Juanma Barranquero <lekktu@gmail.com>
6518
6519 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6520 dirs from the default value of EMACSLOADPATH (bug#10208).
6521
7efa6272
GM
65222011-12-07 Glenn Morris <rgm@gnu.org>
6523
6524 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6525 installation and source directories as well. (Bug#10208)
6526
f6fc4d87
CY
65272011-12-06 Chong Yidong <cyd@gnu.org>
6528
6529 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6530
2bf26180
GM
65312011-12-06 Glenn Morris <rgm@gnu.org>
6532
6533 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6534 as an error, not just -1. (Bug#10217)
6535
3a6ad4f0
CY
65362011-12-05 Chong Yidong <cyd@gnu.org>
6537
6538 * keyboard.c (process_special_events): New function.
6539 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6540
75a3b399
PE
65412011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * coding.c (encode_designation_at_bol): Don't use uninitialized
6544 local variable (Bug#9318).
6545
c3c9e25e
KH
65462011-12-05 Kenichi Handa <handa@m17n.org>
6547
6548 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6549 return Qnil (Bug#8046, Bug#10193).
6550
5eb05ea3
KH
65512011-12-05 Kenichi Handa <handa@m17n.org>
6552
6553 * coding.c (encode_designation_at_bol): New args charbuf_end and
6554 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6555 (coding_set_source): Return how many bytes coding->source was
6556 relocated.
6557 (coding_set_destination): Return how many bytes
6558 coding->destination was relocated.
6559 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6560 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6561
65622011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6563
6564 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6565 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6566 macro (Bug#9318).
6567
65682011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6569
6570 The following changes are to fix Bug#9318.
6571
a79703f5 6572 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6573 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6574 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6575 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6576
7dbda6df
JB
65772011-12-05 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * lisp.h (process_quit_flag): Fix external declaration.
6580
6d5eb5b0
SM
65812011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6582
6583 Don't macro-inline non-performance-critical code.
6584 * eval.c (process_quit_flag): New function.
6585 * lisp.h (QUIT): Use it.
6586
a0c3fad0
JD
65872011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6588
6589 * nsfns.m (get_geometry_from_preferences): New function.
6590 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6591
6c07aac2
AS
65922011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6593
6594 * emacs.c (Qkill_emacs): Define.
6595 (syms_of_emacs): Initialize it.
6596 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6597 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6598 (quit_throw_to_read_char): Add parameter `from_signal'.
6599 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6600 * lisp.h (QUIT): Call Fkill_emacs if requested.
6601
c052ead4
JD
66022011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6603
6604 * widget.c (update_wm_hints): Return if wmshell is null.
6605 (widget_update_wm_size_hints): New function.
6606
6607 * widget.h (widget_update_wm_size_hints): Declare.
6608
6609 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6610 widget_update_wm_size_hints (Bug#10104).
6611
9e49252b
EZ
66122011-12-03 Eli Zaretskii <eliz@gnu.org>
6613
6614 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6615 before a newline, prepare the bidi iterator for consuming the
6616 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6617 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6618
02b16839
JL
66192011-12-02 Juri Linkov <juri@jurta.org>
6620
6621 * search.c (Fword_search_regexp): New Lisp function created from
6622 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6623 (Fword_search_backward, Fword_search_forward)
6624 (Fword_search_backward_lax, Fword_search_forward_lax):
6625 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6626 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6627
0068070e
SM
66282011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6629
6630 * fileio.c (Finsert_file_contents): Move after-change-function call
6631 to before the "handled:" label, since all "goto handled" appear in
6632 cases where the *-change-functions have already been properly called
6633 (bug#10117).
6634
3360a3fc
AS
66352011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6636
6637 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6638 waiting for input. (Bug#10169)
6639
73d6c093
EZ
66402011-11-30 Eli Zaretskii <eliz@gnu.org>
6641
6642 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6643 verifies glyph row's hash code--we have just reallocated the
6644 glyphs, so their contents can be complete garbage. (Bug#10164)
6645
febe6bea
JB
66462011-11-30 Juanma Barranquero <lekktu@gmail.com>
6647
6648 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6649
801a4313
EZ
66502011-11-30 Eli Zaretskii <eliz@gnu.org>
6651
6652 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6653 attributes are tested _before_ calling verify_row_hash, to protect
6654 against GCC re-ordering of the tests. (Bug#10164)
6655
2b56b87e
JD
66562011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6657
6658 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6659
6660 * xterm.c (handle_one_xevent): Only set async_visible and friends
6661 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6662 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6663 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6664
dbf31225
PE
66652011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6668 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6669 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6670 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6671 All uses changed to use GCPRO1 etc.
6672 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6673 Revert to old implementation (i.e., before 2011-03-11).
6674
1305621b
YM
66752011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6676
6677 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6678 of scroll runs so as to avoid assigning disabled bogus rows and
6679 unnecessary graphics copy operations.
6680
8c9afb46
EZ
66812011-11-27 Eli Zaretskii <eliz@gnu.org>
6682
6683 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6684 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6685 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6686 (malloc, free, realloc, calloc): Redirect to e_* only when
6687 compiling Emacs.
6688
6689 * lisp.h (GCTYPEBITS): Move before first use.
6690 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6691 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6692 this macro definition.
6693
6694 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6695 _MSC_VER.
6696
54e9e3bf
JD
66972011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6698
6d5eb5b0
SM
6699 * gtkutil.c (xg_create_frame_widgets):
6700 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6701 present with Gtk+ 2.0.
6702
83aca1cb
PE
67032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6704
6705 * fileio.c (Finsert_file_contents): Undo previous change; see
6706 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6707
5b76caa4
PE
67082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6709
6710 Rename locals to avoid shadowing.
6711 * fileio.c (Finsert_file_contents):
6712 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6713 * process.c (wait_reading_process_output):
6714 Rename inner 'proc' to 'p' to avoid shadowing.
6715 Indent for consistency with usual Emacs style.
6716
8c535114
EZ
67172011-11-25 Eli Zaretskii <eliz@gnu.org>
6718
6719 * xdisp.c (redisplay_window): If cursor row is not fully visible
6720 after recentering, and scroll-conservatively is set to a large
6721 number, scroll window by a few more lines to make the cursor fully
6722 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6723 (start_display): Don't move to the next line if the display should
6724 start at a newline that is part of a display vector or an overlay
6725 string. (Bug#10119)
8c535114 6726
fa4fdb5c
JL
67272011-11-24 Juri Linkov <juri@jurta.org>
6728
6729 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6730 after the `MagickPingImage' call. (Bug#10112)
6731
90ec88df
CY
67322011-11-23 Chong Yidong <cyd@gnu.org>
6733
6734 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6735
56e2e794
MR
67362011-11-23 Martin Rudalics <rudalics@gmx.at>
6737
6738 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6739 making another buffer current. (Bug#10114)
6740
b6e64c41
GM
67412011-11-23 Glenn Morris <rgm@gnu.org>
6742
6743 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6744
6b21de18
CY
67452011-11-23 Chong Yidong <cyd@gnu.org>
6746
6747 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6748 using it (Bug#5984).
6749
b12cd789
EZ
67502011-11-22 Eli Zaretskii <eliz@gnu.org>
6751
6752 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6753 and header-lines, as they don't have one computed for them.
6754 (Bug#10098)
6755
6756 * .gdbinit (prow): Make displayed values more self-explaining.
6757 Add row's hash code.
6758
261b6fd4
LMI
67592011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6760
6761 * process.c (wait_reading_process_output): Fix asynchrounous
6762 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6763 (wait_reading_process_output): Add comment and URL.
261b6fd4 6764
e7cfd277
JD
67652011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6766
6767 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6768
a9b9b7f5
CY
67692011-11-21 Chong Yidong <cyd@gnu.org>
6770
6771 * window.c (Fnext_window, Fprevious_window): Doc fix.
6772
b0d15b4f
SM
67732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6774
6775 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6776
fe7a3057
JB
67772011-11-20 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6780
d2999b1a
MR
67812011-11-20 Martin Rudalics <rudalics@gmx.at>
6782
6783 * window.c (Fset_window_combination_limit): Rename argument
6784 STATUS to LIMIT.
6785 (Vwindow_combination_limit): Remove "status" from doc-string.
6786
d5ff9cd0
AS
67872011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6788
6789 * m/ibms390.h: Remove.
6790 * m/ibms390x.h: Don't include "ibms390.h".
6791
a5bb9bd3
SM
67922011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6793
6794 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6795 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6796
cd1181db
JB
67972011-11-20 Juanma Barranquero <lekktu@gmail.com>
6798
6799 * casetab.c (Fset_case_table):
6800 * charset.c (Fcharset_after): Fix typos.
6801
615a3b8d 68022011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6803
17e845af
PE
6804 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6805 Otherwise, valgrind does not work on some platforms.
6806 Problem reported by Andreas Schwab in
6a0bf43d
PE
6807 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6808 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6809 is set, removing the need for VIRT_ADDRESS_VARIES.
6810 (PURE_P): Use a more-efficient implementation that needs just one
6811 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6812 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6813 to 4 (xorl, subq, cmpq, setbe).
6814 * alloc.c (pure): Always extern now, since that's the
6815 VIRT_ADDR_VARIES behavior.
6816 (PURE_POINTER_P): Use a single comparison, not two, for
6817 consistency with the new puresize.h.
6818 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6819 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6820 Remove VIRT_ADDR_VARIES no longer needed.
6821
f8fe6f96
EZ
68222011-11-19 Eli Zaretskii <eliz@gnu.org>
6823
6824 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6825 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6826 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6827 behave as if the cursor position were at the window margin.
6828
6829 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6830 and the cursor position is out of bounds, behave as if the cursor
6831 position were at the window margin. (Bug#10075)
6832
df05a53c
CY
68332011-11-18 Chong Yidong <cyd@gnu.org>
6834
6835 * window.c (Fwindow_combination_limit): Make first argument
6836 non-optional, since it is meaningless for live windows like the
6837 selected window.
61ccba97 6838
2071918e
DA
68392011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6840
6841 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6842
b50a28de
SM
68432011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6844
6845 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6846 (graft_intervals_into_buffer): Simplify.
6847
015137db
EZ
68482011-11-18 Eli Zaretskii <eliz@gnu.org>
6849
6850 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6851 hash values of the two rows.
6852 (copy_row_except_pointers): Preserve the used[] arrays and the
6853 hash values of the two rows. (Bug#10035)
68c95424 6854 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6855
6856 * xdisp.c (row_hash): New function, body extracted from
6857 compute_line_metrics.
6858 (compute_line_metrics): Call row_hash, instead of computing the
6859 hash code inline.
6860
6861 * dispnew.c (verify_row_hash): Call row_hash for computing the
6862 hash code of a row, instead of duplicating code from xdisp.c.
6863
6864 * dispextern.h (row_hash): Add prototype.
6865
a2addb04
TH
68662011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6867
6868 * frame.c (delete_frame): Don't delete the terminal when the last
6869 X frame is closed if emacs is built with GTK toolkit.
6870
df85d315
JB
68712011-11-17 Juanma Barranquero <lekktu@gmail.com>
6872
6873 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6874
a0c2d0ae
MR
68752011-11-17 Martin Rudalics <rudalics@gmx.at>
6876
6877 * window.c (Vwindow_splits): Rename to
6878 Vwindow_combination_resize. Suggested by Juri Linkov.
6879 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6880 of Vwindow_splits.
6881
58179cce
JB
68822011-11-16 Juanma Barranquero <lekktu@gmail.com>
6883
7877f373
JB
6884 * nsfns.m (Fns_font_name):
6885 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6886
b6f67890
MR
68872011-11-16 Martin Rudalics <rudalics@gmx.at>
6888
6889 * window.h (window): Rename slot "nest" to "combination_limit".
6890 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6891 (Fset_window_nest): Rename to Fset_window_combination_limit.
6892 (Vwindow_nest): Rename to Vwindow_combination_limit.
6893 (recombine_windows, make_parent_window, make_window)
6894 (Fsplit_window_internal, saved_window)
6895 (Fset_window_configuration, save_window_save): Rename all
6896 occurrences of window_nest to window_combination_limit.
6897
c7015153
JB
68982011-11-15 Juanma Barranquero <lekktu@gmail.com>
6899
6900 * image.c (imagemagick_load_image): Fix typo.
6901
322ad6ec
EZ
69022011-11-14 Eli Zaretskii <eliz@gnu.org>
6903
6904 * xdisp.c (display_line): Move the call to
6905 highlight_trailing_whitespace before the call to
6906 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6907 faces of all the glyphs to compute ROW's hash value.
6908 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6909
f067b8ec
JB
69102011-11-14 Juanma Barranquero <lekktu@gmail.com>
6911
6912 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6913 just return (bug#10044).
6914
1e5b2111
EZ
69152011-11-12 Eli Zaretskii <eliz@gnu.org>
6916
7ef3cbd5
EZ
6917 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6918 with user-defined heap size. Bump the default size of the temacs
6919 heap to 27MB, to avoid memory warning when running temacs.
6920 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6921
1e5b2111
EZ
6922 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6923 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6924 (verify_row_hash) [XASSERTS]: New function.
6925 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6926 that the hash value of glyph rows is correct.
1e5b2111 6927
89d61221
MR
69282011-11-12 Martin Rudalics <rudalics@gmx.at>
6929
6930 * window.h (window): Remove splits slot.
6931 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6932 (Fdelete_other_windows_internal, make_parent_window)
6933 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6934 (Fset_window_configuration, save_window_save): Don't deal with
6935 split status of windows.
6936 (saved_window): Remove splits slot.
6937 (Vwindow_splits): Rewrite doc-string.
6938
97f18cc8
JD
69392011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6940
6941 * xfns.c (unwind_create_frame):
6942 * nsfns.m (unwind_create_frame):
6943 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6944 Vframe_list (Bug#9999).
6945
22a648b4
DA
69462011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6947
0b381c7e 6948 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6949
659afede
KH
69502011-11-11 Kenichi Handa <handa@m17n.org>
6951
6952 * callproc.c (Fcall_process): Set the member dst_multibyte of
6953 process_coding.
6954
9ac0394b
KH
69552011-11-11 Johan Bockgård <bojohan@gnu.org>
6956
6957 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6958 avoid a crash (bug#9496).
6959
2fbdc249
CY
69602011-11-09 Chong Yidong <cyd@gnu.org>
6961
6962 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6963 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6964
ac6b1f81
PE
69652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6968
09db192c
PE
69692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6970
6971 Avoid some portability problems by eschewing 'extern inline' functions.
6972 The trivial performance wins aren't worth the portability hassles; see
6973 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6974 et seq.
6975 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6976 (window_box_width, window_box_left, window_box_left_offset)
6977 (window_box_right, window_box_right_offset): Undo previous change,
6978 by removing the "extern"s.
6979 * intervals.c (adjust_intervals_for_insertion)
6980 (adjust_intervals_for_deletion): Undo previous change,
6981 making these static again.
6982 (offset_intervals, temp_set_point_both, temp_set_point)
6983 (copy_intervals_to_string): No longer inline.
6984 * xdisp.c (window_text_bottom_y, window_box_width)
6985 (window_box_height, window_box_left_offset)
6986 (window_box_right_offset, window_box_left, window_box_right)
6987 (window_box): No longer inline.
6988
105216ed
CY
69892011-11-08 Chong Yidong <cyd@gnu.org>
6990
6991 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6992 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6993 Signal an error if not a live window.
105216ed
CY
6994 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6995 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6996
ae9e237f
JB
69972011-11-07 Juanma Barranquero <lekktu@gmail.com>
6998
6999 * lisp.h (syms_of_abbrev): Remove declaration.
7000 Reported by CHENG Gao <chenggao@royau.me>.
7001
c7aa8333
EZ
70022011-11-07 Eli Zaretskii <eliz@gnu.org>
7003
7004 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7005 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7006 of temacs in GUI mode.
7007
be7f5545
MR
70082011-11-07 Martin Rudalics <rudalics@gmx.at>
7009
7010 * window.h: Declare delete_all_child_windows instead of
7011 delete_all_subwindows.
7012 * window.c (Fwindow_nest, Fset_window_nest)
7013 (Fset_window_new_total, Fset_window_new_normal)
7014 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7015 (delete_all_subwindows): Rename to delete_all_child_windows.
7016 (Fdelete_other_windows_internal, Fset_window_configuration):
7017 Call delete_all_child_windows instead of delete_all_subwindows.
7018 * frame.c (delete_frame): Call delete_all_child_windows instead
7019 of delete_all_subwindows.
7020
ca78dc43
PE
70212011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7022
7023 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7024 This is also needed for porting to any host where GC_MARK_STACK is
7025 not GC_MAKE_GCPROS_NOOPS.
7026 (which_symbols): Use it.
7027
a0241d01
KH
70282011-11-07 Kenichi Handa <handa@m17n.org>
7029
7030 * coding.c (coding_set_destination): Check coding->src_pos only
7031 when coding->src_object is a buffer (bug#9910).
7032
7033 * process.c (send_process): Set the member src_multibyte of coding
7034 to 0 (bug#9911) when sending a unibyte text.
7035
7036 * callproc.c (Fcall_process): Set the member src_multibyte of
7037 process_coding to 0 (bug#9912).
7038
a64bfdfa 70392011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7040
7041 * xmenu.c (cleanup_widget_value_tree): New function.
7042 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7043 calling free_menubar_widget_value_tree directly (Bug#9830).
7044
cb41b32a
PE
70452011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7046
7047 Fix some portability problems with 'inline'.
7048 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7049 (window_box_width, window_box_left, window_box_left_offset)
7050 (window_box_right, window_box_right_offset): Declare extern.
7051 Otherwise, these inline functions do not conform to C99 and
7052 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7053 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7054 * intervals.c (adjust_intervals_for_insertion)
7055 (adjust_intervals_for_deletion): Now extern, because otherwise the
7056 extern inline functions 'offset_intervals' couldn't refer to it.
7057 (static_offset_intervals): Remove.
7058 (offset_intervals): Rewrite using the old contents of
7059 static_offset_intervals. The old version didn't conform to C99
7060 because an extern inline function contained a reference to an
7061 identifier with static linkage.
7062
b7041366
AS
70632011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7064
7065 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7066 GC.
7067
88a37c4d
EZ
70682011-11-06 Eli Zaretskii <eliz@gnu.org>
7069
7070 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7071 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7072 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7073 return Qleft_to_right.
7074
49745b39
CY
70752011-11-06 Chong Yidong <cyd@gnu.org>
7076
7077 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7078 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7079 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7080 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7081 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7082 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7083 (Fwindow_vscroll): Doc fix.
7084 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7085 argument, since it makes no sense to pass a live window and for
7086 consistency with window-child.
7087
1f05cd82
CS
70882011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7089
7090 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7091 support MSVC.
7092
22610910
JR
70932011-11-05 Jason Rumney <jasonr@gnu.org>
7094
7095 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7096 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7097 fonts (Bug#6029).
7098 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7099 bitwise arithmetic preventing use of unicode-sip and non-truetype
7100 opentype fonts.
7101
a06776b2
EZ
71022011-11-05 Eli Zaretskii <eliz@gnu.org>
7103
3ad924ba
EZ
7104 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7105 "emacs"-only part.
7106
a06776b2
EZ
7107 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7108 initialization code to keep similarity to xfns.c after changes
7109 from 2011-11-05.
7110
c9e7db78
JD
71112011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7112
a97f8f3f
JD
7113 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7114 (unwind_create_frame): New function (Bug#9943).
7115 (Fx_create_frame): Restructure code to be more similar to the one in
7116 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7117 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7118 Move terminal->reference_count++ just before making the frame official
7119 (Bug#9943).
7120
7121 * nsterm.m (x_free_frame_resources): New function.
7122 (x_destroy_window): Move code to x_free_frame_resources.
7123
c9e7db78 7124 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7125 (Fx_create_frame, x_create_tip_frame):
7126 Move terminal->reference_count++ just before making the frame
75f1671a 7127 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7128 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7129
a6fc3b5c
EZ
71302011-11-05 Eli Zaretskii <eliz@gnu.org>
7131
7132 Support MSVC build with newer versions of Visual Studio.
7133 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7134 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7135 nt/gmake.defs.
7136
7137 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7138 which are not supported by MSVC.
7139 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7140 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7141 bitfields.
7142 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7143 types in bitfields.
7144 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7145
7146 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7147
58179cce 71482011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7149
7150 Support MSVC build with newer versions of Visual Studio.
7151 * w32.c: Don't include w32api.h for MSVC.
7152 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7153
7154 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7155 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7156 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7157 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7158 e_* cousins.
7159 (alloca) [_MSC_VER]: Define to _alloca.
7160
7161 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7162
7163 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7164
a58c13ed
EZ
71652011-11-04 Eli Zaretskii <eliz@gnu.org>
7166
7167 * xdisp.c (note_mouse_highlight): If either of
7168 previous/next-single-property-change returns nil, treat that as
7169 the beginning or the end of the buffer. (Bug#9955)
7170
fe0b6370
JD
71712011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7172
a58c13ed 7173 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7174 label is not null (Bug#9951).
7175 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7176 may be NULL.
7177
89bd5ee1
EZ
71782011-11-04 Eli Zaretskii <eliz@gnu.org>
7179
7180 * window.c (Fwindow_body_size): Mention in the doc string that the
7181 return value is in frame's canonical units. (Bug#9949)
7182
84c3edb9
EZ
71832011-11-03 Eli Zaretskii <eliz@gnu.org>
7184
4e2fb5c7
EZ
7185 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7186
84c3edb9 7187 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7188 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7189 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7190
bc17a887
EZ
71912011-11-01 Eli Zaretskii <eliz@gnu.org>
7192
7193 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7194 Don't stop backward scan on the continuation glyph, even though
7195 its CHARPOS is positive.
6d5eb5b0
SM
7196 (mouse_face_from_buffer_pos, note_mouse_highlight):
7197 Rename cover_string to disp_string.
bc17a887 7198
4ee88440
MR
71992011-11-01 Martin Rudalics <rudalics@gmx.at>
7200
7201 * window.c (temp_output_buffer_show): Don't use
7202 Vtemp_buffer_show_specifiers.
7203 (Vtemp_buffer_show_specifiers): Remove unused variable.
7204
c2ff3c02
EZ
72052011-10-30 Eli Zaretskii <eliz@gnu.org>
7206
7207 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7208 past the beginning of the current glyph matrix.
7209
58179cce 72102011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7211
7212 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7213 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7214 HAVE_GTK3 (Bug#9869).
b77a6a7f 7215
3b574623
JD
7216 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7217 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7218
b77a6a7f
JD
7219 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7220
7221 * xterm.c: Declare x_handle_net_wm_state to return int.
7222 (handle_one_xevent): Check if we are iconified but don't have
7223 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7224 (get_current_wm_state): Return non-zero if not hidden,
7225 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7226 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7227 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7228 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7229
196e41e4
PE
72302011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7231
7232 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7233 so that this new function doesn't get optimized away by a
7234 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7235
021f2e1a
AS
72362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7237
7238 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7239
8b058d44
EZ
72402011-10-29 Eli Zaretskii <eliz@gnu.org>
7241
7242 Fix the `xbytecode' command.
7243 * .gdbinit (xprintbytestr): New command.
b50a28de 7244 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7245 (xbytecode): Print the byte-code string as well.
7246
4452fb80
EZ
72472011-10-29 Kim Storm <storm@cua.dk>
7248
8b058d44
EZ
7249 * alloc.c (which_symbols): New function.
7250
21b72067
AS
72512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7252
7253 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7254 line. (Bug#9903)
7255
83ed7b5c
GM
72562011-10-29 Glenn Morris <rgm@gnu.org>
7257
7258 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7259 Not clear what it was for, and it causes various bugs. (Bug#9839)
7260
5a7a728b
EZ
72612011-10-28 Eli Zaretskii <eliz@gnu.org>
7262
7263 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7264 possible random value that matches one of those tested as
7265 condition to clear the mouse face.
7266
d3d0842f
CY
72672011-10-28 Chong Yidong <cyd@gnu.org>
7268
7269 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7270
31b39d13
DN
72712011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7272
7273 * window.c (make_window): Initialize phys_cursor_on_p.
7274
9aba6043
SM
72752011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7276
7277 * lisp.h (struct Lisp_Symbol): Update comments.
7278
c20992f4
JB
72792011-10-28 Juanma Barranquero <lekktu@gmail.com>
7280
7281 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7282
db4f02f2
EZ
72832011-10-28 Eli Zaretskii <eliz@gnu.org>
7284
7285 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7286 <oslsachem@gmail.com> for helping to debug this.
7287
7288 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7289 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7290 (g_b_init_get_glyph_outline_w): New static variables.
7291 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7292 (GetGlyphOutlineW_Proc): New typedefs.
7293 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7294 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7295 New functions.
7296 (w32font_open_internal, compute_metrics):
7297 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7298 instead of calling the "wide" APIs directly.
7299
7300 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7301
7302 * w32.h (syms_of_w32font): Add prototype.
7303
87e68db4
JB
73042011-10-27 Juanma Barranquero <lekktu@gmail.com>
7305
7306 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7307 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7308 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7309 (Fmove_to_window_line): Doc fix.
7310
435c1d67
CY
73112011-10-27 Chong Yidong <cyd@gnu.org>
7312
7313 * process.c (make_process): Set gnutls_state to NULL.
7314
7315 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7316 non-NULL, regardless of GNUTLS_INITSTAGE.
7317 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7318 an error. Set process slots as soon as we allocate them.
7319
7320 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7321
9c6c6f49
CY
73222011-10-27 Chong Yidong <cyd@gnu.org>
7323
9aba6043
SM
7324 * gnutls.c (emacs_gnutls_deinit): New function.
7325 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7326 (Fgnutls_deinit, Fgnutls_boot): Use it.
7327
7328 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7329 (deactivate_process): Call emacs_gnutls_deinit.
7330
657d08d3
JB
73312011-10-27 Juanma Barranquero <lekktu@gmail.com>
7332
7333 * image.c (x_create_x_image_and_pixmap):
7334 * w32.c (sys_rename, w32_delayed_load):
7335 * w32font.c (fill_in_logfont):
7336 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7337
5430d399
JB
73382011-10-26 Juanma Barranquero <lekktu@gmail.com>
7339
7340 * w32fns.c (w32_default_color_map): New function,
7341 extracted from Fw32_default_color_map.
a7ef684b 7342 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7343
fe0055fa
PE
73442011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7345
7346 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7347
e6346438
SM
73482011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7349
7350 * keyboard.c (test_undefined): New function (bug#9751).
7351 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7352
e112cc37
ET
73532011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7354
7355 * sysdep.c (init_sys_modes): Fix the check for the controlling
7356 terminal (Bug#6649).
7357
7b5d6677
EZ
73582011-10-20 Eli Zaretskii <eliz@gnu.org>
7359
7360 * dispextern.h (struct bidi_it): New member next_en_type.
7361
7362 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7363 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7364 current character, check also for next_en_type being WEAK_EN.
7365 (bidi_resolve_weak): Don't enter the expensive loop if the current
7366 position is before next_en_pos. Record the bidi type of the first
7367 non-ET, non-BN character we find, in addition to its position.
7368 (bidi_level_of_next_char): Invalidate next_en_type when
7369 next_en_pos is over-stepped.
7370
7da0b018
PE
73712011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7372
7373 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7374 * editfns.c: Rewrite current-time-zone so that it invokes
7375 the equivalent of (format-time-string "%Z") to get the time zone name.
7376 This fixes a bug when the time zone name contains characters that
7377 need converting from the system time locale to Emacs internal format.
7378 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7379 that patch fixed format-time-string to do the conversion, but
7380 I forgot to fix current-time-zone.
7381 (format_time_string): New function, containing most of
7382 what Fformat_time_string used to contain.
7383 (Fformat_time_string): Rewrite in terms of format_time_string.
7384 This doesn't change this function's behavior.
7385 (current-time-zone): Rewrite to use format_time_string.
7386 This fixes the bug reported by Michael Schierl in
7387 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7388 Jason Rumney's 2007-06-07 change worked around this bug, but
7389 didn't fix it.
7390 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7391
8547b010
EZ
73922011-10-19 Eli Zaretskii <eliz@gnu.org>
7393
7394 * xdisp.c (start_display): If the character at POS is displayed
7395 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7396 (try_window_reusing_current_matrix): If a line ends in a display
7397 vector or the next line starts in a display vector, continue
7398 redrawing the window even though the character position of
7399 start_row was reached.
8547b010
EZ
7400 (Bug#9771, part 2)
7401
4e948d15
CY
74022011-10-18 Chong Yidong <cyd@gnu.org>
7403
7404 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7405 with nobreak-char-display too.
7406
4787455f
EZ
74072011-10-18 Eli Zaretskii <eliz@gnu.org>
7408
7409 Fix part 3 of bug#9771.
7410 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7411 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7412 non-neutral characters if the current character is a paragraph
7413 separator (a.k.a. Newline). This avoids running the same
7414 expensive loop twice, once when we consume the preceding newline
7415 and the other time when the line actually needs to be displayed.
7416 Avoid the loop when we see neutrals on the base embedding level
7417 following a character whose directionality is the same as the
7418 paragraph's. This avoids running the expensive loop when a line
7419 ends in a long sequence of neutrals, like control characters.
7420 Add assertion against STRONG_AL type. Slightly rearrange code
7421 that determines the type of a neutral given the first non-neutral
7422 that follows it.
7423 (bidi_level_of_next_char): Set next_en_pos to zero when
7424 invalidating its info.
7425
2c91f553
EZ
74262011-10-17 Eli Zaretskii <eliz@gnu.org>
7427
7428 * xdisp.c (push_display_prop): Determine whether to record string
7429 or buffer position by IT->string, not by IT->method. Allow
7430 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7431 (move_it_vertically_backward): Don't look for character position
7432 immediately after the newline when in a continuation line.
7433 (Bug#9771, part 1)
2c91f553 7434
c7b08b0d
MR
74352011-10-15 Martin Rudalics <rudalics@gmx.at>
7436
7437 * window.c (coordinates_in_window): Rewrite and delabelize
7438 vertical border check. (Bug#5357) (Bug#9618)
7439
6b02f655
SM
74402011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7441
7442 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7443 errors in XSetWindowBorder (bug#9310).
7444
81d40c92
DA
74452011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7446
7447 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7448 avoid crash when xmalloc overrun checking is enabled.
7449
d4172c3b
EZ
74502011-10-13 Eli Zaretskii <eliz@gnu.org>
7451
7452 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7453 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7454 cursor motion with <left> and <right> arrow keys.
7455
7456 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7457 some callers set that themselves.
7458
b00eea75
EZ
74592011-10-12 Eli Zaretskii <eliz@gnu.org>
7460
7461 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7462 display string and the previous row comes from the same string and
7463 is empty. (Bug#9739) (Bug#9738)
7464
8fe012c4
SM
74652011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7466
7467 * doc.c (get_doc_string): Encode file name (bug#9735).
7468
0074aef2
EZ
74692011-10-12 Eli Zaretskii <eliz@gnu.org>
7470
79beb178
EZ
7471 * bidi.c (bidi_level_of_next_char):
7472 * xdisp.c (get_visually_first_element): Remove old incorrect
7473 comments regarding the Unicode Line Separator character.
7474
0074aef2
EZ
7475 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7476
6e4b3fbe
DA
74772011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7478
7479 * alloc.c (Fgc_status): Do not access beyond zombies array
7480 boundary if nzombies > MAX_ZOMBIES.
7481 * alloc.c (dump_zombies): Add missing format specifier.
7482
0324f3af
PE
74832011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7484
b5525cac
PE
7485 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7486 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7487
0324f3af
PE
7488 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7489 Some packages use them to denote characters with modifiers.
7490
e9b5f888
AS
74912011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7492
7493 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7494 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7495 matching a pp-number. Rename parameter var to var1.
7496
127827c0
SM
74972011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7498
7499 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7500
c8fd3bd0
GM
75012011-10-08 Glenn Morris <rgm@gnu.org>
7502
7503 * callint.c (Fcall_interactively): Give a more explicit error for the
7504 'c' case with a non-character input. (Bug#8479)
7505
352ec8ff
EZ
75062011-10-08 Eli Zaretskii <eliz@gnu.org>
7507
03669ccb
EZ
7508 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7509 lines.
7061c986
EZ
7510 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7511 lines that are hscrolled on the left.
03669ccb 7512
352ec8ff
EZ
7513 * dispnew.c (buffer_posn_from_coords): Account for a possible
7514 presence of header-line. (Bug#4426)
7515
a66cfb1c
SM
75162011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7517
6b02f655
SM
7518 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7519 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7520
7c5ee88e
PE
75212011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7522
7523 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7524 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7525 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7526 this makes Emacs dump core during garbage collection on rare
7527 occasions. sizeof is obviously inferior to offsetof here, so
7528 stick with offsetof.
7529 (GC_POINTER_ALIGNMENT): New macro.
7530 (mark_memory): Omit 3rd (offset) arg; caller changed.
7531 Don't assume EMACS_INT alignment is the same as pointer alignment.
7532
df1bbe5b
SM
75332011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7534
7535 * keyboard.c (read_key_sequence_remapped): New var.
7536 (read_key_sequence): Compute remapping in the right buffer.
7537 (command_loop_1): Use read_key_sequence's remapping directly.
7538
51553db6
SM
75392011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7540
32c1fffd
SM
7541 * dired.c (file_name_completion): Don't expand file name.
7542 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7543 before checking file name handler.
7544
51553db6
SM
7545 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7546 they've been requested explicitly (bug#9591).
7547
b6bd1599 75482011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7549
7550 * keymap.c (Fsingle_key_description): Use make_specified_string
7551 instead of build_string to build string from push_key_description.
7552 (Bug#5193)
7553
f701dc2a
PE
75542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7555
4222c55d
PE
7556 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7557 This fixes a Y2038 bug on 64-bit hosts.
7558 * buffer.c (reset_buffer):
7559 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7560 (Fclear_buffer_auto_save_failure):
7561 Use 0, not -1, to represent an unset failure time, since time_t
7562 might not be signed.
7563
f701dc2a
PE
7564 Remove dependency on glibc malloc internals.
7565 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7566 Move back here from lisp.h, but with their new implementations.
7567 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7568 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7569 * charset.c (charset_table_init): New static var.
7570 (syms_of_charset): Use it instead of xmalloc. This removes a
7571 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7572 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7573 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7574 Move back to alloc.c.
7575 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7576 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7577
9ceebf39
JD
75782011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7579
7580 * nsterm.m (windowDidResize): Call x_set_window_size only when
7581 ns_in_resize is true. Otherwise set pixelwidth/height and
7582 call change_frame_size (Bug#9628).
7583
cb993c58
PE
75842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7585
3930c88b
PE
7586 Port --enable-checking=all to Fedora 14 x86-64.
7587 * charset.c (syms_of_charset): Also account for glibc malloc's
7588 internal overhead when calculating the initial malloc maximum.
7589
cb993c58
PE
7590 Port --enable-checking=all to Fedora 14 x86.
7591 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7592 Move to lisp.h.
7593 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7594 (overrun_check_realloc, overrun_check_free):
7595 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7596 That way, xmalloc returns a properly-aligned pointer even if
7597 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7598 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7599 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7600 into account when calculating the initial malloc maximum.
7601 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7602 Move here from alloc.c, so that charset.c can use it too.
7603 Properly align; the old code wasn't right for common 32-bit hosts
7604 when configured with --enable-checking=all.
7605 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7606 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7607
31bed486
EZ
76082011-09-29 Eli Zaretskii <eliz@gnu.org>
7609
04c70788 7610 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7611 use EDOM.
7612
fbcaa2f3
EZ
76132011-09-28 Eli Zaretskii <eliz@gnu.org>
7614
7615 * xdisp.c (compute_display_string_end): If there's no display
7616 string at CHARPOS, return -1.
7617
7618 * bidi.c (bidi_fetch_char): When compute_display_string_end
7619 returns a negative value, treat the character as a normal
7620 character not covered by a display string. (Bug#9624)
7621
a239d4e9
JB
76222011-09-28 Juanma Barranquero <lekktu@gmail.com>
7623
7624 * lread.c (Fread_from_string): Fix typo in docstring.
7625
88652fd5
EZ
76262011-09-27 Eli Zaretskii <eliz@gnu.org>
7627
7628 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7629 newline, reseat the iterator instead of bidi-iterating there one
7630 character at a time. (Bug#9610)
32c1fffd
SM
7631 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7632 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7633
ed497dd4
AS
76342011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7635
7636 * lread.c (readevalloop): Use correct code for NBSP.
7637 (read1): Likewise. (Bug#9608)
7638
b2bf61aa
MA
76392011-09-25 Michael Albinus <michael.albinus@gmx.de>
7640
7641 * dbusbind.c (Fdbus_register_signal): When service is not
7642 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7643
32bbb17c
GM
76442011-09-25 Glenn Morris <rgm@gnu.org>
7645
7646 * buffer.c (truncate-lines): Doc fix.
7647
94e0933e
CY
76482011-09-24 Chong Yidong <cyd@stupidchicken.com>
7649
7650 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7651 (Fset_window_next_buffers): Doc fix.
7652
cddde921
GM
76532011-09-24 Glenn Morris <rgm@gnu.org>
7654
7655 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7656
1260aef1
PE
76572011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7658
25b4bfa0
PE
7659 Fix minor problems found by static checking.
7660 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7661 * indent.c (Fvertical_motion): Fix == vs = typo.
7662
e3cbd34b
EZ
76632011-09-24 Eli Zaretskii <eliz@gnu.org>
7664
a66cfb1c
SM
7665 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7666 Default value is now t. Doc fix.
6bf7006f 7667
e3cbd34b 7668 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7669 logic when moving up, not only when moving down. Fix the
e3cbd34b 7670 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7671 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7672
7673 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7674 CHARPOS is covered by a display string which includes newlines.
7675 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7676 is covered by a display string with embedded newlines.
7677
a3de0cbd
MA
76782011-09-24 Michael Albinus <michael.albinus@gmx.de>
7679
7680 * dbusbind.c (Fdbus_register_signal): Add match rule to
7681 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7682 (Fdbus_register_method, Vdbus_registered_objects_table):
7683 Fix docstring.
a3de0cbd 7684
b260039d
JM
76852011-09-24 Jim Meyering <meyering@redhat.com>
7686
32c1fffd 7687 do not ignore write error for any output size
b260039d
JM
7688 The previous change was incomplete.
7689 While it makes emacs --batch detect the vast majority of stdout
7690 write failures, errors were still ignored whenever the output size is
7691 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7692 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7693 && echo FAIL: ignored write error
7694 FAIL: ignored write error
7695 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7696 && echo FAIL: ignored write error
7697 FAIL: ignored write error
7698 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7699
8eca8a7c
AS
77002011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7701
7702 * emacs.c (Fkill_emacs): In noninteractive mode exit
7703 non-successfully if a write error occurred on stdout. (Bug#9574)
7704
3341db62
EZ
77052011-09-21 Eli Zaretskii <eliz@gnu.org>
7706
7707 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7708 the xassert test.
7709
7710 * dispextern.h (struct it): Update the comment documenting what
7711 can it->OBJECT be.
7712
8c203dbf
EZ
77132011-09-20 Eli Zaretskii <eliz@gnu.org>
7714
7715 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7716 a display string, extend search for cursor position to end of row.
7717 (find_row_edges): If the row ends in a newline from a display
7718 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7719 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7720 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7721 non-empty line. Fixes confusing cursor motion with arrow keys at
7722 the beginning of a line that starts with whitespace.
8c203dbf 7723
a4824228
LMI
77242011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7725
7726 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7727 (bug#9493).
7728
33ed493b
CY
77292011-09-18 Chong Yidong <cyd@stupidchicken.com>
7730
7731 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7732 boolean (Bug#9154).
7733
56cd55c8
EZ
77342011-09-18 Eli Zaretskii <eliz@gnu.org>
7735
7736 * xdisp.c (display_line): Record maximum and minimum buffer
7737 positions even if no glyphs were produced (e.g., by a zero-width
7738 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7739 buffer positions that will be removed from the glyph row because
7740 they don't fit.
c02dcedf
EZ
7741 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7742 column is beyond frame width: don't subtract 1 "pixel" when
7743 computing width of the stretch.
3e62b7e0
EZ
7744 (reseat_at_next_visible_line_start): Undo the change made on
7745 2011-09-17 that saved paragraph information and restored it after
7746 the call to `reseat'. (Bug#9545)
56cd55c8 7747
5ed99d36 77482011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7749
7750 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7751 and turn window cursor on if cleared (Bug#9415).
7752
5ed99d36 77532011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7754
7755 * search.c (boyer_moore): Take unibyte characters from pattern
7756 literally. (Bug#9458)
7757
9bade7b2
EZ
77582011-09-18 Eli Zaretskii <eliz@gnu.org>
7759
7760 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7761
e5e9d610
PE
77622011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7763
87e4427a
PE
7764 Fix minor problem found by static checking.
7765 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7766 initialized, to pacify gcc -Wuninitialized.
7767
e5e9d610
PE
7768 * fileio.c: Report proper errno when syscall falls.
7769 (Finsert_file_contents): Save and restore errno,
7770 so that report_file_error outputs the correct diagnostic.
7771 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7772
a1674f0b
EZ
77732011-09-18 Eli Zaretskii <eliz@gnu.org>
7774
7775 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7776
fbfb6dd4
EZ
77772011-09-17 Eli Zaretskii <eliz@gnu.org>
7778
7779 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7780 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7781
bb187662
EZ
77822011-09-17 Eli Zaretskii <eliz@gnu.org>
7783
1137e8b8 7784 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7785 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7786
7787 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7788 (bidi_find_paragraph_start): Search back for paragraph beginning
7789 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7790 (bidi_move_to_visually_next): Only trigger paragraph-related
7791 computations when the last character is a newline or at EOB, not
7792 just any NEUTRAL_B. (Bug#9470)
7793
bb187662
EZ
7794 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7795 truncated lines if point is covered by a display string. (Bug#9524)
7796
2e621251
PE
77972011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7798
7799 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7800 (cons_to_x_long): New function.
7801 (lisp_data_to_selection_data): Use it. Correct the test for
7802 short-versus-long data; it was negated. Break out of vector
7803 loop, for efficiency, when a long datum is discovered.
7804
91a15bc6
SM
78052011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7806
7807 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7808
b41c3a35
EZ
78092011-09-16 Eli Zaretskii <eliz@gnu.org>
7810
7811 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7812 GCC PR/17406) by declaring this function with external scope.
7813
7812ba2d
PE
78142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7815
7816 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7817 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7818
cf7edc2a
AS
78192011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7820
7821 * editfns.c (Fformat): Correctly handle text properties on "%%".
7822
bd01620e
EZ
78232011-09-15 Eli Zaretskii <eliz@gnu.org>
7824
7825 * xterm.c (x_draw_composite_glyph_string_foreground):
7826 * w32term.c (x_draw_composite_glyph_string_foreground):
7827 * term.c (encode_terminal_code):
7828 * composite.c (composition_update_it, get_composition_id):
7829 * xdisp.c (get_next_display_element)
7830 (fill_composite_glyph_string): Add comments about special meaning
7831 of TAB characters in a composition.
7832
a02719a3
PE
78332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7834
7835 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7836 This occurs when processing a multibyte format.
7837 Problem reported by Wolfgang Jenker.
a02719a3 7838
72589a3c
JB
78392011-09-15 Johan Bockgård <bojohan@gnu.org>
7840
7841 * xdisp.c (try_cursor_movement): Only check for exact match if
7842 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7843
1c14176c
PE
78442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7845
7846 Remove unused external symbols.
7847 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7848 * xdisp.c (calc_pixel_width_or_height): Now static.
7849 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7850 * indent.c (check_display_width):
7851 * w32term.c: Fix comment to match code.
7852 * xterm.c, xterm.h (x_catching_errors): Remove.
7853
d2eea5b5
PE
78542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7855
7856 * xselect.c: Use signed conversions more consistently (Bug#9498).
7857 (selection_data_to_lisp_data): Assume incoming selection data are
7858 signed integers, not unsigned. This is to be consistent with
7859 outgoing selection data, which was modified to use signed integers
7860 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7861 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7862 expects long, not unsigned long.
7863
46888499
EZ
78642011-09-14 Eli Zaretskii <eliz@gnu.org>
7865
7866 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7867 computation of loop end. Reported by Johan Bockgård
7868 <bojohan@gnu.org>.
7869
ef8ef9fb
CY
78702011-09-13 Chong Yidong <cyd@stupidchicken.com>
7871
7872 * frame.c (Fother_visible_frames_p): Function deleted.
7873
fa819fed
EZ
78742011-09-12 Eli Zaretskii <eliz@gnu.org>
7875
7876 * indent.c (compute_motion): Process display vector front to back
7877 rather than the other way around. (Bug#2496)
7878
2ba8e008
SM
78792011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7880
7881 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7882
20f53c69
CY
78832011-09-11 Chong Yidong <cyd@stupidchicken.com>
7884
7885 * minibuf.c (Fread_from_minibuffer): Doc fix.
7886
d562d7a4
EZ
78872011-09-11 Eli Zaretskii <eliz@gnu.org>
7888
7889 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7890 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7891
1c4d7f3d
LMI
78922011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7893
7894 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7895 value for non-existent files.
7896
b885bf36
EZ
78972011-09-11 Eli Zaretskii <eliz@gnu.org>
7898
7899 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7900 set its "size" to -1. This will set the modtime_size field of
7901 the corresponding buffer to -1, which is what
7902 verify-visited-file-modtime expects for files that do not exist.
7903 (Bug#9139)
7904
6612f0bf
PE
79052011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7906
7907 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7908 here ...
7909 * lisp.h: ... from here. push_key_description is no longer
7910 defined in keyboard.c, so its declaration should not be in
7911 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7912 logically belongs with push_key_description.
7913
dfb3f755
PE
79142011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7915
7916 * buffer.h: Include <sys/types.h> instead of <time.h>.
7917 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7918 Problem reported by Herbert J. Skuhra.
7919
3134906c
LMI
79202011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7921
7922 * xml.c (parse_region): Make the parsing work for
7923 non-comment-starting XML files again (bug#9144).
7924
8d903f4e
AS
79252011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7926
7927 * image.c (gif_load): Fix calculation of bottom and right corner.
7928 (Bug#9468)
7929
80ad64f4
EZ
79302011-09-10 Eli Zaretskii <eliz@gnu.org>
7931
7932 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7933 redisplay in small windows.
7934
208a048d
EZ
79352011-09-09 Eli Zaretskii <eliz@gnu.org>
7936
7937 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7938
9b1c252e
MR
79392011-09-08 Martin Rudalics <rudalics@gmx.at>
7940
7941 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7942 Operate on live windows only.
7943
2949f33b
JB
79442011-09-08 Juanma Barranquero <lekktu@gmail.com>
7945
7946 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7947
e08dcafd
EZ
79482011-09-07 Eli Zaretskii <eliz@gnu.org>
7949
7950 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7951 only under bidi iteration.
7952
115b96bd
JD
79532011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7954
7955 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7956
c8199d0f
PE
79572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7958
7959 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7960 Without this fix, the command to link temacs failed due to an
7961 undefined symbol __builtin_isnan. This is because
7962 /usr/include/iso/math_c99.h #defines isnan(x) to
7963 __builtin_isnan(x), but the bundled gcc, which identifies itself
7964 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7965 a __builtin_isnan.
7966 * floatfns.c (isnan): #undef, and then #define to a clone of
7967 what's in data.c.
7968 (Fisnan): Always define, since it's always available now.
7969 (syms_of_floatfns): Always define isnan at the Lisp level.
7970
e39b275c 79712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7972
7973 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7974
b2db44d9 79752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7976
f4af5137 7977 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7978 The previous code assumed that file offsets (off_t values) fit in
7979 EMACS_INT variables, which is not true on typical 32-bit hosts.
7980 The code messed up by falsely reporting buffer overflow in cases
7981 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7982 when "big" contains more than 2**29 bytes, even though this
7983 inserts just one byte and does not overflow the buffer.
7984 (Finsert_file_contents): Store file offsets as off_t
7985 values, not as EMACS_INT values. Check for overflow when
7986 converting between EMACS_INT and off_t. When checking for
7987 buffer overflow or for overlap, take the offsets into account.
7988 Don't use EMACS_INT for small values where int suffices.
7989 When checking for overlap, fix a typo: ZV was used where
7990 ZV_BYTE was intended.
7991 (Fwrite_region): Don't assume off_t fits into 'long'.
7992 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7993
ecfc0a49
MA
79942011-09-05 Michael Albinus <michael.albinus@gmx.de>
7995
7996 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7997
6511acf2 79982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7999
0999621a 8000 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8001
8002 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8003 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8004 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8005 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8006 (modify_event_symbol): Do not assume that the length of
8007 name_alist_or_stem is safe to alloca and fits in int.
8008 (Fexecute_extended_command): Likewise for function name and binding.
8009 (Frecursion_depth): Wrap around reliably on integer overflow.
8010 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8011 since some callers pass EMACS_INT values.
8012 (Fsingle_key_description): Don't crash if symbol name contains more
8013 than MAX_ALLOCA bytes.
8014 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8015 (get_minibuffer): Arg is now EMACS_INT, not int.
8016 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8017 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8018 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8019
2be7d702
PE
8020 * dbusbind.c (signature_cat): New function.
8021 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8022 Do not overrun buffer; instead, report string overflow.
8023
9d1df220
PE
8024 * dispnew.c (add_window_display_history): Don't overrun buffer.
8025 Truncate instead; this is OK since it's just a log.
8026
33ef5c64
PE
8027 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8028 even if the time zone offset is outlandishly large.
8029 Don't mishandle offset == INT_MIN.
8030
66c6fdd5
PE
8031 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8032 when creating daemon; the previous buffer-overflow check was incorrect.
8033
d749b01b
PE
8034 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8035 which has the guts of the old verror function.
8036
b5cd1905
PE
8037 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8038 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8039
6e1a67fb
PE
8040 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8041 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8042 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8043 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8044 length of string rather than counting it via multiple sprintfs;
8045 that's simpler and more reliable.
c21721cc
PE
8046 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8047 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8048 sprintf, in case result does not fit in int.
8049
c57b67fc
PE
8050 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8051 (fontset_from_font): Print it.
8052
8a401434
PE
8053 * frame.c (tty_frame_count): Now printmax_t, not int.
8054 (make_terminal_frame, set_term_frame_name): Print it.
8055 (x_report_frame_params): In X, window IDs are unsigned long,
8056 not signed long, so print them as unsigned.
8057 (validate_x_resource_name): Check for implausibly long names,
8058 and don't assume name length fits in 'int'.
8059 (x_get_resource_string): Don't blindly alloca invocation name;
8060 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8061 not fit in int.
8062
6e1a67fb
PE
8063 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8064 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8065 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8066
0df02bf3
PE
8067 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8068 Use esprintf, not sprintf, in case result does not fit in int.
8069
48e30793
PE
8070 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8071 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8072 it as a large positive number.
8073 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8074 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8075
a66ff6d8
PE
8076 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8077 in case result does not fit in int.
8078
aca216ff
PE
8079 * print.c (float_to_string): Detect width overflow more reliably.
8080 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8081 buffer overrun. Don't assume list length fits in 'int'. Treat
8082 print length of 0 as 0, not as infinity; to be consistent with other
8083 uses of print length in this function. Don't overflow print length
8084 index. Don't assume hash table size fits in 'long', or that
8085 vectorlike size fits in 'unsigned long'.
8086
31c286f7
PE
8087 * process.c (make_process): Use printmax_t, not int, to format
8088 process-name gensyms.
8089
55e5faa1
PE
8090 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8091
80f2e268
PE
8092 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8093 to avoid potential buffer overrun.
8094
670741ab
PE
8095 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8096 if X resource line is longer than 512 bytes.
8097
b7163a50
PE
8098 * xfns.c (x_window): Make sprintf buffer a bit bigger
8099 to avoid potential buffer overrun.
8100
ae58ff1f
PE
8101 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8102
c43c8a6a
PE
8103 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8104
3f8236f4
PE
81052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8106
53e9fe90 8107 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8108 Without these, Emacs silently mishandles large integers sometimes.
8109 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8110 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8111
6511acf2
PE
8112 * xdisp.c (try_window_id): Check Emacs fixnum range before
8113 converting to 'int'.
806add1d 8114
6511acf2 8115 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8116 Check that an Emacs fixnum is in range before assigning it to 'int'.
8117 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8118 values converted from Emacs fixnums.
8119 (Frecenter): Don't wrap around a line count if it is out of 'int'
8120 range; instead, treat it as an extreme value.
8121 (Fset_window_configuration, compare_window_configurations):
8122 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8123
6511acf2
PE
8124 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8125 that can exceed INT_MAX. Check that EMACS_INT value is in range
8126 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8127 (match_limit): Don't assume that a fixnum can fit in 'int'.
8128
6511acf2 8129 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8130 exceed INT_MAX.
8131
6511acf2 8132 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8133 (Fvertical_motion): Don't wrap around LINES values that don't fit
8134 in 'int'. Instead, treat them as extreme values. This is good
8135 enough for windows, which can't have more than INT_MAX lines anyway.
8136
fcb901a7
LMI
81372011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8138
0f2f6b6d
LMI
8139 * Require libxml/parser.h to avoid compilation warning.
8140
fcb901a7
LMI
8141 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8142
8143 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8144 since this reportedly can destroy thread storage.
8145
6e20a0d4
CY
81462011-08-30 Chong Yidong <cyd@stupidchicken.com>
8147
8148 * syntax.c (find_defun_start): Update all cache variables if
8149 exiting early (Bug#9401).
8150
148ae00e
EZ
81512011-08-30 Eli Zaretskii <eliz@gnu.org>
8152
f6cfbd8f
EZ
8153 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8154
148ae00e
EZ
8155 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8156 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8157 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8158
8159 * term.c (tty_append_glyph): New function.
8160 (produce_stretch_glyph): Static function and its prototype deleted.
8161
a66cfb1c
SM
8162 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8163 Add prototypes.
148ae00e 8164
c4a07a4c
PE
81652011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8166
8167 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8168 when checking :margin (Bug#9390).
8169 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8170 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8171 so that the name doesn't mislead. All uses changed.
8172
6bc8cd65
JB
81732011-08-28 Johan Bockgård <bojohan@gnu.org>
8174
8175 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8176 set_tty_hooks.
8177
dca4927e
EZ
81782011-08-27 Eli Zaretskii <eliz@gnu.org>
8179
8180 * xdisp.c (move_it_to): Don't bail out early when reaching
8181 position beyond to_charpos, if we are scanning backwards.
8182 (move_it_vertically_backward): When DY == 0, make sure we get to
8183 the first character in the line after the newline.
8184
f2cad773
PE
81852011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8186
8187 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8188 (ccl_driver): Do not generate an out-of-range pointer.
8189 (Fccl_execute_on_string): Remove unnecessary check for
8190 integer overflow, noted by Stefan Monnier in
8191 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8192 Remove a FIXME that didn't need fixing.
8193 Simplify the newly-introduced buffer reallocation code.
8194
0cae2cdb
JB
81952011-08-27 Juanma Barranquero <lekktu@gmail.com>
8196
8197 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8198
5fc295a4 81992011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8200
70c60eb2 8201 Integer and memory overflow issues (Bug#9196).
726e0ab1 8202
d31850da
PE
8203 * doc.c (get_doc_string): Rework so that
8204 get_doc_string_buffer_size is the actual buffer size, rather than
8205 being 1 less than the actual buffer size; this makes xpalloc more
8206 convenient.
8207
a69fbedb
PE
8208 * image.c (x_allocate_bitmap_record, cache_image):
8209 * xselect.c (Fx_register_dnd_atom):
8210 Simplify previous changes by using xpalloc.
8211
fe5c5d37
PE
8212 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8213 since either will do and ptrdiff_t is convenient with xpalloc.
8214
0065d054
PE
8215 * charset.c (charset_table_size)
8216 (struct charset_sort_data.priority): Now ptrdiff_t.
8217 (charset_compare): Don't overflow if priorities differ greatly.
8218 (Fsort_charsets): Don't assume list length fits in int.
8219 Check for size-calculation overflow when allocating sort data.
8220 (syms_of_charset): Allocate an initial charset table that is
8221 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8222
8223 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8224
8225 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8226 The actual value is always <= INT_MAX, and leaving it unsigned made
8227 overflow checking harder.
8228
8229 * dispextern.h (struct glyph_matrix.rows_allocated)
8230 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8231 with xpalloc. The values are still always <= INT_MAX.
8232
8233 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8234
8235 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8236 (SAFE_NALLOCA): New macro.
8237
8238 * region-cache.c (struct boundary.pos, find_cache_boundary)
8239 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8240 (set_cache_region, invalidate_region_cache)
8241 (revalidate_region_cache, know_region_cache, region_cache_forward)
8242 (region_cache_backward, pp_cache):
8243 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8244 so that ptrdiff_t * can be passed to xpalloc.
8245 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8246 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8247 (pp_cache): Don't assume cache_len fits in int.
8248 * region-cache.h: Adjust extern decls to match.
8249
8250 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8251 EMACS_INT, since either will do, for xpalloc.
8252
8253 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8254 (xnmalloc, xnrealloc, xpalloc): New functions.
8255
726e0ab1
PE
8256 * bidi.c (bidi_shelve_header_size): New constant.
8257 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8258 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8259
51f30bc5 8260 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8261 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8262 (overlay_strings):
8263 Don't update size of array until after memory allocation succeeds,
8264 because xmalloc/xrealloc may not return.
0065d054
PE
8265 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8266 now that we have proper integer overflow checking.
8267 (record_overlay_string, overlay_strings): Catch overflows when
8268 calculating size of overlay_str_buf.
726e0ab1 8269
0065d054
PE
8270 * callproc.c (Fcall_process): Check for size overflow when
8271 calculating size of args2.
8272 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8273 Normally we prefer signed values, but sticking with ptrdiff_t would
8274 require adding more-complicated checks.
726e0ab1
PE
8275
8276 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8277 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8278 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8279 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8280
8281 * character.c (Fstring): Check for size-calculation overflow.
8282
8283 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8284 unnecessary integer overflow. Check for size overflow.
8285 (encode_coding_object): Don't update size until xmalloc succeeds.
8286
8287 * composite.c (get_composition_id): Check for overflow in glyph
8288 length calculations.
8289
8290 Integer and memory overflow fixes for display code.
8291 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8292 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8293 (scrolling_window): Check for overflow in size calculations.
8294 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8295 Don't assume glyph table len fits in int.
8296 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8297 (row_table_size): Now ptrdiff_t, not int.
8298 (scrolling_window): Avoid overflow in size calculations.
8299 Don't update size until allocation succeeds.
8300 * fns.c (concat): Check for overflow in size calculations.
8301 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8302 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8303 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8304
8305 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8306 (get_doc_string): Check for size calculation overflow.
8307 Don't update size until allocation succeeds.
8308 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8309 EMACS_INT, where ptrdiff_t will do.
8310 (Fsubstitute_command_keys): Check for string overflow.
8311
8312 * editfns.c (set_time_zone_rule): Don't assume environment length
8313 fits in int.
8314 (message_length): Now ptrdiff_t, not int.
8315 (Fmessage_box): Don't update size until allocation succeeds.
8316 Don't assume message length fits in int.
8317 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8318
0065d054
PE
8319 * emacs.c (main): Do not reallocate argv, since there is a null at
8320 the end that can be overwritten, and this way there's no need to
8321 worry about size-calculation overflow.
8322 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8323
8324 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8325 alloc succeeds.
8326 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8327
8328 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8329 (x_set_scroll_bar_width, x_figure_window_size):
8330 Check for integer overflow.
8331 (x_set_alpha): Do not assume XINT fits in int.
8332
8333 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8334 This is for the members text_lines, text_cols, total_lines, total_cols,
8335 where the system imposes an 'int' limit.
8336
8337 * fringe.c (Fdefine_fringe_bitmap):
8338 Don't update size until alloc works.
8339
8340 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8341 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8342
8343 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8344 Check for size-calculation overflow.
8345 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8346 do, as we prefer signed integers.
8347 (id_to_widget.max_size, id_to_widget.used)
8348 (xg_store_widget_in_map, xg_remove_widget_from_map)
8349 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8350 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8351 Use and return ptrdiff_t, not int.
8352 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8353 * gtkutil.h: Change prototypes to match the above.
8354
8355 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8356 are duplicate now that they've been promoted to lisp.h.
8357 (x_allocate_bitmap_record, x_alloc_image_color)
8358 (make_image_cache, cache_image, xpm_load):
8359 Don't update size until alloc is done.
8360 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8361 (x_detect_edges):
3256efce 8362 Check for size calculation overflow.
726e0ab1
PE
8363 (ct_colors_allocated_max): New constant.
8364 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8365 overflow.
3256efce 8366
726e0ab1
PE
8367 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8368 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8369 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8370 Use ptrdiff_t, not int, to count maps.
8371 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8372 calculations. Don't update size until allocation succeeds.
8373 Redo calculations to avoid overflow.
726e0ab1
PE
8374 * keyboard.h: Change prototypes to match the above.
8375
8376 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8377 to count maps.
8378 (current_minor_maps): Check for size calculation overflow.
8379 * keymap.h: Change prototypes to match the above.
8380
8381 * lread.c (read1, init_obarray): Don't update size until alloc done.
8382
8383 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8384 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8385
726e0ab1
PE
8386 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8387 Now ptrdiff_t, not int.
8388 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8389 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8390
8391 * process.c (Fnetwork_interface_list): Check for overflow
8392 in size calculation.
8393
8394 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8395
8396 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8397 overflow. Don't bother calling xmalloc when xrealloc will do.
8398
8399 * search.c (Freplace_match): Check for size calculation overflow.
8400 (Fset_match_data): Don't assume list lengths fit in 'int'.
8401
8402 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8403 for command line length. Do not attempt to address one before the
8404 beginning of an array, as that's not portable.
8405
8406 * term.c (max_frame_lines): Remove; unused.
8407 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8408 not int.
8409 (encode_terminal_code, calculate_costs): Check for size
8410 calculation overflow.
8411 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8412 table lengths and related sizes. Don't update size until alloc
8413 done. Redo calculations to avoid overflow.
8414 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8415
8416 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8417 subtracting pointers.
8418 (gobble_line): Check for overflow more carefully. Don't update size
8419 until alloc done.
8420
8421 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8422 Don't update size until alloc done.
8423 Redo size calculations to avoid overflow.
8424 Check for size calculation overflow.
0065d054 8425 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8426
8427 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8428 Use ptrdiff_t, not int, for sizes.
8429 (store_mode_line_noprop_char): Don't update size until alloc done.
8430
0065d054
PE
8431 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8432 Use ptrdiff_t, not int, for sizes.
8433 (Finternal_make_lisp_face, cache_face):
8434 Check for size calculation overflow.
8435 (cache_face): Treat size calculation overflows as if they were
8436 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8437
8438 * xfns.c (x_encode_text, x_set_name_internal)
8439 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8440 sizes, since they can exceed INT_MAX in size. Check for size
8441 calculation overflow.
8442
0065d054
PE
8443 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8444 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8445 Don't update size until alloc done.
8446
0065d054 8447 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8448 as sprintf is limited to int lengths.
1d526e2f 8449
252c5ee1
PE
8450 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8451 (X_LONG_MIN): New macros.
864d7ce7
PE
8452 Use them to make the following changes clearer.
8453 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8454 This change doesn't affect the value now, but it may help remind
8455 future maintainers not to raise the value too much later.
8456 (SELECTION_QUANTUM): Remove, replacing with ...
8457 (selection_quantum): ... new function, which avoids overflow.
8458 All uses changed.
8459 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8460 assumption that selection length fits in 'int'.
8461 (x_reply_selection_request, x_handle_selection_request)
8462 (x_get_window_property, receive_incremental_selection)
8463 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8464 (lisp_data_to_selection_data, clean_local_selection_data):
8465 Use ptrdiff_t, not int, to record length of selection.
8466 (x_reply_selection_request, x_get_window_property)
8467 (receive_incremental_selection, x_property_data_to_lisp):
8468 Redo calculations to avoid overflow.
8469 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8470 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8471 something.
8472 (x_get_window_property, receive_incremental_selection)
8473 (lisp_data_to_selection_data, x_property_data_to_lisp):
8474 Check for size-calculation overflow.
8475 (x_get_window_property, receive_incremental_selection)
8476 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8477 Don't store size until memory allocation succeeds.
8478 (x_get_window_property): Plug memory leak on memory exhaustion.
8479 Don't double-block input; malloc is safe here. Don't assume 2**34
8480 - 4 fits in unsigned long. Add an xassert to check
8481 XGetWindowProperty overflow. Be more careful about overflow
8482 calculations, and distinguish size from memory overflow better.
8483 (receive_incremental_selection): When tracing, don't assume
8484 unsigned int is less than INT_MAX.
8485 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8486 harmful) conversions of unsigned short to int.
8487 (lisp_data_to_selection_data): Don't assume that integers
8488 in the range -65535 through -1 fit in an X unsigned short.
8489 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8490 result parameters unless successful. Rely on cons_to_unsigned
8491 to report problems with elements; the old code wasn't right anyway.
8492 (x_check_property_data): Check for int overflow; we cannot use
8493 a wider type due to X limits.
8494 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8495
726e0ab1 8496 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8497
0065d054
PE
8498 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8499 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8500 (x_color_cells): Don't store size until memory allocation succeeds.
8501 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8502 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8503 (x_term_init): Don't assume length fits in int (sprintf is limited
8504 to int size).
bc18e09d 8505
ebfa62c0
PE
8506 Use ptrdiff_t for composition IDs.
8507 * character.c (lisp_string_width):
8508 * composite.c (composition_table_size, n_compositions)
8509 (get_composition_id, composition_gstring_from_id):
8510 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8511 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8512 * window.c (Frecenter):
8513 Use ptrdiff_t, not int, for composition IDs.
8514 * composite.c (get_composition_id): Check for integer overflow.
8515 * composite.h: Adjust prototypes to match the above changes.
8516
d3411f89
PE
8517 Use ptrdiff_t for hash table indexes.
8518 * category.c (hash_get_category_set):
8519 * ccl.c (ccl_driver):
8520 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8521 * coding.c (coding_system_charset_list, detect_coding_system):
8522 * coding.h (struct coding_system.id):
8523 * composite.c (get_composition_id, gstring_lookup_cache):
8524 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8525 * image.c (xpm_get_color_table_h):
8526 * lisp.h (hash_lookup, hash_put):
8527 * minibuf.c (Ftest_completion):
8528 Use ptrdiff_t for hash table indexes, not int (which is too
8529 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8530 32-bit --with-wide-int hosts).
8531
e097a6fa
PE
8532 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8533 Add a FIXME comment about memory leaks.
8534 (syms_of_charset): Don't assume xmalloc returns.
8535
5637687f
PE
8536 Don't assume that stated character widths fit in int.
8537 * character.c (Fchar_width, c_string_width, lisp_string_width):
8538 * character.h (CHAR_WIDTH):
8539 * indent.c (MULTIBYTE_BYTES_WIDTH):
8540 Use sanitize_char_width to avoid undefined and/or bad behavior
8541 with outlandish widths.
a66cfb1c 8542 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8543 now that we have two such functions. All uses changed.
8544 (sanitize_char_width): New inline function.
8545
a2271ba2
PE
8546 Don't assume that tab-width fits in int.
8547 * character.h (sanitize_width): New inline function.
8548 (SANE_TAB_WIDTH): New macro.
8549 (ASCII_CHAR_WIDTH): Use it.
8550 * indent.c (sane_tab_width): Remove. All uses replaced by
8551 SANE_TAB_WIDTH (current_buffer).
8552 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8553
18c52557
PE
8554 * fileio.c: Integer overflow issues with file modes.
8555 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8556
caeeedc1
PE
8557 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8558 Remove unreachable code.
8559 (read_hex, load_charset_map_from_file): Check for integer overflow.
8560
6df6ae42 8561 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8562 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8563 (x_send_scroll_bar_event): Likewise. Check that the size does not
8564 exceed limits imposed by XClientMessageEvent, as well as the usual
8565 ptrdiff_t and size_t limits.
8566
b13995db
PE
8567 * keyboard.c: Overflow, signedness and related fixes.
8568 (make_lispy_movement): Use same integer type in forward decl
8569 that is used in the definition.
8570 (read_key_sequence, keyremap_step):
8571 Change bufsize argument back to int, undoing my 2011-03-30 change.
8572 We prefer signed types, and int is wide enough here.
8573 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8574 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8575 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8576 length, not size_t. Use ptrdiff_t for index, not int.
8577 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8578 possibility of integer overflow.
8579
13464394
PE
8580 Overflow, signedness and related fixes for images.
8581
8582 * dispextern.h (struct it.stack[0].u.image.image_id)
8583 (struct_it.image_id, struct image.id, struct image_cache.size)
8584 (struct image_cache.used, struct image_cache.ref_count):
8585 * gtkutil.c (update_frame_tool_bar):
8586 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8587 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8588 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8589 * nsmenu.m (update_frame_tool_bar):
8590 * xdisp.c (calc_pixel_width_or_height):
8591 * xfns.c (image_cache_refcount):
8592 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8593 on typical 64-bit hosts.
8594
8595 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8596 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8597 Omit unnecessary casts to int.
8598 (parse_image_spec): Check that integers fall into 'int' range
8599 when the callers expect that.
8600 (image_ascent): Redo ascent calculation to avoid int overflow.
8601 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8602 (lookup_image): Remove unnecessary tests.
8603 (xbm_image_p): Locals are now of int, not EMACS_INT,
8604 since parse_image_check makes sure they fit into int.
8605 (png_load, gif_load, svg_load_image):
8606 Prefer int to unsigned where either will do.
8607 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8608 old tiff_error_handler and tiff_warning_handler.
8609 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8610 stack buffer overflows. It uses only the features of vsnprintf
8611 that are common to both POSIX and native Microsoft.
8612 (tiff_error_handler, tiff_warning_handler): Use it.
8613 (tiff_load, gif_load, imagemagick_load_image):
8614 Don't assume :index value fits in 'int'.
8615 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8616 (imagemagick_load_image): Check that crop parameters fit into
8617 the integer types that MagickCropImage accepts. Don't assume
8618 Vimagemagick_render_type has a nonnegative value. Don't assume
8619 size_t fits in 'long'.
8620 (gs_load): Use printmax_t to print the widest integers possible.
8621 Check for integer overflow when computing image height and width.
8622
c11821d4
EZ
86232011-08-26 Eli Zaretskii <eliz@gnu.org>
8624
8625 * xdisp.c (redisplay_window): Don't force window start if point
8626 will be invisible in the resulting window. (Bug#9324)
8627
0c95fcf7
EZ
86282011-08-25 Eli Zaretskii <eliz@gnu.org>
8629
8630 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8631 the display spec is of the form `(space ...)'.
8632 (handle_display_spec): Return the value returned by
8633 handle_single_display_spec, not just 1 or zero.
8634 (handle_single_display_spec): If the display spec is of the form
8635 `(space ...)', and specifies display in the text area, return 2
8636 rather than 1.
fee65a97 8637 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8638 accurately, and prefer exact match for point under bidi.
8639 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8640
8641 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8642 into disp_prop; all users changed.
8643
8644 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8645 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8646 for the text covered by the display property.
8647
e4ed06f1
CY
86482011-08-25 Chong Yidong <cyd@stupidchicken.com>
8649
8650 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8651 Change return value to nil.
8652 (Frecord_buffer): Delete unused function.
8653
f67cdd7f
EZ
86542011-08-24 Eli Zaretskii <eliz@gnu.org>
8655
5980d4c6
EZ
8656 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8657 buffers, return left-to-right.
8610fe8b
EZ
8658 (set_cursor_from_row): Consider candidate row a win if its glyph
8659 represents a newline and point is on that newline. Fixes cursor
8660 positioning on the newline at EOL of R2L text within L2R
8661 paragraph, and vice versa.
8662 (try_cursor_movement): Check continued rows, in addition to
8663 continuation rows. Fixes unwarranted scroll when point enters a
8664 continued line of R2L text within an L2R paragraph, or vice versa.
8665 (cursor_row_p): Consider the case of point being equal to
8666 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8667 from the end of a short line to the beginning of a continued line
8668 of R2L text within L2R paragraph.
8669 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8670 composed characters.
5980d4c6 8671
f67cdd7f
EZ
8672 * bidi.c (bidi_check_type): Use xassert.
8673 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8674 members.
8675
bca633fb
EZ
86762011-08-23 Eli Zaretskii <eliz@gnu.org>
8677
8678 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8679 a character.
8680
4a5885a7
CY
86812011-08-23 Chong Yidong <cyd@stupidchicken.com>
8682
8683 * nsfont.m (ns_otf_to_script): Fix typo.
8684
0902a04e
KH
86852011-08-22 Kenichi Handa <handa@m17n.org>
8686
8687 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8688 extra slot even if the purpose is char-code-property-table.
8689
1a2e6670
EZ
86902011-08-23 Eli Zaretskii <eliz@gnu.org>
8691
8ddde651
EZ
8692 * xdisp.c (redisplay_window): When computing centering_position,
8693 account for the height of the header line. (Bug#8874)
8694
425cc014
EZ
8695 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8696 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8697 candidate is selected by the mouse, and that candidate has a
8698 composed character under the mouse.
8699
1a2e6670
EZ
8700 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8701 coordinates reported by pos-visible-in-window-p for a composed
8702 character in column zero.
8703
8b76d6f8
SM
87042011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8705
8706 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8707
dac347dd
EZ
87082011-08-22 Eli Zaretskii <eliz@gnu.org>
8709
8710 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8711 consider it a hit if to_charpos is anywhere in the range of the
8712 composed buffer positions.
8713
e013fb34
CY
87142011-08-22 Chong Yidong <cyd@stupidchicken.com>
8715
8716 * image.c (gif_load): Don't assume that each subimage has the same
8717 dimensions as the base image. Handle disposal method that is
8718 "undefined" by the gif spec (Bug#9335).
8719
bd1ba3e8
CY
87202011-08-20 Chong Yidong <cyd@stupidchicken.com>
8721
8722 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8723 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8724
54a1215b
EZ
87252011-08-19 Eli Zaretskii <eliz@gnu.org>
8726
823564e5
EZ
8727 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8728 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8729 from an Org mode buffer to a Speedbar frame.
8730
54a1215b
EZ
8731 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8732 a composition, take its buffer position from IT->cmp_it.charpos.
8733 Fixes cursor positioning at the beginning of a line that begins
8734 with a composed character.
8735
9778ebcc
EZ
87362011-08-18 Eli Zaretskii <eliz@gnu.org>
8737
0be6ee06
EZ
8738 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8739 character bidirectional type, use STRONG_L instead. Fixes crashes
8740 in a buffer produced by `describe-categories'.
8741
9778ebcc
EZ
8742 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8743 members before the level stack, so they would be saved and
8744 restored when copying iterator state. Fixes incorrect reordering
8745 around TABs covered by display properties.
8746
156bffbe
AS
87472011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8748
6b02f655 8749 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8750
72ad093b
CY
87512011-08-17 Chong Yidong <cyd@stupidchicken.com>
8752
8753 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8754 (internal_condition_case_2, internal_condition_case_n):
8755 Remove unnecessary aborts (Bug#9081).
72ad093b 8756
35774242
EZ
87572011-08-17 Eli Zaretskii <eliz@gnu.org>
8758
8759 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8760 has no `load' handler, try opening the file locally. (Bug#9311)
8761
db76dd85
KB
87622011-08-16 Ken Brown <kbrown@cornell.edu>
8763
8764 * gmalloc.c: Expand comment.
8765
b215eee5
EZ
87662011-08-16 Eli Zaretskii <eliz@gnu.org>
8767
8768 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8769 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8770
a4579d33
KB
87712011-08-16 Ken Brown <kbrown@cornell.edu>
8772
8773 Fix memory allocation problems in Cygwin build (Bug#9273).
8774
8775 * unexcw.c ( __malloc_initialized): Declare external variable.
8776 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8777
8b76d6f8
SM
8778 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8779 New variables.
a4579d33
KB
8780 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8781 dumped emacs.
8782 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8783 in the static heap.
8784 [CYGWIN] (special_realloc): New function.
8785 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8786 requests to realloc storage in the static heap.
8787
3ebec551
PE
87882011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8789
8790 * bidi.c (bidi_initialize): Remove unused local.
8791
9fd8be00
EZ
87922011-08-15 Eli Zaretskii <eliz@gnu.org>
8793
6b02f655
SM
8794 * bidimirror.h:
8795 * biditype.h: Remove file.
8796 * makefile.w32-in ($(BLD)/bidi.$(O)):
8797 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8798
8799 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8800
8801 * chartab.c: Improve commentary for the uniprop_table API.
8802
32413314
EZ
8803 * bidi.c (bidi_paragraph_init): Support zero value of
8804 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8805 (bidi_initialize): Use uniprop_table instead of including
8806 biditype.h and bidimirror.h.
32413314 8807
9fd8be00
EZ
8808 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8809 coordinates of the iterator when restoring from ppos_it.
8810 (Bug#9296)
8811
5cf2b69b
KH
88122011-08-14 Kenichi Handa <handa@m17n.org>
8813
8814 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8815 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8816
daf17d00
EZ
88172011-08-14 Eli Zaretskii <eliz@gnu.org>
8818
8819 * xdisp.c (move_it_in_display_line_to): Don't invoke
8820 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8821 ppos_it. Fixes vertical cursor motion when line beginning is
8822 covered by an image. (Bug#9296)
8823
08e3161a
JD
88242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8825
8826 * nsterm.h (ns_run_ascript): Declare.
8827 (NSAPP_DATA2_RUNASSCRIPT): Define.
8828
8829 * nsfns.m (as_script, as_result, as_status): New static variables.
8830 (ns_run_ascript): New function.
5e617bc2 8831 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8832 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8833 the event loop. Get status from as_status (Bug#7276).
8834
8835 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8836 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8837 the event loop (Bug#7276).
8838
a3720aa2
AS
88392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8840
8841 * gnutls.c (QCgnutls_bootprop_priority)
8842 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8843 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8844 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8845 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8846 (QCgnutls_bootprop_verify_hostname_error)
8847 (QCgnutls_bootprop_callbacks_verify): Rename from
8848 Qgnutls_bootprop_..., all uses changed.
8849
8850 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8851 uses changed.
8852
0a0d27fb
PE
88532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8854
19d5c50c
PE
8855 * xfaces.c (Qframe_set_background_mode): Now static.
8856 * dispextern.h (Qframe_set_background_mode): Remove decl.
8857
0a0d27fb
PE
8858 * process.c (Fnetwork_interface_info): Declare local only if needed.
8859
377538cb
JD
88602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8861
8862 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8863 (Fnetwork_interface_list): Allocate in increments of bytes instead
8864 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8865 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8866 sockaddr.
8867 (struct ifflag_def): notrailers is smart on OSX.
8868 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8869 Get hardware address with getifaddrs if available.
8870
08fff70c
EZ
88712011-08-12 Eli Zaretskii <eliz@gnu.org>
8872
8873 * xdisp.c (iterate_out_of_display_property): xassert that
8874 IT->position is set to within IT->object's boundaries. Break from
8875 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8876 when IT->position is set up wrongly due to some bug.
8877 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8878 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8879 entry. Force push_it to save on the stack the current
8880 buffer/string position, to be restored by pop_it. Fix flags in
8881 the iterator structure wrt the object coming from a display
8882 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8883 properties. (Bug#9284)
8884
7be1c708 88852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8886
7be1c708
CY
8887 * fontset.c (fontset_get_font_group): Add proper type checks.
8888 (Bug#9172)
aac0c6e3 8889
7be1c708 88902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8891
7be1c708
CY
8892 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8893 and LC_VERSION_MIN_MACOSX.
8894 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8895 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8896
97bb72a6
EZ
88972011-08-08 Eli Zaretskii <eliz@gnu.org>
8898
8899 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8900 no-display-properties-and-no-overlays under bidi display.
8901 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8902 properties and overlays.
97bb72a6 8903
d5617611
CY
89042011-08-08 Chong Yidong <cyd@stupidchicken.com>
8905
37e11a63
CY
8906 * editfns.c (Fset_time_zone_rule): Document relationship with the
8907 setenv function.
8908
d5617611
CY
8909 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8910 the font entity extracted from the cache (Bug#8109).
8911
58872834
CY
89122011-08-07 Chong Yidong <cyd@stupidchicken.com>
8913
8914 * composite.c (autocmp_chars): Don't reset point. That is done by
8915 restore_point_unwind (Bug#5984).
8916
75bfc667
JL
89172011-08-07 Juri Linkov <juri@jurta.org>
8918
8919 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8920 to show the arg `TIME' instead of `TIMEVAL'.
8921
d1410150
EZ
89222011-08-06 Eli Zaretskii <eliz@gnu.org>
8923
8924 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8925 display property strides EOL and includes a newline, as in
8926 longlines-mode. (Bug#9254)
75b771e4
EZ
8927 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8928 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8929
8930 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8931 is non-zero, even if the data buffer is NULL. Fixes a crash in
8932 vertical-motion with longlines-mode. (Bug#9254)
8933
35928349
EZ
89342011-08-05 Eli Zaretskii <eliz@gnu.org>
8935
ec7cc85b
EZ
8936 * bidi.c <bidi_cache_total_alloc>: Now static.
8937 (bidi_initialize): Initialize bidi_cache_total_alloc.
8938
8b76d6f8 8939 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8940 cache. (Bug#9221)
8941
8942 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8943 amount allocated this far in `bidi_cache_total_alloc'.
8944 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8945 non-zero, only free the data buffer without restoring the cache
8946 contents. All callers changed.
8947
8948 * dispextern.h (bidi_unshelve_cache): Update prototype.
8949
8950 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8951 (move_it_in_display_line, move_it_to)
8952 (move_it_vertically_backward, move_it_by_lines): Replace the call
8953 to xfree to an equivalent call to bidi_unshelve_cache.
8954 (move_it_in_display_line_to): Fix logic of returning
412b6358 8955 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8956
e2e2423b
EZ
89572011-08-05 Eli Zaretskii <eliz@gnu.org>
8958
8959 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8960 came from a string character with a `cursor' property. (Bug#9229)
8961
ae9e757a
JD
89622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8963
8964 * Makefile.in (LIB_PTHREAD): New variable.
8965 (LIBES): Add LIB_PTHREAD (Bug#9216).
8966
8967 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8968 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8969
213bd7f2
AS
89702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8971
6b02f655 8972 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8973
99aaf75f
JD
89742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8975
8976 * xterm.c (x_find_topmost_parent): New function.
8977 (x_set_frame_alpha): Find topmost parent window with
8978 x_find_topmost_parent and set the property there also (bug#9181).
8979 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8980
c74e9d86
PE
89812011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8982
8983 * callproc.c (Fcall_process): Avoid vfork clobbering
8984 the local vars buffer, coding_systems, current_dir.
8985
640c8776
SM
89862011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8987
8988 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8989
f26d0e4c
PE
89902011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8991
8a10d76c
PE
8992 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8993 so that it is not optimized away.
8994
f26d0e4c
PE
8995 * xdisp.c (compute_display_string_pos): Remove unused local.
8996
55439c61
EZ
89972011-08-02 Eli Zaretskii <eliz@gnu.org>
8998
8999 Fix slow cursor motion and scrolling in large buffers with
9000 selective display, like Org Mode buffers. (Bug#9218)
9001
9002 * dispextern.h (struct bidi_it): New member disp_prop_p.
9003
9004 * xdisp.c: Remove one-slot cache of display string positions.
9005 (compute_display_string_pos): Accept an additional argument
5e617bc2 9006 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9007 for a display string or property. If found, set DISP_PROP_P
9008 non-zero.
9009
9010 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9011 DISP_PROP_P, and pass it to compute_display_string_pos.
9012 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9013 non-zero. All callers of bidi_fetch_char changed.
9014
fb33fa43
SM
90152011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9016
9017 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9018
b099e063
DM
90192010-12-03 Don March <don@ohspite.net>
9020
9021 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9022 last character M-[char] is translated to ESC [char] (bug#7541).
9023
5cc7f7af
KH
90242011-08-02 Kenichi Handa <handa@m17n.org>
9025
d0fffa3f 9026 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9027
9028 * chartab.c (uniprop_table): Make it non-static.
9029
525d5e6e
EZ
90302011-08-01 Eli Zaretskii <eliz@gnu.org>
9031
9032 * xdisp.c (forward_to_next_line_start): Accept additional argument
9033 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9034 on the newline.
9035 (reseat_at_next_visible_line_start): Use the bidi iterator state
9036 returned by forward_to_next_line_start to restore the state of
9037 it->bidi_it after backing up to previous newline. (Bug#9212)
9038
31011111
AS
90392011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9040
9041 * regex.c (re_comp): Protoize.
9042 (re_exec): Fix return type.
9043 (regexec): Fix type of `ret'. (Bug#9203)
9044
476371c4
PE
90452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9046
e5d76069
PE
9047 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9048 This is needed if max-image-size is a floating-point number.
9049
9a79b20c
AS
90502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9051
9052 * print.c (print_object): Print empty symbol as ##.
9053
9054 * lread.c (read1): Read ## as empty symbol.
9055
d8c2fa78
AA
90562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9057
9058 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9059 setting frame foreground color (Bug#9175).
9060 (x_set_background_color): Likewise.
9061
ffe57a7a
AA
9062 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9063 contents (Bug#9176).
9064 (EmacsTooltip -init): Remove bezels and add shadows to
9065 tooltip windows.
9066
bf3492a5
AA
9067 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9068 or scroll bar (Bug#8470).
9069
d55e9c53
AA
9070 * nsfont.m (nsfont_open): Remove assignment to voffset and
9071 unnecessary vars hshink, expand, hd, full_height, min_height.
9072 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9073
9074 * nsterm.h (nsfont_info): Remove voffset field.
9075
d8c2fa78 90762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9077
9078 Implement strike-through and overline on NextStep (Bug#8863).
9079
9080 * nsfont.m (nsfont_open): Use underline position provided by font,
9081 instead of hard-coded value of 2.
9082 (nsfont_draw): Call ns_draw_text_decoration instead.
9083
9084 * nsterm.h: Add declaration for ns_draw_text_decoration.
9085
9086 * nsterm.m (ns_draw_text_decoration): New function for drawing
9087 underline, overline, and strike-through.
9088 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9089 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9090 accommodate underlining, etc.
4843aac3 9091
4cc60b9b
EZ
90922011-07-28 Eli Zaretskii <eliz@gnu.org>
9093
bc7ece87
EZ
9094 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9095 default.
4cc60b9b 9096
476371c4
PE
90972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9098
66606eea
PE
9099 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9100 Without this fix, if a signal arrives just after memory fills up,
9101 'malloc' might be invoked reentrantly.
9102
476371c4
PE
9103 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9104 In other words, assume that every image size is allowed, on non-X
9105 hosts. This assumption is probably wrong, but it lets Emacs compile.
9106
f3fcc40d
AS
91072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9108
9109 * regex.c (re_iswctype): Convert return values to boolean.
9110
350c992f
EZ
91112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9112
9113 * xdisp.c (compute_display_string_pos): Don't use cached display
9114 string position if the buffer had its restriction changed.
9115 (Bug#9184)
9116
5266b4bb
PE
91172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9118
9119 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9120
2573a837 91212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9122
41f55ccd 9123 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9124
39e378da
PE
9125 * bidi.c: Integer size and overflow fixes.
9126 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9127 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9128 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9129 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9130 (bidi_find_other_level_edge):
9131 Use ptrdiff_t instead of EMACS_INT where either will do.
9132 This works better on 32-bit hosts configured --with-wide-int.
9133 (bidi_cache_ensure_space): Check for size-calculation overflow.
9134 Use % rather than repeated addition, for better worst-case speed.
9135 Don't set bidi_cache_size until after xrealloc returns, because it
9136 might not return.
9137 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9138 (bidi_cache_ensure_space): Also check that the bidi cache size
9139 does not exceed that of the largest Lisp string or buffer. See Eli
9140 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9141
5e927815
PE
9142 * alloc.c (__malloc_size_t): Remove.
9143 All uses replaced by size_t. See Andreas Schwab's note
9144 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9145
ca4aa935
PE
9146 * image.c: Improve checking for integer overflow.
9147 (check_image_size): Assume that f is nonnull, since
9148 it is always nonnull in practice. This is one less thing to
9149 worry about when checking for integer overflow later.
9150 (x_check_image_size): New function, which checks for integer
9151 overflow issues inside X.
9152 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9153 This removes the need for a memory_full check.
9154 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9155 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9156 (xbm_read_bitmap_data): Change locals back to 'int', since
9157 their values must fit in 'int'.
9158 (xpm_load_image, png_load, tiff_load):
9159 Invoke x_create_x_image_and_pixmap earlier,
9160 to avoid much needless work if the image is too large.
9161 (tiff_load): Treat overly large images as if
9162 x_create_x_image_and_pixmap failed, not as malloc failures.
9163 (gs_load): Use x_check_image_size.
9164
5f8f9cc2
PE
9165 * gtkutil.c: Omit integer casts.
9166 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9167 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9168
5adf60bc
PE
9169 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9170
c8907a93
PE
9171 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9172 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9173 would wrongly return t on a 64-bit host.
9174
e3c25c68
PE
9175 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9176 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9177 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9178 and therefore cause GCC to emit a bogus diagnostic in some cases.
9179
3f791afe
PE
9180 * image.c: Integer signedness and overflow and related fixes.
9181 This is not an exhaustive set of fixes, but it's time to
9182 record what I've got.
9183 (lookup_pixel_color, check_image_size): Remove redundant decls.
9184 (check_image_size): Don't assume that arbitrary EMACS_INT values
9185 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9186 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9187 (tiff_load, imagemagick_load_image):
9188 Check for overflow in size calculations.
9189 (x_create_x_image_and_pixmap): Remove unnecessary test for
9190 xmalloc returning NULL; that can't happen.
9191 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9192 (xpm_color_bucket): Use better integer hashing function.
9193 (xpm_cache_color): Don't possibly over-allocate memory.
9194 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9195 (gif_memory_source):
9196 Use ptrdiff_t, not int or size_t, to record sizes.
9197 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9198 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9199 either works, as we prefer signed integers.
9200 (tiff_read_from_memory, tiff_write_from_memory):
9201 Return tsize_t, not size_t, since that's what the TIFF API wants.
9202 (tiff_read_from_memory): Don't fail simply because the read would
9203 go past EOF; instead, return a short read.
9204 (tiff_load): Omit no-longer-needed casts.
9205 (Fimagemagick_types): Don't assume size fits into 'int'.
9206
3cc5a532
PE
9207 Improve hashing quality when configured --with-wide-int.
9208 * fns.c (hash_string): New function, taken from sxhash_string.
9209 Do not discard information about ASCII character case; this
9210 discarding is no longer needed.
9211 (sxhash-string): Use it. Change sig to match it. Caller changed.
9212 * lisp.h: Declare it.
9213 * lread.c (hash_string): Remove, since we now use fns.c's version.
9214 The fns.c version returns a wider integer if --with-wide-int is
9215 specified, so this should help the quality of the hashing a bit.
9216
b312a492
PE
9217 * emacs.c: Integer overflow minor fix.
9218 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9219 Define only if GNU_LINUX.
9220 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9221
dfd153ae
PE
9222 * dispnew.c: Integer signedness and overflow fixes.
9223 Remove unnecessary forward decls, that were a maintenance hassle.
9224 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9225 All uses changed.
9226 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9227 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9228 (prepare_desired_row, line_draw_cost):
9229 Use int, not unsigned, where either works.
9230 (save_current_matrix, restore_current_matrix):
9231 Use ptrdiff_t, not size_t, where either works.
9232 (init_display): Check for overflow more accurately, and without
9233 relying on undefined behavior.
9234
a81d11a3
PE
9235 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9236 Remove, replacing with the new symbols in lisp.h. All uses changed.
9237 * fileio.c (make_temp_name):
9238 * filelock.c (lock_file_1, lock_file):
9239 * xdisp.c (message_dolog):
9240 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9241 Use pMd etc. instead.
9242 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9243 replacing the pWIDE etc. symbols removed from editfns.c.
9244
3300e6fd
PE
9245 * keyboard.h (num_input_events): Now uintmax_t.
9246 This is (very slightly) less likely to mess up due to wraparound.
9247 All uses changed.
9248
fd05c7e9
PE
9249 * buffer.c: Integer signedness fixes.
9250 (alloc_buffer_text, enlarge_buffer_text):
9251 Use ptrdiff_t rather than size_t when either will do, as we prefer
9252 signed integers.
9253
903fe15d
PE
9254 * alloc.c: Integer signedness and overflow fixes.
9255 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9256 (__malloc_size_t): Default to size_t, not to int.
9257 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9258 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9259 Prefer ptrdiff_t to size_t when either would do, as we prefer
9260 signed integers.
9261 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9262 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9263 Now const. Initialize with values that are in range even if char
9264 is signed.
9265 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9266 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9267 These functions do the right thing with sizes > 2**32.
9268 (check_depth): Now ptrdiff_t, not int.
9269 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9270 Adjust to new way of storing sizes. Check for size overflow bugs
9271 in rest of code.
9272 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9273 slightly wrong anyway, as it missed one instance of
9274 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9275 (refill_memory_reserve): Omit needless cast to size_t.
9276 (mark_object_loop_halt): Mark as externally visible.
9277
ac82cc6a
PE
9278 * xselect.c: Integer signedness and overflow fixes.
9279 (Fx_register_dnd_atom, x_handle_dnd_message):
9280 Use ptrdiff_t, not size_t, since we prefer signed.
9281 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9282 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9283 x_dnd_atoms_size and x_dnd_atoms_length.
9284
c2d1e36d
PE
9285 * doprnt.c: Prefer signed to unsigned when either works.
9286 * eval.c (verror):
9287 * doprnt.c (doprnt):
9288 * lisp.h (doprnt):
9289 * xdisp.c (vmessage):
9290 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9291 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9292 prefer signed arithmetic to avoid comparison confusion.
9293 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9294 but is a bit tricky.
9295
0e926e56
PE
9296 Assume freestanding C89 headers, string.h, stdlib.h.
9297 * data.c, doprnt.c, floatfns.c, print.c:
9298 Include float.h unconditionally.
9299 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9300 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9301 * regex.c: Likewise for stddef.h, string.h.
9302 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9303 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9304 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9305 (STDC_HEADERS): Remove obsolete defines.
9306 * sysdep.c: Include limits.h unconditionally.
9307
9cfdb3ec
PE
9308 Assume support for memcmp, memcpy, memmove, memset.
9309 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9310 * regex.c (memcmp, memcpy):
9311 Remove; we assume C89 now.
9312
9313 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9314 (__malloc_safe_bcopy): Remove; no longer needed.
9315
cf950e6b 9316 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9317 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9318 well either way, and we prefer signed to unsigned.
9319
dbf38e02
LMI
93202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9321
9322 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9323 closes the connection while we're reading (bug#9182).
9324
d6f0886c 93252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9326
d6f0886c
JD
9327 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9328 are specified (Bug#9168).
24e0f6b1 9329
2eb1f9e6
PE
93302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9331
9332 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9333 Found by GCC static checking and --with-wide-int on a 32-bit host.
9334
22381272 93352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9336
9337 * xdisp.c (compute_display_string_pos): Fix logic of caching
9338 previous display string position. Initialize cached_prev_pos to
9339 -1. Fixes slow-down at the beginning of a buffer.
9340
f25e39b4
EZ
93412011-07-24 Eli Zaretskii <eliz@gnu.org>
9342
9343 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9344 for attrs[LFACE_FONTSET_INDEX].
9345
04c4b52e
PE
93462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9347
9348 * xml.c (parse_region): Remove unused local
9349 that was recently introduced.
9350
c1734fbd
EZ
93512011-07-23 Eli Zaretskii <eliz@gnu.org>
9352
be18c5a5
EZ
9353 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9354 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9355
c1734fbd
EZ
9356 * xdisp.c (move_it_in_display_line_to): Record the best matching
9357 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9358 exit if none of the characters scanned was an exact match.
9359 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9360 when exact match is impossible due to invisible text, and the
9361 lines are truncated.
9362
a258d627
JD
93632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9364
9365 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9366 for OSX >= 10.7.
9367
b6d5a689
EZ
93682011-07-22 Eli Zaretskii <eliz@gnu.org>
9369
0f74f785
EZ
9370 Fix a significant slow-down of cursor motion with C-n, C-p,
9371 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9372 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9373 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9374 (next_element_from_buffer): Call compute_stop_pos_backwards to
9375 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9376 base_level_stop.
9377 (reseat): Don't look for prev_stop, as that could mean a very long
9378 run.
9379 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9380 <cached_disp_overlay_modiff>: Cache for last found display string
9381 position.
551918c1 9382 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9383 about the same buffer in the same area of character positions, and
9384 the buffer wasn't changed since the time the display string
9385 position was cached.
551918c1 9386
b2d0c91a
EZ
93872011-07-22 Eli Zaretskii <eliz@gnu.org>
9388
9389 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9390 is an integer, which is important for empty lines. (Bug#9149)
9391
043604ee
CY
93922011-07-22 Chong Yidong <cyd@stupidchicken.com>
9393
9394 * frame.c (Fmodify_frame_parameters): In tty case, update the
9395 default face if necessary (Bug#4238).
9396
da4adb04
CY
93972011-07-21 Chong Yidong <cyd@stupidchicken.com>
9398
9399 * editfns.c (Fstring_to_char): No need to explain what a character
9400 is in the docstring (Bug#6576).
9401
9abd0532
LMI
94022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9403
9404 * xml.c (parse_region): Make sure we always return a tree.
9405
36881d16
HK
94062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9407
9408 * xml.c (parse_region): If a document contains only comments,
9409 return that, too.
9410
1e98674d
LMI
94112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9412
9413 * xml.c (make_dom): Return comments, too.
9414
590bd467
PE
94152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9416
9417 Port to OpenBSD.
9418 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9419 and the surrounding thread.
9420 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9421 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9422 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9423 timer goes off.
9424 * s/openbsd.h (BROKEN_SIGIO): Define.
9425 * unexelf.c (unexec) [__OpenBSD__]:
9426 Don't update the .mdebug section of the Alpha COFF symbol table.
9427
f41628b2
LMI
94282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9429
9430 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9431 (bug#8460).
9432
b59b67c5
PE
94332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9434
15e3a074
PE
9435 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9436 This fixes some race conditions on the permissions of any newly
9437 created file.
9438
41bed37d
PE
9439 * alloc.c (valid_pointer_p): Use pipe, not open.
9440 This fixes some permissions issues when debugging.
9441
b59b67c5
PE
9442 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9443 If fchown fails to set both uid and gid, try to set just gid,
9444 as that is sometimes allowed. Adjust the file's mode to eliminate
9445 setuid or setgid bits that are inappropriate if fchown fails.
9446
925a6be7
SM
94472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9448
9449 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9450 to compare Lisp_Objects.
9451 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9452 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9453 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9454
52968808
AS
94552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9456
0a6a104b
AS
9457 * lread.c (read_integer): Unread even EOF character.
9458 (read1): Likewise. Properly record start position of symbol.
9459
52968808
AS
9460 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9461 symbol character follows.
9462
9e381cdd
PE
94632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9464
9465 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9466 This works around a problem with the previous change to Fcopy_file.
9467 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9468 and without this change, GCC might complain about discarding
9469 fchown's return value.
9470
b5641435
JB
94712011-07-16 Juanma Barranquero <lekktu@gmail.com>
9472
9473 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9474
a8031457
PE
94752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9476
9477 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9478
dd889327
LMI
94792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9480
750c33f7
LMI
9481 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9482 it's used from the C level.
9483
dd889327
LMI
9484 * process.c: Use the same condition for POLL_FOR_INPUT in both
9485 keyboard.c and process.c (bug#1858).
9486
87e86684
LM
94872011-07-09 Lawrence Mitchell <wence@gmx.li>
9488
9489 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9490 (Fgnutls_boot): Use it.
9491
64348f40
AS
94922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9493
9494 * doc.c (Fsubstitute_command_keys): Revert last change.
9495
1d698799
LMI
94962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9497
f863868c
LMI
9498 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9499 quotes the next character, and doesn't affect other longer
9500 sequences (bug#8935).
9501
1d698799
LMI
9502 * lread.c (syms_of_lread): Clarify that is isn't only
9503 `eval-buffer' and `eval-defun' that's affected by
9504 `lexical-binding' (bug#8460).
9505
aa4b6df6
EZ
95062011-07-15 Eli Zaretskii <eliz@gnu.org>
9507
9508 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9509 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9510
5d856da6
PE
95112011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9512
ad6042bb
PE
9513 Fix minor problems found by static checking.
9514 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9515 (elsz): Now a signed constant, not a size_t var. We prefer signed
9516 types to unsigned, to avoid integer comparison confusion. Without
9517 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9518 "cannot optimize loop, the loop counter may overflow", a symptom
9519 of the confusion.
f00bbb22 9520 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9521 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9522
6468f31c
LMI
95232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9524
49080b10
LMI
9525 * search.c (Fre_search_backward): Mention `case-fold-search' in
9526 all the re_search_* functions (bug#8138).
9527
6468f31c
LMI
9528 * keyboard.c (Fopen_dribble_file): Document when the file is
9529 closed (bug#8056).
9530
c965adc5
EZ
95312011-07-14 Eli Zaretskii <eliz@gnu.org>
9532
df9733bf
EZ
9533 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9534 bidi_cache_idx.
9535
0bb23927
EZ
9536 Support bidi reordering of display and overlay strings.
9537 * xdisp.c (compute_display_string_pos)
9538 (compute_display_string_end): Accept additional argument STRING.
9539 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9540 (reseat_to_string): Initialize bidi_it->string.s and
9541 bidi_it->string.schars.
9542 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9543 NULL (avoids a crash in bidi_paragraph_init).
9544 Initialize itb.string.lstring.
0bb23927
EZ
9545 (init_iterator): Call bidi_init_it only of a valid
9546 buffer position was specified. Initialize paragraph_embedding to
9547 L2R.
9548 (reseat_to_string): Initialize the bidi iterator.
9549 (display_string): If we need to ignore text properties of
9550 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9551 original value of -1 will not work with bidi.)
9552 (compute_display_string_pos): First arg is now struct
9553 `text_pos *'; all callers changed. Support display properties on
9554 Lisp strings.
9555 (compute_display_string_end): Support display properties on Lisp
9556 strings.
9557 (init_iterator, reseat_1, reseat_to_string): Initialize the
9558 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9559 when iterating on a string not from display properties).
640c8776
SM
9560 (compute_display_string_pos, compute_display_string_end):
9561 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9562 arrow keys.
9563 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9564 base_level_stop; instead, set base_level_stop to BEGV.
9565 Fixes crashes in vertical-motion.
0bb23927
EZ
9566 (next_element_from_buffer): Improve commentary for when
9567 the iterator is before prev_stop.
9568 (init_iterator): Initialize bidi_p from the default value of
9569 bidi-display-reordering, not from buffer-local value. Use the
9570 buffer-local value only if initializing for buffer iteration.
9571 (handle_invisible_prop): Support invisible properties on strings
9572 that are being bidi-reordered.
9573 (set_iterator_to_next): Support bidi reordering of C strings and
9574 Lisp strings.
9575 (next_element_from_string): Support bidi reordering of Lisp
9576 strings.
9577 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9578 (display_string): Support display of R2L glyph rows.
9579 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9580 (init_iterator): Don't initialize it->bidi_p for strings
9581 here.
9582 (reseat_to_string): Initialize it->bidi_p for strings here.
9583 (next_element_from_string, next_element_from_c_string)
9584 (next_element_from_buffer): Add xassert's for correspondence
9585 between IT's object being iterated and it->bidi_it.string
9586 structure.
9587 (face_before_or_after_it_pos): Support bidi iteration.
9588 (next_element_from_c_string): Handle the case of the first string
9589 character that is not the first one in the visual order.
9590 (get_visually_first_element): New function, refactored from common
9591 parts of next_element_from_buffer, next_element_from_string, and
9592 next_element_from_c_string.
9593 (tool_bar_lines_needed, redisplay_tool_bar)
9594 (display_menu_bar): Force left-to-right direction. Add a FIXME
9595 comment for making that be controlled by a user option.
9596 (push_it, pop_it): Save and restore the state of the
9597 bidi iterator. Save and restore the bidi_p flag.
9598 (pop_it): Iterate out of display property for string iteration as
9599 well.
9600 (iterate_out_of_display_property): Support iteration over strings.
9601 (handle_single_display_spec): Set up it->bidi_it for iteration
9602 over a display string, and call bidi_init_it.
9603 (handle_single_display_spec, next_overlay_string)
9604 (get_overlay_strings_1, push_display_prop): Set up the bidi
9605 iterator for displaying display or overlay strings.
9606 (forward_to_next_line_start): Don't use the shortcut if
9607 bidi-iterating.
9608 (back_to_previous_visible_line_start): If handle_display_prop
9609 pushed the iterator stack, restore the internal state of the bidi
9610 iterator by calling bidi_pop_it same number of times.
9611 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9612 and we are bidi-iterating, don't decrement the iterator position;
9613 instead, set the first_elt flag in the bidi iterator, to produce
9614 the same effect.
9615 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9616 (push_display_prop): xassert that we are iterating a buffer.
9617 (push_it, pop_it): Save and restore paragraph_embedding member.
9618 (handle_single_display_spec, next_overlay_string)
9619 (get_overlay_strings_1, reseat_1, reseat_to_string)
9620 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9621 correctly. Don't assume unibyte strings are not bidi-reordered.
9622 (compute_display_string_pos)
9623 (compute_display_string_end): Fix handling the case of C string.
9624 (push_it, pop_it): Save and restore from_disp_prop_p.
9625 (handle_single_display_spec, push_display_prop): Set the
9626 from_disp_prop_p flag.
9627 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9628 (pop_it): Call iterate_out_of_display_property only if we are
9629 popping after iteration over a string that came from a display
9630 property. Fix a typo in popping stretch info. Add an assertion
9631 for verifying that the iterator position is in sync with the bidi
9632 iterator.
9633 (handle_single_display_spec, get_overlay_strings_1)
9634 (push_display_prop): Fix initialization of paragraph direction for
9635 string when that of the parent object is not yet determined.
9636 (reseat_1): Call bidi_init_it to resync the bidi
9637 iterator with IT's position. (Bug#7616)
9638 (find_row_edges): If ROW->start.pos gives position
9639 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9640 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9641 Reset the from_disp_prop_p flag.
9642 (SAVE_IT, RESTORE_IT): New macros.
9643 (pos_visible_p, face_before_or_after_it_pos)
9644 (back_to_previous_visible_line_start)
9645 (move_it_in_display_line_to, move_it_in_display_line)
9646 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9647 (try_scrolling, redisplay_window, display_line): Use them when
9648 saving a temporary copy of the iterator and restoring it back.
9649 (back_to_previous_visible_line_start, reseat_1)
9650 (init_iterator): Empty the bidi cache "stack".
9651 (move_it_in_display_line_to): If iterator ended up at
9652 EOL, but we never saw any buffer positions smaller than
9653 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9654 motion in bidi-reordered lines.
9655 (move_it_in_display_line_to): Record prev_method and prev_pos
9656 immediately before the call to set_iterator_to_next. Fixes cursor
9657 motion in bidi-reordered lines with stretch glyphs and strings
9658 displayed in margins. (Bug#8133) (Bug#8867)
9659 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9660 TO_CHARPOS.
640c8776
SM
9661 (pos_visible_p): Support positions in bidi-reordered lines.
9662 Save and restore bidi cache.
0bb23927
EZ
9663
9664 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9665 (bidi_paragraph_info): Delete unused struct.
9666 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9667 (bidi_cache_start): New variable.
9668 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9669 to zero.
9670 (bidi_cache_fetch_state, bidi_cache_search)
9671 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9672 (bidi_cache_find, bidi_peek_at_next_level)
9673 (bidi_level_of_next_char, bidi_find_other_level_edge)
9674 (bidi_move_to_visually_next): Compare cache index with
9675 bidi_cache_start rather than with zero.
9676 (bidi_fetch_char): Accept new argument STRING; all callers
9677 changed. Support iteration over a string. Support strings with
9678 display properties. Support unibyte strings. Fix the type of
9679 `len' according to what STRING_CHAR_AND_LENGTH expects.
9680 (bidi_paragraph_init, bidi_resolve_explicit_1)
9681 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9682 (bidi_level_of_next_char, bidi_move_to_visually_next):
9683 Support iteration over a string.
0bb23927
EZ
9684 (bidi_set_sor_type, bidi_resolve_explicit_1)
9685 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9686 can now be zero (for strings); special values 0 and -1 were
9687 changed to -1 and -2, respectively.
9688 (bidi_char_at_pos): New function.
9689 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9690 Call it instead of FETCH_MULTIBYTE_CHAR.
9691 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9692 initialized to valid values.
9693 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9694 values.
9695 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9696 the test for valid cached positions. Fix the logic for looking up
9697 the sentinel state in the cache. GCPRO the Lisp string we are
9698 iterating.
9699 (bidi_push_it, bidi_pop_it): New functions.
9700 (bidi_initialize): Initialize the bidi cache start stack pointer.
9701 (bidi_cache_ensure_space): New function, refactored from part of
9702 bidi_cache_iterator_state. Don't assume the required size is just
9703 one BIDI_CACHE_CHUNK away.
9704 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9705 (bidi_count_bytes, bidi_char_at_pos): New functions.
9706 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9707 always valid if bidi_cache_idx is valid.
9708 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9709 is valid if it's going to be used.
9710 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9711 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9712 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9713 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9714 (bidi_find_other_level_edge, bidi_cache_start_stack):
9715 All variables related to cache indices are now EMACS_INT.
c965adc5 9716
0bb23927
EZ
9717 * dispextern.h (struct bidi_string_data): New structure.
9718 (struct bidi_it): New member `string'. Make flag members be 1-bit
9719 fields, and put them last in the struct.
640c8776
SM
9720 (compute_display_string_pos, compute_display_string_end):
9721 Update prototypes.
0bb23927
EZ
9722 (bidi_push_it, bidi_pop_it): Add prototypes.
9723 (struct iterator_stack_entry): New members bidi_p,
9724 paragraph_embedding, and from_disp_prop_p.
9725 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9726 (bidi_shelve_cache, bidi_unshelve_cache):
9727 Declare prototypes.
0bb23927
EZ
9728
9729 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9730 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9731 and vector-like objects.
9732
9733 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9734 cache around display iteration.
9735
9736 * window.c (Fwindow_end, window_scroll_pixel_based)
9737 (displayed_window_lines, Frecenter): Save and restore the bidi
9738 cache around display iteration.
9739
3bbd2265
LMI
97402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9741
9742 * editfns.c (Fdelete_region): Clarify the use of the named
9743 parameters (bug#6788).
9744
adc47434
MR
97452011-07-14 Martin Rudalics <rudalics@gmx.at>
9746
9747 * indent.c (Fvertical_motion): Set and restore w->pointm when
9748 saving and restoring the window's buffer (Bug#9006).
9749
837c31f8
LMI
97502011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9751
9752 * editfns.c (Fstring_to_char): Clarify just what is returned
9753 (bug#6576). Text by Eli Zaretskii.
9754
ac389d0c
JB
97552011-07-13 Juanma Barranquero <lekktu@gmail.com>
9756
9757 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9758
0be0ce47
EZ
97592011-07-13 Eli Zaretskii <eliz@gnu.org>
9760
9761 * buffer.c (mmap_find): Fix a typo.
9762
cd18e7e3
JB
97632011-07-13 Johan Bockgård <bojohan@gnu.org>
9764
9765 Fix execution of x selection hooks.
9766 * xselect.c (Qx_lost_selection_functions)
9767 (Qx_sent_selection_functions): New vars.
9768 (syms_of_xselect): DEFSYM them.
9769 (x_handle_selection_request): Pass Qx_sent_selection_functions
9770 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9771 (x_handle_selection_clear,x_clear_frame_selections):
9772 Pass Qx_lost_selection_functions rather than
9773 Vx_lost_selection_functions to Frun_hook_with_args.
9774
47ea7f44
PE
97752011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9776
ac389d0c 9777 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9778 The old code sometimes used this field without initializing it.
9779
47ea7f44
PE
9780 * alloc.c (gc_sweep): Don't read past end of array.
9781 In theory, the old code could also have corrupted Emacs internals,
9782 though it'd be very unlikely.
9783
bc985c87
AS
97842011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9785
9786 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9787 argument. (Bug#4026)
bc985c87 9788
0cf34688
LMI
97892011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9790
b3dadd76
LMI
9791 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9792 key" (bug#4257).
9793
0cf34688
LMI
9794 * window.c (Fset_window_start): Doc fix (bug#4199).
9795 (Fset_window_hscroll): Ditto.
9796
270768cd
PE
97972011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9798
077e3dda 9799 Fix minor new problems caught by GCC 4.6.1.
270768cd 9800 * term.c (init_tty): Remove unused local.
490011a6 9801 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9802 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9803 not used otherwise.
270768cd 9804
b1f58454
CY
98052011-07-12 Chong Yidong <cyd@stupidchicken.com>
9806
9807 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9808
22b9578d
LMI
98092011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9810
6e70ab07
LMI
9811 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9812 are the mini-buffer and the echo area (bug#3320).
9813
22b9578d
LMI
9814 * term.c (init_tty): Remove support for supdup, c10 and perq
9815 terminals, which are no longer supported (bug#1482).
9816
8974cc9f
JB
98172011-07-10 Johan Bockgård <bojohan@gnu.org>
9818
9819 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9820
a560d974
JD
98212011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9822
9823 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9824 for non-popups (Bug#3642).
9825
1dae0f0a
AS
98262011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9827
268c2c36 9828 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9829 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9830 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9831 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9832 * data.c (fmod): Likewise.
9833 * dispnew.c (swap_glyphs_in_rows): Likewise.
9834 * emacs.c (memory_warning_signal): Likewise.
9835 * floatfns.c (float_error): Likewise.
9836 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9837 (otf_open, font_otf_capability, generate_otf_features)
9838 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9839 Likewise.
9840 * image.c (pbm_read_file): Likewise.
9841 * indent.c (string_display_width): Likewise.
9842 * intervals.c (check_for_interval, search_for_interval)
9843 (inc_interval_count, count_intervals, root_interval)
9844 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9845 * lread.c (defalias): Likewise.
268c2c36 9846 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9847 * regex.c (set_image_of_range_1, set_image_of_range)
9848 (regex_grow_registers): Likewise.
9849 * sysdep.c (strerror): Likewise.
9850 * termcap.c (valid_filename_p, tprint, main): Likewise.
9851 * tparam.c (main): Likewise.
9852 * unexhp9k800.c (run_time_remap, save_data_space)
9853 (update_file_ptrs, read_header, write_header, calculate_checksum)
9854 (copy_file, copy_rest, display_header): Likewise.
9855 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9856 Likewise.
9857 * xdisp.c (check_it): Likewise.
9858 * xfaces.c (register_color, unregister_color, unregister_colors):
9859 Likewise.
9860 * xfns.c (print_fontset_result): Likewise.
9861 * xrdb.c (member, fatal, main): Likewise.
9862
99033785
PE
98632011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9864
9865 Fix minor problems found by static checking (Bug#9031).
9866 * chartab.c (char_table_set_range, map_sub_char_table):
9867 Remove unused locals.
9868 (uniprop_table): Now static.
9869 * composite.c (_work_char): Remove unused static var.
9870
9cb2ac56
JB
98712011-07-09 Juanma Barranquero <lekktu@gmail.com>
9872
9873 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9874
f25661f0
JD
98752011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9876
9877 * gtkutil.c (qttip_cb): Remove code without function.
9878
8278c4fe
EZ
98792011-07-09 Eli Zaretskii <eliz@gnu.org>
9880
9881 * w32.c (pthread_sigmask): New stub.
9882
1692ae2d 98832011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9884
8a6ebd58 9885 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9886 sigprocmask is portable only for single-threaded applications, and
9887 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9888 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9889 (LIBES): Use it.
9890 * callproc.c (Fcall_process):
9891 * process.c (create_process):
9892 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9893 Use pthread_sigmask, not sigprocmask.
123403e4 9894
1b854618
JD
98952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9896
9897 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9898 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9899 wrong (Bug#8591).
9900
3fe4b549
JD
99012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9902
0ce7e563
JD
9903 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9904 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9905 (xg_hide_tooltip): Fix comment.
9906
3fe4b549
JD
9907 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9908 in registerServicesMenuSendTypes.
9909 (validRequestorForSendType): Don't check ns_return_types.
9910
9911 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9912 ns_return_type.
9913
5df75e47
JR
99142011-07-08 Jason Rumney <jasonr@gnu.org>
9915
22610910
JR
9916 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9917 SH_SHOW for hidden windows (Bug#5482).
9918
5df75e47
JR
9919 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9920 frame struct members of non-existent frames (Bug#6284).
9921
699c10bd
JD
99222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9923
4393663b
JD
9924 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9925 variable firstTime not needed on OSX >= 10.6.
9926 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9927 >= 10.5. Use setKnobProportion, setDoubleValue.
9928
9929 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9930 (MAC_OS_X_VERSION_10_5): Define if not defined.
9931 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9932 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9933 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9934
9935 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9936 cString and lossyCString on OSX >= 10.4.
4393663b 9937
58179cce 9938 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9939 sizeToFit on OSX >= 10.2.
9940
9941 * nsimage.m (allocInitFromFile): Don't use deprecated method
9942 bestRepresentationForDevice on OSX >= 10.6.
9943
9944 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9945 to avoid warning.
9946
9947 * emacs.c: Declare unexec_init_emacs_zone.
9948
a63e0781
JD
9949 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9950
699c10bd
JD
9951 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9952
9953 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9954 on svcsMenu (Bug#8842).
9955
9956 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9957 ns_return_types.
9958 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9959
9960 * nsterm.m (QUTF8_STRING): Declare.
9961 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9962 (validRequestorForSendType): Return type is (id).
9963 Change indexOfObjectIdenticalTo to indexOfObject.
9964 Check if we have local selection before returning self (Bug#8842).
9965 (writeSelectionToPasteboard): Put local selection into paste board
9966 if we have a local selection (Bug#8842).
9967 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9968
9969 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9970 (ns_get_local_selection): Declare.
9971
54e10184
LMI
99722011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9973
9888ff71
LMI
9974 * keymap.c (describe_map_tree): Don't insert a double newline at
9975 the end of the buffer (bug#1169) and return whether we inserted
9976 something.
9977
54e10184
LMI
9978 * callint.c (Fcall_interactively): Change "reading args" to
9979 "providing args" to try to clarify what it does (bug#1010).
9980
15fa4783
KH
99812011-07-07 Kenichi Handa <handa@m17n.org>
9982
9983 * composite.c (composition_compute_stop_pos): Ignore a static
9984 composition starting before CHARPOS (Bug#8915).
9985
9986 * xdisp.c (handle_composition_prop): Likewise.
9987
a8815b00
EZ
99882011-07-07 Eli Zaretskii <eliz@gnu.org>
9989
9990 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9991 (Bug#9015)
9992
ef7b981d 99932011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9994
9995 * character.h (unicode_category_t): New enum type.
9996
9997 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9998 (Qchar_code_property_table): New variable.
9999 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10000 (UNIPROP_COMPRESSED_FORM_P): New macros.
10001 (char_table_ascii): Uncompress the compressed values.
10002 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10003 Uncompress the compressed values.
ac389d0c 10004 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10005 (char_table_ref_and_range): Uncompress the compressed values.
10006 (sub_char_table_set): New arg is_uniprop. Callers changed.
10007 Uncompress the compressed values.
10008 (sub_char_table_set_range): Args changed. Callers changed.
10009 (char_table_set_range): Adjuted for the above change.
10010 (map_sub_char_table): Delete args default_val and parent. Add arg
10011 top. Give decoded values to a Lisp function.
640c8776 10012 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10013 values to a Lisp function. Gcpro more variables.
10014 (uniprop_table_uncompress)
10015 (uniprop_decode_value_run_length): New functions.
10016 (uniprop_decoder, uniprop_decoder_count): New variables.
10017 (uniprop_get_decoder, uniprop_encode_value_character)
10018 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10019 New functions.
10020 (uniprop_encoder, uniprop_encoder_count): New variables.
10021 (uniprop_get_encoder, uniprop_table)
10022 (Funicode_property_table_internal, Fget_unicode_property_internal)
10023 (Fput_unicode_property_internal): New functions.
10024 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10025 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10026 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10027 char-code-property-alist.
10028
640c8776 10029 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10030 Vunicode_category_table.
10031
640c8776 10032 * font.c (font_range): Adjust for the change of
c805dec0
KH
10033 Vunicode_category_table.
10034
76b397fb
DN
100352011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10036
10037 * m/iris4d.h: Remove file, move contents ...
10038 * s/irix6-5.h: ... here.
10039
22b4128e
PE
100402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10041
10042 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10043 * alloc.c (mark_buffer):
10044 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10045 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10046 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10047 This isn't true in general, and it's particularly not true
10048 if Emacs is configured with --with-wide-int.
10049 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10050 New macros, used in the buffer.c change.
10051
869795d6
JD
100522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10053
10054 * xsettings.c: Use both GConf and GSettings if both are available.
10055 (store_config_changed_event): Add comment.
10056 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10057 (store_tool_bar_style_changed): New functions.
5e617bc2 10058 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10059 (struct xsettings): Move font inside HAVE_XFT.
10060 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10061 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10062 Move inside HAVE_XFT.
640c8776 10063 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10064 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10065 also.
10066 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10067 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10068 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10069 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10070 (parse_settings): Move check for font inside HAVE_XFT.
10071 (read_settings, apply_xft_settings): Add comment.
10072 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10073 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10074 call store_font_name_changed.
10075 (xft_settings_event): Add comment.
10076 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10077 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10078 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10079 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10080 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10081 (xsettings_get_system_font, xsettings_get_system_normal_font):
10082 Add comment.
869795d6 10083
d8ed26bd
PE
100842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10085
10086 Random fixes. E.g., (random) never returned negative values.
10087 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10088 subseconds part to the entropy, as that's a bit more random.
10089 Prefer signed to unsigned, since the signedness doesn't matter and
10090 in general we prefer signed. When given a limit, use a
10091 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10092 latter isn't right if USE_2_TAGS_FOR_INTS.
10093 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10094 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10095
cabf1cac
SM
100962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10097
10098 * textprop.c (text_property_stickiness):
10099 Obey Vtext_property_default_nonsticky.
10100 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10101 * w32fns.c (syms_of_w32fns):
10102 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10103
6e9b2be9
PE
101042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10105
10106 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10107 This is more efficient than Ffile_directory_p and avoids a minor race.
10108
90186c68
LMI
101092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10110
7c301272
LMI
10111 * buffer.c (Foverlay_put): Say what the return value is
10112 (bug#7835).
10113
c4f2d8d4
LMI
10114 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10115 is a directory before asking whether to use the file name
10116 (bug#7564).
ad637907
LMI
10117 (barf_or_query_if_file_exists): Make the "File is a directory"
10118 error be more correct.
c4f2d8d4 10119
90186c68
LMI
10120 * fns.c (Frequire): Remove the mention of the .gz files, since
10121 that's installation-specific, but keep the mention of
10122 `get-load-suffixes'.
10123
da64016e
PE
101242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10125
10126 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10127 Report string overflow if the output is too long.
10128
7d47b580
JB
101292011-07-04 Juanma Barranquero <lekktu@gmail.com>
10130
a555cb87
JB
10131 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10132 (syms_of_gnutls): Remove duplicate DEFSYM for
10133 Qgnutls_bootprop_verify_hostname_error, an error for
10134 Qgnutls_bootprop_verify_error (which is no longer used).
10135
7d47b580
JB
10136 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10137 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10138 Also (re)move comments that are misplaced or no longer relevant.
10139
1e49bfab
LMI
101402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10141
10142 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10143
1485f4c0
CY
101442011-07-03 Chong Yidong <cyd@stupidchicken.com>
10145
10146 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10147 and background color parameters if they have been changed.
10148
a9ab721e
LMI
101492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10150
10151 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10152
cf7cff57
PE
101532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10154
2e13213d
PE
10155 * xsettings.c (SYSTEM_FONT): Define only when used.
10156 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10157
cf7cff57
PE
10158 * keymap.c (access_keymap_1): Now static.
10159
7a8e04f7
CY
101602011-07-02 Chong Yidong <cyd@stupidchicken.com>
10161
10162 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10163 leave any prefix arg for the up event (Bug#1586).
10164
61352f62
LMI
101652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10166
69bb1ef7
LMI
10167 * lread.c (syms_of_lread): Mention single symbols defined by
10168 `defvar' or `defconst' (bug#7154).
10169
61352f62 10170 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10171 (Frequire): Mention get-load-suffixes.
61352f62 10172
28545e04
MR
101732011-07-02 Martin Rudalics <rudalics@gmx.at>
10174
10175 * window.h (window): Remove clone_number slot.
10176 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10177 Remove.
10178 (make_parent_window, make_window, saved_window)
10179 (Fset_window_configuration, save_window_save): Don't deal with
10180 clone numbers.
10181 * buffer.c (Qclone_number): Remove declaration.
10182 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10183
3349e122
SM
101842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10185
10186 Add multiple inheritance to keymaps.
10187 * keymap.c (Fmake_composed_keymap): New function.
10188 (Fset_keymap_parent): Simplify.
10189 (fix_submap_inheritance): Remove.
10190 (access_keymap_1): New function extracted from access_keymap to handle
10191 embedded parents and handle lists of maps.
10192 (access_keymap): Use it.
10193 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10194 (Fcopy_keymap): Handle embedded parents.
10195 (Fcommand_remapping, define_as_prefix): Simplify.
10196 (Fkey_binding): Simplify.
10197 (syms_of_keymap): Move minibuffer-local-completion-map,
10198 minibuffer-local-filename-completion-map,
10199 minibuffer-local-must-match-map, and
10200 minibuffer-local-filename-must-match-map to Elisp.
10201 (syms_of_keymap): Defsubr make-composed-keymap.
10202 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10203 (parse_menu_item): Trivial simplification.
10204
3279eb87
GM
102052011-07-01 Glenn Morris <rgm@gnu.org>
10206
10207 * Makefile.in (SETTINGS_LIBS): Fix typo.
10208
39cb9e56 102092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10210
10211 * coding.c (Fencode_coding_string): Record the last coding system
10212 used, as the function doc string says (bug#8738).
10213
0949d2b6
JD
102142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10215
10216 * xsettings.c (store_monospaced_changed): Take new font as arg and
10217 check for change against current_mono_font.
10218 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10219 (emacs_settings_constructor, emacs_settings_get_property)
10220 (emacs_settings_set_property, emacs_settings_class_init)
10221 (emacs_settings_init, gsettings_obj): Remove.
10222 (something_changedCB): New function for HAVE_GSETTINGS.
10223 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10224 with value as argument.
10225 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10226 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10227 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10228 "changed".
10229
10230 * xgselect.c: Add defined (HAVE_GSETTINGS).
10231 (xgselect_initialize): Ditto.
10232
10233 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10234 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10235 xg_select.
10236
bbc6b304
PE
102372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10238
10239 * eval.c (struct backtrace): Simplify and port the data structure.
10240 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10241 signed bit field, as this assumption is not portable and it makes
10242 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10243 "char debug_on_exit : 1" as this is not portable either; instead,
10244 use the portable "unsigned int debug_on_exit : 1". Remove unused
10245 member evalargs. Remove obsolete comments about cc bombing out.
10246
9851bfc5
JD
102472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10248
51bb811f 10249 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10250 Let HAVE_GSETTINGS override HAVE_GCONF.
10251 (store_monospaced_changed): New function.
10252 (EMACS_SETTINGS): A new type derived from GObject to handle
10253 GSettings notifications.
10254 (emacs_settings_constructor, emacs_settings_get_property)
10255 (emacs_settings_set_property, emacs_settings_class_init):
10256 New functions.
10257 (gsettings_client, gsettings_obj): New variables.
10258 (GSETTINGS_SCHEMA): New define.
10259 (something_changedCB): Call store_monospaced_changed.
10260 (init_gsettings): New function.
10261 (xsettings_initialize): Call init_gsettings.
10262 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10263 to NULL.
10264
640c8776 10265 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10266 GCONF_CFLAGS/LIBS.
10267
5386012d
MR
102682011-06-29 Martin Rudalics <rudalics@gmx.at>
10269
10270 * window.c (resize_root_window, grow_mini_window)
10271 (shrink_mini_window): Rename Qresize_root_window to
10272 Qwindow_resize_root_window and Qresize_root_window_vertically to
10273 Qwindow_resize_root_window_vertically.
10274
f13e0b08
PE
102752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10276
10277 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10278
94515237
JB
102792011-06-27 Juanma Barranquero <lekktu@gmail.com>
10280
10281 * makefile.w32-in: Redesign dependencies so they reflect more
10282 clearly which files are directly included by each source file,
10283 and not through other includes.
10284
e43b6e43
MR
102852011-06-27 Martin Rudalics <rudalics@gmx.at>
10286
10287 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10288 (sort_overlays, overlay_strings): When an overlay's clone number
10289 matches the window's clone number process the overlay even if
10290 the overlay's window property doesn't match the current window.
10291
d68443dc
MR
10292 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10293 (Fwindow_hchild): Rename to Fwindow_left_child.
10294 (Fwindow_next): Rename to Fwindow_next_sibling.
10295 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10296 (resize_window_check): Rename to window_resize_check.
10297 (resize_window_apply): Rename to window_resize_apply.
10298 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10299 (Fdelete_other_windows_internal, resize_frame_windows)
10300 (Fsplit_window_internal, Fdelete_window_internal)
10301 (grow_mini_window, shrink_mini_window)
10302 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10303
c7e73be5
JD
103042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10305
10306 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10307 (emacs_fixed_set_min_size): Remove.
10308 (emacs_fixed_new): Take frame as argument.
10309
10310 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10311 (_EmacsFixedPrivate): Remove minwidth/height.
10312 Add struct frame *f.
10313 (emacs_fixed_init): Initialize priv->f.
10314 (get_parent_class, emacs_fixed_set_min_size): Remove.
10315 (emacs_fixed_new): Set priv->f to argument.
10316 (emacs_fixed_get_preferred_width)
10317 (emacs_fixed_get_preferred_height): Use min_width/height from
10318 frames size_hint to set minimum and natural (Bug#8919).
10319 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10320 and use min_width/height from frames size_hint to set
10321 min_width/height (Bug#8919).
10322
10323 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10324 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10325 Fix indentation.
c7e73be5 10326
cf99dcf8
EZ
103272011-06-26 Eli Zaretskii <eliz@gnu.org>
10328
10329 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10330 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10331 called at ZV.
10332
029529ac
CY
103332011-06-26 Chong Yidong <cyd@stupidchicken.com>
10334
10335 * process.c (wait_reading_process_output): Bypass select if
10336 waiting for a cell while ignoring keyboard input, and input is
10337 pending. Suggested by Jan Djärv (Bug#8869).
10338
7a7ef429
PE
103392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10340
10341 Use gnulib's dup2 module instead of rolling our own.
10342 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10343
11fdef7d 103442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10345
10346 * dispnew.c (scrolling_window): Before scrolling, turn off a
10347 mouse-highlight in the window being scrolled.
10348
cd3520a4
JB
103492011-06-24 Juanma Barranquero <lekktu@gmail.com>
10350
10351 Move DEFSYM to lisp.h and use everywhere.
10352
10353 * character.h (DEFSYM): Move declaration...
10354 * lisp.h (DEFSYM): ...here.
10355
10356 * gnutls.c:
10357 * minibuf.c:
10358 * w32menu.c:
10359 * w32proc.c:
10360 * w32select.c: Don't include character.h.
10361
10362 * alloc.c (syms_of_alloc):
10363 * buffer.c (syms_of_buffer):
10364 * bytecode.c (syms_of_bytecode):
10365 * callint.c (syms_of_callint):
10366 * casefiddle.c (syms_of_casefiddle):
10367 * casetab.c (init_casetab_once):
10368 * category.c (init_category_once, syms_of_category):
10369 * ccl.c (syms_of_ccl):
10370 * cmds.c (syms_of_cmds):
10371 * composite.c (syms_of_composite):
10372 * dbusbind.c (syms_of_dbusbind):
10373 * dired.c (syms_of_dired):
10374 * dispnew.c (syms_of_display):
10375 * doc.c (syms_of_doc):
10376 * editfns.c (syms_of_editfns):
10377 * emacs.c (syms_of_emacs):
10378 * eval.c (syms_of_eval):
10379 * fileio.c (syms_of_fileio):
10380 * fns.c (syms_of_fns):
10381 * frame.c (syms_of_frame):
10382 * fringe.c (syms_of_fringe):
10383 * insdel.c (syms_of_insdel):
10384 * keymap.c (syms_of_keymap):
10385 * lread.c (init_obarray, syms_of_lread):
10386 * macros.c (syms_of_macros):
10387 * msdos.c (syms_of_msdos):
10388 * print.c (syms_of_print):
10389 * process.c (syms_of_process):
10390 * search.c (syms_of_search):
10391 * sound.c (syms_of_sound):
10392 * syntax.c (init_syntax_once, syms_of_syntax):
10393 * terminal.c (syms_of_terminal):
10394 * textprop.c (syms_of_textprop):
10395 * undo.c (syms_of_undo):
10396 * w32.c (globals_of_w32):
10397 * window.c (syms_of_window):
10398 * xdisp.c (syms_of_xdisp):
10399 * xfaces.c (syms_of_xfaces):
10400 * xfns.c (syms_of_xfns):
10401 * xmenu.c (syms_of_xmenu):
10402 * xsettings.c (syms_of_xsettings):
10403 * xterm.c (syms_of_xterm): Use DEFSYM.
10404
4228cf16
TZ
104052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10406
cd3520a4 10407 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10408
7fcccf1e
PE
104092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10410
7efb4e0e
PE
10411 Integer and buffer overflow fixes (Bug#8873).
10412
ff5844ad
PE
10413 * print.c (printchar, strout): Check for string overflow.
10414 (PRINTPREPARE, printchar, strout):
10415 Don't set size unless allocation succeeds.
10416
90532f02
PE
10417 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10418 for sizes. Check for string overflow more accurately.
10419 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10420
6d84508d
PE
10421 * macros.c: Integer and buffer overflow fixes.
10422 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10423 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10424 Use ptrdiff_t, not int, for sizes.
10425 Don't increment bufsize until after realloc succeeds.
10426 Check for size-calculation overflow.
10427 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10428
437b2cb4
PE
10429 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10430
8b9ac8b4
PE
10431 * lread.c: Integer overflow fixes.
10432 (read_integer): Radix is now EMACS_INT, not int,
10433 to improve quality of diagnostics for out-of-range radices.
10434 Calculate buffer size correctly for out-of-range radices.
10435 (read1): Check for integer overflow in radices, and in
10436 read-circle numbers.
82cb60d3
PE
10437 (read_escape): Avoid int overflow.
10438 (Fload, openp, read_buffer_size, read1)
10439 (substitute_object_recurse, read_vector, read_list, map_obarray):
10440 Use ptrdiff_t, not int, for sizes.
10441 (read1): Use EMACS_INT, not int, for sizes.
20270765 10442 Check for size overflow.
8b9ac8b4 10443
7fcccf1e
PE
10444 * image.c (cache_image): Check for size arithmetic overflow.
10445
bfbbd7e7
PE
10446 * lread.c: Integer overflow issues.
10447 (saved_doc_string_size, saved_doc_string_length)
10448 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10449 Now ptrdiff_t, not int.
10450 (read1): Don't assume doc string length fits in int. Check for
10451 out-of-range doc string lengths.
10452 (read_list): Don't assume file position fits in int.
39019e54 10453 (read_escape): Check for hex character overflow.
bfbbd7e7 10454
4e323265
LL
104552011-06-22 Leo Liu <sdl.web@gmail.com>
10456
10457 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10458 Move to minibuffer.el.
10459
85fece3e
PE
104602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10461
20b84ce9 10462 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10463 The following patches are for when GLYPH_DEBUG && !XASSERT.
10464 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10465 * dispnew.c (flush_stdout):
10466 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10467 Mark as externally visible.
10468 * dispnew.c (check_window_matrix_pointers): Now static.
10469 * dispnew.c (window_to_frame_vpos):
10470 * xfns.c (unwind_create_frame):
10471 * xterm.c (x_check_font): Remove unused local.
10472 * scroll.c (CHECK_BOUNDS):
10473 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10474 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10475 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10476 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10477 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10478 Now static.
10479 (debug_method_add): Use va_list and vsprintf rather than relying
10480 on undefined behavior with wrong number of arguments.
10481 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10482 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10483 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10484 since we're not interested in debugging glyphs with old libraries.
10485 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10486 GCC 4.6.0's static checking.
10487
0766b489
PE
104882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10489
31fd4b32
PE
10490 Integer overflow and signedness fixes (Bug#8873).
10491 A few related buffer overrun fixes, too.
10492
b79e8648
PE
10493 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10494
0766b489
PE
10495 * dispextern.h (struct face.stipple):
10496 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10497 (x_bitmap_mask, x_allocate_bitmap_record)
10498 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10499 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10500 (x_create_bitmap_from_xpm_data):
10501 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10502 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10503 (.bitmaps_last):
10504 * xfaces.c (load_pixmap):
10505 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10506 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10507 (.bitmaps_last, struct x_output.icon_bitmap):
10508 Use ptrdiff_t, not int, for bitmap indexes.
10509 (x_allocate_bitmap_record): Check for size overflow.
10510 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10511
b081724f
PE
10512 Use ptrdiff_t, not int, for overlay counts.
10513 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10514 * editfns.c (overlays_around, get_pos_property):
10515 * textprop.c (get_char_property_and_overlay):
10516 * xdisp.c (next_overlay_change, note_mouse_highlight):
10517 * xfaces.c (face_at_buffer_position):
21514da7
PE
10518 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10519 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10520 (Fnext_overlay_change, Fprevious_overlay_change)
10521 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10522 Use ptrdiff_t, not int, for sizes.
21514da7 10523 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10524
3de73e5e
PE
10525 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10526
2606c57b
PE
10527 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10528 (x_session_initialize): Do not assume string length fits in int.
10529
aaafe47a
PE
10530 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10531 This is unlikely, but can occur if DPI is outlandish.
10532
2674ddc8 10533 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10534 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10535
28154962
PE
10536 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10537 * xrdb.c (magic_file_p, search_magic_path):
10538 Omit last arg SUFFIX; it was always 0. All callers changed.
10539 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10540
7de51af5
PE
10541 * xfont.c (xfont_match): Avoid need for strlen.
10542
25ed6cc3
PE
10543 * xfns.c: Don't assume strlen fits in int.
10544 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10545
4eab31dd
PE
10546 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10547 not unsigned long, as we prefer signed integers. All callers changed.
10548 Detect integer overflow in repeat count.
10549 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10550 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10551
171e2a58
PE
10552 * termcap.c: Don't assume sizes fit in int and never overflow.
10553 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10554 (gobble_line): Check for size-calculation overflow.
10555
ad39faca 10556 * minibuf.c (Fread_buffer):
6e5bb2dc 10557 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10558 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10559 Don't assume string length fits in int.
10560
52c61c22 10561 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10562 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10563
b5b8c9e5
PE
10564 * font.c: Don't assume string length fits in int.
10565 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10566 Use ptrdiff_t, not int.
ccd6111c
PE
10567 (font_intern_prop): Don't assume string length fits in int.
10568 Don't assume integer property fits in fixnum.
10569 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10570
882f0d81 10571 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10572 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10573 Reformulate so as not to need the command string.
10574 Invoke gzip -cd rather than gunzip, as it's more portable.
10575 (lock_info_type, lock_file_1, lock_file):
10576 Don't assume pid_t and time_t fit in unsigned long.
10577 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10578 (current_lock_owner): Prefer signed type for sizes.
10579 Use memcpy, not strncpy, where memcpy is what is really wanted.
10580 Don't assume (via atoi) that time_t and pid_t fit in int.
10581 Check for time_t and/or pid_t out of range, e.g., via a network share.
10582 Don't alloca where an auto var works fine.
10583
93f4cf88
PE
10584 * fileio.c: Fix some integer overflow issues.
10585 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10586 Don't assume string length fits in int.
10587 (directory_file_name): Don't assume string length fits in long.
10588 (make_temp_name): Don't assume pid fits in int, or that its print
10589 length is less than 20.
10590
f3e92b69
PE
10591 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10592
1bfdaf10
PE
10593 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10594
35016e9a
PE
10595 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10596
3d1e65a1
PE
10597 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10598 We prefer signed integers, even for size calculations.
10599
0b963a93
PE
10600 * emacs.c: Don't assume string length fits in 'int'.
10601 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10602 (main): Don't invoke strlen when not needed.
10603
573f4b54
PE
10604 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10605 (XD_DEBUG_MESSAGE): Don't waste a byte.
10606
989f33ba
PE
10607 * callproc.c (getenv_internal_1, getenv_internal)
10608 (Fgetenv_internal):
965d34eb
PE
10609 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10610
e4d29b33
PE
10611 * lread.c (invalid_syntax): Omit length argument.
10612 All uses changed. This doesn't fix a bug, but it simplifies the
10613 code away from its former Hollerith-constant appearance, and it's
10614 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10615 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10616
eb49b136
PE
10617 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10618 This didn't break anything, but it didn't help either.
10619 It's confusing to put a bogus integer in a place where the actual
10620 value does not matter.
9f62aeb1 10621 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10622 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10623
15375a22
PE
10624 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10625 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10626 implementation.
b61cc01c
PE
10627 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10628 We prefer signed types, and the value cannot exceed the EMACS_INT
10629 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10630 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10631 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10632 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10633
53b2623d
PE
10634 * indent.c (sane_tab_width): New function.
10635 (current_column, scan_for_column, Findent_to, position_indentation)
10636 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10637 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10638
51cab52b 10639 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10640
f2ed8a70
PE
10641 * lisp.h (lint_assume): New macro.
10642 * composite.c (composition_gstring_put_cache):
10643 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10644
abe80cc6
PE
10645 * editfns.c, insdel.c:
10646 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10647
b02c740e
PE
10648 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10649
ebc96716
PE
10650 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10651
b4e50fa0 10652 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10653 Use much-faster test for byte-length change.
311d5d7c 10654 Don't assume string byte-length fits in 'int'.
a4cf38e4 10655 Check that character arg fits in 'int'.
85461888 10656 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10657
c0c1ee9f
PE
10658 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10659
a498d7f4
PE
10660 * fns.c (concat): Catch string overflow earlier.
10661 Do not rely on integer wraparound.
10662
51cab52b
PE
10663 * dispextern.h (struct it.overlay_strings_charpos)
10664 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10665 * xdisp.c (forward_to_next_line_start)
10666 (back_to_previous_visible_line_start)
10667 (reseat_at_next_visible_line_start, next_element_from_buffer):
10668 Don't arbitrarily truncate the value of 'selective' to int.
10669
76031fad
PE
10670 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10671
5eb55db9
PE
10672 * composite.c: Don't truncate sizes to 'int'.
10673 (composition_gstring_p, composition_reseat_it)
10674 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10675 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10676 not EMACS_UINT, for indexes.
5eb55db9 10677
0703a717
PE
10678 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10679
d6202519
PE
10680 * buffer.c: Include <verify.h>.
10681 (struct sortvec.priority, struct sortstr.priority):
8961a454 10682 Now EMACS_INT, not int.
c20998a7 10683 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10684 (struct sortstr.size, record_overlay_string)
10685 (struct sortstrlist.size, struct sortlist.used):
10686 Don't truncate size to int.
10687 (record_overlay_string): Check for size-calculation overflow.
d6202519 10688 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10689
d5a19415
JM
106902011-06-22 Jim Meyering <meyering@redhat.com>
10691
029529ac 10692 Don't leak an XBM-image-sized buffer
d5a19415
JM
10693 * image.c (xbm_load): Free the image buffer after using it.
10694
a9041e6c
PE
106952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10696
10697 Port to Sun C.
10698 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10699 that Sun C diagnosed.
10700 * fns.c (secure_hash): Fix pointer signedness issue.
10701 * intervals.c (static_offset_intervals): New function.
10702 (offset_intervals): Use it.
10703
7f3f739f
LL
107042011-06-21 Leo Liu <sdl.web@gmail.com>
10705
10706 * deps.mk (fns.o):
10707 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10708 sha512.h.
10709
10710 * fns.c (secure_hash): Rename from crypto_hash_function and change
10711 the first arg to accept symbols.
5b66d427 10712 (Fsecure_hash): New primitive.
7f3f739f
LL
10713 (syms_of_fns): New symbols.
10714
76147d94
DD
107152011-06-20 Deniz Dogan <deniz@dogan.se>
10716
10717 * process.c (Fset_process_buffer): Clarify return value in
10718 docstring.
10719
7d7d0045
CY
107202011-06-18 Chong Yidong <cyd@stupidchicken.com>
10721
10722 * dispnew.c (add_window_display_history): Use BVAR.
10723
10724 * xdisp.c (debug_method_add): Use BVAR.
10725 (check_window_end, dump_glyph_matrix, dump_glyph)
10726 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10727
10728 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10729 Likewise.
10730
10731 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10732 check till after the cache is created in init_frame_faces.
10733
ff2bc410
SM
107342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10735
10736 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10737
28177add
PE
107382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10739
dd3482fe
PE
10740 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10741 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10742 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10743
393d71f3 10744 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10745 * fileio.c (Finsert_file_contents):
10746 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10747 Remove the old (too-loose) buffer overflow checks.
10748 They weren't needed, since make_gap checks for buffer overflow.
10749 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10750 The old code merely checked for Emacs fixnum overflow, and relied
10751 on undefined (wraparound) behavior. The new code avoids undefined
10752 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10753
2e6813b0 10754 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10755 Tune. Don't use wider integers than needed. Don't use alloca.
10756 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10757
599a9e4f
PE
10758 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10759
99561444
PE
10760 * insdel.c, lisp.h (buffer_overflow): New function.
10761 (insert_from_buffer_1, replace_range, replace_range_2):
10762 * insdel.c (make_gap_larger):
10763 * editfns.c (Finsert_char):
10764 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10765
28177add
PE
10766 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10767
e69dafad
PE
107682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10769
4baa020d 10770 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10771
b1c46f02
PE
10772 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10773 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10774
e69dafad
PE
10775 * fileio.c: Don't assume EMACS_INT fits in off_t.
10776 (emacs_lseek): New static function.
10777 (Finsert_file_contents, Fwrite_region): Use it.
10778 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10779
566684ea
PE
10780 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10781
e6966cd6
PE
10782 * fns.c: Don't overflow int when computing a list length.
10783 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10784 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10785 truncation on 64-bit hosts. Check for QUIT every
10786 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10787 faster and is responsive enough.
10788 (Flength): Report an error instead of overflowing an integer.
10789 (Fsafe_length): Return a float if the value is not representable
10790 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10791 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10792 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10793
dd0b0efb
PE
10794 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10795 (header_size, word_size): New constants.
10796 (allocate_vectorlike): Don't check size overflow here.
10797 (allocate_vector): Check it here instead, since this is the only
10798 caller of allocate_vectorlike that could cause overflow.
10799 Check that the new vector's length is representable as a fixnum.
10800
86fe5cfe
PE
10801 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10802 The previous code was bogus. For example, next_almost_prime (32)
10803 returned 39, which is undesirable as it is a multiple of 3; and
10804 next_almost_prime (24) returned 25, which is a multiple of 5 so
10805 why was the code bothering to check for multiples of 7?
10806
80e88859
PE
10807 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10808
4a2f0ad6
PE
10809 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10810
f66c7cf8
PE
10811 Variadic C functions now count arguments with ptrdiff_t.
10812 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10813 Back then I didn't know that the Emacs coding style prefers signed int.
10814 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10815 were being counted with int, which may truncate counts on 64-bit
10816 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10817 * lisp.h (struct Lisp_Subr.function.aMANY)
10818 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10819 Arg counts are now ptrdiff_t, not size_t.
10820 All variadic functions and their callers changed accordingly.
10821 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10822 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10823 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10824 * callint.c (Fcall_interactively): Check arg count for overflow,
10825 to avoid potential buffer overrun. Use signed char, not 'int',
10826 for 'varies' array, so that we needn't bother to check its size
10827 calculation for overflow.
10828 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10829 * eval.c (apply_lambda):
10830 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10831 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10832 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10833
a1759b76
PE
10834 * callint.c (Fcall_interactively): Don't use index var as event count.
10835
d96be9fc
PE
10836 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10837 * mem-limits.h (SIZE): Remove; no longer used.
10838
a690a978 10839 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10840
578c21e6
PE
10841 Remove unnecessary casts.
10842 * xterm.c (x_term_init):
10843 * xfns.c (x_set_border_pixel):
10844 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10845 These aren't needed now that we assume ANSI C.
10846
96f53c6c
PE
10847 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10848 It's more likely to cause problems (due to unsigned overflow)
10849 than to cure them.
10850
83c77d31
PE
10851 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10852
ee2079f1
PE
10853 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10854
6da65536
PE
10855 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10856
7147c4a4
PE
10857 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10858
193e32d9
PE
10859 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10860
e5533da6
PE
10861 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10862
9910e595
PE
10863 GLYPH_CODE_FACE returns EMACS_INT, not int.
10864 * dispextern.h (merge_faces):
10865 * xfaces.c (merge_faces):
01103c44
PE
10866 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10867 Don't assume EMACS_INT fits in int.
9910e595 10868
2638320e
PE
10869 * character.h (CHAR_VALID_P): Remove unused parameter.
10870 * fontset.c, lisp.h, xdisp.c: All uses changed.
10871
045eb8d9
PE
10872 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10873
c1f134b5
PE
10874 * fns.c (concat): Minor tuning based on overflow analysis.
10875 This doesn't fix any bugs. Use int to hold character, instead
10876 of constantly refetching from Emacs object. Use XFASTINT, not
10877 XINT, for value known to be a character. Don't bother comparing
10878 a single byte to 0400, as it's always less.
10879
395fcb93 10880 * floatfns.c (Fexpt):
327eeec8
PE
10881 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10882
abbd3d23
PE
10883 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10884 for characters.
10885
684a03ef
PE
10886 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10887
0fed43f3
PE
10888 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10889 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10890 incorrectly succeed when S was a string, because 4294967386 was
10891 truncated before it was used.
10892
8fd02eb7
PE
10893 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10894 Otherwise, an out-of-range integer could cause undefined behavior
10895 on a 64-bit host.
10896
f8c86b69
PE
10897 * composite.c: Use int, not EMACS_INT, for characters.
10898 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10899 EMACS_INT, for values that are known to be in character range.
10900 This doesn't fix any bugs but is the usual style inside Emacs and
10901 may generate better code on 32-bit machines.
10902
34206dd2
PE
10903 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10904 This is for reasons similar to the recent CHAR_STRING fix.
10905 * charset.c (Fencode_char): Check that character arg is actually
10906 a character. Pass an int to ENCODE_CHAR.
10907 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10908 wider than 'int', as a compile-time check to prevent future regressions
10909 in this area.
10910
c5958d4c 10911 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10912
10913 Make sure a 64-bit char is never passed to CHAR_STRING.
10914 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10915 by silently ignoring the top 32 bits, allowing some values
10916 that were far too large to be valid characters.
10917 * character.h: Include <verify.h>.
10918 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10919 arguments are no wider than unsigned, as a compile-time check
10920 to prevent future regressions in this area.
10921 * data.c (Faset):
01103c44 10922 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10923 (Fsubst_char_in_region):
10924 * fns.c (concat):
10925 * xdisp.c (decode_mode_spec_coding):
10926 Adjust to CHAR_STRING's new requirement.
10927 * editfns.c (Finsert_char, Fsubst_char_in_region):
10928 * fns.c (concat): Check that character args are actually
10929 characters. Without this test, these functions did the wrong
10930 thing with wildly out-of-range values on 64-bit hosts.
10931
d37ca623
PE
10932 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10933 These casts should not be needed on 32-bit hosts, either.
10934 * keyboard.c (read_char):
10935 * lread.c (Fload): Remove casts to unsigned.
10936
ea204efb
PE
10937 * lisp.h (UNSIGNED_CMP): New macro.
10938 This fixes comparison bugs on 64-bit hosts.
10939 (ASCII_CHAR_P): Use it.
10940 * casefiddle.c (casify_object):
01103c44 10941 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10942 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10943 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10944 * dispextern.h (FACE_FROM_ID):
10945 * keyboard.c (read_char): Use UNSIGNED_CMP.
10946
41cb286c
PE
10947 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10948 not to EMACS_INT, to avoid GCC warning.
10949
4a1b9832
PE
10950 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10951
55daad71
PE
10952 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10953 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10954 isn't needed on 32-bit machines.
8f95c75c 10955
01103c44
PE
10956 * buffer.c (Fgenerate_new_buffer_name):
10957 Use EMACS_INT for count, not int.
0ceccced 10958 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10959
10960 * data.c (Qcompiled_function): Now static.
10961
c6f072e7
PE
10962 * window.c (window_body_lines): Now static.
10963
20ce5912
PE
10964 * image.c (gif_load): Rename local to avoid shadowing.
10965
9c4c5f81
PE
10966 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10967 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10968 * alloc.c (make_save_value): Integer argument is now of type
10969 ptrdiff_t, not int.
10970 (mark_object): Use ptrdiff_t, not int.
10971 * lisp.h (pD): New macro.
10972 * print.c (print_object): Use it.
10973
c0c5c8ae
PE
10974 * alloc.c: Use EMACS_INT, not int, to count objects.
10975 (total_conses, total_markers, total_symbols, total_vector_size)
10976 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10977 (total_free_floats, total_floats, total_free_intervals)
10978 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10979 Now EMACS_INT, not int. All uses changed.
10980 (Fgarbage_collect): Compute overall total using a double, so that
10981 integer overflow is less likely to be a problem. Check for overflow
10982 when converting back to an integer.
5a25e253
PE
10983 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10984 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10985 These were 'int' variables that could overflow on 64-bit hosts;
10986 they were never used, so remove them instead of repairing them.
211a0b2a 10987 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10988 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10989 Previously, this ceilinged at INT_MAX, but that doesn't work on
10990 64-bit machines.
e46bb31a 10991 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10992
c78baabf 10993 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10994 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10995 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10996 when a (possibly-narrower) signed value would do just as well.
10997 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10998
c9d624c6
PE
10999 * alloc.c: Catch some string size overflows that we were missing.
11000 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11001 for convenience in STRING_BYTES_MAX.
11002 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11003 The definition here is exact; the one in lisp.h was approximate.
11004 (allocate_string_data): Check for string overflow. This catches
11005 some instances we weren't catching before. Also, it catches
11006 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11007 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11008 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11009
c9d624c6
PE
11010 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11011 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11012 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11013
353032ce
PE
11014 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11015
2bccce07
PE
11016 * alloc.c (Fmake_string): Check for out-of-range init.
11017
0ac30604
SM
110182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11019
11020 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11021
c195f2de
JD
110222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11023
11024 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11025 xg_get_default_scrollbar_width.
11026
11027 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11028 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11029 (style_changed_cb): Call update_theme_scrollbar_width and call
11030 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11031 all frames (Bug#8505).
11032 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11033 Call gtk_window_set_resizable if HAVE_GTK3.
11034 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11035 and height if HAVE_GTK3 (Bug#8505).
11036 (scroll_bar_width_for_theme): New variable.
11037 (update_theme_scrollbar_width): New function.
11038 (xg_get_default_scrollbar_width): Move code to
11039 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11040 (xg_initialize): Call update_theme_scrollbar_width.
11041
11042 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11043
11044 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11045
e10ac9f1
MR
110462011-06-12 Martin Rudalics <rudalics@gmx.at>
11047
11048 * frame.c (make_frame): Call other_buffer_safely instead of
11049 other_buffer.
11050
11051 * window.c (temp_output_buffer_show): Call display_buffer with
11052 second argument Vtemp_buffer_show_specifiers and reset latter
11053 immediately after the call.
11054 (Vtemp_buffer_show_specifiers): New variable.
11055 (auto_window_vscroll_p, next_screen_context_lines)
11056 (Vscroll_preserve_screen_position): Remove leading asterisks from
11057 doc-strings.
11058
2d3c217e 110592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11060
7b7f97e8 11061 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11062 * buffer.c (Qclone_number): Remove for now, as it's unused.
11063 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11064 (record_buffer): Remove unused local.
11065 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11066 (set_frame_buffer_list): Remove; unused.
11067 * frame.h (other_visible_frames): Remove decl.
11068 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11069 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11070 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11071 if HAVE_GPM.
11072 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11073 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11074 Define only if HAVE_GPM.
11075 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11076 (update_hints_inhibit): Remove; never set. All uses removed.
11077 * widgetprv.h (emacsFrameClassRec): Remove decl.
11078 * window.c (delete_deletable_window): Now returns void, since it
11079 wasn't returning anything.
11080 (compare_window_configurations): Remove unused locals.
11081 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11082 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11083 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11084 the same widths as pointers. This follows up on the 2011-05-06 patch.
11085 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11086 * xterm.h: Likewise.
11087 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11088
1384b89e
JB
110892011-06-12 Juanma Barranquero <lekktu@gmail.com>
11090
11091 * makefile.w32-in: Update dependencies.
11092 (LISP_H): Add lib/intprops.h.
11093
1100a63c
CY
110942011-06-11 Chong Yidong <cyd@stupidchicken.com>
11095
11096 * image.c (gif_load): Add animation frame delay to the metadata.
11097 (syms_of_image): Use DEFSYM. New symbol `delay'.
11098
6198ccd0
MR
110992011-06-11 Martin Rudalics <rudalics@gmx.at>
11100
11101 * window.c (delete_deletable_window): Re-add.
11102 (Fset_window_configuration): Rewrite to handle dead buffers and
11103 consequently deletable windows.
11104 (window_tree, Fwindow_tree): Remove. Supply functionality in
11105 window.el.
11106 (compare_window_configurations): Simplify code.
11107
b6e3633c
AS
111082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11109
1ab0dee5
AS
11110 * image.c (imagemagick_load_image): Fix type mismatch.
11111 (Fimagemagick_types): Likewise.
11112
b6e3633c
AS
11113 * window.h (replace_buffer_in_windows): Declare.
11114
9397e56f
MR
111152011-06-11 Martin Rudalics <rudalics@gmx.at>
11116
11117 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11118 Qclone_number. Remove external declaration of Qdelete_window.
11119 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11120 code.
640c8776
SM
11121 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11122 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11123 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11124 buffer list implementation.
11125 (other_buffer_safely): New function.
11126 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11127 calls to replace_buffer_in_windows and
11128 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11129 if allowed.
11130 (record_buffer): Inhibit quitting and rewrite using quittable
11131 functions. Run Qbuffer_list_update_hook if allowed.
11132 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11133 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11134 Move switch-to-buffer to window.el.
9397e56f
MR
11135 (bury-buffer): Move to window.el.
11136 (Vbuffer_list_update_hook): New variable.
11137
11138 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11139 section.
11140
11141 * window.h (resize_frame_windows): Move up in code.
11142 (Fwindow_frame): Remove EXFUN.
11143 (replace_buffer_in_all_windows): Remove prototype.
11144 (replace_buffer_in_windows_safely): Add prototype.
11145
11146 * window.c: Declare Qdelete_window static again. Move down
11147 declaration of select_count.
11148 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11149 (Fother_window): Move to window.el.
11150 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11151 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11152 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11153 window.el.
11154 (replace_buffer_in_windows): Implement by calling
11155 Qreplace_buffer_in_windows.
11156 (replace_buffer_in_all_windows): Remove with some functionality
11157 moved into replace_buffer_in_windows_safely.
11158 (replace_buffer_in_windows_safely): New function.
11159 (select_window_norecord, select_frame_norecord): Move in front
11160 of run_window_configuration_change_hook. Remove now obsolete
11161 declarations.
640c8776
SM
11162 (Fset_window_buffer): Rewrite doc-string.
11163 Call Qrecord_window_buffer.
9397e56f
MR
11164 (keys_of_window): Move binding for other-window to window.el.
11165
b50691aa
CY
111662011-06-11 Chong Yidong <cyd@stupidchicken.com>
11167
11168 * dispextern.h (struct image): Replace data member, whose int_val
11169 and ptr_val fields were not used by anything, with a single
11170 lisp_val object.
11171
11172 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11173 (gif_clear_image, gif_load, imagemagick_load_image)
11174 (gs_clear_image, gs_load): Callers changed.
11175
3f754b86
PE
111762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11177
cca69397
PE
11178 * buffer.h: Include <time.h>, for time_t.
11179 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11180
109e28d0
PE
11181 Fix minor problems found by static checking.
11182
60737f02
PE
11183 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11184
4b66faf3
PE
11185 Make identifiers static if they are not used in other modules.
11186 * data.c (Qcompiled_function, Qframe, Qvector):
11187 * image.c (QimageMagick, Qsvg):
11188 * minibuf.c (Qmetadata):
11189 * window.c (resize_window_check, resize_root_window): Now static.
11190 * window.h (resize_window_check, resize_root_window): Remove decls.
11191
109e28d0
PE
11192 * window.c (window_deletion_count, delete_deletable_window):
11193 Remove; unused.
46a4ce9e
PE
11194 (window_body_lines): Now static.
11195 (Fdelete_other_windows_internal): Mark vars as initialized.
11196 Make sure 'resize_failed' is initialized.
11197 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11198 (resize_window_apply): Remove unused local.
11199 * window.h (delete_deletable_window): Remove decl.
11200
109e28d0 11201 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11202 (imagemagick_load_image): Fix pointer signedness problem by changing
11203 last arg from unsigned char * to char *. All uses changed.
11204 Also, fix a local for similar reasons.
11205 Remove unused locals. Remove locals to avoid shadowing.
11206 (fn_rsvg_handle_free): Remove; unused.
11207 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11208 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11209
3f754b86
PE
11210 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11211
2547adb1
CY
112122011-06-10 Chong Yidong <cyd@stupidchicken.com>
11213
11214 * image.c (gif_load): Fix omitted cast error introduced by
11215 2011-06-06 change.
11216
2c8e37d4
MR
112172011-06-10 Martin Rudalics <rudalics@gmx.at>
11218
11219 * window.h (resize_proportionally, orig_total_lines)
11220 (orig_top_line): Remove from window structure.
11221 (set_window_height, set_window_width, change_window_heights)
11222 (Fdelete_window): Remove prototypes.
11223 (resize_frame_windows): Remove duplicate declaration.
11224
440a42e3
EZ
112252011-06-10 Eli Zaretskii <eliz@gnu.org>
11226
11227 * window.h (resize_frame_windows, resize_window_check)
11228 (delete_deletable_window, resize_root_window)
11229 (resize_frame_windows): Declare prototypes.
11230
11231 * window.c (resize_window_apply): Make definition be "static" to
11232 match the prototype.
11233
562dd5e9
MR
112342011-06-10 Martin Rudalics <rudalics@gmx.at>
11235
11236 * window.c: Remove declarations of Qwindow_size_fixed,
11237 window_min_size_1, window_min_size_2, window_min_size,
11238 size_window, window_fixed_size_p, enlarge_window, delete_window.
11239 Remove static from declaration of Qdelete_window, it's
11240 temporarily needed by Fbury_buffer.
11241 (replace_window): Don't assign orig_top_line and
11242 orig_total_lines.
11243 (Fdelete_window, delete_window): Remove. Window deletion is
11244 handled by window.el.
640c8776
SM
11245 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11246 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11247 (Fdelete_other_windows): Remove. Deleting other windows is
11248 handled by window.el.
11249 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11250 handled in window.el.
11251 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11252 Window minimum sizes are handled in window.el.
11253 (shrink_windows, size_window, set_window_height)
11254 (set_window_width, change_window_heights, window_height)
11255 (window_width, CURBEG, CURSIZE, enlarge_window)
11256 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11257 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11258 handled in window.el.
11259 (make_dummy_parent): Rename to make_parent_window and give it a
11260 second argument horflag.
11261 (make_window): Don't set resize_proportionally any more.
11262 (Fsplit_window): Remove. Windows are split in window.el.
11263 (save_restore_action, save_restore_orig_size)
11264 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11265 Resize mini windows in window.el.
11266 (grow_mini_window, shrink_mini_window): Implement by calling
11267 Qresize_root_window_vertically, resize_window_check and
11268 resize_window_apply.
640c8776
SM
11269 (saved_window, Fset_window_configuration, save_window_save):
11270 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11271 resize_proportionally.
11272 (window_min_height, window_min_width): Move to window.el.
11273 (keys_of_window): Move bindings for delete-other-windows,
11274 split-window, delete-window and enlarge-window to window.el.
11275
11276 * buffer.c: Temporarily extern Qdelete_window.
11277 (Fbury_buffer): Temporarily call Qdelete_window instead of
11278 Fdelete_window (Fbury_buffer will move to window.el soon).
11279
11280 * frame.c (set_menu_bar_lines_1): Remove code handling
11281 orig_top_line and orig_total_lines.
11282
11283 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11284 set_window_height but set heights directly.
11285 (change_frame_size_1): Use resize_frame_windows.
11286
11287 * xdisp.c (init_xdisp): Don't use set_window_height but set
11288 heights directly.
11289
640c8776
SM
11290 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11291 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11292 run_window_configuration_change_hook.
11293
11294 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11295 instead of change_window_heights and run
11296 run_window_configuration_change_hook.
11297
1a13852e
MR
112982011-06-09 Martin Rudalics <rudalics@gmx.at>
11299
11300 * window.c (replace_window): Rename second argument REPLACEMENT to
11301 NEW. New third argument SETFLAG. Rewrite.
11302 (delete_window, make_dummy_parent): Call replace_window with
11303 third argument 1.
11304 (window_list_1): Move down in code.
11305 (run_window_configuration_change_hook): Move set_buffer part
11306 before select_frame_norecord part in order to unwind correctly.
11307 Rename count1 to count.
11308 (recombine_windows, delete_deletable_window, resize_root_window)
11309 (Fdelete_other_windows_internal)
11310 (Frun_window_configuration_change_hook, make_parent_window)
11311 (resize_window_check, resize_window_apply, Fresize_window_apply)
11312 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11313 (Fdelete_window_internal, Fresize_mini_window_internal):
11314 New functions.
1a13852e
MR
11315 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11316
f3d1777e
MR
113172011-06-08 Martin Rudalics <rudalics@gmx.at>
11318
496e208e
MR
11319 * window.h (window): Add some new members to window structure -
11320 normal_lines, normal_cols, new_total, new_normal, clone_number,
11321 splits, nest, prev_buffers, next_buffers.
11322 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11323 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11324
f3d1777e
MR
11325 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11326 Remove.
496e208e
MR
11327 (make_dummy_parent): Set new members of windows structure.
11328 (make_window): Move down in code. Handle new members of window
11329 structure.
11330 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11331 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11332 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11333 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11334 (Fset_window_next_buffers, Fset_window_clone_number):
11335 New functions.
496e208e
MR
11336 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11337 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11338 Doc-string fixes.
11339 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11340 Argument WINDOW can be now internal window too.
11341 (Fwindow_use_time): Move up in code.
11342 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11343 Rewrite doc-string.
11344 (Fset_window_configuration, saved_window)
11345 (Fcurrent_window_configuration, save_window_save): Handle new
11346 members of window structure.
b9e809c2
MR
11347 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11348 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11349 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11350 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11351 Qget_mru_window, Qresize_root_window,
11352 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11353 Qauto_buffer_name; staticpro them.
f3d1777e 11354
abde8f8c
MR
113552011-06-07 Martin Rudalics <rudalics@gmx.at>
11356
11357 * window.c (Fwindow_total_size, Fwindow_left_column)
11358 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11359 (Fwindow_list_1): New functions.
11360 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11361 (Fwindow_width, Fscroll_left, Fscroll_right):
11362 Use window_body_cols instead of window_box_text_cols.
11363 (delete_window, Fset_window_configuration):
11364 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11365 (delete_all_subwindows): Take a window as argument and not a
11366 structure. Rewrite.
190b47e6
MR
11367 (window_loop): Remove handling of GET_LRU_WINDOW and
11368 GET_LARGEST_WINDOW.
11369 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11370
11371 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11372 window_box_text_cols. delete_all_subwindows now takes a
11373 Lisp_Object as argument.
abde8f8c 11374
640c8776
SM
11375 * indent.c (compute_motion, Fcompute_motion):
11376 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11377
fa8a67e6
MR
11378 * frame.c (delete_frame): Call delete_all_subwindows with root
11379 window as argument.
11380
a54e3482
DC
113812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11382
11383 * fns.c (Fputhash): Document return value.
11384
60002bf5
CY
113852011-06-06 Chong Yidong <cyd@stupidchicken.com>
11386
11387 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11388
0c671da6 113892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11390
b862a52a 11391 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11392
be44ca6c
PE
11393 Check for overflow when converting integer to cons and back.
11394 * charset.c (Fdefine_charset_internal, Fdecode_char):
11395 Use cons_to_unsigned to catch overflow.
11396 (Fencode_char): Use INTEGER_TO_CONS.
11397 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11398 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11399 * data.c (long_to_cons, cons_to_long): Remove.
11400 (cons_to_unsigned, cons_to_signed): New functions.
11401 These signal an error for invalid or out-of-range values.
11402 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11403 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11404 * font.c (Ffont_variation_glyphs):
11405 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11406 * lisp.h: Include <intprops.h>.
11407 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11408 (cons_to_signed, cons_to_unsigned): New decls.
11409 (long_to_cons, cons_to_long): Remove decls.
11410 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11411 (Fprimitive_undo): Use CONS_TO_INTEGER.
11412 * xfns.c (Fx_window_property): Likewise.
11413 * xselect.c: Include <limits.h>.
11414 (x_own_selection, selection_data_to_lisp_data):
11415 Use INTEGER_TO_CONS.
11416 (x_handle_selection_request, x_handle_selection_clear)
11417 (x_get_foreign_selection, Fx_disown_selection_internal)
11418 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11419 (lisp_data_to_selection_data): Use cons_to_unsigned.
11420 (x_fill_property_data): Use cons_to_signed.
11421 Report values out of range.
11422
d1f3d2af
PE
11423 Check for buffer and string overflow more precisely.
11424 * buffer.h (BUF_BYTES_MAX): New macro.
11425 * lisp.h (STRING_BYTES_MAX): New macro.
11426 * alloc.c (Fmake_string):
11427 * character.c (string_escape_byte8):
11428 * coding.c (coding_alloc_by_realloc):
11429 * doprnt.c (doprnt):
11430 * editfns.c (Fformat):
11431 * eval.c (verror):
11432 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11433 since they may not be the same number.
11434 * editfns.c (Finsert_char):
11435 * fileio.c (Finsert_file_contents):
11436 Likewise for BUF_BYTES_MAX.
11437
dd52fcea
PE
11438 * image.c: Use ptrdiff_t, not int, for sizes.
11439 (slurp_file): Switch from int to ptrdiff_t.
11440 All uses changed.
11441 (slurp_file): Check that file size fits in both size_t (for
11442 malloc) and ptrdiff_t (for sanity and safety).
11443
7f9bbdbb
PE
11444 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11445 if b->modtime has its maximal value.
11446
dfe18f82
PE
11447 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11448
84acfcf0
PE
11449 Don't assume time_t can fit into int.
11450 * buffer.h (struct buffer.modtime): Now time_t, not int.
11451 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11452 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11453
ccd9a01a
PE
11454 Minor fixes for signed vs unsigned integers.
11455 * character.h (MAYBE_UNIFY_CHAR):
11456 * charset.c (maybe_unify_char):
11457 * keyboard.c (read_char, reorder_modifiers):
11458 XINT -> XFASTINT, since the integer must be nonnegative.
11459 * ftfont.c (ftfont_spec_pattern):
11460 * keymap.c (access_keymap, silly_event_symbol_error):
11461 XUINT -> XFASTINT, since the integer must be nonnegative.
11462 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11463 since it makes no difference and we prefer signed.
11464 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11465 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11466 nonnegative.
11467
d6d100dd
SM
114682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11469
11470 * window.h (Fwindow_frame): Declare.
11471
2b6148e4
PE
114722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11473
11474 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11475 (SPARE_MEMORY): Always define.
11476 (LARGE_REQUEST): Remove.
11477 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11478
f230ecc9
MR
114792011-06-06 Martin Rudalics <rudalics@gmx.at>
11480
727e958e
MR
11481 * lisp.h: Move EXFUNS for Fframe_root_window,
11482 Fframe_first_window and Fset_frame_selected_window to window.h.
11483
11484 * window.h: Move EXFUNS for Fframe_root_window,
11485 Fframe_first_window and Fset_frame_selected_window here from
11486 lisp.h.
11487
11488 * frame.c (Fwindow_frame, Fframe_first_window)
11489 (Fframe_root_window, Fframe_selected_window)
11490 (Fset_frame_selected_window): Move to window.c.
11491 (Factive_minibuffer_window): Move to minibuf.c.
11492 (Fother_visible_frames_p): New function.
11493
11494 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11495
f230ecc9
MR
11496 * window.c (decode_window, decode_any_window): Move up in code.
11497 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11498 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11499 (Fwindow_buffer): Move up and rewrite doc-string.
11500 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11501 (Fwindow_prev): New functions.
727e958e
MR
11502 (Fwindow_frame): Move here from frame.c. Accept any window as
11503 argument.
11504 (Fframe_root_window, Fframe_first_window)
11505 (Fframe_selected_window): Move here from frame.c. Accept frame
11506 or arbitrary window as argument. Update doc-strings.
11507 (Fminibuffer_window): Move up in code.
11508 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11509 (Fset_frame_selected_window): Move here from frame.c.
11510 Marginal rewrite.
727e958e
MR
11511 (Fselected_window, select_window, Fselect_window): Move up in
11512 code. Minor doc-string fixes.
f230ecc9 11513
4d09bcf6
PE
115142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11515
11516 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11517 Do not assume that spare memory exists; that assumption is valid
11518 only if SYSTEM_MALLOC.
11519 (LARGE_REQUEST): New macro, so that the issue of large requests
11520 is separated from the issue of spare memory.
11521
810928a2
AS
115222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11523
172418ad
AS
11524 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11525 format. (Bug#8806)
11526
43f862f7
AS
11527 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11528
810928a2
AS
11529 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11530 before statements.
11531
a059fe24
JD
115322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11533
11534 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11535
11536 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11537
11538 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11539 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11540
989bf368
JB
115412011-06-05 Juanma Barranquero <lekktu@gmail.com>
11542
11543 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11544
4b80f674
CY
115452011-06-04 Chong Yidong <cyd@stupidchicken.com>
11546
11547 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11548 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11549 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11550 New error handlers.
4b80f674
CY
11551 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11552 Obey Vx_select_enable_clipboard_manager. Catch errors in
11553 x_clipboard_manager_save (Bug#8779).
11554 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11555 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11556
99a33b77 115572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11558
11559 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11560
99a33b77 115612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11562
11563 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11564 in the current matrix if keep_current_p is non-zero.
11565
8264569d
EZ
115662011-06-04 Eli Zaretskii <eliz@gnu.org>
11567
11568 * bidi.c (bidi_level_of_next_char): Fix last change.
11569
57f97249
EZ
115702011-06-03 Eli Zaretskii <eliz@gnu.org>
11571
fec2107c 11572 Support bidi reordering of text covered by display properties.
57f97249 11573
fec2107c
EZ
11574 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11575 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11576 (bidi_cache_search, bidi_cache_iterator_state)
11577 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11578 (bidi_level_of_next_char, bidi_move_to_visually_next):
11579 Support character positions inside a run of characters covered by a
fec2107c
EZ
11580 display string.
11581 (bidi_paragraph_init, bidi_resolve_explicit_1)
11582 (bidi_level_of_next_char): Call bidi_fetch_char and
11583 bidi_fetch_char_advance instead of FETCH_CHAR and
11584 FETCH_CHAR_ADVANCE.
11585 (bidi_init_it): Initialize new members.
11586 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11587 definitions.
11588 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11589 instead of using explicit *_CHAR codes.
d6d100dd
SM
11590 (bidi_resolve_explicit, bidi_resolve_weak):
11591 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11592 bidirectional text is supported only in multibyte buffers.
11593 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11594 it to initialize the frame_window_p member of struct bidi_it.
11595 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11596 (bidi_resolve_explicit, bidi_resolve_weak)
11597 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11598 bidi_it->nchars is non-positive.
11599 (bidi_level_of_next_char): Don't try to lookup the cache for the
11600 next/previous character if nothing is cached there yet, or if we
11601 were just reseat()'ed to a new position.
c40e2fb2 11602
0e14fe90
EZ
11603 * xdisp.c (set_cursor_from_row): Set start and stop points
11604 according to the row's direction when priming the loop that looks
11605 for the glyph on which to display cursor.
11606 (single_display_spec_intangible_p): Function deleted.
11607 (display_prop_intangible_p): Reimplement to call
11608 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11609 Accept 3 additional arguments needed by handle_display_spec.
11610 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11611 values: lists, `(when COND...)' forms, etc.
11612 (single_display_spec_string_p): Support property values that are
11613 lists with the argument STRING its top-level element.
11614 (display_prop_string_p): Fix the condition for processing a
11615 property that is a list to be consistent with handle_display_spec.
fec2107c 11616 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11617 last portion of handle_display_prop.
11618 (compute_display_string_pos): Accept additional argument
11619 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11620 value of a `display' property is a "replacing spec".
11621 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11622 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11623 the display property, but just return a value indicating whether
11624 the display property will replace the characters it covers.
11625 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11626 frame_window_p members of struct bidi_it.
d6d100dd
SM
11627 (compute_display_string_pos, compute_display_string_end):
11628 New functions.
fec2107c
EZ
11629 (push_it): Accept second argument POSITION, where pop_it should
11630 jump to continue iteration.
11631 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11632
fec2107c
EZ
11633 * keyboard.c (adjust_point_for_property): Adjust the call to
11634 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11635
11636 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11637 (bidi_init_it): Update prototypes.
11638 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11639 (compute_display_string_pos, compute_display_string_end):
11640 Declare prototypes.
fec2107c
EZ
11641 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11642 EMACS_INT.
fc6f18ce 11643
40087514 116442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11645
57f53182
PE
11646 Malloc failure behavior now depends on size of allocation.
11647 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11648 * lisp.h: Change signatures accordingly.
11649 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11650 All callers changed. (Bug#8762)
11651
11652 * gnutls.c: Use Emacs's memory allocators.
11653 Without this change, the gnutls library would invoke malloc etc.
11654 directly, which causes problems on non-SYNC_INPUT hosts, and which
11655 runs afoul of improving memory_full behavior. (Bug#8761)
11656 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11657 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11658 xfree instead of the default malloc, realloc, free.
11659 (Fgnutls_boot): No need to check for memory allocation failure,
11660 since xmalloc does that for us.
11661
ac32cd99 11662 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11663 * category.c (hash_get_category_set):
11664 * ccl.c (ccl_driver):
11665 * charset.c (Fdefine_charset_internal):
11666 * charset.h (struct charset.hash_index):
11667 * composite.c (get_composition_id, gstring_lookup_cache)
11668 (composition_gstring_put_cache):
11669 * composite.h (struct composition.hash_index):
11670 * dispextern.h (struct image.hash):
11671 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11672 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11673 (hashfn_equal, hashfn_user_defined, make_hash_table)
11674 (maybe_resize_hash_table, hash_lookup, hash_put)
11675 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11676 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11677 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11678 * image.c (make_image, search_image_cache, lookup_image)
11679 (xpm_put_color_table_h):
11680 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11681 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11682 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11683 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11684 * alloc.c (allocate_vectorlike):
11685 Check for overflow in vector size calculations.
11686 * ccl.c (ccl_driver):
11687 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11688 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11689 need to be updated by these changes.
40087514
PE
11690 * fns.c (make_hash_table, maybe_resize_hash_table):
11691 Check for integer overflow with large hash tables.
0de4bb68
PE
11692 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11693 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11694 (SXHASH_REDUCE): New macro.
11695 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11696 Use it instead of discarding useful hash info with large hash values.
11697 (sxhash_float): New function.
11698 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11699 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11700 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11701 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11702 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11703 Adjust signatures to match updated version of code.
11704 (consing_since_gc): Now EMACS_INT, since a single hash table can
11705 use more than INT_MAX bytes.
11706
698d32e2
DN
117072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11708
11709 Make it possible to build with GCC-4.6+ -O2 -flto.
11710
11711 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11712
fd6fa53f
SM
117132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11714
11715 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11716 Call minibuffer-inactive-mode.
11717
864db017
JB
117182011-05-31 Juanma Barranquero <lekktu@gmail.com>
11719
11720 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11721 Update dependencies.
11722
2ad0baf4
DN
117232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11724
11725 * data.c (init_data): Remove code for UTS, this system is not
11726 supported anymore.
11727
4fcc2638
DN
117282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11729
11730 Don't force ./temacs to start in terminal mode.
11731
11732 * frame.c (make_initial_frame): Initialize faces in all cases, not
11733 only when CANNOT_DUMP is defined.
11734 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11735
c56e0fd5
DN
117362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11737
11738 * dispnew.c (add_window_display_history): Use const for the string
11739 pointer. Remove declaration, not needed.
11740
333d54da 117412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11742
55d4c1b2 11743 Use 'inline', not 'INLINE'.
333d54da 11744 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11745 * alloc.c, fontset.c (INLINE): Remove.
11746 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11747 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11748 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11749 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11750 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11751
738db178
DN
117522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11753
11754 Make it possible to run ./temacs.
11755
11756 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11757 syms_of_callproc does the same thing. Remove test for
11758 "initialized", do it in the caller.
11759 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11760
620c53a6
SM
117612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11762
11763 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11764 (read_minibuf): Use get_minibuffer.
11765 (syms_of_minibuf): Use DEFSYM.
11766 (Qmetadata): New var.
11767 * data.c (Qbuffer): Don't make it static.
11768 (syms_of_data): Use DEFSYM.
11769
e003a292
PE
117702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11771
11772 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11773 (CCL_CODE_MIN): New macro.
11774
ed008a6d
PE
117752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11776
3687c2ef
PE
11777 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11778
ed008a6d
PE
11779 * eval.c (Qdebug): Now static.
11780 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11781 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11782 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11783
d66c4c7c
CY
117842011-05-29 Chong Yidong <cyd@stupidchicken.com>
11785
11786 * image.c: Various fixes to ImageMagick code comments.
11787 (Fimagemagick_types): Doc fix.
11788
5fbc2025
PE
117892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11790
0196f88a
PE
11791 Minor fixes prompted by GCC 4.6.0 warnings.
11792
11793 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11794
5fbc2025
PE
11795 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11796 (x_clipboard_manager_save_all): Move extern decl to ...
11797 * xterm.h: ... here, so that it can be checked for consistency.
11798
1dd3c2d9
CY
117992011-05-29 Chong Yidong <cyd@stupidchicken.com>
11800
11801 * xselect.c (x_clipboard_manager_save_frame)
11802 (x_clipboard_manager_save_all): New functions.
11803 (Fx_clipboard_manager_save): Lisp function deleted.
11804
11805 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11806 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11807
11808 * xterm.h: Update prototype.
11809
5ba6571d
WX
118102011-05-28 William Xu <william.xwl@gmail.com>
11811
11812 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11813 exiting (Bug#8239).
11814
3eaff834
JM
118152011-05-28 Jim Meyering <meyering@redhat.com>
11816
e1900994 11817 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11818 * fns.c (to_uchar): Define.
11819 (crypto_hash_function): Use it to convert some newly-signed
11820 variables to unsigned, to avoid sign-extension bugs. For example,
11821 without this change, (md5 "truc") would evaluate to
11822 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11823 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11824 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11825
0f6990a7
PE
118262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11827
11828 Integer overflow fixes.
c8a9ca5a 11829
08686060
PE
11830 * dbusbind.c: Serial number integer overflow fixes.
11831 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11832 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11833 to hold a serial number that is too large for a fixnum.
11834 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11835 Check for serial numbers out of range. Decode any serial number
59568bf0 11836 that was so large that it became a float. (Bug#8722)
08686060 11837
2d1fc3c7
PE
11838 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11839 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11840 Use XFASTINT rather than XUINT when numbers are nonnegative.
11841 (xd_append_arg, Fdbus_method_return_internal):
11842 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11843 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11844 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11845 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11846 (Bug#8722)
2d1fc3c7 11847
c8a9ca5a
PE
11848 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11849
519e1d69
PE
11850 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11851
6df6ae42 11852 ccl: Add integer overflow checks.
30569699
PE
11853 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11854 (IN_INT_RANGE): New macros.
11855 (ccl_driver): Use them to check for integer overflow when
11856 decoding a CCL program. Many of the new checks are whether XINT (x)
11857 fits in int; it doesn't always, on 64-bit hosts. The new version
11858 doesn't catch all possible integer overflows, but it's an
847044ea 11859 improvement. (Bug#8719)
30569699 11860
c11285dc
PE
11861 * alloc.c (make_event_array): Use XINT, not XUINT.
11862 There's no need for unsigned here.
11863
fdccd48e
PE
11864 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11865 This follows up to the 2011-05-06 change that substituted uintptr_t
11866 for EMACS_INT. This case wasn't caught back then.
11867
37910ab2
PE
11868 Rework Fformat to avoid integer overflow issues.
11869 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11870 now (part of C89). Include <verify.h>.
11871 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11872 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11873 (Fformat): Avoid the prepass trying to compute sizes; it was only
11874 approximate and thus did not catch overflow reliably. Instead, walk
11875 through the format just once, formatting and computing sizes as we go,
11876 checking for integer overflow at every step, and allocating a larger
11877 buffer as needed. Keep track separately whether the format is
11878 multibyte. Keep only the most-recently calculated precision, rather
11879 than them all. Record whether each argument has been converted to
11880 string. Use EMACS_INT, not int, for byte and char and arg counts.
11881 Support field widths and precisions larger than INT_MAX. Avoid
11882 sprintf's undefined behavior with conversion specifications such as %#d
11883 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11884 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11885 formatting out-of-range floating point numbers with int
9173deec 11886 formats. (Bug#8668)
37910ab2 11887
2e6578fb
PE
11888 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11889
0ae6bdee
PE
11890 * data.c: Avoid integer truncation in expressions involving floats.
11891 * data.c: Include <intprops.h>.
11892 (arith_driver): When there's an integer overflow in an expression
11893 involving floating point, convert the integers to floating point
11894 so that the resulting value does not suffer from catastrophic
11895 integer truncation. For example, on a 64-bit host (* 4
11896 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11897 Do not rely on undefined behavior after integer overflow.
11898
de883a70
PE
11899 merge count_size_as_multibyte, parse_str_to_multibyte
11900 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11901 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11902 Check for integer overflow.
11903 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11904 since it's now a duplicate of the other. This is more of
11905 a character than a buffer op, so better that it's in character.c.
11906 * fns.c, print.c: Adjust to above changes.
11907
2ff916cb
PE
119082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11909
11910 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11911
f1b54466
PE
119122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11913
fb1ac845
PE
11914 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11915 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11916 (x_clipboard_manager_save): Now static.
11917 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11918
f1b54466
PE
11919 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11920 (crypto_hash_function): Now static.
11921 Fix pointer signedness problems. Avoid unnecessary initializations.
11922
a9f737ee
CY
119232011-05-27 Chong Yidong <cyd@stupidchicken.com>
11924
11925 * termhooks.h (Vselection_alist): Make it terminal-local.
11926
11927 * terminal.c (create_terminal): Initialize it.
11928
11929 * xselect.c: Support for clipboard managers.
11930 (Vselection_alist): Move to termhooks.h as terminal-local var.
11931 (LOCAL_SELECTION): New macro.
11932 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11933 (symbol_to_x_atom): Remove gratuitous arg.
11934 (x_handle_selection_request, lisp_data_to_selection_data)
11935 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11936 (x_own_selection, x_get_local_selection, x_convert_selection):
11937 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11938 (some_frame_on_display): Delete unused function.
11939 (Fx_own_selection_internal, Fx_get_selection_internal)
11940 (Fx_disown_selection_internal, Fx_selection_owner_p)
11941 (Fx_selection_exists_p): New optional frame arg.
11942 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11943 (x_handle_selection_clear): Don't treat other terminals with the
11944 same keyboard specially. Use the terminal-local Vselection_alist.
11945 (x_clear_frame_selections): Use Frun_hook_with_args.
11946
11947 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11948
11949 * xterm.h: Add support for those atoms.
11950
e067f0c1
CY
119512011-05-26 Chong Yidong <cyd@stupidchicken.com>
11952
11953 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11954 (converted_selections, conversion_fail_tag): New global variables.
11955 (x_selection_request_lisp_error): Free the above.
11956 (x_get_local_selection): Remove unnecessary code.
11957 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11958 of converted selections stored in converted_selections.
11959 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11960 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11961 (x_convert_selection): New function.
11962 (x_handle_selection_event): Simplify.
11963 (x_get_foreign_selection): Don't ignore incoming requests while
11964 waiting for an answer; this will fail when we implement
11965 SAVE_TARGETS, and seems unnecessary anyway.
11966 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11967 (Vx_sent_selection_functions): Doc fix.
11968
0f4aebc0
LL
119692011-05-26 Leo Liu <sdl.web@gmail.com>
11970
11971 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11972
e61124cd
YM
119732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11974
11975 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11976
11977 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11978 for fringe update if it has periodic bitmap.
ac389d0c 11979 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11980 and fringe_bitmap_periodic_p.
11981
11982 * fringe.c (get_fringe_bitmap_data): New function.
11983 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11984 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11985 row. Mark glyph row for fringe update if periodicity changed.
11986
11987 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11988 for fringe update unless it has periodic bitmap.
11989
f16d9837
KH
119902011-05-25 Kenichi Handa <handa@m17n.org>
11991
11992 * xdisp.c (get_next_display_element): Set correct it->face_id for
11993 a static composition.
11994
e1b90ef6
LL
119952011-05-24 Leo Liu <sdl.web@gmail.com>
11996
11997 * deps.mk (fns.o):
11998 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11999
12000 * fns.c (crypto_hash_function, Fsha1): New function.
12001 (Fmd5): Use crypto_hash_function.
12002 (syms_of_fns): Add Ssha1.
12003
7400048f
PE
120042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12005
12006 * gnutls.c: Remove unused macros.
12007 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12008 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12009 Remove macros that are defined and never used.
12010 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12011
abb71cf4
CY
120122011-05-22 Chong Yidong <cyd@stupidchicken.com>
12013
12014 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12015 (Fx_get_selection_internal): Minor cleanup.
12016 (Fx_own_selection_internal): Rename arguments for consistency with
12017 select.el.
12018
6307db39
PE
120192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12020
12021 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12022
f3d4e0a4
CY
120232011-05-22 Chong Yidong <cyd@stupidchicken.com>
12024
12025 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12026
4d8ade89
YM
120272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12028
12029 * dispnew.c (scrolling_window): Don't exclude the case that the
12030 last enabled row in the desired matrix touches the bottom boundary.
12031
32078c8d
GM
120322011-05-21 Glenn Morris <rgm@gnu.org>
12033
12034 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12035 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12036 and add some more files.
32078c8d 12037
7285dc67
EZ
120382011-05-20 Eli Zaretskii <eliz@gnu.org>
12039
12040 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12041 report_file_error introduced by the change from 2011-05-07.
12042
89d1bd22
PE
120432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12044
12045 * systime.h (Time): Define only if emacs is defined.
12046 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12047 where the include path doesn't have X11/X.h by default. See
12048 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12049
cd394be1 120502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12051
12052 * composite.c (find_automatic_composition): Fix previous change.
12053
b9704ad9
GM
120542011-05-20 Glenn Morris <rgm@gnu.org>
12055
12056 * lisp.mk: New file, split from Makefile.in.
12057 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12058 (shortlisp): Remove.
12059 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12060
4a720484
GM
120612011-05-19 Glenn Morris <rgm@gnu.org>
12062
12063 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12064 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12065 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12066 (lisp): Set the order to that of loadup.el.
12067 (shortlisp): Make it a copy of $lisp.
12068 (SOME_MACHINE_LISP): Remove.
12069 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12070 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12071
a28d4396
KH
120722011-05-18 Kenichi Handa <handa@m17n.org>
12073
12074 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12075 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12076 (find_automatic_composition): Mostly rewrite for efficiency.
12077
a2b1fa8e
JB
120782011-05-18 Juanma Barranquero <lekktu@gmail.com>
12079
12080 * makefile.w32-in: Update dependencies.
12081
8e1f5610
CS
120822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12083
12084 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12085 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12086
7025ee00 120872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12088
cdfa6eab
PE
12089 Fix some integer overflow issues, such as string length overflow.
12090
06d6db33
PE
12091 * insdel.c (count_size_as_multibyte): Check for string overflow.
12092
2b4560a8
PE
12093 * character.c (lisp_string_width): Check for string overflow.
12094 Use EMACS_INT, not int, for string indexes and lengths; in
12095 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12096 the resulting string length overflows an EMACS_INT; instead,
12097 report a string overflow if no precision given. When checking for
12098 precision exhaustion, use a check that cannot possibly have
12099 integer overflow. (Bug#8675)
12100 * character.h (lisp_string_width): Adjust to new signature.
12101
cb93f9be
PE
12102 * alloc.c (string_overflow): New function.
12103 (Fmake_string): Use it. This doesn't change behavior, but saves
12104 a few bytes and will simplify future changes.
12105 * character.c (string_escape_byte8): Likewise.
12106 * lisp.h (string_overflow): New decl.
12107
1a1f3366
PE
12108 Fixups, following up to the user-interface timestamp change.
12109 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12110 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12111 * msdos.c (mouse_get_pos): Likewise.
12112 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12113 * w32gui.h (Time): Define by including "systime.h" rather than by
12114 declaring it ourselves. (Bug#8664)
12115
d4e3e4d3
PE
12116 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12117 * image.c (clear_image_cache): Likewise.
12118
f6a24d19
PE
12119 * term.c (term_mouse_position): Don't assume time_t wraparound.
12120
08dc5ae6
PE
12121 Be more systematic about user-interface timestamps.
12122 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12123 and sometimes 'EMACS_UINT', to represent these timestamps.
12124 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12125 This makes the code easier to follow, and makes it easier to catch
12126 integer overflow bugs such as Bug#8664.
12127 * frame.c (Fmouse_position, Fmouse_pixel_position):
12128 Use Time, not unsigned long, for user-interface timestamps.
12129 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12130 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12131 * keyboard.h (last_event_timestamp): Likewise.
12132 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12133 * menu.h (xmenu_show): Likewise.
12134 * term.c (term_mouse_position): Likewise.
12135 * termhooks.h (struct input_event.timestamp): Likewise.
12136 (struct terminal.mouse_position_hook): Likewise.
12137 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12138 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12139 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12140 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12141 what it was before.
12142 * menu.h, termhooks.h: Include "systime.h", for Time.
12143
8e55734a
PE
12144 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12145 Don't assume that the difference between two unsigned long values
12146 can fit into an integer. At this point, we know button_down_time
12147 <= event->timestamp, so the difference must be nonnegative, so
12148 there's no need to cast the result if double-click-time is
12149 nonnegative, as it should be; check that it's nonnegative, just in
12150 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12151 apart (about 25 days). (Bug#8664)
8e55734a 12152
841f1b75 12153 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12154 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12155
3e26f69c
PE
12156 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12157 that always fit in int. Use a sentinel instead of a counter, to
12158 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12159 * frame.h (struct frame): Use int for menu_bar_items_used
12160 instead of EMACS_INT, since it always fits in int.
3e26f69c 12161
5cc152c0
PE
12162 * menu.c (grow_menu_items): Check for int overflow.
12163
d89eb65e
PE
12164 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12165
5235bd3e
PE
12166 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12167 Before, the code was not consistent. These values cannot exceed
12168 2**31 - 1 so there's no need to make them unsigned.
12169 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12170 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12171 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12172 as modifiers.
12173 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12174
bc827e23
PE
12175 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12176 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12177 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12178 presumably because the widths might not match.
12179
78eb494e
PE
12180 * window.c (size_window): Avoid needless test at loop start.
12181
04f2d78b
CB
121822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12183
12184 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12185
d2fc7e3d 121862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12187
12188 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12189
d2fc7e3d 121902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12191
12192 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12193 `width' to `bar_area_x' and `bar_area_width', respectively.
12194 (x_scroll_run): Take account of fringe background extension.
12195
04f2d78b
CB
12196 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12197 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12198 `bar_area_width', respectively.
12199 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12200 background extension.
12201
79b70037
GM
122022011-05-10 Jim Meyering <meyering@redhat.com>
12203
12204 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12205
2f142cc5
JB
122062011-05-10 Juanma Barranquero <lekktu@gmail.com>
12207
12208 * image.c (Finit_image_library): Return t for built-in image types,
12209 like pbm and xbm. (Bug#8640)
12210
57679c86
AS
122112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12212
12213 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12214
888c9e86
EZ
122152011-05-07 Eli Zaretskii <eliz@gnu.org>
12216
b0512a1d
EZ
12217 * w32console.c (Fset_screen_color): Doc fix.
12218 (Fget_screen_color): New function.
12219 (syms_of_ntterm): Defsubr it.
12220
7285dc67
EZ
12221 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12222 unlink the temporary file if Fcall_process didn't create it in the
12223 first place.
12224 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12225 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12226 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12227 cue to call_process_cleanup not to close that handle.
12228
4d3fcc8e
BK
122292011-05-07 Ben Key <bkey76@gmail.com>
12230
12231 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12232 one of two shell specific rules, either bootstrap-temacs-CMD or
12233 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12234 to the previous implementation of the bootstrap-temacs rule.
12235 The bootstrap-temacs-CMD rule is similar to the previous
12236 implementation of the bootstrap-temacs rule except that it
12237 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12238 variable.
12239
12240 These changes, along with some changes to nt/configure.bat,
12241 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12242 earlier fix to add support for --cflags and --ldflags options
12243 that include quotes so that it works whether make uses cmd or
12244 sh as the shell.
12245
b4289b64
MA
122462011-05-06 Michael Albinus <michael.albinus@gmx.de>
12247
12248 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12249 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12250 is a constant.
12251 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12252 a string. Handle both cases.
12253 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12254 (Fdbus_register_method): Use Qinvalid_function.
12255
af4c0e28
JB
122562011-05-06 Juanma Barranquero <lekktu@gmail.com>
12257
12258 * makefile.w32-in: Update dependencies.
12259 (LISP_H): Add inttypes.h and stdin.h.
12260 (PROCESS_H): Add unistd.h.
12261
c51453d9
EZ
122622011-05-06 Eli Zaretskii <eliz@gnu.org>
12263
12264 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12265 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12266
8ff0ac3c 122672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12268
4c4b566b
PE
12269 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12270
aab2b9b5
PE
12271 * term.c (vfatal): Remove stray call to va_end.
12272 It's not needed and the C Standard doesn't allow it here anyway.
12273
c378da0b
PE
12274 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12275 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12276
288b08c7
PE
12277 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12278 bytes.
12279
e3601888
PE
12280 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12281
db6c0e74
PE
12282 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12283
dd5963ea
PE
12284 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12285
88c9450f
PE
12286 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12287
2f9442b8
PE
12288 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12289
c032b5f8
PE
12290 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12291 * charset.c (Fdefine_charset_internal): Don't initialize
12292 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12293 32-bit int (Bug#8600).
a108c10b
PE
12294
12295 * lread.c (read_integer): Be more consistent with string-to-number.
12296 Use string_to_number to do the actual conversion; this avoids
12297 rounding errors and fixes some other screwups. Without this fix,
12298 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12299 (digit_to_number): Move earlier, for benefit of read_integer.
12300 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12301 not a digit in any supported base. (Bug#8602)
a108c10b 12302
ad5f9eea
PE
12303 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12304
aec1708a
PE
12305 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12306 to match comment at start of function. This also removes a
12307 GCC warning about overflow in a 32+64-bit port.
12308
47be4ab5
PE
12309 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12310
371cac43
PE
12311 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12312 Reported by Stefan Monnier in
12313 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12314 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12315 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12316
d01a7826
PE
12317 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12318 (EMACS_UINTPTR): Likewise, with uintptr_t.
12319
7fd47d5c
PE
12320 * lisp.h: Prefer 64-bit EMACS_INT if available.
12321 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12322 on 32-bit hosts that have 64-bit int, so that they can access
12323 large files.
122b0c86
PE
12324 However, temporarily disable this change unless the temporary
12325 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12326
8727937b
PE
12327 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12328
8ac068ac
PE
12329 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12330 This removes an assumption that EMACS_INT and long are the same
12331 width as pointers. The assumption is true for Emacs porting targets
12332 now, but we want to make other targets possible.
12333 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12334 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12335 In the rest of the code, change types of integers that hold casted
12336 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12337 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12338 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12339 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12340 No need to cast type when ORing.
12341 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12342 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12343 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12344 assume EMACS_INT is the same width as char *.
12345 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12346 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12347 Remove no-longer-needed casts.
12348 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12349 (xg_tool_bar_help_callback, xg_make_tool_item):
12350 Use EMACS_INTPTR to hold an integer
12351 that will be cast to void *; this can avoid a GCC warning
12352 if EMACS_INT is not the same width as void *.
12353 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12354 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12355 (current_message_1, set_message_1):
12356 Use a local to convert to proper width without a cast.
12357 * xmenu.c (dialog_selection_callback): Likewise.
12358
ede49d71
PE
12359 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12360 Also, don't assume VALBITS / RAND_BITS is less than 5,
12361 and don't rely on undefined behavior when shifting a 1 left into
12362 the sign bit.
12363 * lisp.h (get_random): Change signature to match.
12364
2f30ecd0
PE
12365 * lread.c (hash_string): Use size_t, not int, for hash computation.
12366 Normally we prefer signed values; but hashing is special, because
12367 it's better to use unsigned division on hash table sizes so that
12368 the remainder is nonnegative. Also, size_t is the natural width
12369 for hashing into memory. The previous code used 'int', which doesn't
12370 retain enough info to hash well into very large tables.
12371 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12372
2a866e7b
PE
12373 * dbusbind.c: Don't possibly lose pointer info when converting.
12374 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12375 Use XPNTR rather than XHASH, so that the high-order bits of
12376 the pointer aren't lost when converting through void *.
12377
51639eac
PE
12378 * eval.c (Fautoload): Don't double-shift a pointer.
12379
92394119
PE
12380 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12381
dbdb9a7c
JB
123822011-05-06 Juanma Barranquero <lekktu@gmail.com>
12383
12384 * gnutls.c (DEF_GNUTLS_FN):
12385 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12386
db7a0b4f
AS
123872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12388
12389 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12390 marker. (Bug#8610)
12391
cd394be1 123922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12393
12394 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12395 New version that can reserve upto 2GB of heap space.
12396
f7ff1b0f 123972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12398
12399 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12400
639c109b
TZ
124012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12402
12403 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12404 `gnutls_certificate_set_x509_key_file'.
12405
d2127135
JB
124062011-05-05 Juanma Barranquero <lekktu@gmail.com>
12407
12408 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12409 Update dependencies.
12410
e968f4f3
JB
124112011-05-04 Juanma Barranquero <lekktu@gmail.com>
12412
12413 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12414 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12415 Remove unused parameter `fildes'.
12416 * process.c (read_process_output, send_process): Don't pass it.
12417
84d358f0
JB
124182011-05-04 Juanma Barranquero <lekktu@gmail.com>
12419
12420 Fix previous change: the library cache is defined in w32.c.
12421 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12422 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12423
0898ca10
JB
124242011-05-04 Juanma Barranquero <lekktu@gmail.com>
12425
12426 Implement dynamic loading of GnuTLS on Windows.
12427
12428 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12429 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12430 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12431 Declare.
12432
12433 * gnutls.c (Qgnutls_dll): Define.
12434 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12435 (gnutls_*): Declare function pointers.
12436 (init_gnutls_functions): New function to initialize function pointers.
12437 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12438 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12439 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12440 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12441 (emacs_gnutls_write, emacs_gnutls_read)
12442 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12443 (Fgnutls_available_p): New function.
12444 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12445 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12446 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12447
12448 * image.c: Include w32.h.
12449 (Vimage_type_cache): Delete.
12450 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12451 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12452 (w32_delayed_load): Move to w32.c.
12453
12454 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12455
12456 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12457 (w32_delayed_load): Move from image.c. When loading a library, record
12458 its filename in the :loaded-from property of the library id.
12459 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12460 Initialize and staticpro them.
12461 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12462
12463 * process.c: Include lisp.h before w32.h, not after.
12464 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12465 instead of gnutls_record_check_pending.
12466
12467 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12468
ff4de4aa
TZ
124692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12470
12471 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12472 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12473 as passed in.
12474
abe95abb
JD
124752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12476
12477 * xterm.c (x_set_frame_alpha): Do not set property on anything
12478 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12479
e16e55d4
JB
124802011-05-02 Juanma Barranquero <lekktu@gmail.com>
12481
12482 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12483
bafcf6a5
JB
124842011-05-02 Juanma Barranquero <lekktu@gmail.com>
12485
12486 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12487 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12488 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12489 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12490 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12491 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12492 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12493 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12494 (Qgnutls_bootprop_callbacks_verify): Make static.
12495
e7a6747f
AS
124962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12497
19ed11ba
AS
12498 * callproc.c: Indentation fixup.
12499
e7a6747f 12500 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12501 (wait_for_termination, interruptible_wait_for_termination):
12502 Move after wait_for_termination_1.
e7a6747f 12503
1ef14cb4
LMI
125042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12505
12506 * sysdep.c (interruptible_wait_for_termination): New function
12507 which is like wait_for_termination, but allows keyboard
12508 interruptions.
12509
12510 * callproc.c (Fcall_process): Add (:file "file") as an option for
12511 the STDOUT buffer.
12512 (Fcall_process_region): Ditto.
12513
330d880c
EZ
125142011-04-30 Eli Zaretskii <eliz@gnu.org>
12515
8db90b73
EZ
12516 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12517 rather than `XVECTOR (FOO)->size'.
12518
330d880c
EZ
12519 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12520 inttypes.h, as a gnulib replacement is used if it not available in
12521 system headers.
12522
15cbd324
EZ
125232011-04-21 Eli Zaretskii <eliz@gnu.org>
12524
12525 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12526 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12527 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12528
12529 * coding.c (coding_alloc_by_realloc): Error out if destination
12530 will grow beyond MOST_POSITIVE_FIXNUM.
12531 (decode_coding_emacs_mule): Abort if there isn't enough place in
12532 charbuf for the composition carryover bytes. Reserve an extra
12533 space for up to 2 characters produced in a loop.
12534 (decode_coding_iso_2022): Abort if there isn't enough place in
12535 charbuf for the composition carryover bytes.
12536
125372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12538
ae940cca
EZ
12539 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12540 aborting when %lld or %lll format is passed.
12541 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12542 %llo or %llx format is passed. (Bug#8545)
12543
03ab8921
EZ
12544 * window.c (window_scroll_line_based): Use a marker instead of
12545 simple variables to record original value of point. (Bug#7952)
12546
afda1437
EZ
12547 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12548 produced by %s or %c overflows available buffer space. (Bug#8545)
12549
f76dee0c
PE
125502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12551
12552 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12553 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12554
fdc5744d
JB
125552011-04-28 Juanma Barranquero <lekktu@gmail.com>
12556
12557 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12558
638f053a
JB
125592011-04-28 Juanma Barranquero <lekktu@gmail.com>
12560
12561 * keyboard.c (Qdelayed_warnings_hook): Define.
12562 (command_loop_1): Run `delayed-warnings-hook'
12563 if Vdelayed_warnings_list is non-nil.
12564 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12565 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12566
d178f871
EZ
125672011-04-28 Eli Zaretskii <eliz@gnu.org>
12568
12569 * doprnt.c (doprnt): Don't return value smaller than the buffer
12570 size if the message was truncated. (Bug#8545).
12571
b124fd93
JB
125722011-04-28 Juanma Barranquero <lekktu@gmail.com>
12573
12574 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12575 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12576
e810457d
PE
125772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12578
12579 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12580
ea51cceb
JB
125812011-04-27 Juanma Barranquero <lekktu@gmail.com>
12582
12583 * makefile.w32-in: Update dependencies.
12584
94dcfacf
EZ
125852011-04-27 Eli Zaretskii <eliz@gnu.org>
12586
12587 Improve `doprnt' and its usage. (Bug#8545)
12588 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12589 `format_end'. Remove support for %l as a conversion specifier.
12590 Don't use xrealloc. Improve diagnostics when the %l size modifier
12591 is used. Update the commentary.
12592
12593 * eval.c (verror): Simplify calculation of size_t.
12594
12595 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12596 messages.
12597
f61f41d7
PE
125982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12599
12600 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12601 change.
12602
96fb4434
PE
126032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12604
12605 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12606 This makes this file independent of the recent pseudovector change.
12607
671875da 126082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12609
69e9b5a3
PE
12610 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12611
b5f869a7 12612 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12613 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12614 Remove unused local.
c8926152 12615 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12616
841a1577 12617 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12618 GCC 4.6.0 optimizes based on type-based alias analysis.
12619 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12620 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12621 != &v->size, and therefore "v->size = 1; b->size = 2; return
12622 v->size;" must therefore return 1. This assumption is incorrect
12623 for Emacs, since it type-puns struct Lisp_Vector * with many other
12624 types. To fix this problem, this patch adds a new type struct
f904488f 12625 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12626 and pseudovectors, and helps optimizing compilers not get fooled
12627 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12628 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12629 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12630 the size member.
eab3844f
PE
12631 (XSETPVECTYPE): Rewrite in terms of new macro.
12632 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12633 This is a bit clearer, and further avoids the possibility of
12634 undesirable aliasing.
12635 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12636 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12637 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12638 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12639 (ASIZE): Now uses header.size rather than size.
12640 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12641 to avoid the hassle of writing XVECTOR (foo)->header.size.
12642 (struct vectorlike_header): New type.
eab3844f
PE
12643 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12644 object, to help avoid aliasing.
12645 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12646 (SUBRP): Likewise, since Lisp_Subr is a special case.
12647 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12648 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12649 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12650 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12651 changed to be "header.size" and "header.next".
12652 * buffer.h (struct buffer): Likewise.
12653 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12654 * frame.h (struct frame): Likewise.
12655 * process.h (struct Lisp_Process): Likewise.
12656 * termhooks.h (struct terminal): Likewise.
12657 * window.c (struct save_window_data, struct saved_window): Likewise.
12658 * window.h (struct window): Likewise.
12659 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12660 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12661 * buffer.c (init_buffer_once): Likewise.
12662 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12663 special case.
12664 * process.c (Fformat_network_address): Use local var for size,
12665 for brevity.
12666
0df1eac5
PE
12667 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12668
847ab9d1 12669 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12670 * data.c (atof): Remove decl; no longer used or needed.
12671 (digit_to_number): Move to lread.c.
12672 (Fstring_to_number): Use new string_to_number function, to be
12673 consistent with how the Lisp reader treats infinities and NaNs.
12674 Do not assume that floating-point numbers represent EMACS_INT
12675 without losing information; this is not true on most 64-bit hosts.
12676 Avoid double-rounding errors, by insisting on integers when
12677 parsing non-base-10 numbers, as the documentation specifies.
12678 * lisp.h (string_to_number): New decl, replacing ...
12679 (isfloat_string): Remove.
bc0a5c13 12680 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12681 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12682 appears to have been a coding error. Similarly, do not accept
12683 strings like +-1e0 as floating point numbers. Do not report
12684 overflow for integer overflows unless the base is not 10 which
12685 means we have no simple and reliable way to continue.
12686 Break out the floating-point parsing into a new
12687 function string_to_number, so that Fstring_to_number parses
12688 floating point numbers consistently with the Lisp reader.
04f2d78b 12689 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12690 (E_CHAR, EXP_INT): Remove, replacing with ...
12691 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12692 (string_to_number): New function, replacing isfloat_string.
12693 This function checks for valid syntax and produces the resulting
12694 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12695 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12696 so that overflow for non-base-10 numbers is reported only when
12697 there's no portable and simple way to convert to floating point.
452f4150 12698
67769ffc
PE
12699 * textprop.c (set_text_properties_1): Rewrite for clarity,
12700 and to avoid GCC warning about integer overflow.
12701
c20db43f
PE
12702 * intervals.h (struct interval): Use EMACS_INT for members
12703 where EMACS_UINT might cause problems. See
12704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12705 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12706 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12707 All uses changed.
37aa2f85
PE
12708 (offset_intervals): Tell GCC not to worry about length overflow
12709 when negating a negative length.
c20db43f 12710
2538aa2f
PE
12711 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12712 (overrun_check_free): Likewise.
12713
f2d3008d
PE
12714 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12715 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12716 word size.
12717
ec8df744
PE
12718 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12719 (gnutls_make_error): Rename local to avoid shadowing.
12720 (gnutls_emacs_global_deinit): ifdef out; not used.
12721 (Fgnutls_boot): Use const for pointer to readonly storage.
12722 Comment out unused local. Fix pointer signedness problems.
12723
640ee02d
PE
12724 * lread.c (openp): Don't stuff size_t into an 'int'.
12725 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12726 about possible signed overflow.
12727
6048fb2a
PE
12728 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12729 (GDK_KEY_g): Don't define if already defined.
12730 (xg_prepare_tooltip): Avoid pointer signedness problem.
12731 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12732
fa3c87e1
PE
12733 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12734 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12735
2172544b
PE
12736 * xfns.c (Fx_window_property): Simplify a bit,
12737 to make a bit faster and to avoid GCC 4.6.0 warning.
12738 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12739
9b821a21
PE
12740 * fns.c (internal_equal): Don't assume size_t fits in int.
12741
3c616cfa
PE
12742 * alloc.c (compact_small_strings): Tighten assertion a little.
12743
c2982e87
PE
12744 Replace pEd with more-general pI, and fix some printf arg casts.
12745 * lisp.h (pI): New macro, generalizing old pEd macro to other
12746 conversion specifiers. For example, use "...%"pI"d..." rather
12747 than "...%"pEd"...".
12748 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12749 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12750 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12751 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12752 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12753 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12754 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12755 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12756 64-bit hosts.
12757 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12758 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12759 * print.c (safe_debug_print, print_object): Likewise.
12760 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12761 to int.
6f04d126
PE
12762 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12763 avoiding the 0 flag, which is not portable.
c2982e87
PE
12764 * process.c (Fmake_network_process): Use pI to avoid cast.
12765 * region-cache.c (pp_cache): Likewise.
12766 * xdisp.c (decode_mode_spec): Likewise.
12767 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12768 behavior on 64-bit hosts with printf arg.
6f04d126 12769 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12770 (x_stop_queuing_selection_requests): Likewise.
12771 (x_get_window_property): Don't truncate byte count to an 'int'
12772 when tracing.
0b432f21 12773
5e073ec7
PE
12774 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12775 here, since it parses constructs like leading '-' and spaces,
12776 which are not wanted; and it overflows with large numbers.
12777 Instead, simply match F[0-9]+, which is what is wanted anyway.
12778
36372bf9
PE
12779 * alloc.c: Remove unportable assumptions about struct layout.
12780 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12781 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12782 (allocate_vectorlike, make_pure_vector): Use the new macros,
12783 plus offsetof, to remove unportable assumptions about struct layout.
12784 These assumptions hold on all porting targets that I know of, but
12785 they are not guaranteed, they're easy to remove, and removing them
12786 makes further changes easier.
12787
0b432f21
PE
12788 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12789 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12790 (string_overrun_cookie): Now const. Use initializers that
12791 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12792 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12793 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12794 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12795 multiple of sizeof (EMACS_INT); it need not be, if
12796 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12797 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12798
895009e1
JB
127992011-04-26 Juanma Barranquero <lekktu@gmail.com>
12800
12801 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12802
6a7a1b0b
TZ
128032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12804
12805 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12806 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12807 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12808
841a1577 128092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12810
12811 * lisp.h (Qdebug): List symbol.
895009e1 12812 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12813 * keyboard.c (debug-on-event): New variable.
12814 (handle_user_signal): Break into debugger when debug-on-event
12815 matches the current signal symbol.
12816
f2d3ba6f
DN
128172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12818
12819 * alloc.c (check_sblock, check_string_bytes)
12820 (check_string_free_list): Convert to standard C.
12821
42ce4c63
TZ
128222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12823
12824 * w32.c (emacs_gnutls_push): Fix typo.
12825
825cd63c
EZ
128262011-04-25 Eli Zaretskii <eliz@gnu.org>
12827
fb11d64d
EZ
12828 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12829 "cast to pointer from integer of different size".
12830
825cd63c
EZ
12831 Improve doprnt and its use in verror. (Bug#8545)
12832 * doprnt.c (doprnt): Document the set of format control sequences
12833 supported by the function. Use SAFE_ALLOCA instead of always
12834 using `alloca'.
12835
12836 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12837 is one byte too soon. Don't use xrealloc; instead xfree and
12838 xmalloc anew.
12839
e061a11b
TZ
128402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12841
12842 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12843 callbacks stage.
12844
12845 * gnutls.c: Renamed global_initialized to
12846 gnutls_global_initialized. Added internals for the
12847 :verify-hostname-error, :verify-error, and :verify-flags
12848 parameters of `gnutls-boot' and documented those parameters in the
12849 docstring. Start callback support.
9173deec
JB
12850 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12851 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12852 on error. Return error code.
e061a11b
TZ
12853 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12854 (emacs_gnutls_read): Likewise.
12855 (Fgnutls_boot): Return handshake error code.
12856 (emacs_gnutls_handle_error): New function.
12857 (wsaerror_to_errno): Likewise.
12858
12859 * w32.h (emacs_gnutls_pull): Add prototype.
12860 (emacs_gnutls_push): Likewise.
12861
12862 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12863 (emacs_gnutls_push): Likewise.
12864
128652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12866
12867 * process.c (wait_reading_process_output): Check if GnuTLS
12868 buffered some data internally if no FDs are set for TLS
12869 connections.
12870
12871 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12872 (LIBS): Link to USER_LIBS.
12873 ($(BLD)/gnutls.$(0)): New target.
12874
fa6996bc
EZ
128752011-04-24 Eli Zaretskii <eliz@gnu.org>
12876
eb35682e
EZ
12877 * xdisp.c (handle_single_display_spec): Rename the
12878 display_replaced_before_p argument into display_replaced_p, to
12879 make it consistent with the commentary. Fix typos in the
12880 commentary.
12881
e2ad650c
EZ
12882 * textprop.c (syms_of_textprop): Remove dead code.
12883 (copy_text_properties): Delete obsolete commentary about an
12884 interface that was deleted long ago. Fix typos in the description
12885 of arguments.
12886
1b2de274
EZ
12887 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12888 to changes in oldXMenu/XMenu.h from 2011-04-16.
12889 <menu_help_message, prev_menu_help_message>: Constify.
12890 (IT_menu_make_room): menu->help_text is now `const char **';
12891 adjust.
12892
12893 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12894 to changes in oldXMenu/XMenu.h from 2011-04-16.
12895 (struct XMenu): Declare `help_text' `const char **'.
12896
12897 * xfaces.c <Qunspecified>: Make extern again.
12898
12899 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12900 required by POSIX.
1b2de274 12901
762b15be
EZ
12902 * doc.c (get_doc_string): Improve the format passed to `error'.
12903
12904 * doprnt.c (doprnt): Improve commentary.
12905
12906 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12907
12908 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12909 them with etags.
12910
f1052e5d
EZ
12911 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12912 changes in globals.h immediately force recompilation.
762b15be
EZ
12913 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12914 $(CURDIR)/s/ms-w32.h.
12915 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12916
fa6996bc
EZ
12917 * character.c (Fchar_direction): Function deleted.
12918 (syms_of_character): Don't defsubr it.
12919 <char-direction-table>: Deleted.
12920
e6c3da20
EZ
129212011-04-23 Eli Zaretskii <eliz@gnu.org>
12922
12923 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12924 * doprnt.c: Include limits.h.
12925 (SIZE_MAX): New macro.
04f2d78b
CB
12926 (doprnt): Return a size_t value. 2nd arg is now size_t.
12927 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12928 Improve overflow protection. Support `l' modifier for integer
12929 conversions. Support %l conversion. Don't assume an EMACS_INT
12930 argument for integer conversions and for %c.
12931
12932 * lisp.h (doprnt): Restore prototype.
12933
12934 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12935 $(SRC)/character.h.
12936
12937 * Makefile.in (base_obj): Add back doprnt.o.
12938
12939 * deps.mk (doprnt.o): Add back prerequisites.
12940 (callint.o): Depend on character.h.
12941
12942 * eval.c (internal_lisp_condition_case): Include the handler
12943 representation in the error message.
12944 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12945 when breaking from the loop.
12946
12947 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12948
12949 * callint.c (Fcall_interactively): When displaying error message
12950 about invalid control letter, pass the character's codepoint, not
12951 a pointer to its multibyte form. Improve display of the character
12952 in octal and display also its hex code.
12953
12954 * character.c (char_string): Use %x to display the (unsigned)
12955 codepoint of an invalid character, to avoid displaying a bogus
12956 negative value.
12957
12958 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12959 `error', not SYMBOL_NAME itself.
12960
12961 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12962 character arguments to `error'.
12963
12964 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12965 to `error' in error message about FINAL_CHAR argument. Make sure
12966 FINAL_CHAR is a character, and use %c when it is passed as
12967 argument to `error'.
12968
4ffd0d6b 129692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12970
12971 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12972
12973 * w32.c: Include <time.h>.
12974 (sys_localtime): New function.
12975
4ffd0d6b 129762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12977
12978 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12979
4ffd0d6b 12980 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12981
4ffd0d6b 129822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12983
4ffd0d6b
GM
12984 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12985 zombies (Bug#8467).
aac0c6e3 12986
04c56954
EZ
129872011-04-19 Eli Zaretskii <eliz@gnu.org>
12988
12989 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12990 gl_state.e_property when gl_state.object is Qt.
12991
12992 * insdel.c (make_gap_larger): Remove limitation of buffer size
12993 to <= INT_MAX.
12994
16a43933
CY
129952011-04-18 Chong Yidong <cyd@stupidchicken.com>
12996
12997 * xdisp.c (lookup_glyphless_char_display)
12998 (produce_glyphless_glyph): Handle cons cell entry in
12999 glyphless-char-display.
13000 (Vglyphless_char_display): Document it.
13001
13002 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13003 glyphless-char-display.
13004
4581706e
CY
130052011-04-17 Chong Yidong <cyd@stupidchicken.com>
13006
13007 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13008
13009 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13010
13011 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13012 definition for no-X builds.
13013
4887c6e2 130142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13015
fd35b6f9
PE
13016 Static checks with GCC 4.6.0 and non-default toolkits.
13017
5c1ccb01
PE
13018 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13019
006c5daa
PE
13020 * process.c (keyboard_bit_set): Define only if SIGIO.
13021 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13022 (send_process): Repair possible setjmp clobbering.
13023
efc736d3
PE
13024 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13025
4e2fe2e6
PE
13026 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13027
f97334a2
PE
13028 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13029
4e75f29d
PE
13030 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13031 Define only if needed.
13032
90efadd1
PE
13033 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13034 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13035 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13036
3c647824
PE
13037 * dispextern.h (struct redisplay_interface): Rename param
13038 to avoid shadowing.
e264f262 13039 * termhooks.h (struct terminal): Likewise.
761383f4 13040 * xterm.c (xembed_send_message): Likewise.
3c647824 13041
b58c5c4a
PE
13042 * insdel.c (make_gap_smaller): Define only if
13043 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13044
cad59032
PE
13045 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13046 it.
13047
c339dc2e
PE
13048 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13049 so that we aren't warned about unused symbols.
13050
91a3e27b
PE
13051 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13052
399c71d3 13053 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13054
8ffc96f5
PE
13055 * xfns.c (x_real_positions): Mark locals as initialized.
13056
eef9bc79
PE
13057 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13058
098db9dd
PE
13059 * xterm.c: Fix problems found by static analysis with other toolkits.
13060 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13061 (x_dispatch_event): Declare static if USE_GTK, and
13062 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13063 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13064 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13065 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13066 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13067
eb18f6cc
PE
13068 * xmenu.c (menu_help_callback): Pointer type fixes.
13069 Use const pointers when pointing at readonly data. Avoid pointer
13070 signedness clashes.
13071 (FALSE): Remove unused macro.
13072 (update_frame_menubar): Remove unused decl.
13073
1fe72bf8
PE
13074 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13075
60d9e1db
PE
13076 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13077 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13078 (single_menu_item): Rename local to avoid shadowing.
13079
39261c26
PE
13080 * keyboard.c (make_lispy_event): Remove unused local var.
13081
018c5e19
PE
13082 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13083 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13084
63d2b86e
PE
13085 * bitmaps: Change bitmaps from unsigned char back to the X11
13086 compatible char. Avoid the old compiler warnings about
13087 out-of-range initializers by using, for example, '\xab' rather
13088 than 0xab.
13089
aefd87e1
PE
13090 * xgselect.c (xgselect_initialize): Check vs interface
13091 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13092
bf501fb9
PE
13093 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13094
e9829fdf
PE
13095 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13096 to read-only memory.
13097
1086c095
PE
13098 * fns.c (vector): Remove; this old hack is no longer needed.
13099
2baccd04 13100 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13101 Remove unused var.
dde42981 13102 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13103
72391843 13104 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13105
436c16df 13106 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13107 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13108 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13109
92bb796d 13110 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13111 (x_term_init): Remove local to avoid shadowing.
92bb796d 13112
764430a3 13113 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13114
13115 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13116 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13117
d1dfb56c
EZ
131182011-04-16 Eli Zaretskii <eliz@gnu.org>
13119
c4354cb4
EZ
13120 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13121
d1dfb56c
EZ
13122 Fix regex.c, syntax.c and friends for buffers > 2GB.
13123 * syntax.h (struct gl_state_s): Declare character position members
13124 EMACS_INT.
13125
13126 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13127
04f2d78b
CB
13128 * textprop.c (verify_interval_modification, interval_of):
13129 Declare arguments EMACS_INT.
d1dfb56c
EZ
13130
13131 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13132 EMACS_INT.
13133
13134 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13135
13136 * indent.c (Fvertical_motion): Local variable it_start is now
13137 EMACS_INT.
13138
13139 * regex.c (re_match, re_match_2, re_match_2_internal)
13140 (bcmp_translate, regcomp, regexec, print_double_string)
13141 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13142 (re_compile_pattern, re_exec): Declare arguments and local
13143 variables `size_t' and `ssize_t' and return values `regoff_t', as
13144 appropriate.
13145 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13146 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13147 <compile_stack_type>: `size' and `avail' are now `size_t'.
13148
13149 * regex.h <regoff_t>: Use ssize_t, not int.
13150 (re_search, re_search_2, re_match, re_match_2): Arguments that
13151 specify buffer/string position and length are now ssize_t and
13152 size_t. Return type is regoff_t.
13153
613052cd
BK
131542011-04-16 Ben Key <bkey76@gmail.com>
13155
13156 * nsfont.m: Fixed bugs in ns_get_family and
13157 ns_descriptor_to_entity that were caused by using free to
13158 deallocate memory blocks that were allocated by xmalloc (via
13159 xstrdup). This caused Emacs to crash when compiled with
13160 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13161 --enable-checking=xmallocoverrun). xfree is now used to
13162 deallocate these memory blocks.
13163
4170f62f 131642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13165
71b41406
PE
13166 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13167
9587a89d
PE
13168 emacs_write: Accept and return EMACS_INT for sizes.
13169 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13170 et seq.
13171 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13172 Accept and return EMACS_INT.
13173 (emacs_gnutls_write): Return the number of bytes written on
13174 partial writes.
13175 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13176 (emacs_read, emacs_write): Remove check for negative size, as the
13177 Emacs source code has been audited now.
9587a89d
PE
13178 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13179 (emacs_read, emacs_write): Use it.
273a5f82
PE
13180 * process.c (send_process): Adjust to the new signatures of
13181 emacs_write and emacs_gnutls_write. Do not attempt to store
13182 a byte offset into an 'int'; it might overflow.
9587a89d 13183 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13184
3e047f51
PE
13185 * sound.c: Don't assume sizes fit in 'int'.
13186 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13187 Return EMACS_INT, not int.
3e047f51 13188 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13189 Accept EMACS_INT, not int.
13190 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13191 record read return values.
13192
cc39a9db
BK
131932011-04-15 Ben Key <bkey76@gmail.com>
13194
c9d0ec6d
JB
13195 * keyboard.c (Qundefined): Don't declare static since it is used
13196 in nsfns.m.
13197 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13198 static since they are used in nsfont.m.
cc39a9db 13199
6c60eb9f
SM
132002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13201
13202 * process.c (Qprocessp): Don't declare static.
13203 * lisp.h (Qprocessp): Declare again.
13204
7990b61a
JB
132052011-04-15 Juanma Barranquero <lekktu@gmail.com>
13206
13207 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13208
5d4cb038
PE
132092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13210
8bd7b830 13211 Improve C-level modularity by making more things 'static'.
cd64ea1d 13212
e3b27b31
PE
13213 Don't publish debugger-only interfaces to other modules.
13214 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13215 (verify_bytepos, count_markers): Move decls to the only modules
13216 that need them.
13217 * region-cache.h (pp_cache): Likewise.
13218 * window.h (check_all_windows): Likewise.
13219 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13220
5d4cb038
PE
13221 * sysdep.c (croak): Now static, if
13222 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13223 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13224
13225 * alloc.c (refill_memory_reserve): Now static if
13226 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13227 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13228
e87b6180
PE
13229 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13230 Define only if USE_LUCID.
13231
ac64929e
PE
13232 * xrdb.c (x_customization_string, x_rm_string): Now static.
13233
6f37259d
PE
13234 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13235 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13236
1683e3ab
PE
13237 * xdisp.c (draw_row_with_mouse_face): Now static.
13238 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13239
de9c2632
PE
13240 * window.h (check_all_windows): Mark externally visible.
13241
2b96acb7
PE
13242 * window.c (window_deletion_count): Now static.
13243
13244 * undo.c: Make symbols static if they're not exported.
13245 (last_undo_buffer, last_boundary_position, pending_boundary):
13246 Now static.
13247
50436f33
PE
13248 * textprop.c (interval_insert_behind_hooks): Now static.
13249 (interval_insert_in_front_hooks): Likewise.
13250
64520e5c
PE
13251 * term.c: Make symbols static if they're not exported.
13252 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13253 (max_frame_lines, tty_set_terminal_modes):
13254 (tty_reset_terminal_modes, tty_turn_off_highlight):
13255 (get_tty_terminal): Now static.
13256 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13257 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13258 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13259 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13260 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13261
1fa53021
PE
13262 * sysdep.c: Make symbols static if they're not exported.
13263 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13264 Now static.
13265 (sigprocmask_set, full_mask): Remove; unused.
13266 (wait_debugging): Mark as visible.
13267 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13268 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13269
d4b43b22
PE
13270 * syntax.c (syntax_temp): Define only if !__GNUC__.
13271
b7c513d0
PE
13272 * sound.c (current_sound_device, current_sound): Now static.
13273
989b29ad
PE
13274 * search.c (searchbufs, searchbuf_head): Now static.
13275
13a55a78
PE
13276 * scroll.c (scroll_cost): Remove; unused.
13277 * dispextern.h (scroll_cost): Remove decl.
13278
de68a1fc
PE
13279 * region-cache.h (pp_cache): Mark as externally visible.
13280
40ccffa6
PE
13281 * process.c: Make symbols static if they're not exported.
13282 (process_tick, update_tick, create_process, chan_process):
13283 (Vprocess_alist, proc_buffered_char, datagram_access):
13284 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13285 (deactivate_process): Mark defn as static, as well as decl.
13286 * lisp.h (create_process): Remove decl.
13287 * process.h (chan_process, Vprocess_alist): Remove decls.
13288
ad64fc97
PE
13289 * print.c: Make symbols static if they're not exported.
13290 (print_depth, new_backquote_output, being_printed, print_buffer):
13291 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13292 (print_interval, print_number_index, initial_stderr_stream):
13293 Now static.
13294 * lisp.h (Fprinc): Remove decl.
13295 (debug_output_compilation_hack): Mark as externally visible.
13296
adddb265
PE
13297 * sysdep.c (croak): Move decl from here to syssignal.h.
13298 * syssignal.h (croak): Put it here, so the API can be checked when
13299 'croak' is called from dissociate_if_controlling_tty.
13300
1717ede2
PE
13301 * minibuf.c: Make symbols static if they're not exported.
13302 (minibuf_save_list, choose_minibuf_frame): Now static.
13303 * lisp.h (choose_minibuf_frame): Remove decl.
13304
fa5fb2bc
PE
13305 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13306
1e3890d1
PE
13307 * lread.c: Make symbols static if they're not exported.
13308 (read_objects, initial_obarray, oblookup_last_bucket_number):
13309 Now static.
13310 (make_symbol): Remove; unused.
13311 * lisp.h (initial_obarray, make_symbol): Remove decls.
13312
8a1414fa
PE
13313 * keyboard.c: Make symbols static if they're not exported.
13314 (single_kboard, recent_keys_index, total_keys, recent_keys):
13315 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13316 (this_single_command_key_start, echoing, last_auto_save):
13317 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13318 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13319 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13320 (Vlispy_mouse_stem, double_click_count):
13321 Now static.
13322 (force_auto_save_soon): Define only if SIGDANGER.
13323 (ignore_mouse_drag_p): Now static if
13324 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13325 (print_help): Remove; unused.
13326 (stop_character, last_timer_event): Mark as externally visible.
13327 * keyboard.h (ignore_mouse_drag_p): Declare only if
13328 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13329 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13330 * lisp.h (echoing): Remove decl.
13331 (force_auto_save_soon): Declare only if SIGDANGER.
13332 * xdisp.c (redisplay_window): Simplify code, to make it more
13333 obvious that ignore_mouse_drag_p is not accessed if !defined
13334 USE_GTK && !defined HAVE_NS.
13335
93ea6e8f
PE
13336 * intervals.c: Make symbols static if they're not exported.
13337 (merge_properties_sticky, merge_interval_right, delete_interval):
13338 Now static.
13339 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13340
77382fcc
PE
13341 * insdel.c: Make symbols static if they're not exported.
13342 However, leave prepare_to_modify_buffer alone. It's never
13343 called from outside this function, but that appears to be a bug.
13344 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13345 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13346 (adjust_after_replace_noundo): Remove; unused.
13347 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13348 (signal_before_change): Remove decls.
77382fcc 13349
9306c32e
PE
13350 * indent.c (val_compute_motion, val_vmotion): Now static.
13351
cd44d2eb
PE
13352 * image.c: Make symbols static if they're not exported.
13353 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13354 if USE_GTK.
13355 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13356 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13357
ad9a7a06
PE
13358 * fringe.c (standard_bitmaps): Now static.
13359 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13360
81626931
PE
13361 * frame.c: Make symbols static if they're not exported.
13362 (x_report_frame_params, make_terminal_frame): Now static.
13363 (get_frame_param): Now static, unless HAVE_NS.
13364 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13365 (x_get_resource_string): Remove; not used.
13366 * frame.h (make_terminal_frame, x_report_frame_params):
13367 (x_get_resource_string); Remove decls.
13368 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13369 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13370
239f9db9
PE
13371 * font.c, fontset.c: Make symbols static if they're not exported.
13372 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13373 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13374 * font.c (font_close_object): Now static.
13375 * font.h (font_close_object): Remove.
13376 * fontset.c (FONTSET_OBJLIST): Remove.
13377 (free_realized_fontset) #if-0 the body, which does nothing.
13378 (face_suitable_for_char_p): #if-0, as it's never called.
13379 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13380 * xfaces.c (face_at_string_position):
13381 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13382 since 0 is always ASCII.
13383
dfcf3579
PE
13384 * fns.c (weak_hash_tables): Now static.
13385
5045092b
PE
13386 * fileio.c: Make symbols static if they're not exported.
13387 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13388 (Vwrite_region_annotation_buffers): Now static.
13389
57a96f5c
PE
13390 * eval.c: Make symbols static if they're not exported.
13391 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13392 * lisp.h (backtrace_list): Remove decl.
13393
35f08c38
PE
13394 * emacs.c: Make symbols static if they're not exported.
13395 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13396 (fatal_error_code, fatal_error_signal_hook, standard_args):
13397 Now static.
13398 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13399 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13400 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13401 * lisp.h (fatal_error_signal_hook): Remove decl.
13402 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13403
f44bd759
PE
13404 * editfns.c: Move a (normally-unused) function to its only use.
13405 * editfns.c, lisp.h (get_operating_system_release): Remove.
13406 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13407 worth the hassle of breaking this out.
13408
b532497d
PE
13409 * xterm.c: Make symbols static if they're not exported.
13410 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13411 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13412 (x_destroy_window, x_delete_display):
13413 Now static.
13414 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13415 (x_mouse_leave): Remove; unused.
13416 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13417 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13418 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13419 Remove decls.
13420 (x_mouse_leave): Declare only if WINDOWSNT.
13421 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13422 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13423 USE_X_TOOLKIT.
13424
1675728f
PE
13425 * ftxfont.c: Make symbols static if they're not exported.
13426 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13427 HAVE_FREETYPE.
13428 * font.h (ftxfont_driver): Likewise.
13429
e4cebfca
PE
13430 * xfns.c: Make symbols static if they're not exported.
13431 (x_last_font_name, x_display_info_for_name):
13432 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13433 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13434 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13435 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13436 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13437 (last_show_tip_args): Now static.
13438 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13439 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13440 (x_screen_planes): Remove; unused.
13441 * dispextern.h (x_screen_planes): Remove decl.
13442
5bf46f05
PE
13443 * dispnew.c: Make symbols static if they're not exported.
13444 * dispextern.h (redraw_garbaged_frames, scrolling):
13445 (increment_row_positions): Remove.
13446 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13447 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13448 Now static.
13449 (redraw_garbaged_frames): Remove; unused.
13450
435f4c28
PE
13451 * xfaces.c: Make symbols static if they're not exported.
13452 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13453 Remove decls.
13454 * xterm.h (defined_color): Remove decls.
13455 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13456 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13457 (menu_face_changed_default, defined_color, free_realized_face):
13458 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13459 (ascii_face_of_lisp_face): Remove; unused.
13460
8524aef3
PE
13461 * xdisp.c: Make symbols static if they're not exported.
13462 * dispextern.h (scratch_glyph_row, window_box_edges):
13463 (glyph_to_pixel_coords, set_cursor_from_row):
13464 (get_next_display_element, set_iterator_to_next):
13465 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13466 (show_mouse_face): Remove decls
13467 * frame.h (message_buf_print): Likewise.
13468 * lisp.h (pop_message, set_message, check_point_in_composition):
13469 Likewise.
13470 * xterm.h (set_vertical_scroll_bar): Likewise.
13471 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13472 (message_buf_print, scratch_glyph_row, displayed_buffer):
13473 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13474 (get_next_display_element, show_mouse_face, window_box_edges):
13475 (frame_to_window_pixel_xy, check_point_in_composition):
13476 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13477 (glyph_to_pixel_coords): Remove; unused.
13478
16390cd2
PE
13479 * dired.c (file_name_completion): Now static.
13480
13481 * dbusbind.c (xd_in_read_queued_messages): Now static.
13482
a25f4dfa
PE
13483 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13484 * data.c (circular_list_error): Remove.
13485
14a9c8df
PE
13486 * commands.h (last_point_position, last_point_position_buffer):
13487 (last_point_position_window): Remove decls.
13488 * keyboard.c: Make these variables static.
13489
04f2d78b
CB
13490 * coding.h (coding, code_convert_region, encode_coding_gap):
13491 Remove decls.
74ab6df5
PE
13492 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13493 (iso_code_class, detect_coding, code_convert_region): Now static.
13494 (encode_coding_gap): Remove; unused.
13495
38dfbee1
PE
13496 * chartab.c (chartab_chars, chartab_bits): Now static.
13497
a2cb4e63
PE
13498 * charset.h (charset_iso_8859_1): Remove decl.
13499 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13500 Now static.
13501
127198fd
PE
13502 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13503 * ccl.c (Vccl_program_table): Now static.
13504 (check_ccl_update): Remove; unused.
13505
d85b608f
PE
13506 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13507 * category.h: ... from here.
13508 * category.c (check_category_table, set_category_set): Now static.
13509
31cd66f3
PE
13510 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13511 * lisp.h: Remove these decls.
13512
c358e587
PE
13513 * buffer.c (buffer_count): Remove unused var.
13514
e78aecca
PE
13515 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13516 so that it's not optimized away.
13517 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13518 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13519 exported only to the debugger.
13520
e192d7d3 13521 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13522 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13523
92470028
PE
13524 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13525 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13526 was inaccessible from Lisp.
13527 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13528 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13529
244ed907
PE
13530 alloc.c: Import and export fewer symbols, and remove unused items.
13531 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13532 is defined.
13533 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13534 it's not optimized away by whole-program optimization.
13535 (message_enable_multibyte, free_misc): Remove.
13536 (catchlist, handlerlist, mark_backtrace):
13537 Declare only if BYTE_MARK_STACK.
13538 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13539 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13540 (message_enable_multibyte): Remove decl.
13541 (free_misc, interval_free_list, float_block, float_block_index):
13542 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13543 (cons_free_list, last_marked_index):
13544 Now static.
13545 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13546 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13547 (mark_backtrace): Define only if BYTE_MARK_STACK.
13548 * xdisp.c (message_enable_multibyte): Now static.
13549
61c2b50e 13550 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13551 This makes it easier for human readers (and static analyzers)
13552 to see whether these variables are used from other modules.
13553 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13554 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13555 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13556 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13557 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13558 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13559 * xmenu.c, xselect.c:
13560 Declare Q* vars static if they are not used in other modules.
13561 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13562 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13563 Remove decls of unexported vars.
13564 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13565
95c82688
PE
13566 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13567
16a97296
PE
13568 Make Emacs functions such as Fatom 'static' by default.
13569 This makes it easier for human readers (and static analyzers)
13570 to see whether these functions can be called from other modules.
13571 DEFUN now defines a static function. To make the function external
13572 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13573 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13574 (Finit_image_library):
16a97296
PE
13575 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13576 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13577 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13578 Remove decls, since these functions are now static.
13579 (Funintern, Fget_internal_run_time): New decls, since these functions
13580 were already external.
95c82688 13581
16a97296
PE
13582 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13583 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13584 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13585 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13586 * keyboard.c, keymap.c, lread.c:
13587 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13588 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13589 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13590 Mark functions with DEFUE instead of DEFUN,
13591 if they are used in other modules.
13592 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13593 decls for now-static functions.
13594 * buffer.h (Fdelete_overlay): Remove decl.
13595 * callproc.c (Fgetenv_internal): Mark as internal.
13596 * composite.c (Fremove_list_of_text_properties): Remove decl.
13597 (Fcomposition_get_gstring): New forward static decl.
13598 * composite.h (Fcomposite_get_gstring): Remove decl.
13599 * dired.c (Ffile_attributes): New forward static decl.
13600 * doc.c (Fdocumntation_property): New forward static decl.
13601 * eval.c (Ffetch_bytecode): New forward static decl.
13602 (Funintern): Remove extern decl; now in .h file where it belongs.
13603 * fileio.c (Fmake_symbolic_link): New forward static decl.
13604 * image.c (Finit_image_library): New forward static decl.
13605 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13606 * intervals.h (Fprevious_property_change):
13607 (Fremove_list_of_text_properties): Remove decls.
13608 * keyboard.c (Fthis_command_keys): Remove decl.
13609 (Fcommand_execute): New forward static decl.
13610 * keymap.c (Flookup_key): New forward static decl.
13611 (Fcopy_keymap): Now static.
13612 * keymap.h (Flookup_key): Remove decl.
13613 * process.c (Fget_process): New forward static decl.
13614 (Fprocess_datagram_address): Mark as internal.
13615 * syntax.c (Fsyntax_table_p): New forward static decl.
13616 (skip_chars): Remove duplicate decl.
13617 * textprop.c (Fprevious_property_change): New forward static decl.
13618 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13619 Now internal.
13620 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13621 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13622
785bbd42
PE
13623 * editfns.c (Fformat): Remove unreachable code.
13624
8b913b57
AS
136252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13626
13627 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13628 change. (Bug#8496)
13629
a6744a35
EZ
136302011-04-13 Eli Zaretskii <eliz@gnu.org>
13631
13632 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13633 when at ZV. (Bug#8487)
13634
e7974947
AS
136352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13636
baad03f0
AS
13637 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13638 (Bug#8437)
13639 * keyboard.c (parse_tool_bar_item): Likewise.
13640 * sound.c (sound_cleanup, alsa_close): Likewise.
13641 * termcap.c (tgetent): Likewise.
13642 * xfns.c (x_default_font_parameter): Likewise.
13643 * xsettings.c (read_and_apply_settings): Likewise.
13644
e7974947
AS
13645 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13646 (overrun_check_free): Protoize.
13647
28272684
PE
136482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13649
13650 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13651 since callers should never pass a negative size.
13652 Change the signature to match that of plain 'read' and 'write'; see
13653 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13654 * lisp.h: Update prototypes of emacs_write and emacs_read.
13655
11997c76
EZ
136562011-04-11 Eli Zaretskii <eliz@gnu.org>
13657
13658 * xdisp.c (redisplay_window): Don't try to determine the character
13659 position of the scroll margin if the window start point w->startp
e896f03c 13660 is outside the buffer's accessible region. (Bug#8468)
11997c76 13661
8a2cbd72
EZ
136622011-04-10 Eli Zaretskii <eliz@gnu.org>
13663
13664 Fix write-region and its subroutines for buffers > 2GB.
13665 * fileio.c (a_write, e_write): Modify declaration of arguments and
13666 local variables to support buffers larger than 2GB.
13667 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13668
13669 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13670 argument, local variables, and return value.
13671
13672 * lisp.h: Update prototypes of emacs_write and emacs_read.
13673
13674 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13675
4073e537 136762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13677
1ebfdcb6
PE
13678 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13679
b2ded58d
PE
13680 Fix more problems found by GCC 4.6.0's static checks.
13681
7d66342c
PE
13682 * xdisp.c (vmessage): Use a better test for character truncation.
13683
bbf47d44
PE
13684 * charset.c (load_charset_map): <, not <=, for optimization,
13685 and to avoid potential problems with integer overflow.
9248994d 13686 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13687 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13688 * editfns.c (Fformat): Likewise.
1e69125e 13689 * syntax.c (skip_chars): Likewise.
3befa583 13690
e3019616
PE
13691 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13692 This also lets GCC 4.6.0 generate slightly better loop code.
13693
becfa255
PE
13694 * callint.c (Fcall_interactively): <, not <=, for optimization.
13695 (Fcall_interactively): Count the number of arguments produced,
13696 not the number of arguments given. This is simpler and lets GCC
13697 4.6.0 generate slightly better code.
13698
dae0cd48
PE
13699 * ftfont.c: Distingish more carefully between FcChar8 and char.
13700 The previous code passed unsigned char * to a functions like
13701 strlen and xstrcasecmp that expect char *, which does not
13702 conform to the C standard.
13703 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13704 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13705 char * when the C standard requires it.
13706
76032d70
PE
13707 * keyboard.c (read_char): Remove unused var.
13708
eb3f1cc8
PE
13709 * eval.c: Port to Windows vsnprintf (Bug#8435).
13710 Include <limits.h>.
13711 (SIZE_MAX): Define if the headers do not.
13712 (verror): Do not give up if vsnprintf returns a negative count.
13713 Instead, grow the buffer. This ports to Windows vsnprintf, which
13714 does not conform to C99. Problem reported by Eli Zaretskii.
13715 Also, simplify the allocation scheme, by avoiding the need for
13716 calling realloc, and removing the ALLOCATED variable.
13717
70476b54
PE
13718 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13719
12020a9e
PE
13720 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13721 But keep the doprint source code for now, as we might revamp it
13722 and use it again (Bug#8435).
ea6c7ae6
PE
13723 * lisp.h (doprnt): Remove.
13724 * Makefile.in (base_obj): Remove doprnt.o.
13725 * deps.mk (doprnt.o): Remove.
13726
5fdb398c
PE
13727 error: Print 32- and 64-bit integers portably (Bug#8435).
13728 Without this change, on typical 64-bit hosts error ("...%d...", N)
13729 was used to print both 32- and 64-bit integers N, which relied on
13730 undefined behavior.
61bdb816 13731 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13732 * lisp.h (error, verror): Mark as printf-like functions.
13733 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13734 Report overflow in size calculations when allocating printf buffer.
13735 Do not truncate output string at its first null byte.
13736 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13737 Truncate the output at a character boundary, since vsnprintf does not
13738 do that.
13739 * charset.c (check_iso_charset_parameter): Convert internal
13740 character to string before calling 'error', since %c now has the
13741 printf meaning.
13742 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13743 overflow when computing char to be passed to 'error'. Do not
13744 pass Lisp_Object to 'error'; pass the integer instead.
13745 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13746 formatted with plain %d.
13747
b189fa66
PE
13748 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13749
bff87ef0
PE
13750 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13751
7e2cac20
PE
13752 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13753
ce4d90b5
PE
13754 * xterm.c (x_catch_errors): Remove duplicate declaration.
13755
266c9547
PE
13756 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13757
79c49ad2
PE
13758 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13759
368f4090
JM
137602011-04-10 Jim Meyering <meyering@redhat.com>
13761
13762 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13763 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13764 return ssize_t not "int", and use size_t as the buffer length.
13765 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13766 * gnutls.h: Update declarations.
13767 * process.c (read_process_output): Use ssize_t, to match.
13768 (send_process): Likewise.
13769
a32d4040
CY
137702011-04-09 Chong Yidong <cyd@stupidchicken.com>
13771
13772 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13773
8546720e 137742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13775
04f2d78b
CB
13776 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13777 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13778
8546720e
GM
13779 * xterm.c (handle_one_xevent):
13780 * xmenu.c (create_and_show_popup_menu):
13781 * xselect.c (x_decline_selection_request)
13782 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13783
0a2f5c1a 137842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13785
13786 Fix some uses of `int' instead of EMACS_INT.
13787 * search.c (string_match_1, fast_string_match)
13788 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13789 (scan_buffer, find_next_newline_no_quit)
13790 (find_before_next_newline, search_command, Freplace_match)
13791 (Fmatch_data): Make some `int' variables be EMACS_INT.
13792
13793 * xdisp.c (display_count_lines): 3rd argument and return value now
13794 EMACS_INT. All callers changed.
13795 (pint2hrstr): Last argument is now EMACS_INT.
13796
13797 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13798 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13799 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13800 (decode_coding_utf_16, decode_coding_emacs_mule)
13801 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13802 (decode_coding_ccl, decode_coding_charset)
13803 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13804 (decode_coding_iso_2022, decode_coding_emacs_mule)
13805 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13806 <char_offset, last_offset>: Declare EMACS_INT.
13807 (encode_coding_utf_8, encode_coding_utf_16)
13808 (encode_coding_emacs_mule, encode_invocation_designation)
13809 (encode_designation_at_bol, encode_coding_iso_2022)
13810 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13811 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13812 Declare EMACS_INT.
13813 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13814 (encode_invocation_designation): Last argument P_NCHARS is now
13815 EMACS_INT.
13816 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13817 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13818
13819 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13820 All users changed.
13821
13822 * ccl.c (Fccl_execute_on_string): Declare some variables
13823 EMACS_INT.
13824
8546720e 138252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13826
13827 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13828
4e19a977
CS
138292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13830
13831 * process.c (Fformat_network_address): Doc fix.
13832
87302331
R
138332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13834
ee7683eb 13835 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13836
cbb59342
CY
138372011-04-08 Chong Yidong <cyd@stupidchicken.com>
13838
13839 * keyboard.c (read_char): Call Lisp function help-form-show,
13840 instead of using internal_with_output_to_temp_buffer.
13841 (Qhelp_form_show): New var.
e0d38eeb 13842 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13843
13844 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13845
13846 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13847
e67a13ab
CY
138482011-04-06 Chong Yidong <cyd@stupidchicken.com>
13849
04f2d78b
CB
13850 * process.c (Flist_processes): Remove to Lisp.
13851 (list_processes_1): Delete.
e67a13ab 13852
973f782d
EZ
138532011-04-06 Eli Zaretskii <eliz@gnu.org>
13854
7c106b1e
EZ
13855 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13856
973f782d
EZ
13857 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13858
41cf7d1a 138592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13860
ca23cc88
PE
13861 Fix more problems found by GCC 4.6.0's static checks.
13862
f390e2d5
PE
13863 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13864
42eea0d0
PE
13865 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13866
b69769da 13867 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13868
f9541e84
PE
13869 * xdisp.c (vmessage): Mark as a printf-like function.
13870
13841b55
PE
13871 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13872
c136c10f
PE
13873 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13874
5e2d4a30
PE
13875 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13876 printf-like functions.
13877 (tiff_load): Add casts to remove these marks before passing them
13878 to system-supplied API.
13879
583f48b9
PE
13880 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13881
b25d760e
PE
13882 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13883 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13884 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13885 directly, rather than having caller test rule sign. This avoids
13886 some unnecessary tests.
13887 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13888 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13889 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13890
bc7b6697 13891 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13892 (xfont_open): Avoid unnecessary tests.
bc7b6697 13893
27ccc379
PE
13894 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13895
dcd5c89a
PE
13896 * composite.h, composite.c (composition_gstring_put_cache):
13897 Use EMACS_INT, not int, for length.
13898
b13a45c6
PE
13899 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13900 breaking out part of COMPOSITION_DECODE_RULE.
13901 (COMPOSITION_DECODE_RULE): Use it.
13902 * composite.c (get_composition_id): Remove unused local vars,
13903 by using the new macro.
13904
1e792e4d
PE
13905 * textprop.c (set_text_properties_1): Change while to do-while,
13906 since the condition is always true at first.
13907
dc6c6455 13908 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13909 (interval_deletion_adjustment): Return unsigned value.
13910 All uses changed.
dc6c6455 13911
aba7731a
PE
13912 * process.c (list_processes_1, create_pty, read_process_output):
13913 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13914 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13915 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13916 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13917 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13918
fdfc4bf3
PE
13919 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13920
fca8fe46 13921 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13922 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13923
06a0259a 13924 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13925 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13926 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13927
e7b9e80f
PE
13928 * print.c (print_error_message): Avoid int overflow.
13929
56201685
PE
13930 * font.c (font_list_entities): Redo for clarity,
13931 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13932
78834453 13933 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13934 (font_score): Avoid potential overflow in diff calculation.
78834453 13935
0bc0b309 13936 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13937 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13938
e610eaca
PE
13939 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13940
b895abce
PE
13941 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13942 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13943 can always succeed if overflow has undefined behavior.
13944
1f1d9321 13945 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13946 (wordify): Omit three unnecessary tests.
1f1d9321 13947
c59478bc
PE
13948 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13949 All callers changed. This avoids the need for an unused var.
13950
79b73827
PE
13951 * casefiddle.c (casify_region): Remove var that is set but not used.
13952
a4db5dfe
PE
13953 * dired.c (file_name_completion): Remove var that is set but not used.
13954
43aae36e
PE
13955 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13956
2a47c44d 13957 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13958 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13959
a37c69bf
PE
13960 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13961 Check for integer overflow on size calculations.
13962
328ab8e7
PE
13963 * buffer.c (Fprevious_overlay_change): Remove var that is set
13964 but not used.
13965
e5a2a5cb
PE
13966 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13967 Remove vars that are set but not used.
8d84a6eb 13968 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13969 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13970
a60e5f68
PE
13971 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13972
f661cb61 13973 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13974 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13975
f0397f5a
PE
13976 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13977 that are set but not used.
13978
8664db06 13979 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13980 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13981
6abdaa4a
PE
13982 * xselect.c (x_get_local_selection, x_handle_property_notify):
13983 Remove vars that are set but not used.
13984
0ce7538d 13985 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13986 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13987
9ae848fc
PE
13988 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13989 Remove var that is set but not used.
0b918413
PE
13990 (scroll_bar_windows_size): Now size_t, not int.
13991 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13992 Check for overflow.
9ae848fc 13993
a5a62657
PE
13994 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13995 (map_tty_color) [!defined MSDOS]: Likewise.
13996
5c5cdd39
PE
13997 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13998
66ebf983
PE
13999 * coding.c: Remove vars that are set but not used.
14000 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14001 All callers changed.
14002 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14003 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14004 (decode_coding_charset): Remove vars that are set but not used.
14005
1be4d761
PE
14006 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14007 that is set but not used.
14008
47553fa8
PE
14009 * print.c (print_object): Remove var that is set but not used.
14010
1f7196bf 14011 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14012 The gnulib version avoids calling malloc in the usual case,
14013 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14014 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14015 * filelock.c (current_lock_owner): Likewise.
14016 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14017 * sysdep.c: Include allocator.h, careadlinkat.h.
14018 (emacs_no_realloc_allocator): New static constant.
14019 (emacs_readlink): New function.
fdb61804
PE
14020 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14021 ../lib/careadlinkat.h.
d1fdcab7 14022
f84c17c7
SM
140232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14024
14025 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14026 first non-nil return value).
14027
ef3862ad
JD
140282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14029
14030 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14031 if not defined (Bug#8403).
14032
376a7006
JB
140332011-04-02 Juanma Barranquero <lekktu@gmail.com>
14034
14035 * xdisp.c (display_count_lines): Remove parameter `start',
14036 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14037 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14038 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14039 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14040 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14041 and thereabouts. All callers changed.
14042 (get_per_char_metric): Remove parameter `f', unused since
14043 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14044
6ca3801d
JM
140452011-04-02 Jim Meyering <meyering@redhat.com>
14046
14047 do not dereference NULL upon failed strdup
14048 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14049 (ns_get_family): Likewise.
14050
d8e2b5ba
JB
140512011-04-02 Juanma Barranquero <lekktu@gmail.com>
14052
14053 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14054
8c74fcbd
JD
140552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14056
14057 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14058 later (Bug#8403).
14059
7200d79c
SM
140602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14061
03408648 14062 Add lexical binding.
7200d79c 14063
03408648
SM
14064 * window.c (Ftemp_output_buffer_show): New fun.
14065 (Fsave_window_excursion):
14066 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14067
14068 * lread.c (lisp_file_lexically_bound_p): New function.
14069 (Fload): Bind Qlexical_binding.
14070 (readevalloop): Remove `evalfun' arg.
14071 Bind Qinternal_interpreter_environment.
14072 (Feval_buffer): Bind Qlexical_binding.
14073 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14074 Mark as dynamic.
14075 (syms_of_lread): Declare `lexical-binding'.
14076
14077 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14078
14079 * keyboard.c (eval_dyn): New fun.
14080 (menu_item_eval_property): Use it.
ca105506
SM
14081
14082 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14083
03408648
SM
14084 * fns.c (concat, mapcar1): Accept byte-code-functions.
14085
14086 * eval.c (Fsetq): Handle lexical vars.
14087 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14088 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14089 (FletX, Flet): Obey lexical binding.
14090 (Fcommandp): Handle closures.
14091 (Feval): New `lexical' arg.
14092 (eval_sub): New function extracted from Feval. Use it almost
14093 everywhere where Feval was used. Look up vars in lexical env.
14094 Handle closures.
14095 (Ffunctionp): Move from subr.el.
14096 (Ffuncall): Handle closures.
14097 (apply_lambda): Remove `eval_flags'.
14098 (funcall_lambda): Handle closures and new byte-code-functions.
14099 (Fspecial_variable_p): New function.
14100 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14101 but without exporting it to Lisp.
23aba0ea 14102
23aba0ea 14103 * doc.c (Fdocumentation, store_function_docstring):
03408648 14104 * data.c (Finteractive_form): Handle closures.
23aba0ea 14105
03408648
SM
14106 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14107 interactive spec.
ba83908c 14108
04f2d78b
CB
14109 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14110 New byte-codes.
03408648
SM
14111 (exec_byte_code): New function extracted from Fbyte_code to handle new
14112 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14113
03408648 14114 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14115
03408648 14116 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14117
e2abce01
JB
141182011-03-31 Juanma Barranquero <lekktu@gmail.com>
14119
14120 * xdisp.c (redisplay_internal): Fix prototype.
14121
63696a73 141222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14123
63696a73 14124 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14125 (try_scrolling): Use it when setting scroll_limit.
14126 Limit scrolling to 100 screen lines.
63696a73
EZ
14127 (redisplay_window): Even when falling back on "recentering",
14128 position point in the window according to scroll-conservatively,
14129 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14130
14131 (try_scrolling): When point is above the window, allow searching
14132 as far as scroll_max, or one screenful, to compute vertical
14133 distance from PT to the scroll margin position. This prevents
14134 try_scrolling from unnecessarily failing when
14135 scroll-conservatively is set to a value slightly larger than the
14136 window height. Clean up the case of PT below the margin at bottom
14137 of window: scroll_max can no longer be INT_MAX. When aggressive
14138 scrolling is in use, don't let point enter the opposite scroll
14139 margin as result of the scroll.
14140 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14141 threshold of 100 lines for never-recentering scrolling.
14142
e4cc2dfc
JB
141432011-03-31 Juanma Barranquero <lekktu@gmail.com>
14144
14145 * dispextern.h (move_it_by_lines):
14146 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14147 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14148 (message_log_check_duplicate): Remove parameters `prev_bol' and
14149 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14150 (redisplay_internal): Remove parameter `preserve_echo_area',
14151 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14152
14153 * indent.c (Fvertical_motion):
14154 * window.c (window_scroll_pixel_based, Frecenter):
14155 Don't pass `need_y_p' to `move_it_by_lines'.
14156
1c470562
SM
141572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14158
44f230aa
SM
14159 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14160 steal a few bits to be more compact.
14161 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14162 Remove unneeded casts.
14163
1c470562
SM
14164 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14165
888adce9
ZK
141662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14167
14168 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14169 binding" message (bug#7967).
14170
f838ed7b
PE
141712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14172
77861b95
PE
14173 Fix more problems found by GCC 4.6.0's static checks.
14174
de6dbc14
PE
14175 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14176 Remove unused local var.
14177
f838ed7b
PE
14178 * editfns.c (Fmessage_box): Remove unused local var.
14179
792c7b2b
PE
14180 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14181 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14182 Omit unused local vars.
c499e557 14183 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14184 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14185 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14186 Omit unused local var.
14187
ba0165e1
PE
14188 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14189 Don't assume string length fits in int.
32ad8845 14190 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14191 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14192
3c59b4c9
PE
14193 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14194 instead of alloca (Bug#8344).
14195
a3eed478 14196 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14197 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14198
eb4d412d
PE
14199 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14200
1658b401
PE
14201 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14202 concerns.
14203
14204 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14205
14206 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14207
9a2c6e05
PE
14208 * keyboard.c (syms_of_keyboard): Use the same style as later
14209 in this function when indexing through an array. This also
14210 works around GCC bug 48267.
14211
03d0a109
PE
14212 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14213
44f730c8
PE
14214 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14215
fe75f926
PE
14216 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14217 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14218
ffa8c828
PE
14219 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14220 This avoids undefined behavior on integer overflow, and is a bit
14221 more convenient anyway since it is compared to a size_t variable.
14222
c5101a77
PE
14223 Variadic C functions now count arguments with size_t, not int.
14224 This avoids an unnecessary limitation on 64-bit machines, which
14225 caused (substring ...) to crash on large vectors (Bug#8344).
14226 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14227 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14228 All variadic functions and their callers changed accordingly.
c5101a77
PE
14229 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14230 * data.c (arith_driver, float_arith_driver): Likewise.
14231 * editfns.c (general_insert_function): Likewise.
14232 * eval.c (struct backtrace.nargs, interactive_p)
14233 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14234 (funcall_lambda, mark_backtrace): Likewise.
14235 * fns.c (concat): Likewise.
14236 * frame.c (x_set_frame_parameters): Likewise.
14237 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14238 0 if not found, not -1. All callers changed.
14239
dd3f25f7
PE
14240 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14241 (stack_copy_size): Now size_t, not int.
14242 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14243
461c2ab9
JB
142442011-03-28 Juanma Barranquero <lekktu@gmail.com>
14245
14246 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14247 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14248 All callers changed.
14249
14250 * lisp.h (multibyte_char_to_unibyte):
14251 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14252 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14253 * character.h (CHAR_TO_BYTE8):
14254 * cmds.c (internal_self_insert):
14255 * editfns.c (general_insert_function):
14256 * keymap.c (push_key_description):
14257 * search.c (Freplace_match):
14258 * xdisp.c (message_dolog, set_message_1): All callers changed.
14259
f6d62986
SM
142602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14261
14262 * keyboard.c (safe_run_hook_funcall): New function.
14263 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14264 don't set the hook to nil, but remove the offending function instead.
14265 (Qcommand_hook_internal): Remove, unused.
14266 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14267 Vcommand_hook_internal.
14268
14269 * eval.c (enum run_hooks_condition): Remove.
14270 (funcall_nil, funcall_not): New functions.
14271 (run_hook_with_args): Call each function through a `funcall' argument.
14272 Remove `cond' argument, now redundant.
14273 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14274 (Frun_hook_with_args_until_failure): Adjust accordingly.
14275 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14276
1db5b1ad
JB
142772011-03-28 Juanma Barranquero <lekktu@gmail.com>
14278
14279 * dispextern.h (string_buffer_position): Remove declaration.
14280
14281 * print.c (strout): Remove parameter `multibyte', unused since
14282 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14283
14284 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14285 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14286 All callers changed.
14287
14288 * w32.c (_wsa_errlist): Use braces for struct initializers.
14289
14290 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14291 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14292 All callers changed.
14293 (string_buffer_position): Likewise. Also, make static (it's never
14294 used outside xdisp.c).
14295 (cursor_row_p): Remove parameter `w', unused since
14296 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14297 (decode_mode_spec): Remove parameter `precision', introduced during
14298 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14299 All callers changed.
14300
5ffb62aa
JD
143012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14302
14303 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14304
461c2ab9 143052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14306
14307 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14308 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14309 (ns_update_auto_hide_menu_bar): New functions.
14310 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14311 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14312 ns_constrain_all_frames.
14313 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14314 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14315
5c380ffb
JD
143162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14317
14318 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14319
9af30bdf
GM
143202011-03-27 Glenn Morris <rgm@gnu.org>
14321
14322 * syssignal.h: Replace RETSIGTYPE with void.
14323 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14324 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14325 Replace SIGTYPE with void everywhere.
14326 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14327 * s/template.h (SIGTYPE): Remove commented out definition.
14328
e2abce01
JB
143292011-03-26 Eli Zaretskii <eliz@gnu.org>
14330
14331 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14332 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14333
f868cd8a
JB
143342011-03-26 Juanma Barranquero <lekktu@gmail.com>
14335
59eb0929
JB
14336 * w32.c (read_unc_volume): Use parameter `henum', instead of
14337 global variable `wget_enum_handle'.
14338
14339 * keymap.c (describe_vector): Remove parameters `indices' and
14340 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14341 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14342
f868cd8a
JB
14343 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14344
14345 * keyboard.c (timer_check): Remove parameter `do_it_now',
14346 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14347 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14348 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14349
14350 * keyboard.c (read_char):
14351 * w32menu.c (w32_menu_display_help):
14352 * xmenu.c (show_help_event, menu_help_callback):
14353 Adjust calls to `show_help_echo'.
14354
14355 * gtkutil.c (xg_maybe_add_timer):
14356 * keyboard.c (readable_events):
14357 * process.c (wait_reading_process_output):
14358 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14359
14360 * insdel.c (adjust_markers_gap_motion):
14361 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14362 (gap_left, gap_right): Don't call it.
14363
2ecf6fdb
CY
143642011-03-25 Chong Yidong <cyd@stupidchicken.com>
14365
14366 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14367 incurred during fontification.
14368
6b1f9ba4
JB
143692011-03-25 Juanma Barranquero <lekktu@gmail.com>
14370
14371 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14372 (DEFVAR_PER_BUFFER): Don't pass it.
14373
14374 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14375 (scrolling_window): Don't pass it.
14376
0f4a96b5
JB
143772011-03-25 Juanma Barranquero <lekktu@gmail.com>
14378
14379 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14380
14381 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14382 and `suffix'.
14383 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14384 of variables specific to SELinux and computation of `encoded_absname'.
14385
14386 * image.c (XPutPixel): Remove unused variable `height'.
14387
14388 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14389
14390 * unexw32.c (get_section_info): Remove unused variable `section'.
14391
14392 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14393 (system_process_attributes): Remove unused variable `sess'.
14394 (sys_read): Remove unused variable `err'.
14395
14396 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14397 (w32_wnd_proc): Remove unused variable `isdead'.
14398 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14399 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14400 (x_create_tip_frame): Remove unused variable `tem'.
14401
14402 * w32inevt.c (w32_console_read_socket):
14403 Remove unused variable `no_events'.
14404
14405 * w32term.c (x_draw_composite_glyph_string_foreground):
14406 Remove unused variable `width'.
14407
1149507c
JB
144082011-03-24 Juanma Barranquero <lekktu@gmail.com>
14409
14410 * w32term.c (x_set_glyph_string_clipping):
14411 Don't pass uninitialized region to CombineRgn.
14412
9c88f339
JB
144132011-03-23 Juanma Barranquero <lekktu@gmail.com>
14414
14415 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14416 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14417 (Fx_close_connection): Remove unused variable `i'.
14418
14419 * w32font.c (w32font_draw): Return number of glyphs.
14420 (w32font_open_internal): Remove unused variable `i'.
14421 (w32font_driver): Add missing initializer.
14422
14423 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14424 (fill_in_menu): Remove unused variable `items_added'.
14425
14426 * w32term.c (last_mouse_press_frame): Remove static global variable.
14427 (w32_clip_to_row): Remove unused variable `f'.
14428 (x_delete_terminal): Remove unused variable `i'.
14429
14430 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14431 (NOTHING): Remove unused static global variable.
14432 (uniscribe_check_otf): Remove unused variable `table'.
14433 (uniscribe_font_driver): Add missing initializers.
14434
dee091a3
JD
144352011-03-23 Julien Danjou <julien@danjou.info>
14436
14437 * term.c (Fsuspend_tty, Fresume_tty):
14438 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14439 * window.c (temp_output_buffer_show):
14440 * insdel.c (signal_before_change):
14441 * frame.c (Fhandle_switch_frame):
14442 * fileio.c (Fdo_auto_save):
14443 * emacs.c (Fkill_emacs):
14444 * editfns.c (save_excursion_restore):
14445 * cmds.c (internal_self_insert):
14446 * callint.c (Fcall_interactively):
14447 * buffer.c (Fkill_all_local_variables):
14448 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14449 Use Frun_hooks.
0f4a96b5 14450 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14451 unconditionally since it does the check itself.
dee091a3 14452
2c520ab5 144532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14454
c9c49752
PE
14455 Fix more problems found by GCC 4.5.2's static checks.
14456
8abc3f12
PE
14457 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14458 the first time through the loop, since we know p0 < p1 then.
14459 This also avoids a gcc -Wstrict-overflow warning.
14460
a2d26660
PE
14461 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14462 leading to a memory leak, possible in functions like
14463 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14464 of objects (Bug#8318).
a2d26660 14465
916c72e9
PE
14466 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14467 that could (at least in theory) be that large.
14468
19ab8a18
PE
14469 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14470 This is less likely to overflow, and avoids undefined behavior if
14471 overflow does occur. All callers changed. Use strtoul to scan
14472 for the unsigned long integer.
b7cbbd6f
PE
14473 (pint2hrstr): Simplify and tune code slightly.
14474 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14475
f0641eff
PE
14476 * scroll.c (do_scrolling): Work around GCC bug 48228.
14477 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14478
7f650bb9
PE
14479 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14480 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14481 (validate_x_resource_name): Simplify count usage.
14482 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14483
37dd57d1
PE
14484 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14485 fail (Bug#8306).
81e56e61 14486
699979fc 14487 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14488
401bf9b4
PE
14489 * process.c (Fmake_network_process): Use socklen_t, not int,
14490 where POSIX says socklen_t is required in portable programs.
14491 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14492 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14493 (Fmake_network_process, server_accept_connection):
14494 (wait_reading_process_output, read_process_output):
14495 Likewise.
14496
b93aacde
PE
14497 * process.c: Rename or move locals to avoid shadowing.
14498 (list_processes_1, Fmake_network_process):
14499 (read_process_output_error_handler, exec_sentinel_error_handler):
14500 Rename or move locals.
4dc343ee 14501 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14502 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14503 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14504 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14505 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14506
af8a867c 14507 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14508 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14509 Include tparam.h instead, since it declares them.
af8a867c
PE
14510 * cm.h (PC): Remove extern decl; tparam.h now does this.
14511 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14512 * terminfo.c: Include tparam.h, to check interfaces.
14513 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14514 (tparam): Adjust signature to match interface in tparam.h;
14515 this removes some undefined behavior. Check that outstring and len
14516 are zero, which they always are with Emacs.
14517 * tparam.h (PC, BC, UP): New extern decls.
14518
0248044d 14519 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14520 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14521
8ff096c1 14522 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14523 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14524 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14525 (ftfont_list): Remove unused local.
49eaafba
PE
14526 (get_adstyle_property, ftfont_pattern_entity):
14527 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14528 Rename locals to avoid shadowing.
8ff096c1 14529
e2be39f6
PE
14530 * xfont.c (xfont_list_family): Mark var as initialized.
14531
c9735e30
PE
14532 * xml.c (make_dom): Now static.
14533
8f5201ae
PE
14534 * composite.c (composition_compute_stop_pos): Rename local to
14535 avoid shadowing.
b246f932
PE
14536 (composition_reseat_it): Remove unused locals.
14537 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14538 (composition_update_it): Mark var as initialized.
11b61122
PE
14539 (find_automatic_composition): Mark vars as initialized,
14540 with a FIXME (Bug#8290).
8f5201ae 14541
760fbc2c
PE
14542 character.h: Rename locals to avoid shadowing.
14543 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14544 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14545 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14546 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14547 to avoid shadowing.
14548
ff08eb85
PE
14549 * textprop.c (property_change_between_p): Remove; unused.
14550
fc7bf025
PE
14551 * intervals.c (interval_start_pos): Now static.
14552
235d7abc
PE
14553 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14554
44f230aa
SM
14555 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14556 Rename locals to avoid shadowing.
3e7d6594 14557
50060332
PE
14558 * sound.c (wav_play, au_play, Fplay_sound_internal):
14559 Fix pointer signedness.
d01f234b 14560 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14561 (wav_play): Initialize a variable to 0, to prevent undefined
14562 behavior (Bug#8278).
50060332 14563
c4fc4e30
PE
14564 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14565
918436ed
PE
14566 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14567
c939f91b
PE
14568 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14569 clobbering (Bug#8298).
b9c7f648
PE
14570 * sysdep.c (sys_subshell): Likewise.
14571 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14572
6bd8c144
PE
14573 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14574 This should get cleaned up, so that child_setup has the
14575 same signature on all platforms.
14576
7710357c 14577 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14578 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14579
c59da222
CY
145802011-03-22 Chong Yidong <cyd@stupidchicken.com>
14581
14582 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14583 not to be necessary, and produces flickering.
14584
66b87493
GM
145852011-03-20 Glenn Morris <rgm@gnu.org>
14586
14587 * config.in: Remove file.
14588
45b6f6d5
JB
145892011-03-20 Juanma Barranquero <lekktu@gmail.com>
14590
14591 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14592 are now in src/globals.h.
14593 (syms_of_minibuf): Remove spurious & from previous change.
14594
cd394be1 145952011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14596
14597 * minibuf.c (completing-read-function): New variable.
14598 (completing-read-default): Rename from completing-read.
14599 (completing-read): Call completing-read-function.
14600
b14e3e21
CY
146012011-03-19 Juanma Barranquero <lekktu@gmail.com>
14602
14603 * xfaces.c (Fx_load_color_file):
14604 Read color file from absolute filename (bug#8250).
14605
f2b726e6
JB
146062011-03-19 Juanma Barranquero <lekktu@gmail.com>
14607
14608 * makefile.w32-in: Update dependencies.
14609
09f6ff02
EZ
146102011-03-17 Eli Zaretskii <eliz@gnu.org>
14611
14612 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14613
29a6015a
PE
146142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14615
a3a6c54e
PE
14616 Fix more problems found by GCC 4.5.2's static checks.
14617
b766f867
PE
14618 * process.c (make_serial_process_unwind, send_process_trap):
14619 (sigchld_handler): Now static.
14620
be02381c
PE
14621 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14622 That way, the code declares only the vars that it needs.
14623 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14624 * s/cygwin.h (PTY_ITERATION): Likewise.
14625 * s/darwin.h (PTY_ITERATION): Likewise.
14626 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14627
57048744
PE
14628 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14629 * process.c (allocate_pty): Don't declare stb unless it's needed.
14630
7914961c 14631 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14632 (CONSTANTLIM): Remove; unused.
14633 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14634 Define only if needed.
7914961c 14635
b3967b18
PE
14636 * unexelf.c (unexec): Name an expression,
14637 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14638 Use a different way to cause a compilation error if anyone uses
14639 n rather than nn, a way that does not involve shadowing.
73366a00 14640 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14641
29a6015a
PE
14642 * deps.mk (unexalpha.o): Remove; unused.
14643
43cfc33e 14644 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14645 * unexec.h: New file.
ce701a33
PE
14646 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14647 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14648 Depend on unexec.h.
14649 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14650 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14651 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14652 Change as necessary to match prototype in unexec.h.
ce701a33 14653
01f44d5a
PE
14654 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14655 shadowing.
4f63c6bb 14656 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14657
a6670b0b
PE
14658 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14659 Rename locals to avoid shadowing.
14660
cef2010d 14661 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14662 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14663
d4d7173a
PE
14664 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14665
f08b802a
PE
14666 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14667 warning when compiling print.c.
14668
3ddb0639
PE
14669 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14670 instead of using an uninitialized var.
5ad03b97 14671 (font_sort_entities): Mark var as initialized.
3ddb0639 14672
170a2692
PE
14673 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14674
e663c700
PE
14675 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14676 pointers to constants.
89bc529a 14677 (font_parse_fcname): Remove unused vars.
7b81e2d0 14678 (font_delete_unmatched): Now static.
ea838e10 14679 (font_get_spec): Remove; unused.
13a547c6
PE
14680 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14681 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14682 Rename or move locals to avoid shadowing.
e663c700 14683
2a80c887 14684 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14685 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14686
1384fa33 14687 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14688 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14689
8b2c52e9
PE
14690 * alloc.c (mark_backtrace): Move decl from here ...
14691 * lisp.h: ... to here, so that it can be checked.
14692
475545b5 14693 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14694 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14695 (lisp_indirect_variable): Name an expression,
14696 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14697 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14698
b1349114 14699 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14700 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14701 Use const pointer when appropriate.
b1349114 14702
a2928364
PE
14703 * lisp.h (get_system_name, get_operating_system_release):
14704 Move decls here, to check interfaces.
14705 * process.c (get_operating_system_release): Move decl to lisp.h.
14706 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14707 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14708 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14709 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14710 (Fformat_time_string, Fencode_time, Finsert_char):
14711 (Ftranslate_region_internal, Fformat):
14712 Rename or remove local vars to avoid shadowing.
9710023e 14713 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14714
a415e694
PE
14715 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14716 avoid shadowing.
14717
8ef4622d
PE
14718 * lisp.h (eassert): Check that the argument compiles, even if
14719 ENABLE_CHECKING is not defined.
14720
946f9a5b
PE
14721 * data.c (Findirect_variable): Name an expression, to avoid
14722 gcc -Wbad-function-cast warning.
112396d6 14723 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14724 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14725 (Fmake_variable_buffer_local, Fmake_local_variable):
14726 Mark variables as initialized.
52746918 14727 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14728
e5aab7e7 14729 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14730 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14731 Rename locals to avoid shadowing.
dff45157
PE
14732 (mark_stack): Move local variables into the #ifdef region where
14733 they're used.
7bc26fdb
PE
14734 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14735 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14736 needed otherwise.
14737 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14738 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14739 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14740
e5aab7e7
PE
14741 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14742 avoids undefined behavior in theory.
14743
4da60324
PE
14744 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14745
88043301
PE
14746 Use functions, not macros, for up- and down-casing (Bug#8254).
14747 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14748 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14749 to use the following functions instead of these macros.
14750 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14751 EMACS_INT, since callers assume the returned value fits in int.
14752 (upcase1): Likewise, for UPCASE_TABLE.
14753 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14754 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14755 the race-condition problem in the old DOWNCASE.
88043301 14756
19ed5445
PE
14757 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14758 Rename locals to avoid shadowing.
14759 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14760 (regex_compile, re_search_2, re_match_2_internal):
14761 Remove unused local vars.
952db0d7
PE
14762 (FREE_VAR): Rewrite so as not to use empty "else",
14763 which gcc can warn about.
da053e48 14764 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14765 (RETALLOC_IF): Define only if needed.
14766 (WORDCHAR_P): Likewise. This one is never needed, but is used
14767 only in a comment talking about a compiler bug, so put inside
14768 the #if 0 of that comment.
14769 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14770 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14771 Remove; unused.
19ed5445 14772
1f3561e4 14773 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14774 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14775 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14776
ded6f8f7
PE
14777 * search.c (simple_search): Remove unused var.
14778
dbd37a95
PE
14779 * dired.c (compile_pattern): Move decl from here ...
14780 * lisp.h: ... to here, so that it can be checked.
14781 (struct re_registers): New forward decl.
14782
7e47afad
PE
14783 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14784
85f24f61
PE
14785 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14786 All uses changed.
14787 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14788 Rename locals to avoid shadowing.
5671df8f 14789 (Fvertical_motion): Mark locals as initialized.
85f24f61 14790
181aa2be 14791 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14792 (casify_region): Mark local as initialized.
181aa2be 14793
930d429c
PE
14794 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14795
7082eac6
PE
14796 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14797 New macros, so that the caller can use some names other than
14798 gcpro1, gcpro2, etc.
14799 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14800 of the new macros.
14801 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14802 argument, for consistency with GCPRO2_VAR, etc: it is now the
14803 prefix of the variable, not the variable itself. All uses
14804 changed.
38b2c076
PE
14805 * dired.c (directory_files_internal, file_name_completion):
14806 Rename locals to avoid shadowing.
14807
15206ed9
PE
14808 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14809 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14810 dired.c's scmp function, had undefined behavior.
14811 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14812 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14813 * buffer.h: ... to here, because these macros use current_buffer,
14814 and the new implementation with inline functions needs to have
14815 current_buffer in scope now, rather than later when the macros
14816 are used.
14817 (downcase, upcase1): New static inline functions.
14818 (DOWNCASE, UPCASE1): Reimplement using these functions.
14819 This avoids undefined behavior in expressions like
14820 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14821 from race conditions in accessing the global variables
14822 case_temp1 and case_temp2.
14823 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14824 * lisp.h (case_temp1, case_temp2): Remove their decls.
14825 * character.h (ASCII_CHAR_P): Move from here ...
14826 * lisp.h: ... to here, so that the inline functions mentioned
14827 above can use them.
14828
4a6bea26
PE
14829 * dired.c (directory_files_internal_unwind): Now static.
14830
f14b7e14
PE
14831 * fileio.c (file_name_as_directory, directory_file_name):
14832 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14833 Now static.
2893f146
PE
14834 (file_name_as_directory): Use const pointers when appropriate.
14835 (Fexpand_file_name): Likewise. In particular, newdir might
14836 point at constant storage, so make it a const pointer.
fd4ead52 14837 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14838 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14839 signedness issues.
f839df0c
PE
14840 (Fset_file_times, Finsert_file_contents, auto_save_error):
14841 Rename locals to avoid shadowing.
f14b7e14 14842
5716756e 14843 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14844 (Ftry_completion, Fall_completions): Rename or remove locals
14845 to avoid shadowing.
5716756e 14846
b4c3046a
PE
14847 * marker.c (bytepos_to_charpos): Remove; unused.
14848
b45db522
PE
14849 * lisp.h (verify_bytepos, count_markers): New decls,
14850 so that gcc does not warn that these functions aren't declared.
14851
85876d07
PE
14852 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14853 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14854 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14855 (copy_text): Remove unused local var.
85876d07 14856
03d78a21 14857 * filelock.c (within_one_second): Now static.
b3dd38ab 14858 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14859
5df8f01b
PE
14860 * buffer.c (fix_overlays_before): Mark locals as initialized.
14861 (fix_start_end_in_overlays): Likewise. This function should be
14862 simplified by using pointers-to-pointers, but that's a different
14863 matter.
b1d876f1 14864 (switch_to_buffer_1): Now static.
8f54f30a
PE
14865 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14866 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14867
a70072c9 14868 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14869 Fix pointer signedness issue.
edced198
PE
14870 (sys_subshell): Mark local as volatile if checking for lint,
14871 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14872 (MAXPATHLEN): Define only if needed.
a70072c9 14873
a0977c44
PE
14874 * process.c (serial_open, serial_configure): Move decls from here ...
14875 * systty.h: ... to here, so that they can be checked.
14876
a884fdcc
PE
14877 * fns.c (get_random, seed_random): Move extern decls from here ...
14878 * lisp.h: ... to here, so that they can be checked.
14879
604efe86 14880 * sysdep.c (reset_io): Now static.
b8950c94 14881 (wait_for_termination_signal): Remove; unused.
604efe86 14882
38fc62d9
PE
14883 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14884 (copy_keymap_item, append_key, push_text_char_description):
14885 Now static.
1004a21a 14886 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14887 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14888 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14889 (describe_map_tree):
14890 Rename locals to avoid shadowing.
38fc62d9 14891
2f2650da
PE
14892 * keyboard.c: Declare functions static if they are not used elsewhere.
14893 (echo_char, echo_dash, cmd_error, top_level_2):
14894 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14895 (read_char, kbd_buffer_get_event, make_lispy_position):
14896 (make_lispy_event, make_lispy_movement, apply_modifiers):
14897 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14898 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14899 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14900 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14901 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14902
a053e86c 14903 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14904 (mark_kboards): Move decl here ...
14905 * alloc.c (mark_kboards): ... from here.
a053e86c 14906
4752793e
PE
14907 * lisp.h (force_auto_save_soon): New decl.
14908
74f10ca7 14909 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14910 (DEFINE_DUMMY_FUNCTION): New macro.
14911 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14912 Use it.
c03cd23f
PE
14913 (main): Add casts to avoid warnings
14914 if GCC considers string literals to be constants.
74f10ca7 14915
022e70d4
PE
14916 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14917
59d6fe83
PE
14918 * dbusbind.c: Pointer signedness fixes.
14919 (xd_signature, xd_append_arg, xd_initialize):
14920 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14921 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14922 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14923 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14924
78320123
PE
14925 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14926 if GCC considers string literals to be constants.
49cebcca 14927 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14928
35ac2a97
SM
149292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14930
fb103ca9
SM
14931 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14932 (print_preprocess, print_object): New macro to fix last change.
14933
35ac2a97
SM
14934 * print.c (print_preprocess): Don't forget font objects.
14935
62973b41
JB
149362011-03-16 Juanma Barranquero <lekktu@gmail.com>
14937
14938 * emacs.c (USAGE3): Doc fixes.
14939
0e48bb22
AS
149402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14941
14942 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14943 structure.
14944
7684e57b
JB
149452011-03-14 Juanma Barranquero <lekktu@gmail.com>
14946
14947 * lisp.h (VWindow_system, Qfile_name_history):
14948 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14949 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14950 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14951
14952 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14953 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14954
14955 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14956 * w32console.c (detect_input_pending, read_input_pending)
14957 (encode_terminal_code):
14958 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14959 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14960 (w32_system_caret_y, Qfile_name_history):
14961 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14962 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14963 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14964 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14965 * w32proc.c (Qlocal, report_file_error):
14966 * w32term.c (Vwindow_system, updating_frame):
14967 * w32uniscribe.c (initialized, uniscribe_font_driver):
14968 Remove unneeded extern declarations.
14969
2aa46d6c
CY
149702011-03-14 Chong Yidong <cyd@stupidchicken.com>
14971
c96bbc66 14972 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14973
cffc6f3b
CY
149742011-03-13 Chong Yidong <cyd@stupidchicken.com>
14975
14976 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14977 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14978 These macros can no longer be used for assignment.
14979
44f230aa
SM
14980 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14981 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14982 (record_buffer_markers, fetch_buffer_markers): New functions for
14983 recording and fetching special buffer markers.
14984 (set_buffer_internal_1, set_buffer_temp): Use them.
14985
14986 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14987
14988 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14989
14990 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14991 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14992
14993 * xdisp.c (hscroll_window_tree):
14994 (reconsider_clip_changes): Use PT instead of BUF_PT.
14995
d251f04b
EZ
149962011-03-13 Eli Zaretskii <eliz@gnu.org>
14997
14998 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14999 $(EMACS_ROOT)/lib/intprops.h.
15000
f0c77cd1
PE
150012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15002
3eca4629
PE
15003 Fix more problems found by GCC 4.5.2's static checks.
15004
7c86ee98
PE
15005 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15006 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15007 (xg_free_frame_widgets): Make it clear that a local variable is
15008 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15009 (gdk_window_get_screen): Make it clear that this macro is needed
15010 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15011 (int_gtk_range_get_value): New function, which avoids a diagnostic
15012 from gcc -Wbad-function-cast.
15013 (xg_set_toolkit_scroll_bar_thumb): Use it.
15014 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15015 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15016 (get_utf8_string, xg_get_file_with_chooser):
15017 Rename locals to avoid shadowing.
15018 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15019
41729b81
PE
15020 * xgselect.c (xg_select): Remove unused var.
15021
f0c77cd1
PE
15022 * image.c (four_corners_best): Mark locals as initialized.
15023 (gif_load): Initialize transparent_p to zero (Bug#8238).
15024 Mark another local as initialized.
ec6cf4c6 15025 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15026
ce0ad53d 15027 * image.c (clear_image_cache): Now static.
d5d5a617 15028 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15029 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15030 (x_edge_detection): Remove unnecessary cast that
15031 gcc -Wbad-function-cast diagnoses.
2037898d 15032 (gif_load): Fix pointer signedness.
6ae141d6
PE
15033 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15034 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15035
33383987 150362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15037
d32df629
PE
15038 Improve quality of tests for time stamp overflow.
15039 For example, without this patch (encode-time 0 0 0 1 1
15040 1152921504606846976) returns the obviously-bogus value (-948597
15041 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15042 reports time overflow. See
15043 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15044 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15045 * editfns.c: Include limits.h and intprops.h.
15046 (TIME_T_MIN, TIME_T_MAX): New macros.
15047 (time_overflow): Move earlier, to before first use.
15048 (hi_time, lo_time): New functions, for an accurate test for
15049 out-of-range times.
15050 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15051 (Fget_internal_run_time): Don't assume time_t fits in int.
15052 (make_time): Use list2 instead of Fcons twice.
15053 (Fdecode_time): More accurate test for out-of-range times.
15054 (check_tm_member): New function.
15055 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15056 (lisp_time_argument): Don't rely on undefined left-shift and
15057 right-shift behavior when checking for time stamp overflow.
8be6f318 15058
fe31d94c
PE
15059 * editfns.c (time_overflow): New function, refactoring common code.
15060 (Fformat_time_string, Fdecode_time, Fencode_time):
15061 (Fcurrent_time_string): Use it.
15062
8be6f318
PE
15063 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15064 * dired.c (make_time): Move to ...
15065 * editfns.c (make_time): ... here.
15066 * systime.h: Note the move.
15067
09d9db2c 150682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15069
126bc0dc
YM
15070 * fringe.c (update_window_fringes): Remove unused variables.
15071
c47cbdfd
YM
15072 * unexmacosx.c (copy_data_segment): Also copy __got section.
15073 (Bug#8223)
15074
7ac80be9
EZ
150752011-03-12 Eli Zaretskii <eliz@gnu.org>
15076
c96bbc66 15077 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15078 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15079 Constify `char *' arguments and their references according to
15080 prototypes in tparam.h.
15081
ecb0f94d 15082 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15083
7ac80be9
EZ
15084 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15085 Adapt all references accordingly.
15086
15087 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15088
ef1fd07e
TT
150892011-03-11 Tom Tromey <tromey@redhat.com>
15090
15091 * buffer.c (syms_of_buffer): Remove obsolete comment.
15092
7ef4b50c
EZ
150932011-03-11 Eli Zaretskii <eliz@gnu.org>
15094
15095 * termhooks.h (encode_terminal_code): Declare prototype.
15096
15097 * msdos.c (encode_terminal_code): Don't declare prototype.
15098
15099 * term.c (encode_terminal_code): Now external again, used by
15100 w32console.c and msdos.c.
15101
44f230aa
SM
15102 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15103 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15104
4b1ec863 151052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15106
1714f52b 15107 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15108
4b1ec863
PE
15109 * fringe.c (update_window_fringes): Mark locals as initialized
15110 (Bug#8227).
15111 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15112
524c7aa6
PE
15113 * alloc.c (mark_fringe_data): Move decl from here ...
15114 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15115 to check its interface.
15116 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15117
a5c0af81 15118 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15119 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15120 (fontset_font): Mark local as initialized.
a9a06e0b 15121 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15122
b4716021
PE
15123 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15124
811e9bac 15125 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15126 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15127 (x_own_selection, Fx_disown_selection_internal): Rename locals
15128 to avoid shadowing.
15129 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15130
7e3ab302
PE
15131 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15132 so that the caller can use some name other than gcpro1.
15133 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15134 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15135 (Fx_backspace_delete_keys_p):
15136 Use them to avoid shadowing, and rename vars to avoid shadowing.
15137 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15138 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15139 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15140 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15141 Remove unused locals.
7e3ab302
PE
15142 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15143 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15144 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15145 macros.
f78faa98 15146
e2b13473
PE
15147 * xterm.h (x_mouse_leave): New decl.
15148
77f23912
PE
15149 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15150 Remove unused functions.
cdf4ba58
PE
15151 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15152 (x_calc_absolute_position): Now static.
7411c686 15153 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15154 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15155 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15156 unless they are used.
38d0b34a
PE
15157 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15158 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15159 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15160 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15161 (x_error_catcher, x_connection_closed, x_error_handler):
15162 (x_error_quitter, xembed_send_message, x_iconify_frame):
15163 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15164 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15165 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15166
44f230aa
SM
15167 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15168 Rename or move locals to avoid shadowing.
6b463e58 15169 (tty_defined_color, merge_face_heights): Now static.
5967d051 15170 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15171 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15172 does not deduce is never used uninitialized.
73719eba
PE
15173 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15174 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15175
426994c3 15176 * terminal.c (store_terminal_param): Now static.
5489860b 15177
032f1620 15178 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15179 (set_frame_menubar): Remove unused local.
d4323972 15180 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15181 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15182 since they might point to immutable storage.
281585b0
PE
15183 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15184 since it's unused otherwise.
032f1620 15185
367c19e5 15186 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15187 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15188 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15189 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15190 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15191 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15192 does not deduce are never used uninitialized.
70739cbe 15193
07b48fa9
PE
15194 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15195
8868a238 15196 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15197 * window.c (window_loop, size_window):
15198 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15199
7e5cf297 15200 * window.c (display_buffer): Now static.
d6550a9f
PE
15201 (size_window): Mark variables that gcc -Wuninitialized
15202 does not deduce are never used uninitialized.
a586633d
PE
15203 * window.h (check_all_windows): New decl, to forestall
15204 gcc -Wmissing-prototypes diagnostic.
5b555da1 15205 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15206
f6095868
PE
15207 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15208 shadowing.
15209 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15210 Include <limits.h>.
15211 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15212 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15213 (load_charset_map): Mark variables that gcc -Wuninitialized
15214 does not deduce are never used uninitialized.
53df7c11 15215 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15216
f38b440c
PE
15217 * coding.c (coding_set_source, coding_set_destination):
15218 Use "else { /* comment */ }" rather than "else /* comment */;"
15219 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15220 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15221 a block, when the outer 'i' will do.
15222 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15223 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15224 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15225 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15226 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15227 Rename locals to avoid shadowing.
15228 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15229 * coding.c (emacs_mule_char, encode_invocation_designation):
15230 Now static, since they're not used elsewhere.
413bb2db 15231 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15232 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15233 (decode_coding_emacs_mule): Mark variables that gcc
15234 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15235 (detect_coding_iso_2022): Initialize a local variable that might
15236 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15237 this initialization is needed. (Bug#8211)
5f58e762
PE
15238 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15239 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15240 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15241 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15242 Remove unused macros.
f38b440c 15243
232b38b9 15244 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15245 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15246 * character.c (string_count_byte8): Likewise.
232b38b9 15247
fb90da1b
PE
15248 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15249 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15250
fb93dbc2
PE
15251 * chartab.c (copy_sub_char_table): Now static, since it's not used
15252 elsewhere.
5c156ace
PE
15253 (sub_char_table_ref_and_range, char_table_ref_and_range):
15254 Rename locals to avoid shadowing.
bbcd0949 15255 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15256
7d3b3862 15257 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15258 (BIDI_BOB): Remove unused macro.
7d3b3862 15259
6be7d3da
PE
15260 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15261 deduce are never used uninitialized.
c2ed9c8b 15262 * term.c (encode_terminal_code): Likewise.
6be7d3da 15263
75f8807f 15264 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15265
50938595
PE
15266 * tparam.h: New file.
15267 * term.c, tparam.h: Include it.
15268 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15269 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15270 Move these decls to tparam.h, and make them agree with what
15271 is actually in tparam.c. The previous trick of using incompatible
15272 decls in different modules does not conform to the C standard.
15273 All callers of tparam changed to use tparam's actual API.
15274 * tparam.c (tparam1, tparam, tgoto):
15275 Use const pointers where appropriate.
15276
fbceeba2
PE
15277 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15278 * cm.h (struct cm): Likewise.
15279 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15280 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15281 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15282 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15283 (turn_on_face, init_tty): Likewise.
15284 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15285
7f3f1250
PE
15286 * term.c (term_mouse_position): Rename local to avoid shadowing.
15287
e6ca6543
PE
15288 * alloc.c (mark_ttys): Move decl from here ...
15289 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15290
c40f8d15
AS
152912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15292
15293 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15294
cfe0661d
JB
152952011-03-09 Juanma Barranquero <lekktu@gmail.com>
15296
15297 * search.c (compile_pattern_1): Remove argument regp, unused since
15298 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15299 (compile_pattern): Don't pass it.
15300
0afb4571
J
153012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15302
15303 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15304 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15305 for ! HAVE_GTK3.
15306 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15307
15308 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15309
15310 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15311 gdk_window_get_screen, gdk_window_get_geometry,
15312 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15313 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15314 (xg_get_pixbuf_from_pixmap): New function.
15315 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15316 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15317 Call xg_get_pixbuf_from_pixmap instead of
15318 gdk_pixbuf_get_from_drawable.
15319 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15320 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15321 (xg_check_special_colors): Use GtkStyleContext and its functions
15322 for HAVE_GTK3.
15323 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15324 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15325 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15326 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15327 Call gtk_widget_get_preferred_size.
0afb4571
J
15328 (xg_frame_resized): gdk_window_get_geometry only takes 5
15329 parameters.
44f230aa
SM
15330 (xg_win_to_widget, xg_event_is_for_menubar):
15331 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15332 (xg_set_widget_bg): New function.
15333 (delete_cb): New function.
895009e1 15334 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15335 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15336 (xg_set_background_color): Call xg_set_widget_bg.
15337 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15338 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15339 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15340 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15341 if ! HAVE_GTK3.
15342 (update_frame_tool_bar): Call gtk_widget_hide.
15343 (xg_initialize): Use GDK_KEY_g.
15344
15345 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15346 if ! HAVE_GTK3
15347 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15348
15349 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15350 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15351 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15352
1c2cc4ef
JB
153532011-03-08 Juanma Barranquero <lekktu@gmail.com>
15354
15355 * w32xfns.c (select_palette): Check success of RealizePalette against
15356 GDI_ERROR, not zero.
15357
33383987 15358See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15359
15360;; Local Variables:
15361;; coding: utf-8
aac0c6e3
MR
15362;; End:
15363
2f097256 15364 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15365
15366 This file is part of GNU Emacs.
15367
15368 GNU Emacs is free software: you can redistribute it and/or modify
15369 it under the terms of the GNU General Public License as published by
15370 the Free Software Foundation, either version 3 of the License, or
15371 (at your option) any later version.
15372
15373 GNU Emacs is distributed in the hope that it will be useful,
15374 but WITHOUT ANY WARRANTY; without even the implied warranty of
15375 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15376 GNU General Public License for more details.
15377
15378 You should have received a copy of the GNU General Public License
15379 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.