* xml.el (xml-parse-string): Fix typo in handling of bad character references.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1a359750
GM
12013-02-13 Glenn Morris <rgm@gnu.org>
2
3 * keyboard.c (input-decode-map, key-translation-map): Doc fixes.
4
4458c255
PE
52013-02-12 Paul Eggert <eggert@cs.ucla.edu>
6
f53f992a
PE
7 Improve AIX port some more (Bug#13650).
8 With this, it should be as good as it was in 23.3, though it's
9 still pretty bad: the dumped emacs does not run. See Mark Fleishman in
10 http://lists.gnu.org/archive/html/help-gnu-emacs/2011-04/msg00287.html
11 * unexaix.c (start_of_text): Remove.
12 (_data, _text): Declare as char[], not int, as AIX manual suggests.
13 (bias, lnnoptr, text_scnptr, data_scnptr, load_scnptr)
14 (orig_load_scnptr, orig_data_scnptr):
15 Now off_t, not long, since they are file offsets.
16 (make_hdr): Use _data, not start_of_data ().
17 This is the key part of the fix.
18 (make_hdr, unrelocate_symbols): Use off_t for file offsets.
19 (unrelocate_symbols): Cast pointers to intptr_t, not to ulong.
20
4458c255
PE
21 * pre-crt0.c (data_start): Initialize to 1.
22 This ports to compilers that optimize the external declaration
23 'int x = 0;' as if it were 'int x;' to shrink the executable.
24
227be86d
PE
252013-02-11 Paul Eggert <eggert@cs.ucla.edu>
26
27 Improve AIX port (Bug#13650).
28 This doesn't fix the bug, but it makes progress: Emacs builds now.
29 * unexaix.c: Include inttypes.h, stdarg.h.
30 (report_error, report_error_1): Mark as _Noreturn.
31 (report_error): Don't report the wrong errno.
32 (report_error_1): Now varargs. All callers changed.
33 (make_hdr): Use uintptr_t, not unsigned, when converting pointers
34 to unsigned. Don't use ADDR_CORRECT, as it no longer exists.
35 (write_ptr): Use %p to print address rather than %lx and a cast
36 to unsigned long. Grow buffer a bit, to be safer.
37
713bfeaa
EZ
382013-02-11 Eli Zaretskii <eliz@gnu.org>
39
40 * bidi.c (bidi_resolve_neutral): After finding the next
41 non-neutral character, accept NEUTRAL_ON type as well, because
42 directional control characters, such as LRE and RLE, have their
43 type converted to that by bidi_resolve_weak. This avoids aborts
44 when LRE/RLE follows a run of neutrals.
45 (bidi_move_to_visually_next): Assert that return value of
46 bidi_peek_at_next_level is non-negative. Negative values will
47 cause an infloop.
48
efad91ec 492013-02-05 Daniel Colascione <dancol@dancol.org>
b8f74366
DC
50
51 * emacs.c: Use execvp, not execv, when DAEMON_MUST_EXEC, so that
52 daemon mode works on cygw32 when Emacs is installed and not just
53 during development.
54
18a80473
EZ
552013-02-01 Eli Zaretskii <eliz@gnu.org>
56
e7c3fb06
EZ
57 * callproc.c (Fcall_process): Make sure program name in PATH and
58 new_argv[0] is encoded, if needed. Otherwise, un-encoded string
59 is passed to exec/spawnve, which fails unless the file-name
60 encoding is UTF-8.
61
18a80473
EZ
62 * w32proc.c (sys_spawnve): Make sure escape_char is initialized,
63 even if w32-quote-process-args is nil.
64
224f4ec1
EZ
652013-01-27 Eli Zaretskii <eliz@gnu.org>
66
67 * w32.c (sys_open): Zero out the flags for the new file descriptor.
68 (sys_close): Zero out the flags for the file descriptor before
69 closing it. (Bug#13546)
70
806fed21
EZ
712013-01-26 Eli Zaretskii <eliz@gnu.org>
72
73 * w32.c (parse_root, get_volume_info, readdir, read_unc_volume)
74 (logon_network_drive, stat_worker, symlink, chase_symlinks): Use
75 CharNextExA and CharPrevExA to iterate over file names encoded in
76 DBCS. (Bug#13553)
77
6ee4509a
EZ
782013-01-25 Eli Zaretskii <eliz@gnu.org>
79
80 * w32.c (w32_get_long_filename, init_environment, readlink):
81 Support file names encoded in DBCS codepages.
26854e9c
EZ
82 (readlink): Use the current file-name-coding-system, not the ANSI
83 codepage, to decode and handle targets of symlinks.
6ee4509a 84
6d2851de
EZ
852013-01-23 Eli Zaretskii <eliz@gnu.org>
86
87 * w32.c (max_filename_mbslen): New function.
88 (normalize_filename, readdir): Use it to detect locales where ANSI
89 encoding of file names uses a double-byte character set (DBCS).
90 If a DBCS encoding is used, advance by characters using
91 CharNextExA, instead of incrementing a 'char *' pointer. Use
92 _mbslwr instead of _strlwr. (Bug#13515)
93
81abbb95
EZ
942013-01-22 Eli Zaretskii <eliz@gnu.org>
95
96 * w32heap.c (allocate_heap) [!_WIN64]: Decrease the initial
97 request of memory reservation to 1.7GB. (Bug#13065)
98
ba14c607
AS
992013-01-20 Andreas Schwab <schwab@linux-m68k.org>
100
101 * coding.c (detect_coding_iso_2022): Move back mis-reordered code
102 at check_extra_latin label. (Bug#13505)
103
085d34c4
GM
1042013-01-17 Glenn Morris <rgm@gnu.org>
105
106 * fns.c (Frandom): Doc fix.
107
b826986f
JD
1082013-01-13 Jan Djärv <jan.h.d@swipnet.se>
109
110 * nsfont.m (LCD_SMOOTHING_MARGIN): New define.
111 (nsfont_draw): Remove disabling of LCD smoothing.
112 (ns_glyph_metrics): Add LCD_SMOOTHING_MARGIN to bearings to fix
2e7a1892 113 Bug#11484 with LCD smoothing on.
b826986f 114
f5e9cbd4 1152013-01-11 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> (tiny change)
38693137
JD
116
117 * gtkutil.c (xg_initialize): Backport from trunk.
118 Add ifdef HAVE_FREETYPE around x_last_font_name (Bug#13403).
119
b6f960a0
PE
1202013-01-11 Paul Eggert <eggert@cs.ucla.edu>
121
45b7bfdd
PE
122 Backport typo fix from trunk, for AIX (Bug#13408).
123 * eval.c (mark_backtrace) [BYTE_MARK_STACK]: Remove stray '*'.
124 This follows up on the 2012-09-29 patch that removed indirection
125 for the 'function' field. Reported by Sergey Vinokurov in
126 <http://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00263.html>.
127
b6f960a0
PE
128 Fix SIGDANGER handlers, for AIX (Bug#13408).
129 * sysdep.c.c (handle_danger_signal, deliver_danger_signal) [SIGDANGER]:
130 Move handlers here from emacs.c; they were out of place.
131
b630991b
EZ
1322013-01-05 Eli Zaretskii <eliz@gnu.org>
133
134 * xdisp.c (dump_glyph): Align glyph data better. Use "pD" instead
135 of a non-portable "t" to print ptrdiff_t values. Allow up to 9
136 digits for buffer positions, before misalignment starts. Display
137 "0" for integer "object" field.
138 (dump_glyph_row): Adapt the header line to changes in dump_glyph.
139 Display the newline glyph more unambiguously.
140
f032a318
YM
1412013-01-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
142
143 * nsterm.m (ns_draw_underwave):
144 * w32term.c (w32_draw_underwave):
145 * xterm.c (x_draw_underwave): Make underwave look more triangular
146 and also degrade gracefully for small fonts. (Bug#13000)
147
4240dd3c
YM
148 * nsterm.m (ns_draw_text_decoration):
149 * w32term.c (x_draw_glyph_string):
150 * xterm.c (x_draw_glyph_string): Don't use previous underline
151 thickness and position if previous underline type is underwave.
152
08f59219
GM
1532012-12-31 Glenn Morris <rgm@gnu.org>
154
155 * keymap.c (Fkey_description): Doc fix. (Bug#13323)
156
2550c6e4
AS
1572012-12-29 Andreas Schwab <schwab@linux-m68k.org>
158
159 * src/Makefile.in (TEMACS_LDFLAGS2): Remove.
160 (LIBS_GNUSTEP): Define.
161 (LIBES): Add $(LIBS_GNUSTEP).
162 (temacs$(EXEEXT)): Use $(LDFLAGS) instead of $(TEMACS_LDFLAGS2).
163
7a3a7493
EZ
1642012-12-27 Eli Zaretskii <eliz@gnu.org>
165
166 * xdisp.c (set_cursor_from_row): Don't confuse a truncation or
167 continuation glyph on a TTY with an indication of an empty line.
168 (Bug#13277)
169
1ab0c851
GM
1702012-12-27 Glenn Morris <rgm@gnu.org>
171
172 * cygw32.c (Fcygwin_convert_file_name_to_windows)
173 (Fcygwin_convert_file_name_from_windows): Doc fixes.
174
f5c81c80
EZ
1752012-12-24 Eli Zaretskii <eliz@gnu.org>
176
177 * fileio.c (file_name_as_directory, directory_file_name): Accept
178 an additional argument MULTIBYTE to indicate whether the input C
179 came from a multibyte or a unibyte Lisp string; all callers
180 adjusted. Don't assume the input string is always multibyte.
181 (Bug#13262)
182 (Ffile_name_directory) [DOS_NT]: Handle unibyte strings correctly:
183 don't ENCODE_FILE them, and return a unibyte string if the input
184 was unibyte.
185 (Fexpand_file_name): Don't mix unibyte with multibyte strings, and
186 don't assume the input strings will always be multibyte. If the
187 input strings are multibyte, decode strings obtained from C
188 library functions.
189
94900bfe
MR
1902012-12-22 Martin Rudalics <rudalics@gmx.at>
191
192 * window.c (Fselect_window): Reword doc-string (Bug#13248).
193
7efa3fb3
EZ
1942012-12-21 Eli Zaretskii <eliz@gnu.org>
195
bb085aed
EZ
196 * fileio.c (Finsert_file_contents): Doc fix.
197
7efa3fb3
EZ
198 * w32proc.c (new_child, delete_child, find_child_pid): For a
199 subprocess, consider its slot being in use as long as its process
200 handle (procinfo.hProcess) is not NULL. This avoids reusing the
201 slot when a new process is started immediately after killing
202 another one, without waiting enough time for the first process to
203 be reaped and resources allocated for it be orderly freed.
204 (Bug#13086)
205 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
206
c1f02afa
CY
2072012-12-21 Chong Yidong <cyd@gnu.org>
208
209 * buffer.c (Fset_buffer_major_mode): Doc fix (Bug#13231).
210
5bec25eb
CY
2112012-12-15 Chong Yidong <cyd@gnu.org>
212
213 * fns.c (Fcompare_strings): Doc fix (Bug#13081).
214
92340ec7
EZ
2152012-12-14 Eli Zaretskii <eliz@gnu.org>
216
217 * w32.c (get_name_and_id): Always pass NULL as the first argument
218 of lookup_account_sid. Avoids crashes with UNC file names that
219 refer to DFS domains, not to specific machine names. (Bug#12621)
220 Remove now unused argument FNAME; all callers changed.
221 (get_file_owner_and_group): Remove now unused argument FNAME; all
222 callers changed.
223
e8c6e965
EZ
2242012-12-11 Eli Zaretskii <eliz@gnu.org>
225
226 * search.c (search_buffer): Check the inverse translations of each
227 character in pattern when the buffer being searched is unibyte.
228 (Bug#13084)
229
184246df
PE
2302012-12-10 Paul Eggert <eggert@cs.ucla.edu>
231
232 * fileio.c (Fvisited_file_modtime): Return (-1 ...) for nonexistent
233 files, fixing a regression from 24.2.
645c6a30 234 (Fverify_visited_file_modtime): Don't read uninitialized st.st_size.
184246df 235
a06ae17d
JD
2362012-12-08 Jan Djärv <jan.h.d@swipnet.se>
237
238 * nsterm.m (fd_handler:): FD_ZERO fds (Bug#13103).
239
cb576b5c
FP
2402012-12-08 Fabrice Popineau <fabrice.popineau@gmail.com>
241
242 * w32fns.c (cache_system_info): Cast sysinfo_cache.dwPageSize to
243 DWORD_PTR, for compatibility with 64-bit builds.
244
a06ae17d 245 * w32.c (_PROCESS_MEMORY_COUNTERS_EX):
cb576b5c
FP
246 (GetProcessWorkingSetSize_Proc, get_process_working_set_size)
247 (system_process_attributes): Use SIZE_T rather than DWORD, for
248 compatibility with 64-bit builds.
249
76b92fee
CS
2502012-12-08 Christopher Schmidt <christopher@ch.ristopher.com>
251
252 * lread.c (Vload_source_file_function): Doc fix (Bug#11647).
253
81d8cc53
EZ
2542012-12-07 Eli Zaretskii <eliz@gnu.org>
255
256 * indent.c (Fvertical_motion): If a display string will be
257 displayed on the left or the right margin, don't consider it as a
258 factor in cursor positioning. (Bug#13108)
259
2cec368c
MR
2602012-12-07 Martin Rudalics <rudalics@gmx.at>
261
262 * editfns.c (Fcompare_buffer_substrings): Reword doc-string.
263
d3cefd13
EZ
2642012-12-05 Eli Zaretskii <eliz@gnu.org>
265
266 * callproc.c (Fcall_process_region) [!HAVE_MKSTEMP]: If mktemp
267 fails, signal an error instead of continuing with an empty
268 string. (Bug#13079)
7c2fcf9b
EZ
269 Encode expanded temp file pattern before passing it to mkstemp or
270 mktemp.
d3cefd13 271
2e7cddd3
EZ
2722012-12-04 Eli Zaretskii <eliz@gnu.org>
273
274 * fileio.c (file_name_as_directory, directory_file_name) [DOS_NT]:
275 Encode the file name before passing it to dostounix_filename, in
276 case it will downcase it (under w32-downcase-file-names).
277 (Bug#12933)
278
a2458031
CY
2792012-12-01 Chong Yidong <cyd@gnu.org>
280
281 * fileio.c (Vauto_save_list_file_name): Doc fix.
282
c7b36b95
FP
2832012-11-30 Fabrice Popineau <fabrice.popineau@gmail.com>
284
285 * w32fns.c: Remove prototype of atof.
286 (syspage_mask): Declared DWORD_PTR, for compatibility with 64-bit
287 builds.
288 (file_dialog_callback): Declared UINT_PTR.
289
290 * w32common.h (syspage_mask): Declare DWORD_PTR, for compatibility
291 with 64-bit builds.
292
293 * w32.c (FILE_DEVICE_FILE_SYSTEM, METHOD_BUFFERED)
294 (FILE_ANY_ACCESS, CTL_CODE) [_MSC_VER]: Define only if not already
295 defined.
296
14d27346
GM
2972012-11-27 Glenn Morris <rgm@gnu.org>
298
a9de9f0c 299 * data.c (Fboundp, Fsymbol_value): Doc fix re lexical-binding.
14d27346 300
3fa1e84d
EZ
3012012-11-26 Eli Zaretskii <eliz@gnu.org>
302
303 * fontset.c (Finternal_char_font): Return nil on non-GUI frames.
304 (Bug#11964)
305
d4547511
PE
3062012-11-24 Paul Eggert <eggert@cs.ucla.edu>
307
308 Revert recent change for Bug#8855.
309 As reported by Harald Hanche-Olsen in
310 <http://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00445.html>
311 the change introduces a further bug, of creating lots of zombie
312 processes in some cases. Further work is needed to come up with a
313 better fix for Bug#8855.
314
22294a56
EZ
3152012-11-24 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (draw_glyphs): Don't draw in mouse face if mouse
318 highlighting on the frame was cleared. Prevents assertion
319 violations when repeatedly clicking on the "Top" link of the
320 "bread-crumbs" in Info buffers.
321
6d4e8f62 3222012-11-23 Paul Eggert <eggert@cs.ucla.edu>
259719a6 323 Eli Zaretskii <eliz@gnu.org>
6d4e8f62
PE
324
325 Fix a race condition with glib (Bug#8855).
259719a6
EZ
326 The symptom is a diagnostic "GLib-WARNING **: In call to
327 g_spawn_sync(), exit status of a child process was requested but
328 SIGCHLD action was set to SIG_IGN and ECHILD was received by
329 waitpid(), so exit status can't be returned." The diagnostic
330 is partly wrong, as the SIGCHLD action is not set to SIG_IGN.
331 The real bug is a race condition between Emacs and glib: Emacs
332 does a waitpid (-1, ...) and reaps glib's subprocess by mistake,
333 so that glib can't find it. Work around the bug by invoking
334 waitpid only on subprocesses that Emacs itself creates.
6d4e8f62 335
259719a6 336 This is a backport from the trunk, consisting of:
6d4e8f62
PE
337
338 * w32proc.c (create_child): Don't clip the PID of the child
339 process to fit into an Emacs integer, as this is no longer a
340 restriction.
341 (waitpid): Rename from sys_wait. Emulate a Posix 'waitpid' by
342 reaping only the process specified by PID argument, if that is
343 positive. Use PID instead of dead_child to know which process to
344 reap. Wait for the child to die only if WNOHANG is not in
345 OPTIONS.
346 (sys_select): Don't set dead_child.
347
348 * sysdep.c (wait_for_termination_1): Remove the WINDOWSNT portion,
349 as it is no longer needed.
350
351 * process.c (waitpid, WUNTRACED) [!WNOHANG]: Remove definitions,
352 no longer needed.
259719a6
EZ
353 (create_process, record_child_status_change): Don't use special
354 value -1 in pid field, as the caller now must know the pid rather
355 than having the callee infer it. The inference was sometimes
356 incorrect anyway, due to another race.
6d4e8f62
PE
357 (create_process): Set new 'alive' member if child is created.
358 (process_status_retrieved): New function.
359 (record_child_status_change): Use it.
360 Accept negative 1st argument, which means to wait for the
361 processes that Emacs already knows about. Move special-case code
362 for DOS_NT (which lacks WNOHANG) here, from caller. Keep track of
363 processes that have already been waited for, by testing and
259719a6
EZ
364 clearing new 'alive' member. Remove the setting of
365 record_at_most_one_child for the !WNOHANG case.
6d4e8f62
PE
366 (CAN_HANDLE_MULTIPLE_CHILDREN): Remove, as record_child_status_change
367 now does this internally.
368 (handle_child_signal): Let record_child_status_change do all
369 the work, since we do not want to reap all exited child processes,
370 only the child processes that Emacs itself created.
371 * process.h (Lisp_Process): New boolean member 'alive'.
372
8654a41b
EZ
3732012-11-23 Eli Zaretskii <eliz@gnu.org>
374
24becea4
EZ
375 * xdisp.c (set_cursor_from_row): Skip step 2 only if point is not
376 between bpos_covered and bpos_max. This fixes cursor display when
377 several display strings follow each other.
378
8654a41b
EZ
379 * .gdbinit (pgx): If the glyph's object is a string, display the
380 pointer to string data, rather than the value of the string object
381 itself (which barfs under CHECK_LISP_OBJECT_TYPE).
382
cb5867b1
EZ
3832012-11-21 Eli Zaretskii <eliz@gnu.org>
384
385 * indent.c (Fvertical_motion): If the starting position is covered
386 by a display string, return to one position before that, to avoid
387 overshooting it inside move_it_to. (Bug#12930)
388
a16ac13f
DC
3892012-11-20 Daniel Colascione <dancol@dancol.org>
390
391 * w32fns.c (Fx_file_dialog):
392 (Fx_file_dialog): Accomodate rename of cygwin_convert_path* to
393 cygwin_convert_file_name*.
394
395 * cygw32.c (Fcygwin_convert_path_to_windows, syms_of_cygw32):
396 Rename cygwin_convert_path* to cygwin_convert_file_name*.
397
4ffea447
KB
3982012-11-20 Ken Brown <kbrown@cornell.edu>
399
400 * emacs.c (main): Set the G_SLICE environment variable for all
401 Cygwin builds, not just GTK builds. See
402 https://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00368.html.
403
88c4a13c
EZ
4042012-11-19 Eli Zaretskii <eliz@gnu.org>
405
406 * xdisp.c (start_hourglass) [HAVE_NTGUI]: Don't mix declaration of
407 w32_note_current_window with code. (Backport from trunk.)
408
409 * w32.c (FILE_DEVICE_FILE_SYSTEM, METHOD_BUFFERED)
410 (FILE_ANY_ACCESS, CTL_CODE, FSCTL_GET_REPARSE_POINT) [_MSC_VER]:
411 Define for the MSVC compiler.
412
413 * w32term.h (EnumSystemLocalesW) [_MSC_VER]: Add a missing
414 semi-colon.
415
273ac8d1
EZ
4162012-11-18 Eli Zaretskii <eliz@gnu.org>
417
418 * fileio.c (Fsubstitute_in_file_name, Ffile_name_directory)
419 (Fexpand_file_name) [DOS_NT]: Pass encoded file name to
420 dostounix_filename. Prevents crashes down the road, because
421 dostounix_filename assumes it gets a unibyte string. Reported by
422 Michel de Ruiter <michel@sentient.nl>, see
423 http://lists.gnu.org/archive/html/help-emacs-windows/2012-11/msg00017.html
424
d8715cdf
EZ
4252012-11-17 Eli Zaretskii <eliz@gnu.org>
426
427 * w32select.c: Include w32common.h before w32term.h, so that
428 windows.h gets included before w32term.h uses some of its
429 features, see below.
430
431 * w32term.h (LOCALE_ENUMPROCA, LOCALE_ENUMPROCW) [_MSC_VER]: New
432 typedefs.
433 (EnumSystemLocalesA, EnumSystemLocalesW) [_MSC_VER]: New
434 prototypes.
435 (EnumSystemLocales) [_MSC_VER]: Define if undefined. (Bug#12878)
436
7436fc63
JD
4372012-11-17 Jan Djärv <jan.h.d@swipnet.se>
438
439 * nsterm.m (hold_event): Set send_appdefined to YES (Bug#12834).
440 (ns_select): Return at once if events are held (Bug#12834).
441
86dcf21c 4422012-11-16 enami tsugutomo <tsugutomo.enami@jp.sony.com>
443
444 * unexelf.c (ELFSIZE) [__NetBSD__ && _LP64]: Set to 64.
445 Needed following 2012-10-20 change. (Bug#12902)
446
d56f2e49
GM
4472012-11-16 Glenn Morris <rgm@gnu.org>
448
449 * editfns.c (Fmessage): Mention message-log-max. (Bug#12849)
450
5c2a7148
SM
4512012-11-15 Stefan Monnier <monnier@iro.umontreal.ca>
452
453 * eval.c (Finteractive_p): Revert lexbind-merge mishap.
454
730b2d8f
EZ
4552012-11-14 Eli Zaretskii <eliz@gnu.org>
456
457 * w32proc.c (timer_loop): Make sure SuspendThread and ResumeThread
458 use the same value of thread handle.
459 (start_timer_thread): If the timer thread exited (due to error),
460 clean up by closing the two handles it used. Duplicate the caller
461 thread's handle here, so it gets duplicated only once, when
462 launching the timer thread. Set priority of the timer thread, not
463 the caller thread.
464 (getitimer): Don't duplicate the caller thread's handle here.
465 (Bug#12832)
466
f99c65e5
JD
4672012-11-13 Jan Djärv <jan.h.d@swipnet.se>
468
469 * nsterm.m (hold_event): Send SIGIO to make sure ns_read_socket is
470 called (Bug#12834).
471
32520273
EZ
4722012-11-12 Eli Zaretskii <eliz@gnu.org>
473
474 * xdisp.c (decode_mode_spec): Limit the value of WIDTH argument
475 passed to pint2str and pint2hrstr to be at most the size of the
476 frame's decode_mode_spec_buffer. This avoids crashes with very
477 large values of FIELD_WIDTH argument to decode_mode_spec.
478 (Bug#12867)
479
fdaf534a
MR
4802012-11-07 Martin Rudalics <rudalics@gmx.at>
481
482 * window.c (Fsplit_window_internal): Set combination limit of
483 new parent window to t iff Vwindow_combination_limit is t;
484 fixing a regression introduced with the change from 2012-09-22.
5c2a7148
SM
485 (Fwindow_combination_limit, Fset_window_combination_limit):
486 Fix doc-strings.
fdaf534a 487
acf93bcf
EZ
4882012-11-06 Eli Zaretskii <eliz@gnu.org>
489
490 * xdisp.c (try_scrolling): Fix correction of aggressive-scroll
491 amount when the scroll margins are too large. When scrolling
492 backwards in the buffer, give up if cannot reach point or the
5c2a7148
SM
493 scroll margin within a reasonable number of screen lines.
494 Fixes point position in window under scroll-up/down-aggressively when
acf93bcf
EZ
495 point is positioned many lines beyond the window top/bottom.
496 (Bug#12811)
497
508f51f5
EZ
4982012-11-05 Eli Zaretskii <eliz@gnu.org>
499
500 * ralloc.c (relinquish): If real_morecore fails to return memory
501 to the system, don't crash; instead, leave the last heap
502 unchanged and return. (Bug#12774)
503
67b50ba4 5042012-11-03 Eli Zaretskii <eliz@gnu.org>
ad10696b 505
1d4341f9
EZ
506 * lisp.mk: Adjust comments to the fact that term/internal is now
507 loaded from loadup.el.
ad10696b 508
b3cf17f6
EZ
509 * msdos.c (msdos_abort): Rename from emacs_abort, and make static.
510 (msdos_fatal_signal): New function.
511 (XMenuActivate): Adjust the call to kbd_buffer_events_waiting to
512 its argument list.
513
514 * conf_post.h (_GL_EXECINFO_INLINE) [MSDOS]: Define to "inline"
515 for GCC versions before 4.
516 (emacs_raise): Define to call msdos_fatal_signal.
67b50ba4
EZ
517
518 * xdisp.c (init_from_display_pos): Fix initialization of the bidi
519 iterator when starting in the middle of a display or overlay
520 string. (Bug#12745)
521
858f0f24
EZ
5222012-11-03 Jan Djärv <jan.h.d@swipnet.se>
523
524 * widget.c (resize_cb): New function.
525 (EmacsFrameRealize): Add resize_cb as event handler (Bug#12733).
526 (EmacsFrameResize): Check if all is up to date before changing frame
527 size.
528
7e8b50d9
EZ
5292012-11-01 Eli Zaretskii <eliz@gnu.org>
530
531 * w32proc.c (getpgrp, setpgid): New functions. (Bug#12776)
532
322aea6d
PE
5332012-10-31 Paul Eggert <eggert@cs.ucla.edu>
534
535 Fix crash when using Emacs as commit editor for git (Bug#12697).
536 * callproc.c (setpgrp): Remove macro, as we now use setpgid
537 and it is configured in conf_post.h.
538 (Fcall_process): Don't invoke both setsid and setpgid; the former
539 is enough, if it exists.
540 * callproc.c (Fcall_process, child_setup):
541 * process.c (create_process): Use setpgid.
542 * conf_post.h (setpgid) [!HAVE_SETPGID]: New macro, which substitutes
543 for the real thing.
544 * dispnew.c (init_display): Initialize the foreground group
545 if we are running a tty display.
546 * emacs.c (main): Do not worry about setpgrp; init_display does it now.
547 * lisp.h (init_foreground_group): New decl.
548 * sysdep.c (inherited_pgroup): New static var.
549 (init_foreground_group, tcsetpgrp_without_stopping)
550 (narrow_foreground_group, widen_foreground_group): New functions.
551 (init_sys_modes): Narrow foreground group.
552 (reset_sys_modes): Widen foreground group.
553
220cb2bd
MA
5542012-10-31 Michael Albinus <michael.albinus@gmx.de>
555
556 * dbusbind.c: Fix cut'n'waste error. Use HAVE_DBUS_VALIDATE_INTERFACE.
557
218e997a
MR
5582012-10-31 Martin Rudalics <rudalics@gmx.at>
559
560 * minibuf.c (read_minibuf): Restore current buffer since
561 choose_minibuf_frame calling Fset_frame_selected_window may
562 change it (Bug#12766).
563
02615da0
JD
5642012-10-30 Jan Djärv <jan.h.d@swipnet.se>
565
566 * frame.c (Fframe_pixel_height): Fix documentation (Bug#12733).
567
aee5b18e
KH
5682012-10-30 Kenichi Handa <handa@gnu.org>
569
570 * font.c (Ffont_at): If WINDOW is specified and it is not
571 displaying the current buffer, signal an error.
572
ba116008
DC
5732012-10-29 Daniel Colascione <dancol@dancol.org>
574
5c2a7148
SM
575 * cygw32.h, cygw32.c (Qutf_16le, from_unicode, to_unicode):
576 In preparation for fixing bug#12739, move these functions from
ba116008
DC
577 here...
578
579 * coding.h, coding.c: ... to here, and compile them only when
53372c27
DC
580 WINDOWSNT or CYGWIN. Moving these functions out of cygw32 proper
581 lets us write cygw32-agnostic code for the HAVE_NTGUI case.
ba116008 582
640bf8ad
EZ
5832012-10-28 Eli Zaretskii <eliz@gnu.org>
584
585 * w32proc.c (TIMER_TICKS_PER_SEC): New macro.
586 (timer_loop, getitimer, setitimer): Use it instead of
587 CLOCKS_PER_SEC, which is no longer pertinent, since we don't use
588 'clock'.
589 (w32_get_timer_time): Use 10*TIMER_TICKS_PER_SEC instead of a
590 literal 10000.
591
64ccff5f
JD
5922012-10-28 Jan Djärv <jan.h.d@swipnet.se>
593
594 * nsterm.m (NO_APPDEFINED_DATA): New define.
595 (last_appdefined_event_data): New variable
596 (last_appdefined_event): Remove.
597 (ns_select): Initialize t from last_appdefined_event_data instead
598 of [last_appdefined_event data1].
599 (sendEvent:): Save [theEvent data1] to last_appdefined_event_data,
600 remove last_appdefined_event (Bug#12698).
601
e483264c
SM
6022012-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * frame.c (x_set_font): Catch internal error.
605
6c16c13e
EZ
6062012-10-27 Eli Zaretskii <eliz@gnu.org>
607
e483264c
SM
608 Avoid overflow in w32 implementation of interval timers.
609 When possible, for ITIMER_PROF count only times the main thread
6c16c13e
EZ
610 actually executes.
611 * w32proc.c <struct itimer_data>: 'expire' and 'reload' are now
2e612797
EZ
612 'volatile ULONGLONG' types. All the other data which was
613 previously clock_t is now ULONGLONG. 'terminate' is 'volatile int'.
6c16c13e
EZ
614 (GetThreadTimes_Proc): New typedef.
615 (w32_get_timer_time): New function, returns a suitable time value
616 for the timer.
617 (timer_loop): Enter critical section when accessing ULONGLONG
618 values of the itimer_data struct, as these accesses are no longer
e483264c
SM
619 atomic. Call 'w32_get_timer_time' instead of 'clock'.
620 Remove unused variable.
6c16c13e
EZ
621 (init_timers): Initialize s_pfn_Get_Thread_Times.
622 (start_timer_thread): Don't assign itimer->caller_thread here.
623 (getitimer): Assign itimer->caller_thread here.
624 (setitimer): Always call getitimer to get the value of ticks_now.
2f246cd3 625 (sys_spawnve): Avoid compiler warning about format mismatch.
6c16c13e 626
ccc83f50
EZ
6272012-10-26 Eli Zaretskii <eliz@gnu.org>
628
629 * w32fns.c (w32_wnd_proc) <WM_MOUSEMOVE>: Don't enable tracking of
630 mouse movement events if the menu bar is active. This avoids
631 producing a busy "hour-glass" cursor by Windows if the mouse
632 pointer is positioned over a tooltip shown for some menu item.
633
69deda53
PE
6342012-10-25 Paul Eggert <eggert@cs.ucla.edu>
635
636 Don't assume process IDs fit in int.
637 * emacs.c (shut_down_emacs) [!DOS_NT]:
638 * sysdep.c (sys_suspend) [SIGTSTP && !MSDOS]:
639 * term.c (dissociate_if_controlling_tty) [!DOS_NT]:
640 Use pid_t, not int, to store process IDs, as 'int'
641 is not wide enough on a few platforms (e.g., AIX and IRIX).
642
7e70a152
KH
6432012-10-23 Kenichi Handa <handa@gnu.org>
644
645 The following change is to make face-font-rescale-alist work
646 correctly for non-ASCII fonts.
647
648 * font.c (font_open_entity): Don't handle Vface_font_rescale_alist.
649 (font_open_for_lface): Handle Vface_font_rescale_alist.
650
49238e7f
CY
6512012-10-23 Chong Yidong <cyd@gnu.org>
652
653 * xfaces.c (Vfont_list_limit): Move unused variable to faces.el.
654
5ec86886
JD
6552012-10-21 Jan Djärv <jan.h.d@swipnet.se>
656
ef446959
JD
657 * nsfont.m (nsfont_open, ns_glyph_metrics): Force integer advancement
658 for screen font.
659 (nsfont_draw): Turn off LCD-smoothing (Bug#11484).
660
5ec86886
JD
661 * xterm.c (x_focus_changed): Check if daemonp when sending focus in
662 event (Bug#12681).
663
ee7a418d
GM
6642012-10-21 Glenn Morris <rgm@gnu.org>
665
666 * lisp.mk (lisp): Add cp51932.el and eucjp-ms.el.
667
4973679b
PE
6682012-10-20 Paul Eggert <eggert@cs.ucla.edu>
669
670 Port to OpenBSD 5.1.
671 * frame.c (Fmouse_position, Fmouse_pixel_position):
672 * xdisp.c (produce_stretch_glyph):
673 Declare local vars only when they're needed.
674 This is clearer and avoids a warning on OpenBSD about unused vars.
675 * frame.h (FRAME_WINDOW_P): Always evaluate its argument.
676 This is safer, and avoids OpenBSD warnings about unused vars.
677 * keyboard.c (record_menu_key): Remove unnecessary decl.
678 (poll_timer): Define only if POLL_FOR_INPUT is defined.
679 * unexelf.c (ELFSIZE) [!ElfW]: Do not define if already defined,
680 as our definition clashes with OpenBSD's.
681 * xfaces.c (load_face_colors, check_lface_attrs)
682 (get_lface_attributes_no_remap, get_lface_attributes)
683 (lface_fully_specified_p, x_supports_face_attributes_p)
684 (tty_supports_face_attributes_p, face_fontset, realize_face)
685 (realize_x_face, realize_tty_face):
686 Declare parameters to be Lisp_Object[LFACE_VECTOR_SIZE], not
687 merely Lisp_Object *. This is more informative and avoids
688 a warning on OpenBSD about accessing beyond an object's size.
689
c664f463
CY
6902012-10-20 Chong Yidong <cyd@gnu.org>
691
692 * lread.c (Fload): Doc fix (Bug#12592).
693
6ec83f92 6942012-10-19 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
a0d7415f
KH
695
696 * font.c (Ffont_at): Fix previous change.
697
d2824928
EZ
6982012-10-19 Eli Zaretskii <eliz@gnu.org>
699
e483264c
SM
700 * puresize.h (BASE_PURESIZE): Bump the base value to 1700000.
701 See http://lists.gnu.org/archive/html/emacs-devel/2012-10/msg00593.html
c052c554
EZ
702 for the reasons.
703
d2824928
EZ
704 * alloc.c (NSTATICS): Decrease to 0x800.
705
f60d391f
SM
7062012-10-19 Stefan Monnier <monnier@iro.umontreal.ca>
707
708 * fns.c (Fnreverse): Include the problem element when signalling an
709 error (bug#12677).
710
1a9327d5
JD
7112012-10-18 Jan Djärv <jan.h.d@swipnet.se>
712
713 * nsterm.m (ns_select): Check writefds before call to
714 FD_ISSET (Bug#12668).
715
14145a1e
DC
7162012-10-18 Daniel Colascione <dancol@dancol.org>
717
718 * alloc.c (NSTATICS): Increase from 0x650 to 0x1000
719 (staticpro): If we run out of staticpro slots, die with an
720 informative error instead of just calling emacs_abort.
721
1f76f6f5
MR
7222012-10-18 Martin Rudalics <rudalics@gmx.at>
723
724 Fix two flaws reported by Dmitry Antipov.
725 * window.c (Ftemp_output_buffer_show): Remove.
726 (Fwindow_vscroll, Fset_window_vscroll): Use decode_live_window.
727 (syms_of_window): Remove defsubr for Stemp_output_buffer_show.
728
fcf14875
EZ
7292012-10-17 Eli Zaretskii <eliz@gnu.org>
730
1f76f6f5
MR
731 * makefile.w32-in ($(BLD)/w32.$(O)):
732 ($(BLD)/vm-limit.$(O)):
733 ($(BLD)/term.$(O)):
734 ($(BLD)/unexw32.$(O)):
735 ($(BLD)/fileio.$(O)):
a68089e4
EZ
736 ($(BLD)/dispnew.$(O)): Update dependencies.
737
738 * w32term.h (w32_initialize_display_info, initialize_w32_display):
739 Add prototypes.
740
741 * w32proc.c: Include ctype.h.
742
743 * w32.h (init_environment, check_windows_init_file)
744 (syms_of_ntproc, syms_of_ntterm, dostounix_filename)
745 (unixtodos_filename, init_winsock, srandom, random, sys_pipe)
746 (set_process_dir, sys_spawnve, register_child, sys_sleep, getwd)
747 (sys_link): Add prototypes.
748
749 * w32.c: Include w32select.h.
750 (sys_access, e_malloc, sys_select): Add prototypes.
751 (emacs_gnutls_pull): 'timeout' is now EMACS_TIME, not struct timeval.
752
753 * vm-limit.c [WINDOWSNT]: Include w32heap.h.
754
755 * unexw32.c: Include lisp.h and w32.h.
756
757 * term.c [WINDOWSNT]: Include w32term.h.
758
759 * process.c [WINDOWSNT]: Add prototype of sys_select.
760
761 * fileio.c [WINDOWSNT]: Include w32.h.
762
763 * dispnew.c [WINDOWSNT]: Include w32.h.
764
fcf14875
EZ
765 * cygw32.c (Fcygwin_convert_path_to_windows)
766 (Fcygwin_convert_path_from_windows): Use EQ to compare 2
767 Lisp_Object values. (Bug#12661)
768
769 * w32fns.c (w32_msg_pump): Use XIL instead of casting an integer
770 to Lisp_Object. (Bug#12661)
771
fe0b1ec4
KH
7722012-10-17 Kenichi Handa <handa@gnu.org>
773
774 * xdisp.c (reseat_1): Make the information stored in it->cmp_it
775 invalidate.
776
d556ebf9
DA
7772012-10-17 Dmitry Antipov <dmantipov@yandex.ru>
778
779 * buffer.c (Fkill_buffer): When unchaining the marker,
1f9f395d 780 reset its buffer pointer to NULL (Bug#12652).
d556ebf9 781
f0863a54
DA
7822012-10-17 Dmitry Antipov <dmantipov@yandex.ru>
783
784 Do not verify indirection counters of killed buffers (Bug#12579).
785 * buffer.h (BUFFER_CHECK_INDIRECTION): New macro.
786 * buffer.c (compact_buffer, set_buffer_internal_1): Use it.
787
12fbe755
DA
7882012-10-16 Dmitry Antipov <dmantipov@yandex.ru>
789
790 * alloc.c (Fmake_byte_code): Fix typo in comment.
791 * print.c (print_interval): Define as static to match prototype.
792 * indent.c (disptab_matches_widthtab, recompute_width_table):
793 Convert to eassert.
794
61655b89
DA
7952012-10-16 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * editfns.c (get_system_name): Remove.
798 * lisp.h (get_system_name): Remove prototype.
799 * xrdb.c (getenv, getpwuid, getpwnam): Remove prototypes.
800 (get_environ_db): Use Vsystem_name. Avoid call to strlen.
801
9520f2f2
DC
8022012-10-15 Daniel Colascione <dancol@dancol.org>
803
804 * dbusbind.c: Add comment explaining reason for previous change.
805
dca778d5
MR
8062012-10-15 Martin Rudalics <rudalics@gmx.at>
807
808 * window.c (Fwindow_end): Rewrite check whether cached position
809 can be used (Bug#12600).
810 (resize_frame_windows, grow_mini_window, shrink_mini_window):
811 Set windows_or_buffers_changed.
812
3e0341b0
DC
8132012-10-15 Daniel Colascione <dancol@dancol.org>
814
815 * dbusbind.c: Fix cygw32 build break when compiling with dbus
816 enabled by undefining the symbol "interface", which the platform
817 headers define to something incompatible.
818
33d4113c
DC
8192012-10-14 Daniel Colascione <dancol@dancol.org>
820
821 * image.c (init_tiff_functions, init_imagemagick_functions)
822 (init_svg_functions): Fix cygw32 build break by using these
823 functions only when WINDOWSNT _and_ HAVE_NTGUI.
824
a36fb15e
JD
8252012-10-14 Jan Djärv <jan.h.d@swipnet.se>
826
827 * nsterm.m (ns_select): Count fd:s in writefs also (Bug#12422).
828
537f336d
JD
8292012-10-13 Jan Djärv <jan.h.d@swipnet.se>
830
831 * gtkutil.c (xg_set_widget_bg): Divide by 65535 (Bug#12612).
832
0ba06a77
KH
8332012-10-13 HANATAKA, Shinya <bogytech@gmail.com> (tiny change)
834
835 * coding.c (detect_coding): Set coding->id before calling
836 this->detector.
837
ce2fe65a
AS
8382012-10-13 Andreas Schwab <schwab@linux-m68k.org>
839
840 * fileio.c: Formatting fixes.
841
d6453ce4
PE
8422012-10-13 Paul Eggert <eggert@cs.ucla.edu>
843
844 Fix some stat-related races.
845 * fileio.c (Fwrite_region): Avoid race condition if a file is
846 removed or renamed by some other process immediately after Emacs
847 writes it but before Emacs stats it. Do not assume that stat (or
848 fstat) succeeds.
849 * image.c (slurp_file): Resolve the file name with fopen + fstat
850 rather than stat + fopen.
851 (pbm_read_file) [0]: Remove unused code with stat race.
852 * process.c (allocate_pty) [HAVE_PTYS && !PTY_ITERATION && !PTY_OPEN]:
853 Remove ineffective code with stat race.
854
06485aa8
SM
8552012-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
856
857 * doc.c (get_doc_string): Don't signal an error if the file is missing.
858
167e3640
JD
8592012-10-12 Jan Djärv <jan.h.d@swipnet.se>
860
861 * nsterm.m (hold_event_q): New static variable.
862 (EV_TRAILER, sendScrollEventAtLoc:fromEvent:): Call hold_event if
863 ! q_event_ptr.
864 (hold_event): New function.
865 (ns_read_socket): If hold_event_q have events, store them and
866 return (Bug#12384).
867 (setPosition:portion:whole:): Send SIGIO to ourselves if apploopnr
868 is zero (Bug#12384).
869
c40239df
JB
8702012-10-12 Juanma Barranquero <lekktu@gmail.com>
871
872 * makefile.w32-in ($(BLD)/w32select.$(O)): Update dependencies.
873
bb385a92
EZ
8742012-10-12 Eli Zaretskii <eliz@gnu.org>
875
2a9f1099
EZ
876 * makefile.w32-in ($(BLD)/fileio.$(O)): Add sys/file.h.
877
bb385a92
EZ
878 * fileio.c (check_existing): New function.
879 (make_temp_name, Ffile_exists_p, Ffile_writable_p): Call it
880 instead of calling 'stat', when what's needed is to check whether
881 a file exists. This avoids expensive system calls on MS-Windows.
882 (Bug#12587)
883
8599b23a 884 * w32.c (init_environment): Call 'check_existing' instead of 'stat'.
bb385a92
EZ
885
886 * lread.c (openp) [WINDOWSNT]: Call 'access' instead of 'stat' to
887 determine whether a file exists and is not a directory.
888
889 * lisp.h (check_existing): Add prototype.
890
2b9c2e68
JD
8912012-10-12 Jan Djärv <jan.h.d@swipnet.se>
892
893 * nsfont.m (nsfont_open): Remove font cache, it is not GC correct.
894
81749a23
GM
8952012-10-12 Glenn Morris <rgm@gnu.org>
896
897 * buffer.c (Fset_buffer): Doc fix. (Bug#12624)
898
5253a5fd
SM
8992012-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
900
389a94a5
SM
901 * buffer.c (Fkill_buffer): Null out the overlay list(s) as well.
902
5253a5fd
SM
903 * eval.c (Fautoload): Remember previous autoload status in load-history.
904
7cded46f
PE
9052012-10-11 Paul Eggert <eggert@cs.ucla.edu>
906
907 lread.c, macros.c, marker.c, menu.c, minibuf.c: Use bool for booleans.
908 * lread.c (load_each_byte, new_backquote_flag, readchar)
909 (read_filtered_event, lisp_file_lexically_bound_p)
910 (safe_to_load_version, Fload, complete_filename_p, openp)
911 (build_load_history, readevalloop, read_escape, read1)
912 (string_to_number, read_vector, read_list):
913 * macros.c (Fstart_kbd_macro):
914 * marker.c (CONSIDER):
915 * menu.c (parse_single_submenu, digest_single_submenu)
916 (find_and_return_menu_selection, Fx_popup_menu):
917 * minibuf.c (read_minibuf_noninteractive, read_minibuf)
918 (Ftry_completion):
919 * nsmenu.m (ns_update_menubar, runMenuAt:forFrame:keymaps:):
920 (ns_menu_show):
921 * xmenu.c (set_frame_menubar, create_and_show_popup_menu)
922 (xmenu_show, xdialog_show):
923 Use bool for booleans.
924 * lread.c (safe_to_load_version): Rename from safe_to_load_p,
925 as it's not a predicate. All uses changed. Omit unnecessary
926 buffer termination.
927
549c3414
DA
9282012-10-11 Dmitry Antipov <dmantipov@yandex.ru>
929
930 * editfns.c (save_excursion_save): Use nil if mark points to nowhere.
931 (save_excursion_restore): Do not restore mark if it was not saved.
932
e85aafe7
PE
9332012-10-11 Paul Eggert <eggert@cs.ucla.edu>
934
fd2f90cf
PE
935 * marker.c (cached_modiff): EMACS_INT, not int.
936
c1af190b
PE
937 * w32select.c (waiting_for_input): Declare by including "keyboard.h"
938 instead of having a wrong decl.
e85aafe7
PE
939 * nsmenu.m (waiting_for_input): Remove wrong decl.
940
e738ca56
PE
9412012-10-10 Paul Eggert <eggert@cs.ucla.edu>
942
9fa1de30
PE
943 keyboard.c, keymap.c: Use bool for booleans.
944 * dispnew.c (sit_for): Distinguish between 3-way display_option
945 and boolean do_display.
946 * keyboard.c (single_kboard, this_command_key_count_reset)
947 (waiting_for_input, echoing, immediate_quit, input_pending)
948 (interrupt_input, interrupts_deferred, pop_kboard)
949 (temporarily_switch_to_single_kboard, ignore_mouse_drag_p)
950 (command_loop_1, adjust_point_for_property)
951 (safe_run_hooks_error, input_polling_used, read_char):
952 (help_char_p, readable_events, kbd_buffer_events_waiting)
953 (kbd_buffer_get_event, timer_check_2, make_lispy_event)
954 (lucid_event_type_list_p, get_input_pending):
955 (gobble_input, menu_separator_name_p, menu_bar_item)
956 (parse_menu_item, parse_tool_bar_item, read_char_x_menu_prompt)
957 (read_char_minibuf_menu_prompt, access_keymap_keyremap)
958 (keyremap_step, test_undefined, read_key_sequence)
959 (detect_input_pending, detect_input_pending_ignore_squeezables)
960 (detect_input_pending_run_timers, requeued_events_pending_p)
961 (quit_throw_to_read_char, Fset_input_interrupt_mode):
962 * keymap.c (get_keymap, keymap_parent, keymap_memberp)
963 (access_keymap_1, access_keymap, map_keymap, get_keyelt)
964 (Fdefine_key, Flookup_key, struct accessible_keymaps_data)
965 (accessible_keymaps_1, Fkey_description, push_key_description):
966 (shadow_lookup, struct where_is_internal_data)
967 (where_is_internal, Fwhere_is_internal, where_is_internal_1)
968 (Fdescribe_buffer_bindings, describe_map_tree, struct describe_map_elt)
969 (describe_map, describe_vector):
970 * menu.c (single_menu_item):
971 * nsmenu.m (ns_update_menubar):
972 * process.c (wait_reading_process_output):
973 * search.c (scan_buffer, scan_newline):
974 Use bool for boolean.
975 * keyboard.c (timers_run, swallow_events)
976 (detect_input_pending_run_timers):
977 * process.c (wait_reading_process_output):
978 Use unsigned for counter where wraparound-on-overflow is desired,
979 since unsigned is guaranteed to have that behavior and signed is not.
980 (read_char): Use ptrdiff_t for string length.
981 (get_input_pending): Remove first argument, since it was always
982 the same pointer-to-int (now pointer-to-boolean) &input_pending,
983 and behave as if it had that value. Return new value of
984 input_pending. All callers changed.
985 * keyboard.h (struct kboard): Use unsigned : 1 for boolean member
986 immediate_echo. Use ptrdiff_t for echo_after_prompt, since it's
987 a string length.
988 * keymap.c (push_key_description): Omit last arg, which was always 1.
989 All callers changed.
990
e738ca56
PE
991 * regex.c (immediate_quit) [emacs]: Remove duplicate decl.
992
29f21cdf
JB
9932012-10-10 Juanma Barranquero <lekktu@gmail.com>
994
995 * makefile.w32-in ($(BLD)/dispnew.$(O), $(BLD)/indent.$(O))
996 ($(BLD)/term.$(O)): Update dependencies.
997
6aea7528
DA
9982012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * alloc.c (mark_object): Use meaningful PVEC_NORMAL_VECTOR.
1001 * lisp.h (enum pvec_type): Adjust comments and omit explicit
1002 initializer for PVEC_NORMAL_VECTOR.
1003
5f3f57be
PE
10042012-10-10 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 Clean out old termopts cruft.
1007 * termopts.h (flow_control, meta_key): Remove unused decls.
1008 * dispnew.c, indent.c, nsterm.m, term.c, xsettings.c, xsmfns.c:
1009 Don't include termopts.h.
1010
3e98c68e
DA
10112012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
1012
1013 * alloc.c (gc_sweep): Use pointer-to-a-pointer loop for buffers.
1014
77e344e5
PE
10152012-10-10 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * commands.h (immediate_quit): Remove duplicate decl.
1018
5683d7cd
JD
10192012-10-09 Jan Djärv <jan.h.d@swipnet.se>
1020
1021 * nsfont.m (Vfonts_in_cache): Remove, not needed as font.c handles
1022 caching.
1023 (nsfont_open): Remove setting of Vfonts_in_cache.
1f9f395d 1024 (syms_of_nsfont): Remove initialization of Vfonts_in_cache.
5683d7cd 1025
cf5fc6db
EZ
10262012-10-09 Eli Zaretskii <eliz@gnu.org>
1027
b15736e6
EZ
1028 * w32fns.c (w32_last_error): Change the return value to DWORD, to
1029 match what GetLastError returns. Explain why the function is
1030 needed.
1031
cf5fc6db
EZ
1032 * frame.c (delete_frame): Rename local variable 'tooltip_frame' to
1033 'is_tooltip_frame', to avoid confusion with its global namesake.
1034
f99714ce
DC
10352012-10-08 Daniel Colascione <dancol@dancol.org>
1036
1037 * xdisp.c (start_hourglass): Call w32_note_current_window when
2b1f11ed
EZ
1038 HAVE_NTGUI, not just WINDOWSNT, resolving a problem in the cygw32
1039 build that caused Emacs to display the hourglass cursor forever.
f99714ce 1040
fd59cb29
GM
1041 * w32fns.c (Fx_display_color_cells): Instead of using NCOLORS,
1042 which is broken under remote desktop, calculate the number of
1043 colors available for a display based on the display's number of
1044 planes and number of bits per pixel per plane. (bug#10397).
1045
62c480c9 10462012-10-08 Jan Djärv <jan.h.d@swipnet.se>
fd59cb29 1047
62c480c9
JD
1048 * nsfont.m (Vfonts_in_cache): New variable.
1049 (nsfont_open): Use unsignedLongLongValue for cache in case wide ints
1050 are used. Add cached fonts to Vfonts_in_cache.
1051 (syms_of_nsfont): Initialize and staticpro Vfonts_in_cache.
1052
607446ba
JB
10532012-10-08 Juanma Barranquero <lekktu@gmail.com>
1054
fd5125ad
JB
1055 * makefile.w32-in (LOCAL_FLAGS): Don't define HAVE_NTGUI, it's now
1056 in nt/config.nt.
46979e0b
JB
1057 (FONT_H): Define after FRAME_H.
1058 ($(BLD)/emacs.$(O), $(BLD)/process.$(O), $(BLD)/w32heap.$(O)):
1059 Update dependencies.
fd5125ad 1060
607446ba
JB
1061 * w32term.c: Remove leftover declaration of keyboard_codepage.
1062
b6f4e300
EZ
10632012-10-08 Eli Zaretskii <eliz@gnu.org>
1064
c54ebba4
EZ
1065 * makefile.w32-in (FONT_H): Add $(FRAME_H).
1066 (W32TERM_H): Add $(ATIMER_H) and $(FRAME_H).
1067 ($(BLD)/emacs.$(O), $(BLD)/w32console.$(O)): Update dependencies.
1068 (GLOBAL_SOURCES): Add cygw32.c.
fd59cb29
GM
1069 ($(BLD)/unexw32.$(O)):
1070 ($(BLD)/w32.$(O)):
1071 ($(BLD)/w32console.$(O)):
1072 ($(BLD)/w32fns.$(O)):
1073 ($(BLD)/w32heap.$(O)):
1074 ($(BLD)/w32menu.$(O)):
15c720a3 1075 ($(BLD)/w32proc.$(O)): Add w32common.h.
c54ebba4 1076
b6f4e300
EZ
1077 * w32fns.c (w32_color_map_lookup, x_to_w32_color): Argument is now
1078 'const char *'.
1079 (x_to_w32_color): Don't modify the argument, modify a copy instead.
1080
501199a3
DC
10812012-10-08 Daniel Colascione <dancol@dancol.org>
1082
1083 * w32term.h (WM_EMACS_BRINGTOTOP, WM_EMACS_INPUT_READY)
1084 (WM_EMACS_END): Change WM_EMACS_BRINGTOTOP from 22 to 21 to close
1085 accidental message numbering hole. Change other messages to
1086 match.
1087
1088 * w32select.h (HAVE_W32SELECT): Remove.
1089
1090 * w32select.c, w32proc.c, w32menu.c, w32console.c, w32.c: Include
1f9f395d 1091 w32common.h instead of w32heap.h.
501199a3
DC
1092
1093 * w32heap.h (ROUND_UP, ROUND_DOWN, get_page_size)
1094 (get_allocation_unit, get_processor_type, get_w32_major_version)
1095 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
1096 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
1097 (OS_NT, os_subtype, cache_system_info): Move declarations to
1098 w32common.
1099
1100 * w32heap.c: Include w32common.h.
1101 (sysinfo_cache, syspage_mask, osinfo_cache, w32_major_version)
8599b23a
SM
1102 (w32_minor_version, w32_build_number, w32_subtype):
1103 Remove duplicate definitions.
501199a3
DC
1104
1105 * w32fns.c: Include w32common.h; include w32heap.h only in
1106 WINDOWSNT.
1107
1108 (Fx_file_dialog): Clarify comment on GetOpenFileName structure.
1109 Use `report_file_error' instead of `error' in order to better
1110 inform users of what went wrong. Increase NTGUI_UNICODE file
1111 dialog box file name length to 32k, the maximum allowed by the NT
1112 kernel.
1113
1114 * w32common.h: New file.
1115 (ROUND_UP, ROUND_DOWN, get_page_size)
1116 (get_allocation_unit, get_processor_type, get_w32_major_version)
1117 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
1118 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
1119 (OS_NT, os_subtype, cache_system_info): Move here.
1120
1121 * unexw32.c, unexcw.c: Include w32common.h.
1122
1123 * emacs.c (main): Use (defined (WINDOWSNT) || defined
1124 HAVE_NTGUI) instead of removed HAVE_W32SELECT to decide whether
1125 to call syms_of_w32select.
1126
1127 * cygw32.h: Remove obsolete EXFUN declarations.
1128
1129 * cygw32.c (Qutf_16_le): Rename to Qutf_16le.
1130
1131 * Makefile.in (SOME_MACHINE_OBJECTS): Reverse accidental removal
1132 of w32inevt.o from SOME_MACHINE_OBJECTS.
1133
93aa5c81
DC
11342012-10-08 Daniel Colascione <dancol@dancol.org>
1135
1136 * image.c: Permanent fix for JPEG compilation issue --- limit
1137 jpeglib `boolean' redefinition to Cygwin builds.
1138
d424f3d8
EZ
11392012-10-08 Eli Zaretskii <eliz@gnu.org>
1140
8ee4c6ce
EZ
1141 * image.c (CHECK_LIB_AVAILABLE): Remove, no longer used.
1142
d424f3d8
EZ
1143 * emacs.c (DAEMON_MUST_EXEC) [HAVE_NTGUI]: Define this only on
1144 Cygwin.
1145
e08348a0
DC
11462012-10-08 Daniel Colascione <dancol@dancol.org>
1147
1148 * xfaces.c, xdisp.c, window.c, w32xfns.c, w32term.h, w32term.c,
1149 w32select.h w32select.c, w32proc.c, w32menu.c, w32inevt.c,
1150 w32help.c, w32font.c, w32font.c, w32fns.c, w32console.c, w32.h,
1151 w32.c, unexw32.c, termhooks.h, process.c, menu.c, keyboard.h,
1152 keyboard.c, image.c, frame.h, frame.c, fontset.c, font.h, font.c,
1153 emacs.c, dispextern.h, cygw32.h, cygw32.c, conf_post.h,
1154 Makefile.in: use HAVE_NTGUI for W32 GUI and WINDOWSNT for the
1155 operating system. defined(HAVE_NTGUI) && !defined(WINDOWSNT) is
1156 now a supported configuration.
1157
1158 * Makefile.in: consolidate image variables into LIBIMAGE; add
1159 W32_OBJ and W32_LIBS. Compile new files.
1160
1161 * conf_post.h:
1162 (_DebPrint) declare tracing facility for W32 debugging. We need
1163 to unify tracing later.
1164
1165 (NTGUI_UNICODE) Define when compiling for Cygwin to allow the
1166 unconditional use of W32 Unicode functions. Cygwin runs only on
1167 100% Unicode operating systems.
1168
1169 * cygw32.c: New file. Define Cygwin-specific facilities.
1170 (Fcygwin_convert_path_to_windows)
1171 (Fcygwin_convert_path_from_windows): New user functions for
1172 accessing Cygwin path-munging routines.
1173
1174 * cygw32.h: New file.
1175 (WCSDATA, to_unicode, from_unicode): Define facilities for storing
1176 UTF-16LE strings temporarily inside non-Lisp-visible string
1177 objects.
1178
1179 (w32_strerror): Just what it says on the tin.
1180
1181 * emacs.c: Make the NS fork-then-exec code for daemon-launching
1182 also run for Cygwin; both systems have the same problem with using
1183 GUI facilities in a forked child. Also call syms_of_cygw32,
1184 syms_of_w32select in correct places.
1185
1186 (DAEMON_MUST_EXEC): new macro defined to signal that a platform
1187 needs fork-then-exec for daemon launching.
1188
1189 * font.h: Include frame.h.
1190
1191 * image.c: Use the image library cache machinery only when we're
1192 compiling for native WINDOWSNT; Cygwin can use shared libraries
1193 like any other Unixlike system.
1194
1195 * keyboard.c: Clarify a comment regarding the input loop.
1196
1197 * menu.c: When NTGUI_UNICODE is defined, use Unicode menu
1198 functions directly instead of trying to detect at runtime that our
1199 host operating system supports them. We make this change for two
1200 reasons: Cygwin lacks support for the multibyte character
1201 conversion functions used by the legacy menu code, and Cygwin
1202 never needs to rely on non-Unicode APIs.
1203
1204 * unexw32.c (hinst): Declare extern.
1205
1206 * w32.c: Change header order;
1207 (w32_strerror): Move to w32fns.c because we need it for
1208 non-WINDOWSNT builds.
1209
1210 * w32.h: Add #error macro to make sure we don't include w32.h for
1211 Cygwin builds. Remove w32select declarations.
1212
1213 * w32console.c (w32_sys_ring_bell, Fset_message_beep): Move to
1f9f395d 1214 w32fns.c. w32console.c is WINDOWSNT-only.
e08348a0
DC
1215
1216 * w32fns.c: Include cygw32.h or w32.h depending on CYGWIN; more
1217 NTGUI_UNICODE tweaks. (See above.) Change _snprintf to the more
1218 POSIXy alternative.
1219 (faked_key, sysinfo_cache, osinfo_cahce, syspage_mask)
1220 (w32_major_version, w32_minor_version, w32_build_number)
1221 (os_subtype, sound_type): Define here
1222 (w32_defined_color): Make color parameter const for consistency
1223 with other _defined_color functions.
1224 (w32_createwindow): Unconditionally call w32_init_class instead of
1225 doing so only when hprevinst is non-NULL. Plumbing hprevinst
1226 through the code is complex and unnecessary because class
1227 registration is practically free.
1228 (w32_name_of_message): New EMACSDEBUG-only function.
1229 (Fset_message_beep): Move here
1230 (Fx_open_connection): Require that the display name for Windows be
1231 "w32" for consistency, emacsclient disambiguation, and maybe, one
1232 day, multi-window-system support.
1233 (file_dialog_callback): NTGUI_UNICODE changes; encode and decode
1234 Cygwin files for W32 GUI facilities, since these clearly don't
1235 expect Cygwin names.
1236 (_DebPrint): Define.
1237 (w32_strerror, w32_console_toggle_lock_key, w32_kbd_mods_to_emacs)
1238 (w32_kbd_patch_key, w32_sys_ring_bell): Move here.
1239 (Ssystem_move_file_to_trash): Define only for native WINDOWSNT.
1240 (w32_last_error): Remove.
1241
1242 * w32font.c: Define _strlwr to strlwr for non-WINDOWSNT builds.
1243
1244 * w32heap.c (syspage_mask): Declare here.
1245 (cache_system_info): Remove.
1246
1247 * w32inevt.c (faked_key): Define globally, not statically.
1248 (w32_kbd_mods_to_emacs, w32_kbd_patch_key, faked_key)
1249 (w32_console_toggle_lock_key): Move to w32fns.c.
1250
1251 * w32menu.c: Include setjmp.h. NTGUI_UNICODE changes throughout.
1252
1253 * w32proc.c (_DebPrint): Move to w32fns.c.
1254 * w32select.c: Include string.h, stdio.h for Cygwin.
1255 * w32select.h: New File.
1256
1257 * w32term.c: Include io.h for non-CYGWIN builds; needed for
1258 get_osfhandle.
1259 (w32_message_fd): New variable. Under Cygwin, holds the file
1260 descriptor the system used to tell us about pending thread
1261 messages.
1262
1263 (w32_init_term): Remove incorrect calls to fcntl and init_sigio
1264 that prevented compilation under non-WINDOWSNT systems.
1265
1266 (w32_initialize): Open /dev/windows and assign it to
1267 w32_message_fd. Provide w32 feature.
1268
1269 * w32term.h: Include frame.h, atimer.h. Declare various frame functions.
1270 (WM_EMACS_INPUT_READY): add.
1271 (prepend_msg, w32_message_fd): Declare globally.
1272
1273 * w32xfns.c:
1274 (keyboard_handle): Use only when WINDOWSNT.
1275 (notify_msg_ready): New function. Posts a message to the main
1276 thread's message queue under CYGWIN, which wakes up the main
1277 thread from select(2) by making the /dev/windows file descriptor
1278 ready. Under WINDOWSNT, it sets an event the same way the old
1279 code did.
1280
1281 (post, prepend_msg): Actually call notify_msg_ready instead of
1282 setting the input event directly.
1283
98daa893
EZ
12842012-10-07 Eli Zaretskii <eliz@gnu.org>
1285
1286 * ralloc.c (relinquish): If a heap is ready to be relinquished,
1287 but it still has blocs in it, don't return it to the system,
1288 instead of aborting. (Bug#12402)
1289
3bc0a2f7
JD
12902012-10-07 Jan Djärv <jan.h.d@swipnet.se>
1291
8ad5b73b 1292 * nsterm.m (ns_dumpglyphs_image): Only draw slice of image (Bug#12506).
493b5b1c 1293
335f5ae4
JD
1294 * nsterm.m (ns_update_auto_hide_menu_bar): Remove defintion of
1295 MAC_OS_X_VERSION_10_6.
8ad5b73b
JD
1296 (syms_of_nsterm): Remove comment about Panther and above for
1297 ns-antialias-text.
335f5ae4
JD
1298 * nsterm.h (MAC_OS_X_VERSION_10_3, onTiger): Remove.
1299 (EmacsApp): Remove check for >= MAC_OS_X_VERSION_10_4.
1300 (struct nsfont_info): Remove check for >= MAC_OS_X_VERSION_10_3.
1301
1302 * nsselect.m (ns_string_from_pasteboard): Remove check for >=
1303 MAC_OS_X_VERSION_10_4.
1304
8ad5b73b
JD
1305 * nsmenu.m (fillWithWidgetValue:): Remove code for <
1306 MAC_OS_X_VERSION_10_2.
335f5ae4
JD
1307
1308 * nsimage.m (setPixmapData, getPixelAtX, setAlphaAtX): Remove onTiger.
1309
1310 * nsfns.m (Fns_list_services): Remove comment and check for OSX < 10.4.
1311 (ns_do_applescript): Remove check for >= MAC_OS_X_VERSION_10_4.
1312
3bc0a2f7
JD
1313 * nsterm.m (ns_in_resize): Remove (Bug#12479).
1314 (ns_resize_handle_rect, mouseDown, mouseUp, mouseDragged): Remove.
8599b23a
SM
1315 (ns_clear_frame, sendEvent, windowDidResize, drawRect:):
1316 Remove ns_in_resize check.
3bc0a2f7
JD
1317 (ns_clear_frame_area): Remove resize handle code.
1318
1319 * nsfns.m (ns_in_resize): Remove.
e483264c
SM
1320 (x_set_icon_name, ns_set_name, ns_set_name_as_filename):
1321 Remove ns_in_resize check.
3bc0a2f7 1322
c622b48f
PE
13232012-10-07 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Improve sys_siglist detection.
1326 * sysdep.c (sys_siglist, init_signals): Use _sys_siglist if it's
1327 defined as a macro, as is done in Solaris.
1328 (sys_siglist_entries): New macro.
1329 (save_strsignal): Use it.
1330 * syssignal.h (safe_strsignal): Now ATTRIBUTE_CONST, to pacify
1331 GCC 4.7.2 on Fedora 17 with the fixed sys_siglist detection.
1332
04fafa46
JD
13332012-10-06 Jan Djärv <jan.h.d@swipnet.se>
1334
1335 * nsfns.m (Fx_create_frame): Call x_default_parameter with
1336 fullscreen/Fullscreen.
1337
1338 * nsterm.h (EmacsView): Rename tbar_height to tibar_height.
1339 tobar_height is new.
1340
1341 * nsterm.m (x_make_frame_visible): Check for fullscreen.
1342 (ns_fullscreen_hook): Activate old style fullscreen with a timer.
1343 (ns_term_init): Set activateIgnoringOtherApps if old style fullscreen.
1344 (windowDidResize:): Check for correct window if old style fullscreen.
1345 Capitalize word in comment. Remove incorrect comment.
1346 (initFrameFromEmacs:): tbar_height renamed tibar_height.
1347 (windowDidEnterFullScreen:): Toggle toolbar for fullscreen to fix
1348 error in drawing background.
1f9f395d 1349 (toggleFullScreen:): Remove comment. Rearrange calls.
04fafa46
JD
1350 Set toolbar values to zero, save old height in tobar_height.
1351 Restore tool bar height when leaving fullscreen.
1352 (canBecomeMainWindow): New function.
1353
c6e21c03
PE
13542012-10-06 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
1357
0d9f584b
EZ
13582012-10-05 Eli Zaretskii <eliz@gnu.org>
1359
a65fbb5f
EZ
1360 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
1361
0d9f584b 1362 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
8599b23a
SM
1363 that time stamps of directories could also be changed.
1364 Don't request the too broad GENERIC_WRITE, only the more restrictive
0d9f584b
EZ
1365 FILE_WRITE_ATTRIBUTES access rights.
1366
1367 * fileio.c (Fset_file_times): Special-case ignoring errors for
1368 directories only on MSDOS, not on MS-Windows.
1369
e8757f09 13702012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
1371
1372 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
1373
7604f298
EZ
13742012-10-04 Eli Zaretskii <eliz@gnu.org>
1375
1376 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
1377 see whether CreateFile failed.
1378
88d69b7d
PE
13792012-10-04 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
1382 to avoid similar races.
1383 * keyboard.c (pending_signals): Now bool, not int.
1384
7509f454
PE
1385 Port timers to OpenBSD, plus check for timer failures.
1386 OpenBSD problem reported by Han Boetes.
1387 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
1388 and/or setitimer.
1389 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
1390 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
1391 like OpenBSD, which has timer_settime but does not declare it.
1392 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
1393 whether to use itimerspec-related primitives. All uses of
1394 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
1395
a3c5c0c5
PE
13962012-10-02 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 * profiler.c (handle_profiler_signal): Fix a malloc race
1399 that caused Emacs to hang on Fedora 17 when profiling Lisp.
1400
914e743b
JD
14012012-10-02 Jan Djärv <jan.h.d@swipnet.se>
1402
1403 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
1404
d8ab37a8
EZ
14052012-10-02 Eli Zaretskii <eliz@gnu.org>
1406
1407 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
1408 consistent with the change in return value of 'safe_strsignal'.
1409
b3ecad33
PE
14102012-10-02 Paul Eggert <eggert@cs.ucla.edu>
1411
0a99eee1
PE
1412 Prefer plain 'static' to 'static inline' (Bug#12541).
1413 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
1414 (bidi_set_sor_type, bidi_push_embedding_level)
1415 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
1416 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
1417 (bidi_cache_search, bidi_cache_ensure_space)
1418 (bidi_cache_iterator_state, bidi_cache_find)
1419 (bidi_peek_at_next_level, bidi_set_paragraph_end)
1420 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1421 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
1422 Now 'static', not 'static inline'.
1423
b3ecad33
PE
1424 Count overruns when profiling; change units to ns.
1425 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
1426 Give extra weight to samples after overruns, to attempt to count
1427 the time more accurately.
1428 (setup_cpu_timer): Change sampling interval units from ms to ns, since
1429 the underlying primitives nominally do ns.
1430 (Fprofiler_cpu_start): Document the change. Mention that
1431 the sampling intervals are only approximate.
1432
090cf9db
SM
14332012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1434
1435 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
1436
1437 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
1438 case for the special 0 coding-system.
1439
1440 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
1441 (Fmake_overlay): Remove redundant tests.
64edc777 1442 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 1443
81550bf4
JB
14442012-10-02 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
1447 Update dependencies.
1448
aa1ba90e
PE
14492012-10-01 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 Fix a malloc race condition involving strsignal.
1452 A signal can arrive in the middle of a malloc, and Emacs's signal
1453 handler can invoke strsignal, which can invoke malloc, which is
1454 not portable. This race condition bug makes Emacs hang on GNU/Linux.
1455 Fix it by altering the signal handler so that it does not invoke
1456 strsignal.
1457 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
1458 * process.c (status_message): Use const pointer, in case strsignal
1459 is #defined to safe_strsignal.
1460 * sysdep.c (sys_siglist, init_signals): Always define and
1461 initialize a substitute sys_siglist if the system does not define
1462 one, even if HAVE_STRSIGNAL.
1463 (safe_strsignal): Rename from strsignal. Always define,
1464 using sys_siglist. Return a const pointer.
1465 * syssignal.h (safe_strsignal): New decl.
1466 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
1467
ace917bd
EZ
14682012-10-01 Eli Zaretskii <eliz@gnu.org>
1469
1470 * w32proc.c (timer_loop): Fix code that waits for timer
1471 expiration, to avoid high CPU usage.
1472
9eb71b9c
SM
14732012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
1474
1475 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
1476 (sweep_weak_table): Remove redundant prototypes.
1477
b3317662
FP
14782012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
1479
1480 * emacs.c: Move the inclusion of TERM_HEADER after including
1481 windows.h on WINDOWSNT. This avoids compilation problems with
1482 MSVC.
1483
f0e5f225
EZ
14842012-10-01 Eli Zaretskii <eliz@gnu.org>
1485
2d7d1608
EZ
1486 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
1487 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
1488 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
1489 as the previous version used 'void *'.
1490
1491 * ralloc.c (ROUNDUP): Fix last change.
1492 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
1493 'size_t'.
1494
f0e5f225
EZ
1495 * w32proc.c <disable_itimers>: New static flag.
1496 (init_timers): Initialize it to zero, after creating the critical
1497 sections used by the timer threads.
1498 (term_timers): Set to 1 before deleting the critical sections.
1499 (getitimer, setitimer): If disable_itimers is non-zero, return an
1500 error indication without doing anything. Reported by Fabrice
1501 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
1502 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
1503 return results.
1504 [!HAVE_SETITIMER]: Behave as the previous version that didn't
1505 support timers.
f0e5f225
EZ
1506
1507 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
1508 term_ntproc after all the other bookkeeping, to get timers working
1509 as long as possible.
1510
82ef37c1
PE
15112012-10-01 Paul Eggert <eggert@cs.ucla.edu>
1512
b3a4c387
PE
1513 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
1514 Suggested by Juri Linkov in
1515 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
1516
b0ab8123
PE
1517 Prefer plain 'static' to 'static inline' (Bug#12541).
1518 With static functions, modern compilers inline pretty well by
1519 themselves; advice from programmers often hurts as much as it helps.
1520 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
1521 this change shrinks the text size of the Emacs executable by 1.1%
1522 without affecting CPU significantly in my benchmark.
1523 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
1524 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
1525 (mark_maybe_object, mark_maybe_pointer, bounded_number):
1526 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1527 (bset_auto_fill_function, bset_auto_save_file_format)
1528 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1529 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1530 (bset_cache_long_line_scans, bset_case_fold_search)
1531 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
1532 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
1533 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
1534 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
1535 (bset_header_line_format, bset_indicate_buffer_boundaries)
1536 (bset_indicate_empty_lines, bset_invisibility_spec)
1537 (bset_left_fringe_width, bset_major_mode, bset_mark)
1538 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
1539 (bset_name, bset_overwrite_mode, bset_pt_marker)
1540 (bset_right_fringe_width, bset_save_length)
1541 (bset_scroll_bar_width, bset_scroll_down_aggressively)
1542 (bset_scroll_up_aggressively, bset_selective_display)
1543 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
1544 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
1545 (set_buffer_overlays_after):
1546 * category.c (bset_category_table):
1547 * charset.c (read_hex):
1548 * coding.c (produce_composition, produce_charset)
1549 (handle_composition_annotation, handle_charset_annotation)
1550 (char_encodable_p):
1551 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
1552 (assign_row, set_frame_matrix_frame, make_current)
1553 (add_row_entry):
1554 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
1555 * fns.c (maybe_resize_hash_table):
1556 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
1557 * gmalloc.c (register_heapinfo):
1558 * image.c (lookup_image_type):
1559 * intervals.c (set_interval_object, set_interval_left)
1560 (set_interval_right, copy_interval_parent, rotate_right)
1561 (rotate_left, balance_possible_root_interval):
1562 * keyboard.c (kset_echo_string, kset_kbd_queue)
1563 (kset_keyboard_translate_table, kset_last_prefix_arg)
1564 (kset_last_repeatable_command, kset_local_function_key_map)
1565 (kset_overriding_terminal_local_map, kset_real_last_command)
1566 (kset_system_key_syms, clear_event, set_prop):
1567 * lread.c (digit_to_number):
1568 * marker.c (attach_marker, live_buffer, set_marker_internal):
1569 * nsterm.m (ns_compute_glyph_string_overhangs):
1570 * process.c (pset_buffer, pset_command)
1571 (pset_decode_coding_system, pset_decoding_buf)
1572 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
1573 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
1574 (pset_status, pset_tty_name, pset_type, pset_write_queue):
1575 * syntax.c (bset_syntax_table, dec_bytepos):
1576 * terminal.c (tset_param_alist):
1577 * textprop.c (interval_has_some_properties)
1578 (interval_has_some_properties_list):
1579 * window.c (wset_combination_limit, wset_dedicated)
1580 (wset_display_table, wset_hchild, wset_left_fringe_width)
1581 (wset_left_margin_cols, wset_new_normal, wset_new_total)
1582 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
1583 (wset_right_fringe_width, wset_right_margin_cols)
1584 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
1585 (wset_vertical_scroll_bar_type, wset_window_parameters):
1586 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1587 (wset_column_number_displayed, wset_region_showing)
1588 (window_box_edges, run_window_scroll_functions)
1589 (append_glyph_string_lists, prepend_glyph_string_lists)
1590 (append_glyph_string, set_glyph_string_background_width)
1591 (append_glyph, append_composite_glyph)
1592 (take_vertical_position_into_account):
1593 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
1594 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
1595 (lface_hash, lface_same_font_attributes_p, lookup_face):
1596 * xml.c (libxml2_loaded_p):
1597 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
1598 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
1599 Now 'static', not 'static inline'.
1600
05584c31
PE
1601 * bidi.c: Tune.
1602 (bidi_copy_it): Do the whole copy with a single memcpy.
1603 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
1604
86ec63ba
PE
1605 Revert the FOLLOW-SYMLINKS change for file-attributes.
1606 Doing it right would require several changes to Tramp, and there's
1607 not enough time to get that tested before the freeze today.
1608 * dired.c (directory_files_internal, Ffile_attributes):
1609 Undo last change.
1610
82ef37c1
PE
1611 * frame.c (x_report_frame_params): Port better to wider ints.
1612 Do not assume that EMACS_UINT is the same width as uprintmax_t,
1613 or that pointers can be printed in 15 decimal digits.
1614 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
1615
62aba0d4
FP
16162012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
1617
1618 Support x64 build on MS-Windows.
1619 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
1620 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
1621 compatibility with x64.
5e4daaf3 1622 (x_get_focus_frame): Add prototype.
62aba0d4
FP
1623
1624 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
1625 defining an XRectangle structure.
1626
1627 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
1628 arithmetics for compatibility with x64.
1629
1630 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
1631 compatibility with x64.
1632
1633 * w32heap.h: Adjust prototypes and declarations.
1634
1635 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
1636 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
1637 DWORD, long, and unsigned long, for compatibility with x64.
1638 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
1639 (sbrk): Argument is now of type ptrdiff_t.
1640
1641 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
1642 less than 0x0500.
1643 (w32_msg_pump): Use WPARAM type for 'result'.
1644
1645 * w32.c (init_environment, get_emacs_configuration): Support AMD64
1646 architecture.
1647 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
1648 compatibility with x64.
1649
1650 * vm-limit.c (lim_data): Now size_t.
1651 (check_memory_limits): Adjust prototypes of real_morecore and
1652 __morecore to receive argument of type ptrdiff_t. Use size_t for
1653 five_percent and data_size.
1654
1655 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
1656 variables, for compatibility with x64.
1657 (rva_to_section, offset_to_section, relocate_offset)
1658 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
1659 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
1660 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
1661 for compatibility with x64.
1662
1663 * sysdep.c (STDERR_FILENO): Define if not already defined.
1664
1665 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
1666 (__morecore): Argument type is now ptrdiff_t.
1667 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
1668 (relinquish): Use ptrdiff_t type for 'excess'.
1669 (r_alloc_sbrk): Argument type is now ptrdiff_t.
1670
1671 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
1672 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
1673 instead of a literal number.
1674
1675 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
1676 (min): Define only if not already defined.
1677
1678 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
1679 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
1680 hosts.
1681
1682 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
1683 'bitmaps' is a pointer.
1684
1685 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
1686
1687 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
1688
e7a2937b
PE
16892012-09-30 Paul Eggert <eggert@cs.ucla.edu>
1690
1691 file-attributes has a new optional arg FOLLOW-SYMLINKS.
1692 * dired.c (directory_files_internal, Ffile_attributes):
1693 New arg follow_symlinks. All uses changed.
1694
b43d62ae
SM
16952012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
1696
1697 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
1698
c06c382a
EZ
16992012-09-30 Eli Zaretskii <eliz@gnu.org>
1700
1701 Support atimers and CPU profiler via profile.c on MS-Windows.
1702 * w32proc.c (sig_mask, crit_sig): New static variables.
1703 (sys_signal): Support SIGALRM and SIGPROF.
1704 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 1705 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
1706 sigfillset, and sigprocmask are no longer no-ops.
1707 (sigismember): New function.
1708 (struct itimer_data): New definition.
1709 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
1710 (crit_prof): New static variables.
1711 (MAX_SINGLE_SLEEP): New definition.
1712 (timer_loop, stop_timer_thread, term_timers, init_timers)
1713 (start_timer_thread, getitimer, setitimer): New functions.
1714 (alarm): No longer a no-op, calls setitimer.
1715
1716 * w32.c (term_ntproc): Call term_timers.
1717 (init_ntproc): Make sure all signals are unblocked at startup, to
1718 erase any traces of dumping. Call init_timers.
1719
1720 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
1721 Windows-specific code to display the hourglass mouse pointer is no
1722 longer used.
1723 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
1724 to hourglass timer expiration.
1725 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
1726 Remove, no longer used.
b43d62ae
SM
1727 (w32_note_current_window, show_hourglass, hide_hourglass):
1728 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
1729 window systems.
1730 (syms_of_w32fns): Don't initialize hourglass_timer.
1731
1732 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
1733 WINDOWSNT as well.
1734 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
1735
1736 * w32.h (init_timers, term_timers): Add prototypes.
1737
95402d5f
KH
17382012-09-30 Kenichi Handa <handa@gnu.org>
1739
1740 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
1741 to the buffer relocation which may be caused by ccl_driver.
1742
dd946752
JD
17432012-09-30 Jan Djärv <jan.h.d@swipnet.se>
1744
d7e642cc
JD
1745 * xfns.c (Fx_file_dialog): Update comment.
1746
1747 * w32fns.c (Fx_file_dialog): Update comment.
1748
1749 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
1750 Initialize panel name field if OSX >= 10.6.
1751
1752 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
1753
dd946752
JD
1754 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
1755
1756 * nsterm.m (NEW_STYLE_FS): New define.
1757 (ns_fullscreen_hook, windowWillEnterFullScreen)
1758 (windowDidEnterFullScreen, windowWillExitFullScreen)
1759 (windowDidExitFullScreen, toggleFullScreen, handleFS)
1760 (setFSValue): New functions.
1761 (EmacsFSWindow): New implementation.
1762 (canBecomeKeyWindow): New function for EmacsFSWindow.
1763 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
1764 (dealloc): Release nonfs_window if in fullscreen.
1765 (updateFrameSize:): Call windowDidMove to update top/left.
1766 (windowWillResize:toSize:): Check if frame is still maximized.
1767 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
1768 next_maximized, maximized_width, maximized_height and nonfs_window.
1769 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
1770 tbar_height.
1771 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
1f9f395d 1772 fullscreen. Set maximized_width/height. Act on next_maximized.
dd946752
JD
1773
1774 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
1775 (EmacsView): Add variables for fullscreen.
1776 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
1777 (EmacsFSWindow): New interface for fullscreen.
1778
427730eb
JB
17792012-09-30 Juanma Barranquero <lekktu@gmail.com>
1780
1781 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
1782
48de8b12
CY
17832012-09-30 Chong Yidong <cyd@gnu.org>
1784
1785 * fns.c (Frandom): Doc fix.
1786
5938d519
MR
17872012-09-30 Martin Rudalics <rudalics@gmx.at>
1788
1789 * window.c (Vwindow_combination_limit): New default value.
1790 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
1791
cb5b0266
PE
17922012-09-30 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
1795 Suggested by Eli Zaretskii in
1796 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
1797
84f72efd
EZ
17982012-09-30 Eli Zaretskii <eliz@gnu.org>
1799
1800 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
1801 HAVE_TIMER_SETTIME is defined.
1802
9d4dcdc9
PE
18032012-09-30 Paul Eggert <eggert@cs.ucla.edu>
1804
d89460ed
PE
1805 Profiler improvements: more-accurate timers, overflow checks.
1806 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
1807 signal.h, setjmp.h. Include systime.h instead.
1808 (saturated_add): New function.
1809 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
1810 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
1811 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
1812 New static vars.
84f72efd 1813 (enum profiler_cpu_running): New enum.
d89460ed
PE
1814 (profiler_cpu_running): Now of that enum type, not bool.
1815 All uses changed to store the new value.
1816 (handle_profiler_signal): Rename from sigprof_handler_1,
1817 for consistency with other handlers. Do not check whether
1818 cpu_log is a hash-table if garbage collecting, since it
1819 doesn't matter in that case.
1820 (deliver_profiler_signal): Rename from sigprof_handler,
1821 for consistency with other handlers.
1822 (setup_cpu_timer): New function, with much of what used to be in
1823 Fprofiler_cpu_start. Check for out-of-range argument.
1824 Prefer timer_settime if available, and prefer
1825 thread cputime clocks, then process cputime clocks, then
1826 monotonic clocks, to the old realtime clock. Use make_timeval
1827 to round more-correctly when falling back to setitimer.
1828 (Fprofiler_cpu_start): Use it.
1829 (Fprofiler_cpu_stop): Prefer timer_settime if available.
1830 Don't assume that passing NULL as the 2nd argument of setitimer
1831 is the same as passing a pointer to all-zero storage.
1832 Ignore SIGPROF afterwards.
1833 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
1834 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
1835 non-fatal signal handlers. Ignore SIGPROF on startup.
1836 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
1837 in profiler.c, since sysdep.c now uses it.
1838
9d4dcdc9
PE
1839 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
1840 Suggested by Eli Zaretskii in
1841 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
1842
8e5691a0
JB
18432012-09-29 Juanma Barranquero <lekktu@gmail.com>
1844
1845 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
1846
e7c1b6ef
SM
18472012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
1848
1849 * lisp.h (struct backtrace): Remove indirection for `function' field.
1850 * xdisp.c (redisplay_internal):
1851 * profiler.c (record_backtrace, sigprof_handler_1):
1852 * alloc.c (Fgarbage_collect):
1853 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
1854 (Fbacktrace_frame): Adjust accordingly.
1855
e61d39cd 18562012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
1857
1858 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
1859 (Frun_hook_with_args_until_failure): Doc fixes.
1860
404043ea
EZ
18612012-09-28 Eli Zaretskii <eliz@gnu.org>
1862
1863 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
1864 Qautomatic_redisplay and change the symbol name. All users changed.
1865
704d3f45
TM
18662012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
1867
1868 * profiler.c (sigprof_handler): Fix race condition.
1869
757140ff
GM
18702012-09-28 Glenn Morris <rgm@gnu.org>
1871
1872 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
1873
a615a3ae
PE
18742012-09-27 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 Check more robustly for timer_settime.
89d17fd0
PE
1877 * Makefile.in (LIB_TIMER_TIME): New macro.
1878 (LIBES): Add it.
a615a3ae
PE
1879 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
1880 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
1881 call timer_settime.
1882
3670daf7
TM
18832012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
1884
1885 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
1886
6a586b7f
JB
18872012-09-26 Juanma Barranquero <lekktu@gmail.com>
1888
1889 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
1890
41c8bfcf
PE
18912012-09-26 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * character.h (MAYBE_UNIFY_CHAR): Remove.
1894 * charset.c, charset.h (maybe_unify_char): Now static.
1895 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
1896 Since this stuff is now private to charset.c, there's no need for
1897 a public macro and no need to inline by hand.
1898
3a880af4
SM
18992012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
1900 Stefan Monnier <monnier@iro.umontreal.ca>
1901 Juanma Barranquero <lekktu@gmail.com>
611b7507 1902
3a880af4
SM
1903 * profiler.c: New file.
1904 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
1905 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
1906 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
1907 * emacs.c (main): Call syms_of_profiler.
1908 * alloc.c (Qautomatic_gc): New constant.
1909 (MALLOC_PROBE): New macro.
1910 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
1911 (total_bytes_of_live_objects): New function.
1912 (Fgarbage_collect): Use it. Record itself in backtrace_list.
1913 Call malloc_probe for the memory profiler.
1914 (syms_of_alloc): Define Qautomatic_gc.
1915 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
1916 race condition.
1917 (struct backtrace): Move definition...
1918 * lisp.h (struct backtrace): ..here.
1919 (Qautomatic_gc, profiler_memory_running): Declare vars.
1920 (malloc_probe, syms_of_profiler): Declare functions.
1921 * xdisp.c (Qautomatic_redisplay): New constant.
1922 (redisplay_internal): Record itself in backtrace_list.
1923 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 1924
5938d519 19252012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
19262012-09-25 Juanma Barranquero <lekktu@gmail.com>
1927
1928 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
1929
e26fd2e4
PE
19302012-09-25 Paul Eggert <eggert@cs.ucla.edu>
1931
1932 Prefer POSIX timers if available.
1933 They avoid a race if the timer is too close to the current time.
1934 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
1935 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 1936 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 1937
eedec3ee
EZ
19382012-09-25 Eli Zaretskii <eliz@gnu.org>
1939
1940 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
1941 CHAR_STRING_ADVANCE.
1942 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
1943 STRING_CHAR_ADVANCE.
1944
aa15c6bb
JB
19452012-09-25 Juanma Barranquero <lekktu@gmail.com>
1946
1947 Move Vlibrary_cache to emacs.c and reset before dumping.
1948
1949 * lisp.h (reset_image_types): Declare.
1950 [WINDOWSNT] (Vlibrary_cache): Declare.
1951
1952 * image.c (reset_image_types): New function.
1953
1954 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
1955 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
1956 (Fdump_emacs): Reset Vlibrary_cache and image_types.
1957
1958 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
1959 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
1960
1961 * w32.h (Vlibrary_cache): Do not declare.
1962
54d629be
EZ
19632012-09-25 Eli Zaretskii <eliz@gnu.org>
1964
16b22fef
EZ
1965 * w32proc.c (sys_signal): Handle all signals defined by the
1966 MS-Windows runtime, not just SIGCHLD. Actually install the signal
1967 handlers for signals supported by Windows. Don't override
1968 term_ntproc as the handler for SIGABRT.
1969 (sigaction): Rewrite to call sys_signal instead of duplicating its
1970 code.
1971 (sys_kill): Improve commentary.
1972
1973 * w32.c (term_ntproc): Accept (and ignore) one argument, for
1974 consistency with a signature of a signal handler. All callers
1975 changed.
1976 (init_ntproc): Accept an argument DUMPING. If dumping, don't
1977 install term_ntproc as a signal handler for SIGABRT, as that
1978 should be done by the dumped Emacs.
1979
1980 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
1981
1982 * w32select.c (term_w32select): Protect against repeated
1983 invocation by setting clipboard_owner to NULL after calling
1984 DestroyWindow.
1985
1986 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
1987 and term_ntproc to their modified signatures.
1988
54d629be
EZ
1989 * character.c (char_string, string_char): Remove calls to
1990 MAYBE_UNIFY_CHAR. See the discussion starting at
1991 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
1992 for the details.
1993
59f7af81
CY
19942012-09-25 Chong Yidong <cyd@gnu.org>
1995
1996 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
1997
22e8cf4a
SM
19982012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
1999
2000 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
2001 when encountering an unknown bytecode.
2002
578098f3
PE
20032012-09-24 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 image.c, indent.c: Use bool for booleans.
2006 * dispextern.h (struct image_type): Members valid_p, load, init
2007 now return bool, not int. All uses changed.
2008 * image.c: Omit unnecessary static decls.
2009 (x_create_bitmap_mask, x_build_heuristic_mask):
2010 Return void, not int, since callers don't care about the return value.
2011 (x_create_bitmap_mask, define_image_type, valid_image_p)
2012 (struct image_keyword, parse_image_spec, image_spec_value)
2013 (check_image_size, image_background)
2014 (image_background_transparent, x_clear_image_1)
2015 (postprocess_image, lookup_image, x_check_image_size)
2016 (x_create_x_image_and_pixmap, xbm_image_p)
2017 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
2018 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
2019 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
2020 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
2021 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
2022 (png_image_p, init_png_functions, png_load_body, png_load)
2023 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
2024 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
2025 (init_gif_functions, gif_load, imagemagick_image_p)
2026 (imagemagick_load_image, imagemagick_load, svg_image_p)
2027 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
2028 (gs_load):
2029 * nsimage.m (ns_load_image):
2030 * nsterm.m (ns_defined_color):
2031 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
2032 * xfns.c (x_defined_color):
2033 * xterm.c (x_alloc_lighter_color_for_widget)
2034 (x_alloc_nearest_color_1, x_alloc_nearest_color)
2035 (x_alloc_lighter_color):
2036 * indent.c (disptab_matches_widthtab, current_column)
2037 (scan_for_column, string_display_width, indented_beyond_p)
2038 (compute_motion, vmotion, Fvertical_motion):
2039 Use bool for booleans.
2040
a5f2b6ec
CY
20412012-09-24 Chong Yidong <cyd@gnu.org>
2042
2043 * chartab.c (Fset_char_table_default): Obsolete function removed.
2044
18e27ea8
PE
20452012-09-23 Paul Eggert <eggert@cs.ucla.edu>
2046
afea8a8a
PE
2047 Move pid_t related decls out of lisp.h.
2048 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
2049 (interruptible_wait_for_termination):
2050 Move these decls from lisp.h to syswait.h, since they use pid_t.
2051 Needed on FreeBSD; see Herbert J. Skuhra in
2052 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
2053 * callproc.c: Include syswait.h.
2054
18e27ea8
PE
2055 gnutls.c, gtkutil.c: Use bool for boolean.
2056 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
2057 (emacs_gnutls_handle_error):
2058 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
2059 (xg_hide_tooltip, xg_create_frame_widgets)
2060 (create_dialog, xg_uses_old_file_dialog)
2061 (xg_get_file_with_chooser, xg_get_file_with_selection)
2062 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
2063 (xg_item_label_same_p, xg_update_menubar)
2064 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
2065 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
2066 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
2067 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
2068 (update_frame_tool_bar, free_frame_tool_bar):
2069 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
2070 * nsmenu.m (ns_update_menubar):
2071 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
2072 * xfns.c (Fx_show_tip) [USE_GTK]:
2073 Use bool for boolean.
2074 * gtkutil.c (xg_update_frame_menubar):
2075 * xmenu.c (update_frame_menubar):
2076 Return void, not int, since caller ignores return value.
2077 * gtkutil.c (xg_change_toolbar_position):
2078 Return void, not 1.
2079
af0e9f75
JB
20802012-09-23 Juanma Barranquero <lekktu@gmail.com>
2081
2082 * makefile.w32-in (BLOCKINPUT_H): Remove.
2083 (SYSSIGNAL_H): New macro.
2084 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
2085 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
2086 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
2087 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
2088 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
2089 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
2090 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
2091 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
2092 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
2093 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
2094 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
2095 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
2096 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
2097 ($(BLD)/w32xfns.$(O)): Update dependencies.
2098
5101529e
EZ
20992012-09-23 Eli Zaretskii <eliz@gnu.org>
2100
2101 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
2102 fatal_error_backtrace.
2103
2104 * w32proc.c (sys_kill): Undo last change: don't do anything when
2105 invoked to deliver SIGABRT to our own process. This is now
2106 handled by emacs_raise.
2107
2c3ee0ad
JB
21082012-09-23 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * w32term.c (w32_read_socket): Remove leftover reference to
2111 interrupt_input_pending.
2112
62a1d661
PE
21132012-09-23 Paul Eggert <eggert@cs.ucla.edu>
2114
2115 Do not use SA_NODEFER.
2116 Problem reported by Dani Moncayo in
2117 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
2118 * alloc.c (die):
2119 * sysdep.c (emacs_abort): Do not reset signal handler.
2120 * emacs.c (terminate_due_to_signal): Reset signal handler here.
2121 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
2122 wanted even on POSIXish hosts, and it doesn't work on Windows.
2123
a0942b9a
JD
21242012-09-23 Jan Djärv <jan.h.d@swipnet.se>
2125
2126 * xterm.c (x_term_init): Call fixup_locale before and after calling
2127 gtk_init (Bug#12392).
2128
d07ff9db
CY
21292012-09-23 Chong Yidong <cyd@gnu.org>
2130
2131 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
2132 Vdynamic_library_alist.
2133
2134 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
2135 (Fgnutls_available_p): Caller changed.
2136
2137 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
2138 (Flibxml_parse_xml_region): Likewise.
2139
2140 * dispextern.h (struct image_type): Remove arg from init function.
2141
2142 * image.c (Finit_image_library, lookup_image_type)
2143 (define_image_type): Remove now-unneeded second arg.
2144 (init_xpm_functions, init_png_functions, init_jpeg_functions)
2145 (init_tiff_functions, init_gif_functions, init_svg_functions):
2146 Arglist and w32_delayed_load calling convention changed.
2147 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 2148 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 2149
4d7e6e51
PE
21502012-09-23 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 Simplify and avoid signal-handling races (Bug#12471).
2153 * alloc.c (die):
2154 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
2155 Avoid recursive loop if there's a fatal error in the function itself.
2156 * atimer.c (pending_atimers):
2157 * blockinput.h: Don't include "atimer.h"; no longer needed.
2158 (interrupt_input_pending): Remove. All uses removed.
2159 pending_signals now counts both atimers and ordinary interrupts.
2160 This is less racy than having three separate pending-signal flags.
2161 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
2162 (input_blocked_p):
2163 Rename from their upper-case counterparts BLOCK_INPUT,
2164 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
2165 INPUT_BLOCKED_P, and turn into functions. All uses changed.
2166 This makes it easier to access volatile variables more accurately.
2167 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
2168 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
2169 that's more reliable if the code is buggy and sets
2170 interrupt_input_blocked to a negative value. All uses changed.
2171 * atimer.c (deliver_alarm_signal):
2172 Remove. No need to deliver this to the parent; any thread can
2173 handle this signal now. All uses replaced by underlying handler.
2174 * atimer.c (turn_on_atimers):
2175 * dispnew.c (handle_window_change_signal):
2176 * emacs.c (handle_danger_signal):
2177 * keyboard.c (kbd_buffer_get_event):
2178 Don't reestablish signal handler; not needed with sigaction.
2179 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
2180 (UNBLOCK_INPUT_TO):
2181 Rework to avoid unnecessary accesses to volatile variables.
2182 (UNBLOCK_INPUT_TO): Now a function.
2183 (totally_unblock_input, unblock_input): New decls.
2184 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
2185 (init_data): Remove. Necessary stuff now done in init_signal.
2186 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
2187 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
2188 (fatal_error_code): Remove; no longer needed.
2189 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
2190 it doesn't always backtrace. All uses changed. No need to reset
2191 signal to default, since sigaction and/or die does that for us now.
2192 Use emacs_raise (FOO), not kill (getpid (), FOO).
2193 (main): Check more-accurately whether we're dumping.
2194 Move fatal-error setup to sysdep.c
2195 * floatfns.c: Do not include "syssignal.h"; no longer needed.
2196 * gtkutil.c (xg_get_file_name, xg_get_font):
2197 Remove no-longer-needed signal-mask manipulation.
2198 * keyboard.c, process.c (POLL_FOR_INPUT):
2199 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
2200 * keyboard.c (read_avail_input): Remove.
2201 All uses replaced by gobble_input.
2202 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
2203 (kbd_buffer_store_event_hold, gobble_input):
2204 (record_asynch_buffer_change) [USABLE_SIGIO]:
2205 (store_user_signal_events):
2206 No need to mess with signal mask.
2207 (gobble_input): If blocking input and there are terminals, simply
2208 set pending_signals to 1 and return. All hooks changed to not
2209 worry about whether input is blocked.
2210 (process_pending_signals): Clear pending_signals before processing
2211 them, in case a signal comes in while we're processing.
2212 By convention callers now test pending_signals before calling us.
2213 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
2214 New functions, to support changes to blockinput.h.
2215 (handle_input_available_signal): Now extern.
2216 (reinvoke_input_signal): Remove. All uses replaced by
2217 handle_async_input.
2218 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
2219 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
2220 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
2221 Clear sigmask reliably, even if Fsignal returns, which it can.
2222 Omit unnecessary accesses to volatile var.
2223 (quit_throw_to_read_char): No need to restore sigmask.
2224 * keyboard.c (gobble_input, handle_user_signal):
2225 * process.c (wait_reading_process_output):
2226 Call signal-handling code rather than killing ourselves.
2227 * lisp.h: Include <float.h>, for...
2228 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
2229 (pending_signals): Now volatile.
2230 (syms_of_data): Now const if IEEE floating point.
2231 (handle_input_available_signal) [USABLE_SIGIO]:
2232 (terminate_due_to_signal, record_child_status_change): New decls.
2233 * process.c (create_process): Avoid disaster if memory is exhausted
2234 while we're processing a vfork, by tightening the critical section
2235 around the vfork.
2236 (send_process_frame, process_sent_to, handle_pipe_signal)
2237 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
2238 ignores SIGPIPE.
2239 (send_process): No need for setjmp/longjmp any more, since the
2240 SIGPIPE stuff is now gone. Instead, report an error if errno
2241 is EPIPE.
2242 (record_child_status_change): Now extern. PID and W are now args.
2243 Return void, not bool. All callers changed.
2244 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
2245 Remove. All uses removed. This bug should be fixed now in a
2246 different way.
2247 (wait_for_termination_1): Use waitpid rather than sigsuspend,
2248 and record the child status change directly. This avoids the
2249 need to futz with the signal mask.
2250 (process_fatal_action): Move here from emacs.c.
2251 (emacs_sigaction_flags): New function, containing
2252 much of what used to be in emacs_sigaction_init.
2253 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
2254 caught by emacs, to make races less likely.
2255 (deliver_process_signal): Rename from handle_on_main_thread.
2256 All uses changed.
2257 (BACKTRACE_LIMIT_MAX): Now at top level.
2258 (thread_backtrace_buffer, threadback_backtrace_pointers):
2259 New static vars.
2260 (deliver_thread_signal, deliver_fatal_thread_signal):
2261 New functions, for more-accurate delivery of thread-specific signals.
2262 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
2263 (deliver_arith_signal): Handle in this thread, not
2264 in the main thread, since it's triggered by this thread.
2265 (maybe_fatal_sig): New function.
2266 (init_signals): New arg DUMPING so that we can be more accurate
2267 about whether we're dumping. Caller changed.
2268 Treat thread-specific signals differently from process-general signals.
2269 Block all signals while handling fatal error; that's safer.
2270 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
2271 on IEEE hosts.
2272 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
2273 Ignore SIGPIPE unless batch.
2274 (emacs_backtrace): Output backtrace for the appropriate thread,
2275 which is not necessarily the main thread.
2276 * syssignal.h: Include <stdbool.h>.
2277 (emacs_raise): New macro.
2278 * xterm.c (x_connection_signal): Remove; no longer needed
2279 now that we use sigaction.
2280 (x_connection_closed): No need to mess with sigmask now.
2281 (x_initialize): No need to reset SIGPIPE handler here, since
2282 init_signals does this for us now.
2283
8f4635e9
JD
22842012-09-23 Jan Djärv <jan.h.d@swipnet.se>
2285
2286 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 2287 background rect may be larger (Bug#12245).
8f4635e9 2288
3296976d
CY
22892012-09-23 Chong Yidong <cyd@gnu.org>
2290
2291 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
2292
d41e491e
PE
22932012-09-22 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * .gdbinit: Just stop at fatal_error_backtrace.
2296 See Stefan Monnier's request in
2297 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
2298 Remove no-longer-used query of system type.
2299
c88b867f
CY
23002012-09-22 Chong Yidong <cyd@gnu.org>
2301
2302 * search.c (Freplace_match): Doc fix (Bug#12325).
2303
2304 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
2305
2306 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
2307 (Fline_end_position): Doc fix.
2308
2309 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
2310
bb4d86b4
CY
23112012-09-22 Chong Yidong <cyd@gnu.org>
2312
2313 * dispextern.h (struct image_type): Add new slot, storing a type
2314 initialization function.
2315
2316 * image.c (define_image_type): Call the image initializer function
2317 if it is defined. Arguments and return value changed.
2318 (valid_image_p, make_image): Callers changed.
2319 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
2320 (gif_type, imagemagick_type, svg_type, gs_type):
2321 Add initialization functions.
bb4d86b4
CY
2322 (Finit_image_library): Call lookup_image_type.
2323 (CHECK_LIB_AVAILABLE): Macro deleted.
2324 (lookup_image_type): Call define_image_type here, rather than via
2325 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
2326 (syms_of_image): Move define_image_type calls for xbm_type and
2327 pbm_type to lookup_image_type.
2328
df9685f3
EZ
23292012-09-22 Eli Zaretskii <eliz@gnu.org>
2330
2331 * keyboard.c (timer_check_2): Move calculation of 'timers' and
2332 'idle_timers' from here ...
2333 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
2334 lists, to avoid infloops when the timer does something stupid,
2335 like reinvoke itself with the same or smaller time-out.
2336 (Bug#12447)
2337
8e17c9ba
MR
23382012-09-22 Martin Rudalics <rudalics@gmx.at>
2339
2340 * window.c (Fsplit_window_internal): Handle only Qt value of
2341 Vwindow_combination_limit separately.
2342 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
2343 (Vwindow_combination_limit): New default value.
2344 Rewrite doc-string.
8e17c9ba 2345
589bd69b
EZ
23462012-09-22 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
2349 the new overlay string. (Bug#10159)
2350
01108e3f
PE
23512012-09-22 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
2354 or that fprintf is async-signal-safe. POSIX doesn't require
2355 either assumption.
2356
82f8cd94
CY
23572012-09-22 Chong Yidong <cyd@gnu.org>
2358
2359 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
2360 (Bug#8207).
2361
3cccbd87
KH
23622012-09-22 Kenichi Handa <handa@gnu.org>
2363
2364 * composite.c (composition_reseat_it): Handle the case that a
2365 grapheme cluster is not covered by a single font (Bug#12352).
2366
09c01941
CY
23672012-09-21 Chong Yidong <cyd@gnu.org>
2368
2369 * image.c (define_image_type): Avoid adding duplicate types to
2370 image_types (Bug#12463). Suggested by Jörg Walter.
2371
acfa068f 23722012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
2373
2374 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
2375 (print_load_command_name): Add case LC_DATA_IN_CODE.
2376 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
2377
acfa068f 23782012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
2379
2380 * eval.c (Frun_hook_with_args_until_success)
2381 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
2382
acfa068f 23832012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
2384
2385 * fileio.c (Ffile_selinux_context): Only call freecon when
2386 lgetfilecon succeeded.
2387 (Fset_file_selinux_context): Likewise. (Bug#12444)
2388
acfa068f 23892012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
2390
2391 * xdisp.c (try_window_reusing_current_matrix): Under bidi
2392 reordering, locate the cursor by calling set_cursor_from_row; if
2393 that fails, clear the desired glyph matrix before returning a
2394 failure indication to the caller. Fixes leaving garbled display
2395 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
2396 (compute_stop_pos_backwards): Fix a typo that caused crashes while
2397 scrolling through multibyte text.
aa36e4d2 2398
e99f70c8
SM
23992012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
2400
2401 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
2402 calling mark_vectorlike since that's the one that marks the window.
2403 (mark_discard_killed_buffers): Mark the final cdr.
2404 * window.h (struct window): Move prev/next_buffers to the
2405 non-standard fields.
2406 * window.c (make_window): Initialize prev/next_buffers manually.
2407
f75beb47
PE
24082012-09-20 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 Omit unused arg EXPECTED from socket hooks.
2411 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
2412 * nsterm.m (ns_term_init):
2413 * termhooks.h (struct terminal.read_socket_hook):
2414 * w32inevt.c (w32_console_read_socket):
2415 * w32term.c (w32_read_socket):
2416 * xterm.c (XTread_socket):
2417 Omit unused arg EXPECTED. All callers changed.
2418 (store_user_signal_events): Return void, not int, since callers no
2419 longer care about the return value. All uses changed.
2420
b019b76a
JB
24212012-09-20 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * w32gui.h (XParseGeometry): Do not declare.
2424
05642592
PE
24252012-09-19 Paul Eggert <eggert@cs.ucla.edu>
2426
e4bce92a 2427 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1f9f395d 2428 Ignore 'expected'. See Eli Zaretskii in
e4bce92a
PE
2429 <http://bugs.gnu.org/12471#8> (last line).
2430
05642592
PE
2431 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
2432 (XParseGeometry): Now static. Substitute extremal values for
2433 values that are out of range.
2434
e543ae91
JD
24352012-09-19 Jan Djärv <jan.h.d@swipnet.se>
2436
2437 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
2438
2439 * nsfns.m (XParseGeometry): Remove.
2440 (Fx_create_frame): Call x_set_offset to correctly interpret
2441 top_pos in geometry.
2442
3a880af4 2443 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
2444 (Fx_parse_geometry): If there is a space in string, call
2445 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
2446
45ba16c7
EZ
24472012-09-17 Eli Zaretskii <eliz@gnu.org>
2448
c8b9f1bc
EZ
2449 * search.c (scan_buffer): Use character positions in calls to
2450 region_cache_forward and region_cache_backward, not byte
2451 positions. (Bug#12196)
2452
b4c932a2
EZ
2453 * w32term.c (w32_read_socket): Set pending_signals to 1, like
2454 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
2455
45ba16c7
EZ
2456 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
2457 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
2458 emacs_blocked_malloc, now deleted.
2459
eeceac93
PE
24602012-09-17 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
2463 The workaround was for improving performance on Solaris 2.4, but
2464 is getting in the way now. Emacs will still work if someone is
2465 still running Solaris 2.4 in a museum somewhere; Sun dropped
2466 support for Solaris 2.4 in 2003.
2467 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
2468 * process.c (create_process) [HAVE_WORKING_VFORK]:
2469 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
2470 since Emacs no longer uses vfork on that platform.
2471
78f83752
GM
24722012-09-17 Glenn Morris <rgm@gnu.org>
2473
2474 * emacs.c: Use COPYRIGHT.
2475
634b8cac
PE
24762012-09-16 Paul Eggert <eggert@cs.ucla.edu>
2477
0caaedb1
PE
2478 Remove configure's --without-sync-input option (Bug#12450).
2479 When auditing signal-handling in preparation for cleaning it up,
2480 I found that SYNC_INPUT has race conditions and would be a real
2481 pain to fix. Since it's an undocumented and deprecated
2482 configure-time option, now seems like a good time to remove it.
2483 Also see <http://bugs.gnu.org/11080#16>.
2484 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
2485 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
2486 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
2487 (malloc_hysteresis):
2488 (check_depth) [XMALLOC_OVERRUN_CHECK]:
2489 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
2490 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
2491 (dont_register_blocks, bytes_used_when_reconsidered)
2492 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
2493 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
2494 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1f9f395d 2495 Remove. All uses removed.
0caaedb1
PE
2496 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
2497 implementation, one that depends on whether the new macro
2498 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
2499 is defined.
2500 * atimer.c (run_timers, handle_alarm_signal):
2501 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
2502 (handle_async_input, process_pending_signals)
2503 (handle_input_available_signal, init_keyboard):
2504 * nsterm.m (ns_read_socket):
2505 * process.c (wait_reading_process_output):
2506 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
2507 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
2508 (emacs_write):
2509 * xterm.c (XTread_socket):
2510 Assume SYNC_INPUT.
2511 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
2512 * eval.c (handling_signal): Remove. All uses removed.
2513 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
2514 All uses replaced with the SYNC_INPUT version.
2515 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
2516 Remove decls.
2517 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2518 Now static.
2519
634b8cac
PE
2520 * font.c (Ffont_shape_gstring): Remove unused local.
2521
83da1b55
GM
25222012-09-16 Glenn Morris <rgm@gnu.org>
2523
518650a5
GM
2524 * Makefile.in (clean): No longer run nextstep's clean.
2525
83da1b55
GM
2526 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
2527 (ns_frag): Remove.
2528 (ns-app): Move here from ns.mk, and simplify.
2529 (clean): Simplify nextstep entry.
2530 * ns.mk: Remove file.
2531
85a43e2e
KH
25322012-09-17 Kenichi Handa <handa@gnu.org>
2533
2534 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
2535 not covert the last few charactes.
2536
ba13e616 25372012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
2538
2539 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
2540 here, but just check the validity of glyphs in the glyph-string.
2541
a8c729af
MR
25422012-09-16 Martin Rudalics <rudalics@gmx.at>
2543
3a880af4
SM
2544 * window.c (Fwindow_parameter, Fset_window_parameter):
2545 Accept any window as argument (Bug#12452).
a8c729af 2546
c077c059
JD
25472012-09-16 Jan Djärv <jan.h.d@swipnet.se>
2548
2549 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
2550 to ns_term_init to avoid memory leak.
2551
2552 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
2553 explicit retain/release.
2554 (ns_term_init): Only allow one display. Initialize outerpool and
2555 ns_*_types.
2556
39a57ad0
PE
25572012-09-15 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 Port _setjmp fix to POSIXish hosts as well as Microsoft.
2560 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
2561 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
2562 the Microsoft problem in a different way, by altering ../nt/config.nt.
2563
7105c8cb
EZ
25642012-09-15 Eli Zaretskii <eliz@gnu.org>
2565
2566 * w32xfns.c:
2567 * w32uniscribe.c:
2568 * w32term.c:
2569 * w32select.c:
2570 * w32reg.c:
2571 * w32proc.c:
2572 * w32menu.c:
2573 * w32inevt.c:
2574 * w32heap.c:
2575 * w32font.c:
2576 * w32fns.c:
2577 * w32console.c:
2578 * w32.c:
2579 * w16select.c: Remove inclusion of setjmp.h, as it is now included
2580 by lisp.h. This completes removal of setjmp.h inclusion
2581 erroneously announced in the previous commit. (Bug#12446)
2582
2583 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
2584 more accurate.
2585
2586 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
2587 not defined as a macro. The latter happens on MS-Windows.
2588 (Bug#12446)
2589
0328b6de
PE
25902012-09-15 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Port better to POSIX hosts lacking _setjmp (Bug#12446).
2593 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 2594 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
2595 only reason for the instance was because "lisp.h" was included.
2596 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
2597 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
2598 and _longjmp with the new symbols. Emacs already uses _setjmp if
2599 available, so this change affects only POSIXish hosts that have
2600 sigsetjmp but not _setjmp, such as some versions of Solaris and
2601 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
2602 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
2603 (png_load_body) [HAVE_PNG]:
2604 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
2605 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
2606 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
2607 since PNG requires jmp_buf. This is the only exception to the
2608 general rule that we now use sys_setjmp and sys_longjmp.
2609 This exception is OK since this code does not change the signal
2610 mask or longjmp out of a signal handler.
2611
2af03429
PE
26122012-09-14 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
2615 Include "syssignal.h", for 'main_thread'.
2616
2f294edf
DA
26172012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
2618
2619 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
2620 * insdel.c (replace_range, replace_range_2):
2621 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
2622 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
2623 Remove redundant check before calling offset_intervals.
2624
6b533e9c
MR
26252012-09-14 Martin Rudalics <rudalics@gmx.at>
2626
2627 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
2628 current buffer (Bug#12387).
2629
2a7931e3
JB
26302012-09-14 Juanma Barranquero <lekktu@gmail.com>
2631
2632 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
2633
c18e885b
PE
26342012-09-13 Paul Eggert <eggert@cs.ucla.edu>
2635
2636 Use a more backwards-compatible timer format (Bug#12430).
2637 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
2638 vector element, not from the 4th, since PSECS is now at the end.
2639 (Fcurrent_idle_time): Doc fix.
2640
d59a1afb
DA
26412012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
2642
2643 Function to mark objects and remove killed buffers at once.
2644 * alloc.c (discard_killed_buffers): Rename to ...
2645 (mark_discard_killed buffers) ... new name. Add marking
2646 of remaining objects. Fix comment. Adjust users.
2647 (mark_object): Do not touch frame buffer lists here.
2648 * frame.c (delete_frame): Reset frame buffer lists here.
2649
5f0cb45a
PE
26502012-09-13 Paul Eggert <eggert@cs.ucla.edu>
2651
8ea47e3a
PE
2652 Better workaround for GNOME bug when --enable-gcc-warnings.
2653 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
2654 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
2655 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
2656
4a4bbad2
PE
2657 Simplify SIGIO usage (Bug#12408).
2658 The code that dealt with SIGIO was crufty and confusing, e.g., it
2659 played tricks like "#undef SIGIO" but these tricks were not used
2660 consistently. Simplify mostly by not #undeffing standard symbols,
2661 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
2662 or not as we please) rather than "defined SIGIO" (standard symbol
2663 that we probably shouldn't #undef).
2664 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
2665 Modules that need it can include it.
2666 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
2667 * dispextern.h (ignore_sigio): New decl.
2668 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
2669 unconditionally, since it's now a no-op if !USABLE_SIGIO.
2670 * emacs.c (shut_down_emacs):
2671 * keyboard.c (kbd_buffer_store_event_hold):
2672 Use ignore_sigio rather than invoking 'signal' directly.
2673 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
2674 for FIONREAD.
2675 (FIONREAD, SIGIO): Do not #undef.
2676 (tty_read_avail_input): Use #error rather than a syntax error.
2677 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
2678 for I_PIPE, used by SETUP_SLAVE_PTY.
2679 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
2680 * sysdep.c (croak): Remove; no longer needed. This bit of
2681 temporary code, with Fred N. Fish's comment that it's temporary,
2682 has been in Emacs since at least 1992!
2683 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
2684 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
2685 * syssignal.h (croak): Remove decl.
2686 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
2687 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
2688 now that we're termios-only.
2689 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
2690 * term.c (dissociate_if_controlling_tty): Use #error rather than
2691 a run-time error.
2692
5f0cb45a
PE
2693 Work around GCC and GNOME bugs when --enable-gcc-warnings.
2694 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
2695 to work around GNOME bug 683906.
2696 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
2697 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
2698 This works around GCC bug 54561.
2699
40bce90b
PE
27002012-09-12 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 More fixes for 'volatile' and setjmp/longjmp.
2703 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
2704 * image.c (struct png_load_context) [HAVE_PNG]: New type.
2705 (png_load_body) [HAVE_PNG]:
2706 (jpeg_load_body) [HAVE_JPEG]:
2707 New function, with most of the old parent function's body.
2708 (png_load) [HAVE_PNG]:
2709 (jpeg_load) [HAVE_JPEG]:
2710 Invoke the new function, to avoid longjmp munging our locals.
2711 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
2712 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
2713 longjmp is passed 2, as the C standard doesn't guarantee this.
2714 Instead, store the failure code into mgr->failure_code.
2715
bfeae2cf
SM
27162012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2717
2718 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
2719 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
2720 (syms_of_keyboard): Remove support for unread-command-char.
2721
8099e36b
EZ
27222012-09-12 Eli Zaretskii <eliz@gnu.org>
2723
2724 * w32proc.c (sys_kill): If PID is our process ID and the signal is
2725 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
2726 violation. (Bug#12426)
2727
92547ff9
PE
27282012-09-12 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
2731
45b82ad0
SM
27322012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2733
2734 * eval.c: Add `inhibit-debugger'.
2735 (Qinhibit_debugger): New symbol.
2736 (call_debugger): Bind it instead of Qdebug_on_error.
2737 (maybe_call_debugger): Test Vinhibit_debugger.
2738 (syms_of_eval): Define inhibit-debugger.
2739 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
2740 (syms_of_xdisp): Remove inhibit-debug-on-message.
2741
5779a1dc
PE
27422012-09-11 Paul Eggert <eggert@cs.ucla.edu>
2743
50f2e553
PE
2744 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
2745 If a nonvolatile local variable is written before a _longjmp to
2746 the frame containing the variable, and is read after the _longjmp,
2747 the value read is indeterminate. Some local variables of type
2748 'struct handler' and 'struct catchtag' are used in this way, so
2749 mark each of their slots as volatile if the slot can be set before
2750 _longjmp and read afterwards.
2751 * lisp.h (struct handler): var and chosen_clause are now volatile.
2752 (struct catchtag): val, next, and pdlcount are now volatile.
2753
ae1d87e2
PE
2754 * bidi.c (bidi_push_it, bidi_pop_it):
2755 * fns.c (copy_hash_table):
2756 * image.c (define_image_type):
2757 * keyboard.c (kbd_buffer_store_event_hold):
2758 * process.c (Fprocess_send_eof):
2759 * xfaces.c (x_create_gc) [HAVE_NS]:
2760 * xgselect.c (xg_select):
2761 Prefer assignment to memcpy when either will do.
2762
5779a1dc
PE
2763 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
2764 Use pointer-to-a-pointer to simplify and avoid a NILP check each
2765 time an item is removed. No need to mark this function 'inline';
2766 the compiler knows better than we do.
2767
c4c9756b
JD
27682012-09-11 Jan Djärv <jan.h.d@swipnet.se>
2769
2770 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
2771 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
2772 to change_frame_size (Bug#12388).
2773 (windowDidResize:): Pass YES to updateFrameSize.
2774
2775 * nsterm.h: Add delay parameter to updateFrameSize.
2776
d73e321c
DA
27772012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
2778
2779 Discard killed buffers from deleted window and frame objects.
2780 This reduces an amount of references to killed buffers and
2781 helps GC to reclaim them faster.
2782 * alloc.c (discard_killed_buffers): New function.
2783 (mark_object): Use it for deleted windows and frames.
2784 (mark_object): If symbol's value is set up for a killed buffer
1f9f395d 2785 or deleted frame, restore its global binding.
d73e321c
DA
2786 * data.c (swap_in_global_binding): Add GC notice.
2787 (swap_in_symval_forwarding): Use convenient set_blv_where.
2788 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
2789 * window.h: ... to here.
2790
e578f381
DA
27912012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
2792
2793 Convenient macro to check whether the buffer is live.
2794 * buffer.h (BUFFER_LIVE_P): New macro.
2795 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
2796 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
2797
3057e615
YM
27982012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2799
2800 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
2801 composition cases (Bug#12364).
2802
2803 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
2804 overhang of succeeding glyphs overlapping box cursor.
2805
2806 * w32term.c (x_draw_glyph_string): Likewise.
2807
6fda35f2
PE
28082012-09-11 Paul Eggert <eggert@cs.ucla.edu>
2809
c990426a
PE
2810 Simplify, document, and port floating-point (Bug#12381).
2811 The porting part of this patch fixes bugs on non-IEEE platforms
2812 with frexp, ldexp, logb.
2813 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
2814 Now static.
2815 * floatfns.c: Simplify discussion of functions that Emacs doesn't
2816 support, by removing commented-out code and briefly listing the
2817 C89 functions excluded. The commented-out stuff was confusing
2818 maintenance, e.g., we thought we needed cbrt but it was commented out.
2819 (logb): Remove decl; no longer needed.
2820 (isfinite): New macro, if not already supplied.
2821 (isnan): Don't replace any existing macro.
2822 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
2823 are present on all C89 platforms.
2824 (Ffrexp): Do not special-case zero, as frexp does the right thing
2825 for that case.
2826 (Flogb): Do not use logb, as it doesn't have the desired meaning
2827 on hosts that use non-base-2 floating point. Instead, stick with
2828 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
2829 frexp, to avoid getting an unspecified result.
2830
6fda35f2
PE
2831 * xdisp.c (Qinhibit_debug_on_message): Now static.
2832
16130a58
JD
28332012-09-10 Jan Djärv <jan.h.d@swipnet.se>
2834
2835 * nsterm.m (ns_update_begin): Set clip path to whole view by using
2836 NSBezierPath (Bug#12131).
2837
d105a573
CY
28382012-09-10 Chong Yidong <cyd@gnu.org>
2839
2840 * fns.c (Fdelq, Fdelete): Doc fix.
2841
ff55dfe8
PE
28422012-09-10 Paul Eggert <eggert@cs.ucla.edu>
2843
2844 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
2845 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
2846
e7032e7c
SM
28472012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 * lisp.h (make_lisp_ptr): New macro to replace XSET.
2850 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
2851 Use it.
2852
e9957956
EZ
28532012-09-09 Eli Zaretskii <eliz@gnu.org>
2854
aba05ce9
EZ
2855 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
2856 left fringe if the window has a left margin. This avoids leaving
2857 traces of the cursor because its leftmost pixel is not drawn over.
2858
e9957956
EZ
2859 * dispnew.c (update_window_line): When the left margin area of a
2860 screen line is updated, set the redraw_fringe_bitmaps_p flag of
2861 that screen line. (Bug#12277)
2862
f6196b87
PE
28632012-09-09 Paul Eggert <eggert@cs.ucla.edu>
2864
2865 Assume C89 or later for math functions (Bug#12381).
2866 This simplifies the code, and makes it a bit smaller and faster,
2867 and (most important) makes it easier to clean up signal handling
2868 since we can stop worring about floating-point exceptions in
2869 library code. That was a problem before C89, but the problem
2870 went away many years ago on all practical Emacs targets.
2871 * data.c, image.c, lread.c, print.c:
2872 Don't include <math.h>; no longer needed.
2873 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
2874 might be autoconfigured, as that never happens.
2875 * data.c (fmod):
2876 * doprnt.c (DBL_MAX_10_EXP):
2877 * print.c (DBL_DIG):
2878 Remove. C89 or later always defines these.
2879 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
2880 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
2881 (arith_error, domain_error, domain_error2):
2882 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
2883 no longer needed -- we simply return what C returns. All uses removed.
2884 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
2885 the wrapped code.
2886 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
2887 Remove. All uses expanded, as these macros are no longer used
2888 more than once and are now more trouble than they're worth.
2889 (Ftan): Use tan, not sin / cos.
2890 (Flogb): Assume C89 frexp.
2891 (fmod_float): Assume C89 fmod.
2892 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
2893 (init_floatfns): Remove. All uses removed.
2894
9d7f1863
JD
28952012-09-08 Jan Djärv <jan.h.d@swipnet.se>
2896
2897 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
2898 compositeToPoint for OSX < 10.6 (Bug#12390).
2899
eabf0404
PE
29002012-09-08 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
2903 This produces more-accurate results.
2904
0b3b1d23
JD
29052012-09-08 Jan Djärv <jan.h.d@swipnet.se>
2906
2907 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
2908 changes (Bug#12088).
2909
6dcef6ec
CY
29102012-09-08 Chong Yidong <cyd@gnu.org>
2911
2912 * syntax.c (Fstring_to_syntax): Doc fix.
2913
aa7d57c5
JD
29142012-09-08 Jan Djärv <jan.h.d@swipnet.se>
2915
2916 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
2917 in the internal border.
2918 (x_set_window_size): Remove static variables and their usage.
2919 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
2920 (ns_after_update_window_line, ns_draw_fringe_bitmap):
2921 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
2922 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
2923 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
2924 (ns_fix_rect_ibw): Remove.
2925 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
2926 (ns_dumpglyphs_box_or_relief): Ditto.
2927 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
2928 adjustment.
2929 (ns_dumpglyphs_image): Ditto.
fc0c31f8 2930 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
2931 border adjustment.
2932 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
2933 their usage. Add fringe_extended_p and its use as in other terms.
2934 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
2935 scroll bar was removed.
2936 (updateFrameSize): New function.
2937 (windowDidResize): Move code to updateFrameSize and call it.
2938
2939 * nsterm.h (EmacsView): Add updateFrameSize.
2940
1a5432bc
CY
29412012-09-07 Chong Yidong <cyd@gnu.org>
2942
b4f5313e
CY
2943 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
2944
1a5432bc
CY
2945 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
2946
1a4f1e9b
PE
29472012-09-07 Paul Eggert <eggert@cs.ucla.edu>
2948
2949 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
2950 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
2951 Problem introduced when merging patches. Noted by Eli Zaretskii in
2952 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
2953 * floatfns.c: Comment fix.
2954 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
2955 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
2956 and anyway the declaration is harmless even if SIGDANGER is not defined.
2957 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
2958 defined BROKEN_FIONREAD). systty.h formerly did this, but other
2959 source files not surprisingly expected syssignal.h to define, or
2960 not define, SIGIO, and it's cleaner to do it that way, for consistency.
2961 Include <sys/ioctl.h>, for FIONREAD.
2962 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
2963 This eliminates a problem whereby other files mysteriously had
2964 to include "syssignal.h" before including "systty.h" if they
2965 wanted to use "#ifdef SIGIO".
2966
bc8000ff
EZ
29672012-09-07 Eli Zaretskii <eliz@gnu.org>
2968
3e6d6928
EZ
2969 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
2970
2971 * w32.c (sigemptyset): Empty the set.
2972 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
2973
bc8000ff
EZ
2974 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
2975
b4fa72f2
DA
29762012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
2977
2978 * alloc.c (mark_buffer): Revert unsafe marking optimization.
2979 (mark_object): Likewise for frame objects.
2980
30730c93
PE
29812012-09-07 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 * syssignal.h (handle_on_main_thread): Always declare,
2984 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
2985 This ports to platforms without HAVE_PTHREAD.
2986
2fe28299
PE
29872012-09-06 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 Signal-handler cleanup (Bug#12327).
2990 Emacs's signal handlers were written in the old 4.2BSD style with
2991 sigblock and sigmask and so forth, and this led to some
2992 inefficiencies and confusion. Rewrite these to use
2993 pthread_sigmask etc. without copying signal sets around. Also,
2994 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
2995 'signal', and instead use functions that do not attempt to take
2996 over the system name space. This patch causes Emacs's text
2997 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
2998 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
2999 Do not include <signal.h> or "syssignal.h", as these
3000 modules do not use signals.
3001 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
3002 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
3003 Do not include <signal.h>, as "syssignal.h" does that for us now.
3004 * atimer.c (sigmask_atimers): New function.
3005 (block_atimers, unblock_atimers): New functions,
3006 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
3007 All uses replaced.
3008 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
3009 no longer needed here.
3010 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 3011 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
3012 * sysdep.c (struct save_signal): New member 'action', replacing
3013 old member 'handler'.
3014 (save_signal_handlers, restore_signal_handlers):
3015 Use sigaction instead of 'signal' to save and restore.
3016 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
3017 New function. All users of 'signal' modified to use set_sighandler
3018 if they're writeonly, and to use sys_signal if they're read+write.
3019 (emacs_sigaction_init, forwarded_signal): New functions.
3020 (sys_signal): Remove. All uses replaced by calls to sigaction
3021 and emacs_sigaction_init, or by direct calls to 'signal'.
3022 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
3023 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
3024 all uses replaced by pthread_sigmask etc. calls.
3025 * syssignal.h: Include <signal.h>.
3026 (emacs_sigaction_init, forwarded_signal): New decls.
3027 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
3028 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
3029 (sigmask, sys_sigmask): Remove; no longer needed.
3030 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
3031 (sigblock, sigunblock, sigfree):
3032 (sigsetmask) [!defined sigsetmask]:
3033 Remove. All uses replaced by pthread_sigmask.
3034 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
3035 no longer need to be replaced, and its typical old uses
3036 are now done via emacs_sigaction_init and sigaction.
3037 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
3038 (sys_sigdel): Remove; unused.
3039 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
3040
0216c128
EZ
30412012-09-06 Eli Zaretskii <eliz@gnu.org>
3042
3043 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
3044 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
3045
c752cfa9
DA
30462012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
3047
3048 Explicitly mark buffer_defaults and buffer_local_symbols.
3049 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
3050 mark_local_symbols here.
3051 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
3052 since special buffers aren't marked here any more.
3053 (allocate_buffer): Chain new buffer with all_buffers here...
3054 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
3055 not here.
3056 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
3057 (syms_of_buffer): Remove staticpro of the above.
3058 (init_buffer_once): Set names for buffer_defaults and
3059 buffer_local_symbols.
3060
a864ef14
PE
30612012-09-06 Paul Eggert <eggert@cs.ucla.edu>
3062
3063 Use bool for booleans in font-related modules.
3064 * font.c (font_intern_prop, font_style_to_value)
3065 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
3066 (generate_otf_features, font_check_otf_features, font_check_otf)
3067 (font_match_p, font_list_entities, font_at):
3068 * fontset.c (fontset_id_valid_p, reorder_font_vector
3069 (fontset_find_font, Fset_fontset_font)
3070 (face_suitable_for_char_p) [0]:
3071 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
3072 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
3073 (m17n_flt_initialized, ftfont_shape_by_flt):
3074 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
3075 * nsfont.m (nsfont_draw):
3076 * w32font.c (w32font_draw):
3077 * w32term.c (x_draw_glyphless_glyph_string_foreground):
3078 Use bool for booleans.
3079 * font.h: Adjust to above API changes.
3080 (struct font, struct font_driver, struct font_driver_list):
3081 Use bool for booleans.
3082 (struct font): Remove useless member encoding_type.
3083 All users removed.
3084 * fontset.c, xftfont.c: Omit unnecessary static decls.
3085
0699fc18
DA
30862012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
3087
3088 * alloc.c (mark_object): Revert window marking code
3089 since it's unsafe for the Fset_window_configuration.
3090
20ef56db
PE
30912012-09-05 Paul Eggert <eggert@cs.ucla.edu>
3092
2fe28299 3093 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
3094 Be more systematic about preserving errno whenever a signal
3095 handler returns, even if it's not in the main thread. Do this by
3096 renaming signal handlers to distinguish between signal delivery
3097 and signal handling. All uses changed.
3098 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
3099 * data.c (deliver_arith_signal): Rename from arith_error.
3100 * dispnew.c (deliver_window_change_signal): Rename from
3101 window_change_signal.
3102 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
3103 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
3104 * keyboard.c (deliver_input_available_signal): Rename from
3105 input_available_signal.
3106 (deliver_user_signal): Rename from handle_user_signal.
3107 (deliver_interrupt_signal): Rename from interrupt_signal.
3108 * process.c (deliver_pipe_signal): Rename from send_process_trap.
3109 (deliver_child_signal): Rename from sigchld_handler.
3110 * atimer.c (handle_alarm_signal):
3111 * data.c (handle_arith_signal):
3112 * dispnew.c (handle_window_change_signal):
3113 * emacs.c (handle_fatal_signal, handle_danger_signal):
3114 * keyboard.c (handle_input_available_signal):
3115 * keyboard.c (handle_user_signal, handle_interrupt_signal):
3116 * process.c (handle_pipe_signal, handle_child_signal):
3117 New functions, with the actual signal-handling code taken from the
3118 original respective signal handlers, sans the sporadic attempts to
3119 preserve errno, since that's now done by handle_on_main_thread.
3120 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
3121 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
3122 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
3123 Move to sysdep.c.
3124 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
3125 Move initialization of main_thread to sysdep.c's init_signals.
3126 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
3127 our usage, and simplifies the mainline code.
3128 (record_child_status_change): New static function, as a helper
3129 for handle_child_signal, and with most of the old child handler's
3130 contents.
3131 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
3132 (handle_child_signal): Use the above.
3133 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
3134 Moved here from emacs.c.
3135 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
3136 code moved here from emacs.c's main function.
3137 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
3138 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
3139 This lets callers save and restore errno properly.
20ef56db 3140
e3ccf108
DA
31412012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
3142
3143 Remove redundant or unused things here and there.
3144 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
3145 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
3146 * editfns.c (Fcompare_buffer_substrings): Likewise.
3147 * frame.h (struct terminal, struct font_driver_list):
3148 Remove redundant declarations.
3149 * window.h (Qleft, Qright): Likewise.
3150
697e1e39
DA
31512012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
3152
3153 Do not mark objects from deleted buffers, windows and frames.
3154 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
3155 (mark_object): Likewise for windows and frames.
3156
c1ca42ca
DA
31572012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
3158
3159 * alloc.c (valid_lisp_object_p): Treat killed buffers,
3160 buffer_defaults and buffer_local_symbols as valid objects.
3161 Return special value to denote them.
3162
014d93be
PE
31632012-09-05 Paul Eggert <eggert@cs.ucla.edu>
3164
f75d7a91
PE
3165 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
3166 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
3167 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
3168 (file_name_absolute_p, Fsubstitute_in_file_name):
3169 (check_executable, check_writable, Ffile_accessible_directory_p)
3170 (Fset_file_selinux_context, Fdefault_file_modes)
3171 (Finsert_file_contents, choose_write_coding_system)
3172 (Fwrite_region, build_annotations, a_write, e_write)
3173 (Fdo_auto_save):
3174 * filelock.c (boot_time_initialized, get_boot_time)
3175 (get_boot_time_1, lock_file_1, within_one_second):
3176 * floatfns.c (in_float):
3177 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
3178 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
3179 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
3180 * lisp.h (struct Lisp_Hash_Table.cmpfn):
3181 * window.c (compare_window_configurations):
3182 Use bool for booleans.
3183 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
3184 (Fdefault_file_modes): Now mode_t, not int, for modes.
3185 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
3186 (internal_delete_file): Now returns void, not a (boolean) int,
3187 since nobody was looking at the return value.
3188 * lisp.h, window.h: Adjust to above API changes.
3189
014d93be
PE
3190 * xdisp.c (set_message): Simplify and reindent last change.
3191
776f29e1
JB
31922012-09-05 Juanma Barranquero <lekktu@gmail.com>
3193
3194 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
3195
7f7e0167
LI
31962012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
3197
3198 * eval.c (call_debugger): Make the function non-static so that we
3199 can call it from set_message.
3200
3201 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
3202 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
3203
cf29dd84
PE
32042012-09-04 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 Give more-useful info on a fatal error (Bug#12328).
3207 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
3208 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
3209 of doing the work ourselves.
3210 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
3211 do most of the work.
3212 (fatal_error_backtrace): New function, taken from the guts
3213 of the old fatal_error_signal, but with a new option to output
3214 a backtrace.
3215 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
3216 info about the signal than just its number.
3217 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
3218 * sysdep.c: Include <execinfo.h>
3219 (emacs_backtrace): New function, taken partly from the previous
3220 code of the 'die' function.
3221 (emacs_abort): Call fatal_error_backtrace rather than abort.
3222
972debf2
SM
32232012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
3224
3225 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
3226 eager (load-time) macro-expansion.
3227 * lisp.mk (lisp): Add macroexp.
3228
1088b922
PE
32292012-09-04 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Simplify redefinition of 'abort' (Bug#12316).
3232 Do not try to redefine the 'abort' function. Instead, redo
3233 the code so that it calls 'emacs_abort' rather than 'abort'.
3234 This removes the need for the NO_ABORT configure-time macro
3235 and makes it easier to change the abort code to do a backtrace.
3236 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
3237 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
3238 Remove; sysdep.c's emacs_abort now takes its place.
3239 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
3240 'abort' changed to use 'emacs_abort'.
3241 * msdos.c (dos_abort) [defined abort]: Remove; not used.
3242 (abort) [!defined abort]: Rename to ...
3243 (emacs_abort): ... new name.
3244 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
3245 the place of the old 'abort' in emacs.c.
3246 * w32.c, w32fns.c (abort): Do not #undef.
3247 * w32.c (emacs_abort): Rename from w32_abort.
3248
30934d33
EZ
32492012-09-04 Eli Zaretskii <eliz@gnu.org>
3250
3251 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
3252 offsets[j].dv, since the y axis of the screen coordinates points
3253 down, while the y axis of the font definition coordinates points
3254 up. This fixes display of Arabic diacritics such as KASRA and
3255 KASRATAN. (Bug#11860)
3256
af26b72c
PE
32572012-09-04 Paul Eggert <eggert@cs.ucla.edu>
3258
3259 Be more systematic about _setjmp vs setjmp.
3260 * alloc.c (test_setjmp, mark_stack):
3261 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
3262 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
3263 (png_load, my_error_exit, jpeg_load):
3264 * process.c (send_process_trap, send_process):
3265 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
3266 The underscored versions are up to 30x faster on some hosts.
3267 Formerly, the code used setjmp+longjmp sometimes and
3268 _setjmp+_longjmp at other times, with no particular reason to
3269 prefer setjmp+longjmp.
3270
26d4541d
PE
32712012-09-03 Paul Eggert <eggert@cs.ucla.edu>
3272
d42f4f0f 3273 Fix minor problem found by static checking.
26d4541d 3274 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 3275
c5e28e39
MR
32762012-09-03 Martin Rudalics <rudalics@gmx.at>
3277
3278 * buffer.c (Fdelete_all_overlays): New function.
3279
3eab3ca9
CY
32802012-09-03 Chong Yidong <cyd@gnu.org>
3281
3282 * gtkutil.c: Add extern decl for Qxft.
3283
c04889f8
PE
32842012-09-02 Paul Eggert <eggert@cs.ucla.edu>
3285
1882aa38
PE
3286 * emacs.c, eval.c: Use bool for boolean.
3287 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
3288 (malloc_using_checking) [DOUG_LEA_MALLOC]:
3289 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
3290 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
3291 (main, decode_env_path, Fdaemon_initialized):
3292 * eval.c (call_debugger, Finteractive_p, interactive_p):
3293 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
3294 (maybe_call_debugger, Fbacktrace):
3295 * process.c (read_process_output, exec_sentinel):
3296 Use bool for booleans.
3297 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
3298 All callers changed.
3299 * eval.c (interactive_p): Omit always-true boolean argument
3300 EXCLUDE_SUBRS_P. All callers changed.
3301 * dispextern.h, lisp.h: Reflect above API changes.
3302 * firstfile.c (dummy): Use the address of 'main', whose signature
3303 won't change, instead of the address of 'initialize', whose
3304 signature just changed from int to bool.
3305 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
3306 * msdos.c (fatal_error_in_progress): ... from here.
3307 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
3308 of incrementing it.
3309 (redisplay_internal, unwind_redisplay): Simply clear
3310 REDISPLAYING_P when unwinding, instead of saving its previous,
3311 always-false value and then restoring it.
3312
a411ac43
PE
3313 Clean up some extern decls.
3314 Mostly, this hoists extern decls out of .c files and into .h files.
3315 That way, we're more likely to catch errors if the interfaces change.
3316 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
3317 declare xg_mark_data.
3318 * dispextern.h (x_frame_parm_handlers):
3319 * font.h (Qxft):
3320 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
3321 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
3322 (Qultra_bold, Qoblique, Qitalic):
3323 Move extern decl here from .c file.
3324 * alloc.c (xg_mark_data) [USE_GTK]:
3325 * doc.c (Qclosure):
3326 * eval.c (Qlexical_binding):
3327 * fns.c (time) [!HAVE_UNISTD_H]:
3328 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
3329 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
3330 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
3331 * lread.c (Qinternal_interpreter_environment):
3332 * minibuf.c (Qbuffer):
3333 * process.c (QCfamily, QCfilter):
3334 * widget.c (free_frame_faces):
3335 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
3336 * xfont.c (x_clear_errors):
3337 * xterm.c (x_frame_parm_handlers):
3338 Remove now-redundant extern decls.
3339 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
3340 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
3341 Now static.
3342 * xfaces.c: Remove unnecessary static decls.
3343 * xterm.c (updating_frame): Remove decl of nonexistent object.
3344
c04889f8
PE
3345 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
3346 when building globals.h, as the objects that are not built on
3347 this host are not needed to compile C files on this host.
3348
8b339673
JD
33492012-09-02 Jan Djärv <jan.h.d@swipnet.se>
3350
3351 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
3352
3353 * frame.h: Add missing prototype for x_wm_set_size_hint.
3354
a08d4ba7
PE
33552012-09-02 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
3358 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
3359 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
3360 (Fsubstitute_command_keys):
3361 * editfns.c (region_limit, find_field, Fconstrain_to_field)
3362 (save_excursion_save, save_excursion_restore)
3363 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
3364 (format_time_string, general_insert_function)
3365 (make_buffer_string, make_buffer_string_both)
3366 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
3367 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
3368 (copy_text, insert_1, insert_1_both, insert_from_string)
3369 (insert_from_string_before_markers, insert_from_string_1)
3370 (insert_from_buffer, insert_from_buffer_1, replace_range)
3371 (replace_range_2, del_range_1, del_range_byte, del_range_both)
3372 (del_range_2, modify_region):
3373 * intervals.c (intervals_equal, balance_possible_root_interval)
3374 (adjust_intervals_for_insertion, merge_properties_sticky)
3375 (graft_intervals_into_buffer, lookup_char_property)
3376 (adjust_for_invis_intang, set_point_both)
3377 (get_property_and_range, compare_string_intervals)
3378 (set_intervals_multibyte_1, set_intervals_multibyte):
3379 * keyboard.c (decode_timer):
3380 Use bool for boolean.
3381 * intervals.h, lisp.h, systime.h: Reflect above API changes.
3382 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
3383
48c948de
CY
33842012-09-02 Chong Yidong <cyd@gnu.org>
3385
3386 * keymap.c (push_key_description): Print M-TAB as C-M-i
3387 (Bug#11758).
3388
6c49a40b
JB
33892012-09-02 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
3392 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
3393 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
3394 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
3395 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
3396 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
3397 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
3398
4dfbd238
EZ
33992012-09-01 Eli Zaretskii <eliz@gnu.org>
3400
7e510e28
EZ
3401 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
3402 more than one grapheme cluster passed to the shaper: compute the
3403 offset adjustment values separately for each cluster. (Bug#11860)
3404
4dfbd238
EZ
3405 * image.c: Restore mistakenly removed inclusion of w32.h. Without
3406 it, GCC doesn't see prototypes of w32_delayed_load, and complains
3407 about implicit conversions from integer to pointer.
3408
86571ae0
DC
34092012-09-01 Daniel Colascione <dancol@dancol.org>
3410
3411 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
3412 system used too early.
3413
0e23ef9d
PE
34142012-09-01 Paul Eggert <eggert@cs.ucla.edu>
3415
3416 Better seed support for (random).
3417 * emacs.c (main): Call init_random.
3418 * fns.c (Frandom): Set the seed from a string argument, if given.
3419 Remove long-obsolete Gentzel cruft.
3420 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
3421 (init_random): New function.
3422
17a2cbbd
DC
34232012-09-01 Daniel Colascione <dancol@dancol.org>
3424
3425 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
3426 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
3427 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
3428 x_wm_set_size_hint, x_query_colors, x_real_positions,
3429 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
3430 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
3431 all of which have been moved to common code.
3432
3433 * xfaces.c: Include TERM_HEADER instead of listing all possible
3434 window-system headers.
3435
3436 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
3437 to match header.
3438
3439 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
3440 directly accessing frame internals.
3441
f18cbb28 3442 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
3443 globals_of_w32font.
3444
3445 * process.c: Include TERM_HEADER instead of listing all possible
3446 window-system headers.
3447
3a880af4
SM
3448 * nsterm.h: Remove declarations now in frame.h.
3449 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
3450
3451 * menu.c: Include TERM_HEADER instead of listing all possible
3452 window-system headers.
3453
3454 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
3455 window system.
3456
3457 * keyboard.c: Include TERM_HEADER instead of listing all possible
3458 window-system headers.
3459
3460 * image.c: Include TERM_HEADER instead of listing all possible
3461 window-system headers. Declare Vlibrary_cache when compiling for
3462 Windows.
3463
3464 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
3465 window system declarations.
3466
3467 * frame.h: Move common functions here: set_frame_menubar,
3468 x_set_window_size, x_sync, x_get_focus_frame,
3469 x_set_mouse_position, x_set_mouse_pixel_position,
3470 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
3471 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
3472 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
3473 x_activate_menubar, x_real_positions, x_bitmap_icon,
3474 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
3475 and x_query_colors.
3476
3477 * frame.c: Include TERM_HEADER instead of listing all possible
3478 window-system headers.
3479
3480 * font.c: Include TERM_HEADER instead of listing all possible
3481 window-system headers.
3482
3483 * emacs.c: Include TERM_HEADER.
3484
f18cbb28
EZ
3485 * dispnew.c: Include TERM_HEADER instead of listing all possible
3486 window-system headers.
17a2cbbd 3487
f18cbb28 3488 * ccl.h: Include character.h.
17a2cbbd
DC
3489
3490 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
3491 the current window system; include in list of objects to link into
3492 Emacs.
3493
c650a5de
DA
34942012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
3495
3496 Remove mark_ttys function and fix tty_display_info initialization.
3497 * lisp.h (mark_ttys): Remove prototype.
3498 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
3499 to mark_ttys because all possible values of 'top_frame' slot are
3500 the frames which are reachable from Vframe_list.
3501 * term.c (mark_ttys): Remove.
3502 (init_tty): Safely initialize 'top_frame' slot with Qnil.
3503
4e0f6479
DA
35042012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
3505
3506 Change struct frame bitfields from unsigned char to unsigned.
3507 * frame.h (struct frame): Change type of 'display_preempted',
3508 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
3509 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
3510 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
3511 bitfields from unsigned char to unsigned.
3512
8b96a52c
DA
35132012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
3514
3515 Remove unused member of struct x_output and struct w32_output.
3516 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
3517 * w32term.h (struct w32_output): Likewise.
3518
b4444c8a
JD
35192012-08-30 Jan Djärv <jan.h.d@swipnet.se>
3520
3521 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
3522 does not become zero (Bug#12234).
3523
b98521db
PE
35242012-08-30 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
3527 for GCC 4.7.1 x86-64.
3528
31d02438
GM
35292012-08-30 Glenn Morris <rgm@gnu.org>
3530
3531 * lread.c (init_lread): For out-of-tree builds, only add the
3532 source directory's site-lisp dir to the load-path if it exists,
3533 consistent with in-tree builds. (Bug#12302)
3534
7f8941d8
JD
35352012-08-28 Jan Djärv <jan.h.d@swipnet.se>
3536
3537 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 3538 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
3539 (windowShouldClose:): Set window_closed.
3540 (dealloc): New member, free button_values.
fc0c31f8
JB
3541 (process_dialog:): Make member function. Remove window argument,
3542 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
3543 in button_values.
3544 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 3545 with tag. Remove return self, declare return value as void.
7f8941d8
JD
3546 (addString:row:): Remove return self, declare return value as void.
3547 (addSplit): Remove return self, declare return value as void.
3548 (clicked:): Remove return self, declare return value as void.
fc0c31f8 3549 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
3550 (initFromContents:isQuestion:): Adjust call to process_dialog.
3551 Code formatting change.
3552 (timeout_handler:): Set timer_fired to YES.
3553 (runDialogAt:): Set timer_fired to NO.
3554 Handle click on close button as quit.
3555
3556 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
3557 Add window_closed and button_values. Add void as return value for
3558 add(Button|String|Split). addButton takes int instead of Lisp_Object.
3559 Add process_dialog as new member.
3560
eada0861 35612012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 3562
eada0861
GM
3563 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
3564 is not one of the heaps we manage. (Bug#12242)
3565
35662012-08-28 Glenn Morris <rgm@gnu.org>
3567
3568 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
3569
457294dd
MR
35702012-08-28 Martin Rudalics <rudalics@gmx.at>
3571
3572 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
3573 auto-buffer-name window parameter. Install revision of reverted
3574 fix.
457294dd 3575
4f2daf31
DA
35762012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
3577
3578 Do not allow to set major mode for a dead buffer.
3579 * buffer.c (Fset_buffer_major_mode): Signal an error
3580 if the buffer is dead.
3581 (Fother_buffer, other_buffer_safely): Remove redundant
3582 nested declaration.
3583
66322887
DA
35842012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
3585
3586 Always use set_buffer_if_live to restore original buffer at unwind.
3587 * buffer.h (record_unwind_current_buffer): New function.
3588 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
3589 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
3590 * undo.c, window.c: Adjust users.
3591 * buffer.c (set_buffer_if_live): Fix comment.
3592
a3d794a1
DA
35932012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
3594
3595 Fix usage of set_buffer_internal.
3596 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
3597 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
3598 * coding.c (decode_coding): Omit redundant test.
3599 * fileio.c (decide_coding_unwind): Likewise.
3600 * fns.c (secure_hash): Likewise.
3601 * insdel.c (modify_region): Likewise.
3602 * keyboard.c (command_loop_1): Likewise.
3603 * print.c (PRINTFINISH): Likewise.
3604 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
3605
59ea14cd
PE
36062012-08-27 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 * dispnew.c: Use bool for boolean.
3609 (frame_garbaged, display_completed, delayed_size_change)
3610 (fonts_changed_p, add_window_display_history)
3611 (add_frame_display_history, verify_row_hash)
3612 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
3613 (row_equal_p, realloc_glyph_pool)
3614 (allocate_matrices_for_frame_redisplay)
3615 (showing_window_margins_p)
3616 (adjust_frame_glyphs_for_frame_redisplay)
3617 (build_frame_matrix_from_leaf_window, make_current)
3618 (mirrored_line_dance, mirror_line_dance, update_frame)
3619 (update_window_tree, update_single_window)
3620 (check_current_matrix_flags, update_window, update_text_area)
3621 (update_window_line, set_window_update_flags, scrolling_window)
3622 (update_frame_1, scrolling, buffer_posn_from_coords)
3623 (do_pending_window_change, change_frame_size)
3624 (change_frame_size_1, sit_for):
3625 Use bool for boolean.
3626 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
3627 and remove last int (actually boolean) argument, which was always 0.
3628 All callers changed.
3629 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
3630 * dispextern.h (struct composition_it): Use bool for boolean.
3631 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
3632 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
3633 * dired.c (file_name_completion):
3634 Use bool for boolean. (This was missed in an earlier change.)
3635
95072a94
MR
36362012-08-27 Martin Rudalics <rudalics@gmx.at>
3637
3638 * window.c (Fset_window_configuration): Revert first part of
3639 last change.
3640
0f19feff
JD
36412012-08-27 Jan Djärv <jan.h.d@swipnet.se>
3642
3643 * nsterm.h (NSPanel): New class variable dialog_return.
3644
3a880af4
SM
3645 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
3646 Initialize dialog_return.
0f19feff
JD
3647 (windowShouldClose:): Use stop instead of stopModalWithCode.
3648 (clicked:): Ditto, and also set dialog_return (Bug#12258).
3649 (timeout_handler:): Use stop instead of abortModal. Send a dummy
3650 event.
3651 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
3652 modal loop returns.
3653
f10fe38f
PE
36542012-08-27 Paul Eggert <eggert@cs.ucla.edu>
3655
de1339b0
PE
3656 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
3657 * composite.c (find_composition, composition_gstring_p)
3658 (composition_reseat_it, find_automatic_composition):
3659 * data.c (let_shadows_buffer_binding_p)
3660 (let_shadows_global_binding_p, set_internal, make_blv)
3661 (Fmake_variable_buffer_local, Fmake_local_variable)
3662 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
3663 (cons_to_signed, arith_driver):
3664 * dbusbind.c (xd_in_read_queued_messages):
3665 * dired.c (directory_files_internal, file_name_completion):
3666 Use bool for booleans.
3667 * dired.c (file_name_completion):
3668 * process.h (fd_callback):
3669 Omit int (actually boolean) argument. It wasn't being used.
3670 All uses changed.
3671 * composite.h, lisp.h: Reflect above API changes.
3672
f10fe38f
PE
3673 * cmds.c, coding.c: Use bool for booleans.
3674 * cmds.c (move_point, Fself_insert_command):
3675 * coding.h (struct composition status, struct coding_system):
3676 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
3677 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
3678 (emacs_mule_char, decode_coding_emacs_mule)
3679 (encode_coding_emacs_mule, detect_coding_iso_2022)
3680 (decode_coding_iso_2022, encode_invocation_designation)
3681 (encode_designation_at_bol, encode_coding_iso_2022)
3682 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
3683 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
3684 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
3685 (encode_coding_raw_text, detect_coding_charset)
3686 (decode_coding_charset, encode_coding_charset, detect_eol)
3687 (detect_coding, get_translation_table, produce_chars)
3688 (consume_chars, reused_workbuf_in_use)
3689 (make_conversion_work_buffer, code_conversion_save)
3690 (decode_coding_object, encode_coding_object)
3691 (detect_coding_system, char_encodable_p)
3692 (Funencodable_char_position, code_convert_region)
3693 (code_convert_string, code_convert_string_norecord)
3694 (Fset_coding_system_priority):
3695 * fileio.c (Finsert_file_contents):
3696 Use bool for booleans.
3697 * coding.h, lisp.h: Reflect above API changes.
3698 * coding.c: Remove unnecessary static function decls.
3699 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
3700 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
3701 not a boolean 'int', since callers never look at the return value.
3702 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
3703 * coding.h (decoding_buffer_size, encoding_buffer_size)
3704 (emacs_mule_string_char): Remove unused extern decls.
3705 (struct iso_2022_spec, struct coding_system):
3706 Use 'unsigned int : 1' for boolean fields, since there's more than one.
3707 (struct emacs_mule_spec): Remove unused field 'full_support'.
3708 All initializations removed.
3709 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
3710
5474c384
DA
37112012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
3712
f10fe38f 3713 Fix spare memory change (Bug#12286).
5474c384
DA
3714 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
3715 (valid_lisp_object_p): Likewise.
3716
c4b6914d
MR
37172012-08-27 Martin Rudalics <rudalics@gmx.at>
3718
3719 * window.c (Fset_window_configuration): Record any window's old
3720 buffer if it's replaced (see Bug#8789). If the new current
3721 buffer doesn't appear in the selected window, go to its old
3722 point (Bug#12208).
3723
35aaa1ea
DA
37242012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
3725
3726 Special MEM_TYPE_SPARE to denote reserved memory.
3727 * alloc.c (enum mem_type): New memory type.
3728 (refill_memory_reserve): Use new type for spare memory.
3729 This prevents live_cons_p and live_string_p from incorrect
3730 detection of uninitialized objects from spare memory as live.
3731
6af64513
PE
37322012-08-26 Paul Eggert <eggert@cs.ucla.edu>
3733
8b2e00a3
PE
3734 Spelling fixes.
3735 * Makefile.in (.PHONY): versioclean -> versionclean.
3736
b52d6985
PE
3737 Remove unused external symbols.
3738 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
3739 * window.c (Qwindow_valid_p, decode_valid_window):
3740 Now static, not extern.
3741 * data.c (Qinterval): Remove; unused.
3742 (syms_of_data): Do not define 'interval'.
3743 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
3744 * window.h (decode_valid_window):
3745 Remove decls.
3746
d5172d4f
PE
3747 * character.c, charset.c, chartab.c: Use bool for booleans.
3748 * character.c (lisp_string_width, string_count_byte8)
3749 (string_escape_byte8):
3750 * charset.c (charset_map_loaded, load_charset_map, read_hex):
3751 (load_charset_map_from_file, map_charset_chars)
3752 (Fdefine_charset_internal, define_charset_internal)
3753 (Fdeclare_equiv_charset, find_charsets_in_text)
3754 (Ffind_charset_region, char_charset, Fiso_charset):
3755 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
3756 (sub_char_table_set, sub_char_table_set_range)
3757 (char_table_set_range, optimize_sub_char_table)
3758 (map_sub_char_table):
3759 Use bool for boolean.
3760 * character.c (str_to_unibyte): Omit last boolean argument; it was
3761 always 0. All callers changed.
3762 * character.h, charset.h: Adjust to match previous changes.
3763 * character.h (char_printable_p): Remove decl of nonexistent function.
3764 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
3765 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
3766 are all boolean, so make them single-bit bitfields.
3767
6af64513
PE
3768 * lisp.h (ASET): Remove attempt to detect side effects.
3769 It was meant to be temporary and it often doesn't work,
3770 because when IDX has side effects the behavior of IDX==IDX
3771 is undefined. See Stefan Monnier in
3772 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
3773
e1f29348
BR
37742012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3775
3776 * lisp.h (functionp): New function (extracted from Ffunctionp).
3777 (FUNCTIONP): Use it.
3778 * eval.c (Ffunctionp): Use it.
3779
17c05d74
PE
37802012-08-25 Paul Eggert <eggert@cs.ucla.edu>
3781
0f46bc75
PE
3782 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
3783 as that's faster and simpler than static storage. Don't bother
3784 with the g_main_context_query overhead if g_main_context_pending
3785 says no events are pending.
3786 (gfds, gfds_size): Remove these static vars.
3787 (xgselect_initialize): Remove; no longer needed.
3788 All uses and decls removed.
3789
ee4c0f69
PE
3790 * emacs.c (fatal_error_signal_hook): Remove.
3791 All uses removed. This leftover from old code was always 0.
3792
17c05d74
PE
3793 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
3794 * casefiddle.c (casify_object, casify_region):
3795 * casetab.c (set_case_table):
3796 * category.c, category.h (word_boundary_p):
3797 * category.h (CHAR_HAS_CATEGORY):
3798 Use bool for booleans, instead of int.
3799
391ceac5
EZ
38002012-08-25 Eli Zaretskii <eliz@gnu.org>
3801
3802 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
3803
2f221583
PE
38042012-08-25 Paul Eggert <eggert@cs.ucla.edu>
3805
f4a681b0
PE
3806 On assertion failure, print backtrace if available.
3807 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
3808 (die) [ENABLE_CHECKING]: Print a backtrace if available.
3809 * Makefile.in (LIB_EXECINFO): New macro.
3810 (LIBES): Use it.
3811
2f221583
PE
3812 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
3813 * bytecode.c (exec_byte_code):
3814 * callint.c (check_mark, Fcall_interactively):
3815 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
3816 (getenv_internal, sync_process_alive, call_process_exited):
3817 * lisp.h (USE_SAFE_ALLOCA):
3818 Use bool for booleans, instead of int.
3819 * lisp.h, process.h: Adjust prototypes to match above changes.
3820 * callint.c (Fcall_interactively): Don't assume the mark's
3821 offset fits in 'int'.
3822
37ef52bb
PE
38232012-08-24 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 * buffer.c, buffer.h: Use bool for boolean.
3826 * buffer.c (reset_buffer_local_variables)
3827 (buffer_lisp_local_variables, Fset_buffer_modified_p)
3828 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
3829 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
3830 (overlay_touches_p, overlay_strings, Foverlay_put)
3831 (report_overlay_modification, call_overlay_mod_hooks):
3832 (mmap_enlarge, mmap_set_vars):
3833 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
3834 Use bool for booleans, instead of int.
3835 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
3836 since the 1-or-0 return value is always ignored anyway.
3837 (mmap_initialized_p):
3838 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
3839 * buffer.h, lisp.h: Adjust prototypes to match above changes.
3840
2cc21167
PE
38412012-08-23 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 * bidi.c: Use bool for boolean.
3844 This is a bit more readable, and makes the text segment of bidi.o
3845 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
3846 Presumably it's faster too.
3847 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
3848 Now bool.
3849 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3850 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
3851 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
3852 (bidi_explicit_dir_char, bidi_level_of_next_char)
3853 (bidi_find_other_level_edge, bidi_move_to_visually_next):
3854 Use bool for booleans, instead of int.
3855 * dispextern.h (bidi_init_it, bidi_paragraph_init)
3856 (bidi_unshelve_cache): Adjust decls to match code.
3857
7db4ddf4
MR
38582012-08-23 Martin Rudalics <rudalics@gmx.at>
3859
3860 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
3861 argument.
3862
b1bb8011
PE
38632012-08-23 Paul Eggert <eggert@cs.ucla.edu>
3864
3865 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
3866 * atimer.h: Include <stdbool.h>.
3867
ff687885
DN
38682012-08-22 Dan Nicolaescu <dann@gnu.org>
3869
3870 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
3871 compile time tests instead of run time tests on systems that do
3872 not use them.
3873 (FRAME_MAC_P): Remove leftover from deleted code.
3874 * frame.c (syms_of_frame): Remove leftover from deleted code.
3875
4ce7a138
JD
38762012-08-22 Jan Djärv <jan.h.d@swipnet.se>
3877
3878 * nsterm.m (insertText:): Don't clear modifiers if code is space.
3879
d733ec6d
PE
38802012-08-22 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
3883 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 3884 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
3885 (fontset_add): Return void, for FONTSET_ADD.
3886
d0d2d26f
PE
38872012-08-21 Paul Eggert <eggert@cs.ucla.edu>
3888
fce31d69
PE
3889 * alloc.c: Use bool for booleans.
3890 (gc_in_progress, abort_on_gc)
3891 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
3892 (dont_register_blocks) [GC_MALLOC_CHECK]:
3893 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
3894 (check_string_bytes, make_specified_string, memory_full)
3895 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
3896 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
3897 (mark_stack, valid_pointer_p, make_pure_string)
3898 (Fgarbage_collect, survives_gc_p, gc_sweep):
3899 Use bool for booleans, instead of int.
3900 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
3901 Remove unused local.
3902 * alloc.c (PURE_POINTER_P):
3903 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
3904 * editfns.c (Fformat):
3905 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
3906 (Fdo_auto_save):
3907 * fns.c (sweep_weak_table):
3908 * lisp.h (suppress_checking, push_message, survives_gc_p)
3909 (make_pure_string, gc_in_progress, abort_on_gc):
3910 * lread.c (readchar, read1):
3911 * print.c (Fprin1_to_string):
3912 * xdisp.c (push_message):
3913 Use bool for booleans affected directly or indirectly by
3914 alloc.c's changes.
3915
d0d2d26f
PE
3916 Make recently-introduced setters macros.
3917 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
3918 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
3919 (set_fontset_default, set_fontset_fallback): Rename from their
3920 upper-case counterparts, and make them functions rather than macros.
3921 This is more consistent with the other recently-introduced setters.
3922 These don't need to be inline, since they're local.
3923
d18e2bb6
JD
39242012-08-21 Jan Djärv <jan.h.d@swipnet.se>
3925
3926 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
3927 the loop (Bug#12247).
3928
1b9d9d16
PE
39292012-08-21 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * lisp.h (vcopy): Use memcpy rather than our own loop.
3932 This fixes a performance regression introduced by the recent
3933 addition of vcopy. This means 'vcopy' will need to be modified
3934 for a copying collector, but that's OK. Also, tighten the
3935 checking in the assertion.
3936
b2f09701
EZ
39372012-08-21 Eli Zaretskii <eliz@gnu.org>
3938
3939 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
3940 components for RTL text (Bug#11860). Adjust X-OFFSET of each
3941 non-base glyph for the width of the base character, according to
e1f29348
BR
3942 what x_draw_composite_glyph_string_foreground expects.
3943 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
3944 expectations, to produce correct width of the composed character.
3945 Reverse the sign of the DU offset produced by ScriptPlace.
3946
9b994fed
PE
39472012-08-21 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
3950
086ca913
DA
39512012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
3952
3953 Avoid direct writes to contents member of struct Lisp_Vector.
3954 * lisp.h (vcopy): New function to copy data into vector.
3955 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
3956 * fns.c (Ffillarray): Use ASET.
3957 * keyboard.c (timer_check_2): Use AREF and ASET.
3958 (append_tool_bar_item, Frecent_keys): Use vcopy.
3959 * lread.c (read_vector): Use ASET.
3960 * msdos.c (Frecent_doskeys): Use vcopy.
3961 * xface.c (Finternal_copy_lisp_face): Use vcopy.
3962 (Finternal_merge_in_global_face): Use ASET and vcopy.
3963 * xfont.c (xfont_list_pattern): Likewise.
3964
5481664a
MR
39652012-08-21 Martin Rudalics <rudalics@gmx.at>
3966
3967 * window.c (Fwindow_point): For the selected window always return
3968 the position of its buffer's point.
3969 (Fset_window_point): For the selected window always go in its
3970 buffer to the specified position.
3971
6d470bdd
DA
39722012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
3973
3974 Setter macros for fontsets.
3975 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
3976 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
3977 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
3978 Adjust users.
3979
24564fe1
GM
39802012-08-20 Glenn Morris <rgm@gnu.org>
3981
3982 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3983 Don't assume that `ln -f' works.
3984
0a05a035
EZ
39852012-08-20 Eli Zaretskii <eliz@gnu.org>
3986
3987 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
3988 and later about non-assignments with no effect. See discussion at
3989 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
3990 details.
3991
e46f2325
DA
39922012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3993
3994 Inline setter functions for Lisp_Objects slots of struct specbinding.
3995 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
3996 Adjust users.
3997
734fbd86
MR
39982012-08-20 Martin Rudalics <rudalics@gmx.at>
3999
4000 * window.c (select_window): Always make selected window's buffer
4001 current.
4002
f1a95992
DA
40032012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
4004
4005 Use AREF and ASET for docstrings of category tables.
4006 * category.h (CATEGORY_DOCSTRING): Use AREF.
4007 (SET_CATEGORY_DOCSTRING): Use ASET.
4008 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
4009
e83064be
DA
40102012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
4011
4012 Inline setter functions for hash table members.
4013 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
4014 (set_hash_hash, set_hash_index): Rename with _slot suffix.
4015 (set_hash_key_and_value, set_hash_index, set_hash_next)
4016 (set_hash_hash): New functions.
4017 * charset.c, fns.c: Adjust users.
4018
4ce60d2e
DA
40192012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
4020
4021 Inline getter and setter functions for per-buffer values.
4022 * buffer.h (per_buffer_default, set_per_buffer_default)
4023 (per_buffer_value, set_per_buffer_value): New functions.
4024 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
4025 * buffer.c, data.c: Adjust users.
4026
c06c9690
JB
40272012-08-20 Juanma Barranquero <lekktu@gmail.com>
4028
4029 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
4030
32bd4250
PE
40312012-08-19 Paul Eggert <eggert@cs.ucla.edu>
4032
bad03192 4033 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
4034 as gnulib does this if the system doesn't.
4035 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
4036 Remove declaration. MS-Windows declares it on stdlib.h which is
4037 included by conf_post.h.
b69a6d22
PE
4038 * emacs.c (environ) [DOUG_LEA_MALLOC]:
4039 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
4040 * vm-limit.c: Include <unistd.h>, for 'environ'.
4041
22d7feb2
PE
4042 * unexaix.c, unexcoff.c: Include "mem-limits.h".
4043 (start_of_data): Remove decl; mem-limits.h provides it.
4044
32bd4250
PE
4045 * xdisp.c (handle_invisible_prop): Make it a bit faster
4046 and avoid a gcc -Wmaybe-uninitialized diagnostic.
4047
450809af
CY
40482012-08-19 Chong Yidong <cyd@gnu.org>
4049
4050 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
4051 ends (Bug#3874).
4052
9e677988
AS
40532012-08-19 Andreas Schwab <schwab@linux-m68k.org>
4054
6b1319ce
AS
4055 * .gdbinit: Use call instead of set when calling a function in the
4056 inferior.
4057
9e677988
AS
4058 * data.c (set_internal): Don't use set_blv_found.
4059 (Fkill_local_variable): Likewise.
4060
d7191076
AA
40612012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
4062
4063 * nsfont.m (ns_ascii_average_width): Ensure the string
4064 ascii_printable is initialized with a null-terminated character
4065 array. Otherwise, it can contain undesired extra characters.
4066
e757f1c6
PE
40672012-08-18 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 port new setting code to Sun C 5.8 2005/10/13
4070 * chartab.c, lisp.h (char_table_set, char_table_set_range):
4071 Return void, not Lisp_Object. Otherwise, the compiler
4072 complains about (A?B:C) where B is void and C is Lisp_Object
4073 when compiling CHAR_TABLE_SET, due to the recent change to
4074 the API of sub_char_table_set_contents.
4075
a999ce26
CY
40762012-08-18 Chong Yidong <cyd@gnu.org>
4077
4078 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
4079 for the string case (Bug#3874).
4080
3f22b86f
PE
40812012-08-18 Paul Eggert <eggert@cs.ucla.edu>
4082
39eb03f1
PE
4083 * buffer.h (BSET): Remove (Bug#12215).
4084 Replace all uses with calls to new setter functions.
4085 (bset_bidi_paragraph_direction, bset_case_canon_table)
4086 (bset_case_eqv_table, bset_directory, bset_display_count)
4087 (bset_display_time, bset_downcase_table)
4088 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
4089 (bset_last_selected_window, bset_local_var_alist)
4090 (bset_mark_active, bset_point_before_scroll, bset_read_only)
4091 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
4092 (bset_width_table):
4093 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
4094 (bset_auto_fill_function, bset_auto_save_file_format)
4095 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
4096 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
4097 (bset_cache_long_line_scans, bset_case_fold_search)
4098 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
4099 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
4100 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
4101 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
4102 (bset_header_line_format, bset_indicate_buffer_boundaries)
4103 (bset_indicate_empty_lines, bset_invisibility_spec)
4104 (bset_left_fringe_width, bset_major_mode, bset_mark)
4105 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
4106 (bset_name, bset_overwrite_mode, bset_pt_marker)
4107 (bset_right_fringe_width, bset_save_length)
4108 (bset_scroll_bar_width, bset_scroll_down_aggressively)
4109 (bset_scroll_up_aggressively, bset_selective_display)
4110 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
4111 (bset_word_wrap, bset_zv_marker):
4112 * category.c (bset_category_table):
4113 * syntax.c (bset_syntax_table):
4114 New setter functions.
4115
6a09a33b
PE
4116 * process.h (PSET): Remove (Bug#12215).
4117 Replace all uses with calls to new setter functions.
4118 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4119 (PROCESS_INLINE): New macro.
4120 (pset_childp): New setter function.
4121 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
4122 * process.c (PROCESS_INLINE):
4123 Define to EXTERN_INLINE, so that the corresponding functions
4124 are compiled into code.
4125 (pset_buffer, pset_command, pset_decode_coding_system)
4126 (pset_decoding_buf, pset_encode_coding_system)
4127 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
4128 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
4129 (pset_type, pset_write_queue): New setter functions.
4130
e8c17b81
PE
4131 * window.h (WSET): Remove (Bug#12215).
4132 Replace all uses with calls to new setter functions.
4133 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4134 (WINDOW_INLINE): New macro.
4135 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
4136 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
4137 (wset_total_lines, wset_vertical_scroll_bar)
4138 (wset_window_end_pos, wset_window_end_valid)
4139 (wset_window_end_vpos): New setter functions.
4140 * window.c (WINDOW_INLINE):
4141 Define to EXTERN_INLINE, so that the corresponding functions
4142 are compiled into code.
4143 (wset_combination_limit, wset_dedicated, wset_display_table)
4144 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
4145 (wset_new_normal, wset_new_total, wset_next_buffers)
4146 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
4147 (wset_prev_buffers, wset_right_fringe_width)
4148 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
4149 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
4150 (wset_window_parameters):
4151 * xdisp.c (wset_base_line_number, wset_base_line_pos)
4152 (wset_column_number_displayed, wset_region_showing):
4153 New setter functions.
4154
3f22b86f
PE
4155 * termhooks.h (TSET): Remove (Bug#12215).
4156 Replace all uses with calls to new setter functions.
4157 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4158 (TERMHOOKS_INLINE): New macro.
4159 (tset_charset_list, tset_selection_alist): New setter functions.
4160 * terminal.c (TERMHOOKS_INLINE):
4161 Define to EXTERN_INLINE, so that the corresponding functions
4162 are compiled into code.
4163 (tset_param_alist): New setter function.
4164
742af32f
PE
41652012-08-17 Paul Eggert <eggert@cs.ucla.edu>
4166
15dbb4d6
PE
4167 * keyboard.h (KSET): Remove (Bug#12215).
4168 Replace all uses with calls to new setter functions.
4169 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4170 (KEYBOARD_INLINE): New macro.
4171 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
4172 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
4173 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
4174 New setter functions.
4175 * keyboard.c (KEYBOARD_INLINE):
4176 Define to EXTERN_INLINE, so that the corresponding functions
4177 are compiled into code.
4178 (kset_echo_string, kset_kbd_queue)
4179 (kset_keyboard_translate_table, kset_last_prefix_arg)
4180 (kset_last_repeatable_command, kset_local_function_key_map)
4181 (kset_overriding_terminal_local_map, kset_real_last_command)
4182 (kset_system_key_syms): New setter functions.
4183
f00af5b1
PE
4184 * frame.h (FSET): Remove (Bug#12215).
4185 Replace all uses with calls to new setter functions.
4186 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4187 (FRAME_INLINE): New macro.
4188 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
4189 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
4190 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
4191 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
4192 (fset_param_alist, fset_root_window, fset_scroll_bars)
4193 (fset_selected_window, fset_title, fset_tool_bar_items)
4194 (fset_tool_bar_position, fset_tool_bar_window): New functions.
4195 * frame.c (FRAME_INLINE):
4196 Define to EXTERN_INLINE, so that the corresponding functions
4197 are compiled into code.
4198 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
4199
0c94c8d6
PE
4200 A few more naming-convention fixes for getters and setters.
4201 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
4202 and rename from buffer_overlays_set_before.
4203 (set_buffer_overlays_after): Move here from buffer.h, and rename
4204 from buffer_overlays_set_after.
4205 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
4206 All uses changed.
4207 (set_buffer_intervals): Rename from buffer_set_intervals.
4208 * intervals.c (set_interval_object): Move here from intervals.h,
4209 and rename from interval_set_object.
4210 (set_interval_left): Move here from intervals.h, and rename from
4211 interval_set_left.
4212 (set_interval_right): Move here from intervals.h, and rename from
4213 interval_set_right.
4214 (copy_interval_parent): Move here from intervals.h, and rename from
4215 interval_copy_parent.
4216 * intervals.h (set_interval_parent): Rename from interval_set_parent.
4217 (set_interval_plist): Rename from interval_set_plist.
4218 Return void, not Lisp_Object, since no caller uses the result.
4219 * lisp.h (string_intervals): Rename from string_get_intervals.
4220 (set_string_intervals): Rename from string_set_intervals.
4221
34dabdb7
PE
4222 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
4223 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 4224 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
4225 All uses changed. See the end of
4226 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
4227
742af32f
PE
4228 * lisp.h (CSET): Remove (Bug#12215).
4229 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
4230 (set_char_table_purpose): New functions,
4231 replacing CSET. All uses changed. For example, replace
4232 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 4233 "set_char_table_parent (char_table, parent);".
742af32f
PE
4234 The old version was confusing because it used the same name
4235 'parent' for two different things.
4236
a04e2c62
DA
42372012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
4238
4239 Functions to get and set Lisp_Object fields of buffer-local variables.
4240 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
4241 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
4242 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
4243 * data.c, eval.c, frame.c: Adjust users.
4244
383dcbf9
CY
42452012-08-17 Chong Yidong <cyd@gnu.org>
4246
4247 * xfaces.c (merge_face_vectors): If the target font specfies a
4248 font spec, make the font's attributes take precedence over
4249 directly-specified attributes.
4250 (merge_face_ref): Recognize :font.
4251
44386687
DA
42522012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
4253
4254 Do not use memcpy for copying intervals.
4255 * intervals.c (reproduce_interval): New function.
4256 (reproduce_tree, reproduce_tree_obj): Use it.
4257 (reproduce_tree_obj): Remove prototype.
4258
927c7216
PE
42592012-08-17 Paul Eggert <eggert@cs.ucla.edu>
4260
4261 * lisp.h (duration_to_sec_usec): Remove unused decl.
4262
93044f7b
AA
42632012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
4264
4265 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
4266 to an allocated instance of NSString, not to the class itself.
4267
9851e4a5
JB
42682012-08-17 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * makefile.w32-in (C_CTYPE_H): New macro.
4271 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
4272 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
4273 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
4274
620f13b0
PE
42752012-08-16 Paul Eggert <eggert@cs.ucla.edu>
4276
4277 Use ASCII tests for character types.
4278 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
4279 * xfns.c, xterm.c:
4280 Don't include <ctype.h>; was not needed.
4281 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
4282 * sysdep.c, xfaces.c:
4283 Include <c-ctype.h> instead of <ctype.h>.
4284 * nsterm.m: Include <c-ctype.h>.
4285 * charset.c (read_hex):
4286 * doc.c (Fsnarf_documentation):
4287 * fileio.c (IS_DRIVE) [WINDOWSNT]:
4288 (DRIVE_LETTER) [DOS_NT]:
4289 (Ffile_name_directory, Fexpand_file_name)
4290 (Fsubstitute_in_file_name):
4291 * font.c (font_parse_xlfd, font_parse_fcname):
4292 * frame.c (x_set_font_backend):
4293 * gtkutil.c (xg_get_font):
4294 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
4295 * nsimage.m (hexchar):
4296 * nsterm.m (ns_xlfd_to_fontname):
4297 * sysdep.c (system_process_attributes):
4298 * xfaces.c (hash_string_case_insensitive):
4299 Use C-locale tests instead of locale-specific tests for character
4300 types, since we want the ASCII interpretation here, not the
4301 interpretation suitable for whatever happens to be the current locale.
4302
52162052
MR
43032012-08-16 Martin Rudalics <rudalics@gmx.at>
4304
4305 Consistently check windows for validity/liveness
4306 (Bug#11984, Bug#12025, Bug#12026).
4307 * lisp.h (CHECK_VALID_WINDOW): New macro.
4308 * window.c (decode_window): Rename to decode_live_window.
4309 (decode_valid_window, Fwindow_valid_p): New functions.
4310 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
4311 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
4312 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
4313 (Fwindow_prev_sibling, Fwindow_combination_limit)
4314 (Fset_window_combination_limit, Fwindow_use_time)
4315 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
4316 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
4317 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
4318 (Fwindow_hscroll, Fset_window_hscroll)
4319 (Fwindow_redisplay_end_trigger)
4320 (Fset_window_redisplay_end_trigger, Fwindow_edges)
4321 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
4322 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4323 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
4324 (Fwindow_end, Fset_window_point, Fset_window_start)
4325 (Fpos_visible_in_window_p, Fwindow_line_height)
4326 (Fwindow_dedicated_p, Fset_window_dedicated_p)
4327 (Fwindow_prev_buffers, Fset_window_prev_buffers)
4328 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
4329 (Fset_window_parameter, Fwindow_display_table)
4330 (Fset_window_display_table, Fdelete_other_windows_internal)
4331 (Fset_window_buffer, Fset_window_new_total)
4332 (Fset_window_new_normal, Fdelete_window_internal)
4333 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
4334 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
4335 (Fwindow_scroll_bars): Check whether argument window is a valid or
4336 live window. Update doc-strings.
4337 (syms_of_window): New symbol Qwindow_valid_p.
4338 * keyboard.c (Fposn_at_x_y): Check whether argument
4339 frame_or_window denotes a valid window.
4340
2751c80f
DA
43412012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
4342
4343 Fix previous char table change.
4344 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
4345 * chartab.c (optimize_sub_char_table): Likewise.
4346
032a42c8
CY
43472012-08-16 Chong Yidong <cyd@gnu.org>
4348
a2d19368
CY
4349 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
4350
032a42c8
CY
4351 * xfont.c (xfont_open):
4352 * xftfont.c (xftfont_open): Set the font's max_width field.
4353
4354 * nsfont.m (nsfont_open): Similar to the Xft backend, set
4355 min_width to space_width and average_width to the average over
4356 printable ASCII characters.
4357 (ns_char_width): Code cleanup.
4358 (ns_ascii_average_width): New utility function.
4359
4360 * font.h (struct font): Update comments.
4361
a098c930
DA
43622012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
4363
032a42c8 4364 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
4365 * lisp.h (CSET): New macro.
4366 (char_table_set_extras, char_table_set_contents)
4367 (sub_char_table_set_contents): New function.
4368 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
4369 * syntax.c: Adjust users.
4370
8be3a09c
SM
43712012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
4372
4373 * eval.c (eval_sub): Bind lexical-binding.
4374 * lread.c (Qlexical_binding): Make non-static.
4375
ac4845a6
JD
43762012-08-15 Jan Djärv <jan.h.d@swipnet.se>
4377
ddee6515
JD
4378 * nsmenu.m (popupSession): Remove.
4379 (pop_down_menu): Remove endModalSession.
4380 (timeout_handler:): New method.
4381 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
4382 Call runModalForWindow. Check timer_fired when it returns.
4383 If not set, cancel timer and break out of loop.
4384 Otherwise loop again, with a new timeout.
4385
4386 * nsterm.m: Include fcntl.h if present.
4387 (fd_entry, t_readfds, inNsSelect): Remove.
4388 (select_writefds, select_valid, select_timeout, selfds)
4389 (select_mutex, apploopnr): Add.
4390 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
4391 Otherwise call kbd_buffer_store_event.
4392 (ns_send_appdefined): Remove release of fd_entry.
4393 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
4394 Increment and decrement apploopnr.
4395 (ns_select): If no file descriptors, just do a NSTimer.
4396 Otherwise copy read/write masks and start select thread (fd_handler).
4397 Start main loop and wait for application defined event.
4398 Inform select thread to stop selecting after main loop is exited.
4399 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 4400 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
4401 (fd_handler:): Loop forever, wait for info from the main thread
4402 to either start or stop selecting. When select returns, send
4403 and appdefined event.
4404 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
4405 If not call kbd_buffer_store_event.
4406
4407 * nsterm.h (EmacsApp): fd_handler takes id argument.
4408 (EmacsDialogPanel): Add timer_fired and timeout_handler.
4409
ac4845a6
JD
4410 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
4411
eb424fe3
EZ
44122012-08-15 Eli Zaretskii <eliz@gnu.org>
4413
4414 * region-cache.c (move_cache_gap): Update gap_len using the actual
4415 growth of the boundaries array. Do not change cache_len.
4416 (Bug#12196)
4417
4e6a86c6
DA
44182012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
4419
4420 Generalize and cleanup font subsystem checks.
4421 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
4422 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
4423 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 4424
5bf192ca
DA
44252012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
4426
4427 * gtkutil.c (xg_get_font): Use pango_units_to_double.
4428
f2045622
CY
44292012-08-15 Chong Yidong <cyd@gnu.org>
4430
8be3a09c
SM
4431 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
4432 When using the new font chooser, use gtk_font_chooser_get_font_desc to
4433 extract the font descriptor instead of just the font name.
4434 In that case, return a font spec instead of a string.
f2045622
CY
4435 (x_last_font_name): Move to this file from xfns.c.
4436
4437 * xfns.c (Fx_select_font): The return value can also be a font
4438 spec. Move x_last_font_name management to gtkutil.c.
4439
4440 * xfaces.c: Make font weight and style symbols non-static.
4441
7f6feb56
SM
44422012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
4443
4444 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
4445 (bug#12117).
4446
fecbd8ff
SM
44472012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
4448
4449 * alloc.c (Fgarbage_collect): Use plural form consistently.
4450
9b8d5165
EZ
44512012-08-14 Eli Zaretskii <eliz@gnu.org>
4452
4453 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
4454 iteration through the command loop. Fixes a problem whereby mouse
4455 movements are ignored until the first mouse click.
4456
f5d9e83a
PE
44572012-08-14 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 Use bool, not int, for Lisp booleans.
4460 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
4461 makes Emacs a bit smaller and presumably a bit faster.
4462 * lisp.h: Include <stdbool.h>.
4463 (struct Lisp_Boolfwd, defvar_bool):
4464 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
4465 * regex.c [!emacs]: Include <stdbool.h>.
4466 (false, true): Remove; <stdbool.h> does this for us now.
4467
55802e4a
CY
44682012-08-14 Chong Yidong <cyd@gnu.org>
4469
4abcdac8
CY
4470 * character.c (Fcharacterp): Doc fix (Bug#12076).
4471
4472 * data.c (Findirect_variable): Doc fix (Bug#11040).
4473
55802e4a
CY
4474 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
4475
4476 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 4477 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 4478
8e99d072
BR
44792012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
4480
4481 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
4482 (bug#12022).
4483
08908aca
MR
44842012-08-14 Martin Rudalics <rudalics@gmx.at>
4485
4486 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
4487 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
4488 * minibuf.c (choose_minibuf_frame, read_minibuf):
4489 * w32fns.c (x_create_tip_frame):
4490 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
4491 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
4492
56120d6f
PE
44932012-08-14 Paul Eggert <eggert@cs.ucla.edu>
4494
4495 * intervals.c (offset_intervals): Remove obsolete comment.
4496
67b77c0b
AS
44972012-08-14 Andreas Schwab <schwab@linux-m68k.org>
4498
4499 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
4500
f48b82fd
GR
45012012-08-14 Gergely Risko <gergely@risko.hu>
4502
4503 * coding.c (decode_coding): Record buffer modification before
4504 disabling undo_list (Bug#11773).
4505
fd318b54
DA
45062012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
4507
4508 Revert and cleanup some recent overlay changes.
4509 * buffer.h (enum overlay_type): Remove.
4510 (buffer_get_overlays, buffer_set_overlays): Likewise.
4511 (buffer_set_overlays_before, buffer_set_overlays_after):
4512 New function. Adjust users.
4513 (unchain_both): Add eassert.
4514
41a62dd9
DA
45152012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
4516
4517 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
4518
5884c324
PE
45192012-08-14 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 * gtkutil.c (xg_mark_data): Don't assume C99.
4522
ca06f160
JD
45232012-08-13 Jan Djärv <jan.h.d@swipnet.se>
4524
4525 * gtkutil.c (xg_frame_tb_info): New struct.
4526 (TB_INFO_KEY): New define.
4527 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
4528 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
4529 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
4530 if not present.
4531 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 4532 is up to date. Otherwise store new data.
ca06f160
JD
4533 (free_frame_tool_bar): Free xg_frame_tb_info if present.
4534
7864a3f7
DA
45352012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
4536
4537 Use KSET for write access to Lisp_Object members of struct kboard.
4538 * keyboard.h (KSET): New macro.
4539 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
4540 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
4541 * xterm.c: Adjust users.
4542
4c31be61
DA
45432012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
4544
4545 Use BSET for write access to Lisp_Object members of struct buffer.
4546 * buffer.h (BSET): New macro.
4547 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
4548 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
4549 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
4550 * window.c, xdisp.c, xfns.c: Adjust users.
4551
14ae4239
BT
45522012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
4553
4554 * lread.c (syms_of_lread): Initialize Vlexical_binding.
4555
32bcadb4
JD
45562012-08-11 Jan Djärv <jan.h.d@swipnet.se>
4557
3d29b2ce 4558 * nsterm.m (not_in_argv): New function.
fc0c31f8 4559 (application:openFile, application:openTempFile:):
3d29b2ce
JD
4560 (application:openFileWithoutUI:, application:openFiles:): Open file
4561 if not_in_argv returns non-zero (bug#12171).
4562
32bcadb4 4563 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
4564 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
4565 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
4566 (xg_get_font_name): Use those functions/macros here.
4567 Reported by Frans Oilinki <moilinki@gmail.com>.
4568
9ff9402d 45692012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
4570
4571 * unexmacosx.c (copy_data_segment): Copy initialized data in
4572 statically linked libraries from input file rather than memory.
4573
db74a5fc
YM
4574 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
4575 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
4576 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
4577
25e65510
GM
45782012-08-10 Glenn Morris <rgm@gnu.org>
4579
4580 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
4581 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
4582
7961135c
DA
45832012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
4584
4585 Fix last change to allow compilation with low optimization levels.
4586 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
4587 Reported by Jan Djärv <jan.h.d@swipnet.se>.
4588
42b3a444
DA
45892012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
4590
4591 Use common inline syntax in intervals.h.
4592 * intervals.h (INTERVALS_INLINE): New macro.
4593 Change all users from LISP_INLINE.
4594
9fb0c957
DA
45952012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
4596
4597 Define Qnone once for all platforms.
4598 * frame.c (Qnone): Define here.
4599 (syms_of_frame): DEFSYM it.
4600 * lisp.h (Qnone): New declaration.
4601 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
4602 * xfns.c: Remove duplication. Adjust users.
4603
65e8ee52
DA
46042012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
4605
4606 Remove unused macros from intervals.h.
4607 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
4608 * intervals.c: Adjust comment.
4609
9b855fd6
EZ
46102012-08-10 Eli Zaretskii <eliz@gnu.org>
4611
4612 * w32fns.c <w32_unicode_gui>: New static variable.
4613 (globals_of_w32fns): Initialize it according to os_subtype.
4614 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
4615 testing os_subtype.
4616
39cb9e56 46172012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
4618 Eli Zaretskii <eliz@gnu.org>
4619
4620 Fix bug #10299 with Unicode characters sent by customized
4621 keyboards created by MSKLC.
4622 * w32fns.c (INIT_WINDOW_CLASS): New macro.
4623 (w32_init_class): Use it to initialize the Emacs class with either
4624 ANSI or Unicode API calls.
4625 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
4626 later.
4627 (w32_wnd_proc): If the character code sent by WM_CHAR or
4628 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
4629 original message. Call DefWindowProcW on NT and later.
4630
9374581a
GM
46312012-08-10 Glenn Morris <rgm@gnu.org>
4632
4b94e8cf
GM
4633 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
4634
9374581a
GM
4635 * lisp.h (DIRECTORY_SEP): Let configure set it.
4636
a2752828
DA
46372012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
4638
4639 Use TSET for write access to Lisp_Object slots of struct terminal.
4640 * termhooks.h (TSET): New macro.
4641 * coding.c, terminal.c, xselect.c: Adjust users.
4642
cc92c454
SM
46432012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
4644
4645 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
4646 the failing expression, include them in the error message.
4647 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
4648 * lisp.h (internal_condition_case_n): Update declaration.
4649
4cb3e6b3
DA
46502012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
4651
4652 Inline functions to examine and change buffer overlays.
4653 * buffer.c (unchain_both): New function.
4654 * buffer.h (buffer_get_overlays, buffer_set_overlays):
4655 (buffer_has_overlays): New function.
4656 (enum overlay_type): New enum.
4657 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
4658 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
4659
8707c1e5
DA
46602012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
4661
4662 Inline functions to examine and change buffer intervals.
4663 * alloc.c (mark_interval_tree): Remove.
4664 (MARK_INTERVAL_TREE): Simplify.
4665 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
4666 * intervals.c (buffer_balance_intervals): New function.
4667 (graft_intervals_into_buffer): Adjust indentation.
4668 (set_intervals_multibyte): Simplify.
4669 * buffer.h (BUF_INTERVALS): Remove.
4670 (buffer_get_intervals, buffer_set_intervals): New function.
4671 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
4672 * intervals.c, textprop.c: Adjust users.
4673
ad8c997f
DA
46742012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
4675
4676 Inline functions to examine and change string intervals.
4677 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
4678 (string_get_intervals, string_set_intervals): New function.
4679 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
4680 * lread.c, print.c, textprop.c: Adjust users.
4681
32ac3a6b
GM
46822012-08-08 Glenn Morris <rgm@gnu.org>
4683
4684 * lisp.mk (lisp): Remove language/persian.elc.
4685
77c7bcb1
DA
46862012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
4687
4688 Cleanup intervals.
4689 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
4690 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
4691 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
4692 Adjust comment. Move under #if 0.
77c7bcb1
DA
4693 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
4694 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
4695
9c08a8d4
DA
46962012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
4697
4698 Check total length of intervals with eassert.
4699 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
4700 * intervals.c: Change all users to eassert.
4701
26d16b35
EZ
47022012-08-07 Eli Zaretskii <eliz@gnu.org>
4703
14ae4239
BT
4704 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
4705 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
4706 INTERNAL_FIELD in Lisp_Cons.
4707
c644523b
DA
47082012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
4709
4710 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
4711 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
4712 name since all xname users are fixed long time ago. Do not
4713 use INTERNAL_FIELD.
4714 (set_symbol_name, set_symbol_function, set_symbol_plist):
4715 (set_symbol_next, set_overlay_plist): New function.
4716 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
4717 (struct Lisp_Overlay): Likewise.
4718 (CVAR, MVAR, SVAR): Remove.
4719 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
4720 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
4721 * xterm.c: Adjust users.
4722 * .gdbinit: Change to use name field of struct Lisp_Symbol
4723 where appropriate.
4724
6a3d20cc
DA
47252012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
4726
4727 Basic functions to set Lisp_Object and pointer slots of intervals.
4728 * intervals.h (interval_set_parent, interval_set_object):
4729 (interval_set_left, interval_set_right, interval_set_plist):
4730 (interval_copy_parent): New function.
4731 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
4732 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
4733 Adjust indentation.
6a3d20cc
DA
4734 (INTERVAL_SIZE): Remove. Adjust users.
4735 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
4736
4d2b044c
DA
47372012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
4738
4739 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
4740 * process.h (PGET): Remove.
4741 (struct Lisp_Process): Do not use INTERNAL_FIELD.
4742 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
4743
d3d50620
DA
47442012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
4745
4746 Drop WGET and revert read access to Lisp_Objects slots of struct window.
4747 * window.h (WGET): Remove.
4748 (struct window): Do not use INTERNAL_FIELD.
4749 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
4750 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
4751 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
4752 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
4753 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
4754 Adjust users.
4755
d10a51dc
CY
47562012-08-07 Chong Yidong <cyd@gnu.org>
4757
4758 * window.c (Fwindow_edges, Fwindow_pixel_edges)
4759 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
4760 (Fdelete_window_internal): Signal an error if the window is not on
4761 a live frame (Bug#12025).
4762
e69b0960
DA
47632012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
4764
4765 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
4766 * frame.h (FGET): Remove.
4767 (struct frame): Do not use INTERNAL_FIELD.
4768 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
4769 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
4770 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
4771 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
4772
25a20a3a
JB
47732012-08-06 Juanma Barranquero <lekktu@gmail.com>
4774
4775 * w32.c: Silence compiler warnings.
4776 (map_w32_filename): Remove unused variable `is_fat'.
4777 (chase_symlinks): Add parentheses around expression.
4778
1c6f11f4
GM
47792012-08-06 Glenn Morris <rgm@gnu.org>
4780
1db4583a
GM
4781 * sysdep.c: Respect BROKEN_GETWD.
4782
1c6f11f4
GM
4783 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
4784 Let configure handle it.
4785 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
4786
2b90362b
DA
47872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4788
4789 Use GCALIGNMENT where appropriate.
4790 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
4791 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
4792 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
4793
5f50daf2
EZ
47942012-08-06 Eli Zaretskii <eliz@gnu.org>
4795
14ae4239
BT
4796 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
4797 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 4798
cbcc7007
SM
47992012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
4800
4801 * buffer.h (struct buffer): Revert `indirections' to a simple int;
4802 that should be sufficient for everyone.
4803
4d365fa4
JD
48042012-08-06 Jan Djärv <jan.h.d@swipnet.se>
4805
4806 * keyboard.c (timer_check_2): Add break so timer_check returns next
4807 timeout.
4808
dd86bd82
DA
48092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4810
4811 Fix Windows build errors introduced after converting to WGET and WSET.
4812 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
4813 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
4814
054e1668
JD
48152012-08-06 Jan Djärv <jan.h.d@swipnet.se>
4816
4817 * nsterm.m (ns_frame_rehighlight): Use FSET.
4818
4819 * nsmenu.m (ns_update_menubar): Use FSET.
4820
21238f11
DA
48212012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4822
4823 Separate read and write access to Lisp_Object slots of Lisp_Process.
4824 * process.h (PGET, PSET): New macros similar to AREF and ASET.
4825 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
4826
077288cf
DA
48272012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4828
4829 Separate read and write access to Lisp_Object slots of struct window.
4830 * window.h (WGET, WSET): New macros similar to AREF and ASET.
4831 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
4832 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
4833 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
4834 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
4835 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
4836 Adjust users.
4837
71688bd7
DA
48382012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4839
4840 Fix Windows build errors introduced after converting to FGET and FSET.
4841 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
4842 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
4843 (w32_judge_scroll_bars): Change to use FSET.
4844 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
4845
f99bac93
DA
48462012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4847
4848 Fix replacement typo.
4849 * window.c (replace_window): Set root_window instead of
4850 selected_window. This fixes a total window subsystem
4851 malfunction reported by Bastien Guerry <bzg@gnu.org>.
4852
8c2a0f2d
GM
48532012-08-06 Glenn Morris <rgm@gnu.org>
4854
4855 * lisp.mk (lisp): Add language/persian.elc.
4856
edd74c35
DA
48572012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
4858
4859 Separate read and write access to Lisp_Object slots of struct frame.
4860 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
4861 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
4862 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
4863 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
4864 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
4865
8671676c
AS
48662012-08-05 Andreas Schwab <schwab@linux-m68k.org>
4867
4868 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
4869
663e2b3f
DA
48702012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
4871
4872 Generalize common compile-time constants.
4873 * lisp.h (header_size, bool_header_size, word_size): Now here.
4874 (struct Lisp_Vector): Add comment.
4875 (struct Lisp_Bool_Vector): Move up to define handy constants.
4876 (VECSIZE, PSEUDOVECSIZE): Simplify.
4877 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
4878 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
4879 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
4880 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
4881 * xfont.c, xmenu.c: Use word_size where appropriate.
4882
d32e47af
LM
48832012-08-05 Lawrence Mitchell <wence@gmx.li>
4884
4885 * search.c (Freplace_match): Treat \? in the replacement text
4886 literally (Bug#8161).
4887
e5d9c0d1
CY
48882012-08-05 Chong Yidong <cyd@gnu.org>
4889
4890 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
4891 * frame.c (Vdelete_frame_functions):
4892 * emacs.c (Vkill_emacs_hook): Doc fix.
4893
8da0576b
EZ
48942012-08-04 Eli Zaretskii <eliz@gnu.org>
4895
4896 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
4897 --with-x-toolkit=no builds.
4898 Reported by Carsten Mattner <carstenmattner@gmail.com>.
4899
02676e5d
CY
49002012-08-04 Chong Yidong <cyd@gnu.org>
4901
4902 * syntax.c (Fmodify_syntax_entry): Doc fix.
4903
97147da9
EZ
49042012-08-04 Eli Zaretskii <eliz@gnu.org>
4905
76151e2c
EZ
4906 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
4907 * w32.c (init_environment): Change the default values of many
4908 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
4909 them into environment when they were not already defined.
4910 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 4911 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
4912 (check_windows_init_file): Now external, not static.
4913 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
4914 called when Vload_path is already set up.
4915
4916 * w32.h (check_windows_init_file): Add prototype.
4917
4918 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
4919 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
4920 compatibility with Posix platforms.
4921 (main): Move the call to check_windows_init_file to here from
4922 w32.c.
4923 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
4924 any, in the DEFALT argument into the root of the Emacs build or
4925 installation tree, as appropriate.
4926
4927 * callproc.c (init_callproc_1): Call decode_env_path instead of
4928 doing its equivalent by hand.
4929 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
4930 the code that sets Vexec_path run on MS-Windows.
4931
4932 * lread.c (init_lread): Add comments to #ifdef's.
4933
97147da9
EZ
4934 * msdos.c (dos_set_window_size, IT_update_begin)
4935 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
4936 instead of direct references.
4937
185ee146
PE
49382012-08-04 Paul Eggert <eggert@cs.ucla.edu>
4939
4940 Export DEFAULT_REHASH_* to GDB.
4941 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
4942 Now constants, not macros.
4943
8834c57a
PE
49442012-08-03 Paul Eggert <eggert@cs.ucla.edu>
4945
98c6f1e3
PE
4946 Remove unnecessary casts involving pointers.
4947 These casts are no longer needed now that we assume C89 or later,
4948 since they involve casting to or from void *.
4949 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
4950 (make_pure_float, make_pure_vector):
4951 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
4952 * macros.c (Fstart_kbd_macro):
4953 * menu.c (find_and_return_menu_selection):
4954 * minibuf.c (read_minibuf_noninteractive):
4955 * sysdep.c (closedir):
4956 * xdisp.c (x_produce_glyphs):
4957 * xfaces.c (compare_fonts_by_sort_order):
4958 * xfns.c (x_real_positions, select_visual):
4959 * xselect.c (x_stop_queuing_selection_requests)
4960 (x_get_window_property, x_get_window_property_as_lisp_data):
4961 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
4962 Remove unnecessary pointer casts.
4963 * alloc.c (record_xmalloc): New function.
4964 * lisp.h (record_xmalloc): New decl.
4965 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
4966 more like a function. This is because the pointer cast is not
4967 needed. All uses changed.
4968 * print.c (print_string, print_error_message): Avoid length recalc.
4969
8834c57a
PE
4970 Improve fix for macroexp crash with debugging (Bug#12118).
4971 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
4972 ARRAY_MARK_FLAG when checking subscripts, because ASET is
4973 not supposed to be invoked from the garbage collector.
4974 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
4975 (gc_aset): New function, which is like ASET but can be
4976 used in the garbage collector.
4977 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
4978 (set_hash_index): Use it instead of ASET.
4979
6dad7178
EZ
49802012-08-03 Eli Zaretskii <eliz@gnu.org>
4981
4982 Support symlinks on latest versions of MS-Windows.
4983 * w32.c: Include winioctl.h and aclapi.h.
4984 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
4985 (revert_to_self): Forward declarations of static functions.
4986 <static BOOL g_b_init_get_security_info>:
4987 <g_b_init_create_symbolic_link>: New static flags.
4988 (globals_of_w32): Initialize them to zero.
4989 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
4990 (map_w32_filename): Improve commentary. Simplify switch.
4991 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
4992 headers (most versions of MinGW w32api don't).
4993 (get_security_info, create_symbolic_link)
4994 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
4995 New functions.
4996 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
4997 in the argument file name.
4998 (sys_access): Call unc_volume_file_attributes only if
4999 GetFileAttributes fails with network-related error codes.
5000 (sys_rename): Diagnose renaming of a symlink when the user doesn't
5001 have the required privileges.
14ae4239 5002 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
5003 get_file_security_desc.
5004 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
5005 with addition of handling of symlinks and support for 'lstat'.
5006 If possible, get file's attributes and security information by
6dad7178
EZ
5007 handle, not by name. Produce S_IFLNK bit for symlinks, when
5008 called from 'lstat'.
5009 (stat, lstat): New functions, call 'stat_worker'.
5010 (symlink, readlink, careadlinkat): Rewritten to create and resolve
5011 symlinks when the underlying filesystem supports them.
5012
f162bcc3
PE
50132012-08-02 Paul Eggert <eggert@cs.ucla.edu>
5014
79ea6c20
PE
5015 Fix macroexp crash on Windows with debugging (Bug#12118).
5016 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
5017 checking subscripts; problem introduced with the recent
5018 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
5019 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
5020 since it's used in non-static inline functions now.
5021
c0ce93fd
PE
5022 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
5023 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 5024
f162bcc3
PE
5025 Use C99-style 'extern inline' if available.
5026 * buffer.h (BUFFER_INLINE):
5027 * category.h (CATEGORY_INLINE):
5028 * character.h (CHARACTER_INLINE):
5029 * charset.h (CHARSET_INLINE):
5030 * composite.h (COMPOSITE_INLINE):
5031 * dispextern.h (DISPEXTERN_INLINE):
5032 * lisp.h (LISP_INLINE):
5033 * systime.h (SYSTIME_INLINE):
5034 New macro, replacing 'static inline' in this header.
5035 * buffer.h, category.h, character.h, charset.h, composite.h:
5036 * dispextern.h, lisp.h, systime.h:
5037 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
5038 * alloc.c (LISP_INLINE):
5039 * buffer.c (BUFFER_INLINE):
5040 * category.c (CATEGORY_INLINE):
5041 * character.c (CHARACTER_INLINE):
5042 * charset.c (CHARSET_INLINE):
5043 * composite.c (COMPOSITE_INLINE):
5044 * dispnew.c (DISPEXTERN_INLINE):
5045 * sysdep.c (SYSTIME_INLINE):
5046 Define to EXTERN_INLINE, so that the corresponding functions
5047 are compiled into code.
5048 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
5049 (INLINE_HEADER_END): New macros.
5050 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
5051 since it's used in non-static inline functions now.
a8333d03 5052 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 5053
837b365b
GM
50542012-08-02 Glenn Morris <rgm@gnu.org>
5055
d66b744d
GM
5056 * s/: Remove empty directory.
5057
837b365b
GM
5058 * s/ms-w32.h: Move to ../nt/inc.
5059 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
5060 Update for new ms-w32.h location.
5061
13294f95
PE
50622012-08-02 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 Port to Solaris 8.
5065 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
5066
90df0db3
GM
50672012-08-02 Glenn Morris <rgm@gnu.org>
5068
5069 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
5070 hard-coding the path separator.
5071
4939150c
PE
50722012-08-01 Paul Eggert <eggert@cs.ucla.edu>
5073
5074 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
5075 This how ASET and AREF are supposed to work, and makes
5076 it easier to think about future improvements. See
5077 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
5078 * charset.h (set_charset_attr): New function.
5079 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
5080 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
5081 (aref_addr): New function. All uses of &AREF(...) changed.
5082 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
5083 (set_hash_index): New functions. All lvalue-style uses of
5084 HASH_KEY etc. changed.
5085 * keyboard.c (set_prop): New function. All lvalue-style uses
5086 of PROP changed.
5087
947b2afd
AA
50882012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
5089
5090 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
5091 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1f9f395d 5092 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
947b2afd
AA
5093 * nsfns.m (ns_set_name_as_filename): Likewise.
5094 * nsmenu.m (ns_update_menubar): Likewise.
5095 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
5096
4f5d0325
EZ
50972012-08-01 Eli Zaretskii <eliz@gnu.org>
5098
2008beae
EZ
5099 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
5100 Adapt to latest changes in field names of the corresponding Lisp
288479f6 5101 objects.
2008beae 5102
4f5d0325
EZ
5103 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
5104
fe3cc771
GM
51052012-08-01 Glenn Morris <rgm@gnu.org>
5106
5107 * s/msdos.h: Remove file.
5108 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
5109 * Makefile.in (S_FILE): Remove.
5110 (config_h): Remove S_FILE.
5111
c90acc54
JB
51122012-08-01 Juanma Barranquero <lekktu@gmail.com>
5113
5114 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
5115 Remove; moved to nt/config.nt.
5116
d8a05828
DA
51172012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
5118
5119 Use INTERNAL_FIELD for conses and overlays.
5120 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
5121 Remove obsolete comment.
5122 (MVAR): New macro.
5123 (struct Lisp_Overlay): Use INTERNAL_FIELD.
5124 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
5125
8271d590
DA
51262012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
5127
5128 Use INTERNAL_FIELD for symbols.
5129 * lisp.h (SVAR): New macro. Adjust users.
5130 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
5131 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
5132
3193acd2
DA
51332012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
5134
5135 Use INTERNAL_FIELD for processes.
5136 * process.h (PVAR): New macro. Adjust style.
5137 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
5138 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
5139
3a45383a
DA
51402012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
5141
5142 Use INTERNAL_FIELD for windows.
5143 * window.h (WVAR): New macro.
5144 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
5145 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
5146 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
5147 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
5148 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
5149 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
5150
c1dbc63c
PE
51512012-08-01 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
5154
5c0c0e8a
GM
51552012-08-01 Glenn Morris <rgm@gnu.org>
5156
5157 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
5158 Move to configure.ac.
5159
552a99b4
JB
51602012-08-01 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * makefile.w32-in (CONFIG_H): Update dependencies.
5163 (CONF_POST_H): New macro.
5164
5165 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
5166
8d8e2dfe
GM
51672012-07-31 Glenn Morris <rgm@gnu.org>
5168
bc96620a
GM
5169 * Makefile.in (S_FILE): No longer set by configure.
5170
476b1b2d
GM
5171 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
5172 is available.
5173 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
5174
b2c7a106
GM
5175 * process.h (NULL_DEVICE):
5176 * emacs.c (SEPCHAR):
5177 * editfns.c (USER_FULL_NAME): Let configure set them.
5178
d53d062a
GM
5179 * s/README, s/template.h: Remove files.
5180
4515017f
GM
5181 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
5182
8d8e2dfe
GM
5183 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
5184 Move to configure.ac.
5185
5b20b3cc
EZ
51862012-07-31 Eli Zaretskii <eliz@gnu.org>
5187
1e0afd9a
EZ
5188 * .gdbinit (xframe): Adapt to introduction of FVAR and the
5189 resulting renaming of 'struct frame' members.
5190
5b20b3cc
EZ
5191 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
5192
5193 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
5194 after introduction of FVAR.
5195
f1310128
JD
51962012-07-31 Jan Djärv <jan.h.d@swipnet.se>
5197
79e721e0
JD
5198 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
5199
5200 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
5201 instead of compositeToPoint.
5202 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
5203
8d7c7eed 5204 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 5205
e34f7f79
DA
52062012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
5207
5208 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
5209 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 5210 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
5211 (BVAR): Change to use INTERNAL_FIELD.
5212 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
5213 (KVAR): Change to use INTERNAL_FIELD.
5214 * frame.h (FVAR): New macro.
5215 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
5216 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
5217 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
5218 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
5219 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
5220
c09bfb2f
DA
52212012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
5222
5223 Miscellaneous fixes for non-default X toolkits.
5224 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
5225 * xterm.c (x_frame_of_widget): Remove redundant prototype.
5226 Move under #ifdef USE_LUCID.
5227 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
5228 definition and usage to avoid warnings.
5229
14c114ae
JD
52302012-07-31 Jan Djärv <jan.h.d@swipnet.se>
5231
5232 * nsterm.m (openFiles): Fix previous checkin.
5233
3bd21e82
PE
52342012-07-31 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * indent.c (compute_motion): Remove unused local.
5237
c1529ded
GM
52382012-07-31 Glenn Morris <rgm@gnu.org>
5239
400d5621
GM
5240 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
5241
268e2432
GM
5242 * conf_post.h [USG5_4]:
5243 Move remaining contents of s/usg5-4-common.h here.
5244 * s/usg5-4-common.h: Remove file.
5245
7552f3ee
GM
5246 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
5247 * s/irix6-5.h: Remove file.
5248
6a381852
GM
5249 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
5250 * s/darwin.h: Remove file.
5251
c1529ded
GM
5252 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
5253 * s/hpux10-20.h: Remove file, which is now empty.
5254
b429a4ee
GM
52552012-07-30 Glenn Morris <rgm@gnu.org>
5256
5257 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
5258 * Makefile.in (config_h): Add conf_post.h.
5259 * makefile.w32-in (CONFIG_H): Add conf_post.h.
5260
adff3182
JD
52612012-07-30 Jan Djärv <jan.h.d@swipnet.se>
5262
5263 * nsterm.m (ns_do_open_file): New variable.
b9031d69 5264 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
5265 (openFile, openTempFile, openFileWithoutUI, openFiles):
5266 Open files only if ns_do_open_file.
adff3182 5267
c32af1e4
PE
52682012-07-30 Paul Eggert <eggert@cs.ucla.edu>
5269
7393bcbb
PE
5270 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
5271 This no-op macro hasn't been needed for many years.
5272 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
5273
c32af1e4
PE
5274 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
5275 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
5276 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
5277 gdb_make_enums_visible.
5278 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
5279 (DIRECTORY_SEP): Now a constant, not a macro.
5280
302fc036
EZ
52812012-07-30 Eli Zaretskii <eliz@gnu.org>
5282
5283 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
5284 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
5285
5286 * w32term.c <w32_keyboard_codepage>: Renamed from
5287 keyboard_codepage and now external. All users changed.
5288
5289 * w32term.h: Add declaration of w32_keyboard_codepage.
5290
5291 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
5292 the codepage to translate keys to Unicode. If this argument is
5293 -1, use the value returned by GetConsoleCP. All callers changed.
5294
88fb40b4
PE
52952012-07-30 Paul Eggert <eggert@cs.ucla.edu>
5296
0aee6912
PE
5297 Update .PHONY listings in makefiles.
5298 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
5299 bootstrap-clean, distclean, maintainer-clean, versioclean,
5300 extraclean, frc.
5301
88fb40b4
PE
5302 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
5303 This is a bit clearer. Fix some commentary typos.
5304
0a763bd1
GM
53052012-07-30 Glenn Morris <rgm@gnu.org>
5306
32bac6d6
GM
5307 * s/netbsd.h: Let configure include signal.h if needed.
5308 Remove file, which is now empty.
5309
b65e7c46
GM
5310 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
5311 Let configure set them.
5312 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
5313 No more need to undefine.
0a763bd1 5314
169304bd
AS
53152012-07-30 Andreas Schwab <schwab@linux-m68k.org>
5316
5317 * keymap.c (Fkey_description): Don't remove 0x80 bit from
5318 non-single-byte char when adding meta modifier. (Bug#12090)
5319
6cd7a139
DA
53202012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
5321
5322 Convert safe_call to use variable number of arguments.
5323 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
5324 (safe_call2): Fix comment.
5325 * lisp.h (safe_call): Adjust prototype.
5326 * coding.c (encode_coding_object): Change to use safe_call2.
5327 * xfaces.c (merge_face_heights): Change to use safe_call1.
5328
d34d6ffc
GM
53292012-07-30 Glenn Morris <rgm@gnu.org>
5330
7b8a48e4 5331 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 5332 does that unconditionally. Remove file, which is now empty.
7b8a48e4 5333
d34d6ffc
GM
5334 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
5335 Remove empty files.
5336
03a660a6
PE
53372012-07-30 Paul Eggert <eggert@cs.ucla.edu>
5338
5339 Export to GDB most of lisp.h's remaining object-like macros.
5340 * lisp.h (min, max): Move earlier, because they're used earlier now.
5341 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
5342 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
5343 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
5344 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
5345 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
5346 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
5347 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
5348 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
5349 Now constants, for GDB. They need not be macros.
5350 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
5351 Now constants, for GDB, as well as macros, for static initializers.
5352 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
5353 Move to after the definition of struct Lisp_Char_Table,
5354 since the former now needs that type defined.
5355 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
5356 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
5357 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
5358 New enums, for gdb_make_enums_visible.
5359 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 5360 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
5361 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
5362 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
5363 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
5364 enum maxargs, enum MAX_ALLOCA.
5365 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
5366 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
5367 no longer needed, now that they are done in lisp.h.
5368
e499d0ee
DA
53692012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
5370
5371 Cleanup string bytes checking.
5372 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
5373 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
5374 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
5375 (check_sblock, compact_small_strings): Simplify.
5376
d5040d2d
PE
53772012-07-29 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
5380 These macros are confusing and no longer need to be defined, as
5381 the enum values now suffice. All uses replaced with definiens.
5382 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
5383
7f259ae6
JB
53842012-07-29 Juanma Barranquero <lekktu@gmail.com>
5385
5386 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
5387 ($(BLD)/w32console.$(O)): Update dependencies.
5388
7e63e0c3
DA
53892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
5390
5391 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
5392 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
5393 time. Adjust users.
5394 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
5395
ffd817eb
JD
53962012-07-29 Jan Djärv <jan.h.d@swipnet.se>
5397
5398 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
5399 setting sitelisp (Bug#12010).
5400
417a7a0e
EZ
54012012-07-29 Eli Zaretskii <eliz@gnu.org>
5402
14ae4239 5403 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
5404
5405 * w32heap.c (cache_system_info):
5406 * w32.c (sys_rename):
5407 * w32proc.c (find_child_console, sys_kill): All users changed.
5408
387d4d92
PE
54092012-07-29 Paul Eggert <eggert@cs.ucla.edu>
5410
5411 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
5412
55a6cca6
EZ
54132012-07-29 Eli Zaretskii <eliz@gnu.org>
5414
5415 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
5416
dbcf001c
DA
54172012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
5418
5419 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
5420 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
5421 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 5422
e2688e4a
DA
54232012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
5424
5425 Generalize marker debugging code under MARKER_DEBUG and use eassert.
5426 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
5427 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
5428 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
5429 (replace_range, replace_range_2, del_range_2): Change to eassert.
5430 * marker.c (byte_char_debug_check): Adjust style.
5431
b46a6a83
PE
54322012-07-29 Paul Eggert <eggert@cs.ucla.edu>
5433
5434 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
5435 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
5436 long-ago-commented-out code that talks about "WIN32".
5437 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
5438 All uses changed.
5439
e32a5799
PE
54402012-07-28 Paul Eggert <eggert@cs.ucla.edu>
5441
5442 Use Gnulib stdalign module (Bug#9772, Bug#9960).
5443 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
5444 Simplify by using alignof.
5445 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
5446 * lisp.h: Include <stdalign.h>.
5447 (GCALIGNMENT): New macro and constant.
5448 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
5449 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
5450 (stdalign): New macro, if not already defined.
5451
df81cd29
EZ
54522012-07-28 Eli Zaretskii <eliz@gnu.org>
5453
01bd1b0d
EZ
5454 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
5455 * w32inevt.c: Include w32inevt.h.
5456 (w32_read_console_input): New inline function, calls either
5457 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
5458 w32_console_unicode_input.
5459 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
5460 (w32_kbd_patch_key, key_event): Use the codepage returned by
5461 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
5462 (key_event): use uChar.UnicodeChar only if
5463 w32_console_unicode_input is non-zero.
5464
5465 * w32console.c: Include w32heap.h.
5466 <w32_console_unicode_input>: New global variable.
5467 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
5468 family of Windows, zero otherwise.
5469
5470 * w32inevt.h: Declare w32_console_unicode_input.
5471
df81cd29
EZ
5472 * xdisp.c (init_iterator): Don't reference tip_frame in a build
5473 --without-x. (Bug#11742)
5474
c20fdd9e
PE
54752012-07-27 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 Adjust GDB to reflect pvec_type changes (Bug#12036).
5478 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
5479 2012-07-04 changes to pseudovector representation.
5480 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 5481
32770973 54822012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
5483
5484 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
5485 bus address.
5486 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
5487
3438fe21
EZ
54882012-07-27 Eli Zaretskii <eliz@gnu.org>
5489
bcfbc9de
EZ
5490 * alloc.c (listn): Fix the order the arguments are consed onto the
5491 list.
5492
3438fe21
EZ
5493 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
5494 enumeration constants, as PURE and HEAP are too general, and clash
5495 with other headers and sources, such as gmalloc.c and the
5496 MS-Windows system headers. All users changed.
5497
eeaea515
DA
54982012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
5499
5500 Revert last save_excursion_save and save_excursion_restore changes.
5501 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
5502 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
5503
073c88c2
DA
55042012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
5505
5506 Fix recently-introduced typos in Windows port.
5507 Reported by Martin Rudalics <rudalics@gmx.at>.
5508 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 5509 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 5510
4706125e
PE
55112012-07-27 Paul Eggert <eggert@cs.ucla.edu>
5512
5513 Improve GDB symbol export (Bug#12036).
5514 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
5515 arms of an 'if', not using conditional expressions; otherwise GDB
5516 complains about the types in the unevaluated arm when the argument
5517 is an integer literal.
5518 (xgetint): Simplify expression.
5519 * alloc.c (gdb_make_enums_visible): New constant. This ports to
5520 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
5521 Zaretskii in <http://bugs.gnu.org/12036#13>.
5522 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
5523 needed now that we have gdb_make_enums_visible.
5524 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
5525 (enum enum_USE_LSB_TAG):
5526 New enum types, packaging up enums that need to be exported to GDB.
5527
694b6c97
DA
55282012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
5529
5530 Utility function to make a list from specified amount of objects.
5531 * lisp.h (enum constype): New datatype.
5532 (listn): New prototype.
5533 * alloc.c (listn): New function.
5534 (Fmemory_use_count, syms_of_alloc): Use it.
5535 * buffer.c (syms_of_buffer): Likewise.
5536 * callint.c (syms_of_callint): Likewise.
5537 * charset.c (define_charset_internal): Likewise.
5538 * coding.c (syms_of_coding): Likewise.
5539 * keymap.c (syms_of_keymap): Likewise.
5540 * search.c (syms_of_search): Likewise.
5541 * syntax.c (syms_of_syntax): Likewise.
5542 * w32.c (init_environment): Likewise.
5543 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
5544 * xdisp.c (syms_of_xdisp): Likewise.
5545 * xfns.c (syms_of_xfns): Likewise.
5546
6195f384
DA
55472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
5548
5549 Fast save_excursion_save and save_excursion_restore.
5550 * lisp.h (struct Lisp_Excursion): New data type.
5551 (PVEC_EXCURSION): New pseudovector type.
5552 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
5553 to deal with it. Adjust comments.
5554 (init_marker, attach_marker): New prototype.
5555 (unchain_marker): Adjust prototype.
5556 * marker.c (attach_marker): Change to global.
5557 (init_marker): New function.
5558 * alloc.c (Fmake_marker, build_marker): Use it.
5559 (build_marker): More easserts.
5560 (mark_object): Handle struct Lisp_Excursion.
5561 * editfns.c (save_excursion_save, save_excursion_restore):
5562 Reimplement to use struct Lisp_Excursion. Add comments.
5563
5eceb8fb
PE
55642012-07-26 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 Fix export of symbols to GDB (Bug#12036).
5567 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
5568 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
5569 emacs.c, as this is a more-suitable home. Had this been done earlier
5570 the fix for 12036 would have avoided some of the problems noted in
5571 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
5572 would have been more obvious.
562157c8
PE
5573 * emacs.c: Do not include <verify.h>; no longer needed.
5574 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
5575 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
5576 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
5577 Remove; now done in lisp.h.
5578 * lisp.h (PUBLISH_TO_GDB): New macro.
5579 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
5580 (DATA_SEG_BITS): Use it.
5581 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
5582 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
5583 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
5584 not be usable in #if. This simplifies things.
5585
d6749401
JB
55862012-07-26 Juanma Barranquero <lekktu@gmail.com>
5587
5588 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
5589
1781b9e9
PE
55902012-07-26 Paul Eggert <eggert@cs.ucla.edu>
5591
d89518db 5592 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
5593 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
5594 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
5595 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
5596 Adjust to changes in lisp.h and emacs.c, by using
5597 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
5598 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
5599 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
5600 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
5601 instead of gdb_valbits.
5602 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
5603 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
5604 instead of gdb_array_mark_flag.
5605 (xboolvector): Get size from $->size, not $->header.size.
5606 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
5607 (xreload, hook-run, hookpost-run): Remove.
5608 * emacs.c: Include <verify.h>.
5609 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
5610 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
5611 Remove.
5612 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
5613 (gdb_USE_LSB_TAG): New enum constants.
5614 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
5615 Also define these as enum constants, so they're visible to GDB.
5616 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
5617 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
5618 as constants, so they're visible to GDB.
5619 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
5620 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
5621 Now enum constants, not macros, so they're visible to GDB.
5622 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
5623 more convenient now. All uses changed.
5624 (VALMASK) [USE_LSB_TAG]: Also define in this case.
5625 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
5626
3628596a
DA
56272012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
5628
5629 Explicitly free restriction data that are not needed anymore.
5630 * editfns.c (save_restriction_restore): Free restriction data.
5631
7abaf5cc
SM
56322012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
5633
5634 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
5635 add argument, tune behavior, and adjust all callers.
5636
71f88e00
PE
56372012-07-25 Paul Eggert <eggert@cs.ucla.edu>
5638
5639 Use typedef for EMACS_INT, EMACS_UINT.
5640 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
5641 than macros. This simplifies debugging in the usual case, since
5642 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
5643 and it allows expressions involving EMACS_INT casts.
5644 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
5645
57ec3034
JD
56462012-07-25 Jan Djärv <jan.h.d@swipnet.se>
5647
5648 * nsterm.m (ns_read_socket): Return early if there is a modal
5649 window (Bug#12043).
5650
8137e7b3
MR
56512012-07-25 Martin Rudalics <rudalics@gmx.at>
5652
5653 * frame.c (Fredirect_frame_focus): In doc-string don't mention
5654 that FOCUS-FRAME can be omitted.
5655
04e9897c
DA
56562012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
5657
5658 Adjust buffer text indirection counters at the end of Fkill_buffer.
5659 * buffer.c (Fkill_buffer): Adjust indirection counters when the
5660 buffer is definitely dead. This should really fix an issue reported
5661 by Christoph Scholtes again. (Bug#12007).
5662 (init_buffer_once): Initialize indirection counters of
5663 buffer_defaults and buffer_local_symbols (for sanity and safety).
5664
8a0484e1
EZ
56652012-07-24 Eli Zaretskii <eliz@gnu.org>
5666
5667 * xdisp.c (init_iterator): Don't compute dimensions of truncation
5668 and continuation glyphs on tooltip frames, leave them at zero.
5669 Avoids continued lines in tooltips. (Bug#11832)
5670
fa691a83
DA
56712012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
5672
5673 Simplify copy_overlay.
04e9897c 5674 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
5675 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
5676
436bc8e0
EZ
56772012-07-23 Eli Zaretskii <eliz@gnu.org>
5678
5679 * print.c (print_object): Don't crash when a frame's name is nil
5680 or invalid. (Bug#12025)
5681
5682 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
5683 it signals an error when a tooltip frame is being created.
5684
d7a7fda3
DA
56852012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
5686
5687 Cleanup miscellaneous objects allocation and initialization.
5688 * alloc.c (allocate_misc): Change to static. Add argument to
5689 specify the subtype. Adjust comment and users.
5690 (build_overlay): New function.
5691 * buffer.c (copy_overlays, Fmake_overlay): Use it.
5692 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
5693 (allocate_misc): Remove prototype.
5694 (build_overlay): Add prototype.
5695
56962012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
5697
5698 Swap buffer text indirection counters in Fbuffer_swap_text.
5699 * buffer.c (Fbuffer_swap_text): Swap indirections too.
5700 This avoids crash reported by Christoph Scholtes at
5701 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
5702
9d7fa573
JD
57032012-07-22 Jan Djärv <jan.h.d@swipnet.se>
5704
5705 * nsmenu.m (Popdown_data): New struct.
5706 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
5707 free Popdown_data.
5708 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
5709 (initWithContentRect): Make imgView and contentView non-static
5710 and autorelease them. Also autorelease img and matrix (Bug#12005).
5711 (dealloc): Remove (Bug#12005).
5712
0dd6d66d
DA
57132012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
5714
5715 Adjust consing_since_gc when objects are explicitly freed.
5716 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
5717 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
5718 (free_cons, free_misc): Subtract object size from consing_since_gc.
5719
d36d71df
DA
57202012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
5721
5722 Simplify and cleanup markers positioning code.
5723 * marker.c (attach_marker): More useful eassert.
5724 (live_buffer, set_marker_internal): New function.
5725 (Fset_marker, set_marker_restricted): Use set_marker_internal.
5726 (set_marker_both, set_marker_restricted_both): Use live_buffer.
5727
fb9ea40f
PE
57282012-07-22 Paul Eggert <eggert@cs.ucla.edu>
5729
5730 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
5731 as it's limited by the amount of memory, not by INT_MAX.
5732
2d5c5f7d
EZ
57332012-07-21 Eli Zaretskii <eliz@gnu.org>
5734
07fb592e
EZ
5735 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
5736 in special-event-map. See the discussion at
5737 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
5738 for the reasons.
5739
37a9eac8 5740 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
5741 info.dwItemData. Fixes crashes on 64-bit Windows.
5742 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 5743
c4328746
JD
57442012-07-21 Jan Djärv <jan.h.d@swipnet.se>
5745
fc0c31f8 5746 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 5747 (conversationIdentifier): Return value is NSInteger.
784051c4 5748 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 5749
6e5d1c12
CY
57502012-07-21 Chong Yidong <cyd@gnu.org>
5751
5752 * window.c (decode_any_window): Signal an error if the window is
5753 on a dead frame (Bug#11984).
5754
9928463d
DA
57552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
5756
5757 Add indirection counting to speed up Fkill_buffer.
5758 * buffer.h (struct buffer): New member.
5759 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
5760 (Fmake_indirect_buffer): Set indirection counter to -1, increment
5761 base buffer indirection counter.
5762 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
5763 (Fkill_buffer): Adjust indirection counters as needed, don't walk
5764 through buffer list if indirection counter is 0.
5765
f8643a6b
DA
57662012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
5767
5768 Extend the value returned by Fgarbage_collect with heap statistics.
5769 * alloc.c (Qheap): New symbol.
5770 (syms_of_alloc): DEFSYM it.
5771 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
5772 (Fmemory_free): Remove.
5773 (syms_of_alloc): Don't defsubr it.
5774 * buffer.c (Fcompact_buffer): Remove.
5775 (syms_of_buffer): Don't defsubr it.
5776
dac616ff
DA
57772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
5778
5779 Make maybe_gc inline.
5780 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
5781 * lisp.h (consing_since_gc, gc_relative_threshold)
5782 (memory_full_cons_threshold): Revert declaration.
5783 (maybe_gc): Remove prototype, define as inline.
5784 * alloc.c: Remove old commented-out code.
5785 (consing_since_gc, gc_relative_threshold)
5786 (memory_full_cons_threshold): Revert to global.
5787 (maybe_gc): Remove.
5788
d7ea76b4
DA
57892012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
5790
5791 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
5792 * lisp.h (build_unibyte_string): New function.
5793 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
5794 * sysdep.c, w32fns.c, xfns.c: Use it.
5795 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
5796 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
5797 Adjust users accordingly.
5798 * font.h (font_open_by_name): Adjust prototype.
5799
765e61e3
DA
58002012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
5801
5802 Cleanup calls to Fgarbage_collect.
5803 * lisp.h (maybe_gc): New prototype.
5804 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
5805 Remove declarations.
5806 * alloc.c (maybe_gc): New function.
5807 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
5808 Make them static.
5809 * bytecode.c (MAYBE_GC): Use maybe_gc.
5810 * eval.c (eval_sub, Ffuncall): Likewise.
5811 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
5812 to avoid dependency from auto-save feature.
5813
52b852c7
PE
58142012-07-19 Paul Eggert <eggert@cs.ucla.edu>
5815
5816 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
5817 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
5818 'for_each_per_buffer_object_at'.
5819 All uses changed. It's better to use upper-case for macros that
5820 cannot be implemented as functions, to give the reader a clue
5821 that they're special.
5822
5db81e33
SM
58232012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
5824
5825 * alloc.c (Fgarbage_collect): Tweak docstring.
5826
5b835e1d
DA
58272012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
5828
5829 Tweak the value returned from Fgarbage_collect again.
5830 * alloc.c (Fgarbage_collect): New return value, as confirmed in
5831 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
5832 Adjust documentation.
5833 (total_vector_bytes): Rename to total_vector_slots, adjust
5834 accounting.
5835 (total_free_vector_bytes): Rename to total_free_vector_slots,
5836 adjust accounting.
5837 (Qstring_bytes, Qvector_slots): New symbols.
5838 (syms_of_alloc): DEFSYM them.
5839
9cd47b72
DA
58402012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
5841
5842 Buffer compaction primitive which may be used from Lisp.
5843 * buffer.c (compact_buffer, Fcompact_buffer): New function.
5844 (syms_of_buffer): Register Fcompact_buffer.
5845 * alloc.c (Fgarbage_collect): Use compact_buffer.
5846 * buffer.h (compact_buffer): New prototype.
5847 (struct buffer_text): New member.
5848
d17337e5
DA
58492012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
5850
5851 New macro to iterate over all buffers, miscellaneous cleanups.
5852 * lisp.h (all_buffers): Remove declaration.
5853 * buffer.h (all_buffers): Add declaration, with comment.
5854 (for_each_buffer): New macro.
5855 * alloc.c (Fgarbage_collect, mark_object): Use it.
5856 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
5857 (init_buffer): Likewise.
5858 * data.c (Fset_default): Likewise.
5859 * coding.c (code_conversion_restore): Remove redundant check
5860 for dead buffer.
5861 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
5862
60cfd278
AS
58632012-07-18 Andreas Schwab <schwab@linux-m68k.org>
5864
5865 Fix bug that created negative-length intervals.
5866 * intervals.c (merge_interval_right, merge_interval_left):
5867 Do not zero out this interval if it is absorbed by its children,
5868 as this interval's total length doesn't change in that case. See
5869 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
5870
d06714cb
PE
58712012-07-18 Paul Eggert <eggert@cs.ucla.edu>
5872
83713154
PE
5873 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
5874 when invoking (make-bool-vector N t) and N is a positive
5875 multiple of 8 -- the last 8 bits were mistakenly cleared.
5876
d06714cb
PE
5877 Remove some struct layout assumptions in bool vectors.
5878 * alloc.c (bool_header_size): New constant.
5879 (header_size, word_size): Move earlier, as they're now used earlier.
5880 Use 'word_size' in a few more places, where it's appropriate.
5881 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
5882 padding before the data member of a bool vector.
5883 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
5884 than doing the check by hand with an abort ().
5885
464d5a5e
SM
58862012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5887
5fbc0409
SM
5888 * eval.c (Fdefvar): Don't check constants since we only set the var if
5889 it's not yet defined anyway (bug#11904).
5890
464d5a5e
SM
5891 * lisp.h (last_undo_boundary): Declare new var.
5892 * keyboard.c (command_loop_1): Set it.
5893 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
5894 were auto-added by the command loop (bug#11774).
5895
8dc2e44a
AS
58962012-07-18 Andreas Schwab <schwab@linux-m68k.org>
5897
5898 * w32font.c (Qsymbol): Remove local definition.
5899 (syms_of_w32font): Don't DEFSYM it.
5900
169925ec
DA
59012012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
5902
5903 Fix sweep_vectors to handle large bool vectors correctly.
5904 * alloc.c (sweep_vectors): Account total_vector_bytes for
5905 bool vectors larger than VBLOCK_BYTES_MAX.
5906
5fbfb018
CY
59072012-07-18 Chong Yidong <cyd@gnu.org>
5908
5909 * frame.c (x_set_frame_parameters): Revert bogus change introduced
5910 in 2012-05-25 commit by Paul Eggert (Bug#11738).
5911
3ab6e069
DA
59122012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
5913
5914 Return more descriptive data from Fgarbage_collect.
5915 Suggested by Stefan Monnier in
5916 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
5917 * alloc.c (bounded_number): New function.
5918 (total_buffers, total_vectors): New variable.
5919 (total_string_size): Rename to total_string_bytes, adjust users.
5920 (total_vector_size): Rename to total_vector_bytes, adjust users.
5921 (sweep_vectors): Account total_vectors and total_vector_bytes.
5922 (Fgarbage_collect): New return value. Adjust documentation.
5923 (gc_sweep): Account total_buffers.
5924 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
5925 (VECTOR_SIZE): Remove.
5926 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
5927 (Qinterval, Qmisc): New symbols.
5928 (syms_of_data): Initialize them.
5929 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
5930 (Qcons, Qbuffer): New declarations.
5931
6d02fe5b
PE
59322012-07-17 Paul Eggert <eggert@cs.ucla.edu>
5933
5934 * alloc.c (Fmemory_free): Account for memory-free's own storage.
5935 Round up, not down. Improve doc.
5936
b7ffe040
DA
59372012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5938
5939 Restore old code in allocate_string_data to avoid Faset breakage.
5940 Reported by Julien Danjou <julien@danjou.info> in
5941 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
5942 * alloc.c (allocate_string_data): Restore old code with minor
5943 adjustments, fix comment to explain this subtle issue.
5944
4dc7c8d5
SM
59452012-07-17 Eli Zaretskii <eliz@gnu.org>
5946
5947 Remove FILE_SYSTEM_CASE.
5948 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
5949
5950 * fileio.c (FILE_SYSTEM_CASE): Don't define.
5951 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
5952 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
5953 call-process-region passes it through expand-file-name.
5954
5955 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
5956
59572012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5958
5959 Fix crash when creating indirect buffer (Bug#11917)
5960 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
5961 Don't handle unbound variables specially if non-zero.
5962 (Fbuffer_local_variables): Pass zero.
5963 (clone_per_buffer_values): Pass non-zero.
5964
59652012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5966
5967 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
5968 to make the loop interruptible.
5969
59702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5971
5972 * gnutls.c (emacs_gnutls_handshake): Only retry if
5973 GNUTLS_E_INTERRUPTED.
5974
cce7fefc
DA
59752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5976
5977 Cleanup and convert miscellaneous checks to eassert.
5978 * alloc.c (mark_interval): Fix comment, partially rephrase
5979 old comment from intervals.h (see below).
5980 * intervals.c (find_interval, adjust_intervals_for_insertion)
5981 (delete_interval, adjust_intervals_for_deletion)
5982 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
5983 Convert to eassert.
5984 (adjust_intervals_for_insertion, make_new_interval):
5985 Remove obsolete and unused code.
5986 * intervals.h (struct interval): Remove obsolete comment.
5987 * textprotp.c (erase_properties): Remove unused code.
5988 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
5989 (Fremove_list_of_text_properties): Convert to eassert.
5990
9ea10cc3
CY
59912012-07-17 Chong Yidong <cyd@gnu.org>
5992
5993 * editfns.c (Finsert_char): Doc fix.
5994
3900d5de
DA
59952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5996
5997 Fix previous change to make Fmemory_free always accurate.
5998 * alloc.c (make_interval): Update total_free_intervals.
5999 (make_float): Likewise for total_free_floats.
6000 (free_cons, Fcons): Likewise for total_free_conses.
6001 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
6002 Likewise for total_free_vector_bytes.
6003 (Fmake_symbol): Likewise for total_free_symbols.
6004 (bytes_free): Remove.
6005
7098646f
DA
60062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
6007
6008 Simple free memory accounting feature.
6009 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
6010 (sweep_vectors): Accumulate size of free vectors.
6011 (Fgarbage_collect): Setup bytes_free.
6012 (Fmemory_free): New function.
6013 (syms_of_alloc): Register it.
6014
22657b40
DA
60152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
6016
6017 Cleanup overlays checking.
6018 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
6019 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
6020 eassert and OVERLAYP.
6021 (sort_overlays): Change to use OVERLAYP.
6022
ddfc8813
RK
60232012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
6024
6025 * editfns.c (Finsert_char): Make it interactive, and make the
6026 second arg optional. Copy interactive spec and docstring from
6027 ucs-insert.
6028
7c26cf3c
PE
60292012-07-17 Paul Eggert <eggert@cs.ucla.edu>
6030
6031 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
6032 Unlike the other wrapped functions, fabs has an unspecified
6033 effect on errno.
6034
5d127af9
JD
60352012-07-16 Jan Djärv <jan.h.d@swipnet.se>
6036
6037 * nsterm.m (keyDown): Interpret flags without left/right bits
6038 as the left key (Bug#11670).
6039
6a0dd1d7
DA
60402012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
6041
6042 Remove empty and useless init functions.
6043 * lisp.h (init_character_once, init_fns, init_image)
6044 (init_filelock, init_sound): Remove prototype.
6045 * character.c (init_character_once): Remove.
6046 * filelock.c (init_filelock): Likewise.
6047 * fns.c (init_fns): Likewise.
6048 * image.c (init_image): Likewise.
6049 * sound.c (init_sound): Likewise.
6050 * emacs.c (main): Adjust accordingly.
6051
7a6136fd
DA
60522012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
6053
6054 * gtkutil.h: Tiny cleanups.
6055 (use_old_gtk_file_dialog): Remove useless declaration.
6056 (xg_uses_old_file_dialog): Add suggested const attribute.
6057
ce811ad9
EZ
60582012-07-15 Eli Zaretskii <eliz@gnu.org>
6059
6060 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
6061 (bidi_paragraph_init): Use it to limit search forward for a strong
6062 directional character in abnormally large paragraphs full of
6063 neutral or weak characters. (Bug#11943)
6064
c9adfeaa
SF
60652012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
6066
6067 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
6068 the toolbar (Bug#9451).
6069 (xg_make_tool_item): Give the widget event box a transparent
6070 background.
6071
fff62aa9
DA
60722012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
6073
6074 Cleanup basic allocation variables and functions.
6075 * alloc.c (ignore_warnings, init_intervals, init_float)
6076 (init_cons, init_symbol, init_marker): Remove.
6077 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
6078 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
6079 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
6080 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
6081 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
6082 (staticidx, init_alloc_once, init_strings, free_ablock):
6083 Remove redundant initialization.
6084 * fns.c (init_weak_hash_tables): Remove.
6085 * lisp.h (init_weak_hash_tables): Remove prototype.
6086
9730daca
DA
60872012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
6088
6089 Use zero_vector where appropriate.
6090 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
6091 accordingly.
6092 * lisp.h (zero_vector): New declaration.
6093 * font.c (null_vector): Remove.
6094 (syms_of_font): Remove initialization and staticpro.
6095 (font_list_entities, font_find_for_lface): Change to use zero_vector.
6096 * keymap.c (Faccessible_keymaps): Likewise.
6097
2e2d2a13
LL
60982012-07-15 Leo Liu <sdl.web@gmail.com>
6099
6100 * fringe.c: Fix typo in comments.
6101
cd276f6e
LL
61022012-07-14 Leo Liu <sdl.web@gmail.com>
6103
6104 * fringe.c: Add a new bitmap exclamation-mark.
6105
5a1131d9
EZ
61062012-07-14 Eli Zaretskii <eliz@gnu.org>
6107
6108 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
6109
6110 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
6111 (HAVE_MENUS): Don't define, defined by editing config.in with
6112 msdos/sed2v2.inp.
6113 (GMALLOC_INHIBIT_VALLOC): Don't define.
6114 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
6115
22e983b7
JB
61162012-07-14 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
6119
5b3f250f
GM
61202012-07-14 Glenn Morris <rgm@gnu.org>
6121
6122 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
6123 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
6124 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
6125
33d63ff4
GM
61262012-07-13 Glenn Morris <rgm@gnu.org>
6127
5b633342
GM
6128 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
6129
33d63ff4
GM
6130 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
6131 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
6132
b55b9f85
JD
61332012-07-13 Jan Djärv <jan.h.d@swipnet.se>
6134
0dc8cf50
JD
6135 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
6136 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
6137 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
6138 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
6139 where appropriate.
6140 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
6141 as boolean expression.
6142 (x_set_window_size): Remove unused variable toolbar.
6143 (ns_get_color_default, ns_mod_to_lisp): Remove.
6144 (ns_mouse_position): Remove unused variables xchar and ychar.
6145 (ns_compute_glyph_string_overhangs): Remove unused variable face.
6146 (ns_set_vertical_scroll_bar): Remove unused variable count.
6147 (ns_delete_terminal): Remove unused variable i.
6148 (ns_term_init): Remove unused variables r, g and b.
6149 (mouseDown): Remove unused variable window.
6150 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
6151 (initFrameFromEmacs): Remove unused variable vbextra.
6152 (mouseEntered): Remove unused variables p and dpyinfo.
6153 (mouseExited): Remove unused variables p and r.
6154 (ns_define_frame_cursor, ns_clear_frame_area)
6155 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
6156 (menuDown): Assign [sender tag] to variable and cast the variable.
6157
6158 * nsterm.h (menuDown): Add id as type to argument sender.
6159 (ns_display_info_for_name): Add Lisp_Object argument.
6160 (ns_term_init): Add Lisp_Object argument.
6161 (ns_map_event_to_object): Add void argument.
6162 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
6163 prototype with arguments and only declare if __OBJC__.
6164 (nxatoms_of_nsselect): Add void argument.
6165 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
6166 (ns_alloc_autorelease_pool): Add void argument.
6167 (ns_release_autorelease_pool): Add void* argument.
6168 (ns_get_defaults_value): Add const char* argument.
6169
6170 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
6171 (initFromContents): Use SSDATA where appropriate.
6172 (ns_update_menubar): Add braces to ambigous if-else.
6173 (initWithTitle): Put () around assignment in if statement.
6174 (ns_menu_show): Remove unused variables window and keymap.
6175 (update_frame_tool_bar): Remove unused variable selected_p.
6176 (initWithContentRect): Remove unused variable this_cmd_name.
6177
6178 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
6179 appropriate.
6180 (setXBMColor): Remove unused variable len.
6181 (setPixmapData): Put () around assignment in loop statement.
6182
6183 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
6184 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
6185 where appropriate.
6186 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
6187 around assignment in loop statement.
6188 (nsfont_open): Remove unused variable i.
6189 (nsfont_open): Remove unused variable len.
6190 (nsfont_draw): Remove unused variable cs.
6191
6192 * nsfns.m (x_set_icon_name, ns_set_name_internal)
6193 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
6194 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
6195 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
6196 (Fns_font_name, Fns_perform_service)
6197 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
6198 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
6199 (ns_set_name): Remove unused variable view.
6200 (x_set_menu_bar_lines): Remove unused variable olines.
6201 (x_set_tool_bar_lines): Remove unused variable root_window.
6202 (Fns_list_colors): Put () around assignment in while statement.
6203 (Fns_perform_service): Remove unused variable len.
6204 (Fns_display_usable_bounds): Remove unused variable top.
6205 (syms_of_nsfns): Remove unused variable i.
6206
b55b9f85
JD
6207 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
6208 memcpy (Bug#11907).
6209
ed9265fc 62102012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
6211
6212 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
6213 and free it with DestroyExceptionInfo (Bug#11558).
6214
ef099b57
JB
62152012-07-13 Juanma Barranquero <lekktu@gmail.com>
6216
6217 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
6218 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
6219 Set here, not in nt/config.nt.
6220
ea814a5d
EZ
62212012-07-13 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
6224 cursor overflow into the last glyph on display line when the right
6225 fringe is off. (Bug#11832)
6226
1a952767
PE
62272012-07-13 Paul Eggert <eggert@cs.ucla.edu>
6228
6229 * xdisp.c (produce_special_glyphs): Now static.
6230 * dispextern.h (produce_special_glyphs): Remove decl.
6231
983188fd
GM
62322012-07-13 Glenn Morris <rgm@gnu.org>
6233
8d7c7eed 6234 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
6235 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
6236
983188fd
GM
6237 * s/usg5-4-common.h (USG, USG5):
6238 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
6239 * s/sol2-6.h (SOLARIS2):
6240 * s/irix6-5.h (IRIX6_5):
6241 * s/hpux10-20.h (USG, USG5, HPUX):
6242 * s/gnu-linux.h (USG, GNU_LINUX):
6243 * s/freebsd.h (BSD_SYSTEM):
6244 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
6245 * s/cygwin.h (CYGWIN):
6246 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
6247 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
6248
d1e68667 62492012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
6250
6251 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 6252
6de0e799
GM
62532012-07-13 Glenn Morris <rgm@gnu.org>
6254
739ae010
GM
6255 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
6256
dbee5793
GM
6257 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
6258
6de0e799
GM
6259 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
6260 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
6261
b82da769
GM
62622012-07-12 Glenn Morris <rgm@gnu.org>
6263
4fae5a7a 6264 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
6265
6266 * process.c (init_process_emacs): Rename from init_process.
6267 The old name is also the name of a Mach system call.
6268 * lisp.h, emacs.c: Update for this name change.
6269 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
6270 longer needed.
6271
5a979817
EZ
62722012-07-12 Eli Zaretskii <eliz@gnu.org>
6273
6274 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
6275 memmove call that removes glyphs covered by the left truncation
6276 glyph. Improve commentary.
6277 (display_line): Fix display of continuation glyphs on GUI frames
6278 when the right fringe is turned off and variable-size fonts are
6279 used in the window. Move the code that appends a stretch glyph to
6280 produce_special_glyphs, so that it could be used for truncation
6281 and continuation glyphs alike.
6282 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
6283 glyph of a suitably computed width, to align the special glyphs at
6284 the window margin. Code moved from display_line. (Bug#11832)
6285
3e91a053
GM
62862012-07-12 Glenn Morris <rgm@gnu.org>
6287
ba9e4b84
GM
6288 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
6289
6290 * s/gnu-linux.h, s/hpux10-20.h:
6291 Do not unconditionally define HAVE_XRMSETDATABASE.
6292
3e91a053
GM
6293 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
6294
b300b1f4
PE
62952012-07-12 Paul Eggert <eggert@cs.ucla.edu>
6296
6297 Fix typos that broke OS X build.
6298 Reported by Randal L. Schwartz in
6299 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
6300 * nsterm.m (ns_timeout): Add missing local decl.
6301 (ns_get_color): snprintf -> sprintf, to fix typo.
6302
6e777848
GM
63032012-07-12 Glenn Morris <rgm@gnu.org>
6304
3f922c37
GM
6305 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
6306 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
6307 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
6308 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
6309
0ab7b23a
GM
6310 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
6311 Move PTY_OPEN to configure.
6312
6e777848
GM
6313 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6314 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
6315 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
6316
4a7edc24
DA
63172012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
6318
6319 Use empty_unibyte_string where applicable.
6320 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
6321 * lread.c (read1): Likewise.
6322 * xsettings.c (syms_of_xsettings): Likewise.
6323
308aab79
GM
63242012-07-12 Glenn Morris <rgm@gnu.org>
6325
42bd1719
GM
6326 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
6327 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
6328 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
6329 * s/hpux10-20.h (RUN_TIME_REMAP):
6330 * s/bsd-common.h (TABDLY): Move to configure.
6331
6332 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
6333
6334 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
6335
ea0bbd17 6336 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 6337 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
6338
6339 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 6340
308aab79
GM
6341 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
6342 * s/template.h: Move NARROWPROTO to configure.
6343
ee1cf5cf
GM
63442012-07-11 Glenn Morris <rgm@gnu.org>
6345
30fe9bf4
GM
6346 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
6347 unused since 2011-01-17 change to systty.h.
6348
ee1cf5cf
GM
6349 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
6350 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
6351 Move HAVE_PTYS and HAVE_SOCKETS to configure.
6352
63e47e07
PE
63532012-07-11 Paul Eggert <eggert@cs.ucla.edu>
6354
6355 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
6356
c43fb4c3
GM
63572012-07-11 Glenn Morris <rgm@gnu.org>
6358
6359 * s/darwin.h, s/gnu-linux.h, s/template.h:
6360 Move INTERRUPT_INPUT to configure.
6361
e8df9267
DA
63622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
6363
6364 Minor adjustments to interning code.
6365 * lisp.h (intern, intern_c_string): Redefine as static inline
6366 wrappers for intern_1 and intern_c_string_1, respectively.
6367 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
6368 * lread.c (intern_1, intern_c_string_1, oblookup):
6369 Simplify Vobarray checking.
e8df9267
DA
6370 * font.c (font_intern_prop): Likewise. Adjust comment.
6371 * w32font.c (intern_font_name): Likewise.
6372
34348bd4
AS
63732012-07-11 Andreas Schwab <schwab@linux-m68k.org>
6374
d96a1e0c
AS
6375 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
6376
34348bd4
AS
6377 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
6378 of Fcar/Fcdr if possible.
6379 * font.c (check_otf_features): Likewise.
6380 * fontset.c (Fnew_fontset): Likewise.
6381 * gnutls.c (Fgnutls_boot): Likewise.
6382 * minibuf.c (read_minibuf): Likewise.
6383 * msdos.c (IT_set_frame_parameters): Likewise.
6384 * xmenu.c (Fx_popup_dialog): Likewise.
6385 * w32menu.c (Fx_popup_dialog): Likewise.
6386
c8add24e
GM
63872012-07-11 Glenn Morris <rgm@gnu.org>
6388
4b575b3c
GM
6389 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
6390 since nothing has defined it on these platforms.
6391
09f4e3b0
GM
6392 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
6393 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
6394
172bedef
GM
6395 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6396 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
6397 Move CLASH_DETECTION to configure.
6398
249685df
GM
6399 * s/gnu.h: Remove file, which is now empty.
6400
c8add24e
GM
6401 * s/gnu.h, s/gnu-linux.h:
6402 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
6403
b41253a3
JW
64042012-07-11 John Wiegley <johnw@newartisans.com>
6405
6406 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
6407 function attribute, so we only use it if it exists in the
6408 compiler.
6409
d923b542
DA
64102012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
6411
6412 Avoid call to strlen in fast_c_string_match_ignore_case.
6413 * search.c (fast_c_string_match_ignore_case): Change to use
6414 length argument. Adjust users accordingly.
6415 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
6416
5ebbef1d
PE
64172012-07-11 Paul Eggert <eggert@cs.ucla.edu>
6418
bb352260
PE
6419 Assume mkdir, rmdir.
6420 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
6421 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
6422
57054ddd
PE
6423 Assume rename.
6424 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
6425
b747d3f7
PE
6426 Assume perror.
6427 * s/hpux10-20.h (HAVE_PERROR): Remove.
6428 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
6429 Remove dummy definition, as this problem was obsolete long ago.
6430
5ebbef1d
PE
6431 Assume strerror.
6432 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
6433
984e7f30
DA
64342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
6435
6436 Avoid calls to strlen in font processing functions.
6437 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
6438 (font_open_by_name): Change to use length argument.
6439 Adjust users accordingly.
d923b542
DA
6440 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
6441 Adjust prototypes.
6442 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
6443 Change to return ptrdiff_t.
984e7f30
DA
6444 (xfont_list_pattern, xfont_match): Use length returned by
6445 xfont_decode_coding_xlfd.
6446 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
6447
20e94fdd
GM
64482012-07-11 Glenn Morris <rgm@gnu.org>
6449
9d596af3
GM
6450 * s/darwin.h, s/freebsd.h, s/netbsd.h:
6451 Move DONT_REOPEN_PTY to configure.
6452
20e94fdd
GM
6453 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
6454 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
6455
e99a530f
PE
64562012-07-10 Paul Eggert <eggert@cs.ucla.edu>
6457
22ffb973
PE
6458 Remove "#define unix" that is no longer needed (Bug#11905).
6459 * s/aix4-2.h (unix): Remove; no longer needed.
6460
e9a9ae03
PE
6461 EMACS_TIME simplification (Bug#11875).
6462 This replaces macros (which typically do not work in GDB)
6463 with functions, typedefs and enums, making the code easier to debug.
6464 The functional style also makes code easier to read and maintain.
6465 * systime.h: Include <sys/time.h> on all hosts, not just if
6466 WINDOWSNT, since 'struct timeval' is needed in general.
6467 (EMACS_TIME): Now a typedef, not a macro.
6468 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
6469 not macros.
6470 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
6471 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
6472 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
6473 (EMACS_TIME_LE): Now functions, not macros.
6474 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
6475 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
6476 which are not functions. All uses rewritten to use:
6477 (make_emacs_time): New function.
6478 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
6479 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
6480 not functions. All uses rewritten to use the following, respectively:
6481 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
6482 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 6483 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
6484 * fileio.c (Fcopy_file):
6485 * xterm.c (XTflash): Get the current time closer to when it's used.
6486 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
6487
ffacb126
PE
6488 * bytecode.c (targets): Suppress -Woverride-init warnings.
6489
e99a530f
PE
6490 Simplify by avoiding confusing use of strncpy etc.
6491 * doc.c (Fsnarf_documentation):
6492 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
6493 * frame.c (Fmake_terminal_frame):
6494 * gtkutil.c (get_utf8_string):
6495 * lread.c (openp):
6496 * nsmenu.m (ns_update_menubar):
6497 * regex.c (regerror):
6498 Prefer memcpy to strncpy and strncat when either will do.
6499 * fileio.c (Fsubstitute_in_file_name):
6500 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
6501 (menu_separator_name_p):
6502 * nsmenu.m (ns_update_menubar):
6503 Prefer memcmp to strncmp when either will do.
6504 * nsterm.m: Include <ftoastr.h>.
6505 (ns_get_color):
6506 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
6507 Prefer snprintf to strncpy.
6508 * nsterm.m (ns_term_init):
6509 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
6510 * nsterm.m (ns_term_init):
6511 Avoid the need for strncpy, by using build_string or
6512 make_unibyte_string directly. Use dtoastr, not snprintf.
6513 * process.c (Fmake_network_process): Diagnose service names that
6514 are too long, rather than silently truncating them or creating
6515 non-null-terminated names.
6516 (Fnetwork_interface_info): Likewise, for interface names.
6517 * sysdep.c (system_process_attributes) [GNU_LINUX]:
6518 Prefer sprintf to strncat.
6519 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
6520 Prefer vsnprintf to vsprintf + strncpy.
6521
c59592b3
GM
65222012-07-10 Glenn Morris <rgm@gnu.org>
6523
6524 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
6525 Clarify fallback case.
6526
7d7bbefd
DA
65272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
6528
6529 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
6530 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
6531 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 6532 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
6533 where argument type is known to be a Lisp_Cons.
6534
3a4c8000
TT
65352012-07-10 Tom Tromey <tromey@redhat.com>
6536
6537 * bytecode.c (BYTE_CODE_THREADED): New macro.
6538 (BYTE_CODES): New macro. Replaces all old byte-code defines.
6539 (enum byte_code_op): New type.
6540 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
6541 (exec_byte_code): Use them. Use token threading when applicable.
6542
2a0213a6
DA
65432012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
6544
6545 Optimize pure C strings initialization.
6546 * lisp.h (make_pure_string): Fix prototype.
6547 (build_pure_c_string): New function, defined as static inline. This
6548 provides a better opportunity to optimize away calls to strlen when
6549 the function is called with compile-time constant argument.
6550 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
6551 argument, adjust users accordingly. Use build_pure_c_string where
6552 appropriate.
6553 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
6554 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
6555 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
6556
cb1caeaf
DA
65572012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
6558
6559 Avoid calls to strlen in miscellaneous functions.
6560 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
6561 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
6562 * lread.c (openp): Likewise.
6563
c293e30c
DA
65642012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
6565
6566 Avoid calls to strlen in path processing functions.
6567 * fileio.c (file_name_as_directory): Add comment. Change to add
6568 srclen argument and return the length of result. Adjust users
6569 accordingly.
6570 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
6571 swap 1st and 2nd arguments to obey the common convention.
6572 Adjust users accordingly.
c293e30c
DA
6573 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
6574
9e059e3f
GM
65752012-07-10 Glenn Morris <rgm@gnu.org>
6576
d02eb359
GM
6577 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
6578 Move PENDING_OUTPUT_COUNT definition to configure.
6579
882cf227
GM
6580 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
6581 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
6582 * s/gnu.h (DATA_START): Move definitions to configure.
6583
af6e839f
GM
6584 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
6585 We include usg5-4-common.h, which defines them both.
6586
40289a12
GM
6587 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
6588 O_RDONLY already includes it).
6589
9e059e3f
GM
6590 Stop ns builds setting the EMACSLOADPATH environment variable.
6591 * nsterm.m (ns_load_path): Rename from ns_init_paths.
6592 Now it does not set EMACSLOADPATH, just returns the load-path string.
6593 * nsterm.h: Update accordingly.
6594 * lread.c [HAVE_NS]: Include nsterm.h.
6595 (init_lread) [HAVE_NS]: Use ns_load_path.
6596 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
6597
7c4e8ec0
GM
65982012-07-09 Glenn Morris <rgm@gnu.org>
6599
d4f600ff
GM
6600 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
6601 since the included bsd-common.h does so.
6602
cbb31951
GM
6603 Stop ns builds setting the EMACSPATH environment variable.
6604 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
6605 (ns_init_paths): Do not set EMACSPATH.
6606 * nsterm.h (ns_exec_path): Add it.
6607 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
6608 Use ns_exec_path.
6609
7c4e8ec0
GM
6610 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
6611
26bccfae
PE
66122012-07-09 Paul Eggert <eggert@cs.ucla.edu>
6613
a0bee46f
PE
6614 * process.c (wait_reading_process_output): 'waitchannels' was unset
6615 when read_kbd || !NILP (wait_for_cell); fix this.
6616
5994c183
PE
6617 Add GCC-style 'const' attribute to functions that can use it.
6618 * character.h (char_resolve_modifier_mask):
6619 * keyboard.h (make_ctrl_char):
6620 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
6621 (init_character_once, next_almost_prime, init_fns, init_image)
6622 (flush_pending_output, init_sound):
6623 * mem-limits.h (start_of_data):
6624 * menu.h (finish_menu_items):
6625 Add ATTRIBUTE_CONST.
6626 * emacs.c (DEFINE_DUMMY_FUNCTION):
6627 Declare the dummy function with ATTRIBUTE_CONST.
6628 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
6629 Add decls with ATTRIBUTE_CONST.
6630
26bccfae
PE
6631 Minor improvements to make_formatted_string.
6632 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
6633 where int is good enough, as vsprintf returns an int.
6634 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
6635
a8290ec3
DA
66362012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
6637
6638 Use make_formatted_string to avoid double length calculation.
6639 * lisp.h (make_formatted_string): New prototype.
6640 * alloc.c (make_formatted_string): New function.
6641 * buffer.c (Fgenerate_new_buffer_name): Use it.
220cb2bd 6642 * dbusbind.c (syms_of_dbusbind): Likewise.
a8290ec3
DA
6643 * editfns.c (Fcurrent_time_zone): Likewise.
6644 * filelock.c (get_boot_time): Likewise.
6645 * frame.c (make_terminal_frame, set_term_frame_name)
6646 (x_report_frame_params): Likewise.
6647 * image.c (gs_load): Likewise.
6648 * minibuf.c (get_minibuffer): Likewise.
6649 * msdos.c (dos_set_window_size): Likewise.
6650 * process.c (make_process): Likewise.
6651 * xdisp.c (ensure_echo_area_buffers): Likewise.
6652 * xsettings.c (apply_xft_settings): Likewise.
6653
d01ba2f1
GM
66542012-07-09 Glenn Morris <rgm@gnu.org>
6655
6656 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
6657 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
6658 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
6659 * nsterm.h (ns_etc_directory): Add it.
6660 * callproc.c [HAVE_NS]: Include nsterm.h.
6661 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
6662
f1f924b6
DA
66632012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
6664
6665 Move marker debugging code under MARKER_DEBUG.
6666 * marker.c (MARKER_DEBUG): Move marker debugging code under
6667 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
6668 for bootstrap with --enable-checking (~3x slowdown reported
6669 by Juanma Barranquero <lekktu@gmail.com>).
6670 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
6671
ab531b66
PE
66722012-07-08 Paul Eggert <eggert@cs.ucla.edu>
6673
6674 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
6675 See <http://bugs.gnu.org/11825#29>.
6676
c4b3bc8a
EZ
66772012-07-08 Eli Zaretskii <eliz@gnu.org>
6678
6679 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
6680 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
6681 (display_line): Add commentary about displaying truncation glyphs
6682 on GUI frames.
6683 (produce_special_glyphs): Move here from term.c.
6684
6685 * term.c (produce_special_glyphs): Move to xdisp.c.
6686
6687 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
6688 section.
c4b3bc8a 6689
b676b881
AS
66902012-07-07 Andreas Schwab <schwab@linux-m68k.org>
6691
f17c5273
AS
6692 * xdisp.c (display_line): Avoid warning about implicit declaration
6693 of FRAME_FONT.
6694
298819b9
AS
6695 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
6696
b676b881
AS
6697 * lisp.h: Remove empty conditional.
6698
6045c4fd
PE
66992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
6700
b3350bf9
PE
6701 * lread.c (load_path_check): Now static.
6702
6045c4fd
PE
6703 Fix some minor --with-ns problems found by static checking.
6704 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
6705 (x_set_font) [!HAVE_X_WINDOWS]:
6706 * image.c (xpm_load_image) [HAVE_NS]:
6707 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
6708 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
6709 Remove unused local.
6710 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
6711 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
6712 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
6713 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
6714 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
6715 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
6716 Fix pointer signedness problem.
6717 * xfaces.c (FRAME_X_FONT_TABLE):
6718 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
6719
929e7845
GM
67202012-07-07 Glenn Morris <rgm@gnu.org>
6721
6722 * lread.c (load_path_check): New function, split from init_lread.
6723 (init_lread): Reorganize. Motivation:
6724 If EMACSLOADPATH is set, check/warn about that rather than the
6725 defaults, which we are not going to use. Hence we can remove
6726 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
6727 Don't warn if site-lisp directories are missing.
6728 If not installed, start from a blank load-path, since
6729 PATH_LOADSEARCH refers to the eventual installation directories.
6730
58dd0aa4
EZ
67312012-07-07 Eli Zaretskii <eliz@gnu.org>
6732
6733 Support truncation and continuation glyphs on GUI frames, when
6734 fringes are disabled. (Bug#11832)
6735 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
6736 continuation glyphs even if on GUI frames.
6737 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
6738 or both, are absent.
6739 (start_display, move_it_in_display_line_to): Handle the case of a
6740 GUI frame without a fringe to display continuation or truncation
6741 glyphs.
6742 (insert_left_trunc_glyphs): Support GUI frames: make sure
6743 truncation glyphs overwrite enough glyphs from the current line to
6744 have sufficient space in pixels.
6745 (display_line): Support truncation and continuation glyphs on GUI
6746 frames. If some spare pixels are left on the line after inserting
6747 the truncation glyphs, fill that space with a stretch glyph of a
6748 suitably computed width.
6749
6750 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
6751 produce_glyphs, to support GUI sessions.
6752
31571fd7
PE
67532012-07-07 Paul Eggert <eggert@cs.ucla.edu>
6754
5a16b9bc
PE
6755 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
6756
f3047c75
PE
6757 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
6758
31571fd7
PE
6759 Do not require float-time's arg to fit in time_t (Bug#11825).
6760 This works better on hosts where time_t is unsigned, and where
6761 float-time is applied to the (negative) difference between two times.
6762 * editfns.c (decode_time_components): Last arg is now double *,
6763 not int *, and means to store all the result as a double, without
6764 worrying about whether the seconds part fits in time_t.
6765 All callers changed.
6766 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
6767 All callers changed.
6768 (Ffloat_time): Do not fail merely because the specified time falls
6769 outside of time_t range.
6770
4516fbef
GM
67712012-07-07 Glenn Morris <rgm@gnu.org>
6772
6773 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
6774 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
6775 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
6776
07adc2c6
JB
67772012-07-07 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
6780 Update dependencies.
6781
6782 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
6783
fd573f31
PE
67842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
6785
fee5959d
PE
6786 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
6787 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
6788 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
6789 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
6790 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
6791 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
6792
fd573f31
PE
6793 * xfont.c (compare_font_names): Redo to omit the need for casts.
6794
ddadbc0e
AS
67952012-07-06 Andreas Schwab <schwab@linux-m68k.org>
6796
fca8d6b6
AS
6797 * xfns.c (Fx_change_window_property): Doc fix.
6798 * w32fns.c (Fx_change_window_property): Doc fix.
6799
ddadbc0e
AS
6800 * w32fns.c (Fx_window_property): Accept the same arguments as the
6801 X Windows version. Doc fix.
6802 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
6803
ed9265fc 68042012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
6805 Eli Zaretskii <eliz@gnu.org>
6806
6807 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
6808 Windows-specific code from nt/config.nt moved here.
6809 Obsolete settings removed.
6810
216ee680
PE
68112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
6812
6813 * process.c: Avoid unnecessary calls to gettime.
6814 (wait_reading_process_output): Don't get the time of day
6815 when gobbling data immediately and not waiting, as there's no need
6816 for it in that case. This removes a FIXME.
6817
bdd091e4
JD
68182012-07-06 Jan Djärv <jan.h.d@swipnet.se>
6819
6820 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
6821 is defined (Bug#11768).
6822
9d44f8ce
DA
68232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
6824
6825 Fix marker debugging code.
6826 * marker.c (byte_char_debug_check): Do not perform the check
6827 if buffer is not multibyte.
090bd7cb
JB
6828 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
6829 Call byte_char_debug_check with correct arguments.
9d44f8ce 6830
90fc4786
DA
68312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
6832
6833 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
6834 * marker.c (byte_char_debug_check, count_markers):
6835 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
6836 (byte_debug_flag): Remove.
6837 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
6838 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
6839
7b7ae965
DA
68402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
6841
4e57b342
DA
6842 Avoid code repetition in marker-related functions.
6843 * marker.c (attach_marker): New function.
6844 (Fset_marker, set_marker_restricted, set_marker_both)
6845 (set_marker_restricted_both): Use it.
6846 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
6847 Consistently rename charno to charpos.
6848 (marker_position): Add eassert.
6849 (marker_byte_position): Convert to eassert.
6850
68512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
6852
6853 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 6854 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 6855 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 6856
657924ff
DA
68572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
6858
6859 Introduce fast path for the widely used marker operation.
6860 * alloc.c (build_marker): New function.
6861 * lisp.h (build_marker): New prototype.
6862 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
6863 * composite.c (autocmp_chars): Likewise.
6864 * editfns.c (buildmark): Remove.
6865 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
6866 (save_restriction_save): Use build_marker.
6867 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
6868 * window.c (save_window_save): Likewise.
6869
041a49a6
DA
68702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
6871
6872 Do not use Fdelete_overlay in delete_all_overlays
6873 to avoid redundant calls to unchain_overlay.
6874 * buffer.c (drop_overlay): New function.
6875 (delete_all_overlays, Fdelete_overlay): Use it.
6876 * minibuf.c (get_minibuffer): Fix comment.
6877
7dca65a4
PE
68782012-07-06 Paul Eggert <eggert@cs.ucla.edu>
6879
6880 Port to OpenBSD 5.1 amd64.
6881 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
6882 This is needed for OpenBSD, and should be harmless on all BSD systems.
6883 Also, include <sys/sysctl.h>, as it should be available on all
6884 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
6885 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
6886 use p_pid member, not kp_proc.pid.
6887
8eb876e2
GM
68882012-07-06 Glenn Morris <rgm@gnu.org>
6889
6890 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
6891
38182d90
PE
68922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 More xmalloc and related cleanup.
6895 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
6896 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
6897 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
6898 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
6899 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
6900 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
6901 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
6902 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
6903 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
6904 * xterm.c:
6905 Omit needless casts involving void * pointers and allocation.
6906 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
6907 as the former is more robust if P's type is changed.
6908 Prefer xzalloc to xmalloc + memset 0.
6909 Simplify malloc-or-realloc to realloc.
6910 Don't worry about xmalloc returning a null pointer.
6911 Prefer xstrdup to xmalloc + strcpy.
6912 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
6913 growing it.
6914 * keyboard.c (apply_modifiers_uncached): Prefer local array to
6915 alloca of a constant.
6916
6dd5a677
EZ
69172012-07-05 Eli Zaretskii <eliz@gnu.org>
6918
6919 * xdisp.c (display_line): Fix horizontal pixel coordinates when
6920 hscroll is larger than the line width. Fixes long and futile
6921 looping inside extend_face_to_end_of_line (on a TTY) producing
6922 glyphs that are not needed and thrown away.
6923
6b312f0f
DA
69242012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
6925
6926 * marker.c (set_marker_restricted_both): Simplify by using
6927 clip_to_bounds.
6928
f520ef9b
PE
69292012-07-05 Paul Eggert <eggert@cs.ucla.edu>
6930
6931 * editfns.c (region_limit): Simplify by using clip_to_bounds.
6932
383b7c95
JD
69332012-07-05 Jan Djärv <jan.h.d@swipnet.se>
6934
6935 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
6936 not defined (Bug#11768).
6937 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
6938 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
6939 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
6940 followed by gtk_box_set_homogeneous (Bug#11768).
6941 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
6942 (update_theme_scrollbar_width, xg_create_scroll_bar):
6943 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
6944 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
6945 (is_box_type): New function (Bug#11768).
6946 (xg_tool_item_stale_p): Call is_box_type.
5293d758 6947 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
6948 with default display (Bug#11768).
6949
d6e7bf45
EZ
69502012-07-05 Eli Zaretskii <eliz@gnu.org>
6951
6952 * xdisp.c (window_hscroll_limited): New function.
6953 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
6954 coordinates when window's hscroll is set to insanely large
6955 values. (Bug#11857)
6956
431391ec
JB
69572012-07-05 Juanma Barranquero <lekktu@gmail.com>
6958
6959 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
6960 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
6961
23f86fce
DA
69622012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
6963
6964 Cleanup xmalloc.
6965 * lisp.h (xzalloc): New prototype. Omit needless casts.
6966 * alloc.c (xzalloc): New function. Omit needless casts.
6967 * charset.c: Omit needless casts. Convert all calls to
6968 xmalloc with following memset to xzalloc.
6969 * dispnew.c: Likewise.
6970 * fringe.c: Likewise.
6971 * image.c: Likewise.
6972 * sound.c: Likewise.
6973 * term.c: Likewise.
6974 * w32fns.c: Likewise.
6975 * w32font.c: Likewise.
6976 * w32term.c: Likewise.
6977 * xfaces.c: Likewise.
6978 * xfns.c: Likewise.
6979 * xterm.c: Likewise.
6980 * atimer.c: Omit needless casts.
6981 * buffer.c: Likewise.
6982 * callproc.c: Likewise.
6983 * ccl.c: Likewise.
6984 * coding.c: Likewise.
6985 * composite.c: Likewise.
6986 * doc.c: Likewise.
6987 * doprnt.c: Likewise.
6988 * editfns.c: Likewise.
6989 * emacs.c: Likewise.
6990 * eval.c: Likewise.
6991 * filelock.c: Likewise.
6992 * fns.c: Likewise.
6993 * gtkutil.c: Likewise.
6994 * keyboard.c: Likewise.
6995 * lisp.h: Likewise.
6996 * lread.c: Likewise.
6997 * minibuf.c: Likewise.
6998 * msdos.c: Likewise.
6999 * print.c: Likewise.
7000 * process.c: Likewise.
7001 * region-cache.c: Likewise.
7002 * search.c: Likewise.
7003 * sysdep.c: Likewise.
7004 * termcap.c: Likewise.
7005 * terminal.c: Likewise.
7006 * tparam.c: Likewise.
7007 * w16select.c: Likewise.
7008 * w32.c: Likewise.
7009 * w32reg.c: Likewise.
7010 * w32select.c: Likewise.
7011 * w32uniscribe.c: Likewise.
7012 * widget.c: Likewise.
7013 * xdisp.c: Likewise.
7014 * xmenu.c: Likewise.
7015 * xrdb.c: Likewise.
7016 * xselect.c: Likewise.
7017
0497dc44
PE
70182012-07-05 Paul Eggert <eggert@cs.ucla.edu>
7019
7020 * fileio.c (time_error_value): Check the right error number.
7021 Problem reported by Troels Nielsen in
7022 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
7023
356e7178
PE
70242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
7025
4e71fd89
PE
7026 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
7027 This should be fixed in a better way; see Eli Zaretskii in
7028 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
7029 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
7030
f0941253
PE
7031 * fileio.c (time_error_value): Rename from special_mtime.
7032 The old name's problems were noted by Eli Zaretskii in
7033 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
7034
065c9eb4
PE
7035 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
7036 This variable's comment says Emacs needs at least one GDB-visible
7037 symbol of type enum pvec_type, to work around GDB problems.
7038 The symbol's value doesn't matter.
7039
356e7178
PE
7040 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
7041 that causes compilation to fail on pre-C99 compilers.
7042
ed9265fc 70432012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
7044
7045 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
7046 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
7047
3884d954
DA
70482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
7049
d209e2fb 7050 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
7051 headers for buffer_defaults and buffer_local_symbols.
7052 Reported by Juanma Barranquero <lekktu@gmail.com>.
7053
ee28be33
SM
70542012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7055
7056 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
7057 * lisp.h (enum pvec_type): Use fewer bits.
7058 (PSEUDOVECTOR_SIZE_BITS): New constant.
7059 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
7060 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
7061 change in pvec_type.
7062 (PSEUDOVECTOR_TYPEP): New macro.
7063 (TYPED_PSEUDOVECTORP): Use it.
7064 * fns.c (internal_equal): Adapt code to extract pvectype.
7065 * emacs.c (gdb_pvec_type): Update type.
7066 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
7067 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
7068 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
7069 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
7070 (sweep_vectors): Use it. Use local var `total_bytes' instead of
7071 abusing vector->header.next.nbytes.
7072 (live_vector_p): Use PVEC_TYPE.
7073 (mark_object): Adapt code to extract pvectype. Use switch.
7074
c7f2cd7f
PE
70752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
7076
7077 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
7078 Tighten new eassert a bit.
7079
8ce70ed2
DA
70802012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
7081
7082 Fix compilation with --enable-gcc-warnings and -O1
7083 optimization level.
7084 * doprnt.c (doprnt): Change type of tem to int, initialize
7085 to avoid compiler warning. Add eassert.
7086 * search.c (simple_search): Initialize match_byte to avoid
7087 compiler warning. Add eassert.
7088
dea7f1e5
PE
70892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
7090
24a212eb
PE
7091 Avoid weird behavior with large horizontal scrolls.
7092 Without this change, for example, large hscroll values would
7093 mess up Emacs's display on Fedora 15 x86, presumably due to
7094 overflows in int calculations in the display code.
7095 Also, if buffers had long lines, Emacs would freeze.
7096 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
7097 (set_window_hscroll): New function, containing the old guts of
7098 Fset_window_hscroll. Return the clipped value.
7099 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
7100 This avoids the need to check against PTRDIFF_MAX.
7101
dea7f1e5
PE
7102 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
7103
76046526
DA
71042012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
7105
7106 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
7107
39adff0d
PE
71082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
7109
63807d47
PE
7110 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
7111 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
7112 since GCC 4.4.6 issues a bogus warning for them.
7113
39adff0d
PE
7114 Fix bugs in file timestamp newness comparisons.
7115 * fileio.c (Ffile_newer_than_file_p):
7116 * lread.c (Fload): Use full timestamp resolution of files,
7117 not just the 1-second resolution, so that files that are only
7118 slightly newer still count as newer.
7119 * fileio.c (Ffile_newer_than_file_p): Don't assume file
7120 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
7121
dbeed9a6
PE
71222012-07-03 Paul Eggert <eggert@cs.ucla.edu>
7123
7124 * fileio.c: Improve handling of file time marker. (Bug#11852)
7125 (special_mtime): New function.
7126 (Finsert_file_contents, Fverify_visited_file_modtime):
7127 Use it to set special mtime values consistently.
7128
636334d6
AS
71292012-07-03 Andreas Schwab <schwab@linux-m68k.org>
7130
7131 * fileio.c (Finsert_file_contents): Properly handle st_mtime
7132 marker for non-existing file. (Bug#11852)
7133
e2017fe2
GM
71342012-07-03 Glenn Morris <rgm@gnu.org>
7135
7136 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
7137 and did not make it into globals.h).
7138
404dbd37
TT
71392012-07-03 Tom Tromey <tromey@redhat.com>
7140
7141 * window.c (Fset_window_margins, Fset_window_fringes)
7142 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
7143 * textprop.c (Fprevious_property_change): No longer static.
7144 * syntax.c (Fsyntax_table_p): No longer static.
7145 * process.c (Fget_process, Fprocess_datagram_address): No longer
7146 static.
7147 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
7148 * keyboard.c (Fcommand_execute): No longer static.
7149 Remove EXFUN.
7150 * insdel.c (Fcombine_after_change_execute): No longer static.
7151 * image.c (Finit_image_library): No longer static.
7152 * fileio.c (Fmake_symbolic_link): No longer static.
7153 * eval.c (Ffetch_bytecode): No longer static.
7154 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
7155 * doc.c (Fdocumentation_property, Fsnarf_documentation):
7156 No longer static.
404dbd37
TT
7157 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
7158 static.
7159 * dired.c (Ffile_attributes): No longer static.
7160 * composite.c (Fcomposition_get_gstring): No longer static.
7161 * callproc.c (Fgetenv_internal): No longer static.
7162
7163 * ccl.h: Remove EXFUNs.
7164 * buffer.h: Remove EXFUNs.
7165 * dispextern.h: Remove EXFUNs.
7166 * intervals.h: Remove EXFUNs.
7167 * fontset.h: Remove EXFUN.
7168 * font.h: Remove EXFUNs.
7169 * dosfns.c (system_process_attributes): Remove EXFUN.
7170 * keymap.h: Remove EXFUNs.
7171 * lisp.h: Remove EXFUNs.
7172 * w32term.h: Remove EXFUNs.
7173 * window.h: Remove EXFUNs.
7174 * xsettings.h: Remove EXFUN.
7175 * xterm.h: Remove EXFUN.
7176
8e4fd1e1
GM
71772012-07-03 Glenn Morris <rgm@gnu.org>
7178
7179 * lisp.h (Frandom): Make it visible to C.
7180 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
7181 buffer for invisible buffers. (Bug#1229)
7182
ca95b3eb
DA
71832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
7184
7185 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
7186 values which aren't power of 2.
14ae4239 7187 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
1f9f395d 7188 Verify its value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
7189 accordingly.
7190
7555c33f
SM
71912012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
7192
7193 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
7194
7195 * alloc.c (mark_object): Revert part of last patch to use `switch'.
7196
d12e8f5a
DA
71972012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
7198
7199 * alloc.c (allocate_vector_block): Remove redundant
7200 calls to mallopt if DOUG_LEA_MALLOC is defined.
7201 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
7202 avoid calls to mallopt if zero_vector is returned.
7203
296094c3
DA
72042012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
7205
7206 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
7207 is enabled, avoid dereferencing NULL current_sblock if
7208 running undumped.
7209
36429c89
DA
72102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
7211
7212 Cleanup basic buffer management.
7213 * buffer.h (struct buffer): Change layout to use generic vector
7214 marking code. Fix some comments. Change type of 'clip_changed'
7215 to bitfield. Remove unused #ifndef old.
7216 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
7217 (GET_OVERLAYS_AT): Fix indentation.
7218 (for_each_per_buffer_object_at): New macro.
7219 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
7220 (Fbuffer_local_variables): Use it.
7221 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
7222 * alloc.c (allocate_buffer): Adjust to match new layout of
7223 struct buffer. Fix comment.
7224 (mark_overlay): New function.
7225 (mark_buffer): Use it. Use mark_vectorlike to mark normal
7226 Lisp area of struct buffer.
7227 (mark_object): Use it. Adjust marking of misc objects
7228 and related comments.
7229
3b3e4cac
PE
72302012-07-02 Paul Eggert <eggert@cs.ucla.edu>
7231
7232 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
7233 wrapper that is not needed because the wrapped code is a no-op (zero
7234 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
7235 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
7236
cf5c0175
DA
72372012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
7238
7239 * alloc.c (mark_buffer): Simplify. Remove prototype.
7240 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 7241 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
7242 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
7243 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 7244
ca26824c
GM
72452012-06-30 Glenn Morris <rgm@gnu.org>
7246
2e4c5312
GM
7247 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
7248
ca26824c
GM
7249 * epaths.in (PATH_SITELOADSEARCH): New.
7250 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
7251 This is rather than relying on --enable-locallisppath elements
7252 having "site-lisp" in their names. (Bug#10208#25, 11658)
7253
0d23c240
EZ
72542012-06-30 Eli Zaretskii <eliz@gnu.org>
7255
c9240d7a
EZ
7256 * w32proc.c (sys_select): Accept and ignore one more argument.
7257
7258 * w32.c (emacs_gnutls_pull): Call select with one more argument.
7259
0d23c240 7260 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 7261 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
7262
7263 * sysdep.c: Don't include dos.h and dosfns.h.
7264
7265 * process.c (sys_select):
7266 * msdos.c (sys_select): Accept one more argument and ignore it.
7267
7268 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
7269 adapt data types and code to that.
7270
7271 * dosfns.c:
7272 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
7273 which clashes with the gnulib function of the same name.
7274
af5a5a98
AS
72752012-06-30 Andreas Schwab <schwab@linux-m68k.org>
7276
c5e4379c
AS
7277 * font.c (font_style_to_value, font_style_symbolic)
7278 (font_prop_validate_style): Add type checks for values in
7279 font_style_table.
7280
af5a5a98
AS
7281 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
7282 argument.
7283 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
7284 uses.
7285
8d38f461
EZ
72862012-06-29 Eli Zaretskii <eliz@gnu.org>
7287
2e5a6631
EZ
7288 * xdisp.c (try_window_id): Undo last change.
7289
8d38f461
EZ
7290 * w32.c (getwd): Adjust commentary about startup_dir.
7291 (init_environment): Always call sys_access, even in non-MSVC
7292 builds. Don't chdir to the directory of the Emacs executable.
7293 This undoes code from 1997 which was justified by the need to
7294 "avoid conflicts when removing and renaming directories". But its
7295 downside was that every relative file name was being interpreted
7296 relative to the directory of the Emacs executable, which can never
7297 be TRT. In particular, it broke sys_access when called with
7298 relative file names.
7299 (sys_access): Map GetLastError to errno.
7300
2af3565e
DA
73012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
7302
7303 * window.h (struct window): Change type of 'fringes_outside_margins'
7304 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 7305 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
7306 Adjust comment.
7307 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
7308 to ptrdiff_t.
7309
c8d3a25c 73102012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 7311
c8d3a25c
GM
7312 * gnutls.c (emacs_gnutls_handshake):
7313 Add QUIT to make the loop interruptible.
57570cd3 7314
c8d3a25c 73152012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 7316
c8d3a25c
GM
7317 * charset.c (init_charset): Make lack of etc/charsets fatal.
7318
3e984ee8
DA
73192012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
7320
7321 * editfns.c (region_limit): Fix type mismatch.
7322
ef884f23
DA
73232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
7324
7325 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
7326 undefined. Convert from xassert to eassert.
7327 * nsmenu.m: Convert from xassert to eassert.
7328 * nsterm.m: Likewise.
7329
7d7e0027
SM
73302012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
7331
7332 * editfns.c (region_limit): Clip to narrowing (bug#11770).
7333
aa754e6a
PE
73342012-06-28 Paul Eggert <eggert@cs.ucla.edu>
7335
7336 Avoid integer overflow on scroll-left and scroll-right.
7337 * window.c (HSCROLL_MAX): New macro.
7338 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
7339 overflow when requested scroll falls outside ptrdiff_t range.
7340
80b00b08
DA
73412012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
7342
7343 * window.h (struct window): Change type of 'hscroll',
7344 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
7345 'last_modified' and 'last_overlay_modified' to EMACS_INT.
7346 Adjust users accordingly.
7347 * xdisp.c (try_cursor_movement): Replace type check with eassert.
7348 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
7349 from EMACS_INT to ptrdiff_t.
7350 (make_window): Omit redundant initialization.
7351
62b2bcf6
JB
73522012-06-28 Juanma Barranquero <lekktu@gmail.com>
7353
7354 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
7355
45942c7d
DA
73562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
7357
7358 * window.h (struct window): Change type of 'use_time' and
7359 'sequence_number' from Lisp_Object to int.
7360 * frame.c (make_frame): Adjust users accordingly.
7361 * print.c (print_object): Likewise.
7362 * window.c (select_window, Fwindow_use_time, make_parent_window)
7363 (make_window): Likewise.
7364
e509cfa6
DA
73652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
7366
7367 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
7368 enabled with --enable-checking=[all,glyphs] configure option.
7369 Fix GLYPH_DEBUG usage assuming that it may be undefined,
7370 adjust comments accordingly.
7371 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
7372 undefined, adjust comments accordingly.
7373 * image.c: Likewise.
7374 * scroll.c: Likewise.
7375 * w32fns.c: Likewise.
7376 * w32term.c: Likewise.
7377 * xdisp.c: Likewise.
7378 * xfaces.c: Likewise.
7379 * xfns.c: Likewise.
7380 * xterm.c: Likewise.
7381
a54e2c05
DA
73822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
7383
7384 Generalize run-time debugging checks.
7385 * dispextern.h (XASSERTS): Remove.
7386 * fontset.c (xassert): Remove.
7387 Convert from xassert to eassert.
7388 * alloc.c: Convert from xassert to eassert.
7389 * bidi.c: Likewise.
7390 * dispnew.c: Likewise.
7391 * fns.c: Likewise.
7392 * fringe.c: Likewise.
7393 * ftfont.c: Likewise.
7394 * gtkutil.c: Likewise.
7395 * image.c: Likewise.
7396 * keyboard.c: Likewise.
7397 * menu.c: Likewise.
7398 * process.c: Likewise.
7399 * scroll.c: Likewise.
7400 * sound.c: Likewise.
7401 * term.c: Likewise.
7402 * w32console.c: Likewise.
7403 * w32fns.c: Likewise.
7404 * w32term.c: Likewise.
7405 * window.c: Likewise.
7406 * xdisp.c: Likewise.
7407 * xfaces.c: Likewise.
7408 * xfns.c: Likewise.
7409 * xselect.c: Likewise.
7410 * xterm.c: Likewise.
7411
1ec4b7b2
SM
74122012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
7413
7414 * fns.c (maybe_resize_hash_table): Output message when growing the
7415 purify-hashtable.
7416
2014308a
DA
74172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
7418
7419 * alloc.c (allocate_string_data): Remove dead code.
7420 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
7421 avoid GCC warning about unused macro.
7422
246155eb
DA
74232012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
7424
7425 * alloc.c (allocate_string): Omit intervals initialization.
7426 * alloc.c (make_uninit_multibyte_string): Initialize intervals
7427 as in make_pure_string and make_pure_c_string.
7428
43184b7b
DA
74292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
7430
d209e2fb 7431 * alloc.c (allocate_string): Fix last change.
43184b7b 7432
3fe6dd74
DA
74332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
7434
d209e2fb 7435 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
7436 to memset, add explicit initialization where appropriate.
7437
1ba6038a
GM
74382012-06-27 Glenn Morris <rgm@gnu.org>
7439
7440 * lisp.mk (lisp): Remove paths.elc.
7441
c89926a5
CY
74422012-06-27 Chong Yidong <cyd@gnu.org>
7443
7444 * doc.c (Fsubstitute_command_keys): Fix punctuation.
7445
ed6b3510
JW
74462012-06-26 John Wiegley <johnw@newartisans.com>
7447
1ec4b7b2 7448 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
7449 on Mac OS X Lion: __mod_init_func and __mod_term_func.
7450
ed6b3510
JW
7451 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
7452 when building with Clang.
7453
8edd4a2b
SM
74542012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
7455
7456 * eval.c (Fapply): Allow calling it with a single argument.
7457
f6f62d1b
EZ
74582012-06-26 Eli Zaretskii <eliz@gnu.org>
7459
7460 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
7461 _stricmp and _strnicmp.
7462 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
7463
62efea5e
DA
74642012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
7465
7466 * alloc.c (allocate_window): Zero out non-Lisp part of newly
7467 allocated window.
7468 (allocate_process): Likewise for new process.
8edd4a2b 7469 (allocate_terminal): Change to use offsetof.
62efea5e
DA
7470 (allocate_frame): Likewise.
7471 * frame.c (make_frame): Omit redundant initialization.
7472 * window.c (make_parent_window): Use memset.
7473 (make_window): Omit redundant initialization.
7474 * process.c (make_process): Omit redundant initialization.
7475 * terminal.c (create_terminal): Likewise.
7476
42997f4d
DA
74772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
7478
7479 * term.c (delete_tty): Remove redundant call to memset.
7480
1130ecfc
DA
74812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
7482
7483 * alloc.c: Remove build_string.
7484 * lisp.h: Define build_string as static inline. This provides
7485 a better opportunity to optimize away calls to strlen when the
7486 function is called with compile-time constant argument.
7487 * image.c (imagemagick_error): Convert to build_string.
7488 * w32proc.c (sys_spawnve): Likewise.
7489 * xterm.c (x_term_init): Likewise.
7490
cf38a720
PE
74912012-06-26 Paul Eggert <eggert@cs.ucla.edu>
7492
99027bdd
PE
7493 Use sprintf return value instead of invoking strlen on result.
7494 In the old days this wasn't portable, since some sprintf
7495 implementations returned char *. But they died out years ago and
7496 Emacs already assumes sprintf returns int.
7497 Similarly for float_to_string.
7498 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
7499 * ccl.c (ccl_driver):
7500 * character.c (string_escape_byte8):
7501 * data.c (Fnumber_to_string):
7502 * doprnt.c (doprnt):
7503 * print.c (print_object):
7504 * xdisp.c (message_dolog):
7505 * xfns.c (syms_of_xfns):
7506 Use sprintf or float_to_string result to avoid need to call strlen.
7507 * data.c (Fnumber_to_string):
7508 Use make_unibyte_string, since the string must be ASCII.
7509 * lisp.h, print.c (float_to_string): Now returns int length.
7510 * term.c (produce_glyphless_glyph):
7511 Use sprintf result rather than recomputing it.
7512
cf38a720
PE
7513 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
7514 * Makefile.in (ALL_CFLAGS):
7515 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
7516 * gmalloc.c, regex.c: Include <config.h> unconditionally.
7517
3511c784
DA
75182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
7519
0a08eb21 7520 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
7521 strcasecmp if available.
7522 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
7523
fb7da12e
AS
75242012-06-25 Andreas Schwab <schwab@linux-m68k.org>
7525
7526 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
7527 Avoid comma operator.
7528 * menu.c (push_submenu_start, push_submenu_end)
7529 (push_left_right_boundary, push_menu_pane): Likewise.
7530 * msdos.c (dos_rawgetc): Likewise.
7531
afa2ffd8
DA
75322012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
7533
7534 * xfns.c (xic_create_fontsetname): Remove redundant calls
7535 to memset.
7536
b3b4476b
PE
75372012-06-25 Paul Eggert <eggert@cs.ucla.edu>
7538
4495ff38
PE
7539 * gtkutil.c (get_utf8_string): Remove redundant assignment.
7540 sprintf already null-terminates its output.
7541
b3b4476b
PE
7542 * xfns.c (x_window): Remove redundant cast.
7543
b00876c9
DA
75442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
7545
7546 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
7547 `const char *' to `char *' to avoid compiler warning.
7548
d188e26b
PE
75492012-06-24 Paul Eggert <eggert@cs.ucla.edu>
7550
885d1d74
PE
7551 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
7552 instead of truncating it to 63 (admittedly a generous limit).
7553
d188e26b
PE
7554 * process.c: Fix spelling and caps in comments.
7555
e2f560b1
DN
75562012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
7557
e86db54b 7558 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
7559 * sysdep.c (setpgrp): Remove definition, not used in this file.
7560
7583a3a1
JB
75612012-06-24 Juanma Barranquero <lekktu@gmail.com>
7562
7563 * makefile.w32-in: Update dependencies.
7564
696056c2
EZ
75652012-06-24 Eli Zaretskii <eliz@gnu.org>
7566
7567 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
7568 (SYSTIME_H): Add nt/inc/sys/time.h.
7569
7570 * systime.h [WINDOWSNT]: Include sys/time.h.
7571
7572 * s/ms-w32.h (struct timespec): Definition moved from
7573 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
7574
845ca893
PE
75752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
7576
7577 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
7578 * buffer.h (buffer_slot_type_mismatch):
7579 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
7580 * eval.c (unwind_to_catch):
7581 * image.c (my_png_error, my_error_exit):
7582 * keyboard.c (quit_throw_to_read_char, user_error)
7583 (Fexit_recursive_edit, Fabort_recursive_edit):
7584 * lisp.h (die, args_out_of_range, args_out_of_range_3)
7585 (wrong_type_argument, buffer_overflow, __executable_start)
7586 (memory_full, buffer_memory_full, string_overflow, Fthrow)
7587 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
7588 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
7589 (fatal):
7590 (child_setup) [!DOS_NT]:
7591 * lread.c (end_of_file_error, invalid_syntax):
7592 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
7593 * puresize.h (pure_write_error):
7594 * search.c (matcher_overflow):
7595 * sound.c (sound_perror, alsa_sound_perror):
7596 * sysdep.c, syssignal.h (croak):
7597 * term.c (maybe_fatal, vfatal):
7598 * textprop.c (text_read_only):
7599 * undo.c (user_error):
7600 * unexmacosx.c (unexec_error):
7601 * xterm.c (x_ins_del_lines, x_delete_glyphs):
7602 Use _Noreturn rather than NO_RETURN.
7603 No need for separate decl merely because of _Noreturn.
7604 * sound.c (sound_warning, parse_sound):
7605 Remove unnecessary forward decls.
7606
f1dd8073
PE
76072012-06-24 Paul Eggert <eggert@cs.ucla.edu>
7608
7609 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
7610 * lisp.h (WAIT_READING_MAX): New macro.
7611 * dispnew.c (Fsleep_for, sit_for):
7612 * keyboard.c (kbd_buffer_get_event):
7613 * process.c (Faccept_process_output):
7614 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
7615 This improves on the previous patch, which introduced a bug
7616 when time_t is unsigned and as wide as intmax_t.
7617 See <http://bugs.gnu.org/9000#51>.
7618
b82c1755
EZ
76192012-06-23 Eli Zaretskii <eliz@gnu.org>
7620
7621 * dispnew.c (sit_for, Fsleep_for):
7622 * keyboard.c (kbd_buffer_get_event):
7623 * process.c (Faccept_process_output): Avoid compiler warnings when
7624 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
7625
ca300656
JB
76262012-06-23 Juanma Barranquero <lekktu@gmail.com>
7627
049ec95b
JB
7628 * makefile.w32-in: Update dependencies.
7629
ca300656
JB
7630 * w32.c (ltime): Add return type and declare static.
7631 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
7632
db7b8d06
PE
76332012-06-23 Paul Eggert <eggert@cs.ucla.edu>
7634
7635 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
7636 Privately reported by Herbert J. Skuhra.
7637 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
7638 All uses changed.
7639 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
7640 not make_lisp_timeval, when the argument is of type EMACS_TIME.
7641
0bd8297f
EZ
76422012-06-23 Eli Zaretskii <eliz@gnu.org>
7643
96512555
EZ
7644 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
7645 last argument of make_unibyte_string.
7646
0bd8297f
EZ
7647 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
7648 language ID in the event parameters.
7649
7650 * w32term.c (w32_read_socket): Put the new keyboard codepage into
7651 event.code, not the obscure "character set ID".
7652
63def6b6
CY
76532012-06-23 Chong Yidong <cyd@gnu.org>
7654
7655 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
7656
e8a02204
EZ
76572012-06-23 Eli Zaretskii <eliz@gnu.org>
7658
388cdec0
EZ
7659 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
7660 * w32.c (fdutimens): New function.
7661
7662 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
7663
7664 * s/ms-w32.h (pselect): Redirect to sys_select.
7665
7666 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
7667
e8a02204
EZ
7668 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
7669 in the logic of incrementing and decrementing the value of
7670 use_relocatable_buffers.
7671
d054f3fb
PE
76722012-06-23 Paul Eggert <eggert@cs.ucla.edu>
7673
7674 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
7675 Privately reported by Herbert J. Skuhra.
7676 [__FreeBSD__]: Remove "*/" typo after "#include".
7677 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
7678 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
7679 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
7680 Don't assume EMACS_TIME and struct timeval are the same type.
7681
d35af63c
PE
76822012-06-22 Paul Eggert <eggert@cs.ucla.edu>
7683
7684 Support higher-resolution time stamps (Bug#9000).
7685 The time stamps are only nanosecond-resolution at the C level,
7686 since that's the best that any real-world system supports now.
7687 But they are picosecond-resolution at the Lisp level, as that's
7688 easy, and leaves room for future OS improvements.
7689
7690 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
7691 (LIBES): Use it.
7692
7693 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
7694 Don't get current time unless it's needed.
7695
7696 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
7697 now provides it if it's absent.
7698 (start_atimer): Port to higher-res time stamps.
7699 Check for time stamp overflow. Don't get current time more
7700 often than is needed.
7701
7702 * buffer.h (struct buffer): Buffer modtime now has high resolution.
7703 Include systime.h, not time.h.
7704 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
7705
7706 * dired.c: Include stat-time.h.
7707 (Ffile-attributes): File times now have higher resolution.
7708
7709 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
7710 (struct image): Timestamp now has higher resolution.
7711
7712 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
7713 has at least microseconds now. All uses removed.
7714 (update_frame, update_single_window, update_window, update_frame_1)
7715 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 7716 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
7717
7718 * editfns.c (time_overflow): Now extern.
7719 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
7720 (float-time, Fformat_time_string, Fcurrent_time_string)
7721 (Fcurrent_time_zone): Accept and generate higher-resolution
7722 time stamps.
7723 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
7724 (decode_time_components, lisp_seconds_argument): New functions.
7725 (make_time): Now static.
7726 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
7727 Report an error if the time is invalid, rather than having the caller
7728 do that.
7729
7730 * fileio.c: Include <stat-time.h>
7731 (Fcopy_file): Copy higher-resolution time stamps.
7732 Prefer to set the time stamp via a file descriptor if that works.
7733 (Fset_file_times, Finsert_file_contents, Fwrite_region)
7734 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
7735 (Fvisited_file_modtime, Fset_visited_file_modtime):
7736 Support higher-resolution time stamps.
7737
7738 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
7739
7740 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
7741
7742 * image.c (prepare_image_for_display, clear_image_cache)
7743 (lookup_image): Port to higer-resolution time stamps.
7744
7745 * keyboard.c (start_polling, bind_polling_period):
7746 Check for time stamp overflow.
7747 (read_char, kbd_buffer_get_event, timer_start_idle)
7748 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
7749 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
7750 Port to higher-resolution time stamps. Do not assume time_t is signed.
7751 (decode_timer): New function. Timers are now vectors of length 9,
7752 not 8, to accommodate the picosecond component.
7753 (timer_check_2): Use it.
7754
7755 * nsterm.m (select_timeout, timeval_subtract): Remove.
7756 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
7757 as they're a bit more accurate and handle overflow better.
7758 (ns_select): Change prototype to be compatible with pselect.
7759 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
7760 * nsterm.h (ns_select): Adjust prototype.
7761
7762 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
7763 us-resolution time stamps.
7764 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
7765
7766 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
7767
7768 * lisp.h (time_overflow): New decl.
7769 (wait_reading_process_output): First arg is now intmax_t, not int,
7770 to accommodate larger waits.
7771
7772 * process.h (struct Lisp_Process.read_output_delay):
7773 Now counts nanoseconds, not microseconds.
7774 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
7775 EMACS_HAS_USECS.
7776 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
7777 (wait_reading_process_output):
7778 Port to ns-resolution time stamps.
7779 (Faccept_process_output, wait_reading_process_output):
7780 Check for time stamp overflow. Do not assume time_t is signed.
7781 (select_wrapper): Remove; we now use pselect.
7782 (Fprocess_attributes): Now generates ns-resolution time stamps.
7783
7784 * sysdep.c: Include utimens.h. Don't include utime.h
7785 or worry about struct utimbuf; gnulib does that for us now.
7786 (gettimeofday): Remove; gnulib provides a substitute.
7787 (make_timeval): New function.
7788 (set_file_times): Now sets ns-resolution time stamps.
7789 New arg FD; all uses changed.
7790 (time_from_jiffies, ltime_from_jiffies, get_up_time)
7791 (system_process_attributes):
7792 Now returns ns-resolution time stamp. All uses changed.
7793 Check for time stamp overflow.
7794
7795 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
7796 provides a substitute now.
7797
7798 * systime.h: Include timespec.h rather than sys/time.h and time.h,
7799 since it guarantees struct timespec.
7800 (EMACS_TIME): Now struct timespec, so that we can support
7801 ns-resolution time stamps.
7802 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
7803 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
7804 (EMACS_USECS): Remove.
7805 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
7806 so multiply the arg by 1000 before storing it.
7807 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
7808 New macros.
7809 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
7810 Port to ns-resolution time stamps.
7811 (EMACS_TIME_NEG_P): Remove; replaced by....
7812 (EMACS_TIME_SIGN): New macro.
7813 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
7814 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
7815 (set_file_times, make_time, lisp_time_argument): Adjust signature.
7816 (make_timeval, make_lisp_time, decode_time_components): New decls.
7817 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
7818 that it mishandled time_t overflow. You can't compare by subtracting!
7819 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
7820 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
7821
7822 * term.c: Include <sys/time.h>.
7823 (timeval_to_Time): New function, for proper overflow wraparound.
7824 (term_mouse_position, term_mouse_click): Use it.
7825
7826 * undo.c (record_first_change): Support higher-resolution time stamps
7827 in the undo buffer.
7828 (Fprimitive_undo): Use them when restoring time stamps.
7829
7830 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
7831 (w32_get_internal_run_time):
7832 Port to higher-resolution Emacs time stamps.
7833 (ltime): Now accepts single 64-bit integer, as that's more convenient
7834 for callers.
7835
7836 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
7837
7838 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
7839 for compatibility with pselect. Support ns-resolution time stamps.
7840
7841 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
7842
7843 * xselect.c (wait_for_property_change, x_get_foreign_selection):
7844 Check for time stamp overflow, and support ns-resolution time stamps.
7845
7846 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
7847 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
7848 (timeval_subtract): Remove; no longer needed.
7849 (XTflash, XTring_bell, x_wait_for_event):
7850 Port to ns-resolution time stamps. Don't assume time_t is signed.
7851
b6a92dfe
CY
78522012-06-22 Chong Yidong <cyd@gnu.org>
7853
7854 * xdisp.c (x_consider_frame_title): Revert last change.
7855
d251c37c
EZ
78562012-06-22 Eli Zaretskii <eliz@gnu.org>
7857
7858 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
7859 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
7860 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
7861 staticidx goes up to 1597 out of 1600 = 0x640.)
7862
f10deafb
PE
78632012-06-20 Paul Eggert <eggert@cs.ucla.edu>
7864
7865 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
7866 Otherwise, the umask might be mistakenly 0 while handling input signals.
7867
ec6de1e2
SM
78682012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
7869
7870 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
7871
28be1ada
DA
78722012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
7873
7874 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
7875 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
7876 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
7877 access to `contents' member of Lisp_Vector objects with AREF and ASET
7878 where appropriate.
7879
c6bf3022
CY
78802012-06-19 Chong Yidong <cyd@gnu.org>
7881
7882 * frame.c (delete_frame): When selecting a frame on a different
7883 text terminal, do not alter the terminal's top-frame.
7884
7885 * xdisp.c (format_mode_line_unwind_data): Record the target
7886 frame's selected window and its terminal's top-frame.
7887 (unwind_format_mode_line): Restore them.
7888 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
7889 Callers changed.
7890 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
7891 since tty frames can be explicitly named.
7892 (prepare_menu_bars): Likewise.
7893
7894 * term.c (Ftty_top_frame): New function.
7895
defd4196
PE
78962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
7897
7898 Port byte-code-meter to modern targets.
7899 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
7900 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 7901 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
7902 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
7903 (METER_1, METER_2): Simplify.
7904
1053a871
SM
79052012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
7906
7907 * data.c (Fdefalias): Return `symbol' (bug#11686).
7908
b7e8d081
MR
79092012-06-18 Martin Rudalics <rudalics@gmx.at>
7910
7911 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
7912 gets killed during executing of this function (Bug#11665).
7913 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
7914 (Vkill_buffer_query_functions): In doc-string say that functions
7915 run by this hook should not change the current buffer.
7916
7ea2b339
PE
79172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
7918
7919 Fix recently-introduced process.c problems found by static checking.
7920 * process.c (write_queue_push, write_queue_pop, send_process):
7921 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
7922 (write_queue_pop): Fix pointer signedness problem.
7923 (send_process): Remove unused local.
7924
96a313a1
CY
79252012-06-17 Chong Yidong <cyd@gnu.org>
7926
7927 * xdisp.c (redisplay_internal): No need to redisplay terminal
7928 frames that are not on top.
7929
20ca2e94
TN
79302012-06-17 Troels Nielsen <bn.troels@gmail.com>
7931
7932 * process.c (make_process): Initialize write_queue.
7933 (write_queue_push, write_queue_pop): New functions.
7934 (send_process): Use them to maintain correct ordering of process
7935 writes (Bug#10815).
7936
9a900ca9
PE
79372012-06-17 Paul Eggert <eggert@cs.ucla.edu>
7938
310fbfa8
PE
7939 * lisp.h (eassert): Assume C89 or later.
7940 This removes the need for CHECK.
7941 (CHECK): Remove. Its comments about always evaluating its
7942 argument were confusing, as 'eassert' typically does not evaluate
7943 its argument.
7944
27bb1ca4
PE
7945 * coding.c (produce_chars): Use ptrdiff_t, not int.
7946
9a900ca9
PE
7947 * xterm.c (x_draw_underwave): Check for integer overflow.
7948 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
7949
41b7f8bc 79502012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
7951
7952 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
7953 referenced (Bug#11583).
7954
9b0e3eba
AA
79552012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
7956
7957 Implement wave-style variant of underlining.
7958 * dispextern.h (face_underline_type): New enum.
7959 (face): Add field for underline type.
7960 * nsterm.m (ns_draw_underwave): New function.
7961 (ns_draw_text_decoration): Use it.
7962 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
7963 New functions.
7964 (x_draw_glyph_string): Use them.
7965 * xfaces.c (Qline, Qwave): New Lisp objects.
7966 (check_lface_attrs, merge_face_ref)
1053a871
SM
7967 (Finternal_set_lisp_face_attribute, realize_x_face):
7968 Handle wave-style underline face attributes.
9b0e3eba
AA
7969 * xterm.c (x_draw_underwave): New function.
7970 (x_draw_glyph_string): Use it.
7971
0fb52f11
JB
79722012-06-16 Juanma Barranquero <lekktu@gmail.com>
7973
7974 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
7975 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
7976 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
7977 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
7978 ($(BLD)/w32select.$(O)): Update dependencies.
7979
e5560ff7
AS
79802012-06-16 Andreas Schwab <schwab@linux-m68k.org>
7981
7982 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
7983 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
7984 * character.c (_fetch_multibyte_char_p): Remove.
7985 * alloc.c: Include "character.h" before "buffer.h".
7986 * bidi.c: Likewise.
7987 * buffer.c: Likewise.
7988 * bytecode.c: Likewise.
7989 * callint.c: Likewise.
7990 * callproc.c: Likewise.
7991 * casefiddle.c: Likewise.
7992 * casetab.c: Likewise.
7993 * category.c: Likewise.
7994 * cmds.c: Likewise.
7995 * coding.c: Likewise.
7996 * composite.c: Likewise.
7997 * dired.c: Likewise.
7998 * dispnew.c: Likewise.
7999 * doc.c: Likewise.
8000 * dosfns.c: Likewise.
8001 * editfns.c: Likewise.
8002 * emacs.c: Likewise.
8003 * fileio.c: Likewise.
8004 * filelock.c: Likewise.
8005 * font.c: Likewise.
8006 * fontset.c: Likewise.
8007 * fringe.c: Likewise.
8008 * indent.c: Likewise.
8009 * insdel.c: Likewise.
8010 * intervals.c: Likewise.
8011 * keyboard.c: Likewise.
8012 * keymap.c: Likewise.
8013 * lread.c: Likewise.
8014 * macros.c: Likewise.
8015 * marker.c: Likewise.
8016 * minibuf.c: Likewise.
8017 * nsfns.m: Likewise.
8018 * nsmenu.m: Likewise.
8019 * print.c: Likewise.
8020 * process.c: Likewise.
8021 * regex.c: Likewise.
8022 * region-cache.c: Likewise.
8023 * search.c: Likewise.
8024 * syntax.c: Likewise.
8025 * term.c: Likewise.
8026 * textprop.c: Likewise.
8027 * undo.c: Likewise.
8028 * unexsol.c: Likewise.
8029 * w16select.c: Likewise.
8030 * w32fns.c: Likewise.
8031 * w32menu.c: Likewise.
8032 * window.c: Likewise.
8033 * xdisp.c: Likewise.
8034 * xfns.c: Likewise.
8035 * xmenu.c: Likewise.
8036 * xml.c: Likewise.
8037 * xselect.c: Likewise.
8038
2f07e6af
EZ
80392012-06-16 Eli Zaretskii <eliz@gnu.org>
8040
1053a871
SM
8041 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
8042 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 8043 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
8044 row.
8045 (handle_face_prop): Use chunk-relative overlay string index when
8046 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
8047 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
8048 the rightmost. (Bug#11720)
2f07e6af 8049
29b83cec
AS
80502012-06-16 Andreas Schwab <schwab@linux-m68k.org>
8051
8052 * category.h (CHAR_HAS_CATEGORY): Define as inline.
8053 (CATEGORY_MEMBER): Enforce 1/0 value.
8054 * category.c (_temp_category_set): Remove.
8055
4c5501e9
EZ
80562012-06-16 Eli Zaretskii <eliz@gnu.org>
8057
8058 * window.c (Fdelete_other_windows_internal)
8059 (Fdelete_window_internal): Don't access frame's mouse highlight
8060 info of the initial frame. (Bug#11677)
8061
2b570124
PE
80622012-06-14 Paul Eggert <eggert@cs.ucla.edu>
8063
e93864f9
PE
8064 * .gdbinit (xgetint): Fix recently-introduced paren typo.
8065 Assume USE_2_TAGS_FOR_INTS.
8066 (xreload): Adjust $tagmask width to match recent lisp.h change.
8067
2b570124
PE
8068 Simplify lisp.h in minor ways that should not affect code.
8069 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
8070 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
8071 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
8072 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
8073 (INTTYPEBITS): New macro, for clarity.
8074 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
8075 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
8076 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
8077 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
8078 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
8079
81755f69
JB
80802012-06-13 Juanma Barranquero <lekktu@gmail.com>
8081
8082 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
8083
16192a57
GM
80842012-06-13 Glenn Morris <rgm@gnu.org>
8085
8086 * s/bsd-common.h (BSD4_3):
8087 * s/usg5-4-common.h (USG5_4): No longer define; unused.
8088
646b5f55
AS
80892012-06-13 Andreas Schwab <schwab@linux-m68k.org>
8090
8091 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
8092 instead of union.
8093 (XLI, XIL): Define.
1053a871
SM
8094 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
8095 Use them.
8096 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 8097 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 8098 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
8099 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
8100 * frame.c (delete_frame): Remove outdated comment.
8101 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
8102 USE_LISP_UNION_TYPE.
8103 (Fw32_unregister_hot_key): Likewise.
8104 (Fw32_toggle_lock_key): Likewise.
8105 * w32menu.c (add_menu_item): Likewise.
8106 (w32_menu_display_help): Use XIL instead of checking
8107 USE_LISP_UNION_TYPE.
8108 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
8109 (init_heap): Likewise.
8110 * w32term.c (w32_read_socket): Update comment.
8111
1d3823c9
GM
81122012-06-13 Glenn Morris <rgm@gnu.org>
8113
c62ff706
GM
8114 * s/usg5-4-common.h, src/s/unixware.h:
8115 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
8116
1d3823c9
GM
8117 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
8118
bfe3e0a2
PE
81192012-06-13 Paul Eggert <eggert@cs.ucla.edu>
8120
8121 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
8122 * alloc.c (make_number) [!defined make_number]:
8123 Remove, as lisp.h always defines this now.
8124 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
8125 (roundup_size): Verify that it is a power of 2.
8126 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
8127 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
8128 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
8129 -DUSE_LSB_TAG=0, to override the automatically-selected default.
8130 USE_LSB_TAG now is always defined to be either 0 or 1.
8131 All uses changed.
8132 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
8133 code works fine either way, and efficiency is not a concern here,
8134 as the union type is for debugging, not for production.
8135 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
8136 Use an inline function on all platforms when using the union type,
8137 since this is simpler and 'static inline' can be used portably
8138 within Emacs now.
8139 (LISP_INITIALLY_ZERO): New macro.
8140 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
8141 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
8142
45fa9c0f
GM
81432012-06-12 Glenn Morris <rgm@gnu.org>
8144
b4492cba
GM
8145 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
8146
8147 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 8148
45fa9c0f
GM
8149 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
8150 Move BROKEN_SIGIO to configure.
8151
8152 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
8153 Move NO_TERMIO to configure.
8154
0e25d334
CY
81552012-06-12 Chong Yidong <cyd@gnu.org>
8156
8157 * image.c (imagemagick_load_image): Use MagickFlattenImage if
8158 MagickMergeImageLayers is undefined. Use pixel pusher loop if
8159 MagickExportImagePixels is undefined.
8160
43682bb6
PE
81612012-06-12 Paul Eggert <eggert@cs.ucla.edu>
8162
8163 * image.c (imagemagick_load_image): Remove unused label.
8164
a9be7d2b
GM
81652012-06-11 Glenn Morris <rgm@gnu.org>
8166
8167 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
8168 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
8169 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
8170 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
8171
3017f87f
SM
81722012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
8173
8174 * alloc.c (make_byte_code): New function.
8175 (Fmake_byte_code): Use it. Don't purify here.
8176 * lread.c (read1): Use it as well to avoid extra allocation.
8177
1b9b4cf4
CY
81782012-06-11 Chong Yidong <cyd@gnu.org>
8179
8180 * image.c (imagemagick_load_image): Implement transparency.
8181
95988fcf
AS
81822012-06-10 Andreas Schwab <schwab@linux-m68k.org>
8183
8184 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
8185 account for preceding backslashes. (Bug#11663)
8186
cd4eb164
CY
81872012-06-09 Chong Yidong <cyd@gnu.org>
8188
8189 * term.c: Support italics in capable terminals (Bug#9652).
8190 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
8191 (turn_on_face): Output using TS_enter_italic_mode if available.
8192 Don't handle unused blinking and alt-charset cases.
8193 (turn_off_face): Handle italic case; discard unused tty_blinking_p
8194 and tty_alt_charset_p cases.
8195 (tty_capable_p, init_tty): Support italics.
8196
8197 * termchar.h (struct tty_display_info): Add field for italics.
8198 Remove unused blink field.
8199
8200 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
8201 Handle slant.
8202
8203 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
8204 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
8205 tty_alt_charset_p. Add tty_italic_p.
8206
ff88beb8
MA
82072012-06-09 Michael Albinus <michael.albinus@gmx.de>
8208
8209 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
8210 dbus_type_is_basic if available.
8211 (xd_extract_signed, xd_extract_unsigned): Rename from
8212 extract_signed and extract_unsigned, respectively. Adapt callers.
8213
44286096
CY
82142012-06-09 Chong Yidong <cyd@gnu.org>
8215
1682701f
CY
8216 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
8217
44286096
CY
8218 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
8219 case (Bug#9752).
8220
d86feb17
PE
82212012-06-08 Paul Eggert <eggert@cs.ucla.edu>
8222
8223 * xdisp.c (vmessage): Treat frame message as multibyte.
8224 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
8225 would generate the diagnostic "Making \302\247 buffer-local while
8226 let-bound!".
8227
d5c20fe8
EZ
82282012-06-08 Eli Zaretskii <eliz@gnu.org>
8229
8230 * dispnew.c (showing_window_margins_p): Undo last change, which
8231 was done due to an inadvertent commit.
8232 (adjust_frame_glyphs_for_frame_redisplay): Do call
8233 showing_window_margins_p.
8234
513749ee
SM
82352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
8236
8237 * eval.c (Fmake_var_non_special): New primitive.
8238 (syms_of_eval): Defsubr it.
8239 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
8240
d4a8f5c1
JB
82412012-06-08 Juanma Barranquero <lekktu@gmail.com>
8242
8243 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
8244 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
8245
8bbbc977
EZ
82462012-06-08 Eli Zaretskii <eliz@gnu.org>
8247
8248 * alloc.c (allocate_vectorlike): Fix last change.
8249
f3372c87
DA
82502012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
8251
8252 Block-based vector allocation of small vectors.
8253 * lisp.h (struct vectorlike_header): New field `nbytes',
8254 adjust comment accordingly.
8255 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 8256 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
8257 mark_maybe_pointer, valid_lisp_object_p) accordingly.
8258 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
8259 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
8260 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
8261 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
8262 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
8263 (roundup_size): New constant.
8264 (struct vector_block): New data type.
8265 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 8266 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
8267 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
8268 (sweep_vectors): New functions.
8269 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 8270 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
8271 or equal to VBLOCK_BYTES_MAX.
8272 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
8273 (init_alloc_once): Add call to init_vectors.
8274
4f18a4ed
SM
82752012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
8276
8277 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
8278
86f158bc
PE
82792012-06-07 Paul Eggert <eggert@cs.ucla.edu>
8280
8281 * doprnt.c (doprnt): Truncate multibyte char correctly.
8282 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
8283 would mishandle a string argument "Xc" if X was a multibyte
8284 character of length 2: it would truncate after X's first byte
8285 rather than including all of X.
8286
c5cfcbe0
CY
82872012-06-06 Chong Yidong <cyd@gnu.org>
8288
8289 * buffer.c (word_wrap): Doc fix.
8290
c05cf390
PE
82912012-06-04 Paul Eggert <eggert@cs.ucla.edu>
8292
8293 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
8294
0c3461de
GM
82952012-06-03 Glenn Morris <rgm@gnu.org>
8296
8297 * xdisp.c (tool-bar-style): Doc fix.
8298
c71232db
UM
82992012-06-03 Ulrich Müller <ulm@gentoo.org>
8300
8301 * Makefile.in (PAXCTL): Define.
8302 (temacs$(EXEEXT)): Disable memory randomization for the temacs
8303 binary via PaX flags if the paxctl utility is available.
8304 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
8305 Restore PaX flags to their default. (Bug#11398)
8306
383f7350
CY
83072012-06-03 Chong Yidong <cyd@gnu.org>
8308
8309 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
8310 buffer (Bug#11226).
8311
5f2c76c6
CY
83122012-06-03 Chong Yidong <cyd@gnu.org>
8313
8314 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
8315 (note_mode_line_or_margin_highlight): If there is no help echo,
8316 use mode-line-default-help-echo. Handle the case where the mouse
8317 position is past the end of the mode line string.
8318
8319 * buffer.c (buffer_local_value_1): New function, split from
8320 Fbuffer_local_value; can return Qunbound.
8321 (Fbuffer_local_value): Use it.
8322 (Vmode_line_format): Docstring tweaks.
8323
773d47f6
PE
83242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
8325
8326 * sysdep.c (system_process_attributes): Improve comment.
8327
f2d6a3df
SM
83282012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
8329
8330 * keyboard.c: Export real-this-command to Elisp.
8331 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
8332 and DEFVAR it. Update all users.
8333
63810350
PE
83342012-06-02 Paul Eggert <eggert@cs.ucla.edu>
8335
7bd5c1f4
PE
8336 * minibuf.c (Fassoc_string): Remove duplicate declaration.
8337
63810350
PE
8338 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
8339 Convert pctcpu and pctmem to Lisp float properly.
8340 Let the compiler fold better, as 100.0/0x8000 is exact.
8341
a2821611
AS
83422012-06-02 Andreas Schwab <schwab@linux-m68k.org>
8343
8344 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
8345 cons_block.
8346
5fceba1d
PE
83472012-06-01 Paul Eggert <eggert@cs.ucla.edu>
8348
8349 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
8350
c98ff5dd
DA
83512012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
8352
8353 For a 'struct window', replace some Lisp_Object fields to
8354 bitfields where appropriate, remove unused fields.
8355 * window.h (struct window): Remove unused 'last_mark_x' and
8356 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1f9f395d 8357 change its type from Lisp_Object to bitfield.
c98ff5dd
DA
8358 Change type of 'force_start', 'optional_new_start',
8359 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 8360 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 8361
ca34e0be
PE
83622012-05-31 Paul Eggert <eggert@cs.ucla.edu>
8363
8364 Pacify gcc -Wdouble-precision when using Xaw.
8365 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
8366 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
8367 Use 'float' consistently, rather than 'float' in most places
8368 and 'double' in a couple of places.
8369
efc00ab1 83702012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
8371
8372 * xdisp.c (handle_stop): Detect whether we have overlay strings
8373 loaded by testing it->current.overlay_string_index to be
8374 non-negative, instead of checking whether n_overlay_strings is
8375 positive. (Bug#11587)
8376
efc00ab1 83772012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
8378
8379 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
8380
8381 * doc.c (Fsubstitute_command_keys): Doc fix.
8382
efc00ab1 83832012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
8384
8385 * search.c (search_buffer): Remove calls to
8386 r_alloc_inhibit_buffer_relocation, as it is now called by
8387 maybe_unify_char, which was the cause of relocation of buffer text
8388 in bug#11519.
8389
efc00ab1 83902012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
8391
8392 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
8393 for the duration of call to load_charset, to avoid problems with
8394 callers of maybe_unify_char that access buffer text through C
8395 pointers.
8396
8397 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
8398 decrement the inhibition flag, instead of just setting or
8399 resetting it.
8400
ba93a187
PE
84012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
8402
8403 Remove obsolete '#define static' cruft.
8404 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
8405 This #undef was "temporary" in 2000; it is no longer needed
8406 now that '#define static' has gone away.
8407 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
8408 (gray_bitmap_bits): Remove; no longer needed.
8409 All uses replaced with definiens.
8410 * xterm.c: Include "bitmaps/gray.xbm".
8411
9e4bf381
PE
84122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
8413
8414 Clean up __executable_start, monstartup when --enable-profiling.
8415 The following changes affect the code only when profiling.
8416 * dispnew.c (__executable_start): Rename from safe_bcopy.
8417 Define only on platforms that need it.
8418 * emacs.c: Include <sys/gmon.h> when profiling.
8419 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
8420 (__executable_start): Remove decl, since lisp.h does it now.
8421 (safe_bcopy): Remove decl; no longer has that name.
8422 (main): Coalesce #if into single bit of code, for simplicity.
8423 Cast pointers to uintptr_t, since standard libraries want integers
8424 and not pointers.
8425 * lisp.h (__executable_start): New decl.
8426
32d72c2f
GM
84272012-05-31 Glenn Morris <rgm@gnu.org>
8428
8429 * image.c (Fimagemagick_types): Doc fix.
8430
baac5bc7
JM
84312012-05-30 Jim Meyering <meyering@redhat.com>
8432
8433 * callproc.c (Fcall_process_region): Include directory component
8434 in mkstemp error message (Bug#11586).
8435
72cb32cf
PE
84362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
8437
8438 * alloc.c, lisp.h (make_pure_vector): Now static.
8439
61b108cc
SM
84402012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
8441
8442 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
8443 Move to byte-run.el.
8444 (Fautoload): Do the hash-doc more carefully.
8445 * data.c (Fdefalias): Purify definition, except for keymaps.
8446 (Qdefun): Move from eval.c.
8447 * lisp.h (Qdefun): Remove.
8448 * lread.c (read1): Tiny simplification.
8449
471fe23d
TN
84502012-05-29 Troels Nielsen <bn.troels@gmail.com>
8451
934f3f58 8452 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
8453 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
8454 Bug#9642, but explicitly check that the buffer the overlay would
8455 be moved to is live and rearrange lines to make sure that errors
8456 will not put the overlay in an inconsistent state.
8457 (Fdelete_overlay): Cosmetics.
8458
85d0efd1
EZ
84592012-05-28 Eli Zaretskii <eliz@gnu.org>
8460
8461 * w32term.c (my_bring_window_to_top): New function.
8462 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
8463 could be different from the original one.
8464 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
8465 (Bug#11513)
8466
8467 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
8468 by calling BringWindowToTop.
8469
8470 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
8471 (WM_EMACS_END): Increase by one.
8472
da92a98c
PE
84732012-05-28 Paul Eggert <eggert@cs.ucla.edu>
8474
8475 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
8476 This avoids undefined behavior that might cause the eassert
8477 to not catch an out-of-range value.
8478
74d1f848
JB
84792012-05-28 Juanma Barranquero <lekktu@gmail.com>
8480
8481 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
8482 Update dependencies.
8483
9e1a06fc
EZ
84842012-05-27 Eli Zaretskii <eliz@gnu.org>
8485
8486 * bidi.c (bidi_mirror_char): Fix last change.
8487
f3dd7312
AS
84882012-05-27 Andreas Schwab <schwab@linux-m68k.org>
8489
8490 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
8491 when referring to sectname field in printf format.
8492
81899c91
PE
84932012-05-27 Paul Eggert <eggert@cs.ucla.edu>
8494
57b81a9f
PE
8495 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
8496 Only r_alloc_inhibit_buffer_relocation needed to be added;
8497 the others were already declared.
8498
81899c91
PE
8499 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
8500 before checking whether it's out of range. Put the check inside
8501 eassert. See
8502 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
8503
33017faf 85042012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
8505
8506 * callproc.c (Fcall_process): Restore a line that was accidentally
8507 commented out in the 2011-02-13 change (bug#11547).
8508
33017faf 85092012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
8510
8511 * lisp.h [REL_ALLOC]: Add prototypes for external functions
8512 defined on ralloc.c.
8513
8514 * buffer.c [REL_ALLOC]: Remove prototypes of
8515 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
8516 they are now on lisp.h.
8517
8518 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
8519
8520 * search.c (search_buffer): Use it to inhibit relocation of buffer
8521 text while re_search_2 is doing its job, because re_search_2 is
8522 passed C pointers to buffer text. (Bug#11519)
8523
23415acf
EZ
8524 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
8525 Update value to 24.
8526
44e27368
EZ
8527 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
8528 state after an additional call to move_it_in_display_line_to, keep
8529 the values of it->max_ascent and it->max_descent found for the
8530 entire line.
8531 (pos_visible_p): Revert the comparison against bottom_y to what it
8532 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
8533 (Bug#11464)
8534
c1892f11
PE
85352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
8536
8537 Fix coding-related core dumps with gcc -ftrapv.
8538 The code was computing A - B, where A and B are pointers, and B is
8539 random garbage. This can lead to core dumps on platforms that
8540 have special pointer registers, and it also leads to core dumps on
8541 x86-64 when compiled with gcc -ftrapv. The fix is to compute
8542 A - B only when B is initialized properly.
8543 * coding.c (coding_set_source, coding_set_destination): Return void.
8544 (coding_change_source, coding_change_destinations): New functions,
8545 with the old behaviors of coding_set_source and coding_set_destination.
8546 All callers that need an offset changed to use these new functions.
8547
eb7afdad
GM
85482012-05-26 Glenn Morris <rgm@gnu.org>
8549
8550 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
8551
f12fdf02
EZ
85522012-05-26 Eli Zaretskii <eliz@gnu.org>
8553
53a63be6 8554 Extend mouse support on W32 text-mode console.
61b108cc
SM
8555 * xdisp.c (draw_row_with_mouse_face):
8556 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 8557
eb3f6f01 8558 * w32console.c: Include window.h.
61b108cc
SM
8559 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
8560 New functions.
eb3f6f01
EZ
8561 (initialize_w32_display): Initialize mouse-highlight data.
8562
53a63be6
EZ
8563 * w32inevt.c: Include termchar.h and window.h.
8564 (do_mouse_event): Support mouse-autoselect-window. When the mouse
8565 moves, call note_mouse_highlight. If help_echo changed, call
8566 gen_help_event to produce help-echo message in the echo area.
8567 Call clear_mouse_face if mouse_face_hidden is set in the mouse
8568 highlight info.
8569
4cfd81f6
PE
85702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
8571
8572 * lread.c (read1): Simplify slightly to avoid an overflow warning
8573 with GCC 4.7.0 on x86-64.
8574
4446092a
EZ
85752012-05-26 Eli Zaretskii <eliz@gnu.org>
8576
8577 * bidi.c (bidi_mirror_char): Revert last change: an int is
8578 definitely wide enough here.
8579
42b2a986 85802012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 8581
42b2a986 8582 Fix integer width and related bugs (Bug#9874).
eb106a49 8583 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
8584 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
8585 (string_bytes, check_sblock, allocate_string_data):
8586 (compact_small_strings, Fmake_bool_vector, make_string)
8587 (make_unibyte_string, make_multibyte_string)
8588 (make_string_from_bytes, make_specified_string)
8589 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
8590 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
8591 (mark_vectorlike):
8592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8593 (allocate_pseudovector):
8594 Use int, not EMACS_INT, where int is wide enough.
8595 (inhibit_garbage_collection, Fgarbage_collect):
8596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8597 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
8598 int might not be wide enough.
8599 (bidi_cache_search, bidi_cache_find, bidi_init_it)
8600 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
8601 (bidi_at_paragraph_end, bidi_find_paragraph_start)
8602 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8603 (bidi_level_of_next_char, bidi_move_to_visually_next):
8604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8605 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
8606 (Fkill_buffer, Fset_buffer_major_mode)
8607 (advance_to_char_boundary, Fbuffer_swap_text)
8608 (Fset_buffer_multibyte, overlays_at, overlays_in)
8609 (overlay_touches_p, struct sortvec, record_overlay_string)
8610 (overlay_strings, recenter_overlay_lists)
8611 (adjust_overlays_for_insert, adjust_overlays_for_delete)
8612 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
8613 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
8614 (Foverlay_recenter, last_overlay_modification_hooks_used)
8615 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
8616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
8617 (validate_region): Omit unnecessary test for b <= e,
8618 since that's guaranteed by the previous test.
d311d28c
PE
8619 (adjust_overlays_for_delete): Avoid pos + length overflow.
8620 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
8621 (report_overlay_modification):
8622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8623 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
8624 Omit pointer cast, which isn't needed anyway, and doesn't work
8625 after the EMACS_INT -> ptrdiff_t change.
02481186 8626 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
8627 * buffer.h: Adjust decls to match defn changes elsewhere.
8628 (struct buffer_text, struct buffer):
8629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8630 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
8631 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
8632 not int, to avoid needless 32-bit limit on 64-bit hosts.
8633 (exec_byte_code): Use tighter memory-full test, one that checks
8634 for alloca overflow. Don't compute the address of the object just
8635 before an array, as that's not portable. Use EMACS_INT, not
8636 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
8637 * callint.c (Fcall_interactively):
8638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8639 * callproc.c (call_process_kill, Fcall_process):
8640 Don't assume pid_t fits into an Emacs fixnum.
8641 (call_process_cleanup, Fcall_process, child_setup):
8642 Don't assume pid_t fits into int.
8643 (call_process_cleanup, Fcall_process, delete_temp_file)
8644 (Fcall_process_region):
8645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8646 (Fcall_process): Simplify handling of volatile integers.
8647 Use int, not EMACS_INT, where int will do.
8648 * casefiddle.c (casify_object, casify_region, operate_on_word)
8649 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
8650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8651 (casify_object): Avoid integer overflow when overallocating buffer.
8652 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 8653 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
8654 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
8655 * category.h (CATEGORYP): Don't assume arg is nonnegative.
8656 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
8657 integers are now checked earlier. All uses replaced with XINT.
8658 (ccl_driver):
8659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8660 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
8661 (ccl_driver, Fregister_code_conversion_map):
8662 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
8663 (resolve_symbol_ccl_program): Check that vector header is in range.
8664 Always copy the vector, so that we can check its contents reliably
8665 now rather than having to recheck each instruction as it's being
8666 executed. Check that vector words fit in 'int'.
8667 (ccl_get_compiled_code, Fregister_ccl_program)
8668 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
8669 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
8670 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
8671 contents are in range.
8672 (Fccl_execute_on_string): Check that status is in range.
8673 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
8674 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
8675 Accept and return EMACS_INT, not int, because callers can pass values
8676 out of 'int' range.
8677 (c_string_width, strwidth, lisp_string_width, chars_in_text)
8678 (multibyte_chars_in_text, parse_str_as_multibyte)
8679 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
8680 (str_as_unibyte, str_to_unibyte, string_count_byte8)
8681 (string_escape_byte8, Fget_byte):
8682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 8683 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
8684 avoid mishandling large integers.
8685 * character.h: Adjust decls to match defn changes elsewhere.
8686 * charset.c (load_charset_map_from_file, find_charsets_in_text)
8687 (Ffind_charset_region):
8688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8689 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
8690 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 8691 Don't assume fixnum fits in int.
d311d28c
PE
8692 (load_charset_map_from_vector, Fmap_charset_chars):
8693 Remove now-unnecessary CHECK_NATNUMs.
8694 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
8695 Don't rely on undefined behavior with signed left shift overflow.
8696 Don't assume unsigned int fits into fixnum, or that fixnum fits
8697 into unsigned int. Don't require max_code to be a valid fixnum;
8698 that's not true for gb10830 4-byte on a 32-bit host. Allow
8699 invalid_code to be a cons, for the same reason. Require code_offset
8700 to be a character. Avoid int overflow if max_char is close
8701 to INT_MAX.
8702 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
8703 this is intended anyway and avoids some undefined behavior.
8704 (load_charset_map): Pass unsigned, not int, as 2nd arg of
8705 INDEX_TO_CODE_POINT, as that's what it expects.
8706 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
8707 * charset.h (DECODE_CHAR): Return int, not unsigned;
8708 this is what was intended anyway, and it avoids undefined behavior.
8709 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
8710 integer-overflow issues.
8711 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
8712 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
8713 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
8714 * chartab.c (Fmake_char_table, Fset_char_table_range)
8715 (uniprop_get_decoder, uniprop_get_encoder):
8716 Don't assume fixnum fits in int.
8717 * cmds.c (move_point): New function, that does the gist of
8718 Fforward_char and Fbackward_char, but does so while checking
8719 for integer overflow more accurately.
c96e5d6a 8720 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
8721 (Fforward_line, Fend_of_line, internal_self_insert)
8722 (internal_self_insert):
8723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8724 Fix a FIXME, by checking for integer overflow when calculating
8725 target_clm and actual_clm.
8726 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 8727 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
8728 (ASSURE_DESTINATION, coding_alloc_by_realloc)
8729 (coding_alloc_by_making_gap, alloc_destination)
8730 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
8731 (encode_coding_utf_16, detect_coding_emacs_mule)
8732 (decode_coding_emacs_mule, encode_coding_emacs_mule)
8733 (detect_coding_iso_2022, decode_coding_iso_2022)
8734 (encode_invocation_designation, encode_designation_at_bol)
8735 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8736 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
8737 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
8738 (encode_coding_ccl, encode_coding_raw_text)
8739 (detect_coding_charset, decode_coding_charset)
8740 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
8741 (produce_composition, produce_charset, produce_annotation)
8742 (decode_coding, handle_composition_annotation)
8743 (handle_charset_annotation, consume_chars, decode_coding_gap)
8744 (decode_coding_object, encode_coding_object, detect_coding_system)
8745 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
8746 (code_convert_region, code_convert_string)
8f50130c
PE
8747 (Fdefine_coding_system_internal)
8748 (coding_set_source, coding_set_destination):
d311d28c
PE
8749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8750 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
8751 (Fdefine_coding_system_internal):
8752 Don't assume fixnums fit in int.
8753 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 8754 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
8755 (Funencodable_char_position, Fcheck_coding_systems_region)
8756 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 8757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 8758 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 8759 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 8760 Don't access memory outside of the args array.
d311d28c 8761 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
8762 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
8763 result of ENCODE_CHAR.
d311d28c
PE
8764 * coding.h: Adjust decls to match defn changes elsewhere.
8765 (struct coding_system):
8766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8767 * composite.c (get_composition_id, find_composition)
8768 (run_composition_function, update_compositions)
8769 (compose_text, composition_gstring_put_cache)
8770 (composition_gstring_p, composition_gstring_width)
8771 (fill_gstring_header, fill_gstring_body, autocmp_chars)
8772 (composition_compute_stop_pos, composition_reseat_it)
8773 (composition_update_it, struct position_record)
8774 (find_automatic_composition, composition_adjust_point)
8775 (Fcomposition_get_gstring, Ffind_composition_internal):
8776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8777 (update_compositions):
8778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8779 * composite.h: Adjust decls to match defn changes elsewhere.
8780 (struct composition):
8781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8782 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
8783 Do not attempt to compute the address of the object just before a
8784 buffer; this is not portable.
8785 (Faref, Faset):
8786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8787 (Faset): Use int, not EMACS_INT, where int is wide enough.
8788 (Fstring_to_number): Don't assume fixnums fit in int.
8789 (Frem): Don't assume arg is nonnegative.
8790 * dbusbind.c (xd_append_arg): Check for integers out of range.
8791 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 8792 (extract_signed, extract_unsigned): New functions.
243e0530
PE
8793 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
8794 (xd_get_connection_references): Return ptrdiff_t, not int.
8795 All uses changed.
8796 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
8797 (xd_read_message_1):
8798 Use int, not unsigned, where the dbus API uses int.
8799 (Fdbus_message_internal): Don't overflow mtype.
8800 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
8801 * dired.c (directory_files_internal, file_name_completion, scmp)
8802 (file_name_completion_stat):
8803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8804 (file_name_completion): Don't overflow matchcount.
8805 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
8806 * dispextern.h: Adjust decls to match defn changes elsewhere.
8807 (struct text_pos, struct glyph, struct bidi_saved_info)
8808 (struct bidi_string_data, struct bidi_it, struct composition_it)
8809 (struct it):
8810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8811 (struct display_pos, struct composition_it, struct it):
8812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8813 * dispnew.c (increment_matrix_positions)
8814 (increment_row_positions, mode_line_string)
8815 (marginal_area_string):
8816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 8817 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
8818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8819 (duration_to_sec_usec): New function, to check for overflow better.
8820 (Fsleep_for, sit_for): Use it.
8821 * doc.c (get_doc_string, store_function_docstring):
8822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8823 (get_doc_string, Fsnarf_documentation):
8824 Use int, not EMACS_INT, where int is wide enough.
8825 (get_doc_string):
8826 Use SAFE_ALLOCA, not alloca.
8827 Check for overflow when converting EMACS_INT to off_t.
8828 * doprnt.c (doprnt):
8829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8830 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
8831 Don't assume uid_t fits into fixnum.
8832 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
8833 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
8834 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
8835 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
8836 (general_insert_function)
8837 (Finsert_char, make_buffer_string, make_buffer_string_both)
8838 (update_buffer_properties, Fbuffer_substring)
8839 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
8840 (Fsubst_char_in_region, check_translation)
8841 (Ftranslate_region_internal, save_restriction_restore, Fformat)
8842 (transpose_markers, Ftranspose_regions):
8843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8844 (clip_to_bounds): Move to lisp.h as an inline function).
8845 (Fconstrain_to_field): Don't assume integers are nonnegative.
8846 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
8847 (Fsubst_char_in_region, Fsave_restriction):
8848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8849 (Femacs_pid): Don't assume pid_t fits into fixnum.
8850 (lo_time): Use int, not EMACS_INT, when int suffices.
8851 (lisp_time_argument): Check for usec out of range.
8852 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
8853 (Fuser_login_name, Fuser_full_name): Signal an error
8854 if a uid argument is out of range, rather than relying on
8855 undefined behavior.
c8d5c857
PE
8856 (Fformat_time_string): Remove now-unnecessary check.
8857 lisp_time_argument checks for out-of-range usec now.
243e0530 8858 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
8859 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
8860 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
8861 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
8862 (init_cmdargs, Fdump_emacs):
8863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8864 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
8865 the bottom (typically) 32 bits of the fixnum.
8866 * eval.c (specpdl_size, call_debugger):
8867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8868 (when_entered_debugger, Fbacktrace_debug):
8869 Don't assume fixnum can fit in int.
8870 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
8871 the object just before a buffer; this is not portable.
8872 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
8873 (grow_specpdl, unbind_to):
8874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8875 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
8876 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 8877 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
8878 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
8879 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
8880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8881 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
8882 (a_write, e_write):
8883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8884 (Fcopy_file, non_regular_nbytes, read_non_regular)
8885 (Finsert_file_contents):
8886 Use int, not EMACS_INT, where int is wide enough.
8887 (READ_BUF_SIZE): Verify that it fits in int.
8888 (Finsert_file_contents): Check that counts are in proper range,
8889 rather than assuming fixnums fit into ptrdiff_t etc.
8890 Don't assume fixnums fit into int.
125b3835 8891 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
8892 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
8893 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
8894 (string_char_to_byte, string_byte_to_char)
8895 (string_make_multibyte, string_to_multibyte)
8896 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
8897 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
8898 (substring_both, Fdelete, internal_equal, Ffillarray)
8899 (Fclear_string, mapcar1)
8900 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
8901 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
8902 (larger_vector, make_hash_table, maybe_resize_hash_table)
8903 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
8904 (Fmaphash, secure_hash):
8905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8906 (concat): Check for string index and length overflow.
8907 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
8908 (Frequire):
8909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8910 (larger_vector): New API (vec, incr_min, size_max) replaces old
8911 one (vec, new_size, init). This catches size overflow.
8912 INIT was removed because it was always Qnil.
8913 All callers changed.
8914 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
8915 the upper bound on a hash table index size.
8916 (make_hash_table, maybe_resize_hash_table): Use it.
8917 (secure_hash): Computer start_byte and end_byte only after
8918 they're known to be in ptrdiff_t range.
8919 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
8920 (Ffont_get_glyphs, Ffont_at):
8921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8922 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
8923 (Flist_fonts, Fopen_font):
8924 Don't assume fixnum can fit in int.
8925 (check_gstring): Don't assume index can fit in int.
8926 (font_match_p): Check that fixnum is a character, not a nonnegative
8927 fixnum, since the later code needs to stuff it into an int.
8928 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
8929 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
8930 conversion overflow issues.
8931 (Fopen_font): Check for integer out of range.
8932 (Ffont_get_glyphs): Don't assume index can fit in int.
8933 * font.h: Adjust decls to match defn changes elsewhere.
8934 * fontset.c (reorder_font_vector): Redo score calculation to avoid
8935 integer overflow.
8936 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
8937 printmax_t, where ptrdiff_t is wide enough.
8938 (Finternal_char_font):
8939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8940 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
8941 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
8942 (Fset_frame_position, x_set_frame_parameters)
8943 (x_set_line_spacing, x_set_border_width)
8944 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
8945 Check that fixnums are in proper range for system types.
8946 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
8947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8948 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
8949 Use SAFE_ALLOCA_LISP, not alloca.
8950 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
8951 intptr_t is wide enough.
8952 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
8953 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
8954 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
8955 Check for fixnum out of range.
8956 * ftfont.c (ftfont_list): Don't assume index fits in int.
8957 Check that fixnums are in proper range for system types.
8958 (ftfont_shape_by_flt):
8959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
8960 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8962 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
8963 Check that fixnums are in proper range for system types.
8964 * gnutls.h: Adjust decls to match defn changes elsewhere.
8965 * gtkutil.c (xg_dialog_run):
8966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8967 (update_frame_tool_bar):
8968 Check that fixnums are in proper range for system types.
8969 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 8970 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
8971 * indent.c (last_known_column, last_known_column_point):
8972 (current_column_bol_cache):
8973 (skip_invisible, current_column, check_display_width):
8974 (check_display_width, scan_for_column, current_column_1)
8975 (Findent_to, Fcurrent_indentation, position_indentation)
8976 (indented_beyond_p, Fmove_to_column, compute_motion):
8977 (Fcompute_motion, Fvertical_motion):
8978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8979 (last_known_column_modified): Use EMACS_INT, not int.
8980 (check_display_width):
8981 (Fcompute_motion):
8982 Check that fixnums and floats are in proper range for system types.
8983 (compute_motion): Don't assume index or fixnum fits in int.
8984 (compute_motion, Fcompute_motion):
8985 Use int, not EMACS_INT, when it is wide enough.
8986 (vmotion): Omit local var start_hpos that is always 0; that way
8987 we don't need to worry about overflow in expressions involving it.
8988 * indent.h: Adjust decls to match defn changes elsewhere.
8989 (struct position):
8990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8991 Use int, not EMACS_INT, where int is wide enough.
8992 Remove unused members ovstring_chars_done and tab_offset;
8993 all uses removed.
8994 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
8995 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
8996 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
8997 (make_gap, copy_text, insert, insert_and_inherit)
8998 (insert_before_markers, insert_before_markers_and_inherit)
8999 (insert_1, count_combining_before, count_combining_after)
9000 (insert_1_both, insert_from_string)
9001 (insert_from_string_before_markers, insert_from_string_1)
9002 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
9003 (adjust_after_replace, adjust_after_insert, replace_range)
9004 (replace_range_2, del_range, del_range_1, del_range_byte)
9005 (del_range_both, del_range_2, modify_region)
9006 (prepare_to_modify_buffer, signal_before_change)
9007 (signal_after_change, Fcombine_after_change_execute):
9008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9009 * intervals.c (traverse_intervals, rotate_right, rotate_left)
9010 (balance_an_interval, split_interval_right, split_interval_left)
9011 (find_interval, next_interval, update_interval)
9012 (adjust_intervals_for_insertion, delete_node, delete_interval)
9013 (interval_deletion_adjustment, adjust_intervals_for_deletion)
9014 (static_offset_intervals, offset_intervals)
9015 (merge_interval_right, merge_interval_left, make_new_interval)
9016 (graft_intervals_into_buffer, temp_set_point_both)
9017 (temp_set_point, set_point, adjust_for_invis_intang)
9018 (set_point_both, move_if_not_intangible, get_property_and_range)
9019 (get_local_map, copy_intervals, copy_intervals_to_string)
9020 (compare_string_intervals, set_intervals_multibyte_1):
9021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9022 * intervals.h: Adjust decls to match defn changes elsewhere.
9023 (struct interval):
9024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9025 * keyboard.c (this_command_key_count, this_single_command_key_start)
9026 (before_command_key_count, before_command_echo_length, echo_now)
9027 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
9028 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
9029 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
9030 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
9031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9032 (last_non_minibuf_size, last_point_position, echo_truncate)
9033 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
9034 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
9035 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
9036 (stuff_buffered_input):
9037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9038 (last_auto_save, command_loop_1, read_char):
9039 Use EMACS_INT, not int, to avoid integer overflow.
9040 (record_char): Avoid overflow in total_keys computation.
9041 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
9042 * keyboard.h: Adjust decls to match defn changes elsewhere.
9043 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
9044 (Fkey_description, Fdescribe_vector, Flookup_key):
9045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9046 (click_position): New function, to check that positions are in range.
9047 (Fcurrent_active_maps):
9048 (describe_command):
9049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9050 (Faccessible_keymaps, Fkey_description):
9051 (preferred_sequence_p):
9052 Don't assume fixnum can fit into int.
9053 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
9054 Check for integer overflow in size calculations.
9055 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
9056 avoid mishandling large integers.
9057 * lisp.h: Adjust decls to match defn changes elsewhere.
9058 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
9059 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
9060 (struct Lisp_Marker):
9061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9062 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
9063 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
9064 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
9065 All callers changed.
9066 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
9067 Assume the arg has valid form, since it always does.
9068 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
9069 unsigned integer system type.
9070 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
9071 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
9072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9073 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
9074 (duration_to_sec_usec): New decl.
9075 * lread.c (read_from_string_index, read_from_string_index_byte)
9076 (read_from_string_limit, readchar, unreadchar, openp)
9077 (read_internal_start, read1, oblookup):
9078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9079 (Fload, readevalloop, Feval_buffer, Feval_region):
9080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9081 (openp): Check for out-of-range argument to 'access'.
9082 (read1): Use int, not EMACS_INT, where int is wide enough.
9083 Don't assume fixnum fits into int.
6efdadfd 9084 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
9085 (read_filtered_event): Use duration_to_sec_usec
9086 to do proper overflow checking on durations.
d311d28c
PE
9087 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
9088 in size calculation.
9089 (Fexecute_kbd_macro):
9090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9091 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
9092 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
9093 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
9094 (set_marker_both, set_marker_restricted_both, marker_position)
9095 (marker_byte_position, Fbuffer_has_markers_at):
9096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9097 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 9098 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
9099 It now merely ensures that the menu is large enough, without
9100 necessarily growing it, as this avoids some integer overflow issues.
9101 All callers changed.
9102 (keymap_panes, parse_single_submenu, Fx_popup_menu):
9103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9104 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
9105 Use SAFE_ALLOCA_LISP, not alloca.
9106 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
9107 to EMACS_INT. Check that fixnums are in proper range for system types.
9108 * minibuf.c (minibuf_prompt_width, string_to_object)
9109 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
9110 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
9111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9112 (get_minibuffer, read_minibuf_unwind):
9113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9114 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
9115 this simplifies overflow checking. All callers changed.
9116 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
9117 (Ftest_completion):
9118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9119 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
9120 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
9121 Check that fixnums are in proper range for system types.
9122 (Fx_create_frame, Fx_show_tip):
9123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9124 * nsfont.m (ns_findfonts, nsfont_list_family):
9125 Don't assume fixnum fits in long.
9126 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
9127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9128 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
9129 wide enough.
17fdb222 9130 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
9131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9132 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
9133 (PRINTDECLARE, PRINTPREPARE):
9134 (strout, print_string):
9135 (print, print_preprocess, print_check_string_charset_prop)
9136 (print_object):
9137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9138 (PRINTDECLARE):
9139 (temp_output_buffer_setup, Fprin1_to_string, print_object):
9140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9141 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 9142 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 9143 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
9144 (print_error_message): Use SAFE_ALLOCA, not alloca.
9145 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
9146 (print_depth, new_backquote_output, print_number_index):
9147 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
9148 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
9149 (Fset_process_window_size, Fformat_network_address)
9150 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 9151 (sigchld_handler):
d311d28c 9152 Check that fixnums are in proper range for system types.
d44287d4 9153 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
9154 Check for process-ids out of pid_t range rather than relying on
9155 undefined behavior.
e4d81efc 9156 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
9157 (Fformat_network_address, read_process_output, send_process)
9158 (Fprocess_send_region, status_notify):
9159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9160 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
9161 (wait_reading_process_output, read_process_output, exec_sentinel):
9162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9163 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
9164 (Faccept_process_output): Use duration_to_sec_usec to do proper
9165 overflow checking on durations.
dde14581
PE
9166 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
9167 Don't assume pid_t fits in int.
02481186
PE
9168 * process.h (struct Lisp_Process): Members tick and update_tick
9169 are now of type EMACS_INT, not int.
b62b53e8
PE
9170 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
9171 configured --with-wide-int.
d311d28c
PE
9172 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
9173 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
9174 * search.c (looking_at_1, string_match_1):
9175 (fast_string_match, fast_c_string_match_ignore_case)
9176 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
9177 (scan_newline, find_before_next_newline, search_command)
9178 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
9179 (set_search_regs, wordify):
9180 (Freplace_match):
9181 (Fmatch_data):
9182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9183 (string_match_1, search_buffer, set_search_regs):
9184 (Fmatch_data):
9185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9186 (wordify): Check for overflow in size calculation.
9187 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
9188 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
9189 Check that fixnums are in proper range for system types.
9190 * sound.c (struct sound_device)
9191 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
9192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9193 (Fplay_sound_internal):
9194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 9195 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
9196 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
9197 (Fparse_partial_sexp):
9198 Don't assume fixnums can fit in int.
9199 (struct lisp_parse_state, find_start_pos, find_start_value)
9200 (find_start_value_byte, find_start_begv)
9201 (update_syntax_table, char_quoted, dec_bytepos)
9202 (find_defun_start, prev_char_comend_first, back_comment):
9203 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
9204 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
9205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9206 (Finternal_describe_syntax_value): Check that match_lisp is a
9207 character, not an integer, since the code stuffs it into int.
9208 (scan_words, scan_sexps_forward):
9209 Check that fixnums are in proper range for system types.
9210 (Fforward_word):
9211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9212 (scan_sexps_forward):
9213 Use CHARACTERP, not INTEGERP, since the value must fit into int.
9214 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
9215 * syntax.h: Adjust decls to match defn changes elsewhere.
9216 (struct gl_state_s):
9217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
9218 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
9219 MOST_POSITIVE_FIXNUM.
d311d28c
PE
9220 * sysdep.c (wait_for_termination_1, wait_for_termination)
9221 (interruptible_wait_for_termination, mkdir):
9222 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
9223 (emacs_read, emacs_write):
9224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
9225 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
9226 and double all fit in int.
d311d28c
PE
9227 * term.c (set_tty_color_mode):
9228 Check that fixnums are in proper range for system types.
9229 * termhooks.h (struct input_event):
9230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9231 * textprop.c (validate_interval_range, interval_of)
9232 (Fadd_text_properties, set_text_properties_1)
9233 (Fremove_text_properties, Fremove_list_of_text_properties)
9234 (Ftext_property_any, Ftext_property_not_all)
9235 (copy_text_properties, text_property_list, extend_property_ranges)
9236 (verify_interval_modification):
9237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9238 (Fnext_single_char_property_change)
9239 (Fprevious_single_char_property_change):
9240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
9241 (copy_text_properties):
9242 Check for integer overflow in index calculation.
d311d28c
PE
9243 * undo.c (last_boundary_position, record_point, record_insert)
9244 (record_delete, record_marker_adjustment, record_change)
9245 (record_property_change):
9246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9247 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
9248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9249 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
9250 (Fx_hide_tip, Fx_file_dialog):
9251 * w32menu.c (set_frame_menubar):
9252 Use ptrdiff_t, not int, for consistency with rest of code.
9253 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
9254 (select_window, Fdelete_other_windows_internal)
9255 (window_scroll_pixel_based, window_scroll_line_based)
9256 (Frecenter, Fset_window_configuration):
9257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9258 (Fset_window_hscroll, run_window_configuration_change_hook)
9259 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 9260 (Fscroll_other_window, Frecenter):
d311d28c
PE
9261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9262 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
9263 Don't assume fixnum fits in int.
9264 (Fset_window_scroll_bars):
9265 Check that fixnums are in proper range for system types.
9266 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
9267 (string_pos, c_string_pos, number_of_chars, init_iterator)
9268 (in_ellipses_for_invisible_text_p, init_from_display_pos)
9269 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
9270 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
9271 (face_before_or_after_it_pos, handle_invisible_prop)
9272 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
9273 (display_prop_intangible_p, string_buffer_position_lim)
9274 (string_buffer_position, handle_composition_prop, load_overlay_strings)
9275 (get_overlay_strings_1, get_overlay_strings)
9276 (iterate_out_of_display_property, forward_to_next_line_start)
9277 (back_to_previous_visible_line_start, reseat, reseat_to_string)
9278 (get_next_display_element, set_iterator_to_next)
9279 (get_visually_first_element, compute_stop_pos_backwards)
9280 (handle_stop_backwards, next_element_from_buffer)
9281 (move_it_in_display_line_to, move_it_in_display_line)
9282 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9283 (add_to_log, message_dolog, message_log_check_duplicate)
9284 (message2, message2_nolog, message3, message3_nolog
9285 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
9286 (current_message_1, truncate_echo_area, truncate_message_1)
9287 (set_message, set_message_1, store_mode_line_noprop)
9288 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
9289 (text_outside_line_unchanged_p, check_point_in_composition)
9290 (reconsider_clip_changes)
9291 (redisplay_internal, set_cursor_from_row, try_scrolling)
9292 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
9293 (redisplay_window, find_last_unchanged_at_beg_row)
9294 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
9295 (trailing_whitespace_p, find_row_edges, display_line)
9296 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
9297 (display_mode_element, store_mode_line_string)
9298 (pint2str, pint2hrstr, decode_mode_spec)
9299 (display_count_lines, display_string, draw_glyphs)
9300 (x_produce_glyphs, x_insert_glyphs)
9301 (rows_from_pos_range, mouse_face_from_buffer_pos)
9302 (fast_find_string_pos, mouse_face_from_string_pos)
9303 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9305 (safe_call, init_from_display_pos, handle_fontified_prop)
9306 (handle_single_display_spec, load_overlay_strings)
9307 (with_echo_area_buffer, setup_echo_area_for_printing)
9308 (display_echo_area, echo_area_display)
9309 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
9310 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
9311 (redisplay_window, dump_glyph_row, display_mode_line)
9312 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 9313 (handle_display_spec, display_prop_string_p):
d311d28c
PE
9314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9315 (handle_single_display_spec, build_desired_tool_bar_string)
9316 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
9317 (get_specified_cursor_type):
9318 Check that fixnums are in proper range for system types.
9319 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
9320 (Flookup_image_map):
9321 Don't assume fixnums fit in int.
9322 (compare_overlay_entries):
9323 Avoid mishandling comparisons due to subtraction overflow.
9324 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
9325 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
9326 (handle_tool_bar_click):
9327 Use int, not unsigned, since we prefer signed and the signedness
9328 doesn't matter here.
9329 (get_next_display_element, next_element_from_display_vector):
9330 Use int, not EMACS_INT, when int is wide enough.
9331 (start_hourglass): Use duration_to_sec_usec to do proper
9332 overflow checking on durations.
9333 * xfaces.c (Fbitmap_spec_p):
9334 Check that fixnums are in proper range for system types.
9335 (compare_fonts_by_sort_order):
9336 Avoid mishandling comparisons due to subtraction overflow.
9337 (Fx_family_fonts, realize_basic_faces):
9338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9339 (Fx_family_fonts):
9340 Don't assume fixnum fits in int.
9341 Use SAFE_ALLOCA_LISP, not alloca.
9342 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
9343 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
9344 (face_at_buffer_position, face_for_overlay_string)
9345 (face_at_string_position):
9346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9347 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
9348 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
9349 (Fx_show_tip):
9350 Check that fixnums are in proper range for system types.
9351 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
9352 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
9353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9354 (Fx_change_window_property): Don't assume fixnums fit in int.
9355 * xfont.c (xfont_chars_supported):
9356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9357 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
9358 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
9359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9360 * xml.c (parse_region):
9361 * xrdb.c (magic_file_p):
9362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
9363 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
9364 (x_get_local_selection, x_reply_selection_request)
9365 (x_handle_selection_request, wait_for_property_change):
9366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9367 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
9368 short is wide enough.
9369 (x_send_client_event): Don't assume fixnum fits in int.
9370 * xterm.c (x_x_to_emacs_modifiers):
9371 Don't assume EMACS_INT overflows nicely into int.
9372 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
9373 may come from Lisp.
9374 (handle_one_xevent): NATNUMP can eval its arg twice.
9375 (x_connection_closed):
9376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
9377 * xterm.h: Adjust decls to match defn changes elsewhere.
9378 (struct scroll_bar): Use struct vectorlike_header
9379 rather than rolling our own approximation.
9380 (SCROLL_BAR_VEC_SIZE): Remove; not used.
9381
c6574eb5
GM
93822012-05-25 Glenn Morris <rgm@gnu.org>
9383
9384 * lisp.mk (lisp): Update for more files being compiled now.
9385
e8d32c7e
SM
93862012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
9387
48def666
SM
9388 * lread.c: Remove `read_pure' which makes no difference.
9389 (read_pure): Remove var.
9390 (unreadpure): Remove function.
9391 (readevalloop): Don't call read_list with -1 flag.
9392 (read1, read_vector): Don't test read_pure any more.
9393 (read_list): Simplify.
9394
e8d32c7e
SM
9395 * fileio.c, character.h: Minor style tweaks.
9396
4b2addb7
DA
93972012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
9398
9399 * window.h (clip_changed): Remove useless declaration.
9400
584461b2
JB
94012012-05-22 Juanma Barranquero <lekktu@gmail.com>
9402
9403 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
9404 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
9405
34374650
PE
94062012-05-22 Paul Eggert <eggert@cs.ucla.edu>
9407
9408 Remove src/m/*.
9409 This directory predates autoconf and is no longer needed nowadays.
9410 Move its few remaining bits of functionality to where they're needed.
9411 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
9412 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
9413 * m/template.h: Remove.
9414 * Makefile.in (M_FILE): Remove. All uses removed.
9415 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
9416 * lisp.h (USE_LSB_TAG):
9417 * mem-limits.h (EXCEEDS_LISP_PTR):
9418 Use VAL_MAX, not VALBITS, in #if.
9419 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
9420 (EMACS_UINT): Define unconditionally now.
9421 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
9422 (BITS_PER_EMACS_INT): New constants, replacing
9423 what used to be in config.h, but not useful in #if.
9424 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
9425 define them any more.
9426 (VAL_MAX): New macro.
9427 (VALMASK): Use it.
9428 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
9429 BITS_PER_EMACS_INT, in #if.
9430 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
9431 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
9432 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
9433 * s/ms-w32.h (DATA_START):
9434 Move here from removed file m/intel386.h.
9435 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
9436 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
9437
261cb4bb
PE
94382012-05-21 Paul Eggert <eggert@cs.ucla.edu>
9439
9440 Assume C89 or later.
9441 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
9442 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
9443 (xrealloc):
9444 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
9445 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
9446 * textprop.c, tparam.c (NULL): Remove.
9447 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
9448 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
9449 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
9450 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
9451 * xterm.c (input_signal_count): Assume volatile works.
9452
ff23cd9f
KB
94532012-05-21 Ken Brown <kbrown@cornell.edu>
9454
9455 * xgselect.c (xg_select): Fix first argument in call to 'select'
9456 (bug#11508).
9457
1b170bc6
KB
94582012-05-20 Ken Brown <kbrown@cornell.edu>
9459
9460 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 9461 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 9462
b2f4d39f
KB
94632012-05-19 Ken Brown <kbrown@cornell.edu>
9464
9465 * xfns.c (x_in_use): Remove `static' qualifier.
9466 * xterm.h (x_in_use): Declare.
9467 * xgselect.c: Include xterm.h.
9468 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
9469 and `display_arg' (bug#9754).
9470
003fdae2
PE
94712012-05-19 Paul Eggert <eggert@cs.ucla.edu>
9472
9232a6d9
PE
9473 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
9474
003fdae2
PE
9475 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
9476 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
9477
784b56e2
EZ
94782012-05-18 Eli Zaretskii <eliz@gnu.org>
9479
9480 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
9481
9482 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 9483 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
9484
9485 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
9486 reference to image_cache->refcount.
9487 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
9488
a0a79cde
JL
94892012-05-17 Juri Linkov <juri@jurta.org>
9490
9491 * search.c (Fword_search_regexp, Fword_search_backward)
9492 (Fword_search_forward, Fword_search_backward_lax)
9493 (Fword_search_forward_lax): Move functions to isearch.el
9494 (bug#10145, bug#11381).
9495
b0572523
PE
94962012-05-16 Paul Eggert <eggert@cs.ucla.edu>
9497
9498 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
9499
9660f5fc
SM
95002012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
9501
9502 * lread.c (init_obarray): Declare Qt and Qnil as special.
9503
4374de83
GM
95042012-05-14 Glenn Morris <rgm@gnu.org>
9505
9506 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 9507 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 9508
dc44c39a
PE
95092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
9510
078c97cb
PE
9511 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
9512
dc44c39a
PE
9513 * unexaix.c: Port to more-recent AIX compilers.
9514 (report_error, report_error_1, make_hdr, copy_sym)
9515 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
9516 Make arguments const char *, not char *, to avoid violations of C
9517 standard and to fix some AIX warnings reported by Gilles Pion.
9518
e18afed7 95192012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
9520
9521 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
9522 already have overlays loaded.
9523 (handle_single_display_spec): Before returning without displaying
9524 fringe bitmap, synchronize the bidi iterator with the main display
9525 iterator, by calling iterate_out_of_display_property.
9526 (iterate_out_of_display_property): Detect buffer iteration by
9527 testing that it->string is a Lisp string.
9528 (get_next_display_element): When the current object is exhausted,
9529 and there's something on it->stack, call set_iterator_to_next to
9530 proceed with what's on the stack, instead of returning zero.
9531 (set_iterator_to_next): If called at the end of a Lisp string,
9532 proceed to consider_string_end without incrementing string
9533 position. Don't increment display vector index past the end of
9534 the display vector. (Bug#11417)
c8fb9dc6
EZ
9535 (pos_visible_p): Don't report a position visible when move_it_to
9536 stopped at the last line of window, which happens to be scanned
9537 backwards by the bidi iteration. (Bug#11464)
ac268e67 9538
e18afed7 95392012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
9540
9541 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
9542 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
9543 are on a TTY, and thus unable to display on the fringes.
9544 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
9545 so we need to signal to the caller that this is a "replacing"
9546 display spec. This fixes display when the spec is invalid or we
9547 are on a TTY.
9548
e18afed7 95492012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
9550
9551 * unexaix.c (make_hdr): Fix typo in prototype.
9552 This bug broke the build on AIX. Problem reported by Gilles Pion.
9553
9d0a235a
MA
95542012-05-14 Michael Albinus <michael.albinus@gmx.de>
9555
9556 * keyboard.c (kbd_buffer_get_event): Read special events also in
9557 batch mode. (Bug#11415)
9558
9e6b06ed
GM
95592012-05-12 Glenn Morris <rgm@gnu.org>
9560
9561 * ns.mk: Update for ns_appbindir no longer having trailing "/".
9562
c1a1d7a3
EZ
95632012-05-12 Eli Zaretskii <eliz@gnu.org>
9564
9565 * lisp.mk (lisp): Add newcomment.elc.
9566
3fe7cdc8
GM
95672012-05-12 Glenn Morris <rgm@gnu.org>
9568
9569 * Makefile.in (MKDIR_P): New, set by configure.
9570 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
9571
53f7d2c0
PE
95722012-05-11 Paul Eggert <eggert@cs.ucla.edu>
9573
9574 Remove unused function hourglass_started.
9575 * dispextern.h (hourglass_started):
9576 * w32fns.c (hourglass_started):
9577 * xdisp.c (hourglass_started): Remove.
9578
75aafb17
JB
95792012-05-10 Juanma Barranquero <lekktu@gmail.com>
9580
9581 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
9582 Update dependencies.
9583
12959e8e
PE
95842012-05-10 Paul Eggert <eggert@cs.ucla.edu>
9585
97107e2e
PE
9586 * xgselect.c (xg_select): Put maxfds+1 into a var.
9587 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
9588
12959e8e
PE
9589 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
9590
836d29b3
DA
95912012-05-10 Dave Abrahams <dave@boostpro.com>
9592
9593 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
9594 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
9595
5cb67954
MA
95962012-05-09 Michael Albinus <michael.albinus@gmx.de>
9597
9598 * dbusbind.c (xd_registered_buses): New internal Lisp object.
9599 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
9600 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
9601 Initialize xd_registered_buses.
9602
3478ec45
PE
96032012-05-09 Paul Eggert <eggert@cs.ucla.edu>
9604
b263a6b0
PE
9605 Untag more efficiently if USE_LSB_TAG.
9606 This is based on a proposal by YAMAMOTO Mitsuharu in
9607 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
9608 For an admittedly artificial (nth 8000 longlist) benchmark on
9609 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
9610 Emacs's overall text size by 1%.
9611 * lisp.h (XUNTAG): New macro.
9612 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
9613 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
9614 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
9615 * eval.c (Fautoload):
9616 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
9617 * frame.h (XFRAME): Use XUNTAG.
9618
3478ec45
PE
9619 Port recent dbusbind.c changes to 32-bit --with-wide-int.
9620 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
9621 Remove unportable assumptions about print widths of types like
9622 dbus_uint32_t.
9623 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
9624 intptr_t when converting between pointer and integer, to avoid GCC
9625 warnings about wrong width.
9626
666b903b 96272012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
9628
9629 * w32proc.c (new_child): Force Windows to reserve only 64KB of
9630 stack for each reader_thread, instead of defaulting to 8MB
9631 determined by the linker. This avoids failures in creating
9632 subprocesses on Windows 7, see the discussion in this thread:
9633 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
9634
b120cc17
JC
96352012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
9636
9637 Fix up display of the *Minibuf-0* buffer in the mini window.
9638 * keyboard.c (read_char): Don't clear the echo area if there's no
9639 message to clear.
9640 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 9641 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 9642
9a4b36f8
MA
96432012-05-07 Michael Albinus <michael.albinus@gmx.de>
9644
9645 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
9646 batch mode.
9647
e5f9458f
CY
96482012-05-06 Chong Yidong <cyd@gnu.org>
9649
9650 * lisp.mk (lisp): Update.
9651
eceeb5fc 96522012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
9653
9654 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
9655
71873e2b
SM
96562012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
9657
9658 * data.c (PUT_ERROR): New macro.
9659 (syms_of_data): Use it. Add new error type `user-error'.
9660 * undo.c (user_error): New function.
9661 (Fprimitive_undo): Use it.
9662 * print.c (print_error_message): Adjust print style for `user-error'.
9663 * keyboard.c (user_error): New function.
9664 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
9665
ab0fa4e4
PE
96662012-05-03 Paul Eggert <eggert@cs.ucla.edu>
9667
9668 Do not limit current-time-string to years 1000..9999.
9669 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
9670 (Fcurrent_time_string): Support any year that is supported by the
9671 underlying localtime representation. Don't use asctime, as it
9672 has undefined behavior for years outside the range -999..9999.
9673
7ed806a7
PE
96742012-05-02 Paul Eggert <eggert@cs.ucla.edu>
9675
9676 Fix race conditions involving setenv, gmtime, localtime, asctime.
9677 Without this fix, interrupts could mess up code that uses these
9678 nonreentrant functions, since setting TZ invalidates existing
9679 tm_zone or tzname values, and since most of these functions return
9680 pointers to static storage.
9681 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
9682 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
9683 Grow the critical sections to include not just invoking
9684 localtime/gmtime, but also accessing these functions' results
9685 including their tm_zone values if any, and any related TZ setting.
9686 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
9687 so that the struct tm is saved in the critical section.
9688 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
9689 motivated by the fact that memory allocation needs to be outside
9690 the critical section.
9691
0c16dfed
DA
96922012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
9693
9694 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
9695 with RESET_INTERVAL.
9696
9697 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9698 Remove duplicated buffer name initialization.
9699
3f83ace8
JM
97002012-05-02 Jim Meyering <jim@meyering.net>
9701
9702 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
9703
c7b8541e
JM
9704 * xfns.c (x_window): Use xstrdup (Bug#11375).
9705
90207a15 97062012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
9707
9708 * xdisp.c (pos_visible_p): If already at a newline from the
9709 display string before the 'while' loop, don't walk back the glyphs
9710 from it3.glyph_row. Solves assertion violation when the display
9711 string begins with a newline (egg.el). (Bug#11367)
9712
b593d6a9
AH
97132012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
9714
9715 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
9716 Move to simple.el.
9717
4737362e
GM
97182012-05-01 Glenn Morris <rgm@gnu.org>
9719
99cf43f9
GM
9720 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
9721 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
9722 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
9723 All were removed before 23.1.
9724
9311dcff
GM
9725 * dispnew.c: Remove HAVE_LIBNCURSES test;
9726 it is always true on relevant platforms.
9727
4d5c6349
GM
9728 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
9729 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
9730
4737362e
GM
9731 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
9732
74dd3a6b
AS
97332012-04-30 Andreas Schwab <schwab@linux-m68k.org>
9734
9735 * .gdbinit (xpr): Remove checks for no longer existing misc types.
9736 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
9737 Remove.
9738
13c379ee
PE
97392012-04-28 Paul Eggert <eggert@cs.ucla.edu>
9740
9741 Do not avoid creating empty evaporating overlays (Bug#9642).
9742 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
9743 That is, do not delete an evaporating overlay if it becomes
9744 empty after its bounds are adjusted to fit within its buffer.
9745 This fix caused other problems, and I'm reverting it until we get
9746 to the bottom of them.
9747
a8e7d6d7 97482012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
9749
9750 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
9751
a8e7d6d7 97522012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
9753
9754 * xdisp.c (pos_visible_p): If the window start position is beyond
9755 ZV, start the display from buffer beginning. Prevents assertion
9756 violation in init_iterator when the minibuffer window is scrolled
9757 via the scroll bar.
9758
9759 * window.c (window_scroll_pixel_based): Likewise.
9760
a8e7d6d7 97612012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
9762
9763 * keymap.c (where_is_internal): Doc fix (Bug#10872).
9764
a8e7d6d7 97652012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
9766
9767 * fileio.c (Fcopy_file, Fset_file_selinux_context):
9768 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
9769
a8e7d6d7 97702012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 9771
b593d6a9
AH
9772 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
9773 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 9774
1c6900d9
EZ
97752012-04-26 Eli Zaretskii <eliz@gnu.org>
9776
4c3fa1d9
EZ
9777 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
9778 display element, check also the underlying string or buffer
9779 character. (Bug#11341)
9780
1c6900d9
EZ
9781 * w32menu.c: Include w32heap.h.
9782 (add_menu_item): If the call to AppendMenuW (via
9783 unicode_append_menu) fails, disable Unicode menus only if we are
9784 running on Windows 9X/Me.
9785
42bf8205
AS
97862012-04-24 Andreas Schwab <schwab@linux-m68k.org>
9787
9788 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
9789 (xgetint): Add missing shift for LSB tags.
9790
b1bac16e
MR
97912012-04-24 Martin Rudalics <rudalics@gmx.at>
9792
9793 * keyboard.c (read_char): Don't wipe echo area for select window
9794 events: These might get delayed via `mouse-autoselect-window'
9795 (Bug#11304).
9796
d69621cc
JB
97972012-04-24 Juanma Barranquero <lekktu@gmail.com>
9798
9799 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
9800 manipulation of :loaded-from data.
9801
02fd101b
JB
98022012-04-23 Juanma Barranquero <lekktu@gmail.com>
9803
9804 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
9805 now a cons (bug#11311).
9806
888bec30
PE
98072012-04-23 Paul Eggert <eggert@cs.ucla.edu>
9808
89a438bd
PE
9809 Do not create empty overlays with the evaporate property (Bug#9642).
9810 * buffer.c (Fmove_overlay): Delete an evaporating overlay
9811 if it becomes empty after its bounds are adjusted to fit within
9812 its buffer. Without this fix, in a nonempty buffer (let ((o
9813 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
9814 yields an empty overlay that has the evaporate property, which is
9815 not supposed to happen.
9816
1068fe4d
PE
9817 Fix minor GTK3 problems found by static checking.
9818 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
9819 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
9820 (struct _EmacsFixedClass, emacs_fixed_get_type):
9821 Move decls here from emacsgtkfixed.h, since they needn't be public.
9822 (emacs_fixed_get_type): Now static.
9823 (emacs_fixed_class_init): Omit unused local.
9824 (emacs_fixed_child_type): Remove; unused.
9825 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
9826 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
9827 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
9828 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
9829 (EMACS_FIXED_GET_CLASS): Remove; unused.
9830 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
9831
888bec30
PE
9832 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
9833 Problem reported by Juanma Barranquero for Windows -Wunused-function.
9834
de85e130
PE
98352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
9836
d0baac98 9837 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 9838 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
9839 (__malloc_size_t, __malloc_ptrdiff_t):
9840 Remove. All uses removed, replaced by the definiens if needed,
9841 since we can assume C89 or better now.
9842 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
9843 (protect_malloc_state, align, get_contiguous_space)
9844 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
9845 (malloc_atfork_handler_child, malloc_enable_thread)
9846 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
9847 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
9848 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
9849 (special_realloc, _realloc_internal_nolock, _realloc_internal)
9850 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
9851 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
9852 Define using prototypes, not old style.
9853 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
9854 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
9855 (align): Don't assume that signed integer overflow wraps around.
9856 Omit unused local var.
9857 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
9858 (_free_internal_nolock, memalign, mallochook, reallochook):
9859 Omit no-longer-needed casts.
9860 (valloc): Use getpagesize, not __getpagesize.
9861 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
9862 (struct hdr): The 'magic' member is now size_t, not unsigned long.
9863
de85e130
PE
9864 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
9865
dcbf5805
MA
98662012-04-22 Michael Albinus <michael.albinus@gmx.de>
9867
9868 Move functions from C to Lisp. Make non-blocking method calls
9869 the default. Implement further D-Bus standard interfaces.
9870
9871 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
9872 (QCdbus_request_name_allow_replacement)
9873 (QCdbus_request_name_replace_existing)
9874 (QCdbus_request_name_do_not_queue)
9875 (QCdbus_request_name_reply_primary_owner)
9876 (QCdbus_request_name_reply_in_queue)
9877 (QCdbus_request_name_reply_exists)
9878 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
9879 (QCdbus_registered_serial, QCdbus_registered_method)
9880 (QCdbus_registered_signal): New Lisp objects.
9881 (XD_DEBUG_MESSAGE): Use sizeof.
9882 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
9883 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
9884 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
9885 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
9886 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
9887 (xd_signature, xd_append_arg): Allow float for integer types.
9888 (xd_get_connection_references): New function.
b593d6a9
AH
9889 (xd_get_connection_address): Rename from xd_initialize.
9890 Return cached address.
dcbf5805
MA
9891 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
9892 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
9893 level.
9894 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 9895 Return number of refcounts.
dcbf5805
MA
9896 (Fdbus_get_unique_name): Make stronger parameter check.
9897 (Fdbus_message_internal): New defun.
9898 (Fdbus_call_method, Fdbus_call_method_asynchronously)
9899 (Fdbus_method_return_internal, Fdbus_method_error_internal)
9900 (Fdbus_send_signal, Fdbus_register_service)
9901 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
9902 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
9903 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
9904 (Vdbus_compiled_version, Vdbus_runtime_version)
9905 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
9906 (Vdbus_message_type_method_return, Vdbus_message_type_error)
9907 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
9908 (Vdbus_registered_buses, Vdbus_registered_objects_table):
9909 Adapt docstring.
dcbf5805 9910
52828e02
PE
99112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
9912
da05bc4c
PE
9913 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
9914 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
9915 Do not assume ptrdiff_t is the same width as 'int'.
9916
52828e02
PE
9917 * alloc.c: Handle unusual debugging option combinations.
9918 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
9919 since the two debugging options are incompatible.
9920 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
9921 is defined.
9922 (mem_init, mem_insert, mem_insert_fixup):
9923 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
9924 (NEED_MEM_INSERT): Remove; no longer needed.
9925
f01769f9
LL
99262012-04-22 Leo Liu <sdl.web@gmail.com>
9927
9928 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
9929
5790543d
PE
99302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
9931
9932 * sysdep.c [__FreeBSD__]: Minor cleanups.
9933 (list_system_processes, system_process_attributes) [__FreeBSD__]:
9934 Use Emacs indenting style more consistently. Avoid some casts.
9935 Use 'double' consistently rather than mixing 'float' and 'double'.
9936
b91b7e4d
EW
99372012-04-21 Eduard Wiebe <usenet@pusto.de>
9938
b593d6a9
AH
9939 * sysdep.c (list_system_processes, system_process_attributes):
9940 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 9941
6114eb15
AS
99422012-04-21 Andreas Schwab <schwab@linux-m68k.org>
9943
9944 * lisp.mk (lisp): Update.
9945
2f38dff7
PE
99462012-04-20 Paul Eggert <eggert@cs.ucla.edu>
9947
9948 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
9949 It is never used otherwise.
9950
4ae29f89
SM
99512012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
9952
9953 * print.c (print_preprocess): Only check print_depth if print-circle
9954 is nil.
9955 (print_object): Check for cycles even when print-circle is nil and
9956 print-gensym is t, but only check print_depth if print-circle is nil.
9957
f30d612a
CY
99582012-04-20 Chong Yidong <cyd@gnu.org>
9959
9960 * process.c (wait_reading_process_output): If EIO occurs on a pty,
9961 set the status to "failed" and ensure that sentinel is run.
9962
c07a4c0b 99632012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
9964
9965 * process.c (Fset_process_inherit_coding_system_flag)
9966 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 9967 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 9968
c07a4c0b 99692012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
9970
9971 * xdisp.c (string_buffer_position_lim): Limit starting position to
9972 BEGV.
9973 (set_cursor_from_row): If called for a mode-line or header-line
9974 row, return zero immediately.
9975 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
9976 farther than the first row after the header line, if any.
9977 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
9978 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
9979
c07a4c0b 99802012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 9981
4ae29f89
SM
9982 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
9983 (bug#11238).
ad3a2b41 9984
c07a4c0b 99852012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 99862012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
9987
9988 configure: new option --enable-gcc-warnings (Bug#11207)
9989 * Makefile.in (C_WARNINGS_SWITCH): Remove.
9990 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
9991 (ALL_CFLAGS): Use new macros rather than old.
9992 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
9993 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
9994 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
9995 -Wunused-result, -Wunused-variable. This should go away once
9996 the Emacs and Gnulib regex code is merged.
9997 (xmalloc, xrealloc): Now static.
9998
aba027e8
PE
99992012-04-17 Paul Eggert <eggert@cs.ucla.edu>
10000
10001 * dired.c (Fsystem_groups): Remove unused local.
10002
e5a36063
GM
100032012-04-17 Glenn Morris <rgm@gnu.org>
10004
10005 * dired.c (Fsystem_users): Doc fix.
10006
316411f0
DA
100072012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
10008
10009 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
10010 (syms_of_dired): Add them.
10011
9426aba4
PE
100122012-04-16 Paul Eggert <eggert@cs.ucla.edu>
10013
b62a57be
PE
10014 Fix minor alloc.c problems found by static checking.
10015 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
10016 New extern decls, to avoid calling undeclared functions.
10017 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
10018 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
10019 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
10020 (NEED_MEM_INSERT): New macro.
10021 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 10022 Remove one incorrect comment and fix another.
b62a57be 10023
3539f31f
PE
10024 Fix minor ralloc.c problems found by static checking.
10025 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
10026 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
10027 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
10028 (r_alloc_sbrk): Now static.
10029
a041960a
PE
10030 Improve ralloc.c interface checking.
10031 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
10032 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
10033 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
10034 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
10035 [REL_ALLOC]: ... to here, to check interface.
10036 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
10037 Remove decls. This fixes an "It stinks!".
10038
9426aba4
PE
10039 * alloc.c (which_symbols): Fix alignment issue / type clash.
10040
d55c12ed
AS
100412012-04-15 Andreas Schwab <schwab@linux-m68k.org>
10042
10043 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
10044 (struct Lisp_Misc_Any): Likewise.
10045 (struct Lisp_Free): Likewise.
10046 * alloc.c (union aligned_Lisp_Symbol): Define.
10047 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
10048 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
10049 (union aligned_Lisp_Misc): Define.
10050 (MARKER_BLOCK_SIZE, struct marker_block): Use union
10051 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 10052 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 10053
b948ce8b
PE
100542012-04-14 Paul Eggert <eggert@cs.ucla.edu>
10055
10056 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
10057 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
10058 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
10059 * s/netbsd.h, s/sol2-6.h:
10060 Remove definition of GC_MARK_STACK, since the default now works.
10061 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
10062 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
10063 no longer the default.
10064 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
10065
35dc09a1 100662012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 10067
35dc09a1
GM
10068 * lread.c (lisp_file_lexically_bound_p):
10069 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 10070
35dc09a1
GM
100712012-04-14 Eli Zaretskii <eliz@gnu.org>
10072
10073 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
10074 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
10075
100762012-04-14 Jan Djärv <jan.h.d@swipnet.se>
10077
10078 * nsterm.m (constrainFrameRect): Always constrain when there is only
10079 one screen (Bug#10962).
10080
bcd86815
KB
100812012-04-13 Ken Brown <kbrown@cornell.edu>
10082
10083 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
10084
c25df26e
RT
100852012-04-13 Reuben Thomas <rrt@sc3d.org>
10086
10087 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
10088
0fc59f1e
DC
100892012-04-11 Daniel Colascione <dancol@dancol.org>
10090
10091 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
10092 against is gone. It's better to use vfork now so that when Cygwin
10093 gains a new, working vfork, we use it automatically (bug#10398).
10094
de8c03dc
SM
100952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
10096
10097 * window.c (save_window_save): Obey window-point-insertion-type.
10098
2f097256
GM
100992012-04-11 Glenn Morris <rgm@gnu.org>
10100
10101 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
10102
453b951e
SM
101032012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
10104
10105 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
10106
75f1671a 101072012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
10108
10109 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
10110 (force_quit_count): New var.
10111 (handle_interrupt): Use it.
10112
2a8ce227
JB
101132012-04-10 Juanma Barranquero <lekktu@gmail.com>
10114
10115 * w32.c (w32_delayed_load): Record the full path of the library
10116 being loaded (bug#10424).
10117
935396c0
GM
101182012-04-09 Glenn Morris <rgm@gnu.org>
10119
05920a43
GM
10120 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
10121 not just in the obarray, before snarfing them. (Bug#11036)
10122
935396c0
GM
10123 * Makefile.in ($(leimdir)/leim-list.el):
10124 Pass EMACS rather than BUILT_EMACS.
10125
a18ecafa
TZ
101262012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
10127
10128 * process.c (make_process):
10129 * process.h: Add integer `gnutls_handshakes_tried' member to
10130 process struct.
10131
6bbef4e5
JC
10132 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
10133 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
10134
10135 * gnutls.c (gnutls_log_function2i): Convenience log function.
10136 (emacs_gnutls_read): Use new log functions,
10137 `gnutls_handshakes_tried' process member, and
10138 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
10139 attempts per process (connection).
10140
b4d3bc10
CY
101412012-04-09 Chong Yidong <cyd@gnu.org>
10142
10143 * eval.c (Fuser_variable_p, user_variable_p_eh)
10144 (lisp_indirect_variable): Functions deleted.
10145 (Fdefvar): Caller changed.
10146
10147 * callint.c (Finteractive, Fcall_interactively):
10148 * minibuf.c (Fread_variable): Callers changed.
10149
70f4d973
EZ
101502012-04-09 Eli Zaretskii <eliz@gnu.org>
10151
10152 * xdisp.c (set_cursor_from_row): If the display string appears in
10153 the buffer at position that is closer to point than the position
10154 after the display string, display the cursor on the first glyph of
10155 the display string. Fixes cursor display when a 'display' text
10156 property immediately follows invisible text. (Bug#11094)
10157
cb3c2e3e
PE
101582012-04-09 Paul Eggert <eggert@cs.ucla.edu>
10159
10160 composite.c: use 'double' consistently
10161 * composite.c (get_composition_id): Use 'double' consistently
10162 instead of converting 'float' to 'double' and vice versa; this is
10163 easier to understand and avoids a GCC warning.
10164
fd06db5d
GM
101652012-04-09 Glenn Morris <rgm@gnu.org>
10166
50fe702a
GM
10167 * Makefile.in: Generate leim-list with bootstrap-emacs, in
10168 preparation for dumping it with emacs. (Bug#4789)
10169 (leimdir): New variable.
10170 ($(leimdir)/leim-list.el): New rule.
10171 (emacs$(EXEEXT)): Depend on leim-list.el.
10172
fd06db5d
GM
10173 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
10174 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
10175 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
10176
55c131ee
AS
101772012-04-08 Andreas Schwab <schwab@linux-m68k.org>
10178
10179 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
10180 proper alignment.
10181
9209588f
JB
101822012-04-07 Juanma Barranquero <lekktu@gmail.com>
10183
10184 * xml.c (init_libxml2_functions) [WINDOWSNT]:
10185 Remove unused local variable.
10186
e3fb2efb
PE
101872012-04-07 Paul Eggert <eggert@cs.ucla.edu>
10188
10189 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
10190 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
10191 (mark_memory): Mark Lisp_Objects only if pointers might hide in
10192 objects, as mark_maybe_pointer will catch them otherwise.
10193 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
10194 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
10195
b5385551
PE
101962012-04-07 Paul Eggert <eggert@cs.ucla.edu>
10197
10198 Fix typo that broke non-Windows builds.
10199 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
10200
9078ead6
EZ
102012012-04-07 Eli Zaretskii <eliz@gnu.org>
10202
10203 Support building on MS-Windows with libxml2.
10204
10205 * makefile.w32-in (OBJ2): Add xml.$(O).
10206 (GLOBAL_SOURCES): Add xml.c.
10207 ($(BLD)/xml.$(O)): New dependency list.
10208
10209 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
10210 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
10211 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
10212 [!WINDOWSNT]: New macros.
10213 (init_libxml2_functions, libxml2_loaded_p): New functions.
10214 (parse_region): Call fn_xmlCheckVersion instead of using the macro
10215 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
10216 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
10217 Calls xmlCleanupParser only if libxml2 was loaded (or statically
10218 linked in).
6bbef4e5
JC
10219 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
10220 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
10221 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
10222
10223 * emacs.c: Don't include libxml/parser.h.
10224 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
10225 xmlCleanupParser directly.
10226
10227 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
10228
3811fdf3
EZ
102292012-04-07 Eli Zaretskii <eliz@gnu.org>
10230
10231 * indent.c (Fvertical_motion): If there is a display string at
10232 point, use it.vpos to compute how many lines to backtrack after
10233 move_it_to point. (Bug#11133)
10234
2f8e16b2
EZ
102352012-04-06 Eli Zaretskii <eliz@gnu.org>
10236
10237 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
10238 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
10239 about subtle differences between FETCH_CHAR* and STRING_CHAR*
10240 macros related to unification of CJK characters. For the details,
10241 see the discussion following the message here:
10242 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
10243
3d439cd1
CY
102442012-04-04 Chong Yidong <cyd@gnu.org>
10245
10246 * keyboard.c (Vdelayed_warnings_list): Doc fix.
10247
8bc53d00
EZ
102482012-04-01 Eli Zaretskii <eliz@gnu.org>
10249
10250 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
10251 instead of alloca. (Bug#11138)
10252
3b0512a3
AS
102532012-04-01 Andreas Schwab <schwab@linux-m68k.org>
10254
10255 * w32menu.c (is_simple_dialog): Properly check lisp types.
10256 (Bug#11141)
10257
8427ddd2
EZ
102582012-03-31 Eli Zaretskii <eliz@gnu.org>
10259
979022ef
EZ
10260 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
10261 position we get to after a call to move_it_to fails the
10262 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
10263 only if we wind up in a string from display property. (Bug#11063)
10264
a6b1c7cc
EZ
10265 * window.c (Fdelete_other_windows_internal): Invalidate the row
10266 and column information about mouse highlight, so that redisplay
10267 restores it after reallocating the glyph matrices. (Bug#7464)
10268
8427ddd2
EZ
10269 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
10270 string comes from a `display' text property, use the buffer
10271 position of that property as if we actually saw that position in
10272 the row's glyphs.
697ba24b
EZ
10273 (move_it_by_lines): Remove the assertion that
10274 "it->current_x == 0 && it->hpos == 0" which can be legitimately
10275 violated when there's a before-string at the beginning of a line.
10276 (Bug#11063)
8427ddd2 10277
65a0a738
EZ
102782012-03-30 Eli Zaretskii <eliz@gnu.org>
10279
10280 * xdisp.c (append_space_for_newline): If the default face was
10281 remapped, use the remapped face for the appended newline.
10282 (extend_face_to_end_of_line): Use the remapped default face for
10283 extending the face to the end of the line.
10284 (display_line): Call extend_face_to_end_of_line when the default
10285 face was remapped. (Bug#11068)
10286
581355cc
EZ
102872012-03-29 Eli Zaretskii <eliz@gnu.org>
10288
10289 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
10290
e8fc049f
SM
102912012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10292
10293 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
10294
4fb9a543
GM
102952012-03-27 Glenn Morris <rgm@gnu.org>
10296
10297 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
10298 Doc fixes.
10299
679910f1
KH
103002012-03-26 Kenichi Handa <handa@m17n.org>
10301
10302 * dispextern.h (struct glyph): Fix previous change. Change the
10303 bit length of glyphless.ch to 25 (Bug#11082).
10304
90d49b7f
CY
103052012-03-26 Chong Yidong <cyd@gnu.org>
10306
10307 * keyboard.c (Vselection_inhibit_update_commands): New variable.
10308 (command_loop_1): Use it; inhibit selection update for
10309 handle-select-window too (Bug#8996).
10310
f514f6f0
FP
103112012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
10312
e8fc049f 10313 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 10314
bf43fa51
KH
103152012-03-25 Kenichi Handa <handa@m17n.org>
10316
10317 * dispextern.h (struct glyph): Change the bit length of
10318 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
10319
8a0c01dd
EZ
103202012-03-24 Eli Zaretskii <eliz@gnu.org>
10321
10322 * s/ms-w32.h (tzname): Include time.h before redirecting to
10323 _tzname. Fixes the MSVC build. (Bug#9960)
10324
7d1c3a76
AS
103252012-03-24 Andreas Schwab <schwab@linux-m68k.org>
10326
8ed79523
AS
10327 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
10328 characters.
10329
7d1c3a76
AS
10330 * xterm.c (XTread_socket): Only modify handling_signal if
10331 !SYNC_INPUT. (Bug#11080)
10332
e99a9b8b
EZ
103332012-03-23 Eli Zaretskii <eliz@gnu.org>
10334
10335 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
10336 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
10337 when fetching a multibyte character consumes more bytes than
10338 CHAR_BYTES returns, due to unification of CJK characters in
10339 string_char. (Bug#11073)
10340
5063c0e1
TN
103412012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
10342
10343 * process.c (wait_reading_process_output): Handle pty disconnect
10344 by refraining from sending oneself a SIGCHLD (bug#10933).
10345
9f851fbd
CY
103462012-03-22 Chong Yidong <cyd@gnu.org>
10347
10348 * dispextern.h (struct it): New member string_from_prefix_prop_p.
10349
5063c0e1 10350 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
10351 Mark string as coming from a prefix property.
10352 (handle_face_prop): Use default face for prefix strings (Bug#4281).
10353 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
10354
fb5b8aca
CY
103552012-03-21 Chong Yidong <cyd@gnu.org>
10356
10357 * xfaces.c (Vface_remapping_alist): Doc fix.
10358
62356a1b
EZ
103592012-03-20 Eli Zaretskii <eliz@gnu.org>
10360
10361 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
10362 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
10363 Doc fixes.
62356a1b 10364
025de85b
CY
103652012-03-20 Chong Yidong <cyd@gnu.org>
10366
10367 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
10368 to reflect default non-nil value of redisplay-dont-pause.
10369
4827f94e
KH
103702012-03-19 Kenichi Handa <handa@m17n.org>
10371
10372 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
10373 it fit in a valid range (Bug#11003).
10374
e50a24a2
EZ
103752012-03-18 Eli Zaretskii <eliz@gnu.org>
10376
10377 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
10378 that is not from display property, accept the row as a "cursor
10379 row" if one of the string's character has a non-nil `cursor'
10380 property. Fixes cursor positioning when there are newlines in
10381 overlay strings, e.g. in icomplete.el. (Bug#11035)
10382
9af5ed87
PE
103832012-03-12 Paul Eggert <eggert@cs.ucla.edu>
10384
10385 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
10386
d1f55f16
CY
103872012-03-12 Chong Yidong <cyd@gnu.org>
10388
10389 * eval.c (inhibit_lisp_code): Rename from
10390 inhibit_window_configuration_change_hook; move from window.c.
10391
10392 * xfns.c (unwind_create_frame_1, Fx_create_frame):
10393 * window.c (run_window_configuration_change_hook)
10394 (syms_of_window): Callers changed.
10395
66c5eebd
CY
103962012-03-11 Chong Yidong <cyd@gnu.org>
10397
413df973
CY
10398 * keymap.c (Fkey_description): Doc fix (Bug#9700).
10399
66c5eebd
CY
10400 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
10401
1de11f56
CY
104022012-03-10 Chong Yidong <cyd@gnu.org>
10403
10404 * frame.c (other_visible_frames): Don't assume the selected frame
10405 is visible (Bug#10955).
10406
cae07000
SM
104072012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
10408
10409 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
10410
89c94350
JD
104112012-03-08 Jan Djärv <jan.h.d@swipnet.se>
10412
10413 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
10414 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
10415 zero (Bug#10954).
10416
999dd333
GM
104172012-03-03 Glenn Morris <rgm@gnu.org>
10418
01a6dcc8 10419 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 10420
de0100f2
EZ
104212012-03-02 Eli Zaretskii <eliz@gnu.org>
10422
10423 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
10424 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
10425 (redisplay_window, next_element_from_string): Fix typos in
10426 comments.
3e441275
EZ
10427 (redisplay_window): Pass to move_it_vertically the margin in
10428 pixels, not in screen lines.
de0100f2 10429
96a72ee9
GM
104302012-03-02 Glenn Morris <rgm@gnu.org>
10431
10432 * buffer.c (buffer-list-update-hook): Doc fix.
10433
312508d7
EZ
104342012-02-29 Eli Zaretskii <eliz@gnu.org>
10435
10436 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
10437 push_it before setting up the iterator for the first overlay
10438 string, even if we have an empty string loaded.
10439 (next_overlay_string): If there's an empty string on the iterator
10440 stack, pop the stack. (Bug#10903)
10441
27f3c637
PE
104422012-02-25 Paul Eggert <eggert@cs.ucla.edu>
10443
10444 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
10445 Suggested by Stefan Monnier in
10446 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
10447 * alloc.c (widen_to_Lisp_Object): New static function.
10448 (mark_memory): Also mark Lisp_Objects by fetching pointer words
10449 and widening them to Lisp_Objects. This would work even if
10450 USE_LSB_TAG is defined and wide integers are used, which might
10451 happen in a future version of Emacs.
10452
3c9dfce6
CY
104532012-02-25 Chong Yidong <cyd@gnu.org>
10454
fa74b241
CY
10455 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
10456 Doc fix.
10457
3c9dfce6
CY
10458 * xselect.c (Fx_selection_exists_p): Doc fix.
10459 (x_clipboard_manager_save_all): Print an informative message
10460 before saving to clipboard manager.
10461
9486df08
CY
104622012-02-24 Chong Yidong <cyd@gnu.org>
10463
10464 * keyboard.c (process_special_events): Handle all X selection
10465 requests in kbd_buffer, not just the next one (Bug#8869).
10466
f01d3321
CY
104672012-02-23 Chong Yidong <cyd@gnu.org>
10468
10469 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
10470 call when setting menu-bar-lines and tool-bar-lines parameters.
10471 (unwind_create_frame_1): New helper function.
10472
10473 * window.c (inhibit_window_configuration_change_hook): New var.
10474 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 10475 (syms_of_window): Initialize it.
f01d3321 10476
86b847b6
CY
104772012-02-22 Chong Yidong <cyd@gnu.org>
10478
10479 * xterm.c (x_draw_image_relief): Add missing type check for
10480 Vtool_bar_button_margin (Bug#10743).
10481
a59225b1
CY
104822012-02-21 Chong Yidong <cyd@gnu.org>
10483
10484 * fileio.c (Vfile_name_handler_alist): Doc fix.
10485
10486 * buffer.c (Fget_file_buffer): Protect against invalid file
10487 handler return value.
10488
310f5bd4
PE
104892012-02-20 Paul Eggert <eggert@cs.ucla.edu>
10490
cb3a28cc
PE
10491 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
10492 when computing $valmask.
10493
310f5bd4
PE
10494 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
10495 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
10496 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
10497 It's useless in that case, and it can cause problems on hosts
10498 that allocate halves of EMACS_INT values separately.
10499 Reported by Dan Horák. Diagnosed by Andreas Schwab in
10500 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
10501 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
10502 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
10503 it avoids undefined behavior on hosts where shifting right by more
10504 than the word width has undefined behavior.
10505
2375c96a
CY
105062012-02-19 Chong Yidong <cyd@gnu.org>
10507
10508 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
10509 (Funhandled_file_name_directory, Ffile_name_as_directory)
10510 (Fdirectory_file_name, Fexpand_file_name)
10511 (Fsubstitute_in_file_name): Protect against invalid file handler
10512 return values (Bug#10845).
10513
3eb49e71
EZ
105142012-02-18 Eli Zaretskii <eliz@gnu.org>
10515
10516 * .gdbinit (pitx): Fix incorrect references to fields of the
10517 iterator stack.
10518
7b926f3f
CY
105192012-02-17 Chong Yidong <cyd@gnu.org>
10520
10521 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
10522
11273115
PE
105232012-02-15 Paul Eggert <eggert@cs.ucla.edu>
10524
10525 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
10526 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
10527
c3a70e2b
CY
105282012-02-15 Chong Yidong <cyd@gnu.org>
10529
10530 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
10531 marked as special. Also, starting docstrings with * is obsolete.
10532
0ca43699
AS
105332012-02-13 Andreas Schwab <schwab@linux-m68k.org>
10534
10535 * gnutls.c (emacs_gnutls_write): Fix last change.
10536
2e8f3c56
LI
105372012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
10538
10539 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
10540 send_process.
10541
af70074f
SM
105422012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
10543
10544 * keymap.c (Fsingle_key_description): Handle char ranges.
10545
95986d52
CY
105462012-02-12 Chong Yidong <cyd@gnu.org>
10547
afd83bd1
CY
10548 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
10549 as that creates a dangerous corner case.
10550
95986d52
CY
10551 * window.c (Fdelete_window_internal): Invalidate the mouse
10552 highlight (Bug#9904).
10553
bd7da63e
GM
105542012-02-12 Glenn Morris <rgm@gnu.org>
10555
10556 * xselect.c (Fx_own_selection_internal)
10557 (Fx_get_selection_internal, Fx_disown_selection_internal)
10558 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
10559 * nsselect.m (Fx_own_selection_internal)
10560 (Fx_disown_selection_internal, Fx_selection_exists_p)
10561 (Fx_selection_owner_p, Fx_get_selection_internal):
10562 Sync docs and argument specs with the xselect.c versions.
10563
77abcbc2
LI
105642012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
10565
10566 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
10567
90b671e2
EZ
105682012-02-11 Eli Zaretskii <eliz@gnu.org>
10569
1c0ca0b7
EZ
10570 * w32select.c (Fx_selection_exists_p): Sync doc string and
10571 argument list with xselect.c. (Bug#10783)
10572
10573 * w16select.c (Fx_selection_exists_p): Sync doc string and
10574 argument list with xselect.c. (Bug#10783)
90b671e2 10575
49241268
GM
105762012-02-10 Glenn Morris <rgm@gnu.org>
10577
10578 * fns.c (Fsecure_hash): Doc fix.
10579
f998bbe7 105802012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
10581
10582 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
10583
0992bd9c
CY
105842012-02-07 Chong Yidong <cyd@gnu.org>
10585
10586 * buffer.c (Fbuffer_local_variables)
10587 (buffer_lisp_local_variables): Handle unbound vars correctly;
10588 don't let Qunbound leak into Lisp.
10589
af008560
GM
105902012-02-07 Glenn Morris <rgm@gnu.org>
10591
dd605cc4
GM
10592 * image.c (Fimagemagick_types): Doc fix.
10593
af008560
GM
10594 * image.c (imagemagick-render-type): Change it from a lisp object
10595 to an integer. Move the doc here from the lisp manual.
10596 Treat all values not equal to 0 the same.
10597
1449fa1d
CY
105982012-02-06 Chong Yidong <cyd@gnu.org>
10599
10600 * doc.c (store_function_docstring): Avoid applying docstring of
10601 alias to base function (Bug#2603).
10602
3723ec07
AS
106032012-02-04 Andreas Schwab <schwab@linux-m68k.org>
10604
10605 * .gdbinit (pp1, pv1): Remove redundant defines.
10606 (pr): Use pp.
10607
79c1cc1e
CY
106082012-02-04 Chong Yidong <cyd@gnu.org>
10609
10610 * nsterm.m: Declare a global (Bug#10694).
10611
d7f29f8e
EZ
106122012-02-04 Eli Zaretskii <eliz@gnu.org>
10613
cae07000
SM
10614 * w32.c (get_emacs_configuration_options):
10615 Include --enable-checking, if specified, in the return value.
d7f29f8e 10616
3b95a6f9
MR
106172012-02-04 Martin Rudalics <rudalics@gmx.at>
10618
10619 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
10620 after rounding frame sizes. (Bug#9723)
10621
d6fa96a6
EZ
106222012-02-04 Eli Zaretskii <eliz@gnu.org>
10623
10624 * keyboard.c (adjust_point_for_property): Don't position point
10625 before BEGV. (Bug#10696)
10626
df0b2940
PE
106272012-02-03 Paul Eggert <eggert@cs.ucla.edu>
10628
10629 Handle overflow when computing char display width (Bug#9496).
10630 * character.c (char_width): Return EMACS_INT, not int.
10631 (char_width, c_string_width): Check for overflow when
10632 computing the width; this is possible now that individual
10633 characters can have unbounded width. Problem introduced
10634 by merge from Emacs 23 on 2012-01-19.
10635
6bee44d6
MA
106362012-02-02 Michael Albinus <michael.albinus@gmx.de>
10637
10638 * dbusbind.c (Fdbus_register_method): Mention the return value
10639 :ignore in the docstring.
10640
44f92739
GM
106412012-02-02 Glenn Morris <rgm@gnu.org>
10642
1b9f60cc
GM
10643 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
10644
44f92739
GM
10645 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
10646 Unconditionally set to t. (Bug#10673)
10647 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
10648 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
10649 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
10650
c5d3843c
KH
106512012-02-02 Kenichi Handa <handa@m17n.org>
10652
10653 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
10654 0, do not call append_composite_glyph.
10655
159462d4 106562012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
10657
10658 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
10659 NULL (Bug#6988).
10660 (x_produce_glyphs): If the component of a composition is a null
10661 string, set it->pixel_width to 1 to avoid zero-width glyph.
10662
78cef877
EZ
106632012-02-01 Eli Zaretskii <eliz@gnu.org>
10664
10665 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
10666 first 2 arguments are identical. This makes inserting large
10667 output from a subprocess an order of magnitude faster on
10668 MS-Windows, where all sbrk'ed memory is always contiguous.
10669
97897668
GM
106702012-01-31 Glenn Morris <rgm@gnu.org>
10671
10672 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 10673 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
10674 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
10675
31fd3586
GM
106762012-01-29 Glenn Morris <rgm@gnu.org>
10677
10678 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
10679
0e24a8b2
CY
106802012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
10681
10682 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
10683
cc0adcb0
CY
106842012-01-28 Chong Yidong <cyd@gnu.org>
10685
10686 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
10687
acc28cb9
CY
106882012-01-26 Chong Yidong <cyd@gnu.org>
10689
9c69cfb7
CY
10690 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
10691
acc28cb9
CY
10692 * search.c (Fsearch_forward, Fsearch_backward): Document negative
10693 repeat counts (Bug#10507).
10694
48da7392
GM
106952012-01-26 Glenn Morris <rgm@gnu.org>
10696
10697 * lread.c (syms_of_lread): Doc fix.
10698
14af5f7f
CY
106992012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
10700
10701 * coding.c (encode_designation_at_bol): Change return value to
10702 EMACS_INT.
10703
0b21c100
CY
107042012-01-25 Chong Yidong <cyd@gnu.org>
10705
10706 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
10707
3c2907f7
CY
107082012-01-21 Chong Yidong <cyd@gnu.org>
10709
10710 * floatfns.c (Fcopysign): Make the second argument non-optional,
10711 since nil is not allowed anyway.
10712
959ad23f
AS
107132012-01-21 Andreas Schwab <schwab@linux-m68k.org>
10714
10715 * process.c (read_process_output): Use p instead of XPROCESS (proc).
10716 (send_process): Likewise.
10717
34a02f46
MR
107182012-01-19 Martin Rudalics <rudalics@gmx.at>
10719
10720 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
10721 (Vwindow_persistent_parameters): Do not use Qstate.
10722 Rewrite doc-strings.
34a02f46 10723
1259009a 107242012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
10725
10726 * character.c (char_width): New function.
70d4fdf6
GM
10727 (Fchar_width, c_string_width, lisp_string_width):
10728 Use char_width (Bug#9496).
25ed9e61 10729
6a6ee00d
MR
107302012-01-16 Martin Rudalics <rudalics@gmx.at>
10731
10732 * window.c (Vwindow_persistent_parameters): New variable.
10733 (Fset_window_configuration, save_window_save): Handle persistent
10734 window parameters.
10735
c85efaf7
EZ
107362012-01-14 Eli Zaretskii <eliz@gnu.org>
10737
10738 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
10739 thrashing the stack of the thread. (Bug#9087)
10740
5944709e
PE
107412012-01-12 Paul Eggert <eggert@cs.ucla.edu>
10742
10743 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
10744
e71f5d99
EZ
107452012-01-11 Eli Zaretskii <eliz@gnu.org>
10746
10747 * xdisp.c (rows_from_pos_range): Handle the case where the
10748 highlight ends on a newline. (Bug#10464)
10749 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
10750 he end column for display of highlight that ends on a newline
10751 before a R2L line.
10752
ce316182
GM
107532012-01-11 Glenn Morris <rgm@gnu.org>
10754
10755 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
10756 from load-path also when installation-directory is nil. (Bug#10208)
10757
5b43da69
GM
107582012-01-10 Glenn Morris <rgm@gnu.org>
10759
74cc8ff9
GM
10760 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
10761
7d8d6e4e
GM
10762 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
10763 Update template values to be closer to their typical values these days.
5b43da69 10764
a0db8d43
EZ
107652012-01-09 Eli Zaretskii <eliz@gnu.org>
10766
10767 * xdisp.c (rows_from_pos_range): Accept additional argument
10768 DISP_STRING, and accept any glyph in a row whose object is that
10769 string as eligible for mouse highlight. Fixes mouse highlight of
10770 display strings from overlays. (Bug#10464)
10771
9a0115ab 107722012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 10773
b9110d6a 10774 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
10775 * fileio.c (auto_saving_dir_umask): New static var.
10776 (Fmake_directory_internal): Use it.
10777 (do_auto_save_make_dir): Set it, instead of invoking chmod after
10778 creating the directory. The old code temporarily assigns
10779 too-generous permissions to the directory.
10780 (do_auto_save_eh): Clear it.
b9110d6a 10781 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
10782 that the var is always cleared.
10783
6c1bd3f3
EZ
107842012-01-07 Eli Zaretskii <eliz@gnu.org>
10785
10786 * search.c (scan_buffer): Pass character positions to
10787 know_region_cache, not byte positions. (Bug#6540)
10788
069d2b50
L
107892012-01-07 LynX <_LynX@bk.ru> (tiny change)
10790
10791 * w32.c (sys_rename): Report EXDEV when rename of a directory
10792 fails because the target is on another logical disk. (Bug#10284)
10793
75bf0d33
DB
107942012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
10795
10796 * xterm.c (x_embed_request_focus): New function.
10797
10798 * xterm.h: Add prototype.
10799
10800 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
10801
1c6e5a32
GM
108022012-01-05 Glenn Morris <rgm@gnu.org>
10803
10804 * emacs.c (emacs_copyright): Update short copyright year to 2012.
10805
651e947e
EZ
108062012-01-01 Eli Zaretskii <eliz@gnu.org>
10807
10808 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
10809 Load gnutls_transport_set_lowat only if GnuTLS version is below
10810 2.11.1.
10811 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
10812 GnuTLS versions below 2.11.1.
10813
3778cdd8
AL
108142011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
10815
10816 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
10817 to the doc string advising against its use for altering the way
10818 windows are scrolled.
10819
0e5317f7
KH
108202011-12-28 Kenichi Handa <handa@m17n.org>
10821
10822 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
10823 coding-system ASCII compatible only when it does not produce BOM
10824 on encoding (Bug#10383).
10825
93d5ca1f
JD
108262011-12-26 Jan Djärv <jan.h.d@swipnet.se>
10827
10828 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
10829 can scroll.
10830 (create_and_show_popup_menu): Always use menu_position_func for
10831 Gtk3 (Bug#10361).
10832
ca22b785
AS
108332011-12-24 Andreas Schwab <schwab@linux-m68k.org>
10834
10835 * callint.c (Fcall_interactively): Don't truncate prompt string.
10836
d048e1e6
EZ
108372011-12-23 Eli Zaretskii <eliz@gnu.org>
10838
10839 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
10840 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 10841 resumed from there (after widening). (Bug#10360)
d048e1e6 10842
5ccaba1f
JD
108432011-12-22 Jan Djärv <jan.h.d@swipnet.se>
10844
10845 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
10846
204ee57f
JD
108472011-12-21 Jan Djärv <jan.h.d@swipnet.se>
10848
b81d40f0
JB
10849 * nsterm.m (x_free_frame_resources):
10850 Release f->output_data.ns->miniimage.
204ee57f
JD
10851 (ns_index_color): Fix indentation. Do not retain
10852 color_table->colors[i].
10853
10854 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
10855 before returning.
10856
10857 * nsfns.m (x_set_background_color): Assign return value from
10858 ns_index_color to face-background instead of NSColor*.
10859 (ns_implicitly_set_icon_type): Fix indentation.
10860 Change assignment in for loop to comparison.
10861
10862 * emacs.c (ns_pool): New variable.
10863 (main): Assign ns_pool.
10864 (Fkill_emacs): Call ns_release_autorelease_pool.
10865
10866 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
10867 autorelease fdesc, release fdAttrs and tdict.
10868 (ns_get_covering_families): Release charset.
10869 (ns_findfonts): Release NSFontDescriptor created with new.
10870 (ns_uni_to_glyphs): Fix indentation.
10871 (setString): Release attrStr before assigning new value.
10872
c803b2b7
JD
108732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
10874
678f4426
JD
10875 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
10876 and NS_IMPL_COCOA.
10877 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
10878 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
10879
cd394be1 108802011-12-18 David Reitter <reitter@cmu.edu>
678f4426 10881
5fecd5fc
JD
10882 * nsterm.m (ns_term_init): Subscribe for notifications
10883 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
10884 to method trackingNotification in EmacsMenu.
10885
10886 * nsmenu.m (trackingMenu): New variable.
3771cb17 10887 (trackingNotification): New method (from Aquamacs).
5fecd5fc 10888 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 10889 from Aquamacs (Bug#7030).
678f4426
JD
10890
108912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 10892
c803b2b7
JD
10893 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
10894 (symbol_to_nsstring): Fix indentation.
10895 (ns_symbol_to_pb): New function.
cae07000
SM
10896 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
10897 (Fns_rotate_cut_buffers_internal): Remove.
10898 (Fns_store_selection_internal): Rename from
c803b2b7
JD
10899 Fns_store_cut_buffer_internal.
10900 (ns_get_foreign_selection, Fx_own_selection_internal)
10901 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
10902 (Fns_get_selection_internal, Fns_store_selection_internal):
10903 Use ns_symbol_to_pb and check if return value is nil.
10904 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
10905 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
10906 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
10907 renamed to Sns_store_selection_internal.
10908 (ns_handle_selection_request): Move code to Fx_own_selection_internal
10909 and remove this function.
10910 (ns_handle_selection_clear): Remove, never used.
10911 (Fx_own_selection_internal): Move code from ns_handle_selection_request
10912 here.
10913
e1b01a3a
KB
109142011-12-17 Ken Brown <kbrown@cornell.edu>
10915
10916 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
10917 GID is unknown (Bug#10257).
10918
2adb6e85
PE
109192011-12-17 Paul Eggert <eggert@cs.ucla.edu>
10920
10921 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
10922 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
10923 which caused a build failure on GNU/Linux IA-64. This problem was
10924 introduced by my 2011-10-07 patch.
10925
d1d7b339
JL
109262011-12-15 Juri Linkov <juri@jurta.org>
10927
10928 * image.c (imagemagick_error): New function. (Bug#10112)
10929 (imagemagick_load_image): Comment out `MagickSetResolution' call.
10930 Use `imagemagick_error' where ImageMagick functions return
10931 `MagickFalse'.
10932 (Fimagemagick_types): Add `Fnreverse' to return the list in the
10933 proper order.
10934
100d5755
KH
109352011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10936
10937 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
10938 fill background (Bug#8992).
10939
454592a6
MR
109402011-12-13 Martin Rudalics <rudalics@gmx.at>
10941
10942 * window.c (Vwindow_combination_resize)
10943 (Vwindow_combination_limit): Use t instead of non-nil in
10944 doc-strings.
61d4b438
MR
10945 (Vrecenter_redisplay): Add first sentence of doc-string on
10946 separate line.
53524d93 10947 (Frecenter): Fix doc-string typo.
454592a6 10948
3633e3aa
KH
109492011-12-11 Kenichi Handa <handa@m17n.org>
10950
10951 * coding.c (Funencodable_char_position): Pay attention to the
10952 buffer text relocation (Bug#9389).
10953
7b9d523a 109542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 10955
7b9d523a
JD
10956 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
10957 gtk_init (Bug#10100).
10958
b73189c6
EZ
109592011-12-10 Eli Zaretskii <eliz@gnu.org>
10960
10961 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
10962 IT->string is nil. (Bug#10263)
10963
f7dfe5d6
JD
109642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
10965
83faebb4
JD
10966 * nsterm.h (x_free_frame_resources): Declare.
10967
f7dfe5d6
JD
10968 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
10969 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
10970
10971 * nsterm.h (ns_get_defaults_value): Declare.
10972
10973 * nsterm.m (ns_default): Call ns_get_defaults_value.
10974
7cd4e72c
EZ
109752011-12-09 Eli Zaretskii <eliz@gnu.org>
10976
10977 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
10978 (Bug#10170)
10979
b34d7317
YM
109802011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10981
10982 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
10983 that where the value of an _OBJC_* symbol points to is in the .bss
10984 section (Bug#10240).
10985
76470ad1
KH
109862011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10987
10988 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 10989 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 10990
745fff94
KH
109912011-12-08 Kenichi Handa <handa@m17n.org>
10992
10993 * ftfont.c (get_adstyle_property): Fix previous change
10994 (Bug#10233).
10995
6e44397c
JB
109962011-12-07 Juanma Barranquero <lekktu@gmail.com>
10997
10998 * w32.c (init_environment): If no_site_lisp, remove site-lisp
10999 dirs from the default value of EMACSLOADPATH (bug#10208).
11000
7efa6272
GM
110012011-12-07 Glenn Morris <rgm@gnu.org>
11002
11003 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
11004 installation and source directories as well. (Bug#10208)
11005
f6fc4d87
CY
110062011-12-06 Chong Yidong <cyd@gnu.org>
11007
11008 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
11009
2bf26180
GM
110102011-12-06 Glenn Morris <rgm@gnu.org>
11011
11012 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
11013 as an error, not just -1. (Bug#10217)
11014
3a6ad4f0
CY
110152011-12-05 Chong Yidong <cyd@gnu.org>
11016
11017 * keyboard.c (process_special_events): New function.
11018 (swallow_events, Finput_pending_p): Use it (Bug#10195).
11019
75a3b399
PE
110202011-12-05 Paul Eggert <eggert@cs.ucla.edu>
11021
11022 * coding.c (encode_designation_at_bol): Don't use uninitialized
11023 local variable (Bug#9318).
11024
c3c9e25e
KH
110252011-12-05 Kenichi Handa <handa@m17n.org>
11026
11027 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
11028 return Qnil (Bug#8046, Bug#10193).
11029
5eb05ea3
KH
110302011-12-05 Kenichi Handa <handa@m17n.org>
11031
11032 * coding.c (encode_designation_at_bol): New args charbuf_end and
11033 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
11034 (coding_set_source): Return how many bytes coding->source was
11035 relocated.
11036 (coding_set_destination): Return how many bytes
11037 coding->destination was relocated.
11038 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 11039 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
11040
110412011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
11042
11043 * coding.c (CODING_CHAR_CHARSET_P): New macro.
11044 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
11045 macro (Bug#9318).
11046
110472011-12-05 Andreas Schwab <schwab@linux-m68k.org>
11048
11049 The following changes are to fix Bug#9318.
11050
a79703f5 11051 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
11052 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
11053 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 11054 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 11055
7dbda6df
JB
110562011-12-05 Juanma Barranquero <lekktu@gmail.com>
11057
11058 * lisp.h (process_quit_flag): Fix external declaration.
11059
6d5eb5b0
SM
110602011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
11061
11062 Don't macro-inline non-performance-critical code.
11063 * eval.c (process_quit_flag): New function.
11064 * lisp.h (QUIT): Use it.
11065
a0c3fad0
JD
110662011-12-04 Jan Djärv <jan.h.d@swipnet.se>
11067
11068 * nsfns.m (get_geometry_from_preferences): New function.
11069 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
11070
6c07aac2
AS
110712011-12-04 Andreas Schwab <schwab@linux-m68k.org>
11072
11073 * emacs.c (Qkill_emacs): Define.
11074 (syms_of_emacs): Initialize it.
11075 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
11076 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
11077 (quit_throw_to_read_char): Add parameter `from_signal'.
11078 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
11079 * lisp.h (QUIT): Call Fkill_emacs if requested.
11080
c052ead4
JD
110812011-12-03 Jan Djärv <jan.h.d@swipnet.se>
11082
11083 * widget.c (update_wm_hints): Return if wmshell is null.
11084 (widget_update_wm_size_hints): New function.
11085
11086 * widget.h (widget_update_wm_size_hints): Declare.
11087
11088 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
11089 widget_update_wm_size_hints (Bug#10104).
11090
9e49252b
EZ
110912011-12-03 Eli Zaretskii <eliz@gnu.org>
11092
11093 * xdisp.c (handle_invisible_prop): If the invisible text ends just
11094 before a newline, prepare the bidi iterator for consuming the
11095 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 11096 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 11097
02b16839
JL
110982011-12-02 Juri Linkov <juri@jurta.org>
11099
11100 * search.c (Fword_search_regexp): New Lisp function created from
11101 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
11102 (Fword_search_backward, Fword_search_forward)
11103 (Fword_search_backward_lax, Fword_search_forward_lax):
11104 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
11105 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
11106
0068070e
SM
111072011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
11108
11109 * fileio.c (Finsert_file_contents): Move after-change-function call
11110 to before the "handled:" label, since all "goto handled" appear in
11111 cases where the *-change-functions have already been properly called
11112 (bug#10117).
11113
3360a3fc
AS
111142011-12-01 Andreas Schwab <schwab@linux-m68k.org>
11115
11116 * keyboard.c (interrupt_signal): Don't call kill-emacs when
11117 waiting for input. (Bug#10169)
11118
73d6c093
EZ
111192011-11-30 Eli Zaretskii <eliz@gnu.org>
11120
11121 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
11122 verifies glyph row's hash code--we have just reallocated the
11123 glyphs, so their contents can be complete garbage. (Bug#10164)
11124
febe6bea
JB
111252011-11-30 Juanma Barranquero <lekktu@gmail.com>
11126
11127 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
11128
801a4313
EZ
111292011-11-30 Eli Zaretskii <eliz@gnu.org>
11130
11131 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
11132 attributes are tested _before_ calling verify_row_hash, to protect
11133 against GCC re-ordering of the tests. (Bug#10164)
11134
2b56b87e
JD
111352011-11-29 Jan Djärv <jan.h.d@swipnet.se>
11136
11137 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
11138
11139 * xterm.c (handle_one_xevent): Only set async_visible and friends
11140 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 11141 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
11142 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
11143
dbf31225
PE
111442011-11-28 Paul Eggert <eggert@cs.ucla.edu>
11145
11146 Remove GCPRO-related macros that exist only to avoid shadowing locals.
11147 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
11148 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
11149 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
11150 All uses changed to use GCPRO1 etc.
11151 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
11152 Revert to old implementation (i.e., before 2011-03-11).
11153
1305621b
YM
111542011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11155
11156 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
11157 of scroll runs so as to avoid assigning disabled bogus rows and
11158 unnecessary graphics copy operations.
11159
8c9afb46
EZ
111602011-11-27 Eli Zaretskii <eliz@gnu.org>
11161
11162 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
11163 (snprintf) [_MSC_VER]: Redirect to _snprintf.
11164 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
11165 (malloc, free, realloc, calloc): Redirect to e_* only when
11166 compiling Emacs.
11167
11168 * lisp.h (GCTYPEBITS): Move before first use.
11169 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
11170 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
11171 this macro definition.
11172
11173 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
11174 _MSC_VER.
11175
54e9e3bf
JD
111762011-11-27 Jan Djärv <jan.h.d@swipnet.se>
11177
6d5eb5b0
SM
11178 * gtkutil.c (xg_create_frame_widgets):
11179 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
11180 present with Gtk+ 2.0.
11181
83aca1cb
PE
111822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
11183
11184 * fileio.c (Finsert_file_contents): Undo previous change; see
11185 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
11186
5b76caa4
PE
111872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
11188
11189 Rename locals to avoid shadowing.
11190 * fileio.c (Finsert_file_contents):
11191 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
11192 * process.c (wait_reading_process_output):
11193 Rename inner 'proc' to 'p' to avoid shadowing.
11194 Indent for consistency with usual Emacs style.
11195
8c535114
EZ
111962011-11-25 Eli Zaretskii <eliz@gnu.org>
11197
11198 * xdisp.c (redisplay_window): If cursor row is not fully visible
11199 after recentering, and scroll-conservatively is set to a large
11200 number, scroll window by a few more lines to make the cursor fully
11201 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
11202 (start_display): Don't move to the next line if the display should
11203 start at a newline that is part of a display vector or an overlay
11204 string. (Bug#10119)
8c535114 11205
fa4fdb5c
JL
112062011-11-24 Juri Linkov <juri@jurta.org>
11207
11208 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
11209 after the `MagickPingImage' call. (Bug#10112)
11210
90ec88df
CY
112112011-11-23 Chong Yidong <cyd@gnu.org>
11212
11213 * window.c (Fcoordinates_in_window_p): Accept only live windows.
11214
56e2e794
MR
112152011-11-23 Martin Rudalics <rudalics@gmx.at>
11216
11217 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
11218 making another buffer current. (Bug#10114)
11219
b6e64c41
GM
112202011-11-23 Glenn Morris <rgm@gnu.org>
11221
11222 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
11223
6b21de18
CY
112242011-11-23 Chong Yidong <cyd@gnu.org>
11225
11226 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
11227 using it (Bug#5984).
11228
b12cd789
EZ
112292011-11-22 Eli Zaretskii <eliz@gnu.org>
11230
11231 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
11232 and header-lines, as they don't have one computed for them.
11233 (Bug#10098)
11234
11235 * .gdbinit (prow): Make displayed values more self-explaining.
11236 Add row's hash code.
11237
261b6fd4
LMI
112382011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
11239
11240 * process.c (wait_reading_process_output): Fix asynchrounous
11241 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 11242 (wait_reading_process_output): Add comment and URL.
261b6fd4 11243
e7cfd277
JD
112442011-11-21 Jan Djärv <jan.h.d@swipnet.se>
11245
11246 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
11247
a9b9b7f5
CY
112482011-11-21 Chong Yidong <cyd@gnu.org>
11249
11250 * window.c (Fnext_window, Fprevious_window): Doc fix.
11251
b0d15b4f
SM
112522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
11253
11254 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
11255
fe7a3057
JB
112562011-11-20 Juanma Barranquero <lekktu@gmail.com>
11257
11258 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
11259
d2999b1a
MR
112602011-11-20 Martin Rudalics <rudalics@gmx.at>
11261
11262 * window.c (Fset_window_combination_limit): Rename argument
11263 STATUS to LIMIT.
11264 (Vwindow_combination_limit): Remove "status" from doc-string.
11265
d5ff9cd0
AS
112662011-11-20 Andreas Schwab <schwab@linux-m68k.org>
11267
11268 * m/ibms390.h: Remove.
11269 * m/ibms390x.h: Don't include "ibms390.h".
11270
a5bb9bd3
SM
112712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
11272
11273 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
11274 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
11275
cd1181db
JB
112762011-11-20 Juanma Barranquero <lekktu@gmail.com>
11277
11278 * casetab.c (Fset_case_table):
11279 * charset.c (Fcharset_after): Fix typos.
11280
615a3b8d 112812011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 11282
17e845af
PE
11283 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
11284 Otherwise, valgrind does not work on some platforms.
11285 Problem reported by Andreas Schwab in
6a0bf43d
PE
11286 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
11287 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
11288 is set, removing the need for VIRT_ADDRESS_VARIES.
11289 (PURE_P): Use a more-efficient implementation that needs just one
11290 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
11291 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
11292 to 4 (xorl, subq, cmpq, setbe).
11293 * alloc.c (pure): Always extern now, since that's the
11294 VIRT_ADDR_VARIES behavior.
11295 (PURE_POINTER_P): Use a single comparison, not two, for
11296 consistency with the new puresize.h.
11297 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
11298 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
11299 Remove VIRT_ADDR_VARIES no longer needed.
11300
f8fe6f96
EZ
113012011-11-19 Eli Zaretskii <eliz@gnu.org>
11302
11303 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
11304 (erase_phys_cursor, update_window_cursor, show_mouse_face)
11305 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
11306 behave as if the cursor position were at the window margin.
11307
11308 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
11309 and the cursor position is out of bounds, behave as if the cursor
11310 position were at the window margin. (Bug#10075)
11311
df05a53c
CY
113122011-11-18 Chong Yidong <cyd@gnu.org>
11313
11314 * window.c (Fwindow_combination_limit): Make first argument
11315 non-optional, since it is meaningless for live windows like the
11316 selected window.
61ccba97 11317
2071918e
DA
113182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
11319
11320 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
11321
b50a28de
SM
113222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
11323
11324 * intervals.c: Fix grafting over the whole buffer (bug#10071).
11325 (graft_intervals_into_buffer): Simplify.
11326
015137db
EZ
113272011-11-18 Eli Zaretskii <eliz@gnu.org>
11328
11329 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
11330 hash values of the two rows.
11331 (copy_row_except_pointers): Preserve the used[] arrays and the
11332 hash values of the two rows. (Bug#10035)
68c95424 11333 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
11334
11335 * xdisp.c (row_hash): New function, body extracted from
11336 compute_line_metrics.
11337 (compute_line_metrics): Call row_hash, instead of computing the
11338 hash code inline.
11339
11340 * dispnew.c (verify_row_hash): Call row_hash for computing the
11341 hash code of a row, instead of duplicating code from xdisp.c.
11342
11343 * dispextern.h (row_hash): Add prototype.
11344
a2addb04
TH
113452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
11346
11347 * frame.c (delete_frame): Don't delete the terminal when the last
11348 X frame is closed if emacs is built with GTK toolkit.
11349
df85d315
JB
113502011-11-17 Juanma Barranquero <lekktu@gmail.com>
11351
11352 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
11353
a0c2d0ae
MR
113542011-11-17 Martin Rudalics <rudalics@gmx.at>
11355
11356 * window.c (Vwindow_splits): Rename to
11357 Vwindow_combination_resize. Suggested by Juri Linkov.
11358 (Fsplit_window_internal): Use Vwindow_combination_resize instead
11359 of Vwindow_splits.
11360
58179cce
JB
113612011-11-16 Juanma Barranquero <lekktu@gmail.com>
11362
7877f373
JB
11363 * nsfns.m (Fns_font_name):
11364 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 11365
b6f67890
MR
113662011-11-16 Martin Rudalics <rudalics@gmx.at>
11367
11368 * window.h (window): Rename slot "nest" to "combination_limit".
11369 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
11370 (Fset_window_nest): Rename to Fset_window_combination_limit.
11371 (Vwindow_nest): Rename to Vwindow_combination_limit.
11372 (recombine_windows, make_parent_window, make_window)
11373 (Fsplit_window_internal, saved_window)
11374 (Fset_window_configuration, save_window_save): Rename all
11375 occurrences of window_nest to window_combination_limit.
11376
c7015153
JB
113772011-11-15 Juanma Barranquero <lekktu@gmail.com>
11378
11379 * image.c (imagemagick_load_image): Fix typo.
11380
322ad6ec
EZ
113812011-11-14 Eli Zaretskii <eliz@gnu.org>
11382
11383 * xdisp.c (display_line): Move the call to
11384 highlight_trailing_whitespace before the call to
11385 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
11386 faces of all the glyphs to compute ROW's hash value.
11387 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 11388
f067b8ec
JB
113892011-11-14 Juanma Barranquero <lekktu@gmail.com>
11390
11391 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
11392 just return (bug#10044).
11393
1e5b2111
EZ
113942011-11-12 Eli Zaretskii <eliz@gnu.org>
11395
7ef3cbd5
EZ
11396 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
11397 with user-defined heap size. Bump the default size of the temacs
11398 heap to 27MB, to avoid memory warning when running temacs.
11399 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
11400
1e5b2111
EZ
11401 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
11402 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
11403 (verify_row_hash) [XASSERTS]: New function.
11404 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
11405 that the hash value of glyph rows is correct.
1e5b2111 11406
89d61221
MR
114072011-11-12 Martin Rudalics <rudalics@gmx.at>
11408
11409 * window.h (window): Remove splits slot.
11410 * window.c (Fwindow_splits, Fset_window_splits): Remove.
11411 (Fdelete_other_windows_internal, make_parent_window)
11412 (make_window, Fsplit_window_internal, Fdelete_window_internal)
11413 (Fset_window_configuration, save_window_save): Don't deal with
11414 split status of windows.
11415 (saved_window): Remove splits slot.
11416 (Vwindow_splits): Rewrite doc-string.
11417
97f18cc8
JD
114182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
11419
11420 * xfns.c (unwind_create_frame):
11421 * nsfns.m (unwind_create_frame):
11422 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
11423 Vframe_list (Bug#9999).
11424
22a648b4
DA
114252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
11426
0b381c7e 11427 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 11428
659afede
KH
114292011-11-11 Kenichi Handa <handa@m17n.org>
11430
11431 * callproc.c (Fcall_process): Set the member dst_multibyte of
11432 process_coding.
11433
9ac0394b
KH
114342011-11-11 Johan Bockgård <bojohan@gnu.org>
11435
11436 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
11437 avoid a crash (bug#9496).
11438
2fbdc249
CY
114392011-11-09 Chong Yidong <cyd@gnu.org>
11440
11441 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
11442 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
11443
ac6b1f81
PE
114442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
11445
11446 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
11447
09db192c
PE
114482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
11449
11450 Avoid some portability problems by eschewing 'extern inline' functions.
11451 The trivial performance wins aren't worth the portability hassles; see
11452 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
11453 et seq.
11454 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
11455 (window_box_width, window_box_left, window_box_left_offset)
11456 (window_box_right, window_box_right_offset): Undo previous change,
11457 by removing the "extern"s.
11458 * intervals.c (adjust_intervals_for_insertion)
11459 (adjust_intervals_for_deletion): Undo previous change,
11460 making these static again.
11461 (offset_intervals, temp_set_point_both, temp_set_point)
11462 (copy_intervals_to_string): No longer inline.
11463 * xdisp.c (window_text_bottom_y, window_box_width)
11464 (window_box_height, window_box_left_offset)
11465 (window_box_right_offset, window_box_left, window_box_right)
11466 (window_box): No longer inline.
11467
105216ed
CY
114682011-11-08 Chong Yidong <cyd@gnu.org>
11469
11470 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
11471 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
11472 Signal an error if not a live window.
105216ed
CY
11473 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
11474 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
11475
ae9e237f
JB
114762011-11-07 Juanma Barranquero <lekktu@gmail.com>
11477
11478 * lisp.h (syms_of_abbrev): Remove declaration.
11479 Reported by CHENG Gao <chenggao@royau.me>.
11480
c7aa8333
EZ
114812011-11-07 Eli Zaretskii <eliz@gnu.org>
11482
11483 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
11484 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
11485 of temacs in GUI mode.
11486
be7f5545
MR
114872011-11-07 Martin Rudalics <rudalics@gmx.at>
11488
11489 * window.h: Declare delete_all_child_windows instead of
11490 delete_all_subwindows.
11491 * window.c (Fwindow_nest, Fset_window_nest)
11492 (Fset_window_new_total, Fset_window_new_normal)
11493 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
11494 (delete_all_subwindows): Rename to delete_all_child_windows.
11495 (Fdelete_other_windows_internal, Fset_window_configuration):
11496 Call delete_all_child_windows instead of delete_all_subwindows.
11497 * frame.c (delete_frame): Call delete_all_child_windows instead
11498 of delete_all_subwindows.
11499
ca78dc43
PE
115002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
11501
11502 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
11503 This is also needed for porting to any host where GC_MARK_STACK is
11504 not GC_MAKE_GCPROS_NOOPS.
11505 (which_symbols): Use it.
11506
a0241d01
KH
115072011-11-07 Kenichi Handa <handa@m17n.org>
11508
11509 * coding.c (coding_set_destination): Check coding->src_pos only
11510 when coding->src_object is a buffer (bug#9910).
11511
11512 * process.c (send_process): Set the member src_multibyte of coding
11513 to 0 (bug#9911) when sending a unibyte text.
11514
11515 * callproc.c (Fcall_process): Set the member src_multibyte of
11516 process_coding to 0 (bug#9912).
11517
a64bfdfa 115182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
11519
11520 * xmenu.c (cleanup_widget_value_tree): New function.
11521 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
11522 calling free_menubar_widget_value_tree directly (Bug#9830).
11523
cb41b32a
PE
115242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
11525
11526 Fix some portability problems with 'inline'.
11527 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
11528 (window_box_width, window_box_left, window_box_left_offset)
11529 (window_box_right, window_box_right_offset): Declare extern.
11530 Otherwise, these inline functions do not conform to C99 and
11531 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
11532 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
11533 * intervals.c (adjust_intervals_for_insertion)
11534 (adjust_intervals_for_deletion): Now extern, because otherwise the
11535 extern inline functions 'offset_intervals' couldn't refer to it.
11536 (static_offset_intervals): Remove.
11537 (offset_intervals): Rewrite using the old contents of
11538 static_offset_intervals. The old version didn't conform to C99
11539 because an extern inline function contained a reference to an
11540 identifier with static linkage.
11541
b7041366
AS
115422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
11543
11544 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
11545 GC.
11546
88a37c4d
EZ
115472011-11-06 Eli Zaretskii <eliz@gnu.org>
11548
11549 * xdisp.c (init_iterator, reseat_to_string): Don't set the
11550 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
11551 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
11552 return Qleft_to_right.
11553
49745b39
CY
115542011-11-06 Chong Yidong <cyd@gnu.org>
11555
11556 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
11557 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
11558 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
11559 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
11560 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
11561 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
11562 (Fwindow_vscroll): Doc fix.
11563 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
11564 argument, since it makes no sense to pass a live window and for
11565 consistency with window-child.
11566
1f05cd82
CS
115672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
11568
11569 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
11570 support MSVC.
11571
22610910
JR
115722011-11-05 Jason Rumney <jasonr@gnu.org>
11573
11574 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
11575 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
11576 fonts (Bug#6029).
11577 (add_font_entity_to_list): Fix logic errors in mixed boolean and
11578 bitwise arithmetic preventing use of unicode-sip and non-truetype
11579 opentype fonts.
11580
a06776b2
EZ
115812011-11-05 Eli Zaretskii <eliz@gnu.org>
11582
3ad924ba
EZ
11583 * s/ms-w32.h (fstat, stat, utime): Move redirections to
11584 "emacs"-only part.
11585
a06776b2
EZ
11586 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
11587 initialization code to keep similarity to xfns.c after changes
11588 from 2011-11-05.
11589
c9e7db78
JD
115902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
11591
a97f8f3f
JD
11592 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
11593 (unwind_create_frame): New function (Bug#9943).
11594 (Fx_create_frame): Restructure code to be more similar to the one in
11595 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
11596 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
11597 Move terminal->reference_count++ just before making the frame official
11598 (Bug#9943).
11599
11600 * nsterm.m (x_free_frame_resources): New function.
11601 (x_destroy_window): Move code to x_free_frame_resources.
11602
c9e7db78 11603 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
11604 (Fx_create_frame, x_create_tip_frame):
11605 Move terminal->reference_count++ just before making the frame
75f1671a 11606 official. Move initialization of image_cache_refcount and
c9e7db78
JD
11607 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
11608
a6fc3b5c
EZ
116092011-11-05 Eli Zaretskii <eliz@gnu.org>
11610
11611 Support MSVC build with newer versions of Visual Studio.
11612 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
11613 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
11614 nt/gmake.defs.
11615
11616 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
11617 which are not supported by MSVC.
11618 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
11619 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
11620 bitfields.
11621 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
11622 types in bitfields.
11623 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
11624
11625 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
11626
58179cce 116272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
11628
11629 Support MSVC build with newer versions of Visual Studio.
11630 * w32.c: Don't include w32api.h for MSVC.
11631 (init_environment) [_MSC_VER]: Call sys_access, not _access.
11632
11633 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
11634 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
11635 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
11636 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
11637 e_* cousins.
11638 (alloca) [_MSC_VER]: Define to _alloca.
11639
11640 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
11641
11642 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
11643
a58c13ed
EZ
116442011-11-04 Eli Zaretskii <eliz@gnu.org>
11645
11646 * xdisp.c (note_mouse_highlight): If either of
11647 previous/next-single-property-change returns nil, treat that as
11648 the beginning or the end of the buffer. (Bug#9955)
11649
fe0b6370
JD
116502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
11651
a58c13ed 11652 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
11653 label is not null (Bug#9951).
11654 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
11655 may be NULL.
11656
89bd5ee1
EZ
116572011-11-04 Eli Zaretskii <eliz@gnu.org>
11658
11659 * window.c (Fwindow_body_size): Mention in the doc string that the
11660 return value is in frame's canonical units. (Bug#9949)
11661
84c3edb9
EZ
116622011-11-03 Eli Zaretskii <eliz@gnu.org>
11663
4e2fb5c7
EZ
11664 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
11665
84c3edb9 11666 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 11667 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 11668 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 11669
bc17a887
EZ
116702011-11-01 Eli Zaretskii <eliz@gnu.org>
11671
11672 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
11673 Don't stop backward scan on the continuation glyph, even though
11674 its CHARPOS is positive.
6d5eb5b0
SM
11675 (mouse_face_from_buffer_pos, note_mouse_highlight):
11676 Rename cover_string to disp_string.
bc17a887 11677
4ee88440
MR
116782011-11-01 Martin Rudalics <rudalics@gmx.at>
11679
11680 * window.c (temp_output_buffer_show): Don't use
11681 Vtemp_buffer_show_specifiers.
11682 (Vtemp_buffer_show_specifiers): Remove unused variable.
11683
c2ff3c02
EZ
116842011-10-30 Eli Zaretskii <eliz@gnu.org>
11685
11686 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
11687 past the beginning of the current glyph matrix.
11688
58179cce 116892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
11690
11691 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
11692 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
11693 HAVE_GTK3 (Bug#9869).
b77a6a7f 11694
3b574623
JD
11695 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
11696 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
11697
b77a6a7f
JD
11698 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
11699
11700 * xterm.c: Declare x_handle_net_wm_state to return int.
11701 (handle_one_xevent): Check if we are iconified but don't have
11702 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
11703 (get_current_wm_state): Return non-zero if not hidden,
11704 check for _NET_WM_STATE_HIDDEN (Bug#9893).
11705 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
11706 (x_handle_net_wm_state): Return what get_current_wm_state returns.
11707 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
11708
196e41e4
PE
117092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
11710
11711 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
11712 so that this new function doesn't get optimized away by a
11713 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
11714
021f2e1a
AS
117152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
11716
11717 * frame.h (MOUSE_HL_INFO): Remove excess parens.
11718
8b058d44
EZ
117192011-10-29 Eli Zaretskii <eliz@gnu.org>
11720
11721 Fix the `xbytecode' command.
11722 * .gdbinit (xprintbytestr): New command.
b50a28de 11723 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
11724 (xbytecode): Print the byte-code string as well.
11725
4452fb80
EZ
117262011-10-29 Kim Storm <storm@cua.dk>
11727
8b058d44
EZ
11728 * alloc.c (which_symbols): New function.
11729
21b72067
AS
117302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
11731
11732 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
11733 line. (Bug#9903)
11734
83ed7b5c
GM
117352011-10-29 Glenn Morris <rgm@gnu.org>
11736
11737 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
11738 Not clear what it was for, and it causes various bugs. (Bug#9839)
11739
5a7a728b
EZ
117402011-10-28 Eli Zaretskii <eliz@gnu.org>
11741
11742 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
11743 possible random value that matches one of those tested as
11744 condition to clear the mouse face.
11745
d3d0842f
CY
117462011-10-28 Chong Yidong <cyd@gnu.org>
11747
11748 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
11749
31b39d13
DN
117502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
11751
11752 * window.c (make_window): Initialize phys_cursor_on_p.
11753
9aba6043
SM
117542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
11755
11756 * lisp.h (struct Lisp_Symbol): Update comments.
11757
c20992f4
JB
117582011-10-28 Juanma Barranquero <lekktu@gmail.com>
11759
11760 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
11761
db4f02f2
EZ
117622011-10-28 Eli Zaretskii <eliz@gnu.org>
11763
11764 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
11765 <oslsachem@gmail.com> for helping to debug this.
11766
11767 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
11768 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
11769 (g_b_init_get_glyph_outline_w): New static variables.
11770 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
11771 (GetGlyphOutlineW_Proc): New typedefs.
11772 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
11773 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
11774 New functions.
11775 (w32font_open_internal, compute_metrics):
11776 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
11777 instead of calling the "wide" APIs directly.
11778
11779 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
11780
11781 * w32.h (syms_of_w32font): Add prototype.
11782
87e68db4
JB
117832011-10-27 Juanma Barranquero <lekktu@gmail.com>
11784
11785 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
11786 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
11787 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
11788 (Fmove_to_window_line): Doc fix.
11789
435c1d67
CY
117902011-10-27 Chong Yidong <cyd@gnu.org>
11791
11792 * process.c (make_process): Set gnutls_state to NULL.
11793
11794 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
11795 non-NULL, regardless of GNUTLS_INITSTAGE.
11796 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
11797 an error. Set process slots as soon as we allocate them.
11798
11799 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
11800
9c6c6f49
CY
118012011-10-27 Chong Yidong <cyd@gnu.org>
11802
9aba6043
SM
11803 * gnutls.c (emacs_gnutls_deinit): New function.
11804 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
11805 (Fgnutls_deinit, Fgnutls_boot): Use it.
11806
11807 * process.c (make_process): Initialize GnuTLS credentials to NULL.
11808 (deactivate_process): Call emacs_gnutls_deinit.
11809
657d08d3
JB
118102011-10-27 Juanma Barranquero <lekktu@gmail.com>
11811
11812 * image.c (x_create_x_image_and_pixmap):
11813 * w32.c (sys_rename, w32_delayed_load):
11814 * w32font.c (fill_in_logfont):
11815 * w32reg.c (x_get_string_resource): Silence compiler warnings.
11816
5430d399
JB
118172011-10-26 Juanma Barranquero <lekktu@gmail.com>
11818
11819 * w32fns.c (w32_default_color_map): New function,
11820 extracted from Fw32_default_color_map.
a7ef684b 11821 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 11822
fe0055fa
PE
118232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
11824
11825 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
11826
e6346438
SM
118272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
11828
11829 * keyboard.c (test_undefined): New function (bug#9751).
11830 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
11831
e112cc37
ET
118322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
11833
11834 * sysdep.c (init_sys_modes): Fix the check for the controlling
11835 terminal (Bug#6649).
11836
7b5d6677
EZ
118372011-10-20 Eli Zaretskii <eliz@gnu.org>
11838
11839 * dispextern.h (struct bidi_it): New member next_en_type.
11840
11841 * bidi.c (bidi_line_init): Initialize the next_en_type member.
11842 (bidi_resolve_explicit_1): When next_en_pos is valid for the
11843 current character, check also for next_en_type being WEAK_EN.
11844 (bidi_resolve_weak): Don't enter the expensive loop if the current
11845 position is before next_en_pos. Record the bidi type of the first
11846 non-ET, non-BN character we find, in addition to its position.
11847 (bidi_level_of_next_char): Invalidate next_en_type when
11848 next_en_pos is over-stepped.
11849
7da0b018
PE
118502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
11851
11852 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
11853 * editfns.c: Rewrite current-time-zone so that it invokes
11854 the equivalent of (format-time-string "%Z") to get the time zone name.
11855 This fixes a bug when the time zone name contains characters that
11856 need converting from the system time locale to Emacs internal format.
11857 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
11858 that patch fixed format-time-string to do the conversion, but
11859 I forgot to fix current-time-zone.
11860 (format_time_string): New function, containing most of
11861 what Fformat_time_string used to contain.
11862 (Fformat_time_string): Rewrite in terms of format_time_string.
11863 This doesn't change this function's behavior.
11864 (current-time-zone): Rewrite to use format_time_string.
11865 This fixes the bug reported by Michael Schierl in
11866 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
11867 Jason Rumney's 2007-06-07 change worked around this bug, but
11868 didn't fix it.
11869 * systime.h (tzname, timezone): Remove no-longer-used declarations.
11870
8547b010
EZ
118712011-10-19 Eli Zaretskii <eliz@gnu.org>
11872
11873 * xdisp.c (start_display): If the character at POS is displayed
11874 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
11875 (try_window_reusing_current_matrix): If a line ends in a display
11876 vector or the next line starts in a display vector, continue
11877 redrawing the window even though the character position of
11878 start_row was reached.
8547b010
EZ
11879 (Bug#9771, part 2)
11880
4e948d15
CY
118812011-10-18 Chong Yidong <cyd@gnu.org>
11882
11883 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
11884 with nobreak-char-display too.
11885
4787455f
EZ
118862011-10-18 Eli Zaretskii <eliz@gnu.org>
11887
11888 Fix part 3 of bug#9771.
11889 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
11890 (bidi_resolve_neutral): Don't enter the expensive loop looking for
11891 non-neutral characters if the current character is a paragraph
11892 separator (a.k.a. Newline). This avoids running the same
11893 expensive loop twice, once when we consume the preceding newline
11894 and the other time when the line actually needs to be displayed.
11895 Avoid the loop when we see neutrals on the base embedding level
11896 following a character whose directionality is the same as the
11897 paragraph's. This avoids running the expensive loop when a line
11898 ends in a long sequence of neutrals, like control characters.
11899 Add assertion against STRONG_AL type. Slightly rearrange code
11900 that determines the type of a neutral given the first non-neutral
11901 that follows it.
11902 (bidi_level_of_next_char): Set next_en_pos to zero when
11903 invalidating its info.
11904
2c91f553
EZ
119052011-10-17 Eli Zaretskii <eliz@gnu.org>
11906
11907 * xdisp.c (push_display_prop): Determine whether to record string
11908 or buffer position by IT->string, not by IT->method. Allow
11909 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
11910 (move_it_vertically_backward): Don't look for character position
11911 immediately after the newline when in a continuation line.
11912 (Bug#9771, part 1)
2c91f553 11913
c7b08b0d
MR
119142011-10-15 Martin Rudalics <rudalics@gmx.at>
11915
11916 * window.c (coordinates_in_window): Rewrite and delabelize
11917 vertical border check. (Bug#5357) (Bug#9618)
11918
6b02f655
SM
119192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
11920
11921 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
11922 errors in XSetWindowBorder (bug#9310).
11923
81d40c92
DA
119242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
11925
11926 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
11927 avoid crash when xmalloc overrun checking is enabled.
11928
d4172c3b
EZ
119292011-10-13 Eli Zaretskii <eliz@gnu.org>
11930
11931 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
11932 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
11933 cursor motion with <left> and <right> arrow keys.
11934
11935 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
11936 some callers set that themselves.
11937
b00eea75
EZ
119382011-10-12 Eli Zaretskii <eliz@gnu.org>
11939
11940 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
11941 display string and the previous row comes from the same string and
11942 is empty. (Bug#9739) (Bug#9738)
11943
8fe012c4
SM
119442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
11945
11946 * doc.c (get_doc_string): Encode file name (bug#9735).
11947
0074aef2
EZ
119482011-10-12 Eli Zaretskii <eliz@gnu.org>
11949
79beb178
EZ
11950 * bidi.c (bidi_level_of_next_char):
11951 * xdisp.c (get_visually_first_element): Remove old incorrect
11952 comments regarding the Unicode Line Separator character.
11953
0074aef2
EZ
11954 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
11955
6e4b3fbe
DA
119562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
11957
11958 * alloc.c (Fgc_status): Do not access beyond zombies array
11959 boundary if nzombies > MAX_ZOMBIES.
11960 * alloc.c (dump_zombies): Add missing format specifier.
11961
0324f3af
PE
119622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
11963
b5525cac
PE
11964 * xdisp.c (set_cursor_from_row): Simplify conditionals,
11965 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
11966
0324f3af
PE
11967 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
11968 Some packages use them to denote characters with modifiers.
11969
e9b5f888
AS
119702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
11971
11972 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
11973 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
11974 matching a pp-number. Rename parameter var to var1.
11975
127827c0
SM
119762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
11977
11978 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
11979
c8fd3bd0
GM
119802011-10-08 Glenn Morris <rgm@gnu.org>
11981
11982 * callint.c (Fcall_interactively): Give a more explicit error for the
11983 'c' case with a non-character input. (Bug#8479)
11984
352ec8ff
EZ
119852011-10-08 Eli Zaretskii <eliz@gnu.org>
11986
03669ccb
EZ
11987 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
11988 lines.
7061c986
EZ
11989 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
11990 lines that are hscrolled on the left.
03669ccb 11991
352ec8ff
EZ
11992 * dispnew.c (buffer_posn_from_coords): Account for a possible
11993 presence of header-line. (Bug#4426)
11994
a66cfb1c
SM
119952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
11996
6b02f655
SM
11997 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
11998 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 11999
7c5ee88e
PE
120002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
12001
12002 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
12003 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
12004 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
12005 this makes Emacs dump core during garbage collection on rare
12006 occasions. sizeof is obviously inferior to offsetof here, so
12007 stick with offsetof.
12008 (GC_POINTER_ALIGNMENT): New macro.
12009 (mark_memory): Omit 3rd (offset) arg; caller changed.
12010 Don't assume EMACS_INT alignment is the same as pointer alignment.
12011
df1bbe5b
SM
120122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
12013
12014 * keyboard.c (read_key_sequence_remapped): New var.
12015 (read_key_sequence): Compute remapping in the right buffer.
12016 (command_loop_1): Use read_key_sequence's remapping directly.
12017
51553db6
SM
120182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
12019
32c1fffd
SM
12020 * dired.c (file_name_completion): Don't expand file name.
12021 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
12022 before checking file name handler.
12023
51553db6
SM
12024 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
12025 they've been requested explicitly (bug#9591).
12026
b6bd1599 120272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
12028
12029 * keymap.c (Fsingle_key_description): Use make_specified_string
12030 instead of build_string to build string from push_key_description.
12031 (Bug#5193)
12032
f701dc2a
PE
120332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
12034
4222c55d
PE
12035 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
12036 This fixes a Y2038 bug on 64-bit hosts.
12037 * buffer.c (reset_buffer):
12038 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
12039 (Fclear_buffer_auto_save_failure):
12040 Use 0, not -1, to represent an unset failure time, since time_t
12041 might not be signed.
12042
f701dc2a
PE
12043 Remove dependency on glibc malloc internals.
12044 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
12045 Move back here from lisp.h, but with their new implementations.
12046 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
12047 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
12048 * charset.c (charset_table_init): New static var.
12049 (syms_of_charset): Use it instead of xmalloc. This removes a
12050 dependency on glibc malloc internals. See Eli Zaretskii's comment in
12051 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
12052 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
12053 Move back to alloc.c.
12054 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
12055 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
12056
9ceebf39
JD
120572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
12058
12059 * nsterm.m (windowDidResize): Call x_set_window_size only when
12060 ns_in_resize is true. Otherwise set pixelwidth/height and
12061 call change_frame_size (Bug#9628).
12062
cb993c58
PE
120632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
12064
3930c88b
PE
12065 Port --enable-checking=all to Fedora 14 x86-64.
12066 * charset.c (syms_of_charset): Also account for glibc malloc's
12067 internal overhead when calculating the initial malloc maximum.
12068
cb993c58
PE
12069 Port --enable-checking=all to Fedora 14 x86.
12070 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
12071 Move to lisp.h.
12072 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
12073 (overrun_check_realloc, overrun_check_free):
12074 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
12075 That way, xmalloc returns a properly-aligned pointer even if
12076 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
12077 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
12078 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
12079 into account when calculating the initial malloc maximum.
12080 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
12081 Move here from alloc.c, so that charset.c can use it too.
12082 Properly align; the old code wasn't right for common 32-bit hosts
12083 when configured with --enable-checking=all.
12084 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
12085 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
12086
31bed486
EZ
120872011-09-29 Eli Zaretskii <eliz@gnu.org>
12088
04c70788 12089 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
12090 use EDOM.
12091
fbcaa2f3
EZ
120922011-09-28 Eli Zaretskii <eliz@gnu.org>
12093
12094 * xdisp.c (compute_display_string_end): If there's no display
12095 string at CHARPOS, return -1.
12096
12097 * bidi.c (bidi_fetch_char): When compute_display_string_end
12098 returns a negative value, treat the character as a normal
12099 character not covered by a display string. (Bug#9624)
12100
a239d4e9
JB
121012011-09-28 Juanma Barranquero <lekktu@gmail.com>
12102
12103 * lread.c (Fread_from_string): Fix typo in docstring.
12104
88652fd5
EZ
121052011-09-27 Eli Zaretskii <eliz@gnu.org>
12106
12107 * xdisp.c (handle_invisible_prop): If invisible text ends on a
12108 newline, reseat the iterator instead of bidi-iterating there one
12109 character at a time. (Bug#9610)
32c1fffd
SM
12110 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
12111 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 12112
ed497dd4
AS
121132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
12114
12115 * lread.c (readevalloop): Use correct code for NBSP.
12116 (read1): Likewise. (Bug#9608)
12117
b2bf61aa
MA
121182011-09-25 Michael Albinus <michael.albinus@gmx.de>
12119
12120 * dbusbind.c (Fdbus_register_signal): When service is not
12121 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
12122
32bbb17c
GM
121232011-09-25 Glenn Morris <rgm@gnu.org>
12124
12125 * buffer.c (truncate-lines): Doc fix.
12126
94e0933e
CY
121272011-09-24 Chong Yidong <cyd@stupidchicken.com>
12128
12129 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
12130 (Fset_window_next_buffers): Doc fix.
12131
cddde921
GM
121322011-09-24 Glenn Morris <rgm@gnu.org>
12133
12134 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
12135
1260aef1
PE
121362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
12137
25b4bfa0
PE
12138 Fix minor problems found by static checking.
12139 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
12140 * indent.c (Fvertical_motion): Fix == vs = typo.
12141
e3cbd34b
EZ
121422011-09-24 Eli Zaretskii <eliz@gnu.org>
12143
a66cfb1c
SM
12144 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
12145 Default value is now t. Doc fix.
6bf7006f 12146
e3cbd34b 12147 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 12148 logic when moving up, not only when moving down. Fix the
e3cbd34b 12149 confusing name and values of the it_overshoot_expected variable;
32c1fffd 12150 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
12151
12152 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
12153 CHARPOS is covered by a display string which includes newlines.
12154 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
12155 is covered by a display string with embedded newlines.
12156
a3de0cbd
MA
121572011-09-24 Michael Albinus <michael.albinus@gmx.de>
12158
12159 * dbusbind.c (Fdbus_register_signal): Add match rule to
12160 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
12161 (Fdbus_register_method, Vdbus_registered_objects_table):
12162 Fix docstring.
a3de0cbd 12163
b260039d
JM
121642011-09-24 Jim Meyering <meyering@redhat.com>
12165
32c1fffd 12166 do not ignore write error for any output size
b260039d
JM
12167 The previous change was incomplete.
12168 While it makes emacs --batch detect the vast majority of stdout
12169 write failures, errors were still ignored whenever the output size is
12170 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
12171 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
12172 && echo FAIL: ignored write error
12173 FAIL: ignored write error
12174 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
12175 && echo FAIL: ignored write error
12176 FAIL: ignored write error
12177 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
12178
8eca8a7c
AS
121792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
12180
12181 * emacs.c (Fkill_emacs): In noninteractive mode exit
12182 non-successfully if a write error occurred on stdout. (Bug#9574)
12183
3341db62
EZ
121842011-09-21 Eli Zaretskii <eliz@gnu.org>
12185
12186 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
12187 the xassert test.
12188
12189 * dispextern.h (struct it): Update the comment documenting what
12190 can it->OBJECT be.
12191
8c203dbf
EZ
121922011-09-20 Eli Zaretskii <eliz@gnu.org>
12193
12194 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
12195 a display string, extend search for cursor position to end of row.
12196 (find_row_edges): If the row ends in a newline from a display
12197 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
12198 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
12199 (Fcurrent_bidi_paragraph_direction): Fix search for previous
12200 non-empty line. Fixes confusing cursor motion with arrow keys at
12201 the beginning of a line that starts with whitespace.
8c203dbf 12202
a4824228
LMI
122032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12204
12205 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
12206 (bug#9493).
12207
33ed493b
CY
122082011-09-18 Chong Yidong <cyd@stupidchicken.com>
12209
12210 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
12211 boolean (Bug#9154).
12212
56cd55c8
EZ
122132011-09-18 Eli Zaretskii <eliz@gnu.org>
12214
12215 * xdisp.c (display_line): Record maximum and minimum buffer
12216 positions even if no glyphs were produced (e.g., by a zero-width
12217 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
12218 buffer positions that will be removed from the glyph row because
12219 they don't fit.
c02dcedf
EZ
12220 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
12221 column is beyond frame width: don't subtract 1 "pixel" when
12222 computing width of the stretch.
3e62b7e0
EZ
12223 (reseat_at_next_visible_line_start): Undo the change made on
12224 2011-09-17 that saved paragraph information and restored it after
12225 the call to `reseat'. (Bug#9545)
56cd55c8 12226
5ed99d36 122272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
12228
12229 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
12230 and turn window cursor on if cleared (Bug#9415).
12231
5ed99d36 122322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
12233
12234 * search.c (boyer_moore): Take unibyte characters from pattern
12235 literally. (Bug#9458)
12236
9bade7b2
EZ
122372011-09-18 Eli Zaretskii <eliz@gnu.org>
12238
12239 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
12240
e5e9d610
PE
122412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
12242
87e4427a
PE
12243 Fix minor problem found by static checking.
12244 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
12245 initialized, to pacify gcc -Wuninitialized.
12246
e5e9d610
PE
12247 * fileio.c: Report proper errno when syscall falls.
12248 (Finsert_file_contents): Save and restore errno,
12249 so that report_file_error outputs the correct diagnostic.
12250 (Fwrite_region) [CLASH_DETECTION]: Likewise.
12251
a1674f0b
EZ
122522011-09-18 Eli Zaretskii <eliz@gnu.org>
12253
12254 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
12255
fbfb6dd4
EZ
122562011-09-17 Eli Zaretskii <eliz@gnu.org>
12257
12258 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
12259 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
12260
bb187662
EZ
122612011-09-17 Eli Zaretskii <eliz@gnu.org>
12262
1137e8b8 12263 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 12264 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
12265
12266 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
12267 (bidi_find_paragraph_start): Search back for paragraph beginning
12268 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
12269 (bidi_move_to_visually_next): Only trigger paragraph-related
12270 computations when the last character is a newline or at EOB, not
12271 just any NEUTRAL_B. (Bug#9470)
12272
bb187662
EZ
12273 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
12274 truncated lines if point is covered by a display string. (Bug#9524)
12275
2e621251
PE
122762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
12277
12278 * xselect.c: Relax test for outgoing X longs (Bug#9498).
12279 (cons_to_x_long): New function.
12280 (lisp_data_to_selection_data): Use it. Correct the test for
12281 short-versus-long data; it was negated. Break out of vector
12282 loop, for efficiency, when a long datum is discovered.
12283
91a15bc6
SM
122842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
12285
12286 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
12287
b41c3a35
EZ
122882011-09-16 Eli Zaretskii <eliz@gnu.org>
12289
12290 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
12291 GCC PR/17406) by declaring this function with external scope.
12292
7812ba2d
PE
122932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
12294
12295 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
12296 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
12297
cf7edc2a
AS
122982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
12299
12300 * editfns.c (Fformat): Correctly handle text properties on "%%".
12301
bd01620e
EZ
123022011-09-15 Eli Zaretskii <eliz@gnu.org>
12303
12304 * xterm.c (x_draw_composite_glyph_string_foreground):
12305 * w32term.c (x_draw_composite_glyph_string_foreground):
12306 * term.c (encode_terminal_code):
12307 * composite.c (composition_update_it, get_composition_id):
12308 * xdisp.c (get_next_display_element)
12309 (fill_composite_glyph_string): Add comments about special meaning
12310 of TAB characters in a composition.
12311
a02719a3
PE
123122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
12313
12314 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
12315 This occurs when processing a multibyte format.
12316 Problem reported by Wolfgang Jenker.
a02719a3 12317
72589a3c
JB
123182011-09-15 Johan Bockgård <bojohan@gnu.org>
12319
12320 * xdisp.c (try_cursor_movement): Only check for exact match if
12321 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
12322
1c14176c
PE
123232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
12324
12325 Remove unused external symbols.
12326 * dispextern.h (calc_pixel_width_or_height): Remove decl.
12327 * xdisp.c (calc_pixel_width_or_height): Now static.
12328 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
12329 * indent.c (check_display_width):
12330 * w32term.c: Fix comment to match code.
12331 * xterm.c, xterm.h (x_catching_errors): Remove.
12332
d2eea5b5
PE
123332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
12334
12335 * xselect.c: Use signed conversions more consistently (Bug#9498).
12336 (selection_data_to_lisp_data): Assume incoming selection data are
12337 signed integers, not unsigned. This is to be consistent with
12338 outgoing selection data, which was modified to use signed integers
12339 in as part of the fix to Bug#9196 in response to Jan D.'s comment
12340 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
12341 expects long, not unsigned long.
12342
46888499
EZ
123432011-09-14 Eli Zaretskii <eliz@gnu.org>
12344
12345 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
12346 computation of loop end. Reported by Johan Bockgård
12347 <bojohan@gnu.org>.
12348
ef8ef9fb
CY
123492011-09-13 Chong Yidong <cyd@stupidchicken.com>
12350
12351 * frame.c (Fother_visible_frames_p): Function deleted.
12352
fa819fed
EZ
123532011-09-12 Eli Zaretskii <eliz@gnu.org>
12354
12355 * indent.c (compute_motion): Process display vector front to back
12356 rather than the other way around. (Bug#2496)
12357
2ba8e008
SM
123582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
12359
12360 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
12361
20f53c69
CY
123622011-09-11 Chong Yidong <cyd@stupidchicken.com>
12363
12364 * minibuf.c (Fread_from_minibuffer): Doc fix.
12365
d562d7a4
EZ
123662011-09-11 Eli Zaretskii <eliz@gnu.org>
12367
12368 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
12369 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
12370
1c4d7f3d
LMI
123712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12372
12373 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
12374 value for non-existent files.
12375
b885bf36
EZ
123762011-09-11 Eli Zaretskii <eliz@gnu.org>
12377
12378 * fileio.c (Finsert_file_contents): If the file cannot be opened,
12379 set its "size" to -1. This will set the modtime_size field of
12380 the corresponding buffer to -1, which is what
12381 verify-visited-file-modtime expects for files that do not exist.
12382 (Bug#9139)
12383
6612f0bf
PE
123842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
12385
12386 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
12387 here ...
12388 * lisp.h: ... from here. push_key_description is no longer
12389 defined in keyboard.c, so its declaration should not be in
12390 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
12391 logically belongs with push_key_description.
12392
dfb3f755
PE
123932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
12394
12395 * buffer.h: Include <sys/types.h> instead of <time.h>.
12396 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
12397 Problem reported by Herbert J. Skuhra.
12398
3134906c
LMI
123992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
12400
12401 * xml.c (parse_region): Make the parsing work for
12402 non-comment-starting XML files again (bug#9144).
12403
8d903f4e
AS
124042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
12405
12406 * image.c (gif_load): Fix calculation of bottom and right corner.
12407 (Bug#9468)
12408
80ad64f4
EZ
124092011-09-10 Eli Zaretskii <eliz@gnu.org>
12410
12411 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
12412 redisplay in small windows.
12413
208a048d
EZ
124142011-09-09 Eli Zaretskii <eliz@gnu.org>
12415
12416 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
12417
9b1c252e
MR
124182011-09-08 Martin Rudalics <rudalics@gmx.at>
12419
12420 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
12421 Operate on live windows only.
12422
2949f33b
JB
124232011-09-08 Juanma Barranquero <lekktu@gmail.com>
12424
12425 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
12426
e08dcafd
EZ
124272011-09-07 Eli Zaretskii <eliz@gnu.org>
12428
12429 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
12430 only under bidi iteration.
12431
115b96bd
JD
124322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
12433
12434 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
12435
c8199d0f
PE
124362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
12437
12438 isnan: Fix porting problem to Solaris 10 with bundled gcc.
12439 Without this fix, the command to link temacs failed due to an
12440 undefined symbol __builtin_isnan. This is because
12441 /usr/include/iso/math_c99.h #defines isnan(x) to
12442 __builtin_isnan(x), but the bundled gcc, which identifies itself
12443 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
12444 a __builtin_isnan.
12445 * floatfns.c (isnan): #undef, and then #define to a clone of
12446 what's in data.c.
12447 (Fisnan): Always define, since it's always available now.
12448 (syms_of_floatfns): Always define isnan at the Lisp level.
12449
e39b275c 124502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
12451
12452 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
12453
b2db44d9 124542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 12455
f4af5137 12456 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
12457 The previous code assumed that file offsets (off_t values) fit in
12458 EMACS_INT variables, which is not true on typical 32-bit hosts.
12459 The code messed up by falsely reporting buffer overflow in cases
12460 such as (insert-file-contents "big" nil 1 2) into an empty buffer
12461 when "big" contains more than 2**29 bytes, even though this
12462 inserts just one byte and does not overflow the buffer.
12463 (Finsert_file_contents): Store file offsets as off_t
12464 values, not as EMACS_INT values. Check for overflow when
12465 converting between EMACS_INT and off_t. When checking for
12466 buffer overflow or for overlap, take the offsets into account.
12467 Don't use EMACS_INT for small values where int suffices.
12468 When checking for overlap, fix a typo: ZV was used where
12469 ZV_BYTE was intended.
12470 (Fwrite_region): Don't assume off_t fits into 'long'.
12471 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
12472
ecfc0a49
MA
124732011-09-05 Michael Albinus <michael.albinus@gmx.de>
12474
12475 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
12476
6511acf2 124772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 12478
0999621a 12479 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
12480
12481 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 12482 (esprintf, exprintf, evxprintf): New functions.
62f19c19 12483 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 12484 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
12485 (modify_event_symbol): Do not assume that the length of
12486 name_alist_or_stem is safe to alloca and fits in int.
12487 (Fexecute_extended_command): Likewise for function name and binding.
12488 (Frecursion_depth): Wrap around reliably on integer overflow.
12489 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
12490 since some callers pass EMACS_INT values.
12491 (Fsingle_key_description): Don't crash if symbol name contains more
12492 than MAX_ALLOCA bytes.
12493 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
12494 (get_minibuffer): Arg is now EMACS_INT, not int.
12495 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 12496 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
12497 * window.h (command_loop_level, minibuf_level): Reflect API changes.
12498
2be7d702
PE
12499 * dbusbind.c (signature_cat): New function.
12500 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
12501 Do not overrun buffer; instead, report string overflow.
12502
9d1df220
PE
12503 * dispnew.c (add_window_display_history): Don't overrun buffer.
12504 Truncate instead; this is OK since it's just a log.
12505
33ef5c64
PE
12506 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
12507 even if the time zone offset is outlandishly large.
12508 Don't mishandle offset == INT_MIN.
12509
66c6fdd5
PE
12510 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
12511 when creating daemon; the previous buffer-overflow check was incorrect.
12512
d749b01b
PE
12513 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
12514 which has the guts of the old verror function.
12515
b5cd1905
PE
12516 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
12517 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
12518
6e1a67fb
PE
12519 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
12520 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 12521 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 12522 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
12523 length of string rather than counting it via multiple sprintfs;
12524 that's simpler and more reliable.
c21721cc
PE
12525 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
12526 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
12527 sprintf, in case result does not fit in int.
12528
c57b67fc
PE
12529 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
12530 (fontset_from_font): Print it.
12531
8a401434
PE
12532 * frame.c (tty_frame_count): Now printmax_t, not int.
12533 (make_terminal_frame, set_term_frame_name): Print it.
12534 (x_report_frame_params): In X, window IDs are unsigned long,
12535 not signed long, so print them as unsigned.
12536 (validate_x_resource_name): Check for implausibly long names,
12537 and don't assume name length fits in 'int'.
12538 (x_get_resource_string): Don't blindly alloca invocation name;
12539 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
12540 not fit in int.
12541
6e1a67fb
PE
12542 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
12543 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
12544 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
12545
0df02bf3
PE
12546 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
12547 Use esprintf, not sprintf, in case result does not fit in int.
12548
48e30793
PE
12549 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
12550 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
12551 it as a large positive number.
12552 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
12553 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
12554
a66ff6d8
PE
12555 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
12556 in case result does not fit in int.
12557
aca216ff
PE
12558 * print.c (float_to_string): Detect width overflow more reliably.
12559 (print_object): Make sprintf buffer a bit bigger, to avoid potential
12560 buffer overrun. Don't assume list length fits in 'int'. Treat
12561 print length of 0 as 0, not as infinity; to be consistent with other
12562 uses of print length in this function. Don't overflow print length
12563 index. Don't assume hash table size fits in 'long', or that
12564 vectorlike size fits in 'unsigned long'.
12565
31c286f7
PE
12566 * process.c (make_process): Use printmax_t, not int, to format
12567 process-name gensyms.
12568
55e5faa1
PE
12569 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
12570
80f2e268
PE
12571 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
12572 to avoid potential buffer overrun.
12573
670741ab
PE
12574 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
12575 if X resource line is longer than 512 bytes.
12576
b7163a50
PE
12577 * xfns.c (x_window): Make sprintf buffer a bit bigger
12578 to avoid potential buffer overrun.
12579
ae58ff1f
PE
12580 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
12581
c43c8a6a
PE
12582 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
12583
3f8236f4
PE
125842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
12585
53e9fe90 12586 Integer overflow fixes for scrolling, etc.
6511acf2
PE
12587 Without these, Emacs silently mishandles large integers sometimes.
12588 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
12589 it were "C-u 1 M-x recenter" on a typical 64-bit host.
12590
6511acf2
PE
12591 * xdisp.c (try_window_id): Check Emacs fixnum range before
12592 converting to 'int'.
806add1d 12593
6511acf2 12594 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
12595 Check that an Emacs fixnum is in range before assigning it to 'int'.
12596 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
12597 values converted from Emacs fixnums.
12598 (Frecenter): Don't wrap around a line count if it is out of 'int'
12599 range; instead, treat it as an extreme value.
12600 (Fset_window_configuration, compare_window_configurations):
12601 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
12602
6511acf2
PE
12603 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
12604 that can exceed INT_MAX. Check that EMACS_INT value is in range
12605 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
12606 (match_limit): Don't assume that a fixnum can fit in 'int'.
12607
6511acf2 12608 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
12609 exceed INT_MAX.
12610
6511acf2 12611 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
12612 (Fvertical_motion): Don't wrap around LINES values that don't fit
12613 in 'int'. Instead, treat them as extreme values. This is good
12614 enough for windows, which can't have more than INT_MAX lines anyway.
12615
fcb901a7
LMI
126162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12617
0f2f6b6d
LMI
12618 * Require libxml/parser.h to avoid compilation warning.
12619
fcb901a7
LMI
12620 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
12621
12622 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
12623 since this reportedly can destroy thread storage.
12624
6e20a0d4
CY
126252011-08-30 Chong Yidong <cyd@stupidchicken.com>
12626
12627 * syntax.c (find_defun_start): Update all cache variables if
12628 exiting early (Bug#9401).
12629
148ae00e
EZ
126302011-08-30 Eli Zaretskii <eliz@gnu.org>
12631
f6cfbd8f
EZ
12632 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
12633
148ae00e
EZ
12634 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
12635 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
12636 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
12637
12638 * term.c (tty_append_glyph): New function.
12639 (produce_stretch_glyph): Static function and its prototype deleted.
12640
a66cfb1c
SM
12641 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
12642 Add prototypes.
148ae00e 12643
c4a07a4c
PE
126442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
12645
12646 * image.c (parse_image_spec): Check for nonnegative, not for positive,
12647 when checking :margin (Bug#9390).
12648 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 12649 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
12650 so that the name doesn't mislead. All uses changed.
12651
6bc8cd65
JB
126522011-08-28 Johan Bockgård <bojohan@gnu.org>
12653
12654 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
12655 set_tty_hooks.
12656
dca4927e
EZ
126572011-08-27 Eli Zaretskii <eliz@gnu.org>
12658
12659 * xdisp.c (move_it_to): Don't bail out early when reaching
12660 position beyond to_charpos, if we are scanning backwards.
12661 (move_it_vertically_backward): When DY == 0, make sure we get to
12662 the first character in the line after the newline.
12663
f2cad773
PE
126642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
12665
12666 * ccl.c: Improve and simplify overflow checking (Bug#9196).
12667 (ccl_driver): Do not generate an out-of-range pointer.
12668 (Fccl_execute_on_string): Remove unnecessary check for
12669 integer overflow, noted by Stefan Monnier in
12670 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
12671 Remove a FIXME that didn't need fixing.
12672 Simplify the newly-introduced buffer reallocation code.
12673
0cae2cdb
JB
126742011-08-27 Juanma Barranquero <lekktu@gmail.com>
12675
12676 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
12677
5fc295a4 126782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 12679
70c60eb2 12680 Integer and memory overflow issues (Bug#9196).
726e0ab1 12681
d31850da
PE
12682 * doc.c (get_doc_string): Rework so that
12683 get_doc_string_buffer_size is the actual buffer size, rather than
12684 being 1 less than the actual buffer size; this makes xpalloc more
12685 convenient.
12686
a69fbedb
PE
12687 * image.c (x_allocate_bitmap_record, cache_image):
12688 * xselect.c (Fx_register_dnd_atom):
12689 Simplify previous changes by using xpalloc.
12690
fe5c5d37
PE
12691 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
12692 since either will do and ptrdiff_t is convenient with xpalloc.
12693
0065d054
PE
12694 * charset.c (charset_table_size)
12695 (struct charset_sort_data.priority): Now ptrdiff_t.
12696 (charset_compare): Don't overflow if priorities differ greatly.
12697 (Fsort_charsets): Don't assume list length fits in int.
12698 Check for size-calculation overflow when allocating sort data.
12699 (syms_of_charset): Allocate an initial charset table that is
12700 just under 64 KiB, to avoid problems with glibc malloc and mmap.
12701
12702 * cmds.c (internal_self_insert): Check for size-calculation overflow.
12703
12704 * composite.h (struct composition.glyph_len): Now int, not unsigned.
12705 The actual value is always <= INT_MAX, and leaving it unsigned made
12706 overflow checking harder.
12707
12708 * dispextern.h (struct glyph_matrix.rows_allocated)
12709 (struct face_cache.size): Now ptrdiff_t, for convenience in use
12710 with xpalloc. The values are still always <= INT_MAX.
12711
12712 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
12713
12714 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
12715 (SAFE_NALLOCA): New macro.
12716
12717 * region-cache.c (struct boundary.pos, find_cache_boundary)
12718 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
12719 (set_cache_region, invalidate_region_cache)
12720 (revalidate_region_cache, know_region_cache, region_cache_forward)
12721 (region_cache_backward, pp_cache):
12722 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
12723 so that ptrdiff_t * can be passed to xpalloc.
12724 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
12725 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
12726 (pp_cache): Don't assume cache_len fits in int.
12727 * region-cache.h: Adjust extern decls to match.
12728
12729 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
12730 EMACS_INT, since either will do, for xpalloc.
12731
12732 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
12733 (xnmalloc, xnrealloc, xpalloc): New functions.
12734
726e0ab1
PE
12735 * bidi.c (bidi_shelve_header_size): New constant.
12736 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
12737 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
12738
51f30bc5 12739 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
12740 * buffer.c (overlays_at, overlays_in, record_overlay_string)
12741 (overlay_strings):
12742 Don't update size of array until after memory allocation succeeds,
12743 because xmalloc/xrealloc may not return.
0065d054
PE
12744 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
12745 now that we have proper integer overflow checking.
12746 (record_overlay_string, overlay_strings): Catch overflows when
12747 calculating size of overlay_str_buf.
726e0ab1 12748
0065d054
PE
12749 * callproc.c (Fcall_process): Check for size overflow when
12750 calculating size of args2.
12751 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
12752 Normally we prefer signed values, but sticking with ptrdiff_t would
12753 require adding more-complicated checks.
726e0ab1
PE
12754
12755 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
12756 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
12757 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 12758 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
12759
12760 * character.c (Fstring): Check for size-calculation overflow.
12761
12762 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
12763 unnecessary integer overflow. Check for size overflow.
12764 (encode_coding_object): Don't update size until xmalloc succeeds.
12765
12766 * composite.c (get_composition_id): Check for overflow in glyph
12767 length calculations.
12768
12769 Integer and memory overflow fixes for display code.
12770 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
12771 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
12772 (scrolling_window): Check for overflow in size calculations.
12773 (line_draw_cost, realloc_glyph_pool, add_row_entry):
12774 Don't assume glyph table len fits in int.
12775 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
12776 (row_table_size): Now ptrdiff_t, not int.
12777 (scrolling_window): Avoid overflow in size calculations.
12778 Don't update size until allocation succeeds.
12779 * fns.c (concat): Check for overflow in size calculations.
12780 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
12781 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
12782 (NEXT_ALMOST_PRIME_LIMIT): New constant.
12783
12784 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
12785 (get_doc_string): Check for size calculation overflow.
12786 Don't update size until allocation succeeds.
12787 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
12788 EMACS_INT, where ptrdiff_t will do.
12789 (Fsubstitute_command_keys): Check for string overflow.
12790
12791 * editfns.c (set_time_zone_rule): Don't assume environment length
12792 fits in int.
12793 (message_length): Now ptrdiff_t, not int.
12794 (Fmessage_box): Don't update size until allocation succeeds.
12795 Don't assume message length fits in int.
12796 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
12797
0065d054
PE
12798 * emacs.c (main): Do not reallocate argv, since there is a null at
12799 the end that can be overwritten, and this way there's no need to
12800 worry about size-calculation overflow.
12801 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
12802
12803 * eval.c (init_eval_once, grow_specpdl): Don't update size until
12804 alloc succeeds.
12805 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
12806
12807 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
12808 (x_set_scroll_bar_width, x_figure_window_size):
12809 Check for integer overflow.
12810 (x_set_alpha): Do not assume XINT fits in int.
12811
12812 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
12813 This is for the members text_lines, text_cols, total_lines, total_cols,
12814 where the system imposes an 'int' limit.
12815
12816 * fringe.c (Fdefine_fringe_bitmap):
12817 Don't update size until alloc works.
12818
12819 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
12820 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
12821
12822 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
12823 Check for size-calculation overflow.
12824 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
12825 do, as we prefer signed integers.
12826 (id_to_widget.max_size, id_to_widget.used)
12827 (xg_store_widget_in_map, xg_remove_widget_from_map)
12828 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
12829 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
12830 Use and return ptrdiff_t, not int.
12831 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
12832 * gtkutil.h: Change prototypes to match the above.
12833
12834 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
12835 are duplicate now that they've been promoted to lisp.h.
12836 (x_allocate_bitmap_record, x_alloc_image_color)
12837 (make_image_cache, cache_image, xpm_load):
12838 Don't update size until alloc is done.
12839 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
12840 (x_detect_edges):
3256efce 12841 Check for size calculation overflow.
726e0ab1
PE
12842 (ct_colors_allocated_max): New constant.
12843 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
12844 overflow.
3256efce 12845
726e0ab1
PE
12846 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
12847 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
12848 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
12849 Use ptrdiff_t, not int, to count maps.
12850 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
12851 calculations. Don't update size until allocation succeeds.
12852 Redo calculations to avoid overflow.
726e0ab1
PE
12853 * keyboard.h: Change prototypes to match the above.
12854
12855 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
12856 to count maps.
12857 (current_minor_maps): Check for size calculation overflow.
12858 * keymap.h: Change prototypes to match the above.
12859
12860 * lread.c (read1, init_obarray): Don't update size until alloc done.
12861
12862 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
12863 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
12864
726e0ab1
PE
12865 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
12866 Now ptrdiff_t, not int.
12867 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
12868 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
12869
12870 * process.c (Fnetwork_interface_list): Check for overflow
12871 in size calculation.
12872
12873 * region-cache.c (move_cache_gap): Check for size calculation overflow.
12874
12875 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
12876 overflow. Don't bother calling xmalloc when xrealloc will do.
12877
12878 * search.c (Freplace_match): Check for size calculation overflow.
12879 (Fset_match_data): Don't assume list lengths fit in 'int'.
12880
12881 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
12882 for command line length. Do not attempt to address one before the
12883 beginning of an array, as that's not portable.
12884
12885 * term.c (max_frame_lines): Remove; unused.
12886 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
12887 not int.
12888 (encode_terminal_code, calculate_costs): Check for size
12889 calculation overflow.
12890 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
12891 table lengths and related sizes. Don't update size until alloc
12892 done. Redo calculations to avoid overflow.
12893 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
12894
12895 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
12896 subtracting pointers.
12897 (gobble_line): Check for overflow more carefully. Don't update size
12898 until alloc done.
12899
12900 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
12901 Don't update size until alloc done.
12902 Redo size calculations to avoid overflow.
12903 Check for size calculation overflow.
0065d054 12904 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
12905
12906 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
12907 Use ptrdiff_t, not int, for sizes.
12908 (store_mode_line_noprop_char): Don't update size until alloc done.
12909
0065d054
PE
12910 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
12911 Use ptrdiff_t, not int, for sizes.
12912 (Finternal_make_lisp_face, cache_face):
12913 Check for size calculation overflow.
12914 (cache_face): Treat size calculation overflows as if they were
12915 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
12916
12917 * xfns.c (x_encode_text, x_set_name_internal)
12918 (Fx_change_window_property): Use ptrdiff_t, not int, to count
12919 sizes, since they can exceed INT_MAX in size. Check for size
12920 calculation overflow.
12921
0065d054
PE
12922 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
12923 (xg_select): Check for size calculation overflow.
726e0ab1
PE
12924 Don't update size until alloc done.
12925
0065d054 12926 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 12927 as sprintf is limited to int lengths.
1d526e2f 12928
252c5ee1
PE
12929 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
12930 (X_LONG_MIN): New macros.
864d7ce7
PE
12931 Use them to make the following changes clearer.
12932 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
12933 This change doesn't affect the value now, but it may help remind
12934 future maintainers not to raise the value too much later.
12935 (SELECTION_QUANTUM): Remove, replacing with ...
12936 (selection_quantum): ... new function, which avoids overflow.
12937 All uses changed.
12938 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
12939 assumption that selection length fits in 'int'.
12940 (x_reply_selection_request, x_handle_selection_request)
12941 (x_get_window_property, receive_incremental_selection)
12942 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
12943 (lisp_data_to_selection_data, clean_local_selection_data):
12944 Use ptrdiff_t, not int, to record length of selection.
12945 (x_reply_selection_request, x_get_window_property)
12946 (receive_incremental_selection, x_property_data_to_lisp):
12947 Redo calculations to avoid overflow.
12948 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 12949 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
12950 something.
12951 (x_get_window_property, receive_incremental_selection)
12952 (lisp_data_to_selection_data, x_property_data_to_lisp):
12953 Check for size-calculation overflow.
12954 (x_get_window_property, receive_incremental_selection)
12955 (lisp_data_to_selection_data, Fx_register_dnd_atom):
12956 Don't store size until memory allocation succeeds.
12957 (x_get_window_property): Plug memory leak on memory exhaustion.
12958 Don't double-block input; malloc is safe here. Don't assume 2**34
12959 - 4 fits in unsigned long. Add an xassert to check
12960 XGetWindowProperty overflow. Be more careful about overflow
12961 calculations, and distinguish size from memory overflow better.
12962 (receive_incremental_selection): When tracing, don't assume
12963 unsigned int is less than INT_MAX.
12964 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
12965 harmful) conversions of unsigned short to int.
12966 (lisp_data_to_selection_data): Don't assume that integers
12967 in the range -65535 through -1 fit in an X unsigned short.
12968 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
12969 result parameters unless successful. Rely on cons_to_unsigned
12970 to report problems with elements; the old code wasn't right anyway.
12971 (x_check_property_data): Check for int overflow; we cannot use
12972 a wider type due to X limits.
12973 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
12974
726e0ab1 12975 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 12976
0065d054
PE
12977 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
12978 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
12979 (x_color_cells): Don't store size until memory allocation succeeds.
12980 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 12981 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
12982 (x_term_init): Don't assume length fits in int (sprintf is limited
12983 to int size).
bc18e09d 12984
ebfa62c0
PE
12985 Use ptrdiff_t for composition IDs.
12986 * character.c (lisp_string_width):
12987 * composite.c (composition_table_size, n_compositions)
12988 (get_composition_id, composition_gstring_from_id):
12989 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
12990 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
12991 * window.c (Frecenter):
12992 Use ptrdiff_t, not int, for composition IDs.
12993 * composite.c (get_composition_id): Check for integer overflow.
12994 * composite.h: Adjust prototypes to match the above changes.
12995
d3411f89
PE
12996 Use ptrdiff_t for hash table indexes.
12997 * category.c (hash_get_category_set):
12998 * ccl.c (ccl_driver):
12999 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
13000 * coding.c (coding_system_charset_list, detect_coding_system):
13001 * coding.h (struct coding_system.id):
13002 * composite.c (get_composition_id, gstring_lookup_cache):
13003 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
13004 * image.c (xpm_get_color_table_h):
13005 * lisp.h (hash_lookup, hash_put):
13006 * minibuf.c (Ftest_completion):
13007 Use ptrdiff_t for hash table indexes, not int (which is too
13008 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
13009 32-bit --with-wide-int hosts).
13010
e097a6fa
PE
13011 * charset.c (Fdefine_charset_internal): Check for integer overflow.
13012 Add a FIXME comment about memory leaks.
13013 (syms_of_charset): Don't assume xmalloc returns.
13014
5637687f
PE
13015 Don't assume that stated character widths fit in int.
13016 * character.c (Fchar_width, c_string_width, lisp_string_width):
13017 * character.h (CHAR_WIDTH):
13018 * indent.c (MULTIBYTE_BYTES_WIDTH):
13019 Use sanitize_char_width to avoid undefined and/or bad behavior
13020 with outlandish widths.
a66cfb1c 13021 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
13022 now that we have two such functions. All uses changed.
13023 (sanitize_char_width): New inline function.
13024
a2271ba2
PE
13025 Don't assume that tab-width fits in int.
13026 * character.h (sanitize_width): New inline function.
13027 (SANE_TAB_WIDTH): New macro.
13028 (ASCII_CHAR_WIDTH): Use it.
13029 * indent.c (sane_tab_width): Remove. All uses replaced by
13030 SANE_TAB_WIDTH (current_buffer).
13031 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
13032
18c52557
PE
13033 * fileio.c: Integer overflow issues with file modes.
13034 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
13035
caeeedc1
PE
13036 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
13037 Remove unreachable code.
13038 (read_hex, load_charset_map_from_file): Check for integer overflow.
13039
6df6ae42 13040 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
13041 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
13042 (x_send_scroll_bar_event): Likewise. Check that the size does not
13043 exceed limits imposed by XClientMessageEvent, as well as the usual
13044 ptrdiff_t and size_t limits.
13045
b13995db
PE
13046 * keyboard.c: Overflow, signedness and related fixes.
13047 (make_lispy_movement): Use same integer type in forward decl
13048 that is used in the definition.
13049 (read_key_sequence, keyremap_step):
13050 Change bufsize argument back to int, undoing my 2011-03-30 change.
13051 We prefer signed types, and int is wide enough here.
13052 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
13053 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
13054 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
13055 length, not size_t. Use ptrdiff_t for index, not int.
13056 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
13057 possibility of integer overflow.
13058
13464394
PE
13059 Overflow, signedness and related fixes for images.
13060
13061 * dispextern.h (struct it.stack[0].u.image.image_id)
13062 (struct_it.image_id, struct image.id, struct image_cache.size)
13063 (struct image_cache.used, struct image_cache.ref_count):
13064 * gtkutil.c (update_frame_tool_bar):
13065 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
13066 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
13067 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
13068 * nsmenu.m (update_frame_tool_bar):
13069 * xdisp.c (calc_pixel_width_or_height):
13070 * xfns.c (image_cache_refcount):
13071 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
13072 on typical 64-bit hosts.
13073
13074 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
13075 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
13076 Omit unnecessary casts to int.
13077 (parse_image_spec): Check that integers fall into 'int' range
13078 when the callers expect that.
13079 (image_ascent): Redo ascent calculation to avoid int overflow.
13080 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
13081 (lookup_image): Remove unnecessary tests.
13082 (xbm_image_p): Locals are now of int, not EMACS_INT,
13083 since parse_image_check makes sure they fit into int.
13084 (png_load, gif_load, svg_load_image):
13085 Prefer int to unsigned where either will do.
13086 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
13087 old tiff_error_handler and tiff_warning_handler.
13088 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
13089 stack buffer overflows. It uses only the features of vsnprintf
13090 that are common to both POSIX and native Microsoft.
13091 (tiff_error_handler, tiff_warning_handler): Use it.
13092 (tiff_load, gif_load, imagemagick_load_image):
13093 Don't assume :index value fits in 'int'.
13094 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
13095 (imagemagick_load_image): Check that crop parameters fit into
13096 the integer types that MagickCropImage accepts. Don't assume
13097 Vimagemagick_render_type has a nonnegative value. Don't assume
13098 size_t fits in 'long'.
13099 (gs_load): Use printmax_t to print the widest integers possible.
13100 Check for integer overflow when computing image height and width.
13101
c11821d4
EZ
131022011-08-26 Eli Zaretskii <eliz@gnu.org>
13103
13104 * xdisp.c (redisplay_window): Don't force window start if point
13105 will be invisible in the resulting window. (Bug#9324)
13106
0c95fcf7
EZ
131072011-08-25 Eli Zaretskii <eliz@gnu.org>
13108
13109 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
13110 the display spec is of the form `(space ...)'.
13111 (handle_display_spec): Return the value returned by
13112 handle_single_display_spec, not just 1 or zero.
13113 (handle_single_display_spec): If the display spec is of the form
13114 `(space ...)', and specifies display in the text area, return 2
13115 rather than 1.
fee65a97 13116 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
13117 accurately, and prefer exact match for point under bidi.
13118 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
13119
13120 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
13121 into disp_prop; all users changed.
13122
13123 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
13124 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
13125 for the text covered by the display property.
13126
e4ed06f1
CY
131272011-08-25 Chong Yidong <cyd@stupidchicken.com>
13128
13129 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
13130 Change return value to nil.
13131 (Frecord_buffer): Delete unused function.
13132
f67cdd7f
EZ
131332011-08-24 Eli Zaretskii <eliz@gnu.org>
13134
5980d4c6
EZ
13135 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
13136 buffers, return left-to-right.
8610fe8b
EZ
13137 (set_cursor_from_row): Consider candidate row a win if its glyph
13138 represents a newline and point is on that newline. Fixes cursor
13139 positioning on the newline at EOL of R2L text within L2R
13140 paragraph, and vice versa.
13141 (try_cursor_movement): Check continued rows, in addition to
13142 continuation rows. Fixes unwarranted scroll when point enters a
13143 continued line of R2L text within an L2R paragraph, or vice versa.
13144 (cursor_row_p): Consider the case of point being equal to
13145 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
13146 from the end of a short line to the beginning of a continued line
13147 of R2L text within L2R paragraph.
13148 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
13149 composed characters.
5980d4c6 13150
f67cdd7f
EZ
13151 * bidi.c (bidi_check_type): Use xassert.
13152 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
13153 members.
13154
bca633fb
EZ
131552011-08-23 Eli Zaretskii <eliz@gnu.org>
13156
13157 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
13158 a character.
13159
4a5885a7
CY
131602011-08-23 Chong Yidong <cyd@stupidchicken.com>
13161
13162 * nsfont.m (ns_otf_to_script): Fix typo.
13163
0902a04e
KH
131642011-08-22 Kenichi Handa <handa@m17n.org>
13165
13166 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
13167 extra slot even if the purpose is char-code-property-table.
13168
1a2e6670
EZ
131692011-08-23 Eli Zaretskii <eliz@gnu.org>
13170
8ddde651
EZ
13171 * xdisp.c (redisplay_window): When computing centering_position,
13172 account for the height of the header line. (Bug#8874)
13173
425cc014
EZ
13174 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
13175 instead of CHAR_TO_BYTE. Fixes a crash when a completion
13176 candidate is selected by the mouse, and that candidate has a
13177 composed character under the mouse.
13178
1a2e6670
EZ
13179 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
13180 coordinates reported by pos-visible-in-window-p for a composed
13181 character in column zero.
13182
8b76d6f8
SM
131832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
13184
13185 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
13186
dac347dd
EZ
131872011-08-22 Eli Zaretskii <eliz@gnu.org>
13188
13189 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
13190 consider it a hit if to_charpos is anywhere in the range of the
13191 composed buffer positions.
13192
e013fb34
CY
131932011-08-22 Chong Yidong <cyd@stupidchicken.com>
13194
13195 * image.c (gif_load): Don't assume that each subimage has the same
13196 dimensions as the base image. Handle disposal method that is
13197 "undefined" by the gif spec (Bug#9335).
13198
bd1ba3e8
CY
131992011-08-20 Chong Yidong <cyd@stupidchicken.com>
13200
13201 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 13202 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 13203
54a1215b
EZ
132042011-08-19 Eli Zaretskii <eliz@gnu.org>
13205
823564e5
EZ
13206 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
13207 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
13208 from an Org mode buffer to a Speedbar frame.
13209
54a1215b
EZ
13210 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
13211 a composition, take its buffer position from IT->cmp_it.charpos.
13212 Fixes cursor positioning at the beginning of a line that begins
13213 with a composed character.
13214
9778ebcc
EZ
132152011-08-18 Eli Zaretskii <eliz@gnu.org>
13216
0be6ee06
EZ
13217 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
13218 character bidirectional type, use STRONG_L instead. Fixes crashes
13219 in a buffer produced by `describe-categories'.
13220
9778ebcc
EZ
13221 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
13222 members before the level stack, so they would be saved and
13223 restored when copying iterator state. Fixes incorrect reordering
13224 around TABs covered by display properties.
13225
156bffbe
AS
132262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
13227
6b02f655 13228 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 13229
72ad093b
CY
132302011-08-17 Chong Yidong <cyd@stupidchicken.com>
13231
13232 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
13233 (internal_condition_case_2, internal_condition_case_n):
13234 Remove unnecessary aborts (Bug#9081).
72ad093b 13235
35774242
EZ
132362011-08-17 Eli Zaretskii <eliz@gnu.org>
13237
13238 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
13239 has no `load' handler, try opening the file locally. (Bug#9311)
13240
db76dd85
KB
132412011-08-16 Ken Brown <kbrown@cornell.edu>
13242
13243 * gmalloc.c: Expand comment.
13244
b215eee5
EZ
132452011-08-16 Eli Zaretskii <eliz@gnu.org>
13246
13247 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
13248 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
13249
a4579d33
KB
132502011-08-16 Ken Brown <kbrown@cornell.edu>
13251
13252 Fix memory allocation problems in Cygwin build (Bug#9273).
13253
13254 * unexcw.c ( __malloc_initialized): Declare external variable.
13255 (fixup_executable): Force the dumped emacs to reinitialize malloc.
13256
8b76d6f8
SM
13257 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
13258 New variables.
a4579d33
KB
13259 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
13260 dumped emacs.
13261 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
13262 in the static heap.
13263 [CYGWIN] (special_realloc): New function.
13264 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
13265 requests to realloc storage in the static heap.
13266
3ebec551
PE
132672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
13268
13269 * bidi.c (bidi_initialize): Remove unused local.
13270
9fd8be00
EZ
132712011-08-15 Eli Zaretskii <eliz@gnu.org>
13272
6b02f655
SM
13273 * bidimirror.h:
13274 * biditype.h: Remove file.
13275 * makefile.w32-in ($(BLD)/bidi.$(O)):
13276 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
13277
13278 * dispextern.h: Fix a typo in the comment to bidi_type_t.
13279
13280 * chartab.c: Improve commentary for the uniprop_table API.
13281
32413314
EZ
13282 * bidi.c (bidi_paragraph_init): Support zero value of
13283 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
13284 (bidi_initialize): Use uniprop_table instead of including
13285 biditype.h and bidimirror.h.
32413314 13286
9fd8be00
EZ
13287 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
13288 coordinates of the iterator when restoring from ppos_it.
13289 (Bug#9296)
13290
5cf2b69b
KH
132912011-08-14 Kenichi Handa <handa@m17n.org>
13292
13293 * process.c (create_process): Call setup_process_coding_systems
72ad093b 13294 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 13295
daf17d00
EZ
132962011-08-14 Eli Zaretskii <eliz@gnu.org>
13297
13298 * xdisp.c (move_it_in_display_line_to): Don't invoke
13299 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
13300 ppos_it. Fixes vertical cursor motion when line beginning is
13301 covered by an image. (Bug#9296)
13302
08e3161a
JD
133032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
13304
13305 * nsterm.h (ns_run_ascript): Declare.
13306 (NSAPP_DATA2_RUNASSCRIPT): Define.
13307
13308 * nsfns.m (as_script, as_result, as_status): New static variables.
13309 (ns_run_ascript): New function.
5e617bc2 13310 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
13311 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
13312 the event loop. Get status from as_status (Bug#7276).
13313
13314 * nsterm.m (sendEvent): If event is NSApplicationDefined and
13315 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
13316 the event loop (Bug#7276).
13317
a3720aa2
AS
133182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
13319
13320 * gnutls.c (QCgnutls_bootprop_priority)
13321 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
13322 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
13323 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
13324 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
13325 (QCgnutls_bootprop_verify_hostname_error)
13326 (QCgnutls_bootprop_callbacks_verify): Rename from
13327 Qgnutls_bootprop_..., all uses changed.
13328
13329 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
13330 uses changed.
13331
0a0d27fb
PE
133322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
13333
19d5c50c
PE
13334 * xfaces.c (Qframe_set_background_mode): Now static.
13335 * dispextern.h (Qframe_set_background_mode): Remove decl.
13336
0a0d27fb
PE
13337 * process.c (Fnetwork_interface_info): Declare local only if needed.
13338
377538cb
JD
133392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
13340
13341 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
13342 (Fnetwork_interface_list): Allocate in increments of bytes instead
13343 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
13344 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
13345 sockaddr.
13346 (struct ifflag_def): notrailers is smart on OSX.
13347 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
13348 Get hardware address with getifaddrs if available.
13349
08fff70c
EZ
133502011-08-12 Eli Zaretskii <eliz@gnu.org>
13351
13352 * xdisp.c (iterate_out_of_display_property): xassert that
13353 IT->position is set to within IT->object's boundaries. Break from
13354 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
13355 when IT->position is set up wrongly due to some bug.
13356 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
13357 (push_display_prop): Allow GET_FROM_STRING as IT->method on
13358 entry. Force push_it to save on the stack the current
13359 buffer/string position, to be restored by pop_it. Fix flags in
13360 the iterator structure wrt the object coming from a display
13361 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
13362 properties. (Bug#9284)
13363
7be1c708 133642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 13365
7be1c708
CY
13366 * fontset.c (fontset_get_font_group): Add proper type checks.
13367 (Bug#9172)
aac0c6e3 13368
7be1c708 133692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 13370
7be1c708
CY
13371 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
13372 and LC_VERSION_MIN_MACOSX.
13373 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
13374 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 13375
97bb72a6
EZ
133762011-08-08 Eli Zaretskii <eliz@gnu.org>
13377
13378 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
13379 no-display-properties-and-no-overlays under bidi display.
13380 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 13381 properties and overlays.
97bb72a6 13382
d5617611
CY
133832011-08-08 Chong Yidong <cyd@stupidchicken.com>
13384
37e11a63
CY
13385 * editfns.c (Fset_time_zone_rule): Document relationship with the
13386 setenv function.
13387
d5617611
CY
13388 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
13389 the font entity extracted from the cache (Bug#8109).
13390
58872834
CY
133912011-08-07 Chong Yidong <cyd@stupidchicken.com>
13392
13393 * composite.c (autocmp_chars): Don't reset point. That is done by
13394 restore_point_unwind (Bug#5984).
13395
75bfc667
JL
133962011-08-07 Juri Linkov <juri@jurta.org>
13397
13398 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
13399 to show the arg `TIME' instead of `TIMEVAL'.
13400
d1410150
EZ
134012011-08-06 Eli Zaretskii <eliz@gnu.org>
13402
13403 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
13404 display property strides EOL and includes a newline, as in
13405 longlines-mode. (Bug#9254)
75b771e4
EZ
13406 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
13407 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
13408
13409 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
13410 is non-zero, even if the data buffer is NULL. Fixes a crash in
13411 vertical-motion with longlines-mode. (Bug#9254)
13412
35928349
EZ
134132011-08-05 Eli Zaretskii <eliz@gnu.org>
13414
ec7cc85b
EZ
13415 * bidi.c <bidi_cache_total_alloc>: Now static.
13416 (bidi_initialize): Initialize bidi_cache_total_alloc.
13417
8b76d6f8 13418 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
13419 cache. (Bug#9221)
13420
13421 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
13422 amount allocated this far in `bidi_cache_total_alloc'.
13423 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
13424 non-zero, only free the data buffer without restoring the cache
13425 contents. All callers changed.
13426
13427 * dispextern.h (bidi_unshelve_cache): Update prototype.
13428
13429 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
13430 (move_it_in_display_line, move_it_to)
13431 (move_it_vertically_backward, move_it_by_lines): Replace the call
13432 to xfree to an equivalent call to bidi_unshelve_cache.
13433 (move_it_in_display_line_to): Fix logic of returning
412b6358 13434 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 13435
e2e2423b
EZ
134362011-08-05 Eli Zaretskii <eliz@gnu.org>
13437
13438 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
13439 came from a string character with a `cursor' property. (Bug#9229)
13440
ae9e757a
JD
134412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
13442
13443 * Makefile.in (LIB_PTHREAD): New variable.
13444 (LIBES): Add LIB_PTHREAD (Bug#9216).
13445
13446 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
13447 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
13448
213bd7f2
AS
134492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
13450
6b02f655 13451 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 13452
99aaf75f
JD
134532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
13454
13455 * xterm.c (x_find_topmost_parent): New function.
13456 (x_set_frame_alpha): Find topmost parent window with
13457 x_find_topmost_parent and set the property there also (bug#9181).
13458 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
13459
c74e9d86
PE
134602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
13461
13462 * callproc.c (Fcall_process): Avoid vfork clobbering
13463 the local vars buffer, coding_systems, current_dir.
13464
640c8776
SM
134652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
13466
13467 * keymap.c (Fmake_composed_keymap): Move to subr.el.
13468
f26d0e4c
PE
134692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
13470
8a10d76c
PE
13471 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
13472 so that it is not optimized away.
13473
f26d0e4c
PE
13474 * xdisp.c (compute_display_string_pos): Remove unused local.
13475
55439c61
EZ
134762011-08-02 Eli Zaretskii <eliz@gnu.org>
13477
13478 Fix slow cursor motion and scrolling in large buffers with
13479 selective display, like Org Mode buffers. (Bug#9218)
13480
13481 * dispextern.h (struct bidi_it): New member disp_prop_p.
13482
13483 * xdisp.c: Remove one-slot cache of display string positions.
13484 (compute_display_string_pos): Accept an additional argument
5e617bc2 13485 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
13486 for a display string or property. If found, set DISP_PROP_P
13487 non-zero.
13488
13489 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
13490 DISP_PROP_P, and pass it to compute_display_string_pos.
13491 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
13492 non-zero. All callers of bidi_fetch_char changed.
13493
fb33fa43
SM
134942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
13495
13496 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
13497
b099e063
DM
134982010-12-03 Don March <don@ohspite.net>
13499
13500 * keymap.c (Fdefine_key): Fix non-prefix key error message when
13501 last character M-[char] is translated to ESC [char] (bug#7541).
13502
5cc7f7af
KH
135032011-08-02 Kenichi Handa <handa@m17n.org>
13504
d0fffa3f 13505 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
13506
13507 * chartab.c (uniprop_table): Make it non-static.
13508
525d5e6e
EZ
135092011-08-01 Eli Zaretskii <eliz@gnu.org>
13510
13511 * xdisp.c (forward_to_next_line_start): Accept additional argument
13512 BIDI_IT_PREV, and store into it the state of the bidi iterator had
13513 on the newline.
13514 (reseat_at_next_visible_line_start): Use the bidi iterator state
13515 returned by forward_to_next_line_start to restore the state of
13516 it->bidi_it after backing up to previous newline. (Bug#9212)
13517
31011111
AS
135182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
13519
13520 * regex.c (re_comp): Protoize.
13521 (re_exec): Fix return type.
13522 (regexec): Fix type of `ret'. (Bug#9203)
13523
476371c4
PE
135242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
13525
e5d76069
PE
13526 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
13527 This is needed if max-image-size is a floating-point number.
13528
9a79b20c
AS
135292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
13530
13531 * print.c (print_object): Print empty symbol as ##.
13532
13533 * lread.c (read1): Read ## as empty symbol.
13534
d8c2fa78
AA
135352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
13536
13537 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
13538 setting frame foreground color (Bug#9175).
13539 (x_set_background_color): Likewise.
13540
ffe57a7a
AA
13541 * nsmenu.m (-setText): Size tooltip dimensions precisely to
13542 contents (Bug#9176).
13543 (EmacsTooltip -init): Remove bezels and add shadows to
13544 tooltip windows.
13545
bf3492a5
AA
13546 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
13547 or scroll bar (Bug#8470).
13548
d55e9c53
AA
13549 * nsfont.m (nsfont_open): Remove assignment to voffset and
13550 unnecessary vars hshink, expand, hd, full_height, min_height.
13551 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
13552
13553 * nsterm.h (nsfont_info): Remove voffset field.
13554
d8c2fa78 135552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
13556
13557 Implement strike-through and overline on NextStep (Bug#8863).
13558
13559 * nsfont.m (nsfont_open): Use underline position provided by font,
13560 instead of hard-coded value of 2.
13561 (nsfont_draw): Call ns_draw_text_decoration instead.
13562
13563 * nsterm.h: Add declaration for ns_draw_text_decoration.
13564
13565 * nsterm.m (ns_draw_text_decoration): New function for drawing
13566 underline, overline, and strike-through.
13567 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
13568 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 13569 accommodate underlining, etc.
4843aac3 13570
4cc60b9b
EZ
135712011-07-28 Eli Zaretskii <eliz@gnu.org>
13572
bc7ece87
EZ
13573 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
13574 default.
4cc60b9b 13575
476371c4
PE
135762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
13577
66606eea
PE
13578 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
13579 Without this fix, if a signal arrives just after memory fills up,
13580 'malloc' might be invoked reentrantly.
13581
476371c4
PE
13582 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
13583 In other words, assume that every image size is allowed, on non-X
13584 hosts. This assumption is probably wrong, but it lets Emacs compile.
13585
f3fcc40d
AS
135862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
13587
13588 * regex.c (re_iswctype): Convert return values to boolean.
13589
350c992f
EZ
135902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
13591
13592 * xdisp.c (compute_display_string_pos): Don't use cached display
13593 string position if the buffer had its restriction changed.
13594 (Bug#9184)
13595
5266b4bb
PE
135962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
13597
13598 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13599
2573a837 136002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 13601
41f55ccd 13602 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 13603
39e378da
PE
13604 * bidi.c: Integer size and overflow fixes.
13605 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
13606 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
13607 (bidi_cache_find_level_change, bidi_cache_ensure_space)
13608 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
13609 (bidi_find_other_level_edge):
13610 Use ptrdiff_t instead of EMACS_INT where either will do.
13611 This works better on 32-bit hosts configured --with-wide-int.
13612 (bidi_cache_ensure_space): Check for size-calculation overflow.
13613 Use % rather than repeated addition, for better worst-case speed.
13614 Don't set bidi_cache_size until after xrealloc returns, because it
13615 might not return.
13616 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
13617 (bidi_cache_ensure_space): Also check that the bidi cache size
13618 does not exceed that of the largest Lisp string or buffer. See Eli
13619 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 13620
5e927815
PE
13621 * alloc.c (__malloc_size_t): Remove.
13622 All uses replaced by size_t. See Andreas Schwab's note
13623 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
13624
ca4aa935
PE
13625 * image.c: Improve checking for integer overflow.
13626 (check_image_size): Assume that f is nonnull, since
13627 it is always nonnull in practice. This is one less thing to
13628 worry about when checking for integer overflow later.
13629 (x_check_image_size): New function, which checks for integer
13630 overflow issues inside X.
13631 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
13632 This removes the need for a memory_full check.
13633 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
13634 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
13635 (xbm_read_bitmap_data): Change locals back to 'int', since
13636 their values must fit in 'int'.
13637 (xpm_load_image, png_load, tiff_load):
13638 Invoke x_create_x_image_and_pixmap earlier,
13639 to avoid much needless work if the image is too large.
13640 (tiff_load): Treat overly large images as if
13641 x_create_x_image_and_pixmap failed, not as malloc failures.
13642 (gs_load): Use x_check_image_size.
13643
5f8f9cc2
PE
13644 * gtkutil.c: Omit integer casts.
13645 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
13646 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
13647
5adf60bc
PE
13648 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
13649
c8907a93
PE
13650 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
13651 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
13652 would wrongly return t on a 64-bit host.
13653
e3c25c68
PE
13654 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
13655 The plain *_OVERFLOW macros run afoul of GCC bug 49705
13656 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
13657 and therefore cause GCC to emit a bogus diagnostic in some cases.
13658
3f791afe
PE
13659 * image.c: Integer signedness and overflow and related fixes.
13660 This is not an exhaustive set of fixes, but it's time to
13661 record what I've got.
13662 (lookup_pixel_color, check_image_size): Remove redundant decls.
13663 (check_image_size): Don't assume that arbitrary EMACS_INT values
13664 fit in 'int', or that arbitrary 'double' values fit in 'int'.
13665 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
13666 (tiff_load, imagemagick_load_image):
13667 Check for overflow in size calculations.
13668 (x_create_x_image_and_pixmap): Remove unnecessary test for
13669 xmalloc returning NULL; that can't happen.
13670 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
13671 (xpm_color_bucket): Use better integer hashing function.
13672 (xpm_cache_color): Don't possibly over-allocate memory.
13673 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
13674 (gif_memory_source):
13675 Use ptrdiff_t, not int or size_t, to record sizes.
13676 (png_load): Don't assume values greater than 2**31 fit in 'int'.
13677 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
13678 either works, as we prefer signed integers.
13679 (tiff_read_from_memory, tiff_write_from_memory):
13680 Return tsize_t, not size_t, since that's what the TIFF API wants.
13681 (tiff_read_from_memory): Don't fail simply because the read would
13682 go past EOF; instead, return a short read.
13683 (tiff_load): Omit no-longer-needed casts.
13684 (Fimagemagick_types): Don't assume size fits into 'int'.
13685
3cc5a532
PE
13686 Improve hashing quality when configured --with-wide-int.
13687 * fns.c (hash_string): New function, taken from sxhash_string.
13688 Do not discard information about ASCII character case; this
13689 discarding is no longer needed.
13690 (sxhash-string): Use it. Change sig to match it. Caller changed.
13691 * lisp.h: Declare it.
13692 * lread.c (hash_string): Remove, since we now use fns.c's version.
13693 The fns.c version returns a wider integer if --with-wide-int is
13694 specified, so this should help the quality of the hashing a bit.
13695
b312a492
PE
13696 * emacs.c: Integer overflow minor fix.
13697 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
13698 Define only if GNU_LINUX.
13699 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
13700
dfd153ae
PE
13701 * dispnew.c: Integer signedness and overflow fixes.
13702 Remove unnecessary forward decls, that were a maintenance hassle.
13703 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
13704 All uses changed.
13705 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
13706 (scrolling_window): Use ptrdiff_t, not int, for byte count.
13707 (prepare_desired_row, line_draw_cost):
13708 Use int, not unsigned, where either works.
13709 (save_current_matrix, restore_current_matrix):
13710 Use ptrdiff_t, not size_t, where either works.
13711 (init_display): Check for overflow more accurately, and without
13712 relying on undefined behavior.
13713
a81d11a3
PE
13714 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
13715 Remove, replacing with the new symbols in lisp.h. All uses changed.
13716 * fileio.c (make_temp_name):
13717 * filelock.c (lock_file_1, lock_file):
13718 * xdisp.c (message_dolog):
13719 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
13720 Use pMd etc. instead.
13721 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
13722 replacing the pWIDE etc. symbols removed from editfns.c.
13723
3300e6fd
PE
13724 * keyboard.h (num_input_events): Now uintmax_t.
13725 This is (very slightly) less likely to mess up due to wraparound.
13726 All uses changed.
13727
fd05c7e9
PE
13728 * buffer.c: Integer signedness fixes.
13729 (alloc_buffer_text, enlarge_buffer_text):
13730 Use ptrdiff_t rather than size_t when either will do, as we prefer
13731 signed integers.
13732
903fe15d
PE
13733 * alloc.c: Integer signedness and overflow fixes.
13734 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
13735 (__malloc_size_t): Default to size_t, not to int.
13736 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
13737 (Fgarbage_collect, mark_object_loop_halt, mark_object):
13738 Prefer ptrdiff_t to size_t when either would do, as we prefer
13739 signed integers.
13740 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
13741 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
13742 Now const. Initialize with values that are in range even if char
13743 is signed.
13744 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
13745 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
13746 These functions do the right thing with sizes > 2**32.
13747 (check_depth): Now ptrdiff_t, not int.
13748 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
13749 Adjust to new way of storing sizes. Check for size overflow bugs
13750 in rest of code.
13751 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
13752 slightly wrong anyway, as it missed one instance of
13753 XMALLOC_OVERRUN_CHECK_OVERHEAD.
13754 (refill_memory_reserve): Omit needless cast to size_t.
13755 (mark_object_loop_halt): Mark as externally visible.
13756
ac82cc6a
PE
13757 * xselect.c: Integer signedness and overflow fixes.
13758 (Fx_register_dnd_atom, x_handle_dnd_message):
13759 Use ptrdiff_t, not size_t, since we prefer signed.
13760 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
13761 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
13762 x_dnd_atoms_size and x_dnd_atoms_length.
13763
c2d1e36d
PE
13764 * doprnt.c: Prefer signed to unsigned when either works.
13765 * eval.c (verror):
13766 * doprnt.c (doprnt):
13767 * lisp.h (doprnt):
13768 * xdisp.c (vmessage):
13769 Use ptrdiff_t, not size_t, when using or implementing doprnt,
13770 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
13771 prefer signed arithmetic to avoid comparison confusion.
13772 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
13773 but is a bit tricky.
13774
0e926e56
PE
13775 Assume freestanding C89 headers, string.h, stdlib.h.
13776 * data.c, doprnt.c, floatfns.c, print.c:
13777 Include float.h unconditionally.
13778 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
13779 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
13780 * regex.c: Likewise for stddef.h, string.h.
13781 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
13782 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
13783 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
13784 (STDC_HEADERS): Remove obsolete defines.
13785 * sysdep.c: Include limits.h unconditionally.
13786
9cfdb3ec
PE
13787 Assume support for memcmp, memcpy, memmove, memset.
13788 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
13789 * regex.c (memcmp, memcpy):
13790 Remove; we assume C89 now.
13791
13792 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
13793 (__malloc_safe_bcopy): Remove; no longer needed.
13794
cf950e6b 13795 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
13796 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
13797 well either way, and we prefer signed to unsigned.
13798
dbf38e02
LMI
137992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
13800
13801 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
13802 closes the connection while we're reading (bug#9182).
13803
d6f0886c 138042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 13805
d6f0886c
JD
13806 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
13807 are specified (Bug#9168).
24e0f6b1 13808
2eb1f9e6
PE
138092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
13810
13811 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
13812 Found by GCC static checking and --with-wide-int on a 32-bit host.
13813
22381272 138142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
13815
13816 * xdisp.c (compute_display_string_pos): Fix logic of caching
13817 previous display string position. Initialize cached_prev_pos to
13818 -1. Fixes slow-down at the beginning of a buffer.
13819
f25e39b4
EZ
138202011-07-24 Eli Zaretskii <eliz@gnu.org>
13821
13822 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
13823 for attrs[LFACE_FONTSET_INDEX].
13824
04c4b52e
PE
138252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
13826
13827 * xml.c (parse_region): Remove unused local
13828 that was recently introduced.
13829
c1734fbd
EZ
138302011-07-23 Eli Zaretskii <eliz@gnu.org>
13831
be18c5a5
EZ
13832 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
13833 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
13834
c1734fbd
EZ
13835 * xdisp.c (move_it_in_display_line_to): Record the best matching
13836 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
13837 exit if none of the characters scanned was an exact match.
13838 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
13839 when exact match is impossible due to invisible text, and the
13840 lines are truncated.
13841
a258d627
JD
138422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
13843
13844 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
13845 for OSX >= 10.7.
13846
b6d5a689
EZ
138472011-07-22 Eli Zaretskii <eliz@gnu.org>
13848
0f74f785
EZ
13849 Fix a significant slow-down of cursor motion with C-n, C-p,
13850 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
13851 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 13852 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
13853 (next_element_from_buffer): Call compute_stop_pos_backwards to
13854 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
13855 base_level_stop.
13856 (reseat): Don't look for prev_stop, as that could mean a very long
13857 run.
13858 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
13859 <cached_disp_overlay_modiff>: Cache for last found display string
13860 position.
551918c1 13861 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
13862 about the same buffer in the same area of character positions, and
13863 the buffer wasn't changed since the time the display string
13864 position was cached.
551918c1 13865
b2d0c91a
EZ
138662011-07-22 Eli Zaretskii <eliz@gnu.org>
13867
13868 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
13869 is an integer, which is important for empty lines. (Bug#9149)
13870
043604ee
CY
138712011-07-22 Chong Yidong <cyd@stupidchicken.com>
13872
13873 * frame.c (Fmodify_frame_parameters): In tty case, update the
13874 default face if necessary (Bug#4238).
13875
da4adb04
CY
138762011-07-21 Chong Yidong <cyd@stupidchicken.com>
13877
13878 * editfns.c (Fstring_to_char): No need to explain what a character
13879 is in the docstring (Bug#6576).
13880
9abd0532
LMI
138812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
13882
13883 * xml.c (parse_region): Make sure we always return a tree.
13884
36881d16
HK
138852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
13886
13887 * xml.c (parse_region): If a document contains only comments,
13888 return that, too.
13889
1e98674d
LMI
138902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
13891
13892 * xml.c (make_dom): Return comments, too.
13893
590bd467
PE
138942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
13895
13896 Port to OpenBSD.
13897 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
13898 and the surrounding thread.
13899 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
13900 rather than fgets, and retry after EINTR. Otherwise, 'emacs
13901 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
13902 timer goes off.
13903 * s/openbsd.h (BROKEN_SIGIO): Define.
13904 * unexelf.c (unexec) [__OpenBSD__]:
13905 Don't update the .mdebug section of the Alpha COFF symbol table.
13906
f41628b2
LMI
139072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
13908
13909 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
13910 (bug#8460).
13911
b59b67c5
PE
139122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
13913
15e3a074
PE
13914 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
13915 This fixes some race conditions on the permissions of any newly
13916 created file.
13917
41bed37d
PE
13918 * alloc.c (valid_pointer_p): Use pipe, not open.
13919 This fixes some permissions issues when debugging.
13920
b59b67c5
PE
13921 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
13922 If fchown fails to set both uid and gid, try to set just gid,
13923 as that is sometimes allowed. Adjust the file's mode to eliminate
13924 setuid or setgid bits that are inappropriate if fchown fails.
13925
925a6be7
SM
139262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
13927
13928 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
13929 to compare Lisp_Objects.
13930 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
13931 global_gnutls_log_level, don't mistake it for a Lisp_Object.
13932 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
13933
52968808
AS
139342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
13935
0a6a104b
AS
13936 * lread.c (read_integer): Unread even EOF character.
13937 (read1): Likewise. Properly record start position of symbol.
13938
52968808
AS
13939 * lread.c (read1): Read `#:' as empty uninterned symbol if no
13940 symbol character follows.
13941
9e381cdd
PE
139422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
13943
13944 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
13945 This works around a problem with the previous change to Fcopy_file.
13946 Recent glibc declares fchown with __attribute__((warn_unused_result)),
13947 and without this change, GCC might complain about discarding
13948 fchown's return value.
13949
b5641435
JB
139502011-07-16 Juanma Barranquero <lekktu@gmail.com>
13951
13952 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
13953
a8031457
PE
139542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
13955
13956 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
13957
dd889327
LMI
139582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
13959
750c33f7
LMI
13960 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
13961 it's used from the C level.
13962
dd889327
LMI
13963 * process.c: Use the same condition for POLL_FOR_INPUT in both
13964 keyboard.c and process.c (bug#1858).
13965
87e86684
LM
139662011-07-09 Lawrence Mitchell <wence@gmx.li>
13967
13968 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
13969 (Fgnutls_boot): Use it.
13970
64348f40
AS
139712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
13972
13973 * doc.c (Fsubstitute_command_keys): Revert last change.
13974
1d698799
LMI
139752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
13976
f863868c
LMI
13977 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
13978 quotes the next character, and doesn't affect other longer
13979 sequences (bug#8935).
13980
1d698799
LMI
13981 * lread.c (syms_of_lread): Clarify that is isn't only
13982 `eval-buffer' and `eval-defun' that's affected by
13983 `lexical-binding' (bug#8460).
13984
aa4b6df6
EZ
139852011-07-15 Eli Zaretskii <eliz@gnu.org>
13986
13987 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 13988 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 13989
5d856da6
PE
139902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
13991
ad6042bb
PE
13992 Fix minor problems found by static checking.
13993 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
13994 (elsz): Now a signed constant, not a size_t var. We prefer signed
13995 types to unsigned, to avoid integer comparison confusion. Without
13996 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
13997 "cannot optimize loop, the loop counter may overflow", a symptom
13998 of the confusion.
f00bbb22 13999 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
14000 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
14001
6468f31c
LMI
140022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
14003
49080b10
LMI
14004 * search.c (Fre_search_backward): Mention `case-fold-search' in
14005 all the re_search_* functions (bug#8138).
14006
6468f31c
LMI
14007 * keyboard.c (Fopen_dribble_file): Document when the file is
14008 closed (bug#8056).
14009
c965adc5
EZ
140102011-07-14 Eli Zaretskii <eliz@gnu.org>
14011
df9733bf
EZ
14012 * bidi.c (bidi_dump_cached_states): Fix format of displaying
14013 bidi_cache_idx.
14014
0bb23927
EZ
14015 Support bidi reordering of display and overlay strings.
14016 * xdisp.c (compute_display_string_pos)
14017 (compute_display_string_end): Accept additional argument STRING.
14018 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
14019 (reseat_to_string): Initialize bidi_it->string.s and
14020 bidi_it->string.schars.
14021 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
14022 NULL (avoids a crash in bidi_paragraph_init).
14023 Initialize itb.string.lstring.
0bb23927
EZ
14024 (init_iterator): Call bidi_init_it only of a valid
14025 buffer position was specified. Initialize paragraph_embedding to
14026 L2R.
14027 (reseat_to_string): Initialize the bidi iterator.
14028 (display_string): If we need to ignore text properties of
14029 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
14030 original value of -1 will not work with bidi.)
14031 (compute_display_string_pos): First arg is now struct
14032 `text_pos *'; all callers changed. Support display properties on
14033 Lisp strings.
14034 (compute_display_string_end): Support display properties on Lisp
14035 strings.
14036 (init_iterator, reseat_1, reseat_to_string): Initialize the
14037 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
14038 when iterating on a string not from display properties).
640c8776
SM
14039 (compute_display_string_pos, compute_display_string_end):
14040 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
14041 arrow keys.
14042 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
14043 base_level_stop; instead, set base_level_stop to BEGV.
14044 Fixes crashes in vertical-motion.
0bb23927
EZ
14045 (next_element_from_buffer): Improve commentary for when
14046 the iterator is before prev_stop.
14047 (init_iterator): Initialize bidi_p from the default value of
14048 bidi-display-reordering, not from buffer-local value. Use the
14049 buffer-local value only if initializing for buffer iteration.
14050 (handle_invisible_prop): Support invisible properties on strings
14051 that are being bidi-reordered.
14052 (set_iterator_to_next): Support bidi reordering of C strings and
14053 Lisp strings.
14054 (next_element_from_string): Support bidi reordering of Lisp
14055 strings.
14056 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
14057 (display_string): Support display of R2L glyph rows.
14058 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
14059 (init_iterator): Don't initialize it->bidi_p for strings
14060 here.
14061 (reseat_to_string): Initialize it->bidi_p for strings here.
14062 (next_element_from_string, next_element_from_c_string)
14063 (next_element_from_buffer): Add xassert's for correspondence
14064 between IT's object being iterated and it->bidi_it.string
14065 structure.
14066 (face_before_or_after_it_pos): Support bidi iteration.
14067 (next_element_from_c_string): Handle the case of the first string
14068 character that is not the first one in the visual order.
14069 (get_visually_first_element): New function, refactored from common
14070 parts of next_element_from_buffer, next_element_from_string, and
14071 next_element_from_c_string.
14072 (tool_bar_lines_needed, redisplay_tool_bar)
14073 (display_menu_bar): Force left-to-right direction. Add a FIXME
14074 comment for making that be controlled by a user option.
14075 (push_it, pop_it): Save and restore the state of the
14076 bidi iterator. Save and restore the bidi_p flag.
14077 (pop_it): Iterate out of display property for string iteration as
14078 well.
14079 (iterate_out_of_display_property): Support iteration over strings.
14080 (handle_single_display_spec): Set up it->bidi_it for iteration
14081 over a display string, and call bidi_init_it.
14082 (handle_single_display_spec, next_overlay_string)
14083 (get_overlay_strings_1, push_display_prop): Set up the bidi
14084 iterator for displaying display or overlay strings.
14085 (forward_to_next_line_start): Don't use the shortcut if
14086 bidi-iterating.
14087 (back_to_previous_visible_line_start): If handle_display_prop
14088 pushed the iterator stack, restore the internal state of the bidi
14089 iterator by calling bidi_pop_it same number of times.
14090 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
14091 and we are bidi-iterating, don't decrement the iterator position;
14092 instead, set the first_elt flag in the bidi iterator, to produce
14093 the same effect.
14094 (reseat_1): Remove redundant setting of string_from_display_prop_p.
14095 (push_display_prop): xassert that we are iterating a buffer.
14096 (push_it, pop_it): Save and restore paragraph_embedding member.
14097 (handle_single_display_spec, next_overlay_string)
14098 (get_overlay_strings_1, reseat_1, reseat_to_string)
14099 (push_display_prop): Set up the `unibyte' member of bidi_it.string
14100 correctly. Don't assume unibyte strings are not bidi-reordered.
14101 (compute_display_string_pos)
14102 (compute_display_string_end): Fix handling the case of C string.
14103 (push_it, pop_it): Save and restore from_disp_prop_p.
14104 (handle_single_display_spec, push_display_prop): Set the
14105 from_disp_prop_p flag.
14106 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
14107 (pop_it): Call iterate_out_of_display_property only if we are
14108 popping after iteration over a string that came from a display
14109 property. Fix a typo in popping stretch info. Add an assertion
14110 for verifying that the iterator position is in sync with the bidi
14111 iterator.
14112 (handle_single_display_spec, get_overlay_strings_1)
14113 (push_display_prop): Fix initialization of paragraph direction for
14114 string when that of the parent object is not yet determined.
14115 (reseat_1): Call bidi_init_it to resync the bidi
14116 iterator with IT's position. (Bug#7616)
14117 (find_row_edges): If ROW->start.pos gives position
14118 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
14119 (handle_stop, back_to_previous_visible_line_start, reseat_1):
14120 Reset the from_disp_prop_p flag.
14121 (SAVE_IT, RESTORE_IT): New macros.
14122 (pos_visible_p, face_before_or_after_it_pos)
14123 (back_to_previous_visible_line_start)
14124 (move_it_in_display_line_to, move_it_in_display_line)
14125 (move_it_to, move_it_vertically_backward, move_it_by_lines)
14126 (try_scrolling, redisplay_window, display_line): Use them when
14127 saving a temporary copy of the iterator and restoring it back.
14128 (back_to_previous_visible_line_start, reseat_1)
14129 (init_iterator): Empty the bidi cache "stack".
14130 (move_it_in_display_line_to): If iterator ended up at
14131 EOL, but we never saw any buffer positions smaller than
14132 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
14133 motion in bidi-reordered lines.
14134 (move_it_in_display_line_to): Record prev_method and prev_pos
14135 immediately before the call to set_iterator_to_next. Fixes cursor
14136 motion in bidi-reordered lines with stretch glyphs and strings
14137 displayed in margins. (Bug#8133) (Bug#8867)
14138 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
14139 TO_CHARPOS.
640c8776
SM
14140 (pos_visible_p): Support positions in bidi-reordered lines.
14141 Save and restore bidi cache.
0bb23927
EZ
14142
14143 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
14144 (bidi_paragraph_info): Delete unused struct.
14145 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
14146 (bidi_cache_start): New variable.
14147 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
14148 to zero.
14149 (bidi_cache_fetch_state, bidi_cache_search)
14150 (bidi_cache_find_level_change, bidi_cache_iterator_state)
14151 (bidi_cache_find, bidi_peek_at_next_level)
14152 (bidi_level_of_next_char, bidi_find_other_level_edge)
14153 (bidi_move_to_visually_next): Compare cache index with
14154 bidi_cache_start rather than with zero.
14155 (bidi_fetch_char): Accept new argument STRING; all callers
14156 changed. Support iteration over a string. Support strings with
14157 display properties. Support unibyte strings. Fix the type of
14158 `len' according to what STRING_CHAR_AND_LENGTH expects.
14159 (bidi_paragraph_init, bidi_resolve_explicit_1)
14160 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
14161 (bidi_level_of_next_char, bidi_move_to_visually_next):
14162 Support iteration over a string.
0bb23927
EZ
14163 (bidi_set_sor_type, bidi_resolve_explicit_1)
14164 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
14165 can now be zero (for strings); special values 0 and -1 were
14166 changed to -1 and -2, respectively.
14167 (bidi_char_at_pos): New function.
14168 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
14169 Call it instead of FETCH_MULTIBYTE_CHAR.
14170 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
14171 initialized to valid values.
14172 (bidi_init_it): Don't initialize charpos and bytepos with invalid
14173 values.
14174 (bidi_level_of_next_char): Allow the sentinel "position" to pass
14175 the test for valid cached positions. Fix the logic for looking up
14176 the sentinel state in the cache. GCPRO the Lisp string we are
14177 iterating.
14178 (bidi_push_it, bidi_pop_it): New functions.
14179 (bidi_initialize): Initialize the bidi cache start stack pointer.
14180 (bidi_cache_ensure_space): New function, refactored from part of
14181 bidi_cache_iterator_state. Don't assume the required size is just
14182 one BIDI_CACHE_CHUNK away.
14183 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
14184 (bidi_count_bytes, bidi_char_at_pos): New functions.
14185 (bidi_cache_search): Don't assume bidi_cache_last_idx is
14186 always valid if bidi_cache_idx is valid.
14187 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
14188 is valid if it's going to be used.
14189 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
14190 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
14191 (bidi_cache_find_level_change, bidi_cache_ensure_space)
14192 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
14193 (bidi_find_other_level_edge, bidi_cache_start_stack):
14194 All variables related to cache indices are now EMACS_INT.
c965adc5 14195
0bb23927
EZ
14196 * dispextern.h (struct bidi_string_data): New structure.
14197 (struct bidi_it): New member `string'. Make flag members be 1-bit
14198 fields, and put them last in the struct.
640c8776
SM
14199 (compute_display_string_pos, compute_display_string_end):
14200 Update prototypes.
0bb23927
EZ
14201 (bidi_push_it, bidi_pop_it): Add prototypes.
14202 (struct iterator_stack_entry): New members bidi_p,
14203 paragraph_embedding, and from_disp_prop_p.
14204 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
14205 (bidi_shelve_cache, bidi_unshelve_cache):
14206 Declare prototypes.
0bb23927
EZ
14207
14208 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
14209 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
14210 and vector-like objects.
14211
14212 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
14213 cache around display iteration.
14214
14215 * window.c (Fwindow_end, window_scroll_pixel_based)
14216 (displayed_window_lines, Frecenter): Save and restore the bidi
14217 cache around display iteration.
14218
3bbd2265
LMI
142192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
14220
14221 * editfns.c (Fdelete_region): Clarify the use of the named
14222 parameters (bug#6788).
14223
adc47434
MR
142242011-07-14 Martin Rudalics <rudalics@gmx.at>
14225
14226 * indent.c (Fvertical_motion): Set and restore w->pointm when
14227 saving and restoring the window's buffer (Bug#9006).
14228
837c31f8
LMI
142292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
14230
14231 * editfns.c (Fstring_to_char): Clarify just what is returned
14232 (bug#6576). Text by Eli Zaretskii.
14233
ac389d0c
JB
142342011-07-13 Juanma Barranquero <lekktu@gmail.com>
14235
14236 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
14237
0be0ce47
EZ
142382011-07-13 Eli Zaretskii <eliz@gnu.org>
14239
14240 * buffer.c (mmap_find): Fix a typo.
14241
cd18e7e3
JB
142422011-07-13 Johan Bockgård <bojohan@gnu.org>
14243
14244 Fix execution of x selection hooks.
14245 * xselect.c (Qx_lost_selection_functions)
14246 (Qx_sent_selection_functions): New vars.
14247 (syms_of_xselect): DEFSYM them.
14248 (x_handle_selection_request): Pass Qx_sent_selection_functions
14249 rather than Vx_sent_selection_functions to Frun_hook_with_args.
14250 (x_handle_selection_clear,x_clear_frame_selections):
14251 Pass Qx_lost_selection_functions rather than
14252 Vx_lost_selection_functions to Frun_hook_with_args.
14253
47ea7f44
PE
142542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
14255
ac389d0c 14256 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
14257 The old code sometimes used this field without initializing it.
14258
47ea7f44
PE
14259 * alloc.c (gc_sweep): Don't read past end of array.
14260 In theory, the old code could also have corrupted Emacs internals,
14261 though it'd be very unlikely.
14262
bc985c87
AS
142632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
14264
14265 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 14266 argument. (Bug#4026)
bc985c87 14267
0cf34688
LMI
142682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
14269
b3dadd76
LMI
14270 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
14271 key" (bug#4257).
14272
0cf34688
LMI
14273 * window.c (Fset_window_start): Doc fix (bug#4199).
14274 (Fset_window_hscroll): Ditto.
14275
270768cd
PE
142762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
14277
077e3dda 14278 Fix minor new problems caught by GCC 4.6.1.
270768cd 14279 * term.c (init_tty): Remove unused local.
490011a6 14280 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 14281 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 14282 not used otherwise.
270768cd 14283
b1f58454
CY
142842011-07-12 Chong Yidong <cyd@stupidchicken.com>
14285
14286 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
14287
22b9578d
LMI
142882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
14289
6e70ab07
LMI
14290 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
14291 are the mini-buffer and the echo area (bug#3320).
14292
22b9578d
LMI
14293 * term.c (init_tty): Remove support for supdup, c10 and perq
14294 terminals, which are no longer supported (bug#1482).
14295
8974cc9f
JB
142962011-07-10 Johan Bockgård <bojohan@gnu.org>
14297
14298 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
14299
a560d974
JD
143002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
14301
14302 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
14303 for non-popups (Bug#3642).
14304
1dae0f0a
AS
143052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
14306
268c2c36 14307 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 14308 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
14309 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
14310 * cm.c (losecursor): Likewise.
1dae0f0a
AS
14311 * data.c (fmod): Likewise.
14312 * dispnew.c (swap_glyphs_in_rows): Likewise.
14313 * emacs.c (memory_warning_signal): Likewise.
14314 * floatfns.c (float_error): Likewise.
14315 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
14316 (otf_open, font_otf_capability, generate_otf_features)
14317 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
14318 Likewise.
14319 * image.c (pbm_read_file): Likewise.
14320 * indent.c (string_display_width): Likewise.
14321 * intervals.c (check_for_interval, search_for_interval)
14322 (inc_interval_count, count_intervals, root_interval)
14323 (adjust_intervals_for_insertion, make_new_interval): Likewise.
14324 * lread.c (defalias): Likewise.
268c2c36 14325 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
14326 * regex.c (set_image_of_range_1, set_image_of_range)
14327 (regex_grow_registers): Likewise.
14328 * sysdep.c (strerror): Likewise.
14329 * termcap.c (valid_filename_p, tprint, main): Likewise.
14330 * tparam.c (main): Likewise.
14331 * unexhp9k800.c (run_time_remap, save_data_space)
14332 (update_file_ptrs, read_header, write_header, calculate_checksum)
14333 (copy_file, copy_rest, display_header): Likewise.
14334 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
14335 Likewise.
14336 * xdisp.c (check_it): Likewise.
14337 * xfaces.c (register_color, unregister_color, unregister_colors):
14338 Likewise.
14339 * xfns.c (print_fontset_result): Likewise.
14340 * xrdb.c (member, fatal, main): Likewise.
14341
99033785
PE
143422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
14343
14344 Fix minor problems found by static checking (Bug#9031).
14345 * chartab.c (char_table_set_range, map_sub_char_table):
14346 Remove unused locals.
14347 (uniprop_table): Now static.
14348 * composite.c (_work_char): Remove unused static var.
14349
9cb2ac56
JB
143502011-07-09 Juanma Barranquero <lekktu@gmail.com>
14351
14352 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
14353
f25661f0
JD
143542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
14355
14356 * gtkutil.c (qttip_cb): Remove code without function.
14357
8278c4fe
EZ
143582011-07-09 Eli Zaretskii <eliz@gnu.org>
14359
14360 * w32.c (pthread_sigmask): New stub.
14361
1692ae2d 143622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 14363
8a6ebd58 14364 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
14365 sigprocmask is portable only for single-threaded applications, and
14366 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
14367 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
14368 (LIBES): Use it.
14369 * callproc.c (Fcall_process):
14370 * process.c (create_process):
14371 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
14372 Use pthread_sigmask, not sigprocmask.
123403e4 14373
1b854618
JD
143742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
14375
14376 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
14377 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
14378 wrong (Bug#8591).
14379
3fe4b549
JD
143802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
14381
0ce7e563
JD
14382 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
14383 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
14384 (xg_hide_tooltip): Fix comment.
14385
3fe4b549
JD
14386 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
14387 in registerServicesMenuSendTypes.
14388 (validRequestorForSendType): Don't check ns_return_types.
14389
14390 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
14391 ns_return_type.
14392
5df75e47
JR
143932011-07-08 Jason Rumney <jasonr@gnu.org>
14394
22610910
JR
14395 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
14396 SH_SHOW for hidden windows (Bug#5482).
14397
5df75e47
JR
14398 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
14399 frame struct members of non-existent frames (Bug#6284).
14400
699c10bd
JD
144012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
14402
4393663b
JD
14403 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
14404 variable firstTime not needed on OSX >= 10.6.
14405 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
14406 >= 10.5. Use setKnobProportion, setDoubleValue.
14407
14408 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
14409 (MAC_OS_X_VERSION_10_5): Define if not defined.
14410 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
14411 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
14412 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
14413
14414 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 14415 cString and lossyCString on OSX >= 10.4.
4393663b 14416
58179cce 14417 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
14418 sizeToFit on OSX >= 10.2.
14419
14420 * nsimage.m (allocInitFromFile): Don't use deprecated method
14421 bestRepresentationForDevice on OSX >= 10.6.
14422
14423 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
14424 to avoid warning.
14425
14426 * emacs.c: Declare unexec_init_emacs_zone.
14427
a63e0781
JD
14428 * nsgui.h: Fix compiler warning about gnulib redefining verify.
14429
699c10bd
JD
14430 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
14431
14432 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
14433 on svcsMenu (Bug#8842).
14434
14435 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
14436 ns_return_types.
14437 (Fns_list_services): Just return Qnil on 10.6, code not working there.
14438
14439 * nsterm.m (QUTF8_STRING): Declare.
14440 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
14441 (validRequestorForSendType): Return type is (id).
14442 Change indexOfObjectIdenticalTo to indexOfObject.
14443 Check if we have local selection before returning self (Bug#8842).
14444 (writeSelectionToPasteboard): Put local selection into paste board
14445 if we have a local selection (Bug#8842).
14446 (syms_of_nsterm): DEFSYM QUTF8_STRING.
14447
14448 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
14449 (ns_get_local_selection): Declare.
14450
54e10184
LMI
144512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
14452
9888ff71
LMI
14453 * keymap.c (describe_map_tree): Don't insert a double newline at
14454 the end of the buffer (bug#1169) and return whether we inserted
14455 something.
14456
54e10184
LMI
14457 * callint.c (Fcall_interactively): Change "reading args" to
14458 "providing args" to try to clarify what it does (bug#1010).
14459
15fa4783
KH
144602011-07-07 Kenichi Handa <handa@m17n.org>
14461
14462 * composite.c (composition_compute_stop_pos): Ignore a static
14463 composition starting before CHARPOS (Bug#8915).
14464
14465 * xdisp.c (handle_composition_prop): Likewise.
14466
a8815b00
EZ
144672011-07-07 Eli Zaretskii <eliz@gnu.org>
14468
14469 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
14470 (Bug#9015)
14471
ef7b981d 144722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
14473
14474 * character.h (unicode_category_t): New enum type.
14475
14476 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
14477 (Qchar_code_property_table): New variable.
14478 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
14479 (UNIPROP_COMPRESSED_FORM_P): New macros.
14480 (char_table_ascii): Uncompress the compressed values.
14481 (sub_char_table_ref): New arg is_uniprop. Callers changed.
14482 Uncompress the compressed values.
ac389d0c 14483 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
14484 (char_table_ref_and_range): Uncompress the compressed values.
14485 (sub_char_table_set): New arg is_uniprop. Callers changed.
14486 Uncompress the compressed values.
14487 (sub_char_table_set_range): Args changed. Callers changed.
14488 (char_table_set_range): Adjuted for the above change.
14489 (map_sub_char_table): Delete args default_val and parent. Add arg
14490 top. Give decoded values to a Lisp function.
640c8776 14491 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
14492 values to a Lisp function. Gcpro more variables.
14493 (uniprop_table_uncompress)
14494 (uniprop_decode_value_run_length): New functions.
14495 (uniprop_decoder, uniprop_decoder_count): New variables.
14496 (uniprop_get_decoder, uniprop_encode_value_character)
14497 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
14498 New functions.
14499 (uniprop_encoder, uniprop_encoder_count): New variables.
14500 (uniprop_get_encoder, uniprop_table)
14501 (Funicode_property_table_internal, Fget_unicode_property_internal)
14502 (Fput_unicode_property_internal): New functions.
14503 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
14504 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 14505 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
14506 char-code-property-alist.
14507
640c8776 14508 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
14509 Vunicode_category_table.
14510
640c8776 14511 * font.c (font_range): Adjust for the change of
c805dec0
KH
14512 Vunicode_category_table.
14513
76b397fb
DN
145142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
14515
14516 * m/iris4d.h: Remove file, move contents ...
14517 * s/irix6-5.h: ... here.
14518
22b4128e
PE
145192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
14520
14521 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
14522 * alloc.c (mark_buffer):
14523 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
14524 (clone_per_buffer_values): Don't assume that
22b4128e
PE
14525 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
14526 This isn't true in general, and it's particularly not true
14527 if Emacs is configured with --with-wide-int.
14528 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
14529 New macros, used in the buffer.c change.
14530
869795d6
JD
145312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
14532
14533 * xsettings.c: Use both GConf and GSettings if both are available.
14534 (store_config_changed_event): Add comment.
14535 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
14536 (store_tool_bar_style_changed): New functions.
5e617bc2 14537 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
14538 (struct xsettings): Move font inside HAVE_XFT.
14539 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 14540 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 14541 Move inside HAVE_XFT.
640c8776 14542 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
14543 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
14544 also.
14545 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 14546 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 14547 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
14548 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
14549 (parse_settings): Move check for font inside HAVE_XFT.
14550 (read_settings, apply_xft_settings): Add comment.
14551 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
14552 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
14553 call store_font_name_changed.
14554 (xft_settings_event): Add comment.
14555 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
14556 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
14557 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
14558 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
14559 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
14560 (xsettings_get_system_font, xsettings_get_system_normal_font):
14561 Add comment.
869795d6 14562
d8ed26bd
PE
145632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
14564
14565 Random fixes. E.g., (random) never returned negative values.
14566 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
14567 subseconds part to the entropy, as that's a bit more random.
14568 Prefer signed to unsigned, since the signedness doesn't matter and
14569 in general we prefer signed. When given a limit, use a
14570 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
14571 latter isn't right if USE_2_TAGS_FOR_INTS.
14572 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
14573 not 0..VALMASK. Don't discard "excess" bits that random () returns.
14574
cabf1cac
SM
145752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
14576
14577 * textprop.c (text_property_stickiness):
14578 Obey Vtext_property_default_nonsticky.
14579 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
14580 * w32fns.c (syms_of_w32fns):
14581 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
14582
6e9b2be9
PE
145832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
14584
14585 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
14586 This is more efficient than Ffile_directory_p and avoids a minor race.
14587
90186c68
LMI
145882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
14589
7c301272
LMI
14590 * buffer.c (Foverlay_put): Say what the return value is
14591 (bug#7835).
14592
c4f2d8d4
LMI
14593 * fileio.c (barf_or_query_if_file_exists): Check first if the file
14594 is a directory before asking whether to use the file name
14595 (bug#7564).
ad637907
LMI
14596 (barf_or_query_if_file_exists): Make the "File is a directory"
14597 error be more correct.
c4f2d8d4 14598
90186c68
LMI
14599 * fns.c (Frequire): Remove the mention of the .gz files, since
14600 that's installation-specific, but keep the mention of
14601 `get-load-suffixes'.
14602
da64016e
PE
146032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
14604
14605 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
14606 Report string overflow if the output is too long.
14607
7d47b580
JB
146082011-07-04 Juanma Barranquero <lekktu@gmail.com>
14609
a555cb87
JB
14610 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
14611 (syms_of_gnutls): Remove duplicate DEFSYM for
14612 Qgnutls_bootprop_verify_hostname_error, an error for
14613 Qgnutls_bootprop_verify_error (which is no longer used).
14614
7d47b580
JB
14615 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
14616 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
14617 Also (re)move comments that are misplaced or no longer relevant.
14618
1e49bfab
LMI
146192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
14620
14621 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
14622
1485f4c0
CY
146232011-07-03 Chong Yidong <cyd@stupidchicken.com>
14624
14625 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
14626 and background color parameters if they have been changed.
14627
a9ab721e
LMI
146282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
14629
14630 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
14631
cf7cff57
PE
146322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
14633
2e13213d
PE
14634 * xsettings.c (SYSTEM_FONT): Define only when used.
14635 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
14636
cf7cff57
PE
14637 * keymap.c (access_keymap_1): Now static.
14638
7a8e04f7
CY
146392011-07-02 Chong Yidong <cyd@stupidchicken.com>
14640
14641 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
14642 leave any prefix arg for the up event (Bug#1586).
14643
61352f62
LMI
146442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
14645
69bb1ef7
LMI
14646 * lread.c (syms_of_lread): Mention single symbols defined by
14647 `defvar' or `defconst' (bug#7154).
14648
61352f62 14649 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 14650 (Frequire): Mention get-load-suffixes.
61352f62 14651
28545e04
MR
146522011-07-02 Martin Rudalics <rudalics@gmx.at>
14653
14654 * window.h (window): Remove clone_number slot.
14655 * window.c (Fwindow_clone_number, Fset_window_clone_number):
14656 Remove.
14657 (make_parent_window, make_window, saved_window)
14658 (Fset_window_configuration, save_window_save): Don't deal with
14659 clone numbers.
14660 * buffer.c (Qclone_number): Remove declaration.
14661 (sort_overlays, overlay_strings): Don't deal with clone numbers.
14662
3349e122
SM
146632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
14664
14665 Add multiple inheritance to keymaps.
14666 * keymap.c (Fmake_composed_keymap): New function.
14667 (Fset_keymap_parent): Simplify.
14668 (fix_submap_inheritance): Remove.
14669 (access_keymap_1): New function extracted from access_keymap to handle
14670 embedded parents and handle lists of maps.
14671 (access_keymap): Use it.
14672 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
14673 (Fcopy_keymap): Handle embedded parents.
14674 (Fcommand_remapping, define_as_prefix): Simplify.
14675 (Fkey_binding): Simplify.
14676 (syms_of_keymap): Move minibuffer-local-completion-map,
14677 minibuffer-local-filename-completion-map,
14678 minibuffer-local-must-match-map, and
14679 minibuffer-local-filename-must-match-map to Elisp.
14680 (syms_of_keymap): Defsubr make-composed-keymap.
14681 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
14682 (parse_menu_item): Trivial simplification.
14683
3279eb87
GM
146842011-07-01 Glenn Morris <rgm@gnu.org>
14685
14686 * Makefile.in (SETTINGS_LIBS): Fix typo.
14687
39cb9e56 146882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
14689
14690 * coding.c (Fencode_coding_string): Record the last coding system
14691 used, as the function doc string says (bug#8738).
14692
0949d2b6
JD
146932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
14694
14695 * xsettings.c (store_monospaced_changed): Take new font as arg and
14696 check for change against current_mono_font.
14697 (EMACS_TYPE_SETTINGS): Remove this and related defines.
14698 (emacs_settings_constructor, emacs_settings_get_property)
14699 (emacs_settings_set_property, emacs_settings_class_init)
14700 (emacs_settings_init, gsettings_obj): Remove.
14701 (something_changedCB): New function for HAVE_GSETTINGS.
14702 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
14703 with value as argument.
14704 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
14705 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 14706 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
14707 "changed".
14708
14709 * xgselect.c: Add defined (HAVE_GSETTINGS).
14710 (xgselect_initialize): Ditto.
14711
14712 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
14713 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
14714 xg_select.
14715
bbc6b304
PE
147162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
14717
14718 * eval.c (struct backtrace): Simplify and port the data structure.
14719 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
14720 signed bit field, as this assumption is not portable and it makes
14721 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
14722 "char debug_on_exit : 1" as this is not portable either; instead,
14723 use the portable "unsigned int debug_on_exit : 1". Remove unused
14724 member evalargs. Remove obsolete comments about cc bombing out.
14725
9851bfc5
JD
147262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
14727
51bb811f 14728 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
14729 Let HAVE_GSETTINGS override HAVE_GCONF.
14730 (store_monospaced_changed): New function.
14731 (EMACS_SETTINGS): A new type derived from GObject to handle
14732 GSettings notifications.
14733 (emacs_settings_constructor, emacs_settings_get_property)
14734 (emacs_settings_set_property, emacs_settings_class_init):
14735 New functions.
14736 (gsettings_client, gsettings_obj): New variables.
14737 (GSETTINGS_SCHEMA): New define.
14738 (something_changedCB): Call store_monospaced_changed.
14739 (init_gsettings): New function.
14740 (xsettings_initialize): Call init_gsettings.
14741 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
14742 to NULL.
14743
640c8776 14744 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
14745 GCONF_CFLAGS/LIBS.
14746
5386012d
MR
147472011-06-29 Martin Rudalics <rudalics@gmx.at>
14748
14749 * window.c (resize_root_window, grow_mini_window)
14750 (shrink_mini_window): Rename Qresize_root_window to
14751 Qwindow_resize_root_window and Qresize_root_window_vertically to
14752 Qwindow_resize_root_window_vertically.
14753
f13e0b08
PE
147542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
14755
14756 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
14757
94515237
JB
147582011-06-27 Juanma Barranquero <lekktu@gmail.com>
14759
14760 * makefile.w32-in: Redesign dependencies so they reflect more
14761 clearly which files are directly included by each source file,
14762 and not through other includes.
14763
e43b6e43
MR
147642011-06-27 Martin Rudalics <rudalics@gmx.at>
14765
14766 * buffer.c (Qclone_number): Declare static and DEFSYM it.
14767 (sort_overlays, overlay_strings): When an overlay's clone number
14768 matches the window's clone number process the overlay even if
14769 the overlay's window property doesn't match the current window.
14770
d68443dc
MR
14771 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
14772 (Fwindow_hchild): Rename to Fwindow_left_child.
14773 (Fwindow_next): Rename to Fwindow_next_sibling.
14774 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
14775 (resize_window_check): Rename to window_resize_check.
14776 (resize_window_apply): Rename to window_resize_apply.
14777 (Fresize_window_apply): Rename to Fwindow_resize_apply.
14778 (Fdelete_other_windows_internal, resize_frame_windows)
14779 (Fsplit_window_internal, Fdelete_window_internal)
14780 (grow_mini_window, shrink_mini_window)
14781 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 14782
c7e73be5
JD
147832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
14784
14785 * emacsgtkfixed.h: State that this is only used with Gtk+3.
14786 (emacs_fixed_set_min_size): Remove.
14787 (emacs_fixed_new): Take frame as argument.
14788
14789 * emacsgtkfixed.c: State that this is only used with Gtk+3.
14790 (_EmacsFixedPrivate): Remove minwidth/height.
14791 Add struct frame *f.
14792 (emacs_fixed_init): Initialize priv->f.
14793 (get_parent_class, emacs_fixed_set_min_size): Remove.
14794 (emacs_fixed_new): Set priv->f to argument.
14795 (emacs_fixed_get_preferred_width)
14796 (emacs_fixed_get_preferred_height): Use min_width/height from
14797 frames size_hint to set minimum and natural (Bug#8919).
14798 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
14799 and use min_width/height from frames size_hint to set
14800 min_width/height (Bug#8919).
14801
14802 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
14803 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
14804 Fix indentation.
c7e73be5 14805
cf99dcf8
EZ
148062011-06-26 Eli Zaretskii <eliz@gnu.org>
14807
14808 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
14809 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
14810 called at ZV.
14811
029529ac
CY
148122011-06-26 Chong Yidong <cyd@stupidchicken.com>
14813
14814 * process.c (wait_reading_process_output): Bypass select if
14815 waiting for a cell while ignoring keyboard input, and input is
14816 pending. Suggested by Jan Djärv (Bug#8869).
14817
7a7ef429
PE
148182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
14819
14820 Use gnulib's dup2 module instead of rolling our own.
14821 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
14822
11fdef7d 148232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
14824
14825 * dispnew.c (scrolling_window): Before scrolling, turn off a
14826 mouse-highlight in the window being scrolled.
14827
cd3520a4
JB
148282011-06-24 Juanma Barranquero <lekktu@gmail.com>
14829
14830 Move DEFSYM to lisp.h and use everywhere.
14831
14832 * character.h (DEFSYM): Move declaration...
14833 * lisp.h (DEFSYM): ...here.
14834
14835 * gnutls.c:
14836 * minibuf.c:
14837 * w32menu.c:
14838 * w32proc.c:
14839 * w32select.c: Don't include character.h.
14840
14841 * alloc.c (syms_of_alloc):
14842 * buffer.c (syms_of_buffer):
14843 * bytecode.c (syms_of_bytecode):
14844 * callint.c (syms_of_callint):
14845 * casefiddle.c (syms_of_casefiddle):
14846 * casetab.c (init_casetab_once):
14847 * category.c (init_category_once, syms_of_category):
14848 * ccl.c (syms_of_ccl):
14849 * cmds.c (syms_of_cmds):
14850 * composite.c (syms_of_composite):
14851 * dbusbind.c (syms_of_dbusbind):
14852 * dired.c (syms_of_dired):
14853 * dispnew.c (syms_of_display):
14854 * doc.c (syms_of_doc):
14855 * editfns.c (syms_of_editfns):
14856 * emacs.c (syms_of_emacs):
14857 * eval.c (syms_of_eval):
14858 * fileio.c (syms_of_fileio):
14859 * fns.c (syms_of_fns):
14860 * frame.c (syms_of_frame):
14861 * fringe.c (syms_of_fringe):
14862 * insdel.c (syms_of_insdel):
14863 * keymap.c (syms_of_keymap):
14864 * lread.c (init_obarray, syms_of_lread):
14865 * macros.c (syms_of_macros):
14866 * msdos.c (syms_of_msdos):
14867 * print.c (syms_of_print):
14868 * process.c (syms_of_process):
14869 * search.c (syms_of_search):
14870 * sound.c (syms_of_sound):
14871 * syntax.c (init_syntax_once, syms_of_syntax):
14872 * terminal.c (syms_of_terminal):
14873 * textprop.c (syms_of_textprop):
14874 * undo.c (syms_of_undo):
14875 * w32.c (globals_of_w32):
14876 * window.c (syms_of_window):
14877 * xdisp.c (syms_of_xdisp):
14878 * xfaces.c (syms_of_xfaces):
14879 * xfns.c (syms_of_xfns):
14880 * xmenu.c (syms_of_xmenu):
14881 * xsettings.c (syms_of_xsettings):
14882 * xterm.c (syms_of_xterm): Use DEFSYM.
14883
4228cf16
TZ
148842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
14885
cd3520a4 14886 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 14887
7fcccf1e
PE
148882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
14889
7efb4e0e
PE
14890 Integer and buffer overflow fixes (Bug#8873).
14891
ff5844ad
PE
14892 * print.c (printchar, strout): Check for string overflow.
14893 (PRINTPREPARE, printchar, strout):
14894 Don't set size unless allocation succeeds.
14895
90532f02
PE
14896 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
14897 for sizes. Check for string overflow more accurately.
14898 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
14899
6d84508d
PE
14900 * macros.c: Integer and buffer overflow fixes.
14901 * keyboard.h (struct keyboard.kbd_macro_bufsize):
14902 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
14903 Use ptrdiff_t, not int, for sizes.
14904 Don't increment bufsize until after realloc succeeds.
14905 Check for size-calculation overflow.
14906 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
14907
437b2cb4
PE
14908 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
14909
8b9ac8b4
PE
14910 * lread.c: Integer overflow fixes.
14911 (read_integer): Radix is now EMACS_INT, not int,
14912 to improve quality of diagnostics for out-of-range radices.
14913 Calculate buffer size correctly for out-of-range radices.
14914 (read1): Check for integer overflow in radices, and in
14915 read-circle numbers.
82cb60d3
PE
14916 (read_escape): Avoid int overflow.
14917 (Fload, openp, read_buffer_size, read1)
14918 (substitute_object_recurse, read_vector, read_list, map_obarray):
14919 Use ptrdiff_t, not int, for sizes.
14920 (read1): Use EMACS_INT, not int, for sizes.
20270765 14921 Check for size overflow.
8b9ac8b4 14922
7fcccf1e
PE
14923 * image.c (cache_image): Check for size arithmetic overflow.
14924
bfbbd7e7
PE
14925 * lread.c: Integer overflow issues.
14926 (saved_doc_string_size, saved_doc_string_length)
14927 (prev_saved_doc_string_size, prev_saved_doc_string_length):
14928 Now ptrdiff_t, not int.
14929 (read1): Don't assume doc string length fits in int. Check for
14930 out-of-range doc string lengths.
14931 (read_list): Don't assume file position fits in int.
39019e54 14932 (read_escape): Check for hex character overflow.
bfbbd7e7 14933
4e323265
LL
149342011-06-22 Leo Liu <sdl.web@gmail.com>
14935
14936 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
14937 Move to minibuffer.el.
14938
85fece3e
PE
149392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
14940
20b84ce9 14941 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
14942 The following patches are for when GLYPH_DEBUG && !XASSERT.
14943 * dispextern.h (trace_redisplay_p, dump_glyph_string):
14944 * dispnew.c (flush_stdout):
14945 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
14946 Mark as externally visible.
14947 * dispnew.c (check_window_matrix_pointers): Now static.
14948 * dispnew.c (window_to_frame_vpos):
14949 * xfns.c (unwind_create_frame):
14950 * xterm.c (x_check_font): Remove unused local.
14951 * scroll.c (CHECK_BOUNDS):
14952 * xfaces.c (cache_fache): Rename local to avoid shadowing.
14953 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
14954 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
14955 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
14956 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
14957 Now static.
14958 (debug_method_add): Use va_list and vsprintf rather than relying
14959 on undefined behavior with wrong number of arguments.
14960 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
14961 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
14962 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
14963 since we're not interested in debugging glyphs with old libraries.
14964 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
14965 GCC 4.6.0's static checking.
14966
0766b489
PE
149672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
14968
31fd4b32
PE
14969 Integer overflow and signedness fixes (Bug#8873).
14970 A few related buffer overrun fixes, too.
14971
b79e8648
PE
14972 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
14973
0766b489
PE
14974 * dispextern.h (struct face.stipple):
14975 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
14976 (x_bitmap_mask, x_allocate_bitmap_record)
14977 (x_create_bitmap_from_data, x_create_bitmap_from_file)
14978 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
14979 (x_create_bitmap_from_xpm_data):
14980 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
14981 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
14982 (.bitmaps_last):
14983 * xfaces.c (load_pixmap):
14984 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
14985 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
14986 (.bitmaps_last, struct x_output.icon_bitmap):
14987 Use ptrdiff_t, not int, for bitmap indexes.
14988 (x_allocate_bitmap_record): Check for size overflow.
14989 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
14990
b081724f
PE
14991 Use ptrdiff_t, not int, for overlay counts.
14992 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
14993 * editfns.c (overlays_around, get_pos_property):
14994 * textprop.c (get_char_property_and_overlay):
14995 * xdisp.c (next_overlay_change, note_mouse_highlight):
14996 * xfaces.c (face_at_buffer_position):
21514da7
PE
14997 * buffer.c (OVERLAY_COUNT_MAX): New macro.
14998 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
14999 (Fnext_overlay_change, Fprevious_overlay_change)
15000 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 15001 Use ptrdiff_t, not int, for sizes.
21514da7 15002 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 15003
3de73e5e
PE
15004 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
15005
2606c57b
PE
15006 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
15007 (x_session_initialize): Do not assume string length fits in int.
15008
aaafe47a
PE
15009 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
15010 This is unlikely, but can occur if DPI is outlandish.
15011
2674ddc8 15012 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
15013 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
15014
28154962
PE
15015 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
15016 * xrdb.c (magic_file_p, search_magic_path):
15017 Omit last arg SUFFIX; it was always 0. All callers changed.
15018 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
15019
7de51af5
PE
15020 * xfont.c (xfont_match): Avoid need for strlen.
15021
25ed6cc3
PE
15022 * xfns.c: Don't assume strlen fits in int.
15023 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
15024
4eab31dd
PE
15025 * xdisp.c (message_log_check_duplicate): Return intmax_t,
15026 not unsigned long, as we prefer signed integers. All callers changed.
15027 Detect integer overflow in repeat count.
15028 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 15029 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 15030
171e2a58
PE
15031 * termcap.c: Don't assume sizes fit in int and never overflow.
15032 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
15033 (gobble_line): Check for size-calculation overflow.
15034
ad39faca 15035 * minibuf.c (Fread_buffer):
6e5bb2dc 15036 * lread.c (intern, intern_c_string):
74ca2eb3
PE
15037 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
15038 Don't assume string length fits in int.
15039
52c61c22 15040 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
15041 * gtkutil.c (style_changed_cb): Avoid need for strlen.
15042
b5b8c9e5
PE
15043 * font.c: Don't assume string length fits in int.
15044 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
15045 Use ptrdiff_t, not int.
ccd6111c
PE
15046 (font_intern_prop): Don't assume string length fits in int.
15047 Don't assume integer property fits in fixnum.
15048 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 15049
882f0d81 15050 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 15051 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
15052 Reformulate so as not to need the command string.
15053 Invoke gzip -cd rather than gunzip, as it's more portable.
15054 (lock_info_type, lock_file_1, lock_file):
15055 Don't assume pid_t and time_t fit in unsigned long.
15056 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
15057 (current_lock_owner): Prefer signed type for sizes.
15058 Use memcpy, not strncpy, where memcpy is what is really wanted.
15059 Don't assume (via atoi) that time_t and pid_t fit in int.
15060 Check for time_t and/or pid_t out of range, e.g., via a network share.
15061 Don't alloca where an auto var works fine.
15062
93f4cf88
PE
15063 * fileio.c: Fix some integer overflow issues.
15064 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
15065 Don't assume string length fits in int.
15066 (directory_file_name): Don't assume string length fits in long.
15067 (make_temp_name): Don't assume pid fits in int, or that its print
15068 length is less than 20.
15069
f3e92b69
PE
15070 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
15071
1bfdaf10
PE
15072 * coding.c (make_subsidiaries): Don't assume string length fits in int.
15073
35016e9a
PE
15074 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
15075
3d1e65a1
PE
15076 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
15077 We prefer signed integers, even for size calculations.
15078
0b963a93
PE
15079 * emacs.c: Don't assume string length fits in 'int'.
15080 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
15081 (main): Don't invoke strlen when not needed.
15082
573f4b54
PE
15083 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
15084 (XD_DEBUG_MESSAGE): Don't waste a byte.
15085
989f33ba
PE
15086 * callproc.c (getenv_internal_1, getenv_internal)
15087 (Fgetenv_internal):
965d34eb
PE
15088 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
15089
e4d29b33
PE
15090 * lread.c (invalid_syntax): Omit length argument.
15091 All uses changed. This doesn't fix a bug, but it simplifies the
15092 code away from its former Hollerith-constant appearance, and it's
15093 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 15094 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 15095
eb49b136
PE
15096 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
15097 This didn't break anything, but it didn't help either.
15098 It's confusing to put a bogus integer in a place where the actual
15099 value does not matter.
9f62aeb1 15100 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 15101 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 15102
15375a22
PE
15103 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
15104 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
15105 implementation.
b61cc01c
PE
15106 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
15107 We prefer signed types, and the value cannot exceed the EMACS_INT
15108 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
15109 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
15110 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
15111 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 15112
53b2623d
PE
15113 * indent.c (sane_tab_width): New function.
15114 (current_column, scan_for_column, Findent_to, position_indentation)
15115 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 15116 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 15117
51cab52b 15118 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 15119
f2ed8a70
PE
15120 * lisp.h (lint_assume): New macro.
15121 * composite.c (composition_gstring_put_cache):
15122 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
15123
abe80cc6
PE
15124 * editfns.c, insdel.c:
15125 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 15126
b02c740e
PE
15127 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
15128
ebc96716
PE
15129 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
15130
b4e50fa0 15131 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 15132 Use much-faster test for byte-length change.
311d5d7c 15133 Don't assume string byte-length fits in 'int'.
a4cf38e4 15134 Check that character arg fits in 'int'.
85461888 15135 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 15136
c0c1ee9f
PE
15137 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
15138
a498d7f4
PE
15139 * fns.c (concat): Catch string overflow earlier.
15140 Do not rely on integer wraparound.
15141
51cab52b
PE
15142 * dispextern.h (struct it.overlay_strings_charpos)
15143 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
15144 * xdisp.c (forward_to_next_line_start)
15145 (back_to_previous_visible_line_start)
15146 (reseat_at_next_visible_line_start, next_element_from_buffer):
15147 Don't arbitrarily truncate the value of 'selective' to int.
15148
76031fad
PE
15149 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
15150
5eb55db9
PE
15151 * composite.c: Don't truncate sizes to 'int'.
15152 (composition_gstring_p, composition_reseat_it)
15153 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
15154 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
15155 not EMACS_UINT, for indexes.
5eb55db9 15156
0703a717
PE
15157 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
15158
d6202519
PE
15159 * buffer.c: Include <verify.h>.
15160 (struct sortvec.priority, struct sortstr.priority):
8961a454 15161 Now EMACS_INT, not int.
c20998a7 15162 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
15163 (struct sortstr.size, record_overlay_string)
15164 (struct sortstrlist.size, struct sortlist.used):
15165 Don't truncate size to int.
15166 (record_overlay_string): Check for size-calculation overflow.
d6202519 15167 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 15168
d5a19415
JM
151692011-06-22 Jim Meyering <meyering@redhat.com>
15170
029529ac 15171 Don't leak an XBM-image-sized buffer
d5a19415
JM
15172 * image.c (xbm_load): Free the image buffer after using it.
15173
a9041e6c
PE
151742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
15175
15176 Port to Sun C.
15177 * composite.c (find_automatic_composition): Omit needless 'return 0;'
15178 that Sun C diagnosed.
15179 * fns.c (secure_hash): Fix pointer signedness issue.
15180 * intervals.c (static_offset_intervals): New function.
15181 (offset_intervals): Use it.
15182
7f3f739f
LL
151832011-06-21 Leo Liu <sdl.web@gmail.com>
15184
15185 * deps.mk (fns.o):
15186 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
15187 sha512.h.
15188
15189 * fns.c (secure_hash): Rename from crypto_hash_function and change
15190 the first arg to accept symbols.
5b66d427 15191 (Fsecure_hash): New primitive.
7f3f739f
LL
15192 (syms_of_fns): New symbols.
15193
76147d94
DD
151942011-06-20 Deniz Dogan <deniz@dogan.se>
15195
15196 * process.c (Fset_process_buffer): Clarify return value in
15197 docstring.
15198
7d7d0045
CY
151992011-06-18 Chong Yidong <cyd@stupidchicken.com>
15200
15201 * dispnew.c (add_window_display_history): Use BVAR.
15202
15203 * xdisp.c (debug_method_add): Use BVAR.
15204 (check_window_end, dump_glyph_matrix, dump_glyph)
15205 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
15206
15207 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
15208 Likewise.
15209
15210 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
15211 check till after the cache is created in init_frame_faces.
15212
ff2bc410
SM
152132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
15214
15215 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
15216
28177add
PE
152172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
15218
dd3482fe
PE
15219 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
15220 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
15221 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
15222
393d71f3 15223 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
15224 * fileio.c (Finsert_file_contents):
15225 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
15226 Remove the old (too-loose) buffer overflow checks.
15227 They weren't needed, since make_gap checks for buffer overflow.
15228 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
15229 The old code merely checked for Emacs fixnum overflow, and relied
15230 on undefined (wraparound) behavior. The new code avoids undefined
15231 behavior, and also checks for ptrdiff_t and/or size_t overflow.
15232
2e6813b0 15233 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
15234 Tune. Don't use wider integers than needed. Don't use alloca.
15235 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 15236
599a9e4f
PE
15237 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
15238
99561444
PE
15239 * insdel.c, lisp.h (buffer_overflow): New function.
15240 (insert_from_buffer_1, replace_range, replace_range_2):
15241 * insdel.c (make_gap_larger):
15242 * editfns.c (Finsert_char):
15243 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
15244
28177add
PE
15245 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
15246
e69dafad
PE
152472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
15248
4baa020d 15249 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 15250
b1c46f02
PE
15251 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
15252 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
15253
e69dafad
PE
15254 * fileio.c: Don't assume EMACS_INT fits in off_t.
15255 (emacs_lseek): New static function.
15256 (Finsert_file_contents, Fwrite_region): Use it.
15257 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
15258
566684ea
PE
15259 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
15260
e6966cd6
PE
15261 * fns.c: Don't overflow int when computing a list length.
15262 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
15263 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
15264 truncation on 64-bit hosts. Check for QUIT every
15265 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
15266 faster and is responsive enough.
15267 (Flength): Report an error instead of overflowing an integer.
15268 (Fsafe_length): Return a float if the value is not representable
15269 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 15270 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 15271 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 15272
dd0b0efb
PE
15273 * alloc.c: Check that resized vectors' lengths fit in fixnums.
15274 (header_size, word_size): New constants.
15275 (allocate_vectorlike): Don't check size overflow here.
15276 (allocate_vector): Check it here instead, since this is the only
15277 caller of allocate_vectorlike that could cause overflow.
15278 Check that the new vector's length is representable as a fixnum.
15279
86fe5cfe
PE
15280 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
15281 The previous code was bogus. For example, next_almost_prime (32)
15282 returned 39, which is undesirable as it is a multiple of 3; and
15283 next_almost_prime (24) returned 25, which is a multiple of 5 so
15284 why was the code bothering to check for multiples of 7?
15285
80e88859
PE
15286 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
15287
4a2f0ad6
PE
15288 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
15289
f66c7cf8
PE
15290 Variadic C functions now count arguments with ptrdiff_t.
15291 This partly undoes my 2011-03-30 change, which replaced int with size_t.
15292 Back then I didn't know that the Emacs coding style prefers signed int.
15293 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
15294 were being counted with int, which may truncate counts on 64-bit
15295 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
15296 * lisp.h (struct Lisp_Subr.function.aMANY)
15297 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
15298 Arg counts are now ptrdiff_t, not size_t.
15299 All variadic functions and their callers changed accordingly.
15300 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
15301 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
15302 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
15303 * callint.c (Fcall_interactively): Check arg count for overflow,
15304 to avoid potential buffer overrun. Use signed char, not 'int',
15305 for 'varies' array, so that we needn't bother to check its size
15306 calculation for overflow.
15307 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
15308 * eval.c (apply_lambda):
15309 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
15310 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
15311 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
15312
a1759b76
PE
15313 * callint.c (Fcall_interactively): Don't use index var as event count.
15314
d96be9fc
PE
15315 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
15316 * mem-limits.h (SIZE): Remove; no longer used.
15317
a690a978 15318 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 15319
578c21e6
PE
15320 Remove unnecessary casts.
15321 * xterm.c (x_term_init):
15322 * xfns.c (x_set_border_pixel):
15323 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
15324 These aren't needed now that we assume ANSI C.
15325
96f53c6c
PE
15326 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
15327 It's more likely to cause problems (due to unsigned overflow)
15328 than to cure them.
15329
83c77d31
PE
15330 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
15331
ee2079f1
PE
15332 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
15333
6da65536
PE
15334 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
15335
7147c4a4
PE
15336 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
15337
193e32d9
PE
15338 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
15339
e5533da6
PE
15340 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
15341
9910e595
PE
15342 GLYPH_CODE_FACE returns EMACS_INT, not int.
15343 * dispextern.h (merge_faces):
15344 * xfaces.c (merge_faces):
01103c44
PE
15345 * xdisp.c (get_next_display_element, next_element_from_display_vector):
15346 Don't assume EMACS_INT fits in int.
9910e595 15347
2638320e
PE
15348 * character.h (CHAR_VALID_P): Remove unused parameter.
15349 * fontset.c, lisp.h, xdisp.c: All uses changed.
15350
045eb8d9
PE
15351 * editfns.c (Ftranslate_region_internal): Omit redundant test.
15352
c1f134b5
PE
15353 * fns.c (concat): Minor tuning based on overflow analysis.
15354 This doesn't fix any bugs. Use int to hold character, instead
15355 of constantly refetching from Emacs object. Use XFASTINT, not
15356 XINT, for value known to be a character. Don't bother comparing
15357 a single byte to 0400, as it's always less.
15358
395fcb93 15359 * floatfns.c (Fexpt):
327eeec8
PE
15360 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
15361
abbd3d23
PE
15362 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
15363 for characters.
15364
684a03ef
PE
15365 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
15366
0fed43f3
PE
15367 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
15368 Without this fix, on a 64-bit host (aset S 0 4294967386) would
15369 incorrectly succeed when S was a string, because 4294967386 was
15370 truncated before it was used.
15371
8fd02eb7
PE
15372 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
15373 Otherwise, an out-of-range integer could cause undefined behavior
15374 on a 64-bit host.
15375
f8c86b69
PE
15376 * composite.c: Use int, not EMACS_INT, for characters.
15377 (fill_gstring_body, composition_compute_stop_pos): Use int, not
15378 EMACS_INT, for values that are known to be in character range.
15379 This doesn't fix any bugs but is the usual style inside Emacs and
15380 may generate better code on 32-bit machines.
15381
34206dd2
PE
15382 Make sure a 64-bit char is never passed to ENCODE_CHAR.
15383 This is for reasons similar to the recent CHAR_STRING fix.
15384 * charset.c (Fencode_char): Check that character arg is actually
15385 a character. Pass an int to ENCODE_CHAR.
15386 * charset.h (ENCODE_CHAR): Verify that the character argument is no
15387 wider than 'int', as a compile-time check to prevent future regressions
15388 in this area.
15389
c5958d4c 15390 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
15391
15392 Make sure a 64-bit char is never passed to CHAR_STRING.
15393 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
15394 by silently ignoring the top 32 bits, allowing some values
15395 that were far too large to be valid characters.
15396 * character.h: Include <verify.h>.
15397 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
15398 arguments are no wider than unsigned, as a compile-time check
15399 to prevent future regressions in this area.
15400 * data.c (Faset):
01103c44 15401 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
15402 (Fsubst_char_in_region):
15403 * fns.c (concat):
15404 * xdisp.c (decode_mode_spec_coding):
15405 Adjust to CHAR_STRING's new requirement.
15406 * editfns.c (Finsert_char, Fsubst_char_in_region):
15407 * fns.c (concat): Check that character args are actually
15408 characters. Without this test, these functions did the wrong
15409 thing with wildly out-of-range values on 64-bit hosts.
15410
d37ca623
PE
15411 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
15412 These casts should not be needed on 32-bit hosts, either.
15413 * keyboard.c (read_char):
15414 * lread.c (Fload): Remove casts to unsigned.
15415
ea204efb
PE
15416 * lisp.h (UNSIGNED_CMP): New macro.
15417 This fixes comparison bugs on 64-bit hosts.
15418 (ASCII_CHAR_P): Use it.
15419 * casefiddle.c (casify_object):
01103c44 15420 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
15421 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
15422 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
15423 * dispextern.h (FACE_FROM_ID):
15424 * keyboard.c (read_char): Use UNSIGNED_CMP.
15425
41cb286c
PE
15426 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
15427 not to EMACS_INT, to avoid GCC warning.
15428
4a1b9832
PE
15429 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
15430
55daad71
PE
15431 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
15432 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
15433 isn't needed on 32-bit machines.
8f95c75c 15434
01103c44
PE
15435 * buffer.c (Fgenerate_new_buffer_name):
15436 Use EMACS_INT for count, not int.
0ceccced 15437 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
15438
15439 * data.c (Qcompiled_function): Now static.
15440
c6f072e7
PE
15441 * window.c (window_body_lines): Now static.
15442
20ce5912
PE
15443 * image.c (gif_load): Rename local to avoid shadowing.
15444
9c4c5f81
PE
15445 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
15446 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
15447 * alloc.c (make_save_value): Integer argument is now of type
15448 ptrdiff_t, not int.
15449 (mark_object): Use ptrdiff_t, not int.
15450 * lisp.h (pD): New macro.
15451 * print.c (print_object): Use it.
15452
c0c5c8ae
PE
15453 * alloc.c: Use EMACS_INT, not int, to count objects.
15454 (total_conses, total_markers, total_symbols, total_vector_size)
15455 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
15456 (total_free_floats, total_floats, total_free_intervals)
15457 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
15458 Now EMACS_INT, not int. All uses changed.
15459 (Fgarbage_collect): Compute overall total using a double, so that
15460 integer overflow is less likely to be a problem. Check for overflow
15461 when converting back to an integer.
5a25e253
PE
15462 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
15463 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
15464 These were 'int' variables that could overflow on 64-bit hosts;
15465 they were never used, so remove them instead of repairing them.
211a0b2a 15466 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
15467 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
15468 Previously, this ceilinged at INT_MAX, but that doesn't work on
15469 64-bit machines.
e46bb31a 15470 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 15471
c78baabf 15472 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 15473 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
15474 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
15475 when a (possibly-narrower) signed value would do just as well.
15476 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 15477
c9d624c6
PE
15478 * alloc.c: Catch some string size overflows that we were missing.
15479 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
15480 for convenience in STRING_BYTES_MAX.
15481 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
15482 The definition here is exact; the one in lisp.h was approximate.
15483 (allocate_string_data): Check for string overflow. This catches
15484 some instances we weren't catching before. Also, it catches
15485 size_t overflow on (unusual) hosts where SIZE_MAX <= min
15486 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
15487 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 15488
c9d624c6
PE
15489 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
15490 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 15491 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 15492
353032ce
PE
15493 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
15494
2bccce07
PE
15495 * alloc.c (Fmake_string): Check for out-of-range init.
15496
0ac30604
SM
154972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
15498
15499 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
15500
c195f2de
JD
155012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
15502
15503 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
15504 xg_get_default_scrollbar_width.
15505
15506 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
15507 (int_gtk_range_get_value): Move to the scroll bar part of the file.
15508 (style_changed_cb): Call update_theme_scrollbar_width and call
15509 x_set_scroll_bar_default_width and xg_frame_set_char_size for
15510 all frames (Bug#8505).
15511 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
15512 Call gtk_window_set_resizable if HAVE_GTK3.
15513 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
15514 and height if HAVE_GTK3 (Bug#8505).
15515 (scroll_bar_width_for_theme): New variable.
15516 (update_theme_scrollbar_width): New function.
15517 (xg_get_default_scrollbar_width): Move code to
15518 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
15519 (xg_initialize): Call update_theme_scrollbar_width.
15520
15521 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
15522
15523 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
15524
e10ac9f1
MR
155252011-06-12 Martin Rudalics <rudalics@gmx.at>
15526
15527 * frame.c (make_frame): Call other_buffer_safely instead of
15528 other_buffer.
15529
15530 * window.c (temp_output_buffer_show): Call display_buffer with
15531 second argument Vtemp_buffer_show_specifiers and reset latter
15532 immediately after the call.
15533 (Vtemp_buffer_show_specifiers): New variable.
15534 (auto_window_vscroll_p, next_screen_context_lines)
15535 (Vscroll_preserve_screen_position): Remove leading asterisks from
15536 doc-strings.
15537
2d3c217e 155382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 15539
7b7f97e8 15540 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
15541 * buffer.c (Qclone_number): Remove for now, as it's unused.
15542 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
15543 (record_buffer): Remove unused local.
15544 * frame.c (other_visible_frames, frame_buffer_list): Now static.
15545 (set_frame_buffer_list): Remove; unused.
15546 * frame.h (other_visible_frames): Remove decl.
15547 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
15548 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
15549 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
15550 if HAVE_GPM.
15551 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
15552 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
15553 Define only if HAVE_GPM.
15554 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
15555 (update_hints_inhibit): Remove; never set. All uses removed.
15556 * widgetprv.h (emacsFrameClassRec): Remove decl.
15557 * window.c (delete_deletable_window): Now returns void, since it
15558 wasn't returning anything.
15559 (compare_window_configurations): Remove unused locals.
15560 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
15561 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
15562 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
15563 the same widths as pointers. This follows up on the 2011-05-06 patch.
15564 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
15565 * xterm.h: Likewise.
15566 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
15567
1384b89e
JB
155682011-06-12 Juanma Barranquero <lekktu@gmail.com>
15569
15570 * makefile.w32-in: Update dependencies.
15571 (LISP_H): Add lib/intprops.h.
15572
1100a63c
CY
155732011-06-11 Chong Yidong <cyd@stupidchicken.com>
15574
15575 * image.c (gif_load): Add animation frame delay to the metadata.
15576 (syms_of_image): Use DEFSYM. New symbol `delay'.
15577
6198ccd0
MR
155782011-06-11 Martin Rudalics <rudalics@gmx.at>
15579
15580 * window.c (delete_deletable_window): Re-add.
15581 (Fset_window_configuration): Rewrite to handle dead buffers and
15582 consequently deletable windows.
15583 (window_tree, Fwindow_tree): Remove. Supply functionality in
15584 window.el.
15585 (compare_window_configurations): Simplify code.
15586
b6e3633c
AS
155872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
15588
1ab0dee5
AS
15589 * image.c (imagemagick_load_image): Fix type mismatch.
15590 (Fimagemagick_types): Likewise.
15591
b6e3633c
AS
15592 * window.h (replace_buffer_in_windows): Declare.
15593
9397e56f
MR
155942011-06-11 Martin Rudalics <rudalics@gmx.at>
15595
15596 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
15597 Qclone_number. Remove external declaration of Qdelete_window.
15598 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
15599 code.
640c8776
SM
15600 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
15601 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
15602 (Fother_buffer): Rewrite doc-string. Major rewrite for new
15603 buffer list implementation.
15604 (other_buffer_safely): New function.
15605 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
15606 calls to replace_buffer_in_windows and
15607 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
15608 if allowed.
15609 (record_buffer): Inhibit quitting and rewrite using quittable
15610 functions. Run Qbuffer_list_update_hook if allowed.
15611 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
15612 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
15613 Move switch-to-buffer to window.el.
9397e56f
MR
15614 (bury-buffer): Move to window.el.
15615 (Vbuffer_list_update_hook): New variable.
15616
15617 * lisp.h (other_buffer_safely): Add prototype in buffer.c
15618 section.
15619
15620 * window.h (resize_frame_windows): Move up in code.
15621 (Fwindow_frame): Remove EXFUN.
15622 (replace_buffer_in_all_windows): Remove prototype.
15623 (replace_buffer_in_windows_safely): Add prototype.
15624
15625 * window.c: Declare Qdelete_window static again. Move down
15626 declaration of select_count.
15627 (Fnext_window, Fprevious_window): Rewrite doc-strings.
15628 (Fother_window): Move to window.el.
15629 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
15630 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
15631 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
15632 window.el.
15633 (replace_buffer_in_windows): Implement by calling
15634 Qreplace_buffer_in_windows.
15635 (replace_buffer_in_all_windows): Remove with some functionality
15636 moved into replace_buffer_in_windows_safely.
15637 (replace_buffer_in_windows_safely): New function.
15638 (select_window_norecord, select_frame_norecord): Move in front
15639 of run_window_configuration_change_hook. Remove now obsolete
15640 declarations.
640c8776
SM
15641 (Fset_window_buffer): Rewrite doc-string.
15642 Call Qrecord_window_buffer.
9397e56f
MR
15643 (keys_of_window): Move binding for other-window to window.el.
15644
b50691aa
CY
156452011-06-11 Chong Yidong <cyd@stupidchicken.com>
15646
15647 * dispextern.h (struct image): Replace data member, whose int_val
15648 and ptr_val fields were not used by anything, with a single
15649 lisp_val object.
15650
15651 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
15652 (gif_clear_image, gif_load, imagemagick_load_image)
15653 (gs_clear_image, gs_load): Callers changed.
15654
3f754b86
PE
156552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
15656
cca69397
PE
15657 * buffer.h: Include <time.h>, for time_t.
15658 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
15659
109e28d0
PE
15660 Fix minor problems found by static checking.
15661
60737f02
PE
15662 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
15663
4b66faf3
PE
15664 Make identifiers static if they are not used in other modules.
15665 * data.c (Qcompiled_function, Qframe, Qvector):
15666 * image.c (QimageMagick, Qsvg):
15667 * minibuf.c (Qmetadata):
15668 * window.c (resize_window_check, resize_root_window): Now static.
15669 * window.h (resize_window_check, resize_root_window): Remove decls.
15670
109e28d0
PE
15671 * window.c (window_deletion_count, delete_deletable_window):
15672 Remove; unused.
46a4ce9e
PE
15673 (window_body_lines): Now static.
15674 (Fdelete_other_windows_internal): Mark vars as initialized.
15675 Make sure 'resize_failed' is initialized.
15676 (run_window_configuration_change_hook): Rename local to avoid shadowing.
15677 (resize_window_apply): Remove unused local.
15678 * window.h (delete_deletable_window): Remove decl.
15679
109e28d0 15680 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
15681 (imagemagick_load_image): Fix pointer signedness problem by changing
15682 last arg from unsigned char * to char *. All uses changed.
15683 Also, fix a local for similar reasons.
15684 Remove unused locals. Remove locals to avoid shadowing.
15685 (fn_rsvg_handle_free): Remove; unused.
15686 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 15687 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 15688
3f754b86
PE
15689 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
15690
2547adb1
CY
156912011-06-10 Chong Yidong <cyd@stupidchicken.com>
15692
15693 * image.c (gif_load): Fix omitted cast error introduced by
15694 2011-06-06 change.
15695
2c8e37d4
MR
156962011-06-10 Martin Rudalics <rudalics@gmx.at>
15697
15698 * window.h (resize_proportionally, orig_total_lines)
15699 (orig_top_line): Remove from window structure.
15700 (set_window_height, set_window_width, change_window_heights)
15701 (Fdelete_window): Remove prototypes.
15702 (resize_frame_windows): Remove duplicate declaration.
15703
440a42e3
EZ
157042011-06-10 Eli Zaretskii <eliz@gnu.org>
15705
15706 * window.h (resize_frame_windows, resize_window_check)
15707 (delete_deletable_window, resize_root_window)
15708 (resize_frame_windows): Declare prototypes.
15709
15710 * window.c (resize_window_apply): Make definition be "static" to
15711 match the prototype.
15712
562dd5e9
MR
157132011-06-10 Martin Rudalics <rudalics@gmx.at>
15714
15715 * window.c: Remove declarations of Qwindow_size_fixed,
15716 window_min_size_1, window_min_size_2, window_min_size,
15717 size_window, window_fixed_size_p, enlarge_window, delete_window.
15718 Remove static from declaration of Qdelete_window, it's
15719 temporarily needed by Fbury_buffer.
15720 (replace_window): Don't assign orig_top_line and
15721 orig_total_lines.
15722 (Fdelete_window, delete_window): Remove. Window deletion is
15723 handled by window.el.
640c8776
SM
15724 (window_loop): Remove DELETE_OTHER_WINDOWS case.
15725 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
15726 (Fdelete_other_windows): Remove. Deleting other windows is
15727 handled by window.el.
15728 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
15729 handled in window.el.
15730 (window_min_size_2, window_min_size_1, window_min_size): Remove.
15731 Window minimum sizes are handled in window.el.
15732 (shrink_windows, size_window, set_window_height)
15733 (set_window_width, change_window_heights, window_height)
15734 (window_width, CURBEG, CURSIZE, enlarge_window)
15735 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
15736 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
15737 handled in window.el.
15738 (make_dummy_parent): Rename to make_parent_window and give it a
15739 second argument horflag.
15740 (make_window): Don't set resize_proportionally any more.
15741 (Fsplit_window): Remove. Windows are split in window.el.
15742 (save_restore_action, save_restore_orig_size)
15743 (shrink_window_lowest_first, save_restore_orig_size): Remove.
15744 Resize mini windows in window.el.
15745 (grow_mini_window, shrink_mini_window): Implement by calling
15746 Qresize_root_window_vertically, resize_window_check and
15747 resize_window_apply.
640c8776
SM
15748 (saved_window, Fset_window_configuration, save_window_save):
15749 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
15750 resize_proportionally.
15751 (window_min_height, window_min_width): Move to window.el.
15752 (keys_of_window): Move bindings for delete-other-windows,
15753 split-window, delete-window and enlarge-window to window.el.
15754
15755 * buffer.c: Temporarily extern Qdelete_window.
15756 (Fbury_buffer): Temporarily call Qdelete_window instead of
15757 Fdelete_window (Fbury_buffer will move to window.el soon).
15758
15759 * frame.c (set_menu_bar_lines_1): Remove code handling
15760 orig_top_line and orig_total_lines.
15761
15762 * dispnew.c (adjust_frame_glyphs_initially): Don't use
15763 set_window_height but set heights directly.
15764 (change_frame_size_1): Use resize_frame_windows.
15765
15766 * xdisp.c (init_xdisp): Don't use set_window_height but set
15767 heights directly.
15768
640c8776
SM
15769 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
15770 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
15771 run_window_configuration_change_hook.
15772
15773 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
15774 instead of change_window_heights and run
15775 run_window_configuration_change_hook.
15776
1a13852e
MR
157772011-06-09 Martin Rudalics <rudalics@gmx.at>
15778
15779 * window.c (replace_window): Rename second argument REPLACEMENT to
15780 NEW. New third argument SETFLAG. Rewrite.
15781 (delete_window, make_dummy_parent): Call replace_window with
15782 third argument 1.
15783 (window_list_1): Move down in code.
15784 (run_window_configuration_change_hook): Move set_buffer part
15785 before select_frame_norecord part in order to unwind correctly.
15786 Rename count1 to count.
15787 (recombine_windows, delete_deletable_window, resize_root_window)
15788 (Fdelete_other_windows_internal)
15789 (Frun_window_configuration_change_hook, make_parent_window)
15790 (resize_window_check, resize_window_apply, Fresize_window_apply)
15791 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
15792 (Fdelete_window_internal, Fresize_mini_window_internal):
15793 New functions.
1a13852e
MR
15794 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
15795
f3d1777e
MR
157962011-06-08 Martin Rudalics <rudalics@gmx.at>
15797
496e208e
MR
15798 * window.h (window): Add some new members to window structure -
15799 normal_lines, normal_cols, new_total, new_normal, clone_number,
15800 splits, nest, prev_buffers, next_buffers.
15801 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 15802 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 15803
f3d1777e
MR
15804 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
15805 Remove.
496e208e
MR
15806 (make_dummy_parent): Set new members of windows structure.
15807 (make_window): Move down in code. Handle new members of window
15808 structure.
15809 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
15810 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
15811 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
15812 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
15813 (Fset_window_next_buffers, Fset_window_clone_number):
15814 New functions.
496e208e
MR
15815 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
15816 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
15817 Doc-string fixes.
15818 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
15819 Argument WINDOW can be now internal window too.
15820 (Fwindow_use_time): Move up in code.
15821 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
15822 Rewrite doc-string.
15823 (Fset_window_configuration, saved_window)
15824 (Fcurrent_window_configuration, save_window_save): Handle new
15825 members of window structure.
b9e809c2
MR
15826 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
15827 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
15828 (syms_of_window): New Lisp objects Qrecord_window_buffer,
15829 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
15830 Qget_mru_window, Qresize_root_window,
15831 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
15832 Qauto_buffer_name; staticpro them.
f3d1777e 15833
abde8f8c
MR
158342011-06-07 Martin Rudalics <rudalics@gmx.at>
15835
15836 * window.c (Fwindow_total_size, Fwindow_left_column)
15837 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
15838 (Fwindow_list_1): New functions.
15839 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
15840 (Fwindow_width, Fscroll_left, Fscroll_right):
15841 Use window_body_cols instead of window_box_text_cols.
15842 (delete_window, Fset_window_configuration):
15843 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
15844 (delete_all_subwindows): Take a window as argument and not a
15845 structure. Rewrite.
190b47e6
MR
15846 (window_loop): Remove handling of GET_LRU_WINDOW and
15847 GET_LARGEST_WINDOW.
15848 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
15849
15850 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
15851 window_box_text_cols. delete_all_subwindows now takes a
15852 Lisp_Object as argument.
abde8f8c 15853
640c8776
SM
15854 * indent.c (compute_motion, Fcompute_motion):
15855 Use window_body_cols instead of window_box_text_cols.
abde8f8c 15856
fa8a67e6
MR
15857 * frame.c (delete_frame): Call delete_all_subwindows with root
15858 window as argument.
15859
a54e3482
DC
158602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
15861
15862 * fns.c (Fputhash): Document return value.
15863
60002bf5
CY
158642011-06-06 Chong Yidong <cyd@stupidchicken.com>
15865
15866 * image.c (gif_load): Implement gif89a spec "no disposal" method.
15867
0c671da6 158682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 15869
b862a52a 15870 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 15871
be44ca6c
PE
15872 Check for overflow when converting integer to cons and back.
15873 * charset.c (Fdefine_charset_internal, Fdecode_char):
15874 Use cons_to_unsigned to catch overflow.
15875 (Fencode_char): Use INTEGER_TO_CONS.
15876 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
15877 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
15878 * data.c (long_to_cons, cons_to_long): Remove.
15879 (cons_to_unsigned, cons_to_signed): New functions.
15880 These signal an error for invalid or out-of-range values.
15881 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
15882 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
15883 * font.c (Ffont_variation_glyphs):
15884 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
15885 * lisp.h: Include <intprops.h>.
15886 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
15887 (cons_to_signed, cons_to_unsigned): New decls.
15888 (long_to_cons, cons_to_long): Remove decls.
15889 * undo.c (record_first_change): Use INTEGER_TO_CONS.
15890 (Fprimitive_undo): Use CONS_TO_INTEGER.
15891 * xfns.c (Fx_window_property): Likewise.
15892 * xselect.c: Include <limits.h>.
15893 (x_own_selection, selection_data_to_lisp_data):
15894 Use INTEGER_TO_CONS.
15895 (x_handle_selection_request, x_handle_selection_clear)
15896 (x_get_foreign_selection, Fx_disown_selection_internal)
15897 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
15898 (lisp_data_to_selection_data): Use cons_to_unsigned.
15899 (x_fill_property_data): Use cons_to_signed.
15900 Report values out of range.
15901
d1f3d2af
PE
15902 Check for buffer and string overflow more precisely.
15903 * buffer.h (BUF_BYTES_MAX): New macro.
15904 * lisp.h (STRING_BYTES_MAX): New macro.
15905 * alloc.c (Fmake_string):
15906 * character.c (string_escape_byte8):
15907 * coding.c (coding_alloc_by_realloc):
15908 * doprnt.c (doprnt):
15909 * editfns.c (Fformat):
15910 * eval.c (verror):
15911 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
15912 since they may not be the same number.
15913 * editfns.c (Finsert_char):
15914 * fileio.c (Finsert_file_contents):
15915 Likewise for BUF_BYTES_MAX.
15916
dd52fcea
PE
15917 * image.c: Use ptrdiff_t, not int, for sizes.
15918 (slurp_file): Switch from int to ptrdiff_t.
15919 All uses changed.
15920 (slurp_file): Check that file size fits in both size_t (for
15921 malloc) and ptrdiff_t (for sanity and safety).
15922
7f9bbdbb
PE
15923 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
15924 if b->modtime has its maximal value.
15925
dfe18f82
PE
15926 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
15927
84acfcf0
PE
15928 Don't assume time_t can fit into int.
15929 * buffer.h (struct buffer.modtime): Now time_t, not int.
15930 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
15931 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
15932
ccd9a01a
PE
15933 Minor fixes for signed vs unsigned integers.
15934 * character.h (MAYBE_UNIFY_CHAR):
15935 * charset.c (maybe_unify_char):
15936 * keyboard.c (read_char, reorder_modifiers):
15937 XINT -> XFASTINT, since the integer must be nonnegative.
15938 * ftfont.c (ftfont_spec_pattern):
15939 * keymap.c (access_keymap, silly_event_symbol_error):
15940 XUINT -> XFASTINT, since the integer must be nonnegative.
15941 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
15942 since it makes no difference and we prefer signed.
15943 * keyboard.c (record_char): Use XUINT when all the neighbors do.
15944 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
15945 nonnegative.
15946
d6d100dd
SM
159472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
15948
15949 * window.h (Fwindow_frame): Declare.
15950
2b6148e4
PE
159512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
15952
15953 * alloc.c: Simplify handling of large-request failures (Bug#8800).
15954 (SPARE_MEMORY): Always define.
15955 (LARGE_REQUEST): Remove.
15956 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
15957
f230ecc9
MR
159582011-06-06 Martin Rudalics <rudalics@gmx.at>
15959
727e958e
MR
15960 * lisp.h: Move EXFUNS for Fframe_root_window,
15961 Fframe_first_window and Fset_frame_selected_window to window.h.
15962
15963 * window.h: Move EXFUNS for Fframe_root_window,
15964 Fframe_first_window and Fset_frame_selected_window here from
15965 lisp.h.
15966
15967 * frame.c (Fwindow_frame, Fframe_first_window)
15968 (Fframe_root_window, Fframe_selected_window)
15969 (Fset_frame_selected_window): Move to window.c.
15970 (Factive_minibuffer_window): Move to minibuf.c.
15971 (Fother_visible_frames_p): New function.
15972
15973 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
15974
f230ecc9
MR
15975 * window.c (decode_window, decode_any_window): Move up in code.
15976 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
15977 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
15978 (Fwindow_buffer): Move up and rewrite doc-string.
15979 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
15980 (Fwindow_prev): New functions.
727e958e
MR
15981 (Fwindow_frame): Move here from frame.c. Accept any window as
15982 argument.
15983 (Fframe_root_window, Fframe_first_window)
15984 (Fframe_selected_window): Move here from frame.c. Accept frame
15985 or arbitrary window as argument. Update doc-strings.
15986 (Fminibuffer_window): Move up in code.
15987 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
15988 (Fset_frame_selected_window): Move here from frame.c.
15989 Marginal rewrite.
727e958e
MR
15990 (Fselected_window, select_window, Fselect_window): Move up in
15991 code. Minor doc-string fixes.
f230ecc9 15992
4d09bcf6
PE
159932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
15994
15995 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
15996 Do not assume that spare memory exists; that assumption is valid
15997 only if SYSTEM_MALLOC.
15998 (LARGE_REQUEST): New macro, so that the issue of large requests
15999 is separated from the issue of spare memory.
16000
810928a2
AS
160012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
16002
172418ad
AS
16003 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
16004 format. (Bug#8806)
16005
43f862f7
AS
16006 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
16007
810928a2
AS
16008 * xfns.c (x_set_scroll_bar_default_width): Move declarations
16009 before statements.
16010
a059fe24
JD
160112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
16012
16013 * gtkutil.c (xg_get_default_scrollbar_width): New function.
16014
16015 * gtkutil.h: Declare xg_get_default_scrollbar_width.
16016
16017 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
16018 min width by calling x_set_scroll_bar_default_width (Bug#8505).
16019
989bf368
JB
160202011-06-05 Juanma Barranquero <lekktu@gmail.com>
16021
16022 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
16023
4b80f674
CY
160242011-06-04 Chong Yidong <cyd@stupidchicken.com>
16025
16026 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
16027 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
16028 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
16029 New error handlers.
4b80f674
CY
16030 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
16031 Obey Vx_select_enable_clipboard_manager. Catch errors in
16032 x_clipboard_manager_save (Bug#8779).
16033 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 16034 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 16035
99a33b77 160362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
16037
16038 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
16039
99a33b77 160402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
16041
16042 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
16043 in the current matrix if keep_current_p is non-zero.
16044
8264569d
EZ
160452011-06-04 Eli Zaretskii <eliz@gnu.org>
16046
16047 * bidi.c (bidi_level_of_next_char): Fix last change.
16048
57f97249
EZ
160492011-06-03 Eli Zaretskii <eliz@gnu.org>
16050
fec2107c 16051 Support bidi reordering of text covered by display properties.
57f97249 16052
fec2107c
EZ
16053 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
16054 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
16055 (bidi_cache_search, bidi_cache_iterator_state)
16056 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
16057 (bidi_level_of_next_char, bidi_move_to_visually_next):
16058 Support character positions inside a run of characters covered by a
fec2107c
EZ
16059 display string.
16060 (bidi_paragraph_init, bidi_resolve_explicit_1)
16061 (bidi_level_of_next_char): Call bidi_fetch_char and
16062 bidi_fetch_char_advance instead of FETCH_CHAR and
16063 FETCH_CHAR_ADVANCE.
16064 (bidi_init_it): Initialize new members.
16065 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
16066 definitions.
16067 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
16068 instead of using explicit *_CHAR codes.
d6d100dd
SM
16069 (bidi_resolve_explicit, bidi_resolve_weak):
16070 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
16071 bidirectional text is supported only in multibyte buffers.
16072 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
16073 it to initialize the frame_window_p member of struct bidi_it.
16074 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
16075 (bidi_resolve_explicit, bidi_resolve_weak)
16076 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
16077 bidi_it->nchars is non-positive.
16078 (bidi_level_of_next_char): Don't try to lookup the cache for the
16079 next/previous character if nothing is cached there yet, or if we
16080 were just reseat()'ed to a new position.
c40e2fb2 16081
0e14fe90
EZ
16082 * xdisp.c (set_cursor_from_row): Set start and stop points
16083 according to the row's direction when priming the loop that looks
16084 for the glyph on which to display cursor.
16085 (single_display_spec_intangible_p): Function deleted.
16086 (display_prop_intangible_p): Reimplement to call
16087 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
16088 Accept 3 additional arguments needed by handle_display_spec.
16089 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
16090 values: lists, `(when COND...)' forms, etc.
16091 (single_display_spec_string_p): Support property values that are
16092 lists with the argument STRING its top-level element.
16093 (display_prop_string_p): Fix the condition for processing a
16094 property that is a list to be consistent with handle_display_spec.
fec2107c 16095 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
16096 last portion of handle_display_prop.
16097 (compute_display_string_pos): Accept additional argument
16098 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
16099 value of a `display' property is a "replacing spec".
16100 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
16101 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
16102 the display property, but just return a value indicating whether
16103 the display property will replace the characters it covers.
16104 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
16105 frame_window_p members of struct bidi_it.
d6d100dd
SM
16106 (compute_display_string_pos, compute_display_string_end):
16107 New functions.
fec2107c
EZ
16108 (push_it): Accept second argument POSITION, where pop_it should
16109 jump to continue iteration.
16110 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 16111
fec2107c
EZ
16112 * keyboard.c (adjust_point_for_property): Adjust the call to
16113 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
16114
16115 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
16116 (bidi_init_it): Update prototypes.
16117 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
16118 (compute_display_string_pos, compute_display_string_end):
16119 Declare prototypes.
fec2107c
EZ
16120 (struct bidi_it): New members nchars and disp_pos. ch_len is now
16121 EMACS_INT.
fc6f18ce 16122
40087514 161232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 16124
57f53182
PE
16125 Malloc failure behavior now depends on size of allocation.
16126 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
16127 * lisp.h: Change signatures accordingly.
16128 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
16129 All callers changed. (Bug#8762)
16130
16131 * gnutls.c: Use Emacs's memory allocators.
16132 Without this change, the gnutls library would invoke malloc etc.
16133 directly, which causes problems on non-SYNC_INPUT hosts, and which
16134 runs afoul of improving memory_full behavior. (Bug#8761)
16135 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
16136 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
16137 xfree instead of the default malloc, realloc, free.
16138 (Fgnutls_boot): No need to check for memory allocation failure,
16139 since xmalloc does that for us.
16140
ac32cd99 16141 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
16142 * category.c (hash_get_category_set):
16143 * ccl.c (ccl_driver):
16144 * charset.c (Fdefine_charset_internal):
16145 * charset.h (struct charset.hash_index):
16146 * composite.c (get_composition_id, gstring_lookup_cache)
16147 (composition_gstring_put_cache):
16148 * composite.h (struct composition.hash_index):
16149 * dispextern.h (struct image.hash):
16150 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
16151 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
16152 (hashfn_equal, hashfn_user_defined, make_hash_table)
16153 (maybe_resize_hash_table, hash_lookup, hash_put)
16154 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
16155 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
16156 (Fsxhash, Fgethash, Fputhash, Fmaphash):
16157 * image.c (make_image, search_image_cache, lookup_image)
16158 (xpm_put_color_table_h):
16159 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 16160 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 16161 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 16162 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
16163 * alloc.c (allocate_vectorlike):
16164 Check for overflow in vector size calculations.
16165 * ccl.c (ccl_driver):
16166 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
16167 * fns.c, image.c: Remove unnecessary static decls that would otherwise
16168 need to be updated by these changes.
40087514
PE
16169 * fns.c (make_hash_table, maybe_resize_hash_table):
16170 Check for integer overflow with large hash tables.
0de4bb68
PE
16171 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
16172 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
16173 (SXHASH_REDUCE): New macro.
16174 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
16175 Use it instead of discarding useful hash info with large hash values.
16176 (sxhash_float): New function.
16177 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
16178 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
16179 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
16180 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
16181 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
16182 Adjust signatures to match updated version of code.
16183 (consing_since_gc): Now EMACS_INT, since a single hash table can
16184 use more than INT_MAX bytes.
16185
698d32e2
DN
161862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
16187
16188 Make it possible to build with GCC-4.6+ -O2 -flto.
16189
16190 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
16191
fd6fa53f
SM
161922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
16193
16194 * minibuf.c (get_minibuffer, read_minibuf_unwind):
16195 Call minibuffer-inactive-mode.
16196
864db017
JB
161972011-05-31 Juanma Barranquero <lekktu@gmail.com>
16198
16199 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
16200 Update dependencies.
16201
2ad0baf4
DN
162022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
16203
16204 * data.c (init_data): Remove code for UTS, this system is not
16205 supported anymore.
16206
4fcc2638
DN
162072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
16208
16209 Don't force ./temacs to start in terminal mode.
16210
16211 * frame.c (make_initial_frame): Initialize faces in all cases, not
16212 only when CANNOT_DUMP is defined.
16213 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
16214
c56e0fd5
DN
162152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
16216
16217 * dispnew.c (add_window_display_history): Use const for the string
16218 pointer. Remove declaration, not needed.
16219
333d54da 162202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 16221
55d4c1b2 16222 Use 'inline', not 'INLINE'.
333d54da 16223 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
16224 * alloc.c, fontset.c (INLINE): Remove.
16225 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
16226 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
16227 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
16228 * gmalloc.c (register_heapinfo): Use inline unconditionally.
16229 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
16230
738db178
DN
162312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
16232
16233 Make it possible to run ./temacs.
16234
16235 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
16236 syms_of_callproc does the same thing. Remove test for
16237 "initialized", do it in the caller.
16238 * emacs.c (main): Avoid calling set_initial_environment when dumping.
16239
620c53a6
SM
162402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
16241
16242 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
16243 (read_minibuf): Use get_minibuffer.
16244 (syms_of_minibuf): Use DEFSYM.
16245 (Qmetadata): New var.
16246 * data.c (Qbuffer): Don't make it static.
16247 (syms_of_data): Use DEFSYM.
16248
e003a292
PE
162492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
16250
16251 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
16252 (CCL_CODE_MIN): New macro.
16253
ed008a6d
PE
162542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
16255
3687c2ef
PE
16256 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
16257
ed008a6d
PE
16258 * eval.c (Qdebug): Now static.
16259 * lisp.h (Qdebug): Remove decl. This reverts a part of the
16260 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
16261 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
16262
d66c4c7c
CY
162632011-05-29 Chong Yidong <cyd@stupidchicken.com>
16264
16265 * image.c: Various fixes to ImageMagick code comments.
16266 (Fimagemagick_types): Doc fix.
16267
5fbc2025
PE
162682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
16269
0196f88a
PE
16270 Minor fixes prompted by GCC 4.6.0 warnings.
16271
16272 * xselect.c (converted_selections, conversion_fail_tag): Now static.
16273
5fbc2025
PE
16274 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
16275 (x_clipboard_manager_save_all): Move extern decl to ...
16276 * xterm.h: ... here, so that it can be checked for consistency.
16277
1dd3c2d9
CY
162782011-05-29 Chong Yidong <cyd@stupidchicken.com>
16279
16280 * xselect.c (x_clipboard_manager_save_frame)
16281 (x_clipboard_manager_save_all): New functions.
16282 (Fx_clipboard_manager_save): Lisp function deleted.
16283
16284 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
16285 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
16286
16287 * xterm.h: Update prototype.
16288
5ba6571d
WX
162892011-05-28 William Xu <william.xwl@gmail.com>
16290
16291 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
16292 exiting (Bug#8239).
16293
3eaff834
JM
162942011-05-28 Jim Meyering <meyering@redhat.com>
16295
e1900994 16296 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
16297 * fns.c (to_uchar): Define.
16298 (crypto_hash_function): Use it to convert some newly-signed
16299 variables to unsigned, to avoid sign-extension bugs. For example,
16300 without this change, (md5 "truc") would evaluate to
16301 45723a2aff78ff4fff7fff1114760e62 rather than the expected
16302 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 16303 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 16304
0f6990a7
PE
163052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
16306
16307 Integer overflow fixes.
c8a9ca5a 16308
08686060
PE
16309 * dbusbind.c: Serial number integer overflow fixes.
16310 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
16311 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
16312 to hold a serial number that is too large for a fixnum.
16313 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16314 Check for serial numbers out of range. Decode any serial number
59568bf0 16315 that was so large that it became a float. (Bug#8722)
08686060 16316
2d1fc3c7
PE
16317 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
16318 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16319 Use XFASTINT rather than XUINT when numbers are nonnegative.
16320 (xd_append_arg, Fdbus_method_return_internal):
16321 (Fdbus_method_error_internal): Likewise. Also, for unsigned
16322 arguments, check that Lisp number is nonnegative, rather than
59568bf0 16323 silently wrapping negative numbers around. (Bug#8722)
30217ff0 16324 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 16325 (Bug#8722)
2d1fc3c7 16326
c8a9ca5a
PE
16327 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
16328
519e1d69
PE
16329 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
16330
6df6ae42 16331 ccl: Add integer overflow checks.
30569699
PE
16332 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
16333 (IN_INT_RANGE): New macros.
16334 (ccl_driver): Use them to check for integer overflow when
16335 decoding a CCL program. Many of the new checks are whether XINT (x)
16336 fits in int; it doesn't always, on 64-bit hosts. The new version
16337 doesn't catch all possible integer overflows, but it's an
847044ea 16338 improvement. (Bug#8719)
30569699 16339
c11285dc
PE
16340 * alloc.c (make_event_array): Use XINT, not XUINT.
16341 There's no need for unsigned here.
16342
fdccd48e
PE
16343 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
16344 This follows up to the 2011-05-06 change that substituted uintptr_t
16345 for EMACS_INT. This case wasn't caught back then.
16346
37910ab2
PE
16347 Rework Fformat to avoid integer overflow issues.
16348 * editfns.c: Include <float.h> unconditionally, as it's everywhere
16349 now (part of C89). Include <verify.h>.
16350 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
16351 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
16352 (Fformat): Avoid the prepass trying to compute sizes; it was only
16353 approximate and thus did not catch overflow reliably. Instead, walk
16354 through the format just once, formatting and computing sizes as we go,
16355 checking for integer overflow at every step, and allocating a larger
16356 buffer as needed. Keep track separately whether the format is
16357 multibyte. Keep only the most-recently calculated precision, rather
16358 than them all. Record whether each argument has been converted to
16359 string. Use EMACS_INT, not int, for byte and char and arg counts.
16360 Support field widths and precisions larger than INT_MAX. Avoid
16361 sprintf's undefined behavior with conversion specifications such as %#d
16362 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
16363 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
16364 formatting out-of-range floating point numbers with int
9173deec 16365 formats. (Bug#8668)
37910ab2 16366
2e6578fb
PE
16367 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
16368
0ae6bdee
PE
16369 * data.c: Avoid integer truncation in expressions involving floats.
16370 * data.c: Include <intprops.h>.
16371 (arith_driver): When there's an integer overflow in an expression
16372 involving floating point, convert the integers to floating point
16373 so that the resulting value does not suffer from catastrophic
16374 integer truncation. For example, on a 64-bit host (* 4
16375 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
16376 Do not rely on undefined behavior after integer overflow.
16377
de883a70
PE
16378 merge count_size_as_multibyte, parse_str_to_multibyte
16379 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 16380 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
16381 Check for integer overflow.
16382 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
16383 since it's now a duplicate of the other. This is more of
16384 a character than a buffer op, so better that it's in character.c.
16385 * fns.c, print.c: Adjust to above changes.
16386
2ff916cb
PE
163872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
16388
16389 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
16390
f1b54466
PE
163912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
16392
fb1ac845
PE
16393 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
16394 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
16395 (x_clipboard_manager_save): Now static.
16396 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
16397
f1b54466
PE
16398 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
16399 (crypto_hash_function): Now static.
16400 Fix pointer signedness problems. Avoid unnecessary initializations.
16401
a9f737ee
CY
164022011-05-27 Chong Yidong <cyd@stupidchicken.com>
16403
16404 * termhooks.h (Vselection_alist): Make it terminal-local.
16405
16406 * terminal.c (create_terminal): Initialize it.
16407
16408 * xselect.c: Support for clipboard managers.
16409 (Vselection_alist): Move to termhooks.h as terminal-local var.
16410 (LOCAL_SELECTION): New macro.
16411 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
16412 (symbol_to_x_atom): Remove gratuitous arg.
16413 (x_handle_selection_request, lisp_data_to_selection_data)
16414 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
16415 (x_own_selection, x_get_local_selection, x_convert_selection):
16416 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
16417 (some_frame_on_display): Delete unused function.
16418 (Fx_own_selection_internal, Fx_get_selection_internal)
16419 (Fx_disown_selection_internal, Fx_selection_owner_p)
16420 (Fx_selection_exists_p): New optional frame arg.
16421 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
16422 (x_handle_selection_clear): Don't treat other terminals with the
16423 same keyboard specially. Use the terminal-local Vselection_alist.
16424 (x_clear_frame_selections): Use Frun_hook_with_args.
16425
16426 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
16427
16428 * xterm.h: Add support for those atoms.
16429
e067f0c1
CY
164302011-05-26 Chong Yidong <cyd@stupidchicken.com>
16431
16432 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
16433 (converted_selections, conversion_fail_tag): New global variables.
16434 (x_selection_request_lisp_error): Free the above.
16435 (x_get_local_selection): Remove unnecessary code.
16436 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
16437 of converted selections stored in converted_selections.
16438 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
16439 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
16440 (x_convert_selection): New function.
16441 (x_handle_selection_event): Simplify.
16442 (x_get_foreign_selection): Don't ignore incoming requests while
16443 waiting for an answer; this will fail when we implement
16444 SAVE_TARGETS, and seems unnecessary anyway.
16445 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
16446 (Vx_sent_selection_functions): Doc fix.
16447
0f4aebc0
LL
164482011-05-26 Leo Liu <sdl.web@gmail.com>
16449
16450 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
16451
e61124cd
YM
164522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
16453
16454 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
16455
16456 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
16457 for fringe update if it has periodic bitmap.
ac389d0c 16458 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
16459 and fringe_bitmap_periodic_p.
16460
16461 * fringe.c (get_fringe_bitmap_data): New function.
16462 (draw_fringe_bitmap_1, update_window_fringes): Use it.
16463 (update_window_fringes): Record periodicity of fringe bitmap in glyph
16464 row. Mark glyph row for fringe update if periodicity changed.
16465
16466 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
16467 for fringe update unless it has periodic bitmap.
16468
f16d9837
KH
164692011-05-25 Kenichi Handa <handa@m17n.org>
16470
16471 * xdisp.c (get_next_display_element): Set correct it->face_id for
16472 a static composition.
16473
e1b90ef6
LL
164742011-05-24 Leo Liu <sdl.web@gmail.com>
16475
16476 * deps.mk (fns.o):
16477 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
16478
16479 * fns.c (crypto_hash_function, Fsha1): New function.
16480 (Fmd5): Use crypto_hash_function.
16481 (syms_of_fns): Add Ssha1.
16482
7400048f
PE
164832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
16484
16485 * gnutls.c: Remove unused macros.
16486 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
16487 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
16488 Remove macros that are defined and never used.
16489 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
16490
abb71cf4
CY
164912011-05-22 Chong Yidong <cyd@stupidchicken.com>
16492
16493 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
16494 (Fx_get_selection_internal): Minor cleanup.
16495 (Fx_own_selection_internal): Rename arguments for consistency with
16496 select.el.
16497
6307db39
PE
164982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
16499
16500 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
16501
f3d4e0a4
CY
165022011-05-22 Chong Yidong <cyd@stupidchicken.com>
16503
16504 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
16505
4d8ade89
YM
165062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
16507
16508 * dispnew.c (scrolling_window): Don't exclude the case that the
16509 last enabled row in the desired matrix touches the bottom boundary.
16510
32078c8d
GM
165112011-05-21 Glenn Morris <rgm@gnu.org>
16512
16513 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
16514 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
16515 and add some more files.
32078c8d 16516
7285dc67
EZ
165172011-05-20 Eli Zaretskii <eliz@gnu.org>
16518
16519 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
16520 report_file_error introduced by the change from 2011-05-07.
16521
89d1bd22
PE
165222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
16523
16524 * systime.h (Time): Define only if emacs is defined.
16525 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
16526 where the include path doesn't have X11/X.h by default. See
16527 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
16528
cd394be1 165292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
16530
16531 * composite.c (find_automatic_composition): Fix previous change.
16532
b9704ad9
GM
165332011-05-20 Glenn Morris <rgm@gnu.org>
16534
16535 * lisp.mk: New file, split from Makefile.in.
16536 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
16537 (shortlisp): Remove.
16538 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
16539
4a720484
GM
165402011-05-19 Glenn Morris <rgm@gnu.org>
16541
16542 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
16543 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
16544 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
16545 (lisp): Set the order to that of loadup.el.
16546 (shortlisp): Make it a copy of $lisp.
16547 (SOME_MACHINE_LISP): Remove.
16548 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
16549 Use just $shortlisp, not $SOME_MACHINE_LISP too.
16550
a28d4396
KH
165512011-05-18 Kenichi Handa <handa@m17n.org>
16552
16553 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
16554 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
16555 (find_automatic_composition): Mostly rewrite for efficiency.
16556
a2b1fa8e
JB
165572011-05-18 Juanma Barranquero <lekktu@gmail.com>
16558
16559 * makefile.w32-in: Update dependencies.
16560
8e1f5610
CS
165612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
16562
16563 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 16564 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 16565
7025ee00 165662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 16567
cdfa6eab
PE
16568 Fix some integer overflow issues, such as string length overflow.
16569
06d6db33
PE
16570 * insdel.c (count_size_as_multibyte): Check for string overflow.
16571
2b4560a8
PE
16572 * character.c (lisp_string_width): Check for string overflow.
16573 Use EMACS_INT, not int, for string indexes and lengths; in
16574 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
16575 the resulting string length overflows an EMACS_INT; instead,
16576 report a string overflow if no precision given. When checking for
16577 precision exhaustion, use a check that cannot possibly have
16578 integer overflow. (Bug#8675)
16579 * character.h (lisp_string_width): Adjust to new signature.
16580
cb93f9be
PE
16581 * alloc.c (string_overflow): New function.
16582 (Fmake_string): Use it. This doesn't change behavior, but saves
16583 a few bytes and will simplify future changes.
16584 * character.c (string_escape_byte8): Likewise.
16585 * lisp.h (string_overflow): New decl.
16586
1a1f3366
PE
16587 Fixups, following up to the user-interface timestamp change.
16588 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
16589 for UI timestamps, instead of unsigned long.
9fbd6841
PE
16590 * msdos.c (mouse_get_pos): Likewise.
16591 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
16592 * w32gui.h (Time): Define by including "systime.h" rather than by
16593 declaring it ourselves. (Bug#8664)
16594
d4e3e4d3
PE
16595 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
16596 * image.c (clear_image_cache): Likewise.
16597
f6a24d19
PE
16598 * term.c (term_mouse_position): Don't assume time_t wraparound.
16599
08dc5ae6
PE
16600 Be more systematic about user-interface timestamps.
16601 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
16602 and sometimes 'EMACS_UINT', to represent these timestamps.
16603 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
16604 This makes the code easier to follow, and makes it easier to catch
16605 integer overflow bugs such as Bug#8664.
16606 * frame.c (Fmouse_position, Fmouse_pixel_position):
16607 Use Time, not unsigned long, for user-interface timestamps.
16608 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
16609 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
16610 * keyboard.h (last_event_timestamp): Likewise.
16611 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
16612 * menu.h (xmenu_show): Likewise.
16613 * term.c (term_mouse_position): Likewise.
16614 * termhooks.h (struct input_event.timestamp): Likewise.
16615 (struct terminal.mouse_position_hook): Likewise.
16616 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
16617 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
16618 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
16619 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
16620 what it was before.
16621 * menu.h, termhooks.h: Include "systime.h", for Time.
16622
8e55734a
PE
16623 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
16624 Don't assume that the difference between two unsigned long values
16625 can fit into an integer. At this point, we know button_down_time
16626 <= event->timestamp, so the difference must be nonnegative, so
16627 there's no need to cast the result if double-click-time is
16628 nonnegative, as it should be; check that it's nonnegative, just in
16629 case. This bug is triggered when events are more than 2**31 ms
86db42d2 16630 apart (about 25 days). (Bug#8664)
8e55734a 16631
841f1b75 16632 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 16633 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 16634
3e26f69c
PE
16635 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
16636 that always fit in int. Use a sentinel instead of a counter, to
16637 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
16638 * frame.h (struct frame): Use int for menu_bar_items_used
16639 instead of EMACS_INT, since it always fits in int.
3e26f69c 16640
5cc152c0
PE
16641 * menu.c (grow_menu_items): Check for int overflow.
16642
d89eb65e
PE
16643 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
16644
5235bd3e
PE
16645 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
16646 Before, the code was not consistent. These values cannot exceed
16647 2**31 - 1 so there's no need to make them unsigned.
16648 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
16649 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
16650 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
16651 as modifiers.
16652 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
16653
bc827e23
PE
16654 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
16655 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
16656 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
16657 presumably because the widths might not match.
16658
78eb494e
PE
16659 * window.c (size_window): Avoid needless test at loop start.
16660
04f2d78b
CB
166612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
16662
16663 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
16664
d2fc7e3d 166652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
16666
16667 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
16668
d2fc7e3d 166692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
16670
16671 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
16672 `width' to `bar_area_x' and `bar_area_width', respectively.
16673 (x_scroll_run): Take account of fringe background extension.
16674
04f2d78b
CB
16675 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
16676 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
16677 `bar_area_width', respectively.
16678 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
16679 background extension.
16680
79b70037
GM
166812011-05-10 Jim Meyering <meyering@redhat.com>
16682
16683 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
16684
2f142cc5
JB
166852011-05-10 Juanma Barranquero <lekktu@gmail.com>
16686
16687 * image.c (Finit_image_library): Return t for built-in image types,
16688 like pbm and xbm. (Bug#8640)
16689
57679c86
AS
166902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
16691
16692 * w32menu.c (set_frame_menubar): Fix submenu allocation.
16693
888c9e86
EZ
166942011-05-07 Eli Zaretskii <eliz@gnu.org>
16695
b0512a1d
EZ
16696 * w32console.c (Fset_screen_color): Doc fix.
16697 (Fget_screen_color): New function.
16698 (syms_of_ntterm): Defsubr it.
16699
7285dc67
EZ
16700 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
16701 unlink the temporary file if Fcall_process didn't create it in the
16702 first place.
16703 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
16704 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
16705 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
16706 cue to call_process_cleanup not to close that handle.
16707
4d3fcc8e
BK
167082011-05-07 Ben Key <bkey76@gmail.com>
16709
16710 * makefile.w32-in: The bootstrap-temacs rule now makes use of
16711 one of two shell specific rules, either bootstrap-temacs-CMD or
16712 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
16713 to the previous implementation of the bootstrap-temacs rule.
16714 The bootstrap-temacs-CMD rule is similar to the previous
16715 implementation of the bootstrap-temacs rule except that it
16716 makes use of the ESC_CFLAGS variable instead of the CFLAGS
16717 variable.
16718
16719 These changes, along with some changes to nt/configure.bat,
16720 nt/gmake.defs, and nt/nmake.defs, are required to extend my
16721 earlier fix to add support for --cflags and --ldflags options
16722 that include quotes so that it works whether make uses cmd or
16723 sh as the shell.
16724
b4289b64
MA
167252011-05-06 Michael Albinus <michael.albinus@gmx.de>
16726
16727 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
16728 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
16729 is a constant.
16730 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
16731 a string. Handle both cases.
16732 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
16733 (Fdbus_register_method): Use Qinvalid_function.
16734
af4c0e28
JB
167352011-05-06 Juanma Barranquero <lekktu@gmail.com>
16736
16737 * makefile.w32-in: Update dependencies.
16738 (LISP_H): Add inttypes.h and stdin.h.
16739 (PROCESS_H): Add unistd.h.
16740
c51453d9
EZ
167412011-05-06 Eli Zaretskii <eliz@gnu.org>
16742
16743 * lread.c: Include limits.h (fixes the MS-Windows build broken by
16744 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
16745
8ff0ac3c 167462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 16747
4c4b566b
PE
16748 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
16749
aab2b9b5
PE
16750 * term.c (vfatal): Remove stray call to va_end.
16751 It's not needed and the C Standard doesn't allow it here anyway.
16752
c378da0b
PE
16753 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
16754 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
16755
288b08c7
PE
16756 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
16757 bytes.
16758
e3601888
PE
16759 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
16760
db6c0e74
PE
16761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
16762
dd5963ea
PE
16763 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
16764
88c9450f
PE
16765 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
16766
2f9442b8
PE
16767 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
16768
c032b5f8
PE
16769 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
16770 * charset.c (Fdefine_charset_internal): Don't initialize
16771 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 16772 32-bit int (Bug#8600).
a108c10b
PE
16773
16774 * lread.c (read_integer): Be more consistent with string-to-number.
16775 Use string_to_number to do the actual conversion; this avoids
16776 rounding errors and fixes some other screwups. Without this fix,
16777 for example, #x1fffffffffffffff was misread as -2305843009213693952.
16778 (digit_to_number): Move earlier, for benefit of read_integer.
16779 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 16780 not a digit in any supported base. (Bug#8602)
a108c10b 16781
ad5f9eea
PE
16782 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
16783
aec1708a
PE
16784 * dispnew.c (scrolling_window): Return 1 if we scrolled,
16785 to match comment at start of function. This also removes a
16786 GCC warning about overflow in a 32+64-bit port.
16787
47be4ab5
PE
16788 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
16789
371cac43
PE
16790 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
16791 Reported by Stefan Monnier in
16792 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
16793 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
16794 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 16795
d01a7826
PE
16796 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
16797 (EMACS_UINTPTR): Likewise, with uintptr_t.
16798
7fd47d5c
PE
16799 * lisp.h: Prefer 64-bit EMACS_INT if available.
16800 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
16801 on 32-bit hosts that have 64-bit int, so that they can access
16802 large files.
122b0c86
PE
16803 However, temporarily disable this change unless the temporary
16804 symbol WIDE_EMACS_INT is defined.
7fd47d5c 16805
8727937b
PE
16806 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
16807
8ac068ac
PE
16808 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
16809 This removes an assumption that EMACS_INT and long are the same
16810 width as pointers. The assumption is true for Emacs porting targets
16811 now, but we want to make other targets possible.
16812 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
16813 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
16814 In the rest of the code, change types of integers that hold casted
16815 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
16816 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
16817 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
16818 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
16819 No need to cast type when ORing.
16820 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
16821 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
16822 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
16823 assume EMACS_INT is the same width as char *.
16824 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
16825 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
16826 Remove no-longer-needed casts.
16827 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
16828 (xg_tool_bar_help_callback, xg_make_tool_item):
16829 Use EMACS_INTPTR to hold an integer
16830 that will be cast to void *; this can avoid a GCC warning
16831 if EMACS_INT is not the same width as void *.
16832 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
16833 * xdisp.c (display_echo_area_1, resize_mini_window_1):
16834 (current_message_1, set_message_1):
16835 Use a local to convert to proper width without a cast.
16836 * xmenu.c (dialog_selection_callback): Likewise.
16837
ede49d71
PE
16838 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
16839 Also, don't assume VALBITS / RAND_BITS is less than 5,
16840 and don't rely on undefined behavior when shifting a 1 left into
16841 the sign bit.
16842 * lisp.h (get_random): Change signature to match.
16843
2f30ecd0
PE
16844 * lread.c (hash_string): Use size_t, not int, for hash computation.
16845 Normally we prefer signed values; but hashing is special, because
16846 it's better to use unsigned division on hash table sizes so that
16847 the remainder is nonnegative. Also, size_t is the natural width
16848 for hashing into memory. The previous code used 'int', which doesn't
16849 retain enough info to hash well into very large tables.
16850 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
16851
2a866e7b
PE
16852 * dbusbind.c: Don't possibly lose pointer info when converting.
16853 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
16854 Use XPNTR rather than XHASH, so that the high-order bits of
16855 the pointer aren't lost when converting through void *.
16856
51639eac
PE
16857 * eval.c (Fautoload): Don't double-shift a pointer.
16858
92394119
PE
16859 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
16860
dbdb9a7c
JB
168612011-05-06 Juanma Barranquero <lekktu@gmail.com>
16862
16863 * gnutls.c (DEF_GNUTLS_FN):
16864 * image.c (DEF_IMGLIB_FN): Make function pointers static.
16865
db7a0b4f
AS
168662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
16867
16868 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
16869 marker. (Bug#8610)
16870
cd394be1 168712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
16872
16873 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
16874 New version that can reserve upto 2GB of heap space.
16875
f7ff1b0f 168762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
16877
16878 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
16879
639c109b
TZ
168802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
16881
16882 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
16883 `gnutls_certificate_set_x509_key_file'.
16884
d2127135
JB
168852011-05-05 Juanma Barranquero <lekktu@gmail.com>
16886
16887 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
16888 Update dependencies.
16889
e968f4f3
JB
168902011-05-04 Juanma Barranquero <lekktu@gmail.com>
16891
16892 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
16893 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
16894 Remove unused parameter `fildes'.
16895 * process.c (read_process_output, send_process): Don't pass it.
16896
84d358f0
JB
168972011-05-04 Juanma Barranquero <lekktu@gmail.com>
16898
16899 Fix previous change: the library cache is defined in w32.c.
16900 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
16901 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
16902
0898ca10
JB
169032011-05-04 Juanma Barranquero <lekktu@gmail.com>
16904
16905 Implement dynamic loading of GnuTLS on Windows.
16906
16907 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
16908 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
16909 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
16910 Declare.
16911
16912 * gnutls.c (Qgnutls_dll): Define.
16913 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
16914 (gnutls_*): Declare function pointers.
16915 (init_gnutls_functions): New function to initialize function pointers.
16916 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
16917 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
16918 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
16919 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
16920 (emacs_gnutls_write, emacs_gnutls_read)
16921 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
16922 (Fgnutls_available_p): New function.
16923 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
16924 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
16925 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
16926
16927 * image.c: Include w32.h.
16928 (Vimage_type_cache): Delete.
16929 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
16930 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
16931 (w32_delayed_load): Move to w32.c.
16932
16933 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
16934
16935 * w32.c (QCloaded_from, Vlibrary_cache): Define.
16936 (w32_delayed_load): Move from image.c. When loading a library, record
16937 its filename in the :loaded-from property of the library id.
16938 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
16939 Initialize and staticpro them.
16940 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
16941
16942 * process.c: Include lisp.h before w32.h, not after.
16943 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
16944 instead of gnutls_record_check_pending.
16945
16946 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
16947
ff4de4aa
TZ
169482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
16949
16950 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
16951 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
16952 as passed in.
16953
abe95abb
JD
169542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
16955
16956 * xterm.c (x_set_frame_alpha): Do not set property on anything
16957 else than FRAME_X_OUTER_WINDOW (Bug#8608).
16958
e16e55d4
JB
169592011-05-02 Juanma Barranquero <lekktu@gmail.com>
16960
16961 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
16962
bafcf6a5
JB
169632011-05-02 Juanma Barranquero <lekktu@gmail.com>
16964
16965 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
16966 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
16967 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
16968 (gnutls_global_initialized, Qgnutls_bootprop_priority)
16969 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
16970 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
16971 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
16972 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
16973 (Qgnutls_bootprop_callbacks_verify): Make static.
16974
e7a6747f
AS
169752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
16976
19ed11ba
AS
16977 * callproc.c: Indentation fixup.
16978
e7a6747f 16979 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
16980 (wait_for_termination, interruptible_wait_for_termination):
16981 Move after wait_for_termination_1.
e7a6747f 16982
1ef14cb4
LMI
169832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
16984
16985 * sysdep.c (interruptible_wait_for_termination): New function
16986 which is like wait_for_termination, but allows keyboard
16987 interruptions.
16988
16989 * callproc.c (Fcall_process): Add (:file "file") as an option for
16990 the STDOUT buffer.
16991 (Fcall_process_region): Ditto.
16992
330d880c
EZ
169932011-04-30 Eli Zaretskii <eliz@gnu.org>
16994
8db90b73
EZ
16995 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
16996 rather than `XVECTOR (FOO)->size'.
16997
330d880c
EZ
16998 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
16999 inttypes.h, as a gnulib replacement is used if it not available in
17000 system headers.
17001
15cbd324
EZ
170022011-04-21 Eli Zaretskii <eliz@gnu.org>
17003
17004 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
17005 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
17006 of MOST_POSITIVE_FIXNUM. (Bug#8528)
17007
17008 * coding.c (coding_alloc_by_realloc): Error out if destination
17009 will grow beyond MOST_POSITIVE_FIXNUM.
17010 (decode_coding_emacs_mule): Abort if there isn't enough place in
17011 charbuf for the composition carryover bytes. Reserve an extra
17012 space for up to 2 characters produced in a loop.
17013 (decode_coding_iso_2022): Abort if there isn't enough place in
17014 charbuf for the composition carryover bytes.
17015
170162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 17017
ae940cca
EZ
17018 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
17019 aborting when %lld or %lll format is passed.
17020 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
17021 %llo or %llx format is passed. (Bug#8545)
17022
03ab8921
EZ
17023 * window.c (window_scroll_line_based): Use a marker instead of
17024 simple variables to record original value of point. (Bug#7952)
17025
afda1437
EZ
17026 * doprnt.c (doprnt): Fix the case where a multibyte sequence
17027 produced by %s or %c overflows available buffer space. (Bug#8545)
17028
f76dee0c
PE
170292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
17030
17031 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 17032 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 17033
fdc5744d
JB
170342011-04-28 Juanma Barranquero <lekktu@gmail.com>
17035
17036 * w32.c (init_environment): Warn about defaulting HOME to C:\.
17037
638f053a
JB
170382011-04-28 Juanma Barranquero <lekktu@gmail.com>
17039
17040 * keyboard.c (Qdelayed_warnings_hook): Define.
17041 (command_loop_1): Run `delayed-warnings-hook'
17042 if Vdelayed_warnings_list is non-nil.
17043 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
17044 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
17045
d178f871
EZ
170462011-04-28 Eli Zaretskii <eliz@gnu.org>
17047
17048 * doprnt.c (doprnt): Don't return value smaller than the buffer
17049 size if the message was truncated. (Bug#8545).
17050
b124fd93
JB
170512011-04-28 Juanma Barranquero <lekktu@gmail.com>
17052
17053 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
17054 (Fx_window_property): #if-0 the whole functions, not just the bodies.
17055
e810457d
PE
170562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
17057
17058 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
17059
ea51cceb
JB
170602011-04-27 Juanma Barranquero <lekktu@gmail.com>
17061
17062 * makefile.w32-in: Update dependencies.
17063
94dcfacf
EZ
170642011-04-27 Eli Zaretskii <eliz@gnu.org>
17065
17066 Improve `doprnt' and its usage. (Bug#8545)
17067 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
17068 `format_end'. Remove support for %l as a conversion specifier.
17069 Don't use xrealloc. Improve diagnostics when the %l size modifier
17070 is used. Update the commentary.
17071
17072 * eval.c (verror): Simplify calculation of size_t.
17073
17074 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
17075 messages.
17076
f61f41d7
PE
170772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
17078
17079 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
17080 change.
17081
96fb4434
PE
170822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
17083
17084 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
17085 This makes this file independent of the recent pseudovector change.
17086
671875da 170872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 17088
69e9b5a3
PE
17089 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
17090
b5f869a7 17091 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 17092 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 17093 Remove unused local.
c8926152 17094 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 17095
841a1577 17096 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
17097 GCC 4.6.0 optimizes based on type-based alias analysis.
17098 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
17099 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
17100 != &v->size, and therefore "v->size = 1; b->size = 2; return
17101 v->size;" must therefore return 1. This assumption is incorrect
17102 for Emacs, since it type-puns struct Lisp_Vector * with many other
17103 types. To fix this problem, this patch adds a new type struct
f904488f 17104 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
17105 and pseudovectors, and helps optimizing compilers not get fooled
17106 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
17107 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
17108 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
17109 the size member.
eab3844f
PE
17110 (XSETPVECTYPE): Rewrite in terms of new macro.
17111 (XSETPVECTYPESIZE): New macro, specifying both type and size.
17112 This is a bit clearer, and further avoids the possibility of
17113 undesirable aliasing.
17114 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 17115 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
17116 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
17117 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
17118 (ASIZE): Now uses header.size rather than size.
17119 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
17120 to avoid the hassle of writing XVECTOR (foo)->header.size.
17121 (struct vectorlike_header): New type.
eab3844f
PE
17122 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
17123 object, to help avoid aliasing.
17124 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
17125 (SUBRP): Likewise, since Lisp_Subr is a special case.
17126 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
17127 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
17128 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 17129 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
17130 changed to be "header.size" and "header.next".
17131 * buffer.h (struct buffer): Likewise.
17132 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
17133 * frame.h (struct frame): Likewise.
17134 * process.h (struct Lisp_Process): Likewise.
17135 * termhooks.h (struct terminal): Likewise.
17136 * window.c (struct save_window_data, struct saved_window): Likewise.
17137 * window.h (struct window): Likewise.
17138 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
17139 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
17140 * buffer.c (init_buffer_once): Likewise.
17141 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
17142 special case.
17143 * process.c (Fformat_network_address): Use local var for size,
17144 for brevity.
17145
0df1eac5
PE
17146 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
17147
847ab9d1 17148 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
17149 * data.c (atof): Remove decl; no longer used or needed.
17150 (digit_to_number): Move to lread.c.
17151 (Fstring_to_number): Use new string_to_number function, to be
17152 consistent with how the Lisp reader treats infinities and NaNs.
17153 Do not assume that floating-point numbers represent EMACS_INT
17154 without losing information; this is not true on most 64-bit hosts.
17155 Avoid double-rounding errors, by insisting on integers when
17156 parsing non-base-10 numbers, as the documentation specifies.
17157 * lisp.h (string_to_number): New decl, replacing ...
17158 (isfloat_string): Remove.
bc0a5c13 17159 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 17160 (read1): Do not accept +. and -. as integers; this
452f4150
PE
17161 appears to have been a coding error. Similarly, do not accept
17162 strings like +-1e0 as floating point numbers. Do not report
17163 overflow for integer overflows unless the base is not 10 which
17164 means we have no simple and reliable way to continue.
17165 Break out the floating-point parsing into a new
17166 function string_to_number, so that Fstring_to_number parses
17167 floating point numbers consistently with the Lisp reader.
04f2d78b 17168 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
17169 (E_CHAR, EXP_INT): Remove, replacing with ...
17170 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
17171 (string_to_number): New function, replacing isfloat_string.
17172 This function checks for valid syntax and produces the resulting
17173 Lisp float number too. Rework it so that string-to-number
bc0a5c13 17174 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
17175 so that overflow for non-base-10 numbers is reported only when
17176 there's no portable and simple way to convert to floating point.
452f4150 17177
67769ffc
PE
17178 * textprop.c (set_text_properties_1): Rewrite for clarity,
17179 and to avoid GCC warning about integer overflow.
17180
c20db43f
PE
17181 * intervals.h (struct interval): Use EMACS_INT for members
17182 where EMACS_UINT might cause problems. See
17183 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
17184 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
17185 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
17186 All uses changed.
37aa2f85
PE
17187 (offset_intervals): Tell GCC not to worry about length overflow
17188 when negating a negative length.
c20db43f 17189
2538aa2f
PE
17190 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
17191 (overrun_check_free): Likewise.
17192
f2d3008d
PE
17193 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
17194 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
17195 word size.
17196
ec8df744
PE
17197 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
17198 (gnutls_make_error): Rename local to avoid shadowing.
17199 (gnutls_emacs_global_deinit): ifdef out; not used.
17200 (Fgnutls_boot): Use const for pointer to readonly storage.
17201 Comment out unused local. Fix pointer signedness problems.
17202
640ee02d
PE
17203 * lread.c (openp): Don't stuff size_t into an 'int'.
17204 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
17205 about possible signed overflow.
17206
6048fb2a
PE
17207 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
17208 (GDK_KEY_g): Don't define if already defined.
17209 (xg_prepare_tooltip): Avoid pointer signedness problem.
17210 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
17211
fa3c87e1
PE
17212 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
17213 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
17214
2172544b
PE
17215 * xfns.c (Fx_window_property): Simplify a bit,
17216 to make a bit faster and to avoid GCC 4.6.0 warning.
17217 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
17218
9b821a21
PE
17219 * fns.c (internal_equal): Don't assume size_t fits in int.
17220
3c616cfa
PE
17221 * alloc.c (compact_small_strings): Tighten assertion a little.
17222
c2982e87
PE
17223 Replace pEd with more-general pI, and fix some printf arg casts.
17224 * lisp.h (pI): New macro, generalizing old pEd macro to other
17225 conversion specifiers. For example, use "...%"pI"d..." rather
17226 than "...%"pEd"...".
17227 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 17228 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
17229 * alloc.c (check_pure_size): Don't overflow by converting size to int.
17230 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
17231 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
17232 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
17233 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
17234 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
17235 64-bit hosts.
17236 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
17237 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
17238 * print.c (safe_debug_print, print_object): Likewise.
17239 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
17240 to int.
6f04d126
PE
17241 Use pI instead of if-then-else-abort. Use %p to avoid casts,
17242 avoiding the 0 flag, which is not portable.
c2982e87
PE
17243 * process.c (Fmake_network_process): Use pI to avoid cast.
17244 * region-cache.c (pp_cache): Likewise.
17245 * xdisp.c (decode_mode_spec): Likewise.
17246 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
17247 behavior on 64-bit hosts with printf arg.
6f04d126 17248 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
17249 (x_stop_queuing_selection_requests): Likewise.
17250 (x_get_window_property): Don't truncate byte count to an 'int'
17251 when tracing.
0b432f21 17252
5e073ec7
PE
17253 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
17254 here, since it parses constructs like leading '-' and spaces,
17255 which are not wanted; and it overflows with large numbers.
17256 Instead, simply match F[0-9]+, which is what is wanted anyway.
17257
36372bf9
PE
17258 * alloc.c: Remove unportable assumptions about struct layout.
17259 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
17260 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
17261 (allocate_vectorlike, make_pure_vector): Use the new macros,
17262 plus offsetof, to remove unportable assumptions about struct layout.
17263 These assumptions hold on all porting targets that I know of, but
17264 they are not guaranteed, they're easy to remove, and removing them
17265 makes further changes easier.
17266
0b432f21
PE
17267 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
17268 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
17269 (string_overrun_cookie): Now const. Use initializers that
17270 don't formally overflow signed char, to avoid warnings.
000098c1
PE
17271 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
17272 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
17273 (allocate_buffer): Don't assume sizeof (struct buffer) is a
17274 multiple of sizeof (EMACS_INT); it need not be, if
17275 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 17276 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 17277
895009e1
JB
172782011-04-26 Juanma Barranquero <lekktu@gmail.com>
17279
17280 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
17281
6a7a1b0b
TZ
172822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
17283
17284 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 17285 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
17286 Reported by Paul Eggert <eggert@cs.ucla.edu>.
17287
841a1577 172882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
17289
17290 * lisp.h (Qdebug): List symbol.
895009e1 17291 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
17292 * keyboard.c (debug-on-event): New variable.
17293 (handle_user_signal): Break into debugger when debug-on-event
17294 matches the current signal symbol.
17295
f2d3ba6f
DN
172962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
17297
17298 * alloc.c (check_sblock, check_string_bytes)
17299 (check_string_free_list): Convert to standard C.
17300
42ce4c63
TZ
173012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
17302
17303 * w32.c (emacs_gnutls_push): Fix typo.
17304
825cd63c
EZ
173052011-04-25 Eli Zaretskii <eliz@gnu.org>
17306
fb11d64d
EZ
17307 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
17308 "cast to pointer from integer of different size".
17309
825cd63c
EZ
17310 Improve doprnt and its use in verror. (Bug#8545)
17311 * doprnt.c (doprnt): Document the set of format control sequences
17312 supported by the function. Use SAFE_ALLOCA instead of always
17313 using `alloca'.
17314
17315 * eval.c (verror): Don't limit the buffer size at size_max-1, that
17316 is one byte too soon. Don't use xrealloc; instead xfree and
17317 xmalloc anew.
17318
e061a11b
TZ
173192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
17320
17321 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
17322 callbacks stage.
17323
17324 * gnutls.c: Renamed global_initialized to
17325 gnutls_global_initialized. Added internals for the
17326 :verify-hostname-error, :verify-error, and :verify-flags
17327 parameters of `gnutls-boot' and documented those parameters in the
17328 docstring. Start callback support.
9173deec
JB
17329 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
17330 unless a fatal error occurred. Call gnutls_alert_send_appropriate
17331 on error. Return error code.
e061a11b
TZ
17332 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
17333 (emacs_gnutls_read): Likewise.
17334 (Fgnutls_boot): Return handshake error code.
17335 (emacs_gnutls_handle_error): New function.
17336 (wsaerror_to_errno): Likewise.
17337
17338 * w32.h (emacs_gnutls_pull): Add prototype.
17339 (emacs_gnutls_push): Likewise.
17340
17341 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
17342 (emacs_gnutls_push): Likewise.
17343
173442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
17345
17346 * process.c (wait_reading_process_output): Check if GnuTLS
17347 buffered some data internally if no FDs are set for TLS
17348 connections.
17349
17350 * makefile.w32-in (OBJ2): Add gnutls.$(O).
17351 (LIBS): Link to USER_LIBS.
17352 ($(BLD)/gnutls.$(0)): New target.
17353
fa6996bc
EZ
173542011-04-24 Eli Zaretskii <eliz@gnu.org>
17355
eb35682e
EZ
17356 * xdisp.c (handle_single_display_spec): Rename the
17357 display_replaced_before_p argument into display_replaced_p, to
17358 make it consistent with the commentary. Fix typos in the
17359 commentary.
17360
e2ad650c
EZ
17361 * textprop.c (syms_of_textprop): Remove dead code.
17362 (copy_text_properties): Delete obsolete commentary about an
17363 interface that was deleted long ago. Fix typos in the description
17364 of arguments.
17365
1b2de274
EZ
17366 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
17367 to changes in oldXMenu/XMenu.h from 2011-04-16.
17368 <menu_help_message, prev_menu_help_message>: Constify.
17369 (IT_menu_make_room): menu->help_text is now `const char **';
17370 adjust.
17371
17372 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
17373 to changes in oldXMenu/XMenu.h from 2011-04-16.
17374 (struct XMenu): Declare `help_text' `const char **'.
17375
17376 * xfaces.c <Qunspecified>: Make extern again.
17377
17378 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 17379 required by POSIX.
1b2de274 17380
762b15be
EZ
17381 * doc.c (get_doc_string): Improve the format passed to `error'.
17382
17383 * doprnt.c (doprnt): Improve commentary.
17384
17385 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
17386
17387 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
17388 them with etags.
17389
f1052e5d
EZ
17390 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
17391 changes in globals.h immediately force recompilation.
762b15be
EZ
17392 (TAGS): Depend on $(CURDIR)/m/intel386.h and
17393 $(CURDIR)/s/ms-w32.h.
17394 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 17395
fa6996bc
EZ
17396 * character.c (Fchar_direction): Function deleted.
17397 (syms_of_character): Don't defsubr it.
17398 <char-direction-table>: Deleted.
17399
e6c3da20
EZ
174002011-04-23 Eli Zaretskii <eliz@gnu.org>
17401
17402 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
17403 * doprnt.c: Include limits.h.
17404 (SIZE_MAX): New macro.
04f2d78b
CB
17405 (doprnt): Return a size_t value. 2nd arg is now size_t.
17406 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
17407 Improve overflow protection. Support `l' modifier for integer
17408 conversions. Support %l conversion. Don't assume an EMACS_INT
17409 argument for integer conversions and for %c.
17410
17411 * lisp.h (doprnt): Restore prototype.
17412
17413 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
17414 $(SRC)/character.h.
17415
17416 * Makefile.in (base_obj): Add back doprnt.o.
17417
17418 * deps.mk (doprnt.o): Add back prerequisites.
17419 (callint.o): Depend on character.h.
17420
17421 * eval.c (internal_lisp_condition_case): Include the handler
17422 representation in the error message.
17423 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
17424 when breaking from the loop.
17425
17426 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
17427
17428 * callint.c (Fcall_interactively): When displaying error message
17429 about invalid control letter, pass the character's codepoint, not
17430 a pointer to its multibyte form. Improve display of the character
17431 in octal and display also its hex code.
17432
17433 * character.c (char_string): Use %x to display the (unsigned)
17434 codepoint of an invalid character, to avoid displaying a bogus
17435 negative value.
17436
17437 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
17438 `error', not SYMBOL_NAME itself.
17439
17440 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
17441 character arguments to `error'.
17442
17443 * charset.c (check_iso_charset_parameter): Fix incorrect argument
17444 to `error' in error message about FINAL_CHAR argument. Make sure
17445 FINAL_CHAR is a character, and use %c when it is passed as
17446 argument to `error'.
17447
4ffd0d6b 174482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
17449
17450 * s/ms-w32.h (localtime): Redirect to sys_localtime.
17451
17452 * w32.c: Include <time.h>.
17453 (sys_localtime): New function.
17454
4ffd0d6b 174552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
17456
17457 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
17458
4ffd0d6b 17459 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 17460
4ffd0d6b 174612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 17462
4ffd0d6b
GM
17463 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
17464 zombies (Bug#8467).
aac0c6e3 17465
04c56954
EZ
174662011-04-19 Eli Zaretskii <eliz@gnu.org>
17467
17468 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
17469 gl_state.e_property when gl_state.object is Qt.
17470
17471 * insdel.c (make_gap_larger): Remove limitation of buffer size
17472 to <= INT_MAX.
17473
16a43933
CY
174742011-04-18 Chong Yidong <cyd@stupidchicken.com>
17475
17476 * xdisp.c (lookup_glyphless_char_display)
17477 (produce_glyphless_glyph): Handle cons cell entry in
17478 glyphless-char-display.
17479 (Vglyphless_char_display): Document it.
17480
17481 * term.c (produce_glyphless_glyph): Handle cons cell entry in
17482 glyphless-char-display.
17483
4581706e
CY
174842011-04-17 Chong Yidong <cyd@stupidchicken.com>
17485
17486 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
17487
17488 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
17489
17490 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
17491 definition for no-X builds.
17492
4887c6e2 174932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 17494
fd35b6f9
PE
17495 Static checks with GCC 4.6.0 and non-default toolkits.
17496
5c1ccb01
PE
17497 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
17498
006c5daa
PE
17499 * process.c (keyboard_bit_set): Define only if SIGIO.
17500 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
17501 (send_process): Repair possible setjmp clobbering.
17502
efc736d3
PE
17503 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
17504
4e2fe2e6
PE
17505 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
17506
f97334a2
PE
17507 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
17508
4e75f29d
PE
17509 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
17510 Define only if needed.
17511
90efadd1
PE
17512 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
17513 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 17514 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 17515
3c647824
PE
17516 * dispextern.h (struct redisplay_interface): Rename param
17517 to avoid shadowing.
e264f262 17518 * termhooks.h (struct terminal): Likewise.
761383f4 17519 * xterm.c (xembed_send_message): Likewise.
3c647824 17520
b58c5c4a
PE
17521 * insdel.c (make_gap_smaller): Define only if
17522 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
17523
cad59032
PE
17524 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
17525 it.
17526
c339dc2e
PE
17527 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
17528 so that we aren't warned about unused symbols.
17529
91a3e27b
PE
17530 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
17531
399c71d3 17532 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 17533
8ffc96f5
PE
17534 * xfns.c (x_real_positions): Mark locals as initialized.
17535
eef9bc79
PE
17536 * xmenu.c (xmenu_show): Don't use uninitialized vars.
17537
098db9dd
PE
17538 * xterm.c: Fix problems found by static analysis with other toolkits.
17539 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
17540 (x_dispatch_event): Declare static if USE_GTK, and
17541 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 17542 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 17543 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
17544 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
17545 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 17546
eb18f6cc
PE
17547 * xmenu.c (menu_help_callback): Pointer type fixes.
17548 Use const pointers when pointing at readonly data. Avoid pointer
17549 signedness clashes.
17550 (FALSE): Remove unused macro.
17551 (update_frame_menubar): Remove unused decl.
17552
1fe72bf8
PE
17553 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
17554
60d9e1db
PE
17555 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
17556 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
17557 (single_menu_item): Rename local to avoid shadowing.
17558
39261c26
PE
17559 * keyboard.c (make_lispy_event): Remove unused local var.
17560
018c5e19
PE
17561 * frame.c, frame.h (x_get_resource_string): Bring this back, but
17562 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
17563
63d2b86e
PE
17564 * bitmaps: Change bitmaps from unsigned char back to the X11
17565 compatible char. Avoid the old compiler warnings about
17566 out-of-range initializers by using, for example, '\xab' rather
17567 than 0xab.
17568
aefd87e1
PE
17569 * xgselect.c (xgselect_initialize): Check vs interface
17570 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
17571
bf501fb9
PE
17572 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
17573
e9829fdf
PE
17574 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
17575 to read-only memory.
17576
1086c095
PE
17577 * fns.c (vector): Remove; this old hack is no longer needed.
17578
2baccd04 17579 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 17580 Remove unused var.
dde42981 17581 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 17582
72391843 17583 * xrdb.c (x_load_resources): Omit unused local.
3565b346 17584
436c16df 17585 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 17586 (x_window): Rename locals to avoid shadowing.
dc5ddd85 17587 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 17588
92bb796d 17589 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 17590 (x_term_init): Remove local to avoid shadowing.
92bb796d 17591
764430a3 17592 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
17593
17594 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
17595 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
17596
d1dfb56c
EZ
175972011-04-16 Eli Zaretskii <eliz@gnu.org>
17598
c4354cb4
EZ
17599 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
17600
d1dfb56c
EZ
17601 Fix regex.c, syntax.c and friends for buffers > 2GB.
17602 * syntax.h (struct gl_state_s): Declare character position members
17603 EMACS_INT.
17604
17605 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
17606
04f2d78b
CB
17607 * textprop.c (verify_interval_modification, interval_of):
17608 Declare arguments EMACS_INT.
d1dfb56c
EZ
17609
17610 * intervals.c (adjust_intervals_for_insertion): Declare arguments
17611 EMACS_INT.
17612
17613 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
17614
17615 * indent.c (Fvertical_motion): Local variable it_start is now
17616 EMACS_INT.
17617
17618 * regex.c (re_match, re_match_2, re_match_2_internal)
17619 (bcmp_translate, regcomp, regexec, print_double_string)
17620 (group_in_compile_stack, re_search, re_search_2, regex_compile)
17621 (re_compile_pattern, re_exec): Declare arguments and local
17622 variables `size_t' and `ssize_t' and return values `regoff_t', as
17623 appropriate.
17624 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
17625 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
17626 <compile_stack_type>: `size' and `avail' are now `size_t'.
17627
17628 * regex.h <regoff_t>: Use ssize_t, not int.
17629 (re_search, re_search_2, re_match, re_match_2): Arguments that
17630 specify buffer/string position and length are now ssize_t and
17631 size_t. Return type is regoff_t.
17632
613052cd
BK
176332011-04-16 Ben Key <bkey76@gmail.com>
17634
17635 * nsfont.m: Fixed bugs in ns_get_family and
17636 ns_descriptor_to_entity that were caused by using free to
17637 deallocate memory blocks that were allocated by xmalloc (via
17638 xstrdup). This caused Emacs to crash when compiled with
17639 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
17640 --enable-checking=xmallocoverrun). xfree is now used to
17641 deallocate these memory blocks.
17642
4170f62f 176432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 17644
71b41406
PE
17645 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
17646
9587a89d
PE
17647 emacs_write: Accept and return EMACS_INT for sizes.
17648 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
17649 et seq.
17650 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
17651 Accept and return EMACS_INT.
17652 (emacs_gnutls_write): Return the number of bytes written on
17653 partial writes.
17654 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
17655 (emacs_read, emacs_write): Remove check for negative size, as the
17656 Emacs source code has been audited now.
9587a89d
PE
17657 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
17658 (emacs_read, emacs_write): Use it.
273a5f82
PE
17659 * process.c (send_process): Adjust to the new signatures of
17660 emacs_write and emacs_gnutls_write. Do not attempt to store
17661 a byte offset into an 'int'; it might overflow.
9587a89d 17662 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 17663
3e047f51
PE
17664 * sound.c: Don't assume sizes fit in 'int'.
17665 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 17666 Return EMACS_INT, not int.
3e047f51 17667 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
17668 Accept EMACS_INT, not int.
17669 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
17670 record read return values.
17671
cc39a9db
BK
176722011-04-15 Ben Key <bkey76@gmail.com>
17673
c9d0ec6d
JB
17674 * keyboard.c (Qundefined): Don't declare static since it is used
17675 in nsfns.m.
17676 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
17677 static since they are used in nsfont.m.
cc39a9db 17678
6c60eb9f
SM
176792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
17680
17681 * process.c (Qprocessp): Don't declare static.
17682 * lisp.h (Qprocessp): Declare again.
17683
7990b61a
JB
176842011-04-15 Juanma Barranquero <lekktu@gmail.com>
17685
17686 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
17687
5d4cb038
PE
176882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
17689
8bd7b830 17690 Improve C-level modularity by making more things 'static'.
cd64ea1d 17691
e3b27b31
PE
17692 Don't publish debugger-only interfaces to other modules.
17693 * lisp.h (safe_debug_print, debug_output_compilation_hack):
17694 (verify_bytepos, count_markers): Move decls to the only modules
17695 that need them.
17696 * region-cache.h (pp_cache): Likewise.
17697 * window.h (check_all_windows): Likewise.
17698 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
17699
5d4cb038
PE
17700 * sysdep.c (croak): Now static, if
17701 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
17702 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
17703
17704 * alloc.c (refill_memory_reserve): Now static if
17705 !defined REL_ALLOC || defined SYSTEM_MALLOC.
17706 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 17707
e87b6180
PE
17708 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
17709 Define only if USE_LUCID.
17710
ac64929e
PE
17711 * xrdb.c (x_customization_string, x_rm_string): Now static.
17712
6f37259d
PE
17713 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
17714 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
17715
1683e3ab
PE
17716 * xdisp.c (draw_row_with_mouse_face): Now static.
17717 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
17718
de9c2632
PE
17719 * window.h (check_all_windows): Mark externally visible.
17720
2b96acb7
PE
17721 * window.c (window_deletion_count): Now static.
17722
17723 * undo.c: Make symbols static if they're not exported.
17724 (last_undo_buffer, last_boundary_position, pending_boundary):
17725 Now static.
17726
50436f33
PE
17727 * textprop.c (interval_insert_behind_hooks): Now static.
17728 (interval_insert_in_front_hooks): Likewise.
17729
64520e5c
PE
17730 * term.c: Make symbols static if they're not exported.
17731 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
17732 (max_frame_lines, tty_set_terminal_modes):
17733 (tty_reset_terminal_modes, tty_turn_off_highlight):
17734 (get_tty_terminal): Now static.
17735 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
17736 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 17737 HAVE_WINDOW_SYSTEM.
64520e5c
PE
17738 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
17739 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
17740
1fa53021
PE
17741 * sysdep.c: Make symbols static if they're not exported.
17742 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
17743 Now static.
17744 (sigprocmask_set, full_mask): Remove; unused.
17745 (wait_debugging): Mark as visible.
17746 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
17747 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
17748
d4b43b22
PE
17749 * syntax.c (syntax_temp): Define only if !__GNUC__.
17750
b7c513d0
PE
17751 * sound.c (current_sound_device, current_sound): Now static.
17752
989b29ad
PE
17753 * search.c (searchbufs, searchbuf_head): Now static.
17754
13a55a78
PE
17755 * scroll.c (scroll_cost): Remove; unused.
17756 * dispextern.h (scroll_cost): Remove decl.
17757
de68a1fc
PE
17758 * region-cache.h (pp_cache): Mark as externally visible.
17759
40ccffa6
PE
17760 * process.c: Make symbols static if they're not exported.
17761 (process_tick, update_tick, create_process, chan_process):
17762 (Vprocess_alist, proc_buffered_char, datagram_access):
17763 (fd_callback_data, send_process_frame, process_sent_to): Now static.
17764 (deactivate_process): Mark defn as static, as well as decl.
17765 * lisp.h (create_process): Remove decl.
17766 * process.h (chan_process, Vprocess_alist): Remove decls.
17767
ad64fc97
PE
17768 * print.c: Make symbols static if they're not exported.
17769 (print_depth, new_backquote_output, being_printed, print_buffer):
17770 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
17771 (print_interval, print_number_index, initial_stderr_stream):
17772 Now static.
17773 * lisp.h (Fprinc): Remove decl.
17774 (debug_output_compilation_hack): Mark as externally visible.
17775
adddb265
PE
17776 * sysdep.c (croak): Move decl from here to syssignal.h.
17777 * syssignal.h (croak): Put it here, so the API can be checked when
17778 'croak' is called from dissociate_if_controlling_tty.
17779
1717ede2
PE
17780 * minibuf.c: Make symbols static if they're not exported.
17781 (minibuf_save_list, choose_minibuf_frame): Now static.
17782 * lisp.h (choose_minibuf_frame): Remove decl.
17783
fa5fb2bc
PE
17784 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
17785
1e3890d1
PE
17786 * lread.c: Make symbols static if they're not exported.
17787 (read_objects, initial_obarray, oblookup_last_bucket_number):
17788 Now static.
17789 (make_symbol): Remove; unused.
17790 * lisp.h (initial_obarray, make_symbol): Remove decls.
17791
8a1414fa
PE
17792 * keyboard.c: Make symbols static if they're not exported.
17793 (single_kboard, recent_keys_index, total_keys, recent_keys):
17794 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
17795 (this_single_command_key_start, echoing, last_auto_save):
17796 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
17797 (command_loop, echo_now, keyboard_init_hook, help_char_p):
17798 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
17799 (Vlispy_mouse_stem, double_click_count):
17800 Now static.
17801 (force_auto_save_soon): Define only if SIGDANGER.
17802 (ignore_mouse_drag_p): Now static if
17803 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
17804 (print_help): Remove; unused.
17805 (stop_character, last_timer_event): Mark as externally visible.
17806 * keyboard.h (ignore_mouse_drag_p): Declare only if
17807 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
17808 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
17809 * lisp.h (echoing): Remove decl.
17810 (force_auto_save_soon): Declare only if SIGDANGER.
17811 * xdisp.c (redisplay_window): Simplify code, to make it more
17812 obvious that ignore_mouse_drag_p is not accessed if !defined
17813 USE_GTK && !defined HAVE_NS.
17814
93ea6e8f
PE
17815 * intervals.c: Make symbols static if they're not exported.
17816 (merge_properties_sticky, merge_interval_right, delete_interval):
17817 Now static.
17818 * intervals.h (merge_interval_right, delete_interval): Remove decls.
17819
77382fcc
PE
17820 * insdel.c: Make symbols static if they're not exported.
17821 However, leave prepare_to_modify_buffer alone. It's never
17822 called from outside this function, but that appears to be a bug.
17823 (combine_after_change_list, combine_after_change_buffer):
4889fc82 17824 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
17825 (adjust_after_replace_noundo): Remove; unused.
17826 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 17827 (signal_before_change): Remove decls.
77382fcc 17828
9306c32e
PE
17829 * indent.c (val_compute_motion, val_vmotion): Now static.
17830
cd44d2eb
PE
17831 * image.c: Make symbols static if they're not exported.
17832 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
17833 if USE_GTK.
17834 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
17835 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
17836
ad9a7a06
PE
17837 * fringe.c (standard_bitmaps): Now static.
17838 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
17839
81626931
PE
17840 * frame.c: Make symbols static if they're not exported.
17841 (x_report_frame_params, make_terminal_frame): Now static.
17842 (get_frame_param): Now static, unless HAVE_NS.
17843 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
17844 (x_get_resource_string): Remove; not used.
17845 * frame.h (make_terminal_frame, x_report_frame_params):
17846 (x_get_resource_string); Remove decls.
17847 (x_fullscreen_adjust): Declare only if WINDOWSNT.
17848 * lisp.h (get_frame_param): Declare only if HAVE_NS.
17849
239f9db9
PE
17850 * font.c, fontset.c: Make symbols static if they're not exported.
17851 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
17852 (FACE_SUITABLE_FOR_CHAR_P): Use it.
17853 * font.c (font_close_object): Now static.
17854 * font.h (font_close_object): Remove.
17855 * fontset.c (FONTSET_OBJLIST): Remove.
17856 (free_realized_fontset) #if-0 the body, which does nothing.
17857 (face_suitable_for_char_p): #if-0, as it's never called.
17858 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
17859 * xfaces.c (face_at_string_position):
17860 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
17861 since 0 is always ASCII.
17862
dfcf3579
PE
17863 * fns.c (weak_hash_tables): Now static.
17864
5045092b
PE
17865 * fileio.c: Make symbols static if they're not exported.
17866 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
17867 (Vwrite_region_annotation_buffers): Now static.
17868
57a96f5c
PE
17869 * eval.c: Make symbols static if they're not exported.
17870 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
17871 * lisp.h (backtrace_list): Remove decl.
17872
35f08c38
PE
17873 * emacs.c: Make symbols static if they're not exported.
17874 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
17875 (fatal_error_code, fatal_error_signal_hook, standard_args):
17876 Now static.
17877 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
17878 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
17879 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
17880 * lisp.h (fatal_error_signal_hook): Remove decl.
17881 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
17882
f44bd759
PE
17883 * editfns.c: Move a (normally-unused) function to its only use.
17884 * editfns.c, lisp.h (get_operating_system_release): Remove.
17885 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
17886 worth the hassle of breaking this out.
17887
b532497d
PE
17888 * xterm.c: Make symbols static if they're not exported.
17889 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
17890 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
17891 (x_destroy_window, x_delete_display):
17892 Now static.
17893 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
17894 (x_mouse_leave): Remove; unused.
17895 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
17896 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
17897 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
17898 Remove decls.
17899 (x_mouse_leave): Declare only if WINDOWSNT.
17900 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
17901 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
17902 USE_X_TOOLKIT.
17903
1675728f
PE
17904 * ftxfont.c: Make symbols static if they're not exported.
17905 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
17906 HAVE_FREETYPE.
17907 * font.h (ftxfont_driver): Likewise.
17908
e4cebfca
PE
17909 * xfns.c: Make symbols static if they're not exported.
17910 (x_last_font_name, x_display_info_for_name):
17911 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
17912 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
17913 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
17914 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
17915 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
17916 (last_show_tip_args): Now static.
17917 (xic_defaut_fontset, xic_create_fontsetname): Define only if
17918 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
17919 (x_screen_planes): Remove; unused.
17920 * dispextern.h (x_screen_planes): Remove decl.
17921
5bf46f05
PE
17922 * dispnew.c: Make symbols static if they're not exported.
17923 * dispextern.h (redraw_garbaged_frames, scrolling):
17924 (increment_row_positions): Remove.
17925 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
17926 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
17927 Now static.
17928 (redraw_garbaged_frames): Remove; unused.
17929
435f4c28
PE
17930 * xfaces.c: Make symbols static if they're not exported.
17931 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
17932 Remove decls.
17933 * xterm.h (defined_color): Remove decls.
17934 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
17935 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
17936 (menu_face_changed_default, defined_color, free_realized_face):
17937 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
17938 (ascii_face_of_lisp_face): Remove; unused.
17939
8524aef3
PE
17940 * xdisp.c: Make symbols static if they're not exported.
17941 * dispextern.h (scratch_glyph_row, window_box_edges):
17942 (glyph_to_pixel_coords, set_cursor_from_row):
17943 (get_next_display_element, set_iterator_to_next):
17944 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
17945 (show_mouse_face): Remove decls
17946 * frame.h (message_buf_print): Likewise.
17947 * lisp.h (pop_message, set_message, check_point_in_composition):
17948 Likewise.
17949 * xterm.h (set_vertical_scroll_bar): Likewise.
17950 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
17951 (message_buf_print, scratch_glyph_row, displayed_buffer):
17952 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
17953 (get_next_display_element, show_mouse_face, window_box_edges):
17954 (frame_to_window_pixel_xy, check_point_in_composition):
17955 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
17956 (glyph_to_pixel_coords): Remove; unused.
17957
16390cd2
PE
17958 * dired.c (file_name_completion): Now static.
17959
17960 * dbusbind.c (xd_in_read_queued_messages): Now static.
17961
a25f4dfa
PE
17962 * lisp.h (circular_list_error, FOREACH): Remove; unused.
17963 * data.c (circular_list_error): Remove.
17964
14a9c8df
PE
17965 * commands.h (last_point_position, last_point_position_buffer):
17966 (last_point_position_window): Remove decls.
17967 * keyboard.c: Make these variables static.
17968
04f2d78b
CB
17969 * coding.h (coding, code_convert_region, encode_coding_gap):
17970 Remove decls.
74ab6df5
PE
17971 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
17972 (iso_code_class, detect_coding, code_convert_region): Now static.
17973 (encode_coding_gap): Remove; unused.
17974
38dfbee1
PE
17975 * chartab.c (chartab_chars, chartab_bits): Now static.
17976
a2cb4e63
PE
17977 * charset.h (charset_iso_8859_1): Remove decl.
17978 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
17979 Now static.
17980
127198fd
PE
17981 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
17982 * ccl.c (Vccl_program_table): Now static.
17983 (check_ccl_update): Remove; unused.
17984
d85b608f
PE
17985 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
17986 * category.h: ... from here.
17987 * category.c (check_category_table, set_category_set): Now static.
17988
31cd66f3
PE
17989 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
17990 * lisp.h: Remove these decls.
17991
c358e587
PE
17992 * buffer.c (buffer_count): Remove unused var.
17993
e78aecca
PE
17994 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
17995 so that it's not optimized away.
17996 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
17997 * dispextern.h (bidi_dump_cached_states): Remove, since it's
17998 exported only to the debugger.
17999
e192d7d3 18000 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 18001 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 18002
92470028
PE
18003 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
18004 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
18005 was inaccessible from Lisp.
18006 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
18007 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
18008
244ed907
PE
18009 alloc.c: Import and export fewer symbols, and remove unused items.
18010 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
18011 is defined.
18012 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
18013 it's not optimized away by whole-program optimization.
18014 (message_enable_multibyte, free_misc): Remove.
18015 (catchlist, handlerlist, mark_backtrace):
18016 Declare only if BYTE_MARK_STACK.
18017 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
18018 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
18019 (message_enable_multibyte): Remove decl.
18020 (free_misc, interval_free_list, float_block, float_block_index):
18021 (n_float_blocks, float_free_list, cons_block, cons_block_index):
18022 (cons_free_list, last_marked_index):
18023 Now static.
18024 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
18025 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
18026 (mark_backtrace): Define only if BYTE_MARK_STACK.
18027 * xdisp.c (message_enable_multibyte): Now static.
18028
61c2b50e 18029 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
18030 This makes it easier for human readers (and static analyzers)
18031 to see whether these variables are used from other modules.
18032 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
18033 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
18034 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
18035 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
18036 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
18037 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
18038 * xmenu.c, xselect.c:
18039 Declare Q* vars static if they are not used in other modules.
18040 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
18041 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
18042 Remove decls of unexported vars.
18043 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
18044
95c82688
PE
18045 * lisp.h (DEFINE_FUNC): Make sname 'static'.
18046
16a97296
PE
18047 Make Emacs functions such as Fatom 'static' by default.
18048 This makes it easier for human readers (and static analyzers)
18049 to see whether these functions can be called from other modules.
18050 DEFUN now defines a static function. To make the function external
18051 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
18052 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
18053 (Finit_image_library):
16a97296
PE
18054 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
18055 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
18056 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
18057 Remove decls, since these functions are now static.
18058 (Funintern, Fget_internal_run_time): New decls, since these functions
18059 were already external.
95c82688 18060
16a97296
PE
18061 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
18062 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
18063 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
18064 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
18065 * keyboard.c, keymap.c, lread.c:
18066 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
18067 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
18068 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
18069 Mark functions with DEFUE instead of DEFUN,
18070 if they are used in other modules.
18071 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
18072 decls for now-static functions.
18073 * buffer.h (Fdelete_overlay): Remove decl.
18074 * callproc.c (Fgetenv_internal): Mark as internal.
18075 * composite.c (Fremove_list_of_text_properties): Remove decl.
18076 (Fcomposition_get_gstring): New forward static decl.
18077 * composite.h (Fcomposite_get_gstring): Remove decl.
18078 * dired.c (Ffile_attributes): New forward static decl.
18079 * doc.c (Fdocumntation_property): New forward static decl.
18080 * eval.c (Ffetch_bytecode): New forward static decl.
18081 (Funintern): Remove extern decl; now in .h file where it belongs.
18082 * fileio.c (Fmake_symbolic_link): New forward static decl.
18083 * image.c (Finit_image_library): New forward static decl.
18084 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
18085 * intervals.h (Fprevious_property_change):
18086 (Fremove_list_of_text_properties): Remove decls.
18087 * keyboard.c (Fthis_command_keys): Remove decl.
18088 (Fcommand_execute): New forward static decl.
18089 * keymap.c (Flookup_key): New forward static decl.
18090 (Fcopy_keymap): Now static.
18091 * keymap.h (Flookup_key): Remove decl.
18092 * process.c (Fget_process): New forward static decl.
18093 (Fprocess_datagram_address): Mark as internal.
18094 * syntax.c (Fsyntax_table_p): New forward static decl.
18095 (skip_chars): Remove duplicate decl.
18096 * textprop.c (Fprevious_property_change): New forward static decl.
18097 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
18098 Now internal.
18099 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
18100 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
18101
785bbd42
PE
18102 * editfns.c (Fformat): Remove unreachable code.
18103
8b913b57
AS
181042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
18105
18106 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
18107 change. (Bug#8496)
18108
a6744a35
EZ
181092011-04-13 Eli Zaretskii <eliz@gnu.org>
18110
18111 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
18112 when at ZV. (Bug#8487)
18113
e7974947
AS
181142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
18115
baad03f0
AS
18116 * charset.c (Fclear_charset_maps): Use xfree instead of free.
18117 (Bug#8437)
18118 * keyboard.c (parse_tool_bar_item): Likewise.
18119 * sound.c (sound_cleanup, alsa_close): Likewise.
18120 * termcap.c (tgetent): Likewise.
18121 * xfns.c (x_default_font_parameter): Likewise.
18122 * xsettings.c (read_and_apply_settings): Likewise.
18123
e7974947
AS
18124 * alloc.c (overrun_check_malloc, overrun_check_realloc)
18125 (overrun_check_free): Protoize.
18126
28272684
PE
181272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
18128
18129 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
18130 since callers should never pass a negative size.
18131 Change the signature to match that of plain 'read' and 'write'; see
18132 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
18133 * lisp.h: Update prototypes of emacs_write and emacs_read.
18134
11997c76
EZ
181352011-04-11 Eli Zaretskii <eliz@gnu.org>
18136
18137 * xdisp.c (redisplay_window): Don't try to determine the character
18138 position of the scroll margin if the window start point w->startp
e896f03c 18139 is outside the buffer's accessible region. (Bug#8468)
11997c76 18140
8a2cbd72
EZ
181412011-04-10 Eli Zaretskii <eliz@gnu.org>
18142
18143 Fix write-region and its subroutines for buffers > 2GB.
18144 * fileio.c (a_write, e_write): Modify declaration of arguments and
18145 local variables to support buffers larger than 2GB.
18146 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
18147
18148 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
18149 argument, local variables, and return value.
18150
18151 * lisp.h: Update prototypes of emacs_write and emacs_read.
18152
18153 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
18154
4073e537 181552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 18156
1ebfdcb6
PE
18157 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
18158
b2ded58d
PE
18159 Fix more problems found by GCC 4.6.0's static checks.
18160
7d66342c
PE
18161 * xdisp.c (vmessage): Use a better test for character truncation.
18162
bbf47d44
PE
18163 * charset.c (load_charset_map): <, not <=, for optimization,
18164 and to avoid potential problems with integer overflow.
9248994d 18165 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 18166 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 18167 * editfns.c (Fformat): Likewise.
1e69125e 18168 * syntax.c (skip_chars): Likewise.
3befa583 18169
e3019616
PE
18170 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
18171 This also lets GCC 4.6.0 generate slightly better loop code.
18172
becfa255
PE
18173 * callint.c (Fcall_interactively): <, not <=, for optimization.
18174 (Fcall_interactively): Count the number of arguments produced,
18175 not the number of arguments given. This is simpler and lets GCC
18176 4.6.0 generate slightly better code.
18177
dae0cd48
PE
18178 * ftfont.c: Distingish more carefully between FcChar8 and char.
18179 The previous code passed unsigned char * to a functions like
18180 strlen and xstrcasecmp that expect char *, which does not
18181 conform to the C standard.
18182 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
18183 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
18184 char * when the C standard requires it.
18185
76032d70
PE
18186 * keyboard.c (read_char): Remove unused var.
18187
eb3f1cc8
PE
18188 * eval.c: Port to Windows vsnprintf (Bug#8435).
18189 Include <limits.h>.
18190 (SIZE_MAX): Define if the headers do not.
18191 (verror): Do not give up if vsnprintf returns a negative count.
18192 Instead, grow the buffer. This ports to Windows vsnprintf, which
18193 does not conform to C99. Problem reported by Eli Zaretskii.
18194 Also, simplify the allocation scheme, by avoiding the need for
18195 calling realloc, and removing the ALLOCATED variable.
18196
70476b54
PE
18197 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
18198
12020a9e
PE
18199 Remove invocations of doprnt, as Emacs now uses vsnprintf.
18200 But keep the doprint source code for now, as we might revamp it
18201 and use it again (Bug#8435).
ea6c7ae6
PE
18202 * lisp.h (doprnt): Remove.
18203 * Makefile.in (base_obj): Remove doprnt.o.
18204 * deps.mk (doprnt.o): Remove.
18205
5fdb398c
PE
18206 error: Print 32- and 64-bit integers portably (Bug#8435).
18207 Without this change, on typical 64-bit hosts error ("...%d...", N)
18208 was used to print both 32- and 64-bit integers N, which relied on
18209 undefined behavior.
61bdb816 18210 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
18211 * lisp.h (error, verror): Mark as printf-like functions.
18212 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
18213 Report overflow in size calculations when allocating printf buffer.
18214 Do not truncate output string at its first null byte.
18215 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
18216 Truncate the output at a character boundary, since vsnprintf does not
18217 do that.
18218 * charset.c (check_iso_charset_parameter): Convert internal
18219 character to string before calling 'error', since %c now has the
18220 printf meaning.
18221 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
18222 overflow when computing char to be passed to 'error'. Do not
18223 pass Lisp_Object to 'error'; pass the integer instead.
18224 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
18225 formatted with plain %d.
18226
b189fa66
PE
18227 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
18228
bff87ef0
PE
18229 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
18230
7e2cac20
PE
18231 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
18232
ce4d90b5
PE
18233 * xterm.c (x_catch_errors): Remove duplicate declaration.
18234
266c9547
PE
18235 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
18236
79c49ad2
PE
18237 * xdisp.c, lisp.h (message_nolog): Remove; unused.
18238
368f4090
JM
182392011-04-10 Jim Meyering <meyering@redhat.com>
18240
18241 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
18242 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
18243 return ssize_t not "int", and use size_t as the buffer length.
18244 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
18245 * gnutls.h: Update declarations.
18246 * process.c (read_process_output): Use ssize_t, to match.
18247 (send_process): Likewise.
18248
a32d4040
CY
182492011-04-09 Chong Yidong <cyd@stupidchicken.com>
18250
18251 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
18252
8546720e 182532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 18254
04f2d78b
CB
18255 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
18256 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 18257
8546720e
GM
18258 * xterm.c (handle_one_xevent):
18259 * xmenu.c (create_and_show_popup_menu):
18260 * xselect.c (x_decline_selection_request)
18261 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 18262
0a2f5c1a 182632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
18264
18265 Fix some uses of `int' instead of EMACS_INT.
18266 * search.c (string_match_1, fast_string_match)
18267 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
18268 (scan_buffer, find_next_newline_no_quit)
18269 (find_before_next_newline, search_command, Freplace_match)
18270 (Fmatch_data): Make some `int' variables be EMACS_INT.
18271
18272 * xdisp.c (display_count_lines): 3rd argument and return value now
18273 EMACS_INT. All callers changed.
18274 (pint2hrstr): Last argument is now EMACS_INT.
18275
18276 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
18277 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
18278 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
18279 (decode_coding_utf_16, decode_coding_emacs_mule)
18280 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
18281 (decode_coding_ccl, decode_coding_charset)
18282 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
18283 (decode_coding_iso_2022, decode_coding_emacs_mule)
18284 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
18285 <char_offset, last_offset>: Declare EMACS_INT.
18286 (encode_coding_utf_8, encode_coding_utf_16)
18287 (encode_coding_emacs_mule, encode_invocation_designation)
18288 (encode_designation_at_bol, encode_coding_iso_2022)
18289 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
18290 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
18291 Declare EMACS_INT.
18292 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
18293 (encode_invocation_designation): Last argument P_NCHARS is now
18294 EMACS_INT.
18295 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
18296 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
18297
18298 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
18299 All users changed.
18300
18301 * ccl.c (Fccl_execute_on_string): Declare some variables
18302 EMACS_INT.
18303
8546720e 183042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
18305
18306 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
18307
4e19a977
CS
183082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
18309
18310 * process.c (Fformat_network_address): Doc fix.
18311
87302331
R
183122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
18313
ee7683eb 18314 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 18315
cbb59342
CY
183162011-04-08 Chong Yidong <cyd@stupidchicken.com>
18317
18318 * keyboard.c (read_char): Call Lisp function help-form-show,
18319 instead of using internal_with_output_to_temp_buffer.
18320 (Qhelp_form_show): New var.
e0d38eeb 18321 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
18322
18323 * print.c (internal_with_output_to_temp_buffer): Function deleted.
18324
18325 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
18326
e67a13ab
CY
183272011-04-06 Chong Yidong <cyd@stupidchicken.com>
18328
04f2d78b
CB
18329 * process.c (Flist_processes): Remove to Lisp.
18330 (list_processes_1): Delete.
e67a13ab 18331
973f782d
EZ
183322011-04-06 Eli Zaretskii <eliz@gnu.org>
18333
7c106b1e
EZ
18334 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
18335
973f782d
EZ
18336 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
18337
41cf7d1a 183382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 18339
ca23cc88
PE
18340 Fix more problems found by GCC 4.6.0's static checks.
18341
f390e2d5
PE
18342 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
18343
42eea0d0
PE
18344 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
18345
b69769da 18346 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 18347
f9541e84
PE
18348 * xdisp.c (vmessage): Mark as a printf-like function.
18349
13841b55
PE
18350 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
18351
c136c10f
PE
18352 * sound.c (sound_warning): Don't crash if arg contains a printf format.
18353
5e2d4a30
PE
18354 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
18355 printf-like functions.
18356 (tiff_load): Add casts to remove these marks before passing them
18357 to system-supplied API.
18358
583f48b9
PE
18359 * eval.c (Fsignal): Remove excess argument to 'fatal'.
18360
b25d760e
PE
18361 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
18362 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
18363 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
18364 directly, rather than having caller test rule sign. This avoids
18365 some unnecessary tests.
18366 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
18367 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
18368 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 18369
bc7b6697 18370 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 18371 (xfont_open): Avoid unnecessary tests.
bc7b6697 18372
27ccc379
PE
18373 * composite.c (composition_gstring_put_cache): Use unsigned integer.
18374
dcd5c89a
PE
18375 * composite.h, composite.c (composition_gstring_put_cache):
18376 Use EMACS_INT, not int, for length.
18377
b13a45c6
PE
18378 * composite.h (COMPOSITION_DECODE_REFS): New macro,
18379 breaking out part of COMPOSITION_DECODE_RULE.
18380 (COMPOSITION_DECODE_RULE): Use it.
18381 * composite.c (get_composition_id): Remove unused local vars,
18382 by using the new macro.
18383
1e792e4d
PE
18384 * textprop.c (set_text_properties_1): Change while to do-while,
18385 since the condition is always true at first.
18386
dc6c6455 18387 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
18388 (interval_deletion_adjustment): Return unsigned value.
18389 All uses changed.
dc6c6455 18390
aba7731a
PE
18391 * process.c (list_processes_1, create_pty, read_process_output):
18392 (exec_sentinel): Remove vars that were set but not used.
afd4052b 18393 (create_pty): Remove unnecessary "volatile"s.
bc57d757 18394 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 18395 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 18396 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 18397
fdfc4bf3
PE
18398 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
18399
fca8fe46 18400 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 18401 (update_syntax_table): Use unsigned instead of int.
fca8fe46 18402
06a0259a 18403 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 18404 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 18405 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 18406
e7b9e80f
PE
18407 * print.c (print_error_message): Avoid int overflow.
18408
56201685
PE
18409 * font.c (font_list_entities): Redo for clarity,
18410 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
18411
78834453 18412 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 18413 (font_score): Avoid potential overflow in diff calculation.
78834453 18414
0bc0b309 18415 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 18416 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 18417
e610eaca
PE
18418 * eval.c (funcall_lambda): Rename local to avoid shadowing.
18419
b895abce
PE
18420 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
18421 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
18422 can always succeed if overflow has undefined behavior.
18423
1f1d9321 18424 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 18425 (wordify): Omit three unnecessary tests.
1f1d9321 18426
c59478bc
PE
18427 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
18428 All callers changed. This avoids the need for an unused var.
18429
79b73827
PE
18430 * casefiddle.c (casify_region): Remove var that is set but not used.
18431
a4db5dfe
PE
18432 * dired.c (file_name_completion): Remove var that is set but not used.
18433
43aae36e
PE
18434 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
18435
2a47c44d 18436 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 18437 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 18438
a37c69bf
PE
18439 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
18440 Check for integer overflow on size calculations.
18441
328ab8e7
PE
18442 * buffer.c (Fprevious_overlay_change): Remove var that is set
18443 but not used.
18444
e5a2a5cb
PE
18445 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
18446 Remove vars that are set but not used.
8d84a6eb 18447 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 18448 (timer_check_2): Mark vars as initialized.
e5a2a5cb 18449
a60e5f68
PE
18450 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
18451
f661cb61 18452 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 18453 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 18454
f0397f5a
PE
18455 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
18456 that are set but not used.
18457
8664db06 18458 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 18459 if XCreateBitmapFromData fails (Bug#8410).
8664db06 18460
6abdaa4a
PE
18461 * xselect.c (x_get_local_selection, x_handle_property_notify):
18462 Remove vars that are set but not used.
18463
0ce7538d 18464 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 18465 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 18466
9ae848fc
PE
18467 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
18468 Remove var that is set but not used.
0b918413
PE
18469 (scroll_bar_windows_size): Now size_t, not int.
18470 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
18471 Check for overflow.
9ae848fc 18472
a5a62657
PE
18473 * xfaces.c (realize_named_face): Remove vars that are set but not used.
18474 (map_tty_color) [!defined MSDOS]: Likewise.
18475
5c5cdd39
PE
18476 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
18477
66ebf983
PE
18478 * coding.c: Remove vars that are set but not used.
18479 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
18480 All callers changed.
18481 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
18482 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
18483 (decode_coding_charset): Remove vars that are set but not used.
18484
1be4d761
PE
18485 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
18486 that is set but not used.
18487
47553fa8
PE
18488 * print.c (print_object): Remove var that is set but not used.
18489
1f7196bf 18490 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
18491 The gnulib version avoids calling malloc in the usual case,
18492 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
18493 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
18494 * filelock.c (current_lock_owner): Likewise.
18495 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
18496 * sysdep.c: Include allocator.h, careadlinkat.h.
18497 (emacs_no_realloc_allocator): New static constant.
18498 (emacs_readlink): New function.
fdb61804
PE
18499 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
18500 ../lib/careadlinkat.h.
d1fdcab7 18501
f84c17c7
SM
185022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
18503
18504 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
18505 first non-nil return value).
18506
ef3862ad
JD
185072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
18508
18509 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
18510 if not defined (Bug#8403).
18511
376a7006
JB
185122011-04-02 Juanma Barranquero <lekktu@gmail.com>
18513
18514 * xdisp.c (display_count_lines): Remove parameter `start',
18515 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
18516 (get_char_face_and_encoding): Remove parameter `multibyte_p',
18517 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
18518 (fill_stretch_glyph_string): Remove parameters `row' and `area',
18519 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
18520 and thereabouts. All callers changed.
18521 (get_per_char_metric): Remove parameter `f', unused since
18522 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
18523
6ca3801d
JM
185242011-04-02 Jim Meyering <meyering@redhat.com>
18525
18526 do not dereference NULL upon failed strdup
18527 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
18528 (ns_get_family): Likewise.
18529
d8e2b5ba
JB
185302011-04-02 Juanma Barranquero <lekktu@gmail.com>
18531
18532 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
18533
8c74fcbd
JD
185342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
18535
18536 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
18537 later (Bug#8403).
18538
7200d79c
SM
185392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
18540
03408648 18541 Add lexical binding.
7200d79c 18542
03408648
SM
18543 * window.c (Ftemp_output_buffer_show): New fun.
18544 (Fsave_window_excursion):
18545 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
18546
18547 * lread.c (lisp_file_lexically_bound_p): New function.
18548 (Fload): Bind Qlexical_binding.
18549 (readevalloop): Remove `evalfun' arg.
18550 Bind Qinternal_interpreter_environment.
18551 (Feval_buffer): Bind Qlexical_binding.
18552 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
18553 Mark as dynamic.
18554 (syms_of_lread): Declare `lexical-binding'.
18555
18556 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
18557
18558 * keyboard.c (eval_dyn): New fun.
18559 (menu_item_eval_property): Use it.
ca105506
SM
18560
18561 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 18562
03408648
SM
18563 * fns.c (concat, mapcar1): Accept byte-code-functions.
18564
18565 * eval.c (Fsetq): Handle lexical vars.
18566 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
18567 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
18568 (FletX, Flet): Obey lexical binding.
18569 (Fcommandp): Handle closures.
18570 (Feval): New `lexical' arg.
18571 (eval_sub): New function extracted from Feval. Use it almost
18572 everywhere where Feval was used. Look up vars in lexical env.
18573 Handle closures.
18574 (Ffunctionp): Move from subr.el.
18575 (Ffuncall): Handle closures.
18576 (apply_lambda): Remove `eval_flags'.
18577 (funcall_lambda): Handle closures and new byte-code-functions.
18578 (Fspecial_variable_p): New function.
18579 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
18580 but without exporting it to Lisp.
23aba0ea 18581
23aba0ea 18582 * doc.c (Fdocumentation, store_function_docstring):
03408648 18583 * data.c (Finteractive_form): Handle closures.
23aba0ea 18584
03408648
SM
18585 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
18586 interactive spec.
ba83908c 18587
04f2d78b
CB
18588 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
18589 New byte-codes.
03408648
SM
18590 (exec_byte_code): New function extracted from Fbyte_code to handle new
18591 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 18592
03408648 18593 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 18594
03408648 18595 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 18596
e2abce01
JB
185972011-03-31 Juanma Barranquero <lekktu@gmail.com>
18598
18599 * xdisp.c (redisplay_internal): Fix prototype.
18600
63696a73 186012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 18602
63696a73 18603 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
18604 (try_scrolling): Use it when setting scroll_limit.
18605 Limit scrolling to 100 screen lines.
63696a73
EZ
18606 (redisplay_window): Even when falling back on "recentering",
18607 position point in the window according to scroll-conservatively,
18608 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
18609
18610 (try_scrolling): When point is above the window, allow searching
18611 as far as scroll_max, or one screenful, to compute vertical
18612 distance from PT to the scroll margin position. This prevents
18613 try_scrolling from unnecessarily failing when
18614 scroll-conservatively is set to a value slightly larger than the
18615 window height. Clean up the case of PT below the margin at bottom
18616 of window: scroll_max can no longer be INT_MAX. When aggressive
18617 scrolling is in use, don't let point enter the opposite scroll
18618 margin as result of the scroll.
18619 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
18620 threshold of 100 lines for never-recentering scrolling.
18621
e4cc2dfc
JB
186222011-03-31 Juanma Barranquero <lekktu@gmail.com>
18623
18624 * dispextern.h (move_it_by_lines):
18625 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
18626 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
18627 (message_log_check_duplicate): Remove parameters `prev_bol' and
18628 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
18629 (redisplay_internal): Remove parameter `preserve_echo_area',
18630 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
18631
18632 * indent.c (Fvertical_motion):
18633 * window.c (window_scroll_pixel_based, Frecenter):
18634 Don't pass `need_y_p' to `move_it_by_lines'.
18635
1c470562
SM
186362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
18637
44f230aa
SM
18638 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
18639 steal a few bits to be more compact.
18640 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
18641 Remove unneeded casts.
18642
1c470562
SM
18643 * bytecode.c (Fbyte_code): CAR and CDR can GC.
18644
888adce9
ZK
186452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
18646
18647 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
18648 binding" message (bug#7967).
18649
f838ed7b
PE
186502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
18651
77861b95
PE
18652 Fix more problems found by GCC 4.6.0's static checks.
18653
de6dbc14
PE
18654 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
18655 Remove unused local var.
18656
f838ed7b
PE
18657 * editfns.c (Fmessage_box): Remove unused local var.
18658
792c7b2b
PE
18659 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
18660 (note_mode_line_or_margin_highlight, note_mouse_highlight):
18661 Omit unused local vars.
c499e557 18662 * window.c (shrink_windows): Omit unused local var.
b01a1c29 18663 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
18664 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
18665 Omit unused local var.
18666
ba0165e1
PE
18667 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
18668 Don't assume string length fits in int.
32ad8845 18669 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 18670 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 18671
3c59b4c9
PE
18672 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
18673 instead of alloca (Bug#8344).
18674
a3eed478 18675 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 18676 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 18677
eb4d412d
PE
18678 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
18679
1658b401
PE
18680 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
18681 concerns.
18682
18683 * term.c (produce_glyphless_glyph): Remove unnecessary test.
18684
18685 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 18686
9a2c6e05
PE
18687 * keyboard.c (syms_of_keyboard): Use the same style as later
18688 in this function when indexing through an array. This also
18689 works around GCC bug 48267.
18690
03d0a109
PE
18691 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
18692
44f730c8
PE
18693 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
18694
fe75f926
PE
18695 * chartab.c (sub_char_table_ref_and_range): Redo for slight
18696 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
18697
ffa8c828
PE
18698 * keyboard.c, keyboard.h (num_input_events): Now size_t.
18699 This avoids undefined behavior on integer overflow, and is a bit
18700 more convenient anyway since it is compared to a size_t variable.
18701
c5101a77
PE
18702 Variadic C functions now count arguments with size_t, not int.
18703 This avoids an unnecessary limitation on 64-bit machines, which
18704 caused (substring ...) to crash on large vectors (Bug#8344).
18705 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
18706 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 18707 All variadic functions and their callers changed accordingly.
c5101a77
PE
18708 (struct gcpro.nvars): Now size_t, not int. All uses changed.
18709 * data.c (arith_driver, float_arith_driver): Likewise.
18710 * editfns.c (general_insert_function): Likewise.
18711 * eval.c (struct backtrace.nargs, interactive_p)
18712 (internal_condition_case_n, run_hook_with_args, apply_lambda)
18713 (funcall_lambda, mark_backtrace): Likewise.
18714 * fns.c (concat): Likewise.
18715 * frame.c (x_set_frame_parameters): Likewise.
18716 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
18717 0 if not found, not -1. All callers changed.
18718
dd3f25f7
PE
18719 * alloc.c (garbage_collect): Don't assume stack size fits in int.
18720 (stack_copy_size): Now size_t, not int.
18721 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
18722
461c2ab9
JB
187232011-03-28 Juanma Barranquero <lekktu@gmail.com>
18724
18725 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
18726 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
18727 All callers changed.
18728
18729 * lisp.h (multibyte_char_to_unibyte):
18730 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
18731 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
18732 * character.h (CHAR_TO_BYTE8):
18733 * cmds.c (internal_self_insert):
18734 * editfns.c (general_insert_function):
18735 * keymap.c (push_key_description):
18736 * search.c (Freplace_match):
18737 * xdisp.c (message_dolog, set_message_1): All callers changed.
18738
f6d62986
SM
187392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
18740
18741 * keyboard.c (safe_run_hook_funcall): New function.
18742 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
18743 don't set the hook to nil, but remove the offending function instead.
18744 (Qcommand_hook_internal): Remove, unused.
18745 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
18746 Vcommand_hook_internal.
18747
18748 * eval.c (enum run_hooks_condition): Remove.
18749 (funcall_nil, funcall_not): New functions.
18750 (run_hook_with_args): Call each function through a `funcall' argument.
18751 Remove `cond' argument, now redundant.
18752 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
18753 (Frun_hook_with_args_until_failure): Adjust accordingly.
18754 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
18755
1db5b1ad
JB
187562011-03-28 Juanma Barranquero <lekktu@gmail.com>
18757
18758 * dispextern.h (string_buffer_position): Remove declaration.
18759
18760 * print.c (strout): Remove parameter `multibyte', unused since
18761 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
18762
18763 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
18764 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
18765 All callers changed.
18766
18767 * w32.c (_wsa_errlist): Use braces for struct initializers.
18768
18769 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
18770 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
18771 All callers changed.
18772 (string_buffer_position): Likewise. Also, make static (it's never
18773 used outside xdisp.c).
18774 (cursor_row_p): Remove parameter `w', unused since
18775 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
18776 (decode_mode_spec): Remove parameter `precision', introduced during
18777 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
18778 All callers changed.
18779
5ffb62aa
JD
187802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
18781
18782 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
18783
461c2ab9 187842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
18785
18786 * nsterm.m (ns_menu_bar_is_hidden): New variable.
18787 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
18788 (ns_update_auto_hide_menu_bar): New functions.
18789 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
18790 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
18791 ns_constrain_all_frames.
18792 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
18793 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
18794
5c380ffb
JD
187952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
18796
18797 * nsmenu.m (runDialogAt): Remove argument to timer_check.
18798
9af30bdf
GM
187992011-03-27 Glenn Morris <rgm@gnu.org>
18800
18801 * syssignal.h: Replace RETSIGTYPE with void.
18802 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
18803 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
18804 Replace SIGTYPE with void everywhere.
18805 * s/usg5-4-common.h (SIGTYPE): Remove definition.
18806 * s/template.h (SIGTYPE): Remove commented out definition.
18807
e2abce01
JB
188082011-03-26 Eli Zaretskii <eliz@gnu.org>
18809
18810 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
18811 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
18812
f868cd8a
JB
188132011-03-26 Juanma Barranquero <lekktu@gmail.com>
18814
59eb0929
JB
18815 * w32.c (read_unc_volume): Use parameter `henum', instead of
18816 global variable `wget_enum_handle'.
18817
18818 * keymap.c (describe_vector): Remove parameters `indices' and
18819 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
18820 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
18821
f868cd8a
JB
18822 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
18823
18824 * keyboard.c (timer_check): Remove parameter `do_it_now',
18825 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
18826 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
18827 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
18828
18829 * keyboard.c (read_char):
18830 * w32menu.c (w32_menu_display_help):
18831 * xmenu.c (show_help_event, menu_help_callback):
18832 Adjust calls to `show_help_echo'.
18833
18834 * gtkutil.c (xg_maybe_add_timer):
18835 * keyboard.c (readable_events):
18836 * process.c (wait_reading_process_output):
18837 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
18838
18839 * insdel.c (adjust_markers_gap_motion):
18840 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
18841 (gap_left, gap_right): Don't call it.
18842
2ecf6fdb
CY
188432011-03-25 Chong Yidong <cyd@stupidchicken.com>
18844
18845 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
18846 incurred during fontification.
18847
6b1f9ba4
JB
188482011-03-25 Juanma Barranquero <lekktu@gmail.com>
18849
18850 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
18851 (DEFVAR_PER_BUFFER): Don't pass it.
18852
18853 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
18854 (scrolling_window): Don't pass it.
18855
0f4a96b5
JB
188562011-03-25 Juanma Barranquero <lekktu@gmail.com>
18857
18858 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
18859
18860 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
18861 and `suffix'.
18862 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
18863 of variables specific to SELinux and computation of `encoded_absname'.
18864
18865 * image.c (XPutPixel): Remove unused variable `height'.
18866
18867 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
18868
18869 * unexw32.c (get_section_info): Remove unused variable `section'.
18870
18871 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
18872 (system_process_attributes): Remove unused variable `sess'.
18873 (sys_read): Remove unused variable `err'.
18874
18875 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
18876 (w32_wnd_proc): Remove unused variable `isdead'.
18877 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
18878 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
18879 (x_create_tip_frame): Remove unused variable `tem'.
18880
18881 * w32inevt.c (w32_console_read_socket):
18882 Remove unused variable `no_events'.
18883
18884 * w32term.c (x_draw_composite_glyph_string_foreground):
18885 Remove unused variable `width'.
18886
1149507c
JB
188872011-03-24 Juanma Barranquero <lekktu@gmail.com>
18888
18889 * w32term.c (x_set_glyph_string_clipping):
18890 Don't pass uninitialized region to CombineRgn.
18891
9c88f339
JB
188922011-03-23 Juanma Barranquero <lekktu@gmail.com>
18893
18894 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
18895 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
18896 (Fx_close_connection): Remove unused variable `i'.
18897
18898 * w32font.c (w32font_draw): Return number of glyphs.
18899 (w32font_open_internal): Remove unused variable `i'.
18900 (w32font_driver): Add missing initializer.
18901
18902 * w32menu.c (utf8to16): Remove unused variable `utf16'.
18903 (fill_in_menu): Remove unused variable `items_added'.
18904
18905 * w32term.c (last_mouse_press_frame): Remove static global variable.
18906 (w32_clip_to_row): Remove unused variable `f'.
18907 (x_delete_terminal): Remove unused variable `i'.
18908
18909 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
18910 (NOTHING): Remove unused static global variable.
18911 (uniscribe_check_otf): Remove unused variable `table'.
18912 (uniscribe_font_driver): Add missing initializers.
18913
dee091a3
JD
189142011-03-23 Julien Danjou <julien@danjou.info>
18915
18916 * term.c (Fsuspend_tty, Fresume_tty):
18917 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
18918 * window.c (temp_output_buffer_show):
18919 * insdel.c (signal_before_change):
18920 * frame.c (Fhandle_switch_frame):
18921 * fileio.c (Fdo_auto_save):
18922 * emacs.c (Fkill_emacs):
18923 * editfns.c (save_excursion_restore):
18924 * cmds.c (internal_self_insert):
18925 * callint.c (Fcall_interactively):
18926 * buffer.c (Fkill_all_local_variables):
18927 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
18928 Use Frun_hooks.
0f4a96b5 18929 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 18930 unconditionally since it does the check itself.
dee091a3 18931
2c520ab5 189322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 18933
c9c49752
PE
18934 Fix more problems found by GCC 4.5.2's static checks.
18935
8abc3f12
PE
18936 * coding.c (encode_coding_raw_text): Avoid unnecessary test
18937 the first time through the loop, since we know p0 < p1 then.
18938 This also avoids a gcc -Wstrict-overflow warning.
18939
a2d26660
PE
18940 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
18941 leading to a memory leak, possible in functions like
18942 load_charset_map_from_file that can allocate an unbounded number
b12ef411 18943 of objects (Bug#8318).
a2d26660 18944
916c72e9
PE
18945 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
18946 that could (at least in theory) be that large.
18947
19ab8a18
PE
18948 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
18949 This is less likely to overflow, and avoids undefined behavior if
18950 overflow does occur. All callers changed. Use strtoul to scan
18951 for the unsigned long integer.
b7cbbd6f
PE
18952 (pint2hrstr): Simplify and tune code slightly.
18953 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 18954
f0641eff
PE
18955 * scroll.c (do_scrolling): Work around GCC bug 48228.
18956 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
18957
7f650bb9
PE
18958 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
18959 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
18960 (validate_x_resource_name): Simplify count usage.
18961 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 18962
37dd57d1
PE
18963 * fileio.c (Fcopy_file): Report error if fchown or fchmod
18964 fail (Bug#8306).
81e56e61 18965
699979fc 18966 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 18967
401bf9b4
PE
18968 * process.c (Fmake_network_process): Use socklen_t, not int,
18969 where POSIX says socklen_t is required in portable programs.
18970 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 18971 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
18972 (Fmake_network_process, server_accept_connection):
18973 (wait_reading_process_output, read_process_output):
18974 Likewise.
18975
b93aacde
PE
18976 * process.c: Rename or move locals to avoid shadowing.
18977 (list_processes_1, Fmake_network_process):
18978 (read_process_output_error_handler, exec_sentinel_error_handler):
18979 Rename or move locals.
4dc343ee 18980 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 18981 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 18982 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 18983 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 18984 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 18985
af8a867c 18986 Make tparam.h and terminfo.c consistent.
44f230aa
SM
18987 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
18988 Include tparam.h instead, since it declares them.
af8a867c
PE
18989 * cm.h (PC): Remove extern decl; tparam.h now does this.
18990 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
18991 * terminfo.c: Include tparam.h, to check interfaces.
18992 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
18993 (tparam): Adjust signature to match interface in tparam.h;
18994 this removes some undefined behavior. Check that outstring and len
18995 are zero, which they always are with Emacs.
18996 * tparam.h (PC, BC, UP): New extern decls.
18997
0248044d 18998 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 18999 (xftfont_open): Rename locals to avoid shadowing.
0248044d 19000
8ff096c1 19001 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
19002 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
19003 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 19004 (ftfont_list): Remove unused local.
49eaafba
PE
19005 (get_adstyle_property, ftfont_pattern_entity):
19006 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
19007 Rename locals to avoid shadowing.
8ff096c1 19008
e2be39f6
PE
19009 * xfont.c (xfont_list_family): Mark var as initialized.
19010
c9735e30
PE
19011 * xml.c (make_dom): Now static.
19012
8f5201ae
PE
19013 * composite.c (composition_compute_stop_pos): Rename local to
19014 avoid shadowing.
b246f932
PE
19015 (composition_reseat_it): Remove unused locals.
19016 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 19017 (composition_update_it): Mark var as initialized.
11b61122
PE
19018 (find_automatic_composition): Mark vars as initialized,
19019 with a FIXME (Bug#8290).
8f5201ae 19020
760fbc2c
PE
19021 character.h: Rename locals to avoid shadowing.
19022 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
19023 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
19024 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
19025 (BUF_DEC_POS): Be more systematic about renaming local temporaries
19026 to avoid shadowing.
19027
ff08eb85
PE
19028 * textprop.c (property_change_between_p): Remove; unused.
19029
fc7bf025
PE
19030 * intervals.c (interval_start_pos): Now static.
19031
235d7abc
PE
19032 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
19033
44f230aa
SM
19034 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
19035 Rename locals to avoid shadowing.
3e7d6594 19036
50060332
PE
19037 * sound.c (wav_play, au_play, Fplay_sound_internal):
19038 Fix pointer signedness.
d01f234b 19039 (alsa_choose_format): Remove unused local var.
c83b8872
PE
19040 (wav_play): Initialize a variable to 0, to prevent undefined
19041 behavior (Bug#8278).
50060332 19042
c4fc4e30
PE
19043 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
19044
918436ed
PE
19045 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
19046
c939f91b
PE
19047 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
19048 clobbering (Bug#8298).
b9c7f648
PE
19049 * sysdep.c (sys_subshell): Likewise.
19050 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 19051
6bd8c144
PE
19052 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
19053 This should get cleaned up, so that child_setup has the
19054 same signature on all platforms.
19055
7710357c 19056 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 19057 (relocate_fd): Rename locals to avoid shadowing.
7710357c 19058
c59da222
CY
190592011-03-22 Chong Yidong <cyd@stupidchicken.com>
19060
19061 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
19062 not to be necessary, and produces flickering.
19063
66b87493
GM
190642011-03-20 Glenn Morris <rgm@gnu.org>
19065
19066 * config.in: Remove file.
19067
45b6f6d5
JB
190682011-03-20 Juanma Barranquero <lekktu@gmail.com>
19069
19070 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
19071 are now in src/globals.h.
19072 (syms_of_minibuf): Remove spurious & from previous change.
19073
cd394be1 190742011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
19075
19076 * minibuf.c (completing-read-function): New variable.
19077 (completing-read-default): Rename from completing-read.
19078 (completing-read): Call completing-read-function.
19079
b14e3e21
CY
190802011-03-19 Juanma Barranquero <lekktu@gmail.com>
19081
19082 * xfaces.c (Fx_load_color_file):
19083 Read color file from absolute filename (bug#8250).
19084
f2b726e6
JB
190852011-03-19 Juanma Barranquero <lekktu@gmail.com>
19086
19087 * makefile.w32-in: Update dependencies.
19088
09f6ff02
EZ
190892011-03-17 Eli Zaretskii <eliz@gnu.org>
19090
19091 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
19092
29a6015a
PE
190932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
19094
a3a6c54e
PE
19095 Fix more problems found by GCC 4.5.2's static checks.
19096
b766f867
PE
19097 * process.c (make_serial_process_unwind, send_process_trap):
19098 (sigchld_handler): Now static.
19099
be02381c
PE
19100 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
19101 That way, the code declares only the vars that it needs.
19102 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
19103 * s/cygwin.h (PTY_ITERATION): Likewise.
19104 * s/darwin.h (PTY_ITERATION): Likewise.
19105 * s/gnu-linux.h (PTY_ITERATION): Likewise.
19106
57048744
PE
19107 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
19108 * process.c (allocate_pty): Don't declare stb unless it's needed.
19109
7914961c 19110 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
19111 (CONSTANTLIM): Remove; unused.
19112 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
19113 Define only if needed.
7914961c 19114
b3967b18
PE
19115 * unexelf.c (unexec): Name an expression,
19116 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
19117 Use a different way to cause a compilation error if anyone uses
19118 n rather than nn, a way that does not involve shadowing.
73366a00 19119 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 19120
29a6015a
PE
19121 * deps.mk (unexalpha.o): Remove; unused.
19122
43cfc33e 19123 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 19124 * unexec.h: New file.
ce701a33
PE
19125 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
19126 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
19127 Depend on unexec.h.
19128 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
19129 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
19130 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 19131 Change as necessary to match prototype in unexec.h.
ce701a33 19132
01f44d5a
PE
19133 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
19134 shadowing.
4f63c6bb 19135 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 19136
a6670b0b
PE
19137 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
19138 Rename locals to avoid shadowing.
19139
cef2010d 19140 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 19141 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 19142
d4d7173a
PE
19143 * print.c (Fredirect_debugging_output): Fix pointer signedess.
19144
f08b802a
PE
19145 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
19146 warning when compiling print.c.
19147
3ddb0639
PE
19148 * font.c (font_unparse_fcname): Abort in an "impossible" situation
19149 instead of using an uninitialized var.
5ad03b97 19150 (font_sort_entities): Mark var as initialized.
3ddb0639 19151
170a2692
PE
19152 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
19153
e663c700
PE
19154 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
19155 pointers to constants.
89bc529a 19156 (font_parse_fcname): Remove unused vars.
7b81e2d0 19157 (font_delete_unmatched): Now static.
ea838e10 19158 (font_get_spec): Remove; unused.
13a547c6
PE
19159 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
19160 (font_update_drivers, Ffont_get_glyphs, font_add_log):
19161 Rename or move locals to avoid shadowing.
e663c700 19162
2a80c887 19163 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 19164 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 19165
1384fa33 19166 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 19167 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 19168
8b2c52e9
PE
19169 * alloc.c (mark_backtrace): Move decl from here ...
19170 * lisp.h: ... to here, so that it can be checked.
19171
475545b5 19172 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 19173 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
19174 (lisp_indirect_variable): Name an expression,
19175 to avoid gcc -Wbad-function-cast warning.
1faed8ae 19176 (Fdefvar): Rename locals to avoid shadowing.
475545b5 19177
b1349114 19178 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 19179 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 19180 Use const pointer when appropriate.
b1349114 19181
a2928364
PE
19182 * lisp.h (get_system_name, get_operating_system_release):
19183 Move decls here, to check interfaces.
19184 * process.c (get_operating_system_release): Move decl to lisp.h.
19185 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
19186 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
19187 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
19188 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
19189 (Fformat_time_string, Fencode_time, Finsert_char):
19190 (Ftranslate_region_internal, Fformat):
19191 Rename or remove local vars to avoid shadowing.
9710023e 19192 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 19193
a415e694
PE
19194 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
19195 avoid shadowing.
19196
8ef4622d
PE
19197 * lisp.h (eassert): Check that the argument compiles, even if
19198 ENABLE_CHECKING is not defined.
19199
946f9a5b
PE
19200 * data.c (Findirect_variable): Name an expression, to avoid
19201 gcc -Wbad-function-cast warning.
112396d6 19202 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 19203 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
19204 (Fmake_variable_buffer_local, Fmake_local_variable):
19205 Mark variables as initialized.
52746918 19206 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 19207
e5aab7e7 19208 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
19209 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
19210 Rename locals to avoid shadowing.
dff45157
PE
19211 (mark_stack): Move local variables into the #ifdef region where
19212 they're used.
7bc26fdb
PE
19213 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
19214 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
19215 needed otherwise.
19216 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
19217 (GC_STRING_CHARS): Remove; not used.
d40d4be1 19218 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 19219
e5aab7e7
PE
19220 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
19221 avoids undefined behavior in theory.
19222
4da60324
PE
19223 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
19224
88043301
PE
19225 Use functions, not macros, for up- and down-casing (Bug#8254).
19226 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
19227 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
19228 to use the following functions instead of these macros.
19229 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
19230 EMACS_INT, since callers assume the returned value fits in int.
19231 (upcase1): Likewise, for UPCASE_TABLE.
19232 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 19233 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 19234 the race-condition problem in the old DOWNCASE.
88043301 19235
19ed5445
PE
19236 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
19237 Rename locals to avoid shadowing.
19238 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
19239 (regex_compile, re_search_2, re_match_2_internal):
19240 Remove unused local vars.
952db0d7
PE
19241 (FREE_VAR): Rewrite so as not to use empty "else",
19242 which gcc can warn about.
da053e48 19243 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
19244 (RETALLOC_IF): Define only if needed.
19245 (WORDCHAR_P): Likewise. This one is never needed, but is used
19246 only in a comment talking about a compiler bug, so put inside
19247 the #if 0 of that comment.
19248 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
19249 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
19250 Remove; unused.
19ed5445 19251
1f3561e4 19252 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
19253 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
19254 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 19255
ded6f8f7
PE
19256 * search.c (simple_search): Remove unused var.
19257
dbd37a95
PE
19258 * dired.c (compile_pattern): Move decl from here ...
19259 * lisp.h: ... to here, so that it can be checked.
19260 (struct re_registers): New forward decl.
19261
7e47afad
PE
19262 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
19263
85f24f61
PE
19264 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
19265 All uses changed.
19266 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
19267 Rename locals to avoid shadowing.
5671df8f 19268 (Fvertical_motion): Mark locals as initialized.
85f24f61 19269
181aa2be 19270 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 19271 (casify_region): Mark local as initialized.
181aa2be 19272
930d429c
PE
19273 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
19274
7082eac6
PE
19275 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
19276 New macros, so that the caller can use some names other than
19277 gcpro1, gcpro2, etc.
19278 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
19279 of the new macros.
19280 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
19281 argument, for consistency with GCPRO2_VAR, etc: it is now the
19282 prefix of the variable, not the variable itself. All uses
19283 changed.
38b2c076
PE
19284 * dired.c (directory_files_internal, file_name_completion):
19285 Rename locals to avoid shadowing.
19286
15206ed9
PE
19287 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
19288 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
19289 dired.c's scmp function, had undefined behavior.
19290 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
19291 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
19292 * buffer.h: ... to here, because these macros use current_buffer,
19293 and the new implementation with inline functions needs to have
19294 current_buffer in scope now, rather than later when the macros
19295 are used.
19296 (downcase, upcase1): New static inline functions.
19297 (DOWNCASE, UPCASE1): Reimplement using these functions.
19298 This avoids undefined behavior in expressions like
19299 DOWNCASE (x) == DOWNCASE (y), which previously suffered
19300 from race conditions in accessing the global variables
19301 case_temp1 and case_temp2.
19302 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
19303 * lisp.h (case_temp1, case_temp2): Remove their decls.
19304 * character.h (ASCII_CHAR_P): Move from here ...
19305 * lisp.h: ... to here, so that the inline functions mentioned
19306 above can use them.
19307
4a6bea26
PE
19308 * dired.c (directory_files_internal_unwind): Now static.
19309
f14b7e14
PE
19310 * fileio.c (file_name_as_directory, directory_file_name):
19311 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
19312 Now static.
2893f146
PE
19313 (file_name_as_directory): Use const pointers when appropriate.
19314 (Fexpand_file_name): Likewise. In particular, newdir might
19315 point at constant storage, so make it a const pointer.
fd4ead52 19316 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
19317 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
19318 signedness issues.
f839df0c
PE
19319 (Fset_file_times, Finsert_file_contents, auto_save_error):
19320 Rename locals to avoid shadowing.
f14b7e14 19321
5716756e 19322 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
19323 (Ftry_completion, Fall_completions): Rename or remove locals
19324 to avoid shadowing.
5716756e 19325
b4c3046a
PE
19326 * marker.c (bytepos_to_charpos): Remove; unused.
19327
b45db522
PE
19328 * lisp.h (verify_bytepos, count_markers): New decls,
19329 so that gcc does not warn that these functions aren't declared.
19330
85876d07
PE
19331 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
19332 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 19333 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 19334 (copy_text): Remove unused local var.
85876d07 19335
03d78a21 19336 * filelock.c (within_one_second): Now static.
b3dd38ab 19337 (lock_file_1): Rename local to avoid shadowing.
03d78a21 19338
5df8f01b
PE
19339 * buffer.c (fix_overlays_before): Mark locals as initialized.
19340 (fix_start_end_in_overlays): Likewise. This function should be
19341 simplified by using pointers-to-pointers, but that's a different
19342 matter.
b1d876f1 19343 (switch_to_buffer_1): Now static.
8f54f30a
PE
19344 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
19345 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 19346
a70072c9 19347 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 19348 Fix pointer signedness issue.
edced198
PE
19349 (sys_subshell): Mark local as volatile if checking for lint,
19350 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 19351 (MAXPATHLEN): Define only if needed.
a70072c9 19352
a0977c44
PE
19353 * process.c (serial_open, serial_configure): Move decls from here ...
19354 * systty.h: ... to here, so that they can be checked.
19355
a884fdcc
PE
19356 * fns.c (get_random, seed_random): Move extern decls from here ...
19357 * lisp.h: ... to here, so that they can be checked.
19358
604efe86 19359 * sysdep.c (reset_io): Now static.
b8950c94 19360 (wait_for_termination_signal): Remove; unused.
604efe86 19361
38fc62d9
PE
19362 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
19363 (copy_keymap_item, append_key, push_text_char_description):
19364 Now static.
1004a21a 19365 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 19366 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
19367 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
19368 (describe_map_tree):
19369 Rename locals to avoid shadowing.
38fc62d9 19370
2f2650da
PE
19371 * keyboard.c: Declare functions static if they are not used elsewhere.
19372 (echo_char, echo_dash, cmd_error, top_level_2):
19373 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
19374 (read_char, kbd_buffer_get_event, make_lispy_position):
19375 (make_lispy_event, make_lispy_movement, apply_modifiers):
19376 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
19377 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
19378 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 19379 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 19380 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 19381
a053e86c 19382 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
19383 (mark_kboards): Move decl here ...
19384 * alloc.c (mark_kboards): ... from here.
a053e86c 19385
4752793e
PE
19386 * lisp.h (force_auto_save_soon): New decl.
19387
74f10ca7 19388 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
19389 (DEFINE_DUMMY_FUNCTION): New macro.
19390 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
19391 Use it.
c03cd23f
PE
19392 (main): Add casts to avoid warnings
19393 if GCC considers string literals to be constants.
74f10ca7 19394
022e70d4
PE
19395 * lisp.h (fatal_error_signal): Add decl, since it's exported.
19396
59d6fe83
PE
19397 * dbusbind.c: Pointer signedness fixes.
19398 (xd_signature, xd_append_arg, xd_initialize):
19399 (Fdbus_call_method, Fdbus_call_method_asynchronously):
19400 (Fdbus_method_return_internal, Fdbus_method_error_internal):
19401 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
19402 (Fdbus_register_signal): Use SSDATA when the context wants char *.
19403
78320123
PE
19404 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
19405 if GCC considers string literals to be constants.
49cebcca 19406 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 19407
35ac2a97
SM
194082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
19409
fb103ca9
SM
19410 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
19411 (print_preprocess, print_object): New macro to fix last change.
19412
35ac2a97
SM
19413 * print.c (print_preprocess): Don't forget font objects.
19414
62973b41
JB
194152011-03-16 Juanma Barranquero <lekktu@gmail.com>
19416
19417 * emacs.c (USAGE3): Doc fixes.
19418
0e48bb22
AS
194192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
19420
19421 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
19422 structure.
19423
7684e57b
JB
194242011-03-14 Juanma Barranquero <lekktu@gmail.com>
19425
19426 * lisp.h (VWindow_system, Qfile_name_history):
19427 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
19428 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
19429 (w32_system_caret_x, w32_system_caret_y): Declare extern.
19430
19431 * w32select.c: Don't #include "keyboard.h".
c96bbc66 19432 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
19433
19434 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
19435 * w32console.c (detect_input_pending, read_input_pending)
19436 (encode_terminal_code):
19437 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
19438 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
19439 (w32_system_caret_y, Qfile_name_history):
19440 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
19441 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
19442 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
19443 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
19444 * w32proc.c (Qlocal, report_file_error):
19445 * w32term.c (Vwindow_system, updating_frame):
19446 * w32uniscribe.c (initialized, uniscribe_font_driver):
19447 Remove unneeded extern declarations.
19448
2aa46d6c
CY
194492011-03-14 Chong Yidong <cyd@stupidchicken.com>
19450
c96bbc66 19451 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 19452
cffc6f3b
CY
194532011-03-13 Chong Yidong <cyd@stupidchicken.com>
19454
19455 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
19456 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
19457 These macros can no longer be used for assignment.
19458
44f230aa
SM
19459 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
19460 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
19461 (record_buffer_markers, fetch_buffer_markers): New functions for
19462 recording and fetching special buffer markers.
19463 (set_buffer_internal_1, set_buffer_temp): Use them.
19464
19465 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
19466
19467 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
19468
19469 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
19470 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
19471
19472 * xdisp.c (hscroll_window_tree):
19473 (reconsider_clip_changes): Use PT instead of BUF_PT.
19474
d251f04b
EZ
194752011-03-13 Eli Zaretskii <eliz@gnu.org>
19476
19477 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
19478 $(EMACS_ROOT)/lib/intprops.h.
19479
f0c77cd1
PE
194802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
19481
3eca4629
PE
19482 Fix more problems found by GCC 4.5.2's static checks.
19483
7c86ee98
PE
19484 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
19485 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
19486 (xg_free_frame_widgets): Make it clear that a local variable is
19487 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
19488 (gdk_window_get_screen): Make it clear that this macro is needed
19489 only if USE_GTK_TOOLTIP.
1e5524e7
PE
19490 (int_gtk_range_get_value): New function, which avoids a diagnostic
19491 from gcc -Wbad-function-cast.
19492 (xg_set_toolkit_scroll_bar_thumb): Use it.
19493 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
19494 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
19495 (get_utf8_string, xg_get_file_with_chooser):
19496 Rename locals to avoid shadowing.
19497 (create_dialog): Move locals to avoid shadowing.
7c86ee98 19498
41729b81
PE
19499 * xgselect.c (xg_select): Remove unused var.
19500
f0c77cd1
PE
19501 * image.c (four_corners_best): Mark locals as initialized.
19502 (gif_load): Initialize transparent_p to zero (Bug#8238).
19503 Mark another local as initialized.
ec6cf4c6 19504 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 19505
ce0ad53d 19506 * image.c (clear_image_cache): Now static.
d5d5a617 19507 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 19508 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
19509 (x_edge_detection): Remove unnecessary cast that
19510 gcc -Wbad-function-cast diagnoses.
2037898d 19511 (gif_load): Fix pointer signedness.
6ae141d6
PE
19512 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
19513 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 19514
33383987 195152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 19516
d32df629
PE
19517 Improve quality of tests for time stamp overflow.
19518 For example, without this patch (encode-time 0 0 0 1 1
19519 1152921504606846976) returns the obviously-bogus value (-948597
19520 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
19521 reports time overflow. See
19522 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
19523 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
19524 * editfns.c: Include limits.h and intprops.h.
19525 (TIME_T_MIN, TIME_T_MAX): New macros.
19526 (time_overflow): Move earlier, to before first use.
19527 (hi_time, lo_time): New functions, for an accurate test for
19528 out-of-range times.
19529 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
19530 (Fget_internal_run_time): Don't assume time_t fits in int.
19531 (make_time): Use list2 instead of Fcons twice.
19532 (Fdecode_time): More accurate test for out-of-range times.
19533 (check_tm_member): New function.
19534 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
19535 (lisp_time_argument): Don't rely on undefined left-shift and
19536 right-shift behavior when checking for time stamp overflow.
8be6f318 19537
fe31d94c
PE
19538 * editfns.c (time_overflow): New function, refactoring common code.
19539 (Fformat_time_string, Fdecode_time, Fencode_time):
19540 (Fcurrent_time_string): Use it.
19541
8be6f318
PE
19542 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
19543 * dired.c (make_time): Move to ...
19544 * editfns.c (make_time): ... here.
19545 * systime.h: Note the move.
19546
09d9db2c 195472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 19548
126bc0dc
YM
19549 * fringe.c (update_window_fringes): Remove unused variables.
19550
c47cbdfd
YM
19551 * unexmacosx.c (copy_data_segment): Also copy __got section.
19552 (Bug#8223)
19553
7ac80be9
EZ
195542011-03-12 Eli Zaretskii <eliz@gnu.org>
19555
c96bbc66 19556 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
19557 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
19558 Constify `char *' arguments and their references according to
19559 prototypes in tparam.h.
19560
ecb0f94d 19561 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 19562
7ac80be9
EZ
19563 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
19564 Adapt all references accordingly.
19565
19566 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
19567
ef1fd07e
TT
195682011-03-11 Tom Tromey <tromey@redhat.com>
19569
19570 * buffer.c (syms_of_buffer): Remove obsolete comment.
19571
7ef4b50c
EZ
195722011-03-11 Eli Zaretskii <eliz@gnu.org>
19573
19574 * termhooks.h (encode_terminal_code): Declare prototype.
19575
19576 * msdos.c (encode_terminal_code): Don't declare prototype.
19577
19578 * term.c (encode_terminal_code): Now external again, used by
19579 w32console.c and msdos.c.
19580
44f230aa
SM
19581 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
19582 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 19583
4b1ec863 195842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 19585
1714f52b 19586 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 19587
4b1ec863
PE
19588 * fringe.c (update_window_fringes): Mark locals as initialized
19589 (Bug#8227).
19590 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 19591
524c7aa6
PE
19592 * alloc.c (mark_fringe_data): Move decl from here ...
19593 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
19594 to check its interface.
19595 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
19596
a5c0af81 19597 * fontset.c (free_realized_fontset): Now static.
7519b8cd 19598 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 19599 (fontset_font): Mark local as initialized.
a9a06e0b 19600 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 19601
b4716021
PE
19602 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
19603
811e9bac 19604 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 19605 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
19606 (x_own_selection, Fx_disown_selection_internal): Rename locals
19607 to avoid shadowing.
19608 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 19609
7e3ab302
PE
19610 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
19611 so that the caller can use some name other than gcpro1.
19612 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
19613 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
19614 (Fx_backspace_delete_keys_p):
19615 Use them to avoid shadowing, and rename vars to avoid shadowing.
19616 (x_decode_color, x_set_name, x_window): Now static.
6b437900 19617 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 19618 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
19619 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
19620 Remove unused locals.
7e3ab302
PE
19621 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
19622 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
19623 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
19624 macros.
f78faa98 19625
e2b13473
PE
19626 * xterm.h (x_mouse_leave): New decl.
19627
77f23912
PE
19628 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
19629 Remove unused functions.
cdf4ba58
PE
19630 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
19631 (x_calc_absolute_position): Now static.
7411c686 19632 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 19633 Don't declare local "event" unless it's used.
ed7bf3a5
PE
19634 (x_iconify_frame, x_free_frame_resources): Don't declare locals
19635 unless they are used.
38d0b34a
PE
19636 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
19637 (x_fatal_error_signal): Remove; not used.
a6067996
PE
19638 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
19639 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
19640 (x_error_catcher, x_connection_closed, x_error_handler):
19641 (x_error_quitter, xembed_send_message, x_iconify_frame):
19642 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 19643 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 19644 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 19645
44f230aa
SM
19646 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
19647 Rename or move locals to avoid shadowing.
6b463e58 19648 (tty_defined_color, merge_face_heights): Now static.
5967d051 19649 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
19650 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
19651 does not deduce is never used uninitialized.
73719eba
PE
19652 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
19653 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 19654
426994c3 19655 * terminal.c (store_terminal_param): Now static.
5489860b 19656
032f1620 19657 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 19658 (set_frame_menubar): Remove unused local.
d4323972 19659 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
19660 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
19661 since they might point to immutable storage.
281585b0
PE
19662 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
19663 since it's unused otherwise.
032f1620 19664
367c19e5 19665 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 19666 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
19667 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
19668 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 19669 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
19670 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
19671 does not deduce are never used uninitialized.
70739cbe 19672
07b48fa9
PE
19673 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
19674
8868a238 19675 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
19676 * window.c (window_loop, size_window):
19677 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 19678
7e5cf297 19679 * window.c (display_buffer): Now static.
d6550a9f
PE
19680 (size_window): Mark variables that gcc -Wuninitialized
19681 does not deduce are never used uninitialized.
a586633d
PE
19682 * window.h (check_all_windows): New decl, to forestall
19683 gcc -Wmissing-prototypes diagnostic.
5b555da1 19684 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 19685
f6095868
PE
19686 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
19687 shadowing.
19688 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
19689 Include <limits.h>.
19690 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
19691 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
19692 (load_charset_map): Mark variables that gcc -Wuninitialized
19693 does not deduce are never used uninitialized.
53df7c11 19694 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 19695
f38b440c
PE
19696 * coding.c (coding_set_source, coding_set_destination):
19697 Use "else { /* comment */ }" rather than "else /* comment */;"
19698 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
19699 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
19700 a block, when the outer 'i' will do.
19701 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
19702 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
19703 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
19704 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
19705 (Fdecode_sjis_char, Fdefine_coding_system_internal):
19706 Rename locals to avoid shadowing.
19707 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
19708 * coding.c (emacs_mule_char, encode_invocation_designation):
19709 Now static, since they're not used elsewhere.
413bb2db 19710 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 19711 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
19712 (decode_coding_emacs_mule): Mark variables that gcc
19713 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
19714 (detect_coding_iso_2022): Initialize a local variable that might
19715 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 19716 this initialization is needed. (Bug#8211)
5f58e762
PE
19717 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
19718 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
19719 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
19720 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
19721 Remove unused macros.
f38b440c 19722
232b38b9 19723 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 19724 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 19725 * character.c (string_count_byte8): Likewise.
232b38b9 19726
fb90da1b
PE
19727 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
19728 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
19729
fb93dbc2
PE
19730 * chartab.c (copy_sub_char_table): Now static, since it's not used
19731 elsewhere.
5c156ace
PE
19732 (sub_char_table_ref_and_range, char_table_ref_and_range):
19733 Rename locals to avoid shadowing.
bbcd0949 19734 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 19735
7d3b3862 19736 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 19737 (BIDI_BOB): Remove unused macro.
7d3b3862 19738
6be7d3da
PE
19739 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
19740 deduce are never used uninitialized.
c2ed9c8b 19741 * term.c (encode_terminal_code): Likewise.
6be7d3da 19742
75f8807f 19743 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 19744
50938595
PE
19745 * tparam.h: New file.
19746 * term.c, tparam.h: Include it.
19747 * deps.mk (term.o, tparam.o): Depend on tparam.h.
19748 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
19749 Move these decls to tparam.h, and make them agree with what
19750 is actually in tparam.c. The previous trick of using incompatible
19751 decls in different modules does not conform to the C standard.
19752 All callers of tparam changed to use tparam's actual API.
19753 * tparam.c (tparam1, tparam, tgoto):
19754 Use const pointers where appropriate.
19755
fbceeba2
PE
19756 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
19757 * cm.h (struct cm): Likewise.
19758 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
19759 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
19760 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
19761 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
19762 (turn_on_face, init_tty): Likewise.
19763 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 19764
7f3f1250
PE
19765 * term.c (term_mouse_position): Rename local to avoid shadowing.
19766
e6ca6543
PE
19767 * alloc.c (mark_ttys): Move decl from here ...
19768 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
19769
c40f8d15
AS
197702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
19771
19772 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
19773
cfe0661d
JB
197742011-03-09 Juanma Barranquero <lekktu@gmail.com>
19775
19776 * search.c (compile_pattern_1): Remove argument regp, unused since
19777 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
19778 (compile_pattern): Don't pass it.
19779
0afb4571
J
197802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
19781
19782 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
19783 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
19784 for ! HAVE_GTK3.
19785 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
19786
19787 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
19788
19789 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
19790 gdk_window_get_screen, gdk_window_get_geometry,
19791 gdk_x11_window_lookup_for_display and GDK_KEY_g.
19792 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
19793 (xg_get_pixbuf_from_pixmap): New function.
19794 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
19795 to Pixmap, take frame as parameter, remove GdkColormap parameter.
19796 Call xg_get_pixbuf_from_pixmap instead of
19797 gdk_pixbuf_get_from_drawable.
19798 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
19799 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
19800 (xg_check_special_colors): Use GtkStyleContext and its functions
19801 for HAVE_GTK3.
19802 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
19803 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
19804 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
19805 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
19806 Call gtk_widget_get_preferred_size.
0afb4571
J
19807 (xg_frame_resized): gdk_window_get_geometry only takes 5
19808 parameters.
44f230aa
SM
19809 (xg_win_to_widget, xg_event_is_for_menubar):
19810 Call gdk_x11_window_lookup_for_display.
0afb4571
J
19811 (xg_set_widget_bg): New function.
19812 (delete_cb): New function.
895009e1 19813 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 19814 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
19815 (xg_set_background_color): Call xg_set_widget_bg.
19816 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
19817 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
19818 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
19819 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
19820 if ! HAVE_GTK3.
19821 (update_frame_tool_bar): Call gtk_widget_hide.
19822 (xg_initialize): Use GDK_KEY_g.
19823
19824 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
19825 if ! HAVE_GTK3
19826 (x_session_initialize): Call gdk_x11_set_sm_client_id.
19827
19828 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
19829 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
19830 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
19831
1c2cc4ef
JB
198322011-03-08 Juanma Barranquero <lekktu@gmail.com>
19833
19834 * w32xfns.c (select_palette): Check success of RealizePalette against
19835 GDI_ERROR, not zero.
19836
33383987 19837See ChangeLog.11 for earlier changes.
aac0c6e3
MR
19838
19839;; Local Variables:
19840;; coding: utf-8
aac0c6e3
MR
19841;; End:
19842
ab422c4d 19843 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
19844
19845 This file is part of GNU Emacs.
19846
19847 GNU Emacs is free software: you can redistribute it and/or modify
19848 it under the terms of the GNU General Public License as published by
19849 the Free Software Foundation, either version 3 of the License, or
19850 (at your option) any later version.
19851
19852 GNU Emacs is distributed in the hope that it will be useful,
19853 but WITHOUT ANY WARRANTY; without even the implied warranty of
19854 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19855 GNU General Public License for more details.
19856
19857 You should have received a copy of the GNU General Public License
19858 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.