calccomp.el (math-compose-expr): Use parentheses when
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6195f384
DA
12012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fast save_excursion_save and save_excursion_restore.
4 * lisp.h (struct Lisp_Excursion): New data type.
5 (PVEC_EXCURSION): New pseudovector type.
6 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
7 to deal with it. Adjust comments.
8 (init_marker, attach_marker): New prototype.
9 (unchain_marker): Adjust prototype.
10 * marker.c (attach_marker): Change to global.
11 (init_marker): New function.
12 * alloc.c (Fmake_marker, build_marker): Use it.
13 (build_marker): More easserts.
14 (mark_object): Handle struct Lisp_Excursion.
15 * editfns.c (save_excursion_save, save_excursion_restore):
16 Reimplement to use struct Lisp_Excursion. Add comments.
17
5eceb8fb
PE
182012-07-26 Paul Eggert <eggert@cs.ucla.edu>
19
20 Fix export of symbols to GDB (Bug#12036).
21 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
22 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
23 emacs.c, as this is a more-suitable home. Had this been done earlier
24 the fix for 12036 would have avoided some of the problems noted in
25 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
26 would have been more obvious.
562157c8
PE
27 * emacs.c: Do not include <verify.h>; no longer needed.
28 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
29 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
30 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
31 Remove; now done in lisp.h.
32 * lisp.h (PUBLISH_TO_GDB): New macro.
33 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
34 (DATA_SEG_BITS): Use it.
35 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
36 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
37 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
38 not be usable in #if. This simplifies things.
39
d6749401
JB
402012-07-26 Juanma Barranquero <lekktu@gmail.com>
41
42 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
43
1781b9e9
PE
442012-07-26 Paul Eggert <eggert@cs.ucla.edu>
45
d89518db 46 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
47 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
48 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
49 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
50 Adjust to changes in lisp.h and emacs.c, by using
51 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
52 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
53 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
54 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
55 instead of gdb_valbits.
56 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
57 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
58 instead of gdb_array_mark_flag.
59 (xboolvector): Get size from $->size, not $->header.size.
60 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
61 (xreload, hook-run, hookpost-run): Remove.
62 * emacs.c: Include <verify.h>.
63 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
64 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
65 Remove.
66 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
67 (gdb_USE_LSB_TAG): New enum constants.
68 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
69 Also define these as enum constants, so they're visible to GDB.
70 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
71 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
72 as constants, so they're visible to GDB.
73 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
74 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
75 Now enum constants, not macros, so they're visible to GDB.
76 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
77 more convenient now. All uses changed.
78 (VALMASK) [USE_LSB_TAG]: Also define in this case.
79 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
80
3628596a
DA
812012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
82
83 Explicitly free restriction data that are not needed anymore.
84 * editfns.c (save_restriction_restore): Free restriction data.
85
7abaf5cc
SM
862012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
87
88 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
89 add argument, tune behavior, and adjust all callers.
90
71f88e00
PE
912012-07-25 Paul Eggert <eggert@cs.ucla.edu>
92
93 Use typedef for EMACS_INT, EMACS_UINT.
94 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
95 than macros. This simplifies debugging in the usual case, since
96 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
97 and it allows expressions involving EMACS_INT casts.
98 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
99
57ec3034
JD
1002012-07-25 Jan Djärv <jan.h.d@swipnet.se>
101
102 * nsterm.m (ns_read_socket): Return early if there is a modal
103 window (Bug#12043).
104
8137e7b3
MR
1052012-07-25 Martin Rudalics <rudalics@gmx.at>
106
107 * frame.c (Fredirect_frame_focus): In doc-string don't mention
108 that FOCUS-FRAME can be omitted.
109
04e9897c
DA
1102012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Adjust buffer text indirection counters at the end of Fkill_buffer.
113 * buffer.c (Fkill_buffer): Adjust indirection counters when the
114 buffer is definitely dead. This should really fix an issue reported
115 by Christoph Scholtes again. (Bug#12007).
116 (init_buffer_once): Initialize indirection counters of
117 buffer_defaults and buffer_local_symbols (for sanity and safety).
118
8a0484e1
EZ
1192012-07-24 Eli Zaretskii <eliz@gnu.org>
120
121 * xdisp.c (init_iterator): Don't compute dimensions of truncation
122 and continuation glyphs on tooltip frames, leave them at zero.
123 Avoids continued lines in tooltips. (Bug#11832)
124
fa691a83
DA
1252012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
126
127 Simplify copy_overlay.
04e9897c 128 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
129 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
130
436bc8e0
EZ
1312012-07-23 Eli Zaretskii <eliz@gnu.org>
132
133 * print.c (print_object): Don't crash when a frame's name is nil
134 or invalid. (Bug#12025)
135
136 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
137 it signals an error when a tooltip frame is being created.
138
d7a7fda3
DA
1392012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
140
141 Cleanup miscellaneous objects allocation and initialization.
142 * alloc.c (allocate_misc): Change to static. Add argument to
143 specify the subtype. Adjust comment and users.
144 (build_overlay): New function.
145 * buffer.c (copy_overlays, Fmake_overlay): Use it.
146 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
147 (allocate_misc): Remove prototype.
148 (build_overlay): Add prototype.
149
1502012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
151
152 Swap buffer text indirection counters in Fbuffer_swap_text.
153 * buffer.c (Fbuffer_swap_text): Swap indirections too.
154 This avoids crash reported by Christoph Scholtes at
155 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
156
9d7fa573
JD
1572012-07-22 Jan Djärv <jan.h.d@swipnet.se>
158
159 * nsmenu.m (Popdown_data): New struct.
160 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
161 free Popdown_data.
162 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
163 (initWithContentRect): Make imgView and contentView non-static
164 and autorelease them. Also autorelease img and matrix (Bug#12005).
165 (dealloc): Remove (Bug#12005).
166
0dd6d66d
DA
1672012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
168
169 Adjust consing_since_gc when objects are explicitly freed.
170 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
171 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
172 (free_cons, free_misc): Subtract object size from consing_since_gc.
173
d36d71df
DA
1742012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Simplify and cleanup markers positioning code.
177 * marker.c (attach_marker): More useful eassert.
178 (live_buffer, set_marker_internal): New function.
179 (Fset_marker, set_marker_restricted): Use set_marker_internal.
180 (set_marker_both, set_marker_restricted_both): Use live_buffer.
181
fb9ea40f
PE
1822012-07-22 Paul Eggert <eggert@cs.ucla.edu>
183
184 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
185 as it's limited by the amount of memory, not by INT_MAX.
186
2d5c5f7d
EZ
1872012-07-21 Eli Zaretskii <eliz@gnu.org>
188
07fb592e
EZ
189 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
190 in special-event-map. See the discussion at
191 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
192 for the reasons.
193
37a9eac8 194 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
195 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
196 Fabrice Popineau <fabrice.popineau@supelec.fr>.
197
c4328746
JD
1982012-07-21 Jan Djärv <jan.h.d@swipnet.se>
199
200 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 201 (conversationIdentifier): Return value is NSInteger.
784051c4 202 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 203
6e5d1c12
CY
2042012-07-21 Chong Yidong <cyd@gnu.org>
205
206 * window.c (decode_any_window): Signal an error if the window is
207 on a dead frame (Bug#11984).
208
9928463d
DA
2092012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
210
211 Add indirection counting to speed up Fkill_buffer.
212 * buffer.h (struct buffer): New member.
213 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
214 (Fmake_indirect_buffer): Set indirection counter to -1, increment
215 base buffer indirection counter.
216 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
217 (Fkill_buffer): Adjust indirection counters as needed, don't walk
218 through buffer list if indirection counter is 0.
219
f8643a6b
DA
2202012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Extend the value returned by Fgarbage_collect with heap statistics.
223 * alloc.c (Qheap): New symbol.
224 (syms_of_alloc): DEFSYM it.
225 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
226 (Fmemory_free): Remove.
227 (syms_of_alloc): Don't defsubr it.
228 * buffer.c (Fcompact_buffer): Remove.
229 (syms_of_buffer): Don't defsubr it.
230
dac616ff
DA
2312012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
232
233 Make maybe_gc inline.
234 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
235 * lisp.h (consing_since_gc, gc_relative_threshold)
236 (memory_full_cons_threshold): Revert declaration.
237 (maybe_gc): Remove prototype, define as inline.
238 * alloc.c: Remove old commented-out code.
239 (consing_since_gc, gc_relative_threshold)
240 (memory_full_cons_threshold): Revert to global.
241 (maybe_gc): Remove.
242
d7ea76b4
DA
2432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
246 * lisp.h (build_unibyte_string): New function.
247 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
248 * sysdep.c, w32fns.c, xfns.c: Use it.
249 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
250 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
251 Adjust users accordingly.
252 * font.h (font_open_by_name): Adjust prototype.
253
765e61e3
DA
2542012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
255
256 Cleanup calls to Fgarbage_collect.
257 * lisp.h (maybe_gc): New prototype.
258 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
259 Remove declarations.
260 * alloc.c (maybe_gc): New function.
261 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
262 Make them static.
263 * bytecode.c (MAYBE_GC): Use maybe_gc.
264 * eval.c (eval_sub, Ffuncall): Likewise.
265 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
266 to avoid dependency from auto-save feature.
267
52b852c7
PE
2682012-07-19 Paul Eggert <eggert@cs.ucla.edu>
269
270 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
271 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
272 'for_each_per_buffer_object_at'.
273 All uses changed. It's better to use upper-case for macros that
274 cannot be implemented as functions, to give the reader a clue
275 that they're special.
276
5db81e33
SM
2772012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
278
279 * alloc.c (Fgarbage_collect): Tweak docstring.
280
5b835e1d
DA
2812012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
282
283 Tweak the value returned from Fgarbage_collect again.
284 * alloc.c (Fgarbage_collect): New return value, as confirmed in
285 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
286 Adjust documentation.
287 (total_vector_bytes): Rename to total_vector_slots, adjust
288 accounting.
289 (total_free_vector_bytes): Rename to total_free_vector_slots,
290 adjust accounting.
291 (Qstring_bytes, Qvector_slots): New symbols.
292 (syms_of_alloc): DEFSYM them.
293
9cd47b72
DA
2942012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
295
296 Buffer compaction primitive which may be used from Lisp.
297 * buffer.c (compact_buffer, Fcompact_buffer): New function.
298 (syms_of_buffer): Register Fcompact_buffer.
299 * alloc.c (Fgarbage_collect): Use compact_buffer.
300 * buffer.h (compact_buffer): New prototype.
301 (struct buffer_text): New member.
302
d17337e5
DA
3032012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
304
305 New macro to iterate over all buffers, miscellaneous cleanups.
306 * lisp.h (all_buffers): Remove declaration.
307 * buffer.h (all_buffers): Add declaration, with comment.
308 (for_each_buffer): New macro.
309 * alloc.c (Fgarbage_collect, mark_object): Use it.
310 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
311 (init_buffer): Likewise.
312 * data.c (Fset_default): Likewise.
313 * coding.c (code_conversion_restore): Remove redundant check
314 for dead buffer.
315 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
316
60cfd278
AS
3172012-07-18 Andreas Schwab <schwab@linux-m68k.org>
318
319 Fix bug that created negative-length intervals.
320 * intervals.c (merge_interval_right, merge_interval_left):
321 Do not zero out this interval if it is absorbed by its children,
322 as this interval's total length doesn't change in that case. See
323 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
324
d06714cb
PE
3252012-07-18 Paul Eggert <eggert@cs.ucla.edu>
326
83713154
PE
327 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
328 when invoking (make-bool-vector N t) and N is a positive
329 multiple of 8 -- the last 8 bits were mistakenly cleared.
330
d06714cb
PE
331 Remove some struct layout assumptions in bool vectors.
332 * alloc.c (bool_header_size): New constant.
333 (header_size, word_size): Move earlier, as they're now used earlier.
334 Use 'word_size' in a few more places, where it's appropriate.
335 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
336 padding before the data member of a bool vector.
337 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
338 than doing the check by hand with an abort ().
339
464d5a5e
SM
3402012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
341
5fbc0409
SM
342 * eval.c (Fdefvar): Don't check constants since we only set the var if
343 it's not yet defined anyway (bug#11904).
344
464d5a5e
SM
345 * lisp.h (last_undo_boundary): Declare new var.
346 * keyboard.c (command_loop_1): Set it.
347 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
348 were auto-added by the command loop (bug#11774).
349
8dc2e44a
AS
3502012-07-18 Andreas Schwab <schwab@linux-m68k.org>
351
352 * w32font.c (Qsymbol): Remove local definition.
353 (syms_of_w32font): Don't DEFSYM it.
354
169925ec
DA
3552012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Fix sweep_vectors to handle large bool vectors correctly.
358 * alloc.c (sweep_vectors): Account total_vector_bytes for
359 bool vectors larger than VBLOCK_BYTES_MAX.
360
5fbfb018
CY
3612012-07-18 Chong Yidong <cyd@gnu.org>
362
363 * frame.c (x_set_frame_parameters): Revert bogus change introduced
364 in 2012-05-25 commit by Paul Eggert (Bug#11738).
365
3ab6e069
DA
3662012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Return more descriptive data from Fgarbage_collect.
369 Suggested by Stefan Monnier in
370 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
371 * alloc.c (bounded_number): New function.
372 (total_buffers, total_vectors): New variable.
373 (total_string_size): Rename to total_string_bytes, adjust users.
374 (total_vector_size): Rename to total_vector_bytes, adjust users.
375 (sweep_vectors): Account total_vectors and total_vector_bytes.
376 (Fgarbage_collect): New return value. Adjust documentation.
377 (gc_sweep): Account total_buffers.
378 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
379 (VECTOR_SIZE): Remove.
380 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
381 (Qinterval, Qmisc): New symbols.
382 (syms_of_data): Initialize them.
383 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
384 (Qcons, Qbuffer): New declarations.
385
6d02fe5b
PE
3862012-07-17 Paul Eggert <eggert@cs.ucla.edu>
387
388 * alloc.c (Fmemory_free): Account for memory-free's own storage.
389 Round up, not down. Improve doc.
390
b7ffe040
DA
3912012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
392
393 Restore old code in allocate_string_data to avoid Faset breakage.
394 Reported by Julien Danjou <julien@danjou.info> in
395 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
396 * alloc.c (allocate_string_data): Restore old code with minor
397 adjustments, fix comment to explain this subtle issue.
398
4dc7c8d5
SM
3992012-07-17 Eli Zaretskii <eliz@gnu.org>
400
401 Remove FILE_SYSTEM_CASE.
402 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
403
404 * fileio.c (FILE_SYSTEM_CASE): Don't define.
405 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
406 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
407 call-process-region passes it through expand-file-name.
408
409 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
410
4112012-07-17 Andreas Schwab <schwab@linux-m68k.org>
412
413 Fix crash when creating indirect buffer (Bug#11917)
414 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
415 Don't handle unbound variables specially if non-zero.
416 (Fbuffer_local_variables): Pass zero.
417 (clone_per_buffer_values): Pass non-zero.
418
4192012-07-17 Andreas Schwab <schwab@linux-m68k.org>
420
421 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
422 to make the loop interruptible.
423
4242012-07-17 Andreas Schwab <schwab@linux-m68k.org>
425
426 * gnutls.c (emacs_gnutls_handshake): Only retry if
427 GNUTLS_E_INTERRUPTED.
428
cce7fefc
DA
4292012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
430
431 Cleanup and convert miscellaneous checks to eassert.
432 * alloc.c (mark_interval): Fix comment, partially rephrase
433 old comment from intervals.h (see below).
434 * intervals.c (find_interval, adjust_intervals_for_insertion)
435 (delete_interval, adjust_intervals_for_deletion)
436 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
437 Convert to eassert.
438 (adjust_intervals_for_insertion, make_new_interval):
439 Remove obsolete and unused code.
440 * intervals.h (struct interval): Remove obsolete comment.
441 * textprotp.c (erase_properties): Remove unused code.
442 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
443 (Fremove_list_of_text_properties): Convert to eassert.
444
9ea10cc3
CY
4452012-07-17 Chong Yidong <cyd@gnu.org>
446
447 * editfns.c (Finsert_char): Doc fix.
448
3900d5de
DA
4492012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Fix previous change to make Fmemory_free always accurate.
452 * alloc.c (make_interval): Update total_free_intervals.
453 (make_float): Likewise for total_free_floats.
454 (free_cons, Fcons): Likewise for total_free_conses.
455 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
456 Likewise for total_free_vector_bytes.
457 (Fmake_symbol): Likewise for total_free_symbols.
458 (bytes_free): Remove.
459
7098646f
DA
4602012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Simple free memory accounting feature.
463 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
464 (sweep_vectors): Accumulate size of free vectors.
465 (Fgarbage_collect): Setup bytes_free.
466 (Fmemory_free): New function.
467 (syms_of_alloc): Register it.
468
22657b40
DA
4692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Cleanup overlays checking.
472 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
473 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
474 eassert and OVERLAYP.
475 (sort_overlays): Change to use OVERLAYP.
476
ddfc8813
RK
4772012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
478
479 * editfns.c (Finsert_char): Make it interactive, and make the
480 second arg optional. Copy interactive spec and docstring from
481 ucs-insert.
482
7c26cf3c
PE
4832012-07-17 Paul Eggert <eggert@cs.ucla.edu>
484
485 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
486 Unlike the other wrapped functions, fabs has an unspecified
487 effect on errno.
488
5d127af9
JD
4892012-07-16 Jan Djärv <jan.h.d@swipnet.se>
490
491 * nsterm.m (keyDown): Interpret flags without left/right bits
492 as the left key (Bug#11670).
493
6a0dd1d7
DA
4942012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
495
496 Remove empty and useless init functions.
497 * lisp.h (init_character_once, init_fns, init_image)
498 (init_filelock, init_sound): Remove prototype.
499 * character.c (init_character_once): Remove.
500 * filelock.c (init_filelock): Likewise.
501 * fns.c (init_fns): Likewise.
502 * image.c (init_image): Likewise.
503 * sound.c (init_sound): Likewise.
504 * emacs.c (main): Adjust accordingly.
505
7a6136fd
DA
5062012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
507
508 * gtkutil.h: Tiny cleanups.
509 (use_old_gtk_file_dialog): Remove useless declaration.
510 (xg_uses_old_file_dialog): Add suggested const attribute.
511
ce811ad9
EZ
5122012-07-15 Eli Zaretskii <eliz@gnu.org>
513
514 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
515 (bidi_paragraph_init): Use it to limit search forward for a strong
516 directional character in abnormally large paragraphs full of
517 neutral or weak characters. (Bug#11943)
518
c9adfeaa
SF
5192012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
520
521 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
522 the toolbar (Bug#9451).
523 (xg_make_tool_item): Give the widget event box a transparent
524 background.
525
fff62aa9
DA
5262012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
527
528 Cleanup basic allocation variables and functions.
529 * alloc.c (ignore_warnings, init_intervals, init_float)
530 (init_cons, init_symbol, init_marker): Remove.
531 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
532 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
533 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
534 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
535 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
536 (staticidx, init_alloc_once, init_strings, free_ablock):
537 Remove redundant initialization.
538 * fns.c (init_weak_hash_tables): Remove.
539 * lisp.h (init_weak_hash_tables): Remove prototype.
540
9730daca
DA
5412012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
542
543 Use zero_vector where appropriate.
544 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
545 accordingly.
546 * lisp.h (zero_vector): New declaration.
547 * font.c (null_vector): Remove.
548 (syms_of_font): Remove initialization and staticpro.
549 (font_list_entities, font_find_for_lface): Change to use zero_vector.
550 * keymap.c (Faccessible_keymaps): Likewise.
551
2e2d2a13
LL
5522012-07-15 Leo Liu <sdl.web@gmail.com>
553
554 * fringe.c: Fix typo in comments.
555
cd276f6e
LL
5562012-07-14 Leo Liu <sdl.web@gmail.com>
557
558 * fringe.c: Add a new bitmap exclamation-mark.
559
5a1131d9
EZ
5602012-07-14 Eli Zaretskii <eliz@gnu.org>
561
562 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
563
564 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
565 (HAVE_MENUS): Don't define, defined by editing config.in with
566 msdos/sed2v2.inp.
567 (GMALLOC_INHIBIT_VALLOC): Don't define.
568 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
569
22e983b7
JB
5702012-07-14 Juanma Barranquero <lekktu@gmail.com>
571
572 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
573
5b3f250f
GM
5742012-07-14 Glenn Morris <rgm@gnu.org>
575
576 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
577 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
578 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
579
33d63ff4
GM
5802012-07-13 Glenn Morris <rgm@gnu.org>
581
5b633342
GM
582 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
583
33d63ff4
GM
584 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
585 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
586
b55b9f85
JD
5872012-07-13 Jan Djärv <jan.h.d@swipnet.se>
588
0dc8cf50
JD
589 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
590 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
591 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
592 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
593 where appropriate.
594 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
595 as boolean expression.
596 (x_set_window_size): Remove unused variable toolbar.
597 (ns_get_color_default, ns_mod_to_lisp): Remove.
598 (ns_mouse_position): Remove unused variables xchar and ychar.
599 (ns_compute_glyph_string_overhangs): Remove unused variable face.
600 (ns_set_vertical_scroll_bar): Remove unused variable count.
601 (ns_delete_terminal): Remove unused variable i.
602 (ns_term_init): Remove unused variables r, g and b.
603 (mouseDown): Remove unused variable window.
604 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
605 (initFrameFromEmacs): Remove unused variable vbextra.
606 (mouseEntered): Remove unused variables p and dpyinfo.
607 (mouseExited): Remove unused variables p and r.
608 (ns_define_frame_cursor, ns_clear_frame_area)
609 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
610 (menuDown): Assign [sender tag] to variable and cast the variable.
611
612 * nsterm.h (menuDown): Add id as type to argument sender.
613 (ns_display_info_for_name): Add Lisp_Object argument.
614 (ns_term_init): Add Lisp_Object argument.
615 (ns_map_event_to_object): Add void argument.
616 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
617 prototype with arguments and only declare if __OBJC__.
618 (nxatoms_of_nsselect): Add void argument.
619 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
620 (ns_alloc_autorelease_pool): Add void argument.
621 (ns_release_autorelease_pool): Add void* argument.
622 (ns_get_defaults_value): Add const char* argument.
623
624 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
625 (initFromContents): Use SSDATA where appropriate.
626 (ns_update_menubar): Add braces to ambigous if-else.
627 (initWithTitle): Put () around assignment in if statement.
628 (ns_menu_show): Remove unused variables window and keymap.
629 (update_frame_tool_bar): Remove unused variable selected_p.
630 (initWithContentRect): Remove unused variable this_cmd_name.
631
632 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
633 appropriate.
634 (setXBMColor): Remove unused variable len.
635 (setPixmapData): Put () around assignment in loop statement.
636
637 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
638 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
639 where appropriate.
640 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
641 around assignment in loop statement.
642 (nsfont_open): Remove unused variable i.
643 (nsfont_open): Remove unused variable len.
644 (nsfont_draw): Remove unused variable cs.
645
646 * nsfns.m (x_set_icon_name, ns_set_name_internal)
647 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
648 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
649 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
650 (Fns_font_name, Fns_perform_service)
651 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
652 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
653 (ns_set_name): Remove unused variable view.
654 (x_set_menu_bar_lines): Remove unused variable olines.
655 (x_set_tool_bar_lines): Remove unused variable root_window.
656 (Fns_list_colors): Put () around assignment in while statement.
657 (Fns_perform_service): Remove unused variable len.
658 (Fns_display_usable_bounds): Remove unused variable top.
659 (syms_of_nsfns): Remove unused variable i.
660
b55b9f85
JD
661 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
662 memcpy (Bug#11907).
663
ed9265fc 6642012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
665
666 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
667 and free it with DestroyExceptionInfo (Bug#11558).
668
ef099b57
JB
6692012-07-13 Juanma Barranquero <lekktu@gmail.com>
670
671 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
672 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
673 Set here, not in nt/config.nt.
674
ea814a5d
EZ
6752012-07-13 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
678 cursor overflow into the last glyph on display line when the right
679 fringe is off. (Bug#11832)
680
1a952767
PE
6812012-07-13 Paul Eggert <eggert@cs.ucla.edu>
682
683 * xdisp.c (produce_special_glyphs): Now static.
684 * dispextern.h (produce_special_glyphs): Remove decl.
685
983188fd
GM
6862012-07-13 Glenn Morris <rgm@gnu.org>
687
32fb4bb6
GM
688 * s/bsd-common, s/cygwin.h: Remove empty files.
689 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
690
983188fd
GM
691 * s/usg5-4-common.h (USG, USG5):
692 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
693 * s/sol2-6.h (SOLARIS2):
694 * s/irix6-5.h (IRIX6_5):
695 * s/hpux10-20.h (USG, USG5, HPUX):
696 * s/gnu-linux.h (USG, GNU_LINUX):
697 * s/freebsd.h (BSD_SYSTEM):
698 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
699 * s/cygwin.h (CYGWIN):
700 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
701 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
702
d1e68667 7032012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
704
705 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 706
6de0e799
GM
7072012-07-13 Glenn Morris <rgm@gnu.org>
708
739ae010
GM
709 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
710
dbee5793
GM
711 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
712
6de0e799
GM
713 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
714 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
715
b82da769
GM
7162012-07-12 Glenn Morris <rgm@gnu.org>
717
4fae5a7a 718 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
719
720 * process.c (init_process_emacs): Rename from init_process.
721 The old name is also the name of a Mach system call.
722 * lisp.h, emacs.c: Update for this name change.
723 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
724 longer needed.
725
5a979817
EZ
7262012-07-12 Eli Zaretskii <eliz@gnu.org>
727
728 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
729 memmove call that removes glyphs covered by the left truncation
730 glyph. Improve commentary.
731 (display_line): Fix display of continuation glyphs on GUI frames
732 when the right fringe is turned off and variable-size fonts are
733 used in the window. Move the code that appends a stretch glyph to
734 produce_special_glyphs, so that it could be used for truncation
735 and continuation glyphs alike.
736 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
737 glyph of a suitably computed width, to align the special glyphs at
738 the window margin. Code moved from display_line. (Bug#11832)
739
3e91a053
GM
7402012-07-12 Glenn Morris <rgm@gnu.org>
741
ba9e4b84
GM
742 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
743
744 * s/gnu-linux.h, s/hpux10-20.h:
745 Do not unconditionally define HAVE_XRMSETDATABASE.
746
3e91a053
GM
747 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
748
b300b1f4
PE
7492012-07-12 Paul Eggert <eggert@cs.ucla.edu>
750
751 Fix typos that broke OS X build.
752 Reported by Randal L. Schwartz in
753 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
754 * nsterm.m (ns_timeout): Add missing local decl.
755 (ns_get_color): snprintf -> sprintf, to fix typo.
756
6e777848
GM
7572012-07-12 Glenn Morris <rgm@gnu.org>
758
3f922c37
GM
759 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
760 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
761 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
762 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
763
0ab7b23a
GM
764 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
765 Move PTY_OPEN to configure.
766
6e777848
GM
767 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
768 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
769 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
770
4a7edc24
DA
7712012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Use empty_unibyte_string where applicable.
774 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
775 * lread.c (read1): Likewise.
776 * xsettings.c (syms_of_xsettings): Likewise.
777
308aab79
GM
7782012-07-12 Glenn Morris <rgm@gnu.org>
779
42bd1719
GM
780 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
781 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
782 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
783 * s/hpux10-20.h (RUN_TIME_REMAP):
784 * s/bsd-common.h (TABDLY): Move to configure.
785
786 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
787
788 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
789
ea0bbd17 790 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 791 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
792
793 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 794
308aab79
GM
795 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
796 * s/template.h: Move NARROWPROTO to configure.
797
ee1cf5cf
GM
7982012-07-11 Glenn Morris <rgm@gnu.org>
799
30fe9bf4
GM
800 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
801 unused since 2011-01-17 change to systty.h.
802
ee1cf5cf
GM
803 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
804 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
805 Move HAVE_PTYS and HAVE_SOCKETS to configure.
806
63e47e07
PE
8072012-07-11 Paul Eggert <eggert@cs.ucla.edu>
808
809 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
810
c43fb4c3
GM
8112012-07-11 Glenn Morris <rgm@gnu.org>
812
813 * s/darwin.h, s/gnu-linux.h, s/template.h:
814 Move INTERRUPT_INPUT to configure.
815
e8df9267
DA
8162012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
817
818 Minor adjustments to interning code.
819 * lisp.h (intern, intern_c_string): Redefine as static inline
820 wrappers for intern_1 and intern_c_string_1, respectively.
821 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
822 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
823 Vobarray checking.
e8df9267
DA
824 * font.c (font_intern_prop): Likewise. Adjust comment.
825 * w32font.c (intern_font_name): Likewise.
826
34348bd4
AS
8272012-07-11 Andreas Schwab <schwab@linux-m68k.org>
828
d96a1e0c
AS
829 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
830
34348bd4
AS
831 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
832 of Fcar/Fcdr if possible.
833 * font.c (check_otf_features): Likewise.
834 * fontset.c (Fnew_fontset): Likewise.
835 * gnutls.c (Fgnutls_boot): Likewise.
836 * minibuf.c (read_minibuf): Likewise.
837 * msdos.c (IT_set_frame_parameters): Likewise.
838 * xmenu.c (Fx_popup_dialog): Likewise.
839 * w32menu.c (Fx_popup_dialog): Likewise.
840
c8add24e
GM
8412012-07-11 Glenn Morris <rgm@gnu.org>
842
4b575b3c
GM
843 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
844 since nothing has defined it on these platforms.
845
09f4e3b0
GM
846 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
847 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
848
172bedef
GM
849 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
850 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
851 Move CLASH_DETECTION to configure.
852
249685df
GM
853 * s/gnu.h: Remove file, which is now empty.
854
c8add24e
GM
855 * s/gnu.h, s/gnu-linux.h:
856 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
857
b41253a3
JW
8582012-07-11 John Wiegley <johnw@newartisans.com>
859
860 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
861 function attribute, so we only use it if it exists in the
862 compiler.
863
d923b542
DA
8642012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Avoid call to strlen in fast_c_string_match_ignore_case.
867 * search.c (fast_c_string_match_ignore_case): Change to use
868 length argument. Adjust users accordingly.
869 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
870
5ebbef1d
PE
8712012-07-11 Paul Eggert <eggert@cs.ucla.edu>
872
bb352260
PE
873 Assume mkdir, rmdir.
874 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
875 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
876
57054ddd
PE
877 Assume rename.
878 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
879
b747d3f7
PE
880 Assume perror.
881 * s/hpux10-20.h (HAVE_PERROR): Remove.
882 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
883 Remove dummy definition, as this problem was obsolete long ago.
884
5ebbef1d
PE
885 Assume strerror.
886 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
887
984e7f30
DA
8882012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
889
890 Avoid calls to strlen in font processing functions.
891 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 892 (font_open_by_name): Change to use length argument. Adjust
984e7f30 893 users accordingly.
d923b542
DA
894 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
895 Adjust prototypes.
896 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
897 Change to return ptrdiff_t.
984e7f30
DA
898 (xfont_list_pattern, xfont_match): Use length returned by
899 xfont_decode_coding_xlfd.
900 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
901
20e94fdd
GM
9022012-07-11 Glenn Morris <rgm@gnu.org>
903
9d596af3
GM
904 * s/darwin.h, s/freebsd.h, s/netbsd.h:
905 Move DONT_REOPEN_PTY to configure.
906
20e94fdd
GM
907 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
908 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
909
e99a530f
PE
9102012-07-10 Paul Eggert <eggert@cs.ucla.edu>
911
22ffb973
PE
912 Remove "#define unix" that is no longer needed (Bug#11905).
913 * s/aix4-2.h (unix): Remove; no longer needed.
914
e9a9ae03
PE
915 EMACS_TIME simplification (Bug#11875).
916 This replaces macros (which typically do not work in GDB)
917 with functions, typedefs and enums, making the code easier to debug.
918 The functional style also makes code easier to read and maintain.
919 * systime.h: Include <sys/time.h> on all hosts, not just if
920 WINDOWSNT, since 'struct timeval' is needed in general.
921 (EMACS_TIME): Now a typedef, not a macro.
922 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
923 not macros.
924 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
925 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
926 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
927 (EMACS_TIME_LE): Now functions, not macros.
928 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
929 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
930 which are not functions. All uses rewritten to use:
931 (make_emacs_time): New function.
932 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
933 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
934 not functions. All uses rewritten to use the following, respectively:
935 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
936 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 937 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
938 * fileio.c (Fcopy_file):
939 * xterm.c (XTflash): Get the current time closer to when it's used.
940 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
941
ffacb126
PE
942 * bytecode.c (targets): Suppress -Woverride-init warnings.
943
e99a530f
PE
944 Simplify by avoiding confusing use of strncpy etc.
945 * doc.c (Fsnarf_documentation):
946 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
947 * frame.c (Fmake_terminal_frame):
948 * gtkutil.c (get_utf8_string):
949 * lread.c (openp):
950 * nsmenu.m (ns_update_menubar):
951 * regex.c (regerror):
952 Prefer memcpy to strncpy and strncat when either will do.
953 * fileio.c (Fsubstitute_in_file_name):
954 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
955 (menu_separator_name_p):
956 * nsmenu.m (ns_update_menubar):
957 Prefer memcmp to strncmp when either will do.
958 * nsterm.m: Include <ftoastr.h>.
959 (ns_get_color):
960 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
961 Prefer snprintf to strncpy.
962 * nsterm.m (ns_term_init):
963 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
964 * nsterm.m (ns_term_init):
965 Avoid the need for strncpy, by using build_string or
966 make_unibyte_string directly. Use dtoastr, not snprintf.
967 * process.c (Fmake_network_process): Diagnose service names that
968 are too long, rather than silently truncating them or creating
969 non-null-terminated names.
970 (Fnetwork_interface_info): Likewise, for interface names.
971 * sysdep.c (system_process_attributes) [GNU_LINUX]:
972 Prefer sprintf to strncat.
973 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
974 Prefer vsnprintf to vsprintf + strncpy.
975
c59592b3
GM
9762012-07-10 Glenn Morris <rgm@gnu.org>
977
978 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
979 Clarify fallback case.
980
7d7bbefd
DA
9812012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
982
983 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
984 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
985 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 986 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
987 where argument type is known to be a Lisp_Cons.
988
3a4c8000
TT
9892012-07-10 Tom Tromey <tromey@redhat.com>
990
991 * bytecode.c (BYTE_CODE_THREADED): New macro.
992 (BYTE_CODES): New macro. Replaces all old byte-code defines.
993 (enum byte_code_op): New type.
994 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
995 (exec_byte_code): Use them. Use token threading when applicable.
996
2a0213a6
DA
9972012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
998
999 Optimize pure C strings initialization.
1000 * lisp.h (make_pure_string): Fix prototype.
1001 (build_pure_c_string): New function, defined as static inline. This
1002 provides a better opportunity to optimize away calls to strlen when
1003 the function is called with compile-time constant argument.
1004 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1005 argument, adjust users accordingly. Use build_pure_c_string where
1006 appropriate.
1007 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1008 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1009 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1010
cb1caeaf
DA
10112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1012
1013 Avoid calls to strlen in miscellaneous functions.
1014 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1015 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1016 * lread.c (openp): Likewise.
1017
c293e30c
DA
10182012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1019
1020 Avoid calls to strlen in path processing functions.
1021 * fileio.c (file_name_as_directory): Add comment. Change to add
1022 srclen argument and return the length of result. Adjust users
1023 accordingly.
1024 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1025 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1026 users accordingly.
1027 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1028
9e059e3f
GM
10292012-07-10 Glenn Morris <rgm@gnu.org>
1030
d02eb359
GM
1031 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1032 Move PENDING_OUTPUT_COUNT definition to configure.
1033
882cf227
GM
1034 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1035 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1036 * s/gnu.h (DATA_START): Move definitions to configure.
1037
af6e839f
GM
1038 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1039 We include usg5-4-common.h, which defines them both.
1040
40289a12
GM
1041 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1042 O_RDONLY already includes it).
1043
9e059e3f
GM
1044 Stop ns builds setting the EMACSLOADPATH environment variable.
1045 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1046 Now it does not set EMACSLOADPATH, just returns the load-path string.
1047 * nsterm.h: Update accordingly.
1048 * lread.c [HAVE_NS]: Include nsterm.h.
1049 (init_lread) [HAVE_NS]: Use ns_load_path.
1050 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1051
7c4e8ec0
GM
10522012-07-09 Glenn Morris <rgm@gnu.org>
1053
d4f600ff
GM
1054 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1055 since the included bsd-common.h does so.
1056
cbb31951
GM
1057 Stop ns builds setting the EMACSPATH environment variable.
1058 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1059 (ns_init_paths): Do not set EMACSPATH.
1060 * nsterm.h (ns_exec_path): Add it.
1061 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1062 Use ns_exec_path.
1063
7c4e8ec0
GM
1064 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1065
26bccfae
PE
10662012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1067
a0bee46f
PE
1068 * process.c (wait_reading_process_output): 'waitchannels' was unset
1069 when read_kbd || !NILP (wait_for_cell); fix this.
1070
5994c183
PE
1071 Add GCC-style 'const' attribute to functions that can use it.
1072 * character.h (char_resolve_modifier_mask):
1073 * keyboard.h (make_ctrl_char):
1074 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1075 (init_character_once, next_almost_prime, init_fns, init_image)
1076 (flush_pending_output, init_sound):
1077 * mem-limits.h (start_of_data):
1078 * menu.h (finish_menu_items):
1079 Add ATTRIBUTE_CONST.
1080 * emacs.c (DEFINE_DUMMY_FUNCTION):
1081 Declare the dummy function with ATTRIBUTE_CONST.
1082 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1083 Add decls with ATTRIBUTE_CONST.
1084
26bccfae
PE
1085 Minor improvements to make_formatted_string.
1086 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1087 where int is good enough, as vsprintf returns an int.
1088 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1089
a8290ec3
DA
10902012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1091
1092 Use make_formatted_string to avoid double length calculation.
1093 * lisp.h (make_formatted_string): New prototype.
1094 * alloc.c (make_formatted_string): New function.
1095 * buffer.c (Fgenerate_new_buffer_name): Use it.
1096 * dbus.c (syms_of_dbusbind): Likewise.
1097 * editfns.c (Fcurrent_time_zone): Likewise.
1098 * filelock.c (get_boot_time): Likewise.
1099 * frame.c (make_terminal_frame, set_term_frame_name)
1100 (x_report_frame_params): Likewise.
1101 * image.c (gs_load): Likewise.
1102 * minibuf.c (get_minibuffer): Likewise.
1103 * msdos.c (dos_set_window_size): Likewise.
1104 * process.c (make_process): Likewise.
1105 * xdisp.c (ensure_echo_area_buffers): Likewise.
1106 * xsettings.c (apply_xft_settings): Likewise.
1107
d01ba2f1
GM
11082012-07-09 Glenn Morris <rgm@gnu.org>
1109
1110 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1111 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1112 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1113 * nsterm.h (ns_etc_directory): Add it.
1114 * callproc.c [HAVE_NS]: Include nsterm.h.
1115 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1116
f1f924b6
DA
11172012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1118
1119 Move marker debugging code under MARKER_DEBUG.
1120 * marker.c (MARKER_DEBUG): Move marker debugging code under
1121 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1122 for bootstrap with --enable-checking (~3x slowdown reported
1123 by Juanma Barranquero <lekktu@gmail.com>).
1124 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1125
ab531b66
PE
11262012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1129 See <http://bugs.gnu.org/11825#29>.
1130
c4b3bc8a
EZ
11312012-07-08 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1134 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1135 (display_line): Add commentary about displaying truncation glyphs
1136 on GUI frames.
1137 (produce_special_glyphs): Move here from term.c.
1138
1139 * term.c (produce_special_glyphs): Move to xdisp.c.
1140
1141 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1142 section.
c4b3bc8a 1143
b676b881
AS
11442012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1145
f17c5273
AS
1146 * xdisp.c (display_line): Avoid warning about implicit declaration
1147 of FRAME_FONT.
1148
298819b9
AS
1149 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1150
b676b881
AS
1151 * lisp.h: Remove empty conditional.
1152
6045c4fd
PE
11532012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1154
b3350bf9
PE
1155 * lread.c (load_path_check): Now static.
1156
6045c4fd
PE
1157 Fix some minor --with-ns problems found by static checking.
1158 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1159 (x_set_font) [!HAVE_X_WINDOWS]:
1160 * image.c (xpm_load_image) [HAVE_NS]:
1161 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1162 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1163 Remove unused local.
1164 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1165 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1166 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1167 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1168 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1169 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1170 Fix pointer signedness problem.
1171 * xfaces.c (FRAME_X_FONT_TABLE):
1172 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1173
929e7845
GM
11742012-07-07 Glenn Morris <rgm@gnu.org>
1175
1176 * lread.c (load_path_check): New function, split from init_lread.
1177 (init_lread): Reorganize. Motivation:
1178 If EMACSLOADPATH is set, check/warn about that rather than the
1179 defaults, which we are not going to use. Hence we can remove
1180 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1181 Don't warn if site-lisp directories are missing.
1182 If not installed, start from a blank load-path, since
1183 PATH_LOADSEARCH refers to the eventual installation directories.
1184
58dd0aa4
EZ
11852012-07-07 Eli Zaretskii <eliz@gnu.org>
1186
1187 Support truncation and continuation glyphs on GUI frames, when
1188 fringes are disabled. (Bug#11832)
1189 * xdisp.c (init_iterator): Get dimensions of truncation and
1190 continuation glyphs even if on GUI frames. Adjust
1191 it->last_visible_x on GUI frames when the left or right fringes,
1192 or both, are absent.
1193 (start_display, move_it_in_display_line_to): Handle the case of a
1194 GUI frame without a fringe to display continuation or truncation
1195 glyphs.
1196 (insert_left_trunc_glyphs): Support GUI frames: make sure
1197 truncation glyphs overwrite enough glyphs from the current line to
1198 have sufficient space in pixels.
1199 (display_line): Support truncation and continuation glyphs on GUI
1200 frames. If some spare pixels are left on the line after inserting
1201 the truncation glyphs, fill that space with a stretch glyph of a
1202 suitably computed width.
1203
1204 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1205 produce_glyphs, to support GUI sessions.
1206
31571fd7
PE
12072012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1208
5a16b9bc
PE
1209 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1210
f3047c75
PE
1211 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1212
31571fd7
PE
1213 Do not require float-time's arg to fit in time_t (Bug#11825).
1214 This works better on hosts where time_t is unsigned, and where
1215 float-time is applied to the (negative) difference between two times.
1216 * editfns.c (decode_time_components): Last arg is now double *,
1217 not int *, and means to store all the result as a double, without
1218 worrying about whether the seconds part fits in time_t.
1219 All callers changed.
1220 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1221 All callers changed.
1222 (Ffloat_time): Do not fail merely because the specified time falls
1223 outside of time_t range.
1224
4516fbef
GM
12252012-07-07 Glenn Morris <rgm@gnu.org>
1226
1227 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1228 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1229 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1230
07adc2c6
JB
12312012-07-07 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1234 Update dependencies.
1235
1236 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1237
fd573f31
PE
12382012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1239
fee5959d
PE
1240 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1241 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1242 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1243 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1244 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1245 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1246
fd573f31
PE
1247 * xfont.c (compare_font_names): Redo to omit the need for casts.
1248
ddadbc0e
AS
12492012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1250
fca8d6b6
AS
1251 * xfns.c (Fx_change_window_property): Doc fix.
1252 * w32fns.c (Fx_change_window_property): Doc fix.
1253
ddadbc0e
AS
1254 * w32fns.c (Fx_window_property): Accept the same arguments as the
1255 X Windows version. Doc fix.
1256 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1257
ed9265fc 12582012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1259 Eli Zaretskii <eliz@gnu.org>
1260
1261 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1262 Windows-specific code from nt/config.nt moved here.
1263 Obsolete settings removed.
1264
216ee680
PE
12652012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1266
1267 * process.c: Avoid unnecessary calls to gettime.
1268 (wait_reading_process_output): Don't get the time of day
1269 when gobbling data immediately and not waiting, as there's no need
1270 for it in that case. This removes a FIXME.
1271
bdd091e4
JD
12722012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1273
1274 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1275 is defined (Bug#11768).
1276
9d44f8ce
DA
12772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 Fix marker debugging code.
1280 * marker.c (byte_char_debug_check): Do not perform the check
1281 if buffer is not multibyte.
090bd7cb
JB
1282 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1283 Call byte_char_debug_check with correct arguments.
9d44f8ce 1284
90fc4786
DA
12852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1288 * marker.c (byte_char_debug_check, count_markers):
1289 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1290 (byte_debug_flag): Remove.
1291 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1292 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1293
7b7ae965
DA
12942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1295
4e57b342
DA
1296 Avoid code repetition in marker-related functions.
1297 * marker.c (attach_marker): New function.
1298 (Fset_marker, set_marker_restricted, set_marker_both)
1299 (set_marker_restricted_both): Use it.
1300 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1301 Consistently rename charno to charpos.
1302 (marker_position): Add eassert.
1303 (marker_byte_position): Convert to eassert.
1304
13052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1308 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1309 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1310
657924ff
DA
13112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 Introduce fast path for the widely used marker operation.
1314 * alloc.c (build_marker): New function.
1315 * lisp.h (build_marker): New prototype.
1316 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1317 * composite.c (autocmp_chars): Likewise.
1318 * editfns.c (buildmark): Remove.
1319 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1320 (save_restriction_save): Use build_marker.
1321 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1322 * window.c (save_window_save): Likewise.
1323
041a49a6
DA
13242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1325
1326 Do not use Fdelete_overlay in delete_all_overlays
1327 to avoid redundant calls to unchain_overlay.
1328 * buffer.c (drop_overlay): New function.
1329 (delete_all_overlays, Fdelete_overlay): Use it.
1330 * minibuf.c (get_minibuffer): Fix comment.
1331
7dca65a4
PE
13322012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 Port to OpenBSD 5.1 amd64.
1335 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1336 This is needed for OpenBSD, and should be harmless on all BSD systems.
1337 Also, include <sys/sysctl.h>, as it should be available on all
1338 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1339 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1340 use p_pid member, not kp_proc.pid.
1341
8eb876e2
GM
13422012-07-06 Glenn Morris <rgm@gnu.org>
1343
1344 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1345
38182d90
PE
13462012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 More xmalloc and related cleanup.
1349 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1350 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1351 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1352 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1353 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1354 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1355 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1356 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1357 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1358 * xterm.c:
1359 Omit needless casts involving void * pointers and allocation.
1360 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1361 as the former is more robust if P's type is changed.
1362 Prefer xzalloc to xmalloc + memset 0.
1363 Simplify malloc-or-realloc to realloc.
1364 Don't worry about xmalloc returning a null pointer.
1365 Prefer xstrdup to xmalloc + strcpy.
1366 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1367 growing it.
1368 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1369 alloca of a constant.
1370
6dd5a677
EZ
13712012-07-05 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1374 hscroll is larger than the line width. Fixes long and futile
1375 looping inside extend_face_to_end_of_line (on a TTY) producing
1376 glyphs that are not needed and thrown away.
1377
6b312f0f
DA
13782012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1379
1380 * marker.c (set_marker_restricted_both): Simplify by using
1381 clip_to_bounds.
1382
f520ef9b
PE
13832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1386
383b7c95
JD
13872012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1388
1389 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1390 not defined (Bug#11768).
1391 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1392 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1393 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1394 followed by gtk_box_set_homogeneous (Bug#11768).
1395 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1396 (update_theme_scrollbar_width, xg_create_scroll_bar):
1397 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1398 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1399 (is_box_type): New function (Bug#11768).
1400 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1401 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1402 with default display (Bug#11768).
1403
d6e7bf45
EZ
14042012-07-05 Eli Zaretskii <eliz@gnu.org>
1405
1406 * xdisp.c (window_hscroll_limited): New function.
1407 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1408 coordinates when window's hscroll is set to insanely large
1409 values. (Bug#11857)
1410
431391ec
JB
14112012-07-05 Juanma Barranquero <lekktu@gmail.com>
1412
1413 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1414 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1415
23f86fce
DA
14162012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 Cleanup xmalloc.
1419 * lisp.h (xzalloc): New prototype. Omit needless casts.
1420 * alloc.c (xzalloc): New function. Omit needless casts.
1421 * charset.c: Omit needless casts. Convert all calls to
1422 xmalloc with following memset to xzalloc.
1423 * dispnew.c: Likewise.
1424 * fringe.c: Likewise.
1425 * image.c: Likewise.
1426 * sound.c: Likewise.
1427 * term.c: Likewise.
1428 * w32fns.c: Likewise.
1429 * w32font.c: Likewise.
1430 * w32term.c: Likewise.
1431 * xfaces.c: Likewise.
1432 * xfns.c: Likewise.
1433 * xterm.c: Likewise.
1434 * atimer.c: Omit needless casts.
1435 * buffer.c: Likewise.
1436 * callproc.c: Likewise.
1437 * ccl.c: Likewise.
1438 * coding.c: Likewise.
1439 * composite.c: Likewise.
1440 * doc.c: Likewise.
1441 * doprnt.c: Likewise.
1442 * editfns.c: Likewise.
1443 * emacs.c: Likewise.
1444 * eval.c: Likewise.
1445 * filelock.c: Likewise.
1446 * fns.c: Likewise.
1447 * gtkutil.c: Likewise.
1448 * keyboard.c: Likewise.
1449 * lisp.h: Likewise.
1450 * lread.c: Likewise.
1451 * minibuf.c: Likewise.
1452 * msdos.c: Likewise.
1453 * print.c: Likewise.
1454 * process.c: Likewise.
1455 * region-cache.c: Likewise.
1456 * search.c: Likewise.
1457 * sysdep.c: Likewise.
1458 * termcap.c: Likewise.
1459 * terminal.c: Likewise.
1460 * tparam.c: Likewise.
1461 * w16select.c: Likewise.
1462 * w32.c: Likewise.
1463 * w32reg.c: Likewise.
1464 * w32select.c: Likewise.
1465 * w32uniscribe.c: Likewise.
1466 * widget.c: Likewise.
1467 * xdisp.c: Likewise.
1468 * xmenu.c: Likewise.
1469 * xrdb.c: Likewise.
1470 * xselect.c: Likewise.
1471
0497dc44
PE
14722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 * fileio.c (time_error_value): Check the right error number.
1475 Problem reported by Troels Nielsen in
1476 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1477
356e7178
PE
14782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1479
4e71fd89
PE
1480 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1481 This should be fixed in a better way; see Eli Zaretskii in
1482 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1483 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1484
f0941253
PE
1485 * fileio.c (time_error_value): Rename from special_mtime.
1486 The old name's problems were noted by Eli Zaretskii in
1487 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1488
065c9eb4
PE
1489 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1490 This variable's comment says Emacs needs at least one GDB-visible
1491 symbol of type enum pvec_type, to work around GDB problems.
1492 The symbol's value doesn't matter.
1493
356e7178
PE
1494 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1495 that causes compilation to fail on pre-C99 compilers.
1496
ed9265fc 14972012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1498
1499 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1500 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1501
3884d954
DA
15022012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1503
d209e2fb 1504 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1505 headers for buffer_defaults and buffer_local_symbols.
1506 Reported by Juanma Barranquero <lekktu@gmail.com>.
1507
ee28be33
SM
15082012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1509
1510 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1511 * lisp.h (enum pvec_type): Use fewer bits.
1512 (PSEUDOVECTOR_SIZE_BITS): New constant.
1513 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1514 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1515 change in pvec_type.
1516 (PSEUDOVECTOR_TYPEP): New macro.
1517 (TYPED_PSEUDOVECTORP): Use it.
1518 * fns.c (internal_equal): Adapt code to extract pvectype.
1519 * emacs.c (gdb_pvec_type): Update type.
1520 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1521 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1522 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1523 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1524 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1525 abusing vector->header.next.nbytes.
1526 (live_vector_p): Use PVEC_TYPE.
1527 (mark_object): Adapt code to extract pvectype. Use switch.
1528
c7f2cd7f
PE
15292012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1532 Tighten new eassert a bit.
1533
8ce70ed2
DA
15342012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Fix compilation with --enable-gcc-warnings and -O1
1537 optimization level.
1538 * doprnt.c (doprnt): Change type of tem to int, initialize
1539 to avoid compiler warning. Add eassert.
1540 * search.c (simple_search): Initialize match_byte to avoid
1541 compiler warning. Add eassert.
1542
dea7f1e5
PE
15432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1544
24a212eb
PE
1545 Avoid weird behavior with large horizontal scrolls.
1546 Without this change, for example, large hscroll values would
1547 mess up Emacs's display on Fedora 15 x86, presumably due to
1548 overflows in int calculations in the display code.
1549 Also, if buffers had long lines, Emacs would freeze.
1550 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1551 (set_window_hscroll): New function, containing the old guts of
1552 Fset_window_hscroll. Return the clipped value.
1553 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1554 This avoids the need to check against PTRDIFF_MAX.
1555
dea7f1e5
PE
1556 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1557
76046526
DA
15582012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1559
1560 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1561
39adff0d
PE
15622012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1563
63807d47
PE
1564 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1565 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1566 since GCC 4.4.6 issues a bogus warning for them.
1567
39adff0d
PE
1568 Fix bugs in file timestamp newness comparisons.
1569 * fileio.c (Ffile_newer_than_file_p):
1570 * lread.c (Fload): Use full timestamp resolution of files,
1571 not just the 1-second resolution, so that files that are only
1572 slightly newer still count as newer.
1573 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1574 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1575
dbeed9a6
PE
15762012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * fileio.c: Improve handling of file time marker. (Bug#11852)
1579 (special_mtime): New function.
1580 (Finsert_file_contents, Fverify_visited_file_modtime):
1581 Use it to set special mtime values consistently.
1582
636334d6
AS
15832012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1584
1585 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1586 marker for non-existing file. (Bug#11852)
1587
e2017fe2
GM
15882012-07-03 Glenn Morris <rgm@gnu.org>
1589
1590 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1591 and did not make it into globals.h).
1592
404dbd37
TT
15932012-07-03 Tom Tromey <tromey@redhat.com>
1594
1595 * window.c (Fset_window_margins, Fset_window_fringes)
1596 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1597 * textprop.c (Fprevious_property_change): No longer static.
1598 * syntax.c (Fsyntax_table_p): No longer static.
1599 * process.c (Fget_process, Fprocess_datagram_address): No longer
1600 static.
1601 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1602 * keyboard.c (Fcommand_execute): No longer static.
1603 Remove EXFUN.
1604 * insdel.c (Fcombine_after_change_execute): No longer static.
1605 * image.c (Finit_image_library): No longer static.
1606 * fileio.c (Fmake_symbolic_link): No longer static.
1607 * eval.c (Ffetch_bytecode): No longer static.
1608 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1609 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1610 No longer static.
404dbd37
TT
1611 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1612 static.
1613 * dired.c (Ffile_attributes): No longer static.
1614 * composite.c (Fcomposition_get_gstring): No longer static.
1615 * callproc.c (Fgetenv_internal): No longer static.
1616
1617 * ccl.h: Remove EXFUNs.
1618 * buffer.h: Remove EXFUNs.
1619 * dispextern.h: Remove EXFUNs.
1620 * intervals.h: Remove EXFUNs.
1621 * fontset.h: Remove EXFUN.
1622 * font.h: Remove EXFUNs.
1623 * dosfns.c (system_process_attributes): Remove EXFUN.
1624 * keymap.h: Remove EXFUNs.
1625 * lisp.h: Remove EXFUNs.
1626 * w32term.h: Remove EXFUNs.
1627 * window.h: Remove EXFUNs.
1628 * xsettings.h: Remove EXFUN.
1629 * xterm.h: Remove EXFUN.
1630
8e4fd1e1
GM
16312012-07-03 Glenn Morris <rgm@gnu.org>
1632
1633 * lisp.h (Frandom): Make it visible to C.
1634 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1635 buffer for invisible buffers. (Bug#1229)
1636
ca95b3eb
DA
16372012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1638
1639 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1640 values which aren't power of 2.
1641 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1642 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1643 accordingly.
1644
7555c33f
SM
16452012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1646
1647 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1648
1649 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1650
d12e8f5a
DA
16512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1652
1653 * alloc.c (allocate_vector_block): Remove redundant
1654 calls to mallopt if DOUG_LEA_MALLOC is defined.
1655 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1656 avoid calls to mallopt if zero_vector is returned.
1657
296094c3
DA
16582012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1659
1660 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1661 is enabled, avoid dereferencing NULL current_sblock if
1662 running undumped.
1663
36429c89
DA
16642012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1665
1666 Cleanup basic buffer management.
1667 * buffer.h (struct buffer): Change layout to use generic vector
1668 marking code. Fix some comments. Change type of 'clip_changed'
1669 to bitfield. Remove unused #ifndef old.
1670 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1671 (GET_OVERLAYS_AT): Fix indentation.
1672 (for_each_per_buffer_object_at): New macro.
1673 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1674 (Fbuffer_local_variables): Use it.
1675 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1676 * alloc.c (allocate_buffer): Adjust to match new layout of
1677 struct buffer. Fix comment.
1678 (mark_overlay): New function.
1679 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1680 Lisp area of struct buffer.
1681 (mark_object): Use it. Adjust marking of misc objects
1682 and related comments.
1683
3b3e4cac
PE
16842012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1687 wrapper that is not needed because the wrapped code is a no-op (zero
1688 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1689 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1690
cf5c0175
DA
16912012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1692
1693 * alloc.c (mark_buffer): Simplify. Remove prototype.
1694 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1695 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1696 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1697 redundant calls to mark_vectorlike for bool vectors.
1698
ca26824c
GM
16992012-06-30 Glenn Morris <rgm@gnu.org>
1700
2e4c5312
GM
1701 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1702
ca26824c
GM
1703 * epaths.in (PATH_SITELOADSEARCH): New.
1704 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1705 This is rather than relying on --enable-locallisppath elements
1706 having "site-lisp" in their names. (Bug#10208#25, 11658)
1707
0d23c240
EZ
17082012-06-30 Eli Zaretskii <eliz@gnu.org>
1709
c9240d7a
EZ
1710 * w32proc.c (sys_select): Accept and ignore one more argument.
1711
1712 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1713
0d23c240 1714 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1715 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1716
1717 * sysdep.c: Don't include dos.h and dosfns.h.
1718
1719 * process.c (sys_select):
1720 * msdos.c (sys_select): Accept one more argument and ignore it.
1721
1722 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1723 adapt data types and code to that.
1724
1725 * dosfns.c:
1726 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1727 which clashes with the gnulib function of the same name.
1728
af5a5a98
AS
17292012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1730
c5e4379c
AS
1731 * font.c (font_style_to_value, font_style_symbolic)
1732 (font_prop_validate_style): Add type checks for values in
1733 font_style_table.
1734
af5a5a98
AS
1735 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1736 argument.
1737 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1738 uses.
1739
8d38f461
EZ
17402012-06-29 Eli Zaretskii <eliz@gnu.org>
1741
2e5a6631
EZ
1742 * xdisp.c (try_window_id): Undo last change.
1743
8d38f461
EZ
1744 * w32.c (getwd): Adjust commentary about startup_dir.
1745 (init_environment): Always call sys_access, even in non-MSVC
1746 builds. Don't chdir to the directory of the Emacs executable.
1747 This undoes code from 1997 which was justified by the need to
1748 "avoid conflicts when removing and renaming directories". But its
1749 downside was that every relative file name was being interpreted
1750 relative to the directory of the Emacs executable, which can never
1751 be TRT. In particular, it broke sys_access when called with
1752 relative file names.
1753 (sys_access): Map GetLastError to errno.
1754
2af3565e
DA
17552012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 * window.h (struct window): Change type of 'fringes_outside_margins'
1758 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1759 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1760 Adjust comment.
1761 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1762 to ptrdiff_t.
1763
c8d3a25c 17642012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1765
c8d3a25c
GM
1766 * gnutls.c (emacs_gnutls_handshake):
1767 Add QUIT to make the loop interruptible.
57570cd3 1768
c8d3a25c 17692012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1770
c8d3a25c
GM
1771 * charset.c (init_charset): Make lack of etc/charsets fatal.
1772
3e984ee8
DA
17732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1774
1775 * editfns.c (region_limit): Fix type mismatch.
1776
ef884f23
DA
17772012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1778
1779 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1780 undefined. Convert from xassert to eassert.
1781 * nsmenu.m: Convert from xassert to eassert.
1782 * nsterm.m: Likewise.
1783
7d7e0027
SM
17842012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1785
1786 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1787
aa754e6a
PE
17882012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 Avoid integer overflow on scroll-left and scroll-right.
1791 * window.c (HSCROLL_MAX): New macro.
1792 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1793 overflow when requested scroll falls outside ptrdiff_t range.
1794
80b00b08
DA
17952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1796
1797 * window.h (struct window): Change type of 'hscroll',
1798 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1799 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1800 Adjust users accordingly.
1801 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1802 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1803 from EMACS_INT to ptrdiff_t.
1804 (make_window): Omit redundant initialization.
1805
62b2bcf6
JB
18062012-06-28 Juanma Barranquero <lekktu@gmail.com>
1807
1808 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1809
45942c7d
DA
18102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1811
1812 * window.h (struct window): Change type of 'use_time' and
1813 'sequence_number' from Lisp_Object to int.
1814 * frame.c (make_frame): Adjust users accordingly.
1815 * print.c (print_object): Likewise.
1816 * window.c (select_window, Fwindow_use_time, make_parent_window)
1817 (make_window): Likewise.
1818
e509cfa6
DA
18192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1822 enabled with --enable-checking=[all,glyphs] configure option.
1823 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1824 adjust comments accordingly.
1825 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1826 undefined, adjust comments accordingly.
1827 * image.c: Likewise.
1828 * scroll.c: Likewise.
1829 * w32fns.c: Likewise.
1830 * w32term.c: Likewise.
1831 * xdisp.c: Likewise.
1832 * xfaces.c: Likewise.
1833 * xfns.c: Likewise.
1834 * xterm.c: Likewise.
1835
a54e2c05
DA
18362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 Generalize run-time debugging checks.
1839 * dispextern.h (XASSERTS): Remove.
1840 * fontset.c (xassert): Remove.
1841 Convert from xassert to eassert.
1842 * alloc.c: Convert from xassert to eassert.
1843 * bidi.c: Likewise.
1844 * dispnew.c: Likewise.
1845 * fns.c: Likewise.
1846 * fringe.c: Likewise.
1847 * ftfont.c: Likewise.
1848 * gtkutil.c: Likewise.
1849 * image.c: Likewise.
1850 * keyboard.c: Likewise.
1851 * menu.c: Likewise.
1852 * process.c: Likewise.
1853 * scroll.c: Likewise.
1854 * sound.c: Likewise.
1855 * term.c: Likewise.
1856 * w32console.c: Likewise.
1857 * w32fns.c: Likewise.
1858 * w32term.c: Likewise.
1859 * window.c: Likewise.
1860 * xdisp.c: Likewise.
1861 * xfaces.c: Likewise.
1862 * xfns.c: Likewise.
1863 * xselect.c: Likewise.
1864 * xterm.c: Likewise.
1865
1ec4b7b2
SM
18662012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1867
1868 * fns.c (maybe_resize_hash_table): Output message when growing the
1869 purify-hashtable.
1870
2014308a
DA
18712012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1872
1873 * alloc.c (allocate_string_data): Remove dead code.
1874 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1875 avoid GCC warning about unused macro.
1876
246155eb
DA
18772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1878
1879 * alloc.c (allocate_string): Omit intervals initialization.
1880 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1881 as in make_pure_string and make_pure_c_string.
1882
43184b7b
DA
18832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1884
d209e2fb 1885 * alloc.c (allocate_string): Fix last change.
43184b7b 1886
3fe6dd74
DA
18872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1888
d209e2fb 1889 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1890 to memset, add explicit initialization where appropriate.
1891
1ba6038a
GM
18922012-06-27 Glenn Morris <rgm@gnu.org>
1893
1894 * lisp.mk (lisp): Remove paths.elc.
1895
c89926a5
CY
18962012-06-27 Chong Yidong <cyd@gnu.org>
1897
1898 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1899
ed6b3510
JW
19002012-06-26 John Wiegley <johnw@newartisans.com>
1901
1ec4b7b2 1902 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1903 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1904
ed6b3510
JW
1905 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1906 when building with Clang.
1907
8edd4a2b
SM
19082012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1909
1910 * eval.c (Fapply): Allow calling it with a single argument.
1911
f6f62d1b
EZ
19122012-06-26 Eli Zaretskii <eliz@gnu.org>
1913
1914 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1915 _stricmp and _strnicmp.
1916 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1917
62efea5e
DA
19182012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1919
1920 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1921 allocated window.
1922 (allocate_process): Likewise for new process.
8edd4a2b 1923 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1924 (allocate_frame): Likewise.
1925 * frame.c (make_frame): Omit redundant initialization.
1926 * window.c (make_parent_window): Use memset.
1927 (make_window): Omit redundant initialization.
1928 * process.c (make_process): Omit redundant initialization.
1929 * terminal.c (create_terminal): Likewise.
1930
42997f4d
DA
19312012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1932
1933 * term.c (delete_tty): Remove redundant call to memset.
1934
1130ecfc
DA
19352012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1936
1937 * alloc.c: Remove build_string.
1938 * lisp.h: Define build_string as static inline. This provides
1939 a better opportunity to optimize away calls to strlen when the
1940 function is called with compile-time constant argument.
1941 * image.c (imagemagick_error): Convert to build_string.
1942 * w32proc.c (sys_spawnve): Likewise.
1943 * xterm.c (x_term_init): Likewise.
1944
cf38a720
PE
19452012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1946
99027bdd
PE
1947 Use sprintf return value instead of invoking strlen on result.
1948 In the old days this wasn't portable, since some sprintf
1949 implementations returned char *. But they died out years ago and
1950 Emacs already assumes sprintf returns int.
1951 Similarly for float_to_string.
1952 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1953 * ccl.c (ccl_driver):
1954 * character.c (string_escape_byte8):
1955 * data.c (Fnumber_to_string):
1956 * doprnt.c (doprnt):
1957 * print.c (print_object):
1958 * xdisp.c (message_dolog):
1959 * xfns.c (syms_of_xfns):
1960 Use sprintf or float_to_string result to avoid need to call strlen.
1961 * data.c (Fnumber_to_string):
1962 Use make_unibyte_string, since the string must be ASCII.
1963 * lisp.h, print.c (float_to_string): Now returns int length.
1964 * term.c (produce_glyphless_glyph):
1965 Use sprintf result rather than recomputing it.
1966
cf38a720
PE
1967 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1968 * Makefile.in (ALL_CFLAGS):
1969 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1970 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1971
3511c784
DA
19722012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1973
0a08eb21 1974 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1975 strcasecmp if available.
1976 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1977
fb7da12e
AS
19782012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1979
1980 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1981 Avoid comma operator.
1982 * menu.c (push_submenu_start, push_submenu_end)
1983 (push_left_right_boundary, push_menu_pane): Likewise.
1984 * msdos.c (dos_rawgetc): Likewise.
1985
afa2ffd8
DA
19862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 * xfns.c (xic_create_fontsetname): Remove redundant calls
1989 to memset.
1990
b3b4476b
PE
19912012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1992
4495ff38
PE
1993 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1994 sprintf already null-terminates its output.
1995
b3b4476b
PE
1996 * xfns.c (x_window): Remove redundant cast.
1997
b00876c9
DA
19982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1999
2000 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2001 `const char *' to `char *' to avoid compiler warning.
2002
d188e26b
PE
20032012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2004
885d1d74
PE
2005 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2006 instead of truncating it to 63 (admittedly a generous limit).
2007
d188e26b
PE
2008 * process.c: Fix spelling and caps in comments.
2009
e2f560b1
DN
20102012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2011
e86db54b 2012 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2013 * sysdep.c (setpgrp): Remove definition, not used in this file.
2014
7583a3a1
JB
20152012-06-24 Juanma Barranquero <lekktu@gmail.com>
2016
2017 * makefile.w32-in: Update dependencies.
2018
696056c2
EZ
20192012-06-24 Eli Zaretskii <eliz@gnu.org>
2020
2021 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2022 (SYSTIME_H): Add nt/inc/sys/time.h.
2023
2024 * systime.h [WINDOWSNT]: Include sys/time.h.
2025
2026 * s/ms-w32.h (struct timespec): Definition moved from
2027 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2028
845ca893
PE
20292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2030
2031 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2032 * buffer.h (buffer_slot_type_mismatch):
2033 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2034 * eval.c (unwind_to_catch):
2035 * image.c (my_png_error, my_error_exit):
2036 * keyboard.c (quit_throw_to_read_char, user_error)
2037 (Fexit_recursive_edit, Fabort_recursive_edit):
2038 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2039 (wrong_type_argument, buffer_overflow, __executable_start)
2040 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2041 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2042 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2043 (fatal):
2044 (child_setup) [!DOS_NT]:
2045 * lread.c (end_of_file_error, invalid_syntax):
2046 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2047 * puresize.h (pure_write_error):
2048 * search.c (matcher_overflow):
2049 * sound.c (sound_perror, alsa_sound_perror):
2050 * sysdep.c, syssignal.h (croak):
2051 * term.c (maybe_fatal, vfatal):
2052 * textprop.c (text_read_only):
2053 * undo.c (user_error):
2054 * unexmacosx.c (unexec_error):
2055 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2056 Use _Noreturn rather than NO_RETURN.
2057 No need for separate decl merely because of _Noreturn.
2058 * sound.c (sound_warning, parse_sound):
2059 Remove unnecessary forward decls.
2060
f1dd8073
PE
20612012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2064 * lisp.h (WAIT_READING_MAX): New macro.
2065 * dispnew.c (Fsleep_for, sit_for):
2066 * keyboard.c (kbd_buffer_get_event):
2067 * process.c (Faccept_process_output):
2068 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2069 This improves on the previous patch, which introduced a bug
2070 when time_t is unsigned and as wide as intmax_t.
2071 See <http://bugs.gnu.org/9000#51>.
2072
b82c1755
EZ
20732012-06-23 Eli Zaretskii <eliz@gnu.org>
2074
2075 * dispnew.c (sit_for, Fsleep_for):
2076 * keyboard.c (kbd_buffer_get_event):
2077 * process.c (Faccept_process_output): Avoid compiler warnings when
2078 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2079
ca300656
JB
20802012-06-23 Juanma Barranquero <lekktu@gmail.com>
2081
049ec95b
JB
2082 * makefile.w32-in: Update dependencies.
2083
ca300656
JB
2084 * w32.c (ltime): Add return type and declare static.
2085 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2086
db7b8d06
PE
20872012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2090 Privately reported by Herbert J. Skuhra.
2091 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2092 All uses changed.
2093 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2094 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2095
0bd8297f
EZ
20962012-06-23 Eli Zaretskii <eliz@gnu.org>
2097
96512555
EZ
2098 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2099 last argument of make_unibyte_string.
2100
0bd8297f
EZ
2101 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2102 language ID in the event parameters.
2103
2104 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2105 event.code, not the obscure "character set ID".
2106
63def6b6
CY
21072012-06-23 Chong Yidong <cyd@gnu.org>
2108
2109 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2110
e8a02204
EZ
21112012-06-23 Eli Zaretskii <eliz@gnu.org>
2112
388cdec0
EZ
2113 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2114 * w32.c (fdutimens): New function.
2115
2116 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2117
2118 * s/ms-w32.h (pselect): Redirect to sys_select.
2119
2120 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2121
e8a02204
EZ
2122 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2123 in the logic of incrementing and decrementing the value of
2124 use_relocatable_buffers.
2125
d054f3fb
PE
21262012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2129 Privately reported by Herbert J. Skuhra.
2130 [__FreeBSD__]: Remove "*/" typo after "#include".
2131 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2132 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2133 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2134 Don't assume EMACS_TIME and struct timeval are the same type.
2135
d35af63c
PE
21362012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 Support higher-resolution time stamps (Bug#9000).
2139 The time stamps are only nanosecond-resolution at the C level,
2140 since that's the best that any real-world system supports now.
2141 But they are picosecond-resolution at the Lisp level, as that's
2142 easy, and leaves room for future OS improvements.
2143
2144 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2145 (LIBES): Use it.
2146
2147 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2148 Don't get current time unless it's needed.
2149
2150 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2151 now provides it if it's absent.
2152 (start_atimer): Port to higher-res time stamps.
2153 Check for time stamp overflow. Don't get current time more
2154 often than is needed.
2155
2156 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2157 Include systime.h, not time.h.
2158 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2159
2160 * dired.c: Include stat-time.h.
2161 (Ffile-attributes): File times now have higher resolution.
2162
2163 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2164 (struct image): Timestamp now has higher resolution.
2165
2166 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2167 has at least microseconds now. All uses removed.
2168 (update_frame, update_single_window, update_window, update_frame_1)
2169 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2170
2171 * editfns.c (time_overflow): Now extern.
2172 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2173 (float-time, Fformat_time_string, Fcurrent_time_string)
2174 (Fcurrent_time_zone): Accept and generate higher-resolution
2175 time stamps.
2176 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2177 (decode_time_components, lisp_seconds_argument): New functions.
2178 (make_time): Now static.
2179 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2180 Report an error if the time is invalid, rather than having the caller
2181 do that.
2182
2183 * fileio.c: Include <stat-time.h>
2184 (Fcopy_file): Copy higher-resolution time stamps.
2185 Prefer to set the time stamp via a file descriptor if that works.
2186 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2187 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2188 (Fvisited_file_modtime, Fset_visited_file_modtime):
2189 Support higher-resolution time stamps.
2190
2191 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2192
2193 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2194
2195 * image.c (prepare_image_for_display, clear_image_cache)
2196 (lookup_image): Port to higer-resolution time stamps.
2197
2198 * keyboard.c (start_polling, bind_polling_period):
2199 Check for time stamp overflow.
2200 (read_char, kbd_buffer_get_event, timer_start_idle)
2201 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2202 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2203 Port to higher-resolution time stamps. Do not assume time_t is signed.
2204 (decode_timer): New function. Timers are now vectors of length 9,
2205 not 8, to accommodate the picosecond component.
2206 (timer_check_2): Use it.
2207
2208 * nsterm.m (select_timeout, timeval_subtract): Remove.
2209 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2210 as they're a bit more accurate and handle overflow better.
2211 (ns_select): Change prototype to be compatible with pselect.
2212 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2213 * nsterm.h (ns_select): Adjust prototype.
2214
2215 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2216 us-resolution time stamps.
2217 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2218
2219 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2220
2221 * lisp.h (time_overflow): New decl.
2222 (wait_reading_process_output): First arg is now intmax_t, not int,
2223 to accommodate larger waits.
2224
2225 * process.h (struct Lisp_Process.read_output_delay):
2226 Now counts nanoseconds, not microseconds.
2227 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2228 EMACS_HAS_USECS.
2229 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2230 (wait_reading_process_output):
2231 Port to ns-resolution time stamps.
2232 (Faccept_process_output, wait_reading_process_output):
2233 Check for time stamp overflow. Do not assume time_t is signed.
2234 (select_wrapper): Remove; we now use pselect.
2235 (Fprocess_attributes): Now generates ns-resolution time stamps.
2236
2237 * sysdep.c: Include utimens.h. Don't include utime.h
2238 or worry about struct utimbuf; gnulib does that for us now.
2239 (gettimeofday): Remove; gnulib provides a substitute.
2240 (make_timeval): New function.
2241 (set_file_times): Now sets ns-resolution time stamps.
2242 New arg FD; all uses changed.
2243 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2244 (system_process_attributes):
2245 Now returns ns-resolution time stamp. All uses changed.
2246 Check for time stamp overflow.
2247
2248 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2249 provides a substitute now.
2250
2251 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2252 since it guarantees struct timespec.
2253 (EMACS_TIME): Now struct timespec, so that we can support
2254 ns-resolution time stamps.
2255 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2256 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2257 (EMACS_USECS): Remove.
2258 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2259 so multiply the arg by 1000 before storing it.
2260 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2261 New macros.
2262 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2263 Port to ns-resolution time stamps.
2264 (EMACS_TIME_NEG_P): Remove; replaced by....
2265 (EMACS_TIME_SIGN): New macro.
2266 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2267 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2268 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2269 (make_timeval, make_lisp_time, decode_time_components): New decls.
2270 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2271 that it mishandled time_t overflow. You can't compare by subtracting!
2272 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2273 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2274
2275 * term.c: Include <sys/time.h>.
2276 (timeval_to_Time): New function, for proper overflow wraparound.
2277 (term_mouse_position, term_mouse_click): Use it.
2278
2279 * undo.c (record_first_change): Support higher-resolution time stamps
2280 in the undo buffer.
2281 (Fprimitive_undo): Use them when restoring time stamps.
2282
2283 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2284 (w32_get_internal_run_time):
2285 Port to higher-resolution Emacs time stamps.
2286 (ltime): Now accepts single 64-bit integer, as that's more convenient
2287 for callers.
2288
2289 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2290
2291 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2292 for compatibility with pselect. Support ns-resolution time stamps.
2293
2294 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2295
2296 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2297 Check for time stamp overflow, and support ns-resolution time stamps.
2298
2299 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2300 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2301 (timeval_subtract): Remove; no longer needed.
2302 (XTflash, XTring_bell, x_wait_for_event):
2303 Port to ns-resolution time stamps. Don't assume time_t is signed.
2304
b6a92dfe
CY
23052012-06-22 Chong Yidong <cyd@gnu.org>
2306
2307 * xdisp.c (x_consider_frame_title): Revert last change.
2308
d251c37c
EZ
23092012-06-22 Eli Zaretskii <eliz@gnu.org>
2310
2311 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2312 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2313 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2314 staticidx goes up to 1597 out of 1600 = 0x640.)
2315
f10deafb
PE
23162012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2319 Otherwise, the umask might be mistakenly 0 while handling input signals.
2320
ec6de1e2
SM
23212012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2322
2323 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2324
28be1ada
DA
23252012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2326
2327 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2328 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2329 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2330 access to `contents' member of Lisp_Vector objects with AREF and ASET
2331 where appropriate.
2332
c6bf3022
CY
23332012-06-19 Chong Yidong <cyd@gnu.org>
2334
2335 * frame.c (delete_frame): When selecting a frame on a different
2336 text terminal, do not alter the terminal's top-frame.
2337
2338 * xdisp.c (format_mode_line_unwind_data): Record the target
2339 frame's selected window and its terminal's top-frame.
2340 (unwind_format_mode_line): Restore them.
2341 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2342 Callers changed.
2343 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2344 since tty frames can be explicitly named.
2345 (prepare_menu_bars): Likewise.
2346
2347 * term.c (Ftty_top_frame): New function.
2348
defd4196
PE
23492012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 Port byte-code-meter to modern targets.
2352 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2353 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2354 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2355 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2356 (METER_1, METER_2): Simplify.
2357
1053a871
SM
23582012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2359
2360 * data.c (Fdefalias): Return `symbol' (bug#11686).
2361
b7e8d081
MR
23622012-06-18 Martin Rudalics <rudalics@gmx.at>
2363
2364 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2365 gets killed during executing of this function (Bug#11665).
2366 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2367 (Vkill_buffer_query_functions): In doc-string say that functions
2368 run by this hook should not change the current buffer.
2369
7ea2b339
PE
23702012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 Fix recently-introduced process.c problems found by static checking.
2373 * process.c (write_queue_push, write_queue_pop, send_process):
2374 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2375 (write_queue_pop): Fix pointer signedness problem.
2376 (send_process): Remove unused local.
2377
96a313a1
CY
23782012-06-17 Chong Yidong <cyd@gnu.org>
2379
2380 * xdisp.c (redisplay_internal): No need to redisplay terminal
2381 frames that are not on top.
2382
20ca2e94
TN
23832012-06-17 Troels Nielsen <bn.troels@gmail.com>
2384
2385 * process.c (make_process): Initialize write_queue.
2386 (write_queue_push, write_queue_pop): New functions.
2387 (send_process): Use them to maintain correct ordering of process
2388 writes (Bug#10815).
2389
9a900ca9
PE
23902012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2391
310fbfa8
PE
2392 * lisp.h (eassert): Assume C89 or later.
2393 This removes the need for CHECK.
2394 (CHECK): Remove. Its comments about always evaluating its
2395 argument were confusing, as 'eassert' typically does not evaluate
2396 its argument.
2397
27bb1ca4
PE
2398 * coding.c (produce_chars): Use ptrdiff_t, not int.
2399
9a900ca9
PE
2400 * xterm.c (x_draw_underwave): Check for integer overflow.
2401 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2402
41b7f8bc 24032012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2404
2405 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2406 referenced (Bug#11583).
2407
9b0e3eba
AA
24082012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2409
2410 Implement wave-style variant of underlining.
2411 * dispextern.h (face_underline_type): New enum.
2412 (face): Add field for underline type.
2413 * nsterm.m (ns_draw_underwave): New function.
2414 (ns_draw_text_decoration): Use it.
2415 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2416 New functions.
2417 (x_draw_glyph_string): Use them.
2418 * xfaces.c (Qline, Qwave): New Lisp objects.
2419 (check_lface_attrs, merge_face_ref)
1053a871
SM
2420 (Finternal_set_lisp_face_attribute, realize_x_face):
2421 Handle wave-style underline face attributes.
9b0e3eba
AA
2422 * xterm.c (x_draw_underwave): New function.
2423 (x_draw_glyph_string): Use it.
2424
0fb52f11
JB
24252012-06-16 Juanma Barranquero <lekktu@gmail.com>
2426
2427 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2428 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2429 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2430 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2431 ($(BLD)/w32select.$(O)): Update dependencies.
2432
e5560ff7
AS
24332012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2434
2435 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2436 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2437 * character.c (_fetch_multibyte_char_p): Remove.
2438 * alloc.c: Include "character.h" before "buffer.h".
2439 * bidi.c: Likewise.
2440 * buffer.c: Likewise.
2441 * bytecode.c: Likewise.
2442 * callint.c: Likewise.
2443 * callproc.c: Likewise.
2444 * casefiddle.c: Likewise.
2445 * casetab.c: Likewise.
2446 * category.c: Likewise.
2447 * cmds.c: Likewise.
2448 * coding.c: Likewise.
2449 * composite.c: Likewise.
2450 * dired.c: Likewise.
2451 * dispnew.c: Likewise.
2452 * doc.c: Likewise.
2453 * dosfns.c: Likewise.
2454 * editfns.c: Likewise.
2455 * emacs.c: Likewise.
2456 * fileio.c: Likewise.
2457 * filelock.c: Likewise.
2458 * font.c: Likewise.
2459 * fontset.c: Likewise.
2460 * fringe.c: Likewise.
2461 * indent.c: Likewise.
2462 * insdel.c: Likewise.
2463 * intervals.c: Likewise.
2464 * keyboard.c: Likewise.
2465 * keymap.c: Likewise.
2466 * lread.c: Likewise.
2467 * macros.c: Likewise.
2468 * marker.c: Likewise.
2469 * minibuf.c: Likewise.
2470 * nsfns.m: Likewise.
2471 * nsmenu.m: Likewise.
2472 * print.c: Likewise.
2473 * process.c: Likewise.
2474 * regex.c: Likewise.
2475 * region-cache.c: Likewise.
2476 * search.c: Likewise.
2477 * syntax.c: Likewise.
2478 * term.c: Likewise.
2479 * textprop.c: Likewise.
2480 * undo.c: Likewise.
2481 * unexsol.c: Likewise.
2482 * w16select.c: Likewise.
2483 * w32fns.c: Likewise.
2484 * w32menu.c: Likewise.
2485 * window.c: Likewise.
2486 * xdisp.c: Likewise.
2487 * xfns.c: Likewise.
2488 * xmenu.c: Likewise.
2489 * xml.c: Likewise.
2490 * xselect.c: Likewise.
2491
2f07e6af
EZ
24922012-06-16 Eli Zaretskii <eliz@gnu.org>
2493
1053a871
SM
2494 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2495 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2496 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2497 row.
2498 (handle_face_prop): Use chunk-relative overlay string index when
2499 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2500 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2501 the rightmost. (Bug#11720)
2f07e6af 2502
29b83cec
AS
25032012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2504
2505 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2506 (CATEGORY_MEMBER): Enforce 1/0 value.
2507 * category.c (_temp_category_set): Remove.
2508
4c5501e9
EZ
25092012-06-16 Eli Zaretskii <eliz@gnu.org>
2510
2511 * window.c (Fdelete_other_windows_internal)
2512 (Fdelete_window_internal): Don't access frame's mouse highlight
2513 info of the initial frame. (Bug#11677)
2514
2b570124
PE
25152012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2516
e93864f9
PE
2517 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2518 Assume USE_2_TAGS_FOR_INTS.
2519 (xreload): Adjust $tagmask width to match recent lisp.h change.
2520
2b570124
PE
2521 Simplify lisp.h in minor ways that should not affect code.
2522 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2523 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2524 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2525 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2526 (INTTYPEBITS): New macro, for clarity.
2527 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2528 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2529 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2530 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2531 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2532
81755f69
JB
25332012-06-13 Juanma Barranquero <lekktu@gmail.com>
2534
2535 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2536
16192a57
GM
25372012-06-13 Glenn Morris <rgm@gnu.org>
2538
2539 * s/bsd-common.h (BSD4_3):
2540 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2541
646b5f55
AS
25422012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2543
2544 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2545 instead of union.
2546 (XLI, XIL): Define.
1053a871
SM
2547 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2548 Use them.
2549 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2550 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2551 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2552 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2553 * frame.c (delete_frame): Remove outdated comment.
2554 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2555 USE_LISP_UNION_TYPE.
2556 (Fw32_unregister_hot_key): Likewise.
2557 (Fw32_toggle_lock_key): Likewise.
2558 * w32menu.c (add_menu_item): Likewise.
2559 (w32_menu_display_help): Use XIL instead of checking
2560 USE_LISP_UNION_TYPE.
2561 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2562 (init_heap): Likewise.
2563 * w32term.c (w32_read_socket): Update comment.
2564
1d3823c9
GM
25652012-06-13 Glenn Morris <rgm@gnu.org>
2566
c62ff706
GM
2567 * s/usg5-4-common.h, src/s/unixware.h:
2568 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2569
1d3823c9
GM
2570 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2571
bfe3e0a2
PE
25722012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2575 * alloc.c (make_number) [!defined make_number]:
2576 Remove, as lisp.h always defines this now.
2577 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2578 (roundup_size): Verify that it is a power of 2.
2579 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2580 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2581 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2582 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2583 USE_LSB_TAG now is always defined to be either 0 or 1.
2584 All uses changed.
2585 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2586 code works fine either way, and efficiency is not a concern here,
2587 as the union type is for debugging, not for production.
2588 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2589 Use an inline function on all platforms when using the union type,
2590 since this is simpler and 'static inline' can be used portably
2591 within Emacs now.
2592 (LISP_INITIALLY_ZERO): New macro.
2593 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2594 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2595
45fa9c0f
GM
25962012-06-12 Glenn Morris <rgm@gnu.org>
2597
b4492cba
GM
2598 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2599
2600 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2601
45fa9c0f
GM
2602 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2603 Move BROKEN_SIGIO to configure.
2604
2605 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2606 Move NO_TERMIO to configure.
2607
0e25d334
CY
26082012-06-12 Chong Yidong <cyd@gnu.org>
2609
2610 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2611 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2612 MagickExportImagePixels is undefined.
2613
43682bb6
PE
26142012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * image.c (imagemagick_load_image): Remove unused label.
2617
a9be7d2b
GM
26182012-06-11 Glenn Morris <rgm@gnu.org>
2619
2620 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2621 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2622 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2623 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2624
3017f87f
SM
26252012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2626
2627 * alloc.c (make_byte_code): New function.
2628 (Fmake_byte_code): Use it. Don't purify here.
2629 * lread.c (read1): Use it as well to avoid extra allocation.
2630
1b9b4cf4
CY
26312012-06-11 Chong Yidong <cyd@gnu.org>
2632
2633 * image.c (imagemagick_load_image): Implement transparency.
2634
95988fcf
AS
26352012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2636
2637 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2638 account for preceding backslashes. (Bug#11663)
2639
cd4eb164
CY
26402012-06-09 Chong Yidong <cyd@gnu.org>
2641
2642 * term.c: Support italics in capable terminals (Bug#9652).
2643 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2644 (turn_on_face): Output using TS_enter_italic_mode if available.
2645 Don't handle unused blinking and alt-charset cases.
2646 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2647 and tty_alt_charset_p cases.
2648 (tty_capable_p, init_tty): Support italics.
2649
2650 * termchar.h (struct tty_display_info): Add field for italics.
2651 Remove unused blink field.
2652
2653 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2654 Handle slant.
2655
2656 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2657 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2658 tty_alt_charset_p. Add tty_italic_p.
2659
ff88beb8
MA
26602012-06-09 Michael Albinus <michael.albinus@gmx.de>
2661
2662 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2663 dbus_type_is_basic if available.
2664 (xd_extract_signed, xd_extract_unsigned): Rename from
2665 extract_signed and extract_unsigned, respectively. Adapt callers.
2666
44286096
CY
26672012-06-09 Chong Yidong <cyd@gnu.org>
2668
1682701f
CY
2669 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2670
44286096
CY
2671 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2672 case (Bug#9752).
2673
d86feb17
PE
26742012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2675
2676 * xdisp.c (vmessage): Treat frame message as multibyte.
2677 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2678 would generate the diagnostic "Making \302\247 buffer-local while
2679 let-bound!".
2680
d5c20fe8
EZ
26812012-06-08 Eli Zaretskii <eliz@gnu.org>
2682
2683 * dispnew.c (showing_window_margins_p): Undo last change, which
2684 was done due to an inadvertent commit.
2685 (adjust_frame_glyphs_for_frame_redisplay): Do call
2686 showing_window_margins_p.
2687
513749ee
SM
26882012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2689
2690 * eval.c (Fmake_var_non_special): New primitive.
2691 (syms_of_eval): Defsubr it.
2692 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2693
d4a8f5c1
JB
26942012-06-08 Juanma Barranquero <lekktu@gmail.com>
2695
2696 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2697 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2698
8bbbc977
EZ
26992012-06-08 Eli Zaretskii <eliz@gnu.org>
2700
2701 * alloc.c (allocate_vectorlike): Fix last change.
2702
f3372c87
DA
27032012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2704
2705 Block-based vector allocation of small vectors.
2706 * lisp.h (struct vectorlike_header): New field `nbytes',
2707 adjust comment accordingly.
2708 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2709 to denote vector blocks. Adjust users (live_vector_p,
2710 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2711 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2712 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2713 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2714 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2715 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2716 (roundup_size): New constant.
2717 (struct vector_block): New data type.
2718 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2719 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2720 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2721 (sweep_vectors): New functions.
2722 (allocate_vectorlike): Return `zero_vector' as the only vector of
2723 0 items. Allocate new vector from block if vector size is less than
2724 or equal to VBLOCK_BYTES_MAX.
2725 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2726 (init_alloc_once): Add call to init_vectors.
2727
4f18a4ed
SM
27282012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2729
2730 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2731
86f158bc
PE
27322012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 * doprnt.c (doprnt): Truncate multibyte char correctly.
2735 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2736 would mishandle a string argument "Xc" if X was a multibyte
2737 character of length 2: it would truncate after X's first byte
2738 rather than including all of X.
2739
c5cfcbe0
CY
27402012-06-06 Chong Yidong <cyd@gnu.org>
2741
2742 * buffer.c (word_wrap): Doc fix.
2743
c05cf390
PE
27442012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2747
0c3461de
GM
27482012-06-03 Glenn Morris <rgm@gnu.org>
2749
2750 * xdisp.c (tool-bar-style): Doc fix.
2751
c71232db
UM
27522012-06-03 Ulrich Müller <ulm@gentoo.org>
2753
2754 * Makefile.in (PAXCTL): Define.
2755 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2756 binary via PaX flags if the paxctl utility is available.
2757 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2758 Restore PaX flags to their default. (Bug#11398)
2759
383f7350
CY
27602012-06-03 Chong Yidong <cyd@gnu.org>
2761
2762 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2763 buffer (Bug#11226).
2764
5f2c76c6
CY
27652012-06-03 Chong Yidong <cyd@gnu.org>
2766
2767 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2768 (note_mode_line_or_margin_highlight): If there is no help echo,
2769 use mode-line-default-help-echo. Handle the case where the mouse
2770 position is past the end of the mode line string.
2771
2772 * buffer.c (buffer_local_value_1): New function, split from
2773 Fbuffer_local_value; can return Qunbound.
2774 (Fbuffer_local_value): Use it.
2775 (Vmode_line_format): Docstring tweaks.
2776
773d47f6
PE
27772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 * sysdep.c (system_process_attributes): Improve comment.
2780
f2d6a3df
SM
27812012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2782
2783 * keyboard.c: Export real-this-command to Elisp.
2784 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2785 and DEFVAR it. Update all users.
2786
63810350
PE
27872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2788
7bd5c1f4
PE
2789 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2790
63810350
PE
2791 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2792 Convert pctcpu and pctmem to Lisp float properly.
2793 Let the compiler fold better, as 100.0/0x8000 is exact.
2794
a2821611
AS
27952012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2796
2797 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2798 cons_block.
2799
5fceba1d
PE
28002012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2803
c98ff5dd
DA
28042012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2805
2806 For a 'struct window', replace some Lisp_Object fields to
2807 bitfields where appropriate, remove unused fields.
2808 * window.h (struct window): Remove unused 'last_mark_x' and
2809 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2810 change it's type from Lisp_Object to bitfield.
2811 Change type of 'force_start', 'optional_new_start',
2812 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2813 fields from Lisp_Object to bitfield. Adjust users accordingly.
2814
ca34e0be
PE
28152012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2816
2817 Pacify gcc -Wdouble-precision when using Xaw.
2818 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2819 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2820 Use 'float' consistently, rather than 'float' in most places
2821 and 'double' in a couple of places.
2822
efc00ab1 28232012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2824
2825 * xdisp.c (handle_stop): Detect whether we have overlay strings
2826 loaded by testing it->current.overlay_string_index to be
2827 non-negative, instead of checking whether n_overlay_strings is
2828 positive. (Bug#11587)
2829
efc00ab1 28302012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2831
2832 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2833
2834 * doc.c (Fsubstitute_command_keys): Doc fix.
2835
efc00ab1 28362012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2837
2838 * search.c (search_buffer): Remove calls to
2839 r_alloc_inhibit_buffer_relocation, as it is now called by
2840 maybe_unify_char, which was the cause of relocation of buffer text
2841 in bug#11519.
2842
efc00ab1 28432012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2844
2845 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2846 for the duration of call to load_charset, to avoid problems with
2847 callers of maybe_unify_char that access buffer text through C
2848 pointers.
2849
2850 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2851 decrement the inhibition flag, instead of just setting or
2852 resetting it.
2853
ba93a187
PE
28542012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2855
2856 Remove obsolete '#define static' cruft.
2857 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2858 This #undef was "temporary" in 2000; it is no longer needed
2859 now that '#define static' has gone away.
2860 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2861 (gray_bitmap_bits): Remove; no longer needed.
2862 All uses replaced with definiens.
2863 * xterm.c: Include "bitmaps/gray.xbm".
2864
9e4bf381
PE
28652012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2866
2867 Clean up __executable_start, monstartup when --enable-profiling.
2868 The following changes affect the code only when profiling.
2869 * dispnew.c (__executable_start): Rename from safe_bcopy.
2870 Define only on platforms that need it.
2871 * emacs.c: Include <sys/gmon.h> when profiling.
2872 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2873 (__executable_start): Remove decl, since lisp.h does it now.
2874 (safe_bcopy): Remove decl; no longer has that name.
2875 (main): Coalesce #if into single bit of code, for simplicity.
2876 Cast pointers to uintptr_t, since standard libraries want integers
2877 and not pointers.
2878 * lisp.h (__executable_start): New decl.
2879
32d72c2f
GM
28802012-05-31 Glenn Morris <rgm@gnu.org>
2881
2882 * image.c (Fimagemagick_types): Doc fix.
2883
baac5bc7
JM
28842012-05-30 Jim Meyering <meyering@redhat.com>
2885
2886 * callproc.c (Fcall_process_region): Include directory component
2887 in mkstemp error message (Bug#11586).
2888
72cb32cf
PE
28892012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * alloc.c, lisp.h (make_pure_vector): Now static.
2892
61b108cc
SM
28932012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2894
2895 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2896 Move to byte-run.el.
2897 (Fautoload): Do the hash-doc more carefully.
2898 * data.c (Fdefalias): Purify definition, except for keymaps.
2899 (Qdefun): Move from eval.c.
2900 * lisp.h (Qdefun): Remove.
2901 * lread.c (read1): Tiny simplification.
2902
471fe23d
TN
29032012-05-29 Troels Nielsen <bn.troels@gmail.com>
2904
934f3f58 2905 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2906 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2907 Bug#9642, but explicitly check that the buffer the overlay would
2908 be moved to is live and rearrange lines to make sure that errors
2909 will not put the overlay in an inconsistent state.
2910 (Fdelete_overlay): Cosmetics.
2911
85d0efd1
EZ
29122012-05-28 Eli Zaretskii <eliz@gnu.org>
2913
2914 * w32term.c (my_bring_window_to_top): New function.
2915 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2916 could be different from the original one.
2917 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2918 (Bug#11513)
2919
2920 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2921 by calling BringWindowToTop.
2922
2923 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2924 (WM_EMACS_END): Increase by one.
2925
da92a98c
PE
29262012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2929 This avoids undefined behavior that might cause the eassert
2930 to not catch an out-of-range value.
2931
74d1f848
JB
29322012-05-28 Juanma Barranquero <lekktu@gmail.com>
2933
2934 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2935 Update dependencies.
2936
9e1a06fc
EZ
29372012-05-27 Eli Zaretskii <eliz@gnu.org>
2938
2939 * bidi.c (bidi_mirror_char): Fix last change.
2940
f3dd7312
AS
29412012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2942
2943 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2944 when referring to sectname field in printf format.
2945
81899c91
PE
29462012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2947
57b81a9f
PE
2948 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2949 Only r_alloc_inhibit_buffer_relocation needed to be added;
2950 the others were already declared.
2951
81899c91
PE
2952 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2953 before checking whether it's out of range. Put the check inside
2954 eassert. See
2955 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2956
33017faf 29572012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2958
2959 * callproc.c (Fcall_process): Restore a line that was accidentally
2960 commented out in the 2011-02-13 change (bug#11547).
2961
33017faf 29622012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2963
2964 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2965 defined on ralloc.c.
2966
2967 * buffer.c [REL_ALLOC]: Remove prototypes of
2968 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2969 they are now on lisp.h.
2970
2971 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2972
2973 * search.c (search_buffer): Use it to inhibit relocation of buffer
2974 text while re_search_2 is doing its job, because re_search_2 is
2975 passed C pointers to buffer text. (Bug#11519)
2976
23415acf
EZ
2977 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2978 Update value to 24.
2979
44e27368
EZ
2980 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2981 state after an additional call to move_it_in_display_line_to, keep
2982 the values of it->max_ascent and it->max_descent found for the
2983 entire line.
2984 (pos_visible_p): Revert the comparison against bottom_y to what it
2985 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2986 (Bug#11464)
2987
c1892f11
PE
29882012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 Fix coding-related core dumps with gcc -ftrapv.
2991 The code was computing A - B, where A and B are pointers, and B is
2992 random garbage. This can lead to core dumps on platforms that
2993 have special pointer registers, and it also leads to core dumps on
2994 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2995 A - B only when B is initialized properly.
2996 * coding.c (coding_set_source, coding_set_destination): Return void.
2997 (coding_change_source, coding_change_destinations): New functions,
2998 with the old behaviors of coding_set_source and coding_set_destination.
2999 All callers that need an offset changed to use these new functions.
3000
eb7afdad
GM
30012012-05-26 Glenn Morris <rgm@gnu.org>
3002
3003 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3004
f12fdf02
EZ
30052012-05-26 Eli Zaretskii <eliz@gnu.org>
3006
53a63be6 3007 Extend mouse support on W32 text-mode console.
61b108cc
SM
3008 * xdisp.c (draw_row_with_mouse_face):
3009 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3010
eb3f6f01 3011 * w32console.c: Include window.h.
61b108cc
SM
3012 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3013 New functions.
eb3f6f01
EZ
3014 (initialize_w32_display): Initialize mouse-highlight data.
3015
53a63be6
EZ
3016 * w32inevt.c: Include termchar.h and window.h.
3017 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3018 moves, call note_mouse_highlight. If help_echo changed, call
3019 gen_help_event to produce help-echo message in the echo area.
3020 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3021 highlight info.
3022
4cfd81f6
PE
30232012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * lread.c (read1): Simplify slightly to avoid an overflow warning
3026 with GCC 4.7.0 on x86-64.
3027
4446092a
EZ
30282012-05-26 Eli Zaretskii <eliz@gnu.org>
3029
3030 * bidi.c (bidi_mirror_char): Revert last change: an int is
3031 definitely wide enough here.
3032
42b2a986 30332012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3034
42b2a986 3035 Fix integer width and related bugs (Bug#9874).
eb106a49 3036 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3037 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3038 (string_bytes, check_sblock, allocate_string_data):
3039 (compact_small_strings, Fmake_bool_vector, make_string)
3040 (make_unibyte_string, make_multibyte_string)
3041 (make_string_from_bytes, make_specified_string)
3042 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3043 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3044 (mark_vectorlike):
3045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3046 (allocate_pseudovector):
3047 Use int, not EMACS_INT, where int is wide enough.
3048 (inhibit_garbage_collection, Fgarbage_collect):
3049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3050 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3051 int might not be wide enough.
3052 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3053 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3054 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3055 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3056 (bidi_level_of_next_char, bidi_move_to_visually_next):
3057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3058 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3059 (Fkill_buffer, Fset_buffer_major_mode)
3060 (advance_to_char_boundary, Fbuffer_swap_text)
3061 (Fset_buffer_multibyte, overlays_at, overlays_in)
3062 (overlay_touches_p, struct sortvec, record_overlay_string)
3063 (overlay_strings, recenter_overlay_lists)
3064 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3065 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3066 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3067 (Foverlay_recenter, last_overlay_modification_hooks_used)
3068 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3070 (validate_region): Omit unnecessary test for b <= e,
3071 since that's guaranteed by the previous test.
d311d28c
PE
3072 (adjust_overlays_for_delete): Avoid pos + length overflow.
3073 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3074 (report_overlay_modification):
3075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3076 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3077 Omit pointer cast, which isn't needed anyway, and doesn't work
3078 after the EMACS_INT -> ptrdiff_t change.
02481186 3079 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3080 * buffer.h: Adjust decls to match defn changes elsewhere.
3081 (struct buffer_text, struct buffer):
3082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3083 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3084 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3085 not int, to avoid needless 32-bit limit on 64-bit hosts.
3086 (exec_byte_code): Use tighter memory-full test, one that checks
3087 for alloca overflow. Don't compute the address of the object just
3088 before an array, as that's not portable. Use EMACS_INT, not
3089 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3090 * callint.c (Fcall_interactively):
3091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3092 * callproc.c (call_process_kill, Fcall_process):
3093 Don't assume pid_t fits into an Emacs fixnum.
3094 (call_process_cleanup, Fcall_process, child_setup):
3095 Don't assume pid_t fits into int.
3096 (call_process_cleanup, Fcall_process, delete_temp_file)
3097 (Fcall_process_region):
3098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3099 (Fcall_process): Simplify handling of volatile integers.
3100 Use int, not EMACS_INT, where int will do.
3101 * casefiddle.c (casify_object, casify_region, operate_on_word)
3102 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3104 (casify_object): Avoid integer overflow when overallocating buffer.
3105 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3106 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3107 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3108 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3109 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3110 integers are now checked earlier. All uses replaced with XINT.
3111 (ccl_driver):
3112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3113 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3114 (ccl_driver, Fregister_code_conversion_map):
3115 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3116 (resolve_symbol_ccl_program): Check that vector header is in range.
3117 Always copy the vector, so that we can check its contents reliably
3118 now rather than having to recheck each instruction as it's being
3119 executed. Check that vector words fit in 'int'.
3120 (ccl_get_compiled_code, Fregister_ccl_program)
3121 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3122 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3123 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3124 contents are in range.
3125 (Fccl_execute_on_string): Check that status is in range.
3126 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3127 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3128 Accept and return EMACS_INT, not int, because callers can pass values
3129 out of 'int' range.
3130 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3131 (multibyte_chars_in_text, parse_str_as_multibyte)
3132 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3133 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3134 (string_escape_byte8, Fget_byte):
3135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3136 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3137 avoid mishandling large integers.
3138 * character.h: Adjust decls to match defn changes elsewhere.
3139 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3140 (Ffind_charset_region):
3141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3142 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3143 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3144 Don't assume fixnum fits in int.
d311d28c
PE
3145 (load_charset_map_from_vector, Fmap_charset_chars):
3146 Remove now-unnecessary CHECK_NATNUMs.
3147 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3148 Don't rely on undefined behavior with signed left shift overflow.
3149 Don't assume unsigned int fits into fixnum, or that fixnum fits
3150 into unsigned int. Don't require max_code to be a valid fixnum;
3151 that's not true for gb10830 4-byte on a 32-bit host. Allow
3152 invalid_code to be a cons, for the same reason. Require code_offset
3153 to be a character. Avoid int overflow if max_char is close
3154 to INT_MAX.
3155 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3156 this is intended anyway and avoids some undefined behavior.
3157 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3158 INDEX_TO_CODE_POINT, as that's what it expects.
3159 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3160 * charset.h (DECODE_CHAR): Return int, not unsigned;
3161 this is what was intended anyway, and it avoids undefined behavior.
3162 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3163 integer-overflow issues.
3164 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3165 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3166 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3167 * chartab.c (Fmake_char_table, Fset_char_table_range)
3168 (uniprop_get_decoder, uniprop_get_encoder):
3169 Don't assume fixnum fits in int.
3170 * cmds.c (move_point): New function, that does the gist of
3171 Fforward_char and Fbackward_char, but does so while checking
3172 for integer overflow more accurately.
c96e5d6a 3173 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3174 (Fforward_line, Fend_of_line, internal_self_insert)
3175 (internal_self_insert):
3176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3177 Fix a FIXME, by checking for integer overflow when calculating
3178 target_clm and actual_clm.
3179 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3180 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3181 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3182 (coding_alloc_by_making_gap, alloc_destination)
3183 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3184 (encode_coding_utf_16, detect_coding_emacs_mule)
3185 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3186 (detect_coding_iso_2022, decode_coding_iso_2022)
3187 (encode_invocation_designation, encode_designation_at_bol)
3188 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3189 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3190 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3191 (encode_coding_ccl, encode_coding_raw_text)
3192 (detect_coding_charset, decode_coding_charset)
3193 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3194 (produce_composition, produce_charset, produce_annotation)
3195 (decode_coding, handle_composition_annotation)
3196 (handle_charset_annotation, consume_chars, decode_coding_gap)
3197 (decode_coding_object, encode_coding_object, detect_coding_system)
3198 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3199 (code_convert_region, code_convert_string)
8f50130c
PE
3200 (Fdefine_coding_system_internal)
3201 (coding_set_source, coding_set_destination):
d311d28c
PE
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3204 (Fdefine_coding_system_internal):
3205 Don't assume fixnums fit in int.
3206 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3207 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3208 (Funencodable_char_position, Fcheck_coding_systems_region)
3209 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3211 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3212 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3213 Don't access memory outside of the args array.
d311d28c 3214 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3215 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3216 result of ENCODE_CHAR.
d311d28c
PE
3217 * coding.h: Adjust decls to match defn changes elsewhere.
3218 (struct coding_system):
3219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3220 * composite.c (get_composition_id, find_composition)
3221 (run_composition_function, update_compositions)
3222 (compose_text, composition_gstring_put_cache)
3223 (composition_gstring_p, composition_gstring_width)
3224 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3225 (composition_compute_stop_pos, composition_reseat_it)
3226 (composition_update_it, struct position_record)
3227 (find_automatic_composition, composition_adjust_point)
3228 (Fcomposition_get_gstring, Ffind_composition_internal):
3229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3230 (update_compositions):
3231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3232 * composite.h: Adjust decls to match defn changes elsewhere.
3233 (struct composition):
3234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3235 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3236 Do not attempt to compute the address of the object just before a
3237 buffer; this is not portable.
3238 (Faref, Faset):
3239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3240 (Faset): Use int, not EMACS_INT, where int is wide enough.
3241 (Fstring_to_number): Don't assume fixnums fit in int.
3242 (Frem): Don't assume arg is nonnegative.
3243 * dbusbind.c (xd_append_arg): Check for integers out of range.
3244 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3245 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3246 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3247 (xd_get_connection_references): Return ptrdiff_t, not int.
3248 All uses changed.
3249 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3250 (xd_read_message_1):
3251 Use int, not unsigned, where the dbus API uses int.
3252 (Fdbus_message_internal): Don't overflow mtype.
3253 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3254 * dired.c (directory_files_internal, file_name_completion, scmp)
3255 (file_name_completion_stat):
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 (file_name_completion): Don't overflow matchcount.
3258 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3259 * dispextern.h: Adjust decls to match defn changes elsewhere.
3260 (struct text_pos, struct glyph, struct bidi_saved_info)
3261 (struct bidi_string_data, struct bidi_it, struct composition_it)
3262 (struct it):
3263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3264 (struct display_pos, struct composition_it, struct it):
3265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3266 * dispnew.c (increment_matrix_positions)
3267 (increment_row_positions, mode_line_string)
3268 (marginal_area_string):
3269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3270 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3272 (duration_to_sec_usec): New function, to check for overflow better.
3273 (Fsleep_for, sit_for): Use it.
3274 * doc.c (get_doc_string, store_function_docstring):
3275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3276 (get_doc_string, Fsnarf_documentation):
3277 Use int, not EMACS_INT, where int is wide enough.
3278 (get_doc_string):
3279 Use SAFE_ALLOCA, not alloca.
3280 Check for overflow when converting EMACS_INT to off_t.
3281 * doprnt.c (doprnt):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3284 Don't assume uid_t fits into fixnum.
3285 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3286 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3287 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3288 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3289 (general_insert_function)
3290 (Finsert_char, make_buffer_string, make_buffer_string_both)
3291 (update_buffer_properties, Fbuffer_substring)
3292 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3293 (Fsubst_char_in_region, check_translation)
3294 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3295 (transpose_markers, Ftranspose_regions):
3296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3297 (clip_to_bounds): Move to lisp.h as an inline function).
3298 (Fconstrain_to_field): Don't assume integers are nonnegative.
3299 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3300 (Fsubst_char_in_region, Fsave_restriction):
3301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3302 (Femacs_pid): Don't assume pid_t fits into fixnum.
3303 (lo_time): Use int, not EMACS_INT, when int suffices.
3304 (lisp_time_argument): Check for usec out of range.
3305 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3306 (Fuser_login_name, Fuser_full_name): Signal an error
3307 if a uid argument is out of range, rather than relying on
3308 undefined behavior.
c8d5c857
PE
3309 (Fformat_time_string): Remove now-unnecessary check.
3310 lisp_time_argument checks for out-of-range usec now.
243e0530 3311 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3312 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3313 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3314 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3315 (init_cmdargs, Fdump_emacs):
3316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3317 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3318 the bottom (typically) 32 bits of the fixnum.
3319 * eval.c (specpdl_size, call_debugger):
3320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3321 (when_entered_debugger, Fbacktrace_debug):
3322 Don't assume fixnum can fit in int.
3323 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3324 the object just before a buffer; this is not portable.
3325 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3326 (grow_specpdl, unbind_to):
3327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3328 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3329 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3330 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3331 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3332 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3334 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3335 (a_write, e_write):
3336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3337 (Fcopy_file, non_regular_nbytes, read_non_regular)
3338 (Finsert_file_contents):
3339 Use int, not EMACS_INT, where int is wide enough.
3340 (READ_BUF_SIZE): Verify that it fits in int.
3341 (Finsert_file_contents): Check that counts are in proper range,
3342 rather than assuming fixnums fit into ptrdiff_t etc.
3343 Don't assume fixnums fit into int.
125b3835 3344 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3345 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3346 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3347 (string_char_to_byte, string_byte_to_char)
3348 (string_make_multibyte, string_to_multibyte)
3349 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3350 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3351 (substring_both, Fdelete, internal_equal, Ffillarray)
3352 (Fclear_string, mapcar1)
3353 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3354 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3355 (larger_vector, make_hash_table, maybe_resize_hash_table)
3356 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3357 (Fmaphash, secure_hash):
3358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3359 (concat): Check for string index and length overflow.
3360 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3361 (Frequire):
3362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3363 (larger_vector): New API (vec, incr_min, size_max) replaces old
3364 one (vec, new_size, init). This catches size overflow.
3365 INIT was removed because it was always Qnil.
3366 All callers changed.
3367 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3368 the upper bound on a hash table index size.
3369 (make_hash_table, maybe_resize_hash_table): Use it.
3370 (secure_hash): Computer start_byte and end_byte only after
3371 they're known to be in ptrdiff_t range.
3372 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3373 (Ffont_get_glyphs, Ffont_at):
3374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3375 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3376 (Flist_fonts, Fopen_font):
3377 Don't assume fixnum can fit in int.
3378 (check_gstring): Don't assume index can fit in int.
3379 (font_match_p): Check that fixnum is a character, not a nonnegative
3380 fixnum, since the later code needs to stuff it into an int.
3381 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3382 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3383 conversion overflow issues.
3384 (Fopen_font): Check for integer out of range.
3385 (Ffont_get_glyphs): Don't assume index can fit in int.
3386 * font.h: Adjust decls to match defn changes elsewhere.
3387 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3388 integer overflow.
3389 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3390 printmax_t, where ptrdiff_t is wide enough.
3391 (Finternal_char_font):
3392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3393 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3394 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3395 (Fset_frame_position, x_set_frame_parameters)
3396 (x_set_line_spacing, x_set_border_width)
3397 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3398 Check that fixnums are in proper range for system types.
3399 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3401 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3402 Use SAFE_ALLOCA_LISP, not alloca.
3403 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3404 intptr_t is wide enough.
3405 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3406 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3407 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3408 Check for fixnum out of range.
3409 * ftfont.c (ftfont_list): Don't assume index fits in int.
3410 Check that fixnums are in proper range for system types.
3411 (ftfont_shape_by_flt):
3412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3413 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3415 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3416 Check that fixnums are in proper range for system types.
3417 * gnutls.h: Adjust decls to match defn changes elsewhere.
3418 * gtkutil.c (xg_dialog_run):
3419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3420 (update_frame_tool_bar):
3421 Check that fixnums are in proper range for system types.
3422 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3423 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3424 * indent.c (last_known_column, last_known_column_point):
3425 (current_column_bol_cache):
3426 (skip_invisible, current_column, check_display_width):
3427 (check_display_width, scan_for_column, current_column_1)
3428 (Findent_to, Fcurrent_indentation, position_indentation)
3429 (indented_beyond_p, Fmove_to_column, compute_motion):
3430 (Fcompute_motion, Fvertical_motion):
3431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3432 (last_known_column_modified): Use EMACS_INT, not int.
3433 (check_display_width):
3434 (Fcompute_motion):
3435 Check that fixnums and floats are in proper range for system types.
3436 (compute_motion): Don't assume index or fixnum fits in int.
3437 (compute_motion, Fcompute_motion):
3438 Use int, not EMACS_INT, when it is wide enough.
3439 (vmotion): Omit local var start_hpos that is always 0; that way
3440 we don't need to worry about overflow in expressions involving it.
3441 * indent.h: Adjust decls to match defn changes elsewhere.
3442 (struct position):
3443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3444 Use int, not EMACS_INT, where int is wide enough.
3445 Remove unused members ovstring_chars_done and tab_offset;
3446 all uses removed.
3447 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3448 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3449 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3450 (make_gap, copy_text, insert, insert_and_inherit)
3451 (insert_before_markers, insert_before_markers_and_inherit)
3452 (insert_1, count_combining_before, count_combining_after)
3453 (insert_1_both, insert_from_string)
3454 (insert_from_string_before_markers, insert_from_string_1)
3455 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3456 (adjust_after_replace, adjust_after_insert, replace_range)
3457 (replace_range_2, del_range, del_range_1, del_range_byte)
3458 (del_range_both, del_range_2, modify_region)
3459 (prepare_to_modify_buffer, signal_before_change)
3460 (signal_after_change, Fcombine_after_change_execute):
3461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3462 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3463 (balance_an_interval, split_interval_right, split_interval_left)
3464 (find_interval, next_interval, update_interval)
3465 (adjust_intervals_for_insertion, delete_node, delete_interval)
3466 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3467 (static_offset_intervals, offset_intervals)
3468 (merge_interval_right, merge_interval_left, make_new_interval)
3469 (graft_intervals_into_buffer, temp_set_point_both)
3470 (temp_set_point, set_point, adjust_for_invis_intang)
3471 (set_point_both, move_if_not_intangible, get_property_and_range)
3472 (get_local_map, copy_intervals, copy_intervals_to_string)
3473 (compare_string_intervals, set_intervals_multibyte_1):
3474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3475 * intervals.h: Adjust decls to match defn changes elsewhere.
3476 (struct interval):
3477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3478 * keyboard.c (this_command_key_count, this_single_command_key_start)
3479 (before_command_key_count, before_command_echo_length, echo_now)
3480 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3481 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3482 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3483 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3485 (last_non_minibuf_size, last_point_position, echo_truncate)
3486 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3487 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3488 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3489 (stuff_buffered_input):
3490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3491 (last_auto_save, command_loop_1, read_char):
3492 Use EMACS_INT, not int, to avoid integer overflow.
3493 (record_char): Avoid overflow in total_keys computation.
3494 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3495 * keyboard.h: Adjust decls to match defn changes elsewhere.
3496 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3497 (Fkey_description, Fdescribe_vector, Flookup_key):
3498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3499 (click_position): New function, to check that positions are in range.
3500 (Fcurrent_active_maps):
3501 (describe_command):
3502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3503 (Faccessible_keymaps, Fkey_description):
3504 (preferred_sequence_p):
3505 Don't assume fixnum can fit into int.
3506 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3507 Check for integer overflow in size calculations.
3508 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3509 avoid mishandling large integers.
3510 * lisp.h: Adjust decls to match defn changes elsewhere.
3511 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3512 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3513 (struct Lisp_Marker):
3514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3515 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3516 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3517 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3518 All callers changed.
3519 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3520 Assume the arg has valid form, since it always does.
3521 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3522 unsigned integer system type.
3523 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3524 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3526 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3527 (duration_to_sec_usec): New decl.
3528 * lread.c (read_from_string_index, read_from_string_index_byte)
3529 (read_from_string_limit, readchar, unreadchar, openp)
3530 (read_internal_start, read1, oblookup):
3531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3532 (Fload, readevalloop, Feval_buffer, Feval_region):
3533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3534 (openp): Check for out-of-range argument to 'access'.
3535 (read1): Use int, not EMACS_INT, where int is wide enough.
3536 Don't assume fixnum fits into int.
6efdadfd 3537 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3538 (read_filtered_event): Use duration_to_sec_usec
3539 to do proper overflow checking on durations.
d311d28c
PE
3540 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3541 in size calculation.
3542 (Fexecute_kbd_macro):
3543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3544 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3545 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3546 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3547 (set_marker_both, set_marker_restricted_both, marker_position)
3548 (marker_byte_position, Fbuffer_has_markers_at):
3549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3550 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3551 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3552 It now merely ensures that the menu is large enough, without
3553 necessarily growing it, as this avoids some integer overflow issues.
3554 All callers changed.
3555 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3557 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3558 Use SAFE_ALLOCA_LISP, not alloca.
3559 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3560 to EMACS_INT. Check that fixnums are in proper range for system types.
3561 * minibuf.c (minibuf_prompt_width, string_to_object)
3562 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3563 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3565 (get_minibuffer, read_minibuf_unwind):
3566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3567 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3568 this simplifies overflow checking. All callers changed.
3569 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3570 (Ftest_completion):
3571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3572 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3573 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3574 Check that fixnums are in proper range for system types.
3575 (Fx_create_frame, Fx_show_tip):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 * nsfont.m (ns_findfonts, nsfont_list_family):
3578 Don't assume fixnum fits in long.
3579 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3581 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3582 wide enough.
17fdb222 3583 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3585 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3586 (PRINTDECLARE, PRINTPREPARE):
3587 (strout, print_string):
3588 (print, print_preprocess, print_check_string_charset_prop)
3589 (print_object):
3590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3591 (PRINTDECLARE):
3592 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3594 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3595 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3596 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3597 (print_error_message): Use SAFE_ALLOCA, not alloca.
3598 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3599 (print_depth, new_backquote_output, print_number_index):
3600 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3601 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3602 (Fset_process_window_size, Fformat_network_address)
3603 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3604 (sigchld_handler):
d311d28c 3605 Check that fixnums are in proper range for system types.
d44287d4 3606 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3607 Check for process-ids out of pid_t range rather than relying on
3608 undefined behavior.
e4d81efc 3609 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3610 (Fformat_network_address, read_process_output, send_process)
3611 (Fprocess_send_region, status_notify):
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3614 (wait_reading_process_output, read_process_output, exec_sentinel):
3615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3616 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3617 (Faccept_process_output): Use duration_to_sec_usec to do proper
3618 overflow checking on durations.
dde14581
PE
3619 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3620 Don't assume pid_t fits in int.
02481186
PE
3621 * process.h (struct Lisp_Process): Members tick and update_tick
3622 are now of type EMACS_INT, not int.
b62b53e8
PE
3623 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3624 configured --with-wide-int.
d311d28c
PE
3625 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3626 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3627 * search.c (looking_at_1, string_match_1):
3628 (fast_string_match, fast_c_string_match_ignore_case)
3629 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3630 (scan_newline, find_before_next_newline, search_command)
3631 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3632 (set_search_regs, wordify):
3633 (Freplace_match):
3634 (Fmatch_data):
3635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3636 (string_match_1, search_buffer, set_search_regs):
3637 (Fmatch_data):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 (wordify): Check for overflow in size calculation.
3640 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3641 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3642 Check that fixnums are in proper range for system types.
3643 * sound.c (struct sound_device)
3644 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3646 (Fplay_sound_internal):
3647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3648 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3649 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3650 (Fparse_partial_sexp):
3651 Don't assume fixnums can fit in int.
3652 (struct lisp_parse_state, find_start_pos, find_start_value)
3653 (find_start_value_byte, find_start_begv)
3654 (update_syntax_table, char_quoted, dec_bytepos)
3655 (find_defun_start, prev_char_comend_first, back_comment):
3656 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3657 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3659 (Finternal_describe_syntax_value): Check that match_lisp is a
3660 character, not an integer, since the code stuffs it into int.
3661 (scan_words, scan_sexps_forward):
3662 Check that fixnums are in proper range for system types.
3663 (Fforward_word):
3664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3665 (scan_sexps_forward):
3666 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3667 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3668 * syntax.h: Adjust decls to match defn changes elsewhere.
3669 (struct gl_state_s):
3670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3671 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3672 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3673 * sysdep.c (wait_for_termination_1, wait_for_termination)
3674 (interruptible_wait_for_termination, mkdir):
3675 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3676 (emacs_read, emacs_write):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3678 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3679 and double all fit in int.
d311d28c
PE
3680 * term.c (set_tty_color_mode):
3681 Check that fixnums are in proper range for system types.
3682 * termhooks.h (struct input_event):
3683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3684 * textprop.c (validate_interval_range, interval_of)
3685 (Fadd_text_properties, set_text_properties_1)
3686 (Fremove_text_properties, Fremove_list_of_text_properties)
3687 (Ftext_property_any, Ftext_property_not_all)
3688 (copy_text_properties, text_property_list, extend_property_ranges)
3689 (verify_interval_modification):
3690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3691 (Fnext_single_char_property_change)
3692 (Fprevious_single_char_property_change):
3693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3694 (copy_text_properties):
3695 Check for integer overflow in index calculation.
d311d28c
PE
3696 * undo.c (last_boundary_position, record_point, record_insert)
3697 (record_delete, record_marker_adjustment, record_change)
3698 (record_property_change):
3699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3700 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3702 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3703 (Fx_hide_tip, Fx_file_dialog):
3704 * w32menu.c (set_frame_menubar):
3705 Use ptrdiff_t, not int, for consistency with rest of code.
3706 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3707 (select_window, Fdelete_other_windows_internal)
3708 (window_scroll_pixel_based, window_scroll_line_based)
3709 (Frecenter, Fset_window_configuration):
3710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3711 (Fset_window_hscroll, run_window_configuration_change_hook)
3712 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3713 (Fscroll_other_window, Frecenter):
d311d28c
PE
3714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3715 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3716 Don't assume fixnum fits in int.
3717 (Fset_window_scroll_bars):
3718 Check that fixnums are in proper range for system types.
3719 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3720 (string_pos, c_string_pos, number_of_chars, init_iterator)
3721 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3722 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3723 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3724 (face_before_or_after_it_pos, handle_invisible_prop)
3725 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3726 (display_prop_intangible_p, string_buffer_position_lim)
3727 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3728 (get_overlay_strings_1, get_overlay_strings)
3729 (iterate_out_of_display_property, forward_to_next_line_start)
3730 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3731 (get_next_display_element, set_iterator_to_next)
3732 (get_visually_first_element, compute_stop_pos_backwards)
3733 (handle_stop_backwards, next_element_from_buffer)
3734 (move_it_in_display_line_to, move_it_in_display_line)
3735 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3736 (add_to_log, message_dolog, message_log_check_duplicate)
3737 (message2, message2_nolog, message3, message3_nolog
3738 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3739 (current_message_1, truncate_echo_area, truncate_message_1)
3740 (set_message, set_message_1, store_mode_line_noprop)
3741 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3742 (text_outside_line_unchanged_p, check_point_in_composition)
3743 (reconsider_clip_changes)
3744 (redisplay_internal, set_cursor_from_row, try_scrolling)
3745 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3746 (redisplay_window, find_last_unchanged_at_beg_row)
3747 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3748 (trailing_whitespace_p, find_row_edges, display_line)
3749 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3750 (display_mode_element, store_mode_line_string)
3751 (pint2str, pint2hrstr, decode_mode_spec)
3752 (display_count_lines, display_string, draw_glyphs)
3753 (x_produce_glyphs, x_insert_glyphs)
3754 (rows_from_pos_range, mouse_face_from_buffer_pos)
3755 (fast_find_string_pos, mouse_face_from_string_pos)
3756 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3758 (safe_call, init_from_display_pos, handle_fontified_prop)
3759 (handle_single_display_spec, load_overlay_strings)
3760 (with_echo_area_buffer, setup_echo_area_for_printing)
3761 (display_echo_area, echo_area_display)
3762 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3763 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3764 (redisplay_window, dump_glyph_row, display_mode_line)
3765 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3766 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3768 (handle_single_display_spec, build_desired_tool_bar_string)
3769 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3770 (get_specified_cursor_type):
3771 Check that fixnums are in proper range for system types.
3772 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3773 (Flookup_image_map):
3774 Don't assume fixnums fit in int.
3775 (compare_overlay_entries):
3776 Avoid mishandling comparisons due to subtraction overflow.
3777 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3778 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3779 (handle_tool_bar_click):
3780 Use int, not unsigned, since we prefer signed and the signedness
3781 doesn't matter here.
3782 (get_next_display_element, next_element_from_display_vector):
3783 Use int, not EMACS_INT, when int is wide enough.
3784 (start_hourglass): Use duration_to_sec_usec to do proper
3785 overflow checking on durations.
3786 * xfaces.c (Fbitmap_spec_p):
3787 Check that fixnums are in proper range for system types.
3788 (compare_fonts_by_sort_order):
3789 Avoid mishandling comparisons due to subtraction overflow.
3790 (Fx_family_fonts, realize_basic_faces):
3791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3792 (Fx_family_fonts):
3793 Don't assume fixnum fits in int.
3794 Use SAFE_ALLOCA_LISP, not alloca.
3795 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3796 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3797 (face_at_buffer_position, face_for_overlay_string)
3798 (face_at_string_position):
3799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3800 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3801 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3802 (Fx_show_tip):
3803 Check that fixnums are in proper range for system types.
3804 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3805 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3807 (Fx_change_window_property): Don't assume fixnums fit in int.
3808 * xfont.c (xfont_chars_supported):
3809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3810 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3811 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3813 * xml.c (parse_region):
3814 * xrdb.c (magic_file_p):
3815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3816 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3817 (x_get_local_selection, x_reply_selection_request)
3818 (x_handle_selection_request, wait_for_property_change):
3819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3820 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3821 short is wide enough.
3822 (x_send_client_event): Don't assume fixnum fits in int.
3823 * xterm.c (x_x_to_emacs_modifiers):
3824 Don't assume EMACS_INT overflows nicely into int.
3825 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3826 may come from Lisp.
3827 (handle_one_xevent): NATNUMP can eval its arg twice.
3828 (x_connection_closed):
3829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3830 * xterm.h: Adjust decls to match defn changes elsewhere.
3831 (struct scroll_bar): Use struct vectorlike_header
3832 rather than rolling our own approximation.
3833 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3834
c6574eb5
GM
38352012-05-25 Glenn Morris <rgm@gnu.org>
3836
3837 * lisp.mk (lisp): Update for more files being compiled now.
3838
e8d32c7e
SM
38392012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3840
48def666
SM
3841 * lread.c: Remove `read_pure' which makes no difference.
3842 (read_pure): Remove var.
3843 (unreadpure): Remove function.
3844 (readevalloop): Don't call read_list with -1 flag.
3845 (read1, read_vector): Don't test read_pure any more.
3846 (read_list): Simplify.
3847
e8d32c7e
SM
3848 * fileio.c, character.h: Minor style tweaks.
3849
4b2addb7
DA
38502012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3851
3852 * window.h (clip_changed): Remove useless declaration.
3853
584461b2
JB
38542012-05-22 Juanma Barranquero <lekktu@gmail.com>
3855
3856 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3857 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3858
34374650
PE
38592012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3860
3861 Remove src/m/*.
3862 This directory predates autoconf and is no longer needed nowadays.
3863 Move its few remaining bits of functionality to where they're needed.
3864 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3865 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3866 * m/template.h: Remove.
3867 * Makefile.in (M_FILE): Remove. All uses removed.
3868 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3869 * lisp.h (USE_LSB_TAG):
3870 * mem-limits.h (EXCEEDS_LISP_PTR):
3871 Use VAL_MAX, not VALBITS, in #if.
3872 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3873 (EMACS_UINT): Define unconditionally now.
3874 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3875 (BITS_PER_EMACS_INT): New constants, replacing
3876 what used to be in config.h, but not useful in #if.
3877 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3878 define them any more.
3879 (VAL_MAX): New macro.
3880 (VALMASK): Use it.
3881 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3882 BITS_PER_EMACS_INT, in #if.
3883 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3884 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3885 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3886 * s/ms-w32.h (DATA_START):
3887 Move here from removed file m/intel386.h.
3888 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3889 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3890
261cb4bb
PE
38912012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 Assume C89 or later.
3894 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3895 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3896 (xrealloc):
3897 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3898 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3899 * textprop.c, tparam.c (NULL): Remove.
3900 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3901 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3902 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3903 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3904 * xterm.c (input_signal_count): Assume volatile works.
3905
ff23cd9f
KB
39062012-05-21 Ken Brown <kbrown@cornell.edu>
3907
3908 * xgselect.c (xg_select): Fix first argument in call to 'select'
3909 (bug#11508).
3910
1b170bc6
KB
39112012-05-20 Ken Brown <kbrown@cornell.edu>
3912
3913 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3914 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3915
b2f4d39f
KB
39162012-05-19 Ken Brown <kbrown@cornell.edu>
3917
3918 * xfns.c (x_in_use): Remove `static' qualifier.
3919 * xterm.h (x_in_use): Declare.
3920 * xgselect.c: Include xterm.h.
3921 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3922 and `display_arg' (bug#9754).
3923
003fdae2
PE
39242012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3925
9232a6d9
PE
3926 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3927
003fdae2
PE
3928 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3929 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3930
784b56e2
EZ
39312012-05-18 Eli Zaretskii <eliz@gnu.org>
3932
3933 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3934
3935 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3936 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3937
3938 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3939 reference to image_cache->refcount.
3940 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3941
a0a79cde
JL
39422012-05-17 Juri Linkov <juri@jurta.org>
3943
3944 * search.c (Fword_search_regexp, Fword_search_backward)
3945 (Fword_search_forward, Fword_search_backward_lax)
3946 (Fword_search_forward_lax): Move functions to isearch.el
3947 (bug#10145, bug#11381).
3948
b0572523
PE
39492012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3950
3951 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3952
9660f5fc
SM
39532012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3954
3955 * lread.c (init_obarray): Declare Qt and Qnil as special.
3956
4374de83
GM
39572012-05-14 Glenn Morris <rgm@gnu.org>
3958
3959 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3960 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3961
dc44c39a
PE
39622012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3963
078c97cb
PE
3964 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3965
dc44c39a
PE
3966 * unexaix.c: Port to more-recent AIX compilers.
3967 (report_error, report_error_1, make_hdr, copy_sym)
3968 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3969 Make arguments const char *, not char *, to avoid violations of C
3970 standard and to fix some AIX warnings reported by Gilles Pion.
3971
e18afed7 39722012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3973
3974 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3975 already have overlays loaded.
3976 (handle_single_display_spec): Before returning without displaying
3977 fringe bitmap, synchronize the bidi iterator with the main display
3978 iterator, by calling iterate_out_of_display_property.
3979 (iterate_out_of_display_property): Detect buffer iteration by
3980 testing that it->string is a Lisp string.
3981 (get_next_display_element): When the current object is exhausted,
3982 and there's something on it->stack, call set_iterator_to_next to
3983 proceed with what's on the stack, instead of returning zero.
3984 (set_iterator_to_next): If called at the end of a Lisp string,
3985 proceed to consider_string_end without incrementing string
3986 position. Don't increment display vector index past the end of
3987 the display vector. (Bug#11417)
c8fb9dc6
EZ
3988 (pos_visible_p): Don't report a position visible when move_it_to
3989 stopped at the last line of window, which happens to be scanned
3990 backwards by the bidi iteration. (Bug#11464)
ac268e67 3991
e18afed7 39922012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3993
3994 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3995 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3996 are on a TTY, and thus unable to display on the fringes.
3997 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3998 so we need to signal to the caller that this is a "replacing"
3999 display spec. This fixes display when the spec is invalid or we
4000 are on a TTY.
4001
e18afed7 40022012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4003
4004 * unexaix.c (make_hdr): Fix typo in prototype.
4005 This bug broke the build on AIX. Problem reported by Gilles Pion.
4006
9d0a235a
MA
40072012-05-14 Michael Albinus <michael.albinus@gmx.de>
4008
4009 * keyboard.c (kbd_buffer_get_event): Read special events also in
4010 batch mode. (Bug#11415)
4011
9e6b06ed
GM
40122012-05-12 Glenn Morris <rgm@gnu.org>
4013
4014 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4015
c1a1d7a3
EZ
40162012-05-12 Eli Zaretskii <eliz@gnu.org>
4017
4018 * lisp.mk (lisp): Add newcomment.elc.
4019
3fe7cdc8
GM
40202012-05-12 Glenn Morris <rgm@gnu.org>
4021
4022 * Makefile.in (MKDIR_P): New, set by configure.
4023 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4024
53f7d2c0
PE
40252012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 Remove unused function hourglass_started.
4028 * dispextern.h (hourglass_started):
4029 * w32fns.c (hourglass_started):
4030 * xdisp.c (hourglass_started): Remove.
4031
75aafb17
JB
40322012-05-10 Juanma Barranquero <lekktu@gmail.com>
4033
4034 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4035 Update dependencies.
4036
12959e8e
PE
40372012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4038
97107e2e
PE
4039 * xgselect.c (xg_select): Put maxfds+1 into a var.
4040 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4041
12959e8e
PE
4042 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4043
836d29b3
DA
40442012-05-10 Dave Abrahams <dave@boostpro.com>
4045
4046 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4047 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4048
5cb67954
MA
40492012-05-09 Michael Albinus <michael.albinus@gmx.de>
4050
4051 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4052 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4053 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4054 Initialize xd_registered_buses.
4055
3478ec45
PE
40562012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4057
b263a6b0
PE
4058 Untag more efficiently if USE_LSB_TAG.
4059 This is based on a proposal by YAMAMOTO Mitsuharu in
4060 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4061 For an admittedly artificial (nth 8000 longlist) benchmark on
4062 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4063 Emacs's overall text size by 1%.
4064 * lisp.h (XUNTAG): New macro.
4065 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4066 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4067 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4068 * eval.c (Fautoload):
4069 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4070 * frame.h (XFRAME): Use XUNTAG.
4071
3478ec45
PE
4072 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4073 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4074 Remove unportable assumptions about print widths of types like
4075 dbus_uint32_t.
4076 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4077 intptr_t when converting between pointer and integer, to avoid GCC
4078 warnings about wrong width.
4079
666b903b 40802012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4081
4082 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4083 stack for each reader_thread, instead of defaulting to 8MB
4084 determined by the linker. This avoids failures in creating
4085 subprocesses on Windows 7, see the discussion in this thread:
4086 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4087
b120cc17
JC
40882012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4089
4090 Fix up display of the *Minibuf-0* buffer in the mini window.
4091 * keyboard.c (read_char): Don't clear the echo area if there's no
4092 message to clear.
4093 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4094 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4095
9a4b36f8
MA
40962012-05-07 Michael Albinus <michael.albinus@gmx.de>
4097
4098 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4099 batch mode.
4100
e5f9458f
CY
41012012-05-06 Chong Yidong <cyd@gnu.org>
4102
4103 * lisp.mk (lisp): Update.
4104
eceeb5fc 41052012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4106
4107 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4108
71873e2b
SM
41092012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * data.c (PUT_ERROR): New macro.
4112 (syms_of_data): Use it. Add new error type `user-error'.
4113 * undo.c (user_error): New function.
4114 (Fprimitive_undo): Use it.
4115 * print.c (print_error_message): Adjust print style for `user-error'.
4116 * keyboard.c (user_error): New function.
4117 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4118
ab0fa4e4
PE
41192012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4120
4121 Do not limit current-time-string to years 1000..9999.
4122 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4123 (Fcurrent_time_string): Support any year that is supported by the
4124 underlying localtime representation. Don't use asctime, as it
4125 has undefined behavior for years outside the range -999..9999.
4126
7ed806a7
PE
41272012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4128
4129 Fix race conditions involving setenv, gmtime, localtime, asctime.
4130 Without this fix, interrupts could mess up code that uses these
4131 nonreentrant functions, since setting TZ invalidates existing
4132 tm_zone or tzname values, and since most of these functions return
4133 pointers to static storage.
4134 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4135 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4136 Grow the critical sections to include not just invoking
4137 localtime/gmtime, but also accessing these functions' results
4138 including their tm_zone values if any, and any related TZ setting.
4139 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4140 so that the struct tm is saved in the critical section.
4141 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4142 motivated by the fact that memory allocation needs to be outside
4143 the critical section.
4144
0c16dfed
DA
41452012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4146
4147 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4148 with RESET_INTERVAL.
4149
4150 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4151 Remove duplicated buffer name initialization.
4152
3f83ace8
JM
41532012-05-02 Jim Meyering <jim@meyering.net>
4154
4155 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4156
c7b8541e
JM
4157 * xfns.c (x_window): Use xstrdup (Bug#11375).
4158
90207a15 41592012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4160
4161 * xdisp.c (pos_visible_p): If already at a newline from the
4162 display string before the 'while' loop, don't walk back the glyphs
4163 from it3.glyph_row. Solves assertion violation when the display
4164 string begins with a newline (egg.el). (Bug#11367)
4165
b593d6a9
AH
41662012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4167
4168 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4169 Move to simple.el.
4170
4737362e
GM
41712012-05-01 Glenn Morris <rgm@gnu.org>
4172
99cf43f9
GM
4173 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4174 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4175 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4176 All were removed before 23.1.
4177
9311dcff
GM
4178 * dispnew.c: Remove HAVE_LIBNCURSES test;
4179 it is always true on relevant platforms.
4180
4d5c6349
GM
4181 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4182 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4183
4737362e
GM
4184 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4185
74dd3a6b
AS
41862012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4187
4188 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4189 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4190 Remove.
4191
13c379ee
PE
41922012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 Do not avoid creating empty evaporating overlays (Bug#9642).
4195 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4196 That is, do not delete an evaporating overlay if it becomes
4197 empty after its bounds are adjusted to fit within its buffer.
4198 This fix caused other problems, and I'm reverting it until we get
4199 to the bottom of them.
4200
a8e7d6d7 42012012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4202
4203 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4204
a8e7d6d7 42052012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4206
4207 * xdisp.c (pos_visible_p): If the window start position is beyond
4208 ZV, start the display from buffer beginning. Prevents assertion
4209 violation in init_iterator when the minibuffer window is scrolled
4210 via the scroll bar.
4211
4212 * window.c (window_scroll_pixel_based): Likewise.
4213
a8e7d6d7 42142012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4215
4216 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4217
a8e7d6d7 42182012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4219
4220 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4221 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4222
a8e7d6d7 42232012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4224
b593d6a9
AH
4225 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4226 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4227
1c6900d9
EZ
42282012-04-26 Eli Zaretskii <eliz@gnu.org>
4229
4c3fa1d9
EZ
4230 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4231 display element, check also the underlying string or buffer
4232 character. (Bug#11341)
4233
1c6900d9
EZ
4234 * w32menu.c: Include w32heap.h.
4235 (add_menu_item): If the call to AppendMenuW (via
4236 unicode_append_menu) fails, disable Unicode menus only if we are
4237 running on Windows 9X/Me.
4238
42bf8205
AS
42392012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4240
4241 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4242 (xgetint): Add missing shift for LSB tags.
4243
b1bac16e
MR
42442012-04-24 Martin Rudalics <rudalics@gmx.at>
4245
4246 * keyboard.c (read_char): Don't wipe echo area for select window
4247 events: These might get delayed via `mouse-autoselect-window'
4248 (Bug#11304).
4249
d69621cc
JB
42502012-04-24 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4253 manipulation of :loaded-from data.
4254
02fd101b
JB
42552012-04-23 Juanma Barranquero <lekktu@gmail.com>
4256
4257 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4258 now a cons (bug#11311).
4259
888bec30
PE
42602012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4261
89a438bd
PE
4262 Do not create empty overlays with the evaporate property (Bug#9642).
4263 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4264 if it becomes empty after its bounds are adjusted to fit within
4265 its buffer. Without this fix, in a nonempty buffer (let ((o
4266 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4267 yields an empty overlay that has the evaporate property, which is
4268 not supposed to happen.
4269
1068fe4d
PE
4270 Fix minor GTK3 problems found by static checking.
4271 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4272 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4273 (struct _EmacsFixedClass, emacs_fixed_get_type):
4274 Move decls here from emacsgtkfixed.h, since they needn't be public.
4275 (emacs_fixed_get_type): Now static.
4276 (emacs_fixed_class_init): Omit unused local.
4277 (emacs_fixed_child_type): Remove; unused.
4278 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4279 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4280 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4281 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4282 (EMACS_FIXED_GET_CLASS): Remove; unused.
4283 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4284
888bec30
PE
4285 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4286 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4287
de85e130
PE
42882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4289
d0baac98 4290 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4291 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4292 (__malloc_size_t, __malloc_ptrdiff_t):
4293 Remove. All uses removed, replaced by the definiens if needed,
4294 since we can assume C89 or better now.
4295 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4296 (protect_malloc_state, align, get_contiguous_space)
4297 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4298 (malloc_atfork_handler_child, malloc_enable_thread)
4299 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4300 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4301 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4302 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4303 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4304 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4305 Define using prototypes, not old style.
4306 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4307 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4308 (align): Don't assume that signed integer overflow wraps around.
4309 Omit unused local var.
4310 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4311 (_free_internal_nolock, memalign, mallochook, reallochook):
4312 Omit no-longer-needed casts.
4313 (valloc): Use getpagesize, not __getpagesize.
4314 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4315 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4316
de85e130
PE
4317 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4318
dcbf5805
MA
43192012-04-22 Michael Albinus <michael.albinus@gmx.de>
4320
4321 Move functions from C to Lisp. Make non-blocking method calls
4322 the default. Implement further D-Bus standard interfaces.
4323
4324 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4325 (QCdbus_request_name_allow_replacement)
4326 (QCdbus_request_name_replace_existing)
4327 (QCdbus_request_name_do_not_queue)
4328 (QCdbus_request_name_reply_primary_owner)
4329 (QCdbus_request_name_reply_in_queue)
4330 (QCdbus_request_name_reply_exists)
4331 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4332 (QCdbus_registered_serial, QCdbus_registered_method)
4333 (QCdbus_registered_signal): New Lisp objects.
4334 (XD_DEBUG_MESSAGE): Use sizeof.
4335 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4336 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4337 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4338 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4339 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4340 (xd_signature, xd_append_arg): Allow float for integer types.
4341 (xd_get_connection_references): New function.
b593d6a9
AH
4342 (xd_get_connection_address): Rename from xd_initialize.
4343 Return cached address.
dcbf5805
MA
4344 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4345 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4346 level.
4347 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4348 Return number of refcounts.
dcbf5805
MA
4349 (Fdbus_get_unique_name): Make stronger parameter check.
4350 (Fdbus_message_internal): New defun.
4351 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4352 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4353 (Fdbus_send_signal, Fdbus_register_service)
4354 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4355 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4356 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4357 (Vdbus_compiled_version, Vdbus_runtime_version)
4358 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4359 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4360 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4361 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4362 Adapt docstring.
dcbf5805 4363
52828e02
PE
43642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4365
da05bc4c
PE
4366 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4367 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4368 Do not assume ptrdiff_t is the same width as 'int'.
4369
52828e02
PE
4370 * alloc.c: Handle unusual debugging option combinations.
4371 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4372 since the two debugging options are incompatible.
4373 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4374 is defined.
4375 (mem_init, mem_insert, mem_insert_fixup):
4376 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4377 (NEED_MEM_INSERT): Remove; no longer needed.
4378
f01769f9
LL
43792012-04-22 Leo Liu <sdl.web@gmail.com>
4380
4381 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4382
5790543d
PE
43832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4384
4385 * sysdep.c [__FreeBSD__]: Minor cleanups.
4386 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4387 Use Emacs indenting style more consistently. Avoid some casts.
4388 Use 'double' consistently rather than mixing 'float' and 'double'.
4389
b91b7e4d
EW
43902012-04-21 Eduard Wiebe <usenet@pusto.de>
4391
b593d6a9
AH
4392 * sysdep.c (list_system_processes, system_process_attributes):
4393 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4394
6114eb15
AS
43952012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4396
4397 * lisp.mk (lisp): Update.
4398
2f38dff7
PE
43992012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4400
4401 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4402 It is never used otherwise.
4403
4ae29f89
SM
44042012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4405
4406 * print.c (print_preprocess): Only check print_depth if print-circle
4407 is nil.
4408 (print_object): Check for cycles even when print-circle is nil and
4409 print-gensym is t, but only check print_depth if print-circle is nil.
4410
f30d612a
CY
44112012-04-20 Chong Yidong <cyd@gnu.org>
4412
4413 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4414 set the status to "failed" and ensure that sentinel is run.
4415
c07a4c0b 44162012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4417
4418 * process.c (Fset_process_inherit_coding_system_flag)
4419 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4420 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4421
c07a4c0b 44222012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4423
4424 * xdisp.c (string_buffer_position_lim): Limit starting position to
4425 BEGV.
4426 (set_cursor_from_row): If called for a mode-line or header-line
4427 row, return zero immediately.
4428 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4429 farther than the first row after the header line, if any.
4430 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4431 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4432
c07a4c0b 44332012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4434
4ae29f89
SM
4435 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4436 (bug#11238).
ad3a2b41 4437
c07a4c0b 44382012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 44392012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4440
4441 configure: new option --enable-gcc-warnings (Bug#11207)
4442 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4443 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4444 (ALL_CFLAGS): Use new macros rather than old.
4445 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4446 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4447 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4448 -Wunused-result, -Wunused-variable. This should go away once
4449 the Emacs and Gnulib regex code is merged.
4450 (xmalloc, xrealloc): Now static.
4451
aba027e8
PE
44522012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4453
4454 * dired.c (Fsystem_groups): Remove unused local.
4455
e5a36063
GM
44562012-04-17 Glenn Morris <rgm@gnu.org>
4457
4458 * dired.c (Fsystem_users): Doc fix.
4459
316411f0
DA
44602012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4461
4462 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4463 (syms_of_dired): Add them.
4464
9426aba4
PE
44652012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4466
b62a57be
PE
4467 Fix minor alloc.c problems found by static checking.
4468 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4469 New extern decls, to avoid calling undeclared functions.
4470 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4471 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4472 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4473 (NEED_MEM_INSERT): New macro.
4474 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4475 Remove one incorrect comment and fix another.
b62a57be 4476
3539f31f
PE
4477 Fix minor ralloc.c problems found by static checking.
4478 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4479 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4480 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4481 (r_alloc_sbrk): Now static.
4482
a041960a
PE
4483 Improve ralloc.c interface checking.
4484 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4485 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4486 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4487 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4488 [REL_ALLOC]: ... to here, to check interface.
4489 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4490 Remove decls. This fixes an "It stinks!".
4491
9426aba4
PE
4492 * alloc.c (which_symbols): Fix alignment issue / type clash.
4493
d55c12ed
AS
44942012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4495
4496 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4497 (struct Lisp_Misc_Any): Likewise.
4498 (struct Lisp_Free): Likewise.
4499 * alloc.c (union aligned_Lisp_Symbol): Define.
4500 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4501 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4502 (union aligned_Lisp_Misc): Define.
4503 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4504 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4505 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4506
b948ce8b
PE
45072012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4510 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4511 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4512 * s/netbsd.h, s/sol2-6.h:
4513 Remove definition of GC_MARK_STACK, since the default now works.
4514 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4515 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4516 no longer the default.
4517 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4518
35dc09a1 45192012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4520
35dc09a1
GM
4521 * lread.c (lisp_file_lexically_bound_p):
4522 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4523
35dc09a1
GM
45242012-04-14 Eli Zaretskii <eliz@gnu.org>
4525
4526 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4527 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4528
45292012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4530
4531 * nsterm.m (constrainFrameRect): Always constrain when there is only
4532 one screen (Bug#10962).
4533
bcd86815
KB
45342012-04-13 Ken Brown <kbrown@cornell.edu>
4535
4536 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4537
c25df26e
RT
45382012-04-13 Reuben Thomas <rrt@sc3d.org>
4539
4540 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4541
0fc59f1e
DC
45422012-04-11 Daniel Colascione <dancol@dancol.org>
4543
4544 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4545 against is gone. It's better to use vfork now so that when Cygwin
4546 gains a new, working vfork, we use it automatically (bug#10398).
4547
de8c03dc
SM
45482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4549
4550 * window.c (save_window_save): Obey window-point-insertion-type.
4551
2f097256
GM
45522012-04-11 Glenn Morris <rgm@gnu.org>
4553
4554 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4555
453b951e
SM
45562012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4557
4558 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4559
75f1671a 45602012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4561
4562 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4563 (force_quit_count): New var.
4564 (handle_interrupt): Use it.
4565
2a8ce227
JB
45662012-04-10 Juanma Barranquero <lekktu@gmail.com>
4567
4568 * w32.c (w32_delayed_load): Record the full path of the library
4569 being loaded (bug#10424).
4570
935396c0
GM
45712012-04-09 Glenn Morris <rgm@gnu.org>
4572
05920a43
GM
4573 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4574 not just in the obarray, before snarfing them. (Bug#11036)
4575
935396c0
GM
4576 * Makefile.in ($(leimdir)/leim-list.el):
4577 Pass EMACS rather than BUILT_EMACS.
4578
a18ecafa
TZ
45792012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4580
4581 * process.c (make_process):
4582 * process.h: Add integer `gnutls_handshakes_tried' member to
4583 process struct.
4584
6bbef4e5
JC
4585 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4586 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4587
4588 * gnutls.c (gnutls_log_function2i): Convenience log function.
4589 (emacs_gnutls_read): Use new log functions,
4590 `gnutls_handshakes_tried' process member, and
4591 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4592 attempts per process (connection).
4593
b4d3bc10
CY
45942012-04-09 Chong Yidong <cyd@gnu.org>
4595
4596 * eval.c (Fuser_variable_p, user_variable_p_eh)
4597 (lisp_indirect_variable): Functions deleted.
4598 (Fdefvar): Caller changed.
4599
4600 * callint.c (Finteractive, Fcall_interactively):
4601 * minibuf.c (Fread_variable): Callers changed.
4602
70f4d973
EZ
46032012-04-09 Eli Zaretskii <eliz@gnu.org>
4604
4605 * xdisp.c (set_cursor_from_row): If the display string appears in
4606 the buffer at position that is closer to point than the position
4607 after the display string, display the cursor on the first glyph of
4608 the display string. Fixes cursor display when a 'display' text
4609 property immediately follows invisible text. (Bug#11094)
4610
cb3c2e3e
PE
46112012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4612
4613 composite.c: use 'double' consistently
4614 * composite.c (get_composition_id): Use 'double' consistently
4615 instead of converting 'float' to 'double' and vice versa; this is
4616 easier to understand and avoids a GCC warning.
4617
fd06db5d
GM
46182012-04-09 Glenn Morris <rgm@gnu.org>
4619
50fe702a
GM
4620 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4621 preparation for dumping it with emacs. (Bug#4789)
4622 (leimdir): New variable.
4623 ($(leimdir)/leim-list.el): New rule.
4624 (emacs$(EXEEXT)): Depend on leim-list.el.
4625
fd06db5d
GM
4626 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4627 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4628 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4629
55c131ee
AS
46302012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4631
4632 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4633 proper alignment.
4634
9209588f
JB
46352012-04-07 Juanma Barranquero <lekktu@gmail.com>
4636
4637 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4638 Remove unused local variable.
4639
e3fb2efb
PE
46402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4641
4642 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4643 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4644 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4645 objects, as mark_maybe_pointer will catch them otherwise.
4646 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4647 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4648
b5385551
PE
46492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 Fix typo that broke non-Windows builds.
4652 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4653
9078ead6
EZ
46542012-04-07 Eli Zaretskii <eliz@gnu.org>
4655
4656 Support building on MS-Windows with libxml2.
4657
4658 * makefile.w32-in (OBJ2): Add xml.$(O).
4659 (GLOBAL_SOURCES): Add xml.c.
4660 ($(BLD)/xml.$(O)): New dependency list.
4661
4662 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4663 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4664 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4665 [!WINDOWSNT]: New macros.
4666 (init_libxml2_functions, libxml2_loaded_p): New functions.
4667 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4668 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4669 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4670 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4671 linked in).
6bbef4e5
JC
4672 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4673 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4674 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4675
4676 * emacs.c: Don't include libxml/parser.h.
4677 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4678 xmlCleanupParser directly.
4679
4680 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4681
3811fdf3
EZ
46822012-04-07 Eli Zaretskii <eliz@gnu.org>
4683
4684 * indent.c (Fvertical_motion): If there is a display string at
4685 point, use it.vpos to compute how many lines to backtrack after
4686 move_it_to point. (Bug#11133)
4687
2f8e16b2
EZ
46882012-04-06 Eli Zaretskii <eliz@gnu.org>
4689
4690 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4691 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4692 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4693 macros related to unification of CJK characters. For the details,
4694 see the discussion following the message here:
4695 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4696
3d439cd1
CY
46972012-04-04 Chong Yidong <cyd@gnu.org>
4698
4699 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4700
8bc53d00
EZ
47012012-04-01 Eli Zaretskii <eliz@gnu.org>
4702
4703 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4704 instead of alloca. (Bug#11138)
4705
3b0512a3
AS
47062012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4707
4708 * w32menu.c (is_simple_dialog): Properly check lisp types.
4709 (Bug#11141)
4710
8427ddd2
EZ
47112012-03-31 Eli Zaretskii <eliz@gnu.org>
4712
979022ef
EZ
4713 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4714 position we get to after a call to move_it_to fails the
4715 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4716 only if we wind up in a string from display property. (Bug#11063)
4717
a6b1c7cc
EZ
4718 * window.c (Fdelete_other_windows_internal): Invalidate the row
4719 and column information about mouse highlight, so that redisplay
4720 restores it after reallocating the glyph matrices. (Bug#7464)
4721
8427ddd2
EZ
4722 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4723 string comes from a `display' text property, use the buffer
4724 position of that property as if we actually saw that position in
4725 the row's glyphs.
697ba24b
EZ
4726 (move_it_by_lines): Remove the assertion that
4727 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4728 violated when there's a before-string at the beginning of a line.
4729 (Bug#11063)
8427ddd2 4730
65a0a738
EZ
47312012-03-30 Eli Zaretskii <eliz@gnu.org>
4732
4733 * xdisp.c (append_space_for_newline): If the default face was
4734 remapped, use the remapped face for the appended newline.
4735 (extend_face_to_end_of_line): Use the remapped default face for
4736 extending the face to the end of the line.
4737 (display_line): Call extend_face_to_end_of_line when the default
4738 face was remapped. (Bug#11068)
4739
581355cc
EZ
47402012-03-29 Eli Zaretskii <eliz@gnu.org>
4741
4742 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4743
e8fc049f
SM
47442012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4745
4746 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4747
4fb9a543
GM
47482012-03-27 Glenn Morris <rgm@gnu.org>
4749
4750 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4751 Doc fixes.
4752
679910f1
KH
47532012-03-26 Kenichi Handa <handa@m17n.org>
4754
4755 * dispextern.h (struct glyph): Fix previous change. Change the
4756 bit length of glyphless.ch to 25 (Bug#11082).
4757
90d49b7f
CY
47582012-03-26 Chong Yidong <cyd@gnu.org>
4759
4760 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4761 (command_loop_1): Use it; inhibit selection update for
4762 handle-select-window too (Bug#8996).
4763
f514f6f0
FP
47642012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4765
e8fc049f 4766 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4767
bf43fa51
KH
47682012-03-25 Kenichi Handa <handa@m17n.org>
4769
4770 * dispextern.h (struct glyph): Change the bit length of
4771 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4772
8a0c01dd
EZ
47732012-03-24 Eli Zaretskii <eliz@gnu.org>
4774
4775 * s/ms-w32.h (tzname): Include time.h before redirecting to
4776 _tzname. Fixes the MSVC build. (Bug#9960)
4777
7d1c3a76
AS
47782012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4779
8ed79523
AS
4780 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4781 characters.
4782
7d1c3a76
AS
4783 * xterm.c (XTread_socket): Only modify handling_signal if
4784 !SYNC_INPUT. (Bug#11080)
4785
e99a9b8b
EZ
47862012-03-23 Eli Zaretskii <eliz@gnu.org>
4787
4788 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4789 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4790 when fetching a multibyte character consumes more bytes than
4791 CHAR_BYTES returns, due to unification of CJK characters in
4792 string_char. (Bug#11073)
4793
5063c0e1
TN
47942012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4795
4796 * process.c (wait_reading_process_output): Handle pty disconnect
4797 by refraining from sending oneself a SIGCHLD (bug#10933).
4798
9f851fbd
CY
47992012-03-22 Chong Yidong <cyd@gnu.org>
4800
4801 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4802
5063c0e1 4803 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4804 Mark string as coming from a prefix property.
4805 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4806 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4807
fb5b8aca
CY
48082012-03-21 Chong Yidong <cyd@gnu.org>
4809
4810 * xfaces.c (Vface_remapping_alist): Doc fix.
4811
62356a1b
EZ
48122012-03-20 Eli Zaretskii <eliz@gnu.org>
4813
4814 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4815 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4816 Doc fixes.
62356a1b 4817
025de85b
CY
48182012-03-20 Chong Yidong <cyd@gnu.org>
4819
4820 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4821 to reflect default non-nil value of redisplay-dont-pause.
4822
4827f94e
KH
48232012-03-19 Kenichi Handa <handa@m17n.org>
4824
4825 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4826 it fit in a valid range (Bug#11003).
4827
e50a24a2
EZ
48282012-03-18 Eli Zaretskii <eliz@gnu.org>
4829
4830 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4831 that is not from display property, accept the row as a "cursor
4832 row" if one of the string's character has a non-nil `cursor'
4833 property. Fixes cursor positioning when there are newlines in
4834 overlay strings, e.g. in icomplete.el. (Bug#11035)
4835
9af5ed87
PE
48362012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4839
d1f55f16
CY
48402012-03-12 Chong Yidong <cyd@gnu.org>
4841
4842 * eval.c (inhibit_lisp_code): Rename from
4843 inhibit_window_configuration_change_hook; move from window.c.
4844
4845 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4846 * window.c (run_window_configuration_change_hook)
4847 (syms_of_window): Callers changed.
4848
66c5eebd
CY
48492012-03-11 Chong Yidong <cyd@gnu.org>
4850
413df973
CY
4851 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4852
66c5eebd
CY
4853 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4854
1de11f56
CY
48552012-03-10 Chong Yidong <cyd@gnu.org>
4856
4857 * frame.c (other_visible_frames): Don't assume the selected frame
4858 is visible (Bug#10955).
4859
cae07000
SM
48602012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4861
4862 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4863
89c94350
JD
48642012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4865
4866 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4867 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4868 zero (Bug#10954).
4869
999dd333
GM
48702012-03-03 Glenn Morris <rgm@gnu.org>
4871
01a6dcc8 4872 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4873
de0100f2
EZ
48742012-03-02 Eli Zaretskii <eliz@gnu.org>
4875
4876 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4877 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4878 (redisplay_window, next_element_from_string): Fix typos in
4879 comments.
3e441275
EZ
4880 (redisplay_window): Pass to move_it_vertically the margin in
4881 pixels, not in screen lines.
de0100f2 4882
96a72ee9
GM
48832012-03-02 Glenn Morris <rgm@gnu.org>
4884
4885 * buffer.c (buffer-list-update-hook): Doc fix.
4886
312508d7
EZ
48872012-02-29 Eli Zaretskii <eliz@gnu.org>
4888
4889 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4890 push_it before setting up the iterator for the first overlay
4891 string, even if we have an empty string loaded.
4892 (next_overlay_string): If there's an empty string on the iterator
4893 stack, pop the stack. (Bug#10903)
4894
27f3c637
PE
48952012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4896
4897 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4898 Suggested by Stefan Monnier in
4899 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4900 * alloc.c (widen_to_Lisp_Object): New static function.
4901 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4902 and widening them to Lisp_Objects. This would work even if
4903 USE_LSB_TAG is defined and wide integers are used, which might
4904 happen in a future version of Emacs.
4905
3c9dfce6
CY
49062012-02-25 Chong Yidong <cyd@gnu.org>
4907
fa74b241
CY
4908 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4909 Doc fix.
4910
3c9dfce6
CY
4911 * xselect.c (Fx_selection_exists_p): Doc fix.
4912 (x_clipboard_manager_save_all): Print an informative message
4913 before saving to clipboard manager.
4914
9486df08
CY
49152012-02-24 Chong Yidong <cyd@gnu.org>
4916
4917 * keyboard.c (process_special_events): Handle all X selection
4918 requests in kbd_buffer, not just the next one (Bug#8869).
4919
f01d3321
CY
49202012-02-23 Chong Yidong <cyd@gnu.org>
4921
4922 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4923 call when setting menu-bar-lines and tool-bar-lines parameters.
4924 (unwind_create_frame_1): New helper function.
4925
4926 * window.c (inhibit_window_configuration_change_hook): New var.
4927 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4928 (syms_of_window): Initialize it.
f01d3321 4929
86b847b6
CY
49302012-02-22 Chong Yidong <cyd@gnu.org>
4931
4932 * xterm.c (x_draw_image_relief): Add missing type check for
4933 Vtool_bar_button_margin (Bug#10743).
4934
a59225b1
CY
49352012-02-21 Chong Yidong <cyd@gnu.org>
4936
4937 * fileio.c (Vfile_name_handler_alist): Doc fix.
4938
4939 * buffer.c (Fget_file_buffer): Protect against invalid file
4940 handler return value.
4941
310f5bd4
PE
49422012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4943
cb3a28cc
PE
4944 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4945 when computing $valmask.
4946
310f5bd4
PE
4947 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4948 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4949 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4950 It's useless in that case, and it can cause problems on hosts
4951 that allocate halves of EMACS_INT values separately.
4952 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4953 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4954 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4955 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4956 it avoids undefined behavior on hosts where shifting right by more
4957 than the word width has undefined behavior.
4958
2375c96a
CY
49592012-02-19 Chong Yidong <cyd@gnu.org>
4960
4961 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4962 (Funhandled_file_name_directory, Ffile_name_as_directory)
4963 (Fdirectory_file_name, Fexpand_file_name)
4964 (Fsubstitute_in_file_name): Protect against invalid file handler
4965 return values (Bug#10845).
4966
3eb49e71
EZ
49672012-02-18 Eli Zaretskii <eliz@gnu.org>
4968
4969 * .gdbinit (pitx): Fix incorrect references to fields of the
4970 iterator stack.
4971
7b926f3f
CY
49722012-02-17 Chong Yidong <cyd@gnu.org>
4973
4974 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4975
11273115
PE
49762012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4977
4978 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4979 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4980
c3a70e2b
CY
49812012-02-15 Chong Yidong <cyd@gnu.org>
4982
4983 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4984 marked as special. Also, starting docstrings with * is obsolete.
4985
0ca43699
AS
49862012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4987
4988 * gnutls.c (emacs_gnutls_write): Fix last change.
4989
2e8f3c56
LI
49902012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4991
4992 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4993 send_process.
4994
af70074f
SM
49952012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4996
4997 * keymap.c (Fsingle_key_description): Handle char ranges.
4998
95986d52
CY
49992012-02-12 Chong Yidong <cyd@gnu.org>
5000
afd83bd1
CY
5001 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5002 as that creates a dangerous corner case.
5003
95986d52
CY
5004 * window.c (Fdelete_window_internal): Invalidate the mouse
5005 highlight (Bug#9904).
5006
bd7da63e
GM
50072012-02-12 Glenn Morris <rgm@gnu.org>
5008
5009 * xselect.c (Fx_own_selection_internal)
5010 (Fx_get_selection_internal, Fx_disown_selection_internal)
5011 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5012 * nsselect.m (Fx_own_selection_internal)
5013 (Fx_disown_selection_internal, Fx_selection_exists_p)
5014 (Fx_selection_owner_p, Fx_get_selection_internal):
5015 Sync docs and argument specs with the xselect.c versions.
5016
77abcbc2
LI
50172012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5018
5019 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5020
90b671e2
EZ
50212012-02-11 Eli Zaretskii <eliz@gnu.org>
5022
1c0ca0b7
EZ
5023 * w32select.c (Fx_selection_exists_p): Sync doc string and
5024 argument list with xselect.c. (Bug#10783)
5025
5026 * w16select.c (Fx_selection_exists_p): Sync doc string and
5027 argument list with xselect.c. (Bug#10783)
90b671e2 5028
49241268
GM
50292012-02-10 Glenn Morris <rgm@gnu.org>
5030
5031 * fns.c (Fsecure_hash): Doc fix.
5032
f998bbe7 50332012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5034
5035 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5036
0992bd9c
CY
50372012-02-07 Chong Yidong <cyd@gnu.org>
5038
5039 * buffer.c (Fbuffer_local_variables)
5040 (buffer_lisp_local_variables): Handle unbound vars correctly;
5041 don't let Qunbound leak into Lisp.
5042
af008560
GM
50432012-02-07 Glenn Morris <rgm@gnu.org>
5044
dd605cc4
GM
5045 * image.c (Fimagemagick_types): Doc fix.
5046
af008560
GM
5047 * image.c (imagemagick-render-type): Change it from a lisp object
5048 to an integer. Move the doc here from the lisp manual.
5049 Treat all values not equal to 0 the same.
5050
1449fa1d
CY
50512012-02-06 Chong Yidong <cyd@gnu.org>
5052
5053 * doc.c (store_function_docstring): Avoid applying docstring of
5054 alias to base function (Bug#2603).
5055
3723ec07
AS
50562012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5057
5058 * .gdbinit (pp1, pv1): Remove redundant defines.
5059 (pr): Use pp.
5060
79c1cc1e
CY
50612012-02-04 Chong Yidong <cyd@gnu.org>
5062
5063 * nsterm.m: Declare a global (Bug#10694).
5064
d7f29f8e
EZ
50652012-02-04 Eli Zaretskii <eliz@gnu.org>
5066
cae07000
SM
5067 * w32.c (get_emacs_configuration_options):
5068 Include --enable-checking, if specified, in the return value.
d7f29f8e 5069
3b95a6f9
MR
50702012-02-04 Martin Rudalics <rudalics@gmx.at>
5071
5072 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5073 after rounding frame sizes. (Bug#9723)
5074
d6fa96a6
EZ
50752012-02-04 Eli Zaretskii <eliz@gnu.org>
5076
5077 * keyboard.c (adjust_point_for_property): Don't position point
5078 before BEGV. (Bug#10696)
5079
df0b2940
PE
50802012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5081
5082 Handle overflow when computing char display width (Bug#9496).
5083 * character.c (char_width): Return EMACS_INT, not int.
5084 (char_width, c_string_width): Check for overflow when
5085 computing the width; this is possible now that individual
5086 characters can have unbounded width. Problem introduced
5087 by merge from Emacs 23 on 2012-01-19.
5088
6bee44d6
MA
50892012-02-02 Michael Albinus <michael.albinus@gmx.de>
5090
5091 * dbusbind.c (Fdbus_register_method): Mention the return value
5092 :ignore in the docstring.
5093
44f92739
GM
50942012-02-02 Glenn Morris <rgm@gnu.org>
5095
1b9f60cc
GM
5096 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5097
44f92739
GM
5098 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5099 Unconditionally set to t. (Bug#10673)
5100 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5101 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5102 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5103
c5d3843c
KH
51042012-02-02 Kenichi Handa <handa@m17n.org>
5105
5106 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5107 0, do not call append_composite_glyph.
5108
159462d4 51092012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5110
5111 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5112 NULL (Bug#6988).
5113 (x_produce_glyphs): If the component of a composition is a null
5114 string, set it->pixel_width to 1 to avoid zero-width glyph.
5115
78cef877
EZ
51162012-02-01 Eli Zaretskii <eliz@gnu.org>
5117
5118 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5119 first 2 arguments are identical. This makes inserting large
5120 output from a subprocess an order of magnitude faster on
5121 MS-Windows, where all sbrk'ed memory is always contiguous.
5122
97897668
GM
51232012-01-31 Glenn Morris <rgm@gnu.org>
5124
5125 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5126 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5127 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5128
31fd3586
GM
51292012-01-29 Glenn Morris <rgm@gnu.org>
5130
5131 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5132
0e24a8b2
CY
51332012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5134
5135 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5136
cc0adcb0
CY
51372012-01-28 Chong Yidong <cyd@gnu.org>
5138
5139 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5140
acc28cb9
CY
51412012-01-26 Chong Yidong <cyd@gnu.org>
5142
9c69cfb7
CY
5143 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5144
acc28cb9
CY
5145 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5146 repeat counts (Bug#10507).
5147
48da7392
GM
51482012-01-26 Glenn Morris <rgm@gnu.org>
5149
5150 * lread.c (syms_of_lread): Doc fix.
5151
14af5f7f
CY
51522012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5153
5154 * coding.c (encode_designation_at_bol): Change return value to
5155 EMACS_INT.
5156
0b21c100
CY
51572012-01-25 Chong Yidong <cyd@gnu.org>
5158
5159 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5160
3c2907f7
CY
51612012-01-21 Chong Yidong <cyd@gnu.org>
5162
5163 * floatfns.c (Fcopysign): Make the second argument non-optional,
5164 since nil is not allowed anyway.
5165
959ad23f
AS
51662012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5167
5168 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5169 (send_process): Likewise.
5170
34a02f46
MR
51712012-01-19 Martin Rudalics <rudalics@gmx.at>
5172
5173 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5174 (Vwindow_persistent_parameters): Do not use Qstate.
5175 Rewrite doc-strings.
34a02f46 5176
1259009a 51772012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5178
5179 * character.c (char_width): New function.
70d4fdf6
GM
5180 (Fchar_width, c_string_width, lisp_string_width):
5181 Use char_width (Bug#9496).
25ed9e61 5182
6a6ee00d
MR
51832012-01-16 Martin Rudalics <rudalics@gmx.at>
5184
5185 * window.c (Vwindow_persistent_parameters): New variable.
5186 (Fset_window_configuration, save_window_save): Handle persistent
5187 window parameters.
5188
c85efaf7
EZ
51892012-01-14 Eli Zaretskii <eliz@gnu.org>
5190
5191 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5192 thrashing the stack of the thread. (Bug#9087)
5193
5944709e
PE
51942012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5195
5196 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5197
e71f5d99
EZ
51982012-01-11 Eli Zaretskii <eliz@gnu.org>
5199
5200 * xdisp.c (rows_from_pos_range): Handle the case where the
5201 highlight ends on a newline. (Bug#10464)
5202 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5203 he end column for display of highlight that ends on a newline
5204 before a R2L line.
5205
ce316182
GM
52062012-01-11 Glenn Morris <rgm@gnu.org>
5207
5208 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5209 from load-path also when installation-directory is nil. (Bug#10208)
5210
5b43da69
GM
52112012-01-10 Glenn Morris <rgm@gnu.org>
5212
74cc8ff9
GM
5213 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5214
7d8d6e4e
GM
5215 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5216 Update template values to be closer to their typical values these days.
5b43da69 5217
a0db8d43
EZ
52182012-01-09 Eli Zaretskii <eliz@gnu.org>
5219
5220 * xdisp.c (rows_from_pos_range): Accept additional argument
5221 DISP_STRING, and accept any glyph in a row whose object is that
5222 string as eligible for mouse highlight. Fixes mouse highlight of
5223 display strings from overlays. (Bug#10464)
5224
9a0115ab 52252012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5226
b9110d6a 5227 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5228 * fileio.c (auto_saving_dir_umask): New static var.
5229 (Fmake_directory_internal): Use it.
5230 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5231 creating the directory. The old code temporarily assigns
5232 too-generous permissions to the directory.
5233 (do_auto_save_eh): Clear it.
b9110d6a 5234 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5235 that the var is always cleared.
5236
6c1bd3f3
EZ
52372012-01-07 Eli Zaretskii <eliz@gnu.org>
5238
5239 * search.c (scan_buffer): Pass character positions to
5240 know_region_cache, not byte positions. (Bug#6540)
5241
069d2b50
L
52422012-01-07 LynX <_LynX@bk.ru> (tiny change)
5243
5244 * w32.c (sys_rename): Report EXDEV when rename of a directory
5245 fails because the target is on another logical disk. (Bug#10284)
5246
75bf0d33
DB
52472012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5248
5249 * xterm.c (x_embed_request_focus): New function.
5250
5251 * xterm.h: Add prototype.
5252
5253 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5254
1c6e5a32
GM
52552012-01-05 Glenn Morris <rgm@gnu.org>
5256
5257 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5258
651e947e
EZ
52592012-01-01 Eli Zaretskii <eliz@gnu.org>
5260
5261 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5262 Load gnutls_transport_set_lowat only if GnuTLS version is below
5263 2.11.1.
5264 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5265 GnuTLS versions below 2.11.1.
5266
3778cdd8
AL
52672011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5268
5269 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5270 to the doc string advising against its use for altering the way
5271 windows are scrolled.
5272
0e5317f7
KH
52732011-12-28 Kenichi Handa <handa@m17n.org>
5274
5275 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5276 coding-system ASCII compatible only when it does not produce BOM
5277 on encoding (Bug#10383).
5278
93d5ca1f
JD
52792011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5280
5281 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5282 can scroll.
5283 (create_and_show_popup_menu): Always use menu_position_func for
5284 Gtk3 (Bug#10361).
5285
ca22b785
AS
52862011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5287
5288 * callint.c (Fcall_interactively): Don't truncate prompt string.
5289
d048e1e6
EZ
52902011-12-23 Eli Zaretskii <eliz@gnu.org>
5291
5292 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5293 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5294 resumed from there (after widening). (Bug#10360)
d048e1e6 5295
5ccaba1f
JD
52962011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5297
5298 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5299
204ee57f
JD
53002011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5301
b81d40f0
JB
5302 * nsterm.m (x_free_frame_resources):
5303 Release f->output_data.ns->miniimage.
204ee57f
JD
5304 (ns_index_color): Fix indentation. Do not retain
5305 color_table->colors[i].
5306
5307 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5308 before returning.
5309
5310 * nsfns.m (x_set_background_color): Assign return value from
5311 ns_index_color to face-background instead of NSColor*.
5312 (ns_implicitly_set_icon_type): Fix indentation.
5313 Change assignment in for loop to comparison.
5314
5315 * emacs.c (ns_pool): New variable.
5316 (main): Assign ns_pool.
5317 (Fkill_emacs): Call ns_release_autorelease_pool.
5318
5319 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5320 autorelease fdesc, release fdAttrs and tdict.
5321 (ns_get_covering_families): Release charset.
5322 (ns_findfonts): Release NSFontDescriptor created with new.
5323 (ns_uni_to_glyphs): Fix indentation.
5324 (setString): Release attrStr before assigning new value.
5325
c803b2b7
JD
53262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5327
678f4426
JD
5328 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5329 and NS_IMPL_COCOA.
5330 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5331 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5332
cd394be1 53332011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5334
5fecd5fc
JD
5335 * nsterm.m (ns_term_init): Subscribe for notifications
5336 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5337 to method trackingNotification in EmacsMenu.
5338
5339 * nsmenu.m (trackingMenu): New variable.
3771cb17 5340 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5341 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5342 from Aquamacs (Bug#7030).
678f4426
JD
5343
53442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5345
c803b2b7
JD
5346 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5347 (symbol_to_nsstring): Fix indentation.
5348 (ns_symbol_to_pb): New function.
cae07000
SM
5349 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5350 (Fns_rotate_cut_buffers_internal): Remove.
5351 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5352 Fns_store_cut_buffer_internal.
5353 (ns_get_foreign_selection, Fx_own_selection_internal)
5354 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5355 (Fns_get_selection_internal, Fns_store_selection_internal):
5356 Use ns_symbol_to_pb and check if return value is nil.
5357 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5358 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5359 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5360 renamed to Sns_store_selection_internal.
5361 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5362 and remove this function.
5363 (ns_handle_selection_clear): Remove, never used.
5364 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5365 here.
5366
e1b01a3a
KB
53672011-12-17 Ken Brown <kbrown@cornell.edu>
5368
5369 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5370 GID is unknown (Bug#10257).
5371
2adb6e85
PE
53722011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5375 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5376 which caused a build failure on GNU/Linux IA-64. This problem was
5377 introduced by my 2011-10-07 patch.
5378
d1d7b339
JL
53792011-12-15 Juri Linkov <juri@jurta.org>
5380
5381 * image.c (imagemagick_error): New function. (Bug#10112)
5382 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5383 Use `imagemagick_error' where ImageMagick functions return
5384 `MagickFalse'.
5385 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5386 proper order.
5387
100d5755
KH
53882011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5389
5390 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5391 fill background (Bug#8992).
5392
454592a6
MR
53932011-12-13 Martin Rudalics <rudalics@gmx.at>
5394
5395 * window.c (Vwindow_combination_resize)
5396 (Vwindow_combination_limit): Use t instead of non-nil in
5397 doc-strings.
61d4b438
MR
5398 (Vrecenter_redisplay): Add first sentence of doc-string on
5399 separate line.
53524d93 5400 (Frecenter): Fix doc-string typo.
454592a6 5401
3633e3aa
KH
54022011-12-11 Kenichi Handa <handa@m17n.org>
5403
5404 * coding.c (Funencodable_char_position): Pay attention to the
5405 buffer text relocation (Bug#9389).
5406
7b9d523a 54072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5408
7b9d523a
JD
5409 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5410 gtk_init (Bug#10100).
5411
b73189c6
EZ
54122011-12-10 Eli Zaretskii <eliz@gnu.org>
5413
5414 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5415 IT->string is nil. (Bug#10263)
5416
f7dfe5d6
JD
54172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5418
83faebb4
JD
5419 * nsterm.h (x_free_frame_resources): Declare.
5420
f7dfe5d6
JD
5421 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5422 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5423
5424 * nsterm.h (ns_get_defaults_value): Declare.
5425
5426 * nsterm.m (ns_default): Call ns_get_defaults_value.
5427
7cd4e72c
EZ
54282011-12-09 Eli Zaretskii <eliz@gnu.org>
5429
5430 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5431 (Bug#10170)
5432
b34d7317
YM
54332011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5434
5435 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5436 that where the value of an _OBJC_* symbol points to is in the .bss
5437 section (Bug#10240).
5438
76470ad1
KH
54392011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5440
5441 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5442 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5443
745fff94
KH
54442011-12-08 Kenichi Handa <handa@m17n.org>
5445
5446 * ftfont.c (get_adstyle_property): Fix previous change
5447 (Bug#10233).
5448
6e44397c
JB
54492011-12-07 Juanma Barranquero <lekktu@gmail.com>
5450
5451 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5452 dirs from the default value of EMACSLOADPATH (bug#10208).
5453
7efa6272
GM
54542011-12-07 Glenn Morris <rgm@gnu.org>
5455
5456 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5457 installation and source directories as well. (Bug#10208)
5458
f6fc4d87
CY
54592011-12-06 Chong Yidong <cyd@gnu.org>
5460
5461 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5462
2bf26180
GM
54632011-12-06 Glenn Morris <rgm@gnu.org>
5464
5465 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5466 as an error, not just -1. (Bug#10217)
5467
3a6ad4f0
CY
54682011-12-05 Chong Yidong <cyd@gnu.org>
5469
5470 * keyboard.c (process_special_events): New function.
5471 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5472
75a3b399
PE
54732011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 * coding.c (encode_designation_at_bol): Don't use uninitialized
5476 local variable (Bug#9318).
5477
c3c9e25e
KH
54782011-12-05 Kenichi Handa <handa@m17n.org>
5479
5480 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5481 return Qnil (Bug#8046, Bug#10193).
5482
5eb05ea3
KH
54832011-12-05 Kenichi Handa <handa@m17n.org>
5484
5485 * coding.c (encode_designation_at_bol): New args charbuf_end and
5486 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5487 (coding_set_source): Return how many bytes coding->source was
5488 relocated.
5489 (coding_set_destination): Return how many bytes
5490 coding->destination was relocated.
5491 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5492 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5493
54942011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5495
5496 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5497 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5498 macro (Bug#9318).
5499
55002011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5501
5502 The following changes are to fix Bug#9318.
5503
a79703f5 5504 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5505 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5506 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5507 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5508
7dbda6df
JB
55092011-12-05 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * lisp.h (process_quit_flag): Fix external declaration.
5512
6d5eb5b0
SM
55132011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5514
5515 Don't macro-inline non-performance-critical code.
5516 * eval.c (process_quit_flag): New function.
5517 * lisp.h (QUIT): Use it.
5518
a0c3fad0
JD
55192011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5520
5521 * nsfns.m (get_geometry_from_preferences): New function.
5522 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5523
6c07aac2
AS
55242011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5525
5526 * emacs.c (Qkill_emacs): Define.
5527 (syms_of_emacs): Initialize it.
5528 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5529 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5530 (quit_throw_to_read_char): Add parameter `from_signal'.
5531 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5532 * lisp.h (QUIT): Call Fkill_emacs if requested.
5533
c052ead4
JD
55342011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5535
5536 * widget.c (update_wm_hints): Return if wmshell is null.
5537 (widget_update_wm_size_hints): New function.
5538
5539 * widget.h (widget_update_wm_size_hints): Declare.
5540
5541 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5542 widget_update_wm_size_hints (Bug#10104).
5543
9e49252b
EZ
55442011-12-03 Eli Zaretskii <eliz@gnu.org>
5545
5546 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5547 before a newline, prepare the bidi iterator for consuming the
5548 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5549 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5550
02b16839
JL
55512011-12-02 Juri Linkov <juri@jurta.org>
5552
5553 * search.c (Fword_search_regexp): New Lisp function created from
5554 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5555 (Fword_search_backward, Fword_search_forward)
5556 (Fword_search_backward_lax, Fword_search_forward_lax):
5557 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5558 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5559
0068070e
SM
55602011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5561
5562 * fileio.c (Finsert_file_contents): Move after-change-function call
5563 to before the "handled:" label, since all "goto handled" appear in
5564 cases where the *-change-functions have already been properly called
5565 (bug#10117).
5566
3360a3fc
AS
55672011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5568
5569 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5570 waiting for input. (Bug#10169)
5571
73d6c093
EZ
55722011-11-30 Eli Zaretskii <eliz@gnu.org>
5573
5574 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5575 verifies glyph row's hash code--we have just reallocated the
5576 glyphs, so their contents can be complete garbage. (Bug#10164)
5577
febe6bea
JB
55782011-11-30 Juanma Barranquero <lekktu@gmail.com>
5579
5580 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5581
801a4313
EZ
55822011-11-30 Eli Zaretskii <eliz@gnu.org>
5583
5584 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5585 attributes are tested _before_ calling verify_row_hash, to protect
5586 against GCC re-ordering of the tests. (Bug#10164)
5587
2b56b87e
JD
55882011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5589
5590 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5591
5592 * xterm.c (handle_one_xevent): Only set async_visible and friends
5593 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5594 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5595 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5596
dbf31225
PE
55972011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5598
5599 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5600 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5601 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5602 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5603 All uses changed to use GCPRO1 etc.
5604 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5605 Revert to old implementation (i.e., before 2011-03-11).
5606
1305621b
YM
56072011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5608
5609 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5610 of scroll runs so as to avoid assigning disabled bogus rows and
5611 unnecessary graphics copy operations.
5612
8c9afb46
EZ
56132011-11-27 Eli Zaretskii <eliz@gnu.org>
5614
5615 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5616 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5617 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5618 (malloc, free, realloc, calloc): Redirect to e_* only when
5619 compiling Emacs.
5620
5621 * lisp.h (GCTYPEBITS): Move before first use.
5622 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5623 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5624 this macro definition.
5625
5626 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5627 _MSC_VER.
5628
54e9e3bf
JD
56292011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5630
6d5eb5b0
SM
5631 * gtkutil.c (xg_create_frame_widgets):
5632 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5633 present with Gtk+ 2.0.
5634
83aca1cb
PE
56352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5636
5637 * fileio.c (Finsert_file_contents): Undo previous change; see
5638 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5639
5b76caa4
PE
56402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5641
5642 Rename locals to avoid shadowing.
5643 * fileio.c (Finsert_file_contents):
5644 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5645 * process.c (wait_reading_process_output):
5646 Rename inner 'proc' to 'p' to avoid shadowing.
5647 Indent for consistency with usual Emacs style.
5648
8c535114
EZ
56492011-11-25 Eli Zaretskii <eliz@gnu.org>
5650
5651 * xdisp.c (redisplay_window): If cursor row is not fully visible
5652 after recentering, and scroll-conservatively is set to a large
5653 number, scroll window by a few more lines to make the cursor fully
5654 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5655 (start_display): Don't move to the next line if the display should
5656 start at a newline that is part of a display vector or an overlay
5657 string. (Bug#10119)
8c535114 5658
fa4fdb5c
JL
56592011-11-24 Juri Linkov <juri@jurta.org>
5660
5661 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5662 after the `MagickPingImage' call. (Bug#10112)
5663
90ec88df
CY
56642011-11-23 Chong Yidong <cyd@gnu.org>
5665
5666 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5667
56e2e794
MR
56682011-11-23 Martin Rudalics <rudalics@gmx.at>
5669
5670 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5671 making another buffer current. (Bug#10114)
5672
b6e64c41
GM
56732011-11-23 Glenn Morris <rgm@gnu.org>
5674
5675 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5676
6b21de18
CY
56772011-11-23 Chong Yidong <cyd@gnu.org>
5678
5679 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5680 using it (Bug#5984).
5681
b12cd789
EZ
56822011-11-22 Eli Zaretskii <eliz@gnu.org>
5683
5684 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5685 and header-lines, as they don't have one computed for them.
5686 (Bug#10098)
5687
5688 * .gdbinit (prow): Make displayed values more self-explaining.
5689 Add row's hash code.
5690
261b6fd4
LMI
56912011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5692
5693 * process.c (wait_reading_process_output): Fix asynchrounous
5694 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5695 (wait_reading_process_output): Add comment and URL.
261b6fd4 5696
e7cfd277
JD
56972011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5698
5699 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5700
a9b9b7f5
CY
57012011-11-21 Chong Yidong <cyd@gnu.org>
5702
5703 * window.c (Fnext_window, Fprevious_window): Doc fix.
5704
b0d15b4f
SM
57052011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5706
5707 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5708
fe7a3057
JB
57092011-11-20 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5712
d2999b1a
MR
57132011-11-20 Martin Rudalics <rudalics@gmx.at>
5714
5715 * window.c (Fset_window_combination_limit): Rename argument
5716 STATUS to LIMIT.
5717 (Vwindow_combination_limit): Remove "status" from doc-string.
5718
d5ff9cd0
AS
57192011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5720
5721 * m/ibms390.h: Remove.
5722 * m/ibms390x.h: Don't include "ibms390.h".
5723
a5bb9bd3
SM
57242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5725
5726 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5727 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5728
cd1181db
JB
57292011-11-20 Juanma Barranquero <lekktu@gmail.com>
5730
5731 * casetab.c (Fset_case_table):
5732 * charset.c (Fcharset_after): Fix typos.
5733
615a3b8d 57342011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5735
17e845af
PE
5736 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5737 Otherwise, valgrind does not work on some platforms.
5738 Problem reported by Andreas Schwab in
6a0bf43d
PE
5739 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5740 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5741 is set, removing the need for VIRT_ADDRESS_VARIES.
5742 (PURE_P): Use a more-efficient implementation that needs just one
5743 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5744 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5745 to 4 (xorl, subq, cmpq, setbe).
5746 * alloc.c (pure): Always extern now, since that's the
5747 VIRT_ADDR_VARIES behavior.
5748 (PURE_POINTER_P): Use a single comparison, not two, for
5749 consistency with the new puresize.h.
5750 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5751 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5752 Remove VIRT_ADDR_VARIES no longer needed.
5753
f8fe6f96
EZ
57542011-11-19 Eli Zaretskii <eliz@gnu.org>
5755
5756 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5757 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5758 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5759 behave as if the cursor position were at the window margin.
5760
5761 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5762 and the cursor position is out of bounds, behave as if the cursor
5763 position were at the window margin. (Bug#10075)
5764
df05a53c
CY
57652011-11-18 Chong Yidong <cyd@gnu.org>
5766
5767 * window.c (Fwindow_combination_limit): Make first argument
5768 non-optional, since it is meaningless for live windows like the
5769 selected window.
61ccba97 5770
2071918e
DA
57712011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5772
5773 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5774
b50a28de
SM
57752011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5776
5777 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5778 (graft_intervals_into_buffer): Simplify.
5779
015137db
EZ
57802011-11-18 Eli Zaretskii <eliz@gnu.org>
5781
5782 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5783 hash values of the two rows.
5784 (copy_row_except_pointers): Preserve the used[] arrays and the
5785 hash values of the two rows. (Bug#10035)
68c95424 5786 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5787
5788 * xdisp.c (row_hash): New function, body extracted from
5789 compute_line_metrics.
5790 (compute_line_metrics): Call row_hash, instead of computing the
5791 hash code inline.
5792
5793 * dispnew.c (verify_row_hash): Call row_hash for computing the
5794 hash code of a row, instead of duplicating code from xdisp.c.
5795
5796 * dispextern.h (row_hash): Add prototype.
5797
a2addb04
TH
57982011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5799
5800 * frame.c (delete_frame): Don't delete the terminal when the last
5801 X frame is closed if emacs is built with GTK toolkit.
5802
df85d315
JB
58032011-11-17 Juanma Barranquero <lekktu@gmail.com>
5804
5805 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5806
a0c2d0ae
MR
58072011-11-17 Martin Rudalics <rudalics@gmx.at>
5808
5809 * window.c (Vwindow_splits): Rename to
5810 Vwindow_combination_resize. Suggested by Juri Linkov.
5811 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5812 of Vwindow_splits.
5813
58179cce
JB
58142011-11-16 Juanma Barranquero <lekktu@gmail.com>
5815
7877f373
JB
5816 * nsfns.m (Fns_font_name):
5817 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5818
b6f67890
MR
58192011-11-16 Martin Rudalics <rudalics@gmx.at>
5820
5821 * window.h (window): Rename slot "nest" to "combination_limit".
5822 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5823 (Fset_window_nest): Rename to Fset_window_combination_limit.
5824 (Vwindow_nest): Rename to Vwindow_combination_limit.
5825 (recombine_windows, make_parent_window, make_window)
5826 (Fsplit_window_internal, saved_window)
5827 (Fset_window_configuration, save_window_save): Rename all
5828 occurrences of window_nest to window_combination_limit.
5829
c7015153
JB
58302011-11-15 Juanma Barranquero <lekktu@gmail.com>
5831
5832 * image.c (imagemagick_load_image): Fix typo.
5833
322ad6ec
EZ
58342011-11-14 Eli Zaretskii <eliz@gnu.org>
5835
5836 * xdisp.c (display_line): Move the call to
5837 highlight_trailing_whitespace before the call to
5838 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5839 faces of all the glyphs to compute ROW's hash value.
5840 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5841
f067b8ec
JB
58422011-11-14 Juanma Barranquero <lekktu@gmail.com>
5843
5844 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5845 just return (bug#10044).
5846
1e5b2111
EZ
58472011-11-12 Eli Zaretskii <eliz@gnu.org>
5848
7ef3cbd5
EZ
5849 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5850 with user-defined heap size. Bump the default size of the temacs
5851 heap to 27MB, to avoid memory warning when running temacs.
5852 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5853
1e5b2111
EZ
5854 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5855 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5856 (verify_row_hash) [XASSERTS]: New function.
5857 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5858 that the hash value of glyph rows is correct.
1e5b2111 5859
89d61221
MR
58602011-11-12 Martin Rudalics <rudalics@gmx.at>
5861
5862 * window.h (window): Remove splits slot.
5863 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5864 (Fdelete_other_windows_internal, make_parent_window)
5865 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5866 (Fset_window_configuration, save_window_save): Don't deal with
5867 split status of windows.
5868 (saved_window): Remove splits slot.
5869 (Vwindow_splits): Rewrite doc-string.
5870
97f18cc8
JD
58712011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5872
5873 * xfns.c (unwind_create_frame):
5874 * nsfns.m (unwind_create_frame):
5875 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5876 Vframe_list (Bug#9999).
5877
22a648b4
DA
58782011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5879
0b381c7e 5880 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5881
659afede
KH
58822011-11-11 Kenichi Handa <handa@m17n.org>
5883
5884 * callproc.c (Fcall_process): Set the member dst_multibyte of
5885 process_coding.
5886
9ac0394b
KH
58872011-11-11 Johan Bockgård <bojohan@gnu.org>
5888
5889 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5890 avoid a crash (bug#9496).
5891
2fbdc249
CY
58922011-11-09 Chong Yidong <cyd@gnu.org>
5893
5894 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5895 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5896
ac6b1f81
PE
58972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5900
09db192c
PE
59012011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5902
5903 Avoid some portability problems by eschewing 'extern inline' functions.
5904 The trivial performance wins aren't worth the portability hassles; see
5905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5906 et seq.
5907 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5908 (window_box_width, window_box_left, window_box_left_offset)
5909 (window_box_right, window_box_right_offset): Undo previous change,
5910 by removing the "extern"s.
5911 * intervals.c (adjust_intervals_for_insertion)
5912 (adjust_intervals_for_deletion): Undo previous change,
5913 making these static again.
5914 (offset_intervals, temp_set_point_both, temp_set_point)
5915 (copy_intervals_to_string): No longer inline.
5916 * xdisp.c (window_text_bottom_y, window_box_width)
5917 (window_box_height, window_box_left_offset)
5918 (window_box_right_offset, window_box_left, window_box_right)
5919 (window_box): No longer inline.
5920
105216ed
CY
59212011-11-08 Chong Yidong <cyd@gnu.org>
5922
5923 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5924 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5925 Signal an error if not a live window.
105216ed
CY
5926 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5927 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5928
ae9e237f
JB
59292011-11-07 Juanma Barranquero <lekktu@gmail.com>
5930
5931 * lisp.h (syms_of_abbrev): Remove declaration.
5932 Reported by CHENG Gao <chenggao@royau.me>.
5933
c7aa8333
EZ
59342011-11-07 Eli Zaretskii <eliz@gnu.org>
5935
5936 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5937 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5938 of temacs in GUI mode.
5939
be7f5545
MR
59402011-11-07 Martin Rudalics <rudalics@gmx.at>
5941
5942 * window.h: Declare delete_all_child_windows instead of
5943 delete_all_subwindows.
5944 * window.c (Fwindow_nest, Fset_window_nest)
5945 (Fset_window_new_total, Fset_window_new_normal)
5946 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5947 (delete_all_subwindows): Rename to delete_all_child_windows.
5948 (Fdelete_other_windows_internal, Fset_window_configuration):
5949 Call delete_all_child_windows instead of delete_all_subwindows.
5950 * frame.c (delete_frame): Call delete_all_child_windows instead
5951 of delete_all_subwindows.
5952
ca78dc43
PE
59532011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5954
5955 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5956 This is also needed for porting to any host where GC_MARK_STACK is
5957 not GC_MAKE_GCPROS_NOOPS.
5958 (which_symbols): Use it.
5959
a0241d01
KH
59602011-11-07 Kenichi Handa <handa@m17n.org>
5961
5962 * coding.c (coding_set_destination): Check coding->src_pos only
5963 when coding->src_object is a buffer (bug#9910).
5964
5965 * process.c (send_process): Set the member src_multibyte of coding
5966 to 0 (bug#9911) when sending a unibyte text.
5967
5968 * callproc.c (Fcall_process): Set the member src_multibyte of
5969 process_coding to 0 (bug#9912).
5970
a64bfdfa 59712011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5972
5973 * xmenu.c (cleanup_widget_value_tree): New function.
5974 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5975 calling free_menubar_widget_value_tree directly (Bug#9830).
5976
cb41b32a
PE
59772011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5978
5979 Fix some portability problems with 'inline'.
5980 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5981 (window_box_width, window_box_left, window_box_left_offset)
5982 (window_box_right, window_box_right_offset): Declare extern.
5983 Otherwise, these inline functions do not conform to C99 and
5984 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5985 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5986 * intervals.c (adjust_intervals_for_insertion)
5987 (adjust_intervals_for_deletion): Now extern, because otherwise the
5988 extern inline functions 'offset_intervals' couldn't refer to it.
5989 (static_offset_intervals): Remove.
5990 (offset_intervals): Rewrite using the old contents of
5991 static_offset_intervals. The old version didn't conform to C99
5992 because an extern inline function contained a reference to an
5993 identifier with static linkage.
5994
b7041366
AS
59952011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5996
5997 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5998 GC.
5999
88a37c4d
EZ
60002011-11-06 Eli Zaretskii <eliz@gnu.org>
6001
6002 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6003 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6004 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6005 return Qleft_to_right.
6006
49745b39
CY
60072011-11-06 Chong Yidong <cyd@gnu.org>
6008
6009 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6010 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6011 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6012 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6013 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6014 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6015 (Fwindow_vscroll): Doc fix.
6016 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6017 argument, since it makes no sense to pass a live window and for
6018 consistency with window-child.
6019
1f05cd82
CS
60202011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6021
6022 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6023 support MSVC.
6024
22610910
JR
60252011-11-05 Jason Rumney <jasonr@gnu.org>
6026
6027 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6028 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6029 fonts (Bug#6029).
6030 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6031 bitwise arithmetic preventing use of unicode-sip and non-truetype
6032 opentype fonts.
6033
a06776b2
EZ
60342011-11-05 Eli Zaretskii <eliz@gnu.org>
6035
3ad924ba
EZ
6036 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6037 "emacs"-only part.
6038
a06776b2
EZ
6039 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6040 initialization code to keep similarity to xfns.c after changes
6041 from 2011-11-05.
6042
c9e7db78
JD
60432011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6044
a97f8f3f
JD
6045 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6046 (unwind_create_frame): New function (Bug#9943).
6047 (Fx_create_frame): Restructure code to be more similar to the one in
6048 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6049 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6050 Move terminal->reference_count++ just before making the frame official
6051 (Bug#9943).
6052
6053 * nsterm.m (x_free_frame_resources): New function.
6054 (x_destroy_window): Move code to x_free_frame_resources.
6055
c9e7db78 6056 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6057 (Fx_create_frame, x_create_tip_frame):
6058 Move terminal->reference_count++ just before making the frame
75f1671a 6059 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6060 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6061
a6fc3b5c
EZ
60622011-11-05 Eli Zaretskii <eliz@gnu.org>
6063
6064 Support MSVC build with newer versions of Visual Studio.
6065 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6066 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6067 nt/gmake.defs.
6068
6069 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6070 which are not supported by MSVC.
6071 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6072 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6073 bitfields.
6074 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6075 types in bitfields.
6076 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6077
6078 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6079
58179cce 60802011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6081
6082 Support MSVC build with newer versions of Visual Studio.
6083 * w32.c: Don't include w32api.h for MSVC.
6084 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6085
6086 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6087 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6088 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6089 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6090 e_* cousins.
6091 (alloca) [_MSC_VER]: Define to _alloca.
6092
6093 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6094
6095 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6096
a58c13ed
EZ
60972011-11-04 Eli Zaretskii <eliz@gnu.org>
6098
6099 * xdisp.c (note_mouse_highlight): If either of
6100 previous/next-single-property-change returns nil, treat that as
6101 the beginning or the end of the buffer. (Bug#9955)
6102
fe0b6370
JD
61032011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6104
a58c13ed 6105 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6106 label is not null (Bug#9951).
6107 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6108 may be NULL.
6109
89bd5ee1
EZ
61102011-11-04 Eli Zaretskii <eliz@gnu.org>
6111
6112 * window.c (Fwindow_body_size): Mention in the doc string that the
6113 return value is in frame's canonical units. (Bug#9949)
6114
84c3edb9
EZ
61152011-11-03 Eli Zaretskii <eliz@gnu.org>
6116
4e2fb5c7
EZ
6117 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6118
84c3edb9 6119 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6120 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6121 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6122
bc17a887
EZ
61232011-11-01 Eli Zaretskii <eliz@gnu.org>
6124
6125 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6126 Don't stop backward scan on the continuation glyph, even though
6127 its CHARPOS is positive.
6d5eb5b0
SM
6128 (mouse_face_from_buffer_pos, note_mouse_highlight):
6129 Rename cover_string to disp_string.
bc17a887 6130
4ee88440
MR
61312011-11-01 Martin Rudalics <rudalics@gmx.at>
6132
6133 * window.c (temp_output_buffer_show): Don't use
6134 Vtemp_buffer_show_specifiers.
6135 (Vtemp_buffer_show_specifiers): Remove unused variable.
6136
c2ff3c02
EZ
61372011-10-30 Eli Zaretskii <eliz@gnu.org>
6138
6139 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6140 past the beginning of the current glyph matrix.
6141
58179cce 61422011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6143
6144 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6145 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6146 HAVE_GTK3 (Bug#9869).
b77a6a7f 6147
3b574623
JD
6148 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6149 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6150
b77a6a7f
JD
6151 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6152
6153 * xterm.c: Declare x_handle_net_wm_state to return int.
6154 (handle_one_xevent): Check if we are iconified but don't have
6155 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6156 (get_current_wm_state): Return non-zero if not hidden,
6157 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6158 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6159 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6160 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6161
196e41e4
PE
61622011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6163
6164 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6165 so that this new function doesn't get optimized away by a
6166 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6167
021f2e1a
AS
61682011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6169
6170 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6171
8b058d44
EZ
61722011-10-29 Eli Zaretskii <eliz@gnu.org>
6173
6174 Fix the `xbytecode' command.
6175 * .gdbinit (xprintbytestr): New command.
b50a28de 6176 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6177 (xbytecode): Print the byte-code string as well.
6178
4452fb80
EZ
61792011-10-29 Kim Storm <storm@cua.dk>
6180
8b058d44
EZ
6181 * alloc.c (which_symbols): New function.
6182
21b72067
AS
61832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6184
6185 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6186 line. (Bug#9903)
6187
83ed7b5c
GM
61882011-10-29 Glenn Morris <rgm@gnu.org>
6189
6190 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6191 Not clear what it was for, and it causes various bugs. (Bug#9839)
6192
5a7a728b
EZ
61932011-10-28 Eli Zaretskii <eliz@gnu.org>
6194
6195 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6196 possible random value that matches one of those tested as
6197 condition to clear the mouse face.
6198
d3d0842f
CY
61992011-10-28 Chong Yidong <cyd@gnu.org>
6200
6201 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6202
31b39d13
DN
62032011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6204
6205 * window.c (make_window): Initialize phys_cursor_on_p.
6206
9aba6043
SM
62072011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6208
6209 * lisp.h (struct Lisp_Symbol): Update comments.
6210
c20992f4
JB
62112011-10-28 Juanma Barranquero <lekktu@gmail.com>
6212
6213 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6214
db4f02f2
EZ
62152011-10-28 Eli Zaretskii <eliz@gnu.org>
6216
6217 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6218 <oslsachem@gmail.com> for helping to debug this.
6219
6220 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6221 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6222 (g_b_init_get_glyph_outline_w): New static variables.
6223 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6224 (GetGlyphOutlineW_Proc): New typedefs.
6225 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6226 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6227 New functions.
6228 (w32font_open_internal, compute_metrics):
6229 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6230 instead of calling the "wide" APIs directly.
6231
6232 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6233
6234 * w32.h (syms_of_w32font): Add prototype.
6235
87e68db4
JB
62362011-10-27 Juanma Barranquero <lekktu@gmail.com>
6237
6238 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6239 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6240 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6241 (Fmove_to_window_line): Doc fix.
6242
435c1d67
CY
62432011-10-27 Chong Yidong <cyd@gnu.org>
6244
6245 * process.c (make_process): Set gnutls_state to NULL.
6246
6247 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6248 non-NULL, regardless of GNUTLS_INITSTAGE.
6249 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6250 an error. Set process slots as soon as we allocate them.
6251
6252 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6253
9c6c6f49
CY
62542011-10-27 Chong Yidong <cyd@gnu.org>
6255
9aba6043
SM
6256 * gnutls.c (emacs_gnutls_deinit): New function.
6257 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6258 (Fgnutls_deinit, Fgnutls_boot): Use it.
6259
6260 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6261 (deactivate_process): Call emacs_gnutls_deinit.
6262
657d08d3
JB
62632011-10-27 Juanma Barranquero <lekktu@gmail.com>
6264
6265 * image.c (x_create_x_image_and_pixmap):
6266 * w32.c (sys_rename, w32_delayed_load):
6267 * w32font.c (fill_in_logfont):
6268 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6269
5430d399
JB
62702011-10-26 Juanma Barranquero <lekktu@gmail.com>
6271
6272 * w32fns.c (w32_default_color_map): New function,
6273 extracted from Fw32_default_color_map.
a7ef684b 6274 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6275
fe0055fa
PE
62762011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6277
6278 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6279
e6346438
SM
62802011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6281
6282 * keyboard.c (test_undefined): New function (bug#9751).
6283 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6284
e112cc37
ET
62852011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6286
6287 * sysdep.c (init_sys_modes): Fix the check for the controlling
6288 terminal (Bug#6649).
6289
7b5d6677
EZ
62902011-10-20 Eli Zaretskii <eliz@gnu.org>
6291
6292 * dispextern.h (struct bidi_it): New member next_en_type.
6293
6294 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6295 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6296 current character, check also for next_en_type being WEAK_EN.
6297 (bidi_resolve_weak): Don't enter the expensive loop if the current
6298 position is before next_en_pos. Record the bidi type of the first
6299 non-ET, non-BN character we find, in addition to its position.
6300 (bidi_level_of_next_char): Invalidate next_en_type when
6301 next_en_pos is over-stepped.
6302
7da0b018
PE
63032011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6304
6305 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6306 * editfns.c: Rewrite current-time-zone so that it invokes
6307 the equivalent of (format-time-string "%Z") to get the time zone name.
6308 This fixes a bug when the time zone name contains characters that
6309 need converting from the system time locale to Emacs internal format.
6310 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6311 that patch fixed format-time-string to do the conversion, but
6312 I forgot to fix current-time-zone.
6313 (format_time_string): New function, containing most of
6314 what Fformat_time_string used to contain.
6315 (Fformat_time_string): Rewrite in terms of format_time_string.
6316 This doesn't change this function's behavior.
6317 (current-time-zone): Rewrite to use format_time_string.
6318 This fixes the bug reported by Michael Schierl in
6319 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6320 Jason Rumney's 2007-06-07 change worked around this bug, but
6321 didn't fix it.
6322 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6323
8547b010
EZ
63242011-10-19 Eli Zaretskii <eliz@gnu.org>
6325
6326 * xdisp.c (start_display): If the character at POS is displayed
6327 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6328 (try_window_reusing_current_matrix): If a line ends in a display
6329 vector or the next line starts in a display vector, continue
6330 redrawing the window even though the character position of
6331 start_row was reached.
8547b010
EZ
6332 (Bug#9771, part 2)
6333
4e948d15
CY
63342011-10-18 Chong Yidong <cyd@gnu.org>
6335
6336 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6337 with nobreak-char-display too.
6338
4787455f
EZ
63392011-10-18 Eli Zaretskii <eliz@gnu.org>
6340
6341 Fix part 3 of bug#9771.
6342 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6343 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6344 non-neutral characters if the current character is a paragraph
6345 separator (a.k.a. Newline). This avoids running the same
6346 expensive loop twice, once when we consume the preceding newline
6347 and the other time when the line actually needs to be displayed.
6348 Avoid the loop when we see neutrals on the base embedding level
6349 following a character whose directionality is the same as the
6350 paragraph's. This avoids running the expensive loop when a line
6351 ends in a long sequence of neutrals, like control characters.
6352 Add assertion against STRONG_AL type. Slightly rearrange code
6353 that determines the type of a neutral given the first non-neutral
6354 that follows it.
6355 (bidi_level_of_next_char): Set next_en_pos to zero when
6356 invalidating its info.
6357
2c91f553
EZ
63582011-10-17 Eli Zaretskii <eliz@gnu.org>
6359
6360 * xdisp.c (push_display_prop): Determine whether to record string
6361 or buffer position by IT->string, not by IT->method. Allow
6362 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6363 (move_it_vertically_backward): Don't look for character position
6364 immediately after the newline when in a continuation line.
6365 (Bug#9771, part 1)
2c91f553 6366
c7b08b0d
MR
63672011-10-15 Martin Rudalics <rudalics@gmx.at>
6368
6369 * window.c (coordinates_in_window): Rewrite and delabelize
6370 vertical border check. (Bug#5357) (Bug#9618)
6371
6b02f655
SM
63722011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6373
6374 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6375 errors in XSetWindowBorder (bug#9310).
6376
81d40c92
DA
63772011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6378
6379 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6380 avoid crash when xmalloc overrun checking is enabled.
6381
d4172c3b
EZ
63822011-10-13 Eli Zaretskii <eliz@gnu.org>
6383
6384 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6385 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6386 cursor motion with <left> and <right> arrow keys.
6387
6388 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6389 some callers set that themselves.
6390
b00eea75
EZ
63912011-10-12 Eli Zaretskii <eliz@gnu.org>
6392
6393 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6394 display string and the previous row comes from the same string and
6395 is empty. (Bug#9739) (Bug#9738)
6396
8fe012c4
SM
63972011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6398
6399 * doc.c (get_doc_string): Encode file name (bug#9735).
6400
0074aef2
EZ
64012011-10-12 Eli Zaretskii <eliz@gnu.org>
6402
79beb178
EZ
6403 * bidi.c (bidi_level_of_next_char):
6404 * xdisp.c (get_visually_first_element): Remove old incorrect
6405 comments regarding the Unicode Line Separator character.
6406
0074aef2
EZ
6407 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6408
6e4b3fbe
DA
64092011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6410
6411 * alloc.c (Fgc_status): Do not access beyond zombies array
6412 boundary if nzombies > MAX_ZOMBIES.
6413 * alloc.c (dump_zombies): Add missing format specifier.
6414
0324f3af
PE
64152011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6416
b5525cac
PE
6417 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6418 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6419
0324f3af
PE
6420 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6421 Some packages use them to denote characters with modifiers.
6422
e9b5f888
AS
64232011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6424
6425 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6426 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6427 matching a pp-number. Rename parameter var to var1.
6428
127827c0
SM
64292011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6430
6431 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6432
c8fd3bd0
GM
64332011-10-08 Glenn Morris <rgm@gnu.org>
6434
6435 * callint.c (Fcall_interactively): Give a more explicit error for the
6436 'c' case with a non-character input. (Bug#8479)
6437
352ec8ff
EZ
64382011-10-08 Eli Zaretskii <eliz@gnu.org>
6439
03669ccb
EZ
6440 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6441 lines.
7061c986
EZ
6442 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6443 lines that are hscrolled on the left.
03669ccb 6444
352ec8ff
EZ
6445 * dispnew.c (buffer_posn_from_coords): Account for a possible
6446 presence of header-line. (Bug#4426)
6447
a66cfb1c
SM
64482011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6449
6b02f655
SM
6450 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6451 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6452
7c5ee88e
PE
64532011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6454
6455 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6456 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6457 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6458 this makes Emacs dump core during garbage collection on rare
6459 occasions. sizeof is obviously inferior to offsetof here, so
6460 stick with offsetof.
6461 (GC_POINTER_ALIGNMENT): New macro.
6462 (mark_memory): Omit 3rd (offset) arg; caller changed.
6463 Don't assume EMACS_INT alignment is the same as pointer alignment.
6464
df1bbe5b
SM
64652011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6466
6467 * keyboard.c (read_key_sequence_remapped): New var.
6468 (read_key_sequence): Compute remapping in the right buffer.
6469 (command_loop_1): Use read_key_sequence's remapping directly.
6470
51553db6
SM
64712011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6472
32c1fffd
SM
6473 * dired.c (file_name_completion): Don't expand file name.
6474 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6475 before checking file name handler.
6476
51553db6
SM
6477 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6478 they've been requested explicitly (bug#9591).
6479
b6bd1599 64802011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6481
6482 * keymap.c (Fsingle_key_description): Use make_specified_string
6483 instead of build_string to build string from push_key_description.
6484 (Bug#5193)
6485
f701dc2a
PE
64862011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6487
4222c55d
PE
6488 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6489 This fixes a Y2038 bug on 64-bit hosts.
6490 * buffer.c (reset_buffer):
6491 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6492 (Fclear_buffer_auto_save_failure):
6493 Use 0, not -1, to represent an unset failure time, since time_t
6494 might not be signed.
6495
f701dc2a
PE
6496 Remove dependency on glibc malloc internals.
6497 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6498 Move back here from lisp.h, but with their new implementations.
6499 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6500 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6501 * charset.c (charset_table_init): New static var.
6502 (syms_of_charset): Use it instead of xmalloc. This removes a
6503 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6504 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6505 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6506 Move back to alloc.c.
6507 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6508 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6509
9ceebf39
JD
65102011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6511
6512 * nsterm.m (windowDidResize): Call x_set_window_size only when
6513 ns_in_resize is true. Otherwise set pixelwidth/height and
6514 call change_frame_size (Bug#9628).
6515
cb993c58
PE
65162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6517
3930c88b
PE
6518 Port --enable-checking=all to Fedora 14 x86-64.
6519 * charset.c (syms_of_charset): Also account for glibc malloc's
6520 internal overhead when calculating the initial malloc maximum.
6521
cb993c58
PE
6522 Port --enable-checking=all to Fedora 14 x86.
6523 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6524 Move to lisp.h.
6525 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6526 (overrun_check_realloc, overrun_check_free):
6527 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6528 That way, xmalloc returns a properly-aligned pointer even if
6529 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6530 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6531 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6532 into account when calculating the initial malloc maximum.
6533 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6534 Move here from alloc.c, so that charset.c can use it too.
6535 Properly align; the old code wasn't right for common 32-bit hosts
6536 when configured with --enable-checking=all.
6537 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6538 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6539
31bed486
EZ
65402011-09-29 Eli Zaretskii <eliz@gnu.org>
6541
04c70788 6542 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6543 use EDOM.
6544
fbcaa2f3
EZ
65452011-09-28 Eli Zaretskii <eliz@gnu.org>
6546
6547 * xdisp.c (compute_display_string_end): If there's no display
6548 string at CHARPOS, return -1.
6549
6550 * bidi.c (bidi_fetch_char): When compute_display_string_end
6551 returns a negative value, treat the character as a normal
6552 character not covered by a display string. (Bug#9624)
6553
a239d4e9
JB
65542011-09-28 Juanma Barranquero <lekktu@gmail.com>
6555
6556 * lread.c (Fread_from_string): Fix typo in docstring.
6557
88652fd5
EZ
65582011-09-27 Eli Zaretskii <eliz@gnu.org>
6559
6560 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6561 newline, reseat the iterator instead of bidi-iterating there one
6562 character at a time. (Bug#9610)
32c1fffd
SM
6563 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6564 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6565
ed497dd4
AS
65662011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6567
6568 * lread.c (readevalloop): Use correct code for NBSP.
6569 (read1): Likewise. (Bug#9608)
6570
b2bf61aa
MA
65712011-09-25 Michael Albinus <michael.albinus@gmx.de>
6572
6573 * dbusbind.c (Fdbus_register_signal): When service is not
6574 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6575
32bbb17c
GM
65762011-09-25 Glenn Morris <rgm@gnu.org>
6577
6578 * buffer.c (truncate-lines): Doc fix.
6579
94e0933e
CY
65802011-09-24 Chong Yidong <cyd@stupidchicken.com>
6581
6582 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6583 (Fset_window_next_buffers): Doc fix.
6584
cddde921
GM
65852011-09-24 Glenn Morris <rgm@gnu.org>
6586
6587 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6588
1260aef1
PE
65892011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6590
25b4bfa0
PE
6591 Fix minor problems found by static checking.
6592 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6593 * indent.c (Fvertical_motion): Fix == vs = typo.
6594
e3cbd34b
EZ
65952011-09-24 Eli Zaretskii <eliz@gnu.org>
6596
a66cfb1c
SM
6597 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6598 Default value is now t. Doc fix.
6bf7006f 6599
e3cbd34b 6600 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6601 logic when moving up, not only when moving down. Fix the
e3cbd34b 6602 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6603 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6604
6605 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6606 CHARPOS is covered by a display string which includes newlines.
6607 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6608 is covered by a display string with embedded newlines.
6609
a3de0cbd
MA
66102011-09-24 Michael Albinus <michael.albinus@gmx.de>
6611
6612 * dbusbind.c (Fdbus_register_signal): Add match rule to
6613 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6614 (Fdbus_register_method, Vdbus_registered_objects_table):
6615 Fix docstring.
a3de0cbd 6616
b260039d
JM
66172011-09-24 Jim Meyering <meyering@redhat.com>
6618
32c1fffd 6619 do not ignore write error for any output size
b260039d
JM
6620 The previous change was incomplete.
6621 While it makes emacs --batch detect the vast majority of stdout
6622 write failures, errors were still ignored whenever the output size is
6623 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6624 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6625 && echo FAIL: ignored write error
6626 FAIL: ignored write error
6627 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6628 && echo FAIL: ignored write error
6629 FAIL: ignored write error
6630 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6631
8eca8a7c
AS
66322011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6633
6634 * emacs.c (Fkill_emacs): In noninteractive mode exit
6635 non-successfully if a write error occurred on stdout. (Bug#9574)
6636
3341db62
EZ
66372011-09-21 Eli Zaretskii <eliz@gnu.org>
6638
6639 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6640 the xassert test.
6641
6642 * dispextern.h (struct it): Update the comment documenting what
6643 can it->OBJECT be.
6644
8c203dbf
EZ
66452011-09-20 Eli Zaretskii <eliz@gnu.org>
6646
6647 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6648 a display string, extend search for cursor position to end of row.
6649 (find_row_edges): If the row ends in a newline from a display
6650 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6651 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6652 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6653 non-empty line. Fixes confusing cursor motion with arrow keys at
6654 the beginning of a line that starts with whitespace.
8c203dbf 6655
a4824228
LMI
66562011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6657
6658 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6659 (bug#9493).
6660
33ed493b
CY
66612011-09-18 Chong Yidong <cyd@stupidchicken.com>
6662
6663 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6664 boolean (Bug#9154).
6665
56cd55c8
EZ
66662011-09-18 Eli Zaretskii <eliz@gnu.org>
6667
6668 * xdisp.c (display_line): Record maximum and minimum buffer
6669 positions even if no glyphs were produced (e.g., by a zero-width
6670 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6671 buffer positions that will be removed from the glyph row because
6672 they don't fit.
c02dcedf
EZ
6673 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6674 column is beyond frame width: don't subtract 1 "pixel" when
6675 computing width of the stretch.
3e62b7e0
EZ
6676 (reseat_at_next_visible_line_start): Undo the change made on
6677 2011-09-17 that saved paragraph information and restored it after
6678 the call to `reseat'. (Bug#9545)
56cd55c8 6679
5ed99d36 66802011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6681
6682 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6683 and turn window cursor on if cleared (Bug#9415).
6684
5ed99d36 66852011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6686
6687 * search.c (boyer_moore): Take unibyte characters from pattern
6688 literally. (Bug#9458)
6689
9bade7b2
EZ
66902011-09-18 Eli Zaretskii <eliz@gnu.org>
6691
6692 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6693
e5e9d610
PE
66942011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6695
87e4427a
PE
6696 Fix minor problem found by static checking.
6697 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6698 initialized, to pacify gcc -Wuninitialized.
6699
e5e9d610
PE
6700 * fileio.c: Report proper errno when syscall falls.
6701 (Finsert_file_contents): Save and restore errno,
6702 so that report_file_error outputs the correct diagnostic.
6703 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6704
a1674f0b
EZ
67052011-09-18 Eli Zaretskii <eliz@gnu.org>
6706
6707 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6708
fbfb6dd4
EZ
67092011-09-17 Eli Zaretskii <eliz@gnu.org>
6710
6711 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6712 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6713
bb187662
EZ
67142011-09-17 Eli Zaretskii <eliz@gnu.org>
6715
1137e8b8 6716 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6717 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6718
6719 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6720 (bidi_find_paragraph_start): Search back for paragraph beginning
6721 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6722 (bidi_move_to_visually_next): Only trigger paragraph-related
6723 computations when the last character is a newline or at EOB, not
6724 just any NEUTRAL_B. (Bug#9470)
6725
bb187662
EZ
6726 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6727 truncated lines if point is covered by a display string. (Bug#9524)
6728
2e621251
PE
67292011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6730
6731 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6732 (cons_to_x_long): New function.
6733 (lisp_data_to_selection_data): Use it. Correct the test for
6734 short-versus-long data; it was negated. Break out of vector
6735 loop, for efficiency, when a long datum is discovered.
6736
91a15bc6
SM
67372011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6738
6739 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6740
b41c3a35
EZ
67412011-09-16 Eli Zaretskii <eliz@gnu.org>
6742
6743 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6744 GCC PR/17406) by declaring this function with external scope.
6745
7812ba2d
PE
67462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6747
6748 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6749 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6750
cf7edc2a
AS
67512011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6752
6753 * editfns.c (Fformat): Correctly handle text properties on "%%".
6754
bd01620e
EZ
67552011-09-15 Eli Zaretskii <eliz@gnu.org>
6756
6757 * xterm.c (x_draw_composite_glyph_string_foreground):
6758 * w32term.c (x_draw_composite_glyph_string_foreground):
6759 * term.c (encode_terminal_code):
6760 * composite.c (composition_update_it, get_composition_id):
6761 * xdisp.c (get_next_display_element)
6762 (fill_composite_glyph_string): Add comments about special meaning
6763 of TAB characters in a composition.
6764
a02719a3
PE
67652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6766
6767 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6768 This occurs when processing a multibyte format.
6769 Problem reported by Wolfgang Jenker.
a02719a3 6770
72589a3c
JB
67712011-09-15 Johan Bockgård <bojohan@gnu.org>
6772
6773 * xdisp.c (try_cursor_movement): Only check for exact match if
6774 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6775
1c14176c
PE
67762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6777
6778 Remove unused external symbols.
6779 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6780 * xdisp.c (calc_pixel_width_or_height): Now static.
6781 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6782 * indent.c (check_display_width):
6783 * w32term.c: Fix comment to match code.
6784 * xterm.c, xterm.h (x_catching_errors): Remove.
6785
d2eea5b5
PE
67862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6787
6788 * xselect.c: Use signed conversions more consistently (Bug#9498).
6789 (selection_data_to_lisp_data): Assume incoming selection data are
6790 signed integers, not unsigned. This is to be consistent with
6791 outgoing selection data, which was modified to use signed integers
6792 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6793 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6794 expects long, not unsigned long.
6795
46888499
EZ
67962011-09-14 Eli Zaretskii <eliz@gnu.org>
6797
6798 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6799 computation of loop end. Reported by Johan Bockgård
6800 <bojohan@gnu.org>.
6801
ef8ef9fb
CY
68022011-09-13 Chong Yidong <cyd@stupidchicken.com>
6803
6804 * frame.c (Fother_visible_frames_p): Function deleted.
6805
fa819fed
EZ
68062011-09-12 Eli Zaretskii <eliz@gnu.org>
6807
6808 * indent.c (compute_motion): Process display vector front to back
6809 rather than the other way around. (Bug#2496)
6810
2ba8e008
SM
68112011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6812
6813 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6814
20f53c69
CY
68152011-09-11 Chong Yidong <cyd@stupidchicken.com>
6816
6817 * minibuf.c (Fread_from_minibuffer): Doc fix.
6818
d562d7a4
EZ
68192011-09-11 Eli Zaretskii <eliz@gnu.org>
6820
6821 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6822 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6823
1c4d7f3d
LMI
68242011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6825
6826 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6827 value for non-existent files.
6828
b885bf36
EZ
68292011-09-11 Eli Zaretskii <eliz@gnu.org>
6830
6831 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6832 set its "size" to -1. This will set the modtime_size field of
6833 the corresponding buffer to -1, which is what
6834 verify-visited-file-modtime expects for files that do not exist.
6835 (Bug#9139)
6836
6612f0bf
PE
68372011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6838
6839 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6840 here ...
6841 * lisp.h: ... from here. push_key_description is no longer
6842 defined in keyboard.c, so its declaration should not be in
6843 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6844 logically belongs with push_key_description.
6845
dfb3f755
PE
68462011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6847
6848 * buffer.h: Include <sys/types.h> instead of <time.h>.
6849 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6850 Problem reported by Herbert J. Skuhra.
6851
3134906c
LMI
68522011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6853
6854 * xml.c (parse_region): Make the parsing work for
6855 non-comment-starting XML files again (bug#9144).
6856
8d903f4e
AS
68572011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6858
6859 * image.c (gif_load): Fix calculation of bottom and right corner.
6860 (Bug#9468)
6861
80ad64f4
EZ
68622011-09-10 Eli Zaretskii <eliz@gnu.org>
6863
6864 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6865 redisplay in small windows.
6866
208a048d
EZ
68672011-09-09 Eli Zaretskii <eliz@gnu.org>
6868
6869 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6870
9b1c252e
MR
68712011-09-08 Martin Rudalics <rudalics@gmx.at>
6872
6873 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6874 Operate on live windows only.
6875
2949f33b
JB
68762011-09-08 Juanma Barranquero <lekktu@gmail.com>
6877
6878 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6879
e08dcafd
EZ
68802011-09-07 Eli Zaretskii <eliz@gnu.org>
6881
6882 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6883 only under bidi iteration.
6884
115b96bd
JD
68852011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6886
6887 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6888
c8199d0f
PE
68892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6890
6891 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6892 Without this fix, the command to link temacs failed due to an
6893 undefined symbol __builtin_isnan. This is because
6894 /usr/include/iso/math_c99.h #defines isnan(x) to
6895 __builtin_isnan(x), but the bundled gcc, which identifies itself
6896 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6897 a __builtin_isnan.
6898 * floatfns.c (isnan): #undef, and then #define to a clone of
6899 what's in data.c.
6900 (Fisnan): Always define, since it's always available now.
6901 (syms_of_floatfns): Always define isnan at the Lisp level.
6902
e39b275c 69032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6904
6905 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6906
b2db44d9 69072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6908
f4af5137 6909 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6910 The previous code assumed that file offsets (off_t values) fit in
6911 EMACS_INT variables, which is not true on typical 32-bit hosts.
6912 The code messed up by falsely reporting buffer overflow in cases
6913 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6914 when "big" contains more than 2**29 bytes, even though this
6915 inserts just one byte and does not overflow the buffer.
6916 (Finsert_file_contents): Store file offsets as off_t
6917 values, not as EMACS_INT values. Check for overflow when
6918 converting between EMACS_INT and off_t. When checking for
6919 buffer overflow or for overlap, take the offsets into account.
6920 Don't use EMACS_INT for small values where int suffices.
6921 When checking for overlap, fix a typo: ZV was used where
6922 ZV_BYTE was intended.
6923 (Fwrite_region): Don't assume off_t fits into 'long'.
6924 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6925
ecfc0a49
MA
69262011-09-05 Michael Albinus <michael.albinus@gmx.de>
6927
6928 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6929
6511acf2 69302011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6931
0999621a 6932 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6933
6934 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6935 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6936 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6937 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6938 (modify_event_symbol): Do not assume that the length of
6939 name_alist_or_stem is safe to alloca and fits in int.
6940 (Fexecute_extended_command): Likewise for function name and binding.
6941 (Frecursion_depth): Wrap around reliably on integer overflow.
6942 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6943 since some callers pass EMACS_INT values.
6944 (Fsingle_key_description): Don't crash if symbol name contains more
6945 than MAX_ALLOCA bytes.
6946 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6947 (get_minibuffer): Arg is now EMACS_INT, not int.
6948 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6949 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6950 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6951
2be7d702
PE
6952 * dbusbind.c (signature_cat): New function.
6953 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6954 Do not overrun buffer; instead, report string overflow.
6955
9d1df220
PE
6956 * dispnew.c (add_window_display_history): Don't overrun buffer.
6957 Truncate instead; this is OK since it's just a log.
6958
33ef5c64
PE
6959 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6960 even if the time zone offset is outlandishly large.
6961 Don't mishandle offset == INT_MIN.
6962
66c6fdd5
PE
6963 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6964 when creating daemon; the previous buffer-overflow check was incorrect.
6965
d749b01b
PE
6966 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6967 which has the guts of the old verror function.
6968
b5cd1905
PE
6969 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6970 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6971
6e1a67fb
PE
6972 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6973 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6974 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6975 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6976 length of string rather than counting it via multiple sprintfs;
6977 that's simpler and more reliable.
c21721cc
PE
6978 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6979 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6980 sprintf, in case result does not fit in int.
6981
c57b67fc
PE
6982 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6983 (fontset_from_font): Print it.
6984
8a401434
PE
6985 * frame.c (tty_frame_count): Now printmax_t, not int.
6986 (make_terminal_frame, set_term_frame_name): Print it.
6987 (x_report_frame_params): In X, window IDs are unsigned long,
6988 not signed long, so print them as unsigned.
6989 (validate_x_resource_name): Check for implausibly long names,
6990 and don't assume name length fits in 'int'.
6991 (x_get_resource_string): Don't blindly alloca invocation name;
6992 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6993 not fit in int.
6994
6e1a67fb
PE
6995 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6996 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6997 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6998
0df02bf3
PE
6999 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7000 Use esprintf, not sprintf, in case result does not fit in int.
7001
48e30793
PE
7002 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7003 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7004 it as a large positive number.
7005 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7006 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7007
a66ff6d8
PE
7008 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7009 in case result does not fit in int.
7010
aca216ff
PE
7011 * print.c (float_to_string): Detect width overflow more reliably.
7012 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7013 buffer overrun. Don't assume list length fits in 'int'. Treat
7014 print length of 0 as 0, not as infinity; to be consistent with other
7015 uses of print length in this function. Don't overflow print length
7016 index. Don't assume hash table size fits in 'long', or that
7017 vectorlike size fits in 'unsigned long'.
7018
31c286f7
PE
7019 * process.c (make_process): Use printmax_t, not int, to format
7020 process-name gensyms.
7021
55e5faa1
PE
7022 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7023
80f2e268
PE
7024 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7025 to avoid potential buffer overrun.
7026
670741ab
PE
7027 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7028 if X resource line is longer than 512 bytes.
7029
b7163a50
PE
7030 * xfns.c (x_window): Make sprintf buffer a bit bigger
7031 to avoid potential buffer overrun.
7032
ae58ff1f
PE
7033 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7034
c43c8a6a
PE
7035 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7036
3f8236f4
PE
70372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7038
53e9fe90 7039 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7040 Without these, Emacs silently mishandles large integers sometimes.
7041 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7042 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7043
6511acf2
PE
7044 * xdisp.c (try_window_id): Check Emacs fixnum range before
7045 converting to 'int'.
806add1d 7046
6511acf2 7047 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7048 Check that an Emacs fixnum is in range before assigning it to 'int'.
7049 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7050 values converted from Emacs fixnums.
7051 (Frecenter): Don't wrap around a line count if it is out of 'int'
7052 range; instead, treat it as an extreme value.
7053 (Fset_window_configuration, compare_window_configurations):
7054 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7055
6511acf2
PE
7056 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7057 that can exceed INT_MAX. Check that EMACS_INT value is in range
7058 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7059 (match_limit): Don't assume that a fixnum can fit in 'int'.
7060
6511acf2 7061 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7062 exceed INT_MAX.
7063
6511acf2 7064 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7065 (Fvertical_motion): Don't wrap around LINES values that don't fit
7066 in 'int'. Instead, treat them as extreme values. This is good
7067 enough for windows, which can't have more than INT_MAX lines anyway.
7068
fcb901a7
LMI
70692011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7070
0f2f6b6d
LMI
7071 * Require libxml/parser.h to avoid compilation warning.
7072
fcb901a7
LMI
7073 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7074
7075 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7076 since this reportedly can destroy thread storage.
7077
6e20a0d4
CY
70782011-08-30 Chong Yidong <cyd@stupidchicken.com>
7079
7080 * syntax.c (find_defun_start): Update all cache variables if
7081 exiting early (Bug#9401).
7082
148ae00e
EZ
70832011-08-30 Eli Zaretskii <eliz@gnu.org>
7084
f6cfbd8f
EZ
7085 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7086
148ae00e
EZ
7087 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7088 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7089 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7090
7091 * term.c (tty_append_glyph): New function.
7092 (produce_stretch_glyph): Static function and its prototype deleted.
7093
a66cfb1c
SM
7094 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7095 Add prototypes.
148ae00e 7096
c4a07a4c
PE
70972011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7098
7099 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7100 when checking :margin (Bug#9390).
7101 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7102 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7103 so that the name doesn't mislead. All uses changed.
7104
6bc8cd65
JB
71052011-08-28 Johan Bockgård <bojohan@gnu.org>
7106
7107 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7108 set_tty_hooks.
7109
dca4927e
EZ
71102011-08-27 Eli Zaretskii <eliz@gnu.org>
7111
7112 * xdisp.c (move_it_to): Don't bail out early when reaching
7113 position beyond to_charpos, if we are scanning backwards.
7114 (move_it_vertically_backward): When DY == 0, make sure we get to
7115 the first character in the line after the newline.
7116
f2cad773
PE
71172011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7118
7119 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7120 (ccl_driver): Do not generate an out-of-range pointer.
7121 (Fccl_execute_on_string): Remove unnecessary check for
7122 integer overflow, noted by Stefan Monnier in
7123 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7124 Remove a FIXME that didn't need fixing.
7125 Simplify the newly-introduced buffer reallocation code.
7126
0cae2cdb
JB
71272011-08-27 Juanma Barranquero <lekktu@gmail.com>
7128
7129 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7130
5fc295a4 71312011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7132
70c60eb2 7133 Integer and memory overflow issues (Bug#9196).
726e0ab1 7134
d31850da
PE
7135 * doc.c (get_doc_string): Rework so that
7136 get_doc_string_buffer_size is the actual buffer size, rather than
7137 being 1 less than the actual buffer size; this makes xpalloc more
7138 convenient.
7139
a69fbedb
PE
7140 * image.c (x_allocate_bitmap_record, cache_image):
7141 * xselect.c (Fx_register_dnd_atom):
7142 Simplify previous changes by using xpalloc.
7143
fe5c5d37
PE
7144 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7145 since either will do and ptrdiff_t is convenient with xpalloc.
7146
0065d054
PE
7147 * charset.c (charset_table_size)
7148 (struct charset_sort_data.priority): Now ptrdiff_t.
7149 (charset_compare): Don't overflow if priorities differ greatly.
7150 (Fsort_charsets): Don't assume list length fits in int.
7151 Check for size-calculation overflow when allocating sort data.
7152 (syms_of_charset): Allocate an initial charset table that is
7153 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7154
7155 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7156
7157 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7158 The actual value is always <= INT_MAX, and leaving it unsigned made
7159 overflow checking harder.
7160
7161 * dispextern.h (struct glyph_matrix.rows_allocated)
7162 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7163 with xpalloc. The values are still always <= INT_MAX.
7164
7165 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7166
7167 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7168 (SAFE_NALLOCA): New macro.
7169
7170 * region-cache.c (struct boundary.pos, find_cache_boundary)
7171 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7172 (set_cache_region, invalidate_region_cache)
7173 (revalidate_region_cache, know_region_cache, region_cache_forward)
7174 (region_cache_backward, pp_cache):
7175 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7176 so that ptrdiff_t * can be passed to xpalloc.
7177 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7178 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7179 (pp_cache): Don't assume cache_len fits in int.
7180 * region-cache.h: Adjust extern decls to match.
7181
7182 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7183 EMACS_INT, since either will do, for xpalloc.
7184
7185 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7186 (xnmalloc, xnrealloc, xpalloc): New functions.
7187
726e0ab1
PE
7188 * bidi.c (bidi_shelve_header_size): New constant.
7189 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7190 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7191
51f30bc5 7192 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7193 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7194 (overlay_strings):
7195 Don't update size of array until after memory allocation succeeds,
7196 because xmalloc/xrealloc may not return.
0065d054
PE
7197 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7198 now that we have proper integer overflow checking.
7199 (record_overlay_string, overlay_strings): Catch overflows when
7200 calculating size of overlay_str_buf.
726e0ab1 7201
0065d054
PE
7202 * callproc.c (Fcall_process): Check for size overflow when
7203 calculating size of args2.
7204 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7205 Normally we prefer signed values, but sticking with ptrdiff_t would
7206 require adding more-complicated checks.
726e0ab1
PE
7207
7208 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7209 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7210 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7211 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7212
7213 * character.c (Fstring): Check for size-calculation overflow.
7214
7215 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7216 unnecessary integer overflow. Check for size overflow.
7217 (encode_coding_object): Don't update size until xmalloc succeeds.
7218
7219 * composite.c (get_composition_id): Check for overflow in glyph
7220 length calculations.
7221
7222 Integer and memory overflow fixes for display code.
7223 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7224 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7225 (scrolling_window): Check for overflow in size calculations.
7226 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7227 Don't assume glyph table len fits in int.
7228 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7229 (row_table_size): Now ptrdiff_t, not int.
7230 (scrolling_window): Avoid overflow in size calculations.
7231 Don't update size until allocation succeeds.
7232 * fns.c (concat): Check for overflow in size calculations.
7233 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7234 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7235 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7236
7237 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7238 (get_doc_string): Check for size calculation overflow.
7239 Don't update size until allocation succeeds.
7240 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7241 EMACS_INT, where ptrdiff_t will do.
7242 (Fsubstitute_command_keys): Check for string overflow.
7243
7244 * editfns.c (set_time_zone_rule): Don't assume environment length
7245 fits in int.
7246 (message_length): Now ptrdiff_t, not int.
7247 (Fmessage_box): Don't update size until allocation succeeds.
7248 Don't assume message length fits in int.
7249 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7250
0065d054
PE
7251 * emacs.c (main): Do not reallocate argv, since there is a null at
7252 the end that can be overwritten, and this way there's no need to
7253 worry about size-calculation overflow.
7254 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7255
7256 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7257 alloc succeeds.
7258 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7259
7260 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7261 (x_set_scroll_bar_width, x_figure_window_size):
7262 Check for integer overflow.
7263 (x_set_alpha): Do not assume XINT fits in int.
7264
7265 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7266 This is for the members text_lines, text_cols, total_lines, total_cols,
7267 where the system imposes an 'int' limit.
7268
7269 * fringe.c (Fdefine_fringe_bitmap):
7270 Don't update size until alloc works.
7271
7272 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7273 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7274
7275 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7276 Check for size-calculation overflow.
7277 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7278 do, as we prefer signed integers.
7279 (id_to_widget.max_size, id_to_widget.used)
7280 (xg_store_widget_in_map, xg_remove_widget_from_map)
7281 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7282 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7283 Use and return ptrdiff_t, not int.
7284 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7285 * gtkutil.h: Change prototypes to match the above.
7286
7287 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7288 are duplicate now that they've been promoted to lisp.h.
7289 (x_allocate_bitmap_record, x_alloc_image_color)
7290 (make_image_cache, cache_image, xpm_load):
7291 Don't update size until alloc is done.
7292 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7293 (x_detect_edges):
3256efce 7294 Check for size calculation overflow.
726e0ab1
PE
7295 (ct_colors_allocated_max): New constant.
7296 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7297 overflow.
3256efce 7298
726e0ab1
PE
7299 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7300 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7301 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7302 Use ptrdiff_t, not int, to count maps.
7303 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7304 calculations. Don't update size until allocation succeeds.
7305 Redo calculations to avoid overflow.
726e0ab1
PE
7306 * keyboard.h: Change prototypes to match the above.
7307
7308 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7309 to count maps.
7310 (current_minor_maps): Check for size calculation overflow.
7311 * keymap.h: Change prototypes to match the above.
7312
7313 * lread.c (read1, init_obarray): Don't update size until alloc done.
7314
7315 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7316 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7317
726e0ab1
PE
7318 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7319 Now ptrdiff_t, not int.
7320 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7321 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7322
7323 * process.c (Fnetwork_interface_list): Check for overflow
7324 in size calculation.
7325
7326 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7327
7328 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7329 overflow. Don't bother calling xmalloc when xrealloc will do.
7330
7331 * search.c (Freplace_match): Check for size calculation overflow.
7332 (Fset_match_data): Don't assume list lengths fit in 'int'.
7333
7334 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7335 for command line length. Do not attempt to address one before the
7336 beginning of an array, as that's not portable.
7337
7338 * term.c (max_frame_lines): Remove; unused.
7339 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7340 not int.
7341 (encode_terminal_code, calculate_costs): Check for size
7342 calculation overflow.
7343 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7344 table lengths and related sizes. Don't update size until alloc
7345 done. Redo calculations to avoid overflow.
7346 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7347
7348 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7349 subtracting pointers.
7350 (gobble_line): Check for overflow more carefully. Don't update size
7351 until alloc done.
7352
7353 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7354 Don't update size until alloc done.
7355 Redo size calculations to avoid overflow.
7356 Check for size calculation overflow.
0065d054 7357 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7358
7359 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7360 Use ptrdiff_t, not int, for sizes.
7361 (store_mode_line_noprop_char): Don't update size until alloc done.
7362
0065d054
PE
7363 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7364 Use ptrdiff_t, not int, for sizes.
7365 (Finternal_make_lisp_face, cache_face):
7366 Check for size calculation overflow.
7367 (cache_face): Treat size calculation overflows as if they were
7368 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7369
7370 * xfns.c (x_encode_text, x_set_name_internal)
7371 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7372 sizes, since they can exceed INT_MAX in size. Check for size
7373 calculation overflow.
7374
0065d054
PE
7375 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7376 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7377 Don't update size until alloc done.
7378
0065d054 7379 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7380 as sprintf is limited to int lengths.
1d526e2f 7381
252c5ee1
PE
7382 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7383 (X_LONG_MIN): New macros.
864d7ce7
PE
7384 Use them to make the following changes clearer.
7385 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7386 This change doesn't affect the value now, but it may help remind
7387 future maintainers not to raise the value too much later.
7388 (SELECTION_QUANTUM): Remove, replacing with ...
7389 (selection_quantum): ... new function, which avoids overflow.
7390 All uses changed.
7391 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7392 assumption that selection length fits in 'int'.
7393 (x_reply_selection_request, x_handle_selection_request)
7394 (x_get_window_property, receive_incremental_selection)
7395 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7396 (lisp_data_to_selection_data, clean_local_selection_data):
7397 Use ptrdiff_t, not int, to record length of selection.
7398 (x_reply_selection_request, x_get_window_property)
7399 (receive_incremental_selection, x_property_data_to_lisp):
7400 Redo calculations to avoid overflow.
7401 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7402 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7403 something.
7404 (x_get_window_property, receive_incremental_selection)
7405 (lisp_data_to_selection_data, x_property_data_to_lisp):
7406 Check for size-calculation overflow.
7407 (x_get_window_property, receive_incremental_selection)
7408 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7409 Don't store size until memory allocation succeeds.
7410 (x_get_window_property): Plug memory leak on memory exhaustion.
7411 Don't double-block input; malloc is safe here. Don't assume 2**34
7412 - 4 fits in unsigned long. Add an xassert to check
7413 XGetWindowProperty overflow. Be more careful about overflow
7414 calculations, and distinguish size from memory overflow better.
7415 (receive_incremental_selection): When tracing, don't assume
7416 unsigned int is less than INT_MAX.
7417 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7418 harmful) conversions of unsigned short to int.
7419 (lisp_data_to_selection_data): Don't assume that integers
7420 in the range -65535 through -1 fit in an X unsigned short.
7421 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7422 result parameters unless successful. Rely on cons_to_unsigned
7423 to report problems with elements; the old code wasn't right anyway.
7424 (x_check_property_data): Check for int overflow; we cannot use
7425 a wider type due to X limits.
7426 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7427
726e0ab1 7428 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7429
0065d054
PE
7430 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7431 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7432 (x_color_cells): Don't store size until memory allocation succeeds.
7433 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7434 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7435 (x_term_init): Don't assume length fits in int (sprintf is limited
7436 to int size).
bc18e09d 7437
ebfa62c0
PE
7438 Use ptrdiff_t for composition IDs.
7439 * character.c (lisp_string_width):
7440 * composite.c (composition_table_size, n_compositions)
7441 (get_composition_id, composition_gstring_from_id):
7442 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7443 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7444 * window.c (Frecenter):
7445 Use ptrdiff_t, not int, for composition IDs.
7446 * composite.c (get_composition_id): Check for integer overflow.
7447 * composite.h: Adjust prototypes to match the above changes.
7448
d3411f89
PE
7449 Use ptrdiff_t for hash table indexes.
7450 * category.c (hash_get_category_set):
7451 * ccl.c (ccl_driver):
7452 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7453 * coding.c (coding_system_charset_list, detect_coding_system):
7454 * coding.h (struct coding_system.id):
7455 * composite.c (get_composition_id, gstring_lookup_cache):
7456 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7457 * image.c (xpm_get_color_table_h):
7458 * lisp.h (hash_lookup, hash_put):
7459 * minibuf.c (Ftest_completion):
7460 Use ptrdiff_t for hash table indexes, not int (which is too
7461 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7462 32-bit --with-wide-int hosts).
7463
e097a6fa
PE
7464 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7465 Add a FIXME comment about memory leaks.
7466 (syms_of_charset): Don't assume xmalloc returns.
7467
5637687f
PE
7468 Don't assume that stated character widths fit in int.
7469 * character.c (Fchar_width, c_string_width, lisp_string_width):
7470 * character.h (CHAR_WIDTH):
7471 * indent.c (MULTIBYTE_BYTES_WIDTH):
7472 Use sanitize_char_width to avoid undefined and/or bad behavior
7473 with outlandish widths.
a66cfb1c 7474 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7475 now that we have two such functions. All uses changed.
7476 (sanitize_char_width): New inline function.
7477
a2271ba2
PE
7478 Don't assume that tab-width fits in int.
7479 * character.h (sanitize_width): New inline function.
7480 (SANE_TAB_WIDTH): New macro.
7481 (ASCII_CHAR_WIDTH): Use it.
7482 * indent.c (sane_tab_width): Remove. All uses replaced by
7483 SANE_TAB_WIDTH (current_buffer).
7484 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7485
18c52557
PE
7486 * fileio.c: Integer overflow issues with file modes.
7487 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7488
caeeedc1
PE
7489 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7490 Remove unreachable code.
7491 (read_hex, load_charset_map_from_file): Check for integer overflow.
7492
6df6ae42 7493 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7494 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7495 (x_send_scroll_bar_event): Likewise. Check that the size does not
7496 exceed limits imposed by XClientMessageEvent, as well as the usual
7497 ptrdiff_t and size_t limits.
7498
b13995db
PE
7499 * keyboard.c: Overflow, signedness and related fixes.
7500 (make_lispy_movement): Use same integer type in forward decl
7501 that is used in the definition.
7502 (read_key_sequence, keyremap_step):
7503 Change bufsize argument back to int, undoing my 2011-03-30 change.
7504 We prefer signed types, and int is wide enough here.
7505 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7506 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7507 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7508 length, not size_t. Use ptrdiff_t for index, not int.
7509 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7510 possibility of integer overflow.
7511
13464394
PE
7512 Overflow, signedness and related fixes for images.
7513
7514 * dispextern.h (struct it.stack[0].u.image.image_id)
7515 (struct_it.image_id, struct image.id, struct image_cache.size)
7516 (struct image_cache.used, struct image_cache.ref_count):
7517 * gtkutil.c (update_frame_tool_bar):
7518 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7519 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7520 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7521 * nsmenu.m (update_frame_tool_bar):
7522 * xdisp.c (calc_pixel_width_or_height):
7523 * xfns.c (image_cache_refcount):
7524 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7525 on typical 64-bit hosts.
7526
7527 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7528 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7529 Omit unnecessary casts to int.
7530 (parse_image_spec): Check that integers fall into 'int' range
7531 when the callers expect that.
7532 (image_ascent): Redo ascent calculation to avoid int overflow.
7533 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7534 (lookup_image): Remove unnecessary tests.
7535 (xbm_image_p): Locals are now of int, not EMACS_INT,
7536 since parse_image_check makes sure they fit into int.
7537 (png_load, gif_load, svg_load_image):
7538 Prefer int to unsigned where either will do.
7539 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7540 old tiff_error_handler and tiff_warning_handler.
7541 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7542 stack buffer overflows. It uses only the features of vsnprintf
7543 that are common to both POSIX and native Microsoft.
7544 (tiff_error_handler, tiff_warning_handler): Use it.
7545 (tiff_load, gif_load, imagemagick_load_image):
7546 Don't assume :index value fits in 'int'.
7547 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7548 (imagemagick_load_image): Check that crop parameters fit into
7549 the integer types that MagickCropImage accepts. Don't assume
7550 Vimagemagick_render_type has a nonnegative value. Don't assume
7551 size_t fits in 'long'.
7552 (gs_load): Use printmax_t to print the widest integers possible.
7553 Check for integer overflow when computing image height and width.
7554
c11821d4
EZ
75552011-08-26 Eli Zaretskii <eliz@gnu.org>
7556
7557 * xdisp.c (redisplay_window): Don't force window start if point
7558 will be invisible in the resulting window. (Bug#9324)
7559
0c95fcf7
EZ
75602011-08-25 Eli Zaretskii <eliz@gnu.org>
7561
7562 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7563 the display spec is of the form `(space ...)'.
7564 (handle_display_spec): Return the value returned by
7565 handle_single_display_spec, not just 1 or zero.
7566 (handle_single_display_spec): If the display spec is of the form
7567 `(space ...)', and specifies display in the text area, return 2
7568 rather than 1.
fee65a97 7569 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7570 accurately, and prefer exact match for point under bidi.
7571 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7572
7573 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7574 into disp_prop; all users changed.
7575
7576 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7577 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7578 for the text covered by the display property.
7579
e4ed06f1
CY
75802011-08-25 Chong Yidong <cyd@stupidchicken.com>
7581
7582 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7583 Change return value to nil.
7584 (Frecord_buffer): Delete unused function.
7585
f67cdd7f
EZ
75862011-08-24 Eli Zaretskii <eliz@gnu.org>
7587
5980d4c6
EZ
7588 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7589 buffers, return left-to-right.
8610fe8b
EZ
7590 (set_cursor_from_row): Consider candidate row a win if its glyph
7591 represents a newline and point is on that newline. Fixes cursor
7592 positioning on the newline at EOL of R2L text within L2R
7593 paragraph, and vice versa.
7594 (try_cursor_movement): Check continued rows, in addition to
7595 continuation rows. Fixes unwarranted scroll when point enters a
7596 continued line of R2L text within an L2R paragraph, or vice versa.
7597 (cursor_row_p): Consider the case of point being equal to
7598 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7599 from the end of a short line to the beginning of a continued line
7600 of R2L text within L2R paragraph.
7601 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7602 composed characters.
5980d4c6 7603
f67cdd7f
EZ
7604 * bidi.c (bidi_check_type): Use xassert.
7605 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7606 members.
7607
bca633fb
EZ
76082011-08-23 Eli Zaretskii <eliz@gnu.org>
7609
7610 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7611 a character.
7612
4a5885a7
CY
76132011-08-23 Chong Yidong <cyd@stupidchicken.com>
7614
7615 * nsfont.m (ns_otf_to_script): Fix typo.
7616
0902a04e
KH
76172011-08-22 Kenichi Handa <handa@m17n.org>
7618
7619 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7620 extra slot even if the purpose is char-code-property-table.
7621
1a2e6670
EZ
76222011-08-23 Eli Zaretskii <eliz@gnu.org>
7623
8ddde651
EZ
7624 * xdisp.c (redisplay_window): When computing centering_position,
7625 account for the height of the header line. (Bug#8874)
7626
425cc014
EZ
7627 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7628 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7629 candidate is selected by the mouse, and that candidate has a
7630 composed character under the mouse.
7631
1a2e6670
EZ
7632 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7633 coordinates reported by pos-visible-in-window-p for a composed
7634 character in column zero.
7635
8b76d6f8
SM
76362011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7637
7638 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7639
dac347dd
EZ
76402011-08-22 Eli Zaretskii <eliz@gnu.org>
7641
7642 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7643 consider it a hit if to_charpos is anywhere in the range of the
7644 composed buffer positions.
7645
e013fb34
CY
76462011-08-22 Chong Yidong <cyd@stupidchicken.com>
7647
7648 * image.c (gif_load): Don't assume that each subimage has the same
7649 dimensions as the base image. Handle disposal method that is
7650 "undefined" by the gif spec (Bug#9335).
7651
bd1ba3e8
CY
76522011-08-20 Chong Yidong <cyd@stupidchicken.com>
7653
7654 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7655 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7656
54a1215b
EZ
76572011-08-19 Eli Zaretskii <eliz@gnu.org>
7658
823564e5
EZ
7659 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7660 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7661 from an Org mode buffer to a Speedbar frame.
7662
54a1215b
EZ
7663 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7664 a composition, take its buffer position from IT->cmp_it.charpos.
7665 Fixes cursor positioning at the beginning of a line that begins
7666 with a composed character.
7667
9778ebcc
EZ
76682011-08-18 Eli Zaretskii <eliz@gnu.org>
7669
0be6ee06
EZ
7670 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7671 character bidirectional type, use STRONG_L instead. Fixes crashes
7672 in a buffer produced by `describe-categories'.
7673
9778ebcc
EZ
7674 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7675 members before the level stack, so they would be saved and
7676 restored when copying iterator state. Fixes incorrect reordering
7677 around TABs covered by display properties.
7678
156bffbe
AS
76792011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7680
6b02f655 7681 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7682
72ad093b
CY
76832011-08-17 Chong Yidong <cyd@stupidchicken.com>
7684
7685 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7686 (internal_condition_case_2, internal_condition_case_n):
7687 Remove unnecessary aborts (Bug#9081).
72ad093b 7688
35774242
EZ
76892011-08-17 Eli Zaretskii <eliz@gnu.org>
7690
7691 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7692 has no `load' handler, try opening the file locally. (Bug#9311)
7693
db76dd85
KB
76942011-08-16 Ken Brown <kbrown@cornell.edu>
7695
7696 * gmalloc.c: Expand comment.
7697
b215eee5
EZ
76982011-08-16 Eli Zaretskii <eliz@gnu.org>
7699
7700 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7701 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7702
a4579d33
KB
77032011-08-16 Ken Brown <kbrown@cornell.edu>
7704
7705 Fix memory allocation problems in Cygwin build (Bug#9273).
7706
7707 * unexcw.c ( __malloc_initialized): Declare external variable.
7708 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7709
8b76d6f8
SM
7710 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7711 New variables.
a4579d33
KB
7712 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7713 dumped emacs.
7714 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7715 in the static heap.
7716 [CYGWIN] (special_realloc): New function.
7717 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7718 requests to realloc storage in the static heap.
7719
3ebec551
PE
77202011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7721
7722 * bidi.c (bidi_initialize): Remove unused local.
7723
9fd8be00
EZ
77242011-08-15 Eli Zaretskii <eliz@gnu.org>
7725
6b02f655
SM
7726 * bidimirror.h:
7727 * biditype.h: Remove file.
7728 * makefile.w32-in ($(BLD)/bidi.$(O)):
7729 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7730
7731 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7732
7733 * chartab.c: Improve commentary for the uniprop_table API.
7734
32413314
EZ
7735 * bidi.c (bidi_paragraph_init): Support zero value of
7736 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7737 (bidi_initialize): Use uniprop_table instead of including
7738 biditype.h and bidimirror.h.
32413314 7739
9fd8be00
EZ
7740 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7741 coordinates of the iterator when restoring from ppos_it.
7742 (Bug#9296)
7743
5cf2b69b
KH
77442011-08-14 Kenichi Handa <handa@m17n.org>
7745
7746 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7747 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7748
daf17d00
EZ
77492011-08-14 Eli Zaretskii <eliz@gnu.org>
7750
7751 * xdisp.c (move_it_in_display_line_to): Don't invoke
7752 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7753 ppos_it. Fixes vertical cursor motion when line beginning is
7754 covered by an image. (Bug#9296)
7755
08e3161a
JD
77562011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7757
7758 * nsterm.h (ns_run_ascript): Declare.
7759 (NSAPP_DATA2_RUNASSCRIPT): Define.
7760
7761 * nsfns.m (as_script, as_result, as_status): New static variables.
7762 (ns_run_ascript): New function.
5e617bc2 7763 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7764 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7765 the event loop. Get status from as_status (Bug#7276).
7766
7767 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7768 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7769 the event loop (Bug#7276).
7770
a3720aa2
AS
77712011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7772
7773 * gnutls.c (QCgnutls_bootprop_priority)
7774 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7775 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7776 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7777 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7778 (QCgnutls_bootprop_verify_hostname_error)
7779 (QCgnutls_bootprop_callbacks_verify): Rename from
7780 Qgnutls_bootprop_..., all uses changed.
7781
7782 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7783 uses changed.
7784
0a0d27fb
PE
77852011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7786
19d5c50c
PE
7787 * xfaces.c (Qframe_set_background_mode): Now static.
7788 * dispextern.h (Qframe_set_background_mode): Remove decl.
7789
0a0d27fb
PE
7790 * process.c (Fnetwork_interface_info): Declare local only if needed.
7791
377538cb
JD
77922011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7793
7794 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7795 (Fnetwork_interface_list): Allocate in increments of bytes instead
7796 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7797 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7798 sockaddr.
7799 (struct ifflag_def): notrailers is smart on OSX.
7800 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7801 Get hardware address with getifaddrs if available.
7802
08fff70c
EZ
78032011-08-12 Eli Zaretskii <eliz@gnu.org>
7804
7805 * xdisp.c (iterate_out_of_display_property): xassert that
7806 IT->position is set to within IT->object's boundaries. Break from
7807 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7808 when IT->position is set up wrongly due to some bug.
7809 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7810 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7811 entry. Force push_it to save on the stack the current
7812 buffer/string position, to be restored by pop_it. Fix flags in
7813 the iterator structure wrt the object coming from a display
7814 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7815 properties. (Bug#9284)
7816
7be1c708 78172011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7818
7be1c708
CY
7819 * fontset.c (fontset_get_font_group): Add proper type checks.
7820 (Bug#9172)
aac0c6e3 7821
7be1c708 78222011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7823
7be1c708
CY
7824 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7825 and LC_VERSION_MIN_MACOSX.
7826 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7827 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7828
97bb72a6
EZ
78292011-08-08 Eli Zaretskii <eliz@gnu.org>
7830
7831 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7832 no-display-properties-and-no-overlays under bidi display.
7833 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7834 properties and overlays.
97bb72a6 7835
d5617611
CY
78362011-08-08 Chong Yidong <cyd@stupidchicken.com>
7837
37e11a63
CY
7838 * editfns.c (Fset_time_zone_rule): Document relationship with the
7839 setenv function.
7840
d5617611
CY
7841 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7842 the font entity extracted from the cache (Bug#8109).
7843
58872834
CY
78442011-08-07 Chong Yidong <cyd@stupidchicken.com>
7845
7846 * composite.c (autocmp_chars): Don't reset point. That is done by
7847 restore_point_unwind (Bug#5984).
7848
75bfc667
JL
78492011-08-07 Juri Linkov <juri@jurta.org>
7850
7851 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7852 to show the arg `TIME' instead of `TIMEVAL'.
7853
d1410150
EZ
78542011-08-06 Eli Zaretskii <eliz@gnu.org>
7855
7856 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7857 display property strides EOL and includes a newline, as in
7858 longlines-mode. (Bug#9254)
75b771e4
EZ
7859 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7860 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7861
7862 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7863 is non-zero, even if the data buffer is NULL. Fixes a crash in
7864 vertical-motion with longlines-mode. (Bug#9254)
7865
35928349
EZ
78662011-08-05 Eli Zaretskii <eliz@gnu.org>
7867
ec7cc85b
EZ
7868 * bidi.c <bidi_cache_total_alloc>: Now static.
7869 (bidi_initialize): Initialize bidi_cache_total_alloc.
7870
8b76d6f8 7871 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7872 cache. (Bug#9221)
7873
7874 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7875 amount allocated this far in `bidi_cache_total_alloc'.
7876 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7877 non-zero, only free the data buffer without restoring the cache
7878 contents. All callers changed.
7879
7880 * dispextern.h (bidi_unshelve_cache): Update prototype.
7881
7882 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7883 (move_it_in_display_line, move_it_to)
7884 (move_it_vertically_backward, move_it_by_lines): Replace the call
7885 to xfree to an equivalent call to bidi_unshelve_cache.
7886 (move_it_in_display_line_to): Fix logic of returning
412b6358 7887 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7888
e2e2423b
EZ
78892011-08-05 Eli Zaretskii <eliz@gnu.org>
7890
7891 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7892 came from a string character with a `cursor' property. (Bug#9229)
7893
ae9e757a
JD
78942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7895
7896 * Makefile.in (LIB_PTHREAD): New variable.
7897 (LIBES): Add LIB_PTHREAD (Bug#9216).
7898
7899 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7900 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7901
213bd7f2
AS
79022011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7903
6b02f655 7904 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7905
99aaf75f
JD
79062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7907
7908 * xterm.c (x_find_topmost_parent): New function.
7909 (x_set_frame_alpha): Find topmost parent window with
7910 x_find_topmost_parent and set the property there also (bug#9181).
7911 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7912
c74e9d86
PE
79132011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7914
7915 * callproc.c (Fcall_process): Avoid vfork clobbering
7916 the local vars buffer, coding_systems, current_dir.
7917
640c8776
SM
79182011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7919
7920 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7921
f26d0e4c
PE
79222011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7923
8a10d76c
PE
7924 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7925 so that it is not optimized away.
7926
f26d0e4c
PE
7927 * xdisp.c (compute_display_string_pos): Remove unused local.
7928
55439c61
EZ
79292011-08-02 Eli Zaretskii <eliz@gnu.org>
7930
7931 Fix slow cursor motion and scrolling in large buffers with
7932 selective display, like Org Mode buffers. (Bug#9218)
7933
7934 * dispextern.h (struct bidi_it): New member disp_prop_p.
7935
7936 * xdisp.c: Remove one-slot cache of display string positions.
7937 (compute_display_string_pos): Accept an additional argument
5e617bc2 7938 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7939 for a display string or property. If found, set DISP_PROP_P
7940 non-zero.
7941
7942 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7943 DISP_PROP_P, and pass it to compute_display_string_pos.
7944 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7945 non-zero. All callers of bidi_fetch_char changed.
7946
fb33fa43
SM
79472011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7948
7949 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7950
b099e063
DM
79512010-12-03 Don March <don@ohspite.net>
7952
7953 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7954 last character M-[char] is translated to ESC [char] (bug#7541).
7955
5cc7f7af
KH
79562011-08-02 Kenichi Handa <handa@m17n.org>
7957
d0fffa3f 7958 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7959
7960 * chartab.c (uniprop_table): Make it non-static.
7961
525d5e6e
EZ
79622011-08-01 Eli Zaretskii <eliz@gnu.org>
7963
7964 * xdisp.c (forward_to_next_line_start): Accept additional argument
7965 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7966 on the newline.
7967 (reseat_at_next_visible_line_start): Use the bidi iterator state
7968 returned by forward_to_next_line_start to restore the state of
7969 it->bidi_it after backing up to previous newline. (Bug#9212)
7970
31011111
AS
79712011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7972
7973 * regex.c (re_comp): Protoize.
7974 (re_exec): Fix return type.
7975 (regexec): Fix type of `ret'. (Bug#9203)
7976
476371c4
PE
79772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7978
e5d76069
PE
7979 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7980 This is needed if max-image-size is a floating-point number.
7981
9a79b20c
AS
79822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7983
7984 * print.c (print_object): Print empty symbol as ##.
7985
7986 * lread.c (read1): Read ## as empty symbol.
7987
d8c2fa78
AA
79882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7989
7990 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7991 setting frame foreground color (Bug#9175).
7992 (x_set_background_color): Likewise.
7993
ffe57a7a
AA
7994 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7995 contents (Bug#9176).
7996 (EmacsTooltip -init): Remove bezels and add shadows to
7997 tooltip windows.
7998
bf3492a5
AA
7999 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8000 or scroll bar (Bug#8470).
8001
d55e9c53
AA
8002 * nsfont.m (nsfont_open): Remove assignment to voffset and
8003 unnecessary vars hshink, expand, hd, full_height, min_height.
8004 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8005
8006 * nsterm.h (nsfont_info): Remove voffset field.
8007
d8c2fa78 80082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8009
8010 Implement strike-through and overline on NextStep (Bug#8863).
8011
8012 * nsfont.m (nsfont_open): Use underline position provided by font,
8013 instead of hard-coded value of 2.
8014 (nsfont_draw): Call ns_draw_text_decoration instead.
8015
8016 * nsterm.h: Add declaration for ns_draw_text_decoration.
8017
8018 * nsterm.m (ns_draw_text_decoration): New function for drawing
8019 underline, overline, and strike-through.
8020 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8021 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8022 accommodate underlining, etc.
4843aac3 8023
4cc60b9b
EZ
80242011-07-28 Eli Zaretskii <eliz@gnu.org>
8025
bc7ece87
EZ
8026 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8027 default.
4cc60b9b 8028
476371c4
PE
80292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8030
66606eea
PE
8031 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8032 Without this fix, if a signal arrives just after memory fills up,
8033 'malloc' might be invoked reentrantly.
8034
476371c4
PE
8035 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8036 In other words, assume that every image size is allowed, on non-X
8037 hosts. This assumption is probably wrong, but it lets Emacs compile.
8038
f3fcc40d
AS
80392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8040
8041 * regex.c (re_iswctype): Convert return values to boolean.
8042
350c992f
EZ
80432011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8044
8045 * xdisp.c (compute_display_string_pos): Don't use cached display
8046 string position if the buffer had its restriction changed.
8047 (Bug#9184)
8048
5266b4bb
PE
80492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8050
8051 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8052
2573a837 80532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8054
41f55ccd 8055 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8056
39e378da
PE
8057 * bidi.c: Integer size and overflow fixes.
8058 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8059 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8060 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8061 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8062 (bidi_find_other_level_edge):
8063 Use ptrdiff_t instead of EMACS_INT where either will do.
8064 This works better on 32-bit hosts configured --with-wide-int.
8065 (bidi_cache_ensure_space): Check for size-calculation overflow.
8066 Use % rather than repeated addition, for better worst-case speed.
8067 Don't set bidi_cache_size until after xrealloc returns, because it
8068 might not return.
8069 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8070 (bidi_cache_ensure_space): Also check that the bidi cache size
8071 does not exceed that of the largest Lisp string or buffer. See Eli
8072 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8073
5e927815
PE
8074 * alloc.c (__malloc_size_t): Remove.
8075 All uses replaced by size_t. See Andreas Schwab's note
8076 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8077
ca4aa935
PE
8078 * image.c: Improve checking for integer overflow.
8079 (check_image_size): Assume that f is nonnull, since
8080 it is always nonnull in practice. This is one less thing to
8081 worry about when checking for integer overflow later.
8082 (x_check_image_size): New function, which checks for integer
8083 overflow issues inside X.
8084 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8085 This removes the need for a memory_full check.
8086 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8087 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8088 (xbm_read_bitmap_data): Change locals back to 'int', since
8089 their values must fit in 'int'.
8090 (xpm_load_image, png_load, tiff_load):
8091 Invoke x_create_x_image_and_pixmap earlier,
8092 to avoid much needless work if the image is too large.
8093 (tiff_load): Treat overly large images as if
8094 x_create_x_image_and_pixmap failed, not as malloc failures.
8095 (gs_load): Use x_check_image_size.
8096
5f8f9cc2
PE
8097 * gtkutil.c: Omit integer casts.
8098 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8099 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8100
5adf60bc
PE
8101 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8102
c8907a93
PE
8103 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8104 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8105 would wrongly return t on a 64-bit host.
8106
e3c25c68
PE
8107 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8108 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8109 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8110 and therefore cause GCC to emit a bogus diagnostic in some cases.
8111
3f791afe
PE
8112 * image.c: Integer signedness and overflow and related fixes.
8113 This is not an exhaustive set of fixes, but it's time to
8114 record what I've got.
8115 (lookup_pixel_color, check_image_size): Remove redundant decls.
8116 (check_image_size): Don't assume that arbitrary EMACS_INT values
8117 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8118 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8119 (tiff_load, imagemagick_load_image):
8120 Check for overflow in size calculations.
8121 (x_create_x_image_and_pixmap): Remove unnecessary test for
8122 xmalloc returning NULL; that can't happen.
8123 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8124 (xpm_color_bucket): Use better integer hashing function.
8125 (xpm_cache_color): Don't possibly over-allocate memory.
8126 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8127 (gif_memory_source):
8128 Use ptrdiff_t, not int or size_t, to record sizes.
8129 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8130 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8131 either works, as we prefer signed integers.
8132 (tiff_read_from_memory, tiff_write_from_memory):
8133 Return tsize_t, not size_t, since that's what the TIFF API wants.
8134 (tiff_read_from_memory): Don't fail simply because the read would
8135 go past EOF; instead, return a short read.
8136 (tiff_load): Omit no-longer-needed casts.
8137 (Fimagemagick_types): Don't assume size fits into 'int'.
8138
3cc5a532
PE
8139 Improve hashing quality when configured --with-wide-int.
8140 * fns.c (hash_string): New function, taken from sxhash_string.
8141 Do not discard information about ASCII character case; this
8142 discarding is no longer needed.
8143 (sxhash-string): Use it. Change sig to match it. Caller changed.
8144 * lisp.h: Declare it.
8145 * lread.c (hash_string): Remove, since we now use fns.c's version.
8146 The fns.c version returns a wider integer if --with-wide-int is
8147 specified, so this should help the quality of the hashing a bit.
8148
b312a492
PE
8149 * emacs.c: Integer overflow minor fix.
8150 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8151 Define only if GNU_LINUX.
8152 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8153
dfd153ae
PE
8154 * dispnew.c: Integer signedness and overflow fixes.
8155 Remove unnecessary forward decls, that were a maintenance hassle.
8156 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8157 All uses changed.
8158 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8159 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8160 (prepare_desired_row, line_draw_cost):
8161 Use int, not unsigned, where either works.
8162 (save_current_matrix, restore_current_matrix):
8163 Use ptrdiff_t, not size_t, where either works.
8164 (init_display): Check for overflow more accurately, and without
8165 relying on undefined behavior.
8166
a81d11a3
PE
8167 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8168 Remove, replacing with the new symbols in lisp.h. All uses changed.
8169 * fileio.c (make_temp_name):
8170 * filelock.c (lock_file_1, lock_file):
8171 * xdisp.c (message_dolog):
8172 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8173 Use pMd etc. instead.
8174 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8175 replacing the pWIDE etc. symbols removed from editfns.c.
8176
3300e6fd
PE
8177 * keyboard.h (num_input_events): Now uintmax_t.
8178 This is (very slightly) less likely to mess up due to wraparound.
8179 All uses changed.
8180
fd05c7e9
PE
8181 * buffer.c: Integer signedness fixes.
8182 (alloc_buffer_text, enlarge_buffer_text):
8183 Use ptrdiff_t rather than size_t when either will do, as we prefer
8184 signed integers.
8185
903fe15d
PE
8186 * alloc.c: Integer signedness and overflow fixes.
8187 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8188 (__malloc_size_t): Default to size_t, not to int.
8189 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8190 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8191 Prefer ptrdiff_t to size_t when either would do, as we prefer
8192 signed integers.
8193 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8194 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8195 Now const. Initialize with values that are in range even if char
8196 is signed.
8197 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8198 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8199 These functions do the right thing with sizes > 2**32.
8200 (check_depth): Now ptrdiff_t, not int.
8201 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8202 Adjust to new way of storing sizes. Check for size overflow bugs
8203 in rest of code.
8204 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8205 slightly wrong anyway, as it missed one instance of
8206 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8207 (refill_memory_reserve): Omit needless cast to size_t.
8208 (mark_object_loop_halt): Mark as externally visible.
8209
ac82cc6a
PE
8210 * xselect.c: Integer signedness and overflow fixes.
8211 (Fx_register_dnd_atom, x_handle_dnd_message):
8212 Use ptrdiff_t, not size_t, since we prefer signed.
8213 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8214 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8215 x_dnd_atoms_size and x_dnd_atoms_length.
8216
c2d1e36d
PE
8217 * doprnt.c: Prefer signed to unsigned when either works.
8218 * eval.c (verror):
8219 * doprnt.c (doprnt):
8220 * lisp.h (doprnt):
8221 * xdisp.c (vmessage):
8222 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8223 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8224 prefer signed arithmetic to avoid comparison confusion.
8225 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8226 but is a bit tricky.
8227
0e926e56
PE
8228 Assume freestanding C89 headers, string.h, stdlib.h.
8229 * data.c, doprnt.c, floatfns.c, print.c:
8230 Include float.h unconditionally.
8231 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8232 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8233 * regex.c: Likewise for stddef.h, string.h.
8234 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8235 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8236 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8237 (STDC_HEADERS): Remove obsolete defines.
8238 * sysdep.c: Include limits.h unconditionally.
8239
9cfdb3ec
PE
8240 Assume support for memcmp, memcpy, memmove, memset.
8241 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8242 * regex.c (memcmp, memcpy):
8243 Remove; we assume C89 now.
8244
8245 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8246 (__malloc_safe_bcopy): Remove; no longer needed.
8247
cf950e6b 8248 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8249 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8250 well either way, and we prefer signed to unsigned.
8251
dbf38e02
LMI
82522011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8253
8254 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8255 closes the connection while we're reading (bug#9182).
8256
d6f0886c 82572011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8258
d6f0886c
JD
8259 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8260 are specified (Bug#9168).
24e0f6b1 8261
2eb1f9e6
PE
82622011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8263
8264 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8265 Found by GCC static checking and --with-wide-int on a 32-bit host.
8266
22381272 82672011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8268
8269 * xdisp.c (compute_display_string_pos): Fix logic of caching
8270 previous display string position. Initialize cached_prev_pos to
8271 -1. Fixes slow-down at the beginning of a buffer.
8272
f25e39b4
EZ
82732011-07-24 Eli Zaretskii <eliz@gnu.org>
8274
8275 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8276 for attrs[LFACE_FONTSET_INDEX].
8277
04c4b52e
PE
82782011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8279
8280 * xml.c (parse_region): Remove unused local
8281 that was recently introduced.
8282
c1734fbd
EZ
82832011-07-23 Eli Zaretskii <eliz@gnu.org>
8284
be18c5a5
EZ
8285 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8286 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8287
c1734fbd
EZ
8288 * xdisp.c (move_it_in_display_line_to): Record the best matching
8289 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8290 exit if none of the characters scanned was an exact match.
8291 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8292 when exact match is impossible due to invisible text, and the
8293 lines are truncated.
8294
a258d627
JD
82952011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8296
8297 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8298 for OSX >= 10.7.
8299
b6d5a689
EZ
83002011-07-22 Eli Zaretskii <eliz@gnu.org>
8301
0f74f785
EZ
8302 Fix a significant slow-down of cursor motion with C-n, C-p,
8303 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8304 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8305 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8306 (next_element_from_buffer): Call compute_stop_pos_backwards to
8307 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8308 base_level_stop.
8309 (reseat): Don't look for prev_stop, as that could mean a very long
8310 run.
8311 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8312 <cached_disp_overlay_modiff>: Cache for last found display string
8313 position.
551918c1 8314 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8315 about the same buffer in the same area of character positions, and
8316 the buffer wasn't changed since the time the display string
8317 position was cached.
551918c1 8318
b2d0c91a
EZ
83192011-07-22 Eli Zaretskii <eliz@gnu.org>
8320
8321 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8322 is an integer, which is important for empty lines. (Bug#9149)
8323
043604ee
CY
83242011-07-22 Chong Yidong <cyd@stupidchicken.com>
8325
8326 * frame.c (Fmodify_frame_parameters): In tty case, update the
8327 default face if necessary (Bug#4238).
8328
da4adb04
CY
83292011-07-21 Chong Yidong <cyd@stupidchicken.com>
8330
8331 * editfns.c (Fstring_to_char): No need to explain what a character
8332 is in the docstring (Bug#6576).
8333
9abd0532
LMI
83342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8335
8336 * xml.c (parse_region): Make sure we always return a tree.
8337
36881d16
HK
83382011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8339
8340 * xml.c (parse_region): If a document contains only comments,
8341 return that, too.
8342
1e98674d
LMI
83432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8344
8345 * xml.c (make_dom): Return comments, too.
8346
590bd467
PE
83472011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8348
8349 Port to OpenBSD.
8350 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8351 and the surrounding thread.
8352 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8353 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8354 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8355 timer goes off.
8356 * s/openbsd.h (BROKEN_SIGIO): Define.
8357 * unexelf.c (unexec) [__OpenBSD__]:
8358 Don't update the .mdebug section of the Alpha COFF symbol table.
8359
f41628b2
LMI
83602011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8361
8362 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8363 (bug#8460).
8364
b59b67c5
PE
83652011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8366
15e3a074
PE
8367 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8368 This fixes some race conditions on the permissions of any newly
8369 created file.
8370
41bed37d
PE
8371 * alloc.c (valid_pointer_p): Use pipe, not open.
8372 This fixes some permissions issues when debugging.
8373
b59b67c5
PE
8374 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8375 If fchown fails to set both uid and gid, try to set just gid,
8376 as that is sometimes allowed. Adjust the file's mode to eliminate
8377 setuid or setgid bits that are inappropriate if fchown fails.
8378
925a6be7
SM
83792011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8380
8381 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8382 to compare Lisp_Objects.
8383 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8384 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8385 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8386
52968808
AS
83872011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8388
0a6a104b
AS
8389 * lread.c (read_integer): Unread even EOF character.
8390 (read1): Likewise. Properly record start position of symbol.
8391
52968808
AS
8392 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8393 symbol character follows.
8394
9e381cdd
PE
83952011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8396
8397 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8398 This works around a problem with the previous change to Fcopy_file.
8399 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8400 and without this change, GCC might complain about discarding
8401 fchown's return value.
8402
b5641435
JB
84032011-07-16 Juanma Barranquero <lekktu@gmail.com>
8404
8405 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8406
a8031457
PE
84072011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8408
8409 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8410
dd889327
LMI
84112011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8412
750c33f7
LMI
8413 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8414 it's used from the C level.
8415
dd889327
LMI
8416 * process.c: Use the same condition for POLL_FOR_INPUT in both
8417 keyboard.c and process.c (bug#1858).
8418
87e86684
LM
84192011-07-09 Lawrence Mitchell <wence@gmx.li>
8420
8421 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8422 (Fgnutls_boot): Use it.
8423
64348f40
AS
84242011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8425
8426 * doc.c (Fsubstitute_command_keys): Revert last change.
8427
1d698799
LMI
84282011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8429
f863868c
LMI
8430 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8431 quotes the next character, and doesn't affect other longer
8432 sequences (bug#8935).
8433
1d698799
LMI
8434 * lread.c (syms_of_lread): Clarify that is isn't only
8435 `eval-buffer' and `eval-defun' that's affected by
8436 `lexical-binding' (bug#8460).
8437
aa4b6df6
EZ
84382011-07-15 Eli Zaretskii <eliz@gnu.org>
8439
8440 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8441 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8442
5d856da6
PE
84432011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8444
ad6042bb
PE
8445 Fix minor problems found by static checking.
8446 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8447 (elsz): Now a signed constant, not a size_t var. We prefer signed
8448 types to unsigned, to avoid integer comparison confusion. Without
8449 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8450 "cannot optimize loop, the loop counter may overflow", a symptom
8451 of the confusion.
f00bbb22 8452 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8453 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8454
6468f31c
LMI
84552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8456
49080b10
LMI
8457 * search.c (Fre_search_backward): Mention `case-fold-search' in
8458 all the re_search_* functions (bug#8138).
8459
6468f31c
LMI
8460 * keyboard.c (Fopen_dribble_file): Document when the file is
8461 closed (bug#8056).
8462
c965adc5
EZ
84632011-07-14 Eli Zaretskii <eliz@gnu.org>
8464
df9733bf
EZ
8465 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8466 bidi_cache_idx.
8467
0bb23927
EZ
8468 Support bidi reordering of display and overlay strings.
8469 * xdisp.c (compute_display_string_pos)
8470 (compute_display_string_end): Accept additional argument STRING.
8471 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8472 (reseat_to_string): Initialize bidi_it->string.s and
8473 bidi_it->string.schars.
8474 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8475 NULL (avoids a crash in bidi_paragraph_init).
8476 Initialize itb.string.lstring.
0bb23927
EZ
8477 (init_iterator): Call bidi_init_it only of a valid
8478 buffer position was specified. Initialize paragraph_embedding to
8479 L2R.
8480 (reseat_to_string): Initialize the bidi iterator.
8481 (display_string): If we need to ignore text properties of
8482 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8483 original value of -1 will not work with bidi.)
8484 (compute_display_string_pos): First arg is now struct
8485 `text_pos *'; all callers changed. Support display properties on
8486 Lisp strings.
8487 (compute_display_string_end): Support display properties on Lisp
8488 strings.
8489 (init_iterator, reseat_1, reseat_to_string): Initialize the
8490 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8491 when iterating on a string not from display properties).
640c8776
SM
8492 (compute_display_string_pos, compute_display_string_end):
8493 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8494 arrow keys.
8495 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8496 base_level_stop; instead, set base_level_stop to BEGV.
8497 Fixes crashes in vertical-motion.
0bb23927
EZ
8498 (next_element_from_buffer): Improve commentary for when
8499 the iterator is before prev_stop.
8500 (init_iterator): Initialize bidi_p from the default value of
8501 bidi-display-reordering, not from buffer-local value. Use the
8502 buffer-local value only if initializing for buffer iteration.
8503 (handle_invisible_prop): Support invisible properties on strings
8504 that are being bidi-reordered.
8505 (set_iterator_to_next): Support bidi reordering of C strings and
8506 Lisp strings.
8507 (next_element_from_string): Support bidi reordering of Lisp
8508 strings.
8509 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8510 (display_string): Support display of R2L glyph rows.
8511 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8512 (init_iterator): Don't initialize it->bidi_p for strings
8513 here.
8514 (reseat_to_string): Initialize it->bidi_p for strings here.
8515 (next_element_from_string, next_element_from_c_string)
8516 (next_element_from_buffer): Add xassert's for correspondence
8517 between IT's object being iterated and it->bidi_it.string
8518 structure.
8519 (face_before_or_after_it_pos): Support bidi iteration.
8520 (next_element_from_c_string): Handle the case of the first string
8521 character that is not the first one in the visual order.
8522 (get_visually_first_element): New function, refactored from common
8523 parts of next_element_from_buffer, next_element_from_string, and
8524 next_element_from_c_string.
8525 (tool_bar_lines_needed, redisplay_tool_bar)
8526 (display_menu_bar): Force left-to-right direction. Add a FIXME
8527 comment for making that be controlled by a user option.
8528 (push_it, pop_it): Save and restore the state of the
8529 bidi iterator. Save and restore the bidi_p flag.
8530 (pop_it): Iterate out of display property for string iteration as
8531 well.
8532 (iterate_out_of_display_property): Support iteration over strings.
8533 (handle_single_display_spec): Set up it->bidi_it for iteration
8534 over a display string, and call bidi_init_it.
8535 (handle_single_display_spec, next_overlay_string)
8536 (get_overlay_strings_1, push_display_prop): Set up the bidi
8537 iterator for displaying display or overlay strings.
8538 (forward_to_next_line_start): Don't use the shortcut if
8539 bidi-iterating.
8540 (back_to_previous_visible_line_start): If handle_display_prop
8541 pushed the iterator stack, restore the internal state of the bidi
8542 iterator by calling bidi_pop_it same number of times.
8543 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8544 and we are bidi-iterating, don't decrement the iterator position;
8545 instead, set the first_elt flag in the bidi iterator, to produce
8546 the same effect.
8547 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8548 (push_display_prop): xassert that we are iterating a buffer.
8549 (push_it, pop_it): Save and restore paragraph_embedding member.
8550 (handle_single_display_spec, next_overlay_string)
8551 (get_overlay_strings_1, reseat_1, reseat_to_string)
8552 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8553 correctly. Don't assume unibyte strings are not bidi-reordered.
8554 (compute_display_string_pos)
8555 (compute_display_string_end): Fix handling the case of C string.
8556 (push_it, pop_it): Save and restore from_disp_prop_p.
8557 (handle_single_display_spec, push_display_prop): Set the
8558 from_disp_prop_p flag.
8559 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8560 (pop_it): Call iterate_out_of_display_property only if we are
8561 popping after iteration over a string that came from a display
8562 property. Fix a typo in popping stretch info. Add an assertion
8563 for verifying that the iterator position is in sync with the bidi
8564 iterator.
8565 (handle_single_display_spec, get_overlay_strings_1)
8566 (push_display_prop): Fix initialization of paragraph direction for
8567 string when that of the parent object is not yet determined.
8568 (reseat_1): Call bidi_init_it to resync the bidi
8569 iterator with IT's position. (Bug#7616)
8570 (find_row_edges): If ROW->start.pos gives position
8571 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8572 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8573 Reset the from_disp_prop_p flag.
8574 (SAVE_IT, RESTORE_IT): New macros.
8575 (pos_visible_p, face_before_or_after_it_pos)
8576 (back_to_previous_visible_line_start)
8577 (move_it_in_display_line_to, move_it_in_display_line)
8578 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8579 (try_scrolling, redisplay_window, display_line): Use them when
8580 saving a temporary copy of the iterator and restoring it back.
8581 (back_to_previous_visible_line_start, reseat_1)
8582 (init_iterator): Empty the bidi cache "stack".
8583 (move_it_in_display_line_to): If iterator ended up at
8584 EOL, but we never saw any buffer positions smaller than
8585 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8586 motion in bidi-reordered lines.
8587 (move_it_in_display_line_to): Record prev_method and prev_pos
8588 immediately before the call to set_iterator_to_next. Fixes cursor
8589 motion in bidi-reordered lines with stretch glyphs and strings
8590 displayed in margins. (Bug#8133) (Bug#8867)
8591 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8592 TO_CHARPOS.
640c8776
SM
8593 (pos_visible_p): Support positions in bidi-reordered lines.
8594 Save and restore bidi cache.
0bb23927
EZ
8595
8596 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8597 (bidi_paragraph_info): Delete unused struct.
8598 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8599 (bidi_cache_start): New variable.
8600 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8601 to zero.
8602 (bidi_cache_fetch_state, bidi_cache_search)
8603 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8604 (bidi_cache_find, bidi_peek_at_next_level)
8605 (bidi_level_of_next_char, bidi_find_other_level_edge)
8606 (bidi_move_to_visually_next): Compare cache index with
8607 bidi_cache_start rather than with zero.
8608 (bidi_fetch_char): Accept new argument STRING; all callers
8609 changed. Support iteration over a string. Support strings with
8610 display properties. Support unibyte strings. Fix the type of
8611 `len' according to what STRING_CHAR_AND_LENGTH expects.
8612 (bidi_paragraph_init, bidi_resolve_explicit_1)
8613 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8614 (bidi_level_of_next_char, bidi_move_to_visually_next):
8615 Support iteration over a string.
0bb23927
EZ
8616 (bidi_set_sor_type, bidi_resolve_explicit_1)
8617 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8618 can now be zero (for strings); special values 0 and -1 were
8619 changed to -1 and -2, respectively.
8620 (bidi_char_at_pos): New function.
8621 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8622 Call it instead of FETCH_MULTIBYTE_CHAR.
8623 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8624 initialized to valid values.
8625 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8626 values.
8627 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8628 the test for valid cached positions. Fix the logic for looking up
8629 the sentinel state in the cache. GCPRO the Lisp string we are
8630 iterating.
8631 (bidi_push_it, bidi_pop_it): New functions.
8632 (bidi_initialize): Initialize the bidi cache start stack pointer.
8633 (bidi_cache_ensure_space): New function, refactored from part of
8634 bidi_cache_iterator_state. Don't assume the required size is just
8635 one BIDI_CACHE_CHUNK away.
8636 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8637 (bidi_count_bytes, bidi_char_at_pos): New functions.
8638 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8639 always valid if bidi_cache_idx is valid.
8640 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8641 is valid if it's going to be used.
8642 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8643 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8644 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8645 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8646 (bidi_find_other_level_edge, bidi_cache_start_stack):
8647 All variables related to cache indices are now EMACS_INT.
c965adc5 8648
0bb23927
EZ
8649 * dispextern.h (struct bidi_string_data): New structure.
8650 (struct bidi_it): New member `string'. Make flag members be 1-bit
8651 fields, and put them last in the struct.
640c8776
SM
8652 (compute_display_string_pos, compute_display_string_end):
8653 Update prototypes.
0bb23927
EZ
8654 (bidi_push_it, bidi_pop_it): Add prototypes.
8655 (struct iterator_stack_entry): New members bidi_p,
8656 paragraph_embedding, and from_disp_prop_p.
8657 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8658 (bidi_shelve_cache, bidi_unshelve_cache):
8659 Declare prototypes.
0bb23927
EZ
8660
8661 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8662 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8663 and vector-like objects.
8664
8665 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8666 cache around display iteration.
8667
8668 * window.c (Fwindow_end, window_scroll_pixel_based)
8669 (displayed_window_lines, Frecenter): Save and restore the bidi
8670 cache around display iteration.
8671
3bbd2265
LMI
86722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8673
8674 * editfns.c (Fdelete_region): Clarify the use of the named
8675 parameters (bug#6788).
8676
adc47434
MR
86772011-07-14 Martin Rudalics <rudalics@gmx.at>
8678
8679 * indent.c (Fvertical_motion): Set and restore w->pointm when
8680 saving and restoring the window's buffer (Bug#9006).
8681
837c31f8
LMI
86822011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8683
8684 * editfns.c (Fstring_to_char): Clarify just what is returned
8685 (bug#6576). Text by Eli Zaretskii.
8686
ac389d0c
JB
86872011-07-13 Juanma Barranquero <lekktu@gmail.com>
8688
8689 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8690
0be0ce47
EZ
86912011-07-13 Eli Zaretskii <eliz@gnu.org>
8692
8693 * buffer.c (mmap_find): Fix a typo.
8694
cd18e7e3
JB
86952011-07-13 Johan Bockgård <bojohan@gnu.org>
8696
8697 Fix execution of x selection hooks.
8698 * xselect.c (Qx_lost_selection_functions)
8699 (Qx_sent_selection_functions): New vars.
8700 (syms_of_xselect): DEFSYM them.
8701 (x_handle_selection_request): Pass Qx_sent_selection_functions
8702 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8703 (x_handle_selection_clear,x_clear_frame_selections):
8704 Pass Qx_lost_selection_functions rather than
8705 Vx_lost_selection_functions to Frun_hook_with_args.
8706
47ea7f44
PE
87072011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8708
ac389d0c 8709 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8710 The old code sometimes used this field without initializing it.
8711
47ea7f44
PE
8712 * alloc.c (gc_sweep): Don't read past end of array.
8713 In theory, the old code could also have corrupted Emacs internals,
8714 though it'd be very unlikely.
8715
bc985c87
AS
87162011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8717
8718 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8719 argument. (Bug#4026)
bc985c87 8720
0cf34688
LMI
87212011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8722
b3dadd76
LMI
8723 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8724 key" (bug#4257).
8725
0cf34688
LMI
8726 * window.c (Fset_window_start): Doc fix (bug#4199).
8727 (Fset_window_hscroll): Ditto.
8728
270768cd
PE
87292011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8730
077e3dda 8731 Fix minor new problems caught by GCC 4.6.1.
270768cd 8732 * term.c (init_tty): Remove unused local.
490011a6 8733 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8734 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8735 not used otherwise.
270768cd 8736
b1f58454
CY
87372011-07-12 Chong Yidong <cyd@stupidchicken.com>
8738
8739 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8740
22b9578d
LMI
87412011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8742
6e70ab07
LMI
8743 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8744 are the mini-buffer and the echo area (bug#3320).
8745
22b9578d
LMI
8746 * term.c (init_tty): Remove support for supdup, c10 and perq
8747 terminals, which are no longer supported (bug#1482).
8748
8974cc9f
JB
87492011-07-10 Johan Bockgård <bojohan@gnu.org>
8750
8751 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8752
a560d974
JD
87532011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8754
8755 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8756 for non-popups (Bug#3642).
8757
1dae0f0a
AS
87582011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8759
268c2c36 8760 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8761 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8762 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8763 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8764 * data.c (fmod): Likewise.
8765 * dispnew.c (swap_glyphs_in_rows): Likewise.
8766 * emacs.c (memory_warning_signal): Likewise.
8767 * floatfns.c (float_error): Likewise.
8768 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8769 (otf_open, font_otf_capability, generate_otf_features)
8770 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8771 Likewise.
8772 * image.c (pbm_read_file): Likewise.
8773 * indent.c (string_display_width): Likewise.
8774 * intervals.c (check_for_interval, search_for_interval)
8775 (inc_interval_count, count_intervals, root_interval)
8776 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8777 * lread.c (defalias): Likewise.
268c2c36 8778 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8779 * regex.c (set_image_of_range_1, set_image_of_range)
8780 (regex_grow_registers): Likewise.
8781 * sysdep.c (strerror): Likewise.
8782 * termcap.c (valid_filename_p, tprint, main): Likewise.
8783 * tparam.c (main): Likewise.
8784 * unexhp9k800.c (run_time_remap, save_data_space)
8785 (update_file_ptrs, read_header, write_header, calculate_checksum)
8786 (copy_file, copy_rest, display_header): Likewise.
8787 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8788 Likewise.
8789 * xdisp.c (check_it): Likewise.
8790 * xfaces.c (register_color, unregister_color, unregister_colors):
8791 Likewise.
8792 * xfns.c (print_fontset_result): Likewise.
8793 * xrdb.c (member, fatal, main): Likewise.
8794
99033785
PE
87952011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8796
8797 Fix minor problems found by static checking (Bug#9031).
8798 * chartab.c (char_table_set_range, map_sub_char_table):
8799 Remove unused locals.
8800 (uniprop_table): Now static.
8801 * composite.c (_work_char): Remove unused static var.
8802
9cb2ac56
JB
88032011-07-09 Juanma Barranquero <lekktu@gmail.com>
8804
8805 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8806
f25661f0
JD
88072011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8808
8809 * gtkutil.c (qttip_cb): Remove code without function.
8810
8278c4fe
EZ
88112011-07-09 Eli Zaretskii <eliz@gnu.org>
8812
8813 * w32.c (pthread_sigmask): New stub.
8814
1692ae2d 88152011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8816
8a6ebd58 8817 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8818 sigprocmask is portable only for single-threaded applications, and
8819 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8820 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8821 (LIBES): Use it.
8822 * callproc.c (Fcall_process):
8823 * process.c (create_process):
8824 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8825 Use pthread_sigmask, not sigprocmask.
123403e4 8826
1b854618
JD
88272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8828
8829 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8830 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8831 wrong (Bug#8591).
8832
3fe4b549
JD
88332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8834
0ce7e563
JD
8835 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8836 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8837 (xg_hide_tooltip): Fix comment.
8838
3fe4b549
JD
8839 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8840 in registerServicesMenuSendTypes.
8841 (validRequestorForSendType): Don't check ns_return_types.
8842
8843 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8844 ns_return_type.
8845
5df75e47
JR
88462011-07-08 Jason Rumney <jasonr@gnu.org>
8847
22610910
JR
8848 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8849 SH_SHOW for hidden windows (Bug#5482).
8850
5df75e47
JR
8851 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8852 frame struct members of non-existent frames (Bug#6284).
8853
699c10bd
JD
88542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8855
4393663b
JD
8856 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8857 variable firstTime not needed on OSX >= 10.6.
8858 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8859 >= 10.5. Use setKnobProportion, setDoubleValue.
8860
8861 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8862 (MAC_OS_X_VERSION_10_5): Define if not defined.
8863 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8864 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8865 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8866
8867 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8868 cString and lossyCString on OSX >= 10.4.
4393663b 8869
58179cce 8870 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8871 sizeToFit on OSX >= 10.2.
8872
8873 * nsimage.m (allocInitFromFile): Don't use deprecated method
8874 bestRepresentationForDevice on OSX >= 10.6.
8875
8876 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8877 to avoid warning.
8878
8879 * emacs.c: Declare unexec_init_emacs_zone.
8880
a63e0781
JD
8881 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8882
699c10bd
JD
8883 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8884
8885 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8886 on svcsMenu (Bug#8842).
8887
8888 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8889 ns_return_types.
8890 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8891
8892 * nsterm.m (QUTF8_STRING): Declare.
8893 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8894 (validRequestorForSendType): Return type is (id).
8895 Change indexOfObjectIdenticalTo to indexOfObject.
8896 Check if we have local selection before returning self (Bug#8842).
8897 (writeSelectionToPasteboard): Put local selection into paste board
8898 if we have a local selection (Bug#8842).
8899 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8900
8901 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8902 (ns_get_local_selection): Declare.
8903
54e10184
LMI
89042011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8905
9888ff71
LMI
8906 * keymap.c (describe_map_tree): Don't insert a double newline at
8907 the end of the buffer (bug#1169) and return whether we inserted
8908 something.
8909
54e10184
LMI
8910 * callint.c (Fcall_interactively): Change "reading args" to
8911 "providing args" to try to clarify what it does (bug#1010).
8912
15fa4783
KH
89132011-07-07 Kenichi Handa <handa@m17n.org>
8914
8915 * composite.c (composition_compute_stop_pos): Ignore a static
8916 composition starting before CHARPOS (Bug#8915).
8917
8918 * xdisp.c (handle_composition_prop): Likewise.
8919
a8815b00
EZ
89202011-07-07 Eli Zaretskii <eliz@gnu.org>
8921
8922 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8923 (Bug#9015)
8924
ef7b981d 89252011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8926
8927 * character.h (unicode_category_t): New enum type.
8928
8929 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8930 (Qchar_code_property_table): New variable.
8931 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8932 (UNIPROP_COMPRESSED_FORM_P): New macros.
8933 (char_table_ascii): Uncompress the compressed values.
8934 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8935 Uncompress the compressed values.
ac389d0c 8936 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8937 (char_table_ref_and_range): Uncompress the compressed values.
8938 (sub_char_table_set): New arg is_uniprop. Callers changed.
8939 Uncompress the compressed values.
8940 (sub_char_table_set_range): Args changed. Callers changed.
8941 (char_table_set_range): Adjuted for the above change.
8942 (map_sub_char_table): Delete args default_val and parent. Add arg
8943 top. Give decoded values to a Lisp function.
640c8776 8944 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8945 values to a Lisp function. Gcpro more variables.
8946 (uniprop_table_uncompress)
8947 (uniprop_decode_value_run_length): New functions.
8948 (uniprop_decoder, uniprop_decoder_count): New variables.
8949 (uniprop_get_decoder, uniprop_encode_value_character)
8950 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8951 New functions.
8952 (uniprop_encoder, uniprop_encoder_count): New variables.
8953 (uniprop_get_encoder, uniprop_table)
8954 (Funicode_property_table_internal, Fget_unicode_property_internal)
8955 (Fput_unicode_property_internal): New functions.
8956 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8957 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8958 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8959 char-code-property-alist.
8960
640c8776 8961 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8962 Vunicode_category_table.
8963
640c8776 8964 * font.c (font_range): Adjust for the change of
c805dec0
KH
8965 Vunicode_category_table.
8966
76b397fb
DN
89672011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8968
8969 * m/iris4d.h: Remove file, move contents ...
8970 * s/irix6-5.h: ... here.
8971
22b4128e
PE
89722011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8973
8974 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8975 * alloc.c (mark_buffer):
8976 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8977 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8978 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8979 This isn't true in general, and it's particularly not true
8980 if Emacs is configured with --with-wide-int.
8981 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8982 New macros, used in the buffer.c change.
8983
869795d6
JD
89842011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8985
8986 * xsettings.c: Use both GConf and GSettings if both are available.
8987 (store_config_changed_event): Add comment.
8988 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8989 (store_tool_bar_style_changed): New functions.
5e617bc2 8990 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8991 (struct xsettings): Move font inside HAVE_XFT.
8992 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8993 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8994 Move inside HAVE_XFT.
640c8776 8995 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8996 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8997 also.
8998 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8999 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9000 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9001 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9002 (parse_settings): Move check for font inside HAVE_XFT.
9003 (read_settings, apply_xft_settings): Add comment.
9004 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9005 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9006 call store_font_name_changed.
9007 (xft_settings_event): Add comment.
9008 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9009 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9010 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9011 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9012 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9013 (xsettings_get_system_font, xsettings_get_system_normal_font):
9014 Add comment.
869795d6 9015
d8ed26bd
PE
90162011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9017
9018 Random fixes. E.g., (random) never returned negative values.
9019 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9020 subseconds part to the entropy, as that's a bit more random.
9021 Prefer signed to unsigned, since the signedness doesn't matter and
9022 in general we prefer signed. When given a limit, use a
9023 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9024 latter isn't right if USE_2_TAGS_FOR_INTS.
9025 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9026 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9027
cabf1cac
SM
90282011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9029
9030 * textprop.c (text_property_stickiness):
9031 Obey Vtext_property_default_nonsticky.
9032 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9033 * w32fns.c (syms_of_w32fns):
9034 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9035
6e9b2be9
PE
90362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9037
9038 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9039 This is more efficient than Ffile_directory_p and avoids a minor race.
9040
90186c68
LMI
90412011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9042
7c301272
LMI
9043 * buffer.c (Foverlay_put): Say what the return value is
9044 (bug#7835).
9045
c4f2d8d4
LMI
9046 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9047 is a directory before asking whether to use the file name
9048 (bug#7564).
ad637907
LMI
9049 (barf_or_query_if_file_exists): Make the "File is a directory"
9050 error be more correct.
c4f2d8d4 9051
90186c68
LMI
9052 * fns.c (Frequire): Remove the mention of the .gz files, since
9053 that's installation-specific, but keep the mention of
9054 `get-load-suffixes'.
9055
da64016e
PE
90562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9057
9058 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9059 Report string overflow if the output is too long.
9060
7d47b580
JB
90612011-07-04 Juanma Barranquero <lekktu@gmail.com>
9062
a555cb87
JB
9063 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9064 (syms_of_gnutls): Remove duplicate DEFSYM for
9065 Qgnutls_bootprop_verify_hostname_error, an error for
9066 Qgnutls_bootprop_verify_error (which is no longer used).
9067
7d47b580
JB
9068 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9069 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9070 Also (re)move comments that are misplaced or no longer relevant.
9071
1e49bfab
LMI
90722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9073
9074 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9075
1485f4c0
CY
90762011-07-03 Chong Yidong <cyd@stupidchicken.com>
9077
9078 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9079 and background color parameters if they have been changed.
9080
a9ab721e
LMI
90812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9082
9083 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9084
cf7cff57
PE
90852011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9086
2e13213d
PE
9087 * xsettings.c (SYSTEM_FONT): Define only when used.
9088 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9089
cf7cff57
PE
9090 * keymap.c (access_keymap_1): Now static.
9091
7a8e04f7
CY
90922011-07-02 Chong Yidong <cyd@stupidchicken.com>
9093
9094 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9095 leave any prefix arg for the up event (Bug#1586).
9096
61352f62
LMI
90972011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9098
69bb1ef7
LMI
9099 * lread.c (syms_of_lread): Mention single symbols defined by
9100 `defvar' or `defconst' (bug#7154).
9101
61352f62 9102 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9103 (Frequire): Mention get-load-suffixes.
61352f62 9104
28545e04
MR
91052011-07-02 Martin Rudalics <rudalics@gmx.at>
9106
9107 * window.h (window): Remove clone_number slot.
9108 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9109 Remove.
9110 (make_parent_window, make_window, saved_window)
9111 (Fset_window_configuration, save_window_save): Don't deal with
9112 clone numbers.
9113 * buffer.c (Qclone_number): Remove declaration.
9114 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9115
3349e122
SM
91162011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9117
9118 Add multiple inheritance to keymaps.
9119 * keymap.c (Fmake_composed_keymap): New function.
9120 (Fset_keymap_parent): Simplify.
9121 (fix_submap_inheritance): Remove.
9122 (access_keymap_1): New function extracted from access_keymap to handle
9123 embedded parents and handle lists of maps.
9124 (access_keymap): Use it.
9125 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9126 (Fcopy_keymap): Handle embedded parents.
9127 (Fcommand_remapping, define_as_prefix): Simplify.
9128 (Fkey_binding): Simplify.
9129 (syms_of_keymap): Move minibuffer-local-completion-map,
9130 minibuffer-local-filename-completion-map,
9131 minibuffer-local-must-match-map, and
9132 minibuffer-local-filename-must-match-map to Elisp.
9133 (syms_of_keymap): Defsubr make-composed-keymap.
9134 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9135 (parse_menu_item): Trivial simplification.
9136
3279eb87
GM
91372011-07-01 Glenn Morris <rgm@gnu.org>
9138
9139 * Makefile.in (SETTINGS_LIBS): Fix typo.
9140
4550efdf
KI
91412011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9142
9143 * coding.c (Fencode_coding_string): Record the last coding system
9144 used, as the function doc string says (bug#8738).
9145
0949d2b6
JD
91462011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9147
9148 * xsettings.c (store_monospaced_changed): Take new font as arg and
9149 check for change against current_mono_font.
9150 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9151 (emacs_settings_constructor, emacs_settings_get_property)
9152 (emacs_settings_set_property, emacs_settings_class_init)
9153 (emacs_settings_init, gsettings_obj): Remove.
9154 (something_changedCB): New function for HAVE_GSETTINGS.
9155 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9156 with value as argument.
9157 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9158 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9159 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9160 "changed".
9161
9162 * xgselect.c: Add defined (HAVE_GSETTINGS).
9163 (xgselect_initialize): Ditto.
9164
9165 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9166 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9167 xg_select.
9168
bbc6b304
PE
91692011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9170
9171 * eval.c (struct backtrace): Simplify and port the data structure.
9172 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9173 signed bit field, as this assumption is not portable and it makes
9174 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9175 "char debug_on_exit : 1" as this is not portable either; instead,
9176 use the portable "unsigned int debug_on_exit : 1". Remove unused
9177 member evalargs. Remove obsolete comments about cc bombing out.
9178
9851bfc5
JD
91792011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9180
51bb811f 9181 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9182 Let HAVE_GSETTINGS override HAVE_GCONF.
9183 (store_monospaced_changed): New function.
9184 (EMACS_SETTINGS): A new type derived from GObject to handle
9185 GSettings notifications.
9186 (emacs_settings_constructor, emacs_settings_get_property)
9187 (emacs_settings_set_property, emacs_settings_class_init):
9188 New functions.
9189 (gsettings_client, gsettings_obj): New variables.
9190 (GSETTINGS_SCHEMA): New define.
9191 (something_changedCB): Call store_monospaced_changed.
9192 (init_gsettings): New function.
9193 (xsettings_initialize): Call init_gsettings.
9194 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9195 to NULL.
9196
640c8776 9197 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9198 GCONF_CFLAGS/LIBS.
9199
5386012d
MR
92002011-06-29 Martin Rudalics <rudalics@gmx.at>
9201
9202 * window.c (resize_root_window, grow_mini_window)
9203 (shrink_mini_window): Rename Qresize_root_window to
9204 Qwindow_resize_root_window and Qresize_root_window_vertically to
9205 Qwindow_resize_root_window_vertically.
9206
f13e0b08
PE
92072011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9208
9209 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9210
94515237
JB
92112011-06-27 Juanma Barranquero <lekktu@gmail.com>
9212
9213 * makefile.w32-in: Redesign dependencies so they reflect more
9214 clearly which files are directly included by each source file,
9215 and not through other includes.
9216
e43b6e43
MR
92172011-06-27 Martin Rudalics <rudalics@gmx.at>
9218
9219 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9220 (sort_overlays, overlay_strings): When an overlay's clone number
9221 matches the window's clone number process the overlay even if
9222 the overlay's window property doesn't match the current window.
9223
d68443dc
MR
9224 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9225 (Fwindow_hchild): Rename to Fwindow_left_child.
9226 (Fwindow_next): Rename to Fwindow_next_sibling.
9227 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9228 (resize_window_check): Rename to window_resize_check.
9229 (resize_window_apply): Rename to window_resize_apply.
9230 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9231 (Fdelete_other_windows_internal, resize_frame_windows)
9232 (Fsplit_window_internal, Fdelete_window_internal)
9233 (grow_mini_window, shrink_mini_window)
9234 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9235
c7e73be5
JD
92362011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9237
9238 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9239 (emacs_fixed_set_min_size): Remove.
9240 (emacs_fixed_new): Take frame as argument.
9241
9242 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9243 (_EmacsFixedPrivate): Remove minwidth/height.
9244 Add struct frame *f.
9245 (emacs_fixed_init): Initialize priv->f.
9246 (get_parent_class, emacs_fixed_set_min_size): Remove.
9247 (emacs_fixed_new): Set priv->f to argument.
9248 (emacs_fixed_get_preferred_width)
9249 (emacs_fixed_get_preferred_height): Use min_width/height from
9250 frames size_hint to set minimum and natural (Bug#8919).
9251 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9252 and use min_width/height from frames size_hint to set
9253 min_width/height (Bug#8919).
9254
9255 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9256 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9257 Fix indentation.
c7e73be5 9258
cf99dcf8
EZ
92592011-06-26 Eli Zaretskii <eliz@gnu.org>
9260
9261 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9262 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9263 called at ZV.
9264
029529ac
CY
92652011-06-26 Chong Yidong <cyd@stupidchicken.com>
9266
9267 * process.c (wait_reading_process_output): Bypass select if
9268 waiting for a cell while ignoring keyboard input, and input is
9269 pending. Suggested by Jan Djärv (Bug#8869).
9270
7a7ef429
PE
92712011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9272
9273 Use gnulib's dup2 module instead of rolling our own.
9274 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9275
11fdef7d 92762011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9277
9278 * dispnew.c (scrolling_window): Before scrolling, turn off a
9279 mouse-highlight in the window being scrolled.
9280
cd3520a4
JB
92812011-06-24 Juanma Barranquero <lekktu@gmail.com>
9282
9283 Move DEFSYM to lisp.h and use everywhere.
9284
9285 * character.h (DEFSYM): Move declaration...
9286 * lisp.h (DEFSYM): ...here.
9287
9288 * gnutls.c:
9289 * minibuf.c:
9290 * w32menu.c:
9291 * w32proc.c:
9292 * w32select.c: Don't include character.h.
9293
9294 * alloc.c (syms_of_alloc):
9295 * buffer.c (syms_of_buffer):
9296 * bytecode.c (syms_of_bytecode):
9297 * callint.c (syms_of_callint):
9298 * casefiddle.c (syms_of_casefiddle):
9299 * casetab.c (init_casetab_once):
9300 * category.c (init_category_once, syms_of_category):
9301 * ccl.c (syms_of_ccl):
9302 * cmds.c (syms_of_cmds):
9303 * composite.c (syms_of_composite):
9304 * dbusbind.c (syms_of_dbusbind):
9305 * dired.c (syms_of_dired):
9306 * dispnew.c (syms_of_display):
9307 * doc.c (syms_of_doc):
9308 * editfns.c (syms_of_editfns):
9309 * emacs.c (syms_of_emacs):
9310 * eval.c (syms_of_eval):
9311 * fileio.c (syms_of_fileio):
9312 * fns.c (syms_of_fns):
9313 * frame.c (syms_of_frame):
9314 * fringe.c (syms_of_fringe):
9315 * insdel.c (syms_of_insdel):
9316 * keymap.c (syms_of_keymap):
9317 * lread.c (init_obarray, syms_of_lread):
9318 * macros.c (syms_of_macros):
9319 * msdos.c (syms_of_msdos):
9320 * print.c (syms_of_print):
9321 * process.c (syms_of_process):
9322 * search.c (syms_of_search):
9323 * sound.c (syms_of_sound):
9324 * syntax.c (init_syntax_once, syms_of_syntax):
9325 * terminal.c (syms_of_terminal):
9326 * textprop.c (syms_of_textprop):
9327 * undo.c (syms_of_undo):
9328 * w32.c (globals_of_w32):
9329 * window.c (syms_of_window):
9330 * xdisp.c (syms_of_xdisp):
9331 * xfaces.c (syms_of_xfaces):
9332 * xfns.c (syms_of_xfns):
9333 * xmenu.c (syms_of_xmenu):
9334 * xsettings.c (syms_of_xsettings):
9335 * xterm.c (syms_of_xterm): Use DEFSYM.
9336
4228cf16
TZ
93372011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9338
cd3520a4 9339 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9340
7fcccf1e
PE
93412011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9342
7efb4e0e
PE
9343 Integer and buffer overflow fixes (Bug#8873).
9344
ff5844ad
PE
9345 * print.c (printchar, strout): Check for string overflow.
9346 (PRINTPREPARE, printchar, strout):
9347 Don't set size unless allocation succeeds.
9348
90532f02
PE
9349 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9350 for sizes. Check for string overflow more accurately.
9351 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9352
6d84508d
PE
9353 * macros.c: Integer and buffer overflow fixes.
9354 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9355 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9356 Use ptrdiff_t, not int, for sizes.
9357 Don't increment bufsize until after realloc succeeds.
9358 Check for size-calculation overflow.
9359 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9360
437b2cb4
PE
9361 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9362
8b9ac8b4
PE
9363 * lread.c: Integer overflow fixes.
9364 (read_integer): Radix is now EMACS_INT, not int,
9365 to improve quality of diagnostics for out-of-range radices.
9366 Calculate buffer size correctly for out-of-range radices.
9367 (read1): Check for integer overflow in radices, and in
9368 read-circle numbers.
82cb60d3
PE
9369 (read_escape): Avoid int overflow.
9370 (Fload, openp, read_buffer_size, read1)
9371 (substitute_object_recurse, read_vector, read_list, map_obarray):
9372 Use ptrdiff_t, not int, for sizes.
9373 (read1): Use EMACS_INT, not int, for sizes.
20270765 9374 Check for size overflow.
8b9ac8b4 9375
7fcccf1e
PE
9376 * image.c (cache_image): Check for size arithmetic overflow.
9377
bfbbd7e7
PE
9378 * lread.c: Integer overflow issues.
9379 (saved_doc_string_size, saved_doc_string_length)
9380 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9381 Now ptrdiff_t, not int.
9382 (read1): Don't assume doc string length fits in int. Check for
9383 out-of-range doc string lengths.
9384 (read_list): Don't assume file position fits in int.
39019e54 9385 (read_escape): Check for hex character overflow.
bfbbd7e7 9386
4e323265
LL
93872011-06-22 Leo Liu <sdl.web@gmail.com>
9388
9389 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9390 Move to minibuffer.el.
9391
85fece3e
PE
93922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9393
20b84ce9 9394 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9395 The following patches are for when GLYPH_DEBUG && !XASSERT.
9396 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9397 * dispnew.c (flush_stdout):
9398 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9399 Mark as externally visible.
9400 * dispnew.c (check_window_matrix_pointers): Now static.
9401 * dispnew.c (window_to_frame_vpos):
9402 * xfns.c (unwind_create_frame):
9403 * xterm.c (x_check_font): Remove unused local.
9404 * scroll.c (CHECK_BOUNDS):
9405 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9406 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9407 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9408 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9409 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9410 Now static.
9411 (debug_method_add): Use va_list and vsprintf rather than relying
9412 on undefined behavior with wrong number of arguments.
9413 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9414 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9415 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9416 since we're not interested in debugging glyphs with old libraries.
9417 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9418 GCC 4.6.0's static checking.
9419
0766b489
PE
94202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9421
31fd4b32
PE
9422 Integer overflow and signedness fixes (Bug#8873).
9423 A few related buffer overrun fixes, too.
9424
b79e8648
PE
9425 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9426
0766b489
PE
9427 * dispextern.h (struct face.stipple):
9428 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9429 (x_bitmap_mask, x_allocate_bitmap_record)
9430 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9431 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9432 (x_create_bitmap_from_xpm_data):
9433 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9434 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9435 (.bitmaps_last):
9436 * xfaces.c (load_pixmap):
9437 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9438 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9439 (.bitmaps_last, struct x_output.icon_bitmap):
9440 Use ptrdiff_t, not int, for bitmap indexes.
9441 (x_allocate_bitmap_record): Check for size overflow.
9442 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9443
b081724f
PE
9444 Use ptrdiff_t, not int, for overlay counts.
9445 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9446 * editfns.c (overlays_around, get_pos_property):
9447 * textprop.c (get_char_property_and_overlay):
9448 * xdisp.c (next_overlay_change, note_mouse_highlight):
9449 * xfaces.c (face_at_buffer_position):
21514da7
PE
9450 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9451 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9452 (Fnext_overlay_change, Fprevious_overlay_change)
9453 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9454 Use ptrdiff_t, not int, for sizes.
21514da7 9455 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9456
3de73e5e
PE
9457 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9458
2606c57b
PE
9459 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9460 (x_session_initialize): Do not assume string length fits in int.
9461
aaafe47a
PE
9462 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9463 This is unlikely, but can occur if DPI is outlandish.
9464
2674ddc8 9465 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9466 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9467
28154962
PE
9468 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9469 * xrdb.c (magic_file_p, search_magic_path):
9470 Omit last arg SUFFIX; it was always 0. All callers changed.
9471 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9472
7de51af5
PE
9473 * xfont.c (xfont_match): Avoid need for strlen.
9474
25ed6cc3
PE
9475 * xfns.c: Don't assume strlen fits in int.
9476 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9477
4eab31dd
PE
9478 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9479 not unsigned long, as we prefer signed integers. All callers changed.
9480 Detect integer overflow in repeat count.
9481 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9482 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9483
171e2a58
PE
9484 * termcap.c: Don't assume sizes fit in int and never overflow.
9485 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9486 (gobble_line): Check for size-calculation overflow.
9487
ad39faca 9488 * minibuf.c (Fread_buffer):
6e5bb2dc 9489 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9490 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9491 Don't assume string length fits in int.
9492
52c61c22 9493 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9494 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9495
b5b8c9e5
PE
9496 * font.c: Don't assume string length fits in int.
9497 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9498 Use ptrdiff_t, not int.
ccd6111c
PE
9499 (font_intern_prop): Don't assume string length fits in int.
9500 Don't assume integer property fits in fixnum.
9501 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9502
882f0d81 9503 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9504 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9505 Reformulate so as not to need the command string.
9506 Invoke gzip -cd rather than gunzip, as it's more portable.
9507 (lock_info_type, lock_file_1, lock_file):
9508 Don't assume pid_t and time_t fit in unsigned long.
9509 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9510 (current_lock_owner): Prefer signed type for sizes.
9511 Use memcpy, not strncpy, where memcpy is what is really wanted.
9512 Don't assume (via atoi) that time_t and pid_t fit in int.
9513 Check for time_t and/or pid_t out of range, e.g., via a network share.
9514 Don't alloca where an auto var works fine.
9515
93f4cf88
PE
9516 * fileio.c: Fix some integer overflow issues.
9517 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9518 Don't assume string length fits in int.
9519 (directory_file_name): Don't assume string length fits in long.
9520 (make_temp_name): Don't assume pid fits in int, or that its print
9521 length is less than 20.
9522
f3e92b69
PE
9523 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9524
1bfdaf10
PE
9525 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9526
35016e9a
PE
9527 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9528
3d1e65a1
PE
9529 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9530 We prefer signed integers, even for size calculations.
9531
0b963a93
PE
9532 * emacs.c: Don't assume string length fits in 'int'.
9533 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9534 (main): Don't invoke strlen when not needed.
9535
573f4b54
PE
9536 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9537 (XD_DEBUG_MESSAGE): Don't waste a byte.
9538
989f33ba
PE
9539 * callproc.c (getenv_internal_1, getenv_internal)
9540 (Fgetenv_internal):
965d34eb
PE
9541 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9542
e4d29b33
PE
9543 * lread.c (invalid_syntax): Omit length argument.
9544 All uses changed. This doesn't fix a bug, but it simplifies the
9545 code away from its former Hollerith-constant appearance, and it's
9546 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9547 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9548
eb49b136
PE
9549 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9550 This didn't break anything, but it didn't help either.
9551 It's confusing to put a bogus integer in a place where the actual
9552 value does not matter.
9f62aeb1 9553 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9554 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9555
15375a22
PE
9556 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9557 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9558 implementation.
b61cc01c
PE
9559 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9560 We prefer signed types, and the value cannot exceed the EMACS_INT
9561 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9562 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9563 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9564 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9565
53b2623d
PE
9566 * indent.c (sane_tab_width): New function.
9567 (current_column, scan_for_column, Findent_to, position_indentation)
9568 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9569 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9570
51cab52b 9571 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9572
f2ed8a70
PE
9573 * lisp.h (lint_assume): New macro.
9574 * composite.c (composition_gstring_put_cache):
9575 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9576
abe80cc6
PE
9577 * editfns.c, insdel.c:
9578 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9579
b02c740e
PE
9580 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9581
ebc96716
PE
9582 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9583
b4e50fa0 9584 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9585 Use much-faster test for byte-length change.
311d5d7c 9586 Don't assume string byte-length fits in 'int'.
a4cf38e4 9587 Check that character arg fits in 'int'.
85461888 9588 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9589
c0c1ee9f
PE
9590 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9591
a498d7f4
PE
9592 * fns.c (concat): Catch string overflow earlier.
9593 Do not rely on integer wraparound.
9594
51cab52b
PE
9595 * dispextern.h (struct it.overlay_strings_charpos)
9596 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9597 * xdisp.c (forward_to_next_line_start)
9598 (back_to_previous_visible_line_start)
9599 (reseat_at_next_visible_line_start, next_element_from_buffer):
9600 Don't arbitrarily truncate the value of 'selective' to int.
9601
76031fad
PE
9602 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9603
5eb55db9
PE
9604 * composite.c: Don't truncate sizes to 'int'.
9605 (composition_gstring_p, composition_reseat_it)
9606 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9607 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9608 not EMACS_UINT, for indexes.
5eb55db9 9609
0703a717
PE
9610 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9611
d6202519
PE
9612 * buffer.c: Include <verify.h>.
9613 (struct sortvec.priority, struct sortstr.priority):
8961a454 9614 Now EMACS_INT, not int.
c20998a7 9615 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9616 (struct sortstr.size, record_overlay_string)
9617 (struct sortstrlist.size, struct sortlist.used):
9618 Don't truncate size to int.
9619 (record_overlay_string): Check for size-calculation overflow.
d6202519 9620 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9621
d5a19415
JM
96222011-06-22 Jim Meyering <meyering@redhat.com>
9623
029529ac 9624 Don't leak an XBM-image-sized buffer
d5a19415
JM
9625 * image.c (xbm_load): Free the image buffer after using it.
9626
a9041e6c
PE
96272011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9628
9629 Port to Sun C.
9630 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9631 that Sun C diagnosed.
9632 * fns.c (secure_hash): Fix pointer signedness issue.
9633 * intervals.c (static_offset_intervals): New function.
9634 (offset_intervals): Use it.
9635
7f3f739f
LL
96362011-06-21 Leo Liu <sdl.web@gmail.com>
9637
9638 * deps.mk (fns.o):
9639 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9640 sha512.h.
9641
9642 * fns.c (secure_hash): Rename from crypto_hash_function and change
9643 the first arg to accept symbols.
5b66d427 9644 (Fsecure_hash): New primitive.
7f3f739f
LL
9645 (syms_of_fns): New symbols.
9646
76147d94
DD
96472011-06-20 Deniz Dogan <deniz@dogan.se>
9648
9649 * process.c (Fset_process_buffer): Clarify return value in
9650 docstring.
9651
7d7d0045
CY
96522011-06-18 Chong Yidong <cyd@stupidchicken.com>
9653
9654 * dispnew.c (add_window_display_history): Use BVAR.
9655
9656 * xdisp.c (debug_method_add): Use BVAR.
9657 (check_window_end, dump_glyph_matrix, dump_glyph)
9658 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9659
9660 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9661 Likewise.
9662
9663 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9664 check till after the cache is created in init_frame_faces.
9665
ff2bc410
SM
96662011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9667
9668 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9669
28177add
PE
96702011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9671
dd3482fe
PE
9672 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9673 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9674 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9675
393d71f3 9676 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9677 * fileio.c (Finsert_file_contents):
9678 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9679 Remove the old (too-loose) buffer overflow checks.
9680 They weren't needed, since make_gap checks for buffer overflow.
9681 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9682 The old code merely checked for Emacs fixnum overflow, and relied
9683 on undefined (wraparound) behavior. The new code avoids undefined
9684 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9685
2e6813b0 9686 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9687 Tune. Don't use wider integers than needed. Don't use alloca.
9688 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9689
599a9e4f
PE
9690 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9691
99561444
PE
9692 * insdel.c, lisp.h (buffer_overflow): New function.
9693 (insert_from_buffer_1, replace_range, replace_range_2):
9694 * insdel.c (make_gap_larger):
9695 * editfns.c (Finsert_char):
9696 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9697
28177add
PE
9698 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9699
e69dafad
PE
97002011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9701
4baa020d 9702 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9703
b1c46f02
PE
9704 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9705 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9706
e69dafad
PE
9707 * fileio.c: Don't assume EMACS_INT fits in off_t.
9708 (emacs_lseek): New static function.
9709 (Finsert_file_contents, Fwrite_region): Use it.
9710 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9711
566684ea
PE
9712 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9713
e6966cd6
PE
9714 * fns.c: Don't overflow int when computing a list length.
9715 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9716 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9717 truncation on 64-bit hosts. Check for QUIT every
9718 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9719 faster and is responsive enough.
9720 (Flength): Report an error instead of overflowing an integer.
9721 (Fsafe_length): Return a float if the value is not representable
9722 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9723 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9724 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9725
dd0b0efb
PE
9726 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9727 (header_size, word_size): New constants.
9728 (allocate_vectorlike): Don't check size overflow here.
9729 (allocate_vector): Check it here instead, since this is the only
9730 caller of allocate_vectorlike that could cause overflow.
9731 Check that the new vector's length is representable as a fixnum.
9732
86fe5cfe
PE
9733 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9734 The previous code was bogus. For example, next_almost_prime (32)
9735 returned 39, which is undesirable as it is a multiple of 3; and
9736 next_almost_prime (24) returned 25, which is a multiple of 5 so
9737 why was the code bothering to check for multiples of 7?
9738
80e88859
PE
9739 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9740
4a2f0ad6
PE
9741 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9742
f66c7cf8
PE
9743 Variadic C functions now count arguments with ptrdiff_t.
9744 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9745 Back then I didn't know that the Emacs coding style prefers signed int.
9746 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9747 were being counted with int, which may truncate counts on 64-bit
9748 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9749 * lisp.h (struct Lisp_Subr.function.aMANY)
9750 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9751 Arg counts are now ptrdiff_t, not size_t.
9752 All variadic functions and their callers changed accordingly.
9753 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9754 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9755 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9756 * callint.c (Fcall_interactively): Check arg count for overflow,
9757 to avoid potential buffer overrun. Use signed char, not 'int',
9758 for 'varies' array, so that we needn't bother to check its size
9759 calculation for overflow.
9760 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9761 * eval.c (apply_lambda):
9762 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9763 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9764 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9765
a1759b76
PE
9766 * callint.c (Fcall_interactively): Don't use index var as event count.
9767
d96be9fc
PE
9768 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9769 * mem-limits.h (SIZE): Remove; no longer used.
9770
a690a978 9771 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9772
578c21e6
PE
9773 Remove unnecessary casts.
9774 * xterm.c (x_term_init):
9775 * xfns.c (x_set_border_pixel):
9776 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9777 These aren't needed now that we assume ANSI C.
9778
96f53c6c
PE
9779 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9780 It's more likely to cause problems (due to unsigned overflow)
9781 than to cure them.
9782
83c77d31
PE
9783 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9784
ee2079f1
PE
9785 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9786
6da65536
PE
9787 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9788
7147c4a4
PE
9789 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9790
193e32d9
PE
9791 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9792
e5533da6
PE
9793 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9794
9910e595
PE
9795 GLYPH_CODE_FACE returns EMACS_INT, not int.
9796 * dispextern.h (merge_faces):
9797 * xfaces.c (merge_faces):
01103c44
PE
9798 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9799 Don't assume EMACS_INT fits in int.
9910e595 9800
2638320e
PE
9801 * character.h (CHAR_VALID_P): Remove unused parameter.
9802 * fontset.c, lisp.h, xdisp.c: All uses changed.
9803
045eb8d9
PE
9804 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9805
c1f134b5
PE
9806 * fns.c (concat): Minor tuning based on overflow analysis.
9807 This doesn't fix any bugs. Use int to hold character, instead
9808 of constantly refetching from Emacs object. Use XFASTINT, not
9809 XINT, for value known to be a character. Don't bother comparing
9810 a single byte to 0400, as it's always less.
9811
395fcb93 9812 * floatfns.c (Fexpt):
327eeec8
PE
9813 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9814
abbd3d23
PE
9815 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9816 for characters.
9817
684a03ef
PE
9818 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9819
0fed43f3
PE
9820 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9821 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9822 incorrectly succeed when S was a string, because 4294967386 was
9823 truncated before it was used.
9824
8fd02eb7
PE
9825 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9826 Otherwise, an out-of-range integer could cause undefined behavior
9827 on a 64-bit host.
9828
f8c86b69
PE
9829 * composite.c: Use int, not EMACS_INT, for characters.
9830 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9831 EMACS_INT, for values that are known to be in character range.
9832 This doesn't fix any bugs but is the usual style inside Emacs and
9833 may generate better code on 32-bit machines.
9834
34206dd2
PE
9835 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9836 This is for reasons similar to the recent CHAR_STRING fix.
9837 * charset.c (Fencode_char): Check that character arg is actually
9838 a character. Pass an int to ENCODE_CHAR.
9839 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9840 wider than 'int', as a compile-time check to prevent future regressions
9841 in this area.
9842
c5958d4c 9843 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9844
9845 Make sure a 64-bit char is never passed to CHAR_STRING.
9846 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9847 by silently ignoring the top 32 bits, allowing some values
9848 that were far too large to be valid characters.
9849 * character.h: Include <verify.h>.
9850 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9851 arguments are no wider than unsigned, as a compile-time check
9852 to prevent future regressions in this area.
9853 * data.c (Faset):
01103c44 9854 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9855 (Fsubst_char_in_region):
9856 * fns.c (concat):
9857 * xdisp.c (decode_mode_spec_coding):
9858 Adjust to CHAR_STRING's new requirement.
9859 * editfns.c (Finsert_char, Fsubst_char_in_region):
9860 * fns.c (concat): Check that character args are actually
9861 characters. Without this test, these functions did the wrong
9862 thing with wildly out-of-range values on 64-bit hosts.
9863
d37ca623
PE
9864 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9865 These casts should not be needed on 32-bit hosts, either.
9866 * keyboard.c (read_char):
9867 * lread.c (Fload): Remove casts to unsigned.
9868
ea204efb
PE
9869 * lisp.h (UNSIGNED_CMP): New macro.
9870 This fixes comparison bugs on 64-bit hosts.
9871 (ASCII_CHAR_P): Use it.
9872 * casefiddle.c (casify_object):
01103c44 9873 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9874 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9875 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9876 * dispextern.h (FACE_FROM_ID):
9877 * keyboard.c (read_char): Use UNSIGNED_CMP.
9878
41cb286c
PE
9879 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9880 not to EMACS_INT, to avoid GCC warning.
9881
4a1b9832
PE
9882 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9883
55daad71
PE
9884 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9885 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9886 isn't needed on 32-bit machines.
8f95c75c 9887
01103c44
PE
9888 * buffer.c (Fgenerate_new_buffer_name):
9889 Use EMACS_INT for count, not int.
0ceccced 9890 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9891
9892 * data.c (Qcompiled_function): Now static.
9893
c6f072e7
PE
9894 * window.c (window_body_lines): Now static.
9895
20ce5912
PE
9896 * image.c (gif_load): Rename local to avoid shadowing.
9897
9c4c5f81
PE
9898 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9899 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9900 * alloc.c (make_save_value): Integer argument is now of type
9901 ptrdiff_t, not int.
9902 (mark_object): Use ptrdiff_t, not int.
9903 * lisp.h (pD): New macro.
9904 * print.c (print_object): Use it.
9905
c0c5c8ae
PE
9906 * alloc.c: Use EMACS_INT, not int, to count objects.
9907 (total_conses, total_markers, total_symbols, total_vector_size)
9908 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9909 (total_free_floats, total_floats, total_free_intervals)
9910 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9911 Now EMACS_INT, not int. All uses changed.
9912 (Fgarbage_collect): Compute overall total using a double, so that
9913 integer overflow is less likely to be a problem. Check for overflow
9914 when converting back to an integer.
5a25e253
PE
9915 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9916 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9917 These were 'int' variables that could overflow on 64-bit hosts;
9918 they were never used, so remove them instead of repairing them.
211a0b2a 9919 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9920 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9921 Previously, this ceilinged at INT_MAX, but that doesn't work on
9922 64-bit machines.
e46bb31a 9923 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9924
c78baabf 9925 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9926 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9927 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9928 when a (possibly-narrower) signed value would do just as well.
9929 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9930
c9d624c6
PE
9931 * alloc.c: Catch some string size overflows that we were missing.
9932 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9933 for convenience in STRING_BYTES_MAX.
9934 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9935 The definition here is exact; the one in lisp.h was approximate.
9936 (allocate_string_data): Check for string overflow. This catches
9937 some instances we weren't catching before. Also, it catches
9938 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9939 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9940 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9941
c9d624c6
PE
9942 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9943 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9944 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9945
353032ce
PE
9946 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9947
2bccce07
PE
9948 * alloc.c (Fmake_string): Check for out-of-range init.
9949
0ac30604
SM
99502011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9951
9952 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9953
c195f2de
JD
99542011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9955
9956 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9957 xg_get_default_scrollbar_width.
9958
9959 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9960 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9961 (style_changed_cb): Call update_theme_scrollbar_width and call
9962 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9963 all frames (Bug#8505).
9964 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9965 Call gtk_window_set_resizable if HAVE_GTK3.
9966 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9967 and height if HAVE_GTK3 (Bug#8505).
9968 (scroll_bar_width_for_theme): New variable.
9969 (update_theme_scrollbar_width): New function.
9970 (xg_get_default_scrollbar_width): Move code to
9971 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9972 (xg_initialize): Call update_theme_scrollbar_width.
9973
9974 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9975
9976 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9977
e10ac9f1
MR
99782011-06-12 Martin Rudalics <rudalics@gmx.at>
9979
9980 * frame.c (make_frame): Call other_buffer_safely instead of
9981 other_buffer.
9982
9983 * window.c (temp_output_buffer_show): Call display_buffer with
9984 second argument Vtemp_buffer_show_specifiers and reset latter
9985 immediately after the call.
9986 (Vtemp_buffer_show_specifiers): New variable.
9987 (auto_window_vscroll_p, next_screen_context_lines)
9988 (Vscroll_preserve_screen_position): Remove leading asterisks from
9989 doc-strings.
9990
2d3c217e 99912011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9992
7b7f97e8 9993 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9994 * buffer.c (Qclone_number): Remove for now, as it's unused.
9995 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9996 (record_buffer): Remove unused local.
9997 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9998 (set_frame_buffer_list): Remove; unused.
9999 * frame.h (other_visible_frames): Remove decl.
10000 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10001 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10002 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10003 if HAVE_GPM.
10004 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10005 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10006 Define only if HAVE_GPM.
10007 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10008 (update_hints_inhibit): Remove; never set. All uses removed.
10009 * widgetprv.h (emacsFrameClassRec): Remove decl.
10010 * window.c (delete_deletable_window): Now returns void, since it
10011 wasn't returning anything.
10012 (compare_window_configurations): Remove unused locals.
10013 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10014 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10015 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10016 the same widths as pointers. This follows up on the 2011-05-06 patch.
10017 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10018 * xterm.h: Likewise.
10019 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10020
1384b89e
JB
100212011-06-12 Juanma Barranquero <lekktu@gmail.com>
10022
10023 * makefile.w32-in: Update dependencies.
10024 (LISP_H): Add lib/intprops.h.
10025
1100a63c
CY
100262011-06-11 Chong Yidong <cyd@stupidchicken.com>
10027
10028 * image.c (gif_load): Add animation frame delay to the metadata.
10029 (syms_of_image): Use DEFSYM. New symbol `delay'.
10030
6198ccd0
MR
100312011-06-11 Martin Rudalics <rudalics@gmx.at>
10032
10033 * window.c (delete_deletable_window): Re-add.
10034 (Fset_window_configuration): Rewrite to handle dead buffers and
10035 consequently deletable windows.
10036 (window_tree, Fwindow_tree): Remove. Supply functionality in
10037 window.el.
10038 (compare_window_configurations): Simplify code.
10039
b6e3633c
AS
100402011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10041
1ab0dee5
AS
10042 * image.c (imagemagick_load_image): Fix type mismatch.
10043 (Fimagemagick_types): Likewise.
10044
b6e3633c
AS
10045 * window.h (replace_buffer_in_windows): Declare.
10046
9397e56f
MR
100472011-06-11 Martin Rudalics <rudalics@gmx.at>
10048
10049 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10050 Qclone_number. Remove external declaration of Qdelete_window.
10051 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10052 code.
640c8776
SM
10053 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10054 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10055 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10056 buffer list implementation.
10057 (other_buffer_safely): New function.
10058 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10059 calls to replace_buffer_in_windows and
10060 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10061 if allowed.
10062 (record_buffer): Inhibit quitting and rewrite using quittable
10063 functions. Run Qbuffer_list_update_hook if allowed.
10064 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10065 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10066 Move switch-to-buffer to window.el.
9397e56f
MR
10067 (bury-buffer): Move to window.el.
10068 (Vbuffer_list_update_hook): New variable.
10069
10070 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10071 section.
10072
10073 * window.h (resize_frame_windows): Move up in code.
10074 (Fwindow_frame): Remove EXFUN.
10075 (replace_buffer_in_all_windows): Remove prototype.
10076 (replace_buffer_in_windows_safely): Add prototype.
10077
10078 * window.c: Declare Qdelete_window static again. Move down
10079 declaration of select_count.
10080 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10081 (Fother_window): Move to window.el.
10082 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10083 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10084 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10085 window.el.
10086 (replace_buffer_in_windows): Implement by calling
10087 Qreplace_buffer_in_windows.
10088 (replace_buffer_in_all_windows): Remove with some functionality
10089 moved into replace_buffer_in_windows_safely.
10090 (replace_buffer_in_windows_safely): New function.
10091 (select_window_norecord, select_frame_norecord): Move in front
10092 of run_window_configuration_change_hook. Remove now obsolete
10093 declarations.
640c8776
SM
10094 (Fset_window_buffer): Rewrite doc-string.
10095 Call Qrecord_window_buffer.
9397e56f
MR
10096 (keys_of_window): Move binding for other-window to window.el.
10097
b50691aa
CY
100982011-06-11 Chong Yidong <cyd@stupidchicken.com>
10099
10100 * dispextern.h (struct image): Replace data member, whose int_val
10101 and ptr_val fields were not used by anything, with a single
10102 lisp_val object.
10103
10104 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10105 (gif_clear_image, gif_load, imagemagick_load_image)
10106 (gs_clear_image, gs_load): Callers changed.
10107
3f754b86
PE
101082011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10109
cca69397
PE
10110 * buffer.h: Include <time.h>, for time_t.
10111 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10112
109e28d0
PE
10113 Fix minor problems found by static checking.
10114
60737f02
PE
10115 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10116
4b66faf3
PE
10117 Make identifiers static if they are not used in other modules.
10118 * data.c (Qcompiled_function, Qframe, Qvector):
10119 * image.c (QimageMagick, Qsvg):
10120 * minibuf.c (Qmetadata):
10121 * window.c (resize_window_check, resize_root_window): Now static.
10122 * window.h (resize_window_check, resize_root_window): Remove decls.
10123
109e28d0
PE
10124 * window.c (window_deletion_count, delete_deletable_window):
10125 Remove; unused.
46a4ce9e
PE
10126 (window_body_lines): Now static.
10127 (Fdelete_other_windows_internal): Mark vars as initialized.
10128 Make sure 'resize_failed' is initialized.
10129 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10130 (resize_window_apply): Remove unused local.
10131 * window.h (delete_deletable_window): Remove decl.
10132
109e28d0 10133 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10134 (imagemagick_load_image): Fix pointer signedness problem by changing
10135 last arg from unsigned char * to char *. All uses changed.
10136 Also, fix a local for similar reasons.
10137 Remove unused locals. Remove locals to avoid shadowing.
10138 (fn_rsvg_handle_free): Remove; unused.
10139 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10140 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10141
3f754b86
PE
10142 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10143
2547adb1
CY
101442011-06-10 Chong Yidong <cyd@stupidchicken.com>
10145
10146 * image.c (gif_load): Fix omitted cast error introduced by
10147 2011-06-06 change.
10148
2c8e37d4
MR
101492011-06-10 Martin Rudalics <rudalics@gmx.at>
10150
10151 * window.h (resize_proportionally, orig_total_lines)
10152 (orig_top_line): Remove from window structure.
10153 (set_window_height, set_window_width, change_window_heights)
10154 (Fdelete_window): Remove prototypes.
10155 (resize_frame_windows): Remove duplicate declaration.
10156
440a42e3
EZ
101572011-06-10 Eli Zaretskii <eliz@gnu.org>
10158
10159 * window.h (resize_frame_windows, resize_window_check)
10160 (delete_deletable_window, resize_root_window)
10161 (resize_frame_windows): Declare prototypes.
10162
10163 * window.c (resize_window_apply): Make definition be "static" to
10164 match the prototype.
10165
562dd5e9
MR
101662011-06-10 Martin Rudalics <rudalics@gmx.at>
10167
10168 * window.c: Remove declarations of Qwindow_size_fixed,
10169 window_min_size_1, window_min_size_2, window_min_size,
10170 size_window, window_fixed_size_p, enlarge_window, delete_window.
10171 Remove static from declaration of Qdelete_window, it's
10172 temporarily needed by Fbury_buffer.
10173 (replace_window): Don't assign orig_top_line and
10174 orig_total_lines.
10175 (Fdelete_window, delete_window): Remove. Window deletion is
10176 handled by window.el.
640c8776
SM
10177 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10178 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10179 (Fdelete_other_windows): Remove. Deleting other windows is
10180 handled by window.el.
10181 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10182 handled in window.el.
10183 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10184 Window minimum sizes are handled in window.el.
10185 (shrink_windows, size_window, set_window_height)
10186 (set_window_width, change_window_heights, window_height)
10187 (window_width, CURBEG, CURSIZE, enlarge_window)
10188 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10189 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10190 handled in window.el.
10191 (make_dummy_parent): Rename to make_parent_window and give it a
10192 second argument horflag.
10193 (make_window): Don't set resize_proportionally any more.
10194 (Fsplit_window): Remove. Windows are split in window.el.
10195 (save_restore_action, save_restore_orig_size)
10196 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10197 Resize mini windows in window.el.
10198 (grow_mini_window, shrink_mini_window): Implement by calling
10199 Qresize_root_window_vertically, resize_window_check and
10200 resize_window_apply.
640c8776
SM
10201 (saved_window, Fset_window_configuration, save_window_save):
10202 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10203 resize_proportionally.
10204 (window_min_height, window_min_width): Move to window.el.
10205 (keys_of_window): Move bindings for delete-other-windows,
10206 split-window, delete-window and enlarge-window to window.el.
10207
10208 * buffer.c: Temporarily extern Qdelete_window.
10209 (Fbury_buffer): Temporarily call Qdelete_window instead of
10210 Fdelete_window (Fbury_buffer will move to window.el soon).
10211
10212 * frame.c (set_menu_bar_lines_1): Remove code handling
10213 orig_top_line and orig_total_lines.
10214
10215 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10216 set_window_height but set heights directly.
10217 (change_frame_size_1): Use resize_frame_windows.
10218
10219 * xdisp.c (init_xdisp): Don't use set_window_height but set
10220 heights directly.
10221
640c8776
SM
10222 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10223 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10224 run_window_configuration_change_hook.
10225
10226 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10227 instead of change_window_heights and run
10228 run_window_configuration_change_hook.
10229
1a13852e
MR
102302011-06-09 Martin Rudalics <rudalics@gmx.at>
10231
10232 * window.c (replace_window): Rename second argument REPLACEMENT to
10233 NEW. New third argument SETFLAG. Rewrite.
10234 (delete_window, make_dummy_parent): Call replace_window with
10235 third argument 1.
10236 (window_list_1): Move down in code.
10237 (run_window_configuration_change_hook): Move set_buffer part
10238 before select_frame_norecord part in order to unwind correctly.
10239 Rename count1 to count.
10240 (recombine_windows, delete_deletable_window, resize_root_window)
10241 (Fdelete_other_windows_internal)
10242 (Frun_window_configuration_change_hook, make_parent_window)
10243 (resize_window_check, resize_window_apply, Fresize_window_apply)
10244 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10245 (Fdelete_window_internal, Fresize_mini_window_internal):
10246 New functions.
1a13852e
MR
10247 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10248
f3d1777e
MR
102492011-06-08 Martin Rudalics <rudalics@gmx.at>
10250
496e208e
MR
10251 * window.h (window): Add some new members to window structure -
10252 normal_lines, normal_cols, new_total, new_normal, clone_number,
10253 splits, nest, prev_buffers, next_buffers.
10254 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10255 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10256
f3d1777e
MR
10257 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10258 Remove.
496e208e
MR
10259 (make_dummy_parent): Set new members of windows structure.
10260 (make_window): Move down in code. Handle new members of window
10261 structure.
10262 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10263 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10264 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10265 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10266 (Fset_window_next_buffers, Fset_window_clone_number):
10267 New functions.
496e208e
MR
10268 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10269 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10270 Doc-string fixes.
10271 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10272 Argument WINDOW can be now internal window too.
10273 (Fwindow_use_time): Move up in code.
10274 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10275 Rewrite doc-string.
10276 (Fset_window_configuration, saved_window)
10277 (Fcurrent_window_configuration, save_window_save): Handle new
10278 members of window structure.
b9e809c2
MR
10279 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10280 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10281 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10282 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10283 Qget_mru_window, Qresize_root_window,
10284 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10285 Qauto_buffer_name; staticpro them.
f3d1777e 10286
abde8f8c
MR
102872011-06-07 Martin Rudalics <rudalics@gmx.at>
10288
10289 * window.c (Fwindow_total_size, Fwindow_left_column)
10290 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10291 (Fwindow_list_1): New functions.
10292 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10293 (Fwindow_width, Fscroll_left, Fscroll_right):
10294 Use window_body_cols instead of window_box_text_cols.
10295 (delete_window, Fset_window_configuration):
10296 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10297 (delete_all_subwindows): Take a window as argument and not a
10298 structure. Rewrite.
190b47e6
MR
10299 (window_loop): Remove handling of GET_LRU_WINDOW and
10300 GET_LARGEST_WINDOW.
10301 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10302
10303 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10304 window_box_text_cols. delete_all_subwindows now takes a
10305 Lisp_Object as argument.
abde8f8c 10306
640c8776
SM
10307 * indent.c (compute_motion, Fcompute_motion):
10308 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10309
fa8a67e6
MR
10310 * frame.c (delete_frame): Call delete_all_subwindows with root
10311 window as argument.
10312
a54e3482
DC
103132011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10314
10315 * fns.c (Fputhash): Document return value.
10316
60002bf5
CY
103172011-06-06 Chong Yidong <cyd@stupidchicken.com>
10318
10319 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10320
0c671da6 103212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10322
b862a52a 10323 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10324
be44ca6c
PE
10325 Check for overflow when converting integer to cons and back.
10326 * charset.c (Fdefine_charset_internal, Fdecode_char):
10327 Use cons_to_unsigned to catch overflow.
10328 (Fencode_char): Use INTEGER_TO_CONS.
10329 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10330 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10331 * data.c (long_to_cons, cons_to_long): Remove.
10332 (cons_to_unsigned, cons_to_signed): New functions.
10333 These signal an error for invalid or out-of-range values.
10334 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10335 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10336 * font.c (Ffont_variation_glyphs):
10337 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10338 * lisp.h: Include <intprops.h>.
10339 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10340 (cons_to_signed, cons_to_unsigned): New decls.
10341 (long_to_cons, cons_to_long): Remove decls.
10342 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10343 (Fprimitive_undo): Use CONS_TO_INTEGER.
10344 * xfns.c (Fx_window_property): Likewise.
10345 * xselect.c: Include <limits.h>.
10346 (x_own_selection, selection_data_to_lisp_data):
10347 Use INTEGER_TO_CONS.
10348 (x_handle_selection_request, x_handle_selection_clear)
10349 (x_get_foreign_selection, Fx_disown_selection_internal)
10350 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10351 (lisp_data_to_selection_data): Use cons_to_unsigned.
10352 (x_fill_property_data): Use cons_to_signed.
10353 Report values out of range.
10354
d1f3d2af
PE
10355 Check for buffer and string overflow more precisely.
10356 * buffer.h (BUF_BYTES_MAX): New macro.
10357 * lisp.h (STRING_BYTES_MAX): New macro.
10358 * alloc.c (Fmake_string):
10359 * character.c (string_escape_byte8):
10360 * coding.c (coding_alloc_by_realloc):
10361 * doprnt.c (doprnt):
10362 * editfns.c (Fformat):
10363 * eval.c (verror):
10364 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10365 since they may not be the same number.
10366 * editfns.c (Finsert_char):
10367 * fileio.c (Finsert_file_contents):
10368 Likewise for BUF_BYTES_MAX.
10369
dd52fcea
PE
10370 * image.c: Use ptrdiff_t, not int, for sizes.
10371 (slurp_file): Switch from int to ptrdiff_t.
10372 All uses changed.
10373 (slurp_file): Check that file size fits in both size_t (for
10374 malloc) and ptrdiff_t (for sanity and safety).
10375
7f9bbdbb
PE
10376 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10377 if b->modtime has its maximal value.
10378
dfe18f82
PE
10379 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10380
84acfcf0
PE
10381 Don't assume time_t can fit into int.
10382 * buffer.h (struct buffer.modtime): Now time_t, not int.
10383 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10384 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10385
ccd9a01a
PE
10386 Minor fixes for signed vs unsigned integers.
10387 * character.h (MAYBE_UNIFY_CHAR):
10388 * charset.c (maybe_unify_char):
10389 * keyboard.c (read_char, reorder_modifiers):
10390 XINT -> XFASTINT, since the integer must be nonnegative.
10391 * ftfont.c (ftfont_spec_pattern):
10392 * keymap.c (access_keymap, silly_event_symbol_error):
10393 XUINT -> XFASTINT, since the integer must be nonnegative.
10394 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10395 since it makes no difference and we prefer signed.
10396 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10397 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10398 nonnegative.
10399
d6d100dd
SM
104002011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10401
10402 * window.h (Fwindow_frame): Declare.
10403
2b6148e4
PE
104042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10405
10406 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10407 (SPARE_MEMORY): Always define.
10408 (LARGE_REQUEST): Remove.
10409 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10410
f230ecc9
MR
104112011-06-06 Martin Rudalics <rudalics@gmx.at>
10412
727e958e
MR
10413 * lisp.h: Move EXFUNS for Fframe_root_window,
10414 Fframe_first_window and Fset_frame_selected_window to window.h.
10415
10416 * window.h: Move EXFUNS for Fframe_root_window,
10417 Fframe_first_window and Fset_frame_selected_window here from
10418 lisp.h.
10419
10420 * frame.c (Fwindow_frame, Fframe_first_window)
10421 (Fframe_root_window, Fframe_selected_window)
10422 (Fset_frame_selected_window): Move to window.c.
10423 (Factive_minibuffer_window): Move to minibuf.c.
10424 (Fother_visible_frames_p): New function.
10425
10426 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10427
f230ecc9
MR
10428 * window.c (decode_window, decode_any_window): Move up in code.
10429 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10430 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10431 (Fwindow_buffer): Move up and rewrite doc-string.
10432 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10433 (Fwindow_prev): New functions.
727e958e
MR
10434 (Fwindow_frame): Move here from frame.c. Accept any window as
10435 argument.
10436 (Fframe_root_window, Fframe_first_window)
10437 (Fframe_selected_window): Move here from frame.c. Accept frame
10438 or arbitrary window as argument. Update doc-strings.
10439 (Fminibuffer_window): Move up in code.
10440 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10441 (Fset_frame_selected_window): Move here from frame.c.
10442 Marginal rewrite.
727e958e
MR
10443 (Fselected_window, select_window, Fselect_window): Move up in
10444 code. Minor doc-string fixes.
f230ecc9 10445
4d09bcf6
PE
104462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10447
10448 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10449 Do not assume that spare memory exists; that assumption is valid
10450 only if SYSTEM_MALLOC.
10451 (LARGE_REQUEST): New macro, so that the issue of large requests
10452 is separated from the issue of spare memory.
10453
810928a2
AS
104542011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10455
172418ad
AS
10456 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10457 format. (Bug#8806)
10458
43f862f7
AS
10459 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10460
810928a2
AS
10461 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10462 before statements.
10463
a059fe24
JD
104642011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10465
10466 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10467
10468 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10469
10470 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10471 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10472
989bf368
JB
104732011-06-05 Juanma Barranquero <lekktu@gmail.com>
10474
10475 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10476
4b80f674
CY
104772011-06-04 Chong Yidong <cyd@stupidchicken.com>
10478
10479 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10480 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10481 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10482 New error handlers.
4b80f674
CY
10483 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10484 Obey Vx_select_enable_clipboard_manager. Catch errors in
10485 x_clipboard_manager_save (Bug#8779).
10486 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10487 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10488
99a33b77 104892011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10490
10491 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10492
99a33b77 104932011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10494
10495 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10496 in the current matrix if keep_current_p is non-zero.
10497
8264569d
EZ
104982011-06-04 Eli Zaretskii <eliz@gnu.org>
10499
10500 * bidi.c (bidi_level_of_next_char): Fix last change.
10501
57f97249
EZ
105022011-06-03 Eli Zaretskii <eliz@gnu.org>
10503
fec2107c 10504 Support bidi reordering of text covered by display properties.
57f97249 10505
fec2107c
EZ
10506 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10507 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10508 (bidi_cache_search, bidi_cache_iterator_state)
10509 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10510 (bidi_level_of_next_char, bidi_move_to_visually_next):
10511 Support character positions inside a run of characters covered by a
fec2107c
EZ
10512 display string.
10513 (bidi_paragraph_init, bidi_resolve_explicit_1)
10514 (bidi_level_of_next_char): Call bidi_fetch_char and
10515 bidi_fetch_char_advance instead of FETCH_CHAR and
10516 FETCH_CHAR_ADVANCE.
10517 (bidi_init_it): Initialize new members.
10518 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10519 definitions.
10520 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10521 instead of using explicit *_CHAR codes.
d6d100dd
SM
10522 (bidi_resolve_explicit, bidi_resolve_weak):
10523 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10524 bidirectional text is supported only in multibyte buffers.
10525 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10526 it to initialize the frame_window_p member of struct bidi_it.
10527 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10528 (bidi_resolve_explicit, bidi_resolve_weak)
10529 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10530 bidi_it->nchars is non-positive.
10531 (bidi_level_of_next_char): Don't try to lookup the cache for the
10532 next/previous character if nothing is cached there yet, or if we
10533 were just reseat()'ed to a new position.
c40e2fb2 10534
0e14fe90
EZ
10535 * xdisp.c (set_cursor_from_row): Set start and stop points
10536 according to the row's direction when priming the loop that looks
10537 for the glyph on which to display cursor.
10538 (single_display_spec_intangible_p): Function deleted.
10539 (display_prop_intangible_p): Reimplement to call
10540 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10541 Accept 3 additional arguments needed by handle_display_spec.
10542 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10543 values: lists, `(when COND...)' forms, etc.
10544 (single_display_spec_string_p): Support property values that are
10545 lists with the argument STRING its top-level element.
10546 (display_prop_string_p): Fix the condition for processing a
10547 property that is a list to be consistent with handle_display_spec.
fec2107c 10548 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10549 last portion of handle_display_prop.
10550 (compute_display_string_pos): Accept additional argument
10551 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10552 value of a `display' property is a "replacing spec".
10553 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10554 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10555 the display property, but just return a value indicating whether
10556 the display property will replace the characters it covers.
10557 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10558 frame_window_p members of struct bidi_it.
d6d100dd
SM
10559 (compute_display_string_pos, compute_display_string_end):
10560 New functions.
fec2107c
EZ
10561 (push_it): Accept second argument POSITION, where pop_it should
10562 jump to continue iteration.
10563 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10564
fec2107c
EZ
10565 * keyboard.c (adjust_point_for_property): Adjust the call to
10566 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10567
10568 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10569 (bidi_init_it): Update prototypes.
10570 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10571 (compute_display_string_pos, compute_display_string_end):
10572 Declare prototypes.
fec2107c
EZ
10573 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10574 EMACS_INT.
fc6f18ce 10575
40087514 105762011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10577
57f53182
PE
10578 Malloc failure behavior now depends on size of allocation.
10579 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10580 * lisp.h: Change signatures accordingly.
10581 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10582 All callers changed. (Bug#8762)
10583
10584 * gnutls.c: Use Emacs's memory allocators.
10585 Without this change, the gnutls library would invoke malloc etc.
10586 directly, which causes problems on non-SYNC_INPUT hosts, and which
10587 runs afoul of improving memory_full behavior. (Bug#8761)
10588 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10589 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10590 xfree instead of the default malloc, realloc, free.
10591 (Fgnutls_boot): No need to check for memory allocation failure,
10592 since xmalloc does that for us.
10593
ac32cd99 10594 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10595 * category.c (hash_get_category_set):
10596 * ccl.c (ccl_driver):
10597 * charset.c (Fdefine_charset_internal):
10598 * charset.h (struct charset.hash_index):
10599 * composite.c (get_composition_id, gstring_lookup_cache)
10600 (composition_gstring_put_cache):
10601 * composite.h (struct composition.hash_index):
10602 * dispextern.h (struct image.hash):
10603 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10604 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10605 (hashfn_equal, hashfn_user_defined, make_hash_table)
10606 (maybe_resize_hash_table, hash_lookup, hash_put)
10607 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10608 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10609 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10610 * image.c (make_image, search_image_cache, lookup_image)
10611 (xpm_put_color_table_h):
10612 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10613 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10614 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10615 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10616 * alloc.c (allocate_vectorlike):
10617 Check for overflow in vector size calculations.
10618 * ccl.c (ccl_driver):
10619 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10620 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10621 need to be updated by these changes.
40087514
PE
10622 * fns.c (make_hash_table, maybe_resize_hash_table):
10623 Check for integer overflow with large hash tables.
0de4bb68
PE
10624 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10625 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10626 (SXHASH_REDUCE): New macro.
10627 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10628 Use it instead of discarding useful hash info with large hash values.
10629 (sxhash_float): New function.
10630 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10631 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10632 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10633 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10634 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10635 Adjust signatures to match updated version of code.
10636 (consing_since_gc): Now EMACS_INT, since a single hash table can
10637 use more than INT_MAX bytes.
10638
698d32e2
DN
106392011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10640
10641 Make it possible to build with GCC-4.6+ -O2 -flto.
10642
10643 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10644
fd6fa53f
SM
106452011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10646
10647 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10648 Call minibuffer-inactive-mode.
10649
864db017
JB
106502011-05-31 Juanma Barranquero <lekktu@gmail.com>
10651
10652 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10653 Update dependencies.
10654
2ad0baf4
DN
106552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10656
10657 * data.c (init_data): Remove code for UTS, this system is not
10658 supported anymore.
10659
4fcc2638
DN
106602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10661
10662 Don't force ./temacs to start in terminal mode.
10663
10664 * frame.c (make_initial_frame): Initialize faces in all cases, not
10665 only when CANNOT_DUMP is defined.
10666 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10667
c56e0fd5
DN
106682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10669
10670 * dispnew.c (add_window_display_history): Use const for the string
10671 pointer. Remove declaration, not needed.
10672
333d54da 106732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10674
55d4c1b2 10675 Use 'inline', not 'INLINE'.
333d54da 10676 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10677 * alloc.c, fontset.c (INLINE): Remove.
10678 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10679 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10680 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10681 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10682 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10683
738db178
DN
106842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10685
10686 Make it possible to run ./temacs.
10687
10688 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10689 syms_of_callproc does the same thing. Remove test for
10690 "initialized", do it in the caller.
10691 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10692
620c53a6
SM
106932011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10694
10695 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10696 (read_minibuf): Use get_minibuffer.
10697 (syms_of_minibuf): Use DEFSYM.
10698 (Qmetadata): New var.
10699 * data.c (Qbuffer): Don't make it static.
10700 (syms_of_data): Use DEFSYM.
10701
e003a292
PE
107022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10703
10704 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10705 (CCL_CODE_MIN): New macro.
10706
ed008a6d
PE
107072011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10708
3687c2ef
PE
10709 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10710
ed008a6d
PE
10711 * eval.c (Qdebug): Now static.
10712 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10713 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10714 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10715
d66c4c7c
CY
107162011-05-29 Chong Yidong <cyd@stupidchicken.com>
10717
10718 * image.c: Various fixes to ImageMagick code comments.
10719 (Fimagemagick_types): Doc fix.
10720
5fbc2025
PE
107212011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10722
0196f88a
PE
10723 Minor fixes prompted by GCC 4.6.0 warnings.
10724
10725 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10726
5fbc2025
PE
10727 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10728 (x_clipboard_manager_save_all): Move extern decl to ...
10729 * xterm.h: ... here, so that it can be checked for consistency.
10730
1dd3c2d9
CY
107312011-05-29 Chong Yidong <cyd@stupidchicken.com>
10732
10733 * xselect.c (x_clipboard_manager_save_frame)
10734 (x_clipboard_manager_save_all): New functions.
10735 (Fx_clipboard_manager_save): Lisp function deleted.
10736
10737 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10738 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10739
10740 * xterm.h: Update prototype.
10741
5ba6571d
WX
107422011-05-28 William Xu <william.xwl@gmail.com>
10743
10744 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10745 exiting (Bug#8239).
10746
3eaff834
JM
107472011-05-28 Jim Meyering <meyering@redhat.com>
10748
e1900994 10749 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10750 * fns.c (to_uchar): Define.
10751 (crypto_hash_function): Use it to convert some newly-signed
10752 variables to unsigned, to avoid sign-extension bugs. For example,
10753 without this change, (md5 "truc") would evaluate to
10754 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10755 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10756 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10757
0f6990a7
PE
107582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10759
10760 Integer overflow fixes.
c8a9ca5a 10761
08686060
PE
10762 * dbusbind.c: Serial number integer overflow fixes.
10763 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10764 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10765 to hold a serial number that is too large for a fixnum.
10766 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10767 Check for serial numbers out of range. Decode any serial number
59568bf0 10768 that was so large that it became a float. (Bug#8722)
08686060 10769
2d1fc3c7
PE
10770 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10771 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10772 Use XFASTINT rather than XUINT when numbers are nonnegative.
10773 (xd_append_arg, Fdbus_method_return_internal):
10774 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10775 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10776 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10777 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10778 (Bug#8722)
2d1fc3c7 10779
c8a9ca5a
PE
10780 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10781
519e1d69
PE
10782 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10783
6df6ae42 10784 ccl: Add integer overflow checks.
30569699
PE
10785 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10786 (IN_INT_RANGE): New macros.
10787 (ccl_driver): Use them to check for integer overflow when
10788 decoding a CCL program. Many of the new checks are whether XINT (x)
10789 fits in int; it doesn't always, on 64-bit hosts. The new version
10790 doesn't catch all possible integer overflows, but it's an
847044ea 10791 improvement. (Bug#8719)
30569699 10792
c11285dc
PE
10793 * alloc.c (make_event_array): Use XINT, not XUINT.
10794 There's no need for unsigned here.
10795
fdccd48e
PE
10796 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10797 This follows up to the 2011-05-06 change that substituted uintptr_t
10798 for EMACS_INT. This case wasn't caught back then.
10799
37910ab2
PE
10800 Rework Fformat to avoid integer overflow issues.
10801 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10802 now (part of C89). Include <verify.h>.
10803 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10804 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10805 (Fformat): Avoid the prepass trying to compute sizes; it was only
10806 approximate and thus did not catch overflow reliably. Instead, walk
10807 through the format just once, formatting and computing sizes as we go,
10808 checking for integer overflow at every step, and allocating a larger
10809 buffer as needed. Keep track separately whether the format is
10810 multibyte. Keep only the most-recently calculated precision, rather
10811 than them all. Record whether each argument has been converted to
10812 string. Use EMACS_INT, not int, for byte and char and arg counts.
10813 Support field widths and precisions larger than INT_MAX. Avoid
10814 sprintf's undefined behavior with conversion specifications such as %#d
10815 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10816 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10817 formatting out-of-range floating point numbers with int
9173deec 10818 formats. (Bug#8668)
37910ab2 10819
2e6578fb
PE
10820 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10821
0ae6bdee
PE
10822 * data.c: Avoid integer truncation in expressions involving floats.
10823 * data.c: Include <intprops.h>.
10824 (arith_driver): When there's an integer overflow in an expression
10825 involving floating point, convert the integers to floating point
10826 so that the resulting value does not suffer from catastrophic
10827 integer truncation. For example, on a 64-bit host (* 4
10828 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10829 Do not rely on undefined behavior after integer overflow.
10830
de883a70
PE
10831 merge count_size_as_multibyte, parse_str_to_multibyte
10832 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10833 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10834 Check for integer overflow.
10835 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10836 since it's now a duplicate of the other. This is more of
10837 a character than a buffer op, so better that it's in character.c.
10838 * fns.c, print.c: Adjust to above changes.
10839
2ff916cb
PE
108402011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10841
10842 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10843
f1b54466
PE
108442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10845
fb1ac845
PE
10846 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10847 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10848 (x_clipboard_manager_save): Now static.
10849 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10850
f1b54466
PE
10851 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10852 (crypto_hash_function): Now static.
10853 Fix pointer signedness problems. Avoid unnecessary initializations.
10854
a9f737ee
CY
108552011-05-27 Chong Yidong <cyd@stupidchicken.com>
10856
10857 * termhooks.h (Vselection_alist): Make it terminal-local.
10858
10859 * terminal.c (create_terminal): Initialize it.
10860
10861 * xselect.c: Support for clipboard managers.
10862 (Vselection_alist): Move to termhooks.h as terminal-local var.
10863 (LOCAL_SELECTION): New macro.
10864 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10865 (symbol_to_x_atom): Remove gratuitous arg.
10866 (x_handle_selection_request, lisp_data_to_selection_data)
10867 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10868 (x_own_selection, x_get_local_selection, x_convert_selection):
10869 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10870 (some_frame_on_display): Delete unused function.
10871 (Fx_own_selection_internal, Fx_get_selection_internal)
10872 (Fx_disown_selection_internal, Fx_selection_owner_p)
10873 (Fx_selection_exists_p): New optional frame arg.
10874 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10875 (x_handle_selection_clear): Don't treat other terminals with the
10876 same keyboard specially. Use the terminal-local Vselection_alist.
10877 (x_clear_frame_selections): Use Frun_hook_with_args.
10878
10879 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10880
10881 * xterm.h: Add support for those atoms.
10882
e067f0c1
CY
108832011-05-26 Chong Yidong <cyd@stupidchicken.com>
10884
10885 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10886 (converted_selections, conversion_fail_tag): New global variables.
10887 (x_selection_request_lisp_error): Free the above.
10888 (x_get_local_selection): Remove unnecessary code.
10889 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10890 of converted selections stored in converted_selections.
10891 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10892 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10893 (x_convert_selection): New function.
10894 (x_handle_selection_event): Simplify.
10895 (x_get_foreign_selection): Don't ignore incoming requests while
10896 waiting for an answer; this will fail when we implement
10897 SAVE_TARGETS, and seems unnecessary anyway.
10898 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10899 (Vx_sent_selection_functions): Doc fix.
10900
0f4aebc0
LL
109012011-05-26 Leo Liu <sdl.web@gmail.com>
10902
10903 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10904
e61124cd
YM
109052011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10906
10907 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10908
10909 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10910 for fringe update if it has periodic bitmap.
ac389d0c 10911 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10912 and fringe_bitmap_periodic_p.
10913
10914 * fringe.c (get_fringe_bitmap_data): New function.
10915 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10916 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10917 row. Mark glyph row for fringe update if periodicity changed.
10918
10919 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10920 for fringe update unless it has periodic bitmap.
10921
f16d9837
KH
109222011-05-25 Kenichi Handa <handa@m17n.org>
10923
10924 * xdisp.c (get_next_display_element): Set correct it->face_id for
10925 a static composition.
10926
e1b90ef6
LL
109272011-05-24 Leo Liu <sdl.web@gmail.com>
10928
10929 * deps.mk (fns.o):
10930 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10931
10932 * fns.c (crypto_hash_function, Fsha1): New function.
10933 (Fmd5): Use crypto_hash_function.
10934 (syms_of_fns): Add Ssha1.
10935
7400048f
PE
109362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10937
10938 * gnutls.c: Remove unused macros.
10939 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10940 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10941 Remove macros that are defined and never used.
10942 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10943
abb71cf4
CY
109442011-05-22 Chong Yidong <cyd@stupidchicken.com>
10945
10946 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10947 (Fx_get_selection_internal): Minor cleanup.
10948 (Fx_own_selection_internal): Rename arguments for consistency with
10949 select.el.
10950
6307db39
PE
109512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10952
10953 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10954
f3d4e0a4
CY
109552011-05-22 Chong Yidong <cyd@stupidchicken.com>
10956
10957 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10958
4d8ade89
YM
109592011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10960
10961 * dispnew.c (scrolling_window): Don't exclude the case that the
10962 last enabled row in the desired matrix touches the bottom boundary.
10963
32078c8d
GM
109642011-05-21 Glenn Morris <rgm@gnu.org>
10965
10966 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10967 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10968 and add some more files.
32078c8d 10969
7285dc67
EZ
109702011-05-20 Eli Zaretskii <eliz@gnu.org>
10971
10972 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10973 report_file_error introduced by the change from 2011-05-07.
10974
89d1bd22
PE
109752011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10976
10977 * systime.h (Time): Define only if emacs is defined.
10978 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10979 where the include path doesn't have X11/X.h by default. See
10980 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10981
cd394be1 109822011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10983
10984 * composite.c (find_automatic_composition): Fix previous change.
10985
b9704ad9
GM
109862011-05-20 Glenn Morris <rgm@gnu.org>
10987
10988 * lisp.mk: New file, split from Makefile.in.
10989 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10990 (shortlisp): Remove.
10991 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10992
4a720484
GM
109932011-05-19 Glenn Morris <rgm@gnu.org>
10994
10995 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10996 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10997 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10998 (lisp): Set the order to that of loadup.el.
10999 (shortlisp): Make it a copy of $lisp.
11000 (SOME_MACHINE_LISP): Remove.
11001 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11002 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11003
a28d4396
KH
110042011-05-18 Kenichi Handa <handa@m17n.org>
11005
11006 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11007 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11008 (find_automatic_composition): Mostly rewrite for efficiency.
11009
a2b1fa8e
JB
110102011-05-18 Juanma Barranquero <lekktu@gmail.com>
11011
11012 * makefile.w32-in: Update dependencies.
11013
8e1f5610
CS
110142011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11015
11016 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11017 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11018
7025ee00 110192011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11020
cdfa6eab
PE
11021 Fix some integer overflow issues, such as string length overflow.
11022
06d6db33
PE
11023 * insdel.c (count_size_as_multibyte): Check for string overflow.
11024
2b4560a8
PE
11025 * character.c (lisp_string_width): Check for string overflow.
11026 Use EMACS_INT, not int, for string indexes and lengths; in
11027 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11028 the resulting string length overflows an EMACS_INT; instead,
11029 report a string overflow if no precision given. When checking for
11030 precision exhaustion, use a check that cannot possibly have
11031 integer overflow. (Bug#8675)
11032 * character.h (lisp_string_width): Adjust to new signature.
11033
cb93f9be
PE
11034 * alloc.c (string_overflow): New function.
11035 (Fmake_string): Use it. This doesn't change behavior, but saves
11036 a few bytes and will simplify future changes.
11037 * character.c (string_escape_byte8): Likewise.
11038 * lisp.h (string_overflow): New decl.
11039
1a1f3366
PE
11040 Fixups, following up to the user-interface timestamp change.
11041 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11042 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11043 * msdos.c (mouse_get_pos): Likewise.
11044 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11045 * w32gui.h (Time): Define by including "systime.h" rather than by
11046 declaring it ourselves. (Bug#8664)
11047
d4e3e4d3
PE
11048 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11049 * image.c (clear_image_cache): Likewise.
11050
f6a24d19
PE
11051 * term.c (term_mouse_position): Don't assume time_t wraparound.
11052
08dc5ae6
PE
11053 Be more systematic about user-interface timestamps.
11054 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11055 and sometimes 'EMACS_UINT', to represent these timestamps.
11056 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11057 This makes the code easier to follow, and makes it easier to catch
11058 integer overflow bugs such as Bug#8664.
11059 * frame.c (Fmouse_position, Fmouse_pixel_position):
11060 Use Time, not unsigned long, for user-interface timestamps.
11061 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11062 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11063 * keyboard.h (last_event_timestamp): Likewise.
11064 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11065 * menu.h (xmenu_show): Likewise.
11066 * term.c (term_mouse_position): Likewise.
11067 * termhooks.h (struct input_event.timestamp): Likewise.
11068 (struct terminal.mouse_position_hook): Likewise.
11069 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11070 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11071 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11072 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11073 what it was before.
11074 * menu.h, termhooks.h: Include "systime.h", for Time.
11075
8e55734a
PE
11076 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11077 Don't assume that the difference between two unsigned long values
11078 can fit into an integer. At this point, we know button_down_time
11079 <= event->timestamp, so the difference must be nonnegative, so
11080 there's no need to cast the result if double-click-time is
11081 nonnegative, as it should be; check that it's nonnegative, just in
11082 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11083 apart (about 25 days). (Bug#8664)
8e55734a 11084
841f1b75 11085 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11086 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11087
3e26f69c
PE
11088 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11089 that always fit in int. Use a sentinel instead of a counter, to
11090 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11091 * frame.h (struct frame): Use int for menu_bar_items_used
11092 instead of EMACS_INT, since it always fits in int.
3e26f69c 11093
5cc152c0
PE
11094 * menu.c (grow_menu_items): Check for int overflow.
11095
d89eb65e
PE
11096 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11097
5235bd3e
PE
11098 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11099 Before, the code was not consistent. These values cannot exceed
11100 2**31 - 1 so there's no need to make them unsigned.
11101 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11102 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11103 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11104 as modifiers.
11105 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11106
bc827e23
PE
11107 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11108 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11109 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11110 presumably because the widths might not match.
11111
78eb494e
PE
11112 * window.c (size_window): Avoid needless test at loop start.
11113
04f2d78b
CB
111142011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11115
11116 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11117
d2fc7e3d 111182011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11119
11120 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11121
d2fc7e3d 111222011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11123
11124 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11125 `width' to `bar_area_x' and `bar_area_width', respectively.
11126 (x_scroll_run): Take account of fringe background extension.
11127
04f2d78b
CB
11128 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11129 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11130 `bar_area_width', respectively.
11131 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11132 background extension.
11133
79b70037
GM
111342011-05-10 Jim Meyering <meyering@redhat.com>
11135
11136 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11137
2f142cc5
JB
111382011-05-10 Juanma Barranquero <lekktu@gmail.com>
11139
11140 * image.c (Finit_image_library): Return t for built-in image types,
11141 like pbm and xbm. (Bug#8640)
11142
57679c86
AS
111432011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11144
11145 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11146
888c9e86
EZ
111472011-05-07 Eli Zaretskii <eliz@gnu.org>
11148
b0512a1d
EZ
11149 * w32console.c (Fset_screen_color): Doc fix.
11150 (Fget_screen_color): New function.
11151 (syms_of_ntterm): Defsubr it.
11152
7285dc67
EZ
11153 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11154 unlink the temporary file if Fcall_process didn't create it in the
11155 first place.
11156 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11157 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11158 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11159 cue to call_process_cleanup not to close that handle.
11160
4d3fcc8e
BK
111612011-05-07 Ben Key <bkey76@gmail.com>
11162
11163 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11164 one of two shell specific rules, either bootstrap-temacs-CMD or
11165 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11166 to the previous implementation of the bootstrap-temacs rule.
11167 The bootstrap-temacs-CMD rule is similar to the previous
11168 implementation of the bootstrap-temacs rule except that it
11169 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11170 variable.
11171
11172 These changes, along with some changes to nt/configure.bat,
11173 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11174 earlier fix to add support for --cflags and --ldflags options
11175 that include quotes so that it works whether make uses cmd or
11176 sh as the shell.
11177
b4289b64
MA
111782011-05-06 Michael Albinus <michael.albinus@gmx.de>
11179
11180 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11181 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11182 is a constant.
11183 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11184 a string. Handle both cases.
11185 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11186 (Fdbus_register_method): Use Qinvalid_function.
11187
af4c0e28
JB
111882011-05-06 Juanma Barranquero <lekktu@gmail.com>
11189
11190 * makefile.w32-in: Update dependencies.
11191 (LISP_H): Add inttypes.h and stdin.h.
11192 (PROCESS_H): Add unistd.h.
11193
c51453d9
EZ
111942011-05-06 Eli Zaretskii <eliz@gnu.org>
11195
11196 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11197 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11198
8ff0ac3c 111992011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11200
4c4b566b
PE
11201 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11202
aab2b9b5
PE
11203 * term.c (vfatal): Remove stray call to va_end.
11204 It's not needed and the C Standard doesn't allow it here anyway.
11205
c378da0b
PE
11206 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11207 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11208
288b08c7
PE
11209 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11210 bytes.
11211
e3601888
PE
11212 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11213
db6c0e74
PE
11214 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11215
dd5963ea
PE
11216 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11217
88c9450f
PE
11218 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11219
2f9442b8
PE
11220 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11221
c032b5f8
PE
11222 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11223 * charset.c (Fdefine_charset_internal): Don't initialize
11224 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11225 32-bit int (Bug#8600).
a108c10b
PE
11226
11227 * lread.c (read_integer): Be more consistent with string-to-number.
11228 Use string_to_number to do the actual conversion; this avoids
11229 rounding errors and fixes some other screwups. Without this fix,
11230 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11231 (digit_to_number): Move earlier, for benefit of read_integer.
11232 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11233 not a digit in any supported base. (Bug#8602)
a108c10b 11234
ad5f9eea
PE
11235 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11236
aec1708a
PE
11237 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11238 to match comment at start of function. This also removes a
11239 GCC warning about overflow in a 32+64-bit port.
11240
47be4ab5
PE
11241 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11242
371cac43
PE
11243 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11244 Reported by Stefan Monnier in
11245 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11246 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11247 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11248
d01a7826
PE
11249 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11250 (EMACS_UINTPTR): Likewise, with uintptr_t.
11251
7fd47d5c
PE
11252 * lisp.h: Prefer 64-bit EMACS_INT if available.
11253 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11254 on 32-bit hosts that have 64-bit int, so that they can access
11255 large files.
122b0c86
PE
11256 However, temporarily disable this change unless the temporary
11257 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11258
8727937b
PE
11259 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11260
8ac068ac
PE
11261 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11262 This removes an assumption that EMACS_INT and long are the same
11263 width as pointers. The assumption is true for Emacs porting targets
11264 now, but we want to make other targets possible.
11265 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11266 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11267 In the rest of the code, change types of integers that hold casted
11268 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11269 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11270 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11271 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11272 No need to cast type when ORing.
11273 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11274 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11275 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11276 assume EMACS_INT is the same width as char *.
11277 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11278 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11279 Remove no-longer-needed casts.
11280 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11281 (xg_tool_bar_help_callback, xg_make_tool_item):
11282 Use EMACS_INTPTR to hold an integer
11283 that will be cast to void *; this can avoid a GCC warning
11284 if EMACS_INT is not the same width as void *.
11285 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11286 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11287 (current_message_1, set_message_1):
11288 Use a local to convert to proper width without a cast.
11289 * xmenu.c (dialog_selection_callback): Likewise.
11290
ede49d71
PE
11291 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11292 Also, don't assume VALBITS / RAND_BITS is less than 5,
11293 and don't rely on undefined behavior when shifting a 1 left into
11294 the sign bit.
11295 * lisp.h (get_random): Change signature to match.
11296
2f30ecd0
PE
11297 * lread.c (hash_string): Use size_t, not int, for hash computation.
11298 Normally we prefer signed values; but hashing is special, because
11299 it's better to use unsigned division on hash table sizes so that
11300 the remainder is nonnegative. Also, size_t is the natural width
11301 for hashing into memory. The previous code used 'int', which doesn't
11302 retain enough info to hash well into very large tables.
11303 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11304
2a866e7b
PE
11305 * dbusbind.c: Don't possibly lose pointer info when converting.
11306 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11307 Use XPNTR rather than XHASH, so that the high-order bits of
11308 the pointer aren't lost when converting through void *.
11309
51639eac
PE
11310 * eval.c (Fautoload): Don't double-shift a pointer.
11311
92394119
PE
11312 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11313
dbdb9a7c
JB
113142011-05-06 Juanma Barranquero <lekktu@gmail.com>
11315
11316 * gnutls.c (DEF_GNUTLS_FN):
11317 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11318
db7a0b4f
AS
113192011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11320
11321 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11322 marker. (Bug#8610)
11323
cd394be1 113242011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11325
11326 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11327 New version that can reserve upto 2GB of heap space.
11328
f7ff1b0f 113292011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11330
11331 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11332
639c109b
TZ
113332011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11334
11335 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11336 `gnutls_certificate_set_x509_key_file'.
11337
d2127135
JB
113382011-05-05 Juanma Barranquero <lekktu@gmail.com>
11339
11340 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11341 Update dependencies.
11342
e968f4f3
JB
113432011-05-04 Juanma Barranquero <lekktu@gmail.com>
11344
11345 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11346 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11347 Remove unused parameter `fildes'.
11348 * process.c (read_process_output, send_process): Don't pass it.
11349
84d358f0
JB
113502011-05-04 Juanma Barranquero <lekktu@gmail.com>
11351
11352 Fix previous change: the library cache is defined in w32.c.
11353 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11354 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11355
0898ca10
JB
113562011-05-04 Juanma Barranquero <lekktu@gmail.com>
11357
11358 Implement dynamic loading of GnuTLS on Windows.
11359
11360 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11361 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11362 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11363 Declare.
11364
11365 * gnutls.c (Qgnutls_dll): Define.
11366 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11367 (gnutls_*): Declare function pointers.
11368 (init_gnutls_functions): New function to initialize function pointers.
11369 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11370 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11371 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11372 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11373 (emacs_gnutls_write, emacs_gnutls_read)
11374 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11375 (Fgnutls_available_p): New function.
11376 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11377 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11378 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11379
11380 * image.c: Include w32.h.
11381 (Vimage_type_cache): Delete.
11382 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11383 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11384 (w32_delayed_load): Move to w32.c.
11385
11386 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11387
11388 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11389 (w32_delayed_load): Move from image.c. When loading a library, record
11390 its filename in the :loaded-from property of the library id.
11391 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11392 Initialize and staticpro them.
11393 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11394
11395 * process.c: Include lisp.h before w32.h, not after.
11396 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11397 instead of gnutls_record_check_pending.
11398
11399 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11400
ff4de4aa
TZ
114012011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11402
11403 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11404 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11405 as passed in.
11406
abe95abb
JD
114072011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11408
11409 * xterm.c (x_set_frame_alpha): Do not set property on anything
11410 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11411
e16e55d4
JB
114122011-05-02 Juanma Barranquero <lekktu@gmail.com>
11413
11414 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11415
bafcf6a5
JB
114162011-05-02 Juanma Barranquero <lekktu@gmail.com>
11417
11418 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11419 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11420 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11421 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11422 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11423 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11424 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11425 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11426 (Qgnutls_bootprop_callbacks_verify): Make static.
11427
e7a6747f
AS
114282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11429
19ed11ba
AS
11430 * callproc.c: Indentation fixup.
11431
e7a6747f 11432 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11433 (wait_for_termination, interruptible_wait_for_termination):
11434 Move after wait_for_termination_1.
e7a6747f 11435
1ef14cb4
LMI
114362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11437
11438 * sysdep.c (interruptible_wait_for_termination): New function
11439 which is like wait_for_termination, but allows keyboard
11440 interruptions.
11441
11442 * callproc.c (Fcall_process): Add (:file "file") as an option for
11443 the STDOUT buffer.
11444 (Fcall_process_region): Ditto.
11445
330d880c
EZ
114462011-04-30 Eli Zaretskii <eliz@gnu.org>
11447
8db90b73
EZ
11448 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11449 rather than `XVECTOR (FOO)->size'.
11450
330d880c
EZ
11451 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11452 inttypes.h, as a gnulib replacement is used if it not available in
11453 system headers.
11454
15cbd324
EZ
114552011-04-21 Eli Zaretskii <eliz@gnu.org>
11456
11457 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11458 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11459 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11460
11461 * coding.c (coding_alloc_by_realloc): Error out if destination
11462 will grow beyond MOST_POSITIVE_FIXNUM.
11463 (decode_coding_emacs_mule): Abort if there isn't enough place in
11464 charbuf for the composition carryover bytes. Reserve an extra
11465 space for up to 2 characters produced in a loop.
11466 (decode_coding_iso_2022): Abort if there isn't enough place in
11467 charbuf for the composition carryover bytes.
11468
114692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11470
ae940cca
EZ
11471 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11472 aborting when %lld or %lll format is passed.
11473 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11474 %llo or %llx format is passed. (Bug#8545)
11475
03ab8921
EZ
11476 * window.c (window_scroll_line_based): Use a marker instead of
11477 simple variables to record original value of point. (Bug#7952)
11478
afda1437
EZ
11479 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11480 produced by %s or %c overflows available buffer space. (Bug#8545)
11481
f76dee0c
PE
114822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11483
11484 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11485 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11486
fdc5744d
JB
114872011-04-28 Juanma Barranquero <lekktu@gmail.com>
11488
11489 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11490
638f053a
JB
114912011-04-28 Juanma Barranquero <lekktu@gmail.com>
11492
11493 * keyboard.c (Qdelayed_warnings_hook): Define.
11494 (command_loop_1): Run `delayed-warnings-hook'
11495 if Vdelayed_warnings_list is non-nil.
11496 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11497 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11498
d178f871
EZ
114992011-04-28 Eli Zaretskii <eliz@gnu.org>
11500
11501 * doprnt.c (doprnt): Don't return value smaller than the buffer
11502 size if the message was truncated. (Bug#8545).
11503
b124fd93
JB
115042011-04-28 Juanma Barranquero <lekktu@gmail.com>
11505
11506 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11507 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11508
e810457d
PE
115092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11510
11511 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11512
ea51cceb
JB
115132011-04-27 Juanma Barranquero <lekktu@gmail.com>
11514
11515 * makefile.w32-in: Update dependencies.
11516
94dcfacf
EZ
115172011-04-27 Eli Zaretskii <eliz@gnu.org>
11518
11519 Improve `doprnt' and its usage. (Bug#8545)
11520 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11521 `format_end'. Remove support for %l as a conversion specifier.
11522 Don't use xrealloc. Improve diagnostics when the %l size modifier
11523 is used. Update the commentary.
11524
11525 * eval.c (verror): Simplify calculation of size_t.
11526
11527 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11528 messages.
11529
f61f41d7
PE
115302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11531
11532 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11533 change.
11534
96fb4434
PE
115352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11536
11537 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11538 This makes this file independent of the recent pseudovector change.
11539
671875da 115402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11541
69e9b5a3
PE
11542 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11543
b5f869a7 11544 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11545 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11546 Remove unused local.
c8926152 11547 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11548
841a1577 11549 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11550 GCC 4.6.0 optimizes based on type-based alias analysis.
11551 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11552 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11553 != &v->size, and therefore "v->size = 1; b->size = 2; return
11554 v->size;" must therefore return 1. This assumption is incorrect
11555 for Emacs, since it type-puns struct Lisp_Vector * with many other
11556 types. To fix this problem, this patch adds a new type struct
f904488f 11557 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11558 and pseudovectors, and helps optimizing compilers not get fooled
11559 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11560 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11561 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11562 the size member.
eab3844f
PE
11563 (XSETPVECTYPE): Rewrite in terms of new macro.
11564 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11565 This is a bit clearer, and further avoids the possibility of
11566 undesirable aliasing.
11567 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11568 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11569 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11570 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11571 (ASIZE): Now uses header.size rather than size.
11572 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11573 to avoid the hassle of writing XVECTOR (foo)->header.size.
11574 (struct vectorlike_header): New type.
eab3844f
PE
11575 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11576 object, to help avoid aliasing.
11577 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11578 (SUBRP): Likewise, since Lisp_Subr is a special case.
11579 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11580 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11581 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11582 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11583 changed to be "header.size" and "header.next".
11584 * buffer.h (struct buffer): Likewise.
11585 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11586 * frame.h (struct frame): Likewise.
11587 * process.h (struct Lisp_Process): Likewise.
11588 * termhooks.h (struct terminal): Likewise.
11589 * window.c (struct save_window_data, struct saved_window): Likewise.
11590 * window.h (struct window): Likewise.
11591 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11592 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11593 * buffer.c (init_buffer_once): Likewise.
11594 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11595 special case.
11596 * process.c (Fformat_network_address): Use local var for size,
11597 for brevity.
11598
0df1eac5
PE
11599 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11600
847ab9d1 11601 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11602 * data.c (atof): Remove decl; no longer used or needed.
11603 (digit_to_number): Move to lread.c.
11604 (Fstring_to_number): Use new string_to_number function, to be
11605 consistent with how the Lisp reader treats infinities and NaNs.
11606 Do not assume that floating-point numbers represent EMACS_INT
11607 without losing information; this is not true on most 64-bit hosts.
11608 Avoid double-rounding errors, by insisting on integers when
11609 parsing non-base-10 numbers, as the documentation specifies.
11610 * lisp.h (string_to_number): New decl, replacing ...
11611 (isfloat_string): Remove.
bc0a5c13 11612 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11613 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11614 appears to have been a coding error. Similarly, do not accept
11615 strings like +-1e0 as floating point numbers. Do not report
11616 overflow for integer overflows unless the base is not 10 which
11617 means we have no simple and reliable way to continue.
11618 Break out the floating-point parsing into a new
11619 function string_to_number, so that Fstring_to_number parses
11620 floating point numbers consistently with the Lisp reader.
04f2d78b 11621 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11622 (E_CHAR, EXP_INT): Remove, replacing with ...
11623 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11624 (string_to_number): New function, replacing isfloat_string.
11625 This function checks for valid syntax and produces the resulting
11626 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11627 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11628 so that overflow for non-base-10 numbers is reported only when
11629 there's no portable and simple way to convert to floating point.
452f4150 11630
67769ffc
PE
11631 * textprop.c (set_text_properties_1): Rewrite for clarity,
11632 and to avoid GCC warning about integer overflow.
11633
c20db43f
PE
11634 * intervals.h (struct interval): Use EMACS_INT for members
11635 where EMACS_UINT might cause problems. See
11636 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11637 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11638 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11639 All uses changed.
37aa2f85
PE
11640 (offset_intervals): Tell GCC not to worry about length overflow
11641 when negating a negative length.
c20db43f 11642
2538aa2f
PE
11643 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11644 (overrun_check_free): Likewise.
11645
f2d3008d
PE
11646 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11647 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11648 word size.
11649
ec8df744
PE
11650 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11651 (gnutls_make_error): Rename local to avoid shadowing.
11652 (gnutls_emacs_global_deinit): ifdef out; not used.
11653 (Fgnutls_boot): Use const for pointer to readonly storage.
11654 Comment out unused local. Fix pointer signedness problems.
11655
640ee02d
PE
11656 * lread.c (openp): Don't stuff size_t into an 'int'.
11657 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11658 about possible signed overflow.
11659
6048fb2a
PE
11660 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11661 (GDK_KEY_g): Don't define if already defined.
11662 (xg_prepare_tooltip): Avoid pointer signedness problem.
11663 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11664
fa3c87e1
PE
11665 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11666 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11667
2172544b
PE
11668 * xfns.c (Fx_window_property): Simplify a bit,
11669 to make a bit faster and to avoid GCC 4.6.0 warning.
11670 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11671
9b821a21
PE
11672 * fns.c (internal_equal): Don't assume size_t fits in int.
11673
3c616cfa
PE
11674 * alloc.c (compact_small_strings): Tighten assertion a little.
11675
c2982e87
PE
11676 Replace pEd with more-general pI, and fix some printf arg casts.
11677 * lisp.h (pI): New macro, generalizing old pEd macro to other
11678 conversion specifiers. For example, use "...%"pI"d..." rather
11679 than "...%"pEd"...".
11680 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11681 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11682 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11683 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11684 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11685 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11686 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11687 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11688 64-bit hosts.
11689 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11690 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11691 * print.c (safe_debug_print, print_object): Likewise.
11692 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11693 to int.
6f04d126
PE
11694 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11695 avoiding the 0 flag, which is not portable.
c2982e87
PE
11696 * process.c (Fmake_network_process): Use pI to avoid cast.
11697 * region-cache.c (pp_cache): Likewise.
11698 * xdisp.c (decode_mode_spec): Likewise.
11699 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11700 behavior on 64-bit hosts with printf arg.
6f04d126 11701 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11702 (x_stop_queuing_selection_requests): Likewise.
11703 (x_get_window_property): Don't truncate byte count to an 'int'
11704 when tracing.
0b432f21 11705
5e073ec7
PE
11706 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11707 here, since it parses constructs like leading '-' and spaces,
11708 which are not wanted; and it overflows with large numbers.
11709 Instead, simply match F[0-9]+, which is what is wanted anyway.
11710
36372bf9
PE
11711 * alloc.c: Remove unportable assumptions about struct layout.
11712 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11713 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11714 (allocate_vectorlike, make_pure_vector): Use the new macros,
11715 plus offsetof, to remove unportable assumptions about struct layout.
11716 These assumptions hold on all porting targets that I know of, but
11717 they are not guaranteed, they're easy to remove, and removing them
11718 makes further changes easier.
11719
0b432f21
PE
11720 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11721 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11722 (string_overrun_cookie): Now const. Use initializers that
11723 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11724 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11725 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11726 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11727 multiple of sizeof (EMACS_INT); it need not be, if
11728 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11729 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11730
895009e1
JB
117312011-04-26 Juanma Barranquero <lekktu@gmail.com>
11732
11733 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11734
6a7a1b0b
TZ
117352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11736
11737 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11738 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11739 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11740
841a1577 117412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11742
11743 * lisp.h (Qdebug): List symbol.
895009e1 11744 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11745 * keyboard.c (debug-on-event): New variable.
11746 (handle_user_signal): Break into debugger when debug-on-event
11747 matches the current signal symbol.
11748
f2d3ba6f
DN
117492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11750
11751 * alloc.c (check_sblock, check_string_bytes)
11752 (check_string_free_list): Convert to standard C.
11753
42ce4c63
TZ
117542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11755
11756 * w32.c (emacs_gnutls_push): Fix typo.
11757
825cd63c
EZ
117582011-04-25 Eli Zaretskii <eliz@gnu.org>
11759
fb11d64d
EZ
11760 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11761 "cast to pointer from integer of different size".
11762
825cd63c
EZ
11763 Improve doprnt and its use in verror. (Bug#8545)
11764 * doprnt.c (doprnt): Document the set of format control sequences
11765 supported by the function. Use SAFE_ALLOCA instead of always
11766 using `alloca'.
11767
11768 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11769 is one byte too soon. Don't use xrealloc; instead xfree and
11770 xmalloc anew.
11771
e061a11b
TZ
117722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11773
11774 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11775 callbacks stage.
11776
11777 * gnutls.c: Renamed global_initialized to
11778 gnutls_global_initialized. Added internals for the
11779 :verify-hostname-error, :verify-error, and :verify-flags
11780 parameters of `gnutls-boot' and documented those parameters in the
11781 docstring. Start callback support.
9173deec
JB
11782 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11783 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11784 on error. Return error code.
e061a11b
TZ
11785 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11786 (emacs_gnutls_read): Likewise.
11787 (Fgnutls_boot): Return handshake error code.
11788 (emacs_gnutls_handle_error): New function.
11789 (wsaerror_to_errno): Likewise.
11790
11791 * w32.h (emacs_gnutls_pull): Add prototype.
11792 (emacs_gnutls_push): Likewise.
11793
11794 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11795 (emacs_gnutls_push): Likewise.
11796
117972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11798
11799 * process.c (wait_reading_process_output): Check if GnuTLS
11800 buffered some data internally if no FDs are set for TLS
11801 connections.
11802
11803 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11804 (LIBS): Link to USER_LIBS.
11805 ($(BLD)/gnutls.$(0)): New target.
11806
fa6996bc
EZ
118072011-04-24 Eli Zaretskii <eliz@gnu.org>
11808
eb35682e
EZ
11809 * xdisp.c (handle_single_display_spec): Rename the
11810 display_replaced_before_p argument into display_replaced_p, to
11811 make it consistent with the commentary. Fix typos in the
11812 commentary.
11813
e2ad650c
EZ
11814 * textprop.c (syms_of_textprop): Remove dead code.
11815 (copy_text_properties): Delete obsolete commentary about an
11816 interface that was deleted long ago. Fix typos in the description
11817 of arguments.
11818
1b2de274
EZ
11819 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11820 to changes in oldXMenu/XMenu.h from 2011-04-16.
11821 <menu_help_message, prev_menu_help_message>: Constify.
11822 (IT_menu_make_room): menu->help_text is now `const char **';
11823 adjust.
11824
11825 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11826 to changes in oldXMenu/XMenu.h from 2011-04-16.
11827 (struct XMenu): Declare `help_text' `const char **'.
11828
11829 * xfaces.c <Qunspecified>: Make extern again.
11830
11831 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11832 required by POSIX.
1b2de274 11833
762b15be
EZ
11834 * doc.c (get_doc_string): Improve the format passed to `error'.
11835
11836 * doprnt.c (doprnt): Improve commentary.
11837
11838 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11839
11840 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11841 them with etags.
11842
f1052e5d
EZ
11843 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11844 changes in globals.h immediately force recompilation.
762b15be
EZ
11845 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11846 $(CURDIR)/s/ms-w32.h.
11847 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11848
fa6996bc
EZ
11849 * character.c (Fchar_direction): Function deleted.
11850 (syms_of_character): Don't defsubr it.
11851 <char-direction-table>: Deleted.
11852
e6c3da20
EZ
118532011-04-23 Eli Zaretskii <eliz@gnu.org>
11854
11855 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11856 * doprnt.c: Include limits.h.
11857 (SIZE_MAX): New macro.
04f2d78b
CB
11858 (doprnt): Return a size_t value. 2nd arg is now size_t.
11859 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11860 Improve overflow protection. Support `l' modifier for integer
11861 conversions. Support %l conversion. Don't assume an EMACS_INT
11862 argument for integer conversions and for %c.
11863
11864 * lisp.h (doprnt): Restore prototype.
11865
11866 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11867 $(SRC)/character.h.
11868
11869 * Makefile.in (base_obj): Add back doprnt.o.
11870
11871 * deps.mk (doprnt.o): Add back prerequisites.
11872 (callint.o): Depend on character.h.
11873
11874 * eval.c (internal_lisp_condition_case): Include the handler
11875 representation in the error message.
11876 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11877 when breaking from the loop.
11878
11879 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11880
11881 * callint.c (Fcall_interactively): When displaying error message
11882 about invalid control letter, pass the character's codepoint, not
11883 a pointer to its multibyte form. Improve display of the character
11884 in octal and display also its hex code.
11885
11886 * character.c (char_string): Use %x to display the (unsigned)
11887 codepoint of an invalid character, to avoid displaying a bogus
11888 negative value.
11889
11890 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11891 `error', not SYMBOL_NAME itself.
11892
11893 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11894 character arguments to `error'.
11895
11896 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11897 to `error' in error message about FINAL_CHAR argument. Make sure
11898 FINAL_CHAR is a character, and use %c when it is passed as
11899 argument to `error'.
11900
4ffd0d6b 119012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11902
11903 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11904
11905 * w32.c: Include <time.h>.
11906 (sys_localtime): New function.
11907
4ffd0d6b 119082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11909
11910 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11911
4ffd0d6b 11912 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11913
4ffd0d6b 119142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11915
4ffd0d6b
GM
11916 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11917 zombies (Bug#8467).
aac0c6e3 11918
04c56954
EZ
119192011-04-19 Eli Zaretskii <eliz@gnu.org>
11920
11921 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11922 gl_state.e_property when gl_state.object is Qt.
11923
11924 * insdel.c (make_gap_larger): Remove limitation of buffer size
11925 to <= INT_MAX.
11926
16a43933
CY
119272011-04-18 Chong Yidong <cyd@stupidchicken.com>
11928
11929 * xdisp.c (lookup_glyphless_char_display)
11930 (produce_glyphless_glyph): Handle cons cell entry in
11931 glyphless-char-display.
11932 (Vglyphless_char_display): Document it.
11933
11934 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11935 glyphless-char-display.
11936
4581706e
CY
119372011-04-17 Chong Yidong <cyd@stupidchicken.com>
11938
11939 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11940
11941 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11942
11943 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11944 definition for no-X builds.
11945
4887c6e2 119462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11947
fd35b6f9
PE
11948 Static checks with GCC 4.6.0 and non-default toolkits.
11949
5c1ccb01
PE
11950 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11951
006c5daa
PE
11952 * process.c (keyboard_bit_set): Define only if SIGIO.
11953 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11954 (send_process): Repair possible setjmp clobbering.
11955
efc736d3
PE
11956 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11957
4e2fe2e6
PE
11958 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11959
f97334a2
PE
11960 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11961
4e75f29d
PE
11962 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11963 Define only if needed.
11964
90efadd1
PE
11965 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11966 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11967 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11968
3c647824
PE
11969 * dispextern.h (struct redisplay_interface): Rename param
11970 to avoid shadowing.
e264f262 11971 * termhooks.h (struct terminal): Likewise.
761383f4 11972 * xterm.c (xembed_send_message): Likewise.
3c647824 11973
b58c5c4a
PE
11974 * insdel.c (make_gap_smaller): Define only if
11975 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11976
cad59032
PE
11977 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11978 it.
11979
c339dc2e
PE
11980 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11981 so that we aren't warned about unused symbols.
11982
91a3e27b
PE
11983 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11984
399c71d3 11985 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11986
8ffc96f5
PE
11987 * xfns.c (x_real_positions): Mark locals as initialized.
11988
eef9bc79
PE
11989 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11990
098db9dd
PE
11991 * xterm.c: Fix problems found by static analysis with other toolkits.
11992 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11993 (x_dispatch_event): Declare static if USE_GTK, and
11994 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11995 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11996 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11997 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11998 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11999
eb18f6cc
PE
12000 * xmenu.c (menu_help_callback): Pointer type fixes.
12001 Use const pointers when pointing at readonly data. Avoid pointer
12002 signedness clashes.
12003 (FALSE): Remove unused macro.
12004 (update_frame_menubar): Remove unused decl.
12005
1fe72bf8
PE
12006 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12007
60d9e1db
PE
12008 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12009 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12010 (single_menu_item): Rename local to avoid shadowing.
12011
39261c26
PE
12012 * keyboard.c (make_lispy_event): Remove unused local var.
12013
018c5e19
PE
12014 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12015 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12016
63d2b86e
PE
12017 * bitmaps: Change bitmaps from unsigned char back to the X11
12018 compatible char. Avoid the old compiler warnings about
12019 out-of-range initializers by using, for example, '\xab' rather
12020 than 0xab.
12021
aefd87e1
PE
12022 * xgselect.c (xgselect_initialize): Check vs interface
12023 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12024
bf501fb9
PE
12025 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12026
e9829fdf
PE
12027 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12028 to read-only memory.
12029
1086c095
PE
12030 * fns.c (vector): Remove; this old hack is no longer needed.
12031
2baccd04 12032 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12033 Remove unused var.
dde42981 12034 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12035
72391843 12036 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12037
436c16df 12038 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12039 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12040 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12041
92bb796d 12042 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12043 (x_term_init): Remove local to avoid shadowing.
92bb796d 12044
764430a3 12045 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12046
12047 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12048 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12049
d1dfb56c
EZ
120502011-04-16 Eli Zaretskii <eliz@gnu.org>
12051
c4354cb4
EZ
12052 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12053
d1dfb56c
EZ
12054 Fix regex.c, syntax.c and friends for buffers > 2GB.
12055 * syntax.h (struct gl_state_s): Declare character position members
12056 EMACS_INT.
12057
12058 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12059
04f2d78b
CB
12060 * textprop.c (verify_interval_modification, interval_of):
12061 Declare arguments EMACS_INT.
d1dfb56c
EZ
12062
12063 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12064 EMACS_INT.
12065
12066 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12067
12068 * indent.c (Fvertical_motion): Local variable it_start is now
12069 EMACS_INT.
12070
12071 * regex.c (re_match, re_match_2, re_match_2_internal)
12072 (bcmp_translate, regcomp, regexec, print_double_string)
12073 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12074 (re_compile_pattern, re_exec): Declare arguments and local
12075 variables `size_t' and `ssize_t' and return values `regoff_t', as
12076 appropriate.
12077 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12078 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12079 <compile_stack_type>: `size' and `avail' are now `size_t'.
12080
12081 * regex.h <regoff_t>: Use ssize_t, not int.
12082 (re_search, re_search_2, re_match, re_match_2): Arguments that
12083 specify buffer/string position and length are now ssize_t and
12084 size_t. Return type is regoff_t.
12085
613052cd
BK
120862011-04-16 Ben Key <bkey76@gmail.com>
12087
12088 * nsfont.m: Fixed bugs in ns_get_family and
12089 ns_descriptor_to_entity that were caused by using free to
12090 deallocate memory blocks that were allocated by xmalloc (via
12091 xstrdup). This caused Emacs to crash when compiled with
12092 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12093 --enable-checking=xmallocoverrun). xfree is now used to
12094 deallocate these memory blocks.
12095
4170f62f 120962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12097
71b41406
PE
12098 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12099
9587a89d
PE
12100 emacs_write: Accept and return EMACS_INT for sizes.
12101 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12102 et seq.
12103 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12104 Accept and return EMACS_INT.
12105 (emacs_gnutls_write): Return the number of bytes written on
12106 partial writes.
12107 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12108 (emacs_read, emacs_write): Remove check for negative size, as the
12109 Emacs source code has been audited now.
9587a89d
PE
12110 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12111 (emacs_read, emacs_write): Use it.
273a5f82
PE
12112 * process.c (send_process): Adjust to the new signatures of
12113 emacs_write and emacs_gnutls_write. Do not attempt to store
12114 a byte offset into an 'int'; it might overflow.
9587a89d 12115 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12116
3e047f51
PE
12117 * sound.c: Don't assume sizes fit in 'int'.
12118 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12119 Return EMACS_INT, not int.
3e047f51 12120 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12121 Accept EMACS_INT, not int.
12122 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12123 record read return values.
12124
cc39a9db
BK
121252011-04-15 Ben Key <bkey76@gmail.com>
12126
c9d0ec6d
JB
12127 * keyboard.c (Qundefined): Don't declare static since it is used
12128 in nsfns.m.
12129 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12130 static since they are used in nsfont.m.
cc39a9db 12131
6c60eb9f
SM
121322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12133
12134 * process.c (Qprocessp): Don't declare static.
12135 * lisp.h (Qprocessp): Declare again.
12136
7990b61a
JB
121372011-04-15 Juanma Barranquero <lekktu@gmail.com>
12138
12139 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12140
5d4cb038
PE
121412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12142
8bd7b830 12143 Improve C-level modularity by making more things 'static'.
cd64ea1d 12144
e3b27b31
PE
12145 Don't publish debugger-only interfaces to other modules.
12146 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12147 (verify_bytepos, count_markers): Move decls to the only modules
12148 that need them.
12149 * region-cache.h (pp_cache): Likewise.
12150 * window.h (check_all_windows): Likewise.
12151 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12152
5d4cb038
PE
12153 * sysdep.c (croak): Now static, if
12154 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12155 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12156
12157 * alloc.c (refill_memory_reserve): Now static if
12158 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12159 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12160
e87b6180
PE
12161 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12162 Define only if USE_LUCID.
12163
ac64929e
PE
12164 * xrdb.c (x_customization_string, x_rm_string): Now static.
12165
6f37259d
PE
12166 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12167 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12168
1683e3ab
PE
12169 * xdisp.c (draw_row_with_mouse_face): Now static.
12170 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12171
de9c2632
PE
12172 * window.h (check_all_windows): Mark externally visible.
12173
2b96acb7
PE
12174 * window.c (window_deletion_count): Now static.
12175
12176 * undo.c: Make symbols static if they're not exported.
12177 (last_undo_buffer, last_boundary_position, pending_boundary):
12178 Now static.
12179
50436f33
PE
12180 * textprop.c (interval_insert_behind_hooks): Now static.
12181 (interval_insert_in_front_hooks): Likewise.
12182
64520e5c
PE
12183 * term.c: Make symbols static if they're not exported.
12184 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12185 (max_frame_lines, tty_set_terminal_modes):
12186 (tty_reset_terminal_modes, tty_turn_off_highlight):
12187 (get_tty_terminal): Now static.
12188 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12189 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12190 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12191 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12192 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12193
1fa53021
PE
12194 * sysdep.c: Make symbols static if they're not exported.
12195 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12196 Now static.
12197 (sigprocmask_set, full_mask): Remove; unused.
12198 (wait_debugging): Mark as visible.
12199 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12200 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12201
d4b43b22
PE
12202 * syntax.c (syntax_temp): Define only if !__GNUC__.
12203
b7c513d0
PE
12204 * sound.c (current_sound_device, current_sound): Now static.
12205
989b29ad
PE
12206 * search.c (searchbufs, searchbuf_head): Now static.
12207
13a55a78
PE
12208 * scroll.c (scroll_cost): Remove; unused.
12209 * dispextern.h (scroll_cost): Remove decl.
12210
de68a1fc
PE
12211 * region-cache.h (pp_cache): Mark as externally visible.
12212
40ccffa6
PE
12213 * process.c: Make symbols static if they're not exported.
12214 (process_tick, update_tick, create_process, chan_process):
12215 (Vprocess_alist, proc_buffered_char, datagram_access):
12216 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12217 (deactivate_process): Mark defn as static, as well as decl.
12218 * lisp.h (create_process): Remove decl.
12219 * process.h (chan_process, Vprocess_alist): Remove decls.
12220
ad64fc97
PE
12221 * print.c: Make symbols static if they're not exported.
12222 (print_depth, new_backquote_output, being_printed, print_buffer):
12223 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12224 (print_interval, print_number_index, initial_stderr_stream):
12225 Now static.
12226 * lisp.h (Fprinc): Remove decl.
12227 (debug_output_compilation_hack): Mark as externally visible.
12228
adddb265
PE
12229 * sysdep.c (croak): Move decl from here to syssignal.h.
12230 * syssignal.h (croak): Put it here, so the API can be checked when
12231 'croak' is called from dissociate_if_controlling_tty.
12232
1717ede2
PE
12233 * minibuf.c: Make symbols static if they're not exported.
12234 (minibuf_save_list, choose_minibuf_frame): Now static.
12235 * lisp.h (choose_minibuf_frame): Remove decl.
12236
fa5fb2bc
PE
12237 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12238
1e3890d1
PE
12239 * lread.c: Make symbols static if they're not exported.
12240 (read_objects, initial_obarray, oblookup_last_bucket_number):
12241 Now static.
12242 (make_symbol): Remove; unused.
12243 * lisp.h (initial_obarray, make_symbol): Remove decls.
12244
8a1414fa
PE
12245 * keyboard.c: Make symbols static if they're not exported.
12246 (single_kboard, recent_keys_index, total_keys, recent_keys):
12247 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12248 (this_single_command_key_start, echoing, last_auto_save):
12249 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12250 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12251 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12252 (Vlispy_mouse_stem, double_click_count):
12253 Now static.
12254 (force_auto_save_soon): Define only if SIGDANGER.
12255 (ignore_mouse_drag_p): Now static if
12256 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12257 (print_help): Remove; unused.
12258 (stop_character, last_timer_event): Mark as externally visible.
12259 * keyboard.h (ignore_mouse_drag_p): Declare only if
12260 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12261 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12262 * lisp.h (echoing): Remove decl.
12263 (force_auto_save_soon): Declare only if SIGDANGER.
12264 * xdisp.c (redisplay_window): Simplify code, to make it more
12265 obvious that ignore_mouse_drag_p is not accessed if !defined
12266 USE_GTK && !defined HAVE_NS.
12267
93ea6e8f
PE
12268 * intervals.c: Make symbols static if they're not exported.
12269 (merge_properties_sticky, merge_interval_right, delete_interval):
12270 Now static.
12271 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12272
77382fcc
PE
12273 * insdel.c: Make symbols static if they're not exported.
12274 However, leave prepare_to_modify_buffer alone. It's never
12275 called from outside this function, but that appears to be a bug.
12276 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12277 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12278 (adjust_after_replace_noundo): Remove; unused.
12279 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12280 (signal_before_change): Remove decls.
77382fcc 12281
9306c32e
PE
12282 * indent.c (val_compute_motion, val_vmotion): Now static.
12283
cd44d2eb
PE
12284 * image.c: Make symbols static if they're not exported.
12285 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12286 if USE_GTK.
12287 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12288 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12289
ad9a7a06
PE
12290 * fringe.c (standard_bitmaps): Now static.
12291 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12292
81626931
PE
12293 * frame.c: Make symbols static if they're not exported.
12294 (x_report_frame_params, make_terminal_frame): Now static.
12295 (get_frame_param): Now static, unless HAVE_NS.
12296 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12297 (x_get_resource_string): Remove; not used.
12298 * frame.h (make_terminal_frame, x_report_frame_params):
12299 (x_get_resource_string); Remove decls.
12300 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12301 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12302
239f9db9
PE
12303 * font.c, fontset.c: Make symbols static if they're not exported.
12304 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12305 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12306 * font.c (font_close_object): Now static.
12307 * font.h (font_close_object): Remove.
12308 * fontset.c (FONTSET_OBJLIST): Remove.
12309 (free_realized_fontset) #if-0 the body, which does nothing.
12310 (face_suitable_for_char_p): #if-0, as it's never called.
12311 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12312 * xfaces.c (face_at_string_position):
12313 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12314 since 0 is always ASCII.
12315
dfcf3579
PE
12316 * fns.c (weak_hash_tables): Now static.
12317
5045092b
PE
12318 * fileio.c: Make symbols static if they're not exported.
12319 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12320 (Vwrite_region_annotation_buffers): Now static.
12321
57a96f5c
PE
12322 * eval.c: Make symbols static if they're not exported.
12323 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12324 * lisp.h (backtrace_list): Remove decl.
12325
35f08c38
PE
12326 * emacs.c: Make symbols static if they're not exported.
12327 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12328 (fatal_error_code, fatal_error_signal_hook, standard_args):
12329 Now static.
12330 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12331 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12332 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12333 * lisp.h (fatal_error_signal_hook): Remove decl.
12334 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12335
f44bd759
PE
12336 * editfns.c: Move a (normally-unused) function to its only use.
12337 * editfns.c, lisp.h (get_operating_system_release): Remove.
12338 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12339 worth the hassle of breaking this out.
12340
b532497d
PE
12341 * xterm.c: Make symbols static if they're not exported.
12342 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12343 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12344 (x_destroy_window, x_delete_display):
12345 Now static.
12346 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12347 (x_mouse_leave): Remove; unused.
12348 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12349 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12350 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12351 Remove decls.
12352 (x_mouse_leave): Declare only if WINDOWSNT.
12353 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12354 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12355 USE_X_TOOLKIT.
12356
1675728f
PE
12357 * ftxfont.c: Make symbols static if they're not exported.
12358 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12359 HAVE_FREETYPE.
12360 * font.h (ftxfont_driver): Likewise.
12361
e4cebfca
PE
12362 * xfns.c: Make symbols static if they're not exported.
12363 (x_last_font_name, x_display_info_for_name):
12364 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12365 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12366 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12367 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12368 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12369 (last_show_tip_args): Now static.
12370 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12371 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12372 (x_screen_planes): Remove; unused.
12373 * dispextern.h (x_screen_planes): Remove decl.
12374
5bf46f05
PE
12375 * dispnew.c: Make symbols static if they're not exported.
12376 * dispextern.h (redraw_garbaged_frames, scrolling):
12377 (increment_row_positions): Remove.
12378 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12379 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12380 Now static.
12381 (redraw_garbaged_frames): Remove; unused.
12382
435f4c28
PE
12383 * xfaces.c: Make symbols static if they're not exported.
12384 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12385 Remove decls.
12386 * xterm.h (defined_color): Remove decls.
12387 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12388 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12389 (menu_face_changed_default, defined_color, free_realized_face):
12390 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12391 (ascii_face_of_lisp_face): Remove; unused.
12392
8524aef3
PE
12393 * xdisp.c: Make symbols static if they're not exported.
12394 * dispextern.h (scratch_glyph_row, window_box_edges):
12395 (glyph_to_pixel_coords, set_cursor_from_row):
12396 (get_next_display_element, set_iterator_to_next):
12397 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12398 (show_mouse_face): Remove decls
12399 * frame.h (message_buf_print): Likewise.
12400 * lisp.h (pop_message, set_message, check_point_in_composition):
12401 Likewise.
12402 * xterm.h (set_vertical_scroll_bar): Likewise.
12403 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12404 (message_buf_print, scratch_glyph_row, displayed_buffer):
12405 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12406 (get_next_display_element, show_mouse_face, window_box_edges):
12407 (frame_to_window_pixel_xy, check_point_in_composition):
12408 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12409 (glyph_to_pixel_coords): Remove; unused.
12410
16390cd2
PE
12411 * dired.c (file_name_completion): Now static.
12412
12413 * dbusbind.c (xd_in_read_queued_messages): Now static.
12414
a25f4dfa
PE
12415 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12416 * data.c (circular_list_error): Remove.
12417
14a9c8df
PE
12418 * commands.h (last_point_position, last_point_position_buffer):
12419 (last_point_position_window): Remove decls.
12420 * keyboard.c: Make these variables static.
12421
04f2d78b
CB
12422 * coding.h (coding, code_convert_region, encode_coding_gap):
12423 Remove decls.
74ab6df5
PE
12424 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12425 (iso_code_class, detect_coding, code_convert_region): Now static.
12426 (encode_coding_gap): Remove; unused.
12427
38dfbee1
PE
12428 * chartab.c (chartab_chars, chartab_bits): Now static.
12429
a2cb4e63
PE
12430 * charset.h (charset_iso_8859_1): Remove decl.
12431 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12432 Now static.
12433
127198fd
PE
12434 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12435 * ccl.c (Vccl_program_table): Now static.
12436 (check_ccl_update): Remove; unused.
12437
d85b608f
PE
12438 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12439 * category.h: ... from here.
12440 * category.c (check_category_table, set_category_set): Now static.
12441
31cd66f3
PE
12442 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12443 * lisp.h: Remove these decls.
12444
c358e587
PE
12445 * buffer.c (buffer_count): Remove unused var.
12446
e78aecca
PE
12447 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12448 so that it's not optimized away.
12449 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12450 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12451 exported only to the debugger.
12452
e192d7d3 12453 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12454 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12455
92470028
PE
12456 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12457 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12458 was inaccessible from Lisp.
12459 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12460 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12461
244ed907
PE
12462 alloc.c: Import and export fewer symbols, and remove unused items.
12463 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12464 is defined.
12465 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12466 it's not optimized away by whole-program optimization.
12467 (message_enable_multibyte, free_misc): Remove.
12468 (catchlist, handlerlist, mark_backtrace):
12469 Declare only if BYTE_MARK_STACK.
12470 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12471 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12472 (message_enable_multibyte): Remove decl.
12473 (free_misc, interval_free_list, float_block, float_block_index):
12474 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12475 (cons_free_list, last_marked_index):
12476 Now static.
12477 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12478 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12479 (mark_backtrace): Define only if BYTE_MARK_STACK.
12480 * xdisp.c (message_enable_multibyte): Now static.
12481
61c2b50e 12482 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12483 This makes it easier for human readers (and static analyzers)
12484 to see whether these variables are used from other modules.
12485 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12486 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12487 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12488 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12489 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12490 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12491 * xmenu.c, xselect.c:
12492 Declare Q* vars static if they are not used in other modules.
12493 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12494 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12495 Remove decls of unexported vars.
12496 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12497
95c82688
PE
12498 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12499
16a97296
PE
12500 Make Emacs functions such as Fatom 'static' by default.
12501 This makes it easier for human readers (and static analyzers)
12502 to see whether these functions can be called from other modules.
12503 DEFUN now defines a static function. To make the function external
12504 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12505 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12506 (Finit_image_library):
16a97296
PE
12507 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12508 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12509 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12510 Remove decls, since these functions are now static.
12511 (Funintern, Fget_internal_run_time): New decls, since these functions
12512 were already external.
95c82688 12513
16a97296
PE
12514 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12515 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12516 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12517 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12518 * keyboard.c, keymap.c, lread.c:
12519 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12520 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12521 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12522 Mark functions with DEFUE instead of DEFUN,
12523 if they are used in other modules.
12524 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12525 decls for now-static functions.
12526 * buffer.h (Fdelete_overlay): Remove decl.
12527 * callproc.c (Fgetenv_internal): Mark as internal.
12528 * composite.c (Fremove_list_of_text_properties): Remove decl.
12529 (Fcomposition_get_gstring): New forward static decl.
12530 * composite.h (Fcomposite_get_gstring): Remove decl.
12531 * dired.c (Ffile_attributes): New forward static decl.
12532 * doc.c (Fdocumntation_property): New forward static decl.
12533 * eval.c (Ffetch_bytecode): New forward static decl.
12534 (Funintern): Remove extern decl; now in .h file where it belongs.
12535 * fileio.c (Fmake_symbolic_link): New forward static decl.
12536 * image.c (Finit_image_library): New forward static decl.
12537 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12538 * intervals.h (Fprevious_property_change):
12539 (Fremove_list_of_text_properties): Remove decls.
12540 * keyboard.c (Fthis_command_keys): Remove decl.
12541 (Fcommand_execute): New forward static decl.
12542 * keymap.c (Flookup_key): New forward static decl.
12543 (Fcopy_keymap): Now static.
12544 * keymap.h (Flookup_key): Remove decl.
12545 * process.c (Fget_process): New forward static decl.
12546 (Fprocess_datagram_address): Mark as internal.
12547 * syntax.c (Fsyntax_table_p): New forward static decl.
12548 (skip_chars): Remove duplicate decl.
12549 * textprop.c (Fprevious_property_change): New forward static decl.
12550 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12551 Now internal.
12552 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12553 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12554
785bbd42
PE
12555 * editfns.c (Fformat): Remove unreachable code.
12556
8b913b57
AS
125572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12558
12559 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12560 change. (Bug#8496)
12561
a6744a35
EZ
125622011-04-13 Eli Zaretskii <eliz@gnu.org>
12563
12564 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12565 when at ZV. (Bug#8487)
12566
e7974947
AS
125672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12568
baad03f0
AS
12569 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12570 (Bug#8437)
12571 * keyboard.c (parse_tool_bar_item): Likewise.
12572 * sound.c (sound_cleanup, alsa_close): Likewise.
12573 * termcap.c (tgetent): Likewise.
12574 * xfns.c (x_default_font_parameter): Likewise.
12575 * xsettings.c (read_and_apply_settings): Likewise.
12576
e7974947
AS
12577 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12578 (overrun_check_free): Protoize.
12579
28272684
PE
125802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12581
12582 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12583 since callers should never pass a negative size.
12584 Change the signature to match that of plain 'read' and 'write'; see
12585 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12586 * lisp.h: Update prototypes of emacs_write and emacs_read.
12587
11997c76
EZ
125882011-04-11 Eli Zaretskii <eliz@gnu.org>
12589
12590 * xdisp.c (redisplay_window): Don't try to determine the character
12591 position of the scroll margin if the window start point w->startp
e896f03c 12592 is outside the buffer's accessible region. (Bug#8468)
11997c76 12593
8a2cbd72
EZ
125942011-04-10 Eli Zaretskii <eliz@gnu.org>
12595
12596 Fix write-region and its subroutines for buffers > 2GB.
12597 * fileio.c (a_write, e_write): Modify declaration of arguments and
12598 local variables to support buffers larger than 2GB.
12599 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12600
12601 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12602 argument, local variables, and return value.
12603
12604 * lisp.h: Update prototypes of emacs_write and emacs_read.
12605
12606 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12607
4073e537 126082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12609
1ebfdcb6
PE
12610 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12611
b2ded58d
PE
12612 Fix more problems found by GCC 4.6.0's static checks.
12613
7d66342c
PE
12614 * xdisp.c (vmessage): Use a better test for character truncation.
12615
bbf47d44
PE
12616 * charset.c (load_charset_map): <, not <=, for optimization,
12617 and to avoid potential problems with integer overflow.
9248994d 12618 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12619 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12620 * editfns.c (Fformat): Likewise.
1e69125e 12621 * syntax.c (skip_chars): Likewise.
3befa583 12622
e3019616
PE
12623 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12624 This also lets GCC 4.6.0 generate slightly better loop code.
12625
becfa255
PE
12626 * callint.c (Fcall_interactively): <, not <=, for optimization.
12627 (Fcall_interactively): Count the number of arguments produced,
12628 not the number of arguments given. This is simpler and lets GCC
12629 4.6.0 generate slightly better code.
12630
dae0cd48
PE
12631 * ftfont.c: Distingish more carefully between FcChar8 and char.
12632 The previous code passed unsigned char * to a functions like
12633 strlen and xstrcasecmp that expect char *, which does not
12634 conform to the C standard.
12635 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12636 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12637 char * when the C standard requires it.
12638
76032d70
PE
12639 * keyboard.c (read_char): Remove unused var.
12640
eb3f1cc8
PE
12641 * eval.c: Port to Windows vsnprintf (Bug#8435).
12642 Include <limits.h>.
12643 (SIZE_MAX): Define if the headers do not.
12644 (verror): Do not give up if vsnprintf returns a negative count.
12645 Instead, grow the buffer. This ports to Windows vsnprintf, which
12646 does not conform to C99. Problem reported by Eli Zaretskii.
12647 Also, simplify the allocation scheme, by avoiding the need for
12648 calling realloc, and removing the ALLOCATED variable.
12649
70476b54
PE
12650 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12651
12020a9e
PE
12652 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12653 But keep the doprint source code for now, as we might revamp it
12654 and use it again (Bug#8435).
ea6c7ae6
PE
12655 * lisp.h (doprnt): Remove.
12656 * Makefile.in (base_obj): Remove doprnt.o.
12657 * deps.mk (doprnt.o): Remove.
12658
5fdb398c
PE
12659 error: Print 32- and 64-bit integers portably (Bug#8435).
12660 Without this change, on typical 64-bit hosts error ("...%d...", N)
12661 was used to print both 32- and 64-bit integers N, which relied on
12662 undefined behavior.
61bdb816 12663 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12664 * lisp.h (error, verror): Mark as printf-like functions.
12665 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12666 Report overflow in size calculations when allocating printf buffer.
12667 Do not truncate output string at its first null byte.
12668 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12669 Truncate the output at a character boundary, since vsnprintf does not
12670 do that.
12671 * charset.c (check_iso_charset_parameter): Convert internal
12672 character to string before calling 'error', since %c now has the
12673 printf meaning.
12674 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12675 overflow when computing char to be passed to 'error'. Do not
12676 pass Lisp_Object to 'error'; pass the integer instead.
12677 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12678 formatted with plain %d.
12679
b189fa66
PE
12680 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12681
bff87ef0
PE
12682 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12683
7e2cac20
PE
12684 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12685
ce4d90b5
PE
12686 * xterm.c (x_catch_errors): Remove duplicate declaration.
12687
266c9547
PE
12688 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12689
79c49ad2
PE
12690 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12691
368f4090
JM
126922011-04-10 Jim Meyering <meyering@redhat.com>
12693
12694 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12695 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12696 return ssize_t not "int", and use size_t as the buffer length.
12697 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12698 * gnutls.h: Update declarations.
12699 * process.c (read_process_output): Use ssize_t, to match.
12700 (send_process): Likewise.
12701
a32d4040
CY
127022011-04-09 Chong Yidong <cyd@stupidchicken.com>
12703
12704 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12705
8546720e 127062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12707
04f2d78b
CB
12708 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12709 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12710
8546720e
GM
12711 * xterm.c (handle_one_xevent):
12712 * xmenu.c (create_and_show_popup_menu):
12713 * xselect.c (x_decline_selection_request)
12714 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12715
0a2f5c1a 127162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12717
12718 Fix some uses of `int' instead of EMACS_INT.
12719 * search.c (string_match_1, fast_string_match)
12720 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12721 (scan_buffer, find_next_newline_no_quit)
12722 (find_before_next_newline, search_command, Freplace_match)
12723 (Fmatch_data): Make some `int' variables be EMACS_INT.
12724
12725 * xdisp.c (display_count_lines): 3rd argument and return value now
12726 EMACS_INT. All callers changed.
12727 (pint2hrstr): Last argument is now EMACS_INT.
12728
12729 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12730 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12731 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12732 (decode_coding_utf_16, decode_coding_emacs_mule)
12733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12734 (decode_coding_ccl, decode_coding_charset)
12735 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12736 (decode_coding_iso_2022, decode_coding_emacs_mule)
12737 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12738 <char_offset, last_offset>: Declare EMACS_INT.
12739 (encode_coding_utf_8, encode_coding_utf_16)
12740 (encode_coding_emacs_mule, encode_invocation_designation)
12741 (encode_designation_at_bol, encode_coding_iso_2022)
12742 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12743 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12744 Declare EMACS_INT.
12745 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12746 (encode_invocation_designation): Last argument P_NCHARS is now
12747 EMACS_INT.
12748 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12749 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12750
12751 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12752 All users changed.
12753
12754 * ccl.c (Fccl_execute_on_string): Declare some variables
12755 EMACS_INT.
12756
8546720e 127572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12758
12759 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12760
4e19a977
CS
127612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12762
12763 * process.c (Fformat_network_address): Doc fix.
12764
87302331
R
127652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12766
ee7683eb 12767 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12768
cbb59342
CY
127692011-04-08 Chong Yidong <cyd@stupidchicken.com>
12770
12771 * keyboard.c (read_char): Call Lisp function help-form-show,
12772 instead of using internal_with_output_to_temp_buffer.
12773 (Qhelp_form_show): New var.
e0d38eeb 12774 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12775
12776 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12777
12778 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12779
e67a13ab
CY
127802011-04-06 Chong Yidong <cyd@stupidchicken.com>
12781
04f2d78b
CB
12782 * process.c (Flist_processes): Remove to Lisp.
12783 (list_processes_1): Delete.
e67a13ab 12784
973f782d
EZ
127852011-04-06 Eli Zaretskii <eliz@gnu.org>
12786
7c106b1e
EZ
12787 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12788
973f782d
EZ
12789 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12790
41cf7d1a 127912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12792
ca23cc88
PE
12793 Fix more problems found by GCC 4.6.0's static checks.
12794
f390e2d5
PE
12795 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12796
42eea0d0
PE
12797 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12798
b69769da 12799 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12800
f9541e84
PE
12801 * xdisp.c (vmessage): Mark as a printf-like function.
12802
13841b55
PE
12803 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12804
c136c10f
PE
12805 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12806
5e2d4a30
PE
12807 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12808 printf-like functions.
12809 (tiff_load): Add casts to remove these marks before passing them
12810 to system-supplied API.
12811
583f48b9
PE
12812 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12813
b25d760e
PE
12814 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12815 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12816 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12817 directly, rather than having caller test rule sign. This avoids
12818 some unnecessary tests.
12819 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12820 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12821 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12822
bc7b6697 12823 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12824 (xfont_open): Avoid unnecessary tests.
bc7b6697 12825
27ccc379
PE
12826 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12827
dcd5c89a
PE
12828 * composite.h, composite.c (composition_gstring_put_cache):
12829 Use EMACS_INT, not int, for length.
12830
b13a45c6
PE
12831 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12832 breaking out part of COMPOSITION_DECODE_RULE.
12833 (COMPOSITION_DECODE_RULE): Use it.
12834 * composite.c (get_composition_id): Remove unused local vars,
12835 by using the new macro.
12836
1e792e4d
PE
12837 * textprop.c (set_text_properties_1): Change while to do-while,
12838 since the condition is always true at first.
12839
dc6c6455 12840 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12841 (interval_deletion_adjustment): Return unsigned value.
12842 All uses changed.
dc6c6455 12843
aba7731a
PE
12844 * process.c (list_processes_1, create_pty, read_process_output):
12845 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12846 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12847 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12848 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12849 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12850
fdfc4bf3
PE
12851 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12852
fca8fe46 12853 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12854 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12855
06a0259a 12856 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12857 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12858 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12859
e7b9e80f
PE
12860 * print.c (print_error_message): Avoid int overflow.
12861
56201685
PE
12862 * font.c (font_list_entities): Redo for clarity,
12863 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12864
78834453 12865 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12866 (font_score): Avoid potential overflow in diff calculation.
78834453 12867
0bc0b309 12868 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12869 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12870
e610eaca
PE
12871 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12872
b895abce
PE
12873 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12874 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12875 can always succeed if overflow has undefined behavior.
12876
1f1d9321 12877 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12878 (wordify): Omit three unnecessary tests.
1f1d9321 12879
c59478bc
PE
12880 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12881 All callers changed. This avoids the need for an unused var.
12882
79b73827
PE
12883 * casefiddle.c (casify_region): Remove var that is set but not used.
12884
a4db5dfe
PE
12885 * dired.c (file_name_completion): Remove var that is set but not used.
12886
43aae36e
PE
12887 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12888
2a47c44d 12889 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12890 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12891
a37c69bf
PE
12892 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12893 Check for integer overflow on size calculations.
12894
328ab8e7
PE
12895 * buffer.c (Fprevious_overlay_change): Remove var that is set
12896 but not used.
12897
e5a2a5cb
PE
12898 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12899 Remove vars that are set but not used.
8d84a6eb 12900 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12901 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12902
a60e5f68
PE
12903 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12904
f661cb61 12905 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12906 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12907
f0397f5a
PE
12908 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12909 that are set but not used.
12910
8664db06 12911 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12912 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12913
6abdaa4a
PE
12914 * xselect.c (x_get_local_selection, x_handle_property_notify):
12915 Remove vars that are set but not used.
12916
0ce7538d 12917 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12918 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12919
9ae848fc
PE
12920 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12921 Remove var that is set but not used.
0b918413
PE
12922 (scroll_bar_windows_size): Now size_t, not int.
12923 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12924 Check for overflow.
9ae848fc 12925
a5a62657
PE
12926 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12927 (map_tty_color) [!defined MSDOS]: Likewise.
12928
5c5cdd39
PE
12929 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12930
66ebf983
PE
12931 * coding.c: Remove vars that are set but not used.
12932 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12933 All callers changed.
12934 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12935 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12936 (decode_coding_charset): Remove vars that are set but not used.
12937
1be4d761
PE
12938 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12939 that is set but not used.
12940
47553fa8
PE
12941 * print.c (print_object): Remove var that is set but not used.
12942
1f7196bf 12943 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12944 The gnulib version avoids calling malloc in the usual case,
12945 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12946 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12947 * filelock.c (current_lock_owner): Likewise.
12948 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12949 * sysdep.c: Include allocator.h, careadlinkat.h.
12950 (emacs_no_realloc_allocator): New static constant.
12951 (emacs_readlink): New function.
fdb61804
PE
12952 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12953 ../lib/careadlinkat.h.
d1fdcab7 12954
f84c17c7
SM
129552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12956
12957 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12958 first non-nil return value).
12959
ef3862ad
JD
129602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12961
12962 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12963 if not defined (Bug#8403).
12964
376a7006
JB
129652011-04-02 Juanma Barranquero <lekktu@gmail.com>
12966
12967 * xdisp.c (display_count_lines): Remove parameter `start',
12968 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12969 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12970 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12971 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12972 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12973 and thereabouts. All callers changed.
12974 (get_per_char_metric): Remove parameter `f', unused since
12975 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12976
6ca3801d
JM
129772011-04-02 Jim Meyering <meyering@redhat.com>
12978
12979 do not dereference NULL upon failed strdup
12980 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12981 (ns_get_family): Likewise.
12982
d8e2b5ba
JB
129832011-04-02 Juanma Barranquero <lekktu@gmail.com>
12984
12985 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12986
8c74fcbd
JD
129872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12988
12989 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12990 later (Bug#8403).
12991
7200d79c
SM
129922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12993
03408648 12994 Add lexical binding.
7200d79c 12995
03408648
SM
12996 * window.c (Ftemp_output_buffer_show): New fun.
12997 (Fsave_window_excursion):
12998 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12999
13000 * lread.c (lisp_file_lexically_bound_p): New function.
13001 (Fload): Bind Qlexical_binding.
13002 (readevalloop): Remove `evalfun' arg.
13003 Bind Qinternal_interpreter_environment.
13004 (Feval_buffer): Bind Qlexical_binding.
13005 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13006 Mark as dynamic.
13007 (syms_of_lread): Declare `lexical-binding'.
13008
13009 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13010
13011 * keyboard.c (eval_dyn): New fun.
13012 (menu_item_eval_property): Use it.
ca105506
SM
13013
13014 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13015
03408648
SM
13016 * fns.c (concat, mapcar1): Accept byte-code-functions.
13017
13018 * eval.c (Fsetq): Handle lexical vars.
13019 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13020 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13021 (FletX, Flet): Obey lexical binding.
13022 (Fcommandp): Handle closures.
13023 (Feval): New `lexical' arg.
13024 (eval_sub): New function extracted from Feval. Use it almost
13025 everywhere where Feval was used. Look up vars in lexical env.
13026 Handle closures.
13027 (Ffunctionp): Move from subr.el.
13028 (Ffuncall): Handle closures.
13029 (apply_lambda): Remove `eval_flags'.
13030 (funcall_lambda): Handle closures and new byte-code-functions.
13031 (Fspecial_variable_p): New function.
13032 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13033 but without exporting it to Lisp.
23aba0ea 13034
23aba0ea 13035 * doc.c (Fdocumentation, store_function_docstring):
03408648 13036 * data.c (Finteractive_form): Handle closures.
23aba0ea 13037
03408648
SM
13038 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13039 interactive spec.
ba83908c 13040
04f2d78b
CB
13041 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13042 New byte-codes.
03408648
SM
13043 (exec_byte_code): New function extracted from Fbyte_code to handle new
13044 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13045
03408648 13046 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13047
03408648 13048 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13049
e2abce01
JB
130502011-03-31 Juanma Barranquero <lekktu@gmail.com>
13051
13052 * xdisp.c (redisplay_internal): Fix prototype.
13053
63696a73 130542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13055
63696a73 13056 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13057 (try_scrolling): Use it when setting scroll_limit.
13058 Limit scrolling to 100 screen lines.
63696a73
EZ
13059 (redisplay_window): Even when falling back on "recentering",
13060 position point in the window according to scroll-conservatively,
13061 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13062
13063 (try_scrolling): When point is above the window, allow searching
13064 as far as scroll_max, or one screenful, to compute vertical
13065 distance from PT to the scroll margin position. This prevents
13066 try_scrolling from unnecessarily failing when
13067 scroll-conservatively is set to a value slightly larger than the
13068 window height. Clean up the case of PT below the margin at bottom
13069 of window: scroll_max can no longer be INT_MAX. When aggressive
13070 scrolling is in use, don't let point enter the opposite scroll
13071 margin as result of the scroll.
13072 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13073 threshold of 100 lines for never-recentering scrolling.
13074
e4cc2dfc
JB
130752011-03-31 Juanma Barranquero <lekktu@gmail.com>
13076
13077 * dispextern.h (move_it_by_lines):
13078 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13079 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13080 (message_log_check_duplicate): Remove parameters `prev_bol' and
13081 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13082 (redisplay_internal): Remove parameter `preserve_echo_area',
13083 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13084
13085 * indent.c (Fvertical_motion):
13086 * window.c (window_scroll_pixel_based, Frecenter):
13087 Don't pass `need_y_p' to `move_it_by_lines'.
13088
1c470562
SM
130892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13090
44f230aa
SM
13091 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13092 steal a few bits to be more compact.
13093 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13094 Remove unneeded casts.
13095
1c470562
SM
13096 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13097
888adce9
ZK
130982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13099
13100 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13101 binding" message (bug#7967).
13102
f838ed7b
PE
131032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13104
77861b95
PE
13105 Fix more problems found by GCC 4.6.0's static checks.
13106
de6dbc14
PE
13107 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13108 Remove unused local var.
13109
f838ed7b
PE
13110 * editfns.c (Fmessage_box): Remove unused local var.
13111
792c7b2b
PE
13112 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13113 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13114 Omit unused local vars.
c499e557 13115 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13116 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13117 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13118 Omit unused local var.
13119
ba0165e1
PE
13120 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13121 Don't assume string length fits in int.
32ad8845 13122 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13123 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13124
3c59b4c9
PE
13125 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13126 instead of alloca (Bug#8344).
13127
a3eed478 13128 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13129 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13130
eb4d412d
PE
13131 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13132
1658b401
PE
13133 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13134 concerns.
13135
13136 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13137
13138 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13139
9a2c6e05
PE
13140 * keyboard.c (syms_of_keyboard): Use the same style as later
13141 in this function when indexing through an array. This also
13142 works around GCC bug 48267.
13143
03d0a109
PE
13144 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13145
44f730c8
PE
13146 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13147
fe75f926
PE
13148 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13149 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13150
ffa8c828
PE
13151 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13152 This avoids undefined behavior on integer overflow, and is a bit
13153 more convenient anyway since it is compared to a size_t variable.
13154
c5101a77
PE
13155 Variadic C functions now count arguments with size_t, not int.
13156 This avoids an unnecessary limitation on 64-bit machines, which
13157 caused (substring ...) to crash on large vectors (Bug#8344).
13158 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13160 All variadic functions and their callers changed accordingly.
c5101a77
PE
13161 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13162 * data.c (arith_driver, float_arith_driver): Likewise.
13163 * editfns.c (general_insert_function): Likewise.
13164 * eval.c (struct backtrace.nargs, interactive_p)
13165 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13166 (funcall_lambda, mark_backtrace): Likewise.
13167 * fns.c (concat): Likewise.
13168 * frame.c (x_set_frame_parameters): Likewise.
13169 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13170 0 if not found, not -1. All callers changed.
13171
dd3f25f7
PE
13172 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13173 (stack_copy_size): Now size_t, not int.
13174 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13175
461c2ab9
JB
131762011-03-28 Juanma Barranquero <lekktu@gmail.com>
13177
13178 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13179 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13180 All callers changed.
13181
13182 * lisp.h (multibyte_char_to_unibyte):
13183 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13184 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13185 * character.h (CHAR_TO_BYTE8):
13186 * cmds.c (internal_self_insert):
13187 * editfns.c (general_insert_function):
13188 * keymap.c (push_key_description):
13189 * search.c (Freplace_match):
13190 * xdisp.c (message_dolog, set_message_1): All callers changed.
13191
f6d62986
SM
131922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13193
13194 * keyboard.c (safe_run_hook_funcall): New function.
13195 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13196 don't set the hook to nil, but remove the offending function instead.
13197 (Qcommand_hook_internal): Remove, unused.
13198 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13199 Vcommand_hook_internal.
13200
13201 * eval.c (enum run_hooks_condition): Remove.
13202 (funcall_nil, funcall_not): New functions.
13203 (run_hook_with_args): Call each function through a `funcall' argument.
13204 Remove `cond' argument, now redundant.
13205 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13206 (Frun_hook_with_args_until_failure): Adjust accordingly.
13207 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13208
1db5b1ad
JB
132092011-03-28 Juanma Barranquero <lekktu@gmail.com>
13210
13211 * dispextern.h (string_buffer_position): Remove declaration.
13212
13213 * print.c (strout): Remove parameter `multibyte', unused since
13214 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13215
13216 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13217 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13218 All callers changed.
13219
13220 * w32.c (_wsa_errlist): Use braces for struct initializers.
13221
13222 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13223 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13224 All callers changed.
13225 (string_buffer_position): Likewise. Also, make static (it's never
13226 used outside xdisp.c).
13227 (cursor_row_p): Remove parameter `w', unused since
13228 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13229 (decode_mode_spec): Remove parameter `precision', introduced during
13230 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13231 All callers changed.
13232
5ffb62aa
JD
132332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13234
13235 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13236
461c2ab9 132372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13238
13239 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13240 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13241 (ns_update_auto_hide_menu_bar): New functions.
13242 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13243 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13244 ns_constrain_all_frames.
13245 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13246 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13247
5c380ffb
JD
132482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13249
13250 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13251
9af30bdf
GM
132522011-03-27 Glenn Morris <rgm@gnu.org>
13253
13254 * syssignal.h: Replace RETSIGTYPE with void.
13255 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13256 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13257 Replace SIGTYPE with void everywhere.
13258 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13259 * s/template.h (SIGTYPE): Remove commented out definition.
13260
e2abce01
JB
132612011-03-26 Eli Zaretskii <eliz@gnu.org>
13262
13263 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13264 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13265
f868cd8a
JB
132662011-03-26 Juanma Barranquero <lekktu@gmail.com>
13267
59eb0929
JB
13268 * w32.c (read_unc_volume): Use parameter `henum', instead of
13269 global variable `wget_enum_handle'.
13270
13271 * keymap.c (describe_vector): Remove parameters `indices' and
13272 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13273 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13274
f868cd8a
JB
13275 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13276
13277 * keyboard.c (timer_check): Remove parameter `do_it_now',
13278 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13279 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13280 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13281
13282 * keyboard.c (read_char):
13283 * w32menu.c (w32_menu_display_help):
13284 * xmenu.c (show_help_event, menu_help_callback):
13285 Adjust calls to `show_help_echo'.
13286
13287 * gtkutil.c (xg_maybe_add_timer):
13288 * keyboard.c (readable_events):
13289 * process.c (wait_reading_process_output):
13290 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13291
13292 * insdel.c (adjust_markers_gap_motion):
13293 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13294 (gap_left, gap_right): Don't call it.
13295
2ecf6fdb
CY
132962011-03-25 Chong Yidong <cyd@stupidchicken.com>
13297
13298 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13299 incurred during fontification.
13300
6b1f9ba4
JB
133012011-03-25 Juanma Barranquero <lekktu@gmail.com>
13302
13303 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13304 (DEFVAR_PER_BUFFER): Don't pass it.
13305
13306 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13307 (scrolling_window): Don't pass it.
13308
0f4a96b5
JB
133092011-03-25 Juanma Barranquero <lekktu@gmail.com>
13310
13311 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13312
13313 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13314 and `suffix'.
13315 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13316 of variables specific to SELinux and computation of `encoded_absname'.
13317
13318 * image.c (XPutPixel): Remove unused variable `height'.
13319
13320 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13321
13322 * unexw32.c (get_section_info): Remove unused variable `section'.
13323
13324 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13325 (system_process_attributes): Remove unused variable `sess'.
13326 (sys_read): Remove unused variable `err'.
13327
13328 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13329 (w32_wnd_proc): Remove unused variable `isdead'.
13330 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13331 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13332 (x_create_tip_frame): Remove unused variable `tem'.
13333
13334 * w32inevt.c (w32_console_read_socket):
13335 Remove unused variable `no_events'.
13336
13337 * w32term.c (x_draw_composite_glyph_string_foreground):
13338 Remove unused variable `width'.
13339
1149507c
JB
133402011-03-24 Juanma Barranquero <lekktu@gmail.com>
13341
13342 * w32term.c (x_set_glyph_string_clipping):
13343 Don't pass uninitialized region to CombineRgn.
13344
9c88f339
JB
133452011-03-23 Juanma Barranquero <lekktu@gmail.com>
13346
13347 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13348 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13349 (Fx_close_connection): Remove unused variable `i'.
13350
13351 * w32font.c (w32font_draw): Return number of glyphs.
13352 (w32font_open_internal): Remove unused variable `i'.
13353 (w32font_driver): Add missing initializer.
13354
13355 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13356 (fill_in_menu): Remove unused variable `items_added'.
13357
13358 * w32term.c (last_mouse_press_frame): Remove static global variable.
13359 (w32_clip_to_row): Remove unused variable `f'.
13360 (x_delete_terminal): Remove unused variable `i'.
13361
13362 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13363 (NOTHING): Remove unused static global variable.
13364 (uniscribe_check_otf): Remove unused variable `table'.
13365 (uniscribe_font_driver): Add missing initializers.
13366
dee091a3
JD
133672011-03-23 Julien Danjou <julien@danjou.info>
13368
13369 * term.c (Fsuspend_tty, Fresume_tty):
13370 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13371 * window.c (temp_output_buffer_show):
13372 * insdel.c (signal_before_change):
13373 * frame.c (Fhandle_switch_frame):
13374 * fileio.c (Fdo_auto_save):
13375 * emacs.c (Fkill_emacs):
13376 * editfns.c (save_excursion_restore):
13377 * cmds.c (internal_self_insert):
13378 * callint.c (Fcall_interactively):
13379 * buffer.c (Fkill_all_local_variables):
13380 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13381 Use Frun_hooks.
0f4a96b5 13382 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13383 unconditionally since it does the check itself.
dee091a3 13384
2c520ab5 133852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13386
c9c49752
PE
13387 Fix more problems found by GCC 4.5.2's static checks.
13388
8abc3f12
PE
13389 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13390 the first time through the loop, since we know p0 < p1 then.
13391 This also avoids a gcc -Wstrict-overflow warning.
13392
a2d26660
PE
13393 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13394 leading to a memory leak, possible in functions like
13395 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13396 of objects (Bug#8318).
a2d26660 13397
916c72e9
PE
13398 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13399 that could (at least in theory) be that large.
13400
19ab8a18
PE
13401 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13402 This is less likely to overflow, and avoids undefined behavior if
13403 overflow does occur. All callers changed. Use strtoul to scan
13404 for the unsigned long integer.
b7cbbd6f
PE
13405 (pint2hrstr): Simplify and tune code slightly.
13406 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13407
f0641eff
PE
13408 * scroll.c (do_scrolling): Work around GCC bug 48228.
13409 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13410
7f650bb9
PE
13411 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13412 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13413 (validate_x_resource_name): Simplify count usage.
13414 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13415
37dd57d1
PE
13416 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13417 fail (Bug#8306).
81e56e61 13418
699979fc 13419 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13420
401bf9b4
PE
13421 * process.c (Fmake_network_process): Use socklen_t, not int,
13422 where POSIX says socklen_t is required in portable programs.
13423 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13424 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13425 (Fmake_network_process, server_accept_connection):
13426 (wait_reading_process_output, read_process_output):
13427 Likewise.
13428
b93aacde
PE
13429 * process.c: Rename or move locals to avoid shadowing.
13430 (list_processes_1, Fmake_network_process):
13431 (read_process_output_error_handler, exec_sentinel_error_handler):
13432 Rename or move locals.
4dc343ee 13433 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13434 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13435 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13436 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13437 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13438
af8a867c 13439 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13440 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13441 Include tparam.h instead, since it declares them.
af8a867c
PE
13442 * cm.h (PC): Remove extern decl; tparam.h now does this.
13443 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13444 * terminfo.c: Include tparam.h, to check interfaces.
13445 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13446 (tparam): Adjust signature to match interface in tparam.h;
13447 this removes some undefined behavior. Check that outstring and len
13448 are zero, which they always are with Emacs.
13449 * tparam.h (PC, BC, UP): New extern decls.
13450
0248044d 13451 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13452 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13453
8ff096c1 13454 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13455 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13456 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13457 (ftfont_list): Remove unused local.
49eaafba
PE
13458 (get_adstyle_property, ftfont_pattern_entity):
13459 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13460 Rename locals to avoid shadowing.
8ff096c1 13461
e2be39f6
PE
13462 * xfont.c (xfont_list_family): Mark var as initialized.
13463
c9735e30
PE
13464 * xml.c (make_dom): Now static.
13465
8f5201ae
PE
13466 * composite.c (composition_compute_stop_pos): Rename local to
13467 avoid shadowing.
b246f932
PE
13468 (composition_reseat_it): Remove unused locals.
13469 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13470 (composition_update_it): Mark var as initialized.
11b61122
PE
13471 (find_automatic_composition): Mark vars as initialized,
13472 with a FIXME (Bug#8290).
8f5201ae 13473
760fbc2c
PE
13474 character.h: Rename locals to avoid shadowing.
13475 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13476 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13477 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13478 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13479 to avoid shadowing.
13480
ff08eb85
PE
13481 * textprop.c (property_change_between_p): Remove; unused.
13482
fc7bf025
PE
13483 * intervals.c (interval_start_pos): Now static.
13484
235d7abc
PE
13485 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13486
44f230aa
SM
13487 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13488 Rename locals to avoid shadowing.
3e7d6594 13489
50060332
PE
13490 * sound.c (wav_play, au_play, Fplay_sound_internal):
13491 Fix pointer signedness.
d01f234b 13492 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13493 (wav_play): Initialize a variable to 0, to prevent undefined
13494 behavior (Bug#8278).
50060332 13495
c4fc4e30
PE
13496 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13497
918436ed
PE
13498 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13499
c939f91b
PE
13500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13501 clobbering (Bug#8298).
b9c7f648
PE
13502 * sysdep.c (sys_subshell): Likewise.
13503 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13504
6bd8c144
PE
13505 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13506 This should get cleaned up, so that child_setup has the
13507 same signature on all platforms.
13508
7710357c 13509 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13510 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13511
c59da222
CY
135122011-03-22 Chong Yidong <cyd@stupidchicken.com>
13513
13514 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13515 not to be necessary, and produces flickering.
13516
66b87493
GM
135172011-03-20 Glenn Morris <rgm@gnu.org>
13518
13519 * config.in: Remove file.
13520
45b6f6d5
JB
135212011-03-20 Juanma Barranquero <lekktu@gmail.com>
13522
13523 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13524 are now in src/globals.h.
13525 (syms_of_minibuf): Remove spurious & from previous change.
13526
cd394be1 135272011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13528
13529 * minibuf.c (completing-read-function): New variable.
13530 (completing-read-default): Rename from completing-read.
13531 (completing-read): Call completing-read-function.
13532
b14e3e21
CY
135332011-03-19 Juanma Barranquero <lekktu@gmail.com>
13534
13535 * xfaces.c (Fx_load_color_file):
13536 Read color file from absolute filename (bug#8250).
13537
f2b726e6
JB
135382011-03-19 Juanma Barranquero <lekktu@gmail.com>
13539
13540 * makefile.w32-in: Update dependencies.
13541
09f6ff02
EZ
135422011-03-17 Eli Zaretskii <eliz@gnu.org>
13543
13544 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13545
29a6015a
PE
135462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13547
a3a6c54e
PE
13548 Fix more problems found by GCC 4.5.2's static checks.
13549
b766f867
PE
13550 * process.c (make_serial_process_unwind, send_process_trap):
13551 (sigchld_handler): Now static.
13552
be02381c
PE
13553 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13554 That way, the code declares only the vars that it needs.
13555 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13556 * s/cygwin.h (PTY_ITERATION): Likewise.
13557 * s/darwin.h (PTY_ITERATION): Likewise.
13558 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13559
57048744
PE
13560 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13561 * process.c (allocate_pty): Don't declare stb unless it's needed.
13562
7914961c 13563 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13564 (CONSTANTLIM): Remove; unused.
13565 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13566 Define only if needed.
7914961c 13567
b3967b18
PE
13568 * unexelf.c (unexec): Name an expression,
13569 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13570 Use a different way to cause a compilation error if anyone uses
13571 n rather than nn, a way that does not involve shadowing.
73366a00 13572 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13573
29a6015a
PE
13574 * deps.mk (unexalpha.o): Remove; unused.
13575
43cfc33e 13576 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13577 * unexec.h: New file.
ce701a33
PE
13578 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13579 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13580 Depend on unexec.h.
13581 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13582 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13583 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13584 Change as necessary to match prototype in unexec.h.
ce701a33 13585
01f44d5a
PE
13586 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13587 shadowing.
4f63c6bb 13588 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13589
a6670b0b
PE
13590 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13591 Rename locals to avoid shadowing.
13592
cef2010d 13593 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13594 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13595
d4d7173a
PE
13596 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13597
f08b802a
PE
13598 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13599 warning when compiling print.c.
13600
3ddb0639
PE
13601 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13602 instead of using an uninitialized var.
5ad03b97 13603 (font_sort_entities): Mark var as initialized.
3ddb0639 13604
170a2692
PE
13605 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13606
e663c700
PE
13607 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13608 pointers to constants.
89bc529a 13609 (font_parse_fcname): Remove unused vars.
7b81e2d0 13610 (font_delete_unmatched): Now static.
ea838e10 13611 (font_get_spec): Remove; unused.
13a547c6
PE
13612 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13613 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13614 Rename or move locals to avoid shadowing.
e663c700 13615
2a80c887 13616 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13617 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13618
1384fa33 13619 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13620 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13621
8b2c52e9
PE
13622 * alloc.c (mark_backtrace): Move decl from here ...
13623 * lisp.h: ... to here, so that it can be checked.
13624
475545b5 13625 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13626 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13627 (lisp_indirect_variable): Name an expression,
13628 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13629 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13630
b1349114 13631 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13632 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13633 Use const pointer when appropriate.
b1349114 13634
a2928364
PE
13635 * lisp.h (get_system_name, get_operating_system_release):
13636 Move decls here, to check interfaces.
13637 * process.c (get_operating_system_release): Move decl to lisp.h.
13638 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13639 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13640 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13641 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13642 (Fformat_time_string, Fencode_time, Finsert_char):
13643 (Ftranslate_region_internal, Fformat):
13644 Rename or remove local vars to avoid shadowing.
9710023e 13645 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13646
a415e694
PE
13647 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13648 avoid shadowing.
13649
8ef4622d
PE
13650 * lisp.h (eassert): Check that the argument compiles, even if
13651 ENABLE_CHECKING is not defined.
13652
946f9a5b
PE
13653 * data.c (Findirect_variable): Name an expression, to avoid
13654 gcc -Wbad-function-cast warning.
112396d6 13655 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13656 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13657 (Fmake_variable_buffer_local, Fmake_local_variable):
13658 Mark variables as initialized.
52746918 13659 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13660
e5aab7e7 13661 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13662 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13663 Rename locals to avoid shadowing.
dff45157
PE
13664 (mark_stack): Move local variables into the #ifdef region where
13665 they're used.
7bc26fdb
PE
13666 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13667 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13668 needed otherwise.
13669 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13670 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13671 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13672
e5aab7e7
PE
13673 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13674 avoids undefined behavior in theory.
13675
4da60324
PE
13676 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13677
88043301
PE
13678 Use functions, not macros, for up- and down-casing (Bug#8254).
13679 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13681 to use the following functions instead of these macros.
13682 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13683 EMACS_INT, since callers assume the returned value fits in int.
13684 (upcase1): Likewise, for UPCASE_TABLE.
13685 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13686 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13687 the race-condition problem in the old DOWNCASE.
88043301 13688
19ed5445
PE
13689 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13690 Rename locals to avoid shadowing.
13691 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13692 (regex_compile, re_search_2, re_match_2_internal):
13693 Remove unused local vars.
952db0d7
PE
13694 (FREE_VAR): Rewrite so as not to use empty "else",
13695 which gcc can warn about.
da053e48 13696 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13697 (RETALLOC_IF): Define only if needed.
13698 (WORDCHAR_P): Likewise. This one is never needed, but is used
13699 only in a comment talking about a compiler bug, so put inside
13700 the #if 0 of that comment.
13701 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13702 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13703 Remove; unused.
19ed5445 13704
1f3561e4 13705 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13706 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13707 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13708
ded6f8f7
PE
13709 * search.c (simple_search): Remove unused var.
13710
dbd37a95
PE
13711 * dired.c (compile_pattern): Move decl from here ...
13712 * lisp.h: ... to here, so that it can be checked.
13713 (struct re_registers): New forward decl.
13714
7e47afad
PE
13715 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13716
85f24f61
PE
13717 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13718 All uses changed.
13719 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13720 Rename locals to avoid shadowing.
5671df8f 13721 (Fvertical_motion): Mark locals as initialized.
85f24f61 13722
181aa2be 13723 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13724 (casify_region): Mark local as initialized.
181aa2be 13725
930d429c
PE
13726 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13727
7082eac6
PE
13728 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13729 New macros, so that the caller can use some names other than
13730 gcpro1, gcpro2, etc.
13731 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13732 of the new macros.
13733 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13734 argument, for consistency with GCPRO2_VAR, etc: it is now the
13735 prefix of the variable, not the variable itself. All uses
13736 changed.
38b2c076
PE
13737 * dired.c (directory_files_internal, file_name_completion):
13738 Rename locals to avoid shadowing.
13739
15206ed9
PE
13740 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13741 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13742 dired.c's scmp function, had undefined behavior.
13743 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13745 * buffer.h: ... to here, because these macros use current_buffer,
13746 and the new implementation with inline functions needs to have
13747 current_buffer in scope now, rather than later when the macros
13748 are used.
13749 (downcase, upcase1): New static inline functions.
13750 (DOWNCASE, UPCASE1): Reimplement using these functions.
13751 This avoids undefined behavior in expressions like
13752 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13753 from race conditions in accessing the global variables
13754 case_temp1 and case_temp2.
13755 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13756 * lisp.h (case_temp1, case_temp2): Remove their decls.
13757 * character.h (ASCII_CHAR_P): Move from here ...
13758 * lisp.h: ... to here, so that the inline functions mentioned
13759 above can use them.
13760
4a6bea26
PE
13761 * dired.c (directory_files_internal_unwind): Now static.
13762
f14b7e14
PE
13763 * fileio.c (file_name_as_directory, directory_file_name):
13764 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13765 Now static.
2893f146
PE
13766 (file_name_as_directory): Use const pointers when appropriate.
13767 (Fexpand_file_name): Likewise. In particular, newdir might
13768 point at constant storage, so make it a const pointer.
fd4ead52 13769 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13770 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13771 signedness issues.
f839df0c
PE
13772 (Fset_file_times, Finsert_file_contents, auto_save_error):
13773 Rename locals to avoid shadowing.
f14b7e14 13774
5716756e 13775 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13776 (Ftry_completion, Fall_completions): Rename or remove locals
13777 to avoid shadowing.
5716756e 13778
b4c3046a
PE
13779 * marker.c (bytepos_to_charpos): Remove; unused.
13780
b45db522
PE
13781 * lisp.h (verify_bytepos, count_markers): New decls,
13782 so that gcc does not warn that these functions aren't declared.
13783
85876d07
PE
13784 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13785 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13786 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13787 (copy_text): Remove unused local var.
85876d07 13788
03d78a21 13789 * filelock.c (within_one_second): Now static.
b3dd38ab 13790 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13791
5df8f01b
PE
13792 * buffer.c (fix_overlays_before): Mark locals as initialized.
13793 (fix_start_end_in_overlays): Likewise. This function should be
13794 simplified by using pointers-to-pointers, but that's a different
13795 matter.
b1d876f1 13796 (switch_to_buffer_1): Now static.
8f54f30a
PE
13797 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13798 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13799
a70072c9 13800 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13801 Fix pointer signedness issue.
edced198
PE
13802 (sys_subshell): Mark local as volatile if checking for lint,
13803 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13804 (MAXPATHLEN): Define only if needed.
a70072c9 13805
a0977c44
PE
13806 * process.c (serial_open, serial_configure): Move decls from here ...
13807 * systty.h: ... to here, so that they can be checked.
13808
a884fdcc
PE
13809 * fns.c (get_random, seed_random): Move extern decls from here ...
13810 * lisp.h: ... to here, so that they can be checked.
13811
604efe86 13812 * sysdep.c (reset_io): Now static.
b8950c94 13813 (wait_for_termination_signal): Remove; unused.
604efe86 13814
38fc62d9
PE
13815 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13816 (copy_keymap_item, append_key, push_text_char_description):
13817 Now static.
1004a21a 13818 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13819 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13820 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13821 (describe_map_tree):
13822 Rename locals to avoid shadowing.
38fc62d9 13823
2f2650da
PE
13824 * keyboard.c: Declare functions static if they are not used elsewhere.
13825 (echo_char, echo_dash, cmd_error, top_level_2):
13826 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13827 (read_char, kbd_buffer_get_event, make_lispy_position):
13828 (make_lispy_event, make_lispy_movement, apply_modifiers):
13829 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13830 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13831 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13832 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13833 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13834
a053e86c 13835 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13836 (mark_kboards): Move decl here ...
13837 * alloc.c (mark_kboards): ... from here.
a053e86c 13838
4752793e
PE
13839 * lisp.h (force_auto_save_soon): New decl.
13840
74f10ca7 13841 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13842 (DEFINE_DUMMY_FUNCTION): New macro.
13843 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13844 Use it.
c03cd23f
PE
13845 (main): Add casts to avoid warnings
13846 if GCC considers string literals to be constants.
74f10ca7 13847
022e70d4
PE
13848 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13849
59d6fe83
PE
13850 * dbusbind.c: Pointer signedness fixes.
13851 (xd_signature, xd_append_arg, xd_initialize):
13852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13853 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13854 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13855 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13856
78320123
PE
13857 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13858 if GCC considers string literals to be constants.
49cebcca 13859 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13860
35ac2a97
SM
138612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13862
fb103ca9
SM
13863 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13864 (print_preprocess, print_object): New macro to fix last change.
13865
35ac2a97
SM
13866 * print.c (print_preprocess): Don't forget font objects.
13867
62973b41
JB
138682011-03-16 Juanma Barranquero <lekktu@gmail.com>
13869
13870 * emacs.c (USAGE3): Doc fixes.
13871
0e48bb22
AS
138722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13873
13874 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13875 structure.
13876
7684e57b
JB
138772011-03-14 Juanma Barranquero <lekktu@gmail.com>
13878
13879 * lisp.h (VWindow_system, Qfile_name_history):
13880 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13881 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13882 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13883
13884 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13885 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13886
13887 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13888 * w32console.c (detect_input_pending, read_input_pending)
13889 (encode_terminal_code):
13890 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13891 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13892 (w32_system_caret_y, Qfile_name_history):
13893 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13894 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13895 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13896 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13897 * w32proc.c (Qlocal, report_file_error):
13898 * w32term.c (Vwindow_system, updating_frame):
13899 * w32uniscribe.c (initialized, uniscribe_font_driver):
13900 Remove unneeded extern declarations.
13901
2aa46d6c
CY
139022011-03-14 Chong Yidong <cyd@stupidchicken.com>
13903
c96bbc66 13904 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13905
cffc6f3b
CY
139062011-03-13 Chong Yidong <cyd@stupidchicken.com>
13907
13908 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13909 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13910 These macros can no longer be used for assignment.
13911
44f230aa
SM
13912 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13913 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13914 (record_buffer_markers, fetch_buffer_markers): New functions for
13915 recording and fetching special buffer markers.
13916 (set_buffer_internal_1, set_buffer_temp): Use them.
13917
13918 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13919
13920 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13921
13922 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13923 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13924
13925 * xdisp.c (hscroll_window_tree):
13926 (reconsider_clip_changes): Use PT instead of BUF_PT.
13927
d251f04b
EZ
139282011-03-13 Eli Zaretskii <eliz@gnu.org>
13929
13930 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13931 $(EMACS_ROOT)/lib/intprops.h.
13932
f0c77cd1
PE
139332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13934
3eca4629
PE
13935 Fix more problems found by GCC 4.5.2's static checks.
13936
7c86ee98
PE
13937 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13938 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13939 (xg_free_frame_widgets): Make it clear that a local variable is
13940 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13941 (gdk_window_get_screen): Make it clear that this macro is needed
13942 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13943 (int_gtk_range_get_value): New function, which avoids a diagnostic
13944 from gcc -Wbad-function-cast.
13945 (xg_set_toolkit_scroll_bar_thumb): Use it.
13946 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13947 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13948 (get_utf8_string, xg_get_file_with_chooser):
13949 Rename locals to avoid shadowing.
13950 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13951
41729b81
PE
13952 * xgselect.c (xg_select): Remove unused var.
13953
f0c77cd1
PE
13954 * image.c (four_corners_best): Mark locals as initialized.
13955 (gif_load): Initialize transparent_p to zero (Bug#8238).
13956 Mark another local as initialized.
ec6cf4c6 13957 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13958
ce0ad53d 13959 * image.c (clear_image_cache): Now static.
d5d5a617 13960 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13961 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13962 (x_edge_detection): Remove unnecessary cast that
13963 gcc -Wbad-function-cast diagnoses.
2037898d 13964 (gif_load): Fix pointer signedness.
6ae141d6
PE
13965 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13966 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13967
33383987 139682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13969
d32df629
PE
13970 Improve quality of tests for time stamp overflow.
13971 For example, without this patch (encode-time 0 0 0 1 1
13972 1152921504606846976) returns the obviously-bogus value (-948597
13973 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13974 reports time overflow. See
13975 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13976 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13977 * editfns.c: Include limits.h and intprops.h.
13978 (TIME_T_MIN, TIME_T_MAX): New macros.
13979 (time_overflow): Move earlier, to before first use.
13980 (hi_time, lo_time): New functions, for an accurate test for
13981 out-of-range times.
13982 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13983 (Fget_internal_run_time): Don't assume time_t fits in int.
13984 (make_time): Use list2 instead of Fcons twice.
13985 (Fdecode_time): More accurate test for out-of-range times.
13986 (check_tm_member): New function.
13987 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13988 (lisp_time_argument): Don't rely on undefined left-shift and
13989 right-shift behavior when checking for time stamp overflow.
8be6f318 13990
fe31d94c
PE
13991 * editfns.c (time_overflow): New function, refactoring common code.
13992 (Fformat_time_string, Fdecode_time, Fencode_time):
13993 (Fcurrent_time_string): Use it.
13994
8be6f318
PE
13995 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13996 * dired.c (make_time): Move to ...
13997 * editfns.c (make_time): ... here.
13998 * systime.h: Note the move.
13999
09d9db2c 140002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14001
126bc0dc
YM
14002 * fringe.c (update_window_fringes): Remove unused variables.
14003
c47cbdfd
YM
14004 * unexmacosx.c (copy_data_segment): Also copy __got section.
14005 (Bug#8223)
14006
7ac80be9
EZ
140072011-03-12 Eli Zaretskii <eliz@gnu.org>
14008
c96bbc66 14009 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14010 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14011 Constify `char *' arguments and their references according to
14012 prototypes in tparam.h.
14013
ecb0f94d 14014 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14015
7ac80be9
EZ
14016 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14017 Adapt all references accordingly.
14018
14019 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14020
ef1fd07e
TT
140212011-03-11 Tom Tromey <tromey@redhat.com>
14022
14023 * buffer.c (syms_of_buffer): Remove obsolete comment.
14024
7ef4b50c
EZ
140252011-03-11 Eli Zaretskii <eliz@gnu.org>
14026
14027 * termhooks.h (encode_terminal_code): Declare prototype.
14028
14029 * msdos.c (encode_terminal_code): Don't declare prototype.
14030
14031 * term.c (encode_terminal_code): Now external again, used by
14032 w32console.c and msdos.c.
14033
44f230aa
SM
14034 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14035 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14036
4b1ec863 140372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14038
1714f52b 14039 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14040
4b1ec863
PE
14041 * fringe.c (update_window_fringes): Mark locals as initialized
14042 (Bug#8227).
14043 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14044
524c7aa6
PE
14045 * alloc.c (mark_fringe_data): Move decl from here ...
14046 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14047 to check its interface.
14048 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14049
a5c0af81 14050 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14051 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14052 (fontset_font): Mark local as initialized.
a9a06e0b 14053 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14054
b4716021
PE
14055 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14056
811e9bac 14057 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14058 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14059 (x_own_selection, Fx_disown_selection_internal): Rename locals
14060 to avoid shadowing.
14061 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14062
7e3ab302
PE
14063 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14064 so that the caller can use some name other than gcpro1.
14065 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14066 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14067 (Fx_backspace_delete_keys_p):
14068 Use them to avoid shadowing, and rename vars to avoid shadowing.
14069 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14070 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14071 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14072 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14073 Remove unused locals.
7e3ab302
PE
14074 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14075 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14076 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14077 macros.
f78faa98 14078
e2b13473
PE
14079 * xterm.h (x_mouse_leave): New decl.
14080
77f23912
PE
14081 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14082 Remove unused functions.
cdf4ba58
PE
14083 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14084 (x_calc_absolute_position): Now static.
7411c686 14085 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14086 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14087 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14088 unless they are used.
38d0b34a
PE
14089 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14090 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14091 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14092 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14093 (x_error_catcher, x_connection_closed, x_error_handler):
14094 (x_error_quitter, xembed_send_message, x_iconify_frame):
14095 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14096 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14097 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14098
44f230aa
SM
14099 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14100 Rename or move locals to avoid shadowing.
6b463e58 14101 (tty_defined_color, merge_face_heights): Now static.
5967d051 14102 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14103 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14104 does not deduce is never used uninitialized.
73719eba
PE
14105 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14106 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14107
426994c3 14108 * terminal.c (store_terminal_param): Now static.
5489860b 14109
032f1620 14110 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14111 (set_frame_menubar): Remove unused local.
d4323972 14112 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14113 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14114 since they might point to immutable storage.
281585b0
PE
14115 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14116 since it's unused otherwise.
032f1620 14117
367c19e5 14118 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14119 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14120 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14121 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14122 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14123 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14124 does not deduce are never used uninitialized.
70739cbe 14125
07b48fa9
PE
14126 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14127
8868a238 14128 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14129 * window.c (window_loop, size_window):
14130 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14131
7e5cf297 14132 * window.c (display_buffer): Now static.
d6550a9f
PE
14133 (size_window): Mark variables that gcc -Wuninitialized
14134 does not deduce are never used uninitialized.
a586633d
PE
14135 * window.h (check_all_windows): New decl, to forestall
14136 gcc -Wmissing-prototypes diagnostic.
5b555da1 14137 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14138
f6095868
PE
14139 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14140 shadowing.
14141 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14142 Include <limits.h>.
14143 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14144 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14145 (load_charset_map): Mark variables that gcc -Wuninitialized
14146 does not deduce are never used uninitialized.
53df7c11 14147 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14148
f38b440c
PE
14149 * coding.c (coding_set_source, coding_set_destination):
14150 Use "else { /* comment */ }" rather than "else /* comment */;"
14151 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14152 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14153 a block, when the outer 'i' will do.
14154 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14155 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14156 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14157 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14158 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14159 Rename locals to avoid shadowing.
14160 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14161 * coding.c (emacs_mule_char, encode_invocation_designation):
14162 Now static, since they're not used elsewhere.
413bb2db 14163 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14164 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14165 (decode_coding_emacs_mule): Mark variables that gcc
14166 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14167 (detect_coding_iso_2022): Initialize a local variable that might
14168 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14169 this initialization is needed. (Bug#8211)
5f58e762
PE
14170 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14171 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14172 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14173 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14174 Remove unused macros.
f38b440c 14175
232b38b9 14176 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14177 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14178 * character.c (string_count_byte8): Likewise.
232b38b9 14179
fb90da1b
PE
14180 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14181 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14182
fb93dbc2
PE
14183 * chartab.c (copy_sub_char_table): Now static, since it's not used
14184 elsewhere.
5c156ace
PE
14185 (sub_char_table_ref_and_range, char_table_ref_and_range):
14186 Rename locals to avoid shadowing.
bbcd0949 14187 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14188
7d3b3862 14189 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14190 (BIDI_BOB): Remove unused macro.
7d3b3862 14191
6be7d3da
PE
14192 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14193 deduce are never used uninitialized.
c2ed9c8b 14194 * term.c (encode_terminal_code): Likewise.
6be7d3da 14195
75f8807f 14196 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14197
50938595
PE
14198 * tparam.h: New file.
14199 * term.c, tparam.h: Include it.
14200 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14201 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14202 Move these decls to tparam.h, and make them agree with what
14203 is actually in tparam.c. The previous trick of using incompatible
14204 decls in different modules does not conform to the C standard.
14205 All callers of tparam changed to use tparam's actual API.
14206 * tparam.c (tparam1, tparam, tgoto):
14207 Use const pointers where appropriate.
14208
fbceeba2
PE
14209 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14210 * cm.h (struct cm): Likewise.
14211 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14212 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14213 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14214 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14215 (turn_on_face, init_tty): Likewise.
14216 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14217
7f3f1250
PE
14218 * term.c (term_mouse_position): Rename local to avoid shadowing.
14219
e6ca6543
PE
14220 * alloc.c (mark_ttys): Move decl from here ...
14221 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14222
c40f8d15
AS
142232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14224
14225 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14226
cfe0661d
JB
142272011-03-09 Juanma Barranquero <lekktu@gmail.com>
14228
14229 * search.c (compile_pattern_1): Remove argument regp, unused since
14230 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14231 (compile_pattern): Don't pass it.
14232
0afb4571
J
142332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14234
14235 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14236 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14237 for ! HAVE_GTK3.
14238 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14239
14240 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14241
14242 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14243 gdk_window_get_screen, gdk_window_get_geometry,
14244 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14245 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14246 (xg_get_pixbuf_from_pixmap): New function.
14247 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14248 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14249 Call xg_get_pixbuf_from_pixmap instead of
14250 gdk_pixbuf_get_from_drawable.
14251 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14252 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14253 (xg_check_special_colors): Use GtkStyleContext and its functions
14254 for HAVE_GTK3.
14255 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14256 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14257 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14258 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14259 Call gtk_widget_get_preferred_size.
0afb4571
J
14260 (xg_frame_resized): gdk_window_get_geometry only takes 5
14261 parameters.
44f230aa
SM
14262 (xg_win_to_widget, xg_event_is_for_menubar):
14263 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14264 (xg_set_widget_bg): New function.
14265 (delete_cb): New function.
895009e1 14266 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14267 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14268 (xg_set_background_color): Call xg_set_widget_bg.
14269 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14270 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14271 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14272 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14273 if ! HAVE_GTK3.
14274 (update_frame_tool_bar): Call gtk_widget_hide.
14275 (xg_initialize): Use GDK_KEY_g.
14276
14277 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14278 if ! HAVE_GTK3
14279 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14280
14281 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14282 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14283 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14284
1c2cc4ef
JB
142852011-03-08 Juanma Barranquero <lekktu@gmail.com>
14286
14287 * w32xfns.c (select_palette): Check success of RealizePalette against
14288 GDI_ERROR, not zero.
14289
33383987 14290See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14291
14292;; Local Variables:
14293;; coding: utf-8
aac0c6e3
MR
14294;; End:
14295
2f097256 14296 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14297
14298 This file is part of GNU Emacs.
14299
14300 GNU Emacs is free software: you can redistribute it and/or modify
14301 it under the terms of the GNU General Public License as published by
14302 the Free Software Foundation, either version 3 of the License, or
14303 (at your option) any later version.
14304
14305 GNU Emacs is distributed in the hope that it will be useful,
14306 but WITHOUT ANY WARRANTY; without even the implied warranty of
14307 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14308 GNU General Public License for more details.
14309
14310 You should have received a copy of the GNU General Public License
14311 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.