progmodes/cc-engine.el (c-state-cache-non-literal-place): Correct to
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b215eee5
EZ
12011-08-16 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5
a4579d33
KB
62011-08-16 Ken Brown <kbrown@cornell.edu>
7
8 Fix memory allocation problems in Cygwin build (Bug#9273).
9
10 * unexcw.c ( __malloc_initialized): Declare external variable.
11 (fixup_executable): Force the dumped emacs to reinitialize malloc.
12
13 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
14 variables.
15 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
16 dumped emacs.
17 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
18 in the static heap.
19 [CYGWIN] (special_realloc): New function.
20 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
21 requests to realloc storage in the static heap.
22
3ebec551
PE
232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
24
25 * bidi.c (bidi_initialize): Remove unused local.
26
9fd8be00
EZ
272011-08-15 Eli Zaretskii <eliz@gnu.org>
28
474a8465
EZ
29 * biditype.h: File removed.
30
31 * bidimirror.h: File removed.
32
33 * deps.mk (bidi.o): Remove biditype.h and
34 bidimirror.h.
35
36 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
37 bidimirror.h.
38
39 * dispextern.h: Fix a typo in the comment to bidi_type_t.
40
41 * chartab.c: Improve commentary for the uniprop_table API.
42
32413314
EZ
43 * bidi.c (bidi_paragraph_init): Support zero value of
44 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
45 (bidi_initialize): Use uniprop_table instead of including
46 biditype.h and bidimirror.h.
32413314 47
9fd8be00
EZ
48 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
49 coordinates of the iterator when restoring from ppos_it.
50 (Bug#9296)
51
5cf2b69b
KH
522011-08-14 Kenichi Handa <handa@m17n.org>
53
54 * process.c (create_process): Call setup_process_coding_systems
55 after the pid of the process is set to -1.
56
daf17d00
EZ
572011-08-14 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (move_it_in_display_line_to): Don't invoke
60 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
61 ppos_it. Fixes vertical cursor motion when line beginning is
62 covered by an image. (Bug#9296)
63
08e3161a
JD
642011-08-14 Jan Djärv <jan.h.d@swipnet.se>
65
66 * nsterm.h (ns_run_ascript): Declare.
67 (NSAPP_DATA2_RUNASSCRIPT): Define.
68
69 * nsfns.m (as_script, as_result, as_status): New static variables.
70 (ns_run_ascript): New function.
71 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
72 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
73 the event loop. Get status from as_status (Bug#7276).
74
75 * nsterm.m (sendEvent): If event is NSApplicationDefined and
76 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
77 the event loop (Bug#7276).
78
a3720aa2
AS
792011-08-14 Andreas Schwab <schwab@linux-m68k.org>
80
81 * gnutls.c (QCgnutls_bootprop_priority)
82 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
83 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
84 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
85 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
86 (QCgnutls_bootprop_verify_hostname_error)
87 (QCgnutls_bootprop_callbacks_verify): Rename from
88 Qgnutls_bootprop_..., all uses changed.
89
90 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
91 uses changed.
92
0a0d27fb
PE
932011-08-14 Paul Eggert <eggert@cs.ucla.edu>
94
19d5c50c
PE
95 * xfaces.c (Qframe_set_background_mode): Now static.
96 * dispextern.h (Qframe_set_background_mode): Remove decl.
97
0a0d27fb
PE
98 * process.c (Fnetwork_interface_info): Declare local only if needed.
99
377538cb
JD
1002011-08-13 Jan Djärv <jan.h.d@swipnet.se>
101
102 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
103 (Fnetwork_interface_list): Allocate in increments of bytes instead
104 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
105 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
106 sockaddr.
107 (struct ifflag_def): notrailers is smart on OSX.
108 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
109 Get hardware address with getifaddrs if available.
110
08fff70c
EZ
1112011-08-12 Eli Zaretskii <eliz@gnu.org>
112
113 * xdisp.c (iterate_out_of_display_property): xassert that
114 IT->position is set to within IT->object's boundaries. Break from
115 the loop as soon as EOB is reached; avoids infloops in redisplay
116 when IT->position is set up wrongly due to some bug. Set
117 IT->current to match the bidi iterator unconditionally.
118 (push_display_prop): Allow GET_FROM_STRING as IT->method on
119 entry. Force push_it to save on the stack the current
120 buffer/string position, to be restored by pop_it. Fix flags in
121 the iterator structure wrt the object coming from a display
122 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
123 properties. (Bug#9284)
124
7be1c708 1252011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 126
7be1c708
CY
127 * fontset.c (fontset_get_font_group): Add proper type checks.
128 (Bug#9172)
aac0c6e3 129
7be1c708 1302011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 131
7be1c708
CY
132 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
133 and LC_VERSION_MIN_MACOSX.
134 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
135 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 136
97bb72a6
EZ
1372011-08-08 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
140 no-display-properties-and-no-overlays under bidi display. Set
141 disp_pos in the bidi iterator to avoid searches for display
142 properties and overlays.
97bb72a6 143
d5617611
CY
1442011-08-08 Chong Yidong <cyd@stupidchicken.com>
145
37e11a63
CY
146 * editfns.c (Fset_time_zone_rule): Document relationship with the
147 setenv function.
148
d5617611
CY
149 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
150 the font entity extracted from the cache (Bug#8109).
151
58872834
CY
1522011-08-07 Chong Yidong <cyd@stupidchicken.com>
153
154 * composite.c (autocmp_chars): Don't reset point. That is done by
155 restore_point_unwind (Bug#5984).
156
75bfc667
JL
1572011-08-07 Juri Linkov <juri@jurta.org>
158
159 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
160 to show the arg `TIME' instead of `TIMEVAL'.
161
d1410150
EZ
1622011-08-06 Eli Zaretskii <eliz@gnu.org>
163
164 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
165 display property strides EOL and includes a newline, as in
166 longlines-mode. (Bug#9254)
75b771e4
EZ
167 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
168 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
169
170 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
171 is non-zero, even if the data buffer is NULL. Fixes a crash in
172 vertical-motion with longlines-mode. (Bug#9254)
173
35928349
EZ
1742011-08-05 Eli Zaretskii <eliz@gnu.org>
175
ec7cc85b
EZ
176 * bidi.c <bidi_cache_total_alloc>: Now static.
177 (bidi_initialize): Initialize bidi_cache_total_alloc.
178
35928349
EZ
179 *xdisp.c (display_line): Release buffer allocated for shelved bidi
180 cache. (Bug#9221)
181
182 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
183 amount allocated this far in `bidi_cache_total_alloc'.
184 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
185 non-zero, only free the data buffer without restoring the cache
186 contents. All callers changed.
187
188 * dispextern.h (bidi_unshelve_cache): Update prototype.
189
190 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
191 (move_it_in_display_line, move_it_to)
192 (move_it_vertically_backward, move_it_by_lines): Replace the call
193 to xfree to an equivalent call to bidi_unshelve_cache.
194 (move_it_in_display_line_to): Fix logic of returning
412b6358 195 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 196
e2e2423b
EZ
1972011-08-05 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
200 came from a string character with a `cursor' property. (Bug#9229)
201
ae9e757a
JD
2022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
203
204 * Makefile.in (LIB_PTHREAD): New variable.
205 (LIBES): Add LIB_PTHREAD (Bug#9216).
206
207 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
208 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
209
213bd7f2
AS
2102011-08-04 Andreas Schwab <schwab@linux-m68k.org>
211
212 * regex.c (re_iswctype): Remove some redundant boolean
213 conversions.
214
99aaf75f
JD
2152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
216
217 * xterm.c (x_find_topmost_parent): New function.
218 (x_set_frame_alpha): Find topmost parent window with
219 x_find_topmost_parent and set the property there also (bug#9181).
220 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
221
c74e9d86
PE
2222011-08-04 Paul Eggert <eggert@cs.ucla.edu>
223
224 * callproc.c (Fcall_process): Avoid vfork clobbering
225 the local vars buffer, coding_systems, current_dir.
226
640c8776
SM
2272011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
228
229 * keymap.c (Fmake_composed_keymap): Move to subr.el.
230
f26d0e4c
PE
2312011-08-03 Paul Eggert <eggert@cs.ucla.edu>
232
8a10d76c
PE
233 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
234 so that it is not optimized away.
235
f26d0e4c
PE
236 * xdisp.c (compute_display_string_pos): Remove unused local.
237
55439c61
EZ
2382011-08-02 Eli Zaretskii <eliz@gnu.org>
239
240 Fix slow cursor motion and scrolling in large buffers with
241 selective display, like Org Mode buffers. (Bug#9218)
242
243 * dispextern.h (struct bidi_it): New member disp_prop_p.
244
245 * xdisp.c: Remove one-slot cache of display string positions.
246 (compute_display_string_pos): Accept an additional argument
247 DISP_PROP_P; callers changed. Scan at most 5K characters forward
248 for a display string or property. If found, set DISP_PROP_P
249 non-zero.
250
251 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
252 DISP_PROP_P, and pass it to compute_display_string_pos.
253 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
254 non-zero. All callers of bidi_fetch_char changed.
255
fb33fa43
SM
2562011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
259
b099e063
DM
2602010-12-03 Don March <don@ohspite.net>
261
262 * keymap.c (Fdefine_key): Fix non-prefix key error message when
263 last character M-[char] is translated to ESC [char] (bug#7541).
264
5cc7f7af
KH
2652011-08-02 Kenichi Handa <handa@m17n.org>
266
d0fffa3f 267 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
268
269 * chartab.c (uniprop_table): Make it non-static.
270
525d5e6e
EZ
2712011-08-01 Eli Zaretskii <eliz@gnu.org>
272
273 * xdisp.c (forward_to_next_line_start): Accept additional argument
274 BIDI_IT_PREV, and store into it the state of the bidi iterator had
275 on the newline.
276 (reseat_at_next_visible_line_start): Use the bidi iterator state
277 returned by forward_to_next_line_start to restore the state of
278 it->bidi_it after backing up to previous newline. (Bug#9212)
279
31011111
AS
2802011-07-30 Andreas Schwab <schwab@linux-m68k.org>
281
282 * regex.c (re_comp): Protoize.
283 (re_exec): Fix return type.
284 (regexec): Fix type of `ret'. (Bug#9203)
285
e5d76069
PE
2862011-07-29 Paul Eggert <eggert@cs.ucla.edu>
287
288 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
289 This is needed if max-image-size is a floating-point number.
290
9a79b20c
AS
2912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
292
293 * print.c (print_object): Print empty symbol as ##.
294
295 * lread.c (read1): Read ## as empty symbol.
296
d8c2fa78
AA
2972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
298
299 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
300 setting frame foreground color (Bug#9175).
301 (x_set_background_color): Likewise.
302
ffe57a7a
AA
303 * nsmenu.m (-setText): Size tooltip dimensions precisely to
304 contents (Bug#9176).
305 (EmacsTooltip -init): Remove bezels and add shadows to
306 tooltip windows.
307
bf3492a5
AA
308 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
309 or scroll bar (Bug#8470).
310
d55e9c53
AA
311 * nsfont.m (nsfont_open): Remove assignment to voffset and
312 unnecessary vars hshink, expand, hd, full_height, min_height.
313 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
314
315 * nsterm.h (nsfont_info): Remove voffset field.
316
d8c2fa78 3172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
318
319 Implement strike-through and overline on NextStep (Bug#8863).
320
321 * nsfont.m (nsfont_open): Use underline position provided by font,
322 instead of hard-coded value of 2.
323 (nsfont_draw): Call ns_draw_text_decoration instead.
324
325 * nsterm.h: Add declaration for ns_draw_text_decoration.
326
327 * nsterm.m (ns_draw_text_decoration): New function for drawing
328 underline, overline, and strike-through.
329 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
330 ns_draw_text_decoration. Change treatment of cursor drawing to
331 accomodate underlining, etc.
332
4cc60b9b
EZ
3332011-07-28 Eli Zaretskii <eliz@gnu.org>
334
bc7ece87
EZ
335 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
336 default.
4cc60b9b 337
476371c4
PE
3382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
339
66606eea
PE
340 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
341 Without this fix, if a signal arrives just after memory fills up,
342 'malloc' might be invoked reentrantly.
343
476371c4
PE
344 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
345 In other words, assume that every image size is allowed, on non-X
346 hosts. This assumption is probably wrong, but it lets Emacs compile.
347
f3fcc40d
AS
3482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
349
350 * regex.c (re_iswctype): Convert return values to boolean.
351
350c992f
EZ
3522011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
353
354 * xdisp.c (compute_display_string_pos): Don't use cached display
355 string position if the buffer had its restriction changed.
356 (Bug#9184)
357
5266b4bb
PE
3582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
359
360 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
361
2573a837 3622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 363
41f55ccd 364 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 365
39e378da
PE
366 * bidi.c: Integer size and overflow fixes.
367 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
368 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
369 (bidi_cache_find_level_change, bidi_cache_ensure_space)
370 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
371 (bidi_find_other_level_edge):
372 Use ptrdiff_t instead of EMACS_INT where either will do.
373 This works better on 32-bit hosts configured --with-wide-int.
374 (bidi_cache_ensure_space): Check for size-calculation overflow.
375 Use % rather than repeated addition, for better worst-case speed.
376 Don't set bidi_cache_size until after xrealloc returns, because it
377 might not return.
378 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
379 (bidi_cache_ensure_space): Also check that the bidi cache size
380 does not exceed that of the largest Lisp string or buffer. See Eli
381 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 382
5e927815
PE
383 * alloc.c (__malloc_size_t): Remove.
384 All uses replaced by size_t. See Andreas Schwab's note
385 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
386
ca4aa935
PE
387 * image.c: Improve checking for integer overflow.
388 (check_image_size): Assume that f is nonnull, since
389 it is always nonnull in practice. This is one less thing to
390 worry about when checking for integer overflow later.
391 (x_check_image_size): New function, which checks for integer
392 overflow issues inside X.
393 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
394 This removes the need for a memory_full check.
395 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
396 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
397 (xbm_read_bitmap_data): Change locals back to 'int', since
398 their values must fit in 'int'.
399 (xpm_load_image, png_load, tiff_load):
400 Invoke x_create_x_image_and_pixmap earlier,
401 to avoid much needless work if the image is too large.
402 (tiff_load): Treat overly large images as if
403 x_create_x_image_and_pixmap failed, not as malloc failures.
404 (gs_load): Use x_check_image_size.
405
5f8f9cc2
PE
406 * gtkutil.c: Omit integer casts.
407 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
408 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
409
5adf60bc
PE
410 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
411
c8907a93
PE
412 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
413 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
414 would wrongly return t on a 64-bit host.
415
e3c25c68
PE
416 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
417 The plain *_OVERFLOW macros run afoul of GCC bug 49705
418 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
419 and therefore cause GCC to emit a bogus diagnostic in some cases.
420
3f791afe
PE
421 * image.c: Integer signedness and overflow and related fixes.
422 This is not an exhaustive set of fixes, but it's time to
423 record what I've got.
424 (lookup_pixel_color, check_image_size): Remove redundant decls.
425 (check_image_size): Don't assume that arbitrary EMACS_INT values
426 fit in 'int', or that arbitrary 'double' values fit in 'int'.
427 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
428 (tiff_load, imagemagick_load_image):
429 Check for overflow in size calculations.
430 (x_create_x_image_and_pixmap): Remove unnecessary test for
431 xmalloc returning NULL; that can't happen.
432 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
433 (xpm_color_bucket): Use better integer hashing function.
434 (xpm_cache_color): Don't possibly over-allocate memory.
435 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
436 (gif_memory_source):
437 Use ptrdiff_t, not int or size_t, to record sizes.
438 (png_load): Don't assume values greater than 2**31 fit in 'int'.
439 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
440 either works, as we prefer signed integers.
441 (tiff_read_from_memory, tiff_write_from_memory):
442 Return tsize_t, not size_t, since that's what the TIFF API wants.
443 (tiff_read_from_memory): Don't fail simply because the read would
444 go past EOF; instead, return a short read.
445 (tiff_load): Omit no-longer-needed casts.
446 (Fimagemagick_types): Don't assume size fits into 'int'.
447
3cc5a532
PE
448 Improve hashing quality when configured --with-wide-int.
449 * fns.c (hash_string): New function, taken from sxhash_string.
450 Do not discard information about ASCII character case; this
451 discarding is no longer needed.
452 (sxhash-string): Use it. Change sig to match it. Caller changed.
453 * lisp.h: Declare it.
454 * lread.c (hash_string): Remove, since we now use fns.c's version.
455 The fns.c version returns a wider integer if --with-wide-int is
456 specified, so this should help the quality of the hashing a bit.
457
b312a492
PE
458 * emacs.c: Integer overflow minor fix.
459 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
460 Define only if GNU_LINUX.
461 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
462
dfd153ae
PE
463 * dispnew.c: Integer signedness and overflow fixes.
464 Remove unnecessary forward decls, that were a maintenance hassle.
465 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
466 All uses changed.
467 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
468 (scrolling_window): Use ptrdiff_t, not int, for byte count.
469 (prepare_desired_row, line_draw_cost):
470 Use int, not unsigned, where either works.
471 (save_current_matrix, restore_current_matrix):
472 Use ptrdiff_t, not size_t, where either works.
473 (init_display): Check for overflow more accurately, and without
474 relying on undefined behavior.
475
a81d11a3
PE
476 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
477 Remove, replacing with the new symbols in lisp.h. All uses changed.
478 * fileio.c (make_temp_name):
479 * filelock.c (lock_file_1, lock_file):
480 * xdisp.c (message_dolog):
481 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
482 Use pMd etc. instead.
483 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
484 replacing the pWIDE etc. symbols removed from editfns.c.
485
3300e6fd
PE
486 * keyboard.h (num_input_events): Now uintmax_t.
487 This is (very slightly) less likely to mess up due to wraparound.
488 All uses changed.
489
fd05c7e9
PE
490 * buffer.c: Integer signedness fixes.
491 (alloc_buffer_text, enlarge_buffer_text):
492 Use ptrdiff_t rather than size_t when either will do, as we prefer
493 signed integers.
494
903fe15d
PE
495 * alloc.c: Integer signedness and overflow fixes.
496 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
497 (__malloc_size_t): Default to size_t, not to int.
498 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
499 (Fgarbage_collect, mark_object_loop_halt, mark_object):
500 Prefer ptrdiff_t to size_t when either would do, as we prefer
501 signed integers.
502 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
503 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
504 Now const. Initialize with values that are in range even if char
505 is signed.
506 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
507 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
508 These functions do the right thing with sizes > 2**32.
509 (check_depth): Now ptrdiff_t, not int.
510 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
511 Adjust to new way of storing sizes. Check for size overflow bugs
512 in rest of code.
513 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
514 slightly wrong anyway, as it missed one instance of
515 XMALLOC_OVERRUN_CHECK_OVERHEAD.
516 (refill_memory_reserve): Omit needless cast to size_t.
517 (mark_object_loop_halt): Mark as externally visible.
518
ac82cc6a
PE
519 * xselect.c: Integer signedness and overflow fixes.
520 (Fx_register_dnd_atom, x_handle_dnd_message):
521 Use ptrdiff_t, not size_t, since we prefer signed.
522 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
523 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
524 x_dnd_atoms_size and x_dnd_atoms_length.
525
c2d1e36d
PE
526 * doprnt.c: Prefer signed to unsigned when either works.
527 * eval.c (verror):
528 * doprnt.c (doprnt):
529 * lisp.h (doprnt):
530 * xdisp.c (vmessage):
531 Use ptrdiff_t, not size_t, when using or implementing doprnt,
532 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
533 prefer signed arithmetic to avoid comparison confusion.
534 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
535 but is a bit tricky.
536
0e926e56
PE
537 Assume freestanding C89 headers, string.h, stdlib.h.
538 * data.c, doprnt.c, floatfns.c, print.c:
539 Include float.h unconditionally.
540 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
541 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
542 * regex.c: Likewise for stddef.h, string.h.
543 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
544 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
545 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
546 (STDC_HEADERS): Remove obsolete defines.
547 * sysdep.c: Include limits.h unconditionally.
548
9cfdb3ec
PE
549 Assume support for memcmp, memcpy, memmove, memset.
550 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
551 * regex.c (memcmp, memcpy):
552 Remove; we assume C89 now.
553
554 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
555 (__malloc_safe_bcopy): Remove; no longer needed.
556
cf950e6b 557 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
558 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
559 well either way, and we prefer signed to unsigned.
560
dbf38e02
LMI
5612011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
562
563 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
564 closes the connection while we're reading (bug#9182).
565
d6f0886c
JD
5662011-07-25 Jan Djärv <jan.h.d@swipnet.se>
567
568 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
569 are specified (Bug#9168).
570
2eb1f9e6
PE
5712011-07-25 Paul Eggert <eggert@cs.ucla.edu>
572
573 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
574 Found by GCC static checking and --with-wide-int on a 32-bit host.
575
22381272 5762011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
577
578 * xdisp.c (compute_display_string_pos): Fix logic of caching
579 previous display string position. Initialize cached_prev_pos to
580 -1. Fixes slow-down at the beginning of a buffer.
581
f25e39b4
EZ
5822011-07-24 Eli Zaretskii <eliz@gnu.org>
583
584 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
585 for attrs[LFACE_FONTSET_INDEX].
586
04c4b52e
PE
5872011-07-23 Paul Eggert <eggert@cs.ucla.edu>
588
589 * xml.c (parse_region): Remove unused local
590 that was recently introduced.
591
c1734fbd
EZ
5922011-07-23 Eli Zaretskii <eliz@gnu.org>
593
be18c5a5
EZ
594 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
595 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
596
c1734fbd
EZ
597 * xdisp.c (move_it_in_display_line_to): Record the best matching
598 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
599 exit if none of the characters scanned was an exact match.
600 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
601 when exact match is impossible due to invisible text, and the
602 lines are truncated.
603
a258d627
JD
6042011-07-23 Jan Djärv <jan.h.d@swipnet.se>
605
606 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
607 for OSX >= 10.7.
608
b6d5a689
EZ
6092011-07-22 Eli Zaretskii <eliz@gnu.org>
610
0f74f785
EZ
611 Fix a significant slow-down of cursor motion with C-n, C-p,
612 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
613 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 614 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
615 (next_element_from_buffer): Call compute_stop_pos_backwards to
616 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
617 base_level_stop.
618 (reseat): Don't look for prev_stop, as that could mean a very long
619 run.
620 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
621 <cached_disp_overlay_modiff>: Cache for last found display string
622 position.
551918c1 623 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
624 about the same buffer in the same area of character positions, and
625 the buffer wasn't changed since the time the display string
626 position was cached.
551918c1 627
b2d0c91a
EZ
6282011-07-22 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
631 is an integer, which is important for empty lines. (Bug#9149)
632
043604ee
CY
6332011-07-22 Chong Yidong <cyd@stupidchicken.com>
634
635 * frame.c (Fmodify_frame_parameters): In tty case, update the
636 default face if necessary (Bug#4238).
637
da4adb04
CY
6382011-07-21 Chong Yidong <cyd@stupidchicken.com>
639
640 * editfns.c (Fstring_to_char): No need to explain what a character
641 is in the docstring (Bug#6576).
642
9abd0532
LMI
6432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
644
645 * xml.c (parse_region): Make sure we always return a tree.
646
36881d16
HK
6472011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
648
649 * xml.c (parse_region): If a document contains only comments,
650 return that, too.
651
1e98674d
LMI
6522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
653
654 * xml.c (make_dom): Return comments, too.
655
590bd467
PE
6562011-07-19 Paul Eggert <eggert@cs.ucla.edu>
657
658 Port to OpenBSD.
659 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
660 and the surrounding thread.
661 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
662 rather than fgets, and retry after EINTR. Otherwise, 'emacs
663 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
664 timer goes off.
665 * s/openbsd.h (BROKEN_SIGIO): Define.
666 * unexelf.c (unexec) [__OpenBSD__]:
667 Don't update the .mdebug section of the Alpha COFF symbol table.
668
f41628b2
LMI
6692011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
670
671 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
672 (bug#8460).
673
b59b67c5
PE
6742011-07-18 Paul Eggert <eggert@cs.ucla.edu>
675
15e3a074
PE
676 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
677 This fixes some race conditions on the permissions of any newly
678 created file.
679
41bed37d
PE
680 * alloc.c (valid_pointer_p): Use pipe, not open.
681 This fixes some permissions issues when debugging.
682
b59b67c5
PE
683 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
684 If fchown fails to set both uid and gid, try to set just gid,
685 as that is sometimes allowed. Adjust the file's mode to eliminate
686 setuid or setgid bits that are inappropriate if fchown fails.
687
925a6be7
SM
6882011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
689
690 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
691 to compare Lisp_Objects.
692 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
693 global_gnutls_log_level, don't mistake it for a Lisp_Object.
694 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
695
52968808
AS
6962011-07-17 Andreas Schwab <schwab@linux-m68k.org>
697
0a6a104b
AS
698 * lread.c (read_integer): Unread even EOF character.
699 (read1): Likewise. Properly record start position of symbol.
700
52968808
AS
701 * lread.c (read1): Read `#:' as empty uninterned symbol if no
702 symbol character follows.
703
9e381cdd
PE
7042011-07-17 Paul Eggert <eggert@cs.ucla.edu>
705
706 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
707 This works around a problem with the previous change to Fcopy_file.
708 Recent glibc declares fchown with __attribute__((warn_unused_result)),
709 and without this change, GCC might complain about discarding
710 fchown's return value.
711
b5641435
JB
7122011-07-16 Juanma Barranquero <lekktu@gmail.com>
713
714 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
715
a8031457
PE
7162011-07-16 Paul Eggert <eggert@cs.ucla.edu>
717
718 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
719
dd889327
LMI
7202011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
721
750c33f7
LMI
722 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
723 it's used from the C level.
724
dd889327
LMI
725 * process.c: Use the same condition for POLL_FOR_INPUT in both
726 keyboard.c and process.c (bug#1858).
727
87e86684
LM
7282011-07-09 Lawrence Mitchell <wence@gmx.li>
729
730 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
731 (Fgnutls_boot): Use it.
732
64348f40
AS
7332011-07-15 Andreas Schwab <schwab@linux-m68k.org>
734
735 * doc.c (Fsubstitute_command_keys): Revert last change.
736
1d698799
LMI
7372011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
738
f863868c
LMI
739 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
740 quotes the next character, and doesn't affect other longer
741 sequences (bug#8935).
742
1d698799
LMI
743 * lread.c (syms_of_lread): Clarify that is isn't only
744 `eval-buffer' and `eval-defun' that's affected by
745 `lexical-binding' (bug#8460).
746
aa4b6df6
EZ
7472011-07-15 Eli Zaretskii <eliz@gnu.org>
748
749 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
750 bidi redisplay when a line includes both an image and is
751 truncated.
752
5d856da6
PE
7532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
754
ad6042bb
PE
755 Fix minor problems found by static checking.
756 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
757 (elsz): Now a signed constant, not a size_t var. We prefer signed
758 types to unsigned, to avoid integer comparison confusion. Without
759 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
760 "cannot optimize loop, the loop counter may overflow", a symptom
761 of the confusion.
f00bbb22 762 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
763 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
764
6468f31c
LMI
7652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
766
49080b10
LMI
767 * search.c (Fre_search_backward): Mention `case-fold-search' in
768 all the re_search_* functions (bug#8138).
769
6468f31c
LMI
770 * keyboard.c (Fopen_dribble_file): Document when the file is
771 closed (bug#8056).
772
c965adc5
EZ
7732011-07-14 Eli Zaretskii <eliz@gnu.org>
774
df9733bf
EZ
775 * bidi.c (bidi_dump_cached_states): Fix format of displaying
776 bidi_cache_idx.
777
0bb23927
EZ
778 Support bidi reordering of display and overlay strings.
779 * xdisp.c (compute_display_string_pos)
780 (compute_display_string_end): Accept additional argument STRING.
781 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
782 (reseat_to_string): Initialize bidi_it->string.s and
783 bidi_it->string.schars.
784 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
785 NULL (avoids a crash in bidi_paragraph_init).
786 Initialize itb.string.lstring.
0bb23927
EZ
787 (init_iterator): Call bidi_init_it only of a valid
788 buffer position was specified. Initialize paragraph_embedding to
789 L2R.
790 (reseat_to_string): Initialize the bidi iterator.
791 (display_string): If we need to ignore text properties of
792 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
793 original value of -1 will not work with bidi.)
794 (compute_display_string_pos): First arg is now struct
795 `text_pos *'; all callers changed. Support display properties on
796 Lisp strings.
797 (compute_display_string_end): Support display properties on Lisp
798 strings.
799 (init_iterator, reseat_1, reseat_to_string): Initialize the
800 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
801 when iterating on a string not from display properties).
640c8776
SM
802 (compute_display_string_pos, compute_display_string_end):
803 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
804 arrow keys.
805 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
806 base_level_stop; instead, set base_level_stop to BEGV.
807 Fixes crashes in vertical-motion.
0bb23927
EZ
808 (next_element_from_buffer): Improve commentary for when
809 the iterator is before prev_stop.
810 (init_iterator): Initialize bidi_p from the default value of
811 bidi-display-reordering, not from buffer-local value. Use the
812 buffer-local value only if initializing for buffer iteration.
813 (handle_invisible_prop): Support invisible properties on strings
814 that are being bidi-reordered.
815 (set_iterator_to_next): Support bidi reordering of C strings and
816 Lisp strings.
817 (next_element_from_string): Support bidi reordering of Lisp
818 strings.
819 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
820 (display_string): Support display of R2L glyph rows.
821 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
822 (init_iterator): Don't initialize it->bidi_p for strings
823 here.
824 (reseat_to_string): Initialize it->bidi_p for strings here.
825 (next_element_from_string, next_element_from_c_string)
826 (next_element_from_buffer): Add xassert's for correspondence
827 between IT's object being iterated and it->bidi_it.string
828 structure.
829 (face_before_or_after_it_pos): Support bidi iteration.
830 (next_element_from_c_string): Handle the case of the first string
831 character that is not the first one in the visual order.
832 (get_visually_first_element): New function, refactored from common
833 parts of next_element_from_buffer, next_element_from_string, and
834 next_element_from_c_string.
835 (tool_bar_lines_needed, redisplay_tool_bar)
836 (display_menu_bar): Force left-to-right direction. Add a FIXME
837 comment for making that be controlled by a user option.
838 (push_it, pop_it): Save and restore the state of the
839 bidi iterator. Save and restore the bidi_p flag.
840 (pop_it): Iterate out of display property for string iteration as
841 well.
842 (iterate_out_of_display_property): Support iteration over strings.
843 (handle_single_display_spec): Set up it->bidi_it for iteration
844 over a display string, and call bidi_init_it.
845 (handle_single_display_spec, next_overlay_string)
846 (get_overlay_strings_1, push_display_prop): Set up the bidi
847 iterator for displaying display or overlay strings.
848 (forward_to_next_line_start): Don't use the shortcut if
849 bidi-iterating.
850 (back_to_previous_visible_line_start): If handle_display_prop
851 pushed the iterator stack, restore the internal state of the bidi
852 iterator by calling bidi_pop_it same number of times.
853 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
854 and we are bidi-iterating, don't decrement the iterator position;
855 instead, set the first_elt flag in the bidi iterator, to produce
856 the same effect.
857 (reseat_1): Remove redundant setting of string_from_display_prop_p.
858 (push_display_prop): xassert that we are iterating a buffer.
859 (push_it, pop_it): Save and restore paragraph_embedding member.
860 (handle_single_display_spec, next_overlay_string)
861 (get_overlay_strings_1, reseat_1, reseat_to_string)
862 (push_display_prop): Set up the `unibyte' member of bidi_it.string
863 correctly. Don't assume unibyte strings are not bidi-reordered.
864 (compute_display_string_pos)
865 (compute_display_string_end): Fix handling the case of C string.
866 (push_it, pop_it): Save and restore from_disp_prop_p.
867 (handle_single_display_spec, push_display_prop): Set the
868 from_disp_prop_p flag.
869 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
870 (pop_it): Call iterate_out_of_display_property only if we are
871 popping after iteration over a string that came from a display
872 property. Fix a typo in popping stretch info. Add an assertion
873 for verifying that the iterator position is in sync with the bidi
874 iterator.
875 (handle_single_display_spec, get_overlay_strings_1)
876 (push_display_prop): Fix initialization of paragraph direction for
877 string when that of the parent object is not yet determined.
878 (reseat_1): Call bidi_init_it to resync the bidi
879 iterator with IT's position. (Bug#7616)
880 (find_row_edges): If ROW->start.pos gives position
881 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
882 (handle_stop, back_to_previous_visible_line_start, reseat_1):
883 Reset the from_disp_prop_p flag.
884 (SAVE_IT, RESTORE_IT): New macros.
885 (pos_visible_p, face_before_or_after_it_pos)
886 (back_to_previous_visible_line_start)
887 (move_it_in_display_line_to, move_it_in_display_line)
888 (move_it_to, move_it_vertically_backward, move_it_by_lines)
889 (try_scrolling, redisplay_window, display_line): Use them when
890 saving a temporary copy of the iterator and restoring it back.
891 (back_to_previous_visible_line_start, reseat_1)
892 (init_iterator): Empty the bidi cache "stack".
893 (move_it_in_display_line_to): If iterator ended up at
894 EOL, but we never saw any buffer positions smaller than
895 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
896 motion in bidi-reordered lines.
897 (move_it_in_display_line_to): Record prev_method and prev_pos
898 immediately before the call to set_iterator_to_next. Fixes cursor
899 motion in bidi-reordered lines with stretch glyphs and strings
900 displayed in margins. (Bug#8133) (Bug#8867)
901 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
902 TO_CHARPOS.
640c8776
SM
903 (pos_visible_p): Support positions in bidi-reordered lines.
904 Save and restore bidi cache.
0bb23927
EZ
905
906 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
907 (bidi_paragraph_info): Delete unused struct.
908 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
909 (bidi_cache_start): New variable.
910 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
911 to zero.
912 (bidi_cache_fetch_state, bidi_cache_search)
913 (bidi_cache_find_level_change, bidi_cache_iterator_state)
914 (bidi_cache_find, bidi_peek_at_next_level)
915 (bidi_level_of_next_char, bidi_find_other_level_edge)
916 (bidi_move_to_visually_next): Compare cache index with
917 bidi_cache_start rather than with zero.
918 (bidi_fetch_char): Accept new argument STRING; all callers
919 changed. Support iteration over a string. Support strings with
920 display properties. Support unibyte strings. Fix the type of
921 `len' according to what STRING_CHAR_AND_LENGTH expects.
922 (bidi_paragraph_init, bidi_resolve_explicit_1)
923 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
924 (bidi_level_of_next_char, bidi_move_to_visually_next):
925 Support iteration over a string.
0bb23927
EZ
926 (bidi_set_sor_type, bidi_resolve_explicit_1)
927 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
928 can now be zero (for strings); special values 0 and -1 were
929 changed to -1 and -2, respectively.
930 (bidi_char_at_pos): New function.
931 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
932 Call it instead of FETCH_MULTIBYTE_CHAR.
933 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
934 initialized to valid values.
935 (bidi_init_it): Don't initialize charpos and bytepos with invalid
936 values.
937 (bidi_level_of_next_char): Allow the sentinel "position" to pass
938 the test for valid cached positions. Fix the logic for looking up
939 the sentinel state in the cache. GCPRO the Lisp string we are
940 iterating.
941 (bidi_push_it, bidi_pop_it): New functions.
942 (bidi_initialize): Initialize the bidi cache start stack pointer.
943 (bidi_cache_ensure_space): New function, refactored from part of
944 bidi_cache_iterator_state. Don't assume the required size is just
945 one BIDI_CACHE_CHUNK away.
946 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
947 (bidi_count_bytes, bidi_char_at_pos): New functions.
948 (bidi_cache_search): Don't assume bidi_cache_last_idx is
949 always valid if bidi_cache_idx is valid.
950 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
951 is valid if it's going to be used.
952 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
953 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
954 (bidi_cache_find_level_change, bidi_cache_ensure_space)
955 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
956 (bidi_find_other_level_edge, bidi_cache_start_stack):
957 All variables related to cache indices are now EMACS_INT.
c965adc5 958
0bb23927
EZ
959 * dispextern.h (struct bidi_string_data): New structure.
960 (struct bidi_it): New member `string'. Make flag members be 1-bit
961 fields, and put them last in the struct.
640c8776
SM
962 (compute_display_string_pos, compute_display_string_end):
963 Update prototypes.
0bb23927
EZ
964 (bidi_push_it, bidi_pop_it): Add prototypes.
965 (struct iterator_stack_entry): New members bidi_p,
966 paragraph_embedding, and from_disp_prop_p.
967 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
968 (bidi_shelve_cache, bidi_unshelve_cache):
969 Declare prototypes.
0bb23927
EZ
970
971 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
972 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
973 and vector-like objects.
974
975 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
976 cache around display iteration.
977
978 * window.c (Fwindow_end, window_scroll_pixel_based)
979 (displayed_window_lines, Frecenter): Save and restore the bidi
980 cache around display iteration.
981
3bbd2265
LMI
9822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
983
984 * editfns.c (Fdelete_region): Clarify the use of the named
985 parameters (bug#6788).
986
adc47434
MR
9872011-07-14 Martin Rudalics <rudalics@gmx.at>
988
989 * indent.c (Fvertical_motion): Set and restore w->pointm when
990 saving and restoring the window's buffer (Bug#9006).
991
837c31f8
LMI
9922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
993
994 * editfns.c (Fstring_to_char): Clarify just what is returned
995 (bug#6576). Text by Eli Zaretskii.
996
ac389d0c
JB
9972011-07-13 Juanma Barranquero <lekktu@gmail.com>
998
999 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1000
0be0ce47
EZ
10012011-07-13 Eli Zaretskii <eliz@gnu.org>
1002
1003 * buffer.c (mmap_find): Fix a typo.
1004
cd18e7e3
JB
10052011-07-13 Johan Bockgård <bojohan@gnu.org>
1006
1007 Fix execution of x selection hooks.
1008 * xselect.c (Qx_lost_selection_functions)
1009 (Qx_sent_selection_functions): New vars.
1010 (syms_of_xselect): DEFSYM them.
1011 (x_handle_selection_request): Pass Qx_sent_selection_functions
1012 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1013 (x_handle_selection_clear,x_clear_frame_selections):
1014 Pass Qx_lost_selection_functions rather than
1015 Vx_lost_selection_functions to Frun_hook_with_args.
1016
47ea7f44
PE
10172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1018
ac389d0c 1019 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1020 The old code sometimes used this field without initializing it.
1021
47ea7f44
PE
1022 * alloc.c (gc_sweep): Don't read past end of array.
1023 In theory, the old code could also have corrupted Emacs internals,
1024 though it'd be very unlikely.
1025
bc985c87
AS
10262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1029 argument. (Bug#4026)
bc985c87 1030
0cf34688
LMI
10312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1032
b3dadd76
LMI
1033 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1034 key" (bug#4257).
1035
0cf34688
LMI
1036 * window.c (Fset_window_start): Doc fix (bug#4199).
1037 (Fset_window_hscroll): Ditto.
1038
270768cd
PE
10392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1040
077e3dda 1041 Fix minor new problems caught by GCC 4.6.1.
270768cd 1042 * term.c (init_tty): Remove unused local.
490011a6 1043 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1044 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1045 not used otherwise.
270768cd 1046
b1f58454
CY
10472011-07-12 Chong Yidong <cyd@stupidchicken.com>
1048
1049 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1050
22b9578d
LMI
10512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1052
6e70ab07
LMI
1053 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1054 are the mini-buffer and the echo area (bug#3320).
1055
22b9578d
LMI
1056 * term.c (init_tty): Remove support for supdup, c10 and perq
1057 terminals, which are no longer supported (bug#1482).
1058
8974cc9f
JB
10592011-07-10 Johan Bockgård <bojohan@gnu.org>
1060
1061 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1062
a560d974
JD
10632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1064
1065 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1066 for non-popups (Bug#3642).
1067
1dae0f0a
AS
10682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1069
268c2c36 1070 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1071 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1072 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1073 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1074 * data.c (fmod): Likewise.
1075 * dispnew.c (swap_glyphs_in_rows): Likewise.
1076 * emacs.c (memory_warning_signal): Likewise.
1077 * floatfns.c (float_error): Likewise.
1078 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1079 (otf_open, font_otf_capability, generate_otf_features)
1080 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1081 Likewise.
1082 * image.c (pbm_read_file): Likewise.
1083 * indent.c (string_display_width): Likewise.
1084 * intervals.c (check_for_interval, search_for_interval)
1085 (inc_interval_count, count_intervals, root_interval)
1086 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1087 * lread.c (defalias): Likewise.
268c2c36 1088 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1089 * regex.c (set_image_of_range_1, set_image_of_range)
1090 (regex_grow_registers): Likewise.
1091 * sysdep.c (strerror): Likewise.
1092 * termcap.c (valid_filename_p, tprint, main): Likewise.
1093 * tparam.c (main): Likewise.
1094 * unexhp9k800.c (run_time_remap, save_data_space)
1095 (update_file_ptrs, read_header, write_header, calculate_checksum)
1096 (copy_file, copy_rest, display_header): Likewise.
1097 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1098 Likewise.
1099 * xdisp.c (check_it): Likewise.
1100 * xfaces.c (register_color, unregister_color, unregister_colors):
1101 Likewise.
1102 * xfns.c (print_fontset_result): Likewise.
1103 * xrdb.c (member, fatal, main): Likewise.
1104
99033785
PE
11052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1106
1107 Fix minor problems found by static checking (Bug#9031).
1108 * chartab.c (char_table_set_range, map_sub_char_table):
1109 Remove unused locals.
1110 (uniprop_table): Now static.
1111 * composite.c (_work_char): Remove unused static var.
1112
9cb2ac56
JB
11132011-07-09 Juanma Barranquero <lekktu@gmail.com>
1114
1115 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1116
f25661f0
JD
11172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1118
1119 * gtkutil.c (qttip_cb): Remove code without function.
1120
8278c4fe
EZ
11212011-07-09 Eli Zaretskii <eliz@gnu.org>
1122
1123 * w32.c (pthread_sigmask): New stub.
1124
1692ae2d 11252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1126
8a6ebd58 1127 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1128 sigprocmask is portable only for single-threaded applications, and
1129 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1130 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1131 (LIBES): Use it.
1132 * callproc.c (Fcall_process):
1133 * process.c (create_process):
1134 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1135 Use pthread_sigmask, not sigprocmask.
123403e4 1136
1b854618
JD
11372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1138
1139 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1140 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1141 wrong (Bug#8591).
1142
3fe4b549
JD
11432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1144
0ce7e563
JD
1145 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1146 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1147 (xg_hide_tooltip): Fix comment.
1148
3fe4b549
JD
1149 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1150 in registerServicesMenuSendTypes.
1151 (validRequestorForSendType): Don't check ns_return_types.
1152
1153 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1154 ns_return_type.
1155
5df75e47
JR
11562011-07-08 Jason Rumney <jasonr@gnu.org>
1157
1158 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1159 frame struct members of non-existent frames (Bug#6284).
1160
699c10bd
JD
11612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1162
4393663b
JD
1163 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1164 variable firstTime not needed on OSX >= 10.6.
1165 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1166 >= 10.5. Use setKnobProportion, setDoubleValue.
1167
1168 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1169 (MAC_OS_X_VERSION_10_5): Define if not defined.
1170 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1171 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1172 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1173
1174 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1175 cString and lossyCString on OSX >= 10.4
1176
1177 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1178 sizeToFit on OSX >= 10.2.
1179
1180 * nsimage.m (allocInitFromFile): Don't use deprecated method
1181 bestRepresentationForDevice on OSX >= 10.6.
1182
1183 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1184 to avoid warning.
1185
1186 * emacs.c: Declare unexec_init_emacs_zone.
1187
a63e0781
JD
1188 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1189
699c10bd
JD
1190 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1191
1192 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1193 on svcsMenu (Bug#8842).
1194
1195 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1196 ns_return_types.
1197 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1198
1199 * nsterm.m (QUTF8_STRING): Declare.
1200 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1201 (validRequestorForSendType): Return type is (id).
1202 Change indexOfObjectIdenticalTo to indexOfObject.
1203 Check if we have local selection before returning self (Bug#8842).
1204 (writeSelectionToPasteboard): Put local selection into paste board
1205 if we have a local selection (Bug#8842).
1206 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1207
1208 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1209 (ns_get_local_selection): Declare.
1210
54e10184
LMI
12112011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1212
9888ff71
LMI
1213 * keymap.c (describe_map_tree): Don't insert a double newline at
1214 the end of the buffer (bug#1169) and return whether we inserted
1215 something.
1216
54e10184
LMI
1217 * callint.c (Fcall_interactively): Change "reading args" to
1218 "providing args" to try to clarify what it does (bug#1010).
1219
15fa4783
KH
12202011-07-07 Kenichi Handa <handa@m17n.org>
1221
1222 * composite.c (composition_compute_stop_pos): Ignore a static
1223 composition starting before CHARPOS (Bug#8915).
1224
1225 * xdisp.c (handle_composition_prop): Likewise.
1226
a8815b00
EZ
12272011-07-07 Eli Zaretskii <eliz@gnu.org>
1228
1229 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1230 (Bug#9015)
1231
ef7b981d 12322011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1233
1234 * character.h (unicode_category_t): New enum type.
1235
1236 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1237 (Qchar_code_property_table): New variable.
1238 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1239 (UNIPROP_COMPRESSED_FORM_P): New macros.
1240 (char_table_ascii): Uncompress the compressed values.
1241 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1242 Uncompress the compressed values.
ac389d0c 1243 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1244 (char_table_ref_and_range): Uncompress the compressed values.
1245 (sub_char_table_set): New arg is_uniprop. Callers changed.
1246 Uncompress the compressed values.
1247 (sub_char_table_set_range): Args changed. Callers changed.
1248 (char_table_set_range): Adjuted for the above change.
1249 (map_sub_char_table): Delete args default_val and parent. Add arg
1250 top. Give decoded values to a Lisp function.
640c8776 1251 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1252 values to a Lisp function. Gcpro more variables.
1253 (uniprop_table_uncompress)
1254 (uniprop_decode_value_run_length): New functions.
1255 (uniprop_decoder, uniprop_decoder_count): New variables.
1256 (uniprop_get_decoder, uniprop_encode_value_character)
1257 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1258 New functions.
1259 (uniprop_encoder, uniprop_encoder_count): New variables.
1260 (uniprop_get_encoder, uniprop_table)
1261 (Funicode_property_table_internal, Fget_unicode_property_internal)
1262 (Fput_unicode_property_internal): New functions.
1263 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1264 Sunicode_property_table_internal, Sget_unicode_property_internal,
1265 and Sput_unicode_property_internal. Defvar_lisp
1266 char-code-property-alist.
1267
640c8776 1268 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1269 Vunicode_category_table.
1270
640c8776 1271 * font.c (font_range): Adjust for the change of
c805dec0
KH
1272 Vunicode_category_table.
1273
76b397fb
DN
12742011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1275
1276 * m/iris4d.h: Remove file, move contents ...
1277 * s/irix6-5.h: ... here.
1278
22b4128e
PE
12792011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1282 * alloc.c (mark_buffer):
1283 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1284 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1285 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1286 This isn't true in general, and it's particularly not true
1287 if Emacs is configured with --with-wide-int.
1288 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1289 New macros, used in the buffer.c change.
1290
869795d6
JD
12912011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1292
1293 * xsettings.c: Use both GConf and GSettings if both are available.
1294 (store_config_changed_event): Add comment.
1295 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1296 (store_tool_bar_style_changed): New functions.
1297 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1298 (struct xsettings): Move font inside HAVE_XFT.
1299 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1300 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1301 Move inside HAVE_XFT.
640c8776 1302 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1303 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1304 also.
1305 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1306 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1307 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1308 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1309 (parse_settings): Move check for font inside HAVE_XFT.
1310 (read_settings, apply_xft_settings): Add comment.
1311 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1312 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1313 call store_font_name_changed.
1314 (xft_settings_event): Add comment.
1315 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1316 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1317 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1318 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1319 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1320 (xsettings_get_system_font, xsettings_get_system_normal_font):
1321 Add comment.
869795d6 1322
d8ed26bd
PE
13232011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Random fixes. E.g., (random) never returned negative values.
1326 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1327 subseconds part to the entropy, as that's a bit more random.
1328 Prefer signed to unsigned, since the signedness doesn't matter and
1329 in general we prefer signed. When given a limit, use a
1330 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1331 latter isn't right if USE_2_TAGS_FOR_INTS.
1332 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1333 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1334
cabf1cac
SM
13352011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1336
1337 * textprop.c (text_property_stickiness):
1338 Obey Vtext_property_default_nonsticky.
1339 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1340 * w32fns.c (syms_of_w32fns):
1341 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1342
6e9b2be9
PE
13432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1346 This is more efficient than Ffile_directory_p and avoids a minor race.
1347
90186c68
LMI
13482011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1349
7c301272
LMI
1350 * buffer.c (Foverlay_put): Say what the return value is
1351 (bug#7835).
1352
c4f2d8d4
LMI
1353 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1354 is a directory before asking whether to use the file name
1355 (bug#7564).
ad637907
LMI
1356 (barf_or_query_if_file_exists): Make the "File is a directory"
1357 error be more correct.
c4f2d8d4 1358
90186c68
LMI
1359 * fns.c (Frequire): Remove the mention of the .gz files, since
1360 that's installation-specific, but keep the mention of
1361 `get-load-suffixes'.
1362
da64016e
PE
13632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1366 Report string overflow if the output is too long.
1367
7d47b580
JB
13682011-07-04 Juanma Barranquero <lekktu@gmail.com>
1369
a555cb87
JB
1370 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1371 (syms_of_gnutls): Remove duplicate DEFSYM for
1372 Qgnutls_bootprop_verify_hostname_error, an error for
1373 Qgnutls_bootprop_verify_error (which is no longer used).
1374
7d47b580
JB
1375 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1376 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1377 Also (re)move comments that are misplaced or no longer relevant.
1378
1e49bfab
LMI
13792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1380
1381 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1382
1485f4c0
CY
13832011-07-03 Chong Yidong <cyd@stupidchicken.com>
1384
1385 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1386 and background color parameters if they have been changed.
1387
a9ab721e
LMI
13882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1389
1390 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1391
cf7cff57
PE
13922011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1393
2e13213d
PE
1394 * xsettings.c (SYSTEM_FONT): Define only when used.
1395 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1396
cf7cff57
PE
1397 * keymap.c (access_keymap_1): Now static.
1398
7a8e04f7
CY
13992011-07-02 Chong Yidong <cyd@stupidchicken.com>
1400
1401 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1402 leave any prefix arg for the up event (Bug#1586).
1403
61352f62
LMI
14042011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1405
69bb1ef7
LMI
1406 * lread.c (syms_of_lread): Mention single symbols defined by
1407 `defvar' or `defconst' (bug#7154).
1408
61352f62 1409 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1410 (Frequire): Mention get-load-suffixes.
61352f62 1411
28545e04
MR
14122011-07-02 Martin Rudalics <rudalics@gmx.at>
1413
1414 * window.h (window): Remove clone_number slot.
1415 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1416 Remove.
1417 (make_parent_window, make_window, saved_window)
1418 (Fset_window_configuration, save_window_save): Don't deal with
1419 clone numbers.
1420 * buffer.c (Qclone_number): Remove declaration.
1421 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1422
3349e122
SM
14232011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1424
1425 Add multiple inheritance to keymaps.
1426 * keymap.c (Fmake_composed_keymap): New function.
1427 (Fset_keymap_parent): Simplify.
1428 (fix_submap_inheritance): Remove.
1429 (access_keymap_1): New function extracted from access_keymap to handle
1430 embedded parents and handle lists of maps.
1431 (access_keymap): Use it.
1432 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1433 (Fcopy_keymap): Handle embedded parents.
1434 (Fcommand_remapping, define_as_prefix): Simplify.
1435 (Fkey_binding): Simplify.
1436 (syms_of_keymap): Move minibuffer-local-completion-map,
1437 minibuffer-local-filename-completion-map,
1438 minibuffer-local-must-match-map, and
1439 minibuffer-local-filename-must-match-map to Elisp.
1440 (syms_of_keymap): Defsubr make-composed-keymap.
1441 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1442 (parse_menu_item): Trivial simplification.
1443
3279eb87
GM
14442011-07-01 Glenn Morris <rgm@gnu.org>
1445
1446 * Makefile.in (SETTINGS_LIBS): Fix typo.
1447
4550efdf
KI
14482011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1449
1450 * coding.c (Fencode_coding_string): Record the last coding system
1451 used, as the function doc string says (bug#8738).
1452
0949d2b6
JD
14532011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1454
1455 * xsettings.c (store_monospaced_changed): Take new font as arg and
1456 check for change against current_mono_font.
1457 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1458 (emacs_settings_constructor, emacs_settings_get_property)
1459 (emacs_settings_set_property, emacs_settings_class_init)
1460 (emacs_settings_init, gsettings_obj): Remove.
1461 (something_changedCB): New function for HAVE_GSETTINGS.
1462 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1463 with value as argument.
1464 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1465 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1466 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1467 "changed".
1468
1469 * xgselect.c: Add defined (HAVE_GSETTINGS).
1470 (xgselect_initialize): Ditto.
1471
1472 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1473 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1474 xg_select.
1475
bbc6b304
PE
14762011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1477
1478 * eval.c (struct backtrace): Simplify and port the data structure.
1479 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1480 signed bit field, as this assumption is not portable and it makes
1481 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1482 "char debug_on_exit : 1" as this is not portable either; instead,
1483 use the portable "unsigned int debug_on_exit : 1". Remove unused
1484 member evalargs. Remove obsolete comments about cc bombing out.
1485
9851bfc5
JD
14862011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1487
51bb811f 1488 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1489 Let HAVE_GSETTINGS override HAVE_GCONF.
1490 (store_monospaced_changed): New function.
1491 (EMACS_SETTINGS): A new type derived from GObject to handle
1492 GSettings notifications.
1493 (emacs_settings_constructor, emacs_settings_get_property)
1494 (emacs_settings_set_property, emacs_settings_class_init):
1495 New functions.
1496 (gsettings_client, gsettings_obj): New variables.
1497 (GSETTINGS_SCHEMA): New define.
1498 (something_changedCB): Call store_monospaced_changed.
1499 (init_gsettings): New function.
1500 (xsettings_initialize): Call init_gsettings.
1501 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1502 to NULL.
1503
640c8776 1504 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1505 GCONF_CFLAGS/LIBS.
1506
5386012d
MR
15072011-06-29 Martin Rudalics <rudalics@gmx.at>
1508
1509 * window.c (resize_root_window, grow_mini_window)
1510 (shrink_mini_window): Rename Qresize_root_window to
1511 Qwindow_resize_root_window and Qresize_root_window_vertically to
1512 Qwindow_resize_root_window_vertically.
1513
f13e0b08
PE
15142011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1517
94515237
JB
15182011-06-27 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * makefile.w32-in: Redesign dependencies so they reflect more
1521 clearly which files are directly included by each source file,
1522 and not through other includes.
1523
e43b6e43
MR
15242011-06-27 Martin Rudalics <rudalics@gmx.at>
1525
1526 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1527 (sort_overlays, overlay_strings): When an overlay's clone number
1528 matches the window's clone number process the overlay even if
1529 the overlay's window property doesn't match the current window.
1530
d68443dc
MR
1531 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1532 (Fwindow_hchild): Rename to Fwindow_left_child.
1533 (Fwindow_next): Rename to Fwindow_next_sibling.
1534 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1535 (resize_window_check): Rename to window_resize_check.
1536 (resize_window_apply): Rename to window_resize_apply.
1537 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1538 (Fdelete_other_windows_internal, resize_frame_windows)
1539 (Fsplit_window_internal, Fdelete_window_internal)
1540 (grow_mini_window, shrink_mini_window)
1541 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1542
c7e73be5
JD
15432011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1544
1545 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1546 (emacs_fixed_set_min_size): Remove.
1547 (emacs_fixed_new): Take frame as argument.
1548
1549 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1550 (_EmacsFixedPrivate): Remove minwidth/height.
1551 Add struct frame *f.
1552 (emacs_fixed_init): Initialize priv->f.
1553 (get_parent_class, emacs_fixed_set_min_size): Remove.
1554 (emacs_fixed_new): Set priv->f to argument.
1555 (emacs_fixed_get_preferred_width)
1556 (emacs_fixed_get_preferred_height): Use min_width/height from
1557 frames size_hint to set minimum and natural (Bug#8919).
1558 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1559 and use min_width/height from frames size_hint to set
1560 min_width/height (Bug#8919).
1561
1562 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1563 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1564 Fix indentation.
c7e73be5 1565
cf99dcf8
EZ
15662011-06-26 Eli Zaretskii <eliz@gnu.org>
1567
1568 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1569 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1570 called at ZV.
1571
029529ac
CY
15722011-06-26 Chong Yidong <cyd@stupidchicken.com>
1573
1574 * process.c (wait_reading_process_output): Bypass select if
1575 waiting for a cell while ignoring keyboard input, and input is
1576 pending. Suggested by Jan Djärv (Bug#8869).
1577
7a7ef429
PE
15782011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 Use gnulib's dup2 module instead of rolling our own.
1581 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1582
11fdef7d 15832011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1584
1585 * dispnew.c (scrolling_window): Before scrolling, turn off a
1586 mouse-highlight in the window being scrolled.
1587
cd3520a4
JB
15882011-06-24 Juanma Barranquero <lekktu@gmail.com>
1589
1590 Move DEFSYM to lisp.h and use everywhere.
1591
1592 * character.h (DEFSYM): Move declaration...
1593 * lisp.h (DEFSYM): ...here.
1594
1595 * gnutls.c:
1596 * minibuf.c:
1597 * w32menu.c:
1598 * w32proc.c:
1599 * w32select.c: Don't include character.h.
1600
1601 * alloc.c (syms_of_alloc):
1602 * buffer.c (syms_of_buffer):
1603 * bytecode.c (syms_of_bytecode):
1604 * callint.c (syms_of_callint):
1605 * casefiddle.c (syms_of_casefiddle):
1606 * casetab.c (init_casetab_once):
1607 * category.c (init_category_once, syms_of_category):
1608 * ccl.c (syms_of_ccl):
1609 * cmds.c (syms_of_cmds):
1610 * composite.c (syms_of_composite):
1611 * dbusbind.c (syms_of_dbusbind):
1612 * dired.c (syms_of_dired):
1613 * dispnew.c (syms_of_display):
1614 * doc.c (syms_of_doc):
1615 * editfns.c (syms_of_editfns):
1616 * emacs.c (syms_of_emacs):
1617 * eval.c (syms_of_eval):
1618 * fileio.c (syms_of_fileio):
1619 * fns.c (syms_of_fns):
1620 * frame.c (syms_of_frame):
1621 * fringe.c (syms_of_fringe):
1622 * insdel.c (syms_of_insdel):
1623 * keymap.c (syms_of_keymap):
1624 * lread.c (init_obarray, syms_of_lread):
1625 * macros.c (syms_of_macros):
1626 * msdos.c (syms_of_msdos):
1627 * print.c (syms_of_print):
1628 * process.c (syms_of_process):
1629 * search.c (syms_of_search):
1630 * sound.c (syms_of_sound):
1631 * syntax.c (init_syntax_once, syms_of_syntax):
1632 * terminal.c (syms_of_terminal):
1633 * textprop.c (syms_of_textprop):
1634 * undo.c (syms_of_undo):
1635 * w32.c (globals_of_w32):
1636 * window.c (syms_of_window):
1637 * xdisp.c (syms_of_xdisp):
1638 * xfaces.c (syms_of_xfaces):
1639 * xfns.c (syms_of_xfns):
1640 * xmenu.c (syms_of_xmenu):
1641 * xsettings.c (syms_of_xsettings):
1642 * xterm.c (syms_of_xterm): Use DEFSYM.
1643
4228cf16
TZ
16442011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1645
cd3520a4 1646 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1647
7fcccf1e
PE
16482011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1649
7efb4e0e
PE
1650 Integer and buffer overflow fixes (Bug#8873).
1651
ff5844ad
PE
1652 * print.c (printchar, strout): Check for string overflow.
1653 (PRINTPREPARE, printchar, strout):
1654 Don't set size unless allocation succeeds.
1655
90532f02
PE
1656 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1657 for sizes. Check for string overflow more accurately.
1658 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1659
6d84508d
PE
1660 * macros.c: Integer and buffer overflow fixes.
1661 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1662 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1663 Use ptrdiff_t, not int, for sizes.
1664 Don't increment bufsize until after realloc succeeds.
1665 Check for size-calculation overflow.
1666 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1667
437b2cb4
PE
1668 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1669
8b9ac8b4
PE
1670 * lread.c: Integer overflow fixes.
1671 (read_integer): Radix is now EMACS_INT, not int,
1672 to improve quality of diagnostics for out-of-range radices.
1673 Calculate buffer size correctly for out-of-range radices.
1674 (read1): Check for integer overflow in radices, and in
1675 read-circle numbers.
82cb60d3
PE
1676 (read_escape): Avoid int overflow.
1677 (Fload, openp, read_buffer_size, read1)
1678 (substitute_object_recurse, read_vector, read_list, map_obarray):
1679 Use ptrdiff_t, not int, for sizes.
1680 (read1): Use EMACS_INT, not int, for sizes.
20270765 1681 Check for size overflow.
8b9ac8b4 1682
7fcccf1e
PE
1683 * image.c (cache_image): Check for size arithmetic overflow.
1684
bfbbd7e7
PE
1685 * lread.c: Integer overflow issues.
1686 (saved_doc_string_size, saved_doc_string_length)
1687 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1688 Now ptrdiff_t, not int.
1689 (read1): Don't assume doc string length fits in int. Check for
1690 out-of-range doc string lengths.
1691 (read_list): Don't assume file position fits in int.
39019e54 1692 (read_escape): Check for hex character overflow.
bfbbd7e7 1693
4e323265
LL
16942011-06-22 Leo Liu <sdl.web@gmail.com>
1695
1696 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1697 Move to minibuffer.el.
1698
85fece3e
PE
16992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1700
20b84ce9 1701 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1702 The following patches are for when GLYPH_DEBUG && !XASSERT.
1703 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1704 * dispnew.c (flush_stdout):
1705 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1706 Mark as externally visible.
1707 * dispnew.c (check_window_matrix_pointers): Now static.
1708 * dispnew.c (window_to_frame_vpos):
1709 * xfns.c (unwind_create_frame):
1710 * xterm.c (x_check_font): Remove unused local.
1711 * scroll.c (CHECK_BOUNDS):
1712 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1713 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1714 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1715 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1716 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1717 Now static.
1718 (debug_method_add): Use va_list and vsprintf rather than relying
1719 on undefined behavior with wrong number of arguments.
1720 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1721 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1722 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1723 since we're not interested in debugging glyphs with old libraries.
1724 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1725 GCC 4.6.0's static checking.
1726
0766b489
PE
17272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1728
31fd4b32
PE
1729 Integer overflow and signedness fixes (Bug#8873).
1730 A few related buffer overrun fixes, too.
1731
b79e8648
PE
1732 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1733
0766b489
PE
1734 * dispextern.h (struct face.stipple):
1735 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1736 (x_bitmap_mask, x_allocate_bitmap_record)
1737 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1738 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1739 (x_create_bitmap_from_xpm_data):
1740 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1741 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1742 (.bitmaps_last):
1743 * xfaces.c (load_pixmap):
1744 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1745 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1746 (.bitmaps_last, struct x_output.icon_bitmap):
1747 Use ptrdiff_t, not int, for bitmap indexes.
1748 (x_allocate_bitmap_record): Check for size overflow.
1749 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1750
b081724f
PE
1751 Use ptrdiff_t, not int, for overlay counts.
1752 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1753 * editfns.c (overlays_around, get_pos_property):
1754 * textprop.c (get_char_property_and_overlay):
1755 * xdisp.c (next_overlay_change, note_mouse_highlight):
1756 * xfaces.c (face_at_buffer_position):
21514da7
PE
1757 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1758 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1759 (Fnext_overlay_change, Fprevious_overlay_change)
1760 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1761 Use ptrdiff_t, not int, for sizes.
21514da7 1762 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1763
3de73e5e
PE
1764 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1765
2606c57b
PE
1766 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1767 (x_session_initialize): Do not assume string length fits in int.
1768
aaafe47a
PE
1769 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1770 This is unlikely, but can occur if DPI is outlandish.
1771
2674ddc8 1772 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1773 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1774
28154962
PE
1775 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1776 * xrdb.c (magic_file_p, search_magic_path):
1777 Omit last arg SUFFIX; it was always 0. All callers changed.
1778 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1779
7de51af5
PE
1780 * xfont.c (xfont_match): Avoid need for strlen.
1781
25ed6cc3
PE
1782 * xfns.c: Don't assume strlen fits in int.
1783 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1784
4eab31dd
PE
1785 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1786 not unsigned long, as we prefer signed integers. All callers changed.
1787 Detect integer overflow in repeat count.
1788 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1789 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1790
171e2a58
PE
1791 * termcap.c: Don't assume sizes fit in int and never overflow.
1792 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1793 (gobble_line): Check for size-calculation overflow.
1794
ad39faca 1795 * minibuf.c (Fread_buffer):
6e5bb2dc 1796 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1797 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1798 Don't assume string length fits in int.
1799
52c61c22 1800 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1801 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1802
b5b8c9e5
PE
1803 * font.c: Don't assume string length fits in int.
1804 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1805 Use ptrdiff_t, not int.
ccd6111c
PE
1806 (font_intern_prop): Don't assume string length fits in int.
1807 Don't assume integer property fits in fixnum.
1808 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1809
882f0d81 1810 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1811 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1812 Reformulate so as not to need the command string.
1813 Invoke gzip -cd rather than gunzip, as it's more portable.
1814 (lock_info_type, lock_file_1, lock_file):
1815 Don't assume pid_t and time_t fit in unsigned long.
1816 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1817 (current_lock_owner): Prefer signed type for sizes.
1818 Use memcpy, not strncpy, where memcpy is what is really wanted.
1819 Don't assume (via atoi) that time_t and pid_t fit in int.
1820 Check for time_t and/or pid_t out of range, e.g., via a network share.
1821 Don't alloca where an auto var works fine.
1822
93f4cf88
PE
1823 * fileio.c: Fix some integer overflow issues.
1824 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1825 Don't assume string length fits in int.
1826 (directory_file_name): Don't assume string length fits in long.
1827 (make_temp_name): Don't assume pid fits in int, or that its print
1828 length is less than 20.
1829
f3e92b69
PE
1830 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1831
1bfdaf10
PE
1832 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1833
35016e9a
PE
1834 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1835
3d1e65a1
PE
1836 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1837 We prefer signed integers, even for size calculations.
1838
0b963a93
PE
1839 * emacs.c: Don't assume string length fits in 'int'.
1840 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1841 (main): Don't invoke strlen when not needed.
1842
573f4b54
PE
1843 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1844 (XD_DEBUG_MESSAGE): Don't waste a byte.
1845
989f33ba
PE
1846 * callproc.c (getenv_internal_1, getenv_internal)
1847 (Fgetenv_internal):
965d34eb
PE
1848 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1849
e4d29b33
PE
1850 * lread.c (invalid_syntax): Omit length argument.
1851 All uses changed. This doesn't fix a bug, but it simplifies the
1852 code away from its former Hollerith-constant appearance, and it's
1853 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1854 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1855
eb49b136
PE
1856 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1857 This didn't break anything, but it didn't help either.
1858 It's confusing to put a bogus integer in a place where the actual
1859 value does not matter.
9f62aeb1 1860 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1861 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1862
15375a22
PE
1863 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1864 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1865 implementation.
b61cc01c
PE
1866 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1867 We prefer signed types, and the value cannot exceed the EMACS_INT
1868 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1869 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1870 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1871 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1872
53b2623d
PE
1873 * indent.c (sane_tab_width): New function.
1874 (current_column, scan_for_column, Findent_to, position_indentation)
1875 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1876 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1877
51cab52b 1878 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1879
f2ed8a70
PE
1880 * lisp.h (lint_assume): New macro.
1881 * composite.c (composition_gstring_put_cache):
1882 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1883
abe80cc6
PE
1884 * editfns.c, insdel.c:
1885 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1886
b02c740e
PE
1887 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1888
ebc96716
PE
1889 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1890
b4e50fa0 1891 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1892 Use much-faster test for byte-length change.
311d5d7c 1893 Don't assume string byte-length fits in 'int'.
a4cf38e4 1894 Check that character arg fits in 'int'.
85461888 1895 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1896
c0c1ee9f
PE
1897 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1898
a498d7f4
PE
1899 * fns.c (concat): Catch string overflow earlier.
1900 Do not rely on integer wraparound.
1901
51cab52b
PE
1902 * dispextern.h (struct it.overlay_strings_charpos)
1903 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1904 * xdisp.c (forward_to_next_line_start)
1905 (back_to_previous_visible_line_start)
1906 (reseat_at_next_visible_line_start, next_element_from_buffer):
1907 Don't arbitrarily truncate the value of 'selective' to int.
1908
76031fad
PE
1909 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1910
5eb55db9
PE
1911 * composite.c: Don't truncate sizes to 'int'.
1912 (composition_gstring_p, composition_reseat_it)
1913 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1914 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1915 not EMACS_UINT, for indexes.
5eb55db9 1916
0703a717
PE
1917 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1918
d6202519
PE
1919 * buffer.c: Include <verify.h>.
1920 (struct sortvec.priority, struct sortstr.priority):
8961a454 1921 Now EMACS_INT, not int.
c20998a7 1922 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1923 (struct sortstr.size, record_overlay_string)
1924 (struct sortstrlist.size, struct sortlist.used):
1925 Don't truncate size to int.
1926 (record_overlay_string): Check for size-calculation overflow.
d6202519 1927 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1928
d5a19415
JM
19292011-06-22 Jim Meyering <meyering@redhat.com>
1930
029529ac 1931 Don't leak an XBM-image-sized buffer
d5a19415
JM
1932 * image.c (xbm_load): Free the image buffer after using it.
1933
a9041e6c
PE
19342011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Port to Sun C.
1937 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1938 that Sun C diagnosed.
1939 * fns.c (secure_hash): Fix pointer signedness issue.
1940 * intervals.c (static_offset_intervals): New function.
1941 (offset_intervals): Use it.
1942
7f3f739f
LL
19432011-06-21 Leo Liu <sdl.web@gmail.com>
1944
1945 * deps.mk (fns.o):
1946 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1947 sha512.h.
1948
1949 * fns.c (secure_hash): Rename from crypto_hash_function and change
1950 the first arg to accept symbols.
5b66d427 1951 (Fsecure_hash): New primitive.
7f3f739f
LL
1952 (syms_of_fns): New symbols.
1953
76147d94
DD
19542011-06-20 Deniz Dogan <deniz@dogan.se>
1955
1956 * process.c (Fset_process_buffer): Clarify return value in
1957 docstring.
1958
7d7d0045
CY
19592011-06-18 Chong Yidong <cyd@stupidchicken.com>
1960
1961 * dispnew.c (add_window_display_history): Use BVAR.
1962
1963 * xdisp.c (debug_method_add): Use BVAR.
1964 (check_window_end, dump_glyph_matrix, dump_glyph)
1965 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1966
1967 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1968 Likewise.
1969
1970 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1971 check till after the cache is created in init_frame_faces.
1972
ff2bc410
SM
19732011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1974
1975 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1976
28177add
PE
19772011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1978
dd3482fe
PE
1979 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1980 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1981 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1982
393d71f3 1983 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1984 * fileio.c (Finsert_file_contents):
1985 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1986 Remove the old (too-loose) buffer overflow checks.
1987 They weren't needed, since make_gap checks for buffer overflow.
1988 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1989 The old code merely checked for Emacs fixnum overflow, and relied
1990 on undefined (wraparound) behavior. The new code avoids undefined
1991 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1992
2e6813b0 1993 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1994 Tune. Don't use wider integers than needed. Don't use alloca.
1995 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1996
599a9e4f
PE
1997 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1998
99561444
PE
1999 * insdel.c, lisp.h (buffer_overflow): New function.
2000 (insert_from_buffer_1, replace_range, replace_range_2):
2001 * insdel.c (make_gap_larger):
2002 * editfns.c (Finsert_char):
2003 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2004
28177add
PE
2005 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2006
e69dafad
PE
20072011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2008
a7af7fde 2009 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2010
b1c46f02
PE
2011 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2012 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2013
e69dafad
PE
2014 * fileio.c: Don't assume EMACS_INT fits in off_t.
2015 (emacs_lseek): New static function.
2016 (Finsert_file_contents, Fwrite_region): Use it.
2017 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2018
566684ea
PE
2019 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2020
e6966cd6
PE
2021 * fns.c: Don't overflow int when computing a list length.
2022 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2023 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2024 truncation on 64-bit hosts. Check for QUIT every
2025 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2026 faster and is responsive enough.
2027 (Flength): Report an error instead of overflowing an integer.
2028 (Fsafe_length): Return a float if the value is not representable
2029 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2030 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2031 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2032
dd0b0efb
PE
2033 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2034 (header_size, word_size): New constants.
2035 (allocate_vectorlike): Don't check size overflow here.
2036 (allocate_vector): Check it here instead, since this is the only
2037 caller of allocate_vectorlike that could cause overflow.
2038 Check that the new vector's length is representable as a fixnum.
2039
86fe5cfe
PE
2040 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2041 The previous code was bogus. For example, next_almost_prime (32)
2042 returned 39, which is undesirable as it is a multiple of 3; and
2043 next_almost_prime (24) returned 25, which is a multiple of 5 so
2044 why was the code bothering to check for multiples of 7?
2045
80e88859
PE
2046 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2047
4a2f0ad6
PE
2048 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2049
f66c7cf8
PE
2050 Variadic C functions now count arguments with ptrdiff_t.
2051 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2052 Back then I didn't know that the Emacs coding style prefers signed int.
2053 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2054 were being counted with int, which may truncate counts on 64-bit
2055 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2056 * lisp.h (struct Lisp_Subr.function.aMANY)
2057 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2058 Arg counts are now ptrdiff_t, not size_t.
2059 All variadic functions and their callers changed accordingly.
2060 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2061 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2062 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2063 * callint.c (Fcall_interactively): Check arg count for overflow,
2064 to avoid potential buffer overrun. Use signed char, not 'int',
2065 for 'varies' array, so that we needn't bother to check its size
2066 calculation for overflow.
2067 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2068 * eval.c (apply_lambda):
2069 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2070 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2071 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2072
a1759b76
PE
2073 * callint.c (Fcall_interactively): Don't use index var as event count.
2074
d96be9fc
PE
2075 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2076 * mem-limits.h (SIZE): Remove; no longer used.
2077
a690a978 2078 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2079
578c21e6
PE
2080 Remove unnecessary casts.
2081 * xterm.c (x_term_init):
2082 * xfns.c (x_set_border_pixel):
2083 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2084 These aren't needed now that we assume ANSI C.
2085
96f53c6c
PE
2086 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2087 It's more likely to cause problems (due to unsigned overflow)
2088 than to cure them.
2089
83c77d31
PE
2090 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2091
ee2079f1
PE
2092 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2093
6da65536
PE
2094 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2095
7147c4a4
PE
2096 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2097
193e32d9
PE
2098 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2099
e5533da6
PE
2100 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2101
9910e595
PE
2102 GLYPH_CODE_FACE returns EMACS_INT, not int.
2103 * dispextern.h (merge_faces):
2104 * xfaces.c (merge_faces):
01103c44
PE
2105 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2106 Don't assume EMACS_INT fits in int.
9910e595 2107
2638320e
PE
2108 * character.h (CHAR_VALID_P): Remove unused parameter.
2109 * fontset.c, lisp.h, xdisp.c: All uses changed.
2110
045eb8d9
PE
2111 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2112
c1f134b5
PE
2113 * fns.c (concat): Minor tuning based on overflow analysis.
2114 This doesn't fix any bugs. Use int to hold character, instead
2115 of constantly refetching from Emacs object. Use XFASTINT, not
2116 XINT, for value known to be a character. Don't bother comparing
2117 a single byte to 0400, as it's always less.
2118
395fcb93 2119 * floatfns.c (Fexpt):
327eeec8
PE
2120 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2121
abbd3d23
PE
2122 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2123 for characters.
2124
684a03ef
PE
2125 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2126
0fed43f3
PE
2127 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2128 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2129 incorrectly succeed when S was a string, because 4294967386 was
2130 truncated before it was used.
2131
8fd02eb7
PE
2132 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2133 Otherwise, an out-of-range integer could cause undefined behavior
2134 on a 64-bit host.
2135
f8c86b69
PE
2136 * composite.c: Use int, not EMACS_INT, for characters.
2137 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2138 EMACS_INT, for values that are known to be in character range.
2139 This doesn't fix any bugs but is the usual style inside Emacs and
2140 may generate better code on 32-bit machines.
2141
34206dd2
PE
2142 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2143 This is for reasons similar to the recent CHAR_STRING fix.
2144 * charset.c (Fencode_char): Check that character arg is actually
2145 a character. Pass an int to ENCODE_CHAR.
2146 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2147 wider than 'int', as a compile-time check to prevent future regressions
2148 in this area.
2149
c5958d4c 2150 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2151
2152 Make sure a 64-bit char is never passed to CHAR_STRING.
2153 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2154 by silently ignoring the top 32 bits, allowing some values
2155 that were far too large to be valid characters.
2156 * character.h: Include <verify.h>.
2157 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2158 arguments are no wider than unsigned, as a compile-time check
2159 to prevent future regressions in this area.
2160 * data.c (Faset):
01103c44 2161 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2162 (Fsubst_char_in_region):
2163 * fns.c (concat):
2164 * xdisp.c (decode_mode_spec_coding):
2165 Adjust to CHAR_STRING's new requirement.
2166 * editfns.c (Finsert_char, Fsubst_char_in_region):
2167 * fns.c (concat): Check that character args are actually
2168 characters. Without this test, these functions did the wrong
2169 thing with wildly out-of-range values on 64-bit hosts.
2170
d37ca623
PE
2171 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2172 These casts should not be needed on 32-bit hosts, either.
2173 * keyboard.c (read_char):
2174 * lread.c (Fload): Remove casts to unsigned.
2175
ea204efb
PE
2176 * lisp.h (UNSIGNED_CMP): New macro.
2177 This fixes comparison bugs on 64-bit hosts.
2178 (ASCII_CHAR_P): Use it.
2179 * casefiddle.c (casify_object):
01103c44 2180 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2181 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2182 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2183 * dispextern.h (FACE_FROM_ID):
2184 * keyboard.c (read_char): Use UNSIGNED_CMP.
2185
41cb286c
PE
2186 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2187 not to EMACS_INT, to avoid GCC warning.
2188
4a1b9832
PE
2189 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2190
55daad71
PE
2191 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2192 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2193 isn't needed on 32-bit machines.
8f95c75c 2194
01103c44
PE
2195 * buffer.c (Fgenerate_new_buffer_name):
2196 Use EMACS_INT for count, not int.
0ceccced 2197 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2198
2199 * data.c (Qcompiled_function): Now static.
2200
c6f072e7
PE
2201 * window.c (window_body_lines): Now static.
2202
20ce5912
PE
2203 * image.c (gif_load): Rename local to avoid shadowing.
2204
9c4c5f81
PE
2205 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2206 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2207 * alloc.c (make_save_value): Integer argument is now of type
2208 ptrdiff_t, not int.
2209 (mark_object): Use ptrdiff_t, not int.
2210 * lisp.h (pD): New macro.
2211 * print.c (print_object): Use it.
2212
c0c5c8ae
PE
2213 * alloc.c: Use EMACS_INT, not int, to count objects.
2214 (total_conses, total_markers, total_symbols, total_vector_size)
2215 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2216 (total_free_floats, total_floats, total_free_intervals)
2217 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2218 Now EMACS_INT, not int. All uses changed.
2219 (Fgarbage_collect): Compute overall total using a double, so that
2220 integer overflow is less likely to be a problem. Check for overflow
2221 when converting back to an integer.
5a25e253
PE
2222 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2223 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2224 These were 'int' variables that could overflow on 64-bit hosts;
2225 they were never used, so remove them instead of repairing them.
211a0b2a 2226 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2227 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2228 Previously, this ceilinged at INT_MAX, but that doesn't work on
2229 64-bit machines.
e46bb31a 2230 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2231
c78baabf 2232 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2233 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2234 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2235 when a (possibly-narrower) signed value would do just as well.
2236 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2237
c9d624c6
PE
2238 * alloc.c: Catch some string size overflows that we were missing.
2239 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2240 for convenience in STRING_BYTES_MAX.
2241 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2242 The definition here is exact; the one in lisp.h was approximate.
2243 (allocate_string_data): Check for string overflow. This catches
2244 some instances we weren't catching before. Also, it catches
2245 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2246 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2247 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2248
c9d624c6
PE
2249 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2250 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2251 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2252
353032ce
PE
2253 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2254
2bccce07
PE
2255 * alloc.c (Fmake_string): Check for out-of-range init.
2256
0ac30604
SM
22572011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2258
2259 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2260
c195f2de
JD
22612011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2262
2263 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2264 xg_get_default_scrollbar_width.
2265
2266 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2267 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2268 (style_changed_cb): Call update_theme_scrollbar_width and call
2269 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2270 all frames (Bug#8505).
2271 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2272 Call gtk_window_set_resizable if HAVE_GTK3.
2273 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2274 and height if HAVE_GTK3 (Bug#8505).
2275 (scroll_bar_width_for_theme): New variable.
2276 (update_theme_scrollbar_width): New function.
2277 (xg_get_default_scrollbar_width): Move code to
2278 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2279 (xg_initialize): Call update_theme_scrollbar_width.
2280
2281 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2282
2283 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2284
e10ac9f1
MR
22852011-06-12 Martin Rudalics <rudalics@gmx.at>
2286
2287 * frame.c (make_frame): Call other_buffer_safely instead of
2288 other_buffer.
2289
2290 * window.c (temp_output_buffer_show): Call display_buffer with
2291 second argument Vtemp_buffer_show_specifiers and reset latter
2292 immediately after the call.
2293 (Vtemp_buffer_show_specifiers): New variable.
2294 (auto_window_vscroll_p, next_screen_context_lines)
2295 (Vscroll_preserve_screen_position): Remove leading asterisks from
2296 doc-strings.
2297
2d3c217e 22982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2299
7b7f97e8 2300 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2301 * buffer.c (Qclone_number): Remove for now, as it's unused.
2302 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2303 (record_buffer): Remove unused local.
2304 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2305 (set_frame_buffer_list): Remove; unused.
2306 * frame.h (other_visible_frames): Remove decl.
2307 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2308 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2309 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2310 if HAVE_GPM.
2311 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2312 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2313 Define only if HAVE_GPM.
2314 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2315 (update_hints_inhibit): Remove; never set. All uses removed.
2316 * widgetprv.h (emacsFrameClassRec): Remove decl.
2317 * window.c (delete_deletable_window): Now returns void, since it
2318 wasn't returning anything.
2319 (compare_window_configurations): Remove unused locals.
2320 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2321 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2322 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2323 the same widths as pointers. This follows up on the 2011-05-06 patch.
2324 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2325 * xterm.h: Likewise.
2326 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2327
1384b89e
JB
23282011-06-12 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * makefile.w32-in: Update dependencies.
2331 (LISP_H): Add lib/intprops.h.
2332
1100a63c
CY
23332011-06-11 Chong Yidong <cyd@stupidchicken.com>
2334
2335 * image.c (gif_load): Add animation frame delay to the metadata.
2336 (syms_of_image): Use DEFSYM. New symbol `delay'.
2337
6198ccd0
MR
23382011-06-11 Martin Rudalics <rudalics@gmx.at>
2339
2340 * window.c (delete_deletable_window): Re-add.
2341 (Fset_window_configuration): Rewrite to handle dead buffers and
2342 consequently deletable windows.
2343 (window_tree, Fwindow_tree): Remove. Supply functionality in
2344 window.el.
2345 (compare_window_configurations): Simplify code.
2346
b6e3633c
AS
23472011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2348
1ab0dee5
AS
2349 * image.c (imagemagick_load_image): Fix type mismatch.
2350 (Fimagemagick_types): Likewise.
2351
b6e3633c
AS
2352 * window.h (replace_buffer_in_windows): Declare.
2353
9397e56f
MR
23542011-06-11 Martin Rudalics <rudalics@gmx.at>
2355
2356 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2357 Qclone_number. Remove external declaration of Qdelete_window.
2358 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2359 code.
640c8776
SM
2360 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2361 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2362 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2363 buffer list implementation.
2364 (other_buffer_safely): New function.
2365 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2366 calls to replace_buffer_in_windows and
2367 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2368 if allowed.
2369 (record_buffer): Inhibit quitting and rewrite using quittable
2370 functions. Run Qbuffer_list_update_hook if allowed.
2371 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2372 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2373 Move switch-to-buffer to window.el.
9397e56f
MR
2374 (bury-buffer): Move to window.el.
2375 (Vbuffer_list_update_hook): New variable.
2376
2377 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2378 section.
2379
2380 * window.h (resize_frame_windows): Move up in code.
2381 (Fwindow_frame): Remove EXFUN.
2382 (replace_buffer_in_all_windows): Remove prototype.
2383 (replace_buffer_in_windows_safely): Add prototype.
2384
2385 * window.c: Declare Qdelete_window static again. Move down
2386 declaration of select_count.
2387 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2388 (Fother_window): Move to window.el.
2389 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2390 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2391 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2392 window.el.
2393 (replace_buffer_in_windows): Implement by calling
2394 Qreplace_buffer_in_windows.
2395 (replace_buffer_in_all_windows): Remove with some functionality
2396 moved into replace_buffer_in_windows_safely.
2397 (replace_buffer_in_windows_safely): New function.
2398 (select_window_norecord, select_frame_norecord): Move in front
2399 of run_window_configuration_change_hook. Remove now obsolete
2400 declarations.
640c8776
SM
2401 (Fset_window_buffer): Rewrite doc-string.
2402 Call Qrecord_window_buffer.
9397e56f
MR
2403 (keys_of_window): Move binding for other-window to window.el.
2404
b50691aa
CY
24052011-06-11 Chong Yidong <cyd@stupidchicken.com>
2406
2407 * dispextern.h (struct image): Replace data member, whose int_val
2408 and ptr_val fields were not used by anything, with a single
2409 lisp_val object.
2410
2411 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2412 (gif_clear_image, gif_load, imagemagick_load_image)
2413 (gs_clear_image, gs_load): Callers changed.
2414
3f754b86
PE
24152011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2416
cca69397
PE
2417 * buffer.h: Include <time.h>, for time_t.
2418 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2419
109e28d0
PE
2420 Fix minor problems found by static checking.
2421
60737f02
PE
2422 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2423
4b66faf3
PE
2424 Make identifiers static if they are not used in other modules.
2425 * data.c (Qcompiled_function, Qframe, Qvector):
2426 * image.c (QimageMagick, Qsvg):
2427 * minibuf.c (Qmetadata):
2428 * window.c (resize_window_check, resize_root_window): Now static.
2429 * window.h (resize_window_check, resize_root_window): Remove decls.
2430
109e28d0
PE
2431 * window.c (window_deletion_count, delete_deletable_window):
2432 Remove; unused.
46a4ce9e
PE
2433 (window_body_lines): Now static.
2434 (Fdelete_other_windows_internal): Mark vars as initialized.
2435 Make sure 'resize_failed' is initialized.
2436 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2437 (resize_window_apply): Remove unused local.
2438 * window.h (delete_deletable_window): Remove decl.
2439
109e28d0 2440 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2441 (imagemagick_load_image): Fix pointer signedness problem by changing
2442 last arg from unsigned char * to char *. All uses changed.
2443 Also, fix a local for similar reasons.
2444 Remove unused locals. Remove locals to avoid shadowing.
2445 (fn_rsvg_handle_free): Remove; unused.
2446 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2447 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2448
3f754b86
PE
2449 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2450
2547adb1
CY
24512011-06-10 Chong Yidong <cyd@stupidchicken.com>
2452
2453 * image.c (gif_load): Fix omitted cast error introduced by
2454 2011-06-06 change.
2455
2c8e37d4
MR
24562011-06-10 Martin Rudalics <rudalics@gmx.at>
2457
2458 * window.h (resize_proportionally, orig_total_lines)
2459 (orig_top_line): Remove from window structure.
2460 (set_window_height, set_window_width, change_window_heights)
2461 (Fdelete_window): Remove prototypes.
2462 (resize_frame_windows): Remove duplicate declaration.
2463
440a42e3
EZ
24642011-06-10 Eli Zaretskii <eliz@gnu.org>
2465
2466 * window.h (resize_frame_windows, resize_window_check)
2467 (delete_deletable_window, resize_root_window)
2468 (resize_frame_windows): Declare prototypes.
2469
2470 * window.c (resize_window_apply): Make definition be "static" to
2471 match the prototype.
2472
562dd5e9
MR
24732011-06-10 Martin Rudalics <rudalics@gmx.at>
2474
2475 * window.c: Remove declarations of Qwindow_size_fixed,
2476 window_min_size_1, window_min_size_2, window_min_size,
2477 size_window, window_fixed_size_p, enlarge_window, delete_window.
2478 Remove static from declaration of Qdelete_window, it's
2479 temporarily needed by Fbury_buffer.
2480 (replace_window): Don't assign orig_top_line and
2481 orig_total_lines.
2482 (Fdelete_window, delete_window): Remove. Window deletion is
2483 handled by window.el.
640c8776
SM
2484 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2485 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2486 (Fdelete_other_windows): Remove. Deleting other windows is
2487 handled by window.el.
2488 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2489 handled in window.el.
2490 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2491 Window minimum sizes are handled in window.el.
2492 (shrink_windows, size_window, set_window_height)
2493 (set_window_width, change_window_heights, window_height)
2494 (window_width, CURBEG, CURSIZE, enlarge_window)
2495 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2496 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2497 handled in window.el.
2498 (make_dummy_parent): Rename to make_parent_window and give it a
2499 second argument horflag.
2500 (make_window): Don't set resize_proportionally any more.
2501 (Fsplit_window): Remove. Windows are split in window.el.
2502 (save_restore_action, save_restore_orig_size)
2503 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2504 Resize mini windows in window.el.
2505 (grow_mini_window, shrink_mini_window): Implement by calling
2506 Qresize_root_window_vertically, resize_window_check and
2507 resize_window_apply.
640c8776
SM
2508 (saved_window, Fset_window_configuration, save_window_save):
2509 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2510 resize_proportionally.
2511 (window_min_height, window_min_width): Move to window.el.
2512 (keys_of_window): Move bindings for delete-other-windows,
2513 split-window, delete-window and enlarge-window to window.el.
2514
2515 * buffer.c: Temporarily extern Qdelete_window.
2516 (Fbury_buffer): Temporarily call Qdelete_window instead of
2517 Fdelete_window (Fbury_buffer will move to window.el soon).
2518
2519 * frame.c (set_menu_bar_lines_1): Remove code handling
2520 orig_top_line and orig_total_lines.
2521
2522 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2523 set_window_height but set heights directly.
2524 (change_frame_size_1): Use resize_frame_windows.
2525
2526 * xdisp.c (init_xdisp): Don't use set_window_height but set
2527 heights directly.
2528
640c8776
SM
2529 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2530 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2531 run_window_configuration_change_hook.
2532
2533 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2534 instead of change_window_heights and run
2535 run_window_configuration_change_hook.
2536
1a13852e
MR
25372011-06-09 Martin Rudalics <rudalics@gmx.at>
2538
2539 * window.c (replace_window): Rename second argument REPLACEMENT to
2540 NEW. New third argument SETFLAG. Rewrite.
2541 (delete_window, make_dummy_parent): Call replace_window with
2542 third argument 1.
2543 (window_list_1): Move down in code.
2544 (run_window_configuration_change_hook): Move set_buffer part
2545 before select_frame_norecord part in order to unwind correctly.
2546 Rename count1 to count.
2547 (recombine_windows, delete_deletable_window, resize_root_window)
2548 (Fdelete_other_windows_internal)
2549 (Frun_window_configuration_change_hook, make_parent_window)
2550 (resize_window_check, resize_window_apply, Fresize_window_apply)
2551 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2552 (Fdelete_window_internal, Fresize_mini_window_internal):
2553 New functions.
1a13852e
MR
2554 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2555
f3d1777e
MR
25562011-06-08 Martin Rudalics <rudalics@gmx.at>
2557
496e208e
MR
2558 * window.h (window): Add some new members to window structure -
2559 normal_lines, normal_cols, new_total, new_normal, clone_number,
2560 splits, nest, prev_buffers, next_buffers.
2561 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2562 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2563
f3d1777e
MR
2564 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2565 Remove.
496e208e
MR
2566 (make_dummy_parent): Set new members of windows structure.
2567 (make_window): Move down in code. Handle new members of window
2568 structure.
2569 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2570 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2571 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2572 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2573 (Fset_window_next_buffers, Fset_window_clone_number):
2574 New functions.
496e208e
MR
2575 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2576 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2577 Doc-string fixes.
2578 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2579 Argument WINDOW can be now internal window too.
2580 (Fwindow_use_time): Move up in code.
2581 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2582 Rewrite doc-string.
2583 (Fset_window_configuration, saved_window)
2584 (Fcurrent_window_configuration, save_window_save): Handle new
2585 members of window structure.
b9e809c2
MR
2586 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2587 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2588 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2589 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2590 Qget_mru_window, Qresize_root_window,
2591 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2592 Qauto_buffer_name; staticpro them.
f3d1777e 2593
abde8f8c
MR
25942011-06-07 Martin Rudalics <rudalics@gmx.at>
2595
2596 * window.c (Fwindow_total_size, Fwindow_left_column)
2597 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2598 (Fwindow_list_1): New functions.
2599 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2600 (Fwindow_width, Fscroll_left, Fscroll_right):
2601 Use window_body_cols instead of window_box_text_cols.
2602 (delete_window, Fset_window_configuration):
2603 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2604 (delete_all_subwindows): Take a window as argument and not a
2605 structure. Rewrite.
190b47e6
MR
2606 (window_loop): Remove handling of GET_LRU_WINDOW and
2607 GET_LARGEST_WINDOW.
2608 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2609
2610 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2611 window_box_text_cols. delete_all_subwindows now takes a
2612 Lisp_Object as argument.
abde8f8c 2613
640c8776
SM
2614 * indent.c (compute_motion, Fcompute_motion):
2615 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2616
fa8a67e6
MR
2617 * frame.c (delete_frame): Call delete_all_subwindows with root
2618 window as argument.
2619
a54e3482
DC
26202011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2621
2622 * fns.c (Fputhash): Document return value.
2623
60002bf5
CY
26242011-06-06 Chong Yidong <cyd@stupidchicken.com>
2625
2626 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2627
0c671da6 26282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2629
b862a52a 2630 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2631
be44ca6c
PE
2632 Check for overflow when converting integer to cons and back.
2633 * charset.c (Fdefine_charset_internal, Fdecode_char):
2634 Use cons_to_unsigned to catch overflow.
2635 (Fencode_char): Use INTEGER_TO_CONS.
2636 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2637 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2638 * data.c (long_to_cons, cons_to_long): Remove.
2639 (cons_to_unsigned, cons_to_signed): New functions.
2640 These signal an error for invalid or out-of-range values.
2641 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2642 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2643 * font.c (Ffont_variation_glyphs):
2644 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2645 * lisp.h: Include <intprops.h>.
2646 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2647 (cons_to_signed, cons_to_unsigned): New decls.
2648 (long_to_cons, cons_to_long): Remove decls.
2649 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2650 (Fprimitive_undo): Use CONS_TO_INTEGER.
2651 * xfns.c (Fx_window_property): Likewise.
2652 * xselect.c: Include <limits.h>.
2653 (x_own_selection, selection_data_to_lisp_data):
2654 Use INTEGER_TO_CONS.
2655 (x_handle_selection_request, x_handle_selection_clear)
2656 (x_get_foreign_selection, Fx_disown_selection_internal)
2657 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2658 (lisp_data_to_selection_data): Use cons_to_unsigned.
2659 (x_fill_property_data): Use cons_to_signed.
2660 Report values out of range.
2661
d1f3d2af
PE
2662 Check for buffer and string overflow more precisely.
2663 * buffer.h (BUF_BYTES_MAX): New macro.
2664 * lisp.h (STRING_BYTES_MAX): New macro.
2665 * alloc.c (Fmake_string):
2666 * character.c (string_escape_byte8):
2667 * coding.c (coding_alloc_by_realloc):
2668 * doprnt.c (doprnt):
2669 * editfns.c (Fformat):
2670 * eval.c (verror):
2671 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2672 since they may not be the same number.
2673 * editfns.c (Finsert_char):
2674 * fileio.c (Finsert_file_contents):
2675 Likewise for BUF_BYTES_MAX.
2676
dd52fcea
PE
2677 * image.c: Use ptrdiff_t, not int, for sizes.
2678 (slurp_file): Switch from int to ptrdiff_t.
2679 All uses changed.
2680 (slurp_file): Check that file size fits in both size_t (for
2681 malloc) and ptrdiff_t (for sanity and safety).
2682
7f9bbdbb
PE
2683 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2684 if b->modtime has its maximal value.
2685
dfe18f82
PE
2686 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2687
84acfcf0
PE
2688 Don't assume time_t can fit into int.
2689 * buffer.h (struct buffer.modtime): Now time_t, not int.
2690 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2691 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2692
ccd9a01a
PE
2693 Minor fixes for signed vs unsigned integers.
2694 * character.h (MAYBE_UNIFY_CHAR):
2695 * charset.c (maybe_unify_char):
2696 * keyboard.c (read_char, reorder_modifiers):
2697 XINT -> XFASTINT, since the integer must be nonnegative.
2698 * ftfont.c (ftfont_spec_pattern):
2699 * keymap.c (access_keymap, silly_event_symbol_error):
2700 XUINT -> XFASTINT, since the integer must be nonnegative.
2701 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2702 since it makes no difference and we prefer signed.
2703 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2704 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2705 nonnegative.
2706
d6d100dd
SM
27072011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2708
2709 * window.h (Fwindow_frame): Declare.
2710
2b6148e4
PE
27112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2714 (SPARE_MEMORY): Always define.
2715 (LARGE_REQUEST): Remove.
2716 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2717
f230ecc9
MR
27182011-06-06 Martin Rudalics <rudalics@gmx.at>
2719
727e958e
MR
2720 * lisp.h: Move EXFUNS for Fframe_root_window,
2721 Fframe_first_window and Fset_frame_selected_window to window.h.
2722
2723 * window.h: Move EXFUNS for Fframe_root_window,
2724 Fframe_first_window and Fset_frame_selected_window here from
2725 lisp.h.
2726
2727 * frame.c (Fwindow_frame, Fframe_first_window)
2728 (Fframe_root_window, Fframe_selected_window)
2729 (Fset_frame_selected_window): Move to window.c.
2730 (Factive_minibuffer_window): Move to minibuf.c.
2731 (Fother_visible_frames_p): New function.
2732
2733 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2734
f230ecc9
MR
2735 * window.c (decode_window, decode_any_window): Move up in code.
2736 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2737 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2738 (Fwindow_buffer): Move up and rewrite doc-string.
2739 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2740 (Fwindow_prev): New functions.
727e958e
MR
2741 (Fwindow_frame): Move here from frame.c. Accept any window as
2742 argument.
2743 (Fframe_root_window, Fframe_first_window)
2744 (Fframe_selected_window): Move here from frame.c. Accept frame
2745 or arbitrary window as argument. Update doc-strings.
2746 (Fminibuffer_window): Move up in code.
2747 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2748 (Fset_frame_selected_window): Move here from frame.c.
2749 Marginal rewrite.
727e958e
MR
2750 (Fselected_window, select_window, Fselect_window): Move up in
2751 code. Minor doc-string fixes.
f230ecc9 2752
4d09bcf6
PE
27532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2754
2755 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2756 Do not assume that spare memory exists; that assumption is valid
2757 only if SYSTEM_MALLOC.
2758 (LARGE_REQUEST): New macro, so that the issue of large requests
2759 is separated from the issue of spare memory.
2760
810928a2
AS
27612011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2762
172418ad
AS
2763 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2764 format. (Bug#8806)
2765
43f862f7
AS
2766 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2767
810928a2
AS
2768 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2769 before statements.
2770
a059fe24
JD
27712011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2772
2773 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2774
2775 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2776
2777 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2778 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2779
989bf368
JB
27802011-06-05 Juanma Barranquero <lekktu@gmail.com>
2781
2782 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2783
4b80f674
CY
27842011-06-04 Chong Yidong <cyd@stupidchicken.com>
2785
2786 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2787 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2788 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2789 New error handlers.
4b80f674
CY
2790 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2791 Obey Vx_select_enable_clipboard_manager. Catch errors in
2792 x_clipboard_manager_save (Bug#8779).
2793 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2794 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2795
99a33b77 27962011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2797
2798 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2799
99a33b77 28002011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2801
2802 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2803 in the current matrix if keep_current_p is non-zero.
2804
8264569d
EZ
28052011-06-04 Eli Zaretskii <eliz@gnu.org>
2806
2807 * bidi.c (bidi_level_of_next_char): Fix last change.
2808
57f97249
EZ
28092011-06-03 Eli Zaretskii <eliz@gnu.org>
2810
fec2107c 2811 Support bidi reordering of text covered by display properties.
57f97249 2812
fec2107c
EZ
2813 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2814 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2815 (bidi_cache_search, bidi_cache_iterator_state)
2816 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2817 (bidi_level_of_next_char, bidi_move_to_visually_next):
2818 Support character positions inside a run of characters covered by a
fec2107c
EZ
2819 display string.
2820 (bidi_paragraph_init, bidi_resolve_explicit_1)
2821 (bidi_level_of_next_char): Call bidi_fetch_char and
2822 bidi_fetch_char_advance instead of FETCH_CHAR and
2823 FETCH_CHAR_ADVANCE.
2824 (bidi_init_it): Initialize new members.
2825 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2826 definitions.
2827 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2828 instead of using explicit *_CHAR codes.
d6d100dd
SM
2829 (bidi_resolve_explicit, bidi_resolve_weak):
2830 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2831 bidirectional text is supported only in multibyte buffers.
2832 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2833 it to initialize the frame_window_p member of struct bidi_it.
2834 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2835 (bidi_resolve_explicit, bidi_resolve_weak)
2836 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2837 bidi_it->nchars is non-positive.
2838 (bidi_level_of_next_char): Don't try to lookup the cache for the
2839 next/previous character if nothing is cached there yet, or if we
2840 were just reseat()'ed to a new position.
c40e2fb2 2841
0e14fe90
EZ
2842 * xdisp.c (set_cursor_from_row): Set start and stop points
2843 according to the row's direction when priming the loop that looks
2844 for the glyph on which to display cursor.
2845 (single_display_spec_intangible_p): Function deleted.
2846 (display_prop_intangible_p): Reimplement to call
2847 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2848 Accept 3 additional arguments needed by handle_display_spec.
2849 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2850 values: lists, `(when COND...)' forms, etc.
2851 (single_display_spec_string_p): Support property values that are
2852 lists with the argument STRING its top-level element.
2853 (display_prop_string_p): Fix the condition for processing a
2854 property that is a list to be consistent with handle_display_spec.
fec2107c 2855 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2856 last portion of handle_display_prop.
2857 (compute_display_string_pos): Accept additional argument
2858 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2859 value of a `display' property is a "replacing spec".
2860 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2861 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2862 the display property, but just return a value indicating whether
2863 the display property will replace the characters it covers.
2864 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2865 frame_window_p members of struct bidi_it.
d6d100dd
SM
2866 (compute_display_string_pos, compute_display_string_end):
2867 New functions.
fec2107c
EZ
2868 (push_it): Accept second argument POSITION, where pop_it should
2869 jump to continue iteration.
2870 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2871
fec2107c
EZ
2872 * keyboard.c (adjust_point_for_property): Adjust the call to
2873 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2874
2875 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2876 (bidi_init_it): Update prototypes.
2877 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2878 (compute_display_string_pos, compute_display_string_end):
2879 Declare prototypes.
fec2107c
EZ
2880 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2881 EMACS_INT.
fc6f18ce 2882
40087514 28832011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2884
57f53182
PE
2885 Malloc failure behavior now depends on size of allocation.
2886 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2887 * lisp.h: Change signatures accordingly.
2888 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2889 All callers changed. (Bug#8762)
2890
2891 * gnutls.c: Use Emacs's memory allocators.
2892 Without this change, the gnutls library would invoke malloc etc.
2893 directly, which causes problems on non-SYNC_INPUT hosts, and which
2894 runs afoul of improving memory_full behavior. (Bug#8761)
2895 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2896 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2897 xfree instead of the default malloc, realloc, free.
2898 (Fgnutls_boot): No need to check for memory allocation failure,
2899 since xmalloc does that for us.
2900
ac32cd99 2901 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2902 * category.c (hash_get_category_set):
2903 * ccl.c (ccl_driver):
2904 * charset.c (Fdefine_charset_internal):
2905 * charset.h (struct charset.hash_index):
2906 * composite.c (get_composition_id, gstring_lookup_cache)
2907 (composition_gstring_put_cache):
2908 * composite.h (struct composition.hash_index):
2909 * dispextern.h (struct image.hash):
2910 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2911 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2912 (hashfn_equal, hashfn_user_defined, make_hash_table)
2913 (maybe_resize_hash_table, hash_lookup, hash_put)
2914 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2915 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2916 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2917 * image.c (make_image, search_image_cache, lookup_image)
2918 (xpm_put_color_table_h):
2919 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2920 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2921 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2922 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2923 * alloc.c (allocate_vectorlike):
2924 Check for overflow in vector size calculations.
2925 * ccl.c (ccl_driver):
2926 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2927 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2928 need to be updated by these changes.
40087514
PE
2929 * fns.c (make_hash_table, maybe_resize_hash_table):
2930 Check for integer overflow with large hash tables.
0de4bb68
PE
2931 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2932 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2933 (SXHASH_REDUCE): New macro.
2934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2935 Use it instead of discarding useful hash info with large hash values.
2936 (sxhash_float): New function.
2937 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2938 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2939 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2940 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2941 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2942 Adjust signatures to match updated version of code.
2943 (consing_since_gc): Now EMACS_INT, since a single hash table can
2944 use more than INT_MAX bytes.
2945
698d32e2
DN
29462011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2947
2948 Make it possible to build with GCC-4.6+ -O2 -flto.
2949
2950 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2951
fd6fa53f
SM
29522011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2953
2954 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2955 Call minibuffer-inactive-mode.
2956
864db017
JB
29572011-05-31 Juanma Barranquero <lekktu@gmail.com>
2958
2959 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2960 Update dependencies.
2961
2ad0baf4
DN
29622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2963
2964 * data.c (init_data): Remove code for UTS, this system is not
2965 supported anymore.
2966
4fcc2638
DN
29672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2968
2969 Don't force ./temacs to start in terminal mode.
2970
2971 * frame.c (make_initial_frame): Initialize faces in all cases, not
2972 only when CANNOT_DUMP is defined.
2973 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2974
c56e0fd5
DN
29752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2976
2977 * dispnew.c (add_window_display_history): Use const for the string
2978 pointer. Remove declaration, not needed.
2979
333d54da 29802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2981
55d4c1b2 2982 Use 'inline', not 'INLINE'.
333d54da 2983 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2984 * alloc.c, fontset.c (INLINE): Remove.
2985 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2986 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2987 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2988 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2989 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2990
738db178
DN
29912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2992
2993 Make it possible to run ./temacs.
2994
2995 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2996 syms_of_callproc does the same thing. Remove test for
2997 "initialized", do it in the caller.
2998 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2999
620c53a6
SM
30002011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3001
3002 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3003 (read_minibuf): Use get_minibuffer.
3004 (syms_of_minibuf): Use DEFSYM.
3005 (Qmetadata): New var.
3006 * data.c (Qbuffer): Don't make it static.
3007 (syms_of_data): Use DEFSYM.
3008
e003a292
PE
30092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3012 (CCL_CODE_MIN): New macro.
3013
ed008a6d
PE
30142011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3015
3687c2ef
PE
3016 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3017
ed008a6d
PE
3018 * eval.c (Qdebug): Now static.
3019 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3020 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3021 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3022
d66c4c7c
CY
30232011-05-29 Chong Yidong <cyd@stupidchicken.com>
3024
3025 * image.c: Various fixes to ImageMagick code comments.
3026 (Fimagemagick_types): Doc fix.
3027
5fbc2025
PE
30282011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3029
0196f88a
PE
3030 Minor fixes prompted by GCC 4.6.0 warnings.
3031
3032 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3033
5fbc2025
PE
3034 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3035 (x_clipboard_manager_save_all): Move extern decl to ...
3036 * xterm.h: ... here, so that it can be checked for consistency.
3037
1dd3c2d9
CY
30382011-05-29 Chong Yidong <cyd@stupidchicken.com>
3039
3040 * xselect.c (x_clipboard_manager_save_frame)
3041 (x_clipboard_manager_save_all): New functions.
3042 (Fx_clipboard_manager_save): Lisp function deleted.
3043
3044 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3045 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3046
3047 * xterm.h: Update prototype.
3048
5ba6571d
WX
30492011-05-28 William Xu <william.xwl@gmail.com>
3050
3051 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3052 exiting (Bug#8239).
3053
3eaff834
JM
30542011-05-28 Jim Meyering <meyering@redhat.com>
3055
e1900994 3056 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3057 * fns.c (to_uchar): Define.
3058 (crypto_hash_function): Use it to convert some newly-signed
3059 variables to unsigned, to avoid sign-extension bugs. For example,
3060 without this change, (md5 "truc") would evaluate to
3061 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3062 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3063 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3064
0f6990a7
PE
30652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 Integer overflow fixes.
c8a9ca5a 3068
08686060
PE
3069 * dbusbind.c: Serial number integer overflow fixes.
3070 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3071 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3072 to hold a serial number that is too large for a fixnum.
3073 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3074 Check for serial numbers out of range. Decode any serial number
59568bf0 3075 that was so large that it became a float. (Bug#8722)
08686060 3076
2d1fc3c7
PE
3077 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3078 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3079 Use XFASTINT rather than XUINT when numbers are nonnegative.
3080 (xd_append_arg, Fdbus_method_return_internal):
3081 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3082 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3083 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3084 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3085 (Bug#8722)
2d1fc3c7 3086
c8a9ca5a
PE
3087 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3088
519e1d69
PE
3089 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3090
30569699
PE
3091 ccl: add integer overflow checks
3092 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3093 (IN_INT_RANGE): New macros.
3094 (ccl_driver): Use them to check for integer overflow when
3095 decoding a CCL program. Many of the new checks are whether XINT (x)
3096 fits in int; it doesn't always, on 64-bit hosts. The new version
3097 doesn't catch all possible integer overflows, but it's an
847044ea 3098 improvement. (Bug#8719)
30569699 3099
c11285dc
PE
3100 * alloc.c (make_event_array): Use XINT, not XUINT.
3101 There's no need for unsigned here.
3102
fdccd48e
PE
3103 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3104 This follows up to the 2011-05-06 change that substituted uintptr_t
3105 for EMACS_INT. This case wasn't caught back then.
3106
37910ab2
PE
3107 Rework Fformat to avoid integer overflow issues.
3108 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3109 now (part of C89). Include <verify.h>.
3110 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3111 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3112 (Fformat): Avoid the prepass trying to compute sizes; it was only
3113 approximate and thus did not catch overflow reliably. Instead, walk
3114 through the format just once, formatting and computing sizes as we go,
3115 checking for integer overflow at every step, and allocating a larger
3116 buffer as needed. Keep track separately whether the format is
3117 multibyte. Keep only the most-recently calculated precision, rather
3118 than them all. Record whether each argument has been converted to
3119 string. Use EMACS_INT, not int, for byte and char and arg counts.
3120 Support field widths and precisions larger than INT_MAX. Avoid
3121 sprintf's undefined behavior with conversion specifications such as %#d
3122 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3123 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3124 formatting out-of-range floating point numbers with int
9173deec 3125 formats. (Bug#8668)
37910ab2 3126
2e6578fb
PE
3127 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3128
0ae6bdee
PE
3129 * data.c: Avoid integer truncation in expressions involving floats.
3130 * data.c: Include <intprops.h>.
3131 (arith_driver): When there's an integer overflow in an expression
3132 involving floating point, convert the integers to floating point
3133 so that the resulting value does not suffer from catastrophic
3134 integer truncation. For example, on a 64-bit host (* 4
3135 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3136 Do not rely on undefined behavior after integer overflow.
3137
de883a70
PE
3138 merge count_size_as_multibyte, parse_str_to_multibyte
3139 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3140 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3141 Check for integer overflow.
3142 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3143 since it's now a duplicate of the other. This is more of
3144 a character than a buffer op, so better that it's in character.c.
3145 * fns.c, print.c: Adjust to above changes.
3146
2ff916cb
PE
31472011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3150
f1b54466
PE
31512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3152
fb1ac845
PE
3153 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3154 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3155 (x_clipboard_manager_save): Now static.
3156 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3157
f1b54466
PE
3158 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3159 (crypto_hash_function): Now static.
3160 Fix pointer signedness problems. Avoid unnecessary initializations.
3161
a9f737ee
CY
31622011-05-27 Chong Yidong <cyd@stupidchicken.com>
3163
3164 * termhooks.h (Vselection_alist): Make it terminal-local.
3165
3166 * terminal.c (create_terminal): Initialize it.
3167
3168 * xselect.c: Support for clipboard managers.
3169 (Vselection_alist): Move to termhooks.h as terminal-local var.
3170 (LOCAL_SELECTION): New macro.
3171 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3172 (symbol_to_x_atom): Remove gratuitous arg.
3173 (x_handle_selection_request, lisp_data_to_selection_data)
3174 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3175 (x_own_selection, x_get_local_selection, x_convert_selection):
3176 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3177 (some_frame_on_display): Delete unused function.
3178 (Fx_own_selection_internal, Fx_get_selection_internal)
3179 (Fx_disown_selection_internal, Fx_selection_owner_p)
3180 (Fx_selection_exists_p): New optional frame arg.
3181 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3182 (x_handle_selection_clear): Don't treat other terminals with the
3183 same keyboard specially. Use the terminal-local Vselection_alist.
3184 (x_clear_frame_selections): Use Frun_hook_with_args.
3185
3186 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3187
3188 * xterm.h: Add support for those atoms.
3189
e067f0c1
CY
31902011-05-26 Chong Yidong <cyd@stupidchicken.com>
3191
3192 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3193 (converted_selections, conversion_fail_tag): New global variables.
3194 (x_selection_request_lisp_error): Free the above.
3195 (x_get_local_selection): Remove unnecessary code.
3196 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3197 of converted selections stored in converted_selections.
3198 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3199 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3200 (x_convert_selection): New function.
3201 (x_handle_selection_event): Simplify.
3202 (x_get_foreign_selection): Don't ignore incoming requests while
3203 waiting for an answer; this will fail when we implement
3204 SAVE_TARGETS, and seems unnecessary anyway.
3205 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3206 (Vx_sent_selection_functions): Doc fix.
3207
0f4aebc0
LL
32082011-05-26 Leo Liu <sdl.web@gmail.com>
3209
3210 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3211
e61124cd
YM
32122011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3213
3214 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3215
3216 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3217 for fringe update if it has periodic bitmap.
ac389d0c 3218 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3219 and fringe_bitmap_periodic_p.
3220
3221 * fringe.c (get_fringe_bitmap_data): New function.
3222 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3223 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3224 row. Mark glyph row for fringe update if periodicity changed.
3225
3226 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3227 for fringe update unless it has periodic bitmap.
3228
f16d9837
KH
32292011-05-25 Kenichi Handa <handa@m17n.org>
3230
3231 * xdisp.c (get_next_display_element): Set correct it->face_id for
3232 a static composition.
3233
e1b90ef6
LL
32342011-05-24 Leo Liu <sdl.web@gmail.com>
3235
3236 * deps.mk (fns.o):
3237 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3238
3239 * fns.c (crypto_hash_function, Fsha1): New function.
3240 (Fmd5): Use crypto_hash_function.
3241 (syms_of_fns): Add Ssha1.
3242
7400048f
PE
32432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 * gnutls.c: Remove unused macros.
3246 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3247 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3248 Remove macros that are defined and never used.
3249 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3250
abb71cf4
CY
32512011-05-22 Chong Yidong <cyd@stupidchicken.com>
3252
3253 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3254 (Fx_get_selection_internal): Minor cleanup.
3255 (Fx_own_selection_internal): Rename arguments for consistency with
3256 select.el.
3257
6307db39
PE
32582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3261
f3d4e0a4
CY
32622011-05-22 Chong Yidong <cyd@stupidchicken.com>
3263
3264 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3265
4d8ade89
YM
32662011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3267
3268 * dispnew.c (scrolling_window): Don't exclude the case that the
3269 last enabled row in the desired matrix touches the bottom boundary.
3270
32078c8d
GM
32712011-05-21 Glenn Morris <rgm@gnu.org>
3272
3273 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3274 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3275 and add some more files.
32078c8d 3276
7285dc67
EZ
32772011-05-20 Eli Zaretskii <eliz@gnu.org>
3278
3279 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3280 report_file_error introduced by the change from 2011-05-07.
3281
89d1bd22
PE
32822011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3283
3284 * systime.h (Time): Define only if emacs is defined.
3285 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3286 where the include path doesn't have X11/X.h by default. See
3287 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3288
e23640bb 32892011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3290
3291 * composite.c (find_automatic_composition): Fix previous change.
3292
b9704ad9
GM
32932011-05-20 Glenn Morris <rgm@gnu.org>
3294
3295 * lisp.mk: New file, split from Makefile.in.
3296 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3297 (shortlisp): Remove.
3298 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3299
4a720484
GM
33002011-05-19 Glenn Morris <rgm@gnu.org>
3301
3302 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3303 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3304 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3305 (lisp): Set the order to that of loadup.el.
3306 (shortlisp): Make it a copy of $lisp.
3307 (SOME_MACHINE_LISP): Remove.
3308 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3309 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3310
a28d4396
KH
33112011-05-18 Kenichi Handa <handa@m17n.org>
3312
3313 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3314 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3315 (find_automatic_composition): Mostly rewrite for efficiency.
3316
a2b1fa8e
JB
33172011-05-18 Juanma Barranquero <lekktu@gmail.com>
3318
3319 * makefile.w32-in: Update dependencies.
3320
8e1f5610
CS
33212011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3322
3323 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3324 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3325
7025ee00 33262011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3327
cdfa6eab
PE
3328 Fix some integer overflow issues, such as string length overflow.
3329
06d6db33
PE
3330 * insdel.c (count_size_as_multibyte): Check for string overflow.
3331
2b4560a8
PE
3332 * character.c (lisp_string_width): Check for string overflow.
3333 Use EMACS_INT, not int, for string indexes and lengths; in
3334 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3335 the resulting string length overflows an EMACS_INT; instead,
3336 report a string overflow if no precision given. When checking for
3337 precision exhaustion, use a check that cannot possibly have
3338 integer overflow. (Bug#8675)
3339 * character.h (lisp_string_width): Adjust to new signature.
3340
cb93f9be
PE
3341 * alloc.c (string_overflow): New function.
3342 (Fmake_string): Use it. This doesn't change behavior, but saves
3343 a few bytes and will simplify future changes.
3344 * character.c (string_escape_byte8): Likewise.
3345 * lisp.h (string_overflow): New decl.
3346
1a1f3366
PE
3347 Fixups, following up to the user-interface timestamp change.
3348 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3349 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3350 * msdos.c (mouse_get_pos): Likewise.
3351 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3352 * w32gui.h (Time): Define by including "systime.h" rather than by
3353 declaring it ourselves. (Bug#8664)
3354
d4e3e4d3
PE
3355 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3356 * image.c (clear_image_cache): Likewise.
3357
f6a24d19
PE
3358 * term.c (term_mouse_position): Don't assume time_t wraparound.
3359
08dc5ae6
PE
3360 Be more systematic about user-interface timestamps.
3361 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3362 and sometimes 'EMACS_UINT', to represent these timestamps.
3363 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3364 This makes the code easier to follow, and makes it easier to catch
3365 integer overflow bugs such as Bug#8664.
3366 * frame.c (Fmouse_position, Fmouse_pixel_position):
3367 Use Time, not unsigned long, for user-interface timestamps.
3368 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3369 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3370 * keyboard.h (last_event_timestamp): Likewise.
3371 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3372 * menu.h (xmenu_show): Likewise.
3373 * term.c (term_mouse_position): Likewise.
3374 * termhooks.h (struct input_event.timestamp): Likewise.
3375 (struct terminal.mouse_position_hook): Likewise.
3376 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3377 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3378 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3379 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3380 what it was before.
3381 * menu.h, termhooks.h: Include "systime.h", for Time.
3382
8e55734a
PE
3383 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3384 Don't assume that the difference between two unsigned long values
3385 can fit into an integer. At this point, we know button_down_time
3386 <= event->timestamp, so the difference must be nonnegative, so
3387 there's no need to cast the result if double-click-time is
3388 nonnegative, as it should be; check that it's nonnegative, just in
3389 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3390 apart (about 25 days). (Bug#8664)
8e55734a 3391
841f1b75 3392 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3393 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3394
3e26f69c
PE
3395 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3396 that always fit in int. Use a sentinel instead of a counter, to
3397 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3398 * frame.h (struct frame): Use int for menu_bar_items_used
3399 instead of EMACS_INT, since it always fits in int.
3e26f69c 3400
5cc152c0
PE
3401 * menu.c (grow_menu_items): Check for int overflow.
3402
d89eb65e
PE
3403 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3404
5235bd3e
PE
3405 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3406 Before, the code was not consistent. These values cannot exceed
3407 2**31 - 1 so there's no need to make them unsigned.
3408 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3409 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3410 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3411 as modifiers.
3412 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3413
bc827e23
PE
3414 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3415 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3416 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3417 presumably because the widths might not match.
3418
78eb494e
PE
3419 * window.c (size_window): Avoid needless test at loop start.
3420
04f2d78b
CB
34212011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3422
3423 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3424
d2fc7e3d 34252011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3426
3427 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3428
d2fc7e3d 34292011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3430
3431 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3432 `width' to `bar_area_x' and `bar_area_width', respectively.
3433 (x_scroll_run): Take account of fringe background extension.
3434
04f2d78b
CB
3435 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3436 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3437 `bar_area_width', respectively.
3438 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3439 background extension.
3440
79b70037
GM
34412011-05-10 Jim Meyering <meyering@redhat.com>
3442
3443 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3444
2f142cc5
JB
34452011-05-10 Juanma Barranquero <lekktu@gmail.com>
3446
3447 * image.c (Finit_image_library): Return t for built-in image types,
3448 like pbm and xbm. (Bug#8640)
3449
57679c86
AS
34502011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3451
3452 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3453
888c9e86
EZ
34542011-05-07 Eli Zaretskii <eliz@gnu.org>
3455
b0512a1d
EZ
3456 * w32console.c (Fset_screen_color): Doc fix.
3457 (Fget_screen_color): New function.
3458 (syms_of_ntterm): Defsubr it.
3459
7285dc67
EZ
3460 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3461 unlink the temporary file if Fcall_process didn't create it in the
3462 first place.
3463 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3464 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3465 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3466 cue to call_process_cleanup not to close that handle.
3467
4d3fcc8e
BK
34682011-05-07 Ben Key <bkey76@gmail.com>
3469
3470 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3471 one of two shell specific rules, either bootstrap-temacs-CMD or
3472 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3473 to the previous implementation of the bootstrap-temacs rule.
3474 The bootstrap-temacs-CMD rule is similar to the previous
3475 implementation of the bootstrap-temacs rule except that it
3476 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3477 variable.
3478
3479 These changes, along with some changes to nt/configure.bat,
3480 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3481 earlier fix to add support for --cflags and --ldflags options
3482 that include quotes so that it works whether make uses cmd or
3483 sh as the shell.
3484
b4289b64
MA
34852011-05-06 Michael Albinus <michael.albinus@gmx.de>
3486
3487 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3488 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3489 is a constant.
3490 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3491 a string. Handle both cases.
3492 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3493 (Fdbus_register_method): Use Qinvalid_function.
3494
af4c0e28
JB
34952011-05-06 Juanma Barranquero <lekktu@gmail.com>
3496
3497 * makefile.w32-in: Update dependencies.
3498 (LISP_H): Add inttypes.h and stdin.h.
3499 (PROCESS_H): Add unistd.h.
3500
c51453d9
EZ
35012011-05-06 Eli Zaretskii <eliz@gnu.org>
3502
3503 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3504 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3505
8ff0ac3c 35062011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3507
4c4b566b
PE
3508 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3509
aab2b9b5
PE
3510 * term.c (vfatal): Remove stray call to va_end.
3511 It's not needed and the C Standard doesn't allow it here anyway.
3512
c378da0b
PE
3513 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3514 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3515
288b08c7
PE
3516 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3517 bytes.
3518
e3601888
PE
3519 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3520
db6c0e74
PE
3521 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3522
dd5963ea
PE
3523 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3524
88c9450f
PE
3525 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3526
2f9442b8
PE
3527 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3528
c032b5f8
PE
3529 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3530 * charset.c (Fdefine_charset_internal): Don't initialize
3531 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3532 32-bit int (Bug#8600).
a108c10b
PE
3533
3534 * lread.c (read_integer): Be more consistent with string-to-number.
3535 Use string_to_number to do the actual conversion; this avoids
3536 rounding errors and fixes some other screwups. Without this fix,
3537 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3538 (digit_to_number): Move earlier, for benefit of read_integer.
3539 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3540 not a digit in any supported base. (Bug#8602)
a108c10b 3541
ad5f9eea
PE
3542 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3543
aec1708a
PE
3544 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3545 to match comment at start of function. This also removes a
3546 GCC warning about overflow in a 32+64-bit port.
3547
47be4ab5
PE
3548 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3549
371cac43
PE
3550 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3551 Reported by Stefan Monnier in
3552 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3553 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3554 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3555
d01a7826
PE
3556 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3557 (EMACS_UINTPTR): Likewise, with uintptr_t.
3558
7fd47d5c
PE
3559 * lisp.h: Prefer 64-bit EMACS_INT if available.
3560 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3561 on 32-bit hosts that have 64-bit int, so that they can access
3562 large files.
122b0c86
PE
3563 However, temporarily disable this change unless the temporary
3564 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3565
8727937b
PE
3566 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3567
8ac068ac
PE
3568 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3569 This removes an assumption that EMACS_INT and long are the same
3570 width as pointers. The assumption is true for Emacs porting targets
3571 now, but we want to make other targets possible.
3572 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3573 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3574 In the rest of the code, change types of integers that hold casted
3575 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3576 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3577 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3578 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3579 No need to cast type when ORing.
3580 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3581 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3582 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3583 assume EMACS_INT is the same width as char *.
3584 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3585 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3586 Remove no-longer-needed casts.
3587 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3588 (xg_tool_bar_help_callback, xg_make_tool_item):
3589 Use EMACS_INTPTR to hold an integer
3590 that will be cast to void *; this can avoid a GCC warning
3591 if EMACS_INT is not the same width as void *.
3592 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3593 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3594 (current_message_1, set_message_1):
3595 Use a local to convert to proper width without a cast.
3596 * xmenu.c (dialog_selection_callback): Likewise.
3597
ede49d71
PE
3598 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3599 Also, don't assume VALBITS / RAND_BITS is less than 5,
3600 and don't rely on undefined behavior when shifting a 1 left into
3601 the sign bit.
3602 * lisp.h (get_random): Change signature to match.
3603
2f30ecd0
PE
3604 * lread.c (hash_string): Use size_t, not int, for hash computation.
3605 Normally we prefer signed values; but hashing is special, because
3606 it's better to use unsigned division on hash table sizes so that
3607 the remainder is nonnegative. Also, size_t is the natural width
3608 for hashing into memory. The previous code used 'int', which doesn't
3609 retain enough info to hash well into very large tables.
3610 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3611
2a866e7b
PE
3612 * dbusbind.c: Don't possibly lose pointer info when converting.
3613 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3614 Use XPNTR rather than XHASH, so that the high-order bits of
3615 the pointer aren't lost when converting through void *.
3616
51639eac
PE
3617 * eval.c (Fautoload): Don't double-shift a pointer.
3618
92394119
PE
3619 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3620
dbdb9a7c
JB
36212011-05-06 Juanma Barranquero <lekktu@gmail.com>
3622
3623 * gnutls.c (DEF_GNUTLS_FN):
3624 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3625
db7a0b4f
AS
36262011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3627
3628 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3629 marker. (Bug#8610)
3630
f7ff1b0f 36312011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3632
3633 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3634 New version that can reserve upto 2GB of heap space.
3635
f7ff1b0f 36362011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3637
3638 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3639
639c109b
TZ
36402011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3641
3642 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3643 `gnutls_certificate_set_x509_key_file'.
3644
d2127135
JB
36452011-05-05 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3648 Update dependencies.
3649
e968f4f3
JB
36502011-05-04 Juanma Barranquero <lekktu@gmail.com>
3651
3652 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3653 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3654 Remove unused parameter `fildes'.
3655 * process.c (read_process_output, send_process): Don't pass it.
3656
84d358f0
JB
36572011-05-04 Juanma Barranquero <lekktu@gmail.com>
3658
3659 Fix previous change: the library cache is defined in w32.c.
3660 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3661 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3662
0898ca10
JB
36632011-05-04 Juanma Barranquero <lekktu@gmail.com>
3664
3665 Implement dynamic loading of GnuTLS on Windows.
3666
3667 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3668 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3669 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3670 Declare.
3671
3672 * gnutls.c (Qgnutls_dll): Define.
3673 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3674 (gnutls_*): Declare function pointers.
3675 (init_gnutls_functions): New function to initialize function pointers.
3676 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3677 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3678 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3679 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3680 (emacs_gnutls_write, emacs_gnutls_read)
3681 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3682 (Fgnutls_available_p): New function.
3683 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3684 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3685 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3686
3687 * image.c: Include w32.h.
3688 (Vimage_type_cache): Delete.
3689 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3690 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3691 (w32_delayed_load): Move to w32.c.
3692
3693 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3694
3695 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3696 (w32_delayed_load): Move from image.c. When loading a library, record
3697 its filename in the :loaded-from property of the library id.
3698 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3699 Initialize and staticpro them.
3700 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3701
3702 * process.c: Include lisp.h before w32.h, not after.
3703 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3704 instead of gnutls_record_check_pending.
3705
3706 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3707
ff4de4aa
TZ
37082011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3709
3710 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3711 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3712 as passed in.
3713
abe95abb
JD
37142011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3715
3716 * xterm.c (x_set_frame_alpha): Do not set property on anything
3717 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3718
e16e55d4
JB
37192011-05-02 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3722
bafcf6a5
JB
37232011-05-02 Juanma Barranquero <lekktu@gmail.com>
3724
3725 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3726 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3727 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3728 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3729 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3730 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3731 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3732 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3733 (Qgnutls_bootprop_callbacks_verify): Make static.
3734
e7a6747f
AS
37352011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3736
19ed11ba
AS
3737 * callproc.c: Indentation fixup.
3738
e7a6747f 3739 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3740 (wait_for_termination, interruptible_wait_for_termination):
3741 Move after wait_for_termination_1.
e7a6747f 3742
1ef14cb4
LMI
37432011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3744
3745 * sysdep.c (interruptible_wait_for_termination): New function
3746 which is like wait_for_termination, but allows keyboard
3747 interruptions.
3748
3749 * callproc.c (Fcall_process): Add (:file "file") as an option for
3750 the STDOUT buffer.
3751 (Fcall_process_region): Ditto.
3752
330d880c
EZ
37532011-04-30 Eli Zaretskii <eliz@gnu.org>
3754
8db90b73
EZ
3755 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3756 rather than `XVECTOR (FOO)->size'.
3757
330d880c
EZ
3758 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3759 inttypes.h, as a gnulib replacement is used if it not available in
3760 system headers.
3761
15cbd324
EZ
37622011-04-21 Eli Zaretskii <eliz@gnu.org>
3763
3764 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3765 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3766 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3767
3768 * coding.c (coding_alloc_by_realloc): Error out if destination
3769 will grow beyond MOST_POSITIVE_FIXNUM.
3770 (decode_coding_emacs_mule): Abort if there isn't enough place in
3771 charbuf for the composition carryover bytes. Reserve an extra
3772 space for up to 2 characters produced in a loop.
3773 (decode_coding_iso_2022): Abort if there isn't enough place in
3774 charbuf for the composition carryover bytes.
3775
37762011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3777
ae940cca
EZ
3778 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3779 aborting when %lld or %lll format is passed.
3780 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3781 %llo or %llx format is passed. (Bug#8545)
3782
03ab8921
EZ
3783 * window.c (window_scroll_line_based): Use a marker instead of
3784 simple variables to record original value of point. (Bug#7952)
3785
afda1437
EZ
3786 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3787 produced by %s or %c overflows available buffer space. (Bug#8545)
3788
f76dee0c
PE
37892011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3792 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3793
fdc5744d
JB
37942011-04-28 Juanma Barranquero <lekktu@gmail.com>
3795
3796 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3797
638f053a
JB
37982011-04-28 Juanma Barranquero <lekktu@gmail.com>
3799
3800 * keyboard.c (Qdelayed_warnings_hook): Define.
3801 (command_loop_1): Run `delayed-warnings-hook'
3802 if Vdelayed_warnings_list is non-nil.
3803 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3804 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3805
d178f871
EZ
38062011-04-28 Eli Zaretskii <eliz@gnu.org>
3807
3808 * doprnt.c (doprnt): Don't return value smaller than the buffer
3809 size if the message was truncated. (Bug#8545).
3810
b124fd93
JB
38112011-04-28 Juanma Barranquero <lekktu@gmail.com>
3812
3813 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3814 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3815
e810457d
PE
38162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3817
3818 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3819
ea51cceb
JB
38202011-04-27 Juanma Barranquero <lekktu@gmail.com>
3821
3822 * makefile.w32-in: Update dependencies.
3823
94dcfacf
EZ
38242011-04-27 Eli Zaretskii <eliz@gnu.org>
3825
3826 Improve `doprnt' and its usage. (Bug#8545)
3827 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3828 `format_end'. Remove support for %l as a conversion specifier.
3829 Don't use xrealloc. Improve diagnostics when the %l size modifier
3830 is used. Update the commentary.
3831
3832 * eval.c (verror): Simplify calculation of size_t.
3833
3834 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3835 messages.
3836
f61f41d7
PE
38372011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3838
3839 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3840 change.
3841
96fb4434
PE
38422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3845 This makes this file independent of the recent pseudovector change.
3846
671875da 38472011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3848
69e9b5a3
PE
3849 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3850
b5f869a7 3851 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3852 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3853 Remove unused local.
c8926152 3854 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3855
841a1577 3856 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3857 GCC 4.6.0 optimizes based on type-based alias analysis.
3858 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3859 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3860 != &v->size, and therefore "v->size = 1; b->size = 2; return
3861 v->size;" must therefore return 1. This assumption is incorrect
3862 for Emacs, since it type-puns struct Lisp_Vector * with many other
3863 types. To fix this problem, this patch adds a new type struct
f904488f 3864 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3865 and pseudovectors, and helps optimizing compilers not get fooled
3866 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3867 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3868 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3869 the size member.
eab3844f
PE
3870 (XSETPVECTYPE): Rewrite in terms of new macro.
3871 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3872 This is a bit clearer, and further avoids the possibility of
3873 undesirable aliasing.
3874 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3875 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3876 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3877 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3878 (ASIZE): Now uses header.size rather than size.
3879 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3880 to avoid the hassle of writing XVECTOR (foo)->header.size.
3881 (struct vectorlike_header): New type.
eab3844f
PE
3882 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3883 object, to help avoid aliasing.
3884 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3885 (SUBRP): Likewise, since Lisp_Subr is a special case.
3886 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3887 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3888 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3889 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3890 changed to be "header.size" and "header.next".
3891 * buffer.h (struct buffer): Likewise.
3892 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3893 * frame.h (struct frame): Likewise.
3894 * process.h (struct Lisp_Process): Likewise.
3895 * termhooks.h (struct terminal): Likewise.
3896 * window.c (struct save_window_data, struct saved_window): Likewise.
3897 * window.h (struct window): Likewise.
3898 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3899 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3900 * buffer.c (init_buffer_once): Likewise.
3901 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3902 special case.
3903 * process.c (Fformat_network_address): Use local var for size,
3904 for brevity.
3905
0df1eac5
PE
3906 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3907
847ab9d1 3908 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3909 * data.c (atof): Remove decl; no longer used or needed.
3910 (digit_to_number): Move to lread.c.
3911 (Fstring_to_number): Use new string_to_number function, to be
3912 consistent with how the Lisp reader treats infinities and NaNs.
3913 Do not assume that floating-point numbers represent EMACS_INT
3914 without losing information; this is not true on most 64-bit hosts.
3915 Avoid double-rounding errors, by insisting on integers when
3916 parsing non-base-10 numbers, as the documentation specifies.
3917 * lisp.h (string_to_number): New decl, replacing ...
3918 (isfloat_string): Remove.
bc0a5c13 3919 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3920 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3921 appears to have been a coding error. Similarly, do not accept
3922 strings like +-1e0 as floating point numbers. Do not report
3923 overflow for integer overflows unless the base is not 10 which
3924 means we have no simple and reliable way to continue.
3925 Break out the floating-point parsing into a new
3926 function string_to_number, so that Fstring_to_number parses
3927 floating point numbers consistently with the Lisp reader.
04f2d78b 3928 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3929 (E_CHAR, EXP_INT): Remove, replacing with ...
3930 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3931 (string_to_number): New function, replacing isfloat_string.
3932 This function checks for valid syntax and produces the resulting
3933 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3934 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3935 so that overflow for non-base-10 numbers is reported only when
3936 there's no portable and simple way to convert to floating point.
452f4150 3937
67769ffc
PE
3938 * textprop.c (set_text_properties_1): Rewrite for clarity,
3939 and to avoid GCC warning about integer overflow.
3940
c20db43f
PE
3941 * intervals.h (struct interval): Use EMACS_INT for members
3942 where EMACS_UINT might cause problems. See
3943 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3944 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3945 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3946 All uses changed.
37aa2f85
PE
3947 (offset_intervals): Tell GCC not to worry about length overflow
3948 when negating a negative length.
c20db43f 3949
2538aa2f
PE
3950 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3951 (overrun_check_free): Likewise.
3952
f2d3008d
PE
3953 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3954 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3955 word size.
3956
ec8df744
PE
3957 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3958 (gnutls_make_error): Rename local to avoid shadowing.
3959 (gnutls_emacs_global_deinit): ifdef out; not used.
3960 (Fgnutls_boot): Use const for pointer to readonly storage.
3961 Comment out unused local. Fix pointer signedness problems.
3962
640ee02d
PE
3963 * lread.c (openp): Don't stuff size_t into an 'int'.
3964 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3965 about possible signed overflow.
3966
6048fb2a
PE
3967 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3968 (GDK_KEY_g): Don't define if already defined.
3969 (xg_prepare_tooltip): Avoid pointer signedness problem.
3970 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3971
fa3c87e1
PE
3972 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3973 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3974
2172544b
PE
3975 * xfns.c (Fx_window_property): Simplify a bit,
3976 to make a bit faster and to avoid GCC 4.6.0 warning.
3977 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3978
9b821a21
PE
3979 * fns.c (internal_equal): Don't assume size_t fits in int.
3980
3c616cfa
PE
3981 * alloc.c (compact_small_strings): Tighten assertion a little.
3982
c2982e87
PE
3983 Replace pEd with more-general pI, and fix some printf arg casts.
3984 * lisp.h (pI): New macro, generalizing old pEd macro to other
3985 conversion specifiers. For example, use "...%"pI"d..." rather
3986 than "...%"pEd"...".
3987 (pEd): Remove. All uses replaced with similar uses of pI.
3988 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3989 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3990 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3991 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3992 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3993 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3994 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3995 64-bit hosts.
3996 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3997 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3998 * print.c (safe_debug_print, print_object): Likewise.
3999 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4000 to int.
6f04d126
PE
4001 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4002 avoiding the 0 flag, which is not portable.
c2982e87
PE
4003 * process.c (Fmake_network_process): Use pI to avoid cast.
4004 * region-cache.c (pp_cache): Likewise.
4005 * xdisp.c (decode_mode_spec): Likewise.
4006 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4007 behavior on 64-bit hosts with printf arg.
6f04d126 4008 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4009 (x_stop_queuing_selection_requests): Likewise.
4010 (x_get_window_property): Don't truncate byte count to an 'int'
4011 when tracing.
0b432f21 4012
5e073ec7
PE
4013 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4014 here, since it parses constructs like leading '-' and spaces,
4015 which are not wanted; and it overflows with large numbers.
4016 Instead, simply match F[0-9]+, which is what is wanted anyway.
4017
36372bf9
PE
4018 * alloc.c: Remove unportable assumptions about struct layout.
4019 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4020 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4021 (allocate_vectorlike, make_pure_vector): Use the new macros,
4022 plus offsetof, to remove unportable assumptions about struct layout.
4023 These assumptions hold on all porting targets that I know of, but
4024 they are not guaranteed, they're easy to remove, and removing them
4025 makes further changes easier.
4026
0b432f21
PE
4027 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4028 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4029 (string_overrun_cookie): Now const. Use initializers that
4030 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4031 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4032 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4033 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4034 multiple of sizeof (EMACS_INT); it need not be, if
4035 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4036 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4037
895009e1
JB
40382011-04-26 Juanma Barranquero <lekktu@gmail.com>
4039
4040 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4041
6a7a1b0b
TZ
40422011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4043
4044 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4045 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4046 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4047
841a1577 40482011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4049
4050 * lisp.h (Qdebug): List symbol.
895009e1 4051 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4052 * keyboard.c (debug-on-event): New variable.
4053 (handle_user_signal): Break into debugger when debug-on-event
4054 matches the current signal symbol.
4055
f2d3ba6f
DN
40562011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4057
4058 * alloc.c (check_sblock, check_string_bytes)
4059 (check_string_free_list): Convert to standard C.
4060
42ce4c63
TZ
40612011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4062
4063 * w32.c (emacs_gnutls_push): Fix typo.
4064
825cd63c
EZ
40652011-04-25 Eli Zaretskii <eliz@gnu.org>
4066
fb11d64d
EZ
4067 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4068 "cast to pointer from integer of different size".
4069
825cd63c
EZ
4070 Improve doprnt and its use in verror. (Bug#8545)
4071 * doprnt.c (doprnt): Document the set of format control sequences
4072 supported by the function. Use SAFE_ALLOCA instead of always
4073 using `alloca'.
4074
4075 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4076 is one byte too soon. Don't use xrealloc; instead xfree and
4077 xmalloc anew.
4078
e061a11b
TZ
40792011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4080
4081 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4082 callbacks stage.
4083
4084 * gnutls.c: Renamed global_initialized to
4085 gnutls_global_initialized. Added internals for the
4086 :verify-hostname-error, :verify-error, and :verify-flags
4087 parameters of `gnutls-boot' and documented those parameters in the
4088 docstring. Start callback support.
9173deec
JB
4089 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4090 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4091 on error. Return error code.
e061a11b
TZ
4092 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4093 (emacs_gnutls_read): Likewise.
4094 (Fgnutls_boot): Return handshake error code.
4095 (emacs_gnutls_handle_error): New function.
4096 (wsaerror_to_errno): Likewise.
4097
4098 * w32.h (emacs_gnutls_pull): Add prototype.
4099 (emacs_gnutls_push): Likewise.
4100
4101 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4102 (emacs_gnutls_push): Likewise.
4103
41042011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4105
4106 * process.c (wait_reading_process_output): Check if GnuTLS
4107 buffered some data internally if no FDs are set for TLS
4108 connections.
4109
4110 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4111 (LIBS): Link to USER_LIBS.
4112 ($(BLD)/gnutls.$(0)): New target.
4113
fa6996bc
EZ
41142011-04-24 Eli Zaretskii <eliz@gnu.org>
4115
eb35682e
EZ
4116 * xdisp.c (handle_single_display_spec): Rename the
4117 display_replaced_before_p argument into display_replaced_p, to
4118 make it consistent with the commentary. Fix typos in the
4119 commentary.
4120
e2ad650c
EZ
4121 * textprop.c (syms_of_textprop): Remove dead code.
4122 (copy_text_properties): Delete obsolete commentary about an
4123 interface that was deleted long ago. Fix typos in the description
4124 of arguments.
4125
1b2de274
EZ
4126 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4127 to changes in oldXMenu/XMenu.h from 2011-04-16.
4128 <menu_help_message, prev_menu_help_message>: Constify.
4129 (IT_menu_make_room): menu->help_text is now `const char **';
4130 adjust.
4131
4132 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4133 to changes in oldXMenu/XMenu.h from 2011-04-16.
4134 (struct XMenu): Declare `help_text' `const char **'.
4135
4136 * xfaces.c <Qunspecified>: Make extern again.
4137
4138 * syntax.c: Include sys/types.h before including regex.h, as
4139 required by Posix.
4140
762b15be
EZ
4141 * doc.c (get_doc_string): Improve the format passed to `error'.
4142
4143 * doprnt.c (doprnt): Improve commentary.
4144
4145 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4146
4147 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4148 them with etags.
4149
f1052e5d
EZ
4150 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4151 changes in globals.h immediately force recompilation.
762b15be
EZ
4152 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4153 $(CURDIR)/s/ms-w32.h.
4154 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4155
fa6996bc
EZ
4156 * character.c (Fchar_direction): Function deleted.
4157 (syms_of_character): Don't defsubr it.
4158 <char-direction-table>: Deleted.
4159
e6c3da20
EZ
41602011-04-23 Eli Zaretskii <eliz@gnu.org>
4161
4162 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4163 * doprnt.c: Include limits.h.
4164 (SIZE_MAX): New macro.
04f2d78b
CB
4165 (doprnt): Return a size_t value. 2nd arg is now size_t.
4166 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4167 Improve overflow protection. Support `l' modifier for integer
4168 conversions. Support %l conversion. Don't assume an EMACS_INT
4169 argument for integer conversions and for %c.
4170
4171 * lisp.h (doprnt): Restore prototype.
4172
4173 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4174 $(SRC)/character.h.
4175
4176 * Makefile.in (base_obj): Add back doprnt.o.
4177
4178 * deps.mk (doprnt.o): Add back prerequisites.
4179 (callint.o): Depend on character.h.
4180
4181 * eval.c (internal_lisp_condition_case): Include the handler
4182 representation in the error message.
4183 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4184 when breaking from the loop.
4185
4186 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4187
4188 * callint.c (Fcall_interactively): When displaying error message
4189 about invalid control letter, pass the character's codepoint, not
4190 a pointer to its multibyte form. Improve display of the character
4191 in octal and display also its hex code.
4192
4193 * character.c (char_string): Use %x to display the (unsigned)
4194 codepoint of an invalid character, to avoid displaying a bogus
4195 negative value.
4196
4197 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4198 `error', not SYMBOL_NAME itself.
4199
4200 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4201 character arguments to `error'.
4202
4203 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4204 to `error' in error message about FINAL_CHAR argument. Make sure
4205 FINAL_CHAR is a character, and use %c when it is passed as
4206 argument to `error'.
4207
4ffd0d6b 42082011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4209
4210 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4211
4212 * w32.c: Include <time.h>.
4213 (sys_localtime): New function.
4214
4ffd0d6b 42152011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4216
4217 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4218
4ffd0d6b 4219 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4220
4ffd0d6b 42212011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4222
4ffd0d6b
GM
4223 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4224 zombies (Bug#8467).
aac0c6e3 4225
04c56954
EZ
42262011-04-19 Eli Zaretskii <eliz@gnu.org>
4227
4228 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4229 gl_state.e_property when gl_state.object is Qt.
4230
4231 * insdel.c (make_gap_larger): Remove limitation of buffer size
4232 to <= INT_MAX.
4233
16a43933
CY
42342011-04-18 Chong Yidong <cyd@stupidchicken.com>
4235
4236 * xdisp.c (lookup_glyphless_char_display)
4237 (produce_glyphless_glyph): Handle cons cell entry in
4238 glyphless-char-display.
4239 (Vglyphless_char_display): Document it.
4240
4241 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4242 glyphless-char-display.
4243
4581706e
CY
42442011-04-17 Chong Yidong <cyd@stupidchicken.com>
4245
4246 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4247
4248 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4249
4250 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4251 definition for no-X builds.
4252
4887c6e2 42532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4254
fd35b6f9
PE
4255 Static checks with GCC 4.6.0 and non-default toolkits.
4256
5c1ccb01
PE
4257 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4258
006c5daa
PE
4259 * process.c (keyboard_bit_set): Define only if SIGIO.
4260 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4261 (send_process): Repair possible setjmp clobbering.
4262
efc736d3
PE
4263 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4264
4e2fe2e6
PE
4265 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4266
f97334a2
PE
4267 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4268
4e75f29d
PE
4269 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4270 Define only if needed.
4271
90efadd1
PE
4272 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4273 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4274 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4275
3c647824
PE
4276 * dispextern.h (struct redisplay_interface): Rename param
4277 to avoid shadowing.
e264f262 4278 * termhooks.h (struct terminal): Likewise.
761383f4 4279 * xterm.c (xembed_send_message): Likewise.
3c647824 4280
b58c5c4a
PE
4281 * insdel.c (make_gap_smaller): Define only if
4282 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4283
cad59032
PE
4284 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4285 it.
4286
c339dc2e
PE
4287 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4288 so that we aren't warned about unused symbols.
4289
91a3e27b
PE
4290 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4291
399c71d3 4292 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4293
8ffc96f5
PE
4294 * xfns.c (x_real_positions): Mark locals as initialized.
4295
eef9bc79
PE
4296 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4297
098db9dd
PE
4298 * xterm.c: Fix problems found by static analysis with other toolkits.
4299 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4300 (x_dispatch_event): Declare static if USE_GTK, and
4301 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4302 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4303 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4304 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4305 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4306
eb18f6cc
PE
4307 * xmenu.c (menu_help_callback): Pointer type fixes.
4308 Use const pointers when pointing at readonly data. Avoid pointer
4309 signedness clashes.
4310 (FALSE): Remove unused macro.
4311 (update_frame_menubar): Remove unused decl.
4312
1fe72bf8
PE
4313 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4314
60d9e1db
PE
4315 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4316 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4317 (single_menu_item): Rename local to avoid shadowing.
4318
39261c26
PE
4319 * keyboard.c (make_lispy_event): Remove unused local var.
4320
018c5e19
PE
4321 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4322 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4323
63d2b86e
PE
4324 * bitmaps: Change bitmaps from unsigned char back to the X11
4325 compatible char. Avoid the old compiler warnings about
4326 out-of-range initializers by using, for example, '\xab' rather
4327 than 0xab.
4328
aefd87e1
PE
4329 * xgselect.c (xgselect_initialize): Check vs interface
4330 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4331
bf501fb9
PE
4332 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4333
e9829fdf
PE
4334 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4335 to read-only memory.
4336
1086c095
PE
4337 * fns.c (vector): Remove; this old hack is no longer needed.
4338
2baccd04 4339 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4340 Remove unused var.
dde42981 4341 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4342
72391843 4343 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4344
436c16df 4345 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4346 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4347 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4348
92bb796d 4349 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4350 (x_term_init): Remove local to avoid shadowing.
92bb796d 4351
764430a3 4352 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4353
4354 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4355 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4356
d1dfb56c
EZ
43572011-04-16 Eli Zaretskii <eliz@gnu.org>
4358
c4354cb4
EZ
4359 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4360
d1dfb56c
EZ
4361 Fix regex.c, syntax.c and friends for buffers > 2GB.
4362 * syntax.h (struct gl_state_s): Declare character position members
4363 EMACS_INT.
4364
4365 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4366
04f2d78b
CB
4367 * textprop.c (verify_interval_modification, interval_of):
4368 Declare arguments EMACS_INT.
d1dfb56c
EZ
4369
4370 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4371 EMACS_INT.
4372
4373 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4374
4375 * indent.c (Fvertical_motion): Local variable it_start is now
4376 EMACS_INT.
4377
4378 * regex.c (re_match, re_match_2, re_match_2_internal)
4379 (bcmp_translate, regcomp, regexec, print_double_string)
4380 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4381 (re_compile_pattern, re_exec): Declare arguments and local
4382 variables `size_t' and `ssize_t' and return values `regoff_t', as
4383 appropriate.
4384 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4385 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4386 <compile_stack_type>: `size' and `avail' are now `size_t'.
4387
4388 * regex.h <regoff_t>: Use ssize_t, not int.
4389 (re_search, re_search_2, re_match, re_match_2): Arguments that
4390 specify buffer/string position and length are now ssize_t and
4391 size_t. Return type is regoff_t.
4392
613052cd
BK
43932011-04-16 Ben Key <bkey76@gmail.com>
4394
4395 * nsfont.m: Fixed bugs in ns_get_family and
4396 ns_descriptor_to_entity that were caused by using free to
4397 deallocate memory blocks that were allocated by xmalloc (via
4398 xstrdup). This caused Emacs to crash when compiled with
4399 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4400 --enable-checking=xmallocoverrun). xfree is now used to
4401 deallocate these memory blocks.
4402
4170f62f 44032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4404
71b41406
PE
4405 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4406
9587a89d
PE
4407 emacs_write: Accept and return EMACS_INT for sizes.
4408 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4409 et seq.
4410 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4411 Accept and return EMACS_INT.
4412 (emacs_gnutls_write): Return the number of bytes written on
4413 partial writes.
4414 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4415 (emacs_read, emacs_write): Remove check for negative size, as the
4416 Emacs source code has been audited now.
9587a89d
PE
4417 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4418 (emacs_read, emacs_write): Use it.
273a5f82
PE
4419 * process.c (send_process): Adjust to the new signatures of
4420 emacs_write and emacs_gnutls_write. Do not attempt to store
4421 a byte offset into an 'int'; it might overflow.
9587a89d 4422 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4423
3e047f51
PE
4424 * sound.c: Don't assume sizes fit in 'int'.
4425 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4426 Return EMACS_INT, not int.
3e047f51 4427 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4428 Accept EMACS_INT, not int.
4429 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4430 record read return values.
4431
cc39a9db
BK
44322011-04-15 Ben Key <bkey76@gmail.com>
4433
c9d0ec6d
JB
4434 * keyboard.c (Qundefined): Don't declare static since it is used
4435 in nsfns.m.
4436 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4437 static since they are used in nsfont.m.
cc39a9db 4438
6c60eb9f
SM
44392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4440
4441 * process.c (Qprocessp): Don't declare static.
4442 * lisp.h (Qprocessp): Declare again.
4443
7990b61a
JB
44442011-04-15 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4447
5d4cb038
PE
44482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4449
8bd7b830 4450 Improve C-level modularity by making more things 'static'.
cd64ea1d 4451
e3b27b31
PE
4452 Don't publish debugger-only interfaces to other modules.
4453 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4454 (verify_bytepos, count_markers): Move decls to the only modules
4455 that need them.
4456 * region-cache.h (pp_cache): Likewise.
4457 * window.h (check_all_windows): Likewise.
4458 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4459
5d4cb038
PE
4460 * sysdep.c (croak): Now static, if
4461 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4462 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4463
4464 * alloc.c (refill_memory_reserve): Now static if
4465 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4466 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4467
e87b6180
PE
4468 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4469 Define only if USE_LUCID.
4470
ac64929e
PE
4471 * xrdb.c (x_customization_string, x_rm_string): Now static.
4472
6f37259d
PE
4473 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4474 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4475
1683e3ab
PE
4476 * xdisp.c (draw_row_with_mouse_face): Now static.
4477 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4478
de9c2632
PE
4479 * window.h (check_all_windows): Mark externally visible.
4480
2b96acb7
PE
4481 * window.c (window_deletion_count): Now static.
4482
4483 * undo.c: Make symbols static if they're not exported.
4484 (last_undo_buffer, last_boundary_position, pending_boundary):
4485 Now static.
4486
50436f33
PE
4487 * textprop.c (interval_insert_behind_hooks): Now static.
4488 (interval_insert_in_front_hooks): Likewise.
4489
64520e5c
PE
4490 * term.c: Make symbols static if they're not exported.
4491 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4492 (max_frame_lines, tty_set_terminal_modes):
4493 (tty_reset_terminal_modes, tty_turn_off_highlight):
4494 (get_tty_terminal): Now static.
4495 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4496 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4497 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4498 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4499 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4500
1fa53021
PE
4501 * sysdep.c: Make symbols static if they're not exported.
4502 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4503 Now static.
4504 (sigprocmask_set, full_mask): Remove; unused.
4505 (wait_debugging): Mark as visible.
4506 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4507 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4508
d4b43b22
PE
4509 * syntax.c (syntax_temp): Define only if !__GNUC__.
4510
b7c513d0
PE
4511 * sound.c (current_sound_device, current_sound): Now static.
4512
989b29ad
PE
4513 * search.c (searchbufs, searchbuf_head): Now static.
4514
13a55a78
PE
4515 * scroll.c (scroll_cost): Remove; unused.
4516 * dispextern.h (scroll_cost): Remove decl.
4517
de68a1fc
PE
4518 * region-cache.h (pp_cache): Mark as externally visible.
4519
40ccffa6
PE
4520 * process.c: Make symbols static if they're not exported.
4521 (process_tick, update_tick, create_process, chan_process):
4522 (Vprocess_alist, proc_buffered_char, datagram_access):
4523 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4524 (deactivate_process): Mark defn as static, as well as decl.
4525 * lisp.h (create_process): Remove decl.
4526 * process.h (chan_process, Vprocess_alist): Remove decls.
4527
ad64fc97
PE
4528 * print.c: Make symbols static if they're not exported.
4529 (print_depth, new_backquote_output, being_printed, print_buffer):
4530 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4531 (print_interval, print_number_index, initial_stderr_stream):
4532 Now static.
4533 * lisp.h (Fprinc): Remove decl.
4534 (debug_output_compilation_hack): Mark as externally visible.
4535
adddb265
PE
4536 * sysdep.c (croak): Move decl from here to syssignal.h.
4537 * syssignal.h (croak): Put it here, so the API can be checked when
4538 'croak' is called from dissociate_if_controlling_tty.
4539
1717ede2
PE
4540 * minibuf.c: Make symbols static if they're not exported.
4541 (minibuf_save_list, choose_minibuf_frame): Now static.
4542 * lisp.h (choose_minibuf_frame): Remove decl.
4543
fa5fb2bc
PE
4544 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4545
1e3890d1
PE
4546 * lread.c: Make symbols static if they're not exported.
4547 (read_objects, initial_obarray, oblookup_last_bucket_number):
4548 Now static.
4549 (make_symbol): Remove; unused.
4550 * lisp.h (initial_obarray, make_symbol): Remove decls.
4551
8a1414fa
PE
4552 * keyboard.c: Make symbols static if they're not exported.
4553 (single_kboard, recent_keys_index, total_keys, recent_keys):
4554 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4555 (this_single_command_key_start, echoing, last_auto_save):
4556 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4557 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4558 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4559 (Vlispy_mouse_stem, double_click_count):
4560 Now static.
4561 (force_auto_save_soon): Define only if SIGDANGER.
4562 (ignore_mouse_drag_p): Now static if
4563 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4564 (print_help): Remove; unused.
4565 (stop_character, last_timer_event): Mark as externally visible.
4566 * keyboard.h (ignore_mouse_drag_p): Declare only if
4567 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4568 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4569 * lisp.h (echoing): Remove decl.
4570 (force_auto_save_soon): Declare only if SIGDANGER.
4571 * xdisp.c (redisplay_window): Simplify code, to make it more
4572 obvious that ignore_mouse_drag_p is not accessed if !defined
4573 USE_GTK && !defined HAVE_NS.
4574
93ea6e8f
PE
4575 * intervals.c: Make symbols static if they're not exported.
4576 (merge_properties_sticky, merge_interval_right, delete_interval):
4577 Now static.
4578 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4579
77382fcc
PE
4580 * insdel.c: Make symbols static if they're not exported.
4581 However, leave prepare_to_modify_buffer alone. It's never
4582 called from outside this function, but that appears to be a bug.
4583 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4584 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4585 (adjust_after_replace_noundo): Remove; unused.
4586 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4587 (signal_before_change): Remove decls.
77382fcc 4588
9306c32e
PE
4589 * indent.c (val_compute_motion, val_vmotion): Now static.
4590
cd44d2eb
PE
4591 * image.c: Make symbols static if they're not exported.
4592 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4593 if USE_GTK.
4594 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4595 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4596
ad9a7a06
PE
4597 * fringe.c (standard_bitmaps): Now static.
4598 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4599
81626931
PE
4600 * frame.c: Make symbols static if they're not exported.
4601 (x_report_frame_params, make_terminal_frame): Now static.
4602 (get_frame_param): Now static, unless HAVE_NS.
4603 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4604 (x_get_resource_string): Remove; not used.
4605 * frame.h (make_terminal_frame, x_report_frame_params):
4606 (x_get_resource_string); Remove decls.
4607 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4608 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4609
239f9db9
PE
4610 * font.c, fontset.c: Make symbols static if they're not exported.
4611 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4612 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4613 * font.c (font_close_object): Now static.
4614 * font.h (font_close_object): Remove.
4615 * fontset.c (FONTSET_OBJLIST): Remove.
4616 (free_realized_fontset) #if-0 the body, which does nothing.
4617 (face_suitable_for_char_p): #if-0, as it's never called.
4618 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4619 * xfaces.c (face_at_string_position):
4620 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4621 since 0 is always ASCII.
4622
dfcf3579
PE
4623 * fns.c (weak_hash_tables): Now static.
4624
5045092b
PE
4625 * fileio.c: Make symbols static if they're not exported.
4626 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4627 (Vwrite_region_annotation_buffers): Now static.
4628
57a96f5c
PE
4629 * eval.c: Make symbols static if they're not exported.
4630 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4631 * lisp.h (backtrace_list): Remove decl.
4632
35f08c38
PE
4633 * emacs.c: Make symbols static if they're not exported.
4634 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4635 (fatal_error_code, fatal_error_signal_hook, standard_args):
4636 Now static.
4637 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4638 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4639 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4640 * lisp.h (fatal_error_signal_hook): Remove decl.
4641 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4642
f44bd759
PE
4643 * editfns.c: Move a (normally-unused) function to its only use.
4644 * editfns.c, lisp.h (get_operating_system_release): Remove.
4645 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4646 worth the hassle of breaking this out.
4647
b532497d
PE
4648 * xterm.c: Make symbols static if they're not exported.
4649 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4650 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4651 (x_destroy_window, x_delete_display):
4652 Now static.
4653 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4654 (x_mouse_leave): Remove; unused.
4655 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4656 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4657 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4658 Remove decls.
4659 (x_mouse_leave): Declare only if WINDOWSNT.
4660 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4661 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4662 USE_X_TOOLKIT.
4663
1675728f
PE
4664 * ftxfont.c: Make symbols static if they're not exported.
4665 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4666 HAVE_FREETYPE.
4667 * font.h (ftxfont_driver): Likewise.
4668
e4cebfca
PE
4669 * xfns.c: Make symbols static if they're not exported.
4670 (x_last_font_name, x_display_info_for_name):
4671 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4672 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4673 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4674 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4675 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4676 (last_show_tip_args): Now static.
4677 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4678 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4679 (x_screen_planes): Remove; unused.
4680 * dispextern.h (x_screen_planes): Remove decl.
4681
5bf46f05
PE
4682 * dispnew.c: Make symbols static if they're not exported.
4683 * dispextern.h (redraw_garbaged_frames, scrolling):
4684 (increment_row_positions): Remove.
4685 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4686 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4687 Now static.
4688 (redraw_garbaged_frames): Remove; unused.
4689
435f4c28
PE
4690 * xfaces.c: Make symbols static if they're not exported.
4691 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4692 Remove decls.
4693 * xterm.h (defined_color): Remove decls.
4694 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4695 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4696 (menu_face_changed_default, defined_color, free_realized_face):
4697 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4698 (ascii_face_of_lisp_face): Remove; unused.
4699
8524aef3
PE
4700 * xdisp.c: Make symbols static if they're not exported.
4701 * dispextern.h (scratch_glyph_row, window_box_edges):
4702 (glyph_to_pixel_coords, set_cursor_from_row):
4703 (get_next_display_element, set_iterator_to_next):
4704 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4705 (show_mouse_face): Remove decls
4706 * frame.h (message_buf_print): Likewise.
4707 * lisp.h (pop_message, set_message, check_point_in_composition):
4708 Likewise.
4709 * xterm.h (set_vertical_scroll_bar): Likewise.
4710 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4711 (message_buf_print, scratch_glyph_row, displayed_buffer):
4712 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4713 (get_next_display_element, show_mouse_face, window_box_edges):
4714 (frame_to_window_pixel_xy, check_point_in_composition):
4715 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4716 (glyph_to_pixel_coords): Remove; unused.
4717
16390cd2
PE
4718 * dired.c (file_name_completion): Now static.
4719
4720 * dbusbind.c (xd_in_read_queued_messages): Now static.
4721
a25f4dfa
PE
4722 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4723 * data.c (circular_list_error): Remove.
4724
14a9c8df
PE
4725 * commands.h (last_point_position, last_point_position_buffer):
4726 (last_point_position_window): Remove decls.
4727 * keyboard.c: Make these variables static.
4728
04f2d78b
CB
4729 * coding.h (coding, code_convert_region, encode_coding_gap):
4730 Remove decls.
74ab6df5
PE
4731 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4732 (iso_code_class, detect_coding, code_convert_region): Now static.
4733 (encode_coding_gap): Remove; unused.
4734
38dfbee1
PE
4735 * chartab.c (chartab_chars, chartab_bits): Now static.
4736
a2cb4e63
PE
4737 * charset.h (charset_iso_8859_1): Remove decl.
4738 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4739 Now static.
4740
127198fd
PE
4741 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4742 * ccl.c (Vccl_program_table): Now static.
4743 (check_ccl_update): Remove; unused.
4744
d85b608f
PE
4745 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4746 * category.h: ... from here.
4747 * category.c (check_category_table, set_category_set): Now static.
4748
31cd66f3
PE
4749 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4750 * lisp.h: Remove these decls.
4751
c358e587
PE
4752 * buffer.c (buffer_count): Remove unused var.
4753
e78aecca
PE
4754 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4755 so that it's not optimized away.
4756 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4757 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4758 exported only to the debugger.
4759
e192d7d3 4760 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4761 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4762
92470028
PE
4763 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4764 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4765 was inaccessible from Lisp.
4766 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4767 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4768
244ed907
PE
4769 alloc.c: Import and export fewer symbols, and remove unused items.
4770 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4771 is defined.
4772 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4773 it's not optimized away by whole-program optimization.
4774 (message_enable_multibyte, free_misc): Remove.
4775 (catchlist, handlerlist, mark_backtrace):
4776 Declare only if BYTE_MARK_STACK.
4777 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4778 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4779 (message_enable_multibyte): Remove decl.
4780 (free_misc, interval_free_list, float_block, float_block_index):
4781 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4782 (cons_free_list, last_marked_index):
4783 Now static.
4784 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4785 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4786 (mark_backtrace): Define only if BYTE_MARK_STACK.
4787 * xdisp.c (message_enable_multibyte): Now static.
4788
61c2b50e 4789 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4790 This makes it easier for human readers (and static analyzers)
4791 to see whether these variables are used from other modules.
4792 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4793 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4794 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4795 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4796 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4797 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4798 * xmenu.c, xselect.c:
4799 Declare Q* vars static if they are not used in other modules.
4800 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4801 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4802 Remove decls of unexported vars.
4803 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4804
95c82688
PE
4805 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4806
16a97296
PE
4807 Make Emacs functions such as Fatom 'static' by default.
4808 This makes it easier for human readers (and static analyzers)
4809 to see whether these functions can be called from other modules.
4810 DEFUN now defines a static function. To make the function external
4811 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4812 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4813 (Finit_image_library):
16a97296
PE
4814 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4815 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4816 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4817 Remove decls, since these functions are now static.
4818 (Funintern, Fget_internal_run_time): New decls, since these functions
4819 were already external.
95c82688 4820
16a97296
PE
4821 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4822 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4823 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4824 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4825 * keyboard.c, keymap.c, lread.c:
4826 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4827 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4828 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4829 Mark functions with DEFUE instead of DEFUN,
4830 if they are used in other modules.
4831 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4832 decls for now-static functions.
4833 * buffer.h (Fdelete_overlay): Remove decl.
4834 * callproc.c (Fgetenv_internal): Mark as internal.
4835 * composite.c (Fremove_list_of_text_properties): Remove decl.
4836 (Fcomposition_get_gstring): New forward static decl.
4837 * composite.h (Fcomposite_get_gstring): Remove decl.
4838 * dired.c (Ffile_attributes): New forward static decl.
4839 * doc.c (Fdocumntation_property): New forward static decl.
4840 * eval.c (Ffetch_bytecode): New forward static decl.
4841 (Funintern): Remove extern decl; now in .h file where it belongs.
4842 * fileio.c (Fmake_symbolic_link): New forward static decl.
4843 * image.c (Finit_image_library): New forward static decl.
4844 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4845 * intervals.h (Fprevious_property_change):
4846 (Fremove_list_of_text_properties): Remove decls.
4847 * keyboard.c (Fthis_command_keys): Remove decl.
4848 (Fcommand_execute): New forward static decl.
4849 * keymap.c (Flookup_key): New forward static decl.
4850 (Fcopy_keymap): Now static.
4851 * keymap.h (Flookup_key): Remove decl.
4852 * process.c (Fget_process): New forward static decl.
4853 (Fprocess_datagram_address): Mark as internal.
4854 * syntax.c (Fsyntax_table_p): New forward static decl.
4855 (skip_chars): Remove duplicate decl.
4856 * textprop.c (Fprevious_property_change): New forward static decl.
4857 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4858 Now internal.
4859 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4860 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4861
785bbd42
PE
4862 * editfns.c (Fformat): Remove unreachable code.
4863
8b913b57
AS
48642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4865
4866 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4867 change. (Bug#8496)
4868
a6744a35
EZ
48692011-04-13 Eli Zaretskii <eliz@gnu.org>
4870
4871 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4872 when at ZV. (Bug#8487)
4873
e7974947
AS
48742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4875
baad03f0
AS
4876 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4877 (Bug#8437)
4878 * keyboard.c (parse_tool_bar_item): Likewise.
4879 * sound.c (sound_cleanup, alsa_close): Likewise.
4880 * termcap.c (tgetent): Likewise.
4881 * xfns.c (x_default_font_parameter): Likewise.
4882 * xsettings.c (read_and_apply_settings): Likewise.
4883
e7974947
AS
4884 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4885 (overrun_check_free): Protoize.
4886
28272684
PE
48872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4890 since callers should never pass a negative size.
4891 Change the signature to match that of plain 'read' and 'write'; see
4892 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4893 * lisp.h: Update prototypes of emacs_write and emacs_read.
4894
11997c76
EZ
48952011-04-11 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (redisplay_window): Don't try to determine the character
4898 position of the scroll margin if the window start point w->startp
e896f03c 4899 is outside the buffer's accessible region. (Bug#8468)
11997c76 4900
8a2cbd72
EZ
49012011-04-10 Eli Zaretskii <eliz@gnu.org>
4902
4903 Fix write-region and its subroutines for buffers > 2GB.
4904 * fileio.c (a_write, e_write): Modify declaration of arguments and
4905 local variables to support buffers larger than 2GB.
4906 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4907
4908 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4909 argument, local variables, and return value.
4910
4911 * lisp.h: Update prototypes of emacs_write and emacs_read.
4912
4913 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4914
4073e537 49152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4916
1ebfdcb6
PE
4917 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4918
b2ded58d
PE
4919 Fix more problems found by GCC 4.6.0's static checks.
4920
7d66342c
PE
4921 * xdisp.c (vmessage): Use a better test for character truncation.
4922
bbf47d44
PE
4923 * charset.c (load_charset_map): <, not <=, for optimization,
4924 and to avoid potential problems with integer overflow.
9248994d 4925 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4926 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4927 * editfns.c (Fformat): Likewise.
1e69125e 4928 * syntax.c (skip_chars): Likewise.
3befa583 4929
e3019616
PE
4930 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4931 This also lets GCC 4.6.0 generate slightly better loop code.
4932
becfa255
PE
4933 * callint.c (Fcall_interactively): <, not <=, for optimization.
4934 (Fcall_interactively): Count the number of arguments produced,
4935 not the number of arguments given. This is simpler and lets GCC
4936 4.6.0 generate slightly better code.
4937
dae0cd48
PE
4938 * ftfont.c: Distingish more carefully between FcChar8 and char.
4939 The previous code passed unsigned char * to a functions like
4940 strlen and xstrcasecmp that expect char *, which does not
4941 conform to the C standard.
4942 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4943 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4944 char * when the C standard requires it.
4945
76032d70
PE
4946 * keyboard.c (read_char): Remove unused var.
4947
eb3f1cc8
PE
4948 * eval.c: Port to Windows vsnprintf (Bug#8435).
4949 Include <limits.h>.
4950 (SIZE_MAX): Define if the headers do not.
4951 (verror): Do not give up if vsnprintf returns a negative count.
4952 Instead, grow the buffer. This ports to Windows vsnprintf, which
4953 does not conform to C99. Problem reported by Eli Zaretskii.
4954 Also, simplify the allocation scheme, by avoiding the need for
4955 calling realloc, and removing the ALLOCATED variable.
4956
70476b54
PE
4957 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4958
12020a9e
PE
4959 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4960 But keep the doprint source code for now, as we might revamp it
4961 and use it again (Bug#8435).
ea6c7ae6
PE
4962 * lisp.h (doprnt): Remove.
4963 * Makefile.in (base_obj): Remove doprnt.o.
4964 * deps.mk (doprnt.o): Remove.
4965
5fdb398c
PE
4966 error: Print 32- and 64-bit integers portably (Bug#8435).
4967 Without this change, on typical 64-bit hosts error ("...%d...", N)
4968 was used to print both 32- and 64-bit integers N, which relied on
4969 undefined behavior.
4970 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4971 New macro.
4972 * lisp.h (error, verror): Mark as printf-like functions.
4973 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4974 Report overflow in size calculations when allocating printf buffer.
4975 Do not truncate output string at its first null byte.
4976 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4977 Truncate the output at a character boundary, since vsnprintf does not
4978 do that.
4979 * charset.c (check_iso_charset_parameter): Convert internal
4980 character to string before calling 'error', since %c now has the
4981 printf meaning.
4982 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4983 overflow when computing char to be passed to 'error'. Do not
4984 pass Lisp_Object to 'error'; pass the integer instead.
4985 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4986 formatted with plain %d.
4987
b189fa66
PE
4988 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4989
bff87ef0
PE
4990 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4991
7e2cac20
PE
4992 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4993
ce4d90b5
PE
4994 * xterm.c (x_catch_errors): Remove duplicate declaration.
4995
266c9547
PE
4996 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4997
79c49ad2
PE
4998 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4999
368f4090
JM
50002011-04-10 Jim Meyering <meyering@redhat.com>
5001
5002 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5003 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5004 return ssize_t not "int", and use size_t as the buffer length.
5005 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5006 * gnutls.h: Update declarations.
5007 * process.c (read_process_output): Use ssize_t, to match.
5008 (send_process): Likewise.
5009
a32d4040
CY
50102011-04-09 Chong Yidong <cyd@stupidchicken.com>
5011
5012 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5013
8546720e 50142011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5015
04f2d78b
CB
5016 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5017 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5018
8546720e
GM
5019 * xterm.c (handle_one_xevent):
5020 * xmenu.c (create_and_show_popup_menu):
5021 * xselect.c (x_decline_selection_request)
5022 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5023
0a2f5c1a 50242011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5025
5026 Fix some uses of `int' instead of EMACS_INT.
5027 * search.c (string_match_1, fast_string_match)
5028 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5029 (scan_buffer, find_next_newline_no_quit)
5030 (find_before_next_newline, search_command, Freplace_match)
5031 (Fmatch_data): Make some `int' variables be EMACS_INT.
5032
5033 * xdisp.c (display_count_lines): 3rd argument and return value now
5034 EMACS_INT. All callers changed.
5035 (pint2hrstr): Last argument is now EMACS_INT.
5036
5037 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5038 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5039 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5040 (decode_coding_utf_16, decode_coding_emacs_mule)
5041 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5042 (decode_coding_ccl, decode_coding_charset)
5043 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5044 (decode_coding_iso_2022, decode_coding_emacs_mule)
5045 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5046 <char_offset, last_offset>: Declare EMACS_INT.
5047 (encode_coding_utf_8, encode_coding_utf_16)
5048 (encode_coding_emacs_mule, encode_invocation_designation)
5049 (encode_designation_at_bol, encode_coding_iso_2022)
5050 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5051 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5052 Declare EMACS_INT.
5053 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5054 (encode_invocation_designation): Last argument P_NCHARS is now
5055 EMACS_INT.
5056 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5057 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5058
5059 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5060 All users changed.
5061
5062 * ccl.c (Fccl_execute_on_string): Declare some variables
5063 EMACS_INT.
5064
8546720e 50652011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5066
5067 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5068
4e19a977
CS
50692011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5070
5071 * process.c (Fformat_network_address): Doc fix.
5072
87302331
R
50732011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5074
5075 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5076
cbb59342
CY
50772011-04-08 Chong Yidong <cyd@stupidchicken.com>
5078
5079 * keyboard.c (read_char): Call Lisp function help-form-show,
5080 instead of using internal_with_output_to_temp_buffer.
5081 (Qhelp_form_show): New var.
e0d38eeb 5082 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5083
5084 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5085
5086 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5087
e67a13ab
CY
50882011-04-06 Chong Yidong <cyd@stupidchicken.com>
5089
04f2d78b
CB
5090 * process.c (Flist_processes): Remove to Lisp.
5091 (list_processes_1): Delete.
e67a13ab 5092
973f782d
EZ
50932011-04-06 Eli Zaretskii <eliz@gnu.org>
5094
7c106b1e
EZ
5095 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5096
973f782d
EZ
5097 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5098
41cf7d1a 50992011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5100
ca23cc88
PE
5101 Fix more problems found by GCC 4.6.0's static checks.
5102
f390e2d5
PE
5103 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5104
42eea0d0
PE
5105 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5106
b69769da 5107 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5108
f9541e84
PE
5109 * xdisp.c (vmessage): Mark as a printf-like function.
5110
13841b55
PE
5111 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5112
c136c10f
PE
5113 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5114
5e2d4a30
PE
5115 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5116 printf-like functions.
5117 (tiff_load): Add casts to remove these marks before passing them
5118 to system-supplied API.
5119
583f48b9
PE
5120 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5121
b25d760e
PE
5122 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5123 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5124 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5125 directly, rather than having caller test rule sign. This avoids
5126 some unnecessary tests.
5127 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5128 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5129 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5130
bc7b6697 5131 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5132 (xfont_open): Avoid unnecessary tests.
bc7b6697 5133
27ccc379
PE
5134 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5135
dcd5c89a
PE
5136 * composite.h, composite.c (composition_gstring_put_cache):
5137 Use EMACS_INT, not int, for length.
5138
b13a45c6
PE
5139 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5140 breaking out part of COMPOSITION_DECODE_RULE.
5141 (COMPOSITION_DECODE_RULE): Use it.
5142 * composite.c (get_composition_id): Remove unused local vars,
5143 by using the new macro.
5144
1e792e4d
PE
5145 * textprop.c (set_text_properties_1): Change while to do-while,
5146 since the condition is always true at first.
5147
dc6c6455 5148 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5149 (interval_deletion_adjustment): Return unsigned value.
5150 All uses changed.
dc6c6455 5151
aba7731a
PE
5152 * process.c (list_processes_1, create_pty, read_process_output):
5153 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5154 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5155 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5156 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5157 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5158
fdfc4bf3
PE
5159 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5160
fca8fe46 5161 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5162 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5163
06a0259a 5164 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5165 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5166 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5167
e7b9e80f
PE
5168 * print.c (print_error_message): Avoid int overflow.
5169
56201685
PE
5170 * font.c (font_list_entities): Redo for clarity,
5171 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5172
78834453 5173 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5174 (font_score): Avoid potential overflow in diff calculation.
78834453 5175
0bc0b309 5176 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5177 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5178
e610eaca
PE
5179 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5180
b895abce
PE
5181 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5182 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5183 can always succeed if overflow has undefined behavior.
5184
1f1d9321 5185 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5186 (wordify): Omit three unnecessary tests.
1f1d9321 5187
c59478bc
PE
5188 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5189 All callers changed. This avoids the need for an unused var.
5190
79b73827
PE
5191 * casefiddle.c (casify_region): Remove var that is set but not used.
5192
a4db5dfe
PE
5193 * dired.c (file_name_completion): Remove var that is set but not used.
5194
43aae36e
PE
5195 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5196
2a47c44d 5197 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5198 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5199
a37c69bf
PE
5200 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5201 Check for integer overflow on size calculations.
5202
328ab8e7
PE
5203 * buffer.c (Fprevious_overlay_change): Remove var that is set
5204 but not used.
5205
e5a2a5cb
PE
5206 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5207 Remove vars that are set but not used.
8d84a6eb 5208 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5209 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5210
a60e5f68
PE
5211 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5212
f661cb61 5213 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5214 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5215
f0397f5a
PE
5216 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5217 that are set but not used.
5218
8664db06 5219 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5220 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5221
6abdaa4a
PE
5222 * xselect.c (x_get_local_selection, x_handle_property_notify):
5223 Remove vars that are set but not used.
5224
0ce7538d 5225 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5226 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5227
9ae848fc
PE
5228 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5229 Remove var that is set but not used.
0b918413
PE
5230 (scroll_bar_windows_size): Now size_t, not int.
5231 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5232 Check for overflow.
9ae848fc 5233
a5a62657
PE
5234 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5235 (map_tty_color) [!defined MSDOS]: Likewise.
5236
5c5cdd39
PE
5237 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5238
66ebf983
PE
5239 * coding.c: Remove vars that are set but not used.
5240 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5241 All callers changed.
5242 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5243 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5244 (decode_coding_charset): Remove vars that are set but not used.
5245
1be4d761
PE
5246 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5247 that is set but not used.
5248
47553fa8
PE
5249 * print.c (print_object): Remove var that is set but not used.
5250
1f7196bf 5251 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5252 The gnulib version avoids calling malloc in the usual case,
5253 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5254 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5255 * filelock.c (current_lock_owner): Likewise.
5256 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5257 * sysdep.c: Include allocator.h, careadlinkat.h.
5258 (emacs_no_realloc_allocator): New static constant.
5259 (emacs_readlink): New function.
fdb61804
PE
5260 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5261 ../lib/careadlinkat.h.
d1fdcab7 5262
f84c17c7
SM
52632011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5264
5265 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5266 first non-nil return value).
5267
ef3862ad
JD
52682011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5269
5270 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5271 if not defined (Bug#8403).
5272
376a7006
JB
52732011-04-02 Juanma Barranquero <lekktu@gmail.com>
5274
5275 * xdisp.c (display_count_lines): Remove parameter `start',
5276 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5277 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5278 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5279 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5280 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5281 and thereabouts. All callers changed.
5282 (get_per_char_metric): Remove parameter `f', unused since
5283 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5284
6ca3801d
JM
52852011-04-02 Jim Meyering <meyering@redhat.com>
5286
5287 do not dereference NULL upon failed strdup
5288 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5289 (ns_get_family): Likewise.
5290
d8e2b5ba
JB
52912011-04-02 Juanma Barranquero <lekktu@gmail.com>
5292
5293 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5294
8c74fcbd
JD
52952011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5296
5297 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5298 later (Bug#8403).
5299
7200d79c
SM
53002011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5301
03408648 5302 Add lexical binding.
7200d79c 5303
03408648
SM
5304 * window.c (Ftemp_output_buffer_show): New fun.
5305 (Fsave_window_excursion):
5306 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5307
5308 * lread.c (lisp_file_lexically_bound_p): New function.
5309 (Fload): Bind Qlexical_binding.
5310 (readevalloop): Remove `evalfun' arg.
5311 Bind Qinternal_interpreter_environment.
5312 (Feval_buffer): Bind Qlexical_binding.
5313 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5314 Mark as dynamic.
5315 (syms_of_lread): Declare `lexical-binding'.
5316
5317 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5318
5319 * keyboard.c (eval_dyn): New fun.
5320 (menu_item_eval_property): Use it.
ca105506
SM
5321
5322 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5323
03408648
SM
5324 * fns.c (concat, mapcar1): Accept byte-code-functions.
5325
5326 * eval.c (Fsetq): Handle lexical vars.
5327 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5328 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5329 (FletX, Flet): Obey lexical binding.
5330 (Fcommandp): Handle closures.
5331 (Feval): New `lexical' arg.
5332 (eval_sub): New function extracted from Feval. Use it almost
5333 everywhere where Feval was used. Look up vars in lexical env.
5334 Handle closures.
5335 (Ffunctionp): Move from subr.el.
5336 (Ffuncall): Handle closures.
5337 (apply_lambda): Remove `eval_flags'.
5338 (funcall_lambda): Handle closures and new byte-code-functions.
5339 (Fspecial_variable_p): New function.
5340 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5341 but without exporting it to Lisp.
23aba0ea 5342
23aba0ea 5343 * doc.c (Fdocumentation, store_function_docstring):
03408648 5344 * data.c (Finteractive_form): Handle closures.
23aba0ea 5345
03408648
SM
5346 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5347 interactive spec.
ba83908c 5348
04f2d78b
CB
5349 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5350 New byte-codes.
03408648
SM
5351 (exec_byte_code): New function extracted from Fbyte_code to handle new
5352 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5353
03408648 5354 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5355
03408648 5356 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5357
e2abce01
JB
53582011-03-31 Juanma Barranquero <lekktu@gmail.com>
5359
5360 * xdisp.c (redisplay_internal): Fix prototype.
5361
63696a73 53622011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5363
63696a73 5364 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5365 (try_scrolling): Use it when setting scroll_limit.
5366 Limit scrolling to 100 screen lines.
63696a73
EZ
5367 (redisplay_window): Even when falling back on "recentering",
5368 position point in the window according to scroll-conservatively,
5369 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5370
5371 (try_scrolling): When point is above the window, allow searching
5372 as far as scroll_max, or one screenful, to compute vertical
5373 distance from PT to the scroll margin position. This prevents
5374 try_scrolling from unnecessarily failing when
5375 scroll-conservatively is set to a value slightly larger than the
5376 window height. Clean up the case of PT below the margin at bottom
5377 of window: scroll_max can no longer be INT_MAX. When aggressive
5378 scrolling is in use, don't let point enter the opposite scroll
5379 margin as result of the scroll.
5380 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5381 threshold of 100 lines for never-recentering scrolling.
5382
e4cc2dfc
JB
53832011-03-31 Juanma Barranquero <lekktu@gmail.com>
5384
5385 * dispextern.h (move_it_by_lines):
5386 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5387 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5388 (message_log_check_duplicate): Remove parameters `prev_bol' and
5389 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5390 (redisplay_internal): Remove parameter `preserve_echo_area',
5391 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5392
5393 * indent.c (Fvertical_motion):
5394 * window.c (window_scroll_pixel_based, Frecenter):
5395 Don't pass `need_y_p' to `move_it_by_lines'.
5396
1c470562
SM
53972011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5398
44f230aa
SM
5399 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5400 steal a few bits to be more compact.
5401 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5402 Remove unneeded casts.
5403
1c470562
SM
5404 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5405
888adce9
ZK
54062011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5407
5408 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5409 binding" message (bug#7967).
5410
f838ed7b
PE
54112011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5412
77861b95
PE
5413 Fix more problems found by GCC 4.6.0's static checks.
5414
de6dbc14
PE
5415 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5416 Remove unused local var.
5417
f838ed7b
PE
5418 * editfns.c (Fmessage_box): Remove unused local var.
5419
792c7b2b
PE
5420 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5421 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5422 Omit unused local vars.
c499e557 5423 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5424 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5425 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5426 Omit unused local var.
5427
ba0165e1
PE
5428 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5429 Don't assume string length fits in int.
32ad8845 5430 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5431 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5432
3c59b4c9
PE
5433 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5434 instead of alloca (Bug#8344).
5435
a3eed478 5436 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5437 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5438
eb4d412d
PE
5439 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5440
1658b401
PE
5441 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5442 concerns.
5443
5444 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5445
5446 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5447
9a2c6e05
PE
5448 * keyboard.c (syms_of_keyboard): Use the same style as later
5449 in this function when indexing through an array. This also
5450 works around GCC bug 48267.
5451
03d0a109
PE
5452 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5453
44f730c8
PE
5454 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5455
fe75f926
PE
5456 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5457 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5458
ffa8c828
PE
5459 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5460 This avoids undefined behavior on integer overflow, and is a bit
5461 more convenient anyway since it is compared to a size_t variable.
5462
c5101a77
PE
5463 Variadic C functions now count arguments with size_t, not int.
5464 This avoids an unnecessary limitation on 64-bit machines, which
5465 caused (substring ...) to crash on large vectors (Bug#8344).
5466 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5467 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5468 All variadic functions and their callers changed accordingly.
c5101a77
PE
5469 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5470 * data.c (arith_driver, float_arith_driver): Likewise.
5471 * editfns.c (general_insert_function): Likewise.
5472 * eval.c (struct backtrace.nargs, interactive_p)
5473 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5474 (funcall_lambda, mark_backtrace): Likewise.
5475 * fns.c (concat): Likewise.
5476 * frame.c (x_set_frame_parameters): Likewise.
5477 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5478 0 if not found, not -1. All callers changed.
5479
dd3f25f7
PE
5480 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5481 (stack_copy_size): Now size_t, not int.
5482 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5483
461c2ab9
JB
54842011-03-28 Juanma Barranquero <lekktu@gmail.com>
5485
5486 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5487 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5488 All callers changed.
5489
5490 * lisp.h (multibyte_char_to_unibyte):
5491 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5492 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5493 * character.h (CHAR_TO_BYTE8):
5494 * cmds.c (internal_self_insert):
5495 * editfns.c (general_insert_function):
5496 * keymap.c (push_key_description):
5497 * search.c (Freplace_match):
5498 * xdisp.c (message_dolog, set_message_1): All callers changed.
5499
f6d62986
SM
55002011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5501
5502 * keyboard.c (safe_run_hook_funcall): New function.
5503 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5504 don't set the hook to nil, but remove the offending function instead.
5505 (Qcommand_hook_internal): Remove, unused.
5506 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5507 Vcommand_hook_internal.
5508
5509 * eval.c (enum run_hooks_condition): Remove.
5510 (funcall_nil, funcall_not): New functions.
5511 (run_hook_with_args): Call each function through a `funcall' argument.
5512 Remove `cond' argument, now redundant.
5513 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5514 (Frun_hook_with_args_until_failure): Adjust accordingly.
5515 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5516
1db5b1ad
JB
55172011-03-28 Juanma Barranquero <lekktu@gmail.com>
5518
5519 * dispextern.h (string_buffer_position): Remove declaration.
5520
5521 * print.c (strout): Remove parameter `multibyte', unused since
5522 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5523
5524 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5525 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5526 All callers changed.
5527
5528 * w32.c (_wsa_errlist): Use braces for struct initializers.
5529
5530 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5531 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5532 All callers changed.
5533 (string_buffer_position): Likewise. Also, make static (it's never
5534 used outside xdisp.c).
5535 (cursor_row_p): Remove parameter `w', unused since
5536 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5537 (decode_mode_spec): Remove parameter `precision', introduced during
5538 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5539 All callers changed.
5540
5ffb62aa
JD
55412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5542
5543 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5544
461c2ab9 55452011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5546
5547 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5548 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5549 (ns_update_auto_hide_menu_bar): New functions.
5550 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5551 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5552 ns_constrain_all_frames.
5553 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5554 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5555
5c380ffb
JD
55562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5557
5558 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5559
9af30bdf
GM
55602011-03-27 Glenn Morris <rgm@gnu.org>
5561
5562 * syssignal.h: Replace RETSIGTYPE with void.
5563 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5564 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5565 Replace SIGTYPE with void everywhere.
5566 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5567 * s/template.h (SIGTYPE): Remove commented out definition.
5568
e2abce01
JB
55692011-03-26 Eli Zaretskii <eliz@gnu.org>
5570
5571 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5572 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5573
f868cd8a
JB
55742011-03-26 Juanma Barranquero <lekktu@gmail.com>
5575
59eb0929
JB
5576 * w32.c (read_unc_volume): Use parameter `henum', instead of
5577 global variable `wget_enum_handle'.
5578
5579 * keymap.c (describe_vector): Remove parameters `indices' and
5580 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5581 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5582
f868cd8a
JB
5583 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5584
5585 * keyboard.c (timer_check): Remove parameter `do_it_now',
5586 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5587 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5588 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5589
5590 * keyboard.c (read_char):
5591 * w32menu.c (w32_menu_display_help):
5592 * xmenu.c (show_help_event, menu_help_callback):
5593 Adjust calls to `show_help_echo'.
5594
5595 * gtkutil.c (xg_maybe_add_timer):
5596 * keyboard.c (readable_events):
5597 * process.c (wait_reading_process_output):
5598 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5599
5600 * insdel.c (adjust_markers_gap_motion):
5601 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5602 (gap_left, gap_right): Don't call it.
5603
2ecf6fdb
CY
56042011-03-25 Chong Yidong <cyd@stupidchicken.com>
5605
5606 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5607 incurred during fontification.
5608
6b1f9ba4
JB
56092011-03-25 Juanma Barranquero <lekktu@gmail.com>
5610
5611 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5612 (DEFVAR_PER_BUFFER): Don't pass it.
5613
5614 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5615 (scrolling_window): Don't pass it.
5616
0f4a96b5
JB
56172011-03-25 Juanma Barranquero <lekktu@gmail.com>
5618
5619 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5620
5621 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5622 and `suffix'.
5623 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5624 of variables specific to SELinux and computation of `encoded_absname'.
5625
5626 * image.c (XPutPixel): Remove unused variable `height'.
5627
5628 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5629
5630 * unexw32.c (get_section_info): Remove unused variable `section'.
5631
5632 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5633 (system_process_attributes): Remove unused variable `sess'.
5634 (sys_read): Remove unused variable `err'.
5635
5636 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5637 (w32_wnd_proc): Remove unused variable `isdead'.
5638 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5639 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5640 (x_create_tip_frame): Remove unused variable `tem'.
5641
5642 * w32inevt.c (w32_console_read_socket):
5643 Remove unused variable `no_events'.
5644
5645 * w32term.c (x_draw_composite_glyph_string_foreground):
5646 Remove unused variable `width'.
5647
1149507c
JB
56482011-03-24 Juanma Barranquero <lekktu@gmail.com>
5649
5650 * w32term.c (x_set_glyph_string_clipping):
5651 Don't pass uninitialized region to CombineRgn.
5652
9c88f339
JB
56532011-03-23 Juanma Barranquero <lekktu@gmail.com>
5654
5655 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5656 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5657 (Fx_close_connection): Remove unused variable `i'.
5658
5659 * w32font.c (w32font_draw): Return number of glyphs.
5660 (w32font_open_internal): Remove unused variable `i'.
5661 (w32font_driver): Add missing initializer.
5662
5663 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5664 (fill_in_menu): Remove unused variable `items_added'.
5665
5666 * w32term.c (last_mouse_press_frame): Remove static global variable.
5667 (w32_clip_to_row): Remove unused variable `f'.
5668 (x_delete_terminal): Remove unused variable `i'.
5669
5670 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5671 (NOTHING): Remove unused static global variable.
5672 (uniscribe_check_otf): Remove unused variable `table'.
5673 (uniscribe_font_driver): Add missing initializers.
5674
dee091a3
JD
56752011-03-23 Julien Danjou <julien@danjou.info>
5676
5677 * term.c (Fsuspend_tty, Fresume_tty):
5678 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5679 * window.c (temp_output_buffer_show):
5680 * insdel.c (signal_before_change):
5681 * frame.c (Fhandle_switch_frame):
5682 * fileio.c (Fdo_auto_save):
5683 * emacs.c (Fkill_emacs):
5684 * editfns.c (save_excursion_restore):
5685 * cmds.c (internal_self_insert):
5686 * callint.c (Fcall_interactively):
5687 * buffer.c (Fkill_all_local_variables):
5688 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5689 Use Frun_hooks.
0f4a96b5 5690 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5691 unconditionnaly since it does the check itself.
5692
2c520ab5 56932011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5694
c9c49752
PE
5695 Fix more problems found by GCC 4.5.2's static checks.
5696
8abc3f12
PE
5697 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5698 the first time through the loop, since we know p0 < p1 then.
5699 This also avoids a gcc -Wstrict-overflow warning.
5700
a2d26660
PE
5701 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5702 leading to a memory leak, possible in functions like
5703 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5704 of objects (Bug#8318).
a2d26660 5705
916c72e9
PE
5706 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5707 that could (at least in theory) be that large.
5708
19ab8a18
PE
5709 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5710 This is less likely to overflow, and avoids undefined behavior if
5711 overflow does occur. All callers changed. Use strtoul to scan
5712 for the unsigned long integer.
b7cbbd6f
PE
5713 (pint2hrstr): Simplify and tune code slightly.
5714 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5715
f0641eff
PE
5716 * scroll.c (do_scrolling): Work around GCC bug 48228.
5717 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5718
7f650bb9
PE
5719 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5720 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5721 (validate_x_resource_name): Simplify count usage.
5722 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5723
37dd57d1
PE
5724 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5725 fail (Bug#8306).
81e56e61 5726
699979fc 5727 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5728
401bf9b4
PE
5729 * process.c (Fmake_network_process): Use socklen_t, not int,
5730 where POSIX says socklen_t is required in portable programs.
5731 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5732 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5733 (Fmake_network_process, server_accept_connection):
5734 (wait_reading_process_output, read_process_output):
5735 Likewise.
5736
b93aacde
PE
5737 * process.c: Rename or move locals to avoid shadowing.
5738 (list_processes_1, Fmake_network_process):
5739 (read_process_output_error_handler, exec_sentinel_error_handler):
5740 Rename or move locals.
4dc343ee 5741 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5742 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5743 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5744 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5745 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5746
af8a867c 5747 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5748 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5749 Include tparam.h instead, since it declares them.
af8a867c
PE
5750 * cm.h (PC): Remove extern decl; tparam.h now does this.
5751 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5752 * terminfo.c: Include tparam.h, to check interfaces.
5753 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5754 (tparam): Adjust signature to match interface in tparam.h;
5755 this removes some undefined behavior. Check that outstring and len
5756 are zero, which they always are with Emacs.
5757 * tparam.h (PC, BC, UP): New extern decls.
5758
0248044d 5759 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5760 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5761
8ff096c1 5762 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5763 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5764 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5765 (ftfont_list): Remove unused local.
49eaafba
PE
5766 (get_adstyle_property, ftfont_pattern_entity):
5767 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5768 Rename locals to avoid shadowing.
8ff096c1 5769
e2be39f6
PE
5770 * xfont.c (xfont_list_family): Mark var as initialized.
5771
c9735e30
PE
5772 * xml.c (make_dom): Now static.
5773
8f5201ae
PE
5774 * composite.c (composition_compute_stop_pos): Rename local to
5775 avoid shadowing.
b246f932
PE
5776 (composition_reseat_it): Remove unused locals.
5777 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5778 (composition_update_it): Mark var as initialized.
11b61122
PE
5779 (find_automatic_composition): Mark vars as initialized,
5780 with a FIXME (Bug#8290).
8f5201ae 5781
760fbc2c
PE
5782 character.h: Rename locals to avoid shadowing.
5783 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5784 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5785 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5786 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5787 to avoid shadowing.
5788
ff08eb85
PE
5789 * textprop.c (property_change_between_p): Remove; unused.
5790
fc7bf025
PE
5791 * intervals.c (interval_start_pos): Now static.
5792
235d7abc
PE
5793 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5794
44f230aa
SM
5795 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5796 Rename locals to avoid shadowing.
3e7d6594 5797
50060332
PE
5798 * sound.c (wav_play, au_play, Fplay_sound_internal):
5799 Fix pointer signedness.
d01f234b 5800 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5801 (wav_play): Initialize a variable to 0, to prevent undefined
5802 behavior (Bug#8278).
50060332 5803
c4fc4e30
PE
5804 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5805
918436ed
PE
5806 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5807
c939f91b
PE
5808 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5809 clobbering (Bug#8298).
b9c7f648
PE
5810 * sysdep.c (sys_subshell): Likewise.
5811 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5812
6bd8c144
PE
5813 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5814 This should get cleaned up, so that child_setup has the
5815 same signature on all platforms.
5816
7710357c 5817 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5818 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5819
c59da222
CY
58202011-03-22 Chong Yidong <cyd@stupidchicken.com>
5821
5822 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5823 not to be necessary, and produces flickering.
5824
66b87493
GM
58252011-03-20 Glenn Morris <rgm@gnu.org>
5826
5827 * config.in: Remove file.
5828
45b6f6d5
JB
58292011-03-20 Juanma Barranquero <lekktu@gmail.com>
5830
5831 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5832 are now in src/globals.h.
5833 (syms_of_minibuf): Remove spurious & from previous change.
5834
3ec03f7e
LL
58352011-03-20 Leo <sdl.web@gmail.com>
5836
5837 * minibuf.c (completing-read-function): New variable.
5838 (completing-read-default): Rename from completing-read.
5839 (completing-read): Call completing-read-function.
5840
b14e3e21
CY
58412011-03-19 Juanma Barranquero <lekktu@gmail.com>
5842
5843 * xfaces.c (Fx_load_color_file):
5844 Read color file from absolute filename (bug#8250).
5845
f2b726e6
JB
58462011-03-19 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * makefile.w32-in: Update dependencies.
5849
09f6ff02
EZ
58502011-03-17 Eli Zaretskii <eliz@gnu.org>
5851
5852 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5853
29a6015a
PE
58542011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5855
a3a6c54e
PE
5856 Fix more problems found by GCC 4.5.2's static checks.
5857
b766f867
PE
5858 * process.c (make_serial_process_unwind, send_process_trap):
5859 (sigchld_handler): Now static.
5860
be02381c
PE
5861 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5862 That way, the code declares only the vars that it needs.
5863 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5864 * s/cygwin.h (PTY_ITERATION): Likewise.
5865 * s/darwin.h (PTY_ITERATION): Likewise.
5866 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5867
57048744
PE
5868 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5869 * process.c (allocate_pty): Don't declare stb unless it's needed.
5870
7914961c 5871 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5872 (CONSTANTLIM): Remove; unused.
5873 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5874 Define only if needed.
7914961c 5875
b3967b18
PE
5876 * unexelf.c (unexec): Name an expression,
5877 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5878 Use a different way to cause a compilation error if anyone uses
5879 n rather than nn, a way that does not involve shadowing.
73366a00 5880 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5881
29a6015a
PE
5882 * deps.mk (unexalpha.o): Remove; unused.
5883
43cfc33e 5884 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5885 * unexec.h: New file.
ce701a33
PE
5886 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5887 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5888 Depend on unexec.h.
5889 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5890 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5891 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5892 Change as necessary to match prototype in unexec.h.
ce701a33 5893
01f44d5a
PE
5894 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5895 shadowing.
4f63c6bb 5896 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5897
a6670b0b
PE
5898 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5899 Rename locals to avoid shadowing.
5900
cef2010d 5901 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5902 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5903
d4d7173a
PE
5904 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5905
f08b802a
PE
5906 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5907 warning when compiling print.c.
5908
3ddb0639
PE
5909 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5910 instead of using an uninitialized var.
5ad03b97 5911 (font_sort_entities): Mark var as initialized.
3ddb0639 5912
170a2692
PE
5913 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5914
e663c700
PE
5915 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5916 pointers to constants.
89bc529a 5917 (font_parse_fcname): Remove unused vars.
7b81e2d0 5918 (font_delete_unmatched): Now static.
ea838e10 5919 (font_get_spec): Remove; unused.
13a547c6
PE
5920 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5921 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5922 Rename or move locals to avoid shadowing.
e663c700 5923
2a80c887 5924 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5925 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5926
1384fa33 5927 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5928 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5929
8b2c52e9
PE
5930 * alloc.c (mark_backtrace): Move decl from here ...
5931 * lisp.h: ... to here, so that it can be checked.
5932
475545b5 5933 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5934 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5935 (lisp_indirect_variable): Name an expression,
5936 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5937 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5938
b1349114 5939 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5940 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5941 Use const pointer when appropriate.
b1349114 5942
a2928364
PE
5943 * lisp.h (get_system_name, get_operating_system_release):
5944 Move decls here, to check interfaces.
5945 * process.c (get_operating_system_release): Move decl to lisp.h.
5946 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5947 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5948 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5949 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5950 (Fformat_time_string, Fencode_time, Finsert_char):
5951 (Ftranslate_region_internal, Fformat):
5952 Rename or remove local vars to avoid shadowing.
9710023e 5953 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5954
a415e694
PE
5955 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5956 avoid shadowing.
5957
8ef4622d
PE
5958 * lisp.h (eassert): Check that the argument compiles, even if
5959 ENABLE_CHECKING is not defined.
5960
946f9a5b
PE
5961 * data.c (Findirect_variable): Name an expression, to avoid
5962 gcc -Wbad-function-cast warning.
112396d6 5963 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5964 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5965 (Fmake_variable_buffer_local, Fmake_local_variable):
5966 Mark variables as initialized.
52746918 5967 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5968
e5aab7e7 5969 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5970 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5971 Rename locals to avoid shadowing.
dff45157
PE
5972 (mark_stack): Move local variables into the #ifdef region where
5973 they're used.
7bc26fdb
PE
5974 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5975 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5976 needed otherwise.
5977 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5978 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5979 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5980
e5aab7e7
PE
5981 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5982 avoids undefined behavior in theory.
5983
4da60324
PE
5984 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5985
88043301
PE
5986 Use functions, not macros, for up- and down-casing (Bug#8254).
5987 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5988 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5989 to use the following functions instead of these macros.
5990 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5991 EMACS_INT, since callers assume the returned value fits in int.
5992 (upcase1): Likewise, for UPCASE_TABLE.
5993 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5994 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5995 the race-condition problem in the old DOWNCASE.
88043301 5996
19ed5445
PE
5997 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5998 Rename locals to avoid shadowing.
5999 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6000 (regex_compile, re_search_2, re_match_2_internal):
6001 Remove unused local vars.
952db0d7
PE
6002 (FREE_VAR): Rewrite so as not to use empty "else",
6003 which gcc can warn about.
da053e48 6004 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6005 (RETALLOC_IF): Define only if needed.
6006 (WORDCHAR_P): Likewise. This one is never needed, but is used
6007 only in a comment talking about a compiler bug, so put inside
6008 the #if 0 of that comment.
6009 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6010 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6011 Remove; unused.
19ed5445 6012
1f3561e4 6013 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6014 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6015 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6016
ded6f8f7
PE
6017 * search.c (simple_search): Remove unused var.
6018
dbd37a95
PE
6019 * dired.c (compile_pattern): Move decl from here ...
6020 * lisp.h: ... to here, so that it can be checked.
6021 (struct re_registers): New forward decl.
6022
7e47afad
PE
6023 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6024
85f24f61
PE
6025 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6026 All uses changed.
6027 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6028 Rename locals to avoid shadowing.
5671df8f 6029 (Fvertical_motion): Mark locals as initialized.
85f24f61 6030
181aa2be 6031 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6032 (casify_region): Mark local as initialized.
181aa2be 6033
930d429c
PE
6034 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6035
7082eac6
PE
6036 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6037 New macros, so that the caller can use some names other than
6038 gcpro1, gcpro2, etc.
6039 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6040 of the new macros.
6041 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6042 argument, for consistency with GCPRO2_VAR, etc: it is now the
6043 prefix of the variable, not the variable itself. All uses
6044 changed.
38b2c076
PE
6045 * dired.c (directory_files_internal, file_name_completion):
6046 Rename locals to avoid shadowing.
6047
15206ed9
PE
6048 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6049 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6050 dired.c's scmp function, had undefined behavior.
6051 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6052 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6053 * buffer.h: ... to here, because these macros use current_buffer,
6054 and the new implementation with inline functions needs to have
6055 current_buffer in scope now, rather than later when the macros
6056 are used.
6057 (downcase, upcase1): New static inline functions.
6058 (DOWNCASE, UPCASE1): Reimplement using these functions.
6059 This avoids undefined behavior in expressions like
6060 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6061 from race conditions in accessing the global variables
6062 case_temp1 and case_temp2.
6063 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6064 * lisp.h (case_temp1, case_temp2): Remove their decls.
6065 * character.h (ASCII_CHAR_P): Move from here ...
6066 * lisp.h: ... to here, so that the inline functions mentioned
6067 above can use them.
6068
4a6bea26
PE
6069 * dired.c (directory_files_internal_unwind): Now static.
6070
f14b7e14
PE
6071 * fileio.c (file_name_as_directory, directory_file_name):
6072 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6073 Now static.
2893f146
PE
6074 (file_name_as_directory): Use const pointers when appropriate.
6075 (Fexpand_file_name): Likewise. In particular, newdir might
6076 point at constant storage, so make it a const pointer.
fd4ead52 6077 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6078 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6079 signedness issues.
f839df0c
PE
6080 (Fset_file_times, Finsert_file_contents, auto_save_error):
6081 Rename locals to avoid shadowing.
f14b7e14 6082
5716756e 6083 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6084 (Ftry_completion, Fall_completions): Rename or remove locals
6085 to avoid shadowing.
5716756e 6086
b4c3046a
PE
6087 * marker.c (bytepos_to_charpos): Remove; unused.
6088
b45db522
PE
6089 * lisp.h (verify_bytepos, count_markers): New decls,
6090 so that gcc does not warn that these functions aren't declared.
6091
85876d07
PE
6092 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6093 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6094 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6095 (copy_text): Remove unused local var.
85876d07 6096
03d78a21 6097 * filelock.c (within_one_second): Now static.
b3dd38ab 6098 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6099
5df8f01b
PE
6100 * buffer.c (fix_overlays_before): Mark locals as initialized.
6101 (fix_start_end_in_overlays): Likewise. This function should be
6102 simplified by using pointers-to-pointers, but that's a different
6103 matter.
b1d876f1 6104 (switch_to_buffer_1): Now static.
8f54f30a
PE
6105 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6106 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6107
a70072c9 6108 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6109 Fix pointer signedness issue.
edced198
PE
6110 (sys_subshell): Mark local as volatile if checking for lint,
6111 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6112 (MAXPATHLEN): Define only if needed.
a70072c9 6113
a0977c44
PE
6114 * process.c (serial_open, serial_configure): Move decls from here ...
6115 * systty.h: ... to here, so that they can be checked.
6116
a884fdcc
PE
6117 * fns.c (get_random, seed_random): Move extern decls from here ...
6118 * lisp.h: ... to here, so that they can be checked.
6119
604efe86 6120 * sysdep.c (reset_io): Now static.
b8950c94 6121 (wait_for_termination_signal): Remove; unused.
604efe86 6122
38fc62d9
PE
6123 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6124 (copy_keymap_item, append_key, push_text_char_description):
6125 Now static.
1004a21a 6126 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6127 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6128 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6129 (describe_map_tree):
6130 Rename locals to avoid shadowing.
38fc62d9 6131
2f2650da
PE
6132 * keyboard.c: Declare functions static if they are not used elsewhere.
6133 (echo_char, echo_dash, cmd_error, top_level_2):
6134 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6135 (read_char, kbd_buffer_get_event, make_lispy_position):
6136 (make_lispy_event, make_lispy_movement, apply_modifiers):
6137 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6138 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6139 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6140 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6141 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6142
a053e86c 6143 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6144 (mark_kboards): Move decl here ...
6145 * alloc.c (mark_kboards): ... from here.
a053e86c 6146
4752793e
PE
6147 * lisp.h (force_auto_save_soon): New decl.
6148
74f10ca7 6149 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6150 (DEFINE_DUMMY_FUNCTION): New macro.
6151 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6152 Use it.
c03cd23f
PE
6153 (main): Add casts to avoid warnings
6154 if GCC considers string literals to be constants.
74f10ca7 6155
022e70d4
PE
6156 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6157
59d6fe83
PE
6158 * dbusbind.c: Pointer signedness fixes.
6159 (xd_signature, xd_append_arg, xd_initialize):
6160 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6161 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6162 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6163 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6164
78320123
PE
6165 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6166 if GCC considers string literals to be constants.
49cebcca 6167 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6168
35ac2a97
SM
61692011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6170
fb103ca9
SM
6171 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6172 (print_preprocess, print_object): New macro to fix last change.
6173
35ac2a97
SM
6174 * print.c (print_preprocess): Don't forget font objects.
6175
62973b41
JB
61762011-03-16 Juanma Barranquero <lekktu@gmail.com>
6177
6178 * emacs.c (USAGE3): Doc fixes.
6179
0e48bb22
AS
61802011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6181
6182 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6183 structure.
6184
7684e57b
JB
61852011-03-14 Juanma Barranquero <lekktu@gmail.com>
6186
6187 * lisp.h (VWindow_system, Qfile_name_history):
6188 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6189 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6190 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6191
6192 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6193 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6194
6195 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6196 * w32console.c (detect_input_pending, read_input_pending)
6197 (encode_terminal_code):
6198 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6199 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6200 (w32_system_caret_y, Qfile_name_history):
6201 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6202 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6203 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6204 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6205 * w32proc.c (Qlocal, report_file_error):
6206 * w32term.c (Vwindow_system, updating_frame):
6207 * w32uniscribe.c (initialized, uniscribe_font_driver):
6208 Remove unneeded extern declarations.
6209
2aa46d6c
CY
62102011-03-14 Chong Yidong <cyd@stupidchicken.com>
6211
c96bbc66 6212 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6213
cffc6f3b
CY
62142011-03-13 Chong Yidong <cyd@stupidchicken.com>
6215
6216 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6217 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6218 These macros can no longer be used for assignment.
6219
44f230aa
SM
6220 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6221 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6222 (record_buffer_markers, fetch_buffer_markers): New functions for
6223 recording and fetching special buffer markers.
6224 (set_buffer_internal_1, set_buffer_temp): Use them.
6225
6226 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6227
6228 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6229
6230 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6231 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6232
6233 * xdisp.c (hscroll_window_tree):
6234 (reconsider_clip_changes): Use PT instead of BUF_PT.
6235
d251f04b
EZ
62362011-03-13 Eli Zaretskii <eliz@gnu.org>
6237
6238 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6239 $(EMACS_ROOT)/lib/intprops.h.
6240
f0c77cd1
PE
62412011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6242
3eca4629
PE
6243 Fix more problems found by GCC 4.5.2's static checks.
6244
7c86ee98
PE
6245 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6246 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6247 (xg_free_frame_widgets): Make it clear that a local variable is
6248 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6249 (gdk_window_get_screen): Make it clear that this macro is needed
6250 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6251 (int_gtk_range_get_value): New function, which avoids a diagnostic
6252 from gcc -Wbad-function-cast.
6253 (xg_set_toolkit_scroll_bar_thumb): Use it.
6254 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6255 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6256 (get_utf8_string, xg_get_file_with_chooser):
6257 Rename locals to avoid shadowing.
6258 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6259
41729b81
PE
6260 * xgselect.c (xg_select): Remove unused var.
6261
f0c77cd1
PE
6262 * image.c (four_corners_best): Mark locals as initialized.
6263 (gif_load): Initialize transparent_p to zero (Bug#8238).
6264 Mark another local as initialized.
ec6cf4c6 6265 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6266
ce0ad53d 6267 * image.c (clear_image_cache): Now static.
d5d5a617 6268 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6269 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6270 (x_edge_detection): Remove unnecessary cast that
6271 gcc -Wbad-function-cast diagnoses.
2037898d 6272 (gif_load): Fix pointer signedness.
6ae141d6
PE
6273 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6274 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6275
33383987 62762011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6277
d32df629
PE
6278 Improve quality of tests for time stamp overflow.
6279 For example, without this patch (encode-time 0 0 0 1 1
6280 1152921504606846976) returns the obviously-bogus value (-948597
6281 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6282 reports time overflow. See
6283 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6284 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6285 * editfns.c: Include limits.h and intprops.h.
6286 (TIME_T_MIN, TIME_T_MAX): New macros.
6287 (time_overflow): Move earlier, to before first use.
6288 (hi_time, lo_time): New functions, for an accurate test for
6289 out-of-range times.
6290 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6291 (Fget_internal_run_time): Don't assume time_t fits in int.
6292 (make_time): Use list2 instead of Fcons twice.
6293 (Fdecode_time): More accurate test for out-of-range times.
6294 (check_tm_member): New function.
6295 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6296 (lisp_time_argument): Don't rely on undefined left-shift and
6297 right-shift behavior when checking for time stamp overflow.
8be6f318 6298
fe31d94c
PE
6299 * editfns.c (time_overflow): New function, refactoring common code.
6300 (Fformat_time_string, Fdecode_time, Fencode_time):
6301 (Fcurrent_time_string): Use it.
6302
8be6f318
PE
6303 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6304 * dired.c (make_time): Move to ...
6305 * editfns.c (make_time): ... here.
6306 * systime.h: Note the move.
6307
09d9db2c 63082011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6309
126bc0dc
YM
6310 * fringe.c (update_window_fringes): Remove unused variables.
6311
c47cbdfd
YM
6312 * unexmacosx.c (copy_data_segment): Also copy __got section.
6313 (Bug#8223)
6314
7ac80be9
EZ
63152011-03-12 Eli Zaretskii <eliz@gnu.org>
6316
c96bbc66 6317 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6318 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6319 Constify `char *' arguments and their references according to
6320 prototypes in tparam.h.
6321
ecb0f94d 6322 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6323
7ac80be9
EZ
6324 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6325 Adapt all references accordingly.
6326
6327 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6328
ef1fd07e
TT
63292011-03-11 Tom Tromey <tromey@redhat.com>
6330
6331 * buffer.c (syms_of_buffer): Remove obsolete comment.
6332
7ef4b50c
EZ
63332011-03-11 Eli Zaretskii <eliz@gnu.org>
6334
6335 * termhooks.h (encode_terminal_code): Declare prototype.
6336
6337 * msdos.c (encode_terminal_code): Don't declare prototype.
6338
6339 * term.c (encode_terminal_code): Now external again, used by
6340 w32console.c and msdos.c.
6341
44f230aa
SM
6342 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6343 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6344
4b1ec863 63452011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6346
1714f52b 6347 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6348
4b1ec863
PE
6349 * fringe.c (update_window_fringes): Mark locals as initialized
6350 (Bug#8227).
6351 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6352
524c7aa6
PE
6353 * alloc.c (mark_fringe_data): Move decl from here ...
6354 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6355 to check its interface.
6356 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6357
a5c0af81 6358 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6359 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6360 (fontset_font): Mark local as initialized.
a9a06e0b 6361 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6362
b4716021
PE
6363 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6364
811e9bac 6365 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6366 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6367 (x_own_selection, Fx_disown_selection_internal): Rename locals
6368 to avoid shadowing.
6369 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6370
7e3ab302
PE
6371 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6372 so that the caller can use some name other than gcpro1.
6373 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6374 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6375 (Fx_backspace_delete_keys_p):
6376 Use them to avoid shadowing, and rename vars to avoid shadowing.
6377 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6378 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6379 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6380 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6381 Remove unused locals.
7e3ab302
PE
6382 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6383 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6384 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6385 macros.
f78faa98 6386
e2b13473
PE
6387 * xterm.h (x_mouse_leave): New decl.
6388
77f23912
PE
6389 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6390 Remove unused functions.
cdf4ba58
PE
6391 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6392 (x_calc_absolute_position): Now static.
7411c686 6393 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6394 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6395 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6396 unless they are used.
38d0b34a
PE
6397 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6398 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6399 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6400 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6401 (x_error_catcher, x_connection_closed, x_error_handler):
6402 (x_error_quitter, xembed_send_message, x_iconify_frame):
6403 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6404 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6405 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6406
44f230aa
SM
6407 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6408 Rename or move locals to avoid shadowing.
6b463e58 6409 (tty_defined_color, merge_face_heights): Now static.
5967d051 6410 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6411 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6412 does not deduce is never used uninitialized.
73719eba
PE
6413 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6414 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6415
426994c3 6416 * terminal.c (store_terminal_param): Now static.
5489860b 6417
032f1620 6418 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6419 (set_frame_menubar): Remove unused local.
d4323972 6420 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6421 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6422 since they might point to immutable storage.
281585b0
PE
6423 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6424 since it's unused otherwise.
032f1620 6425
367c19e5 6426 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6427 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6428 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6429 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6430 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6431 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6432 does not deduce are never used uninitialized.
70739cbe 6433
07b48fa9
PE
6434 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6435
8868a238 6436 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6437 * window.c (window_loop, size_window):
6438 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6439
7e5cf297 6440 * window.c (display_buffer): Now static.
d6550a9f
PE
6441 (size_window): Mark variables that gcc -Wuninitialized
6442 does not deduce are never used uninitialized.
a586633d
PE
6443 * window.h (check_all_windows): New decl, to forestall
6444 gcc -Wmissing-prototypes diagnostic.
5b555da1 6445 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6446
f6095868
PE
6447 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6448 shadowing.
6449 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6450 Include <limits.h>.
6451 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6452 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6453 (load_charset_map): Mark variables that gcc -Wuninitialized
6454 does not deduce are never used uninitialized.
53df7c11 6455 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6456
f38b440c
PE
6457 * coding.c (coding_set_source, coding_set_destination):
6458 Use "else { /* comment */ }" rather than "else /* comment */;"
6459 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6460 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6461 a block, when the outer 'i' will do.
6462 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6463 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6464 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6465 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6466 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6467 Rename locals to avoid shadowing.
6468 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6469 * coding.c (emacs_mule_char, encode_invocation_designation):
6470 Now static, since they're not used elsewhere.
413bb2db 6471 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6472 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6473 (decode_coding_emacs_mule): Mark variables that gcc
6474 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6475 (detect_coding_iso_2022): Initialize a local variable that might
6476 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6477 this initialization is needed. (Bug#8211)
5f58e762
PE
6478 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6479 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6480 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6481 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6482 Remove unused macros.
f38b440c 6483
232b38b9 6484 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6485 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6486 * character.c (string_count_byte8): Likewise.
232b38b9 6487
fb90da1b
PE
6488 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6489 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6490
fb93dbc2
PE
6491 * chartab.c (copy_sub_char_table): Now static, since it's not used
6492 elsewhere.
5c156ace
PE
6493 (sub_char_table_ref_and_range, char_table_ref_and_range):
6494 Rename locals to avoid shadowing.
bbcd0949 6495 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6496
7d3b3862 6497 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6498 (BIDI_BOB): Remove unused macro.
7d3b3862 6499
6be7d3da
PE
6500 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6501 deduce are never used uninitialized.
c2ed9c8b 6502 * term.c (encode_terminal_code): Likewise.
6be7d3da 6503
75f8807f 6504 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6505
50938595
PE
6506 * tparam.h: New file.
6507 * term.c, tparam.h: Include it.
6508 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6509 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6510 Move these decls to tparam.h, and make them agree with what
6511 is actually in tparam.c. The previous trick of using incompatible
6512 decls in different modules does not conform to the C standard.
6513 All callers of tparam changed to use tparam's actual API.
6514 * tparam.c (tparam1, tparam, tgoto):
6515 Use const pointers where appropriate.
6516
fbceeba2
PE
6517 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6518 * cm.h (struct cm): Likewise.
6519 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6520 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6521 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6522 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6523 (turn_on_face, init_tty): Likewise.
6524 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6525
7f3f1250
PE
6526 * term.c (term_mouse_position): Rename local to avoid shadowing.
6527
e6ca6543
PE
6528 * alloc.c (mark_ttys): Move decl from here ...
6529 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6530
c40f8d15
AS
65312011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6532
6533 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6534
cfe0661d
JB
65352011-03-09 Juanma Barranquero <lekktu@gmail.com>
6536
6537 * search.c (compile_pattern_1): Remove argument regp, unused since
6538 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6539 (compile_pattern): Don't pass it.
6540
0afb4571
J
65412011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6542
6543 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6544 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6545 for ! HAVE_GTK3.
6546 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6547
6548 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6549
6550 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6551 gdk_window_get_screen, gdk_window_get_geometry,
6552 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6553 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6554 (xg_get_pixbuf_from_pixmap): New function.
6555 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6556 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6557 Call xg_get_pixbuf_from_pixmap instead of
6558 gdk_pixbuf_get_from_drawable.
6559 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6560 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6561 (xg_check_special_colors): Use GtkStyleContext and its functions
6562 for HAVE_GTK3.
6563 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6564 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6565 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6566 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6567 Call gtk_widget_get_preferred_size.
0afb4571
J
6568 (xg_frame_resized): gdk_window_get_geometry only takes 5
6569 parameters.
44f230aa
SM
6570 (xg_win_to_widget, xg_event_is_for_menubar):
6571 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6572 (xg_set_widget_bg): New function.
6573 (delete_cb): New function.
895009e1 6574 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6575 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6576 (xg_set_background_color): Call xg_set_widget_bg.
6577 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6578 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6579 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6580 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6581 if ! HAVE_GTK3.
6582 (update_frame_tool_bar): Call gtk_widget_hide.
6583 (xg_initialize): Use GDK_KEY_g.
6584
6585 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6586 if ! HAVE_GTK3
6587 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6588
6589 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6590 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6591 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6592
1c2cc4ef
JB
65932011-03-08 Juanma Barranquero <lekktu@gmail.com>
6594
6595 * w32xfns.c (select_palette): Check success of RealizePalette against
6596 GDI_ERROR, not zero.
6597
33383987 6598See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6599
6600;; Local Variables:
6601;; coding: utf-8
aac0c6e3
MR
6602;; End:
6603
33383987 6604 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6605
6606 This file is part of GNU Emacs.
6607
6608 GNU Emacs is free software: you can redistribute it and/or modify
6609 it under the terms of the GNU General Public License as published by
6610 the Free Software Foundation, either version 3 of the License, or
6611 (at your option) any later version.
6612
6613 GNU Emacs is distributed in the hope that it will be useful,
6614 but WITHOUT ANY WARRANTY; without even the implied warranty of
6615 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6616 GNU General Public License for more details.
6617
6618 You should have received a copy of the GNU General Public License
6619 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.