Add PROBLEMS entry for X clipboard managers slowing down exit
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9486df08
CY
12012-02-24 Chong Yidong <cyd@gnu.org>
2
3 * keyboard.c (process_special_events): Handle all X selection
4 requests in kbd_buffer, not just the next one (Bug#8869).
5
f01d3321
CY
62012-02-23 Chong Yidong <cyd@gnu.org>
7
8 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9 call when setting menu-bar-lines and tool-bar-lines parameters.
10 (unwind_create_frame_1): New helper function.
11
12 * window.c (inhibit_window_configuration_change_hook): New var.
13 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 14 (syms_of_window): Initialize it.
f01d3321 15
86b847b6
CY
162012-02-22 Chong Yidong <cyd@gnu.org>
17
18 * xterm.c (x_draw_image_relief): Add missing type check for
19 Vtool_bar_button_margin (Bug#10743).
20
a59225b1
CY
212012-02-21 Chong Yidong <cyd@gnu.org>
22
23 * fileio.c (Vfile_name_handler_alist): Doc fix.
24
25 * buffer.c (Fget_file_buffer): Protect against invalid file
26 handler return value.
27
310f5bd4
PE
282012-02-20 Paul Eggert <eggert@cs.ucla.edu>
29
cb3a28cc
PE
30 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
31 when computing $valmask.
32
310f5bd4
PE
33 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
34 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
35 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
36 It's useless in that case, and it can cause problems on hosts
37 that allocate halves of EMACS_INT values separately.
38 Reported by Dan Horák. Diagnosed by Andreas Schwab in
39 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
40 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
41 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
42 it avoids undefined behavior on hosts where shifting right by more
43 than the word width has undefined behavior.
44
2375c96a
CY
452012-02-19 Chong Yidong <cyd@gnu.org>
46
47 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
48 (Funhandled_file_name_directory, Ffile_name_as_directory)
49 (Fdirectory_file_name, Fexpand_file_name)
50 (Fsubstitute_in_file_name): Protect against invalid file handler
51 return values (Bug#10845).
52
3eb49e71
EZ
532012-02-18 Eli Zaretskii <eliz@gnu.org>
54
55 * .gdbinit (pitx): Fix incorrect references to fields of the
56 iterator stack.
57
7b926f3f
CY
582012-02-17 Chong Yidong <cyd@gnu.org>
59
60 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
61
11273115
PE
622012-02-15 Paul Eggert <eggert@cs.ucla.edu>
63
64 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
65 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
66
c3a70e2b
CY
672012-02-15 Chong Yidong <cyd@gnu.org>
68
69 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
70 marked as special. Also, starting docstrings with * is obsolete.
71
0ca43699
AS
722012-02-13 Andreas Schwab <schwab@linux-m68k.org>
73
74 * gnutls.c (emacs_gnutls_write): Fix last change.
75
2e8f3c56
LI
762012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
77
78 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
79 send_process.
80
af70074f
SM
812012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
82
83 * keymap.c (Fsingle_key_description): Handle char ranges.
84
95986d52
CY
852012-02-12 Chong Yidong <cyd@gnu.org>
86
afd83bd1
CY
87 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
88 as that creates a dangerous corner case.
89
95986d52
CY
90 * window.c (Fdelete_window_internal): Invalidate the mouse
91 highlight (Bug#9904).
92
bd7da63e
GM
932012-02-12 Glenn Morris <rgm@gnu.org>
94
95 * xselect.c (Fx_own_selection_internal)
96 (Fx_get_selection_internal, Fx_disown_selection_internal)
97 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
98 * nsselect.m (Fx_own_selection_internal)
99 (Fx_disown_selection_internal, Fx_selection_exists_p)
100 (Fx_selection_owner_p, Fx_get_selection_internal):
101 Sync docs and argument specs with the xselect.c versions.
102
77abcbc2
LI
1032012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
104
105 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
106
90b671e2
EZ
1072012-02-11 Eli Zaretskii <eliz@gnu.org>
108
1c0ca0b7
EZ
109 * w32select.c (Fx_selection_exists_p): Sync doc string and
110 argument list with xselect.c. (Bug#10783)
111
112 * w16select.c (Fx_selection_exists_p): Sync doc string and
113 argument list with xselect.c. (Bug#10783)
90b671e2 114
49241268
GM
1152012-02-10 Glenn Morris <rgm@gnu.org>
116
117 * fns.c (Fsecure_hash): Doc fix.
118
f998bbe7 1192012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
120
121 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
122
0992bd9c
CY
1232012-02-07 Chong Yidong <cyd@gnu.org>
124
125 * buffer.c (Fbuffer_local_variables)
126 (buffer_lisp_local_variables): Handle unbound vars correctly;
127 don't let Qunbound leak into Lisp.
128
af008560
GM
1292012-02-07 Glenn Morris <rgm@gnu.org>
130
dd605cc4
GM
131 * image.c (Fimagemagick_types): Doc fix.
132
af008560
GM
133 * image.c (imagemagick-render-type): Change it from a lisp object
134 to an integer. Move the doc here from the lisp manual.
135 Treat all values not equal to 0 the same.
136
1449fa1d
CY
1372012-02-06 Chong Yidong <cyd@gnu.org>
138
139 * doc.c (store_function_docstring): Avoid applying docstring of
140 alias to base function (Bug#2603).
141
3723ec07
AS
1422012-02-04 Andreas Schwab <schwab@linux-m68k.org>
143
144 * .gdbinit (pp1, pv1): Remove redundant defines.
145 (pr): Use pp.
146
79c1cc1e
CY
1472012-02-04 Chong Yidong <cyd@gnu.org>
148
149 * nsterm.m: Declare a global (Bug#10694).
150
d7f29f8e
EZ
1512012-02-04 Eli Zaretskii <eliz@gnu.org>
152
153 * w32.c (get_emacs_configuration_options): Include
154 --enable-checking, if specified, in the return value.
155
3b95a6f9
MR
1562012-02-04 Martin Rudalics <rudalics@gmx.at>
157
158 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
159 after rounding frame sizes. (Bug#9723)
160
d6fa96a6
EZ
1612012-02-04 Eli Zaretskii <eliz@gnu.org>
162
163 * keyboard.c (adjust_point_for_property): Don't position point
164 before BEGV. (Bug#10696)
165
df0b2940
PE
1662012-02-03 Paul Eggert <eggert@cs.ucla.edu>
167
168 Handle overflow when computing char display width (Bug#9496).
169 * character.c (char_width): Return EMACS_INT, not int.
170 (char_width, c_string_width): Check for overflow when
171 computing the width; this is possible now that individual
172 characters can have unbounded width. Problem introduced
173 by merge from Emacs 23 on 2012-01-19.
174
6bee44d6
MA
1752012-02-02 Michael Albinus <michael.albinus@gmx.de>
176
177 * dbusbind.c (Fdbus_register_method): Mention the return value
178 :ignore in the docstring.
179
44f92739
GM
1802012-02-02 Glenn Morris <rgm@gnu.org>
181
1b9f60cc
GM
182 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
183
44f92739
GM
184 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
185 Unconditionally set to t. (Bug#10673)
186 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
187 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
188 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
189
c5d3843c
KH
1902012-02-02 Kenichi Handa <handa@m17n.org>
191
192 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
193 0, do not call append_composite_glyph.
194
159462d4 1952012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
196
197 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
198 NULL (Bug#6988).
199 (x_produce_glyphs): If the component of a composition is a null
200 string, set it->pixel_width to 1 to avoid zero-width glyph.
201
78cef877
EZ
2022012-02-01 Eli Zaretskii <eliz@gnu.org>
203
204 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
205 first 2 arguments are identical. This makes inserting large
206 output from a subprocess an order of magnitude faster on
207 MS-Windows, where all sbrk'ed memory is always contiguous.
208
97897668
GM
2092012-01-31 Glenn Morris <rgm@gnu.org>
210
211 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 212 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
213 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
214
31fd3586
GM
2152012-01-29 Glenn Morris <rgm@gnu.org>
216
217 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
218
0e24a8b2
CY
2192012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
220
221 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
222
cc0adcb0
CY
2232012-01-28 Chong Yidong <cyd@gnu.org>
224
225 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
226
acc28cb9
CY
2272012-01-26 Chong Yidong <cyd@gnu.org>
228
9c69cfb7
CY
229 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
230
acc28cb9
CY
231 * search.c (Fsearch_forward, Fsearch_backward): Document negative
232 repeat counts (Bug#10507).
233
48da7392
GM
2342012-01-26 Glenn Morris <rgm@gnu.org>
235
236 * lread.c (syms_of_lread): Doc fix.
237
14af5f7f
CY
2382012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
239
240 * coding.c (encode_designation_at_bol): Change return value to
241 EMACS_INT.
242
0b21c100
CY
2432012-01-25 Chong Yidong <cyd@gnu.org>
244
245 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
246
3c2907f7
CY
2472012-01-21 Chong Yidong <cyd@gnu.org>
248
249 * floatfns.c (Fcopysign): Make the second argument non-optional,
250 since nil is not allowed anyway.
251
959ad23f
AS
2522012-01-21 Andreas Schwab <schwab@linux-m68k.org>
253
254 * process.c (read_process_output): Use p instead of XPROCESS (proc).
255 (send_process): Likewise.
256
34a02f46
MR
2572012-01-19 Martin Rudalics <rudalics@gmx.at>
258
259 * window.c (save_window_save, Fcurrent_window_configuration)
260 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
261 doc-strings.
262
1259009a 2632012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
264
265 * character.c (char_width): New function.
70d4fdf6
GM
266 (Fchar_width, c_string_width, lisp_string_width):
267 Use char_width (Bug#9496).
25ed9e61 268
6a6ee00d
MR
2692012-01-16 Martin Rudalics <rudalics@gmx.at>
270
271 * window.c (Vwindow_persistent_parameters): New variable.
272 (Fset_window_configuration, save_window_save): Handle persistent
273 window parameters.
274
c85efaf7
EZ
2752012-01-14 Eli Zaretskii <eliz@gnu.org>
276
277 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
278 thrashing the stack of the thread. (Bug#9087)
279
5944709e
PE
2802012-01-12 Paul Eggert <eggert@cs.ucla.edu>
281
282 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
283
e71f5d99
EZ
2842012-01-11 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (rows_from_pos_range): Handle the case where the
287 highlight ends on a newline. (Bug#10464)
288 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
289 he end column for display of highlight that ends on a newline
290 before a R2L line.
291
ce316182
GM
2922012-01-11 Glenn Morris <rgm@gnu.org>
293
294 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
295 from load-path also when installation-directory is nil. (Bug#10208)
296
5b43da69
GM
2972012-01-10 Glenn Morris <rgm@gnu.org>
298
74cc8ff9
GM
299 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
300
7d8d6e4e
GM
301 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
302 Update template values to be closer to their typical values these days.
5b43da69 303
a0db8d43
EZ
3042012-01-09 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (rows_from_pos_range): Accept additional argument
307 DISP_STRING, and accept any glyph in a row whose object is that
308 string as eligible for mouse highlight. Fixes mouse highlight of
309 display strings from overlays. (Bug#10464)
310
9a0115ab 3112012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 312
b9110d6a 313 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
314 * fileio.c (auto_saving_dir_umask): New static var.
315 (Fmake_directory_internal): Use it.
316 (do_auto_save_make_dir): Set it, instead of invoking chmod after
317 creating the directory. The old code temporarily assigns
318 too-generous permissions to the directory.
319 (do_auto_save_eh): Clear it.
b9110d6a 320 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
321 that the var is always cleared.
322
6c1bd3f3
EZ
3232012-01-07 Eli Zaretskii <eliz@gnu.org>
324
325 * search.c (scan_buffer): Pass character positions to
326 know_region_cache, not byte positions. (Bug#6540)
327
069d2b50
L
3282012-01-07 LynX <_LynX@bk.ru> (tiny change)
329
330 * w32.c (sys_rename): Report EXDEV when rename of a directory
331 fails because the target is on another logical disk. (Bug#10284)
332
75bf0d33
DB
3332012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
334
335 * xterm.c (x_embed_request_focus): New function.
336
337 * xterm.h: Add prototype.
338
339 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
340
1c6e5a32
GM
3412012-01-05 Glenn Morris <rgm@gnu.org>
342
343 * emacs.c (emacs_copyright): Update short copyright year to 2012.
344
651e947e
EZ
3452012-01-01 Eli Zaretskii <eliz@gnu.org>
346
347 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
348 Load gnutls_transport_set_lowat only if GnuTLS version is below
349 2.11.1.
350 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
351 GnuTLS versions below 2.11.1.
352
3778cdd8
AL
3532011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
354
355 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
356 to the doc string advising against its use for altering the way
357 windows are scrolled.
358
0e5317f7
KH
3592011-12-28 Kenichi Handa <handa@m17n.org>
360
361 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
362 coding-system ASCII compatible only when it does not produce BOM
363 on encoding (Bug#10383).
364
93d5ca1f
JD
3652011-12-26 Jan Djärv <jan.h.d@swipnet.se>
366
367 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
368 can scroll.
369 (create_and_show_popup_menu): Always use menu_position_func for
370 Gtk3 (Bug#10361).
371
ca22b785
AS
3722011-12-24 Andreas Schwab <schwab@linux-m68k.org>
373
374 * callint.c (Fcall_interactively): Don't truncate prompt string.
375
d048e1e6
EZ
3762011-12-23 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
379 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 380 resumed from there (after widening). (Bug#10360)
d048e1e6 381
5ccaba1f
JD
3822011-12-22 Jan Djärv <jan.h.d@swipnet.se>
383
384 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
385
204ee57f
JD
3862011-12-21 Jan Djärv <jan.h.d@swipnet.se>
387
b81d40f0
JB
388 * nsterm.m (x_free_frame_resources):
389 Release f->output_data.ns->miniimage.
204ee57f
JD
390 (ns_index_color): Fix indentation. Do not retain
391 color_table->colors[i].
392
393 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
394 before returning.
395
396 * nsfns.m (x_set_background_color): Assign return value from
397 ns_index_color to face-background instead of NSColor*.
398 (ns_implicitly_set_icon_type): Fix indentation.
399 Change assignment in for loop to comparison.
400
401 * emacs.c (ns_pool): New variable.
402 (main): Assign ns_pool.
403 (Fkill_emacs): Call ns_release_autorelease_pool.
404
405 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
406 autorelease fdesc, release fdAttrs and tdict.
407 (ns_get_covering_families): Release charset.
408 (ns_findfonts): Release NSFontDescriptor created with new.
409 (ns_uni_to_glyphs): Fix indentation.
410 (setString): Release attrStr before assigning new value.
411
c803b2b7
JD
4122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
413
678f4426
JD
414 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
415 and NS_IMPL_COCOA.
416 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
417 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
418
cd394be1 4192011-12-18 David Reitter <reitter@cmu.edu>
678f4426 420
5fecd5fc
JD
421 * nsterm.m (ns_term_init): Subscribe for notifications
422 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
423 to method trackingNotification in EmacsMenu.
424
425 * nsmenu.m (trackingMenu): New variable.
3771cb17 426 (trackingNotification): New method (from Aquamacs).
5fecd5fc 427 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 428 from Aquamacs (Bug#7030).
678f4426
JD
429
4302011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 431
c803b2b7
JD
432 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
433 (symbol_to_nsstring): Fix indentation.
434 (ns_symbol_to_pb): New function.
435 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
436 (Fns_rotate_cut_buffers_internal): Removed.
437 (Fns_store_selection_internal): Renamed from
438 Fns_store_cut_buffer_internal.
439 (ns_get_foreign_selection, Fx_own_selection_internal)
440 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
441 (Fns_get_selection_internal, Fns_store_selection_internal):
442 Use ns_symbol_to_pb and check if return value is nil.
443 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
444 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
445 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
446 renamed to Sns_store_selection_internal.
447 (ns_handle_selection_request): Move code to Fx_own_selection_internal
448 and remove this function.
449 (ns_handle_selection_clear): Remove, never used.
450 (Fx_own_selection_internal): Move code from ns_handle_selection_request
451 here.
452
e1b01a3a
KB
4532011-12-17 Ken Brown <kbrown@cornell.edu>
454
455 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
456 GID is unknown (Bug#10257).
457
2adb6e85
PE
4582011-12-17 Paul Eggert <eggert@cs.ucla.edu>
459
460 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
461 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
462 which caused a build failure on GNU/Linux IA-64. This problem was
463 introduced by my 2011-10-07 patch.
464
d1d7b339
JL
4652011-12-15 Juri Linkov <juri@jurta.org>
466
467 * image.c (imagemagick_error): New function. (Bug#10112)
468 (imagemagick_load_image): Comment out `MagickSetResolution' call.
469 Use `imagemagick_error' where ImageMagick functions return
470 `MagickFalse'.
471 (Fimagemagick_types): Add `Fnreverse' to return the list in the
472 proper order.
473
100d5755
KH
4742011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
475
476 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
477 fill background (Bug#8992).
478
454592a6
MR
4792011-12-13 Martin Rudalics <rudalics@gmx.at>
480
481 * window.c (Vwindow_combination_resize)
482 (Vwindow_combination_limit): Use t instead of non-nil in
483 doc-strings.
61d4b438
MR
484 (Vrecenter_redisplay): Add first sentence of doc-string on
485 separate line.
53524d93 486 (Frecenter): Fix doc-string typo.
454592a6 487
3633e3aa
KH
4882011-12-11 Kenichi Handa <handa@m17n.org>
489
490 * coding.c (Funencodable_char_position): Pay attention to the
491 buffer text relocation (Bug#9389).
492
7b9d523a
JD
4932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
494
495 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
496 gtk_init (Bug#10100).
497
b73189c6
EZ
4982011-12-10 Eli Zaretskii <eliz@gnu.org>
499
500 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
501 IT->string is nil. (Bug#10263)
502
f7dfe5d6
JD
5032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
504
83faebb4
JD
505 * nsterm.h (x_free_frame_resources): Declare.
506
f7dfe5d6
JD
507 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
508 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
509
510 * nsterm.h (ns_get_defaults_value): Declare.
511
512 * nsterm.m (ns_default): Call ns_get_defaults_value.
513
7cd4e72c
EZ
5142011-12-09 Eli Zaretskii <eliz@gnu.org>
515
516 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
517 (Bug#10170)
518
b34d7317
YM
5192011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
520
521 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
522 that where the value of an _OBJC_* symbol points to is in the .bss
523 section (Bug#10240).
524
76470ad1
KH
5252011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
526
527 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 528 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 529
745fff94
KH
5302011-12-08 Kenichi Handa <handa@m17n.org>
531
532 * ftfont.c (get_adstyle_property): Fix previous change
533 (Bug#10233).
534
6e44397c
JB
5352011-12-07 Juanma Barranquero <lekktu@gmail.com>
536
537 * w32.c (init_environment): If no_site_lisp, remove site-lisp
538 dirs from the default value of EMACSLOADPATH (bug#10208).
539
7efa6272
GM
5402011-12-07 Glenn Morris <rgm@gnu.org>
541
542 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
543 installation and source directories as well. (Bug#10208)
544
f6fc4d87
CY
5452011-12-06 Chong Yidong <cyd@gnu.org>
546
547 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
548
2bf26180
GM
5492011-12-06 Glenn Morris <rgm@gnu.org>
550
551 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
552 as an error, not just -1. (Bug#10217)
553
3a6ad4f0
CY
5542011-12-05 Chong Yidong <cyd@gnu.org>
555
556 * keyboard.c (process_special_events): New function.
557 (swallow_events, Finput_pending_p): Use it (Bug#10195).
558
75a3b399
PE
5592011-12-05 Paul Eggert <eggert@cs.ucla.edu>
560
561 * coding.c (encode_designation_at_bol): Don't use uninitialized
562 local variable (Bug#9318).
563
c3c9e25e
KH
5642011-12-05 Kenichi Handa <handa@m17n.org>
565
566 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
567 return Qnil (Bug#8046, Bug#10193).
568
5eb05ea3
KH
5692011-12-05 Kenichi Handa <handa@m17n.org>
570
571 * coding.c (encode_designation_at_bol): New args charbuf_end and
572 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
573 (coding_set_source): Return how many bytes coding->source was
574 relocated.
575 (coding_set_destination): Return how many bytes
576 coding->destination was relocated.
577 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
578 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
579
5802011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
581
582 * coding.c (CODING_CHAR_CHARSET_P): New macro.
583 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
584 macro (Bug#9318).
585
5862011-12-05 Andreas Schwab <schwab@linux-m68k.org>
587
588 The following changes are to fix Bug#9318.
589
a79703f5 590 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
591 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
592 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 593 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 594
7dbda6df
JB
5952011-12-05 Juanma Barranquero <lekktu@gmail.com>
596
597 * lisp.h (process_quit_flag): Fix external declaration.
598
6d5eb5b0
SM
5992011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
600
601 Don't macro-inline non-performance-critical code.
602 * eval.c (process_quit_flag): New function.
603 * lisp.h (QUIT): Use it.
604
a0c3fad0
JD
6052011-12-04 Jan Djärv <jan.h.d@swipnet.se>
606
607 * nsfns.m (get_geometry_from_preferences): New function.
608 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
609
6c07aac2
AS
6102011-12-04 Andreas Schwab <schwab@linux-m68k.org>
611
612 * emacs.c (Qkill_emacs): Define.
613 (syms_of_emacs): Initialize it.
614 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
615 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
616 (quit_throw_to_read_char): Add parameter `from_signal'.
617 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
618 * lisp.h (QUIT): Call Fkill_emacs if requested.
619
c052ead4
JD
6202011-12-03 Jan Djärv <jan.h.d@swipnet.se>
621
622 * widget.c (update_wm_hints): Return if wmshell is null.
623 (widget_update_wm_size_hints): New function.
624
625 * widget.h (widget_update_wm_size_hints): Declare.
626
627 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
628 widget_update_wm_size_hints (Bug#10104).
629
9e49252b
EZ
6302011-12-03 Eli Zaretskii <eliz@gnu.org>
631
632 * xdisp.c (handle_invisible_prop): If the invisible text ends just
633 before a newline, prepare the bidi iterator for consuming the
634 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 635 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 636
02b16839
JL
6372011-12-02 Juri Linkov <juri@jurta.org>
638
639 * search.c (Fword_search_regexp): New Lisp function created from
640 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
641 (Fword_search_backward, Fword_search_forward)
642 (Fword_search_backward_lax, Fword_search_forward_lax):
643 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
644 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
645
0068070e
SM
6462011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * fileio.c (Finsert_file_contents): Move after-change-function call
649 to before the "handled:" label, since all "goto handled" appear in
650 cases where the *-change-functions have already been properly called
651 (bug#10117).
652
3360a3fc
AS
6532011-12-01 Andreas Schwab <schwab@linux-m68k.org>
654
655 * keyboard.c (interrupt_signal): Don't call kill-emacs when
656 waiting for input. (Bug#10169)
657
73d6c093
EZ
6582011-11-30 Eli Zaretskii <eliz@gnu.org>
659
660 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
661 verifies glyph row's hash code--we have just reallocated the
662 glyphs, so their contents can be complete garbage. (Bug#10164)
663
febe6bea
JB
6642011-11-30 Juanma Barranquero <lekktu@gmail.com>
665
666 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
667
801a4313
EZ
6682011-11-30 Eli Zaretskii <eliz@gnu.org>
669
670 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
671 attributes are tested _before_ calling verify_row_hash, to protect
672 against GCC re-ordering of the tests. (Bug#10164)
673
2b56b87e
JD
6742011-11-29 Jan Djärv <jan.h.d@swipnet.se>
675
676 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
677
678 * xterm.c (handle_one_xevent): Only set async_visible and friends
679 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 680 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
681 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
682
dbf31225
PE
6832011-11-28 Paul Eggert <eggert@cs.ucla.edu>
684
685 Remove GCPRO-related macros that exist only to avoid shadowing locals.
686 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
687 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
688 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
689 All uses changed to use GCPRO1 etc.
690 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
691 Revert to old implementation (i.e., before 2011-03-11).
692
1305621b
YM
6932011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
694
695 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
696 of scroll runs so as to avoid assigning disabled bogus rows and
697 unnecessary graphics copy operations.
698
8c9afb46
EZ
6992011-11-27 Eli Zaretskii <eliz@gnu.org>
700
701 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
702 (snprintf) [_MSC_VER]: Redirect to _snprintf.
703 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
704 (malloc, free, realloc, calloc): Redirect to e_* only when
705 compiling Emacs.
706
707 * lisp.h (GCTYPEBITS): Move before first use.
708 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
709 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
710 this macro definition.
711
712 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
713 _MSC_VER.
714
54e9e3bf
JD
7152011-11-27 Jan Djärv <jan.h.d@swipnet.se>
716
6d5eb5b0
SM
717 * gtkutil.c (xg_create_frame_widgets):
718 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
719 present with Gtk+ 2.0.
720
83aca1cb
PE
7212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
722
723 * fileio.c (Finsert_file_contents): Undo previous change; see
724 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
725
5b76caa4
PE
7262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
727
728 Rename locals to avoid shadowing.
729 * fileio.c (Finsert_file_contents):
730 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
731 * process.c (wait_reading_process_output):
732 Rename inner 'proc' to 'p' to avoid shadowing.
733 Indent for consistency with usual Emacs style.
734
8c535114
EZ
7352011-11-25 Eli Zaretskii <eliz@gnu.org>
736
737 * xdisp.c (redisplay_window): If cursor row is not fully visible
738 after recentering, and scroll-conservatively is set to a large
739 number, scroll window by a few more lines to make the cursor fully
740 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
741 (start_display): Don't move to the next line if the display should
742 start at a newline that is part of a display vector or an overlay
743 string. (Bug#10119)
8c535114 744
fa4fdb5c
JL
7452011-11-24 Juri Linkov <juri@jurta.org>
746
747 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
748 after the `MagickPingImage' call. (Bug#10112)
749
90ec88df
CY
7502011-11-23 Chong Yidong <cyd@gnu.org>
751
752 * window.c (Fcoordinates_in_window_p): Accept only live windows.
753
56e2e794
MR
7542011-11-23 Martin Rudalics <rudalics@gmx.at>
755
756 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
757 making another buffer current. (Bug#10114)
758
b6e64c41
GM
7592011-11-23 Glenn Morris <rgm@gnu.org>
760
761 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
762
6b21de18
CY
7632011-11-23 Chong Yidong <cyd@gnu.org>
764
765 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
766 using it (Bug#5984).
767
b12cd789
EZ
7682011-11-22 Eli Zaretskii <eliz@gnu.org>
769
770 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
771 and header-lines, as they don't have one computed for them.
772 (Bug#10098)
773
774 * .gdbinit (prow): Make displayed values more self-explaining.
775 Add row's hash code.
776
261b6fd4
LMI
7772011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
778
779 * process.c (wait_reading_process_output): Fix asynchrounous
780 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 781 (wait_reading_process_output): Add comment and URL.
261b6fd4 782
e7cfd277
JD
7832011-11-21 Jan Djärv <jan.h.d@swipnet.se>
784
785 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
786
a9b9b7f5
CY
7872011-11-21 Chong Yidong <cyd@gnu.org>
788
789 * window.c (Fnext_window, Fprevious_window): Doc fix.
790
b0d15b4f
SM
7912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
794
fe7a3057
JB
7952011-11-20 Juanma Barranquero <lekktu@gmail.com>
796
797 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
798
d2999b1a
MR
7992011-11-20 Martin Rudalics <rudalics@gmx.at>
800
801 * window.c (Fset_window_combination_limit): Rename argument
802 STATUS to LIMIT.
803 (Vwindow_combination_limit): Remove "status" from doc-string.
804
d5ff9cd0
AS
8052011-11-20 Andreas Schwab <schwab@linux-m68k.org>
806
807 * m/ibms390.h: Remove.
808 * m/ibms390x.h: Don't include "ibms390.h".
809
a5bb9bd3
SM
8102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
813 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
814
cd1181db
JB
8152011-11-20 Juanma Barranquero <lekktu@gmail.com>
816
817 * casetab.c (Fset_case_table):
818 * charset.c (Fcharset_after): Fix typos.
819
615a3b8d 8202011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 821
17e845af
PE
822 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
823 Otherwise, valgrind does not work on some platforms.
824 Problem reported by Andreas Schwab in
6a0bf43d
PE
825 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
826 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
827 is set, removing the need for VIRT_ADDRESS_VARIES.
828 (PURE_P): Use a more-efficient implementation that needs just one
829 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
830 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
831 to 4 (xorl, subq, cmpq, setbe).
832 * alloc.c (pure): Always extern now, since that's the
833 VIRT_ADDR_VARIES behavior.
834 (PURE_POINTER_P): Use a single comparison, not two, for
835 consistency with the new puresize.h.
836 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
837 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
838 Remove VIRT_ADDR_VARIES no longer needed.
839
f8fe6f96
EZ
8402011-11-19 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
843 (erase_phys_cursor, update_window_cursor, show_mouse_face)
844 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
845 behave as if the cursor position were at the window margin.
846
847 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
848 and the cursor position is out of bounds, behave as if the cursor
849 position were at the window margin. (Bug#10075)
850
df05a53c
CY
8512011-11-18 Chong Yidong <cyd@gnu.org>
852
853 * window.c (Fwindow_combination_limit): Make first argument
854 non-optional, since it is meaningless for live windows like the
855 selected window.
856
2071918e
DA
8572011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
858
859 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
860
b50a28de
SM
8612011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
862
863 * intervals.c: Fix grafting over the whole buffer (bug#10071).
864 (graft_intervals_into_buffer): Simplify.
865
015137db
EZ
8662011-11-18 Eli Zaretskii <eliz@gnu.org>
867
868 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
869 hash values of the two rows.
870 (copy_row_except_pointers): Preserve the used[] arrays and the
871 hash values of the two rows. (Bug#10035)
68c95424 872 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
873
874 * xdisp.c (row_hash): New function, body extracted from
875 compute_line_metrics.
876 (compute_line_metrics): Call row_hash, instead of computing the
877 hash code inline.
878
879 * dispnew.c (verify_row_hash): Call row_hash for computing the
880 hash code of a row, instead of duplicating code from xdisp.c.
881
882 * dispextern.h (row_hash): Add prototype.
883
a2addb04
TH
8842011-11-18 Tassilo Horn <tassilo@member.fsf.org>
885
886 * frame.c (delete_frame): Don't delete the terminal when the last
887 X frame is closed if emacs is built with GTK toolkit.
888
df85d315
JB
8892011-11-17 Juanma Barranquero <lekktu@gmail.com>
890
891 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
892
a0c2d0ae
MR
8932011-11-17 Martin Rudalics <rudalics@gmx.at>
894
895 * window.c (Vwindow_splits): Rename to
896 Vwindow_combination_resize. Suggested by Juri Linkov.
897 (Fsplit_window_internal): Use Vwindow_combination_resize instead
898 of Vwindow_splits.
899
58179cce
JB
9002011-11-16 Juanma Barranquero <lekktu@gmail.com>
901
7877f373
JB
902 * nsfns.m (Fns_font_name):
903 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 904
b6f67890
MR
9052011-11-16 Martin Rudalics <rudalics@gmx.at>
906
907 * window.h (window): Rename slot "nest" to "combination_limit".
908 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
909 (Fset_window_nest): Rename to Fset_window_combination_limit.
910 (Vwindow_nest): Rename to Vwindow_combination_limit.
911 (recombine_windows, make_parent_window, make_window)
912 (Fsplit_window_internal, saved_window)
913 (Fset_window_configuration, save_window_save): Rename all
914 occurrences of window_nest to window_combination_limit.
915
c7015153
JB
9162011-11-15 Juanma Barranquero <lekktu@gmail.com>
917
918 * image.c (imagemagick_load_image): Fix typo.
919
322ad6ec
EZ
9202011-11-14 Eli Zaretskii <eliz@gnu.org>
921
922 * xdisp.c (display_line): Move the call to
923 highlight_trailing_whitespace before the call to
924 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
925 faces of all the glyphs to compute ROW's hash value.
926 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 927
f067b8ec
JB
9282011-11-14 Juanma Barranquero <lekktu@gmail.com>
929
930 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
931 just return (bug#10044).
932
1e5b2111
EZ
9332011-11-12 Eli Zaretskii <eliz@gnu.org>
934
7ef3cbd5
EZ
935 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
936 with user-defined heap size. Bump the default size of the temacs
937 heap to 27MB, to avoid memory warning when running temacs.
938 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
939
1e5b2111
EZ
940 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
941 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
942 (verify_row_hash) [XASSERTS]: New function.
943 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
944 that the hash value of glyph rows is correct.
1e5b2111 945
89d61221
MR
9462011-11-12 Martin Rudalics <rudalics@gmx.at>
947
948 * window.h (window): Remove splits slot.
949 * window.c (Fwindow_splits, Fset_window_splits): Remove.
950 (Fdelete_other_windows_internal, make_parent_window)
951 (make_window, Fsplit_window_internal, Fdelete_window_internal)
952 (Fset_window_configuration, save_window_save): Don't deal with
953 split status of windows.
954 (saved_window): Remove splits slot.
955 (Vwindow_splits): Rewrite doc-string.
956
97f18cc8
JD
9572011-11-11 Jan Djärv <jan.h.d@swipnet.se>
958
959 * xfns.c (unwind_create_frame):
960 * nsfns.m (unwind_create_frame):
961 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
962 Vframe_list (Bug#9999).
963
22a648b4
DA
9642011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
965
0b381c7e 966 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 967
659afede
KH
9682011-11-11 Kenichi Handa <handa@m17n.org>
969
970 * callproc.c (Fcall_process): Set the member dst_multibyte of
971 process_coding.
972
9ac0394b
KH
9732011-11-11 Johan Bockgård <bojohan@gnu.org>
974
975 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
976 avoid a crash (bug#9496).
977
2fbdc249
CY
9782011-11-09 Chong Yidong <cyd@gnu.org>
979
980 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
981 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
982
ac6b1f81
PE
9832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
984
985 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
986
09db192c
PE
9872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
988
989 Avoid some portability problems by eschewing 'extern inline' functions.
990 The trivial performance wins aren't worth the portability hassles; see
991 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
992 et seq.
993 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
994 (window_box_width, window_box_left, window_box_left_offset)
995 (window_box_right, window_box_right_offset): Undo previous change,
996 by removing the "extern"s.
997 * intervals.c (adjust_intervals_for_insertion)
998 (adjust_intervals_for_deletion): Undo previous change,
999 making these static again.
1000 (offset_intervals, temp_set_point_both, temp_set_point)
1001 (copy_intervals_to_string): No longer inline.
1002 * xdisp.c (window_text_bottom_y, window_box_width)
1003 (window_box_height, window_box_left_offset)
1004 (window_box_right_offset, window_box_left, window_box_right)
1005 (window_box): No longer inline.
1006
105216ed
CY
10072011-11-08 Chong Yidong <cyd@gnu.org>
1008
1009 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1010 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1011 Signal an error if not a live window.
105216ed
CY
1012 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1013 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1014
ae9e237f
JB
10152011-11-07 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * lisp.h (syms_of_abbrev): Remove declaration.
1018 Reported by CHENG Gao <chenggao@royau.me>.
1019
c7aa8333
EZ
10202011-11-07 Eli Zaretskii <eliz@gnu.org>
1021
1022 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1023 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1024 of temacs in GUI mode.
1025
be7f5545
MR
10262011-11-07 Martin Rudalics <rudalics@gmx.at>
1027
1028 * window.h: Declare delete_all_child_windows instead of
1029 delete_all_subwindows.
1030 * window.c (Fwindow_nest, Fset_window_nest)
1031 (Fset_window_new_total, Fset_window_new_normal)
1032 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1033 (delete_all_subwindows): Rename to delete_all_child_windows.
1034 (Fdelete_other_windows_internal, Fset_window_configuration):
1035 Call delete_all_child_windows instead of delete_all_subwindows.
1036 * frame.c (delete_frame): Call delete_all_child_windows instead
1037 of delete_all_subwindows.
1038
ca78dc43
PE
10392011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1042 This is also needed for porting to any host where GC_MARK_STACK is
1043 not GC_MAKE_GCPROS_NOOPS.
1044 (which_symbols): Use it.
1045
a0241d01
KH
10462011-11-07 Kenichi Handa <handa@m17n.org>
1047
1048 * coding.c (coding_set_destination): Check coding->src_pos only
1049 when coding->src_object is a buffer (bug#9910).
1050
1051 * process.c (send_process): Set the member src_multibyte of coding
1052 to 0 (bug#9911) when sending a unibyte text.
1053
1054 * callproc.c (Fcall_process): Set the member src_multibyte of
1055 process_coding to 0 (bug#9912).
1056
a64bfdfa 10572011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1058
1059 * xmenu.c (cleanup_widget_value_tree): New function.
1060 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1061 calling free_menubar_widget_value_tree directly (Bug#9830).
1062
cb41b32a
PE
10632011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 Fix some portability problems with 'inline'.
1066 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1067 (window_box_width, window_box_left, window_box_left_offset)
1068 (window_box_right, window_box_right_offset): Declare extern.
1069 Otherwise, these inline functions do not conform to C99 and
1070 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1071 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1072 * intervals.c (adjust_intervals_for_insertion)
1073 (adjust_intervals_for_deletion): Now extern, because otherwise the
1074 extern inline functions 'offset_intervals' couldn't refer to it.
1075 (static_offset_intervals): Remove.
1076 (offset_intervals): Rewrite using the old contents of
1077 static_offset_intervals. The old version didn't conform to C99
1078 because an extern inline function contained a reference to an
1079 identifier with static linkage.
1080
b7041366
AS
10812011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1082
1083 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1084 GC.
1085
88a37c4d
EZ
10862011-11-06 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1089 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1090 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1091 return Qleft_to_right.
1092
49745b39
CY
10932011-11-06 Chong Yidong <cyd@gnu.org>
1094
1095 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1096 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1097 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1098 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1099 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1100 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1101 (Fwindow_vscroll): Doc fix.
1102 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1103 argument, since it makes no sense to pass a live window and for
1104 consistency with window-child.
1105
1f05cd82
CS
11062011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1107
1108 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1109 support MSVC.
1110
22610910
JR
11112011-11-05 Jason Rumney <jasonr@gnu.org>
1112
1113 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1114 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1115 fonts (Bug#6029).
1116 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1117 bitwise arithmetic preventing use of unicode-sip and non-truetype
1118 opentype fonts.
1119
a06776b2
EZ
11202011-11-05 Eli Zaretskii <eliz@gnu.org>
1121
3ad924ba
EZ
1122 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1123 "emacs"-only part.
1124
a06776b2
EZ
1125 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1126 initialization code to keep similarity to xfns.c after changes
1127 from 2011-11-05.
1128
c9e7db78
JD
11292011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1130
a97f8f3f
JD
1131 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1132 (unwind_create_frame): New function (Bug#9943).
1133 (Fx_create_frame): Restructure code to be more similar to the one in
1134 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1135 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1136 Move terminal->reference_count++ just before making the frame official
1137 (Bug#9943).
1138
1139 * nsterm.m (x_free_frame_resources): New function.
1140 (x_destroy_window): Move code to x_free_frame_resources.
1141
c9e7db78 1142 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1143 (Fx_create_frame, x_create_tip_frame):
1144 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1145 official. Move initialization of image_cache_refcount and
1146 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1147
a6fc3b5c
EZ
11482011-11-05 Eli Zaretskii <eliz@gnu.org>
1149
1150 Support MSVC build with newer versions of Visual Studio.
1151 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1152 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1153 nt/gmake.defs.
1154
1155 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1156 which are not supported by MSVC.
1157 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1158 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1159 bitfields.
1160 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1161 types in bitfields.
1162 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1163
1164 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1165
58179cce 11662011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1167
1168 Support MSVC build with newer versions of Visual Studio.
1169 * w32.c: Don't include w32api.h for MSVC.
1170 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1171
1172 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1173 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1174 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1175 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1176 e_* cousins.
1177 (alloca) [_MSC_VER]: Define to _alloca.
1178
1179 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1180
1181 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1182
a58c13ed
EZ
11832011-11-04 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (note_mouse_highlight): If either of
1186 previous/next-single-property-change returns nil, treat that as
1187 the beginning or the end of the buffer. (Bug#9955)
1188
fe0b6370
JD
11892011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1190
a58c13ed 1191 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1192 label is not null (Bug#9951).
1193 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1194 may be NULL.
1195
89bd5ee1
EZ
11962011-11-04 Eli Zaretskii <eliz@gnu.org>
1197
1198 * window.c (Fwindow_body_size): Mention in the doc string that the
1199 return value is in frame's canonical units. (Bug#9949)
1200
84c3edb9
EZ
12012011-11-03 Eli Zaretskii <eliz@gnu.org>
1202
4e2fb5c7
EZ
1203 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1204
84c3edb9 1205 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1206 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1207 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1208
bc17a887
EZ
12092011-11-01 Eli Zaretskii <eliz@gnu.org>
1210
1211 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1212 Don't stop backward scan on the continuation glyph, even though
1213 its CHARPOS is positive.
6d5eb5b0
SM
1214 (mouse_face_from_buffer_pos, note_mouse_highlight):
1215 Rename cover_string to disp_string.
bc17a887 1216
4ee88440
MR
12172011-11-01 Martin Rudalics <rudalics@gmx.at>
1218
1219 * window.c (temp_output_buffer_show): Don't use
1220 Vtemp_buffer_show_specifiers.
1221 (Vtemp_buffer_show_specifiers): Remove unused variable.
1222
c2ff3c02
EZ
12232011-10-30 Eli Zaretskii <eliz@gnu.org>
1224
1225 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1226 past the beginning of the current glyph matrix.
1227
58179cce 12282011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1229
1230 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1231 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1232 HAVE_GTK3 (Bug#9869).
b77a6a7f 1233
3b574623
JD
1234 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1235 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1236
b77a6a7f
JD
1237 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1238
1239 * xterm.c: Declare x_handle_net_wm_state to return int.
1240 (handle_one_xevent): Check if we are iconified but don't have
1241 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1242 (get_current_wm_state): Return non-zero if not hidden,
1243 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1244 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1245 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1246 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1247
196e41e4
PE
12482011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1251 so that this new function doesn't get optimized away by a
1252 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1253
021f2e1a
AS
12542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1255
1256 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1257
8b058d44
EZ
12582011-10-29 Eli Zaretskii <eliz@gnu.org>
1259
1260 Fix the `xbytecode' command.
1261 * .gdbinit (xprintbytestr): New command.
b50a28de 1262 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1263 (xbytecode): Print the byte-code string as well.
1264
4452fb80
EZ
12652011-10-29 Kim Storm <storm@cua.dk>
1266
8b058d44
EZ
1267 * alloc.c (which_symbols): New function.
1268
21b72067
AS
12692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1270
1271 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1272 line. (Bug#9903)
1273
83ed7b5c
GM
12742011-10-29 Glenn Morris <rgm@gnu.org>
1275
1276 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1277 Not clear what it was for, and it causes various bugs. (Bug#9839)
1278
5a7a728b
EZ
12792011-10-28 Eli Zaretskii <eliz@gnu.org>
1280
1281 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1282 possible random value that matches one of those tested as
1283 condition to clear the mouse face.
1284
d3d0842f
CY
12852011-10-28 Chong Yidong <cyd@gnu.org>
1286
1287 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1288
31b39d13
DN
12892011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1290
1291 * window.c (make_window): Initialize phys_cursor_on_p.
1292
9aba6043
SM
12932011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * lisp.h (struct Lisp_Symbol): Update comments.
1296
c20992f4
JB
12972011-10-28 Juanma Barranquero <lekktu@gmail.com>
1298
1299 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1300
db4f02f2
EZ
13012011-10-28 Eli Zaretskii <eliz@gnu.org>
1302
1303 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1304 <oslsachem@gmail.com> for helping to debug this.
1305
1306 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1307 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1308 (g_b_init_get_glyph_outline_w): New static variables.
1309 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1310 (GetGlyphOutlineW_Proc): New typedefs.
1311 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1312 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1313 New functions.
1314 (w32font_open_internal, compute_metrics):
1315 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1316 instead of calling the "wide" APIs directly.
1317
1318 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1319
1320 * w32.h (syms_of_w32font): Add prototype.
1321
87e68db4
JB
13222011-10-27 Juanma Barranquero <lekktu@gmail.com>
1323
1324 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1325 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1326 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1327 (Fmove_to_window_line): Doc fix.
1328
435c1d67
CY
13292011-10-27 Chong Yidong <cyd@gnu.org>
1330
1331 * process.c (make_process): Set gnutls_state to NULL.
1332
1333 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1334 non-NULL, regardless of GNUTLS_INITSTAGE.
1335 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1336 an error. Set process slots as soon as we allocate them.
1337
1338 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1339
9c6c6f49
CY
13402011-10-27 Chong Yidong <cyd@gnu.org>
1341
9aba6043
SM
1342 * gnutls.c (emacs_gnutls_deinit): New function.
1343 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1344 (Fgnutls_deinit, Fgnutls_boot): Use it.
1345
1346 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1347 (deactivate_process): Call emacs_gnutls_deinit.
1348
657d08d3
JB
13492011-10-27 Juanma Barranquero <lekktu@gmail.com>
1350
1351 * image.c (x_create_x_image_and_pixmap):
1352 * w32.c (sys_rename, w32_delayed_load):
1353 * w32font.c (fill_in_logfont):
1354 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1355
5430d399
JB
13562011-10-26 Juanma Barranquero <lekktu@gmail.com>
1357
1358 * w32fns.c (w32_default_color_map): New function,
1359 extracted from Fw32_default_color_map.
a7ef684b 1360 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1361
fe0055fa
PE
13622011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1365
e6346438
SM
13662011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1367
1368 * keyboard.c (test_undefined): New function (bug#9751).
1369 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1370
e112cc37
ET
13712011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1372
1373 * sysdep.c (init_sys_modes): Fix the check for the controlling
1374 terminal (Bug#6649).
1375
7b5d6677
EZ
13762011-10-20 Eli Zaretskii <eliz@gnu.org>
1377
1378 * dispextern.h (struct bidi_it): New member next_en_type.
1379
1380 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1381 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1382 current character, check also for next_en_type being WEAK_EN.
1383 (bidi_resolve_weak): Don't enter the expensive loop if the current
1384 position is before next_en_pos. Record the bidi type of the first
1385 non-ET, non-BN character we find, in addition to its position.
1386 (bidi_level_of_next_char): Invalidate next_en_type when
1387 next_en_pos is over-stepped.
1388
7da0b018
PE
13892011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1392 * editfns.c: Rewrite current-time-zone so that it invokes
1393 the equivalent of (format-time-string "%Z") to get the time zone name.
1394 This fixes a bug when the time zone name contains characters that
1395 need converting from the system time locale to Emacs internal format.
1396 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1397 that patch fixed format-time-string to do the conversion, but
1398 I forgot to fix current-time-zone.
1399 (format_time_string): New function, containing most of
1400 what Fformat_time_string used to contain.
1401 (Fformat_time_string): Rewrite in terms of format_time_string.
1402 This doesn't change this function's behavior.
1403 (current-time-zone): Rewrite to use format_time_string.
1404 This fixes the bug reported by Michael Schierl in
1405 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1406 Jason Rumney's 2007-06-07 change worked around this bug, but
1407 didn't fix it.
1408 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1409
8547b010
EZ
14102011-10-19 Eli Zaretskii <eliz@gnu.org>
1411
1412 * xdisp.c (start_display): If the character at POS is displayed
1413 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1414 (try_window_reusing_current_matrix): If a line ends in a display
1415 vector or the next line starts in a display vector, continue
1416 redrawing the window even though the character position of
1417 start_row was reached.
8547b010
EZ
1418 (Bug#9771, part 2)
1419
4e948d15
CY
14202011-10-18 Chong Yidong <cyd@gnu.org>
1421
1422 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1423 with nobreak-char-display too.
1424
4787455f
EZ
14252011-10-18 Eli Zaretskii <eliz@gnu.org>
1426
1427 Fix part 3 of bug#9771.
1428 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1429 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1430 non-neutral characters if the current character is a paragraph
1431 separator (a.k.a. Newline). This avoids running the same
1432 expensive loop twice, once when we consume the preceding newline
1433 and the other time when the line actually needs to be displayed.
1434 Avoid the loop when we see neutrals on the base embedding level
1435 following a character whose directionality is the same as the
1436 paragraph's. This avoids running the expensive loop when a line
1437 ends in a long sequence of neutrals, like control characters.
1438 Add assertion against STRONG_AL type. Slightly rearrange code
1439 that determines the type of a neutral given the first non-neutral
1440 that follows it.
1441 (bidi_level_of_next_char): Set next_en_pos to zero when
1442 invalidating its info.
1443
2c91f553
EZ
14442011-10-17 Eli Zaretskii <eliz@gnu.org>
1445
1446 * xdisp.c (push_display_prop): Determine whether to record string
1447 or buffer position by IT->string, not by IT->method. Allow
1448 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1449 (move_it_vertically_backward): Don't look for character position
1450 immediately after the newline when in a continuation line.
1451 (Bug#9771, part 1)
2c91f553 1452
c7b08b0d
MR
14532011-10-15 Martin Rudalics <rudalics@gmx.at>
1454
1455 * window.c (coordinates_in_window): Rewrite and delabelize
1456 vertical border check. (Bug#5357) (Bug#9618)
1457
6b02f655
SM
14582011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1459
1460 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1461 errors in XSetWindowBorder (bug#9310).
1462
81d40c92
DA
14632011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1464
1465 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1466 avoid crash when xmalloc overrun checking is enabled.
1467
d4172c3b
EZ
14682011-10-13 Eli Zaretskii <eliz@gnu.org>
1469
1470 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1471 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1472 cursor motion with <left> and <right> arrow keys.
1473
1474 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1475 some callers set that themselves.
1476
b00eea75
EZ
14772011-10-12 Eli Zaretskii <eliz@gnu.org>
1478
1479 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1480 display string and the previous row comes from the same string and
1481 is empty. (Bug#9739) (Bug#9738)
1482
8fe012c4
SM
14832011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1484
1485 * doc.c (get_doc_string): Encode file name (bug#9735).
1486
0074aef2
EZ
14872011-10-12 Eli Zaretskii <eliz@gnu.org>
1488
79beb178
EZ
1489 * bidi.c (bidi_level_of_next_char):
1490 * xdisp.c (get_visually_first_element): Remove old incorrect
1491 comments regarding the Unicode Line Separator character.
1492
0074aef2
EZ
1493 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1494
6e4b3fbe
DA
14952011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 * alloc.c (Fgc_status): Do not access beyond zombies array
1498 boundary if nzombies > MAX_ZOMBIES.
1499 * alloc.c (dump_zombies): Add missing format specifier.
1500
0324f3af
PE
15012011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1502
b5525cac
PE
1503 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1504 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1505
0324f3af
PE
1506 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1507 Some packages use them to denote characters with modifiers.
1508
e9b5f888
AS
15092011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1510
1511 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1512 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1513 matching a pp-number. Rename parameter var to var1.
1514
127827c0
SM
15152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1516
1517 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1518
c8fd3bd0
GM
15192011-10-08 Glenn Morris <rgm@gnu.org>
1520
1521 * callint.c (Fcall_interactively): Give a more explicit error for the
1522 'c' case with a non-character input. (Bug#8479)
1523
352ec8ff
EZ
15242011-10-08 Eli Zaretskii <eliz@gnu.org>
1525
03669ccb
EZ
1526 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1527 lines.
7061c986
EZ
1528 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1529 lines that are hscrolled on the left.
03669ccb 1530
352ec8ff
EZ
1531 * dispnew.c (buffer_posn_from_coords): Account for a possible
1532 presence of header-line. (Bug#4426)
1533
a66cfb1c
SM
15342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1535
6b02f655
SM
1536 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1537 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1538
7c5ee88e
PE
15392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1542 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1543 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1544 this makes Emacs dump core during garbage collection on rare
1545 occasions. sizeof is obviously inferior to offsetof here, so
1546 stick with offsetof.
1547 (GC_POINTER_ALIGNMENT): New macro.
1548 (mark_memory): Omit 3rd (offset) arg; caller changed.
1549 Don't assume EMACS_INT alignment is the same as pointer alignment.
1550
df1bbe5b
SM
15512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1552
1553 * keyboard.c (read_key_sequence_remapped): New var.
1554 (read_key_sequence): Compute remapping in the right buffer.
1555 (command_loop_1): Use read_key_sequence's remapping directly.
1556
51553db6
SM
15572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1558
32c1fffd
SM
1559 * dired.c (file_name_completion): Don't expand file name.
1560 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1561 before checking file name handler.
1562
51553db6
SM
1563 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1564 they've been requested explicitly (bug#9591).
1565
b6bd1599 15662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1567
1568 * keymap.c (Fsingle_key_description): Use make_specified_string
1569 instead of build_string to build string from push_key_description.
1570 (Bug#5193)
1571
f701dc2a
PE
15722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1573
4222c55d
PE
1574 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1575 This fixes a Y2038 bug on 64-bit hosts.
1576 * buffer.c (reset_buffer):
1577 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1578 (Fclear_buffer_auto_save_failure):
1579 Use 0, not -1, to represent an unset failure time, since time_t
1580 might not be signed.
1581
f701dc2a
PE
1582 Remove dependency on glibc malloc internals.
1583 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1584 Move back here from lisp.h, but with their new implementations.
1585 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1586 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1587 * charset.c (charset_table_init): New static var.
1588 (syms_of_charset): Use it instead of xmalloc. This removes a
1589 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1590 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1591 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1592 Move back to alloc.c.
1593 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1594 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1595
9ceebf39
JD
15962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1597
1598 * nsterm.m (windowDidResize): Call x_set_window_size only when
1599 ns_in_resize is true. Otherwise set pixelwidth/height and
1600 call change_frame_size (Bug#9628).
1601
cb993c58
PE
16022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1603
3930c88b
PE
1604 Port --enable-checking=all to Fedora 14 x86-64.
1605 * charset.c (syms_of_charset): Also account for glibc malloc's
1606 internal overhead when calculating the initial malloc maximum.
1607
cb993c58
PE
1608 Port --enable-checking=all to Fedora 14 x86.
1609 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1610 Move to lisp.h.
1611 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1612 (overrun_check_realloc, overrun_check_free):
1613 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1614 That way, xmalloc returns a properly-aligned pointer even if
1615 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1616 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1617 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1618 into account when calculating the initial malloc maximum.
1619 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1620 Move here from alloc.c, so that charset.c can use it too.
1621 Properly align; the old code wasn't right for common 32-bit hosts
1622 when configured with --enable-checking=all.
1623 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1624 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1625
31bed486
EZ
16262011-09-29 Eli Zaretskii <eliz@gnu.org>
1627
04c70788 1628 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1629 use EDOM.
1630
fbcaa2f3
EZ
16312011-09-28 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (compute_display_string_end): If there's no display
1634 string at CHARPOS, return -1.
1635
1636 * bidi.c (bidi_fetch_char): When compute_display_string_end
1637 returns a negative value, treat the character as a normal
1638 character not covered by a display string. (Bug#9624)
1639
a239d4e9
JB
16402011-09-28 Juanma Barranquero <lekktu@gmail.com>
1641
1642 * lread.c (Fread_from_string): Fix typo in docstring.
1643
88652fd5
EZ
16442011-09-27 Eli Zaretskii <eliz@gnu.org>
1645
1646 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1647 newline, reseat the iterator instead of bidi-iterating there one
1648 character at a time. (Bug#9610)
32c1fffd
SM
1649 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1650 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1651
ed497dd4
AS
16522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1653
1654 * lread.c (readevalloop): Use correct code for NBSP.
1655 (read1): Likewise. (Bug#9608)
1656
b2bf61aa
MA
16572011-09-25 Michael Albinus <michael.albinus@gmx.de>
1658
1659 * dbusbind.c (Fdbus_register_signal): When service is not
1660 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1661
32bbb17c
GM
16622011-09-25 Glenn Morris <rgm@gnu.org>
1663
1664 * buffer.c (truncate-lines): Doc fix.
1665
94e0933e
CY
16662011-09-24 Chong Yidong <cyd@stupidchicken.com>
1667
1668 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1669 (Fset_window_next_buffers): Doc fix.
1670
cddde921
GM
16712011-09-24 Glenn Morris <rgm@gnu.org>
1672
1673 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1674
1260aef1
PE
16752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1676
25b4bfa0
PE
1677 Fix minor problems found by static checking.
1678 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1679 * indent.c (Fvertical_motion): Fix == vs = typo.
1680
e3cbd34b
EZ
16812011-09-24 Eli Zaretskii <eliz@gnu.org>
1682
a66cfb1c
SM
1683 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1684 Default value is now t. Doc fix.
6bf7006f 1685
e3cbd34b 1686 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1687 logic when moving up, not only when moving down. Fix the
e3cbd34b 1688 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1689 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1690
1691 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1692 CHARPOS is covered by a display string which includes newlines.
1693 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1694 is covered by a display string with embedded newlines.
1695
a3de0cbd
MA
16962011-09-24 Michael Albinus <michael.albinus@gmx.de>
1697
1698 * dbusbind.c (Fdbus_register_signal): Add match rule to
1699 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1700 (Fdbus_register_method, Vdbus_registered_objects_table):
1701 Fix docstring.
a3de0cbd 1702
b260039d
JM
17032011-09-24 Jim Meyering <meyering@redhat.com>
1704
32c1fffd 1705 do not ignore write error for any output size
b260039d
JM
1706 The previous change was incomplete.
1707 While it makes emacs --batch detect the vast majority of stdout
1708 write failures, errors were still ignored whenever the output size is
1709 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1710 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1711 && echo FAIL: ignored write error
1712 FAIL: ignored write error
1713 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1714 && echo FAIL: ignored write error
1715 FAIL: ignored write error
1716 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1717
8eca8a7c
AS
17182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1719
1720 * emacs.c (Fkill_emacs): In noninteractive mode exit
1721 non-successfully if a write error occurred on stdout. (Bug#9574)
1722
3341db62
EZ
17232011-09-21 Eli Zaretskii <eliz@gnu.org>
1724
1725 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1726 the xassert test.
1727
1728 * dispextern.h (struct it): Update the comment documenting what
1729 can it->OBJECT be.
1730
8c203dbf
EZ
17312011-09-20 Eli Zaretskii <eliz@gnu.org>
1732
1733 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1734 a display string, extend search for cursor position to end of row.
1735 (find_row_edges): If the row ends in a newline from a display
1736 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1737 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1738 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1739 non-empty line. Fixes confusing cursor motion with arrow keys at
1740 the beginning of a line that starts with whitespace.
8c203dbf 1741
a4824228
LMI
17422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1743
1744 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1745 (bug#9493).
1746
33ed493b
CY
17472011-09-18 Chong Yidong <cyd@stupidchicken.com>
1748
1749 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1750 boolean (Bug#9154).
1751
56cd55c8
EZ
17522011-09-18 Eli Zaretskii <eliz@gnu.org>
1753
1754 * xdisp.c (display_line): Record maximum and minimum buffer
1755 positions even if no glyphs were produced (e.g., by a zero-width
1756 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1757 buffer positions that will be removed from the glyph row because
1758 they don't fit.
c02dcedf
EZ
1759 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1760 column is beyond frame width: don't subtract 1 "pixel" when
1761 computing width of the stretch.
3e62b7e0
EZ
1762 (reseat_at_next_visible_line_start): Undo the change made on
1763 2011-09-17 that saved paragraph information and restored it after
1764 the call to `reseat'. (Bug#9545)
56cd55c8 1765
5ed99d36 17662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1767
1768 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1769 and turn window cursor on if cleared (Bug#9415).
1770
5ed99d36 17712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1772
1773 * search.c (boyer_moore): Take unibyte characters from pattern
1774 literally. (Bug#9458)
1775
9bade7b2
EZ
17762011-09-18 Eli Zaretskii <eliz@gnu.org>
1777
1778 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1779
e5e9d610
PE
17802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1781
87e4427a
PE
1782 Fix minor problem found by static checking.
1783 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1784 initialized, to pacify gcc -Wuninitialized.
1785
e5e9d610
PE
1786 * fileio.c: Report proper errno when syscall falls.
1787 (Finsert_file_contents): Save and restore errno,
1788 so that report_file_error outputs the correct diagnostic.
1789 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1790
a1674f0b
EZ
17912011-09-18 Eli Zaretskii <eliz@gnu.org>
1792
1793 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1794
fbfb6dd4
EZ
17952011-09-17 Eli Zaretskii <eliz@gnu.org>
1796
1797 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1798 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1799
bb187662
EZ
18002011-09-17 Eli Zaretskii <eliz@gnu.org>
1801
1137e8b8 1802 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1803 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1804
1805 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1806 (bidi_find_paragraph_start): Search back for paragraph beginning
1807 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1808 (bidi_move_to_visually_next): Only trigger paragraph-related
1809 computations when the last character is a newline or at EOB, not
1810 just any NEUTRAL_B. (Bug#9470)
1811
bb187662
EZ
1812 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1813 truncated lines if point is covered by a display string. (Bug#9524)
1814
2e621251
PE
18152011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1818 (cons_to_x_long): New function.
1819 (lisp_data_to_selection_data): Use it. Correct the test for
1820 short-versus-long data; it was negated. Break out of vector
1821 loop, for efficiency, when a long datum is discovered.
1822
91a15bc6
SM
18232011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1824
1825 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1826
b41c3a35
EZ
18272011-09-16 Eli Zaretskii <eliz@gnu.org>
1828
1829 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1830 GCC PR/17406) by declaring this function with external scope.
1831
7812ba2d
PE
18322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1835 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1836
cf7edc2a
AS
18372011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1838
1839 * editfns.c (Fformat): Correctly handle text properties on "%%".
1840
bd01620e
EZ
18412011-09-15 Eli Zaretskii <eliz@gnu.org>
1842
1843 * xterm.c (x_draw_composite_glyph_string_foreground):
1844 * w32term.c (x_draw_composite_glyph_string_foreground):
1845 * term.c (encode_terminal_code):
1846 * composite.c (composition_update_it, get_composition_id):
1847 * xdisp.c (get_next_display_element)
1848 (fill_composite_glyph_string): Add comments about special meaning
1849 of TAB characters in a composition.
1850
a02719a3
PE
18512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1854 This occurs when processing a multibyte format.
1855 Problem reported by Wolfgang Jenker.
a02719a3 1856
72589a3c
JB
18572011-09-15 Johan Bockgård <bojohan@gnu.org>
1858
1859 * xdisp.c (try_cursor_movement): Only check for exact match if
1860 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1861
1c14176c
PE
18622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 Remove unused external symbols.
1865 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1866 * xdisp.c (calc_pixel_width_or_height): Now static.
1867 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1868 * indent.c (check_display_width):
1869 * w32term.c: Fix comment to match code.
1870 * xterm.c, xterm.h (x_catching_errors): Remove.
1871
d2eea5b5
PE
18722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * xselect.c: Use signed conversions more consistently (Bug#9498).
1875 (selection_data_to_lisp_data): Assume incoming selection data are
1876 signed integers, not unsigned. This is to be consistent with
1877 outgoing selection data, which was modified to use signed integers
1878 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1879 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1880 expects long, not unsigned long.
1881
46888499
EZ
18822011-09-14 Eli Zaretskii <eliz@gnu.org>
1883
1884 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1885 computation of loop end. Reported by Johan Bockgård
1886 <bojohan@gnu.org>.
1887
ef8ef9fb
CY
18882011-09-13 Chong Yidong <cyd@stupidchicken.com>
1889
1890 * frame.c (Fother_visible_frames_p): Function deleted.
1891
fa819fed
EZ
18922011-09-12 Eli Zaretskii <eliz@gnu.org>
1893
1894 * indent.c (compute_motion): Process display vector front to back
1895 rather than the other way around. (Bug#2496)
1896
2ba8e008
SM
18972011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1898
1899 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1900
20f53c69
CY
19012011-09-11 Chong Yidong <cyd@stupidchicken.com>
1902
1903 * minibuf.c (Fread_from_minibuffer): Doc fix.
1904
d562d7a4
EZ
19052011-09-11 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1908 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1909
1c4d7f3d
LMI
19102011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1911
1912 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1913 value for non-existent files.
1914
b885bf36
EZ
19152011-09-11 Eli Zaretskii <eliz@gnu.org>
1916
1917 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1918 set its "size" to -1. This will set the modtime_size field of
1919 the corresponding buffer to -1, which is what
1920 verify-visited-file-modtime expects for files that do not exist.
1921 (Bug#9139)
1922
6612f0bf
PE
19232011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1926 here ...
1927 * lisp.h: ... from here. push_key_description is no longer
1928 defined in keyboard.c, so its declaration should not be in
1929 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1930 logically belongs with push_key_description.
1931
dfb3f755
PE
19322011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * buffer.h: Include <sys/types.h> instead of <time.h>.
1935 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1936 Problem reported by Herbert J. Skuhra.
1937
3134906c
LMI
19382011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1939
1940 * xml.c (parse_region): Make the parsing work for
1941 non-comment-starting XML files again (bug#9144).
1942
8d903f4e
AS
19432011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1944
1945 * image.c (gif_load): Fix calculation of bottom and right corner.
1946 (Bug#9468)
1947
80ad64f4
EZ
19482011-09-10 Eli Zaretskii <eliz@gnu.org>
1949
1950 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1951 redisplay in small windows.
1952
208a048d
EZ
19532011-09-09 Eli Zaretskii <eliz@gnu.org>
1954
1955 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1956
9b1c252e
MR
19572011-09-08 Martin Rudalics <rudalics@gmx.at>
1958
1959 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1960 Operate on live windows only.
1961
2949f33b
JB
19622011-09-08 Juanma Barranquero <lekktu@gmail.com>
1963
1964 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1965
e08dcafd
EZ
19662011-09-07 Eli Zaretskii <eliz@gnu.org>
1967
1968 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1969 only under bidi iteration.
1970
115b96bd
JD
19712011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1972
1973 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1974
c8199d0f
PE
19752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1978 Without this fix, the command to link temacs failed due to an
1979 undefined symbol __builtin_isnan. This is because
1980 /usr/include/iso/math_c99.h #defines isnan(x) to
1981 __builtin_isnan(x), but the bundled gcc, which identifies itself
1982 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1983 a __builtin_isnan.
1984 * floatfns.c (isnan): #undef, and then #define to a clone of
1985 what's in data.c.
1986 (Fisnan): Always define, since it's always available now.
1987 (syms_of_floatfns): Always define isnan at the Lisp level.
1988
e39b275c 19892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1990
1991 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1992
b2db44d9 19932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1994
f4af5137 1995 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1996 The previous code assumed that file offsets (off_t values) fit in
1997 EMACS_INT variables, which is not true on typical 32-bit hosts.
1998 The code messed up by falsely reporting buffer overflow in cases
1999 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2000 when "big" contains more than 2**29 bytes, even though this
2001 inserts just one byte and does not overflow the buffer.
2002 (Finsert_file_contents): Store file offsets as off_t
2003 values, not as EMACS_INT values. Check for overflow when
2004 converting between EMACS_INT and off_t. When checking for
2005 buffer overflow or for overlap, take the offsets into account.
2006 Don't use EMACS_INT for small values where int suffices.
2007 When checking for overlap, fix a typo: ZV was used where
2008 ZV_BYTE was intended.
2009 (Fwrite_region): Don't assume off_t fits into 'long'.
2010 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2011
ecfc0a49
MA
20122011-09-05 Michael Albinus <michael.albinus@gmx.de>
2013
2014 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2015
6511acf2 20162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2017
0999621a 2018 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2019
2020 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2021 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2022 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2023 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2024 (modify_event_symbol): Do not assume that the length of
2025 name_alist_or_stem is safe to alloca and fits in int.
2026 (Fexecute_extended_command): Likewise for function name and binding.
2027 (Frecursion_depth): Wrap around reliably on integer overflow.
2028 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2029 since some callers pass EMACS_INT values.
2030 (Fsingle_key_description): Don't crash if symbol name contains more
2031 than MAX_ALLOCA bytes.
2032 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2033 (get_minibuffer): Arg is now EMACS_INT, not int.
2034 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2035 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2036 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2037
2be7d702
PE
2038 * dbusbind.c (signature_cat): New function.
2039 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2040 Do not overrun buffer; instead, report string overflow.
2041
9d1df220
PE
2042 * dispnew.c (add_window_display_history): Don't overrun buffer.
2043 Truncate instead; this is OK since it's just a log.
2044
33ef5c64
PE
2045 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2046 even if the time zone offset is outlandishly large.
2047 Don't mishandle offset == INT_MIN.
2048
66c6fdd5
PE
2049 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2050 when creating daemon; the previous buffer-overflow check was incorrect.
2051
d749b01b
PE
2052 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2053 which has the guts of the old verror function.
2054
b5cd1905
PE
2055 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2056 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2057
6e1a67fb
PE
2058 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2059 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2060 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2061 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2062 length of string rather than counting it via multiple sprintfs;
2063 that's simpler and more reliable.
c21721cc
PE
2064 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2065 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2066 sprintf, in case result does not fit in int.
2067
c57b67fc
PE
2068 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2069 (fontset_from_font): Print it.
2070
8a401434
PE
2071 * frame.c (tty_frame_count): Now printmax_t, not int.
2072 (make_terminal_frame, set_term_frame_name): Print it.
2073 (x_report_frame_params): In X, window IDs are unsigned long,
2074 not signed long, so print them as unsigned.
2075 (validate_x_resource_name): Check for implausibly long names,
2076 and don't assume name length fits in 'int'.
2077 (x_get_resource_string): Don't blindly alloca invocation name;
2078 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2079 not fit in int.
2080
6e1a67fb
PE
2081 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2082 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2083 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2084
0df02bf3
PE
2085 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2086 Use esprintf, not sprintf, in case result does not fit in int.
2087
48e30793
PE
2088 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2089 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2090 it as a large positive number.
2091 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2092 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2093
a66ff6d8
PE
2094 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2095 in case result does not fit in int.
2096
aca216ff
PE
2097 * print.c (float_to_string): Detect width overflow more reliably.
2098 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2099 buffer overrun. Don't assume list length fits in 'int'. Treat
2100 print length of 0 as 0, not as infinity; to be consistent with other
2101 uses of print length in this function. Don't overflow print length
2102 index. Don't assume hash table size fits in 'long', or that
2103 vectorlike size fits in 'unsigned long'.
2104
31c286f7
PE
2105 * process.c (make_process): Use printmax_t, not int, to format
2106 process-name gensyms.
2107
55e5faa1
PE
2108 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2109
80f2e268
PE
2110 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2111 to avoid potential buffer overrun.
2112
670741ab
PE
2113 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2114 if X resource line is longer than 512 bytes.
2115
b7163a50
PE
2116 * xfns.c (x_window): Make sprintf buffer a bit bigger
2117 to avoid potential buffer overrun.
2118
ae58ff1f
PE
2119 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2120
c43c8a6a
PE
2121 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2122
3f8236f4
PE
21232011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2124
53e9fe90 2125 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2126 Without these, Emacs silently mishandles large integers sometimes.
2127 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2128 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2129
6511acf2
PE
2130 * xdisp.c (try_window_id): Check Emacs fixnum range before
2131 converting to 'int'.
806add1d 2132
6511acf2 2133 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2134 Check that an Emacs fixnum is in range before assigning it to 'int'.
2135 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2136 values converted from Emacs fixnums.
2137 (Frecenter): Don't wrap around a line count if it is out of 'int'
2138 range; instead, treat it as an extreme value.
2139 (Fset_window_configuration, compare_window_configurations):
2140 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2141
6511acf2
PE
2142 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2143 that can exceed INT_MAX. Check that EMACS_INT value is in range
2144 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2145 (match_limit): Don't assume that a fixnum can fit in 'int'.
2146
6511acf2 2147 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2148 exceed INT_MAX.
2149
6511acf2 2150 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2151 (Fvertical_motion): Don't wrap around LINES values that don't fit
2152 in 'int'. Instead, treat them as extreme values. This is good
2153 enough for windows, which can't have more than INT_MAX lines anyway.
2154
fcb901a7
LMI
21552011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2156
0f2f6b6d
LMI
2157 * Require libxml/parser.h to avoid compilation warning.
2158
fcb901a7
LMI
2159 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2160
2161 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2162 since this reportedly can destroy thread storage.
2163
6e20a0d4
CY
21642011-08-30 Chong Yidong <cyd@stupidchicken.com>
2165
2166 * syntax.c (find_defun_start): Update all cache variables if
2167 exiting early (Bug#9401).
2168
148ae00e
EZ
21692011-08-30 Eli Zaretskii <eliz@gnu.org>
2170
f6cfbd8f
EZ
2171 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2172
148ae00e
EZ
2173 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2174 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2175 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2176
2177 * term.c (tty_append_glyph): New function.
2178 (produce_stretch_glyph): Static function and its prototype deleted.
2179
a66cfb1c
SM
2180 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2181 Add prototypes.
148ae00e 2182
c4a07a4c
PE
21832011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2184
2185 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2186 when checking :margin (Bug#9390).
2187 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2188 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2189 so that the name doesn't mislead. All uses changed.
2190
6bc8cd65
JB
21912011-08-28 Johan Bockgård <bojohan@gnu.org>
2192
2193 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2194 set_tty_hooks.
2195
dca4927e
EZ
21962011-08-27 Eli Zaretskii <eliz@gnu.org>
2197
2198 * xdisp.c (move_it_to): Don't bail out early when reaching
2199 position beyond to_charpos, if we are scanning backwards.
2200 (move_it_vertically_backward): When DY == 0, make sure we get to
2201 the first character in the line after the newline.
2202
f2cad773
PE
22032011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2206 (ccl_driver): Do not generate an out-of-range pointer.
2207 (Fccl_execute_on_string): Remove unnecessary check for
2208 integer overflow, noted by Stefan Monnier in
2209 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2210 Remove a FIXME that didn't need fixing.
2211 Simplify the newly-introduced buffer reallocation code.
2212
0cae2cdb
JB
22132011-08-27 Juanma Barranquero <lekktu@gmail.com>
2214
2215 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2216
5fc295a4 22172011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2218
70c60eb2 2219 Integer and memory overflow issues (Bug#9196).
726e0ab1 2220
d31850da
PE
2221 * doc.c (get_doc_string): Rework so that
2222 get_doc_string_buffer_size is the actual buffer size, rather than
2223 being 1 less than the actual buffer size; this makes xpalloc more
2224 convenient.
2225
a69fbedb
PE
2226 * image.c (x_allocate_bitmap_record, cache_image):
2227 * xselect.c (Fx_register_dnd_atom):
2228 Simplify previous changes by using xpalloc.
2229
fe5c5d37
PE
2230 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2231 since either will do and ptrdiff_t is convenient with xpalloc.
2232
0065d054
PE
2233 * charset.c (charset_table_size)
2234 (struct charset_sort_data.priority): Now ptrdiff_t.
2235 (charset_compare): Don't overflow if priorities differ greatly.
2236 (Fsort_charsets): Don't assume list length fits in int.
2237 Check for size-calculation overflow when allocating sort data.
2238 (syms_of_charset): Allocate an initial charset table that is
2239 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2240
2241 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2242
2243 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2244 The actual value is always <= INT_MAX, and leaving it unsigned made
2245 overflow checking harder.
2246
2247 * dispextern.h (struct glyph_matrix.rows_allocated)
2248 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2249 with xpalloc. The values are still always <= INT_MAX.
2250
2251 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2252
2253 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2254 (SAFE_NALLOCA): New macro.
2255
2256 * region-cache.c (struct boundary.pos, find_cache_boundary)
2257 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2258 (set_cache_region, invalidate_region_cache)
2259 (revalidate_region_cache, know_region_cache, region_cache_forward)
2260 (region_cache_backward, pp_cache):
2261 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2262 so that ptrdiff_t * can be passed to xpalloc.
2263 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2264 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2265 (pp_cache): Don't assume cache_len fits in int.
2266 * region-cache.h: Adjust extern decls to match.
2267
2268 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2269 EMACS_INT, since either will do, for xpalloc.
2270
2271 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2272 (xnmalloc, xnrealloc, xpalloc): New functions.
2273
726e0ab1
PE
2274 * bidi.c (bidi_shelve_header_size): New constant.
2275 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2276 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2277
51f30bc5 2278 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2279 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2280 (overlay_strings):
2281 Don't update size of array until after memory allocation succeeds,
2282 because xmalloc/xrealloc may not return.
0065d054
PE
2283 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2284 now that we have proper integer overflow checking.
2285 (record_overlay_string, overlay_strings): Catch overflows when
2286 calculating size of overlay_str_buf.
726e0ab1 2287
0065d054
PE
2288 * callproc.c (Fcall_process): Check for size overflow when
2289 calculating size of args2.
2290 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2291 Normally we prefer signed values, but sticking with ptrdiff_t would
2292 require adding more-complicated checks.
726e0ab1
PE
2293
2294 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2295 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2296 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2297 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2298
2299 * character.c (Fstring): Check for size-calculation overflow.
2300
2301 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2302 unnecessary integer overflow. Check for size overflow.
2303 (encode_coding_object): Don't update size until xmalloc succeeds.
2304
2305 * composite.c (get_composition_id): Check for overflow in glyph
2306 length calculations.
2307
2308 Integer and memory overflow fixes for display code.
2309 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2310 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2311 (scrolling_window): Check for overflow in size calculations.
2312 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2313 Don't assume glyph table len fits in int.
2314 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2315 (row_table_size): Now ptrdiff_t, not int.
2316 (scrolling_window): Avoid overflow in size calculations.
2317 Don't update size until allocation succeeds.
2318 * fns.c (concat): Check for overflow in size calculations.
2319 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2320 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2321 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2322
2323 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2324 (get_doc_string): Check for size calculation overflow.
2325 Don't update size until allocation succeeds.
2326 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2327 EMACS_INT, where ptrdiff_t will do.
2328 (Fsubstitute_command_keys): Check for string overflow.
2329
2330 * editfns.c (set_time_zone_rule): Don't assume environment length
2331 fits in int.
2332 (message_length): Now ptrdiff_t, not int.
2333 (Fmessage_box): Don't update size until allocation succeeds.
2334 Don't assume message length fits in int.
2335 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2336
0065d054
PE
2337 * emacs.c (main): Do not reallocate argv, since there is a null at
2338 the end that can be overwritten, and this way there's no need to
2339 worry about size-calculation overflow.
2340 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2341
2342 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2343 alloc succeeds.
2344 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2345
2346 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2347 (x_set_scroll_bar_width, x_figure_window_size):
2348 Check for integer overflow.
2349 (x_set_alpha): Do not assume XINT fits in int.
2350
2351 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2352 This is for the members text_lines, text_cols, total_lines, total_cols,
2353 where the system imposes an 'int' limit.
2354
2355 * fringe.c (Fdefine_fringe_bitmap):
2356 Don't update size until alloc works.
2357
2358 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2359 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2360
2361 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2362 Check for size-calculation overflow.
2363 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2364 do, as we prefer signed integers.
2365 (id_to_widget.max_size, id_to_widget.used)
2366 (xg_store_widget_in_map, xg_remove_widget_from_map)
2367 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2368 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2369 Use and return ptrdiff_t, not int.
2370 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2371 * gtkutil.h: Change prototypes to match the above.
2372
2373 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2374 are duplicate now that they've been promoted to lisp.h.
2375 (x_allocate_bitmap_record, x_alloc_image_color)
2376 (make_image_cache, cache_image, xpm_load):
2377 Don't update size until alloc is done.
2378 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2379 (x_detect_edges):
3256efce 2380 Check for size calculation overflow.
726e0ab1
PE
2381 (ct_colors_allocated_max): New constant.
2382 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2383 overflow.
3256efce 2384
726e0ab1
PE
2385 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2386 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2387 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2388 Use ptrdiff_t, not int, to count maps.
2389 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2390 calculations. Don't update size until allocation succeeds.
2391 Redo calculations to avoid overflow.
726e0ab1
PE
2392 * keyboard.h: Change prototypes to match the above.
2393
2394 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2395 to count maps.
2396 (current_minor_maps): Check for size calculation overflow.
2397 * keymap.h: Change prototypes to match the above.
2398
2399 * lread.c (read1, init_obarray): Don't update size until alloc done.
2400
2401 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2402 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2403
726e0ab1
PE
2404 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2405 Now ptrdiff_t, not int.
2406 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2407 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2408
2409 * process.c (Fnetwork_interface_list): Check for overflow
2410 in size calculation.
2411
2412 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2413
2414 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2415 overflow. Don't bother calling xmalloc when xrealloc will do.
2416
2417 * search.c (Freplace_match): Check for size calculation overflow.
2418 (Fset_match_data): Don't assume list lengths fit in 'int'.
2419
2420 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2421 for command line length. Do not attempt to address one before the
2422 beginning of an array, as that's not portable.
2423
2424 * term.c (max_frame_lines): Remove; unused.
2425 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2426 not int.
2427 (encode_terminal_code, calculate_costs): Check for size
2428 calculation overflow.
2429 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2430 table lengths and related sizes. Don't update size until alloc
2431 done. Redo calculations to avoid overflow.
2432 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2433
2434 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2435 subtracting pointers.
2436 (gobble_line): Check for overflow more carefully. Don't update size
2437 until alloc done.
2438
2439 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2440 Don't update size until alloc done.
2441 Redo size calculations to avoid overflow.
2442 Check for size calculation overflow.
0065d054 2443 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2444
2445 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2446 Use ptrdiff_t, not int, for sizes.
2447 (store_mode_line_noprop_char): Don't update size until alloc done.
2448
0065d054
PE
2449 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2450 Use ptrdiff_t, not int, for sizes.
2451 (Finternal_make_lisp_face, cache_face):
2452 Check for size calculation overflow.
2453 (cache_face): Treat size calculation overflows as if they were
2454 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2455
2456 * xfns.c (x_encode_text, x_set_name_internal)
2457 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2458 sizes, since they can exceed INT_MAX in size. Check for size
2459 calculation overflow.
2460
0065d054
PE
2461 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2462 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2463 Don't update size until alloc done.
2464
0065d054 2465 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2466 as sprintf is limited to int lengths.
1d526e2f 2467
252c5ee1
PE
2468 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2469 (X_LONG_MIN): New macros.
864d7ce7
PE
2470 Use them to make the following changes clearer.
2471 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2472 This change doesn't affect the value now, but it may help remind
2473 future maintainers not to raise the value too much later.
2474 (SELECTION_QUANTUM): Remove, replacing with ...
2475 (selection_quantum): ... new function, which avoids overflow.
2476 All uses changed.
2477 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2478 assumption that selection length fits in 'int'.
2479 (x_reply_selection_request, x_handle_selection_request)
2480 (x_get_window_property, receive_incremental_selection)
2481 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2482 (lisp_data_to_selection_data, clean_local_selection_data):
2483 Use ptrdiff_t, not int, to record length of selection.
2484 (x_reply_selection_request, x_get_window_property)
2485 (receive_incremental_selection, x_property_data_to_lisp):
2486 Redo calculations to avoid overflow.
2487 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2488 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2489 something.
2490 (x_get_window_property, receive_incremental_selection)
2491 (lisp_data_to_selection_data, x_property_data_to_lisp):
2492 Check for size-calculation overflow.
2493 (x_get_window_property, receive_incremental_selection)
2494 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2495 Don't store size until memory allocation succeeds.
2496 (x_get_window_property): Plug memory leak on memory exhaustion.
2497 Don't double-block input; malloc is safe here. Don't assume 2**34
2498 - 4 fits in unsigned long. Add an xassert to check
2499 XGetWindowProperty overflow. Be more careful about overflow
2500 calculations, and distinguish size from memory overflow better.
2501 (receive_incremental_selection): When tracing, don't assume
2502 unsigned int is less than INT_MAX.
2503 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2504 harmful) conversions of unsigned short to int.
2505 (lisp_data_to_selection_data): Don't assume that integers
2506 in the range -65535 through -1 fit in an X unsigned short.
2507 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2508 result parameters unless successful. Rely on cons_to_unsigned
2509 to report problems with elements; the old code wasn't right anyway.
2510 (x_check_property_data): Check for int overflow; we cannot use
2511 a wider type due to X limits.
2512 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2513
726e0ab1 2514 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2515
0065d054
PE
2516 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2517 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2518 (x_color_cells): Don't store size until memory allocation succeeds.
2519 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2520 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2521 (x_term_init): Don't assume length fits in int (sprintf is limited
2522 to int size).
bc18e09d 2523
ebfa62c0
PE
2524 Use ptrdiff_t for composition IDs.
2525 * character.c (lisp_string_width):
2526 * composite.c (composition_table_size, n_compositions)
2527 (get_composition_id, composition_gstring_from_id):
2528 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2529 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2530 * window.c (Frecenter):
2531 Use ptrdiff_t, not int, for composition IDs.
2532 * composite.c (get_composition_id): Check for integer overflow.
2533 * composite.h: Adjust prototypes to match the above changes.
2534
d3411f89
PE
2535 Use ptrdiff_t for hash table indexes.
2536 * category.c (hash_get_category_set):
2537 * ccl.c (ccl_driver):
2538 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2539 * coding.c (coding_system_charset_list, detect_coding_system):
2540 * coding.h (struct coding_system.id):
2541 * composite.c (get_composition_id, gstring_lookup_cache):
2542 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2543 * image.c (xpm_get_color_table_h):
2544 * lisp.h (hash_lookup, hash_put):
2545 * minibuf.c (Ftest_completion):
2546 Use ptrdiff_t for hash table indexes, not int (which is too
2547 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2548 32-bit --with-wide-int hosts).
2549
e097a6fa
PE
2550 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2551 Add a FIXME comment about memory leaks.
2552 (syms_of_charset): Don't assume xmalloc returns.
2553
5637687f
PE
2554 Don't assume that stated character widths fit in int.
2555 * character.c (Fchar_width, c_string_width, lisp_string_width):
2556 * character.h (CHAR_WIDTH):
2557 * indent.c (MULTIBYTE_BYTES_WIDTH):
2558 Use sanitize_char_width to avoid undefined and/or bad behavior
2559 with outlandish widths.
a66cfb1c 2560 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2561 now that we have two such functions. All uses changed.
2562 (sanitize_char_width): New inline function.
2563
a2271ba2
PE
2564 Don't assume that tab-width fits in int.
2565 * character.h (sanitize_width): New inline function.
2566 (SANE_TAB_WIDTH): New macro.
2567 (ASCII_CHAR_WIDTH): Use it.
2568 * indent.c (sane_tab_width): Remove. All uses replaced by
2569 SANE_TAB_WIDTH (current_buffer).
2570 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2571
18c52557
PE
2572 * fileio.c: Integer overflow issues with file modes.
2573 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2574
caeeedc1
PE
2575 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2576 Remove unreachable code.
2577 (read_hex, load_charset_map_from_file): Check for integer overflow.
2578
6df6ae42 2579 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2580 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2581 (x_send_scroll_bar_event): Likewise. Check that the size does not
2582 exceed limits imposed by XClientMessageEvent, as well as the usual
2583 ptrdiff_t and size_t limits.
2584
b13995db
PE
2585 * keyboard.c: Overflow, signedness and related fixes.
2586 (make_lispy_movement): Use same integer type in forward decl
2587 that is used in the definition.
2588 (read_key_sequence, keyremap_step):
2589 Change bufsize argument back to int, undoing my 2011-03-30 change.
2590 We prefer signed types, and int is wide enough here.
2591 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2592 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2593 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2594 length, not size_t. Use ptrdiff_t for index, not int.
2595 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2596 possibility of integer overflow.
2597
13464394
PE
2598 Overflow, signedness and related fixes for images.
2599
2600 * dispextern.h (struct it.stack[0].u.image.image_id)
2601 (struct_it.image_id, struct image.id, struct image_cache.size)
2602 (struct image_cache.used, struct image_cache.ref_count):
2603 * gtkutil.c (update_frame_tool_bar):
2604 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2605 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2606 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2607 * nsmenu.m (update_frame_tool_bar):
2608 * xdisp.c (calc_pixel_width_or_height):
2609 * xfns.c (image_cache_refcount):
2610 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2611 on typical 64-bit hosts.
2612
2613 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2614 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2615 Omit unnecessary casts to int.
2616 (parse_image_spec): Check that integers fall into 'int' range
2617 when the callers expect that.
2618 (image_ascent): Redo ascent calculation to avoid int overflow.
2619 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2620 (lookup_image): Remove unnecessary tests.
2621 (xbm_image_p): Locals are now of int, not EMACS_INT,
2622 since parse_image_check makes sure they fit into int.
2623 (png_load, gif_load, svg_load_image):
2624 Prefer int to unsigned where either will do.
2625 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2626 old tiff_error_handler and tiff_warning_handler.
2627 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2628 stack buffer overflows. It uses only the features of vsnprintf
2629 that are common to both POSIX and native Microsoft.
2630 (tiff_error_handler, tiff_warning_handler): Use it.
2631 (tiff_load, gif_load, imagemagick_load_image):
2632 Don't assume :index value fits in 'int'.
2633 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2634 (imagemagick_load_image): Check that crop parameters fit into
2635 the integer types that MagickCropImage accepts. Don't assume
2636 Vimagemagick_render_type has a nonnegative value. Don't assume
2637 size_t fits in 'long'.
2638 (gs_load): Use printmax_t to print the widest integers possible.
2639 Check for integer overflow when computing image height and width.
2640
c11821d4
EZ
26412011-08-26 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (redisplay_window): Don't force window start if point
2644 will be invisible in the resulting window. (Bug#9324)
2645
0c95fcf7
EZ
26462011-08-25 Eli Zaretskii <eliz@gnu.org>
2647
2648 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2649 the display spec is of the form `(space ...)'.
2650 (handle_display_spec): Return the value returned by
2651 handle_single_display_spec, not just 1 or zero.
2652 (handle_single_display_spec): If the display spec is of the form
2653 `(space ...)', and specifies display in the text area, return 2
2654 rather than 1.
fee65a97 2655 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2656 accurately, and prefer exact match for point under bidi.
2657 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2658
2659 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2660 into disp_prop; all users changed.
2661
2662 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2663 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2664 for the text covered by the display property.
2665
e4ed06f1
CY
26662011-08-25 Chong Yidong <cyd@stupidchicken.com>
2667
2668 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2669 Change return value to nil.
2670 (Frecord_buffer): Delete unused function.
2671
f67cdd7f
EZ
26722011-08-24 Eli Zaretskii <eliz@gnu.org>
2673
5980d4c6
EZ
2674 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2675 buffers, return left-to-right.
8610fe8b
EZ
2676 (set_cursor_from_row): Consider candidate row a win if its glyph
2677 represents a newline and point is on that newline. Fixes cursor
2678 positioning on the newline at EOL of R2L text within L2R
2679 paragraph, and vice versa.
2680 (try_cursor_movement): Check continued rows, in addition to
2681 continuation rows. Fixes unwarranted scroll when point enters a
2682 continued line of R2L text within an L2R paragraph, or vice versa.
2683 (cursor_row_p): Consider the case of point being equal to
2684 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2685 from the end of a short line to the beginning of a continued line
2686 of R2L text within L2R paragraph.
2687 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2688 composed characters.
5980d4c6 2689
f67cdd7f
EZ
2690 * bidi.c (bidi_check_type): Use xassert.
2691 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2692 members.
2693
bca633fb
EZ
26942011-08-23 Eli Zaretskii <eliz@gnu.org>
2695
2696 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2697 a character.
2698
4a5885a7
CY
26992011-08-23 Chong Yidong <cyd@stupidchicken.com>
2700
2701 * nsfont.m (ns_otf_to_script): Fix typo.
2702
0902a04e
KH
27032011-08-22 Kenichi Handa <handa@m17n.org>
2704
2705 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2706 extra slot even if the purpose is char-code-property-table.
2707
1a2e6670
EZ
27082011-08-23 Eli Zaretskii <eliz@gnu.org>
2709
8ddde651
EZ
2710 * xdisp.c (redisplay_window): When computing centering_position,
2711 account for the height of the header line. (Bug#8874)
2712
425cc014
EZ
2713 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2714 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2715 candidate is selected by the mouse, and that candidate has a
2716 composed character under the mouse.
2717
1a2e6670
EZ
2718 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2719 coordinates reported by pos-visible-in-window-p for a composed
2720 character in column zero.
2721
8b76d6f8
SM
27222011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2723
2724 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2725
dac347dd
EZ
27262011-08-22 Eli Zaretskii <eliz@gnu.org>
2727
2728 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2729 consider it a hit if to_charpos is anywhere in the range of the
2730 composed buffer positions.
2731
e013fb34
CY
27322011-08-22 Chong Yidong <cyd@stupidchicken.com>
2733
2734 * image.c (gif_load): Don't assume that each subimage has the same
2735 dimensions as the base image. Handle disposal method that is
2736 "undefined" by the gif spec (Bug#9335).
2737
bd1ba3e8
CY
27382011-08-20 Chong Yidong <cyd@stupidchicken.com>
2739
2740 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2741 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2742
54a1215b
EZ
27432011-08-19 Eli Zaretskii <eliz@gnu.org>
2744
823564e5
EZ
2745 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2746 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2747 from an Org mode buffer to a Speedbar frame.
2748
54a1215b
EZ
2749 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2750 a composition, take its buffer position from IT->cmp_it.charpos.
2751 Fixes cursor positioning at the beginning of a line that begins
2752 with a composed character.
2753
9778ebcc
EZ
27542011-08-18 Eli Zaretskii <eliz@gnu.org>
2755
0be6ee06
EZ
2756 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2757 character bidirectional type, use STRONG_L instead. Fixes crashes
2758 in a buffer produced by `describe-categories'.
2759
9778ebcc
EZ
2760 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2761 members before the level stack, so they would be saved and
2762 restored when copying iterator state. Fixes incorrect reordering
2763 around TABs covered by display properties.
2764
156bffbe
AS
27652011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2766
6b02f655 2767 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2768
72ad093b
CY
27692011-08-17 Chong Yidong <cyd@stupidchicken.com>
2770
2771 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2772 (internal_condition_case_2, internal_condition_case_n):
2773 Remove unnecessary aborts (Bug#9081).
72ad093b 2774
35774242
EZ
27752011-08-17 Eli Zaretskii <eliz@gnu.org>
2776
2777 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2778 has no `load' handler, try opening the file locally. (Bug#9311)
2779
db76dd85
KB
27802011-08-16 Ken Brown <kbrown@cornell.edu>
2781
2782 * gmalloc.c: Expand comment.
2783
b215eee5
EZ
27842011-08-16 Eli Zaretskii <eliz@gnu.org>
2785
2786 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2787 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2788
a4579d33
KB
27892011-08-16 Ken Brown <kbrown@cornell.edu>
2790
2791 Fix memory allocation problems in Cygwin build (Bug#9273).
2792
2793 * unexcw.c ( __malloc_initialized): Declare external variable.
2794 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2795
8b76d6f8
SM
2796 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2797 New variables.
a4579d33
KB
2798 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2799 dumped emacs.
2800 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2801 in the static heap.
2802 [CYGWIN] (special_realloc): New function.
2803 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2804 requests to realloc storage in the static heap.
2805
3ebec551
PE
28062011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2807
2808 * bidi.c (bidi_initialize): Remove unused local.
2809
9fd8be00
EZ
28102011-08-15 Eli Zaretskii <eliz@gnu.org>
2811
6b02f655
SM
2812 * bidimirror.h:
2813 * biditype.h: Remove file.
2814 * makefile.w32-in ($(BLD)/bidi.$(O)):
2815 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2816
2817 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2818
2819 * chartab.c: Improve commentary for the uniprop_table API.
2820
32413314
EZ
2821 * bidi.c (bidi_paragraph_init): Support zero value of
2822 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2823 (bidi_initialize): Use uniprop_table instead of including
2824 biditype.h and bidimirror.h.
32413314 2825
9fd8be00
EZ
2826 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2827 coordinates of the iterator when restoring from ppos_it.
2828 (Bug#9296)
2829
5cf2b69b
KH
28302011-08-14 Kenichi Handa <handa@m17n.org>
2831
2832 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2833 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2834
daf17d00
EZ
28352011-08-14 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (move_it_in_display_line_to): Don't invoke
2838 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2839 ppos_it. Fixes vertical cursor motion when line beginning is
2840 covered by an image. (Bug#9296)
2841
08e3161a
JD
28422011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2843
2844 * nsterm.h (ns_run_ascript): Declare.
2845 (NSAPP_DATA2_RUNASSCRIPT): Define.
2846
2847 * nsfns.m (as_script, as_result, as_status): New static variables.
2848 (ns_run_ascript): New function.
5e617bc2 2849 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2850 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2851 the event loop. Get status from as_status (Bug#7276).
2852
2853 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2854 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2855 the event loop (Bug#7276).
2856
a3720aa2
AS
28572011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2858
2859 * gnutls.c (QCgnutls_bootprop_priority)
2860 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2861 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2862 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2863 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2864 (QCgnutls_bootprop_verify_hostname_error)
2865 (QCgnutls_bootprop_callbacks_verify): Rename from
2866 Qgnutls_bootprop_..., all uses changed.
2867
2868 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2869 uses changed.
2870
0a0d27fb
PE
28712011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2872
19d5c50c
PE
2873 * xfaces.c (Qframe_set_background_mode): Now static.
2874 * dispextern.h (Qframe_set_background_mode): Remove decl.
2875
0a0d27fb
PE
2876 * process.c (Fnetwork_interface_info): Declare local only if needed.
2877
377538cb
JD
28782011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2879
2880 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2881 (Fnetwork_interface_list): Allocate in increments of bytes instead
2882 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2883 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2884 sockaddr.
2885 (struct ifflag_def): notrailers is smart on OSX.
2886 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2887 Get hardware address with getifaddrs if available.
2888
08fff70c
EZ
28892011-08-12 Eli Zaretskii <eliz@gnu.org>
2890
2891 * xdisp.c (iterate_out_of_display_property): xassert that
2892 IT->position is set to within IT->object's boundaries. Break from
2893 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2894 when IT->position is set up wrongly due to some bug.
2895 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2896 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2897 entry. Force push_it to save on the stack the current
2898 buffer/string position, to be restored by pop_it. Fix flags in
2899 the iterator structure wrt the object coming from a display
2900 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2901 properties. (Bug#9284)
2902
7be1c708 29032011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2904
7be1c708
CY
2905 * fontset.c (fontset_get_font_group): Add proper type checks.
2906 (Bug#9172)
aac0c6e3 2907
7be1c708 29082011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2909
7be1c708
CY
2910 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2911 and LC_VERSION_MIN_MACOSX.
2912 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2913 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2914
97bb72a6
EZ
29152011-08-08 Eli Zaretskii <eliz@gnu.org>
2916
2917 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2918 no-display-properties-and-no-overlays under bidi display.
2919 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2920 properties and overlays.
97bb72a6 2921
d5617611
CY
29222011-08-08 Chong Yidong <cyd@stupidchicken.com>
2923
37e11a63
CY
2924 * editfns.c (Fset_time_zone_rule): Document relationship with the
2925 setenv function.
2926
d5617611
CY
2927 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2928 the font entity extracted from the cache (Bug#8109).
2929
58872834
CY
29302011-08-07 Chong Yidong <cyd@stupidchicken.com>
2931
2932 * composite.c (autocmp_chars): Don't reset point. That is done by
2933 restore_point_unwind (Bug#5984).
2934
75bfc667
JL
29352011-08-07 Juri Linkov <juri@jurta.org>
2936
2937 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2938 to show the arg `TIME' instead of `TIMEVAL'.
2939
d1410150
EZ
29402011-08-06 Eli Zaretskii <eliz@gnu.org>
2941
2942 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2943 display property strides EOL and includes a newline, as in
2944 longlines-mode. (Bug#9254)
75b771e4
EZ
2945 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2946 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2947
2948 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2949 is non-zero, even if the data buffer is NULL. Fixes a crash in
2950 vertical-motion with longlines-mode. (Bug#9254)
2951
35928349
EZ
29522011-08-05 Eli Zaretskii <eliz@gnu.org>
2953
ec7cc85b
EZ
2954 * bidi.c <bidi_cache_total_alloc>: Now static.
2955 (bidi_initialize): Initialize bidi_cache_total_alloc.
2956
8b76d6f8 2957 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2958 cache. (Bug#9221)
2959
2960 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2961 amount allocated this far in `bidi_cache_total_alloc'.
2962 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2963 non-zero, only free the data buffer without restoring the cache
2964 contents. All callers changed.
2965
2966 * dispextern.h (bidi_unshelve_cache): Update prototype.
2967
2968 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2969 (move_it_in_display_line, move_it_to)
2970 (move_it_vertically_backward, move_it_by_lines): Replace the call
2971 to xfree to an equivalent call to bidi_unshelve_cache.
2972 (move_it_in_display_line_to): Fix logic of returning
412b6358 2973 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2974
e2e2423b
EZ
29752011-08-05 Eli Zaretskii <eliz@gnu.org>
2976
2977 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2978 came from a string character with a `cursor' property. (Bug#9229)
2979
ae9e757a
JD
29802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * Makefile.in (LIB_PTHREAD): New variable.
2983 (LIBES): Add LIB_PTHREAD (Bug#9216).
2984
2985 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2986 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2987
213bd7f2
AS
29882011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2989
6b02f655 2990 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2991
99aaf75f
JD
29922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2993
2994 * xterm.c (x_find_topmost_parent): New function.
2995 (x_set_frame_alpha): Find topmost parent window with
2996 x_find_topmost_parent and set the property there also (bug#9181).
2997 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2998
c74e9d86
PE
29992011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 * callproc.c (Fcall_process): Avoid vfork clobbering
3002 the local vars buffer, coding_systems, current_dir.
3003
640c8776
SM
30042011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3005
3006 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3007
f26d0e4c
PE
30082011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3009
8a10d76c
PE
3010 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3011 so that it is not optimized away.
3012
f26d0e4c
PE
3013 * xdisp.c (compute_display_string_pos): Remove unused local.
3014
55439c61
EZ
30152011-08-02 Eli Zaretskii <eliz@gnu.org>
3016
3017 Fix slow cursor motion and scrolling in large buffers with
3018 selective display, like Org Mode buffers. (Bug#9218)
3019
3020 * dispextern.h (struct bidi_it): New member disp_prop_p.
3021
3022 * xdisp.c: Remove one-slot cache of display string positions.
3023 (compute_display_string_pos): Accept an additional argument
5e617bc2 3024 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3025 for a display string or property. If found, set DISP_PROP_P
3026 non-zero.
3027
3028 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3029 DISP_PROP_P, and pass it to compute_display_string_pos.
3030 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3031 non-zero. All callers of bidi_fetch_char changed.
3032
fb33fa43
SM
30332011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3034
3035 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3036
b099e063
DM
30372010-12-03 Don March <don@ohspite.net>
3038
3039 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3040 last character M-[char] is translated to ESC [char] (bug#7541).
3041
5cc7f7af
KH
30422011-08-02 Kenichi Handa <handa@m17n.org>
3043
d0fffa3f 3044 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3045
3046 * chartab.c (uniprop_table): Make it non-static.
3047
525d5e6e
EZ
30482011-08-01 Eli Zaretskii <eliz@gnu.org>
3049
3050 * xdisp.c (forward_to_next_line_start): Accept additional argument
3051 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3052 on the newline.
3053 (reseat_at_next_visible_line_start): Use the bidi iterator state
3054 returned by forward_to_next_line_start to restore the state of
3055 it->bidi_it after backing up to previous newline. (Bug#9212)
3056
31011111
AS
30572011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3058
3059 * regex.c (re_comp): Protoize.
3060 (re_exec): Fix return type.
3061 (regexec): Fix type of `ret'. (Bug#9203)
3062
476371c4
PE
30632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3064
e5d76069
PE
3065 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3066 This is needed if max-image-size is a floating-point number.
3067
9a79b20c
AS
30682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3069
3070 * print.c (print_object): Print empty symbol as ##.
3071
3072 * lread.c (read1): Read ## as empty symbol.
3073
d8c2fa78
AA
30742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3075
3076 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3077 setting frame foreground color (Bug#9175).
3078 (x_set_background_color): Likewise.
3079
ffe57a7a
AA
3080 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3081 contents (Bug#9176).
3082 (EmacsTooltip -init): Remove bezels and add shadows to
3083 tooltip windows.
3084
bf3492a5
AA
3085 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3086 or scroll bar (Bug#8470).
3087
d55e9c53
AA
3088 * nsfont.m (nsfont_open): Remove assignment to voffset and
3089 unnecessary vars hshink, expand, hd, full_height, min_height.
3090 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3091
3092 * nsterm.h (nsfont_info): Remove voffset field.
3093
d8c2fa78 30942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3095
3096 Implement strike-through and overline on NextStep (Bug#8863).
3097
3098 * nsfont.m (nsfont_open): Use underline position provided by font,
3099 instead of hard-coded value of 2.
3100 (nsfont_draw): Call ns_draw_text_decoration instead.
3101
3102 * nsterm.h: Add declaration for ns_draw_text_decoration.
3103
3104 * nsterm.m (ns_draw_text_decoration): New function for drawing
3105 underline, overline, and strike-through.
3106 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3107 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3108 accommodate underlining, etc.
4843aac3 3109
4cc60b9b
EZ
31102011-07-28 Eli Zaretskii <eliz@gnu.org>
3111
bc7ece87
EZ
3112 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3113 default.
4cc60b9b 3114
476371c4
PE
31152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3116
66606eea
PE
3117 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3118 Without this fix, if a signal arrives just after memory fills up,
3119 'malloc' might be invoked reentrantly.
3120
476371c4
PE
3121 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3122 In other words, assume that every image size is allowed, on non-X
3123 hosts. This assumption is probably wrong, but it lets Emacs compile.
3124
f3fcc40d
AS
31252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3126
3127 * regex.c (re_iswctype): Convert return values to boolean.
3128
350c992f
EZ
31292011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3130
3131 * xdisp.c (compute_display_string_pos): Don't use cached display
3132 string position if the buffer had its restriction changed.
3133 (Bug#9184)
3134
5266b4bb
PE
31352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3138
2573a837 31392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3140
41f55ccd 3141 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3142
39e378da
PE
3143 * bidi.c: Integer size and overflow fixes.
3144 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3145 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3146 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3147 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3148 (bidi_find_other_level_edge):
3149 Use ptrdiff_t instead of EMACS_INT where either will do.
3150 This works better on 32-bit hosts configured --with-wide-int.
3151 (bidi_cache_ensure_space): Check for size-calculation overflow.
3152 Use % rather than repeated addition, for better worst-case speed.
3153 Don't set bidi_cache_size until after xrealloc returns, because it
3154 might not return.
3155 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3156 (bidi_cache_ensure_space): Also check that the bidi cache size
3157 does not exceed that of the largest Lisp string or buffer. See Eli
3158 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3159
5e927815
PE
3160 * alloc.c (__malloc_size_t): Remove.
3161 All uses replaced by size_t. See Andreas Schwab's note
3162 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3163
ca4aa935
PE
3164 * image.c: Improve checking for integer overflow.
3165 (check_image_size): Assume that f is nonnull, since
3166 it is always nonnull in practice. This is one less thing to
3167 worry about when checking for integer overflow later.
3168 (x_check_image_size): New function, which checks for integer
3169 overflow issues inside X.
3170 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3171 This removes the need for a memory_full check.
3172 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3173 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3174 (xbm_read_bitmap_data): Change locals back to 'int', since
3175 their values must fit in 'int'.
3176 (xpm_load_image, png_load, tiff_load):
3177 Invoke x_create_x_image_and_pixmap earlier,
3178 to avoid much needless work if the image is too large.
3179 (tiff_load): Treat overly large images as if
3180 x_create_x_image_and_pixmap failed, not as malloc failures.
3181 (gs_load): Use x_check_image_size.
3182
5f8f9cc2
PE
3183 * gtkutil.c: Omit integer casts.
3184 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3185 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3186
5adf60bc
PE
3187 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3188
c8907a93
PE
3189 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3190 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3191 would wrongly return t on a 64-bit host.
3192
e3c25c68
PE
3193 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3194 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3195 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3196 and therefore cause GCC to emit a bogus diagnostic in some cases.
3197
3f791afe
PE
3198 * image.c: Integer signedness and overflow and related fixes.
3199 This is not an exhaustive set of fixes, but it's time to
3200 record what I've got.
3201 (lookup_pixel_color, check_image_size): Remove redundant decls.
3202 (check_image_size): Don't assume that arbitrary EMACS_INT values
3203 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3204 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3205 (tiff_load, imagemagick_load_image):
3206 Check for overflow in size calculations.
3207 (x_create_x_image_and_pixmap): Remove unnecessary test for
3208 xmalloc returning NULL; that can't happen.
3209 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3210 (xpm_color_bucket): Use better integer hashing function.
3211 (xpm_cache_color): Don't possibly over-allocate memory.
3212 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3213 (gif_memory_source):
3214 Use ptrdiff_t, not int or size_t, to record sizes.
3215 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3216 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3217 either works, as we prefer signed integers.
3218 (tiff_read_from_memory, tiff_write_from_memory):
3219 Return tsize_t, not size_t, since that's what the TIFF API wants.
3220 (tiff_read_from_memory): Don't fail simply because the read would
3221 go past EOF; instead, return a short read.
3222 (tiff_load): Omit no-longer-needed casts.
3223 (Fimagemagick_types): Don't assume size fits into 'int'.
3224
3cc5a532
PE
3225 Improve hashing quality when configured --with-wide-int.
3226 * fns.c (hash_string): New function, taken from sxhash_string.
3227 Do not discard information about ASCII character case; this
3228 discarding is no longer needed.
3229 (sxhash-string): Use it. Change sig to match it. Caller changed.
3230 * lisp.h: Declare it.
3231 * lread.c (hash_string): Remove, since we now use fns.c's version.
3232 The fns.c version returns a wider integer if --with-wide-int is
3233 specified, so this should help the quality of the hashing a bit.
3234
b312a492
PE
3235 * emacs.c: Integer overflow minor fix.
3236 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3237 Define only if GNU_LINUX.
3238 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3239
dfd153ae
PE
3240 * dispnew.c: Integer signedness and overflow fixes.
3241 Remove unnecessary forward decls, that were a maintenance hassle.
3242 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3243 All uses changed.
3244 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3245 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3246 (prepare_desired_row, line_draw_cost):
3247 Use int, not unsigned, where either works.
3248 (save_current_matrix, restore_current_matrix):
3249 Use ptrdiff_t, not size_t, where either works.
3250 (init_display): Check for overflow more accurately, and without
3251 relying on undefined behavior.
3252
a81d11a3
PE
3253 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3254 Remove, replacing with the new symbols in lisp.h. All uses changed.
3255 * fileio.c (make_temp_name):
3256 * filelock.c (lock_file_1, lock_file):
3257 * xdisp.c (message_dolog):
3258 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3259 Use pMd etc. instead.
3260 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3261 replacing the pWIDE etc. symbols removed from editfns.c.
3262
3300e6fd
PE
3263 * keyboard.h (num_input_events): Now uintmax_t.
3264 This is (very slightly) less likely to mess up due to wraparound.
3265 All uses changed.
3266
fd05c7e9
PE
3267 * buffer.c: Integer signedness fixes.
3268 (alloc_buffer_text, enlarge_buffer_text):
3269 Use ptrdiff_t rather than size_t when either will do, as we prefer
3270 signed integers.
3271
903fe15d
PE
3272 * alloc.c: Integer signedness and overflow fixes.
3273 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3274 (__malloc_size_t): Default to size_t, not to int.
3275 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3276 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3277 Prefer ptrdiff_t to size_t when either would do, as we prefer
3278 signed integers.
3279 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3280 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3281 Now const. Initialize with values that are in range even if char
3282 is signed.
3283 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3284 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3285 These functions do the right thing with sizes > 2**32.
3286 (check_depth): Now ptrdiff_t, not int.
3287 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3288 Adjust to new way of storing sizes. Check for size overflow bugs
3289 in rest of code.
3290 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3291 slightly wrong anyway, as it missed one instance of
3292 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3293 (refill_memory_reserve): Omit needless cast to size_t.
3294 (mark_object_loop_halt): Mark as externally visible.
3295
ac82cc6a
PE
3296 * xselect.c: Integer signedness and overflow fixes.
3297 (Fx_register_dnd_atom, x_handle_dnd_message):
3298 Use ptrdiff_t, not size_t, since we prefer signed.
3299 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3300 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3301 x_dnd_atoms_size and x_dnd_atoms_length.
3302
c2d1e36d
PE
3303 * doprnt.c: Prefer signed to unsigned when either works.
3304 * eval.c (verror):
3305 * doprnt.c (doprnt):
3306 * lisp.h (doprnt):
3307 * xdisp.c (vmessage):
3308 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3309 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3310 prefer signed arithmetic to avoid comparison confusion.
3311 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3312 but is a bit tricky.
3313
0e926e56
PE
3314 Assume freestanding C89 headers, string.h, stdlib.h.
3315 * data.c, doprnt.c, floatfns.c, print.c:
3316 Include float.h unconditionally.
3317 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3318 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3319 * regex.c: Likewise for stddef.h, string.h.
3320 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3321 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3322 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3323 (STDC_HEADERS): Remove obsolete defines.
3324 * sysdep.c: Include limits.h unconditionally.
3325
9cfdb3ec
PE
3326 Assume support for memcmp, memcpy, memmove, memset.
3327 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3328 * regex.c (memcmp, memcpy):
3329 Remove; we assume C89 now.
3330
3331 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3332 (__malloc_safe_bcopy): Remove; no longer needed.
3333
cf950e6b 3334 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3335 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3336 well either way, and we prefer signed to unsigned.
3337
dbf38e02
LMI
33382011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3339
3340 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3341 closes the connection while we're reading (bug#9182).
3342
d6f0886c 33432011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3344
d6f0886c
JD
3345 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3346 are specified (Bug#9168).
24e0f6b1 3347
2eb1f9e6
PE
33482011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3351 Found by GCC static checking and --with-wide-int on a 32-bit host.
3352
22381272 33532011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3354
3355 * xdisp.c (compute_display_string_pos): Fix logic of caching
3356 previous display string position. Initialize cached_prev_pos to
3357 -1. Fixes slow-down at the beginning of a buffer.
3358
f25e39b4
EZ
33592011-07-24 Eli Zaretskii <eliz@gnu.org>
3360
3361 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3362 for attrs[LFACE_FONTSET_INDEX].
3363
04c4b52e
PE
33642011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 * xml.c (parse_region): Remove unused local
3367 that was recently introduced.
3368
c1734fbd
EZ
33692011-07-23 Eli Zaretskii <eliz@gnu.org>
3370
be18c5a5
EZ
3371 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3372 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3373
c1734fbd
EZ
3374 * xdisp.c (move_it_in_display_line_to): Record the best matching
3375 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3376 exit if none of the characters scanned was an exact match.
3377 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3378 when exact match is impossible due to invisible text, and the
3379 lines are truncated.
3380
a258d627
JD
33812011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3382
3383 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3384 for OSX >= 10.7.
3385
b6d5a689
EZ
33862011-07-22 Eli Zaretskii <eliz@gnu.org>
3387
0f74f785
EZ
3388 Fix a significant slow-down of cursor motion with C-n, C-p,
3389 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3390 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3391 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3392 (next_element_from_buffer): Call compute_stop_pos_backwards to
3393 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3394 base_level_stop.
3395 (reseat): Don't look for prev_stop, as that could mean a very long
3396 run.
3397 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3398 <cached_disp_overlay_modiff>: Cache for last found display string
3399 position.
551918c1 3400 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3401 about the same buffer in the same area of character positions, and
3402 the buffer wasn't changed since the time the display string
3403 position was cached.
551918c1 3404
b2d0c91a
EZ
34052011-07-22 Eli Zaretskii <eliz@gnu.org>
3406
3407 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3408 is an integer, which is important for empty lines. (Bug#9149)
3409
043604ee
CY
34102011-07-22 Chong Yidong <cyd@stupidchicken.com>
3411
3412 * frame.c (Fmodify_frame_parameters): In tty case, update the
3413 default face if necessary (Bug#4238).
3414
da4adb04
CY
34152011-07-21 Chong Yidong <cyd@stupidchicken.com>
3416
3417 * editfns.c (Fstring_to_char): No need to explain what a character
3418 is in the docstring (Bug#6576).
3419
9abd0532
LMI
34202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3421
3422 * xml.c (parse_region): Make sure we always return a tree.
3423
36881d16
HK
34242011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3425
3426 * xml.c (parse_region): If a document contains only comments,
3427 return that, too.
3428
1e98674d
LMI
34292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3430
3431 * xml.c (make_dom): Return comments, too.
3432
590bd467
PE
34332011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3434
3435 Port to OpenBSD.
3436 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3437 and the surrounding thread.
3438 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3439 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3440 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3441 timer goes off.
3442 * s/openbsd.h (BROKEN_SIGIO): Define.
3443 * unexelf.c (unexec) [__OpenBSD__]:
3444 Don't update the .mdebug section of the Alpha COFF symbol table.
3445
f41628b2
LMI
34462011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3447
3448 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3449 (bug#8460).
3450
b59b67c5
PE
34512011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3452
15e3a074
PE
3453 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3454 This fixes some race conditions on the permissions of any newly
3455 created file.
3456
41bed37d
PE
3457 * alloc.c (valid_pointer_p): Use pipe, not open.
3458 This fixes some permissions issues when debugging.
3459
b59b67c5
PE
3460 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3461 If fchown fails to set both uid and gid, try to set just gid,
3462 as that is sometimes allowed. Adjust the file's mode to eliminate
3463 setuid or setgid bits that are inappropriate if fchown fails.
3464
925a6be7
SM
34652011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3466
3467 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3468 to compare Lisp_Objects.
3469 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3470 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3471 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3472
52968808
AS
34732011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3474
0a6a104b
AS
3475 * lread.c (read_integer): Unread even EOF character.
3476 (read1): Likewise. Properly record start position of symbol.
3477
52968808
AS
3478 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3479 symbol character follows.
3480
9e381cdd
PE
34812011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3482
3483 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3484 This works around a problem with the previous change to Fcopy_file.
3485 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3486 and without this change, GCC might complain about discarding
3487 fchown's return value.
3488
b5641435
JB
34892011-07-16 Juanma Barranquero <lekktu@gmail.com>
3490
3491 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3492
a8031457
PE
34932011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3496
dd889327
LMI
34972011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498
750c33f7
LMI
3499 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3500 it's used from the C level.
3501
dd889327
LMI
3502 * process.c: Use the same condition for POLL_FOR_INPUT in both
3503 keyboard.c and process.c (bug#1858).
3504
87e86684
LM
35052011-07-09 Lawrence Mitchell <wence@gmx.li>
3506
3507 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3508 (Fgnutls_boot): Use it.
3509
64348f40
AS
35102011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3511
3512 * doc.c (Fsubstitute_command_keys): Revert last change.
3513
1d698799
LMI
35142011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3515
f863868c
LMI
3516 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3517 quotes the next character, and doesn't affect other longer
3518 sequences (bug#8935).
3519
1d698799
LMI
3520 * lread.c (syms_of_lread): Clarify that is isn't only
3521 `eval-buffer' and `eval-defun' that's affected by
3522 `lexical-binding' (bug#8460).
3523
aa4b6df6
EZ
35242011-07-15 Eli Zaretskii <eliz@gnu.org>
3525
3526 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3527 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3528
5d856da6
PE
35292011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3530
ad6042bb
PE
3531 Fix minor problems found by static checking.
3532 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3533 (elsz): Now a signed constant, not a size_t var. We prefer signed
3534 types to unsigned, to avoid integer comparison confusion. Without
3535 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3536 "cannot optimize loop, the loop counter may overflow", a symptom
3537 of the confusion.
f00bbb22 3538 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3539 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3540
6468f31c
LMI
35412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3542
49080b10
LMI
3543 * search.c (Fre_search_backward): Mention `case-fold-search' in
3544 all the re_search_* functions (bug#8138).
3545
6468f31c
LMI
3546 * keyboard.c (Fopen_dribble_file): Document when the file is
3547 closed (bug#8056).
3548
c965adc5
EZ
35492011-07-14 Eli Zaretskii <eliz@gnu.org>
3550
df9733bf
EZ
3551 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3552 bidi_cache_idx.
3553
0bb23927
EZ
3554 Support bidi reordering of display and overlay strings.
3555 * xdisp.c (compute_display_string_pos)
3556 (compute_display_string_end): Accept additional argument STRING.
3557 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3558 (reseat_to_string): Initialize bidi_it->string.s and
3559 bidi_it->string.schars.
3560 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3561 NULL (avoids a crash in bidi_paragraph_init).
3562 Initialize itb.string.lstring.
0bb23927
EZ
3563 (init_iterator): Call bidi_init_it only of a valid
3564 buffer position was specified. Initialize paragraph_embedding to
3565 L2R.
3566 (reseat_to_string): Initialize the bidi iterator.
3567 (display_string): If we need to ignore text properties of
3568 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3569 original value of -1 will not work with bidi.)
3570 (compute_display_string_pos): First arg is now struct
3571 `text_pos *'; all callers changed. Support display properties on
3572 Lisp strings.
3573 (compute_display_string_end): Support display properties on Lisp
3574 strings.
3575 (init_iterator, reseat_1, reseat_to_string): Initialize the
3576 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3577 when iterating on a string not from display properties).
640c8776
SM
3578 (compute_display_string_pos, compute_display_string_end):
3579 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3580 arrow keys.
3581 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3582 base_level_stop; instead, set base_level_stop to BEGV.
3583 Fixes crashes in vertical-motion.
0bb23927
EZ
3584 (next_element_from_buffer): Improve commentary for when
3585 the iterator is before prev_stop.
3586 (init_iterator): Initialize bidi_p from the default value of
3587 bidi-display-reordering, not from buffer-local value. Use the
3588 buffer-local value only if initializing for buffer iteration.
3589 (handle_invisible_prop): Support invisible properties on strings
3590 that are being bidi-reordered.
3591 (set_iterator_to_next): Support bidi reordering of C strings and
3592 Lisp strings.
3593 (next_element_from_string): Support bidi reordering of Lisp
3594 strings.
3595 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3596 (display_string): Support display of R2L glyph rows.
3597 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3598 (init_iterator): Don't initialize it->bidi_p for strings
3599 here.
3600 (reseat_to_string): Initialize it->bidi_p for strings here.
3601 (next_element_from_string, next_element_from_c_string)
3602 (next_element_from_buffer): Add xassert's for correspondence
3603 between IT's object being iterated and it->bidi_it.string
3604 structure.
3605 (face_before_or_after_it_pos): Support bidi iteration.
3606 (next_element_from_c_string): Handle the case of the first string
3607 character that is not the first one in the visual order.
3608 (get_visually_first_element): New function, refactored from common
3609 parts of next_element_from_buffer, next_element_from_string, and
3610 next_element_from_c_string.
3611 (tool_bar_lines_needed, redisplay_tool_bar)
3612 (display_menu_bar): Force left-to-right direction. Add a FIXME
3613 comment for making that be controlled by a user option.
3614 (push_it, pop_it): Save and restore the state of the
3615 bidi iterator. Save and restore the bidi_p flag.
3616 (pop_it): Iterate out of display property for string iteration as
3617 well.
3618 (iterate_out_of_display_property): Support iteration over strings.
3619 (handle_single_display_spec): Set up it->bidi_it for iteration
3620 over a display string, and call bidi_init_it.
3621 (handle_single_display_spec, next_overlay_string)
3622 (get_overlay_strings_1, push_display_prop): Set up the bidi
3623 iterator for displaying display or overlay strings.
3624 (forward_to_next_line_start): Don't use the shortcut if
3625 bidi-iterating.
3626 (back_to_previous_visible_line_start): If handle_display_prop
3627 pushed the iterator stack, restore the internal state of the bidi
3628 iterator by calling bidi_pop_it same number of times.
3629 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3630 and we are bidi-iterating, don't decrement the iterator position;
3631 instead, set the first_elt flag in the bidi iterator, to produce
3632 the same effect.
3633 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3634 (push_display_prop): xassert that we are iterating a buffer.
3635 (push_it, pop_it): Save and restore paragraph_embedding member.
3636 (handle_single_display_spec, next_overlay_string)
3637 (get_overlay_strings_1, reseat_1, reseat_to_string)
3638 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3639 correctly. Don't assume unibyte strings are not bidi-reordered.
3640 (compute_display_string_pos)
3641 (compute_display_string_end): Fix handling the case of C string.
3642 (push_it, pop_it): Save and restore from_disp_prop_p.
3643 (handle_single_display_spec, push_display_prop): Set the
3644 from_disp_prop_p flag.
3645 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3646 (pop_it): Call iterate_out_of_display_property only if we are
3647 popping after iteration over a string that came from a display
3648 property. Fix a typo in popping stretch info. Add an assertion
3649 for verifying that the iterator position is in sync with the bidi
3650 iterator.
3651 (handle_single_display_spec, get_overlay_strings_1)
3652 (push_display_prop): Fix initialization of paragraph direction for
3653 string when that of the parent object is not yet determined.
3654 (reseat_1): Call bidi_init_it to resync the bidi
3655 iterator with IT's position. (Bug#7616)
3656 (find_row_edges): If ROW->start.pos gives position
3657 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3658 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3659 Reset the from_disp_prop_p flag.
3660 (SAVE_IT, RESTORE_IT): New macros.
3661 (pos_visible_p, face_before_or_after_it_pos)
3662 (back_to_previous_visible_line_start)
3663 (move_it_in_display_line_to, move_it_in_display_line)
3664 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3665 (try_scrolling, redisplay_window, display_line): Use them when
3666 saving a temporary copy of the iterator and restoring it back.
3667 (back_to_previous_visible_line_start, reseat_1)
3668 (init_iterator): Empty the bidi cache "stack".
3669 (move_it_in_display_line_to): If iterator ended up at
3670 EOL, but we never saw any buffer positions smaller than
3671 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3672 motion in bidi-reordered lines.
3673 (move_it_in_display_line_to): Record prev_method and prev_pos
3674 immediately before the call to set_iterator_to_next. Fixes cursor
3675 motion in bidi-reordered lines with stretch glyphs and strings
3676 displayed in margins. (Bug#8133) (Bug#8867)
3677 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3678 TO_CHARPOS.
640c8776
SM
3679 (pos_visible_p): Support positions in bidi-reordered lines.
3680 Save and restore bidi cache.
0bb23927
EZ
3681
3682 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3683 (bidi_paragraph_info): Delete unused struct.
3684 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3685 (bidi_cache_start): New variable.
3686 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3687 to zero.
3688 (bidi_cache_fetch_state, bidi_cache_search)
3689 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3690 (bidi_cache_find, bidi_peek_at_next_level)
3691 (bidi_level_of_next_char, bidi_find_other_level_edge)
3692 (bidi_move_to_visually_next): Compare cache index with
3693 bidi_cache_start rather than with zero.
3694 (bidi_fetch_char): Accept new argument STRING; all callers
3695 changed. Support iteration over a string. Support strings with
3696 display properties. Support unibyte strings. Fix the type of
3697 `len' according to what STRING_CHAR_AND_LENGTH expects.
3698 (bidi_paragraph_init, bidi_resolve_explicit_1)
3699 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3700 (bidi_level_of_next_char, bidi_move_to_visually_next):
3701 Support iteration over a string.
0bb23927
EZ
3702 (bidi_set_sor_type, bidi_resolve_explicit_1)
3703 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3704 can now be zero (for strings); special values 0 and -1 were
3705 changed to -1 and -2, respectively.
3706 (bidi_char_at_pos): New function.
3707 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3708 Call it instead of FETCH_MULTIBYTE_CHAR.
3709 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3710 initialized to valid values.
3711 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3712 values.
3713 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3714 the test for valid cached positions. Fix the logic for looking up
3715 the sentinel state in the cache. GCPRO the Lisp string we are
3716 iterating.
3717 (bidi_push_it, bidi_pop_it): New functions.
3718 (bidi_initialize): Initialize the bidi cache start stack pointer.
3719 (bidi_cache_ensure_space): New function, refactored from part of
3720 bidi_cache_iterator_state. Don't assume the required size is just
3721 one BIDI_CACHE_CHUNK away.
3722 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3723 (bidi_count_bytes, bidi_char_at_pos): New functions.
3724 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3725 always valid if bidi_cache_idx is valid.
3726 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3727 is valid if it's going to be used.
3728 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3729 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3730 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3731 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3732 (bidi_find_other_level_edge, bidi_cache_start_stack):
3733 All variables related to cache indices are now EMACS_INT.
c965adc5 3734
0bb23927
EZ
3735 * dispextern.h (struct bidi_string_data): New structure.
3736 (struct bidi_it): New member `string'. Make flag members be 1-bit
3737 fields, and put them last in the struct.
640c8776
SM
3738 (compute_display_string_pos, compute_display_string_end):
3739 Update prototypes.
0bb23927
EZ
3740 (bidi_push_it, bidi_pop_it): Add prototypes.
3741 (struct iterator_stack_entry): New members bidi_p,
3742 paragraph_embedding, and from_disp_prop_p.
3743 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3744 (bidi_shelve_cache, bidi_unshelve_cache):
3745 Declare prototypes.
0bb23927
EZ
3746
3747 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3748 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3749 and vector-like objects.
3750
3751 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3752 cache around display iteration.
3753
3754 * window.c (Fwindow_end, window_scroll_pixel_based)
3755 (displayed_window_lines, Frecenter): Save and restore the bidi
3756 cache around display iteration.
3757
3bbd2265
LMI
37582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3759
3760 * editfns.c (Fdelete_region): Clarify the use of the named
3761 parameters (bug#6788).
3762
adc47434
MR
37632011-07-14 Martin Rudalics <rudalics@gmx.at>
3764
3765 * indent.c (Fvertical_motion): Set and restore w->pointm when
3766 saving and restoring the window's buffer (Bug#9006).
3767
837c31f8
LMI
37682011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3769
3770 * editfns.c (Fstring_to_char): Clarify just what is returned
3771 (bug#6576). Text by Eli Zaretskii.
3772
ac389d0c
JB
37732011-07-13 Juanma Barranquero <lekktu@gmail.com>
3774
3775 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3776
0be0ce47
EZ
37772011-07-13 Eli Zaretskii <eliz@gnu.org>
3778
3779 * buffer.c (mmap_find): Fix a typo.
3780
cd18e7e3
JB
37812011-07-13 Johan Bockgård <bojohan@gnu.org>
3782
3783 Fix execution of x selection hooks.
3784 * xselect.c (Qx_lost_selection_functions)
3785 (Qx_sent_selection_functions): New vars.
3786 (syms_of_xselect): DEFSYM them.
3787 (x_handle_selection_request): Pass Qx_sent_selection_functions
3788 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3789 (x_handle_selection_clear,x_clear_frame_selections):
3790 Pass Qx_lost_selection_functions rather than
3791 Vx_lost_selection_functions to Frun_hook_with_args.
3792
47ea7f44
PE
37932011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3794
ac389d0c 3795 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3796 The old code sometimes used this field without initializing it.
3797
47ea7f44
PE
3798 * alloc.c (gc_sweep): Don't read past end of array.
3799 In theory, the old code could also have corrupted Emacs internals,
3800 though it'd be very unlikely.
3801
bc985c87
AS
38022011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3805 argument. (Bug#4026)
bc985c87 3806
0cf34688
LMI
38072011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3808
b3dadd76
LMI
3809 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3810 key" (bug#4257).
3811
0cf34688
LMI
3812 * window.c (Fset_window_start): Doc fix (bug#4199).
3813 (Fset_window_hscroll): Ditto.
3814
270768cd
PE
38152011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3816
077e3dda 3817 Fix minor new problems caught by GCC 4.6.1.
270768cd 3818 * term.c (init_tty): Remove unused local.
490011a6 3819 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3820 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3821 not used otherwise.
270768cd 3822
b1f58454
CY
38232011-07-12 Chong Yidong <cyd@stupidchicken.com>
3824
3825 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3826
22b9578d
LMI
38272011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3828
6e70ab07
LMI
3829 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3830 are the mini-buffer and the echo area (bug#3320).
3831
22b9578d
LMI
3832 * term.c (init_tty): Remove support for supdup, c10 and perq
3833 terminals, which are no longer supported (bug#1482).
3834
8974cc9f
JB
38352011-07-10 Johan Bockgård <bojohan@gnu.org>
3836
3837 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3838
a560d974
JD
38392011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3840
3841 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3842 for non-popups (Bug#3642).
3843
1dae0f0a
AS
38442011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3845
268c2c36 3846 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3847 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3848 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3849 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3850 * data.c (fmod): Likewise.
3851 * dispnew.c (swap_glyphs_in_rows): Likewise.
3852 * emacs.c (memory_warning_signal): Likewise.
3853 * floatfns.c (float_error): Likewise.
3854 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3855 (otf_open, font_otf_capability, generate_otf_features)
3856 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3857 Likewise.
3858 * image.c (pbm_read_file): Likewise.
3859 * indent.c (string_display_width): Likewise.
3860 * intervals.c (check_for_interval, search_for_interval)
3861 (inc_interval_count, count_intervals, root_interval)
3862 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3863 * lread.c (defalias): Likewise.
268c2c36 3864 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3865 * regex.c (set_image_of_range_1, set_image_of_range)
3866 (regex_grow_registers): Likewise.
3867 * sysdep.c (strerror): Likewise.
3868 * termcap.c (valid_filename_p, tprint, main): Likewise.
3869 * tparam.c (main): Likewise.
3870 * unexhp9k800.c (run_time_remap, save_data_space)
3871 (update_file_ptrs, read_header, write_header, calculate_checksum)
3872 (copy_file, copy_rest, display_header): Likewise.
3873 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3874 Likewise.
3875 * xdisp.c (check_it): Likewise.
3876 * xfaces.c (register_color, unregister_color, unregister_colors):
3877 Likewise.
3878 * xfns.c (print_fontset_result): Likewise.
3879 * xrdb.c (member, fatal, main): Likewise.
3880
99033785
PE
38812011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 Fix minor problems found by static checking (Bug#9031).
3884 * chartab.c (char_table_set_range, map_sub_char_table):
3885 Remove unused locals.
3886 (uniprop_table): Now static.
3887 * composite.c (_work_char): Remove unused static var.
3888
9cb2ac56
JB
38892011-07-09 Juanma Barranquero <lekktu@gmail.com>
3890
3891 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3892
f25661f0
JD
38932011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3894
3895 * gtkutil.c (qttip_cb): Remove code without function.
3896
8278c4fe
EZ
38972011-07-09 Eli Zaretskii <eliz@gnu.org>
3898
3899 * w32.c (pthread_sigmask): New stub.
3900
1692ae2d 39012011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3902
8a6ebd58 3903 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3904 sigprocmask is portable only for single-threaded applications, and
3905 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3906 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3907 (LIBES): Use it.
3908 * callproc.c (Fcall_process):
3909 * process.c (create_process):
3910 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3911 Use pthread_sigmask, not sigprocmask.
123403e4 3912
1b854618
JD
39132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3916 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3917 wrong (Bug#8591).
3918
3fe4b549
JD
39192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3920
0ce7e563
JD
3921 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3922 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3923 (xg_hide_tooltip): Fix comment.
3924
3fe4b549
JD
3925 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3926 in registerServicesMenuSendTypes.
3927 (validRequestorForSendType): Don't check ns_return_types.
3928
3929 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3930 ns_return_type.
3931
5df75e47
JR
39322011-07-08 Jason Rumney <jasonr@gnu.org>
3933
22610910
JR
3934 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3935 SH_SHOW for hidden windows (Bug#5482).
3936
5df75e47
JR
3937 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3938 frame struct members of non-existent frames (Bug#6284).
3939
699c10bd
JD
39402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3941
4393663b
JD
3942 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3943 variable firstTime not needed on OSX >= 10.6.
3944 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3945 >= 10.5. Use setKnobProportion, setDoubleValue.
3946
3947 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3948 (MAC_OS_X_VERSION_10_5): Define if not defined.
3949 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3950 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3951 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3952
3953 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3954 cString and lossyCString on OSX >= 10.4
3955
58179cce 3956 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3957 sizeToFit on OSX >= 10.2.
3958
3959 * nsimage.m (allocInitFromFile): Don't use deprecated method
3960 bestRepresentationForDevice on OSX >= 10.6.
3961
3962 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3963 to avoid warning.
3964
3965 * emacs.c: Declare unexec_init_emacs_zone.
3966
a63e0781
JD
3967 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3968
699c10bd
JD
3969 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3970
3971 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3972 on svcsMenu (Bug#8842).
3973
3974 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3975 ns_return_types.
3976 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3977
3978 * nsterm.m (QUTF8_STRING): Declare.
3979 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3980 (validRequestorForSendType): Return type is (id).
3981 Change indexOfObjectIdenticalTo to indexOfObject.
3982 Check if we have local selection before returning self (Bug#8842).
3983 (writeSelectionToPasteboard): Put local selection into paste board
3984 if we have a local selection (Bug#8842).
3985 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3986
3987 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3988 (ns_get_local_selection): Declare.
3989
54e10184
LMI
39902011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3991
9888ff71
LMI
3992 * keymap.c (describe_map_tree): Don't insert a double newline at
3993 the end of the buffer (bug#1169) and return whether we inserted
3994 something.
3995
54e10184
LMI
3996 * callint.c (Fcall_interactively): Change "reading args" to
3997 "providing args" to try to clarify what it does (bug#1010).
3998
15fa4783
KH
39992011-07-07 Kenichi Handa <handa@m17n.org>
4000
4001 * composite.c (composition_compute_stop_pos): Ignore a static
4002 composition starting before CHARPOS (Bug#8915).
4003
4004 * xdisp.c (handle_composition_prop): Likewise.
4005
a8815b00
EZ
40062011-07-07 Eli Zaretskii <eliz@gnu.org>
4007
4008 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4009 (Bug#9015)
4010
ef7b981d 40112011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4012
4013 * character.h (unicode_category_t): New enum type.
4014
4015 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4016 (Qchar_code_property_table): New variable.
4017 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4018 (UNIPROP_COMPRESSED_FORM_P): New macros.
4019 (char_table_ascii): Uncompress the compressed values.
4020 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4021 Uncompress the compressed values.
ac389d0c 4022 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4023 (char_table_ref_and_range): Uncompress the compressed values.
4024 (sub_char_table_set): New arg is_uniprop. Callers changed.
4025 Uncompress the compressed values.
4026 (sub_char_table_set_range): Args changed. Callers changed.
4027 (char_table_set_range): Adjuted for the above change.
4028 (map_sub_char_table): Delete args default_val and parent. Add arg
4029 top. Give decoded values to a Lisp function.
640c8776 4030 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4031 values to a Lisp function. Gcpro more variables.
4032 (uniprop_table_uncompress)
4033 (uniprop_decode_value_run_length): New functions.
4034 (uniprop_decoder, uniprop_decoder_count): New variables.
4035 (uniprop_get_decoder, uniprop_encode_value_character)
4036 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4037 New functions.
4038 (uniprop_encoder, uniprop_encoder_count): New variables.
4039 (uniprop_get_encoder, uniprop_table)
4040 (Funicode_property_table_internal, Fget_unicode_property_internal)
4041 (Fput_unicode_property_internal): New functions.
4042 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4043 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4044 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4045 char-code-property-alist.
4046
640c8776 4047 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4048 Vunicode_category_table.
4049
640c8776 4050 * font.c (font_range): Adjust for the change of
c805dec0
KH
4051 Vunicode_category_table.
4052
76b397fb
DN
40532011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4054
4055 * m/iris4d.h: Remove file, move contents ...
4056 * s/irix6-5.h: ... here.
4057
22b4128e
PE
40582011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4059
4060 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4061 * alloc.c (mark_buffer):
4062 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4063 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4064 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4065 This isn't true in general, and it's particularly not true
4066 if Emacs is configured with --with-wide-int.
4067 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4068 New macros, used in the buffer.c change.
4069
869795d6
JD
40702011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4071
4072 * xsettings.c: Use both GConf and GSettings if both are available.
4073 (store_config_changed_event): Add comment.
4074 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4075 (store_tool_bar_style_changed): New functions.
5e617bc2 4076 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4077 (struct xsettings): Move font inside HAVE_XFT.
4078 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4079 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4080 Move inside HAVE_XFT.
640c8776 4081 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4082 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4083 also.
4084 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4085 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4086 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4087 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4088 (parse_settings): Move check for font inside HAVE_XFT.
4089 (read_settings, apply_xft_settings): Add comment.
4090 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4091 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4092 call store_font_name_changed.
4093 (xft_settings_event): Add comment.
4094 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4095 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4096 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4097 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4098 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4099 (xsettings_get_system_font, xsettings_get_system_normal_font):
4100 Add comment.
869795d6 4101
d8ed26bd
PE
41022011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4103
4104 Random fixes. E.g., (random) never returned negative values.
4105 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4106 subseconds part to the entropy, as that's a bit more random.
4107 Prefer signed to unsigned, since the signedness doesn't matter and
4108 in general we prefer signed. When given a limit, use a
4109 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4110 latter isn't right if USE_2_TAGS_FOR_INTS.
4111 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4112 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4113
cabf1cac
SM
41142011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4115
4116 * textprop.c (text_property_stickiness):
4117 Obey Vtext_property_default_nonsticky.
4118 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4119 * w32fns.c (syms_of_w32fns):
4120 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4121
6e9b2be9
PE
41222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4125 This is more efficient than Ffile_directory_p and avoids a minor race.
4126
90186c68
LMI
41272011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4128
7c301272
LMI
4129 * buffer.c (Foverlay_put): Say what the return value is
4130 (bug#7835).
4131
c4f2d8d4
LMI
4132 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4133 is a directory before asking whether to use the file name
4134 (bug#7564).
ad637907
LMI
4135 (barf_or_query_if_file_exists): Make the "File is a directory"
4136 error be more correct.
c4f2d8d4 4137
90186c68
LMI
4138 * fns.c (Frequire): Remove the mention of the .gz files, since
4139 that's installation-specific, but keep the mention of
4140 `get-load-suffixes'.
4141
da64016e
PE
41422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4143
4144 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4145 Report string overflow if the output is too long.
4146
7d47b580
JB
41472011-07-04 Juanma Barranquero <lekktu@gmail.com>
4148
a555cb87
JB
4149 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4150 (syms_of_gnutls): Remove duplicate DEFSYM for
4151 Qgnutls_bootprop_verify_hostname_error, an error for
4152 Qgnutls_bootprop_verify_error (which is no longer used).
4153
7d47b580
JB
4154 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4155 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4156 Also (re)move comments that are misplaced or no longer relevant.
4157
1e49bfab
LMI
41582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4159
4160 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4161
1485f4c0
CY
41622011-07-03 Chong Yidong <cyd@stupidchicken.com>
4163
4164 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4165 and background color parameters if they have been changed.
4166
a9ab721e
LMI
41672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4168
4169 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4170
cf7cff57
PE
41712011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4172
2e13213d
PE
4173 * xsettings.c (SYSTEM_FONT): Define only when used.
4174 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4175
cf7cff57
PE
4176 * keymap.c (access_keymap_1): Now static.
4177
7a8e04f7
CY
41782011-07-02 Chong Yidong <cyd@stupidchicken.com>
4179
4180 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4181 leave any prefix arg for the up event (Bug#1586).
4182
61352f62
LMI
41832011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4184
69bb1ef7
LMI
4185 * lread.c (syms_of_lread): Mention single symbols defined by
4186 `defvar' or `defconst' (bug#7154).
4187
61352f62 4188 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4189 (Frequire): Mention get-load-suffixes.
61352f62 4190
28545e04
MR
41912011-07-02 Martin Rudalics <rudalics@gmx.at>
4192
4193 * window.h (window): Remove clone_number slot.
4194 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4195 Remove.
4196 (make_parent_window, make_window, saved_window)
4197 (Fset_window_configuration, save_window_save): Don't deal with
4198 clone numbers.
4199 * buffer.c (Qclone_number): Remove declaration.
4200 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4201
3349e122
SM
42022011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4203
4204 Add multiple inheritance to keymaps.
4205 * keymap.c (Fmake_composed_keymap): New function.
4206 (Fset_keymap_parent): Simplify.
4207 (fix_submap_inheritance): Remove.
4208 (access_keymap_1): New function extracted from access_keymap to handle
4209 embedded parents and handle lists of maps.
4210 (access_keymap): Use it.
4211 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4212 (Fcopy_keymap): Handle embedded parents.
4213 (Fcommand_remapping, define_as_prefix): Simplify.
4214 (Fkey_binding): Simplify.
4215 (syms_of_keymap): Move minibuffer-local-completion-map,
4216 minibuffer-local-filename-completion-map,
4217 minibuffer-local-must-match-map, and
4218 minibuffer-local-filename-must-match-map to Elisp.
4219 (syms_of_keymap): Defsubr make-composed-keymap.
4220 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4221 (parse_menu_item): Trivial simplification.
4222
3279eb87
GM
42232011-07-01 Glenn Morris <rgm@gnu.org>
4224
4225 * Makefile.in (SETTINGS_LIBS): Fix typo.
4226
4550efdf
KI
42272011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4228
4229 * coding.c (Fencode_coding_string): Record the last coding system
4230 used, as the function doc string says (bug#8738).
4231
0949d2b6
JD
42322011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4233
4234 * xsettings.c (store_monospaced_changed): Take new font as arg and
4235 check for change against current_mono_font.
4236 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4237 (emacs_settings_constructor, emacs_settings_get_property)
4238 (emacs_settings_set_property, emacs_settings_class_init)
4239 (emacs_settings_init, gsettings_obj): Remove.
4240 (something_changedCB): New function for HAVE_GSETTINGS.
4241 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4242 with value as argument.
4243 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4244 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4245 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4246 "changed".
4247
4248 * xgselect.c: Add defined (HAVE_GSETTINGS).
4249 (xgselect_initialize): Ditto.
4250
4251 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4252 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4253 xg_select.
4254
bbc6b304
PE
42552011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * eval.c (struct backtrace): Simplify and port the data structure.
4258 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4259 signed bit field, as this assumption is not portable and it makes
4260 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4261 "char debug_on_exit : 1" as this is not portable either; instead,
4262 use the portable "unsigned int debug_on_exit : 1". Remove unused
4263 member evalargs. Remove obsolete comments about cc bombing out.
4264
9851bfc5
JD
42652011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4266
51bb811f 4267 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4268 Let HAVE_GSETTINGS override HAVE_GCONF.
4269 (store_monospaced_changed): New function.
4270 (EMACS_SETTINGS): A new type derived from GObject to handle
4271 GSettings notifications.
4272 (emacs_settings_constructor, emacs_settings_get_property)
4273 (emacs_settings_set_property, emacs_settings_class_init):
4274 New functions.
4275 (gsettings_client, gsettings_obj): New variables.
4276 (GSETTINGS_SCHEMA): New define.
4277 (something_changedCB): Call store_monospaced_changed.
4278 (init_gsettings): New function.
4279 (xsettings_initialize): Call init_gsettings.
4280 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4281 to NULL.
4282
640c8776 4283 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4284 GCONF_CFLAGS/LIBS.
4285
5386012d
MR
42862011-06-29 Martin Rudalics <rudalics@gmx.at>
4287
4288 * window.c (resize_root_window, grow_mini_window)
4289 (shrink_mini_window): Rename Qresize_root_window to
4290 Qwindow_resize_root_window and Qresize_root_window_vertically to
4291 Qwindow_resize_root_window_vertically.
4292
f13e0b08
PE
42932011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4296
94515237
JB
42972011-06-27 Juanma Barranquero <lekktu@gmail.com>
4298
4299 * makefile.w32-in: Redesign dependencies so they reflect more
4300 clearly which files are directly included by each source file,
4301 and not through other includes.
4302
e43b6e43
MR
43032011-06-27 Martin Rudalics <rudalics@gmx.at>
4304
4305 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4306 (sort_overlays, overlay_strings): When an overlay's clone number
4307 matches the window's clone number process the overlay even if
4308 the overlay's window property doesn't match the current window.
4309
d68443dc
MR
4310 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4311 (Fwindow_hchild): Rename to Fwindow_left_child.
4312 (Fwindow_next): Rename to Fwindow_next_sibling.
4313 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4314 (resize_window_check): Rename to window_resize_check.
4315 (resize_window_apply): Rename to window_resize_apply.
4316 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4317 (Fdelete_other_windows_internal, resize_frame_windows)
4318 (Fsplit_window_internal, Fdelete_window_internal)
4319 (grow_mini_window, shrink_mini_window)
4320 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4321
c7e73be5
JD
43222011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4323
4324 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4325 (emacs_fixed_set_min_size): Remove.
4326 (emacs_fixed_new): Take frame as argument.
4327
4328 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4329 (_EmacsFixedPrivate): Remove minwidth/height.
4330 Add struct frame *f.
4331 (emacs_fixed_init): Initialize priv->f.
4332 (get_parent_class, emacs_fixed_set_min_size): Remove.
4333 (emacs_fixed_new): Set priv->f to argument.
4334 (emacs_fixed_get_preferred_width)
4335 (emacs_fixed_get_preferred_height): Use min_width/height from
4336 frames size_hint to set minimum and natural (Bug#8919).
4337 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4338 and use min_width/height from frames size_hint to set
4339 min_width/height (Bug#8919).
4340
4341 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4342 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4343 Fix indentation.
c7e73be5 4344
cf99dcf8
EZ
43452011-06-26 Eli Zaretskii <eliz@gnu.org>
4346
4347 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4348 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4349 called at ZV.
4350
029529ac
CY
43512011-06-26 Chong Yidong <cyd@stupidchicken.com>
4352
4353 * process.c (wait_reading_process_output): Bypass select if
4354 waiting for a cell while ignoring keyboard input, and input is
4355 pending. Suggested by Jan Djärv (Bug#8869).
4356
7a7ef429
PE
43572011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 Use gnulib's dup2 module instead of rolling our own.
4360 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4361
11fdef7d 43622011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4363
4364 * dispnew.c (scrolling_window): Before scrolling, turn off a
4365 mouse-highlight in the window being scrolled.
4366
cd3520a4
JB
43672011-06-24 Juanma Barranquero <lekktu@gmail.com>
4368
4369 Move DEFSYM to lisp.h and use everywhere.
4370
4371 * character.h (DEFSYM): Move declaration...
4372 * lisp.h (DEFSYM): ...here.
4373
4374 * gnutls.c:
4375 * minibuf.c:
4376 * w32menu.c:
4377 * w32proc.c:
4378 * w32select.c: Don't include character.h.
4379
4380 * alloc.c (syms_of_alloc):
4381 * buffer.c (syms_of_buffer):
4382 * bytecode.c (syms_of_bytecode):
4383 * callint.c (syms_of_callint):
4384 * casefiddle.c (syms_of_casefiddle):
4385 * casetab.c (init_casetab_once):
4386 * category.c (init_category_once, syms_of_category):
4387 * ccl.c (syms_of_ccl):
4388 * cmds.c (syms_of_cmds):
4389 * composite.c (syms_of_composite):
4390 * dbusbind.c (syms_of_dbusbind):
4391 * dired.c (syms_of_dired):
4392 * dispnew.c (syms_of_display):
4393 * doc.c (syms_of_doc):
4394 * editfns.c (syms_of_editfns):
4395 * emacs.c (syms_of_emacs):
4396 * eval.c (syms_of_eval):
4397 * fileio.c (syms_of_fileio):
4398 * fns.c (syms_of_fns):
4399 * frame.c (syms_of_frame):
4400 * fringe.c (syms_of_fringe):
4401 * insdel.c (syms_of_insdel):
4402 * keymap.c (syms_of_keymap):
4403 * lread.c (init_obarray, syms_of_lread):
4404 * macros.c (syms_of_macros):
4405 * msdos.c (syms_of_msdos):
4406 * print.c (syms_of_print):
4407 * process.c (syms_of_process):
4408 * search.c (syms_of_search):
4409 * sound.c (syms_of_sound):
4410 * syntax.c (init_syntax_once, syms_of_syntax):
4411 * terminal.c (syms_of_terminal):
4412 * textprop.c (syms_of_textprop):
4413 * undo.c (syms_of_undo):
4414 * w32.c (globals_of_w32):
4415 * window.c (syms_of_window):
4416 * xdisp.c (syms_of_xdisp):
4417 * xfaces.c (syms_of_xfaces):
4418 * xfns.c (syms_of_xfns):
4419 * xmenu.c (syms_of_xmenu):
4420 * xsettings.c (syms_of_xsettings):
4421 * xterm.c (syms_of_xterm): Use DEFSYM.
4422
4228cf16
TZ
44232011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4424
cd3520a4 4425 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4426
7fcccf1e
PE
44272011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4428
7efb4e0e
PE
4429 Integer and buffer overflow fixes (Bug#8873).
4430
ff5844ad
PE
4431 * print.c (printchar, strout): Check for string overflow.
4432 (PRINTPREPARE, printchar, strout):
4433 Don't set size unless allocation succeeds.
4434
90532f02
PE
4435 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4436 for sizes. Check for string overflow more accurately.
4437 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4438
6d84508d
PE
4439 * macros.c: Integer and buffer overflow fixes.
4440 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4441 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4442 Use ptrdiff_t, not int, for sizes.
4443 Don't increment bufsize until after realloc succeeds.
4444 Check for size-calculation overflow.
4445 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4446
437b2cb4
PE
4447 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4448
8b9ac8b4
PE
4449 * lread.c: Integer overflow fixes.
4450 (read_integer): Radix is now EMACS_INT, not int,
4451 to improve quality of diagnostics for out-of-range radices.
4452 Calculate buffer size correctly for out-of-range radices.
4453 (read1): Check for integer overflow in radices, and in
4454 read-circle numbers.
82cb60d3
PE
4455 (read_escape): Avoid int overflow.
4456 (Fload, openp, read_buffer_size, read1)
4457 (substitute_object_recurse, read_vector, read_list, map_obarray):
4458 Use ptrdiff_t, not int, for sizes.
4459 (read1): Use EMACS_INT, not int, for sizes.
20270765 4460 Check for size overflow.
8b9ac8b4 4461
7fcccf1e
PE
4462 * image.c (cache_image): Check for size arithmetic overflow.
4463
bfbbd7e7
PE
4464 * lread.c: Integer overflow issues.
4465 (saved_doc_string_size, saved_doc_string_length)
4466 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4467 Now ptrdiff_t, not int.
4468 (read1): Don't assume doc string length fits in int. Check for
4469 out-of-range doc string lengths.
4470 (read_list): Don't assume file position fits in int.
39019e54 4471 (read_escape): Check for hex character overflow.
bfbbd7e7 4472
4e323265
LL
44732011-06-22 Leo Liu <sdl.web@gmail.com>
4474
4475 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4476 Move to minibuffer.el.
4477
85fece3e
PE
44782011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4479
20b84ce9 4480 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4481 The following patches are for when GLYPH_DEBUG && !XASSERT.
4482 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4483 * dispnew.c (flush_stdout):
4484 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4485 Mark as externally visible.
4486 * dispnew.c (check_window_matrix_pointers): Now static.
4487 * dispnew.c (window_to_frame_vpos):
4488 * xfns.c (unwind_create_frame):
4489 * xterm.c (x_check_font): Remove unused local.
4490 * scroll.c (CHECK_BOUNDS):
4491 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4492 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4493 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4494 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4495 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4496 Now static.
4497 (debug_method_add): Use va_list and vsprintf rather than relying
4498 on undefined behavior with wrong number of arguments.
4499 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4500 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4501 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4502 since we're not interested in debugging glyphs with old libraries.
4503 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4504 GCC 4.6.0's static checking.
4505
0766b489
PE
45062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4507
31fd4b32
PE
4508 Integer overflow and signedness fixes (Bug#8873).
4509 A few related buffer overrun fixes, too.
4510
b79e8648
PE
4511 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4512
0766b489
PE
4513 * dispextern.h (struct face.stipple):
4514 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4515 (x_bitmap_mask, x_allocate_bitmap_record)
4516 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4517 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4518 (x_create_bitmap_from_xpm_data):
4519 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4520 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4521 (.bitmaps_last):
4522 * xfaces.c (load_pixmap):
4523 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4524 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4525 (.bitmaps_last, struct x_output.icon_bitmap):
4526 Use ptrdiff_t, not int, for bitmap indexes.
4527 (x_allocate_bitmap_record): Check for size overflow.
4528 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4529
b081724f
PE
4530 Use ptrdiff_t, not int, for overlay counts.
4531 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4532 * editfns.c (overlays_around, get_pos_property):
4533 * textprop.c (get_char_property_and_overlay):
4534 * xdisp.c (next_overlay_change, note_mouse_highlight):
4535 * xfaces.c (face_at_buffer_position):
21514da7
PE
4536 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4537 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4538 (Fnext_overlay_change, Fprevious_overlay_change)
4539 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4540 Use ptrdiff_t, not int, for sizes.
21514da7 4541 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4542
3de73e5e
PE
4543 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4544
2606c57b
PE
4545 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4546 (x_session_initialize): Do not assume string length fits in int.
4547
aaafe47a
PE
4548 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4549 This is unlikely, but can occur if DPI is outlandish.
4550
2674ddc8 4551 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4552 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4553
28154962
PE
4554 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4555 * xrdb.c (magic_file_p, search_magic_path):
4556 Omit last arg SUFFIX; it was always 0. All callers changed.
4557 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4558
7de51af5
PE
4559 * xfont.c (xfont_match): Avoid need for strlen.
4560
25ed6cc3
PE
4561 * xfns.c: Don't assume strlen fits in int.
4562 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4563
4eab31dd
PE
4564 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4565 not unsigned long, as we prefer signed integers. All callers changed.
4566 Detect integer overflow in repeat count.
4567 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4568 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4569
171e2a58
PE
4570 * termcap.c: Don't assume sizes fit in int and never overflow.
4571 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4572 (gobble_line): Check for size-calculation overflow.
4573
ad39faca 4574 * minibuf.c (Fread_buffer):
6e5bb2dc 4575 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4576 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4577 Don't assume string length fits in int.
4578
52c61c22 4579 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4580 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4581
b5b8c9e5
PE
4582 * font.c: Don't assume string length fits in int.
4583 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4584 Use ptrdiff_t, not int.
ccd6111c
PE
4585 (font_intern_prop): Don't assume string length fits in int.
4586 Don't assume integer property fits in fixnum.
4587 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4588
882f0d81 4589 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4590 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4591 Reformulate so as not to need the command string.
4592 Invoke gzip -cd rather than gunzip, as it's more portable.
4593 (lock_info_type, lock_file_1, lock_file):
4594 Don't assume pid_t and time_t fit in unsigned long.
4595 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4596 (current_lock_owner): Prefer signed type for sizes.
4597 Use memcpy, not strncpy, where memcpy is what is really wanted.
4598 Don't assume (via atoi) that time_t and pid_t fit in int.
4599 Check for time_t and/or pid_t out of range, e.g., via a network share.
4600 Don't alloca where an auto var works fine.
4601
93f4cf88
PE
4602 * fileio.c: Fix some integer overflow issues.
4603 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4604 Don't assume string length fits in int.
4605 (directory_file_name): Don't assume string length fits in long.
4606 (make_temp_name): Don't assume pid fits in int, or that its print
4607 length is less than 20.
4608
f3e92b69
PE
4609 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4610
1bfdaf10
PE
4611 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4612
35016e9a
PE
4613 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4614
3d1e65a1
PE
4615 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4616 We prefer signed integers, even for size calculations.
4617
0b963a93
PE
4618 * emacs.c: Don't assume string length fits in 'int'.
4619 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4620 (main): Don't invoke strlen when not needed.
4621
573f4b54
PE
4622 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4623 (XD_DEBUG_MESSAGE): Don't waste a byte.
4624
989f33ba
PE
4625 * callproc.c (getenv_internal_1, getenv_internal)
4626 (Fgetenv_internal):
965d34eb
PE
4627 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4628
e4d29b33
PE
4629 * lread.c (invalid_syntax): Omit length argument.
4630 All uses changed. This doesn't fix a bug, but it simplifies the
4631 code away from its former Hollerith-constant appearance, and it's
4632 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4633 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4634
eb49b136
PE
4635 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4636 This didn't break anything, but it didn't help either.
4637 It's confusing to put a bogus integer in a place where the actual
4638 value does not matter.
9f62aeb1 4639 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4640 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4641
15375a22
PE
4642 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4643 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4644 implementation.
b61cc01c
PE
4645 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4646 We prefer signed types, and the value cannot exceed the EMACS_INT
4647 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4648 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4649 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4650 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4651
53b2623d
PE
4652 * indent.c (sane_tab_width): New function.
4653 (current_column, scan_for_column, Findent_to, position_indentation)
4654 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4655 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4656
51cab52b 4657 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4658
f2ed8a70
PE
4659 * lisp.h (lint_assume): New macro.
4660 * composite.c (composition_gstring_put_cache):
4661 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4662
abe80cc6
PE
4663 * editfns.c, insdel.c:
4664 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4665
b02c740e
PE
4666 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4667
ebc96716
PE
4668 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4669
b4e50fa0 4670 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4671 Use much-faster test for byte-length change.
311d5d7c 4672 Don't assume string byte-length fits in 'int'.
a4cf38e4 4673 Check that character arg fits in 'int'.
85461888 4674 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4675
c0c1ee9f
PE
4676 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4677
a498d7f4
PE
4678 * fns.c (concat): Catch string overflow earlier.
4679 Do not rely on integer wraparound.
4680
51cab52b
PE
4681 * dispextern.h (struct it.overlay_strings_charpos)
4682 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4683 * xdisp.c (forward_to_next_line_start)
4684 (back_to_previous_visible_line_start)
4685 (reseat_at_next_visible_line_start, next_element_from_buffer):
4686 Don't arbitrarily truncate the value of 'selective' to int.
4687
76031fad
PE
4688 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4689
5eb55db9
PE
4690 * composite.c: Don't truncate sizes to 'int'.
4691 (composition_gstring_p, composition_reseat_it)
4692 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4693 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4694 not EMACS_UINT, for indexes.
5eb55db9 4695
0703a717
PE
4696 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4697
d6202519
PE
4698 * buffer.c: Include <verify.h>.
4699 (struct sortvec.priority, struct sortstr.priority):
8961a454 4700 Now EMACS_INT, not int.
c20998a7 4701 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4702 (struct sortstr.size, record_overlay_string)
4703 (struct sortstrlist.size, struct sortlist.used):
4704 Don't truncate size to int.
4705 (record_overlay_string): Check for size-calculation overflow.
d6202519 4706 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4707
d5a19415
JM
47082011-06-22 Jim Meyering <meyering@redhat.com>
4709
029529ac 4710 Don't leak an XBM-image-sized buffer
d5a19415
JM
4711 * image.c (xbm_load): Free the image buffer after using it.
4712
a9041e6c
PE
47132011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4714
4715 Port to Sun C.
4716 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4717 that Sun C diagnosed.
4718 * fns.c (secure_hash): Fix pointer signedness issue.
4719 * intervals.c (static_offset_intervals): New function.
4720 (offset_intervals): Use it.
4721
7f3f739f
LL
47222011-06-21 Leo Liu <sdl.web@gmail.com>
4723
4724 * deps.mk (fns.o):
4725 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4726 sha512.h.
4727
4728 * fns.c (secure_hash): Rename from crypto_hash_function and change
4729 the first arg to accept symbols.
5b66d427 4730 (Fsecure_hash): New primitive.
7f3f739f
LL
4731 (syms_of_fns): New symbols.
4732
76147d94
DD
47332011-06-20 Deniz Dogan <deniz@dogan.se>
4734
4735 * process.c (Fset_process_buffer): Clarify return value in
4736 docstring.
4737
7d7d0045
CY
47382011-06-18 Chong Yidong <cyd@stupidchicken.com>
4739
4740 * dispnew.c (add_window_display_history): Use BVAR.
4741
4742 * xdisp.c (debug_method_add): Use BVAR.
4743 (check_window_end, dump_glyph_matrix, dump_glyph)
4744 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4745
4746 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4747 Likewise.
4748
4749 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4750 check till after the cache is created in init_frame_faces.
4751
ff2bc410
SM
47522011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4753
4754 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4755
28177add
PE
47562011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4757
dd3482fe
PE
4758 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4759 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4760 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4761
393d71f3 4762 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4763 * fileio.c (Finsert_file_contents):
4764 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4765 Remove the old (too-loose) buffer overflow checks.
4766 They weren't needed, since make_gap checks for buffer overflow.
4767 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4768 The old code merely checked for Emacs fixnum overflow, and relied
4769 on undefined (wraparound) behavior. The new code avoids undefined
4770 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4771
2e6813b0 4772 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4773 Tune. Don't use wider integers than needed. Don't use alloca.
4774 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4775
599a9e4f
PE
4776 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4777
99561444
PE
4778 * insdel.c, lisp.h (buffer_overflow): New function.
4779 (insert_from_buffer_1, replace_range, replace_range_2):
4780 * insdel.c (make_gap_larger):
4781 * editfns.c (Finsert_char):
4782 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4783
28177add
PE
4784 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4785
e69dafad
PE
47862011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4787
4baa020d 4788 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4789
b1c46f02
PE
4790 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4791 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4792
e69dafad
PE
4793 * fileio.c: Don't assume EMACS_INT fits in off_t.
4794 (emacs_lseek): New static function.
4795 (Finsert_file_contents, Fwrite_region): Use it.
4796 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4797
566684ea
PE
4798 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4799
e6966cd6
PE
4800 * fns.c: Don't overflow int when computing a list length.
4801 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4802 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4803 truncation on 64-bit hosts. Check for QUIT every
4804 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4805 faster and is responsive enough.
4806 (Flength): Report an error instead of overflowing an integer.
4807 (Fsafe_length): Return a float if the value is not representable
4808 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4809 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4810 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4811
dd0b0efb
PE
4812 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4813 (header_size, word_size): New constants.
4814 (allocate_vectorlike): Don't check size overflow here.
4815 (allocate_vector): Check it here instead, since this is the only
4816 caller of allocate_vectorlike that could cause overflow.
4817 Check that the new vector's length is representable as a fixnum.
4818
86fe5cfe
PE
4819 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4820 The previous code was bogus. For example, next_almost_prime (32)
4821 returned 39, which is undesirable as it is a multiple of 3; and
4822 next_almost_prime (24) returned 25, which is a multiple of 5 so
4823 why was the code bothering to check for multiples of 7?
4824
80e88859
PE
4825 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4826
4a2f0ad6
PE
4827 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4828
f66c7cf8
PE
4829 Variadic C functions now count arguments with ptrdiff_t.
4830 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4831 Back then I didn't know that the Emacs coding style prefers signed int.
4832 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4833 were being counted with int, which may truncate counts on 64-bit
4834 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4835 * lisp.h (struct Lisp_Subr.function.aMANY)
4836 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4837 Arg counts are now ptrdiff_t, not size_t.
4838 All variadic functions and their callers changed accordingly.
4839 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4840 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4841 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4842 * callint.c (Fcall_interactively): Check arg count for overflow,
4843 to avoid potential buffer overrun. Use signed char, not 'int',
4844 for 'varies' array, so that we needn't bother to check its size
4845 calculation for overflow.
4846 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4847 * eval.c (apply_lambda):
4848 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4849 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4850 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4851
a1759b76
PE
4852 * callint.c (Fcall_interactively): Don't use index var as event count.
4853
d96be9fc
PE
4854 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4855 * mem-limits.h (SIZE): Remove; no longer used.
4856
a690a978 4857 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4858
578c21e6
PE
4859 Remove unnecessary casts.
4860 * xterm.c (x_term_init):
4861 * xfns.c (x_set_border_pixel):
4862 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4863 These aren't needed now that we assume ANSI C.
4864
96f53c6c
PE
4865 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4866 It's more likely to cause problems (due to unsigned overflow)
4867 than to cure them.
4868
83c77d31
PE
4869 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4870
ee2079f1
PE
4871 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4872
6da65536
PE
4873 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4874
7147c4a4
PE
4875 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4876
193e32d9
PE
4877 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4878
e5533da6
PE
4879 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4880
9910e595
PE
4881 GLYPH_CODE_FACE returns EMACS_INT, not int.
4882 * dispextern.h (merge_faces):
4883 * xfaces.c (merge_faces):
01103c44
PE
4884 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4885 Don't assume EMACS_INT fits in int.
9910e595 4886
2638320e
PE
4887 * character.h (CHAR_VALID_P): Remove unused parameter.
4888 * fontset.c, lisp.h, xdisp.c: All uses changed.
4889
045eb8d9
PE
4890 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4891
c1f134b5
PE
4892 * fns.c (concat): Minor tuning based on overflow analysis.
4893 This doesn't fix any bugs. Use int to hold character, instead
4894 of constantly refetching from Emacs object. Use XFASTINT, not
4895 XINT, for value known to be a character. Don't bother comparing
4896 a single byte to 0400, as it's always less.
4897
395fcb93 4898 * floatfns.c (Fexpt):
327eeec8
PE
4899 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4900
abbd3d23
PE
4901 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4902 for characters.
4903
684a03ef
PE
4904 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4905
0fed43f3
PE
4906 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4907 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4908 incorrectly succeed when S was a string, because 4294967386 was
4909 truncated before it was used.
4910
8fd02eb7
PE
4911 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4912 Otherwise, an out-of-range integer could cause undefined behavior
4913 on a 64-bit host.
4914
f8c86b69
PE
4915 * composite.c: Use int, not EMACS_INT, for characters.
4916 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4917 EMACS_INT, for values that are known to be in character range.
4918 This doesn't fix any bugs but is the usual style inside Emacs and
4919 may generate better code on 32-bit machines.
4920
34206dd2
PE
4921 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4922 This is for reasons similar to the recent CHAR_STRING fix.
4923 * charset.c (Fencode_char): Check that character arg is actually
4924 a character. Pass an int to ENCODE_CHAR.
4925 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4926 wider than 'int', as a compile-time check to prevent future regressions
4927 in this area.
4928
c5958d4c 4929 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4930
4931 Make sure a 64-bit char is never passed to CHAR_STRING.
4932 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4933 by silently ignoring the top 32 bits, allowing some values
4934 that were far too large to be valid characters.
4935 * character.h: Include <verify.h>.
4936 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4937 arguments are no wider than unsigned, as a compile-time check
4938 to prevent future regressions in this area.
4939 * data.c (Faset):
01103c44 4940 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4941 (Fsubst_char_in_region):
4942 * fns.c (concat):
4943 * xdisp.c (decode_mode_spec_coding):
4944 Adjust to CHAR_STRING's new requirement.
4945 * editfns.c (Finsert_char, Fsubst_char_in_region):
4946 * fns.c (concat): Check that character args are actually
4947 characters. Without this test, these functions did the wrong
4948 thing with wildly out-of-range values on 64-bit hosts.
4949
d37ca623
PE
4950 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4951 These casts should not be needed on 32-bit hosts, either.
4952 * keyboard.c (read_char):
4953 * lread.c (Fload): Remove casts to unsigned.
4954
ea204efb
PE
4955 * lisp.h (UNSIGNED_CMP): New macro.
4956 This fixes comparison bugs on 64-bit hosts.
4957 (ASCII_CHAR_P): Use it.
4958 * casefiddle.c (casify_object):
01103c44 4959 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4960 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4961 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4962 * dispextern.h (FACE_FROM_ID):
4963 * keyboard.c (read_char): Use UNSIGNED_CMP.
4964
41cb286c
PE
4965 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4966 not to EMACS_INT, to avoid GCC warning.
4967
4a1b9832
PE
4968 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4969
55daad71
PE
4970 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4971 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4972 isn't needed on 32-bit machines.
8f95c75c 4973
01103c44
PE
4974 * buffer.c (Fgenerate_new_buffer_name):
4975 Use EMACS_INT for count, not int.
0ceccced 4976 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4977
4978 * data.c (Qcompiled_function): Now static.
4979
c6f072e7
PE
4980 * window.c (window_body_lines): Now static.
4981
20ce5912
PE
4982 * image.c (gif_load): Rename local to avoid shadowing.
4983
9c4c5f81
PE
4984 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4985 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4986 * alloc.c (make_save_value): Integer argument is now of type
4987 ptrdiff_t, not int.
4988 (mark_object): Use ptrdiff_t, not int.
4989 * lisp.h (pD): New macro.
4990 * print.c (print_object): Use it.
4991
c0c5c8ae
PE
4992 * alloc.c: Use EMACS_INT, not int, to count objects.
4993 (total_conses, total_markers, total_symbols, total_vector_size)
4994 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4995 (total_free_floats, total_floats, total_free_intervals)
4996 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4997 Now EMACS_INT, not int. All uses changed.
4998 (Fgarbage_collect): Compute overall total using a double, so that
4999 integer overflow is less likely to be a problem. Check for overflow
5000 when converting back to an integer.
5a25e253
PE
5001 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5002 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5003 These were 'int' variables that could overflow on 64-bit hosts;
5004 they were never used, so remove them instead of repairing them.
211a0b2a 5005 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5006 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5007 Previously, this ceilinged at INT_MAX, but that doesn't work on
5008 64-bit machines.
e46bb31a 5009 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5010
c78baabf 5011 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5012 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5013 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5014 when a (possibly-narrower) signed value would do just as well.
5015 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5016
c9d624c6
PE
5017 * alloc.c: Catch some string size overflows that we were missing.
5018 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5019 for convenience in STRING_BYTES_MAX.
5020 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5021 The definition here is exact; the one in lisp.h was approximate.
5022 (allocate_string_data): Check for string overflow. This catches
5023 some instances we weren't catching before. Also, it catches
5024 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5025 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5026 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5027
c9d624c6
PE
5028 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5029 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5030 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5031
353032ce
PE
5032 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5033
2bccce07
PE
5034 * alloc.c (Fmake_string): Check for out-of-range init.
5035
0ac30604
SM
50362011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5037
5038 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5039
c195f2de
JD
50402011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5041
5042 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5043 xg_get_default_scrollbar_width.
5044
5045 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5046 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5047 (style_changed_cb): Call update_theme_scrollbar_width and call
5048 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5049 all frames (Bug#8505).
5050 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5051 Call gtk_window_set_resizable if HAVE_GTK3.
5052 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5053 and height if HAVE_GTK3 (Bug#8505).
5054 (scroll_bar_width_for_theme): New variable.
5055 (update_theme_scrollbar_width): New function.
5056 (xg_get_default_scrollbar_width): Move code to
5057 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5058 (xg_initialize): Call update_theme_scrollbar_width.
5059
5060 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5061
5062 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5063
e10ac9f1
MR
50642011-06-12 Martin Rudalics <rudalics@gmx.at>
5065
5066 * frame.c (make_frame): Call other_buffer_safely instead of
5067 other_buffer.
5068
5069 * window.c (temp_output_buffer_show): Call display_buffer with
5070 second argument Vtemp_buffer_show_specifiers and reset latter
5071 immediately after the call.
5072 (Vtemp_buffer_show_specifiers): New variable.
5073 (auto_window_vscroll_p, next_screen_context_lines)
5074 (Vscroll_preserve_screen_position): Remove leading asterisks from
5075 doc-strings.
5076
2d3c217e 50772011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5078
7b7f97e8 5079 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5080 * buffer.c (Qclone_number): Remove for now, as it's unused.
5081 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5082 (record_buffer): Remove unused local.
5083 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5084 (set_frame_buffer_list): Remove; unused.
5085 * frame.h (other_visible_frames): Remove decl.
5086 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5087 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5088 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5089 if HAVE_GPM.
5090 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5091 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5092 Define only if HAVE_GPM.
5093 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5094 (update_hints_inhibit): Remove; never set. All uses removed.
5095 * widgetprv.h (emacsFrameClassRec): Remove decl.
5096 * window.c (delete_deletable_window): Now returns void, since it
5097 wasn't returning anything.
5098 (compare_window_configurations): Remove unused locals.
5099 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5100 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5101 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5102 the same widths as pointers. This follows up on the 2011-05-06 patch.
5103 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5104 * xterm.h: Likewise.
5105 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5106
1384b89e
JB
51072011-06-12 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * makefile.w32-in: Update dependencies.
5110 (LISP_H): Add lib/intprops.h.
5111
1100a63c
CY
51122011-06-11 Chong Yidong <cyd@stupidchicken.com>
5113
5114 * image.c (gif_load): Add animation frame delay to the metadata.
5115 (syms_of_image): Use DEFSYM. New symbol `delay'.
5116
6198ccd0
MR
51172011-06-11 Martin Rudalics <rudalics@gmx.at>
5118
5119 * window.c (delete_deletable_window): Re-add.
5120 (Fset_window_configuration): Rewrite to handle dead buffers and
5121 consequently deletable windows.
5122 (window_tree, Fwindow_tree): Remove. Supply functionality in
5123 window.el.
5124 (compare_window_configurations): Simplify code.
5125
b6e3633c
AS
51262011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5127
1ab0dee5
AS
5128 * image.c (imagemagick_load_image): Fix type mismatch.
5129 (Fimagemagick_types): Likewise.
5130
b6e3633c
AS
5131 * window.h (replace_buffer_in_windows): Declare.
5132
9397e56f
MR
51332011-06-11 Martin Rudalics <rudalics@gmx.at>
5134
5135 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5136 Qclone_number. Remove external declaration of Qdelete_window.
5137 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5138 code.
640c8776
SM
5139 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5140 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5141 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5142 buffer list implementation.
5143 (other_buffer_safely): New function.
5144 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5145 calls to replace_buffer_in_windows and
5146 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5147 if allowed.
5148 (record_buffer): Inhibit quitting and rewrite using quittable
5149 functions. Run Qbuffer_list_update_hook if allowed.
5150 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5151 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5152 Move switch-to-buffer to window.el.
9397e56f
MR
5153 (bury-buffer): Move to window.el.
5154 (Vbuffer_list_update_hook): New variable.
5155
5156 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5157 section.
5158
5159 * window.h (resize_frame_windows): Move up in code.
5160 (Fwindow_frame): Remove EXFUN.
5161 (replace_buffer_in_all_windows): Remove prototype.
5162 (replace_buffer_in_windows_safely): Add prototype.
5163
5164 * window.c: Declare Qdelete_window static again. Move down
5165 declaration of select_count.
5166 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5167 (Fother_window): Move to window.el.
5168 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5169 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5170 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5171 window.el.
5172 (replace_buffer_in_windows): Implement by calling
5173 Qreplace_buffer_in_windows.
5174 (replace_buffer_in_all_windows): Remove with some functionality
5175 moved into replace_buffer_in_windows_safely.
5176 (replace_buffer_in_windows_safely): New function.
5177 (select_window_norecord, select_frame_norecord): Move in front
5178 of run_window_configuration_change_hook. Remove now obsolete
5179 declarations.
640c8776
SM
5180 (Fset_window_buffer): Rewrite doc-string.
5181 Call Qrecord_window_buffer.
9397e56f
MR
5182 (keys_of_window): Move binding for other-window to window.el.
5183
b50691aa
CY
51842011-06-11 Chong Yidong <cyd@stupidchicken.com>
5185
5186 * dispextern.h (struct image): Replace data member, whose int_val
5187 and ptr_val fields were not used by anything, with a single
5188 lisp_val object.
5189
5190 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5191 (gif_clear_image, gif_load, imagemagick_load_image)
5192 (gs_clear_image, gs_load): Callers changed.
5193
3f754b86
PE
51942011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5195
cca69397
PE
5196 * buffer.h: Include <time.h>, for time_t.
5197 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5198
109e28d0
PE
5199 Fix minor problems found by static checking.
5200
60737f02
PE
5201 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5202
4b66faf3
PE
5203 Make identifiers static if they are not used in other modules.
5204 * data.c (Qcompiled_function, Qframe, Qvector):
5205 * image.c (QimageMagick, Qsvg):
5206 * minibuf.c (Qmetadata):
5207 * window.c (resize_window_check, resize_root_window): Now static.
5208 * window.h (resize_window_check, resize_root_window): Remove decls.
5209
109e28d0
PE
5210 * window.c (window_deletion_count, delete_deletable_window):
5211 Remove; unused.
46a4ce9e
PE
5212 (window_body_lines): Now static.
5213 (Fdelete_other_windows_internal): Mark vars as initialized.
5214 Make sure 'resize_failed' is initialized.
5215 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5216 (resize_window_apply): Remove unused local.
5217 * window.h (delete_deletable_window): Remove decl.
5218
109e28d0 5219 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5220 (imagemagick_load_image): Fix pointer signedness problem by changing
5221 last arg from unsigned char * to char *. All uses changed.
5222 Also, fix a local for similar reasons.
5223 Remove unused locals. Remove locals to avoid shadowing.
5224 (fn_rsvg_handle_free): Remove; unused.
5225 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5226 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5227
3f754b86
PE
5228 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5229
2547adb1
CY
52302011-06-10 Chong Yidong <cyd@stupidchicken.com>
5231
5232 * image.c (gif_load): Fix omitted cast error introduced by
5233 2011-06-06 change.
5234
2c8e37d4
MR
52352011-06-10 Martin Rudalics <rudalics@gmx.at>
5236
5237 * window.h (resize_proportionally, orig_total_lines)
5238 (orig_top_line): Remove from window structure.
5239 (set_window_height, set_window_width, change_window_heights)
5240 (Fdelete_window): Remove prototypes.
5241 (resize_frame_windows): Remove duplicate declaration.
5242
440a42e3
EZ
52432011-06-10 Eli Zaretskii <eliz@gnu.org>
5244
5245 * window.h (resize_frame_windows, resize_window_check)
5246 (delete_deletable_window, resize_root_window)
5247 (resize_frame_windows): Declare prototypes.
5248
5249 * window.c (resize_window_apply): Make definition be "static" to
5250 match the prototype.
5251
562dd5e9
MR
52522011-06-10 Martin Rudalics <rudalics@gmx.at>
5253
5254 * window.c: Remove declarations of Qwindow_size_fixed,
5255 window_min_size_1, window_min_size_2, window_min_size,
5256 size_window, window_fixed_size_p, enlarge_window, delete_window.
5257 Remove static from declaration of Qdelete_window, it's
5258 temporarily needed by Fbury_buffer.
5259 (replace_window): Don't assign orig_top_line and
5260 orig_total_lines.
5261 (Fdelete_window, delete_window): Remove. Window deletion is
5262 handled by window.el.
640c8776
SM
5263 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5264 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5265 (Fdelete_other_windows): Remove. Deleting other windows is
5266 handled by window.el.
5267 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5268 handled in window.el.
5269 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5270 Window minimum sizes are handled in window.el.
5271 (shrink_windows, size_window, set_window_height)
5272 (set_window_width, change_window_heights, window_height)
5273 (window_width, CURBEG, CURSIZE, enlarge_window)
5274 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5275 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5276 handled in window.el.
5277 (make_dummy_parent): Rename to make_parent_window and give it a
5278 second argument horflag.
5279 (make_window): Don't set resize_proportionally any more.
5280 (Fsplit_window): Remove. Windows are split in window.el.
5281 (save_restore_action, save_restore_orig_size)
5282 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5283 Resize mini windows in window.el.
5284 (grow_mini_window, shrink_mini_window): Implement by calling
5285 Qresize_root_window_vertically, resize_window_check and
5286 resize_window_apply.
640c8776
SM
5287 (saved_window, Fset_window_configuration, save_window_save):
5288 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5289 resize_proportionally.
5290 (window_min_height, window_min_width): Move to window.el.
5291 (keys_of_window): Move bindings for delete-other-windows,
5292 split-window, delete-window and enlarge-window to window.el.
5293
5294 * buffer.c: Temporarily extern Qdelete_window.
5295 (Fbury_buffer): Temporarily call Qdelete_window instead of
5296 Fdelete_window (Fbury_buffer will move to window.el soon).
5297
5298 * frame.c (set_menu_bar_lines_1): Remove code handling
5299 orig_top_line and orig_total_lines.
5300
5301 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5302 set_window_height but set heights directly.
5303 (change_frame_size_1): Use resize_frame_windows.
5304
5305 * xdisp.c (init_xdisp): Don't use set_window_height but set
5306 heights directly.
5307
640c8776
SM
5308 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5309 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5310 run_window_configuration_change_hook.
5311
5312 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5313 instead of change_window_heights and run
5314 run_window_configuration_change_hook.
5315
1a13852e
MR
53162011-06-09 Martin Rudalics <rudalics@gmx.at>
5317
5318 * window.c (replace_window): Rename second argument REPLACEMENT to
5319 NEW. New third argument SETFLAG. Rewrite.
5320 (delete_window, make_dummy_parent): Call replace_window with
5321 third argument 1.
5322 (window_list_1): Move down in code.
5323 (run_window_configuration_change_hook): Move set_buffer part
5324 before select_frame_norecord part in order to unwind correctly.
5325 Rename count1 to count.
5326 (recombine_windows, delete_deletable_window, resize_root_window)
5327 (Fdelete_other_windows_internal)
5328 (Frun_window_configuration_change_hook, make_parent_window)
5329 (resize_window_check, resize_window_apply, Fresize_window_apply)
5330 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5331 (Fdelete_window_internal, Fresize_mini_window_internal):
5332 New functions.
1a13852e
MR
5333 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5334
f3d1777e
MR
53352011-06-08 Martin Rudalics <rudalics@gmx.at>
5336
496e208e
MR
5337 * window.h (window): Add some new members to window structure -
5338 normal_lines, normal_cols, new_total, new_normal, clone_number,
5339 splits, nest, prev_buffers, next_buffers.
5340 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5341 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5342
f3d1777e
MR
5343 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5344 Remove.
496e208e
MR
5345 (make_dummy_parent): Set new members of windows structure.
5346 (make_window): Move down in code. Handle new members of window
5347 structure.
5348 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5349 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5350 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5351 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5352 (Fset_window_next_buffers, Fset_window_clone_number):
5353 New functions.
496e208e
MR
5354 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5355 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5356 Doc-string fixes.
5357 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5358 Argument WINDOW can be now internal window too.
5359 (Fwindow_use_time): Move up in code.
5360 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5361 Rewrite doc-string.
5362 (Fset_window_configuration, saved_window)
5363 (Fcurrent_window_configuration, save_window_save): Handle new
5364 members of window structure.
b9e809c2
MR
5365 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5366 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5367 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5368 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5369 Qget_mru_window, Qresize_root_window,
5370 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5371 Qauto_buffer_name; staticpro them.
f3d1777e 5372
abde8f8c
MR
53732011-06-07 Martin Rudalics <rudalics@gmx.at>
5374
5375 * window.c (Fwindow_total_size, Fwindow_left_column)
5376 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5377 (Fwindow_list_1): New functions.
5378 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5379 (Fwindow_width, Fscroll_left, Fscroll_right):
5380 Use window_body_cols instead of window_box_text_cols.
5381 (delete_window, Fset_window_configuration):
5382 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5383 (delete_all_subwindows): Take a window as argument and not a
5384 structure. Rewrite.
190b47e6
MR
5385 (window_loop): Remove handling of GET_LRU_WINDOW and
5386 GET_LARGEST_WINDOW.
5387 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5388
5389 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5390 window_box_text_cols. delete_all_subwindows now takes a
5391 Lisp_Object as argument.
abde8f8c 5392
640c8776
SM
5393 * indent.c (compute_motion, Fcompute_motion):
5394 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5395
fa8a67e6
MR
5396 * frame.c (delete_frame): Call delete_all_subwindows with root
5397 window as argument.
5398
a54e3482
DC
53992011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5400
5401 * fns.c (Fputhash): Document return value.
5402
60002bf5
CY
54032011-06-06 Chong Yidong <cyd@stupidchicken.com>
5404
5405 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5406
0c671da6 54072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5408
b862a52a 5409 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5410
be44ca6c
PE
5411 Check for overflow when converting integer to cons and back.
5412 * charset.c (Fdefine_charset_internal, Fdecode_char):
5413 Use cons_to_unsigned to catch overflow.
5414 (Fencode_char): Use INTEGER_TO_CONS.
5415 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5416 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5417 * data.c (long_to_cons, cons_to_long): Remove.
5418 (cons_to_unsigned, cons_to_signed): New functions.
5419 These signal an error for invalid or out-of-range values.
5420 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5421 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5422 * font.c (Ffont_variation_glyphs):
5423 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5424 * lisp.h: Include <intprops.h>.
5425 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5426 (cons_to_signed, cons_to_unsigned): New decls.
5427 (long_to_cons, cons_to_long): Remove decls.
5428 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5429 (Fprimitive_undo): Use CONS_TO_INTEGER.
5430 * xfns.c (Fx_window_property): Likewise.
5431 * xselect.c: Include <limits.h>.
5432 (x_own_selection, selection_data_to_lisp_data):
5433 Use INTEGER_TO_CONS.
5434 (x_handle_selection_request, x_handle_selection_clear)
5435 (x_get_foreign_selection, Fx_disown_selection_internal)
5436 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5437 (lisp_data_to_selection_data): Use cons_to_unsigned.
5438 (x_fill_property_data): Use cons_to_signed.
5439 Report values out of range.
5440
d1f3d2af
PE
5441 Check for buffer and string overflow more precisely.
5442 * buffer.h (BUF_BYTES_MAX): New macro.
5443 * lisp.h (STRING_BYTES_MAX): New macro.
5444 * alloc.c (Fmake_string):
5445 * character.c (string_escape_byte8):
5446 * coding.c (coding_alloc_by_realloc):
5447 * doprnt.c (doprnt):
5448 * editfns.c (Fformat):
5449 * eval.c (verror):
5450 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5451 since they may not be the same number.
5452 * editfns.c (Finsert_char):
5453 * fileio.c (Finsert_file_contents):
5454 Likewise for BUF_BYTES_MAX.
5455
dd52fcea
PE
5456 * image.c: Use ptrdiff_t, not int, for sizes.
5457 (slurp_file): Switch from int to ptrdiff_t.
5458 All uses changed.
5459 (slurp_file): Check that file size fits in both size_t (for
5460 malloc) and ptrdiff_t (for sanity and safety).
5461
7f9bbdbb
PE
5462 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5463 if b->modtime has its maximal value.
5464
dfe18f82
PE
5465 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5466
84acfcf0
PE
5467 Don't assume time_t can fit into int.
5468 * buffer.h (struct buffer.modtime): Now time_t, not int.
5469 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5470 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5471
ccd9a01a
PE
5472 Minor fixes for signed vs unsigned integers.
5473 * character.h (MAYBE_UNIFY_CHAR):
5474 * charset.c (maybe_unify_char):
5475 * keyboard.c (read_char, reorder_modifiers):
5476 XINT -> XFASTINT, since the integer must be nonnegative.
5477 * ftfont.c (ftfont_spec_pattern):
5478 * keymap.c (access_keymap, silly_event_symbol_error):
5479 XUINT -> XFASTINT, since the integer must be nonnegative.
5480 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5481 since it makes no difference and we prefer signed.
5482 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5483 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5484 nonnegative.
5485
d6d100dd
SM
54862011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5487
5488 * window.h (Fwindow_frame): Declare.
5489
2b6148e4
PE
54902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5491
5492 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5493 (SPARE_MEMORY): Always define.
5494 (LARGE_REQUEST): Remove.
5495 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5496
f230ecc9
MR
54972011-06-06 Martin Rudalics <rudalics@gmx.at>
5498
727e958e
MR
5499 * lisp.h: Move EXFUNS for Fframe_root_window,
5500 Fframe_first_window and Fset_frame_selected_window to window.h.
5501
5502 * window.h: Move EXFUNS for Fframe_root_window,
5503 Fframe_first_window and Fset_frame_selected_window here from
5504 lisp.h.
5505
5506 * frame.c (Fwindow_frame, Fframe_first_window)
5507 (Fframe_root_window, Fframe_selected_window)
5508 (Fset_frame_selected_window): Move to window.c.
5509 (Factive_minibuffer_window): Move to minibuf.c.
5510 (Fother_visible_frames_p): New function.
5511
5512 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5513
f230ecc9
MR
5514 * window.c (decode_window, decode_any_window): Move up in code.
5515 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5516 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5517 (Fwindow_buffer): Move up and rewrite doc-string.
5518 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5519 (Fwindow_prev): New functions.
727e958e
MR
5520 (Fwindow_frame): Move here from frame.c. Accept any window as
5521 argument.
5522 (Fframe_root_window, Fframe_first_window)
5523 (Fframe_selected_window): Move here from frame.c. Accept frame
5524 or arbitrary window as argument. Update doc-strings.
5525 (Fminibuffer_window): Move up in code.
5526 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5527 (Fset_frame_selected_window): Move here from frame.c.
5528 Marginal rewrite.
727e958e
MR
5529 (Fselected_window, select_window, Fselect_window): Move up in
5530 code. Minor doc-string fixes.
f230ecc9 5531
4d09bcf6
PE
55322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5533
5534 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5535 Do not assume that spare memory exists; that assumption is valid
5536 only if SYSTEM_MALLOC.
5537 (LARGE_REQUEST): New macro, so that the issue of large requests
5538 is separated from the issue of spare memory.
5539
810928a2
AS
55402011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5541
172418ad
AS
5542 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5543 format. (Bug#8806)
5544
43f862f7
AS
5545 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5546
810928a2
AS
5547 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5548 before statements.
5549
a059fe24
JD
55502011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5551
5552 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5553
5554 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5555
5556 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5557 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5558
989bf368
JB
55592011-06-05 Juanma Barranquero <lekktu@gmail.com>
5560
5561 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5562
4b80f674
CY
55632011-06-04 Chong Yidong <cyd@stupidchicken.com>
5564
5565 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5566 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5567 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5568 New error handlers.
4b80f674
CY
5569 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5570 Obey Vx_select_enable_clipboard_manager. Catch errors in
5571 x_clipboard_manager_save (Bug#8779).
5572 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5573 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5574
99a33b77 55752011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5576
5577 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5578
99a33b77 55792011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5580
5581 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5582 in the current matrix if keep_current_p is non-zero.
5583
8264569d
EZ
55842011-06-04 Eli Zaretskii <eliz@gnu.org>
5585
5586 * bidi.c (bidi_level_of_next_char): Fix last change.
5587
57f97249
EZ
55882011-06-03 Eli Zaretskii <eliz@gnu.org>
5589
fec2107c 5590 Support bidi reordering of text covered by display properties.
57f97249 5591
fec2107c
EZ
5592 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5593 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5594 (bidi_cache_search, bidi_cache_iterator_state)
5595 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5596 (bidi_level_of_next_char, bidi_move_to_visually_next):
5597 Support character positions inside a run of characters covered by a
fec2107c
EZ
5598 display string.
5599 (bidi_paragraph_init, bidi_resolve_explicit_1)
5600 (bidi_level_of_next_char): Call bidi_fetch_char and
5601 bidi_fetch_char_advance instead of FETCH_CHAR and
5602 FETCH_CHAR_ADVANCE.
5603 (bidi_init_it): Initialize new members.
5604 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5605 definitions.
5606 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5607 instead of using explicit *_CHAR codes.
d6d100dd
SM
5608 (bidi_resolve_explicit, bidi_resolve_weak):
5609 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5610 bidirectional text is supported only in multibyte buffers.
5611 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5612 it to initialize the frame_window_p member of struct bidi_it.
5613 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5614 (bidi_resolve_explicit, bidi_resolve_weak)
5615 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5616 bidi_it->nchars is non-positive.
5617 (bidi_level_of_next_char): Don't try to lookup the cache for the
5618 next/previous character if nothing is cached there yet, or if we
5619 were just reseat()'ed to a new position.
c40e2fb2 5620
0e14fe90
EZ
5621 * xdisp.c (set_cursor_from_row): Set start and stop points
5622 according to the row's direction when priming the loop that looks
5623 for the glyph on which to display cursor.
5624 (single_display_spec_intangible_p): Function deleted.
5625 (display_prop_intangible_p): Reimplement to call
5626 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5627 Accept 3 additional arguments needed by handle_display_spec.
5628 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5629 values: lists, `(when COND...)' forms, etc.
5630 (single_display_spec_string_p): Support property values that are
5631 lists with the argument STRING its top-level element.
5632 (display_prop_string_p): Fix the condition for processing a
5633 property that is a list to be consistent with handle_display_spec.
fec2107c 5634 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5635 last portion of handle_display_prop.
5636 (compute_display_string_pos): Accept additional argument
5637 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5638 value of a `display' property is a "replacing spec".
5639 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5640 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5641 the display property, but just return a value indicating whether
5642 the display property will replace the characters it covers.
5643 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5644 frame_window_p members of struct bidi_it.
d6d100dd
SM
5645 (compute_display_string_pos, compute_display_string_end):
5646 New functions.
fec2107c
EZ
5647 (push_it): Accept second argument POSITION, where pop_it should
5648 jump to continue iteration.
5649 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5650
fec2107c
EZ
5651 * keyboard.c (adjust_point_for_property): Adjust the call to
5652 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5653
5654 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5655 (bidi_init_it): Update prototypes.
5656 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5657 (compute_display_string_pos, compute_display_string_end):
5658 Declare prototypes.
fec2107c
EZ
5659 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5660 EMACS_INT.
fc6f18ce 5661
40087514 56622011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5663
57f53182
PE
5664 Malloc failure behavior now depends on size of allocation.
5665 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5666 * lisp.h: Change signatures accordingly.
5667 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5668 All callers changed. (Bug#8762)
5669
5670 * gnutls.c: Use Emacs's memory allocators.
5671 Without this change, the gnutls library would invoke malloc etc.
5672 directly, which causes problems on non-SYNC_INPUT hosts, and which
5673 runs afoul of improving memory_full behavior. (Bug#8761)
5674 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5675 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5676 xfree instead of the default malloc, realloc, free.
5677 (Fgnutls_boot): No need to check for memory allocation failure,
5678 since xmalloc does that for us.
5679
ac32cd99 5680 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5681 * category.c (hash_get_category_set):
5682 * ccl.c (ccl_driver):
5683 * charset.c (Fdefine_charset_internal):
5684 * charset.h (struct charset.hash_index):
5685 * composite.c (get_composition_id, gstring_lookup_cache)
5686 (composition_gstring_put_cache):
5687 * composite.h (struct composition.hash_index):
5688 * dispextern.h (struct image.hash):
5689 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5690 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5691 (hashfn_equal, hashfn_user_defined, make_hash_table)
5692 (maybe_resize_hash_table, hash_lookup, hash_put)
5693 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5694 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5695 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5696 * image.c (make_image, search_image_cache, lookup_image)
5697 (xpm_put_color_table_h):
5698 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5699 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5700 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5701 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5702 * alloc.c (allocate_vectorlike):
5703 Check for overflow in vector size calculations.
5704 * ccl.c (ccl_driver):
5705 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5706 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5707 need to be updated by these changes.
40087514
PE
5708 * fns.c (make_hash_table, maybe_resize_hash_table):
5709 Check for integer overflow with large hash tables.
0de4bb68
PE
5710 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5711 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5712 (SXHASH_REDUCE): New macro.
5713 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5714 Use it instead of discarding useful hash info with large hash values.
5715 (sxhash_float): New function.
5716 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5717 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5718 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5719 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5720 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5721 Adjust signatures to match updated version of code.
5722 (consing_since_gc): Now EMACS_INT, since a single hash table can
5723 use more than INT_MAX bytes.
5724
698d32e2
DN
57252011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5726
5727 Make it possible to build with GCC-4.6+ -O2 -flto.
5728
5729 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5730
fd6fa53f
SM
57312011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5732
5733 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5734 Call minibuffer-inactive-mode.
5735
864db017
JB
57362011-05-31 Juanma Barranquero <lekktu@gmail.com>
5737
5738 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5739 Update dependencies.
5740
2ad0baf4
DN
57412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5742
5743 * data.c (init_data): Remove code for UTS, this system is not
5744 supported anymore.
5745
4fcc2638
DN
57462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5747
5748 Don't force ./temacs to start in terminal mode.
5749
5750 * frame.c (make_initial_frame): Initialize faces in all cases, not
5751 only when CANNOT_DUMP is defined.
5752 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5753
c56e0fd5
DN
57542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5755
5756 * dispnew.c (add_window_display_history): Use const for the string
5757 pointer. Remove declaration, not needed.
5758
333d54da 57592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5760
55d4c1b2 5761 Use 'inline', not 'INLINE'.
333d54da 5762 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5763 * alloc.c, fontset.c (INLINE): Remove.
5764 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5765 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5766 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5767 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5768 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5769
738db178
DN
57702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5771
5772 Make it possible to run ./temacs.
5773
5774 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5775 syms_of_callproc does the same thing. Remove test for
5776 "initialized", do it in the caller.
5777 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5778
620c53a6
SM
57792011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5780
5781 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5782 (read_minibuf): Use get_minibuffer.
5783 (syms_of_minibuf): Use DEFSYM.
5784 (Qmetadata): New var.
5785 * data.c (Qbuffer): Don't make it static.
5786 (syms_of_data): Use DEFSYM.
5787
e003a292
PE
57882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5789
5790 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5791 (CCL_CODE_MIN): New macro.
5792
ed008a6d
PE
57932011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5794
3687c2ef
PE
5795 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5796
ed008a6d
PE
5797 * eval.c (Qdebug): Now static.
5798 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5799 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5800 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5801
d66c4c7c
CY
58022011-05-29 Chong Yidong <cyd@stupidchicken.com>
5803
5804 * image.c: Various fixes to ImageMagick code comments.
5805 (Fimagemagick_types): Doc fix.
5806
5fbc2025
PE
58072011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5808
0196f88a
PE
5809 Minor fixes prompted by GCC 4.6.0 warnings.
5810
5811 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5812
5fbc2025
PE
5813 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5814 (x_clipboard_manager_save_all): Move extern decl to ...
5815 * xterm.h: ... here, so that it can be checked for consistency.
5816
1dd3c2d9
CY
58172011-05-29 Chong Yidong <cyd@stupidchicken.com>
5818
5819 * xselect.c (x_clipboard_manager_save_frame)
5820 (x_clipboard_manager_save_all): New functions.
5821 (Fx_clipboard_manager_save): Lisp function deleted.
5822
5823 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5824 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5825
5826 * xterm.h: Update prototype.
5827
5ba6571d
WX
58282011-05-28 William Xu <william.xwl@gmail.com>
5829
5830 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5831 exiting (Bug#8239).
5832
3eaff834
JM
58332011-05-28 Jim Meyering <meyering@redhat.com>
5834
e1900994 5835 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5836 * fns.c (to_uchar): Define.
5837 (crypto_hash_function): Use it to convert some newly-signed
5838 variables to unsigned, to avoid sign-extension bugs. For example,
5839 without this change, (md5 "truc") would evaluate to
5840 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5841 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5842 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5843
0f6990a7
PE
58442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5845
5846 Integer overflow fixes.
c8a9ca5a 5847
08686060
PE
5848 * dbusbind.c: Serial number integer overflow fixes.
5849 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5850 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5851 to hold a serial number that is too large for a fixnum.
5852 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5853 Check for serial numbers out of range. Decode any serial number
59568bf0 5854 that was so large that it became a float. (Bug#8722)
08686060 5855
2d1fc3c7
PE
5856 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5857 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5858 Use XFASTINT rather than XUINT when numbers are nonnegative.
5859 (xd_append_arg, Fdbus_method_return_internal):
5860 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5861 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5862 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5863 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5864 (Bug#8722)
2d1fc3c7 5865
c8a9ca5a
PE
5866 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5867
519e1d69
PE
5868 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5869
6df6ae42 5870 ccl: Add integer overflow checks.
30569699
PE
5871 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5872 (IN_INT_RANGE): New macros.
5873 (ccl_driver): Use them to check for integer overflow when
5874 decoding a CCL program. Many of the new checks are whether XINT (x)
5875 fits in int; it doesn't always, on 64-bit hosts. The new version
5876 doesn't catch all possible integer overflows, but it's an
847044ea 5877 improvement. (Bug#8719)
30569699 5878
c11285dc
PE
5879 * alloc.c (make_event_array): Use XINT, not XUINT.
5880 There's no need for unsigned here.
5881
fdccd48e
PE
5882 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5883 This follows up to the 2011-05-06 change that substituted uintptr_t
5884 for EMACS_INT. This case wasn't caught back then.
5885
37910ab2
PE
5886 Rework Fformat to avoid integer overflow issues.
5887 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5888 now (part of C89). Include <verify.h>.
5889 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5890 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5891 (Fformat): Avoid the prepass trying to compute sizes; it was only
5892 approximate and thus did not catch overflow reliably. Instead, walk
5893 through the format just once, formatting and computing sizes as we go,
5894 checking for integer overflow at every step, and allocating a larger
5895 buffer as needed. Keep track separately whether the format is
5896 multibyte. Keep only the most-recently calculated precision, rather
5897 than them all. Record whether each argument has been converted to
5898 string. Use EMACS_INT, not int, for byte and char and arg counts.
5899 Support field widths and precisions larger than INT_MAX. Avoid
5900 sprintf's undefined behavior with conversion specifications such as %#d
5901 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5902 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5903 formatting out-of-range floating point numbers with int
9173deec 5904 formats. (Bug#8668)
37910ab2 5905
2e6578fb
PE
5906 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5907
0ae6bdee
PE
5908 * data.c: Avoid integer truncation in expressions involving floats.
5909 * data.c: Include <intprops.h>.
5910 (arith_driver): When there's an integer overflow in an expression
5911 involving floating point, convert the integers to floating point
5912 so that the resulting value does not suffer from catastrophic
5913 integer truncation. For example, on a 64-bit host (* 4
5914 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5915 Do not rely on undefined behavior after integer overflow.
5916
de883a70
PE
5917 merge count_size_as_multibyte, parse_str_to_multibyte
5918 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5919 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5920 Check for integer overflow.
5921 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5922 since it's now a duplicate of the other. This is more of
5923 a character than a buffer op, so better that it's in character.c.
5924 * fns.c, print.c: Adjust to above changes.
5925
2ff916cb
PE
59262011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5927
5928 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5929
f1b54466
PE
59302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5931
fb1ac845
PE
5932 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5933 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5934 (x_clipboard_manager_save): Now static.
5935 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5936
f1b54466
PE
5937 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5938 (crypto_hash_function): Now static.
5939 Fix pointer signedness problems. Avoid unnecessary initializations.
5940
a9f737ee
CY
59412011-05-27 Chong Yidong <cyd@stupidchicken.com>
5942
5943 * termhooks.h (Vselection_alist): Make it terminal-local.
5944
5945 * terminal.c (create_terminal): Initialize it.
5946
5947 * xselect.c: Support for clipboard managers.
5948 (Vselection_alist): Move to termhooks.h as terminal-local var.
5949 (LOCAL_SELECTION): New macro.
5950 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5951 (symbol_to_x_atom): Remove gratuitous arg.
5952 (x_handle_selection_request, lisp_data_to_selection_data)
5953 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5954 (x_own_selection, x_get_local_selection, x_convert_selection):
5955 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5956 (some_frame_on_display): Delete unused function.
5957 (Fx_own_selection_internal, Fx_get_selection_internal)
5958 (Fx_disown_selection_internal, Fx_selection_owner_p)
5959 (Fx_selection_exists_p): New optional frame arg.
5960 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5961 (x_handle_selection_clear): Don't treat other terminals with the
5962 same keyboard specially. Use the terminal-local Vselection_alist.
5963 (x_clear_frame_selections): Use Frun_hook_with_args.
5964
5965 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5966
5967 * xterm.h: Add support for those atoms.
5968
e067f0c1
CY
59692011-05-26 Chong Yidong <cyd@stupidchicken.com>
5970
5971 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5972 (converted_selections, conversion_fail_tag): New global variables.
5973 (x_selection_request_lisp_error): Free the above.
5974 (x_get_local_selection): Remove unnecessary code.
5975 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5976 of converted selections stored in converted_selections.
5977 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5978 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5979 (x_convert_selection): New function.
5980 (x_handle_selection_event): Simplify.
5981 (x_get_foreign_selection): Don't ignore incoming requests while
5982 waiting for an answer; this will fail when we implement
5983 SAVE_TARGETS, and seems unnecessary anyway.
5984 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5985 (Vx_sent_selection_functions): Doc fix.
5986
0f4aebc0
LL
59872011-05-26 Leo Liu <sdl.web@gmail.com>
5988
5989 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5990
e61124cd
YM
59912011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5992
5993 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5994
5995 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5996 for fringe update if it has periodic bitmap.
ac389d0c 5997 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5998 and fringe_bitmap_periodic_p.
5999
6000 * fringe.c (get_fringe_bitmap_data): New function.
6001 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6002 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6003 row. Mark glyph row for fringe update if periodicity changed.
6004
6005 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6006 for fringe update unless it has periodic bitmap.
6007
f16d9837
KH
60082011-05-25 Kenichi Handa <handa@m17n.org>
6009
6010 * xdisp.c (get_next_display_element): Set correct it->face_id for
6011 a static composition.
6012
e1b90ef6
LL
60132011-05-24 Leo Liu <sdl.web@gmail.com>
6014
6015 * deps.mk (fns.o):
6016 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6017
6018 * fns.c (crypto_hash_function, Fsha1): New function.
6019 (Fmd5): Use crypto_hash_function.
6020 (syms_of_fns): Add Ssha1.
6021
7400048f
PE
60222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 * gnutls.c: Remove unused macros.
6025 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6026 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6027 Remove macros that are defined and never used.
6028 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6029
abb71cf4
CY
60302011-05-22 Chong Yidong <cyd@stupidchicken.com>
6031
6032 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6033 (Fx_get_selection_internal): Minor cleanup.
6034 (Fx_own_selection_internal): Rename arguments for consistency with
6035 select.el.
6036
6307db39
PE
60372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6038
6039 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6040
f3d4e0a4
CY
60412011-05-22 Chong Yidong <cyd@stupidchicken.com>
6042
6043 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6044
4d8ade89
YM
60452011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6046
6047 * dispnew.c (scrolling_window): Don't exclude the case that the
6048 last enabled row in the desired matrix touches the bottom boundary.
6049
32078c8d
GM
60502011-05-21 Glenn Morris <rgm@gnu.org>
6051
6052 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6053 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6054 and add some more files.
32078c8d 6055
7285dc67
EZ
60562011-05-20 Eli Zaretskii <eliz@gnu.org>
6057
6058 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6059 report_file_error introduced by the change from 2011-05-07.
6060
89d1bd22
PE
60612011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 * systime.h (Time): Define only if emacs is defined.
6064 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6065 where the include path doesn't have X11/X.h by default. See
6066 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6067
cd394be1 60682011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6069
6070 * composite.c (find_automatic_composition): Fix previous change.
6071
b9704ad9
GM
60722011-05-20 Glenn Morris <rgm@gnu.org>
6073
6074 * lisp.mk: New file, split from Makefile.in.
6075 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6076 (shortlisp): Remove.
6077 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6078
4a720484
GM
60792011-05-19 Glenn Morris <rgm@gnu.org>
6080
6081 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6082 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6083 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6084 (lisp): Set the order to that of loadup.el.
6085 (shortlisp): Make it a copy of $lisp.
6086 (SOME_MACHINE_LISP): Remove.
6087 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6088 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6089
a28d4396
KH
60902011-05-18 Kenichi Handa <handa@m17n.org>
6091
6092 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6093 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6094 (find_automatic_composition): Mostly rewrite for efficiency.
6095
a2b1fa8e
JB
60962011-05-18 Juanma Barranquero <lekktu@gmail.com>
6097
6098 * makefile.w32-in: Update dependencies.
6099
8e1f5610
CS
61002011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6101
6102 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6103 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6104
7025ee00 61052011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6106
cdfa6eab
PE
6107 Fix some integer overflow issues, such as string length overflow.
6108
06d6db33
PE
6109 * insdel.c (count_size_as_multibyte): Check for string overflow.
6110
2b4560a8
PE
6111 * character.c (lisp_string_width): Check for string overflow.
6112 Use EMACS_INT, not int, for string indexes and lengths; in
6113 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6114 the resulting string length overflows an EMACS_INT; instead,
6115 report a string overflow if no precision given. When checking for
6116 precision exhaustion, use a check that cannot possibly have
6117 integer overflow. (Bug#8675)
6118 * character.h (lisp_string_width): Adjust to new signature.
6119
cb93f9be
PE
6120 * alloc.c (string_overflow): New function.
6121 (Fmake_string): Use it. This doesn't change behavior, but saves
6122 a few bytes and will simplify future changes.
6123 * character.c (string_escape_byte8): Likewise.
6124 * lisp.h (string_overflow): New decl.
6125
1a1f3366
PE
6126 Fixups, following up to the user-interface timestamp change.
6127 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6128 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6129 * msdos.c (mouse_get_pos): Likewise.
6130 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6131 * w32gui.h (Time): Define by including "systime.h" rather than by
6132 declaring it ourselves. (Bug#8664)
6133
d4e3e4d3
PE
6134 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6135 * image.c (clear_image_cache): Likewise.
6136
f6a24d19
PE
6137 * term.c (term_mouse_position): Don't assume time_t wraparound.
6138
08dc5ae6
PE
6139 Be more systematic about user-interface timestamps.
6140 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6141 and sometimes 'EMACS_UINT', to represent these timestamps.
6142 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6143 This makes the code easier to follow, and makes it easier to catch
6144 integer overflow bugs such as Bug#8664.
6145 * frame.c (Fmouse_position, Fmouse_pixel_position):
6146 Use Time, not unsigned long, for user-interface timestamps.
6147 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6148 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6149 * keyboard.h (last_event_timestamp): Likewise.
6150 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6151 * menu.h (xmenu_show): Likewise.
6152 * term.c (term_mouse_position): Likewise.
6153 * termhooks.h (struct input_event.timestamp): Likewise.
6154 (struct terminal.mouse_position_hook): Likewise.
6155 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6156 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6157 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6158 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6159 what it was before.
6160 * menu.h, termhooks.h: Include "systime.h", for Time.
6161
8e55734a
PE
6162 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6163 Don't assume that the difference between two unsigned long values
6164 can fit into an integer. At this point, we know button_down_time
6165 <= event->timestamp, so the difference must be nonnegative, so
6166 there's no need to cast the result if double-click-time is
6167 nonnegative, as it should be; check that it's nonnegative, just in
6168 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6169 apart (about 25 days). (Bug#8664)
8e55734a 6170
841f1b75 6171 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6172 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6173
3e26f69c
PE
6174 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6175 that always fit in int. Use a sentinel instead of a counter, to
6176 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6177 * frame.h (struct frame): Use int for menu_bar_items_used
6178 instead of EMACS_INT, since it always fits in int.
3e26f69c 6179
5cc152c0
PE
6180 * menu.c (grow_menu_items): Check for int overflow.
6181
d89eb65e
PE
6182 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6183
5235bd3e
PE
6184 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6185 Before, the code was not consistent. These values cannot exceed
6186 2**31 - 1 so there's no need to make them unsigned.
6187 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6188 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6189 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6190 as modifiers.
6191 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6192
bc827e23
PE
6193 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6194 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6195 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6196 presumably because the widths might not match.
6197
78eb494e
PE
6198 * window.c (size_window): Avoid needless test at loop start.
6199
04f2d78b
CB
62002011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6201
6202 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6203
d2fc7e3d 62042011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6205
6206 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6207
d2fc7e3d 62082011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6209
6210 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6211 `width' to `bar_area_x' and `bar_area_width', respectively.
6212 (x_scroll_run): Take account of fringe background extension.
6213
04f2d78b
CB
6214 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6215 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6216 `bar_area_width', respectively.
6217 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6218 background extension.
6219
79b70037
GM
62202011-05-10 Jim Meyering <meyering@redhat.com>
6221
6222 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6223
2f142cc5
JB
62242011-05-10 Juanma Barranquero <lekktu@gmail.com>
6225
6226 * image.c (Finit_image_library): Return t for built-in image types,
6227 like pbm and xbm. (Bug#8640)
6228
57679c86
AS
62292011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6230
6231 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6232
888c9e86
EZ
62332011-05-07 Eli Zaretskii <eliz@gnu.org>
6234
b0512a1d
EZ
6235 * w32console.c (Fset_screen_color): Doc fix.
6236 (Fget_screen_color): New function.
6237 (syms_of_ntterm): Defsubr it.
6238
7285dc67
EZ
6239 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6240 unlink the temporary file if Fcall_process didn't create it in the
6241 first place.
6242 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6243 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6244 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6245 cue to call_process_cleanup not to close that handle.
6246
4d3fcc8e
BK
62472011-05-07 Ben Key <bkey76@gmail.com>
6248
6249 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6250 one of two shell specific rules, either bootstrap-temacs-CMD or
6251 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6252 to the previous implementation of the bootstrap-temacs rule.
6253 The bootstrap-temacs-CMD rule is similar to the previous
6254 implementation of the bootstrap-temacs rule except that it
6255 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6256 variable.
6257
6258 These changes, along with some changes to nt/configure.bat,
6259 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6260 earlier fix to add support for --cflags and --ldflags options
6261 that include quotes so that it works whether make uses cmd or
6262 sh as the shell.
6263
b4289b64
MA
62642011-05-06 Michael Albinus <michael.albinus@gmx.de>
6265
6266 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6267 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6268 is a constant.
6269 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6270 a string. Handle both cases.
6271 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6272 (Fdbus_register_method): Use Qinvalid_function.
6273
af4c0e28
JB
62742011-05-06 Juanma Barranquero <lekktu@gmail.com>
6275
6276 * makefile.w32-in: Update dependencies.
6277 (LISP_H): Add inttypes.h and stdin.h.
6278 (PROCESS_H): Add unistd.h.
6279
c51453d9
EZ
62802011-05-06 Eli Zaretskii <eliz@gnu.org>
6281
6282 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6283 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6284
8ff0ac3c 62852011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6286
4c4b566b
PE
6287 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6288
aab2b9b5
PE
6289 * term.c (vfatal): Remove stray call to va_end.
6290 It's not needed and the C Standard doesn't allow it here anyway.
6291
c378da0b
PE
6292 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6293 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6294
288b08c7
PE
6295 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6296 bytes.
6297
e3601888
PE
6298 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6299
db6c0e74
PE
6300 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6301
dd5963ea
PE
6302 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6303
88c9450f
PE
6304 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6305
2f9442b8
PE
6306 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6307
c032b5f8
PE
6308 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6309 * charset.c (Fdefine_charset_internal): Don't initialize
6310 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6311 32-bit int (Bug#8600).
a108c10b
PE
6312
6313 * lread.c (read_integer): Be more consistent with string-to-number.
6314 Use string_to_number to do the actual conversion; this avoids
6315 rounding errors and fixes some other screwups. Without this fix,
6316 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6317 (digit_to_number): Move earlier, for benefit of read_integer.
6318 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6319 not a digit in any supported base. (Bug#8602)
a108c10b 6320
ad5f9eea
PE
6321 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6322
aec1708a
PE
6323 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6324 to match comment at start of function. This also removes a
6325 GCC warning about overflow in a 32+64-bit port.
6326
47be4ab5
PE
6327 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6328
371cac43
PE
6329 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6330 Reported by Stefan Monnier in
6331 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6332 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6333 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6334
d01a7826
PE
6335 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6336 (EMACS_UINTPTR): Likewise, with uintptr_t.
6337
7fd47d5c
PE
6338 * lisp.h: Prefer 64-bit EMACS_INT if available.
6339 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6340 on 32-bit hosts that have 64-bit int, so that they can access
6341 large files.
122b0c86
PE
6342 However, temporarily disable this change unless the temporary
6343 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6344
8727937b
PE
6345 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6346
8ac068ac
PE
6347 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6348 This removes an assumption that EMACS_INT and long are the same
6349 width as pointers. The assumption is true for Emacs porting targets
6350 now, but we want to make other targets possible.
6351 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6352 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6353 In the rest of the code, change types of integers that hold casted
6354 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6355 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6356 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6357 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6358 No need to cast type when ORing.
6359 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6360 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6361 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6362 assume EMACS_INT is the same width as char *.
6363 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6364 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6365 Remove no-longer-needed casts.
6366 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6367 (xg_tool_bar_help_callback, xg_make_tool_item):
6368 Use EMACS_INTPTR to hold an integer
6369 that will be cast to void *; this can avoid a GCC warning
6370 if EMACS_INT is not the same width as void *.
6371 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6372 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6373 (current_message_1, set_message_1):
6374 Use a local to convert to proper width without a cast.
6375 * xmenu.c (dialog_selection_callback): Likewise.
6376
ede49d71
PE
6377 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6378 Also, don't assume VALBITS / RAND_BITS is less than 5,
6379 and don't rely on undefined behavior when shifting a 1 left into
6380 the sign bit.
6381 * lisp.h (get_random): Change signature to match.
6382
2f30ecd0
PE
6383 * lread.c (hash_string): Use size_t, not int, for hash computation.
6384 Normally we prefer signed values; but hashing is special, because
6385 it's better to use unsigned division on hash table sizes so that
6386 the remainder is nonnegative. Also, size_t is the natural width
6387 for hashing into memory. The previous code used 'int', which doesn't
6388 retain enough info to hash well into very large tables.
6389 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6390
2a866e7b
PE
6391 * dbusbind.c: Don't possibly lose pointer info when converting.
6392 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6393 Use XPNTR rather than XHASH, so that the high-order bits of
6394 the pointer aren't lost when converting through void *.
6395
51639eac
PE
6396 * eval.c (Fautoload): Don't double-shift a pointer.
6397
92394119
PE
6398 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6399
dbdb9a7c
JB
64002011-05-06 Juanma Barranquero <lekktu@gmail.com>
6401
6402 * gnutls.c (DEF_GNUTLS_FN):
6403 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6404
db7a0b4f
AS
64052011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6406
6407 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6408 marker. (Bug#8610)
6409
cd394be1 64102011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6411
6412 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6413 New version that can reserve upto 2GB of heap space.
6414
f7ff1b0f 64152011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6416
6417 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6418
639c109b
TZ
64192011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6420
6421 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6422 `gnutls_certificate_set_x509_key_file'.
6423
d2127135
JB
64242011-05-05 Juanma Barranquero <lekktu@gmail.com>
6425
6426 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6427 Update dependencies.
6428
e968f4f3
JB
64292011-05-04 Juanma Barranquero <lekktu@gmail.com>
6430
6431 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6432 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6433 Remove unused parameter `fildes'.
6434 * process.c (read_process_output, send_process): Don't pass it.
6435
84d358f0
JB
64362011-05-04 Juanma Barranquero <lekktu@gmail.com>
6437
6438 Fix previous change: the library cache is defined in w32.c.
6439 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6440 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6441
0898ca10
JB
64422011-05-04 Juanma Barranquero <lekktu@gmail.com>
6443
6444 Implement dynamic loading of GnuTLS on Windows.
6445
6446 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6447 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6448 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6449 Declare.
6450
6451 * gnutls.c (Qgnutls_dll): Define.
6452 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6453 (gnutls_*): Declare function pointers.
6454 (init_gnutls_functions): New function to initialize function pointers.
6455 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6456 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6458 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6459 (emacs_gnutls_write, emacs_gnutls_read)
6460 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6461 (Fgnutls_available_p): New function.
6462 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6463 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6464 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6465
6466 * image.c: Include w32.h.
6467 (Vimage_type_cache): Delete.
6468 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6469 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6470 (w32_delayed_load): Move to w32.c.
6471
6472 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6473
6474 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6475 (w32_delayed_load): Move from image.c. When loading a library, record
6476 its filename in the :loaded-from property of the library id.
6477 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6478 Initialize and staticpro them.
6479 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6480
6481 * process.c: Include lisp.h before w32.h, not after.
6482 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6483 instead of gnutls_record_check_pending.
6484
6485 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6486
ff4de4aa
TZ
64872011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6488
6489 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6490 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6491 as passed in.
6492
abe95abb
JD
64932011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6494
6495 * xterm.c (x_set_frame_alpha): Do not set property on anything
6496 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6497
e16e55d4
JB
64982011-05-02 Juanma Barranquero <lekktu@gmail.com>
6499
6500 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6501
bafcf6a5
JB
65022011-05-02 Juanma Barranquero <lekktu@gmail.com>
6503
6504 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6505 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6506 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6507 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6508 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6509 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6510 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6511 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6512 (Qgnutls_bootprop_callbacks_verify): Make static.
6513
e7a6747f
AS
65142011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6515
19ed11ba
AS
6516 * callproc.c: Indentation fixup.
6517
e7a6747f 6518 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6519 (wait_for_termination, interruptible_wait_for_termination):
6520 Move after wait_for_termination_1.
e7a6747f 6521
1ef14cb4
LMI
65222011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6523
6524 * sysdep.c (interruptible_wait_for_termination): New function
6525 which is like wait_for_termination, but allows keyboard
6526 interruptions.
6527
6528 * callproc.c (Fcall_process): Add (:file "file") as an option for
6529 the STDOUT buffer.
6530 (Fcall_process_region): Ditto.
6531
330d880c
EZ
65322011-04-30 Eli Zaretskii <eliz@gnu.org>
6533
8db90b73
EZ
6534 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6535 rather than `XVECTOR (FOO)->size'.
6536
330d880c
EZ
6537 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6538 inttypes.h, as a gnulib replacement is used if it not available in
6539 system headers.
6540
15cbd324
EZ
65412011-04-21 Eli Zaretskii <eliz@gnu.org>
6542
6543 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6544 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6545 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6546
6547 * coding.c (coding_alloc_by_realloc): Error out if destination
6548 will grow beyond MOST_POSITIVE_FIXNUM.
6549 (decode_coding_emacs_mule): Abort if there isn't enough place in
6550 charbuf for the composition carryover bytes. Reserve an extra
6551 space for up to 2 characters produced in a loop.
6552 (decode_coding_iso_2022): Abort if there isn't enough place in
6553 charbuf for the composition carryover bytes.
6554
65552011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6556
ae940cca
EZ
6557 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6558 aborting when %lld or %lll format is passed.
6559 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6560 %llo or %llx format is passed. (Bug#8545)
6561
03ab8921
EZ
6562 * window.c (window_scroll_line_based): Use a marker instead of
6563 simple variables to record original value of point. (Bug#7952)
6564
afda1437
EZ
6565 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6566 produced by %s or %c overflows available buffer space. (Bug#8545)
6567
f76dee0c
PE
65682011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6571 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6572
fdc5744d
JB
65732011-04-28 Juanma Barranquero <lekktu@gmail.com>
6574
6575 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6576
638f053a
JB
65772011-04-28 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * keyboard.c (Qdelayed_warnings_hook): Define.
6580 (command_loop_1): Run `delayed-warnings-hook'
6581 if Vdelayed_warnings_list is non-nil.
6582 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6583 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6584
d178f871
EZ
65852011-04-28 Eli Zaretskii <eliz@gnu.org>
6586
6587 * doprnt.c (doprnt): Don't return value smaller than the buffer
6588 size if the message was truncated. (Bug#8545).
6589
b124fd93
JB
65902011-04-28 Juanma Barranquero <lekktu@gmail.com>
6591
6592 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6593 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6594
e810457d
PE
65952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6596
6597 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6598
ea51cceb
JB
65992011-04-27 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * makefile.w32-in: Update dependencies.
6602
94dcfacf
EZ
66032011-04-27 Eli Zaretskii <eliz@gnu.org>
6604
6605 Improve `doprnt' and its usage. (Bug#8545)
6606 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6607 `format_end'. Remove support for %l as a conversion specifier.
6608 Don't use xrealloc. Improve diagnostics when the %l size modifier
6609 is used. Update the commentary.
6610
6611 * eval.c (verror): Simplify calculation of size_t.
6612
6613 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6614 messages.
6615
f61f41d7
PE
66162011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6617
6618 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6619 change.
6620
96fb4434
PE
66212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6622
6623 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6624 This makes this file independent of the recent pseudovector change.
6625
671875da 66262011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6627
69e9b5a3
PE
6628 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6629
b5f869a7 6630 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6631 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6632 Remove unused local.
c8926152 6633 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6634
841a1577 6635 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6636 GCC 4.6.0 optimizes based on type-based alias analysis.
6637 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6638 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6639 != &v->size, and therefore "v->size = 1; b->size = 2; return
6640 v->size;" must therefore return 1. This assumption is incorrect
6641 for Emacs, since it type-puns struct Lisp_Vector * with many other
6642 types. To fix this problem, this patch adds a new type struct
f904488f 6643 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6644 and pseudovectors, and helps optimizing compilers not get fooled
6645 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6646 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6647 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6648 the size member.
eab3844f
PE
6649 (XSETPVECTYPE): Rewrite in terms of new macro.
6650 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6651 This is a bit clearer, and further avoids the possibility of
6652 undesirable aliasing.
6653 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6654 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6655 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6656 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6657 (ASIZE): Now uses header.size rather than size.
6658 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6659 to avoid the hassle of writing XVECTOR (foo)->header.size.
6660 (struct vectorlike_header): New type.
eab3844f
PE
6661 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6662 object, to help avoid aliasing.
6663 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6664 (SUBRP): Likewise, since Lisp_Subr is a special case.
6665 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6666 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6667 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6668 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6669 changed to be "header.size" and "header.next".
6670 * buffer.h (struct buffer): Likewise.
6671 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6672 * frame.h (struct frame): Likewise.
6673 * process.h (struct Lisp_Process): Likewise.
6674 * termhooks.h (struct terminal): Likewise.
6675 * window.c (struct save_window_data, struct saved_window): Likewise.
6676 * window.h (struct window): Likewise.
6677 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6678 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6679 * buffer.c (init_buffer_once): Likewise.
6680 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6681 special case.
6682 * process.c (Fformat_network_address): Use local var for size,
6683 for brevity.
6684
0df1eac5
PE
6685 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6686
847ab9d1 6687 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6688 * data.c (atof): Remove decl; no longer used or needed.
6689 (digit_to_number): Move to lread.c.
6690 (Fstring_to_number): Use new string_to_number function, to be
6691 consistent with how the Lisp reader treats infinities and NaNs.
6692 Do not assume that floating-point numbers represent EMACS_INT
6693 without losing information; this is not true on most 64-bit hosts.
6694 Avoid double-rounding errors, by insisting on integers when
6695 parsing non-base-10 numbers, as the documentation specifies.
6696 * lisp.h (string_to_number): New decl, replacing ...
6697 (isfloat_string): Remove.
bc0a5c13 6698 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6699 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6700 appears to have been a coding error. Similarly, do not accept
6701 strings like +-1e0 as floating point numbers. Do not report
6702 overflow for integer overflows unless the base is not 10 which
6703 means we have no simple and reliable way to continue.
6704 Break out the floating-point parsing into a new
6705 function string_to_number, so that Fstring_to_number parses
6706 floating point numbers consistently with the Lisp reader.
04f2d78b 6707 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6708 (E_CHAR, EXP_INT): Remove, replacing with ...
6709 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6710 (string_to_number): New function, replacing isfloat_string.
6711 This function checks for valid syntax and produces the resulting
6712 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6713 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6714 so that overflow for non-base-10 numbers is reported only when
6715 there's no portable and simple way to convert to floating point.
452f4150 6716
67769ffc
PE
6717 * textprop.c (set_text_properties_1): Rewrite for clarity,
6718 and to avoid GCC warning about integer overflow.
6719
c20db43f
PE
6720 * intervals.h (struct interval): Use EMACS_INT for members
6721 where EMACS_UINT might cause problems. See
6722 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6723 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6724 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6725 All uses changed.
37aa2f85
PE
6726 (offset_intervals): Tell GCC not to worry about length overflow
6727 when negating a negative length.
c20db43f 6728
2538aa2f
PE
6729 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6730 (overrun_check_free): Likewise.
6731
f2d3008d
PE
6732 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6733 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6734 word size.
6735
ec8df744
PE
6736 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6737 (gnutls_make_error): Rename local to avoid shadowing.
6738 (gnutls_emacs_global_deinit): ifdef out; not used.
6739 (Fgnutls_boot): Use const for pointer to readonly storage.
6740 Comment out unused local. Fix pointer signedness problems.
6741
640ee02d
PE
6742 * lread.c (openp): Don't stuff size_t into an 'int'.
6743 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6744 about possible signed overflow.
6745
6048fb2a
PE
6746 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6747 (GDK_KEY_g): Don't define if already defined.
6748 (xg_prepare_tooltip): Avoid pointer signedness problem.
6749 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6750
fa3c87e1
PE
6751 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6752 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6753
2172544b
PE
6754 * xfns.c (Fx_window_property): Simplify a bit,
6755 to make a bit faster and to avoid GCC 4.6.0 warning.
6756 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6757
9b821a21
PE
6758 * fns.c (internal_equal): Don't assume size_t fits in int.
6759
3c616cfa
PE
6760 * alloc.c (compact_small_strings): Tighten assertion a little.
6761
c2982e87
PE
6762 Replace pEd with more-general pI, and fix some printf arg casts.
6763 * lisp.h (pI): New macro, generalizing old pEd macro to other
6764 conversion specifiers. For example, use "...%"pI"d..." rather
6765 than "...%"pEd"...".
6766 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6767 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6768 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6769 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6770 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6771 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6772 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6773 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6774 64-bit hosts.
6775 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6776 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6777 * print.c (safe_debug_print, print_object): Likewise.
6778 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6779 to int.
6f04d126
PE
6780 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6781 avoiding the 0 flag, which is not portable.
c2982e87
PE
6782 * process.c (Fmake_network_process): Use pI to avoid cast.
6783 * region-cache.c (pp_cache): Likewise.
6784 * xdisp.c (decode_mode_spec): Likewise.
6785 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6786 behavior on 64-bit hosts with printf arg.
6f04d126 6787 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6788 (x_stop_queuing_selection_requests): Likewise.
6789 (x_get_window_property): Don't truncate byte count to an 'int'
6790 when tracing.
0b432f21 6791
5e073ec7
PE
6792 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6793 here, since it parses constructs like leading '-' and spaces,
6794 which are not wanted; and it overflows with large numbers.
6795 Instead, simply match F[0-9]+, which is what is wanted anyway.
6796
36372bf9
PE
6797 * alloc.c: Remove unportable assumptions about struct layout.
6798 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6799 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6800 (allocate_vectorlike, make_pure_vector): Use the new macros,
6801 plus offsetof, to remove unportable assumptions about struct layout.
6802 These assumptions hold on all porting targets that I know of, but
6803 they are not guaranteed, they're easy to remove, and removing them
6804 makes further changes easier.
6805
0b432f21
PE
6806 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6807 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6808 (string_overrun_cookie): Now const. Use initializers that
6809 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6810 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6811 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6812 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6813 multiple of sizeof (EMACS_INT); it need not be, if
6814 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6815 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6816
895009e1
JB
68172011-04-26 Juanma Barranquero <lekktu@gmail.com>
6818
6819 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6820
6a7a1b0b
TZ
68212011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6822
6823 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6824 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6825 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6826
841a1577 68272011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6828
6829 * lisp.h (Qdebug): List symbol.
895009e1 6830 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6831 * keyboard.c (debug-on-event): New variable.
6832 (handle_user_signal): Break into debugger when debug-on-event
6833 matches the current signal symbol.
6834
f2d3ba6f
DN
68352011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6836
6837 * alloc.c (check_sblock, check_string_bytes)
6838 (check_string_free_list): Convert to standard C.
6839
42ce4c63
TZ
68402011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6841
6842 * w32.c (emacs_gnutls_push): Fix typo.
6843
825cd63c
EZ
68442011-04-25 Eli Zaretskii <eliz@gnu.org>
6845
fb11d64d
EZ
6846 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6847 "cast to pointer from integer of different size".
6848
825cd63c
EZ
6849 Improve doprnt and its use in verror. (Bug#8545)
6850 * doprnt.c (doprnt): Document the set of format control sequences
6851 supported by the function. Use SAFE_ALLOCA instead of always
6852 using `alloca'.
6853
6854 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6855 is one byte too soon. Don't use xrealloc; instead xfree and
6856 xmalloc anew.
6857
e061a11b
TZ
68582011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6859
6860 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6861 callbacks stage.
6862
6863 * gnutls.c: Renamed global_initialized to
6864 gnutls_global_initialized. Added internals for the
6865 :verify-hostname-error, :verify-error, and :verify-flags
6866 parameters of `gnutls-boot' and documented those parameters in the
6867 docstring. Start callback support.
9173deec
JB
6868 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6869 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6870 on error. Return error code.
e061a11b
TZ
6871 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6872 (emacs_gnutls_read): Likewise.
6873 (Fgnutls_boot): Return handshake error code.
6874 (emacs_gnutls_handle_error): New function.
6875 (wsaerror_to_errno): Likewise.
6876
6877 * w32.h (emacs_gnutls_pull): Add prototype.
6878 (emacs_gnutls_push): Likewise.
6879
6880 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6881 (emacs_gnutls_push): Likewise.
6882
68832011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6884
6885 * process.c (wait_reading_process_output): Check if GnuTLS
6886 buffered some data internally if no FDs are set for TLS
6887 connections.
6888
6889 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6890 (LIBS): Link to USER_LIBS.
6891 ($(BLD)/gnutls.$(0)): New target.
6892
fa6996bc
EZ
68932011-04-24 Eli Zaretskii <eliz@gnu.org>
6894
eb35682e
EZ
6895 * xdisp.c (handle_single_display_spec): Rename the
6896 display_replaced_before_p argument into display_replaced_p, to
6897 make it consistent with the commentary. Fix typos in the
6898 commentary.
6899
e2ad650c
EZ
6900 * textprop.c (syms_of_textprop): Remove dead code.
6901 (copy_text_properties): Delete obsolete commentary about an
6902 interface that was deleted long ago. Fix typos in the description
6903 of arguments.
6904
1b2de274
EZ
6905 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6906 to changes in oldXMenu/XMenu.h from 2011-04-16.
6907 <menu_help_message, prev_menu_help_message>: Constify.
6908 (IT_menu_make_room): menu->help_text is now `const char **';
6909 adjust.
6910
6911 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6912 to changes in oldXMenu/XMenu.h from 2011-04-16.
6913 (struct XMenu): Declare `help_text' `const char **'.
6914
6915 * xfaces.c <Qunspecified>: Make extern again.
6916
6917 * syntax.c: Include sys/types.h before including regex.h, as
6918 required by Posix.
6919
762b15be
EZ
6920 * doc.c (get_doc_string): Improve the format passed to `error'.
6921
6922 * doprnt.c (doprnt): Improve commentary.
6923
6924 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6925
6926 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6927 them with etags.
6928
f1052e5d
EZ
6929 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6930 changes in globals.h immediately force recompilation.
762b15be
EZ
6931 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6932 $(CURDIR)/s/ms-w32.h.
6933 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6934
fa6996bc
EZ
6935 * character.c (Fchar_direction): Function deleted.
6936 (syms_of_character): Don't defsubr it.
6937 <char-direction-table>: Deleted.
6938
e6c3da20
EZ
69392011-04-23 Eli Zaretskii <eliz@gnu.org>
6940
6941 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6942 * doprnt.c: Include limits.h.
6943 (SIZE_MAX): New macro.
04f2d78b
CB
6944 (doprnt): Return a size_t value. 2nd arg is now size_t.
6945 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6946 Improve overflow protection. Support `l' modifier for integer
6947 conversions. Support %l conversion. Don't assume an EMACS_INT
6948 argument for integer conversions and for %c.
6949
6950 * lisp.h (doprnt): Restore prototype.
6951
6952 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6953 $(SRC)/character.h.
6954
6955 * Makefile.in (base_obj): Add back doprnt.o.
6956
6957 * deps.mk (doprnt.o): Add back prerequisites.
6958 (callint.o): Depend on character.h.
6959
6960 * eval.c (internal_lisp_condition_case): Include the handler
6961 representation in the error message.
6962 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6963 when breaking from the loop.
6964
6965 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6966
6967 * callint.c (Fcall_interactively): When displaying error message
6968 about invalid control letter, pass the character's codepoint, not
6969 a pointer to its multibyte form. Improve display of the character
6970 in octal and display also its hex code.
6971
6972 * character.c (char_string): Use %x to display the (unsigned)
6973 codepoint of an invalid character, to avoid displaying a bogus
6974 negative value.
6975
6976 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6977 `error', not SYMBOL_NAME itself.
6978
6979 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6980 character arguments to `error'.
6981
6982 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6983 to `error' in error message about FINAL_CHAR argument. Make sure
6984 FINAL_CHAR is a character, and use %c when it is passed as
6985 argument to `error'.
6986
4ffd0d6b 69872011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6988
6989 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6990
6991 * w32.c: Include <time.h>.
6992 (sys_localtime): New function.
6993
4ffd0d6b 69942011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6995
6996 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6997
4ffd0d6b 6998 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6999
4ffd0d6b 70002011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7001
4ffd0d6b
GM
7002 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7003 zombies (Bug#8467).
aac0c6e3 7004
04c56954
EZ
70052011-04-19 Eli Zaretskii <eliz@gnu.org>
7006
7007 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7008 gl_state.e_property when gl_state.object is Qt.
7009
7010 * insdel.c (make_gap_larger): Remove limitation of buffer size
7011 to <= INT_MAX.
7012
16a43933
CY
70132011-04-18 Chong Yidong <cyd@stupidchicken.com>
7014
7015 * xdisp.c (lookup_glyphless_char_display)
7016 (produce_glyphless_glyph): Handle cons cell entry in
7017 glyphless-char-display.
7018 (Vglyphless_char_display): Document it.
7019
7020 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7021 glyphless-char-display.
7022
4581706e
CY
70232011-04-17 Chong Yidong <cyd@stupidchicken.com>
7024
7025 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7026
7027 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7028
7029 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7030 definition for no-X builds.
7031
4887c6e2 70322011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7033
fd35b6f9
PE
7034 Static checks with GCC 4.6.0 and non-default toolkits.
7035
5c1ccb01
PE
7036 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7037
006c5daa
PE
7038 * process.c (keyboard_bit_set): Define only if SIGIO.
7039 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7040 (send_process): Repair possible setjmp clobbering.
7041
efc736d3
PE
7042 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7043
4e2fe2e6
PE
7044 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7045
f97334a2
PE
7046 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7047
4e75f29d
PE
7048 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7049 Define only if needed.
7050
90efadd1
PE
7051 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7052 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7053 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7054
3c647824
PE
7055 * dispextern.h (struct redisplay_interface): Rename param
7056 to avoid shadowing.
e264f262 7057 * termhooks.h (struct terminal): Likewise.
761383f4 7058 * xterm.c (xembed_send_message): Likewise.
3c647824 7059
b58c5c4a
PE
7060 * insdel.c (make_gap_smaller): Define only if
7061 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7062
cad59032
PE
7063 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7064 it.
7065
c339dc2e
PE
7066 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7067 so that we aren't warned about unused symbols.
7068
91a3e27b
PE
7069 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7070
399c71d3 7071 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7072
8ffc96f5
PE
7073 * xfns.c (x_real_positions): Mark locals as initialized.
7074
eef9bc79
PE
7075 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7076
098db9dd
PE
7077 * xterm.c: Fix problems found by static analysis with other toolkits.
7078 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7079 (x_dispatch_event): Declare static if USE_GTK, and
7080 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7081 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7082 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7083 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7084 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7085
eb18f6cc
PE
7086 * xmenu.c (menu_help_callback): Pointer type fixes.
7087 Use const pointers when pointing at readonly data. Avoid pointer
7088 signedness clashes.
7089 (FALSE): Remove unused macro.
7090 (update_frame_menubar): Remove unused decl.
7091
1fe72bf8
PE
7092 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7093
60d9e1db
PE
7094 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7095 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7096 (single_menu_item): Rename local to avoid shadowing.
7097
39261c26
PE
7098 * keyboard.c (make_lispy_event): Remove unused local var.
7099
018c5e19
PE
7100 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7101 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7102
63d2b86e
PE
7103 * bitmaps: Change bitmaps from unsigned char back to the X11
7104 compatible char. Avoid the old compiler warnings about
7105 out-of-range initializers by using, for example, '\xab' rather
7106 than 0xab.
7107
aefd87e1
PE
7108 * xgselect.c (xgselect_initialize): Check vs interface
7109 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7110
bf501fb9
PE
7111 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7112
e9829fdf
PE
7113 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7114 to read-only memory.
7115
1086c095
PE
7116 * fns.c (vector): Remove; this old hack is no longer needed.
7117
2baccd04 7118 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7119 Remove unused var.
dde42981 7120 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7121
72391843 7122 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7123
436c16df 7124 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7125 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7126 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7127
92bb796d 7128 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7129 (x_term_init): Remove local to avoid shadowing.
92bb796d 7130
764430a3 7131 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7132
7133 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7134 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7135
d1dfb56c
EZ
71362011-04-16 Eli Zaretskii <eliz@gnu.org>
7137
c4354cb4
EZ
7138 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7139
d1dfb56c
EZ
7140 Fix regex.c, syntax.c and friends for buffers > 2GB.
7141 * syntax.h (struct gl_state_s): Declare character position members
7142 EMACS_INT.
7143
7144 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7145
04f2d78b
CB
7146 * textprop.c (verify_interval_modification, interval_of):
7147 Declare arguments EMACS_INT.
d1dfb56c
EZ
7148
7149 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7150 EMACS_INT.
7151
7152 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7153
7154 * indent.c (Fvertical_motion): Local variable it_start is now
7155 EMACS_INT.
7156
7157 * regex.c (re_match, re_match_2, re_match_2_internal)
7158 (bcmp_translate, regcomp, regexec, print_double_string)
7159 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7160 (re_compile_pattern, re_exec): Declare arguments and local
7161 variables `size_t' and `ssize_t' and return values `regoff_t', as
7162 appropriate.
7163 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7164 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7165 <compile_stack_type>: `size' and `avail' are now `size_t'.
7166
7167 * regex.h <regoff_t>: Use ssize_t, not int.
7168 (re_search, re_search_2, re_match, re_match_2): Arguments that
7169 specify buffer/string position and length are now ssize_t and
7170 size_t. Return type is regoff_t.
7171
613052cd
BK
71722011-04-16 Ben Key <bkey76@gmail.com>
7173
7174 * nsfont.m: Fixed bugs in ns_get_family and
7175 ns_descriptor_to_entity that were caused by using free to
7176 deallocate memory blocks that were allocated by xmalloc (via
7177 xstrdup). This caused Emacs to crash when compiled with
7178 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7179 --enable-checking=xmallocoverrun). xfree is now used to
7180 deallocate these memory blocks.
7181
4170f62f 71822011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7183
71b41406
PE
7184 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7185
9587a89d
PE
7186 emacs_write: Accept and return EMACS_INT for sizes.
7187 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7188 et seq.
7189 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7190 Accept and return EMACS_INT.
7191 (emacs_gnutls_write): Return the number of bytes written on
7192 partial writes.
7193 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7194 (emacs_read, emacs_write): Remove check for negative size, as the
7195 Emacs source code has been audited now.
9587a89d
PE
7196 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7197 (emacs_read, emacs_write): Use it.
273a5f82
PE
7198 * process.c (send_process): Adjust to the new signatures of
7199 emacs_write and emacs_gnutls_write. Do not attempt to store
7200 a byte offset into an 'int'; it might overflow.
9587a89d 7201 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7202
3e047f51
PE
7203 * sound.c: Don't assume sizes fit in 'int'.
7204 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7205 Return EMACS_INT, not int.
3e047f51 7206 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7207 Accept EMACS_INT, not int.
7208 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7209 record read return values.
7210
cc39a9db
BK
72112011-04-15 Ben Key <bkey76@gmail.com>
7212
c9d0ec6d
JB
7213 * keyboard.c (Qundefined): Don't declare static since it is used
7214 in nsfns.m.
7215 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7216 static since they are used in nsfont.m.
cc39a9db 7217
6c60eb9f
SM
72182011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7219
7220 * process.c (Qprocessp): Don't declare static.
7221 * lisp.h (Qprocessp): Declare again.
7222
7990b61a
JB
72232011-04-15 Juanma Barranquero <lekktu@gmail.com>
7224
7225 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7226
5d4cb038
PE
72272011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7228
8bd7b830 7229 Improve C-level modularity by making more things 'static'.
cd64ea1d 7230
e3b27b31
PE
7231 Don't publish debugger-only interfaces to other modules.
7232 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7233 (verify_bytepos, count_markers): Move decls to the only modules
7234 that need them.
7235 * region-cache.h (pp_cache): Likewise.
7236 * window.h (check_all_windows): Likewise.
7237 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7238
5d4cb038
PE
7239 * sysdep.c (croak): Now static, if
7240 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7241 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7242
7243 * alloc.c (refill_memory_reserve): Now static if
7244 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7245 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7246
e87b6180
PE
7247 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7248 Define only if USE_LUCID.
7249
ac64929e
PE
7250 * xrdb.c (x_customization_string, x_rm_string): Now static.
7251
6f37259d
PE
7252 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7253 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7254
1683e3ab
PE
7255 * xdisp.c (draw_row_with_mouse_face): Now static.
7256 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7257
de9c2632
PE
7258 * window.h (check_all_windows): Mark externally visible.
7259
2b96acb7
PE
7260 * window.c (window_deletion_count): Now static.
7261
7262 * undo.c: Make symbols static if they're not exported.
7263 (last_undo_buffer, last_boundary_position, pending_boundary):
7264 Now static.
7265
50436f33
PE
7266 * textprop.c (interval_insert_behind_hooks): Now static.
7267 (interval_insert_in_front_hooks): Likewise.
7268
64520e5c
PE
7269 * term.c: Make symbols static if they're not exported.
7270 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7271 (max_frame_lines, tty_set_terminal_modes):
7272 (tty_reset_terminal_modes, tty_turn_off_highlight):
7273 (get_tty_terminal): Now static.
7274 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7275 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7276 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7277 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7278 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7279
1fa53021
PE
7280 * sysdep.c: Make symbols static if they're not exported.
7281 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7282 Now static.
7283 (sigprocmask_set, full_mask): Remove; unused.
7284 (wait_debugging): Mark as visible.
7285 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7286 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7287
d4b43b22
PE
7288 * syntax.c (syntax_temp): Define only if !__GNUC__.
7289
b7c513d0
PE
7290 * sound.c (current_sound_device, current_sound): Now static.
7291
989b29ad
PE
7292 * search.c (searchbufs, searchbuf_head): Now static.
7293
13a55a78
PE
7294 * scroll.c (scroll_cost): Remove; unused.
7295 * dispextern.h (scroll_cost): Remove decl.
7296
de68a1fc
PE
7297 * region-cache.h (pp_cache): Mark as externally visible.
7298
40ccffa6
PE
7299 * process.c: Make symbols static if they're not exported.
7300 (process_tick, update_tick, create_process, chan_process):
7301 (Vprocess_alist, proc_buffered_char, datagram_access):
7302 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7303 (deactivate_process): Mark defn as static, as well as decl.
7304 * lisp.h (create_process): Remove decl.
7305 * process.h (chan_process, Vprocess_alist): Remove decls.
7306
ad64fc97
PE
7307 * print.c: Make symbols static if they're not exported.
7308 (print_depth, new_backquote_output, being_printed, print_buffer):
7309 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7310 (print_interval, print_number_index, initial_stderr_stream):
7311 Now static.
7312 * lisp.h (Fprinc): Remove decl.
7313 (debug_output_compilation_hack): Mark as externally visible.
7314
adddb265
PE
7315 * sysdep.c (croak): Move decl from here to syssignal.h.
7316 * syssignal.h (croak): Put it here, so the API can be checked when
7317 'croak' is called from dissociate_if_controlling_tty.
7318
1717ede2
PE
7319 * minibuf.c: Make symbols static if they're not exported.
7320 (minibuf_save_list, choose_minibuf_frame): Now static.
7321 * lisp.h (choose_minibuf_frame): Remove decl.
7322
fa5fb2bc
PE
7323 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7324
1e3890d1
PE
7325 * lread.c: Make symbols static if they're not exported.
7326 (read_objects, initial_obarray, oblookup_last_bucket_number):
7327 Now static.
7328 (make_symbol): Remove; unused.
7329 * lisp.h (initial_obarray, make_symbol): Remove decls.
7330
8a1414fa
PE
7331 * keyboard.c: Make symbols static if they're not exported.
7332 (single_kboard, recent_keys_index, total_keys, recent_keys):
7333 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7334 (this_single_command_key_start, echoing, last_auto_save):
7335 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7336 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7337 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7338 (Vlispy_mouse_stem, double_click_count):
7339 Now static.
7340 (force_auto_save_soon): Define only if SIGDANGER.
7341 (ignore_mouse_drag_p): Now static if
7342 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7343 (print_help): Remove; unused.
7344 (stop_character, last_timer_event): Mark as externally visible.
7345 * keyboard.h (ignore_mouse_drag_p): Declare only if
7346 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7347 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7348 * lisp.h (echoing): Remove decl.
7349 (force_auto_save_soon): Declare only if SIGDANGER.
7350 * xdisp.c (redisplay_window): Simplify code, to make it more
7351 obvious that ignore_mouse_drag_p is not accessed if !defined
7352 USE_GTK && !defined HAVE_NS.
7353
93ea6e8f
PE
7354 * intervals.c: Make symbols static if they're not exported.
7355 (merge_properties_sticky, merge_interval_right, delete_interval):
7356 Now static.
7357 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7358
77382fcc
PE
7359 * insdel.c: Make symbols static if they're not exported.
7360 However, leave prepare_to_modify_buffer alone. It's never
7361 called from outside this function, but that appears to be a bug.
7362 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7363 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7364 (adjust_after_replace_noundo): Remove; unused.
7365 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7366 (signal_before_change): Remove decls.
77382fcc 7367
9306c32e
PE
7368 * indent.c (val_compute_motion, val_vmotion): Now static.
7369
cd44d2eb
PE
7370 * image.c: Make symbols static if they're not exported.
7371 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7372 if USE_GTK.
7373 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7374 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7375
ad9a7a06
PE
7376 * fringe.c (standard_bitmaps): Now static.
7377 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7378
81626931
PE
7379 * frame.c: Make symbols static if they're not exported.
7380 (x_report_frame_params, make_terminal_frame): Now static.
7381 (get_frame_param): Now static, unless HAVE_NS.
7382 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7383 (x_get_resource_string): Remove; not used.
7384 * frame.h (make_terminal_frame, x_report_frame_params):
7385 (x_get_resource_string); Remove decls.
7386 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7387 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7388
239f9db9
PE
7389 * font.c, fontset.c: Make symbols static if they're not exported.
7390 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7391 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7392 * font.c (font_close_object): Now static.
7393 * font.h (font_close_object): Remove.
7394 * fontset.c (FONTSET_OBJLIST): Remove.
7395 (free_realized_fontset) #if-0 the body, which does nothing.
7396 (face_suitable_for_char_p): #if-0, as it's never called.
7397 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7398 * xfaces.c (face_at_string_position):
7399 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7400 since 0 is always ASCII.
7401
dfcf3579
PE
7402 * fns.c (weak_hash_tables): Now static.
7403
5045092b
PE
7404 * fileio.c: Make symbols static if they're not exported.
7405 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7406 (Vwrite_region_annotation_buffers): Now static.
7407
57a96f5c
PE
7408 * eval.c: Make symbols static if they're not exported.
7409 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7410 * lisp.h (backtrace_list): Remove decl.
7411
35f08c38
PE
7412 * emacs.c: Make symbols static if they're not exported.
7413 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7414 (fatal_error_code, fatal_error_signal_hook, standard_args):
7415 Now static.
7416 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7417 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7418 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7419 * lisp.h (fatal_error_signal_hook): Remove decl.
7420 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7421
f44bd759
PE
7422 * editfns.c: Move a (normally-unused) function to its only use.
7423 * editfns.c, lisp.h (get_operating_system_release): Remove.
7424 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7425 worth the hassle of breaking this out.
7426
b532497d
PE
7427 * xterm.c: Make symbols static if they're not exported.
7428 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7429 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7430 (x_destroy_window, x_delete_display):
7431 Now static.
7432 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7433 (x_mouse_leave): Remove; unused.
7434 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7435 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7436 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7437 Remove decls.
7438 (x_mouse_leave): Declare only if WINDOWSNT.
7439 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7440 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7441 USE_X_TOOLKIT.
7442
1675728f
PE
7443 * ftxfont.c: Make symbols static if they're not exported.
7444 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7445 HAVE_FREETYPE.
7446 * font.h (ftxfont_driver): Likewise.
7447
e4cebfca
PE
7448 * xfns.c: Make symbols static if they're not exported.
7449 (x_last_font_name, x_display_info_for_name):
7450 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7451 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7452 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7453 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7454 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7455 (last_show_tip_args): Now static.
7456 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7457 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7458 (x_screen_planes): Remove; unused.
7459 * dispextern.h (x_screen_planes): Remove decl.
7460
5bf46f05
PE
7461 * dispnew.c: Make symbols static if they're not exported.
7462 * dispextern.h (redraw_garbaged_frames, scrolling):
7463 (increment_row_positions): Remove.
7464 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7465 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7466 Now static.
7467 (redraw_garbaged_frames): Remove; unused.
7468
435f4c28
PE
7469 * xfaces.c: Make symbols static if they're not exported.
7470 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7471 Remove decls.
7472 * xterm.h (defined_color): Remove decls.
7473 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7474 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7475 (menu_face_changed_default, defined_color, free_realized_face):
7476 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7477 (ascii_face_of_lisp_face): Remove; unused.
7478
8524aef3
PE
7479 * xdisp.c: Make symbols static if they're not exported.
7480 * dispextern.h (scratch_glyph_row, window_box_edges):
7481 (glyph_to_pixel_coords, set_cursor_from_row):
7482 (get_next_display_element, set_iterator_to_next):
7483 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7484 (show_mouse_face): Remove decls
7485 * frame.h (message_buf_print): Likewise.
7486 * lisp.h (pop_message, set_message, check_point_in_composition):
7487 Likewise.
7488 * xterm.h (set_vertical_scroll_bar): Likewise.
7489 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7490 (message_buf_print, scratch_glyph_row, displayed_buffer):
7491 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7492 (get_next_display_element, show_mouse_face, window_box_edges):
7493 (frame_to_window_pixel_xy, check_point_in_composition):
7494 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7495 (glyph_to_pixel_coords): Remove; unused.
7496
16390cd2
PE
7497 * dired.c (file_name_completion): Now static.
7498
7499 * dbusbind.c (xd_in_read_queued_messages): Now static.
7500
a25f4dfa
PE
7501 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7502 * data.c (circular_list_error): Remove.
7503
14a9c8df
PE
7504 * commands.h (last_point_position, last_point_position_buffer):
7505 (last_point_position_window): Remove decls.
7506 * keyboard.c: Make these variables static.
7507
04f2d78b
CB
7508 * coding.h (coding, code_convert_region, encode_coding_gap):
7509 Remove decls.
74ab6df5
PE
7510 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7511 (iso_code_class, detect_coding, code_convert_region): Now static.
7512 (encode_coding_gap): Remove; unused.
7513
38dfbee1
PE
7514 * chartab.c (chartab_chars, chartab_bits): Now static.
7515
a2cb4e63
PE
7516 * charset.h (charset_iso_8859_1): Remove decl.
7517 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7518 Now static.
7519
127198fd
PE
7520 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7521 * ccl.c (Vccl_program_table): Now static.
7522 (check_ccl_update): Remove; unused.
7523
d85b608f
PE
7524 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7525 * category.h: ... from here.
7526 * category.c (check_category_table, set_category_set): Now static.
7527
31cd66f3
PE
7528 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7529 * lisp.h: Remove these decls.
7530
c358e587
PE
7531 * buffer.c (buffer_count): Remove unused var.
7532
e78aecca
PE
7533 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7534 so that it's not optimized away.
7535 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7536 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7537 exported only to the debugger.
7538
e192d7d3 7539 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7540 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7541
92470028
PE
7542 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7543 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7544 was inaccessible from Lisp.
7545 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7546 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7547
244ed907
PE
7548 alloc.c: Import and export fewer symbols, and remove unused items.
7549 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7550 is defined.
7551 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7552 it's not optimized away by whole-program optimization.
7553 (message_enable_multibyte, free_misc): Remove.
7554 (catchlist, handlerlist, mark_backtrace):
7555 Declare only if BYTE_MARK_STACK.
7556 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7557 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7558 (message_enable_multibyte): Remove decl.
7559 (free_misc, interval_free_list, float_block, float_block_index):
7560 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7561 (cons_free_list, last_marked_index):
7562 Now static.
7563 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7564 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7565 (mark_backtrace): Define only if BYTE_MARK_STACK.
7566 * xdisp.c (message_enable_multibyte): Now static.
7567
61c2b50e 7568 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7569 This makes it easier for human readers (and static analyzers)
7570 to see whether these variables are used from other modules.
7571 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7572 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7573 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7574 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7575 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7576 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7577 * xmenu.c, xselect.c:
7578 Declare Q* vars static if they are not used in other modules.
7579 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7580 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7581 Remove decls of unexported vars.
7582 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7583
95c82688
PE
7584 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7585
16a97296
PE
7586 Make Emacs functions such as Fatom 'static' by default.
7587 This makes it easier for human readers (and static analyzers)
7588 to see whether these functions can be called from other modules.
7589 DEFUN now defines a static function. To make the function external
7590 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7591 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7592 (Finit_image_library):
16a97296
PE
7593 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7594 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7595 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7596 Remove decls, since these functions are now static.
7597 (Funintern, Fget_internal_run_time): New decls, since these functions
7598 were already external.
95c82688 7599
16a97296
PE
7600 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7601 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7602 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7603 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7604 * keyboard.c, keymap.c, lread.c:
7605 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7606 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7607 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7608 Mark functions with DEFUE instead of DEFUN,
7609 if they are used in other modules.
7610 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7611 decls for now-static functions.
7612 * buffer.h (Fdelete_overlay): Remove decl.
7613 * callproc.c (Fgetenv_internal): Mark as internal.
7614 * composite.c (Fremove_list_of_text_properties): Remove decl.
7615 (Fcomposition_get_gstring): New forward static decl.
7616 * composite.h (Fcomposite_get_gstring): Remove decl.
7617 * dired.c (Ffile_attributes): New forward static decl.
7618 * doc.c (Fdocumntation_property): New forward static decl.
7619 * eval.c (Ffetch_bytecode): New forward static decl.
7620 (Funintern): Remove extern decl; now in .h file where it belongs.
7621 * fileio.c (Fmake_symbolic_link): New forward static decl.
7622 * image.c (Finit_image_library): New forward static decl.
7623 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7624 * intervals.h (Fprevious_property_change):
7625 (Fremove_list_of_text_properties): Remove decls.
7626 * keyboard.c (Fthis_command_keys): Remove decl.
7627 (Fcommand_execute): New forward static decl.
7628 * keymap.c (Flookup_key): New forward static decl.
7629 (Fcopy_keymap): Now static.
7630 * keymap.h (Flookup_key): Remove decl.
7631 * process.c (Fget_process): New forward static decl.
7632 (Fprocess_datagram_address): Mark as internal.
7633 * syntax.c (Fsyntax_table_p): New forward static decl.
7634 (skip_chars): Remove duplicate decl.
7635 * textprop.c (Fprevious_property_change): New forward static decl.
7636 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7637 Now internal.
7638 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7639 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7640
785bbd42
PE
7641 * editfns.c (Fformat): Remove unreachable code.
7642
8b913b57
AS
76432011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7644
7645 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7646 change. (Bug#8496)
7647
a6744a35
EZ
76482011-04-13 Eli Zaretskii <eliz@gnu.org>
7649
7650 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7651 when at ZV. (Bug#8487)
7652
e7974947
AS
76532011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7654
baad03f0
AS
7655 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7656 (Bug#8437)
7657 * keyboard.c (parse_tool_bar_item): Likewise.
7658 * sound.c (sound_cleanup, alsa_close): Likewise.
7659 * termcap.c (tgetent): Likewise.
7660 * xfns.c (x_default_font_parameter): Likewise.
7661 * xsettings.c (read_and_apply_settings): Likewise.
7662
e7974947
AS
7663 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7664 (overrun_check_free): Protoize.
7665
28272684
PE
76662011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7667
7668 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7669 since callers should never pass a negative size.
7670 Change the signature to match that of plain 'read' and 'write'; see
7671 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7672 * lisp.h: Update prototypes of emacs_write and emacs_read.
7673
11997c76
EZ
76742011-04-11 Eli Zaretskii <eliz@gnu.org>
7675
7676 * xdisp.c (redisplay_window): Don't try to determine the character
7677 position of the scroll margin if the window start point w->startp
e896f03c 7678 is outside the buffer's accessible region. (Bug#8468)
11997c76 7679
8a2cbd72
EZ
76802011-04-10 Eli Zaretskii <eliz@gnu.org>
7681
7682 Fix write-region and its subroutines for buffers > 2GB.
7683 * fileio.c (a_write, e_write): Modify declaration of arguments and
7684 local variables to support buffers larger than 2GB.
7685 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7686
7687 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7688 argument, local variables, and return value.
7689
7690 * lisp.h: Update prototypes of emacs_write and emacs_read.
7691
7692 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7693
4073e537 76942011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7695
1ebfdcb6
PE
7696 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7697
b2ded58d
PE
7698 Fix more problems found by GCC 4.6.0's static checks.
7699
7d66342c
PE
7700 * xdisp.c (vmessage): Use a better test for character truncation.
7701
bbf47d44
PE
7702 * charset.c (load_charset_map): <, not <=, for optimization,
7703 and to avoid potential problems with integer overflow.
9248994d 7704 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7705 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7706 * editfns.c (Fformat): Likewise.
1e69125e 7707 * syntax.c (skip_chars): Likewise.
3befa583 7708
e3019616
PE
7709 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7710 This also lets GCC 4.6.0 generate slightly better loop code.
7711
becfa255
PE
7712 * callint.c (Fcall_interactively): <, not <=, for optimization.
7713 (Fcall_interactively): Count the number of arguments produced,
7714 not the number of arguments given. This is simpler and lets GCC
7715 4.6.0 generate slightly better code.
7716
dae0cd48
PE
7717 * ftfont.c: Distingish more carefully between FcChar8 and char.
7718 The previous code passed unsigned char * to a functions like
7719 strlen and xstrcasecmp that expect char *, which does not
7720 conform to the C standard.
7721 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7722 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7723 char * when the C standard requires it.
7724
76032d70
PE
7725 * keyboard.c (read_char): Remove unused var.
7726
eb3f1cc8
PE
7727 * eval.c: Port to Windows vsnprintf (Bug#8435).
7728 Include <limits.h>.
7729 (SIZE_MAX): Define if the headers do not.
7730 (verror): Do not give up if vsnprintf returns a negative count.
7731 Instead, grow the buffer. This ports to Windows vsnprintf, which
7732 does not conform to C99. Problem reported by Eli Zaretskii.
7733 Also, simplify the allocation scheme, by avoiding the need for
7734 calling realloc, and removing the ALLOCATED variable.
7735
70476b54
PE
7736 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7737
12020a9e
PE
7738 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7739 But keep the doprint source code for now, as we might revamp it
7740 and use it again (Bug#8435).
ea6c7ae6
PE
7741 * lisp.h (doprnt): Remove.
7742 * Makefile.in (base_obj): Remove doprnt.o.
7743 * deps.mk (doprnt.o): Remove.
7744
5fdb398c
PE
7745 error: Print 32- and 64-bit integers portably (Bug#8435).
7746 Without this change, on typical 64-bit hosts error ("...%d...", N)
7747 was used to print both 32- and 64-bit integers N, which relied on
7748 undefined behavior.
61bdb816 7749 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7750 * lisp.h (error, verror): Mark as printf-like functions.
7751 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7752 Report overflow in size calculations when allocating printf buffer.
7753 Do not truncate output string at its first null byte.
7754 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7755 Truncate the output at a character boundary, since vsnprintf does not
7756 do that.
7757 * charset.c (check_iso_charset_parameter): Convert internal
7758 character to string before calling 'error', since %c now has the
7759 printf meaning.
7760 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7761 overflow when computing char to be passed to 'error'. Do not
7762 pass Lisp_Object to 'error'; pass the integer instead.
7763 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7764 formatted with plain %d.
7765
b189fa66
PE
7766 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7767
bff87ef0
PE
7768 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7769
7e2cac20
PE
7770 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7771
ce4d90b5
PE
7772 * xterm.c (x_catch_errors): Remove duplicate declaration.
7773
266c9547
PE
7774 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7775
79c49ad2
PE
7776 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7777
368f4090
JM
77782011-04-10 Jim Meyering <meyering@redhat.com>
7779
7780 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7781 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7782 return ssize_t not "int", and use size_t as the buffer length.
7783 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7784 * gnutls.h: Update declarations.
7785 * process.c (read_process_output): Use ssize_t, to match.
7786 (send_process): Likewise.
7787
a32d4040
CY
77882011-04-09 Chong Yidong <cyd@stupidchicken.com>
7789
7790 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7791
8546720e 77922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7793
04f2d78b
CB
7794 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7795 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7796
8546720e
GM
7797 * xterm.c (handle_one_xevent):
7798 * xmenu.c (create_and_show_popup_menu):
7799 * xselect.c (x_decline_selection_request)
7800 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7801
0a2f5c1a 78022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7803
7804 Fix some uses of `int' instead of EMACS_INT.
7805 * search.c (string_match_1, fast_string_match)
7806 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7807 (scan_buffer, find_next_newline_no_quit)
7808 (find_before_next_newline, search_command, Freplace_match)
7809 (Fmatch_data): Make some `int' variables be EMACS_INT.
7810
7811 * xdisp.c (display_count_lines): 3rd argument and return value now
7812 EMACS_INT. All callers changed.
7813 (pint2hrstr): Last argument is now EMACS_INT.
7814
7815 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7816 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7817 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7818 (decode_coding_utf_16, decode_coding_emacs_mule)
7819 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7820 (decode_coding_ccl, decode_coding_charset)
7821 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7822 (decode_coding_iso_2022, decode_coding_emacs_mule)
7823 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7824 <char_offset, last_offset>: Declare EMACS_INT.
7825 (encode_coding_utf_8, encode_coding_utf_16)
7826 (encode_coding_emacs_mule, encode_invocation_designation)
7827 (encode_designation_at_bol, encode_coding_iso_2022)
7828 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7829 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7830 Declare EMACS_INT.
7831 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7832 (encode_invocation_designation): Last argument P_NCHARS is now
7833 EMACS_INT.
7834 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7835 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7836
7837 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7838 All users changed.
7839
7840 * ccl.c (Fccl_execute_on_string): Declare some variables
7841 EMACS_INT.
7842
8546720e 78432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7844
7845 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7846
4e19a977
CS
78472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7848
7849 * process.c (Fformat_network_address): Doc fix.
7850
87302331
R
78512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7852
ee7683eb 7853 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7854
cbb59342
CY
78552011-04-08 Chong Yidong <cyd@stupidchicken.com>
7856
7857 * keyboard.c (read_char): Call Lisp function help-form-show,
7858 instead of using internal_with_output_to_temp_buffer.
7859 (Qhelp_form_show): New var.
e0d38eeb 7860 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7861
7862 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7863
7864 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7865
e67a13ab
CY
78662011-04-06 Chong Yidong <cyd@stupidchicken.com>
7867
04f2d78b
CB
7868 * process.c (Flist_processes): Remove to Lisp.
7869 (list_processes_1): Delete.
e67a13ab 7870
973f782d
EZ
78712011-04-06 Eli Zaretskii <eliz@gnu.org>
7872
7c106b1e
EZ
7873 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7874
973f782d
EZ
7875 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7876
41cf7d1a 78772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7878
ca23cc88
PE
7879 Fix more problems found by GCC 4.6.0's static checks.
7880
f390e2d5
PE
7881 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7882
42eea0d0
PE
7883 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7884
b69769da 7885 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7886
f9541e84
PE
7887 * xdisp.c (vmessage): Mark as a printf-like function.
7888
13841b55
PE
7889 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7890
c136c10f
PE
7891 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7892
5e2d4a30
PE
7893 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7894 printf-like functions.
7895 (tiff_load): Add casts to remove these marks before passing them
7896 to system-supplied API.
7897
583f48b9
PE
7898 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7899
b25d760e
PE
7900 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7901 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7902 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7903 directly, rather than having caller test rule sign. This avoids
7904 some unnecessary tests.
7905 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7906 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7907 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7908
bc7b6697 7909 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7910 (xfont_open): Avoid unnecessary tests.
bc7b6697 7911
27ccc379
PE
7912 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7913
dcd5c89a
PE
7914 * composite.h, composite.c (composition_gstring_put_cache):
7915 Use EMACS_INT, not int, for length.
7916
b13a45c6
PE
7917 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7918 breaking out part of COMPOSITION_DECODE_RULE.
7919 (COMPOSITION_DECODE_RULE): Use it.
7920 * composite.c (get_composition_id): Remove unused local vars,
7921 by using the new macro.
7922
1e792e4d
PE
7923 * textprop.c (set_text_properties_1): Change while to do-while,
7924 since the condition is always true at first.
7925
dc6c6455 7926 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7927 (interval_deletion_adjustment): Return unsigned value.
7928 All uses changed.
dc6c6455 7929
aba7731a
PE
7930 * process.c (list_processes_1, create_pty, read_process_output):
7931 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7932 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7933 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7934 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7935 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7936
fdfc4bf3
PE
7937 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7938
fca8fe46 7939 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7940 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7941
06a0259a 7942 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7943 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7944 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7945
e7b9e80f
PE
7946 * print.c (print_error_message): Avoid int overflow.
7947
56201685
PE
7948 * font.c (font_list_entities): Redo for clarity,
7949 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7950
78834453 7951 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7952 (font_score): Avoid potential overflow in diff calculation.
78834453 7953
0bc0b309 7954 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7955 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7956
e610eaca
PE
7957 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7958
b895abce
PE
7959 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7960 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7961 can always succeed if overflow has undefined behavior.
7962
1f1d9321 7963 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7964 (wordify): Omit three unnecessary tests.
1f1d9321 7965
c59478bc
PE
7966 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7967 All callers changed. This avoids the need for an unused var.
7968
79b73827
PE
7969 * casefiddle.c (casify_region): Remove var that is set but not used.
7970
a4db5dfe
PE
7971 * dired.c (file_name_completion): Remove var that is set but not used.
7972
43aae36e
PE
7973 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7974
2a47c44d 7975 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7976 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7977
a37c69bf
PE
7978 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7979 Check for integer overflow on size calculations.
7980
328ab8e7
PE
7981 * buffer.c (Fprevious_overlay_change): Remove var that is set
7982 but not used.
7983
e5a2a5cb
PE
7984 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7985 Remove vars that are set but not used.
8d84a6eb 7986 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7987 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7988
a60e5f68
PE
7989 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7990
f661cb61 7991 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7992 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7993
f0397f5a
PE
7994 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7995 that are set but not used.
7996
8664db06 7997 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7998 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7999
6abdaa4a
PE
8000 * xselect.c (x_get_local_selection, x_handle_property_notify):
8001 Remove vars that are set but not used.
8002
0ce7538d 8003 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8004 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8005
9ae848fc
PE
8006 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8007 Remove var that is set but not used.
0b918413
PE
8008 (scroll_bar_windows_size): Now size_t, not int.
8009 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8010 Check for overflow.
9ae848fc 8011
a5a62657
PE
8012 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8013 (map_tty_color) [!defined MSDOS]: Likewise.
8014
5c5cdd39
PE
8015 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8016
66ebf983
PE
8017 * coding.c: Remove vars that are set but not used.
8018 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8019 All callers changed.
8020 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8021 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8022 (decode_coding_charset): Remove vars that are set but not used.
8023
1be4d761
PE
8024 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8025 that is set but not used.
8026
47553fa8
PE
8027 * print.c (print_object): Remove var that is set but not used.
8028
1f7196bf 8029 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8030 The gnulib version avoids calling malloc in the usual case,
8031 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8032 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8033 * filelock.c (current_lock_owner): Likewise.
8034 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8035 * sysdep.c: Include allocator.h, careadlinkat.h.
8036 (emacs_no_realloc_allocator): New static constant.
8037 (emacs_readlink): New function.
fdb61804
PE
8038 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8039 ../lib/careadlinkat.h.
d1fdcab7 8040
f84c17c7
SM
80412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8042
8043 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8044 first non-nil return value).
8045
ef3862ad
JD
80462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8047
8048 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8049 if not defined (Bug#8403).
8050
376a7006
JB
80512011-04-02 Juanma Barranquero <lekktu@gmail.com>
8052
8053 * xdisp.c (display_count_lines): Remove parameter `start',
8054 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8055 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8056 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8057 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8058 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8059 and thereabouts. All callers changed.
8060 (get_per_char_metric): Remove parameter `f', unused since
8061 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8062
6ca3801d
JM
80632011-04-02 Jim Meyering <meyering@redhat.com>
8064
8065 do not dereference NULL upon failed strdup
8066 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8067 (ns_get_family): Likewise.
8068
d8e2b5ba
JB
80692011-04-02 Juanma Barranquero <lekktu@gmail.com>
8070
8071 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8072
8c74fcbd
JD
80732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8074
8075 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8076 later (Bug#8403).
8077
7200d79c
SM
80782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8079
03408648 8080 Add lexical binding.
7200d79c 8081
03408648
SM
8082 * window.c (Ftemp_output_buffer_show): New fun.
8083 (Fsave_window_excursion):
8084 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8085
8086 * lread.c (lisp_file_lexically_bound_p): New function.
8087 (Fload): Bind Qlexical_binding.
8088 (readevalloop): Remove `evalfun' arg.
8089 Bind Qinternal_interpreter_environment.
8090 (Feval_buffer): Bind Qlexical_binding.
8091 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8092 Mark as dynamic.
8093 (syms_of_lread): Declare `lexical-binding'.
8094
8095 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8096
8097 * keyboard.c (eval_dyn): New fun.
8098 (menu_item_eval_property): Use it.
ca105506
SM
8099
8100 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8101
03408648
SM
8102 * fns.c (concat, mapcar1): Accept byte-code-functions.
8103
8104 * eval.c (Fsetq): Handle lexical vars.
8105 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8106 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8107 (FletX, Flet): Obey lexical binding.
8108 (Fcommandp): Handle closures.
8109 (Feval): New `lexical' arg.
8110 (eval_sub): New function extracted from Feval. Use it almost
8111 everywhere where Feval was used. Look up vars in lexical env.
8112 Handle closures.
8113 (Ffunctionp): Move from subr.el.
8114 (Ffuncall): Handle closures.
8115 (apply_lambda): Remove `eval_flags'.
8116 (funcall_lambda): Handle closures and new byte-code-functions.
8117 (Fspecial_variable_p): New function.
8118 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8119 but without exporting it to Lisp.
23aba0ea 8120
23aba0ea 8121 * doc.c (Fdocumentation, store_function_docstring):
03408648 8122 * data.c (Finteractive_form): Handle closures.
23aba0ea 8123
03408648
SM
8124 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8125 interactive spec.
ba83908c 8126
04f2d78b
CB
8127 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8128 New byte-codes.
03408648
SM
8129 (exec_byte_code): New function extracted from Fbyte_code to handle new
8130 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8131
03408648 8132 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8133
03408648 8134 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8135
e2abce01
JB
81362011-03-31 Juanma Barranquero <lekktu@gmail.com>
8137
8138 * xdisp.c (redisplay_internal): Fix prototype.
8139
63696a73 81402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8141
63696a73 8142 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8143 (try_scrolling): Use it when setting scroll_limit.
8144 Limit scrolling to 100 screen lines.
63696a73
EZ
8145 (redisplay_window): Even when falling back on "recentering",
8146 position point in the window according to scroll-conservatively,
8147 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8148
8149 (try_scrolling): When point is above the window, allow searching
8150 as far as scroll_max, or one screenful, to compute vertical
8151 distance from PT to the scroll margin position. This prevents
8152 try_scrolling from unnecessarily failing when
8153 scroll-conservatively is set to a value slightly larger than the
8154 window height. Clean up the case of PT below the margin at bottom
8155 of window: scroll_max can no longer be INT_MAX. When aggressive
8156 scrolling is in use, don't let point enter the opposite scroll
8157 margin as result of the scroll.
8158 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8159 threshold of 100 lines for never-recentering scrolling.
8160
e4cc2dfc
JB
81612011-03-31 Juanma Barranquero <lekktu@gmail.com>
8162
8163 * dispextern.h (move_it_by_lines):
8164 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8165 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8166 (message_log_check_duplicate): Remove parameters `prev_bol' and
8167 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8168 (redisplay_internal): Remove parameter `preserve_echo_area',
8169 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8170
8171 * indent.c (Fvertical_motion):
8172 * window.c (window_scroll_pixel_based, Frecenter):
8173 Don't pass `need_y_p' to `move_it_by_lines'.
8174
1c470562
SM
81752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8176
44f230aa
SM
8177 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8178 steal a few bits to be more compact.
8179 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8180 Remove unneeded casts.
8181
1c470562
SM
8182 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8183
888adce9
ZK
81842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8185
8186 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8187 binding" message (bug#7967).
8188
f838ed7b
PE
81892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8190
77861b95
PE
8191 Fix more problems found by GCC 4.6.0's static checks.
8192
de6dbc14
PE
8193 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8194 Remove unused local var.
8195
f838ed7b
PE
8196 * editfns.c (Fmessage_box): Remove unused local var.
8197
792c7b2b
PE
8198 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8199 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8200 Omit unused local vars.
c499e557 8201 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8202 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8203 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8204 Omit unused local var.
8205
ba0165e1
PE
8206 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8207 Don't assume string length fits in int.
32ad8845 8208 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8209 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8210
3c59b4c9
PE
8211 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8212 instead of alloca (Bug#8344).
8213
a3eed478 8214 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8215 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8216
eb4d412d
PE
8217 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8218
1658b401
PE
8219 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8220 concerns.
8221
8222 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8223
8224 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8225
9a2c6e05
PE
8226 * keyboard.c (syms_of_keyboard): Use the same style as later
8227 in this function when indexing through an array. This also
8228 works around GCC bug 48267.
8229
03d0a109
PE
8230 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8231
44f730c8
PE
8232 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8233
fe75f926
PE
8234 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8235 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8236
ffa8c828
PE
8237 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8238 This avoids undefined behavior on integer overflow, and is a bit
8239 more convenient anyway since it is compared to a size_t variable.
8240
c5101a77
PE
8241 Variadic C functions now count arguments with size_t, not int.
8242 This avoids an unnecessary limitation on 64-bit machines, which
8243 caused (substring ...) to crash on large vectors (Bug#8344).
8244 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8245 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8246 All variadic functions and their callers changed accordingly.
c5101a77
PE
8247 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8248 * data.c (arith_driver, float_arith_driver): Likewise.
8249 * editfns.c (general_insert_function): Likewise.
8250 * eval.c (struct backtrace.nargs, interactive_p)
8251 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8252 (funcall_lambda, mark_backtrace): Likewise.
8253 * fns.c (concat): Likewise.
8254 * frame.c (x_set_frame_parameters): Likewise.
8255 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8256 0 if not found, not -1. All callers changed.
8257
dd3f25f7
PE
8258 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8259 (stack_copy_size): Now size_t, not int.
8260 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8261
461c2ab9
JB
82622011-03-28 Juanma Barranquero <lekktu@gmail.com>
8263
8264 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8265 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8266 All callers changed.
8267
8268 * lisp.h (multibyte_char_to_unibyte):
8269 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8270 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8271 * character.h (CHAR_TO_BYTE8):
8272 * cmds.c (internal_self_insert):
8273 * editfns.c (general_insert_function):
8274 * keymap.c (push_key_description):
8275 * search.c (Freplace_match):
8276 * xdisp.c (message_dolog, set_message_1): All callers changed.
8277
f6d62986
SM
82782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8279
8280 * keyboard.c (safe_run_hook_funcall): New function.
8281 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8282 don't set the hook to nil, but remove the offending function instead.
8283 (Qcommand_hook_internal): Remove, unused.
8284 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8285 Vcommand_hook_internal.
8286
8287 * eval.c (enum run_hooks_condition): Remove.
8288 (funcall_nil, funcall_not): New functions.
8289 (run_hook_with_args): Call each function through a `funcall' argument.
8290 Remove `cond' argument, now redundant.
8291 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8292 (Frun_hook_with_args_until_failure): Adjust accordingly.
8293 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8294
1db5b1ad
JB
82952011-03-28 Juanma Barranquero <lekktu@gmail.com>
8296
8297 * dispextern.h (string_buffer_position): Remove declaration.
8298
8299 * print.c (strout): Remove parameter `multibyte', unused since
8300 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8301
8302 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8303 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8304 All callers changed.
8305
8306 * w32.c (_wsa_errlist): Use braces for struct initializers.
8307
8308 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8309 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8310 All callers changed.
8311 (string_buffer_position): Likewise. Also, make static (it's never
8312 used outside xdisp.c).
8313 (cursor_row_p): Remove parameter `w', unused since
8314 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8315 (decode_mode_spec): Remove parameter `precision', introduced during
8316 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8317 All callers changed.
8318
5ffb62aa
JD
83192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8320
8321 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8322
461c2ab9 83232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8324
8325 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8326 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8327 (ns_update_auto_hide_menu_bar): New functions.
8328 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8329 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8330 ns_constrain_all_frames.
8331 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8332 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8333
5c380ffb
JD
83342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8335
8336 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8337
9af30bdf
GM
83382011-03-27 Glenn Morris <rgm@gnu.org>
8339
8340 * syssignal.h: Replace RETSIGTYPE with void.
8341 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8342 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8343 Replace SIGTYPE with void everywhere.
8344 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8345 * s/template.h (SIGTYPE): Remove commented out definition.
8346
e2abce01
JB
83472011-03-26 Eli Zaretskii <eliz@gnu.org>
8348
8349 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8350 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8351
f868cd8a
JB
83522011-03-26 Juanma Barranquero <lekktu@gmail.com>
8353
59eb0929
JB
8354 * w32.c (read_unc_volume): Use parameter `henum', instead of
8355 global variable `wget_enum_handle'.
8356
8357 * keymap.c (describe_vector): Remove parameters `indices' and
8358 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8359 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8360
f868cd8a
JB
8361 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8362
8363 * keyboard.c (timer_check): Remove parameter `do_it_now',
8364 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8365 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8366 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8367
8368 * keyboard.c (read_char):
8369 * w32menu.c (w32_menu_display_help):
8370 * xmenu.c (show_help_event, menu_help_callback):
8371 Adjust calls to `show_help_echo'.
8372
8373 * gtkutil.c (xg_maybe_add_timer):
8374 * keyboard.c (readable_events):
8375 * process.c (wait_reading_process_output):
8376 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8377
8378 * insdel.c (adjust_markers_gap_motion):
8379 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8380 (gap_left, gap_right): Don't call it.
8381
2ecf6fdb
CY
83822011-03-25 Chong Yidong <cyd@stupidchicken.com>
8383
8384 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8385 incurred during fontification.
8386
6b1f9ba4
JB
83872011-03-25 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8390 (DEFVAR_PER_BUFFER): Don't pass it.
8391
8392 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8393 (scrolling_window): Don't pass it.
8394
0f4a96b5
JB
83952011-03-25 Juanma Barranquero <lekktu@gmail.com>
8396
8397 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8398
8399 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8400 and `suffix'.
8401 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8402 of variables specific to SELinux and computation of `encoded_absname'.
8403
8404 * image.c (XPutPixel): Remove unused variable `height'.
8405
8406 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8407
8408 * unexw32.c (get_section_info): Remove unused variable `section'.
8409
8410 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8411 (system_process_attributes): Remove unused variable `sess'.
8412 (sys_read): Remove unused variable `err'.
8413
8414 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8415 (w32_wnd_proc): Remove unused variable `isdead'.
8416 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8417 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8418 (x_create_tip_frame): Remove unused variable `tem'.
8419
8420 * w32inevt.c (w32_console_read_socket):
8421 Remove unused variable `no_events'.
8422
8423 * w32term.c (x_draw_composite_glyph_string_foreground):
8424 Remove unused variable `width'.
8425
1149507c
JB
84262011-03-24 Juanma Barranquero <lekktu@gmail.com>
8427
8428 * w32term.c (x_set_glyph_string_clipping):
8429 Don't pass uninitialized region to CombineRgn.
8430
9c88f339
JB
84312011-03-23 Juanma Barranquero <lekktu@gmail.com>
8432
8433 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8434 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8435 (Fx_close_connection): Remove unused variable `i'.
8436
8437 * w32font.c (w32font_draw): Return number of glyphs.
8438 (w32font_open_internal): Remove unused variable `i'.
8439 (w32font_driver): Add missing initializer.
8440
8441 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8442 (fill_in_menu): Remove unused variable `items_added'.
8443
8444 * w32term.c (last_mouse_press_frame): Remove static global variable.
8445 (w32_clip_to_row): Remove unused variable `f'.
8446 (x_delete_terminal): Remove unused variable `i'.
8447
8448 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8449 (NOTHING): Remove unused static global variable.
8450 (uniscribe_check_otf): Remove unused variable `table'.
8451 (uniscribe_font_driver): Add missing initializers.
8452
dee091a3
JD
84532011-03-23 Julien Danjou <julien@danjou.info>
8454
8455 * term.c (Fsuspend_tty, Fresume_tty):
8456 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8457 * window.c (temp_output_buffer_show):
8458 * insdel.c (signal_before_change):
8459 * frame.c (Fhandle_switch_frame):
8460 * fileio.c (Fdo_auto_save):
8461 * emacs.c (Fkill_emacs):
8462 * editfns.c (save_excursion_restore):
8463 * cmds.c (internal_self_insert):
8464 * callint.c (Fcall_interactively):
8465 * buffer.c (Fkill_all_local_variables):
8466 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8467 Use Frun_hooks.
0f4a96b5 8468 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8469 unconditionally since it does the check itself.
dee091a3 8470
2c520ab5 84712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8472
c9c49752
PE
8473 Fix more problems found by GCC 4.5.2's static checks.
8474
8abc3f12
PE
8475 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8476 the first time through the loop, since we know p0 < p1 then.
8477 This also avoids a gcc -Wstrict-overflow warning.
8478
a2d26660
PE
8479 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8480 leading to a memory leak, possible in functions like
8481 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8482 of objects (Bug#8318).
a2d26660 8483
916c72e9
PE
8484 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8485 that could (at least in theory) be that large.
8486
19ab8a18
PE
8487 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8488 This is less likely to overflow, and avoids undefined behavior if
8489 overflow does occur. All callers changed. Use strtoul to scan
8490 for the unsigned long integer.
b7cbbd6f
PE
8491 (pint2hrstr): Simplify and tune code slightly.
8492 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8493
f0641eff
PE
8494 * scroll.c (do_scrolling): Work around GCC bug 48228.
8495 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8496
7f650bb9
PE
8497 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8498 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8499 (validate_x_resource_name): Simplify count usage.
8500 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8501
37dd57d1
PE
8502 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8503 fail (Bug#8306).
81e56e61 8504
699979fc 8505 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8506
401bf9b4
PE
8507 * process.c (Fmake_network_process): Use socklen_t, not int,
8508 where POSIX says socklen_t is required in portable programs.
8509 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8510 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8511 (Fmake_network_process, server_accept_connection):
8512 (wait_reading_process_output, read_process_output):
8513 Likewise.
8514
b93aacde
PE
8515 * process.c: Rename or move locals to avoid shadowing.
8516 (list_processes_1, Fmake_network_process):
8517 (read_process_output_error_handler, exec_sentinel_error_handler):
8518 Rename or move locals.
4dc343ee 8519 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8520 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8521 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8522 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8523 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8524
af8a867c 8525 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8526 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8527 Include tparam.h instead, since it declares them.
af8a867c
PE
8528 * cm.h (PC): Remove extern decl; tparam.h now does this.
8529 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8530 * terminfo.c: Include tparam.h, to check interfaces.
8531 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8532 (tparam): Adjust signature to match interface in tparam.h;
8533 this removes some undefined behavior. Check that outstring and len
8534 are zero, which they always are with Emacs.
8535 * tparam.h (PC, BC, UP): New extern decls.
8536
0248044d 8537 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8538 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8539
8ff096c1 8540 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8541 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8542 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8543 (ftfont_list): Remove unused local.
49eaafba
PE
8544 (get_adstyle_property, ftfont_pattern_entity):
8545 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8546 Rename locals to avoid shadowing.
8ff096c1 8547
e2be39f6
PE
8548 * xfont.c (xfont_list_family): Mark var as initialized.
8549
c9735e30
PE
8550 * xml.c (make_dom): Now static.
8551
8f5201ae
PE
8552 * composite.c (composition_compute_stop_pos): Rename local to
8553 avoid shadowing.
b246f932
PE
8554 (composition_reseat_it): Remove unused locals.
8555 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8556 (composition_update_it): Mark var as initialized.
11b61122
PE
8557 (find_automatic_composition): Mark vars as initialized,
8558 with a FIXME (Bug#8290).
8f5201ae 8559
760fbc2c
PE
8560 character.h: Rename locals to avoid shadowing.
8561 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8562 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8563 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8564 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8565 to avoid shadowing.
8566
ff08eb85
PE
8567 * textprop.c (property_change_between_p): Remove; unused.
8568
fc7bf025
PE
8569 * intervals.c (interval_start_pos): Now static.
8570
235d7abc
PE
8571 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8572
44f230aa
SM
8573 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8574 Rename locals to avoid shadowing.
3e7d6594 8575
50060332
PE
8576 * sound.c (wav_play, au_play, Fplay_sound_internal):
8577 Fix pointer signedness.
d01f234b 8578 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8579 (wav_play): Initialize a variable to 0, to prevent undefined
8580 behavior (Bug#8278).
50060332 8581
c4fc4e30
PE
8582 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8583
918436ed
PE
8584 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8585
c939f91b
PE
8586 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8587 clobbering (Bug#8298).
b9c7f648
PE
8588 * sysdep.c (sys_subshell): Likewise.
8589 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8590
6bd8c144
PE
8591 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8592 This should get cleaned up, so that child_setup has the
8593 same signature on all platforms.
8594
7710357c 8595 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8596 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8597
c59da222
CY
85982011-03-22 Chong Yidong <cyd@stupidchicken.com>
8599
8600 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8601 not to be necessary, and produces flickering.
8602
66b87493
GM
86032011-03-20 Glenn Morris <rgm@gnu.org>
8604
8605 * config.in: Remove file.
8606
45b6f6d5
JB
86072011-03-20 Juanma Barranquero <lekktu@gmail.com>
8608
8609 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8610 are now in src/globals.h.
8611 (syms_of_minibuf): Remove spurious & from previous change.
8612
cd394be1 86132011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8614
8615 * minibuf.c (completing-read-function): New variable.
8616 (completing-read-default): Rename from completing-read.
8617 (completing-read): Call completing-read-function.
8618
b14e3e21
CY
86192011-03-19 Juanma Barranquero <lekktu@gmail.com>
8620
8621 * xfaces.c (Fx_load_color_file):
8622 Read color file from absolute filename (bug#8250).
8623
f2b726e6
JB
86242011-03-19 Juanma Barranquero <lekktu@gmail.com>
8625
8626 * makefile.w32-in: Update dependencies.
8627
09f6ff02
EZ
86282011-03-17 Eli Zaretskii <eliz@gnu.org>
8629
8630 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8631
29a6015a
PE
86322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8633
a3a6c54e
PE
8634 Fix more problems found by GCC 4.5.2's static checks.
8635
b766f867
PE
8636 * process.c (make_serial_process_unwind, send_process_trap):
8637 (sigchld_handler): Now static.
8638
be02381c
PE
8639 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8640 That way, the code declares only the vars that it needs.
8641 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8642 * s/cygwin.h (PTY_ITERATION): Likewise.
8643 * s/darwin.h (PTY_ITERATION): Likewise.
8644 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8645
57048744
PE
8646 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8647 * process.c (allocate_pty): Don't declare stb unless it's needed.
8648
7914961c 8649 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8650 (CONSTANTLIM): Remove; unused.
8651 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8652 Define only if needed.
7914961c 8653
b3967b18
PE
8654 * unexelf.c (unexec): Name an expression,
8655 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8656 Use a different way to cause a compilation error if anyone uses
8657 n rather than nn, a way that does not involve shadowing.
73366a00 8658 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8659
29a6015a
PE
8660 * deps.mk (unexalpha.o): Remove; unused.
8661
43cfc33e 8662 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8663 * unexec.h: New file.
ce701a33
PE
8664 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8665 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8666 Depend on unexec.h.
8667 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8668 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8669 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8670 Change as necessary to match prototype in unexec.h.
ce701a33 8671
01f44d5a
PE
8672 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8673 shadowing.
4f63c6bb 8674 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8675
a6670b0b
PE
8676 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8677 Rename locals to avoid shadowing.
8678
cef2010d 8679 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8680 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8681
d4d7173a
PE
8682 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8683
f08b802a
PE
8684 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8685 warning when compiling print.c.
8686
3ddb0639
PE
8687 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8688 instead of using an uninitialized var.
5ad03b97 8689 (font_sort_entities): Mark var as initialized.
3ddb0639 8690
170a2692
PE
8691 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8692
e663c700
PE
8693 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8694 pointers to constants.
89bc529a 8695 (font_parse_fcname): Remove unused vars.
7b81e2d0 8696 (font_delete_unmatched): Now static.
ea838e10 8697 (font_get_spec): Remove; unused.
13a547c6
PE
8698 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8699 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8700 Rename or move locals to avoid shadowing.
e663c700 8701
2a80c887 8702 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8703 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8704
1384fa33 8705 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8706 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8707
8b2c52e9
PE
8708 * alloc.c (mark_backtrace): Move decl from here ...
8709 * lisp.h: ... to here, so that it can be checked.
8710
475545b5 8711 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8712 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8713 (lisp_indirect_variable): Name an expression,
8714 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8715 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8716
b1349114 8717 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8718 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8719 Use const pointer when appropriate.
b1349114 8720
a2928364
PE
8721 * lisp.h (get_system_name, get_operating_system_release):
8722 Move decls here, to check interfaces.
8723 * process.c (get_operating_system_release): Move decl to lisp.h.
8724 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8725 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8726 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8727 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8728 (Fformat_time_string, Fencode_time, Finsert_char):
8729 (Ftranslate_region_internal, Fformat):
8730 Rename or remove local vars to avoid shadowing.
9710023e 8731 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8732
a415e694
PE
8733 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8734 avoid shadowing.
8735
8ef4622d
PE
8736 * lisp.h (eassert): Check that the argument compiles, even if
8737 ENABLE_CHECKING is not defined.
8738
946f9a5b
PE
8739 * data.c (Findirect_variable): Name an expression, to avoid
8740 gcc -Wbad-function-cast warning.
112396d6 8741 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8742 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8743 (Fmake_variable_buffer_local, Fmake_local_variable):
8744 Mark variables as initialized.
52746918 8745 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8746
e5aab7e7 8747 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8748 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8749 Rename locals to avoid shadowing.
dff45157
PE
8750 (mark_stack): Move local variables into the #ifdef region where
8751 they're used.
7bc26fdb
PE
8752 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8753 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8754 needed otherwise.
8755 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8756 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8757 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8758
e5aab7e7
PE
8759 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8760 avoids undefined behavior in theory.
8761
4da60324
PE
8762 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8763
88043301
PE
8764 Use functions, not macros, for up- and down-casing (Bug#8254).
8765 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8766 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8767 to use the following functions instead of these macros.
8768 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8769 EMACS_INT, since callers assume the returned value fits in int.
8770 (upcase1): Likewise, for UPCASE_TABLE.
8771 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8772 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8773 the race-condition problem in the old DOWNCASE.
88043301 8774
19ed5445
PE
8775 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8776 Rename locals to avoid shadowing.
8777 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8778 (regex_compile, re_search_2, re_match_2_internal):
8779 Remove unused local vars.
952db0d7
PE
8780 (FREE_VAR): Rewrite so as not to use empty "else",
8781 which gcc can warn about.
da053e48 8782 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8783 (RETALLOC_IF): Define only if needed.
8784 (WORDCHAR_P): Likewise. This one is never needed, but is used
8785 only in a comment talking about a compiler bug, so put inside
8786 the #if 0 of that comment.
8787 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8788 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8789 Remove; unused.
19ed5445 8790
1f3561e4 8791 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8792 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8793 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8794
ded6f8f7
PE
8795 * search.c (simple_search): Remove unused var.
8796
dbd37a95
PE
8797 * dired.c (compile_pattern): Move decl from here ...
8798 * lisp.h: ... to here, so that it can be checked.
8799 (struct re_registers): New forward decl.
8800
7e47afad
PE
8801 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8802
85f24f61
PE
8803 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8804 All uses changed.
8805 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8806 Rename locals to avoid shadowing.
5671df8f 8807 (Fvertical_motion): Mark locals as initialized.
85f24f61 8808
181aa2be 8809 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8810 (casify_region): Mark local as initialized.
181aa2be 8811
930d429c
PE
8812 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8813
7082eac6
PE
8814 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8815 New macros, so that the caller can use some names other than
8816 gcpro1, gcpro2, etc.
8817 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8818 of the new macros.
8819 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8820 argument, for consistency with GCPRO2_VAR, etc: it is now the
8821 prefix of the variable, not the variable itself. All uses
8822 changed.
38b2c076
PE
8823 * dired.c (directory_files_internal, file_name_completion):
8824 Rename locals to avoid shadowing.
8825
15206ed9
PE
8826 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8827 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8828 dired.c's scmp function, had undefined behavior.
8829 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8830 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8831 * buffer.h: ... to here, because these macros use current_buffer,
8832 and the new implementation with inline functions needs to have
8833 current_buffer in scope now, rather than later when the macros
8834 are used.
8835 (downcase, upcase1): New static inline functions.
8836 (DOWNCASE, UPCASE1): Reimplement using these functions.
8837 This avoids undefined behavior in expressions like
8838 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8839 from race conditions in accessing the global variables
8840 case_temp1 and case_temp2.
8841 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8842 * lisp.h (case_temp1, case_temp2): Remove their decls.
8843 * character.h (ASCII_CHAR_P): Move from here ...
8844 * lisp.h: ... to here, so that the inline functions mentioned
8845 above can use them.
8846
4a6bea26
PE
8847 * dired.c (directory_files_internal_unwind): Now static.
8848
f14b7e14
PE
8849 * fileio.c (file_name_as_directory, directory_file_name):
8850 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8851 Now static.
2893f146
PE
8852 (file_name_as_directory): Use const pointers when appropriate.
8853 (Fexpand_file_name): Likewise. In particular, newdir might
8854 point at constant storage, so make it a const pointer.
fd4ead52 8855 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8856 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8857 signedness issues.
f839df0c
PE
8858 (Fset_file_times, Finsert_file_contents, auto_save_error):
8859 Rename locals to avoid shadowing.
f14b7e14 8860
5716756e 8861 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8862 (Ftry_completion, Fall_completions): Rename or remove locals
8863 to avoid shadowing.
5716756e 8864
b4c3046a
PE
8865 * marker.c (bytepos_to_charpos): Remove; unused.
8866
b45db522
PE
8867 * lisp.h (verify_bytepos, count_markers): New decls,
8868 so that gcc does not warn that these functions aren't declared.
8869
85876d07
PE
8870 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8871 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8872 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8873 (copy_text): Remove unused local var.
85876d07 8874
03d78a21 8875 * filelock.c (within_one_second): Now static.
b3dd38ab 8876 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8877
5df8f01b
PE
8878 * buffer.c (fix_overlays_before): Mark locals as initialized.
8879 (fix_start_end_in_overlays): Likewise. This function should be
8880 simplified by using pointers-to-pointers, but that's a different
8881 matter.
b1d876f1 8882 (switch_to_buffer_1): Now static.
8f54f30a
PE
8883 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8884 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8885
a70072c9 8886 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8887 Fix pointer signedness issue.
edced198
PE
8888 (sys_subshell): Mark local as volatile if checking for lint,
8889 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8890 (MAXPATHLEN): Define only if needed.
a70072c9 8891
a0977c44
PE
8892 * process.c (serial_open, serial_configure): Move decls from here ...
8893 * systty.h: ... to here, so that they can be checked.
8894
a884fdcc
PE
8895 * fns.c (get_random, seed_random): Move extern decls from here ...
8896 * lisp.h: ... to here, so that they can be checked.
8897
604efe86 8898 * sysdep.c (reset_io): Now static.
b8950c94 8899 (wait_for_termination_signal): Remove; unused.
604efe86 8900
38fc62d9
PE
8901 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8902 (copy_keymap_item, append_key, push_text_char_description):
8903 Now static.
1004a21a 8904 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8905 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8906 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8907 (describe_map_tree):
8908 Rename locals to avoid shadowing.
38fc62d9 8909
2f2650da
PE
8910 * keyboard.c: Declare functions static if they are not used elsewhere.
8911 (echo_char, echo_dash, cmd_error, top_level_2):
8912 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8913 (read_char, kbd_buffer_get_event, make_lispy_position):
8914 (make_lispy_event, make_lispy_movement, apply_modifiers):
8915 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8916 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8917 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8918 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8919 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8920
a053e86c 8921 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8922 (mark_kboards): Move decl here ...
8923 * alloc.c (mark_kboards): ... from here.
a053e86c 8924
4752793e
PE
8925 * lisp.h (force_auto_save_soon): New decl.
8926
74f10ca7 8927 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8928 (DEFINE_DUMMY_FUNCTION): New macro.
8929 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8930 Use it.
c03cd23f
PE
8931 (main): Add casts to avoid warnings
8932 if GCC considers string literals to be constants.
74f10ca7 8933
022e70d4
PE
8934 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8935
59d6fe83
PE
8936 * dbusbind.c: Pointer signedness fixes.
8937 (xd_signature, xd_append_arg, xd_initialize):
8938 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8939 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8940 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8941 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8942
78320123
PE
8943 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8944 if GCC considers string literals to be constants.
49cebcca 8945 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8946
35ac2a97
SM
89472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8948
fb103ca9
SM
8949 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8950 (print_preprocess, print_object): New macro to fix last change.
8951
35ac2a97
SM
8952 * print.c (print_preprocess): Don't forget font objects.
8953
62973b41
JB
89542011-03-16 Juanma Barranquero <lekktu@gmail.com>
8955
8956 * emacs.c (USAGE3): Doc fixes.
8957
0e48bb22
AS
89582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8959
8960 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8961 structure.
8962
7684e57b
JB
89632011-03-14 Juanma Barranquero <lekktu@gmail.com>
8964
8965 * lisp.h (VWindow_system, Qfile_name_history):
8966 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8967 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8968 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8969
8970 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8971 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8972
8973 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8974 * w32console.c (detect_input_pending, read_input_pending)
8975 (encode_terminal_code):
8976 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8977 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8978 (w32_system_caret_y, Qfile_name_history):
8979 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8980 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8981 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8982 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8983 * w32proc.c (Qlocal, report_file_error):
8984 * w32term.c (Vwindow_system, updating_frame):
8985 * w32uniscribe.c (initialized, uniscribe_font_driver):
8986 Remove unneeded extern declarations.
8987
2aa46d6c
CY
89882011-03-14 Chong Yidong <cyd@stupidchicken.com>
8989
c96bbc66 8990 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8991
cffc6f3b
CY
89922011-03-13 Chong Yidong <cyd@stupidchicken.com>
8993
8994 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8995 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8996 These macros can no longer be used for assignment.
8997
44f230aa
SM
8998 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8999 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9000 (record_buffer_markers, fetch_buffer_markers): New functions for
9001 recording and fetching special buffer markers.
9002 (set_buffer_internal_1, set_buffer_temp): Use them.
9003
9004 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9005
9006 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9007
9008 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9009 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9010
9011 * xdisp.c (hscroll_window_tree):
9012 (reconsider_clip_changes): Use PT instead of BUF_PT.
9013
d251f04b
EZ
90142011-03-13 Eli Zaretskii <eliz@gnu.org>
9015
9016 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9017 $(EMACS_ROOT)/lib/intprops.h.
9018
f0c77cd1
PE
90192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9020
3eca4629
PE
9021 Fix more problems found by GCC 4.5.2's static checks.
9022
7c86ee98
PE
9023 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9024 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9025 (xg_free_frame_widgets): Make it clear that a local variable is
9026 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9027 (gdk_window_get_screen): Make it clear that this macro is needed
9028 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9029 (int_gtk_range_get_value): New function, which avoids a diagnostic
9030 from gcc -Wbad-function-cast.
9031 (xg_set_toolkit_scroll_bar_thumb): Use it.
9032 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9033 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9034 (get_utf8_string, xg_get_file_with_chooser):
9035 Rename locals to avoid shadowing.
9036 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9037
41729b81
PE
9038 * xgselect.c (xg_select): Remove unused var.
9039
f0c77cd1
PE
9040 * image.c (four_corners_best): Mark locals as initialized.
9041 (gif_load): Initialize transparent_p to zero (Bug#8238).
9042 Mark another local as initialized.
ec6cf4c6 9043 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9044
ce0ad53d 9045 * image.c (clear_image_cache): Now static.
d5d5a617 9046 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9047 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9048 (x_edge_detection): Remove unnecessary cast that
9049 gcc -Wbad-function-cast diagnoses.
2037898d 9050 (gif_load): Fix pointer signedness.
6ae141d6
PE
9051 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9052 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9053
33383987 90542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9055
d32df629
PE
9056 Improve quality of tests for time stamp overflow.
9057 For example, without this patch (encode-time 0 0 0 1 1
9058 1152921504606846976) returns the obviously-bogus value (-948597
9059 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9060 reports time overflow. See
9061 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9062 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9063 * editfns.c: Include limits.h and intprops.h.
9064 (TIME_T_MIN, TIME_T_MAX): New macros.
9065 (time_overflow): Move earlier, to before first use.
9066 (hi_time, lo_time): New functions, for an accurate test for
9067 out-of-range times.
9068 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9069 (Fget_internal_run_time): Don't assume time_t fits in int.
9070 (make_time): Use list2 instead of Fcons twice.
9071 (Fdecode_time): More accurate test for out-of-range times.
9072 (check_tm_member): New function.
9073 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9074 (lisp_time_argument): Don't rely on undefined left-shift and
9075 right-shift behavior when checking for time stamp overflow.
8be6f318 9076
fe31d94c
PE
9077 * editfns.c (time_overflow): New function, refactoring common code.
9078 (Fformat_time_string, Fdecode_time, Fencode_time):
9079 (Fcurrent_time_string): Use it.
9080
8be6f318
PE
9081 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9082 * dired.c (make_time): Move to ...
9083 * editfns.c (make_time): ... here.
9084 * systime.h: Note the move.
9085
09d9db2c 90862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9087
126bc0dc
YM
9088 * fringe.c (update_window_fringes): Remove unused variables.
9089
c47cbdfd
YM
9090 * unexmacosx.c (copy_data_segment): Also copy __got section.
9091 (Bug#8223)
9092
7ac80be9
EZ
90932011-03-12 Eli Zaretskii <eliz@gnu.org>
9094
c96bbc66 9095 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9096 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9097 Constify `char *' arguments and their references according to
9098 prototypes in tparam.h.
9099
ecb0f94d 9100 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9101
7ac80be9
EZ
9102 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9103 Adapt all references accordingly.
9104
9105 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9106
ef1fd07e
TT
91072011-03-11 Tom Tromey <tromey@redhat.com>
9108
9109 * buffer.c (syms_of_buffer): Remove obsolete comment.
9110
7ef4b50c
EZ
91112011-03-11 Eli Zaretskii <eliz@gnu.org>
9112
9113 * termhooks.h (encode_terminal_code): Declare prototype.
9114
9115 * msdos.c (encode_terminal_code): Don't declare prototype.
9116
9117 * term.c (encode_terminal_code): Now external again, used by
9118 w32console.c and msdos.c.
9119
44f230aa
SM
9120 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9121 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9122
4b1ec863 91232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9124
1714f52b 9125 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9126
4b1ec863
PE
9127 * fringe.c (update_window_fringes): Mark locals as initialized
9128 (Bug#8227).
9129 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9130
524c7aa6
PE
9131 * alloc.c (mark_fringe_data): Move decl from here ...
9132 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9133 to check its interface.
9134 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9135
a5c0af81 9136 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9137 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9138 (fontset_font): Mark local as initialized.
a9a06e0b 9139 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9140
b4716021
PE
9141 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9142
811e9bac 9143 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9144 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9145 (x_own_selection, Fx_disown_selection_internal): Rename locals
9146 to avoid shadowing.
9147 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9148
7e3ab302
PE
9149 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9150 so that the caller can use some name other than gcpro1.
9151 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9152 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9153 (Fx_backspace_delete_keys_p):
9154 Use them to avoid shadowing, and rename vars to avoid shadowing.
9155 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9156 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9157 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9158 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9159 Remove unused locals.
7e3ab302
PE
9160 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9161 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9162 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9163 macros.
f78faa98 9164
e2b13473
PE
9165 * xterm.h (x_mouse_leave): New decl.
9166
77f23912
PE
9167 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9168 Remove unused functions.
cdf4ba58
PE
9169 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9170 (x_calc_absolute_position): Now static.
7411c686 9171 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9172 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9173 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9174 unless they are used.
38d0b34a
PE
9175 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9176 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9177 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9178 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9179 (x_error_catcher, x_connection_closed, x_error_handler):
9180 (x_error_quitter, xembed_send_message, x_iconify_frame):
9181 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9182 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9183 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9184
44f230aa
SM
9185 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9186 Rename or move locals to avoid shadowing.
6b463e58 9187 (tty_defined_color, merge_face_heights): Now static.
5967d051 9188 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9189 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9190 does not deduce is never used uninitialized.
73719eba
PE
9191 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9192 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9193
426994c3 9194 * terminal.c (store_terminal_param): Now static.
5489860b 9195
032f1620 9196 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9197 (set_frame_menubar): Remove unused local.
d4323972 9198 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9199 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9200 since they might point to immutable storage.
281585b0
PE
9201 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9202 since it's unused otherwise.
032f1620 9203
367c19e5 9204 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9205 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9206 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9207 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9208 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9209 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9210 does not deduce are never used uninitialized.
70739cbe 9211
07b48fa9
PE
9212 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9213
8868a238 9214 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9215 * window.c (window_loop, size_window):
9216 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9217
7e5cf297 9218 * window.c (display_buffer): Now static.
d6550a9f
PE
9219 (size_window): Mark variables that gcc -Wuninitialized
9220 does not deduce are never used uninitialized.
a586633d
PE
9221 * window.h (check_all_windows): New decl, to forestall
9222 gcc -Wmissing-prototypes diagnostic.
5b555da1 9223 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9224
f6095868
PE
9225 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9226 shadowing.
9227 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9228 Include <limits.h>.
9229 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9230 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9231 (load_charset_map): Mark variables that gcc -Wuninitialized
9232 does not deduce are never used uninitialized.
53df7c11 9233 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9234
f38b440c
PE
9235 * coding.c (coding_set_source, coding_set_destination):
9236 Use "else { /* comment */ }" rather than "else /* comment */;"
9237 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9238 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9239 a block, when the outer 'i' will do.
9240 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9241 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9242 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9243 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9244 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9245 Rename locals to avoid shadowing.
9246 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9247 * coding.c (emacs_mule_char, encode_invocation_designation):
9248 Now static, since they're not used elsewhere.
413bb2db 9249 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9250 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9251 (decode_coding_emacs_mule): Mark variables that gcc
9252 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9253 (detect_coding_iso_2022): Initialize a local variable that might
9254 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9255 this initialization is needed. (Bug#8211)
5f58e762
PE
9256 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9257 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9258 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9259 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9260 Remove unused macros.
f38b440c 9261
232b38b9 9262 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9263 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9264 * character.c (string_count_byte8): Likewise.
232b38b9 9265
fb90da1b
PE
9266 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9267 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9268
fb93dbc2
PE
9269 * chartab.c (copy_sub_char_table): Now static, since it's not used
9270 elsewhere.
5c156ace
PE
9271 (sub_char_table_ref_and_range, char_table_ref_and_range):
9272 Rename locals to avoid shadowing.
bbcd0949 9273 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9274
7d3b3862 9275 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9276 (BIDI_BOB): Remove unused macro.
7d3b3862 9277
6be7d3da
PE
9278 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9279 deduce are never used uninitialized.
c2ed9c8b 9280 * term.c (encode_terminal_code): Likewise.
6be7d3da 9281
75f8807f 9282 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9283
50938595
PE
9284 * tparam.h: New file.
9285 * term.c, tparam.h: Include it.
9286 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9287 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9288 Move these decls to tparam.h, and make them agree with what
9289 is actually in tparam.c. The previous trick of using incompatible
9290 decls in different modules does not conform to the C standard.
9291 All callers of tparam changed to use tparam's actual API.
9292 * tparam.c (tparam1, tparam, tgoto):
9293 Use const pointers where appropriate.
9294
fbceeba2
PE
9295 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9296 * cm.h (struct cm): Likewise.
9297 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9298 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9299 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9300 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9301 (turn_on_face, init_tty): Likewise.
9302 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9303
7f3f1250
PE
9304 * term.c (term_mouse_position): Rename local to avoid shadowing.
9305
e6ca6543
PE
9306 * alloc.c (mark_ttys): Move decl from here ...
9307 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9308
c40f8d15
AS
93092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9310
9311 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9312
cfe0661d
JB
93132011-03-09 Juanma Barranquero <lekktu@gmail.com>
9314
9315 * search.c (compile_pattern_1): Remove argument regp, unused since
9316 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9317 (compile_pattern): Don't pass it.
9318
0afb4571
J
93192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9320
9321 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9322 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9323 for ! HAVE_GTK3.
9324 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9325
9326 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9327
9328 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9329 gdk_window_get_screen, gdk_window_get_geometry,
9330 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9331 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9332 (xg_get_pixbuf_from_pixmap): New function.
9333 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9334 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9335 Call xg_get_pixbuf_from_pixmap instead of
9336 gdk_pixbuf_get_from_drawable.
9337 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9338 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9339 (xg_check_special_colors): Use GtkStyleContext and its functions
9340 for HAVE_GTK3.
9341 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9342 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9343 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9344 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9345 Call gtk_widget_get_preferred_size.
0afb4571
J
9346 (xg_frame_resized): gdk_window_get_geometry only takes 5
9347 parameters.
44f230aa
SM
9348 (xg_win_to_widget, xg_event_is_for_menubar):
9349 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9350 (xg_set_widget_bg): New function.
9351 (delete_cb): New function.
895009e1 9352 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9353 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9354 (xg_set_background_color): Call xg_set_widget_bg.
9355 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9356 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9357 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9358 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9359 if ! HAVE_GTK3.
9360 (update_frame_tool_bar): Call gtk_widget_hide.
9361 (xg_initialize): Use GDK_KEY_g.
9362
9363 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9364 if ! HAVE_GTK3
9365 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9366
9367 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9368 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9369 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9370
1c2cc4ef
JB
93712011-03-08 Juanma Barranquero <lekktu@gmail.com>
9372
9373 * w32xfns.c (select_palette): Check success of RealizePalette against
9374 GDI_ERROR, not zero.
9375
33383987 9376See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9377
9378;; Local Variables:
9379;; coding: utf-8
aac0c6e3
MR
9380;; End:
9381
acaf905b 9382 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9383
9384 This file is part of GNU Emacs.
9385
9386 GNU Emacs is free software: you can redistribute it and/or modify
9387 it under the terms of the GNU General Public License as published by
9388 the Free Software Foundation, either version 3 of the License, or
9389 (at your option) any later version.
9390
9391 GNU Emacs is distributed in the hope that it will be useful,
9392 but WITHOUT ANY WARRANTY; without even the implied warranty of
9393 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9394 GNU General Public License for more details.
9395
9396 You should have received a copy of the GNU General Public License
9397 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.