Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
5efd304b
PE
3 * xterm.c (x_alloc_nearest_color_1): Use a more-precise algorithm
4 for nearest color, one that neither overflows nor relies on unsigned
5 arithmetic.
6
578c21e6
PE
7 Remove unnecessary casts.
8 * xterm.c (x_term_init):
9 * xfns.c (x_set_border_pixel):
10 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11 These aren't needed now that we assume ANSI C.
12
96f53c6c
PE
13 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
14 It's more likely to cause problems (due to unsigned overflow)
15 than to cure them.
16
83c77d31
PE
17 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
18
ee2079f1
PE
19 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
20
6da65536
PE
21 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
22
7147c4a4
PE
23 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
24
193e32d9
PE
25 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
26
e5533da6
PE
27 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
28
9910e595
PE
29 GLYPH_CODE_FACE returns EMACS_INT, not int.
30 * dispextern.h (merge_faces):
31 * xfaces.c (merge_faces):
01103c44
PE
32 * xdisp.c (get_next_display_element, next_element_from_display_vector):
33 Don't assume EMACS_INT fits in int.
9910e595 34
2638320e
PE
35 * character.h (CHAR_VALID_P): Remove unused parameter.
36 * fontset.c, lisp.h, xdisp.c: All uses changed.
37
045eb8d9
PE
38 * editfns.c (Ftranslate_region_internal): Omit redundant test.
39
c1f134b5
PE
40 * fns.c (concat): Minor tuning based on overflow analysis.
41 This doesn't fix any bugs. Use int to hold character, instead
42 of constantly refetching from Emacs object. Use XFASTINT, not
43 XINT, for value known to be a character. Don't bother comparing
44 a single byte to 0400, as it's always less.
45
395fcb93 46 * floatfns.c (Fexpt):
327eeec8
PE
47 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
48
abbd3d23
PE
49 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
50 for characters.
51
684a03ef
PE
52 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
53
0fed43f3
PE
54 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
55 Without this fix, on a 64-bit host (aset S 0 4294967386) would
56 incorrectly succeed when S was a string, because 4294967386 was
57 truncated before it was used.
58
8fd02eb7
PE
59 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
60 Otherwise, an out-of-range integer could cause undefined behavior
61 on a 64-bit host.
62
f8c86b69
PE
63 * composite.c: Use int, not EMACS_INT, for characters.
64 (fill_gstring_body, composition_compute_stop_pos): Use int, not
65 EMACS_INT, for values that are known to be in character range.
66 This doesn't fix any bugs but is the usual style inside Emacs and
67 may generate better code on 32-bit machines.
68
34206dd2
PE
69 Make sure a 64-bit char is never passed to ENCODE_CHAR.
70 This is for reasons similar to the recent CHAR_STRING fix.
71 * charset.c (Fencode_char): Check that character arg is actually
72 a character. Pass an int to ENCODE_CHAR.
73 * charset.h (ENCODE_CHAR): Verify that the character argument is no
74 wider than 'int', as a compile-time check to prevent future regressions
75 in this area.
76
c5958d4c 77 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
78
79 Make sure a 64-bit char is never passed to CHAR_STRING.
80 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
81 by silently ignoring the top 32 bits, allowing some values
82 that were far too large to be valid characters.
83 * character.h: Include <verify.h>.
84 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
85 arguments are no wider than unsigned, as a compile-time check
86 to prevent future regressions in this area.
87 * data.c (Faset):
01103c44 88 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
89 (Fsubst_char_in_region):
90 * fns.c (concat):
91 * xdisp.c (decode_mode_spec_coding):
92 Adjust to CHAR_STRING's new requirement.
93 * editfns.c (Finsert_char, Fsubst_char_in_region):
94 * fns.c (concat): Check that character args are actually
95 characters. Without this test, these functions did the wrong
96 thing with wildly out-of-range values on 64-bit hosts.
97
d37ca623
PE
98 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
99 These casts should not be needed on 32-bit hosts, either.
100 * keyboard.c (read_char):
101 * lread.c (Fload): Remove casts to unsigned.
102
ea204efb
PE
103 * lisp.h (UNSIGNED_CMP): New macro.
104 This fixes comparison bugs on 64-bit hosts.
105 (ASCII_CHAR_P): Use it.
106 * casefiddle.c (casify_object):
01103c44 107 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
108 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
109 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
110 * dispextern.h (FACE_FROM_ID):
111 * keyboard.c (read_char): Use UNSIGNED_CMP.
112
41cb286c
PE
113 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
114 not to EMACS_INT, to avoid GCC warning.
115
4a1b9832
PE
116 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
117
55daad71
PE
118 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
119 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
120 isn't needed on 32-bit machines.
8f95c75c 121
01103c44
PE
122 * buffer.c (Fgenerate_new_buffer_name):
123 Use EMACS_INT for count, not int.
0ceccced 124 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
125
126 * data.c (Qcompiled_function): Now static.
127
c6f072e7
PE
128 * window.c (window_body_lines): Now static.
129
20ce5912
PE
130 * image.c (gif_load): Rename local to avoid shadowing.
131
9c4c5f81
PE
132 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
133 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
134 * alloc.c (make_save_value): Integer argument is now of type
135 ptrdiff_t, not int.
136 (mark_object): Use ptrdiff_t, not int.
137 * lisp.h (pD): New macro.
138 * print.c (print_object): Use it.
139
c0c5c8ae
PE
140 * alloc.c: Use EMACS_INT, not int, to count objects.
141 (total_conses, total_markers, total_symbols, total_vector_size)
142 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
143 (total_free_floats, total_floats, total_free_intervals)
144 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
145 Now EMACS_INT, not int. All uses changed.
146 (Fgarbage_collect): Compute overall total using a double, so that
147 integer overflow is less likely to be a problem. Check for overflow
148 when converting back to an integer.
5a25e253
PE
149 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
150 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
151 These were 'int' variables that could overflow on 64-bit hosts;
152 they were never used, so remove them instead of repairing them.
211a0b2a 153 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
154 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
155 Previously, this ceilinged at INT_MAX, but that doesn't work on
156 64-bit machines.
e46bb31a 157 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 158
c78baabf 159 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 160 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
161 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
162 when a (possibly-narrower) signed value would do just as well.
163 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 164
c9d624c6
PE
165 * alloc.c: Catch some string size overflows that we were missing.
166 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
167 for convenience in STRING_BYTES_MAX.
168 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
169 The definition here is exact; the one in lisp.h was approximate.
170 (allocate_string_data): Check for string overflow. This catches
171 some instances we weren't catching before. Also, it catches
172 size_t overflow on (unusual) hosts where SIZE_MAX <= min
173 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
174 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 175
c9d624c6
PE
176 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
177 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
178 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
179
353032ce
PE
180 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
181
2bccce07
PE
182 * alloc.c (Fmake_string): Check for out-of-range init.
183
e10ac9f1
MR
1842011-06-12 Martin Rudalics <rudalics@gmx.at>
185
186 * frame.c (make_frame): Call other_buffer_safely instead of
187 other_buffer.
188
189 * window.c (temp_output_buffer_show): Call display_buffer with
190 second argument Vtemp_buffer_show_specifiers and reset latter
191 immediately after the call.
192 (Vtemp_buffer_show_specifiers): New variable.
193 (auto_window_vscroll_p, next_screen_context_lines)
194 (Vscroll_preserve_screen_position): Remove leading asterisks from
195 doc-strings.
196
2d3c217e 1972011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 198
7b7f97e8 199 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
200 * buffer.c (Qclone_number): Remove for now, as it's unused.
201 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
202 (record_buffer): Remove unused local.
203 * frame.c (other_visible_frames, frame_buffer_list): Now static.
204 (set_frame_buffer_list): Remove; unused.
205 * frame.h (other_visible_frames): Remove decl.
206 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
207 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
208 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
209 if HAVE_GPM.
210 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
211 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
212 Define only if HAVE_GPM.
213 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
214 (update_hints_inhibit): Remove; never set. All uses removed.
215 * widgetprv.h (emacsFrameClassRec): Remove decl.
216 * window.c (delete_deletable_window): Now returns void, since it
217 wasn't returning anything.
218 (compare_window_configurations): Remove unused locals.
219 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
220 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
221 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
222 the same widths as pointers. This follows up on the 2011-05-06 patch.
223 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
224 * xterm.h: Likewise.
225 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
226
1384b89e
JB
2272011-06-12 Juanma Barranquero <lekktu@gmail.com>
228
229 * makefile.w32-in: Update dependencies.
230 (LISP_H): Add lib/intprops.h.
231
1100a63c
CY
2322011-06-11 Chong Yidong <cyd@stupidchicken.com>
233
234 * image.c (gif_load): Add animation frame delay to the metadata.
235 (syms_of_image): Use DEFSYM. New symbol `delay'.
236
6198ccd0
MR
2372011-06-11 Martin Rudalics <rudalics@gmx.at>
238
239 * window.c (delete_deletable_window): Re-add.
240 (Fset_window_configuration): Rewrite to handle dead buffers and
241 consequently deletable windows.
242 (window_tree, Fwindow_tree): Remove. Supply functionality in
243 window.el.
244 (compare_window_configurations): Simplify code.
245
b6e3633c
AS
2462011-06-11 Andreas Schwab <schwab@linux-m68k.org>
247
1ab0dee5
AS
248 * image.c (imagemagick_load_image): Fix type mismatch.
249 (Fimagemagick_types): Likewise.
250
b6e3633c
AS
251 * window.h (replace_buffer_in_windows): Declare.
252
9397e56f
MR
2532011-06-11 Martin Rudalics <rudalics@gmx.at>
254
255 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
256 Qclone_number. Remove external declaration of Qdelete_window.
257 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
258 code.
259 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
260 Qbuffer_list_update_hook if allowed.
261 (Fother_buffer): Rewrite doc-string. Major rewrite for new
262 buffer list implementation.
263 (other_buffer_safely): New function.
264 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
265 calls to replace_buffer_in_windows and
266 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
267 if allowed.
268 (record_buffer): Inhibit quitting and rewrite using quittable
269 functions. Run Qbuffer_list_update_hook if allowed.
270 (Frecord_buffer, Funrecord_buffer): New functions.
271 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
272 switch-to-buffer to window.el.
273 (bury-buffer): Move to window.el.
274 (Vbuffer_list_update_hook): New variable.
275
276 * lisp.h (other_buffer_safely): Add prototype in buffer.c
277 section.
278
279 * window.h (resize_frame_windows): Move up in code.
280 (Fwindow_frame): Remove EXFUN.
281 (replace_buffer_in_all_windows): Remove prototype.
282 (replace_buffer_in_windows_safely): Add prototype.
283
284 * window.c: Declare Qdelete_window static again. Move down
285 declaration of select_count.
286 (Fnext_window, Fprevious_window): Rewrite doc-strings.
287 (Fother_window): Move to window.el.
288 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
289 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
290 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
291 window.el.
292 (replace_buffer_in_windows): Implement by calling
293 Qreplace_buffer_in_windows.
294 (replace_buffer_in_all_windows): Remove with some functionality
295 moved into replace_buffer_in_windows_safely.
296 (replace_buffer_in_windows_safely): New function.
297 (select_window_norecord, select_frame_norecord): Move in front
298 of run_window_configuration_change_hook. Remove now obsolete
299 declarations.
300 (Fset_window_buffer): Rewrite doc-string. Call
301 Qrecord_window_buffer.
302 (keys_of_window): Move binding for other-window to window.el.
303
b50691aa
CY
3042011-06-11 Chong Yidong <cyd@stupidchicken.com>
305
306 * dispextern.h (struct image): Replace data member, whose int_val
307 and ptr_val fields were not used by anything, with a single
308 lisp_val object.
309
310 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
311 (gif_clear_image, gif_load, imagemagick_load_image)
312 (gs_clear_image, gs_load): Callers changed.
313
3f754b86
PE
3142011-06-10 Paul Eggert <eggert@cs.ucla.edu>
315
cca69397
PE
316 * buffer.h: Include <time.h>, for time_t.
317 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
318
109e28d0
PE
319 Fix minor problems found by static checking.
320
60737f02
PE
321 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
322
4b66faf3
PE
323 Make identifiers static if they are not used in other modules.
324 * data.c (Qcompiled_function, Qframe, Qvector):
325 * image.c (QimageMagick, Qsvg):
326 * minibuf.c (Qmetadata):
327 * window.c (resize_window_check, resize_root_window): Now static.
328 * window.h (resize_window_check, resize_root_window): Remove decls.
329
109e28d0
PE
330 * window.c (window_deletion_count, delete_deletable_window):
331 Remove; unused.
46a4ce9e
PE
332 (window_body_lines): Now static.
333 (Fdelete_other_windows_internal): Mark vars as initialized.
334 Make sure 'resize_failed' is initialized.
335 (run_window_configuration_change_hook): Rename local to avoid shadowing.
336 (resize_window_apply): Remove unused local.
337 * window.h (delete_deletable_window): Remove decl.
338
109e28d0 339 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
340 (imagemagick_load_image): Fix pointer signedness problem by changing
341 last arg from unsigned char * to char *. All uses changed.
342 Also, fix a local for similar reasons.
343 Remove unused locals. Remove locals to avoid shadowing.
344 (fn_rsvg_handle_free): Remove; unused.
345 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 346 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 347
3f754b86
PE
348 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
349
2547adb1
CY
3502011-06-10 Chong Yidong <cyd@stupidchicken.com>
351
352 * image.c (gif_load): Fix omitted cast error introduced by
353 2011-06-06 change.
354
2c8e37d4
MR
3552011-06-10 Martin Rudalics <rudalics@gmx.at>
356
357 * window.h (resize_proportionally, orig_total_lines)
358 (orig_top_line): Remove from window structure.
359 (set_window_height, set_window_width, change_window_heights)
360 (Fdelete_window): Remove prototypes.
361 (resize_frame_windows): Remove duplicate declaration.
362
440a42e3
EZ
3632011-06-10 Eli Zaretskii <eliz@gnu.org>
364
365 * window.h (resize_frame_windows, resize_window_check)
366 (delete_deletable_window, resize_root_window)
367 (resize_frame_windows): Declare prototypes.
368
369 * window.c (resize_window_apply): Make definition be "static" to
370 match the prototype.
371
562dd5e9
MR
3722011-06-10 Martin Rudalics <rudalics@gmx.at>
373
374 * window.c: Remove declarations of Qwindow_size_fixed,
375 window_min_size_1, window_min_size_2, window_min_size,
376 size_window, window_fixed_size_p, enlarge_window, delete_window.
377 Remove static from declaration of Qdelete_window, it's
378 temporarily needed by Fbury_buffer.
379 (replace_window): Don't assign orig_top_line and
380 orig_total_lines.
381 (Fdelete_window, delete_window): Remove. Window deletion is
382 handled by window.el.
383 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
384 Fdelete_window calls with calls to Qdelete_window.
385 (Fdelete_other_windows): Remove. Deleting other windows is
386 handled by window.el.
387 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
388 handled in window.el.
389 (window_min_size_2, window_min_size_1, window_min_size): Remove.
390 Window minimum sizes are handled in window.el.
391 (shrink_windows, size_window, set_window_height)
392 (set_window_width, change_window_heights, window_height)
393 (window_width, CURBEG, CURSIZE, enlarge_window)
394 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
395 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
396 handled in window.el.
397 (make_dummy_parent): Rename to make_parent_window and give it a
398 second argument horflag.
399 (make_window): Don't set resize_proportionally any more.
400 (Fsplit_window): Remove. Windows are split in window.el.
401 (save_restore_action, save_restore_orig_size)
402 (shrink_window_lowest_first, save_restore_orig_size): Remove.
403 Resize mini windows in window.el.
404 (grow_mini_window, shrink_mini_window): Implement by calling
405 Qresize_root_window_vertically, resize_window_check and
406 resize_window_apply.
407 (saved_window, Fset_window_configuration, save_window_save): Do
408 not handle orig_top_line, orig_total_lines, and
409 resize_proportionally.
410 (window_min_height, window_min_width): Move to window.el.
411 (keys_of_window): Move bindings for delete-other-windows,
412 split-window, delete-window and enlarge-window to window.el.
413
414 * buffer.c: Temporarily extern Qdelete_window.
415 (Fbury_buffer): Temporarily call Qdelete_window instead of
416 Fdelete_window (Fbury_buffer will move to window.el soon).
417
418 * frame.c (set_menu_bar_lines_1): Remove code handling
419 orig_top_line and orig_total_lines.
420
421 * dispnew.c (adjust_frame_glyphs_initially): Don't use
422 set_window_height but set heights directly.
423 (change_frame_size_1): Use resize_frame_windows.
424
425 * xdisp.c (init_xdisp): Don't use set_window_height but set
426 heights directly.
427
428 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
429 resize_frame_windows instead of change_window_heights and run
430 run_window_configuration_change_hook.
431
432 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
433 instead of change_window_heights and run
434 run_window_configuration_change_hook.
435
1a13852e
MR
4362011-06-09 Martin Rudalics <rudalics@gmx.at>
437
438 * window.c (replace_window): Rename second argument REPLACEMENT to
439 NEW. New third argument SETFLAG. Rewrite.
440 (delete_window, make_dummy_parent): Call replace_window with
441 third argument 1.
442 (window_list_1): Move down in code.
443 (run_window_configuration_change_hook): Move set_buffer part
444 before select_frame_norecord part in order to unwind correctly.
445 Rename count1 to count.
446 (recombine_windows, delete_deletable_window, resize_root_window)
447 (Fdelete_other_windows_internal)
448 (Frun_window_configuration_change_hook, make_parent_window)
449 (resize_window_check, resize_window_apply, Fresize_window_apply)
450 (resize_frame_windows, Fsplit_window_internal)
451 (Fdelete_window_internal, Fresize_mini_window_internal): New
452 functions.
453 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
454
f3d1777e
MR
4552011-06-08 Martin Rudalics <rudalics@gmx.at>
456
496e208e
MR
457 * window.h (window): Add some new members to window structure -
458 normal_lines, normal_cols, new_total, new_normal, clone_number,
459 splits, nest, prev_buffers, next_buffers.
460 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 461 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 462
f3d1777e
MR
463 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
464 Remove.
496e208e
MR
465 (make_dummy_parent): Set new members of windows structure.
466 (make_window): Move down in code. Handle new members of window
467 structure.
468 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
469 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
470 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
471 (Fset_window_prev_buffers, Fwindow_next_buffers)
472 (Fset_window_next_buffers, Fset_window_clone_number): New
473 functions.
474 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
475 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
476 Doc-string fixes.
477 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
478 Argument WINDOW can be now internal window too.
479 (Fwindow_use_time): Move up in code.
480 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
481 Rewrite doc-string.
482 (Fset_window_configuration, saved_window)
483 (Fcurrent_window_configuration, save_window_save): Handle new
484 members of window structure.
b9e809c2
MR
485 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
486 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
487 (syms_of_window): New Lisp objects Qrecord_window_buffer,
488 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
489 Qget_mru_window, Qresize_root_window,
490 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
491 Qauto_buffer_name; staticpro them.
f3d1777e 492
abde8f8c
MR
4932011-06-07 Martin Rudalics <rudalics@gmx.at>
494
495 * window.c (Fwindow_total_size, Fwindow_left_column)
496 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
497 (Fwindow_list_1): New functions.
498 (window_box_text_cols): Replace with window_body_cols.
499 (Fwindow_width, Fscroll_left, Fscroll_right): Use
500 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
501 (delete_window, Fset_window_configuration): Call
502 delete_all_subwindows with window as argument.
503 (delete_all_subwindows): Take a window as argument and not a
504 structure. Rewrite.
190b47e6
MR
505 (window_loop): Remove handling of GET_LRU_WINDOW and
506 GET_LARGEST_WINDOW.
507 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
508
509 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
510 window_box_text_cols. delete_all_subwindows now takes a
511 Lisp_Object as argument.
abde8f8c
MR
512
513 * indent.c (compute_motion, Fcompute_motion): Use
514 window_body_cols instead of window_box_text_cols.
515
fa8a67e6
MR
516 * frame.c (delete_frame): Call delete_all_subwindows with root
517 window as argument.
518
a54e3482
DC
5192011-06-07 Daniel Colascione <dan.colascione@gmail.com>
520
521 * fns.c (Fputhash): Document return value.
522
60002bf5
CY
5232011-06-06 Chong Yidong <cyd@stupidchicken.com>
524
525 * image.c (gif_load): Implement gif89a spec "no disposal" method.
526
0c671da6 5272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 528
b862a52a 529 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 530
be44ca6c
PE
531 Check for overflow when converting integer to cons and back.
532 * charset.c (Fdefine_charset_internal, Fdecode_char):
533 Use cons_to_unsigned to catch overflow.
534 (Fencode_char): Use INTEGER_TO_CONS.
535 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
536 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
537 * data.c (long_to_cons, cons_to_long): Remove.
538 (cons_to_unsigned, cons_to_signed): New functions.
539 These signal an error for invalid or out-of-range values.
540 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
541 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
542 * font.c (Ffont_variation_glyphs):
543 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
544 * lisp.h: Include <intprops.h>.
545 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
546 (cons_to_signed, cons_to_unsigned): New decls.
547 (long_to_cons, cons_to_long): Remove decls.
548 * undo.c (record_first_change): Use INTEGER_TO_CONS.
549 (Fprimitive_undo): Use CONS_TO_INTEGER.
550 * xfns.c (Fx_window_property): Likewise.
551 * xselect.c: Include <limits.h>.
552 (x_own_selection, selection_data_to_lisp_data):
553 Use INTEGER_TO_CONS.
554 (x_handle_selection_request, x_handle_selection_clear)
555 (x_get_foreign_selection, Fx_disown_selection_internal)
556 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
557 (lisp_data_to_selection_data): Use cons_to_unsigned.
558 (x_fill_property_data): Use cons_to_signed.
559 Report values out of range.
560
d1f3d2af
PE
561 Check for buffer and string overflow more precisely.
562 * buffer.h (BUF_BYTES_MAX): New macro.
563 * lisp.h (STRING_BYTES_MAX): New macro.
564 * alloc.c (Fmake_string):
565 * character.c (string_escape_byte8):
566 * coding.c (coding_alloc_by_realloc):
567 * doprnt.c (doprnt):
568 * editfns.c (Fformat):
569 * eval.c (verror):
570 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
571 since they may not be the same number.
572 * editfns.c (Finsert_char):
573 * fileio.c (Finsert_file_contents):
574 Likewise for BUF_BYTES_MAX.
575
dd52fcea
PE
576 * image.c: Use ptrdiff_t, not int, for sizes.
577 (slurp_file): Switch from int to ptrdiff_t.
578 All uses changed.
579 (slurp_file): Check that file size fits in both size_t (for
580 malloc) and ptrdiff_t (for sanity and safety).
581
7f9bbdbb
PE
582 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
583 if b->modtime has its maximal value.
584
dfe18f82
PE
585 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
586
84acfcf0
PE
587 Don't assume time_t can fit into int.
588 * buffer.h (struct buffer.modtime): Now time_t, not int.
589 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
590 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
591
ccd9a01a
PE
592 Minor fixes for signed vs unsigned integers.
593 * character.h (MAYBE_UNIFY_CHAR):
594 * charset.c (maybe_unify_char):
595 * keyboard.c (read_char, reorder_modifiers):
596 XINT -> XFASTINT, since the integer must be nonnegative.
597 * ftfont.c (ftfont_spec_pattern):
598 * keymap.c (access_keymap, silly_event_symbol_error):
599 XUINT -> XFASTINT, since the integer must be nonnegative.
600 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
601 since it makes no difference and we prefer signed.
602 * keyboard.c (record_char): Use XUINT when all the neighbors do.
603 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
604 nonnegative.
605
d6d100dd
SM
6062011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
607
608 * window.h (Fwindow_frame): Declare.
609
2b6148e4
PE
6102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
611
612 * alloc.c: Simplify handling of large-request failures (Bug#8800).
613 (SPARE_MEMORY): Always define.
614 (LARGE_REQUEST): Remove.
615 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
616
f230ecc9
MR
6172011-06-06 Martin Rudalics <rudalics@gmx.at>
618
727e958e
MR
619 * lisp.h: Move EXFUNS for Fframe_root_window,
620 Fframe_first_window and Fset_frame_selected_window to window.h.
621
622 * window.h: Move EXFUNS for Fframe_root_window,
623 Fframe_first_window and Fset_frame_selected_window here from
624 lisp.h.
625
626 * frame.c (Fwindow_frame, Fframe_first_window)
627 (Fframe_root_window, Fframe_selected_window)
628 (Fset_frame_selected_window): Move to window.c.
629 (Factive_minibuffer_window): Move to minibuf.c.
630 (Fother_visible_frames_p): New function.
631
632 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
633
f230ecc9
MR
634 * window.c (decode_window, decode_any_window): Move up in code.
635 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
636 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
637 (Fwindow_buffer): Move up and rewrite doc-string.
638 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
639 (Fwindow_prev): New functions.
727e958e
MR
640 (Fwindow_frame): Move here from frame.c. Accept any window as
641 argument.
642 (Fframe_root_window, Fframe_first_window)
643 (Fframe_selected_window): Move here from frame.c. Accept frame
644 or arbitrary window as argument. Update doc-strings.
645 (Fminibuffer_window): Move up in code.
646 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
647 (Fset_frame_selected_window): Move here from frame.c.
648 Marginal rewrite.
727e958e
MR
649 (Fselected_window, select_window, Fselect_window): Move up in
650 code. Minor doc-string fixes.
f230ecc9 651
4d09bcf6
PE
6522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
653
654 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
655 Do not assume that spare memory exists; that assumption is valid
656 only if SYSTEM_MALLOC.
657 (LARGE_REQUEST): New macro, so that the issue of large requests
658 is separated from the issue of spare memory.
659
810928a2
AS
6602011-06-05 Andreas Schwab <schwab@linux-m68k.org>
661
172418ad
AS
662 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
663 format. (Bug#8806)
664
43f862f7
AS
665 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
666
810928a2
AS
667 * xfns.c (x_set_scroll_bar_default_width): Move declarations
668 before statements.
669
a059fe24
JD
6702011-06-05 Jan Djärv <jan.h.d@swipnet.se>
671
672 * gtkutil.c (xg_get_default_scrollbar_width): New function.
673
674 * gtkutil.h: Declare xg_get_default_scrollbar_width.
675
676 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
677 min width by calling x_set_scroll_bar_default_width (Bug#8505).
678
989bf368
JB
6792011-06-05 Juanma Barranquero <lekktu@gmail.com>
680
681 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
682
4b80f674
CY
6832011-06-04 Chong Yidong <cyd@stupidchicken.com>
684
685 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
686 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
687 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
688 New error handlers.
4b80f674
CY
689 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
690 Obey Vx_select_enable_clipboard_manager. Catch errors in
691 x_clipboard_manager_save (Bug#8779).
692 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 693 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 694
99a33b77 6952011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
696
697 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
698
99a33b77 6992011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
700
701 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
702 in the current matrix if keep_current_p is non-zero.
703
8264569d
EZ
7042011-06-04 Eli Zaretskii <eliz@gnu.org>
705
706 * bidi.c (bidi_level_of_next_char): Fix last change.
707
57f97249
EZ
7082011-06-03 Eli Zaretskii <eliz@gnu.org>
709
fec2107c 710 Support bidi reordering of text covered by display properties.
57f97249 711
fec2107c
EZ
712 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
713 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
714 (bidi_cache_search, bidi_cache_iterator_state)
715 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
716 (bidi_level_of_next_char, bidi_move_to_visually_next):
717 Support character positions inside a run of characters covered by a
fec2107c
EZ
718 display string.
719 (bidi_paragraph_init, bidi_resolve_explicit_1)
720 (bidi_level_of_next_char): Call bidi_fetch_char and
721 bidi_fetch_char_advance instead of FETCH_CHAR and
722 FETCH_CHAR_ADVANCE.
723 (bidi_init_it): Initialize new members.
724 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
725 definitions.
726 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
727 instead of using explicit *_CHAR codes.
d6d100dd
SM
728 (bidi_resolve_explicit, bidi_resolve_weak):
729 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
730 bidirectional text is supported only in multibyte buffers.
731 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
732 it to initialize the frame_window_p member of struct bidi_it.
733 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
734 (bidi_resolve_explicit, bidi_resolve_weak)
735 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
736 bidi_it->nchars is non-positive.
737 (bidi_level_of_next_char): Don't try to lookup the cache for the
738 next/previous character if nothing is cached there yet, or if we
739 were just reseat()'ed to a new position.
c40e2fb2 740
0e14fe90
EZ
741 * xdisp.c (set_cursor_from_row): Set start and stop points
742 according to the row's direction when priming the loop that looks
743 for the glyph on which to display cursor.
744 (single_display_spec_intangible_p): Function deleted.
745 (display_prop_intangible_p): Reimplement to call
746 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
747 Accept 3 additional arguments needed by handle_display_spec.
748 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
749 values: lists, `(when COND...)' forms, etc.
750 (single_display_spec_string_p): Support property values that are
751 lists with the argument STRING its top-level element.
752 (display_prop_string_p): Fix the condition for processing a
753 property that is a list to be consistent with handle_display_spec.
fec2107c 754 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
755 last portion of handle_display_prop.
756 (compute_display_string_pos): Accept additional argument
757 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
758 value of a `display' property is a "replacing spec".
759 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
760 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
761 the display property, but just return a value indicating whether
762 the display property will replace the characters it covers.
763 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
764 frame_window_p members of struct bidi_it.
d6d100dd
SM
765 (compute_display_string_pos, compute_display_string_end):
766 New functions.
fec2107c
EZ
767 (push_it): Accept second argument POSITION, where pop_it should
768 jump to continue iteration.
769 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 770
fec2107c
EZ
771 * keyboard.c (adjust_point_for_property): Adjust the call to
772 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
773
774 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
775 (bidi_init_it): Update prototypes.
776 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
777 (compute_display_string_pos, compute_display_string_end):
778 Declare prototypes.
fec2107c
EZ
779 (struct bidi_it): New members nchars and disp_pos. ch_len is now
780 EMACS_INT.
fc6f18ce 781
40087514 7822011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 783
57f53182
PE
784 Malloc failure behavior now depends on size of allocation.
785 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
786 * lisp.h: Change signatures accordingly.
787 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
788 All callers changed. (Bug#8762)
789
790 * gnutls.c: Use Emacs's memory allocators.
791 Without this change, the gnutls library would invoke malloc etc.
792 directly, which causes problems on non-SYNC_INPUT hosts, and which
793 runs afoul of improving memory_full behavior. (Bug#8761)
794 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
795 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
796 xfree instead of the default malloc, realloc, free.
797 (Fgnutls_boot): No need to check for memory allocation failure,
798 since xmalloc does that for us.
799
ac32cd99 800 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
801 * category.c (hash_get_category_set):
802 * ccl.c (ccl_driver):
803 * charset.c (Fdefine_charset_internal):
804 * charset.h (struct charset.hash_index):
805 * composite.c (get_composition_id, gstring_lookup_cache)
806 (composition_gstring_put_cache):
807 * composite.h (struct composition.hash_index):
808 * dispextern.h (struct image.hash):
809 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
810 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
811 (hashfn_equal, hashfn_user_defined, make_hash_table)
812 (maybe_resize_hash_table, hash_lookup, hash_put)
813 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
814 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
815 (Fsxhash, Fgethash, Fputhash, Fmaphash):
816 * image.c (make_image, search_image_cache, lookup_image)
817 (xpm_put_color_table_h):
818 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 819 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
820 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
821 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
822 * alloc.c (allocate_vectorlike):
823 Check for overflow in vector size calculations.
824 * ccl.c (ccl_driver):
825 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
826 * fns.c, image.c: Remove unnecessary static decls that would otherwise
827 need to be updated by these changes.
40087514
PE
828 * fns.c (make_hash_table, maybe_resize_hash_table):
829 Check for integer overflow with large hash tables.
0de4bb68
PE
830 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
831 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
832 (SXHASH_REDUCE): New macro.
833 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
834 Use it instead of discarding useful hash info with large hash values.
835 (sxhash_float): New function.
836 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
837 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
838 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
839 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
840 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
841 Adjust signatures to match updated version of code.
842 (consing_since_gc): Now EMACS_INT, since a single hash table can
843 use more than INT_MAX bytes.
844
698d32e2
DN
8452011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
846
847 Make it possible to build with GCC-4.6+ -O2 -flto.
848
849 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
850
fd6fa53f
SM
8512011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
852
853 * minibuf.c (get_minibuffer, read_minibuf_unwind):
854 Call minibuffer-inactive-mode.
855
864db017
JB
8562011-05-31 Juanma Barranquero <lekktu@gmail.com>
857
858 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
859 Update dependencies.
860
2ad0baf4
DN
8612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
862
863 * data.c (init_data): Remove code for UTS, this system is not
864 supported anymore.
865
4fcc2638
DN
8662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
867
868 Don't force ./temacs to start in terminal mode.
869
870 * frame.c (make_initial_frame): Initialize faces in all cases, not
871 only when CANNOT_DUMP is defined.
872 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
873
c56e0fd5
DN
8742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
875
876 * dispnew.c (add_window_display_history): Use const for the string
877 pointer. Remove declaration, not needed.
878
333d54da 8792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 880
55d4c1b2 881 Use 'inline', not 'INLINE'.
333d54da 882 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
883 * alloc.c, fontset.c (INLINE): Remove.
884 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
885 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
886 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
887 * gmalloc.c (register_heapinfo): Use inline unconditionally.
888 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
889
738db178
DN
8902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
891
892 Make it possible to run ./temacs.
893
894 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
895 syms_of_callproc does the same thing. Remove test for
896 "initialized", do it in the caller.
897 * emacs.c (main): Avoid calling set_initial_environment when dumping.
898
620c53a6
SM
8992011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
900
901 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
902 (read_minibuf): Use get_minibuffer.
903 (syms_of_minibuf): Use DEFSYM.
904 (Qmetadata): New var.
905 * data.c (Qbuffer): Don't make it static.
906 (syms_of_data): Use DEFSYM.
907
e003a292
PE
9082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
909
910 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
911 (CCL_CODE_MIN): New macro.
912
ed008a6d
PE
9132011-05-30 Paul Eggert <eggert@cs.ucla.edu>
914
3687c2ef
PE
915 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
916
ed008a6d
PE
917 * eval.c (Qdebug): Now static.
918 * lisp.h (Qdebug): Remove decl. This reverts a part of the
919 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
920 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
921
d66c4c7c
CY
9222011-05-29 Chong Yidong <cyd@stupidchicken.com>
923
924 * image.c: Various fixes to ImageMagick code comments.
925 (Fimagemagick_types): Doc fix.
926
5fbc2025
PE
9272011-05-29 Paul Eggert <eggert@cs.ucla.edu>
928
0196f88a
PE
929 Minor fixes prompted by GCC 4.6.0 warnings.
930
931 * xselect.c (converted_selections, conversion_fail_tag): Now static.
932
5fbc2025
PE
933 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
934 (x_clipboard_manager_save_all): Move extern decl to ...
935 * xterm.h: ... here, so that it can be checked for consistency.
936
1dd3c2d9
CY
9372011-05-29 Chong Yidong <cyd@stupidchicken.com>
938
939 * xselect.c (x_clipboard_manager_save_frame)
940 (x_clipboard_manager_save_all): New functions.
941 (Fx_clipboard_manager_save): Lisp function deleted.
942
943 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
944 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
945
946 * xterm.h: Update prototype.
947
5ba6571d
WX
9482011-05-28 William Xu <william.xwl@gmail.com>
949
950 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
951 exiting (Bug#8239).
952
3eaff834
JM
9532011-05-28 Jim Meyering <meyering@redhat.com>
954
e1900994 955 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
956 * fns.c (to_uchar): Define.
957 (crypto_hash_function): Use it to convert some newly-signed
958 variables to unsigned, to avoid sign-extension bugs. For example,
959 without this change, (md5 "truc") would evaluate to
960 45723a2aff78ff4fff7fff1114760e62 rather than the expected
961 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 962 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 963
0f6990a7
PE
9642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
965
966 Integer overflow fixes.
c8a9ca5a 967
08686060
PE
968 * dbusbind.c: Serial number integer overflow fixes.
969 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
970 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
971 to hold a serial number that is too large for a fixnum.
972 (Fdbus_method_return_internal, Fdbus_method_error_internal):
973 Check for serial numbers out of range. Decode any serial number
59568bf0 974 that was so large that it became a float. (Bug#8722)
08686060 975
2d1fc3c7
PE
976 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
977 (Fdbus_call_method, Fdbus_call_method_asynchronously):
978 Use XFASTINT rather than XUINT when numbers are nonnegative.
979 (xd_append_arg, Fdbus_method_return_internal):
980 (Fdbus_method_error_internal): Likewise. Also, for unsigned
981 arguments, check that Lisp number is nonnegative, rather than
59568bf0 982 silently wrapping negative numbers around. (Bug#8722)
30217ff0 983 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 984 (Bug#8722)
2d1fc3c7 985
c8a9ca5a
PE
986 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
987
519e1d69
PE
988 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
989
30569699
PE
990 ccl: add integer overflow checks
991 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
992 (IN_INT_RANGE): New macros.
993 (ccl_driver): Use them to check for integer overflow when
994 decoding a CCL program. Many of the new checks are whether XINT (x)
995 fits in int; it doesn't always, on 64-bit hosts. The new version
996 doesn't catch all possible integer overflows, but it's an
847044ea 997 improvement. (Bug#8719)
30569699 998
c11285dc
PE
999 * alloc.c (make_event_array): Use XINT, not XUINT.
1000 There's no need for unsigned here.
1001
fdccd48e
PE
1002 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1003 This follows up to the 2011-05-06 change that substituted uintptr_t
1004 for EMACS_INT. This case wasn't caught back then.
1005
37910ab2
PE
1006 Rework Fformat to avoid integer overflow issues.
1007 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1008 now (part of C89). Include <verify.h>.
1009 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1010 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1011 (Fformat): Avoid the prepass trying to compute sizes; it was only
1012 approximate and thus did not catch overflow reliably. Instead, walk
1013 through the format just once, formatting and computing sizes as we go,
1014 checking for integer overflow at every step, and allocating a larger
1015 buffer as needed. Keep track separately whether the format is
1016 multibyte. Keep only the most-recently calculated precision, rather
1017 than them all. Record whether each argument has been converted to
1018 string. Use EMACS_INT, not int, for byte and char and arg counts.
1019 Support field widths and precisions larger than INT_MAX. Avoid
1020 sprintf's undefined behavior with conversion specifications such as %#d
1021 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1022 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1023 formatting out-of-range floating point numbers with int
1024 formats. (Bug#8668)
1025
2e6578fb
PE
1026 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1027
0ae6bdee
PE
1028 * data.c: Avoid integer truncation in expressions involving floats.
1029 * data.c: Include <intprops.h>.
1030 (arith_driver): When there's an integer overflow in an expression
1031 involving floating point, convert the integers to floating point
1032 so that the resulting value does not suffer from catastrophic
1033 integer truncation. For example, on a 64-bit host (* 4
1034 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1035 Do not rely on undefined behavior after integer overflow.
1036
de883a70
PE
1037 merge count_size_as_multibyte, parse_str_to_multibyte
1038 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1039 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1040 Check for integer overflow.
1041 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1042 since it's now a duplicate of the other. This is more of
1043 a character than a buffer op, so better that it's in character.c.
1044 * fns.c, print.c: Adjust to above changes.
1045
2ff916cb
PE
10462011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1047
1048 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1049
f1b54466
PE
10502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1051
fb1ac845
PE
1052 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1053 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1054 (x_clipboard_manager_save): Now static.
1055 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1056
f1b54466
PE
1057 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1058 (crypto_hash_function): Now static.
1059 Fix pointer signedness problems. Avoid unnecessary initializations.
1060
a9f737ee
CY
10612011-05-27 Chong Yidong <cyd@stupidchicken.com>
1062
1063 * termhooks.h (Vselection_alist): Make it terminal-local.
1064
1065 * terminal.c (create_terminal): Initialize it.
1066
1067 * xselect.c: Support for clipboard managers.
1068 (Vselection_alist): Move to termhooks.h as terminal-local var.
1069 (LOCAL_SELECTION): New macro.
1070 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1071 (symbol_to_x_atom): Remove gratuitous arg.
1072 (x_handle_selection_request, lisp_data_to_selection_data)
1073 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1074 (x_own_selection, x_get_local_selection, x_convert_selection):
1075 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1076 (some_frame_on_display): Delete unused function.
1077 (Fx_own_selection_internal, Fx_get_selection_internal)
1078 (Fx_disown_selection_internal, Fx_selection_owner_p)
1079 (Fx_selection_exists_p): New optional frame arg.
1080 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1081 (x_handle_selection_clear): Don't treat other terminals with the
1082 same keyboard specially. Use the terminal-local Vselection_alist.
1083 (x_clear_frame_selections): Use Frun_hook_with_args.
1084
1085 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1086
1087 * xterm.h: Add support for those atoms.
1088
e067f0c1
CY
10892011-05-26 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1092 (converted_selections, conversion_fail_tag): New global variables.
1093 (x_selection_request_lisp_error): Free the above.
1094 (x_get_local_selection): Remove unnecessary code.
1095 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1096 of converted selections stored in converted_selections.
1097 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1098 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1099 (x_convert_selection): New function.
1100 (x_handle_selection_event): Simplify.
1101 (x_get_foreign_selection): Don't ignore incoming requests while
1102 waiting for an answer; this will fail when we implement
1103 SAVE_TARGETS, and seems unnecessary anyway.
1104 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1105 (Vx_sent_selection_functions): Doc fix.
1106
0f4aebc0
LL
11072011-05-26 Leo Liu <sdl.web@gmail.com>
1108
1109 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1110
e61124cd
YM
11112011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1112
1113 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1114
1115 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1116 for fringe update if it has periodic bitmap.
1117 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1118 and fringe_bitmap_periodic_p.
1119
1120 * fringe.c (get_fringe_bitmap_data): New function.
1121 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1122 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1123 row. Mark glyph row for fringe update if periodicity changed.
1124
1125 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1126 for fringe update unless it has periodic bitmap.
1127
f16d9837
KH
11282011-05-25 Kenichi Handa <handa@m17n.org>
1129
1130 * xdisp.c (get_next_display_element): Set correct it->face_id for
1131 a static composition.
1132
e1b90ef6
LL
11332011-05-24 Leo Liu <sdl.web@gmail.com>
1134
1135 * deps.mk (fns.o):
1136 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1137
1138 * fns.c (crypto_hash_function, Fsha1): New function.
1139 (Fmd5): Use crypto_hash_function.
1140 (syms_of_fns): Add Ssha1.
1141
7400048f
PE
11422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 * gnutls.c: Remove unused macros.
1145 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1146 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1147 Remove macros that are defined and never used.
1148 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1149
abb71cf4
CY
11502011-05-22 Chong Yidong <cyd@stupidchicken.com>
1151
1152 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1153 (Fx_get_selection_internal): Minor cleanup.
1154 (Fx_own_selection_internal): Rename arguments for consistency with
1155 select.el.
1156
6307db39
PE
11572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1160
f3d4e0a4
CY
11612011-05-22 Chong Yidong <cyd@stupidchicken.com>
1162
1163 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1164
4d8ade89
YM
11652011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1166
1167 * dispnew.c (scrolling_window): Don't exclude the case that the
1168 last enabled row in the desired matrix touches the bottom boundary.
1169
32078c8d
GM
11702011-05-21 Glenn Morris <rgm@gnu.org>
1171
1172 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1173 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1174 and add some more files.
32078c8d 1175
7285dc67
EZ
11762011-05-20 Eli Zaretskii <eliz@gnu.org>
1177
1178 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1179 report_file_error introduced by the change from 2011-05-07.
1180
89d1bd22
PE
11812011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1182
1183 * systime.h (Time): Define only if emacs is defined.
1184 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1185 where the include path doesn't have X11/X.h by default. See
1186 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1187
e23640bb 11882011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1189
1190 * composite.c (find_automatic_composition): Fix previous change.
1191
b9704ad9
GM
11922011-05-20 Glenn Morris <rgm@gnu.org>
1193
1194 * lisp.mk: New file, split from Makefile.in.
1195 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1196 (shortlisp): Remove.
1197 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1198
4a720484
GM
11992011-05-19 Glenn Morris <rgm@gnu.org>
1200
1201 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1202 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1203 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1204 (lisp): Set the order to that of loadup.el.
1205 (shortlisp): Make it a copy of $lisp.
1206 (SOME_MACHINE_LISP): Remove.
1207 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1208 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1209
a28d4396
KH
12102011-05-18 Kenichi Handa <handa@m17n.org>
1211
1212 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1213 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1214 (find_automatic_composition): Mostly rewrite for efficiency.
1215
a2b1fa8e
JB
12162011-05-18 Juanma Barranquero <lekktu@gmail.com>
1217
1218 * makefile.w32-in: Update dependencies.
1219
8e1f5610
CS
12202011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1221
1222 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1223 revision 104625).
1224
7025ee00 12252011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1226
cdfa6eab
PE
1227 Fix some integer overflow issues, such as string length overflow.
1228
06d6db33
PE
1229 * insdel.c (count_size_as_multibyte): Check for string overflow.
1230
2b4560a8
PE
1231 * character.c (lisp_string_width): Check for string overflow.
1232 Use EMACS_INT, not int, for string indexes and lengths; in
1233 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1234 the resulting string length overflows an EMACS_INT; instead,
1235 report a string overflow if no precision given. When checking for
1236 precision exhaustion, use a check that cannot possibly have
1237 integer overflow. (Bug#8675)
1238 * character.h (lisp_string_width): Adjust to new signature.
1239
cb93f9be
PE
1240 * alloc.c (string_overflow): New function.
1241 (Fmake_string): Use it. This doesn't change behavior, but saves
1242 a few bytes and will simplify future changes.
1243 * character.c (string_escape_byte8): Likewise.
1244 * lisp.h (string_overflow): New decl.
1245
1a1f3366
PE
1246 Fixups, following up to the user-interface timestamp change.
1247 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1248 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1249 * msdos.c (mouse_get_pos): Likewise.
1250 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1251 * w32gui.h (Time): Define by including "systime.h" rather than by
1252 declaring it ourselves. (Bug#8664)
1253
d4e3e4d3
PE
1254 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1255 * image.c (clear_image_cache): Likewise.
1256
f6a24d19
PE
1257 * term.c (term_mouse_position): Don't assume time_t wraparound.
1258
08dc5ae6
PE
1259 Be more systematic about user-interface timestamps.
1260 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1261 and sometimes 'EMACS_UINT', to represent these timestamps.
1262 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1263 This makes the code easier to follow, and makes it easier to catch
1264 integer overflow bugs such as Bug#8664.
1265 * frame.c (Fmouse_position, Fmouse_pixel_position):
1266 Use Time, not unsigned long, for user-interface timestamps.
1267 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1268 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1269 * keyboard.h (last_event_timestamp): Likewise.
1270 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1271 * menu.h (xmenu_show): Likewise.
1272 * term.c (term_mouse_position): Likewise.
1273 * termhooks.h (struct input_event.timestamp): Likewise.
1274 (struct terminal.mouse_position_hook): Likewise.
1275 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1276 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1277 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1278 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1279 what it was before.
1280 * menu.h, termhooks.h: Include "systime.h", for Time.
1281
8e55734a
PE
1282 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1283 Don't assume that the difference between two unsigned long values
1284 can fit into an integer. At this point, we know button_down_time
1285 <= event->timestamp, so the difference must be nonnegative, so
1286 there's no need to cast the result if double-click-time is
1287 nonnegative, as it should be; check that it's nonnegative, just in
1288 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1289 apart (about 25 days). (Bug#8664)
8e55734a 1290
841f1b75 1291 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1292 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1293
3e26f69c
PE
1294 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1295 that always fit in int. Use a sentinel instead of a counter, to
1296 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1297 * frame.h (struct frame): Use int for menu_bar_items_used
1298 instead of EMACS_INT, since it always fits in int.
3e26f69c 1299
5cc152c0
PE
1300 * menu.c (grow_menu_items): Check for int overflow.
1301
d89eb65e
PE
1302 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1303
5235bd3e
PE
1304 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1305 Before, the code was not consistent. These values cannot exceed
1306 2**31 - 1 so there's no need to make them unsigned.
1307 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1308 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1309 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1310 as modifiers.
1311 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1312
bc827e23
PE
1313 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1314 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1315 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1316 presumably because the widths might not match.
1317
78eb494e
PE
1318 * window.c (size_window): Avoid needless test at loop start.
1319
04f2d78b
CB
13202011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1321
1322 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1323
d2fc7e3d 13242011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1325
1326 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1327
d2fc7e3d 13282011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1329
1330 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1331 `width' to `bar_area_x' and `bar_area_width', respectively.
1332 (x_scroll_run): Take account of fringe background extension.
1333
04f2d78b
CB
1334 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1335 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1336 `bar_area_width', respectively.
1337 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1338 background extension.
1339
79b70037
GM
13402011-05-10 Jim Meyering <meyering@redhat.com>
1341
1342 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1343
2f142cc5
JB
13442011-05-10 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * image.c (Finit_image_library): Return t for built-in image types,
1347 like pbm and xbm. (Bug#8640)
1348
57679c86
AS
13492011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1350
1351 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1352
888c9e86
EZ
13532011-05-07 Eli Zaretskii <eliz@gnu.org>
1354
b0512a1d
EZ
1355 * w32console.c (Fset_screen_color): Doc fix.
1356 (Fget_screen_color): New function.
1357 (syms_of_ntterm): Defsubr it.
1358
7285dc67
EZ
1359 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1360 unlink the temporary file if Fcall_process didn't create it in the
1361 first place.
1362 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1363 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1364 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1365 cue to call_process_cleanup not to close that handle.
1366
4d3fcc8e
BK
13672011-05-07 Ben Key <bkey76@gmail.com>
1368
1369 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1370 one of two shell specific rules, either bootstrap-temacs-CMD or
1371 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1372 to the previous implementation of the bootstrap-temacs rule.
1373 The bootstrap-temacs-CMD rule is similar to the previous
1374 implementation of the bootstrap-temacs rule except that it
1375 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1376 variable.
1377
1378 These changes, along with some changes to nt/configure.bat,
1379 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1380 earlier fix to add support for --cflags and --ldflags options
1381 that include quotes so that it works whether make uses cmd or
1382 sh as the shell.
1383
b4289b64
MA
13842011-05-06 Michael Albinus <michael.albinus@gmx.de>
1385
1386 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1387 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1388 is a constant.
1389 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1390 a string. Handle both cases.
1391 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1392 (Fdbus_register_method): Use Qinvalid_function.
1393
af4c0e28
JB
13942011-05-06 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * makefile.w32-in: Update dependencies.
1397 (LISP_H): Add inttypes.h and stdin.h.
1398 (PROCESS_H): Add unistd.h.
1399
c51453d9
EZ
14002011-05-06 Eli Zaretskii <eliz@gnu.org>
1401
1402 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1403 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1404
8ff0ac3c 14052011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1406
4c4b566b
PE
1407 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1408
aab2b9b5
PE
1409 * term.c (vfatal): Remove stray call to va_end.
1410 It's not needed and the C Standard doesn't allow it here anyway.
1411
c378da0b
PE
1412 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1413 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1414
288b08c7
PE
1415 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1416 bytes.
1417
e3601888
PE
1418 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1419
db6c0e74
PE
1420 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1421
dd5963ea
PE
1422 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1423
88c9450f
PE
1424 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1425
2f9442b8
PE
1426 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1427
c032b5f8
PE
1428 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1429 * charset.c (Fdefine_charset_internal): Don't initialize
1430 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1431 32-bit int (Bug#8600).
a108c10b
PE
1432
1433 * lread.c (read_integer): Be more consistent with string-to-number.
1434 Use string_to_number to do the actual conversion; this avoids
1435 rounding errors and fixes some other screwups. Without this fix,
1436 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1437 (digit_to_number): Move earlier, for benefit of read_integer.
1438 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1439 not a digit in any supported base. (Bug#8602)
a108c10b 1440
ad5f9eea
PE
1441 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1442
aec1708a
PE
1443 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1444 to match comment at start of function. This also removes a
1445 GCC warning about overflow in a 32+64-bit port.
1446
47be4ab5
PE
1447 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1448
371cac43
PE
1449 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1450 Reported by Stefan Monnier in
1451 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1452 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1453 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1454
d01a7826
PE
1455 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1456 (EMACS_UINTPTR): Likewise, with uintptr_t.
1457
7fd47d5c
PE
1458 * lisp.h: Prefer 64-bit EMACS_INT if available.
1459 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1460 on 32-bit hosts that have 64-bit int, so that they can access
1461 large files.
122b0c86
PE
1462 However, temporarily disable this change unless the temporary
1463 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1464
8727937b
PE
1465 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1466
8ac068ac
PE
1467 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1468 This removes an assumption that EMACS_INT and long are the same
1469 width as pointers. The assumption is true for Emacs porting targets
1470 now, but we want to make other targets possible.
1471 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1472 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1473 In the rest of the code, change types of integers that hold casted
1474 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1475 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1476 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1477 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1478 No need to cast type when ORing.
1479 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1480 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1481 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1482 assume EMACS_INT is the same width as char *.
1483 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1484 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1485 Remove no-longer-needed casts.
1486 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1487 (xg_tool_bar_help_callback, xg_make_tool_item):
1488 Use EMACS_INTPTR to hold an integer
1489 that will be cast to void *; this can avoid a GCC warning
1490 if EMACS_INT is not the same width as void *.
1491 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1492 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1493 (current_message_1, set_message_1):
1494 Use a local to convert to proper width without a cast.
1495 * xmenu.c (dialog_selection_callback): Likewise.
1496
ede49d71
PE
1497 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1498 Also, don't assume VALBITS / RAND_BITS is less than 5,
1499 and don't rely on undefined behavior when shifting a 1 left into
1500 the sign bit.
1501 * lisp.h (get_random): Change signature to match.
1502
2f30ecd0
PE
1503 * lread.c (hash_string): Use size_t, not int, for hash computation.
1504 Normally we prefer signed values; but hashing is special, because
1505 it's better to use unsigned division on hash table sizes so that
1506 the remainder is nonnegative. Also, size_t is the natural width
1507 for hashing into memory. The previous code used 'int', which doesn't
1508 retain enough info to hash well into very large tables.
1509 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1510
2a866e7b
PE
1511 * dbusbind.c: Don't possibly lose pointer info when converting.
1512 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1513 Use XPNTR rather than XHASH, so that the high-order bits of
1514 the pointer aren't lost when converting through void *.
1515
51639eac
PE
1516 * eval.c (Fautoload): Don't double-shift a pointer.
1517
92394119
PE
1518 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1519
dbdb9a7c
JB
15202011-05-06 Juanma Barranquero <lekktu@gmail.com>
1521
1522 * gnutls.c (DEF_GNUTLS_FN):
1523 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1524
db7a0b4f
AS
15252011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1526
1527 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1528 marker. (Bug#8610)
1529
f7ff1b0f 15302011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1531
1532 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1533 New version that can reserve upto 2GB of heap space.
1534
f7ff1b0f 15352011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1536
1537 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1538
639c109b
TZ
15392011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1540
1541 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1542 `gnutls_certificate_set_x509_key_file'.
1543
d2127135
JB
15442011-05-05 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1547 Update dependencies.
1548
e968f4f3
JB
15492011-05-04 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1552 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1553 Remove unused parameter `fildes'.
1554 * process.c (read_process_output, send_process): Don't pass it.
1555
84d358f0
JB
15562011-05-04 Juanma Barranquero <lekktu@gmail.com>
1557
1558 Fix previous change: the library cache is defined in w32.c.
1559 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1560 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1561
0898ca10
JB
15622011-05-04 Juanma Barranquero <lekktu@gmail.com>
1563
1564 Implement dynamic loading of GnuTLS on Windows.
1565
1566 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1567 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1568 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1569 Declare.
1570
1571 * gnutls.c (Qgnutls_dll): Define.
1572 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1573 (gnutls_*): Declare function pointers.
1574 (init_gnutls_functions): New function to initialize function pointers.
1575 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1576 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1577 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1578 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1579 (emacs_gnutls_write, emacs_gnutls_read)
1580 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1581 (Fgnutls_available_p): New function.
1582 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1583 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1584 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1585
1586 * image.c: Include w32.h.
1587 (Vimage_type_cache): Delete.
1588 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1589 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1590 (w32_delayed_load): Move to w32.c.
1591
1592 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1593
1594 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1595 (w32_delayed_load): Move from image.c. When loading a library, record
1596 its filename in the :loaded-from property of the library id.
1597 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1598 Initialize and staticpro them.
1599 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1600
1601 * process.c: Include lisp.h before w32.h, not after.
1602 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1603 instead of gnutls_record_check_pending.
1604
1605 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1606
ff4de4aa
TZ
16072011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1608
1609 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1610 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1611 as passed in.
1612
abe95abb
JD
16132011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1614
1615 * xterm.c (x_set_frame_alpha): Do not set property on anything
1616 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1617
e16e55d4
JB
16182011-05-02 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1621
bafcf6a5
JB
16222011-05-02 Juanma Barranquero <lekktu@gmail.com>
1623
1624 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1625 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1626 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1627 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1628 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1629 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1630 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1631 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1632 (Qgnutls_bootprop_callbacks_verify): Make static.
1633
e7a6747f
AS
16342011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1635
19ed11ba
AS
1636 * callproc.c: Indentation fixup.
1637
e7a6747f 1638 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1639 (wait_for_termination, interruptible_wait_for_termination):
1640 Move after wait_for_termination_1.
e7a6747f 1641
1ef14cb4
LMI
16422011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1643
1644 * sysdep.c (interruptible_wait_for_termination): New function
1645 which is like wait_for_termination, but allows keyboard
1646 interruptions.
1647
1648 * callproc.c (Fcall_process): Add (:file "file") as an option for
1649 the STDOUT buffer.
1650 (Fcall_process_region): Ditto.
1651
330d880c
EZ
16522011-04-30 Eli Zaretskii <eliz@gnu.org>
1653
8db90b73
EZ
1654 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1655 rather than `XVECTOR (FOO)->size'.
1656
330d880c
EZ
1657 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1658 inttypes.h, as a gnulib replacement is used if it not available in
1659 system headers.
1660
15cbd324
EZ
16612011-04-21 Eli Zaretskii <eliz@gnu.org>
1662
1663 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1664 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1665 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1666
1667 * coding.c (coding_alloc_by_realloc): Error out if destination
1668 will grow beyond MOST_POSITIVE_FIXNUM.
1669 (decode_coding_emacs_mule): Abort if there isn't enough place in
1670 charbuf for the composition carryover bytes. Reserve an extra
1671 space for up to 2 characters produced in a loop.
1672 (decode_coding_iso_2022): Abort if there isn't enough place in
1673 charbuf for the composition carryover bytes.
1674
16752011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1676
ae940cca
EZ
1677 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1678 aborting when %lld or %lll format is passed.
1679 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1680 %llo or %llx format is passed. (Bug#8545)
1681
03ab8921
EZ
1682 * window.c (window_scroll_line_based): Use a marker instead of
1683 simple variables to record original value of point. (Bug#7952)
1684
afda1437
EZ
1685 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1686 produced by %s or %c overflows available buffer space. (Bug#8545)
1687
f76dee0c
PE
16882011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1691 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1692
fdc5744d
JB
16932011-04-28 Juanma Barranquero <lekktu@gmail.com>
1694
1695 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1696
638f053a
JB
16972011-04-28 Juanma Barranquero <lekktu@gmail.com>
1698
1699 * keyboard.c (Qdelayed_warnings_hook): Define.
1700 (command_loop_1): Run `delayed-warnings-hook'
1701 if Vdelayed_warnings_list is non-nil.
1702 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1703 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1704
d178f871
EZ
17052011-04-28 Eli Zaretskii <eliz@gnu.org>
1706
1707 * doprnt.c (doprnt): Don't return value smaller than the buffer
1708 size if the message was truncated. (Bug#8545).
1709
b124fd93
JB
17102011-04-28 Juanma Barranquero <lekktu@gmail.com>
1711
1712 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1713 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1714
e810457d
PE
17152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1718
ea51cceb
JB
17192011-04-27 Juanma Barranquero <lekktu@gmail.com>
1720
1721 * makefile.w32-in: Update dependencies.
1722
94dcfacf
EZ
17232011-04-27 Eli Zaretskii <eliz@gnu.org>
1724
1725 Improve `doprnt' and its usage. (Bug#8545)
1726 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1727 `format_end'. Remove support for %l as a conversion specifier.
1728 Don't use xrealloc. Improve diagnostics when the %l size modifier
1729 is used. Update the commentary.
1730
1731 * eval.c (verror): Simplify calculation of size_t.
1732
1733 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1734 messages.
1735
f61f41d7
PE
17362011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1737
1738 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1739 change.
1740
96fb4434
PE
17412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1744 This makes this file independent of the recent pseudovector change.
1745
671875da 17462011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1747
69e9b5a3
PE
1748 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1749
b5f869a7 1750 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1751 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1752 Remove unused local.
c8926152 1753 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1754
841a1577 1755 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1756 GCC 4.6.0 optimizes based on type-based alias analysis.
1757 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1758 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1759 != &v->size, and therefore "v->size = 1; b->size = 2; return
1760 v->size;" must therefore return 1. This assumption is incorrect
1761 for Emacs, since it type-puns struct Lisp_Vector * with many other
1762 types. To fix this problem, this patch adds a new type struct
f904488f 1763 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1764 and pseudovectors, and helps optimizing compilers not get fooled
1765 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1766 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1767 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1768 the size member.
eab3844f
PE
1769 (XSETPVECTYPE): Rewrite in terms of new macro.
1770 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1771 This is a bit clearer, and further avoids the possibility of
1772 undesirable aliasing.
1773 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1774 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1775 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1776 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1777 (ASIZE): Now uses header.size rather than size.
1778 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1779 to avoid the hassle of writing XVECTOR (foo)->header.size.
1780 (struct vectorlike_header): New type.
eab3844f
PE
1781 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1782 object, to help avoid aliasing.
1783 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1784 (SUBRP): Likewise, since Lisp_Subr is a special case.
1785 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1786 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1787 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1788 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1789 changed to be "header.size" and "header.next".
1790 * buffer.h (struct buffer): Likewise.
1791 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1792 * frame.h (struct frame): Likewise.
1793 * process.h (struct Lisp_Process): Likewise.
1794 * termhooks.h (struct terminal): Likewise.
1795 * window.c (struct save_window_data, struct saved_window): Likewise.
1796 * window.h (struct window): Likewise.
1797 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1798 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1799 * buffer.c (init_buffer_once): Likewise.
1800 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1801 special case.
1802 * process.c (Fformat_network_address): Use local var for size,
1803 for brevity.
1804
0df1eac5
PE
1805 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1806
847ab9d1 1807 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1808 * data.c (atof): Remove decl; no longer used or needed.
1809 (digit_to_number): Move to lread.c.
1810 (Fstring_to_number): Use new string_to_number function, to be
1811 consistent with how the Lisp reader treats infinities and NaNs.
1812 Do not assume that floating-point numbers represent EMACS_INT
1813 without losing information; this is not true on most 64-bit hosts.
1814 Avoid double-rounding errors, by insisting on integers when
1815 parsing non-base-10 numbers, as the documentation specifies.
1816 * lisp.h (string_to_number): New decl, replacing ...
1817 (isfloat_string): Remove.
bc0a5c13 1818 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1819 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1820 appears to have been a coding error. Similarly, do not accept
1821 strings like +-1e0 as floating point numbers. Do not report
1822 overflow for integer overflows unless the base is not 10 which
1823 means we have no simple and reliable way to continue.
1824 Break out the floating-point parsing into a new
1825 function string_to_number, so that Fstring_to_number parses
1826 floating point numbers consistently with the Lisp reader.
04f2d78b 1827 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1828 (E_CHAR, EXP_INT): Remove, replacing with ...
1829 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1830 (string_to_number): New function, replacing isfloat_string.
1831 This function checks for valid syntax and produces the resulting
1832 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1833 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1834 so that overflow for non-base-10 numbers is reported only when
1835 there's no portable and simple way to convert to floating point.
452f4150 1836
67769ffc
PE
1837 * textprop.c (set_text_properties_1): Rewrite for clarity,
1838 and to avoid GCC warning about integer overflow.
1839
c20db43f
PE
1840 * intervals.h (struct interval): Use EMACS_INT for members
1841 where EMACS_UINT might cause problems. See
1842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1843 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1844 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1845 All uses changed.
37aa2f85
PE
1846 (offset_intervals): Tell GCC not to worry about length overflow
1847 when negating a negative length.
c20db43f 1848
2538aa2f
PE
1849 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1850 (overrun_check_free): Likewise.
1851
f2d3008d
PE
1852 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1853 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1854 word size.
1855
ec8df744
PE
1856 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1857 (gnutls_make_error): Rename local to avoid shadowing.
1858 (gnutls_emacs_global_deinit): ifdef out; not used.
1859 (Fgnutls_boot): Use const for pointer to readonly storage.
1860 Comment out unused local. Fix pointer signedness problems.
1861
640ee02d
PE
1862 * lread.c (openp): Don't stuff size_t into an 'int'.
1863 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1864 about possible signed overflow.
1865
6048fb2a
PE
1866 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1867 (GDK_KEY_g): Don't define if already defined.
1868 (xg_prepare_tooltip): Avoid pointer signedness problem.
1869 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1870
fa3c87e1
PE
1871 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1872 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1873
2172544b
PE
1874 * xfns.c (Fx_window_property): Simplify a bit,
1875 to make a bit faster and to avoid GCC 4.6.0 warning.
1876 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1877
9b821a21
PE
1878 * fns.c (internal_equal): Don't assume size_t fits in int.
1879
3c616cfa
PE
1880 * alloc.c (compact_small_strings): Tighten assertion a little.
1881
c2982e87
PE
1882 Replace pEd with more-general pI, and fix some printf arg casts.
1883 * lisp.h (pI): New macro, generalizing old pEd macro to other
1884 conversion specifiers. For example, use "...%"pI"d..." rather
1885 than "...%"pEd"...".
1886 (pEd): Remove. All uses replaced with similar uses of pI.
1887 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1888 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1889 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1890 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1891 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1892 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1893 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1894 64-bit hosts.
1895 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1896 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1897 * print.c (safe_debug_print, print_object): Likewise.
1898 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1899 to int.
6f04d126
PE
1900 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1901 avoiding the 0 flag, which is not portable.
c2982e87
PE
1902 * process.c (Fmake_network_process): Use pI to avoid cast.
1903 * region-cache.c (pp_cache): Likewise.
1904 * xdisp.c (decode_mode_spec): Likewise.
1905 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1906 behavior on 64-bit hosts with printf arg.
6f04d126 1907 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1908 (x_stop_queuing_selection_requests): Likewise.
1909 (x_get_window_property): Don't truncate byte count to an 'int'
1910 when tracing.
0b432f21 1911
5e073ec7
PE
1912 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1913 here, since it parses constructs like leading '-' and spaces,
1914 which are not wanted; and it overflows with large numbers.
1915 Instead, simply match F[0-9]+, which is what is wanted anyway.
1916
36372bf9
PE
1917 * alloc.c: Remove unportable assumptions about struct layout.
1918 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1919 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1920 (allocate_vectorlike, make_pure_vector): Use the new macros,
1921 plus offsetof, to remove unportable assumptions about struct layout.
1922 These assumptions hold on all porting targets that I know of, but
1923 they are not guaranteed, they're easy to remove, and removing them
1924 makes further changes easier.
1925
0b432f21
PE
1926 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1927 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1928 (string_overrun_cookie): Now const. Use initializers that
1929 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1930 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1931 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1932 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1933 multiple of sizeof (EMACS_INT); it need not be, if
1934 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1935 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1936
895009e1
JB
19372011-04-26 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1940
6a7a1b0b
TZ
19412011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1942
1943 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1944 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1945 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1946
841a1577 19472011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1948
1949 * lisp.h (Qdebug): List symbol.
895009e1 1950 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1951 * keyboard.c (debug-on-event): New variable.
1952 (handle_user_signal): Break into debugger when debug-on-event
1953 matches the current signal symbol.
1954
f2d3ba6f
DN
19552011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1956
1957 * alloc.c (check_sblock, check_string_bytes)
1958 (check_string_free_list): Convert to standard C.
1959
42ce4c63
TZ
19602011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1961
1962 * w32.c (emacs_gnutls_push): Fix typo.
1963
825cd63c
EZ
19642011-04-25 Eli Zaretskii <eliz@gnu.org>
1965
fb11d64d
EZ
1966 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1967 "cast to pointer from integer of different size".
1968
825cd63c
EZ
1969 Improve doprnt and its use in verror. (Bug#8545)
1970 * doprnt.c (doprnt): Document the set of format control sequences
1971 supported by the function. Use SAFE_ALLOCA instead of always
1972 using `alloca'.
1973
1974 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1975 is one byte too soon. Don't use xrealloc; instead xfree and
1976 xmalloc anew.
1977
e061a11b
TZ
19782011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1979
1980 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1981 callbacks stage.
1982
1983 * gnutls.c: Renamed global_initialized to
1984 gnutls_global_initialized. Added internals for the
1985 :verify-hostname-error, :verify-error, and :verify-flags
1986 parameters of `gnutls-boot' and documented those parameters in the
1987 docstring. Start callback support.
1988 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1989 unless a fatal error occured. Call gnutls_alert_send_appropriate
1990 on error. Return error code.
1991 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1992 (emacs_gnutls_read): Likewise.
1993 (Fgnutls_boot): Return handshake error code.
1994 (emacs_gnutls_handle_error): New function.
1995 (wsaerror_to_errno): Likewise.
1996
1997 * w32.h (emacs_gnutls_pull): Add prototype.
1998 (emacs_gnutls_push): Likewise.
1999
2000 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2001 (emacs_gnutls_push): Likewise.
2002
20032011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2004
2005 * process.c (wait_reading_process_output): Check if GnuTLS
2006 buffered some data internally if no FDs are set for TLS
2007 connections.
2008
2009 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2010 (LIBS): Link to USER_LIBS.
2011 ($(BLD)/gnutls.$(0)): New target.
2012
fa6996bc
EZ
20132011-04-24 Eli Zaretskii <eliz@gnu.org>
2014
eb35682e
EZ
2015 * xdisp.c (handle_single_display_spec): Rename the
2016 display_replaced_before_p argument into display_replaced_p, to
2017 make it consistent with the commentary. Fix typos in the
2018 commentary.
2019
e2ad650c
EZ
2020 * textprop.c (syms_of_textprop): Remove dead code.
2021 (copy_text_properties): Delete obsolete commentary about an
2022 interface that was deleted long ago. Fix typos in the description
2023 of arguments.
2024
1b2de274
EZ
2025 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2026 to changes in oldXMenu/XMenu.h from 2011-04-16.
2027 <menu_help_message, prev_menu_help_message>: Constify.
2028 (IT_menu_make_room): menu->help_text is now `const char **';
2029 adjust.
2030
2031 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2032 to changes in oldXMenu/XMenu.h from 2011-04-16.
2033 (struct XMenu): Declare `help_text' `const char **'.
2034
2035 * xfaces.c <Qunspecified>: Make extern again.
2036
2037 * syntax.c: Include sys/types.h before including regex.h, as
2038 required by Posix.
2039
762b15be
EZ
2040 * doc.c (get_doc_string): Improve the format passed to `error'.
2041
2042 * doprnt.c (doprnt): Improve commentary.
2043
2044 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2045
2046 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2047 them with etags.
2048
f1052e5d
EZ
2049 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2050 changes in globals.h immediately force recompilation.
762b15be
EZ
2051 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2052 $(CURDIR)/s/ms-w32.h.
2053 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2054
fa6996bc
EZ
2055 * character.c (Fchar_direction): Function deleted.
2056 (syms_of_character): Don't defsubr it.
2057 <char-direction-table>: Deleted.
2058
e6c3da20
EZ
20592011-04-23 Eli Zaretskii <eliz@gnu.org>
2060
2061 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2062 * doprnt.c: Include limits.h.
2063 (SIZE_MAX): New macro.
04f2d78b
CB
2064 (doprnt): Return a size_t value. 2nd arg is now size_t.
2065 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2066 Improve overflow protection. Support `l' modifier for integer
2067 conversions. Support %l conversion. Don't assume an EMACS_INT
2068 argument for integer conversions and for %c.
2069
2070 * lisp.h (doprnt): Restore prototype.
2071
2072 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2073 $(SRC)/character.h.
2074
2075 * Makefile.in (base_obj): Add back doprnt.o.
2076
2077 * deps.mk (doprnt.o): Add back prerequisites.
2078 (callint.o): Depend on character.h.
2079
2080 * eval.c (internal_lisp_condition_case): Include the handler
2081 representation in the error message.
2082 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2083 when breaking from the loop.
2084
2085 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2086
2087 * callint.c (Fcall_interactively): When displaying error message
2088 about invalid control letter, pass the character's codepoint, not
2089 a pointer to its multibyte form. Improve display of the character
2090 in octal and display also its hex code.
2091
2092 * character.c (char_string): Use %x to display the (unsigned)
2093 codepoint of an invalid character, to avoid displaying a bogus
2094 negative value.
2095
2096 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2097 `error', not SYMBOL_NAME itself.
2098
2099 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2100 character arguments to `error'.
2101
2102 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2103 to `error' in error message about FINAL_CHAR argument. Make sure
2104 FINAL_CHAR is a character, and use %c when it is passed as
2105 argument to `error'.
2106
4ffd0d6b 21072011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2108
2109 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2110
2111 * w32.c: Include <time.h>.
2112 (sys_localtime): New function.
2113
4ffd0d6b 21142011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2115
2116 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2117
4ffd0d6b 2118 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2119
4ffd0d6b 21202011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2121
4ffd0d6b
GM
2122 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2123 zombies (Bug#8467).
aac0c6e3 2124
04c56954
EZ
21252011-04-19 Eli Zaretskii <eliz@gnu.org>
2126
2127 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2128 gl_state.e_property when gl_state.object is Qt.
2129
2130 * insdel.c (make_gap_larger): Remove limitation of buffer size
2131 to <= INT_MAX.
2132
16a43933
CY
21332011-04-18 Chong Yidong <cyd@stupidchicken.com>
2134
2135 * xdisp.c (lookup_glyphless_char_display)
2136 (produce_glyphless_glyph): Handle cons cell entry in
2137 glyphless-char-display.
2138 (Vglyphless_char_display): Document it.
2139
2140 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2141 glyphless-char-display.
2142
4581706e
CY
21432011-04-17 Chong Yidong <cyd@stupidchicken.com>
2144
2145 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2146
2147 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2148
2149 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2150 definition for no-X builds.
2151
4887c6e2 21522011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2153
fd35b6f9
PE
2154 Static checks with GCC 4.6.0 and non-default toolkits.
2155
5c1ccb01
PE
2156 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2157
006c5daa
PE
2158 * process.c (keyboard_bit_set): Define only if SIGIO.
2159 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2160 (send_process): Repair possible setjmp clobbering.
2161
efc736d3
PE
2162 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2163
4e2fe2e6
PE
2164 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2165
f97334a2
PE
2166 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2167
4e75f29d
PE
2168 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2169 Define only if needed.
2170
90efadd1
PE
2171 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2172 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2173 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2174
3c647824
PE
2175 * dispextern.h (struct redisplay_interface): Rename param
2176 to avoid shadowing.
e264f262 2177 * termhooks.h (struct terminal): Likewise.
761383f4 2178 * xterm.c (xembed_send_message): Likewise.
3c647824 2179
b58c5c4a
PE
2180 * insdel.c (make_gap_smaller): Define only if
2181 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2182
cad59032
PE
2183 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2184 it.
2185
c339dc2e
PE
2186 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2187 so that we aren't warned about unused symbols.
2188
91a3e27b
PE
2189 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2190
399c71d3 2191 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2192
8ffc96f5
PE
2193 * xfns.c (x_real_positions): Mark locals as initialized.
2194
eef9bc79
PE
2195 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2196
098db9dd
PE
2197 * xterm.c: Fix problems found by static analysis with other toolkits.
2198 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2199 (x_dispatch_event): Declare static if USE_GTK, and
2200 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2201 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2202 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2203 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2204 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2205
eb18f6cc
PE
2206 * xmenu.c (menu_help_callback): Pointer type fixes.
2207 Use const pointers when pointing at readonly data. Avoid pointer
2208 signedness clashes.
2209 (FALSE): Remove unused macro.
2210 (update_frame_menubar): Remove unused decl.
2211
1fe72bf8
PE
2212 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2213
60d9e1db
PE
2214 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2215 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2216 (single_menu_item): Rename local to avoid shadowing.
2217
39261c26
PE
2218 * keyboard.c (make_lispy_event): Remove unused local var.
2219
018c5e19
PE
2220 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2221 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2222
63d2b86e
PE
2223 * bitmaps: Change bitmaps from unsigned char back to the X11
2224 compatible char. Avoid the old compiler warnings about
2225 out-of-range initializers by using, for example, '\xab' rather
2226 than 0xab.
2227
aefd87e1
PE
2228 * xgselect.c (xgselect_initialize): Check vs interface
2229 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2230
bf501fb9
PE
2231 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2232
e9829fdf
PE
2233 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2234 to read-only memory.
2235
1086c095
PE
2236 * fns.c (vector): Remove; this old hack is no longer needed.
2237
2baccd04 2238 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2239 Remove unused var.
dde42981 2240 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2241
72391843 2242 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2243
436c16df 2244 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2245 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2246 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2247
92bb796d 2248 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2249 (x_term_init): Remove local to avoid shadowing.
92bb796d 2250
764430a3 2251 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2252
2253 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2254 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2255
d1dfb56c
EZ
22562011-04-16 Eli Zaretskii <eliz@gnu.org>
2257
c4354cb4
EZ
2258 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2259
d1dfb56c
EZ
2260 Fix regex.c, syntax.c and friends for buffers > 2GB.
2261 * syntax.h (struct gl_state_s): Declare character position members
2262 EMACS_INT.
2263
2264 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2265
04f2d78b
CB
2266 * textprop.c (verify_interval_modification, interval_of):
2267 Declare arguments EMACS_INT.
d1dfb56c
EZ
2268
2269 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2270 EMACS_INT.
2271
2272 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2273
2274 * indent.c (Fvertical_motion): Local variable it_start is now
2275 EMACS_INT.
2276
2277 * regex.c (re_match, re_match_2, re_match_2_internal)
2278 (bcmp_translate, regcomp, regexec, print_double_string)
2279 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2280 (re_compile_pattern, re_exec): Declare arguments and local
2281 variables `size_t' and `ssize_t' and return values `regoff_t', as
2282 appropriate.
2283 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2284 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2285 <compile_stack_type>: `size' and `avail' are now `size_t'.
2286
2287 * regex.h <regoff_t>: Use ssize_t, not int.
2288 (re_search, re_search_2, re_match, re_match_2): Arguments that
2289 specify buffer/string position and length are now ssize_t and
2290 size_t. Return type is regoff_t.
2291
613052cd
BK
22922011-04-16 Ben Key <bkey76@gmail.com>
2293
2294 * nsfont.m: Fixed bugs in ns_get_family and
2295 ns_descriptor_to_entity that were caused by using free to
2296 deallocate memory blocks that were allocated by xmalloc (via
2297 xstrdup). This caused Emacs to crash when compiled with
2298 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2299 --enable-checking=xmallocoverrun). xfree is now used to
2300 deallocate these memory blocks.
2301
4170f62f 23022011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2303
71b41406
PE
2304 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2305
9587a89d
PE
2306 emacs_write: Accept and return EMACS_INT for sizes.
2307 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2308 et seq.
2309 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2310 Accept and return EMACS_INT.
2311 (emacs_gnutls_write): Return the number of bytes written on
2312 partial writes.
2313 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2314 (emacs_read, emacs_write): Remove check for negative size, as the
2315 Emacs source code has been audited now.
9587a89d
PE
2316 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2317 (emacs_read, emacs_write): Use it.
273a5f82
PE
2318 * process.c (send_process): Adjust to the new signatures of
2319 emacs_write and emacs_gnutls_write. Do not attempt to store
2320 a byte offset into an 'int'; it might overflow.
9587a89d 2321 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2322
3e047f51
PE
2323 * sound.c: Don't assume sizes fit in 'int'.
2324 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2325 Return EMACS_INT, not int.
3e047f51 2326 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2327 Accept EMACS_INT, not int.
2328 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2329 record read return values.
2330
cc39a9db
BK
23312011-04-15 Ben Key <bkey76@gmail.com>
2332
c9d0ec6d
JB
2333 * keyboard.c (Qundefined): Don't declare static since it is used
2334 in nsfns.m.
2335 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2336 static since they are used in nsfont.m.
cc39a9db 2337
6c60eb9f
SM
23382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2339
2340 * process.c (Qprocessp): Don't declare static.
2341 * lisp.h (Qprocessp): Declare again.
2342
7990b61a
JB
23432011-04-15 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2346
5d4cb038
PE
23472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2348
8bd7b830 2349 Improve C-level modularity by making more things 'static'.
cd64ea1d 2350
e3b27b31
PE
2351 Don't publish debugger-only interfaces to other modules.
2352 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2353 (verify_bytepos, count_markers): Move decls to the only modules
2354 that need them.
2355 * region-cache.h (pp_cache): Likewise.
2356 * window.h (check_all_windows): Likewise.
2357 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2358
5d4cb038
PE
2359 * sysdep.c (croak): Now static, if
2360 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2361 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2362
2363 * alloc.c (refill_memory_reserve): Now static if
2364 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2365 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2366
e87b6180
PE
2367 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2368 Define only if USE_LUCID.
2369
ac64929e
PE
2370 * xrdb.c (x_customization_string, x_rm_string): Now static.
2371
6f37259d
PE
2372 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2373 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2374
1683e3ab
PE
2375 * xdisp.c (draw_row_with_mouse_face): Now static.
2376 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2377
de9c2632
PE
2378 * window.h (check_all_windows): Mark externally visible.
2379
2b96acb7
PE
2380 * window.c (window_deletion_count): Now static.
2381
2382 * undo.c: Make symbols static if they're not exported.
2383 (last_undo_buffer, last_boundary_position, pending_boundary):
2384 Now static.
2385
50436f33
PE
2386 * textprop.c (interval_insert_behind_hooks): Now static.
2387 (interval_insert_in_front_hooks): Likewise.
2388
64520e5c
PE
2389 * term.c: Make symbols static if they're not exported.
2390 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2391 (max_frame_lines, tty_set_terminal_modes):
2392 (tty_reset_terminal_modes, tty_turn_off_highlight):
2393 (get_tty_terminal): Now static.
2394 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2395 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2396 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2397 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2398 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2399
1fa53021
PE
2400 * sysdep.c: Make symbols static if they're not exported.
2401 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2402 Now static.
2403 (sigprocmask_set, full_mask): Remove; unused.
2404 (wait_debugging): Mark as visible.
2405 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2406 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2407
d4b43b22
PE
2408 * syntax.c (syntax_temp): Define only if !__GNUC__.
2409
b7c513d0
PE
2410 * sound.c (current_sound_device, current_sound): Now static.
2411
989b29ad
PE
2412 * search.c (searchbufs, searchbuf_head): Now static.
2413
13a55a78
PE
2414 * scroll.c (scroll_cost): Remove; unused.
2415 * dispextern.h (scroll_cost): Remove decl.
2416
de68a1fc
PE
2417 * region-cache.h (pp_cache): Mark as externally visible.
2418
40ccffa6
PE
2419 * process.c: Make symbols static if they're not exported.
2420 (process_tick, update_tick, create_process, chan_process):
2421 (Vprocess_alist, proc_buffered_char, datagram_access):
2422 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2423 (deactivate_process): Mark defn as static, as well as decl.
2424 * lisp.h (create_process): Remove decl.
2425 * process.h (chan_process, Vprocess_alist): Remove decls.
2426
ad64fc97
PE
2427 * print.c: Make symbols static if they're not exported.
2428 (print_depth, new_backquote_output, being_printed, print_buffer):
2429 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2430 (print_interval, print_number_index, initial_stderr_stream):
2431 Now static.
2432 * lisp.h (Fprinc): Remove decl.
2433 (debug_output_compilation_hack): Mark as externally visible.
2434
adddb265
PE
2435 * sysdep.c (croak): Move decl from here to syssignal.h.
2436 * syssignal.h (croak): Put it here, so the API can be checked when
2437 'croak' is called from dissociate_if_controlling_tty.
2438
1717ede2
PE
2439 * minibuf.c: Make symbols static if they're not exported.
2440 (minibuf_save_list, choose_minibuf_frame): Now static.
2441 * lisp.h (choose_minibuf_frame): Remove decl.
2442
fa5fb2bc
PE
2443 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2444
1e3890d1
PE
2445 * lread.c: Make symbols static if they're not exported.
2446 (read_objects, initial_obarray, oblookup_last_bucket_number):
2447 Now static.
2448 (make_symbol): Remove; unused.
2449 * lisp.h (initial_obarray, make_symbol): Remove decls.
2450
8a1414fa
PE
2451 * keyboard.c: Make symbols static if they're not exported.
2452 (single_kboard, recent_keys_index, total_keys, recent_keys):
2453 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2454 (this_single_command_key_start, echoing, last_auto_save):
2455 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2456 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2457 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2458 (Vlispy_mouse_stem, double_click_count):
2459 Now static.
2460 (force_auto_save_soon): Define only if SIGDANGER.
2461 (ignore_mouse_drag_p): Now static if
2462 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2463 (print_help): Remove; unused.
2464 (stop_character, last_timer_event): Mark as externally visible.
2465 * keyboard.h (ignore_mouse_drag_p): Declare only if
2466 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2467 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2468 * lisp.h (echoing): Remove decl.
2469 (force_auto_save_soon): Declare only if SIGDANGER.
2470 * xdisp.c (redisplay_window): Simplify code, to make it more
2471 obvious that ignore_mouse_drag_p is not accessed if !defined
2472 USE_GTK && !defined HAVE_NS.
2473
93ea6e8f
PE
2474 * intervals.c: Make symbols static if they're not exported.
2475 (merge_properties_sticky, merge_interval_right, delete_interval):
2476 Now static.
2477 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2478
77382fcc
PE
2479 * insdel.c: Make symbols static if they're not exported.
2480 However, leave prepare_to_modify_buffer alone. It's never
2481 called from outside this function, but that appears to be a bug.
2482 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2483 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2484 (adjust_after_replace_noundo): Remove; unused.
2485 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2486 (signal_before_change): Remove decls.
77382fcc 2487
9306c32e
PE
2488 * indent.c (val_compute_motion, val_vmotion): Now static.
2489
cd44d2eb
PE
2490 * image.c: Make symbols static if they're not exported.
2491 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2492 if USE_GTK.
2493 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2494 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2495
ad9a7a06
PE
2496 * fringe.c (standard_bitmaps): Now static.
2497 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2498
81626931
PE
2499 * frame.c: Make symbols static if they're not exported.
2500 (x_report_frame_params, make_terminal_frame): Now static.
2501 (get_frame_param): Now static, unless HAVE_NS.
2502 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2503 (x_get_resource_string): Remove; not used.
2504 * frame.h (make_terminal_frame, x_report_frame_params):
2505 (x_get_resource_string); Remove decls.
2506 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2507 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2508
239f9db9
PE
2509 * font.c, fontset.c: Make symbols static if they're not exported.
2510 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2511 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2512 * font.c (font_close_object): Now static.
2513 * font.h (font_close_object): Remove.
2514 * fontset.c (FONTSET_OBJLIST): Remove.
2515 (free_realized_fontset) #if-0 the body, which does nothing.
2516 (face_suitable_for_char_p): #if-0, as it's never called.
2517 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2518 * xfaces.c (face_at_string_position):
2519 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2520 since 0 is always ASCII.
2521
dfcf3579
PE
2522 * fns.c (weak_hash_tables): Now static.
2523
5045092b
PE
2524 * fileio.c: Make symbols static if they're not exported.
2525 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2526 (Vwrite_region_annotation_buffers): Now static.
2527
57a96f5c
PE
2528 * eval.c: Make symbols static if they're not exported.
2529 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2530 * lisp.h (backtrace_list): Remove decl.
2531
35f08c38
PE
2532 * emacs.c: Make symbols static if they're not exported.
2533 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2534 (fatal_error_code, fatal_error_signal_hook, standard_args):
2535 Now static.
2536 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2537 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2538 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2539 * lisp.h (fatal_error_signal_hook): Remove decl.
2540 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2541
f44bd759
PE
2542 * editfns.c: Move a (normally-unused) function to its only use.
2543 * editfns.c, lisp.h (get_operating_system_release): Remove.
2544 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2545 worth the hassle of breaking this out.
2546
b532497d
PE
2547 * xterm.c: Make symbols static if they're not exported.
2548 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2549 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2550 (x_destroy_window, x_delete_display):
2551 Now static.
2552 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2553 (x_mouse_leave): Remove; unused.
2554 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2555 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2556 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2557 Remove decls.
2558 (x_mouse_leave): Declare only if WINDOWSNT.
2559 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2560 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2561 USE_X_TOOLKIT.
2562
1675728f
PE
2563 * ftxfont.c: Make symbols static if they're not exported.
2564 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2565 HAVE_FREETYPE.
2566 * font.h (ftxfont_driver): Likewise.
2567
e4cebfca
PE
2568 * xfns.c: Make symbols static if they're not exported.
2569 (x_last_font_name, x_display_info_for_name):
2570 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2571 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2572 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2573 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2574 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2575 (last_show_tip_args): Now static.
2576 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2577 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2578 (x_screen_planes): Remove; unused.
2579 * dispextern.h (x_screen_planes): Remove decl.
2580
5bf46f05
PE
2581 * dispnew.c: Make symbols static if they're not exported.
2582 * dispextern.h (redraw_garbaged_frames, scrolling):
2583 (increment_row_positions): Remove.
2584 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2585 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2586 Now static.
2587 (redraw_garbaged_frames): Remove; unused.
2588
435f4c28
PE
2589 * xfaces.c: Make symbols static if they're not exported.
2590 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2591 Remove decls.
2592 * xterm.h (defined_color): Remove decls.
2593 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2594 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2595 (menu_face_changed_default, defined_color, free_realized_face):
2596 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2597 (ascii_face_of_lisp_face): Remove; unused.
2598
8524aef3
PE
2599 * xdisp.c: Make symbols static if they're not exported.
2600 * dispextern.h (scratch_glyph_row, window_box_edges):
2601 (glyph_to_pixel_coords, set_cursor_from_row):
2602 (get_next_display_element, set_iterator_to_next):
2603 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2604 (show_mouse_face): Remove decls
2605 * frame.h (message_buf_print): Likewise.
2606 * lisp.h (pop_message, set_message, check_point_in_composition):
2607 Likewise.
2608 * xterm.h (set_vertical_scroll_bar): Likewise.
2609 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2610 (message_buf_print, scratch_glyph_row, displayed_buffer):
2611 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2612 (get_next_display_element, show_mouse_face, window_box_edges):
2613 (frame_to_window_pixel_xy, check_point_in_composition):
2614 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2615 (glyph_to_pixel_coords): Remove; unused.
2616
16390cd2
PE
2617 * dired.c (file_name_completion): Now static.
2618
2619 * dbusbind.c (xd_in_read_queued_messages): Now static.
2620
a25f4dfa
PE
2621 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2622 * data.c (circular_list_error): Remove.
2623
14a9c8df
PE
2624 * commands.h (last_point_position, last_point_position_buffer):
2625 (last_point_position_window): Remove decls.
2626 * keyboard.c: Make these variables static.
2627
04f2d78b
CB
2628 * coding.h (coding, code_convert_region, encode_coding_gap):
2629 Remove decls.
74ab6df5
PE
2630 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2631 (iso_code_class, detect_coding, code_convert_region): Now static.
2632 (encode_coding_gap): Remove; unused.
2633
38dfbee1
PE
2634 * chartab.c (chartab_chars, chartab_bits): Now static.
2635
a2cb4e63
PE
2636 * charset.h (charset_iso_8859_1): Remove decl.
2637 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2638 Now static.
2639
127198fd
PE
2640 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2641 * ccl.c (Vccl_program_table): Now static.
2642 (check_ccl_update): Remove; unused.
2643
d85b608f
PE
2644 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2645 * category.h: ... from here.
2646 * category.c (check_category_table, set_category_set): Now static.
2647
31cd66f3
PE
2648 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2649 * lisp.h: Remove these decls.
2650
c358e587
PE
2651 * buffer.c (buffer_count): Remove unused var.
2652
e78aecca
PE
2653 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2654 so that it's not optimized away.
2655 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2656 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2657 exported only to the debugger.
2658
e192d7d3 2659 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2660 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2661
92470028
PE
2662 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2663 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2664 was inaccessible from Lisp.
2665 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2666 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2667
244ed907
PE
2668 alloc.c: Import and export fewer symbols, and remove unused items.
2669 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2670 is defined.
2671 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2672 it's not optimized away by whole-program optimization.
2673 (message_enable_multibyte, free_misc): Remove.
2674 (catchlist, handlerlist, mark_backtrace):
2675 Declare only if BYTE_MARK_STACK.
2676 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2677 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2678 (message_enable_multibyte): Remove decl.
2679 (free_misc, interval_free_list, float_block, float_block_index):
2680 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2681 (cons_free_list, last_marked_index):
2682 Now static.
2683 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2684 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2685 (mark_backtrace): Define only if BYTE_MARK_STACK.
2686 * xdisp.c (message_enable_multibyte): Now static.
2687
61c2b50e 2688 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2689 This makes it easier for human readers (and static analyzers)
2690 to see whether these variables are used from other modules.
2691 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2692 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2693 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2694 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2695 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2696 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2697 * xmenu.c, xselect.c:
2698 Declare Q* vars static if they are not used in other modules.
2699 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2700 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2701 Remove decls of unexported vars.
2702 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2703
95c82688
PE
2704 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2705
16a97296
PE
2706 Make Emacs functions such as Fatom 'static' by default.
2707 This makes it easier for human readers (and static analyzers)
2708 to see whether these functions can be called from other modules.
2709 DEFUN now defines a static function. To make the function external
2710 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2711 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2712 (Finit_image_library):
16a97296
PE
2713 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2714 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2715 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2716 Remove decls, since these functions are now static.
2717 (Funintern, Fget_internal_run_time): New decls, since these functions
2718 were already external.
95c82688 2719
16a97296
PE
2720 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2721 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2722 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2723 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2724 * keyboard.c, keymap.c, lread.c:
2725 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2726 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2727 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2728 Mark functions with DEFUE instead of DEFUN,
2729 if they are used in other modules.
2730 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2731 decls for now-static functions.
2732 * buffer.h (Fdelete_overlay): Remove decl.
2733 * callproc.c (Fgetenv_internal): Mark as internal.
2734 * composite.c (Fremove_list_of_text_properties): Remove decl.
2735 (Fcomposition_get_gstring): New forward static decl.
2736 * composite.h (Fcomposite_get_gstring): Remove decl.
2737 * dired.c (Ffile_attributes): New forward static decl.
2738 * doc.c (Fdocumntation_property): New forward static decl.
2739 * eval.c (Ffetch_bytecode): New forward static decl.
2740 (Funintern): Remove extern decl; now in .h file where it belongs.
2741 * fileio.c (Fmake_symbolic_link): New forward static decl.
2742 * image.c (Finit_image_library): New forward static decl.
2743 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2744 * intervals.h (Fprevious_property_change):
2745 (Fremove_list_of_text_properties): Remove decls.
2746 * keyboard.c (Fthis_command_keys): Remove decl.
2747 (Fcommand_execute): New forward static decl.
2748 * keymap.c (Flookup_key): New forward static decl.
2749 (Fcopy_keymap): Now static.
2750 * keymap.h (Flookup_key): Remove decl.
2751 * process.c (Fget_process): New forward static decl.
2752 (Fprocess_datagram_address): Mark as internal.
2753 * syntax.c (Fsyntax_table_p): New forward static decl.
2754 (skip_chars): Remove duplicate decl.
2755 * textprop.c (Fprevious_property_change): New forward static decl.
2756 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2757 Now internal.
2758 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2759 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2760
785bbd42
PE
2761 * editfns.c (Fformat): Remove unreachable code.
2762
8b913b57
AS
27632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2764
2765 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2766 change. (Bug#8496)
2767
a6744a35
EZ
27682011-04-13 Eli Zaretskii <eliz@gnu.org>
2769
2770 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2771 when at ZV. (Bug#8487)
2772
e7974947
AS
27732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2774
baad03f0
AS
2775 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2776 (Bug#8437)
2777 * keyboard.c (parse_tool_bar_item): Likewise.
2778 * sound.c (sound_cleanup, alsa_close): Likewise.
2779 * termcap.c (tgetent): Likewise.
2780 * xfns.c (x_default_font_parameter): Likewise.
2781 * xsettings.c (read_and_apply_settings): Likewise.
2782
e7974947
AS
2783 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2784 (overrun_check_free): Protoize.
2785
28272684
PE
27862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2787
2788 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2789 since callers should never pass a negative size.
2790 Change the signature to match that of plain 'read' and 'write'; see
2791 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2792 * lisp.h: Update prototypes of emacs_write and emacs_read.
2793
11997c76
EZ
27942011-04-11 Eli Zaretskii <eliz@gnu.org>
2795
2796 * xdisp.c (redisplay_window): Don't try to determine the character
2797 position of the scroll margin if the window start point w->startp
e896f03c 2798 is outside the buffer's accessible region. (Bug#8468)
11997c76 2799
8a2cbd72
EZ
28002011-04-10 Eli Zaretskii <eliz@gnu.org>
2801
2802 Fix write-region and its subroutines for buffers > 2GB.
2803 * fileio.c (a_write, e_write): Modify declaration of arguments and
2804 local variables to support buffers larger than 2GB.
2805 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2806
2807 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2808 argument, local variables, and return value.
2809
2810 * lisp.h: Update prototypes of emacs_write and emacs_read.
2811
2812 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2813
4073e537 28142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2815
1ebfdcb6
PE
2816 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2817
b2ded58d
PE
2818 Fix more problems found by GCC 4.6.0's static checks.
2819
7d66342c
PE
2820 * xdisp.c (vmessage): Use a better test for character truncation.
2821
bbf47d44
PE
2822 * charset.c (load_charset_map): <, not <=, for optimization,
2823 and to avoid potential problems with integer overflow.
9248994d 2824 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2825 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2826 * editfns.c (Fformat): Likewise.
1e69125e 2827 * syntax.c (skip_chars): Likewise.
3befa583 2828
e3019616
PE
2829 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2830 This also lets GCC 4.6.0 generate slightly better loop code.
2831
becfa255
PE
2832 * callint.c (Fcall_interactively): <, not <=, for optimization.
2833 (Fcall_interactively): Count the number of arguments produced,
2834 not the number of arguments given. This is simpler and lets GCC
2835 4.6.0 generate slightly better code.
2836
dae0cd48
PE
2837 * ftfont.c: Distingish more carefully between FcChar8 and char.
2838 The previous code passed unsigned char * to a functions like
2839 strlen and xstrcasecmp that expect char *, which does not
2840 conform to the C standard.
2841 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2842 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2843 char * when the C standard requires it.
2844
76032d70
PE
2845 * keyboard.c (read_char): Remove unused var.
2846
eb3f1cc8
PE
2847 * eval.c: Port to Windows vsnprintf (Bug#8435).
2848 Include <limits.h>.
2849 (SIZE_MAX): Define if the headers do not.
2850 (verror): Do not give up if vsnprintf returns a negative count.
2851 Instead, grow the buffer. This ports to Windows vsnprintf, which
2852 does not conform to C99. Problem reported by Eli Zaretskii.
2853 Also, simplify the allocation scheme, by avoiding the need for
2854 calling realloc, and removing the ALLOCATED variable.
2855
70476b54
PE
2856 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2857
12020a9e
PE
2858 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2859 But keep the doprint source code for now, as we might revamp it
2860 and use it again (Bug#8435).
ea6c7ae6
PE
2861 * lisp.h (doprnt): Remove.
2862 * Makefile.in (base_obj): Remove doprnt.o.
2863 * deps.mk (doprnt.o): Remove.
2864
5fdb398c
PE
2865 error: Print 32- and 64-bit integers portably (Bug#8435).
2866 Without this change, on typical 64-bit hosts error ("...%d...", N)
2867 was used to print both 32- and 64-bit integers N, which relied on
2868 undefined behavior.
2869 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2870 New macro.
2871 * lisp.h (error, verror): Mark as printf-like functions.
2872 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2873 Report overflow in size calculations when allocating printf buffer.
2874 Do not truncate output string at its first null byte.
2875 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2876 Truncate the output at a character boundary, since vsnprintf does not
2877 do that.
2878 * charset.c (check_iso_charset_parameter): Convert internal
2879 character to string before calling 'error', since %c now has the
2880 printf meaning.
2881 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2882 overflow when computing char to be passed to 'error'. Do not
2883 pass Lisp_Object to 'error'; pass the integer instead.
2884 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2885 formatted with plain %d.
2886
b189fa66
PE
2887 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2888
bff87ef0
PE
2889 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2890
7e2cac20
PE
2891 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2892
ce4d90b5
PE
2893 * xterm.c (x_catch_errors): Remove duplicate declaration.
2894
266c9547
PE
2895 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2896
79c49ad2
PE
2897 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2898
368f4090
JM
28992011-04-10 Jim Meyering <meyering@redhat.com>
2900
2901 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2902 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2903 return ssize_t not "int", and use size_t as the buffer length.
2904 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2905 * gnutls.h: Update declarations.
2906 * process.c (read_process_output): Use ssize_t, to match.
2907 (send_process): Likewise.
2908
a32d4040
CY
29092011-04-09 Chong Yidong <cyd@stupidchicken.com>
2910
2911 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2912
8546720e 29132011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2914
04f2d78b
CB
2915 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2916 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2917
8546720e
GM
2918 * xterm.c (handle_one_xevent):
2919 * xmenu.c (create_and_show_popup_menu):
2920 * xselect.c (x_decline_selection_request)
2921 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2922
0a2f5c1a 29232011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2924
2925 Fix some uses of `int' instead of EMACS_INT.
2926 * search.c (string_match_1, fast_string_match)
2927 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2928 (scan_buffer, find_next_newline_no_quit)
2929 (find_before_next_newline, search_command, Freplace_match)
2930 (Fmatch_data): Make some `int' variables be EMACS_INT.
2931
2932 * xdisp.c (display_count_lines): 3rd argument and return value now
2933 EMACS_INT. All callers changed.
2934 (pint2hrstr): Last argument is now EMACS_INT.
2935
2936 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2937 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2938 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2939 (decode_coding_utf_16, decode_coding_emacs_mule)
2940 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2941 (decode_coding_ccl, decode_coding_charset)
2942 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2943 (decode_coding_iso_2022, decode_coding_emacs_mule)
2944 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2945 <char_offset, last_offset>: Declare EMACS_INT.
2946 (encode_coding_utf_8, encode_coding_utf_16)
2947 (encode_coding_emacs_mule, encode_invocation_designation)
2948 (encode_designation_at_bol, encode_coding_iso_2022)
2949 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2950 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2951 Declare EMACS_INT.
2952 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2953 (encode_invocation_designation): Last argument P_NCHARS is now
2954 EMACS_INT.
2955 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2956 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2957
2958 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2959 All users changed.
2960
2961 * ccl.c (Fccl_execute_on_string): Declare some variables
2962 EMACS_INT.
2963
8546720e 29642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2965
2966 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2967
4e19a977
CS
29682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2969
2970 * process.c (Fformat_network_address): Doc fix.
2971
87302331
R
29722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2973
2974 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2975
cbb59342
CY
29762011-04-08 Chong Yidong <cyd@stupidchicken.com>
2977
2978 * keyboard.c (read_char): Call Lisp function help-form-show,
2979 instead of using internal_with_output_to_temp_buffer.
2980 (Qhelp_form_show): New var.
e0d38eeb 2981 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2982
2983 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2984
2985 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2986
e67a13ab
CY
29872011-04-06 Chong Yidong <cyd@stupidchicken.com>
2988
04f2d78b
CB
2989 * process.c (Flist_processes): Remove to Lisp.
2990 (list_processes_1): Delete.
e67a13ab 2991
973f782d
EZ
29922011-04-06 Eli Zaretskii <eliz@gnu.org>
2993
7c106b1e
EZ
2994 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2995
973f782d
EZ
2996 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2997
41cf7d1a 29982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2999
ca23cc88
PE
3000 Fix more problems found by GCC 4.6.0's static checks.
3001
f390e2d5
PE
3002 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3003
42eea0d0
PE
3004 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3005
b69769da 3006 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3007
f9541e84
PE
3008 * xdisp.c (vmessage): Mark as a printf-like function.
3009
13841b55
PE
3010 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3011
c136c10f
PE
3012 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3013
5e2d4a30
PE
3014 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3015 printf-like functions.
3016 (tiff_load): Add casts to remove these marks before passing them
3017 to system-supplied API.
3018
583f48b9
PE
3019 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3020
b25d760e
PE
3021 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3022 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3023 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3024 directly, rather than having caller test rule sign. This avoids
3025 some unnecessary tests.
3026 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3027 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3028 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3029
bc7b6697 3030 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3031 (xfont_open): Avoid unnecessary tests.
bc7b6697 3032
27ccc379
PE
3033 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3034
dcd5c89a
PE
3035 * composite.h, composite.c (composition_gstring_put_cache):
3036 Use EMACS_INT, not int, for length.
3037
b13a45c6
PE
3038 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3039 breaking out part of COMPOSITION_DECODE_RULE.
3040 (COMPOSITION_DECODE_RULE): Use it.
3041 * composite.c (get_composition_id): Remove unused local vars,
3042 by using the new macro.
3043
1e792e4d
PE
3044 * textprop.c (set_text_properties_1): Change while to do-while,
3045 since the condition is always true at first.
3046
dc6c6455 3047 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3048 (interval_deletion_adjustment): Return unsigned value.
3049 All uses changed.
dc6c6455 3050
aba7731a
PE
3051 * process.c (list_processes_1, create_pty, read_process_output):
3052 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3053 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3054 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3055 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3056 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3057
fdfc4bf3
PE
3058 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3059
fca8fe46 3060 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3061 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3062
06a0259a 3063 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3064 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3065 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3066
e7b9e80f
PE
3067 * print.c (print_error_message): Avoid int overflow.
3068
56201685
PE
3069 * font.c (font_list_entities): Redo for clarity,
3070 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3071
78834453 3072 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3073 (font_score): Avoid potential overflow in diff calculation.
78834453 3074
0bc0b309 3075 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3076 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3077
e610eaca
PE
3078 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3079
b895abce
PE
3080 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3081 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3082 can always succeed if overflow has undefined behavior.
3083
1f1d9321 3084 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3085 (wordify): Omit three unnecessary tests.
1f1d9321 3086
c59478bc
PE
3087 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3088 All callers changed. This avoids the need for an unused var.
3089
79b73827
PE
3090 * casefiddle.c (casify_region): Remove var that is set but not used.
3091
a4db5dfe
PE
3092 * dired.c (file_name_completion): Remove var that is set but not used.
3093
43aae36e
PE
3094 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3095
2a47c44d 3096 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3097 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3098
a37c69bf
PE
3099 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3100 Check for integer overflow on size calculations.
3101
328ab8e7
PE
3102 * buffer.c (Fprevious_overlay_change): Remove var that is set
3103 but not used.
3104
e5a2a5cb
PE
3105 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3106 Remove vars that are set but not used.
8d84a6eb 3107 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3108 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3109
a60e5f68
PE
3110 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3111
f661cb61 3112 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3113 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3114
f0397f5a
PE
3115 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3116 that are set but not used.
3117
8664db06 3118 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3119 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3120
6abdaa4a
PE
3121 * xselect.c (x_get_local_selection, x_handle_property_notify):
3122 Remove vars that are set but not used.
3123
0ce7538d 3124 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3125 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3126
9ae848fc
PE
3127 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3128 Remove var that is set but not used.
0b918413
PE
3129 (scroll_bar_windows_size): Now size_t, not int.
3130 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3131 Check for overflow.
9ae848fc 3132
a5a62657
PE
3133 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3134 (map_tty_color) [!defined MSDOS]: Likewise.
3135
5c5cdd39
PE
3136 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3137
66ebf983
PE
3138 * coding.c: Remove vars that are set but not used.
3139 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3140 All callers changed.
3141 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3142 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3143 (decode_coding_charset): Remove vars that are set but not used.
3144
1be4d761
PE
3145 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3146 that is set but not used.
3147
47553fa8
PE
3148 * print.c (print_object): Remove var that is set but not used.
3149
1f7196bf 3150 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3151 The gnulib version avoids calling malloc in the usual case,
3152 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3153 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3154 * filelock.c (current_lock_owner): Likewise.
3155 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3156 * sysdep.c: Include allocator.h, careadlinkat.h.
3157 (emacs_no_realloc_allocator): New static constant.
3158 (emacs_readlink): New function.
fdb61804
PE
3159 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3160 ../lib/careadlinkat.h.
d1fdcab7 3161
f84c17c7
SM
31622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3163
3164 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3165 first non-nil return value).
3166
ef3862ad
JD
31672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3168
3169 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3170 if not defined (Bug#8403).
3171
376a7006
JB
31722011-04-02 Juanma Barranquero <lekktu@gmail.com>
3173
3174 * xdisp.c (display_count_lines): Remove parameter `start',
3175 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3176 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3177 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3178 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3179 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3180 and thereabouts. All callers changed.
3181 (get_per_char_metric): Remove parameter `f', unused since
3182 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3183
6ca3801d
JM
31842011-04-02 Jim Meyering <meyering@redhat.com>
3185
3186 do not dereference NULL upon failed strdup
3187 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3188 (ns_get_family): Likewise.
3189
d8e2b5ba
JB
31902011-04-02 Juanma Barranquero <lekktu@gmail.com>
3191
3192 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3193
8c74fcbd
JD
31942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3195
3196 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3197 later (Bug#8403).
3198
7200d79c
SM
31992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3200
03408648 3201 Add lexical binding.
7200d79c 3202
03408648
SM
3203 * window.c (Ftemp_output_buffer_show): New fun.
3204 (Fsave_window_excursion):
3205 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3206
3207 * lread.c (lisp_file_lexically_bound_p): New function.
3208 (Fload): Bind Qlexical_binding.
3209 (readevalloop): Remove `evalfun' arg.
3210 Bind Qinternal_interpreter_environment.
3211 (Feval_buffer): Bind Qlexical_binding.
3212 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3213 Mark as dynamic.
3214 (syms_of_lread): Declare `lexical-binding'.
3215
3216 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3217
3218 * keyboard.c (eval_dyn): New fun.
3219 (menu_item_eval_property): Use it.
ca105506
SM
3220
3221 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3222
03408648
SM
3223 * fns.c (concat, mapcar1): Accept byte-code-functions.
3224
3225 * eval.c (Fsetq): Handle lexical vars.
3226 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3227 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3228 (FletX, Flet): Obey lexical binding.
3229 (Fcommandp): Handle closures.
3230 (Feval): New `lexical' arg.
3231 (eval_sub): New function extracted from Feval. Use it almost
3232 everywhere where Feval was used. Look up vars in lexical env.
3233 Handle closures.
3234 (Ffunctionp): Move from subr.el.
3235 (Ffuncall): Handle closures.
3236 (apply_lambda): Remove `eval_flags'.
3237 (funcall_lambda): Handle closures and new byte-code-functions.
3238 (Fspecial_variable_p): New function.
3239 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3240 but without exporting it to Lisp.
23aba0ea 3241
23aba0ea 3242 * doc.c (Fdocumentation, store_function_docstring):
03408648 3243 * data.c (Finteractive_form): Handle closures.
23aba0ea 3244
03408648
SM
3245 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3246 interactive spec.
ba83908c 3247
04f2d78b
CB
3248 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3249 New byte-codes.
03408648
SM
3250 (exec_byte_code): New function extracted from Fbyte_code to handle new
3251 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3252
03408648 3253 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3254
03408648 3255 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3256
e2abce01
JB
32572011-03-31 Juanma Barranquero <lekktu@gmail.com>
3258
3259 * xdisp.c (redisplay_internal): Fix prototype.
3260
63696a73 32612011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3262
63696a73 3263 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3264 (try_scrolling): Use it when setting scroll_limit.
3265 Limit scrolling to 100 screen lines.
63696a73
EZ
3266 (redisplay_window): Even when falling back on "recentering",
3267 position point in the window according to scroll-conservatively,
3268 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3269
3270 (try_scrolling): When point is above the window, allow searching
3271 as far as scroll_max, or one screenful, to compute vertical
3272 distance from PT to the scroll margin position. This prevents
3273 try_scrolling from unnecessarily failing when
3274 scroll-conservatively is set to a value slightly larger than the
3275 window height. Clean up the case of PT below the margin at bottom
3276 of window: scroll_max can no longer be INT_MAX. When aggressive
3277 scrolling is in use, don't let point enter the opposite scroll
3278 margin as result of the scroll.
3279 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3280 threshold of 100 lines for never-recentering scrolling.
3281
e4cc2dfc
JB
32822011-03-31 Juanma Barranquero <lekktu@gmail.com>
3283
3284 * dispextern.h (move_it_by_lines):
3285 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3286 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3287 (message_log_check_duplicate): Remove parameters `prev_bol' and
3288 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3289 (redisplay_internal): Remove parameter `preserve_echo_area',
3290 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3291
3292 * indent.c (Fvertical_motion):
3293 * window.c (window_scroll_pixel_based, Frecenter):
3294 Don't pass `need_y_p' to `move_it_by_lines'.
3295
1c470562
SM
32962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3297
44f230aa
SM
3298 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3299 steal a few bits to be more compact.
3300 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3301 Remove unneeded casts.
3302
1c470562
SM
3303 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3304
888adce9
ZK
33052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3306
3307 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3308 binding" message (bug#7967).
3309
f838ed7b
PE
33102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3311
77861b95
PE
3312 Fix more problems found by GCC 4.6.0's static checks.
3313
de6dbc14
PE
3314 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3315 Remove unused local var.
3316
f838ed7b
PE
3317 * editfns.c (Fmessage_box): Remove unused local var.
3318
792c7b2b
PE
3319 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3320 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3321 Omit unused local vars.
c499e557 3322 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3323 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3324 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3325 Omit unused local var.
3326
ba0165e1
PE
3327 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3328 Don't assume string length fits in int.
32ad8845 3329 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3330 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3331
3c59b4c9
PE
3332 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3333 instead of alloca (Bug#8344).
3334
a3eed478 3335 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3336 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3337
eb4d412d
PE
3338 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3339
1658b401
PE
3340 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3341 concerns.
3342
3343 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3344
3345 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3346
9a2c6e05
PE
3347 * keyboard.c (syms_of_keyboard): Use the same style as later
3348 in this function when indexing through an array. This also
3349 works around GCC bug 48267.
3350
03d0a109
PE
3351 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3352
44f730c8
PE
3353 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3354
fe75f926
PE
3355 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3356 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3357
ffa8c828
PE
3358 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3359 This avoids undefined behavior on integer overflow, and is a bit
3360 more convenient anyway since it is compared to a size_t variable.
3361
c5101a77
PE
3362 Variadic C functions now count arguments with size_t, not int.
3363 This avoids an unnecessary limitation on 64-bit machines, which
3364 caused (substring ...) to crash on large vectors (Bug#8344).
3365 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3366 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3367 All variadic functions and their callers changed accordingly.
c5101a77
PE
3368 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3369 * data.c (arith_driver, float_arith_driver): Likewise.
3370 * editfns.c (general_insert_function): Likewise.
3371 * eval.c (struct backtrace.nargs, interactive_p)
3372 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3373 (funcall_lambda, mark_backtrace): Likewise.
3374 * fns.c (concat): Likewise.
3375 * frame.c (x_set_frame_parameters): Likewise.
3376 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3377 0 if not found, not -1. All callers changed.
3378
dd3f25f7
PE
3379 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3380 (stack_copy_size): Now size_t, not int.
3381 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3382
461c2ab9
JB
33832011-03-28 Juanma Barranquero <lekktu@gmail.com>
3384
3385 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3386 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3387 All callers changed.
3388
3389 * lisp.h (multibyte_char_to_unibyte):
3390 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3391 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3392 * character.h (CHAR_TO_BYTE8):
3393 * cmds.c (internal_self_insert):
3394 * editfns.c (general_insert_function):
3395 * keymap.c (push_key_description):
3396 * search.c (Freplace_match):
3397 * xdisp.c (message_dolog, set_message_1): All callers changed.
3398
f6d62986
SM
33992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3400
3401 * keyboard.c (safe_run_hook_funcall): New function.
3402 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3403 don't set the hook to nil, but remove the offending function instead.
3404 (Qcommand_hook_internal): Remove, unused.
3405 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3406 Vcommand_hook_internal.
3407
3408 * eval.c (enum run_hooks_condition): Remove.
3409 (funcall_nil, funcall_not): New functions.
3410 (run_hook_with_args): Call each function through a `funcall' argument.
3411 Remove `cond' argument, now redundant.
3412 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3413 (Frun_hook_with_args_until_failure): Adjust accordingly.
3414 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3415
1db5b1ad
JB
34162011-03-28 Juanma Barranquero <lekktu@gmail.com>
3417
3418 * dispextern.h (string_buffer_position): Remove declaration.
3419
3420 * print.c (strout): Remove parameter `multibyte', unused since
3421 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3422
3423 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3424 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3425 All callers changed.
3426
3427 * w32.c (_wsa_errlist): Use braces for struct initializers.
3428
3429 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3430 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3431 All callers changed.
3432 (string_buffer_position): Likewise. Also, make static (it's never
3433 used outside xdisp.c).
3434 (cursor_row_p): Remove parameter `w', unused since
3435 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3436 (decode_mode_spec): Remove parameter `precision', introduced during
3437 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3438 All callers changed.
3439
5ffb62aa
JD
34402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3441
3442 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3443
461c2ab9 34442011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3445
3446 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3447 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3448 (ns_update_auto_hide_menu_bar): New functions.
3449 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3450 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3451 ns_constrain_all_frames.
3452 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3453 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3454
5c380ffb
JD
34552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3456
3457 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3458
9af30bdf
GM
34592011-03-27 Glenn Morris <rgm@gnu.org>
3460
3461 * syssignal.h: Replace RETSIGTYPE with void.
3462 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3463 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3464 Replace SIGTYPE with void everywhere.
3465 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3466 * s/template.h (SIGTYPE): Remove commented out definition.
3467
e2abce01
JB
34682011-03-26 Eli Zaretskii <eliz@gnu.org>
3469
3470 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3471 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3472
f868cd8a
JB
34732011-03-26 Juanma Barranquero <lekktu@gmail.com>
3474
59eb0929
JB
3475 * w32.c (read_unc_volume): Use parameter `henum', instead of
3476 global variable `wget_enum_handle'.
3477
3478 * keymap.c (describe_vector): Remove parameters `indices' and
3479 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3480 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3481
f868cd8a
JB
3482 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3483
3484 * keyboard.c (timer_check): Remove parameter `do_it_now',
3485 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3486 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3487 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3488
3489 * keyboard.c (read_char):
3490 * w32menu.c (w32_menu_display_help):
3491 * xmenu.c (show_help_event, menu_help_callback):
3492 Adjust calls to `show_help_echo'.
3493
3494 * gtkutil.c (xg_maybe_add_timer):
3495 * keyboard.c (readable_events):
3496 * process.c (wait_reading_process_output):
3497 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3498
3499 * insdel.c (adjust_markers_gap_motion):
3500 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3501 (gap_left, gap_right): Don't call it.
3502
2ecf6fdb
CY
35032011-03-25 Chong Yidong <cyd@stupidchicken.com>
3504
3505 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3506 incurred during fontification.
3507
6b1f9ba4
JB
35082011-03-25 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3511 (DEFVAR_PER_BUFFER): Don't pass it.
3512
3513 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3514 (scrolling_window): Don't pass it.
3515
0f4a96b5
JB
35162011-03-25 Juanma Barranquero <lekktu@gmail.com>
3517
3518 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3519
3520 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3521 and `suffix'.
3522 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3523 of variables specific to SELinux and computation of `encoded_absname'.
3524
3525 * image.c (XPutPixel): Remove unused variable `height'.
3526
3527 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3528
3529 * unexw32.c (get_section_info): Remove unused variable `section'.
3530
3531 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3532 (system_process_attributes): Remove unused variable `sess'.
3533 (sys_read): Remove unused variable `err'.
3534
3535 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3536 (w32_wnd_proc): Remove unused variable `isdead'.
3537 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3538 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3539 (x_create_tip_frame): Remove unused variable `tem'.
3540
3541 * w32inevt.c (w32_console_read_socket):
3542 Remove unused variable `no_events'.
3543
3544 * w32term.c (x_draw_composite_glyph_string_foreground):
3545 Remove unused variable `width'.
3546
1149507c
JB
35472011-03-24 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * w32term.c (x_set_glyph_string_clipping):
3550 Don't pass uninitialized region to CombineRgn.
3551
9c88f339
JB
35522011-03-23 Juanma Barranquero <lekktu@gmail.com>
3553
3554 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3555 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3556 (Fx_close_connection): Remove unused variable `i'.
3557
3558 * w32font.c (w32font_draw): Return number of glyphs.
3559 (w32font_open_internal): Remove unused variable `i'.
3560 (w32font_driver): Add missing initializer.
3561
3562 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3563 (fill_in_menu): Remove unused variable `items_added'.
3564
3565 * w32term.c (last_mouse_press_frame): Remove static global variable.
3566 (w32_clip_to_row): Remove unused variable `f'.
3567 (x_delete_terminal): Remove unused variable `i'.
3568
3569 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3570 (NOTHING): Remove unused static global variable.
3571 (uniscribe_check_otf): Remove unused variable `table'.
3572 (uniscribe_font_driver): Add missing initializers.
3573
dee091a3
JD
35742011-03-23 Julien Danjou <julien@danjou.info>
3575
3576 * term.c (Fsuspend_tty, Fresume_tty):
3577 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3578 * window.c (temp_output_buffer_show):
3579 * insdel.c (signal_before_change):
3580 * frame.c (Fhandle_switch_frame):
3581 * fileio.c (Fdo_auto_save):
3582 * emacs.c (Fkill_emacs):
3583 * editfns.c (save_excursion_restore):
3584 * cmds.c (internal_self_insert):
3585 * callint.c (Fcall_interactively):
3586 * buffer.c (Fkill_all_local_variables):
3587 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3588 Use Frun_hooks.
0f4a96b5 3589 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3590 unconditionnaly since it does the check itself.
3591
2c520ab5 35922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3593
c9c49752
PE
3594 Fix more problems found by GCC 4.5.2's static checks.
3595
8abc3f12
PE
3596 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3597 the first time through the loop, since we know p0 < p1 then.
3598 This also avoids a gcc -Wstrict-overflow warning.
3599
a2d26660
PE
3600 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3601 leading to a memory leak, possible in functions like
3602 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3603 of objects (Bug#8318).
a2d26660 3604
916c72e9
PE
3605 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3606 that could (at least in theory) be that large.
3607
19ab8a18
PE
3608 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3609 This is less likely to overflow, and avoids undefined behavior if
3610 overflow does occur. All callers changed. Use strtoul to scan
3611 for the unsigned long integer.
b7cbbd6f
PE
3612 (pint2hrstr): Simplify and tune code slightly.
3613 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3614
f0641eff
PE
3615 * scroll.c (do_scrolling): Work around GCC bug 48228.
3616 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3617
7f650bb9
PE
3618 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3619 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3620 (validate_x_resource_name): Simplify count usage.
3621 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3622
37dd57d1
PE
3623 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3624 fail (Bug#8306).
81e56e61 3625
699979fc 3626 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3627
401bf9b4
PE
3628 * process.c (Fmake_network_process): Use socklen_t, not int,
3629 where POSIX says socklen_t is required in portable programs.
3630 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3631 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3632 (Fmake_network_process, server_accept_connection):
3633 (wait_reading_process_output, read_process_output):
3634 Likewise.
3635
b93aacde
PE
3636 * process.c: Rename or move locals to avoid shadowing.
3637 (list_processes_1, Fmake_network_process):
3638 (read_process_output_error_handler, exec_sentinel_error_handler):
3639 Rename or move locals.
4dc343ee 3640 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3641 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3642 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3643 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3644 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3645
af8a867c 3646 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3647 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3648 Include tparam.h instead, since it declares them.
af8a867c
PE
3649 * cm.h (PC): Remove extern decl; tparam.h now does this.
3650 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3651 * terminfo.c: Include tparam.h, to check interfaces.
3652 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3653 (tparam): Adjust signature to match interface in tparam.h;
3654 this removes some undefined behavior. Check that outstring and len
3655 are zero, which they always are with Emacs.
3656 * tparam.h (PC, BC, UP): New extern decls.
3657
0248044d 3658 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3659 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3660
8ff096c1 3661 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3662 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3663 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3664 (ftfont_list): Remove unused local.
49eaafba
PE
3665 (get_adstyle_property, ftfont_pattern_entity):
3666 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3667 Rename locals to avoid shadowing.
8ff096c1 3668
e2be39f6
PE
3669 * xfont.c (xfont_list_family): Mark var as initialized.
3670
c9735e30
PE
3671 * xml.c (make_dom): Now static.
3672
8f5201ae
PE
3673 * composite.c (composition_compute_stop_pos): Rename local to
3674 avoid shadowing.
b246f932
PE
3675 (composition_reseat_it): Remove unused locals.
3676 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3677 (composition_update_it): Mark var as initialized.
11b61122
PE
3678 (find_automatic_composition): Mark vars as initialized,
3679 with a FIXME (Bug#8290).
8f5201ae 3680
760fbc2c
PE
3681 character.h: Rename locals to avoid shadowing.
3682 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3683 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3684 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3685 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3686 to avoid shadowing.
3687
ff08eb85
PE
3688 * textprop.c (property_change_between_p): Remove; unused.
3689
fc7bf025
PE
3690 * intervals.c (interval_start_pos): Now static.
3691
235d7abc
PE
3692 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3693
44f230aa
SM
3694 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3695 Rename locals to avoid shadowing.
3e7d6594 3696
50060332
PE
3697 * sound.c (wav_play, au_play, Fplay_sound_internal):
3698 Fix pointer signedness.
d01f234b 3699 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3700 (wav_play): Initialize a variable to 0, to prevent undefined
3701 behavior (Bug#8278).
50060332 3702
c4fc4e30
PE
3703 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3704
918436ed
PE
3705 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3706
c939f91b
PE
3707 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3708 clobbering (Bug#8298).
b9c7f648
PE
3709 * sysdep.c (sys_subshell): Likewise.
3710 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3711
6bd8c144
PE
3712 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3713 This should get cleaned up, so that child_setup has the
3714 same signature on all platforms.
3715
7710357c 3716 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3717 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3718
c59da222
CY
37192011-03-22 Chong Yidong <cyd@stupidchicken.com>
3720
3721 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3722 not to be necessary, and produces flickering.
3723
66b87493
GM
37242011-03-20 Glenn Morris <rgm@gnu.org>
3725
3726 * config.in: Remove file.
3727
45b6f6d5
JB
37282011-03-20 Juanma Barranquero <lekktu@gmail.com>
3729
3730 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3731 are now in src/globals.h.
3732 (syms_of_minibuf): Remove spurious & from previous change.
3733
3ec03f7e
LL
37342011-03-20 Leo <sdl.web@gmail.com>
3735
3736 * minibuf.c (completing-read-function): New variable.
3737 (completing-read-default): Rename from completing-read.
3738 (completing-read): Call completing-read-function.
3739
b14e3e21
CY
37402011-03-19 Juanma Barranquero <lekktu@gmail.com>
3741
3742 * xfaces.c (Fx_load_color_file):
3743 Read color file from absolute filename (bug#8250).
3744
f2b726e6
JB
37452011-03-19 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * makefile.w32-in: Update dependencies.
3748
09f6ff02
EZ
37492011-03-17 Eli Zaretskii <eliz@gnu.org>
3750
3751 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3752
29a6015a
PE
37532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3754
a3a6c54e
PE
3755 Fix more problems found by GCC 4.5.2's static checks.
3756
b766f867
PE
3757 * process.c (make_serial_process_unwind, send_process_trap):
3758 (sigchld_handler): Now static.
3759
be02381c
PE
3760 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3761 That way, the code declares only the vars that it needs.
3762 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3763 * s/cygwin.h (PTY_ITERATION): Likewise.
3764 * s/darwin.h (PTY_ITERATION): Likewise.
3765 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3766
57048744
PE
3767 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3768 * process.c (allocate_pty): Don't declare stb unless it's needed.
3769
7914961c 3770 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3771 (CONSTANTLIM): Remove; unused.
3772 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3773 Define only if needed.
7914961c 3774
b3967b18
PE
3775 * unexelf.c (unexec): Name an expression,
3776 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3777 Use a different way to cause a compilation error if anyone uses
3778 n rather than nn, a way that does not involve shadowing.
73366a00 3779 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3780
29a6015a
PE
3781 * deps.mk (unexalpha.o): Remove; unused.
3782
43cfc33e 3783 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3784 * unexec.h: New file.
ce701a33
PE
3785 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3786 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3787 Depend on unexec.h.
3788 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3789 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3790 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3791 Change as necessary to match prototype in unexec.h.
ce701a33 3792
01f44d5a
PE
3793 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3794 shadowing.
4f63c6bb 3795 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3796
a6670b0b
PE
3797 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3798 Rename locals to avoid shadowing.
3799
cef2010d 3800 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3801 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3802
d4d7173a
PE
3803 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3804
f08b802a
PE
3805 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3806 warning when compiling print.c.
3807
3ddb0639
PE
3808 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3809 instead of using an uninitialized var.
5ad03b97 3810 (font_sort_entities): Mark var as initialized.
3ddb0639 3811
170a2692
PE
3812 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3813
e663c700
PE
3814 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3815 pointers to constants.
89bc529a 3816 (font_parse_fcname): Remove unused vars.
7b81e2d0 3817 (font_delete_unmatched): Now static.
ea838e10 3818 (font_get_spec): Remove; unused.
13a547c6
PE
3819 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3820 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3821 Rename or move locals to avoid shadowing.
e663c700 3822
2a80c887 3823 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3824 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3825
1384fa33 3826 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3827 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3828
8b2c52e9
PE
3829 * alloc.c (mark_backtrace): Move decl from here ...
3830 * lisp.h: ... to here, so that it can be checked.
3831
475545b5 3832 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3833 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3834 (lisp_indirect_variable): Name an expression,
3835 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3836 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3837
b1349114 3838 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3839 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3840 Use const pointer when appropriate.
b1349114 3841
a2928364
PE
3842 * lisp.h (get_system_name, get_operating_system_release):
3843 Move decls here, to check interfaces.
3844 * process.c (get_operating_system_release): Move decl to lisp.h.
3845 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3846 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3847 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3848 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3849 (Fformat_time_string, Fencode_time, Finsert_char):
3850 (Ftranslate_region_internal, Fformat):
3851 Rename or remove local vars to avoid shadowing.
9710023e 3852 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3853
a415e694
PE
3854 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3855 avoid shadowing.
3856
8ef4622d
PE
3857 * lisp.h (eassert): Check that the argument compiles, even if
3858 ENABLE_CHECKING is not defined.
3859
946f9a5b
PE
3860 * data.c (Findirect_variable): Name an expression, to avoid
3861 gcc -Wbad-function-cast warning.
112396d6 3862 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3863 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3864 (Fmake_variable_buffer_local, Fmake_local_variable):
3865 Mark variables as initialized.
52746918 3866 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3867
e5aab7e7 3868 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3869 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3870 Rename locals to avoid shadowing.
dff45157
PE
3871 (mark_stack): Move local variables into the #ifdef region where
3872 they're used.
7bc26fdb
PE
3873 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3874 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3875 needed otherwise.
3876 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3877 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3878 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3879
e5aab7e7
PE
3880 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3881 avoids undefined behavior in theory.
3882
4da60324
PE
3883 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3884
88043301
PE
3885 Use functions, not macros, for up- and down-casing (Bug#8254).
3886 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3887 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3888 to use the following functions instead of these macros.
3889 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3890 EMACS_INT, since callers assume the returned value fits in int.
3891 (upcase1): Likewise, for UPCASE_TABLE.
3892 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3893 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3894 the race-condition problem in the old DOWNCASE.
88043301 3895
19ed5445
PE
3896 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3897 Rename locals to avoid shadowing.
3898 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3899 (regex_compile, re_search_2, re_match_2_internal):
3900 Remove unused local vars.
952db0d7
PE
3901 (FREE_VAR): Rewrite so as not to use empty "else",
3902 which gcc can warn about.
da053e48 3903 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3904 (RETALLOC_IF): Define only if needed.
3905 (WORDCHAR_P): Likewise. This one is never needed, but is used
3906 only in a comment talking about a compiler bug, so put inside
3907 the #if 0 of that comment.
3908 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3909 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3910 Remove; unused.
19ed5445 3911
1f3561e4 3912 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3913 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3914 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3915
ded6f8f7
PE
3916 * search.c (simple_search): Remove unused var.
3917
dbd37a95
PE
3918 * dired.c (compile_pattern): Move decl from here ...
3919 * lisp.h: ... to here, so that it can be checked.
3920 (struct re_registers): New forward decl.
3921
7e47afad
PE
3922 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3923
85f24f61
PE
3924 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3925 All uses changed.
3926 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3927 Rename locals to avoid shadowing.
5671df8f 3928 (Fvertical_motion): Mark locals as initialized.
85f24f61 3929
181aa2be 3930 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3931 (casify_region): Mark local as initialized.
181aa2be 3932
930d429c
PE
3933 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3934
7082eac6
PE
3935 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3936 New macros, so that the caller can use some names other than
3937 gcpro1, gcpro2, etc.
3938 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3939 of the new macros.
3940 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3941 argument, for consistency with GCPRO2_VAR, etc: it is now the
3942 prefix of the variable, not the variable itself. All uses
3943 changed.
38b2c076
PE
3944 * dired.c (directory_files_internal, file_name_completion):
3945 Rename locals to avoid shadowing.
3946
15206ed9
PE
3947 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3948 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3949 dired.c's scmp function, had undefined behavior.
3950 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3951 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3952 * buffer.h: ... to here, because these macros use current_buffer,
3953 and the new implementation with inline functions needs to have
3954 current_buffer in scope now, rather than later when the macros
3955 are used.
3956 (downcase, upcase1): New static inline functions.
3957 (DOWNCASE, UPCASE1): Reimplement using these functions.
3958 This avoids undefined behavior in expressions like
3959 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3960 from race conditions in accessing the global variables
3961 case_temp1 and case_temp2.
3962 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3963 * lisp.h (case_temp1, case_temp2): Remove their decls.
3964 * character.h (ASCII_CHAR_P): Move from here ...
3965 * lisp.h: ... to here, so that the inline functions mentioned
3966 above can use them.
3967
4a6bea26
PE
3968 * dired.c (directory_files_internal_unwind): Now static.
3969
f14b7e14
PE
3970 * fileio.c (file_name_as_directory, directory_file_name):
3971 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3972 Now static.
2893f146
PE
3973 (file_name_as_directory): Use const pointers when appropriate.
3974 (Fexpand_file_name): Likewise. In particular, newdir might
3975 point at constant storage, so make it a const pointer.
fd4ead52 3976 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3977 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3978 signedness issues.
f839df0c
PE
3979 (Fset_file_times, Finsert_file_contents, auto_save_error):
3980 Rename locals to avoid shadowing.
f14b7e14 3981
5716756e 3982 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3983 (Ftry_completion, Fall_completions): Rename or remove locals
3984 to avoid shadowing.
5716756e 3985
b4c3046a
PE
3986 * marker.c (bytepos_to_charpos): Remove; unused.
3987
b45db522
PE
3988 * lisp.h (verify_bytepos, count_markers): New decls,
3989 so that gcc does not warn that these functions aren't declared.
3990
85876d07
PE
3991 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3992 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3993 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3994 (copy_text): Remove unused local var.
85876d07 3995
03d78a21 3996 * filelock.c (within_one_second): Now static.
b3dd38ab 3997 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3998
5df8f01b
PE
3999 * buffer.c (fix_overlays_before): Mark locals as initialized.
4000 (fix_start_end_in_overlays): Likewise. This function should be
4001 simplified by using pointers-to-pointers, but that's a different
4002 matter.
b1d876f1 4003 (switch_to_buffer_1): Now static.
8f54f30a
PE
4004 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4005 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4006
a70072c9 4007 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4008 Fix pointer signedness issue.
edced198
PE
4009 (sys_subshell): Mark local as volatile if checking for lint,
4010 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4011 (MAXPATHLEN): Define only if needed.
a70072c9 4012
a0977c44
PE
4013 * process.c (serial_open, serial_configure): Move decls from here ...
4014 * systty.h: ... to here, so that they can be checked.
4015
a884fdcc
PE
4016 * fns.c (get_random, seed_random): Move extern decls from here ...
4017 * lisp.h: ... to here, so that they can be checked.
4018
604efe86 4019 * sysdep.c (reset_io): Now static.
b8950c94 4020 (wait_for_termination_signal): Remove; unused.
604efe86 4021
38fc62d9
PE
4022 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4023 (copy_keymap_item, append_key, push_text_char_description):
4024 Now static.
1004a21a 4025 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4026 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4027 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4028 (describe_map_tree):
4029 Rename locals to avoid shadowing.
38fc62d9 4030
2f2650da
PE
4031 * keyboard.c: Declare functions static if they are not used elsewhere.
4032 (echo_char, echo_dash, cmd_error, top_level_2):
4033 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4034 (read_char, kbd_buffer_get_event, make_lispy_position):
4035 (make_lispy_event, make_lispy_movement, apply_modifiers):
4036 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4037 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4038 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4039 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4040 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4041
a053e86c 4042 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4043 (mark_kboards): Move decl here ...
4044 * alloc.c (mark_kboards): ... from here.
a053e86c 4045
4752793e
PE
4046 * lisp.h (force_auto_save_soon): New decl.
4047
74f10ca7 4048 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4049 (DEFINE_DUMMY_FUNCTION): New macro.
4050 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4051 Use it.
c03cd23f
PE
4052 (main): Add casts to avoid warnings
4053 if GCC considers string literals to be constants.
74f10ca7 4054
022e70d4
PE
4055 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4056
59d6fe83
PE
4057 * dbusbind.c: Pointer signedness fixes.
4058 (xd_signature, xd_append_arg, xd_initialize):
4059 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4060 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4061 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4062 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4063
78320123
PE
4064 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4065 if GCC considers string literals to be constants.
49cebcca 4066 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4067
35ac2a97
SM
40682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4069
fb103ca9
SM
4070 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4071 (print_preprocess, print_object): New macro to fix last change.
4072
35ac2a97
SM
4073 * print.c (print_preprocess): Don't forget font objects.
4074
62973b41
JB
40752011-03-16 Juanma Barranquero <lekktu@gmail.com>
4076
4077 * emacs.c (USAGE3): Doc fixes.
4078
0e48bb22
AS
40792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4080
4081 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4082 structure.
4083
7684e57b
JB
40842011-03-14 Juanma Barranquero <lekktu@gmail.com>
4085
4086 * lisp.h (VWindow_system, Qfile_name_history):
4087 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4088 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4089 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4090
4091 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4092 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4093
4094 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4095 * w32console.c (detect_input_pending, read_input_pending)
4096 (encode_terminal_code):
4097 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4098 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4099 (w32_system_caret_y, Qfile_name_history):
4100 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4101 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4102 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4103 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4104 * w32proc.c (Qlocal, report_file_error):
4105 * w32term.c (Vwindow_system, updating_frame):
4106 * w32uniscribe.c (initialized, uniscribe_font_driver):
4107 Remove unneeded extern declarations.
4108
2aa46d6c
CY
41092011-03-14 Chong Yidong <cyd@stupidchicken.com>
4110
c96bbc66 4111 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4112
cffc6f3b
CY
41132011-03-13 Chong Yidong <cyd@stupidchicken.com>
4114
4115 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4116 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4117 These macros can no longer be used for assignment.
4118
44f230aa
SM
4119 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4120 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4121 (record_buffer_markers, fetch_buffer_markers): New functions for
4122 recording and fetching special buffer markers.
4123 (set_buffer_internal_1, set_buffer_temp): Use them.
4124
4125 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4126
4127 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4128
4129 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4130 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4131
4132 * xdisp.c (hscroll_window_tree):
4133 (reconsider_clip_changes): Use PT instead of BUF_PT.
4134
d251f04b
EZ
41352011-03-13 Eli Zaretskii <eliz@gnu.org>
4136
4137 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4138 $(EMACS_ROOT)/lib/intprops.h.
4139
f0c77cd1
PE
41402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4141
3eca4629
PE
4142 Fix more problems found by GCC 4.5.2's static checks.
4143
7c86ee98
PE
4144 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4145 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4146 (xg_free_frame_widgets): Make it clear that a local variable is
4147 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4148 (gdk_window_get_screen): Make it clear that this macro is needed
4149 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4150 (int_gtk_range_get_value): New function, which avoids a diagnostic
4151 from gcc -Wbad-function-cast.
4152 (xg_set_toolkit_scroll_bar_thumb): Use it.
4153 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4154 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4155 (get_utf8_string, xg_get_file_with_chooser):
4156 Rename locals to avoid shadowing.
4157 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4158
41729b81
PE
4159 * xgselect.c (xg_select): Remove unused var.
4160
f0c77cd1
PE
4161 * image.c (four_corners_best): Mark locals as initialized.
4162 (gif_load): Initialize transparent_p to zero (Bug#8238).
4163 Mark another local as initialized.
ec6cf4c6 4164 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4165
ce0ad53d 4166 * image.c (clear_image_cache): Now static.
d5d5a617 4167 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4168 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4169 (x_edge_detection): Remove unnecessary cast that
4170 gcc -Wbad-function-cast diagnoses.
2037898d 4171 (gif_load): Fix pointer signedness.
6ae141d6
PE
4172 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4173 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4174
33383987 41752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4176
d32df629
PE
4177 Improve quality of tests for time stamp overflow.
4178 For example, without this patch (encode-time 0 0 0 1 1
4179 1152921504606846976) returns the obviously-bogus value (-948597
4180 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4181 reports time overflow. See
4182 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4183 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4184 * editfns.c: Include limits.h and intprops.h.
4185 (TIME_T_MIN, TIME_T_MAX): New macros.
4186 (time_overflow): Move earlier, to before first use.
4187 (hi_time, lo_time): New functions, for an accurate test for
4188 out-of-range times.
4189 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4190 (Fget_internal_run_time): Don't assume time_t fits in int.
4191 (make_time): Use list2 instead of Fcons twice.
4192 (Fdecode_time): More accurate test for out-of-range times.
4193 (check_tm_member): New function.
4194 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4195 (lisp_time_argument): Don't rely on undefined left-shift and
4196 right-shift behavior when checking for time stamp overflow.
8be6f318 4197
fe31d94c
PE
4198 * editfns.c (time_overflow): New function, refactoring common code.
4199 (Fformat_time_string, Fdecode_time, Fencode_time):
4200 (Fcurrent_time_string): Use it.
4201
8be6f318
PE
4202 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4203 * dired.c (make_time): Move to ...
4204 * editfns.c (make_time): ... here.
4205 * systime.h: Note the move.
4206
09d9db2c 42072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4208
126bc0dc
YM
4209 * fringe.c (update_window_fringes): Remove unused variables.
4210
c47cbdfd
YM
4211 * unexmacosx.c (copy_data_segment): Also copy __got section.
4212 (Bug#8223)
4213
7ac80be9
EZ
42142011-03-12 Eli Zaretskii <eliz@gnu.org>
4215
c96bbc66 4216 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4217 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4218 Constify `char *' arguments and their references according to
4219 prototypes in tparam.h.
4220
ecb0f94d 4221 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4222
7ac80be9
EZ
4223 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4224 Adapt all references accordingly.
4225
4226 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4227
ef1fd07e
TT
42282011-03-11 Tom Tromey <tromey@redhat.com>
4229
4230 * buffer.c (syms_of_buffer): Remove obsolete comment.
4231
7ef4b50c
EZ
42322011-03-11 Eli Zaretskii <eliz@gnu.org>
4233
4234 * termhooks.h (encode_terminal_code): Declare prototype.
4235
4236 * msdos.c (encode_terminal_code): Don't declare prototype.
4237
4238 * term.c (encode_terminal_code): Now external again, used by
4239 w32console.c and msdos.c.
4240
44f230aa
SM
4241 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4242 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4243
4b1ec863 42442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4245
1714f52b 4246 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4247
4b1ec863
PE
4248 * fringe.c (update_window_fringes): Mark locals as initialized
4249 (Bug#8227).
4250 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4251
524c7aa6
PE
4252 * alloc.c (mark_fringe_data): Move decl from here ...
4253 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4254 to check its interface.
4255 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4256
a5c0af81 4257 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4258 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4259 (fontset_font): Mark local as initialized.
a9a06e0b 4260 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4261
b4716021
PE
4262 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4263
811e9bac 4264 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4265 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4266 (x_own_selection, Fx_disown_selection_internal): Rename locals
4267 to avoid shadowing.
4268 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4269
7e3ab302
PE
4270 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4271 so that the caller can use some name other than gcpro1.
4272 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4273 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4274 (Fx_backspace_delete_keys_p):
4275 Use them to avoid shadowing, and rename vars to avoid shadowing.
4276 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4277 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4278 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4279 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4280 Remove unused locals.
7e3ab302
PE
4281 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4282 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4283 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4284 macros.
f78faa98 4285
e2b13473
PE
4286 * xterm.h (x_mouse_leave): New decl.
4287
77f23912
PE
4288 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4289 Remove unused functions.
cdf4ba58
PE
4290 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4291 (x_calc_absolute_position): Now static.
7411c686 4292 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4293 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4294 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4295 unless they are used.
38d0b34a
PE
4296 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4297 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4298 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4299 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4300 (x_error_catcher, x_connection_closed, x_error_handler):
4301 (x_error_quitter, xembed_send_message, x_iconify_frame):
4302 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4303 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4304 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4305
44f230aa
SM
4306 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4307 Rename or move locals to avoid shadowing.
6b463e58 4308 (tty_defined_color, merge_face_heights): Now static.
5967d051 4309 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4310 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4311 does not deduce is never used uninitialized.
73719eba
PE
4312 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4313 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4314
426994c3 4315 * terminal.c (store_terminal_param): Now static.
5489860b 4316
032f1620 4317 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4318 (set_frame_menubar): Remove unused local.
d4323972 4319 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4320 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4321 since they might point to immutable storage.
281585b0
PE
4322 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4323 since it's unused otherwise.
032f1620 4324
367c19e5 4325 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4326 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4327 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4328 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4329 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4330 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4331 does not deduce are never used uninitialized.
70739cbe 4332
07b48fa9
PE
4333 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4334
8868a238 4335 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4336 * window.c (window_loop, size_window):
4337 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4338
7e5cf297 4339 * window.c (display_buffer): Now static.
d6550a9f
PE
4340 (size_window): Mark variables that gcc -Wuninitialized
4341 does not deduce are never used uninitialized.
a586633d
PE
4342 * window.h (check_all_windows): New decl, to forestall
4343 gcc -Wmissing-prototypes diagnostic.
5b555da1 4344 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4345
f6095868
PE
4346 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4347 shadowing.
4348 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4349 Include <limits.h>.
4350 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4351 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4352 (load_charset_map): Mark variables that gcc -Wuninitialized
4353 does not deduce are never used uninitialized.
53df7c11 4354 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4355
f38b440c
PE
4356 * coding.c (coding_set_source, coding_set_destination):
4357 Use "else { /* comment */ }" rather than "else /* comment */;"
4358 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4359 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4360 a block, when the outer 'i' will do.
4361 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4362 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4363 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4364 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4365 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4366 Rename locals to avoid shadowing.
4367 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4368 * coding.c (emacs_mule_char, encode_invocation_designation):
4369 Now static, since they're not used elsewhere.
413bb2db 4370 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4371 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4372 (decode_coding_emacs_mule): Mark variables that gcc
4373 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4374 (detect_coding_iso_2022): Initialize a local variable that might
4375 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4376 this initialization is needed. (Bug#8211)
5f58e762
PE
4377 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4378 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4379 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4380 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4381 Remove unused macros.
f38b440c 4382
232b38b9 4383 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4384 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4385 * character.c (string_count_byte8): Likewise.
232b38b9 4386
fb90da1b
PE
4387 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4388 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4389
fb93dbc2
PE
4390 * chartab.c (copy_sub_char_table): Now static, since it's not used
4391 elsewhere.
5c156ace
PE
4392 (sub_char_table_ref_and_range, char_table_ref_and_range):
4393 Rename locals to avoid shadowing.
bbcd0949 4394 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4395
7d3b3862 4396 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4397 (BIDI_BOB): Remove unused macro.
7d3b3862 4398
6be7d3da
PE
4399 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4400 deduce are never used uninitialized.
c2ed9c8b 4401 * term.c (encode_terminal_code): Likewise.
6be7d3da 4402
75f8807f 4403 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4404
50938595
PE
4405 * tparam.h: New file.
4406 * term.c, tparam.h: Include it.
4407 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4408 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4409 Move these decls to tparam.h, and make them agree with what
4410 is actually in tparam.c. The previous trick of using incompatible
4411 decls in different modules does not conform to the C standard.
4412 All callers of tparam changed to use tparam's actual API.
4413 * tparam.c (tparam1, tparam, tgoto):
4414 Use const pointers where appropriate.
4415
fbceeba2
PE
4416 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4417 * cm.h (struct cm): Likewise.
4418 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4419 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4420 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4421 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4422 (turn_on_face, init_tty): Likewise.
4423 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4424
7f3f1250
PE
4425 * term.c (term_mouse_position): Rename local to avoid shadowing.
4426
e6ca6543
PE
4427 * alloc.c (mark_ttys): Move decl from here ...
4428 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4429
c40f8d15
AS
44302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4431
4432 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4433
cfe0661d
JB
44342011-03-09 Juanma Barranquero <lekktu@gmail.com>
4435
4436 * search.c (compile_pattern_1): Remove argument regp, unused since
4437 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4438 (compile_pattern): Don't pass it.
4439
0afb4571
J
44402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4441
4442 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4443 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4444 for ! HAVE_GTK3.
4445 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4446
4447 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4448
4449 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4450 gdk_window_get_screen, gdk_window_get_geometry,
4451 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4452 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4453 (xg_get_pixbuf_from_pixmap): New function.
4454 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4455 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4456 Call xg_get_pixbuf_from_pixmap instead of
4457 gdk_pixbuf_get_from_drawable.
4458 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4459 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4460 (xg_check_special_colors): Use GtkStyleContext and its functions
4461 for HAVE_GTK3.
4462 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4463 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4464 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4465 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4466 Call gtk_widget_get_preferred_size.
0afb4571
J
4467 (xg_frame_resized): gdk_window_get_geometry only takes 5
4468 parameters.
44f230aa
SM
4469 (xg_win_to_widget, xg_event_is_for_menubar):
4470 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4471 (xg_set_widget_bg): New function.
4472 (delete_cb): New function.
895009e1 4473 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4474 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4475 (xg_set_background_color): Call xg_set_widget_bg.
4476 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4477 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4478 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4479 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4480 if ! HAVE_GTK3.
4481 (update_frame_tool_bar): Call gtk_widget_hide.
4482 (xg_initialize): Use GDK_KEY_g.
4483
4484 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4485 if ! HAVE_GTK3
4486 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4487
4488 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4489 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4490 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4491
1c2cc4ef
JB
44922011-03-08 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * w32xfns.c (select_palette): Check success of RealizePalette against
4495 GDI_ERROR, not zero.
4496
33383987 4497See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4498
4499;; Local Variables:
4500;; coding: utf-8
aac0c6e3
MR
4501;; End:
4502
33383987 4503 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4504
4505 This file is part of GNU Emacs.
4506
4507 GNU Emacs is free software: you can redistribute it and/or modify
4508 it under the terms of the GNU General Public License as published by
4509 the Free Software Foundation, either version 3 of the License, or
4510 (at your option) any later version.
4511
4512 GNU Emacs is distributed in the hope that it will be useful,
4513 but WITHOUT ANY WARRANTY; without even the implied warranty of
4514 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4515 GNU General Public License for more details.
4516
4517 You should have received a copy of the GNU General Public License
4518 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.