* configure.in: Coalesce some function checking.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0e25d334
CY
12012-06-12 Chong Yidong <cyd@gnu.org>
2
3 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4 MagickMergeImageLayers is undefined. Use pixel pusher loop if
5 MagickExportImagePixels is undefined.
6
43682bb6
PE
72012-06-12 Paul Eggert <eggert@cs.ucla.edu>
8
9 * image.c (imagemagick_load_image): Remove unused label.
10
a9be7d2b
GM
112012-06-11 Glenn Morris <rgm@gnu.org>
12
13 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
14 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
15 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
16 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
17
3017f87f
SM
182012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
19
20 * alloc.c (make_byte_code): New function.
21 (Fmake_byte_code): Use it. Don't purify here.
22 * lread.c (read1): Use it as well to avoid extra allocation.
23
1b9b4cf4
CY
242012-06-11 Chong Yidong <cyd@gnu.org>
25
26 * image.c (imagemagick_load_image): Implement transparency.
27
95988fcf
AS
282012-06-10 Andreas Schwab <schwab@linux-m68k.org>
29
30 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
31 account for preceding backslashes. (Bug#11663)
32
cd4eb164
CY
332012-06-09 Chong Yidong <cyd@gnu.org>
34
35 * term.c: Support italics in capable terminals (Bug#9652).
36 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
37 (turn_on_face): Output using TS_enter_italic_mode if available.
38 Don't handle unused blinking and alt-charset cases.
39 (turn_off_face): Handle italic case; discard unused tty_blinking_p
40 and tty_alt_charset_p cases.
41 (tty_capable_p, init_tty): Support italics.
42
43 * termchar.h (struct tty_display_info): Add field for italics.
44 Remove unused blink field.
45
46 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
47 Handle slant.
48
49 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
50 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
51 tty_alt_charset_p. Add tty_italic_p.
52
ff88beb8
MA
532012-06-09 Michael Albinus <michael.albinus@gmx.de>
54
55 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
56 dbus_type_is_basic if available.
57 (xd_extract_signed, xd_extract_unsigned): Rename from
58 extract_signed and extract_unsigned, respectively. Adapt callers.
59
44286096
CY
602012-06-09 Chong Yidong <cyd@gnu.org>
61
1682701f
CY
62 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
63
44286096
CY
64 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
65 case (Bug#9752).
66
d86feb17
PE
672012-06-08 Paul Eggert <eggert@cs.ucla.edu>
68
69 * xdisp.c (vmessage): Treat frame message as multibyte.
70 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
71 would generate the diagnostic "Making \302\247 buffer-local while
72 let-bound!".
73
d5c20fe8
EZ
742012-06-08 Eli Zaretskii <eliz@gnu.org>
75
76 * dispnew.c (showing_window_margins_p): Undo last change, which
77 was done due to an inadvertent commit.
78 (adjust_frame_glyphs_for_frame_redisplay): Do call
79 showing_window_margins_p.
80
513749ee
SM
812012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
82
83 * eval.c (Fmake_var_non_special): New primitive.
84 (syms_of_eval): Defsubr it.
85 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
86
d4a8f5c1
JB
872012-06-08 Juanma Barranquero <lekktu@gmail.com>
88
89 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
90 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
91
8bbbc977
EZ
922012-06-08 Eli Zaretskii <eliz@gnu.org>
93
94 * alloc.c (allocate_vectorlike): Fix last change.
95
f3372c87
DA
962012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Block-based vector allocation of small vectors.
99 * lisp.h (struct vectorlike_header): New field `nbytes',
100 adjust comment accordingly.
101 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
102 to denote vector blocks. Adjust users (live_vector_p,
103 mark_maybe_pointer, valid_lisp_object_p) accordingly.
104 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
105 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
106 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
107 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
108 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
109 (roundup_size): New constant.
110 (struct vector_block): New data type.
111 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 112 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
113 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
114 (sweep_vectors): New functions.
115 (allocate_vectorlike): Return `zero_vector' as the only vector of
116 0 items. Allocate new vector from block if vector size is less than
117 or equal to VBLOCK_BYTES_MAX.
118 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
119 (init_alloc_once): Add call to init_vectors.
120
4f18a4ed
SM
1212012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
122
123 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
124
86f158bc
PE
1252012-06-07 Paul Eggert <eggert@cs.ucla.edu>
126
127 * doprnt.c (doprnt): Truncate multibyte char correctly.
128 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
129 would mishandle a string argument "Xc" if X was a multibyte
130 character of length 2: it would truncate after X's first byte
131 rather than including all of X.
132
c5cfcbe0
CY
1332012-06-06 Chong Yidong <cyd@gnu.org>
134
135 * buffer.c (word_wrap): Doc fix.
136
c05cf390
PE
1372012-06-04 Paul Eggert <eggert@cs.ucla.edu>
138
139 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
140
0c3461de
GM
1412012-06-03 Glenn Morris <rgm@gnu.org>
142
143 * xdisp.c (tool-bar-style): Doc fix.
144
c71232db
UM
1452012-06-03 Ulrich Müller <ulm@gentoo.org>
146
147 * Makefile.in (PAXCTL): Define.
148 (temacs$(EXEEXT)): Disable memory randomization for the temacs
149 binary via PaX flags if the paxctl utility is available.
150 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
151 Restore PaX flags to their default. (Bug#11398)
152
383f7350
CY
1532012-06-03 Chong Yidong <cyd@gnu.org>
154
155 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
156 buffer (Bug#11226).
157
5f2c76c6
CY
1582012-06-03 Chong Yidong <cyd@gnu.org>
159
160 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
161 (note_mode_line_or_margin_highlight): If there is no help echo,
162 use mode-line-default-help-echo. Handle the case where the mouse
163 position is past the end of the mode line string.
164
165 * buffer.c (buffer_local_value_1): New function, split from
166 Fbuffer_local_value; can return Qunbound.
167 (Fbuffer_local_value): Use it.
168 (Vmode_line_format): Docstring tweaks.
169
773d47f6
PE
1702012-06-02 Paul Eggert <eggert@cs.ucla.edu>
171
172 * sysdep.c (system_process_attributes): Improve comment.
173
f2d6a3df
SM
1742012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
175
176 * keyboard.c: Export real-this-command to Elisp.
177 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
178 and DEFVAR it. Update all users.
179
63810350
PE
1802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
181
7bd5c1f4
PE
182 * minibuf.c (Fassoc_string): Remove duplicate declaration.
183
63810350
PE
184 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
185 Convert pctcpu and pctmem to Lisp float properly.
186 Let the compiler fold better, as 100.0/0x8000 is exact.
187
a2821611
AS
1882012-06-02 Andreas Schwab <schwab@linux-m68k.org>
189
190 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
191 cons_block.
192
5fceba1d
PE
1932012-06-01 Paul Eggert <eggert@cs.ucla.edu>
194
195 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
196
c98ff5dd
DA
1972012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
198
199 For a 'struct window', replace some Lisp_Object fields to
200 bitfields where appropriate, remove unused fields.
201 * window.h (struct window): Remove unused 'last_mark_x' and
202 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
203 change it's type from Lisp_Object to bitfield.
204 Change type of 'force_start', 'optional_new_start',
205 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
206 fields from Lisp_Object to bitfield. Adjust users accordingly.
207
ca34e0be
PE
2082012-05-31 Paul Eggert <eggert@cs.ucla.edu>
209
210 Pacify gcc -Wdouble-precision when using Xaw.
211 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
212 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
213 Use 'float' consistently, rather than 'float' in most places
214 and 'double' in a couple of places.
215
efc00ab1 2162012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
217
218 * xdisp.c (handle_stop): Detect whether we have overlay strings
219 loaded by testing it->current.overlay_string_index to be
220 non-negative, instead of checking whether n_overlay_strings is
221 positive. (Bug#11587)
222
efc00ab1 2232012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
224
225 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
226
227 * doc.c (Fsubstitute_command_keys): Doc fix.
228
efc00ab1 2292012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
230
231 * search.c (search_buffer): Remove calls to
232 r_alloc_inhibit_buffer_relocation, as it is now called by
233 maybe_unify_char, which was the cause of relocation of buffer text
234 in bug#11519.
235
efc00ab1 2362012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
237
238 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
239 for the duration of call to load_charset, to avoid problems with
240 callers of maybe_unify_char that access buffer text through C
241 pointers.
242
243 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
244 decrement the inhibition flag, instead of just setting or
245 resetting it.
246
ba93a187
PE
2472012-05-31 Paul Eggert <eggert@cs.ucla.edu>
248
249 Remove obsolete '#define static' cruft.
250 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
251 This #undef was "temporary" in 2000; it is no longer needed
252 now that '#define static' has gone away.
253 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
254 (gray_bitmap_bits): Remove; no longer needed.
255 All uses replaced with definiens.
256 * xterm.c: Include "bitmaps/gray.xbm".
257
9e4bf381
PE
2582012-05-30 Paul Eggert <eggert@cs.ucla.edu>
259
260 Clean up __executable_start, monstartup when --enable-profiling.
261 The following changes affect the code only when profiling.
262 * dispnew.c (__executable_start): Rename from safe_bcopy.
263 Define only on platforms that need it.
264 * emacs.c: Include <sys/gmon.h> when profiling.
265 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
266 (__executable_start): Remove decl, since lisp.h does it now.
267 (safe_bcopy): Remove decl; no longer has that name.
268 (main): Coalesce #if into single bit of code, for simplicity.
269 Cast pointers to uintptr_t, since standard libraries want integers
270 and not pointers.
271 * lisp.h (__executable_start): New decl.
272
32d72c2f
GM
2732012-05-31 Glenn Morris <rgm@gnu.org>
274
275 * image.c (Fimagemagick_types): Doc fix.
276
baac5bc7
JM
2772012-05-30 Jim Meyering <meyering@redhat.com>
278
279 * callproc.c (Fcall_process_region): Include directory component
280 in mkstemp error message (Bug#11586).
281
72cb32cf
PE
2822012-05-30 Paul Eggert <eggert@cs.ucla.edu>
283
284 * alloc.c, lisp.h (make_pure_vector): Now static.
285
61b108cc
SM
2862012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
289 Move to byte-run.el.
290 (Fautoload): Do the hash-doc more carefully.
291 * data.c (Fdefalias): Purify definition, except for keymaps.
292 (Qdefun): Move from eval.c.
293 * lisp.h (Qdefun): Remove.
294 * lread.c (read1): Tiny simplification.
295
471fe23d
TN
2962012-05-29 Troels Nielsen <bn.troels@gmail.com>
297
934f3f58 298 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
299 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
300 Bug#9642, but explicitly check that the buffer the overlay would
301 be moved to is live and rearrange lines to make sure that errors
302 will not put the overlay in an inconsistent state.
303 (Fdelete_overlay): Cosmetics.
304
85d0efd1
EZ
3052012-05-28 Eli Zaretskii <eliz@gnu.org>
306
307 * w32term.c (my_bring_window_to_top): New function.
308 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
309 could be different from the original one.
310 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
311 (Bug#11513)
312
313 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
314 by calling BringWindowToTop.
315
316 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
317 (WM_EMACS_END): Increase by one.
318
da92a98c
PE
3192012-05-28 Paul Eggert <eggert@cs.ucla.edu>
320
321 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
322 This avoids undefined behavior that might cause the eassert
323 to not catch an out-of-range value.
324
74d1f848
JB
3252012-05-28 Juanma Barranquero <lekktu@gmail.com>
326
327 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
328 Update dependencies.
329
9e1a06fc
EZ
3302012-05-27 Eli Zaretskii <eliz@gnu.org>
331
332 * bidi.c (bidi_mirror_char): Fix last change.
333
f3dd7312
AS
3342012-05-27 Andreas Schwab <schwab@linux-m68k.org>
335
336 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
337 when referring to sectname field in printf format.
338
81899c91
PE
3392012-05-27 Paul Eggert <eggert@cs.ucla.edu>
340
57b81a9f
PE
341 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
342 Only r_alloc_inhibit_buffer_relocation needed to be added;
343 the others were already declared.
344
81899c91
PE
345 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
346 before checking whether it's out of range. Put the check inside
347 eassert. See
348 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
349
33017faf 3502012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
351
352 * callproc.c (Fcall_process): Restore a line that was accidentally
353 commented out in the 2011-02-13 change (bug#11547).
354
33017faf 3552012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
356
357 * lisp.h [REL_ALLOC]: Add prototypes for external functions
358 defined on ralloc.c.
359
360 * buffer.c [REL_ALLOC]: Remove prototypes of
361 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
362 they are now on lisp.h.
363
364 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
365
366 * search.c (search_buffer): Use it to inhibit relocation of buffer
367 text while re_search_2 is doing its job, because re_search_2 is
368 passed C pointers to buffer text. (Bug#11519)
369
23415acf
EZ
370 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
371 Update value to 24.
372
44e27368
EZ
373 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
374 state after an additional call to move_it_in_display_line_to, keep
375 the values of it->max_ascent and it->max_descent found for the
376 entire line.
377 (pos_visible_p): Revert the comparison against bottom_y to what it
378 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
379 (Bug#11464)
380
c1892f11
PE
3812012-05-26 Paul Eggert <eggert@cs.ucla.edu>
382
383 Fix coding-related core dumps with gcc -ftrapv.
384 The code was computing A - B, where A and B are pointers, and B is
385 random garbage. This can lead to core dumps on platforms that
386 have special pointer registers, and it also leads to core dumps on
387 x86-64 when compiled with gcc -ftrapv. The fix is to compute
388 A - B only when B is initialized properly.
389 * coding.c (coding_set_source, coding_set_destination): Return void.
390 (coding_change_source, coding_change_destinations): New functions,
391 with the old behaviors of coding_set_source and coding_set_destination.
392 All callers that need an offset changed to use these new functions.
393
eb7afdad
GM
3942012-05-26 Glenn Morris <rgm@gnu.org>
395
396 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
397
f12fdf02
EZ
3982012-05-26 Eli Zaretskii <eliz@gnu.org>
399
53a63be6 400 Extend mouse support on W32 text-mode console.
61b108cc
SM
401 * xdisp.c (draw_row_with_mouse_face):
402 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 403
eb3f6f01 404 * w32console.c: Include window.h.
61b108cc
SM
405 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
406 New functions.
eb3f6f01
EZ
407 (initialize_w32_display): Initialize mouse-highlight data.
408
53a63be6
EZ
409 * w32inevt.c: Include termchar.h and window.h.
410 (do_mouse_event): Support mouse-autoselect-window. When the mouse
411 moves, call note_mouse_highlight. If help_echo changed, call
412 gen_help_event to produce help-echo message in the echo area.
413 Call clear_mouse_face if mouse_face_hidden is set in the mouse
414 highlight info.
415
4cfd81f6
PE
4162012-05-26 Paul Eggert <eggert@cs.ucla.edu>
417
418 * lread.c (read1): Simplify slightly to avoid an overflow warning
419 with GCC 4.7.0 on x86-64.
420
4446092a
EZ
4212012-05-26 Eli Zaretskii <eliz@gnu.org>
422
423 * bidi.c (bidi_mirror_char): Revert last change: an int is
424 definitely wide enough here.
425
42b2a986 4262012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 427
42b2a986 428 Fix integer width and related bugs (Bug#9874).
eb106a49 429 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
430 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
431 (string_bytes, check_sblock, allocate_string_data):
432 (compact_small_strings, Fmake_bool_vector, make_string)
433 (make_unibyte_string, make_multibyte_string)
434 (make_string_from_bytes, make_specified_string)
435 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
436 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
437 (mark_vectorlike):
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 (allocate_pseudovector):
440 Use int, not EMACS_INT, where int is wide enough.
441 (inhibit_garbage_collection, Fgarbage_collect):
442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
443 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
444 int might not be wide enough.
445 (bidi_cache_search, bidi_cache_find, bidi_init_it)
446 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
447 (bidi_at_paragraph_end, bidi_find_paragraph_start)
448 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
449 (bidi_level_of_next_char, bidi_move_to_visually_next):
450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
451 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
452 (Fkill_buffer, Fset_buffer_major_mode)
453 (advance_to_char_boundary, Fbuffer_swap_text)
454 (Fset_buffer_multibyte, overlays_at, overlays_in)
455 (overlay_touches_p, struct sortvec, record_overlay_string)
456 (overlay_strings, recenter_overlay_lists)
457 (adjust_overlays_for_insert, adjust_overlays_for_delete)
458 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
459 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
460 (Foverlay_recenter, last_overlay_modification_hooks_used)
461 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
463 (validate_region): Omit unnecessary test for b <= e,
464 since that's guaranteed by the previous test.
d311d28c
PE
465 (adjust_overlays_for_delete): Avoid pos + length overflow.
466 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
467 (report_overlay_modification):
468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
469 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
470 Omit pointer cast, which isn't needed anyway, and doesn't work
471 after the EMACS_INT -> ptrdiff_t change.
02481186 472 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
473 * buffer.h: Adjust decls to match defn changes elsewhere.
474 (struct buffer_text, struct buffer):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
477 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
478 not int, to avoid needless 32-bit limit on 64-bit hosts.
479 (exec_byte_code): Use tighter memory-full test, one that checks
480 for alloca overflow. Don't compute the address of the object just
481 before an array, as that's not portable. Use EMACS_INT, not
482 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
483 * callint.c (Fcall_interactively):
484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
485 * callproc.c (call_process_kill, Fcall_process):
486 Don't assume pid_t fits into an Emacs fixnum.
487 (call_process_cleanup, Fcall_process, child_setup):
488 Don't assume pid_t fits into int.
489 (call_process_cleanup, Fcall_process, delete_temp_file)
490 (Fcall_process_region):
491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
492 (Fcall_process): Simplify handling of volatile integers.
493 Use int, not EMACS_INT, where int will do.
494 * casefiddle.c (casify_object, casify_region, operate_on_word)
495 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
497 (casify_object): Avoid integer overflow when overallocating buffer.
498 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 499 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
500 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
501 * category.h (CATEGORYP): Don't assume arg is nonnegative.
502 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
503 integers are now checked earlier. All uses replaced with XINT.
504 (ccl_driver):
505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
506 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
507 (ccl_driver, Fregister_code_conversion_map):
508 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
509 (resolve_symbol_ccl_program): Check that vector header is in range.
510 Always copy the vector, so that we can check its contents reliably
511 now rather than having to recheck each instruction as it's being
512 executed. Check that vector words fit in 'int'.
513 (ccl_get_compiled_code, Fregister_ccl_program)
514 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
515 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
516 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
517 contents are in range.
518 (Fccl_execute_on_string): Check that status is in range.
519 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
520 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
521 Accept and return EMACS_INT, not int, because callers can pass values
522 out of 'int' range.
523 (c_string_width, strwidth, lisp_string_width, chars_in_text)
524 (multibyte_chars_in_text, parse_str_as_multibyte)
525 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
526 (str_as_unibyte, str_to_unibyte, string_count_byte8)
527 (string_escape_byte8, Fget_byte):
528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 529 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
530 avoid mishandling large integers.
531 * character.h: Adjust decls to match defn changes elsewhere.
532 * charset.c (load_charset_map_from_file, find_charsets_in_text)
533 (Ffind_charset_region):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
536 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 537 Don't assume fixnum fits in int.
d311d28c
PE
538 (load_charset_map_from_vector, Fmap_charset_chars):
539 Remove now-unnecessary CHECK_NATNUMs.
540 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
541 Don't rely on undefined behavior with signed left shift overflow.
542 Don't assume unsigned int fits into fixnum, or that fixnum fits
543 into unsigned int. Don't require max_code to be a valid fixnum;
544 that's not true for gb10830 4-byte on a 32-bit host. Allow
545 invalid_code to be a cons, for the same reason. Require code_offset
546 to be a character. Avoid int overflow if max_char is close
547 to INT_MAX.
548 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
549 this is intended anyway and avoids some undefined behavior.
550 (load_charset_map): Pass unsigned, not int, as 2nd arg of
551 INDEX_TO_CODE_POINT, as that's what it expects.
552 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
553 * charset.h (DECODE_CHAR): Return int, not unsigned;
554 this is what was intended anyway, and it avoids undefined behavior.
555 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
556 integer-overflow issues.
557 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
558 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
559 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
560 * chartab.c (Fmake_char_table, Fset_char_table_range)
561 (uniprop_get_decoder, uniprop_get_encoder):
562 Don't assume fixnum fits in int.
563 * cmds.c (move_point): New function, that does the gist of
564 Fforward_char and Fbackward_char, but does so while checking
565 for integer overflow more accurately.
c96e5d6a 566 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
567 (Fforward_line, Fend_of_line, internal_self_insert)
568 (internal_self_insert):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 Fix a FIXME, by checking for integer overflow when calculating
571 target_clm and actual_clm.
572 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 573 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
574 (ASSURE_DESTINATION, coding_alloc_by_realloc)
575 (coding_alloc_by_making_gap, alloc_destination)
576 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
577 (encode_coding_utf_16, detect_coding_emacs_mule)
578 (decode_coding_emacs_mule, encode_coding_emacs_mule)
579 (detect_coding_iso_2022, decode_coding_iso_2022)
580 (encode_invocation_designation, encode_designation_at_bol)
581 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
582 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
583 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
584 (encode_coding_ccl, encode_coding_raw_text)
585 (detect_coding_charset, decode_coding_charset)
586 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
587 (produce_composition, produce_charset, produce_annotation)
588 (decode_coding, handle_composition_annotation)
589 (handle_charset_annotation, consume_chars, decode_coding_gap)
590 (decode_coding_object, encode_coding_object, detect_coding_system)
591 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
592 (code_convert_region, code_convert_string)
8f50130c
PE
593 (Fdefine_coding_system_internal)
594 (coding_set_source, coding_set_destination):
d311d28c
PE
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
597 (Fdefine_coding_system_internal):
598 Don't assume fixnums fit in int.
599 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 600 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
601 (Funencodable_char_position, Fcheck_coding_systems_region)
602 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 604 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 605 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 606 Don't access memory outside of the args array.
d311d28c 607 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
608 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
609 result of ENCODE_CHAR.
d311d28c
PE
610 * coding.h: Adjust decls to match defn changes elsewhere.
611 (struct coding_system):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 * composite.c (get_composition_id, find_composition)
614 (run_composition_function, update_compositions)
615 (compose_text, composition_gstring_put_cache)
616 (composition_gstring_p, composition_gstring_width)
617 (fill_gstring_header, fill_gstring_body, autocmp_chars)
618 (composition_compute_stop_pos, composition_reseat_it)
619 (composition_update_it, struct position_record)
620 (find_automatic_composition, composition_adjust_point)
621 (Fcomposition_get_gstring, Ffind_composition_internal):
622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
623 (update_compositions):
624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
625 * composite.h: Adjust decls to match defn changes elsewhere.
626 (struct composition):
627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
628 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
629 Do not attempt to compute the address of the object just before a
630 buffer; this is not portable.
631 (Faref, Faset):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 (Faset): Use int, not EMACS_INT, where int is wide enough.
634 (Fstring_to_number): Don't assume fixnums fit in int.
635 (Frem): Don't assume arg is nonnegative.
636 * dbusbind.c (xd_append_arg): Check for integers out of range.
637 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 638 (extract_signed, extract_unsigned): New functions.
243e0530
PE
639 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
640 (xd_get_connection_references): Return ptrdiff_t, not int.
641 All uses changed.
642 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
643 (xd_read_message_1):
644 Use int, not unsigned, where the dbus API uses int.
645 (Fdbus_message_internal): Don't overflow mtype.
646 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
647 * dired.c (directory_files_internal, file_name_completion, scmp)
648 (file_name_completion_stat):
649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
650 (file_name_completion): Don't overflow matchcount.
651 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
652 * dispextern.h: Adjust decls to match defn changes elsewhere.
653 (struct text_pos, struct glyph, struct bidi_saved_info)
654 (struct bidi_string_data, struct bidi_it, struct composition_it)
655 (struct it):
656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
657 (struct display_pos, struct composition_it, struct it):
658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
659 * dispnew.c (increment_matrix_positions)
660 (increment_row_positions, mode_line_string)
661 (marginal_area_string):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 663 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
665 (duration_to_sec_usec): New function, to check for overflow better.
666 (Fsleep_for, sit_for): Use it.
667 * doc.c (get_doc_string, store_function_docstring):
668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
669 (get_doc_string, Fsnarf_documentation):
670 Use int, not EMACS_INT, where int is wide enough.
671 (get_doc_string):
672 Use SAFE_ALLOCA, not alloca.
673 Check for overflow when converting EMACS_INT to off_t.
674 * doprnt.c (doprnt):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
677 Don't assume uid_t fits into fixnum.
678 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
679 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
680 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
681 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
682 (general_insert_function)
683 (Finsert_char, make_buffer_string, make_buffer_string_both)
684 (update_buffer_properties, Fbuffer_substring)
685 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
686 (Fsubst_char_in_region, check_translation)
687 (Ftranslate_region_internal, save_restriction_restore, Fformat)
688 (transpose_markers, Ftranspose_regions):
689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
690 (clip_to_bounds): Move to lisp.h as an inline function).
691 (Fconstrain_to_field): Don't assume integers are nonnegative.
692 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
693 (Fsubst_char_in_region, Fsave_restriction):
694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
695 (Femacs_pid): Don't assume pid_t fits into fixnum.
696 (lo_time): Use int, not EMACS_INT, when int suffices.
697 (lisp_time_argument): Check for usec out of range.
698 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
699 (Fuser_login_name, Fuser_full_name): Signal an error
700 if a uid argument is out of range, rather than relying on
701 undefined behavior.
c8d5c857
PE
702 (Fformat_time_string): Remove now-unnecessary check.
703 lisp_time_argument checks for out-of-range usec now.
243e0530 704 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
705 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
706 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
707 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
708 (init_cmdargs, Fdump_emacs):
709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
710 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
711 the bottom (typically) 32 bits of the fixnum.
712 * eval.c (specpdl_size, call_debugger):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 (when_entered_debugger, Fbacktrace_debug):
715 Don't assume fixnum can fit in int.
716 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
717 the object just before a buffer; this is not portable.
718 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
719 (grow_specpdl, unbind_to):
720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
721 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
722 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 723 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
724 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
725 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
727 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
728 (a_write, e_write):
729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
730 (Fcopy_file, non_regular_nbytes, read_non_regular)
731 (Finsert_file_contents):
732 Use int, not EMACS_INT, where int is wide enough.
733 (READ_BUF_SIZE): Verify that it fits in int.
734 (Finsert_file_contents): Check that counts are in proper range,
735 rather than assuming fixnums fit into ptrdiff_t etc.
736 Don't assume fixnums fit into int.
125b3835 737 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
738 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
739 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
740 (string_char_to_byte, string_byte_to_char)
741 (string_make_multibyte, string_to_multibyte)
742 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
743 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
744 (substring_both, Fdelete, internal_equal, Ffillarray)
745 (Fclear_string, mapcar1)
746 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
747 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
748 (larger_vector, make_hash_table, maybe_resize_hash_table)
749 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
750 (Fmaphash, secure_hash):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (concat): Check for string index and length overflow.
753 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
754 (Frequire):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 (larger_vector): New API (vec, incr_min, size_max) replaces old
757 one (vec, new_size, init). This catches size overflow.
758 INIT was removed because it was always Qnil.
759 All callers changed.
760 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
761 the upper bound on a hash table index size.
762 (make_hash_table, maybe_resize_hash_table): Use it.
763 (secure_hash): Computer start_byte and end_byte only after
764 they're known to be in ptrdiff_t range.
765 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
766 (Ffont_get_glyphs, Ffont_at):
767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
768 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
769 (Flist_fonts, Fopen_font):
770 Don't assume fixnum can fit in int.
771 (check_gstring): Don't assume index can fit in int.
772 (font_match_p): Check that fixnum is a character, not a nonnegative
773 fixnum, since the later code needs to stuff it into an int.
774 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
775 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
776 conversion overflow issues.
777 (Fopen_font): Check for integer out of range.
778 (Ffont_get_glyphs): Don't assume index can fit in int.
779 * font.h: Adjust decls to match defn changes elsewhere.
780 * fontset.c (reorder_font_vector): Redo score calculation to avoid
781 integer overflow.
782 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
783 printmax_t, where ptrdiff_t is wide enough.
784 (Finternal_char_font):
785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
786 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
787 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
788 (Fset_frame_position, x_set_frame_parameters)
789 (x_set_line_spacing, x_set_border_width)
790 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
791 Check that fixnums are in proper range for system types.
792 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
794 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
795 Use SAFE_ALLOCA_LISP, not alloca.
796 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
797 intptr_t is wide enough.
798 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
799 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
800 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
801 Check for fixnum out of range.
802 * ftfont.c (ftfont_list): Don't assume index fits in int.
803 Check that fixnums are in proper range for system types.
804 (ftfont_shape_by_flt):
805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
806 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
809 Check that fixnums are in proper range for system types.
810 * gnutls.h: Adjust decls to match defn changes elsewhere.
811 * gtkutil.c (xg_dialog_run):
812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
813 (update_frame_tool_bar):
814 Check that fixnums are in proper range for system types.
815 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 816 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
817 * indent.c (last_known_column, last_known_column_point):
818 (current_column_bol_cache):
819 (skip_invisible, current_column, check_display_width):
820 (check_display_width, scan_for_column, current_column_1)
821 (Findent_to, Fcurrent_indentation, position_indentation)
822 (indented_beyond_p, Fmove_to_column, compute_motion):
823 (Fcompute_motion, Fvertical_motion):
824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
825 (last_known_column_modified): Use EMACS_INT, not int.
826 (check_display_width):
827 (Fcompute_motion):
828 Check that fixnums and floats are in proper range for system types.
829 (compute_motion): Don't assume index or fixnum fits in int.
830 (compute_motion, Fcompute_motion):
831 Use int, not EMACS_INT, when it is wide enough.
832 (vmotion): Omit local var start_hpos that is always 0; that way
833 we don't need to worry about overflow in expressions involving it.
834 * indent.h: Adjust decls to match defn changes elsewhere.
835 (struct position):
836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
837 Use int, not EMACS_INT, where int is wide enough.
838 Remove unused members ovstring_chars_done and tab_offset;
839 all uses removed.
840 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
841 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
842 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
843 (make_gap, copy_text, insert, insert_and_inherit)
844 (insert_before_markers, insert_before_markers_and_inherit)
845 (insert_1, count_combining_before, count_combining_after)
846 (insert_1_both, insert_from_string)
847 (insert_from_string_before_markers, insert_from_string_1)
848 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
849 (adjust_after_replace, adjust_after_insert, replace_range)
850 (replace_range_2, del_range, del_range_1, del_range_byte)
851 (del_range_both, del_range_2, modify_region)
852 (prepare_to_modify_buffer, signal_before_change)
853 (signal_after_change, Fcombine_after_change_execute):
854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
855 * intervals.c (traverse_intervals, rotate_right, rotate_left)
856 (balance_an_interval, split_interval_right, split_interval_left)
857 (find_interval, next_interval, update_interval)
858 (adjust_intervals_for_insertion, delete_node, delete_interval)
859 (interval_deletion_adjustment, adjust_intervals_for_deletion)
860 (static_offset_intervals, offset_intervals)
861 (merge_interval_right, merge_interval_left, make_new_interval)
862 (graft_intervals_into_buffer, temp_set_point_both)
863 (temp_set_point, set_point, adjust_for_invis_intang)
864 (set_point_both, move_if_not_intangible, get_property_and_range)
865 (get_local_map, copy_intervals, copy_intervals_to_string)
866 (compare_string_intervals, set_intervals_multibyte_1):
867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
868 * intervals.h: Adjust decls to match defn changes elsewhere.
869 (struct interval):
870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
871 * keyboard.c (this_command_key_count, this_single_command_key_start)
872 (before_command_key_count, before_command_echo_length, echo_now)
873 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
874 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
875 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
876 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
878 (last_non_minibuf_size, last_point_position, echo_truncate)
879 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
880 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
881 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
882 (stuff_buffered_input):
883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
884 (last_auto_save, command_loop_1, read_char):
885 Use EMACS_INT, not int, to avoid integer overflow.
886 (record_char): Avoid overflow in total_keys computation.
887 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
888 * keyboard.h: Adjust decls to match defn changes elsewhere.
889 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
890 (Fkey_description, Fdescribe_vector, Flookup_key):
891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
892 (click_position): New function, to check that positions are in range.
893 (Fcurrent_active_maps):
894 (describe_command):
895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
896 (Faccessible_keymaps, Fkey_description):
897 (preferred_sequence_p):
898 Don't assume fixnum can fit into int.
899 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
900 Check for integer overflow in size calculations.
901 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
902 avoid mishandling large integers.
903 * lisp.h: Adjust decls to match defn changes elsewhere.
904 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
905 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
906 (struct Lisp_Marker):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
909 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
910 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
911 All callers changed.
912 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
913 Assume the arg has valid form, since it always does.
914 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
915 unsigned integer system type.
916 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
917 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
919 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
920 (duration_to_sec_usec): New decl.
921 * lread.c (read_from_string_index, read_from_string_index_byte)
922 (read_from_string_limit, readchar, unreadchar, openp)
923 (read_internal_start, read1, oblookup):
924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
925 (Fload, readevalloop, Feval_buffer, Feval_region):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 (openp): Check for out-of-range argument to 'access'.
928 (read1): Use int, not EMACS_INT, where int is wide enough.
929 Don't assume fixnum fits into int.
6efdadfd 930 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
931 (read_filtered_event): Use duration_to_sec_usec
932 to do proper overflow checking on durations.
d311d28c
PE
933 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
934 in size calculation.
935 (Fexecute_kbd_macro):
936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
937 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
938 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
939 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
940 (set_marker_both, set_marker_restricted_both, marker_position)
941 (marker_byte_position, Fbuffer_has_markers_at):
942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
943 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 944 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
945 It now merely ensures that the menu is large enough, without
946 necessarily growing it, as this avoids some integer overflow issues.
947 All callers changed.
948 (keymap_panes, parse_single_submenu, Fx_popup_menu):
949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
950 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
951 Use SAFE_ALLOCA_LISP, not alloca.
952 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
953 to EMACS_INT. Check that fixnums are in proper range for system types.
954 * minibuf.c (minibuf_prompt_width, string_to_object)
955 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
956 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
958 (get_minibuffer, read_minibuf_unwind):
959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
960 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
961 this simplifies overflow checking. All callers changed.
962 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
963 (Ftest_completion):
964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
965 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
966 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
967 Check that fixnums are in proper range for system types.
968 (Fx_create_frame, Fx_show_tip):
969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
970 * nsfont.m (ns_findfonts, nsfont_list_family):
971 Don't assume fixnum fits in long.
972 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
974 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
975 wide enough.
17fdb222 976 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
978 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
979 (PRINTDECLARE, PRINTPREPARE):
980 (strout, print_string):
981 (print, print_preprocess, print_check_string_charset_prop)
982 (print_object):
983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
984 (PRINTDECLARE):
985 (temp_output_buffer_setup, Fprin1_to_string, print_object):
986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
987 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 988 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 989 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
990 (print_error_message): Use SAFE_ALLOCA, not alloca.
991 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
992 (print_depth, new_backquote_output, print_number_index):
993 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
994 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
995 (Fset_process_window_size, Fformat_network_address)
996 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 997 (sigchld_handler):
d311d28c 998 Check that fixnums are in proper range for system types.
d44287d4 999 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1000 Check for process-ids out of pid_t range rather than relying on
1001 undefined behavior.
e4d81efc 1002 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1003 (Fformat_network_address, read_process_output, send_process)
1004 (Fprocess_send_region, status_notify):
1005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1006 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1007 (wait_reading_process_output, read_process_output, exec_sentinel):
1008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1009 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1010 (Faccept_process_output): Use duration_to_sec_usec to do proper
1011 overflow checking on durations.
dde14581
PE
1012 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1013 Don't assume pid_t fits in int.
02481186
PE
1014 * process.h (struct Lisp_Process): Members tick and update_tick
1015 are now of type EMACS_INT, not int.
b62b53e8
PE
1016 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1017 configured --with-wide-int.
d311d28c
PE
1018 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1019 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1020 * search.c (looking_at_1, string_match_1):
1021 (fast_string_match, fast_c_string_match_ignore_case)
1022 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1023 (scan_newline, find_before_next_newline, search_command)
1024 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1025 (set_search_regs, wordify):
1026 (Freplace_match):
1027 (Fmatch_data):
1028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1029 (string_match_1, search_buffer, set_search_regs):
1030 (Fmatch_data):
1031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1032 (wordify): Check for overflow in size calculation.
1033 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1034 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1035 Check that fixnums are in proper range for system types.
1036 * sound.c (struct sound_device)
1037 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1039 (Fplay_sound_internal):
1040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1041 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1042 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1043 (Fparse_partial_sexp):
1044 Don't assume fixnums can fit in int.
1045 (struct lisp_parse_state, find_start_pos, find_start_value)
1046 (find_start_value_byte, find_start_begv)
1047 (update_syntax_table, char_quoted, dec_bytepos)
1048 (find_defun_start, prev_char_comend_first, back_comment):
1049 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1050 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1052 (Finternal_describe_syntax_value): Check that match_lisp is a
1053 character, not an integer, since the code stuffs it into int.
1054 (scan_words, scan_sexps_forward):
1055 Check that fixnums are in proper range for system types.
1056 (Fforward_word):
1057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1058 (scan_sexps_forward):
1059 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1060 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1061 * syntax.h: Adjust decls to match defn changes elsewhere.
1062 (struct gl_state_s):
1063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1064 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1065 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1066 * sysdep.c (wait_for_termination_1, wait_for_termination)
1067 (interruptible_wait_for_termination, mkdir):
1068 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1069 (emacs_read, emacs_write):
1070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1071 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1072 and double all fit in int.
d311d28c
PE
1073 * term.c (set_tty_color_mode):
1074 Check that fixnums are in proper range for system types.
1075 * termhooks.h (struct input_event):
1076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1077 * textprop.c (validate_interval_range, interval_of)
1078 (Fadd_text_properties, set_text_properties_1)
1079 (Fremove_text_properties, Fremove_list_of_text_properties)
1080 (Ftext_property_any, Ftext_property_not_all)
1081 (copy_text_properties, text_property_list, extend_property_ranges)
1082 (verify_interval_modification):
1083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1084 (Fnext_single_char_property_change)
1085 (Fprevious_single_char_property_change):
1086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1087 (copy_text_properties):
1088 Check for integer overflow in index calculation.
d311d28c
PE
1089 * undo.c (last_boundary_position, record_point, record_insert)
1090 (record_delete, record_marker_adjustment, record_change)
1091 (record_property_change):
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1093 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1095 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1096 (Fx_hide_tip, Fx_file_dialog):
1097 * w32menu.c (set_frame_menubar):
1098 Use ptrdiff_t, not int, for consistency with rest of code.
1099 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1100 (select_window, Fdelete_other_windows_internal)
1101 (window_scroll_pixel_based, window_scroll_line_based)
1102 (Frecenter, Fset_window_configuration):
1103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1104 (Fset_window_hscroll, run_window_configuration_change_hook)
1105 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1106 (Fscroll_other_window, Frecenter):
d311d28c
PE
1107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1108 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1109 Don't assume fixnum fits in int.
1110 (Fset_window_scroll_bars):
1111 Check that fixnums are in proper range for system types.
1112 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1113 (string_pos, c_string_pos, number_of_chars, init_iterator)
1114 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1115 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1116 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1117 (face_before_or_after_it_pos, handle_invisible_prop)
1118 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1119 (display_prop_intangible_p, string_buffer_position_lim)
1120 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1121 (get_overlay_strings_1, get_overlay_strings)
1122 (iterate_out_of_display_property, forward_to_next_line_start)
1123 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1124 (get_next_display_element, set_iterator_to_next)
1125 (get_visually_first_element, compute_stop_pos_backwards)
1126 (handle_stop_backwards, next_element_from_buffer)
1127 (move_it_in_display_line_to, move_it_in_display_line)
1128 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1129 (add_to_log, message_dolog, message_log_check_duplicate)
1130 (message2, message2_nolog, message3, message3_nolog
1131 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1132 (current_message_1, truncate_echo_area, truncate_message_1)
1133 (set_message, set_message_1, store_mode_line_noprop)
1134 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1135 (text_outside_line_unchanged_p, check_point_in_composition)
1136 (reconsider_clip_changes)
1137 (redisplay_internal, set_cursor_from_row, try_scrolling)
1138 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1139 (redisplay_window, find_last_unchanged_at_beg_row)
1140 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1141 (trailing_whitespace_p, find_row_edges, display_line)
1142 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1143 (display_mode_element, store_mode_line_string)
1144 (pint2str, pint2hrstr, decode_mode_spec)
1145 (display_count_lines, display_string, draw_glyphs)
1146 (x_produce_glyphs, x_insert_glyphs)
1147 (rows_from_pos_range, mouse_face_from_buffer_pos)
1148 (fast_find_string_pos, mouse_face_from_string_pos)
1149 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 (safe_call, init_from_display_pos, handle_fontified_prop)
1152 (handle_single_display_spec, load_overlay_strings)
1153 (with_echo_area_buffer, setup_echo_area_for_printing)
1154 (display_echo_area, echo_area_display)
1155 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1156 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1157 (redisplay_window, dump_glyph_row, display_mode_line)
1158 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1159 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1161 (handle_single_display_spec, build_desired_tool_bar_string)
1162 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1163 (get_specified_cursor_type):
1164 Check that fixnums are in proper range for system types.
1165 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1166 (Flookup_image_map):
1167 Don't assume fixnums fit in int.
1168 (compare_overlay_entries):
1169 Avoid mishandling comparisons due to subtraction overflow.
1170 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1171 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1172 (handle_tool_bar_click):
1173 Use int, not unsigned, since we prefer signed and the signedness
1174 doesn't matter here.
1175 (get_next_display_element, next_element_from_display_vector):
1176 Use int, not EMACS_INT, when int is wide enough.
1177 (start_hourglass): Use duration_to_sec_usec to do proper
1178 overflow checking on durations.
1179 * xfaces.c (Fbitmap_spec_p):
1180 Check that fixnums are in proper range for system types.
1181 (compare_fonts_by_sort_order):
1182 Avoid mishandling comparisons due to subtraction overflow.
1183 (Fx_family_fonts, realize_basic_faces):
1184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1185 (Fx_family_fonts):
1186 Don't assume fixnum fits in int.
1187 Use SAFE_ALLOCA_LISP, not alloca.
1188 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1189 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1190 (face_at_buffer_position, face_for_overlay_string)
1191 (face_at_string_position):
1192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1193 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1194 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1195 (Fx_show_tip):
1196 Check that fixnums are in proper range for system types.
1197 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1198 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 (Fx_change_window_property): Don't assume fixnums fit in int.
1201 * xfont.c (xfont_chars_supported):
1202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1203 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1204 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1206 * xml.c (parse_region):
1207 * xrdb.c (magic_file_p):
1208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1209 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1210 (x_get_local_selection, x_reply_selection_request)
1211 (x_handle_selection_request, wait_for_property_change):
1212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1213 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1214 short is wide enough.
1215 (x_send_client_event): Don't assume fixnum fits in int.
1216 * xterm.c (x_x_to_emacs_modifiers):
1217 Don't assume EMACS_INT overflows nicely into int.
1218 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1219 may come from Lisp.
1220 (handle_one_xevent): NATNUMP can eval its arg twice.
1221 (x_connection_closed):
1222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1223 * xterm.h: Adjust decls to match defn changes elsewhere.
1224 (struct scroll_bar): Use struct vectorlike_header
1225 rather than rolling our own approximation.
1226 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1227
c6574eb5
GM
12282012-05-25 Glenn Morris <rgm@gnu.org>
1229
1230 * lisp.mk (lisp): Update for more files being compiled now.
1231
e8d32c7e
SM
12322012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1233
48def666
SM
1234 * lread.c: Remove `read_pure' which makes no difference.
1235 (read_pure): Remove var.
1236 (unreadpure): Remove function.
1237 (readevalloop): Don't call read_list with -1 flag.
1238 (read1, read_vector): Don't test read_pure any more.
1239 (read_list): Simplify.
1240
e8d32c7e
SM
1241 * fileio.c, character.h: Minor style tweaks.
1242
4b2addb7
DA
12432012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1244
1245 * window.h (clip_changed): Remove useless declaration.
1246
584461b2
JB
12472012-05-22 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1250 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1251
34374650
PE
12522012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 Remove src/m/*.
1255 This directory predates autoconf and is no longer needed nowadays.
1256 Move its few remaining bits of functionality to where they're needed.
1257 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1258 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1259 * m/template.h: Remove.
1260 * Makefile.in (M_FILE): Remove. All uses removed.
1261 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1262 * lisp.h (USE_LSB_TAG):
1263 * mem-limits.h (EXCEEDS_LISP_PTR):
1264 Use VAL_MAX, not VALBITS, in #if.
1265 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1266 (EMACS_UINT): Define unconditionally now.
1267 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1268 (BITS_PER_EMACS_INT): New constants, replacing
1269 what used to be in config.h, but not useful in #if.
1270 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1271 define them any more.
1272 (VAL_MAX): New macro.
1273 (VALMASK): Use it.
1274 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1275 BITS_PER_EMACS_INT, in #if.
1276 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1277 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1278 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1279 * s/ms-w32.h (DATA_START):
1280 Move here from removed file m/intel386.h.
1281 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1282 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1283
261cb4bb
PE
12842012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 Assume C89 or later.
1287 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1288 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1289 (xrealloc):
1290 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1291 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1292 * textprop.c, tparam.c (NULL): Remove.
1293 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1294 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1295 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1296 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1297 * xterm.c (input_signal_count): Assume volatile works.
1298
ff23cd9f
KB
12992012-05-21 Ken Brown <kbrown@cornell.edu>
1300
1301 * xgselect.c (xg_select): Fix first argument in call to 'select'
1302 (bug#11508).
1303
1b170bc6
KB
13042012-05-20 Ken Brown <kbrown@cornell.edu>
1305
1306 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1307 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1308
b2f4d39f
KB
13092012-05-19 Ken Brown <kbrown@cornell.edu>
1310
1311 * xfns.c (x_in_use): Remove `static' qualifier.
1312 * xterm.h (x_in_use): Declare.
1313 * xgselect.c: Include xterm.h.
1314 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1315 and `display_arg' (bug#9754).
1316
003fdae2
PE
13172012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1318
9232a6d9
PE
1319 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1320
003fdae2
PE
1321 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1322 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1323
784b56e2
EZ
13242012-05-18 Eli Zaretskii <eliz@gnu.org>
1325
1326 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1327
1328 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1329 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1330
1331 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1332 reference to image_cache->refcount.
1333 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1334
a0a79cde
JL
13352012-05-17 Juri Linkov <juri@jurta.org>
1336
1337 * search.c (Fword_search_regexp, Fword_search_backward)
1338 (Fword_search_forward, Fword_search_backward_lax)
1339 (Fword_search_forward_lax): Move functions to isearch.el
1340 (bug#10145, bug#11381).
1341
b0572523
PE
13422012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1345
9660f5fc
SM
13462012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1347
1348 * lread.c (init_obarray): Declare Qt and Qnil as special.
1349
4374de83
GM
13502012-05-14 Glenn Morris <rgm@gnu.org>
1351
1352 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1353 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1354
dc44c39a
PE
13552012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1356
078c97cb
PE
1357 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1358
dc44c39a
PE
1359 * unexaix.c: Port to more-recent AIX compilers.
1360 (report_error, report_error_1, make_hdr, copy_sym)
1361 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1362 Make arguments const char *, not char *, to avoid violations of C
1363 standard and to fix some AIX warnings reported by Gilles Pion.
1364
e18afed7 13652012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1366
1367 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1368 already have overlays loaded.
1369 (handle_single_display_spec): Before returning without displaying
1370 fringe bitmap, synchronize the bidi iterator with the main display
1371 iterator, by calling iterate_out_of_display_property.
1372 (iterate_out_of_display_property): Detect buffer iteration by
1373 testing that it->string is a Lisp string.
1374 (get_next_display_element): When the current object is exhausted,
1375 and there's something on it->stack, call set_iterator_to_next to
1376 proceed with what's on the stack, instead of returning zero.
1377 (set_iterator_to_next): If called at the end of a Lisp string,
1378 proceed to consider_string_end without incrementing string
1379 position. Don't increment display vector index past the end of
1380 the display vector. (Bug#11417)
c8fb9dc6
EZ
1381 (pos_visible_p): Don't report a position visible when move_it_to
1382 stopped at the last line of window, which happens to be scanned
1383 backwards by the bidi iteration. (Bug#11464)
ac268e67 1384
e18afed7 13852012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1386
1387 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1388 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1389 are on a TTY, and thus unable to display on the fringes.
1390 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1391 so we need to signal to the caller that this is a "replacing"
1392 display spec. This fixes display when the spec is invalid or we
1393 are on a TTY.
1394
e18afed7 13952012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1396
1397 * unexaix.c (make_hdr): Fix typo in prototype.
1398 This bug broke the build on AIX. Problem reported by Gilles Pion.
1399
9d0a235a
MA
14002012-05-14 Michael Albinus <michael.albinus@gmx.de>
1401
1402 * keyboard.c (kbd_buffer_get_event): Read special events also in
1403 batch mode. (Bug#11415)
1404
9e6b06ed
GM
14052012-05-12 Glenn Morris <rgm@gnu.org>
1406
1407 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1408
c1a1d7a3
EZ
14092012-05-12 Eli Zaretskii <eliz@gnu.org>
1410
1411 * lisp.mk (lisp): Add newcomment.elc.
1412
3fe7cdc8
GM
14132012-05-12 Glenn Morris <rgm@gnu.org>
1414
1415 * Makefile.in (MKDIR_P): New, set by configure.
1416 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1417
53f7d2c0
PE
14182012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 Remove unused function hourglass_started.
1421 * dispextern.h (hourglass_started):
1422 * w32fns.c (hourglass_started):
1423 * xdisp.c (hourglass_started): Remove.
1424
75aafb17
JB
14252012-05-10 Juanma Barranquero <lekktu@gmail.com>
1426
1427 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1428 Update dependencies.
1429
12959e8e
PE
14302012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1431
97107e2e
PE
1432 * xgselect.c (xg_select): Put maxfds+1 into a var.
1433 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1434
12959e8e
PE
1435 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1436
836d29b3
DA
14372012-05-10 Dave Abrahams <dave@boostpro.com>
1438
1439 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1440 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1441
5cb67954
MA
14422012-05-09 Michael Albinus <michael.albinus@gmx.de>
1443
1444 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1445 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1446 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1447 Initialize xd_registered_buses.
1448
3478ec45
PE
14492012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1450
b263a6b0
PE
1451 Untag more efficiently if USE_LSB_TAG.
1452 This is based on a proposal by YAMAMOTO Mitsuharu in
1453 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1454 For an admittedly artificial (nth 8000 longlist) benchmark on
1455 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1456 Emacs's overall text size by 1%.
1457 * lisp.h (XUNTAG): New macro.
1458 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1459 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1460 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1461 * eval.c (Fautoload):
1462 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1463 * frame.h (XFRAME): Use XUNTAG.
1464
3478ec45
PE
1465 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1466 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1467 Remove unportable assumptions about print widths of types like
1468 dbus_uint32_t.
1469 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1470 intptr_t when converting between pointer and integer, to avoid GCC
1471 warnings about wrong width.
1472
666b903b 14732012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1474
1475 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1476 stack for each reader_thread, instead of defaulting to 8MB
1477 determined by the linker. This avoids failures in creating
1478 subprocesses on Windows 7, see the discussion in this thread:
1479 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1480
b120cc17
JC
14812012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1482
1483 Fix up display of the *Minibuf-0* buffer in the mini window.
1484 * keyboard.c (read_char): Don't clear the echo area if there's no
1485 message to clear.
1486 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1487 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1488
9a4b36f8
MA
14892012-05-07 Michael Albinus <michael.albinus@gmx.de>
1490
1491 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1492 batch mode.
1493
e5f9458f
CY
14942012-05-06 Chong Yidong <cyd@gnu.org>
1495
1496 * lisp.mk (lisp): Update.
1497
eceeb5fc 14982012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1499
1500 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1501
71873e2b
SM
15022012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * data.c (PUT_ERROR): New macro.
1505 (syms_of_data): Use it. Add new error type `user-error'.
1506 * undo.c (user_error): New function.
1507 (Fprimitive_undo): Use it.
1508 * print.c (print_error_message): Adjust print style for `user-error'.
1509 * keyboard.c (user_error): New function.
1510 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1511
ab0fa4e4
PE
15122012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 Do not limit current-time-string to years 1000..9999.
1515 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1516 (Fcurrent_time_string): Support any year that is supported by the
1517 underlying localtime representation. Don't use asctime, as it
1518 has undefined behavior for years outside the range -999..9999.
1519
7ed806a7
PE
15202012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 Fix race conditions involving setenv, gmtime, localtime, asctime.
1523 Without this fix, interrupts could mess up code that uses these
1524 nonreentrant functions, since setting TZ invalidates existing
1525 tm_zone or tzname values, and since most of these functions return
1526 pointers to static storage.
1527 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1528 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1529 Grow the critical sections to include not just invoking
1530 localtime/gmtime, but also accessing these functions' results
1531 including their tm_zone values if any, and any related TZ setting.
1532 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1533 so that the struct tm is saved in the critical section.
1534 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1535 motivated by the fact that memory allocation needs to be outside
1536 the critical section.
1537
0c16dfed
DA
15382012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1541 with RESET_INTERVAL.
1542
1543 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1544 Remove duplicated buffer name initialization.
1545
3f83ace8
JM
15462012-05-02 Jim Meyering <jim@meyering.net>
1547
1548 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1549
c7b8541e
JM
1550 * xfns.c (x_window): Use xstrdup (Bug#11375).
1551
90207a15 15522012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1553
1554 * xdisp.c (pos_visible_p): If already at a newline from the
1555 display string before the 'while' loop, don't walk back the glyphs
1556 from it3.glyph_row. Solves assertion violation when the display
1557 string begins with a newline (egg.el). (Bug#11367)
1558
b593d6a9
AH
15592012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1560
1561 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1562 Move to simple.el.
1563
4737362e
GM
15642012-05-01 Glenn Morris <rgm@gnu.org>
1565
99cf43f9
GM
1566 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1567 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1568 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1569 All were removed before 23.1.
1570
9311dcff
GM
1571 * dispnew.c: Remove HAVE_LIBNCURSES test;
1572 it is always true on relevant platforms.
1573
4d5c6349
GM
1574 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1575 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1576
4737362e
GM
1577 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1578
74dd3a6b
AS
15792012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1580
1581 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1582 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1583 Remove.
1584
13c379ee
PE
15852012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 Do not avoid creating empty evaporating overlays (Bug#9642).
1588 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1589 That is, do not delete an evaporating overlay if it becomes
1590 empty after its bounds are adjusted to fit within its buffer.
1591 This fix caused other problems, and I'm reverting it until we get
1592 to the bottom of them.
1593
a8e7d6d7 15942012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1595
1596 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1597
a8e7d6d7 15982012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1599
1600 * xdisp.c (pos_visible_p): If the window start position is beyond
1601 ZV, start the display from buffer beginning. Prevents assertion
1602 violation in init_iterator when the minibuffer window is scrolled
1603 via the scroll bar.
1604
1605 * window.c (window_scroll_pixel_based): Likewise.
1606
a8e7d6d7 16072012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1608
1609 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1610
a8e7d6d7 16112012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1612
1613 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1614 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1615
a8e7d6d7 16162012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1617
b593d6a9
AH
1618 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1619 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1620
1c6900d9
EZ
16212012-04-26 Eli Zaretskii <eliz@gnu.org>
1622
4c3fa1d9
EZ
1623 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1624 display element, check also the underlying string or buffer
1625 character. (Bug#11341)
1626
1c6900d9
EZ
1627 * w32menu.c: Include w32heap.h.
1628 (add_menu_item): If the call to AppendMenuW (via
1629 unicode_append_menu) fails, disable Unicode menus only if we are
1630 running on Windows 9X/Me.
1631
42bf8205
AS
16322012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1633
1634 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1635 (xgetint): Add missing shift for LSB tags.
1636
b1bac16e
MR
16372012-04-24 Martin Rudalics <rudalics@gmx.at>
1638
1639 * keyboard.c (read_char): Don't wipe echo area for select window
1640 events: These might get delayed via `mouse-autoselect-window'
1641 (Bug#11304).
1642
d69621cc
JB
16432012-04-24 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1646 manipulation of :loaded-from data.
1647
02fd101b
JB
16482012-04-23 Juanma Barranquero <lekktu@gmail.com>
1649
1650 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1651 now a cons (bug#11311).
1652
888bec30
PE
16532012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1654
89a438bd
PE
1655 Do not create empty overlays with the evaporate property (Bug#9642).
1656 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1657 if it becomes empty after its bounds are adjusted to fit within
1658 its buffer. Without this fix, in a nonempty buffer (let ((o
1659 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1660 yields an empty overlay that has the evaporate property, which is
1661 not supposed to happen.
1662
1068fe4d
PE
1663 Fix minor GTK3 problems found by static checking.
1664 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1665 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1666 (struct _EmacsFixedClass, emacs_fixed_get_type):
1667 Move decls here from emacsgtkfixed.h, since they needn't be public.
1668 (emacs_fixed_get_type): Now static.
1669 (emacs_fixed_class_init): Omit unused local.
1670 (emacs_fixed_child_type): Remove; unused.
1671 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1672 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1673 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1674 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1675 (EMACS_FIXED_GET_CLASS): Remove; unused.
1676 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1677
888bec30
PE
1678 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1679 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1680
de85e130
PE
16812012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1682
d0baac98 1683 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1684 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1685 (__malloc_size_t, __malloc_ptrdiff_t):
1686 Remove. All uses removed, replaced by the definiens if needed,
1687 since we can assume C89 or better now.
1688 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1689 (protect_malloc_state, align, get_contiguous_space)
1690 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1691 (malloc_atfork_handler_child, malloc_enable_thread)
1692 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1693 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1694 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1695 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1696 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1697 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1698 Define using prototypes, not old style.
1699 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1700 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1701 (align): Don't assume that signed integer overflow wraps around.
1702 Omit unused local var.
1703 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1704 (_free_internal_nolock, memalign, mallochook, reallochook):
1705 Omit no-longer-needed casts.
1706 (valloc): Use getpagesize, not __getpagesize.
1707 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1708 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1709
de85e130
PE
1710 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1711
dcbf5805
MA
17122012-04-22 Michael Albinus <michael.albinus@gmx.de>
1713
1714 Move functions from C to Lisp. Make non-blocking method calls
1715 the default. Implement further D-Bus standard interfaces.
1716
1717 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1718 (QCdbus_request_name_allow_replacement)
1719 (QCdbus_request_name_replace_existing)
1720 (QCdbus_request_name_do_not_queue)
1721 (QCdbus_request_name_reply_primary_owner)
1722 (QCdbus_request_name_reply_in_queue)
1723 (QCdbus_request_name_reply_exists)
1724 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1725 (QCdbus_registered_serial, QCdbus_registered_method)
1726 (QCdbus_registered_signal): New Lisp objects.
1727 (XD_DEBUG_MESSAGE): Use sizeof.
1728 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1729 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1730 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1731 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1732 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1733 (xd_signature, xd_append_arg): Allow float for integer types.
1734 (xd_get_connection_references): New function.
b593d6a9
AH
1735 (xd_get_connection_address): Rename from xd_initialize.
1736 Return cached address.
dcbf5805
MA
1737 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1738 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1739 level.
1740 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1741 Return number of refcounts.
dcbf5805
MA
1742 (Fdbus_get_unique_name): Make stronger parameter check.
1743 (Fdbus_message_internal): New defun.
1744 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1745 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1746 (Fdbus_send_signal, Fdbus_register_service)
1747 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1748 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1749 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1750 (Vdbus_compiled_version, Vdbus_runtime_version)
1751 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1752 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1753 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1754 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1755 Adapt docstring.
dcbf5805 1756
52828e02
PE
17572012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1758
da05bc4c
PE
1759 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1760 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1761 Do not assume ptrdiff_t is the same width as 'int'.
1762
52828e02
PE
1763 * alloc.c: Handle unusual debugging option combinations.
1764 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1765 since the two debugging options are incompatible.
1766 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1767 is defined.
1768 (mem_init, mem_insert, mem_insert_fixup):
1769 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1770 (NEED_MEM_INSERT): Remove; no longer needed.
1771
f01769f9
LL
17722012-04-22 Leo Liu <sdl.web@gmail.com>
1773
1774 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1775
5790543d
PE
17762012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * sysdep.c [__FreeBSD__]: Minor cleanups.
1779 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1780 Use Emacs indenting style more consistently. Avoid some casts.
1781 Use 'double' consistently rather than mixing 'float' and 'double'.
1782
b91b7e4d
EW
17832012-04-21 Eduard Wiebe <usenet@pusto.de>
1784
b593d6a9
AH
1785 * sysdep.c (list_system_processes, system_process_attributes):
1786 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1787
6114eb15
AS
17882012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1789
1790 * lisp.mk (lisp): Update.
1791
2f38dff7
PE
17922012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1795 It is never used otherwise.
1796
4ae29f89
SM
17972012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1798
1799 * print.c (print_preprocess): Only check print_depth if print-circle
1800 is nil.
1801 (print_object): Check for cycles even when print-circle is nil and
1802 print-gensym is t, but only check print_depth if print-circle is nil.
1803
f30d612a
CY
18042012-04-20 Chong Yidong <cyd@gnu.org>
1805
1806 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1807 set the status to "failed" and ensure that sentinel is run.
1808
c07a4c0b 18092012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1810
1811 * process.c (Fset_process_inherit_coding_system_flag)
1812 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1813 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1814
c07a4c0b 18152012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1816
1817 * xdisp.c (string_buffer_position_lim): Limit starting position to
1818 BEGV.
1819 (set_cursor_from_row): If called for a mode-line or header-line
1820 row, return zero immediately.
1821 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1822 farther than the first row after the header line, if any.
1823 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1824 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1825
c07a4c0b 18262012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1827
4ae29f89
SM
1828 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1829 (bug#11238).
ad3a2b41 1830
c07a4c0b 18312012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18322012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1833
1834 configure: new option --enable-gcc-warnings (Bug#11207)
1835 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1836 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1837 (ALL_CFLAGS): Use new macros rather than old.
1838 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1839 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1840 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1841 -Wunused-result, -Wunused-variable. This should go away once
1842 the Emacs and Gnulib regex code is merged.
1843 (xmalloc, xrealloc): Now static.
1844
aba027e8
PE
18452012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * dired.c (Fsystem_groups): Remove unused local.
1848
e5a36063
GM
18492012-04-17 Glenn Morris <rgm@gnu.org>
1850
1851 * dired.c (Fsystem_users): Doc fix.
1852
316411f0
DA
18532012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1854
1855 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1856 (syms_of_dired): Add them.
1857
9426aba4
PE
18582012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1859
b62a57be
PE
1860 Fix minor alloc.c problems found by static checking.
1861 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1862 New extern decls, to avoid calling undeclared functions.
1863 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1864 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1865 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1866 (NEED_MEM_INSERT): New macro.
1867 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1868 Remove one incorrect comment and fix another.
b62a57be 1869
3539f31f
PE
1870 Fix minor ralloc.c problems found by static checking.
1871 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1872 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1873 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1874 (r_alloc_sbrk): Now static.
1875
a041960a
PE
1876 Improve ralloc.c interface checking.
1877 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1878 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1879 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1880 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1881 [REL_ALLOC]: ... to here, to check interface.
1882 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1883 Remove decls. This fixes an "It stinks!".
1884
9426aba4
PE
1885 * alloc.c (which_symbols): Fix alignment issue / type clash.
1886
d55c12ed
AS
18872012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1888
1889 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1890 (struct Lisp_Misc_Any): Likewise.
1891 (struct Lisp_Free): Likewise.
1892 * alloc.c (union aligned_Lisp_Symbol): Define.
1893 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1894 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1895 (union aligned_Lisp_Misc): Define.
1896 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1897 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1898 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1899
b948ce8b
PE
19002012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1903 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1904 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1905 * s/netbsd.h, s/sol2-6.h:
1906 Remove definition of GC_MARK_STACK, since the default now works.
1907 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1908 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1909 no longer the default.
1910 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1911
35dc09a1 19122012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1913
35dc09a1
GM
1914 * lread.c (lisp_file_lexically_bound_p):
1915 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1916
35dc09a1
GM
19172012-04-14 Eli Zaretskii <eliz@gnu.org>
1918
1919 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1920 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1921
19222012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1923
1924 * nsterm.m (constrainFrameRect): Always constrain when there is only
1925 one screen (Bug#10962).
1926
bcd86815
KB
19272012-04-13 Ken Brown <kbrown@cornell.edu>
1928
1929 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1930
c25df26e
RT
19312012-04-13 Reuben Thomas <rrt@sc3d.org>
1932
1933 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1934
0fc59f1e
DC
19352012-04-11 Daniel Colascione <dancol@dancol.org>
1936
1937 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1938 against is gone. It's better to use vfork now so that when Cygwin
1939 gains a new, working vfork, we use it automatically (bug#10398).
1940
de8c03dc
SM
19412012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1942
1943 * window.c (save_window_save): Obey window-point-insertion-type.
1944
2f097256
GM
19452012-04-11 Glenn Morris <rgm@gnu.org>
1946
1947 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1948
453b951e
SM
19492012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1950
1951 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1952
75f1671a 19532012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1954
1955 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1956 (force_quit_count): New var.
1957 (handle_interrupt): Use it.
1958
2a8ce227
JB
19592012-04-10 Juanma Barranquero <lekktu@gmail.com>
1960
1961 * w32.c (w32_delayed_load): Record the full path of the library
1962 being loaded (bug#10424).
1963
935396c0
GM
19642012-04-09 Glenn Morris <rgm@gnu.org>
1965
05920a43
GM
1966 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1967 not just in the obarray, before snarfing them. (Bug#11036)
1968
935396c0
GM
1969 * Makefile.in ($(leimdir)/leim-list.el):
1970 Pass EMACS rather than BUILT_EMACS.
1971
a18ecafa
TZ
19722012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1973
1974 * process.c (make_process):
1975 * process.h: Add integer `gnutls_handshakes_tried' member to
1976 process struct.
1977
6bbef4e5
JC
1978 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1979 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1980
1981 * gnutls.c (gnutls_log_function2i): Convenience log function.
1982 (emacs_gnutls_read): Use new log functions,
1983 `gnutls_handshakes_tried' process member, and
1984 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1985 attempts per process (connection).
1986
b4d3bc10
CY
19872012-04-09 Chong Yidong <cyd@gnu.org>
1988
1989 * eval.c (Fuser_variable_p, user_variable_p_eh)
1990 (lisp_indirect_variable): Functions deleted.
1991 (Fdefvar): Caller changed.
1992
1993 * callint.c (Finteractive, Fcall_interactively):
1994 * minibuf.c (Fread_variable): Callers changed.
1995
70f4d973
EZ
19962012-04-09 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (set_cursor_from_row): If the display string appears in
1999 the buffer at position that is closer to point than the position
2000 after the display string, display the cursor on the first glyph of
2001 the display string. Fixes cursor display when a 'display' text
2002 property immediately follows invisible text. (Bug#11094)
2003
cb3c2e3e
PE
20042012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 composite.c: use 'double' consistently
2007 * composite.c (get_composition_id): Use 'double' consistently
2008 instead of converting 'float' to 'double' and vice versa; this is
2009 easier to understand and avoids a GCC warning.
2010
fd06db5d
GM
20112012-04-09 Glenn Morris <rgm@gnu.org>
2012
50fe702a
GM
2013 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2014 preparation for dumping it with emacs. (Bug#4789)
2015 (leimdir): New variable.
2016 ($(leimdir)/leim-list.el): New rule.
2017 (emacs$(EXEEXT)): Depend on leim-list.el.
2018
fd06db5d
GM
2019 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2020 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2021 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2022
55c131ee
AS
20232012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2024
2025 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2026 proper alignment.
2027
9209588f
JB
20282012-04-07 Juanma Barranquero <lekktu@gmail.com>
2029
2030 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2031 Remove unused local variable.
2032
e3fb2efb
PE
20332012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2036 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2037 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2038 objects, as mark_maybe_pointer will catch them otherwise.
2039 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2040 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2041
b5385551
PE
20422012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2043
2044 Fix typo that broke non-Windows builds.
2045 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2046
9078ead6
EZ
20472012-04-07 Eli Zaretskii <eliz@gnu.org>
2048
2049 Support building on MS-Windows with libxml2.
2050
2051 * makefile.w32-in (OBJ2): Add xml.$(O).
2052 (GLOBAL_SOURCES): Add xml.c.
2053 ($(BLD)/xml.$(O)): New dependency list.
2054
2055 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2056 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2057 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2058 [!WINDOWSNT]: New macros.
2059 (init_libxml2_functions, libxml2_loaded_p): New functions.
2060 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2061 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2062 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2063 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2064 linked in).
6bbef4e5
JC
2065 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2066 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2067 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2068
2069 * emacs.c: Don't include libxml/parser.h.
2070 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2071 xmlCleanupParser directly.
2072
2073 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2074
3811fdf3
EZ
20752012-04-07 Eli Zaretskii <eliz@gnu.org>
2076
2077 * indent.c (Fvertical_motion): If there is a display string at
2078 point, use it.vpos to compute how many lines to backtrack after
2079 move_it_to point. (Bug#11133)
2080
2f8e16b2
EZ
20812012-04-06 Eli Zaretskii <eliz@gnu.org>
2082
2083 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2084 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2085 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2086 macros related to unification of CJK characters. For the details,
2087 see the discussion following the message here:
2088 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2089
3d439cd1
CY
20902012-04-04 Chong Yidong <cyd@gnu.org>
2091
2092 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2093
8bc53d00
EZ
20942012-04-01 Eli Zaretskii <eliz@gnu.org>
2095
2096 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2097 instead of alloca. (Bug#11138)
2098
3b0512a3
AS
20992012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2100
2101 * w32menu.c (is_simple_dialog): Properly check lisp types.
2102 (Bug#11141)
2103
8427ddd2
EZ
21042012-03-31 Eli Zaretskii <eliz@gnu.org>
2105
979022ef
EZ
2106 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2107 position we get to after a call to move_it_to fails the
2108 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2109 only if we wind up in a string from display property. (Bug#11063)
2110
a6b1c7cc
EZ
2111 * window.c (Fdelete_other_windows_internal): Invalidate the row
2112 and column information about mouse highlight, so that redisplay
2113 restores it after reallocating the glyph matrices. (Bug#7464)
2114
8427ddd2
EZ
2115 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2116 string comes from a `display' text property, use the buffer
2117 position of that property as if we actually saw that position in
2118 the row's glyphs.
697ba24b
EZ
2119 (move_it_by_lines): Remove the assertion that
2120 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2121 violated when there's a before-string at the beginning of a line.
2122 (Bug#11063)
8427ddd2 2123
65a0a738
EZ
21242012-03-30 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (append_space_for_newline): If the default face was
2127 remapped, use the remapped face for the appended newline.
2128 (extend_face_to_end_of_line): Use the remapped default face for
2129 extending the face to the end of the line.
2130 (display_line): Call extend_face_to_end_of_line when the default
2131 face was remapped. (Bug#11068)
2132
581355cc
EZ
21332012-03-29 Eli Zaretskii <eliz@gnu.org>
2134
2135 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2136
e8fc049f
SM
21372012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2138
2139 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2140
4fb9a543
GM
21412012-03-27 Glenn Morris <rgm@gnu.org>
2142
2143 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2144 Doc fixes.
2145
679910f1
KH
21462012-03-26 Kenichi Handa <handa@m17n.org>
2147
2148 * dispextern.h (struct glyph): Fix previous change. Change the
2149 bit length of glyphless.ch to 25 (Bug#11082).
2150
90d49b7f
CY
21512012-03-26 Chong Yidong <cyd@gnu.org>
2152
2153 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2154 (command_loop_1): Use it; inhibit selection update for
2155 handle-select-window too (Bug#8996).
2156
f514f6f0
FP
21572012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2158
e8fc049f 2159 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2160
bf43fa51
KH
21612012-03-25 Kenichi Handa <handa@m17n.org>
2162
2163 * dispextern.h (struct glyph): Change the bit length of
2164 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2165
8a0c01dd
EZ
21662012-03-24 Eli Zaretskii <eliz@gnu.org>
2167
2168 * s/ms-w32.h (tzname): Include time.h before redirecting to
2169 _tzname. Fixes the MSVC build. (Bug#9960)
2170
7d1c3a76
AS
21712012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2172
8ed79523
AS
2173 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2174 characters.
2175
7d1c3a76
AS
2176 * xterm.c (XTread_socket): Only modify handling_signal if
2177 !SYNC_INPUT. (Bug#11080)
2178
e99a9b8b
EZ
21792012-03-23 Eli Zaretskii <eliz@gnu.org>
2180
2181 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2182 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2183 when fetching a multibyte character consumes more bytes than
2184 CHAR_BYTES returns, due to unification of CJK characters in
2185 string_char. (Bug#11073)
2186
5063c0e1
TN
21872012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2188
2189 * process.c (wait_reading_process_output): Handle pty disconnect
2190 by refraining from sending oneself a SIGCHLD (bug#10933).
2191
9f851fbd
CY
21922012-03-22 Chong Yidong <cyd@gnu.org>
2193
2194 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2195
5063c0e1 2196 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2197 Mark string as coming from a prefix property.
2198 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2199 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2200
fb5b8aca
CY
22012012-03-21 Chong Yidong <cyd@gnu.org>
2202
2203 * xfaces.c (Vface_remapping_alist): Doc fix.
2204
62356a1b
EZ
22052012-03-20 Eli Zaretskii <eliz@gnu.org>
2206
2207 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2208 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2209 Doc fixes.
62356a1b 2210
025de85b
CY
22112012-03-20 Chong Yidong <cyd@gnu.org>
2212
2213 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2214 to reflect default non-nil value of redisplay-dont-pause.
2215
4827f94e
KH
22162012-03-19 Kenichi Handa <handa@m17n.org>
2217
2218 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2219 it fit in a valid range (Bug#11003).
2220
e50a24a2
EZ
22212012-03-18 Eli Zaretskii <eliz@gnu.org>
2222
2223 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2224 that is not from display property, accept the row as a "cursor
2225 row" if one of the string's character has a non-nil `cursor'
2226 property. Fixes cursor positioning when there are newlines in
2227 overlay strings, e.g. in icomplete.el. (Bug#11035)
2228
9af5ed87
PE
22292012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2232
d1f55f16
CY
22332012-03-12 Chong Yidong <cyd@gnu.org>
2234
2235 * eval.c (inhibit_lisp_code): Rename from
2236 inhibit_window_configuration_change_hook; move from window.c.
2237
2238 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2239 * window.c (run_window_configuration_change_hook)
2240 (syms_of_window): Callers changed.
2241
66c5eebd
CY
22422012-03-11 Chong Yidong <cyd@gnu.org>
2243
413df973
CY
2244 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2245
66c5eebd
CY
2246 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2247
1de11f56
CY
22482012-03-10 Chong Yidong <cyd@gnu.org>
2249
2250 * frame.c (other_visible_frames): Don't assume the selected frame
2251 is visible (Bug#10955).
2252
cae07000
SM
22532012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2254
2255 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2256
89c94350
JD
22572012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2258
2259 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2260 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2261 zero (Bug#10954).
2262
999dd333
GM
22632012-03-03 Glenn Morris <rgm@gnu.org>
2264
01a6dcc8 2265 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2266
de0100f2
EZ
22672012-03-02 Eli Zaretskii <eliz@gnu.org>
2268
2269 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2270 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2271 (redisplay_window, next_element_from_string): Fix typos in
2272 comments.
3e441275
EZ
2273 (redisplay_window): Pass to move_it_vertically the margin in
2274 pixels, not in screen lines.
de0100f2 2275
96a72ee9
GM
22762012-03-02 Glenn Morris <rgm@gnu.org>
2277
2278 * buffer.c (buffer-list-update-hook): Doc fix.
2279
312508d7
EZ
22802012-02-29 Eli Zaretskii <eliz@gnu.org>
2281
2282 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2283 push_it before setting up the iterator for the first overlay
2284 string, even if we have an empty string loaded.
2285 (next_overlay_string): If there's an empty string on the iterator
2286 stack, pop the stack. (Bug#10903)
2287
27f3c637
PE
22882012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2291 Suggested by Stefan Monnier in
2292 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2293 * alloc.c (widen_to_Lisp_Object): New static function.
2294 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2295 and widening them to Lisp_Objects. This would work even if
2296 USE_LSB_TAG is defined and wide integers are used, which might
2297 happen in a future version of Emacs.
2298
3c9dfce6
CY
22992012-02-25 Chong Yidong <cyd@gnu.org>
2300
fa74b241
CY
2301 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2302 Doc fix.
2303
3c9dfce6
CY
2304 * xselect.c (Fx_selection_exists_p): Doc fix.
2305 (x_clipboard_manager_save_all): Print an informative message
2306 before saving to clipboard manager.
2307
9486df08
CY
23082012-02-24 Chong Yidong <cyd@gnu.org>
2309
2310 * keyboard.c (process_special_events): Handle all X selection
2311 requests in kbd_buffer, not just the next one (Bug#8869).
2312
f01d3321
CY
23132012-02-23 Chong Yidong <cyd@gnu.org>
2314
2315 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2316 call when setting menu-bar-lines and tool-bar-lines parameters.
2317 (unwind_create_frame_1): New helper function.
2318
2319 * window.c (inhibit_window_configuration_change_hook): New var.
2320 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2321 (syms_of_window): Initialize it.
f01d3321 2322
86b847b6
CY
23232012-02-22 Chong Yidong <cyd@gnu.org>
2324
2325 * xterm.c (x_draw_image_relief): Add missing type check for
2326 Vtool_bar_button_margin (Bug#10743).
2327
a59225b1
CY
23282012-02-21 Chong Yidong <cyd@gnu.org>
2329
2330 * fileio.c (Vfile_name_handler_alist): Doc fix.
2331
2332 * buffer.c (Fget_file_buffer): Protect against invalid file
2333 handler return value.
2334
310f5bd4
PE
23352012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2336
cb3a28cc
PE
2337 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2338 when computing $valmask.
2339
310f5bd4
PE
2340 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2341 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2342 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2343 It's useless in that case, and it can cause problems on hosts
2344 that allocate halves of EMACS_INT values separately.
2345 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2346 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2347 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2348 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2349 it avoids undefined behavior on hosts where shifting right by more
2350 than the word width has undefined behavior.
2351
2375c96a
CY
23522012-02-19 Chong Yidong <cyd@gnu.org>
2353
2354 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2355 (Funhandled_file_name_directory, Ffile_name_as_directory)
2356 (Fdirectory_file_name, Fexpand_file_name)
2357 (Fsubstitute_in_file_name): Protect against invalid file handler
2358 return values (Bug#10845).
2359
3eb49e71
EZ
23602012-02-18 Eli Zaretskii <eliz@gnu.org>
2361
2362 * .gdbinit (pitx): Fix incorrect references to fields of the
2363 iterator stack.
2364
7b926f3f
CY
23652012-02-17 Chong Yidong <cyd@gnu.org>
2366
2367 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2368
11273115
PE
23692012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2370
2371 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2372 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2373
c3a70e2b
CY
23742012-02-15 Chong Yidong <cyd@gnu.org>
2375
2376 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2377 marked as special. Also, starting docstrings with * is obsolete.
2378
0ca43699
AS
23792012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2380
2381 * gnutls.c (emacs_gnutls_write): Fix last change.
2382
2e8f3c56
LI
23832012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2384
2385 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2386 send_process.
2387
af70074f
SM
23882012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2389
2390 * keymap.c (Fsingle_key_description): Handle char ranges.
2391
95986d52
CY
23922012-02-12 Chong Yidong <cyd@gnu.org>
2393
afd83bd1
CY
2394 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2395 as that creates a dangerous corner case.
2396
95986d52
CY
2397 * window.c (Fdelete_window_internal): Invalidate the mouse
2398 highlight (Bug#9904).
2399
bd7da63e
GM
24002012-02-12 Glenn Morris <rgm@gnu.org>
2401
2402 * xselect.c (Fx_own_selection_internal)
2403 (Fx_get_selection_internal, Fx_disown_selection_internal)
2404 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2405 * nsselect.m (Fx_own_selection_internal)
2406 (Fx_disown_selection_internal, Fx_selection_exists_p)
2407 (Fx_selection_owner_p, Fx_get_selection_internal):
2408 Sync docs and argument specs with the xselect.c versions.
2409
77abcbc2
LI
24102012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2411
2412 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2413
90b671e2
EZ
24142012-02-11 Eli Zaretskii <eliz@gnu.org>
2415
1c0ca0b7
EZ
2416 * w32select.c (Fx_selection_exists_p): Sync doc string and
2417 argument list with xselect.c. (Bug#10783)
2418
2419 * w16select.c (Fx_selection_exists_p): Sync doc string and
2420 argument list with xselect.c. (Bug#10783)
90b671e2 2421
49241268
GM
24222012-02-10 Glenn Morris <rgm@gnu.org>
2423
2424 * fns.c (Fsecure_hash): Doc fix.
2425
f998bbe7 24262012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2427
2428 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2429
0992bd9c
CY
24302012-02-07 Chong Yidong <cyd@gnu.org>
2431
2432 * buffer.c (Fbuffer_local_variables)
2433 (buffer_lisp_local_variables): Handle unbound vars correctly;
2434 don't let Qunbound leak into Lisp.
2435
af008560
GM
24362012-02-07 Glenn Morris <rgm@gnu.org>
2437
dd605cc4
GM
2438 * image.c (Fimagemagick_types): Doc fix.
2439
af008560
GM
2440 * image.c (imagemagick-render-type): Change it from a lisp object
2441 to an integer. Move the doc here from the lisp manual.
2442 Treat all values not equal to 0 the same.
2443
1449fa1d
CY
24442012-02-06 Chong Yidong <cyd@gnu.org>
2445
2446 * doc.c (store_function_docstring): Avoid applying docstring of
2447 alias to base function (Bug#2603).
2448
3723ec07
AS
24492012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2450
2451 * .gdbinit (pp1, pv1): Remove redundant defines.
2452 (pr): Use pp.
2453
79c1cc1e
CY
24542012-02-04 Chong Yidong <cyd@gnu.org>
2455
2456 * nsterm.m: Declare a global (Bug#10694).
2457
d7f29f8e
EZ
24582012-02-04 Eli Zaretskii <eliz@gnu.org>
2459
cae07000
SM
2460 * w32.c (get_emacs_configuration_options):
2461 Include --enable-checking, if specified, in the return value.
d7f29f8e 2462
3b95a6f9
MR
24632012-02-04 Martin Rudalics <rudalics@gmx.at>
2464
2465 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2466 after rounding frame sizes. (Bug#9723)
2467
d6fa96a6
EZ
24682012-02-04 Eli Zaretskii <eliz@gnu.org>
2469
2470 * keyboard.c (adjust_point_for_property): Don't position point
2471 before BEGV. (Bug#10696)
2472
df0b2940
PE
24732012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 Handle overflow when computing char display width (Bug#9496).
2476 * character.c (char_width): Return EMACS_INT, not int.
2477 (char_width, c_string_width): Check for overflow when
2478 computing the width; this is possible now that individual
2479 characters can have unbounded width. Problem introduced
2480 by merge from Emacs 23 on 2012-01-19.
2481
6bee44d6
MA
24822012-02-02 Michael Albinus <michael.albinus@gmx.de>
2483
2484 * dbusbind.c (Fdbus_register_method): Mention the return value
2485 :ignore in the docstring.
2486
44f92739
GM
24872012-02-02 Glenn Morris <rgm@gnu.org>
2488
1b9f60cc
GM
2489 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2490
44f92739
GM
2491 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2492 Unconditionally set to t. (Bug#10673)
2493 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2494 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2495 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2496
c5d3843c
KH
24972012-02-02 Kenichi Handa <handa@m17n.org>
2498
2499 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2500 0, do not call append_composite_glyph.
2501
159462d4 25022012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2503
2504 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2505 NULL (Bug#6988).
2506 (x_produce_glyphs): If the component of a composition is a null
2507 string, set it->pixel_width to 1 to avoid zero-width glyph.
2508
78cef877
EZ
25092012-02-01 Eli Zaretskii <eliz@gnu.org>
2510
2511 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2512 first 2 arguments are identical. This makes inserting large
2513 output from a subprocess an order of magnitude faster on
2514 MS-Windows, where all sbrk'ed memory is always contiguous.
2515
97897668
GM
25162012-01-31 Glenn Morris <rgm@gnu.org>
2517
2518 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2519 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2520 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2521
31fd3586
GM
25222012-01-29 Glenn Morris <rgm@gnu.org>
2523
2524 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2525
0e24a8b2
CY
25262012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2527
2528 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2529
cc0adcb0
CY
25302012-01-28 Chong Yidong <cyd@gnu.org>
2531
2532 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2533
acc28cb9
CY
25342012-01-26 Chong Yidong <cyd@gnu.org>
2535
9c69cfb7
CY
2536 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2537
acc28cb9
CY
2538 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2539 repeat counts (Bug#10507).
2540
48da7392
GM
25412012-01-26 Glenn Morris <rgm@gnu.org>
2542
2543 * lread.c (syms_of_lread): Doc fix.
2544
14af5f7f
CY
25452012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2546
2547 * coding.c (encode_designation_at_bol): Change return value to
2548 EMACS_INT.
2549
0b21c100
CY
25502012-01-25 Chong Yidong <cyd@gnu.org>
2551
2552 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2553
3c2907f7
CY
25542012-01-21 Chong Yidong <cyd@gnu.org>
2555
2556 * floatfns.c (Fcopysign): Make the second argument non-optional,
2557 since nil is not allowed anyway.
2558
959ad23f
AS
25592012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2560
2561 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2562 (send_process): Likewise.
2563
34a02f46
MR
25642012-01-19 Martin Rudalics <rudalics@gmx.at>
2565
2566 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2567 (Vwindow_persistent_parameters): Do not use Qstate.
2568 Rewrite doc-strings.
34a02f46 2569
1259009a 25702012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2571
2572 * character.c (char_width): New function.
70d4fdf6
GM
2573 (Fchar_width, c_string_width, lisp_string_width):
2574 Use char_width (Bug#9496).
25ed9e61 2575
6a6ee00d
MR
25762012-01-16 Martin Rudalics <rudalics@gmx.at>
2577
2578 * window.c (Vwindow_persistent_parameters): New variable.
2579 (Fset_window_configuration, save_window_save): Handle persistent
2580 window parameters.
2581
c85efaf7
EZ
25822012-01-14 Eli Zaretskii <eliz@gnu.org>
2583
2584 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2585 thrashing the stack of the thread. (Bug#9087)
2586
5944709e
PE
25872012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2590
e71f5d99
EZ
25912012-01-11 Eli Zaretskii <eliz@gnu.org>
2592
2593 * xdisp.c (rows_from_pos_range): Handle the case where the
2594 highlight ends on a newline. (Bug#10464)
2595 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2596 he end column for display of highlight that ends on a newline
2597 before a R2L line.
2598
ce316182
GM
25992012-01-11 Glenn Morris <rgm@gnu.org>
2600
2601 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2602 from load-path also when installation-directory is nil. (Bug#10208)
2603
5b43da69
GM
26042012-01-10 Glenn Morris <rgm@gnu.org>
2605
74cc8ff9
GM
2606 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2607
7d8d6e4e
GM
2608 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2609 Update template values to be closer to their typical values these days.
5b43da69 2610
a0db8d43
EZ
26112012-01-09 Eli Zaretskii <eliz@gnu.org>
2612
2613 * xdisp.c (rows_from_pos_range): Accept additional argument
2614 DISP_STRING, and accept any glyph in a row whose object is that
2615 string as eligible for mouse highlight. Fixes mouse highlight of
2616 display strings from overlays. (Bug#10464)
2617
9a0115ab 26182012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2619
b9110d6a 2620 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2621 * fileio.c (auto_saving_dir_umask): New static var.
2622 (Fmake_directory_internal): Use it.
2623 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2624 creating the directory. The old code temporarily assigns
2625 too-generous permissions to the directory.
2626 (do_auto_save_eh): Clear it.
b9110d6a 2627 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2628 that the var is always cleared.
2629
6c1bd3f3
EZ
26302012-01-07 Eli Zaretskii <eliz@gnu.org>
2631
2632 * search.c (scan_buffer): Pass character positions to
2633 know_region_cache, not byte positions. (Bug#6540)
2634
069d2b50
L
26352012-01-07 LynX <_LynX@bk.ru> (tiny change)
2636
2637 * w32.c (sys_rename): Report EXDEV when rename of a directory
2638 fails because the target is on another logical disk. (Bug#10284)
2639
75bf0d33
DB
26402012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2641
2642 * xterm.c (x_embed_request_focus): New function.
2643
2644 * xterm.h: Add prototype.
2645
2646 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2647
1c6e5a32
GM
26482012-01-05 Glenn Morris <rgm@gnu.org>
2649
2650 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2651
651e947e
EZ
26522012-01-01 Eli Zaretskii <eliz@gnu.org>
2653
2654 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2655 Load gnutls_transport_set_lowat only if GnuTLS version is below
2656 2.11.1.
2657 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2658 GnuTLS versions below 2.11.1.
2659
3778cdd8
AL
26602011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2661
2662 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2663 to the doc string advising against its use for altering the way
2664 windows are scrolled.
2665
0e5317f7
KH
26662011-12-28 Kenichi Handa <handa@m17n.org>
2667
2668 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2669 coding-system ASCII compatible only when it does not produce BOM
2670 on encoding (Bug#10383).
2671
93d5ca1f
JD
26722011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2673
2674 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2675 can scroll.
2676 (create_and_show_popup_menu): Always use menu_position_func for
2677 Gtk3 (Bug#10361).
2678
ca22b785
AS
26792011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2680
2681 * callint.c (Fcall_interactively): Don't truncate prompt string.
2682
d048e1e6
EZ
26832011-12-23 Eli Zaretskii <eliz@gnu.org>
2684
2685 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2686 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2687 resumed from there (after widening). (Bug#10360)
d048e1e6 2688
5ccaba1f
JD
26892011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2690
2691 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2692
204ee57f
JD
26932011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2694
b81d40f0
JB
2695 * nsterm.m (x_free_frame_resources):
2696 Release f->output_data.ns->miniimage.
204ee57f
JD
2697 (ns_index_color): Fix indentation. Do not retain
2698 color_table->colors[i].
2699
2700 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2701 before returning.
2702
2703 * nsfns.m (x_set_background_color): Assign return value from
2704 ns_index_color to face-background instead of NSColor*.
2705 (ns_implicitly_set_icon_type): Fix indentation.
2706 Change assignment in for loop to comparison.
2707
2708 * emacs.c (ns_pool): New variable.
2709 (main): Assign ns_pool.
2710 (Fkill_emacs): Call ns_release_autorelease_pool.
2711
2712 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2713 autorelease fdesc, release fdAttrs and tdict.
2714 (ns_get_covering_families): Release charset.
2715 (ns_findfonts): Release NSFontDescriptor created with new.
2716 (ns_uni_to_glyphs): Fix indentation.
2717 (setString): Release attrStr before assigning new value.
2718
c803b2b7
JD
27192011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2720
678f4426
JD
2721 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2722 and NS_IMPL_COCOA.
2723 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2724 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2725
cd394be1 27262011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2727
5fecd5fc
JD
2728 * nsterm.m (ns_term_init): Subscribe for notifications
2729 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2730 to method trackingNotification in EmacsMenu.
2731
2732 * nsmenu.m (trackingMenu): New variable.
3771cb17 2733 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2734 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2735 from Aquamacs (Bug#7030).
678f4426
JD
2736
27372011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2738
c803b2b7
JD
2739 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2740 (symbol_to_nsstring): Fix indentation.
2741 (ns_symbol_to_pb): New function.
cae07000
SM
2742 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2743 (Fns_rotate_cut_buffers_internal): Remove.
2744 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2745 Fns_store_cut_buffer_internal.
2746 (ns_get_foreign_selection, Fx_own_selection_internal)
2747 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2748 (Fns_get_selection_internal, Fns_store_selection_internal):
2749 Use ns_symbol_to_pb and check if return value is nil.
2750 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2751 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2752 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2753 renamed to Sns_store_selection_internal.
2754 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2755 and remove this function.
2756 (ns_handle_selection_clear): Remove, never used.
2757 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2758 here.
2759
e1b01a3a
KB
27602011-12-17 Ken Brown <kbrown@cornell.edu>
2761
2762 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2763 GID is unknown (Bug#10257).
2764
2adb6e85
PE
27652011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2766
2767 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2768 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2769 which caused a build failure on GNU/Linux IA-64. This problem was
2770 introduced by my 2011-10-07 patch.
2771
d1d7b339
JL
27722011-12-15 Juri Linkov <juri@jurta.org>
2773
2774 * image.c (imagemagick_error): New function. (Bug#10112)
2775 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2776 Use `imagemagick_error' where ImageMagick functions return
2777 `MagickFalse'.
2778 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2779 proper order.
2780
100d5755
KH
27812011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2782
2783 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2784 fill background (Bug#8992).
2785
454592a6
MR
27862011-12-13 Martin Rudalics <rudalics@gmx.at>
2787
2788 * window.c (Vwindow_combination_resize)
2789 (Vwindow_combination_limit): Use t instead of non-nil in
2790 doc-strings.
61d4b438
MR
2791 (Vrecenter_redisplay): Add first sentence of doc-string on
2792 separate line.
53524d93 2793 (Frecenter): Fix doc-string typo.
454592a6 2794
3633e3aa
KH
27952011-12-11 Kenichi Handa <handa@m17n.org>
2796
2797 * coding.c (Funencodable_char_position): Pay attention to the
2798 buffer text relocation (Bug#9389).
2799
7b9d523a 28002011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2801
7b9d523a
JD
2802 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2803 gtk_init (Bug#10100).
2804
b73189c6
EZ
28052011-12-10 Eli Zaretskii <eliz@gnu.org>
2806
2807 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2808 IT->string is nil. (Bug#10263)
2809
f7dfe5d6
JD
28102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2811
83faebb4
JD
2812 * nsterm.h (x_free_frame_resources): Declare.
2813
f7dfe5d6
JD
2814 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2815 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2816
2817 * nsterm.h (ns_get_defaults_value): Declare.
2818
2819 * nsterm.m (ns_default): Call ns_get_defaults_value.
2820
7cd4e72c
EZ
28212011-12-09 Eli Zaretskii <eliz@gnu.org>
2822
2823 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2824 (Bug#10170)
2825
b34d7317
YM
28262011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2827
2828 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2829 that where the value of an _OBJC_* symbol points to is in the .bss
2830 section (Bug#10240).
2831
76470ad1
KH
28322011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2833
2834 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2835 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2836
745fff94
KH
28372011-12-08 Kenichi Handa <handa@m17n.org>
2838
2839 * ftfont.c (get_adstyle_property): Fix previous change
2840 (Bug#10233).
2841
6e44397c
JB
28422011-12-07 Juanma Barranquero <lekktu@gmail.com>
2843
2844 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2845 dirs from the default value of EMACSLOADPATH (bug#10208).
2846
7efa6272
GM
28472011-12-07 Glenn Morris <rgm@gnu.org>
2848
2849 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2850 installation and source directories as well. (Bug#10208)
2851
f6fc4d87
CY
28522011-12-06 Chong Yidong <cyd@gnu.org>
2853
2854 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2855
2bf26180
GM
28562011-12-06 Glenn Morris <rgm@gnu.org>
2857
2858 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2859 as an error, not just -1. (Bug#10217)
2860
3a6ad4f0
CY
28612011-12-05 Chong Yidong <cyd@gnu.org>
2862
2863 * keyboard.c (process_special_events): New function.
2864 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2865
75a3b399
PE
28662011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * coding.c (encode_designation_at_bol): Don't use uninitialized
2869 local variable (Bug#9318).
2870
c3c9e25e
KH
28712011-12-05 Kenichi Handa <handa@m17n.org>
2872
2873 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2874 return Qnil (Bug#8046, Bug#10193).
2875
5eb05ea3
KH
28762011-12-05 Kenichi Handa <handa@m17n.org>
2877
2878 * coding.c (encode_designation_at_bol): New args charbuf_end and
2879 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2880 (coding_set_source): Return how many bytes coding->source was
2881 relocated.
2882 (coding_set_destination): Return how many bytes
2883 coding->destination was relocated.
2884 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2885 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2886
28872011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2888
2889 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2890 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2891 macro (Bug#9318).
2892
28932011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2894
2895 The following changes are to fix Bug#9318.
2896
a79703f5 2897 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2898 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2899 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2900 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2901
7dbda6df
JB
29022011-12-05 Juanma Barranquero <lekktu@gmail.com>
2903
2904 * lisp.h (process_quit_flag): Fix external declaration.
2905
6d5eb5b0
SM
29062011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2907
2908 Don't macro-inline non-performance-critical code.
2909 * eval.c (process_quit_flag): New function.
2910 * lisp.h (QUIT): Use it.
2911
a0c3fad0
JD
29122011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2913
2914 * nsfns.m (get_geometry_from_preferences): New function.
2915 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2916
6c07aac2
AS
29172011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2918
2919 * emacs.c (Qkill_emacs): Define.
2920 (syms_of_emacs): Initialize it.
2921 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2922 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2923 (quit_throw_to_read_char): Add parameter `from_signal'.
2924 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2925 * lisp.h (QUIT): Call Fkill_emacs if requested.
2926
c052ead4
JD
29272011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2928
2929 * widget.c (update_wm_hints): Return if wmshell is null.
2930 (widget_update_wm_size_hints): New function.
2931
2932 * widget.h (widget_update_wm_size_hints): Declare.
2933
2934 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2935 widget_update_wm_size_hints (Bug#10104).
2936
9e49252b
EZ
29372011-12-03 Eli Zaretskii <eliz@gnu.org>
2938
2939 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2940 before a newline, prepare the bidi iterator for consuming the
2941 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2942 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2943
02b16839
JL
29442011-12-02 Juri Linkov <juri@jurta.org>
2945
2946 * search.c (Fword_search_regexp): New Lisp function created from
2947 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2948 (Fword_search_backward, Fword_search_forward)
2949 (Fword_search_backward_lax, Fword_search_forward_lax):
2950 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2951 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2952
0068070e
SM
29532011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2954
2955 * fileio.c (Finsert_file_contents): Move after-change-function call
2956 to before the "handled:" label, since all "goto handled" appear in
2957 cases where the *-change-functions have already been properly called
2958 (bug#10117).
2959
3360a3fc
AS
29602011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2961
2962 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2963 waiting for input. (Bug#10169)
2964
73d6c093
EZ
29652011-11-30 Eli Zaretskii <eliz@gnu.org>
2966
2967 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2968 verifies glyph row's hash code--we have just reallocated the
2969 glyphs, so their contents can be complete garbage. (Bug#10164)
2970
febe6bea
JB
29712011-11-30 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2974
801a4313
EZ
29752011-11-30 Eli Zaretskii <eliz@gnu.org>
2976
2977 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2978 attributes are tested _before_ calling verify_row_hash, to protect
2979 against GCC re-ordering of the tests. (Bug#10164)
2980
2b56b87e
JD
29812011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2982
2983 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2984
2985 * xterm.c (handle_one_xevent): Only set async_visible and friends
2986 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2987 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2988 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2989
dbf31225
PE
29902011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2993 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2994 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2995 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2996 All uses changed to use GCPRO1 etc.
2997 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2998 Revert to old implementation (i.e., before 2011-03-11).
2999
1305621b
YM
30002011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3001
3002 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3003 of scroll runs so as to avoid assigning disabled bogus rows and
3004 unnecessary graphics copy operations.
3005
8c9afb46
EZ
30062011-11-27 Eli Zaretskii <eliz@gnu.org>
3007
3008 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3009 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3010 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3011 (malloc, free, realloc, calloc): Redirect to e_* only when
3012 compiling Emacs.
3013
3014 * lisp.h (GCTYPEBITS): Move before first use.
3015 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3016 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3017 this macro definition.
3018
3019 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3020 _MSC_VER.
3021
54e9e3bf
JD
30222011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3023
6d5eb5b0
SM
3024 * gtkutil.c (xg_create_frame_widgets):
3025 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3026 present with Gtk+ 2.0.
3027
83aca1cb
PE
30282011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * fileio.c (Finsert_file_contents): Undo previous change; see
3031 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3032
5b76caa4
PE
30332011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 Rename locals to avoid shadowing.
3036 * fileio.c (Finsert_file_contents):
3037 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3038 * process.c (wait_reading_process_output):
3039 Rename inner 'proc' to 'p' to avoid shadowing.
3040 Indent for consistency with usual Emacs style.
3041
8c535114
EZ
30422011-11-25 Eli Zaretskii <eliz@gnu.org>
3043
3044 * xdisp.c (redisplay_window): If cursor row is not fully visible
3045 after recentering, and scroll-conservatively is set to a large
3046 number, scroll window by a few more lines to make the cursor fully
3047 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3048 (start_display): Don't move to the next line if the display should
3049 start at a newline that is part of a display vector or an overlay
3050 string. (Bug#10119)
8c535114 3051
fa4fdb5c
JL
30522011-11-24 Juri Linkov <juri@jurta.org>
3053
3054 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3055 after the `MagickPingImage' call. (Bug#10112)
3056
90ec88df
CY
30572011-11-23 Chong Yidong <cyd@gnu.org>
3058
3059 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3060
56e2e794
MR
30612011-11-23 Martin Rudalics <rudalics@gmx.at>
3062
3063 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3064 making another buffer current. (Bug#10114)
3065
b6e64c41
GM
30662011-11-23 Glenn Morris <rgm@gnu.org>
3067
3068 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3069
6b21de18
CY
30702011-11-23 Chong Yidong <cyd@gnu.org>
3071
3072 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3073 using it (Bug#5984).
3074
b12cd789
EZ
30752011-11-22 Eli Zaretskii <eliz@gnu.org>
3076
3077 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3078 and header-lines, as they don't have one computed for them.
3079 (Bug#10098)
3080
3081 * .gdbinit (prow): Make displayed values more self-explaining.
3082 Add row's hash code.
3083
261b6fd4
LMI
30842011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3085
3086 * process.c (wait_reading_process_output): Fix asynchrounous
3087 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3088 (wait_reading_process_output): Add comment and URL.
261b6fd4 3089
e7cfd277
JD
30902011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3091
3092 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3093
a9b9b7f5
CY
30942011-11-21 Chong Yidong <cyd@gnu.org>
3095
3096 * window.c (Fnext_window, Fprevious_window): Doc fix.
3097
b0d15b4f
SM
30982011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3099
3100 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3101
fe7a3057
JB
31022011-11-20 Juanma Barranquero <lekktu@gmail.com>
3103
3104 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3105
d2999b1a
MR
31062011-11-20 Martin Rudalics <rudalics@gmx.at>
3107
3108 * window.c (Fset_window_combination_limit): Rename argument
3109 STATUS to LIMIT.
3110 (Vwindow_combination_limit): Remove "status" from doc-string.
3111
d5ff9cd0
AS
31122011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3113
3114 * m/ibms390.h: Remove.
3115 * m/ibms390x.h: Don't include "ibms390.h".
3116
a5bb9bd3
SM
31172011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3118
3119 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3120 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3121
cd1181db
JB
31222011-11-20 Juanma Barranquero <lekktu@gmail.com>
3123
3124 * casetab.c (Fset_case_table):
3125 * charset.c (Fcharset_after): Fix typos.
3126
615a3b8d 31272011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3128
17e845af
PE
3129 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3130 Otherwise, valgrind does not work on some platforms.
3131 Problem reported by Andreas Schwab in
6a0bf43d
PE
3132 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3133 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3134 is set, removing the need for VIRT_ADDRESS_VARIES.
3135 (PURE_P): Use a more-efficient implementation that needs just one
3136 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3137 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3138 to 4 (xorl, subq, cmpq, setbe).
3139 * alloc.c (pure): Always extern now, since that's the
3140 VIRT_ADDR_VARIES behavior.
3141 (PURE_POINTER_P): Use a single comparison, not two, for
3142 consistency with the new puresize.h.
3143 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3144 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3145 Remove VIRT_ADDR_VARIES no longer needed.
3146
f8fe6f96
EZ
31472011-11-19 Eli Zaretskii <eliz@gnu.org>
3148
3149 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3150 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3151 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3152 behave as if the cursor position were at the window margin.
3153
3154 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3155 and the cursor position is out of bounds, behave as if the cursor
3156 position were at the window margin. (Bug#10075)
3157
df05a53c
CY
31582011-11-18 Chong Yidong <cyd@gnu.org>
3159
3160 * window.c (Fwindow_combination_limit): Make first argument
3161 non-optional, since it is meaningless for live windows like the
3162 selected window.
61ccba97 3163
2071918e
DA
31642011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3165
3166 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3167
b50a28de
SM
31682011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3169
3170 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3171 (graft_intervals_into_buffer): Simplify.
3172
015137db
EZ
31732011-11-18 Eli Zaretskii <eliz@gnu.org>
3174
3175 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3176 hash values of the two rows.
3177 (copy_row_except_pointers): Preserve the used[] arrays and the
3178 hash values of the two rows. (Bug#10035)
68c95424 3179 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3180
3181 * xdisp.c (row_hash): New function, body extracted from
3182 compute_line_metrics.
3183 (compute_line_metrics): Call row_hash, instead of computing the
3184 hash code inline.
3185
3186 * dispnew.c (verify_row_hash): Call row_hash for computing the
3187 hash code of a row, instead of duplicating code from xdisp.c.
3188
3189 * dispextern.h (row_hash): Add prototype.
3190
a2addb04
TH
31912011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3192
3193 * frame.c (delete_frame): Don't delete the terminal when the last
3194 X frame is closed if emacs is built with GTK toolkit.
3195
df85d315
JB
31962011-11-17 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3199
a0c2d0ae
MR
32002011-11-17 Martin Rudalics <rudalics@gmx.at>
3201
3202 * window.c (Vwindow_splits): Rename to
3203 Vwindow_combination_resize. Suggested by Juri Linkov.
3204 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3205 of Vwindow_splits.
3206
58179cce
JB
32072011-11-16 Juanma Barranquero <lekktu@gmail.com>
3208
7877f373
JB
3209 * nsfns.m (Fns_font_name):
3210 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3211
b6f67890
MR
32122011-11-16 Martin Rudalics <rudalics@gmx.at>
3213
3214 * window.h (window): Rename slot "nest" to "combination_limit".
3215 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3216 (Fset_window_nest): Rename to Fset_window_combination_limit.
3217 (Vwindow_nest): Rename to Vwindow_combination_limit.
3218 (recombine_windows, make_parent_window, make_window)
3219 (Fsplit_window_internal, saved_window)
3220 (Fset_window_configuration, save_window_save): Rename all
3221 occurrences of window_nest to window_combination_limit.
3222
c7015153
JB
32232011-11-15 Juanma Barranquero <lekktu@gmail.com>
3224
3225 * image.c (imagemagick_load_image): Fix typo.
3226
322ad6ec
EZ
32272011-11-14 Eli Zaretskii <eliz@gnu.org>
3228
3229 * xdisp.c (display_line): Move the call to
3230 highlight_trailing_whitespace before the call to
3231 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3232 faces of all the glyphs to compute ROW's hash value.
3233 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3234
f067b8ec
JB
32352011-11-14 Juanma Barranquero <lekktu@gmail.com>
3236
3237 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3238 just return (bug#10044).
3239
1e5b2111
EZ
32402011-11-12 Eli Zaretskii <eliz@gnu.org>
3241
7ef3cbd5
EZ
3242 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3243 with user-defined heap size. Bump the default size of the temacs
3244 heap to 27MB, to avoid memory warning when running temacs.
3245 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3246
1e5b2111
EZ
3247 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3248 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3249 (verify_row_hash) [XASSERTS]: New function.
3250 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3251 that the hash value of glyph rows is correct.
1e5b2111 3252
89d61221
MR
32532011-11-12 Martin Rudalics <rudalics@gmx.at>
3254
3255 * window.h (window): Remove splits slot.
3256 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3257 (Fdelete_other_windows_internal, make_parent_window)
3258 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3259 (Fset_window_configuration, save_window_save): Don't deal with
3260 split status of windows.
3261 (saved_window): Remove splits slot.
3262 (Vwindow_splits): Rewrite doc-string.
3263
97f18cc8
JD
32642011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3265
3266 * xfns.c (unwind_create_frame):
3267 * nsfns.m (unwind_create_frame):
3268 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3269 Vframe_list (Bug#9999).
3270
22a648b4
DA
32712011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3272
0b381c7e 3273 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3274
659afede
KH
32752011-11-11 Kenichi Handa <handa@m17n.org>
3276
3277 * callproc.c (Fcall_process): Set the member dst_multibyte of
3278 process_coding.
3279
9ac0394b
KH
32802011-11-11 Johan Bockgård <bojohan@gnu.org>
3281
3282 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3283 avoid a crash (bug#9496).
3284
2fbdc249
CY
32852011-11-09 Chong Yidong <cyd@gnu.org>
3286
3287 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3288 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3289
ac6b1f81
PE
32902011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3291
3292 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3293
09db192c
PE
32942011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3295
3296 Avoid some portability problems by eschewing 'extern inline' functions.
3297 The trivial performance wins aren't worth the portability hassles; see
3298 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3299 et seq.
3300 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3301 (window_box_width, window_box_left, window_box_left_offset)
3302 (window_box_right, window_box_right_offset): Undo previous change,
3303 by removing the "extern"s.
3304 * intervals.c (adjust_intervals_for_insertion)
3305 (adjust_intervals_for_deletion): Undo previous change,
3306 making these static again.
3307 (offset_intervals, temp_set_point_both, temp_set_point)
3308 (copy_intervals_to_string): No longer inline.
3309 * xdisp.c (window_text_bottom_y, window_box_width)
3310 (window_box_height, window_box_left_offset)
3311 (window_box_right_offset, window_box_left, window_box_right)
3312 (window_box): No longer inline.
3313
105216ed
CY
33142011-11-08 Chong Yidong <cyd@gnu.org>
3315
3316 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3317 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3318 Signal an error if not a live window.
105216ed
CY
3319 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3320 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3321
ae9e237f
JB
33222011-11-07 Juanma Barranquero <lekktu@gmail.com>
3323
3324 * lisp.h (syms_of_abbrev): Remove declaration.
3325 Reported by CHENG Gao <chenggao@royau.me>.
3326
c7aa8333
EZ
33272011-11-07 Eli Zaretskii <eliz@gnu.org>
3328
3329 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3330 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3331 of temacs in GUI mode.
3332
be7f5545
MR
33332011-11-07 Martin Rudalics <rudalics@gmx.at>
3334
3335 * window.h: Declare delete_all_child_windows instead of
3336 delete_all_subwindows.
3337 * window.c (Fwindow_nest, Fset_window_nest)
3338 (Fset_window_new_total, Fset_window_new_normal)
3339 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3340 (delete_all_subwindows): Rename to delete_all_child_windows.
3341 (Fdelete_other_windows_internal, Fset_window_configuration):
3342 Call delete_all_child_windows instead of delete_all_subwindows.
3343 * frame.c (delete_frame): Call delete_all_child_windows instead
3344 of delete_all_subwindows.
3345
ca78dc43
PE
33462011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3349 This is also needed for porting to any host where GC_MARK_STACK is
3350 not GC_MAKE_GCPROS_NOOPS.
3351 (which_symbols): Use it.
3352
a0241d01
KH
33532011-11-07 Kenichi Handa <handa@m17n.org>
3354
3355 * coding.c (coding_set_destination): Check coding->src_pos only
3356 when coding->src_object is a buffer (bug#9910).
3357
3358 * process.c (send_process): Set the member src_multibyte of coding
3359 to 0 (bug#9911) when sending a unibyte text.
3360
3361 * callproc.c (Fcall_process): Set the member src_multibyte of
3362 process_coding to 0 (bug#9912).
3363
a64bfdfa 33642011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3365
3366 * xmenu.c (cleanup_widget_value_tree): New function.
3367 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3368 calling free_menubar_widget_value_tree directly (Bug#9830).
3369
cb41b32a
PE
33702011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3371
3372 Fix some portability problems with 'inline'.
3373 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3374 (window_box_width, window_box_left, window_box_left_offset)
3375 (window_box_right, window_box_right_offset): Declare extern.
3376 Otherwise, these inline functions do not conform to C99 and
3377 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3378 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3379 * intervals.c (adjust_intervals_for_insertion)
3380 (adjust_intervals_for_deletion): Now extern, because otherwise the
3381 extern inline functions 'offset_intervals' couldn't refer to it.
3382 (static_offset_intervals): Remove.
3383 (offset_intervals): Rewrite using the old contents of
3384 static_offset_intervals. The old version didn't conform to C99
3385 because an extern inline function contained a reference to an
3386 identifier with static linkage.
3387
b7041366
AS
33882011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3389
3390 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3391 GC.
3392
88a37c4d
EZ
33932011-11-06 Eli Zaretskii <eliz@gnu.org>
3394
3395 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3396 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3397 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3398 return Qleft_to_right.
3399
49745b39
CY
34002011-11-06 Chong Yidong <cyd@gnu.org>
3401
3402 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3403 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3404 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3405 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3406 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3407 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3408 (Fwindow_vscroll): Doc fix.
3409 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3410 argument, since it makes no sense to pass a live window and for
3411 consistency with window-child.
3412
1f05cd82
CS
34132011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3414
3415 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3416 support MSVC.
3417
22610910
JR
34182011-11-05 Jason Rumney <jasonr@gnu.org>
3419
3420 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3421 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3422 fonts (Bug#6029).
3423 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3424 bitwise arithmetic preventing use of unicode-sip and non-truetype
3425 opentype fonts.
3426
a06776b2
EZ
34272011-11-05 Eli Zaretskii <eliz@gnu.org>
3428
3ad924ba
EZ
3429 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3430 "emacs"-only part.
3431
a06776b2
EZ
3432 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3433 initialization code to keep similarity to xfns.c after changes
3434 from 2011-11-05.
3435
c9e7db78
JD
34362011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3437
a97f8f3f
JD
3438 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3439 (unwind_create_frame): New function (Bug#9943).
3440 (Fx_create_frame): Restructure code to be more similar to the one in
3441 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3442 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3443 Move terminal->reference_count++ just before making the frame official
3444 (Bug#9943).
3445
3446 * nsterm.m (x_free_frame_resources): New function.
3447 (x_destroy_window): Move code to x_free_frame_resources.
3448
c9e7db78 3449 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3450 (Fx_create_frame, x_create_tip_frame):
3451 Move terminal->reference_count++ just before making the frame
75f1671a 3452 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3453 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3454
a6fc3b5c
EZ
34552011-11-05 Eli Zaretskii <eliz@gnu.org>
3456
3457 Support MSVC build with newer versions of Visual Studio.
3458 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3459 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3460 nt/gmake.defs.
3461
3462 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3463 which are not supported by MSVC.
3464 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3465 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3466 bitfields.
3467 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3468 types in bitfields.
3469 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3470
3471 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3472
58179cce 34732011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3474
3475 Support MSVC build with newer versions of Visual Studio.
3476 * w32.c: Don't include w32api.h for MSVC.
3477 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3478
3479 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3480 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3481 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3482 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3483 e_* cousins.
3484 (alloca) [_MSC_VER]: Define to _alloca.
3485
3486 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3487
3488 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3489
a58c13ed
EZ
34902011-11-04 Eli Zaretskii <eliz@gnu.org>
3491
3492 * xdisp.c (note_mouse_highlight): If either of
3493 previous/next-single-property-change returns nil, treat that as
3494 the beginning or the end of the buffer. (Bug#9955)
3495
fe0b6370
JD
34962011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3497
a58c13ed 3498 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3499 label is not null (Bug#9951).
3500 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3501 may be NULL.
3502
89bd5ee1
EZ
35032011-11-04 Eli Zaretskii <eliz@gnu.org>
3504
3505 * window.c (Fwindow_body_size): Mention in the doc string that the
3506 return value is in frame's canonical units. (Bug#9949)
3507
84c3edb9
EZ
35082011-11-03 Eli Zaretskii <eliz@gnu.org>
3509
4e2fb5c7
EZ
3510 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3511
84c3edb9 3512 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3513 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3514 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3515
bc17a887
EZ
35162011-11-01 Eli Zaretskii <eliz@gnu.org>
3517
3518 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3519 Don't stop backward scan on the continuation glyph, even though
3520 its CHARPOS is positive.
6d5eb5b0
SM
3521 (mouse_face_from_buffer_pos, note_mouse_highlight):
3522 Rename cover_string to disp_string.
bc17a887 3523
4ee88440
MR
35242011-11-01 Martin Rudalics <rudalics@gmx.at>
3525
3526 * window.c (temp_output_buffer_show): Don't use
3527 Vtemp_buffer_show_specifiers.
3528 (Vtemp_buffer_show_specifiers): Remove unused variable.
3529
c2ff3c02
EZ
35302011-10-30 Eli Zaretskii <eliz@gnu.org>
3531
3532 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3533 past the beginning of the current glyph matrix.
3534
58179cce 35352011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3536
3537 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3538 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3539 HAVE_GTK3 (Bug#9869).
b77a6a7f 3540
3b574623
JD
3541 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3542 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3543
b77a6a7f
JD
3544 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3545
3546 * xterm.c: Declare x_handle_net_wm_state to return int.
3547 (handle_one_xevent): Check if we are iconified but don't have
3548 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3549 (get_current_wm_state): Return non-zero if not hidden,
3550 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3551 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3552 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3553 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3554
196e41e4
PE
35552011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3558 so that this new function doesn't get optimized away by a
3559 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3560
021f2e1a
AS
35612011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3562
3563 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3564
8b058d44
EZ
35652011-10-29 Eli Zaretskii <eliz@gnu.org>
3566
3567 Fix the `xbytecode' command.
3568 * .gdbinit (xprintbytestr): New command.
b50a28de 3569 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3570 (xbytecode): Print the byte-code string as well.
3571
4452fb80
EZ
35722011-10-29 Kim Storm <storm@cua.dk>
3573
8b058d44
EZ
3574 * alloc.c (which_symbols): New function.
3575
21b72067
AS
35762011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3577
3578 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3579 line. (Bug#9903)
3580
83ed7b5c
GM
35812011-10-29 Glenn Morris <rgm@gnu.org>
3582
3583 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3584 Not clear what it was for, and it causes various bugs. (Bug#9839)
3585
5a7a728b
EZ
35862011-10-28 Eli Zaretskii <eliz@gnu.org>
3587
3588 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3589 possible random value that matches one of those tested as
3590 condition to clear the mouse face.
3591
d3d0842f
CY
35922011-10-28 Chong Yidong <cyd@gnu.org>
3593
3594 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3595
31b39d13
DN
35962011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3597
3598 * window.c (make_window): Initialize phys_cursor_on_p.
3599
9aba6043
SM
36002011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3601
3602 * lisp.h (struct Lisp_Symbol): Update comments.
3603
c20992f4
JB
36042011-10-28 Juanma Barranquero <lekktu@gmail.com>
3605
3606 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3607
db4f02f2
EZ
36082011-10-28 Eli Zaretskii <eliz@gnu.org>
3609
3610 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3611 <oslsachem@gmail.com> for helping to debug this.
3612
3613 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3614 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3615 (g_b_init_get_glyph_outline_w): New static variables.
3616 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3617 (GetGlyphOutlineW_Proc): New typedefs.
3618 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3619 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3620 New functions.
3621 (w32font_open_internal, compute_metrics):
3622 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3623 instead of calling the "wide" APIs directly.
3624
3625 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3626
3627 * w32.h (syms_of_w32font): Add prototype.
3628
87e68db4
JB
36292011-10-27 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3632 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3633 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3634 (Fmove_to_window_line): Doc fix.
3635
435c1d67
CY
36362011-10-27 Chong Yidong <cyd@gnu.org>
3637
3638 * process.c (make_process): Set gnutls_state to NULL.
3639
3640 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3641 non-NULL, regardless of GNUTLS_INITSTAGE.
3642 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3643 an error. Set process slots as soon as we allocate them.
3644
3645 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3646
9c6c6f49
CY
36472011-10-27 Chong Yidong <cyd@gnu.org>
3648
9aba6043
SM
3649 * gnutls.c (emacs_gnutls_deinit): New function.
3650 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3651 (Fgnutls_deinit, Fgnutls_boot): Use it.
3652
3653 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3654 (deactivate_process): Call emacs_gnutls_deinit.
3655
657d08d3
JB
36562011-10-27 Juanma Barranquero <lekktu@gmail.com>
3657
3658 * image.c (x_create_x_image_and_pixmap):
3659 * w32.c (sys_rename, w32_delayed_load):
3660 * w32font.c (fill_in_logfont):
3661 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3662
5430d399
JB
36632011-10-26 Juanma Barranquero <lekktu@gmail.com>
3664
3665 * w32fns.c (w32_default_color_map): New function,
3666 extracted from Fw32_default_color_map.
a7ef684b 3667 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3668
fe0055fa
PE
36692011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3672
e6346438
SM
36732011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3674
3675 * keyboard.c (test_undefined): New function (bug#9751).
3676 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3677
e112cc37
ET
36782011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3679
3680 * sysdep.c (init_sys_modes): Fix the check for the controlling
3681 terminal (Bug#6649).
3682
7b5d6677
EZ
36832011-10-20 Eli Zaretskii <eliz@gnu.org>
3684
3685 * dispextern.h (struct bidi_it): New member next_en_type.
3686
3687 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3688 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3689 current character, check also for next_en_type being WEAK_EN.
3690 (bidi_resolve_weak): Don't enter the expensive loop if the current
3691 position is before next_en_pos. Record the bidi type of the first
3692 non-ET, non-BN character we find, in addition to its position.
3693 (bidi_level_of_next_char): Invalidate next_en_type when
3694 next_en_pos is over-stepped.
3695
7da0b018
PE
36962011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3697
3698 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3699 * editfns.c: Rewrite current-time-zone so that it invokes
3700 the equivalent of (format-time-string "%Z") to get the time zone name.
3701 This fixes a bug when the time zone name contains characters that
3702 need converting from the system time locale to Emacs internal format.
3703 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3704 that patch fixed format-time-string to do the conversion, but
3705 I forgot to fix current-time-zone.
3706 (format_time_string): New function, containing most of
3707 what Fformat_time_string used to contain.
3708 (Fformat_time_string): Rewrite in terms of format_time_string.
3709 This doesn't change this function's behavior.
3710 (current-time-zone): Rewrite to use format_time_string.
3711 This fixes the bug reported by Michael Schierl in
3712 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3713 Jason Rumney's 2007-06-07 change worked around this bug, but
3714 didn't fix it.
3715 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3716
8547b010
EZ
37172011-10-19 Eli Zaretskii <eliz@gnu.org>
3718
3719 * xdisp.c (start_display): If the character at POS is displayed
3720 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3721 (try_window_reusing_current_matrix): If a line ends in a display
3722 vector or the next line starts in a display vector, continue
3723 redrawing the window even though the character position of
3724 start_row was reached.
8547b010
EZ
3725 (Bug#9771, part 2)
3726
4e948d15
CY
37272011-10-18 Chong Yidong <cyd@gnu.org>
3728
3729 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3730 with nobreak-char-display too.
3731
4787455f
EZ
37322011-10-18 Eli Zaretskii <eliz@gnu.org>
3733
3734 Fix part 3 of bug#9771.
3735 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3736 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3737 non-neutral characters if the current character is a paragraph
3738 separator (a.k.a. Newline). This avoids running the same
3739 expensive loop twice, once when we consume the preceding newline
3740 and the other time when the line actually needs to be displayed.
3741 Avoid the loop when we see neutrals on the base embedding level
3742 following a character whose directionality is the same as the
3743 paragraph's. This avoids running the expensive loop when a line
3744 ends in a long sequence of neutrals, like control characters.
3745 Add assertion against STRONG_AL type. Slightly rearrange code
3746 that determines the type of a neutral given the first non-neutral
3747 that follows it.
3748 (bidi_level_of_next_char): Set next_en_pos to zero when
3749 invalidating its info.
3750
2c91f553
EZ
37512011-10-17 Eli Zaretskii <eliz@gnu.org>
3752
3753 * xdisp.c (push_display_prop): Determine whether to record string
3754 or buffer position by IT->string, not by IT->method. Allow
3755 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3756 (move_it_vertically_backward): Don't look for character position
3757 immediately after the newline when in a continuation line.
3758 (Bug#9771, part 1)
2c91f553 3759
c7b08b0d
MR
37602011-10-15 Martin Rudalics <rudalics@gmx.at>
3761
3762 * window.c (coordinates_in_window): Rewrite and delabelize
3763 vertical border check. (Bug#5357) (Bug#9618)
3764
6b02f655
SM
37652011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3766
3767 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3768 errors in XSetWindowBorder (bug#9310).
3769
81d40c92
DA
37702011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3771
3772 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3773 avoid crash when xmalloc overrun checking is enabled.
3774
d4172c3b
EZ
37752011-10-13 Eli Zaretskii <eliz@gnu.org>
3776
3777 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3778 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3779 cursor motion with <left> and <right> arrow keys.
3780
3781 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3782 some callers set that themselves.
3783
b00eea75
EZ
37842011-10-12 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3787 display string and the previous row comes from the same string and
3788 is empty. (Bug#9739) (Bug#9738)
3789
8fe012c4
SM
37902011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3791
3792 * doc.c (get_doc_string): Encode file name (bug#9735).
3793
0074aef2
EZ
37942011-10-12 Eli Zaretskii <eliz@gnu.org>
3795
79beb178
EZ
3796 * bidi.c (bidi_level_of_next_char):
3797 * xdisp.c (get_visually_first_element): Remove old incorrect
3798 comments regarding the Unicode Line Separator character.
3799
0074aef2
EZ
3800 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3801
6e4b3fbe
DA
38022011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3803
3804 * alloc.c (Fgc_status): Do not access beyond zombies array
3805 boundary if nzombies > MAX_ZOMBIES.
3806 * alloc.c (dump_zombies): Add missing format specifier.
3807
0324f3af
PE
38082011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3809
b5525cac
PE
3810 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3811 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3812
0324f3af
PE
3813 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3814 Some packages use them to denote characters with modifiers.
3815
e9b5f888
AS
38162011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3817
3818 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3819 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3820 matching a pp-number. Rename parameter var to var1.
3821
127827c0
SM
38222011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3823
3824 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3825
c8fd3bd0
GM
38262011-10-08 Glenn Morris <rgm@gnu.org>
3827
3828 * callint.c (Fcall_interactively): Give a more explicit error for the
3829 'c' case with a non-character input. (Bug#8479)
3830
352ec8ff
EZ
38312011-10-08 Eli Zaretskii <eliz@gnu.org>
3832
03669ccb
EZ
3833 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3834 lines.
7061c986
EZ
3835 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3836 lines that are hscrolled on the left.
03669ccb 3837
352ec8ff
EZ
3838 * dispnew.c (buffer_posn_from_coords): Account for a possible
3839 presence of header-line. (Bug#4426)
3840
a66cfb1c
SM
38412011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3842
6b02f655
SM
3843 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3844 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3845
7c5ee88e
PE
38462011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3849 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3850 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3851 this makes Emacs dump core during garbage collection on rare
3852 occasions. sizeof is obviously inferior to offsetof here, so
3853 stick with offsetof.
3854 (GC_POINTER_ALIGNMENT): New macro.
3855 (mark_memory): Omit 3rd (offset) arg; caller changed.
3856 Don't assume EMACS_INT alignment is the same as pointer alignment.
3857
df1bbe5b
SM
38582011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3859
3860 * keyboard.c (read_key_sequence_remapped): New var.
3861 (read_key_sequence): Compute remapping in the right buffer.
3862 (command_loop_1): Use read_key_sequence's remapping directly.
3863
51553db6
SM
38642011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3865
32c1fffd
SM
3866 * dired.c (file_name_completion): Don't expand file name.
3867 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3868 before checking file name handler.
3869
51553db6
SM
3870 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3871 they've been requested explicitly (bug#9591).
3872
b6bd1599 38732011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3874
3875 * keymap.c (Fsingle_key_description): Use make_specified_string
3876 instead of build_string to build string from push_key_description.
3877 (Bug#5193)
3878
f701dc2a
PE
38792011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3880
4222c55d
PE
3881 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3882 This fixes a Y2038 bug on 64-bit hosts.
3883 * buffer.c (reset_buffer):
3884 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3885 (Fclear_buffer_auto_save_failure):
3886 Use 0, not -1, to represent an unset failure time, since time_t
3887 might not be signed.
3888
f701dc2a
PE
3889 Remove dependency on glibc malloc internals.
3890 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3891 Move back here from lisp.h, but with their new implementations.
3892 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3893 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3894 * charset.c (charset_table_init): New static var.
3895 (syms_of_charset): Use it instead of xmalloc. This removes a
3896 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3897 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3898 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3899 Move back to alloc.c.
3900 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3901 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3902
9ceebf39
JD
39032011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3904
3905 * nsterm.m (windowDidResize): Call x_set_window_size only when
3906 ns_in_resize is true. Otherwise set pixelwidth/height and
3907 call change_frame_size (Bug#9628).
3908
cb993c58
PE
39092011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3910
3930c88b
PE
3911 Port --enable-checking=all to Fedora 14 x86-64.
3912 * charset.c (syms_of_charset): Also account for glibc malloc's
3913 internal overhead when calculating the initial malloc maximum.
3914
cb993c58
PE
3915 Port --enable-checking=all to Fedora 14 x86.
3916 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3917 Move to lisp.h.
3918 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3919 (overrun_check_realloc, overrun_check_free):
3920 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3921 That way, xmalloc returns a properly-aligned pointer even if
3922 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3923 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3924 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3925 into account when calculating the initial malloc maximum.
3926 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3927 Move here from alloc.c, so that charset.c can use it too.
3928 Properly align; the old code wasn't right for common 32-bit hosts
3929 when configured with --enable-checking=all.
3930 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3931 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3932
31bed486
EZ
39332011-09-29 Eli Zaretskii <eliz@gnu.org>
3934
04c70788 3935 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3936 use EDOM.
3937
fbcaa2f3
EZ
39382011-09-28 Eli Zaretskii <eliz@gnu.org>
3939
3940 * xdisp.c (compute_display_string_end): If there's no display
3941 string at CHARPOS, return -1.
3942
3943 * bidi.c (bidi_fetch_char): When compute_display_string_end
3944 returns a negative value, treat the character as a normal
3945 character not covered by a display string. (Bug#9624)
3946
a239d4e9
JB
39472011-09-28 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * lread.c (Fread_from_string): Fix typo in docstring.
3950
88652fd5
EZ
39512011-09-27 Eli Zaretskii <eliz@gnu.org>
3952
3953 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3954 newline, reseat the iterator instead of bidi-iterating there one
3955 character at a time. (Bug#9610)
32c1fffd
SM
3956 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3957 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3958
ed497dd4
AS
39592011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3960
3961 * lread.c (readevalloop): Use correct code for NBSP.
3962 (read1): Likewise. (Bug#9608)
3963
b2bf61aa
MA
39642011-09-25 Michael Albinus <michael.albinus@gmx.de>
3965
3966 * dbusbind.c (Fdbus_register_signal): When service is not
3967 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3968
32bbb17c
GM
39692011-09-25 Glenn Morris <rgm@gnu.org>
3970
3971 * buffer.c (truncate-lines): Doc fix.
3972
94e0933e
CY
39732011-09-24 Chong Yidong <cyd@stupidchicken.com>
3974
3975 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3976 (Fset_window_next_buffers): Doc fix.
3977
cddde921
GM
39782011-09-24 Glenn Morris <rgm@gnu.org>
3979
3980 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3981
1260aef1
PE
39822011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3983
25b4bfa0
PE
3984 Fix minor problems found by static checking.
3985 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3986 * indent.c (Fvertical_motion): Fix == vs = typo.
3987
e3cbd34b
EZ
39882011-09-24 Eli Zaretskii <eliz@gnu.org>
3989
a66cfb1c
SM
3990 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3991 Default value is now t. Doc fix.
6bf7006f 3992
e3cbd34b 3993 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3994 logic when moving up, not only when moving down. Fix the
e3cbd34b 3995 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3996 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3997
3998 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3999 CHARPOS is covered by a display string which includes newlines.
4000 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4001 is covered by a display string with embedded newlines.
4002
a3de0cbd
MA
40032011-09-24 Michael Albinus <michael.albinus@gmx.de>
4004
4005 * dbusbind.c (Fdbus_register_signal): Add match rule to
4006 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4007 (Fdbus_register_method, Vdbus_registered_objects_table):
4008 Fix docstring.
a3de0cbd 4009
b260039d
JM
40102011-09-24 Jim Meyering <meyering@redhat.com>
4011
32c1fffd 4012 do not ignore write error for any output size
b260039d
JM
4013 The previous change was incomplete.
4014 While it makes emacs --batch detect the vast majority of stdout
4015 write failures, errors were still ignored whenever the output size is
4016 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4017 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4018 && echo FAIL: ignored write error
4019 FAIL: ignored write error
4020 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4021 && echo FAIL: ignored write error
4022 FAIL: ignored write error
4023 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4024
8eca8a7c
AS
40252011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4026
4027 * emacs.c (Fkill_emacs): In noninteractive mode exit
4028 non-successfully if a write error occurred on stdout. (Bug#9574)
4029
3341db62
EZ
40302011-09-21 Eli Zaretskii <eliz@gnu.org>
4031
4032 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4033 the xassert test.
4034
4035 * dispextern.h (struct it): Update the comment documenting what
4036 can it->OBJECT be.
4037
8c203dbf
EZ
40382011-09-20 Eli Zaretskii <eliz@gnu.org>
4039
4040 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4041 a display string, extend search for cursor position to end of row.
4042 (find_row_edges): If the row ends in a newline from a display
4043 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4044 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4045 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4046 non-empty line. Fixes confusing cursor motion with arrow keys at
4047 the beginning of a line that starts with whitespace.
8c203dbf 4048
a4824228
LMI
40492011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4050
4051 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4052 (bug#9493).
4053
33ed493b
CY
40542011-09-18 Chong Yidong <cyd@stupidchicken.com>
4055
4056 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4057 boolean (Bug#9154).
4058
56cd55c8
EZ
40592011-09-18 Eli Zaretskii <eliz@gnu.org>
4060
4061 * xdisp.c (display_line): Record maximum and minimum buffer
4062 positions even if no glyphs were produced (e.g., by a zero-width
4063 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4064 buffer positions that will be removed from the glyph row because
4065 they don't fit.
c02dcedf
EZ
4066 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4067 column is beyond frame width: don't subtract 1 "pixel" when
4068 computing width of the stretch.
3e62b7e0
EZ
4069 (reseat_at_next_visible_line_start): Undo the change made on
4070 2011-09-17 that saved paragraph information and restored it after
4071 the call to `reseat'. (Bug#9545)
56cd55c8 4072
5ed99d36 40732011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4074
4075 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4076 and turn window cursor on if cleared (Bug#9415).
4077
5ed99d36 40782011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4079
4080 * search.c (boyer_moore): Take unibyte characters from pattern
4081 literally. (Bug#9458)
4082
9bade7b2
EZ
40832011-09-18 Eli Zaretskii <eliz@gnu.org>
4084
4085 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4086
e5e9d610
PE
40872011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4088
87e4427a
PE
4089 Fix minor problem found by static checking.
4090 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4091 initialized, to pacify gcc -Wuninitialized.
4092
e5e9d610
PE
4093 * fileio.c: Report proper errno when syscall falls.
4094 (Finsert_file_contents): Save and restore errno,
4095 so that report_file_error outputs the correct diagnostic.
4096 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4097
a1674f0b
EZ
40982011-09-18 Eli Zaretskii <eliz@gnu.org>
4099
4100 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4101
fbfb6dd4
EZ
41022011-09-17 Eli Zaretskii <eliz@gnu.org>
4103
4104 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4105 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4106
bb187662
EZ
41072011-09-17 Eli Zaretskii <eliz@gnu.org>
4108
1137e8b8 4109 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4110 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4111
4112 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4113 (bidi_find_paragraph_start): Search back for paragraph beginning
4114 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4115 (bidi_move_to_visually_next): Only trigger paragraph-related
4116 computations when the last character is a newline or at EOB, not
4117 just any NEUTRAL_B. (Bug#9470)
4118
bb187662
EZ
4119 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4120 truncated lines if point is covered by a display string. (Bug#9524)
4121
2e621251
PE
41222011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4125 (cons_to_x_long): New function.
4126 (lisp_data_to_selection_data): Use it. Correct the test for
4127 short-versus-long data; it was negated. Break out of vector
4128 loop, for efficiency, when a long datum is discovered.
4129
91a15bc6
SM
41302011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4131
4132 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4133
b41c3a35
EZ
41342011-09-16 Eli Zaretskii <eliz@gnu.org>
4135
4136 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4137 GCC PR/17406) by declaring this function with external scope.
4138
7812ba2d
PE
41392011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4142 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4143
cf7edc2a
AS
41442011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4145
4146 * editfns.c (Fformat): Correctly handle text properties on "%%".
4147
bd01620e
EZ
41482011-09-15 Eli Zaretskii <eliz@gnu.org>
4149
4150 * xterm.c (x_draw_composite_glyph_string_foreground):
4151 * w32term.c (x_draw_composite_glyph_string_foreground):
4152 * term.c (encode_terminal_code):
4153 * composite.c (composition_update_it, get_composition_id):
4154 * xdisp.c (get_next_display_element)
4155 (fill_composite_glyph_string): Add comments about special meaning
4156 of TAB characters in a composition.
4157
a02719a3
PE
41582011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4159
4160 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4161 This occurs when processing a multibyte format.
4162 Problem reported by Wolfgang Jenker.
a02719a3 4163
72589a3c
JB
41642011-09-15 Johan Bockgård <bojohan@gnu.org>
4165
4166 * xdisp.c (try_cursor_movement): Only check for exact match if
4167 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4168
1c14176c
PE
41692011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4170
4171 Remove unused external symbols.
4172 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4173 * xdisp.c (calc_pixel_width_or_height): Now static.
4174 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4175 * indent.c (check_display_width):
4176 * w32term.c: Fix comment to match code.
4177 * xterm.c, xterm.h (x_catching_errors): Remove.
4178
d2eea5b5
PE
41792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 * xselect.c: Use signed conversions more consistently (Bug#9498).
4182 (selection_data_to_lisp_data): Assume incoming selection data are
4183 signed integers, not unsigned. This is to be consistent with
4184 outgoing selection data, which was modified to use signed integers
4185 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4186 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4187 expects long, not unsigned long.
4188
46888499
EZ
41892011-09-14 Eli Zaretskii <eliz@gnu.org>
4190
4191 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4192 computation of loop end. Reported by Johan Bockgård
4193 <bojohan@gnu.org>.
4194
ef8ef9fb
CY
41952011-09-13 Chong Yidong <cyd@stupidchicken.com>
4196
4197 * frame.c (Fother_visible_frames_p): Function deleted.
4198
fa819fed
EZ
41992011-09-12 Eli Zaretskii <eliz@gnu.org>
4200
4201 * indent.c (compute_motion): Process display vector front to back
4202 rather than the other way around. (Bug#2496)
4203
2ba8e008
SM
42042011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4205
4206 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4207
20f53c69
CY
42082011-09-11 Chong Yidong <cyd@stupidchicken.com>
4209
4210 * minibuf.c (Fread_from_minibuffer): Doc fix.
4211
d562d7a4
EZ
42122011-09-11 Eli Zaretskii <eliz@gnu.org>
4213
4214 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4215 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4216
1c4d7f3d
LMI
42172011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4218
4219 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4220 value for non-existent files.
4221
b885bf36
EZ
42222011-09-11 Eli Zaretskii <eliz@gnu.org>
4223
4224 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4225 set its "size" to -1. This will set the modtime_size field of
4226 the corresponding buffer to -1, which is what
4227 verify-visited-file-modtime expects for files that do not exist.
4228 (Bug#9139)
4229
6612f0bf
PE
42302011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4231
4232 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4233 here ...
4234 * lisp.h: ... from here. push_key_description is no longer
4235 defined in keyboard.c, so its declaration should not be in
4236 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4237 logically belongs with push_key_description.
4238
dfb3f755
PE
42392011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 * buffer.h: Include <sys/types.h> instead of <time.h>.
4242 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4243 Problem reported by Herbert J. Skuhra.
4244
3134906c
LMI
42452011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4246
4247 * xml.c (parse_region): Make the parsing work for
4248 non-comment-starting XML files again (bug#9144).
4249
8d903f4e
AS
42502011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4251
4252 * image.c (gif_load): Fix calculation of bottom and right corner.
4253 (Bug#9468)
4254
80ad64f4
EZ
42552011-09-10 Eli Zaretskii <eliz@gnu.org>
4256
4257 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4258 redisplay in small windows.
4259
208a048d
EZ
42602011-09-09 Eli Zaretskii <eliz@gnu.org>
4261
4262 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4263
9b1c252e
MR
42642011-09-08 Martin Rudalics <rudalics@gmx.at>
4265
4266 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4267 Operate on live windows only.
4268
2949f33b
JB
42692011-09-08 Juanma Barranquero <lekktu@gmail.com>
4270
4271 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4272
e08dcafd
EZ
42732011-09-07 Eli Zaretskii <eliz@gnu.org>
4274
4275 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4276 only under bidi iteration.
4277
115b96bd
JD
42782011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4279
4280 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4281
c8199d0f
PE
42822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4283
4284 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4285 Without this fix, the command to link temacs failed due to an
4286 undefined symbol __builtin_isnan. This is because
4287 /usr/include/iso/math_c99.h #defines isnan(x) to
4288 __builtin_isnan(x), but the bundled gcc, which identifies itself
4289 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4290 a __builtin_isnan.
4291 * floatfns.c (isnan): #undef, and then #define to a clone of
4292 what's in data.c.
4293 (Fisnan): Always define, since it's always available now.
4294 (syms_of_floatfns): Always define isnan at the Lisp level.
4295
e39b275c 42962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4297
4298 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4299
b2db44d9 43002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4301
f4af5137 4302 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4303 The previous code assumed that file offsets (off_t values) fit in
4304 EMACS_INT variables, which is not true on typical 32-bit hosts.
4305 The code messed up by falsely reporting buffer overflow in cases
4306 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4307 when "big" contains more than 2**29 bytes, even though this
4308 inserts just one byte and does not overflow the buffer.
4309 (Finsert_file_contents): Store file offsets as off_t
4310 values, not as EMACS_INT values. Check for overflow when
4311 converting between EMACS_INT and off_t. When checking for
4312 buffer overflow or for overlap, take the offsets into account.
4313 Don't use EMACS_INT for small values where int suffices.
4314 When checking for overlap, fix a typo: ZV was used where
4315 ZV_BYTE was intended.
4316 (Fwrite_region): Don't assume off_t fits into 'long'.
4317 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4318
ecfc0a49
MA
43192011-09-05 Michael Albinus <michael.albinus@gmx.de>
4320
4321 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4322
6511acf2 43232011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4324
0999621a 4325 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4326
4327 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4328 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4329 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4330 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4331 (modify_event_symbol): Do not assume that the length of
4332 name_alist_or_stem is safe to alloca and fits in int.
4333 (Fexecute_extended_command): Likewise for function name and binding.
4334 (Frecursion_depth): Wrap around reliably on integer overflow.
4335 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4336 since some callers pass EMACS_INT values.
4337 (Fsingle_key_description): Don't crash if symbol name contains more
4338 than MAX_ALLOCA bytes.
4339 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4340 (get_minibuffer): Arg is now EMACS_INT, not int.
4341 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4342 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4343 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4344
2be7d702
PE
4345 * dbusbind.c (signature_cat): New function.
4346 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4347 Do not overrun buffer; instead, report string overflow.
4348
9d1df220
PE
4349 * dispnew.c (add_window_display_history): Don't overrun buffer.
4350 Truncate instead; this is OK since it's just a log.
4351
33ef5c64
PE
4352 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4353 even if the time zone offset is outlandishly large.
4354 Don't mishandle offset == INT_MIN.
4355
66c6fdd5
PE
4356 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4357 when creating daemon; the previous buffer-overflow check was incorrect.
4358
d749b01b
PE
4359 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4360 which has the guts of the old verror function.
4361
b5cd1905
PE
4362 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4363 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4364
6e1a67fb
PE
4365 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4366 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4367 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4368 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4369 length of string rather than counting it via multiple sprintfs;
4370 that's simpler and more reliable.
c21721cc
PE
4371 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4372 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4373 sprintf, in case result does not fit in int.
4374
c57b67fc
PE
4375 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4376 (fontset_from_font): Print it.
4377
8a401434
PE
4378 * frame.c (tty_frame_count): Now printmax_t, not int.
4379 (make_terminal_frame, set_term_frame_name): Print it.
4380 (x_report_frame_params): In X, window IDs are unsigned long,
4381 not signed long, so print them as unsigned.
4382 (validate_x_resource_name): Check for implausibly long names,
4383 and don't assume name length fits in 'int'.
4384 (x_get_resource_string): Don't blindly alloca invocation name;
4385 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4386 not fit in int.
4387
6e1a67fb
PE
4388 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4389 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4390 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4391
0df02bf3
PE
4392 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4393 Use esprintf, not sprintf, in case result does not fit in int.
4394
48e30793
PE
4395 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4396 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4397 it as a large positive number.
4398 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4399 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4400
a66ff6d8
PE
4401 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4402 in case result does not fit in int.
4403
aca216ff
PE
4404 * print.c (float_to_string): Detect width overflow more reliably.
4405 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4406 buffer overrun. Don't assume list length fits in 'int'. Treat
4407 print length of 0 as 0, not as infinity; to be consistent with other
4408 uses of print length in this function. Don't overflow print length
4409 index. Don't assume hash table size fits in 'long', or that
4410 vectorlike size fits in 'unsigned long'.
4411
31c286f7
PE
4412 * process.c (make_process): Use printmax_t, not int, to format
4413 process-name gensyms.
4414
55e5faa1
PE
4415 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4416
80f2e268
PE
4417 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4418 to avoid potential buffer overrun.
4419
670741ab
PE
4420 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4421 if X resource line is longer than 512 bytes.
4422
b7163a50
PE
4423 * xfns.c (x_window): Make sprintf buffer a bit bigger
4424 to avoid potential buffer overrun.
4425
ae58ff1f
PE
4426 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4427
c43c8a6a
PE
4428 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4429
3f8236f4
PE
44302011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4431
53e9fe90 4432 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4433 Without these, Emacs silently mishandles large integers sometimes.
4434 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4435 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4436
6511acf2
PE
4437 * xdisp.c (try_window_id): Check Emacs fixnum range before
4438 converting to 'int'.
806add1d 4439
6511acf2 4440 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4441 Check that an Emacs fixnum is in range before assigning it to 'int'.
4442 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4443 values converted from Emacs fixnums.
4444 (Frecenter): Don't wrap around a line count if it is out of 'int'
4445 range; instead, treat it as an extreme value.
4446 (Fset_window_configuration, compare_window_configurations):
4447 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4448
6511acf2
PE
4449 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4450 that can exceed INT_MAX. Check that EMACS_INT value is in range
4451 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4452 (match_limit): Don't assume that a fixnum can fit in 'int'.
4453
6511acf2 4454 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4455 exceed INT_MAX.
4456
6511acf2 4457 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4458 (Fvertical_motion): Don't wrap around LINES values that don't fit
4459 in 'int'. Instead, treat them as extreme values. This is good
4460 enough for windows, which can't have more than INT_MAX lines anyway.
4461
fcb901a7
LMI
44622011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4463
0f2f6b6d
LMI
4464 * Require libxml/parser.h to avoid compilation warning.
4465
fcb901a7
LMI
4466 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4467
4468 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4469 since this reportedly can destroy thread storage.
4470
6e20a0d4
CY
44712011-08-30 Chong Yidong <cyd@stupidchicken.com>
4472
4473 * syntax.c (find_defun_start): Update all cache variables if
4474 exiting early (Bug#9401).
4475
148ae00e
EZ
44762011-08-30 Eli Zaretskii <eliz@gnu.org>
4477
f6cfbd8f
EZ
4478 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4479
148ae00e
EZ
4480 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4481 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4482 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4483
4484 * term.c (tty_append_glyph): New function.
4485 (produce_stretch_glyph): Static function and its prototype deleted.
4486
a66cfb1c
SM
4487 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4488 Add prototypes.
148ae00e 4489
c4a07a4c
PE
44902011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4491
4492 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4493 when checking :margin (Bug#9390).
4494 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4495 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4496 so that the name doesn't mislead. All uses changed.
4497
6bc8cd65
JB
44982011-08-28 Johan Bockgård <bojohan@gnu.org>
4499
4500 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4501 set_tty_hooks.
4502
dca4927e
EZ
45032011-08-27 Eli Zaretskii <eliz@gnu.org>
4504
4505 * xdisp.c (move_it_to): Don't bail out early when reaching
4506 position beyond to_charpos, if we are scanning backwards.
4507 (move_it_vertically_backward): When DY == 0, make sure we get to
4508 the first character in the line after the newline.
4509
f2cad773
PE
45102011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4511
4512 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4513 (ccl_driver): Do not generate an out-of-range pointer.
4514 (Fccl_execute_on_string): Remove unnecessary check for
4515 integer overflow, noted by Stefan Monnier in
4516 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4517 Remove a FIXME that didn't need fixing.
4518 Simplify the newly-introduced buffer reallocation code.
4519
0cae2cdb
JB
45202011-08-27 Juanma Barranquero <lekktu@gmail.com>
4521
4522 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4523
5fc295a4 45242011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4525
70c60eb2 4526 Integer and memory overflow issues (Bug#9196).
726e0ab1 4527
d31850da
PE
4528 * doc.c (get_doc_string): Rework so that
4529 get_doc_string_buffer_size is the actual buffer size, rather than
4530 being 1 less than the actual buffer size; this makes xpalloc more
4531 convenient.
4532
a69fbedb
PE
4533 * image.c (x_allocate_bitmap_record, cache_image):
4534 * xselect.c (Fx_register_dnd_atom):
4535 Simplify previous changes by using xpalloc.
4536
fe5c5d37
PE
4537 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4538 since either will do and ptrdiff_t is convenient with xpalloc.
4539
0065d054
PE
4540 * charset.c (charset_table_size)
4541 (struct charset_sort_data.priority): Now ptrdiff_t.
4542 (charset_compare): Don't overflow if priorities differ greatly.
4543 (Fsort_charsets): Don't assume list length fits in int.
4544 Check for size-calculation overflow when allocating sort data.
4545 (syms_of_charset): Allocate an initial charset table that is
4546 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4547
4548 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4549
4550 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4551 The actual value is always <= INT_MAX, and leaving it unsigned made
4552 overflow checking harder.
4553
4554 * dispextern.h (struct glyph_matrix.rows_allocated)
4555 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4556 with xpalloc. The values are still always <= INT_MAX.
4557
4558 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4559
4560 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4561 (SAFE_NALLOCA): New macro.
4562
4563 * region-cache.c (struct boundary.pos, find_cache_boundary)
4564 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4565 (set_cache_region, invalidate_region_cache)
4566 (revalidate_region_cache, know_region_cache, region_cache_forward)
4567 (region_cache_backward, pp_cache):
4568 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4569 so that ptrdiff_t * can be passed to xpalloc.
4570 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4571 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4572 (pp_cache): Don't assume cache_len fits in int.
4573 * region-cache.h: Adjust extern decls to match.
4574
4575 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4576 EMACS_INT, since either will do, for xpalloc.
4577
4578 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4579 (xnmalloc, xnrealloc, xpalloc): New functions.
4580
726e0ab1
PE
4581 * bidi.c (bidi_shelve_header_size): New constant.
4582 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4583 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4584
51f30bc5 4585 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4586 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4587 (overlay_strings):
4588 Don't update size of array until after memory allocation succeeds,
4589 because xmalloc/xrealloc may not return.
0065d054
PE
4590 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4591 now that we have proper integer overflow checking.
4592 (record_overlay_string, overlay_strings): Catch overflows when
4593 calculating size of overlay_str_buf.
726e0ab1 4594
0065d054
PE
4595 * callproc.c (Fcall_process): Check for size overflow when
4596 calculating size of args2.
4597 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4598 Normally we prefer signed values, but sticking with ptrdiff_t would
4599 require adding more-complicated checks.
726e0ab1
PE
4600
4601 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4602 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4603 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4604 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4605
4606 * character.c (Fstring): Check for size-calculation overflow.
4607
4608 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4609 unnecessary integer overflow. Check for size overflow.
4610 (encode_coding_object): Don't update size until xmalloc succeeds.
4611
4612 * composite.c (get_composition_id): Check for overflow in glyph
4613 length calculations.
4614
4615 Integer and memory overflow fixes for display code.
4616 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4617 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4618 (scrolling_window): Check for overflow in size calculations.
4619 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4620 Don't assume glyph table len fits in int.
4621 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4622 (row_table_size): Now ptrdiff_t, not int.
4623 (scrolling_window): Avoid overflow in size calculations.
4624 Don't update size until allocation succeeds.
4625 * fns.c (concat): Check for overflow in size calculations.
4626 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4627 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4628 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4629
4630 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4631 (get_doc_string): Check for size calculation overflow.
4632 Don't update size until allocation succeeds.
4633 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4634 EMACS_INT, where ptrdiff_t will do.
4635 (Fsubstitute_command_keys): Check for string overflow.
4636
4637 * editfns.c (set_time_zone_rule): Don't assume environment length
4638 fits in int.
4639 (message_length): Now ptrdiff_t, not int.
4640 (Fmessage_box): Don't update size until allocation succeeds.
4641 Don't assume message length fits in int.
4642 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4643
0065d054
PE
4644 * emacs.c (main): Do not reallocate argv, since there is a null at
4645 the end that can be overwritten, and this way there's no need to
4646 worry about size-calculation overflow.
4647 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4648
4649 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4650 alloc succeeds.
4651 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4652
4653 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4654 (x_set_scroll_bar_width, x_figure_window_size):
4655 Check for integer overflow.
4656 (x_set_alpha): Do not assume XINT fits in int.
4657
4658 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4659 This is for the members text_lines, text_cols, total_lines, total_cols,
4660 where the system imposes an 'int' limit.
4661
4662 * fringe.c (Fdefine_fringe_bitmap):
4663 Don't update size until alloc works.
4664
4665 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4666 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4667
4668 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4669 Check for size-calculation overflow.
4670 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4671 do, as we prefer signed integers.
4672 (id_to_widget.max_size, id_to_widget.used)
4673 (xg_store_widget_in_map, xg_remove_widget_from_map)
4674 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4675 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4676 Use and return ptrdiff_t, not int.
4677 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4678 * gtkutil.h: Change prototypes to match the above.
4679
4680 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4681 are duplicate now that they've been promoted to lisp.h.
4682 (x_allocate_bitmap_record, x_alloc_image_color)
4683 (make_image_cache, cache_image, xpm_load):
4684 Don't update size until alloc is done.
4685 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4686 (x_detect_edges):
3256efce 4687 Check for size calculation overflow.
726e0ab1
PE
4688 (ct_colors_allocated_max): New constant.
4689 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4690 overflow.
3256efce 4691
726e0ab1
PE
4692 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4693 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4694 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4695 Use ptrdiff_t, not int, to count maps.
4696 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4697 calculations. Don't update size until allocation succeeds.
4698 Redo calculations to avoid overflow.
726e0ab1
PE
4699 * keyboard.h: Change prototypes to match the above.
4700
4701 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4702 to count maps.
4703 (current_minor_maps): Check for size calculation overflow.
4704 * keymap.h: Change prototypes to match the above.
4705
4706 * lread.c (read1, init_obarray): Don't update size until alloc done.
4707
4708 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4709 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4710
726e0ab1
PE
4711 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4712 Now ptrdiff_t, not int.
4713 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4714 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4715
4716 * process.c (Fnetwork_interface_list): Check for overflow
4717 in size calculation.
4718
4719 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4720
4721 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4722 overflow. Don't bother calling xmalloc when xrealloc will do.
4723
4724 * search.c (Freplace_match): Check for size calculation overflow.
4725 (Fset_match_data): Don't assume list lengths fit in 'int'.
4726
4727 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4728 for command line length. Do not attempt to address one before the
4729 beginning of an array, as that's not portable.
4730
4731 * term.c (max_frame_lines): Remove; unused.
4732 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4733 not int.
4734 (encode_terminal_code, calculate_costs): Check for size
4735 calculation overflow.
4736 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4737 table lengths and related sizes. Don't update size until alloc
4738 done. Redo calculations to avoid overflow.
4739 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4740
4741 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4742 subtracting pointers.
4743 (gobble_line): Check for overflow more carefully. Don't update size
4744 until alloc done.
4745
4746 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4747 Don't update size until alloc done.
4748 Redo size calculations to avoid overflow.
4749 Check for size calculation overflow.
0065d054 4750 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4751
4752 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4753 Use ptrdiff_t, not int, for sizes.
4754 (store_mode_line_noprop_char): Don't update size until alloc done.
4755
0065d054
PE
4756 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4757 Use ptrdiff_t, not int, for sizes.
4758 (Finternal_make_lisp_face, cache_face):
4759 Check for size calculation overflow.
4760 (cache_face): Treat size calculation overflows as if they were
4761 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4762
4763 * xfns.c (x_encode_text, x_set_name_internal)
4764 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4765 sizes, since they can exceed INT_MAX in size. Check for size
4766 calculation overflow.
4767
0065d054
PE
4768 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4769 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4770 Don't update size until alloc done.
4771
0065d054 4772 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4773 as sprintf is limited to int lengths.
1d526e2f 4774
252c5ee1
PE
4775 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4776 (X_LONG_MIN): New macros.
864d7ce7
PE
4777 Use them to make the following changes clearer.
4778 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4779 This change doesn't affect the value now, but it may help remind
4780 future maintainers not to raise the value too much later.
4781 (SELECTION_QUANTUM): Remove, replacing with ...
4782 (selection_quantum): ... new function, which avoids overflow.
4783 All uses changed.
4784 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4785 assumption that selection length fits in 'int'.
4786 (x_reply_selection_request, x_handle_selection_request)
4787 (x_get_window_property, receive_incremental_selection)
4788 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4789 (lisp_data_to_selection_data, clean_local_selection_data):
4790 Use ptrdiff_t, not int, to record length of selection.
4791 (x_reply_selection_request, x_get_window_property)
4792 (receive_incremental_selection, x_property_data_to_lisp):
4793 Redo calculations to avoid overflow.
4794 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4795 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4796 something.
4797 (x_get_window_property, receive_incremental_selection)
4798 (lisp_data_to_selection_data, x_property_data_to_lisp):
4799 Check for size-calculation overflow.
4800 (x_get_window_property, receive_incremental_selection)
4801 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4802 Don't store size until memory allocation succeeds.
4803 (x_get_window_property): Plug memory leak on memory exhaustion.
4804 Don't double-block input; malloc is safe here. Don't assume 2**34
4805 - 4 fits in unsigned long. Add an xassert to check
4806 XGetWindowProperty overflow. Be more careful about overflow
4807 calculations, and distinguish size from memory overflow better.
4808 (receive_incremental_selection): When tracing, don't assume
4809 unsigned int is less than INT_MAX.
4810 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4811 harmful) conversions of unsigned short to int.
4812 (lisp_data_to_selection_data): Don't assume that integers
4813 in the range -65535 through -1 fit in an X unsigned short.
4814 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4815 result parameters unless successful. Rely on cons_to_unsigned
4816 to report problems with elements; the old code wasn't right anyway.
4817 (x_check_property_data): Check for int overflow; we cannot use
4818 a wider type due to X limits.
4819 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4820
726e0ab1 4821 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4822
0065d054
PE
4823 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4824 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4825 (x_color_cells): Don't store size until memory allocation succeeds.
4826 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4827 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4828 (x_term_init): Don't assume length fits in int (sprintf is limited
4829 to int size).
bc18e09d 4830
ebfa62c0
PE
4831 Use ptrdiff_t for composition IDs.
4832 * character.c (lisp_string_width):
4833 * composite.c (composition_table_size, n_compositions)
4834 (get_composition_id, composition_gstring_from_id):
4835 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4836 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4837 * window.c (Frecenter):
4838 Use ptrdiff_t, not int, for composition IDs.
4839 * composite.c (get_composition_id): Check for integer overflow.
4840 * composite.h: Adjust prototypes to match the above changes.
4841
d3411f89
PE
4842 Use ptrdiff_t for hash table indexes.
4843 * category.c (hash_get_category_set):
4844 * ccl.c (ccl_driver):
4845 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4846 * coding.c (coding_system_charset_list, detect_coding_system):
4847 * coding.h (struct coding_system.id):
4848 * composite.c (get_composition_id, gstring_lookup_cache):
4849 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4850 * image.c (xpm_get_color_table_h):
4851 * lisp.h (hash_lookup, hash_put):
4852 * minibuf.c (Ftest_completion):
4853 Use ptrdiff_t for hash table indexes, not int (which is too
4854 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4855 32-bit --with-wide-int hosts).
4856
e097a6fa
PE
4857 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4858 Add a FIXME comment about memory leaks.
4859 (syms_of_charset): Don't assume xmalloc returns.
4860
5637687f
PE
4861 Don't assume that stated character widths fit in int.
4862 * character.c (Fchar_width, c_string_width, lisp_string_width):
4863 * character.h (CHAR_WIDTH):
4864 * indent.c (MULTIBYTE_BYTES_WIDTH):
4865 Use sanitize_char_width to avoid undefined and/or bad behavior
4866 with outlandish widths.
a66cfb1c 4867 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4868 now that we have two such functions. All uses changed.
4869 (sanitize_char_width): New inline function.
4870
a2271ba2
PE
4871 Don't assume that tab-width fits in int.
4872 * character.h (sanitize_width): New inline function.
4873 (SANE_TAB_WIDTH): New macro.
4874 (ASCII_CHAR_WIDTH): Use it.
4875 * indent.c (sane_tab_width): Remove. All uses replaced by
4876 SANE_TAB_WIDTH (current_buffer).
4877 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4878
18c52557
PE
4879 * fileio.c: Integer overflow issues with file modes.
4880 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4881
caeeedc1
PE
4882 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4883 Remove unreachable code.
4884 (read_hex, load_charset_map_from_file): Check for integer overflow.
4885
6df6ae42 4886 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4887 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4888 (x_send_scroll_bar_event): Likewise. Check that the size does not
4889 exceed limits imposed by XClientMessageEvent, as well as the usual
4890 ptrdiff_t and size_t limits.
4891
b13995db
PE
4892 * keyboard.c: Overflow, signedness and related fixes.
4893 (make_lispy_movement): Use same integer type in forward decl
4894 that is used in the definition.
4895 (read_key_sequence, keyremap_step):
4896 Change bufsize argument back to int, undoing my 2011-03-30 change.
4897 We prefer signed types, and int is wide enough here.
4898 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4899 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4900 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4901 length, not size_t. Use ptrdiff_t for index, not int.
4902 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4903 possibility of integer overflow.
4904
13464394
PE
4905 Overflow, signedness and related fixes for images.
4906
4907 * dispextern.h (struct it.stack[0].u.image.image_id)
4908 (struct_it.image_id, struct image.id, struct image_cache.size)
4909 (struct image_cache.used, struct image_cache.ref_count):
4910 * gtkutil.c (update_frame_tool_bar):
4911 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4912 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4913 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4914 * nsmenu.m (update_frame_tool_bar):
4915 * xdisp.c (calc_pixel_width_or_height):
4916 * xfns.c (image_cache_refcount):
4917 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4918 on typical 64-bit hosts.
4919
4920 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4921 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4922 Omit unnecessary casts to int.
4923 (parse_image_spec): Check that integers fall into 'int' range
4924 when the callers expect that.
4925 (image_ascent): Redo ascent calculation to avoid int overflow.
4926 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4927 (lookup_image): Remove unnecessary tests.
4928 (xbm_image_p): Locals are now of int, not EMACS_INT,
4929 since parse_image_check makes sure they fit into int.
4930 (png_load, gif_load, svg_load_image):
4931 Prefer int to unsigned where either will do.
4932 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4933 old tiff_error_handler and tiff_warning_handler.
4934 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4935 stack buffer overflows. It uses only the features of vsnprintf
4936 that are common to both POSIX and native Microsoft.
4937 (tiff_error_handler, tiff_warning_handler): Use it.
4938 (tiff_load, gif_load, imagemagick_load_image):
4939 Don't assume :index value fits in 'int'.
4940 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4941 (imagemagick_load_image): Check that crop parameters fit into
4942 the integer types that MagickCropImage accepts. Don't assume
4943 Vimagemagick_render_type has a nonnegative value. Don't assume
4944 size_t fits in 'long'.
4945 (gs_load): Use printmax_t to print the widest integers possible.
4946 Check for integer overflow when computing image height and width.
4947
c11821d4
EZ
49482011-08-26 Eli Zaretskii <eliz@gnu.org>
4949
4950 * xdisp.c (redisplay_window): Don't force window start if point
4951 will be invisible in the resulting window. (Bug#9324)
4952
0c95fcf7
EZ
49532011-08-25 Eli Zaretskii <eliz@gnu.org>
4954
4955 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4956 the display spec is of the form `(space ...)'.
4957 (handle_display_spec): Return the value returned by
4958 handle_single_display_spec, not just 1 or zero.
4959 (handle_single_display_spec): If the display spec is of the form
4960 `(space ...)', and specifies display in the text area, return 2
4961 rather than 1.
fee65a97 4962 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4963 accurately, and prefer exact match for point under bidi.
4964 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4965
4966 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4967 into disp_prop; all users changed.
4968
4969 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4970 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4971 for the text covered by the display property.
4972
e4ed06f1
CY
49732011-08-25 Chong Yidong <cyd@stupidchicken.com>
4974
4975 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4976 Change return value to nil.
4977 (Frecord_buffer): Delete unused function.
4978
f67cdd7f
EZ
49792011-08-24 Eli Zaretskii <eliz@gnu.org>
4980
5980d4c6
EZ
4981 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4982 buffers, return left-to-right.
8610fe8b
EZ
4983 (set_cursor_from_row): Consider candidate row a win if its glyph
4984 represents a newline and point is on that newline. Fixes cursor
4985 positioning on the newline at EOL of R2L text within L2R
4986 paragraph, and vice versa.
4987 (try_cursor_movement): Check continued rows, in addition to
4988 continuation rows. Fixes unwarranted scroll when point enters a
4989 continued line of R2L text within an L2R paragraph, or vice versa.
4990 (cursor_row_p): Consider the case of point being equal to
4991 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4992 from the end of a short line to the beginning of a continued line
4993 of R2L text within L2R paragraph.
4994 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4995 composed characters.
5980d4c6 4996
f67cdd7f
EZ
4997 * bidi.c (bidi_check_type): Use xassert.
4998 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4999 members.
5000
bca633fb
EZ
50012011-08-23 Eli Zaretskii <eliz@gnu.org>
5002
5003 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5004 a character.
5005
4a5885a7
CY
50062011-08-23 Chong Yidong <cyd@stupidchicken.com>
5007
5008 * nsfont.m (ns_otf_to_script): Fix typo.
5009
0902a04e
KH
50102011-08-22 Kenichi Handa <handa@m17n.org>
5011
5012 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5013 extra slot even if the purpose is char-code-property-table.
5014
1a2e6670
EZ
50152011-08-23 Eli Zaretskii <eliz@gnu.org>
5016
8ddde651
EZ
5017 * xdisp.c (redisplay_window): When computing centering_position,
5018 account for the height of the header line. (Bug#8874)
5019
425cc014
EZ
5020 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5021 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5022 candidate is selected by the mouse, and that candidate has a
5023 composed character under the mouse.
5024
1a2e6670
EZ
5025 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5026 coordinates reported by pos-visible-in-window-p for a composed
5027 character in column zero.
5028
8b76d6f8
SM
50292011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5030
5031 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5032
dac347dd
EZ
50332011-08-22 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5036 consider it a hit if to_charpos is anywhere in the range of the
5037 composed buffer positions.
5038
e013fb34
CY
50392011-08-22 Chong Yidong <cyd@stupidchicken.com>
5040
5041 * image.c (gif_load): Don't assume that each subimage has the same
5042 dimensions as the base image. Handle disposal method that is
5043 "undefined" by the gif spec (Bug#9335).
5044
bd1ba3e8
CY
50452011-08-20 Chong Yidong <cyd@stupidchicken.com>
5046
5047 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5048 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5049
54a1215b
EZ
50502011-08-19 Eli Zaretskii <eliz@gnu.org>
5051
823564e5
EZ
5052 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5053 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5054 from an Org mode buffer to a Speedbar frame.
5055
54a1215b
EZ
5056 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5057 a composition, take its buffer position from IT->cmp_it.charpos.
5058 Fixes cursor positioning at the beginning of a line that begins
5059 with a composed character.
5060
9778ebcc
EZ
50612011-08-18 Eli Zaretskii <eliz@gnu.org>
5062
0be6ee06
EZ
5063 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5064 character bidirectional type, use STRONG_L instead. Fixes crashes
5065 in a buffer produced by `describe-categories'.
5066
9778ebcc
EZ
5067 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5068 members before the level stack, so they would be saved and
5069 restored when copying iterator state. Fixes incorrect reordering
5070 around TABs covered by display properties.
5071
156bffbe
AS
50722011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5073
6b02f655 5074 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5075
72ad093b
CY
50762011-08-17 Chong Yidong <cyd@stupidchicken.com>
5077
5078 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5079 (internal_condition_case_2, internal_condition_case_n):
5080 Remove unnecessary aborts (Bug#9081).
72ad093b 5081
35774242
EZ
50822011-08-17 Eli Zaretskii <eliz@gnu.org>
5083
5084 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5085 has no `load' handler, try opening the file locally. (Bug#9311)
5086
db76dd85
KB
50872011-08-16 Ken Brown <kbrown@cornell.edu>
5088
5089 * gmalloc.c: Expand comment.
5090
b215eee5
EZ
50912011-08-16 Eli Zaretskii <eliz@gnu.org>
5092
5093 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5094 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5095
a4579d33
KB
50962011-08-16 Ken Brown <kbrown@cornell.edu>
5097
5098 Fix memory allocation problems in Cygwin build (Bug#9273).
5099
5100 * unexcw.c ( __malloc_initialized): Declare external variable.
5101 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5102
8b76d6f8
SM
5103 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5104 New variables.
a4579d33
KB
5105 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5106 dumped emacs.
5107 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5108 in the static heap.
5109 [CYGWIN] (special_realloc): New function.
5110 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5111 requests to realloc storage in the static heap.
5112
3ebec551
PE
51132011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5114
5115 * bidi.c (bidi_initialize): Remove unused local.
5116
9fd8be00
EZ
51172011-08-15 Eli Zaretskii <eliz@gnu.org>
5118
6b02f655
SM
5119 * bidimirror.h:
5120 * biditype.h: Remove file.
5121 * makefile.w32-in ($(BLD)/bidi.$(O)):
5122 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5123
5124 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5125
5126 * chartab.c: Improve commentary for the uniprop_table API.
5127
32413314
EZ
5128 * bidi.c (bidi_paragraph_init): Support zero value of
5129 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5130 (bidi_initialize): Use uniprop_table instead of including
5131 biditype.h and bidimirror.h.
32413314 5132
9fd8be00
EZ
5133 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5134 coordinates of the iterator when restoring from ppos_it.
5135 (Bug#9296)
5136
5cf2b69b
KH
51372011-08-14 Kenichi Handa <handa@m17n.org>
5138
5139 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5140 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5141
daf17d00
EZ
51422011-08-14 Eli Zaretskii <eliz@gnu.org>
5143
5144 * xdisp.c (move_it_in_display_line_to): Don't invoke
5145 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5146 ppos_it. Fixes vertical cursor motion when line beginning is
5147 covered by an image. (Bug#9296)
5148
08e3161a
JD
51492011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5150
5151 * nsterm.h (ns_run_ascript): Declare.
5152 (NSAPP_DATA2_RUNASSCRIPT): Define.
5153
5154 * nsfns.m (as_script, as_result, as_status): New static variables.
5155 (ns_run_ascript): New function.
5e617bc2 5156 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5157 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5158 the event loop. Get status from as_status (Bug#7276).
5159
5160 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5161 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5162 the event loop (Bug#7276).
5163
a3720aa2
AS
51642011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5165
5166 * gnutls.c (QCgnutls_bootprop_priority)
5167 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5168 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5169 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5170 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5171 (QCgnutls_bootprop_verify_hostname_error)
5172 (QCgnutls_bootprop_callbacks_verify): Rename from
5173 Qgnutls_bootprop_..., all uses changed.
5174
5175 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5176 uses changed.
5177
0a0d27fb
PE
51782011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5179
19d5c50c
PE
5180 * xfaces.c (Qframe_set_background_mode): Now static.
5181 * dispextern.h (Qframe_set_background_mode): Remove decl.
5182
0a0d27fb
PE
5183 * process.c (Fnetwork_interface_info): Declare local only if needed.
5184
377538cb
JD
51852011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5186
5187 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5188 (Fnetwork_interface_list): Allocate in increments of bytes instead
5189 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5190 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5191 sockaddr.
5192 (struct ifflag_def): notrailers is smart on OSX.
5193 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5194 Get hardware address with getifaddrs if available.
5195
08fff70c
EZ
51962011-08-12 Eli Zaretskii <eliz@gnu.org>
5197
5198 * xdisp.c (iterate_out_of_display_property): xassert that
5199 IT->position is set to within IT->object's boundaries. Break from
5200 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5201 when IT->position is set up wrongly due to some bug.
5202 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5203 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5204 entry. Force push_it to save on the stack the current
5205 buffer/string position, to be restored by pop_it. Fix flags in
5206 the iterator structure wrt the object coming from a display
5207 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5208 properties. (Bug#9284)
5209
7be1c708 52102011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5211
7be1c708
CY
5212 * fontset.c (fontset_get_font_group): Add proper type checks.
5213 (Bug#9172)
aac0c6e3 5214
7be1c708 52152011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5216
7be1c708
CY
5217 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5218 and LC_VERSION_MIN_MACOSX.
5219 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5220 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5221
97bb72a6
EZ
52222011-08-08 Eli Zaretskii <eliz@gnu.org>
5223
5224 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5225 no-display-properties-and-no-overlays under bidi display.
5226 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5227 properties and overlays.
97bb72a6 5228
d5617611
CY
52292011-08-08 Chong Yidong <cyd@stupidchicken.com>
5230
37e11a63
CY
5231 * editfns.c (Fset_time_zone_rule): Document relationship with the
5232 setenv function.
5233
d5617611
CY
5234 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5235 the font entity extracted from the cache (Bug#8109).
5236
58872834
CY
52372011-08-07 Chong Yidong <cyd@stupidchicken.com>
5238
5239 * composite.c (autocmp_chars): Don't reset point. That is done by
5240 restore_point_unwind (Bug#5984).
5241
75bfc667
JL
52422011-08-07 Juri Linkov <juri@jurta.org>
5243
5244 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5245 to show the arg `TIME' instead of `TIMEVAL'.
5246
d1410150
EZ
52472011-08-06 Eli Zaretskii <eliz@gnu.org>
5248
5249 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5250 display property strides EOL and includes a newline, as in
5251 longlines-mode. (Bug#9254)
75b771e4
EZ
5252 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5253 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5254
5255 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5256 is non-zero, even if the data buffer is NULL. Fixes a crash in
5257 vertical-motion with longlines-mode. (Bug#9254)
5258
35928349
EZ
52592011-08-05 Eli Zaretskii <eliz@gnu.org>
5260
ec7cc85b
EZ
5261 * bidi.c <bidi_cache_total_alloc>: Now static.
5262 (bidi_initialize): Initialize bidi_cache_total_alloc.
5263
8b76d6f8 5264 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5265 cache. (Bug#9221)
5266
5267 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5268 amount allocated this far in `bidi_cache_total_alloc'.
5269 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5270 non-zero, only free the data buffer without restoring the cache
5271 contents. All callers changed.
5272
5273 * dispextern.h (bidi_unshelve_cache): Update prototype.
5274
5275 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5276 (move_it_in_display_line, move_it_to)
5277 (move_it_vertically_backward, move_it_by_lines): Replace the call
5278 to xfree to an equivalent call to bidi_unshelve_cache.
5279 (move_it_in_display_line_to): Fix logic of returning
412b6358 5280 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5281
e2e2423b
EZ
52822011-08-05 Eli Zaretskii <eliz@gnu.org>
5283
5284 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5285 came from a string character with a `cursor' property. (Bug#9229)
5286
ae9e757a
JD
52872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5288
5289 * Makefile.in (LIB_PTHREAD): New variable.
5290 (LIBES): Add LIB_PTHREAD (Bug#9216).
5291
5292 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5293 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5294
213bd7f2
AS
52952011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5296
6b02f655 5297 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5298
99aaf75f
JD
52992011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5300
5301 * xterm.c (x_find_topmost_parent): New function.
5302 (x_set_frame_alpha): Find topmost parent window with
5303 x_find_topmost_parent and set the property there also (bug#9181).
5304 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5305
c74e9d86
PE
53062011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5307
5308 * callproc.c (Fcall_process): Avoid vfork clobbering
5309 the local vars buffer, coding_systems, current_dir.
5310
640c8776
SM
53112011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5312
5313 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5314
f26d0e4c
PE
53152011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5316
8a10d76c
PE
5317 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5318 so that it is not optimized away.
5319
f26d0e4c
PE
5320 * xdisp.c (compute_display_string_pos): Remove unused local.
5321
55439c61
EZ
53222011-08-02 Eli Zaretskii <eliz@gnu.org>
5323
5324 Fix slow cursor motion and scrolling in large buffers with
5325 selective display, like Org Mode buffers. (Bug#9218)
5326
5327 * dispextern.h (struct bidi_it): New member disp_prop_p.
5328
5329 * xdisp.c: Remove one-slot cache of display string positions.
5330 (compute_display_string_pos): Accept an additional argument
5e617bc2 5331 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5332 for a display string or property. If found, set DISP_PROP_P
5333 non-zero.
5334
5335 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5336 DISP_PROP_P, and pass it to compute_display_string_pos.
5337 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5338 non-zero. All callers of bidi_fetch_char changed.
5339
fb33fa43
SM
53402011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5341
5342 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5343
b099e063
DM
53442010-12-03 Don March <don@ohspite.net>
5345
5346 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5347 last character M-[char] is translated to ESC [char] (bug#7541).
5348
5cc7f7af
KH
53492011-08-02 Kenichi Handa <handa@m17n.org>
5350
d0fffa3f 5351 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5352
5353 * chartab.c (uniprop_table): Make it non-static.
5354
525d5e6e
EZ
53552011-08-01 Eli Zaretskii <eliz@gnu.org>
5356
5357 * xdisp.c (forward_to_next_line_start): Accept additional argument
5358 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5359 on the newline.
5360 (reseat_at_next_visible_line_start): Use the bidi iterator state
5361 returned by forward_to_next_line_start to restore the state of
5362 it->bidi_it after backing up to previous newline. (Bug#9212)
5363
31011111
AS
53642011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5365
5366 * regex.c (re_comp): Protoize.
5367 (re_exec): Fix return type.
5368 (regexec): Fix type of `ret'. (Bug#9203)
5369
476371c4
PE
53702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5371
e5d76069
PE
5372 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5373 This is needed if max-image-size is a floating-point number.
5374
9a79b20c
AS
53752011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5376
5377 * print.c (print_object): Print empty symbol as ##.
5378
5379 * lread.c (read1): Read ## as empty symbol.
5380
d8c2fa78
AA
53812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5382
5383 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5384 setting frame foreground color (Bug#9175).
5385 (x_set_background_color): Likewise.
5386
ffe57a7a
AA
5387 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5388 contents (Bug#9176).
5389 (EmacsTooltip -init): Remove bezels and add shadows to
5390 tooltip windows.
5391
bf3492a5
AA
5392 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5393 or scroll bar (Bug#8470).
5394
d55e9c53
AA
5395 * nsfont.m (nsfont_open): Remove assignment to voffset and
5396 unnecessary vars hshink, expand, hd, full_height, min_height.
5397 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5398
5399 * nsterm.h (nsfont_info): Remove voffset field.
5400
d8c2fa78 54012011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5402
5403 Implement strike-through and overline on NextStep (Bug#8863).
5404
5405 * nsfont.m (nsfont_open): Use underline position provided by font,
5406 instead of hard-coded value of 2.
5407 (nsfont_draw): Call ns_draw_text_decoration instead.
5408
5409 * nsterm.h: Add declaration for ns_draw_text_decoration.
5410
5411 * nsterm.m (ns_draw_text_decoration): New function for drawing
5412 underline, overline, and strike-through.
5413 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5414 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5415 accommodate underlining, etc.
4843aac3 5416
4cc60b9b
EZ
54172011-07-28 Eli Zaretskii <eliz@gnu.org>
5418
bc7ece87
EZ
5419 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5420 default.
4cc60b9b 5421
476371c4
PE
54222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5423
66606eea
PE
5424 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5425 Without this fix, if a signal arrives just after memory fills up,
5426 'malloc' might be invoked reentrantly.
5427
476371c4
PE
5428 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5429 In other words, assume that every image size is allowed, on non-X
5430 hosts. This assumption is probably wrong, but it lets Emacs compile.
5431
f3fcc40d
AS
54322011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5433
5434 * regex.c (re_iswctype): Convert return values to boolean.
5435
350c992f
EZ
54362011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5437
5438 * xdisp.c (compute_display_string_pos): Don't use cached display
5439 string position if the buffer had its restriction changed.
5440 (Bug#9184)
5441
5266b4bb
PE
54422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5445
2573a837 54462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5447
41f55ccd 5448 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5449
39e378da
PE
5450 * bidi.c: Integer size and overflow fixes.
5451 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5452 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5453 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5454 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5455 (bidi_find_other_level_edge):
5456 Use ptrdiff_t instead of EMACS_INT where either will do.
5457 This works better on 32-bit hosts configured --with-wide-int.
5458 (bidi_cache_ensure_space): Check for size-calculation overflow.
5459 Use % rather than repeated addition, for better worst-case speed.
5460 Don't set bidi_cache_size until after xrealloc returns, because it
5461 might not return.
5462 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5463 (bidi_cache_ensure_space): Also check that the bidi cache size
5464 does not exceed that of the largest Lisp string or buffer. See Eli
5465 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5466
5e927815
PE
5467 * alloc.c (__malloc_size_t): Remove.
5468 All uses replaced by size_t. See Andreas Schwab's note
5469 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5470
ca4aa935
PE
5471 * image.c: Improve checking for integer overflow.
5472 (check_image_size): Assume that f is nonnull, since
5473 it is always nonnull in practice. This is one less thing to
5474 worry about when checking for integer overflow later.
5475 (x_check_image_size): New function, which checks for integer
5476 overflow issues inside X.
5477 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5478 This removes the need for a memory_full check.
5479 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5480 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5481 (xbm_read_bitmap_data): Change locals back to 'int', since
5482 their values must fit in 'int'.
5483 (xpm_load_image, png_load, tiff_load):
5484 Invoke x_create_x_image_and_pixmap earlier,
5485 to avoid much needless work if the image is too large.
5486 (tiff_load): Treat overly large images as if
5487 x_create_x_image_and_pixmap failed, not as malloc failures.
5488 (gs_load): Use x_check_image_size.
5489
5f8f9cc2
PE
5490 * gtkutil.c: Omit integer casts.
5491 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5492 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5493
5adf60bc
PE
5494 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5495
c8907a93
PE
5496 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5497 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5498 would wrongly return t on a 64-bit host.
5499
e3c25c68
PE
5500 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5501 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5502 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5503 and therefore cause GCC to emit a bogus diagnostic in some cases.
5504
3f791afe
PE
5505 * image.c: Integer signedness and overflow and related fixes.
5506 This is not an exhaustive set of fixes, but it's time to
5507 record what I've got.
5508 (lookup_pixel_color, check_image_size): Remove redundant decls.
5509 (check_image_size): Don't assume that arbitrary EMACS_INT values
5510 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5511 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5512 (tiff_load, imagemagick_load_image):
5513 Check for overflow in size calculations.
5514 (x_create_x_image_and_pixmap): Remove unnecessary test for
5515 xmalloc returning NULL; that can't happen.
5516 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5517 (xpm_color_bucket): Use better integer hashing function.
5518 (xpm_cache_color): Don't possibly over-allocate memory.
5519 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5520 (gif_memory_source):
5521 Use ptrdiff_t, not int or size_t, to record sizes.
5522 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5523 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5524 either works, as we prefer signed integers.
5525 (tiff_read_from_memory, tiff_write_from_memory):
5526 Return tsize_t, not size_t, since that's what the TIFF API wants.
5527 (tiff_read_from_memory): Don't fail simply because the read would
5528 go past EOF; instead, return a short read.
5529 (tiff_load): Omit no-longer-needed casts.
5530 (Fimagemagick_types): Don't assume size fits into 'int'.
5531
3cc5a532
PE
5532 Improve hashing quality when configured --with-wide-int.
5533 * fns.c (hash_string): New function, taken from sxhash_string.
5534 Do not discard information about ASCII character case; this
5535 discarding is no longer needed.
5536 (sxhash-string): Use it. Change sig to match it. Caller changed.
5537 * lisp.h: Declare it.
5538 * lread.c (hash_string): Remove, since we now use fns.c's version.
5539 The fns.c version returns a wider integer if --with-wide-int is
5540 specified, so this should help the quality of the hashing a bit.
5541
b312a492
PE
5542 * emacs.c: Integer overflow minor fix.
5543 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5544 Define only if GNU_LINUX.
5545 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5546
dfd153ae
PE
5547 * dispnew.c: Integer signedness and overflow fixes.
5548 Remove unnecessary forward decls, that were a maintenance hassle.
5549 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5550 All uses changed.
5551 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5552 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5553 (prepare_desired_row, line_draw_cost):
5554 Use int, not unsigned, where either works.
5555 (save_current_matrix, restore_current_matrix):
5556 Use ptrdiff_t, not size_t, where either works.
5557 (init_display): Check for overflow more accurately, and without
5558 relying on undefined behavior.
5559
a81d11a3
PE
5560 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5561 Remove, replacing with the new symbols in lisp.h. All uses changed.
5562 * fileio.c (make_temp_name):
5563 * filelock.c (lock_file_1, lock_file):
5564 * xdisp.c (message_dolog):
5565 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5566 Use pMd etc. instead.
5567 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5568 replacing the pWIDE etc. symbols removed from editfns.c.
5569
3300e6fd
PE
5570 * keyboard.h (num_input_events): Now uintmax_t.
5571 This is (very slightly) less likely to mess up due to wraparound.
5572 All uses changed.
5573
fd05c7e9
PE
5574 * buffer.c: Integer signedness fixes.
5575 (alloc_buffer_text, enlarge_buffer_text):
5576 Use ptrdiff_t rather than size_t when either will do, as we prefer
5577 signed integers.
5578
903fe15d
PE
5579 * alloc.c: Integer signedness and overflow fixes.
5580 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5581 (__malloc_size_t): Default to size_t, not to int.
5582 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5583 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5584 Prefer ptrdiff_t to size_t when either would do, as we prefer
5585 signed integers.
5586 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5587 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5588 Now const. Initialize with values that are in range even if char
5589 is signed.
5590 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5591 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5592 These functions do the right thing with sizes > 2**32.
5593 (check_depth): Now ptrdiff_t, not int.
5594 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5595 Adjust to new way of storing sizes. Check for size overflow bugs
5596 in rest of code.
5597 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5598 slightly wrong anyway, as it missed one instance of
5599 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5600 (refill_memory_reserve): Omit needless cast to size_t.
5601 (mark_object_loop_halt): Mark as externally visible.
5602
ac82cc6a
PE
5603 * xselect.c: Integer signedness and overflow fixes.
5604 (Fx_register_dnd_atom, x_handle_dnd_message):
5605 Use ptrdiff_t, not size_t, since we prefer signed.
5606 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5607 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5608 x_dnd_atoms_size and x_dnd_atoms_length.
5609
c2d1e36d
PE
5610 * doprnt.c: Prefer signed to unsigned when either works.
5611 * eval.c (verror):
5612 * doprnt.c (doprnt):
5613 * lisp.h (doprnt):
5614 * xdisp.c (vmessage):
5615 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5616 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5617 prefer signed arithmetic to avoid comparison confusion.
5618 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5619 but is a bit tricky.
5620
0e926e56
PE
5621 Assume freestanding C89 headers, string.h, stdlib.h.
5622 * data.c, doprnt.c, floatfns.c, print.c:
5623 Include float.h unconditionally.
5624 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5625 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5626 * regex.c: Likewise for stddef.h, string.h.
5627 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5628 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5629 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5630 (STDC_HEADERS): Remove obsolete defines.
5631 * sysdep.c: Include limits.h unconditionally.
5632
9cfdb3ec
PE
5633 Assume support for memcmp, memcpy, memmove, memset.
5634 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5635 * regex.c (memcmp, memcpy):
5636 Remove; we assume C89 now.
5637
5638 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5639 (__malloc_safe_bcopy): Remove; no longer needed.
5640
cf950e6b 5641 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5642 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5643 well either way, and we prefer signed to unsigned.
5644
dbf38e02
LMI
56452011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5646
5647 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5648 closes the connection while we're reading (bug#9182).
5649
d6f0886c 56502011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5651
d6f0886c
JD
5652 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5653 are specified (Bug#9168).
24e0f6b1 5654
2eb1f9e6
PE
56552011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5656
5657 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5658 Found by GCC static checking and --with-wide-int on a 32-bit host.
5659
22381272 56602011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5661
5662 * xdisp.c (compute_display_string_pos): Fix logic of caching
5663 previous display string position. Initialize cached_prev_pos to
5664 -1. Fixes slow-down at the beginning of a buffer.
5665
f25e39b4
EZ
56662011-07-24 Eli Zaretskii <eliz@gnu.org>
5667
5668 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5669 for attrs[LFACE_FONTSET_INDEX].
5670
04c4b52e
PE
56712011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5672
5673 * xml.c (parse_region): Remove unused local
5674 that was recently introduced.
5675
c1734fbd
EZ
56762011-07-23 Eli Zaretskii <eliz@gnu.org>
5677
be18c5a5
EZ
5678 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5679 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5680
c1734fbd
EZ
5681 * xdisp.c (move_it_in_display_line_to): Record the best matching
5682 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5683 exit if none of the characters scanned was an exact match.
5684 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5685 when exact match is impossible due to invisible text, and the
5686 lines are truncated.
5687
a258d627
JD
56882011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5689
5690 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5691 for OSX >= 10.7.
5692
b6d5a689
EZ
56932011-07-22 Eli Zaretskii <eliz@gnu.org>
5694
0f74f785
EZ
5695 Fix a significant slow-down of cursor motion with C-n, C-p,
5696 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5697 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5698 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5699 (next_element_from_buffer): Call compute_stop_pos_backwards to
5700 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5701 base_level_stop.
5702 (reseat): Don't look for prev_stop, as that could mean a very long
5703 run.
5704 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5705 <cached_disp_overlay_modiff>: Cache for last found display string
5706 position.
551918c1 5707 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5708 about the same buffer in the same area of character positions, and
5709 the buffer wasn't changed since the time the display string
5710 position was cached.
551918c1 5711
b2d0c91a
EZ
57122011-07-22 Eli Zaretskii <eliz@gnu.org>
5713
5714 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5715 is an integer, which is important for empty lines. (Bug#9149)
5716
043604ee
CY
57172011-07-22 Chong Yidong <cyd@stupidchicken.com>
5718
5719 * frame.c (Fmodify_frame_parameters): In tty case, update the
5720 default face if necessary (Bug#4238).
5721
da4adb04
CY
57222011-07-21 Chong Yidong <cyd@stupidchicken.com>
5723
5724 * editfns.c (Fstring_to_char): No need to explain what a character
5725 is in the docstring (Bug#6576).
5726
9abd0532
LMI
57272011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5728
5729 * xml.c (parse_region): Make sure we always return a tree.
5730
36881d16
HK
57312011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5732
5733 * xml.c (parse_region): If a document contains only comments,
5734 return that, too.
5735
1e98674d
LMI
57362011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5737
5738 * xml.c (make_dom): Return comments, too.
5739
590bd467
PE
57402011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5741
5742 Port to OpenBSD.
5743 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5744 and the surrounding thread.
5745 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5746 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5747 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5748 timer goes off.
5749 * s/openbsd.h (BROKEN_SIGIO): Define.
5750 * unexelf.c (unexec) [__OpenBSD__]:
5751 Don't update the .mdebug section of the Alpha COFF symbol table.
5752
f41628b2
LMI
57532011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5754
5755 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5756 (bug#8460).
5757
b59b67c5
PE
57582011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5759
15e3a074
PE
5760 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5761 This fixes some race conditions on the permissions of any newly
5762 created file.
5763
41bed37d
PE
5764 * alloc.c (valid_pointer_p): Use pipe, not open.
5765 This fixes some permissions issues when debugging.
5766
b59b67c5
PE
5767 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5768 If fchown fails to set both uid and gid, try to set just gid,
5769 as that is sometimes allowed. Adjust the file's mode to eliminate
5770 setuid or setgid bits that are inappropriate if fchown fails.
5771
925a6be7
SM
57722011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5775 to compare Lisp_Objects.
5776 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5777 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5778 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5779
52968808
AS
57802011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5781
0a6a104b
AS
5782 * lread.c (read_integer): Unread even EOF character.
5783 (read1): Likewise. Properly record start position of symbol.
5784
52968808
AS
5785 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5786 symbol character follows.
5787
9e381cdd
PE
57882011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5789
5790 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5791 This works around a problem with the previous change to Fcopy_file.
5792 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5793 and without this change, GCC might complain about discarding
5794 fchown's return value.
5795
b5641435
JB
57962011-07-16 Juanma Barranquero <lekktu@gmail.com>
5797
5798 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5799
a8031457
PE
58002011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5801
5802 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5803
dd889327
LMI
58042011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5805
750c33f7
LMI
5806 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5807 it's used from the C level.
5808
dd889327
LMI
5809 * process.c: Use the same condition for POLL_FOR_INPUT in both
5810 keyboard.c and process.c (bug#1858).
5811
87e86684
LM
58122011-07-09 Lawrence Mitchell <wence@gmx.li>
5813
5814 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5815 (Fgnutls_boot): Use it.
5816
64348f40
AS
58172011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5818
5819 * doc.c (Fsubstitute_command_keys): Revert last change.
5820
1d698799
LMI
58212011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5822
f863868c
LMI
5823 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5824 quotes the next character, and doesn't affect other longer
5825 sequences (bug#8935).
5826
1d698799
LMI
5827 * lread.c (syms_of_lread): Clarify that is isn't only
5828 `eval-buffer' and `eval-defun' that's affected by
5829 `lexical-binding' (bug#8460).
5830
aa4b6df6
EZ
58312011-07-15 Eli Zaretskii <eliz@gnu.org>
5832
5833 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5834 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5835
5d856da6
PE
58362011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5837
ad6042bb
PE
5838 Fix minor problems found by static checking.
5839 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5840 (elsz): Now a signed constant, not a size_t var. We prefer signed
5841 types to unsigned, to avoid integer comparison confusion. Without
5842 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5843 "cannot optimize loop, the loop counter may overflow", a symptom
5844 of the confusion.
f00bbb22 5845 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5846 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5847
6468f31c
LMI
58482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5849
49080b10
LMI
5850 * search.c (Fre_search_backward): Mention `case-fold-search' in
5851 all the re_search_* functions (bug#8138).
5852
6468f31c
LMI
5853 * keyboard.c (Fopen_dribble_file): Document when the file is
5854 closed (bug#8056).
5855
c965adc5
EZ
58562011-07-14 Eli Zaretskii <eliz@gnu.org>
5857
df9733bf
EZ
5858 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5859 bidi_cache_idx.
5860
0bb23927
EZ
5861 Support bidi reordering of display and overlay strings.
5862 * xdisp.c (compute_display_string_pos)
5863 (compute_display_string_end): Accept additional argument STRING.
5864 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5865 (reseat_to_string): Initialize bidi_it->string.s and
5866 bidi_it->string.schars.
5867 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5868 NULL (avoids a crash in bidi_paragraph_init).
5869 Initialize itb.string.lstring.
0bb23927
EZ
5870 (init_iterator): Call bidi_init_it only of a valid
5871 buffer position was specified. Initialize paragraph_embedding to
5872 L2R.
5873 (reseat_to_string): Initialize the bidi iterator.
5874 (display_string): If we need to ignore text properties of
5875 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5876 original value of -1 will not work with bidi.)
5877 (compute_display_string_pos): First arg is now struct
5878 `text_pos *'; all callers changed. Support display properties on
5879 Lisp strings.
5880 (compute_display_string_end): Support display properties on Lisp
5881 strings.
5882 (init_iterator, reseat_1, reseat_to_string): Initialize the
5883 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5884 when iterating on a string not from display properties).
640c8776
SM
5885 (compute_display_string_pos, compute_display_string_end):
5886 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5887 arrow keys.
5888 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5889 base_level_stop; instead, set base_level_stop to BEGV.
5890 Fixes crashes in vertical-motion.
0bb23927
EZ
5891 (next_element_from_buffer): Improve commentary for when
5892 the iterator is before prev_stop.
5893 (init_iterator): Initialize bidi_p from the default value of
5894 bidi-display-reordering, not from buffer-local value. Use the
5895 buffer-local value only if initializing for buffer iteration.
5896 (handle_invisible_prop): Support invisible properties on strings
5897 that are being bidi-reordered.
5898 (set_iterator_to_next): Support bidi reordering of C strings and
5899 Lisp strings.
5900 (next_element_from_string): Support bidi reordering of Lisp
5901 strings.
5902 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5903 (display_string): Support display of R2L glyph rows.
5904 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5905 (init_iterator): Don't initialize it->bidi_p for strings
5906 here.
5907 (reseat_to_string): Initialize it->bidi_p for strings here.
5908 (next_element_from_string, next_element_from_c_string)
5909 (next_element_from_buffer): Add xassert's for correspondence
5910 between IT's object being iterated and it->bidi_it.string
5911 structure.
5912 (face_before_or_after_it_pos): Support bidi iteration.
5913 (next_element_from_c_string): Handle the case of the first string
5914 character that is not the first one in the visual order.
5915 (get_visually_first_element): New function, refactored from common
5916 parts of next_element_from_buffer, next_element_from_string, and
5917 next_element_from_c_string.
5918 (tool_bar_lines_needed, redisplay_tool_bar)
5919 (display_menu_bar): Force left-to-right direction. Add a FIXME
5920 comment for making that be controlled by a user option.
5921 (push_it, pop_it): Save and restore the state of the
5922 bidi iterator. Save and restore the bidi_p flag.
5923 (pop_it): Iterate out of display property for string iteration as
5924 well.
5925 (iterate_out_of_display_property): Support iteration over strings.
5926 (handle_single_display_spec): Set up it->bidi_it for iteration
5927 over a display string, and call bidi_init_it.
5928 (handle_single_display_spec, next_overlay_string)
5929 (get_overlay_strings_1, push_display_prop): Set up the bidi
5930 iterator for displaying display or overlay strings.
5931 (forward_to_next_line_start): Don't use the shortcut if
5932 bidi-iterating.
5933 (back_to_previous_visible_line_start): If handle_display_prop
5934 pushed the iterator stack, restore the internal state of the bidi
5935 iterator by calling bidi_pop_it same number of times.
5936 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5937 and we are bidi-iterating, don't decrement the iterator position;
5938 instead, set the first_elt flag in the bidi iterator, to produce
5939 the same effect.
5940 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5941 (push_display_prop): xassert that we are iterating a buffer.
5942 (push_it, pop_it): Save and restore paragraph_embedding member.
5943 (handle_single_display_spec, next_overlay_string)
5944 (get_overlay_strings_1, reseat_1, reseat_to_string)
5945 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5946 correctly. Don't assume unibyte strings are not bidi-reordered.
5947 (compute_display_string_pos)
5948 (compute_display_string_end): Fix handling the case of C string.
5949 (push_it, pop_it): Save and restore from_disp_prop_p.
5950 (handle_single_display_spec, push_display_prop): Set the
5951 from_disp_prop_p flag.
5952 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5953 (pop_it): Call iterate_out_of_display_property only if we are
5954 popping after iteration over a string that came from a display
5955 property. Fix a typo in popping stretch info. Add an assertion
5956 for verifying that the iterator position is in sync with the bidi
5957 iterator.
5958 (handle_single_display_spec, get_overlay_strings_1)
5959 (push_display_prop): Fix initialization of paragraph direction for
5960 string when that of the parent object is not yet determined.
5961 (reseat_1): Call bidi_init_it to resync the bidi
5962 iterator with IT's position. (Bug#7616)
5963 (find_row_edges): If ROW->start.pos gives position
5964 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5965 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5966 Reset the from_disp_prop_p flag.
5967 (SAVE_IT, RESTORE_IT): New macros.
5968 (pos_visible_p, face_before_or_after_it_pos)
5969 (back_to_previous_visible_line_start)
5970 (move_it_in_display_line_to, move_it_in_display_line)
5971 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5972 (try_scrolling, redisplay_window, display_line): Use them when
5973 saving a temporary copy of the iterator and restoring it back.
5974 (back_to_previous_visible_line_start, reseat_1)
5975 (init_iterator): Empty the bidi cache "stack".
5976 (move_it_in_display_line_to): If iterator ended up at
5977 EOL, but we never saw any buffer positions smaller than
5978 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5979 motion in bidi-reordered lines.
5980 (move_it_in_display_line_to): Record prev_method and prev_pos
5981 immediately before the call to set_iterator_to_next. Fixes cursor
5982 motion in bidi-reordered lines with stretch glyphs and strings
5983 displayed in margins. (Bug#8133) (Bug#8867)
5984 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5985 TO_CHARPOS.
640c8776
SM
5986 (pos_visible_p): Support positions in bidi-reordered lines.
5987 Save and restore bidi cache.
0bb23927
EZ
5988
5989 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5990 (bidi_paragraph_info): Delete unused struct.
5991 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5992 (bidi_cache_start): New variable.
5993 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5994 to zero.
5995 (bidi_cache_fetch_state, bidi_cache_search)
5996 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5997 (bidi_cache_find, bidi_peek_at_next_level)
5998 (bidi_level_of_next_char, bidi_find_other_level_edge)
5999 (bidi_move_to_visually_next): Compare cache index with
6000 bidi_cache_start rather than with zero.
6001 (bidi_fetch_char): Accept new argument STRING; all callers
6002 changed. Support iteration over a string. Support strings with
6003 display properties. Support unibyte strings. Fix the type of
6004 `len' according to what STRING_CHAR_AND_LENGTH expects.
6005 (bidi_paragraph_init, bidi_resolve_explicit_1)
6006 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6007 (bidi_level_of_next_char, bidi_move_to_visually_next):
6008 Support iteration over a string.
0bb23927
EZ
6009 (bidi_set_sor_type, bidi_resolve_explicit_1)
6010 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6011 can now be zero (for strings); special values 0 and -1 were
6012 changed to -1 and -2, respectively.
6013 (bidi_char_at_pos): New function.
6014 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6015 Call it instead of FETCH_MULTIBYTE_CHAR.
6016 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6017 initialized to valid values.
6018 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6019 values.
6020 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6021 the test for valid cached positions. Fix the logic for looking up
6022 the sentinel state in the cache. GCPRO the Lisp string we are
6023 iterating.
6024 (bidi_push_it, bidi_pop_it): New functions.
6025 (bidi_initialize): Initialize the bidi cache start stack pointer.
6026 (bidi_cache_ensure_space): New function, refactored from part of
6027 bidi_cache_iterator_state. Don't assume the required size is just
6028 one BIDI_CACHE_CHUNK away.
6029 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6030 (bidi_count_bytes, bidi_char_at_pos): New functions.
6031 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6032 always valid if bidi_cache_idx is valid.
6033 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6034 is valid if it's going to be used.
6035 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6036 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6037 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6038 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6039 (bidi_find_other_level_edge, bidi_cache_start_stack):
6040 All variables related to cache indices are now EMACS_INT.
c965adc5 6041
0bb23927
EZ
6042 * dispextern.h (struct bidi_string_data): New structure.
6043 (struct bidi_it): New member `string'. Make flag members be 1-bit
6044 fields, and put them last in the struct.
640c8776
SM
6045 (compute_display_string_pos, compute_display_string_end):
6046 Update prototypes.
0bb23927
EZ
6047 (bidi_push_it, bidi_pop_it): Add prototypes.
6048 (struct iterator_stack_entry): New members bidi_p,
6049 paragraph_embedding, and from_disp_prop_p.
6050 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6051 (bidi_shelve_cache, bidi_unshelve_cache):
6052 Declare prototypes.
0bb23927
EZ
6053
6054 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6055 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6056 and vector-like objects.
6057
6058 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6059 cache around display iteration.
6060
6061 * window.c (Fwindow_end, window_scroll_pixel_based)
6062 (displayed_window_lines, Frecenter): Save and restore the bidi
6063 cache around display iteration.
6064
3bbd2265
LMI
60652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6066
6067 * editfns.c (Fdelete_region): Clarify the use of the named
6068 parameters (bug#6788).
6069
adc47434
MR
60702011-07-14 Martin Rudalics <rudalics@gmx.at>
6071
6072 * indent.c (Fvertical_motion): Set and restore w->pointm when
6073 saving and restoring the window's buffer (Bug#9006).
6074
837c31f8
LMI
60752011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6076
6077 * editfns.c (Fstring_to_char): Clarify just what is returned
6078 (bug#6576). Text by Eli Zaretskii.
6079
ac389d0c
JB
60802011-07-13 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6083
0be0ce47
EZ
60842011-07-13 Eli Zaretskii <eliz@gnu.org>
6085
6086 * buffer.c (mmap_find): Fix a typo.
6087
cd18e7e3
JB
60882011-07-13 Johan Bockgård <bojohan@gnu.org>
6089
6090 Fix execution of x selection hooks.
6091 * xselect.c (Qx_lost_selection_functions)
6092 (Qx_sent_selection_functions): New vars.
6093 (syms_of_xselect): DEFSYM them.
6094 (x_handle_selection_request): Pass Qx_sent_selection_functions
6095 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6096 (x_handle_selection_clear,x_clear_frame_selections):
6097 Pass Qx_lost_selection_functions rather than
6098 Vx_lost_selection_functions to Frun_hook_with_args.
6099
47ea7f44
PE
61002011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6101
ac389d0c 6102 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6103 The old code sometimes used this field without initializing it.
6104
47ea7f44
PE
6105 * alloc.c (gc_sweep): Don't read past end of array.
6106 In theory, the old code could also have corrupted Emacs internals,
6107 though it'd be very unlikely.
6108
bc985c87
AS
61092011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6110
6111 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6112 argument. (Bug#4026)
bc985c87 6113
0cf34688
LMI
61142011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6115
b3dadd76
LMI
6116 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6117 key" (bug#4257).
6118
0cf34688
LMI
6119 * window.c (Fset_window_start): Doc fix (bug#4199).
6120 (Fset_window_hscroll): Ditto.
6121
270768cd
PE
61222011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6123
077e3dda 6124 Fix minor new problems caught by GCC 4.6.1.
270768cd 6125 * term.c (init_tty): Remove unused local.
490011a6 6126 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6127 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6128 not used otherwise.
270768cd 6129
b1f58454
CY
61302011-07-12 Chong Yidong <cyd@stupidchicken.com>
6131
6132 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6133
22b9578d
LMI
61342011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6135
6e70ab07
LMI
6136 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6137 are the mini-buffer and the echo area (bug#3320).
6138
22b9578d
LMI
6139 * term.c (init_tty): Remove support for supdup, c10 and perq
6140 terminals, which are no longer supported (bug#1482).
6141
8974cc9f
JB
61422011-07-10 Johan Bockgård <bojohan@gnu.org>
6143
6144 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6145
a560d974
JD
61462011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6147
6148 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6149 for non-popups (Bug#3642).
6150
1dae0f0a
AS
61512011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6152
268c2c36 6153 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6154 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6155 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6156 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6157 * data.c (fmod): Likewise.
6158 * dispnew.c (swap_glyphs_in_rows): Likewise.
6159 * emacs.c (memory_warning_signal): Likewise.
6160 * floatfns.c (float_error): Likewise.
6161 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6162 (otf_open, font_otf_capability, generate_otf_features)
6163 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6164 Likewise.
6165 * image.c (pbm_read_file): Likewise.
6166 * indent.c (string_display_width): Likewise.
6167 * intervals.c (check_for_interval, search_for_interval)
6168 (inc_interval_count, count_intervals, root_interval)
6169 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6170 * lread.c (defalias): Likewise.
268c2c36 6171 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6172 * regex.c (set_image_of_range_1, set_image_of_range)
6173 (regex_grow_registers): Likewise.
6174 * sysdep.c (strerror): Likewise.
6175 * termcap.c (valid_filename_p, tprint, main): Likewise.
6176 * tparam.c (main): Likewise.
6177 * unexhp9k800.c (run_time_remap, save_data_space)
6178 (update_file_ptrs, read_header, write_header, calculate_checksum)
6179 (copy_file, copy_rest, display_header): Likewise.
6180 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6181 Likewise.
6182 * xdisp.c (check_it): Likewise.
6183 * xfaces.c (register_color, unregister_color, unregister_colors):
6184 Likewise.
6185 * xfns.c (print_fontset_result): Likewise.
6186 * xrdb.c (member, fatal, main): Likewise.
6187
99033785
PE
61882011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6189
6190 Fix minor problems found by static checking (Bug#9031).
6191 * chartab.c (char_table_set_range, map_sub_char_table):
6192 Remove unused locals.
6193 (uniprop_table): Now static.
6194 * composite.c (_work_char): Remove unused static var.
6195
9cb2ac56
JB
61962011-07-09 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6199
f25661f0
JD
62002011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6201
6202 * gtkutil.c (qttip_cb): Remove code without function.
6203
8278c4fe
EZ
62042011-07-09 Eli Zaretskii <eliz@gnu.org>
6205
6206 * w32.c (pthread_sigmask): New stub.
6207
1692ae2d 62082011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6209
8a6ebd58 6210 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6211 sigprocmask is portable only for single-threaded applications, and
6212 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6213 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6214 (LIBES): Use it.
6215 * callproc.c (Fcall_process):
6216 * process.c (create_process):
6217 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6218 Use pthread_sigmask, not sigprocmask.
123403e4 6219
1b854618
JD
62202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6221
6222 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6223 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6224 wrong (Bug#8591).
6225
3fe4b549
JD
62262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6227
0ce7e563
JD
6228 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6229 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6230 (xg_hide_tooltip): Fix comment.
6231
3fe4b549
JD
6232 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6233 in registerServicesMenuSendTypes.
6234 (validRequestorForSendType): Don't check ns_return_types.
6235
6236 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6237 ns_return_type.
6238
5df75e47
JR
62392011-07-08 Jason Rumney <jasonr@gnu.org>
6240
22610910
JR
6241 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6242 SH_SHOW for hidden windows (Bug#5482).
6243
5df75e47
JR
6244 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6245 frame struct members of non-existent frames (Bug#6284).
6246
699c10bd
JD
62472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6248
4393663b
JD
6249 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6250 variable firstTime not needed on OSX >= 10.6.
6251 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6252 >= 10.5. Use setKnobProportion, setDoubleValue.
6253
6254 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6255 (MAC_OS_X_VERSION_10_5): Define if not defined.
6256 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6257 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6258 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6259
6260 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6261 cString and lossyCString on OSX >= 10.4
6262
58179cce 6263 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6264 sizeToFit on OSX >= 10.2.
6265
6266 * nsimage.m (allocInitFromFile): Don't use deprecated method
6267 bestRepresentationForDevice on OSX >= 10.6.
6268
6269 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6270 to avoid warning.
6271
6272 * emacs.c: Declare unexec_init_emacs_zone.
6273
a63e0781
JD
6274 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6275
699c10bd
JD
6276 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6277
6278 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6279 on svcsMenu (Bug#8842).
6280
6281 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6282 ns_return_types.
6283 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6284
6285 * nsterm.m (QUTF8_STRING): Declare.
6286 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6287 (validRequestorForSendType): Return type is (id).
6288 Change indexOfObjectIdenticalTo to indexOfObject.
6289 Check if we have local selection before returning self (Bug#8842).
6290 (writeSelectionToPasteboard): Put local selection into paste board
6291 if we have a local selection (Bug#8842).
6292 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6293
6294 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6295 (ns_get_local_selection): Declare.
6296
54e10184
LMI
62972011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6298
9888ff71
LMI
6299 * keymap.c (describe_map_tree): Don't insert a double newline at
6300 the end of the buffer (bug#1169) and return whether we inserted
6301 something.
6302
54e10184
LMI
6303 * callint.c (Fcall_interactively): Change "reading args" to
6304 "providing args" to try to clarify what it does (bug#1010).
6305
15fa4783
KH
63062011-07-07 Kenichi Handa <handa@m17n.org>
6307
6308 * composite.c (composition_compute_stop_pos): Ignore a static
6309 composition starting before CHARPOS (Bug#8915).
6310
6311 * xdisp.c (handle_composition_prop): Likewise.
6312
a8815b00
EZ
63132011-07-07 Eli Zaretskii <eliz@gnu.org>
6314
6315 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6316 (Bug#9015)
6317
ef7b981d 63182011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6319
6320 * character.h (unicode_category_t): New enum type.
6321
6322 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6323 (Qchar_code_property_table): New variable.
6324 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6325 (UNIPROP_COMPRESSED_FORM_P): New macros.
6326 (char_table_ascii): Uncompress the compressed values.
6327 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6328 Uncompress the compressed values.
ac389d0c 6329 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6330 (char_table_ref_and_range): Uncompress the compressed values.
6331 (sub_char_table_set): New arg is_uniprop. Callers changed.
6332 Uncompress the compressed values.
6333 (sub_char_table_set_range): Args changed. Callers changed.
6334 (char_table_set_range): Adjuted for the above change.
6335 (map_sub_char_table): Delete args default_val and parent. Add arg
6336 top. Give decoded values to a Lisp function.
640c8776 6337 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6338 values to a Lisp function. Gcpro more variables.
6339 (uniprop_table_uncompress)
6340 (uniprop_decode_value_run_length): New functions.
6341 (uniprop_decoder, uniprop_decoder_count): New variables.
6342 (uniprop_get_decoder, uniprop_encode_value_character)
6343 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6344 New functions.
6345 (uniprop_encoder, uniprop_encoder_count): New variables.
6346 (uniprop_get_encoder, uniprop_table)
6347 (Funicode_property_table_internal, Fget_unicode_property_internal)
6348 (Fput_unicode_property_internal): New functions.
6349 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6350 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6351 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6352 char-code-property-alist.
6353
640c8776 6354 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6355 Vunicode_category_table.
6356
640c8776 6357 * font.c (font_range): Adjust for the change of
c805dec0
KH
6358 Vunicode_category_table.
6359
76b397fb
DN
63602011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6361
6362 * m/iris4d.h: Remove file, move contents ...
6363 * s/irix6-5.h: ... here.
6364
22b4128e
PE
63652011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6366
6367 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6368 * alloc.c (mark_buffer):
6369 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6370 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6371 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6372 This isn't true in general, and it's particularly not true
6373 if Emacs is configured with --with-wide-int.
6374 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6375 New macros, used in the buffer.c change.
6376
869795d6
JD
63772011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6378
6379 * xsettings.c: Use both GConf and GSettings if both are available.
6380 (store_config_changed_event): Add comment.
6381 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6382 (store_tool_bar_style_changed): New functions.
5e617bc2 6383 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6384 (struct xsettings): Move font inside HAVE_XFT.
6385 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6386 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6387 Move inside HAVE_XFT.
640c8776 6388 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6389 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6390 also.
6391 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6392 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6393 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6394 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6395 (parse_settings): Move check for font inside HAVE_XFT.
6396 (read_settings, apply_xft_settings): Add comment.
6397 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6398 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6399 call store_font_name_changed.
6400 (xft_settings_event): Add comment.
6401 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6402 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6403 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6404 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6405 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6406 (xsettings_get_system_font, xsettings_get_system_normal_font):
6407 Add comment.
869795d6 6408
d8ed26bd
PE
64092011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6410
6411 Random fixes. E.g., (random) never returned negative values.
6412 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6413 subseconds part to the entropy, as that's a bit more random.
6414 Prefer signed to unsigned, since the signedness doesn't matter and
6415 in general we prefer signed. When given a limit, use a
6416 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6417 latter isn't right if USE_2_TAGS_FOR_INTS.
6418 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6419 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6420
cabf1cac
SM
64212011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6422
6423 * textprop.c (text_property_stickiness):
6424 Obey Vtext_property_default_nonsticky.
6425 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6426 * w32fns.c (syms_of_w32fns):
6427 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6428
6e9b2be9
PE
64292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6430
6431 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6432 This is more efficient than Ffile_directory_p and avoids a minor race.
6433
90186c68
LMI
64342011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6435
7c301272
LMI
6436 * buffer.c (Foverlay_put): Say what the return value is
6437 (bug#7835).
6438
c4f2d8d4
LMI
6439 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6440 is a directory before asking whether to use the file name
6441 (bug#7564).
ad637907
LMI
6442 (barf_or_query_if_file_exists): Make the "File is a directory"
6443 error be more correct.
c4f2d8d4 6444
90186c68
LMI
6445 * fns.c (Frequire): Remove the mention of the .gz files, since
6446 that's installation-specific, but keep the mention of
6447 `get-load-suffixes'.
6448
da64016e
PE
64492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6452 Report string overflow if the output is too long.
6453
7d47b580
JB
64542011-07-04 Juanma Barranquero <lekktu@gmail.com>
6455
a555cb87
JB
6456 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6457 (syms_of_gnutls): Remove duplicate DEFSYM for
6458 Qgnutls_bootprop_verify_hostname_error, an error for
6459 Qgnutls_bootprop_verify_error (which is no longer used).
6460
7d47b580
JB
6461 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6462 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6463 Also (re)move comments that are misplaced or no longer relevant.
6464
1e49bfab
LMI
64652011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6466
6467 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6468
1485f4c0
CY
64692011-07-03 Chong Yidong <cyd@stupidchicken.com>
6470
6471 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6472 and background color parameters if they have been changed.
6473
a9ab721e
LMI
64742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6475
6476 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6477
cf7cff57
PE
64782011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6479
2e13213d
PE
6480 * xsettings.c (SYSTEM_FONT): Define only when used.
6481 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6482
cf7cff57
PE
6483 * keymap.c (access_keymap_1): Now static.
6484
7a8e04f7
CY
64852011-07-02 Chong Yidong <cyd@stupidchicken.com>
6486
6487 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6488 leave any prefix arg for the up event (Bug#1586).
6489
61352f62
LMI
64902011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6491
69bb1ef7
LMI
6492 * lread.c (syms_of_lread): Mention single symbols defined by
6493 `defvar' or `defconst' (bug#7154).
6494
61352f62 6495 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6496 (Frequire): Mention get-load-suffixes.
61352f62 6497
28545e04
MR
64982011-07-02 Martin Rudalics <rudalics@gmx.at>
6499
6500 * window.h (window): Remove clone_number slot.
6501 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6502 Remove.
6503 (make_parent_window, make_window, saved_window)
6504 (Fset_window_configuration, save_window_save): Don't deal with
6505 clone numbers.
6506 * buffer.c (Qclone_number): Remove declaration.
6507 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6508
3349e122
SM
65092011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6510
6511 Add multiple inheritance to keymaps.
6512 * keymap.c (Fmake_composed_keymap): New function.
6513 (Fset_keymap_parent): Simplify.
6514 (fix_submap_inheritance): Remove.
6515 (access_keymap_1): New function extracted from access_keymap to handle
6516 embedded parents and handle lists of maps.
6517 (access_keymap): Use it.
6518 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6519 (Fcopy_keymap): Handle embedded parents.
6520 (Fcommand_remapping, define_as_prefix): Simplify.
6521 (Fkey_binding): Simplify.
6522 (syms_of_keymap): Move minibuffer-local-completion-map,
6523 minibuffer-local-filename-completion-map,
6524 minibuffer-local-must-match-map, and
6525 minibuffer-local-filename-must-match-map to Elisp.
6526 (syms_of_keymap): Defsubr make-composed-keymap.
6527 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6528 (parse_menu_item): Trivial simplification.
6529
3279eb87
GM
65302011-07-01 Glenn Morris <rgm@gnu.org>
6531
6532 * Makefile.in (SETTINGS_LIBS): Fix typo.
6533
4550efdf
KI
65342011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6535
6536 * coding.c (Fencode_coding_string): Record the last coding system
6537 used, as the function doc string says (bug#8738).
6538
0949d2b6
JD
65392011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6540
6541 * xsettings.c (store_monospaced_changed): Take new font as arg and
6542 check for change against current_mono_font.
6543 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6544 (emacs_settings_constructor, emacs_settings_get_property)
6545 (emacs_settings_set_property, emacs_settings_class_init)
6546 (emacs_settings_init, gsettings_obj): Remove.
6547 (something_changedCB): New function for HAVE_GSETTINGS.
6548 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6549 with value as argument.
6550 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6551 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6552 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6553 "changed".
6554
6555 * xgselect.c: Add defined (HAVE_GSETTINGS).
6556 (xgselect_initialize): Ditto.
6557
6558 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6559 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6560 xg_select.
6561
bbc6b304
PE
65622011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6563
6564 * eval.c (struct backtrace): Simplify and port the data structure.
6565 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6566 signed bit field, as this assumption is not portable and it makes
6567 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6568 "char debug_on_exit : 1" as this is not portable either; instead,
6569 use the portable "unsigned int debug_on_exit : 1". Remove unused
6570 member evalargs. Remove obsolete comments about cc bombing out.
6571
9851bfc5
JD
65722011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6573
51bb811f 6574 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6575 Let HAVE_GSETTINGS override HAVE_GCONF.
6576 (store_monospaced_changed): New function.
6577 (EMACS_SETTINGS): A new type derived from GObject to handle
6578 GSettings notifications.
6579 (emacs_settings_constructor, emacs_settings_get_property)
6580 (emacs_settings_set_property, emacs_settings_class_init):
6581 New functions.
6582 (gsettings_client, gsettings_obj): New variables.
6583 (GSETTINGS_SCHEMA): New define.
6584 (something_changedCB): Call store_monospaced_changed.
6585 (init_gsettings): New function.
6586 (xsettings_initialize): Call init_gsettings.
6587 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6588 to NULL.
6589
640c8776 6590 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6591 GCONF_CFLAGS/LIBS.
6592
5386012d
MR
65932011-06-29 Martin Rudalics <rudalics@gmx.at>
6594
6595 * window.c (resize_root_window, grow_mini_window)
6596 (shrink_mini_window): Rename Qresize_root_window to
6597 Qwindow_resize_root_window and Qresize_root_window_vertically to
6598 Qwindow_resize_root_window_vertically.
6599
f13e0b08
PE
66002011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6601
6602 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6603
94515237
JB
66042011-06-27 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * makefile.w32-in: Redesign dependencies so they reflect more
6607 clearly which files are directly included by each source file,
6608 and not through other includes.
6609
e43b6e43
MR
66102011-06-27 Martin Rudalics <rudalics@gmx.at>
6611
6612 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6613 (sort_overlays, overlay_strings): When an overlay's clone number
6614 matches the window's clone number process the overlay even if
6615 the overlay's window property doesn't match the current window.
6616
d68443dc
MR
6617 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6618 (Fwindow_hchild): Rename to Fwindow_left_child.
6619 (Fwindow_next): Rename to Fwindow_next_sibling.
6620 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6621 (resize_window_check): Rename to window_resize_check.
6622 (resize_window_apply): Rename to window_resize_apply.
6623 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6624 (Fdelete_other_windows_internal, resize_frame_windows)
6625 (Fsplit_window_internal, Fdelete_window_internal)
6626 (grow_mini_window, shrink_mini_window)
6627 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6628
c7e73be5
JD
66292011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6630
6631 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6632 (emacs_fixed_set_min_size): Remove.
6633 (emacs_fixed_new): Take frame as argument.
6634
6635 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6636 (_EmacsFixedPrivate): Remove minwidth/height.
6637 Add struct frame *f.
6638 (emacs_fixed_init): Initialize priv->f.
6639 (get_parent_class, emacs_fixed_set_min_size): Remove.
6640 (emacs_fixed_new): Set priv->f to argument.
6641 (emacs_fixed_get_preferred_width)
6642 (emacs_fixed_get_preferred_height): Use min_width/height from
6643 frames size_hint to set minimum and natural (Bug#8919).
6644 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6645 and use min_width/height from frames size_hint to set
6646 min_width/height (Bug#8919).
6647
6648 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6649 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6650 Fix indentation.
c7e73be5 6651
cf99dcf8
EZ
66522011-06-26 Eli Zaretskii <eliz@gnu.org>
6653
6654 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6655 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6656 called at ZV.
6657
029529ac
CY
66582011-06-26 Chong Yidong <cyd@stupidchicken.com>
6659
6660 * process.c (wait_reading_process_output): Bypass select if
6661 waiting for a cell while ignoring keyboard input, and input is
6662 pending. Suggested by Jan Djärv (Bug#8869).
6663
7a7ef429
PE
66642011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6665
6666 Use gnulib's dup2 module instead of rolling our own.
6667 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6668
11fdef7d 66692011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6670
6671 * dispnew.c (scrolling_window): Before scrolling, turn off a
6672 mouse-highlight in the window being scrolled.
6673
cd3520a4
JB
66742011-06-24 Juanma Barranquero <lekktu@gmail.com>
6675
6676 Move DEFSYM to lisp.h and use everywhere.
6677
6678 * character.h (DEFSYM): Move declaration...
6679 * lisp.h (DEFSYM): ...here.
6680
6681 * gnutls.c:
6682 * minibuf.c:
6683 * w32menu.c:
6684 * w32proc.c:
6685 * w32select.c: Don't include character.h.
6686
6687 * alloc.c (syms_of_alloc):
6688 * buffer.c (syms_of_buffer):
6689 * bytecode.c (syms_of_bytecode):
6690 * callint.c (syms_of_callint):
6691 * casefiddle.c (syms_of_casefiddle):
6692 * casetab.c (init_casetab_once):
6693 * category.c (init_category_once, syms_of_category):
6694 * ccl.c (syms_of_ccl):
6695 * cmds.c (syms_of_cmds):
6696 * composite.c (syms_of_composite):
6697 * dbusbind.c (syms_of_dbusbind):
6698 * dired.c (syms_of_dired):
6699 * dispnew.c (syms_of_display):
6700 * doc.c (syms_of_doc):
6701 * editfns.c (syms_of_editfns):
6702 * emacs.c (syms_of_emacs):
6703 * eval.c (syms_of_eval):
6704 * fileio.c (syms_of_fileio):
6705 * fns.c (syms_of_fns):
6706 * frame.c (syms_of_frame):
6707 * fringe.c (syms_of_fringe):
6708 * insdel.c (syms_of_insdel):
6709 * keymap.c (syms_of_keymap):
6710 * lread.c (init_obarray, syms_of_lread):
6711 * macros.c (syms_of_macros):
6712 * msdos.c (syms_of_msdos):
6713 * print.c (syms_of_print):
6714 * process.c (syms_of_process):
6715 * search.c (syms_of_search):
6716 * sound.c (syms_of_sound):
6717 * syntax.c (init_syntax_once, syms_of_syntax):
6718 * terminal.c (syms_of_terminal):
6719 * textprop.c (syms_of_textprop):
6720 * undo.c (syms_of_undo):
6721 * w32.c (globals_of_w32):
6722 * window.c (syms_of_window):
6723 * xdisp.c (syms_of_xdisp):
6724 * xfaces.c (syms_of_xfaces):
6725 * xfns.c (syms_of_xfns):
6726 * xmenu.c (syms_of_xmenu):
6727 * xsettings.c (syms_of_xsettings):
6728 * xterm.c (syms_of_xterm): Use DEFSYM.
6729
4228cf16
TZ
67302011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6731
cd3520a4 6732 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6733
7fcccf1e
PE
67342011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6735
7efb4e0e
PE
6736 Integer and buffer overflow fixes (Bug#8873).
6737
ff5844ad
PE
6738 * print.c (printchar, strout): Check for string overflow.
6739 (PRINTPREPARE, printchar, strout):
6740 Don't set size unless allocation succeeds.
6741
90532f02
PE
6742 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6743 for sizes. Check for string overflow more accurately.
6744 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6745
6d84508d
PE
6746 * macros.c: Integer and buffer overflow fixes.
6747 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6748 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6749 Use ptrdiff_t, not int, for sizes.
6750 Don't increment bufsize until after realloc succeeds.
6751 Check for size-calculation overflow.
6752 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6753
437b2cb4
PE
6754 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6755
8b9ac8b4
PE
6756 * lread.c: Integer overflow fixes.
6757 (read_integer): Radix is now EMACS_INT, not int,
6758 to improve quality of diagnostics for out-of-range radices.
6759 Calculate buffer size correctly for out-of-range radices.
6760 (read1): Check for integer overflow in radices, and in
6761 read-circle numbers.
82cb60d3
PE
6762 (read_escape): Avoid int overflow.
6763 (Fload, openp, read_buffer_size, read1)
6764 (substitute_object_recurse, read_vector, read_list, map_obarray):
6765 Use ptrdiff_t, not int, for sizes.
6766 (read1): Use EMACS_INT, not int, for sizes.
20270765 6767 Check for size overflow.
8b9ac8b4 6768
7fcccf1e
PE
6769 * image.c (cache_image): Check for size arithmetic overflow.
6770
bfbbd7e7
PE
6771 * lread.c: Integer overflow issues.
6772 (saved_doc_string_size, saved_doc_string_length)
6773 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6774 Now ptrdiff_t, not int.
6775 (read1): Don't assume doc string length fits in int. Check for
6776 out-of-range doc string lengths.
6777 (read_list): Don't assume file position fits in int.
39019e54 6778 (read_escape): Check for hex character overflow.
bfbbd7e7 6779
4e323265
LL
67802011-06-22 Leo Liu <sdl.web@gmail.com>
6781
6782 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6783 Move to minibuffer.el.
6784
85fece3e
PE
67852011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6786
20b84ce9 6787 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6788 The following patches are for when GLYPH_DEBUG && !XASSERT.
6789 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6790 * dispnew.c (flush_stdout):
6791 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6792 Mark as externally visible.
6793 * dispnew.c (check_window_matrix_pointers): Now static.
6794 * dispnew.c (window_to_frame_vpos):
6795 * xfns.c (unwind_create_frame):
6796 * xterm.c (x_check_font): Remove unused local.
6797 * scroll.c (CHECK_BOUNDS):
6798 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6799 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6800 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6801 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6802 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6803 Now static.
6804 (debug_method_add): Use va_list and vsprintf rather than relying
6805 on undefined behavior with wrong number of arguments.
6806 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6807 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6808 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6809 since we're not interested in debugging glyphs with old libraries.
6810 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6811 GCC 4.6.0's static checking.
6812
0766b489
PE
68132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6814
31fd4b32
PE
6815 Integer overflow and signedness fixes (Bug#8873).
6816 A few related buffer overrun fixes, too.
6817
b79e8648
PE
6818 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6819
0766b489
PE
6820 * dispextern.h (struct face.stipple):
6821 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6822 (x_bitmap_mask, x_allocate_bitmap_record)
6823 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6824 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6825 (x_create_bitmap_from_xpm_data):
6826 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6827 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6828 (.bitmaps_last):
6829 * xfaces.c (load_pixmap):
6830 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6831 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6832 (.bitmaps_last, struct x_output.icon_bitmap):
6833 Use ptrdiff_t, not int, for bitmap indexes.
6834 (x_allocate_bitmap_record): Check for size overflow.
6835 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6836
b081724f
PE
6837 Use ptrdiff_t, not int, for overlay counts.
6838 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6839 * editfns.c (overlays_around, get_pos_property):
6840 * textprop.c (get_char_property_and_overlay):
6841 * xdisp.c (next_overlay_change, note_mouse_highlight):
6842 * xfaces.c (face_at_buffer_position):
21514da7
PE
6843 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6844 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6845 (Fnext_overlay_change, Fprevious_overlay_change)
6846 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6847 Use ptrdiff_t, not int, for sizes.
21514da7 6848 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6849
3de73e5e
PE
6850 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6851
2606c57b
PE
6852 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6853 (x_session_initialize): Do not assume string length fits in int.
6854
aaafe47a
PE
6855 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6856 This is unlikely, but can occur if DPI is outlandish.
6857
2674ddc8 6858 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6859 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6860
28154962
PE
6861 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6862 * xrdb.c (magic_file_p, search_magic_path):
6863 Omit last arg SUFFIX; it was always 0. All callers changed.
6864 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6865
7de51af5
PE
6866 * xfont.c (xfont_match): Avoid need for strlen.
6867
25ed6cc3
PE
6868 * xfns.c: Don't assume strlen fits in int.
6869 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6870
4eab31dd
PE
6871 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6872 not unsigned long, as we prefer signed integers. All callers changed.
6873 Detect integer overflow in repeat count.
6874 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6875 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6876
171e2a58
PE
6877 * termcap.c: Don't assume sizes fit in int and never overflow.
6878 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6879 (gobble_line): Check for size-calculation overflow.
6880
ad39faca 6881 * minibuf.c (Fread_buffer):
6e5bb2dc 6882 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6883 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6884 Don't assume string length fits in int.
6885
52c61c22 6886 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6887 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6888
b5b8c9e5
PE
6889 * font.c: Don't assume string length fits in int.
6890 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6891 Use ptrdiff_t, not int.
ccd6111c
PE
6892 (font_intern_prop): Don't assume string length fits in int.
6893 Don't assume integer property fits in fixnum.
6894 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6895
882f0d81 6896 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6897 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6898 Reformulate so as not to need the command string.
6899 Invoke gzip -cd rather than gunzip, as it's more portable.
6900 (lock_info_type, lock_file_1, lock_file):
6901 Don't assume pid_t and time_t fit in unsigned long.
6902 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6903 (current_lock_owner): Prefer signed type for sizes.
6904 Use memcpy, not strncpy, where memcpy is what is really wanted.
6905 Don't assume (via atoi) that time_t and pid_t fit in int.
6906 Check for time_t and/or pid_t out of range, e.g., via a network share.
6907 Don't alloca where an auto var works fine.
6908
93f4cf88
PE
6909 * fileio.c: Fix some integer overflow issues.
6910 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6911 Don't assume string length fits in int.
6912 (directory_file_name): Don't assume string length fits in long.
6913 (make_temp_name): Don't assume pid fits in int, or that its print
6914 length is less than 20.
6915
f3e92b69
PE
6916 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6917
1bfdaf10
PE
6918 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6919
35016e9a
PE
6920 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6921
3d1e65a1
PE
6922 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6923 We prefer signed integers, even for size calculations.
6924
0b963a93
PE
6925 * emacs.c: Don't assume string length fits in 'int'.
6926 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6927 (main): Don't invoke strlen when not needed.
6928
573f4b54
PE
6929 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6930 (XD_DEBUG_MESSAGE): Don't waste a byte.
6931
989f33ba
PE
6932 * callproc.c (getenv_internal_1, getenv_internal)
6933 (Fgetenv_internal):
965d34eb
PE
6934 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6935
e4d29b33
PE
6936 * lread.c (invalid_syntax): Omit length argument.
6937 All uses changed. This doesn't fix a bug, but it simplifies the
6938 code away from its former Hollerith-constant appearance, and it's
6939 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6940 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6941
eb49b136
PE
6942 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6943 This didn't break anything, but it didn't help either.
6944 It's confusing to put a bogus integer in a place where the actual
6945 value does not matter.
9f62aeb1 6946 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6947 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6948
15375a22
PE
6949 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6950 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6951 implementation.
b61cc01c
PE
6952 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6953 We prefer signed types, and the value cannot exceed the EMACS_INT
6954 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6955 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6956 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6957 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6958
53b2623d
PE
6959 * indent.c (sane_tab_width): New function.
6960 (current_column, scan_for_column, Findent_to, position_indentation)
6961 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6962 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6963
51cab52b 6964 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6965
f2ed8a70
PE
6966 * lisp.h (lint_assume): New macro.
6967 * composite.c (composition_gstring_put_cache):
6968 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6969
abe80cc6
PE
6970 * editfns.c, insdel.c:
6971 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6972
b02c740e
PE
6973 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6974
ebc96716
PE
6975 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6976
b4e50fa0 6977 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6978 Use much-faster test for byte-length change.
311d5d7c 6979 Don't assume string byte-length fits in 'int'.
a4cf38e4 6980 Check that character arg fits in 'int'.
85461888 6981 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6982
c0c1ee9f
PE
6983 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6984
a498d7f4
PE
6985 * fns.c (concat): Catch string overflow earlier.
6986 Do not rely on integer wraparound.
6987
51cab52b
PE
6988 * dispextern.h (struct it.overlay_strings_charpos)
6989 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6990 * xdisp.c (forward_to_next_line_start)
6991 (back_to_previous_visible_line_start)
6992 (reseat_at_next_visible_line_start, next_element_from_buffer):
6993 Don't arbitrarily truncate the value of 'selective' to int.
6994
76031fad
PE
6995 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6996
5eb55db9
PE
6997 * composite.c: Don't truncate sizes to 'int'.
6998 (composition_gstring_p, composition_reseat_it)
6999 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7000 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7001 not EMACS_UINT, for indexes.
5eb55db9 7002
0703a717
PE
7003 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7004
d6202519
PE
7005 * buffer.c: Include <verify.h>.
7006 (struct sortvec.priority, struct sortstr.priority):
8961a454 7007 Now EMACS_INT, not int.
c20998a7 7008 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7009 (struct sortstr.size, record_overlay_string)
7010 (struct sortstrlist.size, struct sortlist.used):
7011 Don't truncate size to int.
7012 (record_overlay_string): Check for size-calculation overflow.
d6202519 7013 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7014
d5a19415
JM
70152011-06-22 Jim Meyering <meyering@redhat.com>
7016
029529ac 7017 Don't leak an XBM-image-sized buffer
d5a19415
JM
7018 * image.c (xbm_load): Free the image buffer after using it.
7019
a9041e6c
PE
70202011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7021
7022 Port to Sun C.
7023 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7024 that Sun C diagnosed.
7025 * fns.c (secure_hash): Fix pointer signedness issue.
7026 * intervals.c (static_offset_intervals): New function.
7027 (offset_intervals): Use it.
7028
7f3f739f
LL
70292011-06-21 Leo Liu <sdl.web@gmail.com>
7030
7031 * deps.mk (fns.o):
7032 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7033 sha512.h.
7034
7035 * fns.c (secure_hash): Rename from crypto_hash_function and change
7036 the first arg to accept symbols.
5b66d427 7037 (Fsecure_hash): New primitive.
7f3f739f
LL
7038 (syms_of_fns): New symbols.
7039
76147d94
DD
70402011-06-20 Deniz Dogan <deniz@dogan.se>
7041
7042 * process.c (Fset_process_buffer): Clarify return value in
7043 docstring.
7044
7d7d0045
CY
70452011-06-18 Chong Yidong <cyd@stupidchicken.com>
7046
7047 * dispnew.c (add_window_display_history): Use BVAR.
7048
7049 * xdisp.c (debug_method_add): Use BVAR.
7050 (check_window_end, dump_glyph_matrix, dump_glyph)
7051 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7052
7053 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7054 Likewise.
7055
7056 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7057 check till after the cache is created in init_frame_faces.
7058
ff2bc410
SM
70592011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7060
7061 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7062
28177add
PE
70632011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7064
dd3482fe
PE
7065 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7066 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7067 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7068
393d71f3 7069 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7070 * fileio.c (Finsert_file_contents):
7071 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7072 Remove the old (too-loose) buffer overflow checks.
7073 They weren't needed, since make_gap checks for buffer overflow.
7074 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7075 The old code merely checked for Emacs fixnum overflow, and relied
7076 on undefined (wraparound) behavior. The new code avoids undefined
7077 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7078
2e6813b0 7079 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7080 Tune. Don't use wider integers than needed. Don't use alloca.
7081 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7082
599a9e4f
PE
7083 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7084
99561444
PE
7085 * insdel.c, lisp.h (buffer_overflow): New function.
7086 (insert_from_buffer_1, replace_range, replace_range_2):
7087 * insdel.c (make_gap_larger):
7088 * editfns.c (Finsert_char):
7089 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7090
28177add
PE
7091 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7092
e69dafad
PE
70932011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7094
4baa020d 7095 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7096
b1c46f02
PE
7097 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7098 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7099
e69dafad
PE
7100 * fileio.c: Don't assume EMACS_INT fits in off_t.
7101 (emacs_lseek): New static function.
7102 (Finsert_file_contents, Fwrite_region): Use it.
7103 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7104
566684ea
PE
7105 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7106
e6966cd6
PE
7107 * fns.c: Don't overflow int when computing a list length.
7108 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7109 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7110 truncation on 64-bit hosts. Check for QUIT every
7111 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7112 faster and is responsive enough.
7113 (Flength): Report an error instead of overflowing an integer.
7114 (Fsafe_length): Return a float if the value is not representable
7115 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7116 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7117 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7118
dd0b0efb
PE
7119 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7120 (header_size, word_size): New constants.
7121 (allocate_vectorlike): Don't check size overflow here.
7122 (allocate_vector): Check it here instead, since this is the only
7123 caller of allocate_vectorlike that could cause overflow.
7124 Check that the new vector's length is representable as a fixnum.
7125
86fe5cfe
PE
7126 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7127 The previous code was bogus. For example, next_almost_prime (32)
7128 returned 39, which is undesirable as it is a multiple of 3; and
7129 next_almost_prime (24) returned 25, which is a multiple of 5 so
7130 why was the code bothering to check for multiples of 7?
7131
80e88859
PE
7132 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7133
4a2f0ad6
PE
7134 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7135
f66c7cf8
PE
7136 Variadic C functions now count arguments with ptrdiff_t.
7137 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7138 Back then I didn't know that the Emacs coding style prefers signed int.
7139 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7140 were being counted with int, which may truncate counts on 64-bit
7141 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7142 * lisp.h (struct Lisp_Subr.function.aMANY)
7143 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7144 Arg counts are now ptrdiff_t, not size_t.
7145 All variadic functions and their callers changed accordingly.
7146 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7147 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7148 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7149 * callint.c (Fcall_interactively): Check arg count for overflow,
7150 to avoid potential buffer overrun. Use signed char, not 'int',
7151 for 'varies' array, so that we needn't bother to check its size
7152 calculation for overflow.
7153 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7154 * eval.c (apply_lambda):
7155 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7156 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7157 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7158
a1759b76
PE
7159 * callint.c (Fcall_interactively): Don't use index var as event count.
7160
d96be9fc
PE
7161 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7162 * mem-limits.h (SIZE): Remove; no longer used.
7163
a690a978 7164 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7165
578c21e6
PE
7166 Remove unnecessary casts.
7167 * xterm.c (x_term_init):
7168 * xfns.c (x_set_border_pixel):
7169 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7170 These aren't needed now that we assume ANSI C.
7171
96f53c6c
PE
7172 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7173 It's more likely to cause problems (due to unsigned overflow)
7174 than to cure them.
7175
83c77d31
PE
7176 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7177
ee2079f1
PE
7178 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7179
6da65536
PE
7180 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7181
7147c4a4
PE
7182 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7183
193e32d9
PE
7184 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7185
e5533da6
PE
7186 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7187
9910e595
PE
7188 GLYPH_CODE_FACE returns EMACS_INT, not int.
7189 * dispextern.h (merge_faces):
7190 * xfaces.c (merge_faces):
01103c44
PE
7191 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7192 Don't assume EMACS_INT fits in int.
9910e595 7193
2638320e
PE
7194 * character.h (CHAR_VALID_P): Remove unused parameter.
7195 * fontset.c, lisp.h, xdisp.c: All uses changed.
7196
045eb8d9
PE
7197 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7198
c1f134b5
PE
7199 * fns.c (concat): Minor tuning based on overflow analysis.
7200 This doesn't fix any bugs. Use int to hold character, instead
7201 of constantly refetching from Emacs object. Use XFASTINT, not
7202 XINT, for value known to be a character. Don't bother comparing
7203 a single byte to 0400, as it's always less.
7204
395fcb93 7205 * floatfns.c (Fexpt):
327eeec8
PE
7206 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7207
abbd3d23
PE
7208 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7209 for characters.
7210
684a03ef
PE
7211 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7212
0fed43f3
PE
7213 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7214 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7215 incorrectly succeed when S was a string, because 4294967386 was
7216 truncated before it was used.
7217
8fd02eb7
PE
7218 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7219 Otherwise, an out-of-range integer could cause undefined behavior
7220 on a 64-bit host.
7221
f8c86b69
PE
7222 * composite.c: Use int, not EMACS_INT, for characters.
7223 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7224 EMACS_INT, for values that are known to be in character range.
7225 This doesn't fix any bugs but is the usual style inside Emacs and
7226 may generate better code on 32-bit machines.
7227
34206dd2
PE
7228 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7229 This is for reasons similar to the recent CHAR_STRING fix.
7230 * charset.c (Fencode_char): Check that character arg is actually
7231 a character. Pass an int to ENCODE_CHAR.
7232 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7233 wider than 'int', as a compile-time check to prevent future regressions
7234 in this area.
7235
c5958d4c 7236 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7237
7238 Make sure a 64-bit char is never passed to CHAR_STRING.
7239 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7240 by silently ignoring the top 32 bits, allowing some values
7241 that were far too large to be valid characters.
7242 * character.h: Include <verify.h>.
7243 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7244 arguments are no wider than unsigned, as a compile-time check
7245 to prevent future regressions in this area.
7246 * data.c (Faset):
01103c44 7247 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7248 (Fsubst_char_in_region):
7249 * fns.c (concat):
7250 * xdisp.c (decode_mode_spec_coding):
7251 Adjust to CHAR_STRING's new requirement.
7252 * editfns.c (Finsert_char, Fsubst_char_in_region):
7253 * fns.c (concat): Check that character args are actually
7254 characters. Without this test, these functions did the wrong
7255 thing with wildly out-of-range values on 64-bit hosts.
7256
d37ca623
PE
7257 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7258 These casts should not be needed on 32-bit hosts, either.
7259 * keyboard.c (read_char):
7260 * lread.c (Fload): Remove casts to unsigned.
7261
ea204efb
PE
7262 * lisp.h (UNSIGNED_CMP): New macro.
7263 This fixes comparison bugs on 64-bit hosts.
7264 (ASCII_CHAR_P): Use it.
7265 * casefiddle.c (casify_object):
01103c44 7266 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7267 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7268 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7269 * dispextern.h (FACE_FROM_ID):
7270 * keyboard.c (read_char): Use UNSIGNED_CMP.
7271
41cb286c
PE
7272 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7273 not to EMACS_INT, to avoid GCC warning.
7274
4a1b9832
PE
7275 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7276
55daad71
PE
7277 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7278 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7279 isn't needed on 32-bit machines.
8f95c75c 7280
01103c44
PE
7281 * buffer.c (Fgenerate_new_buffer_name):
7282 Use EMACS_INT for count, not int.
0ceccced 7283 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7284
7285 * data.c (Qcompiled_function): Now static.
7286
c6f072e7
PE
7287 * window.c (window_body_lines): Now static.
7288
20ce5912
PE
7289 * image.c (gif_load): Rename local to avoid shadowing.
7290
9c4c5f81
PE
7291 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7292 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7293 * alloc.c (make_save_value): Integer argument is now of type
7294 ptrdiff_t, not int.
7295 (mark_object): Use ptrdiff_t, not int.
7296 * lisp.h (pD): New macro.
7297 * print.c (print_object): Use it.
7298
c0c5c8ae
PE
7299 * alloc.c: Use EMACS_INT, not int, to count objects.
7300 (total_conses, total_markers, total_symbols, total_vector_size)
7301 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7302 (total_free_floats, total_floats, total_free_intervals)
7303 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7304 Now EMACS_INT, not int. All uses changed.
7305 (Fgarbage_collect): Compute overall total using a double, so that
7306 integer overflow is less likely to be a problem. Check for overflow
7307 when converting back to an integer.
5a25e253
PE
7308 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7309 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7310 These were 'int' variables that could overflow on 64-bit hosts;
7311 they were never used, so remove them instead of repairing them.
211a0b2a 7312 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7313 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7314 Previously, this ceilinged at INT_MAX, but that doesn't work on
7315 64-bit machines.
e46bb31a 7316 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7317
c78baabf 7318 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7319 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7320 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7321 when a (possibly-narrower) signed value would do just as well.
7322 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7323
c9d624c6
PE
7324 * alloc.c: Catch some string size overflows that we were missing.
7325 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7326 for convenience in STRING_BYTES_MAX.
7327 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7328 The definition here is exact; the one in lisp.h was approximate.
7329 (allocate_string_data): Check for string overflow. This catches
7330 some instances we weren't catching before. Also, it catches
7331 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7332 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7333 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7334
c9d624c6
PE
7335 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7336 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7337 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7338
353032ce
PE
7339 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7340
2bccce07
PE
7341 * alloc.c (Fmake_string): Check for out-of-range init.
7342
0ac30604
SM
73432011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7344
7345 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7346
c195f2de
JD
73472011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7348
7349 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7350 xg_get_default_scrollbar_width.
7351
7352 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7353 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7354 (style_changed_cb): Call update_theme_scrollbar_width and call
7355 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7356 all frames (Bug#8505).
7357 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7358 Call gtk_window_set_resizable if HAVE_GTK3.
7359 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7360 and height if HAVE_GTK3 (Bug#8505).
7361 (scroll_bar_width_for_theme): New variable.
7362 (update_theme_scrollbar_width): New function.
7363 (xg_get_default_scrollbar_width): Move code to
7364 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7365 (xg_initialize): Call update_theme_scrollbar_width.
7366
7367 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7368
7369 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7370
e10ac9f1
MR
73712011-06-12 Martin Rudalics <rudalics@gmx.at>
7372
7373 * frame.c (make_frame): Call other_buffer_safely instead of
7374 other_buffer.
7375
7376 * window.c (temp_output_buffer_show): Call display_buffer with
7377 second argument Vtemp_buffer_show_specifiers and reset latter
7378 immediately after the call.
7379 (Vtemp_buffer_show_specifiers): New variable.
7380 (auto_window_vscroll_p, next_screen_context_lines)
7381 (Vscroll_preserve_screen_position): Remove leading asterisks from
7382 doc-strings.
7383
2d3c217e 73842011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7385
7b7f97e8 7386 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7387 * buffer.c (Qclone_number): Remove for now, as it's unused.
7388 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7389 (record_buffer): Remove unused local.
7390 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7391 (set_frame_buffer_list): Remove; unused.
7392 * frame.h (other_visible_frames): Remove decl.
7393 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7394 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7395 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7396 if HAVE_GPM.
7397 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7398 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7399 Define only if HAVE_GPM.
7400 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7401 (update_hints_inhibit): Remove; never set. All uses removed.
7402 * widgetprv.h (emacsFrameClassRec): Remove decl.
7403 * window.c (delete_deletable_window): Now returns void, since it
7404 wasn't returning anything.
7405 (compare_window_configurations): Remove unused locals.
7406 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7407 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7408 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7409 the same widths as pointers. This follows up on the 2011-05-06 patch.
7410 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7411 * xterm.h: Likewise.
7412 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7413
1384b89e
JB
74142011-06-12 Juanma Barranquero <lekktu@gmail.com>
7415
7416 * makefile.w32-in: Update dependencies.
7417 (LISP_H): Add lib/intprops.h.
7418
1100a63c
CY
74192011-06-11 Chong Yidong <cyd@stupidchicken.com>
7420
7421 * image.c (gif_load): Add animation frame delay to the metadata.
7422 (syms_of_image): Use DEFSYM. New symbol `delay'.
7423
6198ccd0
MR
74242011-06-11 Martin Rudalics <rudalics@gmx.at>
7425
7426 * window.c (delete_deletable_window): Re-add.
7427 (Fset_window_configuration): Rewrite to handle dead buffers and
7428 consequently deletable windows.
7429 (window_tree, Fwindow_tree): Remove. Supply functionality in
7430 window.el.
7431 (compare_window_configurations): Simplify code.
7432
b6e3633c
AS
74332011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7434
1ab0dee5
AS
7435 * image.c (imagemagick_load_image): Fix type mismatch.
7436 (Fimagemagick_types): Likewise.
7437
b6e3633c
AS
7438 * window.h (replace_buffer_in_windows): Declare.
7439
9397e56f
MR
74402011-06-11 Martin Rudalics <rudalics@gmx.at>
7441
7442 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7443 Qclone_number. Remove external declaration of Qdelete_window.
7444 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7445 code.
640c8776
SM
7446 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7447 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7448 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7449 buffer list implementation.
7450 (other_buffer_safely): New function.
7451 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7452 calls to replace_buffer_in_windows and
7453 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7454 if allowed.
7455 (record_buffer): Inhibit quitting and rewrite using quittable
7456 functions. Run Qbuffer_list_update_hook if allowed.
7457 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7458 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7459 Move switch-to-buffer to window.el.
9397e56f
MR
7460 (bury-buffer): Move to window.el.
7461 (Vbuffer_list_update_hook): New variable.
7462
7463 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7464 section.
7465
7466 * window.h (resize_frame_windows): Move up in code.
7467 (Fwindow_frame): Remove EXFUN.
7468 (replace_buffer_in_all_windows): Remove prototype.
7469 (replace_buffer_in_windows_safely): Add prototype.
7470
7471 * window.c: Declare Qdelete_window static again. Move down
7472 declaration of select_count.
7473 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7474 (Fother_window): Move to window.el.
7475 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7476 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7477 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7478 window.el.
7479 (replace_buffer_in_windows): Implement by calling
7480 Qreplace_buffer_in_windows.
7481 (replace_buffer_in_all_windows): Remove with some functionality
7482 moved into replace_buffer_in_windows_safely.
7483 (replace_buffer_in_windows_safely): New function.
7484 (select_window_norecord, select_frame_norecord): Move in front
7485 of run_window_configuration_change_hook. Remove now obsolete
7486 declarations.
640c8776
SM
7487 (Fset_window_buffer): Rewrite doc-string.
7488 Call Qrecord_window_buffer.
9397e56f
MR
7489 (keys_of_window): Move binding for other-window to window.el.
7490
b50691aa
CY
74912011-06-11 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * dispextern.h (struct image): Replace data member, whose int_val
7494 and ptr_val fields were not used by anything, with a single
7495 lisp_val object.
7496
7497 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7498 (gif_clear_image, gif_load, imagemagick_load_image)
7499 (gs_clear_image, gs_load): Callers changed.
7500
3f754b86
PE
75012011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7502
cca69397
PE
7503 * buffer.h: Include <time.h>, for time_t.
7504 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7505
109e28d0
PE
7506 Fix minor problems found by static checking.
7507
60737f02
PE
7508 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7509
4b66faf3
PE
7510 Make identifiers static if they are not used in other modules.
7511 * data.c (Qcompiled_function, Qframe, Qvector):
7512 * image.c (QimageMagick, Qsvg):
7513 * minibuf.c (Qmetadata):
7514 * window.c (resize_window_check, resize_root_window): Now static.
7515 * window.h (resize_window_check, resize_root_window): Remove decls.
7516
109e28d0
PE
7517 * window.c (window_deletion_count, delete_deletable_window):
7518 Remove; unused.
46a4ce9e
PE
7519 (window_body_lines): Now static.
7520 (Fdelete_other_windows_internal): Mark vars as initialized.
7521 Make sure 'resize_failed' is initialized.
7522 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7523 (resize_window_apply): Remove unused local.
7524 * window.h (delete_deletable_window): Remove decl.
7525
109e28d0 7526 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7527 (imagemagick_load_image): Fix pointer signedness problem by changing
7528 last arg from unsigned char * to char *. All uses changed.
7529 Also, fix a local for similar reasons.
7530 Remove unused locals. Remove locals to avoid shadowing.
7531 (fn_rsvg_handle_free): Remove; unused.
7532 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7533 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7534
3f754b86
PE
7535 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7536
2547adb1
CY
75372011-06-10 Chong Yidong <cyd@stupidchicken.com>
7538
7539 * image.c (gif_load): Fix omitted cast error introduced by
7540 2011-06-06 change.
7541
2c8e37d4
MR
75422011-06-10 Martin Rudalics <rudalics@gmx.at>
7543
7544 * window.h (resize_proportionally, orig_total_lines)
7545 (orig_top_line): Remove from window structure.
7546 (set_window_height, set_window_width, change_window_heights)
7547 (Fdelete_window): Remove prototypes.
7548 (resize_frame_windows): Remove duplicate declaration.
7549
440a42e3
EZ
75502011-06-10 Eli Zaretskii <eliz@gnu.org>
7551
7552 * window.h (resize_frame_windows, resize_window_check)
7553 (delete_deletable_window, resize_root_window)
7554 (resize_frame_windows): Declare prototypes.
7555
7556 * window.c (resize_window_apply): Make definition be "static" to
7557 match the prototype.
7558
562dd5e9
MR
75592011-06-10 Martin Rudalics <rudalics@gmx.at>
7560
7561 * window.c: Remove declarations of Qwindow_size_fixed,
7562 window_min_size_1, window_min_size_2, window_min_size,
7563 size_window, window_fixed_size_p, enlarge_window, delete_window.
7564 Remove static from declaration of Qdelete_window, it's
7565 temporarily needed by Fbury_buffer.
7566 (replace_window): Don't assign orig_top_line and
7567 orig_total_lines.
7568 (Fdelete_window, delete_window): Remove. Window deletion is
7569 handled by window.el.
640c8776
SM
7570 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7571 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7572 (Fdelete_other_windows): Remove. Deleting other windows is
7573 handled by window.el.
7574 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7575 handled in window.el.
7576 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7577 Window minimum sizes are handled in window.el.
7578 (shrink_windows, size_window, set_window_height)
7579 (set_window_width, change_window_heights, window_height)
7580 (window_width, CURBEG, CURSIZE, enlarge_window)
7581 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7582 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7583 handled in window.el.
7584 (make_dummy_parent): Rename to make_parent_window and give it a
7585 second argument horflag.
7586 (make_window): Don't set resize_proportionally any more.
7587 (Fsplit_window): Remove. Windows are split in window.el.
7588 (save_restore_action, save_restore_orig_size)
7589 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7590 Resize mini windows in window.el.
7591 (grow_mini_window, shrink_mini_window): Implement by calling
7592 Qresize_root_window_vertically, resize_window_check and
7593 resize_window_apply.
640c8776
SM
7594 (saved_window, Fset_window_configuration, save_window_save):
7595 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7596 resize_proportionally.
7597 (window_min_height, window_min_width): Move to window.el.
7598 (keys_of_window): Move bindings for delete-other-windows,
7599 split-window, delete-window and enlarge-window to window.el.
7600
7601 * buffer.c: Temporarily extern Qdelete_window.
7602 (Fbury_buffer): Temporarily call Qdelete_window instead of
7603 Fdelete_window (Fbury_buffer will move to window.el soon).
7604
7605 * frame.c (set_menu_bar_lines_1): Remove code handling
7606 orig_top_line and orig_total_lines.
7607
7608 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7609 set_window_height but set heights directly.
7610 (change_frame_size_1): Use resize_frame_windows.
7611
7612 * xdisp.c (init_xdisp): Don't use set_window_height but set
7613 heights directly.
7614
640c8776
SM
7615 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7616 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7617 run_window_configuration_change_hook.
7618
7619 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7620 instead of change_window_heights and run
7621 run_window_configuration_change_hook.
7622
1a13852e
MR
76232011-06-09 Martin Rudalics <rudalics@gmx.at>
7624
7625 * window.c (replace_window): Rename second argument REPLACEMENT to
7626 NEW. New third argument SETFLAG. Rewrite.
7627 (delete_window, make_dummy_parent): Call replace_window with
7628 third argument 1.
7629 (window_list_1): Move down in code.
7630 (run_window_configuration_change_hook): Move set_buffer part
7631 before select_frame_norecord part in order to unwind correctly.
7632 Rename count1 to count.
7633 (recombine_windows, delete_deletable_window, resize_root_window)
7634 (Fdelete_other_windows_internal)
7635 (Frun_window_configuration_change_hook, make_parent_window)
7636 (resize_window_check, resize_window_apply, Fresize_window_apply)
7637 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7638 (Fdelete_window_internal, Fresize_mini_window_internal):
7639 New functions.
1a13852e
MR
7640 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7641
f3d1777e
MR
76422011-06-08 Martin Rudalics <rudalics@gmx.at>
7643
496e208e
MR
7644 * window.h (window): Add some new members to window structure -
7645 normal_lines, normal_cols, new_total, new_normal, clone_number,
7646 splits, nest, prev_buffers, next_buffers.
7647 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7648 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7649
f3d1777e
MR
7650 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7651 Remove.
496e208e
MR
7652 (make_dummy_parent): Set new members of windows structure.
7653 (make_window): Move down in code. Handle new members of window
7654 structure.
7655 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7656 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7657 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7658 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7659 (Fset_window_next_buffers, Fset_window_clone_number):
7660 New functions.
496e208e
MR
7661 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7662 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7663 Doc-string fixes.
7664 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7665 Argument WINDOW can be now internal window too.
7666 (Fwindow_use_time): Move up in code.
7667 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7668 Rewrite doc-string.
7669 (Fset_window_configuration, saved_window)
7670 (Fcurrent_window_configuration, save_window_save): Handle new
7671 members of window structure.
b9e809c2
MR
7672 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7673 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7674 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7675 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7676 Qget_mru_window, Qresize_root_window,
7677 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7678 Qauto_buffer_name; staticpro them.
f3d1777e 7679
abde8f8c
MR
76802011-06-07 Martin Rudalics <rudalics@gmx.at>
7681
7682 * window.c (Fwindow_total_size, Fwindow_left_column)
7683 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7684 (Fwindow_list_1): New functions.
7685 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7686 (Fwindow_width, Fscroll_left, Fscroll_right):
7687 Use window_body_cols instead of window_box_text_cols.
7688 (delete_window, Fset_window_configuration):
7689 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7690 (delete_all_subwindows): Take a window as argument and not a
7691 structure. Rewrite.
190b47e6
MR
7692 (window_loop): Remove handling of GET_LRU_WINDOW and
7693 GET_LARGEST_WINDOW.
7694 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7695
7696 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7697 window_box_text_cols. delete_all_subwindows now takes a
7698 Lisp_Object as argument.
abde8f8c 7699
640c8776
SM
7700 * indent.c (compute_motion, Fcompute_motion):
7701 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7702
fa8a67e6
MR
7703 * frame.c (delete_frame): Call delete_all_subwindows with root
7704 window as argument.
7705
a54e3482
DC
77062011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7707
7708 * fns.c (Fputhash): Document return value.
7709
60002bf5
CY
77102011-06-06 Chong Yidong <cyd@stupidchicken.com>
7711
7712 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7713
0c671da6 77142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7715
b862a52a 7716 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7717
be44ca6c
PE
7718 Check for overflow when converting integer to cons and back.
7719 * charset.c (Fdefine_charset_internal, Fdecode_char):
7720 Use cons_to_unsigned to catch overflow.
7721 (Fencode_char): Use INTEGER_TO_CONS.
7722 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7723 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7724 * data.c (long_to_cons, cons_to_long): Remove.
7725 (cons_to_unsigned, cons_to_signed): New functions.
7726 These signal an error for invalid or out-of-range values.
7727 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7728 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7729 * font.c (Ffont_variation_glyphs):
7730 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7731 * lisp.h: Include <intprops.h>.
7732 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7733 (cons_to_signed, cons_to_unsigned): New decls.
7734 (long_to_cons, cons_to_long): Remove decls.
7735 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7736 (Fprimitive_undo): Use CONS_TO_INTEGER.
7737 * xfns.c (Fx_window_property): Likewise.
7738 * xselect.c: Include <limits.h>.
7739 (x_own_selection, selection_data_to_lisp_data):
7740 Use INTEGER_TO_CONS.
7741 (x_handle_selection_request, x_handle_selection_clear)
7742 (x_get_foreign_selection, Fx_disown_selection_internal)
7743 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7744 (lisp_data_to_selection_data): Use cons_to_unsigned.
7745 (x_fill_property_data): Use cons_to_signed.
7746 Report values out of range.
7747
d1f3d2af
PE
7748 Check for buffer and string overflow more precisely.
7749 * buffer.h (BUF_BYTES_MAX): New macro.
7750 * lisp.h (STRING_BYTES_MAX): New macro.
7751 * alloc.c (Fmake_string):
7752 * character.c (string_escape_byte8):
7753 * coding.c (coding_alloc_by_realloc):
7754 * doprnt.c (doprnt):
7755 * editfns.c (Fformat):
7756 * eval.c (verror):
7757 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7758 since they may not be the same number.
7759 * editfns.c (Finsert_char):
7760 * fileio.c (Finsert_file_contents):
7761 Likewise for BUF_BYTES_MAX.
7762
dd52fcea
PE
7763 * image.c: Use ptrdiff_t, not int, for sizes.
7764 (slurp_file): Switch from int to ptrdiff_t.
7765 All uses changed.
7766 (slurp_file): Check that file size fits in both size_t (for
7767 malloc) and ptrdiff_t (for sanity and safety).
7768
7f9bbdbb
PE
7769 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7770 if b->modtime has its maximal value.
7771
dfe18f82
PE
7772 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7773
84acfcf0
PE
7774 Don't assume time_t can fit into int.
7775 * buffer.h (struct buffer.modtime): Now time_t, not int.
7776 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7777 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7778
ccd9a01a
PE
7779 Minor fixes for signed vs unsigned integers.
7780 * character.h (MAYBE_UNIFY_CHAR):
7781 * charset.c (maybe_unify_char):
7782 * keyboard.c (read_char, reorder_modifiers):
7783 XINT -> XFASTINT, since the integer must be nonnegative.
7784 * ftfont.c (ftfont_spec_pattern):
7785 * keymap.c (access_keymap, silly_event_symbol_error):
7786 XUINT -> XFASTINT, since the integer must be nonnegative.
7787 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7788 since it makes no difference and we prefer signed.
7789 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7790 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7791 nonnegative.
7792
d6d100dd
SM
77932011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7794
7795 * window.h (Fwindow_frame): Declare.
7796
2b6148e4
PE
77972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7798
7799 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7800 (SPARE_MEMORY): Always define.
7801 (LARGE_REQUEST): Remove.
7802 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7803
f230ecc9
MR
78042011-06-06 Martin Rudalics <rudalics@gmx.at>
7805
727e958e
MR
7806 * lisp.h: Move EXFUNS for Fframe_root_window,
7807 Fframe_first_window and Fset_frame_selected_window to window.h.
7808
7809 * window.h: Move EXFUNS for Fframe_root_window,
7810 Fframe_first_window and Fset_frame_selected_window here from
7811 lisp.h.
7812
7813 * frame.c (Fwindow_frame, Fframe_first_window)
7814 (Fframe_root_window, Fframe_selected_window)
7815 (Fset_frame_selected_window): Move to window.c.
7816 (Factive_minibuffer_window): Move to minibuf.c.
7817 (Fother_visible_frames_p): New function.
7818
7819 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7820
f230ecc9
MR
7821 * window.c (decode_window, decode_any_window): Move up in code.
7822 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7823 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7824 (Fwindow_buffer): Move up and rewrite doc-string.
7825 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7826 (Fwindow_prev): New functions.
727e958e
MR
7827 (Fwindow_frame): Move here from frame.c. Accept any window as
7828 argument.
7829 (Fframe_root_window, Fframe_first_window)
7830 (Fframe_selected_window): Move here from frame.c. Accept frame
7831 or arbitrary window as argument. Update doc-strings.
7832 (Fminibuffer_window): Move up in code.
7833 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7834 (Fset_frame_selected_window): Move here from frame.c.
7835 Marginal rewrite.
727e958e
MR
7836 (Fselected_window, select_window, Fselect_window): Move up in
7837 code. Minor doc-string fixes.
f230ecc9 7838
4d09bcf6
PE
78392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7840
7841 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7842 Do not assume that spare memory exists; that assumption is valid
7843 only if SYSTEM_MALLOC.
7844 (LARGE_REQUEST): New macro, so that the issue of large requests
7845 is separated from the issue of spare memory.
7846
810928a2
AS
78472011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7848
172418ad
AS
7849 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7850 format. (Bug#8806)
7851
43f862f7
AS
7852 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7853
810928a2
AS
7854 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7855 before statements.
7856
a059fe24
JD
78572011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7858
7859 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7860
7861 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7862
7863 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7864 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7865
989bf368
JB
78662011-06-05 Juanma Barranquero <lekktu@gmail.com>
7867
7868 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7869
4b80f674
CY
78702011-06-04 Chong Yidong <cyd@stupidchicken.com>
7871
7872 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7873 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7874 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7875 New error handlers.
4b80f674
CY
7876 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7877 Obey Vx_select_enable_clipboard_manager. Catch errors in
7878 x_clipboard_manager_save (Bug#8779).
7879 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7880 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7881
99a33b77 78822011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7883
7884 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7885
99a33b77 78862011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7887
7888 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7889 in the current matrix if keep_current_p is non-zero.
7890
8264569d
EZ
78912011-06-04 Eli Zaretskii <eliz@gnu.org>
7892
7893 * bidi.c (bidi_level_of_next_char): Fix last change.
7894
57f97249
EZ
78952011-06-03 Eli Zaretskii <eliz@gnu.org>
7896
fec2107c 7897 Support bidi reordering of text covered by display properties.
57f97249 7898
fec2107c
EZ
7899 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7900 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7901 (bidi_cache_search, bidi_cache_iterator_state)
7902 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7903 (bidi_level_of_next_char, bidi_move_to_visually_next):
7904 Support character positions inside a run of characters covered by a
fec2107c
EZ
7905 display string.
7906 (bidi_paragraph_init, bidi_resolve_explicit_1)
7907 (bidi_level_of_next_char): Call bidi_fetch_char and
7908 bidi_fetch_char_advance instead of FETCH_CHAR and
7909 FETCH_CHAR_ADVANCE.
7910 (bidi_init_it): Initialize new members.
7911 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7912 definitions.
7913 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7914 instead of using explicit *_CHAR codes.
d6d100dd
SM
7915 (bidi_resolve_explicit, bidi_resolve_weak):
7916 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7917 bidirectional text is supported only in multibyte buffers.
7918 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7919 it to initialize the frame_window_p member of struct bidi_it.
7920 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7921 (bidi_resolve_explicit, bidi_resolve_weak)
7922 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7923 bidi_it->nchars is non-positive.
7924 (bidi_level_of_next_char): Don't try to lookup the cache for the
7925 next/previous character if nothing is cached there yet, or if we
7926 were just reseat()'ed to a new position.
c40e2fb2 7927
0e14fe90
EZ
7928 * xdisp.c (set_cursor_from_row): Set start and stop points
7929 according to the row's direction when priming the loop that looks
7930 for the glyph on which to display cursor.
7931 (single_display_spec_intangible_p): Function deleted.
7932 (display_prop_intangible_p): Reimplement to call
7933 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7934 Accept 3 additional arguments needed by handle_display_spec.
7935 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7936 values: lists, `(when COND...)' forms, etc.
7937 (single_display_spec_string_p): Support property values that are
7938 lists with the argument STRING its top-level element.
7939 (display_prop_string_p): Fix the condition for processing a
7940 property that is a list to be consistent with handle_display_spec.
fec2107c 7941 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7942 last portion of handle_display_prop.
7943 (compute_display_string_pos): Accept additional argument
7944 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7945 value of a `display' property is a "replacing spec".
7946 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7947 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7948 the display property, but just return a value indicating whether
7949 the display property will replace the characters it covers.
7950 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7951 frame_window_p members of struct bidi_it.
d6d100dd
SM
7952 (compute_display_string_pos, compute_display_string_end):
7953 New functions.
fec2107c
EZ
7954 (push_it): Accept second argument POSITION, where pop_it should
7955 jump to continue iteration.
7956 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7957
fec2107c
EZ
7958 * keyboard.c (adjust_point_for_property): Adjust the call to
7959 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7960
7961 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7962 (bidi_init_it): Update prototypes.
7963 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7964 (compute_display_string_pos, compute_display_string_end):
7965 Declare prototypes.
fec2107c
EZ
7966 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7967 EMACS_INT.
fc6f18ce 7968
40087514 79692011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7970
57f53182
PE
7971 Malloc failure behavior now depends on size of allocation.
7972 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7973 * lisp.h: Change signatures accordingly.
7974 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7975 All callers changed. (Bug#8762)
7976
7977 * gnutls.c: Use Emacs's memory allocators.
7978 Without this change, the gnutls library would invoke malloc etc.
7979 directly, which causes problems on non-SYNC_INPUT hosts, and which
7980 runs afoul of improving memory_full behavior. (Bug#8761)
7981 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7982 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7983 xfree instead of the default malloc, realloc, free.
7984 (Fgnutls_boot): No need to check for memory allocation failure,
7985 since xmalloc does that for us.
7986
ac32cd99 7987 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7988 * category.c (hash_get_category_set):
7989 * ccl.c (ccl_driver):
7990 * charset.c (Fdefine_charset_internal):
7991 * charset.h (struct charset.hash_index):
7992 * composite.c (get_composition_id, gstring_lookup_cache)
7993 (composition_gstring_put_cache):
7994 * composite.h (struct composition.hash_index):
7995 * dispextern.h (struct image.hash):
7996 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7997 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7998 (hashfn_equal, hashfn_user_defined, make_hash_table)
7999 (maybe_resize_hash_table, hash_lookup, hash_put)
8000 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8001 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8002 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8003 * image.c (make_image, search_image_cache, lookup_image)
8004 (xpm_put_color_table_h):
8005 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8006 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8007 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8008 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8009 * alloc.c (allocate_vectorlike):
8010 Check for overflow in vector size calculations.
8011 * ccl.c (ccl_driver):
8012 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8013 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8014 need to be updated by these changes.
40087514
PE
8015 * fns.c (make_hash_table, maybe_resize_hash_table):
8016 Check for integer overflow with large hash tables.
0de4bb68
PE
8017 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8018 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8019 (SXHASH_REDUCE): New macro.
8020 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8021 Use it instead of discarding useful hash info with large hash values.
8022 (sxhash_float): New function.
8023 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8024 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8025 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8026 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8027 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8028 Adjust signatures to match updated version of code.
8029 (consing_since_gc): Now EMACS_INT, since a single hash table can
8030 use more than INT_MAX bytes.
8031
698d32e2
DN
80322011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8033
8034 Make it possible to build with GCC-4.6+ -O2 -flto.
8035
8036 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8037
fd6fa53f
SM
80382011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8039
8040 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8041 Call minibuffer-inactive-mode.
8042
864db017
JB
80432011-05-31 Juanma Barranquero <lekktu@gmail.com>
8044
8045 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8046 Update dependencies.
8047
2ad0baf4
DN
80482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8049
8050 * data.c (init_data): Remove code for UTS, this system is not
8051 supported anymore.
8052
4fcc2638
DN
80532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8054
8055 Don't force ./temacs to start in terminal mode.
8056
8057 * frame.c (make_initial_frame): Initialize faces in all cases, not
8058 only when CANNOT_DUMP is defined.
8059 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8060
c56e0fd5
DN
80612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8062
8063 * dispnew.c (add_window_display_history): Use const for the string
8064 pointer. Remove declaration, not needed.
8065
333d54da 80662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8067
55d4c1b2 8068 Use 'inline', not 'INLINE'.
333d54da 8069 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8070 * alloc.c, fontset.c (INLINE): Remove.
8071 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8072 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8073 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8074 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8075 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8076
738db178
DN
80772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8078
8079 Make it possible to run ./temacs.
8080
8081 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8082 syms_of_callproc does the same thing. Remove test for
8083 "initialized", do it in the caller.
8084 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8085
620c53a6
SM
80862011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8087
8088 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8089 (read_minibuf): Use get_minibuffer.
8090 (syms_of_minibuf): Use DEFSYM.
8091 (Qmetadata): New var.
8092 * data.c (Qbuffer): Don't make it static.
8093 (syms_of_data): Use DEFSYM.
8094
e003a292
PE
80952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8096
8097 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8098 (CCL_CODE_MIN): New macro.
8099
ed008a6d
PE
81002011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8101
3687c2ef
PE
8102 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8103
ed008a6d
PE
8104 * eval.c (Qdebug): Now static.
8105 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8106 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8107 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8108
d66c4c7c
CY
81092011-05-29 Chong Yidong <cyd@stupidchicken.com>
8110
8111 * image.c: Various fixes to ImageMagick code comments.
8112 (Fimagemagick_types): Doc fix.
8113
5fbc2025
PE
81142011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8115
0196f88a
PE
8116 Minor fixes prompted by GCC 4.6.0 warnings.
8117
8118 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8119
5fbc2025
PE
8120 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8121 (x_clipboard_manager_save_all): Move extern decl to ...
8122 * xterm.h: ... here, so that it can be checked for consistency.
8123
1dd3c2d9
CY
81242011-05-29 Chong Yidong <cyd@stupidchicken.com>
8125
8126 * xselect.c (x_clipboard_manager_save_frame)
8127 (x_clipboard_manager_save_all): New functions.
8128 (Fx_clipboard_manager_save): Lisp function deleted.
8129
8130 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8131 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8132
8133 * xterm.h: Update prototype.
8134
5ba6571d
WX
81352011-05-28 William Xu <william.xwl@gmail.com>
8136
8137 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8138 exiting (Bug#8239).
8139
3eaff834
JM
81402011-05-28 Jim Meyering <meyering@redhat.com>
8141
e1900994 8142 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8143 * fns.c (to_uchar): Define.
8144 (crypto_hash_function): Use it to convert some newly-signed
8145 variables to unsigned, to avoid sign-extension bugs. For example,
8146 without this change, (md5 "truc") would evaluate to
8147 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8148 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8149 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8150
0f6990a7
PE
81512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8152
8153 Integer overflow fixes.
c8a9ca5a 8154
08686060
PE
8155 * dbusbind.c: Serial number integer overflow fixes.
8156 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8157 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8158 to hold a serial number that is too large for a fixnum.
8159 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8160 Check for serial numbers out of range. Decode any serial number
59568bf0 8161 that was so large that it became a float. (Bug#8722)
08686060 8162
2d1fc3c7
PE
8163 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8164 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8165 Use XFASTINT rather than XUINT when numbers are nonnegative.
8166 (xd_append_arg, Fdbus_method_return_internal):
8167 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8168 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8169 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8170 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8171 (Bug#8722)
2d1fc3c7 8172
c8a9ca5a
PE
8173 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8174
519e1d69
PE
8175 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8176
6df6ae42 8177 ccl: Add integer overflow checks.
30569699
PE
8178 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8179 (IN_INT_RANGE): New macros.
8180 (ccl_driver): Use them to check for integer overflow when
8181 decoding a CCL program. Many of the new checks are whether XINT (x)
8182 fits in int; it doesn't always, on 64-bit hosts. The new version
8183 doesn't catch all possible integer overflows, but it's an
847044ea 8184 improvement. (Bug#8719)
30569699 8185
c11285dc
PE
8186 * alloc.c (make_event_array): Use XINT, not XUINT.
8187 There's no need for unsigned here.
8188
fdccd48e
PE
8189 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8190 This follows up to the 2011-05-06 change that substituted uintptr_t
8191 for EMACS_INT. This case wasn't caught back then.
8192
37910ab2
PE
8193 Rework Fformat to avoid integer overflow issues.
8194 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8195 now (part of C89). Include <verify.h>.
8196 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8197 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8198 (Fformat): Avoid the prepass trying to compute sizes; it was only
8199 approximate and thus did not catch overflow reliably. Instead, walk
8200 through the format just once, formatting and computing sizes as we go,
8201 checking for integer overflow at every step, and allocating a larger
8202 buffer as needed. Keep track separately whether the format is
8203 multibyte. Keep only the most-recently calculated precision, rather
8204 than them all. Record whether each argument has been converted to
8205 string. Use EMACS_INT, not int, for byte and char and arg counts.
8206 Support field widths and precisions larger than INT_MAX. Avoid
8207 sprintf's undefined behavior with conversion specifications such as %#d
8208 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8209 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8210 formatting out-of-range floating point numbers with int
9173deec 8211 formats. (Bug#8668)
37910ab2 8212
2e6578fb
PE
8213 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8214
0ae6bdee
PE
8215 * data.c: Avoid integer truncation in expressions involving floats.
8216 * data.c: Include <intprops.h>.
8217 (arith_driver): When there's an integer overflow in an expression
8218 involving floating point, convert the integers to floating point
8219 so that the resulting value does not suffer from catastrophic
8220 integer truncation. For example, on a 64-bit host (* 4
8221 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8222 Do not rely on undefined behavior after integer overflow.
8223
de883a70
PE
8224 merge count_size_as_multibyte, parse_str_to_multibyte
8225 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8226 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8227 Check for integer overflow.
8228 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8229 since it's now a duplicate of the other. This is more of
8230 a character than a buffer op, so better that it's in character.c.
8231 * fns.c, print.c: Adjust to above changes.
8232
2ff916cb
PE
82332011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8234
8235 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8236
f1b54466
PE
82372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8238
fb1ac845
PE
8239 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8240 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8241 (x_clipboard_manager_save): Now static.
8242 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8243
f1b54466
PE
8244 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8245 (crypto_hash_function): Now static.
8246 Fix pointer signedness problems. Avoid unnecessary initializations.
8247
a9f737ee
CY
82482011-05-27 Chong Yidong <cyd@stupidchicken.com>
8249
8250 * termhooks.h (Vselection_alist): Make it terminal-local.
8251
8252 * terminal.c (create_terminal): Initialize it.
8253
8254 * xselect.c: Support for clipboard managers.
8255 (Vselection_alist): Move to termhooks.h as terminal-local var.
8256 (LOCAL_SELECTION): New macro.
8257 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8258 (symbol_to_x_atom): Remove gratuitous arg.
8259 (x_handle_selection_request, lisp_data_to_selection_data)
8260 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8261 (x_own_selection, x_get_local_selection, x_convert_selection):
8262 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8263 (some_frame_on_display): Delete unused function.
8264 (Fx_own_selection_internal, Fx_get_selection_internal)
8265 (Fx_disown_selection_internal, Fx_selection_owner_p)
8266 (Fx_selection_exists_p): New optional frame arg.
8267 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8268 (x_handle_selection_clear): Don't treat other terminals with the
8269 same keyboard specially. Use the terminal-local Vselection_alist.
8270 (x_clear_frame_selections): Use Frun_hook_with_args.
8271
8272 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8273
8274 * xterm.h: Add support for those atoms.
8275
e067f0c1
CY
82762011-05-26 Chong Yidong <cyd@stupidchicken.com>
8277
8278 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8279 (converted_selections, conversion_fail_tag): New global variables.
8280 (x_selection_request_lisp_error): Free the above.
8281 (x_get_local_selection): Remove unnecessary code.
8282 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8283 of converted selections stored in converted_selections.
8284 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8285 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8286 (x_convert_selection): New function.
8287 (x_handle_selection_event): Simplify.
8288 (x_get_foreign_selection): Don't ignore incoming requests while
8289 waiting for an answer; this will fail when we implement
8290 SAVE_TARGETS, and seems unnecessary anyway.
8291 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8292 (Vx_sent_selection_functions): Doc fix.
8293
0f4aebc0
LL
82942011-05-26 Leo Liu <sdl.web@gmail.com>
8295
8296 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8297
e61124cd
YM
82982011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8299
8300 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8301
8302 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8303 for fringe update if it has periodic bitmap.
ac389d0c 8304 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8305 and fringe_bitmap_periodic_p.
8306
8307 * fringe.c (get_fringe_bitmap_data): New function.
8308 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8309 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8310 row. Mark glyph row for fringe update if periodicity changed.
8311
8312 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8313 for fringe update unless it has periodic bitmap.
8314
f16d9837
KH
83152011-05-25 Kenichi Handa <handa@m17n.org>
8316
8317 * xdisp.c (get_next_display_element): Set correct it->face_id for
8318 a static composition.
8319
e1b90ef6
LL
83202011-05-24 Leo Liu <sdl.web@gmail.com>
8321
8322 * deps.mk (fns.o):
8323 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8324
8325 * fns.c (crypto_hash_function, Fsha1): New function.
8326 (Fmd5): Use crypto_hash_function.
8327 (syms_of_fns): Add Ssha1.
8328
7400048f
PE
83292011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8330
8331 * gnutls.c: Remove unused macros.
8332 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8333 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8334 Remove macros that are defined and never used.
8335 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8336
abb71cf4
CY
83372011-05-22 Chong Yidong <cyd@stupidchicken.com>
8338
8339 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8340 (Fx_get_selection_internal): Minor cleanup.
8341 (Fx_own_selection_internal): Rename arguments for consistency with
8342 select.el.
8343
6307db39
PE
83442011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8345
8346 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8347
f3d4e0a4
CY
83482011-05-22 Chong Yidong <cyd@stupidchicken.com>
8349
8350 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8351
4d8ade89
YM
83522011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8353
8354 * dispnew.c (scrolling_window): Don't exclude the case that the
8355 last enabled row in the desired matrix touches the bottom boundary.
8356
32078c8d
GM
83572011-05-21 Glenn Morris <rgm@gnu.org>
8358
8359 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8360 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8361 and add some more files.
32078c8d 8362
7285dc67
EZ
83632011-05-20 Eli Zaretskii <eliz@gnu.org>
8364
8365 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8366 report_file_error introduced by the change from 2011-05-07.
8367
89d1bd22
PE
83682011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8369
8370 * systime.h (Time): Define only if emacs is defined.
8371 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8372 where the include path doesn't have X11/X.h by default. See
8373 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8374
cd394be1 83752011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8376
8377 * composite.c (find_automatic_composition): Fix previous change.
8378
b9704ad9
GM
83792011-05-20 Glenn Morris <rgm@gnu.org>
8380
8381 * lisp.mk: New file, split from Makefile.in.
8382 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8383 (shortlisp): Remove.
8384 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8385
4a720484
GM
83862011-05-19 Glenn Morris <rgm@gnu.org>
8387
8388 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8389 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8390 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8391 (lisp): Set the order to that of loadup.el.
8392 (shortlisp): Make it a copy of $lisp.
8393 (SOME_MACHINE_LISP): Remove.
8394 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8395 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8396
a28d4396
KH
83972011-05-18 Kenichi Handa <handa@m17n.org>
8398
8399 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8400 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8401 (find_automatic_composition): Mostly rewrite for efficiency.
8402
a2b1fa8e
JB
84032011-05-18 Juanma Barranquero <lekktu@gmail.com>
8404
8405 * makefile.w32-in: Update dependencies.
8406
8e1f5610
CS
84072011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8408
8409 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8410 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8411
7025ee00 84122011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8413
cdfa6eab
PE
8414 Fix some integer overflow issues, such as string length overflow.
8415
06d6db33
PE
8416 * insdel.c (count_size_as_multibyte): Check for string overflow.
8417
2b4560a8
PE
8418 * character.c (lisp_string_width): Check for string overflow.
8419 Use EMACS_INT, not int, for string indexes and lengths; in
8420 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8421 the resulting string length overflows an EMACS_INT; instead,
8422 report a string overflow if no precision given. When checking for
8423 precision exhaustion, use a check that cannot possibly have
8424 integer overflow. (Bug#8675)
8425 * character.h (lisp_string_width): Adjust to new signature.
8426
cb93f9be
PE
8427 * alloc.c (string_overflow): New function.
8428 (Fmake_string): Use it. This doesn't change behavior, but saves
8429 a few bytes and will simplify future changes.
8430 * character.c (string_escape_byte8): Likewise.
8431 * lisp.h (string_overflow): New decl.
8432
1a1f3366
PE
8433 Fixups, following up to the user-interface timestamp change.
8434 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8435 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8436 * msdos.c (mouse_get_pos): Likewise.
8437 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8438 * w32gui.h (Time): Define by including "systime.h" rather than by
8439 declaring it ourselves. (Bug#8664)
8440
d4e3e4d3
PE
8441 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8442 * image.c (clear_image_cache): Likewise.
8443
f6a24d19
PE
8444 * term.c (term_mouse_position): Don't assume time_t wraparound.
8445
08dc5ae6
PE
8446 Be more systematic about user-interface timestamps.
8447 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8448 and sometimes 'EMACS_UINT', to represent these timestamps.
8449 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8450 This makes the code easier to follow, and makes it easier to catch
8451 integer overflow bugs such as Bug#8664.
8452 * frame.c (Fmouse_position, Fmouse_pixel_position):
8453 Use Time, not unsigned long, for user-interface timestamps.
8454 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8455 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8456 * keyboard.h (last_event_timestamp): Likewise.
8457 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8458 * menu.h (xmenu_show): Likewise.
8459 * term.c (term_mouse_position): Likewise.
8460 * termhooks.h (struct input_event.timestamp): Likewise.
8461 (struct terminal.mouse_position_hook): Likewise.
8462 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8463 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8464 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8465 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8466 what it was before.
8467 * menu.h, termhooks.h: Include "systime.h", for Time.
8468
8e55734a
PE
8469 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8470 Don't assume that the difference between two unsigned long values
8471 can fit into an integer. At this point, we know button_down_time
8472 <= event->timestamp, so the difference must be nonnegative, so
8473 there's no need to cast the result if double-click-time is
8474 nonnegative, as it should be; check that it's nonnegative, just in
8475 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8476 apart (about 25 days). (Bug#8664)
8e55734a 8477
841f1b75 8478 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8479 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8480
3e26f69c
PE
8481 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8482 that always fit in int. Use a sentinel instead of a counter, to
8483 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8484 * frame.h (struct frame): Use int for menu_bar_items_used
8485 instead of EMACS_INT, since it always fits in int.
3e26f69c 8486
5cc152c0
PE
8487 * menu.c (grow_menu_items): Check for int overflow.
8488
d89eb65e
PE
8489 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8490
5235bd3e
PE
8491 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8492 Before, the code was not consistent. These values cannot exceed
8493 2**31 - 1 so there's no need to make them unsigned.
8494 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8495 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8496 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8497 as modifiers.
8498 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8499
bc827e23
PE
8500 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8501 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8502 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8503 presumably because the widths might not match.
8504
78eb494e
PE
8505 * window.c (size_window): Avoid needless test at loop start.
8506
04f2d78b
CB
85072011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8508
8509 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8510
d2fc7e3d 85112011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8512
8513 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8514
d2fc7e3d 85152011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8516
8517 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8518 `width' to `bar_area_x' and `bar_area_width', respectively.
8519 (x_scroll_run): Take account of fringe background extension.
8520
04f2d78b
CB
8521 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8522 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8523 `bar_area_width', respectively.
8524 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8525 background extension.
8526
79b70037
GM
85272011-05-10 Jim Meyering <meyering@redhat.com>
8528
8529 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8530
2f142cc5
JB
85312011-05-10 Juanma Barranquero <lekktu@gmail.com>
8532
8533 * image.c (Finit_image_library): Return t for built-in image types,
8534 like pbm and xbm. (Bug#8640)
8535
57679c86
AS
85362011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8537
8538 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8539
888c9e86
EZ
85402011-05-07 Eli Zaretskii <eliz@gnu.org>
8541
b0512a1d
EZ
8542 * w32console.c (Fset_screen_color): Doc fix.
8543 (Fget_screen_color): New function.
8544 (syms_of_ntterm): Defsubr it.
8545
7285dc67
EZ
8546 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8547 unlink the temporary file if Fcall_process didn't create it in the
8548 first place.
8549 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8550 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8551 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8552 cue to call_process_cleanup not to close that handle.
8553
4d3fcc8e
BK
85542011-05-07 Ben Key <bkey76@gmail.com>
8555
8556 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8557 one of two shell specific rules, either bootstrap-temacs-CMD or
8558 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8559 to the previous implementation of the bootstrap-temacs rule.
8560 The bootstrap-temacs-CMD rule is similar to the previous
8561 implementation of the bootstrap-temacs rule except that it
8562 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8563 variable.
8564
8565 These changes, along with some changes to nt/configure.bat,
8566 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8567 earlier fix to add support for --cflags and --ldflags options
8568 that include quotes so that it works whether make uses cmd or
8569 sh as the shell.
8570
b4289b64
MA
85712011-05-06 Michael Albinus <michael.albinus@gmx.de>
8572
8573 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8574 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8575 is a constant.
8576 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8577 a string. Handle both cases.
8578 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8579 (Fdbus_register_method): Use Qinvalid_function.
8580
af4c0e28
JB
85812011-05-06 Juanma Barranquero <lekktu@gmail.com>
8582
8583 * makefile.w32-in: Update dependencies.
8584 (LISP_H): Add inttypes.h and stdin.h.
8585 (PROCESS_H): Add unistd.h.
8586
c51453d9
EZ
85872011-05-06 Eli Zaretskii <eliz@gnu.org>
8588
8589 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8590 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8591
8ff0ac3c 85922011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8593
4c4b566b
PE
8594 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8595
aab2b9b5
PE
8596 * term.c (vfatal): Remove stray call to va_end.
8597 It's not needed and the C Standard doesn't allow it here anyway.
8598
c378da0b
PE
8599 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8600 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8601
288b08c7
PE
8602 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8603 bytes.
8604
e3601888
PE
8605 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8606
db6c0e74
PE
8607 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8608
dd5963ea
PE
8609 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8610
88c9450f
PE
8611 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8612
2f9442b8
PE
8613 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8614
c032b5f8
PE
8615 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8616 * charset.c (Fdefine_charset_internal): Don't initialize
8617 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8618 32-bit int (Bug#8600).
a108c10b
PE
8619
8620 * lread.c (read_integer): Be more consistent with string-to-number.
8621 Use string_to_number to do the actual conversion; this avoids
8622 rounding errors and fixes some other screwups. Without this fix,
8623 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8624 (digit_to_number): Move earlier, for benefit of read_integer.
8625 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8626 not a digit in any supported base. (Bug#8602)
a108c10b 8627
ad5f9eea
PE
8628 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8629
aec1708a
PE
8630 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8631 to match comment at start of function. This also removes a
8632 GCC warning about overflow in a 32+64-bit port.
8633
47be4ab5
PE
8634 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8635
371cac43
PE
8636 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8637 Reported by Stefan Monnier in
8638 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8639 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8640 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8641
d01a7826
PE
8642 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8643 (EMACS_UINTPTR): Likewise, with uintptr_t.
8644
7fd47d5c
PE
8645 * lisp.h: Prefer 64-bit EMACS_INT if available.
8646 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8647 on 32-bit hosts that have 64-bit int, so that they can access
8648 large files.
122b0c86
PE
8649 However, temporarily disable this change unless the temporary
8650 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8651
8727937b
PE
8652 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8653
8ac068ac
PE
8654 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8655 This removes an assumption that EMACS_INT and long are the same
8656 width as pointers. The assumption is true for Emacs porting targets
8657 now, but we want to make other targets possible.
8658 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8659 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8660 In the rest of the code, change types of integers that hold casted
8661 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8662 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8663 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8664 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8665 No need to cast type when ORing.
8666 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8667 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8668 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8669 assume EMACS_INT is the same width as char *.
8670 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8671 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8672 Remove no-longer-needed casts.
8673 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8674 (xg_tool_bar_help_callback, xg_make_tool_item):
8675 Use EMACS_INTPTR to hold an integer
8676 that will be cast to void *; this can avoid a GCC warning
8677 if EMACS_INT is not the same width as void *.
8678 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8679 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8680 (current_message_1, set_message_1):
8681 Use a local to convert to proper width without a cast.
8682 * xmenu.c (dialog_selection_callback): Likewise.
8683
ede49d71
PE
8684 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8685 Also, don't assume VALBITS / RAND_BITS is less than 5,
8686 and don't rely on undefined behavior when shifting a 1 left into
8687 the sign bit.
8688 * lisp.h (get_random): Change signature to match.
8689
2f30ecd0
PE
8690 * lread.c (hash_string): Use size_t, not int, for hash computation.
8691 Normally we prefer signed values; but hashing is special, because
8692 it's better to use unsigned division on hash table sizes so that
8693 the remainder is nonnegative. Also, size_t is the natural width
8694 for hashing into memory. The previous code used 'int', which doesn't
8695 retain enough info to hash well into very large tables.
8696 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8697
2a866e7b
PE
8698 * dbusbind.c: Don't possibly lose pointer info when converting.
8699 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8700 Use XPNTR rather than XHASH, so that the high-order bits of
8701 the pointer aren't lost when converting through void *.
8702
51639eac
PE
8703 * eval.c (Fautoload): Don't double-shift a pointer.
8704
92394119
PE
8705 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8706
dbdb9a7c
JB
87072011-05-06 Juanma Barranquero <lekktu@gmail.com>
8708
8709 * gnutls.c (DEF_GNUTLS_FN):
8710 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8711
db7a0b4f
AS
87122011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8713
8714 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8715 marker. (Bug#8610)
8716
cd394be1 87172011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8718
8719 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8720 New version that can reserve upto 2GB of heap space.
8721
f7ff1b0f 87222011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8723
8724 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8725
639c109b
TZ
87262011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8727
8728 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8729 `gnutls_certificate_set_x509_key_file'.
8730
d2127135
JB
87312011-05-05 Juanma Barranquero <lekktu@gmail.com>
8732
8733 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8734 Update dependencies.
8735
e968f4f3
JB
87362011-05-04 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8739 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8740 Remove unused parameter `fildes'.
8741 * process.c (read_process_output, send_process): Don't pass it.
8742
84d358f0
JB
87432011-05-04 Juanma Barranquero <lekktu@gmail.com>
8744
8745 Fix previous change: the library cache is defined in w32.c.
8746 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8747 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8748
0898ca10
JB
87492011-05-04 Juanma Barranquero <lekktu@gmail.com>
8750
8751 Implement dynamic loading of GnuTLS on Windows.
8752
8753 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8754 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8755 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8756 Declare.
8757
8758 * gnutls.c (Qgnutls_dll): Define.
8759 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8760 (gnutls_*): Declare function pointers.
8761 (init_gnutls_functions): New function to initialize function pointers.
8762 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8763 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8764 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8765 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8766 (emacs_gnutls_write, emacs_gnutls_read)
8767 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8768 (Fgnutls_available_p): New function.
8769 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8770 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8771 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8772
8773 * image.c: Include w32.h.
8774 (Vimage_type_cache): Delete.
8775 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8776 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8777 (w32_delayed_load): Move to w32.c.
8778
8779 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8780
8781 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8782 (w32_delayed_load): Move from image.c. When loading a library, record
8783 its filename in the :loaded-from property of the library id.
8784 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8785 Initialize and staticpro them.
8786 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8787
8788 * process.c: Include lisp.h before w32.h, not after.
8789 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8790 instead of gnutls_record_check_pending.
8791
8792 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8793
ff4de4aa
TZ
87942011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8795
8796 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8797 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8798 as passed in.
8799
abe95abb
JD
88002011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8801
8802 * xterm.c (x_set_frame_alpha): Do not set property on anything
8803 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8804
e16e55d4
JB
88052011-05-02 Juanma Barranquero <lekktu@gmail.com>
8806
8807 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8808
bafcf6a5
JB
88092011-05-02 Juanma Barranquero <lekktu@gmail.com>
8810
8811 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8812 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8813 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8814 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8815 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8816 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8817 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8818 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8819 (Qgnutls_bootprop_callbacks_verify): Make static.
8820
e7a6747f
AS
88212011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8822
19ed11ba
AS
8823 * callproc.c: Indentation fixup.
8824
e7a6747f 8825 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8826 (wait_for_termination, interruptible_wait_for_termination):
8827 Move after wait_for_termination_1.
e7a6747f 8828
1ef14cb4
LMI
88292011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8830
8831 * sysdep.c (interruptible_wait_for_termination): New function
8832 which is like wait_for_termination, but allows keyboard
8833 interruptions.
8834
8835 * callproc.c (Fcall_process): Add (:file "file") as an option for
8836 the STDOUT buffer.
8837 (Fcall_process_region): Ditto.
8838
330d880c
EZ
88392011-04-30 Eli Zaretskii <eliz@gnu.org>
8840
8db90b73
EZ
8841 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8842 rather than `XVECTOR (FOO)->size'.
8843
330d880c
EZ
8844 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8845 inttypes.h, as a gnulib replacement is used if it not available in
8846 system headers.
8847
15cbd324
EZ
88482011-04-21 Eli Zaretskii <eliz@gnu.org>
8849
8850 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8851 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8852 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8853
8854 * coding.c (coding_alloc_by_realloc): Error out if destination
8855 will grow beyond MOST_POSITIVE_FIXNUM.
8856 (decode_coding_emacs_mule): Abort if there isn't enough place in
8857 charbuf for the composition carryover bytes. Reserve an extra
8858 space for up to 2 characters produced in a loop.
8859 (decode_coding_iso_2022): Abort if there isn't enough place in
8860 charbuf for the composition carryover bytes.
8861
88622011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8863
ae940cca
EZ
8864 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8865 aborting when %lld or %lll format is passed.
8866 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8867 %llo or %llx format is passed. (Bug#8545)
8868
03ab8921
EZ
8869 * window.c (window_scroll_line_based): Use a marker instead of
8870 simple variables to record original value of point. (Bug#7952)
8871
afda1437
EZ
8872 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8873 produced by %s or %c overflows available buffer space. (Bug#8545)
8874
f76dee0c
PE
88752011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8876
8877 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8878 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8879
fdc5744d
JB
88802011-04-28 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8883
638f053a
JB
88842011-04-28 Juanma Barranquero <lekktu@gmail.com>
8885
8886 * keyboard.c (Qdelayed_warnings_hook): Define.
8887 (command_loop_1): Run `delayed-warnings-hook'
8888 if Vdelayed_warnings_list is non-nil.
8889 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8890 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8891
d178f871
EZ
88922011-04-28 Eli Zaretskii <eliz@gnu.org>
8893
8894 * doprnt.c (doprnt): Don't return value smaller than the buffer
8895 size if the message was truncated. (Bug#8545).
8896
b124fd93
JB
88972011-04-28 Juanma Barranquero <lekktu@gmail.com>
8898
8899 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8900 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8901
e810457d
PE
89022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8903
8904 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8905
ea51cceb
JB
89062011-04-27 Juanma Barranquero <lekktu@gmail.com>
8907
8908 * makefile.w32-in: Update dependencies.
8909
94dcfacf
EZ
89102011-04-27 Eli Zaretskii <eliz@gnu.org>
8911
8912 Improve `doprnt' and its usage. (Bug#8545)
8913 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8914 `format_end'. Remove support for %l as a conversion specifier.
8915 Don't use xrealloc. Improve diagnostics when the %l size modifier
8916 is used. Update the commentary.
8917
8918 * eval.c (verror): Simplify calculation of size_t.
8919
8920 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8921 messages.
8922
f61f41d7
PE
89232011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8924
8925 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8926 change.
8927
96fb4434
PE
89282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8929
8930 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8931 This makes this file independent of the recent pseudovector change.
8932
671875da 89332011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8934
69e9b5a3
PE
8935 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8936
b5f869a7 8937 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8938 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8939 Remove unused local.
c8926152 8940 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8941
841a1577 8942 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8943 GCC 4.6.0 optimizes based on type-based alias analysis.
8944 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8945 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8946 != &v->size, and therefore "v->size = 1; b->size = 2; return
8947 v->size;" must therefore return 1. This assumption is incorrect
8948 for Emacs, since it type-puns struct Lisp_Vector * with many other
8949 types. To fix this problem, this patch adds a new type struct
f904488f 8950 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8951 and pseudovectors, and helps optimizing compilers not get fooled
8952 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8953 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8954 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8955 the size member.
eab3844f
PE
8956 (XSETPVECTYPE): Rewrite in terms of new macro.
8957 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8958 This is a bit clearer, and further avoids the possibility of
8959 undesirable aliasing.
8960 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8961 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8962 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8963 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8964 (ASIZE): Now uses header.size rather than size.
8965 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8966 to avoid the hassle of writing XVECTOR (foo)->header.size.
8967 (struct vectorlike_header): New type.
eab3844f
PE
8968 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8969 object, to help avoid aliasing.
8970 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8971 (SUBRP): Likewise, since Lisp_Subr is a special case.
8972 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8973 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8974 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8975 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8976 changed to be "header.size" and "header.next".
8977 * buffer.h (struct buffer): Likewise.
8978 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8979 * frame.h (struct frame): Likewise.
8980 * process.h (struct Lisp_Process): Likewise.
8981 * termhooks.h (struct terminal): Likewise.
8982 * window.c (struct save_window_data, struct saved_window): Likewise.
8983 * window.h (struct window): Likewise.
8984 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8985 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8986 * buffer.c (init_buffer_once): Likewise.
8987 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8988 special case.
8989 * process.c (Fformat_network_address): Use local var for size,
8990 for brevity.
8991
0df1eac5
PE
8992 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8993
847ab9d1 8994 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8995 * data.c (atof): Remove decl; no longer used or needed.
8996 (digit_to_number): Move to lread.c.
8997 (Fstring_to_number): Use new string_to_number function, to be
8998 consistent with how the Lisp reader treats infinities and NaNs.
8999 Do not assume that floating-point numbers represent EMACS_INT
9000 without losing information; this is not true on most 64-bit hosts.
9001 Avoid double-rounding errors, by insisting on integers when
9002 parsing non-base-10 numbers, as the documentation specifies.
9003 * lisp.h (string_to_number): New decl, replacing ...
9004 (isfloat_string): Remove.
bc0a5c13 9005 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9006 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9007 appears to have been a coding error. Similarly, do not accept
9008 strings like +-1e0 as floating point numbers. Do not report
9009 overflow for integer overflows unless the base is not 10 which
9010 means we have no simple and reliable way to continue.
9011 Break out the floating-point parsing into a new
9012 function string_to_number, so that Fstring_to_number parses
9013 floating point numbers consistently with the Lisp reader.
04f2d78b 9014 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9015 (E_CHAR, EXP_INT): Remove, replacing with ...
9016 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9017 (string_to_number): New function, replacing isfloat_string.
9018 This function checks for valid syntax and produces the resulting
9019 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9020 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9021 so that overflow for non-base-10 numbers is reported only when
9022 there's no portable and simple way to convert to floating point.
452f4150 9023
67769ffc
PE
9024 * textprop.c (set_text_properties_1): Rewrite for clarity,
9025 and to avoid GCC warning about integer overflow.
9026
c20db43f
PE
9027 * intervals.h (struct interval): Use EMACS_INT for members
9028 where EMACS_UINT might cause problems. See
9029 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9030 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9031 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9032 All uses changed.
37aa2f85
PE
9033 (offset_intervals): Tell GCC not to worry about length overflow
9034 when negating a negative length.
c20db43f 9035
2538aa2f
PE
9036 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9037 (overrun_check_free): Likewise.
9038
f2d3008d
PE
9039 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9040 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9041 word size.
9042
ec8df744
PE
9043 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9044 (gnutls_make_error): Rename local to avoid shadowing.
9045 (gnutls_emacs_global_deinit): ifdef out; not used.
9046 (Fgnutls_boot): Use const for pointer to readonly storage.
9047 Comment out unused local. Fix pointer signedness problems.
9048
640ee02d
PE
9049 * lread.c (openp): Don't stuff size_t into an 'int'.
9050 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9051 about possible signed overflow.
9052
6048fb2a
PE
9053 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9054 (GDK_KEY_g): Don't define if already defined.
9055 (xg_prepare_tooltip): Avoid pointer signedness problem.
9056 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9057
fa3c87e1
PE
9058 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9059 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9060
2172544b
PE
9061 * xfns.c (Fx_window_property): Simplify a bit,
9062 to make a bit faster and to avoid GCC 4.6.0 warning.
9063 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9064
9b821a21
PE
9065 * fns.c (internal_equal): Don't assume size_t fits in int.
9066
3c616cfa
PE
9067 * alloc.c (compact_small_strings): Tighten assertion a little.
9068
c2982e87
PE
9069 Replace pEd with more-general pI, and fix some printf arg casts.
9070 * lisp.h (pI): New macro, generalizing old pEd macro to other
9071 conversion specifiers. For example, use "...%"pI"d..." rather
9072 than "...%"pEd"...".
9073 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9074 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9075 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9076 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9077 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9078 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9079 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9080 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9081 64-bit hosts.
9082 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9083 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9084 * print.c (safe_debug_print, print_object): Likewise.
9085 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9086 to int.
6f04d126
PE
9087 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9088 avoiding the 0 flag, which is not portable.
c2982e87
PE
9089 * process.c (Fmake_network_process): Use pI to avoid cast.
9090 * region-cache.c (pp_cache): Likewise.
9091 * xdisp.c (decode_mode_spec): Likewise.
9092 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9093 behavior on 64-bit hosts with printf arg.
6f04d126 9094 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9095 (x_stop_queuing_selection_requests): Likewise.
9096 (x_get_window_property): Don't truncate byte count to an 'int'
9097 when tracing.
0b432f21 9098
5e073ec7
PE
9099 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9100 here, since it parses constructs like leading '-' and spaces,
9101 which are not wanted; and it overflows with large numbers.
9102 Instead, simply match F[0-9]+, which is what is wanted anyway.
9103
36372bf9
PE
9104 * alloc.c: Remove unportable assumptions about struct layout.
9105 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9106 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9107 (allocate_vectorlike, make_pure_vector): Use the new macros,
9108 plus offsetof, to remove unportable assumptions about struct layout.
9109 These assumptions hold on all porting targets that I know of, but
9110 they are not guaranteed, they're easy to remove, and removing them
9111 makes further changes easier.
9112
0b432f21
PE
9113 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9114 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9115 (string_overrun_cookie): Now const. Use initializers that
9116 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9117 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9118 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9119 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9120 multiple of sizeof (EMACS_INT); it need not be, if
9121 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9122 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9123
895009e1
JB
91242011-04-26 Juanma Barranquero <lekktu@gmail.com>
9125
9126 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9127
6a7a1b0b
TZ
91282011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9129
9130 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9131 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9132 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9133
841a1577 91342011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9135
9136 * lisp.h (Qdebug): List symbol.
895009e1 9137 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9138 * keyboard.c (debug-on-event): New variable.
9139 (handle_user_signal): Break into debugger when debug-on-event
9140 matches the current signal symbol.
9141
f2d3ba6f
DN
91422011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9143
9144 * alloc.c (check_sblock, check_string_bytes)
9145 (check_string_free_list): Convert to standard C.
9146
42ce4c63
TZ
91472011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9148
9149 * w32.c (emacs_gnutls_push): Fix typo.
9150
825cd63c
EZ
91512011-04-25 Eli Zaretskii <eliz@gnu.org>
9152
fb11d64d
EZ
9153 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9154 "cast to pointer from integer of different size".
9155
825cd63c
EZ
9156 Improve doprnt and its use in verror. (Bug#8545)
9157 * doprnt.c (doprnt): Document the set of format control sequences
9158 supported by the function. Use SAFE_ALLOCA instead of always
9159 using `alloca'.
9160
9161 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9162 is one byte too soon. Don't use xrealloc; instead xfree and
9163 xmalloc anew.
9164
e061a11b
TZ
91652011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9166
9167 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9168 callbacks stage.
9169
9170 * gnutls.c: Renamed global_initialized to
9171 gnutls_global_initialized. Added internals for the
9172 :verify-hostname-error, :verify-error, and :verify-flags
9173 parameters of `gnutls-boot' and documented those parameters in the
9174 docstring. Start callback support.
9173deec
JB
9175 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9176 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9177 on error. Return error code.
e061a11b
TZ
9178 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9179 (emacs_gnutls_read): Likewise.
9180 (Fgnutls_boot): Return handshake error code.
9181 (emacs_gnutls_handle_error): New function.
9182 (wsaerror_to_errno): Likewise.
9183
9184 * w32.h (emacs_gnutls_pull): Add prototype.
9185 (emacs_gnutls_push): Likewise.
9186
9187 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9188 (emacs_gnutls_push): Likewise.
9189
91902011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9191
9192 * process.c (wait_reading_process_output): Check if GnuTLS
9193 buffered some data internally if no FDs are set for TLS
9194 connections.
9195
9196 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9197 (LIBS): Link to USER_LIBS.
9198 ($(BLD)/gnutls.$(0)): New target.
9199
fa6996bc
EZ
92002011-04-24 Eli Zaretskii <eliz@gnu.org>
9201
eb35682e
EZ
9202 * xdisp.c (handle_single_display_spec): Rename the
9203 display_replaced_before_p argument into display_replaced_p, to
9204 make it consistent with the commentary. Fix typos in the
9205 commentary.
9206
e2ad650c
EZ
9207 * textprop.c (syms_of_textprop): Remove dead code.
9208 (copy_text_properties): Delete obsolete commentary about an
9209 interface that was deleted long ago. Fix typos in the description
9210 of arguments.
9211
1b2de274
EZ
9212 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9213 to changes in oldXMenu/XMenu.h from 2011-04-16.
9214 <menu_help_message, prev_menu_help_message>: Constify.
9215 (IT_menu_make_room): menu->help_text is now `const char **';
9216 adjust.
9217
9218 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9219 to changes in oldXMenu/XMenu.h from 2011-04-16.
9220 (struct XMenu): Declare `help_text' `const char **'.
9221
9222 * xfaces.c <Qunspecified>: Make extern again.
9223
9224 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9225 required by POSIX.
1b2de274 9226
762b15be
EZ
9227 * doc.c (get_doc_string): Improve the format passed to `error'.
9228
9229 * doprnt.c (doprnt): Improve commentary.
9230
9231 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9232
9233 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9234 them with etags.
9235
f1052e5d
EZ
9236 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9237 changes in globals.h immediately force recompilation.
762b15be
EZ
9238 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9239 $(CURDIR)/s/ms-w32.h.
9240 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9241
fa6996bc
EZ
9242 * character.c (Fchar_direction): Function deleted.
9243 (syms_of_character): Don't defsubr it.
9244 <char-direction-table>: Deleted.
9245
e6c3da20
EZ
92462011-04-23 Eli Zaretskii <eliz@gnu.org>
9247
9248 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9249 * doprnt.c: Include limits.h.
9250 (SIZE_MAX): New macro.
04f2d78b
CB
9251 (doprnt): Return a size_t value. 2nd arg is now size_t.
9252 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9253 Improve overflow protection. Support `l' modifier for integer
9254 conversions. Support %l conversion. Don't assume an EMACS_INT
9255 argument for integer conversions and for %c.
9256
9257 * lisp.h (doprnt): Restore prototype.
9258
9259 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9260 $(SRC)/character.h.
9261
9262 * Makefile.in (base_obj): Add back doprnt.o.
9263
9264 * deps.mk (doprnt.o): Add back prerequisites.
9265 (callint.o): Depend on character.h.
9266
9267 * eval.c (internal_lisp_condition_case): Include the handler
9268 representation in the error message.
9269 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9270 when breaking from the loop.
9271
9272 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9273
9274 * callint.c (Fcall_interactively): When displaying error message
9275 about invalid control letter, pass the character's codepoint, not
9276 a pointer to its multibyte form. Improve display of the character
9277 in octal and display also its hex code.
9278
9279 * character.c (char_string): Use %x to display the (unsigned)
9280 codepoint of an invalid character, to avoid displaying a bogus
9281 negative value.
9282
9283 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9284 `error', not SYMBOL_NAME itself.
9285
9286 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9287 character arguments to `error'.
9288
9289 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9290 to `error' in error message about FINAL_CHAR argument. Make sure
9291 FINAL_CHAR is a character, and use %c when it is passed as
9292 argument to `error'.
9293
4ffd0d6b 92942011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9295
9296 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9297
9298 * w32.c: Include <time.h>.
9299 (sys_localtime): New function.
9300
4ffd0d6b 93012011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9302
9303 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9304
4ffd0d6b 9305 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9306
4ffd0d6b 93072011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9308
4ffd0d6b
GM
9309 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9310 zombies (Bug#8467).
aac0c6e3 9311
04c56954
EZ
93122011-04-19 Eli Zaretskii <eliz@gnu.org>
9313
9314 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9315 gl_state.e_property when gl_state.object is Qt.
9316
9317 * insdel.c (make_gap_larger): Remove limitation of buffer size
9318 to <= INT_MAX.
9319
16a43933
CY
93202011-04-18 Chong Yidong <cyd@stupidchicken.com>
9321
9322 * xdisp.c (lookup_glyphless_char_display)
9323 (produce_glyphless_glyph): Handle cons cell entry in
9324 glyphless-char-display.
9325 (Vglyphless_char_display): Document it.
9326
9327 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9328 glyphless-char-display.
9329
4581706e
CY
93302011-04-17 Chong Yidong <cyd@stupidchicken.com>
9331
9332 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9333
9334 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9335
9336 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9337 definition for no-X builds.
9338
4887c6e2 93392011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9340
fd35b6f9
PE
9341 Static checks with GCC 4.6.0 and non-default toolkits.
9342
5c1ccb01
PE
9343 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9344
006c5daa
PE
9345 * process.c (keyboard_bit_set): Define only if SIGIO.
9346 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9347 (send_process): Repair possible setjmp clobbering.
9348
efc736d3
PE
9349 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9350
4e2fe2e6
PE
9351 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9352
f97334a2
PE
9353 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9354
4e75f29d
PE
9355 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9356 Define only if needed.
9357
90efadd1
PE
9358 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9359 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9360 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9361
3c647824
PE
9362 * dispextern.h (struct redisplay_interface): Rename param
9363 to avoid shadowing.
e264f262 9364 * termhooks.h (struct terminal): Likewise.
761383f4 9365 * xterm.c (xembed_send_message): Likewise.
3c647824 9366
b58c5c4a
PE
9367 * insdel.c (make_gap_smaller): Define only if
9368 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9369
cad59032
PE
9370 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9371 it.
9372
c339dc2e
PE
9373 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9374 so that we aren't warned about unused symbols.
9375
91a3e27b
PE
9376 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9377
399c71d3 9378 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9379
8ffc96f5
PE
9380 * xfns.c (x_real_positions): Mark locals as initialized.
9381
eef9bc79
PE
9382 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9383
098db9dd
PE
9384 * xterm.c: Fix problems found by static analysis with other toolkits.
9385 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9386 (x_dispatch_event): Declare static if USE_GTK, and
9387 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9388 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9389 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9390 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9391 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9392
eb18f6cc
PE
9393 * xmenu.c (menu_help_callback): Pointer type fixes.
9394 Use const pointers when pointing at readonly data. Avoid pointer
9395 signedness clashes.
9396 (FALSE): Remove unused macro.
9397 (update_frame_menubar): Remove unused decl.
9398
1fe72bf8
PE
9399 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9400
60d9e1db
PE
9401 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9402 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9403 (single_menu_item): Rename local to avoid shadowing.
9404
39261c26
PE
9405 * keyboard.c (make_lispy_event): Remove unused local var.
9406
018c5e19
PE
9407 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9408 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9409
63d2b86e
PE
9410 * bitmaps: Change bitmaps from unsigned char back to the X11
9411 compatible char. Avoid the old compiler warnings about
9412 out-of-range initializers by using, for example, '\xab' rather
9413 than 0xab.
9414
aefd87e1
PE
9415 * xgselect.c (xgselect_initialize): Check vs interface
9416 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9417
bf501fb9
PE
9418 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9419
e9829fdf
PE
9420 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9421 to read-only memory.
9422
1086c095
PE
9423 * fns.c (vector): Remove; this old hack is no longer needed.
9424
2baccd04 9425 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9426 Remove unused var.
dde42981 9427 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9428
72391843 9429 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9430
436c16df 9431 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9432 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9433 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9434
92bb796d 9435 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9436 (x_term_init): Remove local to avoid shadowing.
92bb796d 9437
764430a3 9438 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9439
9440 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9441 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9442
d1dfb56c
EZ
94432011-04-16 Eli Zaretskii <eliz@gnu.org>
9444
c4354cb4
EZ
9445 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9446
d1dfb56c
EZ
9447 Fix regex.c, syntax.c and friends for buffers > 2GB.
9448 * syntax.h (struct gl_state_s): Declare character position members
9449 EMACS_INT.
9450
9451 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9452
04f2d78b
CB
9453 * textprop.c (verify_interval_modification, interval_of):
9454 Declare arguments EMACS_INT.
d1dfb56c
EZ
9455
9456 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9457 EMACS_INT.
9458
9459 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9460
9461 * indent.c (Fvertical_motion): Local variable it_start is now
9462 EMACS_INT.
9463
9464 * regex.c (re_match, re_match_2, re_match_2_internal)
9465 (bcmp_translate, regcomp, regexec, print_double_string)
9466 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9467 (re_compile_pattern, re_exec): Declare arguments and local
9468 variables `size_t' and `ssize_t' and return values `regoff_t', as
9469 appropriate.
9470 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9471 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9472 <compile_stack_type>: `size' and `avail' are now `size_t'.
9473
9474 * regex.h <regoff_t>: Use ssize_t, not int.
9475 (re_search, re_search_2, re_match, re_match_2): Arguments that
9476 specify buffer/string position and length are now ssize_t and
9477 size_t. Return type is regoff_t.
9478
613052cd
BK
94792011-04-16 Ben Key <bkey76@gmail.com>
9480
9481 * nsfont.m: Fixed bugs in ns_get_family and
9482 ns_descriptor_to_entity that were caused by using free to
9483 deallocate memory blocks that were allocated by xmalloc (via
9484 xstrdup). This caused Emacs to crash when compiled with
9485 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9486 --enable-checking=xmallocoverrun). xfree is now used to
9487 deallocate these memory blocks.
9488
4170f62f 94892011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9490
71b41406
PE
9491 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9492
9587a89d
PE
9493 emacs_write: Accept and return EMACS_INT for sizes.
9494 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9495 et seq.
9496 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9497 Accept and return EMACS_INT.
9498 (emacs_gnutls_write): Return the number of bytes written on
9499 partial writes.
9500 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9501 (emacs_read, emacs_write): Remove check for negative size, as the
9502 Emacs source code has been audited now.
9587a89d
PE
9503 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9504 (emacs_read, emacs_write): Use it.
273a5f82
PE
9505 * process.c (send_process): Adjust to the new signatures of
9506 emacs_write and emacs_gnutls_write. Do not attempt to store
9507 a byte offset into an 'int'; it might overflow.
9587a89d 9508 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9509
3e047f51
PE
9510 * sound.c: Don't assume sizes fit in 'int'.
9511 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9512 Return EMACS_INT, not int.
3e047f51 9513 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9514 Accept EMACS_INT, not int.
9515 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9516 record read return values.
9517
cc39a9db
BK
95182011-04-15 Ben Key <bkey76@gmail.com>
9519
c9d0ec6d
JB
9520 * keyboard.c (Qundefined): Don't declare static since it is used
9521 in nsfns.m.
9522 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9523 static since they are used in nsfont.m.
cc39a9db 9524
6c60eb9f
SM
95252011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9526
9527 * process.c (Qprocessp): Don't declare static.
9528 * lisp.h (Qprocessp): Declare again.
9529
7990b61a
JB
95302011-04-15 Juanma Barranquero <lekktu@gmail.com>
9531
9532 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9533
5d4cb038
PE
95342011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9535
8bd7b830 9536 Improve C-level modularity by making more things 'static'.
cd64ea1d 9537
e3b27b31
PE
9538 Don't publish debugger-only interfaces to other modules.
9539 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9540 (verify_bytepos, count_markers): Move decls to the only modules
9541 that need them.
9542 * region-cache.h (pp_cache): Likewise.
9543 * window.h (check_all_windows): Likewise.
9544 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9545
5d4cb038
PE
9546 * sysdep.c (croak): Now static, if
9547 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9548 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9549
9550 * alloc.c (refill_memory_reserve): Now static if
9551 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9552 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9553
e87b6180
PE
9554 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9555 Define only if USE_LUCID.
9556
ac64929e
PE
9557 * xrdb.c (x_customization_string, x_rm_string): Now static.
9558
6f37259d
PE
9559 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9560 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9561
1683e3ab
PE
9562 * xdisp.c (draw_row_with_mouse_face): Now static.
9563 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9564
de9c2632
PE
9565 * window.h (check_all_windows): Mark externally visible.
9566
2b96acb7
PE
9567 * window.c (window_deletion_count): Now static.
9568
9569 * undo.c: Make symbols static if they're not exported.
9570 (last_undo_buffer, last_boundary_position, pending_boundary):
9571 Now static.
9572
50436f33
PE
9573 * textprop.c (interval_insert_behind_hooks): Now static.
9574 (interval_insert_in_front_hooks): Likewise.
9575
64520e5c
PE
9576 * term.c: Make symbols static if they're not exported.
9577 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9578 (max_frame_lines, tty_set_terminal_modes):
9579 (tty_reset_terminal_modes, tty_turn_off_highlight):
9580 (get_tty_terminal): Now static.
9581 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9582 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9583 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9584 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9585 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9586
1fa53021
PE
9587 * sysdep.c: Make symbols static if they're not exported.
9588 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9589 Now static.
9590 (sigprocmask_set, full_mask): Remove; unused.
9591 (wait_debugging): Mark as visible.
9592 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9593 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9594
d4b43b22
PE
9595 * syntax.c (syntax_temp): Define only if !__GNUC__.
9596
b7c513d0
PE
9597 * sound.c (current_sound_device, current_sound): Now static.
9598
989b29ad
PE
9599 * search.c (searchbufs, searchbuf_head): Now static.
9600
13a55a78
PE
9601 * scroll.c (scroll_cost): Remove; unused.
9602 * dispextern.h (scroll_cost): Remove decl.
9603
de68a1fc
PE
9604 * region-cache.h (pp_cache): Mark as externally visible.
9605
40ccffa6
PE
9606 * process.c: Make symbols static if they're not exported.
9607 (process_tick, update_tick, create_process, chan_process):
9608 (Vprocess_alist, proc_buffered_char, datagram_access):
9609 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9610 (deactivate_process): Mark defn as static, as well as decl.
9611 * lisp.h (create_process): Remove decl.
9612 * process.h (chan_process, Vprocess_alist): Remove decls.
9613
ad64fc97
PE
9614 * print.c: Make symbols static if they're not exported.
9615 (print_depth, new_backquote_output, being_printed, print_buffer):
9616 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9617 (print_interval, print_number_index, initial_stderr_stream):
9618 Now static.
9619 * lisp.h (Fprinc): Remove decl.
9620 (debug_output_compilation_hack): Mark as externally visible.
9621
adddb265
PE
9622 * sysdep.c (croak): Move decl from here to syssignal.h.
9623 * syssignal.h (croak): Put it here, so the API can be checked when
9624 'croak' is called from dissociate_if_controlling_tty.
9625
1717ede2
PE
9626 * minibuf.c: Make symbols static if they're not exported.
9627 (minibuf_save_list, choose_minibuf_frame): Now static.
9628 * lisp.h (choose_minibuf_frame): Remove decl.
9629
fa5fb2bc
PE
9630 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9631
1e3890d1
PE
9632 * lread.c: Make symbols static if they're not exported.
9633 (read_objects, initial_obarray, oblookup_last_bucket_number):
9634 Now static.
9635 (make_symbol): Remove; unused.
9636 * lisp.h (initial_obarray, make_symbol): Remove decls.
9637
8a1414fa
PE
9638 * keyboard.c: Make symbols static if they're not exported.
9639 (single_kboard, recent_keys_index, total_keys, recent_keys):
9640 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9641 (this_single_command_key_start, echoing, last_auto_save):
9642 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9643 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9644 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9645 (Vlispy_mouse_stem, double_click_count):
9646 Now static.
9647 (force_auto_save_soon): Define only if SIGDANGER.
9648 (ignore_mouse_drag_p): Now static if
9649 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9650 (print_help): Remove; unused.
9651 (stop_character, last_timer_event): Mark as externally visible.
9652 * keyboard.h (ignore_mouse_drag_p): Declare only if
9653 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9654 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9655 * lisp.h (echoing): Remove decl.
9656 (force_auto_save_soon): Declare only if SIGDANGER.
9657 * xdisp.c (redisplay_window): Simplify code, to make it more
9658 obvious that ignore_mouse_drag_p is not accessed if !defined
9659 USE_GTK && !defined HAVE_NS.
9660
93ea6e8f
PE
9661 * intervals.c: Make symbols static if they're not exported.
9662 (merge_properties_sticky, merge_interval_right, delete_interval):
9663 Now static.
9664 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9665
77382fcc
PE
9666 * insdel.c: Make symbols static if they're not exported.
9667 However, leave prepare_to_modify_buffer alone. It's never
9668 called from outside this function, but that appears to be a bug.
9669 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9670 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9671 (adjust_after_replace_noundo): Remove; unused.
9672 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9673 (signal_before_change): Remove decls.
77382fcc 9674
9306c32e
PE
9675 * indent.c (val_compute_motion, val_vmotion): Now static.
9676
cd44d2eb
PE
9677 * image.c: Make symbols static if they're not exported.
9678 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9679 if USE_GTK.
9680 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9681 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9682
ad9a7a06
PE
9683 * fringe.c (standard_bitmaps): Now static.
9684 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9685
81626931
PE
9686 * frame.c: Make symbols static if they're not exported.
9687 (x_report_frame_params, make_terminal_frame): Now static.
9688 (get_frame_param): Now static, unless HAVE_NS.
9689 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9690 (x_get_resource_string): Remove; not used.
9691 * frame.h (make_terminal_frame, x_report_frame_params):
9692 (x_get_resource_string); Remove decls.
9693 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9694 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9695
239f9db9
PE
9696 * font.c, fontset.c: Make symbols static if they're not exported.
9697 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9698 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9699 * font.c (font_close_object): Now static.
9700 * font.h (font_close_object): Remove.
9701 * fontset.c (FONTSET_OBJLIST): Remove.
9702 (free_realized_fontset) #if-0 the body, which does nothing.
9703 (face_suitable_for_char_p): #if-0, as it's never called.
9704 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9705 * xfaces.c (face_at_string_position):
9706 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9707 since 0 is always ASCII.
9708
dfcf3579
PE
9709 * fns.c (weak_hash_tables): Now static.
9710
5045092b
PE
9711 * fileio.c: Make symbols static if they're not exported.
9712 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9713 (Vwrite_region_annotation_buffers): Now static.
9714
57a96f5c
PE
9715 * eval.c: Make symbols static if they're not exported.
9716 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9717 * lisp.h (backtrace_list): Remove decl.
9718
35f08c38
PE
9719 * emacs.c: Make symbols static if they're not exported.
9720 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9721 (fatal_error_code, fatal_error_signal_hook, standard_args):
9722 Now static.
9723 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9724 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9725 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9726 * lisp.h (fatal_error_signal_hook): Remove decl.
9727 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9728
f44bd759
PE
9729 * editfns.c: Move a (normally-unused) function to its only use.
9730 * editfns.c, lisp.h (get_operating_system_release): Remove.
9731 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9732 worth the hassle of breaking this out.
9733
b532497d
PE
9734 * xterm.c: Make symbols static if they're not exported.
9735 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9736 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9737 (x_destroy_window, x_delete_display):
9738 Now static.
9739 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9740 (x_mouse_leave): Remove; unused.
9741 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9742 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9743 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9744 Remove decls.
9745 (x_mouse_leave): Declare only if WINDOWSNT.
9746 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9747 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9748 USE_X_TOOLKIT.
9749
1675728f
PE
9750 * ftxfont.c: Make symbols static if they're not exported.
9751 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9752 HAVE_FREETYPE.
9753 * font.h (ftxfont_driver): Likewise.
9754
e4cebfca
PE
9755 * xfns.c: Make symbols static if they're not exported.
9756 (x_last_font_name, x_display_info_for_name):
9757 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9758 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9759 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9760 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9761 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9762 (last_show_tip_args): Now static.
9763 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9764 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9765 (x_screen_planes): Remove; unused.
9766 * dispextern.h (x_screen_planes): Remove decl.
9767
5bf46f05
PE
9768 * dispnew.c: Make symbols static if they're not exported.
9769 * dispextern.h (redraw_garbaged_frames, scrolling):
9770 (increment_row_positions): Remove.
9771 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9772 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9773 Now static.
9774 (redraw_garbaged_frames): Remove; unused.
9775
435f4c28
PE
9776 * xfaces.c: Make symbols static if they're not exported.
9777 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9778 Remove decls.
9779 * xterm.h (defined_color): Remove decls.
9780 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9781 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9782 (menu_face_changed_default, defined_color, free_realized_face):
9783 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9784 (ascii_face_of_lisp_face): Remove; unused.
9785
8524aef3
PE
9786 * xdisp.c: Make symbols static if they're not exported.
9787 * dispextern.h (scratch_glyph_row, window_box_edges):
9788 (glyph_to_pixel_coords, set_cursor_from_row):
9789 (get_next_display_element, set_iterator_to_next):
9790 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9791 (show_mouse_face): Remove decls
9792 * frame.h (message_buf_print): Likewise.
9793 * lisp.h (pop_message, set_message, check_point_in_composition):
9794 Likewise.
9795 * xterm.h (set_vertical_scroll_bar): Likewise.
9796 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9797 (message_buf_print, scratch_glyph_row, displayed_buffer):
9798 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9799 (get_next_display_element, show_mouse_face, window_box_edges):
9800 (frame_to_window_pixel_xy, check_point_in_composition):
9801 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9802 (glyph_to_pixel_coords): Remove; unused.
9803
16390cd2
PE
9804 * dired.c (file_name_completion): Now static.
9805
9806 * dbusbind.c (xd_in_read_queued_messages): Now static.
9807
a25f4dfa
PE
9808 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9809 * data.c (circular_list_error): Remove.
9810
14a9c8df
PE
9811 * commands.h (last_point_position, last_point_position_buffer):
9812 (last_point_position_window): Remove decls.
9813 * keyboard.c: Make these variables static.
9814
04f2d78b
CB
9815 * coding.h (coding, code_convert_region, encode_coding_gap):
9816 Remove decls.
74ab6df5
PE
9817 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9818 (iso_code_class, detect_coding, code_convert_region): Now static.
9819 (encode_coding_gap): Remove; unused.
9820
38dfbee1
PE
9821 * chartab.c (chartab_chars, chartab_bits): Now static.
9822
a2cb4e63
PE
9823 * charset.h (charset_iso_8859_1): Remove decl.
9824 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9825 Now static.
9826
127198fd
PE
9827 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9828 * ccl.c (Vccl_program_table): Now static.
9829 (check_ccl_update): Remove; unused.
9830
d85b608f
PE
9831 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9832 * category.h: ... from here.
9833 * category.c (check_category_table, set_category_set): Now static.
9834
31cd66f3
PE
9835 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9836 * lisp.h: Remove these decls.
9837
c358e587
PE
9838 * buffer.c (buffer_count): Remove unused var.
9839
e78aecca
PE
9840 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9841 so that it's not optimized away.
9842 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9843 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9844 exported only to the debugger.
9845
e192d7d3 9846 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9847 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9848
92470028
PE
9849 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9850 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9851 was inaccessible from Lisp.
9852 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9853 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9854
244ed907
PE
9855 alloc.c: Import and export fewer symbols, and remove unused items.
9856 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9857 is defined.
9858 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9859 it's not optimized away by whole-program optimization.
9860 (message_enable_multibyte, free_misc): Remove.
9861 (catchlist, handlerlist, mark_backtrace):
9862 Declare only if BYTE_MARK_STACK.
9863 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9864 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9865 (message_enable_multibyte): Remove decl.
9866 (free_misc, interval_free_list, float_block, float_block_index):
9867 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9868 (cons_free_list, last_marked_index):
9869 Now static.
9870 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9871 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9872 (mark_backtrace): Define only if BYTE_MARK_STACK.
9873 * xdisp.c (message_enable_multibyte): Now static.
9874
61c2b50e 9875 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9876 This makes it easier for human readers (and static analyzers)
9877 to see whether these variables are used from other modules.
9878 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9879 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9880 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9881 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9882 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9883 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9884 * xmenu.c, xselect.c:
9885 Declare Q* vars static if they are not used in other modules.
9886 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9887 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9888 Remove decls of unexported vars.
9889 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9890
95c82688
PE
9891 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9892
16a97296
PE
9893 Make Emacs functions such as Fatom 'static' by default.
9894 This makes it easier for human readers (and static analyzers)
9895 to see whether these functions can be called from other modules.
9896 DEFUN now defines a static function. To make the function external
9897 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9898 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9899 (Finit_image_library):
16a97296
PE
9900 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9901 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9902 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9903 Remove decls, since these functions are now static.
9904 (Funintern, Fget_internal_run_time): New decls, since these functions
9905 were already external.
95c82688 9906
16a97296
PE
9907 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9908 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9909 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9910 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9911 * keyboard.c, keymap.c, lread.c:
9912 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9913 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9914 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9915 Mark functions with DEFUE instead of DEFUN,
9916 if they are used in other modules.
9917 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9918 decls for now-static functions.
9919 * buffer.h (Fdelete_overlay): Remove decl.
9920 * callproc.c (Fgetenv_internal): Mark as internal.
9921 * composite.c (Fremove_list_of_text_properties): Remove decl.
9922 (Fcomposition_get_gstring): New forward static decl.
9923 * composite.h (Fcomposite_get_gstring): Remove decl.
9924 * dired.c (Ffile_attributes): New forward static decl.
9925 * doc.c (Fdocumntation_property): New forward static decl.
9926 * eval.c (Ffetch_bytecode): New forward static decl.
9927 (Funintern): Remove extern decl; now in .h file where it belongs.
9928 * fileio.c (Fmake_symbolic_link): New forward static decl.
9929 * image.c (Finit_image_library): New forward static decl.
9930 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9931 * intervals.h (Fprevious_property_change):
9932 (Fremove_list_of_text_properties): Remove decls.
9933 * keyboard.c (Fthis_command_keys): Remove decl.
9934 (Fcommand_execute): New forward static decl.
9935 * keymap.c (Flookup_key): New forward static decl.
9936 (Fcopy_keymap): Now static.
9937 * keymap.h (Flookup_key): Remove decl.
9938 * process.c (Fget_process): New forward static decl.
9939 (Fprocess_datagram_address): Mark as internal.
9940 * syntax.c (Fsyntax_table_p): New forward static decl.
9941 (skip_chars): Remove duplicate decl.
9942 * textprop.c (Fprevious_property_change): New forward static decl.
9943 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9944 Now internal.
9945 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9946 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9947
785bbd42
PE
9948 * editfns.c (Fformat): Remove unreachable code.
9949
8b913b57
AS
99502011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9951
9952 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9953 change. (Bug#8496)
9954
a6744a35
EZ
99552011-04-13 Eli Zaretskii <eliz@gnu.org>
9956
9957 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9958 when at ZV. (Bug#8487)
9959
e7974947
AS
99602011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9961
baad03f0
AS
9962 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9963 (Bug#8437)
9964 * keyboard.c (parse_tool_bar_item): Likewise.
9965 * sound.c (sound_cleanup, alsa_close): Likewise.
9966 * termcap.c (tgetent): Likewise.
9967 * xfns.c (x_default_font_parameter): Likewise.
9968 * xsettings.c (read_and_apply_settings): Likewise.
9969
e7974947
AS
9970 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9971 (overrun_check_free): Protoize.
9972
28272684
PE
99732011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9974
9975 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9976 since callers should never pass a negative size.
9977 Change the signature to match that of plain 'read' and 'write'; see
9978 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9979 * lisp.h: Update prototypes of emacs_write and emacs_read.
9980
11997c76
EZ
99812011-04-11 Eli Zaretskii <eliz@gnu.org>
9982
9983 * xdisp.c (redisplay_window): Don't try to determine the character
9984 position of the scroll margin if the window start point w->startp
e896f03c 9985 is outside the buffer's accessible region. (Bug#8468)
11997c76 9986
8a2cbd72
EZ
99872011-04-10 Eli Zaretskii <eliz@gnu.org>
9988
9989 Fix write-region and its subroutines for buffers > 2GB.
9990 * fileio.c (a_write, e_write): Modify declaration of arguments and
9991 local variables to support buffers larger than 2GB.
9992 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9993
9994 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9995 argument, local variables, and return value.
9996
9997 * lisp.h: Update prototypes of emacs_write and emacs_read.
9998
9999 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10000
4073e537 100012011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10002
1ebfdcb6
PE
10003 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10004
b2ded58d
PE
10005 Fix more problems found by GCC 4.6.0's static checks.
10006
7d66342c
PE
10007 * xdisp.c (vmessage): Use a better test for character truncation.
10008
bbf47d44
PE
10009 * charset.c (load_charset_map): <, not <=, for optimization,
10010 and to avoid potential problems with integer overflow.
9248994d 10011 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10012 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10013 * editfns.c (Fformat): Likewise.
1e69125e 10014 * syntax.c (skip_chars): Likewise.
3befa583 10015
e3019616
PE
10016 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10017 This also lets GCC 4.6.0 generate slightly better loop code.
10018
becfa255
PE
10019 * callint.c (Fcall_interactively): <, not <=, for optimization.
10020 (Fcall_interactively): Count the number of arguments produced,
10021 not the number of arguments given. This is simpler and lets GCC
10022 4.6.0 generate slightly better code.
10023
dae0cd48
PE
10024 * ftfont.c: Distingish more carefully between FcChar8 and char.
10025 The previous code passed unsigned char * to a functions like
10026 strlen and xstrcasecmp that expect char *, which does not
10027 conform to the C standard.
10028 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10029 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10030 char * when the C standard requires it.
10031
76032d70
PE
10032 * keyboard.c (read_char): Remove unused var.
10033
eb3f1cc8
PE
10034 * eval.c: Port to Windows vsnprintf (Bug#8435).
10035 Include <limits.h>.
10036 (SIZE_MAX): Define if the headers do not.
10037 (verror): Do not give up if vsnprintf returns a negative count.
10038 Instead, grow the buffer. This ports to Windows vsnprintf, which
10039 does not conform to C99. Problem reported by Eli Zaretskii.
10040 Also, simplify the allocation scheme, by avoiding the need for
10041 calling realloc, and removing the ALLOCATED variable.
10042
70476b54
PE
10043 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10044
12020a9e
PE
10045 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10046 But keep the doprint source code for now, as we might revamp it
10047 and use it again (Bug#8435).
ea6c7ae6
PE
10048 * lisp.h (doprnt): Remove.
10049 * Makefile.in (base_obj): Remove doprnt.o.
10050 * deps.mk (doprnt.o): Remove.
10051
5fdb398c
PE
10052 error: Print 32- and 64-bit integers portably (Bug#8435).
10053 Without this change, on typical 64-bit hosts error ("...%d...", N)
10054 was used to print both 32- and 64-bit integers N, which relied on
10055 undefined behavior.
61bdb816 10056 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10057 * lisp.h (error, verror): Mark as printf-like functions.
10058 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10059 Report overflow in size calculations when allocating printf buffer.
10060 Do not truncate output string at its first null byte.
10061 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10062 Truncate the output at a character boundary, since vsnprintf does not
10063 do that.
10064 * charset.c (check_iso_charset_parameter): Convert internal
10065 character to string before calling 'error', since %c now has the
10066 printf meaning.
10067 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10068 overflow when computing char to be passed to 'error'. Do not
10069 pass Lisp_Object to 'error'; pass the integer instead.
10070 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10071 formatted with plain %d.
10072
b189fa66
PE
10073 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10074
bff87ef0
PE
10075 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10076
7e2cac20
PE
10077 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10078
ce4d90b5
PE
10079 * xterm.c (x_catch_errors): Remove duplicate declaration.
10080
266c9547
PE
10081 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10082
79c49ad2
PE
10083 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10084
368f4090
JM
100852011-04-10 Jim Meyering <meyering@redhat.com>
10086
10087 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10088 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10089 return ssize_t not "int", and use size_t as the buffer length.
10090 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10091 * gnutls.h: Update declarations.
10092 * process.c (read_process_output): Use ssize_t, to match.
10093 (send_process): Likewise.
10094
a32d4040
CY
100952011-04-09 Chong Yidong <cyd@stupidchicken.com>
10096
10097 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10098
8546720e 100992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10100
04f2d78b
CB
10101 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10102 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10103
8546720e
GM
10104 * xterm.c (handle_one_xevent):
10105 * xmenu.c (create_and_show_popup_menu):
10106 * xselect.c (x_decline_selection_request)
10107 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10108
0a2f5c1a 101092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10110
10111 Fix some uses of `int' instead of EMACS_INT.
10112 * search.c (string_match_1, fast_string_match)
10113 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10114 (scan_buffer, find_next_newline_no_quit)
10115 (find_before_next_newline, search_command, Freplace_match)
10116 (Fmatch_data): Make some `int' variables be EMACS_INT.
10117
10118 * xdisp.c (display_count_lines): 3rd argument and return value now
10119 EMACS_INT. All callers changed.
10120 (pint2hrstr): Last argument is now EMACS_INT.
10121
10122 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10123 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10124 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10125 (decode_coding_utf_16, decode_coding_emacs_mule)
10126 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10127 (decode_coding_ccl, decode_coding_charset)
10128 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10129 (decode_coding_iso_2022, decode_coding_emacs_mule)
10130 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10131 <char_offset, last_offset>: Declare EMACS_INT.
10132 (encode_coding_utf_8, encode_coding_utf_16)
10133 (encode_coding_emacs_mule, encode_invocation_designation)
10134 (encode_designation_at_bol, encode_coding_iso_2022)
10135 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10136 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10137 Declare EMACS_INT.
10138 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10139 (encode_invocation_designation): Last argument P_NCHARS is now
10140 EMACS_INT.
10141 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10142 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10143
10144 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10145 All users changed.
10146
10147 * ccl.c (Fccl_execute_on_string): Declare some variables
10148 EMACS_INT.
10149
8546720e 101502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10151
10152 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10153
4e19a977
CS
101542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10155
10156 * process.c (Fformat_network_address): Doc fix.
10157
87302331
R
101582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10159
ee7683eb 10160 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10161
cbb59342
CY
101622011-04-08 Chong Yidong <cyd@stupidchicken.com>
10163
10164 * keyboard.c (read_char): Call Lisp function help-form-show,
10165 instead of using internal_with_output_to_temp_buffer.
10166 (Qhelp_form_show): New var.
e0d38eeb 10167 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10168
10169 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10170
10171 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10172
e67a13ab
CY
101732011-04-06 Chong Yidong <cyd@stupidchicken.com>
10174
04f2d78b
CB
10175 * process.c (Flist_processes): Remove to Lisp.
10176 (list_processes_1): Delete.
e67a13ab 10177
973f782d
EZ
101782011-04-06 Eli Zaretskii <eliz@gnu.org>
10179
7c106b1e
EZ
10180 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10181
973f782d
EZ
10182 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10183
41cf7d1a 101842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10185
ca23cc88
PE
10186 Fix more problems found by GCC 4.6.0's static checks.
10187
f390e2d5
PE
10188 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10189
42eea0d0
PE
10190 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10191
b69769da 10192 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10193
f9541e84
PE
10194 * xdisp.c (vmessage): Mark as a printf-like function.
10195
13841b55
PE
10196 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10197
c136c10f
PE
10198 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10199
5e2d4a30
PE
10200 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10201 printf-like functions.
10202 (tiff_load): Add casts to remove these marks before passing them
10203 to system-supplied API.
10204
583f48b9
PE
10205 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10206
b25d760e
PE
10207 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10208 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10209 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10210 directly, rather than having caller test rule sign. This avoids
10211 some unnecessary tests.
10212 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10213 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10214 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10215
bc7b6697 10216 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10217 (xfont_open): Avoid unnecessary tests.
bc7b6697 10218
27ccc379
PE
10219 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10220
dcd5c89a
PE
10221 * composite.h, composite.c (composition_gstring_put_cache):
10222 Use EMACS_INT, not int, for length.
10223
b13a45c6
PE
10224 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10225 breaking out part of COMPOSITION_DECODE_RULE.
10226 (COMPOSITION_DECODE_RULE): Use it.
10227 * composite.c (get_composition_id): Remove unused local vars,
10228 by using the new macro.
10229
1e792e4d
PE
10230 * textprop.c (set_text_properties_1): Change while to do-while,
10231 since the condition is always true at first.
10232
dc6c6455 10233 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10234 (interval_deletion_adjustment): Return unsigned value.
10235 All uses changed.
dc6c6455 10236
aba7731a
PE
10237 * process.c (list_processes_1, create_pty, read_process_output):
10238 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10239 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10240 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10241 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10242 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10243
fdfc4bf3
PE
10244 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10245
fca8fe46 10246 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10247 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10248
06a0259a 10249 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10250 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10251 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10252
e7b9e80f
PE
10253 * print.c (print_error_message): Avoid int overflow.
10254
56201685
PE
10255 * font.c (font_list_entities): Redo for clarity,
10256 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10257
78834453 10258 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10259 (font_score): Avoid potential overflow in diff calculation.
78834453 10260
0bc0b309 10261 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10262 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10263
e610eaca
PE
10264 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10265
b895abce
PE
10266 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10267 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10268 can always succeed if overflow has undefined behavior.
10269
1f1d9321 10270 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10271 (wordify): Omit three unnecessary tests.
1f1d9321 10272
c59478bc
PE
10273 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10274 All callers changed. This avoids the need for an unused var.
10275
79b73827
PE
10276 * casefiddle.c (casify_region): Remove var that is set but not used.
10277
a4db5dfe
PE
10278 * dired.c (file_name_completion): Remove var that is set but not used.
10279
43aae36e
PE
10280 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10281
2a47c44d 10282 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10283 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10284
a37c69bf
PE
10285 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10286 Check for integer overflow on size calculations.
10287
328ab8e7
PE
10288 * buffer.c (Fprevious_overlay_change): Remove var that is set
10289 but not used.
10290
e5a2a5cb
PE
10291 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10292 Remove vars that are set but not used.
8d84a6eb 10293 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10294 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10295
a60e5f68
PE
10296 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10297
f661cb61 10298 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10299 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10300
f0397f5a
PE
10301 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10302 that are set but not used.
10303
8664db06 10304 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10305 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10306
6abdaa4a
PE
10307 * xselect.c (x_get_local_selection, x_handle_property_notify):
10308 Remove vars that are set but not used.
10309
0ce7538d 10310 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10311 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10312
9ae848fc
PE
10313 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10314 Remove var that is set but not used.
0b918413
PE
10315 (scroll_bar_windows_size): Now size_t, not int.
10316 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10317 Check for overflow.
9ae848fc 10318
a5a62657
PE
10319 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10320 (map_tty_color) [!defined MSDOS]: Likewise.
10321
5c5cdd39
PE
10322 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10323
66ebf983
PE
10324 * coding.c: Remove vars that are set but not used.
10325 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10326 All callers changed.
10327 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10328 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10329 (decode_coding_charset): Remove vars that are set but not used.
10330
1be4d761
PE
10331 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10332 that is set but not used.
10333
47553fa8
PE
10334 * print.c (print_object): Remove var that is set but not used.
10335
1f7196bf 10336 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10337 The gnulib version avoids calling malloc in the usual case,
10338 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10339 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10340 * filelock.c (current_lock_owner): Likewise.
10341 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10342 * sysdep.c: Include allocator.h, careadlinkat.h.
10343 (emacs_no_realloc_allocator): New static constant.
10344 (emacs_readlink): New function.
fdb61804
PE
10345 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10346 ../lib/careadlinkat.h.
d1fdcab7 10347
f84c17c7
SM
103482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10349
10350 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10351 first non-nil return value).
10352
ef3862ad
JD
103532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10354
10355 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10356 if not defined (Bug#8403).
10357
376a7006
JB
103582011-04-02 Juanma Barranquero <lekktu@gmail.com>
10359
10360 * xdisp.c (display_count_lines): Remove parameter `start',
10361 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10362 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10363 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10364 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10365 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10366 and thereabouts. All callers changed.
10367 (get_per_char_metric): Remove parameter `f', unused since
10368 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10369
6ca3801d
JM
103702011-04-02 Jim Meyering <meyering@redhat.com>
10371
10372 do not dereference NULL upon failed strdup
10373 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10374 (ns_get_family): Likewise.
10375
d8e2b5ba
JB
103762011-04-02 Juanma Barranquero <lekktu@gmail.com>
10377
10378 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10379
8c74fcbd
JD
103802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10381
10382 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10383 later (Bug#8403).
10384
7200d79c
SM
103852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10386
03408648 10387 Add lexical binding.
7200d79c 10388
03408648
SM
10389 * window.c (Ftemp_output_buffer_show): New fun.
10390 (Fsave_window_excursion):
10391 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10392
10393 * lread.c (lisp_file_lexically_bound_p): New function.
10394 (Fload): Bind Qlexical_binding.
10395 (readevalloop): Remove `evalfun' arg.
10396 Bind Qinternal_interpreter_environment.
10397 (Feval_buffer): Bind Qlexical_binding.
10398 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10399 Mark as dynamic.
10400 (syms_of_lread): Declare `lexical-binding'.
10401
10402 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10403
10404 * keyboard.c (eval_dyn): New fun.
10405 (menu_item_eval_property): Use it.
ca105506
SM
10406
10407 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10408
03408648
SM
10409 * fns.c (concat, mapcar1): Accept byte-code-functions.
10410
10411 * eval.c (Fsetq): Handle lexical vars.
10412 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10413 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10414 (FletX, Flet): Obey lexical binding.
10415 (Fcommandp): Handle closures.
10416 (Feval): New `lexical' arg.
10417 (eval_sub): New function extracted from Feval. Use it almost
10418 everywhere where Feval was used. Look up vars in lexical env.
10419 Handle closures.
10420 (Ffunctionp): Move from subr.el.
10421 (Ffuncall): Handle closures.
10422 (apply_lambda): Remove `eval_flags'.
10423 (funcall_lambda): Handle closures and new byte-code-functions.
10424 (Fspecial_variable_p): New function.
10425 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10426 but without exporting it to Lisp.
23aba0ea 10427
23aba0ea 10428 * doc.c (Fdocumentation, store_function_docstring):
03408648 10429 * data.c (Finteractive_form): Handle closures.
23aba0ea 10430
03408648
SM
10431 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10432 interactive spec.
ba83908c 10433
04f2d78b
CB
10434 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10435 New byte-codes.
03408648
SM
10436 (exec_byte_code): New function extracted from Fbyte_code to handle new
10437 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10438
03408648 10439 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10440
03408648 10441 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10442
e2abce01
JB
104432011-03-31 Juanma Barranquero <lekktu@gmail.com>
10444
10445 * xdisp.c (redisplay_internal): Fix prototype.
10446
63696a73 104472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10448
63696a73 10449 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10450 (try_scrolling): Use it when setting scroll_limit.
10451 Limit scrolling to 100 screen lines.
63696a73
EZ
10452 (redisplay_window): Even when falling back on "recentering",
10453 position point in the window according to scroll-conservatively,
10454 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10455
10456 (try_scrolling): When point is above the window, allow searching
10457 as far as scroll_max, or one screenful, to compute vertical
10458 distance from PT to the scroll margin position. This prevents
10459 try_scrolling from unnecessarily failing when
10460 scroll-conservatively is set to a value slightly larger than the
10461 window height. Clean up the case of PT below the margin at bottom
10462 of window: scroll_max can no longer be INT_MAX. When aggressive
10463 scrolling is in use, don't let point enter the opposite scroll
10464 margin as result of the scroll.
10465 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10466 threshold of 100 lines for never-recentering scrolling.
10467
e4cc2dfc
JB
104682011-03-31 Juanma Barranquero <lekktu@gmail.com>
10469
10470 * dispextern.h (move_it_by_lines):
10471 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10472 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10473 (message_log_check_duplicate): Remove parameters `prev_bol' and
10474 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10475 (redisplay_internal): Remove parameter `preserve_echo_area',
10476 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10477
10478 * indent.c (Fvertical_motion):
10479 * window.c (window_scroll_pixel_based, Frecenter):
10480 Don't pass `need_y_p' to `move_it_by_lines'.
10481
1c470562
SM
104822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10483
44f230aa
SM
10484 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10485 steal a few bits to be more compact.
10486 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10487 Remove unneeded casts.
10488
1c470562
SM
10489 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10490
888adce9
ZK
104912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10492
10493 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10494 binding" message (bug#7967).
10495
f838ed7b
PE
104962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10497
77861b95
PE
10498 Fix more problems found by GCC 4.6.0's static checks.
10499
de6dbc14
PE
10500 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10501 Remove unused local var.
10502
f838ed7b
PE
10503 * editfns.c (Fmessage_box): Remove unused local var.
10504
792c7b2b
PE
10505 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10506 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10507 Omit unused local vars.
c499e557 10508 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10509 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10510 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10511 Omit unused local var.
10512
ba0165e1
PE
10513 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10514 Don't assume string length fits in int.
32ad8845 10515 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10516 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10517
3c59b4c9
PE
10518 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10519 instead of alloca (Bug#8344).
10520
a3eed478 10521 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10522 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10523
eb4d412d
PE
10524 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10525
1658b401
PE
10526 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10527 concerns.
10528
10529 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10530
10531 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10532
9a2c6e05
PE
10533 * keyboard.c (syms_of_keyboard): Use the same style as later
10534 in this function when indexing through an array. This also
10535 works around GCC bug 48267.
10536
03d0a109
PE
10537 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10538
44f730c8
PE
10539 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10540
fe75f926
PE
10541 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10542 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10543
ffa8c828
PE
10544 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10545 This avoids undefined behavior on integer overflow, and is a bit
10546 more convenient anyway since it is compared to a size_t variable.
10547
c5101a77
PE
10548 Variadic C functions now count arguments with size_t, not int.
10549 This avoids an unnecessary limitation on 64-bit machines, which
10550 caused (substring ...) to crash on large vectors (Bug#8344).
10551 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10552 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10553 All variadic functions and their callers changed accordingly.
c5101a77
PE
10554 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10555 * data.c (arith_driver, float_arith_driver): Likewise.
10556 * editfns.c (general_insert_function): Likewise.
10557 * eval.c (struct backtrace.nargs, interactive_p)
10558 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10559 (funcall_lambda, mark_backtrace): Likewise.
10560 * fns.c (concat): Likewise.
10561 * frame.c (x_set_frame_parameters): Likewise.
10562 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10563 0 if not found, not -1. All callers changed.
10564
dd3f25f7
PE
10565 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10566 (stack_copy_size): Now size_t, not int.
10567 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10568
461c2ab9
JB
105692011-03-28 Juanma Barranquero <lekktu@gmail.com>
10570
10571 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10572 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10573 All callers changed.
10574
10575 * lisp.h (multibyte_char_to_unibyte):
10576 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10577 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10578 * character.h (CHAR_TO_BYTE8):
10579 * cmds.c (internal_self_insert):
10580 * editfns.c (general_insert_function):
10581 * keymap.c (push_key_description):
10582 * search.c (Freplace_match):
10583 * xdisp.c (message_dolog, set_message_1): All callers changed.
10584
f6d62986
SM
105852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10586
10587 * keyboard.c (safe_run_hook_funcall): New function.
10588 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10589 don't set the hook to nil, but remove the offending function instead.
10590 (Qcommand_hook_internal): Remove, unused.
10591 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10592 Vcommand_hook_internal.
10593
10594 * eval.c (enum run_hooks_condition): Remove.
10595 (funcall_nil, funcall_not): New functions.
10596 (run_hook_with_args): Call each function through a `funcall' argument.
10597 Remove `cond' argument, now redundant.
10598 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10599 (Frun_hook_with_args_until_failure): Adjust accordingly.
10600 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10601
1db5b1ad
JB
106022011-03-28 Juanma Barranquero <lekktu@gmail.com>
10603
10604 * dispextern.h (string_buffer_position): Remove declaration.
10605
10606 * print.c (strout): Remove parameter `multibyte', unused since
10607 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10608
10609 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10610 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10611 All callers changed.
10612
10613 * w32.c (_wsa_errlist): Use braces for struct initializers.
10614
10615 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10616 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10617 All callers changed.
10618 (string_buffer_position): Likewise. Also, make static (it's never
10619 used outside xdisp.c).
10620 (cursor_row_p): Remove parameter `w', unused since
10621 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10622 (decode_mode_spec): Remove parameter `precision', introduced during
10623 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10624 All callers changed.
10625
5ffb62aa
JD
106262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10627
10628 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10629
461c2ab9 106302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10631
10632 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10633 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10634 (ns_update_auto_hide_menu_bar): New functions.
10635 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10636 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10637 ns_constrain_all_frames.
10638 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10639 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10640
5c380ffb
JD
106412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10642
10643 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10644
9af30bdf
GM
106452011-03-27 Glenn Morris <rgm@gnu.org>
10646
10647 * syssignal.h: Replace RETSIGTYPE with void.
10648 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10649 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10650 Replace SIGTYPE with void everywhere.
10651 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10652 * s/template.h (SIGTYPE): Remove commented out definition.
10653
e2abce01
JB
106542011-03-26 Eli Zaretskii <eliz@gnu.org>
10655
10656 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10657 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10658
f868cd8a
JB
106592011-03-26 Juanma Barranquero <lekktu@gmail.com>
10660
59eb0929
JB
10661 * w32.c (read_unc_volume): Use parameter `henum', instead of
10662 global variable `wget_enum_handle'.
10663
10664 * keymap.c (describe_vector): Remove parameters `indices' and
10665 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10666 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10667
f868cd8a
JB
10668 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10669
10670 * keyboard.c (timer_check): Remove parameter `do_it_now',
10671 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10672 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10673 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10674
10675 * keyboard.c (read_char):
10676 * w32menu.c (w32_menu_display_help):
10677 * xmenu.c (show_help_event, menu_help_callback):
10678 Adjust calls to `show_help_echo'.
10679
10680 * gtkutil.c (xg_maybe_add_timer):
10681 * keyboard.c (readable_events):
10682 * process.c (wait_reading_process_output):
10683 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10684
10685 * insdel.c (adjust_markers_gap_motion):
10686 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10687 (gap_left, gap_right): Don't call it.
10688
2ecf6fdb
CY
106892011-03-25 Chong Yidong <cyd@stupidchicken.com>
10690
10691 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10692 incurred during fontification.
10693
6b1f9ba4
JB
106942011-03-25 Juanma Barranquero <lekktu@gmail.com>
10695
10696 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10697 (DEFVAR_PER_BUFFER): Don't pass it.
10698
10699 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10700 (scrolling_window): Don't pass it.
10701
0f4a96b5
JB
107022011-03-25 Juanma Barranquero <lekktu@gmail.com>
10703
10704 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10705
10706 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10707 and `suffix'.
10708 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10709 of variables specific to SELinux and computation of `encoded_absname'.
10710
10711 * image.c (XPutPixel): Remove unused variable `height'.
10712
10713 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10714
10715 * unexw32.c (get_section_info): Remove unused variable `section'.
10716
10717 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10718 (system_process_attributes): Remove unused variable `sess'.
10719 (sys_read): Remove unused variable `err'.
10720
10721 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10722 (w32_wnd_proc): Remove unused variable `isdead'.
10723 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10724 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10725 (x_create_tip_frame): Remove unused variable `tem'.
10726
10727 * w32inevt.c (w32_console_read_socket):
10728 Remove unused variable `no_events'.
10729
10730 * w32term.c (x_draw_composite_glyph_string_foreground):
10731 Remove unused variable `width'.
10732
1149507c
JB
107332011-03-24 Juanma Barranquero <lekktu@gmail.com>
10734
10735 * w32term.c (x_set_glyph_string_clipping):
10736 Don't pass uninitialized region to CombineRgn.
10737
9c88f339
JB
107382011-03-23 Juanma Barranquero <lekktu@gmail.com>
10739
10740 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10741 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10742 (Fx_close_connection): Remove unused variable `i'.
10743
10744 * w32font.c (w32font_draw): Return number of glyphs.
10745 (w32font_open_internal): Remove unused variable `i'.
10746 (w32font_driver): Add missing initializer.
10747
10748 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10749 (fill_in_menu): Remove unused variable `items_added'.
10750
10751 * w32term.c (last_mouse_press_frame): Remove static global variable.
10752 (w32_clip_to_row): Remove unused variable `f'.
10753 (x_delete_terminal): Remove unused variable `i'.
10754
10755 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10756 (NOTHING): Remove unused static global variable.
10757 (uniscribe_check_otf): Remove unused variable `table'.
10758 (uniscribe_font_driver): Add missing initializers.
10759
dee091a3
JD
107602011-03-23 Julien Danjou <julien@danjou.info>
10761
10762 * term.c (Fsuspend_tty, Fresume_tty):
10763 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10764 * window.c (temp_output_buffer_show):
10765 * insdel.c (signal_before_change):
10766 * frame.c (Fhandle_switch_frame):
10767 * fileio.c (Fdo_auto_save):
10768 * emacs.c (Fkill_emacs):
10769 * editfns.c (save_excursion_restore):
10770 * cmds.c (internal_self_insert):
10771 * callint.c (Fcall_interactively):
10772 * buffer.c (Fkill_all_local_variables):
10773 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10774 Use Frun_hooks.
0f4a96b5 10775 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10776 unconditionally since it does the check itself.
dee091a3 10777
2c520ab5 107782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10779
c9c49752
PE
10780 Fix more problems found by GCC 4.5.2's static checks.
10781
8abc3f12
PE
10782 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10783 the first time through the loop, since we know p0 < p1 then.
10784 This also avoids a gcc -Wstrict-overflow warning.
10785
a2d26660
PE
10786 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10787 leading to a memory leak, possible in functions like
10788 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10789 of objects (Bug#8318).
a2d26660 10790
916c72e9
PE
10791 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10792 that could (at least in theory) be that large.
10793
19ab8a18
PE
10794 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10795 This is less likely to overflow, and avoids undefined behavior if
10796 overflow does occur. All callers changed. Use strtoul to scan
10797 for the unsigned long integer.
b7cbbd6f
PE
10798 (pint2hrstr): Simplify and tune code slightly.
10799 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10800
f0641eff
PE
10801 * scroll.c (do_scrolling): Work around GCC bug 48228.
10802 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10803
7f650bb9
PE
10804 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10805 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10806 (validate_x_resource_name): Simplify count usage.
10807 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10808
37dd57d1
PE
10809 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10810 fail (Bug#8306).
81e56e61 10811
699979fc 10812 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10813
401bf9b4
PE
10814 * process.c (Fmake_network_process): Use socklen_t, not int,
10815 where POSIX says socklen_t is required in portable programs.
10816 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10817 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10818 (Fmake_network_process, server_accept_connection):
10819 (wait_reading_process_output, read_process_output):
10820 Likewise.
10821
b93aacde
PE
10822 * process.c: Rename or move locals to avoid shadowing.
10823 (list_processes_1, Fmake_network_process):
10824 (read_process_output_error_handler, exec_sentinel_error_handler):
10825 Rename or move locals.
4dc343ee 10826 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10827 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10828 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10829 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10830 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10831
af8a867c 10832 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10833 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10834 Include tparam.h instead, since it declares them.
af8a867c
PE
10835 * cm.h (PC): Remove extern decl; tparam.h now does this.
10836 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10837 * terminfo.c: Include tparam.h, to check interfaces.
10838 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10839 (tparam): Adjust signature to match interface in tparam.h;
10840 this removes some undefined behavior. Check that outstring and len
10841 are zero, which they always are with Emacs.
10842 * tparam.h (PC, BC, UP): New extern decls.
10843
0248044d 10844 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10845 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10846
8ff096c1 10847 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10848 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10849 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10850 (ftfont_list): Remove unused local.
49eaafba
PE
10851 (get_adstyle_property, ftfont_pattern_entity):
10852 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10853 Rename locals to avoid shadowing.
8ff096c1 10854
e2be39f6
PE
10855 * xfont.c (xfont_list_family): Mark var as initialized.
10856
c9735e30
PE
10857 * xml.c (make_dom): Now static.
10858
8f5201ae
PE
10859 * composite.c (composition_compute_stop_pos): Rename local to
10860 avoid shadowing.
b246f932
PE
10861 (composition_reseat_it): Remove unused locals.
10862 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10863 (composition_update_it): Mark var as initialized.
11b61122
PE
10864 (find_automatic_composition): Mark vars as initialized,
10865 with a FIXME (Bug#8290).
8f5201ae 10866
760fbc2c
PE
10867 character.h: Rename locals to avoid shadowing.
10868 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10869 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10870 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10871 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10872 to avoid shadowing.
10873
ff08eb85
PE
10874 * textprop.c (property_change_between_p): Remove; unused.
10875
fc7bf025
PE
10876 * intervals.c (interval_start_pos): Now static.
10877
235d7abc
PE
10878 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10879
44f230aa
SM
10880 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10881 Rename locals to avoid shadowing.
3e7d6594 10882
50060332
PE
10883 * sound.c (wav_play, au_play, Fplay_sound_internal):
10884 Fix pointer signedness.
d01f234b 10885 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10886 (wav_play): Initialize a variable to 0, to prevent undefined
10887 behavior (Bug#8278).
50060332 10888
c4fc4e30
PE
10889 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10890
918436ed
PE
10891 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10892
c939f91b
PE
10893 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10894 clobbering (Bug#8298).
b9c7f648
PE
10895 * sysdep.c (sys_subshell): Likewise.
10896 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10897
6bd8c144
PE
10898 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10899 This should get cleaned up, so that child_setup has the
10900 same signature on all platforms.
10901
7710357c 10902 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10903 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10904
c59da222
CY
109052011-03-22 Chong Yidong <cyd@stupidchicken.com>
10906
10907 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10908 not to be necessary, and produces flickering.
10909
66b87493
GM
109102011-03-20 Glenn Morris <rgm@gnu.org>
10911
10912 * config.in: Remove file.
10913
45b6f6d5
JB
109142011-03-20 Juanma Barranquero <lekktu@gmail.com>
10915
10916 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10917 are now in src/globals.h.
10918 (syms_of_minibuf): Remove spurious & from previous change.
10919
cd394be1 109202011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10921
10922 * minibuf.c (completing-read-function): New variable.
10923 (completing-read-default): Rename from completing-read.
10924 (completing-read): Call completing-read-function.
10925
b14e3e21
CY
109262011-03-19 Juanma Barranquero <lekktu@gmail.com>
10927
10928 * xfaces.c (Fx_load_color_file):
10929 Read color file from absolute filename (bug#8250).
10930
f2b726e6
JB
109312011-03-19 Juanma Barranquero <lekktu@gmail.com>
10932
10933 * makefile.w32-in: Update dependencies.
10934
09f6ff02
EZ
109352011-03-17 Eli Zaretskii <eliz@gnu.org>
10936
10937 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10938
29a6015a
PE
109392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10940
a3a6c54e
PE
10941 Fix more problems found by GCC 4.5.2's static checks.
10942
b766f867
PE
10943 * process.c (make_serial_process_unwind, send_process_trap):
10944 (sigchld_handler): Now static.
10945
be02381c
PE
10946 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10947 That way, the code declares only the vars that it needs.
10948 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10949 * s/cygwin.h (PTY_ITERATION): Likewise.
10950 * s/darwin.h (PTY_ITERATION): Likewise.
10951 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10952
57048744
PE
10953 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10954 * process.c (allocate_pty): Don't declare stb unless it's needed.
10955
7914961c 10956 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10957 (CONSTANTLIM): Remove; unused.
10958 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10959 Define only if needed.
7914961c 10960
b3967b18
PE
10961 * unexelf.c (unexec): Name an expression,
10962 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10963 Use a different way to cause a compilation error if anyone uses
10964 n rather than nn, a way that does not involve shadowing.
73366a00 10965 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10966
29a6015a
PE
10967 * deps.mk (unexalpha.o): Remove; unused.
10968
43cfc33e 10969 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10970 * unexec.h: New file.
ce701a33
PE
10971 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10972 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10973 Depend on unexec.h.
10974 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10975 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10976 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10977 Change as necessary to match prototype in unexec.h.
ce701a33 10978
01f44d5a
PE
10979 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10980 shadowing.
4f63c6bb 10981 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10982
a6670b0b
PE
10983 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10984 Rename locals to avoid shadowing.
10985
cef2010d 10986 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10987 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10988
d4d7173a
PE
10989 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10990
f08b802a
PE
10991 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10992 warning when compiling print.c.
10993
3ddb0639
PE
10994 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10995 instead of using an uninitialized var.
5ad03b97 10996 (font_sort_entities): Mark var as initialized.
3ddb0639 10997
170a2692
PE
10998 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10999
e663c700
PE
11000 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11001 pointers to constants.
89bc529a 11002 (font_parse_fcname): Remove unused vars.
7b81e2d0 11003 (font_delete_unmatched): Now static.
ea838e10 11004 (font_get_spec): Remove; unused.
13a547c6
PE
11005 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11006 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11007 Rename or move locals to avoid shadowing.
e663c700 11008
2a80c887 11009 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11010 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11011
1384fa33 11012 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11013 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11014
8b2c52e9
PE
11015 * alloc.c (mark_backtrace): Move decl from here ...
11016 * lisp.h: ... to here, so that it can be checked.
11017
475545b5 11018 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11019 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11020 (lisp_indirect_variable): Name an expression,
11021 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11022 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11023
b1349114 11024 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11025 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11026 Use const pointer when appropriate.
b1349114 11027
a2928364
PE
11028 * lisp.h (get_system_name, get_operating_system_release):
11029 Move decls here, to check interfaces.
11030 * process.c (get_operating_system_release): Move decl to lisp.h.
11031 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11032 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11033 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11034 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11035 (Fformat_time_string, Fencode_time, Finsert_char):
11036 (Ftranslate_region_internal, Fformat):
11037 Rename or remove local vars to avoid shadowing.
9710023e 11038 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11039
a415e694
PE
11040 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11041 avoid shadowing.
11042
8ef4622d
PE
11043 * lisp.h (eassert): Check that the argument compiles, even if
11044 ENABLE_CHECKING is not defined.
11045
946f9a5b
PE
11046 * data.c (Findirect_variable): Name an expression, to avoid
11047 gcc -Wbad-function-cast warning.
112396d6 11048 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11049 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11050 (Fmake_variable_buffer_local, Fmake_local_variable):
11051 Mark variables as initialized.
52746918 11052 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11053
e5aab7e7 11054 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11055 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11056 Rename locals to avoid shadowing.
dff45157
PE
11057 (mark_stack): Move local variables into the #ifdef region where
11058 they're used.
7bc26fdb
PE
11059 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11060 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11061 needed otherwise.
11062 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11063 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11064 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11065
e5aab7e7
PE
11066 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11067 avoids undefined behavior in theory.
11068
4da60324
PE
11069 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11070
88043301
PE
11071 Use functions, not macros, for up- and down-casing (Bug#8254).
11072 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11073 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11074 to use the following functions instead of these macros.
11075 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11076 EMACS_INT, since callers assume the returned value fits in int.
11077 (upcase1): Likewise, for UPCASE_TABLE.
11078 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11079 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11080 the race-condition problem in the old DOWNCASE.
88043301 11081
19ed5445
PE
11082 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11083 Rename locals to avoid shadowing.
11084 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11085 (regex_compile, re_search_2, re_match_2_internal):
11086 Remove unused local vars.
952db0d7
PE
11087 (FREE_VAR): Rewrite so as not to use empty "else",
11088 which gcc can warn about.
da053e48 11089 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11090 (RETALLOC_IF): Define only if needed.
11091 (WORDCHAR_P): Likewise. This one is never needed, but is used
11092 only in a comment talking about a compiler bug, so put inside
11093 the #if 0 of that comment.
11094 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11095 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11096 Remove; unused.
19ed5445 11097
1f3561e4 11098 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11099 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11100 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11101
ded6f8f7
PE
11102 * search.c (simple_search): Remove unused var.
11103
dbd37a95
PE
11104 * dired.c (compile_pattern): Move decl from here ...
11105 * lisp.h: ... to here, so that it can be checked.
11106 (struct re_registers): New forward decl.
11107
7e47afad
PE
11108 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11109
85f24f61
PE
11110 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11111 All uses changed.
11112 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11113 Rename locals to avoid shadowing.
5671df8f 11114 (Fvertical_motion): Mark locals as initialized.
85f24f61 11115
181aa2be 11116 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11117 (casify_region): Mark local as initialized.
181aa2be 11118
930d429c
PE
11119 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11120
7082eac6
PE
11121 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11122 New macros, so that the caller can use some names other than
11123 gcpro1, gcpro2, etc.
11124 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11125 of the new macros.
11126 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11127 argument, for consistency with GCPRO2_VAR, etc: it is now the
11128 prefix of the variable, not the variable itself. All uses
11129 changed.
38b2c076
PE
11130 * dired.c (directory_files_internal, file_name_completion):
11131 Rename locals to avoid shadowing.
11132
15206ed9
PE
11133 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11134 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11135 dired.c's scmp function, had undefined behavior.
11136 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11137 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11138 * buffer.h: ... to here, because these macros use current_buffer,
11139 and the new implementation with inline functions needs to have
11140 current_buffer in scope now, rather than later when the macros
11141 are used.
11142 (downcase, upcase1): New static inline functions.
11143 (DOWNCASE, UPCASE1): Reimplement using these functions.
11144 This avoids undefined behavior in expressions like
11145 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11146 from race conditions in accessing the global variables
11147 case_temp1 and case_temp2.
11148 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11149 * lisp.h (case_temp1, case_temp2): Remove their decls.
11150 * character.h (ASCII_CHAR_P): Move from here ...
11151 * lisp.h: ... to here, so that the inline functions mentioned
11152 above can use them.
11153
4a6bea26
PE
11154 * dired.c (directory_files_internal_unwind): Now static.
11155
f14b7e14
PE
11156 * fileio.c (file_name_as_directory, directory_file_name):
11157 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11158 Now static.
2893f146
PE
11159 (file_name_as_directory): Use const pointers when appropriate.
11160 (Fexpand_file_name): Likewise. In particular, newdir might
11161 point at constant storage, so make it a const pointer.
fd4ead52 11162 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11163 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11164 signedness issues.
f839df0c
PE
11165 (Fset_file_times, Finsert_file_contents, auto_save_error):
11166 Rename locals to avoid shadowing.
f14b7e14 11167
5716756e 11168 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11169 (Ftry_completion, Fall_completions): Rename or remove locals
11170 to avoid shadowing.
5716756e 11171
b4c3046a
PE
11172 * marker.c (bytepos_to_charpos): Remove; unused.
11173
b45db522
PE
11174 * lisp.h (verify_bytepos, count_markers): New decls,
11175 so that gcc does not warn that these functions aren't declared.
11176
85876d07
PE
11177 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11178 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11179 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11180 (copy_text): Remove unused local var.
85876d07 11181
03d78a21 11182 * filelock.c (within_one_second): Now static.
b3dd38ab 11183 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11184
5df8f01b
PE
11185 * buffer.c (fix_overlays_before): Mark locals as initialized.
11186 (fix_start_end_in_overlays): Likewise. This function should be
11187 simplified by using pointers-to-pointers, but that's a different
11188 matter.
b1d876f1 11189 (switch_to_buffer_1): Now static.
8f54f30a
PE
11190 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11191 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11192
a70072c9 11193 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11194 Fix pointer signedness issue.
edced198
PE
11195 (sys_subshell): Mark local as volatile if checking for lint,
11196 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11197 (MAXPATHLEN): Define only if needed.
a70072c9 11198
a0977c44
PE
11199 * process.c (serial_open, serial_configure): Move decls from here ...
11200 * systty.h: ... to here, so that they can be checked.
11201
a884fdcc
PE
11202 * fns.c (get_random, seed_random): Move extern decls from here ...
11203 * lisp.h: ... to here, so that they can be checked.
11204
604efe86 11205 * sysdep.c (reset_io): Now static.
b8950c94 11206 (wait_for_termination_signal): Remove; unused.
604efe86 11207
38fc62d9
PE
11208 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11209 (copy_keymap_item, append_key, push_text_char_description):
11210 Now static.
1004a21a 11211 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11212 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11213 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11214 (describe_map_tree):
11215 Rename locals to avoid shadowing.
38fc62d9 11216
2f2650da
PE
11217 * keyboard.c: Declare functions static if they are not used elsewhere.
11218 (echo_char, echo_dash, cmd_error, top_level_2):
11219 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11220 (read_char, kbd_buffer_get_event, make_lispy_position):
11221 (make_lispy_event, make_lispy_movement, apply_modifiers):
11222 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11223 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11224 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11225 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11226 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11227
a053e86c 11228 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11229 (mark_kboards): Move decl here ...
11230 * alloc.c (mark_kboards): ... from here.
a053e86c 11231
4752793e
PE
11232 * lisp.h (force_auto_save_soon): New decl.
11233
74f10ca7 11234 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11235 (DEFINE_DUMMY_FUNCTION): New macro.
11236 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11237 Use it.
c03cd23f
PE
11238 (main): Add casts to avoid warnings
11239 if GCC considers string literals to be constants.
74f10ca7 11240
022e70d4
PE
11241 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11242
59d6fe83
PE
11243 * dbusbind.c: Pointer signedness fixes.
11244 (xd_signature, xd_append_arg, xd_initialize):
11245 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11246 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11247 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11248 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11249
78320123
PE
11250 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11251 if GCC considers string literals to be constants.
49cebcca 11252 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11253
35ac2a97
SM
112542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11255
fb103ca9
SM
11256 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11257 (print_preprocess, print_object): New macro to fix last change.
11258
35ac2a97
SM
11259 * print.c (print_preprocess): Don't forget font objects.
11260
62973b41
JB
112612011-03-16 Juanma Barranquero <lekktu@gmail.com>
11262
11263 * emacs.c (USAGE3): Doc fixes.
11264
0e48bb22
AS
112652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11266
11267 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11268 structure.
11269
7684e57b
JB
112702011-03-14 Juanma Barranquero <lekktu@gmail.com>
11271
11272 * lisp.h (VWindow_system, Qfile_name_history):
11273 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11274 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11275 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11276
11277 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11278 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11279
11280 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11281 * w32console.c (detect_input_pending, read_input_pending)
11282 (encode_terminal_code):
11283 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11284 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11285 (w32_system_caret_y, Qfile_name_history):
11286 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11287 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11288 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11289 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11290 * w32proc.c (Qlocal, report_file_error):
11291 * w32term.c (Vwindow_system, updating_frame):
11292 * w32uniscribe.c (initialized, uniscribe_font_driver):
11293 Remove unneeded extern declarations.
11294
2aa46d6c
CY
112952011-03-14 Chong Yidong <cyd@stupidchicken.com>
11296
c96bbc66 11297 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11298
cffc6f3b
CY
112992011-03-13 Chong Yidong <cyd@stupidchicken.com>
11300
11301 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11302 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11303 These macros can no longer be used for assignment.
11304
44f230aa
SM
11305 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11306 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11307 (record_buffer_markers, fetch_buffer_markers): New functions for
11308 recording and fetching special buffer markers.
11309 (set_buffer_internal_1, set_buffer_temp): Use them.
11310
11311 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11312
11313 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11314
11315 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11316 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11317
11318 * xdisp.c (hscroll_window_tree):
11319 (reconsider_clip_changes): Use PT instead of BUF_PT.
11320
d251f04b
EZ
113212011-03-13 Eli Zaretskii <eliz@gnu.org>
11322
11323 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11324 $(EMACS_ROOT)/lib/intprops.h.
11325
f0c77cd1
PE
113262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11327
3eca4629
PE
11328 Fix more problems found by GCC 4.5.2's static checks.
11329
7c86ee98
PE
11330 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11331 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11332 (xg_free_frame_widgets): Make it clear that a local variable is
11333 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11334 (gdk_window_get_screen): Make it clear that this macro is needed
11335 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11336 (int_gtk_range_get_value): New function, which avoids a diagnostic
11337 from gcc -Wbad-function-cast.
11338 (xg_set_toolkit_scroll_bar_thumb): Use it.
11339 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11340 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11341 (get_utf8_string, xg_get_file_with_chooser):
11342 Rename locals to avoid shadowing.
11343 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11344
41729b81
PE
11345 * xgselect.c (xg_select): Remove unused var.
11346
f0c77cd1
PE
11347 * image.c (four_corners_best): Mark locals as initialized.
11348 (gif_load): Initialize transparent_p to zero (Bug#8238).
11349 Mark another local as initialized.
ec6cf4c6 11350 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11351
ce0ad53d 11352 * image.c (clear_image_cache): Now static.
d5d5a617 11353 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11354 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11355 (x_edge_detection): Remove unnecessary cast that
11356 gcc -Wbad-function-cast diagnoses.
2037898d 11357 (gif_load): Fix pointer signedness.
6ae141d6
PE
11358 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11359 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11360
33383987 113612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11362
d32df629
PE
11363 Improve quality of tests for time stamp overflow.
11364 For example, without this patch (encode-time 0 0 0 1 1
11365 1152921504606846976) returns the obviously-bogus value (-948597
11366 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11367 reports time overflow. See
11368 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11369 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11370 * editfns.c: Include limits.h and intprops.h.
11371 (TIME_T_MIN, TIME_T_MAX): New macros.
11372 (time_overflow): Move earlier, to before first use.
11373 (hi_time, lo_time): New functions, for an accurate test for
11374 out-of-range times.
11375 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11376 (Fget_internal_run_time): Don't assume time_t fits in int.
11377 (make_time): Use list2 instead of Fcons twice.
11378 (Fdecode_time): More accurate test for out-of-range times.
11379 (check_tm_member): New function.
11380 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11381 (lisp_time_argument): Don't rely on undefined left-shift and
11382 right-shift behavior when checking for time stamp overflow.
8be6f318 11383
fe31d94c
PE
11384 * editfns.c (time_overflow): New function, refactoring common code.
11385 (Fformat_time_string, Fdecode_time, Fencode_time):
11386 (Fcurrent_time_string): Use it.
11387
8be6f318
PE
11388 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11389 * dired.c (make_time): Move to ...
11390 * editfns.c (make_time): ... here.
11391 * systime.h: Note the move.
11392
09d9db2c 113932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11394
126bc0dc
YM
11395 * fringe.c (update_window_fringes): Remove unused variables.
11396
c47cbdfd
YM
11397 * unexmacosx.c (copy_data_segment): Also copy __got section.
11398 (Bug#8223)
11399
7ac80be9
EZ
114002011-03-12 Eli Zaretskii <eliz@gnu.org>
11401
c96bbc66 11402 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11403 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11404 Constify `char *' arguments and their references according to
11405 prototypes in tparam.h.
11406
ecb0f94d 11407 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11408
7ac80be9
EZ
11409 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11410 Adapt all references accordingly.
11411
11412 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11413
ef1fd07e
TT
114142011-03-11 Tom Tromey <tromey@redhat.com>
11415
11416 * buffer.c (syms_of_buffer): Remove obsolete comment.
11417
7ef4b50c
EZ
114182011-03-11 Eli Zaretskii <eliz@gnu.org>
11419
11420 * termhooks.h (encode_terminal_code): Declare prototype.
11421
11422 * msdos.c (encode_terminal_code): Don't declare prototype.
11423
11424 * term.c (encode_terminal_code): Now external again, used by
11425 w32console.c and msdos.c.
11426
44f230aa
SM
11427 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11428 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11429
4b1ec863 114302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11431
1714f52b 11432 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11433
4b1ec863
PE
11434 * fringe.c (update_window_fringes): Mark locals as initialized
11435 (Bug#8227).
11436 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11437
524c7aa6
PE
11438 * alloc.c (mark_fringe_data): Move decl from here ...
11439 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11440 to check its interface.
11441 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11442
a5c0af81 11443 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11444 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11445 (fontset_font): Mark local as initialized.
a9a06e0b 11446 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11447
b4716021
PE
11448 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11449
811e9bac 11450 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11451 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11452 (x_own_selection, Fx_disown_selection_internal): Rename locals
11453 to avoid shadowing.
11454 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11455
7e3ab302
PE
11456 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11457 so that the caller can use some name other than gcpro1.
11458 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11459 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11460 (Fx_backspace_delete_keys_p):
11461 Use them to avoid shadowing, and rename vars to avoid shadowing.
11462 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11463 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11464 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11465 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11466 Remove unused locals.
7e3ab302
PE
11467 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11468 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11469 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11470 macros.
f78faa98 11471
e2b13473
PE
11472 * xterm.h (x_mouse_leave): New decl.
11473
77f23912
PE
11474 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11475 Remove unused functions.
cdf4ba58
PE
11476 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11477 (x_calc_absolute_position): Now static.
7411c686 11478 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11479 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11480 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11481 unless they are used.
38d0b34a
PE
11482 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11483 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11484 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11485 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11486 (x_error_catcher, x_connection_closed, x_error_handler):
11487 (x_error_quitter, xembed_send_message, x_iconify_frame):
11488 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11489 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11490 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11491
44f230aa
SM
11492 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11493 Rename or move locals to avoid shadowing.
6b463e58 11494 (tty_defined_color, merge_face_heights): Now static.
5967d051 11495 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11496 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11497 does not deduce is never used uninitialized.
73719eba
PE
11498 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11499 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11500
426994c3 11501 * terminal.c (store_terminal_param): Now static.
5489860b 11502
032f1620 11503 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11504 (set_frame_menubar): Remove unused local.
d4323972 11505 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11506 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11507 since they might point to immutable storage.
281585b0
PE
11508 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11509 since it's unused otherwise.
032f1620 11510
367c19e5 11511 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11512 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11513 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11514 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11515 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11516 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11517 does not deduce are never used uninitialized.
70739cbe 11518
07b48fa9
PE
11519 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11520
8868a238 11521 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11522 * window.c (window_loop, size_window):
11523 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11524
7e5cf297 11525 * window.c (display_buffer): Now static.
d6550a9f
PE
11526 (size_window): Mark variables that gcc -Wuninitialized
11527 does not deduce are never used uninitialized.
a586633d
PE
11528 * window.h (check_all_windows): New decl, to forestall
11529 gcc -Wmissing-prototypes diagnostic.
5b555da1 11530 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11531
f6095868
PE
11532 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11533 shadowing.
11534 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11535 Include <limits.h>.
11536 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11537 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11538 (load_charset_map): Mark variables that gcc -Wuninitialized
11539 does not deduce are never used uninitialized.
53df7c11 11540 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11541
f38b440c
PE
11542 * coding.c (coding_set_source, coding_set_destination):
11543 Use "else { /* comment */ }" rather than "else /* comment */;"
11544 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11545 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11546 a block, when the outer 'i' will do.
11547 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11548 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11549 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11550 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11551 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11552 Rename locals to avoid shadowing.
11553 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11554 * coding.c (emacs_mule_char, encode_invocation_designation):
11555 Now static, since they're not used elsewhere.
413bb2db 11556 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11557 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11558 (decode_coding_emacs_mule): Mark variables that gcc
11559 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11560 (detect_coding_iso_2022): Initialize a local variable that might
11561 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11562 this initialization is needed. (Bug#8211)
5f58e762
PE
11563 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11564 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11565 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11566 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11567 Remove unused macros.
f38b440c 11568
232b38b9 11569 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11570 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11571 * character.c (string_count_byte8): Likewise.
232b38b9 11572
fb90da1b
PE
11573 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11574 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11575
fb93dbc2
PE
11576 * chartab.c (copy_sub_char_table): Now static, since it's not used
11577 elsewhere.
5c156ace
PE
11578 (sub_char_table_ref_and_range, char_table_ref_and_range):
11579 Rename locals to avoid shadowing.
bbcd0949 11580 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11581
7d3b3862 11582 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11583 (BIDI_BOB): Remove unused macro.
7d3b3862 11584
6be7d3da
PE
11585 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11586 deduce are never used uninitialized.
c2ed9c8b 11587 * term.c (encode_terminal_code): Likewise.
6be7d3da 11588
75f8807f 11589 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11590
50938595
PE
11591 * tparam.h: New file.
11592 * term.c, tparam.h: Include it.
11593 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11594 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11595 Move these decls to tparam.h, and make them agree with what
11596 is actually in tparam.c. The previous trick of using incompatible
11597 decls in different modules does not conform to the C standard.
11598 All callers of tparam changed to use tparam's actual API.
11599 * tparam.c (tparam1, tparam, tgoto):
11600 Use const pointers where appropriate.
11601
fbceeba2
PE
11602 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11603 * cm.h (struct cm): Likewise.
11604 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11605 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11606 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11607 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11608 (turn_on_face, init_tty): Likewise.
11609 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11610
7f3f1250
PE
11611 * term.c (term_mouse_position): Rename local to avoid shadowing.
11612
e6ca6543
PE
11613 * alloc.c (mark_ttys): Move decl from here ...
11614 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11615
c40f8d15
AS
116162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11617
11618 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11619
cfe0661d
JB
116202011-03-09 Juanma Barranquero <lekktu@gmail.com>
11621
11622 * search.c (compile_pattern_1): Remove argument regp, unused since
11623 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11624 (compile_pattern): Don't pass it.
11625
0afb4571
J
116262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11627
11628 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11629 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11630 for ! HAVE_GTK3.
11631 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11632
11633 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11634
11635 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11636 gdk_window_get_screen, gdk_window_get_geometry,
11637 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11638 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11639 (xg_get_pixbuf_from_pixmap): New function.
11640 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11641 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11642 Call xg_get_pixbuf_from_pixmap instead of
11643 gdk_pixbuf_get_from_drawable.
11644 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11645 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11646 (xg_check_special_colors): Use GtkStyleContext and its functions
11647 for HAVE_GTK3.
11648 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11649 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11650 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11651 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11652 Call gtk_widget_get_preferred_size.
0afb4571
J
11653 (xg_frame_resized): gdk_window_get_geometry only takes 5
11654 parameters.
44f230aa
SM
11655 (xg_win_to_widget, xg_event_is_for_menubar):
11656 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11657 (xg_set_widget_bg): New function.
11658 (delete_cb): New function.
895009e1 11659 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11660 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11661 (xg_set_background_color): Call xg_set_widget_bg.
11662 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11663 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11664 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11665 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11666 if ! HAVE_GTK3.
11667 (update_frame_tool_bar): Call gtk_widget_hide.
11668 (xg_initialize): Use GDK_KEY_g.
11669
11670 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11671 if ! HAVE_GTK3
11672 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11673
11674 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11675 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11676 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11677
1c2cc4ef
JB
116782011-03-08 Juanma Barranquero <lekktu@gmail.com>
11679
11680 * w32xfns.c (select_palette): Check success of RealizePalette against
11681 GDI_ERROR, not zero.
11682
33383987 11683See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11684
11685;; Local Variables:
11686;; coding: utf-8
aac0c6e3
MR
11687;; End:
11688
2f097256 11689 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11690
11691 This file is part of GNU Emacs.
11692
11693 GNU Emacs is free software: you can redistribute it and/or modify
11694 it under the terms of the GNU General Public License as published by
11695 the Free Software Foundation, either version 3 of the License, or
11696 (at your option) any later version.
11697
11698 GNU Emacs is distributed in the hope that it will be useful,
11699 but WITHOUT ANY WARRANTY; without even the implied warranty of
11700 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11701 GNU General Public License for more details.
11702
11703 You should have received a copy of the GNU General Public License
11704 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.