Mainly resorting contributor list
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2375c96a
CY
12012-02-19 Chong Yidong <cyd@gnu.org>
2
3 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4 (Funhandled_file_name_directory, Ffile_name_as_directory)
5 (Fdirectory_file_name, Fexpand_file_name)
6 (Fsubstitute_in_file_name): Protect against invalid file handler
7 return values (Bug#10845).
8
3eb49e71
EZ
92012-02-18 Eli Zaretskii <eliz@gnu.org>
10
11 * .gdbinit (pitx): Fix incorrect references to fields of the
12 iterator stack.
13
7b926f3f
CY
142012-02-17 Chong Yidong <cyd@gnu.org>
15
16 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
17
11273115
PE
182012-02-15 Paul Eggert <eggert@cs.ucla.edu>
19
20 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
21 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
22
c3a70e2b
CY
232012-02-15 Chong Yidong <cyd@gnu.org>
24
25 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
26 marked as special. Also, starting docstrings with * is obsolete.
27
0ca43699
AS
282012-02-13 Andreas Schwab <schwab@linux-m68k.org>
29
30 * gnutls.c (emacs_gnutls_write): Fix last change.
31
2e8f3c56
LI
322012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
33
34 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
35 send_process.
36
af70074f
SM
372012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
38
39 * keymap.c (Fsingle_key_description): Handle char ranges.
40
95986d52
CY
412012-02-12 Chong Yidong <cyd@gnu.org>
42
afd83bd1
CY
43 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
44 as that creates a dangerous corner case.
45
95986d52
CY
46 * window.c (Fdelete_window_internal): Invalidate the mouse
47 highlight (Bug#9904).
48
bd7da63e
GM
492012-02-12 Glenn Morris <rgm@gnu.org>
50
51 * xselect.c (Fx_own_selection_internal)
52 (Fx_get_selection_internal, Fx_disown_selection_internal)
53 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
54 * nsselect.m (Fx_own_selection_internal)
55 (Fx_disown_selection_internal, Fx_selection_exists_p)
56 (Fx_selection_owner_p, Fx_get_selection_internal):
57 Sync docs and argument specs with the xselect.c versions.
58
77abcbc2
LI
592012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
60
61 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
62
90b671e2
EZ
632012-02-11 Eli Zaretskii <eliz@gnu.org>
64
1c0ca0b7
EZ
65 * w32select.c (Fx_selection_exists_p): Sync doc string and
66 argument list with xselect.c. (Bug#10783)
67
68 * w16select.c (Fx_selection_exists_p): Sync doc string and
69 argument list with xselect.c. (Bug#10783)
90b671e2 70
49241268
GM
712012-02-10 Glenn Morris <rgm@gnu.org>
72
73 * fns.c (Fsecure_hash): Doc fix.
74
f998bbe7 752012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
76
77 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
78
0992bd9c
CY
792012-02-07 Chong Yidong <cyd@gnu.org>
80
81 * buffer.c (Fbuffer_local_variables)
82 (buffer_lisp_local_variables): Handle unbound vars correctly;
83 don't let Qunbound leak into Lisp.
84
af008560
GM
852012-02-07 Glenn Morris <rgm@gnu.org>
86
dd605cc4
GM
87 * image.c (Fimagemagick_types): Doc fix.
88
af008560
GM
89 * image.c (imagemagick-render-type): Change it from a lisp object
90 to an integer. Move the doc here from the lisp manual.
91 Treat all values not equal to 0 the same.
92
1449fa1d
CY
932012-02-06 Chong Yidong <cyd@gnu.org>
94
95 * doc.c (store_function_docstring): Avoid applying docstring of
96 alias to base function (Bug#2603).
97
3723ec07
AS
982012-02-04 Andreas Schwab <schwab@linux-m68k.org>
99
100 * .gdbinit (pp1, pv1): Remove redundant defines.
101 (pr): Use pp.
102
79c1cc1e
CY
1032012-02-04 Chong Yidong <cyd@gnu.org>
104
105 * nsterm.m: Declare a global (Bug#10694).
106
d7f29f8e
EZ
1072012-02-04 Eli Zaretskii <eliz@gnu.org>
108
109 * w32.c (get_emacs_configuration_options): Include
110 --enable-checking, if specified, in the return value.
111
3b95a6f9
MR
1122012-02-04 Martin Rudalics <rudalics@gmx.at>
113
114 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
115 after rounding frame sizes. (Bug#9723)
116
d6fa96a6
EZ
1172012-02-04 Eli Zaretskii <eliz@gnu.org>
118
119 * keyboard.c (adjust_point_for_property): Don't position point
120 before BEGV. (Bug#10696)
121
df0b2940
PE
1222012-02-03 Paul Eggert <eggert@cs.ucla.edu>
123
124 Handle overflow when computing char display width (Bug#9496).
125 * character.c (char_width): Return EMACS_INT, not int.
126 (char_width, c_string_width): Check for overflow when
127 computing the width; this is possible now that individual
128 characters can have unbounded width. Problem introduced
129 by merge from Emacs 23 on 2012-01-19.
130
6bee44d6
MA
1312012-02-02 Michael Albinus <michael.albinus@gmx.de>
132
133 * dbusbind.c (Fdbus_register_method): Mention the return value
134 :ignore in the docstring.
135
44f92739
GM
1362012-02-02 Glenn Morris <rgm@gnu.org>
137
1b9f60cc
GM
138 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
139
44f92739
GM
140 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
141 Unconditionally set to t. (Bug#10673)
142 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
143 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
144 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
145
c5d3843c
KH
1462012-02-02 Kenichi Handa <handa@m17n.org>
147
148 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
149 0, do not call append_composite_glyph.
150
159462d4 1512012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
152
153 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
154 NULL (Bug#6988).
155 (x_produce_glyphs): If the component of a composition is a null
156 string, set it->pixel_width to 1 to avoid zero-width glyph.
157
78cef877
EZ
1582012-02-01 Eli Zaretskii <eliz@gnu.org>
159
160 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
161 first 2 arguments are identical. This makes inserting large
162 output from a subprocess an order of magnitude faster on
163 MS-Windows, where all sbrk'ed memory is always contiguous.
164
97897668
GM
1652012-01-31 Glenn Morris <rgm@gnu.org>
166
167 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 168 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
169 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
170
31fd3586
GM
1712012-01-29 Glenn Morris <rgm@gnu.org>
172
173 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
174
0e24a8b2
CY
1752012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
176
177 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
178
cc0adcb0
CY
1792012-01-28 Chong Yidong <cyd@gnu.org>
180
181 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
182
acc28cb9
CY
1832012-01-26 Chong Yidong <cyd@gnu.org>
184
9c69cfb7
CY
185 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
186
acc28cb9
CY
187 * search.c (Fsearch_forward, Fsearch_backward): Document negative
188 repeat counts (Bug#10507).
189
48da7392
GM
1902012-01-26 Glenn Morris <rgm@gnu.org>
191
192 * lread.c (syms_of_lread): Doc fix.
193
14af5f7f
CY
1942012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
195
196 * coding.c (encode_designation_at_bol): Change return value to
197 EMACS_INT.
198
0b21c100
CY
1992012-01-25 Chong Yidong <cyd@gnu.org>
200
201 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
202
3c2907f7
CY
2032012-01-21 Chong Yidong <cyd@gnu.org>
204
205 * floatfns.c (Fcopysign): Make the second argument non-optional,
206 since nil is not allowed anyway.
207
959ad23f
AS
2082012-01-21 Andreas Schwab <schwab@linux-m68k.org>
209
210 * process.c (read_process_output): Use p instead of XPROCESS (proc).
211 (send_process): Likewise.
212
34a02f46
MR
2132012-01-19 Martin Rudalics <rudalics@gmx.at>
214
215 * window.c (save_window_save, Fcurrent_window_configuration)
216 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
217 doc-strings.
218
1259009a 2192012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
220
221 * character.c (char_width): New function.
70d4fdf6
GM
222 (Fchar_width, c_string_width, lisp_string_width):
223 Use char_width (Bug#9496).
25ed9e61 224
6a6ee00d
MR
2252012-01-16 Martin Rudalics <rudalics@gmx.at>
226
227 * window.c (Vwindow_persistent_parameters): New variable.
228 (Fset_window_configuration, save_window_save): Handle persistent
229 window parameters.
230
c85efaf7
EZ
2312012-01-14 Eli Zaretskii <eliz@gnu.org>
232
233 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
234 thrashing the stack of the thread. (Bug#9087)
235
5944709e
PE
2362012-01-12 Paul Eggert <eggert@cs.ucla.edu>
237
238 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
239
e71f5d99
EZ
2402012-01-11 Eli Zaretskii <eliz@gnu.org>
241
242 * xdisp.c (rows_from_pos_range): Handle the case where the
243 highlight ends on a newline. (Bug#10464)
244 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
245 he end column for display of highlight that ends on a newline
246 before a R2L line.
247
ce316182
GM
2482012-01-11 Glenn Morris <rgm@gnu.org>
249
250 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
251 from load-path also when installation-directory is nil. (Bug#10208)
252
5b43da69
GM
2532012-01-10 Glenn Morris <rgm@gnu.org>
254
74cc8ff9
GM
255 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
256
7d8d6e4e
GM
257 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
258 Update template values to be closer to their typical values these days.
5b43da69 259
a0db8d43
EZ
2602012-01-09 Eli Zaretskii <eliz@gnu.org>
261
262 * xdisp.c (rows_from_pos_range): Accept additional argument
263 DISP_STRING, and accept any glyph in a row whose object is that
264 string as eligible for mouse highlight. Fixes mouse highlight of
265 display strings from overlays. (Bug#10464)
266
9a0115ab 2672012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 268
b9110d6a 269 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
270 * fileio.c (auto_saving_dir_umask): New static var.
271 (Fmake_directory_internal): Use it.
272 (do_auto_save_make_dir): Set it, instead of invoking chmod after
273 creating the directory. The old code temporarily assigns
274 too-generous permissions to the directory.
275 (do_auto_save_eh): Clear it.
b9110d6a 276 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
277 that the var is always cleared.
278
6c1bd3f3
EZ
2792012-01-07 Eli Zaretskii <eliz@gnu.org>
280
281 * search.c (scan_buffer): Pass character positions to
282 know_region_cache, not byte positions. (Bug#6540)
283
069d2b50
L
2842012-01-07 LynX <_LynX@bk.ru> (tiny change)
285
286 * w32.c (sys_rename): Report EXDEV when rename of a directory
287 fails because the target is on another logical disk. (Bug#10284)
288
75bf0d33
DB
2892012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
290
291 * xterm.c (x_embed_request_focus): New function.
292
293 * xterm.h: Add prototype.
294
295 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
296
1c6e5a32
GM
2972012-01-05 Glenn Morris <rgm@gnu.org>
298
299 * emacs.c (emacs_copyright): Update short copyright year to 2012.
300
651e947e
EZ
3012012-01-01 Eli Zaretskii <eliz@gnu.org>
302
303 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
304 Load gnutls_transport_set_lowat only if GnuTLS version is below
305 2.11.1.
306 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
307 GnuTLS versions below 2.11.1.
308
3778cdd8
AL
3092011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
310
311 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
312 to the doc string advising against its use for altering the way
313 windows are scrolled.
314
0e5317f7
KH
3152011-12-28 Kenichi Handa <handa@m17n.org>
316
317 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
318 coding-system ASCII compatible only when it does not produce BOM
319 on encoding (Bug#10383).
320
93d5ca1f
JD
3212011-12-26 Jan Djärv <jan.h.d@swipnet.se>
322
323 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
324 can scroll.
325 (create_and_show_popup_menu): Always use menu_position_func for
326 Gtk3 (Bug#10361).
327
ca22b785
AS
3282011-12-24 Andreas Schwab <schwab@linux-m68k.org>
329
330 * callint.c (Fcall_interactively): Don't truncate prompt string.
331
d048e1e6
EZ
3322011-12-23 Eli Zaretskii <eliz@gnu.org>
333
334 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
335 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 336 resumed from there (after widening). (Bug#10360)
d048e1e6 337
5ccaba1f
JD
3382011-12-22 Jan Djärv <jan.h.d@swipnet.se>
339
340 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
341
204ee57f
JD
3422011-12-21 Jan Djärv <jan.h.d@swipnet.se>
343
b81d40f0
JB
344 * nsterm.m (x_free_frame_resources):
345 Release f->output_data.ns->miniimage.
204ee57f
JD
346 (ns_index_color): Fix indentation. Do not retain
347 color_table->colors[i].
348
349 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
350 before returning.
351
352 * nsfns.m (x_set_background_color): Assign return value from
353 ns_index_color to face-background instead of NSColor*.
354 (ns_implicitly_set_icon_type): Fix indentation.
355 Change assignment in for loop to comparison.
356
357 * emacs.c (ns_pool): New variable.
358 (main): Assign ns_pool.
359 (Fkill_emacs): Call ns_release_autorelease_pool.
360
361 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
362 autorelease fdesc, release fdAttrs and tdict.
363 (ns_get_covering_families): Release charset.
364 (ns_findfonts): Release NSFontDescriptor created with new.
365 (ns_uni_to_glyphs): Fix indentation.
366 (setString): Release attrStr before assigning new value.
367
c803b2b7
JD
3682011-12-18 Jan Djärv <jan.h.d@swipnet.se>
369
678f4426
JD
370 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
371 and NS_IMPL_COCOA.
372 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
373 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
374
cd394be1 3752011-12-18 David Reitter <reitter@cmu.edu>
678f4426 376
5fecd5fc
JD
377 * nsterm.m (ns_term_init): Subscribe for notifications
378 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
379 to method trackingNotification in EmacsMenu.
380
381 * nsmenu.m (trackingMenu): New variable.
3771cb17 382 (trackingNotification): New method (from Aquamacs).
5fecd5fc 383 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 384 from Aquamacs (Bug#7030).
678f4426
JD
385
3862011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 387
c803b2b7
JD
388 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
389 (symbol_to_nsstring): Fix indentation.
390 (ns_symbol_to_pb): New function.
391 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
392 (Fns_rotate_cut_buffers_internal): Removed.
393 (Fns_store_selection_internal): Renamed from
394 Fns_store_cut_buffer_internal.
395 (ns_get_foreign_selection, Fx_own_selection_internal)
396 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
397 (Fns_get_selection_internal, Fns_store_selection_internal):
398 Use ns_symbol_to_pb and check if return value is nil.
399 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
400 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
401 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
402 renamed to Sns_store_selection_internal.
403 (ns_handle_selection_request): Move code to Fx_own_selection_internal
404 and remove this function.
405 (ns_handle_selection_clear): Remove, never used.
406 (Fx_own_selection_internal): Move code from ns_handle_selection_request
407 here.
408
e1b01a3a
KB
4092011-12-17 Ken Brown <kbrown@cornell.edu>
410
411 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
412 GID is unknown (Bug#10257).
413
2adb6e85
PE
4142011-12-17 Paul Eggert <eggert@cs.ucla.edu>
415
416 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
417 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
418 which caused a build failure on GNU/Linux IA-64. This problem was
419 introduced by my 2011-10-07 patch.
420
d1d7b339
JL
4212011-12-15 Juri Linkov <juri@jurta.org>
422
423 * image.c (imagemagick_error): New function. (Bug#10112)
424 (imagemagick_load_image): Comment out `MagickSetResolution' call.
425 Use `imagemagick_error' where ImageMagick functions return
426 `MagickFalse'.
427 (Fimagemagick_types): Add `Fnreverse' to return the list in the
428 proper order.
429
100d5755
KH
4302011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
431
432 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
433 fill background (Bug#8992).
434
454592a6
MR
4352011-12-13 Martin Rudalics <rudalics@gmx.at>
436
437 * window.c (Vwindow_combination_resize)
438 (Vwindow_combination_limit): Use t instead of non-nil in
439 doc-strings.
61d4b438
MR
440 (Vrecenter_redisplay): Add first sentence of doc-string on
441 separate line.
53524d93 442 (Frecenter): Fix doc-string typo.
454592a6 443
3633e3aa
KH
4442011-12-11 Kenichi Handa <handa@m17n.org>
445
446 * coding.c (Funencodable_char_position): Pay attention to the
447 buffer text relocation (Bug#9389).
448
7b9d523a
JD
4492011-12-10 Jan Djärv <jan.h.d@swipnet.se>
450
451 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
452 gtk_init (Bug#10100).
453
b73189c6
EZ
4542011-12-10 Eli Zaretskii <eliz@gnu.org>
455
456 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
457 IT->string is nil. (Bug#10263)
458
f7dfe5d6
JD
4592011-12-10 Jan Djärv <jan.h.d@swipnet.se>
460
83faebb4
JD
461 * nsterm.h (x_free_frame_resources): Declare.
462
f7dfe5d6
JD
463 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
464 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
465
466 * nsterm.h (ns_get_defaults_value): Declare.
467
468 * nsterm.m (ns_default): Call ns_get_defaults_value.
469
7cd4e72c
EZ
4702011-12-09 Eli Zaretskii <eliz@gnu.org>
471
472 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
473 (Bug#10170)
474
b34d7317
YM
4752011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
476
477 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
478 that where the value of an _OBJC_* symbol points to is in the .bss
479 section (Bug#10240).
480
76470ad1
KH
4812011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
482
483 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 484 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 485
745fff94
KH
4862011-12-08 Kenichi Handa <handa@m17n.org>
487
488 * ftfont.c (get_adstyle_property): Fix previous change
489 (Bug#10233).
490
6e44397c
JB
4912011-12-07 Juanma Barranquero <lekktu@gmail.com>
492
493 * w32.c (init_environment): If no_site_lisp, remove site-lisp
494 dirs from the default value of EMACSLOADPATH (bug#10208).
495
7efa6272
GM
4962011-12-07 Glenn Morris <rgm@gnu.org>
497
498 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
499 installation and source directories as well. (Bug#10208)
500
f6fc4d87
CY
5012011-12-06 Chong Yidong <cyd@gnu.org>
502
503 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
504
2bf26180
GM
5052011-12-06 Glenn Morris <rgm@gnu.org>
506
507 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
508 as an error, not just -1. (Bug#10217)
509
3a6ad4f0
CY
5102011-12-05 Chong Yidong <cyd@gnu.org>
511
512 * keyboard.c (process_special_events): New function.
513 (swallow_events, Finput_pending_p): Use it (Bug#10195).
514
75a3b399
PE
5152011-12-05 Paul Eggert <eggert@cs.ucla.edu>
516
517 * coding.c (encode_designation_at_bol): Don't use uninitialized
518 local variable (Bug#9318).
519
c3c9e25e
KH
5202011-12-05 Kenichi Handa <handa@m17n.org>
521
522 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
523 return Qnil (Bug#8046, Bug#10193).
524
5eb05ea3
KH
5252011-12-05 Kenichi Handa <handa@m17n.org>
526
527 * coding.c (encode_designation_at_bol): New args charbuf_end and
528 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
529 (coding_set_source): Return how many bytes coding->source was
530 relocated.
531 (coding_set_destination): Return how many bytes
532 coding->destination was relocated.
533 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
534 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
535
5362011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
537
538 * coding.c (CODING_CHAR_CHARSET_P): New macro.
539 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
540 macro (Bug#9318).
541
5422011-12-05 Andreas Schwab <schwab@linux-m68k.org>
543
544 The following changes are to fix Bug#9318.
545
a79703f5 546 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
547 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
548 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 549 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 550
7dbda6df
JB
5512011-12-05 Juanma Barranquero <lekktu@gmail.com>
552
553 * lisp.h (process_quit_flag): Fix external declaration.
554
6d5eb5b0
SM
5552011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
556
557 Don't macro-inline non-performance-critical code.
558 * eval.c (process_quit_flag): New function.
559 * lisp.h (QUIT): Use it.
560
a0c3fad0
JD
5612011-12-04 Jan Djärv <jan.h.d@swipnet.se>
562
563 * nsfns.m (get_geometry_from_preferences): New function.
564 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
565
6c07aac2
AS
5662011-12-04 Andreas Schwab <schwab@linux-m68k.org>
567
568 * emacs.c (Qkill_emacs): Define.
569 (syms_of_emacs): Initialize it.
570 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
571 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
572 (quit_throw_to_read_char): Add parameter `from_signal'.
573 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
574 * lisp.h (QUIT): Call Fkill_emacs if requested.
575
c052ead4
JD
5762011-12-03 Jan Djärv <jan.h.d@swipnet.se>
577
578 * widget.c (update_wm_hints): Return if wmshell is null.
579 (widget_update_wm_size_hints): New function.
580
581 * widget.h (widget_update_wm_size_hints): Declare.
582
583 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
584 widget_update_wm_size_hints (Bug#10104).
585
9e49252b
EZ
5862011-12-03 Eli Zaretskii <eliz@gnu.org>
587
588 * xdisp.c (handle_invisible_prop): If the invisible text ends just
589 before a newline, prepare the bidi iterator for consuming the
590 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 591 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 592
02b16839
JL
5932011-12-02 Juri Linkov <juri@jurta.org>
594
595 * search.c (Fword_search_regexp): New Lisp function created from
596 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
597 (Fword_search_backward, Fword_search_forward)
598 (Fword_search_backward_lax, Fword_search_forward_lax):
599 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
600 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
601
0068070e
SM
6022011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * fileio.c (Finsert_file_contents): Move after-change-function call
605 to before the "handled:" label, since all "goto handled" appear in
606 cases where the *-change-functions have already been properly called
607 (bug#10117).
608
3360a3fc
AS
6092011-12-01 Andreas Schwab <schwab@linux-m68k.org>
610
611 * keyboard.c (interrupt_signal): Don't call kill-emacs when
612 waiting for input. (Bug#10169)
613
73d6c093
EZ
6142011-11-30 Eli Zaretskii <eliz@gnu.org>
615
616 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
617 verifies glyph row's hash code--we have just reallocated the
618 glyphs, so their contents can be complete garbage. (Bug#10164)
619
febe6bea
JB
6202011-11-30 Juanma Barranquero <lekktu@gmail.com>
621
622 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
623
801a4313
EZ
6242011-11-30 Eli Zaretskii <eliz@gnu.org>
625
626 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
627 attributes are tested _before_ calling verify_row_hash, to protect
628 against GCC re-ordering of the tests. (Bug#10164)
629
2b56b87e
JD
6302011-11-29 Jan Djärv <jan.h.d@swipnet.se>
631
632 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
633
634 * xterm.c (handle_one_xevent): Only set async_visible and friends
635 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 636 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
637 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
638
dbf31225
PE
6392011-11-28 Paul Eggert <eggert@cs.ucla.edu>
640
641 Remove GCPRO-related macros that exist only to avoid shadowing locals.
642 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
643 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
644 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
645 All uses changed to use GCPRO1 etc.
646 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
647 Revert to old implementation (i.e., before 2011-03-11).
648
1305621b
YM
6492011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
650
651 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
652 of scroll runs so as to avoid assigning disabled bogus rows and
653 unnecessary graphics copy operations.
654
8c9afb46
EZ
6552011-11-27 Eli Zaretskii <eliz@gnu.org>
656
657 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
658 (snprintf) [_MSC_VER]: Redirect to _snprintf.
659 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
660 (malloc, free, realloc, calloc): Redirect to e_* only when
661 compiling Emacs.
662
663 * lisp.h (GCTYPEBITS): Move before first use.
664 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
665 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
666 this macro definition.
667
668 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
669 _MSC_VER.
670
54e9e3bf
JD
6712011-11-27 Jan Djärv <jan.h.d@swipnet.se>
672
6d5eb5b0
SM
673 * gtkutil.c (xg_create_frame_widgets):
674 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
675 present with Gtk+ 2.0.
676
83aca1cb
PE
6772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
678
679 * fileio.c (Finsert_file_contents): Undo previous change; see
680 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
681
5b76caa4
PE
6822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
683
684 Rename locals to avoid shadowing.
685 * fileio.c (Finsert_file_contents):
686 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
687 * process.c (wait_reading_process_output):
688 Rename inner 'proc' to 'p' to avoid shadowing.
689 Indent for consistency with usual Emacs style.
690
8c535114
EZ
6912011-11-25 Eli Zaretskii <eliz@gnu.org>
692
693 * xdisp.c (redisplay_window): If cursor row is not fully visible
694 after recentering, and scroll-conservatively is set to a large
695 number, scroll window by a few more lines to make the cursor fully
696 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
697 (start_display): Don't move to the next line if the display should
698 start at a newline that is part of a display vector or an overlay
699 string. (Bug#10119)
8c535114 700
fa4fdb5c
JL
7012011-11-24 Juri Linkov <juri@jurta.org>
702
703 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
704 after the `MagickPingImage' call. (Bug#10112)
705
90ec88df
CY
7062011-11-23 Chong Yidong <cyd@gnu.org>
707
708 * window.c (Fcoordinates_in_window_p): Accept only live windows.
709
56e2e794
MR
7102011-11-23 Martin Rudalics <rudalics@gmx.at>
711
712 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
713 making another buffer current. (Bug#10114)
714
b6e64c41
GM
7152011-11-23 Glenn Morris <rgm@gnu.org>
716
717 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
718
6b21de18
CY
7192011-11-23 Chong Yidong <cyd@gnu.org>
720
721 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
722 using it (Bug#5984).
723
b12cd789
EZ
7242011-11-22 Eli Zaretskii <eliz@gnu.org>
725
726 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
727 and header-lines, as they don't have one computed for them.
728 (Bug#10098)
729
730 * .gdbinit (prow): Make displayed values more self-explaining.
731 Add row's hash code.
732
261b6fd4
LMI
7332011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
734
735 * process.c (wait_reading_process_output): Fix asynchrounous
736 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 737 (wait_reading_process_output): Add comment and URL.
261b6fd4 738
e7cfd277
JD
7392011-11-21 Jan Djärv <jan.h.d@swipnet.se>
740
741 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
742
a9b9b7f5
CY
7432011-11-21 Chong Yidong <cyd@gnu.org>
744
745 * window.c (Fnext_window, Fprevious_window): Doc fix.
746
b0d15b4f
SM
7472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
748
749 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
750
fe7a3057
JB
7512011-11-20 Juanma Barranquero <lekktu@gmail.com>
752
753 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
754
d2999b1a
MR
7552011-11-20 Martin Rudalics <rudalics@gmx.at>
756
757 * window.c (Fset_window_combination_limit): Rename argument
758 STATUS to LIMIT.
759 (Vwindow_combination_limit): Remove "status" from doc-string.
760
d5ff9cd0
AS
7612011-11-20 Andreas Schwab <schwab@linux-m68k.org>
762
763 * m/ibms390.h: Remove.
764 * m/ibms390x.h: Don't include "ibms390.h".
765
a5bb9bd3
SM
7662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
769 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
770
cd1181db
JB
7712011-11-20 Juanma Barranquero <lekktu@gmail.com>
772
773 * casetab.c (Fset_case_table):
774 * charset.c (Fcharset_after): Fix typos.
775
615a3b8d 7762011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 777
17e845af
PE
778 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
779 Otherwise, valgrind does not work on some platforms.
780 Problem reported by Andreas Schwab in
6a0bf43d
PE
781 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
782 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
783 is set, removing the need for VIRT_ADDRESS_VARIES.
784 (PURE_P): Use a more-efficient implementation that needs just one
785 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
786 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
787 to 4 (xorl, subq, cmpq, setbe).
788 * alloc.c (pure): Always extern now, since that's the
789 VIRT_ADDR_VARIES behavior.
790 (PURE_POINTER_P): Use a single comparison, not two, for
791 consistency with the new puresize.h.
792 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
793 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
794 Remove VIRT_ADDR_VARIES no longer needed.
795
f8fe6f96
EZ
7962011-11-19 Eli Zaretskii <eliz@gnu.org>
797
798 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
799 (erase_phys_cursor, update_window_cursor, show_mouse_face)
800 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
801 behave as if the cursor position were at the window margin.
802
803 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
804 and the cursor position is out of bounds, behave as if the cursor
805 position were at the window margin. (Bug#10075)
806
df05a53c
CY
8072011-11-18 Chong Yidong <cyd@gnu.org>
808
809 * window.c (Fwindow_combination_limit): Make first argument
810 non-optional, since it is meaningless for live windows like the
811 selected window.
812
2071918e
DA
8132011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
814
815 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
816
b50a28de
SM
8172011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * intervals.c: Fix grafting over the whole buffer (bug#10071).
820 (graft_intervals_into_buffer): Simplify.
821
015137db
EZ
8222011-11-18 Eli Zaretskii <eliz@gnu.org>
823
824 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
825 hash values of the two rows.
826 (copy_row_except_pointers): Preserve the used[] arrays and the
827 hash values of the two rows. (Bug#10035)
68c95424 828 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
829
830 * xdisp.c (row_hash): New function, body extracted from
831 compute_line_metrics.
832 (compute_line_metrics): Call row_hash, instead of computing the
833 hash code inline.
834
835 * dispnew.c (verify_row_hash): Call row_hash for computing the
836 hash code of a row, instead of duplicating code from xdisp.c.
837
838 * dispextern.h (row_hash): Add prototype.
839
a2addb04
TH
8402011-11-18 Tassilo Horn <tassilo@member.fsf.org>
841
842 * frame.c (delete_frame): Don't delete the terminal when the last
843 X frame is closed if emacs is built with GTK toolkit.
844
df85d315
JB
8452011-11-17 Juanma Barranquero <lekktu@gmail.com>
846
847 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
848
a0c2d0ae
MR
8492011-11-17 Martin Rudalics <rudalics@gmx.at>
850
851 * window.c (Vwindow_splits): Rename to
852 Vwindow_combination_resize. Suggested by Juri Linkov.
853 (Fsplit_window_internal): Use Vwindow_combination_resize instead
854 of Vwindow_splits.
855
58179cce
JB
8562011-11-16 Juanma Barranquero <lekktu@gmail.com>
857
7877f373
JB
858 * nsfns.m (Fns_font_name):
859 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 860
b6f67890
MR
8612011-11-16 Martin Rudalics <rudalics@gmx.at>
862
863 * window.h (window): Rename slot "nest" to "combination_limit".
864 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
865 (Fset_window_nest): Rename to Fset_window_combination_limit.
866 (Vwindow_nest): Rename to Vwindow_combination_limit.
867 (recombine_windows, make_parent_window, make_window)
868 (Fsplit_window_internal, saved_window)
869 (Fset_window_configuration, save_window_save): Rename all
870 occurrences of window_nest to window_combination_limit.
871
c7015153
JB
8722011-11-15 Juanma Barranquero <lekktu@gmail.com>
873
874 * image.c (imagemagick_load_image): Fix typo.
875
322ad6ec
EZ
8762011-11-14 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (display_line): Move the call to
879 highlight_trailing_whitespace before the call to
880 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
881 faces of all the glyphs to compute ROW's hash value.
882 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 883
f067b8ec
JB
8842011-11-14 Juanma Barranquero <lekktu@gmail.com>
885
886 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
887 just return (bug#10044).
888
1e5b2111
EZ
8892011-11-12 Eli Zaretskii <eliz@gnu.org>
890
7ef3cbd5
EZ
891 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
892 with user-defined heap size. Bump the default size of the temacs
893 heap to 27MB, to avoid memory warning when running temacs.
894 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
895
1e5b2111
EZ
896 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
897 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
898 (verify_row_hash) [XASSERTS]: New function.
899 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
900 that the hash value of glyph rows is correct.
1e5b2111 901
89d61221
MR
9022011-11-12 Martin Rudalics <rudalics@gmx.at>
903
904 * window.h (window): Remove splits slot.
905 * window.c (Fwindow_splits, Fset_window_splits): Remove.
906 (Fdelete_other_windows_internal, make_parent_window)
907 (make_window, Fsplit_window_internal, Fdelete_window_internal)
908 (Fset_window_configuration, save_window_save): Don't deal with
909 split status of windows.
910 (saved_window): Remove splits slot.
911 (Vwindow_splits): Rewrite doc-string.
912
97f18cc8
JD
9132011-11-11 Jan Djärv <jan.h.d@swipnet.se>
914
915 * xfns.c (unwind_create_frame):
916 * nsfns.m (unwind_create_frame):
917 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
918 Vframe_list (Bug#9999).
919
22a648b4
DA
9202011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
921
0b381c7e 922 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 923
659afede
KH
9242011-11-11 Kenichi Handa <handa@m17n.org>
925
926 * callproc.c (Fcall_process): Set the member dst_multibyte of
927 process_coding.
928
9ac0394b
KH
9292011-11-11 Johan Bockgård <bojohan@gnu.org>
930
931 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
932 avoid a crash (bug#9496).
933
2fbdc249
CY
9342011-11-09 Chong Yidong <cyd@gnu.org>
935
936 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
937 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
938
ac6b1f81
PE
9392011-11-08 Paul Eggert <eggert@cs.ucla.edu>
940
941 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
942
09db192c
PE
9432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
944
945 Avoid some portability problems by eschewing 'extern inline' functions.
946 The trivial performance wins aren't worth the portability hassles; see
947 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
948 et seq.
949 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
950 (window_box_width, window_box_left, window_box_left_offset)
951 (window_box_right, window_box_right_offset): Undo previous change,
952 by removing the "extern"s.
953 * intervals.c (adjust_intervals_for_insertion)
954 (adjust_intervals_for_deletion): Undo previous change,
955 making these static again.
956 (offset_intervals, temp_set_point_both, temp_set_point)
957 (copy_intervals_to_string): No longer inline.
958 * xdisp.c (window_text_bottom_y, window_box_width)
959 (window_box_height, window_box_left_offset)
960 (window_box_right_offset, window_box_left, window_box_right)
961 (window_box): No longer inline.
962
105216ed
CY
9632011-11-08 Chong Yidong <cyd@gnu.org>
964
965 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
966 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
967 Signal an error if not a live window.
105216ed
CY
968 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
969 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
970
ae9e237f
JB
9712011-11-07 Juanma Barranquero <lekktu@gmail.com>
972
973 * lisp.h (syms_of_abbrev): Remove declaration.
974 Reported by CHENG Gao <chenggao@royau.me>.
975
c7aa8333
EZ
9762011-11-07 Eli Zaretskii <eliz@gnu.org>
977
978 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
979 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
980 of temacs in GUI mode.
981
be7f5545
MR
9822011-11-07 Martin Rudalics <rudalics@gmx.at>
983
984 * window.h: Declare delete_all_child_windows instead of
985 delete_all_subwindows.
986 * window.c (Fwindow_nest, Fset_window_nest)
987 (Fset_window_new_total, Fset_window_new_normal)
988 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
989 (delete_all_subwindows): Rename to delete_all_child_windows.
990 (Fdelete_other_windows_internal, Fset_window_configuration):
991 Call delete_all_child_windows instead of delete_all_subwindows.
992 * frame.c (delete_frame): Call delete_all_child_windows instead
993 of delete_all_subwindows.
994
ca78dc43
PE
9952011-11-07 Paul Eggert <eggert@cs.ucla.edu>
996
997 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
998 This is also needed for porting to any host where GC_MARK_STACK is
999 not GC_MAKE_GCPROS_NOOPS.
1000 (which_symbols): Use it.
1001
a0241d01
KH
10022011-11-07 Kenichi Handa <handa@m17n.org>
1003
1004 * coding.c (coding_set_destination): Check coding->src_pos only
1005 when coding->src_object is a buffer (bug#9910).
1006
1007 * process.c (send_process): Set the member src_multibyte of coding
1008 to 0 (bug#9911) when sending a unibyte text.
1009
1010 * callproc.c (Fcall_process): Set the member src_multibyte of
1011 process_coding to 0 (bug#9912).
1012
a64bfdfa 10132011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1014
1015 * xmenu.c (cleanup_widget_value_tree): New function.
1016 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1017 calling free_menubar_widget_value_tree directly (Bug#9830).
1018
cb41b32a
PE
10192011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 Fix some portability problems with 'inline'.
1022 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1023 (window_box_width, window_box_left, window_box_left_offset)
1024 (window_box_right, window_box_right_offset): Declare extern.
1025 Otherwise, these inline functions do not conform to C99 and
1026 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1027 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1028 * intervals.c (adjust_intervals_for_insertion)
1029 (adjust_intervals_for_deletion): Now extern, because otherwise the
1030 extern inline functions 'offset_intervals' couldn't refer to it.
1031 (static_offset_intervals): Remove.
1032 (offset_intervals): Rewrite using the old contents of
1033 static_offset_intervals. The old version didn't conform to C99
1034 because an extern inline function contained a reference to an
1035 identifier with static linkage.
1036
b7041366
AS
10372011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1038
1039 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1040 GC.
1041
88a37c4d
EZ
10422011-11-06 Eli Zaretskii <eliz@gnu.org>
1043
1044 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1045 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1046 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1047 return Qleft_to_right.
1048
49745b39
CY
10492011-11-06 Chong Yidong <cyd@gnu.org>
1050
1051 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1052 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1053 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1054 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1055 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1056 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1057 (Fwindow_vscroll): Doc fix.
1058 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1059 argument, since it makes no sense to pass a live window and for
1060 consistency with window-child.
1061
1f05cd82
CS
10622011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1063
1064 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1065 support MSVC.
1066
22610910
JR
10672011-11-05 Jason Rumney <jasonr@gnu.org>
1068
1069 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1070 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1071 fonts (Bug#6029).
1072 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1073 bitwise arithmetic preventing use of unicode-sip and non-truetype
1074 opentype fonts.
1075
a06776b2
EZ
10762011-11-05 Eli Zaretskii <eliz@gnu.org>
1077
3ad924ba
EZ
1078 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1079 "emacs"-only part.
1080
a06776b2
EZ
1081 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1082 initialization code to keep similarity to xfns.c after changes
1083 from 2011-11-05.
1084
c9e7db78
JD
10852011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1086
a97f8f3f
JD
1087 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1088 (unwind_create_frame): New function (Bug#9943).
1089 (Fx_create_frame): Restructure code to be more similar to the one in
1090 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1091 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1092 Move terminal->reference_count++ just before making the frame official
1093 (Bug#9943).
1094
1095 * nsterm.m (x_free_frame_resources): New function.
1096 (x_destroy_window): Move code to x_free_frame_resources.
1097
c9e7db78 1098 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1099 (Fx_create_frame, x_create_tip_frame):
1100 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1101 official. Move initialization of image_cache_refcount and
1102 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1103
a6fc3b5c
EZ
11042011-11-05 Eli Zaretskii <eliz@gnu.org>
1105
1106 Support MSVC build with newer versions of Visual Studio.
1107 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1108 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1109 nt/gmake.defs.
1110
1111 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1112 which are not supported by MSVC.
1113 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1114 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1115 bitfields.
1116 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1117 types in bitfields.
1118 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1119
1120 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1121
58179cce 11222011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1123
1124 Support MSVC build with newer versions of Visual Studio.
1125 * w32.c: Don't include w32api.h for MSVC.
1126 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1127
1128 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1129 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1130 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1131 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1132 e_* cousins.
1133 (alloca) [_MSC_VER]: Define to _alloca.
1134
1135 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1136
1137 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1138
a58c13ed
EZ
11392011-11-04 Eli Zaretskii <eliz@gnu.org>
1140
1141 * xdisp.c (note_mouse_highlight): If either of
1142 previous/next-single-property-change returns nil, treat that as
1143 the beginning or the end of the buffer. (Bug#9955)
1144
fe0b6370
JD
11452011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1146
a58c13ed 1147 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1148 label is not null (Bug#9951).
1149 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1150 may be NULL.
1151
89bd5ee1
EZ
11522011-11-04 Eli Zaretskii <eliz@gnu.org>
1153
1154 * window.c (Fwindow_body_size): Mention in the doc string that the
1155 return value is in frame's canonical units. (Bug#9949)
1156
84c3edb9
EZ
11572011-11-03 Eli Zaretskii <eliz@gnu.org>
1158
4e2fb5c7
EZ
1159 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1160
84c3edb9 1161 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1162 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1163 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1164
bc17a887
EZ
11652011-11-01 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1168 Don't stop backward scan on the continuation glyph, even though
1169 its CHARPOS is positive.
6d5eb5b0
SM
1170 (mouse_face_from_buffer_pos, note_mouse_highlight):
1171 Rename cover_string to disp_string.
bc17a887 1172
4ee88440
MR
11732011-11-01 Martin Rudalics <rudalics@gmx.at>
1174
1175 * window.c (temp_output_buffer_show): Don't use
1176 Vtemp_buffer_show_specifiers.
1177 (Vtemp_buffer_show_specifiers): Remove unused variable.
1178
c2ff3c02
EZ
11792011-10-30 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1182 past the beginning of the current glyph matrix.
1183
58179cce 11842011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1185
1186 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1187 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1188 HAVE_GTK3 (Bug#9869).
b77a6a7f 1189
3b574623
JD
1190 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1191 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1192
b77a6a7f
JD
1193 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1194
1195 * xterm.c: Declare x_handle_net_wm_state to return int.
1196 (handle_one_xevent): Check if we are iconified but don't have
1197 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1198 (get_current_wm_state): Return non-zero if not hidden,
1199 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1200 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1201 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1202 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1203
196e41e4
PE
12042011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1207 so that this new function doesn't get optimized away by a
1208 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1209
021f2e1a
AS
12102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1211
1212 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1213
8b058d44
EZ
12142011-10-29 Eli Zaretskii <eliz@gnu.org>
1215
1216 Fix the `xbytecode' command.
1217 * .gdbinit (xprintbytestr): New command.
b50a28de 1218 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1219 (xbytecode): Print the byte-code string as well.
1220
4452fb80
EZ
12212011-10-29 Kim Storm <storm@cua.dk>
1222
8b058d44
EZ
1223 * alloc.c (which_symbols): New function.
1224
21b72067
AS
12252011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1226
1227 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1228 line. (Bug#9903)
1229
83ed7b5c
GM
12302011-10-29 Glenn Morris <rgm@gnu.org>
1231
1232 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1233 Not clear what it was for, and it causes various bugs. (Bug#9839)
1234
5a7a728b
EZ
12352011-10-28 Eli Zaretskii <eliz@gnu.org>
1236
1237 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1238 possible random value that matches one of those tested as
1239 condition to clear the mouse face.
1240
d3d0842f
CY
12412011-10-28 Chong Yidong <cyd@gnu.org>
1242
1243 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1244
31b39d13
DN
12452011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1246
1247 * window.c (make_window): Initialize phys_cursor_on_p.
1248
9aba6043
SM
12492011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1250
1251 * lisp.h (struct Lisp_Symbol): Update comments.
1252
c20992f4
JB
12532011-10-28 Juanma Barranquero <lekktu@gmail.com>
1254
1255 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1256
db4f02f2
EZ
12572011-10-28 Eli Zaretskii <eliz@gnu.org>
1258
1259 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1260 <oslsachem@gmail.com> for helping to debug this.
1261
1262 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1263 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1264 (g_b_init_get_glyph_outline_w): New static variables.
1265 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1266 (GetGlyphOutlineW_Proc): New typedefs.
1267 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1268 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1269 New functions.
1270 (w32font_open_internal, compute_metrics):
1271 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1272 instead of calling the "wide" APIs directly.
1273
1274 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1275
1276 * w32.h (syms_of_w32font): Add prototype.
1277
87e68db4
JB
12782011-10-27 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1281 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1282 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1283 (Fmove_to_window_line): Doc fix.
1284
435c1d67
CY
12852011-10-27 Chong Yidong <cyd@gnu.org>
1286
1287 * process.c (make_process): Set gnutls_state to NULL.
1288
1289 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1290 non-NULL, regardless of GNUTLS_INITSTAGE.
1291 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1292 an error. Set process slots as soon as we allocate them.
1293
1294 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1295
9c6c6f49
CY
12962011-10-27 Chong Yidong <cyd@gnu.org>
1297
9aba6043
SM
1298 * gnutls.c (emacs_gnutls_deinit): New function.
1299 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1300 (Fgnutls_deinit, Fgnutls_boot): Use it.
1301
1302 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1303 (deactivate_process): Call emacs_gnutls_deinit.
1304
657d08d3
JB
13052011-10-27 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * image.c (x_create_x_image_and_pixmap):
1308 * w32.c (sys_rename, w32_delayed_load):
1309 * w32font.c (fill_in_logfont):
1310 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1311
5430d399
JB
13122011-10-26 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * w32fns.c (w32_default_color_map): New function,
1315 extracted from Fw32_default_color_map.
a7ef684b 1316 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1317
fe0055fa
PE
13182011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1321
e6346438
SM
13222011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1323
1324 * keyboard.c (test_undefined): New function (bug#9751).
1325 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1326
e112cc37
ET
13272011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1328
1329 * sysdep.c (init_sys_modes): Fix the check for the controlling
1330 terminal (Bug#6649).
1331
7b5d6677
EZ
13322011-10-20 Eli Zaretskii <eliz@gnu.org>
1333
1334 * dispextern.h (struct bidi_it): New member next_en_type.
1335
1336 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1337 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1338 current character, check also for next_en_type being WEAK_EN.
1339 (bidi_resolve_weak): Don't enter the expensive loop if the current
1340 position is before next_en_pos. Record the bidi type of the first
1341 non-ET, non-BN character we find, in addition to its position.
1342 (bidi_level_of_next_char): Invalidate next_en_type when
1343 next_en_pos is over-stepped.
1344
7da0b018
PE
13452011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1348 * editfns.c: Rewrite current-time-zone so that it invokes
1349 the equivalent of (format-time-string "%Z") to get the time zone name.
1350 This fixes a bug when the time zone name contains characters that
1351 need converting from the system time locale to Emacs internal format.
1352 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1353 that patch fixed format-time-string to do the conversion, but
1354 I forgot to fix current-time-zone.
1355 (format_time_string): New function, containing most of
1356 what Fformat_time_string used to contain.
1357 (Fformat_time_string): Rewrite in terms of format_time_string.
1358 This doesn't change this function's behavior.
1359 (current-time-zone): Rewrite to use format_time_string.
1360 This fixes the bug reported by Michael Schierl in
1361 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1362 Jason Rumney's 2007-06-07 change worked around this bug, but
1363 didn't fix it.
1364 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1365
8547b010
EZ
13662011-10-19 Eli Zaretskii <eliz@gnu.org>
1367
1368 * xdisp.c (start_display): If the character at POS is displayed
1369 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1370 (try_window_reusing_current_matrix): If a line ends in a display
1371 vector or the next line starts in a display vector, continue
1372 redrawing the window even though the character position of
1373 start_row was reached.
8547b010
EZ
1374 (Bug#9771, part 2)
1375
4e948d15
CY
13762011-10-18 Chong Yidong <cyd@gnu.org>
1377
1378 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1379 with nobreak-char-display too.
1380
4787455f
EZ
13812011-10-18 Eli Zaretskii <eliz@gnu.org>
1382
1383 Fix part 3 of bug#9771.
1384 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1385 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1386 non-neutral characters if the current character is a paragraph
1387 separator (a.k.a. Newline). This avoids running the same
1388 expensive loop twice, once when we consume the preceding newline
1389 and the other time when the line actually needs to be displayed.
1390 Avoid the loop when we see neutrals on the base embedding level
1391 following a character whose directionality is the same as the
1392 paragraph's. This avoids running the expensive loop when a line
1393 ends in a long sequence of neutrals, like control characters.
1394 Add assertion against STRONG_AL type. Slightly rearrange code
1395 that determines the type of a neutral given the first non-neutral
1396 that follows it.
1397 (bidi_level_of_next_char): Set next_en_pos to zero when
1398 invalidating its info.
1399
2c91f553
EZ
14002011-10-17 Eli Zaretskii <eliz@gnu.org>
1401
1402 * xdisp.c (push_display_prop): Determine whether to record string
1403 or buffer position by IT->string, not by IT->method. Allow
1404 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1405 (move_it_vertically_backward): Don't look for character position
1406 immediately after the newline when in a continuation line.
1407 (Bug#9771, part 1)
2c91f553 1408
c7b08b0d
MR
14092011-10-15 Martin Rudalics <rudalics@gmx.at>
1410
1411 * window.c (coordinates_in_window): Rewrite and delabelize
1412 vertical border check. (Bug#5357) (Bug#9618)
1413
6b02f655
SM
14142011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1415
1416 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1417 errors in XSetWindowBorder (bug#9310).
1418
81d40c92
DA
14192011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1420
1421 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1422 avoid crash when xmalloc overrun checking is enabled.
1423
d4172c3b
EZ
14242011-10-13 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1427 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1428 cursor motion with <left> and <right> arrow keys.
1429
1430 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1431 some callers set that themselves.
1432
b00eea75
EZ
14332011-10-12 Eli Zaretskii <eliz@gnu.org>
1434
1435 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1436 display string and the previous row comes from the same string and
1437 is empty. (Bug#9739) (Bug#9738)
1438
8fe012c4
SM
14392011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1440
1441 * doc.c (get_doc_string): Encode file name (bug#9735).
1442
0074aef2
EZ
14432011-10-12 Eli Zaretskii <eliz@gnu.org>
1444
79beb178
EZ
1445 * bidi.c (bidi_level_of_next_char):
1446 * xdisp.c (get_visually_first_element): Remove old incorrect
1447 comments regarding the Unicode Line Separator character.
1448
0074aef2
EZ
1449 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1450
6e4b3fbe
DA
14512011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 * alloc.c (Fgc_status): Do not access beyond zombies array
1454 boundary if nzombies > MAX_ZOMBIES.
1455 * alloc.c (dump_zombies): Add missing format specifier.
1456
0324f3af
PE
14572011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1458
b5525cac
PE
1459 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1460 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1461
0324f3af
PE
1462 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1463 Some packages use them to denote characters with modifiers.
1464
e9b5f888
AS
14652011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1466
1467 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1468 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1469 matching a pp-number. Rename parameter var to var1.
1470
127827c0
SM
14712011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1472
1473 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1474
c8fd3bd0
GM
14752011-10-08 Glenn Morris <rgm@gnu.org>
1476
1477 * callint.c (Fcall_interactively): Give a more explicit error for the
1478 'c' case with a non-character input. (Bug#8479)
1479
352ec8ff
EZ
14802011-10-08 Eli Zaretskii <eliz@gnu.org>
1481
03669ccb
EZ
1482 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1483 lines.
7061c986
EZ
1484 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1485 lines that are hscrolled on the left.
03669ccb 1486
352ec8ff
EZ
1487 * dispnew.c (buffer_posn_from_coords): Account for a possible
1488 presence of header-line. (Bug#4426)
1489
a66cfb1c
SM
14902011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1491
6b02f655
SM
1492 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1493 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1494
7c5ee88e
PE
14952011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1496
1497 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1498 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1499 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1500 this makes Emacs dump core during garbage collection on rare
1501 occasions. sizeof is obviously inferior to offsetof here, so
1502 stick with offsetof.
1503 (GC_POINTER_ALIGNMENT): New macro.
1504 (mark_memory): Omit 3rd (offset) arg; caller changed.
1505 Don't assume EMACS_INT alignment is the same as pointer alignment.
1506
df1bbe5b
SM
15072011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1508
1509 * keyboard.c (read_key_sequence_remapped): New var.
1510 (read_key_sequence): Compute remapping in the right buffer.
1511 (command_loop_1): Use read_key_sequence's remapping directly.
1512
51553db6
SM
15132011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1514
32c1fffd
SM
1515 * dired.c (file_name_completion): Don't expand file name.
1516 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1517 before checking file name handler.
1518
51553db6
SM
1519 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1520 they've been requested explicitly (bug#9591).
1521
b6bd1599 15222011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1523
1524 * keymap.c (Fsingle_key_description): Use make_specified_string
1525 instead of build_string to build string from push_key_description.
1526 (Bug#5193)
1527
f701dc2a
PE
15282011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1529
4222c55d
PE
1530 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1531 This fixes a Y2038 bug on 64-bit hosts.
1532 * buffer.c (reset_buffer):
1533 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1534 (Fclear_buffer_auto_save_failure):
1535 Use 0, not -1, to represent an unset failure time, since time_t
1536 might not be signed.
1537
f701dc2a
PE
1538 Remove dependency on glibc malloc internals.
1539 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1540 Move back here from lisp.h, but with their new implementations.
1541 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1542 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1543 * charset.c (charset_table_init): New static var.
1544 (syms_of_charset): Use it instead of xmalloc. This removes a
1545 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1546 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1547 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1548 Move back to alloc.c.
1549 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1550 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1551
9ceebf39
JD
15522011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1553
1554 * nsterm.m (windowDidResize): Call x_set_window_size only when
1555 ns_in_resize is true. Otherwise set pixelwidth/height and
1556 call change_frame_size (Bug#9628).
1557
cb993c58
PE
15582011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1559
3930c88b
PE
1560 Port --enable-checking=all to Fedora 14 x86-64.
1561 * charset.c (syms_of_charset): Also account for glibc malloc's
1562 internal overhead when calculating the initial malloc maximum.
1563
cb993c58
PE
1564 Port --enable-checking=all to Fedora 14 x86.
1565 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1566 Move to lisp.h.
1567 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1568 (overrun_check_realloc, overrun_check_free):
1569 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1570 That way, xmalloc returns a properly-aligned pointer even if
1571 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1572 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1573 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1574 into account when calculating the initial malloc maximum.
1575 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1576 Move here from alloc.c, so that charset.c can use it too.
1577 Properly align; the old code wasn't right for common 32-bit hosts
1578 when configured with --enable-checking=all.
1579 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1580 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1581
31bed486
EZ
15822011-09-29 Eli Zaretskii <eliz@gnu.org>
1583
04c70788 1584 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1585 use EDOM.
1586
fbcaa2f3
EZ
15872011-09-28 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (compute_display_string_end): If there's no display
1590 string at CHARPOS, return -1.
1591
1592 * bidi.c (bidi_fetch_char): When compute_display_string_end
1593 returns a negative value, treat the character as a normal
1594 character not covered by a display string. (Bug#9624)
1595
a239d4e9
JB
15962011-09-28 Juanma Barranquero <lekktu@gmail.com>
1597
1598 * lread.c (Fread_from_string): Fix typo in docstring.
1599
88652fd5
EZ
16002011-09-27 Eli Zaretskii <eliz@gnu.org>
1601
1602 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1603 newline, reseat the iterator instead of bidi-iterating there one
1604 character at a time. (Bug#9610)
32c1fffd
SM
1605 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1606 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1607
ed497dd4
AS
16082011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1609
1610 * lread.c (readevalloop): Use correct code for NBSP.
1611 (read1): Likewise. (Bug#9608)
1612
b2bf61aa
MA
16132011-09-25 Michael Albinus <michael.albinus@gmx.de>
1614
1615 * dbusbind.c (Fdbus_register_signal): When service is not
1616 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1617
32bbb17c
GM
16182011-09-25 Glenn Morris <rgm@gnu.org>
1619
1620 * buffer.c (truncate-lines): Doc fix.
1621
94e0933e
CY
16222011-09-24 Chong Yidong <cyd@stupidchicken.com>
1623
1624 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1625 (Fset_window_next_buffers): Doc fix.
1626
cddde921
GM
16272011-09-24 Glenn Morris <rgm@gnu.org>
1628
1629 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1630
1260aef1
PE
16312011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1632
25b4bfa0
PE
1633 Fix minor problems found by static checking.
1634 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1635 * indent.c (Fvertical_motion): Fix == vs = typo.
1636
e3cbd34b
EZ
16372011-09-24 Eli Zaretskii <eliz@gnu.org>
1638
a66cfb1c
SM
1639 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1640 Default value is now t. Doc fix.
6bf7006f 1641
e3cbd34b 1642 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1643 logic when moving up, not only when moving down. Fix the
e3cbd34b 1644 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1645 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1646
1647 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1648 CHARPOS is covered by a display string which includes newlines.
1649 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1650 is covered by a display string with embedded newlines.
1651
a3de0cbd
MA
16522011-09-24 Michael Albinus <michael.albinus@gmx.de>
1653
1654 * dbusbind.c (Fdbus_register_signal): Add match rule to
1655 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1656 (Fdbus_register_method, Vdbus_registered_objects_table):
1657 Fix docstring.
a3de0cbd 1658
b260039d
JM
16592011-09-24 Jim Meyering <meyering@redhat.com>
1660
32c1fffd 1661 do not ignore write error for any output size
b260039d
JM
1662 The previous change was incomplete.
1663 While it makes emacs --batch detect the vast majority of stdout
1664 write failures, errors were still ignored whenever the output size is
1665 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1666 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1667 && echo FAIL: ignored write error
1668 FAIL: ignored write error
1669 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1670 && echo FAIL: ignored write error
1671 FAIL: ignored write error
1672 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1673
8eca8a7c
AS
16742011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1675
1676 * emacs.c (Fkill_emacs): In noninteractive mode exit
1677 non-successfully if a write error occurred on stdout. (Bug#9574)
1678
3341db62
EZ
16792011-09-21 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1682 the xassert test.
1683
1684 * dispextern.h (struct it): Update the comment documenting what
1685 can it->OBJECT be.
1686
8c203dbf
EZ
16872011-09-20 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1690 a display string, extend search for cursor position to end of row.
1691 (find_row_edges): If the row ends in a newline from a display
1692 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1693 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1694 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1695 non-empty line. Fixes confusing cursor motion with arrow keys at
1696 the beginning of a line that starts with whitespace.
8c203dbf 1697
a4824228
LMI
16982011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1699
1700 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1701 (bug#9493).
1702
33ed493b
CY
17032011-09-18 Chong Yidong <cyd@stupidchicken.com>
1704
1705 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1706 boolean (Bug#9154).
1707
56cd55c8
EZ
17082011-09-18 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (display_line): Record maximum and minimum buffer
1711 positions even if no glyphs were produced (e.g., by a zero-width
1712 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1713 buffer positions that will be removed from the glyph row because
1714 they don't fit.
c02dcedf
EZ
1715 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1716 column is beyond frame width: don't subtract 1 "pixel" when
1717 computing width of the stretch.
3e62b7e0
EZ
1718 (reseat_at_next_visible_line_start): Undo the change made on
1719 2011-09-17 that saved paragraph information and restored it after
1720 the call to `reseat'. (Bug#9545)
56cd55c8 1721
5ed99d36 17222011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1723
1724 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1725 and turn window cursor on if cleared (Bug#9415).
1726
5ed99d36 17272011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1728
1729 * search.c (boyer_moore): Take unibyte characters from pattern
1730 literally. (Bug#9458)
1731
9bade7b2
EZ
17322011-09-18 Eli Zaretskii <eliz@gnu.org>
1733
1734 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1735
e5e9d610
PE
17362011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1737
87e4427a
PE
1738 Fix minor problem found by static checking.
1739 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1740 initialized, to pacify gcc -Wuninitialized.
1741
e5e9d610
PE
1742 * fileio.c: Report proper errno when syscall falls.
1743 (Finsert_file_contents): Save and restore errno,
1744 so that report_file_error outputs the correct diagnostic.
1745 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1746
a1674f0b
EZ
17472011-09-18 Eli Zaretskii <eliz@gnu.org>
1748
1749 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1750
fbfb6dd4
EZ
17512011-09-17 Eli Zaretskii <eliz@gnu.org>
1752
1753 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1754 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1755
bb187662
EZ
17562011-09-17 Eli Zaretskii <eliz@gnu.org>
1757
1137e8b8 1758 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1759 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1760
1761 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1762 (bidi_find_paragraph_start): Search back for paragraph beginning
1763 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1764 (bidi_move_to_visually_next): Only trigger paragraph-related
1765 computations when the last character is a newline or at EOB, not
1766 just any NEUTRAL_B. (Bug#9470)
1767
bb187662
EZ
1768 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1769 truncated lines if point is covered by a display string. (Bug#9524)
1770
2e621251
PE
17712011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1774 (cons_to_x_long): New function.
1775 (lisp_data_to_selection_data): Use it. Correct the test for
1776 short-versus-long data; it was negated. Break out of vector
1777 loop, for efficiency, when a long datum is discovered.
1778
91a15bc6
SM
17792011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1780
1781 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1782
b41c3a35
EZ
17832011-09-16 Eli Zaretskii <eliz@gnu.org>
1784
1785 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1786 GCC PR/17406) by declaring this function with external scope.
1787
7812ba2d
PE
17882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1791 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1792
cf7edc2a
AS
17932011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1794
1795 * editfns.c (Fformat): Correctly handle text properties on "%%".
1796
bd01620e
EZ
17972011-09-15 Eli Zaretskii <eliz@gnu.org>
1798
1799 * xterm.c (x_draw_composite_glyph_string_foreground):
1800 * w32term.c (x_draw_composite_glyph_string_foreground):
1801 * term.c (encode_terminal_code):
1802 * composite.c (composition_update_it, get_composition_id):
1803 * xdisp.c (get_next_display_element)
1804 (fill_composite_glyph_string): Add comments about special meaning
1805 of TAB characters in a composition.
1806
a02719a3
PE
18072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1810 This occurs when processing a multibyte format.
1811 Problem reported by Wolfgang Jenker.
a02719a3 1812
72589a3c
JB
18132011-09-15 Johan Bockgård <bojohan@gnu.org>
1814
1815 * xdisp.c (try_cursor_movement): Only check for exact match if
1816 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1817
1c14176c
PE
18182011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 Remove unused external symbols.
1821 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1822 * xdisp.c (calc_pixel_width_or_height): Now static.
1823 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1824 * indent.c (check_display_width):
1825 * w32term.c: Fix comment to match code.
1826 * xterm.c, xterm.h (x_catching_errors): Remove.
1827
d2eea5b5
PE
18282011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 * xselect.c: Use signed conversions more consistently (Bug#9498).
1831 (selection_data_to_lisp_data): Assume incoming selection data are
1832 signed integers, not unsigned. This is to be consistent with
1833 outgoing selection data, which was modified to use signed integers
1834 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1835 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1836 expects long, not unsigned long.
1837
46888499
EZ
18382011-09-14 Eli Zaretskii <eliz@gnu.org>
1839
1840 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1841 computation of loop end. Reported by Johan Bockgård
1842 <bojohan@gnu.org>.
1843
ef8ef9fb
CY
18442011-09-13 Chong Yidong <cyd@stupidchicken.com>
1845
1846 * frame.c (Fother_visible_frames_p): Function deleted.
1847
fa819fed
EZ
18482011-09-12 Eli Zaretskii <eliz@gnu.org>
1849
1850 * indent.c (compute_motion): Process display vector front to back
1851 rather than the other way around. (Bug#2496)
1852
2ba8e008
SM
18532011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1854
1855 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1856
20f53c69
CY
18572011-09-11 Chong Yidong <cyd@stupidchicken.com>
1858
1859 * minibuf.c (Fread_from_minibuffer): Doc fix.
1860
d562d7a4
EZ
18612011-09-11 Eli Zaretskii <eliz@gnu.org>
1862
1863 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1864 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1865
1c4d7f3d
LMI
18662011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1867
1868 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1869 value for non-existent files.
1870
b885bf36
EZ
18712011-09-11 Eli Zaretskii <eliz@gnu.org>
1872
1873 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1874 set its "size" to -1. This will set the modtime_size field of
1875 the corresponding buffer to -1, which is what
1876 verify-visited-file-modtime expects for files that do not exist.
1877 (Bug#9139)
1878
6612f0bf
PE
18792011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1882 here ...
1883 * lisp.h: ... from here. push_key_description is no longer
1884 defined in keyboard.c, so its declaration should not be in
1885 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1886 logically belongs with push_key_description.
1887
dfb3f755
PE
18882011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * buffer.h: Include <sys/types.h> instead of <time.h>.
1891 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1892 Problem reported by Herbert J. Skuhra.
1893
3134906c
LMI
18942011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1895
1896 * xml.c (parse_region): Make the parsing work for
1897 non-comment-starting XML files again (bug#9144).
1898
8d903f4e
AS
18992011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1900
1901 * image.c (gif_load): Fix calculation of bottom and right corner.
1902 (Bug#9468)
1903
80ad64f4
EZ
19042011-09-10 Eli Zaretskii <eliz@gnu.org>
1905
1906 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1907 redisplay in small windows.
1908
208a048d
EZ
19092011-09-09 Eli Zaretskii <eliz@gnu.org>
1910
1911 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1912
9b1c252e
MR
19132011-09-08 Martin Rudalics <rudalics@gmx.at>
1914
1915 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1916 Operate on live windows only.
1917
2949f33b
JB
19182011-09-08 Juanma Barranquero <lekktu@gmail.com>
1919
1920 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1921
e08dcafd
EZ
19222011-09-07 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1925 only under bidi iteration.
1926
115b96bd
JD
19272011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1928
1929 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1930
c8199d0f
PE
19312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1934 Without this fix, the command to link temacs failed due to an
1935 undefined symbol __builtin_isnan. This is because
1936 /usr/include/iso/math_c99.h #defines isnan(x) to
1937 __builtin_isnan(x), but the bundled gcc, which identifies itself
1938 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1939 a __builtin_isnan.
1940 * floatfns.c (isnan): #undef, and then #define to a clone of
1941 what's in data.c.
1942 (Fisnan): Always define, since it's always available now.
1943 (syms_of_floatfns): Always define isnan at the Lisp level.
1944
e39b275c 19452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1946
1947 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1948
b2db44d9 19492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1950
f4af5137 1951 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1952 The previous code assumed that file offsets (off_t values) fit in
1953 EMACS_INT variables, which is not true on typical 32-bit hosts.
1954 The code messed up by falsely reporting buffer overflow in cases
1955 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1956 when "big" contains more than 2**29 bytes, even though this
1957 inserts just one byte and does not overflow the buffer.
1958 (Finsert_file_contents): Store file offsets as off_t
1959 values, not as EMACS_INT values. Check for overflow when
1960 converting between EMACS_INT and off_t. When checking for
1961 buffer overflow or for overlap, take the offsets into account.
1962 Don't use EMACS_INT for small values where int suffices.
1963 When checking for overlap, fix a typo: ZV was used where
1964 ZV_BYTE was intended.
1965 (Fwrite_region): Don't assume off_t fits into 'long'.
1966 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1967
ecfc0a49
MA
19682011-09-05 Michael Albinus <michael.albinus@gmx.de>
1969
1970 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1971
6511acf2 19722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1973
0999621a 1974 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1975
1976 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1977 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1978 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1979 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1980 (modify_event_symbol): Do not assume that the length of
1981 name_alist_or_stem is safe to alloca and fits in int.
1982 (Fexecute_extended_command): Likewise for function name and binding.
1983 (Frecursion_depth): Wrap around reliably on integer overflow.
1984 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1985 since some callers pass EMACS_INT values.
1986 (Fsingle_key_description): Don't crash if symbol name contains more
1987 than MAX_ALLOCA bytes.
1988 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1989 (get_minibuffer): Arg is now EMACS_INT, not int.
1990 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1991 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1992 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1993
2be7d702
PE
1994 * dbusbind.c (signature_cat): New function.
1995 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1996 Do not overrun buffer; instead, report string overflow.
1997
9d1df220
PE
1998 * dispnew.c (add_window_display_history): Don't overrun buffer.
1999 Truncate instead; this is OK since it's just a log.
2000
33ef5c64
PE
2001 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2002 even if the time zone offset is outlandishly large.
2003 Don't mishandle offset == INT_MIN.
2004
66c6fdd5
PE
2005 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2006 when creating daemon; the previous buffer-overflow check was incorrect.
2007
d749b01b
PE
2008 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2009 which has the guts of the old verror function.
2010
b5cd1905
PE
2011 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2012 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2013
6e1a67fb
PE
2014 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2015 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2016 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2017 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2018 length of string rather than counting it via multiple sprintfs;
2019 that's simpler and more reliable.
c21721cc
PE
2020 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2021 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2022 sprintf, in case result does not fit in int.
2023
c57b67fc
PE
2024 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2025 (fontset_from_font): Print it.
2026
8a401434
PE
2027 * frame.c (tty_frame_count): Now printmax_t, not int.
2028 (make_terminal_frame, set_term_frame_name): Print it.
2029 (x_report_frame_params): In X, window IDs are unsigned long,
2030 not signed long, so print them as unsigned.
2031 (validate_x_resource_name): Check for implausibly long names,
2032 and don't assume name length fits in 'int'.
2033 (x_get_resource_string): Don't blindly alloca invocation name;
2034 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2035 not fit in int.
2036
6e1a67fb
PE
2037 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2038 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2039 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2040
0df02bf3
PE
2041 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2042 Use esprintf, not sprintf, in case result does not fit in int.
2043
48e30793
PE
2044 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2045 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2046 it as a large positive number.
2047 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2048 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2049
a66ff6d8
PE
2050 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2051 in case result does not fit in int.
2052
aca216ff
PE
2053 * print.c (float_to_string): Detect width overflow more reliably.
2054 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2055 buffer overrun. Don't assume list length fits in 'int'. Treat
2056 print length of 0 as 0, not as infinity; to be consistent with other
2057 uses of print length in this function. Don't overflow print length
2058 index. Don't assume hash table size fits in 'long', or that
2059 vectorlike size fits in 'unsigned long'.
2060
31c286f7
PE
2061 * process.c (make_process): Use printmax_t, not int, to format
2062 process-name gensyms.
2063
55e5faa1
PE
2064 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2065
80f2e268
PE
2066 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2067 to avoid potential buffer overrun.
2068
670741ab
PE
2069 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2070 if X resource line is longer than 512 bytes.
2071
b7163a50
PE
2072 * xfns.c (x_window): Make sprintf buffer a bit bigger
2073 to avoid potential buffer overrun.
2074
ae58ff1f
PE
2075 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2076
c43c8a6a
PE
2077 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2078
3f8236f4
PE
20792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2080
53e9fe90 2081 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2082 Without these, Emacs silently mishandles large integers sometimes.
2083 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2084 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2085
6511acf2
PE
2086 * xdisp.c (try_window_id): Check Emacs fixnum range before
2087 converting to 'int'.
806add1d 2088
6511acf2 2089 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2090 Check that an Emacs fixnum is in range before assigning it to 'int'.
2091 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2092 values converted from Emacs fixnums.
2093 (Frecenter): Don't wrap around a line count if it is out of 'int'
2094 range; instead, treat it as an extreme value.
2095 (Fset_window_configuration, compare_window_configurations):
2096 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2097
6511acf2
PE
2098 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2099 that can exceed INT_MAX. Check that EMACS_INT value is in range
2100 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2101 (match_limit): Don't assume that a fixnum can fit in 'int'.
2102
6511acf2 2103 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2104 exceed INT_MAX.
2105
6511acf2 2106 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2107 (Fvertical_motion): Don't wrap around LINES values that don't fit
2108 in 'int'. Instead, treat them as extreme values. This is good
2109 enough for windows, which can't have more than INT_MAX lines anyway.
2110
fcb901a7
LMI
21112011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2112
0f2f6b6d
LMI
2113 * Require libxml/parser.h to avoid compilation warning.
2114
fcb901a7
LMI
2115 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2116
2117 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2118 since this reportedly can destroy thread storage.
2119
6e20a0d4
CY
21202011-08-30 Chong Yidong <cyd@stupidchicken.com>
2121
2122 * syntax.c (find_defun_start): Update all cache variables if
2123 exiting early (Bug#9401).
2124
148ae00e
EZ
21252011-08-30 Eli Zaretskii <eliz@gnu.org>
2126
f6cfbd8f
EZ
2127 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2128
148ae00e
EZ
2129 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2130 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2131 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2132
2133 * term.c (tty_append_glyph): New function.
2134 (produce_stretch_glyph): Static function and its prototype deleted.
2135
a66cfb1c
SM
2136 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2137 Add prototypes.
148ae00e 2138
c4a07a4c
PE
21392011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2142 when checking :margin (Bug#9390).
2143 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2144 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2145 so that the name doesn't mislead. All uses changed.
2146
6bc8cd65
JB
21472011-08-28 Johan Bockgård <bojohan@gnu.org>
2148
2149 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2150 set_tty_hooks.
2151
dca4927e
EZ
21522011-08-27 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (move_it_to): Don't bail out early when reaching
2155 position beyond to_charpos, if we are scanning backwards.
2156 (move_it_vertically_backward): When DY == 0, make sure we get to
2157 the first character in the line after the newline.
2158
f2cad773
PE
21592011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2162 (ccl_driver): Do not generate an out-of-range pointer.
2163 (Fccl_execute_on_string): Remove unnecessary check for
2164 integer overflow, noted by Stefan Monnier in
2165 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2166 Remove a FIXME that didn't need fixing.
2167 Simplify the newly-introduced buffer reallocation code.
2168
0cae2cdb
JB
21692011-08-27 Juanma Barranquero <lekktu@gmail.com>
2170
2171 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2172
5fc295a4 21732011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2174
70c60eb2 2175 Integer and memory overflow issues (Bug#9196).
726e0ab1 2176
d31850da
PE
2177 * doc.c (get_doc_string): Rework so that
2178 get_doc_string_buffer_size is the actual buffer size, rather than
2179 being 1 less than the actual buffer size; this makes xpalloc more
2180 convenient.
2181
a69fbedb
PE
2182 * image.c (x_allocate_bitmap_record, cache_image):
2183 * xselect.c (Fx_register_dnd_atom):
2184 Simplify previous changes by using xpalloc.
2185
fe5c5d37
PE
2186 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2187 since either will do and ptrdiff_t is convenient with xpalloc.
2188
0065d054
PE
2189 * charset.c (charset_table_size)
2190 (struct charset_sort_data.priority): Now ptrdiff_t.
2191 (charset_compare): Don't overflow if priorities differ greatly.
2192 (Fsort_charsets): Don't assume list length fits in int.
2193 Check for size-calculation overflow when allocating sort data.
2194 (syms_of_charset): Allocate an initial charset table that is
2195 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2196
2197 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2198
2199 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2200 The actual value is always <= INT_MAX, and leaving it unsigned made
2201 overflow checking harder.
2202
2203 * dispextern.h (struct glyph_matrix.rows_allocated)
2204 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2205 with xpalloc. The values are still always <= INT_MAX.
2206
2207 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2208
2209 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2210 (SAFE_NALLOCA): New macro.
2211
2212 * region-cache.c (struct boundary.pos, find_cache_boundary)
2213 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2214 (set_cache_region, invalidate_region_cache)
2215 (revalidate_region_cache, know_region_cache, region_cache_forward)
2216 (region_cache_backward, pp_cache):
2217 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2218 so that ptrdiff_t * can be passed to xpalloc.
2219 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2220 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2221 (pp_cache): Don't assume cache_len fits in int.
2222 * region-cache.h: Adjust extern decls to match.
2223
2224 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2225 EMACS_INT, since either will do, for xpalloc.
2226
2227 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2228 (xnmalloc, xnrealloc, xpalloc): New functions.
2229
726e0ab1
PE
2230 * bidi.c (bidi_shelve_header_size): New constant.
2231 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2232 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2233
51f30bc5 2234 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2235 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2236 (overlay_strings):
2237 Don't update size of array until after memory allocation succeeds,
2238 because xmalloc/xrealloc may not return.
0065d054
PE
2239 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2240 now that we have proper integer overflow checking.
2241 (record_overlay_string, overlay_strings): Catch overflows when
2242 calculating size of overlay_str_buf.
726e0ab1 2243
0065d054
PE
2244 * callproc.c (Fcall_process): Check for size overflow when
2245 calculating size of args2.
2246 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2247 Normally we prefer signed values, but sticking with ptrdiff_t would
2248 require adding more-complicated checks.
726e0ab1
PE
2249
2250 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2251 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2252 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2253 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2254
2255 * character.c (Fstring): Check for size-calculation overflow.
2256
2257 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2258 unnecessary integer overflow. Check for size overflow.
2259 (encode_coding_object): Don't update size until xmalloc succeeds.
2260
2261 * composite.c (get_composition_id): Check for overflow in glyph
2262 length calculations.
2263
2264 Integer and memory overflow fixes for display code.
2265 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2266 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2267 (scrolling_window): Check for overflow in size calculations.
2268 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2269 Don't assume glyph table len fits in int.
2270 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2271 (row_table_size): Now ptrdiff_t, not int.
2272 (scrolling_window): Avoid overflow in size calculations.
2273 Don't update size until allocation succeeds.
2274 * fns.c (concat): Check for overflow in size calculations.
2275 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2276 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2277 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2278
2279 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2280 (get_doc_string): Check for size calculation overflow.
2281 Don't update size until allocation succeeds.
2282 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2283 EMACS_INT, where ptrdiff_t will do.
2284 (Fsubstitute_command_keys): Check for string overflow.
2285
2286 * editfns.c (set_time_zone_rule): Don't assume environment length
2287 fits in int.
2288 (message_length): Now ptrdiff_t, not int.
2289 (Fmessage_box): Don't update size until allocation succeeds.
2290 Don't assume message length fits in int.
2291 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2292
0065d054
PE
2293 * emacs.c (main): Do not reallocate argv, since there is a null at
2294 the end that can be overwritten, and this way there's no need to
2295 worry about size-calculation overflow.
2296 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2297
2298 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2299 alloc succeeds.
2300 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2301
2302 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2303 (x_set_scroll_bar_width, x_figure_window_size):
2304 Check for integer overflow.
2305 (x_set_alpha): Do not assume XINT fits in int.
2306
2307 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2308 This is for the members text_lines, text_cols, total_lines, total_cols,
2309 where the system imposes an 'int' limit.
2310
2311 * fringe.c (Fdefine_fringe_bitmap):
2312 Don't update size until alloc works.
2313
2314 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2315 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2316
2317 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2318 Check for size-calculation overflow.
2319 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2320 do, as we prefer signed integers.
2321 (id_to_widget.max_size, id_to_widget.used)
2322 (xg_store_widget_in_map, xg_remove_widget_from_map)
2323 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2324 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2325 Use and return ptrdiff_t, not int.
2326 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2327 * gtkutil.h: Change prototypes to match the above.
2328
2329 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2330 are duplicate now that they've been promoted to lisp.h.
2331 (x_allocate_bitmap_record, x_alloc_image_color)
2332 (make_image_cache, cache_image, xpm_load):
2333 Don't update size until alloc is done.
2334 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2335 (x_detect_edges):
3256efce 2336 Check for size calculation overflow.
726e0ab1
PE
2337 (ct_colors_allocated_max): New constant.
2338 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2339 overflow.
3256efce 2340
726e0ab1
PE
2341 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2342 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2343 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2344 Use ptrdiff_t, not int, to count maps.
2345 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2346 calculations. Don't update size until allocation succeeds.
2347 Redo calculations to avoid overflow.
726e0ab1
PE
2348 * keyboard.h: Change prototypes to match the above.
2349
2350 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2351 to count maps.
2352 (current_minor_maps): Check for size calculation overflow.
2353 * keymap.h: Change prototypes to match the above.
2354
2355 * lread.c (read1, init_obarray): Don't update size until alloc done.
2356
2357 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2358 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2359
726e0ab1
PE
2360 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2361 Now ptrdiff_t, not int.
2362 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2363 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2364
2365 * process.c (Fnetwork_interface_list): Check for overflow
2366 in size calculation.
2367
2368 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2369
2370 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2371 overflow. Don't bother calling xmalloc when xrealloc will do.
2372
2373 * search.c (Freplace_match): Check for size calculation overflow.
2374 (Fset_match_data): Don't assume list lengths fit in 'int'.
2375
2376 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2377 for command line length. Do not attempt to address one before the
2378 beginning of an array, as that's not portable.
2379
2380 * term.c (max_frame_lines): Remove; unused.
2381 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2382 not int.
2383 (encode_terminal_code, calculate_costs): Check for size
2384 calculation overflow.
2385 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2386 table lengths and related sizes. Don't update size until alloc
2387 done. Redo calculations to avoid overflow.
2388 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2389
2390 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2391 subtracting pointers.
2392 (gobble_line): Check for overflow more carefully. Don't update size
2393 until alloc done.
2394
2395 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2396 Don't update size until alloc done.
2397 Redo size calculations to avoid overflow.
2398 Check for size calculation overflow.
0065d054 2399 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2400
2401 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2402 Use ptrdiff_t, not int, for sizes.
2403 (store_mode_line_noprop_char): Don't update size until alloc done.
2404
0065d054
PE
2405 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2406 Use ptrdiff_t, not int, for sizes.
2407 (Finternal_make_lisp_face, cache_face):
2408 Check for size calculation overflow.
2409 (cache_face): Treat size calculation overflows as if they were
2410 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2411
2412 * xfns.c (x_encode_text, x_set_name_internal)
2413 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2414 sizes, since they can exceed INT_MAX in size. Check for size
2415 calculation overflow.
2416
0065d054
PE
2417 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2418 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2419 Don't update size until alloc done.
2420
0065d054 2421 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2422 as sprintf is limited to int lengths.
1d526e2f 2423
252c5ee1
PE
2424 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2425 (X_LONG_MIN): New macros.
864d7ce7
PE
2426 Use them to make the following changes clearer.
2427 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2428 This change doesn't affect the value now, but it may help remind
2429 future maintainers not to raise the value too much later.
2430 (SELECTION_QUANTUM): Remove, replacing with ...
2431 (selection_quantum): ... new function, which avoids overflow.
2432 All uses changed.
2433 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2434 assumption that selection length fits in 'int'.
2435 (x_reply_selection_request, x_handle_selection_request)
2436 (x_get_window_property, receive_incremental_selection)
2437 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2438 (lisp_data_to_selection_data, clean_local_selection_data):
2439 Use ptrdiff_t, not int, to record length of selection.
2440 (x_reply_selection_request, x_get_window_property)
2441 (receive_incremental_selection, x_property_data_to_lisp):
2442 Redo calculations to avoid overflow.
2443 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2444 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2445 something.
2446 (x_get_window_property, receive_incremental_selection)
2447 (lisp_data_to_selection_data, x_property_data_to_lisp):
2448 Check for size-calculation overflow.
2449 (x_get_window_property, receive_incremental_selection)
2450 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2451 Don't store size until memory allocation succeeds.
2452 (x_get_window_property): Plug memory leak on memory exhaustion.
2453 Don't double-block input; malloc is safe here. Don't assume 2**34
2454 - 4 fits in unsigned long. Add an xassert to check
2455 XGetWindowProperty overflow. Be more careful about overflow
2456 calculations, and distinguish size from memory overflow better.
2457 (receive_incremental_selection): When tracing, don't assume
2458 unsigned int is less than INT_MAX.
2459 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2460 harmful) conversions of unsigned short to int.
2461 (lisp_data_to_selection_data): Don't assume that integers
2462 in the range -65535 through -1 fit in an X unsigned short.
2463 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2464 result parameters unless successful. Rely on cons_to_unsigned
2465 to report problems with elements; the old code wasn't right anyway.
2466 (x_check_property_data): Check for int overflow; we cannot use
2467 a wider type due to X limits.
2468 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2469
726e0ab1 2470 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2471
0065d054
PE
2472 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2473 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2474 (x_color_cells): Don't store size until memory allocation succeeds.
2475 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2476 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2477 (x_term_init): Don't assume length fits in int (sprintf is limited
2478 to int size).
bc18e09d 2479
ebfa62c0
PE
2480 Use ptrdiff_t for composition IDs.
2481 * character.c (lisp_string_width):
2482 * composite.c (composition_table_size, n_compositions)
2483 (get_composition_id, composition_gstring_from_id):
2484 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2485 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2486 * window.c (Frecenter):
2487 Use ptrdiff_t, not int, for composition IDs.
2488 * composite.c (get_composition_id): Check for integer overflow.
2489 * composite.h: Adjust prototypes to match the above changes.
2490
d3411f89
PE
2491 Use ptrdiff_t for hash table indexes.
2492 * category.c (hash_get_category_set):
2493 * ccl.c (ccl_driver):
2494 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2495 * coding.c (coding_system_charset_list, detect_coding_system):
2496 * coding.h (struct coding_system.id):
2497 * composite.c (get_composition_id, gstring_lookup_cache):
2498 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2499 * image.c (xpm_get_color_table_h):
2500 * lisp.h (hash_lookup, hash_put):
2501 * minibuf.c (Ftest_completion):
2502 Use ptrdiff_t for hash table indexes, not int (which is too
2503 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2504 32-bit --with-wide-int hosts).
2505
e097a6fa
PE
2506 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2507 Add a FIXME comment about memory leaks.
2508 (syms_of_charset): Don't assume xmalloc returns.
2509
5637687f
PE
2510 Don't assume that stated character widths fit in int.
2511 * character.c (Fchar_width, c_string_width, lisp_string_width):
2512 * character.h (CHAR_WIDTH):
2513 * indent.c (MULTIBYTE_BYTES_WIDTH):
2514 Use sanitize_char_width to avoid undefined and/or bad behavior
2515 with outlandish widths.
a66cfb1c 2516 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2517 now that we have two such functions. All uses changed.
2518 (sanitize_char_width): New inline function.
2519
a2271ba2
PE
2520 Don't assume that tab-width fits in int.
2521 * character.h (sanitize_width): New inline function.
2522 (SANE_TAB_WIDTH): New macro.
2523 (ASCII_CHAR_WIDTH): Use it.
2524 * indent.c (sane_tab_width): Remove. All uses replaced by
2525 SANE_TAB_WIDTH (current_buffer).
2526 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2527
18c52557
PE
2528 * fileio.c: Integer overflow issues with file modes.
2529 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2530
caeeedc1
PE
2531 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2532 Remove unreachable code.
2533 (read_hex, load_charset_map_from_file): Check for integer overflow.
2534
6df6ae42 2535 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2536 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2537 (x_send_scroll_bar_event): Likewise. Check that the size does not
2538 exceed limits imposed by XClientMessageEvent, as well as the usual
2539 ptrdiff_t and size_t limits.
2540
b13995db
PE
2541 * keyboard.c: Overflow, signedness and related fixes.
2542 (make_lispy_movement): Use same integer type in forward decl
2543 that is used in the definition.
2544 (read_key_sequence, keyremap_step):
2545 Change bufsize argument back to int, undoing my 2011-03-30 change.
2546 We prefer signed types, and int is wide enough here.
2547 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2548 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2549 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2550 length, not size_t. Use ptrdiff_t for index, not int.
2551 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2552 possibility of integer overflow.
2553
13464394
PE
2554 Overflow, signedness and related fixes for images.
2555
2556 * dispextern.h (struct it.stack[0].u.image.image_id)
2557 (struct_it.image_id, struct image.id, struct image_cache.size)
2558 (struct image_cache.used, struct image_cache.ref_count):
2559 * gtkutil.c (update_frame_tool_bar):
2560 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2561 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2562 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2563 * nsmenu.m (update_frame_tool_bar):
2564 * xdisp.c (calc_pixel_width_or_height):
2565 * xfns.c (image_cache_refcount):
2566 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2567 on typical 64-bit hosts.
2568
2569 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2570 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2571 Omit unnecessary casts to int.
2572 (parse_image_spec): Check that integers fall into 'int' range
2573 when the callers expect that.
2574 (image_ascent): Redo ascent calculation to avoid int overflow.
2575 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2576 (lookup_image): Remove unnecessary tests.
2577 (xbm_image_p): Locals are now of int, not EMACS_INT,
2578 since parse_image_check makes sure they fit into int.
2579 (png_load, gif_load, svg_load_image):
2580 Prefer int to unsigned where either will do.
2581 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2582 old tiff_error_handler and tiff_warning_handler.
2583 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2584 stack buffer overflows. It uses only the features of vsnprintf
2585 that are common to both POSIX and native Microsoft.
2586 (tiff_error_handler, tiff_warning_handler): Use it.
2587 (tiff_load, gif_load, imagemagick_load_image):
2588 Don't assume :index value fits in 'int'.
2589 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2590 (imagemagick_load_image): Check that crop parameters fit into
2591 the integer types that MagickCropImage accepts. Don't assume
2592 Vimagemagick_render_type has a nonnegative value. Don't assume
2593 size_t fits in 'long'.
2594 (gs_load): Use printmax_t to print the widest integers possible.
2595 Check for integer overflow when computing image height and width.
2596
c11821d4
EZ
25972011-08-26 Eli Zaretskii <eliz@gnu.org>
2598
2599 * xdisp.c (redisplay_window): Don't force window start if point
2600 will be invisible in the resulting window. (Bug#9324)
2601
0c95fcf7
EZ
26022011-08-25 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2605 the display spec is of the form `(space ...)'.
2606 (handle_display_spec): Return the value returned by
2607 handle_single_display_spec, not just 1 or zero.
2608 (handle_single_display_spec): If the display spec is of the form
2609 `(space ...)', and specifies display in the text area, return 2
2610 rather than 1.
fee65a97 2611 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2612 accurately, and prefer exact match for point under bidi.
2613 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2614
2615 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2616 into disp_prop; all users changed.
2617
2618 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2619 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2620 for the text covered by the display property.
2621
e4ed06f1
CY
26222011-08-25 Chong Yidong <cyd@stupidchicken.com>
2623
2624 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2625 Change return value to nil.
2626 (Frecord_buffer): Delete unused function.
2627
f67cdd7f
EZ
26282011-08-24 Eli Zaretskii <eliz@gnu.org>
2629
5980d4c6
EZ
2630 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2631 buffers, return left-to-right.
8610fe8b
EZ
2632 (set_cursor_from_row): Consider candidate row a win if its glyph
2633 represents a newline and point is on that newline. Fixes cursor
2634 positioning on the newline at EOL of R2L text within L2R
2635 paragraph, and vice versa.
2636 (try_cursor_movement): Check continued rows, in addition to
2637 continuation rows. Fixes unwarranted scroll when point enters a
2638 continued line of R2L text within an L2R paragraph, or vice versa.
2639 (cursor_row_p): Consider the case of point being equal to
2640 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2641 from the end of a short line to the beginning of a continued line
2642 of R2L text within L2R paragraph.
2643 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2644 composed characters.
5980d4c6 2645
f67cdd7f
EZ
2646 * bidi.c (bidi_check_type): Use xassert.
2647 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2648 members.
2649
bca633fb
EZ
26502011-08-23 Eli Zaretskii <eliz@gnu.org>
2651
2652 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2653 a character.
2654
4a5885a7
CY
26552011-08-23 Chong Yidong <cyd@stupidchicken.com>
2656
2657 * nsfont.m (ns_otf_to_script): Fix typo.
2658
0902a04e
KH
26592011-08-22 Kenichi Handa <handa@m17n.org>
2660
2661 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2662 extra slot even if the purpose is char-code-property-table.
2663
1a2e6670
EZ
26642011-08-23 Eli Zaretskii <eliz@gnu.org>
2665
8ddde651
EZ
2666 * xdisp.c (redisplay_window): When computing centering_position,
2667 account for the height of the header line. (Bug#8874)
2668
425cc014
EZ
2669 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2670 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2671 candidate is selected by the mouse, and that candidate has a
2672 composed character under the mouse.
2673
1a2e6670
EZ
2674 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2675 coordinates reported by pos-visible-in-window-p for a composed
2676 character in column zero.
2677
8b76d6f8
SM
26782011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2679
2680 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2681
dac347dd
EZ
26822011-08-22 Eli Zaretskii <eliz@gnu.org>
2683
2684 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2685 consider it a hit if to_charpos is anywhere in the range of the
2686 composed buffer positions.
2687
e013fb34
CY
26882011-08-22 Chong Yidong <cyd@stupidchicken.com>
2689
2690 * image.c (gif_load): Don't assume that each subimage has the same
2691 dimensions as the base image. Handle disposal method that is
2692 "undefined" by the gif spec (Bug#9335).
2693
bd1ba3e8
CY
26942011-08-20 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2697 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2698
54a1215b
EZ
26992011-08-19 Eli Zaretskii <eliz@gnu.org>
2700
823564e5
EZ
2701 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2702 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2703 from an Org mode buffer to a Speedbar frame.
2704
54a1215b
EZ
2705 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2706 a composition, take its buffer position from IT->cmp_it.charpos.
2707 Fixes cursor positioning at the beginning of a line that begins
2708 with a composed character.
2709
9778ebcc
EZ
27102011-08-18 Eli Zaretskii <eliz@gnu.org>
2711
0be6ee06
EZ
2712 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2713 character bidirectional type, use STRONG_L instead. Fixes crashes
2714 in a buffer produced by `describe-categories'.
2715
9778ebcc
EZ
2716 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2717 members before the level stack, so they would be saved and
2718 restored when copying iterator state. Fixes incorrect reordering
2719 around TABs covered by display properties.
2720
156bffbe
AS
27212011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2722
6b02f655 2723 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2724
72ad093b
CY
27252011-08-17 Chong Yidong <cyd@stupidchicken.com>
2726
2727 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2728 (internal_condition_case_2, internal_condition_case_n):
2729 Remove unnecessary aborts (Bug#9081).
72ad093b 2730
35774242
EZ
27312011-08-17 Eli Zaretskii <eliz@gnu.org>
2732
2733 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2734 has no `load' handler, try opening the file locally. (Bug#9311)
2735
db76dd85
KB
27362011-08-16 Ken Brown <kbrown@cornell.edu>
2737
2738 * gmalloc.c: Expand comment.
2739
b215eee5
EZ
27402011-08-16 Eli Zaretskii <eliz@gnu.org>
2741
2742 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2743 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2744
a4579d33
KB
27452011-08-16 Ken Brown <kbrown@cornell.edu>
2746
2747 Fix memory allocation problems in Cygwin build (Bug#9273).
2748
2749 * unexcw.c ( __malloc_initialized): Declare external variable.
2750 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2751
8b76d6f8
SM
2752 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2753 New variables.
a4579d33
KB
2754 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2755 dumped emacs.
2756 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2757 in the static heap.
2758 [CYGWIN] (special_realloc): New function.
2759 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2760 requests to realloc storage in the static heap.
2761
3ebec551
PE
27622011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 * bidi.c (bidi_initialize): Remove unused local.
2765
9fd8be00
EZ
27662011-08-15 Eli Zaretskii <eliz@gnu.org>
2767
6b02f655
SM
2768 * bidimirror.h:
2769 * biditype.h: Remove file.
2770 * makefile.w32-in ($(BLD)/bidi.$(O)):
2771 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2772
2773 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2774
2775 * chartab.c: Improve commentary for the uniprop_table API.
2776
32413314
EZ
2777 * bidi.c (bidi_paragraph_init): Support zero value of
2778 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2779 (bidi_initialize): Use uniprop_table instead of including
2780 biditype.h and bidimirror.h.
32413314 2781
9fd8be00
EZ
2782 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2783 coordinates of the iterator when restoring from ppos_it.
2784 (Bug#9296)
2785
5cf2b69b
KH
27862011-08-14 Kenichi Handa <handa@m17n.org>
2787
2788 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2789 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2790
daf17d00
EZ
27912011-08-14 Eli Zaretskii <eliz@gnu.org>
2792
2793 * xdisp.c (move_it_in_display_line_to): Don't invoke
2794 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2795 ppos_it. Fixes vertical cursor motion when line beginning is
2796 covered by an image. (Bug#9296)
2797
08e3161a
JD
27982011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * nsterm.h (ns_run_ascript): Declare.
2801 (NSAPP_DATA2_RUNASSCRIPT): Define.
2802
2803 * nsfns.m (as_script, as_result, as_status): New static variables.
2804 (ns_run_ascript): New function.
5e617bc2 2805 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2806 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2807 the event loop. Get status from as_status (Bug#7276).
2808
2809 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2810 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2811 the event loop (Bug#7276).
2812
a3720aa2
AS
28132011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2814
2815 * gnutls.c (QCgnutls_bootprop_priority)
2816 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2817 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2818 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2819 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2820 (QCgnutls_bootprop_verify_hostname_error)
2821 (QCgnutls_bootprop_callbacks_verify): Rename from
2822 Qgnutls_bootprop_..., all uses changed.
2823
2824 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2825 uses changed.
2826
0a0d27fb
PE
28272011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2828
19d5c50c
PE
2829 * xfaces.c (Qframe_set_background_mode): Now static.
2830 * dispextern.h (Qframe_set_background_mode): Remove decl.
2831
0a0d27fb
PE
2832 * process.c (Fnetwork_interface_info): Declare local only if needed.
2833
377538cb
JD
28342011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2835
2836 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2837 (Fnetwork_interface_list): Allocate in increments of bytes instead
2838 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2839 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2840 sockaddr.
2841 (struct ifflag_def): notrailers is smart on OSX.
2842 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2843 Get hardware address with getifaddrs if available.
2844
08fff70c
EZ
28452011-08-12 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xdisp.c (iterate_out_of_display_property): xassert that
2848 IT->position is set to within IT->object's boundaries. Break from
2849 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2850 when IT->position is set up wrongly due to some bug.
2851 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2852 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2853 entry. Force push_it to save on the stack the current
2854 buffer/string position, to be restored by pop_it. Fix flags in
2855 the iterator structure wrt the object coming from a display
2856 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2857 properties. (Bug#9284)
2858
7be1c708 28592011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2860
7be1c708
CY
2861 * fontset.c (fontset_get_font_group): Add proper type checks.
2862 (Bug#9172)
aac0c6e3 2863
7be1c708 28642011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2865
7be1c708
CY
2866 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2867 and LC_VERSION_MIN_MACOSX.
2868 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2869 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2870
97bb72a6
EZ
28712011-08-08 Eli Zaretskii <eliz@gnu.org>
2872
2873 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2874 no-display-properties-and-no-overlays under bidi display.
2875 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2876 properties and overlays.
97bb72a6 2877
d5617611
CY
28782011-08-08 Chong Yidong <cyd@stupidchicken.com>
2879
37e11a63
CY
2880 * editfns.c (Fset_time_zone_rule): Document relationship with the
2881 setenv function.
2882
d5617611
CY
2883 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2884 the font entity extracted from the cache (Bug#8109).
2885
58872834
CY
28862011-08-07 Chong Yidong <cyd@stupidchicken.com>
2887
2888 * composite.c (autocmp_chars): Don't reset point. That is done by
2889 restore_point_unwind (Bug#5984).
2890
75bfc667
JL
28912011-08-07 Juri Linkov <juri@jurta.org>
2892
2893 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2894 to show the arg `TIME' instead of `TIMEVAL'.
2895
d1410150
EZ
28962011-08-06 Eli Zaretskii <eliz@gnu.org>
2897
2898 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2899 display property strides EOL and includes a newline, as in
2900 longlines-mode. (Bug#9254)
75b771e4
EZ
2901 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2902 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2903
2904 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2905 is non-zero, even if the data buffer is NULL. Fixes a crash in
2906 vertical-motion with longlines-mode. (Bug#9254)
2907
35928349
EZ
29082011-08-05 Eli Zaretskii <eliz@gnu.org>
2909
ec7cc85b
EZ
2910 * bidi.c <bidi_cache_total_alloc>: Now static.
2911 (bidi_initialize): Initialize bidi_cache_total_alloc.
2912
8b76d6f8 2913 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2914 cache. (Bug#9221)
2915
2916 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2917 amount allocated this far in `bidi_cache_total_alloc'.
2918 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2919 non-zero, only free the data buffer without restoring the cache
2920 contents. All callers changed.
2921
2922 * dispextern.h (bidi_unshelve_cache): Update prototype.
2923
2924 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2925 (move_it_in_display_line, move_it_to)
2926 (move_it_vertically_backward, move_it_by_lines): Replace the call
2927 to xfree to an equivalent call to bidi_unshelve_cache.
2928 (move_it_in_display_line_to): Fix logic of returning
412b6358 2929 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2930
e2e2423b
EZ
29312011-08-05 Eli Zaretskii <eliz@gnu.org>
2932
2933 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2934 came from a string character with a `cursor' property. (Bug#9229)
2935
ae9e757a
JD
29362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2937
2938 * Makefile.in (LIB_PTHREAD): New variable.
2939 (LIBES): Add LIB_PTHREAD (Bug#9216).
2940
2941 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2942 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2943
213bd7f2
AS
29442011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2945
6b02f655 2946 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2947
99aaf75f
JD
29482011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * xterm.c (x_find_topmost_parent): New function.
2951 (x_set_frame_alpha): Find topmost parent window with
2952 x_find_topmost_parent and set the property there also (bug#9181).
2953 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2954
c74e9d86
PE
29552011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 * callproc.c (Fcall_process): Avoid vfork clobbering
2958 the local vars buffer, coding_systems, current_dir.
2959
640c8776
SM
29602011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2961
2962 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2963
f26d0e4c
PE
29642011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2965
8a10d76c
PE
2966 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2967 so that it is not optimized away.
2968
f26d0e4c
PE
2969 * xdisp.c (compute_display_string_pos): Remove unused local.
2970
55439c61
EZ
29712011-08-02 Eli Zaretskii <eliz@gnu.org>
2972
2973 Fix slow cursor motion and scrolling in large buffers with
2974 selective display, like Org Mode buffers. (Bug#9218)
2975
2976 * dispextern.h (struct bidi_it): New member disp_prop_p.
2977
2978 * xdisp.c: Remove one-slot cache of display string positions.
2979 (compute_display_string_pos): Accept an additional argument
5e617bc2 2980 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2981 for a display string or property. If found, set DISP_PROP_P
2982 non-zero.
2983
2984 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2985 DISP_PROP_P, and pass it to compute_display_string_pos.
2986 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2987 non-zero. All callers of bidi_fetch_char changed.
2988
fb33fa43
SM
29892011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2992
b099e063
DM
29932010-12-03 Don March <don@ohspite.net>
2994
2995 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2996 last character M-[char] is translated to ESC [char] (bug#7541).
2997
5cc7f7af
KH
29982011-08-02 Kenichi Handa <handa@m17n.org>
2999
d0fffa3f 3000 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3001
3002 * chartab.c (uniprop_table): Make it non-static.
3003
525d5e6e
EZ
30042011-08-01 Eli Zaretskii <eliz@gnu.org>
3005
3006 * xdisp.c (forward_to_next_line_start): Accept additional argument
3007 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3008 on the newline.
3009 (reseat_at_next_visible_line_start): Use the bidi iterator state
3010 returned by forward_to_next_line_start to restore the state of
3011 it->bidi_it after backing up to previous newline. (Bug#9212)
3012
31011111
AS
30132011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3014
3015 * regex.c (re_comp): Protoize.
3016 (re_exec): Fix return type.
3017 (regexec): Fix type of `ret'. (Bug#9203)
3018
476371c4
PE
30192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3020
e5d76069
PE
3021 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3022 This is needed if max-image-size is a floating-point number.
3023
9a79b20c
AS
30242011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3025
3026 * print.c (print_object): Print empty symbol as ##.
3027
3028 * lread.c (read1): Read ## as empty symbol.
3029
d8c2fa78
AA
30302011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3031
3032 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3033 setting frame foreground color (Bug#9175).
3034 (x_set_background_color): Likewise.
3035
ffe57a7a
AA
3036 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3037 contents (Bug#9176).
3038 (EmacsTooltip -init): Remove bezels and add shadows to
3039 tooltip windows.
3040
bf3492a5
AA
3041 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3042 or scroll bar (Bug#8470).
3043
d55e9c53
AA
3044 * nsfont.m (nsfont_open): Remove assignment to voffset and
3045 unnecessary vars hshink, expand, hd, full_height, min_height.
3046 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3047
3048 * nsterm.h (nsfont_info): Remove voffset field.
3049
d8c2fa78 30502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3051
3052 Implement strike-through and overline on NextStep (Bug#8863).
3053
3054 * nsfont.m (nsfont_open): Use underline position provided by font,
3055 instead of hard-coded value of 2.
3056 (nsfont_draw): Call ns_draw_text_decoration instead.
3057
3058 * nsterm.h: Add declaration for ns_draw_text_decoration.
3059
3060 * nsterm.m (ns_draw_text_decoration): New function for drawing
3061 underline, overline, and strike-through.
3062 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3063 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3064 accommodate underlining, etc.
4843aac3 3065
4cc60b9b
EZ
30662011-07-28 Eli Zaretskii <eliz@gnu.org>
3067
bc7ece87
EZ
3068 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3069 default.
4cc60b9b 3070
476371c4
PE
30712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3072
66606eea
PE
3073 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3074 Without this fix, if a signal arrives just after memory fills up,
3075 'malloc' might be invoked reentrantly.
3076
476371c4
PE
3077 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3078 In other words, assume that every image size is allowed, on non-X
3079 hosts. This assumption is probably wrong, but it lets Emacs compile.
3080
f3fcc40d
AS
30812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3082
3083 * regex.c (re_iswctype): Convert return values to boolean.
3084
350c992f
EZ
30852011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3086
3087 * xdisp.c (compute_display_string_pos): Don't use cached display
3088 string position if the buffer had its restriction changed.
3089 (Bug#9184)
3090
5266b4bb
PE
30912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3094
2573a837 30952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3096
41f55ccd 3097 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3098
39e378da
PE
3099 * bidi.c: Integer size and overflow fixes.
3100 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3101 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3102 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3103 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3104 (bidi_find_other_level_edge):
3105 Use ptrdiff_t instead of EMACS_INT where either will do.
3106 This works better on 32-bit hosts configured --with-wide-int.
3107 (bidi_cache_ensure_space): Check for size-calculation overflow.
3108 Use % rather than repeated addition, for better worst-case speed.
3109 Don't set bidi_cache_size until after xrealloc returns, because it
3110 might not return.
3111 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3112 (bidi_cache_ensure_space): Also check that the bidi cache size
3113 does not exceed that of the largest Lisp string or buffer. See Eli
3114 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3115
5e927815
PE
3116 * alloc.c (__malloc_size_t): Remove.
3117 All uses replaced by size_t. See Andreas Schwab's note
3118 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3119
ca4aa935
PE
3120 * image.c: Improve checking for integer overflow.
3121 (check_image_size): Assume that f is nonnull, since
3122 it is always nonnull in practice. This is one less thing to
3123 worry about when checking for integer overflow later.
3124 (x_check_image_size): New function, which checks for integer
3125 overflow issues inside X.
3126 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3127 This removes the need for a memory_full check.
3128 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3129 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3130 (xbm_read_bitmap_data): Change locals back to 'int', since
3131 their values must fit in 'int'.
3132 (xpm_load_image, png_load, tiff_load):
3133 Invoke x_create_x_image_and_pixmap earlier,
3134 to avoid much needless work if the image is too large.
3135 (tiff_load): Treat overly large images as if
3136 x_create_x_image_and_pixmap failed, not as malloc failures.
3137 (gs_load): Use x_check_image_size.
3138
5f8f9cc2
PE
3139 * gtkutil.c: Omit integer casts.
3140 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3141 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3142
5adf60bc
PE
3143 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3144
c8907a93
PE
3145 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3146 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3147 would wrongly return t on a 64-bit host.
3148
e3c25c68
PE
3149 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3150 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3151 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3152 and therefore cause GCC to emit a bogus diagnostic in some cases.
3153
3f791afe
PE
3154 * image.c: Integer signedness and overflow and related fixes.
3155 This is not an exhaustive set of fixes, but it's time to
3156 record what I've got.
3157 (lookup_pixel_color, check_image_size): Remove redundant decls.
3158 (check_image_size): Don't assume that arbitrary EMACS_INT values
3159 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3160 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3161 (tiff_load, imagemagick_load_image):
3162 Check for overflow in size calculations.
3163 (x_create_x_image_and_pixmap): Remove unnecessary test for
3164 xmalloc returning NULL; that can't happen.
3165 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3166 (xpm_color_bucket): Use better integer hashing function.
3167 (xpm_cache_color): Don't possibly over-allocate memory.
3168 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3169 (gif_memory_source):
3170 Use ptrdiff_t, not int or size_t, to record sizes.
3171 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3172 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3173 either works, as we prefer signed integers.
3174 (tiff_read_from_memory, tiff_write_from_memory):
3175 Return tsize_t, not size_t, since that's what the TIFF API wants.
3176 (tiff_read_from_memory): Don't fail simply because the read would
3177 go past EOF; instead, return a short read.
3178 (tiff_load): Omit no-longer-needed casts.
3179 (Fimagemagick_types): Don't assume size fits into 'int'.
3180
3cc5a532
PE
3181 Improve hashing quality when configured --with-wide-int.
3182 * fns.c (hash_string): New function, taken from sxhash_string.
3183 Do not discard information about ASCII character case; this
3184 discarding is no longer needed.
3185 (sxhash-string): Use it. Change sig to match it. Caller changed.
3186 * lisp.h: Declare it.
3187 * lread.c (hash_string): Remove, since we now use fns.c's version.
3188 The fns.c version returns a wider integer if --with-wide-int is
3189 specified, so this should help the quality of the hashing a bit.
3190
b312a492
PE
3191 * emacs.c: Integer overflow minor fix.
3192 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3193 Define only if GNU_LINUX.
3194 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3195
dfd153ae
PE
3196 * dispnew.c: Integer signedness and overflow fixes.
3197 Remove unnecessary forward decls, that were a maintenance hassle.
3198 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3199 All uses changed.
3200 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3201 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3202 (prepare_desired_row, line_draw_cost):
3203 Use int, not unsigned, where either works.
3204 (save_current_matrix, restore_current_matrix):
3205 Use ptrdiff_t, not size_t, where either works.
3206 (init_display): Check for overflow more accurately, and without
3207 relying on undefined behavior.
3208
a81d11a3
PE
3209 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3210 Remove, replacing with the new symbols in lisp.h. All uses changed.
3211 * fileio.c (make_temp_name):
3212 * filelock.c (lock_file_1, lock_file):
3213 * xdisp.c (message_dolog):
3214 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3215 Use pMd etc. instead.
3216 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3217 replacing the pWIDE etc. symbols removed from editfns.c.
3218
3300e6fd
PE
3219 * keyboard.h (num_input_events): Now uintmax_t.
3220 This is (very slightly) less likely to mess up due to wraparound.
3221 All uses changed.
3222
fd05c7e9
PE
3223 * buffer.c: Integer signedness fixes.
3224 (alloc_buffer_text, enlarge_buffer_text):
3225 Use ptrdiff_t rather than size_t when either will do, as we prefer
3226 signed integers.
3227
903fe15d
PE
3228 * alloc.c: Integer signedness and overflow fixes.
3229 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3230 (__malloc_size_t): Default to size_t, not to int.
3231 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3232 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3233 Prefer ptrdiff_t to size_t when either would do, as we prefer
3234 signed integers.
3235 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3236 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3237 Now const. Initialize with values that are in range even if char
3238 is signed.
3239 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3240 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3241 These functions do the right thing with sizes > 2**32.
3242 (check_depth): Now ptrdiff_t, not int.
3243 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3244 Adjust to new way of storing sizes. Check for size overflow bugs
3245 in rest of code.
3246 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3247 slightly wrong anyway, as it missed one instance of
3248 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3249 (refill_memory_reserve): Omit needless cast to size_t.
3250 (mark_object_loop_halt): Mark as externally visible.
3251
ac82cc6a
PE
3252 * xselect.c: Integer signedness and overflow fixes.
3253 (Fx_register_dnd_atom, x_handle_dnd_message):
3254 Use ptrdiff_t, not size_t, since we prefer signed.
3255 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3256 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3257 x_dnd_atoms_size and x_dnd_atoms_length.
3258
c2d1e36d
PE
3259 * doprnt.c: Prefer signed to unsigned when either works.
3260 * eval.c (verror):
3261 * doprnt.c (doprnt):
3262 * lisp.h (doprnt):
3263 * xdisp.c (vmessage):
3264 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3265 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3266 prefer signed arithmetic to avoid comparison confusion.
3267 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3268 but is a bit tricky.
3269
0e926e56
PE
3270 Assume freestanding C89 headers, string.h, stdlib.h.
3271 * data.c, doprnt.c, floatfns.c, print.c:
3272 Include float.h unconditionally.
3273 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3274 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3275 * regex.c: Likewise for stddef.h, string.h.
3276 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3277 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3278 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3279 (STDC_HEADERS): Remove obsolete defines.
3280 * sysdep.c: Include limits.h unconditionally.
3281
9cfdb3ec
PE
3282 Assume support for memcmp, memcpy, memmove, memset.
3283 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3284 * regex.c (memcmp, memcpy):
3285 Remove; we assume C89 now.
3286
3287 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3288 (__malloc_safe_bcopy): Remove; no longer needed.
3289
cf950e6b 3290 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3291 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3292 well either way, and we prefer signed to unsigned.
3293
dbf38e02
LMI
32942011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3295
3296 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3297 closes the connection while we're reading (bug#9182).
3298
d6f0886c 32992011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3300
d6f0886c
JD
3301 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3302 are specified (Bug#9168).
24e0f6b1 3303
2eb1f9e6
PE
33042011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3307 Found by GCC static checking and --with-wide-int on a 32-bit host.
3308
22381272 33092011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3310
3311 * xdisp.c (compute_display_string_pos): Fix logic of caching
3312 previous display string position. Initialize cached_prev_pos to
3313 -1. Fixes slow-down at the beginning of a buffer.
3314
f25e39b4
EZ
33152011-07-24 Eli Zaretskii <eliz@gnu.org>
3316
3317 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3318 for attrs[LFACE_FONTSET_INDEX].
3319
04c4b52e
PE
33202011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 * xml.c (parse_region): Remove unused local
3323 that was recently introduced.
3324
c1734fbd
EZ
33252011-07-23 Eli Zaretskii <eliz@gnu.org>
3326
be18c5a5
EZ
3327 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3328 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3329
c1734fbd
EZ
3330 * xdisp.c (move_it_in_display_line_to): Record the best matching
3331 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3332 exit if none of the characters scanned was an exact match.
3333 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3334 when exact match is impossible due to invisible text, and the
3335 lines are truncated.
3336
a258d627
JD
33372011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3338
3339 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3340 for OSX >= 10.7.
3341
b6d5a689
EZ
33422011-07-22 Eli Zaretskii <eliz@gnu.org>
3343
0f74f785
EZ
3344 Fix a significant slow-down of cursor motion with C-n, C-p,
3345 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3346 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3347 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3348 (next_element_from_buffer): Call compute_stop_pos_backwards to
3349 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3350 base_level_stop.
3351 (reseat): Don't look for prev_stop, as that could mean a very long
3352 run.
3353 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3354 <cached_disp_overlay_modiff>: Cache for last found display string
3355 position.
551918c1 3356 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3357 about the same buffer in the same area of character positions, and
3358 the buffer wasn't changed since the time the display string
3359 position was cached.
551918c1 3360
b2d0c91a
EZ
33612011-07-22 Eli Zaretskii <eliz@gnu.org>
3362
3363 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3364 is an integer, which is important for empty lines. (Bug#9149)
3365
043604ee
CY
33662011-07-22 Chong Yidong <cyd@stupidchicken.com>
3367
3368 * frame.c (Fmodify_frame_parameters): In tty case, update the
3369 default face if necessary (Bug#4238).
3370
da4adb04
CY
33712011-07-21 Chong Yidong <cyd@stupidchicken.com>
3372
3373 * editfns.c (Fstring_to_char): No need to explain what a character
3374 is in the docstring (Bug#6576).
3375
9abd0532
LMI
33762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3377
3378 * xml.c (parse_region): Make sure we always return a tree.
3379
36881d16
HK
33802011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3381
3382 * xml.c (parse_region): If a document contains only comments,
3383 return that, too.
3384
1e98674d
LMI
33852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3386
3387 * xml.c (make_dom): Return comments, too.
3388
590bd467
PE
33892011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 Port to OpenBSD.
3392 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3393 and the surrounding thread.
3394 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3395 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3396 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3397 timer goes off.
3398 * s/openbsd.h (BROKEN_SIGIO): Define.
3399 * unexelf.c (unexec) [__OpenBSD__]:
3400 Don't update the .mdebug section of the Alpha COFF symbol table.
3401
f41628b2
LMI
34022011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
3404 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3405 (bug#8460).
3406
b59b67c5
PE
34072011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3408
15e3a074
PE
3409 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3410 This fixes some race conditions on the permissions of any newly
3411 created file.
3412
41bed37d
PE
3413 * alloc.c (valid_pointer_p): Use pipe, not open.
3414 This fixes some permissions issues when debugging.
3415
b59b67c5
PE
3416 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3417 If fchown fails to set both uid and gid, try to set just gid,
3418 as that is sometimes allowed. Adjust the file's mode to eliminate
3419 setuid or setgid bits that are inappropriate if fchown fails.
3420
925a6be7
SM
34212011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3422
3423 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3424 to compare Lisp_Objects.
3425 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3426 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3427 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3428
52968808
AS
34292011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3430
0a6a104b
AS
3431 * lread.c (read_integer): Unread even EOF character.
3432 (read1): Likewise. Properly record start position of symbol.
3433
52968808
AS
3434 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3435 symbol character follows.
3436
9e381cdd
PE
34372011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3440 This works around a problem with the previous change to Fcopy_file.
3441 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3442 and without this change, GCC might complain about discarding
3443 fchown's return value.
3444
b5641435
JB
34452011-07-16 Juanma Barranquero <lekktu@gmail.com>
3446
3447 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3448
a8031457
PE
34492011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3450
3451 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3452
dd889327
LMI
34532011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3454
750c33f7
LMI
3455 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3456 it's used from the C level.
3457
dd889327
LMI
3458 * process.c: Use the same condition for POLL_FOR_INPUT in both
3459 keyboard.c and process.c (bug#1858).
3460
87e86684
LM
34612011-07-09 Lawrence Mitchell <wence@gmx.li>
3462
3463 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3464 (Fgnutls_boot): Use it.
3465
64348f40
AS
34662011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3467
3468 * doc.c (Fsubstitute_command_keys): Revert last change.
3469
1d698799
LMI
34702011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3471
f863868c
LMI
3472 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3473 quotes the next character, and doesn't affect other longer
3474 sequences (bug#8935).
3475
1d698799
LMI
3476 * lread.c (syms_of_lread): Clarify that is isn't only
3477 `eval-buffer' and `eval-defun' that's affected by
3478 `lexical-binding' (bug#8460).
3479
aa4b6df6
EZ
34802011-07-15 Eli Zaretskii <eliz@gnu.org>
3481
3482 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3483 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3484
5d856da6
PE
34852011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3486
ad6042bb
PE
3487 Fix minor problems found by static checking.
3488 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3489 (elsz): Now a signed constant, not a size_t var. We prefer signed
3490 types to unsigned, to avoid integer comparison confusion. Without
3491 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3492 "cannot optimize loop, the loop counter may overflow", a symptom
3493 of the confusion.
f00bbb22 3494 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3495 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3496
6468f31c
LMI
34972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498
49080b10
LMI
3499 * search.c (Fre_search_backward): Mention `case-fold-search' in
3500 all the re_search_* functions (bug#8138).
3501
6468f31c
LMI
3502 * keyboard.c (Fopen_dribble_file): Document when the file is
3503 closed (bug#8056).
3504
c965adc5
EZ
35052011-07-14 Eli Zaretskii <eliz@gnu.org>
3506
df9733bf
EZ
3507 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3508 bidi_cache_idx.
3509
0bb23927
EZ
3510 Support bidi reordering of display and overlay strings.
3511 * xdisp.c (compute_display_string_pos)
3512 (compute_display_string_end): Accept additional argument STRING.
3513 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3514 (reseat_to_string): Initialize bidi_it->string.s and
3515 bidi_it->string.schars.
3516 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3517 NULL (avoids a crash in bidi_paragraph_init).
3518 Initialize itb.string.lstring.
0bb23927
EZ
3519 (init_iterator): Call bidi_init_it only of a valid
3520 buffer position was specified. Initialize paragraph_embedding to
3521 L2R.
3522 (reseat_to_string): Initialize the bidi iterator.
3523 (display_string): If we need to ignore text properties of
3524 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3525 original value of -1 will not work with bidi.)
3526 (compute_display_string_pos): First arg is now struct
3527 `text_pos *'; all callers changed. Support display properties on
3528 Lisp strings.
3529 (compute_display_string_end): Support display properties on Lisp
3530 strings.
3531 (init_iterator, reseat_1, reseat_to_string): Initialize the
3532 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3533 when iterating on a string not from display properties).
640c8776
SM
3534 (compute_display_string_pos, compute_display_string_end):
3535 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3536 arrow keys.
3537 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3538 base_level_stop; instead, set base_level_stop to BEGV.
3539 Fixes crashes in vertical-motion.
0bb23927
EZ
3540 (next_element_from_buffer): Improve commentary for when
3541 the iterator is before prev_stop.
3542 (init_iterator): Initialize bidi_p from the default value of
3543 bidi-display-reordering, not from buffer-local value. Use the
3544 buffer-local value only if initializing for buffer iteration.
3545 (handle_invisible_prop): Support invisible properties on strings
3546 that are being bidi-reordered.
3547 (set_iterator_to_next): Support bidi reordering of C strings and
3548 Lisp strings.
3549 (next_element_from_string): Support bidi reordering of Lisp
3550 strings.
3551 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3552 (display_string): Support display of R2L glyph rows.
3553 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3554 (init_iterator): Don't initialize it->bidi_p for strings
3555 here.
3556 (reseat_to_string): Initialize it->bidi_p for strings here.
3557 (next_element_from_string, next_element_from_c_string)
3558 (next_element_from_buffer): Add xassert's for correspondence
3559 between IT's object being iterated and it->bidi_it.string
3560 structure.
3561 (face_before_or_after_it_pos): Support bidi iteration.
3562 (next_element_from_c_string): Handle the case of the first string
3563 character that is not the first one in the visual order.
3564 (get_visually_first_element): New function, refactored from common
3565 parts of next_element_from_buffer, next_element_from_string, and
3566 next_element_from_c_string.
3567 (tool_bar_lines_needed, redisplay_tool_bar)
3568 (display_menu_bar): Force left-to-right direction. Add a FIXME
3569 comment for making that be controlled by a user option.
3570 (push_it, pop_it): Save and restore the state of the
3571 bidi iterator. Save and restore the bidi_p flag.
3572 (pop_it): Iterate out of display property for string iteration as
3573 well.
3574 (iterate_out_of_display_property): Support iteration over strings.
3575 (handle_single_display_spec): Set up it->bidi_it for iteration
3576 over a display string, and call bidi_init_it.
3577 (handle_single_display_spec, next_overlay_string)
3578 (get_overlay_strings_1, push_display_prop): Set up the bidi
3579 iterator for displaying display or overlay strings.
3580 (forward_to_next_line_start): Don't use the shortcut if
3581 bidi-iterating.
3582 (back_to_previous_visible_line_start): If handle_display_prop
3583 pushed the iterator stack, restore the internal state of the bidi
3584 iterator by calling bidi_pop_it same number of times.
3585 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3586 and we are bidi-iterating, don't decrement the iterator position;
3587 instead, set the first_elt flag in the bidi iterator, to produce
3588 the same effect.
3589 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3590 (push_display_prop): xassert that we are iterating a buffer.
3591 (push_it, pop_it): Save and restore paragraph_embedding member.
3592 (handle_single_display_spec, next_overlay_string)
3593 (get_overlay_strings_1, reseat_1, reseat_to_string)
3594 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3595 correctly. Don't assume unibyte strings are not bidi-reordered.
3596 (compute_display_string_pos)
3597 (compute_display_string_end): Fix handling the case of C string.
3598 (push_it, pop_it): Save and restore from_disp_prop_p.
3599 (handle_single_display_spec, push_display_prop): Set the
3600 from_disp_prop_p flag.
3601 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3602 (pop_it): Call iterate_out_of_display_property only if we are
3603 popping after iteration over a string that came from a display
3604 property. Fix a typo in popping stretch info. Add an assertion
3605 for verifying that the iterator position is in sync with the bidi
3606 iterator.
3607 (handle_single_display_spec, get_overlay_strings_1)
3608 (push_display_prop): Fix initialization of paragraph direction for
3609 string when that of the parent object is not yet determined.
3610 (reseat_1): Call bidi_init_it to resync the bidi
3611 iterator with IT's position. (Bug#7616)
3612 (find_row_edges): If ROW->start.pos gives position
3613 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3614 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3615 Reset the from_disp_prop_p flag.
3616 (SAVE_IT, RESTORE_IT): New macros.
3617 (pos_visible_p, face_before_or_after_it_pos)
3618 (back_to_previous_visible_line_start)
3619 (move_it_in_display_line_to, move_it_in_display_line)
3620 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3621 (try_scrolling, redisplay_window, display_line): Use them when
3622 saving a temporary copy of the iterator and restoring it back.
3623 (back_to_previous_visible_line_start, reseat_1)
3624 (init_iterator): Empty the bidi cache "stack".
3625 (move_it_in_display_line_to): If iterator ended up at
3626 EOL, but we never saw any buffer positions smaller than
3627 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3628 motion in bidi-reordered lines.
3629 (move_it_in_display_line_to): Record prev_method and prev_pos
3630 immediately before the call to set_iterator_to_next. Fixes cursor
3631 motion in bidi-reordered lines with stretch glyphs and strings
3632 displayed in margins. (Bug#8133) (Bug#8867)
3633 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3634 TO_CHARPOS.
640c8776
SM
3635 (pos_visible_p): Support positions in bidi-reordered lines.
3636 Save and restore bidi cache.
0bb23927
EZ
3637
3638 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3639 (bidi_paragraph_info): Delete unused struct.
3640 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3641 (bidi_cache_start): New variable.
3642 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3643 to zero.
3644 (bidi_cache_fetch_state, bidi_cache_search)
3645 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3646 (bidi_cache_find, bidi_peek_at_next_level)
3647 (bidi_level_of_next_char, bidi_find_other_level_edge)
3648 (bidi_move_to_visually_next): Compare cache index with
3649 bidi_cache_start rather than with zero.
3650 (bidi_fetch_char): Accept new argument STRING; all callers
3651 changed. Support iteration over a string. Support strings with
3652 display properties. Support unibyte strings. Fix the type of
3653 `len' according to what STRING_CHAR_AND_LENGTH expects.
3654 (bidi_paragraph_init, bidi_resolve_explicit_1)
3655 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3656 (bidi_level_of_next_char, bidi_move_to_visually_next):
3657 Support iteration over a string.
0bb23927
EZ
3658 (bidi_set_sor_type, bidi_resolve_explicit_1)
3659 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3660 can now be zero (for strings); special values 0 and -1 were
3661 changed to -1 and -2, respectively.
3662 (bidi_char_at_pos): New function.
3663 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3664 Call it instead of FETCH_MULTIBYTE_CHAR.
3665 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3666 initialized to valid values.
3667 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3668 values.
3669 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3670 the test for valid cached positions. Fix the logic for looking up
3671 the sentinel state in the cache. GCPRO the Lisp string we are
3672 iterating.
3673 (bidi_push_it, bidi_pop_it): New functions.
3674 (bidi_initialize): Initialize the bidi cache start stack pointer.
3675 (bidi_cache_ensure_space): New function, refactored from part of
3676 bidi_cache_iterator_state. Don't assume the required size is just
3677 one BIDI_CACHE_CHUNK away.
3678 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3679 (bidi_count_bytes, bidi_char_at_pos): New functions.
3680 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3681 always valid if bidi_cache_idx is valid.
3682 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3683 is valid if it's going to be used.
3684 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3685 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3686 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3687 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3688 (bidi_find_other_level_edge, bidi_cache_start_stack):
3689 All variables related to cache indices are now EMACS_INT.
c965adc5 3690
0bb23927
EZ
3691 * dispextern.h (struct bidi_string_data): New structure.
3692 (struct bidi_it): New member `string'. Make flag members be 1-bit
3693 fields, and put them last in the struct.
640c8776
SM
3694 (compute_display_string_pos, compute_display_string_end):
3695 Update prototypes.
0bb23927
EZ
3696 (bidi_push_it, bidi_pop_it): Add prototypes.
3697 (struct iterator_stack_entry): New members bidi_p,
3698 paragraph_embedding, and from_disp_prop_p.
3699 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3700 (bidi_shelve_cache, bidi_unshelve_cache):
3701 Declare prototypes.
0bb23927
EZ
3702
3703 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3704 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3705 and vector-like objects.
3706
3707 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3708 cache around display iteration.
3709
3710 * window.c (Fwindow_end, window_scroll_pixel_based)
3711 (displayed_window_lines, Frecenter): Save and restore the bidi
3712 cache around display iteration.
3713
3bbd2265
LMI
37142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3715
3716 * editfns.c (Fdelete_region): Clarify the use of the named
3717 parameters (bug#6788).
3718
adc47434
MR
37192011-07-14 Martin Rudalics <rudalics@gmx.at>
3720
3721 * indent.c (Fvertical_motion): Set and restore w->pointm when
3722 saving and restoring the window's buffer (Bug#9006).
3723
837c31f8
LMI
37242011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3725
3726 * editfns.c (Fstring_to_char): Clarify just what is returned
3727 (bug#6576). Text by Eli Zaretskii.
3728
ac389d0c
JB
37292011-07-13 Juanma Barranquero <lekktu@gmail.com>
3730
3731 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3732
0be0ce47
EZ
37332011-07-13 Eli Zaretskii <eliz@gnu.org>
3734
3735 * buffer.c (mmap_find): Fix a typo.
3736
cd18e7e3
JB
37372011-07-13 Johan Bockgård <bojohan@gnu.org>
3738
3739 Fix execution of x selection hooks.
3740 * xselect.c (Qx_lost_selection_functions)
3741 (Qx_sent_selection_functions): New vars.
3742 (syms_of_xselect): DEFSYM them.
3743 (x_handle_selection_request): Pass Qx_sent_selection_functions
3744 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3745 (x_handle_selection_clear,x_clear_frame_selections):
3746 Pass Qx_lost_selection_functions rather than
3747 Vx_lost_selection_functions to Frun_hook_with_args.
3748
47ea7f44
PE
37492011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3750
ac389d0c 3751 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3752 The old code sometimes used this field without initializing it.
3753
47ea7f44
PE
3754 * alloc.c (gc_sweep): Don't read past end of array.
3755 In theory, the old code could also have corrupted Emacs internals,
3756 though it'd be very unlikely.
3757
bc985c87
AS
37582011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3759
3760 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3761 argument. (Bug#4026)
bc985c87 3762
0cf34688
LMI
37632011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3764
b3dadd76
LMI
3765 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3766 key" (bug#4257).
3767
0cf34688
LMI
3768 * window.c (Fset_window_start): Doc fix (bug#4199).
3769 (Fset_window_hscroll): Ditto.
3770
270768cd
PE
37712011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3772
077e3dda 3773 Fix minor new problems caught by GCC 4.6.1.
270768cd 3774 * term.c (init_tty): Remove unused local.
490011a6 3775 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3776 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3777 not used otherwise.
270768cd 3778
b1f58454
CY
37792011-07-12 Chong Yidong <cyd@stupidchicken.com>
3780
3781 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3782
22b9578d
LMI
37832011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3784
6e70ab07
LMI
3785 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3786 are the mini-buffer and the echo area (bug#3320).
3787
22b9578d
LMI
3788 * term.c (init_tty): Remove support for supdup, c10 and perq
3789 terminals, which are no longer supported (bug#1482).
3790
8974cc9f
JB
37912011-07-10 Johan Bockgård <bojohan@gnu.org>
3792
3793 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3794
a560d974
JD
37952011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3796
3797 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3798 for non-popups (Bug#3642).
3799
1dae0f0a
AS
38002011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3801
268c2c36 3802 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3803 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3804 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3805 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3806 * data.c (fmod): Likewise.
3807 * dispnew.c (swap_glyphs_in_rows): Likewise.
3808 * emacs.c (memory_warning_signal): Likewise.
3809 * floatfns.c (float_error): Likewise.
3810 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3811 (otf_open, font_otf_capability, generate_otf_features)
3812 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3813 Likewise.
3814 * image.c (pbm_read_file): Likewise.
3815 * indent.c (string_display_width): Likewise.
3816 * intervals.c (check_for_interval, search_for_interval)
3817 (inc_interval_count, count_intervals, root_interval)
3818 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3819 * lread.c (defalias): Likewise.
268c2c36 3820 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3821 * regex.c (set_image_of_range_1, set_image_of_range)
3822 (regex_grow_registers): Likewise.
3823 * sysdep.c (strerror): Likewise.
3824 * termcap.c (valid_filename_p, tprint, main): Likewise.
3825 * tparam.c (main): Likewise.
3826 * unexhp9k800.c (run_time_remap, save_data_space)
3827 (update_file_ptrs, read_header, write_header, calculate_checksum)
3828 (copy_file, copy_rest, display_header): Likewise.
3829 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3830 Likewise.
3831 * xdisp.c (check_it): Likewise.
3832 * xfaces.c (register_color, unregister_color, unregister_colors):
3833 Likewise.
3834 * xfns.c (print_fontset_result): Likewise.
3835 * xrdb.c (member, fatal, main): Likewise.
3836
99033785
PE
38372011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3838
3839 Fix minor problems found by static checking (Bug#9031).
3840 * chartab.c (char_table_set_range, map_sub_char_table):
3841 Remove unused locals.
3842 (uniprop_table): Now static.
3843 * composite.c (_work_char): Remove unused static var.
3844
9cb2ac56
JB
38452011-07-09 Juanma Barranquero <lekktu@gmail.com>
3846
3847 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3848
f25661f0
JD
38492011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3850
3851 * gtkutil.c (qttip_cb): Remove code without function.
3852
8278c4fe
EZ
38532011-07-09 Eli Zaretskii <eliz@gnu.org>
3854
3855 * w32.c (pthread_sigmask): New stub.
3856
1692ae2d 38572011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3858
8a6ebd58 3859 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3860 sigprocmask is portable only for single-threaded applications, and
3861 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3862 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3863 (LIBES): Use it.
3864 * callproc.c (Fcall_process):
3865 * process.c (create_process):
3866 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3867 Use pthread_sigmask, not sigprocmask.
123403e4 3868
1b854618
JD
38692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3870
3871 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3872 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3873 wrong (Bug#8591).
3874
3fe4b549
JD
38752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3876
0ce7e563
JD
3877 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3878 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3879 (xg_hide_tooltip): Fix comment.
3880
3fe4b549
JD
3881 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3882 in registerServicesMenuSendTypes.
3883 (validRequestorForSendType): Don't check ns_return_types.
3884
3885 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3886 ns_return_type.
3887
5df75e47
JR
38882011-07-08 Jason Rumney <jasonr@gnu.org>
3889
22610910
JR
3890 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3891 SH_SHOW for hidden windows (Bug#5482).
3892
5df75e47
JR
3893 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3894 frame struct members of non-existent frames (Bug#6284).
3895
699c10bd
JD
38962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3897
4393663b
JD
3898 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3899 variable firstTime not needed on OSX >= 10.6.
3900 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3901 >= 10.5. Use setKnobProportion, setDoubleValue.
3902
3903 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3904 (MAC_OS_X_VERSION_10_5): Define if not defined.
3905 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3906 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3907 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3908
3909 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3910 cString and lossyCString on OSX >= 10.4
3911
58179cce 3912 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3913 sizeToFit on OSX >= 10.2.
3914
3915 * nsimage.m (allocInitFromFile): Don't use deprecated method
3916 bestRepresentationForDevice on OSX >= 10.6.
3917
3918 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3919 to avoid warning.
3920
3921 * emacs.c: Declare unexec_init_emacs_zone.
3922
a63e0781
JD
3923 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3924
699c10bd
JD
3925 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3926
3927 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3928 on svcsMenu (Bug#8842).
3929
3930 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3931 ns_return_types.
3932 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3933
3934 * nsterm.m (QUTF8_STRING): Declare.
3935 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3936 (validRequestorForSendType): Return type is (id).
3937 Change indexOfObjectIdenticalTo to indexOfObject.
3938 Check if we have local selection before returning self (Bug#8842).
3939 (writeSelectionToPasteboard): Put local selection into paste board
3940 if we have a local selection (Bug#8842).
3941 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3942
3943 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3944 (ns_get_local_selection): Declare.
3945
54e10184
LMI
39462011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3947
9888ff71
LMI
3948 * keymap.c (describe_map_tree): Don't insert a double newline at
3949 the end of the buffer (bug#1169) and return whether we inserted
3950 something.
3951
54e10184
LMI
3952 * callint.c (Fcall_interactively): Change "reading args" to
3953 "providing args" to try to clarify what it does (bug#1010).
3954
15fa4783
KH
39552011-07-07 Kenichi Handa <handa@m17n.org>
3956
3957 * composite.c (composition_compute_stop_pos): Ignore a static
3958 composition starting before CHARPOS (Bug#8915).
3959
3960 * xdisp.c (handle_composition_prop): Likewise.
3961
a8815b00
EZ
39622011-07-07 Eli Zaretskii <eliz@gnu.org>
3963
3964 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3965 (Bug#9015)
3966
ef7b981d 39672011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3968
3969 * character.h (unicode_category_t): New enum type.
3970
3971 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3972 (Qchar_code_property_table): New variable.
3973 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3974 (UNIPROP_COMPRESSED_FORM_P): New macros.
3975 (char_table_ascii): Uncompress the compressed values.
3976 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3977 Uncompress the compressed values.
ac389d0c 3978 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3979 (char_table_ref_and_range): Uncompress the compressed values.
3980 (sub_char_table_set): New arg is_uniprop. Callers changed.
3981 Uncompress the compressed values.
3982 (sub_char_table_set_range): Args changed. Callers changed.
3983 (char_table_set_range): Adjuted for the above change.
3984 (map_sub_char_table): Delete args default_val and parent. Add arg
3985 top. Give decoded values to a Lisp function.
640c8776 3986 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3987 values to a Lisp function. Gcpro more variables.
3988 (uniprop_table_uncompress)
3989 (uniprop_decode_value_run_length): New functions.
3990 (uniprop_decoder, uniprop_decoder_count): New variables.
3991 (uniprop_get_decoder, uniprop_encode_value_character)
3992 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3993 New functions.
3994 (uniprop_encoder, uniprop_encoder_count): New variables.
3995 (uniprop_get_encoder, uniprop_table)
3996 (Funicode_property_table_internal, Fget_unicode_property_internal)
3997 (Fput_unicode_property_internal): New functions.
3998 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3999 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4000 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4001 char-code-property-alist.
4002
640c8776 4003 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4004 Vunicode_category_table.
4005
640c8776 4006 * font.c (font_range): Adjust for the change of
c805dec0
KH
4007 Vunicode_category_table.
4008
76b397fb
DN
40092011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4010
4011 * m/iris4d.h: Remove file, move contents ...
4012 * s/irix6-5.h: ... here.
4013
22b4128e
PE
40142011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4017 * alloc.c (mark_buffer):
4018 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4019 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4020 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4021 This isn't true in general, and it's particularly not true
4022 if Emacs is configured with --with-wide-int.
4023 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4024 New macros, used in the buffer.c change.
4025
869795d6
JD
40262011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4027
4028 * xsettings.c: Use both GConf and GSettings if both are available.
4029 (store_config_changed_event): Add comment.
4030 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4031 (store_tool_bar_style_changed): New functions.
5e617bc2 4032 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4033 (struct xsettings): Move font inside HAVE_XFT.
4034 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4035 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4036 Move inside HAVE_XFT.
640c8776 4037 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4038 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4039 also.
4040 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4041 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4042 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4043 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4044 (parse_settings): Move check for font inside HAVE_XFT.
4045 (read_settings, apply_xft_settings): Add comment.
4046 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4047 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4048 call store_font_name_changed.
4049 (xft_settings_event): Add comment.
4050 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4051 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4052 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4053 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4054 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4055 (xsettings_get_system_font, xsettings_get_system_normal_font):
4056 Add comment.
869795d6 4057
d8ed26bd
PE
40582011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4059
4060 Random fixes. E.g., (random) never returned negative values.
4061 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4062 subseconds part to the entropy, as that's a bit more random.
4063 Prefer signed to unsigned, since the signedness doesn't matter and
4064 in general we prefer signed. When given a limit, use a
4065 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4066 latter isn't right if USE_2_TAGS_FOR_INTS.
4067 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4068 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4069
cabf1cac
SM
40702011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4071
4072 * textprop.c (text_property_stickiness):
4073 Obey Vtext_property_default_nonsticky.
4074 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4075 * w32fns.c (syms_of_w32fns):
4076 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4077
6e9b2be9
PE
40782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4081 This is more efficient than Ffile_directory_p and avoids a minor race.
4082
90186c68
LMI
40832011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4084
7c301272
LMI
4085 * buffer.c (Foverlay_put): Say what the return value is
4086 (bug#7835).
4087
c4f2d8d4
LMI
4088 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4089 is a directory before asking whether to use the file name
4090 (bug#7564).
ad637907
LMI
4091 (barf_or_query_if_file_exists): Make the "File is a directory"
4092 error be more correct.
c4f2d8d4 4093
90186c68
LMI
4094 * fns.c (Frequire): Remove the mention of the .gz files, since
4095 that's installation-specific, but keep the mention of
4096 `get-load-suffixes'.
4097
da64016e
PE
40982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4101 Report string overflow if the output is too long.
4102
7d47b580
JB
41032011-07-04 Juanma Barranquero <lekktu@gmail.com>
4104
a555cb87
JB
4105 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4106 (syms_of_gnutls): Remove duplicate DEFSYM for
4107 Qgnutls_bootprop_verify_hostname_error, an error for
4108 Qgnutls_bootprop_verify_error (which is no longer used).
4109
7d47b580
JB
4110 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4111 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4112 Also (re)move comments that are misplaced or no longer relevant.
4113
1e49bfab
LMI
41142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4115
4116 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4117
1485f4c0
CY
41182011-07-03 Chong Yidong <cyd@stupidchicken.com>
4119
4120 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4121 and background color parameters if they have been changed.
4122
a9ab721e
LMI
41232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4124
4125 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4126
cf7cff57
PE
41272011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4128
2e13213d
PE
4129 * xsettings.c (SYSTEM_FONT): Define only when used.
4130 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4131
cf7cff57
PE
4132 * keymap.c (access_keymap_1): Now static.
4133
7a8e04f7
CY
41342011-07-02 Chong Yidong <cyd@stupidchicken.com>
4135
4136 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4137 leave any prefix arg for the up event (Bug#1586).
4138
61352f62
LMI
41392011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4140
69bb1ef7
LMI
4141 * lread.c (syms_of_lread): Mention single symbols defined by
4142 `defvar' or `defconst' (bug#7154).
4143
61352f62 4144 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4145 (Frequire): Mention get-load-suffixes.
61352f62 4146
28545e04
MR
41472011-07-02 Martin Rudalics <rudalics@gmx.at>
4148
4149 * window.h (window): Remove clone_number slot.
4150 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4151 Remove.
4152 (make_parent_window, make_window, saved_window)
4153 (Fset_window_configuration, save_window_save): Don't deal with
4154 clone numbers.
4155 * buffer.c (Qclone_number): Remove declaration.
4156 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4157
3349e122
SM
41582011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 Add multiple inheritance to keymaps.
4161 * keymap.c (Fmake_composed_keymap): New function.
4162 (Fset_keymap_parent): Simplify.
4163 (fix_submap_inheritance): Remove.
4164 (access_keymap_1): New function extracted from access_keymap to handle
4165 embedded parents and handle lists of maps.
4166 (access_keymap): Use it.
4167 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4168 (Fcopy_keymap): Handle embedded parents.
4169 (Fcommand_remapping, define_as_prefix): Simplify.
4170 (Fkey_binding): Simplify.
4171 (syms_of_keymap): Move minibuffer-local-completion-map,
4172 minibuffer-local-filename-completion-map,
4173 minibuffer-local-must-match-map, and
4174 minibuffer-local-filename-must-match-map to Elisp.
4175 (syms_of_keymap): Defsubr make-composed-keymap.
4176 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4177 (parse_menu_item): Trivial simplification.
4178
3279eb87
GM
41792011-07-01 Glenn Morris <rgm@gnu.org>
4180
4181 * Makefile.in (SETTINGS_LIBS): Fix typo.
4182
4550efdf
KI
41832011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4184
4185 * coding.c (Fencode_coding_string): Record the last coding system
4186 used, as the function doc string says (bug#8738).
4187
0949d2b6
JD
41882011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4189
4190 * xsettings.c (store_monospaced_changed): Take new font as arg and
4191 check for change against current_mono_font.
4192 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4193 (emacs_settings_constructor, emacs_settings_get_property)
4194 (emacs_settings_set_property, emacs_settings_class_init)
4195 (emacs_settings_init, gsettings_obj): Remove.
4196 (something_changedCB): New function for HAVE_GSETTINGS.
4197 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4198 with value as argument.
4199 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4200 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4201 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4202 "changed".
4203
4204 * xgselect.c: Add defined (HAVE_GSETTINGS).
4205 (xgselect_initialize): Ditto.
4206
4207 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4208 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4209 xg_select.
4210
bbc6b304
PE
42112011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 * eval.c (struct backtrace): Simplify and port the data structure.
4214 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4215 signed bit field, as this assumption is not portable and it makes
4216 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4217 "char debug_on_exit : 1" as this is not portable either; instead,
4218 use the portable "unsigned int debug_on_exit : 1". Remove unused
4219 member evalargs. Remove obsolete comments about cc bombing out.
4220
9851bfc5
JD
42212011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4222
51bb811f 4223 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4224 Let HAVE_GSETTINGS override HAVE_GCONF.
4225 (store_monospaced_changed): New function.
4226 (EMACS_SETTINGS): A new type derived from GObject to handle
4227 GSettings notifications.
4228 (emacs_settings_constructor, emacs_settings_get_property)
4229 (emacs_settings_set_property, emacs_settings_class_init):
4230 New functions.
4231 (gsettings_client, gsettings_obj): New variables.
4232 (GSETTINGS_SCHEMA): New define.
4233 (something_changedCB): Call store_monospaced_changed.
4234 (init_gsettings): New function.
4235 (xsettings_initialize): Call init_gsettings.
4236 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4237 to NULL.
4238
640c8776 4239 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4240 GCONF_CFLAGS/LIBS.
4241
5386012d
MR
42422011-06-29 Martin Rudalics <rudalics@gmx.at>
4243
4244 * window.c (resize_root_window, grow_mini_window)
4245 (shrink_mini_window): Rename Qresize_root_window to
4246 Qwindow_resize_root_window and Qresize_root_window_vertically to
4247 Qwindow_resize_root_window_vertically.
4248
f13e0b08
PE
42492011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4252
94515237
JB
42532011-06-27 Juanma Barranquero <lekktu@gmail.com>
4254
4255 * makefile.w32-in: Redesign dependencies so they reflect more
4256 clearly which files are directly included by each source file,
4257 and not through other includes.
4258
e43b6e43
MR
42592011-06-27 Martin Rudalics <rudalics@gmx.at>
4260
4261 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4262 (sort_overlays, overlay_strings): When an overlay's clone number
4263 matches the window's clone number process the overlay even if
4264 the overlay's window property doesn't match the current window.
4265
d68443dc
MR
4266 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4267 (Fwindow_hchild): Rename to Fwindow_left_child.
4268 (Fwindow_next): Rename to Fwindow_next_sibling.
4269 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4270 (resize_window_check): Rename to window_resize_check.
4271 (resize_window_apply): Rename to window_resize_apply.
4272 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4273 (Fdelete_other_windows_internal, resize_frame_windows)
4274 (Fsplit_window_internal, Fdelete_window_internal)
4275 (grow_mini_window, shrink_mini_window)
4276 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4277
c7e73be5
JD
42782011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4279
4280 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4281 (emacs_fixed_set_min_size): Remove.
4282 (emacs_fixed_new): Take frame as argument.
4283
4284 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4285 (_EmacsFixedPrivate): Remove minwidth/height.
4286 Add struct frame *f.
4287 (emacs_fixed_init): Initialize priv->f.
4288 (get_parent_class, emacs_fixed_set_min_size): Remove.
4289 (emacs_fixed_new): Set priv->f to argument.
4290 (emacs_fixed_get_preferred_width)
4291 (emacs_fixed_get_preferred_height): Use min_width/height from
4292 frames size_hint to set minimum and natural (Bug#8919).
4293 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4294 and use min_width/height from frames size_hint to set
4295 min_width/height (Bug#8919).
4296
4297 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4298 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4299 Fix indentation.
c7e73be5 4300
cf99dcf8
EZ
43012011-06-26 Eli Zaretskii <eliz@gnu.org>
4302
4303 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4304 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4305 called at ZV.
4306
029529ac
CY
43072011-06-26 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * process.c (wait_reading_process_output): Bypass select if
4310 waiting for a cell while ignoring keyboard input, and input is
4311 pending. Suggested by Jan Djärv (Bug#8869).
4312
7a7ef429
PE
43132011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 Use gnulib's dup2 module instead of rolling our own.
4316 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4317
11fdef7d 43182011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4319
4320 * dispnew.c (scrolling_window): Before scrolling, turn off a
4321 mouse-highlight in the window being scrolled.
4322
cd3520a4
JB
43232011-06-24 Juanma Barranquero <lekktu@gmail.com>
4324
4325 Move DEFSYM to lisp.h and use everywhere.
4326
4327 * character.h (DEFSYM): Move declaration...
4328 * lisp.h (DEFSYM): ...here.
4329
4330 * gnutls.c:
4331 * minibuf.c:
4332 * w32menu.c:
4333 * w32proc.c:
4334 * w32select.c: Don't include character.h.
4335
4336 * alloc.c (syms_of_alloc):
4337 * buffer.c (syms_of_buffer):
4338 * bytecode.c (syms_of_bytecode):
4339 * callint.c (syms_of_callint):
4340 * casefiddle.c (syms_of_casefiddle):
4341 * casetab.c (init_casetab_once):
4342 * category.c (init_category_once, syms_of_category):
4343 * ccl.c (syms_of_ccl):
4344 * cmds.c (syms_of_cmds):
4345 * composite.c (syms_of_composite):
4346 * dbusbind.c (syms_of_dbusbind):
4347 * dired.c (syms_of_dired):
4348 * dispnew.c (syms_of_display):
4349 * doc.c (syms_of_doc):
4350 * editfns.c (syms_of_editfns):
4351 * emacs.c (syms_of_emacs):
4352 * eval.c (syms_of_eval):
4353 * fileio.c (syms_of_fileio):
4354 * fns.c (syms_of_fns):
4355 * frame.c (syms_of_frame):
4356 * fringe.c (syms_of_fringe):
4357 * insdel.c (syms_of_insdel):
4358 * keymap.c (syms_of_keymap):
4359 * lread.c (init_obarray, syms_of_lread):
4360 * macros.c (syms_of_macros):
4361 * msdos.c (syms_of_msdos):
4362 * print.c (syms_of_print):
4363 * process.c (syms_of_process):
4364 * search.c (syms_of_search):
4365 * sound.c (syms_of_sound):
4366 * syntax.c (init_syntax_once, syms_of_syntax):
4367 * terminal.c (syms_of_terminal):
4368 * textprop.c (syms_of_textprop):
4369 * undo.c (syms_of_undo):
4370 * w32.c (globals_of_w32):
4371 * window.c (syms_of_window):
4372 * xdisp.c (syms_of_xdisp):
4373 * xfaces.c (syms_of_xfaces):
4374 * xfns.c (syms_of_xfns):
4375 * xmenu.c (syms_of_xmenu):
4376 * xsettings.c (syms_of_xsettings):
4377 * xterm.c (syms_of_xterm): Use DEFSYM.
4378
4228cf16
TZ
43792011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4380
cd3520a4 4381 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4382
7fcccf1e
PE
43832011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4384
7efb4e0e
PE
4385 Integer and buffer overflow fixes (Bug#8873).
4386
ff5844ad
PE
4387 * print.c (printchar, strout): Check for string overflow.
4388 (PRINTPREPARE, printchar, strout):
4389 Don't set size unless allocation succeeds.
4390
90532f02
PE
4391 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4392 for sizes. Check for string overflow more accurately.
4393 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4394
6d84508d
PE
4395 * macros.c: Integer and buffer overflow fixes.
4396 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4397 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4398 Use ptrdiff_t, not int, for sizes.
4399 Don't increment bufsize until after realloc succeeds.
4400 Check for size-calculation overflow.
4401 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4402
437b2cb4
PE
4403 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4404
8b9ac8b4
PE
4405 * lread.c: Integer overflow fixes.
4406 (read_integer): Radix is now EMACS_INT, not int,
4407 to improve quality of diagnostics for out-of-range radices.
4408 Calculate buffer size correctly for out-of-range radices.
4409 (read1): Check for integer overflow in radices, and in
4410 read-circle numbers.
82cb60d3
PE
4411 (read_escape): Avoid int overflow.
4412 (Fload, openp, read_buffer_size, read1)
4413 (substitute_object_recurse, read_vector, read_list, map_obarray):
4414 Use ptrdiff_t, not int, for sizes.
4415 (read1): Use EMACS_INT, not int, for sizes.
20270765 4416 Check for size overflow.
8b9ac8b4 4417
7fcccf1e
PE
4418 * image.c (cache_image): Check for size arithmetic overflow.
4419
bfbbd7e7
PE
4420 * lread.c: Integer overflow issues.
4421 (saved_doc_string_size, saved_doc_string_length)
4422 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4423 Now ptrdiff_t, not int.
4424 (read1): Don't assume doc string length fits in int. Check for
4425 out-of-range doc string lengths.
4426 (read_list): Don't assume file position fits in int.
39019e54 4427 (read_escape): Check for hex character overflow.
bfbbd7e7 4428
4e323265
LL
44292011-06-22 Leo Liu <sdl.web@gmail.com>
4430
4431 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4432 Move to minibuffer.el.
4433
85fece3e
PE
44342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4435
20b84ce9 4436 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4437 The following patches are for when GLYPH_DEBUG && !XASSERT.
4438 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4439 * dispnew.c (flush_stdout):
4440 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4441 Mark as externally visible.
4442 * dispnew.c (check_window_matrix_pointers): Now static.
4443 * dispnew.c (window_to_frame_vpos):
4444 * xfns.c (unwind_create_frame):
4445 * xterm.c (x_check_font): Remove unused local.
4446 * scroll.c (CHECK_BOUNDS):
4447 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4448 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4449 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4450 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4451 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4452 Now static.
4453 (debug_method_add): Use va_list and vsprintf rather than relying
4454 on undefined behavior with wrong number of arguments.
4455 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4456 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4457 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4458 since we're not interested in debugging glyphs with old libraries.
4459 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4460 GCC 4.6.0's static checking.
4461
0766b489
PE
44622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4463
31fd4b32
PE
4464 Integer overflow and signedness fixes (Bug#8873).
4465 A few related buffer overrun fixes, too.
4466
b79e8648
PE
4467 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4468
0766b489
PE
4469 * dispextern.h (struct face.stipple):
4470 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4471 (x_bitmap_mask, x_allocate_bitmap_record)
4472 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4473 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4474 (x_create_bitmap_from_xpm_data):
4475 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4476 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4477 (.bitmaps_last):
4478 * xfaces.c (load_pixmap):
4479 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4480 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4481 (.bitmaps_last, struct x_output.icon_bitmap):
4482 Use ptrdiff_t, not int, for bitmap indexes.
4483 (x_allocate_bitmap_record): Check for size overflow.
4484 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4485
b081724f
PE
4486 Use ptrdiff_t, not int, for overlay counts.
4487 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4488 * editfns.c (overlays_around, get_pos_property):
4489 * textprop.c (get_char_property_and_overlay):
4490 * xdisp.c (next_overlay_change, note_mouse_highlight):
4491 * xfaces.c (face_at_buffer_position):
21514da7
PE
4492 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4493 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4494 (Fnext_overlay_change, Fprevious_overlay_change)
4495 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4496 Use ptrdiff_t, not int, for sizes.
21514da7 4497 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4498
3de73e5e
PE
4499 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4500
2606c57b
PE
4501 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4502 (x_session_initialize): Do not assume string length fits in int.
4503
aaafe47a
PE
4504 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4505 This is unlikely, but can occur if DPI is outlandish.
4506
2674ddc8 4507 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4508 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4509
28154962
PE
4510 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4511 * xrdb.c (magic_file_p, search_magic_path):
4512 Omit last arg SUFFIX; it was always 0. All callers changed.
4513 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4514
7de51af5
PE
4515 * xfont.c (xfont_match): Avoid need for strlen.
4516
25ed6cc3
PE
4517 * xfns.c: Don't assume strlen fits in int.
4518 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4519
4eab31dd
PE
4520 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4521 not unsigned long, as we prefer signed integers. All callers changed.
4522 Detect integer overflow in repeat count.
4523 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4524 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4525
171e2a58
PE
4526 * termcap.c: Don't assume sizes fit in int and never overflow.
4527 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4528 (gobble_line): Check for size-calculation overflow.
4529
ad39faca 4530 * minibuf.c (Fread_buffer):
6e5bb2dc 4531 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4532 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4533 Don't assume string length fits in int.
4534
52c61c22 4535 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4536 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4537
b5b8c9e5
PE
4538 * font.c: Don't assume string length fits in int.
4539 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4540 Use ptrdiff_t, not int.
ccd6111c
PE
4541 (font_intern_prop): Don't assume string length fits in int.
4542 Don't assume integer property fits in fixnum.
4543 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4544
882f0d81 4545 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4546 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4547 Reformulate so as not to need the command string.
4548 Invoke gzip -cd rather than gunzip, as it's more portable.
4549 (lock_info_type, lock_file_1, lock_file):
4550 Don't assume pid_t and time_t fit in unsigned long.
4551 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4552 (current_lock_owner): Prefer signed type for sizes.
4553 Use memcpy, not strncpy, where memcpy is what is really wanted.
4554 Don't assume (via atoi) that time_t and pid_t fit in int.
4555 Check for time_t and/or pid_t out of range, e.g., via a network share.
4556 Don't alloca where an auto var works fine.
4557
93f4cf88
PE
4558 * fileio.c: Fix some integer overflow issues.
4559 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4560 Don't assume string length fits in int.
4561 (directory_file_name): Don't assume string length fits in long.
4562 (make_temp_name): Don't assume pid fits in int, or that its print
4563 length is less than 20.
4564
f3e92b69
PE
4565 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4566
1bfdaf10
PE
4567 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4568
35016e9a
PE
4569 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4570
3d1e65a1
PE
4571 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4572 We prefer signed integers, even for size calculations.
4573
0b963a93
PE
4574 * emacs.c: Don't assume string length fits in 'int'.
4575 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4576 (main): Don't invoke strlen when not needed.
4577
573f4b54
PE
4578 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4579 (XD_DEBUG_MESSAGE): Don't waste a byte.
4580
989f33ba
PE
4581 * callproc.c (getenv_internal_1, getenv_internal)
4582 (Fgetenv_internal):
965d34eb
PE
4583 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4584
e4d29b33
PE
4585 * lread.c (invalid_syntax): Omit length argument.
4586 All uses changed. This doesn't fix a bug, but it simplifies the
4587 code away from its former Hollerith-constant appearance, and it's
4588 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4589 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4590
eb49b136
PE
4591 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4592 This didn't break anything, but it didn't help either.
4593 It's confusing to put a bogus integer in a place where the actual
4594 value does not matter.
9f62aeb1 4595 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4596 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4597
15375a22
PE
4598 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4599 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4600 implementation.
b61cc01c
PE
4601 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4602 We prefer signed types, and the value cannot exceed the EMACS_INT
4603 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4604 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4605 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4606 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4607
53b2623d
PE
4608 * indent.c (sane_tab_width): New function.
4609 (current_column, scan_for_column, Findent_to, position_indentation)
4610 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4611 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4612
51cab52b 4613 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4614
f2ed8a70
PE
4615 * lisp.h (lint_assume): New macro.
4616 * composite.c (composition_gstring_put_cache):
4617 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4618
abe80cc6
PE
4619 * editfns.c, insdel.c:
4620 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4621
b02c740e
PE
4622 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4623
ebc96716
PE
4624 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4625
b4e50fa0 4626 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4627 Use much-faster test for byte-length change.
311d5d7c 4628 Don't assume string byte-length fits in 'int'.
a4cf38e4 4629 Check that character arg fits in 'int'.
85461888 4630 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4631
c0c1ee9f
PE
4632 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4633
a498d7f4
PE
4634 * fns.c (concat): Catch string overflow earlier.
4635 Do not rely on integer wraparound.
4636
51cab52b
PE
4637 * dispextern.h (struct it.overlay_strings_charpos)
4638 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4639 * xdisp.c (forward_to_next_line_start)
4640 (back_to_previous_visible_line_start)
4641 (reseat_at_next_visible_line_start, next_element_from_buffer):
4642 Don't arbitrarily truncate the value of 'selective' to int.
4643
76031fad
PE
4644 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4645
5eb55db9
PE
4646 * composite.c: Don't truncate sizes to 'int'.
4647 (composition_gstring_p, composition_reseat_it)
4648 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4649 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4650 not EMACS_UINT, for indexes.
5eb55db9 4651
0703a717
PE
4652 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4653
d6202519
PE
4654 * buffer.c: Include <verify.h>.
4655 (struct sortvec.priority, struct sortstr.priority):
8961a454 4656 Now EMACS_INT, not int.
c20998a7 4657 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4658 (struct sortstr.size, record_overlay_string)
4659 (struct sortstrlist.size, struct sortlist.used):
4660 Don't truncate size to int.
4661 (record_overlay_string): Check for size-calculation overflow.
d6202519 4662 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4663
d5a19415
JM
46642011-06-22 Jim Meyering <meyering@redhat.com>
4665
029529ac 4666 Don't leak an XBM-image-sized buffer
d5a19415
JM
4667 * image.c (xbm_load): Free the image buffer after using it.
4668
a9041e6c
PE
46692011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 Port to Sun C.
4672 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4673 that Sun C diagnosed.
4674 * fns.c (secure_hash): Fix pointer signedness issue.
4675 * intervals.c (static_offset_intervals): New function.
4676 (offset_intervals): Use it.
4677
7f3f739f
LL
46782011-06-21 Leo Liu <sdl.web@gmail.com>
4679
4680 * deps.mk (fns.o):
4681 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4682 sha512.h.
4683
4684 * fns.c (secure_hash): Rename from crypto_hash_function and change
4685 the first arg to accept symbols.
5b66d427 4686 (Fsecure_hash): New primitive.
7f3f739f
LL
4687 (syms_of_fns): New symbols.
4688
76147d94
DD
46892011-06-20 Deniz Dogan <deniz@dogan.se>
4690
4691 * process.c (Fset_process_buffer): Clarify return value in
4692 docstring.
4693
7d7d0045
CY
46942011-06-18 Chong Yidong <cyd@stupidchicken.com>
4695
4696 * dispnew.c (add_window_display_history): Use BVAR.
4697
4698 * xdisp.c (debug_method_add): Use BVAR.
4699 (check_window_end, dump_glyph_matrix, dump_glyph)
4700 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4701
4702 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4703 Likewise.
4704
4705 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4706 check till after the cache is created in init_frame_faces.
4707
ff2bc410
SM
47082011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4709
4710 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4711
28177add
PE
47122011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4713
dd3482fe
PE
4714 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4715 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4716 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4717
393d71f3 4718 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4719 * fileio.c (Finsert_file_contents):
4720 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4721 Remove the old (too-loose) buffer overflow checks.
4722 They weren't needed, since make_gap checks for buffer overflow.
4723 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4724 The old code merely checked for Emacs fixnum overflow, and relied
4725 on undefined (wraparound) behavior. The new code avoids undefined
4726 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4727
2e6813b0 4728 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4729 Tune. Don't use wider integers than needed. Don't use alloca.
4730 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4731
599a9e4f
PE
4732 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4733
99561444
PE
4734 * insdel.c, lisp.h (buffer_overflow): New function.
4735 (insert_from_buffer_1, replace_range, replace_range_2):
4736 * insdel.c (make_gap_larger):
4737 * editfns.c (Finsert_char):
4738 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4739
28177add
PE
4740 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4741
e69dafad
PE
47422011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4743
4baa020d 4744 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4745
b1c46f02
PE
4746 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4747 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4748
e69dafad
PE
4749 * fileio.c: Don't assume EMACS_INT fits in off_t.
4750 (emacs_lseek): New static function.
4751 (Finsert_file_contents, Fwrite_region): Use it.
4752 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4753
566684ea
PE
4754 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4755
e6966cd6
PE
4756 * fns.c: Don't overflow int when computing a list length.
4757 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4758 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4759 truncation on 64-bit hosts. Check for QUIT every
4760 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4761 faster and is responsive enough.
4762 (Flength): Report an error instead of overflowing an integer.
4763 (Fsafe_length): Return a float if the value is not representable
4764 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4765 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4766 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4767
dd0b0efb
PE
4768 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4769 (header_size, word_size): New constants.
4770 (allocate_vectorlike): Don't check size overflow here.
4771 (allocate_vector): Check it here instead, since this is the only
4772 caller of allocate_vectorlike that could cause overflow.
4773 Check that the new vector's length is representable as a fixnum.
4774
86fe5cfe
PE
4775 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4776 The previous code was bogus. For example, next_almost_prime (32)
4777 returned 39, which is undesirable as it is a multiple of 3; and
4778 next_almost_prime (24) returned 25, which is a multiple of 5 so
4779 why was the code bothering to check for multiples of 7?
4780
80e88859
PE
4781 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4782
4a2f0ad6
PE
4783 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4784
f66c7cf8
PE
4785 Variadic C functions now count arguments with ptrdiff_t.
4786 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4787 Back then I didn't know that the Emacs coding style prefers signed int.
4788 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4789 were being counted with int, which may truncate counts on 64-bit
4790 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4791 * lisp.h (struct Lisp_Subr.function.aMANY)
4792 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4793 Arg counts are now ptrdiff_t, not size_t.
4794 All variadic functions and their callers changed accordingly.
4795 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4796 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4797 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4798 * callint.c (Fcall_interactively): Check arg count for overflow,
4799 to avoid potential buffer overrun. Use signed char, not 'int',
4800 for 'varies' array, so that we needn't bother to check its size
4801 calculation for overflow.
4802 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4803 * eval.c (apply_lambda):
4804 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4805 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4806 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4807
a1759b76
PE
4808 * callint.c (Fcall_interactively): Don't use index var as event count.
4809
d96be9fc
PE
4810 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4811 * mem-limits.h (SIZE): Remove; no longer used.
4812
a690a978 4813 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4814
578c21e6
PE
4815 Remove unnecessary casts.
4816 * xterm.c (x_term_init):
4817 * xfns.c (x_set_border_pixel):
4818 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4819 These aren't needed now that we assume ANSI C.
4820
96f53c6c
PE
4821 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4822 It's more likely to cause problems (due to unsigned overflow)
4823 than to cure them.
4824
83c77d31
PE
4825 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4826
ee2079f1
PE
4827 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4828
6da65536
PE
4829 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4830
7147c4a4
PE
4831 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4832
193e32d9
PE
4833 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4834
e5533da6
PE
4835 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4836
9910e595
PE
4837 GLYPH_CODE_FACE returns EMACS_INT, not int.
4838 * dispextern.h (merge_faces):
4839 * xfaces.c (merge_faces):
01103c44
PE
4840 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4841 Don't assume EMACS_INT fits in int.
9910e595 4842
2638320e
PE
4843 * character.h (CHAR_VALID_P): Remove unused parameter.
4844 * fontset.c, lisp.h, xdisp.c: All uses changed.
4845
045eb8d9
PE
4846 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4847
c1f134b5
PE
4848 * fns.c (concat): Minor tuning based on overflow analysis.
4849 This doesn't fix any bugs. Use int to hold character, instead
4850 of constantly refetching from Emacs object. Use XFASTINT, not
4851 XINT, for value known to be a character. Don't bother comparing
4852 a single byte to 0400, as it's always less.
4853
395fcb93 4854 * floatfns.c (Fexpt):
327eeec8
PE
4855 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4856
abbd3d23
PE
4857 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4858 for characters.
4859
684a03ef
PE
4860 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4861
0fed43f3
PE
4862 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4863 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4864 incorrectly succeed when S was a string, because 4294967386 was
4865 truncated before it was used.
4866
8fd02eb7
PE
4867 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4868 Otherwise, an out-of-range integer could cause undefined behavior
4869 on a 64-bit host.
4870
f8c86b69
PE
4871 * composite.c: Use int, not EMACS_INT, for characters.
4872 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4873 EMACS_INT, for values that are known to be in character range.
4874 This doesn't fix any bugs but is the usual style inside Emacs and
4875 may generate better code on 32-bit machines.
4876
34206dd2
PE
4877 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4878 This is for reasons similar to the recent CHAR_STRING fix.
4879 * charset.c (Fencode_char): Check that character arg is actually
4880 a character. Pass an int to ENCODE_CHAR.
4881 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4882 wider than 'int', as a compile-time check to prevent future regressions
4883 in this area.
4884
c5958d4c 4885 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4886
4887 Make sure a 64-bit char is never passed to CHAR_STRING.
4888 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4889 by silently ignoring the top 32 bits, allowing some values
4890 that were far too large to be valid characters.
4891 * character.h: Include <verify.h>.
4892 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4893 arguments are no wider than unsigned, as a compile-time check
4894 to prevent future regressions in this area.
4895 * data.c (Faset):
01103c44 4896 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4897 (Fsubst_char_in_region):
4898 * fns.c (concat):
4899 * xdisp.c (decode_mode_spec_coding):
4900 Adjust to CHAR_STRING's new requirement.
4901 * editfns.c (Finsert_char, Fsubst_char_in_region):
4902 * fns.c (concat): Check that character args are actually
4903 characters. Without this test, these functions did the wrong
4904 thing with wildly out-of-range values on 64-bit hosts.
4905
d37ca623
PE
4906 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4907 These casts should not be needed on 32-bit hosts, either.
4908 * keyboard.c (read_char):
4909 * lread.c (Fload): Remove casts to unsigned.
4910
ea204efb
PE
4911 * lisp.h (UNSIGNED_CMP): New macro.
4912 This fixes comparison bugs on 64-bit hosts.
4913 (ASCII_CHAR_P): Use it.
4914 * casefiddle.c (casify_object):
01103c44 4915 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4916 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4917 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4918 * dispextern.h (FACE_FROM_ID):
4919 * keyboard.c (read_char): Use UNSIGNED_CMP.
4920
41cb286c
PE
4921 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4922 not to EMACS_INT, to avoid GCC warning.
4923
4a1b9832
PE
4924 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4925
55daad71
PE
4926 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4927 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4928 isn't needed on 32-bit machines.
8f95c75c 4929
01103c44
PE
4930 * buffer.c (Fgenerate_new_buffer_name):
4931 Use EMACS_INT for count, not int.
0ceccced 4932 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4933
4934 * data.c (Qcompiled_function): Now static.
4935
c6f072e7
PE
4936 * window.c (window_body_lines): Now static.
4937
20ce5912
PE
4938 * image.c (gif_load): Rename local to avoid shadowing.
4939
9c4c5f81
PE
4940 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4941 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4942 * alloc.c (make_save_value): Integer argument is now of type
4943 ptrdiff_t, not int.
4944 (mark_object): Use ptrdiff_t, not int.
4945 * lisp.h (pD): New macro.
4946 * print.c (print_object): Use it.
4947
c0c5c8ae
PE
4948 * alloc.c: Use EMACS_INT, not int, to count objects.
4949 (total_conses, total_markers, total_symbols, total_vector_size)
4950 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4951 (total_free_floats, total_floats, total_free_intervals)
4952 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4953 Now EMACS_INT, not int. All uses changed.
4954 (Fgarbage_collect): Compute overall total using a double, so that
4955 integer overflow is less likely to be a problem. Check for overflow
4956 when converting back to an integer.
5a25e253
PE
4957 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4958 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4959 These were 'int' variables that could overflow on 64-bit hosts;
4960 they were never used, so remove them instead of repairing them.
211a0b2a 4961 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4962 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4963 Previously, this ceilinged at INT_MAX, but that doesn't work on
4964 64-bit machines.
e46bb31a 4965 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4966
c78baabf 4967 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4968 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4969 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4970 when a (possibly-narrower) signed value would do just as well.
4971 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4972
c9d624c6
PE
4973 * alloc.c: Catch some string size overflows that we were missing.
4974 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4975 for convenience in STRING_BYTES_MAX.
4976 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4977 The definition here is exact; the one in lisp.h was approximate.
4978 (allocate_string_data): Check for string overflow. This catches
4979 some instances we weren't catching before. Also, it catches
4980 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4981 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4982 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4983
c9d624c6
PE
4984 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4985 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4986 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4987
353032ce
PE
4988 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4989
2bccce07
PE
4990 * alloc.c (Fmake_string): Check for out-of-range init.
4991
0ac30604
SM
49922011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4993
4994 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4995
c195f2de
JD
49962011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4997
4998 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4999 xg_get_default_scrollbar_width.
5000
5001 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5002 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5003 (style_changed_cb): Call update_theme_scrollbar_width and call
5004 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5005 all frames (Bug#8505).
5006 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5007 Call gtk_window_set_resizable if HAVE_GTK3.
5008 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5009 and height if HAVE_GTK3 (Bug#8505).
5010 (scroll_bar_width_for_theme): New variable.
5011 (update_theme_scrollbar_width): New function.
5012 (xg_get_default_scrollbar_width): Move code to
5013 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5014 (xg_initialize): Call update_theme_scrollbar_width.
5015
5016 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5017
5018 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5019
e10ac9f1
MR
50202011-06-12 Martin Rudalics <rudalics@gmx.at>
5021
5022 * frame.c (make_frame): Call other_buffer_safely instead of
5023 other_buffer.
5024
5025 * window.c (temp_output_buffer_show): Call display_buffer with
5026 second argument Vtemp_buffer_show_specifiers and reset latter
5027 immediately after the call.
5028 (Vtemp_buffer_show_specifiers): New variable.
5029 (auto_window_vscroll_p, next_screen_context_lines)
5030 (Vscroll_preserve_screen_position): Remove leading asterisks from
5031 doc-strings.
5032
2d3c217e 50332011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5034
7b7f97e8 5035 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5036 * buffer.c (Qclone_number): Remove for now, as it's unused.
5037 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5038 (record_buffer): Remove unused local.
5039 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5040 (set_frame_buffer_list): Remove; unused.
5041 * frame.h (other_visible_frames): Remove decl.
5042 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5043 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5044 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5045 if HAVE_GPM.
5046 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5047 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5048 Define only if HAVE_GPM.
5049 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5050 (update_hints_inhibit): Remove; never set. All uses removed.
5051 * widgetprv.h (emacsFrameClassRec): Remove decl.
5052 * window.c (delete_deletable_window): Now returns void, since it
5053 wasn't returning anything.
5054 (compare_window_configurations): Remove unused locals.
5055 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5056 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5057 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5058 the same widths as pointers. This follows up on the 2011-05-06 patch.
5059 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5060 * xterm.h: Likewise.
5061 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5062
1384b89e
JB
50632011-06-12 Juanma Barranquero <lekktu@gmail.com>
5064
5065 * makefile.w32-in: Update dependencies.
5066 (LISP_H): Add lib/intprops.h.
5067
1100a63c
CY
50682011-06-11 Chong Yidong <cyd@stupidchicken.com>
5069
5070 * image.c (gif_load): Add animation frame delay to the metadata.
5071 (syms_of_image): Use DEFSYM. New symbol `delay'.
5072
6198ccd0
MR
50732011-06-11 Martin Rudalics <rudalics@gmx.at>
5074
5075 * window.c (delete_deletable_window): Re-add.
5076 (Fset_window_configuration): Rewrite to handle dead buffers and
5077 consequently deletable windows.
5078 (window_tree, Fwindow_tree): Remove. Supply functionality in
5079 window.el.
5080 (compare_window_configurations): Simplify code.
5081
b6e3633c
AS
50822011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5083
1ab0dee5
AS
5084 * image.c (imagemagick_load_image): Fix type mismatch.
5085 (Fimagemagick_types): Likewise.
5086
b6e3633c
AS
5087 * window.h (replace_buffer_in_windows): Declare.
5088
9397e56f
MR
50892011-06-11 Martin Rudalics <rudalics@gmx.at>
5090
5091 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5092 Qclone_number. Remove external declaration of Qdelete_window.
5093 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5094 code.
640c8776
SM
5095 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5096 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5097 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5098 buffer list implementation.
5099 (other_buffer_safely): New function.
5100 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5101 calls to replace_buffer_in_windows and
5102 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5103 if allowed.
5104 (record_buffer): Inhibit quitting and rewrite using quittable
5105 functions. Run Qbuffer_list_update_hook if allowed.
5106 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5107 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5108 Move switch-to-buffer to window.el.
9397e56f
MR
5109 (bury-buffer): Move to window.el.
5110 (Vbuffer_list_update_hook): New variable.
5111
5112 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5113 section.
5114
5115 * window.h (resize_frame_windows): Move up in code.
5116 (Fwindow_frame): Remove EXFUN.
5117 (replace_buffer_in_all_windows): Remove prototype.
5118 (replace_buffer_in_windows_safely): Add prototype.
5119
5120 * window.c: Declare Qdelete_window static again. Move down
5121 declaration of select_count.
5122 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5123 (Fother_window): Move to window.el.
5124 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5125 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5126 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5127 window.el.
5128 (replace_buffer_in_windows): Implement by calling
5129 Qreplace_buffer_in_windows.
5130 (replace_buffer_in_all_windows): Remove with some functionality
5131 moved into replace_buffer_in_windows_safely.
5132 (replace_buffer_in_windows_safely): New function.
5133 (select_window_norecord, select_frame_norecord): Move in front
5134 of run_window_configuration_change_hook. Remove now obsolete
5135 declarations.
640c8776
SM
5136 (Fset_window_buffer): Rewrite doc-string.
5137 Call Qrecord_window_buffer.
9397e56f
MR
5138 (keys_of_window): Move binding for other-window to window.el.
5139
b50691aa
CY
51402011-06-11 Chong Yidong <cyd@stupidchicken.com>
5141
5142 * dispextern.h (struct image): Replace data member, whose int_val
5143 and ptr_val fields were not used by anything, with a single
5144 lisp_val object.
5145
5146 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5147 (gif_clear_image, gif_load, imagemagick_load_image)
5148 (gs_clear_image, gs_load): Callers changed.
5149
3f754b86
PE
51502011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5151
cca69397
PE
5152 * buffer.h: Include <time.h>, for time_t.
5153 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5154
109e28d0
PE
5155 Fix minor problems found by static checking.
5156
60737f02
PE
5157 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5158
4b66faf3
PE
5159 Make identifiers static if they are not used in other modules.
5160 * data.c (Qcompiled_function, Qframe, Qvector):
5161 * image.c (QimageMagick, Qsvg):
5162 * minibuf.c (Qmetadata):
5163 * window.c (resize_window_check, resize_root_window): Now static.
5164 * window.h (resize_window_check, resize_root_window): Remove decls.
5165
109e28d0
PE
5166 * window.c (window_deletion_count, delete_deletable_window):
5167 Remove; unused.
46a4ce9e
PE
5168 (window_body_lines): Now static.
5169 (Fdelete_other_windows_internal): Mark vars as initialized.
5170 Make sure 'resize_failed' is initialized.
5171 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5172 (resize_window_apply): Remove unused local.
5173 * window.h (delete_deletable_window): Remove decl.
5174
109e28d0 5175 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5176 (imagemagick_load_image): Fix pointer signedness problem by changing
5177 last arg from unsigned char * to char *. All uses changed.
5178 Also, fix a local for similar reasons.
5179 Remove unused locals. Remove locals to avoid shadowing.
5180 (fn_rsvg_handle_free): Remove; unused.
5181 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5182 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5183
3f754b86
PE
5184 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5185
2547adb1
CY
51862011-06-10 Chong Yidong <cyd@stupidchicken.com>
5187
5188 * image.c (gif_load): Fix omitted cast error introduced by
5189 2011-06-06 change.
5190
2c8e37d4
MR
51912011-06-10 Martin Rudalics <rudalics@gmx.at>
5192
5193 * window.h (resize_proportionally, orig_total_lines)
5194 (orig_top_line): Remove from window structure.
5195 (set_window_height, set_window_width, change_window_heights)
5196 (Fdelete_window): Remove prototypes.
5197 (resize_frame_windows): Remove duplicate declaration.
5198
440a42e3
EZ
51992011-06-10 Eli Zaretskii <eliz@gnu.org>
5200
5201 * window.h (resize_frame_windows, resize_window_check)
5202 (delete_deletable_window, resize_root_window)
5203 (resize_frame_windows): Declare prototypes.
5204
5205 * window.c (resize_window_apply): Make definition be "static" to
5206 match the prototype.
5207
562dd5e9
MR
52082011-06-10 Martin Rudalics <rudalics@gmx.at>
5209
5210 * window.c: Remove declarations of Qwindow_size_fixed,
5211 window_min_size_1, window_min_size_2, window_min_size,
5212 size_window, window_fixed_size_p, enlarge_window, delete_window.
5213 Remove static from declaration of Qdelete_window, it's
5214 temporarily needed by Fbury_buffer.
5215 (replace_window): Don't assign orig_top_line and
5216 orig_total_lines.
5217 (Fdelete_window, delete_window): Remove. Window deletion is
5218 handled by window.el.
640c8776
SM
5219 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5220 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5221 (Fdelete_other_windows): Remove. Deleting other windows is
5222 handled by window.el.
5223 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5224 handled in window.el.
5225 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5226 Window minimum sizes are handled in window.el.
5227 (shrink_windows, size_window, set_window_height)
5228 (set_window_width, change_window_heights, window_height)
5229 (window_width, CURBEG, CURSIZE, enlarge_window)
5230 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5231 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5232 handled in window.el.
5233 (make_dummy_parent): Rename to make_parent_window and give it a
5234 second argument horflag.
5235 (make_window): Don't set resize_proportionally any more.
5236 (Fsplit_window): Remove. Windows are split in window.el.
5237 (save_restore_action, save_restore_orig_size)
5238 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5239 Resize mini windows in window.el.
5240 (grow_mini_window, shrink_mini_window): Implement by calling
5241 Qresize_root_window_vertically, resize_window_check and
5242 resize_window_apply.
640c8776
SM
5243 (saved_window, Fset_window_configuration, save_window_save):
5244 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5245 resize_proportionally.
5246 (window_min_height, window_min_width): Move to window.el.
5247 (keys_of_window): Move bindings for delete-other-windows,
5248 split-window, delete-window and enlarge-window to window.el.
5249
5250 * buffer.c: Temporarily extern Qdelete_window.
5251 (Fbury_buffer): Temporarily call Qdelete_window instead of
5252 Fdelete_window (Fbury_buffer will move to window.el soon).
5253
5254 * frame.c (set_menu_bar_lines_1): Remove code handling
5255 orig_top_line and orig_total_lines.
5256
5257 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5258 set_window_height but set heights directly.
5259 (change_frame_size_1): Use resize_frame_windows.
5260
5261 * xdisp.c (init_xdisp): Don't use set_window_height but set
5262 heights directly.
5263
640c8776
SM
5264 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5265 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5266 run_window_configuration_change_hook.
5267
5268 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5269 instead of change_window_heights and run
5270 run_window_configuration_change_hook.
5271
1a13852e
MR
52722011-06-09 Martin Rudalics <rudalics@gmx.at>
5273
5274 * window.c (replace_window): Rename second argument REPLACEMENT to
5275 NEW. New third argument SETFLAG. Rewrite.
5276 (delete_window, make_dummy_parent): Call replace_window with
5277 third argument 1.
5278 (window_list_1): Move down in code.
5279 (run_window_configuration_change_hook): Move set_buffer part
5280 before select_frame_norecord part in order to unwind correctly.
5281 Rename count1 to count.
5282 (recombine_windows, delete_deletable_window, resize_root_window)
5283 (Fdelete_other_windows_internal)
5284 (Frun_window_configuration_change_hook, make_parent_window)
5285 (resize_window_check, resize_window_apply, Fresize_window_apply)
5286 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5287 (Fdelete_window_internal, Fresize_mini_window_internal):
5288 New functions.
1a13852e
MR
5289 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5290
f3d1777e
MR
52912011-06-08 Martin Rudalics <rudalics@gmx.at>
5292
496e208e
MR
5293 * window.h (window): Add some new members to window structure -
5294 normal_lines, normal_cols, new_total, new_normal, clone_number,
5295 splits, nest, prev_buffers, next_buffers.
5296 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5297 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5298
f3d1777e
MR
5299 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5300 Remove.
496e208e
MR
5301 (make_dummy_parent): Set new members of windows structure.
5302 (make_window): Move down in code. Handle new members of window
5303 structure.
5304 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5305 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5306 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5307 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5308 (Fset_window_next_buffers, Fset_window_clone_number):
5309 New functions.
496e208e
MR
5310 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5311 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5312 Doc-string fixes.
5313 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5314 Argument WINDOW can be now internal window too.
5315 (Fwindow_use_time): Move up in code.
5316 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5317 Rewrite doc-string.
5318 (Fset_window_configuration, saved_window)
5319 (Fcurrent_window_configuration, save_window_save): Handle new
5320 members of window structure.
b9e809c2
MR
5321 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5322 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5323 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5324 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5325 Qget_mru_window, Qresize_root_window,
5326 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5327 Qauto_buffer_name; staticpro them.
f3d1777e 5328
abde8f8c
MR
53292011-06-07 Martin Rudalics <rudalics@gmx.at>
5330
5331 * window.c (Fwindow_total_size, Fwindow_left_column)
5332 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5333 (Fwindow_list_1): New functions.
5334 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5335 (Fwindow_width, Fscroll_left, Fscroll_right):
5336 Use window_body_cols instead of window_box_text_cols.
5337 (delete_window, Fset_window_configuration):
5338 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5339 (delete_all_subwindows): Take a window as argument and not a
5340 structure. Rewrite.
190b47e6
MR
5341 (window_loop): Remove handling of GET_LRU_WINDOW and
5342 GET_LARGEST_WINDOW.
5343 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5344
5345 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5346 window_box_text_cols. delete_all_subwindows now takes a
5347 Lisp_Object as argument.
abde8f8c 5348
640c8776
SM
5349 * indent.c (compute_motion, Fcompute_motion):
5350 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5351
fa8a67e6
MR
5352 * frame.c (delete_frame): Call delete_all_subwindows with root
5353 window as argument.
5354
a54e3482
DC
53552011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5356
5357 * fns.c (Fputhash): Document return value.
5358
60002bf5
CY
53592011-06-06 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5362
0c671da6 53632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5364
b862a52a 5365 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5366
be44ca6c
PE
5367 Check for overflow when converting integer to cons and back.
5368 * charset.c (Fdefine_charset_internal, Fdecode_char):
5369 Use cons_to_unsigned to catch overflow.
5370 (Fencode_char): Use INTEGER_TO_CONS.
5371 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5372 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5373 * data.c (long_to_cons, cons_to_long): Remove.
5374 (cons_to_unsigned, cons_to_signed): New functions.
5375 These signal an error for invalid or out-of-range values.
5376 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5377 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5378 * font.c (Ffont_variation_glyphs):
5379 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5380 * lisp.h: Include <intprops.h>.
5381 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5382 (cons_to_signed, cons_to_unsigned): New decls.
5383 (long_to_cons, cons_to_long): Remove decls.
5384 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5385 (Fprimitive_undo): Use CONS_TO_INTEGER.
5386 * xfns.c (Fx_window_property): Likewise.
5387 * xselect.c: Include <limits.h>.
5388 (x_own_selection, selection_data_to_lisp_data):
5389 Use INTEGER_TO_CONS.
5390 (x_handle_selection_request, x_handle_selection_clear)
5391 (x_get_foreign_selection, Fx_disown_selection_internal)
5392 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5393 (lisp_data_to_selection_data): Use cons_to_unsigned.
5394 (x_fill_property_data): Use cons_to_signed.
5395 Report values out of range.
5396
d1f3d2af
PE
5397 Check for buffer and string overflow more precisely.
5398 * buffer.h (BUF_BYTES_MAX): New macro.
5399 * lisp.h (STRING_BYTES_MAX): New macro.
5400 * alloc.c (Fmake_string):
5401 * character.c (string_escape_byte8):
5402 * coding.c (coding_alloc_by_realloc):
5403 * doprnt.c (doprnt):
5404 * editfns.c (Fformat):
5405 * eval.c (verror):
5406 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5407 since they may not be the same number.
5408 * editfns.c (Finsert_char):
5409 * fileio.c (Finsert_file_contents):
5410 Likewise for BUF_BYTES_MAX.
5411
dd52fcea
PE
5412 * image.c: Use ptrdiff_t, not int, for sizes.
5413 (slurp_file): Switch from int to ptrdiff_t.
5414 All uses changed.
5415 (slurp_file): Check that file size fits in both size_t (for
5416 malloc) and ptrdiff_t (for sanity and safety).
5417
7f9bbdbb
PE
5418 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5419 if b->modtime has its maximal value.
5420
dfe18f82
PE
5421 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5422
84acfcf0
PE
5423 Don't assume time_t can fit into int.
5424 * buffer.h (struct buffer.modtime): Now time_t, not int.
5425 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5426 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5427
ccd9a01a
PE
5428 Minor fixes for signed vs unsigned integers.
5429 * character.h (MAYBE_UNIFY_CHAR):
5430 * charset.c (maybe_unify_char):
5431 * keyboard.c (read_char, reorder_modifiers):
5432 XINT -> XFASTINT, since the integer must be nonnegative.
5433 * ftfont.c (ftfont_spec_pattern):
5434 * keymap.c (access_keymap, silly_event_symbol_error):
5435 XUINT -> XFASTINT, since the integer must be nonnegative.
5436 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5437 since it makes no difference and we prefer signed.
5438 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5439 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5440 nonnegative.
5441
d6d100dd
SM
54422011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5443
5444 * window.h (Fwindow_frame): Declare.
5445
2b6148e4
PE
54462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5447
5448 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5449 (SPARE_MEMORY): Always define.
5450 (LARGE_REQUEST): Remove.
5451 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5452
f230ecc9
MR
54532011-06-06 Martin Rudalics <rudalics@gmx.at>
5454
727e958e
MR
5455 * lisp.h: Move EXFUNS for Fframe_root_window,
5456 Fframe_first_window and Fset_frame_selected_window to window.h.
5457
5458 * window.h: Move EXFUNS for Fframe_root_window,
5459 Fframe_first_window and Fset_frame_selected_window here from
5460 lisp.h.
5461
5462 * frame.c (Fwindow_frame, Fframe_first_window)
5463 (Fframe_root_window, Fframe_selected_window)
5464 (Fset_frame_selected_window): Move to window.c.
5465 (Factive_minibuffer_window): Move to minibuf.c.
5466 (Fother_visible_frames_p): New function.
5467
5468 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5469
f230ecc9
MR
5470 * window.c (decode_window, decode_any_window): Move up in code.
5471 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5472 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5473 (Fwindow_buffer): Move up and rewrite doc-string.
5474 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5475 (Fwindow_prev): New functions.
727e958e
MR
5476 (Fwindow_frame): Move here from frame.c. Accept any window as
5477 argument.
5478 (Fframe_root_window, Fframe_first_window)
5479 (Fframe_selected_window): Move here from frame.c. Accept frame
5480 or arbitrary window as argument. Update doc-strings.
5481 (Fminibuffer_window): Move up in code.
5482 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5483 (Fset_frame_selected_window): Move here from frame.c.
5484 Marginal rewrite.
727e958e
MR
5485 (Fselected_window, select_window, Fselect_window): Move up in
5486 code. Minor doc-string fixes.
f230ecc9 5487
4d09bcf6
PE
54882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5489
5490 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5491 Do not assume that spare memory exists; that assumption is valid
5492 only if SYSTEM_MALLOC.
5493 (LARGE_REQUEST): New macro, so that the issue of large requests
5494 is separated from the issue of spare memory.
5495
810928a2
AS
54962011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5497
172418ad
AS
5498 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5499 format. (Bug#8806)
5500
43f862f7
AS
5501 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5502
810928a2
AS
5503 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5504 before statements.
5505
a059fe24
JD
55062011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5507
5508 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5509
5510 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5511
5512 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5513 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5514
989bf368
JB
55152011-06-05 Juanma Barranquero <lekktu@gmail.com>
5516
5517 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5518
4b80f674
CY
55192011-06-04 Chong Yidong <cyd@stupidchicken.com>
5520
5521 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5522 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5523 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5524 New error handlers.
4b80f674
CY
5525 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5526 Obey Vx_select_enable_clipboard_manager. Catch errors in
5527 x_clipboard_manager_save (Bug#8779).
5528 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5529 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5530
99a33b77 55312011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5532
5533 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5534
99a33b77 55352011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5536
5537 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5538 in the current matrix if keep_current_p is non-zero.
5539
8264569d
EZ
55402011-06-04 Eli Zaretskii <eliz@gnu.org>
5541
5542 * bidi.c (bidi_level_of_next_char): Fix last change.
5543
57f97249
EZ
55442011-06-03 Eli Zaretskii <eliz@gnu.org>
5545
fec2107c 5546 Support bidi reordering of text covered by display properties.
57f97249 5547
fec2107c
EZ
5548 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5549 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5550 (bidi_cache_search, bidi_cache_iterator_state)
5551 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5552 (bidi_level_of_next_char, bidi_move_to_visually_next):
5553 Support character positions inside a run of characters covered by a
fec2107c
EZ
5554 display string.
5555 (bidi_paragraph_init, bidi_resolve_explicit_1)
5556 (bidi_level_of_next_char): Call bidi_fetch_char and
5557 bidi_fetch_char_advance instead of FETCH_CHAR and
5558 FETCH_CHAR_ADVANCE.
5559 (bidi_init_it): Initialize new members.
5560 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5561 definitions.
5562 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5563 instead of using explicit *_CHAR codes.
d6d100dd
SM
5564 (bidi_resolve_explicit, bidi_resolve_weak):
5565 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5566 bidirectional text is supported only in multibyte buffers.
5567 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5568 it to initialize the frame_window_p member of struct bidi_it.
5569 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5570 (bidi_resolve_explicit, bidi_resolve_weak)
5571 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5572 bidi_it->nchars is non-positive.
5573 (bidi_level_of_next_char): Don't try to lookup the cache for the
5574 next/previous character if nothing is cached there yet, or if we
5575 were just reseat()'ed to a new position.
c40e2fb2 5576
0e14fe90
EZ
5577 * xdisp.c (set_cursor_from_row): Set start and stop points
5578 according to the row's direction when priming the loop that looks
5579 for the glyph on which to display cursor.
5580 (single_display_spec_intangible_p): Function deleted.
5581 (display_prop_intangible_p): Reimplement to call
5582 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5583 Accept 3 additional arguments needed by handle_display_spec.
5584 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5585 values: lists, `(when COND...)' forms, etc.
5586 (single_display_spec_string_p): Support property values that are
5587 lists with the argument STRING its top-level element.
5588 (display_prop_string_p): Fix the condition for processing a
5589 property that is a list to be consistent with handle_display_spec.
fec2107c 5590 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5591 last portion of handle_display_prop.
5592 (compute_display_string_pos): Accept additional argument
5593 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5594 value of a `display' property is a "replacing spec".
5595 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5596 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5597 the display property, but just return a value indicating whether
5598 the display property will replace the characters it covers.
5599 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5600 frame_window_p members of struct bidi_it.
d6d100dd
SM
5601 (compute_display_string_pos, compute_display_string_end):
5602 New functions.
fec2107c
EZ
5603 (push_it): Accept second argument POSITION, where pop_it should
5604 jump to continue iteration.
5605 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5606
fec2107c
EZ
5607 * keyboard.c (adjust_point_for_property): Adjust the call to
5608 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5609
5610 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5611 (bidi_init_it): Update prototypes.
5612 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5613 (compute_display_string_pos, compute_display_string_end):
5614 Declare prototypes.
fec2107c
EZ
5615 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5616 EMACS_INT.
fc6f18ce 5617
40087514 56182011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5619
57f53182
PE
5620 Malloc failure behavior now depends on size of allocation.
5621 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5622 * lisp.h: Change signatures accordingly.
5623 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5624 All callers changed. (Bug#8762)
5625
5626 * gnutls.c: Use Emacs's memory allocators.
5627 Without this change, the gnutls library would invoke malloc etc.
5628 directly, which causes problems on non-SYNC_INPUT hosts, and which
5629 runs afoul of improving memory_full behavior. (Bug#8761)
5630 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5631 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5632 xfree instead of the default malloc, realloc, free.
5633 (Fgnutls_boot): No need to check for memory allocation failure,
5634 since xmalloc does that for us.
5635
ac32cd99 5636 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5637 * category.c (hash_get_category_set):
5638 * ccl.c (ccl_driver):
5639 * charset.c (Fdefine_charset_internal):
5640 * charset.h (struct charset.hash_index):
5641 * composite.c (get_composition_id, gstring_lookup_cache)
5642 (composition_gstring_put_cache):
5643 * composite.h (struct composition.hash_index):
5644 * dispextern.h (struct image.hash):
5645 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5646 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5647 (hashfn_equal, hashfn_user_defined, make_hash_table)
5648 (maybe_resize_hash_table, hash_lookup, hash_put)
5649 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5650 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5651 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5652 * image.c (make_image, search_image_cache, lookup_image)
5653 (xpm_put_color_table_h):
5654 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5655 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5656 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5657 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5658 * alloc.c (allocate_vectorlike):
5659 Check for overflow in vector size calculations.
5660 * ccl.c (ccl_driver):
5661 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5662 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5663 need to be updated by these changes.
40087514
PE
5664 * fns.c (make_hash_table, maybe_resize_hash_table):
5665 Check for integer overflow with large hash tables.
0de4bb68
PE
5666 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5667 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5668 (SXHASH_REDUCE): New macro.
5669 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5670 Use it instead of discarding useful hash info with large hash values.
5671 (sxhash_float): New function.
5672 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5673 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5674 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5675 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5676 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5677 Adjust signatures to match updated version of code.
5678 (consing_since_gc): Now EMACS_INT, since a single hash table can
5679 use more than INT_MAX bytes.
5680
698d32e2
DN
56812011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5682
5683 Make it possible to build with GCC-4.6+ -O2 -flto.
5684
5685 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5686
fd6fa53f
SM
56872011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5688
5689 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5690 Call minibuffer-inactive-mode.
5691
864db017
JB
56922011-05-31 Juanma Barranquero <lekktu@gmail.com>
5693
5694 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5695 Update dependencies.
5696
2ad0baf4
DN
56972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5698
5699 * data.c (init_data): Remove code for UTS, this system is not
5700 supported anymore.
5701
4fcc2638
DN
57022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5703
5704 Don't force ./temacs to start in terminal mode.
5705
5706 * frame.c (make_initial_frame): Initialize faces in all cases, not
5707 only when CANNOT_DUMP is defined.
5708 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5709
c56e0fd5
DN
57102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5711
5712 * dispnew.c (add_window_display_history): Use const for the string
5713 pointer. Remove declaration, not needed.
5714
333d54da 57152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5716
55d4c1b2 5717 Use 'inline', not 'INLINE'.
333d54da 5718 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5719 * alloc.c, fontset.c (INLINE): Remove.
5720 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5721 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5722 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5723 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5724 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5725
738db178
DN
57262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5727
5728 Make it possible to run ./temacs.
5729
5730 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5731 syms_of_callproc does the same thing. Remove test for
5732 "initialized", do it in the caller.
5733 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5734
620c53a6
SM
57352011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5736
5737 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5738 (read_minibuf): Use get_minibuffer.
5739 (syms_of_minibuf): Use DEFSYM.
5740 (Qmetadata): New var.
5741 * data.c (Qbuffer): Don't make it static.
5742 (syms_of_data): Use DEFSYM.
5743
e003a292
PE
57442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5745
5746 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5747 (CCL_CODE_MIN): New macro.
5748
ed008a6d
PE
57492011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5750
3687c2ef
PE
5751 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5752
ed008a6d
PE
5753 * eval.c (Qdebug): Now static.
5754 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5755 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5756 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5757
d66c4c7c
CY
57582011-05-29 Chong Yidong <cyd@stupidchicken.com>
5759
5760 * image.c: Various fixes to ImageMagick code comments.
5761 (Fimagemagick_types): Doc fix.
5762
5fbc2025
PE
57632011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5764
0196f88a
PE
5765 Minor fixes prompted by GCC 4.6.0 warnings.
5766
5767 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5768
5fbc2025
PE
5769 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5770 (x_clipboard_manager_save_all): Move extern decl to ...
5771 * xterm.h: ... here, so that it can be checked for consistency.
5772
1dd3c2d9
CY
57732011-05-29 Chong Yidong <cyd@stupidchicken.com>
5774
5775 * xselect.c (x_clipboard_manager_save_frame)
5776 (x_clipboard_manager_save_all): New functions.
5777 (Fx_clipboard_manager_save): Lisp function deleted.
5778
5779 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5780 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5781
5782 * xterm.h: Update prototype.
5783
5ba6571d
WX
57842011-05-28 William Xu <william.xwl@gmail.com>
5785
5786 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5787 exiting (Bug#8239).
5788
3eaff834
JM
57892011-05-28 Jim Meyering <meyering@redhat.com>
5790
e1900994 5791 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5792 * fns.c (to_uchar): Define.
5793 (crypto_hash_function): Use it to convert some newly-signed
5794 variables to unsigned, to avoid sign-extension bugs. For example,
5795 without this change, (md5 "truc") would evaluate to
5796 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5797 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5798 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5799
0f6990a7
PE
58002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5801
5802 Integer overflow fixes.
c8a9ca5a 5803
08686060
PE
5804 * dbusbind.c: Serial number integer overflow fixes.
5805 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5806 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5807 to hold a serial number that is too large for a fixnum.
5808 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5809 Check for serial numbers out of range. Decode any serial number
59568bf0 5810 that was so large that it became a float. (Bug#8722)
08686060 5811
2d1fc3c7
PE
5812 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5813 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5814 Use XFASTINT rather than XUINT when numbers are nonnegative.
5815 (xd_append_arg, Fdbus_method_return_internal):
5816 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5817 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5818 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5819 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5820 (Bug#8722)
2d1fc3c7 5821
c8a9ca5a
PE
5822 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5823
519e1d69
PE
5824 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5825
6df6ae42 5826 ccl: Add integer overflow checks.
30569699
PE
5827 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5828 (IN_INT_RANGE): New macros.
5829 (ccl_driver): Use them to check for integer overflow when
5830 decoding a CCL program. Many of the new checks are whether XINT (x)
5831 fits in int; it doesn't always, on 64-bit hosts. The new version
5832 doesn't catch all possible integer overflows, but it's an
847044ea 5833 improvement. (Bug#8719)
30569699 5834
c11285dc
PE
5835 * alloc.c (make_event_array): Use XINT, not XUINT.
5836 There's no need for unsigned here.
5837
fdccd48e
PE
5838 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5839 This follows up to the 2011-05-06 change that substituted uintptr_t
5840 for EMACS_INT. This case wasn't caught back then.
5841
37910ab2
PE
5842 Rework Fformat to avoid integer overflow issues.
5843 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5844 now (part of C89). Include <verify.h>.
5845 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5846 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5847 (Fformat): Avoid the prepass trying to compute sizes; it was only
5848 approximate and thus did not catch overflow reliably. Instead, walk
5849 through the format just once, formatting and computing sizes as we go,
5850 checking for integer overflow at every step, and allocating a larger
5851 buffer as needed. Keep track separately whether the format is
5852 multibyte. Keep only the most-recently calculated precision, rather
5853 than them all. Record whether each argument has been converted to
5854 string. Use EMACS_INT, not int, for byte and char and arg counts.
5855 Support field widths and precisions larger than INT_MAX. Avoid
5856 sprintf's undefined behavior with conversion specifications such as %#d
5857 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5858 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5859 formatting out-of-range floating point numbers with int
9173deec 5860 formats. (Bug#8668)
37910ab2 5861
2e6578fb
PE
5862 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5863
0ae6bdee
PE
5864 * data.c: Avoid integer truncation in expressions involving floats.
5865 * data.c: Include <intprops.h>.
5866 (arith_driver): When there's an integer overflow in an expression
5867 involving floating point, convert the integers to floating point
5868 so that the resulting value does not suffer from catastrophic
5869 integer truncation. For example, on a 64-bit host (* 4
5870 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5871 Do not rely on undefined behavior after integer overflow.
5872
de883a70
PE
5873 merge count_size_as_multibyte, parse_str_to_multibyte
5874 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5875 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5876 Check for integer overflow.
5877 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5878 since it's now a duplicate of the other. This is more of
5879 a character than a buffer op, so better that it's in character.c.
5880 * fns.c, print.c: Adjust to above changes.
5881
2ff916cb
PE
58822011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5883
5884 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5885
f1b54466
PE
58862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5887
fb1ac845
PE
5888 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5889 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5890 (x_clipboard_manager_save): Now static.
5891 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5892
f1b54466
PE
5893 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5894 (crypto_hash_function): Now static.
5895 Fix pointer signedness problems. Avoid unnecessary initializations.
5896
a9f737ee
CY
58972011-05-27 Chong Yidong <cyd@stupidchicken.com>
5898
5899 * termhooks.h (Vselection_alist): Make it terminal-local.
5900
5901 * terminal.c (create_terminal): Initialize it.
5902
5903 * xselect.c: Support for clipboard managers.
5904 (Vselection_alist): Move to termhooks.h as terminal-local var.
5905 (LOCAL_SELECTION): New macro.
5906 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5907 (symbol_to_x_atom): Remove gratuitous arg.
5908 (x_handle_selection_request, lisp_data_to_selection_data)
5909 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5910 (x_own_selection, x_get_local_selection, x_convert_selection):
5911 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5912 (some_frame_on_display): Delete unused function.
5913 (Fx_own_selection_internal, Fx_get_selection_internal)
5914 (Fx_disown_selection_internal, Fx_selection_owner_p)
5915 (Fx_selection_exists_p): New optional frame arg.
5916 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5917 (x_handle_selection_clear): Don't treat other terminals with the
5918 same keyboard specially. Use the terminal-local Vselection_alist.
5919 (x_clear_frame_selections): Use Frun_hook_with_args.
5920
5921 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5922
5923 * xterm.h: Add support for those atoms.
5924
e067f0c1
CY
59252011-05-26 Chong Yidong <cyd@stupidchicken.com>
5926
5927 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5928 (converted_selections, conversion_fail_tag): New global variables.
5929 (x_selection_request_lisp_error): Free the above.
5930 (x_get_local_selection): Remove unnecessary code.
5931 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5932 of converted selections stored in converted_selections.
5933 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5934 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5935 (x_convert_selection): New function.
5936 (x_handle_selection_event): Simplify.
5937 (x_get_foreign_selection): Don't ignore incoming requests while
5938 waiting for an answer; this will fail when we implement
5939 SAVE_TARGETS, and seems unnecessary anyway.
5940 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5941 (Vx_sent_selection_functions): Doc fix.
5942
0f4aebc0
LL
59432011-05-26 Leo Liu <sdl.web@gmail.com>
5944
5945 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5946
e61124cd
YM
59472011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5948
5949 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5950
5951 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5952 for fringe update if it has periodic bitmap.
ac389d0c 5953 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5954 and fringe_bitmap_periodic_p.
5955
5956 * fringe.c (get_fringe_bitmap_data): New function.
5957 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5958 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5959 row. Mark glyph row for fringe update if periodicity changed.
5960
5961 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5962 for fringe update unless it has periodic bitmap.
5963
f16d9837
KH
59642011-05-25 Kenichi Handa <handa@m17n.org>
5965
5966 * xdisp.c (get_next_display_element): Set correct it->face_id for
5967 a static composition.
5968
e1b90ef6
LL
59692011-05-24 Leo Liu <sdl.web@gmail.com>
5970
5971 * deps.mk (fns.o):
5972 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5973
5974 * fns.c (crypto_hash_function, Fsha1): New function.
5975 (Fmd5): Use crypto_hash_function.
5976 (syms_of_fns): Add Ssha1.
5977
7400048f
PE
59782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5979
5980 * gnutls.c: Remove unused macros.
5981 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5982 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5983 Remove macros that are defined and never used.
5984 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5985
abb71cf4
CY
59862011-05-22 Chong Yidong <cyd@stupidchicken.com>
5987
5988 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5989 (Fx_get_selection_internal): Minor cleanup.
5990 (Fx_own_selection_internal): Rename arguments for consistency with
5991 select.el.
5992
6307db39
PE
59932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5994
5995 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5996
f3d4e0a4
CY
59972011-05-22 Chong Yidong <cyd@stupidchicken.com>
5998
5999 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6000
4d8ade89
YM
60012011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6002
6003 * dispnew.c (scrolling_window): Don't exclude the case that the
6004 last enabled row in the desired matrix touches the bottom boundary.
6005
32078c8d
GM
60062011-05-21 Glenn Morris <rgm@gnu.org>
6007
6008 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6009 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6010 and add some more files.
32078c8d 6011
7285dc67
EZ
60122011-05-20 Eli Zaretskii <eliz@gnu.org>
6013
6014 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6015 report_file_error introduced by the change from 2011-05-07.
6016
89d1bd22
PE
60172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6018
6019 * systime.h (Time): Define only if emacs is defined.
6020 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6021 where the include path doesn't have X11/X.h by default. See
6022 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6023
cd394be1 60242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6025
6026 * composite.c (find_automatic_composition): Fix previous change.
6027
b9704ad9
GM
60282011-05-20 Glenn Morris <rgm@gnu.org>
6029
6030 * lisp.mk: New file, split from Makefile.in.
6031 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6032 (shortlisp): Remove.
6033 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6034
4a720484
GM
60352011-05-19 Glenn Morris <rgm@gnu.org>
6036
6037 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6038 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6039 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6040 (lisp): Set the order to that of loadup.el.
6041 (shortlisp): Make it a copy of $lisp.
6042 (SOME_MACHINE_LISP): Remove.
6043 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6044 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6045
a28d4396
KH
60462011-05-18 Kenichi Handa <handa@m17n.org>
6047
6048 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6049 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6050 (find_automatic_composition): Mostly rewrite for efficiency.
6051
a2b1fa8e
JB
60522011-05-18 Juanma Barranquero <lekktu@gmail.com>
6053
6054 * makefile.w32-in: Update dependencies.
6055
8e1f5610
CS
60562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6057
6058 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6059 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6060
7025ee00 60612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6062
cdfa6eab
PE
6063 Fix some integer overflow issues, such as string length overflow.
6064
06d6db33
PE
6065 * insdel.c (count_size_as_multibyte): Check for string overflow.
6066
2b4560a8
PE
6067 * character.c (lisp_string_width): Check for string overflow.
6068 Use EMACS_INT, not int, for string indexes and lengths; in
6069 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6070 the resulting string length overflows an EMACS_INT; instead,
6071 report a string overflow if no precision given. When checking for
6072 precision exhaustion, use a check that cannot possibly have
6073 integer overflow. (Bug#8675)
6074 * character.h (lisp_string_width): Adjust to new signature.
6075
cb93f9be
PE
6076 * alloc.c (string_overflow): New function.
6077 (Fmake_string): Use it. This doesn't change behavior, but saves
6078 a few bytes and will simplify future changes.
6079 * character.c (string_escape_byte8): Likewise.
6080 * lisp.h (string_overflow): New decl.
6081
1a1f3366
PE
6082 Fixups, following up to the user-interface timestamp change.
6083 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6084 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6085 * msdos.c (mouse_get_pos): Likewise.
6086 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6087 * w32gui.h (Time): Define by including "systime.h" rather than by
6088 declaring it ourselves. (Bug#8664)
6089
d4e3e4d3
PE
6090 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6091 * image.c (clear_image_cache): Likewise.
6092
f6a24d19
PE
6093 * term.c (term_mouse_position): Don't assume time_t wraparound.
6094
08dc5ae6
PE
6095 Be more systematic about user-interface timestamps.
6096 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6097 and sometimes 'EMACS_UINT', to represent these timestamps.
6098 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6099 This makes the code easier to follow, and makes it easier to catch
6100 integer overflow bugs such as Bug#8664.
6101 * frame.c (Fmouse_position, Fmouse_pixel_position):
6102 Use Time, not unsigned long, for user-interface timestamps.
6103 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6104 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6105 * keyboard.h (last_event_timestamp): Likewise.
6106 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6107 * menu.h (xmenu_show): Likewise.
6108 * term.c (term_mouse_position): Likewise.
6109 * termhooks.h (struct input_event.timestamp): Likewise.
6110 (struct terminal.mouse_position_hook): Likewise.
6111 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6112 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6113 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6114 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6115 what it was before.
6116 * menu.h, termhooks.h: Include "systime.h", for Time.
6117
8e55734a
PE
6118 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6119 Don't assume that the difference between two unsigned long values
6120 can fit into an integer. At this point, we know button_down_time
6121 <= event->timestamp, so the difference must be nonnegative, so
6122 there's no need to cast the result if double-click-time is
6123 nonnegative, as it should be; check that it's nonnegative, just in
6124 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6125 apart (about 25 days). (Bug#8664)
8e55734a 6126
841f1b75 6127 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6128 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6129
3e26f69c
PE
6130 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6131 that always fit in int. Use a sentinel instead of a counter, to
6132 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6133 * frame.h (struct frame): Use int for menu_bar_items_used
6134 instead of EMACS_INT, since it always fits in int.
3e26f69c 6135
5cc152c0
PE
6136 * menu.c (grow_menu_items): Check for int overflow.
6137
d89eb65e
PE
6138 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6139
5235bd3e
PE
6140 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6141 Before, the code was not consistent. These values cannot exceed
6142 2**31 - 1 so there's no need to make them unsigned.
6143 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6144 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6145 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6146 as modifiers.
6147 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6148
bc827e23
PE
6149 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6150 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6151 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6152 presumably because the widths might not match.
6153
78eb494e
PE
6154 * window.c (size_window): Avoid needless test at loop start.
6155
04f2d78b
CB
61562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6157
6158 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6159
d2fc7e3d 61602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6161
6162 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6163
d2fc7e3d 61642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6165
6166 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6167 `width' to `bar_area_x' and `bar_area_width', respectively.
6168 (x_scroll_run): Take account of fringe background extension.
6169
04f2d78b
CB
6170 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6171 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6172 `bar_area_width', respectively.
6173 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6174 background extension.
6175
79b70037
GM
61762011-05-10 Jim Meyering <meyering@redhat.com>
6177
6178 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6179
2f142cc5
JB
61802011-05-10 Juanma Barranquero <lekktu@gmail.com>
6181
6182 * image.c (Finit_image_library): Return t for built-in image types,
6183 like pbm and xbm. (Bug#8640)
6184
57679c86
AS
61852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6186
6187 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6188
888c9e86
EZ
61892011-05-07 Eli Zaretskii <eliz@gnu.org>
6190
b0512a1d
EZ
6191 * w32console.c (Fset_screen_color): Doc fix.
6192 (Fget_screen_color): New function.
6193 (syms_of_ntterm): Defsubr it.
6194
7285dc67
EZ
6195 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6196 unlink the temporary file if Fcall_process didn't create it in the
6197 first place.
6198 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6199 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6200 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6201 cue to call_process_cleanup not to close that handle.
6202
4d3fcc8e
BK
62032011-05-07 Ben Key <bkey76@gmail.com>
6204
6205 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6206 one of two shell specific rules, either bootstrap-temacs-CMD or
6207 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6208 to the previous implementation of the bootstrap-temacs rule.
6209 The bootstrap-temacs-CMD rule is similar to the previous
6210 implementation of the bootstrap-temacs rule except that it
6211 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6212 variable.
6213
6214 These changes, along with some changes to nt/configure.bat,
6215 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6216 earlier fix to add support for --cflags and --ldflags options
6217 that include quotes so that it works whether make uses cmd or
6218 sh as the shell.
6219
b4289b64
MA
62202011-05-06 Michael Albinus <michael.albinus@gmx.de>
6221
6222 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6223 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6224 is a constant.
6225 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6226 a string. Handle both cases.
6227 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6228 (Fdbus_register_method): Use Qinvalid_function.
6229
af4c0e28
JB
62302011-05-06 Juanma Barranquero <lekktu@gmail.com>
6231
6232 * makefile.w32-in: Update dependencies.
6233 (LISP_H): Add inttypes.h and stdin.h.
6234 (PROCESS_H): Add unistd.h.
6235
c51453d9
EZ
62362011-05-06 Eli Zaretskii <eliz@gnu.org>
6237
6238 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6239 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6240
8ff0ac3c 62412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6242
4c4b566b
PE
6243 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6244
aab2b9b5
PE
6245 * term.c (vfatal): Remove stray call to va_end.
6246 It's not needed and the C Standard doesn't allow it here anyway.
6247
c378da0b
PE
6248 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6249 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6250
288b08c7
PE
6251 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6252 bytes.
6253
e3601888
PE
6254 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6255
db6c0e74
PE
6256 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6257
dd5963ea
PE
6258 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6259
88c9450f
PE
6260 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6261
2f9442b8
PE
6262 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6263
c032b5f8
PE
6264 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6265 * charset.c (Fdefine_charset_internal): Don't initialize
6266 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6267 32-bit int (Bug#8600).
a108c10b
PE
6268
6269 * lread.c (read_integer): Be more consistent with string-to-number.
6270 Use string_to_number to do the actual conversion; this avoids
6271 rounding errors and fixes some other screwups. Without this fix,
6272 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6273 (digit_to_number): Move earlier, for benefit of read_integer.
6274 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6275 not a digit in any supported base. (Bug#8602)
a108c10b 6276
ad5f9eea
PE
6277 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6278
aec1708a
PE
6279 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6280 to match comment at start of function. This also removes a
6281 GCC warning about overflow in a 32+64-bit port.
6282
47be4ab5
PE
6283 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6284
371cac43
PE
6285 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6286 Reported by Stefan Monnier in
6287 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6288 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6289 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6290
d01a7826
PE
6291 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6292 (EMACS_UINTPTR): Likewise, with uintptr_t.
6293
7fd47d5c
PE
6294 * lisp.h: Prefer 64-bit EMACS_INT if available.
6295 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6296 on 32-bit hosts that have 64-bit int, so that they can access
6297 large files.
122b0c86
PE
6298 However, temporarily disable this change unless the temporary
6299 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6300
8727937b
PE
6301 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6302
8ac068ac
PE
6303 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6304 This removes an assumption that EMACS_INT and long are the same
6305 width as pointers. The assumption is true for Emacs porting targets
6306 now, but we want to make other targets possible.
6307 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6308 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6309 In the rest of the code, change types of integers that hold casted
6310 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6311 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6312 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6313 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6314 No need to cast type when ORing.
6315 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6316 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6317 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6318 assume EMACS_INT is the same width as char *.
6319 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6320 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6321 Remove no-longer-needed casts.
6322 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6323 (xg_tool_bar_help_callback, xg_make_tool_item):
6324 Use EMACS_INTPTR to hold an integer
6325 that will be cast to void *; this can avoid a GCC warning
6326 if EMACS_INT is not the same width as void *.
6327 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6328 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6329 (current_message_1, set_message_1):
6330 Use a local to convert to proper width without a cast.
6331 * xmenu.c (dialog_selection_callback): Likewise.
6332
ede49d71
PE
6333 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6334 Also, don't assume VALBITS / RAND_BITS is less than 5,
6335 and don't rely on undefined behavior when shifting a 1 left into
6336 the sign bit.
6337 * lisp.h (get_random): Change signature to match.
6338
2f30ecd0
PE
6339 * lread.c (hash_string): Use size_t, not int, for hash computation.
6340 Normally we prefer signed values; but hashing is special, because
6341 it's better to use unsigned division on hash table sizes so that
6342 the remainder is nonnegative. Also, size_t is the natural width
6343 for hashing into memory. The previous code used 'int', which doesn't
6344 retain enough info to hash well into very large tables.
6345 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6346
2a866e7b
PE
6347 * dbusbind.c: Don't possibly lose pointer info when converting.
6348 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6349 Use XPNTR rather than XHASH, so that the high-order bits of
6350 the pointer aren't lost when converting through void *.
6351
51639eac
PE
6352 * eval.c (Fautoload): Don't double-shift a pointer.
6353
92394119
PE
6354 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6355
dbdb9a7c
JB
63562011-05-06 Juanma Barranquero <lekktu@gmail.com>
6357
6358 * gnutls.c (DEF_GNUTLS_FN):
6359 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6360
db7a0b4f
AS
63612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6362
6363 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6364 marker. (Bug#8610)
6365
cd394be1 63662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6367
6368 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6369 New version that can reserve upto 2GB of heap space.
6370
f7ff1b0f 63712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6372
6373 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6374
639c109b
TZ
63752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6376
6377 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6378 `gnutls_certificate_set_x509_key_file'.
6379
d2127135
JB
63802011-05-05 Juanma Barranquero <lekktu@gmail.com>
6381
6382 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6383 Update dependencies.
6384
e968f4f3
JB
63852011-05-04 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6388 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6389 Remove unused parameter `fildes'.
6390 * process.c (read_process_output, send_process): Don't pass it.
6391
84d358f0
JB
63922011-05-04 Juanma Barranquero <lekktu@gmail.com>
6393
6394 Fix previous change: the library cache is defined in w32.c.
6395 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6396 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6397
0898ca10
JB
63982011-05-04 Juanma Barranquero <lekktu@gmail.com>
6399
6400 Implement dynamic loading of GnuTLS on Windows.
6401
6402 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6403 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6404 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6405 Declare.
6406
6407 * gnutls.c (Qgnutls_dll): Define.
6408 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6409 (gnutls_*): Declare function pointers.
6410 (init_gnutls_functions): New function to initialize function pointers.
6411 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6412 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6413 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6414 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6415 (emacs_gnutls_write, emacs_gnutls_read)
6416 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6417 (Fgnutls_available_p): New function.
6418 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6419 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6420 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6421
6422 * image.c: Include w32.h.
6423 (Vimage_type_cache): Delete.
6424 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6425 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6426 (w32_delayed_load): Move to w32.c.
6427
6428 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6429
6430 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6431 (w32_delayed_load): Move from image.c. When loading a library, record
6432 its filename in the :loaded-from property of the library id.
6433 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6434 Initialize and staticpro them.
6435 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6436
6437 * process.c: Include lisp.h before w32.h, not after.
6438 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6439 instead of gnutls_record_check_pending.
6440
6441 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6442
ff4de4aa
TZ
64432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6444
6445 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6446 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6447 as passed in.
6448
abe95abb
JD
64492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6450
6451 * xterm.c (x_set_frame_alpha): Do not set property on anything
6452 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6453
e16e55d4
JB
64542011-05-02 Juanma Barranquero <lekktu@gmail.com>
6455
6456 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6457
bafcf6a5
JB
64582011-05-02 Juanma Barranquero <lekktu@gmail.com>
6459
6460 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6461 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6462 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6463 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6464 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6465 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6466 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6467 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6468 (Qgnutls_bootprop_callbacks_verify): Make static.
6469
e7a6747f
AS
64702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6471
19ed11ba
AS
6472 * callproc.c: Indentation fixup.
6473
e7a6747f 6474 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6475 (wait_for_termination, interruptible_wait_for_termination):
6476 Move after wait_for_termination_1.
e7a6747f 6477
1ef14cb4
LMI
64782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6479
6480 * sysdep.c (interruptible_wait_for_termination): New function
6481 which is like wait_for_termination, but allows keyboard
6482 interruptions.
6483
6484 * callproc.c (Fcall_process): Add (:file "file") as an option for
6485 the STDOUT buffer.
6486 (Fcall_process_region): Ditto.
6487
330d880c
EZ
64882011-04-30 Eli Zaretskii <eliz@gnu.org>
6489
8db90b73
EZ
6490 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6491 rather than `XVECTOR (FOO)->size'.
6492
330d880c
EZ
6493 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6494 inttypes.h, as a gnulib replacement is used if it not available in
6495 system headers.
6496
15cbd324
EZ
64972011-04-21 Eli Zaretskii <eliz@gnu.org>
6498
6499 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6500 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6501 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6502
6503 * coding.c (coding_alloc_by_realloc): Error out if destination
6504 will grow beyond MOST_POSITIVE_FIXNUM.
6505 (decode_coding_emacs_mule): Abort if there isn't enough place in
6506 charbuf for the composition carryover bytes. Reserve an extra
6507 space for up to 2 characters produced in a loop.
6508 (decode_coding_iso_2022): Abort if there isn't enough place in
6509 charbuf for the composition carryover bytes.
6510
65112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6512
ae940cca
EZ
6513 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6514 aborting when %lld or %lll format is passed.
6515 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6516 %llo or %llx format is passed. (Bug#8545)
6517
03ab8921
EZ
6518 * window.c (window_scroll_line_based): Use a marker instead of
6519 simple variables to record original value of point. (Bug#7952)
6520
afda1437
EZ
6521 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6522 produced by %s or %c overflows available buffer space. (Bug#8545)
6523
f76dee0c
PE
65242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6525
6526 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6527 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6528
fdc5744d
JB
65292011-04-28 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6532
638f053a
JB
65332011-04-28 Juanma Barranquero <lekktu@gmail.com>
6534
6535 * keyboard.c (Qdelayed_warnings_hook): Define.
6536 (command_loop_1): Run `delayed-warnings-hook'
6537 if Vdelayed_warnings_list is non-nil.
6538 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6539 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6540
d178f871
EZ
65412011-04-28 Eli Zaretskii <eliz@gnu.org>
6542
6543 * doprnt.c (doprnt): Don't return value smaller than the buffer
6544 size if the message was truncated. (Bug#8545).
6545
b124fd93
JB
65462011-04-28 Juanma Barranquero <lekktu@gmail.com>
6547
6548 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6549 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6550
e810457d
PE
65512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6552
6553 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6554
ea51cceb
JB
65552011-04-27 Juanma Barranquero <lekktu@gmail.com>
6556
6557 * makefile.w32-in: Update dependencies.
6558
94dcfacf
EZ
65592011-04-27 Eli Zaretskii <eliz@gnu.org>
6560
6561 Improve `doprnt' and its usage. (Bug#8545)
6562 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6563 `format_end'. Remove support for %l as a conversion specifier.
6564 Don't use xrealloc. Improve diagnostics when the %l size modifier
6565 is used. Update the commentary.
6566
6567 * eval.c (verror): Simplify calculation of size_t.
6568
6569 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6570 messages.
6571
f61f41d7
PE
65722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6573
6574 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6575 change.
6576
96fb4434
PE
65772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6578
6579 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6580 This makes this file independent of the recent pseudovector change.
6581
671875da 65822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6583
69e9b5a3
PE
6584 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6585
b5f869a7 6586 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6587 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6588 Remove unused local.
c8926152 6589 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6590
841a1577 6591 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6592 GCC 4.6.0 optimizes based on type-based alias analysis.
6593 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6594 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6595 != &v->size, and therefore "v->size = 1; b->size = 2; return
6596 v->size;" must therefore return 1. This assumption is incorrect
6597 for Emacs, since it type-puns struct Lisp_Vector * with many other
6598 types. To fix this problem, this patch adds a new type struct
f904488f 6599 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6600 and pseudovectors, and helps optimizing compilers not get fooled
6601 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6602 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6603 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6604 the size member.
eab3844f
PE
6605 (XSETPVECTYPE): Rewrite in terms of new macro.
6606 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6607 This is a bit clearer, and further avoids the possibility of
6608 undesirable aliasing.
6609 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6610 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6611 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6612 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6613 (ASIZE): Now uses header.size rather than size.
6614 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6615 to avoid the hassle of writing XVECTOR (foo)->header.size.
6616 (struct vectorlike_header): New type.
eab3844f
PE
6617 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6618 object, to help avoid aliasing.
6619 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6620 (SUBRP): Likewise, since Lisp_Subr is a special case.
6621 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6622 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6623 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6624 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6625 changed to be "header.size" and "header.next".
6626 * buffer.h (struct buffer): Likewise.
6627 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6628 * frame.h (struct frame): Likewise.
6629 * process.h (struct Lisp_Process): Likewise.
6630 * termhooks.h (struct terminal): Likewise.
6631 * window.c (struct save_window_data, struct saved_window): Likewise.
6632 * window.h (struct window): Likewise.
6633 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6634 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6635 * buffer.c (init_buffer_once): Likewise.
6636 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6637 special case.
6638 * process.c (Fformat_network_address): Use local var for size,
6639 for brevity.
6640
0df1eac5
PE
6641 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6642
847ab9d1 6643 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6644 * data.c (atof): Remove decl; no longer used or needed.
6645 (digit_to_number): Move to lread.c.
6646 (Fstring_to_number): Use new string_to_number function, to be
6647 consistent with how the Lisp reader treats infinities and NaNs.
6648 Do not assume that floating-point numbers represent EMACS_INT
6649 without losing information; this is not true on most 64-bit hosts.
6650 Avoid double-rounding errors, by insisting on integers when
6651 parsing non-base-10 numbers, as the documentation specifies.
6652 * lisp.h (string_to_number): New decl, replacing ...
6653 (isfloat_string): Remove.
bc0a5c13 6654 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6655 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6656 appears to have been a coding error. Similarly, do not accept
6657 strings like +-1e0 as floating point numbers. Do not report
6658 overflow for integer overflows unless the base is not 10 which
6659 means we have no simple and reliable way to continue.
6660 Break out the floating-point parsing into a new
6661 function string_to_number, so that Fstring_to_number parses
6662 floating point numbers consistently with the Lisp reader.
04f2d78b 6663 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6664 (E_CHAR, EXP_INT): Remove, replacing with ...
6665 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6666 (string_to_number): New function, replacing isfloat_string.
6667 This function checks for valid syntax and produces the resulting
6668 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6669 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6670 so that overflow for non-base-10 numbers is reported only when
6671 there's no portable and simple way to convert to floating point.
452f4150 6672
67769ffc
PE
6673 * textprop.c (set_text_properties_1): Rewrite for clarity,
6674 and to avoid GCC warning about integer overflow.
6675
c20db43f
PE
6676 * intervals.h (struct interval): Use EMACS_INT for members
6677 where EMACS_UINT might cause problems. See
6678 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6679 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6680 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6681 All uses changed.
37aa2f85
PE
6682 (offset_intervals): Tell GCC not to worry about length overflow
6683 when negating a negative length.
c20db43f 6684
2538aa2f
PE
6685 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6686 (overrun_check_free): Likewise.
6687
f2d3008d
PE
6688 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6689 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6690 word size.
6691
ec8df744
PE
6692 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6693 (gnutls_make_error): Rename local to avoid shadowing.
6694 (gnutls_emacs_global_deinit): ifdef out; not used.
6695 (Fgnutls_boot): Use const for pointer to readonly storage.
6696 Comment out unused local. Fix pointer signedness problems.
6697
640ee02d
PE
6698 * lread.c (openp): Don't stuff size_t into an 'int'.
6699 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6700 about possible signed overflow.
6701
6048fb2a
PE
6702 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6703 (GDK_KEY_g): Don't define if already defined.
6704 (xg_prepare_tooltip): Avoid pointer signedness problem.
6705 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6706
fa3c87e1
PE
6707 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6708 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6709
2172544b
PE
6710 * xfns.c (Fx_window_property): Simplify a bit,
6711 to make a bit faster and to avoid GCC 4.6.0 warning.
6712 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6713
9b821a21
PE
6714 * fns.c (internal_equal): Don't assume size_t fits in int.
6715
3c616cfa
PE
6716 * alloc.c (compact_small_strings): Tighten assertion a little.
6717
c2982e87
PE
6718 Replace pEd with more-general pI, and fix some printf arg casts.
6719 * lisp.h (pI): New macro, generalizing old pEd macro to other
6720 conversion specifiers. For example, use "...%"pI"d..." rather
6721 than "...%"pEd"...".
6722 (pEd): Remove. All uses replaced with similar uses of pI.
6723 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6724 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6725 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6726 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6727 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6728 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6729 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6730 64-bit hosts.
6731 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6732 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6733 * print.c (safe_debug_print, print_object): Likewise.
6734 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6735 to int.
6f04d126
PE
6736 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6737 avoiding the 0 flag, which is not portable.
c2982e87
PE
6738 * process.c (Fmake_network_process): Use pI to avoid cast.
6739 * region-cache.c (pp_cache): Likewise.
6740 * xdisp.c (decode_mode_spec): Likewise.
6741 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6742 behavior on 64-bit hosts with printf arg.
6f04d126 6743 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6744 (x_stop_queuing_selection_requests): Likewise.
6745 (x_get_window_property): Don't truncate byte count to an 'int'
6746 when tracing.
0b432f21 6747
5e073ec7
PE
6748 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6749 here, since it parses constructs like leading '-' and spaces,
6750 which are not wanted; and it overflows with large numbers.
6751 Instead, simply match F[0-9]+, which is what is wanted anyway.
6752
36372bf9
PE
6753 * alloc.c: Remove unportable assumptions about struct layout.
6754 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6755 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6756 (allocate_vectorlike, make_pure_vector): Use the new macros,
6757 plus offsetof, to remove unportable assumptions about struct layout.
6758 These assumptions hold on all porting targets that I know of, but
6759 they are not guaranteed, they're easy to remove, and removing them
6760 makes further changes easier.
6761
0b432f21
PE
6762 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6763 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6764 (string_overrun_cookie): Now const. Use initializers that
6765 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6766 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6767 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6768 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6769 multiple of sizeof (EMACS_INT); it need not be, if
6770 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6771 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6772
895009e1
JB
67732011-04-26 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6776
6a7a1b0b
TZ
67772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6778
6779 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6780 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6781 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6782
841a1577 67832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6784
6785 * lisp.h (Qdebug): List symbol.
895009e1 6786 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6787 * keyboard.c (debug-on-event): New variable.
6788 (handle_user_signal): Break into debugger when debug-on-event
6789 matches the current signal symbol.
6790
f2d3ba6f
DN
67912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6792
6793 * alloc.c (check_sblock, check_string_bytes)
6794 (check_string_free_list): Convert to standard C.
6795
42ce4c63
TZ
67962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6797
6798 * w32.c (emacs_gnutls_push): Fix typo.
6799
825cd63c
EZ
68002011-04-25 Eli Zaretskii <eliz@gnu.org>
6801
fb11d64d
EZ
6802 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6803 "cast to pointer from integer of different size".
6804
825cd63c
EZ
6805 Improve doprnt and its use in verror. (Bug#8545)
6806 * doprnt.c (doprnt): Document the set of format control sequences
6807 supported by the function. Use SAFE_ALLOCA instead of always
6808 using `alloca'.
6809
6810 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6811 is one byte too soon. Don't use xrealloc; instead xfree and
6812 xmalloc anew.
6813
e061a11b
TZ
68142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6815
6816 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6817 callbacks stage.
6818
6819 * gnutls.c: Renamed global_initialized to
6820 gnutls_global_initialized. Added internals for the
6821 :verify-hostname-error, :verify-error, and :verify-flags
6822 parameters of `gnutls-boot' and documented those parameters in the
6823 docstring. Start callback support.
9173deec
JB
6824 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6825 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6826 on error. Return error code.
e061a11b
TZ
6827 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6828 (emacs_gnutls_read): Likewise.
6829 (Fgnutls_boot): Return handshake error code.
6830 (emacs_gnutls_handle_error): New function.
6831 (wsaerror_to_errno): Likewise.
6832
6833 * w32.h (emacs_gnutls_pull): Add prototype.
6834 (emacs_gnutls_push): Likewise.
6835
6836 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6837 (emacs_gnutls_push): Likewise.
6838
68392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6840
6841 * process.c (wait_reading_process_output): Check if GnuTLS
6842 buffered some data internally if no FDs are set for TLS
6843 connections.
6844
6845 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6846 (LIBS): Link to USER_LIBS.
6847 ($(BLD)/gnutls.$(0)): New target.
6848
fa6996bc
EZ
68492011-04-24 Eli Zaretskii <eliz@gnu.org>
6850
eb35682e
EZ
6851 * xdisp.c (handle_single_display_spec): Rename the
6852 display_replaced_before_p argument into display_replaced_p, to
6853 make it consistent with the commentary. Fix typos in the
6854 commentary.
6855
e2ad650c
EZ
6856 * textprop.c (syms_of_textprop): Remove dead code.
6857 (copy_text_properties): Delete obsolete commentary about an
6858 interface that was deleted long ago. Fix typos in the description
6859 of arguments.
6860
1b2de274
EZ
6861 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6862 to changes in oldXMenu/XMenu.h from 2011-04-16.
6863 <menu_help_message, prev_menu_help_message>: Constify.
6864 (IT_menu_make_room): menu->help_text is now `const char **';
6865 adjust.
6866
6867 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6868 to changes in oldXMenu/XMenu.h from 2011-04-16.
6869 (struct XMenu): Declare `help_text' `const char **'.
6870
6871 * xfaces.c <Qunspecified>: Make extern again.
6872
6873 * syntax.c: Include sys/types.h before including regex.h, as
6874 required by Posix.
6875
762b15be
EZ
6876 * doc.c (get_doc_string): Improve the format passed to `error'.
6877
6878 * doprnt.c (doprnt): Improve commentary.
6879
6880 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6881
6882 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6883 them with etags.
6884
f1052e5d
EZ
6885 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6886 changes in globals.h immediately force recompilation.
762b15be
EZ
6887 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6888 $(CURDIR)/s/ms-w32.h.
6889 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6890
fa6996bc
EZ
6891 * character.c (Fchar_direction): Function deleted.
6892 (syms_of_character): Don't defsubr it.
6893 <char-direction-table>: Deleted.
6894
e6c3da20
EZ
68952011-04-23 Eli Zaretskii <eliz@gnu.org>
6896
6897 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6898 * doprnt.c: Include limits.h.
6899 (SIZE_MAX): New macro.
04f2d78b
CB
6900 (doprnt): Return a size_t value. 2nd arg is now size_t.
6901 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6902 Improve overflow protection. Support `l' modifier for integer
6903 conversions. Support %l conversion. Don't assume an EMACS_INT
6904 argument for integer conversions and for %c.
6905
6906 * lisp.h (doprnt): Restore prototype.
6907
6908 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6909 $(SRC)/character.h.
6910
6911 * Makefile.in (base_obj): Add back doprnt.o.
6912
6913 * deps.mk (doprnt.o): Add back prerequisites.
6914 (callint.o): Depend on character.h.
6915
6916 * eval.c (internal_lisp_condition_case): Include the handler
6917 representation in the error message.
6918 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6919 when breaking from the loop.
6920
6921 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6922
6923 * callint.c (Fcall_interactively): When displaying error message
6924 about invalid control letter, pass the character's codepoint, not
6925 a pointer to its multibyte form. Improve display of the character
6926 in octal and display also its hex code.
6927
6928 * character.c (char_string): Use %x to display the (unsigned)
6929 codepoint of an invalid character, to avoid displaying a bogus
6930 negative value.
6931
6932 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6933 `error', not SYMBOL_NAME itself.
6934
6935 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6936 character arguments to `error'.
6937
6938 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6939 to `error' in error message about FINAL_CHAR argument. Make sure
6940 FINAL_CHAR is a character, and use %c when it is passed as
6941 argument to `error'.
6942
4ffd0d6b 69432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6944
6945 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6946
6947 * w32.c: Include <time.h>.
6948 (sys_localtime): New function.
6949
4ffd0d6b 69502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6951
6952 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6953
4ffd0d6b 6954 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6955
4ffd0d6b 69562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6957
4ffd0d6b
GM
6958 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6959 zombies (Bug#8467).
aac0c6e3 6960
04c56954
EZ
69612011-04-19 Eli Zaretskii <eliz@gnu.org>
6962
6963 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6964 gl_state.e_property when gl_state.object is Qt.
6965
6966 * insdel.c (make_gap_larger): Remove limitation of buffer size
6967 to <= INT_MAX.
6968
16a43933
CY
69692011-04-18 Chong Yidong <cyd@stupidchicken.com>
6970
6971 * xdisp.c (lookup_glyphless_char_display)
6972 (produce_glyphless_glyph): Handle cons cell entry in
6973 glyphless-char-display.
6974 (Vglyphless_char_display): Document it.
6975
6976 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6977 glyphless-char-display.
6978
4581706e
CY
69792011-04-17 Chong Yidong <cyd@stupidchicken.com>
6980
6981 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6982
6983 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6984
6985 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6986 definition for no-X builds.
6987
4887c6e2 69882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6989
fd35b6f9
PE
6990 Static checks with GCC 4.6.0 and non-default toolkits.
6991
5c1ccb01
PE
6992 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6993
006c5daa
PE
6994 * process.c (keyboard_bit_set): Define only if SIGIO.
6995 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6996 (send_process): Repair possible setjmp clobbering.
6997
efc736d3
PE
6998 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6999
4e2fe2e6
PE
7000 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7001
f97334a2
PE
7002 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7003
4e75f29d
PE
7004 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7005 Define only if needed.
7006
90efadd1
PE
7007 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7008 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7009 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7010
3c647824
PE
7011 * dispextern.h (struct redisplay_interface): Rename param
7012 to avoid shadowing.
e264f262 7013 * termhooks.h (struct terminal): Likewise.
761383f4 7014 * xterm.c (xembed_send_message): Likewise.
3c647824 7015
b58c5c4a
PE
7016 * insdel.c (make_gap_smaller): Define only if
7017 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7018
cad59032
PE
7019 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7020 it.
7021
c339dc2e
PE
7022 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7023 so that we aren't warned about unused symbols.
7024
91a3e27b
PE
7025 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7026
399c71d3 7027 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7028
8ffc96f5
PE
7029 * xfns.c (x_real_positions): Mark locals as initialized.
7030
eef9bc79
PE
7031 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7032
098db9dd
PE
7033 * xterm.c: Fix problems found by static analysis with other toolkits.
7034 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7035 (x_dispatch_event): Declare static if USE_GTK, and
7036 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7037 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7038 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7039 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7040 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7041
eb18f6cc
PE
7042 * xmenu.c (menu_help_callback): Pointer type fixes.
7043 Use const pointers when pointing at readonly data. Avoid pointer
7044 signedness clashes.
7045 (FALSE): Remove unused macro.
7046 (update_frame_menubar): Remove unused decl.
7047
1fe72bf8
PE
7048 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7049
60d9e1db
PE
7050 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7051 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7052 (single_menu_item): Rename local to avoid shadowing.
7053
39261c26
PE
7054 * keyboard.c (make_lispy_event): Remove unused local var.
7055
018c5e19
PE
7056 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7057 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7058
63d2b86e
PE
7059 * bitmaps: Change bitmaps from unsigned char back to the X11
7060 compatible char. Avoid the old compiler warnings about
7061 out-of-range initializers by using, for example, '\xab' rather
7062 than 0xab.
7063
aefd87e1
PE
7064 * xgselect.c (xgselect_initialize): Check vs interface
7065 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7066
bf501fb9
PE
7067 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7068
e9829fdf
PE
7069 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7070 to read-only memory.
7071
1086c095
PE
7072 * fns.c (vector): Remove; this old hack is no longer needed.
7073
2baccd04 7074 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7075 Remove unused var.
dde42981 7076 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7077
72391843 7078 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7079
436c16df 7080 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7081 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7082 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7083
92bb796d 7084 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7085 (x_term_init): Remove local to avoid shadowing.
92bb796d 7086
764430a3 7087 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7088
7089 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7090 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7091
d1dfb56c
EZ
70922011-04-16 Eli Zaretskii <eliz@gnu.org>
7093
c4354cb4
EZ
7094 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7095
d1dfb56c
EZ
7096 Fix regex.c, syntax.c and friends for buffers > 2GB.
7097 * syntax.h (struct gl_state_s): Declare character position members
7098 EMACS_INT.
7099
7100 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7101
04f2d78b
CB
7102 * textprop.c (verify_interval_modification, interval_of):
7103 Declare arguments EMACS_INT.
d1dfb56c
EZ
7104
7105 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7106 EMACS_INT.
7107
7108 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7109
7110 * indent.c (Fvertical_motion): Local variable it_start is now
7111 EMACS_INT.
7112
7113 * regex.c (re_match, re_match_2, re_match_2_internal)
7114 (bcmp_translate, regcomp, regexec, print_double_string)
7115 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7116 (re_compile_pattern, re_exec): Declare arguments and local
7117 variables `size_t' and `ssize_t' and return values `regoff_t', as
7118 appropriate.
7119 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7120 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7121 <compile_stack_type>: `size' and `avail' are now `size_t'.
7122
7123 * regex.h <regoff_t>: Use ssize_t, not int.
7124 (re_search, re_search_2, re_match, re_match_2): Arguments that
7125 specify buffer/string position and length are now ssize_t and
7126 size_t. Return type is regoff_t.
7127
613052cd
BK
71282011-04-16 Ben Key <bkey76@gmail.com>
7129
7130 * nsfont.m: Fixed bugs in ns_get_family and
7131 ns_descriptor_to_entity that were caused by using free to
7132 deallocate memory blocks that were allocated by xmalloc (via
7133 xstrdup). This caused Emacs to crash when compiled with
7134 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7135 --enable-checking=xmallocoverrun). xfree is now used to
7136 deallocate these memory blocks.
7137
4170f62f 71382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7139
71b41406
PE
7140 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7141
9587a89d
PE
7142 emacs_write: Accept and return EMACS_INT for sizes.
7143 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7144 et seq.
7145 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7146 Accept and return EMACS_INT.
7147 (emacs_gnutls_write): Return the number of bytes written on
7148 partial writes.
7149 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7150 (emacs_read, emacs_write): Remove check for negative size, as the
7151 Emacs source code has been audited now.
9587a89d
PE
7152 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7153 (emacs_read, emacs_write): Use it.
273a5f82
PE
7154 * process.c (send_process): Adjust to the new signatures of
7155 emacs_write and emacs_gnutls_write. Do not attempt to store
7156 a byte offset into an 'int'; it might overflow.
9587a89d 7157 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7158
3e047f51
PE
7159 * sound.c: Don't assume sizes fit in 'int'.
7160 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7161 Return EMACS_INT, not int.
3e047f51 7162 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7163 Accept EMACS_INT, not int.
7164 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7165 record read return values.
7166
cc39a9db
BK
71672011-04-15 Ben Key <bkey76@gmail.com>
7168
c9d0ec6d
JB
7169 * keyboard.c (Qundefined): Don't declare static since it is used
7170 in nsfns.m.
7171 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7172 static since they are used in nsfont.m.
cc39a9db 7173
6c60eb9f
SM
71742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7175
7176 * process.c (Qprocessp): Don't declare static.
7177 * lisp.h (Qprocessp): Declare again.
7178
7990b61a
JB
71792011-04-15 Juanma Barranquero <lekktu@gmail.com>
7180
7181 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7182
5d4cb038
PE
71832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7184
8bd7b830 7185 Improve C-level modularity by making more things 'static'.
cd64ea1d 7186
e3b27b31
PE
7187 Don't publish debugger-only interfaces to other modules.
7188 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7189 (verify_bytepos, count_markers): Move decls to the only modules
7190 that need them.
7191 * region-cache.h (pp_cache): Likewise.
7192 * window.h (check_all_windows): Likewise.
7193 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7194
5d4cb038
PE
7195 * sysdep.c (croak): Now static, if
7196 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7197 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7198
7199 * alloc.c (refill_memory_reserve): Now static if
7200 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7201 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7202
e87b6180
PE
7203 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7204 Define only if USE_LUCID.
7205
ac64929e
PE
7206 * xrdb.c (x_customization_string, x_rm_string): Now static.
7207
6f37259d
PE
7208 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7209 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7210
1683e3ab
PE
7211 * xdisp.c (draw_row_with_mouse_face): Now static.
7212 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7213
de9c2632
PE
7214 * window.h (check_all_windows): Mark externally visible.
7215
2b96acb7
PE
7216 * window.c (window_deletion_count): Now static.
7217
7218 * undo.c: Make symbols static if they're not exported.
7219 (last_undo_buffer, last_boundary_position, pending_boundary):
7220 Now static.
7221
50436f33
PE
7222 * textprop.c (interval_insert_behind_hooks): Now static.
7223 (interval_insert_in_front_hooks): Likewise.
7224
64520e5c
PE
7225 * term.c: Make symbols static if they're not exported.
7226 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7227 (max_frame_lines, tty_set_terminal_modes):
7228 (tty_reset_terminal_modes, tty_turn_off_highlight):
7229 (get_tty_terminal): Now static.
7230 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7231 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7232 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7233 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7234 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7235
1fa53021
PE
7236 * sysdep.c: Make symbols static if they're not exported.
7237 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7238 Now static.
7239 (sigprocmask_set, full_mask): Remove; unused.
7240 (wait_debugging): Mark as visible.
7241 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7242 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7243
d4b43b22
PE
7244 * syntax.c (syntax_temp): Define only if !__GNUC__.
7245
b7c513d0
PE
7246 * sound.c (current_sound_device, current_sound): Now static.
7247
989b29ad
PE
7248 * search.c (searchbufs, searchbuf_head): Now static.
7249
13a55a78
PE
7250 * scroll.c (scroll_cost): Remove; unused.
7251 * dispextern.h (scroll_cost): Remove decl.
7252
de68a1fc
PE
7253 * region-cache.h (pp_cache): Mark as externally visible.
7254
40ccffa6
PE
7255 * process.c: Make symbols static if they're not exported.
7256 (process_tick, update_tick, create_process, chan_process):
7257 (Vprocess_alist, proc_buffered_char, datagram_access):
7258 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7259 (deactivate_process): Mark defn as static, as well as decl.
7260 * lisp.h (create_process): Remove decl.
7261 * process.h (chan_process, Vprocess_alist): Remove decls.
7262
ad64fc97
PE
7263 * print.c: Make symbols static if they're not exported.
7264 (print_depth, new_backquote_output, being_printed, print_buffer):
7265 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7266 (print_interval, print_number_index, initial_stderr_stream):
7267 Now static.
7268 * lisp.h (Fprinc): Remove decl.
7269 (debug_output_compilation_hack): Mark as externally visible.
7270
adddb265
PE
7271 * sysdep.c (croak): Move decl from here to syssignal.h.
7272 * syssignal.h (croak): Put it here, so the API can be checked when
7273 'croak' is called from dissociate_if_controlling_tty.
7274
1717ede2
PE
7275 * minibuf.c: Make symbols static if they're not exported.
7276 (minibuf_save_list, choose_minibuf_frame): Now static.
7277 * lisp.h (choose_minibuf_frame): Remove decl.
7278
fa5fb2bc
PE
7279 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7280
1e3890d1
PE
7281 * lread.c: Make symbols static if they're not exported.
7282 (read_objects, initial_obarray, oblookup_last_bucket_number):
7283 Now static.
7284 (make_symbol): Remove; unused.
7285 * lisp.h (initial_obarray, make_symbol): Remove decls.
7286
8a1414fa
PE
7287 * keyboard.c: Make symbols static if they're not exported.
7288 (single_kboard, recent_keys_index, total_keys, recent_keys):
7289 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7290 (this_single_command_key_start, echoing, last_auto_save):
7291 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7292 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7293 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7294 (Vlispy_mouse_stem, double_click_count):
7295 Now static.
7296 (force_auto_save_soon): Define only if SIGDANGER.
7297 (ignore_mouse_drag_p): Now static if
7298 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7299 (print_help): Remove; unused.
7300 (stop_character, last_timer_event): Mark as externally visible.
7301 * keyboard.h (ignore_mouse_drag_p): Declare only if
7302 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7303 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7304 * lisp.h (echoing): Remove decl.
7305 (force_auto_save_soon): Declare only if SIGDANGER.
7306 * xdisp.c (redisplay_window): Simplify code, to make it more
7307 obvious that ignore_mouse_drag_p is not accessed if !defined
7308 USE_GTK && !defined HAVE_NS.
7309
93ea6e8f
PE
7310 * intervals.c: Make symbols static if they're not exported.
7311 (merge_properties_sticky, merge_interval_right, delete_interval):
7312 Now static.
7313 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7314
77382fcc
PE
7315 * insdel.c: Make symbols static if they're not exported.
7316 However, leave prepare_to_modify_buffer alone. It's never
7317 called from outside this function, but that appears to be a bug.
7318 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7319 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7320 (adjust_after_replace_noundo): Remove; unused.
7321 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7322 (signal_before_change): Remove decls.
77382fcc 7323
9306c32e
PE
7324 * indent.c (val_compute_motion, val_vmotion): Now static.
7325
cd44d2eb
PE
7326 * image.c: Make symbols static if they're not exported.
7327 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7328 if USE_GTK.
7329 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7330 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7331
ad9a7a06
PE
7332 * fringe.c (standard_bitmaps): Now static.
7333 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7334
81626931
PE
7335 * frame.c: Make symbols static if they're not exported.
7336 (x_report_frame_params, make_terminal_frame): Now static.
7337 (get_frame_param): Now static, unless HAVE_NS.
7338 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7339 (x_get_resource_string): Remove; not used.
7340 * frame.h (make_terminal_frame, x_report_frame_params):
7341 (x_get_resource_string); Remove decls.
7342 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7343 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7344
239f9db9
PE
7345 * font.c, fontset.c: Make symbols static if they're not exported.
7346 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7347 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7348 * font.c (font_close_object): Now static.
7349 * font.h (font_close_object): Remove.
7350 * fontset.c (FONTSET_OBJLIST): Remove.
7351 (free_realized_fontset) #if-0 the body, which does nothing.
7352 (face_suitable_for_char_p): #if-0, as it's never called.
7353 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7354 * xfaces.c (face_at_string_position):
7355 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7356 since 0 is always ASCII.
7357
dfcf3579
PE
7358 * fns.c (weak_hash_tables): Now static.
7359
5045092b
PE
7360 * fileio.c: Make symbols static if they're not exported.
7361 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7362 (Vwrite_region_annotation_buffers): Now static.
7363
57a96f5c
PE
7364 * eval.c: Make symbols static if they're not exported.
7365 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7366 * lisp.h (backtrace_list): Remove decl.
7367
35f08c38
PE
7368 * emacs.c: Make symbols static if they're not exported.
7369 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7370 (fatal_error_code, fatal_error_signal_hook, standard_args):
7371 Now static.
7372 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7373 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7374 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7375 * lisp.h (fatal_error_signal_hook): Remove decl.
7376 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7377
f44bd759
PE
7378 * editfns.c: Move a (normally-unused) function to its only use.
7379 * editfns.c, lisp.h (get_operating_system_release): Remove.
7380 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7381 worth the hassle of breaking this out.
7382
b532497d
PE
7383 * xterm.c: Make symbols static if they're not exported.
7384 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7385 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7386 (x_destroy_window, x_delete_display):
7387 Now static.
7388 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7389 (x_mouse_leave): Remove; unused.
7390 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7391 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7392 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7393 Remove decls.
7394 (x_mouse_leave): Declare only if WINDOWSNT.
7395 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7396 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7397 USE_X_TOOLKIT.
7398
1675728f
PE
7399 * ftxfont.c: Make symbols static if they're not exported.
7400 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7401 HAVE_FREETYPE.
7402 * font.h (ftxfont_driver): Likewise.
7403
e4cebfca
PE
7404 * xfns.c: Make symbols static if they're not exported.
7405 (x_last_font_name, x_display_info_for_name):
7406 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7407 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7408 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7409 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7410 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7411 (last_show_tip_args): Now static.
7412 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7413 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7414 (x_screen_planes): Remove; unused.
7415 * dispextern.h (x_screen_planes): Remove decl.
7416
5bf46f05
PE
7417 * dispnew.c: Make symbols static if they're not exported.
7418 * dispextern.h (redraw_garbaged_frames, scrolling):
7419 (increment_row_positions): Remove.
7420 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7421 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7422 Now static.
7423 (redraw_garbaged_frames): Remove; unused.
7424
435f4c28
PE
7425 * xfaces.c: Make symbols static if they're not exported.
7426 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7427 Remove decls.
7428 * xterm.h (defined_color): Remove decls.
7429 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7430 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7431 (menu_face_changed_default, defined_color, free_realized_face):
7432 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7433 (ascii_face_of_lisp_face): Remove; unused.
7434
8524aef3
PE
7435 * xdisp.c: Make symbols static if they're not exported.
7436 * dispextern.h (scratch_glyph_row, window_box_edges):
7437 (glyph_to_pixel_coords, set_cursor_from_row):
7438 (get_next_display_element, set_iterator_to_next):
7439 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7440 (show_mouse_face): Remove decls
7441 * frame.h (message_buf_print): Likewise.
7442 * lisp.h (pop_message, set_message, check_point_in_composition):
7443 Likewise.
7444 * xterm.h (set_vertical_scroll_bar): Likewise.
7445 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7446 (message_buf_print, scratch_glyph_row, displayed_buffer):
7447 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7448 (get_next_display_element, show_mouse_face, window_box_edges):
7449 (frame_to_window_pixel_xy, check_point_in_composition):
7450 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7451 (glyph_to_pixel_coords): Remove; unused.
7452
16390cd2
PE
7453 * dired.c (file_name_completion): Now static.
7454
7455 * dbusbind.c (xd_in_read_queued_messages): Now static.
7456
a25f4dfa
PE
7457 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7458 * data.c (circular_list_error): Remove.
7459
14a9c8df
PE
7460 * commands.h (last_point_position, last_point_position_buffer):
7461 (last_point_position_window): Remove decls.
7462 * keyboard.c: Make these variables static.
7463
04f2d78b
CB
7464 * coding.h (coding, code_convert_region, encode_coding_gap):
7465 Remove decls.
74ab6df5
PE
7466 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7467 (iso_code_class, detect_coding, code_convert_region): Now static.
7468 (encode_coding_gap): Remove; unused.
7469
38dfbee1
PE
7470 * chartab.c (chartab_chars, chartab_bits): Now static.
7471
a2cb4e63
PE
7472 * charset.h (charset_iso_8859_1): Remove decl.
7473 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7474 Now static.
7475
127198fd
PE
7476 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7477 * ccl.c (Vccl_program_table): Now static.
7478 (check_ccl_update): Remove; unused.
7479
d85b608f
PE
7480 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7481 * category.h: ... from here.
7482 * category.c (check_category_table, set_category_set): Now static.
7483
31cd66f3
PE
7484 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7485 * lisp.h: Remove these decls.
7486
c358e587
PE
7487 * buffer.c (buffer_count): Remove unused var.
7488
e78aecca
PE
7489 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7490 so that it's not optimized away.
7491 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7492 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7493 exported only to the debugger.
7494
e192d7d3 7495 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7496 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7497
92470028
PE
7498 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7499 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7500 was inaccessible from Lisp.
7501 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7502 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7503
244ed907
PE
7504 alloc.c: Import and export fewer symbols, and remove unused items.
7505 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7506 is defined.
7507 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7508 it's not optimized away by whole-program optimization.
7509 (message_enable_multibyte, free_misc): Remove.
7510 (catchlist, handlerlist, mark_backtrace):
7511 Declare only if BYTE_MARK_STACK.
7512 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7513 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7514 (message_enable_multibyte): Remove decl.
7515 (free_misc, interval_free_list, float_block, float_block_index):
7516 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7517 (cons_free_list, last_marked_index):
7518 Now static.
7519 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7520 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7521 (mark_backtrace): Define only if BYTE_MARK_STACK.
7522 * xdisp.c (message_enable_multibyte): Now static.
7523
61c2b50e 7524 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7525 This makes it easier for human readers (and static analyzers)
7526 to see whether these variables are used from other modules.
7527 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7528 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7529 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7530 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7531 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7532 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7533 * xmenu.c, xselect.c:
7534 Declare Q* vars static if they are not used in other modules.
7535 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7536 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7537 Remove decls of unexported vars.
7538 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7539
95c82688
PE
7540 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7541
16a97296
PE
7542 Make Emacs functions such as Fatom 'static' by default.
7543 This makes it easier for human readers (and static analyzers)
7544 to see whether these functions can be called from other modules.
7545 DEFUN now defines a static function. To make the function external
7546 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7547 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7548 (Finit_image_library):
16a97296
PE
7549 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7550 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7551 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7552 Remove decls, since these functions are now static.
7553 (Funintern, Fget_internal_run_time): New decls, since these functions
7554 were already external.
95c82688 7555
16a97296
PE
7556 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7557 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7558 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7559 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7560 * keyboard.c, keymap.c, lread.c:
7561 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7562 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7563 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7564 Mark functions with DEFUE instead of DEFUN,
7565 if they are used in other modules.
7566 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7567 decls for now-static functions.
7568 * buffer.h (Fdelete_overlay): Remove decl.
7569 * callproc.c (Fgetenv_internal): Mark as internal.
7570 * composite.c (Fremove_list_of_text_properties): Remove decl.
7571 (Fcomposition_get_gstring): New forward static decl.
7572 * composite.h (Fcomposite_get_gstring): Remove decl.
7573 * dired.c (Ffile_attributes): New forward static decl.
7574 * doc.c (Fdocumntation_property): New forward static decl.
7575 * eval.c (Ffetch_bytecode): New forward static decl.
7576 (Funintern): Remove extern decl; now in .h file where it belongs.
7577 * fileio.c (Fmake_symbolic_link): New forward static decl.
7578 * image.c (Finit_image_library): New forward static decl.
7579 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7580 * intervals.h (Fprevious_property_change):
7581 (Fremove_list_of_text_properties): Remove decls.
7582 * keyboard.c (Fthis_command_keys): Remove decl.
7583 (Fcommand_execute): New forward static decl.
7584 * keymap.c (Flookup_key): New forward static decl.
7585 (Fcopy_keymap): Now static.
7586 * keymap.h (Flookup_key): Remove decl.
7587 * process.c (Fget_process): New forward static decl.
7588 (Fprocess_datagram_address): Mark as internal.
7589 * syntax.c (Fsyntax_table_p): New forward static decl.
7590 (skip_chars): Remove duplicate decl.
7591 * textprop.c (Fprevious_property_change): New forward static decl.
7592 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7593 Now internal.
7594 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7595 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7596
785bbd42
PE
7597 * editfns.c (Fformat): Remove unreachable code.
7598
8b913b57
AS
75992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7600
7601 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7602 change. (Bug#8496)
7603
a6744a35
EZ
76042011-04-13 Eli Zaretskii <eliz@gnu.org>
7605
7606 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7607 when at ZV. (Bug#8487)
7608
e7974947
AS
76092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7610
baad03f0
AS
7611 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7612 (Bug#8437)
7613 * keyboard.c (parse_tool_bar_item): Likewise.
7614 * sound.c (sound_cleanup, alsa_close): Likewise.
7615 * termcap.c (tgetent): Likewise.
7616 * xfns.c (x_default_font_parameter): Likewise.
7617 * xsettings.c (read_and_apply_settings): Likewise.
7618
e7974947
AS
7619 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7620 (overrun_check_free): Protoize.
7621
28272684
PE
76222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7623
7624 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7625 since callers should never pass a negative size.
7626 Change the signature to match that of plain 'read' and 'write'; see
7627 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7628 * lisp.h: Update prototypes of emacs_write and emacs_read.
7629
11997c76
EZ
76302011-04-11 Eli Zaretskii <eliz@gnu.org>
7631
7632 * xdisp.c (redisplay_window): Don't try to determine the character
7633 position of the scroll margin if the window start point w->startp
e896f03c 7634 is outside the buffer's accessible region. (Bug#8468)
11997c76 7635
8a2cbd72
EZ
76362011-04-10 Eli Zaretskii <eliz@gnu.org>
7637
7638 Fix write-region and its subroutines for buffers > 2GB.
7639 * fileio.c (a_write, e_write): Modify declaration of arguments and
7640 local variables to support buffers larger than 2GB.
7641 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7642
7643 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7644 argument, local variables, and return value.
7645
7646 * lisp.h: Update prototypes of emacs_write and emacs_read.
7647
7648 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7649
4073e537 76502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7651
1ebfdcb6
PE
7652 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7653
b2ded58d
PE
7654 Fix more problems found by GCC 4.6.0's static checks.
7655
7d66342c
PE
7656 * xdisp.c (vmessage): Use a better test for character truncation.
7657
bbf47d44
PE
7658 * charset.c (load_charset_map): <, not <=, for optimization,
7659 and to avoid potential problems with integer overflow.
9248994d 7660 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7661 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7662 * editfns.c (Fformat): Likewise.
1e69125e 7663 * syntax.c (skip_chars): Likewise.
3befa583 7664
e3019616
PE
7665 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7666 This also lets GCC 4.6.0 generate slightly better loop code.
7667
becfa255
PE
7668 * callint.c (Fcall_interactively): <, not <=, for optimization.
7669 (Fcall_interactively): Count the number of arguments produced,
7670 not the number of arguments given. This is simpler and lets GCC
7671 4.6.0 generate slightly better code.
7672
dae0cd48
PE
7673 * ftfont.c: Distingish more carefully between FcChar8 and char.
7674 The previous code passed unsigned char * to a functions like
7675 strlen and xstrcasecmp that expect char *, which does not
7676 conform to the C standard.
7677 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7678 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7679 char * when the C standard requires it.
7680
76032d70
PE
7681 * keyboard.c (read_char): Remove unused var.
7682
eb3f1cc8
PE
7683 * eval.c: Port to Windows vsnprintf (Bug#8435).
7684 Include <limits.h>.
7685 (SIZE_MAX): Define if the headers do not.
7686 (verror): Do not give up if vsnprintf returns a negative count.
7687 Instead, grow the buffer. This ports to Windows vsnprintf, which
7688 does not conform to C99. Problem reported by Eli Zaretskii.
7689 Also, simplify the allocation scheme, by avoiding the need for
7690 calling realloc, and removing the ALLOCATED variable.
7691
70476b54
PE
7692 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7693
12020a9e
PE
7694 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7695 But keep the doprint source code for now, as we might revamp it
7696 and use it again (Bug#8435).
ea6c7ae6
PE
7697 * lisp.h (doprnt): Remove.
7698 * Makefile.in (base_obj): Remove doprnt.o.
7699 * deps.mk (doprnt.o): Remove.
7700
5fdb398c
PE
7701 error: Print 32- and 64-bit integers portably (Bug#8435).
7702 Without this change, on typical 64-bit hosts error ("...%d...", N)
7703 was used to print both 32- and 64-bit integers N, which relied on
7704 undefined behavior.
7705 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7706 New macro.
7707 * lisp.h (error, verror): Mark as printf-like functions.
7708 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7709 Report overflow in size calculations when allocating printf buffer.
7710 Do not truncate output string at its first null byte.
7711 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7712 Truncate the output at a character boundary, since vsnprintf does not
7713 do that.
7714 * charset.c (check_iso_charset_parameter): Convert internal
7715 character to string before calling 'error', since %c now has the
7716 printf meaning.
7717 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7718 overflow when computing char to be passed to 'error'. Do not
7719 pass Lisp_Object to 'error'; pass the integer instead.
7720 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7721 formatted with plain %d.
7722
b189fa66
PE
7723 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7724
bff87ef0
PE
7725 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7726
7e2cac20
PE
7727 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7728
ce4d90b5
PE
7729 * xterm.c (x_catch_errors): Remove duplicate declaration.
7730
266c9547
PE
7731 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7732
79c49ad2
PE
7733 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7734
368f4090
JM
77352011-04-10 Jim Meyering <meyering@redhat.com>
7736
7737 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7738 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7739 return ssize_t not "int", and use size_t as the buffer length.
7740 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7741 * gnutls.h: Update declarations.
7742 * process.c (read_process_output): Use ssize_t, to match.
7743 (send_process): Likewise.
7744
a32d4040
CY
77452011-04-09 Chong Yidong <cyd@stupidchicken.com>
7746
7747 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7748
8546720e 77492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7750
04f2d78b
CB
7751 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7752 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7753
8546720e
GM
7754 * xterm.c (handle_one_xevent):
7755 * xmenu.c (create_and_show_popup_menu):
7756 * xselect.c (x_decline_selection_request)
7757 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7758
0a2f5c1a 77592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7760
7761 Fix some uses of `int' instead of EMACS_INT.
7762 * search.c (string_match_1, fast_string_match)
7763 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7764 (scan_buffer, find_next_newline_no_quit)
7765 (find_before_next_newline, search_command, Freplace_match)
7766 (Fmatch_data): Make some `int' variables be EMACS_INT.
7767
7768 * xdisp.c (display_count_lines): 3rd argument and return value now
7769 EMACS_INT. All callers changed.
7770 (pint2hrstr): Last argument is now EMACS_INT.
7771
7772 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7773 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7774 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7775 (decode_coding_utf_16, decode_coding_emacs_mule)
7776 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7777 (decode_coding_ccl, decode_coding_charset)
7778 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7779 (decode_coding_iso_2022, decode_coding_emacs_mule)
7780 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7781 <char_offset, last_offset>: Declare EMACS_INT.
7782 (encode_coding_utf_8, encode_coding_utf_16)
7783 (encode_coding_emacs_mule, encode_invocation_designation)
7784 (encode_designation_at_bol, encode_coding_iso_2022)
7785 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7786 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7787 Declare EMACS_INT.
7788 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7789 (encode_invocation_designation): Last argument P_NCHARS is now
7790 EMACS_INT.
7791 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7792 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7793
7794 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7795 All users changed.
7796
7797 * ccl.c (Fccl_execute_on_string): Declare some variables
7798 EMACS_INT.
7799
8546720e 78002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7801
7802 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7803
4e19a977
CS
78042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7805
7806 * process.c (Fformat_network_address): Doc fix.
7807
87302331
R
78082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7809
ee7683eb 7810 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7811
cbb59342
CY
78122011-04-08 Chong Yidong <cyd@stupidchicken.com>
7813
7814 * keyboard.c (read_char): Call Lisp function help-form-show,
7815 instead of using internal_with_output_to_temp_buffer.
7816 (Qhelp_form_show): New var.
e0d38eeb 7817 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7818
7819 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7820
7821 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7822
e67a13ab
CY
78232011-04-06 Chong Yidong <cyd@stupidchicken.com>
7824
04f2d78b
CB
7825 * process.c (Flist_processes): Remove to Lisp.
7826 (list_processes_1): Delete.
e67a13ab 7827
973f782d
EZ
78282011-04-06 Eli Zaretskii <eliz@gnu.org>
7829
7c106b1e
EZ
7830 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7831
973f782d
EZ
7832 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7833
41cf7d1a 78342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7835
ca23cc88
PE
7836 Fix more problems found by GCC 4.6.0's static checks.
7837
f390e2d5
PE
7838 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7839
42eea0d0
PE
7840 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7841
b69769da 7842 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7843
f9541e84
PE
7844 * xdisp.c (vmessage): Mark as a printf-like function.
7845
13841b55
PE
7846 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7847
c136c10f
PE
7848 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7849
5e2d4a30
PE
7850 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7851 printf-like functions.
7852 (tiff_load): Add casts to remove these marks before passing them
7853 to system-supplied API.
7854
583f48b9
PE
7855 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7856
b25d760e
PE
7857 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7858 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7859 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7860 directly, rather than having caller test rule sign. This avoids
7861 some unnecessary tests.
7862 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7863 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7864 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7865
bc7b6697 7866 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7867 (xfont_open): Avoid unnecessary tests.
bc7b6697 7868
27ccc379
PE
7869 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7870
dcd5c89a
PE
7871 * composite.h, composite.c (composition_gstring_put_cache):
7872 Use EMACS_INT, not int, for length.
7873
b13a45c6
PE
7874 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7875 breaking out part of COMPOSITION_DECODE_RULE.
7876 (COMPOSITION_DECODE_RULE): Use it.
7877 * composite.c (get_composition_id): Remove unused local vars,
7878 by using the new macro.
7879
1e792e4d
PE
7880 * textprop.c (set_text_properties_1): Change while to do-while,
7881 since the condition is always true at first.
7882
dc6c6455 7883 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7884 (interval_deletion_adjustment): Return unsigned value.
7885 All uses changed.
dc6c6455 7886
aba7731a
PE
7887 * process.c (list_processes_1, create_pty, read_process_output):
7888 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7889 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7890 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7891 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7892 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7893
fdfc4bf3
PE
7894 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7895
fca8fe46 7896 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7897 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7898
06a0259a 7899 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7900 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7901 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7902
e7b9e80f
PE
7903 * print.c (print_error_message): Avoid int overflow.
7904
56201685
PE
7905 * font.c (font_list_entities): Redo for clarity,
7906 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7907
78834453 7908 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7909 (font_score): Avoid potential overflow in diff calculation.
78834453 7910
0bc0b309 7911 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7912 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7913
e610eaca
PE
7914 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7915
b895abce
PE
7916 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7917 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7918 can always succeed if overflow has undefined behavior.
7919
1f1d9321 7920 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7921 (wordify): Omit three unnecessary tests.
1f1d9321 7922
c59478bc
PE
7923 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7924 All callers changed. This avoids the need for an unused var.
7925
79b73827
PE
7926 * casefiddle.c (casify_region): Remove var that is set but not used.
7927
a4db5dfe
PE
7928 * dired.c (file_name_completion): Remove var that is set but not used.
7929
43aae36e
PE
7930 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7931
2a47c44d 7932 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7933 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7934
a37c69bf
PE
7935 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7936 Check for integer overflow on size calculations.
7937
328ab8e7
PE
7938 * buffer.c (Fprevious_overlay_change): Remove var that is set
7939 but not used.
7940
e5a2a5cb
PE
7941 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7942 Remove vars that are set but not used.
8d84a6eb 7943 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7944 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7945
a60e5f68
PE
7946 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7947
f661cb61 7948 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7949 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7950
f0397f5a
PE
7951 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7952 that are set but not used.
7953
8664db06 7954 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7955 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7956
6abdaa4a
PE
7957 * xselect.c (x_get_local_selection, x_handle_property_notify):
7958 Remove vars that are set but not used.
7959
0ce7538d 7960 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7961 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7962
9ae848fc
PE
7963 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7964 Remove var that is set but not used.
0b918413
PE
7965 (scroll_bar_windows_size): Now size_t, not int.
7966 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7967 Check for overflow.
9ae848fc 7968
a5a62657
PE
7969 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7970 (map_tty_color) [!defined MSDOS]: Likewise.
7971
5c5cdd39
PE
7972 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7973
66ebf983
PE
7974 * coding.c: Remove vars that are set but not used.
7975 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7976 All callers changed.
7977 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7978 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7979 (decode_coding_charset): Remove vars that are set but not used.
7980
1be4d761
PE
7981 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7982 that is set but not used.
7983
47553fa8
PE
7984 * print.c (print_object): Remove var that is set but not used.
7985
1f7196bf 7986 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7987 The gnulib version avoids calling malloc in the usual case,
7988 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7989 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7990 * filelock.c (current_lock_owner): Likewise.
7991 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7992 * sysdep.c: Include allocator.h, careadlinkat.h.
7993 (emacs_no_realloc_allocator): New static constant.
7994 (emacs_readlink): New function.
fdb61804
PE
7995 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7996 ../lib/careadlinkat.h.
d1fdcab7 7997
f84c17c7
SM
79982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7999
8000 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8001 first non-nil return value).
8002
ef3862ad
JD
80032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8004
8005 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8006 if not defined (Bug#8403).
8007
376a7006
JB
80082011-04-02 Juanma Barranquero <lekktu@gmail.com>
8009
8010 * xdisp.c (display_count_lines): Remove parameter `start',
8011 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8012 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8013 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8014 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8015 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8016 and thereabouts. All callers changed.
8017 (get_per_char_metric): Remove parameter `f', unused since
8018 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8019
6ca3801d
JM
80202011-04-02 Jim Meyering <meyering@redhat.com>
8021
8022 do not dereference NULL upon failed strdup
8023 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8024 (ns_get_family): Likewise.
8025
d8e2b5ba
JB
80262011-04-02 Juanma Barranquero <lekktu@gmail.com>
8027
8028 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8029
8c74fcbd
JD
80302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8031
8032 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8033 later (Bug#8403).
8034
7200d79c
SM
80352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8036
03408648 8037 Add lexical binding.
7200d79c 8038
03408648
SM
8039 * window.c (Ftemp_output_buffer_show): New fun.
8040 (Fsave_window_excursion):
8041 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8042
8043 * lread.c (lisp_file_lexically_bound_p): New function.
8044 (Fload): Bind Qlexical_binding.
8045 (readevalloop): Remove `evalfun' arg.
8046 Bind Qinternal_interpreter_environment.
8047 (Feval_buffer): Bind Qlexical_binding.
8048 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8049 Mark as dynamic.
8050 (syms_of_lread): Declare `lexical-binding'.
8051
8052 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8053
8054 * keyboard.c (eval_dyn): New fun.
8055 (menu_item_eval_property): Use it.
ca105506
SM
8056
8057 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8058
03408648
SM
8059 * fns.c (concat, mapcar1): Accept byte-code-functions.
8060
8061 * eval.c (Fsetq): Handle lexical vars.
8062 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8063 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8064 (FletX, Flet): Obey lexical binding.
8065 (Fcommandp): Handle closures.
8066 (Feval): New `lexical' arg.
8067 (eval_sub): New function extracted from Feval. Use it almost
8068 everywhere where Feval was used. Look up vars in lexical env.
8069 Handle closures.
8070 (Ffunctionp): Move from subr.el.
8071 (Ffuncall): Handle closures.
8072 (apply_lambda): Remove `eval_flags'.
8073 (funcall_lambda): Handle closures and new byte-code-functions.
8074 (Fspecial_variable_p): New function.
8075 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8076 but without exporting it to Lisp.
23aba0ea 8077
23aba0ea 8078 * doc.c (Fdocumentation, store_function_docstring):
03408648 8079 * data.c (Finteractive_form): Handle closures.
23aba0ea 8080
03408648
SM
8081 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8082 interactive spec.
ba83908c 8083
04f2d78b
CB
8084 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8085 New byte-codes.
03408648
SM
8086 (exec_byte_code): New function extracted from Fbyte_code to handle new
8087 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8088
03408648 8089 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8090
03408648 8091 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8092
e2abce01
JB
80932011-03-31 Juanma Barranquero <lekktu@gmail.com>
8094
8095 * xdisp.c (redisplay_internal): Fix prototype.
8096
63696a73 80972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8098
63696a73 8099 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8100 (try_scrolling): Use it when setting scroll_limit.
8101 Limit scrolling to 100 screen lines.
63696a73
EZ
8102 (redisplay_window): Even when falling back on "recentering",
8103 position point in the window according to scroll-conservatively,
8104 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8105
8106 (try_scrolling): When point is above the window, allow searching
8107 as far as scroll_max, or one screenful, to compute vertical
8108 distance from PT to the scroll margin position. This prevents
8109 try_scrolling from unnecessarily failing when
8110 scroll-conservatively is set to a value slightly larger than the
8111 window height. Clean up the case of PT below the margin at bottom
8112 of window: scroll_max can no longer be INT_MAX. When aggressive
8113 scrolling is in use, don't let point enter the opposite scroll
8114 margin as result of the scroll.
8115 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8116 threshold of 100 lines for never-recentering scrolling.
8117
e4cc2dfc
JB
81182011-03-31 Juanma Barranquero <lekktu@gmail.com>
8119
8120 * dispextern.h (move_it_by_lines):
8121 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8122 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8123 (message_log_check_duplicate): Remove parameters `prev_bol' and
8124 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8125 (redisplay_internal): Remove parameter `preserve_echo_area',
8126 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8127
8128 * indent.c (Fvertical_motion):
8129 * window.c (window_scroll_pixel_based, Frecenter):
8130 Don't pass `need_y_p' to `move_it_by_lines'.
8131
1c470562
SM
81322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8133
44f230aa
SM
8134 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8135 steal a few bits to be more compact.
8136 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8137 Remove unneeded casts.
8138
1c470562
SM
8139 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8140
888adce9
ZK
81412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8142
8143 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8144 binding" message (bug#7967).
8145
f838ed7b
PE
81462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8147
77861b95
PE
8148 Fix more problems found by GCC 4.6.0's static checks.
8149
de6dbc14
PE
8150 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8151 Remove unused local var.
8152
f838ed7b
PE
8153 * editfns.c (Fmessage_box): Remove unused local var.
8154
792c7b2b
PE
8155 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8156 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8157 Omit unused local vars.
c499e557 8158 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8159 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8160 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8161 Omit unused local var.
8162
ba0165e1
PE
8163 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8164 Don't assume string length fits in int.
32ad8845 8165 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8166 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8167
3c59b4c9
PE
8168 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8169 instead of alloca (Bug#8344).
8170
a3eed478 8171 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8172 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8173
eb4d412d
PE
8174 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8175
1658b401
PE
8176 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8177 concerns.
8178
8179 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8180
8181 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8182
9a2c6e05
PE
8183 * keyboard.c (syms_of_keyboard): Use the same style as later
8184 in this function when indexing through an array. This also
8185 works around GCC bug 48267.
8186
03d0a109
PE
8187 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8188
44f730c8
PE
8189 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8190
fe75f926
PE
8191 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8192 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8193
ffa8c828
PE
8194 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8195 This avoids undefined behavior on integer overflow, and is a bit
8196 more convenient anyway since it is compared to a size_t variable.
8197
c5101a77
PE
8198 Variadic C functions now count arguments with size_t, not int.
8199 This avoids an unnecessary limitation on 64-bit machines, which
8200 caused (substring ...) to crash on large vectors (Bug#8344).
8201 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8202 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8203 All variadic functions and their callers changed accordingly.
c5101a77
PE
8204 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8205 * data.c (arith_driver, float_arith_driver): Likewise.
8206 * editfns.c (general_insert_function): Likewise.
8207 * eval.c (struct backtrace.nargs, interactive_p)
8208 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8209 (funcall_lambda, mark_backtrace): Likewise.
8210 * fns.c (concat): Likewise.
8211 * frame.c (x_set_frame_parameters): Likewise.
8212 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8213 0 if not found, not -1. All callers changed.
8214
dd3f25f7
PE
8215 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8216 (stack_copy_size): Now size_t, not int.
8217 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8218
461c2ab9
JB
82192011-03-28 Juanma Barranquero <lekktu@gmail.com>
8220
8221 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8222 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8223 All callers changed.
8224
8225 * lisp.h (multibyte_char_to_unibyte):
8226 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8227 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8228 * character.h (CHAR_TO_BYTE8):
8229 * cmds.c (internal_self_insert):
8230 * editfns.c (general_insert_function):
8231 * keymap.c (push_key_description):
8232 * search.c (Freplace_match):
8233 * xdisp.c (message_dolog, set_message_1): All callers changed.
8234
f6d62986
SM
82352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8236
8237 * keyboard.c (safe_run_hook_funcall): New function.
8238 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8239 don't set the hook to nil, but remove the offending function instead.
8240 (Qcommand_hook_internal): Remove, unused.
8241 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8242 Vcommand_hook_internal.
8243
8244 * eval.c (enum run_hooks_condition): Remove.
8245 (funcall_nil, funcall_not): New functions.
8246 (run_hook_with_args): Call each function through a `funcall' argument.
8247 Remove `cond' argument, now redundant.
8248 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8249 (Frun_hook_with_args_until_failure): Adjust accordingly.
8250 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8251
1db5b1ad
JB
82522011-03-28 Juanma Barranquero <lekktu@gmail.com>
8253
8254 * dispextern.h (string_buffer_position): Remove declaration.
8255
8256 * print.c (strout): Remove parameter `multibyte', unused since
8257 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8258
8259 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8260 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8261 All callers changed.
8262
8263 * w32.c (_wsa_errlist): Use braces for struct initializers.
8264
8265 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8266 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8267 All callers changed.
8268 (string_buffer_position): Likewise. Also, make static (it's never
8269 used outside xdisp.c).
8270 (cursor_row_p): Remove parameter `w', unused since
8271 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8272 (decode_mode_spec): Remove parameter `precision', introduced during
8273 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8274 All callers changed.
8275
5ffb62aa
JD
82762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8277
8278 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8279
461c2ab9 82802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8281
8282 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8283 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8284 (ns_update_auto_hide_menu_bar): New functions.
8285 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8286 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8287 ns_constrain_all_frames.
8288 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8289 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8290
5c380ffb
JD
82912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8292
8293 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8294
9af30bdf
GM
82952011-03-27 Glenn Morris <rgm@gnu.org>
8296
8297 * syssignal.h: Replace RETSIGTYPE with void.
8298 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8299 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8300 Replace SIGTYPE with void everywhere.
8301 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8302 * s/template.h (SIGTYPE): Remove commented out definition.
8303
e2abce01
JB
83042011-03-26 Eli Zaretskii <eliz@gnu.org>
8305
8306 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8307 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8308
f868cd8a
JB
83092011-03-26 Juanma Barranquero <lekktu@gmail.com>
8310
59eb0929
JB
8311 * w32.c (read_unc_volume): Use parameter `henum', instead of
8312 global variable `wget_enum_handle'.
8313
8314 * keymap.c (describe_vector): Remove parameters `indices' and
8315 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8316 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8317
f868cd8a
JB
8318 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8319
8320 * keyboard.c (timer_check): Remove parameter `do_it_now',
8321 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8322 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8323 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8324
8325 * keyboard.c (read_char):
8326 * w32menu.c (w32_menu_display_help):
8327 * xmenu.c (show_help_event, menu_help_callback):
8328 Adjust calls to `show_help_echo'.
8329
8330 * gtkutil.c (xg_maybe_add_timer):
8331 * keyboard.c (readable_events):
8332 * process.c (wait_reading_process_output):
8333 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8334
8335 * insdel.c (adjust_markers_gap_motion):
8336 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8337 (gap_left, gap_right): Don't call it.
8338
2ecf6fdb
CY
83392011-03-25 Chong Yidong <cyd@stupidchicken.com>
8340
8341 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8342 incurred during fontification.
8343
6b1f9ba4
JB
83442011-03-25 Juanma Barranquero <lekktu@gmail.com>
8345
8346 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8347 (DEFVAR_PER_BUFFER): Don't pass it.
8348
8349 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8350 (scrolling_window): Don't pass it.
8351
0f4a96b5
JB
83522011-03-25 Juanma Barranquero <lekktu@gmail.com>
8353
8354 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8355
8356 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8357 and `suffix'.
8358 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8359 of variables specific to SELinux and computation of `encoded_absname'.
8360
8361 * image.c (XPutPixel): Remove unused variable `height'.
8362
8363 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8364
8365 * unexw32.c (get_section_info): Remove unused variable `section'.
8366
8367 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8368 (system_process_attributes): Remove unused variable `sess'.
8369 (sys_read): Remove unused variable `err'.
8370
8371 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8372 (w32_wnd_proc): Remove unused variable `isdead'.
8373 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8374 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8375 (x_create_tip_frame): Remove unused variable `tem'.
8376
8377 * w32inevt.c (w32_console_read_socket):
8378 Remove unused variable `no_events'.
8379
8380 * w32term.c (x_draw_composite_glyph_string_foreground):
8381 Remove unused variable `width'.
8382
1149507c
JB
83832011-03-24 Juanma Barranquero <lekktu@gmail.com>
8384
8385 * w32term.c (x_set_glyph_string_clipping):
8386 Don't pass uninitialized region to CombineRgn.
8387
9c88f339
JB
83882011-03-23 Juanma Barranquero <lekktu@gmail.com>
8389
8390 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8391 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8392 (Fx_close_connection): Remove unused variable `i'.
8393
8394 * w32font.c (w32font_draw): Return number of glyphs.
8395 (w32font_open_internal): Remove unused variable `i'.
8396 (w32font_driver): Add missing initializer.
8397
8398 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8399 (fill_in_menu): Remove unused variable `items_added'.
8400
8401 * w32term.c (last_mouse_press_frame): Remove static global variable.
8402 (w32_clip_to_row): Remove unused variable `f'.
8403 (x_delete_terminal): Remove unused variable `i'.
8404
8405 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8406 (NOTHING): Remove unused static global variable.
8407 (uniscribe_check_otf): Remove unused variable `table'.
8408 (uniscribe_font_driver): Add missing initializers.
8409
dee091a3
JD
84102011-03-23 Julien Danjou <julien@danjou.info>
8411
8412 * term.c (Fsuspend_tty, Fresume_tty):
8413 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8414 * window.c (temp_output_buffer_show):
8415 * insdel.c (signal_before_change):
8416 * frame.c (Fhandle_switch_frame):
8417 * fileio.c (Fdo_auto_save):
8418 * emacs.c (Fkill_emacs):
8419 * editfns.c (save_excursion_restore):
8420 * cmds.c (internal_self_insert):
8421 * callint.c (Fcall_interactively):
8422 * buffer.c (Fkill_all_local_variables):
8423 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8424 Use Frun_hooks.
0f4a96b5 8425 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8426 unconditionally since it does the check itself.
dee091a3 8427
2c520ab5 84282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8429
c9c49752
PE
8430 Fix more problems found by GCC 4.5.2's static checks.
8431
8abc3f12
PE
8432 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8433 the first time through the loop, since we know p0 < p1 then.
8434 This also avoids a gcc -Wstrict-overflow warning.
8435
a2d26660
PE
8436 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8437 leading to a memory leak, possible in functions like
8438 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8439 of objects (Bug#8318).
a2d26660 8440
916c72e9
PE
8441 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8442 that could (at least in theory) be that large.
8443
19ab8a18
PE
8444 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8445 This is less likely to overflow, and avoids undefined behavior if
8446 overflow does occur. All callers changed. Use strtoul to scan
8447 for the unsigned long integer.
b7cbbd6f
PE
8448 (pint2hrstr): Simplify and tune code slightly.
8449 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8450
f0641eff
PE
8451 * scroll.c (do_scrolling): Work around GCC bug 48228.
8452 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8453
7f650bb9
PE
8454 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8455 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8456 (validate_x_resource_name): Simplify count usage.
8457 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8458
37dd57d1
PE
8459 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8460 fail (Bug#8306).
81e56e61 8461
699979fc 8462 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8463
401bf9b4
PE
8464 * process.c (Fmake_network_process): Use socklen_t, not int,
8465 where POSIX says socklen_t is required in portable programs.
8466 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8467 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8468 (Fmake_network_process, server_accept_connection):
8469 (wait_reading_process_output, read_process_output):
8470 Likewise.
8471
b93aacde
PE
8472 * process.c: Rename or move locals to avoid shadowing.
8473 (list_processes_1, Fmake_network_process):
8474 (read_process_output_error_handler, exec_sentinel_error_handler):
8475 Rename or move locals.
4dc343ee 8476 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8477 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8478 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8479 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8480 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8481
af8a867c 8482 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8483 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8484 Include tparam.h instead, since it declares them.
af8a867c
PE
8485 * cm.h (PC): Remove extern decl; tparam.h now does this.
8486 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8487 * terminfo.c: Include tparam.h, to check interfaces.
8488 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8489 (tparam): Adjust signature to match interface in tparam.h;
8490 this removes some undefined behavior. Check that outstring and len
8491 are zero, which they always are with Emacs.
8492 * tparam.h (PC, BC, UP): New extern decls.
8493
0248044d 8494 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8495 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8496
8ff096c1 8497 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8498 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8499 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8500 (ftfont_list): Remove unused local.
49eaafba
PE
8501 (get_adstyle_property, ftfont_pattern_entity):
8502 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8503 Rename locals to avoid shadowing.
8ff096c1 8504
e2be39f6
PE
8505 * xfont.c (xfont_list_family): Mark var as initialized.
8506
c9735e30
PE
8507 * xml.c (make_dom): Now static.
8508
8f5201ae
PE
8509 * composite.c (composition_compute_stop_pos): Rename local to
8510 avoid shadowing.
b246f932
PE
8511 (composition_reseat_it): Remove unused locals.
8512 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8513 (composition_update_it): Mark var as initialized.
11b61122
PE
8514 (find_automatic_composition): Mark vars as initialized,
8515 with a FIXME (Bug#8290).
8f5201ae 8516
760fbc2c
PE
8517 character.h: Rename locals to avoid shadowing.
8518 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8519 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8520 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8521 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8522 to avoid shadowing.
8523
ff08eb85
PE
8524 * textprop.c (property_change_between_p): Remove; unused.
8525
fc7bf025
PE
8526 * intervals.c (interval_start_pos): Now static.
8527
235d7abc
PE
8528 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8529
44f230aa
SM
8530 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8531 Rename locals to avoid shadowing.
3e7d6594 8532
50060332
PE
8533 * sound.c (wav_play, au_play, Fplay_sound_internal):
8534 Fix pointer signedness.
d01f234b 8535 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8536 (wav_play): Initialize a variable to 0, to prevent undefined
8537 behavior (Bug#8278).
50060332 8538
c4fc4e30
PE
8539 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8540
918436ed
PE
8541 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8542
c939f91b
PE
8543 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8544 clobbering (Bug#8298).
b9c7f648
PE
8545 * sysdep.c (sys_subshell): Likewise.
8546 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8547
6bd8c144
PE
8548 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8549 This should get cleaned up, so that child_setup has the
8550 same signature on all platforms.
8551
7710357c 8552 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8553 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8554
c59da222
CY
85552011-03-22 Chong Yidong <cyd@stupidchicken.com>
8556
8557 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8558 not to be necessary, and produces flickering.
8559
66b87493
GM
85602011-03-20 Glenn Morris <rgm@gnu.org>
8561
8562 * config.in: Remove file.
8563
45b6f6d5
JB
85642011-03-20 Juanma Barranquero <lekktu@gmail.com>
8565
8566 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8567 are now in src/globals.h.
8568 (syms_of_minibuf): Remove spurious & from previous change.
8569
cd394be1 85702011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8571
8572 * minibuf.c (completing-read-function): New variable.
8573 (completing-read-default): Rename from completing-read.
8574 (completing-read): Call completing-read-function.
8575
b14e3e21
CY
85762011-03-19 Juanma Barranquero <lekktu@gmail.com>
8577
8578 * xfaces.c (Fx_load_color_file):
8579 Read color file from absolute filename (bug#8250).
8580
f2b726e6
JB
85812011-03-19 Juanma Barranquero <lekktu@gmail.com>
8582
8583 * makefile.w32-in: Update dependencies.
8584
09f6ff02
EZ
85852011-03-17 Eli Zaretskii <eliz@gnu.org>
8586
8587 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8588
29a6015a
PE
85892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8590
a3a6c54e
PE
8591 Fix more problems found by GCC 4.5.2's static checks.
8592
b766f867
PE
8593 * process.c (make_serial_process_unwind, send_process_trap):
8594 (sigchld_handler): Now static.
8595
be02381c
PE
8596 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8597 That way, the code declares only the vars that it needs.
8598 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8599 * s/cygwin.h (PTY_ITERATION): Likewise.
8600 * s/darwin.h (PTY_ITERATION): Likewise.
8601 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8602
57048744
PE
8603 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8604 * process.c (allocate_pty): Don't declare stb unless it's needed.
8605
7914961c 8606 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8607 (CONSTANTLIM): Remove; unused.
8608 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8609 Define only if needed.
7914961c 8610
b3967b18
PE
8611 * unexelf.c (unexec): Name an expression,
8612 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8613 Use a different way to cause a compilation error if anyone uses
8614 n rather than nn, a way that does not involve shadowing.
73366a00 8615 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8616
29a6015a
PE
8617 * deps.mk (unexalpha.o): Remove; unused.
8618
43cfc33e 8619 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8620 * unexec.h: New file.
ce701a33
PE
8621 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8622 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8623 Depend on unexec.h.
8624 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8625 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8626 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8627 Change as necessary to match prototype in unexec.h.
ce701a33 8628
01f44d5a
PE
8629 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8630 shadowing.
4f63c6bb 8631 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8632
a6670b0b
PE
8633 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8634 Rename locals to avoid shadowing.
8635
cef2010d 8636 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8637 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8638
d4d7173a
PE
8639 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8640
f08b802a
PE
8641 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8642 warning when compiling print.c.
8643
3ddb0639
PE
8644 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8645 instead of using an uninitialized var.
5ad03b97 8646 (font_sort_entities): Mark var as initialized.
3ddb0639 8647
170a2692
PE
8648 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8649
e663c700
PE
8650 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8651 pointers to constants.
89bc529a 8652 (font_parse_fcname): Remove unused vars.
7b81e2d0 8653 (font_delete_unmatched): Now static.
ea838e10 8654 (font_get_spec): Remove; unused.
13a547c6
PE
8655 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8656 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8657 Rename or move locals to avoid shadowing.
e663c700 8658
2a80c887 8659 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8660 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8661
1384fa33 8662 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8663 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8664
8b2c52e9
PE
8665 * alloc.c (mark_backtrace): Move decl from here ...
8666 * lisp.h: ... to here, so that it can be checked.
8667
475545b5 8668 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8669 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8670 (lisp_indirect_variable): Name an expression,
8671 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8672 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8673
b1349114 8674 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8675 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8676 Use const pointer when appropriate.
b1349114 8677
a2928364
PE
8678 * lisp.h (get_system_name, get_operating_system_release):
8679 Move decls here, to check interfaces.
8680 * process.c (get_operating_system_release): Move decl to lisp.h.
8681 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8682 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8683 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8684 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8685 (Fformat_time_string, Fencode_time, Finsert_char):
8686 (Ftranslate_region_internal, Fformat):
8687 Rename or remove local vars to avoid shadowing.
9710023e 8688 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8689
a415e694
PE
8690 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8691 avoid shadowing.
8692
8ef4622d
PE
8693 * lisp.h (eassert): Check that the argument compiles, even if
8694 ENABLE_CHECKING is not defined.
8695
946f9a5b
PE
8696 * data.c (Findirect_variable): Name an expression, to avoid
8697 gcc -Wbad-function-cast warning.
112396d6 8698 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8699 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8700 (Fmake_variable_buffer_local, Fmake_local_variable):
8701 Mark variables as initialized.
52746918 8702 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8703
e5aab7e7 8704 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8705 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8706 Rename locals to avoid shadowing.
dff45157
PE
8707 (mark_stack): Move local variables into the #ifdef region where
8708 they're used.
7bc26fdb
PE
8709 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8710 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8711 needed otherwise.
8712 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8713 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8714 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8715
e5aab7e7
PE
8716 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8717 avoids undefined behavior in theory.
8718
4da60324
PE
8719 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8720
88043301
PE
8721 Use functions, not macros, for up- and down-casing (Bug#8254).
8722 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8723 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8724 to use the following functions instead of these macros.
8725 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8726 EMACS_INT, since callers assume the returned value fits in int.
8727 (upcase1): Likewise, for UPCASE_TABLE.
8728 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8729 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8730 the race-condition problem in the old DOWNCASE.
88043301 8731
19ed5445
PE
8732 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8733 Rename locals to avoid shadowing.
8734 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8735 (regex_compile, re_search_2, re_match_2_internal):
8736 Remove unused local vars.
952db0d7
PE
8737 (FREE_VAR): Rewrite so as not to use empty "else",
8738 which gcc can warn about.
da053e48 8739 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8740 (RETALLOC_IF): Define only if needed.
8741 (WORDCHAR_P): Likewise. This one is never needed, but is used
8742 only in a comment talking about a compiler bug, so put inside
8743 the #if 0 of that comment.
8744 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8745 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8746 Remove; unused.
19ed5445 8747
1f3561e4 8748 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8749 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8750 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8751
ded6f8f7
PE
8752 * search.c (simple_search): Remove unused var.
8753
dbd37a95
PE
8754 * dired.c (compile_pattern): Move decl from here ...
8755 * lisp.h: ... to here, so that it can be checked.
8756 (struct re_registers): New forward decl.
8757
7e47afad
PE
8758 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8759
85f24f61
PE
8760 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8761 All uses changed.
8762 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8763 Rename locals to avoid shadowing.
5671df8f 8764 (Fvertical_motion): Mark locals as initialized.
85f24f61 8765
181aa2be 8766 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8767 (casify_region): Mark local as initialized.
181aa2be 8768
930d429c
PE
8769 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8770
7082eac6
PE
8771 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8772 New macros, so that the caller can use some names other than
8773 gcpro1, gcpro2, etc.
8774 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8775 of the new macros.
8776 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8777 argument, for consistency with GCPRO2_VAR, etc: it is now the
8778 prefix of the variable, not the variable itself. All uses
8779 changed.
38b2c076
PE
8780 * dired.c (directory_files_internal, file_name_completion):
8781 Rename locals to avoid shadowing.
8782
15206ed9
PE
8783 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8784 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8785 dired.c's scmp function, had undefined behavior.
8786 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8787 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8788 * buffer.h: ... to here, because these macros use current_buffer,
8789 and the new implementation with inline functions needs to have
8790 current_buffer in scope now, rather than later when the macros
8791 are used.
8792 (downcase, upcase1): New static inline functions.
8793 (DOWNCASE, UPCASE1): Reimplement using these functions.
8794 This avoids undefined behavior in expressions like
8795 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8796 from race conditions in accessing the global variables
8797 case_temp1 and case_temp2.
8798 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8799 * lisp.h (case_temp1, case_temp2): Remove their decls.
8800 * character.h (ASCII_CHAR_P): Move from here ...
8801 * lisp.h: ... to here, so that the inline functions mentioned
8802 above can use them.
8803
4a6bea26
PE
8804 * dired.c (directory_files_internal_unwind): Now static.
8805
f14b7e14
PE
8806 * fileio.c (file_name_as_directory, directory_file_name):
8807 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8808 Now static.
2893f146
PE
8809 (file_name_as_directory): Use const pointers when appropriate.
8810 (Fexpand_file_name): Likewise. In particular, newdir might
8811 point at constant storage, so make it a const pointer.
fd4ead52 8812 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8813 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8814 signedness issues.
f839df0c
PE
8815 (Fset_file_times, Finsert_file_contents, auto_save_error):
8816 Rename locals to avoid shadowing.
f14b7e14 8817
5716756e 8818 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8819 (Ftry_completion, Fall_completions): Rename or remove locals
8820 to avoid shadowing.
5716756e 8821
b4c3046a
PE
8822 * marker.c (bytepos_to_charpos): Remove; unused.
8823
b45db522
PE
8824 * lisp.h (verify_bytepos, count_markers): New decls,
8825 so that gcc does not warn that these functions aren't declared.
8826
85876d07
PE
8827 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8828 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8829 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8830 (copy_text): Remove unused local var.
85876d07 8831
03d78a21 8832 * filelock.c (within_one_second): Now static.
b3dd38ab 8833 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8834
5df8f01b
PE
8835 * buffer.c (fix_overlays_before): Mark locals as initialized.
8836 (fix_start_end_in_overlays): Likewise. This function should be
8837 simplified by using pointers-to-pointers, but that's a different
8838 matter.
b1d876f1 8839 (switch_to_buffer_1): Now static.
8f54f30a
PE
8840 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8841 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8842
a70072c9 8843 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8844 Fix pointer signedness issue.
edced198
PE
8845 (sys_subshell): Mark local as volatile if checking for lint,
8846 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8847 (MAXPATHLEN): Define only if needed.
a70072c9 8848
a0977c44
PE
8849 * process.c (serial_open, serial_configure): Move decls from here ...
8850 * systty.h: ... to here, so that they can be checked.
8851
a884fdcc
PE
8852 * fns.c (get_random, seed_random): Move extern decls from here ...
8853 * lisp.h: ... to here, so that they can be checked.
8854
604efe86 8855 * sysdep.c (reset_io): Now static.
b8950c94 8856 (wait_for_termination_signal): Remove; unused.
604efe86 8857
38fc62d9
PE
8858 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8859 (copy_keymap_item, append_key, push_text_char_description):
8860 Now static.
1004a21a 8861 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8862 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8863 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8864 (describe_map_tree):
8865 Rename locals to avoid shadowing.
38fc62d9 8866
2f2650da
PE
8867 * keyboard.c: Declare functions static if they are not used elsewhere.
8868 (echo_char, echo_dash, cmd_error, top_level_2):
8869 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8870 (read_char, kbd_buffer_get_event, make_lispy_position):
8871 (make_lispy_event, make_lispy_movement, apply_modifiers):
8872 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8873 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8874 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8875 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8876 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8877
a053e86c 8878 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8879 (mark_kboards): Move decl here ...
8880 * alloc.c (mark_kboards): ... from here.
a053e86c 8881
4752793e
PE
8882 * lisp.h (force_auto_save_soon): New decl.
8883
74f10ca7 8884 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8885 (DEFINE_DUMMY_FUNCTION): New macro.
8886 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8887 Use it.
c03cd23f
PE
8888 (main): Add casts to avoid warnings
8889 if GCC considers string literals to be constants.
74f10ca7 8890
022e70d4
PE
8891 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8892
59d6fe83
PE
8893 * dbusbind.c: Pointer signedness fixes.
8894 (xd_signature, xd_append_arg, xd_initialize):
8895 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8896 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8897 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8898 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8899
78320123
PE
8900 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8901 if GCC considers string literals to be constants.
49cebcca 8902 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8903
35ac2a97
SM
89042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8905
fb103ca9
SM
8906 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8907 (print_preprocess, print_object): New macro to fix last change.
8908
35ac2a97
SM
8909 * print.c (print_preprocess): Don't forget font objects.
8910
62973b41
JB
89112011-03-16 Juanma Barranquero <lekktu@gmail.com>
8912
8913 * emacs.c (USAGE3): Doc fixes.
8914
0e48bb22
AS
89152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8916
8917 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8918 structure.
8919
7684e57b
JB
89202011-03-14 Juanma Barranquero <lekktu@gmail.com>
8921
8922 * lisp.h (VWindow_system, Qfile_name_history):
8923 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8924 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8925 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8926
8927 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8928 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8929
8930 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8931 * w32console.c (detect_input_pending, read_input_pending)
8932 (encode_terminal_code):
8933 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8934 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8935 (w32_system_caret_y, Qfile_name_history):
8936 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8937 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8938 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8939 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8940 * w32proc.c (Qlocal, report_file_error):
8941 * w32term.c (Vwindow_system, updating_frame):
8942 * w32uniscribe.c (initialized, uniscribe_font_driver):
8943 Remove unneeded extern declarations.
8944
2aa46d6c
CY
89452011-03-14 Chong Yidong <cyd@stupidchicken.com>
8946
c96bbc66 8947 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8948
cffc6f3b
CY
89492011-03-13 Chong Yidong <cyd@stupidchicken.com>
8950
8951 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8952 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8953 These macros can no longer be used for assignment.
8954
44f230aa
SM
8955 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8956 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8957 (record_buffer_markers, fetch_buffer_markers): New functions for
8958 recording and fetching special buffer markers.
8959 (set_buffer_internal_1, set_buffer_temp): Use them.
8960
8961 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8962
8963 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8964
8965 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8966 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8967
8968 * xdisp.c (hscroll_window_tree):
8969 (reconsider_clip_changes): Use PT instead of BUF_PT.
8970
d251f04b
EZ
89712011-03-13 Eli Zaretskii <eliz@gnu.org>
8972
8973 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8974 $(EMACS_ROOT)/lib/intprops.h.
8975
f0c77cd1
PE
89762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8977
3eca4629
PE
8978 Fix more problems found by GCC 4.5.2's static checks.
8979
7c86ee98
PE
8980 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8981 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8982 (xg_free_frame_widgets): Make it clear that a local variable is
8983 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8984 (gdk_window_get_screen): Make it clear that this macro is needed
8985 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8986 (int_gtk_range_get_value): New function, which avoids a diagnostic
8987 from gcc -Wbad-function-cast.
8988 (xg_set_toolkit_scroll_bar_thumb): Use it.
8989 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8990 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8991 (get_utf8_string, xg_get_file_with_chooser):
8992 Rename locals to avoid shadowing.
8993 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8994
41729b81
PE
8995 * xgselect.c (xg_select): Remove unused var.
8996
f0c77cd1
PE
8997 * image.c (four_corners_best): Mark locals as initialized.
8998 (gif_load): Initialize transparent_p to zero (Bug#8238).
8999 Mark another local as initialized.
ec6cf4c6 9000 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9001
ce0ad53d 9002 * image.c (clear_image_cache): Now static.
d5d5a617 9003 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9004 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9005 (x_edge_detection): Remove unnecessary cast that
9006 gcc -Wbad-function-cast diagnoses.
2037898d 9007 (gif_load): Fix pointer signedness.
6ae141d6
PE
9008 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9009 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9010
33383987 90112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9012
d32df629
PE
9013 Improve quality of tests for time stamp overflow.
9014 For example, without this patch (encode-time 0 0 0 1 1
9015 1152921504606846976) returns the obviously-bogus value (-948597
9016 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9017 reports time overflow. See
9018 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9019 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9020 * editfns.c: Include limits.h and intprops.h.
9021 (TIME_T_MIN, TIME_T_MAX): New macros.
9022 (time_overflow): Move earlier, to before first use.
9023 (hi_time, lo_time): New functions, for an accurate test for
9024 out-of-range times.
9025 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9026 (Fget_internal_run_time): Don't assume time_t fits in int.
9027 (make_time): Use list2 instead of Fcons twice.
9028 (Fdecode_time): More accurate test for out-of-range times.
9029 (check_tm_member): New function.
9030 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9031 (lisp_time_argument): Don't rely on undefined left-shift and
9032 right-shift behavior when checking for time stamp overflow.
8be6f318 9033
fe31d94c
PE
9034 * editfns.c (time_overflow): New function, refactoring common code.
9035 (Fformat_time_string, Fdecode_time, Fencode_time):
9036 (Fcurrent_time_string): Use it.
9037
8be6f318
PE
9038 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9039 * dired.c (make_time): Move to ...
9040 * editfns.c (make_time): ... here.
9041 * systime.h: Note the move.
9042
09d9db2c 90432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9044
126bc0dc
YM
9045 * fringe.c (update_window_fringes): Remove unused variables.
9046
c47cbdfd
YM
9047 * unexmacosx.c (copy_data_segment): Also copy __got section.
9048 (Bug#8223)
9049
7ac80be9
EZ
90502011-03-12 Eli Zaretskii <eliz@gnu.org>
9051
c96bbc66 9052 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9053 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9054 Constify `char *' arguments and their references according to
9055 prototypes in tparam.h.
9056
ecb0f94d 9057 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9058
7ac80be9
EZ
9059 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9060 Adapt all references accordingly.
9061
9062 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9063
ef1fd07e
TT
90642011-03-11 Tom Tromey <tromey@redhat.com>
9065
9066 * buffer.c (syms_of_buffer): Remove obsolete comment.
9067
7ef4b50c
EZ
90682011-03-11 Eli Zaretskii <eliz@gnu.org>
9069
9070 * termhooks.h (encode_terminal_code): Declare prototype.
9071
9072 * msdos.c (encode_terminal_code): Don't declare prototype.
9073
9074 * term.c (encode_terminal_code): Now external again, used by
9075 w32console.c and msdos.c.
9076
44f230aa
SM
9077 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9078 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9079
4b1ec863 90802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9081
1714f52b 9082 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9083
4b1ec863
PE
9084 * fringe.c (update_window_fringes): Mark locals as initialized
9085 (Bug#8227).
9086 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9087
524c7aa6
PE
9088 * alloc.c (mark_fringe_data): Move decl from here ...
9089 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9090 to check its interface.
9091 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9092
a5c0af81 9093 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9094 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9095 (fontset_font): Mark local as initialized.
a9a06e0b 9096 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9097
b4716021
PE
9098 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9099
811e9bac 9100 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9101 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9102 (x_own_selection, Fx_disown_selection_internal): Rename locals
9103 to avoid shadowing.
9104 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9105
7e3ab302
PE
9106 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9107 so that the caller can use some name other than gcpro1.
9108 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9109 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9110 (Fx_backspace_delete_keys_p):
9111 Use them to avoid shadowing, and rename vars to avoid shadowing.
9112 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9113 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9114 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9115 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9116 Remove unused locals.
7e3ab302
PE
9117 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9118 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9119 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9120 macros.
f78faa98 9121
e2b13473
PE
9122 * xterm.h (x_mouse_leave): New decl.
9123
77f23912
PE
9124 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9125 Remove unused functions.
cdf4ba58
PE
9126 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9127 (x_calc_absolute_position): Now static.
7411c686 9128 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9129 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9130 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9131 unless they are used.
38d0b34a
PE
9132 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9133 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9134 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9135 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9136 (x_error_catcher, x_connection_closed, x_error_handler):
9137 (x_error_quitter, xembed_send_message, x_iconify_frame):
9138 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9139 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9140 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9141
44f230aa
SM
9142 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9143 Rename or move locals to avoid shadowing.
6b463e58 9144 (tty_defined_color, merge_face_heights): Now static.
5967d051 9145 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9146 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9147 does not deduce is never used uninitialized.
73719eba
PE
9148 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9149 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9150
426994c3 9151 * terminal.c (store_terminal_param): Now static.
5489860b 9152
032f1620 9153 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9154 (set_frame_menubar): Remove unused local.
d4323972 9155 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9156 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9157 since they might point to immutable storage.
281585b0
PE
9158 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9159 since it's unused otherwise.
032f1620 9160
367c19e5 9161 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9162 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9163 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9164 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9165 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9166 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9167 does not deduce are never used uninitialized.
70739cbe 9168
07b48fa9
PE
9169 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9170
8868a238 9171 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9172 * window.c (window_loop, size_window):
9173 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9174
7e5cf297 9175 * window.c (display_buffer): Now static.
d6550a9f
PE
9176 (size_window): Mark variables that gcc -Wuninitialized
9177 does not deduce are never used uninitialized.
a586633d
PE
9178 * window.h (check_all_windows): New decl, to forestall
9179 gcc -Wmissing-prototypes diagnostic.
5b555da1 9180 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9181
f6095868
PE
9182 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9183 shadowing.
9184 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9185 Include <limits.h>.
9186 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9187 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9188 (load_charset_map): Mark variables that gcc -Wuninitialized
9189 does not deduce are never used uninitialized.
53df7c11 9190 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9191
f38b440c
PE
9192 * coding.c (coding_set_source, coding_set_destination):
9193 Use "else { /* comment */ }" rather than "else /* comment */;"
9194 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9195 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9196 a block, when the outer 'i' will do.
9197 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9198 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9199 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9200 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9201 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9202 Rename locals to avoid shadowing.
9203 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9204 * coding.c (emacs_mule_char, encode_invocation_designation):
9205 Now static, since they're not used elsewhere.
413bb2db 9206 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9207 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9208 (decode_coding_emacs_mule): Mark variables that gcc
9209 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9210 (detect_coding_iso_2022): Initialize a local variable that might
9211 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9212 this initialization is needed. (Bug#8211)
5f58e762
PE
9213 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9214 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9215 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9216 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9217 Remove unused macros.
f38b440c 9218
232b38b9 9219 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9220 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9221 * character.c (string_count_byte8): Likewise.
232b38b9 9222
fb90da1b
PE
9223 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9224 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9225
fb93dbc2
PE
9226 * chartab.c (copy_sub_char_table): Now static, since it's not used
9227 elsewhere.
5c156ace
PE
9228 (sub_char_table_ref_and_range, char_table_ref_and_range):
9229 Rename locals to avoid shadowing.
bbcd0949 9230 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9231
7d3b3862 9232 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9233 (BIDI_BOB): Remove unused macro.
7d3b3862 9234
6be7d3da
PE
9235 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9236 deduce are never used uninitialized.
c2ed9c8b 9237 * term.c (encode_terminal_code): Likewise.
6be7d3da 9238
75f8807f 9239 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9240
50938595
PE
9241 * tparam.h: New file.
9242 * term.c, tparam.h: Include it.
9243 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9244 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9245 Move these decls to tparam.h, and make them agree with what
9246 is actually in tparam.c. The previous trick of using incompatible
9247 decls in different modules does not conform to the C standard.
9248 All callers of tparam changed to use tparam's actual API.
9249 * tparam.c (tparam1, tparam, tgoto):
9250 Use const pointers where appropriate.
9251
fbceeba2
PE
9252 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9253 * cm.h (struct cm): Likewise.
9254 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9255 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9256 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9257 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9258 (turn_on_face, init_tty): Likewise.
9259 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9260
7f3f1250
PE
9261 * term.c (term_mouse_position): Rename local to avoid shadowing.
9262
e6ca6543
PE
9263 * alloc.c (mark_ttys): Move decl from here ...
9264 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9265
c40f8d15
AS
92662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9267
9268 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9269
cfe0661d
JB
92702011-03-09 Juanma Barranquero <lekktu@gmail.com>
9271
9272 * search.c (compile_pattern_1): Remove argument regp, unused since
9273 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9274 (compile_pattern): Don't pass it.
9275
0afb4571
J
92762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9277
9278 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9279 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9280 for ! HAVE_GTK3.
9281 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9282
9283 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9284
9285 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9286 gdk_window_get_screen, gdk_window_get_geometry,
9287 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9288 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9289 (xg_get_pixbuf_from_pixmap): New function.
9290 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9291 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9292 Call xg_get_pixbuf_from_pixmap instead of
9293 gdk_pixbuf_get_from_drawable.
9294 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9295 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9296 (xg_check_special_colors): Use GtkStyleContext and its functions
9297 for HAVE_GTK3.
9298 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9299 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9300 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9301 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9302 Call gtk_widget_get_preferred_size.
0afb4571
J
9303 (xg_frame_resized): gdk_window_get_geometry only takes 5
9304 parameters.
44f230aa
SM
9305 (xg_win_to_widget, xg_event_is_for_menubar):
9306 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9307 (xg_set_widget_bg): New function.
9308 (delete_cb): New function.
895009e1 9309 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9310 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9311 (xg_set_background_color): Call xg_set_widget_bg.
9312 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9313 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9314 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9315 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9316 if ! HAVE_GTK3.
9317 (update_frame_tool_bar): Call gtk_widget_hide.
9318 (xg_initialize): Use GDK_KEY_g.
9319
9320 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9321 if ! HAVE_GTK3
9322 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9323
9324 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9325 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9326 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9327
1c2cc4ef
JB
93282011-03-08 Juanma Barranquero <lekktu@gmail.com>
9329
9330 * w32xfns.c (select_palette): Check success of RealizePalette against
9331 GDI_ERROR, not zero.
9332
33383987 9333See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9334
9335;; Local Variables:
9336;; coding: utf-8
aac0c6e3
MR
9337;; End:
9338
acaf905b 9339 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9340
9341 This file is part of GNU Emacs.
9342
9343 GNU Emacs is free software: you can redistribute it and/or modify
9344 it under the terms of the GNU General Public License as published by
9345 the Free Software Foundation, either version 3 of the License, or
9346 (at your option) any later version.
9347
9348 GNU Emacs is distributed in the hope that it will be useful,
9349 but WITHOUT ANY WARRANTY; without even the implied warranty of
9350 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9351 GNU General Public License for more details.
9352
9353 You should have received a copy of the GNU General Public License
9354 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.