merge trunk
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a28d4396
KH
12011-05-18 Kenichi Handa <handa@m17n.org>
2
3 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5 (find_automatic_composition): Mostly rewrite for efficiency.
6
a2b1fa8e
JB
72011-05-18 Juanma Barranquero <lekktu@gmail.com>
8
9 * makefile.w32-in: Update dependencies.
10
8e1f5610
CS
112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12
13 * menu.c: Include limits.h (fixes the MS-Windows build broken by
14 revision 104625).
15
7025ee00 162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 17
cdfa6eab
PE
18 Fix some integer overflow issues, such as string length overflow.
19
06d6db33
PE
20 * insdel.c (count_size_as_multibyte): Check for string overflow.
21
2b4560a8
PE
22 * character.c (lisp_string_width): Check for string overflow.
23 Use EMACS_INT, not int, for string indexes and lengths; in
24 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
25 the resulting string length overflows an EMACS_INT; instead,
26 report a string overflow if no precision given. When checking for
27 precision exhaustion, use a check that cannot possibly have
28 integer overflow. (Bug#8675)
29 * character.h (lisp_string_width): Adjust to new signature.
30
cb93f9be
PE
31 * alloc.c (string_overflow): New function.
32 (Fmake_string): Use it. This doesn't change behavior, but saves
33 a few bytes and will simplify future changes.
34 * character.c (string_escape_byte8): Likewise.
35 * lisp.h (string_overflow): New decl.
36
1a1f3366
PE
37 Fixups, following up to the user-interface timestamp change.
38 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
39 for UI timestamps, instead of unsigned long.
9fbd6841
PE
40 * msdos.c (mouse_get_pos): Likewise.
41 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
42 * w32gui.h (Time): Define by including "systime.h" rather than by
43 declaring it ourselves. (Bug#8664)
44
d4e3e4d3
PE
45 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
46 * image.c (clear_image_cache): Likewise.
47
f6a24d19
PE
48 * term.c (term_mouse_position): Don't assume time_t wraparound.
49
08dc5ae6
PE
50 Be more systematic about user-interface timestamps.
51 Before, the code sometimes used 'Time', sometimes 'unsigned long',
52 and sometimes 'EMACS_UINT', to represent these timestamps. This
53 change causes it to use 'Time' uniformly, as that's what X uses.
54 This makes the code easier to follow, and makes it easier to catch
55 integer overflow bugs such as Bug#8664.
56 * frame.c (Fmouse_position, Fmouse_pixel_position):
57 Use Time, not unsigned long, for user-interface timestamps.
58 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
59 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
60 * keyboard.h (last_event_timestamp): Likewise.
61 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
62 * menu.h (xmenu_show): Likewise.
63 * term.c (term_mouse_position): Likewise.
64 * termhooks.h (struct input_event.timestamp): Likewise.
65 (struct terminal.mouse_position_hook): Likewise.
66 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
67 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
68 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
69 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
70 what it was before.
71 * menu.h, termhooks.h: Include "systime.h", for Time.
72
8e55734a
PE
73 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
74 Don't assume that the difference between two unsigned long values
75 can fit into an integer. At this point, we know button_down_time
76 <= event->timestamp, so the difference must be nonnegative, so
77 there's no need to cast the result if double-click-time is
78 nonnegative, as it should be; check that it's nonnegative, just in
79 case. This bug is triggered when events are more than 2**31 ms
86db42d2 80 apart (about 25 days). (Bug#8664)
8e55734a 81
841f1b75 82 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 83 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 84
3e26f69c
PE
85 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
86 that always fit in int. Use a sentinel instead of a counter, to
87 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
88 * frame.h (struct frame): Use int for menu_bar_items_used
89 instead of EMACS_INT, since it always fits in int.
3e26f69c 90
5cc152c0
PE
91 * menu.c (grow_menu_items): Check for int overflow.
92
d89eb65e
PE
93 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
94
5235bd3e
PE
95 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
96 Before, the code was not consistent. These values cannot exceed
97 2**31 - 1 so there's no need to make them unsigned.
98 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
99 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
100 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
101 as modifiers.
102 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
103
bc827e23
PE
104 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
105 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
106 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
107 presumably because the widths might not match.
108
78eb494e
PE
109 * window.c (size_window): Avoid needless test at loop start.
110
04f2d78b
CB
1112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
112
113 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
114
d2fc7e3d 1152011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
116
117 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
118
d2fc7e3d 1192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
120
121 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
122 `width' to `bar_area_x' and `bar_area_width', respectively.
123 (x_scroll_run): Take account of fringe background extension.
124
04f2d78b
CB
125 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
126 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
127 `bar_area_width', respectively.
128 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
129 background extension.
130
79b70037
GM
1312011-05-10 Jim Meyering <meyering@redhat.com>
132
133 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
134
2f142cc5
JB
1352011-05-10 Juanma Barranquero <lekktu@gmail.com>
136
137 * image.c (Finit_image_library): Return t for built-in image types,
138 like pbm and xbm. (Bug#8640)
139
57679c86
AS
1402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
141
142 * w32menu.c (set_frame_menubar): Fix submenu allocation.
143
888c9e86
EZ
1442011-05-07 Eli Zaretskii <eliz@gnu.org>
145
b0512a1d
EZ
146 * w32console.c (Fset_screen_color): Doc fix.
147 (Fget_screen_color): New function.
148 (syms_of_ntterm): Defsubr it.
149
888c9e86
EZ
150 * callproc.c (call_process_cleanup): Don't close and unlink the
151 temporary file if Fcall_process didn't create it in the first
152 place.
153 (Fcall_process): Don't create tempfile if stdout of the child
154 process will be redirected to a file specified with `:file'.
155 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
156 cue to call_process_cleanup not to close that handle.
157
4d3fcc8e
BK
1582011-05-07 Ben Key <bkey76@gmail.com>
159
160 * makefile.w32-in: The bootstrap-temacs rule now makes use of
161 one of two shell specific rules, either bootstrap-temacs-CMD or
162 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
163 to the previous implementation of the bootstrap-temacs rule.
164 The bootstrap-temacs-CMD rule is similar to the previous
165 implementation of the bootstrap-temacs rule except that it
166 makes use of the ESC_CFLAGS variable instead of the CFLAGS
167 variable.
168
169 These changes, along with some changes to nt/configure.bat,
170 nt/gmake.defs, and nt/nmake.defs, are required to extend my
171 earlier fix to add support for --cflags and --ldflags options
172 that include quotes so that it works whether make uses cmd or
173 sh as the shell.
174
b4289b64
MA
1752011-05-06 Michael Albinus <michael.albinus@gmx.de>
176
177 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
178 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
179 is a constant.
180 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
181 a string. Handle both cases.
182 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
183 (Fdbus_register_method): Use Qinvalid_function.
184
af4c0e28
JB
1852011-05-06 Juanma Barranquero <lekktu@gmail.com>
186
187 * makefile.w32-in: Update dependencies.
188 (LISP_H): Add inttypes.h and stdin.h.
189 (PROCESS_H): Add unistd.h.
190
c51453d9
EZ
1912011-05-06 Eli Zaretskii <eliz@gnu.org>
192
193 * lread.c: Include limits.h (fixes the MS-Windows build broken by
194 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
195
8ff0ac3c 1962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 197
4c4b566b
PE
198 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
199
aab2b9b5
PE
200 * term.c (vfatal): Remove stray call to va_end.
201 It's not needed and the C Standard doesn't allow it here anyway.
202
c378da0b
PE
203 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
204 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
205
288b08c7
PE
206 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
207 bytes.
208
e3601888
PE
209 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
210
db6c0e74
PE
211 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
212
dd5963ea
PE
213 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
214
88c9450f
PE
215 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
216
2f9442b8
PE
217 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
218
c032b5f8
PE
219 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
220 * charset.c (Fdefine_charset_internal): Don't initialize
221 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 222 32-bit int (Bug#8600).
a108c10b
PE
223
224 * lread.c (read_integer): Be more consistent with string-to-number.
225 Use string_to_number to do the actual conversion; this avoids
226 rounding errors and fixes some other screwups. Without this fix,
227 for example, #x1fffffffffffffff was misread as -2305843009213693952.
228 (digit_to_number): Move earlier, for benefit of read_integer.
229 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 230 not a digit in any supported base. (Bug#8602)
a108c10b 231
ad5f9eea
PE
232 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
233
aec1708a
PE
234 * dispnew.c (scrolling_window): Return 1 if we scrolled,
235 to match comment at start of function. This also removes a
236 GCC warning about overflow in a 32+64-bit port.
237
47be4ab5
PE
238 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
239
371cac43
PE
240 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
241 Reported by Stefan Monnier in
242 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
243 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
244 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 245
d01a7826
PE
246 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
247 (EMACS_UINTPTR): Likewise, with uintptr_t.
248
7fd47d5c
PE
249 * lisp.h: Prefer 64-bit EMACS_INT if available.
250 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
251 on 32-bit hosts that have 64-bit int, so that they can access
252 large files.
122b0c86
PE
253 However, temporarily disable this change unless the temporary
254 symbol WIDE_EMACS_INT is defined.
7fd47d5c 255
8727937b
PE
256 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
257
8ac068ac
PE
258 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
259 This removes an assumption that EMACS_INT and long are the same
260 width as pointers. The assumption is true for Emacs porting targets
261 now, but we want to make other targets possible.
262 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
263 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
264 In the rest of the code, change types of integers that hold casted
265 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
266 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
267 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
268 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
269 No need to cast type when ORing.
270 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
271 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
272 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
273 assume EMACS_INT is the same width as char *.
274 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
275 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
276 Remove no-longer-needed casts.
277 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
278 (xg_tool_bar_help_callback, xg_make_tool_item):
279 Use EMACS_INTPTR to hold an integer
280 that will be cast to void *; this can avoid a GCC warning
281 if EMACS_INT is not the same width as void *.
282 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
283 * xdisp.c (display_echo_area_1, resize_mini_window_1):
284 (current_message_1, set_message_1):
285 Use a local to convert to proper width without a cast.
286 * xmenu.c (dialog_selection_callback): Likewise.
287
ede49d71
PE
288 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
289 Also, don't assume VALBITS / RAND_BITS is less than 5,
290 and don't rely on undefined behavior when shifting a 1 left into
291 the sign bit.
292 * lisp.h (get_random): Change signature to match.
293
2f30ecd0
PE
294 * lread.c (hash_string): Use size_t, not int, for hash computation.
295 Normally we prefer signed values; but hashing is special, because
296 it's better to use unsigned division on hash table sizes so that
297 the remainder is nonnegative. Also, size_t is the natural width
298 for hashing into memory. The previous code used 'int', which doesn't
299 retain enough info to hash well into very large tables.
300 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
301
2a866e7b
PE
302 * dbusbind.c: Don't possibly lose pointer info when converting.
303 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
304 Use XPNTR rather than XHASH, so that the high-order bits of
305 the pointer aren't lost when converting through void *.
306
51639eac
PE
307 * eval.c (Fautoload): Don't double-shift a pointer.
308
92394119
PE
309 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
310
dbdb9a7c
JB
3112011-05-06 Juanma Barranquero <lekktu@gmail.com>
312
313 * gnutls.c (DEF_GNUTLS_FN):
314 * image.c (DEF_IMGLIB_FN): Make function pointers static.
315
db7a0b4f
AS
3162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
317
318 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
319 marker. (Bug#8610)
320
f7ff1b0f 3212011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
322
323 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
324 New version that can reserve upto 2GB of heap space.
325
f7ff1b0f 3262011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
327
328 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
329
639c109b
TZ
3302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
331
332 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
333 `gnutls_certificate_set_x509_key_file'.
334
d2127135
JB
3352011-05-05 Juanma Barranquero <lekktu@gmail.com>
336
337 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
338 Update dependencies.
339
e968f4f3
JB
3402011-05-04 Juanma Barranquero <lekktu@gmail.com>
341
342 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
343 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
344 Remove unused parameter `fildes'.
345 * process.c (read_process_output, send_process): Don't pass it.
346
84d358f0
JB
3472011-05-04 Juanma Barranquero <lekktu@gmail.com>
348
349 Fix previous change: the library cache is defined in w32.c.
350 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
351 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
352
0898ca10
JB
3532011-05-04 Juanma Barranquero <lekktu@gmail.com>
354
355 Implement dynamic loading of GnuTLS on Windows.
356
357 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
358 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
359 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
360 Declare.
361
362 * gnutls.c (Qgnutls_dll): Define.
363 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
364 (gnutls_*): Declare function pointers.
365 (init_gnutls_functions): New function to initialize function pointers.
366 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
367 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
368 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
369 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
370 (emacs_gnutls_write, emacs_gnutls_read)
371 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
372 (Fgnutls_available_p): New function.
373 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
374 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
375 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
376
377 * image.c: Include w32.h.
378 (Vimage_type_cache): Delete.
379 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
380 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
381 (w32_delayed_load): Move to w32.c.
382
383 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
384
385 * w32.c (QCloaded_from, Vlibrary_cache): Define.
386 (w32_delayed_load): Move from image.c. When loading a library, record
387 its filename in the :loaded-from property of the library id.
388 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
389 Initialize and staticpro them.
390 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
391
392 * process.c: Include lisp.h before w32.h, not after.
393 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
394 instead of gnutls_record_check_pending.
395
396 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
397
ff4de4aa
TZ
3982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
399
400 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
401 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
402 as passed in.
403
abe95abb
JD
4042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
405
406 * xterm.c (x_set_frame_alpha): Do not set property on anything
407 else than FRAME_X_OUTER_WINDOW (Bug#8608).
408
e16e55d4
JB
4092011-05-02 Juanma Barranquero <lekktu@gmail.com>
410
411 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
412
bafcf6a5
JB
4132011-05-02 Juanma Barranquero <lekktu@gmail.com>
414
415 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
416 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
417 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
418 (gnutls_global_initialized, Qgnutls_bootprop_priority)
419 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
420 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
421 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
422 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
423 (Qgnutls_bootprop_callbacks_verify): Make static.
424
e7a6747f
AS
4252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
426
19ed11ba
AS
427 * callproc.c: Indentation fixup.
428
e7a6747f 429 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
430 (wait_for_termination, interruptible_wait_for_termination):
431 Move after wait_for_termination_1.
e7a6747f 432
1ef14cb4
LMI
4332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
434
435 * sysdep.c (interruptible_wait_for_termination): New function
436 which is like wait_for_termination, but allows keyboard
437 interruptions.
438
439 * callproc.c (Fcall_process): Add (:file "file") as an option for
440 the STDOUT buffer.
441 (Fcall_process_region): Ditto.
442
330d880c
EZ
4432011-04-30 Eli Zaretskii <eliz@gnu.org>
444
8db90b73
EZ
445 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
446 rather than `XVECTOR (FOO)->size'.
447
330d880c
EZ
448 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
449 inttypes.h, as a gnulib replacement is used if it not available in
450 system headers.
451
15cbd324
EZ
4522011-04-21 Eli Zaretskii <eliz@gnu.org>
453
454 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
455 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
456 of MOST_POSITIVE_FIXNUM. (Bug#8528)
457
458 * coding.c (coding_alloc_by_realloc): Error out if destination
459 will grow beyond MOST_POSITIVE_FIXNUM.
460 (decode_coding_emacs_mule): Abort if there isn't enough place in
461 charbuf for the composition carryover bytes. Reserve an extra
462 space for up to 2 characters produced in a loop.
463 (decode_coding_iso_2022): Abort if there isn't enough place in
464 charbuf for the composition carryover bytes.
465
4662011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 467
ae940cca
EZ
468 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
469 aborting when %lld or %lll format is passed.
470 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
471 %llo or %llx format is passed. (Bug#8545)
472
03ab8921
EZ
473 * window.c (window_scroll_line_based): Use a marker instead of
474 simple variables to record original value of point. (Bug#7952)
475
afda1437
EZ
476 * doprnt.c (doprnt): Fix the case where a multibyte sequence
477 produced by %s or %c overflows available buffer space. (Bug#8545)
478
f76dee0c
PE
4792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
480
481 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 482 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 483
fdc5744d
JB
4842011-04-28 Juanma Barranquero <lekktu@gmail.com>
485
486 * w32.c (init_environment): Warn about defaulting HOME to C:\.
487
638f053a
JB
4882011-04-28 Juanma Barranquero <lekktu@gmail.com>
489
490 * keyboard.c (Qdelayed_warnings_hook): Define.
491 (command_loop_1): Run `delayed-warnings-hook'
492 if Vdelayed_warnings_list is non-nil.
493 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
494 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
495
d178f871
EZ
4962011-04-28 Eli Zaretskii <eliz@gnu.org>
497
498 * doprnt.c (doprnt): Don't return value smaller than the buffer
499 size if the message was truncated. (Bug#8545).
500
b124fd93
JB
5012011-04-28 Juanma Barranquero <lekktu@gmail.com>
502
503 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
504 (Fx_window_property): #if-0 the whole functions, not just the bodies.
505
e810457d
PE
5062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
507
508 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
509
ea51cceb
JB
5102011-04-27 Juanma Barranquero <lekktu@gmail.com>
511
512 * makefile.w32-in: Update dependencies.
513
94dcfacf
EZ
5142011-04-27 Eli Zaretskii <eliz@gnu.org>
515
516 Improve `doprnt' and its usage. (Bug#8545)
517 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
518 `format_end'. Remove support for %l as a conversion specifier.
519 Don't use xrealloc. Improve diagnostics when the %l size modifier
520 is used. Update the commentary.
521
522 * eval.c (verror): Simplify calculation of size_t.
523
524 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
525 messages.
526
f61f41d7
PE
5272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
528
529 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
530 change.
531
96fb4434
PE
5322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
533
534 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
535 This makes this file independent of the recent pseudovector change.
536
671875da 5372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 538
69e9b5a3
PE
539 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
540
b5f869a7 541 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 542 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 543 Remove unused local.
c8926152 544 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 545
841a1577 546 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
547 GCC 4.6.0 optimizes based on type-based alias analysis.
548 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
549 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
550 != &v->size, and therefore "v->size = 1; b->size = 2; return
551 v->size;" must therefore return 1. This assumption is incorrect
552 for Emacs, since it type-puns struct Lisp_Vector * with many other
553 types. To fix this problem, this patch adds a new type struct
f904488f 554 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
555 and pseudovectors, and helps optimizing compilers not get fooled
556 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
557 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
558 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
559 the size member.
eab3844f
PE
560 (XSETPVECTYPE): Rewrite in terms of new macro.
561 (XSETPVECTYPESIZE): New macro, specifying both type and size.
562 This is a bit clearer, and further avoids the possibility of
563 undesirable aliasing.
564 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 565 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
566 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
567 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
568 (ASIZE): Now uses header.size rather than size.
569 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
570 to avoid the hassle of writing XVECTOR (foo)->header.size.
571 (struct vectorlike_header): New type.
eab3844f
PE
572 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
573 object, to help avoid aliasing.
574 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
575 (SUBRP): Likewise, since Lisp_Subr is a special case.
576 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
577 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
578 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 579 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
580 changed to be "header.size" and "header.next".
581 * buffer.h (struct buffer): Likewise.
582 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
583 * frame.h (struct frame): Likewise.
584 * process.h (struct Lisp_Process): Likewise.
585 * termhooks.h (struct terminal): Likewise.
586 * window.c (struct save_window_data, struct saved_window): Likewise.
587 * window.h (struct window): Likewise.
588 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
589 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
590 * buffer.c (init_buffer_once): Likewise.
591 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
592 special case.
593 * process.c (Fformat_network_address): Use local var for size,
594 for brevity.
595
0df1eac5
PE
596 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
597
847ab9d1 598 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
599 * data.c (atof): Remove decl; no longer used or needed.
600 (digit_to_number): Move to lread.c.
601 (Fstring_to_number): Use new string_to_number function, to be
602 consistent with how the Lisp reader treats infinities and NaNs.
603 Do not assume that floating-point numbers represent EMACS_INT
604 without losing information; this is not true on most 64-bit hosts.
605 Avoid double-rounding errors, by insisting on integers when
606 parsing non-base-10 numbers, as the documentation specifies.
607 * lisp.h (string_to_number): New decl, replacing ...
608 (isfloat_string): Remove.
bc0a5c13 609 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 610 (read1): Do not accept +. and -. as integers; this
452f4150
PE
611 appears to have been a coding error. Similarly, do not accept
612 strings like +-1e0 as floating point numbers. Do not report
613 overflow for integer overflows unless the base is not 10 which
614 means we have no simple and reliable way to continue.
615 Break out the floating-point parsing into a new
616 function string_to_number, so that Fstring_to_number parses
617 floating point numbers consistently with the Lisp reader.
04f2d78b 618 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
619 (E_CHAR, EXP_INT): Remove, replacing with ...
620 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
621 (string_to_number): New function, replacing isfloat_string.
622 This function checks for valid syntax and produces the resulting
623 Lisp float number too. Rework it so that string-to-number
bc0a5c13 624 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
625 so that overflow for non-base-10 numbers is reported only when
626 there's no portable and simple way to convert to floating point.
452f4150 627
67769ffc
PE
628 * textprop.c (set_text_properties_1): Rewrite for clarity,
629 and to avoid GCC warning about integer overflow.
630
c20db43f
PE
631 * intervals.h (struct interval): Use EMACS_INT for members
632 where EMACS_UINT might cause problems. See
633 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
634 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
635 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
636 All uses changed.
37aa2f85
PE
637 (offset_intervals): Tell GCC not to worry about length overflow
638 when negating a negative length.
c20db43f 639
2538aa2f
PE
640 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
641 (overrun_check_free): Likewise.
642
f2d3008d
PE
643 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
644 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
645 word size.
646
ec8df744
PE
647 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
648 (gnutls_make_error): Rename local to avoid shadowing.
649 (gnutls_emacs_global_deinit): ifdef out; not used.
650 (Fgnutls_boot): Use const for pointer to readonly storage.
651 Comment out unused local. Fix pointer signedness problems.
652
640ee02d
PE
653 * lread.c (openp): Don't stuff size_t into an 'int'.
654 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
655 about possible signed overflow.
656
6048fb2a
PE
657 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
658 (GDK_KEY_g): Don't define if already defined.
659 (xg_prepare_tooltip): Avoid pointer signedness problem.
660 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
661
fa3c87e1
PE
662 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
663 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
664
2172544b
PE
665 * xfns.c (Fx_window_property): Simplify a bit,
666 to make a bit faster and to avoid GCC 4.6.0 warning.
667 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
668
9b821a21
PE
669 * fns.c (internal_equal): Don't assume size_t fits in int.
670
3c616cfa
PE
671 * alloc.c (compact_small_strings): Tighten assertion a little.
672
c2982e87
PE
673 Replace pEd with more-general pI, and fix some printf arg casts.
674 * lisp.h (pI): New macro, generalizing old pEd macro to other
675 conversion specifiers. For example, use "...%"pI"d..." rather
676 than "...%"pEd"...".
677 (pEd): Remove. All uses replaced with similar uses of pI.
678 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
679 * alloc.c (check_pure_size): Don't overflow by converting size to int.
680 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
681 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
682 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
683 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
684 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
685 64-bit hosts.
686 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
687 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
688 * print.c (safe_debug_print, print_object): Likewise.
689 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
690 to int.
6f04d126
PE
691 Use pI instead of if-then-else-abort. Use %p to avoid casts,
692 avoiding the 0 flag, which is not portable.
c2982e87
PE
693 * process.c (Fmake_network_process): Use pI to avoid cast.
694 * region-cache.c (pp_cache): Likewise.
695 * xdisp.c (decode_mode_spec): Likewise.
696 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
697 behavior on 64-bit hosts with printf arg.
6f04d126 698 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
699 (x_stop_queuing_selection_requests): Likewise.
700 (x_get_window_property): Don't truncate byte count to an 'int'
701 when tracing.
0b432f21 702
5e073ec7
PE
703 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
704 here, since it parses constructs like leading '-' and spaces,
705 which are not wanted; and it overflows with large numbers.
706 Instead, simply match F[0-9]+, which is what is wanted anyway.
707
36372bf9
PE
708 * alloc.c: Remove unportable assumptions about struct layout.
709 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
710 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
711 (allocate_vectorlike, make_pure_vector): Use the new macros,
712 plus offsetof, to remove unportable assumptions about struct layout.
713 These assumptions hold on all porting targets that I know of, but
714 they are not guaranteed, they're easy to remove, and removing them
715 makes further changes easier.
716
0b432f21
PE
717 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
718 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
719 (string_overrun_cookie): Now const. Use initializers that
720 don't formally overflow signed char, to avoid warnings.
000098c1
PE
721 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
722 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
723 (allocate_buffer): Don't assume sizeof (struct buffer) is a
724 multiple of sizeof (EMACS_INT); it need not be, if
725 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 726 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 727
895009e1
JB
7282011-04-26 Juanma Barranquero <lekktu@gmail.com>
729
730 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
731
6a7a1b0b
TZ
7322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
733
734 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 735 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
736 Reported by Paul Eggert <eggert@cs.ucla.edu>.
737
841a1577 7382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
739
740 * lisp.h (Qdebug): List symbol.
895009e1 741 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
742 * keyboard.c (debug-on-event): New variable.
743 (handle_user_signal): Break into debugger when debug-on-event
744 matches the current signal symbol.
745
f2d3ba6f
DN
7462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
747
748 * alloc.c (check_sblock, check_string_bytes)
749 (check_string_free_list): Convert to standard C.
750
42ce4c63
TZ
7512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
752
753 * w32.c (emacs_gnutls_push): Fix typo.
754
825cd63c
EZ
7552011-04-25 Eli Zaretskii <eliz@gnu.org>
756
fb11d64d
EZ
757 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
758 "cast to pointer from integer of different size".
759
825cd63c
EZ
760 Improve doprnt and its use in verror. (Bug#8545)
761 * doprnt.c (doprnt): Document the set of format control sequences
762 supported by the function. Use SAFE_ALLOCA instead of always
763 using `alloca'.
764
765 * eval.c (verror): Don't limit the buffer size at size_max-1, that
766 is one byte too soon. Don't use xrealloc; instead xfree and
767 xmalloc anew.
768
e061a11b
TZ
7692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
770
771 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
772 callbacks stage.
773
774 * gnutls.c: Renamed global_initialized to
775 gnutls_global_initialized. Added internals for the
776 :verify-hostname-error, :verify-error, and :verify-flags
777 parameters of `gnutls-boot' and documented those parameters in the
778 docstring. Start callback support.
779 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
780 unless a fatal error occured. Call gnutls_alert_send_appropriate
781 on error. Return error code.
782 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
783 (emacs_gnutls_read): Likewise.
784 (Fgnutls_boot): Return handshake error code.
785 (emacs_gnutls_handle_error): New function.
786 (wsaerror_to_errno): Likewise.
787
788 * w32.h (emacs_gnutls_pull): Add prototype.
789 (emacs_gnutls_push): Likewise.
790
791 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
792 (emacs_gnutls_push): Likewise.
793
7942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
795
796 * process.c (wait_reading_process_output): Check if GnuTLS
797 buffered some data internally if no FDs are set for TLS
798 connections.
799
800 * makefile.w32-in (OBJ2): Add gnutls.$(O).
801 (LIBS): Link to USER_LIBS.
802 ($(BLD)/gnutls.$(0)): New target.
803
fa6996bc
EZ
8042011-04-24 Eli Zaretskii <eliz@gnu.org>
805
eb35682e
EZ
806 * xdisp.c (handle_single_display_spec): Rename the
807 display_replaced_before_p argument into display_replaced_p, to
808 make it consistent with the commentary. Fix typos in the
809 commentary.
810
e2ad650c
EZ
811 * textprop.c (syms_of_textprop): Remove dead code.
812 (copy_text_properties): Delete obsolete commentary about an
813 interface that was deleted long ago. Fix typos in the description
814 of arguments.
815
1b2de274
EZ
816 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
817 to changes in oldXMenu/XMenu.h from 2011-04-16.
818 <menu_help_message, prev_menu_help_message>: Constify.
819 (IT_menu_make_room): menu->help_text is now `const char **';
820 adjust.
821
822 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
823 to changes in oldXMenu/XMenu.h from 2011-04-16.
824 (struct XMenu): Declare `help_text' `const char **'.
825
826 * xfaces.c <Qunspecified>: Make extern again.
827
828 * syntax.c: Include sys/types.h before including regex.h, as
829 required by Posix.
830
762b15be
EZ
831 * doc.c (get_doc_string): Improve the format passed to `error'.
832
833 * doprnt.c (doprnt): Improve commentary.
834
835 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
836
837 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
838 them with etags.
839
f1052e5d
EZ
840 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
841 changes in globals.h immediately force recompilation.
762b15be
EZ
842 (TAGS): Depend on $(CURDIR)/m/intel386.h and
843 $(CURDIR)/s/ms-w32.h.
844 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 845
fa6996bc
EZ
846 * character.c (Fchar_direction): Function deleted.
847 (syms_of_character): Don't defsubr it.
848 <char-direction-table>: Deleted.
849
e6c3da20
EZ
8502011-04-23 Eli Zaretskii <eliz@gnu.org>
851
852 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
853 * doprnt.c: Include limits.h.
854 (SIZE_MAX): New macro.
04f2d78b
CB
855 (doprnt): Return a size_t value. 2nd arg is now size_t.
856 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
857 Improve overflow protection. Support `l' modifier for integer
858 conversions. Support %l conversion. Don't assume an EMACS_INT
859 argument for integer conversions and for %c.
860
861 * lisp.h (doprnt): Restore prototype.
862
863 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
864 $(SRC)/character.h.
865
866 * Makefile.in (base_obj): Add back doprnt.o.
867
868 * deps.mk (doprnt.o): Add back prerequisites.
869 (callint.o): Depend on character.h.
870
871 * eval.c (internal_lisp_condition_case): Include the handler
872 representation in the error message.
873 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
874 when breaking from the loop.
875
876 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
877
878 * callint.c (Fcall_interactively): When displaying error message
879 about invalid control letter, pass the character's codepoint, not
880 a pointer to its multibyte form. Improve display of the character
881 in octal and display also its hex code.
882
883 * character.c (char_string): Use %x to display the (unsigned)
884 codepoint of an invalid character, to avoid displaying a bogus
885 negative value.
886
887 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
888 `error', not SYMBOL_NAME itself.
889
890 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
891 character arguments to `error'.
892
893 * charset.c (check_iso_charset_parameter): Fix incorrect argument
894 to `error' in error message about FINAL_CHAR argument. Make sure
895 FINAL_CHAR is a character, and use %c when it is passed as
896 argument to `error'.
897
4ffd0d6b 8982011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
899
900 * s/ms-w32.h (localtime): Redirect to sys_localtime.
901
902 * w32.c: Include <time.h>.
903 (sys_localtime): New function.
904
4ffd0d6b 9052011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
906
907 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
908
4ffd0d6b 909 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 910
4ffd0d6b 9112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 912
4ffd0d6b
GM
913 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
914 zombies (Bug#8467).
aac0c6e3 915
04c56954
EZ
9162011-04-19 Eli Zaretskii <eliz@gnu.org>
917
918 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
919 gl_state.e_property when gl_state.object is Qt.
920
921 * insdel.c (make_gap_larger): Remove limitation of buffer size
922 to <= INT_MAX.
923
16a43933
CY
9242011-04-18 Chong Yidong <cyd@stupidchicken.com>
925
926 * xdisp.c (lookup_glyphless_char_display)
927 (produce_glyphless_glyph): Handle cons cell entry in
928 glyphless-char-display.
929 (Vglyphless_char_display): Document it.
930
931 * term.c (produce_glyphless_glyph): Handle cons cell entry in
932 glyphless-char-display.
933
4581706e
CY
9342011-04-17 Chong Yidong <cyd@stupidchicken.com>
935
936 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
937
938 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
939
940 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
941 definition for no-X builds.
942
4887c6e2 9432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 944
fd35b6f9
PE
945 Static checks with GCC 4.6.0 and non-default toolkits.
946
5c1ccb01
PE
947 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
948
006c5daa
PE
949 * process.c (keyboard_bit_set): Define only if SIGIO.
950 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
951 (send_process): Repair possible setjmp clobbering.
952
efc736d3
PE
953 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
954
4e2fe2e6
PE
955 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
956
f97334a2
PE
957 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
958
4e75f29d
PE
959 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
960 Define only if needed.
961
90efadd1
PE
962 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
963 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 964 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 965
3c647824
PE
966 * dispextern.h (struct redisplay_interface): Rename param
967 to avoid shadowing.
e264f262 968 * termhooks.h (struct terminal): Likewise.
761383f4 969 * xterm.c (xembed_send_message): Likewise.
3c647824 970
b58c5c4a
PE
971 * insdel.c (make_gap_smaller): Define only if
972 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
973
cad59032
PE
974 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
975 it.
976
c339dc2e
PE
977 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
978 so that we aren't warned about unused symbols.
979
91a3e27b
PE
980 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
981
399c71d3 982 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 983
8ffc96f5
PE
984 * xfns.c (x_real_positions): Mark locals as initialized.
985
eef9bc79
PE
986 * xmenu.c (xmenu_show): Don't use uninitialized vars.
987
098db9dd
PE
988 * xterm.c: Fix problems found by static analysis with other toolkits.
989 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
990 (x_dispatch_event): Declare static if USE_GTK, and
991 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 992 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 993 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
994 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
995 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 996
eb18f6cc
PE
997 * xmenu.c (menu_help_callback): Pointer type fixes.
998 Use const pointers when pointing at readonly data. Avoid pointer
999 signedness clashes.
1000 (FALSE): Remove unused macro.
1001 (update_frame_menubar): Remove unused decl.
1002
1fe72bf8
PE
1003 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1004
60d9e1db
PE
1005 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1006 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1007 (single_menu_item): Rename local to avoid shadowing.
1008
39261c26
PE
1009 * keyboard.c (make_lispy_event): Remove unused local var.
1010
018c5e19
PE
1011 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1012 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1013
63d2b86e
PE
1014 * bitmaps: Change bitmaps from unsigned char back to the X11
1015 compatible char. Avoid the old compiler warnings about
1016 out-of-range initializers by using, for example, '\xab' rather
1017 than 0xab.
1018
aefd87e1
PE
1019 * xgselect.c (xgselect_initialize): Check vs interface
1020 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1021
bf501fb9
PE
1022 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1023
e9829fdf
PE
1024 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1025 to read-only memory.
1026
1086c095
PE
1027 * fns.c (vector): Remove; this old hack is no longer needed.
1028
2baccd04 1029 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1030 Remove unused var.
dde42981 1031 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1032
72391843 1033 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1034
436c16df 1035 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1036 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1037 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1038
92bb796d 1039 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1040 (x_term_init): Remove local to avoid shadowing.
92bb796d 1041
764430a3 1042 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1043
1044 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1045 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1046
d1dfb56c
EZ
10472011-04-16 Eli Zaretskii <eliz@gnu.org>
1048
c4354cb4
EZ
1049 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1050
d1dfb56c
EZ
1051 Fix regex.c, syntax.c and friends for buffers > 2GB.
1052 * syntax.h (struct gl_state_s): Declare character position members
1053 EMACS_INT.
1054
1055 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1056
04f2d78b
CB
1057 * textprop.c (verify_interval_modification, interval_of):
1058 Declare arguments EMACS_INT.
d1dfb56c
EZ
1059
1060 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1061 EMACS_INT.
1062
1063 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1064
1065 * indent.c (Fvertical_motion): Local variable it_start is now
1066 EMACS_INT.
1067
1068 * regex.c (re_match, re_match_2, re_match_2_internal)
1069 (bcmp_translate, regcomp, regexec, print_double_string)
1070 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1071 (re_compile_pattern, re_exec): Declare arguments and local
1072 variables `size_t' and `ssize_t' and return values `regoff_t', as
1073 appropriate.
1074 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1075 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1076 <compile_stack_type>: `size' and `avail' are now `size_t'.
1077
1078 * regex.h <regoff_t>: Use ssize_t, not int.
1079 (re_search, re_search_2, re_match, re_match_2): Arguments that
1080 specify buffer/string position and length are now ssize_t and
1081 size_t. Return type is regoff_t.
1082
613052cd
BK
10832011-04-16 Ben Key <bkey76@gmail.com>
1084
1085 * nsfont.m: Fixed bugs in ns_get_family and
1086 ns_descriptor_to_entity that were caused by using free to
1087 deallocate memory blocks that were allocated by xmalloc (via
1088 xstrdup). This caused Emacs to crash when compiled with
1089 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1090 --enable-checking=xmallocoverrun). xfree is now used to
1091 deallocate these memory blocks.
1092
4170f62f 10932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1094
71b41406
PE
1095 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1096
9587a89d
PE
1097 emacs_write: Accept and return EMACS_INT for sizes.
1098 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1099 et seq.
1100 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1101 Accept and return EMACS_INT.
1102 (emacs_gnutls_write): Return the number of bytes written on
1103 partial writes.
1104 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1105 (emacs_read, emacs_write): Remove check for negative size, as the
1106 Emacs source code has been audited now.
9587a89d
PE
1107 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1108 (emacs_read, emacs_write): Use it.
273a5f82
PE
1109 * process.c (send_process): Adjust to the new signatures of
1110 emacs_write and emacs_gnutls_write. Do not attempt to store
1111 a byte offset into an 'int'; it might overflow.
9587a89d 1112 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1113
3e047f51
PE
1114 * sound.c: Don't assume sizes fit in 'int'.
1115 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1116 Return EMACS_INT, not int.
3e047f51 1117 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1118 Accept EMACS_INT, not int.
1119 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1120 record read return values.
1121
cc39a9db
BK
11222011-04-15 Ben Key <bkey76@gmail.com>
1123
c9d0ec6d
JB
1124 * keyboard.c (Qundefined): Don't declare static since it is used
1125 in nsfns.m.
1126 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1127 static since they are used in nsfont.m.
cc39a9db 1128
6c60eb9f
SM
11292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1130
1131 * process.c (Qprocessp): Don't declare static.
1132 * lisp.h (Qprocessp): Declare again.
1133
7990b61a
JB
11342011-04-15 Juanma Barranquero <lekktu@gmail.com>
1135
1136 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1137
5d4cb038
PE
11382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1139
8bd7b830 1140 Improve C-level modularity by making more things 'static'.
cd64ea1d 1141
e3b27b31
PE
1142 Don't publish debugger-only interfaces to other modules.
1143 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1144 (verify_bytepos, count_markers): Move decls to the only modules
1145 that need them.
1146 * region-cache.h (pp_cache): Likewise.
1147 * window.h (check_all_windows): Likewise.
1148 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1149
5d4cb038
PE
1150 * sysdep.c (croak): Now static, if
1151 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1152 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1153
1154 * alloc.c (refill_memory_reserve): Now static if
1155 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1156 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1157
e87b6180
PE
1158 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1159 Define only if USE_LUCID.
1160
ac64929e
PE
1161 * xrdb.c (x_customization_string, x_rm_string): Now static.
1162
6f37259d
PE
1163 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1164 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1165
1683e3ab
PE
1166 * xdisp.c (draw_row_with_mouse_face): Now static.
1167 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1168
de9c2632
PE
1169 * window.h (check_all_windows): Mark externally visible.
1170
2b96acb7
PE
1171 * window.c (window_deletion_count): Now static.
1172
1173 * undo.c: Make symbols static if they're not exported.
1174 (last_undo_buffer, last_boundary_position, pending_boundary):
1175 Now static.
1176
50436f33
PE
1177 * textprop.c (interval_insert_behind_hooks): Now static.
1178 (interval_insert_in_front_hooks): Likewise.
1179
64520e5c
PE
1180 * term.c: Make symbols static if they're not exported.
1181 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1182 (max_frame_lines, tty_set_terminal_modes):
1183 (tty_reset_terminal_modes, tty_turn_off_highlight):
1184 (get_tty_terminal): Now static.
1185 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1186 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1187 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1188 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1189 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1190
1fa53021
PE
1191 * sysdep.c: Make symbols static if they're not exported.
1192 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1193 Now static.
1194 (sigprocmask_set, full_mask): Remove; unused.
1195 (wait_debugging): Mark as visible.
1196 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1197 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1198
d4b43b22
PE
1199 * syntax.c (syntax_temp): Define only if !__GNUC__.
1200
b7c513d0
PE
1201 * sound.c (current_sound_device, current_sound): Now static.
1202
989b29ad
PE
1203 * search.c (searchbufs, searchbuf_head): Now static.
1204
13a55a78
PE
1205 * scroll.c (scroll_cost): Remove; unused.
1206 * dispextern.h (scroll_cost): Remove decl.
1207
de68a1fc
PE
1208 * region-cache.h (pp_cache): Mark as externally visible.
1209
40ccffa6
PE
1210 * process.c: Make symbols static if they're not exported.
1211 (process_tick, update_tick, create_process, chan_process):
1212 (Vprocess_alist, proc_buffered_char, datagram_access):
1213 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1214 (deactivate_process): Mark defn as static, as well as decl.
1215 * lisp.h (create_process): Remove decl.
1216 * process.h (chan_process, Vprocess_alist): Remove decls.
1217
ad64fc97
PE
1218 * print.c: Make symbols static if they're not exported.
1219 (print_depth, new_backquote_output, being_printed, print_buffer):
1220 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1221 (print_interval, print_number_index, initial_stderr_stream):
1222 Now static.
1223 * lisp.h (Fprinc): Remove decl.
1224 (debug_output_compilation_hack): Mark as externally visible.
1225
adddb265
PE
1226 * sysdep.c (croak): Move decl from here to syssignal.h.
1227 * syssignal.h (croak): Put it here, so the API can be checked when
1228 'croak' is called from dissociate_if_controlling_tty.
1229
1717ede2
PE
1230 * minibuf.c: Make symbols static if they're not exported.
1231 (minibuf_save_list, choose_minibuf_frame): Now static.
1232 * lisp.h (choose_minibuf_frame): Remove decl.
1233
fa5fb2bc
PE
1234 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1235
1e3890d1
PE
1236 * lread.c: Make symbols static if they're not exported.
1237 (read_objects, initial_obarray, oblookup_last_bucket_number):
1238 Now static.
1239 (make_symbol): Remove; unused.
1240 * lisp.h (initial_obarray, make_symbol): Remove decls.
1241
8a1414fa
PE
1242 * keyboard.c: Make symbols static if they're not exported.
1243 (single_kboard, recent_keys_index, total_keys, recent_keys):
1244 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1245 (this_single_command_key_start, echoing, last_auto_save):
1246 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1247 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1248 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1249 (Vlispy_mouse_stem, double_click_count):
1250 Now static.
1251 (force_auto_save_soon): Define only if SIGDANGER.
1252 (ignore_mouse_drag_p): Now static if
1253 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1254 (print_help): Remove; unused.
1255 (stop_character, last_timer_event): Mark as externally visible.
1256 * keyboard.h (ignore_mouse_drag_p): Declare only if
1257 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1258 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1259 * lisp.h (echoing): Remove decl.
1260 (force_auto_save_soon): Declare only if SIGDANGER.
1261 * xdisp.c (redisplay_window): Simplify code, to make it more
1262 obvious that ignore_mouse_drag_p is not accessed if !defined
1263 USE_GTK && !defined HAVE_NS.
1264
93ea6e8f
PE
1265 * intervals.c: Make symbols static if they're not exported.
1266 (merge_properties_sticky, merge_interval_right, delete_interval):
1267 Now static.
1268 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1269
77382fcc
PE
1270 * insdel.c: Make symbols static if they're not exported.
1271 However, leave prepare_to_modify_buffer alone. It's never
1272 called from outside this function, but that appears to be a bug.
1273 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1274 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1275 (adjust_after_replace_noundo): Remove; unused.
1276 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1277 (signal_before_change): Remove decls.
77382fcc 1278
9306c32e
PE
1279 * indent.c (val_compute_motion, val_vmotion): Now static.
1280
cd44d2eb
PE
1281 * image.c: Make symbols static if they're not exported.
1282 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1283 if USE_GTK.
1284 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1285 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1286
ad9a7a06
PE
1287 * fringe.c (standard_bitmaps): Now static.
1288 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1289
81626931
PE
1290 * frame.c: Make symbols static if they're not exported.
1291 (x_report_frame_params, make_terminal_frame): Now static.
1292 (get_frame_param): Now static, unless HAVE_NS.
1293 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1294 (x_get_resource_string): Remove; not used.
1295 * frame.h (make_terminal_frame, x_report_frame_params):
1296 (x_get_resource_string); Remove decls.
1297 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1298 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1299
239f9db9
PE
1300 * font.c, fontset.c: Make symbols static if they're not exported.
1301 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1302 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1303 * font.c (font_close_object): Now static.
1304 * font.h (font_close_object): Remove.
1305 * fontset.c (FONTSET_OBJLIST): Remove.
1306 (free_realized_fontset) #if-0 the body, which does nothing.
1307 (face_suitable_for_char_p): #if-0, as it's never called.
1308 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1309 * xfaces.c (face_at_string_position):
1310 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1311 since 0 is always ASCII.
1312
dfcf3579
PE
1313 * fns.c (weak_hash_tables): Now static.
1314
5045092b
PE
1315 * fileio.c: Make symbols static if they're not exported.
1316 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1317 (Vwrite_region_annotation_buffers): Now static.
1318
57a96f5c
PE
1319 * eval.c: Make symbols static if they're not exported.
1320 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1321 * lisp.h (backtrace_list): Remove decl.
1322
35f08c38
PE
1323 * emacs.c: Make symbols static if they're not exported.
1324 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1325 (fatal_error_code, fatal_error_signal_hook, standard_args):
1326 Now static.
1327 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1328 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1329 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1330 * lisp.h (fatal_error_signal_hook): Remove decl.
1331 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1332
f44bd759
PE
1333 * editfns.c: Move a (normally-unused) function to its only use.
1334 * editfns.c, lisp.h (get_operating_system_release): Remove.
1335 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1336 worth the hassle of breaking this out.
1337
b532497d
PE
1338 * xterm.c: Make symbols static if they're not exported.
1339 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1340 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1341 (x_destroy_window, x_delete_display):
1342 Now static.
1343 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1344 (x_mouse_leave): Remove; unused.
1345 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1346 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1347 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1348 Remove decls.
1349 (x_mouse_leave): Declare only if WINDOWSNT.
1350 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1351 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1352 USE_X_TOOLKIT.
1353
1675728f
PE
1354 * ftxfont.c: Make symbols static if they're not exported.
1355 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1356 HAVE_FREETYPE.
1357 * font.h (ftxfont_driver): Likewise.
1358
e4cebfca
PE
1359 * xfns.c: Make symbols static if they're not exported.
1360 (x_last_font_name, x_display_info_for_name):
1361 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1362 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1363 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1364 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1365 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1366 (last_show_tip_args): Now static.
1367 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1368 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1369 (x_screen_planes): Remove; unused.
1370 * dispextern.h (x_screen_planes): Remove decl.
1371
5bf46f05
PE
1372 * dispnew.c: Make symbols static if they're not exported.
1373 * dispextern.h (redraw_garbaged_frames, scrolling):
1374 (increment_row_positions): Remove.
1375 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1376 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1377 Now static.
1378 (redraw_garbaged_frames): Remove; unused.
1379
435f4c28
PE
1380 * xfaces.c: Make symbols static if they're not exported.
1381 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1382 Remove decls.
1383 * xterm.h (defined_color): Remove decls.
1384 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1385 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1386 (menu_face_changed_default, defined_color, free_realized_face):
1387 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1388 (ascii_face_of_lisp_face): Remove; unused.
1389
8524aef3
PE
1390 * xdisp.c: Make symbols static if they're not exported.
1391 * dispextern.h (scratch_glyph_row, window_box_edges):
1392 (glyph_to_pixel_coords, set_cursor_from_row):
1393 (get_next_display_element, set_iterator_to_next):
1394 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1395 (show_mouse_face): Remove decls
1396 * frame.h (message_buf_print): Likewise.
1397 * lisp.h (pop_message, set_message, check_point_in_composition):
1398 Likewise.
1399 * xterm.h (set_vertical_scroll_bar): Likewise.
1400 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1401 (message_buf_print, scratch_glyph_row, displayed_buffer):
1402 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1403 (get_next_display_element, show_mouse_face, window_box_edges):
1404 (frame_to_window_pixel_xy, check_point_in_composition):
1405 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1406 (glyph_to_pixel_coords): Remove; unused.
1407
16390cd2
PE
1408 * dired.c (file_name_completion): Now static.
1409
1410 * dbusbind.c (xd_in_read_queued_messages): Now static.
1411
a25f4dfa
PE
1412 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1413 * data.c (circular_list_error): Remove.
1414
14a9c8df
PE
1415 * commands.h (last_point_position, last_point_position_buffer):
1416 (last_point_position_window): Remove decls.
1417 * keyboard.c: Make these variables static.
1418
04f2d78b
CB
1419 * coding.h (coding, code_convert_region, encode_coding_gap):
1420 Remove decls.
74ab6df5
PE
1421 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1422 (iso_code_class, detect_coding, code_convert_region): Now static.
1423 (encode_coding_gap): Remove; unused.
1424
38dfbee1
PE
1425 * chartab.c (chartab_chars, chartab_bits): Now static.
1426
a2cb4e63
PE
1427 * charset.h (charset_iso_8859_1): Remove decl.
1428 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1429 Now static.
1430
127198fd
PE
1431 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1432 * ccl.c (Vccl_program_table): Now static.
1433 (check_ccl_update): Remove; unused.
1434
d85b608f
PE
1435 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1436 * category.h: ... from here.
1437 * category.c (check_category_table, set_category_set): Now static.
1438
31cd66f3
PE
1439 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1440 * lisp.h: Remove these decls.
1441
c358e587
PE
1442 * buffer.c (buffer_count): Remove unused var.
1443
e78aecca
PE
1444 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1445 so that it's not optimized away.
1446 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1447 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1448 exported only to the debugger.
1449
e192d7d3 1450 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1451 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1452
92470028
PE
1453 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1454 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1455 was inaccessible from Lisp.
1456 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1457 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1458
244ed907
PE
1459 alloc.c: Import and export fewer symbols, and remove unused items.
1460 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1461 is defined.
1462 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1463 it's not optimized away by whole-program optimization.
1464 (message_enable_multibyte, free_misc): Remove.
1465 (catchlist, handlerlist, mark_backtrace):
1466 Declare only if BYTE_MARK_STACK.
1467 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1468 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1469 (message_enable_multibyte): Remove decl.
1470 (free_misc, interval_free_list, float_block, float_block_index):
1471 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1472 (cons_free_list, last_marked_index):
1473 Now static.
1474 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1475 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1476 (mark_backtrace): Define only if BYTE_MARK_STACK.
1477 * xdisp.c (message_enable_multibyte): Now static.
1478
61c2b50e 1479 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1480 This makes it easier for human readers (and static analyzers)
1481 to see whether these variables are used from other modules.
1482 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1483 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1484 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1485 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1486 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1487 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1488 * xmenu.c, xselect.c:
1489 Declare Q* vars static if they are not used in other modules.
1490 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1491 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1492 Remove decls of unexported vars.
1493 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1494
95c82688
PE
1495 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1496
16a97296
PE
1497 Make Emacs functions such as Fatom 'static' by default.
1498 This makes it easier for human readers (and static analyzers)
1499 to see whether these functions can be called from other modules.
1500 DEFUN now defines a static function. To make the function external
1501 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1502 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1503 (Finit_image_library):
16a97296
PE
1504 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1505 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1506 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1507 Remove decls, since these functions are now static.
1508 (Funintern, Fget_internal_run_time): New decls, since these functions
1509 were already external.
95c82688 1510
16a97296
PE
1511 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1512 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1513 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1514 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1515 * keyboard.c, keymap.c, lread.c:
1516 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1517 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1518 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1519 Mark functions with DEFUE instead of DEFUN,
1520 if they are used in other modules.
1521 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1522 decls for now-static functions.
1523 * buffer.h (Fdelete_overlay): Remove decl.
1524 * callproc.c (Fgetenv_internal): Mark as internal.
1525 * composite.c (Fremove_list_of_text_properties): Remove decl.
1526 (Fcomposition_get_gstring): New forward static decl.
1527 * composite.h (Fcomposite_get_gstring): Remove decl.
1528 * dired.c (Ffile_attributes): New forward static decl.
1529 * doc.c (Fdocumntation_property): New forward static decl.
1530 * eval.c (Ffetch_bytecode): New forward static decl.
1531 (Funintern): Remove extern decl; now in .h file where it belongs.
1532 * fileio.c (Fmake_symbolic_link): New forward static decl.
1533 * image.c (Finit_image_library): New forward static decl.
1534 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1535 * intervals.h (Fprevious_property_change):
1536 (Fremove_list_of_text_properties): Remove decls.
1537 * keyboard.c (Fthis_command_keys): Remove decl.
1538 (Fcommand_execute): New forward static decl.
1539 * keymap.c (Flookup_key): New forward static decl.
1540 (Fcopy_keymap): Now static.
1541 * keymap.h (Flookup_key): Remove decl.
1542 * process.c (Fget_process): New forward static decl.
1543 (Fprocess_datagram_address): Mark as internal.
1544 * syntax.c (Fsyntax_table_p): New forward static decl.
1545 (skip_chars): Remove duplicate decl.
1546 * textprop.c (Fprevious_property_change): New forward static decl.
1547 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1548 Now internal.
1549 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1550 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1551
785bbd42
PE
1552 * editfns.c (Fformat): Remove unreachable code.
1553
8b913b57
AS
15542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1555
1556 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1557 change. (Bug#8496)
1558
a6744a35
EZ
15592011-04-13 Eli Zaretskii <eliz@gnu.org>
1560
1561 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1562 when at ZV. (Bug#8487)
1563
e7974947
AS
15642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1565
baad03f0
AS
1566 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1567 (Bug#8437)
1568 * keyboard.c (parse_tool_bar_item): Likewise.
1569 * sound.c (sound_cleanup, alsa_close): Likewise.
1570 * termcap.c (tgetent): Likewise.
1571 * xfns.c (x_default_font_parameter): Likewise.
1572 * xsettings.c (read_and_apply_settings): Likewise.
1573
e7974947
AS
1574 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1575 (overrun_check_free): Protoize.
1576
28272684
PE
15772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1580 since callers should never pass a negative size.
1581 Change the signature to match that of plain 'read' and 'write'; see
1582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1583 * lisp.h: Update prototypes of emacs_write and emacs_read.
1584
11997c76
EZ
15852011-04-11 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (redisplay_window): Don't try to determine the character
1588 position of the scroll margin if the window start point w->startp
e896f03c 1589 is outside the buffer's accessible region. (Bug#8468)
11997c76 1590
8a2cbd72
EZ
15912011-04-10 Eli Zaretskii <eliz@gnu.org>
1592
1593 Fix write-region and its subroutines for buffers > 2GB.
1594 * fileio.c (a_write, e_write): Modify declaration of arguments and
1595 local variables to support buffers larger than 2GB.
1596 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1597
1598 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1599 argument, local variables, and return value.
1600
1601 * lisp.h: Update prototypes of emacs_write and emacs_read.
1602
1603 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1604
4073e537 16052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1606
1ebfdcb6
PE
1607 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1608
b2ded58d
PE
1609 Fix more problems found by GCC 4.6.0's static checks.
1610
7d66342c
PE
1611 * xdisp.c (vmessage): Use a better test for character truncation.
1612
bbf47d44
PE
1613 * charset.c (load_charset_map): <, not <=, for optimization,
1614 and to avoid potential problems with integer overflow.
9248994d 1615 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1616 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1617 * editfns.c (Fformat): Likewise.
1e69125e 1618 * syntax.c (skip_chars): Likewise.
3befa583 1619
e3019616
PE
1620 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1621 This also lets GCC 4.6.0 generate slightly better loop code.
1622
becfa255
PE
1623 * callint.c (Fcall_interactively): <, not <=, for optimization.
1624 (Fcall_interactively): Count the number of arguments produced,
1625 not the number of arguments given. This is simpler and lets GCC
1626 4.6.0 generate slightly better code.
1627
dae0cd48
PE
1628 * ftfont.c: Distingish more carefully between FcChar8 and char.
1629 The previous code passed unsigned char * to a functions like
1630 strlen and xstrcasecmp that expect char *, which does not
1631 conform to the C standard.
1632 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1633 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1634 char * when the C standard requires it.
1635
76032d70
PE
1636 * keyboard.c (read_char): Remove unused var.
1637
eb3f1cc8
PE
1638 * eval.c: Port to Windows vsnprintf (Bug#8435).
1639 Include <limits.h>.
1640 (SIZE_MAX): Define if the headers do not.
1641 (verror): Do not give up if vsnprintf returns a negative count.
1642 Instead, grow the buffer. This ports to Windows vsnprintf, which
1643 does not conform to C99. Problem reported by Eli Zaretskii.
1644 Also, simplify the allocation scheme, by avoiding the need for
1645 calling realloc, and removing the ALLOCATED variable.
1646
70476b54
PE
1647 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1648
12020a9e
PE
1649 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1650 But keep the doprint source code for now, as we might revamp it
1651 and use it again (Bug#8435).
ea6c7ae6
PE
1652 * lisp.h (doprnt): Remove.
1653 * Makefile.in (base_obj): Remove doprnt.o.
1654 * deps.mk (doprnt.o): Remove.
1655
5fdb398c
PE
1656 error: Print 32- and 64-bit integers portably (Bug#8435).
1657 Without this change, on typical 64-bit hosts error ("...%d...", N)
1658 was used to print both 32- and 64-bit integers N, which relied on
1659 undefined behavior.
1660 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1661 New macro.
1662 * lisp.h (error, verror): Mark as printf-like functions.
1663 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1664 Report overflow in size calculations when allocating printf buffer.
1665 Do not truncate output string at its first null byte.
1666 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1667 Truncate the output at a character boundary, since vsnprintf does not
1668 do that.
1669 * charset.c (check_iso_charset_parameter): Convert internal
1670 character to string before calling 'error', since %c now has the
1671 printf meaning.
1672 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1673 overflow when computing char to be passed to 'error'. Do not
1674 pass Lisp_Object to 'error'; pass the integer instead.
1675 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1676 formatted with plain %d.
1677
b189fa66
PE
1678 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1679
bff87ef0
PE
1680 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1681
7e2cac20
PE
1682 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1683
ce4d90b5
PE
1684 * xterm.c (x_catch_errors): Remove duplicate declaration.
1685
266c9547
PE
1686 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1687
79c49ad2
PE
1688 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1689
368f4090
JM
16902011-04-10 Jim Meyering <meyering@redhat.com>
1691
1692 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1693 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1694 return ssize_t not "int", and use size_t as the buffer length.
1695 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1696 * gnutls.h: Update declarations.
1697 * process.c (read_process_output): Use ssize_t, to match.
1698 (send_process): Likewise.
1699
a32d4040
CY
17002011-04-09 Chong Yidong <cyd@stupidchicken.com>
1701
1702 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1703
8546720e 17042011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1705
04f2d78b
CB
1706 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1707 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1708
8546720e
GM
1709 * xterm.c (handle_one_xevent):
1710 * xmenu.c (create_and_show_popup_menu):
1711 * xselect.c (x_decline_selection_request)
1712 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1713
0a2f5c1a 17142011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1715
1716 Fix some uses of `int' instead of EMACS_INT.
1717 * search.c (string_match_1, fast_string_match)
1718 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1719 (scan_buffer, find_next_newline_no_quit)
1720 (find_before_next_newline, search_command, Freplace_match)
1721 (Fmatch_data): Make some `int' variables be EMACS_INT.
1722
1723 * xdisp.c (display_count_lines): 3rd argument and return value now
1724 EMACS_INT. All callers changed.
1725 (pint2hrstr): Last argument is now EMACS_INT.
1726
1727 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1728 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1729 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1730 (decode_coding_utf_16, decode_coding_emacs_mule)
1731 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1732 (decode_coding_ccl, decode_coding_charset)
1733 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1734 (decode_coding_iso_2022, decode_coding_emacs_mule)
1735 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1736 <char_offset, last_offset>: Declare EMACS_INT.
1737 (encode_coding_utf_8, encode_coding_utf_16)
1738 (encode_coding_emacs_mule, encode_invocation_designation)
1739 (encode_designation_at_bol, encode_coding_iso_2022)
1740 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1741 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1742 Declare EMACS_INT.
1743 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1744 (encode_invocation_designation): Last argument P_NCHARS is now
1745 EMACS_INT.
1746 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1747 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1748
1749 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1750 All users changed.
1751
1752 * ccl.c (Fccl_execute_on_string): Declare some variables
1753 EMACS_INT.
1754
8546720e 17552011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1756
1757 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1758
4e19a977
CS
17592011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1760
1761 * process.c (Fformat_network_address): Doc fix.
1762
87302331
R
17632011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1764
1765 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1766
cbb59342
CY
17672011-04-08 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * keyboard.c (read_char): Call Lisp function help-form-show,
1770 instead of using internal_with_output_to_temp_buffer.
1771 (Qhelp_form_show): New var.
e0d38eeb 1772 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1773
1774 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1775
1776 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1777
e67a13ab
CY
17782011-04-06 Chong Yidong <cyd@stupidchicken.com>
1779
04f2d78b
CB
1780 * process.c (Flist_processes): Remove to Lisp.
1781 (list_processes_1): Delete.
e67a13ab 1782
973f782d
EZ
17832011-04-06 Eli Zaretskii <eliz@gnu.org>
1784
7c106b1e
EZ
1785 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1786
973f782d
EZ
1787 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1788
41cf7d1a 17892011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1790
ca23cc88
PE
1791 Fix more problems found by GCC 4.6.0's static checks.
1792
f390e2d5
PE
1793 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1794
42eea0d0
PE
1795 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1796
b69769da 1797 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1798
f9541e84
PE
1799 * xdisp.c (vmessage): Mark as a printf-like function.
1800
13841b55
PE
1801 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1802
c136c10f
PE
1803 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1804
5e2d4a30
PE
1805 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1806 printf-like functions.
1807 (tiff_load): Add casts to remove these marks before passing them
1808 to system-supplied API.
1809
583f48b9
PE
1810 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1811
b25d760e
PE
1812 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1813 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1814 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1815 directly, rather than having caller test rule sign. This avoids
1816 some unnecessary tests.
1817 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1818 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1819 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1820
bc7b6697 1821 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1822 (xfont_open): Avoid unnecessary tests.
bc7b6697 1823
27ccc379
PE
1824 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1825
dcd5c89a
PE
1826 * composite.h, composite.c (composition_gstring_put_cache):
1827 Use EMACS_INT, not int, for length.
1828
b13a45c6
PE
1829 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1830 breaking out part of COMPOSITION_DECODE_RULE.
1831 (COMPOSITION_DECODE_RULE): Use it.
1832 * composite.c (get_composition_id): Remove unused local vars,
1833 by using the new macro.
1834
1e792e4d
PE
1835 * textprop.c (set_text_properties_1): Change while to do-while,
1836 since the condition is always true at first.
1837
dc6c6455 1838 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1839 (interval_deletion_adjustment): Return unsigned value.
1840 All uses changed.
dc6c6455 1841
aba7731a
PE
1842 * process.c (list_processes_1, create_pty, read_process_output):
1843 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1844 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1845 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1846 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1847 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1848
fdfc4bf3
PE
1849 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1850
fca8fe46 1851 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1852 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1853
06a0259a 1854 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1855 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1856 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1857
e7b9e80f
PE
1858 * print.c (print_error_message): Avoid int overflow.
1859
56201685
PE
1860 * font.c (font_list_entities): Redo for clarity,
1861 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1862
78834453 1863 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1864 (font_score): Avoid potential overflow in diff calculation.
78834453 1865
0bc0b309 1866 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1867 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1868
e610eaca
PE
1869 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1870
b895abce
PE
1871 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1872 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1873 can always succeed if overflow has undefined behavior.
1874
1f1d9321 1875 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1876 (wordify): Omit three unnecessary tests.
1f1d9321 1877
c59478bc
PE
1878 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1879 All callers changed. This avoids the need for an unused var.
1880
79b73827
PE
1881 * casefiddle.c (casify_region): Remove var that is set but not used.
1882
a4db5dfe
PE
1883 * dired.c (file_name_completion): Remove var that is set but not used.
1884
43aae36e
PE
1885 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1886
2a47c44d 1887 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1888 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1889
a37c69bf
PE
1890 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1891 Check for integer overflow on size calculations.
1892
328ab8e7
PE
1893 * buffer.c (Fprevious_overlay_change): Remove var that is set
1894 but not used.
1895
e5a2a5cb
PE
1896 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1897 Remove vars that are set but not used.
8d84a6eb 1898 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1899 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1900
a60e5f68
PE
1901 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1902
f661cb61 1903 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1904 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1905
f0397f5a
PE
1906 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1907 that are set but not used.
1908
8664db06 1909 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1910 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1911
6abdaa4a
PE
1912 * xselect.c (x_get_local_selection, x_handle_property_notify):
1913 Remove vars that are set but not used.
1914
0ce7538d 1915 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1916 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1917
9ae848fc
PE
1918 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1919 Remove var that is set but not used.
0b918413
PE
1920 (scroll_bar_windows_size): Now size_t, not int.
1921 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1922 Check for overflow.
9ae848fc 1923
a5a62657
PE
1924 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1925 (map_tty_color) [!defined MSDOS]: Likewise.
1926
5c5cdd39
PE
1927 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1928
66ebf983
PE
1929 * coding.c: Remove vars that are set but not used.
1930 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1931 All callers changed.
1932 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1933 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1934 (decode_coding_charset): Remove vars that are set but not used.
1935
1be4d761
PE
1936 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1937 that is set but not used.
1938
47553fa8
PE
1939 * print.c (print_object): Remove var that is set but not used.
1940
1f7196bf 1941 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1942 The gnulib version avoids calling malloc in the usual case,
1943 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1944 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1945 * filelock.c (current_lock_owner): Likewise.
1946 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1947 * sysdep.c: Include allocator.h, careadlinkat.h.
1948 (emacs_no_realloc_allocator): New static constant.
1949 (emacs_readlink): New function.
fdb61804
PE
1950 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1951 ../lib/careadlinkat.h.
d1fdcab7 1952
f84c17c7
SM
19532011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1954
1955 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1956 first non-nil return value).
1957
ef3862ad
JD
19582011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1959
1960 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1961 if not defined (Bug#8403).
1962
376a7006
JB
19632011-04-02 Juanma Barranquero <lekktu@gmail.com>
1964
1965 * xdisp.c (display_count_lines): Remove parameter `start',
1966 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1967 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1968 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1969 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1970 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1971 and thereabouts. All callers changed.
1972 (get_per_char_metric): Remove parameter `f', unused since
1973 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1974
6ca3801d
JM
19752011-04-02 Jim Meyering <meyering@redhat.com>
1976
1977 do not dereference NULL upon failed strdup
1978 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1979 (ns_get_family): Likewise.
1980
d8e2b5ba
JB
19812011-04-02 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1984
8c74fcbd
JD
19852011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1986
1987 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1988 later (Bug#8403).
1989
7200d79c
SM
19902011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1991
03408648 1992 Add lexical binding.
7200d79c 1993
03408648
SM
1994 * window.c (Ftemp_output_buffer_show): New fun.
1995 (Fsave_window_excursion):
1996 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1997
1998 * lread.c (lisp_file_lexically_bound_p): New function.
1999 (Fload): Bind Qlexical_binding.
2000 (readevalloop): Remove `evalfun' arg.
2001 Bind Qinternal_interpreter_environment.
2002 (Feval_buffer): Bind Qlexical_binding.
2003 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2004 Mark as dynamic.
2005 (syms_of_lread): Declare `lexical-binding'.
2006
2007 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2008
2009 * keyboard.c (eval_dyn): New fun.
2010 (menu_item_eval_property): Use it.
ca105506
SM
2011
2012 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2013
03408648
SM
2014 * fns.c (concat, mapcar1): Accept byte-code-functions.
2015
2016 * eval.c (Fsetq): Handle lexical vars.
2017 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2018 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2019 (FletX, Flet): Obey lexical binding.
2020 (Fcommandp): Handle closures.
2021 (Feval): New `lexical' arg.
2022 (eval_sub): New function extracted from Feval. Use it almost
2023 everywhere where Feval was used. Look up vars in lexical env.
2024 Handle closures.
2025 (Ffunctionp): Move from subr.el.
2026 (Ffuncall): Handle closures.
2027 (apply_lambda): Remove `eval_flags'.
2028 (funcall_lambda): Handle closures and new byte-code-functions.
2029 (Fspecial_variable_p): New function.
2030 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2031 but without exporting it to Lisp.
23aba0ea 2032
23aba0ea 2033 * doc.c (Fdocumentation, store_function_docstring):
03408648 2034 * data.c (Finteractive_form): Handle closures.
23aba0ea 2035
03408648
SM
2036 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2037 interactive spec.
ba83908c 2038
04f2d78b
CB
2039 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2040 New byte-codes.
03408648
SM
2041 (exec_byte_code): New function extracted from Fbyte_code to handle new
2042 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2043
03408648 2044 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2045
03408648 2046 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2047
e2abce01
JB
20482011-03-31 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * xdisp.c (redisplay_internal): Fix prototype.
2051
63696a73 20522011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2053
63696a73 2054 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2055 (try_scrolling): Use it when setting scroll_limit.
2056 Limit scrolling to 100 screen lines.
63696a73
EZ
2057 (redisplay_window): Even when falling back on "recentering",
2058 position point in the window according to scroll-conservatively,
2059 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2060
2061 (try_scrolling): When point is above the window, allow searching
2062 as far as scroll_max, or one screenful, to compute vertical
2063 distance from PT to the scroll margin position. This prevents
2064 try_scrolling from unnecessarily failing when
2065 scroll-conservatively is set to a value slightly larger than the
2066 window height. Clean up the case of PT below the margin at bottom
2067 of window: scroll_max can no longer be INT_MAX. When aggressive
2068 scrolling is in use, don't let point enter the opposite scroll
2069 margin as result of the scroll.
2070 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2071 threshold of 100 lines for never-recentering scrolling.
2072
e4cc2dfc
JB
20732011-03-31 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * dispextern.h (move_it_by_lines):
2076 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2077 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2078 (message_log_check_duplicate): Remove parameters `prev_bol' and
2079 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2080 (redisplay_internal): Remove parameter `preserve_echo_area',
2081 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2082
2083 * indent.c (Fvertical_motion):
2084 * window.c (window_scroll_pixel_based, Frecenter):
2085 Don't pass `need_y_p' to `move_it_by_lines'.
2086
1c470562
SM
20872011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2088
44f230aa
SM
2089 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2090 steal a few bits to be more compact.
2091 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2092 Remove unneeded casts.
2093
1c470562
SM
2094 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2095
888adce9
ZK
20962011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2097
2098 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2099 binding" message (bug#7967).
2100
f838ed7b
PE
21012011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2102
77861b95
PE
2103 Fix more problems found by GCC 4.6.0's static checks.
2104
de6dbc14
PE
2105 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2106 Remove unused local var.
2107
f838ed7b
PE
2108 * editfns.c (Fmessage_box): Remove unused local var.
2109
792c7b2b
PE
2110 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2111 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2112 Omit unused local vars.
c499e557 2113 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2114 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2115 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2116 Omit unused local var.
2117
ba0165e1
PE
2118 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2119 Don't assume string length fits in int.
32ad8845 2120 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2121 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2122
3c59b4c9
PE
2123 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2124 instead of alloca (Bug#8344).
2125
a3eed478 2126 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2127 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2128
eb4d412d
PE
2129 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2130
1658b401
PE
2131 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2132 concerns.
2133
2134 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2135
2136 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2137
9a2c6e05
PE
2138 * keyboard.c (syms_of_keyboard): Use the same style as later
2139 in this function when indexing through an array. This also
2140 works around GCC bug 48267.
2141
03d0a109
PE
2142 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2143
44f730c8
PE
2144 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2145
fe75f926
PE
2146 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2147 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2148
ffa8c828
PE
2149 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2150 This avoids undefined behavior on integer overflow, and is a bit
2151 more convenient anyway since it is compared to a size_t variable.
2152
c5101a77
PE
2153 Variadic C functions now count arguments with size_t, not int.
2154 This avoids an unnecessary limitation on 64-bit machines, which
2155 caused (substring ...) to crash on large vectors (Bug#8344).
2156 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2157 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2158 All variadic functions and their callers changed accordingly.
c5101a77
PE
2159 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2160 * data.c (arith_driver, float_arith_driver): Likewise.
2161 * editfns.c (general_insert_function): Likewise.
2162 * eval.c (struct backtrace.nargs, interactive_p)
2163 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2164 (funcall_lambda, mark_backtrace): Likewise.
2165 * fns.c (concat): Likewise.
2166 * frame.c (x_set_frame_parameters): Likewise.
2167 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2168 0 if not found, not -1. All callers changed.
2169
dd3f25f7
PE
2170 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2171 (stack_copy_size): Now size_t, not int.
2172 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2173
461c2ab9
JB
21742011-03-28 Juanma Barranquero <lekktu@gmail.com>
2175
2176 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2177 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2178 All callers changed.
2179
2180 * lisp.h (multibyte_char_to_unibyte):
2181 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2182 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2183 * character.h (CHAR_TO_BYTE8):
2184 * cmds.c (internal_self_insert):
2185 * editfns.c (general_insert_function):
2186 * keymap.c (push_key_description):
2187 * search.c (Freplace_match):
2188 * xdisp.c (message_dolog, set_message_1): All callers changed.
2189
f6d62986
SM
21902011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2191
2192 * keyboard.c (safe_run_hook_funcall): New function.
2193 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2194 don't set the hook to nil, but remove the offending function instead.
2195 (Qcommand_hook_internal): Remove, unused.
2196 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2197 Vcommand_hook_internal.
2198
2199 * eval.c (enum run_hooks_condition): Remove.
2200 (funcall_nil, funcall_not): New functions.
2201 (run_hook_with_args): Call each function through a `funcall' argument.
2202 Remove `cond' argument, now redundant.
2203 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2204 (Frun_hook_with_args_until_failure): Adjust accordingly.
2205 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2206
1db5b1ad
JB
22072011-03-28 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * dispextern.h (string_buffer_position): Remove declaration.
2210
2211 * print.c (strout): Remove parameter `multibyte', unused since
2212 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2213
2214 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2215 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2216 All callers changed.
2217
2218 * w32.c (_wsa_errlist): Use braces for struct initializers.
2219
2220 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2221 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2222 All callers changed.
2223 (string_buffer_position): Likewise. Also, make static (it's never
2224 used outside xdisp.c).
2225 (cursor_row_p): Remove parameter `w', unused since
2226 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2227 (decode_mode_spec): Remove parameter `precision', introduced during
2228 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2229 All callers changed.
2230
5ffb62aa
JD
22312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2232
2233 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2234
461c2ab9 22352011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2236
2237 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2238 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2239 (ns_update_auto_hide_menu_bar): New functions.
2240 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2241 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2242 ns_constrain_all_frames.
2243 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2244 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2245
5c380ffb
JD
22462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2247
2248 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2249
9af30bdf
GM
22502011-03-27 Glenn Morris <rgm@gnu.org>
2251
2252 * syssignal.h: Replace RETSIGTYPE with void.
2253 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2254 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2255 Replace SIGTYPE with void everywhere.
2256 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2257 * s/template.h (SIGTYPE): Remove commented out definition.
2258
e2abce01
JB
22592011-03-26 Eli Zaretskii <eliz@gnu.org>
2260
2261 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2262 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2263
f868cd8a
JB
22642011-03-26 Juanma Barranquero <lekktu@gmail.com>
2265
59eb0929
JB
2266 * w32.c (read_unc_volume): Use parameter `henum', instead of
2267 global variable `wget_enum_handle'.
2268
2269 * keymap.c (describe_vector): Remove parameters `indices' and
2270 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2271 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2272
f868cd8a
JB
2273 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2274
2275 * keyboard.c (timer_check): Remove parameter `do_it_now',
2276 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2277 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2278 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2279
2280 * keyboard.c (read_char):
2281 * w32menu.c (w32_menu_display_help):
2282 * xmenu.c (show_help_event, menu_help_callback):
2283 Adjust calls to `show_help_echo'.
2284
2285 * gtkutil.c (xg_maybe_add_timer):
2286 * keyboard.c (readable_events):
2287 * process.c (wait_reading_process_output):
2288 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2289
2290 * insdel.c (adjust_markers_gap_motion):
2291 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2292 (gap_left, gap_right): Don't call it.
2293
2ecf6fdb
CY
22942011-03-25 Chong Yidong <cyd@stupidchicken.com>
2295
2296 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2297 incurred during fontification.
2298
6b1f9ba4
JB
22992011-03-25 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2302 (DEFVAR_PER_BUFFER): Don't pass it.
2303
2304 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2305 (scrolling_window): Don't pass it.
2306
0f4a96b5
JB
23072011-03-25 Juanma Barranquero <lekktu@gmail.com>
2308
2309 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2310
2311 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2312 and `suffix'.
2313 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2314 of variables specific to SELinux and computation of `encoded_absname'.
2315
2316 * image.c (XPutPixel): Remove unused variable `height'.
2317
2318 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2319
2320 * unexw32.c (get_section_info): Remove unused variable `section'.
2321
2322 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2323 (system_process_attributes): Remove unused variable `sess'.
2324 (sys_read): Remove unused variable `err'.
2325
2326 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2327 (w32_wnd_proc): Remove unused variable `isdead'.
2328 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2329 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2330 (x_create_tip_frame): Remove unused variable `tem'.
2331
2332 * w32inevt.c (w32_console_read_socket):
2333 Remove unused variable `no_events'.
2334
2335 * w32term.c (x_draw_composite_glyph_string_foreground):
2336 Remove unused variable `width'.
2337
1149507c
JB
23382011-03-24 Juanma Barranquero <lekktu@gmail.com>
2339
2340 * w32term.c (x_set_glyph_string_clipping):
2341 Don't pass uninitialized region to CombineRgn.
2342
9c88f339
JB
23432011-03-23 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2346 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2347 (Fx_close_connection): Remove unused variable `i'.
2348
2349 * w32font.c (w32font_draw): Return number of glyphs.
2350 (w32font_open_internal): Remove unused variable `i'.
2351 (w32font_driver): Add missing initializer.
2352
2353 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2354 (fill_in_menu): Remove unused variable `items_added'.
2355
2356 * w32term.c (last_mouse_press_frame): Remove static global variable.
2357 (w32_clip_to_row): Remove unused variable `f'.
2358 (x_delete_terminal): Remove unused variable `i'.
2359
2360 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2361 (NOTHING): Remove unused static global variable.
2362 (uniscribe_check_otf): Remove unused variable `table'.
2363 (uniscribe_font_driver): Add missing initializers.
2364
dee091a3
JD
23652011-03-23 Julien Danjou <julien@danjou.info>
2366
2367 * term.c (Fsuspend_tty, Fresume_tty):
2368 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2369 * window.c (temp_output_buffer_show):
2370 * insdel.c (signal_before_change):
2371 * frame.c (Fhandle_switch_frame):
2372 * fileio.c (Fdo_auto_save):
2373 * emacs.c (Fkill_emacs):
2374 * editfns.c (save_excursion_restore):
2375 * cmds.c (internal_self_insert):
2376 * callint.c (Fcall_interactively):
2377 * buffer.c (Fkill_all_local_variables):
2378 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2379 Use Frun_hooks.
0f4a96b5 2380 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2381 unconditionnaly since it does the check itself.
2382
2c520ab5 23832011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2384
c9c49752
PE
2385 Fix more problems found by GCC 4.5.2's static checks.
2386
8abc3f12
PE
2387 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2388 the first time through the loop, since we know p0 < p1 then.
2389 This also avoids a gcc -Wstrict-overflow warning.
2390
a2d26660
PE
2391 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2392 leading to a memory leak, possible in functions like
2393 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2394 of objects (Bug#8318).
a2d26660 2395
916c72e9
PE
2396 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2397 that could (at least in theory) be that large.
2398
19ab8a18
PE
2399 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2400 This is less likely to overflow, and avoids undefined behavior if
2401 overflow does occur. All callers changed. Use strtoul to scan
2402 for the unsigned long integer.
b7cbbd6f
PE
2403 (pint2hrstr): Simplify and tune code slightly.
2404 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2405
f0641eff
PE
2406 * scroll.c (do_scrolling): Work around GCC bug 48228.
2407 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2408
7f650bb9
PE
2409 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2410 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2411 (validate_x_resource_name): Simplify count usage.
2412 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2413
37dd57d1
PE
2414 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2415 fail (Bug#8306).
81e56e61 2416
699979fc 2417 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2418
401bf9b4
PE
2419 * process.c (Fmake_network_process): Use socklen_t, not int,
2420 where POSIX says socklen_t is required in portable programs.
2421 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2422 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2423 (Fmake_network_process, server_accept_connection):
2424 (wait_reading_process_output, read_process_output):
2425 Likewise.
2426
b93aacde
PE
2427 * process.c: Rename or move locals to avoid shadowing.
2428 (list_processes_1, Fmake_network_process):
2429 (read_process_output_error_handler, exec_sentinel_error_handler):
2430 Rename or move locals.
4dc343ee 2431 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2432 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2433 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2434 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2435 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2436
af8a867c 2437 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2438 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2439 Include tparam.h instead, since it declares them.
af8a867c
PE
2440 * cm.h (PC): Remove extern decl; tparam.h now does this.
2441 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2442 * terminfo.c: Include tparam.h, to check interfaces.
2443 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2444 (tparam): Adjust signature to match interface in tparam.h;
2445 this removes some undefined behavior. Check that outstring and len
2446 are zero, which they always are with Emacs.
2447 * tparam.h (PC, BC, UP): New extern decls.
2448
0248044d 2449 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2450 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2451
8ff096c1 2452 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2453 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2454 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2455 (ftfont_list): Remove unused local.
49eaafba
PE
2456 (get_adstyle_property, ftfont_pattern_entity):
2457 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2458 Rename locals to avoid shadowing.
8ff096c1 2459
e2be39f6
PE
2460 * xfont.c (xfont_list_family): Mark var as initialized.
2461
c9735e30
PE
2462 * xml.c (make_dom): Now static.
2463
8f5201ae
PE
2464 * composite.c (composition_compute_stop_pos): Rename local to
2465 avoid shadowing.
b246f932
PE
2466 (composition_reseat_it): Remove unused locals.
2467 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2468 (composition_update_it): Mark var as initialized.
11b61122
PE
2469 (find_automatic_composition): Mark vars as initialized,
2470 with a FIXME (Bug#8290).
8f5201ae 2471
760fbc2c
PE
2472 character.h: Rename locals to avoid shadowing.
2473 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2474 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2475 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2476 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2477 to avoid shadowing.
2478
ff08eb85
PE
2479 * textprop.c (property_change_between_p): Remove; unused.
2480
fc7bf025
PE
2481 * intervals.c (interval_start_pos): Now static.
2482
235d7abc
PE
2483 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2484
44f230aa
SM
2485 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2486 Rename locals to avoid shadowing.
3e7d6594 2487
50060332
PE
2488 * sound.c (wav_play, au_play, Fplay_sound_internal):
2489 Fix pointer signedness.
d01f234b 2490 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2491 (wav_play): Initialize a variable to 0, to prevent undefined
2492 behavior (Bug#8278).
50060332 2493
c4fc4e30
PE
2494 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2495
918436ed
PE
2496 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2497
c939f91b
PE
2498 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2499 clobbering (Bug#8298).
b9c7f648
PE
2500 * sysdep.c (sys_subshell): Likewise.
2501 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2502
6bd8c144
PE
2503 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2504 This should get cleaned up, so that child_setup has the
2505 same signature on all platforms.
2506
7710357c 2507 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2508 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2509
c59da222
CY
25102011-03-22 Chong Yidong <cyd@stupidchicken.com>
2511
2512 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2513 not to be necessary, and produces flickering.
2514
66b87493
GM
25152011-03-20 Glenn Morris <rgm@gnu.org>
2516
2517 * config.in: Remove file.
2518
45b6f6d5
JB
25192011-03-20 Juanma Barranquero <lekktu@gmail.com>
2520
2521 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2522 are now in src/globals.h.
2523 (syms_of_minibuf): Remove spurious & from previous change.
2524
3ec03f7e
LL
25252011-03-20 Leo <sdl.web@gmail.com>
2526
2527 * minibuf.c (completing-read-function): New variable.
2528 (completing-read-default): Rename from completing-read.
2529 (completing-read): Call completing-read-function.
2530
b14e3e21
CY
25312011-03-19 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * xfaces.c (Fx_load_color_file):
2534 Read color file from absolute filename (bug#8250).
2535
f2b726e6
JB
25362011-03-19 Juanma Barranquero <lekktu@gmail.com>
2537
2538 * makefile.w32-in: Update dependencies.
2539
09f6ff02
EZ
25402011-03-17 Eli Zaretskii <eliz@gnu.org>
2541
2542 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2543
29a6015a
PE
25442011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2545
a3a6c54e
PE
2546 Fix more problems found by GCC 4.5.2's static checks.
2547
b766f867
PE
2548 * process.c (make_serial_process_unwind, send_process_trap):
2549 (sigchld_handler): Now static.
2550
be02381c
PE
2551 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2552 That way, the code declares only the vars that it needs.
2553 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2554 * s/cygwin.h (PTY_ITERATION): Likewise.
2555 * s/darwin.h (PTY_ITERATION): Likewise.
2556 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2557
57048744
PE
2558 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2559 * process.c (allocate_pty): Don't declare stb unless it's needed.
2560
7914961c 2561 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2562 (CONSTANTLIM): Remove; unused.
2563 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2564 Define only if needed.
7914961c 2565
b3967b18
PE
2566 * unexelf.c (unexec): Name an expression,
2567 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2568 Use a different way to cause a compilation error if anyone uses
2569 n rather than nn, a way that does not involve shadowing.
73366a00 2570 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2571
29a6015a
PE
2572 * deps.mk (unexalpha.o): Remove; unused.
2573
43cfc33e 2574 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2575 * unexec.h: New file.
ce701a33
PE
2576 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2577 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2578 Depend on unexec.h.
2579 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2580 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2581 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2582 Change as necessary to match prototype in unexec.h.
ce701a33 2583
01f44d5a
PE
2584 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2585 shadowing.
4f63c6bb 2586 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2587
a6670b0b
PE
2588 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2589 Rename locals to avoid shadowing.
2590
cef2010d 2591 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2592 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2593
d4d7173a
PE
2594 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2595
f08b802a
PE
2596 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2597 warning when compiling print.c.
2598
3ddb0639
PE
2599 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2600 instead of using an uninitialized var.
5ad03b97 2601 (font_sort_entities): Mark var as initialized.
3ddb0639 2602
170a2692
PE
2603 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2604
e663c700
PE
2605 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2606 pointers to constants.
89bc529a 2607 (font_parse_fcname): Remove unused vars.
7b81e2d0 2608 (font_delete_unmatched): Now static.
ea838e10 2609 (font_get_spec): Remove; unused.
13a547c6
PE
2610 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2611 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2612 Rename or move locals to avoid shadowing.
e663c700 2613
2a80c887 2614 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2615 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2616
1384fa33 2617 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2618 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2619
8b2c52e9
PE
2620 * alloc.c (mark_backtrace): Move decl from here ...
2621 * lisp.h: ... to here, so that it can be checked.
2622
475545b5 2623 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2624 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2625 (lisp_indirect_variable): Name an expression,
2626 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2627 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2628
b1349114 2629 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2630 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2631 Use const pointer when appropriate.
b1349114 2632
a2928364
PE
2633 * lisp.h (get_system_name, get_operating_system_release):
2634 Move decls here, to check interfaces.
2635 * process.c (get_operating_system_release): Move decl to lisp.h.
2636 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2637 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2638 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2639 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2640 (Fformat_time_string, Fencode_time, Finsert_char):
2641 (Ftranslate_region_internal, Fformat):
2642 Rename or remove local vars to avoid shadowing.
9710023e 2643 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2644
a415e694
PE
2645 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2646 avoid shadowing.
2647
8ef4622d
PE
2648 * lisp.h (eassert): Check that the argument compiles, even if
2649 ENABLE_CHECKING is not defined.
2650
946f9a5b
PE
2651 * data.c (Findirect_variable): Name an expression, to avoid
2652 gcc -Wbad-function-cast warning.
112396d6 2653 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2654 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2655 (Fmake_variable_buffer_local, Fmake_local_variable):
2656 Mark variables as initialized.
52746918 2657 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2658
e5aab7e7 2659 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2660 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2661 Rename locals to avoid shadowing.
dff45157
PE
2662 (mark_stack): Move local variables into the #ifdef region where
2663 they're used.
7bc26fdb
PE
2664 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2665 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2666 needed otherwise.
2667 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2668 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2669 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2670
e5aab7e7
PE
2671 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2672 avoids undefined behavior in theory.
2673
4da60324
PE
2674 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2675
88043301
PE
2676 Use functions, not macros, for up- and down-casing (Bug#8254).
2677 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2678 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2679 to use the following functions instead of these macros.
2680 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2681 EMACS_INT, since callers assume the returned value fits in int.
2682 (upcase1): Likewise, for UPCASE_TABLE.
2683 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2684 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2685 the race-condition problem in the old DOWNCASE.
88043301 2686
19ed5445
PE
2687 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2688 Rename locals to avoid shadowing.
2689 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2690 (regex_compile, re_search_2, re_match_2_internal):
2691 Remove unused local vars.
952db0d7
PE
2692 (FREE_VAR): Rewrite so as not to use empty "else",
2693 which gcc can warn about.
da053e48 2694 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2695 (RETALLOC_IF): Define only if needed.
2696 (WORDCHAR_P): Likewise. This one is never needed, but is used
2697 only in a comment talking about a compiler bug, so put inside
2698 the #if 0 of that comment.
2699 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2700 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2701 Remove; unused.
19ed5445 2702
1f3561e4 2703 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2704 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2705 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2706
ded6f8f7
PE
2707 * search.c (simple_search): Remove unused var.
2708
dbd37a95
PE
2709 * dired.c (compile_pattern): Move decl from here ...
2710 * lisp.h: ... to here, so that it can be checked.
2711 (struct re_registers): New forward decl.
2712
7e47afad
PE
2713 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2714
85f24f61
PE
2715 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2716 All uses changed.
2717 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2718 Rename locals to avoid shadowing.
5671df8f 2719 (Fvertical_motion): Mark locals as initialized.
85f24f61 2720
181aa2be 2721 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2722 (casify_region): Mark local as initialized.
181aa2be 2723
930d429c
PE
2724 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2725
7082eac6
PE
2726 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2727 New macros, so that the caller can use some names other than
2728 gcpro1, gcpro2, etc.
2729 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2730 of the new macros.
2731 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2732 argument, for consistency with GCPRO2_VAR, etc: it is now the
2733 prefix of the variable, not the variable itself. All uses
2734 changed.
38b2c076
PE
2735 * dired.c (directory_files_internal, file_name_completion):
2736 Rename locals to avoid shadowing.
2737
15206ed9
PE
2738 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2739 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2740 dired.c's scmp function, had undefined behavior.
2741 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2742 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2743 * buffer.h: ... to here, because these macros use current_buffer,
2744 and the new implementation with inline functions needs to have
2745 current_buffer in scope now, rather than later when the macros
2746 are used.
2747 (downcase, upcase1): New static inline functions.
2748 (DOWNCASE, UPCASE1): Reimplement using these functions.
2749 This avoids undefined behavior in expressions like
2750 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2751 from race conditions in accessing the global variables
2752 case_temp1 and case_temp2.
2753 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2754 * lisp.h (case_temp1, case_temp2): Remove their decls.
2755 * character.h (ASCII_CHAR_P): Move from here ...
2756 * lisp.h: ... to here, so that the inline functions mentioned
2757 above can use them.
2758
4a6bea26
PE
2759 * dired.c (directory_files_internal_unwind): Now static.
2760
f14b7e14
PE
2761 * fileio.c (file_name_as_directory, directory_file_name):
2762 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2763 Now static.
2893f146
PE
2764 (file_name_as_directory): Use const pointers when appropriate.
2765 (Fexpand_file_name): Likewise. In particular, newdir might
2766 point at constant storage, so make it a const pointer.
fd4ead52 2767 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2768 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2769 signedness issues.
f839df0c
PE
2770 (Fset_file_times, Finsert_file_contents, auto_save_error):
2771 Rename locals to avoid shadowing.
f14b7e14 2772
5716756e 2773 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2774 (Ftry_completion, Fall_completions): Rename or remove locals
2775 to avoid shadowing.
5716756e 2776
b4c3046a
PE
2777 * marker.c (bytepos_to_charpos): Remove; unused.
2778
b45db522
PE
2779 * lisp.h (verify_bytepos, count_markers): New decls,
2780 so that gcc does not warn that these functions aren't declared.
2781
85876d07
PE
2782 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2783 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2784 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2785 (copy_text): Remove unused local var.
85876d07 2786
03d78a21 2787 * filelock.c (within_one_second): Now static.
b3dd38ab 2788 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2789
5df8f01b
PE
2790 * buffer.c (fix_overlays_before): Mark locals as initialized.
2791 (fix_start_end_in_overlays): Likewise. This function should be
2792 simplified by using pointers-to-pointers, but that's a different
2793 matter.
b1d876f1 2794 (switch_to_buffer_1): Now static.
8f54f30a
PE
2795 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2796 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2797
a70072c9 2798 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2799 Fix pointer signedness issue.
edced198
PE
2800 (sys_subshell): Mark local as volatile if checking for lint,
2801 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2802 (MAXPATHLEN): Define only if needed.
a70072c9 2803
a0977c44
PE
2804 * process.c (serial_open, serial_configure): Move decls from here ...
2805 * systty.h: ... to here, so that they can be checked.
2806
a884fdcc
PE
2807 * fns.c (get_random, seed_random): Move extern decls from here ...
2808 * lisp.h: ... to here, so that they can be checked.
2809
604efe86 2810 * sysdep.c (reset_io): Now static.
b8950c94 2811 (wait_for_termination_signal): Remove; unused.
604efe86 2812
38fc62d9
PE
2813 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2814 (copy_keymap_item, append_key, push_text_char_description):
2815 Now static.
1004a21a 2816 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2817 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2818 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2819 (describe_map_tree):
2820 Rename locals to avoid shadowing.
38fc62d9 2821
2f2650da
PE
2822 * keyboard.c: Declare functions static if they are not used elsewhere.
2823 (echo_char, echo_dash, cmd_error, top_level_2):
2824 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2825 (read_char, kbd_buffer_get_event, make_lispy_position):
2826 (make_lispy_event, make_lispy_movement, apply_modifiers):
2827 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2828 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2829 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2830 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2831 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2832
a053e86c 2833 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2834 (mark_kboards): Move decl here ...
2835 * alloc.c (mark_kboards): ... from here.
a053e86c 2836
4752793e
PE
2837 * lisp.h (force_auto_save_soon): New decl.
2838
74f10ca7 2839 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2840 (DEFINE_DUMMY_FUNCTION): New macro.
2841 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2842 Use it.
c03cd23f
PE
2843 (main): Add casts to avoid warnings
2844 if GCC considers string literals to be constants.
74f10ca7 2845
022e70d4
PE
2846 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2847
59d6fe83
PE
2848 * dbusbind.c: Pointer signedness fixes.
2849 (xd_signature, xd_append_arg, xd_initialize):
2850 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2851 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2852 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2853 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2854
78320123
PE
2855 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2856 if GCC considers string literals to be constants.
49cebcca 2857 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2858
35ac2a97
SM
28592011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2860
fb103ca9
SM
2861 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2862 (print_preprocess, print_object): New macro to fix last change.
2863
35ac2a97
SM
2864 * print.c (print_preprocess): Don't forget font objects.
2865
62973b41
JB
28662011-03-16 Juanma Barranquero <lekktu@gmail.com>
2867
2868 * emacs.c (USAGE3): Doc fixes.
2869
0e48bb22
AS
28702011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2871
2872 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2873 structure.
2874
7684e57b
JB
28752011-03-14 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * lisp.h (VWindow_system, Qfile_name_history):
2878 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2879 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2880 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2881
2882 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2883 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2884
2885 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2886 * w32console.c (detect_input_pending, read_input_pending)
2887 (encode_terminal_code):
2888 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2889 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2890 (w32_system_caret_y, Qfile_name_history):
2891 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2892 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2893 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2894 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2895 * w32proc.c (Qlocal, report_file_error):
2896 * w32term.c (Vwindow_system, updating_frame):
2897 * w32uniscribe.c (initialized, uniscribe_font_driver):
2898 Remove unneeded extern declarations.
2899
2aa46d6c
CY
29002011-03-14 Chong Yidong <cyd@stupidchicken.com>
2901
c96bbc66 2902 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2903
cffc6f3b
CY
29042011-03-13 Chong Yidong <cyd@stupidchicken.com>
2905
2906 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2907 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2908 These macros can no longer be used for assignment.
2909
44f230aa
SM
2910 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2911 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2912 (record_buffer_markers, fetch_buffer_markers): New functions for
2913 recording and fetching special buffer markers.
2914 (set_buffer_internal_1, set_buffer_temp): Use them.
2915
2916 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2917
2918 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2919
2920 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2921 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2922
2923 * xdisp.c (hscroll_window_tree):
2924 (reconsider_clip_changes): Use PT instead of BUF_PT.
2925
d251f04b
EZ
29262011-03-13 Eli Zaretskii <eliz@gnu.org>
2927
2928 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2929 $(EMACS_ROOT)/lib/intprops.h.
2930
f0c77cd1
PE
29312011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2932
3eca4629
PE
2933 Fix more problems found by GCC 4.5.2's static checks.
2934
7c86ee98
PE
2935 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2936 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2937 (xg_free_frame_widgets): Make it clear that a local variable is
2938 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2939 (gdk_window_get_screen): Make it clear that this macro is needed
2940 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2941 (int_gtk_range_get_value): New function, which avoids a diagnostic
2942 from gcc -Wbad-function-cast.
2943 (xg_set_toolkit_scroll_bar_thumb): Use it.
2944 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2945 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2946 (get_utf8_string, xg_get_file_with_chooser):
2947 Rename locals to avoid shadowing.
2948 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2949
41729b81
PE
2950 * xgselect.c (xg_select): Remove unused var.
2951
f0c77cd1
PE
2952 * image.c (four_corners_best): Mark locals as initialized.
2953 (gif_load): Initialize transparent_p to zero (Bug#8238).
2954 Mark another local as initialized.
ec6cf4c6 2955 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2956
ce0ad53d 2957 * image.c (clear_image_cache): Now static.
d5d5a617 2958 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2959 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2960 (x_edge_detection): Remove unnecessary cast that
2961 gcc -Wbad-function-cast diagnoses.
2037898d 2962 (gif_load): Fix pointer signedness.
6ae141d6
PE
2963 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2964 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2965
33383987 29662011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2967
d32df629
PE
2968 Improve quality of tests for time stamp overflow.
2969 For example, without this patch (encode-time 0 0 0 1 1
2970 1152921504606846976) returns the obviously-bogus value (-948597
2971 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2972 reports time overflow. See
2973 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2974 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2975 * editfns.c: Include limits.h and intprops.h.
2976 (TIME_T_MIN, TIME_T_MAX): New macros.
2977 (time_overflow): Move earlier, to before first use.
2978 (hi_time, lo_time): New functions, for an accurate test for
2979 out-of-range times.
2980 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2981 (Fget_internal_run_time): Don't assume time_t fits in int.
2982 (make_time): Use list2 instead of Fcons twice.
2983 (Fdecode_time): More accurate test for out-of-range times.
2984 (check_tm_member): New function.
2985 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2986 (lisp_time_argument): Don't rely on undefined left-shift and
2987 right-shift behavior when checking for time stamp overflow.
8be6f318 2988
fe31d94c
PE
2989 * editfns.c (time_overflow): New function, refactoring common code.
2990 (Fformat_time_string, Fdecode_time, Fencode_time):
2991 (Fcurrent_time_string): Use it.
2992
8be6f318
PE
2993 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2994 * dired.c (make_time): Move to ...
2995 * editfns.c (make_time): ... here.
2996 * systime.h: Note the move.
2997
09d9db2c 29982011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2999
126bc0dc
YM
3000 * fringe.c (update_window_fringes): Remove unused variables.
3001
c47cbdfd
YM
3002 * unexmacosx.c (copy_data_segment): Also copy __got section.
3003 (Bug#8223)
3004
7ac80be9
EZ
30052011-03-12 Eli Zaretskii <eliz@gnu.org>
3006
c96bbc66 3007 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3008 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3009 Constify `char *' arguments and their references according to
3010 prototypes in tparam.h.
3011
ecb0f94d 3012 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3013
7ac80be9
EZ
3014 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3015 Adapt all references accordingly.
3016
3017 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3018
ef1fd07e
TT
30192011-03-11 Tom Tromey <tromey@redhat.com>
3020
3021 * buffer.c (syms_of_buffer): Remove obsolete comment.
3022
7ef4b50c
EZ
30232011-03-11 Eli Zaretskii <eliz@gnu.org>
3024
3025 * termhooks.h (encode_terminal_code): Declare prototype.
3026
3027 * msdos.c (encode_terminal_code): Don't declare prototype.
3028
3029 * term.c (encode_terminal_code): Now external again, used by
3030 w32console.c and msdos.c.
3031
44f230aa
SM
3032 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3033 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3034
4b1ec863 30352011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3036
1714f52b 3037 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3038
4b1ec863
PE
3039 * fringe.c (update_window_fringes): Mark locals as initialized
3040 (Bug#8227).
3041 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3042
524c7aa6
PE
3043 * alloc.c (mark_fringe_data): Move decl from here ...
3044 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3045 to check its interface.
3046 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3047
a5c0af81 3048 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3049 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3050 (fontset_font): Mark local as initialized.
a9a06e0b 3051 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3052
b4716021
PE
3053 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3054
811e9bac 3055 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3056 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3057 (x_own_selection, Fx_disown_selection_internal): Rename locals
3058 to avoid shadowing.
3059 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3060
7e3ab302
PE
3061 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3062 so that the caller can use some name other than gcpro1.
3063 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3064 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3065 (Fx_backspace_delete_keys_p):
3066 Use them to avoid shadowing, and rename vars to avoid shadowing.
3067 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3068 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3069 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3070 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3071 Remove unused locals.
7e3ab302
PE
3072 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3073 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3074 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3075 macros.
f78faa98 3076
e2b13473
PE
3077 * xterm.h (x_mouse_leave): New decl.
3078
77f23912
PE
3079 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3080 Remove unused functions.
cdf4ba58
PE
3081 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3082 (x_calc_absolute_position): Now static.
7411c686 3083 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3084 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3085 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3086 unless they are used.
38d0b34a
PE
3087 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3088 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3089 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3090 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3091 (x_error_catcher, x_connection_closed, x_error_handler):
3092 (x_error_quitter, xembed_send_message, x_iconify_frame):
3093 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3094 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3095 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3096
44f230aa
SM
3097 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3098 Rename or move locals to avoid shadowing.
6b463e58 3099 (tty_defined_color, merge_face_heights): Now static.
5967d051 3100 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3101 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3102 does not deduce is never used uninitialized.
73719eba
PE
3103 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3104 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3105
426994c3 3106 * terminal.c (store_terminal_param): Now static.
5489860b 3107
032f1620 3108 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3109 (set_frame_menubar): Remove unused local.
d4323972 3110 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3111 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3112 since they might point to immutable storage.
281585b0
PE
3113 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3114 since it's unused otherwise.
032f1620 3115
367c19e5 3116 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3117 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3118 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3119 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3120 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3121 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3122 does not deduce are never used uninitialized.
70739cbe 3123
07b48fa9
PE
3124 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3125
8868a238 3126 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3127 * window.c (window_loop, size_window):
3128 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3129
7e5cf297 3130 * window.c (display_buffer): Now static.
d6550a9f
PE
3131 (size_window): Mark variables that gcc -Wuninitialized
3132 does not deduce are never used uninitialized.
a586633d
PE
3133 * window.h (check_all_windows): New decl, to forestall
3134 gcc -Wmissing-prototypes diagnostic.
5b555da1 3135 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3136
f6095868
PE
3137 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3138 shadowing.
3139 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3140 Include <limits.h>.
3141 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3142 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3143 (load_charset_map): Mark variables that gcc -Wuninitialized
3144 does not deduce are never used uninitialized.
53df7c11 3145 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3146
f38b440c
PE
3147 * coding.c (coding_set_source, coding_set_destination):
3148 Use "else { /* comment */ }" rather than "else /* comment */;"
3149 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3150 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3151 a block, when the outer 'i' will do.
3152 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3153 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3154 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3155 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3156 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3157 Rename locals to avoid shadowing.
3158 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3159 * coding.c (emacs_mule_char, encode_invocation_designation):
3160 Now static, since they're not used elsewhere.
413bb2db 3161 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3162 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3163 (decode_coding_emacs_mule): Mark variables that gcc
3164 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3165 (detect_coding_iso_2022): Initialize a local variable that might
3166 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3167 this initialization is needed. (Bug#8211)
5f58e762
PE
3168 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3169 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3170 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3171 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3172 Remove unused macros.
f38b440c 3173
232b38b9 3174 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3175 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3176 * character.c (string_count_byte8): Likewise.
232b38b9 3177
fb90da1b
PE
3178 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3179 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3180
fb93dbc2
PE
3181 * chartab.c (copy_sub_char_table): Now static, since it's not used
3182 elsewhere.
5c156ace
PE
3183 (sub_char_table_ref_and_range, char_table_ref_and_range):
3184 Rename locals to avoid shadowing.
bbcd0949 3185 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3186
7d3b3862 3187 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3188 (BIDI_BOB): Remove unused macro.
7d3b3862 3189
6be7d3da
PE
3190 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3191 deduce are never used uninitialized.
c2ed9c8b 3192 * term.c (encode_terminal_code): Likewise.
6be7d3da 3193
75f8807f 3194 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3195
50938595
PE
3196 * tparam.h: New file.
3197 * term.c, tparam.h: Include it.
3198 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3199 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3200 Move these decls to tparam.h, and make them agree with what
3201 is actually in tparam.c. The previous trick of using incompatible
3202 decls in different modules does not conform to the C standard.
3203 All callers of tparam changed to use tparam's actual API.
3204 * tparam.c (tparam1, tparam, tgoto):
3205 Use const pointers where appropriate.
3206
fbceeba2
PE
3207 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3208 * cm.h (struct cm): Likewise.
3209 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3210 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3211 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3212 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3213 (turn_on_face, init_tty): Likewise.
3214 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3215
7f3f1250
PE
3216 * term.c (term_mouse_position): Rename local to avoid shadowing.
3217
e6ca6543
PE
3218 * alloc.c (mark_ttys): Move decl from here ...
3219 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3220
c40f8d15
AS
32212011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3222
3223 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3224
cfe0661d
JB
32252011-03-09 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * search.c (compile_pattern_1): Remove argument regp, unused since
3228 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3229 (compile_pattern): Don't pass it.
3230
0afb4571
J
32312011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3232
3233 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3234 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3235 for ! HAVE_GTK3.
3236 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3237
3238 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3239
3240 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3241 gdk_window_get_screen, gdk_window_get_geometry,
3242 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3243 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3244 (xg_get_pixbuf_from_pixmap): New function.
3245 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3246 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3247 Call xg_get_pixbuf_from_pixmap instead of
3248 gdk_pixbuf_get_from_drawable.
3249 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3250 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3251 (xg_check_special_colors): Use GtkStyleContext and its functions
3252 for HAVE_GTK3.
3253 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3254 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3255 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3256 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3257 Call gtk_widget_get_preferred_size.
0afb4571
J
3258 (xg_frame_resized): gdk_window_get_geometry only takes 5
3259 parameters.
44f230aa
SM
3260 (xg_win_to_widget, xg_event_is_for_menubar):
3261 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3262 (xg_set_widget_bg): New function.
3263 (delete_cb): New function.
895009e1 3264 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3265 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3266 (xg_set_background_color): Call xg_set_widget_bg.
3267 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3268 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3269 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3270 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3271 if ! HAVE_GTK3.
3272 (update_frame_tool_bar): Call gtk_widget_hide.
3273 (xg_initialize): Use GDK_KEY_g.
3274
3275 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3276 if ! HAVE_GTK3
3277 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3278
3279 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3280 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3281 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3282
1c2cc4ef
JB
32832011-03-08 Juanma Barranquero <lekktu@gmail.com>
3284
3285 * w32xfns.c (select_palette): Check success of RealizePalette against
3286 GDI_ERROR, not zero.
3287
33383987 3288See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3289
3290;; Local Variables:
3291;; coding: utf-8
aac0c6e3
MR
3292;; End:
3293
33383987 3294 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3295
3296 This file is part of GNU Emacs.
3297
3298 GNU Emacs is free software: you can redistribute it and/or modify
3299 it under the terms of the GNU General Public License as published by
3300 the Free Software Foundation, either version 3 of the License, or
3301 (at your option) any later version.
3302
3303 GNU Emacs is distributed in the hope that it will be useful,
3304 but WITHOUT ANY WARRANTY; without even the implied warranty of
3305 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3306 GNU General Public License for more details.
3307
3308 You should have received a copy of the GNU General Public License
3309 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.