Fix highlight-regexp's use of Font Lock mode.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f48b82fd
GR
12012-08-14 Gergely Risko <gergely@risko.hu>
2
3 * coding.c (decode_coding): Record buffer modification before
4 disabling undo_list (Bug#11773).
5
fd318b54
DA
62012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Revert and cleanup some recent overlay changes.
9 * buffer.h (enum overlay_type): Remove.
10 (buffer_get_overlays, buffer_set_overlays): Likewise.
11 (buffer_set_overlays_before, buffer_set_overlays_after):
12 New function. Adjust users.
13 (unchain_both): Add eassert.
14
41a62dd9
DA
152012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
16
17 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
18
5884c324
PE
192012-08-14 Paul Eggert <eggert@cs.ucla.edu>
20
21 * gtkutil.c (xg_mark_data): Don't assume C99.
22
ca06f160
JD
232012-08-13 Jan Djärv <jan.h.d@swipnet.se>
24
25 * gtkutil.c (xg_frame_tb_info): New struct.
26 (TB_INFO_KEY): New define.
27 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
28 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
29 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
30 if not present.
31 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
32 is up to date. Otherwise store new data.
33 (free_frame_tool_bar): Free xg_frame_tb_info if present.
34
7864a3f7
DA
352012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
36
37 Use KSET for write access to Lisp_Object members of struct kboard.
38 * keyboard.h (KSET): New macro.
39 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
40 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
41 * xterm.c: Adjust users.
42
4c31be61
DA
432012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
44
45 Use BSET for write access to Lisp_Object members of struct buffer.
46 * buffer.h (BSET): New macro.
47 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
48 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
49 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
50 * window.c, xdisp.c, xfns.c: Adjust users.
51
14ae4239
BT
522012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
53
54 * lread.c (syms_of_lread): Initialize Vlexical_binding.
55
32bcadb4
JD
562012-08-11 Jan Djärv <jan.h.d@swipnet.se>
57
3d29b2ce
JD
58 * nsterm.m (not_in_argv): New function.
59 (application:openFile, application:openTempFile:):
60 (application:openFileWithoutUI:, application:openFiles:): Open file
61 if not_in_argv returns non-zero (bug#12171).
62
32bcadb4 63 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
64 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
65 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
66 (xg_get_font_name): Use those functions/macros here.
67 Reported by Frans Oilinki <moilinki@gmail.com>.
68
9ff9402d 692012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
70
71 * unexmacosx.c (copy_data_segment): Copy initialized data in
72 statically linked libraries from input file rather than memory.
73
db74a5fc
YM
74 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
75 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
76 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
77
25e65510
GM
782012-08-10 Glenn Morris <rgm@gnu.org>
79
80 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
81 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
82
7961135c
DA
832012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
84
85 Fix last change to allow compilation with low optimization levels.
86 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
87 Reported by Jan Djärv <jan.h.d@swipnet.se>.
88
42b3a444
DA
892012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
90
91 Use common inline syntax in intervals.h.
92 * intervals.h (INTERVALS_INLINE): New macro.
93 Change all users from LISP_INLINE.
94
9fb0c957
DA
952012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Define Qnone once for all platforms.
98 * frame.c (Qnone): Define here.
99 (syms_of_frame): DEFSYM it.
100 * lisp.h (Qnone): New declaration.
101 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
102 * xfns.c: Remove duplication. Adjust users.
103
65e8ee52
DA
1042012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
105
106 Remove unused macros from intervals.h.
107 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
108 * intervals.c: Adjust comment.
109
9b855fd6
EZ
1102012-08-10 Eli Zaretskii <eliz@gnu.org>
111
112 * w32fns.c <w32_unicode_gui>: New static variable.
113 (globals_of_w32fns): Initialize it according to os_subtype.
114 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
115 testing os_subtype.
116
39cb9e56 1172012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
118 Eli Zaretskii <eliz@gnu.org>
119
120 Fix bug #10299 with Unicode characters sent by customized
121 keyboards created by MSKLC.
122 * w32fns.c (INIT_WINDOW_CLASS): New macro.
123 (w32_init_class): Use it to initialize the Emacs class with either
124 ANSI or Unicode API calls.
125 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
126 later.
127 (w32_wnd_proc): If the character code sent by WM_CHAR or
128 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
129 original message. Call DefWindowProcW on NT and later.
130
9374581a
GM
1312012-08-10 Glenn Morris <rgm@gnu.org>
132
4b94e8cf
GM
133 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
134
9374581a
GM
135 * lisp.h (DIRECTORY_SEP): Let configure set it.
136
a2752828
DA
1372012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
138
139 Use TSET for write access to Lisp_Object slots of struct terminal.
140 * termhooks.h (TSET): New macro.
141 * coding.c, terminal.c, xselect.c: Adjust users.
142
cc92c454
SM
1432012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
144
145 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
146 the failing expression, include them in the error message.
147 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
148 * lisp.h (internal_condition_case_n): Update declaration.
149
4cb3e6b3
DA
1502012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
151
152 Inline functions to examine and change buffer overlays.
153 * buffer.c (unchain_both): New function.
154 * buffer.h (buffer_get_overlays, buffer_set_overlays):
155 (buffer_has_overlays): New function.
156 (enum overlay_type): New enum.
157 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
158 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
159
8707c1e5
DA
1602012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
161
162 Inline functions to examine and change buffer intervals.
163 * alloc.c (mark_interval_tree): Remove.
164 (MARK_INTERVAL_TREE): Simplify.
165 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
166 * intervals.c (buffer_balance_intervals): New function.
167 (graft_intervals_into_buffer): Adjust indentation.
168 (set_intervals_multibyte): Simplify.
169 * buffer.h (BUF_INTERVALS): Remove.
170 (buffer_get_intervals, buffer_set_intervals): New function.
171 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
172 * intervals.c, textprop.c: Adjust users.
173
ad8c997f
DA
1742012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Inline functions to examine and change string intervals.
177 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
178 (string_get_intervals, string_set_intervals): New function.
179 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
180 * lread.c, print.c, textprop.c: Adjust users.
181
32ac3a6b
GM
1822012-08-08 Glenn Morris <rgm@gnu.org>
183
184 * lisp.mk (lisp): Remove language/persian.elc.
185
77c7bcb1
DA
1862012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Cleanup intervals.
189 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
190 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
191 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
192 Adjust comment. Move under #if 0.
77c7bcb1
DA
193 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
194 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
195
9c08a8d4
DA
1962012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Check total length of intervals with eassert.
199 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
200 * intervals.c: Change all users to eassert.
201
26d16b35
EZ
2022012-08-07 Eli Zaretskii <eliz@gnu.org>
203
14ae4239
BT
204 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
205 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
206 INTERNAL_FIELD in Lisp_Cons.
207
c644523b
DA
2082012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
211 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
212 name since all xname users are fixed long time ago. Do not
213 use INTERNAL_FIELD.
214 (set_symbol_name, set_symbol_function, set_symbol_plist):
215 (set_symbol_next, set_overlay_plist): New function.
216 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
217 (struct Lisp_Overlay): Likewise.
218 (CVAR, MVAR, SVAR): Remove.
219 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
220 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
221 * xterm.c: Adjust users.
222 * .gdbinit: Change to use name field of struct Lisp_Symbol
223 where appropriate.
224
6a3d20cc
DA
2252012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
226
227 Basic functions to set Lisp_Object and pointer slots of intervals.
228 * intervals.h (interval_set_parent, interval_set_object):
229 (interval_set_left, interval_set_right, interval_set_plist):
230 (interval_copy_parent): New function.
231 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
232 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
233 Adjust indentation.
6a3d20cc
DA
234 (INTERVAL_SIZE): Remove. Adjust users.
235 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
236
4d2b044c
DA
2372012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
238
239 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
240 * process.h (PGET): Remove.
241 (struct Lisp_Process): Do not use INTERNAL_FIELD.
242 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
243
d3d50620
DA
2442012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Drop WGET and revert read access to Lisp_Objects slots of struct window.
247 * window.h (WGET): Remove.
248 (struct window): Do not use INTERNAL_FIELD.
249 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
250 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
251 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
252 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
253 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
254 Adjust users.
255
d10a51dc
CY
2562012-08-07 Chong Yidong <cyd@gnu.org>
257
258 * window.c (Fwindow_edges, Fwindow_pixel_edges)
259 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
260 (Fdelete_window_internal): Signal an error if the window is not on
261 a live frame (Bug#12025).
262
e69b0960
DA
2632012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
266 * frame.h (FGET): Remove.
267 (struct frame): Do not use INTERNAL_FIELD.
268 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
269 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
270 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
271 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
272
25a20a3a
JB
2732012-08-06 Juanma Barranquero <lekktu@gmail.com>
274
275 * w32.c: Silence compiler warnings.
276 (map_w32_filename): Remove unused variable `is_fat'.
277 (chase_symlinks): Add parentheses around expression.
278
1c6f11f4
GM
2792012-08-06 Glenn Morris <rgm@gnu.org>
280
1db4583a
GM
281 * sysdep.c: Respect BROKEN_GETWD.
282
1c6f11f4
GM
283 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
284 Let configure handle it.
285 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
286
2b90362b
DA
2872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Use GCALIGNMENT where appropriate.
290 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
291 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
292 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
293
5f50daf2
EZ
2942012-08-06 Eli Zaretskii <eliz@gnu.org>
295
14ae4239
BT
296 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
297 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 298
cbcc7007
SM
2992012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
300
301 * buffer.h (struct buffer): Revert `indirections' to a simple int;
302 that should be sufficient for everyone.
303
4d365fa4
JD
3042012-08-06 Jan Djärv <jan.h.d@swipnet.se>
305
306 * keyboard.c (timer_check_2): Add break so timer_check returns next
307 timeout.
308
dd86bd82
DA
3092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Fix Windows build errors introduced after converting to WGET and WSET.
312 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
313 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
314
054e1668
JD
3152012-08-06 Jan Djärv <jan.h.d@swipnet.se>
316
317 * nsterm.m (ns_frame_rehighlight): Use FSET.
318
319 * nsmenu.m (ns_update_menubar): Use FSET.
320
21238f11
DA
3212012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
322
323 Separate read and write access to Lisp_Object slots of Lisp_Process.
324 * process.h (PGET, PSET): New macros similar to AREF and ASET.
325 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
326
077288cf
DA
3272012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Separate read and write access to Lisp_Object slots of struct window.
330 * window.h (WGET, WSET): New macros similar to AREF and ASET.
331 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
332 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
333 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
334 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
335 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
336 Adjust users.
337
71688bd7
DA
3382012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Fix Windows build errors introduced after converting to FGET and FSET.
341 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
342 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
343 (w32_judge_scroll_bars): Change to use FSET.
344 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
345
f99bac93
DA
3462012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
347
348 Fix replacement typo.
349 * window.c (replace_window): Set root_window instead of
350 selected_window. This fixes a total window subsystem
351 malfunction reported by Bastien Guerry <bzg@gnu.org>.
352
8c2a0f2d
GM
3532012-08-06 Glenn Morris <rgm@gnu.org>
354
355 * lisp.mk (lisp): Add language/persian.elc.
356
edd74c35
DA
3572012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
358
359 Separate read and write access to Lisp_Object slots of struct frame.
360 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
361 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
362 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
363 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
364 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
365
8671676c
AS
3662012-08-05 Andreas Schwab <schwab@linux-m68k.org>
367
368 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
369
663e2b3f
DA
3702012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
371
372 Generalize common compile-time constants.
373 * lisp.h (header_size, bool_header_size, word_size): Now here.
374 (struct Lisp_Vector): Add comment.
375 (struct Lisp_Bool_Vector): Move up to define handy constants.
376 (VECSIZE, PSEUDOVECSIZE): Simplify.
377 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
378 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
379 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
380 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
381 * xfont.c, xmenu.c: Use word_size where appropriate.
382
d32e47af
LM
3832012-08-05 Lawrence Mitchell <wence@gmx.li>
384
385 * search.c (Freplace_match): Treat \? in the replacement text
386 literally (Bug#8161).
387
e5d9c0d1
CY
3882012-08-05 Chong Yidong <cyd@gnu.org>
389
390 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
391 * frame.c (Vdelete_frame_functions):
392 * emacs.c (Vkill_emacs_hook): Doc fix.
393
8da0576b
EZ
3942012-08-04 Eli Zaretskii <eliz@gnu.org>
395
396 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
397 --with-x-toolkit=no builds.
398 Reported by Carsten Mattner <carstenmattner@gmail.com>.
399
02676e5d
CY
4002012-08-04 Chong Yidong <cyd@gnu.org>
401
402 * syntax.c (Fmodify_syntax_entry): Doc fix.
403
97147da9
EZ
4042012-08-04 Eli Zaretskii <eliz@gnu.org>
405
76151e2c
EZ
406 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
407 * w32.c (init_environment): Change the default values of many
408 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
409 them into environment when they were not already defined.
410 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 411 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
412 (check_windows_init_file): Now external, not static.
413 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
414 called when Vload_path is already set up.
415
416 * w32.h (check_windows_init_file): Add prototype.
417
418 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
419 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
420 compatibility with Posix platforms.
421 (main): Move the call to check_windows_init_file to here from
422 w32.c.
423 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
424 any, in the DEFALT argument into the root of the Emacs build or
425 installation tree, as appropriate.
426
427 * callproc.c (init_callproc_1): Call decode_env_path instead of
428 doing its equivalent by hand.
429 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
430 the code that sets Vexec_path run on MS-Windows.
431
432 * lread.c (init_lread): Add comments to #ifdef's.
433
97147da9
EZ
434 * msdos.c (dos_set_window_size, IT_update_begin)
435 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
436 instead of direct references.
437
185ee146
PE
4382012-08-04 Paul Eggert <eggert@cs.ucla.edu>
439
440 Export DEFAULT_REHASH_* to GDB.
441 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
442 Now constants, not macros.
443
8834c57a
PE
4442012-08-03 Paul Eggert <eggert@cs.ucla.edu>
445
98c6f1e3
PE
446 Remove unnecessary casts involving pointers.
447 These casts are no longer needed now that we assume C89 or later,
448 since they involve casting to or from void *.
449 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
450 (make_pure_float, make_pure_vector):
451 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
452 * macros.c (Fstart_kbd_macro):
453 * menu.c (find_and_return_menu_selection):
454 * minibuf.c (read_minibuf_noninteractive):
455 * sysdep.c (closedir):
456 * xdisp.c (x_produce_glyphs):
457 * xfaces.c (compare_fonts_by_sort_order):
458 * xfns.c (x_real_positions, select_visual):
459 * xselect.c (x_stop_queuing_selection_requests)
460 (x_get_window_property, x_get_window_property_as_lisp_data):
461 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
462 Remove unnecessary pointer casts.
463 * alloc.c (record_xmalloc): New function.
464 * lisp.h (record_xmalloc): New decl.
465 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
466 more like a function. This is because the pointer cast is not
467 needed. All uses changed.
468 * print.c (print_string, print_error_message): Avoid length recalc.
469
8834c57a
PE
470 Improve fix for macroexp crash with debugging (Bug#12118).
471 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
472 ARRAY_MARK_FLAG when checking subscripts, because ASET is
473 not supposed to be invoked from the garbage collector.
474 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
475 (gc_aset): New function, which is like ASET but can be
476 used in the garbage collector.
477 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
478 (set_hash_index): Use it instead of ASET.
479
6dad7178
EZ
4802012-08-03 Eli Zaretskii <eliz@gnu.org>
481
482 Support symlinks on latest versions of MS-Windows.
483 * w32.c: Include winioctl.h and aclapi.h.
484 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
485 (revert_to_self): Forward declarations of static functions.
486 <static BOOL g_b_init_get_security_info>:
487 <g_b_init_create_symbolic_link>: New static flags.
488 (globals_of_w32): Initialize them to zero.
489 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
490 (map_w32_filename): Improve commentary. Simplify switch.
491 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
492 headers (most versions of MinGW w32api don't).
493 (get_security_info, create_symbolic_link)
494 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
495 New functions.
496 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
497 in the argument file name.
498 (sys_access): Call unc_volume_file_attributes only if
499 GetFileAttributes fails with network-related error codes.
500 (sys_rename): Diagnose renaming of a symlink when the user doesn't
501 have the required privileges.
14ae4239 502 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
503 get_file_security_desc.
504 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
505 with addition of handling of symlinks and support for 'lstat'.
506 If possible, get file's attributes and security information by
6dad7178
EZ
507 handle, not by name. Produce S_IFLNK bit for symlinks, when
508 called from 'lstat'.
509 (stat, lstat): New functions, call 'stat_worker'.
510 (symlink, readlink, careadlinkat): Rewritten to create and resolve
511 symlinks when the underlying filesystem supports them.
512
f162bcc3
PE
5132012-08-02 Paul Eggert <eggert@cs.ucla.edu>
514
79ea6c20
PE
515 Fix macroexp crash on Windows with debugging (Bug#12118).
516 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
517 checking subscripts; problem introduced with the recent
518 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
519 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
520 since it's used in non-static inline functions now.
521
c0ce93fd
PE
522 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
523 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 524
f162bcc3
PE
525 Use C99-style 'extern inline' if available.
526 * buffer.h (BUFFER_INLINE):
527 * category.h (CATEGORY_INLINE):
528 * character.h (CHARACTER_INLINE):
529 * charset.h (CHARSET_INLINE):
530 * composite.h (COMPOSITE_INLINE):
531 * dispextern.h (DISPEXTERN_INLINE):
532 * lisp.h (LISP_INLINE):
533 * systime.h (SYSTIME_INLINE):
534 New macro, replacing 'static inline' in this header.
535 * buffer.h, category.h, character.h, charset.h, composite.h:
536 * dispextern.h, lisp.h, systime.h:
537 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
538 * alloc.c (LISP_INLINE):
539 * buffer.c (BUFFER_INLINE):
540 * category.c (CATEGORY_INLINE):
541 * character.c (CHARACTER_INLINE):
542 * charset.c (CHARSET_INLINE):
543 * composite.c (COMPOSITE_INLINE):
544 * dispnew.c (DISPEXTERN_INLINE):
545 * sysdep.c (SYSTIME_INLINE):
546 Define to EXTERN_INLINE, so that the corresponding functions
547 are compiled into code.
548 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
549 (INLINE_HEADER_END): New macros.
550 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
551 since it's used in non-static inline functions now.
a8333d03 552 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 553
837b365b
GM
5542012-08-02 Glenn Morris <rgm@gnu.org>
555
d66b744d
GM
556 * s/: Remove empty directory.
557
837b365b
GM
558 * s/ms-w32.h: Move to ../nt/inc.
559 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
560 Update for new ms-w32.h location.
561
13294f95
PE
5622012-08-02 Paul Eggert <eggert@cs.ucla.edu>
563
564 Port to Solaris 8.
565 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
566
90df0db3
GM
5672012-08-02 Glenn Morris <rgm@gnu.org>
568
569 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
570 hard-coding the path separator.
571
4939150c
PE
5722012-08-01 Paul Eggert <eggert@cs.ucla.edu>
573
574 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
575 This how ASET and AREF are supposed to work, and makes
576 it easier to think about future improvements. See
577 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
578 * charset.h (set_charset_attr): New function.
579 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
580 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
581 (aref_addr): New function. All uses of &AREF(...) changed.
582 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
583 (set_hash_index): New functions. All lvalue-style uses of
584 HASH_KEY etc. changed.
585 * keyboard.c (set_prop): New function. All lvalue-style uses
586 of PROP changed.
587
947b2afd
AA
5882012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
589
590 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
591 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
592 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
593 * nsfns.m (ns_set_name_as_filename): Likewise.
594 * nsmenu.m (ns_update_menubar): Likewise.
595 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
596
4f5d0325
EZ
5972012-08-01 Eli Zaretskii <eliz@gnu.org>
598
2008beae
EZ
599 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
600 Adapt to latest changes in field names of the corresponding Lisp
288479f6 601 objects.
2008beae 602
4f5d0325
EZ
603 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
604
fe3cc771
GM
6052012-08-01 Glenn Morris <rgm@gnu.org>
606
607 * s/msdos.h: Remove file.
608 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
609 * Makefile.in (S_FILE): Remove.
610 (config_h): Remove S_FILE.
611
c90acc54
JB
6122012-08-01 Juanma Barranquero <lekktu@gmail.com>
613
614 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
615 Remove; moved to nt/config.nt.
616
d8a05828
DA
6172012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Use INTERNAL_FIELD for conses and overlays.
620 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
621 Remove obsolete comment.
622 (MVAR): New macro.
623 (struct Lisp_Overlay): Use INTERNAL_FIELD.
624 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
625
8271d590
DA
6262012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
627
628 Use INTERNAL_FIELD for symbols.
629 * lisp.h (SVAR): New macro. Adjust users.
630 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
631 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
632
3193acd2
DA
6332012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Use INTERNAL_FIELD for processes.
636 * process.h (PVAR): New macro. Adjust style.
637 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
638 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
639
3a45383a
DA
6402012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
641
642 Use INTERNAL_FIELD for windows.
643 * window.h (WVAR): New macro.
644 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
645 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
646 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
647 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
648 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
649 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
650
c1dbc63c
PE
6512012-08-01 Paul Eggert <eggert@cs.ucla.edu>
652
653 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
654
5c0c0e8a
GM
6552012-08-01 Glenn Morris <rgm@gnu.org>
656
657 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
658 Move to configure.ac.
659
552a99b4
JB
6602012-08-01 Juanma Barranquero <lekktu@gmail.com>
661
662 * makefile.w32-in (CONFIG_H): Update dependencies.
663 (CONF_POST_H): New macro.
664
665 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
666
8d8e2dfe
GM
6672012-07-31 Glenn Morris <rgm@gnu.org>
668
bc96620a
GM
669 * Makefile.in (S_FILE): No longer set by configure.
670
476b1b2d
GM
671 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
672 is available.
673 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
674
b2c7a106
GM
675 * process.h (NULL_DEVICE):
676 * emacs.c (SEPCHAR):
677 * editfns.c (USER_FULL_NAME): Let configure set them.
678
d53d062a
GM
679 * s/README, s/template.h: Remove files.
680
4515017f
GM
681 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
682
8d8e2dfe
GM
683 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
684 Move to configure.ac.
685
5b20b3cc
EZ
6862012-07-31 Eli Zaretskii <eliz@gnu.org>
687
1e0afd9a
EZ
688 * .gdbinit (xframe): Adapt to introduction of FVAR and the
689 resulting renaming of 'struct frame' members.
690
5b20b3cc
EZ
691 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
692
693 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
694 after introduction of FVAR.
695
f1310128
JD
6962012-07-31 Jan Djärv <jan.h.d@swipnet.se>
697
79e721e0
JD
698 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
699
700 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
701 instead of compositeToPoint.
702 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
703
8d7c7eed 704 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 705
e34f7f79
DA
7062012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
707
708 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
709 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 710 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
711 (BVAR): Change to use INTERNAL_FIELD.
712 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
713 (KVAR): Change to use INTERNAL_FIELD.
714 * frame.h (FVAR): New macro.
715 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
716 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
717 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
718 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
719 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
720
c09bfb2f
DA
7212012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
722
723 Miscellaneous fixes for non-default X toolkits.
724 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
725 * xterm.c (x_frame_of_widget): Remove redundant prototype.
726 Move under #ifdef USE_LUCID.
727 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
728 definition and usage to avoid warnings.
729
14c114ae
JD
7302012-07-31 Jan Djärv <jan.h.d@swipnet.se>
731
732 * nsterm.m (openFiles): Fix previous checkin.
733
3bd21e82
PE
7342012-07-31 Paul Eggert <eggert@cs.ucla.edu>
735
736 * indent.c (compute_motion): Remove unused local.
737
c1529ded
GM
7382012-07-31 Glenn Morris <rgm@gnu.org>
739
400d5621
GM
740 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
741
268e2432
GM
742 * conf_post.h [USG5_4]:
743 Move remaining contents of s/usg5-4-common.h here.
744 * s/usg5-4-common.h: Remove file.
745
7552f3ee
GM
746 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
747 * s/irix6-5.h: Remove file.
748
6a381852
GM
749 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
750 * s/darwin.h: Remove file.
751
c1529ded
GM
752 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
753 * s/hpux10-20.h: Remove file, which is now empty.
754
b429a4ee
GM
7552012-07-30 Glenn Morris <rgm@gnu.org>
756
757 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
758 * Makefile.in (config_h): Add conf_post.h.
759 * makefile.w32-in (CONFIG_H): Add conf_post.h.
760
adff3182
JD
7612012-07-30 Jan Djärv <jan.h.d@swipnet.se>
762
763 * nsterm.m (ns_do_open_file): New variable.
b9031d69 764 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
765 (openFile, openTempFile, openFileWithoutUI, openFiles):
766 Open files only if ns_do_open_file.
adff3182 767
c32af1e4
PE
7682012-07-30 Paul Eggert <eggert@cs.ucla.edu>
769
7393bcbb
PE
770 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
771 This no-op macro hasn't been needed for many years.
772 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
773
c32af1e4
PE
774 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
775 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
776 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
777 gdb_make_enums_visible.
778 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
779 (DIRECTORY_SEP): Now a constant, not a macro.
780
302fc036
EZ
7812012-07-30 Eli Zaretskii <eliz@gnu.org>
782
783 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
784 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
785
786 * w32term.c <w32_keyboard_codepage>: Renamed from
787 keyboard_codepage and now external. All users changed.
788
789 * w32term.h: Add declaration of w32_keyboard_codepage.
790
791 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
792 the codepage to translate keys to Unicode. If this argument is
793 -1, use the value returned by GetConsoleCP. All callers changed.
794
88fb40b4
PE
7952012-07-30 Paul Eggert <eggert@cs.ucla.edu>
796
0aee6912
PE
797 Update .PHONY listings in makefiles.
798 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
799 bootstrap-clean, distclean, maintainer-clean, versioclean,
800 extraclean, frc.
801
88fb40b4
PE
802 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
803 This is a bit clearer. Fix some commentary typos.
804
0a763bd1
GM
8052012-07-30 Glenn Morris <rgm@gnu.org>
806
32bac6d6
GM
807 * s/netbsd.h: Let configure include signal.h if needed.
808 Remove file, which is now empty.
809
b65e7c46
GM
810 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
811 Let configure set them.
812 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
813 No more need to undefine.
0a763bd1 814
169304bd
AS
8152012-07-30 Andreas Schwab <schwab@linux-m68k.org>
816
817 * keymap.c (Fkey_description): Don't remove 0x80 bit from
818 non-single-byte char when adding meta modifier. (Bug#12090)
819
6cd7a139
DA
8202012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
821
822 Convert safe_call to use variable number of arguments.
823 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
824 (safe_call2): Fix comment.
825 * lisp.h (safe_call): Adjust prototype.
826 * coding.c (encode_coding_object): Change to use safe_call2.
827 * xfaces.c (merge_face_heights): Change to use safe_call1.
828
d34d6ffc
GM
8292012-07-30 Glenn Morris <rgm@gnu.org>
830
7b8a48e4 831 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 832 does that unconditionally. Remove file, which is now empty.
7b8a48e4 833
d34d6ffc
GM
834 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
835 Remove empty files.
836
03a660a6
PE
8372012-07-30 Paul Eggert <eggert@cs.ucla.edu>
838
839 Export to GDB most of lisp.h's remaining object-like macros.
840 * lisp.h (min, max): Move earlier, because they're used earlier now.
841 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
842 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
843 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
844 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
845 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
846 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
847 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
848 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
849 Now constants, for GDB. They need not be macros.
850 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
851 Now constants, for GDB, as well as macros, for static initializers.
852 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
853 Move to after the definition of struct Lisp_Char_Table,
854 since the former now needs that type defined.
855 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
856 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
857 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
858 New enums, for gdb_make_enums_visible.
859 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 860 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
861 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
862 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
863 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
864 enum maxargs, enum MAX_ALLOCA.
865 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
866 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
867 no longer needed, now that they are done in lisp.h.
868
e499d0ee
DA
8692012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
870
871 Cleanup string bytes checking.
872 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
873 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
874 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
875 (check_sblock, compact_small_strings): Simplify.
876
d5040d2d
PE
8772012-07-29 Paul Eggert <eggert@cs.ucla.edu>
878
879 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
880 These macros are confusing and no longer need to be defined, as
881 the enum values now suffice. All uses replaced with definiens.
882 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
883
7f259ae6
JB
8842012-07-29 Juanma Barranquero <lekktu@gmail.com>
885
886 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
887 ($(BLD)/w32console.$(O)): Update dependencies.
888
7e63e0c3
DA
8892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
890
891 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
892 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
893 time. Adjust users.
894 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
895
ffd817eb
JD
8962012-07-29 Jan Djärv <jan.h.d@swipnet.se>
897
898 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
899 setting sitelisp (Bug#12010).
900
417a7a0e
EZ
9012012-07-29 Eli Zaretskii <eliz@gnu.org>
902
14ae4239 903 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
904
905 * w32heap.c (cache_system_info):
906 * w32.c (sys_rename):
907 * w32proc.c (find_child_console, sys_kill): All users changed.
908
387d4d92
PE
9092012-07-29 Paul Eggert <eggert@cs.ucla.edu>
910
911 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
912
55a6cca6
EZ
9132012-07-29 Eli Zaretskii <eliz@gnu.org>
914
915 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
916
dbcf001c
DA
9172012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
918
919 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
920 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
921 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 922
e2688e4a
DA
9232012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
924
925 Generalize marker debugging code under MARKER_DEBUG and use eassert.
926 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
927 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
928 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
929 (replace_range, replace_range_2, del_range_2): Change to eassert.
930 * marker.c (byte_char_debug_check): Adjust style.
931
b46a6a83
PE
9322012-07-29 Paul Eggert <eggert@cs.ucla.edu>
933
934 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
935 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
936 long-ago-commented-out code that talks about "WIN32".
937 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
938 All uses changed.
939
e32a5799
PE
9402012-07-28 Paul Eggert <eggert@cs.ucla.edu>
941
942 Use Gnulib stdalign module (Bug#9772, Bug#9960).
943 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
944 Simplify by using alignof.
945 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
946 * lisp.h: Include <stdalign.h>.
947 (GCALIGNMENT): New macro and constant.
948 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
949 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
950 (stdalign): New macro, if not already defined.
951
df81cd29
EZ
9522012-07-28 Eli Zaretskii <eliz@gnu.org>
953
01bd1b0d
EZ
954 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
955 * w32inevt.c: Include w32inevt.h.
956 (w32_read_console_input): New inline function, calls either
957 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
958 w32_console_unicode_input.
959 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
960 (w32_kbd_patch_key, key_event): Use the codepage returned by
961 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
962 (key_event): use uChar.UnicodeChar only if
963 w32_console_unicode_input is non-zero.
964
965 * w32console.c: Include w32heap.h.
966 <w32_console_unicode_input>: New global variable.
967 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
968 family of Windows, zero otherwise.
969
970 * w32inevt.h: Declare w32_console_unicode_input.
971
df81cd29
EZ
972 * xdisp.c (init_iterator): Don't reference tip_frame in a build
973 --without-x. (Bug#11742)
974
c20fdd9e
PE
9752012-07-27 Paul Eggert <eggert@cs.ucla.edu>
976
977 Adjust GDB to reflect pvec_type changes (Bug#12036).
978 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
979 2012-07-04 changes to pseudovector representation.
980 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 981
32770973 9822012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
983
984 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
985 bus address.
986 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
987
3438fe21
EZ
9882012-07-27 Eli Zaretskii <eliz@gnu.org>
989
bcfbc9de
EZ
990 * alloc.c (listn): Fix the order the arguments are consed onto the
991 list.
992
3438fe21
EZ
993 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
994 enumeration constants, as PURE and HEAP are too general, and clash
995 with other headers and sources, such as gmalloc.c and the
996 MS-Windows system headers. All users changed.
997
eeaea515
DA
9982012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 Revert last save_excursion_save and save_excursion_restore changes.
1001 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1002 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1003
073c88c2
DA
10042012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1005
1006 Fix recently-introduced typos in Windows port.
1007 Reported by Martin Rudalics <rudalics@gmx.at>.
1008 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1009 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1010
4706125e
PE
10112012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 Improve GDB symbol export (Bug#12036).
1014 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1015 arms of an 'if', not using conditional expressions; otherwise GDB
1016 complains about the types in the unevaluated arm when the argument
1017 is an integer literal.
1018 (xgetint): Simplify expression.
1019 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1020 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1021 Zaretskii in <http://bugs.gnu.org/12036#13>.
1022 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1023 needed now that we have gdb_make_enums_visible.
1024 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1025 (enum enum_USE_LSB_TAG):
1026 New enum types, packaging up enums that need to be exported to GDB.
1027
694b6c97
DA
10282012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 Utility function to make a list from specified amount of objects.
1031 * lisp.h (enum constype): New datatype.
1032 (listn): New prototype.
1033 * alloc.c (listn): New function.
1034 (Fmemory_use_count, syms_of_alloc): Use it.
1035 * buffer.c (syms_of_buffer): Likewise.
1036 * callint.c (syms_of_callint): Likewise.
1037 * charset.c (define_charset_internal): Likewise.
1038 * coding.c (syms_of_coding): Likewise.
1039 * keymap.c (syms_of_keymap): Likewise.
1040 * search.c (syms_of_search): Likewise.
1041 * syntax.c (syms_of_syntax): Likewise.
1042 * w32.c (init_environment): Likewise.
1043 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1044 * xdisp.c (syms_of_xdisp): Likewise.
1045 * xfns.c (syms_of_xfns): Likewise.
1046
6195f384
DA
10472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 Fast save_excursion_save and save_excursion_restore.
1050 * lisp.h (struct Lisp_Excursion): New data type.
1051 (PVEC_EXCURSION): New pseudovector type.
1052 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1053 to deal with it. Adjust comments.
1054 (init_marker, attach_marker): New prototype.
1055 (unchain_marker): Adjust prototype.
1056 * marker.c (attach_marker): Change to global.
1057 (init_marker): New function.
1058 * alloc.c (Fmake_marker, build_marker): Use it.
1059 (build_marker): More easserts.
1060 (mark_object): Handle struct Lisp_Excursion.
1061 * editfns.c (save_excursion_save, save_excursion_restore):
1062 Reimplement to use struct Lisp_Excursion. Add comments.
1063
5eceb8fb
PE
10642012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 Fix export of symbols to GDB (Bug#12036).
1067 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1068 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1069 emacs.c, as this is a more-suitable home. Had this been done earlier
1070 the fix for 12036 would have avoided some of the problems noted in
1071 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1072 would have been more obvious.
562157c8
PE
1073 * emacs.c: Do not include <verify.h>; no longer needed.
1074 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1075 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1076 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1077 Remove; now done in lisp.h.
1078 * lisp.h (PUBLISH_TO_GDB): New macro.
1079 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1080 (DATA_SEG_BITS): Use it.
1081 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1082 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1083 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1084 not be usable in #if. This simplifies things.
1085
d6749401
JB
10862012-07-26 Juanma Barranquero <lekktu@gmail.com>
1087
1088 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1089
1781b9e9
PE
10902012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1091
d89518db 1092 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1093 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1094 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1095 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1096 Adjust to changes in lisp.h and emacs.c, by using
1097 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1098 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1099 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1100 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1101 instead of gdb_valbits.
1102 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1103 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1104 instead of gdb_array_mark_flag.
1105 (xboolvector): Get size from $->size, not $->header.size.
1106 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1107 (xreload, hook-run, hookpost-run): Remove.
1108 * emacs.c: Include <verify.h>.
1109 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1110 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1111 Remove.
1112 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1113 (gdb_USE_LSB_TAG): New enum constants.
1114 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1115 Also define these as enum constants, so they're visible to GDB.
1116 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1117 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1118 as constants, so they're visible to GDB.
1119 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1120 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1121 Now enum constants, not macros, so they're visible to GDB.
1122 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1123 more convenient now. All uses changed.
1124 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1125 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1126
3628596a
DA
11272012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1128
1129 Explicitly free restriction data that are not needed anymore.
1130 * editfns.c (save_restriction_restore): Free restriction data.
1131
7abaf5cc
SM
11322012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1133
1134 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1135 add argument, tune behavior, and adjust all callers.
1136
71f88e00
PE
11372012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 Use typedef for EMACS_INT, EMACS_UINT.
1140 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1141 than macros. This simplifies debugging in the usual case, since
1142 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1143 and it allows expressions involving EMACS_INT casts.
1144 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1145
57ec3034
JD
11462012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1147
1148 * nsterm.m (ns_read_socket): Return early if there is a modal
1149 window (Bug#12043).
1150
8137e7b3
MR
11512012-07-25 Martin Rudalics <rudalics@gmx.at>
1152
1153 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1154 that FOCUS-FRAME can be omitted.
1155
04e9897c
DA
11562012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 Adjust buffer text indirection counters at the end of Fkill_buffer.
1159 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1160 buffer is definitely dead. This should really fix an issue reported
1161 by Christoph Scholtes again. (Bug#12007).
1162 (init_buffer_once): Initialize indirection counters of
1163 buffer_defaults and buffer_local_symbols (for sanity and safety).
1164
8a0484e1
EZ
11652012-07-24 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1168 and continuation glyphs on tooltip frames, leave them at zero.
1169 Avoids continued lines in tooltips. (Bug#11832)
1170
fa691a83
DA
11712012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1172
1173 Simplify copy_overlay.
04e9897c 1174 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1175 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1176
436bc8e0
EZ
11772012-07-23 Eli Zaretskii <eliz@gnu.org>
1178
1179 * print.c (print_object): Don't crash when a frame's name is nil
1180 or invalid. (Bug#12025)
1181
1182 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1183 it signals an error when a tooltip frame is being created.
1184
d7a7fda3
DA
11852012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 Cleanup miscellaneous objects allocation and initialization.
1188 * alloc.c (allocate_misc): Change to static. Add argument to
1189 specify the subtype. Adjust comment and users.
1190 (build_overlay): New function.
1191 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1192 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1193 (allocate_misc): Remove prototype.
1194 (build_overlay): Add prototype.
1195
11962012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1197
1198 Swap buffer text indirection counters in Fbuffer_swap_text.
1199 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1200 This avoids crash reported by Christoph Scholtes at
1201 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1202
9d7fa573
JD
12032012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1204
1205 * nsmenu.m (Popdown_data): New struct.
1206 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1207 free Popdown_data.
1208 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1209 (initWithContentRect): Make imgView and contentView non-static
1210 and autorelease them. Also autorelease img and matrix (Bug#12005).
1211 (dealloc): Remove (Bug#12005).
1212
0dd6d66d
DA
12132012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 Adjust consing_since_gc when objects are explicitly freed.
1216 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1217 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1218 (free_cons, free_misc): Subtract object size from consing_since_gc.
1219
d36d71df
DA
12202012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1221
1222 Simplify and cleanup markers positioning code.
1223 * marker.c (attach_marker): More useful eassert.
1224 (live_buffer, set_marker_internal): New function.
1225 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1226 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1227
fb9ea40f
PE
12282012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1231 as it's limited by the amount of memory, not by INT_MAX.
1232
2d5c5f7d
EZ
12332012-07-21 Eli Zaretskii <eliz@gnu.org>
1234
07fb592e
EZ
1235 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1236 in special-event-map. See the discussion at
1237 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1238 for the reasons.
1239
37a9eac8 1240 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1241 info.dwItemData. Fixes crashes on 64-bit Windows.
1242 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1243
c4328746
JD
12442012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1245
1246 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1247 (conversationIdentifier): Return value is NSInteger.
784051c4 1248 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1249
6e5d1c12
CY
12502012-07-21 Chong Yidong <cyd@gnu.org>
1251
1252 * window.c (decode_any_window): Signal an error if the window is
1253 on a dead frame (Bug#11984).
1254
9928463d
DA
12552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1256
1257 Add indirection counting to speed up Fkill_buffer.
1258 * buffer.h (struct buffer): New member.
1259 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1260 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1261 base buffer indirection counter.
1262 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1263 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1264 through buffer list if indirection counter is 0.
1265
f8643a6b
DA
12662012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 Extend the value returned by Fgarbage_collect with heap statistics.
1269 * alloc.c (Qheap): New symbol.
1270 (syms_of_alloc): DEFSYM it.
1271 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1272 (Fmemory_free): Remove.
1273 (syms_of_alloc): Don't defsubr it.
1274 * buffer.c (Fcompact_buffer): Remove.
1275 (syms_of_buffer): Don't defsubr it.
1276
dac616ff
DA
12772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 Make maybe_gc inline.
1280 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1281 * lisp.h (consing_since_gc, gc_relative_threshold)
1282 (memory_full_cons_threshold): Revert declaration.
1283 (maybe_gc): Remove prototype, define as inline.
1284 * alloc.c: Remove old commented-out code.
1285 (consing_since_gc, gc_relative_threshold)
1286 (memory_full_cons_threshold): Revert to global.
1287 (maybe_gc): Remove.
1288
d7ea76b4
DA
12892012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1290
1291 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1292 * lisp.h (build_unibyte_string): New function.
1293 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1294 * sysdep.c, w32fns.c, xfns.c: Use it.
1295 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1296 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1297 Adjust users accordingly.
1298 * font.h (font_open_by_name): Adjust prototype.
1299
765e61e3
DA
13002012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1301
1302 Cleanup calls to Fgarbage_collect.
1303 * lisp.h (maybe_gc): New prototype.
1304 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1305 Remove declarations.
1306 * alloc.c (maybe_gc): New function.
1307 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1308 Make them static.
1309 * bytecode.c (MAYBE_GC): Use maybe_gc.
1310 * eval.c (eval_sub, Ffuncall): Likewise.
1311 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1312 to avoid dependency from auto-save feature.
1313
52b852c7
PE
13142012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1317 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1318 'for_each_per_buffer_object_at'.
1319 All uses changed. It's better to use upper-case for macros that
1320 cannot be implemented as functions, to give the reader a clue
1321 that they're special.
1322
5db81e33
SM
13232012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1324
1325 * alloc.c (Fgarbage_collect): Tweak docstring.
1326
5b835e1d
DA
13272012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 Tweak the value returned from Fgarbage_collect again.
1330 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1331 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1332 Adjust documentation.
1333 (total_vector_bytes): Rename to total_vector_slots, adjust
1334 accounting.
1335 (total_free_vector_bytes): Rename to total_free_vector_slots,
1336 adjust accounting.
1337 (Qstring_bytes, Qvector_slots): New symbols.
1338 (syms_of_alloc): DEFSYM them.
1339
9cd47b72
DA
13402012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1341
1342 Buffer compaction primitive which may be used from Lisp.
1343 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1344 (syms_of_buffer): Register Fcompact_buffer.
1345 * alloc.c (Fgarbage_collect): Use compact_buffer.
1346 * buffer.h (compact_buffer): New prototype.
1347 (struct buffer_text): New member.
1348
d17337e5
DA
13492012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 New macro to iterate over all buffers, miscellaneous cleanups.
1352 * lisp.h (all_buffers): Remove declaration.
1353 * buffer.h (all_buffers): Add declaration, with comment.
1354 (for_each_buffer): New macro.
1355 * alloc.c (Fgarbage_collect, mark_object): Use it.
1356 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1357 (init_buffer): Likewise.
1358 * data.c (Fset_default): Likewise.
1359 * coding.c (code_conversion_restore): Remove redundant check
1360 for dead buffer.
1361 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1362
60cfd278
AS
13632012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1364
1365 Fix bug that created negative-length intervals.
1366 * intervals.c (merge_interval_right, merge_interval_left):
1367 Do not zero out this interval if it is absorbed by its children,
1368 as this interval's total length doesn't change in that case. See
1369 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1370
d06714cb
PE
13712012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1372
83713154
PE
1373 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1374 when invoking (make-bool-vector N t) and N is a positive
1375 multiple of 8 -- the last 8 bits were mistakenly cleared.
1376
d06714cb
PE
1377 Remove some struct layout assumptions in bool vectors.
1378 * alloc.c (bool_header_size): New constant.
1379 (header_size, word_size): Move earlier, as they're now used earlier.
1380 Use 'word_size' in a few more places, where it's appropriate.
1381 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1382 padding before the data member of a bool vector.
1383 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1384 than doing the check by hand with an abort ().
1385
464d5a5e
SM
13862012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1387
5fbc0409
SM
1388 * eval.c (Fdefvar): Don't check constants since we only set the var if
1389 it's not yet defined anyway (bug#11904).
1390
464d5a5e
SM
1391 * lisp.h (last_undo_boundary): Declare new var.
1392 * keyboard.c (command_loop_1): Set it.
1393 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1394 were auto-added by the command loop (bug#11774).
1395
8dc2e44a
AS
13962012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1397
1398 * w32font.c (Qsymbol): Remove local definition.
1399 (syms_of_w32font): Don't DEFSYM it.
1400
169925ec
DA
14012012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 Fix sweep_vectors to handle large bool vectors correctly.
1404 * alloc.c (sweep_vectors): Account total_vector_bytes for
1405 bool vectors larger than VBLOCK_BYTES_MAX.
1406
5fbfb018
CY
14072012-07-18 Chong Yidong <cyd@gnu.org>
1408
1409 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1410 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1411
3ab6e069
DA
14122012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1413
1414 Return more descriptive data from Fgarbage_collect.
1415 Suggested by Stefan Monnier in
1416 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1417 * alloc.c (bounded_number): New function.
1418 (total_buffers, total_vectors): New variable.
1419 (total_string_size): Rename to total_string_bytes, adjust users.
1420 (total_vector_size): Rename to total_vector_bytes, adjust users.
1421 (sweep_vectors): Account total_vectors and total_vector_bytes.
1422 (Fgarbage_collect): New return value. Adjust documentation.
1423 (gc_sweep): Account total_buffers.
1424 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1425 (VECTOR_SIZE): Remove.
1426 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1427 (Qinterval, Qmisc): New symbols.
1428 (syms_of_data): Initialize them.
1429 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1430 (Qcons, Qbuffer): New declarations.
1431
6d02fe5b
PE
14322012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1435 Round up, not down. Improve doc.
1436
b7ffe040
DA
14372012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1438
1439 Restore old code in allocate_string_data to avoid Faset breakage.
1440 Reported by Julien Danjou <julien@danjou.info> in
1441 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1442 * alloc.c (allocate_string_data): Restore old code with minor
1443 adjustments, fix comment to explain this subtle issue.
1444
4dc7c8d5
SM
14452012-07-17 Eli Zaretskii <eliz@gnu.org>
1446
1447 Remove FILE_SYSTEM_CASE.
1448 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1449
1450 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1451 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1452 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1453 call-process-region passes it through expand-file-name.
1454
1455 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1456
14572012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1458
1459 Fix crash when creating indirect buffer (Bug#11917)
1460 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1461 Don't handle unbound variables specially if non-zero.
1462 (Fbuffer_local_variables): Pass zero.
1463 (clone_per_buffer_values): Pass non-zero.
1464
14652012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1466
1467 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1468 to make the loop interruptible.
1469
14702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1471
1472 * gnutls.c (emacs_gnutls_handshake): Only retry if
1473 GNUTLS_E_INTERRUPTED.
1474
cce7fefc
DA
14752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 Cleanup and convert miscellaneous checks to eassert.
1478 * alloc.c (mark_interval): Fix comment, partially rephrase
1479 old comment from intervals.h (see below).
1480 * intervals.c (find_interval, adjust_intervals_for_insertion)
1481 (delete_interval, adjust_intervals_for_deletion)
1482 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1483 Convert to eassert.
1484 (adjust_intervals_for_insertion, make_new_interval):
1485 Remove obsolete and unused code.
1486 * intervals.h (struct interval): Remove obsolete comment.
1487 * textprotp.c (erase_properties): Remove unused code.
1488 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1489 (Fremove_list_of_text_properties): Convert to eassert.
1490
9ea10cc3
CY
14912012-07-17 Chong Yidong <cyd@gnu.org>
1492
1493 * editfns.c (Finsert_char): Doc fix.
1494
3900d5de
DA
14952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 Fix previous change to make Fmemory_free always accurate.
1498 * alloc.c (make_interval): Update total_free_intervals.
1499 (make_float): Likewise for total_free_floats.
1500 (free_cons, Fcons): Likewise for total_free_conses.
1501 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1502 Likewise for total_free_vector_bytes.
1503 (Fmake_symbol): Likewise for total_free_symbols.
1504 (bytes_free): Remove.
1505
7098646f
DA
15062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1507
1508 Simple free memory accounting feature.
1509 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1510 (sweep_vectors): Accumulate size of free vectors.
1511 (Fgarbage_collect): Setup bytes_free.
1512 (Fmemory_free): New function.
1513 (syms_of_alloc): Register it.
1514
22657b40
DA
15152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 Cleanup overlays checking.
1518 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1519 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1520 eassert and OVERLAYP.
1521 (sort_overlays): Change to use OVERLAYP.
1522
ddfc8813
RK
15232012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1524
1525 * editfns.c (Finsert_char): Make it interactive, and make the
1526 second arg optional. Copy interactive spec and docstring from
1527 ucs-insert.
1528
7c26cf3c
PE
15292012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1532 Unlike the other wrapped functions, fabs has an unspecified
1533 effect on errno.
1534
5d127af9
JD
15352012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1536
1537 * nsterm.m (keyDown): Interpret flags without left/right bits
1538 as the left key (Bug#11670).
1539
6a0dd1d7
DA
15402012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1541
1542 Remove empty and useless init functions.
1543 * lisp.h (init_character_once, init_fns, init_image)
1544 (init_filelock, init_sound): Remove prototype.
1545 * character.c (init_character_once): Remove.
1546 * filelock.c (init_filelock): Likewise.
1547 * fns.c (init_fns): Likewise.
1548 * image.c (init_image): Likewise.
1549 * sound.c (init_sound): Likewise.
1550 * emacs.c (main): Adjust accordingly.
1551
7a6136fd
DA
15522012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1553
1554 * gtkutil.h: Tiny cleanups.
1555 (use_old_gtk_file_dialog): Remove useless declaration.
1556 (xg_uses_old_file_dialog): Add suggested const attribute.
1557
ce811ad9
EZ
15582012-07-15 Eli Zaretskii <eliz@gnu.org>
1559
1560 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1561 (bidi_paragraph_init): Use it to limit search forward for a strong
1562 directional character in abnormally large paragraphs full of
1563 neutral or weak characters. (Bug#11943)
1564
c9adfeaa
SF
15652012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1566
1567 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1568 the toolbar (Bug#9451).
1569 (xg_make_tool_item): Give the widget event box a transparent
1570 background.
1571
fff62aa9
DA
15722012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1573
1574 Cleanup basic allocation variables and functions.
1575 * alloc.c (ignore_warnings, init_intervals, init_float)
1576 (init_cons, init_symbol, init_marker): Remove.
1577 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1578 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1579 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1580 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1581 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1582 (staticidx, init_alloc_once, init_strings, free_ablock):
1583 Remove redundant initialization.
1584 * fns.c (init_weak_hash_tables): Remove.
1585 * lisp.h (init_weak_hash_tables): Remove prototype.
1586
9730daca
DA
15872012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 Use zero_vector where appropriate.
1590 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1591 accordingly.
1592 * lisp.h (zero_vector): New declaration.
1593 * font.c (null_vector): Remove.
1594 (syms_of_font): Remove initialization and staticpro.
1595 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1596 * keymap.c (Faccessible_keymaps): Likewise.
1597
2e2d2a13
LL
15982012-07-15 Leo Liu <sdl.web@gmail.com>
1599
1600 * fringe.c: Fix typo in comments.
1601
cd276f6e
LL
16022012-07-14 Leo Liu <sdl.web@gmail.com>
1603
1604 * fringe.c: Add a new bitmap exclamation-mark.
1605
5a1131d9
EZ
16062012-07-14 Eli Zaretskii <eliz@gnu.org>
1607
1608 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1609
1610 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1611 (HAVE_MENUS): Don't define, defined by editing config.in with
1612 msdos/sed2v2.inp.
1613 (GMALLOC_INHIBIT_VALLOC): Don't define.
1614 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1615
22e983b7
JB
16162012-07-14 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1619
5b3f250f
GM
16202012-07-14 Glenn Morris <rgm@gnu.org>
1621
1622 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1623 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1624 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1625
33d63ff4
GM
16262012-07-13 Glenn Morris <rgm@gnu.org>
1627
5b633342
GM
1628 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1629
33d63ff4
GM
1630 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1631 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1632
b55b9f85
JD
16332012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1634
0dc8cf50
JD
1635 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1636 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1637 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1638 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1639 where appropriate.
1640 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1641 as boolean expression.
1642 (x_set_window_size): Remove unused variable toolbar.
1643 (ns_get_color_default, ns_mod_to_lisp): Remove.
1644 (ns_mouse_position): Remove unused variables xchar and ychar.
1645 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1646 (ns_set_vertical_scroll_bar): Remove unused variable count.
1647 (ns_delete_terminal): Remove unused variable i.
1648 (ns_term_init): Remove unused variables r, g and b.
1649 (mouseDown): Remove unused variable window.
1650 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1651 (initFrameFromEmacs): Remove unused variable vbextra.
1652 (mouseEntered): Remove unused variables p and dpyinfo.
1653 (mouseExited): Remove unused variables p and r.
1654 (ns_define_frame_cursor, ns_clear_frame_area)
1655 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1656 (menuDown): Assign [sender tag] to variable and cast the variable.
1657
1658 * nsterm.h (menuDown): Add id as type to argument sender.
1659 (ns_display_info_for_name): Add Lisp_Object argument.
1660 (ns_term_init): Add Lisp_Object argument.
1661 (ns_map_event_to_object): Add void argument.
1662 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1663 prototype with arguments and only declare if __OBJC__.
1664 (nxatoms_of_nsselect): Add void argument.
1665 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1666 (ns_alloc_autorelease_pool): Add void argument.
1667 (ns_release_autorelease_pool): Add void* argument.
1668 (ns_get_defaults_value): Add const char* argument.
1669
1670 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1671 (initFromContents): Use SSDATA where appropriate.
1672 (ns_update_menubar): Add braces to ambigous if-else.
1673 (initWithTitle): Put () around assignment in if statement.
1674 (ns_menu_show): Remove unused variables window and keymap.
1675 (update_frame_tool_bar): Remove unused variable selected_p.
1676 (initWithContentRect): Remove unused variable this_cmd_name.
1677
1678 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1679 appropriate.
1680 (setXBMColor): Remove unused variable len.
1681 (setPixmapData): Put () around assignment in loop statement.
1682
1683 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1684 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1685 where appropriate.
1686 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1687 around assignment in loop statement.
1688 (nsfont_open): Remove unused variable i.
1689 (nsfont_open): Remove unused variable len.
1690 (nsfont_draw): Remove unused variable cs.
1691
1692 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1693 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1694 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1695 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1696 (Fns_font_name, Fns_perform_service)
1697 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1698 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1699 (ns_set_name): Remove unused variable view.
1700 (x_set_menu_bar_lines): Remove unused variable olines.
1701 (x_set_tool_bar_lines): Remove unused variable root_window.
1702 (Fns_list_colors): Put () around assignment in while statement.
1703 (Fns_perform_service): Remove unused variable len.
1704 (Fns_display_usable_bounds): Remove unused variable top.
1705 (syms_of_nsfns): Remove unused variable i.
1706
b55b9f85
JD
1707 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1708 memcpy (Bug#11907).
1709
ed9265fc 17102012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1711
1712 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1713 and free it with DestroyExceptionInfo (Bug#11558).
1714
ef099b57
JB
17152012-07-13 Juanma Barranquero <lekktu@gmail.com>
1716
1717 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1718 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1719 Set here, not in nt/config.nt.
1720
ea814a5d
EZ
17212012-07-13 Eli Zaretskii <eliz@gnu.org>
1722
1723 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1724 cursor overflow into the last glyph on display line when the right
1725 fringe is off. (Bug#11832)
1726
1a952767
PE
17272012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1728
1729 * xdisp.c (produce_special_glyphs): Now static.
1730 * dispextern.h (produce_special_glyphs): Remove decl.
1731
983188fd
GM
17322012-07-13 Glenn Morris <rgm@gnu.org>
1733
8d7c7eed 1734 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1735 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1736
983188fd
GM
1737 * s/usg5-4-common.h (USG, USG5):
1738 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1739 * s/sol2-6.h (SOLARIS2):
1740 * s/irix6-5.h (IRIX6_5):
1741 * s/hpux10-20.h (USG, USG5, HPUX):
1742 * s/gnu-linux.h (USG, GNU_LINUX):
1743 * s/freebsd.h (BSD_SYSTEM):
1744 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1745 * s/cygwin.h (CYGWIN):
1746 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1747 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1748
d1e68667 17492012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1750
1751 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1752
6de0e799
GM
17532012-07-13 Glenn Morris <rgm@gnu.org>
1754
739ae010
GM
1755 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1756
dbee5793
GM
1757 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1758
6de0e799
GM
1759 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1760 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1761
b82da769
GM
17622012-07-12 Glenn Morris <rgm@gnu.org>
1763
4fae5a7a 1764 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1765
1766 * process.c (init_process_emacs): Rename from init_process.
1767 The old name is also the name of a Mach system call.
1768 * lisp.h, emacs.c: Update for this name change.
1769 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1770 longer needed.
1771
5a979817
EZ
17722012-07-12 Eli Zaretskii <eliz@gnu.org>
1773
1774 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1775 memmove call that removes glyphs covered by the left truncation
1776 glyph. Improve commentary.
1777 (display_line): Fix display of continuation glyphs on GUI frames
1778 when the right fringe is turned off and variable-size fonts are
1779 used in the window. Move the code that appends a stretch glyph to
1780 produce_special_glyphs, so that it could be used for truncation
1781 and continuation glyphs alike.
1782 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1783 glyph of a suitably computed width, to align the special glyphs at
1784 the window margin. Code moved from display_line. (Bug#11832)
1785
3e91a053
GM
17862012-07-12 Glenn Morris <rgm@gnu.org>
1787
ba9e4b84
GM
1788 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1789
1790 * s/gnu-linux.h, s/hpux10-20.h:
1791 Do not unconditionally define HAVE_XRMSETDATABASE.
1792
3e91a053
GM
1793 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1794
b300b1f4
PE
17952012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 Fix typos that broke OS X build.
1798 Reported by Randal L. Schwartz in
1799 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1800 * nsterm.m (ns_timeout): Add missing local decl.
1801 (ns_get_color): snprintf -> sprintf, to fix typo.
1802
6e777848
GM
18032012-07-12 Glenn Morris <rgm@gnu.org>
1804
3f922c37
GM
1805 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1806 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1807 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1808 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1809
0ab7b23a
GM
1810 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1811 Move PTY_OPEN to configure.
1812
6e777848
GM
1813 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1814 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1815 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1816
4a7edc24
DA
18172012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1818
1819 Use empty_unibyte_string where applicable.
1820 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1821 * lread.c (read1): Likewise.
1822 * xsettings.c (syms_of_xsettings): Likewise.
1823
308aab79
GM
18242012-07-12 Glenn Morris <rgm@gnu.org>
1825
42bd1719
GM
1826 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1827 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1828 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1829 * s/hpux10-20.h (RUN_TIME_REMAP):
1830 * s/bsd-common.h (TABDLY): Move to configure.
1831
1832 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1833
1834 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1835
ea0bbd17 1836 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1837 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1838
1839 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1840
308aab79
GM
1841 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1842 * s/template.h: Move NARROWPROTO to configure.
1843
ee1cf5cf
GM
18442012-07-11 Glenn Morris <rgm@gnu.org>
1845
30fe9bf4
GM
1846 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1847 unused since 2011-01-17 change to systty.h.
1848
ee1cf5cf
GM
1849 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1850 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1851 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1852
63e47e07
PE
18532012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1856
c43fb4c3
GM
18572012-07-11 Glenn Morris <rgm@gnu.org>
1858
1859 * s/darwin.h, s/gnu-linux.h, s/template.h:
1860 Move INTERRUPT_INPUT to configure.
1861
e8df9267
DA
18622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1863
1864 Minor adjustments to interning code.
1865 * lisp.h (intern, intern_c_string): Redefine as static inline
1866 wrappers for intern_1 and intern_c_string_1, respectively.
1867 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1868 * lread.c (intern_1, intern_c_string_1, oblookup):
1869 Simplify Vobarray checking.
e8df9267
DA
1870 * font.c (font_intern_prop): Likewise. Adjust comment.
1871 * w32font.c (intern_font_name): Likewise.
1872
34348bd4
AS
18732012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1874
d96a1e0c
AS
1875 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1876
34348bd4
AS
1877 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1878 of Fcar/Fcdr if possible.
1879 * font.c (check_otf_features): Likewise.
1880 * fontset.c (Fnew_fontset): Likewise.
1881 * gnutls.c (Fgnutls_boot): Likewise.
1882 * minibuf.c (read_minibuf): Likewise.
1883 * msdos.c (IT_set_frame_parameters): Likewise.
1884 * xmenu.c (Fx_popup_dialog): Likewise.
1885 * w32menu.c (Fx_popup_dialog): Likewise.
1886
c8add24e
GM
18872012-07-11 Glenn Morris <rgm@gnu.org>
1888
4b575b3c
GM
1889 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1890 since nothing has defined it on these platforms.
1891
09f4e3b0
GM
1892 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1893 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1894
172bedef
GM
1895 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1896 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1897 Move CLASH_DETECTION to configure.
1898
249685df
GM
1899 * s/gnu.h: Remove file, which is now empty.
1900
c8add24e
GM
1901 * s/gnu.h, s/gnu-linux.h:
1902 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1903
b41253a3
JW
19042012-07-11 John Wiegley <johnw@newartisans.com>
1905
1906 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1907 function attribute, so we only use it if it exists in the
1908 compiler.
1909
d923b542
DA
19102012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1911
1912 Avoid call to strlen in fast_c_string_match_ignore_case.
1913 * search.c (fast_c_string_match_ignore_case): Change to use
1914 length argument. Adjust users accordingly.
1915 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1916
5ebbef1d
PE
19172012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1918
bb352260
PE
1919 Assume mkdir, rmdir.
1920 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1921 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1922
57054ddd
PE
1923 Assume rename.
1924 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1925
b747d3f7
PE
1926 Assume perror.
1927 * s/hpux10-20.h (HAVE_PERROR): Remove.
1928 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1929 Remove dummy definition, as this problem was obsolete long ago.
1930
5ebbef1d
PE
1931 Assume strerror.
1932 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1933
984e7f30
DA
19342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1935
1936 Avoid calls to strlen in font processing functions.
1937 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1938 (font_open_by_name): Change to use length argument.
1939 Adjust users accordingly.
d923b542
DA
1940 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1941 Adjust prototypes.
1942 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1943 Change to return ptrdiff_t.
984e7f30
DA
1944 (xfont_list_pattern, xfont_match): Use length returned by
1945 xfont_decode_coding_xlfd.
1946 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1947
20e94fdd
GM
19482012-07-11 Glenn Morris <rgm@gnu.org>
1949
9d596af3
GM
1950 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1951 Move DONT_REOPEN_PTY to configure.
1952
20e94fdd
GM
1953 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1954 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1955
e99a530f
PE
19562012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1957
22ffb973
PE
1958 Remove "#define unix" that is no longer needed (Bug#11905).
1959 * s/aix4-2.h (unix): Remove; no longer needed.
1960
e9a9ae03
PE
1961 EMACS_TIME simplification (Bug#11875).
1962 This replaces macros (which typically do not work in GDB)
1963 with functions, typedefs and enums, making the code easier to debug.
1964 The functional style also makes code easier to read and maintain.
1965 * systime.h: Include <sys/time.h> on all hosts, not just if
1966 WINDOWSNT, since 'struct timeval' is needed in general.
1967 (EMACS_TIME): Now a typedef, not a macro.
1968 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1969 not macros.
1970 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1971 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1972 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1973 (EMACS_TIME_LE): Now functions, not macros.
1974 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1975 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1976 which are not functions. All uses rewritten to use:
1977 (make_emacs_time): New function.
1978 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1979 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1980 not functions. All uses rewritten to use the following, respectively:
1981 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1982 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1983 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1984 * fileio.c (Fcopy_file):
1985 * xterm.c (XTflash): Get the current time closer to when it's used.
1986 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1987
ffacb126
PE
1988 * bytecode.c (targets): Suppress -Woverride-init warnings.
1989
e99a530f
PE
1990 Simplify by avoiding confusing use of strncpy etc.
1991 * doc.c (Fsnarf_documentation):
1992 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1993 * frame.c (Fmake_terminal_frame):
1994 * gtkutil.c (get_utf8_string):
1995 * lread.c (openp):
1996 * nsmenu.m (ns_update_menubar):
1997 * regex.c (regerror):
1998 Prefer memcpy to strncpy and strncat when either will do.
1999 * fileio.c (Fsubstitute_in_file_name):
2000 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2001 (menu_separator_name_p):
2002 * nsmenu.m (ns_update_menubar):
2003 Prefer memcmp to strncmp when either will do.
2004 * nsterm.m: Include <ftoastr.h>.
2005 (ns_get_color):
2006 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2007 Prefer snprintf to strncpy.
2008 * nsterm.m (ns_term_init):
2009 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2010 * nsterm.m (ns_term_init):
2011 Avoid the need for strncpy, by using build_string or
2012 make_unibyte_string directly. Use dtoastr, not snprintf.
2013 * process.c (Fmake_network_process): Diagnose service names that
2014 are too long, rather than silently truncating them or creating
2015 non-null-terminated names.
2016 (Fnetwork_interface_info): Likewise, for interface names.
2017 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2018 Prefer sprintf to strncat.
2019 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2020 Prefer vsnprintf to vsprintf + strncpy.
2021
c59592b3
GM
20222012-07-10 Glenn Morris <rgm@gnu.org>
2023
2024 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2025 Clarify fallback case.
2026
7d7bbefd
DA
20272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2028
2029 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2030 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2031 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2032 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2033 where argument type is known to be a Lisp_Cons.
2034
3a4c8000
TT
20352012-07-10 Tom Tromey <tromey@redhat.com>
2036
2037 * bytecode.c (BYTE_CODE_THREADED): New macro.
2038 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2039 (enum byte_code_op): New type.
2040 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2041 (exec_byte_code): Use them. Use token threading when applicable.
2042
2a0213a6
DA
20432012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2044
2045 Optimize pure C strings initialization.
2046 * lisp.h (make_pure_string): Fix prototype.
2047 (build_pure_c_string): New function, defined as static inline. This
2048 provides a better opportunity to optimize away calls to strlen when
2049 the function is called with compile-time constant argument.
2050 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2051 argument, adjust users accordingly. Use build_pure_c_string where
2052 appropriate.
2053 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2054 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2055 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2056
cb1caeaf
DA
20572012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2058
2059 Avoid calls to strlen in miscellaneous functions.
2060 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2061 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2062 * lread.c (openp): Likewise.
2063
c293e30c
DA
20642012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2065
2066 Avoid calls to strlen in path processing functions.
2067 * fileio.c (file_name_as_directory): Add comment. Change to add
2068 srclen argument and return the length of result. Adjust users
2069 accordingly.
2070 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2071 swap 1st and 2nd arguments to obey the common convention.
2072 Adjust users accordingly.
c293e30c
DA
2073 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2074
9e059e3f
GM
20752012-07-10 Glenn Morris <rgm@gnu.org>
2076
d02eb359
GM
2077 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2078 Move PENDING_OUTPUT_COUNT definition to configure.
2079
882cf227
GM
2080 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2081 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2082 * s/gnu.h (DATA_START): Move definitions to configure.
2083
af6e839f
GM
2084 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2085 We include usg5-4-common.h, which defines them both.
2086
40289a12
GM
2087 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2088 O_RDONLY already includes it).
2089
9e059e3f
GM
2090 Stop ns builds setting the EMACSLOADPATH environment variable.
2091 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2092 Now it does not set EMACSLOADPATH, just returns the load-path string.
2093 * nsterm.h: Update accordingly.
2094 * lread.c [HAVE_NS]: Include nsterm.h.
2095 (init_lread) [HAVE_NS]: Use ns_load_path.
2096 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2097
7c4e8ec0
GM
20982012-07-09 Glenn Morris <rgm@gnu.org>
2099
d4f600ff
GM
2100 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2101 since the included bsd-common.h does so.
2102
cbb31951
GM
2103 Stop ns builds setting the EMACSPATH environment variable.
2104 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2105 (ns_init_paths): Do not set EMACSPATH.
2106 * nsterm.h (ns_exec_path): Add it.
2107 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2108 Use ns_exec_path.
2109
7c4e8ec0
GM
2110 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2111
26bccfae
PE
21122012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2113
a0bee46f
PE
2114 * process.c (wait_reading_process_output): 'waitchannels' was unset
2115 when read_kbd || !NILP (wait_for_cell); fix this.
2116
5994c183
PE
2117 Add GCC-style 'const' attribute to functions that can use it.
2118 * character.h (char_resolve_modifier_mask):
2119 * keyboard.h (make_ctrl_char):
2120 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2121 (init_character_once, next_almost_prime, init_fns, init_image)
2122 (flush_pending_output, init_sound):
2123 * mem-limits.h (start_of_data):
2124 * menu.h (finish_menu_items):
2125 Add ATTRIBUTE_CONST.
2126 * emacs.c (DEFINE_DUMMY_FUNCTION):
2127 Declare the dummy function with ATTRIBUTE_CONST.
2128 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2129 Add decls with ATTRIBUTE_CONST.
2130
26bccfae
PE
2131 Minor improvements to make_formatted_string.
2132 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2133 where int is good enough, as vsprintf returns an int.
2134 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2135
a8290ec3
DA
21362012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 Use make_formatted_string to avoid double length calculation.
2139 * lisp.h (make_formatted_string): New prototype.
2140 * alloc.c (make_formatted_string): New function.
2141 * buffer.c (Fgenerate_new_buffer_name): Use it.
2142 * dbus.c (syms_of_dbusbind): Likewise.
2143 * editfns.c (Fcurrent_time_zone): Likewise.
2144 * filelock.c (get_boot_time): Likewise.
2145 * frame.c (make_terminal_frame, set_term_frame_name)
2146 (x_report_frame_params): Likewise.
2147 * image.c (gs_load): Likewise.
2148 * minibuf.c (get_minibuffer): Likewise.
2149 * msdos.c (dos_set_window_size): Likewise.
2150 * process.c (make_process): Likewise.
2151 * xdisp.c (ensure_echo_area_buffers): Likewise.
2152 * xsettings.c (apply_xft_settings): Likewise.
2153
d01ba2f1
GM
21542012-07-09 Glenn Morris <rgm@gnu.org>
2155
2156 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2157 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2158 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2159 * nsterm.h (ns_etc_directory): Add it.
2160 * callproc.c [HAVE_NS]: Include nsterm.h.
2161 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2162
f1f924b6
DA
21632012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2164
2165 Move marker debugging code under MARKER_DEBUG.
2166 * marker.c (MARKER_DEBUG): Move marker debugging code under
2167 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2168 for bootstrap with --enable-checking (~3x slowdown reported
2169 by Juanma Barranquero <lekktu@gmail.com>).
2170 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2171
ab531b66
PE
21722012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2175 See <http://bugs.gnu.org/11825#29>.
2176
c4b3bc8a
EZ
21772012-07-08 Eli Zaretskii <eliz@gnu.org>
2178
2179 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2180 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2181 (display_line): Add commentary about displaying truncation glyphs
2182 on GUI frames.
2183 (produce_special_glyphs): Move here from term.c.
2184
2185 * term.c (produce_special_glyphs): Move to xdisp.c.
2186
2187 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2188 section.
c4b3bc8a 2189
b676b881
AS
21902012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2191
f17c5273
AS
2192 * xdisp.c (display_line): Avoid warning about implicit declaration
2193 of FRAME_FONT.
2194
298819b9
AS
2195 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2196
b676b881
AS
2197 * lisp.h: Remove empty conditional.
2198
6045c4fd
PE
21992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2200
b3350bf9
PE
2201 * lread.c (load_path_check): Now static.
2202
6045c4fd
PE
2203 Fix some minor --with-ns problems found by static checking.
2204 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2205 (x_set_font) [!HAVE_X_WINDOWS]:
2206 * image.c (xpm_load_image) [HAVE_NS]:
2207 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2208 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2209 Remove unused local.
2210 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2211 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2212 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2213 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2214 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2215 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2216 Fix pointer signedness problem.
2217 * xfaces.c (FRAME_X_FONT_TABLE):
2218 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2219
929e7845
GM
22202012-07-07 Glenn Morris <rgm@gnu.org>
2221
2222 * lread.c (load_path_check): New function, split from init_lread.
2223 (init_lread): Reorganize. Motivation:
2224 If EMACSLOADPATH is set, check/warn about that rather than the
2225 defaults, which we are not going to use. Hence we can remove
2226 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2227 Don't warn if site-lisp directories are missing.
2228 If not installed, start from a blank load-path, since
2229 PATH_LOADSEARCH refers to the eventual installation directories.
2230
58dd0aa4
EZ
22312012-07-07 Eli Zaretskii <eliz@gnu.org>
2232
2233 Support truncation and continuation glyphs on GUI frames, when
2234 fringes are disabled. (Bug#11832)
2235 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2236 continuation glyphs even if on GUI frames.
2237 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2238 or both, are absent.
2239 (start_display, move_it_in_display_line_to): Handle the case of a
2240 GUI frame without a fringe to display continuation or truncation
2241 glyphs.
2242 (insert_left_trunc_glyphs): Support GUI frames: make sure
2243 truncation glyphs overwrite enough glyphs from the current line to
2244 have sufficient space in pixels.
2245 (display_line): Support truncation and continuation glyphs on GUI
2246 frames. If some spare pixels are left on the line after inserting
2247 the truncation glyphs, fill that space with a stretch glyph of a
2248 suitably computed width.
2249
2250 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2251 produce_glyphs, to support GUI sessions.
2252
31571fd7
PE
22532012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2254
5a16b9bc
PE
2255 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2256
f3047c75
PE
2257 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2258
31571fd7
PE
2259 Do not require float-time's arg to fit in time_t (Bug#11825).
2260 This works better on hosts where time_t is unsigned, and where
2261 float-time is applied to the (negative) difference between two times.
2262 * editfns.c (decode_time_components): Last arg is now double *,
2263 not int *, and means to store all the result as a double, without
2264 worrying about whether the seconds part fits in time_t.
2265 All callers changed.
2266 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2267 All callers changed.
2268 (Ffloat_time): Do not fail merely because the specified time falls
2269 outside of time_t range.
2270
4516fbef
GM
22712012-07-07 Glenn Morris <rgm@gnu.org>
2272
2273 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2274 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2275 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2276
07adc2c6
JB
22772012-07-07 Juanma Barranquero <lekktu@gmail.com>
2278
2279 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2280 Update dependencies.
2281
2282 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2283
fd573f31
PE
22842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2285
fee5959d
PE
2286 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2287 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2288 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2289 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2290 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2291 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2292
fd573f31
PE
2293 * xfont.c (compare_font_names): Redo to omit the need for casts.
2294
ddadbc0e
AS
22952012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2296
fca8d6b6
AS
2297 * xfns.c (Fx_change_window_property): Doc fix.
2298 * w32fns.c (Fx_change_window_property): Doc fix.
2299
ddadbc0e
AS
2300 * w32fns.c (Fx_window_property): Accept the same arguments as the
2301 X Windows version. Doc fix.
2302 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2303
ed9265fc 23042012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2305 Eli Zaretskii <eliz@gnu.org>
2306
2307 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2308 Windows-specific code from nt/config.nt moved here.
2309 Obsolete settings removed.
2310
216ee680
PE
23112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * process.c: Avoid unnecessary calls to gettime.
2314 (wait_reading_process_output): Don't get the time of day
2315 when gobbling data immediately and not waiting, as there's no need
2316 for it in that case. This removes a FIXME.
2317
bdd091e4
JD
23182012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2319
2320 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2321 is defined (Bug#11768).
2322
9d44f8ce
DA
23232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2324
2325 Fix marker debugging code.
2326 * marker.c (byte_char_debug_check): Do not perform the check
2327 if buffer is not multibyte.
090bd7cb
JB
2328 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2329 Call byte_char_debug_check with correct arguments.
9d44f8ce 2330
90fc4786
DA
23312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2332
2333 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2334 * marker.c (byte_char_debug_check, count_markers):
2335 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2336 (byte_debug_flag): Remove.
2337 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2338 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2339
7b7ae965
DA
23402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2341
4e57b342
DA
2342 Avoid code repetition in marker-related functions.
2343 * marker.c (attach_marker): New function.
2344 (Fset_marker, set_marker_restricted, set_marker_both)
2345 (set_marker_restricted_both): Use it.
2346 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2347 Consistently rename charno to charpos.
2348 (marker_position): Add eassert.
2349 (marker_byte_position): Convert to eassert.
2350
23512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2352
2353 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2354 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2355 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2356
657924ff
DA
23572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2358
2359 Introduce fast path for the widely used marker operation.
2360 * alloc.c (build_marker): New function.
2361 * lisp.h (build_marker): New prototype.
2362 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2363 * composite.c (autocmp_chars): Likewise.
2364 * editfns.c (buildmark): Remove.
2365 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2366 (save_restriction_save): Use build_marker.
2367 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2368 * window.c (save_window_save): Likewise.
2369
041a49a6
DA
23702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2371
2372 Do not use Fdelete_overlay in delete_all_overlays
2373 to avoid redundant calls to unchain_overlay.
2374 * buffer.c (drop_overlay): New function.
2375 (delete_all_overlays, Fdelete_overlay): Use it.
2376 * minibuf.c (get_minibuffer): Fix comment.
2377
7dca65a4
PE
23782012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Port to OpenBSD 5.1 amd64.
2381 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2382 This is needed for OpenBSD, and should be harmless on all BSD systems.
2383 Also, include <sys/sysctl.h>, as it should be available on all
2384 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2385 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2386 use p_pid member, not kp_proc.pid.
2387
8eb876e2
GM
23882012-07-06 Glenn Morris <rgm@gnu.org>
2389
2390 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2391
38182d90
PE
23922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 More xmalloc and related cleanup.
2395 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2396 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2397 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2398 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2399 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2400 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2401 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2402 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2403 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2404 * xterm.c:
2405 Omit needless casts involving void * pointers and allocation.
2406 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2407 as the former is more robust if P's type is changed.
2408 Prefer xzalloc to xmalloc + memset 0.
2409 Simplify malloc-or-realloc to realloc.
2410 Don't worry about xmalloc returning a null pointer.
2411 Prefer xstrdup to xmalloc + strcpy.
2412 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2413 growing it.
2414 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2415 alloca of a constant.
2416
6dd5a677
EZ
24172012-07-05 Eli Zaretskii <eliz@gnu.org>
2418
2419 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2420 hscroll is larger than the line width. Fixes long and futile
2421 looping inside extend_face_to_end_of_line (on a TTY) producing
2422 glyphs that are not needed and thrown away.
2423
6b312f0f
DA
24242012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2425
2426 * marker.c (set_marker_restricted_both): Simplify by using
2427 clip_to_bounds.
2428
f520ef9b
PE
24292012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2432
383b7c95
JD
24332012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2434
2435 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2436 not defined (Bug#11768).
2437 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2438 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2439 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2440 followed by gtk_box_set_homogeneous (Bug#11768).
2441 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2442 (update_theme_scrollbar_width, xg_create_scroll_bar):
2443 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2444 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2445 (is_box_type): New function (Bug#11768).
2446 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2447 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2448 with default display (Bug#11768).
2449
d6e7bf45
EZ
24502012-07-05 Eli Zaretskii <eliz@gnu.org>
2451
2452 * xdisp.c (window_hscroll_limited): New function.
2453 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2454 coordinates when window's hscroll is set to insanely large
2455 values. (Bug#11857)
2456
431391ec
JB
24572012-07-05 Juanma Barranquero <lekktu@gmail.com>
2458
2459 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2460 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2461
23f86fce
DA
24622012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2463
2464 Cleanup xmalloc.
2465 * lisp.h (xzalloc): New prototype. Omit needless casts.
2466 * alloc.c (xzalloc): New function. Omit needless casts.
2467 * charset.c: Omit needless casts. Convert all calls to
2468 xmalloc with following memset to xzalloc.
2469 * dispnew.c: Likewise.
2470 * fringe.c: Likewise.
2471 * image.c: Likewise.
2472 * sound.c: Likewise.
2473 * term.c: Likewise.
2474 * w32fns.c: Likewise.
2475 * w32font.c: Likewise.
2476 * w32term.c: Likewise.
2477 * xfaces.c: Likewise.
2478 * xfns.c: Likewise.
2479 * xterm.c: Likewise.
2480 * atimer.c: Omit needless casts.
2481 * buffer.c: Likewise.
2482 * callproc.c: Likewise.
2483 * ccl.c: Likewise.
2484 * coding.c: Likewise.
2485 * composite.c: Likewise.
2486 * doc.c: Likewise.
2487 * doprnt.c: Likewise.
2488 * editfns.c: Likewise.
2489 * emacs.c: Likewise.
2490 * eval.c: Likewise.
2491 * filelock.c: Likewise.
2492 * fns.c: Likewise.
2493 * gtkutil.c: Likewise.
2494 * keyboard.c: Likewise.
2495 * lisp.h: Likewise.
2496 * lread.c: Likewise.
2497 * minibuf.c: Likewise.
2498 * msdos.c: Likewise.
2499 * print.c: Likewise.
2500 * process.c: Likewise.
2501 * region-cache.c: Likewise.
2502 * search.c: Likewise.
2503 * sysdep.c: Likewise.
2504 * termcap.c: Likewise.
2505 * terminal.c: Likewise.
2506 * tparam.c: Likewise.
2507 * w16select.c: Likewise.
2508 * w32.c: Likewise.
2509 * w32reg.c: Likewise.
2510 * w32select.c: Likewise.
2511 * w32uniscribe.c: Likewise.
2512 * widget.c: Likewise.
2513 * xdisp.c: Likewise.
2514 * xmenu.c: Likewise.
2515 * xrdb.c: Likewise.
2516 * xselect.c: Likewise.
2517
0497dc44
PE
25182012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 * fileio.c (time_error_value): Check the right error number.
2521 Problem reported by Troels Nielsen in
2522 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2523
356e7178
PE
25242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2525
4e71fd89
PE
2526 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2527 This should be fixed in a better way; see Eli Zaretskii in
2528 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2529 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2530
f0941253
PE
2531 * fileio.c (time_error_value): Rename from special_mtime.
2532 The old name's problems were noted by Eli Zaretskii in
2533 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2534
065c9eb4
PE
2535 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2536 This variable's comment says Emacs needs at least one GDB-visible
2537 symbol of type enum pvec_type, to work around GDB problems.
2538 The symbol's value doesn't matter.
2539
356e7178
PE
2540 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2541 that causes compilation to fail on pre-C99 compilers.
2542
ed9265fc 25432012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2544
2545 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2546 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2547
3884d954
DA
25482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2549
d209e2fb 2550 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2551 headers for buffer_defaults and buffer_local_symbols.
2552 Reported by Juanma Barranquero <lekktu@gmail.com>.
2553
ee28be33
SM
25542012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2555
2556 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2557 * lisp.h (enum pvec_type): Use fewer bits.
2558 (PSEUDOVECTOR_SIZE_BITS): New constant.
2559 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2560 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2561 change in pvec_type.
2562 (PSEUDOVECTOR_TYPEP): New macro.
2563 (TYPED_PSEUDOVECTORP): Use it.
2564 * fns.c (internal_equal): Adapt code to extract pvectype.
2565 * emacs.c (gdb_pvec_type): Update type.
2566 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2567 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2568 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2569 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2570 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2571 abusing vector->header.next.nbytes.
2572 (live_vector_p): Use PVEC_TYPE.
2573 (mark_object): Adapt code to extract pvectype. Use switch.
2574
c7f2cd7f
PE
25752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2578 Tighten new eassert a bit.
2579
8ce70ed2
DA
25802012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2581
2582 Fix compilation with --enable-gcc-warnings and -O1
2583 optimization level.
2584 * doprnt.c (doprnt): Change type of tem to int, initialize
2585 to avoid compiler warning. Add eassert.
2586 * search.c (simple_search): Initialize match_byte to avoid
2587 compiler warning. Add eassert.
2588
dea7f1e5
PE
25892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2590
24a212eb
PE
2591 Avoid weird behavior with large horizontal scrolls.
2592 Without this change, for example, large hscroll values would
2593 mess up Emacs's display on Fedora 15 x86, presumably due to
2594 overflows in int calculations in the display code.
2595 Also, if buffers had long lines, Emacs would freeze.
2596 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2597 (set_window_hscroll): New function, containing the old guts of
2598 Fset_window_hscroll. Return the clipped value.
2599 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2600 This avoids the need to check against PTRDIFF_MAX.
2601
dea7f1e5
PE
2602 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2603
76046526
DA
26042012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2605
2606 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2607
39adff0d
PE
26082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2609
63807d47
PE
2610 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2611 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2612 since GCC 4.4.6 issues a bogus warning for them.
2613
39adff0d
PE
2614 Fix bugs in file timestamp newness comparisons.
2615 * fileio.c (Ffile_newer_than_file_p):
2616 * lread.c (Fload): Use full timestamp resolution of files,
2617 not just the 1-second resolution, so that files that are only
2618 slightly newer still count as newer.
2619 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2620 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2621
dbeed9a6
PE
26222012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 * fileio.c: Improve handling of file time marker. (Bug#11852)
2625 (special_mtime): New function.
2626 (Finsert_file_contents, Fverify_visited_file_modtime):
2627 Use it to set special mtime values consistently.
2628
636334d6
AS
26292012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2630
2631 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2632 marker for non-existing file. (Bug#11852)
2633
e2017fe2
GM
26342012-07-03 Glenn Morris <rgm@gnu.org>
2635
2636 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2637 and did not make it into globals.h).
2638
404dbd37
TT
26392012-07-03 Tom Tromey <tromey@redhat.com>
2640
2641 * window.c (Fset_window_margins, Fset_window_fringes)
2642 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2643 * textprop.c (Fprevious_property_change): No longer static.
2644 * syntax.c (Fsyntax_table_p): No longer static.
2645 * process.c (Fget_process, Fprocess_datagram_address): No longer
2646 static.
2647 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2648 * keyboard.c (Fcommand_execute): No longer static.
2649 Remove EXFUN.
2650 * insdel.c (Fcombine_after_change_execute): No longer static.
2651 * image.c (Finit_image_library): No longer static.
2652 * fileio.c (Fmake_symbolic_link): No longer static.
2653 * eval.c (Ffetch_bytecode): No longer static.
2654 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2655 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2656 No longer static.
404dbd37
TT
2657 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2658 static.
2659 * dired.c (Ffile_attributes): No longer static.
2660 * composite.c (Fcomposition_get_gstring): No longer static.
2661 * callproc.c (Fgetenv_internal): No longer static.
2662
2663 * ccl.h: Remove EXFUNs.
2664 * buffer.h: Remove EXFUNs.
2665 * dispextern.h: Remove EXFUNs.
2666 * intervals.h: Remove EXFUNs.
2667 * fontset.h: Remove EXFUN.
2668 * font.h: Remove EXFUNs.
2669 * dosfns.c (system_process_attributes): Remove EXFUN.
2670 * keymap.h: Remove EXFUNs.
2671 * lisp.h: Remove EXFUNs.
2672 * w32term.h: Remove EXFUNs.
2673 * window.h: Remove EXFUNs.
2674 * xsettings.h: Remove EXFUN.
2675 * xterm.h: Remove EXFUN.
2676
8e4fd1e1
GM
26772012-07-03 Glenn Morris <rgm@gnu.org>
2678
2679 * lisp.h (Frandom): Make it visible to C.
2680 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2681 buffer for invisible buffers. (Bug#1229)
2682
ca95b3eb
DA
26832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2684
2685 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2686 values which aren't power of 2.
14ae4239
BT
2687 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2688 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2689 accordingly.
2690
7555c33f
SM
26912012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2692
2693 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2694
2695 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2696
d12e8f5a
DA
26972012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2698
2699 * alloc.c (allocate_vector_block): Remove redundant
2700 calls to mallopt if DOUG_LEA_MALLOC is defined.
2701 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2702 avoid calls to mallopt if zero_vector is returned.
2703
296094c3
DA
27042012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2705
2706 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2707 is enabled, avoid dereferencing NULL current_sblock if
2708 running undumped.
2709
36429c89
DA
27102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2711
2712 Cleanup basic buffer management.
2713 * buffer.h (struct buffer): Change layout to use generic vector
2714 marking code. Fix some comments. Change type of 'clip_changed'
2715 to bitfield. Remove unused #ifndef old.
2716 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2717 (GET_OVERLAYS_AT): Fix indentation.
2718 (for_each_per_buffer_object_at): New macro.
2719 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2720 (Fbuffer_local_variables): Use it.
2721 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2722 * alloc.c (allocate_buffer): Adjust to match new layout of
2723 struct buffer. Fix comment.
2724 (mark_overlay): New function.
2725 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2726 Lisp area of struct buffer.
2727 (mark_object): Use it. Adjust marking of misc objects
2728 and related comments.
2729
3b3e4cac
PE
27302012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2731
2732 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2733 wrapper that is not needed because the wrapped code is a no-op (zero
2734 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2735 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2736
cf5c0175
DA
27372012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2738
2739 * alloc.c (mark_buffer): Simplify. Remove prototype.
2740 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2741 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2742 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2743 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2744
ca26824c
GM
27452012-06-30 Glenn Morris <rgm@gnu.org>
2746
2e4c5312
GM
2747 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2748
ca26824c
GM
2749 * epaths.in (PATH_SITELOADSEARCH): New.
2750 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2751 This is rather than relying on --enable-locallisppath elements
2752 having "site-lisp" in their names. (Bug#10208#25, 11658)
2753
0d23c240
EZ
27542012-06-30 Eli Zaretskii <eliz@gnu.org>
2755
c9240d7a
EZ
2756 * w32proc.c (sys_select): Accept and ignore one more argument.
2757
2758 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2759
0d23c240 2760 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2761 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2762
2763 * sysdep.c: Don't include dos.h and dosfns.h.
2764
2765 * process.c (sys_select):
2766 * msdos.c (sys_select): Accept one more argument and ignore it.
2767
2768 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2769 adapt data types and code to that.
2770
2771 * dosfns.c:
2772 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2773 which clashes with the gnulib function of the same name.
2774
af5a5a98
AS
27752012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2776
c5e4379c
AS
2777 * font.c (font_style_to_value, font_style_symbolic)
2778 (font_prop_validate_style): Add type checks for values in
2779 font_style_table.
2780
af5a5a98
AS
2781 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2782 argument.
2783 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2784 uses.
2785
8d38f461
EZ
27862012-06-29 Eli Zaretskii <eliz@gnu.org>
2787
2e5a6631
EZ
2788 * xdisp.c (try_window_id): Undo last change.
2789
8d38f461
EZ
2790 * w32.c (getwd): Adjust commentary about startup_dir.
2791 (init_environment): Always call sys_access, even in non-MSVC
2792 builds. Don't chdir to the directory of the Emacs executable.
2793 This undoes code from 1997 which was justified by the need to
2794 "avoid conflicts when removing and renaming directories". But its
2795 downside was that every relative file name was being interpreted
2796 relative to the directory of the Emacs executable, which can never
2797 be TRT. In particular, it broke sys_access when called with
2798 relative file names.
2799 (sys_access): Map GetLastError to errno.
2800
2af3565e
DA
28012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2802
2803 * window.h (struct window): Change type of 'fringes_outside_margins'
2804 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2805 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2806 Adjust comment.
2807 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2808 to ptrdiff_t.
2809
c8d3a25c 28102012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2811
c8d3a25c
GM
2812 * gnutls.c (emacs_gnutls_handshake):
2813 Add QUIT to make the loop interruptible.
57570cd3 2814
c8d3a25c 28152012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2816
c8d3a25c
GM
2817 * charset.c (init_charset): Make lack of etc/charsets fatal.
2818
3e984ee8
DA
28192012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2820
2821 * editfns.c (region_limit): Fix type mismatch.
2822
ef884f23
DA
28232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2826 undefined. Convert from xassert to eassert.
2827 * nsmenu.m: Convert from xassert to eassert.
2828 * nsterm.m: Likewise.
2829
7d7e0027
SM
28302012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2831
2832 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2833
aa754e6a
PE
28342012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 Avoid integer overflow on scroll-left and scroll-right.
2837 * window.c (HSCROLL_MAX): New macro.
2838 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2839 overflow when requested scroll falls outside ptrdiff_t range.
2840
80b00b08
DA
28412012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2842
2843 * window.h (struct window): Change type of 'hscroll',
2844 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2845 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2846 Adjust users accordingly.
2847 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2848 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2849 from EMACS_INT to ptrdiff_t.
2850 (make_window): Omit redundant initialization.
2851
62b2bcf6
JB
28522012-06-28 Juanma Barranquero <lekktu@gmail.com>
2853
2854 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2855
45942c7d
DA
28562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2857
2858 * window.h (struct window): Change type of 'use_time' and
2859 'sequence_number' from Lisp_Object to int.
2860 * frame.c (make_frame): Adjust users accordingly.
2861 * print.c (print_object): Likewise.
2862 * window.c (select_window, Fwindow_use_time, make_parent_window)
2863 (make_window): Likewise.
2864
e509cfa6
DA
28652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2866
2867 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2868 enabled with --enable-checking=[all,glyphs] configure option.
2869 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2870 adjust comments accordingly.
2871 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2872 undefined, adjust comments accordingly.
2873 * image.c: Likewise.
2874 * scroll.c: Likewise.
2875 * w32fns.c: Likewise.
2876 * w32term.c: Likewise.
2877 * xdisp.c: Likewise.
2878 * xfaces.c: Likewise.
2879 * xfns.c: Likewise.
2880 * xterm.c: Likewise.
2881
a54e2c05
DA
28822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2883
2884 Generalize run-time debugging checks.
2885 * dispextern.h (XASSERTS): Remove.
2886 * fontset.c (xassert): Remove.
2887 Convert from xassert to eassert.
2888 * alloc.c: Convert from xassert to eassert.
2889 * bidi.c: Likewise.
2890 * dispnew.c: Likewise.
2891 * fns.c: Likewise.
2892 * fringe.c: Likewise.
2893 * ftfont.c: Likewise.
2894 * gtkutil.c: Likewise.
2895 * image.c: Likewise.
2896 * keyboard.c: Likewise.
2897 * menu.c: Likewise.
2898 * process.c: Likewise.
2899 * scroll.c: Likewise.
2900 * sound.c: Likewise.
2901 * term.c: Likewise.
2902 * w32console.c: Likewise.
2903 * w32fns.c: Likewise.
2904 * w32term.c: Likewise.
2905 * window.c: Likewise.
2906 * xdisp.c: Likewise.
2907 * xfaces.c: Likewise.
2908 * xfns.c: Likewise.
2909 * xselect.c: Likewise.
2910 * xterm.c: Likewise.
2911
1ec4b7b2
SM
29122012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * fns.c (maybe_resize_hash_table): Output message when growing the
2915 purify-hashtable.
2916
2014308a
DA
29172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2918
2919 * alloc.c (allocate_string_data): Remove dead code.
2920 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2921 avoid GCC warning about unused macro.
2922
246155eb
DA
29232012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2924
2925 * alloc.c (allocate_string): Omit intervals initialization.
2926 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2927 as in make_pure_string and make_pure_c_string.
2928
43184b7b
DA
29292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2930
d209e2fb 2931 * alloc.c (allocate_string): Fix last change.
43184b7b 2932
3fe6dd74
DA
29332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2934
d209e2fb 2935 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2936 to memset, add explicit initialization where appropriate.
2937
1ba6038a
GM
29382012-06-27 Glenn Morris <rgm@gnu.org>
2939
2940 * lisp.mk (lisp): Remove paths.elc.
2941
c89926a5
CY
29422012-06-27 Chong Yidong <cyd@gnu.org>
2943
2944 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2945
ed6b3510
JW
29462012-06-26 John Wiegley <johnw@newartisans.com>
2947
1ec4b7b2 2948 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2949 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2950
ed6b3510
JW
2951 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2952 when building with Clang.
2953
8edd4a2b
SM
29542012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2955
2956 * eval.c (Fapply): Allow calling it with a single argument.
2957
f6f62d1b
EZ
29582012-06-26 Eli Zaretskii <eliz@gnu.org>
2959
2960 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2961 _stricmp and _strnicmp.
2962 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2963
62efea5e
DA
29642012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2965
2966 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2967 allocated window.
2968 (allocate_process): Likewise for new process.
8edd4a2b 2969 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2970 (allocate_frame): Likewise.
2971 * frame.c (make_frame): Omit redundant initialization.
2972 * window.c (make_parent_window): Use memset.
2973 (make_window): Omit redundant initialization.
2974 * process.c (make_process): Omit redundant initialization.
2975 * terminal.c (create_terminal): Likewise.
2976
42997f4d
DA
29772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2978
2979 * term.c (delete_tty): Remove redundant call to memset.
2980
1130ecfc
DA
29812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2982
2983 * alloc.c: Remove build_string.
2984 * lisp.h: Define build_string as static inline. This provides
2985 a better opportunity to optimize away calls to strlen when the
2986 function is called with compile-time constant argument.
2987 * image.c (imagemagick_error): Convert to build_string.
2988 * w32proc.c (sys_spawnve): Likewise.
2989 * xterm.c (x_term_init): Likewise.
2990
cf38a720
PE
29912012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2992
99027bdd
PE
2993 Use sprintf return value instead of invoking strlen on result.
2994 In the old days this wasn't portable, since some sprintf
2995 implementations returned char *. But they died out years ago and
2996 Emacs already assumes sprintf returns int.
2997 Similarly for float_to_string.
2998 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2999 * ccl.c (ccl_driver):
3000 * character.c (string_escape_byte8):
3001 * data.c (Fnumber_to_string):
3002 * doprnt.c (doprnt):
3003 * print.c (print_object):
3004 * xdisp.c (message_dolog):
3005 * xfns.c (syms_of_xfns):
3006 Use sprintf or float_to_string result to avoid need to call strlen.
3007 * data.c (Fnumber_to_string):
3008 Use make_unibyte_string, since the string must be ASCII.
3009 * lisp.h, print.c (float_to_string): Now returns int length.
3010 * term.c (produce_glyphless_glyph):
3011 Use sprintf result rather than recomputing it.
3012
cf38a720
PE
3013 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3014 * Makefile.in (ALL_CFLAGS):
3015 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3016 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3017
3511c784
DA
30182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3019
0a08eb21 3020 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3021 strcasecmp if available.
3022 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3023
fb7da12e
AS
30242012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3025
3026 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3027 Avoid comma operator.
3028 * menu.c (push_submenu_start, push_submenu_end)
3029 (push_left_right_boundary, push_menu_pane): Likewise.
3030 * msdos.c (dos_rawgetc): Likewise.
3031
afa2ffd8
DA
30322012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3033
3034 * xfns.c (xic_create_fontsetname): Remove redundant calls
3035 to memset.
3036
b3b4476b
PE
30372012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3038
4495ff38
PE
3039 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3040 sprintf already null-terminates its output.
3041
b3b4476b
PE
3042 * xfns.c (x_window): Remove redundant cast.
3043
b00876c9
DA
30442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3045
3046 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3047 `const char *' to `char *' to avoid compiler warning.
3048
d188e26b
PE
30492012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3050
885d1d74
PE
3051 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3052 instead of truncating it to 63 (admittedly a generous limit).
3053
d188e26b
PE
3054 * process.c: Fix spelling and caps in comments.
3055
e2f560b1
DN
30562012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3057
e86db54b 3058 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3059 * sysdep.c (setpgrp): Remove definition, not used in this file.
3060
7583a3a1
JB
30612012-06-24 Juanma Barranquero <lekktu@gmail.com>
3062
3063 * makefile.w32-in: Update dependencies.
3064
696056c2
EZ
30652012-06-24 Eli Zaretskii <eliz@gnu.org>
3066
3067 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3068 (SYSTIME_H): Add nt/inc/sys/time.h.
3069
3070 * systime.h [WINDOWSNT]: Include sys/time.h.
3071
3072 * s/ms-w32.h (struct timespec): Definition moved from
3073 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3074
845ca893
PE
30752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3076
3077 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3078 * buffer.h (buffer_slot_type_mismatch):
3079 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3080 * eval.c (unwind_to_catch):
3081 * image.c (my_png_error, my_error_exit):
3082 * keyboard.c (quit_throw_to_read_char, user_error)
3083 (Fexit_recursive_edit, Fabort_recursive_edit):
3084 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3085 (wrong_type_argument, buffer_overflow, __executable_start)
3086 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3087 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3088 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3089 (fatal):
3090 (child_setup) [!DOS_NT]:
3091 * lread.c (end_of_file_error, invalid_syntax):
3092 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3093 * puresize.h (pure_write_error):
3094 * search.c (matcher_overflow):
3095 * sound.c (sound_perror, alsa_sound_perror):
3096 * sysdep.c, syssignal.h (croak):
3097 * term.c (maybe_fatal, vfatal):
3098 * textprop.c (text_read_only):
3099 * undo.c (user_error):
3100 * unexmacosx.c (unexec_error):
3101 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3102 Use _Noreturn rather than NO_RETURN.
3103 No need for separate decl merely because of _Noreturn.
3104 * sound.c (sound_warning, parse_sound):
3105 Remove unnecessary forward decls.
3106
f1dd8073
PE
31072012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3110 * lisp.h (WAIT_READING_MAX): New macro.
3111 * dispnew.c (Fsleep_for, sit_for):
3112 * keyboard.c (kbd_buffer_get_event):
3113 * process.c (Faccept_process_output):
3114 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3115 This improves on the previous patch, which introduced a bug
3116 when time_t is unsigned and as wide as intmax_t.
3117 See <http://bugs.gnu.org/9000#51>.
3118
b82c1755
EZ
31192012-06-23 Eli Zaretskii <eliz@gnu.org>
3120
3121 * dispnew.c (sit_for, Fsleep_for):
3122 * keyboard.c (kbd_buffer_get_event):
3123 * process.c (Faccept_process_output): Avoid compiler warnings when
3124 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3125
ca300656
JB
31262012-06-23 Juanma Barranquero <lekktu@gmail.com>
3127
049ec95b
JB
3128 * makefile.w32-in: Update dependencies.
3129
ca300656
JB
3130 * w32.c (ltime): Add return type and declare static.
3131 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3132
db7b8d06
PE
31332012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3134
3135 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3136 Privately reported by Herbert J. Skuhra.
3137 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3138 All uses changed.
3139 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3140 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3141
0bd8297f
EZ
31422012-06-23 Eli Zaretskii <eliz@gnu.org>
3143
96512555
EZ
3144 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3145 last argument of make_unibyte_string.
3146
0bd8297f
EZ
3147 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3148 language ID in the event parameters.
3149
3150 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3151 event.code, not the obscure "character set ID".
3152
63def6b6
CY
31532012-06-23 Chong Yidong <cyd@gnu.org>
3154
3155 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3156
e8a02204
EZ
31572012-06-23 Eli Zaretskii <eliz@gnu.org>
3158
388cdec0
EZ
3159 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3160 * w32.c (fdutimens): New function.
3161
3162 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3163
3164 * s/ms-w32.h (pselect): Redirect to sys_select.
3165
3166 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3167
e8a02204
EZ
3168 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3169 in the logic of incrementing and decrementing the value of
3170 use_relocatable_buffers.
3171
d054f3fb
PE
31722012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3173
3174 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3175 Privately reported by Herbert J. Skuhra.
3176 [__FreeBSD__]: Remove "*/" typo after "#include".
3177 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3178 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3179 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3180 Don't assume EMACS_TIME and struct timeval are the same type.
3181
d35af63c
PE
31822012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3183
3184 Support higher-resolution time stamps (Bug#9000).
3185 The time stamps are only nanosecond-resolution at the C level,
3186 since that's the best that any real-world system supports now.
3187 But they are picosecond-resolution at the Lisp level, as that's
3188 easy, and leaves room for future OS improvements.
3189
3190 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3191 (LIBES): Use it.
3192
3193 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3194 Don't get current time unless it's needed.
3195
3196 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3197 now provides it if it's absent.
3198 (start_atimer): Port to higher-res time stamps.
3199 Check for time stamp overflow. Don't get current time more
3200 often than is needed.
3201
3202 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3203 Include systime.h, not time.h.
3204 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3205
3206 * dired.c: Include stat-time.h.
3207 (Ffile-attributes): File times now have higher resolution.
3208
3209 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3210 (struct image): Timestamp now has higher resolution.
3211
3212 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3213 has at least microseconds now. All uses removed.
3214 (update_frame, update_single_window, update_window, update_frame_1)
3215 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3216
3217 * editfns.c (time_overflow): Now extern.
3218 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3219 (float-time, Fformat_time_string, Fcurrent_time_string)
3220 (Fcurrent_time_zone): Accept and generate higher-resolution
3221 time stamps.
3222 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3223 (decode_time_components, lisp_seconds_argument): New functions.
3224 (make_time): Now static.
3225 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3226 Report an error if the time is invalid, rather than having the caller
3227 do that.
3228
3229 * fileio.c: Include <stat-time.h>
3230 (Fcopy_file): Copy higher-resolution time stamps.
3231 Prefer to set the time stamp via a file descriptor if that works.
3232 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3233 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3234 (Fvisited_file_modtime, Fset_visited_file_modtime):
3235 Support higher-resolution time stamps.
3236
3237 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3238
3239 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3240
3241 * image.c (prepare_image_for_display, clear_image_cache)
3242 (lookup_image): Port to higer-resolution time stamps.
3243
3244 * keyboard.c (start_polling, bind_polling_period):
3245 Check for time stamp overflow.
3246 (read_char, kbd_buffer_get_event, timer_start_idle)
3247 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3248 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3249 Port to higher-resolution time stamps. Do not assume time_t is signed.
3250 (decode_timer): New function. Timers are now vectors of length 9,
3251 not 8, to accommodate the picosecond component.
3252 (timer_check_2): Use it.
3253
3254 * nsterm.m (select_timeout, timeval_subtract): Remove.
3255 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3256 as they're a bit more accurate and handle overflow better.
3257 (ns_select): Change prototype to be compatible with pselect.
3258 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3259 * nsterm.h (ns_select): Adjust prototype.
3260
3261 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3262 us-resolution time stamps.
3263 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3264
3265 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3266
3267 * lisp.h (time_overflow): New decl.
3268 (wait_reading_process_output): First arg is now intmax_t, not int,
3269 to accommodate larger waits.
3270
3271 * process.h (struct Lisp_Process.read_output_delay):
3272 Now counts nanoseconds, not microseconds.
3273 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3274 EMACS_HAS_USECS.
3275 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3276 (wait_reading_process_output):
3277 Port to ns-resolution time stamps.
3278 (Faccept_process_output, wait_reading_process_output):
3279 Check for time stamp overflow. Do not assume time_t is signed.
3280 (select_wrapper): Remove; we now use pselect.
3281 (Fprocess_attributes): Now generates ns-resolution time stamps.
3282
3283 * sysdep.c: Include utimens.h. Don't include utime.h
3284 or worry about struct utimbuf; gnulib does that for us now.
3285 (gettimeofday): Remove; gnulib provides a substitute.
3286 (make_timeval): New function.
3287 (set_file_times): Now sets ns-resolution time stamps.
3288 New arg FD; all uses changed.
3289 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3290 (system_process_attributes):
3291 Now returns ns-resolution time stamp. All uses changed.
3292 Check for time stamp overflow.
3293
3294 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3295 provides a substitute now.
3296
3297 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3298 since it guarantees struct timespec.
3299 (EMACS_TIME): Now struct timespec, so that we can support
3300 ns-resolution time stamps.
3301 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3302 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3303 (EMACS_USECS): Remove.
3304 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3305 so multiply the arg by 1000 before storing it.
3306 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3307 New macros.
3308 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3309 Port to ns-resolution time stamps.
3310 (EMACS_TIME_NEG_P): Remove; replaced by....
3311 (EMACS_TIME_SIGN): New macro.
3312 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3313 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3314 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3315 (make_timeval, make_lisp_time, decode_time_components): New decls.
3316 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3317 that it mishandled time_t overflow. You can't compare by subtracting!
3318 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3319 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3320
3321 * term.c: Include <sys/time.h>.
3322 (timeval_to_Time): New function, for proper overflow wraparound.
3323 (term_mouse_position, term_mouse_click): Use it.
3324
3325 * undo.c (record_first_change): Support higher-resolution time stamps
3326 in the undo buffer.
3327 (Fprimitive_undo): Use them when restoring time stamps.
3328
3329 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3330 (w32_get_internal_run_time):
3331 Port to higher-resolution Emacs time stamps.
3332 (ltime): Now accepts single 64-bit integer, as that's more convenient
3333 for callers.
3334
3335 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3336
3337 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3338 for compatibility with pselect. Support ns-resolution time stamps.
3339
3340 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3341
3342 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3343 Check for time stamp overflow, and support ns-resolution time stamps.
3344
3345 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3346 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3347 (timeval_subtract): Remove; no longer needed.
3348 (XTflash, XTring_bell, x_wait_for_event):
3349 Port to ns-resolution time stamps. Don't assume time_t is signed.
3350
b6a92dfe
CY
33512012-06-22 Chong Yidong <cyd@gnu.org>
3352
3353 * xdisp.c (x_consider_frame_title): Revert last change.
3354
d251c37c
EZ
33552012-06-22 Eli Zaretskii <eliz@gnu.org>
3356
3357 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3358 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3359 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3360 staticidx goes up to 1597 out of 1600 = 0x640.)
3361
f10deafb
PE
33622012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3365 Otherwise, the umask might be mistakenly 0 while handling input signals.
3366
ec6de1e2
SM
33672012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3368
3369 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3370
28be1ada
DA
33712012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3372
3373 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3374 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3375 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3376 access to `contents' member of Lisp_Vector objects with AREF and ASET
3377 where appropriate.
3378
c6bf3022
CY
33792012-06-19 Chong Yidong <cyd@gnu.org>
3380
3381 * frame.c (delete_frame): When selecting a frame on a different
3382 text terminal, do not alter the terminal's top-frame.
3383
3384 * xdisp.c (format_mode_line_unwind_data): Record the target
3385 frame's selected window and its terminal's top-frame.
3386 (unwind_format_mode_line): Restore them.
3387 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3388 Callers changed.
3389 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3390 since tty frames can be explicitly named.
3391 (prepare_menu_bars): Likewise.
3392
3393 * term.c (Ftty_top_frame): New function.
3394
defd4196
PE
33952012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 Port byte-code-meter to modern targets.
3398 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3399 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3400 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3401 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3402 (METER_1, METER_2): Simplify.
3403
1053a871
SM
34042012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3405
3406 * data.c (Fdefalias): Return `symbol' (bug#11686).
3407
b7e8d081
MR
34082012-06-18 Martin Rudalics <rudalics@gmx.at>
3409
3410 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3411 gets killed during executing of this function (Bug#11665).
3412 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3413 (Vkill_buffer_query_functions): In doc-string say that functions
3414 run by this hook should not change the current buffer.
3415
7ea2b339
PE
34162012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 Fix recently-introduced process.c problems found by static checking.
3419 * process.c (write_queue_push, write_queue_pop, send_process):
3420 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3421 (write_queue_pop): Fix pointer signedness problem.
3422 (send_process): Remove unused local.
3423
96a313a1
CY
34242012-06-17 Chong Yidong <cyd@gnu.org>
3425
3426 * xdisp.c (redisplay_internal): No need to redisplay terminal
3427 frames that are not on top.
3428
20ca2e94
TN
34292012-06-17 Troels Nielsen <bn.troels@gmail.com>
3430
3431 * process.c (make_process): Initialize write_queue.
3432 (write_queue_push, write_queue_pop): New functions.
3433 (send_process): Use them to maintain correct ordering of process
3434 writes (Bug#10815).
3435
9a900ca9
PE
34362012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3437
310fbfa8
PE
3438 * lisp.h (eassert): Assume C89 or later.
3439 This removes the need for CHECK.
3440 (CHECK): Remove. Its comments about always evaluating its
3441 argument were confusing, as 'eassert' typically does not evaluate
3442 its argument.
3443
27bb1ca4
PE
3444 * coding.c (produce_chars): Use ptrdiff_t, not int.
3445
9a900ca9
PE
3446 * xterm.c (x_draw_underwave): Check for integer overflow.
3447 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3448
41b7f8bc 34492012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3450
3451 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3452 referenced (Bug#11583).
3453
9b0e3eba
AA
34542012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3455
3456 Implement wave-style variant of underlining.
3457 * dispextern.h (face_underline_type): New enum.
3458 (face): Add field for underline type.
3459 * nsterm.m (ns_draw_underwave): New function.
3460 (ns_draw_text_decoration): Use it.
3461 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3462 New functions.
3463 (x_draw_glyph_string): Use them.
3464 * xfaces.c (Qline, Qwave): New Lisp objects.
3465 (check_lface_attrs, merge_face_ref)
1053a871
SM
3466 (Finternal_set_lisp_face_attribute, realize_x_face):
3467 Handle wave-style underline face attributes.
9b0e3eba
AA
3468 * xterm.c (x_draw_underwave): New function.
3469 (x_draw_glyph_string): Use it.
3470
0fb52f11
JB
34712012-06-16 Juanma Barranquero <lekktu@gmail.com>
3472
3473 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3474 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3475 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3476 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3477 ($(BLD)/w32select.$(O)): Update dependencies.
3478
e5560ff7
AS
34792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3480
3481 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3482 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3483 * character.c (_fetch_multibyte_char_p): Remove.
3484 * alloc.c: Include "character.h" before "buffer.h".
3485 * bidi.c: Likewise.
3486 * buffer.c: Likewise.
3487 * bytecode.c: Likewise.
3488 * callint.c: Likewise.
3489 * callproc.c: Likewise.
3490 * casefiddle.c: Likewise.
3491 * casetab.c: Likewise.
3492 * category.c: Likewise.
3493 * cmds.c: Likewise.
3494 * coding.c: Likewise.
3495 * composite.c: Likewise.
3496 * dired.c: Likewise.
3497 * dispnew.c: Likewise.
3498 * doc.c: Likewise.
3499 * dosfns.c: Likewise.
3500 * editfns.c: Likewise.
3501 * emacs.c: Likewise.
3502 * fileio.c: Likewise.
3503 * filelock.c: Likewise.
3504 * font.c: Likewise.
3505 * fontset.c: Likewise.
3506 * fringe.c: Likewise.
3507 * indent.c: Likewise.
3508 * insdel.c: Likewise.
3509 * intervals.c: Likewise.
3510 * keyboard.c: Likewise.
3511 * keymap.c: Likewise.
3512 * lread.c: Likewise.
3513 * macros.c: Likewise.
3514 * marker.c: Likewise.
3515 * minibuf.c: Likewise.
3516 * nsfns.m: Likewise.
3517 * nsmenu.m: Likewise.
3518 * print.c: Likewise.
3519 * process.c: Likewise.
3520 * regex.c: Likewise.
3521 * region-cache.c: Likewise.
3522 * search.c: Likewise.
3523 * syntax.c: Likewise.
3524 * term.c: Likewise.
3525 * textprop.c: Likewise.
3526 * undo.c: Likewise.
3527 * unexsol.c: Likewise.
3528 * w16select.c: Likewise.
3529 * w32fns.c: Likewise.
3530 * w32menu.c: Likewise.
3531 * window.c: Likewise.
3532 * xdisp.c: Likewise.
3533 * xfns.c: Likewise.
3534 * xmenu.c: Likewise.
3535 * xml.c: Likewise.
3536 * xselect.c: Likewise.
3537
2f07e6af
EZ
35382012-06-16 Eli Zaretskii <eliz@gnu.org>
3539
1053a871
SM
3540 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3541 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3542 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3543 row.
3544 (handle_face_prop): Use chunk-relative overlay string index when
3545 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3546 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3547 the rightmost. (Bug#11720)
2f07e6af 3548
29b83cec
AS
35492012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3550
3551 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3552 (CATEGORY_MEMBER): Enforce 1/0 value.
3553 * category.c (_temp_category_set): Remove.
3554
4c5501e9
EZ
35552012-06-16 Eli Zaretskii <eliz@gnu.org>
3556
3557 * window.c (Fdelete_other_windows_internal)
3558 (Fdelete_window_internal): Don't access frame's mouse highlight
3559 info of the initial frame. (Bug#11677)
3560
2b570124
PE
35612012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3562
e93864f9
PE
3563 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3564 Assume USE_2_TAGS_FOR_INTS.
3565 (xreload): Adjust $tagmask width to match recent lisp.h change.
3566
2b570124
PE
3567 Simplify lisp.h in minor ways that should not affect code.
3568 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3569 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3570 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3571 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3572 (INTTYPEBITS): New macro, for clarity.
3573 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3574 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3575 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3576 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3577 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3578
81755f69
JB
35792012-06-13 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3582
16192a57
GM
35832012-06-13 Glenn Morris <rgm@gnu.org>
3584
3585 * s/bsd-common.h (BSD4_3):
3586 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3587
646b5f55
AS
35882012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3591 instead of union.
3592 (XLI, XIL): Define.
1053a871
SM
3593 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3594 Use them.
3595 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3596 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3597 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3598 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3599 * frame.c (delete_frame): Remove outdated comment.
3600 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3601 USE_LISP_UNION_TYPE.
3602 (Fw32_unregister_hot_key): Likewise.
3603 (Fw32_toggle_lock_key): Likewise.
3604 * w32menu.c (add_menu_item): Likewise.
3605 (w32_menu_display_help): Use XIL instead of checking
3606 USE_LISP_UNION_TYPE.
3607 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3608 (init_heap): Likewise.
3609 * w32term.c (w32_read_socket): Update comment.
3610
1d3823c9
GM
36112012-06-13 Glenn Morris <rgm@gnu.org>
3612
c62ff706
GM
3613 * s/usg5-4-common.h, src/s/unixware.h:
3614 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3615
1d3823c9
GM
3616 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3617
bfe3e0a2
PE
36182012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3621 * alloc.c (make_number) [!defined make_number]:
3622 Remove, as lisp.h always defines this now.
3623 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3624 (roundup_size): Verify that it is a power of 2.
3625 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3626 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3627 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3628 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3629 USE_LSB_TAG now is always defined to be either 0 or 1.
3630 All uses changed.
3631 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3632 code works fine either way, and efficiency is not a concern here,
3633 as the union type is for debugging, not for production.
3634 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3635 Use an inline function on all platforms when using the union type,
3636 since this is simpler and 'static inline' can be used portably
3637 within Emacs now.
3638 (LISP_INITIALLY_ZERO): New macro.
3639 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3640 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3641
45fa9c0f
GM
36422012-06-12 Glenn Morris <rgm@gnu.org>
3643
b4492cba
GM
3644 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3645
3646 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3647
45fa9c0f
GM
3648 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3649 Move BROKEN_SIGIO to configure.
3650
3651 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3652 Move NO_TERMIO to configure.
3653
0e25d334
CY
36542012-06-12 Chong Yidong <cyd@gnu.org>
3655
3656 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3657 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3658 MagickExportImagePixels is undefined.
3659
43682bb6
PE
36602012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3661
3662 * image.c (imagemagick_load_image): Remove unused label.
3663
a9be7d2b
GM
36642012-06-11 Glenn Morris <rgm@gnu.org>
3665
3666 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3667 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3668 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3669 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3670
3017f87f
SM
36712012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3672
3673 * alloc.c (make_byte_code): New function.
3674 (Fmake_byte_code): Use it. Don't purify here.
3675 * lread.c (read1): Use it as well to avoid extra allocation.
3676
1b9b4cf4
CY
36772012-06-11 Chong Yidong <cyd@gnu.org>
3678
3679 * image.c (imagemagick_load_image): Implement transparency.
3680
95988fcf
AS
36812012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3682
3683 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3684 account for preceding backslashes. (Bug#11663)
3685
cd4eb164
CY
36862012-06-09 Chong Yidong <cyd@gnu.org>
3687
3688 * term.c: Support italics in capable terminals (Bug#9652).
3689 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3690 (turn_on_face): Output using TS_enter_italic_mode if available.
3691 Don't handle unused blinking and alt-charset cases.
3692 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3693 and tty_alt_charset_p cases.
3694 (tty_capable_p, init_tty): Support italics.
3695
3696 * termchar.h (struct tty_display_info): Add field for italics.
3697 Remove unused blink field.
3698
3699 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3700 Handle slant.
3701
3702 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3703 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3704 tty_alt_charset_p. Add tty_italic_p.
3705
ff88beb8
MA
37062012-06-09 Michael Albinus <michael.albinus@gmx.de>
3707
3708 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3709 dbus_type_is_basic if available.
3710 (xd_extract_signed, xd_extract_unsigned): Rename from
3711 extract_signed and extract_unsigned, respectively. Adapt callers.
3712
44286096
CY
37132012-06-09 Chong Yidong <cyd@gnu.org>
3714
1682701f
CY
3715 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3716
44286096
CY
3717 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3718 case (Bug#9752).
3719
d86feb17
PE
37202012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3721
3722 * xdisp.c (vmessage): Treat frame message as multibyte.
3723 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3724 would generate the diagnostic "Making \302\247 buffer-local while
3725 let-bound!".
3726
d5c20fe8
EZ
37272012-06-08 Eli Zaretskii <eliz@gnu.org>
3728
3729 * dispnew.c (showing_window_margins_p): Undo last change, which
3730 was done due to an inadvertent commit.
3731 (adjust_frame_glyphs_for_frame_redisplay): Do call
3732 showing_window_margins_p.
3733
513749ee
SM
37342012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3735
3736 * eval.c (Fmake_var_non_special): New primitive.
3737 (syms_of_eval): Defsubr it.
3738 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3739
d4a8f5c1
JB
37402012-06-08 Juanma Barranquero <lekktu@gmail.com>
3741
3742 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3743 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3744
8bbbc977
EZ
37452012-06-08 Eli Zaretskii <eliz@gnu.org>
3746
3747 * alloc.c (allocate_vectorlike): Fix last change.
3748
f3372c87
DA
37492012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3750
3751 Block-based vector allocation of small vectors.
3752 * lisp.h (struct vectorlike_header): New field `nbytes',
3753 adjust comment accordingly.
3754 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3755 to denote vector blocks. Adjust users (live_vector_p,
3756 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3757 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3758 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3759 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3760 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3761 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3762 (roundup_size): New constant.
3763 (struct vector_block): New data type.
3764 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3765 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3766 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3767 (sweep_vectors): New functions.
3768 (allocate_vectorlike): Return `zero_vector' as the only vector of
3769 0 items. Allocate new vector from block if vector size is less than
3770 or equal to VBLOCK_BYTES_MAX.
3771 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3772 (init_alloc_once): Add call to init_vectors.
3773
4f18a4ed
SM
37742012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3775
3776 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3777
86f158bc
PE
37782012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3779
3780 * doprnt.c (doprnt): Truncate multibyte char correctly.
3781 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3782 would mishandle a string argument "Xc" if X was a multibyte
3783 character of length 2: it would truncate after X's first byte
3784 rather than including all of X.
3785
c5cfcbe0
CY
37862012-06-06 Chong Yidong <cyd@gnu.org>
3787
3788 * buffer.c (word_wrap): Doc fix.
3789
c05cf390
PE
37902012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3791
3792 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3793
0c3461de
GM
37942012-06-03 Glenn Morris <rgm@gnu.org>
3795
3796 * xdisp.c (tool-bar-style): Doc fix.
3797
c71232db
UM
37982012-06-03 Ulrich Müller <ulm@gentoo.org>
3799
3800 * Makefile.in (PAXCTL): Define.
3801 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3802 binary via PaX flags if the paxctl utility is available.
3803 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3804 Restore PaX flags to their default. (Bug#11398)
3805
383f7350
CY
38062012-06-03 Chong Yidong <cyd@gnu.org>
3807
3808 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3809 buffer (Bug#11226).
3810
5f2c76c6
CY
38112012-06-03 Chong Yidong <cyd@gnu.org>
3812
3813 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3814 (note_mode_line_or_margin_highlight): If there is no help echo,
3815 use mode-line-default-help-echo. Handle the case where the mouse
3816 position is past the end of the mode line string.
3817
3818 * buffer.c (buffer_local_value_1): New function, split from
3819 Fbuffer_local_value; can return Qunbound.
3820 (Fbuffer_local_value): Use it.
3821 (Vmode_line_format): Docstring tweaks.
3822
773d47f6
PE
38232012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 * sysdep.c (system_process_attributes): Improve comment.
3826
f2d6a3df
SM
38272012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3828
3829 * keyboard.c: Export real-this-command to Elisp.
3830 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3831 and DEFVAR it. Update all users.
3832
63810350
PE
38332012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3834
7bd5c1f4
PE
3835 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3836
63810350
PE
3837 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3838 Convert pctcpu and pctmem to Lisp float properly.
3839 Let the compiler fold better, as 100.0/0x8000 is exact.
3840
a2821611
AS
38412012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3842
3843 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3844 cons_block.
3845
5fceba1d
PE
38462012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3849
c98ff5dd
DA
38502012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3851
3852 For a 'struct window', replace some Lisp_Object fields to
3853 bitfields where appropriate, remove unused fields.
3854 * window.h (struct window): Remove unused 'last_mark_x' and
3855 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3856 change it's type from Lisp_Object to bitfield.
3857 Change type of 'force_start', 'optional_new_start',
3858 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3859 fields from Lisp_Object to bitfield. Adjust users accordingly.
3860
ca34e0be
PE
38612012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 Pacify gcc -Wdouble-precision when using Xaw.
3864 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3865 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3866 Use 'float' consistently, rather than 'float' in most places
3867 and 'double' in a couple of places.
3868
efc00ab1 38692012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3870
3871 * xdisp.c (handle_stop): Detect whether we have overlay strings
3872 loaded by testing it->current.overlay_string_index to be
3873 non-negative, instead of checking whether n_overlay_strings is
3874 positive. (Bug#11587)
3875
efc00ab1 38762012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3877
3878 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3879
3880 * doc.c (Fsubstitute_command_keys): Doc fix.
3881
efc00ab1 38822012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3883
3884 * search.c (search_buffer): Remove calls to
3885 r_alloc_inhibit_buffer_relocation, as it is now called by
3886 maybe_unify_char, which was the cause of relocation of buffer text
3887 in bug#11519.
3888
efc00ab1 38892012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3890
3891 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3892 for the duration of call to load_charset, to avoid problems with
3893 callers of maybe_unify_char that access buffer text through C
3894 pointers.
3895
3896 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3897 decrement the inhibition flag, instead of just setting or
3898 resetting it.
3899
ba93a187
PE
39002012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3901
3902 Remove obsolete '#define static' cruft.
3903 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3904 This #undef was "temporary" in 2000; it is no longer needed
3905 now that '#define static' has gone away.
3906 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3907 (gray_bitmap_bits): Remove; no longer needed.
3908 All uses replaced with definiens.
3909 * xterm.c: Include "bitmaps/gray.xbm".
3910
9e4bf381
PE
39112012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 Clean up __executable_start, monstartup when --enable-profiling.
3914 The following changes affect the code only when profiling.
3915 * dispnew.c (__executable_start): Rename from safe_bcopy.
3916 Define only on platforms that need it.
3917 * emacs.c: Include <sys/gmon.h> when profiling.
3918 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3919 (__executable_start): Remove decl, since lisp.h does it now.
3920 (safe_bcopy): Remove decl; no longer has that name.
3921 (main): Coalesce #if into single bit of code, for simplicity.
3922 Cast pointers to uintptr_t, since standard libraries want integers
3923 and not pointers.
3924 * lisp.h (__executable_start): New decl.
3925
32d72c2f
GM
39262012-05-31 Glenn Morris <rgm@gnu.org>
3927
3928 * image.c (Fimagemagick_types): Doc fix.
3929
baac5bc7
JM
39302012-05-30 Jim Meyering <meyering@redhat.com>
3931
3932 * callproc.c (Fcall_process_region): Include directory component
3933 in mkstemp error message (Bug#11586).
3934
72cb32cf
PE
39352012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * alloc.c, lisp.h (make_pure_vector): Now static.
3938
61b108cc
SM
39392012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3940
3941 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3942 Move to byte-run.el.
3943 (Fautoload): Do the hash-doc more carefully.
3944 * data.c (Fdefalias): Purify definition, except for keymaps.
3945 (Qdefun): Move from eval.c.
3946 * lisp.h (Qdefun): Remove.
3947 * lread.c (read1): Tiny simplification.
3948
471fe23d
TN
39492012-05-29 Troels Nielsen <bn.troels@gmail.com>
3950
934f3f58 3951 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3952 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3953 Bug#9642, but explicitly check that the buffer the overlay would
3954 be moved to is live and rearrange lines to make sure that errors
3955 will not put the overlay in an inconsistent state.
3956 (Fdelete_overlay): Cosmetics.
3957
85d0efd1
EZ
39582012-05-28 Eli Zaretskii <eliz@gnu.org>
3959
3960 * w32term.c (my_bring_window_to_top): New function.
3961 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3962 could be different from the original one.
3963 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3964 (Bug#11513)
3965
3966 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3967 by calling BringWindowToTop.
3968
3969 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3970 (WM_EMACS_END): Increase by one.
3971
da92a98c
PE
39722012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3975 This avoids undefined behavior that might cause the eassert
3976 to not catch an out-of-range value.
3977
74d1f848
JB
39782012-05-28 Juanma Barranquero <lekktu@gmail.com>
3979
3980 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3981 Update dependencies.
3982
9e1a06fc
EZ
39832012-05-27 Eli Zaretskii <eliz@gnu.org>
3984
3985 * bidi.c (bidi_mirror_char): Fix last change.
3986
f3dd7312
AS
39872012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3988
3989 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3990 when referring to sectname field in printf format.
3991
81899c91
PE
39922012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3993
57b81a9f
PE
3994 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3995 Only r_alloc_inhibit_buffer_relocation needed to be added;
3996 the others were already declared.
3997
81899c91
PE
3998 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3999 before checking whether it's out of range. Put the check inside
4000 eassert. See
4001 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4002
33017faf 40032012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4004
4005 * callproc.c (Fcall_process): Restore a line that was accidentally
4006 commented out in the 2011-02-13 change (bug#11547).
4007
33017faf 40082012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4009
4010 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4011 defined on ralloc.c.
4012
4013 * buffer.c [REL_ALLOC]: Remove prototypes of
4014 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4015 they are now on lisp.h.
4016
4017 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4018
4019 * search.c (search_buffer): Use it to inhibit relocation of buffer
4020 text while re_search_2 is doing its job, because re_search_2 is
4021 passed C pointers to buffer text. (Bug#11519)
4022
23415acf
EZ
4023 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4024 Update value to 24.
4025
44e27368
EZ
4026 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4027 state after an additional call to move_it_in_display_line_to, keep
4028 the values of it->max_ascent and it->max_descent found for the
4029 entire line.
4030 (pos_visible_p): Revert the comparison against bottom_y to what it
4031 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4032 (Bug#11464)
4033
c1892f11
PE
40342012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4035
4036 Fix coding-related core dumps with gcc -ftrapv.
4037 The code was computing A - B, where A and B are pointers, and B is
4038 random garbage. This can lead to core dumps on platforms that
4039 have special pointer registers, and it also leads to core dumps on
4040 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4041 A - B only when B is initialized properly.
4042 * coding.c (coding_set_source, coding_set_destination): Return void.
4043 (coding_change_source, coding_change_destinations): New functions,
4044 with the old behaviors of coding_set_source and coding_set_destination.
4045 All callers that need an offset changed to use these new functions.
4046
eb7afdad
GM
40472012-05-26 Glenn Morris <rgm@gnu.org>
4048
4049 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4050
f12fdf02
EZ
40512012-05-26 Eli Zaretskii <eliz@gnu.org>
4052
53a63be6 4053 Extend mouse support on W32 text-mode console.
61b108cc
SM
4054 * xdisp.c (draw_row_with_mouse_face):
4055 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4056
eb3f6f01 4057 * w32console.c: Include window.h.
61b108cc
SM
4058 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4059 New functions.
eb3f6f01
EZ
4060 (initialize_w32_display): Initialize mouse-highlight data.
4061
53a63be6
EZ
4062 * w32inevt.c: Include termchar.h and window.h.
4063 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4064 moves, call note_mouse_highlight. If help_echo changed, call
4065 gen_help_event to produce help-echo message in the echo area.
4066 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4067 highlight info.
4068
4cfd81f6
PE
40692012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4070
4071 * lread.c (read1): Simplify slightly to avoid an overflow warning
4072 with GCC 4.7.0 on x86-64.
4073
4446092a
EZ
40742012-05-26 Eli Zaretskii <eliz@gnu.org>
4075
4076 * bidi.c (bidi_mirror_char): Revert last change: an int is
4077 definitely wide enough here.
4078
42b2a986 40792012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4080
42b2a986 4081 Fix integer width and related bugs (Bug#9874).
eb106a49 4082 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4083 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4084 (string_bytes, check_sblock, allocate_string_data):
4085 (compact_small_strings, Fmake_bool_vector, make_string)
4086 (make_unibyte_string, make_multibyte_string)
4087 (make_string_from_bytes, make_specified_string)
4088 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4089 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4090 (mark_vectorlike):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4092 (allocate_pseudovector):
4093 Use int, not EMACS_INT, where int is wide enough.
4094 (inhibit_garbage_collection, Fgarbage_collect):
4095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4096 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4097 int might not be wide enough.
4098 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4099 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4100 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4101 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4102 (bidi_level_of_next_char, bidi_move_to_visually_next):
4103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4104 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4105 (Fkill_buffer, Fset_buffer_major_mode)
4106 (advance_to_char_boundary, Fbuffer_swap_text)
4107 (Fset_buffer_multibyte, overlays_at, overlays_in)
4108 (overlay_touches_p, struct sortvec, record_overlay_string)
4109 (overlay_strings, recenter_overlay_lists)
4110 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4111 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4112 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4113 (Foverlay_recenter, last_overlay_modification_hooks_used)
4114 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4116 (validate_region): Omit unnecessary test for b <= e,
4117 since that's guaranteed by the previous test.
d311d28c
PE
4118 (adjust_overlays_for_delete): Avoid pos + length overflow.
4119 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4120 (report_overlay_modification):
4121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4122 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4123 Omit pointer cast, which isn't needed anyway, and doesn't work
4124 after the EMACS_INT -> ptrdiff_t change.
02481186 4125 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4126 * buffer.h: Adjust decls to match defn changes elsewhere.
4127 (struct buffer_text, struct buffer):
4128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4129 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4130 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4131 not int, to avoid needless 32-bit limit on 64-bit hosts.
4132 (exec_byte_code): Use tighter memory-full test, one that checks
4133 for alloca overflow. Don't compute the address of the object just
4134 before an array, as that's not portable. Use EMACS_INT, not
4135 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4136 * callint.c (Fcall_interactively):
4137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4138 * callproc.c (call_process_kill, Fcall_process):
4139 Don't assume pid_t fits into an Emacs fixnum.
4140 (call_process_cleanup, Fcall_process, child_setup):
4141 Don't assume pid_t fits into int.
4142 (call_process_cleanup, Fcall_process, delete_temp_file)
4143 (Fcall_process_region):
4144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4145 (Fcall_process): Simplify handling of volatile integers.
4146 Use int, not EMACS_INT, where int will do.
4147 * casefiddle.c (casify_object, casify_region, operate_on_word)
4148 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4150 (casify_object): Avoid integer overflow when overallocating buffer.
4151 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4152 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4153 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4154 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4155 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4156 integers are now checked earlier. All uses replaced with XINT.
4157 (ccl_driver):
4158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4159 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4160 (ccl_driver, Fregister_code_conversion_map):
4161 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4162 (resolve_symbol_ccl_program): Check that vector header is in range.
4163 Always copy the vector, so that we can check its contents reliably
4164 now rather than having to recheck each instruction as it's being
4165 executed. Check that vector words fit in 'int'.
4166 (ccl_get_compiled_code, Fregister_ccl_program)
4167 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4168 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4169 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4170 contents are in range.
4171 (Fccl_execute_on_string): Check that status is in range.
4172 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4173 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4174 Accept and return EMACS_INT, not int, because callers can pass values
4175 out of 'int' range.
4176 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4177 (multibyte_chars_in_text, parse_str_as_multibyte)
4178 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4179 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4180 (string_escape_byte8, Fget_byte):
4181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4182 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4183 avoid mishandling large integers.
4184 * character.h: Adjust decls to match defn changes elsewhere.
4185 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4186 (Ffind_charset_region):
4187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4188 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4189 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4190 Don't assume fixnum fits in int.
d311d28c
PE
4191 (load_charset_map_from_vector, Fmap_charset_chars):
4192 Remove now-unnecessary CHECK_NATNUMs.
4193 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4194 Don't rely on undefined behavior with signed left shift overflow.
4195 Don't assume unsigned int fits into fixnum, or that fixnum fits
4196 into unsigned int. Don't require max_code to be a valid fixnum;
4197 that's not true for gb10830 4-byte on a 32-bit host. Allow
4198 invalid_code to be a cons, for the same reason. Require code_offset
4199 to be a character. Avoid int overflow if max_char is close
4200 to INT_MAX.
4201 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4202 this is intended anyway and avoids some undefined behavior.
4203 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4204 INDEX_TO_CODE_POINT, as that's what it expects.
4205 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4206 * charset.h (DECODE_CHAR): Return int, not unsigned;
4207 this is what was intended anyway, and it avoids undefined behavior.
4208 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4209 integer-overflow issues.
4210 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4211 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4212 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4213 * chartab.c (Fmake_char_table, Fset_char_table_range)
4214 (uniprop_get_decoder, uniprop_get_encoder):
4215 Don't assume fixnum fits in int.
4216 * cmds.c (move_point): New function, that does the gist of
4217 Fforward_char and Fbackward_char, but does so while checking
4218 for integer overflow more accurately.
c96e5d6a 4219 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4220 (Fforward_line, Fend_of_line, internal_self_insert)
4221 (internal_self_insert):
4222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4223 Fix a FIXME, by checking for integer overflow when calculating
4224 target_clm and actual_clm.
4225 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4226 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4227 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4228 (coding_alloc_by_making_gap, alloc_destination)
4229 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4230 (encode_coding_utf_16, detect_coding_emacs_mule)
4231 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4232 (detect_coding_iso_2022, decode_coding_iso_2022)
4233 (encode_invocation_designation, encode_designation_at_bol)
4234 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4235 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4236 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4237 (encode_coding_ccl, encode_coding_raw_text)
4238 (detect_coding_charset, decode_coding_charset)
4239 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4240 (produce_composition, produce_charset, produce_annotation)
4241 (decode_coding, handle_composition_annotation)
4242 (handle_charset_annotation, consume_chars, decode_coding_gap)
4243 (decode_coding_object, encode_coding_object, detect_coding_system)
4244 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4245 (code_convert_region, code_convert_string)
8f50130c
PE
4246 (Fdefine_coding_system_internal)
4247 (coding_set_source, coding_set_destination):
d311d28c
PE
4248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4249 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4250 (Fdefine_coding_system_internal):
4251 Don't assume fixnums fit in int.
4252 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4253 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4254 (Funencodable_char_position, Fcheck_coding_systems_region)
4255 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4257 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4258 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4259 Don't access memory outside of the args array.
d311d28c 4260 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4261 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4262 result of ENCODE_CHAR.
d311d28c
PE
4263 * coding.h: Adjust decls to match defn changes elsewhere.
4264 (struct coding_system):
4265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4266 * composite.c (get_composition_id, find_composition)
4267 (run_composition_function, update_compositions)
4268 (compose_text, composition_gstring_put_cache)
4269 (composition_gstring_p, composition_gstring_width)
4270 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4271 (composition_compute_stop_pos, composition_reseat_it)
4272 (composition_update_it, struct position_record)
4273 (find_automatic_composition, composition_adjust_point)
4274 (Fcomposition_get_gstring, Ffind_composition_internal):
4275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4276 (update_compositions):
4277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4278 * composite.h: Adjust decls to match defn changes elsewhere.
4279 (struct composition):
4280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4281 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4282 Do not attempt to compute the address of the object just before a
4283 buffer; this is not portable.
4284 (Faref, Faset):
4285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4286 (Faset): Use int, not EMACS_INT, where int is wide enough.
4287 (Fstring_to_number): Don't assume fixnums fit in int.
4288 (Frem): Don't assume arg is nonnegative.
4289 * dbusbind.c (xd_append_arg): Check for integers out of range.
4290 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4291 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4292 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4293 (xd_get_connection_references): Return ptrdiff_t, not int.
4294 All uses changed.
4295 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4296 (xd_read_message_1):
4297 Use int, not unsigned, where the dbus API uses int.
4298 (Fdbus_message_internal): Don't overflow mtype.
4299 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4300 * dired.c (directory_files_internal, file_name_completion, scmp)
4301 (file_name_completion_stat):
4302 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4303 (file_name_completion): Don't overflow matchcount.
4304 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4305 * dispextern.h: Adjust decls to match defn changes elsewhere.
4306 (struct text_pos, struct glyph, struct bidi_saved_info)
4307 (struct bidi_string_data, struct bidi_it, struct composition_it)
4308 (struct it):
4309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4310 (struct display_pos, struct composition_it, struct it):
4311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4312 * dispnew.c (increment_matrix_positions)
4313 (increment_row_positions, mode_line_string)
4314 (marginal_area_string):
4315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4316 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4318 (duration_to_sec_usec): New function, to check for overflow better.
4319 (Fsleep_for, sit_for): Use it.
4320 * doc.c (get_doc_string, store_function_docstring):
4321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4322 (get_doc_string, Fsnarf_documentation):
4323 Use int, not EMACS_INT, where int is wide enough.
4324 (get_doc_string):
4325 Use SAFE_ALLOCA, not alloca.
4326 Check for overflow when converting EMACS_INT to off_t.
4327 * doprnt.c (doprnt):
4328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4329 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4330 Don't assume uid_t fits into fixnum.
4331 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4332 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4333 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4334 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4335 (general_insert_function)
4336 (Finsert_char, make_buffer_string, make_buffer_string_both)
4337 (update_buffer_properties, Fbuffer_substring)
4338 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4339 (Fsubst_char_in_region, check_translation)
4340 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4341 (transpose_markers, Ftranspose_regions):
4342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4343 (clip_to_bounds): Move to lisp.h as an inline function).
4344 (Fconstrain_to_field): Don't assume integers are nonnegative.
4345 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4346 (Fsubst_char_in_region, Fsave_restriction):
4347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4348 (Femacs_pid): Don't assume pid_t fits into fixnum.
4349 (lo_time): Use int, not EMACS_INT, when int suffices.
4350 (lisp_time_argument): Check for usec out of range.
4351 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4352 (Fuser_login_name, Fuser_full_name): Signal an error
4353 if a uid argument is out of range, rather than relying on
4354 undefined behavior.
c8d5c857
PE
4355 (Fformat_time_string): Remove now-unnecessary check.
4356 lisp_time_argument checks for out-of-range usec now.
243e0530 4357 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4358 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4359 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4360 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4361 (init_cmdargs, Fdump_emacs):
4362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4363 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4364 the bottom (typically) 32 bits of the fixnum.
4365 * eval.c (specpdl_size, call_debugger):
4366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4367 (when_entered_debugger, Fbacktrace_debug):
4368 Don't assume fixnum can fit in int.
4369 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4370 the object just before a buffer; this is not portable.
4371 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4372 (grow_specpdl, unbind_to):
4373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4374 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4375 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4376 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4377 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4378 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4379 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4380 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4381 (a_write, e_write):
4382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4383 (Fcopy_file, non_regular_nbytes, read_non_regular)
4384 (Finsert_file_contents):
4385 Use int, not EMACS_INT, where int is wide enough.
4386 (READ_BUF_SIZE): Verify that it fits in int.
4387 (Finsert_file_contents): Check that counts are in proper range,
4388 rather than assuming fixnums fit into ptrdiff_t etc.
4389 Don't assume fixnums fit into int.
125b3835 4390 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4391 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4392 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4393 (string_char_to_byte, string_byte_to_char)
4394 (string_make_multibyte, string_to_multibyte)
4395 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4396 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4397 (substring_both, Fdelete, internal_equal, Ffillarray)
4398 (Fclear_string, mapcar1)
4399 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4400 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4401 (larger_vector, make_hash_table, maybe_resize_hash_table)
4402 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4403 (Fmaphash, secure_hash):
4404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4405 (concat): Check for string index and length overflow.
4406 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4407 (Frequire):
4408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4409 (larger_vector): New API (vec, incr_min, size_max) replaces old
4410 one (vec, new_size, init). This catches size overflow.
4411 INIT was removed because it was always Qnil.
4412 All callers changed.
4413 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4414 the upper bound on a hash table index size.
4415 (make_hash_table, maybe_resize_hash_table): Use it.
4416 (secure_hash): Computer start_byte and end_byte only after
4417 they're known to be in ptrdiff_t range.
4418 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4419 (Ffont_get_glyphs, Ffont_at):
4420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4421 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4422 (Flist_fonts, Fopen_font):
4423 Don't assume fixnum can fit in int.
4424 (check_gstring): Don't assume index can fit in int.
4425 (font_match_p): Check that fixnum is a character, not a nonnegative
4426 fixnum, since the later code needs to stuff it into an int.
4427 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4428 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4429 conversion overflow issues.
4430 (Fopen_font): Check for integer out of range.
4431 (Ffont_get_glyphs): Don't assume index can fit in int.
4432 * font.h: Adjust decls to match defn changes elsewhere.
4433 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4434 integer overflow.
4435 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4436 printmax_t, where ptrdiff_t is wide enough.
4437 (Finternal_char_font):
4438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4439 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4440 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4441 (Fset_frame_position, x_set_frame_parameters)
4442 (x_set_line_spacing, x_set_border_width)
4443 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4444 Check that fixnums are in proper range for system types.
4445 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4448 Use SAFE_ALLOCA_LISP, not alloca.
4449 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4450 intptr_t is wide enough.
4451 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4452 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4453 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4454 Check for fixnum out of range.
4455 * ftfont.c (ftfont_list): Don't assume index fits in int.
4456 Check that fixnums are in proper range for system types.
4457 (ftfont_shape_by_flt):
4458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4459 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4461 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4462 Check that fixnums are in proper range for system types.
4463 * gnutls.h: Adjust decls to match defn changes elsewhere.
4464 * gtkutil.c (xg_dialog_run):
4465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4466 (update_frame_tool_bar):
4467 Check that fixnums are in proper range for system types.
4468 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4469 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4470 * indent.c (last_known_column, last_known_column_point):
4471 (current_column_bol_cache):
4472 (skip_invisible, current_column, check_display_width):
4473 (check_display_width, scan_for_column, current_column_1)
4474 (Findent_to, Fcurrent_indentation, position_indentation)
4475 (indented_beyond_p, Fmove_to_column, compute_motion):
4476 (Fcompute_motion, Fvertical_motion):
4477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4478 (last_known_column_modified): Use EMACS_INT, not int.
4479 (check_display_width):
4480 (Fcompute_motion):
4481 Check that fixnums and floats are in proper range for system types.
4482 (compute_motion): Don't assume index or fixnum fits in int.
4483 (compute_motion, Fcompute_motion):
4484 Use int, not EMACS_INT, when it is wide enough.
4485 (vmotion): Omit local var start_hpos that is always 0; that way
4486 we don't need to worry about overflow in expressions involving it.
4487 * indent.h: Adjust decls to match defn changes elsewhere.
4488 (struct position):
4489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4490 Use int, not EMACS_INT, where int is wide enough.
4491 Remove unused members ovstring_chars_done and tab_offset;
4492 all uses removed.
4493 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4494 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4495 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4496 (make_gap, copy_text, insert, insert_and_inherit)
4497 (insert_before_markers, insert_before_markers_and_inherit)
4498 (insert_1, count_combining_before, count_combining_after)
4499 (insert_1_both, insert_from_string)
4500 (insert_from_string_before_markers, insert_from_string_1)
4501 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4502 (adjust_after_replace, adjust_after_insert, replace_range)
4503 (replace_range_2, del_range, del_range_1, del_range_byte)
4504 (del_range_both, del_range_2, modify_region)
4505 (prepare_to_modify_buffer, signal_before_change)
4506 (signal_after_change, Fcombine_after_change_execute):
4507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4508 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4509 (balance_an_interval, split_interval_right, split_interval_left)
4510 (find_interval, next_interval, update_interval)
4511 (adjust_intervals_for_insertion, delete_node, delete_interval)
4512 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4513 (static_offset_intervals, offset_intervals)
4514 (merge_interval_right, merge_interval_left, make_new_interval)
4515 (graft_intervals_into_buffer, temp_set_point_both)
4516 (temp_set_point, set_point, adjust_for_invis_intang)
4517 (set_point_both, move_if_not_intangible, get_property_and_range)
4518 (get_local_map, copy_intervals, copy_intervals_to_string)
4519 (compare_string_intervals, set_intervals_multibyte_1):
4520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4521 * intervals.h: Adjust decls to match defn changes elsewhere.
4522 (struct interval):
4523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4524 * keyboard.c (this_command_key_count, this_single_command_key_start)
4525 (before_command_key_count, before_command_echo_length, echo_now)
4526 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4527 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4528 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4529 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4531 (last_non_minibuf_size, last_point_position, echo_truncate)
4532 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4533 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4534 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4535 (stuff_buffered_input):
4536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4537 (last_auto_save, command_loop_1, read_char):
4538 Use EMACS_INT, not int, to avoid integer overflow.
4539 (record_char): Avoid overflow in total_keys computation.
4540 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4541 * keyboard.h: Adjust decls to match defn changes elsewhere.
4542 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4543 (Fkey_description, Fdescribe_vector, Flookup_key):
4544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4545 (click_position): New function, to check that positions are in range.
4546 (Fcurrent_active_maps):
4547 (describe_command):
4548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4549 (Faccessible_keymaps, Fkey_description):
4550 (preferred_sequence_p):
4551 Don't assume fixnum can fit into int.
4552 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4553 Check for integer overflow in size calculations.
4554 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4555 avoid mishandling large integers.
4556 * lisp.h: Adjust decls to match defn changes elsewhere.
4557 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4558 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4559 (struct Lisp_Marker):
4560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4561 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4562 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4563 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4564 All callers changed.
4565 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4566 Assume the arg has valid form, since it always does.
4567 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4568 unsigned integer system type.
4569 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4570 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4572 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4573 (duration_to_sec_usec): New decl.
4574 * lread.c (read_from_string_index, read_from_string_index_byte)
4575 (read_from_string_limit, readchar, unreadchar, openp)
4576 (read_internal_start, read1, oblookup):
4577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4578 (Fload, readevalloop, Feval_buffer, Feval_region):
4579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4580 (openp): Check for out-of-range argument to 'access'.
4581 (read1): Use int, not EMACS_INT, where int is wide enough.
4582 Don't assume fixnum fits into int.
6efdadfd 4583 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4584 (read_filtered_event): Use duration_to_sec_usec
4585 to do proper overflow checking on durations.
d311d28c
PE
4586 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4587 in size calculation.
4588 (Fexecute_kbd_macro):
4589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4590 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4591 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4592 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4593 (set_marker_both, set_marker_restricted_both, marker_position)
4594 (marker_byte_position, Fbuffer_has_markers_at):
4595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4596 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4597 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4598 It now merely ensures that the menu is large enough, without
4599 necessarily growing it, as this avoids some integer overflow issues.
4600 All callers changed.
4601 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4603 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4604 Use SAFE_ALLOCA_LISP, not alloca.
4605 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4606 to EMACS_INT. Check that fixnums are in proper range for system types.
4607 * minibuf.c (minibuf_prompt_width, string_to_object)
4608 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4609 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4611 (get_minibuffer, read_minibuf_unwind):
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4614 this simplifies overflow checking. All callers changed.
4615 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4616 (Ftest_completion):
4617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4618 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4619 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4620 Check that fixnums are in proper range for system types.
4621 (Fx_create_frame, Fx_show_tip):
4622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4623 * nsfont.m (ns_findfonts, nsfont_list_family):
4624 Don't assume fixnum fits in long.
4625 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4627 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4628 wide enough.
17fdb222 4629 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4631 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4632 (PRINTDECLARE, PRINTPREPARE):
4633 (strout, print_string):
4634 (print, print_preprocess, print_check_string_charset_prop)
4635 (print_object):
4636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4637 (PRINTDECLARE):
4638 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4640 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4641 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4642 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4643 (print_error_message): Use SAFE_ALLOCA, not alloca.
4644 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4645 (print_depth, new_backquote_output, print_number_index):
4646 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4647 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4648 (Fset_process_window_size, Fformat_network_address)
4649 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4650 (sigchld_handler):
d311d28c 4651 Check that fixnums are in proper range for system types.
d44287d4 4652 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4653 Check for process-ids out of pid_t range rather than relying on
4654 undefined behavior.
e4d81efc 4655 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4656 (Fformat_network_address, read_process_output, send_process)
4657 (Fprocess_send_region, status_notify):
4658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4659 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4660 (wait_reading_process_output, read_process_output, exec_sentinel):
4661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4662 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4663 (Faccept_process_output): Use duration_to_sec_usec to do proper
4664 overflow checking on durations.
dde14581
PE
4665 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4666 Don't assume pid_t fits in int.
02481186
PE
4667 * process.h (struct Lisp_Process): Members tick and update_tick
4668 are now of type EMACS_INT, not int.
b62b53e8
PE
4669 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4670 configured --with-wide-int.
d311d28c
PE
4671 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4672 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4673 * search.c (looking_at_1, string_match_1):
4674 (fast_string_match, fast_c_string_match_ignore_case)
4675 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4676 (scan_newline, find_before_next_newline, search_command)
4677 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4678 (set_search_regs, wordify):
4679 (Freplace_match):
4680 (Fmatch_data):
4681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4682 (string_match_1, search_buffer, set_search_regs):
4683 (Fmatch_data):
4684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4685 (wordify): Check for overflow in size calculation.
4686 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4687 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4688 Check that fixnums are in proper range for system types.
4689 * sound.c (struct sound_device)
4690 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4692 (Fplay_sound_internal):
4693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4694 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4695 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4696 (Fparse_partial_sexp):
4697 Don't assume fixnums can fit in int.
4698 (struct lisp_parse_state, find_start_pos, find_start_value)
4699 (find_start_value_byte, find_start_begv)
4700 (update_syntax_table, char_quoted, dec_bytepos)
4701 (find_defun_start, prev_char_comend_first, back_comment):
4702 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4703 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4705 (Finternal_describe_syntax_value): Check that match_lisp is a
4706 character, not an integer, since the code stuffs it into int.
4707 (scan_words, scan_sexps_forward):
4708 Check that fixnums are in proper range for system types.
4709 (Fforward_word):
4710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4711 (scan_sexps_forward):
4712 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4713 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4714 * syntax.h: Adjust decls to match defn changes elsewhere.
4715 (struct gl_state_s):
4716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4717 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4718 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4719 * sysdep.c (wait_for_termination_1, wait_for_termination)
4720 (interruptible_wait_for_termination, mkdir):
4721 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4722 (emacs_read, emacs_write):
4723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4724 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4725 and double all fit in int.
d311d28c
PE
4726 * term.c (set_tty_color_mode):
4727 Check that fixnums are in proper range for system types.
4728 * termhooks.h (struct input_event):
4729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4730 * textprop.c (validate_interval_range, interval_of)
4731 (Fadd_text_properties, set_text_properties_1)
4732 (Fremove_text_properties, Fremove_list_of_text_properties)
4733 (Ftext_property_any, Ftext_property_not_all)
4734 (copy_text_properties, text_property_list, extend_property_ranges)
4735 (verify_interval_modification):
4736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4737 (Fnext_single_char_property_change)
4738 (Fprevious_single_char_property_change):
4739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4740 (copy_text_properties):
4741 Check for integer overflow in index calculation.
d311d28c
PE
4742 * undo.c (last_boundary_position, record_point, record_insert)
4743 (record_delete, record_marker_adjustment, record_change)
4744 (record_property_change):
4745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4746 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4748 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4749 (Fx_hide_tip, Fx_file_dialog):
4750 * w32menu.c (set_frame_menubar):
4751 Use ptrdiff_t, not int, for consistency with rest of code.
4752 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4753 (select_window, Fdelete_other_windows_internal)
4754 (window_scroll_pixel_based, window_scroll_line_based)
4755 (Frecenter, Fset_window_configuration):
4756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4757 (Fset_window_hscroll, run_window_configuration_change_hook)
4758 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4759 (Fscroll_other_window, Frecenter):
d311d28c
PE
4760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4761 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4762 Don't assume fixnum fits in int.
4763 (Fset_window_scroll_bars):
4764 Check that fixnums are in proper range for system types.
4765 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4766 (string_pos, c_string_pos, number_of_chars, init_iterator)
4767 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4768 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4769 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4770 (face_before_or_after_it_pos, handle_invisible_prop)
4771 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4772 (display_prop_intangible_p, string_buffer_position_lim)
4773 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4774 (get_overlay_strings_1, get_overlay_strings)
4775 (iterate_out_of_display_property, forward_to_next_line_start)
4776 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4777 (get_next_display_element, set_iterator_to_next)
4778 (get_visually_first_element, compute_stop_pos_backwards)
4779 (handle_stop_backwards, next_element_from_buffer)
4780 (move_it_in_display_line_to, move_it_in_display_line)
4781 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4782 (add_to_log, message_dolog, message_log_check_duplicate)
4783 (message2, message2_nolog, message3, message3_nolog
4784 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4785 (current_message_1, truncate_echo_area, truncate_message_1)
4786 (set_message, set_message_1, store_mode_line_noprop)
4787 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4788 (text_outside_line_unchanged_p, check_point_in_composition)
4789 (reconsider_clip_changes)
4790 (redisplay_internal, set_cursor_from_row, try_scrolling)
4791 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4792 (redisplay_window, find_last_unchanged_at_beg_row)
4793 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4794 (trailing_whitespace_p, find_row_edges, display_line)
4795 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4796 (display_mode_element, store_mode_line_string)
4797 (pint2str, pint2hrstr, decode_mode_spec)
4798 (display_count_lines, display_string, draw_glyphs)
4799 (x_produce_glyphs, x_insert_glyphs)
4800 (rows_from_pos_range, mouse_face_from_buffer_pos)
4801 (fast_find_string_pos, mouse_face_from_string_pos)
4802 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4804 (safe_call, init_from_display_pos, handle_fontified_prop)
4805 (handle_single_display_spec, load_overlay_strings)
4806 (with_echo_area_buffer, setup_echo_area_for_printing)
4807 (display_echo_area, echo_area_display)
4808 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4809 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4810 (redisplay_window, dump_glyph_row, display_mode_line)
4811 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4812 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4814 (handle_single_display_spec, build_desired_tool_bar_string)
4815 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4816 (get_specified_cursor_type):
4817 Check that fixnums are in proper range for system types.
4818 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4819 (Flookup_image_map):
4820 Don't assume fixnums fit in int.
4821 (compare_overlay_entries):
4822 Avoid mishandling comparisons due to subtraction overflow.
4823 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4824 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4825 (handle_tool_bar_click):
4826 Use int, not unsigned, since we prefer signed and the signedness
4827 doesn't matter here.
4828 (get_next_display_element, next_element_from_display_vector):
4829 Use int, not EMACS_INT, when int is wide enough.
4830 (start_hourglass): Use duration_to_sec_usec to do proper
4831 overflow checking on durations.
4832 * xfaces.c (Fbitmap_spec_p):
4833 Check that fixnums are in proper range for system types.
4834 (compare_fonts_by_sort_order):
4835 Avoid mishandling comparisons due to subtraction overflow.
4836 (Fx_family_fonts, realize_basic_faces):
4837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4838 (Fx_family_fonts):
4839 Don't assume fixnum fits in int.
4840 Use SAFE_ALLOCA_LISP, not alloca.
4841 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4842 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4843 (face_at_buffer_position, face_for_overlay_string)
4844 (face_at_string_position):
4845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4846 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4847 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4848 (Fx_show_tip):
4849 Check that fixnums are in proper range for system types.
4850 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4851 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4853 (Fx_change_window_property): Don't assume fixnums fit in int.
4854 * xfont.c (xfont_chars_supported):
4855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4856 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4857 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4859 * xml.c (parse_region):
4860 * xrdb.c (magic_file_p):
4861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4862 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4863 (x_get_local_selection, x_reply_selection_request)
4864 (x_handle_selection_request, wait_for_property_change):
4865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4866 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4867 short is wide enough.
4868 (x_send_client_event): Don't assume fixnum fits in int.
4869 * xterm.c (x_x_to_emacs_modifiers):
4870 Don't assume EMACS_INT overflows nicely into int.
4871 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4872 may come from Lisp.
4873 (handle_one_xevent): NATNUMP can eval its arg twice.
4874 (x_connection_closed):
4875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4876 * xterm.h: Adjust decls to match defn changes elsewhere.
4877 (struct scroll_bar): Use struct vectorlike_header
4878 rather than rolling our own approximation.
4879 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4880
c6574eb5
GM
48812012-05-25 Glenn Morris <rgm@gnu.org>
4882
4883 * lisp.mk (lisp): Update for more files being compiled now.
4884
e8d32c7e
SM
48852012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4886
48def666
SM
4887 * lread.c: Remove `read_pure' which makes no difference.
4888 (read_pure): Remove var.
4889 (unreadpure): Remove function.
4890 (readevalloop): Don't call read_list with -1 flag.
4891 (read1, read_vector): Don't test read_pure any more.
4892 (read_list): Simplify.
4893
e8d32c7e
SM
4894 * fileio.c, character.h: Minor style tweaks.
4895
4b2addb7
DA
48962012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4897
4898 * window.h (clip_changed): Remove useless declaration.
4899
584461b2
JB
49002012-05-22 Juanma Barranquero <lekktu@gmail.com>
4901
4902 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4903 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4904
34374650
PE
49052012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4906
4907 Remove src/m/*.
4908 This directory predates autoconf and is no longer needed nowadays.
4909 Move its few remaining bits of functionality to where they're needed.
4910 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4911 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4912 * m/template.h: Remove.
4913 * Makefile.in (M_FILE): Remove. All uses removed.
4914 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4915 * lisp.h (USE_LSB_TAG):
4916 * mem-limits.h (EXCEEDS_LISP_PTR):
4917 Use VAL_MAX, not VALBITS, in #if.
4918 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4919 (EMACS_UINT): Define unconditionally now.
4920 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4921 (BITS_PER_EMACS_INT): New constants, replacing
4922 what used to be in config.h, but not useful in #if.
4923 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4924 define them any more.
4925 (VAL_MAX): New macro.
4926 (VALMASK): Use it.
4927 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4928 BITS_PER_EMACS_INT, in #if.
4929 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4930 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4931 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4932 * s/ms-w32.h (DATA_START):
4933 Move here from removed file m/intel386.h.
4934 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4935 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4936
261cb4bb
PE
49372012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4938
4939 Assume C89 or later.
4940 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4941 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4942 (xrealloc):
4943 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4944 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4945 * textprop.c, tparam.c (NULL): Remove.
4946 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4947 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4948 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4949 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4950 * xterm.c (input_signal_count): Assume volatile works.
4951
ff23cd9f
KB
49522012-05-21 Ken Brown <kbrown@cornell.edu>
4953
4954 * xgselect.c (xg_select): Fix first argument in call to 'select'
4955 (bug#11508).
4956
1b170bc6
KB
49572012-05-20 Ken Brown <kbrown@cornell.edu>
4958
4959 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4960 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4961
b2f4d39f
KB
49622012-05-19 Ken Brown <kbrown@cornell.edu>
4963
4964 * xfns.c (x_in_use): Remove `static' qualifier.
4965 * xterm.h (x_in_use): Declare.
4966 * xgselect.c: Include xterm.h.
4967 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4968 and `display_arg' (bug#9754).
4969
003fdae2
PE
49702012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4971
9232a6d9
PE
4972 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4973
003fdae2
PE
4974 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4975 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4976
784b56e2
EZ
49772012-05-18 Eli Zaretskii <eliz@gnu.org>
4978
4979 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4980
4981 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4982 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4983
4984 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4985 reference to image_cache->refcount.
4986 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4987
a0a79cde
JL
49882012-05-17 Juri Linkov <juri@jurta.org>
4989
4990 * search.c (Fword_search_regexp, Fword_search_backward)
4991 (Fword_search_forward, Fword_search_backward_lax)
4992 (Fword_search_forward_lax): Move functions to isearch.el
4993 (bug#10145, bug#11381).
4994
b0572523
PE
49952012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4996
4997 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4998
9660f5fc
SM
49992012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5000
5001 * lread.c (init_obarray): Declare Qt and Qnil as special.
5002
4374de83
GM
50032012-05-14 Glenn Morris <rgm@gnu.org>
5004
5005 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5006 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5007
dc44c39a
PE
50082012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5009
078c97cb
PE
5010 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5011
dc44c39a
PE
5012 * unexaix.c: Port to more-recent AIX compilers.
5013 (report_error, report_error_1, make_hdr, copy_sym)
5014 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5015 Make arguments const char *, not char *, to avoid violations of C
5016 standard and to fix some AIX warnings reported by Gilles Pion.
5017
e18afed7 50182012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5019
5020 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5021 already have overlays loaded.
5022 (handle_single_display_spec): Before returning without displaying
5023 fringe bitmap, synchronize the bidi iterator with the main display
5024 iterator, by calling iterate_out_of_display_property.
5025 (iterate_out_of_display_property): Detect buffer iteration by
5026 testing that it->string is a Lisp string.
5027 (get_next_display_element): When the current object is exhausted,
5028 and there's something on it->stack, call set_iterator_to_next to
5029 proceed with what's on the stack, instead of returning zero.
5030 (set_iterator_to_next): If called at the end of a Lisp string,
5031 proceed to consider_string_end without incrementing string
5032 position. Don't increment display vector index past the end of
5033 the display vector. (Bug#11417)
c8fb9dc6
EZ
5034 (pos_visible_p): Don't report a position visible when move_it_to
5035 stopped at the last line of window, which happens to be scanned
5036 backwards by the bidi iteration. (Bug#11464)
ac268e67 5037
e18afed7 50382012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5039
5040 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5041 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5042 are on a TTY, and thus unable to display on the fringes.
5043 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5044 so we need to signal to the caller that this is a "replacing"
5045 display spec. This fixes display when the spec is invalid or we
5046 are on a TTY.
5047
e18afed7 50482012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5049
5050 * unexaix.c (make_hdr): Fix typo in prototype.
5051 This bug broke the build on AIX. Problem reported by Gilles Pion.
5052
9d0a235a
MA
50532012-05-14 Michael Albinus <michael.albinus@gmx.de>
5054
5055 * keyboard.c (kbd_buffer_get_event): Read special events also in
5056 batch mode. (Bug#11415)
5057
9e6b06ed
GM
50582012-05-12 Glenn Morris <rgm@gnu.org>
5059
5060 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5061
c1a1d7a3
EZ
50622012-05-12 Eli Zaretskii <eliz@gnu.org>
5063
5064 * lisp.mk (lisp): Add newcomment.elc.
5065
3fe7cdc8
GM
50662012-05-12 Glenn Morris <rgm@gnu.org>
5067
5068 * Makefile.in (MKDIR_P): New, set by configure.
5069 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5070
53f7d2c0
PE
50712012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5072
5073 Remove unused function hourglass_started.
5074 * dispextern.h (hourglass_started):
5075 * w32fns.c (hourglass_started):
5076 * xdisp.c (hourglass_started): Remove.
5077
75aafb17
JB
50782012-05-10 Juanma Barranquero <lekktu@gmail.com>
5079
5080 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5081 Update dependencies.
5082
12959e8e
PE
50832012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5084
97107e2e
PE
5085 * xgselect.c (xg_select): Put maxfds+1 into a var.
5086 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5087
12959e8e
PE
5088 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5089
836d29b3
DA
50902012-05-10 Dave Abrahams <dave@boostpro.com>
5091
5092 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5093 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5094
5cb67954
MA
50952012-05-09 Michael Albinus <michael.albinus@gmx.de>
5096
5097 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5098 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5099 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5100 Initialize xd_registered_buses.
5101
3478ec45
PE
51022012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5103
b263a6b0
PE
5104 Untag more efficiently if USE_LSB_TAG.
5105 This is based on a proposal by YAMAMOTO Mitsuharu in
5106 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5107 For an admittedly artificial (nth 8000 longlist) benchmark on
5108 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5109 Emacs's overall text size by 1%.
5110 * lisp.h (XUNTAG): New macro.
5111 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5112 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5113 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5114 * eval.c (Fautoload):
5115 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5116 * frame.h (XFRAME): Use XUNTAG.
5117
3478ec45
PE
5118 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5119 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5120 Remove unportable assumptions about print widths of types like
5121 dbus_uint32_t.
5122 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5123 intptr_t when converting between pointer and integer, to avoid GCC
5124 warnings about wrong width.
5125
666b903b 51262012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5127
5128 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5129 stack for each reader_thread, instead of defaulting to 8MB
5130 determined by the linker. This avoids failures in creating
5131 subprocesses on Windows 7, see the discussion in this thread:
5132 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5133
b120cc17
JC
51342012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5135
5136 Fix up display of the *Minibuf-0* buffer in the mini window.
5137 * keyboard.c (read_char): Don't clear the echo area if there's no
5138 message to clear.
5139 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5140 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5141
9a4b36f8
MA
51422012-05-07 Michael Albinus <michael.albinus@gmx.de>
5143
5144 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5145 batch mode.
5146
e5f9458f
CY
51472012-05-06 Chong Yidong <cyd@gnu.org>
5148
5149 * lisp.mk (lisp): Update.
5150
eceeb5fc 51512012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5152
5153 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5154
71873e2b
SM
51552012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5156
5157 * data.c (PUT_ERROR): New macro.
5158 (syms_of_data): Use it. Add new error type `user-error'.
5159 * undo.c (user_error): New function.
5160 (Fprimitive_undo): Use it.
5161 * print.c (print_error_message): Adjust print style for `user-error'.
5162 * keyboard.c (user_error): New function.
5163 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5164
ab0fa4e4
PE
51652012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5166
5167 Do not limit current-time-string to years 1000..9999.
5168 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5169 (Fcurrent_time_string): Support any year that is supported by the
5170 underlying localtime representation. Don't use asctime, as it
5171 has undefined behavior for years outside the range -999..9999.
5172
7ed806a7
PE
51732012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5174
5175 Fix race conditions involving setenv, gmtime, localtime, asctime.
5176 Without this fix, interrupts could mess up code that uses these
5177 nonreentrant functions, since setting TZ invalidates existing
5178 tm_zone or tzname values, and since most of these functions return
5179 pointers to static storage.
5180 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5181 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5182 Grow the critical sections to include not just invoking
5183 localtime/gmtime, but also accessing these functions' results
5184 including their tm_zone values if any, and any related TZ setting.
5185 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5186 so that the struct tm is saved in the critical section.
5187 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5188 motivated by the fact that memory allocation needs to be outside
5189 the critical section.
5190
0c16dfed
DA
51912012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5192
5193 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5194 with RESET_INTERVAL.
5195
5196 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5197 Remove duplicated buffer name initialization.
5198
3f83ace8
JM
51992012-05-02 Jim Meyering <jim@meyering.net>
5200
5201 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5202
c7b8541e
JM
5203 * xfns.c (x_window): Use xstrdup (Bug#11375).
5204
90207a15 52052012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5206
5207 * xdisp.c (pos_visible_p): If already at a newline from the
5208 display string before the 'while' loop, don't walk back the glyphs
5209 from it3.glyph_row. Solves assertion violation when the display
5210 string begins with a newline (egg.el). (Bug#11367)
5211
b593d6a9
AH
52122012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5213
5214 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5215 Move to simple.el.
5216
4737362e
GM
52172012-05-01 Glenn Morris <rgm@gnu.org>
5218
99cf43f9
GM
5219 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5220 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5221 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5222 All were removed before 23.1.
5223
9311dcff
GM
5224 * dispnew.c: Remove HAVE_LIBNCURSES test;
5225 it is always true on relevant platforms.
5226
4d5c6349
GM
5227 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5228 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5229
4737362e
GM
5230 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5231
74dd3a6b
AS
52322012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5233
5234 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5235 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5236 Remove.
5237
13c379ee
PE
52382012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 Do not avoid creating empty evaporating overlays (Bug#9642).
5241 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5242 That is, do not delete an evaporating overlay if it becomes
5243 empty after its bounds are adjusted to fit within its buffer.
5244 This fix caused other problems, and I'm reverting it until we get
5245 to the bottom of them.
5246
a8e7d6d7 52472012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5248
5249 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5250
a8e7d6d7 52512012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5252
5253 * xdisp.c (pos_visible_p): If the window start position is beyond
5254 ZV, start the display from buffer beginning. Prevents assertion
5255 violation in init_iterator when the minibuffer window is scrolled
5256 via the scroll bar.
5257
5258 * window.c (window_scroll_pixel_based): Likewise.
5259
a8e7d6d7 52602012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5261
5262 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5263
a8e7d6d7 52642012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5265
5266 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5267 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5268
a8e7d6d7 52692012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5270
b593d6a9
AH
5271 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5272 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5273
1c6900d9
EZ
52742012-04-26 Eli Zaretskii <eliz@gnu.org>
5275
4c3fa1d9
EZ
5276 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5277 display element, check also the underlying string or buffer
5278 character. (Bug#11341)
5279
1c6900d9
EZ
5280 * w32menu.c: Include w32heap.h.
5281 (add_menu_item): If the call to AppendMenuW (via
5282 unicode_append_menu) fails, disable Unicode menus only if we are
5283 running on Windows 9X/Me.
5284
42bf8205
AS
52852012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5286
5287 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5288 (xgetint): Add missing shift for LSB tags.
5289
b1bac16e
MR
52902012-04-24 Martin Rudalics <rudalics@gmx.at>
5291
5292 * keyboard.c (read_char): Don't wipe echo area for select window
5293 events: These might get delayed via `mouse-autoselect-window'
5294 (Bug#11304).
5295
d69621cc
JB
52962012-04-24 Juanma Barranquero <lekktu@gmail.com>
5297
5298 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5299 manipulation of :loaded-from data.
5300
02fd101b
JB
53012012-04-23 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5304 now a cons (bug#11311).
5305
888bec30
PE
53062012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5307
89a438bd
PE
5308 Do not create empty overlays with the evaporate property (Bug#9642).
5309 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5310 if it becomes empty after its bounds are adjusted to fit within
5311 its buffer. Without this fix, in a nonempty buffer (let ((o
5312 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5313 yields an empty overlay that has the evaporate property, which is
5314 not supposed to happen.
5315
1068fe4d
PE
5316 Fix minor GTK3 problems found by static checking.
5317 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5318 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5319 (struct _EmacsFixedClass, emacs_fixed_get_type):
5320 Move decls here from emacsgtkfixed.h, since they needn't be public.
5321 (emacs_fixed_get_type): Now static.
5322 (emacs_fixed_class_init): Omit unused local.
5323 (emacs_fixed_child_type): Remove; unused.
5324 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5325 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5326 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5327 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5328 (EMACS_FIXED_GET_CLASS): Remove; unused.
5329 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5330
888bec30
PE
5331 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5332 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5333
de85e130
PE
53342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5335
d0baac98 5336 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5337 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5338 (__malloc_size_t, __malloc_ptrdiff_t):
5339 Remove. All uses removed, replaced by the definiens if needed,
5340 since we can assume C89 or better now.
5341 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5342 (protect_malloc_state, align, get_contiguous_space)
5343 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5344 (malloc_atfork_handler_child, malloc_enable_thread)
5345 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5346 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5347 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5348 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5349 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5350 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5351 Define using prototypes, not old style.
5352 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5353 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5354 (align): Don't assume that signed integer overflow wraps around.
5355 Omit unused local var.
5356 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5357 (_free_internal_nolock, memalign, mallochook, reallochook):
5358 Omit no-longer-needed casts.
5359 (valloc): Use getpagesize, not __getpagesize.
5360 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5361 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5362
de85e130
PE
5363 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5364
dcbf5805
MA
53652012-04-22 Michael Albinus <michael.albinus@gmx.de>
5366
5367 Move functions from C to Lisp. Make non-blocking method calls
5368 the default. Implement further D-Bus standard interfaces.
5369
5370 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5371 (QCdbus_request_name_allow_replacement)
5372 (QCdbus_request_name_replace_existing)
5373 (QCdbus_request_name_do_not_queue)
5374 (QCdbus_request_name_reply_primary_owner)
5375 (QCdbus_request_name_reply_in_queue)
5376 (QCdbus_request_name_reply_exists)
5377 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5378 (QCdbus_registered_serial, QCdbus_registered_method)
5379 (QCdbus_registered_signal): New Lisp objects.
5380 (XD_DEBUG_MESSAGE): Use sizeof.
5381 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5382 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5383 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5384 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5385 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5386 (xd_signature, xd_append_arg): Allow float for integer types.
5387 (xd_get_connection_references): New function.
b593d6a9
AH
5388 (xd_get_connection_address): Rename from xd_initialize.
5389 Return cached address.
dcbf5805
MA
5390 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5391 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5392 level.
5393 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5394 Return number of refcounts.
dcbf5805
MA
5395 (Fdbus_get_unique_name): Make stronger parameter check.
5396 (Fdbus_message_internal): New defun.
5397 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5398 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5399 (Fdbus_send_signal, Fdbus_register_service)
5400 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5401 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5402 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5403 (Vdbus_compiled_version, Vdbus_runtime_version)
5404 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5405 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5406 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5407 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5408 Adapt docstring.
dcbf5805 5409
52828e02
PE
54102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5411
da05bc4c
PE
5412 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5413 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5414 Do not assume ptrdiff_t is the same width as 'int'.
5415
52828e02
PE
5416 * alloc.c: Handle unusual debugging option combinations.
5417 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5418 since the two debugging options are incompatible.
5419 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5420 is defined.
5421 (mem_init, mem_insert, mem_insert_fixup):
5422 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5423 (NEED_MEM_INSERT): Remove; no longer needed.
5424
f01769f9
LL
54252012-04-22 Leo Liu <sdl.web@gmail.com>
5426
5427 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5428
5790543d
PE
54292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5430
5431 * sysdep.c [__FreeBSD__]: Minor cleanups.
5432 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5433 Use Emacs indenting style more consistently. Avoid some casts.
5434 Use 'double' consistently rather than mixing 'float' and 'double'.
5435
b91b7e4d
EW
54362012-04-21 Eduard Wiebe <usenet@pusto.de>
5437
b593d6a9
AH
5438 * sysdep.c (list_system_processes, system_process_attributes):
5439 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5440
6114eb15
AS
54412012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5442
5443 * lisp.mk (lisp): Update.
5444
2f38dff7
PE
54452012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5446
5447 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5448 It is never used otherwise.
5449
4ae29f89
SM
54502012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5451
5452 * print.c (print_preprocess): Only check print_depth if print-circle
5453 is nil.
5454 (print_object): Check for cycles even when print-circle is nil and
5455 print-gensym is t, but only check print_depth if print-circle is nil.
5456
f30d612a
CY
54572012-04-20 Chong Yidong <cyd@gnu.org>
5458
5459 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5460 set the status to "failed" and ensure that sentinel is run.
5461
c07a4c0b 54622012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5463
5464 * process.c (Fset_process_inherit_coding_system_flag)
5465 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5466 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5467
c07a4c0b 54682012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5469
5470 * xdisp.c (string_buffer_position_lim): Limit starting position to
5471 BEGV.
5472 (set_cursor_from_row): If called for a mode-line or header-line
5473 row, return zero immediately.
5474 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5475 farther than the first row after the header line, if any.
5476 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5477 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5478
c07a4c0b 54792012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5480
4ae29f89
SM
5481 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5482 (bug#11238).
ad3a2b41 5483
c07a4c0b 54842012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 54852012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5486
5487 configure: new option --enable-gcc-warnings (Bug#11207)
5488 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5489 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5490 (ALL_CFLAGS): Use new macros rather than old.
5491 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5492 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5493 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5494 -Wunused-result, -Wunused-variable. This should go away once
5495 the Emacs and Gnulib regex code is merged.
5496 (xmalloc, xrealloc): Now static.
5497
aba027e8
PE
54982012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 * dired.c (Fsystem_groups): Remove unused local.
5501
e5a36063
GM
55022012-04-17 Glenn Morris <rgm@gnu.org>
5503
5504 * dired.c (Fsystem_users): Doc fix.
5505
316411f0
DA
55062012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5507
5508 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5509 (syms_of_dired): Add them.
5510
9426aba4
PE
55112012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5512
b62a57be
PE
5513 Fix minor alloc.c problems found by static checking.
5514 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5515 New extern decls, to avoid calling undeclared functions.
5516 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5517 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5518 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5519 (NEED_MEM_INSERT): New macro.
5520 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5521 Remove one incorrect comment and fix another.
b62a57be 5522
3539f31f
PE
5523 Fix minor ralloc.c problems found by static checking.
5524 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5525 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5526 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5527 (r_alloc_sbrk): Now static.
5528
a041960a
PE
5529 Improve ralloc.c interface checking.
5530 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5531 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5532 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5533 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5534 [REL_ALLOC]: ... to here, to check interface.
5535 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5536 Remove decls. This fixes an "It stinks!".
5537
9426aba4
PE
5538 * alloc.c (which_symbols): Fix alignment issue / type clash.
5539
d55c12ed
AS
55402012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5541
5542 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5543 (struct Lisp_Misc_Any): Likewise.
5544 (struct Lisp_Free): Likewise.
5545 * alloc.c (union aligned_Lisp_Symbol): Define.
5546 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5547 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5548 (union aligned_Lisp_Misc): Define.
5549 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5550 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5551 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5552
b948ce8b
PE
55532012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5554
5555 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5556 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5557 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5558 * s/netbsd.h, s/sol2-6.h:
5559 Remove definition of GC_MARK_STACK, since the default now works.
5560 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5561 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5562 no longer the default.
5563 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5564
35dc09a1 55652012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5566
35dc09a1
GM
5567 * lread.c (lisp_file_lexically_bound_p):
5568 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5569
35dc09a1
GM
55702012-04-14 Eli Zaretskii <eliz@gnu.org>
5571
5572 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5573 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5574
55752012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5576
5577 * nsterm.m (constrainFrameRect): Always constrain when there is only
5578 one screen (Bug#10962).
5579
bcd86815
KB
55802012-04-13 Ken Brown <kbrown@cornell.edu>
5581
5582 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5583
c25df26e
RT
55842012-04-13 Reuben Thomas <rrt@sc3d.org>
5585
5586 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5587
0fc59f1e
DC
55882012-04-11 Daniel Colascione <dancol@dancol.org>
5589
5590 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5591 against is gone. It's better to use vfork now so that when Cygwin
5592 gains a new, working vfork, we use it automatically (bug#10398).
5593
de8c03dc
SM
55942012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5595
5596 * window.c (save_window_save): Obey window-point-insertion-type.
5597
2f097256
GM
55982012-04-11 Glenn Morris <rgm@gnu.org>
5599
5600 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5601
453b951e
SM
56022012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5603
5604 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5605
75f1671a 56062012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5607
5608 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5609 (force_quit_count): New var.
5610 (handle_interrupt): Use it.
5611
2a8ce227
JB
56122012-04-10 Juanma Barranquero <lekktu@gmail.com>
5613
5614 * w32.c (w32_delayed_load): Record the full path of the library
5615 being loaded (bug#10424).
5616
935396c0
GM
56172012-04-09 Glenn Morris <rgm@gnu.org>
5618
05920a43
GM
5619 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5620 not just in the obarray, before snarfing them. (Bug#11036)
5621
935396c0
GM
5622 * Makefile.in ($(leimdir)/leim-list.el):
5623 Pass EMACS rather than BUILT_EMACS.
5624
a18ecafa
TZ
56252012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5626
5627 * process.c (make_process):
5628 * process.h: Add integer `gnutls_handshakes_tried' member to
5629 process struct.
5630
6bbef4e5
JC
5631 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5632 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5633
5634 * gnutls.c (gnutls_log_function2i): Convenience log function.
5635 (emacs_gnutls_read): Use new log functions,
5636 `gnutls_handshakes_tried' process member, and
5637 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5638 attempts per process (connection).
5639
b4d3bc10
CY
56402012-04-09 Chong Yidong <cyd@gnu.org>
5641
5642 * eval.c (Fuser_variable_p, user_variable_p_eh)
5643 (lisp_indirect_variable): Functions deleted.
5644 (Fdefvar): Caller changed.
5645
5646 * callint.c (Finteractive, Fcall_interactively):
5647 * minibuf.c (Fread_variable): Callers changed.
5648
70f4d973
EZ
56492012-04-09 Eli Zaretskii <eliz@gnu.org>
5650
5651 * xdisp.c (set_cursor_from_row): If the display string appears in
5652 the buffer at position that is closer to point than the position
5653 after the display string, display the cursor on the first glyph of
5654 the display string. Fixes cursor display when a 'display' text
5655 property immediately follows invisible text. (Bug#11094)
5656
cb3c2e3e
PE
56572012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5658
5659 composite.c: use 'double' consistently
5660 * composite.c (get_composition_id): Use 'double' consistently
5661 instead of converting 'float' to 'double' and vice versa; this is
5662 easier to understand and avoids a GCC warning.
5663
fd06db5d
GM
56642012-04-09 Glenn Morris <rgm@gnu.org>
5665
50fe702a
GM
5666 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5667 preparation for dumping it with emacs. (Bug#4789)
5668 (leimdir): New variable.
5669 ($(leimdir)/leim-list.el): New rule.
5670 (emacs$(EXEEXT)): Depend on leim-list.el.
5671
fd06db5d
GM
5672 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5673 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5674 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5675
55c131ee
AS
56762012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5677
5678 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5679 proper alignment.
5680
9209588f
JB
56812012-04-07 Juanma Barranquero <lekktu@gmail.com>
5682
5683 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5684 Remove unused local variable.
5685
e3fb2efb
PE
56862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5687
5688 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5689 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5690 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5691 objects, as mark_maybe_pointer will catch them otherwise.
5692 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5693 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5694
b5385551
PE
56952012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 Fix typo that broke non-Windows builds.
5698 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5699
9078ead6
EZ
57002012-04-07 Eli Zaretskii <eliz@gnu.org>
5701
5702 Support building on MS-Windows with libxml2.
5703
5704 * makefile.w32-in (OBJ2): Add xml.$(O).
5705 (GLOBAL_SOURCES): Add xml.c.
5706 ($(BLD)/xml.$(O)): New dependency list.
5707
5708 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5709 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5710 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5711 [!WINDOWSNT]: New macros.
5712 (init_libxml2_functions, libxml2_loaded_p): New functions.
5713 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5714 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5715 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5716 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5717 linked in).
6bbef4e5
JC
5718 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5719 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5720 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5721
5722 * emacs.c: Don't include libxml/parser.h.
5723 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5724 xmlCleanupParser directly.
5725
5726 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5727
3811fdf3
EZ
57282012-04-07 Eli Zaretskii <eliz@gnu.org>
5729
5730 * indent.c (Fvertical_motion): If there is a display string at
5731 point, use it.vpos to compute how many lines to backtrack after
5732 move_it_to point. (Bug#11133)
5733
2f8e16b2
EZ
57342012-04-06 Eli Zaretskii <eliz@gnu.org>
5735
5736 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5737 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5738 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5739 macros related to unification of CJK characters. For the details,
5740 see the discussion following the message here:
5741 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5742
3d439cd1
CY
57432012-04-04 Chong Yidong <cyd@gnu.org>
5744
5745 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5746
8bc53d00
EZ
57472012-04-01 Eli Zaretskii <eliz@gnu.org>
5748
5749 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5750 instead of alloca. (Bug#11138)
5751
3b0512a3
AS
57522012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5753
5754 * w32menu.c (is_simple_dialog): Properly check lisp types.
5755 (Bug#11141)
5756
8427ddd2
EZ
57572012-03-31 Eli Zaretskii <eliz@gnu.org>
5758
979022ef
EZ
5759 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5760 position we get to after a call to move_it_to fails the
5761 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5762 only if we wind up in a string from display property. (Bug#11063)
5763
a6b1c7cc
EZ
5764 * window.c (Fdelete_other_windows_internal): Invalidate the row
5765 and column information about mouse highlight, so that redisplay
5766 restores it after reallocating the glyph matrices. (Bug#7464)
5767
8427ddd2
EZ
5768 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5769 string comes from a `display' text property, use the buffer
5770 position of that property as if we actually saw that position in
5771 the row's glyphs.
697ba24b
EZ
5772 (move_it_by_lines): Remove the assertion that
5773 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5774 violated when there's a before-string at the beginning of a line.
5775 (Bug#11063)
8427ddd2 5776
65a0a738
EZ
57772012-03-30 Eli Zaretskii <eliz@gnu.org>
5778
5779 * xdisp.c (append_space_for_newline): If the default face was
5780 remapped, use the remapped face for the appended newline.
5781 (extend_face_to_end_of_line): Use the remapped default face for
5782 extending the face to the end of the line.
5783 (display_line): Call extend_face_to_end_of_line when the default
5784 face was remapped. (Bug#11068)
5785
581355cc
EZ
57862012-03-29 Eli Zaretskii <eliz@gnu.org>
5787
5788 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5789
e8fc049f
SM
57902012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5791
5792 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5793
4fb9a543
GM
57942012-03-27 Glenn Morris <rgm@gnu.org>
5795
5796 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5797 Doc fixes.
5798
679910f1
KH
57992012-03-26 Kenichi Handa <handa@m17n.org>
5800
5801 * dispextern.h (struct glyph): Fix previous change. Change the
5802 bit length of glyphless.ch to 25 (Bug#11082).
5803
90d49b7f
CY
58042012-03-26 Chong Yidong <cyd@gnu.org>
5805
5806 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5807 (command_loop_1): Use it; inhibit selection update for
5808 handle-select-window too (Bug#8996).
5809
f514f6f0
FP
58102012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5811
e8fc049f 5812 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5813
bf43fa51
KH
58142012-03-25 Kenichi Handa <handa@m17n.org>
5815
5816 * dispextern.h (struct glyph): Change the bit length of
5817 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5818
8a0c01dd
EZ
58192012-03-24 Eli Zaretskii <eliz@gnu.org>
5820
5821 * s/ms-w32.h (tzname): Include time.h before redirecting to
5822 _tzname. Fixes the MSVC build. (Bug#9960)
5823
7d1c3a76
AS
58242012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5825
8ed79523
AS
5826 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5827 characters.
5828
7d1c3a76
AS
5829 * xterm.c (XTread_socket): Only modify handling_signal if
5830 !SYNC_INPUT. (Bug#11080)
5831
e99a9b8b
EZ
58322012-03-23 Eli Zaretskii <eliz@gnu.org>
5833
5834 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5835 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5836 when fetching a multibyte character consumes more bytes than
5837 CHAR_BYTES returns, due to unification of CJK characters in
5838 string_char. (Bug#11073)
5839
5063c0e1
TN
58402012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5841
5842 * process.c (wait_reading_process_output): Handle pty disconnect
5843 by refraining from sending oneself a SIGCHLD (bug#10933).
5844
9f851fbd
CY
58452012-03-22 Chong Yidong <cyd@gnu.org>
5846
5847 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5848
5063c0e1 5849 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5850 Mark string as coming from a prefix property.
5851 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5852 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5853
fb5b8aca
CY
58542012-03-21 Chong Yidong <cyd@gnu.org>
5855
5856 * xfaces.c (Vface_remapping_alist): Doc fix.
5857
62356a1b
EZ
58582012-03-20 Eli Zaretskii <eliz@gnu.org>
5859
5860 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5861 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5862 Doc fixes.
62356a1b 5863
025de85b
CY
58642012-03-20 Chong Yidong <cyd@gnu.org>
5865
5866 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5867 to reflect default non-nil value of redisplay-dont-pause.
5868
4827f94e
KH
58692012-03-19 Kenichi Handa <handa@m17n.org>
5870
5871 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5872 it fit in a valid range (Bug#11003).
5873
e50a24a2
EZ
58742012-03-18 Eli Zaretskii <eliz@gnu.org>
5875
5876 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5877 that is not from display property, accept the row as a "cursor
5878 row" if one of the string's character has a non-nil `cursor'
5879 property. Fixes cursor positioning when there are newlines in
5880 overlay strings, e.g. in icomplete.el. (Bug#11035)
5881
9af5ed87
PE
58822012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5883
5884 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5885
d1f55f16
CY
58862012-03-12 Chong Yidong <cyd@gnu.org>
5887
5888 * eval.c (inhibit_lisp_code): Rename from
5889 inhibit_window_configuration_change_hook; move from window.c.
5890
5891 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5892 * window.c (run_window_configuration_change_hook)
5893 (syms_of_window): Callers changed.
5894
66c5eebd
CY
58952012-03-11 Chong Yidong <cyd@gnu.org>
5896
413df973
CY
5897 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5898
66c5eebd
CY
5899 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5900
1de11f56
CY
59012012-03-10 Chong Yidong <cyd@gnu.org>
5902
5903 * frame.c (other_visible_frames): Don't assume the selected frame
5904 is visible (Bug#10955).
5905
cae07000
SM
59062012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5907
5908 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5909
89c94350
JD
59102012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5911
5912 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5913 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5914 zero (Bug#10954).
5915
999dd333
GM
59162012-03-03 Glenn Morris <rgm@gnu.org>
5917
01a6dcc8 5918 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5919
de0100f2
EZ
59202012-03-02 Eli Zaretskii <eliz@gnu.org>
5921
5922 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5923 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5924 (redisplay_window, next_element_from_string): Fix typos in
5925 comments.
3e441275
EZ
5926 (redisplay_window): Pass to move_it_vertically the margin in
5927 pixels, not in screen lines.
de0100f2 5928
96a72ee9
GM
59292012-03-02 Glenn Morris <rgm@gnu.org>
5930
5931 * buffer.c (buffer-list-update-hook): Doc fix.
5932
312508d7
EZ
59332012-02-29 Eli Zaretskii <eliz@gnu.org>
5934
5935 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5936 push_it before setting up the iterator for the first overlay
5937 string, even if we have an empty string loaded.
5938 (next_overlay_string): If there's an empty string on the iterator
5939 stack, pop the stack. (Bug#10903)
5940
27f3c637
PE
59412012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5942
5943 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5944 Suggested by Stefan Monnier in
5945 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5946 * alloc.c (widen_to_Lisp_Object): New static function.
5947 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5948 and widening them to Lisp_Objects. This would work even if
5949 USE_LSB_TAG is defined and wide integers are used, which might
5950 happen in a future version of Emacs.
5951
3c9dfce6
CY
59522012-02-25 Chong Yidong <cyd@gnu.org>
5953
fa74b241
CY
5954 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5955 Doc fix.
5956
3c9dfce6
CY
5957 * xselect.c (Fx_selection_exists_p): Doc fix.
5958 (x_clipboard_manager_save_all): Print an informative message
5959 before saving to clipboard manager.
5960
9486df08
CY
59612012-02-24 Chong Yidong <cyd@gnu.org>
5962
5963 * keyboard.c (process_special_events): Handle all X selection
5964 requests in kbd_buffer, not just the next one (Bug#8869).
5965
f01d3321
CY
59662012-02-23 Chong Yidong <cyd@gnu.org>
5967
5968 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5969 call when setting menu-bar-lines and tool-bar-lines parameters.
5970 (unwind_create_frame_1): New helper function.
5971
5972 * window.c (inhibit_window_configuration_change_hook): New var.
5973 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5974 (syms_of_window): Initialize it.
f01d3321 5975
86b847b6
CY
59762012-02-22 Chong Yidong <cyd@gnu.org>
5977
5978 * xterm.c (x_draw_image_relief): Add missing type check for
5979 Vtool_bar_button_margin (Bug#10743).
5980
a59225b1
CY
59812012-02-21 Chong Yidong <cyd@gnu.org>
5982
5983 * fileio.c (Vfile_name_handler_alist): Doc fix.
5984
5985 * buffer.c (Fget_file_buffer): Protect against invalid file
5986 handler return value.
5987
310f5bd4
PE
59882012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5989
cb3a28cc
PE
5990 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5991 when computing $valmask.
5992
310f5bd4
PE
5993 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5994 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5995 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5996 It's useless in that case, and it can cause problems on hosts
5997 that allocate halves of EMACS_INT values separately.
5998 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5999 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6000 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6001 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6002 it avoids undefined behavior on hosts where shifting right by more
6003 than the word width has undefined behavior.
6004
2375c96a
CY
60052012-02-19 Chong Yidong <cyd@gnu.org>
6006
6007 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6008 (Funhandled_file_name_directory, Ffile_name_as_directory)
6009 (Fdirectory_file_name, Fexpand_file_name)
6010 (Fsubstitute_in_file_name): Protect against invalid file handler
6011 return values (Bug#10845).
6012
3eb49e71
EZ
60132012-02-18 Eli Zaretskii <eliz@gnu.org>
6014
6015 * .gdbinit (pitx): Fix incorrect references to fields of the
6016 iterator stack.
6017
7b926f3f
CY
60182012-02-17 Chong Yidong <cyd@gnu.org>
6019
6020 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6021
11273115
PE
60222012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6025 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6026
c3a70e2b
CY
60272012-02-15 Chong Yidong <cyd@gnu.org>
6028
6029 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6030 marked as special. Also, starting docstrings with * is obsolete.
6031
0ca43699
AS
60322012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6033
6034 * gnutls.c (emacs_gnutls_write): Fix last change.
6035
2e8f3c56
LI
60362012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6037
6038 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6039 send_process.
6040
af70074f
SM
60412012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6042
6043 * keymap.c (Fsingle_key_description): Handle char ranges.
6044
95986d52
CY
60452012-02-12 Chong Yidong <cyd@gnu.org>
6046
afd83bd1
CY
6047 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6048 as that creates a dangerous corner case.
6049
95986d52
CY
6050 * window.c (Fdelete_window_internal): Invalidate the mouse
6051 highlight (Bug#9904).
6052
bd7da63e
GM
60532012-02-12 Glenn Morris <rgm@gnu.org>
6054
6055 * xselect.c (Fx_own_selection_internal)
6056 (Fx_get_selection_internal, Fx_disown_selection_internal)
6057 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6058 * nsselect.m (Fx_own_selection_internal)
6059 (Fx_disown_selection_internal, Fx_selection_exists_p)
6060 (Fx_selection_owner_p, Fx_get_selection_internal):
6061 Sync docs and argument specs with the xselect.c versions.
6062
77abcbc2
LI
60632012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6064
6065 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6066
90b671e2
EZ
60672012-02-11 Eli Zaretskii <eliz@gnu.org>
6068
1c0ca0b7
EZ
6069 * w32select.c (Fx_selection_exists_p): Sync doc string and
6070 argument list with xselect.c. (Bug#10783)
6071
6072 * w16select.c (Fx_selection_exists_p): Sync doc string and
6073 argument list with xselect.c. (Bug#10783)
90b671e2 6074
49241268
GM
60752012-02-10 Glenn Morris <rgm@gnu.org>
6076
6077 * fns.c (Fsecure_hash): Doc fix.
6078
f998bbe7 60792012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6080
6081 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6082
0992bd9c
CY
60832012-02-07 Chong Yidong <cyd@gnu.org>
6084
6085 * buffer.c (Fbuffer_local_variables)
6086 (buffer_lisp_local_variables): Handle unbound vars correctly;
6087 don't let Qunbound leak into Lisp.
6088
af008560
GM
60892012-02-07 Glenn Morris <rgm@gnu.org>
6090
dd605cc4
GM
6091 * image.c (Fimagemagick_types): Doc fix.
6092
af008560
GM
6093 * image.c (imagemagick-render-type): Change it from a lisp object
6094 to an integer. Move the doc here from the lisp manual.
6095 Treat all values not equal to 0 the same.
6096
1449fa1d
CY
60972012-02-06 Chong Yidong <cyd@gnu.org>
6098
6099 * doc.c (store_function_docstring): Avoid applying docstring of
6100 alias to base function (Bug#2603).
6101
3723ec07
AS
61022012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6103
6104 * .gdbinit (pp1, pv1): Remove redundant defines.
6105 (pr): Use pp.
6106
79c1cc1e
CY
61072012-02-04 Chong Yidong <cyd@gnu.org>
6108
6109 * nsterm.m: Declare a global (Bug#10694).
6110
d7f29f8e
EZ
61112012-02-04 Eli Zaretskii <eliz@gnu.org>
6112
cae07000
SM
6113 * w32.c (get_emacs_configuration_options):
6114 Include --enable-checking, if specified, in the return value.
d7f29f8e 6115
3b95a6f9
MR
61162012-02-04 Martin Rudalics <rudalics@gmx.at>
6117
6118 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6119 after rounding frame sizes. (Bug#9723)
6120
d6fa96a6
EZ
61212012-02-04 Eli Zaretskii <eliz@gnu.org>
6122
6123 * keyboard.c (adjust_point_for_property): Don't position point
6124 before BEGV. (Bug#10696)
6125
df0b2940
PE
61262012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6127
6128 Handle overflow when computing char display width (Bug#9496).
6129 * character.c (char_width): Return EMACS_INT, not int.
6130 (char_width, c_string_width): Check for overflow when
6131 computing the width; this is possible now that individual
6132 characters can have unbounded width. Problem introduced
6133 by merge from Emacs 23 on 2012-01-19.
6134
6bee44d6
MA
61352012-02-02 Michael Albinus <michael.albinus@gmx.de>
6136
6137 * dbusbind.c (Fdbus_register_method): Mention the return value
6138 :ignore in the docstring.
6139
44f92739
GM
61402012-02-02 Glenn Morris <rgm@gnu.org>
6141
1b9f60cc
GM
6142 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6143
44f92739
GM
6144 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6145 Unconditionally set to t. (Bug#10673)
6146 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6147 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6148 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6149
c5d3843c
KH
61502012-02-02 Kenichi Handa <handa@m17n.org>
6151
6152 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6153 0, do not call append_composite_glyph.
6154
159462d4 61552012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6156
6157 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6158 NULL (Bug#6988).
6159 (x_produce_glyphs): If the component of a composition is a null
6160 string, set it->pixel_width to 1 to avoid zero-width glyph.
6161
78cef877
EZ
61622012-02-01 Eli Zaretskii <eliz@gnu.org>
6163
6164 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6165 first 2 arguments are identical. This makes inserting large
6166 output from a subprocess an order of magnitude faster on
6167 MS-Windows, where all sbrk'ed memory is always contiguous.
6168
97897668
GM
61692012-01-31 Glenn Morris <rgm@gnu.org>
6170
6171 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6172 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6173 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6174
31fd3586
GM
61752012-01-29 Glenn Morris <rgm@gnu.org>
6176
6177 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6178
0e24a8b2
CY
61792012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6180
6181 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6182
cc0adcb0
CY
61832012-01-28 Chong Yidong <cyd@gnu.org>
6184
6185 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6186
acc28cb9
CY
61872012-01-26 Chong Yidong <cyd@gnu.org>
6188
9c69cfb7
CY
6189 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6190
acc28cb9
CY
6191 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6192 repeat counts (Bug#10507).
6193
48da7392
GM
61942012-01-26 Glenn Morris <rgm@gnu.org>
6195
6196 * lread.c (syms_of_lread): Doc fix.
6197
14af5f7f
CY
61982012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6199
6200 * coding.c (encode_designation_at_bol): Change return value to
6201 EMACS_INT.
6202
0b21c100
CY
62032012-01-25 Chong Yidong <cyd@gnu.org>
6204
6205 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6206
3c2907f7
CY
62072012-01-21 Chong Yidong <cyd@gnu.org>
6208
6209 * floatfns.c (Fcopysign): Make the second argument non-optional,
6210 since nil is not allowed anyway.
6211
959ad23f
AS
62122012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6213
6214 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6215 (send_process): Likewise.
6216
34a02f46
MR
62172012-01-19 Martin Rudalics <rudalics@gmx.at>
6218
6219 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6220 (Vwindow_persistent_parameters): Do not use Qstate.
6221 Rewrite doc-strings.
34a02f46 6222
1259009a 62232012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6224
6225 * character.c (char_width): New function.
70d4fdf6
GM
6226 (Fchar_width, c_string_width, lisp_string_width):
6227 Use char_width (Bug#9496).
25ed9e61 6228
6a6ee00d
MR
62292012-01-16 Martin Rudalics <rudalics@gmx.at>
6230
6231 * window.c (Vwindow_persistent_parameters): New variable.
6232 (Fset_window_configuration, save_window_save): Handle persistent
6233 window parameters.
6234
c85efaf7
EZ
62352012-01-14 Eli Zaretskii <eliz@gnu.org>
6236
6237 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6238 thrashing the stack of the thread. (Bug#9087)
6239
5944709e
PE
62402012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6241
6242 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6243
e71f5d99
EZ
62442012-01-11 Eli Zaretskii <eliz@gnu.org>
6245
6246 * xdisp.c (rows_from_pos_range): Handle the case where the
6247 highlight ends on a newline. (Bug#10464)
6248 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6249 he end column for display of highlight that ends on a newline
6250 before a R2L line.
6251
ce316182
GM
62522012-01-11 Glenn Morris <rgm@gnu.org>
6253
6254 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6255 from load-path also when installation-directory is nil. (Bug#10208)
6256
5b43da69
GM
62572012-01-10 Glenn Morris <rgm@gnu.org>
6258
74cc8ff9
GM
6259 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6260
7d8d6e4e
GM
6261 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6262 Update template values to be closer to their typical values these days.
5b43da69 6263
a0db8d43
EZ
62642012-01-09 Eli Zaretskii <eliz@gnu.org>
6265
6266 * xdisp.c (rows_from_pos_range): Accept additional argument
6267 DISP_STRING, and accept any glyph in a row whose object is that
6268 string as eligible for mouse highlight. Fixes mouse highlight of
6269 display strings from overlays. (Bug#10464)
6270
9a0115ab 62712012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6272
b9110d6a 6273 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6274 * fileio.c (auto_saving_dir_umask): New static var.
6275 (Fmake_directory_internal): Use it.
6276 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6277 creating the directory. The old code temporarily assigns
6278 too-generous permissions to the directory.
6279 (do_auto_save_eh): Clear it.
b9110d6a 6280 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6281 that the var is always cleared.
6282
6c1bd3f3
EZ
62832012-01-07 Eli Zaretskii <eliz@gnu.org>
6284
6285 * search.c (scan_buffer): Pass character positions to
6286 know_region_cache, not byte positions. (Bug#6540)
6287
069d2b50
L
62882012-01-07 LynX <_LynX@bk.ru> (tiny change)
6289
6290 * w32.c (sys_rename): Report EXDEV when rename of a directory
6291 fails because the target is on another logical disk. (Bug#10284)
6292
75bf0d33
DB
62932012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6294
6295 * xterm.c (x_embed_request_focus): New function.
6296
6297 * xterm.h: Add prototype.
6298
6299 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6300
1c6e5a32
GM
63012012-01-05 Glenn Morris <rgm@gnu.org>
6302
6303 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6304
651e947e
EZ
63052012-01-01 Eli Zaretskii <eliz@gnu.org>
6306
6307 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6308 Load gnutls_transport_set_lowat only if GnuTLS version is below
6309 2.11.1.
6310 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6311 GnuTLS versions below 2.11.1.
6312
3778cdd8
AL
63132011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6314
6315 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6316 to the doc string advising against its use for altering the way
6317 windows are scrolled.
6318
0e5317f7
KH
63192011-12-28 Kenichi Handa <handa@m17n.org>
6320
6321 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6322 coding-system ASCII compatible only when it does not produce BOM
6323 on encoding (Bug#10383).
6324
93d5ca1f
JD
63252011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6326
6327 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6328 can scroll.
6329 (create_and_show_popup_menu): Always use menu_position_func for
6330 Gtk3 (Bug#10361).
6331
ca22b785
AS
63322011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6333
6334 * callint.c (Fcall_interactively): Don't truncate prompt string.
6335
d048e1e6
EZ
63362011-12-23 Eli Zaretskii <eliz@gnu.org>
6337
6338 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6339 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6340 resumed from there (after widening). (Bug#10360)
d048e1e6 6341
5ccaba1f
JD
63422011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6343
6344 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6345
204ee57f
JD
63462011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6347
b81d40f0
JB
6348 * nsterm.m (x_free_frame_resources):
6349 Release f->output_data.ns->miniimage.
204ee57f
JD
6350 (ns_index_color): Fix indentation. Do not retain
6351 color_table->colors[i].
6352
6353 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6354 before returning.
6355
6356 * nsfns.m (x_set_background_color): Assign return value from
6357 ns_index_color to face-background instead of NSColor*.
6358 (ns_implicitly_set_icon_type): Fix indentation.
6359 Change assignment in for loop to comparison.
6360
6361 * emacs.c (ns_pool): New variable.
6362 (main): Assign ns_pool.
6363 (Fkill_emacs): Call ns_release_autorelease_pool.
6364
6365 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6366 autorelease fdesc, release fdAttrs and tdict.
6367 (ns_get_covering_families): Release charset.
6368 (ns_findfonts): Release NSFontDescriptor created with new.
6369 (ns_uni_to_glyphs): Fix indentation.
6370 (setString): Release attrStr before assigning new value.
6371
c803b2b7
JD
63722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6373
678f4426
JD
6374 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6375 and NS_IMPL_COCOA.
6376 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6377 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6378
cd394be1 63792011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6380
5fecd5fc
JD
6381 * nsterm.m (ns_term_init): Subscribe for notifications
6382 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6383 to method trackingNotification in EmacsMenu.
6384
6385 * nsmenu.m (trackingMenu): New variable.
3771cb17 6386 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6387 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6388 from Aquamacs (Bug#7030).
678f4426
JD
6389
63902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6391
c803b2b7
JD
6392 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6393 (symbol_to_nsstring): Fix indentation.
6394 (ns_symbol_to_pb): New function.
cae07000
SM
6395 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6396 (Fns_rotate_cut_buffers_internal): Remove.
6397 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6398 Fns_store_cut_buffer_internal.
6399 (ns_get_foreign_selection, Fx_own_selection_internal)
6400 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6401 (Fns_get_selection_internal, Fns_store_selection_internal):
6402 Use ns_symbol_to_pb and check if return value is nil.
6403 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6404 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6405 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6406 renamed to Sns_store_selection_internal.
6407 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6408 and remove this function.
6409 (ns_handle_selection_clear): Remove, never used.
6410 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6411 here.
6412
e1b01a3a
KB
64132011-12-17 Ken Brown <kbrown@cornell.edu>
6414
6415 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6416 GID is unknown (Bug#10257).
6417
2adb6e85
PE
64182011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6421 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6422 which caused a build failure on GNU/Linux IA-64. This problem was
6423 introduced by my 2011-10-07 patch.
6424
d1d7b339
JL
64252011-12-15 Juri Linkov <juri@jurta.org>
6426
6427 * image.c (imagemagick_error): New function. (Bug#10112)
6428 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6429 Use `imagemagick_error' where ImageMagick functions return
6430 `MagickFalse'.
6431 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6432 proper order.
6433
100d5755
KH
64342011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6435
6436 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6437 fill background (Bug#8992).
6438
454592a6
MR
64392011-12-13 Martin Rudalics <rudalics@gmx.at>
6440
6441 * window.c (Vwindow_combination_resize)
6442 (Vwindow_combination_limit): Use t instead of non-nil in
6443 doc-strings.
61d4b438
MR
6444 (Vrecenter_redisplay): Add first sentence of doc-string on
6445 separate line.
53524d93 6446 (Frecenter): Fix doc-string typo.
454592a6 6447
3633e3aa
KH
64482011-12-11 Kenichi Handa <handa@m17n.org>
6449
6450 * coding.c (Funencodable_char_position): Pay attention to the
6451 buffer text relocation (Bug#9389).
6452
7b9d523a 64532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6454
7b9d523a
JD
6455 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6456 gtk_init (Bug#10100).
6457
b73189c6
EZ
64582011-12-10 Eli Zaretskii <eliz@gnu.org>
6459
6460 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6461 IT->string is nil. (Bug#10263)
6462
f7dfe5d6
JD
64632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6464
83faebb4
JD
6465 * nsterm.h (x_free_frame_resources): Declare.
6466
f7dfe5d6
JD
6467 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6468 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6469
6470 * nsterm.h (ns_get_defaults_value): Declare.
6471
6472 * nsterm.m (ns_default): Call ns_get_defaults_value.
6473
7cd4e72c
EZ
64742011-12-09 Eli Zaretskii <eliz@gnu.org>
6475
6476 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6477 (Bug#10170)
6478
b34d7317
YM
64792011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6480
6481 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6482 that where the value of an _OBJC_* symbol points to is in the .bss
6483 section (Bug#10240).
6484
76470ad1
KH
64852011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6486
6487 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6488 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6489
745fff94
KH
64902011-12-08 Kenichi Handa <handa@m17n.org>
6491
6492 * ftfont.c (get_adstyle_property): Fix previous change
6493 (Bug#10233).
6494
6e44397c
JB
64952011-12-07 Juanma Barranquero <lekktu@gmail.com>
6496
6497 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6498 dirs from the default value of EMACSLOADPATH (bug#10208).
6499
7efa6272
GM
65002011-12-07 Glenn Morris <rgm@gnu.org>
6501
6502 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6503 installation and source directories as well. (Bug#10208)
6504
f6fc4d87
CY
65052011-12-06 Chong Yidong <cyd@gnu.org>
6506
6507 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6508
2bf26180
GM
65092011-12-06 Glenn Morris <rgm@gnu.org>
6510
6511 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6512 as an error, not just -1. (Bug#10217)
6513
3a6ad4f0
CY
65142011-12-05 Chong Yidong <cyd@gnu.org>
6515
6516 * keyboard.c (process_special_events): New function.
6517 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6518
75a3b399
PE
65192011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6520
6521 * coding.c (encode_designation_at_bol): Don't use uninitialized
6522 local variable (Bug#9318).
6523
c3c9e25e
KH
65242011-12-05 Kenichi Handa <handa@m17n.org>
6525
6526 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6527 return Qnil (Bug#8046, Bug#10193).
6528
5eb05ea3
KH
65292011-12-05 Kenichi Handa <handa@m17n.org>
6530
6531 * coding.c (encode_designation_at_bol): New args charbuf_end and
6532 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6533 (coding_set_source): Return how many bytes coding->source was
6534 relocated.
6535 (coding_set_destination): Return how many bytes
6536 coding->destination was relocated.
6537 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6538 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6539
65402011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6541
6542 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6543 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6544 macro (Bug#9318).
6545
65462011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6547
6548 The following changes are to fix Bug#9318.
6549
a79703f5 6550 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6551 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6552 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6553 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6554
7dbda6df
JB
65552011-12-05 Juanma Barranquero <lekktu@gmail.com>
6556
6557 * lisp.h (process_quit_flag): Fix external declaration.
6558
6d5eb5b0
SM
65592011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6560
6561 Don't macro-inline non-performance-critical code.
6562 * eval.c (process_quit_flag): New function.
6563 * lisp.h (QUIT): Use it.
6564
a0c3fad0
JD
65652011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6566
6567 * nsfns.m (get_geometry_from_preferences): New function.
6568 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6569
6c07aac2
AS
65702011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6571
6572 * emacs.c (Qkill_emacs): Define.
6573 (syms_of_emacs): Initialize it.
6574 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6575 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6576 (quit_throw_to_read_char): Add parameter `from_signal'.
6577 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6578 * lisp.h (QUIT): Call Fkill_emacs if requested.
6579
c052ead4
JD
65802011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6581
6582 * widget.c (update_wm_hints): Return if wmshell is null.
6583 (widget_update_wm_size_hints): New function.
6584
6585 * widget.h (widget_update_wm_size_hints): Declare.
6586
6587 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6588 widget_update_wm_size_hints (Bug#10104).
6589
9e49252b
EZ
65902011-12-03 Eli Zaretskii <eliz@gnu.org>
6591
6592 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6593 before a newline, prepare the bidi iterator for consuming the
6594 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6595 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6596
02b16839
JL
65972011-12-02 Juri Linkov <juri@jurta.org>
6598
6599 * search.c (Fword_search_regexp): New Lisp function created from
6600 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6601 (Fword_search_backward, Fword_search_forward)
6602 (Fword_search_backward_lax, Fword_search_forward_lax):
6603 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6604 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6605
0068070e
SM
66062011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6607
6608 * fileio.c (Finsert_file_contents): Move after-change-function call
6609 to before the "handled:" label, since all "goto handled" appear in
6610 cases where the *-change-functions have already been properly called
6611 (bug#10117).
6612
3360a3fc
AS
66132011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6614
6615 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6616 waiting for input. (Bug#10169)
6617
73d6c093
EZ
66182011-11-30 Eli Zaretskii <eliz@gnu.org>
6619
6620 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6621 verifies glyph row's hash code--we have just reallocated the
6622 glyphs, so their contents can be complete garbage. (Bug#10164)
6623
febe6bea
JB
66242011-11-30 Juanma Barranquero <lekktu@gmail.com>
6625
6626 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6627
801a4313
EZ
66282011-11-30 Eli Zaretskii <eliz@gnu.org>
6629
6630 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6631 attributes are tested _before_ calling verify_row_hash, to protect
6632 against GCC re-ordering of the tests. (Bug#10164)
6633
2b56b87e
JD
66342011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6635
6636 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6637
6638 * xterm.c (handle_one_xevent): Only set async_visible and friends
6639 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6640 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6641 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6642
dbf31225
PE
66432011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6644
6645 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6646 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6647 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6648 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6649 All uses changed to use GCPRO1 etc.
6650 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6651 Revert to old implementation (i.e., before 2011-03-11).
6652
1305621b
YM
66532011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6654
6655 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6656 of scroll runs so as to avoid assigning disabled bogus rows and
6657 unnecessary graphics copy operations.
6658
8c9afb46
EZ
66592011-11-27 Eli Zaretskii <eliz@gnu.org>
6660
6661 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6662 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6663 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6664 (malloc, free, realloc, calloc): Redirect to e_* only when
6665 compiling Emacs.
6666
6667 * lisp.h (GCTYPEBITS): Move before first use.
6668 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6669 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6670 this macro definition.
6671
6672 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6673 _MSC_VER.
6674
54e9e3bf
JD
66752011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6676
6d5eb5b0
SM
6677 * gtkutil.c (xg_create_frame_widgets):
6678 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6679 present with Gtk+ 2.0.
6680
83aca1cb
PE
66812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6682
6683 * fileio.c (Finsert_file_contents): Undo previous change; see
6684 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6685
5b76caa4
PE
66862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6687
6688 Rename locals to avoid shadowing.
6689 * fileio.c (Finsert_file_contents):
6690 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6691 * process.c (wait_reading_process_output):
6692 Rename inner 'proc' to 'p' to avoid shadowing.
6693 Indent for consistency with usual Emacs style.
6694
8c535114
EZ
66952011-11-25 Eli Zaretskii <eliz@gnu.org>
6696
6697 * xdisp.c (redisplay_window): If cursor row is not fully visible
6698 after recentering, and scroll-conservatively is set to a large
6699 number, scroll window by a few more lines to make the cursor fully
6700 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6701 (start_display): Don't move to the next line if the display should
6702 start at a newline that is part of a display vector or an overlay
6703 string. (Bug#10119)
8c535114 6704
fa4fdb5c
JL
67052011-11-24 Juri Linkov <juri@jurta.org>
6706
6707 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6708 after the `MagickPingImage' call. (Bug#10112)
6709
90ec88df
CY
67102011-11-23 Chong Yidong <cyd@gnu.org>
6711
6712 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6713
56e2e794
MR
67142011-11-23 Martin Rudalics <rudalics@gmx.at>
6715
6716 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6717 making another buffer current. (Bug#10114)
6718
b6e64c41
GM
67192011-11-23 Glenn Morris <rgm@gnu.org>
6720
6721 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6722
6b21de18
CY
67232011-11-23 Chong Yidong <cyd@gnu.org>
6724
6725 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6726 using it (Bug#5984).
6727
b12cd789
EZ
67282011-11-22 Eli Zaretskii <eliz@gnu.org>
6729
6730 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6731 and header-lines, as they don't have one computed for them.
6732 (Bug#10098)
6733
6734 * .gdbinit (prow): Make displayed values more self-explaining.
6735 Add row's hash code.
6736
261b6fd4
LMI
67372011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6738
6739 * process.c (wait_reading_process_output): Fix asynchrounous
6740 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6741 (wait_reading_process_output): Add comment and URL.
261b6fd4 6742
e7cfd277
JD
67432011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6744
6745 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6746
a9b9b7f5
CY
67472011-11-21 Chong Yidong <cyd@gnu.org>
6748
6749 * window.c (Fnext_window, Fprevious_window): Doc fix.
6750
b0d15b4f
SM
67512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6752
6753 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6754
fe7a3057
JB
67552011-11-20 Juanma Barranquero <lekktu@gmail.com>
6756
6757 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6758
d2999b1a
MR
67592011-11-20 Martin Rudalics <rudalics@gmx.at>
6760
6761 * window.c (Fset_window_combination_limit): Rename argument
6762 STATUS to LIMIT.
6763 (Vwindow_combination_limit): Remove "status" from doc-string.
6764
d5ff9cd0
AS
67652011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6766
6767 * m/ibms390.h: Remove.
6768 * m/ibms390x.h: Don't include "ibms390.h".
6769
a5bb9bd3
SM
67702011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6771
6772 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6773 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6774
cd1181db
JB
67752011-11-20 Juanma Barranquero <lekktu@gmail.com>
6776
6777 * casetab.c (Fset_case_table):
6778 * charset.c (Fcharset_after): Fix typos.
6779
615a3b8d 67802011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6781
17e845af
PE
6782 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6783 Otherwise, valgrind does not work on some platforms.
6784 Problem reported by Andreas Schwab in
6a0bf43d
PE
6785 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6786 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6787 is set, removing the need for VIRT_ADDRESS_VARIES.
6788 (PURE_P): Use a more-efficient implementation that needs just one
6789 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6790 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6791 to 4 (xorl, subq, cmpq, setbe).
6792 * alloc.c (pure): Always extern now, since that's the
6793 VIRT_ADDR_VARIES behavior.
6794 (PURE_POINTER_P): Use a single comparison, not two, for
6795 consistency with the new puresize.h.
6796 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6797 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6798 Remove VIRT_ADDR_VARIES no longer needed.
6799
f8fe6f96
EZ
68002011-11-19 Eli Zaretskii <eliz@gnu.org>
6801
6802 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6803 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6804 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6805 behave as if the cursor position were at the window margin.
6806
6807 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6808 and the cursor position is out of bounds, behave as if the cursor
6809 position were at the window margin. (Bug#10075)
6810
df05a53c
CY
68112011-11-18 Chong Yidong <cyd@gnu.org>
6812
6813 * window.c (Fwindow_combination_limit): Make first argument
6814 non-optional, since it is meaningless for live windows like the
6815 selected window.
61ccba97 6816
2071918e
DA
68172011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6818
6819 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6820
b50a28de
SM
68212011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6822
6823 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6824 (graft_intervals_into_buffer): Simplify.
6825
015137db
EZ
68262011-11-18 Eli Zaretskii <eliz@gnu.org>
6827
6828 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6829 hash values of the two rows.
6830 (copy_row_except_pointers): Preserve the used[] arrays and the
6831 hash values of the two rows. (Bug#10035)
68c95424 6832 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6833
6834 * xdisp.c (row_hash): New function, body extracted from
6835 compute_line_metrics.
6836 (compute_line_metrics): Call row_hash, instead of computing the
6837 hash code inline.
6838
6839 * dispnew.c (verify_row_hash): Call row_hash for computing the
6840 hash code of a row, instead of duplicating code from xdisp.c.
6841
6842 * dispextern.h (row_hash): Add prototype.
6843
a2addb04
TH
68442011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6845
6846 * frame.c (delete_frame): Don't delete the terminal when the last
6847 X frame is closed if emacs is built with GTK toolkit.
6848
df85d315
JB
68492011-11-17 Juanma Barranquero <lekktu@gmail.com>
6850
6851 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6852
a0c2d0ae
MR
68532011-11-17 Martin Rudalics <rudalics@gmx.at>
6854
6855 * window.c (Vwindow_splits): Rename to
6856 Vwindow_combination_resize. Suggested by Juri Linkov.
6857 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6858 of Vwindow_splits.
6859
58179cce
JB
68602011-11-16 Juanma Barranquero <lekktu@gmail.com>
6861
7877f373
JB
6862 * nsfns.m (Fns_font_name):
6863 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6864
b6f67890
MR
68652011-11-16 Martin Rudalics <rudalics@gmx.at>
6866
6867 * window.h (window): Rename slot "nest" to "combination_limit".
6868 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6869 (Fset_window_nest): Rename to Fset_window_combination_limit.
6870 (Vwindow_nest): Rename to Vwindow_combination_limit.
6871 (recombine_windows, make_parent_window, make_window)
6872 (Fsplit_window_internal, saved_window)
6873 (Fset_window_configuration, save_window_save): Rename all
6874 occurrences of window_nest to window_combination_limit.
6875
c7015153
JB
68762011-11-15 Juanma Barranquero <lekktu@gmail.com>
6877
6878 * image.c (imagemagick_load_image): Fix typo.
6879
322ad6ec
EZ
68802011-11-14 Eli Zaretskii <eliz@gnu.org>
6881
6882 * xdisp.c (display_line): Move the call to
6883 highlight_trailing_whitespace before the call to
6884 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6885 faces of all the glyphs to compute ROW's hash value.
6886 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6887
f067b8ec
JB
68882011-11-14 Juanma Barranquero <lekktu@gmail.com>
6889
6890 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6891 just return (bug#10044).
6892
1e5b2111
EZ
68932011-11-12 Eli Zaretskii <eliz@gnu.org>
6894
7ef3cbd5
EZ
6895 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6896 with user-defined heap size. Bump the default size of the temacs
6897 heap to 27MB, to avoid memory warning when running temacs.
6898 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6899
1e5b2111
EZ
6900 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6901 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6902 (verify_row_hash) [XASSERTS]: New function.
6903 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6904 that the hash value of glyph rows is correct.
1e5b2111 6905
89d61221
MR
69062011-11-12 Martin Rudalics <rudalics@gmx.at>
6907
6908 * window.h (window): Remove splits slot.
6909 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6910 (Fdelete_other_windows_internal, make_parent_window)
6911 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6912 (Fset_window_configuration, save_window_save): Don't deal with
6913 split status of windows.
6914 (saved_window): Remove splits slot.
6915 (Vwindow_splits): Rewrite doc-string.
6916
97f18cc8
JD
69172011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6918
6919 * xfns.c (unwind_create_frame):
6920 * nsfns.m (unwind_create_frame):
6921 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6922 Vframe_list (Bug#9999).
6923
22a648b4
DA
69242011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6925
0b381c7e 6926 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6927
659afede
KH
69282011-11-11 Kenichi Handa <handa@m17n.org>
6929
6930 * callproc.c (Fcall_process): Set the member dst_multibyte of
6931 process_coding.
6932
9ac0394b
KH
69332011-11-11 Johan Bockgård <bojohan@gnu.org>
6934
6935 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6936 avoid a crash (bug#9496).
6937
2fbdc249
CY
69382011-11-09 Chong Yidong <cyd@gnu.org>
6939
6940 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6941 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6942
ac6b1f81
PE
69432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6944
6945 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6946
09db192c
PE
69472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6948
6949 Avoid some portability problems by eschewing 'extern inline' functions.
6950 The trivial performance wins aren't worth the portability hassles; see
6951 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6952 et seq.
6953 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6954 (window_box_width, window_box_left, window_box_left_offset)
6955 (window_box_right, window_box_right_offset): Undo previous change,
6956 by removing the "extern"s.
6957 * intervals.c (adjust_intervals_for_insertion)
6958 (adjust_intervals_for_deletion): Undo previous change,
6959 making these static again.
6960 (offset_intervals, temp_set_point_both, temp_set_point)
6961 (copy_intervals_to_string): No longer inline.
6962 * xdisp.c (window_text_bottom_y, window_box_width)
6963 (window_box_height, window_box_left_offset)
6964 (window_box_right_offset, window_box_left, window_box_right)
6965 (window_box): No longer inline.
6966
105216ed
CY
69672011-11-08 Chong Yidong <cyd@gnu.org>
6968
6969 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6970 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6971 Signal an error if not a live window.
105216ed
CY
6972 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6973 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6974
ae9e237f
JB
69752011-11-07 Juanma Barranquero <lekktu@gmail.com>
6976
6977 * lisp.h (syms_of_abbrev): Remove declaration.
6978 Reported by CHENG Gao <chenggao@royau.me>.
6979
c7aa8333
EZ
69802011-11-07 Eli Zaretskii <eliz@gnu.org>
6981
6982 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6983 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6984 of temacs in GUI mode.
6985
be7f5545
MR
69862011-11-07 Martin Rudalics <rudalics@gmx.at>
6987
6988 * window.h: Declare delete_all_child_windows instead of
6989 delete_all_subwindows.
6990 * window.c (Fwindow_nest, Fset_window_nest)
6991 (Fset_window_new_total, Fset_window_new_normal)
6992 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6993 (delete_all_subwindows): Rename to delete_all_child_windows.
6994 (Fdelete_other_windows_internal, Fset_window_configuration):
6995 Call delete_all_child_windows instead of delete_all_subwindows.
6996 * frame.c (delete_frame): Call delete_all_child_windows instead
6997 of delete_all_subwindows.
6998
ca78dc43
PE
69992011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7000
7001 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7002 This is also needed for porting to any host where GC_MARK_STACK is
7003 not GC_MAKE_GCPROS_NOOPS.
7004 (which_symbols): Use it.
7005
a0241d01
KH
70062011-11-07 Kenichi Handa <handa@m17n.org>
7007
7008 * coding.c (coding_set_destination): Check coding->src_pos only
7009 when coding->src_object is a buffer (bug#9910).
7010
7011 * process.c (send_process): Set the member src_multibyte of coding
7012 to 0 (bug#9911) when sending a unibyte text.
7013
7014 * callproc.c (Fcall_process): Set the member src_multibyte of
7015 process_coding to 0 (bug#9912).
7016
a64bfdfa 70172011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7018
7019 * xmenu.c (cleanup_widget_value_tree): New function.
7020 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7021 calling free_menubar_widget_value_tree directly (Bug#9830).
7022
cb41b32a
PE
70232011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7024
7025 Fix some portability problems with 'inline'.
7026 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7027 (window_box_width, window_box_left, window_box_left_offset)
7028 (window_box_right, window_box_right_offset): Declare extern.
7029 Otherwise, these inline functions do not conform to C99 and
7030 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7031 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7032 * intervals.c (adjust_intervals_for_insertion)
7033 (adjust_intervals_for_deletion): Now extern, because otherwise the
7034 extern inline functions 'offset_intervals' couldn't refer to it.
7035 (static_offset_intervals): Remove.
7036 (offset_intervals): Rewrite using the old contents of
7037 static_offset_intervals. The old version didn't conform to C99
7038 because an extern inline function contained a reference to an
7039 identifier with static linkage.
7040
b7041366
AS
70412011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7042
7043 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7044 GC.
7045
88a37c4d
EZ
70462011-11-06 Eli Zaretskii <eliz@gnu.org>
7047
7048 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7049 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7050 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7051 return Qleft_to_right.
7052
49745b39
CY
70532011-11-06 Chong Yidong <cyd@gnu.org>
7054
7055 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7056 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7057 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7058 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7059 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7060 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7061 (Fwindow_vscroll): Doc fix.
7062 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7063 argument, since it makes no sense to pass a live window and for
7064 consistency with window-child.
7065
1f05cd82
CS
70662011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7067
7068 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7069 support MSVC.
7070
22610910
JR
70712011-11-05 Jason Rumney <jasonr@gnu.org>
7072
7073 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7074 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7075 fonts (Bug#6029).
7076 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7077 bitwise arithmetic preventing use of unicode-sip and non-truetype
7078 opentype fonts.
7079
a06776b2
EZ
70802011-11-05 Eli Zaretskii <eliz@gnu.org>
7081
3ad924ba
EZ
7082 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7083 "emacs"-only part.
7084
a06776b2
EZ
7085 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7086 initialization code to keep similarity to xfns.c after changes
7087 from 2011-11-05.
7088
c9e7db78
JD
70892011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7090
a97f8f3f
JD
7091 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7092 (unwind_create_frame): New function (Bug#9943).
7093 (Fx_create_frame): Restructure code to be more similar to the one in
7094 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7095 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7096 Move terminal->reference_count++ just before making the frame official
7097 (Bug#9943).
7098
7099 * nsterm.m (x_free_frame_resources): New function.
7100 (x_destroy_window): Move code to x_free_frame_resources.
7101
c9e7db78 7102 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7103 (Fx_create_frame, x_create_tip_frame):
7104 Move terminal->reference_count++ just before making the frame
75f1671a 7105 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7106 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7107
a6fc3b5c
EZ
71082011-11-05 Eli Zaretskii <eliz@gnu.org>
7109
7110 Support MSVC build with newer versions of Visual Studio.
7111 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7112 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7113 nt/gmake.defs.
7114
7115 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7116 which are not supported by MSVC.
7117 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7118 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7119 bitfields.
7120 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7121 types in bitfields.
7122 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7123
7124 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7125
58179cce 71262011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7127
7128 Support MSVC build with newer versions of Visual Studio.
7129 * w32.c: Don't include w32api.h for MSVC.
7130 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7131
7132 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7133 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7134 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7135 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7136 e_* cousins.
7137 (alloca) [_MSC_VER]: Define to _alloca.
7138
7139 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7140
7141 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7142
a58c13ed
EZ
71432011-11-04 Eli Zaretskii <eliz@gnu.org>
7144
7145 * xdisp.c (note_mouse_highlight): If either of
7146 previous/next-single-property-change returns nil, treat that as
7147 the beginning or the end of the buffer. (Bug#9955)
7148
fe0b6370
JD
71492011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7150
a58c13ed 7151 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7152 label is not null (Bug#9951).
7153 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7154 may be NULL.
7155
89bd5ee1
EZ
71562011-11-04 Eli Zaretskii <eliz@gnu.org>
7157
7158 * window.c (Fwindow_body_size): Mention in the doc string that the
7159 return value is in frame's canonical units. (Bug#9949)
7160
84c3edb9
EZ
71612011-11-03 Eli Zaretskii <eliz@gnu.org>
7162
4e2fb5c7
EZ
7163 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7164
84c3edb9 7165 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7166 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7167 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7168
bc17a887
EZ
71692011-11-01 Eli Zaretskii <eliz@gnu.org>
7170
7171 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7172 Don't stop backward scan on the continuation glyph, even though
7173 its CHARPOS is positive.
6d5eb5b0
SM
7174 (mouse_face_from_buffer_pos, note_mouse_highlight):
7175 Rename cover_string to disp_string.
bc17a887 7176
4ee88440
MR
71772011-11-01 Martin Rudalics <rudalics@gmx.at>
7178
7179 * window.c (temp_output_buffer_show): Don't use
7180 Vtemp_buffer_show_specifiers.
7181 (Vtemp_buffer_show_specifiers): Remove unused variable.
7182
c2ff3c02
EZ
71832011-10-30 Eli Zaretskii <eliz@gnu.org>
7184
7185 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7186 past the beginning of the current glyph matrix.
7187
58179cce 71882011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7189
7190 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7191 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7192 HAVE_GTK3 (Bug#9869).
b77a6a7f 7193
3b574623
JD
7194 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7195 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7196
b77a6a7f
JD
7197 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7198
7199 * xterm.c: Declare x_handle_net_wm_state to return int.
7200 (handle_one_xevent): Check if we are iconified but don't have
7201 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7202 (get_current_wm_state): Return non-zero if not hidden,
7203 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7204 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7205 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7206 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7207
196e41e4
PE
72082011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7209
7210 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7211 so that this new function doesn't get optimized away by a
7212 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7213
021f2e1a
AS
72142011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7215
7216 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7217
8b058d44
EZ
72182011-10-29 Eli Zaretskii <eliz@gnu.org>
7219
7220 Fix the `xbytecode' command.
7221 * .gdbinit (xprintbytestr): New command.
b50a28de 7222 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7223 (xbytecode): Print the byte-code string as well.
7224
4452fb80
EZ
72252011-10-29 Kim Storm <storm@cua.dk>
7226
8b058d44
EZ
7227 * alloc.c (which_symbols): New function.
7228
21b72067
AS
72292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7230
7231 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7232 line. (Bug#9903)
7233
83ed7b5c
GM
72342011-10-29 Glenn Morris <rgm@gnu.org>
7235
7236 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7237 Not clear what it was for, and it causes various bugs. (Bug#9839)
7238
5a7a728b
EZ
72392011-10-28 Eli Zaretskii <eliz@gnu.org>
7240
7241 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7242 possible random value that matches one of those tested as
7243 condition to clear the mouse face.
7244
d3d0842f
CY
72452011-10-28 Chong Yidong <cyd@gnu.org>
7246
7247 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7248
31b39d13
DN
72492011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7250
7251 * window.c (make_window): Initialize phys_cursor_on_p.
7252
9aba6043
SM
72532011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7254
7255 * lisp.h (struct Lisp_Symbol): Update comments.
7256
c20992f4
JB
72572011-10-28 Juanma Barranquero <lekktu@gmail.com>
7258
7259 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7260
db4f02f2
EZ
72612011-10-28 Eli Zaretskii <eliz@gnu.org>
7262
7263 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7264 <oslsachem@gmail.com> for helping to debug this.
7265
7266 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7267 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7268 (g_b_init_get_glyph_outline_w): New static variables.
7269 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7270 (GetGlyphOutlineW_Proc): New typedefs.
7271 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7272 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7273 New functions.
7274 (w32font_open_internal, compute_metrics):
7275 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7276 instead of calling the "wide" APIs directly.
7277
7278 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7279
7280 * w32.h (syms_of_w32font): Add prototype.
7281
87e68db4
JB
72822011-10-27 Juanma Barranquero <lekktu@gmail.com>
7283
7284 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7285 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7286 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7287 (Fmove_to_window_line): Doc fix.
7288
435c1d67
CY
72892011-10-27 Chong Yidong <cyd@gnu.org>
7290
7291 * process.c (make_process): Set gnutls_state to NULL.
7292
7293 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7294 non-NULL, regardless of GNUTLS_INITSTAGE.
7295 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7296 an error. Set process slots as soon as we allocate them.
7297
7298 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7299
9c6c6f49
CY
73002011-10-27 Chong Yidong <cyd@gnu.org>
7301
9aba6043
SM
7302 * gnutls.c (emacs_gnutls_deinit): New function.
7303 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7304 (Fgnutls_deinit, Fgnutls_boot): Use it.
7305
7306 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7307 (deactivate_process): Call emacs_gnutls_deinit.
7308
657d08d3
JB
73092011-10-27 Juanma Barranquero <lekktu@gmail.com>
7310
7311 * image.c (x_create_x_image_and_pixmap):
7312 * w32.c (sys_rename, w32_delayed_load):
7313 * w32font.c (fill_in_logfont):
7314 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7315
5430d399
JB
73162011-10-26 Juanma Barranquero <lekktu@gmail.com>
7317
7318 * w32fns.c (w32_default_color_map): New function,
7319 extracted from Fw32_default_color_map.
a7ef684b 7320 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7321
fe0055fa
PE
73222011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7323
7324 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7325
e6346438
SM
73262011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7327
7328 * keyboard.c (test_undefined): New function (bug#9751).
7329 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7330
e112cc37
ET
73312011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7332
7333 * sysdep.c (init_sys_modes): Fix the check for the controlling
7334 terminal (Bug#6649).
7335
7b5d6677
EZ
73362011-10-20 Eli Zaretskii <eliz@gnu.org>
7337
7338 * dispextern.h (struct bidi_it): New member next_en_type.
7339
7340 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7341 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7342 current character, check also for next_en_type being WEAK_EN.
7343 (bidi_resolve_weak): Don't enter the expensive loop if the current
7344 position is before next_en_pos. Record the bidi type of the first
7345 non-ET, non-BN character we find, in addition to its position.
7346 (bidi_level_of_next_char): Invalidate next_en_type when
7347 next_en_pos is over-stepped.
7348
7da0b018
PE
73492011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7350
7351 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7352 * editfns.c: Rewrite current-time-zone so that it invokes
7353 the equivalent of (format-time-string "%Z") to get the time zone name.
7354 This fixes a bug when the time zone name contains characters that
7355 need converting from the system time locale to Emacs internal format.
7356 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7357 that patch fixed format-time-string to do the conversion, but
7358 I forgot to fix current-time-zone.
7359 (format_time_string): New function, containing most of
7360 what Fformat_time_string used to contain.
7361 (Fformat_time_string): Rewrite in terms of format_time_string.
7362 This doesn't change this function's behavior.
7363 (current-time-zone): Rewrite to use format_time_string.
7364 This fixes the bug reported by Michael Schierl in
7365 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7366 Jason Rumney's 2007-06-07 change worked around this bug, but
7367 didn't fix it.
7368 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7369
8547b010
EZ
73702011-10-19 Eli Zaretskii <eliz@gnu.org>
7371
7372 * xdisp.c (start_display): If the character at POS is displayed
7373 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7374 (try_window_reusing_current_matrix): If a line ends in a display
7375 vector or the next line starts in a display vector, continue
7376 redrawing the window even though the character position of
7377 start_row was reached.
8547b010
EZ
7378 (Bug#9771, part 2)
7379
4e948d15
CY
73802011-10-18 Chong Yidong <cyd@gnu.org>
7381
7382 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7383 with nobreak-char-display too.
7384
4787455f
EZ
73852011-10-18 Eli Zaretskii <eliz@gnu.org>
7386
7387 Fix part 3 of bug#9771.
7388 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7389 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7390 non-neutral characters if the current character is a paragraph
7391 separator (a.k.a. Newline). This avoids running the same
7392 expensive loop twice, once when we consume the preceding newline
7393 and the other time when the line actually needs to be displayed.
7394 Avoid the loop when we see neutrals on the base embedding level
7395 following a character whose directionality is the same as the
7396 paragraph's. This avoids running the expensive loop when a line
7397 ends in a long sequence of neutrals, like control characters.
7398 Add assertion against STRONG_AL type. Slightly rearrange code
7399 that determines the type of a neutral given the first non-neutral
7400 that follows it.
7401 (bidi_level_of_next_char): Set next_en_pos to zero when
7402 invalidating its info.
7403
2c91f553
EZ
74042011-10-17 Eli Zaretskii <eliz@gnu.org>
7405
7406 * xdisp.c (push_display_prop): Determine whether to record string
7407 or buffer position by IT->string, not by IT->method. Allow
7408 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7409 (move_it_vertically_backward): Don't look for character position
7410 immediately after the newline when in a continuation line.
7411 (Bug#9771, part 1)
2c91f553 7412
c7b08b0d
MR
74132011-10-15 Martin Rudalics <rudalics@gmx.at>
7414
7415 * window.c (coordinates_in_window): Rewrite and delabelize
7416 vertical border check. (Bug#5357) (Bug#9618)
7417
6b02f655
SM
74182011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7419
7420 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7421 errors in XSetWindowBorder (bug#9310).
7422
81d40c92
DA
74232011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7424
7425 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7426 avoid crash when xmalloc overrun checking is enabled.
7427
d4172c3b
EZ
74282011-10-13 Eli Zaretskii <eliz@gnu.org>
7429
7430 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7431 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7432 cursor motion with <left> and <right> arrow keys.
7433
7434 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7435 some callers set that themselves.
7436
b00eea75
EZ
74372011-10-12 Eli Zaretskii <eliz@gnu.org>
7438
7439 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7440 display string and the previous row comes from the same string and
7441 is empty. (Bug#9739) (Bug#9738)
7442
8fe012c4
SM
74432011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7444
7445 * doc.c (get_doc_string): Encode file name (bug#9735).
7446
0074aef2
EZ
74472011-10-12 Eli Zaretskii <eliz@gnu.org>
7448
79beb178
EZ
7449 * bidi.c (bidi_level_of_next_char):
7450 * xdisp.c (get_visually_first_element): Remove old incorrect
7451 comments regarding the Unicode Line Separator character.
7452
0074aef2
EZ
7453 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7454
6e4b3fbe
DA
74552011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7456
7457 * alloc.c (Fgc_status): Do not access beyond zombies array
7458 boundary if nzombies > MAX_ZOMBIES.
7459 * alloc.c (dump_zombies): Add missing format specifier.
7460
0324f3af
PE
74612011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7462
b5525cac
PE
7463 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7464 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7465
0324f3af
PE
7466 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7467 Some packages use them to denote characters with modifiers.
7468
e9b5f888
AS
74692011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7470
7471 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7472 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7473 matching a pp-number. Rename parameter var to var1.
7474
127827c0
SM
74752011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7476
7477 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7478
c8fd3bd0
GM
74792011-10-08 Glenn Morris <rgm@gnu.org>
7480
7481 * callint.c (Fcall_interactively): Give a more explicit error for the
7482 'c' case with a non-character input. (Bug#8479)
7483
352ec8ff
EZ
74842011-10-08 Eli Zaretskii <eliz@gnu.org>
7485
03669ccb
EZ
7486 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7487 lines.
7061c986
EZ
7488 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7489 lines that are hscrolled on the left.
03669ccb 7490
352ec8ff
EZ
7491 * dispnew.c (buffer_posn_from_coords): Account for a possible
7492 presence of header-line. (Bug#4426)
7493
a66cfb1c
SM
74942011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7495
6b02f655
SM
7496 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7497 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7498
7c5ee88e
PE
74992011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7500
7501 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7502 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7503 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7504 this makes Emacs dump core during garbage collection on rare
7505 occasions. sizeof is obviously inferior to offsetof here, so
7506 stick with offsetof.
7507 (GC_POINTER_ALIGNMENT): New macro.
7508 (mark_memory): Omit 3rd (offset) arg; caller changed.
7509 Don't assume EMACS_INT alignment is the same as pointer alignment.
7510
df1bbe5b
SM
75112011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7512
7513 * keyboard.c (read_key_sequence_remapped): New var.
7514 (read_key_sequence): Compute remapping in the right buffer.
7515 (command_loop_1): Use read_key_sequence's remapping directly.
7516
51553db6
SM
75172011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7518
32c1fffd
SM
7519 * dired.c (file_name_completion): Don't expand file name.
7520 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7521 before checking file name handler.
7522
51553db6
SM
7523 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7524 they've been requested explicitly (bug#9591).
7525
b6bd1599 75262011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7527
7528 * keymap.c (Fsingle_key_description): Use make_specified_string
7529 instead of build_string to build string from push_key_description.
7530 (Bug#5193)
7531
f701dc2a
PE
75322011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7533
4222c55d
PE
7534 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7535 This fixes a Y2038 bug on 64-bit hosts.
7536 * buffer.c (reset_buffer):
7537 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7538 (Fclear_buffer_auto_save_failure):
7539 Use 0, not -1, to represent an unset failure time, since time_t
7540 might not be signed.
7541
f701dc2a
PE
7542 Remove dependency on glibc malloc internals.
7543 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7544 Move back here from lisp.h, but with their new implementations.
7545 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7546 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7547 * charset.c (charset_table_init): New static var.
7548 (syms_of_charset): Use it instead of xmalloc. This removes a
7549 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7550 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7551 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7552 Move back to alloc.c.
7553 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7554 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7555
9ceebf39
JD
75562011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7557
7558 * nsterm.m (windowDidResize): Call x_set_window_size only when
7559 ns_in_resize is true. Otherwise set pixelwidth/height and
7560 call change_frame_size (Bug#9628).
7561
cb993c58
PE
75622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7563
3930c88b
PE
7564 Port --enable-checking=all to Fedora 14 x86-64.
7565 * charset.c (syms_of_charset): Also account for glibc malloc's
7566 internal overhead when calculating the initial malloc maximum.
7567
cb993c58
PE
7568 Port --enable-checking=all to Fedora 14 x86.
7569 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7570 Move to lisp.h.
7571 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7572 (overrun_check_realloc, overrun_check_free):
7573 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7574 That way, xmalloc returns a properly-aligned pointer even if
7575 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7576 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7577 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7578 into account when calculating the initial malloc maximum.
7579 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7580 Move here from alloc.c, so that charset.c can use it too.
7581 Properly align; the old code wasn't right for common 32-bit hosts
7582 when configured with --enable-checking=all.
7583 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7584 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7585
31bed486
EZ
75862011-09-29 Eli Zaretskii <eliz@gnu.org>
7587
04c70788 7588 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7589 use EDOM.
7590
fbcaa2f3
EZ
75912011-09-28 Eli Zaretskii <eliz@gnu.org>
7592
7593 * xdisp.c (compute_display_string_end): If there's no display
7594 string at CHARPOS, return -1.
7595
7596 * bidi.c (bidi_fetch_char): When compute_display_string_end
7597 returns a negative value, treat the character as a normal
7598 character not covered by a display string. (Bug#9624)
7599
a239d4e9
JB
76002011-09-28 Juanma Barranquero <lekktu@gmail.com>
7601
7602 * lread.c (Fread_from_string): Fix typo in docstring.
7603
88652fd5
EZ
76042011-09-27 Eli Zaretskii <eliz@gnu.org>
7605
7606 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7607 newline, reseat the iterator instead of bidi-iterating there one
7608 character at a time. (Bug#9610)
32c1fffd
SM
7609 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7610 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7611
ed497dd4
AS
76122011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7613
7614 * lread.c (readevalloop): Use correct code for NBSP.
7615 (read1): Likewise. (Bug#9608)
7616
b2bf61aa
MA
76172011-09-25 Michael Albinus <michael.albinus@gmx.de>
7618
7619 * dbusbind.c (Fdbus_register_signal): When service is not
7620 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7621
32bbb17c
GM
76222011-09-25 Glenn Morris <rgm@gnu.org>
7623
7624 * buffer.c (truncate-lines): Doc fix.
7625
94e0933e
CY
76262011-09-24 Chong Yidong <cyd@stupidchicken.com>
7627
7628 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7629 (Fset_window_next_buffers): Doc fix.
7630
cddde921
GM
76312011-09-24 Glenn Morris <rgm@gnu.org>
7632
7633 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7634
1260aef1
PE
76352011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7636
25b4bfa0
PE
7637 Fix minor problems found by static checking.
7638 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7639 * indent.c (Fvertical_motion): Fix == vs = typo.
7640
e3cbd34b
EZ
76412011-09-24 Eli Zaretskii <eliz@gnu.org>
7642
a66cfb1c
SM
7643 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7644 Default value is now t. Doc fix.
6bf7006f 7645
e3cbd34b 7646 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7647 logic when moving up, not only when moving down. Fix the
e3cbd34b 7648 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7649 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7650
7651 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7652 CHARPOS is covered by a display string which includes newlines.
7653 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7654 is covered by a display string with embedded newlines.
7655
a3de0cbd
MA
76562011-09-24 Michael Albinus <michael.albinus@gmx.de>
7657
7658 * dbusbind.c (Fdbus_register_signal): Add match rule to
7659 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7660 (Fdbus_register_method, Vdbus_registered_objects_table):
7661 Fix docstring.
a3de0cbd 7662
b260039d
JM
76632011-09-24 Jim Meyering <meyering@redhat.com>
7664
32c1fffd 7665 do not ignore write error for any output size
b260039d
JM
7666 The previous change was incomplete.
7667 While it makes emacs --batch detect the vast majority of stdout
7668 write failures, errors were still ignored whenever the output size is
7669 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7670 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7671 && echo FAIL: ignored write error
7672 FAIL: ignored write error
7673 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7674 && echo FAIL: ignored write error
7675 FAIL: ignored write error
7676 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7677
8eca8a7c
AS
76782011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7679
7680 * emacs.c (Fkill_emacs): In noninteractive mode exit
7681 non-successfully if a write error occurred on stdout. (Bug#9574)
7682
3341db62
EZ
76832011-09-21 Eli Zaretskii <eliz@gnu.org>
7684
7685 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7686 the xassert test.
7687
7688 * dispextern.h (struct it): Update the comment documenting what
7689 can it->OBJECT be.
7690
8c203dbf
EZ
76912011-09-20 Eli Zaretskii <eliz@gnu.org>
7692
7693 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7694 a display string, extend search for cursor position to end of row.
7695 (find_row_edges): If the row ends in a newline from a display
7696 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7697 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7698 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7699 non-empty line. Fixes confusing cursor motion with arrow keys at
7700 the beginning of a line that starts with whitespace.
8c203dbf 7701
a4824228
LMI
77022011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7703
7704 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7705 (bug#9493).
7706
33ed493b
CY
77072011-09-18 Chong Yidong <cyd@stupidchicken.com>
7708
7709 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7710 boolean (Bug#9154).
7711
56cd55c8
EZ
77122011-09-18 Eli Zaretskii <eliz@gnu.org>
7713
7714 * xdisp.c (display_line): Record maximum and minimum buffer
7715 positions even if no glyphs were produced (e.g., by a zero-width
7716 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7717 buffer positions that will be removed from the glyph row because
7718 they don't fit.
c02dcedf
EZ
7719 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7720 column is beyond frame width: don't subtract 1 "pixel" when
7721 computing width of the stretch.
3e62b7e0
EZ
7722 (reseat_at_next_visible_line_start): Undo the change made on
7723 2011-09-17 that saved paragraph information and restored it after
7724 the call to `reseat'. (Bug#9545)
56cd55c8 7725
5ed99d36 77262011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7727
7728 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7729 and turn window cursor on if cleared (Bug#9415).
7730
5ed99d36 77312011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7732
7733 * search.c (boyer_moore): Take unibyte characters from pattern
7734 literally. (Bug#9458)
7735
9bade7b2
EZ
77362011-09-18 Eli Zaretskii <eliz@gnu.org>
7737
7738 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7739
e5e9d610
PE
77402011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7741
87e4427a
PE
7742 Fix minor problem found by static checking.
7743 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7744 initialized, to pacify gcc -Wuninitialized.
7745
e5e9d610
PE
7746 * fileio.c: Report proper errno when syscall falls.
7747 (Finsert_file_contents): Save and restore errno,
7748 so that report_file_error outputs the correct diagnostic.
7749 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7750
a1674f0b
EZ
77512011-09-18 Eli Zaretskii <eliz@gnu.org>
7752
7753 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7754
fbfb6dd4
EZ
77552011-09-17 Eli Zaretskii <eliz@gnu.org>
7756
7757 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7758 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7759
bb187662
EZ
77602011-09-17 Eli Zaretskii <eliz@gnu.org>
7761
1137e8b8 7762 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7763 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7764
7765 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7766 (bidi_find_paragraph_start): Search back for paragraph beginning
7767 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7768 (bidi_move_to_visually_next): Only trigger paragraph-related
7769 computations when the last character is a newline or at EOB, not
7770 just any NEUTRAL_B. (Bug#9470)
7771
bb187662
EZ
7772 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7773 truncated lines if point is covered by a display string. (Bug#9524)
7774
2e621251
PE
77752011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7776
7777 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7778 (cons_to_x_long): New function.
7779 (lisp_data_to_selection_data): Use it. Correct the test for
7780 short-versus-long data; it was negated. Break out of vector
7781 loop, for efficiency, when a long datum is discovered.
7782
91a15bc6
SM
77832011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7784
7785 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7786
b41c3a35
EZ
77872011-09-16 Eli Zaretskii <eliz@gnu.org>
7788
7789 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7790 GCC PR/17406) by declaring this function with external scope.
7791
7812ba2d
PE
77922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7793
7794 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7795 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7796
cf7edc2a
AS
77972011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7798
7799 * editfns.c (Fformat): Correctly handle text properties on "%%".
7800
bd01620e
EZ
78012011-09-15 Eli Zaretskii <eliz@gnu.org>
7802
7803 * xterm.c (x_draw_composite_glyph_string_foreground):
7804 * w32term.c (x_draw_composite_glyph_string_foreground):
7805 * term.c (encode_terminal_code):
7806 * composite.c (composition_update_it, get_composition_id):
7807 * xdisp.c (get_next_display_element)
7808 (fill_composite_glyph_string): Add comments about special meaning
7809 of TAB characters in a composition.
7810
a02719a3
PE
78112011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7812
7813 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7814 This occurs when processing a multibyte format.
7815 Problem reported by Wolfgang Jenker.
a02719a3 7816
72589a3c
JB
78172011-09-15 Johan Bockgård <bojohan@gnu.org>
7818
7819 * xdisp.c (try_cursor_movement): Only check for exact match if
7820 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7821
1c14176c
PE
78222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7823
7824 Remove unused external symbols.
7825 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7826 * xdisp.c (calc_pixel_width_or_height): Now static.
7827 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7828 * indent.c (check_display_width):
7829 * w32term.c: Fix comment to match code.
7830 * xterm.c, xterm.h (x_catching_errors): Remove.
7831
d2eea5b5
PE
78322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7833
7834 * xselect.c: Use signed conversions more consistently (Bug#9498).
7835 (selection_data_to_lisp_data): Assume incoming selection data are
7836 signed integers, not unsigned. This is to be consistent with
7837 outgoing selection data, which was modified to use signed integers
7838 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7839 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7840 expects long, not unsigned long.
7841
46888499
EZ
78422011-09-14 Eli Zaretskii <eliz@gnu.org>
7843
7844 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7845 computation of loop end. Reported by Johan Bockgård
7846 <bojohan@gnu.org>.
7847
ef8ef9fb
CY
78482011-09-13 Chong Yidong <cyd@stupidchicken.com>
7849
7850 * frame.c (Fother_visible_frames_p): Function deleted.
7851
fa819fed
EZ
78522011-09-12 Eli Zaretskii <eliz@gnu.org>
7853
7854 * indent.c (compute_motion): Process display vector front to back
7855 rather than the other way around. (Bug#2496)
7856
2ba8e008
SM
78572011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7858
7859 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7860
20f53c69
CY
78612011-09-11 Chong Yidong <cyd@stupidchicken.com>
7862
7863 * minibuf.c (Fread_from_minibuffer): Doc fix.
7864
d562d7a4
EZ
78652011-09-11 Eli Zaretskii <eliz@gnu.org>
7866
7867 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7868 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7869
1c4d7f3d
LMI
78702011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7871
7872 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7873 value for non-existent files.
7874
b885bf36
EZ
78752011-09-11 Eli Zaretskii <eliz@gnu.org>
7876
7877 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7878 set its "size" to -1. This will set the modtime_size field of
7879 the corresponding buffer to -1, which is what
7880 verify-visited-file-modtime expects for files that do not exist.
7881 (Bug#9139)
7882
6612f0bf
PE
78832011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7884
7885 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7886 here ...
7887 * lisp.h: ... from here. push_key_description is no longer
7888 defined in keyboard.c, so its declaration should not be in
7889 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7890 logically belongs with push_key_description.
7891
dfb3f755
PE
78922011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7893
7894 * buffer.h: Include <sys/types.h> instead of <time.h>.
7895 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7896 Problem reported by Herbert J. Skuhra.
7897
3134906c
LMI
78982011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7899
7900 * xml.c (parse_region): Make the parsing work for
7901 non-comment-starting XML files again (bug#9144).
7902
8d903f4e
AS
79032011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7904
7905 * image.c (gif_load): Fix calculation of bottom and right corner.
7906 (Bug#9468)
7907
80ad64f4
EZ
79082011-09-10 Eli Zaretskii <eliz@gnu.org>
7909
7910 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7911 redisplay in small windows.
7912
208a048d
EZ
79132011-09-09 Eli Zaretskii <eliz@gnu.org>
7914
7915 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7916
9b1c252e
MR
79172011-09-08 Martin Rudalics <rudalics@gmx.at>
7918
7919 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7920 Operate on live windows only.
7921
2949f33b
JB
79222011-09-08 Juanma Barranquero <lekktu@gmail.com>
7923
7924 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7925
e08dcafd
EZ
79262011-09-07 Eli Zaretskii <eliz@gnu.org>
7927
7928 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7929 only under bidi iteration.
7930
115b96bd
JD
79312011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7932
7933 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7934
c8199d0f
PE
79352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7936
7937 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7938 Without this fix, the command to link temacs failed due to an
7939 undefined symbol __builtin_isnan. This is because
7940 /usr/include/iso/math_c99.h #defines isnan(x) to
7941 __builtin_isnan(x), but the bundled gcc, which identifies itself
7942 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7943 a __builtin_isnan.
7944 * floatfns.c (isnan): #undef, and then #define to a clone of
7945 what's in data.c.
7946 (Fisnan): Always define, since it's always available now.
7947 (syms_of_floatfns): Always define isnan at the Lisp level.
7948
e39b275c 79492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7950
7951 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7952
b2db44d9 79532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7954
f4af5137 7955 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7956 The previous code assumed that file offsets (off_t values) fit in
7957 EMACS_INT variables, which is not true on typical 32-bit hosts.
7958 The code messed up by falsely reporting buffer overflow in cases
7959 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7960 when "big" contains more than 2**29 bytes, even though this
7961 inserts just one byte and does not overflow the buffer.
7962 (Finsert_file_contents): Store file offsets as off_t
7963 values, not as EMACS_INT values. Check for overflow when
7964 converting between EMACS_INT and off_t. When checking for
7965 buffer overflow or for overlap, take the offsets into account.
7966 Don't use EMACS_INT for small values where int suffices.
7967 When checking for overlap, fix a typo: ZV was used where
7968 ZV_BYTE was intended.
7969 (Fwrite_region): Don't assume off_t fits into 'long'.
7970 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7971
ecfc0a49
MA
79722011-09-05 Michael Albinus <michael.albinus@gmx.de>
7973
7974 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7975
6511acf2 79762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7977
0999621a 7978 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7979
7980 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7981 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7982 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7983 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7984 (modify_event_symbol): Do not assume that the length of
7985 name_alist_or_stem is safe to alloca and fits in int.
7986 (Fexecute_extended_command): Likewise for function name and binding.
7987 (Frecursion_depth): Wrap around reliably on integer overflow.
7988 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7989 since some callers pass EMACS_INT values.
7990 (Fsingle_key_description): Don't crash if symbol name contains more
7991 than MAX_ALLOCA bytes.
7992 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7993 (get_minibuffer): Arg is now EMACS_INT, not int.
7994 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7995 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7996 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7997
2be7d702
PE
7998 * dbusbind.c (signature_cat): New function.
7999 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8000 Do not overrun buffer; instead, report string overflow.
8001
9d1df220
PE
8002 * dispnew.c (add_window_display_history): Don't overrun buffer.
8003 Truncate instead; this is OK since it's just a log.
8004
33ef5c64
PE
8005 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8006 even if the time zone offset is outlandishly large.
8007 Don't mishandle offset == INT_MIN.
8008
66c6fdd5
PE
8009 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8010 when creating daemon; the previous buffer-overflow check was incorrect.
8011
d749b01b
PE
8012 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8013 which has the guts of the old verror function.
8014
b5cd1905
PE
8015 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8016 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8017
6e1a67fb
PE
8018 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8019 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8020 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8021 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8022 length of string rather than counting it via multiple sprintfs;
8023 that's simpler and more reliable.
c21721cc
PE
8024 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8025 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8026 sprintf, in case result does not fit in int.
8027
c57b67fc
PE
8028 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8029 (fontset_from_font): Print it.
8030
8a401434
PE
8031 * frame.c (tty_frame_count): Now printmax_t, not int.
8032 (make_terminal_frame, set_term_frame_name): Print it.
8033 (x_report_frame_params): In X, window IDs are unsigned long,
8034 not signed long, so print them as unsigned.
8035 (validate_x_resource_name): Check for implausibly long names,
8036 and don't assume name length fits in 'int'.
8037 (x_get_resource_string): Don't blindly alloca invocation name;
8038 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8039 not fit in int.
8040
6e1a67fb
PE
8041 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8042 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8043 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8044
0df02bf3
PE
8045 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8046 Use esprintf, not sprintf, in case result does not fit in int.
8047
48e30793
PE
8048 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8049 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8050 it as a large positive number.
8051 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8052 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8053
a66ff6d8
PE
8054 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8055 in case result does not fit in int.
8056
aca216ff
PE
8057 * print.c (float_to_string): Detect width overflow more reliably.
8058 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8059 buffer overrun. Don't assume list length fits in 'int'. Treat
8060 print length of 0 as 0, not as infinity; to be consistent with other
8061 uses of print length in this function. Don't overflow print length
8062 index. Don't assume hash table size fits in 'long', or that
8063 vectorlike size fits in 'unsigned long'.
8064
31c286f7
PE
8065 * process.c (make_process): Use printmax_t, not int, to format
8066 process-name gensyms.
8067
55e5faa1
PE
8068 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8069
80f2e268
PE
8070 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8071 to avoid potential buffer overrun.
8072
670741ab
PE
8073 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8074 if X resource line is longer than 512 bytes.
8075
b7163a50
PE
8076 * xfns.c (x_window): Make sprintf buffer a bit bigger
8077 to avoid potential buffer overrun.
8078
ae58ff1f
PE
8079 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8080
c43c8a6a
PE
8081 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8082
3f8236f4
PE
80832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8084
53e9fe90 8085 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8086 Without these, Emacs silently mishandles large integers sometimes.
8087 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8088 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8089
6511acf2
PE
8090 * xdisp.c (try_window_id): Check Emacs fixnum range before
8091 converting to 'int'.
806add1d 8092
6511acf2 8093 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8094 Check that an Emacs fixnum is in range before assigning it to 'int'.
8095 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8096 values converted from Emacs fixnums.
8097 (Frecenter): Don't wrap around a line count if it is out of 'int'
8098 range; instead, treat it as an extreme value.
8099 (Fset_window_configuration, compare_window_configurations):
8100 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8101
6511acf2
PE
8102 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8103 that can exceed INT_MAX. Check that EMACS_INT value is in range
8104 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8105 (match_limit): Don't assume that a fixnum can fit in 'int'.
8106
6511acf2 8107 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8108 exceed INT_MAX.
8109
6511acf2 8110 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8111 (Fvertical_motion): Don't wrap around LINES values that don't fit
8112 in 'int'. Instead, treat them as extreme values. This is good
8113 enough for windows, which can't have more than INT_MAX lines anyway.
8114
fcb901a7
LMI
81152011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8116
0f2f6b6d
LMI
8117 * Require libxml/parser.h to avoid compilation warning.
8118
fcb901a7
LMI
8119 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8120
8121 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8122 since this reportedly can destroy thread storage.
8123
6e20a0d4
CY
81242011-08-30 Chong Yidong <cyd@stupidchicken.com>
8125
8126 * syntax.c (find_defun_start): Update all cache variables if
8127 exiting early (Bug#9401).
8128
148ae00e
EZ
81292011-08-30 Eli Zaretskii <eliz@gnu.org>
8130
f6cfbd8f
EZ
8131 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8132
148ae00e
EZ
8133 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8134 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8135 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8136
8137 * term.c (tty_append_glyph): New function.
8138 (produce_stretch_glyph): Static function and its prototype deleted.
8139
a66cfb1c
SM
8140 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8141 Add prototypes.
148ae00e 8142
c4a07a4c
PE
81432011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8144
8145 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8146 when checking :margin (Bug#9390).
8147 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8148 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8149 so that the name doesn't mislead. All uses changed.
8150
6bc8cd65
JB
81512011-08-28 Johan Bockgård <bojohan@gnu.org>
8152
8153 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8154 set_tty_hooks.
8155
dca4927e
EZ
81562011-08-27 Eli Zaretskii <eliz@gnu.org>
8157
8158 * xdisp.c (move_it_to): Don't bail out early when reaching
8159 position beyond to_charpos, if we are scanning backwards.
8160 (move_it_vertically_backward): When DY == 0, make sure we get to
8161 the first character in the line after the newline.
8162
f2cad773
PE
81632011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8164
8165 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8166 (ccl_driver): Do not generate an out-of-range pointer.
8167 (Fccl_execute_on_string): Remove unnecessary check for
8168 integer overflow, noted by Stefan Monnier in
8169 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8170 Remove a FIXME that didn't need fixing.
8171 Simplify the newly-introduced buffer reallocation code.
8172
0cae2cdb
JB
81732011-08-27 Juanma Barranquero <lekktu@gmail.com>
8174
8175 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8176
5fc295a4 81772011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8178
70c60eb2 8179 Integer and memory overflow issues (Bug#9196).
726e0ab1 8180
d31850da
PE
8181 * doc.c (get_doc_string): Rework so that
8182 get_doc_string_buffer_size is the actual buffer size, rather than
8183 being 1 less than the actual buffer size; this makes xpalloc more
8184 convenient.
8185
a69fbedb
PE
8186 * image.c (x_allocate_bitmap_record, cache_image):
8187 * xselect.c (Fx_register_dnd_atom):
8188 Simplify previous changes by using xpalloc.
8189
fe5c5d37
PE
8190 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8191 since either will do and ptrdiff_t is convenient with xpalloc.
8192
0065d054
PE
8193 * charset.c (charset_table_size)
8194 (struct charset_sort_data.priority): Now ptrdiff_t.
8195 (charset_compare): Don't overflow if priorities differ greatly.
8196 (Fsort_charsets): Don't assume list length fits in int.
8197 Check for size-calculation overflow when allocating sort data.
8198 (syms_of_charset): Allocate an initial charset table that is
8199 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8200
8201 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8202
8203 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8204 The actual value is always <= INT_MAX, and leaving it unsigned made
8205 overflow checking harder.
8206
8207 * dispextern.h (struct glyph_matrix.rows_allocated)
8208 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8209 with xpalloc. The values are still always <= INT_MAX.
8210
8211 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8212
8213 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8214 (SAFE_NALLOCA): New macro.
8215
8216 * region-cache.c (struct boundary.pos, find_cache_boundary)
8217 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8218 (set_cache_region, invalidate_region_cache)
8219 (revalidate_region_cache, know_region_cache, region_cache_forward)
8220 (region_cache_backward, pp_cache):
8221 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8222 so that ptrdiff_t * can be passed to xpalloc.
8223 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8224 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8225 (pp_cache): Don't assume cache_len fits in int.
8226 * region-cache.h: Adjust extern decls to match.
8227
8228 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8229 EMACS_INT, since either will do, for xpalloc.
8230
8231 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8232 (xnmalloc, xnrealloc, xpalloc): New functions.
8233
726e0ab1
PE
8234 * bidi.c (bidi_shelve_header_size): New constant.
8235 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8236 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8237
51f30bc5 8238 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8239 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8240 (overlay_strings):
8241 Don't update size of array until after memory allocation succeeds,
8242 because xmalloc/xrealloc may not return.
0065d054
PE
8243 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8244 now that we have proper integer overflow checking.
8245 (record_overlay_string, overlay_strings): Catch overflows when
8246 calculating size of overlay_str_buf.
726e0ab1 8247
0065d054
PE
8248 * callproc.c (Fcall_process): Check for size overflow when
8249 calculating size of args2.
8250 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8251 Normally we prefer signed values, but sticking with ptrdiff_t would
8252 require adding more-complicated checks.
726e0ab1
PE
8253
8254 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8255 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8256 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8257 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8258
8259 * character.c (Fstring): Check for size-calculation overflow.
8260
8261 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8262 unnecessary integer overflow. Check for size overflow.
8263 (encode_coding_object): Don't update size until xmalloc succeeds.
8264
8265 * composite.c (get_composition_id): Check for overflow in glyph
8266 length calculations.
8267
8268 Integer and memory overflow fixes for display code.
8269 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8270 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8271 (scrolling_window): Check for overflow in size calculations.
8272 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8273 Don't assume glyph table len fits in int.
8274 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8275 (row_table_size): Now ptrdiff_t, not int.
8276 (scrolling_window): Avoid overflow in size calculations.
8277 Don't update size until allocation succeeds.
8278 * fns.c (concat): Check for overflow in size calculations.
8279 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8280 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8281 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8282
8283 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8284 (get_doc_string): Check for size calculation overflow.
8285 Don't update size until allocation succeeds.
8286 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8287 EMACS_INT, where ptrdiff_t will do.
8288 (Fsubstitute_command_keys): Check for string overflow.
8289
8290 * editfns.c (set_time_zone_rule): Don't assume environment length
8291 fits in int.
8292 (message_length): Now ptrdiff_t, not int.
8293 (Fmessage_box): Don't update size until allocation succeeds.
8294 Don't assume message length fits in int.
8295 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8296
0065d054
PE
8297 * emacs.c (main): Do not reallocate argv, since there is a null at
8298 the end that can be overwritten, and this way there's no need to
8299 worry about size-calculation overflow.
8300 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8301
8302 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8303 alloc succeeds.
8304 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8305
8306 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8307 (x_set_scroll_bar_width, x_figure_window_size):
8308 Check for integer overflow.
8309 (x_set_alpha): Do not assume XINT fits in int.
8310
8311 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8312 This is for the members text_lines, text_cols, total_lines, total_cols,
8313 where the system imposes an 'int' limit.
8314
8315 * fringe.c (Fdefine_fringe_bitmap):
8316 Don't update size until alloc works.
8317
8318 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8319 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8320
8321 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8322 Check for size-calculation overflow.
8323 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8324 do, as we prefer signed integers.
8325 (id_to_widget.max_size, id_to_widget.used)
8326 (xg_store_widget_in_map, xg_remove_widget_from_map)
8327 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8328 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8329 Use and return ptrdiff_t, not int.
8330 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8331 * gtkutil.h: Change prototypes to match the above.
8332
8333 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8334 are duplicate now that they've been promoted to lisp.h.
8335 (x_allocate_bitmap_record, x_alloc_image_color)
8336 (make_image_cache, cache_image, xpm_load):
8337 Don't update size until alloc is done.
8338 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8339 (x_detect_edges):
3256efce 8340 Check for size calculation overflow.
726e0ab1
PE
8341 (ct_colors_allocated_max): New constant.
8342 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8343 overflow.
3256efce 8344
726e0ab1
PE
8345 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8346 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8347 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8348 Use ptrdiff_t, not int, to count maps.
8349 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8350 calculations. Don't update size until allocation succeeds.
8351 Redo calculations to avoid overflow.
726e0ab1
PE
8352 * keyboard.h: Change prototypes to match the above.
8353
8354 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8355 to count maps.
8356 (current_minor_maps): Check for size calculation overflow.
8357 * keymap.h: Change prototypes to match the above.
8358
8359 * lread.c (read1, init_obarray): Don't update size until alloc done.
8360
8361 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8362 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8363
726e0ab1
PE
8364 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8365 Now ptrdiff_t, not int.
8366 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8367 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8368
8369 * process.c (Fnetwork_interface_list): Check for overflow
8370 in size calculation.
8371
8372 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8373
8374 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8375 overflow. Don't bother calling xmalloc when xrealloc will do.
8376
8377 * search.c (Freplace_match): Check for size calculation overflow.
8378 (Fset_match_data): Don't assume list lengths fit in 'int'.
8379
8380 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8381 for command line length. Do not attempt to address one before the
8382 beginning of an array, as that's not portable.
8383
8384 * term.c (max_frame_lines): Remove; unused.
8385 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8386 not int.
8387 (encode_terminal_code, calculate_costs): Check for size
8388 calculation overflow.
8389 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8390 table lengths and related sizes. Don't update size until alloc
8391 done. Redo calculations to avoid overflow.
8392 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8393
8394 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8395 subtracting pointers.
8396 (gobble_line): Check for overflow more carefully. Don't update size
8397 until alloc done.
8398
8399 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8400 Don't update size until alloc done.
8401 Redo size calculations to avoid overflow.
8402 Check for size calculation overflow.
0065d054 8403 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8404
8405 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8406 Use ptrdiff_t, not int, for sizes.
8407 (store_mode_line_noprop_char): Don't update size until alloc done.
8408
0065d054
PE
8409 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8410 Use ptrdiff_t, not int, for sizes.
8411 (Finternal_make_lisp_face, cache_face):
8412 Check for size calculation overflow.
8413 (cache_face): Treat size calculation overflows as if they were
8414 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8415
8416 * xfns.c (x_encode_text, x_set_name_internal)
8417 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8418 sizes, since they can exceed INT_MAX in size. Check for size
8419 calculation overflow.
8420
0065d054
PE
8421 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8422 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8423 Don't update size until alloc done.
8424
0065d054 8425 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8426 as sprintf is limited to int lengths.
1d526e2f 8427
252c5ee1
PE
8428 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8429 (X_LONG_MIN): New macros.
864d7ce7
PE
8430 Use them to make the following changes clearer.
8431 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8432 This change doesn't affect the value now, but it may help remind
8433 future maintainers not to raise the value too much later.
8434 (SELECTION_QUANTUM): Remove, replacing with ...
8435 (selection_quantum): ... new function, which avoids overflow.
8436 All uses changed.
8437 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8438 assumption that selection length fits in 'int'.
8439 (x_reply_selection_request, x_handle_selection_request)
8440 (x_get_window_property, receive_incremental_selection)
8441 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8442 (lisp_data_to_selection_data, clean_local_selection_data):
8443 Use ptrdiff_t, not int, to record length of selection.
8444 (x_reply_selection_request, x_get_window_property)
8445 (receive_incremental_selection, x_property_data_to_lisp):
8446 Redo calculations to avoid overflow.
8447 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8448 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8449 something.
8450 (x_get_window_property, receive_incremental_selection)
8451 (lisp_data_to_selection_data, x_property_data_to_lisp):
8452 Check for size-calculation overflow.
8453 (x_get_window_property, receive_incremental_selection)
8454 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8455 Don't store size until memory allocation succeeds.
8456 (x_get_window_property): Plug memory leak on memory exhaustion.
8457 Don't double-block input; malloc is safe here. Don't assume 2**34
8458 - 4 fits in unsigned long. Add an xassert to check
8459 XGetWindowProperty overflow. Be more careful about overflow
8460 calculations, and distinguish size from memory overflow better.
8461 (receive_incremental_selection): When tracing, don't assume
8462 unsigned int is less than INT_MAX.
8463 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8464 harmful) conversions of unsigned short to int.
8465 (lisp_data_to_selection_data): Don't assume that integers
8466 in the range -65535 through -1 fit in an X unsigned short.
8467 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8468 result parameters unless successful. Rely on cons_to_unsigned
8469 to report problems with elements; the old code wasn't right anyway.
8470 (x_check_property_data): Check for int overflow; we cannot use
8471 a wider type due to X limits.
8472 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8473
726e0ab1 8474 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8475
0065d054
PE
8476 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8477 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8478 (x_color_cells): Don't store size until memory allocation succeeds.
8479 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8480 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8481 (x_term_init): Don't assume length fits in int (sprintf is limited
8482 to int size).
bc18e09d 8483
ebfa62c0
PE
8484 Use ptrdiff_t for composition IDs.
8485 * character.c (lisp_string_width):
8486 * composite.c (composition_table_size, n_compositions)
8487 (get_composition_id, composition_gstring_from_id):
8488 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8489 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8490 * window.c (Frecenter):
8491 Use ptrdiff_t, not int, for composition IDs.
8492 * composite.c (get_composition_id): Check for integer overflow.
8493 * composite.h: Adjust prototypes to match the above changes.
8494
d3411f89
PE
8495 Use ptrdiff_t for hash table indexes.
8496 * category.c (hash_get_category_set):
8497 * ccl.c (ccl_driver):
8498 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8499 * coding.c (coding_system_charset_list, detect_coding_system):
8500 * coding.h (struct coding_system.id):
8501 * composite.c (get_composition_id, gstring_lookup_cache):
8502 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8503 * image.c (xpm_get_color_table_h):
8504 * lisp.h (hash_lookup, hash_put):
8505 * minibuf.c (Ftest_completion):
8506 Use ptrdiff_t for hash table indexes, not int (which is too
8507 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8508 32-bit --with-wide-int hosts).
8509
e097a6fa
PE
8510 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8511 Add a FIXME comment about memory leaks.
8512 (syms_of_charset): Don't assume xmalloc returns.
8513
5637687f
PE
8514 Don't assume that stated character widths fit in int.
8515 * character.c (Fchar_width, c_string_width, lisp_string_width):
8516 * character.h (CHAR_WIDTH):
8517 * indent.c (MULTIBYTE_BYTES_WIDTH):
8518 Use sanitize_char_width to avoid undefined and/or bad behavior
8519 with outlandish widths.
a66cfb1c 8520 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8521 now that we have two such functions. All uses changed.
8522 (sanitize_char_width): New inline function.
8523
a2271ba2
PE
8524 Don't assume that tab-width fits in int.
8525 * character.h (sanitize_width): New inline function.
8526 (SANE_TAB_WIDTH): New macro.
8527 (ASCII_CHAR_WIDTH): Use it.
8528 * indent.c (sane_tab_width): Remove. All uses replaced by
8529 SANE_TAB_WIDTH (current_buffer).
8530 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8531
18c52557
PE
8532 * fileio.c: Integer overflow issues with file modes.
8533 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8534
caeeedc1
PE
8535 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8536 Remove unreachable code.
8537 (read_hex, load_charset_map_from_file): Check for integer overflow.
8538
6df6ae42 8539 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8540 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8541 (x_send_scroll_bar_event): Likewise. Check that the size does not
8542 exceed limits imposed by XClientMessageEvent, as well as the usual
8543 ptrdiff_t and size_t limits.
8544
b13995db
PE
8545 * keyboard.c: Overflow, signedness and related fixes.
8546 (make_lispy_movement): Use same integer type in forward decl
8547 that is used in the definition.
8548 (read_key_sequence, keyremap_step):
8549 Change bufsize argument back to int, undoing my 2011-03-30 change.
8550 We prefer signed types, and int is wide enough here.
8551 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8552 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8553 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8554 length, not size_t. Use ptrdiff_t for index, not int.
8555 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8556 possibility of integer overflow.
8557
13464394
PE
8558 Overflow, signedness and related fixes for images.
8559
8560 * dispextern.h (struct it.stack[0].u.image.image_id)
8561 (struct_it.image_id, struct image.id, struct image_cache.size)
8562 (struct image_cache.used, struct image_cache.ref_count):
8563 * gtkutil.c (update_frame_tool_bar):
8564 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8565 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8566 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8567 * nsmenu.m (update_frame_tool_bar):
8568 * xdisp.c (calc_pixel_width_or_height):
8569 * xfns.c (image_cache_refcount):
8570 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8571 on typical 64-bit hosts.
8572
8573 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8574 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8575 Omit unnecessary casts to int.
8576 (parse_image_spec): Check that integers fall into 'int' range
8577 when the callers expect that.
8578 (image_ascent): Redo ascent calculation to avoid int overflow.
8579 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8580 (lookup_image): Remove unnecessary tests.
8581 (xbm_image_p): Locals are now of int, not EMACS_INT,
8582 since parse_image_check makes sure they fit into int.
8583 (png_load, gif_load, svg_load_image):
8584 Prefer int to unsigned where either will do.
8585 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8586 old tiff_error_handler and tiff_warning_handler.
8587 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8588 stack buffer overflows. It uses only the features of vsnprintf
8589 that are common to both POSIX and native Microsoft.
8590 (tiff_error_handler, tiff_warning_handler): Use it.
8591 (tiff_load, gif_load, imagemagick_load_image):
8592 Don't assume :index value fits in 'int'.
8593 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8594 (imagemagick_load_image): Check that crop parameters fit into
8595 the integer types that MagickCropImage accepts. Don't assume
8596 Vimagemagick_render_type has a nonnegative value. Don't assume
8597 size_t fits in 'long'.
8598 (gs_load): Use printmax_t to print the widest integers possible.
8599 Check for integer overflow when computing image height and width.
8600
c11821d4
EZ
86012011-08-26 Eli Zaretskii <eliz@gnu.org>
8602
8603 * xdisp.c (redisplay_window): Don't force window start if point
8604 will be invisible in the resulting window. (Bug#9324)
8605
0c95fcf7
EZ
86062011-08-25 Eli Zaretskii <eliz@gnu.org>
8607
8608 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8609 the display spec is of the form `(space ...)'.
8610 (handle_display_spec): Return the value returned by
8611 handle_single_display_spec, not just 1 or zero.
8612 (handle_single_display_spec): If the display spec is of the form
8613 `(space ...)', and specifies display in the text area, return 2
8614 rather than 1.
fee65a97 8615 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8616 accurately, and prefer exact match for point under bidi.
8617 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8618
8619 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8620 into disp_prop; all users changed.
8621
8622 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8623 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8624 for the text covered by the display property.
8625
e4ed06f1
CY
86262011-08-25 Chong Yidong <cyd@stupidchicken.com>
8627
8628 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8629 Change return value to nil.
8630 (Frecord_buffer): Delete unused function.
8631
f67cdd7f
EZ
86322011-08-24 Eli Zaretskii <eliz@gnu.org>
8633
5980d4c6
EZ
8634 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8635 buffers, return left-to-right.
8610fe8b
EZ
8636 (set_cursor_from_row): Consider candidate row a win if its glyph
8637 represents a newline and point is on that newline. Fixes cursor
8638 positioning on the newline at EOL of R2L text within L2R
8639 paragraph, and vice versa.
8640 (try_cursor_movement): Check continued rows, in addition to
8641 continuation rows. Fixes unwarranted scroll when point enters a
8642 continued line of R2L text within an L2R paragraph, or vice versa.
8643 (cursor_row_p): Consider the case of point being equal to
8644 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8645 from the end of a short line to the beginning of a continued line
8646 of R2L text within L2R paragraph.
8647 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8648 composed characters.
5980d4c6 8649
f67cdd7f
EZ
8650 * bidi.c (bidi_check_type): Use xassert.
8651 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8652 members.
8653
bca633fb
EZ
86542011-08-23 Eli Zaretskii <eliz@gnu.org>
8655
8656 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8657 a character.
8658
4a5885a7
CY
86592011-08-23 Chong Yidong <cyd@stupidchicken.com>
8660
8661 * nsfont.m (ns_otf_to_script): Fix typo.
8662
0902a04e
KH
86632011-08-22 Kenichi Handa <handa@m17n.org>
8664
8665 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8666 extra slot even if the purpose is char-code-property-table.
8667
1a2e6670
EZ
86682011-08-23 Eli Zaretskii <eliz@gnu.org>
8669
8ddde651
EZ
8670 * xdisp.c (redisplay_window): When computing centering_position,
8671 account for the height of the header line. (Bug#8874)
8672
425cc014
EZ
8673 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8674 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8675 candidate is selected by the mouse, and that candidate has a
8676 composed character under the mouse.
8677
1a2e6670
EZ
8678 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8679 coordinates reported by pos-visible-in-window-p for a composed
8680 character in column zero.
8681
8b76d6f8
SM
86822011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8683
8684 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8685
dac347dd
EZ
86862011-08-22 Eli Zaretskii <eliz@gnu.org>
8687
8688 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8689 consider it a hit if to_charpos is anywhere in the range of the
8690 composed buffer positions.
8691
e013fb34
CY
86922011-08-22 Chong Yidong <cyd@stupidchicken.com>
8693
8694 * image.c (gif_load): Don't assume that each subimage has the same
8695 dimensions as the base image. Handle disposal method that is
8696 "undefined" by the gif spec (Bug#9335).
8697
bd1ba3e8
CY
86982011-08-20 Chong Yidong <cyd@stupidchicken.com>
8699
8700 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8701 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8702
54a1215b
EZ
87032011-08-19 Eli Zaretskii <eliz@gnu.org>
8704
823564e5
EZ
8705 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8706 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8707 from an Org mode buffer to a Speedbar frame.
8708
54a1215b
EZ
8709 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8710 a composition, take its buffer position from IT->cmp_it.charpos.
8711 Fixes cursor positioning at the beginning of a line that begins
8712 with a composed character.
8713
9778ebcc
EZ
87142011-08-18 Eli Zaretskii <eliz@gnu.org>
8715
0be6ee06
EZ
8716 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8717 character bidirectional type, use STRONG_L instead. Fixes crashes
8718 in a buffer produced by `describe-categories'.
8719
9778ebcc
EZ
8720 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8721 members before the level stack, so they would be saved and
8722 restored when copying iterator state. Fixes incorrect reordering
8723 around TABs covered by display properties.
8724
156bffbe
AS
87252011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8726
6b02f655 8727 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8728
72ad093b
CY
87292011-08-17 Chong Yidong <cyd@stupidchicken.com>
8730
8731 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8732 (internal_condition_case_2, internal_condition_case_n):
8733 Remove unnecessary aborts (Bug#9081).
72ad093b 8734
35774242
EZ
87352011-08-17 Eli Zaretskii <eliz@gnu.org>
8736
8737 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8738 has no `load' handler, try opening the file locally. (Bug#9311)
8739
db76dd85
KB
87402011-08-16 Ken Brown <kbrown@cornell.edu>
8741
8742 * gmalloc.c: Expand comment.
8743
b215eee5
EZ
87442011-08-16 Eli Zaretskii <eliz@gnu.org>
8745
8746 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8747 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8748
a4579d33
KB
87492011-08-16 Ken Brown <kbrown@cornell.edu>
8750
8751 Fix memory allocation problems in Cygwin build (Bug#9273).
8752
8753 * unexcw.c ( __malloc_initialized): Declare external variable.
8754 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8755
8b76d6f8
SM
8756 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8757 New variables.
a4579d33
KB
8758 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8759 dumped emacs.
8760 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8761 in the static heap.
8762 [CYGWIN] (special_realloc): New function.
8763 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8764 requests to realloc storage in the static heap.
8765
3ebec551
PE
87662011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8767
8768 * bidi.c (bidi_initialize): Remove unused local.
8769
9fd8be00
EZ
87702011-08-15 Eli Zaretskii <eliz@gnu.org>
8771
6b02f655
SM
8772 * bidimirror.h:
8773 * biditype.h: Remove file.
8774 * makefile.w32-in ($(BLD)/bidi.$(O)):
8775 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8776
8777 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8778
8779 * chartab.c: Improve commentary for the uniprop_table API.
8780
32413314
EZ
8781 * bidi.c (bidi_paragraph_init): Support zero value of
8782 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8783 (bidi_initialize): Use uniprop_table instead of including
8784 biditype.h and bidimirror.h.
32413314 8785
9fd8be00
EZ
8786 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8787 coordinates of the iterator when restoring from ppos_it.
8788 (Bug#9296)
8789
5cf2b69b
KH
87902011-08-14 Kenichi Handa <handa@m17n.org>
8791
8792 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8793 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8794
daf17d00
EZ
87952011-08-14 Eli Zaretskii <eliz@gnu.org>
8796
8797 * xdisp.c (move_it_in_display_line_to): Don't invoke
8798 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8799 ppos_it. Fixes vertical cursor motion when line beginning is
8800 covered by an image. (Bug#9296)
8801
08e3161a
JD
88022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8803
8804 * nsterm.h (ns_run_ascript): Declare.
8805 (NSAPP_DATA2_RUNASSCRIPT): Define.
8806
8807 * nsfns.m (as_script, as_result, as_status): New static variables.
8808 (ns_run_ascript): New function.
5e617bc2 8809 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8810 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8811 the event loop. Get status from as_status (Bug#7276).
8812
8813 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8814 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8815 the event loop (Bug#7276).
8816
a3720aa2
AS
88172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8818
8819 * gnutls.c (QCgnutls_bootprop_priority)
8820 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8821 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8822 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8823 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8824 (QCgnutls_bootprop_verify_hostname_error)
8825 (QCgnutls_bootprop_callbacks_verify): Rename from
8826 Qgnutls_bootprop_..., all uses changed.
8827
8828 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8829 uses changed.
8830
0a0d27fb
PE
88312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8832
19d5c50c
PE
8833 * xfaces.c (Qframe_set_background_mode): Now static.
8834 * dispextern.h (Qframe_set_background_mode): Remove decl.
8835
0a0d27fb
PE
8836 * process.c (Fnetwork_interface_info): Declare local only if needed.
8837
377538cb
JD
88382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8839
8840 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8841 (Fnetwork_interface_list): Allocate in increments of bytes instead
8842 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8843 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8844 sockaddr.
8845 (struct ifflag_def): notrailers is smart on OSX.
8846 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8847 Get hardware address with getifaddrs if available.
8848
08fff70c
EZ
88492011-08-12 Eli Zaretskii <eliz@gnu.org>
8850
8851 * xdisp.c (iterate_out_of_display_property): xassert that
8852 IT->position is set to within IT->object's boundaries. Break from
8853 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8854 when IT->position is set up wrongly due to some bug.
8855 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8856 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8857 entry. Force push_it to save on the stack the current
8858 buffer/string position, to be restored by pop_it. Fix flags in
8859 the iterator structure wrt the object coming from a display
8860 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8861 properties. (Bug#9284)
8862
7be1c708 88632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8864
7be1c708
CY
8865 * fontset.c (fontset_get_font_group): Add proper type checks.
8866 (Bug#9172)
aac0c6e3 8867
7be1c708 88682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8869
7be1c708
CY
8870 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8871 and LC_VERSION_MIN_MACOSX.
8872 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8873 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8874
97bb72a6
EZ
88752011-08-08 Eli Zaretskii <eliz@gnu.org>
8876
8877 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8878 no-display-properties-and-no-overlays under bidi display.
8879 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8880 properties and overlays.
97bb72a6 8881
d5617611
CY
88822011-08-08 Chong Yidong <cyd@stupidchicken.com>
8883
37e11a63
CY
8884 * editfns.c (Fset_time_zone_rule): Document relationship with the
8885 setenv function.
8886
d5617611
CY
8887 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8888 the font entity extracted from the cache (Bug#8109).
8889
58872834
CY
88902011-08-07 Chong Yidong <cyd@stupidchicken.com>
8891
8892 * composite.c (autocmp_chars): Don't reset point. That is done by
8893 restore_point_unwind (Bug#5984).
8894
75bfc667
JL
88952011-08-07 Juri Linkov <juri@jurta.org>
8896
8897 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8898 to show the arg `TIME' instead of `TIMEVAL'.
8899
d1410150
EZ
89002011-08-06 Eli Zaretskii <eliz@gnu.org>
8901
8902 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8903 display property strides EOL and includes a newline, as in
8904 longlines-mode. (Bug#9254)
75b771e4
EZ
8905 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8906 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8907
8908 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8909 is non-zero, even if the data buffer is NULL. Fixes a crash in
8910 vertical-motion with longlines-mode. (Bug#9254)
8911
35928349
EZ
89122011-08-05 Eli Zaretskii <eliz@gnu.org>
8913
ec7cc85b
EZ
8914 * bidi.c <bidi_cache_total_alloc>: Now static.
8915 (bidi_initialize): Initialize bidi_cache_total_alloc.
8916
8b76d6f8 8917 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8918 cache. (Bug#9221)
8919
8920 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8921 amount allocated this far in `bidi_cache_total_alloc'.
8922 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8923 non-zero, only free the data buffer without restoring the cache
8924 contents. All callers changed.
8925
8926 * dispextern.h (bidi_unshelve_cache): Update prototype.
8927
8928 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8929 (move_it_in_display_line, move_it_to)
8930 (move_it_vertically_backward, move_it_by_lines): Replace the call
8931 to xfree to an equivalent call to bidi_unshelve_cache.
8932 (move_it_in_display_line_to): Fix logic of returning
412b6358 8933 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8934
e2e2423b
EZ
89352011-08-05 Eli Zaretskii <eliz@gnu.org>
8936
8937 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8938 came from a string character with a `cursor' property. (Bug#9229)
8939
ae9e757a
JD
89402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8941
8942 * Makefile.in (LIB_PTHREAD): New variable.
8943 (LIBES): Add LIB_PTHREAD (Bug#9216).
8944
8945 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8946 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8947
213bd7f2
AS
89482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8949
6b02f655 8950 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8951
99aaf75f
JD
89522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8953
8954 * xterm.c (x_find_topmost_parent): New function.
8955 (x_set_frame_alpha): Find topmost parent window with
8956 x_find_topmost_parent and set the property there also (bug#9181).
8957 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8958
c74e9d86
PE
89592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8960
8961 * callproc.c (Fcall_process): Avoid vfork clobbering
8962 the local vars buffer, coding_systems, current_dir.
8963
640c8776
SM
89642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8965
8966 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8967
f26d0e4c
PE
89682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8969
8a10d76c
PE
8970 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8971 so that it is not optimized away.
8972
f26d0e4c
PE
8973 * xdisp.c (compute_display_string_pos): Remove unused local.
8974
55439c61
EZ
89752011-08-02 Eli Zaretskii <eliz@gnu.org>
8976
8977 Fix slow cursor motion and scrolling in large buffers with
8978 selective display, like Org Mode buffers. (Bug#9218)
8979
8980 * dispextern.h (struct bidi_it): New member disp_prop_p.
8981
8982 * xdisp.c: Remove one-slot cache of display string positions.
8983 (compute_display_string_pos): Accept an additional argument
5e617bc2 8984 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8985 for a display string or property. If found, set DISP_PROP_P
8986 non-zero.
8987
8988 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8989 DISP_PROP_P, and pass it to compute_display_string_pos.
8990 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8991 non-zero. All callers of bidi_fetch_char changed.
8992
fb33fa43
SM
89932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8994
8995 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8996
b099e063
DM
89972010-12-03 Don March <don@ohspite.net>
8998
8999 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9000 last character M-[char] is translated to ESC [char] (bug#7541).
9001
5cc7f7af
KH
90022011-08-02 Kenichi Handa <handa@m17n.org>
9003
d0fffa3f 9004 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9005
9006 * chartab.c (uniprop_table): Make it non-static.
9007
525d5e6e
EZ
90082011-08-01 Eli Zaretskii <eliz@gnu.org>
9009
9010 * xdisp.c (forward_to_next_line_start): Accept additional argument
9011 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9012 on the newline.
9013 (reseat_at_next_visible_line_start): Use the bidi iterator state
9014 returned by forward_to_next_line_start to restore the state of
9015 it->bidi_it after backing up to previous newline. (Bug#9212)
9016
31011111
AS
90172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9018
9019 * regex.c (re_comp): Protoize.
9020 (re_exec): Fix return type.
9021 (regexec): Fix type of `ret'. (Bug#9203)
9022
476371c4
PE
90232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9024
e5d76069
PE
9025 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9026 This is needed if max-image-size is a floating-point number.
9027
9a79b20c
AS
90282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9029
9030 * print.c (print_object): Print empty symbol as ##.
9031
9032 * lread.c (read1): Read ## as empty symbol.
9033
d8c2fa78
AA
90342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9035
9036 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9037 setting frame foreground color (Bug#9175).
9038 (x_set_background_color): Likewise.
9039
ffe57a7a
AA
9040 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9041 contents (Bug#9176).
9042 (EmacsTooltip -init): Remove bezels and add shadows to
9043 tooltip windows.
9044
bf3492a5
AA
9045 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9046 or scroll bar (Bug#8470).
9047
d55e9c53
AA
9048 * nsfont.m (nsfont_open): Remove assignment to voffset and
9049 unnecessary vars hshink, expand, hd, full_height, min_height.
9050 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9051
9052 * nsterm.h (nsfont_info): Remove voffset field.
9053
d8c2fa78 90542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9055
9056 Implement strike-through and overline on NextStep (Bug#8863).
9057
9058 * nsfont.m (nsfont_open): Use underline position provided by font,
9059 instead of hard-coded value of 2.
9060 (nsfont_draw): Call ns_draw_text_decoration instead.
9061
9062 * nsterm.h: Add declaration for ns_draw_text_decoration.
9063
9064 * nsterm.m (ns_draw_text_decoration): New function for drawing
9065 underline, overline, and strike-through.
9066 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9067 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9068 accommodate underlining, etc.
4843aac3 9069
4cc60b9b
EZ
90702011-07-28 Eli Zaretskii <eliz@gnu.org>
9071
bc7ece87
EZ
9072 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9073 default.
4cc60b9b 9074
476371c4
PE
90752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9076
66606eea
PE
9077 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9078 Without this fix, if a signal arrives just after memory fills up,
9079 'malloc' might be invoked reentrantly.
9080
476371c4
PE
9081 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9082 In other words, assume that every image size is allowed, on non-X
9083 hosts. This assumption is probably wrong, but it lets Emacs compile.
9084
f3fcc40d
AS
90852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9086
9087 * regex.c (re_iswctype): Convert return values to boolean.
9088
350c992f
EZ
90892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9090
9091 * xdisp.c (compute_display_string_pos): Don't use cached display
9092 string position if the buffer had its restriction changed.
9093 (Bug#9184)
9094
5266b4bb
PE
90952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9096
9097 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9098
2573a837 90992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9100
41f55ccd 9101 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9102
39e378da
PE
9103 * bidi.c: Integer size and overflow fixes.
9104 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9105 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9106 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9107 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9108 (bidi_find_other_level_edge):
9109 Use ptrdiff_t instead of EMACS_INT where either will do.
9110 This works better on 32-bit hosts configured --with-wide-int.
9111 (bidi_cache_ensure_space): Check for size-calculation overflow.
9112 Use % rather than repeated addition, for better worst-case speed.
9113 Don't set bidi_cache_size until after xrealloc returns, because it
9114 might not return.
9115 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9116 (bidi_cache_ensure_space): Also check that the bidi cache size
9117 does not exceed that of the largest Lisp string or buffer. See Eli
9118 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9119
5e927815
PE
9120 * alloc.c (__malloc_size_t): Remove.
9121 All uses replaced by size_t. See Andreas Schwab's note
9122 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9123
ca4aa935
PE
9124 * image.c: Improve checking for integer overflow.
9125 (check_image_size): Assume that f is nonnull, since
9126 it is always nonnull in practice. This is one less thing to
9127 worry about when checking for integer overflow later.
9128 (x_check_image_size): New function, which checks for integer
9129 overflow issues inside X.
9130 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9131 This removes the need for a memory_full check.
9132 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9133 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9134 (xbm_read_bitmap_data): Change locals back to 'int', since
9135 their values must fit in 'int'.
9136 (xpm_load_image, png_load, tiff_load):
9137 Invoke x_create_x_image_and_pixmap earlier,
9138 to avoid much needless work if the image is too large.
9139 (tiff_load): Treat overly large images as if
9140 x_create_x_image_and_pixmap failed, not as malloc failures.
9141 (gs_load): Use x_check_image_size.
9142
5f8f9cc2
PE
9143 * gtkutil.c: Omit integer casts.
9144 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9145 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9146
5adf60bc
PE
9147 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9148
c8907a93
PE
9149 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9150 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9151 would wrongly return t on a 64-bit host.
9152
e3c25c68
PE
9153 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9154 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9155 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9156 and therefore cause GCC to emit a bogus diagnostic in some cases.
9157
3f791afe
PE
9158 * image.c: Integer signedness and overflow and related fixes.
9159 This is not an exhaustive set of fixes, but it's time to
9160 record what I've got.
9161 (lookup_pixel_color, check_image_size): Remove redundant decls.
9162 (check_image_size): Don't assume that arbitrary EMACS_INT values
9163 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9164 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9165 (tiff_load, imagemagick_load_image):
9166 Check for overflow in size calculations.
9167 (x_create_x_image_and_pixmap): Remove unnecessary test for
9168 xmalloc returning NULL; that can't happen.
9169 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9170 (xpm_color_bucket): Use better integer hashing function.
9171 (xpm_cache_color): Don't possibly over-allocate memory.
9172 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9173 (gif_memory_source):
9174 Use ptrdiff_t, not int or size_t, to record sizes.
9175 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9176 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9177 either works, as we prefer signed integers.
9178 (tiff_read_from_memory, tiff_write_from_memory):
9179 Return tsize_t, not size_t, since that's what the TIFF API wants.
9180 (tiff_read_from_memory): Don't fail simply because the read would
9181 go past EOF; instead, return a short read.
9182 (tiff_load): Omit no-longer-needed casts.
9183 (Fimagemagick_types): Don't assume size fits into 'int'.
9184
3cc5a532
PE
9185 Improve hashing quality when configured --with-wide-int.
9186 * fns.c (hash_string): New function, taken from sxhash_string.
9187 Do not discard information about ASCII character case; this
9188 discarding is no longer needed.
9189 (sxhash-string): Use it. Change sig to match it. Caller changed.
9190 * lisp.h: Declare it.
9191 * lread.c (hash_string): Remove, since we now use fns.c's version.
9192 The fns.c version returns a wider integer if --with-wide-int is
9193 specified, so this should help the quality of the hashing a bit.
9194
b312a492
PE
9195 * emacs.c: Integer overflow minor fix.
9196 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9197 Define only if GNU_LINUX.
9198 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9199
dfd153ae
PE
9200 * dispnew.c: Integer signedness and overflow fixes.
9201 Remove unnecessary forward decls, that were a maintenance hassle.
9202 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9203 All uses changed.
9204 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9205 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9206 (prepare_desired_row, line_draw_cost):
9207 Use int, not unsigned, where either works.
9208 (save_current_matrix, restore_current_matrix):
9209 Use ptrdiff_t, not size_t, where either works.
9210 (init_display): Check for overflow more accurately, and without
9211 relying on undefined behavior.
9212
a81d11a3
PE
9213 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9214 Remove, replacing with the new symbols in lisp.h. All uses changed.
9215 * fileio.c (make_temp_name):
9216 * filelock.c (lock_file_1, lock_file):
9217 * xdisp.c (message_dolog):
9218 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9219 Use pMd etc. instead.
9220 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9221 replacing the pWIDE etc. symbols removed from editfns.c.
9222
3300e6fd
PE
9223 * keyboard.h (num_input_events): Now uintmax_t.
9224 This is (very slightly) less likely to mess up due to wraparound.
9225 All uses changed.
9226
fd05c7e9
PE
9227 * buffer.c: Integer signedness fixes.
9228 (alloc_buffer_text, enlarge_buffer_text):
9229 Use ptrdiff_t rather than size_t when either will do, as we prefer
9230 signed integers.
9231
903fe15d
PE
9232 * alloc.c: Integer signedness and overflow fixes.
9233 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9234 (__malloc_size_t): Default to size_t, not to int.
9235 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9236 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9237 Prefer ptrdiff_t to size_t when either would do, as we prefer
9238 signed integers.
9239 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9240 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9241 Now const. Initialize with values that are in range even if char
9242 is signed.
9243 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9244 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9245 These functions do the right thing with sizes > 2**32.
9246 (check_depth): Now ptrdiff_t, not int.
9247 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9248 Adjust to new way of storing sizes. Check for size overflow bugs
9249 in rest of code.
9250 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9251 slightly wrong anyway, as it missed one instance of
9252 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9253 (refill_memory_reserve): Omit needless cast to size_t.
9254 (mark_object_loop_halt): Mark as externally visible.
9255
ac82cc6a
PE
9256 * xselect.c: Integer signedness and overflow fixes.
9257 (Fx_register_dnd_atom, x_handle_dnd_message):
9258 Use ptrdiff_t, not size_t, since we prefer signed.
9259 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9260 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9261 x_dnd_atoms_size and x_dnd_atoms_length.
9262
c2d1e36d
PE
9263 * doprnt.c: Prefer signed to unsigned when either works.
9264 * eval.c (verror):
9265 * doprnt.c (doprnt):
9266 * lisp.h (doprnt):
9267 * xdisp.c (vmessage):
9268 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9269 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9270 prefer signed arithmetic to avoid comparison confusion.
9271 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9272 but is a bit tricky.
9273
0e926e56
PE
9274 Assume freestanding C89 headers, string.h, stdlib.h.
9275 * data.c, doprnt.c, floatfns.c, print.c:
9276 Include float.h unconditionally.
9277 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9278 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9279 * regex.c: Likewise for stddef.h, string.h.
9280 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9281 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9282 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9283 (STDC_HEADERS): Remove obsolete defines.
9284 * sysdep.c: Include limits.h unconditionally.
9285
9cfdb3ec
PE
9286 Assume support for memcmp, memcpy, memmove, memset.
9287 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9288 * regex.c (memcmp, memcpy):
9289 Remove; we assume C89 now.
9290
9291 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9292 (__malloc_safe_bcopy): Remove; no longer needed.
9293
cf950e6b 9294 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9295 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9296 well either way, and we prefer signed to unsigned.
9297
dbf38e02
LMI
92982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9299
9300 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9301 closes the connection while we're reading (bug#9182).
9302
d6f0886c 93032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9304
d6f0886c
JD
9305 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9306 are specified (Bug#9168).
24e0f6b1 9307
2eb1f9e6
PE
93082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9309
9310 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9311 Found by GCC static checking and --with-wide-int on a 32-bit host.
9312
22381272 93132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9314
9315 * xdisp.c (compute_display_string_pos): Fix logic of caching
9316 previous display string position. Initialize cached_prev_pos to
9317 -1. Fixes slow-down at the beginning of a buffer.
9318
f25e39b4
EZ
93192011-07-24 Eli Zaretskii <eliz@gnu.org>
9320
9321 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9322 for attrs[LFACE_FONTSET_INDEX].
9323
04c4b52e
PE
93242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9325
9326 * xml.c (parse_region): Remove unused local
9327 that was recently introduced.
9328
c1734fbd
EZ
93292011-07-23 Eli Zaretskii <eliz@gnu.org>
9330
be18c5a5
EZ
9331 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9332 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9333
c1734fbd
EZ
9334 * xdisp.c (move_it_in_display_line_to): Record the best matching
9335 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9336 exit if none of the characters scanned was an exact match.
9337 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9338 when exact match is impossible due to invisible text, and the
9339 lines are truncated.
9340
a258d627
JD
93412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9342
9343 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9344 for OSX >= 10.7.
9345
b6d5a689
EZ
93462011-07-22 Eli Zaretskii <eliz@gnu.org>
9347
0f74f785
EZ
9348 Fix a significant slow-down of cursor motion with C-n, C-p,
9349 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9350 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9351 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9352 (next_element_from_buffer): Call compute_stop_pos_backwards to
9353 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9354 base_level_stop.
9355 (reseat): Don't look for prev_stop, as that could mean a very long
9356 run.
9357 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9358 <cached_disp_overlay_modiff>: Cache for last found display string
9359 position.
551918c1 9360 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9361 about the same buffer in the same area of character positions, and
9362 the buffer wasn't changed since the time the display string
9363 position was cached.
551918c1 9364
b2d0c91a
EZ
93652011-07-22 Eli Zaretskii <eliz@gnu.org>
9366
9367 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9368 is an integer, which is important for empty lines. (Bug#9149)
9369
043604ee
CY
93702011-07-22 Chong Yidong <cyd@stupidchicken.com>
9371
9372 * frame.c (Fmodify_frame_parameters): In tty case, update the
9373 default face if necessary (Bug#4238).
9374
da4adb04
CY
93752011-07-21 Chong Yidong <cyd@stupidchicken.com>
9376
9377 * editfns.c (Fstring_to_char): No need to explain what a character
9378 is in the docstring (Bug#6576).
9379
9abd0532
LMI
93802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9381
9382 * xml.c (parse_region): Make sure we always return a tree.
9383
36881d16
HK
93842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9385
9386 * xml.c (parse_region): If a document contains only comments,
9387 return that, too.
9388
1e98674d
LMI
93892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9390
9391 * xml.c (make_dom): Return comments, too.
9392
590bd467
PE
93932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9394
9395 Port to OpenBSD.
9396 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9397 and the surrounding thread.
9398 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9399 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9400 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9401 timer goes off.
9402 * s/openbsd.h (BROKEN_SIGIO): Define.
9403 * unexelf.c (unexec) [__OpenBSD__]:
9404 Don't update the .mdebug section of the Alpha COFF symbol table.
9405
f41628b2
LMI
94062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9407
9408 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9409 (bug#8460).
9410
b59b67c5
PE
94112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9412
15e3a074
PE
9413 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9414 This fixes some race conditions on the permissions of any newly
9415 created file.
9416
41bed37d
PE
9417 * alloc.c (valid_pointer_p): Use pipe, not open.
9418 This fixes some permissions issues when debugging.
9419
b59b67c5
PE
9420 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9421 If fchown fails to set both uid and gid, try to set just gid,
9422 as that is sometimes allowed. Adjust the file's mode to eliminate
9423 setuid or setgid bits that are inappropriate if fchown fails.
9424
925a6be7
SM
94252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9426
9427 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9428 to compare Lisp_Objects.
9429 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9430 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9431 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9432
52968808
AS
94332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9434
0a6a104b
AS
9435 * lread.c (read_integer): Unread even EOF character.
9436 (read1): Likewise. Properly record start position of symbol.
9437
52968808
AS
9438 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9439 symbol character follows.
9440
9e381cdd
PE
94412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9442
9443 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9444 This works around a problem with the previous change to Fcopy_file.
9445 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9446 and without this change, GCC might complain about discarding
9447 fchown's return value.
9448
b5641435
JB
94492011-07-16 Juanma Barranquero <lekktu@gmail.com>
9450
9451 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9452
a8031457
PE
94532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9454
9455 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9456
dd889327
LMI
94572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9458
750c33f7
LMI
9459 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9460 it's used from the C level.
9461
dd889327
LMI
9462 * process.c: Use the same condition for POLL_FOR_INPUT in both
9463 keyboard.c and process.c (bug#1858).
9464
87e86684
LM
94652011-07-09 Lawrence Mitchell <wence@gmx.li>
9466
9467 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9468 (Fgnutls_boot): Use it.
9469
64348f40
AS
94702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9471
9472 * doc.c (Fsubstitute_command_keys): Revert last change.
9473
1d698799
LMI
94742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9475
f863868c
LMI
9476 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9477 quotes the next character, and doesn't affect other longer
9478 sequences (bug#8935).
9479
1d698799
LMI
9480 * lread.c (syms_of_lread): Clarify that is isn't only
9481 `eval-buffer' and `eval-defun' that's affected by
9482 `lexical-binding' (bug#8460).
9483
aa4b6df6
EZ
94842011-07-15 Eli Zaretskii <eliz@gnu.org>
9485
9486 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9487 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9488
5d856da6
PE
94892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9490
ad6042bb
PE
9491 Fix minor problems found by static checking.
9492 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9493 (elsz): Now a signed constant, not a size_t var. We prefer signed
9494 types to unsigned, to avoid integer comparison confusion. Without
9495 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9496 "cannot optimize loop, the loop counter may overflow", a symptom
9497 of the confusion.
f00bbb22 9498 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9499 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9500
6468f31c
LMI
95012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9502
49080b10
LMI
9503 * search.c (Fre_search_backward): Mention `case-fold-search' in
9504 all the re_search_* functions (bug#8138).
9505
6468f31c
LMI
9506 * keyboard.c (Fopen_dribble_file): Document when the file is
9507 closed (bug#8056).
9508
c965adc5
EZ
95092011-07-14 Eli Zaretskii <eliz@gnu.org>
9510
df9733bf
EZ
9511 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9512 bidi_cache_idx.
9513
0bb23927
EZ
9514 Support bidi reordering of display and overlay strings.
9515 * xdisp.c (compute_display_string_pos)
9516 (compute_display_string_end): Accept additional argument STRING.
9517 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9518 (reseat_to_string): Initialize bidi_it->string.s and
9519 bidi_it->string.schars.
9520 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9521 NULL (avoids a crash in bidi_paragraph_init).
9522 Initialize itb.string.lstring.
0bb23927
EZ
9523 (init_iterator): Call bidi_init_it only of a valid
9524 buffer position was specified. Initialize paragraph_embedding to
9525 L2R.
9526 (reseat_to_string): Initialize the bidi iterator.
9527 (display_string): If we need to ignore text properties of
9528 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9529 original value of -1 will not work with bidi.)
9530 (compute_display_string_pos): First arg is now struct
9531 `text_pos *'; all callers changed. Support display properties on
9532 Lisp strings.
9533 (compute_display_string_end): Support display properties on Lisp
9534 strings.
9535 (init_iterator, reseat_1, reseat_to_string): Initialize the
9536 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9537 when iterating on a string not from display properties).
640c8776
SM
9538 (compute_display_string_pos, compute_display_string_end):
9539 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9540 arrow keys.
9541 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9542 base_level_stop; instead, set base_level_stop to BEGV.
9543 Fixes crashes in vertical-motion.
0bb23927
EZ
9544 (next_element_from_buffer): Improve commentary for when
9545 the iterator is before prev_stop.
9546 (init_iterator): Initialize bidi_p from the default value of
9547 bidi-display-reordering, not from buffer-local value. Use the
9548 buffer-local value only if initializing for buffer iteration.
9549 (handle_invisible_prop): Support invisible properties on strings
9550 that are being bidi-reordered.
9551 (set_iterator_to_next): Support bidi reordering of C strings and
9552 Lisp strings.
9553 (next_element_from_string): Support bidi reordering of Lisp
9554 strings.
9555 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9556 (display_string): Support display of R2L glyph rows.
9557 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9558 (init_iterator): Don't initialize it->bidi_p for strings
9559 here.
9560 (reseat_to_string): Initialize it->bidi_p for strings here.
9561 (next_element_from_string, next_element_from_c_string)
9562 (next_element_from_buffer): Add xassert's for correspondence
9563 between IT's object being iterated and it->bidi_it.string
9564 structure.
9565 (face_before_or_after_it_pos): Support bidi iteration.
9566 (next_element_from_c_string): Handle the case of the first string
9567 character that is not the first one in the visual order.
9568 (get_visually_first_element): New function, refactored from common
9569 parts of next_element_from_buffer, next_element_from_string, and
9570 next_element_from_c_string.
9571 (tool_bar_lines_needed, redisplay_tool_bar)
9572 (display_menu_bar): Force left-to-right direction. Add a FIXME
9573 comment for making that be controlled by a user option.
9574 (push_it, pop_it): Save and restore the state of the
9575 bidi iterator. Save and restore the bidi_p flag.
9576 (pop_it): Iterate out of display property for string iteration as
9577 well.
9578 (iterate_out_of_display_property): Support iteration over strings.
9579 (handle_single_display_spec): Set up it->bidi_it for iteration
9580 over a display string, and call bidi_init_it.
9581 (handle_single_display_spec, next_overlay_string)
9582 (get_overlay_strings_1, push_display_prop): Set up the bidi
9583 iterator for displaying display or overlay strings.
9584 (forward_to_next_line_start): Don't use the shortcut if
9585 bidi-iterating.
9586 (back_to_previous_visible_line_start): If handle_display_prop
9587 pushed the iterator stack, restore the internal state of the bidi
9588 iterator by calling bidi_pop_it same number of times.
9589 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9590 and we are bidi-iterating, don't decrement the iterator position;
9591 instead, set the first_elt flag in the bidi iterator, to produce
9592 the same effect.
9593 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9594 (push_display_prop): xassert that we are iterating a buffer.
9595 (push_it, pop_it): Save and restore paragraph_embedding member.
9596 (handle_single_display_spec, next_overlay_string)
9597 (get_overlay_strings_1, reseat_1, reseat_to_string)
9598 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9599 correctly. Don't assume unibyte strings are not bidi-reordered.
9600 (compute_display_string_pos)
9601 (compute_display_string_end): Fix handling the case of C string.
9602 (push_it, pop_it): Save and restore from_disp_prop_p.
9603 (handle_single_display_spec, push_display_prop): Set the
9604 from_disp_prop_p flag.
9605 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9606 (pop_it): Call iterate_out_of_display_property only if we are
9607 popping after iteration over a string that came from a display
9608 property. Fix a typo in popping stretch info. Add an assertion
9609 for verifying that the iterator position is in sync with the bidi
9610 iterator.
9611 (handle_single_display_spec, get_overlay_strings_1)
9612 (push_display_prop): Fix initialization of paragraph direction for
9613 string when that of the parent object is not yet determined.
9614 (reseat_1): Call bidi_init_it to resync the bidi
9615 iterator with IT's position. (Bug#7616)
9616 (find_row_edges): If ROW->start.pos gives position
9617 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9618 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9619 Reset the from_disp_prop_p flag.
9620 (SAVE_IT, RESTORE_IT): New macros.
9621 (pos_visible_p, face_before_or_after_it_pos)
9622 (back_to_previous_visible_line_start)
9623 (move_it_in_display_line_to, move_it_in_display_line)
9624 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9625 (try_scrolling, redisplay_window, display_line): Use them when
9626 saving a temporary copy of the iterator and restoring it back.
9627 (back_to_previous_visible_line_start, reseat_1)
9628 (init_iterator): Empty the bidi cache "stack".
9629 (move_it_in_display_line_to): If iterator ended up at
9630 EOL, but we never saw any buffer positions smaller than
9631 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9632 motion in bidi-reordered lines.
9633 (move_it_in_display_line_to): Record prev_method and prev_pos
9634 immediately before the call to set_iterator_to_next. Fixes cursor
9635 motion in bidi-reordered lines with stretch glyphs and strings
9636 displayed in margins. (Bug#8133) (Bug#8867)
9637 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9638 TO_CHARPOS.
640c8776
SM
9639 (pos_visible_p): Support positions in bidi-reordered lines.
9640 Save and restore bidi cache.
0bb23927
EZ
9641
9642 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9643 (bidi_paragraph_info): Delete unused struct.
9644 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9645 (bidi_cache_start): New variable.
9646 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9647 to zero.
9648 (bidi_cache_fetch_state, bidi_cache_search)
9649 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9650 (bidi_cache_find, bidi_peek_at_next_level)
9651 (bidi_level_of_next_char, bidi_find_other_level_edge)
9652 (bidi_move_to_visually_next): Compare cache index with
9653 bidi_cache_start rather than with zero.
9654 (bidi_fetch_char): Accept new argument STRING; all callers
9655 changed. Support iteration over a string. Support strings with
9656 display properties. Support unibyte strings. Fix the type of
9657 `len' according to what STRING_CHAR_AND_LENGTH expects.
9658 (bidi_paragraph_init, bidi_resolve_explicit_1)
9659 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9660 (bidi_level_of_next_char, bidi_move_to_visually_next):
9661 Support iteration over a string.
0bb23927
EZ
9662 (bidi_set_sor_type, bidi_resolve_explicit_1)
9663 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9664 can now be zero (for strings); special values 0 and -1 were
9665 changed to -1 and -2, respectively.
9666 (bidi_char_at_pos): New function.
9667 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9668 Call it instead of FETCH_MULTIBYTE_CHAR.
9669 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9670 initialized to valid values.
9671 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9672 values.
9673 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9674 the test for valid cached positions. Fix the logic for looking up
9675 the sentinel state in the cache. GCPRO the Lisp string we are
9676 iterating.
9677 (bidi_push_it, bidi_pop_it): New functions.
9678 (bidi_initialize): Initialize the bidi cache start stack pointer.
9679 (bidi_cache_ensure_space): New function, refactored from part of
9680 bidi_cache_iterator_state. Don't assume the required size is just
9681 one BIDI_CACHE_CHUNK away.
9682 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9683 (bidi_count_bytes, bidi_char_at_pos): New functions.
9684 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9685 always valid if bidi_cache_idx is valid.
9686 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9687 is valid if it's going to be used.
9688 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9689 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9690 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9691 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9692 (bidi_find_other_level_edge, bidi_cache_start_stack):
9693 All variables related to cache indices are now EMACS_INT.
c965adc5 9694
0bb23927
EZ
9695 * dispextern.h (struct bidi_string_data): New structure.
9696 (struct bidi_it): New member `string'. Make flag members be 1-bit
9697 fields, and put them last in the struct.
640c8776
SM
9698 (compute_display_string_pos, compute_display_string_end):
9699 Update prototypes.
0bb23927
EZ
9700 (bidi_push_it, bidi_pop_it): Add prototypes.
9701 (struct iterator_stack_entry): New members bidi_p,
9702 paragraph_embedding, and from_disp_prop_p.
9703 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9704 (bidi_shelve_cache, bidi_unshelve_cache):
9705 Declare prototypes.
0bb23927
EZ
9706
9707 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9708 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9709 and vector-like objects.
9710
9711 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9712 cache around display iteration.
9713
9714 * window.c (Fwindow_end, window_scroll_pixel_based)
9715 (displayed_window_lines, Frecenter): Save and restore the bidi
9716 cache around display iteration.
9717
3bbd2265
LMI
97182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9719
9720 * editfns.c (Fdelete_region): Clarify the use of the named
9721 parameters (bug#6788).
9722
adc47434
MR
97232011-07-14 Martin Rudalics <rudalics@gmx.at>
9724
9725 * indent.c (Fvertical_motion): Set and restore w->pointm when
9726 saving and restoring the window's buffer (Bug#9006).
9727
837c31f8
LMI
97282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9729
9730 * editfns.c (Fstring_to_char): Clarify just what is returned
9731 (bug#6576). Text by Eli Zaretskii.
9732
ac389d0c
JB
97332011-07-13 Juanma Barranquero <lekktu@gmail.com>
9734
9735 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9736
0be0ce47
EZ
97372011-07-13 Eli Zaretskii <eliz@gnu.org>
9738
9739 * buffer.c (mmap_find): Fix a typo.
9740
cd18e7e3
JB
97412011-07-13 Johan Bockgård <bojohan@gnu.org>
9742
9743 Fix execution of x selection hooks.
9744 * xselect.c (Qx_lost_selection_functions)
9745 (Qx_sent_selection_functions): New vars.
9746 (syms_of_xselect): DEFSYM them.
9747 (x_handle_selection_request): Pass Qx_sent_selection_functions
9748 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9749 (x_handle_selection_clear,x_clear_frame_selections):
9750 Pass Qx_lost_selection_functions rather than
9751 Vx_lost_selection_functions to Frun_hook_with_args.
9752
47ea7f44
PE
97532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9754
ac389d0c 9755 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9756 The old code sometimes used this field without initializing it.
9757
47ea7f44
PE
9758 * alloc.c (gc_sweep): Don't read past end of array.
9759 In theory, the old code could also have corrupted Emacs internals,
9760 though it'd be very unlikely.
9761
bc985c87
AS
97622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9763
9764 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9765 argument. (Bug#4026)
bc985c87 9766
0cf34688
LMI
97672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9768
b3dadd76
LMI
9769 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9770 key" (bug#4257).
9771
0cf34688
LMI
9772 * window.c (Fset_window_start): Doc fix (bug#4199).
9773 (Fset_window_hscroll): Ditto.
9774
270768cd
PE
97752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9776
077e3dda 9777 Fix minor new problems caught by GCC 4.6.1.
270768cd 9778 * term.c (init_tty): Remove unused local.
490011a6 9779 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9780 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9781 not used otherwise.
270768cd 9782
b1f58454
CY
97832011-07-12 Chong Yidong <cyd@stupidchicken.com>
9784
9785 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9786
22b9578d
LMI
97872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9788
6e70ab07
LMI
9789 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9790 are the mini-buffer and the echo area (bug#3320).
9791
22b9578d
LMI
9792 * term.c (init_tty): Remove support for supdup, c10 and perq
9793 terminals, which are no longer supported (bug#1482).
9794
8974cc9f
JB
97952011-07-10 Johan Bockgård <bojohan@gnu.org>
9796
9797 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9798
a560d974
JD
97992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9800
9801 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9802 for non-popups (Bug#3642).
9803
1dae0f0a
AS
98042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9805
268c2c36 9806 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9807 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9808 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9809 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9810 * data.c (fmod): Likewise.
9811 * dispnew.c (swap_glyphs_in_rows): Likewise.
9812 * emacs.c (memory_warning_signal): Likewise.
9813 * floatfns.c (float_error): Likewise.
9814 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9815 (otf_open, font_otf_capability, generate_otf_features)
9816 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9817 Likewise.
9818 * image.c (pbm_read_file): Likewise.
9819 * indent.c (string_display_width): Likewise.
9820 * intervals.c (check_for_interval, search_for_interval)
9821 (inc_interval_count, count_intervals, root_interval)
9822 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9823 * lread.c (defalias): Likewise.
268c2c36 9824 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9825 * regex.c (set_image_of_range_1, set_image_of_range)
9826 (regex_grow_registers): Likewise.
9827 * sysdep.c (strerror): Likewise.
9828 * termcap.c (valid_filename_p, tprint, main): Likewise.
9829 * tparam.c (main): Likewise.
9830 * unexhp9k800.c (run_time_remap, save_data_space)
9831 (update_file_ptrs, read_header, write_header, calculate_checksum)
9832 (copy_file, copy_rest, display_header): Likewise.
9833 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9834 Likewise.
9835 * xdisp.c (check_it): Likewise.
9836 * xfaces.c (register_color, unregister_color, unregister_colors):
9837 Likewise.
9838 * xfns.c (print_fontset_result): Likewise.
9839 * xrdb.c (member, fatal, main): Likewise.
9840
99033785
PE
98412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9842
9843 Fix minor problems found by static checking (Bug#9031).
9844 * chartab.c (char_table_set_range, map_sub_char_table):
9845 Remove unused locals.
9846 (uniprop_table): Now static.
9847 * composite.c (_work_char): Remove unused static var.
9848
9cb2ac56
JB
98492011-07-09 Juanma Barranquero <lekktu@gmail.com>
9850
9851 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9852
f25661f0
JD
98532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9854
9855 * gtkutil.c (qttip_cb): Remove code without function.
9856
8278c4fe
EZ
98572011-07-09 Eli Zaretskii <eliz@gnu.org>
9858
9859 * w32.c (pthread_sigmask): New stub.
9860
1692ae2d 98612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9862
8a6ebd58 9863 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9864 sigprocmask is portable only for single-threaded applications, and
9865 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9866 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9867 (LIBES): Use it.
9868 * callproc.c (Fcall_process):
9869 * process.c (create_process):
9870 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9871 Use pthread_sigmask, not sigprocmask.
123403e4 9872
1b854618
JD
98732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9874
9875 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9876 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9877 wrong (Bug#8591).
9878
3fe4b549
JD
98792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9880
0ce7e563
JD
9881 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9882 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9883 (xg_hide_tooltip): Fix comment.
9884
3fe4b549
JD
9885 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9886 in registerServicesMenuSendTypes.
9887 (validRequestorForSendType): Don't check ns_return_types.
9888
9889 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9890 ns_return_type.
9891
5df75e47
JR
98922011-07-08 Jason Rumney <jasonr@gnu.org>
9893
22610910
JR
9894 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9895 SH_SHOW for hidden windows (Bug#5482).
9896
5df75e47
JR
9897 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9898 frame struct members of non-existent frames (Bug#6284).
9899
699c10bd
JD
99002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9901
4393663b
JD
9902 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9903 variable firstTime not needed on OSX >= 10.6.
9904 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9905 >= 10.5. Use setKnobProportion, setDoubleValue.
9906
9907 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9908 (MAC_OS_X_VERSION_10_5): Define if not defined.
9909 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9910 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9911 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9912
9913 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9914 cString and lossyCString on OSX >= 10.4.
4393663b 9915
58179cce 9916 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9917 sizeToFit on OSX >= 10.2.
9918
9919 * nsimage.m (allocInitFromFile): Don't use deprecated method
9920 bestRepresentationForDevice on OSX >= 10.6.
9921
9922 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9923 to avoid warning.
9924
9925 * emacs.c: Declare unexec_init_emacs_zone.
9926
a63e0781
JD
9927 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9928
699c10bd
JD
9929 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9930
9931 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9932 on svcsMenu (Bug#8842).
9933
9934 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9935 ns_return_types.
9936 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9937
9938 * nsterm.m (QUTF8_STRING): Declare.
9939 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9940 (validRequestorForSendType): Return type is (id).
9941 Change indexOfObjectIdenticalTo to indexOfObject.
9942 Check if we have local selection before returning self (Bug#8842).
9943 (writeSelectionToPasteboard): Put local selection into paste board
9944 if we have a local selection (Bug#8842).
9945 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9946
9947 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9948 (ns_get_local_selection): Declare.
9949
54e10184
LMI
99502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9951
9888ff71
LMI
9952 * keymap.c (describe_map_tree): Don't insert a double newline at
9953 the end of the buffer (bug#1169) and return whether we inserted
9954 something.
9955
54e10184
LMI
9956 * callint.c (Fcall_interactively): Change "reading args" to
9957 "providing args" to try to clarify what it does (bug#1010).
9958
15fa4783
KH
99592011-07-07 Kenichi Handa <handa@m17n.org>
9960
9961 * composite.c (composition_compute_stop_pos): Ignore a static
9962 composition starting before CHARPOS (Bug#8915).
9963
9964 * xdisp.c (handle_composition_prop): Likewise.
9965
a8815b00
EZ
99662011-07-07 Eli Zaretskii <eliz@gnu.org>
9967
9968 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9969 (Bug#9015)
9970
ef7b981d 99712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9972
9973 * character.h (unicode_category_t): New enum type.
9974
9975 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9976 (Qchar_code_property_table): New variable.
9977 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9978 (UNIPROP_COMPRESSED_FORM_P): New macros.
9979 (char_table_ascii): Uncompress the compressed values.
9980 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9981 Uncompress the compressed values.
ac389d0c 9982 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9983 (char_table_ref_and_range): Uncompress the compressed values.
9984 (sub_char_table_set): New arg is_uniprop. Callers changed.
9985 Uncompress the compressed values.
9986 (sub_char_table_set_range): Args changed. Callers changed.
9987 (char_table_set_range): Adjuted for the above change.
9988 (map_sub_char_table): Delete args default_val and parent. Add arg
9989 top. Give decoded values to a Lisp function.
640c8776 9990 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9991 values to a Lisp function. Gcpro more variables.
9992 (uniprop_table_uncompress)
9993 (uniprop_decode_value_run_length): New functions.
9994 (uniprop_decoder, uniprop_decoder_count): New variables.
9995 (uniprop_get_decoder, uniprop_encode_value_character)
9996 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9997 New functions.
9998 (uniprop_encoder, uniprop_encoder_count): New variables.
9999 (uniprop_get_encoder, uniprop_table)
10000 (Funicode_property_table_internal, Fget_unicode_property_internal)
10001 (Fput_unicode_property_internal): New functions.
10002 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10003 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10004 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10005 char-code-property-alist.
10006
640c8776 10007 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10008 Vunicode_category_table.
10009
640c8776 10010 * font.c (font_range): Adjust for the change of
c805dec0
KH
10011 Vunicode_category_table.
10012
76b397fb
DN
100132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10014
10015 * m/iris4d.h: Remove file, move contents ...
10016 * s/irix6-5.h: ... here.
10017
22b4128e
PE
100182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10019
10020 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10021 * alloc.c (mark_buffer):
10022 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10023 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10024 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10025 This isn't true in general, and it's particularly not true
10026 if Emacs is configured with --with-wide-int.
10027 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10028 New macros, used in the buffer.c change.
10029
869795d6
JD
100302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10031
10032 * xsettings.c: Use both GConf and GSettings if both are available.
10033 (store_config_changed_event): Add comment.
10034 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10035 (store_tool_bar_style_changed): New functions.
5e617bc2 10036 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10037 (struct xsettings): Move font inside HAVE_XFT.
10038 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10039 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10040 Move inside HAVE_XFT.
640c8776 10041 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10042 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10043 also.
10044 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10045 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10046 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10047 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10048 (parse_settings): Move check for font inside HAVE_XFT.
10049 (read_settings, apply_xft_settings): Add comment.
10050 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10051 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10052 call store_font_name_changed.
10053 (xft_settings_event): Add comment.
10054 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10055 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10056 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10057 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10058 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10059 (xsettings_get_system_font, xsettings_get_system_normal_font):
10060 Add comment.
869795d6 10061
d8ed26bd
PE
100622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10063
10064 Random fixes. E.g., (random) never returned negative values.
10065 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10066 subseconds part to the entropy, as that's a bit more random.
10067 Prefer signed to unsigned, since the signedness doesn't matter and
10068 in general we prefer signed. When given a limit, use a
10069 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10070 latter isn't right if USE_2_TAGS_FOR_INTS.
10071 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10072 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10073
cabf1cac
SM
100742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10075
10076 * textprop.c (text_property_stickiness):
10077 Obey Vtext_property_default_nonsticky.
10078 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10079 * w32fns.c (syms_of_w32fns):
10080 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10081
6e9b2be9
PE
100822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10083
10084 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10085 This is more efficient than Ffile_directory_p and avoids a minor race.
10086
90186c68
LMI
100872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10088
7c301272
LMI
10089 * buffer.c (Foverlay_put): Say what the return value is
10090 (bug#7835).
10091
c4f2d8d4
LMI
10092 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10093 is a directory before asking whether to use the file name
10094 (bug#7564).
ad637907
LMI
10095 (barf_or_query_if_file_exists): Make the "File is a directory"
10096 error be more correct.
c4f2d8d4 10097
90186c68
LMI
10098 * fns.c (Frequire): Remove the mention of the .gz files, since
10099 that's installation-specific, but keep the mention of
10100 `get-load-suffixes'.
10101
da64016e
PE
101022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10103
10104 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10105 Report string overflow if the output is too long.
10106
7d47b580
JB
101072011-07-04 Juanma Barranquero <lekktu@gmail.com>
10108
a555cb87
JB
10109 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10110 (syms_of_gnutls): Remove duplicate DEFSYM for
10111 Qgnutls_bootprop_verify_hostname_error, an error for
10112 Qgnutls_bootprop_verify_error (which is no longer used).
10113
7d47b580
JB
10114 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10115 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10116 Also (re)move comments that are misplaced or no longer relevant.
10117
1e49bfab
LMI
101182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10119
10120 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10121
1485f4c0
CY
101222011-07-03 Chong Yidong <cyd@stupidchicken.com>
10123
10124 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10125 and background color parameters if they have been changed.
10126
a9ab721e
LMI
101272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10128
10129 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10130
cf7cff57
PE
101312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10132
2e13213d
PE
10133 * xsettings.c (SYSTEM_FONT): Define only when used.
10134 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10135
cf7cff57
PE
10136 * keymap.c (access_keymap_1): Now static.
10137
7a8e04f7
CY
101382011-07-02 Chong Yidong <cyd@stupidchicken.com>
10139
10140 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10141 leave any prefix arg for the up event (Bug#1586).
10142
61352f62
LMI
101432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10144
69bb1ef7
LMI
10145 * lread.c (syms_of_lread): Mention single symbols defined by
10146 `defvar' or `defconst' (bug#7154).
10147
61352f62 10148 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10149 (Frequire): Mention get-load-suffixes.
61352f62 10150
28545e04
MR
101512011-07-02 Martin Rudalics <rudalics@gmx.at>
10152
10153 * window.h (window): Remove clone_number slot.
10154 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10155 Remove.
10156 (make_parent_window, make_window, saved_window)
10157 (Fset_window_configuration, save_window_save): Don't deal with
10158 clone numbers.
10159 * buffer.c (Qclone_number): Remove declaration.
10160 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10161
3349e122
SM
101622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10163
10164 Add multiple inheritance to keymaps.
10165 * keymap.c (Fmake_composed_keymap): New function.
10166 (Fset_keymap_parent): Simplify.
10167 (fix_submap_inheritance): Remove.
10168 (access_keymap_1): New function extracted from access_keymap to handle
10169 embedded parents and handle lists of maps.
10170 (access_keymap): Use it.
10171 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10172 (Fcopy_keymap): Handle embedded parents.
10173 (Fcommand_remapping, define_as_prefix): Simplify.
10174 (Fkey_binding): Simplify.
10175 (syms_of_keymap): Move minibuffer-local-completion-map,
10176 minibuffer-local-filename-completion-map,
10177 minibuffer-local-must-match-map, and
10178 minibuffer-local-filename-must-match-map to Elisp.
10179 (syms_of_keymap): Defsubr make-composed-keymap.
10180 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10181 (parse_menu_item): Trivial simplification.
10182
3279eb87
GM
101832011-07-01 Glenn Morris <rgm@gnu.org>
10184
10185 * Makefile.in (SETTINGS_LIBS): Fix typo.
10186
39cb9e56 101872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10188
10189 * coding.c (Fencode_coding_string): Record the last coding system
10190 used, as the function doc string says (bug#8738).
10191
0949d2b6
JD
101922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10193
10194 * xsettings.c (store_monospaced_changed): Take new font as arg and
10195 check for change against current_mono_font.
10196 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10197 (emacs_settings_constructor, emacs_settings_get_property)
10198 (emacs_settings_set_property, emacs_settings_class_init)
10199 (emacs_settings_init, gsettings_obj): Remove.
10200 (something_changedCB): New function for HAVE_GSETTINGS.
10201 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10202 with value as argument.
10203 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10204 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10205 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10206 "changed".
10207
10208 * xgselect.c: Add defined (HAVE_GSETTINGS).
10209 (xgselect_initialize): Ditto.
10210
10211 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10212 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10213 xg_select.
10214
bbc6b304
PE
102152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10216
10217 * eval.c (struct backtrace): Simplify and port the data structure.
10218 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10219 signed bit field, as this assumption is not portable and it makes
10220 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10221 "char debug_on_exit : 1" as this is not portable either; instead,
10222 use the portable "unsigned int debug_on_exit : 1". Remove unused
10223 member evalargs. Remove obsolete comments about cc bombing out.
10224
9851bfc5
JD
102252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10226
51bb811f 10227 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10228 Let HAVE_GSETTINGS override HAVE_GCONF.
10229 (store_monospaced_changed): New function.
10230 (EMACS_SETTINGS): A new type derived from GObject to handle
10231 GSettings notifications.
10232 (emacs_settings_constructor, emacs_settings_get_property)
10233 (emacs_settings_set_property, emacs_settings_class_init):
10234 New functions.
10235 (gsettings_client, gsettings_obj): New variables.
10236 (GSETTINGS_SCHEMA): New define.
10237 (something_changedCB): Call store_monospaced_changed.
10238 (init_gsettings): New function.
10239 (xsettings_initialize): Call init_gsettings.
10240 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10241 to NULL.
10242
640c8776 10243 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10244 GCONF_CFLAGS/LIBS.
10245
5386012d
MR
102462011-06-29 Martin Rudalics <rudalics@gmx.at>
10247
10248 * window.c (resize_root_window, grow_mini_window)
10249 (shrink_mini_window): Rename Qresize_root_window to
10250 Qwindow_resize_root_window and Qresize_root_window_vertically to
10251 Qwindow_resize_root_window_vertically.
10252
f13e0b08
PE
102532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10254
10255 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10256
94515237
JB
102572011-06-27 Juanma Barranquero <lekktu@gmail.com>
10258
10259 * makefile.w32-in: Redesign dependencies so they reflect more
10260 clearly which files are directly included by each source file,
10261 and not through other includes.
10262
e43b6e43
MR
102632011-06-27 Martin Rudalics <rudalics@gmx.at>
10264
10265 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10266 (sort_overlays, overlay_strings): When an overlay's clone number
10267 matches the window's clone number process the overlay even if
10268 the overlay's window property doesn't match the current window.
10269
d68443dc
MR
10270 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10271 (Fwindow_hchild): Rename to Fwindow_left_child.
10272 (Fwindow_next): Rename to Fwindow_next_sibling.
10273 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10274 (resize_window_check): Rename to window_resize_check.
10275 (resize_window_apply): Rename to window_resize_apply.
10276 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10277 (Fdelete_other_windows_internal, resize_frame_windows)
10278 (Fsplit_window_internal, Fdelete_window_internal)
10279 (grow_mini_window, shrink_mini_window)
10280 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10281
c7e73be5
JD
102822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10283
10284 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10285 (emacs_fixed_set_min_size): Remove.
10286 (emacs_fixed_new): Take frame as argument.
10287
10288 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10289 (_EmacsFixedPrivate): Remove minwidth/height.
10290 Add struct frame *f.
10291 (emacs_fixed_init): Initialize priv->f.
10292 (get_parent_class, emacs_fixed_set_min_size): Remove.
10293 (emacs_fixed_new): Set priv->f to argument.
10294 (emacs_fixed_get_preferred_width)
10295 (emacs_fixed_get_preferred_height): Use min_width/height from
10296 frames size_hint to set minimum and natural (Bug#8919).
10297 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10298 and use min_width/height from frames size_hint to set
10299 min_width/height (Bug#8919).
10300
10301 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10302 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10303 Fix indentation.
c7e73be5 10304
cf99dcf8
EZ
103052011-06-26 Eli Zaretskii <eliz@gnu.org>
10306
10307 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10308 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10309 called at ZV.
10310
029529ac
CY
103112011-06-26 Chong Yidong <cyd@stupidchicken.com>
10312
10313 * process.c (wait_reading_process_output): Bypass select if
10314 waiting for a cell while ignoring keyboard input, and input is
10315 pending. Suggested by Jan Djärv (Bug#8869).
10316
7a7ef429
PE
103172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10318
10319 Use gnulib's dup2 module instead of rolling our own.
10320 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10321
11fdef7d 103222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10323
10324 * dispnew.c (scrolling_window): Before scrolling, turn off a
10325 mouse-highlight in the window being scrolled.
10326
cd3520a4
JB
103272011-06-24 Juanma Barranquero <lekktu@gmail.com>
10328
10329 Move DEFSYM to lisp.h and use everywhere.
10330
10331 * character.h (DEFSYM): Move declaration...
10332 * lisp.h (DEFSYM): ...here.
10333
10334 * gnutls.c:
10335 * minibuf.c:
10336 * w32menu.c:
10337 * w32proc.c:
10338 * w32select.c: Don't include character.h.
10339
10340 * alloc.c (syms_of_alloc):
10341 * buffer.c (syms_of_buffer):
10342 * bytecode.c (syms_of_bytecode):
10343 * callint.c (syms_of_callint):
10344 * casefiddle.c (syms_of_casefiddle):
10345 * casetab.c (init_casetab_once):
10346 * category.c (init_category_once, syms_of_category):
10347 * ccl.c (syms_of_ccl):
10348 * cmds.c (syms_of_cmds):
10349 * composite.c (syms_of_composite):
10350 * dbusbind.c (syms_of_dbusbind):
10351 * dired.c (syms_of_dired):
10352 * dispnew.c (syms_of_display):
10353 * doc.c (syms_of_doc):
10354 * editfns.c (syms_of_editfns):
10355 * emacs.c (syms_of_emacs):
10356 * eval.c (syms_of_eval):
10357 * fileio.c (syms_of_fileio):
10358 * fns.c (syms_of_fns):
10359 * frame.c (syms_of_frame):
10360 * fringe.c (syms_of_fringe):
10361 * insdel.c (syms_of_insdel):
10362 * keymap.c (syms_of_keymap):
10363 * lread.c (init_obarray, syms_of_lread):
10364 * macros.c (syms_of_macros):
10365 * msdos.c (syms_of_msdos):
10366 * print.c (syms_of_print):
10367 * process.c (syms_of_process):
10368 * search.c (syms_of_search):
10369 * sound.c (syms_of_sound):
10370 * syntax.c (init_syntax_once, syms_of_syntax):
10371 * terminal.c (syms_of_terminal):
10372 * textprop.c (syms_of_textprop):
10373 * undo.c (syms_of_undo):
10374 * w32.c (globals_of_w32):
10375 * window.c (syms_of_window):
10376 * xdisp.c (syms_of_xdisp):
10377 * xfaces.c (syms_of_xfaces):
10378 * xfns.c (syms_of_xfns):
10379 * xmenu.c (syms_of_xmenu):
10380 * xsettings.c (syms_of_xsettings):
10381 * xterm.c (syms_of_xterm): Use DEFSYM.
10382
4228cf16
TZ
103832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10384
cd3520a4 10385 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10386
7fcccf1e
PE
103872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10388
7efb4e0e
PE
10389 Integer and buffer overflow fixes (Bug#8873).
10390
ff5844ad
PE
10391 * print.c (printchar, strout): Check for string overflow.
10392 (PRINTPREPARE, printchar, strout):
10393 Don't set size unless allocation succeeds.
10394
90532f02
PE
10395 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10396 for sizes. Check for string overflow more accurately.
10397 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10398
6d84508d
PE
10399 * macros.c: Integer and buffer overflow fixes.
10400 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10401 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10402 Use ptrdiff_t, not int, for sizes.
10403 Don't increment bufsize until after realloc succeeds.
10404 Check for size-calculation overflow.
10405 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10406
437b2cb4
PE
10407 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10408
8b9ac8b4
PE
10409 * lread.c: Integer overflow fixes.
10410 (read_integer): Radix is now EMACS_INT, not int,
10411 to improve quality of diagnostics for out-of-range radices.
10412 Calculate buffer size correctly for out-of-range radices.
10413 (read1): Check for integer overflow in radices, and in
10414 read-circle numbers.
82cb60d3
PE
10415 (read_escape): Avoid int overflow.
10416 (Fload, openp, read_buffer_size, read1)
10417 (substitute_object_recurse, read_vector, read_list, map_obarray):
10418 Use ptrdiff_t, not int, for sizes.
10419 (read1): Use EMACS_INT, not int, for sizes.
20270765 10420 Check for size overflow.
8b9ac8b4 10421
7fcccf1e
PE
10422 * image.c (cache_image): Check for size arithmetic overflow.
10423
bfbbd7e7
PE
10424 * lread.c: Integer overflow issues.
10425 (saved_doc_string_size, saved_doc_string_length)
10426 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10427 Now ptrdiff_t, not int.
10428 (read1): Don't assume doc string length fits in int. Check for
10429 out-of-range doc string lengths.
10430 (read_list): Don't assume file position fits in int.
39019e54 10431 (read_escape): Check for hex character overflow.
bfbbd7e7 10432
4e323265
LL
104332011-06-22 Leo Liu <sdl.web@gmail.com>
10434
10435 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10436 Move to minibuffer.el.
10437
85fece3e
PE
104382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10439
20b84ce9 10440 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10441 The following patches are for when GLYPH_DEBUG && !XASSERT.
10442 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10443 * dispnew.c (flush_stdout):
10444 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10445 Mark as externally visible.
10446 * dispnew.c (check_window_matrix_pointers): Now static.
10447 * dispnew.c (window_to_frame_vpos):
10448 * xfns.c (unwind_create_frame):
10449 * xterm.c (x_check_font): Remove unused local.
10450 * scroll.c (CHECK_BOUNDS):
10451 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10452 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10453 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10454 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10455 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10456 Now static.
10457 (debug_method_add): Use va_list and vsprintf rather than relying
10458 on undefined behavior with wrong number of arguments.
10459 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10460 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10461 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10462 since we're not interested in debugging glyphs with old libraries.
10463 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10464 GCC 4.6.0's static checking.
10465
0766b489
PE
104662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10467
31fd4b32
PE
10468 Integer overflow and signedness fixes (Bug#8873).
10469 A few related buffer overrun fixes, too.
10470
b79e8648
PE
10471 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10472
0766b489
PE
10473 * dispextern.h (struct face.stipple):
10474 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10475 (x_bitmap_mask, x_allocate_bitmap_record)
10476 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10477 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10478 (x_create_bitmap_from_xpm_data):
10479 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10480 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10481 (.bitmaps_last):
10482 * xfaces.c (load_pixmap):
10483 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10484 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10485 (.bitmaps_last, struct x_output.icon_bitmap):
10486 Use ptrdiff_t, not int, for bitmap indexes.
10487 (x_allocate_bitmap_record): Check for size overflow.
10488 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10489
b081724f
PE
10490 Use ptrdiff_t, not int, for overlay counts.
10491 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10492 * editfns.c (overlays_around, get_pos_property):
10493 * textprop.c (get_char_property_and_overlay):
10494 * xdisp.c (next_overlay_change, note_mouse_highlight):
10495 * xfaces.c (face_at_buffer_position):
21514da7
PE
10496 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10497 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10498 (Fnext_overlay_change, Fprevious_overlay_change)
10499 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10500 Use ptrdiff_t, not int, for sizes.
21514da7 10501 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10502
3de73e5e
PE
10503 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10504
2606c57b
PE
10505 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10506 (x_session_initialize): Do not assume string length fits in int.
10507
aaafe47a
PE
10508 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10509 This is unlikely, but can occur if DPI is outlandish.
10510
2674ddc8 10511 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10512 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10513
28154962
PE
10514 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10515 * xrdb.c (magic_file_p, search_magic_path):
10516 Omit last arg SUFFIX; it was always 0. All callers changed.
10517 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10518
7de51af5
PE
10519 * xfont.c (xfont_match): Avoid need for strlen.
10520
25ed6cc3
PE
10521 * xfns.c: Don't assume strlen fits in int.
10522 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10523
4eab31dd
PE
10524 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10525 not unsigned long, as we prefer signed integers. All callers changed.
10526 Detect integer overflow in repeat count.
10527 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10528 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10529
171e2a58
PE
10530 * termcap.c: Don't assume sizes fit in int and never overflow.
10531 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10532 (gobble_line): Check for size-calculation overflow.
10533
ad39faca 10534 * minibuf.c (Fread_buffer):
6e5bb2dc 10535 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10536 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10537 Don't assume string length fits in int.
10538
52c61c22 10539 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10540 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10541
b5b8c9e5
PE
10542 * font.c: Don't assume string length fits in int.
10543 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10544 Use ptrdiff_t, not int.
ccd6111c
PE
10545 (font_intern_prop): Don't assume string length fits in int.
10546 Don't assume integer property fits in fixnum.
10547 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10548
882f0d81 10549 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10550 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10551 Reformulate so as not to need the command string.
10552 Invoke gzip -cd rather than gunzip, as it's more portable.
10553 (lock_info_type, lock_file_1, lock_file):
10554 Don't assume pid_t and time_t fit in unsigned long.
10555 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10556 (current_lock_owner): Prefer signed type for sizes.
10557 Use memcpy, not strncpy, where memcpy is what is really wanted.
10558 Don't assume (via atoi) that time_t and pid_t fit in int.
10559 Check for time_t and/or pid_t out of range, e.g., via a network share.
10560 Don't alloca where an auto var works fine.
10561
93f4cf88
PE
10562 * fileio.c: Fix some integer overflow issues.
10563 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10564 Don't assume string length fits in int.
10565 (directory_file_name): Don't assume string length fits in long.
10566 (make_temp_name): Don't assume pid fits in int, or that its print
10567 length is less than 20.
10568
f3e92b69
PE
10569 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10570
1bfdaf10
PE
10571 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10572
35016e9a
PE
10573 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10574
3d1e65a1
PE
10575 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10576 We prefer signed integers, even for size calculations.
10577
0b963a93
PE
10578 * emacs.c: Don't assume string length fits in 'int'.
10579 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10580 (main): Don't invoke strlen when not needed.
10581
573f4b54
PE
10582 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10583 (XD_DEBUG_MESSAGE): Don't waste a byte.
10584
989f33ba
PE
10585 * callproc.c (getenv_internal_1, getenv_internal)
10586 (Fgetenv_internal):
965d34eb
PE
10587 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10588
e4d29b33
PE
10589 * lread.c (invalid_syntax): Omit length argument.
10590 All uses changed. This doesn't fix a bug, but it simplifies the
10591 code away from its former Hollerith-constant appearance, and it's
10592 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10593 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10594
eb49b136
PE
10595 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10596 This didn't break anything, but it didn't help either.
10597 It's confusing to put a bogus integer in a place where the actual
10598 value does not matter.
9f62aeb1 10599 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10600 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10601
15375a22
PE
10602 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10603 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10604 implementation.
b61cc01c
PE
10605 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10606 We prefer signed types, and the value cannot exceed the EMACS_INT
10607 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10608 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10609 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10610 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10611
53b2623d
PE
10612 * indent.c (sane_tab_width): New function.
10613 (current_column, scan_for_column, Findent_to, position_indentation)
10614 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10615 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10616
51cab52b 10617 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10618
f2ed8a70
PE
10619 * lisp.h (lint_assume): New macro.
10620 * composite.c (composition_gstring_put_cache):
10621 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10622
abe80cc6
PE
10623 * editfns.c, insdel.c:
10624 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10625
b02c740e
PE
10626 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10627
ebc96716
PE
10628 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10629
b4e50fa0 10630 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10631 Use much-faster test for byte-length change.
311d5d7c 10632 Don't assume string byte-length fits in 'int'.
a4cf38e4 10633 Check that character arg fits in 'int'.
85461888 10634 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10635
c0c1ee9f
PE
10636 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10637
a498d7f4
PE
10638 * fns.c (concat): Catch string overflow earlier.
10639 Do not rely on integer wraparound.
10640
51cab52b
PE
10641 * dispextern.h (struct it.overlay_strings_charpos)
10642 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10643 * xdisp.c (forward_to_next_line_start)
10644 (back_to_previous_visible_line_start)
10645 (reseat_at_next_visible_line_start, next_element_from_buffer):
10646 Don't arbitrarily truncate the value of 'selective' to int.
10647
76031fad
PE
10648 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10649
5eb55db9
PE
10650 * composite.c: Don't truncate sizes to 'int'.
10651 (composition_gstring_p, composition_reseat_it)
10652 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10653 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10654 not EMACS_UINT, for indexes.
5eb55db9 10655
0703a717
PE
10656 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10657
d6202519
PE
10658 * buffer.c: Include <verify.h>.
10659 (struct sortvec.priority, struct sortstr.priority):
8961a454 10660 Now EMACS_INT, not int.
c20998a7 10661 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10662 (struct sortstr.size, record_overlay_string)
10663 (struct sortstrlist.size, struct sortlist.used):
10664 Don't truncate size to int.
10665 (record_overlay_string): Check for size-calculation overflow.
d6202519 10666 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10667
d5a19415
JM
106682011-06-22 Jim Meyering <meyering@redhat.com>
10669
029529ac 10670 Don't leak an XBM-image-sized buffer
d5a19415
JM
10671 * image.c (xbm_load): Free the image buffer after using it.
10672
a9041e6c
PE
106732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10674
10675 Port to Sun C.
10676 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10677 that Sun C diagnosed.
10678 * fns.c (secure_hash): Fix pointer signedness issue.
10679 * intervals.c (static_offset_intervals): New function.
10680 (offset_intervals): Use it.
10681
7f3f739f
LL
106822011-06-21 Leo Liu <sdl.web@gmail.com>
10683
10684 * deps.mk (fns.o):
10685 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10686 sha512.h.
10687
10688 * fns.c (secure_hash): Rename from crypto_hash_function and change
10689 the first arg to accept symbols.
5b66d427 10690 (Fsecure_hash): New primitive.
7f3f739f
LL
10691 (syms_of_fns): New symbols.
10692
76147d94
DD
106932011-06-20 Deniz Dogan <deniz@dogan.se>
10694
10695 * process.c (Fset_process_buffer): Clarify return value in
10696 docstring.
10697
7d7d0045
CY
106982011-06-18 Chong Yidong <cyd@stupidchicken.com>
10699
10700 * dispnew.c (add_window_display_history): Use BVAR.
10701
10702 * xdisp.c (debug_method_add): Use BVAR.
10703 (check_window_end, dump_glyph_matrix, dump_glyph)
10704 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10705
10706 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10707 Likewise.
10708
10709 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10710 check till after the cache is created in init_frame_faces.
10711
ff2bc410
SM
107122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10713
10714 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10715
28177add
PE
107162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10717
dd3482fe
PE
10718 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10719 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10720 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10721
393d71f3 10722 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10723 * fileio.c (Finsert_file_contents):
10724 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10725 Remove the old (too-loose) buffer overflow checks.
10726 They weren't needed, since make_gap checks for buffer overflow.
10727 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10728 The old code merely checked for Emacs fixnum overflow, and relied
10729 on undefined (wraparound) behavior. The new code avoids undefined
10730 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10731
2e6813b0 10732 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10733 Tune. Don't use wider integers than needed. Don't use alloca.
10734 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10735
599a9e4f
PE
10736 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10737
99561444
PE
10738 * insdel.c, lisp.h (buffer_overflow): New function.
10739 (insert_from_buffer_1, replace_range, replace_range_2):
10740 * insdel.c (make_gap_larger):
10741 * editfns.c (Finsert_char):
10742 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10743
28177add
PE
10744 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10745
e69dafad
PE
107462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10747
4baa020d 10748 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10749
b1c46f02
PE
10750 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10751 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10752
e69dafad
PE
10753 * fileio.c: Don't assume EMACS_INT fits in off_t.
10754 (emacs_lseek): New static function.
10755 (Finsert_file_contents, Fwrite_region): Use it.
10756 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10757
566684ea
PE
10758 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10759
e6966cd6
PE
10760 * fns.c: Don't overflow int when computing a list length.
10761 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10762 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10763 truncation on 64-bit hosts. Check for QUIT every
10764 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10765 faster and is responsive enough.
10766 (Flength): Report an error instead of overflowing an integer.
10767 (Fsafe_length): Return a float if the value is not representable
10768 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10769 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10770 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10771
dd0b0efb
PE
10772 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10773 (header_size, word_size): New constants.
10774 (allocate_vectorlike): Don't check size overflow here.
10775 (allocate_vector): Check it here instead, since this is the only
10776 caller of allocate_vectorlike that could cause overflow.
10777 Check that the new vector's length is representable as a fixnum.
10778
86fe5cfe
PE
10779 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10780 The previous code was bogus. For example, next_almost_prime (32)
10781 returned 39, which is undesirable as it is a multiple of 3; and
10782 next_almost_prime (24) returned 25, which is a multiple of 5 so
10783 why was the code bothering to check for multiples of 7?
10784
80e88859
PE
10785 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10786
4a2f0ad6
PE
10787 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10788
f66c7cf8
PE
10789 Variadic C functions now count arguments with ptrdiff_t.
10790 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10791 Back then I didn't know that the Emacs coding style prefers signed int.
10792 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10793 were being counted with int, which may truncate counts on 64-bit
10794 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10795 * lisp.h (struct Lisp_Subr.function.aMANY)
10796 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10797 Arg counts are now ptrdiff_t, not size_t.
10798 All variadic functions and their callers changed accordingly.
10799 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10800 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10801 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10802 * callint.c (Fcall_interactively): Check arg count for overflow,
10803 to avoid potential buffer overrun. Use signed char, not 'int',
10804 for 'varies' array, so that we needn't bother to check its size
10805 calculation for overflow.
10806 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10807 * eval.c (apply_lambda):
10808 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10809 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10810 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10811
a1759b76
PE
10812 * callint.c (Fcall_interactively): Don't use index var as event count.
10813
d96be9fc
PE
10814 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10815 * mem-limits.h (SIZE): Remove; no longer used.
10816
a690a978 10817 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10818
578c21e6
PE
10819 Remove unnecessary casts.
10820 * xterm.c (x_term_init):
10821 * xfns.c (x_set_border_pixel):
10822 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10823 These aren't needed now that we assume ANSI C.
10824
96f53c6c
PE
10825 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10826 It's more likely to cause problems (due to unsigned overflow)
10827 than to cure them.
10828
83c77d31
PE
10829 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10830
ee2079f1
PE
10831 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10832
6da65536
PE
10833 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10834
7147c4a4
PE
10835 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10836
193e32d9
PE
10837 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10838
e5533da6
PE
10839 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10840
9910e595
PE
10841 GLYPH_CODE_FACE returns EMACS_INT, not int.
10842 * dispextern.h (merge_faces):
10843 * xfaces.c (merge_faces):
01103c44
PE
10844 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10845 Don't assume EMACS_INT fits in int.
9910e595 10846
2638320e
PE
10847 * character.h (CHAR_VALID_P): Remove unused parameter.
10848 * fontset.c, lisp.h, xdisp.c: All uses changed.
10849
045eb8d9
PE
10850 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10851
c1f134b5
PE
10852 * fns.c (concat): Minor tuning based on overflow analysis.
10853 This doesn't fix any bugs. Use int to hold character, instead
10854 of constantly refetching from Emacs object. Use XFASTINT, not
10855 XINT, for value known to be a character. Don't bother comparing
10856 a single byte to 0400, as it's always less.
10857
395fcb93 10858 * floatfns.c (Fexpt):
327eeec8
PE
10859 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10860
abbd3d23
PE
10861 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10862 for characters.
10863
684a03ef
PE
10864 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10865
0fed43f3
PE
10866 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10867 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10868 incorrectly succeed when S was a string, because 4294967386 was
10869 truncated before it was used.
10870
8fd02eb7
PE
10871 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10872 Otherwise, an out-of-range integer could cause undefined behavior
10873 on a 64-bit host.
10874
f8c86b69
PE
10875 * composite.c: Use int, not EMACS_INT, for characters.
10876 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10877 EMACS_INT, for values that are known to be in character range.
10878 This doesn't fix any bugs but is the usual style inside Emacs and
10879 may generate better code on 32-bit machines.
10880
34206dd2
PE
10881 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10882 This is for reasons similar to the recent CHAR_STRING fix.
10883 * charset.c (Fencode_char): Check that character arg is actually
10884 a character. Pass an int to ENCODE_CHAR.
10885 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10886 wider than 'int', as a compile-time check to prevent future regressions
10887 in this area.
10888
c5958d4c 10889 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10890
10891 Make sure a 64-bit char is never passed to CHAR_STRING.
10892 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10893 by silently ignoring the top 32 bits, allowing some values
10894 that were far too large to be valid characters.
10895 * character.h: Include <verify.h>.
10896 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10897 arguments are no wider than unsigned, as a compile-time check
10898 to prevent future regressions in this area.
10899 * data.c (Faset):
01103c44 10900 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10901 (Fsubst_char_in_region):
10902 * fns.c (concat):
10903 * xdisp.c (decode_mode_spec_coding):
10904 Adjust to CHAR_STRING's new requirement.
10905 * editfns.c (Finsert_char, Fsubst_char_in_region):
10906 * fns.c (concat): Check that character args are actually
10907 characters. Without this test, these functions did the wrong
10908 thing with wildly out-of-range values on 64-bit hosts.
10909
d37ca623
PE
10910 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10911 These casts should not be needed on 32-bit hosts, either.
10912 * keyboard.c (read_char):
10913 * lread.c (Fload): Remove casts to unsigned.
10914
ea204efb
PE
10915 * lisp.h (UNSIGNED_CMP): New macro.
10916 This fixes comparison bugs on 64-bit hosts.
10917 (ASCII_CHAR_P): Use it.
10918 * casefiddle.c (casify_object):
01103c44 10919 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10920 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10921 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10922 * dispextern.h (FACE_FROM_ID):
10923 * keyboard.c (read_char): Use UNSIGNED_CMP.
10924
41cb286c
PE
10925 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10926 not to EMACS_INT, to avoid GCC warning.
10927
4a1b9832
PE
10928 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10929
55daad71
PE
10930 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10931 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10932 isn't needed on 32-bit machines.
8f95c75c 10933
01103c44
PE
10934 * buffer.c (Fgenerate_new_buffer_name):
10935 Use EMACS_INT for count, not int.
0ceccced 10936 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10937
10938 * data.c (Qcompiled_function): Now static.
10939
c6f072e7
PE
10940 * window.c (window_body_lines): Now static.
10941
20ce5912
PE
10942 * image.c (gif_load): Rename local to avoid shadowing.
10943
9c4c5f81
PE
10944 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10945 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10946 * alloc.c (make_save_value): Integer argument is now of type
10947 ptrdiff_t, not int.
10948 (mark_object): Use ptrdiff_t, not int.
10949 * lisp.h (pD): New macro.
10950 * print.c (print_object): Use it.
10951
c0c5c8ae
PE
10952 * alloc.c: Use EMACS_INT, not int, to count objects.
10953 (total_conses, total_markers, total_symbols, total_vector_size)
10954 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10955 (total_free_floats, total_floats, total_free_intervals)
10956 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10957 Now EMACS_INT, not int. All uses changed.
10958 (Fgarbage_collect): Compute overall total using a double, so that
10959 integer overflow is less likely to be a problem. Check for overflow
10960 when converting back to an integer.
5a25e253
PE
10961 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10962 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10963 These were 'int' variables that could overflow on 64-bit hosts;
10964 they were never used, so remove them instead of repairing them.
211a0b2a 10965 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10966 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10967 Previously, this ceilinged at INT_MAX, but that doesn't work on
10968 64-bit machines.
e46bb31a 10969 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10970
c78baabf 10971 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10972 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10973 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10974 when a (possibly-narrower) signed value would do just as well.
10975 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10976
c9d624c6
PE
10977 * alloc.c: Catch some string size overflows that we were missing.
10978 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10979 for convenience in STRING_BYTES_MAX.
10980 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10981 The definition here is exact; the one in lisp.h was approximate.
10982 (allocate_string_data): Check for string overflow. This catches
10983 some instances we weren't catching before. Also, it catches
10984 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10985 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10986 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10987
c9d624c6
PE
10988 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10989 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10990 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10991
353032ce
PE
10992 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10993
2bccce07
PE
10994 * alloc.c (Fmake_string): Check for out-of-range init.
10995
0ac30604
SM
109962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10997
10998 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10999
c195f2de
JD
110002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11001
11002 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11003 xg_get_default_scrollbar_width.
11004
11005 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11006 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11007 (style_changed_cb): Call update_theme_scrollbar_width and call
11008 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11009 all frames (Bug#8505).
11010 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11011 Call gtk_window_set_resizable if HAVE_GTK3.
11012 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11013 and height if HAVE_GTK3 (Bug#8505).
11014 (scroll_bar_width_for_theme): New variable.
11015 (update_theme_scrollbar_width): New function.
11016 (xg_get_default_scrollbar_width): Move code to
11017 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11018 (xg_initialize): Call update_theme_scrollbar_width.
11019
11020 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11021
11022 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11023
e10ac9f1
MR
110242011-06-12 Martin Rudalics <rudalics@gmx.at>
11025
11026 * frame.c (make_frame): Call other_buffer_safely instead of
11027 other_buffer.
11028
11029 * window.c (temp_output_buffer_show): Call display_buffer with
11030 second argument Vtemp_buffer_show_specifiers and reset latter
11031 immediately after the call.
11032 (Vtemp_buffer_show_specifiers): New variable.
11033 (auto_window_vscroll_p, next_screen_context_lines)
11034 (Vscroll_preserve_screen_position): Remove leading asterisks from
11035 doc-strings.
11036
2d3c217e 110372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11038
7b7f97e8 11039 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11040 * buffer.c (Qclone_number): Remove for now, as it's unused.
11041 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11042 (record_buffer): Remove unused local.
11043 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11044 (set_frame_buffer_list): Remove; unused.
11045 * frame.h (other_visible_frames): Remove decl.
11046 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11047 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11048 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11049 if HAVE_GPM.
11050 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11051 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11052 Define only if HAVE_GPM.
11053 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11054 (update_hints_inhibit): Remove; never set. All uses removed.
11055 * widgetprv.h (emacsFrameClassRec): Remove decl.
11056 * window.c (delete_deletable_window): Now returns void, since it
11057 wasn't returning anything.
11058 (compare_window_configurations): Remove unused locals.
11059 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11060 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11061 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11062 the same widths as pointers. This follows up on the 2011-05-06 patch.
11063 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11064 * xterm.h: Likewise.
11065 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11066
1384b89e
JB
110672011-06-12 Juanma Barranquero <lekktu@gmail.com>
11068
11069 * makefile.w32-in: Update dependencies.
11070 (LISP_H): Add lib/intprops.h.
11071
1100a63c
CY
110722011-06-11 Chong Yidong <cyd@stupidchicken.com>
11073
11074 * image.c (gif_load): Add animation frame delay to the metadata.
11075 (syms_of_image): Use DEFSYM. New symbol `delay'.
11076
6198ccd0
MR
110772011-06-11 Martin Rudalics <rudalics@gmx.at>
11078
11079 * window.c (delete_deletable_window): Re-add.
11080 (Fset_window_configuration): Rewrite to handle dead buffers and
11081 consequently deletable windows.
11082 (window_tree, Fwindow_tree): Remove. Supply functionality in
11083 window.el.
11084 (compare_window_configurations): Simplify code.
11085
b6e3633c
AS
110862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11087
1ab0dee5
AS
11088 * image.c (imagemagick_load_image): Fix type mismatch.
11089 (Fimagemagick_types): Likewise.
11090
b6e3633c
AS
11091 * window.h (replace_buffer_in_windows): Declare.
11092
9397e56f
MR
110932011-06-11 Martin Rudalics <rudalics@gmx.at>
11094
11095 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11096 Qclone_number. Remove external declaration of Qdelete_window.
11097 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11098 code.
640c8776
SM
11099 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11100 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11101 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11102 buffer list implementation.
11103 (other_buffer_safely): New function.
11104 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11105 calls to replace_buffer_in_windows and
11106 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11107 if allowed.
11108 (record_buffer): Inhibit quitting and rewrite using quittable
11109 functions. Run Qbuffer_list_update_hook if allowed.
11110 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11111 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11112 Move switch-to-buffer to window.el.
9397e56f
MR
11113 (bury-buffer): Move to window.el.
11114 (Vbuffer_list_update_hook): New variable.
11115
11116 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11117 section.
11118
11119 * window.h (resize_frame_windows): Move up in code.
11120 (Fwindow_frame): Remove EXFUN.
11121 (replace_buffer_in_all_windows): Remove prototype.
11122 (replace_buffer_in_windows_safely): Add prototype.
11123
11124 * window.c: Declare Qdelete_window static again. Move down
11125 declaration of select_count.
11126 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11127 (Fother_window): Move to window.el.
11128 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11129 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11130 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11131 window.el.
11132 (replace_buffer_in_windows): Implement by calling
11133 Qreplace_buffer_in_windows.
11134 (replace_buffer_in_all_windows): Remove with some functionality
11135 moved into replace_buffer_in_windows_safely.
11136 (replace_buffer_in_windows_safely): New function.
11137 (select_window_norecord, select_frame_norecord): Move in front
11138 of run_window_configuration_change_hook. Remove now obsolete
11139 declarations.
640c8776
SM
11140 (Fset_window_buffer): Rewrite doc-string.
11141 Call Qrecord_window_buffer.
9397e56f
MR
11142 (keys_of_window): Move binding for other-window to window.el.
11143
b50691aa
CY
111442011-06-11 Chong Yidong <cyd@stupidchicken.com>
11145
11146 * dispextern.h (struct image): Replace data member, whose int_val
11147 and ptr_val fields were not used by anything, with a single
11148 lisp_val object.
11149
11150 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11151 (gif_clear_image, gif_load, imagemagick_load_image)
11152 (gs_clear_image, gs_load): Callers changed.
11153
3f754b86
PE
111542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11155
cca69397
PE
11156 * buffer.h: Include <time.h>, for time_t.
11157 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11158
109e28d0
PE
11159 Fix minor problems found by static checking.
11160
60737f02
PE
11161 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11162
4b66faf3
PE
11163 Make identifiers static if they are not used in other modules.
11164 * data.c (Qcompiled_function, Qframe, Qvector):
11165 * image.c (QimageMagick, Qsvg):
11166 * minibuf.c (Qmetadata):
11167 * window.c (resize_window_check, resize_root_window): Now static.
11168 * window.h (resize_window_check, resize_root_window): Remove decls.
11169
109e28d0
PE
11170 * window.c (window_deletion_count, delete_deletable_window):
11171 Remove; unused.
46a4ce9e
PE
11172 (window_body_lines): Now static.
11173 (Fdelete_other_windows_internal): Mark vars as initialized.
11174 Make sure 'resize_failed' is initialized.
11175 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11176 (resize_window_apply): Remove unused local.
11177 * window.h (delete_deletable_window): Remove decl.
11178
109e28d0 11179 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11180 (imagemagick_load_image): Fix pointer signedness problem by changing
11181 last arg from unsigned char * to char *. All uses changed.
11182 Also, fix a local for similar reasons.
11183 Remove unused locals. Remove locals to avoid shadowing.
11184 (fn_rsvg_handle_free): Remove; unused.
11185 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11186 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11187
3f754b86
PE
11188 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11189
2547adb1
CY
111902011-06-10 Chong Yidong <cyd@stupidchicken.com>
11191
11192 * image.c (gif_load): Fix omitted cast error introduced by
11193 2011-06-06 change.
11194
2c8e37d4
MR
111952011-06-10 Martin Rudalics <rudalics@gmx.at>
11196
11197 * window.h (resize_proportionally, orig_total_lines)
11198 (orig_top_line): Remove from window structure.
11199 (set_window_height, set_window_width, change_window_heights)
11200 (Fdelete_window): Remove prototypes.
11201 (resize_frame_windows): Remove duplicate declaration.
11202
440a42e3
EZ
112032011-06-10 Eli Zaretskii <eliz@gnu.org>
11204
11205 * window.h (resize_frame_windows, resize_window_check)
11206 (delete_deletable_window, resize_root_window)
11207 (resize_frame_windows): Declare prototypes.
11208
11209 * window.c (resize_window_apply): Make definition be "static" to
11210 match the prototype.
11211
562dd5e9
MR
112122011-06-10 Martin Rudalics <rudalics@gmx.at>
11213
11214 * window.c: Remove declarations of Qwindow_size_fixed,
11215 window_min_size_1, window_min_size_2, window_min_size,
11216 size_window, window_fixed_size_p, enlarge_window, delete_window.
11217 Remove static from declaration of Qdelete_window, it's
11218 temporarily needed by Fbury_buffer.
11219 (replace_window): Don't assign orig_top_line and
11220 orig_total_lines.
11221 (Fdelete_window, delete_window): Remove. Window deletion is
11222 handled by window.el.
640c8776
SM
11223 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11224 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11225 (Fdelete_other_windows): Remove. Deleting other windows is
11226 handled by window.el.
11227 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11228 handled in window.el.
11229 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11230 Window minimum sizes are handled in window.el.
11231 (shrink_windows, size_window, set_window_height)
11232 (set_window_width, change_window_heights, window_height)
11233 (window_width, CURBEG, CURSIZE, enlarge_window)
11234 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11235 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11236 handled in window.el.
11237 (make_dummy_parent): Rename to make_parent_window and give it a
11238 second argument horflag.
11239 (make_window): Don't set resize_proportionally any more.
11240 (Fsplit_window): Remove. Windows are split in window.el.
11241 (save_restore_action, save_restore_orig_size)
11242 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11243 Resize mini windows in window.el.
11244 (grow_mini_window, shrink_mini_window): Implement by calling
11245 Qresize_root_window_vertically, resize_window_check and
11246 resize_window_apply.
640c8776
SM
11247 (saved_window, Fset_window_configuration, save_window_save):
11248 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11249 resize_proportionally.
11250 (window_min_height, window_min_width): Move to window.el.
11251 (keys_of_window): Move bindings for delete-other-windows,
11252 split-window, delete-window and enlarge-window to window.el.
11253
11254 * buffer.c: Temporarily extern Qdelete_window.
11255 (Fbury_buffer): Temporarily call Qdelete_window instead of
11256 Fdelete_window (Fbury_buffer will move to window.el soon).
11257
11258 * frame.c (set_menu_bar_lines_1): Remove code handling
11259 orig_top_line and orig_total_lines.
11260
11261 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11262 set_window_height but set heights directly.
11263 (change_frame_size_1): Use resize_frame_windows.
11264
11265 * xdisp.c (init_xdisp): Don't use set_window_height but set
11266 heights directly.
11267
640c8776
SM
11268 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11269 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11270 run_window_configuration_change_hook.
11271
11272 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11273 instead of change_window_heights and run
11274 run_window_configuration_change_hook.
11275
1a13852e
MR
112762011-06-09 Martin Rudalics <rudalics@gmx.at>
11277
11278 * window.c (replace_window): Rename second argument REPLACEMENT to
11279 NEW. New third argument SETFLAG. Rewrite.
11280 (delete_window, make_dummy_parent): Call replace_window with
11281 third argument 1.
11282 (window_list_1): Move down in code.
11283 (run_window_configuration_change_hook): Move set_buffer part
11284 before select_frame_norecord part in order to unwind correctly.
11285 Rename count1 to count.
11286 (recombine_windows, delete_deletable_window, resize_root_window)
11287 (Fdelete_other_windows_internal)
11288 (Frun_window_configuration_change_hook, make_parent_window)
11289 (resize_window_check, resize_window_apply, Fresize_window_apply)
11290 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11291 (Fdelete_window_internal, Fresize_mini_window_internal):
11292 New functions.
1a13852e
MR
11293 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11294
f3d1777e
MR
112952011-06-08 Martin Rudalics <rudalics@gmx.at>
11296
496e208e
MR
11297 * window.h (window): Add some new members to window structure -
11298 normal_lines, normal_cols, new_total, new_normal, clone_number,
11299 splits, nest, prev_buffers, next_buffers.
11300 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11301 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11302
f3d1777e
MR
11303 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11304 Remove.
496e208e
MR
11305 (make_dummy_parent): Set new members of windows structure.
11306 (make_window): Move down in code. Handle new members of window
11307 structure.
11308 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11309 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11310 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11311 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11312 (Fset_window_next_buffers, Fset_window_clone_number):
11313 New functions.
496e208e
MR
11314 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11315 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11316 Doc-string fixes.
11317 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11318 Argument WINDOW can be now internal window too.
11319 (Fwindow_use_time): Move up in code.
11320 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11321 Rewrite doc-string.
11322 (Fset_window_configuration, saved_window)
11323 (Fcurrent_window_configuration, save_window_save): Handle new
11324 members of window structure.
b9e809c2
MR
11325 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11326 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11327 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11328 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11329 Qget_mru_window, Qresize_root_window,
11330 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11331 Qauto_buffer_name; staticpro them.
f3d1777e 11332
abde8f8c
MR
113332011-06-07 Martin Rudalics <rudalics@gmx.at>
11334
11335 * window.c (Fwindow_total_size, Fwindow_left_column)
11336 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11337 (Fwindow_list_1): New functions.
11338 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11339 (Fwindow_width, Fscroll_left, Fscroll_right):
11340 Use window_body_cols instead of window_box_text_cols.
11341 (delete_window, Fset_window_configuration):
11342 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11343 (delete_all_subwindows): Take a window as argument and not a
11344 structure. Rewrite.
190b47e6
MR
11345 (window_loop): Remove handling of GET_LRU_WINDOW and
11346 GET_LARGEST_WINDOW.
11347 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11348
11349 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11350 window_box_text_cols. delete_all_subwindows now takes a
11351 Lisp_Object as argument.
abde8f8c 11352
640c8776
SM
11353 * indent.c (compute_motion, Fcompute_motion):
11354 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11355
fa8a67e6
MR
11356 * frame.c (delete_frame): Call delete_all_subwindows with root
11357 window as argument.
11358
a54e3482
DC
113592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11360
11361 * fns.c (Fputhash): Document return value.
11362
60002bf5
CY
113632011-06-06 Chong Yidong <cyd@stupidchicken.com>
11364
11365 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11366
0c671da6 113672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11368
b862a52a 11369 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11370
be44ca6c
PE
11371 Check for overflow when converting integer to cons and back.
11372 * charset.c (Fdefine_charset_internal, Fdecode_char):
11373 Use cons_to_unsigned to catch overflow.
11374 (Fencode_char): Use INTEGER_TO_CONS.
11375 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11376 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11377 * data.c (long_to_cons, cons_to_long): Remove.
11378 (cons_to_unsigned, cons_to_signed): New functions.
11379 These signal an error for invalid or out-of-range values.
11380 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11381 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11382 * font.c (Ffont_variation_glyphs):
11383 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11384 * lisp.h: Include <intprops.h>.
11385 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11386 (cons_to_signed, cons_to_unsigned): New decls.
11387 (long_to_cons, cons_to_long): Remove decls.
11388 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11389 (Fprimitive_undo): Use CONS_TO_INTEGER.
11390 * xfns.c (Fx_window_property): Likewise.
11391 * xselect.c: Include <limits.h>.
11392 (x_own_selection, selection_data_to_lisp_data):
11393 Use INTEGER_TO_CONS.
11394 (x_handle_selection_request, x_handle_selection_clear)
11395 (x_get_foreign_selection, Fx_disown_selection_internal)
11396 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11397 (lisp_data_to_selection_data): Use cons_to_unsigned.
11398 (x_fill_property_data): Use cons_to_signed.
11399 Report values out of range.
11400
d1f3d2af
PE
11401 Check for buffer and string overflow more precisely.
11402 * buffer.h (BUF_BYTES_MAX): New macro.
11403 * lisp.h (STRING_BYTES_MAX): New macro.
11404 * alloc.c (Fmake_string):
11405 * character.c (string_escape_byte8):
11406 * coding.c (coding_alloc_by_realloc):
11407 * doprnt.c (doprnt):
11408 * editfns.c (Fformat):
11409 * eval.c (verror):
11410 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11411 since they may not be the same number.
11412 * editfns.c (Finsert_char):
11413 * fileio.c (Finsert_file_contents):
11414 Likewise for BUF_BYTES_MAX.
11415
dd52fcea
PE
11416 * image.c: Use ptrdiff_t, not int, for sizes.
11417 (slurp_file): Switch from int to ptrdiff_t.
11418 All uses changed.
11419 (slurp_file): Check that file size fits in both size_t (for
11420 malloc) and ptrdiff_t (for sanity and safety).
11421
7f9bbdbb
PE
11422 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11423 if b->modtime has its maximal value.
11424
dfe18f82
PE
11425 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11426
84acfcf0
PE
11427 Don't assume time_t can fit into int.
11428 * buffer.h (struct buffer.modtime): Now time_t, not int.
11429 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11430 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11431
ccd9a01a
PE
11432 Minor fixes for signed vs unsigned integers.
11433 * character.h (MAYBE_UNIFY_CHAR):
11434 * charset.c (maybe_unify_char):
11435 * keyboard.c (read_char, reorder_modifiers):
11436 XINT -> XFASTINT, since the integer must be nonnegative.
11437 * ftfont.c (ftfont_spec_pattern):
11438 * keymap.c (access_keymap, silly_event_symbol_error):
11439 XUINT -> XFASTINT, since the integer must be nonnegative.
11440 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11441 since it makes no difference and we prefer signed.
11442 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11443 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11444 nonnegative.
11445
d6d100dd
SM
114462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11447
11448 * window.h (Fwindow_frame): Declare.
11449
2b6148e4
PE
114502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11451
11452 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11453 (SPARE_MEMORY): Always define.
11454 (LARGE_REQUEST): Remove.
11455 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11456
f230ecc9
MR
114572011-06-06 Martin Rudalics <rudalics@gmx.at>
11458
727e958e
MR
11459 * lisp.h: Move EXFUNS for Fframe_root_window,
11460 Fframe_first_window and Fset_frame_selected_window to window.h.
11461
11462 * window.h: Move EXFUNS for Fframe_root_window,
11463 Fframe_first_window and Fset_frame_selected_window here from
11464 lisp.h.
11465
11466 * frame.c (Fwindow_frame, Fframe_first_window)
11467 (Fframe_root_window, Fframe_selected_window)
11468 (Fset_frame_selected_window): Move to window.c.
11469 (Factive_minibuffer_window): Move to minibuf.c.
11470 (Fother_visible_frames_p): New function.
11471
11472 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11473
f230ecc9
MR
11474 * window.c (decode_window, decode_any_window): Move up in code.
11475 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11476 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11477 (Fwindow_buffer): Move up and rewrite doc-string.
11478 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11479 (Fwindow_prev): New functions.
727e958e
MR
11480 (Fwindow_frame): Move here from frame.c. Accept any window as
11481 argument.
11482 (Fframe_root_window, Fframe_first_window)
11483 (Fframe_selected_window): Move here from frame.c. Accept frame
11484 or arbitrary window as argument. Update doc-strings.
11485 (Fminibuffer_window): Move up in code.
11486 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11487 (Fset_frame_selected_window): Move here from frame.c.
11488 Marginal rewrite.
727e958e
MR
11489 (Fselected_window, select_window, Fselect_window): Move up in
11490 code. Minor doc-string fixes.
f230ecc9 11491
4d09bcf6
PE
114922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11493
11494 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11495 Do not assume that spare memory exists; that assumption is valid
11496 only if SYSTEM_MALLOC.
11497 (LARGE_REQUEST): New macro, so that the issue of large requests
11498 is separated from the issue of spare memory.
11499
810928a2
AS
115002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11501
172418ad
AS
11502 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11503 format. (Bug#8806)
11504
43f862f7
AS
11505 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11506
810928a2
AS
11507 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11508 before statements.
11509
a059fe24
JD
115102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11511
11512 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11513
11514 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11515
11516 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11517 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11518
989bf368
JB
115192011-06-05 Juanma Barranquero <lekktu@gmail.com>
11520
11521 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11522
4b80f674
CY
115232011-06-04 Chong Yidong <cyd@stupidchicken.com>
11524
11525 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11526 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11527 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11528 New error handlers.
4b80f674
CY
11529 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11530 Obey Vx_select_enable_clipboard_manager. Catch errors in
11531 x_clipboard_manager_save (Bug#8779).
11532 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11533 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11534
99a33b77 115352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11536
11537 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11538
99a33b77 115392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11540
11541 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11542 in the current matrix if keep_current_p is non-zero.
11543
8264569d
EZ
115442011-06-04 Eli Zaretskii <eliz@gnu.org>
11545
11546 * bidi.c (bidi_level_of_next_char): Fix last change.
11547
57f97249
EZ
115482011-06-03 Eli Zaretskii <eliz@gnu.org>
11549
fec2107c 11550 Support bidi reordering of text covered by display properties.
57f97249 11551
fec2107c
EZ
11552 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11553 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11554 (bidi_cache_search, bidi_cache_iterator_state)
11555 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11556 (bidi_level_of_next_char, bidi_move_to_visually_next):
11557 Support character positions inside a run of characters covered by a
fec2107c
EZ
11558 display string.
11559 (bidi_paragraph_init, bidi_resolve_explicit_1)
11560 (bidi_level_of_next_char): Call bidi_fetch_char and
11561 bidi_fetch_char_advance instead of FETCH_CHAR and
11562 FETCH_CHAR_ADVANCE.
11563 (bidi_init_it): Initialize new members.
11564 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11565 definitions.
11566 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11567 instead of using explicit *_CHAR codes.
d6d100dd
SM
11568 (bidi_resolve_explicit, bidi_resolve_weak):
11569 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11570 bidirectional text is supported only in multibyte buffers.
11571 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11572 it to initialize the frame_window_p member of struct bidi_it.
11573 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11574 (bidi_resolve_explicit, bidi_resolve_weak)
11575 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11576 bidi_it->nchars is non-positive.
11577 (bidi_level_of_next_char): Don't try to lookup the cache for the
11578 next/previous character if nothing is cached there yet, or if we
11579 were just reseat()'ed to a new position.
c40e2fb2 11580
0e14fe90
EZ
11581 * xdisp.c (set_cursor_from_row): Set start and stop points
11582 according to the row's direction when priming the loop that looks
11583 for the glyph on which to display cursor.
11584 (single_display_spec_intangible_p): Function deleted.
11585 (display_prop_intangible_p): Reimplement to call
11586 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11587 Accept 3 additional arguments needed by handle_display_spec.
11588 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11589 values: lists, `(when COND...)' forms, etc.
11590 (single_display_spec_string_p): Support property values that are
11591 lists with the argument STRING its top-level element.
11592 (display_prop_string_p): Fix the condition for processing a
11593 property that is a list to be consistent with handle_display_spec.
fec2107c 11594 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11595 last portion of handle_display_prop.
11596 (compute_display_string_pos): Accept additional argument
11597 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11598 value of a `display' property is a "replacing spec".
11599 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11600 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11601 the display property, but just return a value indicating whether
11602 the display property will replace the characters it covers.
11603 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11604 frame_window_p members of struct bidi_it.
d6d100dd
SM
11605 (compute_display_string_pos, compute_display_string_end):
11606 New functions.
fec2107c
EZ
11607 (push_it): Accept second argument POSITION, where pop_it should
11608 jump to continue iteration.
11609 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11610
fec2107c
EZ
11611 * keyboard.c (adjust_point_for_property): Adjust the call to
11612 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11613
11614 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11615 (bidi_init_it): Update prototypes.
11616 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11617 (compute_display_string_pos, compute_display_string_end):
11618 Declare prototypes.
fec2107c
EZ
11619 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11620 EMACS_INT.
fc6f18ce 11621
40087514 116222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11623
57f53182
PE
11624 Malloc failure behavior now depends on size of allocation.
11625 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11626 * lisp.h: Change signatures accordingly.
11627 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11628 All callers changed. (Bug#8762)
11629
11630 * gnutls.c: Use Emacs's memory allocators.
11631 Without this change, the gnutls library would invoke malloc etc.
11632 directly, which causes problems on non-SYNC_INPUT hosts, and which
11633 runs afoul of improving memory_full behavior. (Bug#8761)
11634 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11635 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11636 xfree instead of the default malloc, realloc, free.
11637 (Fgnutls_boot): No need to check for memory allocation failure,
11638 since xmalloc does that for us.
11639
ac32cd99 11640 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11641 * category.c (hash_get_category_set):
11642 * ccl.c (ccl_driver):
11643 * charset.c (Fdefine_charset_internal):
11644 * charset.h (struct charset.hash_index):
11645 * composite.c (get_composition_id, gstring_lookup_cache)
11646 (composition_gstring_put_cache):
11647 * composite.h (struct composition.hash_index):
11648 * dispextern.h (struct image.hash):
11649 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11650 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11651 (hashfn_equal, hashfn_user_defined, make_hash_table)
11652 (maybe_resize_hash_table, hash_lookup, hash_put)
11653 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11654 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11655 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11656 * image.c (make_image, search_image_cache, lookup_image)
11657 (xpm_put_color_table_h):
11658 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11659 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11660 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11661 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11662 * alloc.c (allocate_vectorlike):
11663 Check for overflow in vector size calculations.
11664 * ccl.c (ccl_driver):
11665 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11666 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11667 need to be updated by these changes.
40087514
PE
11668 * fns.c (make_hash_table, maybe_resize_hash_table):
11669 Check for integer overflow with large hash tables.
0de4bb68
PE
11670 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11671 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11672 (SXHASH_REDUCE): New macro.
11673 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11674 Use it instead of discarding useful hash info with large hash values.
11675 (sxhash_float): New function.
11676 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11677 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11678 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11679 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11680 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11681 Adjust signatures to match updated version of code.
11682 (consing_since_gc): Now EMACS_INT, since a single hash table can
11683 use more than INT_MAX bytes.
11684
698d32e2
DN
116852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11686
11687 Make it possible to build with GCC-4.6+ -O2 -flto.
11688
11689 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11690
fd6fa53f
SM
116912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11692
11693 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11694 Call minibuffer-inactive-mode.
11695
864db017
JB
116962011-05-31 Juanma Barranquero <lekktu@gmail.com>
11697
11698 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11699 Update dependencies.
11700
2ad0baf4
DN
117012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11702
11703 * data.c (init_data): Remove code for UTS, this system is not
11704 supported anymore.
11705
4fcc2638
DN
117062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11707
11708 Don't force ./temacs to start in terminal mode.
11709
11710 * frame.c (make_initial_frame): Initialize faces in all cases, not
11711 only when CANNOT_DUMP is defined.
11712 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11713
c56e0fd5
DN
117142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11715
11716 * dispnew.c (add_window_display_history): Use const for the string
11717 pointer. Remove declaration, not needed.
11718
333d54da 117192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11720
55d4c1b2 11721 Use 'inline', not 'INLINE'.
333d54da 11722 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11723 * alloc.c, fontset.c (INLINE): Remove.
11724 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11725 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11726 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11727 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11728 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11729
738db178
DN
117302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11731
11732 Make it possible to run ./temacs.
11733
11734 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11735 syms_of_callproc does the same thing. Remove test for
11736 "initialized", do it in the caller.
11737 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11738
620c53a6
SM
117392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11740
11741 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11742 (read_minibuf): Use get_minibuffer.
11743 (syms_of_minibuf): Use DEFSYM.
11744 (Qmetadata): New var.
11745 * data.c (Qbuffer): Don't make it static.
11746 (syms_of_data): Use DEFSYM.
11747
e003a292
PE
117482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11749
11750 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11751 (CCL_CODE_MIN): New macro.
11752
ed008a6d
PE
117532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11754
3687c2ef
PE
11755 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11756
ed008a6d
PE
11757 * eval.c (Qdebug): Now static.
11758 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11759 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11760 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11761
d66c4c7c
CY
117622011-05-29 Chong Yidong <cyd@stupidchicken.com>
11763
11764 * image.c: Various fixes to ImageMagick code comments.
11765 (Fimagemagick_types): Doc fix.
11766
5fbc2025
PE
117672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11768
0196f88a
PE
11769 Minor fixes prompted by GCC 4.6.0 warnings.
11770
11771 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11772
5fbc2025
PE
11773 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11774 (x_clipboard_manager_save_all): Move extern decl to ...
11775 * xterm.h: ... here, so that it can be checked for consistency.
11776
1dd3c2d9
CY
117772011-05-29 Chong Yidong <cyd@stupidchicken.com>
11778
11779 * xselect.c (x_clipboard_manager_save_frame)
11780 (x_clipboard_manager_save_all): New functions.
11781 (Fx_clipboard_manager_save): Lisp function deleted.
11782
11783 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11784 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11785
11786 * xterm.h: Update prototype.
11787
5ba6571d
WX
117882011-05-28 William Xu <william.xwl@gmail.com>
11789
11790 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11791 exiting (Bug#8239).
11792
3eaff834
JM
117932011-05-28 Jim Meyering <meyering@redhat.com>
11794
e1900994 11795 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11796 * fns.c (to_uchar): Define.
11797 (crypto_hash_function): Use it to convert some newly-signed
11798 variables to unsigned, to avoid sign-extension bugs. For example,
11799 without this change, (md5 "truc") would evaluate to
11800 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11801 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11802 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11803
0f6990a7
PE
118042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11805
11806 Integer overflow fixes.
c8a9ca5a 11807
08686060
PE
11808 * dbusbind.c: Serial number integer overflow fixes.
11809 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11810 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11811 to hold a serial number that is too large for a fixnum.
11812 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11813 Check for serial numbers out of range. Decode any serial number
59568bf0 11814 that was so large that it became a float. (Bug#8722)
08686060 11815
2d1fc3c7
PE
11816 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11817 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11818 Use XFASTINT rather than XUINT when numbers are nonnegative.
11819 (xd_append_arg, Fdbus_method_return_internal):
11820 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11821 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11822 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11823 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11824 (Bug#8722)
2d1fc3c7 11825
c8a9ca5a
PE
11826 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11827
519e1d69
PE
11828 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11829
6df6ae42 11830 ccl: Add integer overflow checks.
30569699
PE
11831 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11832 (IN_INT_RANGE): New macros.
11833 (ccl_driver): Use them to check for integer overflow when
11834 decoding a CCL program. Many of the new checks are whether XINT (x)
11835 fits in int; it doesn't always, on 64-bit hosts. The new version
11836 doesn't catch all possible integer overflows, but it's an
847044ea 11837 improvement. (Bug#8719)
30569699 11838
c11285dc
PE
11839 * alloc.c (make_event_array): Use XINT, not XUINT.
11840 There's no need for unsigned here.
11841
fdccd48e
PE
11842 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11843 This follows up to the 2011-05-06 change that substituted uintptr_t
11844 for EMACS_INT. This case wasn't caught back then.
11845
37910ab2
PE
11846 Rework Fformat to avoid integer overflow issues.
11847 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11848 now (part of C89). Include <verify.h>.
11849 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11850 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11851 (Fformat): Avoid the prepass trying to compute sizes; it was only
11852 approximate and thus did not catch overflow reliably. Instead, walk
11853 through the format just once, formatting and computing sizes as we go,
11854 checking for integer overflow at every step, and allocating a larger
11855 buffer as needed. Keep track separately whether the format is
11856 multibyte. Keep only the most-recently calculated precision, rather
11857 than them all. Record whether each argument has been converted to
11858 string. Use EMACS_INT, not int, for byte and char and arg counts.
11859 Support field widths and precisions larger than INT_MAX. Avoid
11860 sprintf's undefined behavior with conversion specifications such as %#d
11861 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11862 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11863 formatting out-of-range floating point numbers with int
9173deec 11864 formats. (Bug#8668)
37910ab2 11865
2e6578fb
PE
11866 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11867
0ae6bdee
PE
11868 * data.c: Avoid integer truncation in expressions involving floats.
11869 * data.c: Include <intprops.h>.
11870 (arith_driver): When there's an integer overflow in an expression
11871 involving floating point, convert the integers to floating point
11872 so that the resulting value does not suffer from catastrophic
11873 integer truncation. For example, on a 64-bit host (* 4
11874 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11875 Do not rely on undefined behavior after integer overflow.
11876
de883a70
PE
11877 merge count_size_as_multibyte, parse_str_to_multibyte
11878 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11879 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11880 Check for integer overflow.
11881 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11882 since it's now a duplicate of the other. This is more of
11883 a character than a buffer op, so better that it's in character.c.
11884 * fns.c, print.c: Adjust to above changes.
11885
2ff916cb
PE
118862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11887
11888 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11889
f1b54466
PE
118902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11891
fb1ac845
PE
11892 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11893 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11894 (x_clipboard_manager_save): Now static.
11895 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11896
f1b54466
PE
11897 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11898 (crypto_hash_function): Now static.
11899 Fix pointer signedness problems. Avoid unnecessary initializations.
11900
a9f737ee
CY
119012011-05-27 Chong Yidong <cyd@stupidchicken.com>
11902
11903 * termhooks.h (Vselection_alist): Make it terminal-local.
11904
11905 * terminal.c (create_terminal): Initialize it.
11906
11907 * xselect.c: Support for clipboard managers.
11908 (Vselection_alist): Move to termhooks.h as terminal-local var.
11909 (LOCAL_SELECTION): New macro.
11910 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11911 (symbol_to_x_atom): Remove gratuitous arg.
11912 (x_handle_selection_request, lisp_data_to_selection_data)
11913 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11914 (x_own_selection, x_get_local_selection, x_convert_selection):
11915 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11916 (some_frame_on_display): Delete unused function.
11917 (Fx_own_selection_internal, Fx_get_selection_internal)
11918 (Fx_disown_selection_internal, Fx_selection_owner_p)
11919 (Fx_selection_exists_p): New optional frame arg.
11920 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11921 (x_handle_selection_clear): Don't treat other terminals with the
11922 same keyboard specially. Use the terminal-local Vselection_alist.
11923 (x_clear_frame_selections): Use Frun_hook_with_args.
11924
11925 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11926
11927 * xterm.h: Add support for those atoms.
11928
e067f0c1
CY
119292011-05-26 Chong Yidong <cyd@stupidchicken.com>
11930
11931 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11932 (converted_selections, conversion_fail_tag): New global variables.
11933 (x_selection_request_lisp_error): Free the above.
11934 (x_get_local_selection): Remove unnecessary code.
11935 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11936 of converted selections stored in converted_selections.
11937 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11938 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11939 (x_convert_selection): New function.
11940 (x_handle_selection_event): Simplify.
11941 (x_get_foreign_selection): Don't ignore incoming requests while
11942 waiting for an answer; this will fail when we implement
11943 SAVE_TARGETS, and seems unnecessary anyway.
11944 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11945 (Vx_sent_selection_functions): Doc fix.
11946
0f4aebc0
LL
119472011-05-26 Leo Liu <sdl.web@gmail.com>
11948
11949 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11950
e61124cd
YM
119512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11952
11953 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11954
11955 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11956 for fringe update if it has periodic bitmap.
ac389d0c 11957 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11958 and fringe_bitmap_periodic_p.
11959
11960 * fringe.c (get_fringe_bitmap_data): New function.
11961 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11962 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11963 row. Mark glyph row for fringe update if periodicity changed.
11964
11965 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11966 for fringe update unless it has periodic bitmap.
11967
f16d9837
KH
119682011-05-25 Kenichi Handa <handa@m17n.org>
11969
11970 * xdisp.c (get_next_display_element): Set correct it->face_id for
11971 a static composition.
11972
e1b90ef6
LL
119732011-05-24 Leo Liu <sdl.web@gmail.com>
11974
11975 * deps.mk (fns.o):
11976 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11977
11978 * fns.c (crypto_hash_function, Fsha1): New function.
11979 (Fmd5): Use crypto_hash_function.
11980 (syms_of_fns): Add Ssha1.
11981
7400048f
PE
119822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11983
11984 * gnutls.c: Remove unused macros.
11985 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11986 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11987 Remove macros that are defined and never used.
11988 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11989
abb71cf4
CY
119902011-05-22 Chong Yidong <cyd@stupidchicken.com>
11991
11992 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11993 (Fx_get_selection_internal): Minor cleanup.
11994 (Fx_own_selection_internal): Rename arguments for consistency with
11995 select.el.
11996
6307db39
PE
119972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11998
11999 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12000
f3d4e0a4
CY
120012011-05-22 Chong Yidong <cyd@stupidchicken.com>
12002
12003 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12004
4d8ade89
YM
120052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12006
12007 * dispnew.c (scrolling_window): Don't exclude the case that the
12008 last enabled row in the desired matrix touches the bottom boundary.
12009
32078c8d
GM
120102011-05-21 Glenn Morris <rgm@gnu.org>
12011
12012 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12013 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12014 and add some more files.
32078c8d 12015
7285dc67
EZ
120162011-05-20 Eli Zaretskii <eliz@gnu.org>
12017
12018 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12019 report_file_error introduced by the change from 2011-05-07.
12020
89d1bd22
PE
120212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12022
12023 * systime.h (Time): Define only if emacs is defined.
12024 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12025 where the include path doesn't have X11/X.h by default. See
12026 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12027
cd394be1 120282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12029
12030 * composite.c (find_automatic_composition): Fix previous change.
12031
b9704ad9
GM
120322011-05-20 Glenn Morris <rgm@gnu.org>
12033
12034 * lisp.mk: New file, split from Makefile.in.
12035 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12036 (shortlisp): Remove.
12037 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12038
4a720484
GM
120392011-05-19 Glenn Morris <rgm@gnu.org>
12040
12041 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12042 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12043 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12044 (lisp): Set the order to that of loadup.el.
12045 (shortlisp): Make it a copy of $lisp.
12046 (SOME_MACHINE_LISP): Remove.
12047 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12048 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12049
a28d4396
KH
120502011-05-18 Kenichi Handa <handa@m17n.org>
12051
12052 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12053 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12054 (find_automatic_composition): Mostly rewrite for efficiency.
12055
a2b1fa8e
JB
120562011-05-18 Juanma Barranquero <lekktu@gmail.com>
12057
12058 * makefile.w32-in: Update dependencies.
12059
8e1f5610
CS
120602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12061
12062 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12063 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12064
7025ee00 120652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12066
cdfa6eab
PE
12067 Fix some integer overflow issues, such as string length overflow.
12068
06d6db33
PE
12069 * insdel.c (count_size_as_multibyte): Check for string overflow.
12070
2b4560a8
PE
12071 * character.c (lisp_string_width): Check for string overflow.
12072 Use EMACS_INT, not int, for string indexes and lengths; in
12073 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12074 the resulting string length overflows an EMACS_INT; instead,
12075 report a string overflow if no precision given. When checking for
12076 precision exhaustion, use a check that cannot possibly have
12077 integer overflow. (Bug#8675)
12078 * character.h (lisp_string_width): Adjust to new signature.
12079
cb93f9be
PE
12080 * alloc.c (string_overflow): New function.
12081 (Fmake_string): Use it. This doesn't change behavior, but saves
12082 a few bytes and will simplify future changes.
12083 * character.c (string_escape_byte8): Likewise.
12084 * lisp.h (string_overflow): New decl.
12085
1a1f3366
PE
12086 Fixups, following up to the user-interface timestamp change.
12087 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12088 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12089 * msdos.c (mouse_get_pos): Likewise.
12090 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12091 * w32gui.h (Time): Define by including "systime.h" rather than by
12092 declaring it ourselves. (Bug#8664)
12093
d4e3e4d3
PE
12094 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12095 * image.c (clear_image_cache): Likewise.
12096
f6a24d19
PE
12097 * term.c (term_mouse_position): Don't assume time_t wraparound.
12098
08dc5ae6
PE
12099 Be more systematic about user-interface timestamps.
12100 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12101 and sometimes 'EMACS_UINT', to represent these timestamps.
12102 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12103 This makes the code easier to follow, and makes it easier to catch
12104 integer overflow bugs such as Bug#8664.
12105 * frame.c (Fmouse_position, Fmouse_pixel_position):
12106 Use Time, not unsigned long, for user-interface timestamps.
12107 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12108 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12109 * keyboard.h (last_event_timestamp): Likewise.
12110 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12111 * menu.h (xmenu_show): Likewise.
12112 * term.c (term_mouse_position): Likewise.
12113 * termhooks.h (struct input_event.timestamp): Likewise.
12114 (struct terminal.mouse_position_hook): Likewise.
12115 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12116 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12117 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12118 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12119 what it was before.
12120 * menu.h, termhooks.h: Include "systime.h", for Time.
12121
8e55734a
PE
12122 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12123 Don't assume that the difference between two unsigned long values
12124 can fit into an integer. At this point, we know button_down_time
12125 <= event->timestamp, so the difference must be nonnegative, so
12126 there's no need to cast the result if double-click-time is
12127 nonnegative, as it should be; check that it's nonnegative, just in
12128 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12129 apart (about 25 days). (Bug#8664)
8e55734a 12130
841f1b75 12131 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12132 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12133
3e26f69c
PE
12134 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12135 that always fit in int. Use a sentinel instead of a counter, to
12136 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12137 * frame.h (struct frame): Use int for menu_bar_items_used
12138 instead of EMACS_INT, since it always fits in int.
3e26f69c 12139
5cc152c0
PE
12140 * menu.c (grow_menu_items): Check for int overflow.
12141
d89eb65e
PE
12142 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12143
5235bd3e
PE
12144 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12145 Before, the code was not consistent. These values cannot exceed
12146 2**31 - 1 so there's no need to make them unsigned.
12147 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12148 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12149 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12150 as modifiers.
12151 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12152
bc827e23
PE
12153 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12154 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12155 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12156 presumably because the widths might not match.
12157
78eb494e
PE
12158 * window.c (size_window): Avoid needless test at loop start.
12159
04f2d78b
CB
121602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12161
12162 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12163
d2fc7e3d 121642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12165
12166 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12167
d2fc7e3d 121682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12169
12170 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12171 `width' to `bar_area_x' and `bar_area_width', respectively.
12172 (x_scroll_run): Take account of fringe background extension.
12173
04f2d78b
CB
12174 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12175 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12176 `bar_area_width', respectively.
12177 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12178 background extension.
12179
79b70037
GM
121802011-05-10 Jim Meyering <meyering@redhat.com>
12181
12182 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12183
2f142cc5
JB
121842011-05-10 Juanma Barranquero <lekktu@gmail.com>
12185
12186 * image.c (Finit_image_library): Return t for built-in image types,
12187 like pbm and xbm. (Bug#8640)
12188
57679c86
AS
121892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12190
12191 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12192
888c9e86
EZ
121932011-05-07 Eli Zaretskii <eliz@gnu.org>
12194
b0512a1d
EZ
12195 * w32console.c (Fset_screen_color): Doc fix.
12196 (Fget_screen_color): New function.
12197 (syms_of_ntterm): Defsubr it.
12198
7285dc67
EZ
12199 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12200 unlink the temporary file if Fcall_process didn't create it in the
12201 first place.
12202 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12203 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12204 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12205 cue to call_process_cleanup not to close that handle.
12206
4d3fcc8e
BK
122072011-05-07 Ben Key <bkey76@gmail.com>
12208
12209 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12210 one of two shell specific rules, either bootstrap-temacs-CMD or
12211 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12212 to the previous implementation of the bootstrap-temacs rule.
12213 The bootstrap-temacs-CMD rule is similar to the previous
12214 implementation of the bootstrap-temacs rule except that it
12215 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12216 variable.
12217
12218 These changes, along with some changes to nt/configure.bat,
12219 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12220 earlier fix to add support for --cflags and --ldflags options
12221 that include quotes so that it works whether make uses cmd or
12222 sh as the shell.
12223
b4289b64
MA
122242011-05-06 Michael Albinus <michael.albinus@gmx.de>
12225
12226 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12227 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12228 is a constant.
12229 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12230 a string. Handle both cases.
12231 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12232 (Fdbus_register_method): Use Qinvalid_function.
12233
af4c0e28
JB
122342011-05-06 Juanma Barranquero <lekktu@gmail.com>
12235
12236 * makefile.w32-in: Update dependencies.
12237 (LISP_H): Add inttypes.h and stdin.h.
12238 (PROCESS_H): Add unistd.h.
12239
c51453d9
EZ
122402011-05-06 Eli Zaretskii <eliz@gnu.org>
12241
12242 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12243 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12244
8ff0ac3c 122452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12246
4c4b566b
PE
12247 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12248
aab2b9b5
PE
12249 * term.c (vfatal): Remove stray call to va_end.
12250 It's not needed and the C Standard doesn't allow it here anyway.
12251
c378da0b
PE
12252 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12253 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12254
288b08c7
PE
12255 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12256 bytes.
12257
e3601888
PE
12258 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12259
db6c0e74
PE
12260 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12261
dd5963ea
PE
12262 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12263
88c9450f
PE
12264 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12265
2f9442b8
PE
12266 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12267
c032b5f8
PE
12268 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12269 * charset.c (Fdefine_charset_internal): Don't initialize
12270 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12271 32-bit int (Bug#8600).
a108c10b
PE
12272
12273 * lread.c (read_integer): Be more consistent with string-to-number.
12274 Use string_to_number to do the actual conversion; this avoids
12275 rounding errors and fixes some other screwups. Without this fix,
12276 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12277 (digit_to_number): Move earlier, for benefit of read_integer.
12278 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12279 not a digit in any supported base. (Bug#8602)
a108c10b 12280
ad5f9eea
PE
12281 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12282
aec1708a
PE
12283 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12284 to match comment at start of function. This also removes a
12285 GCC warning about overflow in a 32+64-bit port.
12286
47be4ab5
PE
12287 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12288
371cac43
PE
12289 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12290 Reported by Stefan Monnier in
12291 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12292 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12293 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12294
d01a7826
PE
12295 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12296 (EMACS_UINTPTR): Likewise, with uintptr_t.
12297
7fd47d5c
PE
12298 * lisp.h: Prefer 64-bit EMACS_INT if available.
12299 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12300 on 32-bit hosts that have 64-bit int, so that they can access
12301 large files.
122b0c86
PE
12302 However, temporarily disable this change unless the temporary
12303 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12304
8727937b
PE
12305 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12306
8ac068ac
PE
12307 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12308 This removes an assumption that EMACS_INT and long are the same
12309 width as pointers. The assumption is true for Emacs porting targets
12310 now, but we want to make other targets possible.
12311 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12312 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12313 In the rest of the code, change types of integers that hold casted
12314 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12315 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12316 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12317 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12318 No need to cast type when ORing.
12319 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12320 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12321 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12322 assume EMACS_INT is the same width as char *.
12323 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12324 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12325 Remove no-longer-needed casts.
12326 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12327 (xg_tool_bar_help_callback, xg_make_tool_item):
12328 Use EMACS_INTPTR to hold an integer
12329 that will be cast to void *; this can avoid a GCC warning
12330 if EMACS_INT is not the same width as void *.
12331 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12332 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12333 (current_message_1, set_message_1):
12334 Use a local to convert to proper width without a cast.
12335 * xmenu.c (dialog_selection_callback): Likewise.
12336
ede49d71
PE
12337 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12338 Also, don't assume VALBITS / RAND_BITS is less than 5,
12339 and don't rely on undefined behavior when shifting a 1 left into
12340 the sign bit.
12341 * lisp.h (get_random): Change signature to match.
12342
2f30ecd0
PE
12343 * lread.c (hash_string): Use size_t, not int, for hash computation.
12344 Normally we prefer signed values; but hashing is special, because
12345 it's better to use unsigned division on hash table sizes so that
12346 the remainder is nonnegative. Also, size_t is the natural width
12347 for hashing into memory. The previous code used 'int', which doesn't
12348 retain enough info to hash well into very large tables.
12349 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12350
2a866e7b
PE
12351 * dbusbind.c: Don't possibly lose pointer info when converting.
12352 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12353 Use XPNTR rather than XHASH, so that the high-order bits of
12354 the pointer aren't lost when converting through void *.
12355
51639eac
PE
12356 * eval.c (Fautoload): Don't double-shift a pointer.
12357
92394119
PE
12358 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12359
dbdb9a7c
JB
123602011-05-06 Juanma Barranquero <lekktu@gmail.com>
12361
12362 * gnutls.c (DEF_GNUTLS_FN):
12363 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12364
db7a0b4f
AS
123652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12366
12367 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12368 marker. (Bug#8610)
12369
cd394be1 123702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12371
12372 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12373 New version that can reserve upto 2GB of heap space.
12374
f7ff1b0f 123752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12376
12377 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12378
639c109b
TZ
123792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12380
12381 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12382 `gnutls_certificate_set_x509_key_file'.
12383
d2127135
JB
123842011-05-05 Juanma Barranquero <lekktu@gmail.com>
12385
12386 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12387 Update dependencies.
12388
e968f4f3
JB
123892011-05-04 Juanma Barranquero <lekktu@gmail.com>
12390
12391 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12392 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12393 Remove unused parameter `fildes'.
12394 * process.c (read_process_output, send_process): Don't pass it.
12395
84d358f0
JB
123962011-05-04 Juanma Barranquero <lekktu@gmail.com>
12397
12398 Fix previous change: the library cache is defined in w32.c.
12399 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12400 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12401
0898ca10
JB
124022011-05-04 Juanma Barranquero <lekktu@gmail.com>
12403
12404 Implement dynamic loading of GnuTLS on Windows.
12405
12406 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12407 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12408 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12409 Declare.
12410
12411 * gnutls.c (Qgnutls_dll): Define.
12412 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12413 (gnutls_*): Declare function pointers.
12414 (init_gnutls_functions): New function to initialize function pointers.
12415 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12416 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12417 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12418 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12419 (emacs_gnutls_write, emacs_gnutls_read)
12420 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12421 (Fgnutls_available_p): New function.
12422 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12423 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12424 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12425
12426 * image.c: Include w32.h.
12427 (Vimage_type_cache): Delete.
12428 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12429 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12430 (w32_delayed_load): Move to w32.c.
12431
12432 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12433
12434 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12435 (w32_delayed_load): Move from image.c. When loading a library, record
12436 its filename in the :loaded-from property of the library id.
12437 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12438 Initialize and staticpro them.
12439 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12440
12441 * process.c: Include lisp.h before w32.h, not after.
12442 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12443 instead of gnutls_record_check_pending.
12444
12445 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12446
ff4de4aa
TZ
124472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12448
12449 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12450 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12451 as passed in.
12452
abe95abb
JD
124532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12454
12455 * xterm.c (x_set_frame_alpha): Do not set property on anything
12456 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12457
e16e55d4
JB
124582011-05-02 Juanma Barranquero <lekktu@gmail.com>
12459
12460 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12461
bafcf6a5
JB
124622011-05-02 Juanma Barranquero <lekktu@gmail.com>
12463
12464 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12465 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12466 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12467 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12468 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12469 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12470 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12471 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12472 (Qgnutls_bootprop_callbacks_verify): Make static.
12473
e7a6747f
AS
124742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12475
19ed11ba
AS
12476 * callproc.c: Indentation fixup.
12477
e7a6747f 12478 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12479 (wait_for_termination, interruptible_wait_for_termination):
12480 Move after wait_for_termination_1.
e7a6747f 12481
1ef14cb4
LMI
124822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12483
12484 * sysdep.c (interruptible_wait_for_termination): New function
12485 which is like wait_for_termination, but allows keyboard
12486 interruptions.
12487
12488 * callproc.c (Fcall_process): Add (:file "file") as an option for
12489 the STDOUT buffer.
12490 (Fcall_process_region): Ditto.
12491
330d880c
EZ
124922011-04-30 Eli Zaretskii <eliz@gnu.org>
12493
8db90b73
EZ
12494 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12495 rather than `XVECTOR (FOO)->size'.
12496
330d880c
EZ
12497 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12498 inttypes.h, as a gnulib replacement is used if it not available in
12499 system headers.
12500
15cbd324
EZ
125012011-04-21 Eli Zaretskii <eliz@gnu.org>
12502
12503 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12504 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12505 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12506
12507 * coding.c (coding_alloc_by_realloc): Error out if destination
12508 will grow beyond MOST_POSITIVE_FIXNUM.
12509 (decode_coding_emacs_mule): Abort if there isn't enough place in
12510 charbuf for the composition carryover bytes. Reserve an extra
12511 space for up to 2 characters produced in a loop.
12512 (decode_coding_iso_2022): Abort if there isn't enough place in
12513 charbuf for the composition carryover bytes.
12514
125152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12516
ae940cca
EZ
12517 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12518 aborting when %lld or %lll format is passed.
12519 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12520 %llo or %llx format is passed. (Bug#8545)
12521
03ab8921
EZ
12522 * window.c (window_scroll_line_based): Use a marker instead of
12523 simple variables to record original value of point. (Bug#7952)
12524
afda1437
EZ
12525 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12526 produced by %s or %c overflows available buffer space. (Bug#8545)
12527
f76dee0c
PE
125282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12529
12530 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12531 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12532
fdc5744d
JB
125332011-04-28 Juanma Barranquero <lekktu@gmail.com>
12534
12535 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12536
638f053a
JB
125372011-04-28 Juanma Barranquero <lekktu@gmail.com>
12538
12539 * keyboard.c (Qdelayed_warnings_hook): Define.
12540 (command_loop_1): Run `delayed-warnings-hook'
12541 if Vdelayed_warnings_list is non-nil.
12542 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12543 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12544
d178f871
EZ
125452011-04-28 Eli Zaretskii <eliz@gnu.org>
12546
12547 * doprnt.c (doprnt): Don't return value smaller than the buffer
12548 size if the message was truncated. (Bug#8545).
12549
b124fd93
JB
125502011-04-28 Juanma Barranquero <lekktu@gmail.com>
12551
12552 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12553 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12554
e810457d
PE
125552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12556
12557 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12558
ea51cceb
JB
125592011-04-27 Juanma Barranquero <lekktu@gmail.com>
12560
12561 * makefile.w32-in: Update dependencies.
12562
94dcfacf
EZ
125632011-04-27 Eli Zaretskii <eliz@gnu.org>
12564
12565 Improve `doprnt' and its usage. (Bug#8545)
12566 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12567 `format_end'. Remove support for %l as a conversion specifier.
12568 Don't use xrealloc. Improve diagnostics when the %l size modifier
12569 is used. Update the commentary.
12570
12571 * eval.c (verror): Simplify calculation of size_t.
12572
12573 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12574 messages.
12575
f61f41d7
PE
125762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12577
12578 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12579 change.
12580
96fb4434
PE
125812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12582
12583 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12584 This makes this file independent of the recent pseudovector change.
12585
671875da 125862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12587
69e9b5a3
PE
12588 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12589
b5f869a7 12590 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12591 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12592 Remove unused local.
c8926152 12593 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12594
841a1577 12595 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12596 GCC 4.6.0 optimizes based on type-based alias analysis.
12597 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12598 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12599 != &v->size, and therefore "v->size = 1; b->size = 2; return
12600 v->size;" must therefore return 1. This assumption is incorrect
12601 for Emacs, since it type-puns struct Lisp_Vector * with many other
12602 types. To fix this problem, this patch adds a new type struct
f904488f 12603 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12604 and pseudovectors, and helps optimizing compilers not get fooled
12605 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12606 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12607 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12608 the size member.
eab3844f
PE
12609 (XSETPVECTYPE): Rewrite in terms of new macro.
12610 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12611 This is a bit clearer, and further avoids the possibility of
12612 undesirable aliasing.
12613 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12614 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12615 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12616 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12617 (ASIZE): Now uses header.size rather than size.
12618 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12619 to avoid the hassle of writing XVECTOR (foo)->header.size.
12620 (struct vectorlike_header): New type.
eab3844f
PE
12621 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12622 object, to help avoid aliasing.
12623 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12624 (SUBRP): Likewise, since Lisp_Subr is a special case.
12625 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12626 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12627 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12628 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12629 changed to be "header.size" and "header.next".
12630 * buffer.h (struct buffer): Likewise.
12631 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12632 * frame.h (struct frame): Likewise.
12633 * process.h (struct Lisp_Process): Likewise.
12634 * termhooks.h (struct terminal): Likewise.
12635 * window.c (struct save_window_data, struct saved_window): Likewise.
12636 * window.h (struct window): Likewise.
12637 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12638 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12639 * buffer.c (init_buffer_once): Likewise.
12640 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12641 special case.
12642 * process.c (Fformat_network_address): Use local var for size,
12643 for brevity.
12644
0df1eac5
PE
12645 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12646
847ab9d1 12647 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12648 * data.c (atof): Remove decl; no longer used or needed.
12649 (digit_to_number): Move to lread.c.
12650 (Fstring_to_number): Use new string_to_number function, to be
12651 consistent with how the Lisp reader treats infinities and NaNs.
12652 Do not assume that floating-point numbers represent EMACS_INT
12653 without losing information; this is not true on most 64-bit hosts.
12654 Avoid double-rounding errors, by insisting on integers when
12655 parsing non-base-10 numbers, as the documentation specifies.
12656 * lisp.h (string_to_number): New decl, replacing ...
12657 (isfloat_string): Remove.
bc0a5c13 12658 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12659 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12660 appears to have been a coding error. Similarly, do not accept
12661 strings like +-1e0 as floating point numbers. Do not report
12662 overflow for integer overflows unless the base is not 10 which
12663 means we have no simple and reliable way to continue.
12664 Break out the floating-point parsing into a new
12665 function string_to_number, so that Fstring_to_number parses
12666 floating point numbers consistently with the Lisp reader.
04f2d78b 12667 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12668 (E_CHAR, EXP_INT): Remove, replacing with ...
12669 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12670 (string_to_number): New function, replacing isfloat_string.
12671 This function checks for valid syntax and produces the resulting
12672 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12673 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12674 so that overflow for non-base-10 numbers is reported only when
12675 there's no portable and simple way to convert to floating point.
452f4150 12676
67769ffc
PE
12677 * textprop.c (set_text_properties_1): Rewrite for clarity,
12678 and to avoid GCC warning about integer overflow.
12679
c20db43f
PE
12680 * intervals.h (struct interval): Use EMACS_INT for members
12681 where EMACS_UINT might cause problems. See
12682 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12683 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12684 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12685 All uses changed.
37aa2f85
PE
12686 (offset_intervals): Tell GCC not to worry about length overflow
12687 when negating a negative length.
c20db43f 12688
2538aa2f
PE
12689 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12690 (overrun_check_free): Likewise.
12691
f2d3008d
PE
12692 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12693 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12694 word size.
12695
ec8df744
PE
12696 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12697 (gnutls_make_error): Rename local to avoid shadowing.
12698 (gnutls_emacs_global_deinit): ifdef out; not used.
12699 (Fgnutls_boot): Use const for pointer to readonly storage.
12700 Comment out unused local. Fix pointer signedness problems.
12701
640ee02d
PE
12702 * lread.c (openp): Don't stuff size_t into an 'int'.
12703 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12704 about possible signed overflow.
12705
6048fb2a
PE
12706 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12707 (GDK_KEY_g): Don't define if already defined.
12708 (xg_prepare_tooltip): Avoid pointer signedness problem.
12709 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12710
fa3c87e1
PE
12711 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12712 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12713
2172544b
PE
12714 * xfns.c (Fx_window_property): Simplify a bit,
12715 to make a bit faster and to avoid GCC 4.6.0 warning.
12716 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12717
9b821a21
PE
12718 * fns.c (internal_equal): Don't assume size_t fits in int.
12719
3c616cfa
PE
12720 * alloc.c (compact_small_strings): Tighten assertion a little.
12721
c2982e87
PE
12722 Replace pEd with more-general pI, and fix some printf arg casts.
12723 * lisp.h (pI): New macro, generalizing old pEd macro to other
12724 conversion specifiers. For example, use "...%"pI"d..." rather
12725 than "...%"pEd"...".
12726 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12727 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12728 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12729 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12730 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12731 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12732 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12733 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12734 64-bit hosts.
12735 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12736 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12737 * print.c (safe_debug_print, print_object): Likewise.
12738 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12739 to int.
6f04d126
PE
12740 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12741 avoiding the 0 flag, which is not portable.
c2982e87
PE
12742 * process.c (Fmake_network_process): Use pI to avoid cast.
12743 * region-cache.c (pp_cache): Likewise.
12744 * xdisp.c (decode_mode_spec): Likewise.
12745 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12746 behavior on 64-bit hosts with printf arg.
6f04d126 12747 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12748 (x_stop_queuing_selection_requests): Likewise.
12749 (x_get_window_property): Don't truncate byte count to an 'int'
12750 when tracing.
0b432f21 12751
5e073ec7
PE
12752 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12753 here, since it parses constructs like leading '-' and spaces,
12754 which are not wanted; and it overflows with large numbers.
12755 Instead, simply match F[0-9]+, which is what is wanted anyway.
12756
36372bf9
PE
12757 * alloc.c: Remove unportable assumptions about struct layout.
12758 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12759 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12760 (allocate_vectorlike, make_pure_vector): Use the new macros,
12761 plus offsetof, to remove unportable assumptions about struct layout.
12762 These assumptions hold on all porting targets that I know of, but
12763 they are not guaranteed, they're easy to remove, and removing them
12764 makes further changes easier.
12765
0b432f21
PE
12766 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12767 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12768 (string_overrun_cookie): Now const. Use initializers that
12769 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12770 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12771 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12772 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12773 multiple of sizeof (EMACS_INT); it need not be, if
12774 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12775 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12776
895009e1
JB
127772011-04-26 Juanma Barranquero <lekktu@gmail.com>
12778
12779 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12780
6a7a1b0b
TZ
127812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12782
12783 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12784 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12785 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12786
841a1577 127872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12788
12789 * lisp.h (Qdebug): List symbol.
895009e1 12790 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12791 * keyboard.c (debug-on-event): New variable.
12792 (handle_user_signal): Break into debugger when debug-on-event
12793 matches the current signal symbol.
12794
f2d3ba6f
DN
127952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12796
12797 * alloc.c (check_sblock, check_string_bytes)
12798 (check_string_free_list): Convert to standard C.
12799
42ce4c63
TZ
128002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12801
12802 * w32.c (emacs_gnutls_push): Fix typo.
12803
825cd63c
EZ
128042011-04-25 Eli Zaretskii <eliz@gnu.org>
12805
fb11d64d
EZ
12806 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12807 "cast to pointer from integer of different size".
12808
825cd63c
EZ
12809 Improve doprnt and its use in verror. (Bug#8545)
12810 * doprnt.c (doprnt): Document the set of format control sequences
12811 supported by the function. Use SAFE_ALLOCA instead of always
12812 using `alloca'.
12813
12814 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12815 is one byte too soon. Don't use xrealloc; instead xfree and
12816 xmalloc anew.
12817
e061a11b
TZ
128182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12819
12820 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12821 callbacks stage.
12822
12823 * gnutls.c: Renamed global_initialized to
12824 gnutls_global_initialized. Added internals for the
12825 :verify-hostname-error, :verify-error, and :verify-flags
12826 parameters of `gnutls-boot' and documented those parameters in the
12827 docstring. Start callback support.
9173deec
JB
12828 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12829 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12830 on error. Return error code.
e061a11b
TZ
12831 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12832 (emacs_gnutls_read): Likewise.
12833 (Fgnutls_boot): Return handshake error code.
12834 (emacs_gnutls_handle_error): New function.
12835 (wsaerror_to_errno): Likewise.
12836
12837 * w32.h (emacs_gnutls_pull): Add prototype.
12838 (emacs_gnutls_push): Likewise.
12839
12840 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12841 (emacs_gnutls_push): Likewise.
12842
128432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12844
12845 * process.c (wait_reading_process_output): Check if GnuTLS
12846 buffered some data internally if no FDs are set for TLS
12847 connections.
12848
12849 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12850 (LIBS): Link to USER_LIBS.
12851 ($(BLD)/gnutls.$(0)): New target.
12852
fa6996bc
EZ
128532011-04-24 Eli Zaretskii <eliz@gnu.org>
12854
eb35682e
EZ
12855 * xdisp.c (handle_single_display_spec): Rename the
12856 display_replaced_before_p argument into display_replaced_p, to
12857 make it consistent with the commentary. Fix typos in the
12858 commentary.
12859
e2ad650c
EZ
12860 * textprop.c (syms_of_textprop): Remove dead code.
12861 (copy_text_properties): Delete obsolete commentary about an
12862 interface that was deleted long ago. Fix typos in the description
12863 of arguments.
12864
1b2de274
EZ
12865 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12866 to changes in oldXMenu/XMenu.h from 2011-04-16.
12867 <menu_help_message, prev_menu_help_message>: Constify.
12868 (IT_menu_make_room): menu->help_text is now `const char **';
12869 adjust.
12870
12871 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12872 to changes in oldXMenu/XMenu.h from 2011-04-16.
12873 (struct XMenu): Declare `help_text' `const char **'.
12874
12875 * xfaces.c <Qunspecified>: Make extern again.
12876
12877 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12878 required by POSIX.
1b2de274 12879
762b15be
EZ
12880 * doc.c (get_doc_string): Improve the format passed to `error'.
12881
12882 * doprnt.c (doprnt): Improve commentary.
12883
12884 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12885
12886 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12887 them with etags.
12888
f1052e5d
EZ
12889 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12890 changes in globals.h immediately force recompilation.
762b15be
EZ
12891 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12892 $(CURDIR)/s/ms-w32.h.
12893 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12894
fa6996bc
EZ
12895 * character.c (Fchar_direction): Function deleted.
12896 (syms_of_character): Don't defsubr it.
12897 <char-direction-table>: Deleted.
12898
e6c3da20
EZ
128992011-04-23 Eli Zaretskii <eliz@gnu.org>
12900
12901 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12902 * doprnt.c: Include limits.h.
12903 (SIZE_MAX): New macro.
04f2d78b
CB
12904 (doprnt): Return a size_t value. 2nd arg is now size_t.
12905 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12906 Improve overflow protection. Support `l' modifier for integer
12907 conversions. Support %l conversion. Don't assume an EMACS_INT
12908 argument for integer conversions and for %c.
12909
12910 * lisp.h (doprnt): Restore prototype.
12911
12912 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12913 $(SRC)/character.h.
12914
12915 * Makefile.in (base_obj): Add back doprnt.o.
12916
12917 * deps.mk (doprnt.o): Add back prerequisites.
12918 (callint.o): Depend on character.h.
12919
12920 * eval.c (internal_lisp_condition_case): Include the handler
12921 representation in the error message.
12922 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12923 when breaking from the loop.
12924
12925 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12926
12927 * callint.c (Fcall_interactively): When displaying error message
12928 about invalid control letter, pass the character's codepoint, not
12929 a pointer to its multibyte form. Improve display of the character
12930 in octal and display also its hex code.
12931
12932 * character.c (char_string): Use %x to display the (unsigned)
12933 codepoint of an invalid character, to avoid displaying a bogus
12934 negative value.
12935
12936 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12937 `error', not SYMBOL_NAME itself.
12938
12939 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12940 character arguments to `error'.
12941
12942 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12943 to `error' in error message about FINAL_CHAR argument. Make sure
12944 FINAL_CHAR is a character, and use %c when it is passed as
12945 argument to `error'.
12946
4ffd0d6b 129472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12948
12949 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12950
12951 * w32.c: Include <time.h>.
12952 (sys_localtime): New function.
12953
4ffd0d6b 129542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12955
12956 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12957
4ffd0d6b 12958 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12959
4ffd0d6b 129602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12961
4ffd0d6b
GM
12962 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12963 zombies (Bug#8467).
aac0c6e3 12964
04c56954
EZ
129652011-04-19 Eli Zaretskii <eliz@gnu.org>
12966
12967 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12968 gl_state.e_property when gl_state.object is Qt.
12969
12970 * insdel.c (make_gap_larger): Remove limitation of buffer size
12971 to <= INT_MAX.
12972
16a43933
CY
129732011-04-18 Chong Yidong <cyd@stupidchicken.com>
12974
12975 * xdisp.c (lookup_glyphless_char_display)
12976 (produce_glyphless_glyph): Handle cons cell entry in
12977 glyphless-char-display.
12978 (Vglyphless_char_display): Document it.
12979
12980 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12981 glyphless-char-display.
12982
4581706e
CY
129832011-04-17 Chong Yidong <cyd@stupidchicken.com>
12984
12985 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12986
12987 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12988
12989 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12990 definition for no-X builds.
12991
4887c6e2 129922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12993
fd35b6f9
PE
12994 Static checks with GCC 4.6.0 and non-default toolkits.
12995
5c1ccb01
PE
12996 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12997
006c5daa
PE
12998 * process.c (keyboard_bit_set): Define only if SIGIO.
12999 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13000 (send_process): Repair possible setjmp clobbering.
13001
efc736d3
PE
13002 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13003
4e2fe2e6
PE
13004 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13005
f97334a2
PE
13006 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13007
4e75f29d
PE
13008 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13009 Define only if needed.
13010
90efadd1
PE
13011 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13012 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13013 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13014
3c647824
PE
13015 * dispextern.h (struct redisplay_interface): Rename param
13016 to avoid shadowing.
e264f262 13017 * termhooks.h (struct terminal): Likewise.
761383f4 13018 * xterm.c (xembed_send_message): Likewise.
3c647824 13019
b58c5c4a
PE
13020 * insdel.c (make_gap_smaller): Define only if
13021 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13022
cad59032
PE
13023 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13024 it.
13025
c339dc2e
PE
13026 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13027 so that we aren't warned about unused symbols.
13028
91a3e27b
PE
13029 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13030
399c71d3 13031 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13032
8ffc96f5
PE
13033 * xfns.c (x_real_positions): Mark locals as initialized.
13034
eef9bc79
PE
13035 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13036
098db9dd
PE
13037 * xterm.c: Fix problems found by static analysis with other toolkits.
13038 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13039 (x_dispatch_event): Declare static if USE_GTK, and
13040 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13041 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13042 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13043 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13044 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13045
eb18f6cc
PE
13046 * xmenu.c (menu_help_callback): Pointer type fixes.
13047 Use const pointers when pointing at readonly data. Avoid pointer
13048 signedness clashes.
13049 (FALSE): Remove unused macro.
13050 (update_frame_menubar): Remove unused decl.
13051
1fe72bf8
PE
13052 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13053
60d9e1db
PE
13054 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13055 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13056 (single_menu_item): Rename local to avoid shadowing.
13057
39261c26
PE
13058 * keyboard.c (make_lispy_event): Remove unused local var.
13059
018c5e19
PE
13060 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13061 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13062
63d2b86e
PE
13063 * bitmaps: Change bitmaps from unsigned char back to the X11
13064 compatible char. Avoid the old compiler warnings about
13065 out-of-range initializers by using, for example, '\xab' rather
13066 than 0xab.
13067
aefd87e1
PE
13068 * xgselect.c (xgselect_initialize): Check vs interface
13069 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13070
bf501fb9
PE
13071 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13072
e9829fdf
PE
13073 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13074 to read-only memory.
13075
1086c095
PE
13076 * fns.c (vector): Remove; this old hack is no longer needed.
13077
2baccd04 13078 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13079 Remove unused var.
dde42981 13080 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13081
72391843 13082 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13083
436c16df 13084 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13085 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13086 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13087
92bb796d 13088 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13089 (x_term_init): Remove local to avoid shadowing.
92bb796d 13090
764430a3 13091 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13092
13093 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13094 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13095
d1dfb56c
EZ
130962011-04-16 Eli Zaretskii <eliz@gnu.org>
13097
c4354cb4
EZ
13098 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13099
d1dfb56c
EZ
13100 Fix regex.c, syntax.c and friends for buffers > 2GB.
13101 * syntax.h (struct gl_state_s): Declare character position members
13102 EMACS_INT.
13103
13104 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13105
04f2d78b
CB
13106 * textprop.c (verify_interval_modification, interval_of):
13107 Declare arguments EMACS_INT.
d1dfb56c
EZ
13108
13109 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13110 EMACS_INT.
13111
13112 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13113
13114 * indent.c (Fvertical_motion): Local variable it_start is now
13115 EMACS_INT.
13116
13117 * regex.c (re_match, re_match_2, re_match_2_internal)
13118 (bcmp_translate, regcomp, regexec, print_double_string)
13119 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13120 (re_compile_pattern, re_exec): Declare arguments and local
13121 variables `size_t' and `ssize_t' and return values `regoff_t', as
13122 appropriate.
13123 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13124 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13125 <compile_stack_type>: `size' and `avail' are now `size_t'.
13126
13127 * regex.h <regoff_t>: Use ssize_t, not int.
13128 (re_search, re_search_2, re_match, re_match_2): Arguments that
13129 specify buffer/string position and length are now ssize_t and
13130 size_t. Return type is regoff_t.
13131
613052cd
BK
131322011-04-16 Ben Key <bkey76@gmail.com>
13133
13134 * nsfont.m: Fixed bugs in ns_get_family and
13135 ns_descriptor_to_entity that were caused by using free to
13136 deallocate memory blocks that were allocated by xmalloc (via
13137 xstrdup). This caused Emacs to crash when compiled with
13138 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13139 --enable-checking=xmallocoverrun). xfree is now used to
13140 deallocate these memory blocks.
13141
4170f62f 131422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13143
71b41406
PE
13144 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13145
9587a89d
PE
13146 emacs_write: Accept and return EMACS_INT for sizes.
13147 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13148 et seq.
13149 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13150 Accept and return EMACS_INT.
13151 (emacs_gnutls_write): Return the number of bytes written on
13152 partial writes.
13153 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13154 (emacs_read, emacs_write): Remove check for negative size, as the
13155 Emacs source code has been audited now.
9587a89d
PE
13156 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13157 (emacs_read, emacs_write): Use it.
273a5f82
PE
13158 * process.c (send_process): Adjust to the new signatures of
13159 emacs_write and emacs_gnutls_write. Do not attempt to store
13160 a byte offset into an 'int'; it might overflow.
9587a89d 13161 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13162
3e047f51
PE
13163 * sound.c: Don't assume sizes fit in 'int'.
13164 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13165 Return EMACS_INT, not int.
3e047f51 13166 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13167 Accept EMACS_INT, not int.
13168 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13169 record read return values.
13170
cc39a9db
BK
131712011-04-15 Ben Key <bkey76@gmail.com>
13172
c9d0ec6d
JB
13173 * keyboard.c (Qundefined): Don't declare static since it is used
13174 in nsfns.m.
13175 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13176 static since they are used in nsfont.m.
cc39a9db 13177
6c60eb9f
SM
131782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13179
13180 * process.c (Qprocessp): Don't declare static.
13181 * lisp.h (Qprocessp): Declare again.
13182
7990b61a
JB
131832011-04-15 Juanma Barranquero <lekktu@gmail.com>
13184
13185 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13186
5d4cb038
PE
131872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13188
8bd7b830 13189 Improve C-level modularity by making more things 'static'.
cd64ea1d 13190
e3b27b31
PE
13191 Don't publish debugger-only interfaces to other modules.
13192 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13193 (verify_bytepos, count_markers): Move decls to the only modules
13194 that need them.
13195 * region-cache.h (pp_cache): Likewise.
13196 * window.h (check_all_windows): Likewise.
13197 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13198
5d4cb038
PE
13199 * sysdep.c (croak): Now static, if
13200 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13201 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13202
13203 * alloc.c (refill_memory_reserve): Now static if
13204 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13205 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13206
e87b6180
PE
13207 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13208 Define only if USE_LUCID.
13209
ac64929e
PE
13210 * xrdb.c (x_customization_string, x_rm_string): Now static.
13211
6f37259d
PE
13212 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13213 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13214
1683e3ab
PE
13215 * xdisp.c (draw_row_with_mouse_face): Now static.
13216 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13217
de9c2632
PE
13218 * window.h (check_all_windows): Mark externally visible.
13219
2b96acb7
PE
13220 * window.c (window_deletion_count): Now static.
13221
13222 * undo.c: Make symbols static if they're not exported.
13223 (last_undo_buffer, last_boundary_position, pending_boundary):
13224 Now static.
13225
50436f33
PE
13226 * textprop.c (interval_insert_behind_hooks): Now static.
13227 (interval_insert_in_front_hooks): Likewise.
13228
64520e5c
PE
13229 * term.c: Make symbols static if they're not exported.
13230 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13231 (max_frame_lines, tty_set_terminal_modes):
13232 (tty_reset_terminal_modes, tty_turn_off_highlight):
13233 (get_tty_terminal): Now static.
13234 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13235 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13236 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13237 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13238 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13239
1fa53021
PE
13240 * sysdep.c: Make symbols static if they're not exported.
13241 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13242 Now static.
13243 (sigprocmask_set, full_mask): Remove; unused.
13244 (wait_debugging): Mark as visible.
13245 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13246 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13247
d4b43b22
PE
13248 * syntax.c (syntax_temp): Define only if !__GNUC__.
13249
b7c513d0
PE
13250 * sound.c (current_sound_device, current_sound): Now static.
13251
989b29ad
PE
13252 * search.c (searchbufs, searchbuf_head): Now static.
13253
13a55a78
PE
13254 * scroll.c (scroll_cost): Remove; unused.
13255 * dispextern.h (scroll_cost): Remove decl.
13256
de68a1fc
PE
13257 * region-cache.h (pp_cache): Mark as externally visible.
13258
40ccffa6
PE
13259 * process.c: Make symbols static if they're not exported.
13260 (process_tick, update_tick, create_process, chan_process):
13261 (Vprocess_alist, proc_buffered_char, datagram_access):
13262 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13263 (deactivate_process): Mark defn as static, as well as decl.
13264 * lisp.h (create_process): Remove decl.
13265 * process.h (chan_process, Vprocess_alist): Remove decls.
13266
ad64fc97
PE
13267 * print.c: Make symbols static if they're not exported.
13268 (print_depth, new_backquote_output, being_printed, print_buffer):
13269 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13270 (print_interval, print_number_index, initial_stderr_stream):
13271 Now static.
13272 * lisp.h (Fprinc): Remove decl.
13273 (debug_output_compilation_hack): Mark as externally visible.
13274
adddb265
PE
13275 * sysdep.c (croak): Move decl from here to syssignal.h.
13276 * syssignal.h (croak): Put it here, so the API can be checked when
13277 'croak' is called from dissociate_if_controlling_tty.
13278
1717ede2
PE
13279 * minibuf.c: Make symbols static if they're not exported.
13280 (minibuf_save_list, choose_minibuf_frame): Now static.
13281 * lisp.h (choose_minibuf_frame): Remove decl.
13282
fa5fb2bc
PE
13283 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13284
1e3890d1
PE
13285 * lread.c: Make symbols static if they're not exported.
13286 (read_objects, initial_obarray, oblookup_last_bucket_number):
13287 Now static.
13288 (make_symbol): Remove; unused.
13289 * lisp.h (initial_obarray, make_symbol): Remove decls.
13290
8a1414fa
PE
13291 * keyboard.c: Make symbols static if they're not exported.
13292 (single_kboard, recent_keys_index, total_keys, recent_keys):
13293 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13294 (this_single_command_key_start, echoing, last_auto_save):
13295 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13296 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13297 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13298 (Vlispy_mouse_stem, double_click_count):
13299 Now static.
13300 (force_auto_save_soon): Define only if SIGDANGER.
13301 (ignore_mouse_drag_p): Now static if
13302 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13303 (print_help): Remove; unused.
13304 (stop_character, last_timer_event): Mark as externally visible.
13305 * keyboard.h (ignore_mouse_drag_p): Declare only if
13306 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13307 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13308 * lisp.h (echoing): Remove decl.
13309 (force_auto_save_soon): Declare only if SIGDANGER.
13310 * xdisp.c (redisplay_window): Simplify code, to make it more
13311 obvious that ignore_mouse_drag_p is not accessed if !defined
13312 USE_GTK && !defined HAVE_NS.
13313
93ea6e8f
PE
13314 * intervals.c: Make symbols static if they're not exported.
13315 (merge_properties_sticky, merge_interval_right, delete_interval):
13316 Now static.
13317 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13318
77382fcc
PE
13319 * insdel.c: Make symbols static if they're not exported.
13320 However, leave prepare_to_modify_buffer alone. It's never
13321 called from outside this function, but that appears to be a bug.
13322 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13323 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13324 (adjust_after_replace_noundo): Remove; unused.
13325 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13326 (signal_before_change): Remove decls.
77382fcc 13327
9306c32e
PE
13328 * indent.c (val_compute_motion, val_vmotion): Now static.
13329
cd44d2eb
PE
13330 * image.c: Make symbols static if they're not exported.
13331 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13332 if USE_GTK.
13333 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13334 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13335
ad9a7a06
PE
13336 * fringe.c (standard_bitmaps): Now static.
13337 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13338
81626931
PE
13339 * frame.c: Make symbols static if they're not exported.
13340 (x_report_frame_params, make_terminal_frame): Now static.
13341 (get_frame_param): Now static, unless HAVE_NS.
13342 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13343 (x_get_resource_string): Remove; not used.
13344 * frame.h (make_terminal_frame, x_report_frame_params):
13345 (x_get_resource_string); Remove decls.
13346 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13347 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13348
239f9db9
PE
13349 * font.c, fontset.c: Make symbols static if they're not exported.
13350 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13351 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13352 * font.c (font_close_object): Now static.
13353 * font.h (font_close_object): Remove.
13354 * fontset.c (FONTSET_OBJLIST): Remove.
13355 (free_realized_fontset) #if-0 the body, which does nothing.
13356 (face_suitable_for_char_p): #if-0, as it's never called.
13357 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13358 * xfaces.c (face_at_string_position):
13359 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13360 since 0 is always ASCII.
13361
dfcf3579
PE
13362 * fns.c (weak_hash_tables): Now static.
13363
5045092b
PE
13364 * fileio.c: Make symbols static if they're not exported.
13365 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13366 (Vwrite_region_annotation_buffers): Now static.
13367
57a96f5c
PE
13368 * eval.c: Make symbols static if they're not exported.
13369 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13370 * lisp.h (backtrace_list): Remove decl.
13371
35f08c38
PE
13372 * emacs.c: Make symbols static if they're not exported.
13373 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13374 (fatal_error_code, fatal_error_signal_hook, standard_args):
13375 Now static.
13376 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13377 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13378 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13379 * lisp.h (fatal_error_signal_hook): Remove decl.
13380 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13381
f44bd759
PE
13382 * editfns.c: Move a (normally-unused) function to its only use.
13383 * editfns.c, lisp.h (get_operating_system_release): Remove.
13384 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13385 worth the hassle of breaking this out.
13386
b532497d
PE
13387 * xterm.c: Make symbols static if they're not exported.
13388 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13389 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13390 (x_destroy_window, x_delete_display):
13391 Now static.
13392 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13393 (x_mouse_leave): Remove; unused.
13394 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13395 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13396 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13397 Remove decls.
13398 (x_mouse_leave): Declare only if WINDOWSNT.
13399 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13400 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13401 USE_X_TOOLKIT.
13402
1675728f
PE
13403 * ftxfont.c: Make symbols static if they're not exported.
13404 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13405 HAVE_FREETYPE.
13406 * font.h (ftxfont_driver): Likewise.
13407
e4cebfca
PE
13408 * xfns.c: Make symbols static if they're not exported.
13409 (x_last_font_name, x_display_info_for_name):
13410 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13411 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13412 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13413 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13414 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13415 (last_show_tip_args): Now static.
13416 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13417 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13418 (x_screen_planes): Remove; unused.
13419 * dispextern.h (x_screen_planes): Remove decl.
13420
5bf46f05
PE
13421 * dispnew.c: Make symbols static if they're not exported.
13422 * dispextern.h (redraw_garbaged_frames, scrolling):
13423 (increment_row_positions): Remove.
13424 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13425 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13426 Now static.
13427 (redraw_garbaged_frames): Remove; unused.
13428
435f4c28
PE
13429 * xfaces.c: Make symbols static if they're not exported.
13430 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13431 Remove decls.
13432 * xterm.h (defined_color): Remove decls.
13433 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13434 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13435 (menu_face_changed_default, defined_color, free_realized_face):
13436 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13437 (ascii_face_of_lisp_face): Remove; unused.
13438
8524aef3
PE
13439 * xdisp.c: Make symbols static if they're not exported.
13440 * dispextern.h (scratch_glyph_row, window_box_edges):
13441 (glyph_to_pixel_coords, set_cursor_from_row):
13442 (get_next_display_element, set_iterator_to_next):
13443 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13444 (show_mouse_face): Remove decls
13445 * frame.h (message_buf_print): Likewise.
13446 * lisp.h (pop_message, set_message, check_point_in_composition):
13447 Likewise.
13448 * xterm.h (set_vertical_scroll_bar): Likewise.
13449 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13450 (message_buf_print, scratch_glyph_row, displayed_buffer):
13451 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13452 (get_next_display_element, show_mouse_face, window_box_edges):
13453 (frame_to_window_pixel_xy, check_point_in_composition):
13454 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13455 (glyph_to_pixel_coords): Remove; unused.
13456
16390cd2
PE
13457 * dired.c (file_name_completion): Now static.
13458
13459 * dbusbind.c (xd_in_read_queued_messages): Now static.
13460
a25f4dfa
PE
13461 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13462 * data.c (circular_list_error): Remove.
13463
14a9c8df
PE
13464 * commands.h (last_point_position, last_point_position_buffer):
13465 (last_point_position_window): Remove decls.
13466 * keyboard.c: Make these variables static.
13467
04f2d78b
CB
13468 * coding.h (coding, code_convert_region, encode_coding_gap):
13469 Remove decls.
74ab6df5
PE
13470 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13471 (iso_code_class, detect_coding, code_convert_region): Now static.
13472 (encode_coding_gap): Remove; unused.
13473
38dfbee1
PE
13474 * chartab.c (chartab_chars, chartab_bits): Now static.
13475
a2cb4e63
PE
13476 * charset.h (charset_iso_8859_1): Remove decl.
13477 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13478 Now static.
13479
127198fd
PE
13480 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13481 * ccl.c (Vccl_program_table): Now static.
13482 (check_ccl_update): Remove; unused.
13483
d85b608f
PE
13484 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13485 * category.h: ... from here.
13486 * category.c (check_category_table, set_category_set): Now static.
13487
31cd66f3
PE
13488 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13489 * lisp.h: Remove these decls.
13490
c358e587
PE
13491 * buffer.c (buffer_count): Remove unused var.
13492
e78aecca
PE
13493 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13494 so that it's not optimized away.
13495 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13496 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13497 exported only to the debugger.
13498
e192d7d3 13499 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13500 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13501
92470028
PE
13502 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13503 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13504 was inaccessible from Lisp.
13505 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13506 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13507
244ed907
PE
13508 alloc.c: Import and export fewer symbols, and remove unused items.
13509 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13510 is defined.
13511 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13512 it's not optimized away by whole-program optimization.
13513 (message_enable_multibyte, free_misc): Remove.
13514 (catchlist, handlerlist, mark_backtrace):
13515 Declare only if BYTE_MARK_STACK.
13516 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13517 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13518 (message_enable_multibyte): Remove decl.
13519 (free_misc, interval_free_list, float_block, float_block_index):
13520 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13521 (cons_free_list, last_marked_index):
13522 Now static.
13523 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13524 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13525 (mark_backtrace): Define only if BYTE_MARK_STACK.
13526 * xdisp.c (message_enable_multibyte): Now static.
13527
61c2b50e 13528 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13529 This makes it easier for human readers (and static analyzers)
13530 to see whether these variables are used from other modules.
13531 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13532 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13533 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13534 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13535 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13536 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13537 * xmenu.c, xselect.c:
13538 Declare Q* vars static if they are not used in other modules.
13539 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13540 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13541 Remove decls of unexported vars.
13542 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13543
95c82688
PE
13544 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13545
16a97296
PE
13546 Make Emacs functions such as Fatom 'static' by default.
13547 This makes it easier for human readers (and static analyzers)
13548 to see whether these functions can be called from other modules.
13549 DEFUN now defines a static function. To make the function external
13550 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13551 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13552 (Finit_image_library):
16a97296
PE
13553 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13554 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13555 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13556 Remove decls, since these functions are now static.
13557 (Funintern, Fget_internal_run_time): New decls, since these functions
13558 were already external.
95c82688 13559
16a97296
PE
13560 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13561 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13562 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13563 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13564 * keyboard.c, keymap.c, lread.c:
13565 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13566 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13567 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13568 Mark functions with DEFUE instead of DEFUN,
13569 if they are used in other modules.
13570 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13571 decls for now-static functions.
13572 * buffer.h (Fdelete_overlay): Remove decl.
13573 * callproc.c (Fgetenv_internal): Mark as internal.
13574 * composite.c (Fremove_list_of_text_properties): Remove decl.
13575 (Fcomposition_get_gstring): New forward static decl.
13576 * composite.h (Fcomposite_get_gstring): Remove decl.
13577 * dired.c (Ffile_attributes): New forward static decl.
13578 * doc.c (Fdocumntation_property): New forward static decl.
13579 * eval.c (Ffetch_bytecode): New forward static decl.
13580 (Funintern): Remove extern decl; now in .h file where it belongs.
13581 * fileio.c (Fmake_symbolic_link): New forward static decl.
13582 * image.c (Finit_image_library): New forward static decl.
13583 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13584 * intervals.h (Fprevious_property_change):
13585 (Fremove_list_of_text_properties): Remove decls.
13586 * keyboard.c (Fthis_command_keys): Remove decl.
13587 (Fcommand_execute): New forward static decl.
13588 * keymap.c (Flookup_key): New forward static decl.
13589 (Fcopy_keymap): Now static.
13590 * keymap.h (Flookup_key): Remove decl.
13591 * process.c (Fget_process): New forward static decl.
13592 (Fprocess_datagram_address): Mark as internal.
13593 * syntax.c (Fsyntax_table_p): New forward static decl.
13594 (skip_chars): Remove duplicate decl.
13595 * textprop.c (Fprevious_property_change): New forward static decl.
13596 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13597 Now internal.
13598 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13599 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13600
785bbd42
PE
13601 * editfns.c (Fformat): Remove unreachable code.
13602
8b913b57
AS
136032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13604
13605 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13606 change. (Bug#8496)
13607
a6744a35
EZ
136082011-04-13 Eli Zaretskii <eliz@gnu.org>
13609
13610 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13611 when at ZV. (Bug#8487)
13612
e7974947
AS
136132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13614
baad03f0
AS
13615 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13616 (Bug#8437)
13617 * keyboard.c (parse_tool_bar_item): Likewise.
13618 * sound.c (sound_cleanup, alsa_close): Likewise.
13619 * termcap.c (tgetent): Likewise.
13620 * xfns.c (x_default_font_parameter): Likewise.
13621 * xsettings.c (read_and_apply_settings): Likewise.
13622
e7974947
AS
13623 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13624 (overrun_check_free): Protoize.
13625
28272684
PE
136262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13627
13628 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13629 since callers should never pass a negative size.
13630 Change the signature to match that of plain 'read' and 'write'; see
13631 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13632 * lisp.h: Update prototypes of emacs_write and emacs_read.
13633
11997c76
EZ
136342011-04-11 Eli Zaretskii <eliz@gnu.org>
13635
13636 * xdisp.c (redisplay_window): Don't try to determine the character
13637 position of the scroll margin if the window start point w->startp
e896f03c 13638 is outside the buffer's accessible region. (Bug#8468)
11997c76 13639
8a2cbd72
EZ
136402011-04-10 Eli Zaretskii <eliz@gnu.org>
13641
13642 Fix write-region and its subroutines for buffers > 2GB.
13643 * fileio.c (a_write, e_write): Modify declaration of arguments and
13644 local variables to support buffers larger than 2GB.
13645 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13646
13647 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13648 argument, local variables, and return value.
13649
13650 * lisp.h: Update prototypes of emacs_write and emacs_read.
13651
13652 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13653
4073e537 136542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13655
1ebfdcb6
PE
13656 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13657
b2ded58d
PE
13658 Fix more problems found by GCC 4.6.0's static checks.
13659
7d66342c
PE
13660 * xdisp.c (vmessage): Use a better test for character truncation.
13661
bbf47d44
PE
13662 * charset.c (load_charset_map): <, not <=, for optimization,
13663 and to avoid potential problems with integer overflow.
9248994d 13664 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13665 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13666 * editfns.c (Fformat): Likewise.
1e69125e 13667 * syntax.c (skip_chars): Likewise.
3befa583 13668
e3019616
PE
13669 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13670 This also lets GCC 4.6.0 generate slightly better loop code.
13671
becfa255
PE
13672 * callint.c (Fcall_interactively): <, not <=, for optimization.
13673 (Fcall_interactively): Count the number of arguments produced,
13674 not the number of arguments given. This is simpler and lets GCC
13675 4.6.0 generate slightly better code.
13676
dae0cd48
PE
13677 * ftfont.c: Distingish more carefully between FcChar8 and char.
13678 The previous code passed unsigned char * to a functions like
13679 strlen and xstrcasecmp that expect char *, which does not
13680 conform to the C standard.
13681 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13682 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13683 char * when the C standard requires it.
13684
76032d70
PE
13685 * keyboard.c (read_char): Remove unused var.
13686
eb3f1cc8
PE
13687 * eval.c: Port to Windows vsnprintf (Bug#8435).
13688 Include <limits.h>.
13689 (SIZE_MAX): Define if the headers do not.
13690 (verror): Do not give up if vsnprintf returns a negative count.
13691 Instead, grow the buffer. This ports to Windows vsnprintf, which
13692 does not conform to C99. Problem reported by Eli Zaretskii.
13693 Also, simplify the allocation scheme, by avoiding the need for
13694 calling realloc, and removing the ALLOCATED variable.
13695
70476b54
PE
13696 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13697
12020a9e
PE
13698 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13699 But keep the doprint source code for now, as we might revamp it
13700 and use it again (Bug#8435).
ea6c7ae6
PE
13701 * lisp.h (doprnt): Remove.
13702 * Makefile.in (base_obj): Remove doprnt.o.
13703 * deps.mk (doprnt.o): Remove.
13704
5fdb398c
PE
13705 error: Print 32- and 64-bit integers portably (Bug#8435).
13706 Without this change, on typical 64-bit hosts error ("...%d...", N)
13707 was used to print both 32- and 64-bit integers N, which relied on
13708 undefined behavior.
61bdb816 13709 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13710 * lisp.h (error, verror): Mark as printf-like functions.
13711 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13712 Report overflow in size calculations when allocating printf buffer.
13713 Do not truncate output string at its first null byte.
13714 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13715 Truncate the output at a character boundary, since vsnprintf does not
13716 do that.
13717 * charset.c (check_iso_charset_parameter): Convert internal
13718 character to string before calling 'error', since %c now has the
13719 printf meaning.
13720 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13721 overflow when computing char to be passed to 'error'. Do not
13722 pass Lisp_Object to 'error'; pass the integer instead.
13723 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13724 formatted with plain %d.
13725
b189fa66
PE
13726 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13727
bff87ef0
PE
13728 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13729
7e2cac20
PE
13730 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13731
ce4d90b5
PE
13732 * xterm.c (x_catch_errors): Remove duplicate declaration.
13733
266c9547
PE
13734 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13735
79c49ad2
PE
13736 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13737
368f4090
JM
137382011-04-10 Jim Meyering <meyering@redhat.com>
13739
13740 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13741 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13742 return ssize_t not "int", and use size_t as the buffer length.
13743 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13744 * gnutls.h: Update declarations.
13745 * process.c (read_process_output): Use ssize_t, to match.
13746 (send_process): Likewise.
13747
a32d4040
CY
137482011-04-09 Chong Yidong <cyd@stupidchicken.com>
13749
13750 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13751
8546720e 137522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13753
04f2d78b
CB
13754 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13755 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13756
8546720e
GM
13757 * xterm.c (handle_one_xevent):
13758 * xmenu.c (create_and_show_popup_menu):
13759 * xselect.c (x_decline_selection_request)
13760 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13761
0a2f5c1a 137622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13763
13764 Fix some uses of `int' instead of EMACS_INT.
13765 * search.c (string_match_1, fast_string_match)
13766 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13767 (scan_buffer, find_next_newline_no_quit)
13768 (find_before_next_newline, search_command, Freplace_match)
13769 (Fmatch_data): Make some `int' variables be EMACS_INT.
13770
13771 * xdisp.c (display_count_lines): 3rd argument and return value now
13772 EMACS_INT. All callers changed.
13773 (pint2hrstr): Last argument is now EMACS_INT.
13774
13775 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13776 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13777 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13778 (decode_coding_utf_16, decode_coding_emacs_mule)
13779 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13780 (decode_coding_ccl, decode_coding_charset)
13781 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13782 (decode_coding_iso_2022, decode_coding_emacs_mule)
13783 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13784 <char_offset, last_offset>: Declare EMACS_INT.
13785 (encode_coding_utf_8, encode_coding_utf_16)
13786 (encode_coding_emacs_mule, encode_invocation_designation)
13787 (encode_designation_at_bol, encode_coding_iso_2022)
13788 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13789 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13790 Declare EMACS_INT.
13791 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13792 (encode_invocation_designation): Last argument P_NCHARS is now
13793 EMACS_INT.
13794 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13795 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13796
13797 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13798 All users changed.
13799
13800 * ccl.c (Fccl_execute_on_string): Declare some variables
13801 EMACS_INT.
13802
8546720e 138032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13804
13805 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13806
4e19a977
CS
138072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13808
13809 * process.c (Fformat_network_address): Doc fix.
13810
87302331
R
138112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13812
ee7683eb 13813 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13814
cbb59342
CY
138152011-04-08 Chong Yidong <cyd@stupidchicken.com>
13816
13817 * keyboard.c (read_char): Call Lisp function help-form-show,
13818 instead of using internal_with_output_to_temp_buffer.
13819 (Qhelp_form_show): New var.
e0d38eeb 13820 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13821
13822 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13823
13824 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13825
e67a13ab
CY
138262011-04-06 Chong Yidong <cyd@stupidchicken.com>
13827
04f2d78b
CB
13828 * process.c (Flist_processes): Remove to Lisp.
13829 (list_processes_1): Delete.
e67a13ab 13830
973f782d
EZ
138312011-04-06 Eli Zaretskii <eliz@gnu.org>
13832
7c106b1e
EZ
13833 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13834
973f782d
EZ
13835 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13836
41cf7d1a 138372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13838
ca23cc88
PE
13839 Fix more problems found by GCC 4.6.0's static checks.
13840
f390e2d5
PE
13841 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13842
42eea0d0
PE
13843 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13844
b69769da 13845 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13846
f9541e84
PE
13847 * xdisp.c (vmessage): Mark as a printf-like function.
13848
13841b55
PE
13849 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13850
c136c10f
PE
13851 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13852
5e2d4a30
PE
13853 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13854 printf-like functions.
13855 (tiff_load): Add casts to remove these marks before passing them
13856 to system-supplied API.
13857
583f48b9
PE
13858 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13859
b25d760e
PE
13860 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13861 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13862 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13863 directly, rather than having caller test rule sign. This avoids
13864 some unnecessary tests.
13865 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13866 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13867 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13868
bc7b6697 13869 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13870 (xfont_open): Avoid unnecessary tests.
bc7b6697 13871
27ccc379
PE
13872 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13873
dcd5c89a
PE
13874 * composite.h, composite.c (composition_gstring_put_cache):
13875 Use EMACS_INT, not int, for length.
13876
b13a45c6
PE
13877 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13878 breaking out part of COMPOSITION_DECODE_RULE.
13879 (COMPOSITION_DECODE_RULE): Use it.
13880 * composite.c (get_composition_id): Remove unused local vars,
13881 by using the new macro.
13882
1e792e4d
PE
13883 * textprop.c (set_text_properties_1): Change while to do-while,
13884 since the condition is always true at first.
13885
dc6c6455 13886 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13887 (interval_deletion_adjustment): Return unsigned value.
13888 All uses changed.
dc6c6455 13889
aba7731a
PE
13890 * process.c (list_processes_1, create_pty, read_process_output):
13891 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13892 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13893 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13894 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13895 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13896
fdfc4bf3
PE
13897 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13898
fca8fe46 13899 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13900 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13901
06a0259a 13902 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13903 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13904 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13905
e7b9e80f
PE
13906 * print.c (print_error_message): Avoid int overflow.
13907
56201685
PE
13908 * font.c (font_list_entities): Redo for clarity,
13909 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13910
78834453 13911 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13912 (font_score): Avoid potential overflow in diff calculation.
78834453 13913
0bc0b309 13914 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13915 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13916
e610eaca
PE
13917 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13918
b895abce
PE
13919 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13920 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13921 can always succeed if overflow has undefined behavior.
13922
1f1d9321 13923 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13924 (wordify): Omit three unnecessary tests.
1f1d9321 13925
c59478bc
PE
13926 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13927 All callers changed. This avoids the need for an unused var.
13928
79b73827
PE
13929 * casefiddle.c (casify_region): Remove var that is set but not used.
13930
a4db5dfe
PE
13931 * dired.c (file_name_completion): Remove var that is set but not used.
13932
43aae36e
PE
13933 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13934
2a47c44d 13935 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13936 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13937
a37c69bf
PE
13938 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13939 Check for integer overflow on size calculations.
13940
328ab8e7
PE
13941 * buffer.c (Fprevious_overlay_change): Remove var that is set
13942 but not used.
13943
e5a2a5cb
PE
13944 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13945 Remove vars that are set but not used.
8d84a6eb 13946 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13947 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13948
a60e5f68
PE
13949 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13950
f661cb61 13951 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13952 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13953
f0397f5a
PE
13954 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13955 that are set but not used.
13956
8664db06 13957 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13958 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13959
6abdaa4a
PE
13960 * xselect.c (x_get_local_selection, x_handle_property_notify):
13961 Remove vars that are set but not used.
13962
0ce7538d 13963 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13964 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13965
9ae848fc
PE
13966 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13967 Remove var that is set but not used.
0b918413
PE
13968 (scroll_bar_windows_size): Now size_t, not int.
13969 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13970 Check for overflow.
9ae848fc 13971
a5a62657
PE
13972 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13973 (map_tty_color) [!defined MSDOS]: Likewise.
13974
5c5cdd39
PE
13975 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13976
66ebf983
PE
13977 * coding.c: Remove vars that are set but not used.
13978 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13979 All callers changed.
13980 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13981 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13982 (decode_coding_charset): Remove vars that are set but not used.
13983
1be4d761
PE
13984 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13985 that is set but not used.
13986
47553fa8
PE
13987 * print.c (print_object): Remove var that is set but not used.
13988
1f7196bf 13989 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13990 The gnulib version avoids calling malloc in the usual case,
13991 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13992 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13993 * filelock.c (current_lock_owner): Likewise.
13994 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13995 * sysdep.c: Include allocator.h, careadlinkat.h.
13996 (emacs_no_realloc_allocator): New static constant.
13997 (emacs_readlink): New function.
fdb61804
PE
13998 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13999 ../lib/careadlinkat.h.
d1fdcab7 14000
f84c17c7
SM
140012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14002
14003 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14004 first non-nil return value).
14005
ef3862ad
JD
140062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14007
14008 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14009 if not defined (Bug#8403).
14010
376a7006
JB
140112011-04-02 Juanma Barranquero <lekktu@gmail.com>
14012
14013 * xdisp.c (display_count_lines): Remove parameter `start',
14014 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14015 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14016 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14017 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14018 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14019 and thereabouts. All callers changed.
14020 (get_per_char_metric): Remove parameter `f', unused since
14021 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14022
6ca3801d
JM
140232011-04-02 Jim Meyering <meyering@redhat.com>
14024
14025 do not dereference NULL upon failed strdup
14026 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14027 (ns_get_family): Likewise.
14028
d8e2b5ba
JB
140292011-04-02 Juanma Barranquero <lekktu@gmail.com>
14030
14031 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14032
8c74fcbd
JD
140332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14034
14035 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14036 later (Bug#8403).
14037
7200d79c
SM
140382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14039
03408648 14040 Add lexical binding.
7200d79c 14041
03408648
SM
14042 * window.c (Ftemp_output_buffer_show): New fun.
14043 (Fsave_window_excursion):
14044 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14045
14046 * lread.c (lisp_file_lexically_bound_p): New function.
14047 (Fload): Bind Qlexical_binding.
14048 (readevalloop): Remove `evalfun' arg.
14049 Bind Qinternal_interpreter_environment.
14050 (Feval_buffer): Bind Qlexical_binding.
14051 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14052 Mark as dynamic.
14053 (syms_of_lread): Declare `lexical-binding'.
14054
14055 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14056
14057 * keyboard.c (eval_dyn): New fun.
14058 (menu_item_eval_property): Use it.
ca105506
SM
14059
14060 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14061
03408648
SM
14062 * fns.c (concat, mapcar1): Accept byte-code-functions.
14063
14064 * eval.c (Fsetq): Handle lexical vars.
14065 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14066 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14067 (FletX, Flet): Obey lexical binding.
14068 (Fcommandp): Handle closures.
14069 (Feval): New `lexical' arg.
14070 (eval_sub): New function extracted from Feval. Use it almost
14071 everywhere where Feval was used. Look up vars in lexical env.
14072 Handle closures.
14073 (Ffunctionp): Move from subr.el.
14074 (Ffuncall): Handle closures.
14075 (apply_lambda): Remove `eval_flags'.
14076 (funcall_lambda): Handle closures and new byte-code-functions.
14077 (Fspecial_variable_p): New function.
14078 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14079 but without exporting it to Lisp.
23aba0ea 14080
23aba0ea 14081 * doc.c (Fdocumentation, store_function_docstring):
03408648 14082 * data.c (Finteractive_form): Handle closures.
23aba0ea 14083
03408648
SM
14084 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14085 interactive spec.
ba83908c 14086
04f2d78b
CB
14087 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14088 New byte-codes.
03408648
SM
14089 (exec_byte_code): New function extracted from Fbyte_code to handle new
14090 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14091
03408648 14092 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14093
03408648 14094 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14095
e2abce01
JB
140962011-03-31 Juanma Barranquero <lekktu@gmail.com>
14097
14098 * xdisp.c (redisplay_internal): Fix prototype.
14099
63696a73 141002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14101
63696a73 14102 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14103 (try_scrolling): Use it when setting scroll_limit.
14104 Limit scrolling to 100 screen lines.
63696a73
EZ
14105 (redisplay_window): Even when falling back on "recentering",
14106 position point in the window according to scroll-conservatively,
14107 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14108
14109 (try_scrolling): When point is above the window, allow searching
14110 as far as scroll_max, or one screenful, to compute vertical
14111 distance from PT to the scroll margin position. This prevents
14112 try_scrolling from unnecessarily failing when
14113 scroll-conservatively is set to a value slightly larger than the
14114 window height. Clean up the case of PT below the margin at bottom
14115 of window: scroll_max can no longer be INT_MAX. When aggressive
14116 scrolling is in use, don't let point enter the opposite scroll
14117 margin as result of the scroll.
14118 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14119 threshold of 100 lines for never-recentering scrolling.
14120
e4cc2dfc
JB
141212011-03-31 Juanma Barranquero <lekktu@gmail.com>
14122
14123 * dispextern.h (move_it_by_lines):
14124 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14125 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14126 (message_log_check_duplicate): Remove parameters `prev_bol' and
14127 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14128 (redisplay_internal): Remove parameter `preserve_echo_area',
14129 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14130
14131 * indent.c (Fvertical_motion):
14132 * window.c (window_scroll_pixel_based, Frecenter):
14133 Don't pass `need_y_p' to `move_it_by_lines'.
14134
1c470562
SM
141352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14136
44f230aa
SM
14137 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14138 steal a few bits to be more compact.
14139 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14140 Remove unneeded casts.
14141
1c470562
SM
14142 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14143
888adce9
ZK
141442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14145
14146 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14147 binding" message (bug#7967).
14148
f838ed7b
PE
141492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14150
77861b95
PE
14151 Fix more problems found by GCC 4.6.0's static checks.
14152
de6dbc14
PE
14153 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14154 Remove unused local var.
14155
f838ed7b
PE
14156 * editfns.c (Fmessage_box): Remove unused local var.
14157
792c7b2b
PE
14158 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14159 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14160 Omit unused local vars.
c499e557 14161 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14162 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14163 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14164 Omit unused local var.
14165
ba0165e1
PE
14166 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14167 Don't assume string length fits in int.
32ad8845 14168 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14169 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14170
3c59b4c9
PE
14171 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14172 instead of alloca (Bug#8344).
14173
a3eed478 14174 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14175 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14176
eb4d412d
PE
14177 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14178
1658b401
PE
14179 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14180 concerns.
14181
14182 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14183
14184 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14185
9a2c6e05
PE
14186 * keyboard.c (syms_of_keyboard): Use the same style as later
14187 in this function when indexing through an array. This also
14188 works around GCC bug 48267.
14189
03d0a109
PE
14190 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14191
44f730c8
PE
14192 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14193
fe75f926
PE
14194 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14195 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14196
ffa8c828
PE
14197 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14198 This avoids undefined behavior on integer overflow, and is a bit
14199 more convenient anyway since it is compared to a size_t variable.
14200
c5101a77
PE
14201 Variadic C functions now count arguments with size_t, not int.
14202 This avoids an unnecessary limitation on 64-bit machines, which
14203 caused (substring ...) to crash on large vectors (Bug#8344).
14204 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14205 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14206 All variadic functions and their callers changed accordingly.
c5101a77
PE
14207 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14208 * data.c (arith_driver, float_arith_driver): Likewise.
14209 * editfns.c (general_insert_function): Likewise.
14210 * eval.c (struct backtrace.nargs, interactive_p)
14211 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14212 (funcall_lambda, mark_backtrace): Likewise.
14213 * fns.c (concat): Likewise.
14214 * frame.c (x_set_frame_parameters): Likewise.
14215 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14216 0 if not found, not -1. All callers changed.
14217
dd3f25f7
PE
14218 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14219 (stack_copy_size): Now size_t, not int.
14220 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14221
461c2ab9
JB
142222011-03-28 Juanma Barranquero <lekktu@gmail.com>
14223
14224 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14225 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14226 All callers changed.
14227
14228 * lisp.h (multibyte_char_to_unibyte):
14229 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14230 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14231 * character.h (CHAR_TO_BYTE8):
14232 * cmds.c (internal_self_insert):
14233 * editfns.c (general_insert_function):
14234 * keymap.c (push_key_description):
14235 * search.c (Freplace_match):
14236 * xdisp.c (message_dolog, set_message_1): All callers changed.
14237
f6d62986
SM
142382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14239
14240 * keyboard.c (safe_run_hook_funcall): New function.
14241 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14242 don't set the hook to nil, but remove the offending function instead.
14243 (Qcommand_hook_internal): Remove, unused.
14244 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14245 Vcommand_hook_internal.
14246
14247 * eval.c (enum run_hooks_condition): Remove.
14248 (funcall_nil, funcall_not): New functions.
14249 (run_hook_with_args): Call each function through a `funcall' argument.
14250 Remove `cond' argument, now redundant.
14251 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14252 (Frun_hook_with_args_until_failure): Adjust accordingly.
14253 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14254
1db5b1ad
JB
142552011-03-28 Juanma Barranquero <lekktu@gmail.com>
14256
14257 * dispextern.h (string_buffer_position): Remove declaration.
14258
14259 * print.c (strout): Remove parameter `multibyte', unused since
14260 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14261
14262 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14263 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14264 All callers changed.
14265
14266 * w32.c (_wsa_errlist): Use braces for struct initializers.
14267
14268 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14269 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14270 All callers changed.
14271 (string_buffer_position): Likewise. Also, make static (it's never
14272 used outside xdisp.c).
14273 (cursor_row_p): Remove parameter `w', unused since
14274 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14275 (decode_mode_spec): Remove parameter `precision', introduced during
14276 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14277 All callers changed.
14278
5ffb62aa
JD
142792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14280
14281 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14282
461c2ab9 142832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14284
14285 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14286 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14287 (ns_update_auto_hide_menu_bar): New functions.
14288 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14289 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14290 ns_constrain_all_frames.
14291 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14292 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14293
5c380ffb
JD
142942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14295
14296 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14297
9af30bdf
GM
142982011-03-27 Glenn Morris <rgm@gnu.org>
14299
14300 * syssignal.h: Replace RETSIGTYPE with void.
14301 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14302 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14303 Replace SIGTYPE with void everywhere.
14304 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14305 * s/template.h (SIGTYPE): Remove commented out definition.
14306
e2abce01
JB
143072011-03-26 Eli Zaretskii <eliz@gnu.org>
14308
14309 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14310 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14311
f868cd8a
JB
143122011-03-26 Juanma Barranquero <lekktu@gmail.com>
14313
59eb0929
JB
14314 * w32.c (read_unc_volume): Use parameter `henum', instead of
14315 global variable `wget_enum_handle'.
14316
14317 * keymap.c (describe_vector): Remove parameters `indices' and
14318 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14319 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14320
f868cd8a
JB
14321 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14322
14323 * keyboard.c (timer_check): Remove parameter `do_it_now',
14324 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14325 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14326 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14327
14328 * keyboard.c (read_char):
14329 * w32menu.c (w32_menu_display_help):
14330 * xmenu.c (show_help_event, menu_help_callback):
14331 Adjust calls to `show_help_echo'.
14332
14333 * gtkutil.c (xg_maybe_add_timer):
14334 * keyboard.c (readable_events):
14335 * process.c (wait_reading_process_output):
14336 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14337
14338 * insdel.c (adjust_markers_gap_motion):
14339 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14340 (gap_left, gap_right): Don't call it.
14341
2ecf6fdb
CY
143422011-03-25 Chong Yidong <cyd@stupidchicken.com>
14343
14344 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14345 incurred during fontification.
14346
6b1f9ba4
JB
143472011-03-25 Juanma Barranquero <lekktu@gmail.com>
14348
14349 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14350 (DEFVAR_PER_BUFFER): Don't pass it.
14351
14352 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14353 (scrolling_window): Don't pass it.
14354
0f4a96b5
JB
143552011-03-25 Juanma Barranquero <lekktu@gmail.com>
14356
14357 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14358
14359 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14360 and `suffix'.
14361 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14362 of variables specific to SELinux and computation of `encoded_absname'.
14363
14364 * image.c (XPutPixel): Remove unused variable `height'.
14365
14366 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14367
14368 * unexw32.c (get_section_info): Remove unused variable `section'.
14369
14370 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14371 (system_process_attributes): Remove unused variable `sess'.
14372 (sys_read): Remove unused variable `err'.
14373
14374 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14375 (w32_wnd_proc): Remove unused variable `isdead'.
14376 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14377 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14378 (x_create_tip_frame): Remove unused variable `tem'.
14379
14380 * w32inevt.c (w32_console_read_socket):
14381 Remove unused variable `no_events'.
14382
14383 * w32term.c (x_draw_composite_glyph_string_foreground):
14384 Remove unused variable `width'.
14385
1149507c
JB
143862011-03-24 Juanma Barranquero <lekktu@gmail.com>
14387
14388 * w32term.c (x_set_glyph_string_clipping):
14389 Don't pass uninitialized region to CombineRgn.
14390
9c88f339
JB
143912011-03-23 Juanma Barranquero <lekktu@gmail.com>
14392
14393 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14394 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14395 (Fx_close_connection): Remove unused variable `i'.
14396
14397 * w32font.c (w32font_draw): Return number of glyphs.
14398 (w32font_open_internal): Remove unused variable `i'.
14399 (w32font_driver): Add missing initializer.
14400
14401 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14402 (fill_in_menu): Remove unused variable `items_added'.
14403
14404 * w32term.c (last_mouse_press_frame): Remove static global variable.
14405 (w32_clip_to_row): Remove unused variable `f'.
14406 (x_delete_terminal): Remove unused variable `i'.
14407
14408 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14409 (NOTHING): Remove unused static global variable.
14410 (uniscribe_check_otf): Remove unused variable `table'.
14411 (uniscribe_font_driver): Add missing initializers.
14412
dee091a3
JD
144132011-03-23 Julien Danjou <julien@danjou.info>
14414
14415 * term.c (Fsuspend_tty, Fresume_tty):
14416 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14417 * window.c (temp_output_buffer_show):
14418 * insdel.c (signal_before_change):
14419 * frame.c (Fhandle_switch_frame):
14420 * fileio.c (Fdo_auto_save):
14421 * emacs.c (Fkill_emacs):
14422 * editfns.c (save_excursion_restore):
14423 * cmds.c (internal_self_insert):
14424 * callint.c (Fcall_interactively):
14425 * buffer.c (Fkill_all_local_variables):
14426 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14427 Use Frun_hooks.
0f4a96b5 14428 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14429 unconditionally since it does the check itself.
dee091a3 14430
2c520ab5 144312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14432
c9c49752
PE
14433 Fix more problems found by GCC 4.5.2's static checks.
14434
8abc3f12
PE
14435 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14436 the first time through the loop, since we know p0 < p1 then.
14437 This also avoids a gcc -Wstrict-overflow warning.
14438
a2d26660
PE
14439 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14440 leading to a memory leak, possible in functions like
14441 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14442 of objects (Bug#8318).
a2d26660 14443
916c72e9
PE
14444 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14445 that could (at least in theory) be that large.
14446
19ab8a18
PE
14447 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14448 This is less likely to overflow, and avoids undefined behavior if
14449 overflow does occur. All callers changed. Use strtoul to scan
14450 for the unsigned long integer.
b7cbbd6f
PE
14451 (pint2hrstr): Simplify and tune code slightly.
14452 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14453
f0641eff
PE
14454 * scroll.c (do_scrolling): Work around GCC bug 48228.
14455 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14456
7f650bb9
PE
14457 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14458 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14459 (validate_x_resource_name): Simplify count usage.
14460 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14461
37dd57d1
PE
14462 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14463 fail (Bug#8306).
81e56e61 14464
699979fc 14465 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14466
401bf9b4
PE
14467 * process.c (Fmake_network_process): Use socklen_t, not int,
14468 where POSIX says socklen_t is required in portable programs.
14469 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14470 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14471 (Fmake_network_process, server_accept_connection):
14472 (wait_reading_process_output, read_process_output):
14473 Likewise.
14474
b93aacde
PE
14475 * process.c: Rename or move locals to avoid shadowing.
14476 (list_processes_1, Fmake_network_process):
14477 (read_process_output_error_handler, exec_sentinel_error_handler):
14478 Rename or move locals.
4dc343ee 14479 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14480 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14481 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14482 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14483 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14484
af8a867c 14485 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14486 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14487 Include tparam.h instead, since it declares them.
af8a867c
PE
14488 * cm.h (PC): Remove extern decl; tparam.h now does this.
14489 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14490 * terminfo.c: Include tparam.h, to check interfaces.
14491 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14492 (tparam): Adjust signature to match interface in tparam.h;
14493 this removes some undefined behavior. Check that outstring and len
14494 are zero, which they always are with Emacs.
14495 * tparam.h (PC, BC, UP): New extern decls.
14496
0248044d 14497 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14498 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14499
8ff096c1 14500 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14501 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14502 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14503 (ftfont_list): Remove unused local.
49eaafba
PE
14504 (get_adstyle_property, ftfont_pattern_entity):
14505 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14506 Rename locals to avoid shadowing.
8ff096c1 14507
e2be39f6
PE
14508 * xfont.c (xfont_list_family): Mark var as initialized.
14509
c9735e30
PE
14510 * xml.c (make_dom): Now static.
14511
8f5201ae
PE
14512 * composite.c (composition_compute_stop_pos): Rename local to
14513 avoid shadowing.
b246f932
PE
14514 (composition_reseat_it): Remove unused locals.
14515 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14516 (composition_update_it): Mark var as initialized.
11b61122
PE
14517 (find_automatic_composition): Mark vars as initialized,
14518 with a FIXME (Bug#8290).
8f5201ae 14519
760fbc2c
PE
14520 character.h: Rename locals to avoid shadowing.
14521 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14522 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14523 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14524 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14525 to avoid shadowing.
14526
ff08eb85
PE
14527 * textprop.c (property_change_between_p): Remove; unused.
14528
fc7bf025
PE
14529 * intervals.c (interval_start_pos): Now static.
14530
235d7abc
PE
14531 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14532
44f230aa
SM
14533 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14534 Rename locals to avoid shadowing.
3e7d6594 14535
50060332
PE
14536 * sound.c (wav_play, au_play, Fplay_sound_internal):
14537 Fix pointer signedness.
d01f234b 14538 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14539 (wav_play): Initialize a variable to 0, to prevent undefined
14540 behavior (Bug#8278).
50060332 14541
c4fc4e30
PE
14542 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14543
918436ed
PE
14544 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14545
c939f91b
PE
14546 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14547 clobbering (Bug#8298).
b9c7f648
PE
14548 * sysdep.c (sys_subshell): Likewise.
14549 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14550
6bd8c144
PE
14551 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14552 This should get cleaned up, so that child_setup has the
14553 same signature on all platforms.
14554
7710357c 14555 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14556 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14557
c59da222
CY
145582011-03-22 Chong Yidong <cyd@stupidchicken.com>
14559
14560 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14561 not to be necessary, and produces flickering.
14562
66b87493
GM
145632011-03-20 Glenn Morris <rgm@gnu.org>
14564
14565 * config.in: Remove file.
14566
45b6f6d5
JB
145672011-03-20 Juanma Barranquero <lekktu@gmail.com>
14568
14569 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14570 are now in src/globals.h.
14571 (syms_of_minibuf): Remove spurious & from previous change.
14572
cd394be1 145732011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14574
14575 * minibuf.c (completing-read-function): New variable.
14576 (completing-read-default): Rename from completing-read.
14577 (completing-read): Call completing-read-function.
14578
b14e3e21
CY
145792011-03-19 Juanma Barranquero <lekktu@gmail.com>
14580
14581 * xfaces.c (Fx_load_color_file):
14582 Read color file from absolute filename (bug#8250).
14583
f2b726e6
JB
145842011-03-19 Juanma Barranquero <lekktu@gmail.com>
14585
14586 * makefile.w32-in: Update dependencies.
14587
09f6ff02
EZ
145882011-03-17 Eli Zaretskii <eliz@gnu.org>
14589
14590 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14591
29a6015a
PE
145922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14593
a3a6c54e
PE
14594 Fix more problems found by GCC 4.5.2's static checks.
14595
b766f867
PE
14596 * process.c (make_serial_process_unwind, send_process_trap):
14597 (sigchld_handler): Now static.
14598
be02381c
PE
14599 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14600 That way, the code declares only the vars that it needs.
14601 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14602 * s/cygwin.h (PTY_ITERATION): Likewise.
14603 * s/darwin.h (PTY_ITERATION): Likewise.
14604 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14605
57048744
PE
14606 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14607 * process.c (allocate_pty): Don't declare stb unless it's needed.
14608
7914961c 14609 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14610 (CONSTANTLIM): Remove; unused.
14611 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14612 Define only if needed.
7914961c 14613
b3967b18
PE
14614 * unexelf.c (unexec): Name an expression,
14615 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14616 Use a different way to cause a compilation error if anyone uses
14617 n rather than nn, a way that does not involve shadowing.
73366a00 14618 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14619
29a6015a
PE
14620 * deps.mk (unexalpha.o): Remove; unused.
14621
43cfc33e 14622 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14623 * unexec.h: New file.
ce701a33
PE
14624 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14625 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14626 Depend on unexec.h.
14627 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14628 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14629 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14630 Change as necessary to match prototype in unexec.h.
ce701a33 14631
01f44d5a
PE
14632 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14633 shadowing.
4f63c6bb 14634 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14635
a6670b0b
PE
14636 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14637 Rename locals to avoid shadowing.
14638
cef2010d 14639 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14640 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14641
d4d7173a
PE
14642 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14643
f08b802a
PE
14644 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14645 warning when compiling print.c.
14646
3ddb0639
PE
14647 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14648 instead of using an uninitialized var.
5ad03b97 14649 (font_sort_entities): Mark var as initialized.
3ddb0639 14650
170a2692
PE
14651 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14652
e663c700
PE
14653 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14654 pointers to constants.
89bc529a 14655 (font_parse_fcname): Remove unused vars.
7b81e2d0 14656 (font_delete_unmatched): Now static.
ea838e10 14657 (font_get_spec): Remove; unused.
13a547c6
PE
14658 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14659 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14660 Rename or move locals to avoid shadowing.
e663c700 14661
2a80c887 14662 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14663 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14664
1384fa33 14665 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14666 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14667
8b2c52e9
PE
14668 * alloc.c (mark_backtrace): Move decl from here ...
14669 * lisp.h: ... to here, so that it can be checked.
14670
475545b5 14671 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14672 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14673 (lisp_indirect_variable): Name an expression,
14674 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14675 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14676
b1349114 14677 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14678 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14679 Use const pointer when appropriate.
b1349114 14680
a2928364
PE
14681 * lisp.h (get_system_name, get_operating_system_release):
14682 Move decls here, to check interfaces.
14683 * process.c (get_operating_system_release): Move decl to lisp.h.
14684 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14685 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14686 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14687 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14688 (Fformat_time_string, Fencode_time, Finsert_char):
14689 (Ftranslate_region_internal, Fformat):
14690 Rename or remove local vars to avoid shadowing.
9710023e 14691 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14692
a415e694
PE
14693 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14694 avoid shadowing.
14695
8ef4622d
PE
14696 * lisp.h (eassert): Check that the argument compiles, even if
14697 ENABLE_CHECKING is not defined.
14698
946f9a5b
PE
14699 * data.c (Findirect_variable): Name an expression, to avoid
14700 gcc -Wbad-function-cast warning.
112396d6 14701 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14702 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14703 (Fmake_variable_buffer_local, Fmake_local_variable):
14704 Mark variables as initialized.
52746918 14705 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14706
e5aab7e7 14707 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14708 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14709 Rename locals to avoid shadowing.
dff45157
PE
14710 (mark_stack): Move local variables into the #ifdef region where
14711 they're used.
7bc26fdb
PE
14712 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14713 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14714 needed otherwise.
14715 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14716 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14717 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14718
e5aab7e7
PE
14719 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14720 avoids undefined behavior in theory.
14721
4da60324
PE
14722 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14723
88043301
PE
14724 Use functions, not macros, for up- and down-casing (Bug#8254).
14725 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14726 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14727 to use the following functions instead of these macros.
14728 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14729 EMACS_INT, since callers assume the returned value fits in int.
14730 (upcase1): Likewise, for UPCASE_TABLE.
14731 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14732 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14733 the race-condition problem in the old DOWNCASE.
88043301 14734
19ed5445
PE
14735 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14736 Rename locals to avoid shadowing.
14737 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14738 (regex_compile, re_search_2, re_match_2_internal):
14739 Remove unused local vars.
952db0d7
PE
14740 (FREE_VAR): Rewrite so as not to use empty "else",
14741 which gcc can warn about.
da053e48 14742 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14743 (RETALLOC_IF): Define only if needed.
14744 (WORDCHAR_P): Likewise. This one is never needed, but is used
14745 only in a comment talking about a compiler bug, so put inside
14746 the #if 0 of that comment.
14747 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14748 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14749 Remove; unused.
19ed5445 14750
1f3561e4 14751 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14752 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14753 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14754
ded6f8f7
PE
14755 * search.c (simple_search): Remove unused var.
14756
dbd37a95
PE
14757 * dired.c (compile_pattern): Move decl from here ...
14758 * lisp.h: ... to here, so that it can be checked.
14759 (struct re_registers): New forward decl.
14760
7e47afad
PE
14761 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14762
85f24f61
PE
14763 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14764 All uses changed.
14765 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14766 Rename locals to avoid shadowing.
5671df8f 14767 (Fvertical_motion): Mark locals as initialized.
85f24f61 14768
181aa2be 14769 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14770 (casify_region): Mark local as initialized.
181aa2be 14771
930d429c
PE
14772 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14773
7082eac6
PE
14774 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14775 New macros, so that the caller can use some names other than
14776 gcpro1, gcpro2, etc.
14777 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14778 of the new macros.
14779 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14780 argument, for consistency with GCPRO2_VAR, etc: it is now the
14781 prefix of the variable, not the variable itself. All uses
14782 changed.
38b2c076
PE
14783 * dired.c (directory_files_internal, file_name_completion):
14784 Rename locals to avoid shadowing.
14785
15206ed9
PE
14786 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14787 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14788 dired.c's scmp function, had undefined behavior.
14789 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14790 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14791 * buffer.h: ... to here, because these macros use current_buffer,
14792 and the new implementation with inline functions needs to have
14793 current_buffer in scope now, rather than later when the macros
14794 are used.
14795 (downcase, upcase1): New static inline functions.
14796 (DOWNCASE, UPCASE1): Reimplement using these functions.
14797 This avoids undefined behavior in expressions like
14798 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14799 from race conditions in accessing the global variables
14800 case_temp1 and case_temp2.
14801 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14802 * lisp.h (case_temp1, case_temp2): Remove their decls.
14803 * character.h (ASCII_CHAR_P): Move from here ...
14804 * lisp.h: ... to here, so that the inline functions mentioned
14805 above can use them.
14806
4a6bea26
PE
14807 * dired.c (directory_files_internal_unwind): Now static.
14808
f14b7e14
PE
14809 * fileio.c (file_name_as_directory, directory_file_name):
14810 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14811 Now static.
2893f146
PE
14812 (file_name_as_directory): Use const pointers when appropriate.
14813 (Fexpand_file_name): Likewise. In particular, newdir might
14814 point at constant storage, so make it a const pointer.
fd4ead52 14815 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14816 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14817 signedness issues.
f839df0c
PE
14818 (Fset_file_times, Finsert_file_contents, auto_save_error):
14819 Rename locals to avoid shadowing.
f14b7e14 14820
5716756e 14821 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14822 (Ftry_completion, Fall_completions): Rename or remove locals
14823 to avoid shadowing.
5716756e 14824
b4c3046a
PE
14825 * marker.c (bytepos_to_charpos): Remove; unused.
14826
b45db522
PE
14827 * lisp.h (verify_bytepos, count_markers): New decls,
14828 so that gcc does not warn that these functions aren't declared.
14829
85876d07
PE
14830 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14831 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14832 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14833 (copy_text): Remove unused local var.
85876d07 14834
03d78a21 14835 * filelock.c (within_one_second): Now static.
b3dd38ab 14836 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14837
5df8f01b
PE
14838 * buffer.c (fix_overlays_before): Mark locals as initialized.
14839 (fix_start_end_in_overlays): Likewise. This function should be
14840 simplified by using pointers-to-pointers, but that's a different
14841 matter.
b1d876f1 14842 (switch_to_buffer_1): Now static.
8f54f30a
PE
14843 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14844 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14845
a70072c9 14846 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14847 Fix pointer signedness issue.
edced198
PE
14848 (sys_subshell): Mark local as volatile if checking for lint,
14849 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14850 (MAXPATHLEN): Define only if needed.
a70072c9 14851
a0977c44
PE
14852 * process.c (serial_open, serial_configure): Move decls from here ...
14853 * systty.h: ... to here, so that they can be checked.
14854
a884fdcc
PE
14855 * fns.c (get_random, seed_random): Move extern decls from here ...
14856 * lisp.h: ... to here, so that they can be checked.
14857
604efe86 14858 * sysdep.c (reset_io): Now static.
b8950c94 14859 (wait_for_termination_signal): Remove; unused.
604efe86 14860
38fc62d9
PE
14861 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14862 (copy_keymap_item, append_key, push_text_char_description):
14863 Now static.
1004a21a 14864 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14865 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14866 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14867 (describe_map_tree):
14868 Rename locals to avoid shadowing.
38fc62d9 14869
2f2650da
PE
14870 * keyboard.c: Declare functions static if they are not used elsewhere.
14871 (echo_char, echo_dash, cmd_error, top_level_2):
14872 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14873 (read_char, kbd_buffer_get_event, make_lispy_position):
14874 (make_lispy_event, make_lispy_movement, apply_modifiers):
14875 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14876 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14877 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14878 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14879 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14880
a053e86c 14881 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14882 (mark_kboards): Move decl here ...
14883 * alloc.c (mark_kboards): ... from here.
a053e86c 14884
4752793e
PE
14885 * lisp.h (force_auto_save_soon): New decl.
14886
74f10ca7 14887 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14888 (DEFINE_DUMMY_FUNCTION): New macro.
14889 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14890 Use it.
c03cd23f
PE
14891 (main): Add casts to avoid warnings
14892 if GCC considers string literals to be constants.
74f10ca7 14893
022e70d4
PE
14894 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14895
59d6fe83
PE
14896 * dbusbind.c: Pointer signedness fixes.
14897 (xd_signature, xd_append_arg, xd_initialize):
14898 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14899 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14900 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14901 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14902
78320123
PE
14903 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14904 if GCC considers string literals to be constants.
49cebcca 14905 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14906
35ac2a97
SM
149072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14908
fb103ca9
SM
14909 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14910 (print_preprocess, print_object): New macro to fix last change.
14911
35ac2a97
SM
14912 * print.c (print_preprocess): Don't forget font objects.
14913
62973b41
JB
149142011-03-16 Juanma Barranquero <lekktu@gmail.com>
14915
14916 * emacs.c (USAGE3): Doc fixes.
14917
0e48bb22
AS
149182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14919
14920 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14921 structure.
14922
7684e57b
JB
149232011-03-14 Juanma Barranquero <lekktu@gmail.com>
14924
14925 * lisp.h (VWindow_system, Qfile_name_history):
14926 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14927 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14928 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14929
14930 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14931 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14932
14933 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14934 * w32console.c (detect_input_pending, read_input_pending)
14935 (encode_terminal_code):
14936 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14937 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14938 (w32_system_caret_y, Qfile_name_history):
14939 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14940 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14941 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14942 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14943 * w32proc.c (Qlocal, report_file_error):
14944 * w32term.c (Vwindow_system, updating_frame):
14945 * w32uniscribe.c (initialized, uniscribe_font_driver):
14946 Remove unneeded extern declarations.
14947
2aa46d6c
CY
149482011-03-14 Chong Yidong <cyd@stupidchicken.com>
14949
c96bbc66 14950 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14951
cffc6f3b
CY
149522011-03-13 Chong Yidong <cyd@stupidchicken.com>
14953
14954 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14955 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14956 These macros can no longer be used for assignment.
14957
44f230aa
SM
14958 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14959 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14960 (record_buffer_markers, fetch_buffer_markers): New functions for
14961 recording and fetching special buffer markers.
14962 (set_buffer_internal_1, set_buffer_temp): Use them.
14963
14964 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14965
14966 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14967
14968 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14969 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14970
14971 * xdisp.c (hscroll_window_tree):
14972 (reconsider_clip_changes): Use PT instead of BUF_PT.
14973
d251f04b
EZ
149742011-03-13 Eli Zaretskii <eliz@gnu.org>
14975
14976 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14977 $(EMACS_ROOT)/lib/intprops.h.
14978
f0c77cd1
PE
149792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14980
3eca4629
PE
14981 Fix more problems found by GCC 4.5.2's static checks.
14982
7c86ee98
PE
14983 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14984 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14985 (xg_free_frame_widgets): Make it clear that a local variable is
14986 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14987 (gdk_window_get_screen): Make it clear that this macro is needed
14988 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14989 (int_gtk_range_get_value): New function, which avoids a diagnostic
14990 from gcc -Wbad-function-cast.
14991 (xg_set_toolkit_scroll_bar_thumb): Use it.
14992 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14993 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14994 (get_utf8_string, xg_get_file_with_chooser):
14995 Rename locals to avoid shadowing.
14996 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14997
41729b81
PE
14998 * xgselect.c (xg_select): Remove unused var.
14999
f0c77cd1
PE
15000 * image.c (four_corners_best): Mark locals as initialized.
15001 (gif_load): Initialize transparent_p to zero (Bug#8238).
15002 Mark another local as initialized.
ec6cf4c6 15003 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15004
ce0ad53d 15005 * image.c (clear_image_cache): Now static.
d5d5a617 15006 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15007 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15008 (x_edge_detection): Remove unnecessary cast that
15009 gcc -Wbad-function-cast diagnoses.
2037898d 15010 (gif_load): Fix pointer signedness.
6ae141d6
PE
15011 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15012 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15013
33383987 150142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15015
d32df629
PE
15016 Improve quality of tests for time stamp overflow.
15017 For example, without this patch (encode-time 0 0 0 1 1
15018 1152921504606846976) returns the obviously-bogus value (-948597
15019 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15020 reports time overflow. See
15021 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15022 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15023 * editfns.c: Include limits.h and intprops.h.
15024 (TIME_T_MIN, TIME_T_MAX): New macros.
15025 (time_overflow): Move earlier, to before first use.
15026 (hi_time, lo_time): New functions, for an accurate test for
15027 out-of-range times.
15028 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15029 (Fget_internal_run_time): Don't assume time_t fits in int.
15030 (make_time): Use list2 instead of Fcons twice.
15031 (Fdecode_time): More accurate test for out-of-range times.
15032 (check_tm_member): New function.
15033 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15034 (lisp_time_argument): Don't rely on undefined left-shift and
15035 right-shift behavior when checking for time stamp overflow.
8be6f318 15036
fe31d94c
PE
15037 * editfns.c (time_overflow): New function, refactoring common code.
15038 (Fformat_time_string, Fdecode_time, Fencode_time):
15039 (Fcurrent_time_string): Use it.
15040
8be6f318
PE
15041 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15042 * dired.c (make_time): Move to ...
15043 * editfns.c (make_time): ... here.
15044 * systime.h: Note the move.
15045
09d9db2c 150462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15047
126bc0dc
YM
15048 * fringe.c (update_window_fringes): Remove unused variables.
15049
c47cbdfd
YM
15050 * unexmacosx.c (copy_data_segment): Also copy __got section.
15051 (Bug#8223)
15052
7ac80be9
EZ
150532011-03-12 Eli Zaretskii <eliz@gnu.org>
15054
c96bbc66 15055 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15056 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15057 Constify `char *' arguments and their references according to
15058 prototypes in tparam.h.
15059
ecb0f94d 15060 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15061
7ac80be9
EZ
15062 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15063 Adapt all references accordingly.
15064
15065 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15066
ef1fd07e
TT
150672011-03-11 Tom Tromey <tromey@redhat.com>
15068
15069 * buffer.c (syms_of_buffer): Remove obsolete comment.
15070
7ef4b50c
EZ
150712011-03-11 Eli Zaretskii <eliz@gnu.org>
15072
15073 * termhooks.h (encode_terminal_code): Declare prototype.
15074
15075 * msdos.c (encode_terminal_code): Don't declare prototype.
15076
15077 * term.c (encode_terminal_code): Now external again, used by
15078 w32console.c and msdos.c.
15079
44f230aa
SM
15080 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15081 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15082
4b1ec863 150832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15084
1714f52b 15085 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15086
4b1ec863
PE
15087 * fringe.c (update_window_fringes): Mark locals as initialized
15088 (Bug#8227).
15089 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15090
524c7aa6
PE
15091 * alloc.c (mark_fringe_data): Move decl from here ...
15092 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15093 to check its interface.
15094 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15095
a5c0af81 15096 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15097 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15098 (fontset_font): Mark local as initialized.
a9a06e0b 15099 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15100
b4716021
PE
15101 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15102
811e9bac 15103 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15104 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15105 (x_own_selection, Fx_disown_selection_internal): Rename locals
15106 to avoid shadowing.
15107 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15108
7e3ab302
PE
15109 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15110 so that the caller can use some name other than gcpro1.
15111 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15112 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15113 (Fx_backspace_delete_keys_p):
15114 Use them to avoid shadowing, and rename vars to avoid shadowing.
15115 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15116 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15117 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15118 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15119 Remove unused locals.
7e3ab302
PE
15120 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15121 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15122 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15123 macros.
f78faa98 15124
e2b13473
PE
15125 * xterm.h (x_mouse_leave): New decl.
15126
77f23912
PE
15127 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15128 Remove unused functions.
cdf4ba58
PE
15129 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15130 (x_calc_absolute_position): Now static.
7411c686 15131 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15132 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15133 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15134 unless they are used.
38d0b34a
PE
15135 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15136 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15137 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15138 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15139 (x_error_catcher, x_connection_closed, x_error_handler):
15140 (x_error_quitter, xembed_send_message, x_iconify_frame):
15141 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15142 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15143 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15144
44f230aa
SM
15145 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15146 Rename or move locals to avoid shadowing.
6b463e58 15147 (tty_defined_color, merge_face_heights): Now static.
5967d051 15148 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15149 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15150 does not deduce is never used uninitialized.
73719eba
PE
15151 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15152 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15153
426994c3 15154 * terminal.c (store_terminal_param): Now static.
5489860b 15155
032f1620 15156 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15157 (set_frame_menubar): Remove unused local.
d4323972 15158 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15159 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15160 since they might point to immutable storage.
281585b0
PE
15161 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15162 since it's unused otherwise.
032f1620 15163
367c19e5 15164 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15165 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15166 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15167 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15168 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15169 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15170 does not deduce are never used uninitialized.
70739cbe 15171
07b48fa9
PE
15172 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15173
8868a238 15174 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15175 * window.c (window_loop, size_window):
15176 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15177
7e5cf297 15178 * window.c (display_buffer): Now static.
d6550a9f
PE
15179 (size_window): Mark variables that gcc -Wuninitialized
15180 does not deduce are never used uninitialized.
a586633d
PE
15181 * window.h (check_all_windows): New decl, to forestall
15182 gcc -Wmissing-prototypes diagnostic.
5b555da1 15183 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15184
f6095868
PE
15185 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15186 shadowing.
15187 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15188 Include <limits.h>.
15189 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15190 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15191 (load_charset_map): Mark variables that gcc -Wuninitialized
15192 does not deduce are never used uninitialized.
53df7c11 15193 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15194
f38b440c
PE
15195 * coding.c (coding_set_source, coding_set_destination):
15196 Use "else { /* comment */ }" rather than "else /* comment */;"
15197 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15198 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15199 a block, when the outer 'i' will do.
15200 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15201 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15202 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15203 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15204 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15205 Rename locals to avoid shadowing.
15206 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15207 * coding.c (emacs_mule_char, encode_invocation_designation):
15208 Now static, since they're not used elsewhere.
413bb2db 15209 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15210 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15211 (decode_coding_emacs_mule): Mark variables that gcc
15212 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15213 (detect_coding_iso_2022): Initialize a local variable that might
15214 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15215 this initialization is needed. (Bug#8211)
5f58e762
PE
15216 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15217 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15218 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15219 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15220 Remove unused macros.
f38b440c 15221
232b38b9 15222 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15223 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15224 * character.c (string_count_byte8): Likewise.
232b38b9 15225
fb90da1b
PE
15226 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15227 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15228
fb93dbc2
PE
15229 * chartab.c (copy_sub_char_table): Now static, since it's not used
15230 elsewhere.
5c156ace
PE
15231 (sub_char_table_ref_and_range, char_table_ref_and_range):
15232 Rename locals to avoid shadowing.
bbcd0949 15233 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15234
7d3b3862 15235 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15236 (BIDI_BOB): Remove unused macro.
7d3b3862 15237
6be7d3da
PE
15238 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15239 deduce are never used uninitialized.
c2ed9c8b 15240 * term.c (encode_terminal_code): Likewise.
6be7d3da 15241
75f8807f 15242 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15243
50938595
PE
15244 * tparam.h: New file.
15245 * term.c, tparam.h: Include it.
15246 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15247 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15248 Move these decls to tparam.h, and make them agree with what
15249 is actually in tparam.c. The previous trick of using incompatible
15250 decls in different modules does not conform to the C standard.
15251 All callers of tparam changed to use tparam's actual API.
15252 * tparam.c (tparam1, tparam, tgoto):
15253 Use const pointers where appropriate.
15254
fbceeba2
PE
15255 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15256 * cm.h (struct cm): Likewise.
15257 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15258 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15259 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15260 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15261 (turn_on_face, init_tty): Likewise.
15262 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15263
7f3f1250
PE
15264 * term.c (term_mouse_position): Rename local to avoid shadowing.
15265
e6ca6543
PE
15266 * alloc.c (mark_ttys): Move decl from here ...
15267 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15268
c40f8d15
AS
152692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15270
15271 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15272
cfe0661d
JB
152732011-03-09 Juanma Barranquero <lekktu@gmail.com>
15274
15275 * search.c (compile_pattern_1): Remove argument regp, unused since
15276 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15277 (compile_pattern): Don't pass it.
15278
0afb4571
J
152792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15280
15281 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15282 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15283 for ! HAVE_GTK3.
15284 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15285
15286 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15287
15288 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15289 gdk_window_get_screen, gdk_window_get_geometry,
15290 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15291 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15292 (xg_get_pixbuf_from_pixmap): New function.
15293 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15294 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15295 Call xg_get_pixbuf_from_pixmap instead of
15296 gdk_pixbuf_get_from_drawable.
15297 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15298 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15299 (xg_check_special_colors): Use GtkStyleContext and its functions
15300 for HAVE_GTK3.
15301 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15302 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15303 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15304 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15305 Call gtk_widget_get_preferred_size.
0afb4571
J
15306 (xg_frame_resized): gdk_window_get_geometry only takes 5
15307 parameters.
44f230aa
SM
15308 (xg_win_to_widget, xg_event_is_for_menubar):
15309 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15310 (xg_set_widget_bg): New function.
15311 (delete_cb): New function.
895009e1 15312 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15313 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15314 (xg_set_background_color): Call xg_set_widget_bg.
15315 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15316 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15317 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15318 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15319 if ! HAVE_GTK3.
15320 (update_frame_tool_bar): Call gtk_widget_hide.
15321 (xg_initialize): Use GDK_KEY_g.
15322
15323 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15324 if ! HAVE_GTK3
15325 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15326
15327 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15328 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15329 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15330
1c2cc4ef
JB
153312011-03-08 Juanma Barranquero <lekktu@gmail.com>
15332
15333 * w32xfns.c (select_palette): Check success of RealizePalette against
15334 GDI_ERROR, not zero.
15335
33383987 15336See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15337
15338;; Local Variables:
15339;; coding: utf-8
aac0c6e3
MR
15340;; End:
15341
2f097256 15342 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15343
15344 This file is part of GNU Emacs.
15345
15346 GNU Emacs is free software: you can redistribute it and/or modify
15347 it under the terms of the GNU General Public License as published by
15348 the Free Software Foundation, either version 3 of the License, or
15349 (at your option) any later version.
15350
15351 GNU Emacs is distributed in the hope that it will be useful,
15352 but WITHOUT ANY WARRANTY; without even the implied warranty of
15353 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15354 GNU General Public License for more details.
15355
15356 You should have received a copy of the GNU General Public License
15357 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.