* alloc.c (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c9d624c6
PE
12011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
c78baabf 3 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6 when a (possibly-narrower) signed value would do just as well.
7 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8
c9d624c6
PE
9 * alloc.c: Catch some string size overflows that we were missing.
10 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11 for convenience in STRING_BYTES_MAX.
12 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
13 The definition here is exact; the one in lisp.h was approximate.
14 (allocate_string_data): Check for string overflow. This catches
15 some instances we weren't catching before. Also, it catches
16 size_t overflow on (unusual) hosts where SIZE_MAX <= min
17 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
18 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 19
c9d624c6
PE
20 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
21 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
22 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
23
2bccce07
PE
242011-06-07 Paul Eggert <eggert@cs.ucla.edu>
25
353032ce
PE
26 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
27
2bccce07
PE
28 * alloc.c (Fmake_string): Check for out-of-range init.
29
a54e3482
DC
302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
31
32 * fns.c (Fputhash): Document return value.
33
60002bf5
CY
342011-06-06 Chong Yidong <cyd@stupidchicken.com>
35
36 * image.c (gif_load): Implement gif89a spec "no disposal" method.
37
0c671da6 382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 39
b862a52a 40 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 41
be44ca6c
PE
42 Check for overflow when converting integer to cons and back.
43 * charset.c (Fdefine_charset_internal, Fdecode_char):
44 Use cons_to_unsigned to catch overflow.
45 (Fencode_char): Use INTEGER_TO_CONS.
46 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
47 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
48 * data.c (long_to_cons, cons_to_long): Remove.
49 (cons_to_unsigned, cons_to_signed): New functions.
50 These signal an error for invalid or out-of-range values.
51 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
52 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
53 * font.c (Ffont_variation_glyphs):
54 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
55 * lisp.h: Include <intprops.h>.
56 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
57 (cons_to_signed, cons_to_unsigned): New decls.
58 (long_to_cons, cons_to_long): Remove decls.
59 * undo.c (record_first_change): Use INTEGER_TO_CONS.
60 (Fprimitive_undo): Use CONS_TO_INTEGER.
61 * xfns.c (Fx_window_property): Likewise.
62 * xselect.c: Include <limits.h>.
63 (x_own_selection, selection_data_to_lisp_data):
64 Use INTEGER_TO_CONS.
65 (x_handle_selection_request, x_handle_selection_clear)
66 (x_get_foreign_selection, Fx_disown_selection_internal)
67 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
68 (lisp_data_to_selection_data): Use cons_to_unsigned.
69 (x_fill_property_data): Use cons_to_signed.
70 Report values out of range.
71
d1f3d2af
PE
72 Check for buffer and string overflow more precisely.
73 * buffer.h (BUF_BYTES_MAX): New macro.
74 * lisp.h (STRING_BYTES_MAX): New macro.
75 * alloc.c (Fmake_string):
76 * character.c (string_escape_byte8):
77 * coding.c (coding_alloc_by_realloc):
78 * doprnt.c (doprnt):
79 * editfns.c (Fformat):
80 * eval.c (verror):
81 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
82 since they may not be the same number.
83 * editfns.c (Finsert_char):
84 * fileio.c (Finsert_file_contents):
85 Likewise for BUF_BYTES_MAX.
86
dd52fcea
PE
87 * image.c: Use ptrdiff_t, not int, for sizes.
88 (slurp_file): Switch from int to ptrdiff_t.
89 All uses changed.
90 (slurp_file): Check that file size fits in both size_t (for
91 malloc) and ptrdiff_t (for sanity and safety).
92
7f9bbdbb
PE
93 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
94 if b->modtime has its maximal value.
95
dfe18f82
PE
96 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
97
84acfcf0
PE
98 Don't assume time_t can fit into int.
99 * buffer.h (struct buffer.modtime): Now time_t, not int.
100 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
101 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
102
ccd9a01a
PE
103 Minor fixes for signed vs unsigned integers.
104 * character.h (MAYBE_UNIFY_CHAR):
105 * charset.c (maybe_unify_char):
106 * keyboard.c (read_char, reorder_modifiers):
107 XINT -> XFASTINT, since the integer must be nonnegative.
108 * ftfont.c (ftfont_spec_pattern):
109 * keymap.c (access_keymap, silly_event_symbol_error):
110 XUINT -> XFASTINT, since the integer must be nonnegative.
111 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
112 since it makes no difference and we prefer signed.
113 * keyboard.c (record_char): Use XUINT when all the neighbors do.
114 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
115 nonnegative.
116
d6d100dd
SM
1172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
118
119 * window.h (Fwindow_frame): Declare.
120
2b6148e4
PE
1212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
122
123 * alloc.c: Simplify handling of large-request failures (Bug#8800).
124 (SPARE_MEMORY): Always define.
125 (LARGE_REQUEST): Remove.
126 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
127
f230ecc9
MR
1282011-06-06 Martin Rudalics <rudalics@gmx.at>
129
727e958e
MR
130 * lisp.h: Move EXFUNS for Fframe_root_window,
131 Fframe_first_window and Fset_frame_selected_window to window.h.
132
133 * window.h: Move EXFUNS for Fframe_root_window,
134 Fframe_first_window and Fset_frame_selected_window here from
135 lisp.h.
136
137 * frame.c (Fwindow_frame, Fframe_first_window)
138 (Fframe_root_window, Fframe_selected_window)
139 (Fset_frame_selected_window): Move to window.c.
140 (Factive_minibuffer_window): Move to minibuf.c.
141 (Fother_visible_frames_p): New function.
142
143 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
144
f230ecc9
MR
145 * window.c (decode_window, decode_any_window): Move up in code.
146 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
147 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
148 (Fwindow_buffer): Move up and rewrite doc-string.
149 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
150 (Fwindow_prev): New functions.
727e958e
MR
151 (Fwindow_frame): Move here from frame.c. Accept any window as
152 argument.
153 (Fframe_root_window, Fframe_first_window)
154 (Fframe_selected_window): Move here from frame.c. Accept frame
155 or arbitrary window as argument. Update doc-strings.
156 (Fminibuffer_window): Move up in code.
157 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
158 (Fset_frame_selected_window): Move here from frame.c.
159 Marginal rewrite.
727e958e
MR
160 (Fselected_window, select_window, Fselect_window): Move up in
161 code. Minor doc-string fixes.
f230ecc9 162
4d09bcf6
PE
1632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
164
165 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
166 Do not assume that spare memory exists; that assumption is valid
167 only if SYSTEM_MALLOC.
168 (LARGE_REQUEST): New macro, so that the issue of large requests
169 is separated from the issue of spare memory.
170
810928a2
AS
1712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
172
172418ad
AS
173 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
174 format. (Bug#8806)
175
43f862f7
AS
176 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
177
810928a2
AS
178 * xfns.c (x_set_scroll_bar_default_width): Move declarations
179 before statements.
180
a059fe24
JD
1812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
182
183 * gtkutil.c (xg_get_default_scrollbar_width): New function.
184
185 * gtkutil.h: Declare xg_get_default_scrollbar_width.
186
187 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
188 min width by calling x_set_scroll_bar_default_width (Bug#8505).
189
989bf368
JB
1902011-06-05 Juanma Barranquero <lekktu@gmail.com>
191
192 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
193
4b80f674
CY
1942011-06-04 Chong Yidong <cyd@stupidchicken.com>
195
196 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
197 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
198 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
199 New error handlers.
4b80f674
CY
200 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
201 Obey Vx_select_enable_clipboard_manager. Catch errors in
202 x_clipboard_manager_save (Bug#8779).
203 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 204 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 205
99a33b77 2062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
207
208 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
209
99a33b77 2102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
211
212 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
213 in the current matrix if keep_current_p is non-zero.
214
8264569d
EZ
2152011-06-04 Eli Zaretskii <eliz@gnu.org>
216
217 * bidi.c (bidi_level_of_next_char): Fix last change.
218
57f97249
EZ
2192011-06-03 Eli Zaretskii <eliz@gnu.org>
220
fec2107c 221 Support bidi reordering of text covered by display properties.
57f97249 222
fec2107c
EZ
223 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
224 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
225 (bidi_cache_search, bidi_cache_iterator_state)
226 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
227 (bidi_level_of_next_char, bidi_move_to_visually_next):
228 Support character positions inside a run of characters covered by a
fec2107c
EZ
229 display string.
230 (bidi_paragraph_init, bidi_resolve_explicit_1)
231 (bidi_level_of_next_char): Call bidi_fetch_char and
232 bidi_fetch_char_advance instead of FETCH_CHAR and
233 FETCH_CHAR_ADVANCE.
234 (bidi_init_it): Initialize new members.
235 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
236 definitions.
237 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
238 instead of using explicit *_CHAR codes.
d6d100dd
SM
239 (bidi_resolve_explicit, bidi_resolve_weak):
240 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
241 bidirectional text is supported only in multibyte buffers.
242 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
243 it to initialize the frame_window_p member of struct bidi_it.
244 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
245 (bidi_resolve_explicit, bidi_resolve_weak)
246 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
247 bidi_it->nchars is non-positive.
248 (bidi_level_of_next_char): Don't try to lookup the cache for the
249 next/previous character if nothing is cached there yet, or if we
250 were just reseat()'ed to a new position.
c40e2fb2 251
0e14fe90
EZ
252 * xdisp.c (set_cursor_from_row): Set start and stop points
253 according to the row's direction when priming the loop that looks
254 for the glyph on which to display cursor.
255 (single_display_spec_intangible_p): Function deleted.
256 (display_prop_intangible_p): Reimplement to call
257 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
258 Accept 3 additional arguments needed by handle_display_spec.
259 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
260 values: lists, `(when COND...)' forms, etc.
261 (single_display_spec_string_p): Support property values that are
262 lists with the argument STRING its top-level element.
263 (display_prop_string_p): Fix the condition for processing a
264 property that is a list to be consistent with handle_display_spec.
fec2107c 265 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
266 last portion of handle_display_prop.
267 (compute_display_string_pos): Accept additional argument
268 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
269 value of a `display' property is a "replacing spec".
270 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
271 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
272 the display property, but just return a value indicating whether
273 the display property will replace the characters it covers.
274 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
275 frame_window_p members of struct bidi_it.
d6d100dd
SM
276 (compute_display_string_pos, compute_display_string_end):
277 New functions.
fec2107c
EZ
278 (push_it): Accept second argument POSITION, where pop_it should
279 jump to continue iteration.
280 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 281
fec2107c
EZ
282 * keyboard.c (adjust_point_for_property): Adjust the call to
283 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
284
285 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
286 (bidi_init_it): Update prototypes.
287 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
288 (compute_display_string_pos, compute_display_string_end):
289 Declare prototypes.
fec2107c
EZ
290 (struct bidi_it): New members nchars and disp_pos. ch_len is now
291 EMACS_INT.
fc6f18ce 292
40087514 2932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 294
57f53182
PE
295 Malloc failure behavior now depends on size of allocation.
296 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
297 * lisp.h: Change signatures accordingly.
298 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
299 All callers changed. (Bug#8762)
300
301 * gnutls.c: Use Emacs's memory allocators.
302 Without this change, the gnutls library would invoke malloc etc.
303 directly, which causes problems on non-SYNC_INPUT hosts, and which
304 runs afoul of improving memory_full behavior. (Bug#8761)
305 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
306 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
307 xfree instead of the default malloc, realloc, free.
308 (Fgnutls_boot): No need to check for memory allocation failure,
309 since xmalloc does that for us.
310
ac32cd99 311 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
312 * category.c (hash_get_category_set):
313 * ccl.c (ccl_driver):
314 * charset.c (Fdefine_charset_internal):
315 * charset.h (struct charset.hash_index):
316 * composite.c (get_composition_id, gstring_lookup_cache)
317 (composition_gstring_put_cache):
318 * composite.h (struct composition.hash_index):
319 * dispextern.h (struct image.hash):
320 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
321 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
322 (hashfn_equal, hashfn_user_defined, make_hash_table)
323 (maybe_resize_hash_table, hash_lookup, hash_put)
324 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
325 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
326 (Fsxhash, Fgethash, Fputhash, Fmaphash):
327 * image.c (make_image, search_image_cache, lookup_image)
328 (xpm_put_color_table_h):
329 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 330 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
331 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
332 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
333 * alloc.c (allocate_vectorlike):
334 Check for overflow in vector size calculations.
335 * ccl.c (ccl_driver):
336 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
337 * fns.c, image.c: Remove unnecessary static decls that would otherwise
338 need to be updated by these changes.
40087514
PE
339 * fns.c (make_hash_table, maybe_resize_hash_table):
340 Check for integer overflow with large hash tables.
0de4bb68
PE
341 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
342 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
343 (SXHASH_REDUCE): New macro.
344 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
345 Use it instead of discarding useful hash info with large hash values.
346 (sxhash_float): New function.
347 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
348 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
349 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
350 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
351 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
352 Adjust signatures to match updated version of code.
353 (consing_since_gc): Now EMACS_INT, since a single hash table can
354 use more than INT_MAX bytes.
355
698d32e2
DN
3562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
357
358 Make it possible to build with GCC-4.6+ -O2 -flto.
359
360 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
361
fd6fa53f
SM
3622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
363
364 * minibuf.c (get_minibuffer, read_minibuf_unwind):
365 Call minibuffer-inactive-mode.
366
864db017
JB
3672011-05-31 Juanma Barranquero <lekktu@gmail.com>
368
369 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
370 Update dependencies.
371
2ad0baf4
DN
3722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
373
374 * data.c (init_data): Remove code for UTS, this system is not
375 supported anymore.
376
4fcc2638
DN
3772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
378
379 Don't force ./temacs to start in terminal mode.
380
381 * frame.c (make_initial_frame): Initialize faces in all cases, not
382 only when CANNOT_DUMP is defined.
383 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
384
c56e0fd5
DN
3852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
386
387 * dispnew.c (add_window_display_history): Use const for the string
388 pointer. Remove declaration, not needed.
389
333d54da 3902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 391
55d4c1b2 392 Use 'inline', not 'INLINE'.
333d54da 393 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
394 * alloc.c, fontset.c (INLINE): Remove.
395 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
396 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
397 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
398 * gmalloc.c (register_heapinfo): Use inline unconditionally.
399 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
400
738db178
DN
4012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
402
403 Make it possible to run ./temacs.
404
405 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
406 syms_of_callproc does the same thing. Remove test for
407 "initialized", do it in the caller.
408 * emacs.c (main): Avoid calling set_initial_environment when dumping.
409
620c53a6
SM
4102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
413 (read_minibuf): Use get_minibuffer.
414 (syms_of_minibuf): Use DEFSYM.
415 (Qmetadata): New var.
416 * data.c (Qbuffer): Don't make it static.
417 (syms_of_data): Use DEFSYM.
418
e003a292
PE
4192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
420
421 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
422 (CCL_CODE_MIN): New macro.
423
ed008a6d
PE
4242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
425
3687c2ef
PE
426 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
427
ed008a6d
PE
428 * eval.c (Qdebug): Now static.
429 * lisp.h (Qdebug): Remove decl. This reverts a part of the
430 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
431 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
432
d66c4c7c
CY
4332011-05-29 Chong Yidong <cyd@stupidchicken.com>
434
435 * image.c: Various fixes to ImageMagick code comments.
436 (Fimagemagick_types): Doc fix.
437
5fbc2025
PE
4382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
439
0196f88a
PE
440 Minor fixes prompted by GCC 4.6.0 warnings.
441
442 * xselect.c (converted_selections, conversion_fail_tag): Now static.
443
5fbc2025
PE
444 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
445 (x_clipboard_manager_save_all): Move extern decl to ...
446 * xterm.h: ... here, so that it can be checked for consistency.
447
1dd3c2d9
CY
4482011-05-29 Chong Yidong <cyd@stupidchicken.com>
449
450 * xselect.c (x_clipboard_manager_save_frame)
451 (x_clipboard_manager_save_all): New functions.
452 (Fx_clipboard_manager_save): Lisp function deleted.
453
454 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
455 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
456
457 * xterm.h: Update prototype.
458
5ba6571d
WX
4592011-05-28 William Xu <william.xwl@gmail.com>
460
461 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
462 exiting (Bug#8239).
463
3eaff834
JM
4642011-05-28 Jim Meyering <meyering@redhat.com>
465
e1900994 466 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
467 * fns.c (to_uchar): Define.
468 (crypto_hash_function): Use it to convert some newly-signed
469 variables to unsigned, to avoid sign-extension bugs. For example,
470 without this change, (md5 "truc") would evaluate to
471 45723a2aff78ff4fff7fff1114760e62 rather than the expected
472 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 473 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 474
0f6990a7
PE
4752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
476
477 Integer overflow fixes.
c8a9ca5a 478
08686060
PE
479 * dbusbind.c: Serial number integer overflow fixes.
480 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
481 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
482 to hold a serial number that is too large for a fixnum.
483 (Fdbus_method_return_internal, Fdbus_method_error_internal):
484 Check for serial numbers out of range. Decode any serial number
59568bf0 485 that was so large that it became a float. (Bug#8722)
08686060 486
2d1fc3c7
PE
487 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
488 (Fdbus_call_method, Fdbus_call_method_asynchronously):
489 Use XFASTINT rather than XUINT when numbers are nonnegative.
490 (xd_append_arg, Fdbus_method_return_internal):
491 (Fdbus_method_error_internal): Likewise. Also, for unsigned
492 arguments, check that Lisp number is nonnegative, rather than
59568bf0 493 silently wrapping negative numbers around. (Bug#8722)
30217ff0 494 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 495 (Bug#8722)
2d1fc3c7 496
c8a9ca5a
PE
497 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
498
519e1d69
PE
499 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
500
30569699
PE
501 ccl: add integer overflow checks
502 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
503 (IN_INT_RANGE): New macros.
504 (ccl_driver): Use them to check for integer overflow when
505 decoding a CCL program. Many of the new checks are whether XINT (x)
506 fits in int; it doesn't always, on 64-bit hosts. The new version
507 doesn't catch all possible integer overflows, but it's an
847044ea 508 improvement. (Bug#8719)
30569699 509
c11285dc
PE
510 * alloc.c (make_event_array): Use XINT, not XUINT.
511 There's no need for unsigned here.
512
fdccd48e
PE
513 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
514 This follows up to the 2011-05-06 change that substituted uintptr_t
515 for EMACS_INT. This case wasn't caught back then.
516
37910ab2
PE
517 Rework Fformat to avoid integer overflow issues.
518 * editfns.c: Include <float.h> unconditionally, as it's everywhere
519 now (part of C89). Include <verify.h>.
520 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
521 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
522 (Fformat): Avoid the prepass trying to compute sizes; it was only
523 approximate and thus did not catch overflow reliably. Instead, walk
524 through the format just once, formatting and computing sizes as we go,
525 checking for integer overflow at every step, and allocating a larger
526 buffer as needed. Keep track separately whether the format is
527 multibyte. Keep only the most-recently calculated precision, rather
528 than them all. Record whether each argument has been converted to
529 string. Use EMACS_INT, not int, for byte and char and arg counts.
530 Support field widths and precisions larger than INT_MAX. Avoid
531 sprintf's undefined behavior with conversion specifications such as %#d
532 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
533 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
534 formatting out-of-range floating point numbers with int
535 formats. (Bug#8668)
536
2e6578fb
PE
537 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
538
0ae6bdee
PE
539 * data.c: Avoid integer truncation in expressions involving floats.
540 * data.c: Include <intprops.h>.
541 (arith_driver): When there's an integer overflow in an expression
542 involving floating point, convert the integers to floating point
543 so that the resulting value does not suffer from catastrophic
544 integer truncation. For example, on a 64-bit host (* 4
545 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
546 Do not rely on undefined behavior after integer overflow.
547
de883a70
PE
548 merge count_size_as_multibyte, parse_str_to_multibyte
549 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 550 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
551 Check for integer overflow.
552 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
553 since it's now a duplicate of the other. This is more of
554 a character than a buffer op, so better that it's in character.c.
555 * fns.c, print.c: Adjust to above changes.
556
2ff916cb
PE
5572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
558
559 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
560
f1b54466
PE
5612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
562
fb1ac845
PE
563 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
564 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
565 (x_clipboard_manager_save): Now static.
566 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
567
f1b54466
PE
568 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
569 (crypto_hash_function): Now static.
570 Fix pointer signedness problems. Avoid unnecessary initializations.
571
a9f737ee
CY
5722011-05-27 Chong Yidong <cyd@stupidchicken.com>
573
574 * termhooks.h (Vselection_alist): Make it terminal-local.
575
576 * terminal.c (create_terminal): Initialize it.
577
578 * xselect.c: Support for clipboard managers.
579 (Vselection_alist): Move to termhooks.h as terminal-local var.
580 (LOCAL_SELECTION): New macro.
581 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
582 (symbol_to_x_atom): Remove gratuitous arg.
583 (x_handle_selection_request, lisp_data_to_selection_data)
584 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
585 (x_own_selection, x_get_local_selection, x_convert_selection):
586 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
587 (some_frame_on_display): Delete unused function.
588 (Fx_own_selection_internal, Fx_get_selection_internal)
589 (Fx_disown_selection_internal, Fx_selection_owner_p)
590 (Fx_selection_exists_p): New optional frame arg.
591 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
592 (x_handle_selection_clear): Don't treat other terminals with the
593 same keyboard specially. Use the terminal-local Vselection_alist.
594 (x_clear_frame_selections): Use Frun_hook_with_args.
595
596 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
597
598 * xterm.h: Add support for those atoms.
599
e067f0c1
CY
6002011-05-26 Chong Yidong <cyd@stupidchicken.com>
601
602 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
603 (converted_selections, conversion_fail_tag): New global variables.
604 (x_selection_request_lisp_error): Free the above.
605 (x_get_local_selection): Remove unnecessary code.
606 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
607 of converted selections stored in converted_selections.
608 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
609 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
610 (x_convert_selection): New function.
611 (x_handle_selection_event): Simplify.
612 (x_get_foreign_selection): Don't ignore incoming requests while
613 waiting for an answer; this will fail when we implement
614 SAVE_TARGETS, and seems unnecessary anyway.
615 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
616 (Vx_sent_selection_functions): Doc fix.
617
0f4aebc0
LL
6182011-05-26 Leo Liu <sdl.web@gmail.com>
619
620 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
621
e61124cd
YM
6222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
623
624 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
625
626 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
627 for fringe update if it has periodic bitmap.
628 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
629 and fringe_bitmap_periodic_p.
630
631 * fringe.c (get_fringe_bitmap_data): New function.
632 (draw_fringe_bitmap_1, update_window_fringes): Use it.
633 (update_window_fringes): Record periodicity of fringe bitmap in glyph
634 row. Mark glyph row for fringe update if periodicity changed.
635
636 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
637 for fringe update unless it has periodic bitmap.
638
f16d9837
KH
6392011-05-25 Kenichi Handa <handa@m17n.org>
640
641 * xdisp.c (get_next_display_element): Set correct it->face_id for
642 a static composition.
643
e1b90ef6
LL
6442011-05-24 Leo Liu <sdl.web@gmail.com>
645
646 * deps.mk (fns.o):
647 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
648
649 * fns.c (crypto_hash_function, Fsha1): New function.
650 (Fmd5): Use crypto_hash_function.
651 (syms_of_fns): Add Ssha1.
652
7400048f
PE
6532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
654
655 * gnutls.c: Remove unused macros.
656 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
657 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
658 Remove macros that are defined and never used.
659 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
660
abb71cf4
CY
6612011-05-22 Chong Yidong <cyd@stupidchicken.com>
662
663 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
664 (Fx_get_selection_internal): Minor cleanup.
665 (Fx_own_selection_internal): Rename arguments for consistency with
666 select.el.
667
6307db39
PE
6682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
669
670 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
671
f3d4e0a4
CY
6722011-05-22 Chong Yidong <cyd@stupidchicken.com>
673
674 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
675
4d8ade89
YM
6762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
677
678 * dispnew.c (scrolling_window): Don't exclude the case that the
679 last enabled row in the desired matrix touches the bottom boundary.
680
32078c8d
GM
6812011-05-21 Glenn Morris <rgm@gnu.org>
682
683 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
684 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
685 and add some more files.
32078c8d 686
7285dc67
EZ
6872011-05-20 Eli Zaretskii <eliz@gnu.org>
688
689 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
690 report_file_error introduced by the change from 2011-05-07.
691
89d1bd22
PE
6922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
693
694 * systime.h (Time): Define only if emacs is defined.
695 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
696 where the include path doesn't have X11/X.h by default. See
697 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
698
e23640bb 6992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
700
701 * composite.c (find_automatic_composition): Fix previous change.
702
b9704ad9
GM
7032011-05-20 Glenn Morris <rgm@gnu.org>
704
705 * lisp.mk: New file, split from Makefile.in.
706 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
707 (shortlisp): Remove.
708 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
709
4a720484
GM
7102011-05-19 Glenn Morris <rgm@gnu.org>
711
712 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
713 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
714 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
715 (lisp): Set the order to that of loadup.el.
716 (shortlisp): Make it a copy of $lisp.
717 (SOME_MACHINE_LISP): Remove.
718 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
719 Use just $shortlisp, not $SOME_MACHINE_LISP too.
720
a28d4396
KH
7212011-05-18 Kenichi Handa <handa@m17n.org>
722
723 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
724 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
725 (find_automatic_composition): Mostly rewrite for efficiency.
726
a2b1fa8e
JB
7272011-05-18 Juanma Barranquero <lekktu@gmail.com>
728
729 * makefile.w32-in: Update dependencies.
730
8e1f5610
CS
7312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
732
733 * menu.c: Include limits.h (fixes the MS-Windows build broken by
734 revision 104625).
735
7025ee00 7362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 737
cdfa6eab
PE
738 Fix some integer overflow issues, such as string length overflow.
739
06d6db33
PE
740 * insdel.c (count_size_as_multibyte): Check for string overflow.
741
2b4560a8
PE
742 * character.c (lisp_string_width): Check for string overflow.
743 Use EMACS_INT, not int, for string indexes and lengths; in
744 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
745 the resulting string length overflows an EMACS_INT; instead,
746 report a string overflow if no precision given. When checking for
747 precision exhaustion, use a check that cannot possibly have
748 integer overflow. (Bug#8675)
749 * character.h (lisp_string_width): Adjust to new signature.
750
cb93f9be
PE
751 * alloc.c (string_overflow): New function.
752 (Fmake_string): Use it. This doesn't change behavior, but saves
753 a few bytes and will simplify future changes.
754 * character.c (string_escape_byte8): Likewise.
755 * lisp.h (string_overflow): New decl.
756
1a1f3366
PE
757 Fixups, following up to the user-interface timestamp change.
758 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
759 for UI timestamps, instead of unsigned long.
9fbd6841
PE
760 * msdos.c (mouse_get_pos): Likewise.
761 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
762 * w32gui.h (Time): Define by including "systime.h" rather than by
763 declaring it ourselves. (Bug#8664)
764
d4e3e4d3
PE
765 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
766 * image.c (clear_image_cache): Likewise.
767
f6a24d19
PE
768 * term.c (term_mouse_position): Don't assume time_t wraparound.
769
08dc5ae6
PE
770 Be more systematic about user-interface timestamps.
771 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
772 and sometimes 'EMACS_UINT', to represent these timestamps.
773 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
774 This makes the code easier to follow, and makes it easier to catch
775 integer overflow bugs such as Bug#8664.
776 * frame.c (Fmouse_position, Fmouse_pixel_position):
777 Use Time, not unsigned long, for user-interface timestamps.
778 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
779 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
780 * keyboard.h (last_event_timestamp): Likewise.
781 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
782 * menu.h (xmenu_show): Likewise.
783 * term.c (term_mouse_position): Likewise.
784 * termhooks.h (struct input_event.timestamp): Likewise.
785 (struct terminal.mouse_position_hook): Likewise.
786 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
787 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
788 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
789 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
790 what it was before.
791 * menu.h, termhooks.h: Include "systime.h", for Time.
792
8e55734a
PE
793 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
794 Don't assume that the difference between two unsigned long values
795 can fit into an integer. At this point, we know button_down_time
796 <= event->timestamp, so the difference must be nonnegative, so
797 there's no need to cast the result if double-click-time is
798 nonnegative, as it should be; check that it's nonnegative, just in
799 case. This bug is triggered when events are more than 2**31 ms
86db42d2 800 apart (about 25 days). (Bug#8664)
8e55734a 801
841f1b75 802 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 803 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 804
3e26f69c
PE
805 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
806 that always fit in int. Use a sentinel instead of a counter, to
807 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
808 * frame.h (struct frame): Use int for menu_bar_items_used
809 instead of EMACS_INT, since it always fits in int.
3e26f69c 810
5cc152c0
PE
811 * menu.c (grow_menu_items): Check for int overflow.
812
d89eb65e
PE
813 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
814
5235bd3e
PE
815 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
816 Before, the code was not consistent. These values cannot exceed
817 2**31 - 1 so there's no need to make them unsigned.
818 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
819 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
820 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
821 as modifiers.
822 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
823
bc827e23
PE
824 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
825 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
826 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
827 presumably because the widths might not match.
828
78eb494e
PE
829 * window.c (size_window): Avoid needless test at loop start.
830
04f2d78b
CB
8312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
832
833 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
834
d2fc7e3d 8352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
836
837 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
838
d2fc7e3d 8392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
840
841 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
842 `width' to `bar_area_x' and `bar_area_width', respectively.
843 (x_scroll_run): Take account of fringe background extension.
844
04f2d78b
CB
845 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
846 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
847 `bar_area_width', respectively.
848 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
849 background extension.
850
79b70037
GM
8512011-05-10 Jim Meyering <meyering@redhat.com>
852
853 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
854
2f142cc5
JB
8552011-05-10 Juanma Barranquero <lekktu@gmail.com>
856
857 * image.c (Finit_image_library): Return t for built-in image types,
858 like pbm and xbm. (Bug#8640)
859
57679c86
AS
8602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
861
862 * w32menu.c (set_frame_menubar): Fix submenu allocation.
863
888c9e86
EZ
8642011-05-07 Eli Zaretskii <eliz@gnu.org>
865
b0512a1d
EZ
866 * w32console.c (Fset_screen_color): Doc fix.
867 (Fget_screen_color): New function.
868 (syms_of_ntterm): Defsubr it.
869
7285dc67
EZ
870 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
871 unlink the temporary file if Fcall_process didn't create it in the
872 first place.
873 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
874 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
875 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
876 cue to call_process_cleanup not to close that handle.
877
4d3fcc8e
BK
8782011-05-07 Ben Key <bkey76@gmail.com>
879
880 * makefile.w32-in: The bootstrap-temacs rule now makes use of
881 one of two shell specific rules, either bootstrap-temacs-CMD or
882 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
883 to the previous implementation of the bootstrap-temacs rule.
884 The bootstrap-temacs-CMD rule is similar to the previous
885 implementation of the bootstrap-temacs rule except that it
886 makes use of the ESC_CFLAGS variable instead of the CFLAGS
887 variable.
888
889 These changes, along with some changes to nt/configure.bat,
890 nt/gmake.defs, and nt/nmake.defs, are required to extend my
891 earlier fix to add support for --cflags and --ldflags options
892 that include quotes so that it works whether make uses cmd or
893 sh as the shell.
894
b4289b64
MA
8952011-05-06 Michael Albinus <michael.albinus@gmx.de>
896
897 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
898 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
899 is a constant.
900 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
901 a string. Handle both cases.
902 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
903 (Fdbus_register_method): Use Qinvalid_function.
904
af4c0e28
JB
9052011-05-06 Juanma Barranquero <lekktu@gmail.com>
906
907 * makefile.w32-in: Update dependencies.
908 (LISP_H): Add inttypes.h and stdin.h.
909 (PROCESS_H): Add unistd.h.
910
c51453d9
EZ
9112011-05-06 Eli Zaretskii <eliz@gnu.org>
912
913 * lread.c: Include limits.h (fixes the MS-Windows build broken by
914 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
915
8ff0ac3c 9162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 917
4c4b566b
PE
918 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
919
aab2b9b5
PE
920 * term.c (vfatal): Remove stray call to va_end.
921 It's not needed and the C Standard doesn't allow it here anyway.
922
c378da0b
PE
923 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
924 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
925
288b08c7
PE
926 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
927 bytes.
928
e3601888
PE
929 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
930
db6c0e74
PE
931 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
932
dd5963ea
PE
933 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
934
88c9450f
PE
935 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
936
2f9442b8
PE
937 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
938
c032b5f8
PE
939 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
940 * charset.c (Fdefine_charset_internal): Don't initialize
941 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 942 32-bit int (Bug#8600).
a108c10b
PE
943
944 * lread.c (read_integer): Be more consistent with string-to-number.
945 Use string_to_number to do the actual conversion; this avoids
946 rounding errors and fixes some other screwups. Without this fix,
947 for example, #x1fffffffffffffff was misread as -2305843009213693952.
948 (digit_to_number): Move earlier, for benefit of read_integer.
949 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 950 not a digit in any supported base. (Bug#8602)
a108c10b 951
ad5f9eea
PE
952 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
953
aec1708a
PE
954 * dispnew.c (scrolling_window): Return 1 if we scrolled,
955 to match comment at start of function. This also removes a
956 GCC warning about overflow in a 32+64-bit port.
957
47be4ab5
PE
958 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
959
371cac43
PE
960 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
961 Reported by Stefan Monnier in
962 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
963 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
964 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 965
d01a7826
PE
966 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
967 (EMACS_UINTPTR): Likewise, with uintptr_t.
968
7fd47d5c
PE
969 * lisp.h: Prefer 64-bit EMACS_INT if available.
970 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
971 on 32-bit hosts that have 64-bit int, so that they can access
972 large files.
122b0c86
PE
973 However, temporarily disable this change unless the temporary
974 symbol WIDE_EMACS_INT is defined.
7fd47d5c 975
8727937b
PE
976 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
977
8ac068ac
PE
978 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
979 This removes an assumption that EMACS_INT and long are the same
980 width as pointers. The assumption is true for Emacs porting targets
981 now, but we want to make other targets possible.
982 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
983 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
984 In the rest of the code, change types of integers that hold casted
985 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
986 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
987 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
988 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
989 No need to cast type when ORing.
990 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
991 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
992 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
993 assume EMACS_INT is the same width as char *.
994 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
995 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
996 Remove no-longer-needed casts.
997 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
998 (xg_tool_bar_help_callback, xg_make_tool_item):
999 Use EMACS_INTPTR to hold an integer
1000 that will be cast to void *; this can avoid a GCC warning
1001 if EMACS_INT is not the same width as void *.
1002 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1003 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1004 (current_message_1, set_message_1):
1005 Use a local to convert to proper width without a cast.
1006 * xmenu.c (dialog_selection_callback): Likewise.
1007
ede49d71
PE
1008 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1009 Also, don't assume VALBITS / RAND_BITS is less than 5,
1010 and don't rely on undefined behavior when shifting a 1 left into
1011 the sign bit.
1012 * lisp.h (get_random): Change signature to match.
1013
2f30ecd0
PE
1014 * lread.c (hash_string): Use size_t, not int, for hash computation.
1015 Normally we prefer signed values; but hashing is special, because
1016 it's better to use unsigned division on hash table sizes so that
1017 the remainder is nonnegative. Also, size_t is the natural width
1018 for hashing into memory. The previous code used 'int', which doesn't
1019 retain enough info to hash well into very large tables.
1020 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1021
2a866e7b
PE
1022 * dbusbind.c: Don't possibly lose pointer info when converting.
1023 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1024 Use XPNTR rather than XHASH, so that the high-order bits of
1025 the pointer aren't lost when converting through void *.
1026
51639eac
PE
1027 * eval.c (Fautoload): Don't double-shift a pointer.
1028
92394119
PE
1029 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1030
dbdb9a7c
JB
10312011-05-06 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * gnutls.c (DEF_GNUTLS_FN):
1034 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1035
db7a0b4f
AS
10362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1037
1038 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1039 marker. (Bug#8610)
1040
f7ff1b0f 10412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1042
1043 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1044 New version that can reserve upto 2GB of heap space.
1045
f7ff1b0f 10462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1047
1048 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1049
639c109b
TZ
10502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1051
1052 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1053 `gnutls_certificate_set_x509_key_file'.
1054
d2127135
JB
10552011-05-05 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1058 Update dependencies.
1059
e968f4f3
JB
10602011-05-04 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1063 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1064 Remove unused parameter `fildes'.
1065 * process.c (read_process_output, send_process): Don't pass it.
1066
84d358f0
JB
10672011-05-04 Juanma Barranquero <lekktu@gmail.com>
1068
1069 Fix previous change: the library cache is defined in w32.c.
1070 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1071 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1072
0898ca10
JB
10732011-05-04 Juanma Barranquero <lekktu@gmail.com>
1074
1075 Implement dynamic loading of GnuTLS on Windows.
1076
1077 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1078 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1079 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1080 Declare.
1081
1082 * gnutls.c (Qgnutls_dll): Define.
1083 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1084 (gnutls_*): Declare function pointers.
1085 (init_gnutls_functions): New function to initialize function pointers.
1086 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1087 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1088 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1089 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1090 (emacs_gnutls_write, emacs_gnutls_read)
1091 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1092 (Fgnutls_available_p): New function.
1093 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1094 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1095 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1096
1097 * image.c: Include w32.h.
1098 (Vimage_type_cache): Delete.
1099 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1100 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1101 (w32_delayed_load): Move to w32.c.
1102
1103 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1104
1105 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1106 (w32_delayed_load): Move from image.c. When loading a library, record
1107 its filename in the :loaded-from property of the library id.
1108 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1109 Initialize and staticpro them.
1110 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1111
1112 * process.c: Include lisp.h before w32.h, not after.
1113 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1114 instead of gnutls_record_check_pending.
1115
1116 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1117
ff4de4aa
TZ
11182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1119
1120 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1121 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1122 as passed in.
1123
abe95abb
JD
11242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1125
1126 * xterm.c (x_set_frame_alpha): Do not set property on anything
1127 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1128
e16e55d4
JB
11292011-05-02 Juanma Barranquero <lekktu@gmail.com>
1130
1131 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1132
bafcf6a5
JB
11332011-05-02 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1136 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1137 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1138 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1139 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1140 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1141 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1142 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1143 (Qgnutls_bootprop_callbacks_verify): Make static.
1144
e7a6747f
AS
11452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1146
19ed11ba
AS
1147 * callproc.c: Indentation fixup.
1148
e7a6747f 1149 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1150 (wait_for_termination, interruptible_wait_for_termination):
1151 Move after wait_for_termination_1.
e7a6747f 1152
1ef14cb4
LMI
11532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1154
1155 * sysdep.c (interruptible_wait_for_termination): New function
1156 which is like wait_for_termination, but allows keyboard
1157 interruptions.
1158
1159 * callproc.c (Fcall_process): Add (:file "file") as an option for
1160 the STDOUT buffer.
1161 (Fcall_process_region): Ditto.
1162
330d880c
EZ
11632011-04-30 Eli Zaretskii <eliz@gnu.org>
1164
8db90b73
EZ
1165 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1166 rather than `XVECTOR (FOO)->size'.
1167
330d880c
EZ
1168 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1169 inttypes.h, as a gnulib replacement is used if it not available in
1170 system headers.
1171
15cbd324
EZ
11722011-04-21 Eli Zaretskii <eliz@gnu.org>
1173
1174 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1175 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1176 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1177
1178 * coding.c (coding_alloc_by_realloc): Error out if destination
1179 will grow beyond MOST_POSITIVE_FIXNUM.
1180 (decode_coding_emacs_mule): Abort if there isn't enough place in
1181 charbuf for the composition carryover bytes. Reserve an extra
1182 space for up to 2 characters produced in a loop.
1183 (decode_coding_iso_2022): Abort if there isn't enough place in
1184 charbuf for the composition carryover bytes.
1185
11862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1187
ae940cca
EZ
1188 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1189 aborting when %lld or %lll format is passed.
1190 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1191 %llo or %llx format is passed. (Bug#8545)
1192
03ab8921
EZ
1193 * window.c (window_scroll_line_based): Use a marker instead of
1194 simple variables to record original value of point. (Bug#7952)
1195
afda1437
EZ
1196 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1197 produced by %s or %c overflows available buffer space. (Bug#8545)
1198
f76dee0c
PE
11992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1202 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1203
fdc5744d
JB
12042011-04-28 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1207
638f053a
JB
12082011-04-28 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * keyboard.c (Qdelayed_warnings_hook): Define.
1211 (command_loop_1): Run `delayed-warnings-hook'
1212 if Vdelayed_warnings_list is non-nil.
1213 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1214 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1215
d178f871
EZ
12162011-04-28 Eli Zaretskii <eliz@gnu.org>
1217
1218 * doprnt.c (doprnt): Don't return value smaller than the buffer
1219 size if the message was truncated. (Bug#8545).
1220
b124fd93
JB
12212011-04-28 Juanma Barranquero <lekktu@gmail.com>
1222
1223 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1224 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1225
e810457d
PE
12262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1229
ea51cceb
JB
12302011-04-27 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * makefile.w32-in: Update dependencies.
1233
94dcfacf
EZ
12342011-04-27 Eli Zaretskii <eliz@gnu.org>
1235
1236 Improve `doprnt' and its usage. (Bug#8545)
1237 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1238 `format_end'. Remove support for %l as a conversion specifier.
1239 Don't use xrealloc. Improve diagnostics when the %l size modifier
1240 is used. Update the commentary.
1241
1242 * eval.c (verror): Simplify calculation of size_t.
1243
1244 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1245 messages.
1246
f61f41d7
PE
12472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1248
1249 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1250 change.
1251
96fb4434
PE
12522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1255 This makes this file independent of the recent pseudovector change.
1256
671875da 12572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1258
69e9b5a3
PE
1259 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1260
b5f869a7 1261 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1262 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1263 Remove unused local.
c8926152 1264 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1265
841a1577 1266 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1267 GCC 4.6.0 optimizes based on type-based alias analysis.
1268 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1269 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1270 != &v->size, and therefore "v->size = 1; b->size = 2; return
1271 v->size;" must therefore return 1. This assumption is incorrect
1272 for Emacs, since it type-puns struct Lisp_Vector * with many other
1273 types. To fix this problem, this patch adds a new type struct
f904488f 1274 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1275 and pseudovectors, and helps optimizing compilers not get fooled
1276 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1277 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1278 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1279 the size member.
eab3844f
PE
1280 (XSETPVECTYPE): Rewrite in terms of new macro.
1281 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1282 This is a bit clearer, and further avoids the possibility of
1283 undesirable aliasing.
1284 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1285 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1286 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1287 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1288 (ASIZE): Now uses header.size rather than size.
1289 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1290 to avoid the hassle of writing XVECTOR (foo)->header.size.
1291 (struct vectorlike_header): New type.
eab3844f
PE
1292 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1293 object, to help avoid aliasing.
1294 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1295 (SUBRP): Likewise, since Lisp_Subr is a special case.
1296 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1297 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1298 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1299 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1300 changed to be "header.size" and "header.next".
1301 * buffer.h (struct buffer): Likewise.
1302 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1303 * frame.h (struct frame): Likewise.
1304 * process.h (struct Lisp_Process): Likewise.
1305 * termhooks.h (struct terminal): Likewise.
1306 * window.c (struct save_window_data, struct saved_window): Likewise.
1307 * window.h (struct window): Likewise.
1308 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1309 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1310 * buffer.c (init_buffer_once): Likewise.
1311 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1312 special case.
1313 * process.c (Fformat_network_address): Use local var for size,
1314 for brevity.
1315
0df1eac5
PE
1316 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1317
847ab9d1 1318 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1319 * data.c (atof): Remove decl; no longer used or needed.
1320 (digit_to_number): Move to lread.c.
1321 (Fstring_to_number): Use new string_to_number function, to be
1322 consistent with how the Lisp reader treats infinities and NaNs.
1323 Do not assume that floating-point numbers represent EMACS_INT
1324 without losing information; this is not true on most 64-bit hosts.
1325 Avoid double-rounding errors, by insisting on integers when
1326 parsing non-base-10 numbers, as the documentation specifies.
1327 * lisp.h (string_to_number): New decl, replacing ...
1328 (isfloat_string): Remove.
bc0a5c13 1329 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1330 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1331 appears to have been a coding error. Similarly, do not accept
1332 strings like +-1e0 as floating point numbers. Do not report
1333 overflow for integer overflows unless the base is not 10 which
1334 means we have no simple and reliable way to continue.
1335 Break out the floating-point parsing into a new
1336 function string_to_number, so that Fstring_to_number parses
1337 floating point numbers consistently with the Lisp reader.
04f2d78b 1338 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1339 (E_CHAR, EXP_INT): Remove, replacing with ...
1340 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1341 (string_to_number): New function, replacing isfloat_string.
1342 This function checks for valid syntax and produces the resulting
1343 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1344 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1345 so that overflow for non-base-10 numbers is reported only when
1346 there's no portable and simple way to convert to floating point.
452f4150 1347
67769ffc
PE
1348 * textprop.c (set_text_properties_1): Rewrite for clarity,
1349 and to avoid GCC warning about integer overflow.
1350
c20db43f
PE
1351 * intervals.h (struct interval): Use EMACS_INT for members
1352 where EMACS_UINT might cause problems. See
1353 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1354 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1355 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1356 All uses changed.
37aa2f85
PE
1357 (offset_intervals): Tell GCC not to worry about length overflow
1358 when negating a negative length.
c20db43f 1359
2538aa2f
PE
1360 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1361 (overrun_check_free): Likewise.
1362
f2d3008d
PE
1363 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1364 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1365 word size.
1366
ec8df744
PE
1367 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1368 (gnutls_make_error): Rename local to avoid shadowing.
1369 (gnutls_emacs_global_deinit): ifdef out; not used.
1370 (Fgnutls_boot): Use const for pointer to readonly storage.
1371 Comment out unused local. Fix pointer signedness problems.
1372
640ee02d
PE
1373 * lread.c (openp): Don't stuff size_t into an 'int'.
1374 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1375 about possible signed overflow.
1376
6048fb2a
PE
1377 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1378 (GDK_KEY_g): Don't define if already defined.
1379 (xg_prepare_tooltip): Avoid pointer signedness problem.
1380 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1381
fa3c87e1
PE
1382 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1383 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1384
2172544b
PE
1385 * xfns.c (Fx_window_property): Simplify a bit,
1386 to make a bit faster and to avoid GCC 4.6.0 warning.
1387 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1388
9b821a21
PE
1389 * fns.c (internal_equal): Don't assume size_t fits in int.
1390
3c616cfa
PE
1391 * alloc.c (compact_small_strings): Tighten assertion a little.
1392
c2982e87
PE
1393 Replace pEd with more-general pI, and fix some printf arg casts.
1394 * lisp.h (pI): New macro, generalizing old pEd macro to other
1395 conversion specifiers. For example, use "...%"pI"d..." rather
1396 than "...%"pEd"...".
1397 (pEd): Remove. All uses replaced with similar uses of pI.
1398 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1399 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1400 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1401 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1402 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1403 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1404 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1405 64-bit hosts.
1406 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1407 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1408 * print.c (safe_debug_print, print_object): Likewise.
1409 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1410 to int.
6f04d126
PE
1411 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1412 avoiding the 0 flag, which is not portable.
c2982e87
PE
1413 * process.c (Fmake_network_process): Use pI to avoid cast.
1414 * region-cache.c (pp_cache): Likewise.
1415 * xdisp.c (decode_mode_spec): Likewise.
1416 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1417 behavior on 64-bit hosts with printf arg.
6f04d126 1418 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1419 (x_stop_queuing_selection_requests): Likewise.
1420 (x_get_window_property): Don't truncate byte count to an 'int'
1421 when tracing.
0b432f21 1422
5e073ec7
PE
1423 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1424 here, since it parses constructs like leading '-' and spaces,
1425 which are not wanted; and it overflows with large numbers.
1426 Instead, simply match F[0-9]+, which is what is wanted anyway.
1427
36372bf9
PE
1428 * alloc.c: Remove unportable assumptions about struct layout.
1429 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1430 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1431 (allocate_vectorlike, make_pure_vector): Use the new macros,
1432 plus offsetof, to remove unportable assumptions about struct layout.
1433 These assumptions hold on all porting targets that I know of, but
1434 they are not guaranteed, they're easy to remove, and removing them
1435 makes further changes easier.
1436
0b432f21
PE
1437 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1438 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1439 (string_overrun_cookie): Now const. Use initializers that
1440 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1441 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1442 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1443 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1444 multiple of sizeof (EMACS_INT); it need not be, if
1445 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1446 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1447
895009e1
JB
14482011-04-26 Juanma Barranquero <lekktu@gmail.com>
1449
1450 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1451
6a7a1b0b
TZ
14522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1453
1454 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1455 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1456 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1457
841a1577 14582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1459
1460 * lisp.h (Qdebug): List symbol.
895009e1 1461 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1462 * keyboard.c (debug-on-event): New variable.
1463 (handle_user_signal): Break into debugger when debug-on-event
1464 matches the current signal symbol.
1465
f2d3ba6f
DN
14662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1467
1468 * alloc.c (check_sblock, check_string_bytes)
1469 (check_string_free_list): Convert to standard C.
1470
42ce4c63
TZ
14712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1472
1473 * w32.c (emacs_gnutls_push): Fix typo.
1474
825cd63c
EZ
14752011-04-25 Eli Zaretskii <eliz@gnu.org>
1476
fb11d64d
EZ
1477 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1478 "cast to pointer from integer of different size".
1479
825cd63c
EZ
1480 Improve doprnt and its use in verror. (Bug#8545)
1481 * doprnt.c (doprnt): Document the set of format control sequences
1482 supported by the function. Use SAFE_ALLOCA instead of always
1483 using `alloca'.
1484
1485 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1486 is one byte too soon. Don't use xrealloc; instead xfree and
1487 xmalloc anew.
1488
e061a11b
TZ
14892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1490
1491 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1492 callbacks stage.
1493
1494 * gnutls.c: Renamed global_initialized to
1495 gnutls_global_initialized. Added internals for the
1496 :verify-hostname-error, :verify-error, and :verify-flags
1497 parameters of `gnutls-boot' and documented those parameters in the
1498 docstring. Start callback support.
1499 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1500 unless a fatal error occured. Call gnutls_alert_send_appropriate
1501 on error. Return error code.
1502 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1503 (emacs_gnutls_read): Likewise.
1504 (Fgnutls_boot): Return handshake error code.
1505 (emacs_gnutls_handle_error): New function.
1506 (wsaerror_to_errno): Likewise.
1507
1508 * w32.h (emacs_gnutls_pull): Add prototype.
1509 (emacs_gnutls_push): Likewise.
1510
1511 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1512 (emacs_gnutls_push): Likewise.
1513
15142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1515
1516 * process.c (wait_reading_process_output): Check if GnuTLS
1517 buffered some data internally if no FDs are set for TLS
1518 connections.
1519
1520 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1521 (LIBS): Link to USER_LIBS.
1522 ($(BLD)/gnutls.$(0)): New target.
1523
fa6996bc
EZ
15242011-04-24 Eli Zaretskii <eliz@gnu.org>
1525
eb35682e
EZ
1526 * xdisp.c (handle_single_display_spec): Rename the
1527 display_replaced_before_p argument into display_replaced_p, to
1528 make it consistent with the commentary. Fix typos in the
1529 commentary.
1530
e2ad650c
EZ
1531 * textprop.c (syms_of_textprop): Remove dead code.
1532 (copy_text_properties): Delete obsolete commentary about an
1533 interface that was deleted long ago. Fix typos in the description
1534 of arguments.
1535
1b2de274
EZ
1536 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1537 to changes in oldXMenu/XMenu.h from 2011-04-16.
1538 <menu_help_message, prev_menu_help_message>: Constify.
1539 (IT_menu_make_room): menu->help_text is now `const char **';
1540 adjust.
1541
1542 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1543 to changes in oldXMenu/XMenu.h from 2011-04-16.
1544 (struct XMenu): Declare `help_text' `const char **'.
1545
1546 * xfaces.c <Qunspecified>: Make extern again.
1547
1548 * syntax.c: Include sys/types.h before including regex.h, as
1549 required by Posix.
1550
762b15be
EZ
1551 * doc.c (get_doc_string): Improve the format passed to `error'.
1552
1553 * doprnt.c (doprnt): Improve commentary.
1554
1555 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1556
1557 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1558 them with etags.
1559
f1052e5d
EZ
1560 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1561 changes in globals.h immediately force recompilation.
762b15be
EZ
1562 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1563 $(CURDIR)/s/ms-w32.h.
1564 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1565
fa6996bc
EZ
1566 * character.c (Fchar_direction): Function deleted.
1567 (syms_of_character): Don't defsubr it.
1568 <char-direction-table>: Deleted.
1569
e6c3da20
EZ
15702011-04-23 Eli Zaretskii <eliz@gnu.org>
1571
1572 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1573 * doprnt.c: Include limits.h.
1574 (SIZE_MAX): New macro.
04f2d78b
CB
1575 (doprnt): Return a size_t value. 2nd arg is now size_t.
1576 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1577 Improve overflow protection. Support `l' modifier for integer
1578 conversions. Support %l conversion. Don't assume an EMACS_INT
1579 argument for integer conversions and for %c.
1580
1581 * lisp.h (doprnt): Restore prototype.
1582
1583 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1584 $(SRC)/character.h.
1585
1586 * Makefile.in (base_obj): Add back doprnt.o.
1587
1588 * deps.mk (doprnt.o): Add back prerequisites.
1589 (callint.o): Depend on character.h.
1590
1591 * eval.c (internal_lisp_condition_case): Include the handler
1592 representation in the error message.
1593 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1594 when breaking from the loop.
1595
1596 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1597
1598 * callint.c (Fcall_interactively): When displaying error message
1599 about invalid control letter, pass the character's codepoint, not
1600 a pointer to its multibyte form. Improve display of the character
1601 in octal and display also its hex code.
1602
1603 * character.c (char_string): Use %x to display the (unsigned)
1604 codepoint of an invalid character, to avoid displaying a bogus
1605 negative value.
1606
1607 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1608 `error', not SYMBOL_NAME itself.
1609
1610 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1611 character arguments to `error'.
1612
1613 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1614 to `error' in error message about FINAL_CHAR argument. Make sure
1615 FINAL_CHAR is a character, and use %c when it is passed as
1616 argument to `error'.
1617
4ffd0d6b 16182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1619
1620 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1621
1622 * w32.c: Include <time.h>.
1623 (sys_localtime): New function.
1624
4ffd0d6b 16252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1626
1627 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1628
4ffd0d6b 1629 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1630
4ffd0d6b 16312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1632
4ffd0d6b
GM
1633 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1634 zombies (Bug#8467).
aac0c6e3 1635
04c56954
EZ
16362011-04-19 Eli Zaretskii <eliz@gnu.org>
1637
1638 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1639 gl_state.e_property when gl_state.object is Qt.
1640
1641 * insdel.c (make_gap_larger): Remove limitation of buffer size
1642 to <= INT_MAX.
1643
16a43933
CY
16442011-04-18 Chong Yidong <cyd@stupidchicken.com>
1645
1646 * xdisp.c (lookup_glyphless_char_display)
1647 (produce_glyphless_glyph): Handle cons cell entry in
1648 glyphless-char-display.
1649 (Vglyphless_char_display): Document it.
1650
1651 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1652 glyphless-char-display.
1653
4581706e
CY
16542011-04-17 Chong Yidong <cyd@stupidchicken.com>
1655
1656 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1657
1658 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1659
1660 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1661 definition for no-X builds.
1662
4887c6e2 16632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1664
fd35b6f9
PE
1665 Static checks with GCC 4.6.0 and non-default toolkits.
1666
5c1ccb01
PE
1667 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1668
006c5daa
PE
1669 * process.c (keyboard_bit_set): Define only if SIGIO.
1670 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1671 (send_process): Repair possible setjmp clobbering.
1672
efc736d3
PE
1673 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1674
4e2fe2e6
PE
1675 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1676
f97334a2
PE
1677 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1678
4e75f29d
PE
1679 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1680 Define only if needed.
1681
90efadd1
PE
1682 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1683 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1684 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1685
3c647824
PE
1686 * dispextern.h (struct redisplay_interface): Rename param
1687 to avoid shadowing.
e264f262 1688 * termhooks.h (struct terminal): Likewise.
761383f4 1689 * xterm.c (xembed_send_message): Likewise.
3c647824 1690
b58c5c4a
PE
1691 * insdel.c (make_gap_smaller): Define only if
1692 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1693
cad59032
PE
1694 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1695 it.
1696
c339dc2e
PE
1697 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1698 so that we aren't warned about unused symbols.
1699
91a3e27b
PE
1700 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1701
399c71d3 1702 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1703
8ffc96f5
PE
1704 * xfns.c (x_real_positions): Mark locals as initialized.
1705
eef9bc79
PE
1706 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1707
098db9dd
PE
1708 * xterm.c: Fix problems found by static analysis with other toolkits.
1709 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1710 (x_dispatch_event): Declare static if USE_GTK, and
1711 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1712 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1713 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1714 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1715 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1716
eb18f6cc
PE
1717 * xmenu.c (menu_help_callback): Pointer type fixes.
1718 Use const pointers when pointing at readonly data. Avoid pointer
1719 signedness clashes.
1720 (FALSE): Remove unused macro.
1721 (update_frame_menubar): Remove unused decl.
1722
1fe72bf8
PE
1723 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1724
60d9e1db
PE
1725 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1726 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1727 (single_menu_item): Rename local to avoid shadowing.
1728
39261c26
PE
1729 * keyboard.c (make_lispy_event): Remove unused local var.
1730
018c5e19
PE
1731 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1732 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1733
63d2b86e
PE
1734 * bitmaps: Change bitmaps from unsigned char back to the X11
1735 compatible char. Avoid the old compiler warnings about
1736 out-of-range initializers by using, for example, '\xab' rather
1737 than 0xab.
1738
aefd87e1
PE
1739 * xgselect.c (xgselect_initialize): Check vs interface
1740 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1741
bf501fb9
PE
1742 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1743
e9829fdf
PE
1744 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1745 to read-only memory.
1746
1086c095
PE
1747 * fns.c (vector): Remove; this old hack is no longer needed.
1748
2baccd04 1749 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1750 Remove unused var.
dde42981 1751 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1752
72391843 1753 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1754
436c16df 1755 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1756 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1757 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1758
92bb796d 1759 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1760 (x_term_init): Remove local to avoid shadowing.
92bb796d 1761
764430a3 1762 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1763
1764 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1765 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1766
d1dfb56c
EZ
17672011-04-16 Eli Zaretskii <eliz@gnu.org>
1768
c4354cb4
EZ
1769 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1770
d1dfb56c
EZ
1771 Fix regex.c, syntax.c and friends for buffers > 2GB.
1772 * syntax.h (struct gl_state_s): Declare character position members
1773 EMACS_INT.
1774
1775 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1776
04f2d78b
CB
1777 * textprop.c (verify_interval_modification, interval_of):
1778 Declare arguments EMACS_INT.
d1dfb56c
EZ
1779
1780 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1781 EMACS_INT.
1782
1783 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1784
1785 * indent.c (Fvertical_motion): Local variable it_start is now
1786 EMACS_INT.
1787
1788 * regex.c (re_match, re_match_2, re_match_2_internal)
1789 (bcmp_translate, regcomp, regexec, print_double_string)
1790 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1791 (re_compile_pattern, re_exec): Declare arguments and local
1792 variables `size_t' and `ssize_t' and return values `regoff_t', as
1793 appropriate.
1794 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1795 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1796 <compile_stack_type>: `size' and `avail' are now `size_t'.
1797
1798 * regex.h <regoff_t>: Use ssize_t, not int.
1799 (re_search, re_search_2, re_match, re_match_2): Arguments that
1800 specify buffer/string position and length are now ssize_t and
1801 size_t. Return type is regoff_t.
1802
613052cd
BK
18032011-04-16 Ben Key <bkey76@gmail.com>
1804
1805 * nsfont.m: Fixed bugs in ns_get_family and
1806 ns_descriptor_to_entity that were caused by using free to
1807 deallocate memory blocks that were allocated by xmalloc (via
1808 xstrdup). This caused Emacs to crash when compiled with
1809 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1810 --enable-checking=xmallocoverrun). xfree is now used to
1811 deallocate these memory blocks.
1812
4170f62f 18132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1814
71b41406
PE
1815 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1816
9587a89d
PE
1817 emacs_write: Accept and return EMACS_INT for sizes.
1818 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1819 et seq.
1820 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1821 Accept and return EMACS_INT.
1822 (emacs_gnutls_write): Return the number of bytes written on
1823 partial writes.
1824 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1825 (emacs_read, emacs_write): Remove check for negative size, as the
1826 Emacs source code has been audited now.
9587a89d
PE
1827 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1828 (emacs_read, emacs_write): Use it.
273a5f82
PE
1829 * process.c (send_process): Adjust to the new signatures of
1830 emacs_write and emacs_gnutls_write. Do not attempt to store
1831 a byte offset into an 'int'; it might overflow.
9587a89d 1832 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1833
3e047f51
PE
1834 * sound.c: Don't assume sizes fit in 'int'.
1835 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1836 Return EMACS_INT, not int.
3e047f51 1837 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1838 Accept EMACS_INT, not int.
1839 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1840 record read return values.
1841
cc39a9db
BK
18422011-04-15 Ben Key <bkey76@gmail.com>
1843
c9d0ec6d
JB
1844 * keyboard.c (Qundefined): Don't declare static since it is used
1845 in nsfns.m.
1846 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1847 static since they are used in nsfont.m.
cc39a9db 1848
6c60eb9f
SM
18492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1850
1851 * process.c (Qprocessp): Don't declare static.
1852 * lisp.h (Qprocessp): Declare again.
1853
7990b61a
JB
18542011-04-15 Juanma Barranquero <lekktu@gmail.com>
1855
1856 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1857
5d4cb038
PE
18582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1859
8bd7b830 1860 Improve C-level modularity by making more things 'static'.
cd64ea1d 1861
e3b27b31
PE
1862 Don't publish debugger-only interfaces to other modules.
1863 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1864 (verify_bytepos, count_markers): Move decls to the only modules
1865 that need them.
1866 * region-cache.h (pp_cache): Likewise.
1867 * window.h (check_all_windows): Likewise.
1868 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1869
5d4cb038
PE
1870 * sysdep.c (croak): Now static, if
1871 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1872 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1873
1874 * alloc.c (refill_memory_reserve): Now static if
1875 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1876 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1877
e87b6180
PE
1878 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1879 Define only if USE_LUCID.
1880
ac64929e
PE
1881 * xrdb.c (x_customization_string, x_rm_string): Now static.
1882
6f37259d
PE
1883 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1884 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1885
1683e3ab
PE
1886 * xdisp.c (draw_row_with_mouse_face): Now static.
1887 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1888
de9c2632
PE
1889 * window.h (check_all_windows): Mark externally visible.
1890
2b96acb7
PE
1891 * window.c (window_deletion_count): Now static.
1892
1893 * undo.c: Make symbols static if they're not exported.
1894 (last_undo_buffer, last_boundary_position, pending_boundary):
1895 Now static.
1896
50436f33
PE
1897 * textprop.c (interval_insert_behind_hooks): Now static.
1898 (interval_insert_in_front_hooks): Likewise.
1899
64520e5c
PE
1900 * term.c: Make symbols static if they're not exported.
1901 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1902 (max_frame_lines, tty_set_terminal_modes):
1903 (tty_reset_terminal_modes, tty_turn_off_highlight):
1904 (get_tty_terminal): Now static.
1905 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1906 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1907 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1908 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1909 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1910
1fa53021
PE
1911 * sysdep.c: Make symbols static if they're not exported.
1912 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1913 Now static.
1914 (sigprocmask_set, full_mask): Remove; unused.
1915 (wait_debugging): Mark as visible.
1916 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1917 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1918
d4b43b22
PE
1919 * syntax.c (syntax_temp): Define only if !__GNUC__.
1920
b7c513d0
PE
1921 * sound.c (current_sound_device, current_sound): Now static.
1922
989b29ad
PE
1923 * search.c (searchbufs, searchbuf_head): Now static.
1924
13a55a78
PE
1925 * scroll.c (scroll_cost): Remove; unused.
1926 * dispextern.h (scroll_cost): Remove decl.
1927
de68a1fc
PE
1928 * region-cache.h (pp_cache): Mark as externally visible.
1929
40ccffa6
PE
1930 * process.c: Make symbols static if they're not exported.
1931 (process_tick, update_tick, create_process, chan_process):
1932 (Vprocess_alist, proc_buffered_char, datagram_access):
1933 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1934 (deactivate_process): Mark defn as static, as well as decl.
1935 * lisp.h (create_process): Remove decl.
1936 * process.h (chan_process, Vprocess_alist): Remove decls.
1937
ad64fc97
PE
1938 * print.c: Make symbols static if they're not exported.
1939 (print_depth, new_backquote_output, being_printed, print_buffer):
1940 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1941 (print_interval, print_number_index, initial_stderr_stream):
1942 Now static.
1943 * lisp.h (Fprinc): Remove decl.
1944 (debug_output_compilation_hack): Mark as externally visible.
1945
adddb265
PE
1946 * sysdep.c (croak): Move decl from here to syssignal.h.
1947 * syssignal.h (croak): Put it here, so the API can be checked when
1948 'croak' is called from dissociate_if_controlling_tty.
1949
1717ede2
PE
1950 * minibuf.c: Make symbols static if they're not exported.
1951 (minibuf_save_list, choose_minibuf_frame): Now static.
1952 * lisp.h (choose_minibuf_frame): Remove decl.
1953
fa5fb2bc
PE
1954 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1955
1e3890d1
PE
1956 * lread.c: Make symbols static if they're not exported.
1957 (read_objects, initial_obarray, oblookup_last_bucket_number):
1958 Now static.
1959 (make_symbol): Remove; unused.
1960 * lisp.h (initial_obarray, make_symbol): Remove decls.
1961
8a1414fa
PE
1962 * keyboard.c: Make symbols static if they're not exported.
1963 (single_kboard, recent_keys_index, total_keys, recent_keys):
1964 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1965 (this_single_command_key_start, echoing, last_auto_save):
1966 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1967 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1968 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1969 (Vlispy_mouse_stem, double_click_count):
1970 Now static.
1971 (force_auto_save_soon): Define only if SIGDANGER.
1972 (ignore_mouse_drag_p): Now static if
1973 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1974 (print_help): Remove; unused.
1975 (stop_character, last_timer_event): Mark as externally visible.
1976 * keyboard.h (ignore_mouse_drag_p): Declare only if
1977 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1978 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1979 * lisp.h (echoing): Remove decl.
1980 (force_auto_save_soon): Declare only if SIGDANGER.
1981 * xdisp.c (redisplay_window): Simplify code, to make it more
1982 obvious that ignore_mouse_drag_p is not accessed if !defined
1983 USE_GTK && !defined HAVE_NS.
1984
93ea6e8f
PE
1985 * intervals.c: Make symbols static if they're not exported.
1986 (merge_properties_sticky, merge_interval_right, delete_interval):
1987 Now static.
1988 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1989
77382fcc
PE
1990 * insdel.c: Make symbols static if they're not exported.
1991 However, leave prepare_to_modify_buffer alone. It's never
1992 called from outside this function, but that appears to be a bug.
1993 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1994 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1995 (adjust_after_replace_noundo): Remove; unused.
1996 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1997 (signal_before_change): Remove decls.
77382fcc 1998
9306c32e
PE
1999 * indent.c (val_compute_motion, val_vmotion): Now static.
2000
cd44d2eb
PE
2001 * image.c: Make symbols static if they're not exported.
2002 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2003 if USE_GTK.
2004 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2005 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2006
ad9a7a06
PE
2007 * fringe.c (standard_bitmaps): Now static.
2008 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2009
81626931
PE
2010 * frame.c: Make symbols static if they're not exported.
2011 (x_report_frame_params, make_terminal_frame): Now static.
2012 (get_frame_param): Now static, unless HAVE_NS.
2013 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2014 (x_get_resource_string): Remove; not used.
2015 * frame.h (make_terminal_frame, x_report_frame_params):
2016 (x_get_resource_string); Remove decls.
2017 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2018 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2019
239f9db9
PE
2020 * font.c, fontset.c: Make symbols static if they're not exported.
2021 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2022 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2023 * font.c (font_close_object): Now static.
2024 * font.h (font_close_object): Remove.
2025 * fontset.c (FONTSET_OBJLIST): Remove.
2026 (free_realized_fontset) #if-0 the body, which does nothing.
2027 (face_suitable_for_char_p): #if-0, as it's never called.
2028 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2029 * xfaces.c (face_at_string_position):
2030 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2031 since 0 is always ASCII.
2032
dfcf3579
PE
2033 * fns.c (weak_hash_tables): Now static.
2034
5045092b
PE
2035 * fileio.c: Make symbols static if they're not exported.
2036 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2037 (Vwrite_region_annotation_buffers): Now static.
2038
57a96f5c
PE
2039 * eval.c: Make symbols static if they're not exported.
2040 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2041 * lisp.h (backtrace_list): Remove decl.
2042
35f08c38
PE
2043 * emacs.c: Make symbols static if they're not exported.
2044 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2045 (fatal_error_code, fatal_error_signal_hook, standard_args):
2046 Now static.
2047 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2048 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2049 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2050 * lisp.h (fatal_error_signal_hook): Remove decl.
2051 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2052
f44bd759
PE
2053 * editfns.c: Move a (normally-unused) function to its only use.
2054 * editfns.c, lisp.h (get_operating_system_release): Remove.
2055 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2056 worth the hassle of breaking this out.
2057
b532497d
PE
2058 * xterm.c: Make symbols static if they're not exported.
2059 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2060 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2061 (x_destroy_window, x_delete_display):
2062 Now static.
2063 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2064 (x_mouse_leave): Remove; unused.
2065 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2066 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2067 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2068 Remove decls.
2069 (x_mouse_leave): Declare only if WINDOWSNT.
2070 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2071 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2072 USE_X_TOOLKIT.
2073
1675728f
PE
2074 * ftxfont.c: Make symbols static if they're not exported.
2075 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2076 HAVE_FREETYPE.
2077 * font.h (ftxfont_driver): Likewise.
2078
e4cebfca
PE
2079 * xfns.c: Make symbols static if they're not exported.
2080 (x_last_font_name, x_display_info_for_name):
2081 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2082 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2083 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2084 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2085 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2086 (last_show_tip_args): Now static.
2087 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2088 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2089 (x_screen_planes): Remove; unused.
2090 * dispextern.h (x_screen_planes): Remove decl.
2091
5bf46f05
PE
2092 * dispnew.c: Make symbols static if they're not exported.
2093 * dispextern.h (redraw_garbaged_frames, scrolling):
2094 (increment_row_positions): Remove.
2095 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2096 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2097 Now static.
2098 (redraw_garbaged_frames): Remove; unused.
2099
435f4c28
PE
2100 * xfaces.c: Make symbols static if they're not exported.
2101 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2102 Remove decls.
2103 * xterm.h (defined_color): Remove decls.
2104 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2105 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2106 (menu_face_changed_default, defined_color, free_realized_face):
2107 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2108 (ascii_face_of_lisp_face): Remove; unused.
2109
8524aef3
PE
2110 * xdisp.c: Make symbols static if they're not exported.
2111 * dispextern.h (scratch_glyph_row, window_box_edges):
2112 (glyph_to_pixel_coords, set_cursor_from_row):
2113 (get_next_display_element, set_iterator_to_next):
2114 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2115 (show_mouse_face): Remove decls
2116 * frame.h (message_buf_print): Likewise.
2117 * lisp.h (pop_message, set_message, check_point_in_composition):
2118 Likewise.
2119 * xterm.h (set_vertical_scroll_bar): Likewise.
2120 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2121 (message_buf_print, scratch_glyph_row, displayed_buffer):
2122 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2123 (get_next_display_element, show_mouse_face, window_box_edges):
2124 (frame_to_window_pixel_xy, check_point_in_composition):
2125 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2126 (glyph_to_pixel_coords): Remove; unused.
2127
16390cd2
PE
2128 * dired.c (file_name_completion): Now static.
2129
2130 * dbusbind.c (xd_in_read_queued_messages): Now static.
2131
a25f4dfa
PE
2132 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2133 * data.c (circular_list_error): Remove.
2134
14a9c8df
PE
2135 * commands.h (last_point_position, last_point_position_buffer):
2136 (last_point_position_window): Remove decls.
2137 * keyboard.c: Make these variables static.
2138
04f2d78b
CB
2139 * coding.h (coding, code_convert_region, encode_coding_gap):
2140 Remove decls.
74ab6df5
PE
2141 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2142 (iso_code_class, detect_coding, code_convert_region): Now static.
2143 (encode_coding_gap): Remove; unused.
2144
38dfbee1
PE
2145 * chartab.c (chartab_chars, chartab_bits): Now static.
2146
a2cb4e63
PE
2147 * charset.h (charset_iso_8859_1): Remove decl.
2148 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2149 Now static.
2150
127198fd
PE
2151 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2152 * ccl.c (Vccl_program_table): Now static.
2153 (check_ccl_update): Remove; unused.
2154
d85b608f
PE
2155 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2156 * category.h: ... from here.
2157 * category.c (check_category_table, set_category_set): Now static.
2158
31cd66f3
PE
2159 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2160 * lisp.h: Remove these decls.
2161
c358e587
PE
2162 * buffer.c (buffer_count): Remove unused var.
2163
e78aecca
PE
2164 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2165 so that it's not optimized away.
2166 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2167 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2168 exported only to the debugger.
2169
e192d7d3 2170 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2171 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2172
92470028
PE
2173 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2174 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2175 was inaccessible from Lisp.
2176 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2177 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2178
244ed907
PE
2179 alloc.c: Import and export fewer symbols, and remove unused items.
2180 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2181 is defined.
2182 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2183 it's not optimized away by whole-program optimization.
2184 (message_enable_multibyte, free_misc): Remove.
2185 (catchlist, handlerlist, mark_backtrace):
2186 Declare only if BYTE_MARK_STACK.
2187 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2188 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2189 (message_enable_multibyte): Remove decl.
2190 (free_misc, interval_free_list, float_block, float_block_index):
2191 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2192 (cons_free_list, last_marked_index):
2193 Now static.
2194 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2195 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2196 (mark_backtrace): Define only if BYTE_MARK_STACK.
2197 * xdisp.c (message_enable_multibyte): Now static.
2198
61c2b50e 2199 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2200 This makes it easier for human readers (and static analyzers)
2201 to see whether these variables are used from other modules.
2202 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2203 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2204 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2205 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2206 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2207 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2208 * xmenu.c, xselect.c:
2209 Declare Q* vars static if they are not used in other modules.
2210 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2211 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2212 Remove decls of unexported vars.
2213 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2214
95c82688
PE
2215 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2216
16a97296
PE
2217 Make Emacs functions such as Fatom 'static' by default.
2218 This makes it easier for human readers (and static analyzers)
2219 to see whether these functions can be called from other modules.
2220 DEFUN now defines a static function. To make the function external
2221 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2222 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2223 (Finit_image_library):
16a97296
PE
2224 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2225 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2226 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2227 Remove decls, since these functions are now static.
2228 (Funintern, Fget_internal_run_time): New decls, since these functions
2229 were already external.
95c82688 2230
16a97296
PE
2231 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2232 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2233 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2234 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2235 * keyboard.c, keymap.c, lread.c:
2236 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2237 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2238 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2239 Mark functions with DEFUE instead of DEFUN,
2240 if they are used in other modules.
2241 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2242 decls for now-static functions.
2243 * buffer.h (Fdelete_overlay): Remove decl.
2244 * callproc.c (Fgetenv_internal): Mark as internal.
2245 * composite.c (Fremove_list_of_text_properties): Remove decl.
2246 (Fcomposition_get_gstring): New forward static decl.
2247 * composite.h (Fcomposite_get_gstring): Remove decl.
2248 * dired.c (Ffile_attributes): New forward static decl.
2249 * doc.c (Fdocumntation_property): New forward static decl.
2250 * eval.c (Ffetch_bytecode): New forward static decl.
2251 (Funintern): Remove extern decl; now in .h file where it belongs.
2252 * fileio.c (Fmake_symbolic_link): New forward static decl.
2253 * image.c (Finit_image_library): New forward static decl.
2254 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2255 * intervals.h (Fprevious_property_change):
2256 (Fremove_list_of_text_properties): Remove decls.
2257 * keyboard.c (Fthis_command_keys): Remove decl.
2258 (Fcommand_execute): New forward static decl.
2259 * keymap.c (Flookup_key): New forward static decl.
2260 (Fcopy_keymap): Now static.
2261 * keymap.h (Flookup_key): Remove decl.
2262 * process.c (Fget_process): New forward static decl.
2263 (Fprocess_datagram_address): Mark as internal.
2264 * syntax.c (Fsyntax_table_p): New forward static decl.
2265 (skip_chars): Remove duplicate decl.
2266 * textprop.c (Fprevious_property_change): New forward static decl.
2267 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2268 Now internal.
2269 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2270 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2271
785bbd42
PE
2272 * editfns.c (Fformat): Remove unreachable code.
2273
8b913b57
AS
22742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2275
2276 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2277 change. (Bug#8496)
2278
a6744a35
EZ
22792011-04-13 Eli Zaretskii <eliz@gnu.org>
2280
2281 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2282 when at ZV. (Bug#8487)
2283
e7974947
AS
22842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2285
baad03f0
AS
2286 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2287 (Bug#8437)
2288 * keyboard.c (parse_tool_bar_item): Likewise.
2289 * sound.c (sound_cleanup, alsa_close): Likewise.
2290 * termcap.c (tgetent): Likewise.
2291 * xfns.c (x_default_font_parameter): Likewise.
2292 * xsettings.c (read_and_apply_settings): Likewise.
2293
e7974947
AS
2294 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2295 (overrun_check_free): Protoize.
2296
28272684
PE
22972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2300 since callers should never pass a negative size.
2301 Change the signature to match that of plain 'read' and 'write'; see
2302 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2303 * lisp.h: Update prototypes of emacs_write and emacs_read.
2304
11997c76
EZ
23052011-04-11 Eli Zaretskii <eliz@gnu.org>
2306
2307 * xdisp.c (redisplay_window): Don't try to determine the character
2308 position of the scroll margin if the window start point w->startp
e896f03c 2309 is outside the buffer's accessible region. (Bug#8468)
11997c76 2310
8a2cbd72
EZ
23112011-04-10 Eli Zaretskii <eliz@gnu.org>
2312
2313 Fix write-region and its subroutines for buffers > 2GB.
2314 * fileio.c (a_write, e_write): Modify declaration of arguments and
2315 local variables to support buffers larger than 2GB.
2316 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2317
2318 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2319 argument, local variables, and return value.
2320
2321 * lisp.h: Update prototypes of emacs_write and emacs_read.
2322
2323 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2324
4073e537 23252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2326
1ebfdcb6
PE
2327 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2328
b2ded58d
PE
2329 Fix more problems found by GCC 4.6.0's static checks.
2330
7d66342c
PE
2331 * xdisp.c (vmessage): Use a better test for character truncation.
2332
bbf47d44
PE
2333 * charset.c (load_charset_map): <, not <=, for optimization,
2334 and to avoid potential problems with integer overflow.
9248994d 2335 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2336 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2337 * editfns.c (Fformat): Likewise.
1e69125e 2338 * syntax.c (skip_chars): Likewise.
3befa583 2339
e3019616
PE
2340 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2341 This also lets GCC 4.6.0 generate slightly better loop code.
2342
becfa255
PE
2343 * callint.c (Fcall_interactively): <, not <=, for optimization.
2344 (Fcall_interactively): Count the number of arguments produced,
2345 not the number of arguments given. This is simpler and lets GCC
2346 4.6.0 generate slightly better code.
2347
dae0cd48
PE
2348 * ftfont.c: Distingish more carefully between FcChar8 and char.
2349 The previous code passed unsigned char * to a functions like
2350 strlen and xstrcasecmp that expect char *, which does not
2351 conform to the C standard.
2352 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2353 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2354 char * when the C standard requires it.
2355
76032d70
PE
2356 * keyboard.c (read_char): Remove unused var.
2357
eb3f1cc8
PE
2358 * eval.c: Port to Windows vsnprintf (Bug#8435).
2359 Include <limits.h>.
2360 (SIZE_MAX): Define if the headers do not.
2361 (verror): Do not give up if vsnprintf returns a negative count.
2362 Instead, grow the buffer. This ports to Windows vsnprintf, which
2363 does not conform to C99. Problem reported by Eli Zaretskii.
2364 Also, simplify the allocation scheme, by avoiding the need for
2365 calling realloc, and removing the ALLOCATED variable.
2366
70476b54
PE
2367 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2368
12020a9e
PE
2369 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2370 But keep the doprint source code for now, as we might revamp it
2371 and use it again (Bug#8435).
ea6c7ae6
PE
2372 * lisp.h (doprnt): Remove.
2373 * Makefile.in (base_obj): Remove doprnt.o.
2374 * deps.mk (doprnt.o): Remove.
2375
5fdb398c
PE
2376 error: Print 32- and 64-bit integers portably (Bug#8435).
2377 Without this change, on typical 64-bit hosts error ("...%d...", N)
2378 was used to print both 32- and 64-bit integers N, which relied on
2379 undefined behavior.
2380 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2381 New macro.
2382 * lisp.h (error, verror): Mark as printf-like functions.
2383 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2384 Report overflow in size calculations when allocating printf buffer.
2385 Do not truncate output string at its first null byte.
2386 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2387 Truncate the output at a character boundary, since vsnprintf does not
2388 do that.
2389 * charset.c (check_iso_charset_parameter): Convert internal
2390 character to string before calling 'error', since %c now has the
2391 printf meaning.
2392 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2393 overflow when computing char to be passed to 'error'. Do not
2394 pass Lisp_Object to 'error'; pass the integer instead.
2395 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2396 formatted with plain %d.
2397
b189fa66
PE
2398 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2399
bff87ef0
PE
2400 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2401
7e2cac20
PE
2402 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2403
ce4d90b5
PE
2404 * xterm.c (x_catch_errors): Remove duplicate declaration.
2405
266c9547
PE
2406 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2407
79c49ad2
PE
2408 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2409
368f4090
JM
24102011-04-10 Jim Meyering <meyering@redhat.com>
2411
2412 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2413 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2414 return ssize_t not "int", and use size_t as the buffer length.
2415 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2416 * gnutls.h: Update declarations.
2417 * process.c (read_process_output): Use ssize_t, to match.
2418 (send_process): Likewise.
2419
a32d4040
CY
24202011-04-09 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2423
8546720e 24242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2425
04f2d78b
CB
2426 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2427 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2428
8546720e
GM
2429 * xterm.c (handle_one_xevent):
2430 * xmenu.c (create_and_show_popup_menu):
2431 * xselect.c (x_decline_selection_request)
2432 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2433
0a2f5c1a 24342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2435
2436 Fix some uses of `int' instead of EMACS_INT.
2437 * search.c (string_match_1, fast_string_match)
2438 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2439 (scan_buffer, find_next_newline_no_quit)
2440 (find_before_next_newline, search_command, Freplace_match)
2441 (Fmatch_data): Make some `int' variables be EMACS_INT.
2442
2443 * xdisp.c (display_count_lines): 3rd argument and return value now
2444 EMACS_INT. All callers changed.
2445 (pint2hrstr): Last argument is now EMACS_INT.
2446
2447 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2448 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2449 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2450 (decode_coding_utf_16, decode_coding_emacs_mule)
2451 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2452 (decode_coding_ccl, decode_coding_charset)
2453 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2454 (decode_coding_iso_2022, decode_coding_emacs_mule)
2455 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2456 <char_offset, last_offset>: Declare EMACS_INT.
2457 (encode_coding_utf_8, encode_coding_utf_16)
2458 (encode_coding_emacs_mule, encode_invocation_designation)
2459 (encode_designation_at_bol, encode_coding_iso_2022)
2460 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2461 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2462 Declare EMACS_INT.
2463 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2464 (encode_invocation_designation): Last argument P_NCHARS is now
2465 EMACS_INT.
2466 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2467 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2468
2469 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2470 All users changed.
2471
2472 * ccl.c (Fccl_execute_on_string): Declare some variables
2473 EMACS_INT.
2474
8546720e 24752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2476
2477 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2478
4e19a977
CS
24792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2480
2481 * process.c (Fformat_network_address): Doc fix.
2482
87302331
R
24832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2484
2485 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2486
cbb59342
CY
24872011-04-08 Chong Yidong <cyd@stupidchicken.com>
2488
2489 * keyboard.c (read_char): Call Lisp function help-form-show,
2490 instead of using internal_with_output_to_temp_buffer.
2491 (Qhelp_form_show): New var.
e0d38eeb 2492 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2493
2494 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2495
2496 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2497
e67a13ab
CY
24982011-04-06 Chong Yidong <cyd@stupidchicken.com>
2499
04f2d78b
CB
2500 * process.c (Flist_processes): Remove to Lisp.
2501 (list_processes_1): Delete.
e67a13ab 2502
973f782d
EZ
25032011-04-06 Eli Zaretskii <eliz@gnu.org>
2504
7c106b1e
EZ
2505 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2506
973f782d
EZ
2507 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2508
41cf7d1a 25092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2510
ca23cc88
PE
2511 Fix more problems found by GCC 4.6.0's static checks.
2512
f390e2d5
PE
2513 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2514
42eea0d0
PE
2515 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2516
b69769da 2517 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2518
f9541e84
PE
2519 * xdisp.c (vmessage): Mark as a printf-like function.
2520
13841b55
PE
2521 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2522
c136c10f
PE
2523 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2524
5e2d4a30
PE
2525 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2526 printf-like functions.
2527 (tiff_load): Add casts to remove these marks before passing them
2528 to system-supplied API.
2529
583f48b9
PE
2530 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2531
b25d760e
PE
2532 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2533 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2534 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2535 directly, rather than having caller test rule sign. This avoids
2536 some unnecessary tests.
2537 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2538 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2539 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2540
bc7b6697 2541 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2542 (xfont_open): Avoid unnecessary tests.
bc7b6697 2543
27ccc379
PE
2544 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2545
dcd5c89a
PE
2546 * composite.h, composite.c (composition_gstring_put_cache):
2547 Use EMACS_INT, not int, for length.
2548
b13a45c6
PE
2549 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2550 breaking out part of COMPOSITION_DECODE_RULE.
2551 (COMPOSITION_DECODE_RULE): Use it.
2552 * composite.c (get_composition_id): Remove unused local vars,
2553 by using the new macro.
2554
1e792e4d
PE
2555 * textprop.c (set_text_properties_1): Change while to do-while,
2556 since the condition is always true at first.
2557
dc6c6455 2558 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2559 (interval_deletion_adjustment): Return unsigned value.
2560 All uses changed.
dc6c6455 2561
aba7731a
PE
2562 * process.c (list_processes_1, create_pty, read_process_output):
2563 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2564 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2565 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2566 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2567 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2568
fdfc4bf3
PE
2569 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2570
fca8fe46 2571 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2572 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2573
06a0259a 2574 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2575 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2576 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2577
e7b9e80f
PE
2578 * print.c (print_error_message): Avoid int overflow.
2579
56201685
PE
2580 * font.c (font_list_entities): Redo for clarity,
2581 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2582
78834453 2583 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2584 (font_score): Avoid potential overflow in diff calculation.
78834453 2585
0bc0b309 2586 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2587 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2588
e610eaca
PE
2589 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2590
b895abce
PE
2591 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2592 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2593 can always succeed if overflow has undefined behavior.
2594
1f1d9321 2595 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2596 (wordify): Omit three unnecessary tests.
1f1d9321 2597
c59478bc
PE
2598 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2599 All callers changed. This avoids the need for an unused var.
2600
79b73827
PE
2601 * casefiddle.c (casify_region): Remove var that is set but not used.
2602
a4db5dfe
PE
2603 * dired.c (file_name_completion): Remove var that is set but not used.
2604
43aae36e
PE
2605 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2606
2a47c44d 2607 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2608 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2609
a37c69bf
PE
2610 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2611 Check for integer overflow on size calculations.
2612
328ab8e7
PE
2613 * buffer.c (Fprevious_overlay_change): Remove var that is set
2614 but not used.
2615
e5a2a5cb
PE
2616 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2617 Remove vars that are set but not used.
8d84a6eb 2618 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2619 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2620
a60e5f68
PE
2621 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2622
f661cb61 2623 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2624 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2625
f0397f5a
PE
2626 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2627 that are set but not used.
2628
8664db06 2629 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2630 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2631
6abdaa4a
PE
2632 * xselect.c (x_get_local_selection, x_handle_property_notify):
2633 Remove vars that are set but not used.
2634
0ce7538d 2635 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2636 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2637
9ae848fc
PE
2638 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2639 Remove var that is set but not used.
0b918413
PE
2640 (scroll_bar_windows_size): Now size_t, not int.
2641 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2642 Check for overflow.
9ae848fc 2643
a5a62657
PE
2644 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2645 (map_tty_color) [!defined MSDOS]: Likewise.
2646
5c5cdd39
PE
2647 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2648
66ebf983
PE
2649 * coding.c: Remove vars that are set but not used.
2650 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2651 All callers changed.
2652 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2653 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2654 (decode_coding_charset): Remove vars that are set but not used.
2655
1be4d761
PE
2656 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2657 that is set but not used.
2658
47553fa8
PE
2659 * print.c (print_object): Remove var that is set but not used.
2660
1f7196bf 2661 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2662 The gnulib version avoids calling malloc in the usual case,
2663 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2664 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2665 * filelock.c (current_lock_owner): Likewise.
2666 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2667 * sysdep.c: Include allocator.h, careadlinkat.h.
2668 (emacs_no_realloc_allocator): New static constant.
2669 (emacs_readlink): New function.
fdb61804
PE
2670 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2671 ../lib/careadlinkat.h.
d1fdcab7 2672
f84c17c7
SM
26732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2674
2675 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2676 first non-nil return value).
2677
ef3862ad
JD
26782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2679
2680 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2681 if not defined (Bug#8403).
2682
376a7006
JB
26832011-04-02 Juanma Barranquero <lekktu@gmail.com>
2684
2685 * xdisp.c (display_count_lines): Remove parameter `start',
2686 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2687 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2688 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2689 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2690 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2691 and thereabouts. All callers changed.
2692 (get_per_char_metric): Remove parameter `f', unused since
2693 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2694
6ca3801d
JM
26952011-04-02 Jim Meyering <meyering@redhat.com>
2696
2697 do not dereference NULL upon failed strdup
2698 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2699 (ns_get_family): Likewise.
2700
d8e2b5ba
JB
27012011-04-02 Juanma Barranquero <lekktu@gmail.com>
2702
2703 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2704
8c74fcbd
JD
27052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2706
2707 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2708 later (Bug#8403).
2709
7200d79c
SM
27102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2711
03408648 2712 Add lexical binding.
7200d79c 2713
03408648
SM
2714 * window.c (Ftemp_output_buffer_show): New fun.
2715 (Fsave_window_excursion):
2716 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2717
2718 * lread.c (lisp_file_lexically_bound_p): New function.
2719 (Fload): Bind Qlexical_binding.
2720 (readevalloop): Remove `evalfun' arg.
2721 Bind Qinternal_interpreter_environment.
2722 (Feval_buffer): Bind Qlexical_binding.
2723 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2724 Mark as dynamic.
2725 (syms_of_lread): Declare `lexical-binding'.
2726
2727 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2728
2729 * keyboard.c (eval_dyn): New fun.
2730 (menu_item_eval_property): Use it.
ca105506
SM
2731
2732 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2733
03408648
SM
2734 * fns.c (concat, mapcar1): Accept byte-code-functions.
2735
2736 * eval.c (Fsetq): Handle lexical vars.
2737 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2738 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2739 (FletX, Flet): Obey lexical binding.
2740 (Fcommandp): Handle closures.
2741 (Feval): New `lexical' arg.
2742 (eval_sub): New function extracted from Feval. Use it almost
2743 everywhere where Feval was used. Look up vars in lexical env.
2744 Handle closures.
2745 (Ffunctionp): Move from subr.el.
2746 (Ffuncall): Handle closures.
2747 (apply_lambda): Remove `eval_flags'.
2748 (funcall_lambda): Handle closures and new byte-code-functions.
2749 (Fspecial_variable_p): New function.
2750 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2751 but without exporting it to Lisp.
23aba0ea 2752
23aba0ea 2753 * doc.c (Fdocumentation, store_function_docstring):
03408648 2754 * data.c (Finteractive_form): Handle closures.
23aba0ea 2755
03408648
SM
2756 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2757 interactive spec.
ba83908c 2758
04f2d78b
CB
2759 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2760 New byte-codes.
03408648
SM
2761 (exec_byte_code): New function extracted from Fbyte_code to handle new
2762 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2763
03408648 2764 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2765
03408648 2766 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2767
e2abce01
JB
27682011-03-31 Juanma Barranquero <lekktu@gmail.com>
2769
2770 * xdisp.c (redisplay_internal): Fix prototype.
2771
63696a73 27722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2773
63696a73 2774 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2775 (try_scrolling): Use it when setting scroll_limit.
2776 Limit scrolling to 100 screen lines.
63696a73
EZ
2777 (redisplay_window): Even when falling back on "recentering",
2778 position point in the window according to scroll-conservatively,
2779 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2780
2781 (try_scrolling): When point is above the window, allow searching
2782 as far as scroll_max, or one screenful, to compute vertical
2783 distance from PT to the scroll margin position. This prevents
2784 try_scrolling from unnecessarily failing when
2785 scroll-conservatively is set to a value slightly larger than the
2786 window height. Clean up the case of PT below the margin at bottom
2787 of window: scroll_max can no longer be INT_MAX. When aggressive
2788 scrolling is in use, don't let point enter the opposite scroll
2789 margin as result of the scroll.
2790 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2791 threshold of 100 lines for never-recentering scrolling.
2792
e4cc2dfc
JB
27932011-03-31 Juanma Barranquero <lekktu@gmail.com>
2794
2795 * dispextern.h (move_it_by_lines):
2796 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2797 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2798 (message_log_check_duplicate): Remove parameters `prev_bol' and
2799 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2800 (redisplay_internal): Remove parameter `preserve_echo_area',
2801 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2802
2803 * indent.c (Fvertical_motion):
2804 * window.c (window_scroll_pixel_based, Frecenter):
2805 Don't pass `need_y_p' to `move_it_by_lines'.
2806
1c470562
SM
28072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2808
44f230aa
SM
2809 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2810 steal a few bits to be more compact.
2811 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2812 Remove unneeded casts.
2813
1c470562
SM
2814 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2815
888adce9
ZK
28162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2817
2818 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2819 binding" message (bug#7967).
2820
f838ed7b
PE
28212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2822
77861b95
PE
2823 Fix more problems found by GCC 4.6.0's static checks.
2824
de6dbc14
PE
2825 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2826 Remove unused local var.
2827
f838ed7b
PE
2828 * editfns.c (Fmessage_box): Remove unused local var.
2829
792c7b2b
PE
2830 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2831 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2832 Omit unused local vars.
c499e557 2833 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2834 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2835 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2836 Omit unused local var.
2837
ba0165e1
PE
2838 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2839 Don't assume string length fits in int.
32ad8845 2840 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2841 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2842
3c59b4c9
PE
2843 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2844 instead of alloca (Bug#8344).
2845
a3eed478 2846 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2847 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2848
eb4d412d
PE
2849 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2850
1658b401
PE
2851 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2852 concerns.
2853
2854 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2855
2856 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2857
9a2c6e05
PE
2858 * keyboard.c (syms_of_keyboard): Use the same style as later
2859 in this function when indexing through an array. This also
2860 works around GCC bug 48267.
2861
03d0a109
PE
2862 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2863
44f730c8
PE
2864 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2865
fe75f926
PE
2866 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2867 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2868
ffa8c828
PE
2869 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2870 This avoids undefined behavior on integer overflow, and is a bit
2871 more convenient anyway since it is compared to a size_t variable.
2872
c5101a77
PE
2873 Variadic C functions now count arguments with size_t, not int.
2874 This avoids an unnecessary limitation on 64-bit machines, which
2875 caused (substring ...) to crash on large vectors (Bug#8344).
2876 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2877 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2878 All variadic functions and their callers changed accordingly.
c5101a77
PE
2879 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2880 * data.c (arith_driver, float_arith_driver): Likewise.
2881 * editfns.c (general_insert_function): Likewise.
2882 * eval.c (struct backtrace.nargs, interactive_p)
2883 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2884 (funcall_lambda, mark_backtrace): Likewise.
2885 * fns.c (concat): Likewise.
2886 * frame.c (x_set_frame_parameters): Likewise.
2887 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2888 0 if not found, not -1. All callers changed.
2889
dd3f25f7
PE
2890 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2891 (stack_copy_size): Now size_t, not int.
2892 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2893
461c2ab9
JB
28942011-03-28 Juanma Barranquero <lekktu@gmail.com>
2895
2896 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2897 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2898 All callers changed.
2899
2900 * lisp.h (multibyte_char_to_unibyte):
2901 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2902 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2903 * character.h (CHAR_TO_BYTE8):
2904 * cmds.c (internal_self_insert):
2905 * editfns.c (general_insert_function):
2906 * keymap.c (push_key_description):
2907 * search.c (Freplace_match):
2908 * xdisp.c (message_dolog, set_message_1): All callers changed.
2909
f6d62986
SM
29102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2911
2912 * keyboard.c (safe_run_hook_funcall): New function.
2913 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2914 don't set the hook to nil, but remove the offending function instead.
2915 (Qcommand_hook_internal): Remove, unused.
2916 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2917 Vcommand_hook_internal.
2918
2919 * eval.c (enum run_hooks_condition): Remove.
2920 (funcall_nil, funcall_not): New functions.
2921 (run_hook_with_args): Call each function through a `funcall' argument.
2922 Remove `cond' argument, now redundant.
2923 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2924 (Frun_hook_with_args_until_failure): Adjust accordingly.
2925 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2926
1db5b1ad
JB
29272011-03-28 Juanma Barranquero <lekktu@gmail.com>
2928
2929 * dispextern.h (string_buffer_position): Remove declaration.
2930
2931 * print.c (strout): Remove parameter `multibyte', unused since
2932 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2933
2934 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2935 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2936 All callers changed.
2937
2938 * w32.c (_wsa_errlist): Use braces for struct initializers.
2939
2940 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2941 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2942 All callers changed.
2943 (string_buffer_position): Likewise. Also, make static (it's never
2944 used outside xdisp.c).
2945 (cursor_row_p): Remove parameter `w', unused since
2946 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2947 (decode_mode_spec): Remove parameter `precision', introduced during
2948 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2949 All callers changed.
2950
5ffb62aa
JD
29512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2952
2953 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2954
461c2ab9 29552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2956
2957 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2958 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2959 (ns_update_auto_hide_menu_bar): New functions.
2960 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2961 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2962 ns_constrain_all_frames.
2963 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2964 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2965
5c380ffb
JD
29662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2967
2968 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2969
9af30bdf
GM
29702011-03-27 Glenn Morris <rgm@gnu.org>
2971
2972 * syssignal.h: Replace RETSIGTYPE with void.
2973 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2974 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2975 Replace SIGTYPE with void everywhere.
2976 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2977 * s/template.h (SIGTYPE): Remove commented out definition.
2978
e2abce01
JB
29792011-03-26 Eli Zaretskii <eliz@gnu.org>
2980
2981 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2982 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2983
f868cd8a
JB
29842011-03-26 Juanma Barranquero <lekktu@gmail.com>
2985
59eb0929
JB
2986 * w32.c (read_unc_volume): Use parameter `henum', instead of
2987 global variable `wget_enum_handle'.
2988
2989 * keymap.c (describe_vector): Remove parameters `indices' and
2990 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2991 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2992
f868cd8a
JB
2993 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2994
2995 * keyboard.c (timer_check): Remove parameter `do_it_now',
2996 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2997 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2998 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2999
3000 * keyboard.c (read_char):
3001 * w32menu.c (w32_menu_display_help):
3002 * xmenu.c (show_help_event, menu_help_callback):
3003 Adjust calls to `show_help_echo'.
3004
3005 * gtkutil.c (xg_maybe_add_timer):
3006 * keyboard.c (readable_events):
3007 * process.c (wait_reading_process_output):
3008 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3009
3010 * insdel.c (adjust_markers_gap_motion):
3011 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3012 (gap_left, gap_right): Don't call it.
3013
2ecf6fdb
CY
30142011-03-25 Chong Yidong <cyd@stupidchicken.com>
3015
3016 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3017 incurred during fontification.
3018
6b1f9ba4
JB
30192011-03-25 Juanma Barranquero <lekktu@gmail.com>
3020
3021 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3022 (DEFVAR_PER_BUFFER): Don't pass it.
3023
3024 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3025 (scrolling_window): Don't pass it.
3026
0f4a96b5
JB
30272011-03-25 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3030
3031 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3032 and `suffix'.
3033 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3034 of variables specific to SELinux and computation of `encoded_absname'.
3035
3036 * image.c (XPutPixel): Remove unused variable `height'.
3037
3038 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3039
3040 * unexw32.c (get_section_info): Remove unused variable `section'.
3041
3042 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3043 (system_process_attributes): Remove unused variable `sess'.
3044 (sys_read): Remove unused variable `err'.
3045
3046 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3047 (w32_wnd_proc): Remove unused variable `isdead'.
3048 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3049 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3050 (x_create_tip_frame): Remove unused variable `tem'.
3051
3052 * w32inevt.c (w32_console_read_socket):
3053 Remove unused variable `no_events'.
3054
3055 * w32term.c (x_draw_composite_glyph_string_foreground):
3056 Remove unused variable `width'.
3057
1149507c
JB
30582011-03-24 Juanma Barranquero <lekktu@gmail.com>
3059
3060 * w32term.c (x_set_glyph_string_clipping):
3061 Don't pass uninitialized region to CombineRgn.
3062
9c88f339
JB
30632011-03-23 Juanma Barranquero <lekktu@gmail.com>
3064
3065 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3066 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3067 (Fx_close_connection): Remove unused variable `i'.
3068
3069 * w32font.c (w32font_draw): Return number of glyphs.
3070 (w32font_open_internal): Remove unused variable `i'.
3071 (w32font_driver): Add missing initializer.
3072
3073 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3074 (fill_in_menu): Remove unused variable `items_added'.
3075
3076 * w32term.c (last_mouse_press_frame): Remove static global variable.
3077 (w32_clip_to_row): Remove unused variable `f'.
3078 (x_delete_terminal): Remove unused variable `i'.
3079
3080 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3081 (NOTHING): Remove unused static global variable.
3082 (uniscribe_check_otf): Remove unused variable `table'.
3083 (uniscribe_font_driver): Add missing initializers.
3084
dee091a3
JD
30852011-03-23 Julien Danjou <julien@danjou.info>
3086
3087 * term.c (Fsuspend_tty, Fresume_tty):
3088 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3089 * window.c (temp_output_buffer_show):
3090 * insdel.c (signal_before_change):
3091 * frame.c (Fhandle_switch_frame):
3092 * fileio.c (Fdo_auto_save):
3093 * emacs.c (Fkill_emacs):
3094 * editfns.c (save_excursion_restore):
3095 * cmds.c (internal_self_insert):
3096 * callint.c (Fcall_interactively):
3097 * buffer.c (Fkill_all_local_variables):
3098 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3099 Use Frun_hooks.
0f4a96b5 3100 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3101 unconditionnaly since it does the check itself.
3102
2c520ab5 31032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3104
c9c49752
PE
3105 Fix more problems found by GCC 4.5.2's static checks.
3106
8abc3f12
PE
3107 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3108 the first time through the loop, since we know p0 < p1 then.
3109 This also avoids a gcc -Wstrict-overflow warning.
3110
a2d26660
PE
3111 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3112 leading to a memory leak, possible in functions like
3113 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3114 of objects (Bug#8318).
a2d26660 3115
916c72e9
PE
3116 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3117 that could (at least in theory) be that large.
3118
19ab8a18
PE
3119 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3120 This is less likely to overflow, and avoids undefined behavior if
3121 overflow does occur. All callers changed. Use strtoul to scan
3122 for the unsigned long integer.
b7cbbd6f
PE
3123 (pint2hrstr): Simplify and tune code slightly.
3124 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3125
f0641eff
PE
3126 * scroll.c (do_scrolling): Work around GCC bug 48228.
3127 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3128
7f650bb9
PE
3129 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3130 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3131 (validate_x_resource_name): Simplify count usage.
3132 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3133
37dd57d1
PE
3134 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3135 fail (Bug#8306).
81e56e61 3136
699979fc 3137 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3138
401bf9b4
PE
3139 * process.c (Fmake_network_process): Use socklen_t, not int,
3140 where POSIX says socklen_t is required in portable programs.
3141 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3142 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3143 (Fmake_network_process, server_accept_connection):
3144 (wait_reading_process_output, read_process_output):
3145 Likewise.
3146
b93aacde
PE
3147 * process.c: Rename or move locals to avoid shadowing.
3148 (list_processes_1, Fmake_network_process):
3149 (read_process_output_error_handler, exec_sentinel_error_handler):
3150 Rename or move locals.
4dc343ee 3151 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3152 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3153 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3154 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3155 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3156
af8a867c 3157 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3158 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3159 Include tparam.h instead, since it declares them.
af8a867c
PE
3160 * cm.h (PC): Remove extern decl; tparam.h now does this.
3161 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3162 * terminfo.c: Include tparam.h, to check interfaces.
3163 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3164 (tparam): Adjust signature to match interface in tparam.h;
3165 this removes some undefined behavior. Check that outstring and len
3166 are zero, which they always are with Emacs.
3167 * tparam.h (PC, BC, UP): New extern decls.
3168
0248044d 3169 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3170 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3171
8ff096c1 3172 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3173 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3174 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3175 (ftfont_list): Remove unused local.
49eaafba
PE
3176 (get_adstyle_property, ftfont_pattern_entity):
3177 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3178 Rename locals to avoid shadowing.
8ff096c1 3179
e2be39f6
PE
3180 * xfont.c (xfont_list_family): Mark var as initialized.
3181
c9735e30
PE
3182 * xml.c (make_dom): Now static.
3183
8f5201ae
PE
3184 * composite.c (composition_compute_stop_pos): Rename local to
3185 avoid shadowing.
b246f932
PE
3186 (composition_reseat_it): Remove unused locals.
3187 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3188 (composition_update_it): Mark var as initialized.
11b61122
PE
3189 (find_automatic_composition): Mark vars as initialized,
3190 with a FIXME (Bug#8290).
8f5201ae 3191
760fbc2c
PE
3192 character.h: Rename locals to avoid shadowing.
3193 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3194 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3195 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3196 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3197 to avoid shadowing.
3198
ff08eb85
PE
3199 * textprop.c (property_change_between_p): Remove; unused.
3200
fc7bf025
PE
3201 * intervals.c (interval_start_pos): Now static.
3202
235d7abc
PE
3203 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3204
44f230aa
SM
3205 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3206 Rename locals to avoid shadowing.
3e7d6594 3207
50060332
PE
3208 * sound.c (wav_play, au_play, Fplay_sound_internal):
3209 Fix pointer signedness.
d01f234b 3210 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3211 (wav_play): Initialize a variable to 0, to prevent undefined
3212 behavior (Bug#8278).
50060332 3213
c4fc4e30
PE
3214 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3215
918436ed
PE
3216 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3217
c939f91b
PE
3218 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3219 clobbering (Bug#8298).
b9c7f648
PE
3220 * sysdep.c (sys_subshell): Likewise.
3221 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3222
6bd8c144
PE
3223 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3224 This should get cleaned up, so that child_setup has the
3225 same signature on all platforms.
3226
7710357c 3227 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3228 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3229
c59da222
CY
32302011-03-22 Chong Yidong <cyd@stupidchicken.com>
3231
3232 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3233 not to be necessary, and produces flickering.
3234
66b87493
GM
32352011-03-20 Glenn Morris <rgm@gnu.org>
3236
3237 * config.in: Remove file.
3238
45b6f6d5
JB
32392011-03-20 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3242 are now in src/globals.h.
3243 (syms_of_minibuf): Remove spurious & from previous change.
3244
3ec03f7e
LL
32452011-03-20 Leo <sdl.web@gmail.com>
3246
3247 * minibuf.c (completing-read-function): New variable.
3248 (completing-read-default): Rename from completing-read.
3249 (completing-read): Call completing-read-function.
3250
b14e3e21
CY
32512011-03-19 Juanma Barranquero <lekktu@gmail.com>
3252
3253 * xfaces.c (Fx_load_color_file):
3254 Read color file from absolute filename (bug#8250).
3255
f2b726e6
JB
32562011-03-19 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * makefile.w32-in: Update dependencies.
3259
09f6ff02
EZ
32602011-03-17 Eli Zaretskii <eliz@gnu.org>
3261
3262 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3263
29a6015a
PE
32642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3265
a3a6c54e
PE
3266 Fix more problems found by GCC 4.5.2's static checks.
3267
b766f867
PE
3268 * process.c (make_serial_process_unwind, send_process_trap):
3269 (sigchld_handler): Now static.
3270
be02381c
PE
3271 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3272 That way, the code declares only the vars that it needs.
3273 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3274 * s/cygwin.h (PTY_ITERATION): Likewise.
3275 * s/darwin.h (PTY_ITERATION): Likewise.
3276 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3277
57048744
PE
3278 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3279 * process.c (allocate_pty): Don't declare stb unless it's needed.
3280
7914961c 3281 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3282 (CONSTANTLIM): Remove; unused.
3283 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3284 Define only if needed.
7914961c 3285
b3967b18
PE
3286 * unexelf.c (unexec): Name an expression,
3287 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3288 Use a different way to cause a compilation error if anyone uses
3289 n rather than nn, a way that does not involve shadowing.
73366a00 3290 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3291
29a6015a
PE
3292 * deps.mk (unexalpha.o): Remove; unused.
3293
43cfc33e 3294 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3295 * unexec.h: New file.
ce701a33
PE
3296 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3297 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3298 Depend on unexec.h.
3299 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3300 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3301 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3302 Change as necessary to match prototype in unexec.h.
ce701a33 3303
01f44d5a
PE
3304 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3305 shadowing.
4f63c6bb 3306 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3307
a6670b0b
PE
3308 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3309 Rename locals to avoid shadowing.
3310
cef2010d 3311 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3312 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3313
d4d7173a
PE
3314 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3315
f08b802a
PE
3316 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3317 warning when compiling print.c.
3318
3ddb0639
PE
3319 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3320 instead of using an uninitialized var.
5ad03b97 3321 (font_sort_entities): Mark var as initialized.
3ddb0639 3322
170a2692
PE
3323 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3324
e663c700
PE
3325 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3326 pointers to constants.
89bc529a 3327 (font_parse_fcname): Remove unused vars.
7b81e2d0 3328 (font_delete_unmatched): Now static.
ea838e10 3329 (font_get_spec): Remove; unused.
13a547c6
PE
3330 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3331 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3332 Rename or move locals to avoid shadowing.
e663c700 3333
2a80c887 3334 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3335 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3336
1384fa33 3337 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3338 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3339
8b2c52e9
PE
3340 * alloc.c (mark_backtrace): Move decl from here ...
3341 * lisp.h: ... to here, so that it can be checked.
3342
475545b5 3343 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3344 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3345 (lisp_indirect_variable): Name an expression,
3346 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3347 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3348
b1349114 3349 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3350 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3351 Use const pointer when appropriate.
b1349114 3352
a2928364
PE
3353 * lisp.h (get_system_name, get_operating_system_release):
3354 Move decls here, to check interfaces.
3355 * process.c (get_operating_system_release): Move decl to lisp.h.
3356 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3357 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3358 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3359 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3360 (Fformat_time_string, Fencode_time, Finsert_char):
3361 (Ftranslate_region_internal, Fformat):
3362 Rename or remove local vars to avoid shadowing.
9710023e 3363 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3364
a415e694
PE
3365 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3366 avoid shadowing.
3367
8ef4622d
PE
3368 * lisp.h (eassert): Check that the argument compiles, even if
3369 ENABLE_CHECKING is not defined.
3370
946f9a5b
PE
3371 * data.c (Findirect_variable): Name an expression, to avoid
3372 gcc -Wbad-function-cast warning.
112396d6 3373 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3374 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3375 (Fmake_variable_buffer_local, Fmake_local_variable):
3376 Mark variables as initialized.
52746918 3377 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3378
e5aab7e7 3379 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3380 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3381 Rename locals to avoid shadowing.
dff45157
PE
3382 (mark_stack): Move local variables into the #ifdef region where
3383 they're used.
7bc26fdb
PE
3384 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3385 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3386 needed otherwise.
3387 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3388 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3389 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3390
e5aab7e7
PE
3391 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3392 avoids undefined behavior in theory.
3393
4da60324
PE
3394 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3395
88043301
PE
3396 Use functions, not macros, for up- and down-casing (Bug#8254).
3397 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3398 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3399 to use the following functions instead of these macros.
3400 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3401 EMACS_INT, since callers assume the returned value fits in int.
3402 (upcase1): Likewise, for UPCASE_TABLE.
3403 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3404 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3405 the race-condition problem in the old DOWNCASE.
88043301 3406
19ed5445
PE
3407 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3408 Rename locals to avoid shadowing.
3409 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3410 (regex_compile, re_search_2, re_match_2_internal):
3411 Remove unused local vars.
952db0d7
PE
3412 (FREE_VAR): Rewrite so as not to use empty "else",
3413 which gcc can warn about.
da053e48 3414 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3415 (RETALLOC_IF): Define only if needed.
3416 (WORDCHAR_P): Likewise. This one is never needed, but is used
3417 only in a comment talking about a compiler bug, so put inside
3418 the #if 0 of that comment.
3419 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3420 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3421 Remove; unused.
19ed5445 3422
1f3561e4 3423 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3424 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3425 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3426
ded6f8f7
PE
3427 * search.c (simple_search): Remove unused var.
3428
dbd37a95
PE
3429 * dired.c (compile_pattern): Move decl from here ...
3430 * lisp.h: ... to here, so that it can be checked.
3431 (struct re_registers): New forward decl.
3432
7e47afad
PE
3433 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3434
85f24f61
PE
3435 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3436 All uses changed.
3437 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3438 Rename locals to avoid shadowing.
5671df8f 3439 (Fvertical_motion): Mark locals as initialized.
85f24f61 3440
181aa2be 3441 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3442 (casify_region): Mark local as initialized.
181aa2be 3443
930d429c
PE
3444 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3445
7082eac6
PE
3446 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3447 New macros, so that the caller can use some names other than
3448 gcpro1, gcpro2, etc.
3449 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3450 of the new macros.
3451 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3452 argument, for consistency with GCPRO2_VAR, etc: it is now the
3453 prefix of the variable, not the variable itself. All uses
3454 changed.
38b2c076
PE
3455 * dired.c (directory_files_internal, file_name_completion):
3456 Rename locals to avoid shadowing.
3457
15206ed9
PE
3458 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3459 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3460 dired.c's scmp function, had undefined behavior.
3461 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3462 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3463 * buffer.h: ... to here, because these macros use current_buffer,
3464 and the new implementation with inline functions needs to have
3465 current_buffer in scope now, rather than later when the macros
3466 are used.
3467 (downcase, upcase1): New static inline functions.
3468 (DOWNCASE, UPCASE1): Reimplement using these functions.
3469 This avoids undefined behavior in expressions like
3470 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3471 from race conditions in accessing the global variables
3472 case_temp1 and case_temp2.
3473 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3474 * lisp.h (case_temp1, case_temp2): Remove their decls.
3475 * character.h (ASCII_CHAR_P): Move from here ...
3476 * lisp.h: ... to here, so that the inline functions mentioned
3477 above can use them.
3478
4a6bea26
PE
3479 * dired.c (directory_files_internal_unwind): Now static.
3480
f14b7e14
PE
3481 * fileio.c (file_name_as_directory, directory_file_name):
3482 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3483 Now static.
2893f146
PE
3484 (file_name_as_directory): Use const pointers when appropriate.
3485 (Fexpand_file_name): Likewise. In particular, newdir might
3486 point at constant storage, so make it a const pointer.
fd4ead52 3487 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3488 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3489 signedness issues.
f839df0c
PE
3490 (Fset_file_times, Finsert_file_contents, auto_save_error):
3491 Rename locals to avoid shadowing.
f14b7e14 3492
5716756e 3493 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3494 (Ftry_completion, Fall_completions): Rename or remove locals
3495 to avoid shadowing.
5716756e 3496
b4c3046a
PE
3497 * marker.c (bytepos_to_charpos): Remove; unused.
3498
b45db522
PE
3499 * lisp.h (verify_bytepos, count_markers): New decls,
3500 so that gcc does not warn that these functions aren't declared.
3501
85876d07
PE
3502 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3503 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3504 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3505 (copy_text): Remove unused local var.
85876d07 3506
03d78a21 3507 * filelock.c (within_one_second): Now static.
b3dd38ab 3508 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3509
5df8f01b
PE
3510 * buffer.c (fix_overlays_before): Mark locals as initialized.
3511 (fix_start_end_in_overlays): Likewise. This function should be
3512 simplified by using pointers-to-pointers, but that's a different
3513 matter.
b1d876f1 3514 (switch_to_buffer_1): Now static.
8f54f30a
PE
3515 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3516 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3517
a70072c9 3518 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3519 Fix pointer signedness issue.
edced198
PE
3520 (sys_subshell): Mark local as volatile if checking for lint,
3521 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3522 (MAXPATHLEN): Define only if needed.
a70072c9 3523
a0977c44
PE
3524 * process.c (serial_open, serial_configure): Move decls from here ...
3525 * systty.h: ... to here, so that they can be checked.
3526
a884fdcc
PE
3527 * fns.c (get_random, seed_random): Move extern decls from here ...
3528 * lisp.h: ... to here, so that they can be checked.
3529
604efe86 3530 * sysdep.c (reset_io): Now static.
b8950c94 3531 (wait_for_termination_signal): Remove; unused.
604efe86 3532
38fc62d9
PE
3533 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3534 (copy_keymap_item, append_key, push_text_char_description):
3535 Now static.
1004a21a 3536 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3537 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3538 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3539 (describe_map_tree):
3540 Rename locals to avoid shadowing.
38fc62d9 3541
2f2650da
PE
3542 * keyboard.c: Declare functions static if they are not used elsewhere.
3543 (echo_char, echo_dash, cmd_error, top_level_2):
3544 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3545 (read_char, kbd_buffer_get_event, make_lispy_position):
3546 (make_lispy_event, make_lispy_movement, apply_modifiers):
3547 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3548 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3549 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3550 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3551 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3552
a053e86c 3553 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3554 (mark_kboards): Move decl here ...
3555 * alloc.c (mark_kboards): ... from here.
a053e86c 3556
4752793e
PE
3557 * lisp.h (force_auto_save_soon): New decl.
3558
74f10ca7 3559 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3560 (DEFINE_DUMMY_FUNCTION): New macro.
3561 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3562 Use it.
c03cd23f
PE
3563 (main): Add casts to avoid warnings
3564 if GCC considers string literals to be constants.
74f10ca7 3565
022e70d4
PE
3566 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3567
59d6fe83
PE
3568 * dbusbind.c: Pointer signedness fixes.
3569 (xd_signature, xd_append_arg, xd_initialize):
3570 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3571 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3572 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3573 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3574
78320123
PE
3575 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3576 if GCC considers string literals to be constants.
49cebcca 3577 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3578
35ac2a97
SM
35792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3580
fb103ca9
SM
3581 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3582 (print_preprocess, print_object): New macro to fix last change.
3583
35ac2a97
SM
3584 * print.c (print_preprocess): Don't forget font objects.
3585
62973b41
JB
35862011-03-16 Juanma Barranquero <lekktu@gmail.com>
3587
3588 * emacs.c (USAGE3): Doc fixes.
3589
0e48bb22
AS
35902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3591
3592 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3593 structure.
3594
7684e57b
JB
35952011-03-14 Juanma Barranquero <lekktu@gmail.com>
3596
3597 * lisp.h (VWindow_system, Qfile_name_history):
3598 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3599 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3600 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3601
3602 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3603 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3604
3605 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3606 * w32console.c (detect_input_pending, read_input_pending)
3607 (encode_terminal_code):
3608 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3609 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3610 (w32_system_caret_y, Qfile_name_history):
3611 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3612 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3613 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3614 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3615 * w32proc.c (Qlocal, report_file_error):
3616 * w32term.c (Vwindow_system, updating_frame):
3617 * w32uniscribe.c (initialized, uniscribe_font_driver):
3618 Remove unneeded extern declarations.
3619
2aa46d6c
CY
36202011-03-14 Chong Yidong <cyd@stupidchicken.com>
3621
c96bbc66 3622 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3623
cffc6f3b
CY
36242011-03-13 Chong Yidong <cyd@stupidchicken.com>
3625
3626 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3627 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3628 These macros can no longer be used for assignment.
3629
44f230aa
SM
3630 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3631 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3632 (record_buffer_markers, fetch_buffer_markers): New functions for
3633 recording and fetching special buffer markers.
3634 (set_buffer_internal_1, set_buffer_temp): Use them.
3635
3636 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3637
3638 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3639
3640 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3641 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3642
3643 * xdisp.c (hscroll_window_tree):
3644 (reconsider_clip_changes): Use PT instead of BUF_PT.
3645
d251f04b
EZ
36462011-03-13 Eli Zaretskii <eliz@gnu.org>
3647
3648 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3649 $(EMACS_ROOT)/lib/intprops.h.
3650
f0c77cd1
PE
36512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3652
3eca4629
PE
3653 Fix more problems found by GCC 4.5.2's static checks.
3654
7c86ee98
PE
3655 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3656 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3657 (xg_free_frame_widgets): Make it clear that a local variable is
3658 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3659 (gdk_window_get_screen): Make it clear that this macro is needed
3660 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3661 (int_gtk_range_get_value): New function, which avoids a diagnostic
3662 from gcc -Wbad-function-cast.
3663 (xg_set_toolkit_scroll_bar_thumb): Use it.
3664 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3665 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3666 (get_utf8_string, xg_get_file_with_chooser):
3667 Rename locals to avoid shadowing.
3668 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3669
41729b81
PE
3670 * xgselect.c (xg_select): Remove unused var.
3671
f0c77cd1
PE
3672 * image.c (four_corners_best): Mark locals as initialized.
3673 (gif_load): Initialize transparent_p to zero (Bug#8238).
3674 Mark another local as initialized.
ec6cf4c6 3675 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3676
ce0ad53d 3677 * image.c (clear_image_cache): Now static.
d5d5a617 3678 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3679 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3680 (x_edge_detection): Remove unnecessary cast that
3681 gcc -Wbad-function-cast diagnoses.
2037898d 3682 (gif_load): Fix pointer signedness.
6ae141d6
PE
3683 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3684 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3685
33383987 36862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3687
d32df629
PE
3688 Improve quality of tests for time stamp overflow.
3689 For example, without this patch (encode-time 0 0 0 1 1
3690 1152921504606846976) returns the obviously-bogus value (-948597
3691 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3692 reports time overflow. See
3693 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3694 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3695 * editfns.c: Include limits.h and intprops.h.
3696 (TIME_T_MIN, TIME_T_MAX): New macros.
3697 (time_overflow): Move earlier, to before first use.
3698 (hi_time, lo_time): New functions, for an accurate test for
3699 out-of-range times.
3700 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3701 (Fget_internal_run_time): Don't assume time_t fits in int.
3702 (make_time): Use list2 instead of Fcons twice.
3703 (Fdecode_time): More accurate test for out-of-range times.
3704 (check_tm_member): New function.
3705 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3706 (lisp_time_argument): Don't rely on undefined left-shift and
3707 right-shift behavior when checking for time stamp overflow.
8be6f318 3708
fe31d94c
PE
3709 * editfns.c (time_overflow): New function, refactoring common code.
3710 (Fformat_time_string, Fdecode_time, Fencode_time):
3711 (Fcurrent_time_string): Use it.
3712
8be6f318
PE
3713 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3714 * dired.c (make_time): Move to ...
3715 * editfns.c (make_time): ... here.
3716 * systime.h: Note the move.
3717
09d9db2c 37182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3719
126bc0dc
YM
3720 * fringe.c (update_window_fringes): Remove unused variables.
3721
c47cbdfd
YM
3722 * unexmacosx.c (copy_data_segment): Also copy __got section.
3723 (Bug#8223)
3724
7ac80be9
EZ
37252011-03-12 Eli Zaretskii <eliz@gnu.org>
3726
c96bbc66 3727 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3728 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3729 Constify `char *' arguments and their references according to
3730 prototypes in tparam.h.
3731
ecb0f94d 3732 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3733
7ac80be9
EZ
3734 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3735 Adapt all references accordingly.
3736
3737 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3738
ef1fd07e
TT
37392011-03-11 Tom Tromey <tromey@redhat.com>
3740
3741 * buffer.c (syms_of_buffer): Remove obsolete comment.
3742
7ef4b50c
EZ
37432011-03-11 Eli Zaretskii <eliz@gnu.org>
3744
3745 * termhooks.h (encode_terminal_code): Declare prototype.
3746
3747 * msdos.c (encode_terminal_code): Don't declare prototype.
3748
3749 * term.c (encode_terminal_code): Now external again, used by
3750 w32console.c and msdos.c.
3751
44f230aa
SM
3752 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3753 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3754
4b1ec863 37552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3756
1714f52b 3757 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3758
4b1ec863
PE
3759 * fringe.c (update_window_fringes): Mark locals as initialized
3760 (Bug#8227).
3761 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3762
524c7aa6
PE
3763 * alloc.c (mark_fringe_data): Move decl from here ...
3764 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3765 to check its interface.
3766 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3767
a5c0af81 3768 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3769 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3770 (fontset_font): Mark local as initialized.
a9a06e0b 3771 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3772
b4716021
PE
3773 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3774
811e9bac 3775 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3776 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3777 (x_own_selection, Fx_disown_selection_internal): Rename locals
3778 to avoid shadowing.
3779 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3780
7e3ab302
PE
3781 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3782 so that the caller can use some name other than gcpro1.
3783 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3784 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3785 (Fx_backspace_delete_keys_p):
3786 Use them to avoid shadowing, and rename vars to avoid shadowing.
3787 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3788 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3789 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3790 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3791 Remove unused locals.
7e3ab302
PE
3792 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3793 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3794 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3795 macros.
f78faa98 3796
e2b13473
PE
3797 * xterm.h (x_mouse_leave): New decl.
3798
77f23912
PE
3799 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3800 Remove unused functions.
cdf4ba58
PE
3801 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3802 (x_calc_absolute_position): Now static.
7411c686 3803 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3804 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3805 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3806 unless they are used.
38d0b34a
PE
3807 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3808 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3809 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3810 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3811 (x_error_catcher, x_connection_closed, x_error_handler):
3812 (x_error_quitter, xembed_send_message, x_iconify_frame):
3813 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3814 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3815 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3816
44f230aa
SM
3817 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3818 Rename or move locals to avoid shadowing.
6b463e58 3819 (tty_defined_color, merge_face_heights): Now static.
5967d051 3820 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3821 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3822 does not deduce is never used uninitialized.
73719eba
PE
3823 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3824 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3825
426994c3 3826 * terminal.c (store_terminal_param): Now static.
5489860b 3827
032f1620 3828 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3829 (set_frame_menubar): Remove unused local.
d4323972 3830 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3831 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3832 since they might point to immutable storage.
281585b0
PE
3833 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3834 since it's unused otherwise.
032f1620 3835
367c19e5 3836 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3837 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3838 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3839 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3840 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3841 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3842 does not deduce are never used uninitialized.
70739cbe 3843
07b48fa9
PE
3844 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3845
8868a238 3846 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3847 * window.c (window_loop, size_window):
3848 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3849
7e5cf297 3850 * window.c (display_buffer): Now static.
d6550a9f
PE
3851 (size_window): Mark variables that gcc -Wuninitialized
3852 does not deduce are never used uninitialized.
a586633d
PE
3853 * window.h (check_all_windows): New decl, to forestall
3854 gcc -Wmissing-prototypes diagnostic.
5b555da1 3855 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3856
f6095868
PE
3857 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3858 shadowing.
3859 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3860 Include <limits.h>.
3861 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3862 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3863 (load_charset_map): Mark variables that gcc -Wuninitialized
3864 does not deduce are never used uninitialized.
53df7c11 3865 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3866
f38b440c
PE
3867 * coding.c (coding_set_source, coding_set_destination):
3868 Use "else { /* comment */ }" rather than "else /* comment */;"
3869 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3870 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3871 a block, when the outer 'i' will do.
3872 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3873 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3874 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3875 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3876 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3877 Rename locals to avoid shadowing.
3878 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3879 * coding.c (emacs_mule_char, encode_invocation_designation):
3880 Now static, since they're not used elsewhere.
413bb2db 3881 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3882 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3883 (decode_coding_emacs_mule): Mark variables that gcc
3884 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3885 (detect_coding_iso_2022): Initialize a local variable that might
3886 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3887 this initialization is needed. (Bug#8211)
5f58e762
PE
3888 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3889 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3890 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3891 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3892 Remove unused macros.
f38b440c 3893
232b38b9 3894 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3895 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3896 * character.c (string_count_byte8): Likewise.
232b38b9 3897
fb90da1b
PE
3898 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3899 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3900
fb93dbc2
PE
3901 * chartab.c (copy_sub_char_table): Now static, since it's not used
3902 elsewhere.
5c156ace
PE
3903 (sub_char_table_ref_and_range, char_table_ref_and_range):
3904 Rename locals to avoid shadowing.
bbcd0949 3905 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3906
7d3b3862 3907 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3908 (BIDI_BOB): Remove unused macro.
7d3b3862 3909
6be7d3da
PE
3910 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3911 deduce are never used uninitialized.
c2ed9c8b 3912 * term.c (encode_terminal_code): Likewise.
6be7d3da 3913
75f8807f 3914 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3915
50938595
PE
3916 * tparam.h: New file.
3917 * term.c, tparam.h: Include it.
3918 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3919 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3920 Move these decls to tparam.h, and make them agree with what
3921 is actually in tparam.c. The previous trick of using incompatible
3922 decls in different modules does not conform to the C standard.
3923 All callers of tparam changed to use tparam's actual API.
3924 * tparam.c (tparam1, tparam, tgoto):
3925 Use const pointers where appropriate.
3926
fbceeba2
PE
3927 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3928 * cm.h (struct cm): Likewise.
3929 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3930 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3931 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3932 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3933 (turn_on_face, init_tty): Likewise.
3934 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3935
7f3f1250
PE
3936 * term.c (term_mouse_position): Rename local to avoid shadowing.
3937
e6ca6543
PE
3938 * alloc.c (mark_ttys): Move decl from here ...
3939 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3940
c40f8d15
AS
39412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3942
3943 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3944
cfe0661d
JB
39452011-03-09 Juanma Barranquero <lekktu@gmail.com>
3946
3947 * search.c (compile_pattern_1): Remove argument regp, unused since
3948 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3949 (compile_pattern): Don't pass it.
3950
0afb4571
J
39512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3952
3953 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3954 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3955 for ! HAVE_GTK3.
3956 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3957
3958 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3959
3960 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3961 gdk_window_get_screen, gdk_window_get_geometry,
3962 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3963 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3964 (xg_get_pixbuf_from_pixmap): New function.
3965 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3966 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3967 Call xg_get_pixbuf_from_pixmap instead of
3968 gdk_pixbuf_get_from_drawable.
3969 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3970 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3971 (xg_check_special_colors): Use GtkStyleContext and its functions
3972 for HAVE_GTK3.
3973 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3974 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3975 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3976 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3977 Call gtk_widget_get_preferred_size.
0afb4571
J
3978 (xg_frame_resized): gdk_window_get_geometry only takes 5
3979 parameters.
44f230aa
SM
3980 (xg_win_to_widget, xg_event_is_for_menubar):
3981 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3982 (xg_set_widget_bg): New function.
3983 (delete_cb): New function.
895009e1 3984 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3985 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3986 (xg_set_background_color): Call xg_set_widget_bg.
3987 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3988 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3989 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3990 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3991 if ! HAVE_GTK3.
3992 (update_frame_tool_bar): Call gtk_widget_hide.
3993 (xg_initialize): Use GDK_KEY_g.
3994
3995 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3996 if ! HAVE_GTK3
3997 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3998
3999 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4000 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4001 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4002
1c2cc4ef
JB
40032011-03-08 Juanma Barranquero <lekktu@gmail.com>
4004
4005 * w32xfns.c (select_palette): Check success of RealizePalette against
4006 GDI_ERROR, not zero.
4007
33383987 4008See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4009
4010;; Local Variables:
4011;; coding: utf-8
aac0c6e3
MR
4012;; End:
4013
33383987 4014 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4015
4016 This file is part of GNU Emacs.
4017
4018 GNU Emacs is free software: you can redistribute it and/or modify
4019 it under the terms of the GNU General Public License as published by
4020 the Free Software Foundation, either version 3 of the License, or
4021 (at your option) any later version.
4022
4023 GNU Emacs is distributed in the hope that it will be useful,
4024 but WITHOUT ANY WARRANTY; without even the implied warranty of
4025 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4026 GNU General Public License for more details.
4027
4028 You should have received a copy of the GNU General Public License
4029 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.